{"action":"created","comment":{"url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/pulls/comments/66810825","id":66810825,"diff_hunk":"@@ -0,0 +1,112 @@\n+<?php\n+\n+/**\n+ * Copyright 2016 SURFnet B.V.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+namespace Surfnet\\Stepup\\Configuration\\Value;\n+\n+use ArrayIterator;\n+use IteratorAggregate;\n+use Surfnet\\Stepup\\Exception\\LogicException;\n+use Surfnet\\Stepup\\Configuration\\Entity\\RaLocation;\n+\n+final class RaLocationList implements IteratorAggregate\n+{\n+    /**\n+     * @var RaLocation[]\n+     */\n+    private $raLocations = [];\n+\n+    public function __construct(array $raLocations)\n+    {\n+        foreach ($raLocations as $raLocation) {\n+            $this->add($raLocation);\n+        }\n+    }\n+\n+    /**\n+     * @param RaLocationId $raLocationId\n+     * @return bool\n+     */\n+    public function hasWith(RaLocationId $raLocationId)","path":"src/Surfnet/Stepup/Configuration/Value/RaLocationList.php","position":44,"original_position":44,"commit_id":"d07346bdf3fc34114c5392fb75ec8ec1ca77aa8e","original_commit_id":"d07346bdf3fc34114c5392fb75ec8ec1ca77aa8e","user":{"login":"rjkip","id":1734555,"avatar_url":"https://avatars.githubusercontent.com/u/1734555?v=3","gravatar_id":"","url":"https://api.github.com/users/rjkip","html_url":"https://github.com/rjkip","followers_url":"https://api.github.com/users/rjkip/followers","following_url":"https://api.github.com/users/rjkip/following{/other_user}","gists_url":"https://api.github.com/users/rjkip/gists{/gist_id}","starred_url":"https://api.github.com/users/rjkip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjkip/subscriptions","organizations_url":"https://api.github.com/users/rjkip/orgs","repos_url":"https://api.github.com/users/rjkip/repos","events_url":"https://api.github.com/users/rjkip/events{/privacy}","received_events_url":"https://api.github.com/users/rjkip/received_events","type":"User","site_admin":false},"body":"`hasWith`, `removeWith`, meh. Not very common names and confusing to me at first. In collections, `has` is usually called `contains`, so maybe `containsWithId`. And I'd prefer `removeWithId`. Not sure though.","created_at":"2016-06-13T15:19:07Z","updated_at":"2016-06-13T15:19:07Z","html_url":"https://github.com/SURFnet/Stepup-Middleware/pull/118#discussion_r66810825","pull_request_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/pulls/118","_links":{"self":{"href":"https://api.github.com/repos/SURFnet/Stepup-Middleware/pulls/comments/66810825"},"html":{"href":"https://github.com/SURFnet/Stepup-Middleware/pull/118#discussion_r66810825"},"pull_request":{"href":"https://api.github.com/repos/SURFnet/Stepup-Middleware/pulls/118"}}},"pull_request":{"url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/pulls/118","id":73589479,"html_url":"https://github.com/SURFnet/Stepup-Middleware/pull/118","diff_url":"https://github.com/SURFnet/Stepup-Middleware/pull/118.diff","patch_url":"https://github.com/SURFnet/Stepup-Middleware/pull/118.patch","issue_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/issues/118","number":118,"state":"open","locked":false,"title":"Feature/ra locations model","user":{"login":"arothuis","id":3816591,"avatar_url":"https://avatars.githubusercontent.com/u/3816591?v=3","gravatar_id":"","url":"https://api.github.com/users/arothuis","html_url":"https://github.com/arothuis","followers_url":"https://api.github.com/users/arothuis/followers","following_url":"https://api.github.com/users/arothuis/following{/other_user}","gists_url":"https://api.github.com/users/arothuis/gists{/gist_id}","starred_url":"https://api.github.com/users/arothuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arothuis/subscriptions","organizations_url":"https://api.github.com/users/arothuis/orgs","repos_url":"https://api.github.com/users/arothuis/repos","events_url":"https://api.github.com/users/arothuis/events{/privacy}","received_events_url":"https://api.github.com/users/arothuis/received_events","type":"User","site_admin":false},"body":"Part of [#116602125](https://www.pivotaltracker.com/story/show/116602125).\r\n\r\nThis PR is meant to get the model right before moving on to each separate Event, Command and the handling thereof.","created_at":"2016-06-13T14:56:02Z","updated_at":"2016-06-13T15:19:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"343c6a3754495ebc5902287b6d96130dc6af081a","assignee":{"login":"relaxnow","id":524386,"avatar_url":"https://avatars.githubusercontent.com/u/524386?v=3","gravatar_id":"","url":"https://api.github.com/users/relaxnow","html_url":"https://github.com/relaxnow","followers_url":"https://api.github.com/users/relaxnow/followers","following_url":"https://api.github.com/users/relaxnow/following{/other_user}","gists_url":"https://api.github.com/users/relaxnow/gists{/gist_id}","starred_url":"https://api.github.com/users/relaxnow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/relaxnow/subscriptions","organizations_url":"https://api.github.com/users/relaxnow/orgs","repos_url":"https://api.github.com/users/relaxnow/repos","events_url":"https://api.github.com/users/relaxnow/events{/privacy}","received_events_url":"https://api.github.com/users/relaxnow/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/pulls/118/commits","review_comments_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/pulls/118/comments","review_comment_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/issues/118/comments","statuses_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/statuses/d07346bdf3fc34114c5392fb75ec8ec1ca77aa8e","head":{"label":"SURFnet:feature/ra-locations-model","ref":"feature/ra-locations-model","sha":"d07346bdf3fc34114c5392fb75ec8ec1ca77aa8e","user":{"login":"SURFnet","id":1485353,"avatar_url":"https://avatars.githubusercontent.com/u/1485353?v=3","gravatar_id":"","url":"https://api.github.com/users/SURFnet","html_url":"https://github.com/SURFnet","followers_url":"https://api.github.com/users/SURFnet/followers","following_url":"https://api.github.com/users/SURFnet/following{/other_user}","gists_url":"https://api.github.com/users/SURFnet/gists{/gist_id}","starred_url":"https://api.github.com/users/SURFnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SURFnet/subscriptions","organizations_url":"https://api.github.com/users/SURFnet/orgs","repos_url":"https://api.github.com/users/SURFnet/repos","events_url":"https://api.github.com/users/SURFnet/events{/privacy}","received_events_url":"https://api.github.com/users/SURFnet/received_events","type":"Organization","site_admin":false},"repo":{"id":23867318,"name":"Stepup-Middleware","full_name":"SURFnet/Stepup-Middleware","owner":{"login":"SURFnet","id":1485353,"avatar_url":"https://avatars.githubusercontent.com/u/1485353?v=3","gravatar_id":"","url":"https://api.github.com/users/SURFnet","html_url":"https://github.com/SURFnet","followers_url":"https://api.github.com/users/SURFnet/followers","following_url":"https://api.github.com/users/SURFnet/following{/other_user}","gists_url":"https://api.github.com/users/SURFnet/gists{/gist_id}","starred_url":"https://api.github.com/users/SURFnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SURFnet/subscriptions","organizations_url":"https://api.github.com/users/SURFnet/orgs","repos_url":"https://api.github.com/users/SURFnet/repos","events_url":"https://api.github.com/users/SURFnet/events{/privacy}","received_events_url":"https://api.github.com/users/SURFnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SURFnet/Stepup-Middleware","description":"","fork":false,"url":"https://api.github.com/repos/SURFnet/Stepup-Middleware","forks_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/forks","keys_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/teams","hooks_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/hooks","issue_events_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/issues/events{/number}","events_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/events","assignees_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/assignees{/user}","branches_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/branches{/branch}","tags_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/tags","blobs_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/git/refs{/sha}","trees_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/statuses/{sha}","languages_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/languages","stargazers_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/stargazers","contributors_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/contributors","subscribers_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/subscribers","subscription_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/subscription","commits_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/commits{/sha}","git_commits_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/git/commits{/sha}","comments_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/comments{/number}","issue_comment_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/issues/comments{/number}","contents_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/contents/{+path}","compare_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/merges","archive_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/downloads","issues_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/issues{/number}","pulls_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/pulls{/number}","milestones_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/milestones{/number}","notifications_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/labels{/name}","releases_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/releases{/id}","deployments_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/deployments","created_at":"2014-09-10T08:47:14Z","updated_at":"2016-02-19T13:15:31Z","pushed_at":"2016-06-13T14:56:02Z","git_url":"git://github.com/SURFnet/Stepup-Middleware.git","ssh_url":"git@github.com:SURFnet/Stepup-Middleware.git","clone_url":"https://github.com/SURFnet/Stepup-Middleware.git","svn_url":"https://github.com/SURFnet/Stepup-Middleware","homepage":null,"size":1580,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":2,"default_branch":"develop"}},"base":{"label":"SURFnet:develop","ref":"develop","sha":"b6516e39ec80f667f239d99bfa80b913cc1ccf1b","user":{"login":"SURFnet","id":1485353,"avatar_url":"https://avatars.githubusercontent.com/u/1485353?v=3","gravatar_id":"","url":"https://api.github.com/users/SURFnet","html_url":"https://github.com/SURFnet","followers_url":"https://api.github.com/users/SURFnet/followers","following_url":"https://api.github.com/users/SURFnet/following{/other_user}","gists_url":"https://api.github.com/users/SURFnet/gists{/gist_id}","starred_url":"https://api.github.com/users/SURFnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SURFnet/subscriptions","organizations_url":"https://api.github.com/users/SURFnet/orgs","repos_url":"https://api.github.com/users/SURFnet/repos","events_url":"https://api.github.com/users/SURFnet/events{/privacy}","received_events_url":"https://api.github.com/users/SURFnet/received_events","type":"Organization","site_admin":false},"repo":{"id":23867318,"name":"Stepup-Middleware","full_name":"SURFnet/Stepup-Middleware","owner":{"login":"SURFnet","id":1485353,"avatar_url":"https://avatars.githubusercontent.com/u/1485353?v=3","gravatar_id":"","url":"https://api.github.com/users/SURFnet","html_url":"https://github.com/SURFnet","followers_url":"https://api.github.com/users/SURFnet/followers","following_url":"https://api.github.com/users/SURFnet/following{/other_user}","gists_url":"https://api.github.com/users/SURFnet/gists{/gist_id}","starred_url":"https://api.github.com/users/SURFnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SURFnet/subscriptions","organizations_url":"https://api.github.com/users/SURFnet/orgs","repos_url":"https://api.github.com/users/SURFnet/repos","events_url":"https://api.github.com/users/SURFnet/events{/privacy}","received_events_url":"https://api.github.com/users/SURFnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SURFnet/Stepup-Middleware","description":"","fork":false,"url":"https://api.github.com/repos/SURFnet/Stepup-Middleware","forks_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/forks","keys_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/teams","hooks_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/hooks","issue_events_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/issues/events{/number}","events_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/events","assignees_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/assignees{/user}","branches_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/branches{/branch}","tags_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/tags","blobs_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/git/refs{/sha}","trees_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/statuses/{sha}","languages_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/languages","stargazers_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/stargazers","contributors_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/contributors","subscribers_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/subscribers","subscription_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/subscription","commits_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/commits{/sha}","git_commits_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/git/commits{/sha}","comments_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/comments{/number}","issue_comment_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/issues/comments{/number}","contents_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/contents/{+path}","compare_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/merges","archive_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/downloads","issues_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/issues{/number}","pulls_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/pulls{/number}","milestones_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/milestones{/number}","notifications_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/labels{/name}","releases_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/releases{/id}","deployments_url":"https://api.github.com/repos/SURFnet/Stepup-Middleware/deployments","created_at":"2014-09-10T08:47:14Z","updated_at":"2016-02-19T13:15:31Z","pushed_at":"2016-06-13T14:56:02Z","git_url":"git://github.com/SURFnet/Stepup-Middleware.git","ssh_url":"git@github.com:SURFnet/Stepup-Middleware.git","clone_url":"https://github.com/SURFnet/Stepup-Middleware.git","svn_url":"https://github.com/SURFnet/Stepup-Middleware","homepage":null,"size":1580,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/SURFnet/Stepup-Middleware/pulls/118"},"html":{"href":"https://github.com/SURFnet/Stepup-Middleware/pull/118"},"issue":{"href":"https://api.github.com/repos/SURFnet/Stepup-Middleware/issues/118"},"comments":{"href":"https://api.github.com/repos/SURFnet/Stepup-Middleware/issues/118/comments"},"review_comments":{"href":"https://api.github.com/repos/SURFnet/Stepup-Middleware/pulls/118/comments"},"review_comment":{"href":"https://api.github.com/repos/SURFnet/Stepup-Middleware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SURFnet/Stepup-Middleware/pulls/118/commits"},"statuses":{"href":"https://api.github.com/repos/SURFnet/Stepup-Middleware/statuses/d07346bdf3fc34114c5392fb75ec8ec1ca77aa8e"}}}}
{"actor":{"display_login":"rjkip"}}