{"action":"created","comment":{"url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/pulls/comments/64285130","id":64285130,"diff_hunk":"@@ -708,11 +707,7 @@ modifySDK = (sdk) ->\n       .then((result) ->\n         memberIds = result.map (member) -> member.id\n         promises.when(\n-          sdk.loadMemberEmailAddresses({memberId: memberIds})\n-          sdk.loadContactEmailAddresses({memberId: memberIds})\n-          sdk.loadContacts({memberId: memberIds})\n-          sdk.loadMemberPhoneNumbers({memberId: memberIds})\n-          sdk.loadContactPhoneNumbers({memberId: memberIds})\n+          sdk.loadMembers({id: memberIds})","path":"src/persistence.coffee","position":19,"original_position":19,"commit_id":"1e0bbf4daa2a3825abd0263eae88e43ee2f715cd","original_commit_id":"1e0bbf4daa2a3825abd0263eae88e43ee2f715cd","user":{"login":"amberwebb","id":8335640,"avatar_url":"https://avatars.githubusercontent.com/u/8335640?v=3","gravatar_id":"","url":"https://api.github.com/users/amberwebb","html_url":"https://github.com/amberwebb","followers_url":"https://api.github.com/users/amberwebb/followers","following_url":"https://api.github.com/users/amberwebb/following{/other_user}","gists_url":"https://api.github.com/users/amberwebb/gists{/gist_id}","starred_url":"https://api.github.com/users/amberwebb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amberwebb/subscriptions","organizations_url":"https://api.github.com/users/amberwebb/orgs","repos_url":"https://api.github.com/users/amberwebb/repos","events_url":"https://api.github.com/users/amberwebb/events{/privacy}","received_events_url":"https://api.github.com/users/amberwebb/received_events","type":"User","site_admin":false},"body":"And also, should contacts be loaded before `contactEmailAddresses` and `contactPhoneNumbers` ?","created_at":"2016-05-23T20:42:32Z","updated_at":"2016-05-23T20:42:32Z","html_url":"https://github.com/teamsnap/teamsnap-javascript-sdk/pull/129#discussion_r64285130","pull_request_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/pulls/129","_links":{"self":{"href":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/pulls/comments/64285130"},"html":{"href":"https://github.com/teamsnap/teamsnap-javascript-sdk/pull/129#discussion_r64285130"},"pull_request":{"href":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/pulls/129"}}},"pull_request":{"url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/pulls/129","id":71102465,"html_url":"https://github.com/teamsnap/teamsnap-javascript-sdk/pull/129","diff_url":"https://github.com/teamsnap/teamsnap-javascript-sdk/pull/129.diff","patch_url":"https://github.com/teamsnap/teamsnap-javascript-sdk/pull/129.patch","issue_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/issues/129","number":129,"state":"open","locked":false,"title":"Reload members in importMembersFromTeam","user":{"login":"amberwebb","id":8335640,"avatar_url":"https://avatars.githubusercontent.com/u/8335640?v=3","gravatar_id":"","url":"https://api.github.com/users/amberwebb","html_url":"https://github.com/amberwebb","followers_url":"https://api.github.com/users/amberwebb/followers","following_url":"https://api.github.com/users/amberwebb/following{/other_user}","gists_url":"https://api.github.com/users/amberwebb/gists{/gist_id}","starred_url":"https://api.github.com/users/amberwebb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amberwebb/subscriptions","organizations_url":"https://api.github.com/users/amberwebb/orgs","repos_url":"https://api.github.com/users/amberwebb/repos","events_url":"https://api.github.com/users/amberwebb/events{/privacy}","received_events_url":"https://api.github.com/users/amberwebb/received_events","type":"User","site_admin":false},"body":"We have an issue where member information is not displaying until after refresh of the page once `importMemberFromTeam` has been called. This is reloading the specified members to display the information in the UI.\r\n\r\nI think we could only reload the member object, not needing to reload email addresses, phone numbers or contacts in the member explicitly.","created_at":"2016-05-23T18:57:10Z","updated_at":"2016-05-23T20:42:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c10dedd964af56f82bf103727eb3446a7826d7a2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/pulls/129/commits","review_comments_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/pulls/129/comments","review_comment_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/issues/129/comments","statuses_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/statuses/1e0bbf4daa2a3825abd0263eae88e43ee2f715cd","head":{"label":"teamsnap:import-members-reload-members","ref":"import-members-reload-members","sha":"1e0bbf4daa2a3825abd0263eae88e43ee2f715cd","user":{"login":"teamsnap","id":69031,"avatar_url":"https://avatars.githubusercontent.com/u/69031?v=3","gravatar_id":"","url":"https://api.github.com/users/teamsnap","html_url":"https://github.com/teamsnap","followers_url":"https://api.github.com/users/teamsnap/followers","following_url":"https://api.github.com/users/teamsnap/following{/other_user}","gists_url":"https://api.github.com/users/teamsnap/gists{/gist_id}","starred_url":"https://api.github.com/users/teamsnap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamsnap/subscriptions","organizations_url":"https://api.github.com/users/teamsnap/orgs","repos_url":"https://api.github.com/users/teamsnap/repos","events_url":"https://api.github.com/users/teamsnap/events{/privacy}","received_events_url":"https://api.github.com/users/teamsnap/received_events","type":"Organization","site_admin":false},"repo":{"id":20901458,"name":"teamsnap-javascript-sdk","full_name":"teamsnap/teamsnap-javascript-sdk","owner":{"login":"teamsnap","id":69031,"avatar_url":"https://avatars.githubusercontent.com/u/69031?v=3","gravatar_id":"","url":"https://api.github.com/users/teamsnap","html_url":"https://github.com/teamsnap","followers_url":"https://api.github.com/users/teamsnap/followers","following_url":"https://api.github.com/users/teamsnap/following{/other_user}","gists_url":"https://api.github.com/users/teamsnap/gists{/gist_id}","starred_url":"https://api.github.com/users/teamsnap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamsnap/subscriptions","organizations_url":"https://api.github.com/users/teamsnap/orgs","repos_url":"https://api.github.com/users/teamsnap/repos","events_url":"https://api.github.com/users/teamsnap/events{/privacy}","received_events_url":"https://api.github.com/users/teamsnap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/teamsnap/teamsnap-javascript-sdk","description":"Javascript SDK for TeamSnap's APIv3","fork":false,"url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk","forks_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/forks","keys_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/teams","hooks_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/hooks","issue_events_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/events","assignees_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/tags","blobs_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/languages","stargazers_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/stargazers","contributors_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/contributors","subscribers_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/subscribers","subscription_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/subscription","commits_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/merges","archive_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/downloads","issues_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/labels{/name}","releases_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/deployments","created_at":"2014-06-16T21:28:29Z","updated_at":"2016-01-13T21:41:58Z","pushed_at":"2016-05-23T18:57:10Z","git_url":"git://github.com/teamsnap/teamsnap-javascript-sdk.git","ssh_url":"git@github.com:teamsnap/teamsnap-javascript-sdk.git","clone_url":"https://github.com/teamsnap/teamsnap-javascript-sdk.git","svn_url":"https://github.com/teamsnap/teamsnap-javascript-sdk","homepage":null,"size":1637,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":7,"forks":4,"open_issues":7,"watchers":3,"default_branch":"master"}},"base":{"label":"teamsnap:master","ref":"master","sha":"247170b14fd7224f25175979f8ea84a66dccaea5","user":{"login":"teamsnap","id":69031,"avatar_url":"https://avatars.githubusercontent.com/u/69031?v=3","gravatar_id":"","url":"https://api.github.com/users/teamsnap","html_url":"https://github.com/teamsnap","followers_url":"https://api.github.com/users/teamsnap/followers","following_url":"https://api.github.com/users/teamsnap/following{/other_user}","gists_url":"https://api.github.com/users/teamsnap/gists{/gist_id}","starred_url":"https://api.github.com/users/teamsnap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamsnap/subscriptions","organizations_url":"https://api.github.com/users/teamsnap/orgs","repos_url":"https://api.github.com/users/teamsnap/repos","events_url":"https://api.github.com/users/teamsnap/events{/privacy}","received_events_url":"https://api.github.com/users/teamsnap/received_events","type":"Organization","site_admin":false},"repo":{"id":20901458,"name":"teamsnap-javascript-sdk","full_name":"teamsnap/teamsnap-javascript-sdk","owner":{"login":"teamsnap","id":69031,"avatar_url":"https://avatars.githubusercontent.com/u/69031?v=3","gravatar_id":"","url":"https://api.github.com/users/teamsnap","html_url":"https://github.com/teamsnap","followers_url":"https://api.github.com/users/teamsnap/followers","following_url":"https://api.github.com/users/teamsnap/following{/other_user}","gists_url":"https://api.github.com/users/teamsnap/gists{/gist_id}","starred_url":"https://api.github.com/users/teamsnap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamsnap/subscriptions","organizations_url":"https://api.github.com/users/teamsnap/orgs","repos_url":"https://api.github.com/users/teamsnap/repos","events_url":"https://api.github.com/users/teamsnap/events{/privacy}","received_events_url":"https://api.github.com/users/teamsnap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/teamsnap/teamsnap-javascript-sdk","description":"Javascript SDK for TeamSnap's APIv3","fork":false,"url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk","forks_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/forks","keys_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/teams","hooks_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/hooks","issue_events_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/events","assignees_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/tags","blobs_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/languages","stargazers_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/stargazers","contributors_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/contributors","subscribers_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/subscribers","subscription_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/subscription","commits_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/merges","archive_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/downloads","issues_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/labels{/name}","releases_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/deployments","created_at":"2014-06-16T21:28:29Z","updated_at":"2016-01-13T21:41:58Z","pushed_at":"2016-05-23T18:57:10Z","git_url":"git://github.com/teamsnap/teamsnap-javascript-sdk.git","ssh_url":"git@github.com:teamsnap/teamsnap-javascript-sdk.git","clone_url":"https://github.com/teamsnap/teamsnap-javascript-sdk.git","svn_url":"https://github.com/teamsnap/teamsnap-javascript-sdk","homepage":null,"size":1637,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":7,"forks":4,"open_issues":7,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/pulls/129"},"html":{"href":"https://github.com/teamsnap/teamsnap-javascript-sdk/pull/129"},"issue":{"href":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/issues/129"},"comments":{"href":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/issues/129/comments"},"review_comments":{"href":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/pulls/129/comments"},"review_comment":{"href":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/pulls/129/commits"},"statuses":{"href":"https://api.github.com/repos/teamsnap/teamsnap-javascript-sdk/statuses/1e0bbf4daa2a3825abd0263eae88e43ee2f715cd"}}}}
{"actor":{"display_login":"amberwebb"}}