{"action":"closed","number":53,"pull_request":{"url":"https://api.github.com/repos/TNG/junit-dataprovider/pulls/53","id":43803192,"html_url":"https://github.com/TNG/junit-dataprovider/pull/53","diff_url":"https://github.com/TNG/junit-dataprovider/pull/53.diff","patch_url":"https://github.com/TNG/junit-dataprovider/pull/53.patch","issue_url":"https://api.github.com/repos/TNG/junit-dataprovider/issues/53","number":53,"state":"closed","locked":false,"title":"implemented suggestion for issue 52","user":{"login":"nikowitt","id":1472328,"avatar_url":"https://avatars.githubusercontent.com/u/1472328?v=3","gravatar_id":"","url":"https://api.github.com/users/nikowitt","html_url":"https://github.com/nikowitt","followers_url":"https://api.github.com/users/nikowitt/followers","following_url":"https://api.github.com/users/nikowitt/following{/other_user}","gists_url":"https://api.github.com/users/nikowitt/gists{/gist_id}","starred_url":"https://api.github.com/users/nikowitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikowitt/subscriptions","organizations_url":"https://api.github.com/users/nikowitt/orgs","repos_url":"https://api.github.com/users/nikowitt/repos","events_url":"https://api.github.com/users/nikowitt/events{/privacy}","received_events_url":"https://api.github.com/users/nikowitt/received_events","type":"User","site_admin":false},"body":"This change would suit our needs. By providing a additional protected method in the StringConverter, which can be injected by another constructor in DataConverter which I can instantiate in our test runner.","created_at":"2015-08-31T19:57:32Z","updated_at":"2016-02-19T21:02:23Z","closed_at":"2016-02-19T21:02:23Z","merged_at":null,"merge_commit_sha":"ec5d5bdc195886451083f0383d285c97ef630ba9","assignee":{"login":"aaschmid","id":567653,"avatar_url":"https://avatars.githubusercontent.com/u/567653?v=3","gravatar_id":"","url":"https://api.github.com/users/aaschmid","html_url":"https://github.com/aaschmid","followers_url":"https://api.github.com/users/aaschmid/followers","following_url":"https://api.github.com/users/aaschmid/following{/other_user}","gists_url":"https://api.github.com/users/aaschmid/gists{/gist_id}","starred_url":"https://api.github.com/users/aaschmid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaschmid/subscriptions","organizations_url":"https://api.github.com/users/aaschmid/orgs","repos_url":"https://api.github.com/users/aaschmid/repos","events_url":"https://api.github.com/users/aaschmid/events{/privacy}","received_events_url":"https://api.github.com/users/aaschmid/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/TNG/junit-dataprovider/pulls/53/commits","review_comments_url":"https://api.github.com/repos/TNG/junit-dataprovider/pulls/53/comments","review_comment_url":"https://api.github.com/repos/TNG/junit-dataprovider/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TNG/junit-dataprovider/issues/53/comments","statuses_url":"https://api.github.com/repos/TNG/junit-dataprovider/statuses/bc756201e95d912094d911f1bce36438c9edbe71","head":{"label":"nikowitt:master","ref":"master","sha":"bc756201e95d912094d911f1bce36438c9edbe71","user":{"login":"nikowitt","id":1472328,"avatar_url":"https://avatars.githubusercontent.com/u/1472328?v=3","gravatar_id":"","url":"https://api.github.com/users/nikowitt","html_url":"https://github.com/nikowitt","followers_url":"https://api.github.com/users/nikowitt/followers","following_url":"https://api.github.com/users/nikowitt/following{/other_user}","gists_url":"https://api.github.com/users/nikowitt/gists{/gist_id}","starred_url":"https://api.github.com/users/nikowitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikowitt/subscriptions","organizations_url":"https://api.github.com/users/nikowitt/orgs","repos_url":"https://api.github.com/users/nikowitt/repos","events_url":"https://api.github.com/users/nikowitt/events{/privacy}","received_events_url":"https://api.github.com/users/nikowitt/received_events","type":"User","site_admin":false},"repo":{"id":41696764,"name":"junit-dataprovider","full_name":"nikowitt/junit-dataprovider","owner":{"login":"nikowitt","id":1472328,"avatar_url":"https://avatars.githubusercontent.com/u/1472328?v=3","gravatar_id":"","url":"https://api.github.com/users/nikowitt","html_url":"https://github.com/nikowitt","followers_url":"https://api.github.com/users/nikowitt/followers","following_url":"https://api.github.com/users/nikowitt/following{/other_user}","gists_url":"https://api.github.com/users/nikowitt/gists{/gist_id}","starred_url":"https://api.github.com/users/nikowitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikowitt/subscriptions","organizations_url":"https://api.github.com/users/nikowitt/orgs","repos_url":"https://api.github.com/users/nikowitt/repos","events_url":"https://api.github.com/users/nikowitt/events{/privacy}","received_events_url":"https://api.github.com/users/nikowitt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nikowitt/junit-dataprovider","description":"A TestNG like dataprovider runner for JUnit","fork":true,"url":"https://api.github.com/repos/nikowitt/junit-dataprovider","forks_url":"https://api.github.com/repos/nikowitt/junit-dataprovider/forks","keys_url":"https://api.github.com/repos/nikowitt/junit-dataprovider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nikowitt/junit-dataprovider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nikowitt/junit-dataprovider/teams","hooks_url":"https://api.github.com/repos/nikowitt/junit-dataprovider/hooks","issue_events_url":"https://api.github.com/repos/nikowitt/junit-dataprovider/issues/events{/number}","events_url":"https://api.github.com/repos/nikowitt/junit-dataprovider/events","assignees_url":"https://api.github.com/repos/nikowitt/junit-dataprovider/assignees{/user}","branches_url":"https://api.github.com/repos/nikowitt/junit-dataprovider/branches{/branch}","tags_url":"https://api.github.com/repos/nikowitt/junit-dataprovider/tags","blobs_url":"https://api.github.com/repos/nikowitt/junit-dataprovider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nikowitt/junit-dataprovider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nikowitt/junit-dataprovider/git/refs{/sha}","trees_url":"https://api.github.com/repos/nikowitt/junit-dataprovider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nikowitt/junit-dataprovider/statuses/{sha}","languages_url":"https://api.github.com/repos/nikowitt/junit-dataprovider/languages","stargazers_url":"https://api.github.com/repos/nikowitt/junit-dataprovider/stargazers","contributors_url":"https://api.github.com/repos/nikowitt/junit-dataprovider/contributors","subscribers_url":"https://api.github.com/repos/nikowitt/junit-dataprovider/subscribers","subscription_url":"https://api.github.com/repos/nikowitt/junit-dataprovider/subscription","commits_url":"https://api.github.com/repos/nikowitt/junit-dataprovider/commits{/sha}","git_commits_url":"https://api.github.com/repos/nikowitt/junit-dataprovider/git/commits{/sha}","comments_url":"https://api.github.com/repos/nikowitt/junit-dataprovider/comments{/number}","issue_comment_url":"https://api.github.com/repos/nikowitt/junit-dataprovider/issues/comments{/number}","contents_url":"https://api.github.com/repos/nikowitt/junit-dataprovider/contents/{+path}","compare_url":"https://api.github.com/repos/nikowitt/junit-dataprovider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nikowitt/junit-dataprovider/merges","archive_url":"https://api.github.com/repos/nikowitt/junit-dataprovider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nikowitt/junit-dataprovider/downloads","issues_url":"https://api.github.com/repos/nikowitt/junit-dataprovider/issues{/number}","pulls_url":"https://api.github.com/repos/nikowitt/junit-dataprovider/pulls{/number}","milestones_url":"https://api.github.com/repos/nikowitt/junit-dataprovider/milestones{/number}","notifications_url":"https://api.github.com/repos/nikowitt/junit-dataprovider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nikowitt/junit-dataprovider/labels{/name}","releases_url":"https://api.github.com/repos/nikowitt/junit-dataprovider/releases{/id}","deployments_url":"https://api.github.com/repos/nikowitt/junit-dataprovider/deployments","created_at":"2015-08-31T19:43:49Z","updated_at":"2015-08-31T19:43:49Z","pushed_at":"2015-10-02T09:14:23Z","git_url":"git://github.com/nikowitt/junit-dataprovider.git","ssh_url":"git@github.com:nikowitt/junit-dataprovider.git","clone_url":"https://github.com/nikowitt/junit-dataprovider.git","svn_url":"https://github.com/nikowitt/junit-dataprovider","homepage":null,"size":828,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TNG:master","ref":"master","sha":"2f841b313ceca7a5d107b18506e0c134990e3dc8","user":{"login":"TNG","id":432256,"avatar_url":"https://avatars.githubusercontent.com/u/432256?v=3","gravatar_id":"","url":"https://api.github.com/users/TNG","html_url":"https://github.com/TNG","followers_url":"https://api.github.com/users/TNG/followers","following_url":"https://api.github.com/users/TNG/following{/other_user}","gists_url":"https://api.github.com/users/TNG/gists{/gist_id}","starred_url":"https://api.github.com/users/TNG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TNG/subscriptions","organizations_url":"https://api.github.com/users/TNG/orgs","repos_url":"https://api.github.com/users/TNG/repos","events_url":"https://api.github.com/users/TNG/events{/privacy}","received_events_url":"https://api.github.com/users/TNG/received_events","type":"Organization","site_admin":false},"repo":{"id":8175611,"name":"junit-dataprovider","full_name":"TNG/junit-dataprovider","owner":{"login":"TNG","id":432256,"avatar_url":"https://avatars.githubusercontent.com/u/432256?v=3","gravatar_id":"","url":"https://api.github.com/users/TNG","html_url":"https://github.com/TNG","followers_url":"https://api.github.com/users/TNG/followers","following_url":"https://api.github.com/users/TNG/following{/other_user}","gists_url":"https://api.github.com/users/TNG/gists{/gist_id}","starred_url":"https://api.github.com/users/TNG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TNG/subscriptions","organizations_url":"https://api.github.com/users/TNG/orgs","repos_url":"https://api.github.com/users/TNG/repos","events_url":"https://api.github.com/users/TNG/events{/privacy}","received_events_url":"https://api.github.com/users/TNG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TNG/junit-dataprovider","description":"A TestNG like dataprovider runner for JUnit","fork":false,"url":"https://api.github.com/repos/TNG/junit-dataprovider","forks_url":"https://api.github.com/repos/TNG/junit-dataprovider/forks","keys_url":"https://api.github.com/repos/TNG/junit-dataprovider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TNG/junit-dataprovider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TNG/junit-dataprovider/teams","hooks_url":"https://api.github.com/repos/TNG/junit-dataprovider/hooks","issue_events_url":"https://api.github.com/repos/TNG/junit-dataprovider/issues/events{/number}","events_url":"https://api.github.com/repos/TNG/junit-dataprovider/events","assignees_url":"https://api.github.com/repos/TNG/junit-dataprovider/assignees{/user}","branches_url":"https://api.github.com/repos/TNG/junit-dataprovider/branches{/branch}","tags_url":"https://api.github.com/repos/TNG/junit-dataprovider/tags","blobs_url":"https://api.github.com/repos/TNG/junit-dataprovider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TNG/junit-dataprovider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TNG/junit-dataprovider/git/refs{/sha}","trees_url":"https://api.github.com/repos/TNG/junit-dataprovider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TNG/junit-dataprovider/statuses/{sha}","languages_url":"https://api.github.com/repos/TNG/junit-dataprovider/languages","stargazers_url":"https://api.github.com/repos/TNG/junit-dataprovider/stargazers","contributors_url":"https://api.github.com/repos/TNG/junit-dataprovider/contributors","subscribers_url":"https://api.github.com/repos/TNG/junit-dataprovider/subscribers","subscription_url":"https://api.github.com/repos/TNG/junit-dataprovider/subscription","commits_url":"https://api.github.com/repos/TNG/junit-dataprovider/commits{/sha}","git_commits_url":"https://api.github.com/repos/TNG/junit-dataprovider/git/commits{/sha}","comments_url":"https://api.github.com/repos/TNG/junit-dataprovider/comments{/number}","issue_comment_url":"https://api.github.com/repos/TNG/junit-dataprovider/issues/comments{/number}","contents_url":"https://api.github.com/repos/TNG/junit-dataprovider/contents/{+path}","compare_url":"https://api.github.com/repos/TNG/junit-dataprovider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TNG/junit-dataprovider/merges","archive_url":"https://api.github.com/repos/TNG/junit-dataprovider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TNG/junit-dataprovider/downloads","issues_url":"https://api.github.com/repos/TNG/junit-dataprovider/issues{/number}","pulls_url":"https://api.github.com/repos/TNG/junit-dataprovider/pulls{/number}","milestones_url":"https://api.github.com/repos/TNG/junit-dataprovider/milestones{/number}","notifications_url":"https://api.github.com/repos/TNG/junit-dataprovider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TNG/junit-dataprovider/labels{/name}","releases_url":"https://api.github.com/repos/TNG/junit-dataprovider/releases{/id}","deployments_url":"https://api.github.com/repos/TNG/junit-dataprovider/deployments","created_at":"2013-02-13T08:19:00Z","updated_at":"2016-02-16T20:45:28Z","pushed_at":"2016-02-19T19:43:05Z","git_url":"git://github.com/TNG/junit-dataprovider.git","ssh_url":"git@github.com:TNG/junit-dataprovider.git","clone_url":"https://github.com/TNG/junit-dataprovider.git","svn_url":"https://github.com/TNG/junit-dataprovider","homepage":null,"size":579,"stargazers_count":67,"watchers_count":67,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":8,"forks":13,"open_issues":8,"watchers":67,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TNG/junit-dataprovider/pulls/53"},"html":{"href":"https://github.com/TNG/junit-dataprovider/pull/53"},"issue":{"href":"https://api.github.com/repos/TNG/junit-dataprovider/issues/53"},"comments":{"href":"https://api.github.com/repos/TNG/junit-dataprovider/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/TNG/junit-dataprovider/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/TNG/junit-dataprovider/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TNG/junit-dataprovider/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/TNG/junit-dataprovider/statuses/bc756201e95d912094d911f1bce36438c9edbe71"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":0,"review_comments":0,"commits":4,"additions":823,"deletions":471,"changed_files":6}}