{"action":"created","comment":{"url":"https://api.github.com/repos/dealii/dealii/pulls/comments/86668861","pull_request_review_id":7317768,"id":86668861,"diff_hunk":"@@ -516,22 +515,23 @@ void PreconditionBlock<MatrixType,inverse_type>::invert_diagblocks()\n \n template <typename MatrixType, typename inverse_type>\n void PreconditionBlock<MatrixType,inverse_type>::set_permutation\n-(const std::vector<size_type> &p,\n- const std::vector<size_type> &i)\n+(const std::vector<size_type> &new_permutation,\n+ const std::vector<size_type> &new_inverse_permutation)\n {\n-  Assert (p.size() == i.size(), ExcDimensionMismatch(p.size(), i.size()));\n+  AssertDimension (new_permutation.size(),\n+                   new_inverse_permutation.size());\n \n   if (this->inverses_ready())\n     {\n-      AssertDimension(p.size(), this->size());\n+      AssertDimension(new_permutation.size(), this->size());\n     }\n \n-  permutation.resize(p.size());\n-  inverse_permutation.resize(p.size());\n-  for (unsigned int k=0; k<p.size(); ++k)\n+  permutation.resize(new_permutation.size());\n+  inverse_permutation.resize(new_permutation.size());\n+  for (unsigned int k=0; k<new_permutation.size(); ++k)\n     {\n-      permutation[k] = p[k];\n-      inverse_permutation[k] = i[k];\n+      permutation[k] = new_permutation[k];\n+      inverse_permutation[k] = new_inverse_permutation[k];","path":"include/deal.II/lac/precondition_block.templates.h","position":71,"original_position":71,"commit_id":"cf96488684d91c7382fc6f8298282ccf25c046a2","original_commit_id":"cf96488684d91c7382fc6f8298282ccf25c046a2","user":{"login":"kronbichler","id":8276200,"avatar_url":"https://avatars.githubusercontent.com/u/8276200?v=3","gravatar_id":"","url":"https://api.github.com/users/kronbichler","html_url":"https://github.com/kronbichler","followers_url":"https://api.github.com/users/kronbichler/followers","following_url":"https://api.github.com/users/kronbichler/following{/other_user}","gists_url":"https://api.github.com/users/kronbichler/gists{/gist_id}","starred_url":"https://api.github.com/users/kronbichler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kronbichler/subscriptions","organizations_url":"https://api.github.com/users/kronbichler/orgs","repos_url":"https://api.github.com/users/kronbichler/repos","events_url":"https://api.github.com/users/kronbichler/events{/privacy}","received_events_url":"https://api.github.com/users/kronbichler/received_events","type":"User","site_admin":false},"body":"Can't you just call\r\n```\r\npermutation = new_permutation;\r\ninverse_permutation = new_inverse_permutation;\r\n```\r\nThis would safe a few lines.","created_at":"2016-11-05T16:43:25Z","updated_at":"2016-11-05T16:43:25Z","html_url":"https://github.com/dealii/dealii/pull/3473#discussion_r86668861","pull_request_url":"https://api.github.com/repos/dealii/dealii/pulls/3473","_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments/86668861"},"html":{"href":"https://github.com/dealii/dealii/pull/3473#discussion_r86668861"},"pull_request":{"href":"https://api.github.com/repos/dealii/dealii/pulls/3473"}}},"pull_request":{"url":"https://api.github.com/repos/dealii/dealii/pulls/3473","id":92455948,"html_url":"https://github.com/dealii/dealii/pull/3473","diff_url":"https://github.com/dealii/dealii/pull/3473.diff","patch_url":"https://github.com/dealii/dealii/pull/3473.patch","issue_url":"https://api.github.com/repos/dealii/dealii/issues/3473","number":3473,"state":"open","locked":false,"title":"Pvs precondition block","user":{"login":"drwells","id":3917035,"avatar_url":"https://avatars.githubusercontent.com/u/3917035?v=3","gravatar_id":"","url":"https://api.github.com/users/drwells","html_url":"https://github.com/drwells","followers_url":"https://api.github.com/users/drwells/followers","following_url":"https://api.github.com/users/drwells/following{/other_user}","gists_url":"https://api.github.com/users/drwells/gists{/gist_id}","starred_url":"https://api.github.com/users/drwells/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drwells/subscriptions","organizations_url":"https://api.github.com/users/drwells/orgs","repos_url":"https://api.github.com/users/drwells/repos","events_url":"https://api.github.com/users/drwells/events{/privacy}","received_events_url":"https://api.github.com/users/drwells/received_events","type":"User","site_admin":false},"body":"Fixes #3362.","created_at":"2016-11-05T15:00:48Z","updated_at":"2016-11-05T16:43:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66f0b9c8d2127c3905f7573ca6ce3fd921df8673","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dealii/dealii/pulls/3473/commits","review_comments_url":"https://api.github.com/repos/dealii/dealii/pulls/3473/comments","review_comment_url":"https://api.github.com/repos/dealii/dealii/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dealii/dealii/issues/3473/comments","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/cf96488684d91c7382fc6f8298282ccf25c046a2","head":{"label":"drwells:pvs-precondition-block","ref":"pvs-precondition-block","sha":"cf96488684d91c7382fc6f8298282ccf25c046a2","user":{"login":"drwells","id":3917035,"avatar_url":"https://avatars.githubusercontent.com/u/3917035?v=3","gravatar_id":"","url":"https://api.github.com/users/drwells","html_url":"https://github.com/drwells","followers_url":"https://api.github.com/users/drwells/followers","following_url":"https://api.github.com/users/drwells/following{/other_user}","gists_url":"https://api.github.com/users/drwells/gists{/gist_id}","starred_url":"https://api.github.com/users/drwells/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drwells/subscriptions","organizations_url":"https://api.github.com/users/drwells/orgs","repos_url":"https://api.github.com/users/drwells/repos","events_url":"https://api.github.com/users/drwells/events{/privacy}","received_events_url":"https://api.github.com/users/drwells/received_events","type":"User","site_admin":false},"repo":{"id":28924344,"name":"dealii","full_name":"drwells/dealii","owner":{"login":"drwells","id":3917035,"avatar_url":"https://avatars.githubusercontent.com/u/3917035?v=3","gravatar_id":"","url":"https://api.github.com/users/drwells","html_url":"https://github.com/drwells","followers_url":"https://api.github.com/users/drwells/followers","following_url":"https://api.github.com/users/drwells/following{/other_user}","gists_url":"https://api.github.com/users/drwells/gists{/gist_id}","starred_url":"https://api.github.com/users/drwells/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drwells/subscriptions","organizations_url":"https://api.github.com/users/drwells/orgs","repos_url":"https://api.github.com/users/drwells/repos","events_url":"https://api.github.com/users/drwells/events{/privacy}","received_events_url":"https://api.github.com/users/drwells/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drwells/dealii","description":"The development repository for the deal.II finite element library.","fork":true,"url":"https://api.github.com/repos/drwells/dealii","forks_url":"https://api.github.com/repos/drwells/dealii/forks","keys_url":"https://api.github.com/repos/drwells/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drwells/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drwells/dealii/teams","hooks_url":"https://api.github.com/repos/drwells/dealii/hooks","issue_events_url":"https://api.github.com/repos/drwells/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/drwells/dealii/events","assignees_url":"https://api.github.com/repos/drwells/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/drwells/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/drwells/dealii/tags","blobs_url":"https://api.github.com/repos/drwells/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drwells/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drwells/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/drwells/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drwells/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/drwells/dealii/languages","stargazers_url":"https://api.github.com/repos/drwells/dealii/stargazers","contributors_url":"https://api.github.com/repos/drwells/dealii/contributors","subscribers_url":"https://api.github.com/repos/drwells/dealii/subscribers","subscription_url":"https://api.github.com/repos/drwells/dealii/subscription","commits_url":"https://api.github.com/repos/drwells/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/drwells/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/drwells/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/drwells/dealii/issues/comments{/number}","contents_url":"https://api.github.com/repos/drwells/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/drwells/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drwells/dealii/merges","archive_url":"https://api.github.com/repos/drwells/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drwells/dealii/downloads","issues_url":"https://api.github.com/repos/drwells/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/drwells/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/drwells/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/drwells/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drwells/dealii/labels{/name}","releases_url":"https://api.github.com/repos/drwells/dealii/releases{/id}","deployments_url":"https://api.github.com/repos/drwells/dealii/deployments","created_at":"2015-01-07T17:03:37Z","updated_at":"2016-02-12T16:15:57Z","pushed_at":"2016-11-05T15:46:45Z","git_url":"git://github.com/drwells/dealii.git","ssh_url":"git@github.com:drwells/dealii.git","clone_url":"https://github.com/drwells/dealii.git","svn_url":"https://github.com/drwells/dealii","homepage":"http://www.dealii.org/","size":150221,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dealii:master","ref":"master","sha":"f1994e04695ea1ea035e89f5b0038212d948b213","user":{"login":"dealii","id":7506070,"avatar_url":"https://avatars.githubusercontent.com/u/7506070?v=3","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"repo":{"id":21943980,"name":"dealii","full_name":"dealii/dealii","owner":{"login":"dealii","id":7506070,"avatar_url":"https://avatars.githubusercontent.com/u/7506070?v=3","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dealii/dealii","description":"The development repository for the deal.II finite element library.","fork":false,"url":"https://api.github.com/repos/dealii/dealii","forks_url":"https://api.github.com/repos/dealii/dealii/forks","keys_url":"https://api.github.com/repos/dealii/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dealii/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dealii/dealii/teams","hooks_url":"https://api.github.com/repos/dealii/dealii/hooks","issue_events_url":"https://api.github.com/repos/dealii/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/dealii/dealii/events","assignees_url":"https://api.github.com/repos/dealii/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/dealii/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/dealii/dealii/tags","blobs_url":"https://api.github.com/repos/dealii/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dealii/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dealii/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/dealii/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/dealii/dealii/languages","stargazers_url":"https://api.github.com/repos/dealii/dealii/stargazers","contributors_url":"https://api.github.com/repos/dealii/dealii/contributors","subscribers_url":"https://api.github.com/repos/dealii/dealii/subscribers","subscription_url":"https://api.github.com/repos/dealii/dealii/subscription","commits_url":"https://api.github.com/repos/dealii/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/dealii/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/dealii/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/dealii/dealii/issues/comments{/number}","contents_url":"https://api.github.com/repos/dealii/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/dealii/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dealii/dealii/merges","archive_url":"https://api.github.com/repos/dealii/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dealii/dealii/downloads","issues_url":"https://api.github.com/repos/dealii/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/dealii/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/dealii/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/dealii/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dealii/dealii/labels{/name}","releases_url":"https://api.github.com/repos/dealii/dealii/releases{/id}","deployments_url":"https://api.github.com/repos/dealii/dealii/deployments","created_at":"2014-07-17T14:00:26Z","updated_at":"2016-11-03T08:21:56Z","pushed_at":"2016-11-05T16:41:25Z","git_url":"git://github.com/dealii/dealii.git","ssh_url":"git@github.com:dealii/dealii.git","clone_url":"https://github.com/dealii/dealii.git","svn_url":"https://github.com/dealii/dealii","homepage":"http://www.dealii.org/","size":171694,"stargazers_count":183,"watchers_count":183,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":190,"mirror_url":null,"open_issues_count":223,"forks":190,"open_issues":223,"watchers":183,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/3473"},"html":{"href":"https://github.com/dealii/dealii/pull/3473"},"issue":{"href":"https://api.github.com/repos/dealii/dealii/issues/3473"},"comments":{"href":"https://api.github.com/repos/dealii/dealii/issues/3473/comments"},"review_comments":{"href":"https://api.github.com/repos/dealii/dealii/pulls/3473/comments"},"review_comment":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dealii/dealii/pulls/3473/commits"},"statuses":{"href":"https://api.github.com/repos/dealii/dealii/statuses/cf96488684d91c7382fc6f8298282ccf25c046a2"}}}}
{"actor":{"display_login":"kronbichler"}}