{"action":"created","comment":{"url":"https://api.github.com/repos/akka/akka/pulls/comments/81776780","pull_request_review_id":2731529,"id":81776780,"diff_hunk":"@@ -17,7 +17,7 @@ trait CurrentEventsByTagQuery extends ReadJournal {\n    * is completed immediately when it reaches the end of the \"result set\". Events that are\n    * stored after the query is completed are not included in the event stream.\n    */\n-  def currentEventsByTag(tag: String, offset: Long): Source[EventEnvelope, NotUsed]\n+  def currentEventsByTag(tag: String, offset: Offset): Source[EventEnvelope, NotUsed]","path":"akka-persistence-query/src/main/scala/akka/persistence/query/scaladsl/CurrentEventsByTagQuery.scala","position":5,"original_position":5,"commit_id":"8d6bc969a1ac1d34e21f39bcf19cd448fc705075","original_commit_id":"8d6bc969a1ac1d34e21f39bcf19cd448fc705075","user":{"login":"patriknw","id":336161,"avatar_url":"https://avatars.githubusercontent.com/u/336161?v=3","gravatar_id":"","url":"https://api.github.com/users/patriknw","html_url":"https://github.com/patriknw","followers_url":"https://api.github.com/users/patriknw/followers","following_url":"https://api.github.com/users/patriknw/following{/other_user}","gists_url":"https://api.github.com/users/patriknw/gists{/gist_id}","starred_url":"https://api.github.com/users/patriknw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patriknw/subscriptions","organizations_url":"https://api.github.com/users/patriknw/orgs","repos_url":"https://api.github.com/users/patriknw/repos","events_url":"https://api.github.com/users/patriknw/events{/privacy}","received_events_url":"https://api.github.com/users/patriknw/received_events","type":"User","site_admin":false},"body":"One topic for discussion is how we shall introduce this change without breaking plugins.\r\nWe can change the API, since persistence-qurey is experimental, but I think it can cause unnecessary trouble to do that in a 2.4.x. When we release Akka 2.5 we can change the API before removing the experimental label.\r\n\r\nOne way would be to add `CurrentEventsByTagQuery2` with the new signatures. Then in 2.5 we make that the only trait (and rename it to `CurrentEventsByTagQuery`).","created_at":"2016-10-04T14:59:13Z","updated_at":"2016-10-04T14:59:13Z","html_url":"https://github.com/akka/akka/pull/21615#discussion_r81776780","pull_request_url":"https://api.github.com/repos/akka/akka/pulls/21615","_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/comments/81776780"},"html":{"href":"https://github.com/akka/akka/pull/21615#discussion_r81776780"},"pull_request":{"href":"https://api.github.com/repos/akka/akka/pulls/21615"}}},"pull_request":{"url":"https://api.github.com/repos/akka/akka/pulls/21615","id":87752913,"html_url":"https://github.com/akka/akka/pull/21615","diff_url":"https://github.com/akka/akka/pull/21615.diff","patch_url":"https://github.com/akka/akka/pull/21615.patch","issue_url":"https://api.github.com/repos/akka/akka/issues/21615","number":21615,"state":"open","locked":false,"title":"eventsByTag and currentEventsByTag to use Offset","user":{"login":"richard-imaoka","id":7414320,"avatar_url":"https://avatars.githubusercontent.com/u/7414320?v=3","gravatar_id":"","url":"https://api.github.com/users/richard-imaoka","html_url":"https://github.com/richard-imaoka","followers_url":"https://api.github.com/users/richard-imaoka/followers","following_url":"https://api.github.com/users/richard-imaoka/following{/other_user}","gists_url":"https://api.github.com/users/richard-imaoka/gists{/gist_id}","starred_url":"https://api.github.com/users/richard-imaoka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richard-imaoka/subscriptions","organizations_url":"https://api.github.com/users/richard-imaoka/orgs","repos_url":"https://api.github.com/users/richard-imaoka/repos","events_url":"https://api.github.com/users/richard-imaoka/events{/privacy}","received_events_url":"https://api.github.com/users/richard-imaoka/received_events","type":"User","site_admin":false},"body":"Refs #21283\r\n\r\nAs discussed in the above issue, I didn't implement other offset than long (Sequence) for LevelDB journal.\r\n\r\nI did my best for javadsl.Offset and scaladsl.Offset, but not sure if that's the correct way... please let me know if I should do them differently.","created_at":"2016-10-03T17:02:23Z","updated_at":"2016-10-04T15:01:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79f0ae689664283a10daeb60e880b6a53ba72d90","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/akka/akka/pulls/21615/commits","review_comments_url":"https://api.github.com/repos/akka/akka/pulls/21615/comments","review_comment_url":"https://api.github.com/repos/akka/akka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akka/akka/issues/21615/comments","statuses_url":"https://api.github.com/repos/akka/akka/statuses/8d6bc969a1ac1d34e21f39bcf19cd448fc705075","head":{"label":"richard-imaoka:wip-21283-persistence-offset-richard-imaoka","ref":"wip-21283-persistence-offset-richard-imaoka","sha":"8d6bc969a1ac1d34e21f39bcf19cd448fc705075","user":{"login":"richard-imaoka","id":7414320,"avatar_url":"https://avatars.githubusercontent.com/u/7414320?v=3","gravatar_id":"","url":"https://api.github.com/users/richard-imaoka","html_url":"https://github.com/richard-imaoka","followers_url":"https://api.github.com/users/richard-imaoka/followers","following_url":"https://api.github.com/users/richard-imaoka/following{/other_user}","gists_url":"https://api.github.com/users/richard-imaoka/gists{/gist_id}","starred_url":"https://api.github.com/users/richard-imaoka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richard-imaoka/subscriptions","organizations_url":"https://api.github.com/users/richard-imaoka/orgs","repos_url":"https://api.github.com/users/richard-imaoka/repos","events_url":"https://api.github.com/users/richard-imaoka/events{/privacy}","received_events_url":"https://api.github.com/users/richard-imaoka/received_events","type":"User","site_admin":false},"repo":{"id":52724785,"name":"akka","full_name":"richard-imaoka/akka","owner":{"login":"richard-imaoka","id":7414320,"avatar_url":"https://avatars.githubusercontent.com/u/7414320?v=3","gravatar_id":"","url":"https://api.github.com/users/richard-imaoka","html_url":"https://github.com/richard-imaoka","followers_url":"https://api.github.com/users/richard-imaoka/followers","following_url":"https://api.github.com/users/richard-imaoka/following{/other_user}","gists_url":"https://api.github.com/users/richard-imaoka/gists{/gist_id}","starred_url":"https://api.github.com/users/richard-imaoka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richard-imaoka/subscriptions","organizations_url":"https://api.github.com/users/richard-imaoka/orgs","repos_url":"https://api.github.com/users/richard-imaoka/repos","events_url":"https://api.github.com/users/richard-imaoka/events{/privacy}","received_events_url":"https://api.github.com/users/richard-imaoka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/richard-imaoka/akka","description":"Akka Project","fork":true,"url":"https://api.github.com/repos/richard-imaoka/akka","forks_url":"https://api.github.com/repos/richard-imaoka/akka/forks","keys_url":"https://api.github.com/repos/richard-imaoka/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/richard-imaoka/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/richard-imaoka/akka/teams","hooks_url":"https://api.github.com/repos/richard-imaoka/akka/hooks","issue_events_url":"https://api.github.com/repos/richard-imaoka/akka/issues/events{/number}","events_url":"https://api.github.com/repos/richard-imaoka/akka/events","assignees_url":"https://api.github.com/repos/richard-imaoka/akka/assignees{/user}","branches_url":"https://api.github.com/repos/richard-imaoka/akka/branches{/branch}","tags_url":"https://api.github.com/repos/richard-imaoka/akka/tags","blobs_url":"https://api.github.com/repos/richard-imaoka/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/richard-imaoka/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/richard-imaoka/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/richard-imaoka/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/richard-imaoka/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/richard-imaoka/akka/languages","stargazers_url":"https://api.github.com/repos/richard-imaoka/akka/stargazers","contributors_url":"https://api.github.com/repos/richard-imaoka/akka/contributors","subscribers_url":"https://api.github.com/repos/richard-imaoka/akka/subscribers","subscription_url":"https://api.github.com/repos/richard-imaoka/akka/subscription","commits_url":"https://api.github.com/repos/richard-imaoka/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/richard-imaoka/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/richard-imaoka/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/richard-imaoka/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/richard-imaoka/akka/contents/{+path}","compare_url":"https://api.github.com/repos/richard-imaoka/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/richard-imaoka/akka/merges","archive_url":"https://api.github.com/repos/richard-imaoka/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/richard-imaoka/akka/downloads","issues_url":"https://api.github.com/repos/richard-imaoka/akka/issues{/number}","pulls_url":"https://api.github.com/repos/richard-imaoka/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/richard-imaoka/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/richard-imaoka/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/richard-imaoka/akka/labels{/name}","releases_url":"https://api.github.com/repos/richard-imaoka/akka/releases{/id}","deployments_url":"https://api.github.com/repos/richard-imaoka/akka/deployments","created_at":"2016-02-28T14:20:39Z","updated_at":"2016-02-28T14:20:52Z","pushed_at":"2016-10-04T13:26:59Z","git_url":"git://github.com/richard-imaoka/akka.git","ssh_url":"git@github.com:richard-imaoka/akka.git","clone_url":"https://github.com/richard-imaoka/akka.git","svn_url":"https://github.com/richard-imaoka/akka","homepage":"http://akka.io","size":190331,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"akka:master","ref":"master","sha":"6fea2f3526ded34efeb586a3952d11d843ebac69","user":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":130013,"name":"akka","full_name":"akka/akka","owner":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akka/akka","description":"Akka Project","fork":false,"url":"https://api.github.com/repos/akka/akka","forks_url":"https://api.github.com/repos/akka/akka/forks","keys_url":"https://api.github.com/repos/akka/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/akka/teams","hooks_url":"https://api.github.com/repos/akka/akka/hooks","issue_events_url":"https://api.github.com/repos/akka/akka/issues/events{/number}","events_url":"https://api.github.com/repos/akka/akka/events","assignees_url":"https://api.github.com/repos/akka/akka/assignees{/user}","branches_url":"https://api.github.com/repos/akka/akka/branches{/branch}","tags_url":"https://api.github.com/repos/akka/akka/tags","blobs_url":"https://api.github.com/repos/akka/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/akka/languages","stargazers_url":"https://api.github.com/repos/akka/akka/stargazers","contributors_url":"https://api.github.com/repos/akka/akka/contributors","subscribers_url":"https://api.github.com/repos/akka/akka/subscribers","subscription_url":"https://api.github.com/repos/akka/akka/subscription","commits_url":"https://api.github.com/repos/akka/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/akka/akka/contents/{+path}","compare_url":"https://api.github.com/repos/akka/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/akka/merges","archive_url":"https://api.github.com/repos/akka/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/akka/downloads","issues_url":"https://api.github.com/repos/akka/akka/issues{/number}","pulls_url":"https://api.github.com/repos/akka/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/akka/labels{/name}","releases_url":"https://api.github.com/repos/akka/akka/releases{/id}","deployments_url":"https://api.github.com/repos/akka/akka/deployments","created_at":"2009-02-16T12:51:54Z","updated_at":"2016-10-04T14:17:25Z","pushed_at":"2016-10-04T13:27:04Z","git_url":"git://github.com/akka/akka.git","ssh_url":"git@github.com:akka/akka.git","clone_url":"https://github.com/akka/akka.git","svn_url":"https://github.com/akka/akka","homepage":"http://akka.io","size":231034,"stargazers_count":6102,"watchers_count":6102,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1940,"mirror_url":null,"open_issues_count":523,"forks":1940,"open_issues":523,"watchers":6102,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/21615"},"html":{"href":"https://github.com/akka/akka/pull/21615"},"issue":{"href":"https://api.github.com/repos/akka/akka/issues/21615"},"comments":{"href":"https://api.github.com/repos/akka/akka/issues/21615/comments"},"review_comments":{"href":"https://api.github.com/repos/akka/akka/pulls/21615/comments"},"review_comment":{"href":"https://api.github.com/repos/akka/akka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akka/akka/pulls/21615/commits"},"statuses":{"href":"https://api.github.com/repos/akka/akka/statuses/8d6bc969a1ac1d34e21f39bcf19cd448fc705075"}}}}
{"actor":{"display_login":"patriknw"}}