{"action":"created","comment":{"url":"https://api.github.com/repos/yedino/galaxy42/pulls/comments/68736231","id":68736231,"diff_hunk":"@@ -137,9 +137,9 @@ typedef std::string t_hash; ///< type of hash\n typedef sodiumpp::locked_string t_hash_PRV; ///< type of hash that contains a private secure data (e.g. is memlocked)\n \n t_hash Hash1( const t_hash & hash );\n-size_t Hash1_size(); ///< returns size (in octets) of the output of Hash1 function\n+constexpr size_t Hash1_size(); ///< returns size (in octets) of the output of Hash1 function\n t_hash Hash2( const t_hash & hash );\n-size_t Hash2_size(); ///< returns size (in octets) of the output of Hash1 function\n+constexpr size_t Hash2_size(); ///< returns size (in octets) of the output of Hash1 function\n ","path":"src/crypto/crypto_basic.hpp","position":9,"original_position":9,"commit_id":"e454f5cd8b646a65885022d6427b8d375f71f1a4","original_commit_id":"3e1e12166183dfb11234398cb02912b0682b080b","user":{"login":"rfree-d","id":18722764,"avatar_url":"https://avatars.githubusercontent.com/u/18722764?v=3","gravatar_id":"","url":"https://api.github.com/users/rfree-d","html_url":"https://github.com/rfree-d","followers_url":"https://api.github.com/users/rfree-d/followers","following_url":"https://api.github.com/users/rfree-d/following{/other_user}","gists_url":"https://api.github.com/users/rfree-d/gists{/gist_id}","starred_url":"https://api.github.com/users/rfree-d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfree-d/subscriptions","organizations_url":"https://api.github.com/users/rfree-d/orgs","repos_url":"https://api.github.com/users/rfree-d/repos","events_url":"https://api.github.com/users/rfree-d/events{/privacy}","received_events_url":"https://api.github.com/users/rfree-d/received_events","type":"User","site_admin":false},"body":"change to const expr is ok (ass above)","created_at":"2016-06-28T10:57:03Z","updated_at":"2016-06-28T10:57:03Z","html_url":"https://github.com/yedino/galaxy42/pull/26#discussion_r68736231","pull_request_url":"https://api.github.com/repos/yedino/galaxy42/pulls/26","_links":{"self":{"href":"https://api.github.com/repos/yedino/galaxy42/pulls/comments/68736231"},"html":{"href":"https://github.com/yedino/galaxy42/pull/26#discussion_r68736231"},"pull_request":{"href":"https://api.github.com/repos/yedino/galaxy42/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/yedino/galaxy42/pulls/26","id":75444203,"html_url":"https://github.com/yedino/galaxy42/pull/26","diff_url":"https://github.com/yedino/galaxy42/pull/26.diff","patch_url":"https://github.com/yedino/galaxy42/pull/26.patch","issue_url":"https://api.github.com/repos/yedino/galaxy42/issues/26","number":26,"state":"open","locked":false,"title":"Few TODO resolved; [fix] json in EXPERIMENTAL","user":{"login":"damianbb","id":12492127,"avatar_url":"https://avatars.githubusercontent.com/u/12492127?v=3","gravatar_id":"","url":"https://api.github.com/users/damianbb","html_url":"https://github.com/damianbb","followers_url":"https://api.github.com/users/damianbb/followers","following_url":"https://api.github.com/users/damianbb/following{/other_user}","gists_url":"https://api.github.com/users/damianbb/gists{/gist_id}","starred_url":"https://api.github.com/users/damianbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damianbb/subscriptions","organizations_url":"https://api.github.com/users/damianbb/orgs","repos_url":"https://api.github.com/users/damianbb/repos","events_url":"https://api.github.com/users/damianbb/events{/privacy}","received_events_url":"https://api.github.com/users/damianbb/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-28T09:20:59Z","updated_at":"2016-06-28T10:57:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e37c2edd3790885096fdebd5e66345308e6b51a8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/yedino/galaxy42/pulls/26/commits","review_comments_url":"https://api.github.com/repos/yedino/galaxy42/pulls/26/comments","review_comment_url":"https://api.github.com/repos/yedino/galaxy42/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yedino/galaxy42/issues/26/comments","statuses_url":"https://api.github.com/repos/yedino/galaxy42/statuses/e454f5cd8b646a65885022d6427b8d375f71f1a4","head":{"label":"damianbb:master","ref":"master","sha":"e454f5cd8b646a65885022d6427b8d375f71f1a4","user":{"login":"damianbb","id":12492127,"avatar_url":"https://avatars.githubusercontent.com/u/12492127?v=3","gravatar_id":"","url":"https://api.github.com/users/damianbb","html_url":"https://github.com/damianbb","followers_url":"https://api.github.com/users/damianbb/followers","following_url":"https://api.github.com/users/damianbb/following{/other_user}","gists_url":"https://api.github.com/users/damianbb/gists{/gist_id}","starred_url":"https://api.github.com/users/damianbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damianbb/subscriptions","organizations_url":"https://api.github.com/users/damianbb/orgs","repos_url":"https://api.github.com/users/damianbb/repos","events_url":"https://api.github.com/users/damianbb/events{/privacy}","received_events_url":"https://api.github.com/users/damianbb/received_events","type":"User","site_admin":false},"repo":{"id":61280228,"name":"galaxy42","full_name":"damianbb/galaxy42","owner":{"login":"damianbb","id":12492127,"avatar_url":"https://avatars.githubusercontent.com/u/12492127?v=3","gravatar_id":"","url":"https://api.github.com/users/damianbb","html_url":"https://github.com/damianbb","followers_url":"https://api.github.com/users/damianbb/followers","following_url":"https://api.github.com/users/damianbb/following{/other_user}","gists_url":"https://api.github.com/users/damianbb/gists{/gist_id}","starred_url":"https://api.github.com/users/damianbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damianbb/subscriptions","organizations_url":"https://api.github.com/users/damianbb/orgs","repos_url":"https://api.github.com/users/damianbb/repos","events_url":"https://api.github.com/users/damianbb/events{/privacy}","received_events_url":"https://api.github.com/users/damianbb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/damianbb/galaxy42","description":"","fork":true,"url":"https://api.github.com/repos/damianbb/galaxy42","forks_url":"https://api.github.com/repos/damianbb/galaxy42/forks","keys_url":"https://api.github.com/repos/damianbb/galaxy42/keys{/key_id}","collaborators_url":"https://api.github.com/repos/damianbb/galaxy42/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/damianbb/galaxy42/teams","hooks_url":"https://api.github.com/repos/damianbb/galaxy42/hooks","issue_events_url":"https://api.github.com/repos/damianbb/galaxy42/issues/events{/number}","events_url":"https://api.github.com/repos/damianbb/galaxy42/events","assignees_url":"https://api.github.com/repos/damianbb/galaxy42/assignees{/user}","branches_url":"https://api.github.com/repos/damianbb/galaxy42/branches{/branch}","tags_url":"https://api.github.com/repos/damianbb/galaxy42/tags","blobs_url":"https://api.github.com/repos/damianbb/galaxy42/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/damianbb/galaxy42/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/damianbb/galaxy42/git/refs{/sha}","trees_url":"https://api.github.com/repos/damianbb/galaxy42/git/trees{/sha}","statuses_url":"https://api.github.com/repos/damianbb/galaxy42/statuses/{sha}","languages_url":"https://api.github.com/repos/damianbb/galaxy42/languages","stargazers_url":"https://api.github.com/repos/damianbb/galaxy42/stargazers","contributors_url":"https://api.github.com/repos/damianbb/galaxy42/contributors","subscribers_url":"https://api.github.com/repos/damianbb/galaxy42/subscribers","subscription_url":"https://api.github.com/repos/damianbb/galaxy42/subscription","commits_url":"https://api.github.com/repos/damianbb/galaxy42/commits{/sha}","git_commits_url":"https://api.github.com/repos/damianbb/galaxy42/git/commits{/sha}","comments_url":"https://api.github.com/repos/damianbb/galaxy42/comments{/number}","issue_comment_url":"https://api.github.com/repos/damianbb/galaxy42/issues/comments{/number}","contents_url":"https://api.github.com/repos/damianbb/galaxy42/contents/{+path}","compare_url":"https://api.github.com/repos/damianbb/galaxy42/compare/{base}...{head}","merges_url":"https://api.github.com/repos/damianbb/galaxy42/merges","archive_url":"https://api.github.com/repos/damianbb/galaxy42/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/damianbb/galaxy42/downloads","issues_url":"https://api.github.com/repos/damianbb/galaxy42/issues{/number}","pulls_url":"https://api.github.com/repos/damianbb/galaxy42/pulls{/number}","milestones_url":"https://api.github.com/repos/damianbb/galaxy42/milestones{/number}","notifications_url":"https://api.github.com/repos/damianbb/galaxy42/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/damianbb/galaxy42/labels{/name}","releases_url":"https://api.github.com/repos/damianbb/galaxy42/releases{/id}","deployments_url":"https://api.github.com/repos/damianbb/galaxy42/deployments","created_at":"2016-06-16T09:32:11Z","updated_at":"2016-06-16T09:32:12Z","pushed_at":"2016-06-28T09:14:58Z","git_url":"git://github.com/damianbb/galaxy42.git","ssh_url":"git@github.com:damianbb/galaxy42.git","clone_url":"https://github.com/damianbb/galaxy42.git","svn_url":"https://github.com/damianbb/galaxy42","homepage":null,"size":3953,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yedino:master","ref":"master","sha":"8df2d8a48f9bcd1118013c313b398bc70fe44035","user":{"login":"yedino","id":19927716,"avatar_url":"https://avatars.githubusercontent.com/u/19927716?v=3","gravatar_id":"","url":"https://api.github.com/users/yedino","html_url":"https://github.com/yedino","followers_url":"https://api.github.com/users/yedino/followers","following_url":"https://api.github.com/users/yedino/following{/other_user}","gists_url":"https://api.github.com/users/yedino/gists{/gist_id}","starred_url":"https://api.github.com/users/yedino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yedino/subscriptions","organizations_url":"https://api.github.com/users/yedino/orgs","repos_url":"https://api.github.com/users/yedino/repos","events_url":"https://api.github.com/users/yedino/events{/privacy}","received_events_url":"https://api.github.com/users/yedino/received_events","type":"Organization","site_admin":false},"repo":{"id":61117615,"name":"galaxy42","full_name":"yedino/galaxy42","owner":{"login":"yedino","id":19927716,"avatar_url":"https://avatars.githubusercontent.com/u/19927716?v=3","gravatar_id":"","url":"https://api.github.com/users/yedino","html_url":"https://github.com/yedino","followers_url":"https://api.github.com/users/yedino/followers","following_url":"https://api.github.com/users/yedino/following{/other_user}","gists_url":"https://api.github.com/users/yedino/gists{/gist_id}","starred_url":"https://api.github.com/users/yedino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yedino/subscriptions","organizations_url":"https://api.github.com/users/yedino/orgs","repos_url":"https://api.github.com/users/yedino/repos","events_url":"https://api.github.com/users/yedino/events{/privacy}","received_events_url":"https://api.github.com/users/yedino/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yedino/galaxy42","description":"","fork":false,"url":"https://api.github.com/repos/yedino/galaxy42","forks_url":"https://api.github.com/repos/yedino/galaxy42/forks","keys_url":"https://api.github.com/repos/yedino/galaxy42/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yedino/galaxy42/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yedino/galaxy42/teams","hooks_url":"https://api.github.com/repos/yedino/galaxy42/hooks","issue_events_url":"https://api.github.com/repos/yedino/galaxy42/issues/events{/number}","events_url":"https://api.github.com/repos/yedino/galaxy42/events","assignees_url":"https://api.github.com/repos/yedino/galaxy42/assignees{/user}","branches_url":"https://api.github.com/repos/yedino/galaxy42/branches{/branch}","tags_url":"https://api.github.com/repos/yedino/galaxy42/tags","blobs_url":"https://api.github.com/repos/yedino/galaxy42/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yedino/galaxy42/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yedino/galaxy42/git/refs{/sha}","trees_url":"https://api.github.com/repos/yedino/galaxy42/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yedino/galaxy42/statuses/{sha}","languages_url":"https://api.github.com/repos/yedino/galaxy42/languages","stargazers_url":"https://api.github.com/repos/yedino/galaxy42/stargazers","contributors_url":"https://api.github.com/repos/yedino/galaxy42/contributors","subscribers_url":"https://api.github.com/repos/yedino/galaxy42/subscribers","subscription_url":"https://api.github.com/repos/yedino/galaxy42/subscription","commits_url":"https://api.github.com/repos/yedino/galaxy42/commits{/sha}","git_commits_url":"https://api.github.com/repos/yedino/galaxy42/git/commits{/sha}","comments_url":"https://api.github.com/repos/yedino/galaxy42/comments{/number}","issue_comment_url":"https://api.github.com/repos/yedino/galaxy42/issues/comments{/number}","contents_url":"https://api.github.com/repos/yedino/galaxy42/contents/{+path}","compare_url":"https://api.github.com/repos/yedino/galaxy42/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yedino/galaxy42/merges","archive_url":"https://api.github.com/repos/yedino/galaxy42/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yedino/galaxy42/downloads","issues_url":"https://api.github.com/repos/yedino/galaxy42/issues{/number}","pulls_url":"https://api.github.com/repos/yedino/galaxy42/pulls{/number}","milestones_url":"https://api.github.com/repos/yedino/galaxy42/milestones{/number}","notifications_url":"https://api.github.com/repos/yedino/galaxy42/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yedino/galaxy42/labels{/name}","releases_url":"https://api.github.com/repos/yedino/galaxy42/releases{/id}","deployments_url":"https://api.github.com/repos/yedino/galaxy42/deployments","created_at":"2016-06-14T11:33:01Z","updated_at":"2016-06-15T10:27:57Z","pushed_at":"2016-06-28T09:20:59Z","git_url":"git://github.com/yedino/galaxy42.git","ssh_url":"git@github.com:yedino/galaxy42.git","clone_url":"https://github.com/yedino/galaxy42.git","svn_url":"https://github.com/yedino/galaxy42","homepage":null,"size":7933,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yedino/galaxy42/pulls/26"},"html":{"href":"https://github.com/yedino/galaxy42/pull/26"},"issue":{"href":"https://api.github.com/repos/yedino/galaxy42/issues/26"},"comments":{"href":"https://api.github.com/repos/yedino/galaxy42/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/yedino/galaxy42/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/yedino/galaxy42/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yedino/galaxy42/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/yedino/galaxy42/statuses/e454f5cd8b646a65885022d6427b8d375f71f1a4"}}}}
{"actor":{"display_login":"rfree-d"}}