{"action":"created","comment":{"url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/comments/90739094","pull_request_review_id":11260152,"id":90739094,"diff_hunk":"@@ -58,7 +58,7 @@ public static double GetNamedSize(NamedSize size, Type targetElementType)\n \t\t\treturn GetNamedSize(size, targetElementType, false);\n \t\t}\n \n-\t\tpublic static void OnPlatform(Action iOS = null, Action Android = null, Action WinPhone = null, Action Default = null)\n+\t\tpublic static void OnPlatform(Action iOS = null, Action Android = null, Action WinPhone = null, Action Default = null, Action Tizen = null)","path":"Xamarin.Forms.Core/Device.cs","position":null,"original_position":5,"commit_id":"cc170788bc2ae70588c3183a892d661f449c55b9","original_commit_id":"ed9177b4b0e6eeee314255b9c518abf4774c9fea","user":{"login":"rookiejava","id":1029134,"avatar_url":"https://avatars.githubusercontent.com/u/1029134?v=3","gravatar_id":"","url":"https://api.github.com/users/rookiejava","html_url":"https://github.com/rookiejava","followers_url":"https://api.github.com/users/rookiejava/followers","following_url":"https://api.github.com/users/rookiejava/following{/other_user}","gists_url":"https://api.github.com/users/rookiejava/gists{/gist_id}","starred_url":"https://api.github.com/users/rookiejava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rookiejava/subscriptions","organizations_url":"https://api.github.com/users/rookiejava/orgs","repos_url":"https://api.github.com/users/rookiejava/repos","events_url":"https://api.github.com/users/rookiejava/events{/privacy}","received_events_url":"https://api.github.com/users/rookiejava/received_events","type":"User","site_admin":false},"body":"Thanks for your comments. That's why I want to handle it on different PR. \r\nHow do you feel about separating from this PR? Device.OnPlatform methods are also required to Tizen backend. However, at the moment, TargetDevice.Tizen is first step to support Xamarin.Forms.Platform.Tizen (Forms.cs) I think.","created_at":"2016-12-02T23:39:33Z","updated_at":"2016-12-02T23:39:33Z","html_url":"https://github.com/xamarin/Xamarin.Forms/pull/590#discussion_r90739094","pull_request_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/590","_links":{"self":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/comments/90739094"},"html":{"href":"https://github.com/xamarin/Xamarin.Forms/pull/590#discussion_r90739094"},"pull_request":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/590"}}},"pull_request":{"url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/590","id":96193831,"html_url":"https://github.com/xamarin/Xamarin.Forms/pull/590","diff_url":"https://github.com/xamarin/Xamarin.Forms/pull/590.diff","patch_url":"https://github.com/xamarin/Xamarin.Forms/pull/590.patch","issue_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/590","number":590,"state":"open","locked":false,"title":"Add Tizen to TargetPlatform","user":{"login":"rookiejava","id":1029134,"avatar_url":"https://avatars.githubusercontent.com/u/1029134?v=3","gravatar_id":"","url":"https://api.github.com/users/rookiejava","html_url":"https://github.com/rookiejava","followers_url":"https://api.github.com/users/rookiejava/followers","following_url":"https://api.github.com/users/rookiejava/following{/other_user}","gists_url":"https://api.github.com/users/rookiejava/gists{/gist_id}","starred_url":"https://api.github.com/users/rookiejava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rookiejava/subscriptions","organizations_url":"https://api.github.com/users/rookiejava/orgs","repos_url":"https://api.github.com/users/rookiejava/repos","events_url":"https://api.github.com/users/rookiejava/events{/privacy}","received_events_url":"https://api.github.com/users/rookiejava/received_events","type":"User","site_admin":false},"body":"### Description of Change ###\r\n\r\nThis PR is introduce to Tizen as a TargetPlatform.  `TargetgetPlatform.Tizen` indicates that forms is running on the Tizen Platform.\r\n\r\n### Bugs Fixed ###\r\n\r\n- None\r\n\r\n### API Changes ###\r\n\r\nAdded:\r\n - TargetPlatform.Tizen // enum\r\n - T OnPlatform<T>.Tizen { get; set; }\r\n - static void Device.OnPlatform (Action iOS, Action Android, Action WinPhone, Action Default, Action Tizen)\r\n - static T Device.OnPlatform<T> (T iOS, T Android, T WinPhone, T Tizen)\r\n - sealed class Xamarin.Forms.PlatformConfiguration.Tizen : IConfigPlatform\r\n\r\n### Behavioral Changes ###\r\n\r\n- None\r\n\r\n### PR Checklist ###\r\n\r\n- [X] Has tests (if omitted, state reason in description)\r\n- [X] Rebased on top of master at time of PR\r\n- [X] Changes adhere to coding standard\r\n- [X] Consolidate commits as makes sense\r\n\r\n","created_at":"2016-12-01T23:39:19Z","updated_at":"2016-12-02T23:39:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ef4dc43fa78781ca8d10629cea7ccc139ad672c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/590/commits","review_comments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/590/comments","review_comment_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/590/comments","statuses_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/statuses/cc170788bc2ae70588c3183a892d661f449c55b9","head":{"label":"rookiejava:add-tizen-to-target-platform","ref":"add-tizen-to-target-platform","sha":"cc170788bc2ae70588c3183a892d661f449c55b9","user":{"login":"rookiejava","id":1029134,"avatar_url":"https://avatars.githubusercontent.com/u/1029134?v=3","gravatar_id":"","url":"https://api.github.com/users/rookiejava","html_url":"https://github.com/rookiejava","followers_url":"https://api.github.com/users/rookiejava/followers","following_url":"https://api.github.com/users/rookiejava/following{/other_user}","gists_url":"https://api.github.com/users/rookiejava/gists{/gist_id}","starred_url":"https://api.github.com/users/rookiejava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rookiejava/subscriptions","organizations_url":"https://api.github.com/users/rookiejava/orgs","repos_url":"https://api.github.com/users/rookiejava/repos","events_url":"https://api.github.com/users/rookiejava/events{/privacy}","received_events_url":"https://api.github.com/users/rookiejava/received_events","type":"User","site_admin":false},"repo":{"id":64733208,"name":"Xamarin.Forms","full_name":"rookiejava/Xamarin.Forms","owner":{"login":"rookiejava","id":1029134,"avatar_url":"https://avatars.githubusercontent.com/u/1029134?v=3","gravatar_id":"","url":"https://api.github.com/users/rookiejava","html_url":"https://github.com/rookiejava","followers_url":"https://api.github.com/users/rookiejava/followers","following_url":"https://api.github.com/users/rookiejava/following{/other_user}","gists_url":"https://api.github.com/users/rookiejava/gists{/gist_id}","starred_url":"https://api.github.com/users/rookiejava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rookiejava/subscriptions","organizations_url":"https://api.github.com/users/rookiejava/orgs","repos_url":"https://api.github.com/users/rookiejava/repos","events_url":"https://api.github.com/users/rookiejava/events{/privacy}","received_events_url":"https://api.github.com/users/rookiejava/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rookiejava/Xamarin.Forms","description":"Xamarin.Forms official home","fork":true,"url":"https://api.github.com/repos/rookiejava/Xamarin.Forms","forks_url":"https://api.github.com/repos/rookiejava/Xamarin.Forms/forks","keys_url":"https://api.github.com/repos/rookiejava/Xamarin.Forms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rookiejava/Xamarin.Forms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rookiejava/Xamarin.Forms/teams","hooks_url":"https://api.github.com/repos/rookiejava/Xamarin.Forms/hooks","issue_events_url":"https://api.github.com/repos/rookiejava/Xamarin.Forms/issues/events{/number}","events_url":"https://api.github.com/repos/rookiejava/Xamarin.Forms/events","assignees_url":"https://api.github.com/repos/rookiejava/Xamarin.Forms/assignees{/user}","branches_url":"https://api.github.com/repos/rookiejava/Xamarin.Forms/branches{/branch}","tags_url":"https://api.github.com/repos/rookiejava/Xamarin.Forms/tags","blobs_url":"https://api.github.com/repos/rookiejava/Xamarin.Forms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rookiejava/Xamarin.Forms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rookiejava/Xamarin.Forms/git/refs{/sha}","trees_url":"https://api.github.com/repos/rookiejava/Xamarin.Forms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rookiejava/Xamarin.Forms/statuses/{sha}","languages_url":"https://api.github.com/repos/rookiejava/Xamarin.Forms/languages","stargazers_url":"https://api.github.com/repos/rookiejava/Xamarin.Forms/stargazers","contributors_url":"https://api.github.com/repos/rookiejava/Xamarin.Forms/contributors","subscribers_url":"https://api.github.com/repos/rookiejava/Xamarin.Forms/subscribers","subscription_url":"https://api.github.com/repos/rookiejava/Xamarin.Forms/subscription","commits_url":"https://api.github.com/repos/rookiejava/Xamarin.Forms/commits{/sha}","git_commits_url":"https://api.github.com/repos/rookiejava/Xamarin.Forms/git/commits{/sha}","comments_url":"https://api.github.com/repos/rookiejava/Xamarin.Forms/comments{/number}","issue_comment_url":"https://api.github.com/repos/rookiejava/Xamarin.Forms/issues/comments{/number}","contents_url":"https://api.github.com/repos/rookiejava/Xamarin.Forms/contents/{+path}","compare_url":"https://api.github.com/repos/rookiejava/Xamarin.Forms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rookiejava/Xamarin.Forms/merges","archive_url":"https://api.github.com/repos/rookiejava/Xamarin.Forms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rookiejava/Xamarin.Forms/downloads","issues_url":"https://api.github.com/repos/rookiejava/Xamarin.Forms/issues{/number}","pulls_url":"https://api.github.com/repos/rookiejava/Xamarin.Forms/pulls{/number}","milestones_url":"https://api.github.com/repos/rookiejava/Xamarin.Forms/milestones{/number}","notifications_url":"https://api.github.com/repos/rookiejava/Xamarin.Forms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rookiejava/Xamarin.Forms/labels{/name}","releases_url":"https://api.github.com/repos/rookiejava/Xamarin.Forms/releases{/id}","deployments_url":"https://api.github.com/repos/rookiejava/Xamarin.Forms/deployments","created_at":"2016-08-02T07:07:59Z","updated_at":"2016-08-02T07:08:04Z","pushed_at":"2016-12-02T23:26:17Z","git_url":"git://github.com/rookiejava/Xamarin.Forms.git","ssh_url":"git@github.com:rookiejava/Xamarin.Forms.git","clone_url":"https://github.com/rookiejava/Xamarin.Forms.git","svn_url":"https://github.com/rookiejava/Xamarin.Forms","homepage":"https://xamarin.com/forms","size":14754,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xamarin:master","ref":"master","sha":"0dc9fed3f98ae3eba7ff4e8052a55666a14da32d","user":{"login":"xamarin","id":790012,"avatar_url":"https://avatars.githubusercontent.com/u/790012?v=3","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"repo":{"id":54213490,"name":"Xamarin.Forms","full_name":"xamarin/Xamarin.Forms","owner":{"login":"xamarin","id":790012,"avatar_url":"https://avatars.githubusercontent.com/u/790012?v=3","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xamarin/Xamarin.Forms","description":"Xamarin.Forms official home","fork":false,"url":"https://api.github.com/repos/xamarin/Xamarin.Forms","forks_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/forks","keys_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/teams","hooks_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/hooks","issue_events_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/events{/number}","events_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/events","assignees_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/assignees{/user}","branches_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/branches{/branch}","tags_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/tags","blobs_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/refs{/sha}","trees_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/statuses/{sha}","languages_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/languages","stargazers_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/stargazers","contributors_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/contributors","subscribers_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/subscribers","subscription_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/subscription","commits_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/commits{/sha}","git_commits_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/commits{/sha}","comments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/comments{/number}","issue_comment_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/comments{/number}","contents_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/contents/{+path}","compare_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/merges","archive_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/downloads","issues_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues{/number}","pulls_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls{/number}","milestones_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/milestones{/number}","notifications_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/labels{/name}","releases_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/releases{/id}","deployments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/deployments","created_at":"2016-03-18T15:52:03Z","updated_at":"2016-12-02T16:59:25Z","pushed_at":"2016-12-02T23:36:50Z","git_url":"git://github.com/xamarin/Xamarin.Forms.git","ssh_url":"git@github.com:xamarin/Xamarin.Forms.git","clone_url":"https://github.com/xamarin/Xamarin.Forms.git","svn_url":"https://github.com/xamarin/Xamarin.Forms","homepage":"https://xamarin.com/forms","size":30522,"stargazers_count":1033,"watchers_count":1033,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":377,"mirror_url":null,"open_issues_count":77,"forks":377,"open_issues":77,"watchers":1033,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/590"},"html":{"href":"https://github.com/xamarin/Xamarin.Forms/pull/590"},"issue":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/590"},"comments":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/590/comments"},"review_comments":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/590/comments"},"review_comment":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/590/commits"},"statuses":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/statuses/cc170788bc2ae70588c3183a892d661f449c55b9"}}}}
{"actor":{"display_login":"rookiejava"}}