{"action":"created","issue":{"url":"https://api.github.com/repos/nltk/nltk/issues/1333","repository_url":"https://api.github.com/repos/nltk/nltk","labels_url":"https://api.github.com/repos/nltk/nltk/issues/1333/labels{/name}","comments_url":"https://api.github.com/repos/nltk/nltk/issues/1333/comments","events_url":"https://api.github.com/repos/nltk/nltk/issues/1333/events","html_url":"https://github.com/nltk/nltk/pull/1333","id":140594221,"number":1333,"title":"Refactored text.concordance to return list ","user":{"login":"story645","id":1300499,"avatar_url":"https://avatars.githubusercontent.com/u/1300499?v=3","gravatar_id":"","url":"https://api.github.com/users/story645","html_url":"https://github.com/story645","followers_url":"https://api.github.com/users/story645/followers","following_url":"https://api.github.com/users/story645/following{/other_user}","gists_url":"https://api.github.com/users/story645/gists{/gist_id}","starred_url":"https://api.github.com/users/story645/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/story645/subscriptions","organizations_url":"https://api.github.com/users/story645/orgs","repos_url":"https://api.github.com/users/story645/repos","events_url":"https://api.github.com/users/story645/events{/privacy}","received_events_url":"https://api.github.com/users/story645/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-03-14T07:13:31Z","updated_at":"2016-07-14T02:02:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nltk/nltk/pulls/1333","html_url":"https://github.com/nltk/nltk/pull/1333","diff_url":"https://github.com/nltk/nltk/pull/1333.diff","patch_url":"https://github.com/nltk/nltk/pull/1333.patch"},"body":"Refactored text.concordance so that it returns a list (while still retaining the print functionality). Written so that the list is optional and the old behavior is default, but I think it might make more sense to do this the other way around (list of concordances by default, print on request). \r\n\r\nThe unittests and doctest are based on the behavior described in http://www.nltk.org/book/ch01.html\r\nDoctest relies on ellipses because of invisible character issues. \r\n\r\nWould love more test cases. "},"comment":{"url":"https://api.github.com/repos/nltk/nltk/issues/comments/232537151","html_url":"https://github.com/nltk/nltk/pull/1333#issuecomment-232537151","issue_url":"https://api.github.com/repos/nltk/nltk/issues/1333","id":232537151,"user":{"login":"story645","id":1300499,"avatar_url":"https://avatars.githubusercontent.com/u/1300499?v=3","gravatar_id":"","url":"https://api.github.com/users/story645","html_url":"https://github.com/story645","followers_url":"https://api.github.com/users/story645/followers","following_url":"https://api.github.com/users/story645/following{/other_user}","gists_url":"https://api.github.com/users/story645/gists{/gist_id}","starred_url":"https://api.github.com/users/story645/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/story645/subscriptions","organizations_url":"https://api.github.com/users/story645/orgs","repos_url":"https://api.github.com/users/story645/repos","events_url":"https://api.github.com/users/story645/events{/privacy}","received_events_url":"https://api.github.com/users/story645/received_events","type":"User","site_admin":false},"created_at":"2016-07-14T02:02:54Z","updated_at":"2016-07-14T02:02:54Z","body":"If API consistency is important, I can create a wrapper function in `ConcordanceIndex` that maintains the old api of  the `ConcordanceIndex.print_concordance` method and then make the new methods `_print_concordance` and `_list_concordance`"}}
{"actor":{"display_login":"story645"}}