{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-zeppelin/pulls/comments/61835439","id":61835439,"diff_hunk":"@@ -83,7 +81,10 @@\n         <li ng-if=\"!ticket\">\n             <button class=\"btn btn-default\" data-toggle=\"modal\" data-target=\"#loginModal\" ng-click=\"showLoginWindow()\" style=\"margin-left: 10px\">Login</button>\n         </li>\n+        <li ng-show=\"userName != ''\">\n+        \t<button type=\"button\" class=\"btn btn-default btn-xs\" ng-click=\"logout()\" tooltip-placement=\"bottom\" tooltip=\"logout\">{userName}}</button>","path":"zeppelin-web/src/components/navbar/navbar.html","position":15,"original_position":15,"commit_id":"461adab8b9a0e8492854bbaba560e857fe2e776a","original_commit_id":"461adab8b9a0e8492854bbaba560e857fe2e776a","user":{"login":"prabhjyotsingh","id":674497,"avatar_url":"https://avatars.githubusercontent.com/u/674497?v=3","gravatar_id":"","url":"https://api.github.com/users/prabhjyotsingh","html_url":"https://github.com/prabhjyotsingh","followers_url":"https://api.github.com/users/prabhjyotsingh/followers","following_url":"https://api.github.com/users/prabhjyotsingh/following{/other_user}","gists_url":"https://api.github.com/users/prabhjyotsingh/gists{/gist_id}","starred_url":"https://api.github.com/users/prabhjyotsingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prabhjyotsingh/subscriptions","organizations_url":"https://api.github.com/users/prabhjyotsingh/orgs","repos_url":"https://api.github.com/users/prabhjyotsingh/repos","events_url":"https://api.github.com/users/prabhjyotsingh/events{/privacy}","received_events_url":"https://api.github.com/users/prabhjyotsingh/received_events","type":"User","site_admin":false},"body":"any reason why you need to say `{userName}}` instead of `Logout`","created_at":"2016-05-03T03:35:33Z","updated_at":"2016-05-03T03:35:33Z","html_url":"https://github.com/apache/incubator-zeppelin/pull/861#discussion_r61835439","pull_request_url":"https://api.github.com/repos/apache/incubator-zeppelin/pulls/861","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-zeppelin/pulls/comments/61835439"},"html":{"href":"https://github.com/apache/incubator-zeppelin/pull/861#discussion_r61835439"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-zeppelin/pulls/861"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-zeppelin/pulls/861","id":68195105,"html_url":"https://github.com/apache/incubator-zeppelin/pull/861","diff_url":"https://github.com/apache/incubator-zeppelin/pull/861.diff","patch_url":"https://github.com/apache/incubator-zeppelin/pull/861.patch","issue_url":"https://api.github.com/repos/apache/incubator-zeppelin/issues/861","number":861,"state":"open","locked":false,"title":"add note permission,logout so that people cannot access my notes ","user":{"login":"wind0727","id":7316386,"avatar_url":"https://avatars.githubusercontent.com/u/7316386?v=3","gravatar_id":"","url":"https://api.github.com/users/wind0727","html_url":"https://github.com/wind0727","followers_url":"https://api.github.com/users/wind0727/followers","following_url":"https://api.github.com/users/wind0727/following{/other_user}","gists_url":"https://api.github.com/users/wind0727/gists{/gist_id}","starred_url":"https://api.github.com/users/wind0727/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wind0727/subscriptions","organizations_url":"https://api.github.com/users/wind0727/orgs","repos_url":"https://api.github.com/users/wind0727/repos","events_url":"https://api.github.com/users/wind0727/events{/privacy}","received_events_url":"https://api.github.com/users/wind0727/received_events","type":"User","site_admin":false},"body":"### What is this PR for?\r\nresolve  logout so that people cannot access my notes, Notebook to modify the permissions will pop up, and provide the login button, rather than the login button on the home page\r\n\r\n### What type of PR is it?\r\n[ Improvement ]\r\n\r\n### Todos\r\n* [ ] - Task\r\n\r\n### What is the Jira issue?\r\nhttps://issues.apache.org/jira/browse/ZEPPELIN-723\r\n\r\n### How should this be tested?\r\n1. create a notebook\r\n2. click Note Permission\r\n3. Enter comma separated users and groups,ex: owners:admin,user1; readers:*;writers:admin,user1\r\n4. click \"Run this paragraph\", warn \"only admin,user1 can write this notebook \", prompt box show \"Login\" button\r\n5. click \"Login\" button, userName:user1,password:password2, after login success, click \"Run this paragraph\", can access this notebook\r\n6. click \"Logout\" button,cannot access this notebook\r\n\r\n### Screenshots (if appropriate)\r\n\r\n### Questions:\r\n* Does the licenses files need update?\r\n* Is there breaking changes for older versions?\r\n* Does this needs documentation?\r\n","created_at":"2016-04-28T10:07:50Z","updated_at":"2016-05-03T03:35:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f30016578664180896489b0ab87fc04fb3bb031","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-zeppelin/pulls/861/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-zeppelin/pulls/861/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-zeppelin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-zeppelin/issues/861/comments","statuses_url":"https://api.github.com/repos/apache/incubator-zeppelin/statuses/461adab8b9a0e8492854bbaba560e857fe2e776a","head":{"label":"wind0727:branch_permission","ref":"branch_permission","sha":"461adab8b9a0e8492854bbaba560e857fe2e776a","user":{"login":"wind0727","id":7316386,"avatar_url":"https://avatars.githubusercontent.com/u/7316386?v=3","gravatar_id":"","url":"https://api.github.com/users/wind0727","html_url":"https://github.com/wind0727","followers_url":"https://api.github.com/users/wind0727/followers","following_url":"https://api.github.com/users/wind0727/following{/other_user}","gists_url":"https://api.github.com/users/wind0727/gists{/gist_id}","starred_url":"https://api.github.com/users/wind0727/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wind0727/subscriptions","organizations_url":"https://api.github.com/users/wind0727/orgs","repos_url":"https://api.github.com/users/wind0727/repos","events_url":"https://api.github.com/users/wind0727/events{/privacy}","received_events_url":"https://api.github.com/users/wind0727/received_events","type":"User","site_admin":false},"repo":{"id":57284296,"name":"incubator-zeppelin","full_name":"wind0727/incubator-zeppelin","owner":{"login":"wind0727","id":7316386,"avatar_url":"https://avatars.githubusercontent.com/u/7316386?v=3","gravatar_id":"","url":"https://api.github.com/users/wind0727","html_url":"https://github.com/wind0727","followers_url":"https://api.github.com/users/wind0727/followers","following_url":"https://api.github.com/users/wind0727/following{/other_user}","gists_url":"https://api.github.com/users/wind0727/gists{/gist_id}","starred_url":"https://api.github.com/users/wind0727/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wind0727/subscriptions","organizations_url":"https://api.github.com/users/wind0727/orgs","repos_url":"https://api.github.com/users/wind0727/repos","events_url":"https://api.github.com/users/wind0727/events{/privacy}","received_events_url":"https://api.github.com/users/wind0727/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wind0727/incubator-zeppelin","description":"Mirror of Apache Zeppelin (Incubating)","fork":true,"url":"https://api.github.com/repos/wind0727/incubator-zeppelin","forks_url":"https://api.github.com/repos/wind0727/incubator-zeppelin/forks","keys_url":"https://api.github.com/repos/wind0727/incubator-zeppelin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wind0727/incubator-zeppelin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wind0727/incubator-zeppelin/teams","hooks_url":"https://api.github.com/repos/wind0727/incubator-zeppelin/hooks","issue_events_url":"https://api.github.com/repos/wind0727/incubator-zeppelin/issues/events{/number}","events_url":"https://api.github.com/repos/wind0727/incubator-zeppelin/events","assignees_url":"https://api.github.com/repos/wind0727/incubator-zeppelin/assignees{/user}","branches_url":"https://api.github.com/repos/wind0727/incubator-zeppelin/branches{/branch}","tags_url":"https://api.github.com/repos/wind0727/incubator-zeppelin/tags","blobs_url":"https://api.github.com/repos/wind0727/incubator-zeppelin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wind0727/incubator-zeppelin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wind0727/incubator-zeppelin/git/refs{/sha}","trees_url":"https://api.github.com/repos/wind0727/incubator-zeppelin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wind0727/incubator-zeppelin/statuses/{sha}","languages_url":"https://api.github.com/repos/wind0727/incubator-zeppelin/languages","stargazers_url":"https://api.github.com/repos/wind0727/incubator-zeppelin/stargazers","contributors_url":"https://api.github.com/repos/wind0727/incubator-zeppelin/contributors","subscribers_url":"https://api.github.com/repos/wind0727/incubator-zeppelin/subscribers","subscription_url":"https://api.github.com/repos/wind0727/incubator-zeppelin/subscription","commits_url":"https://api.github.com/repos/wind0727/incubator-zeppelin/commits{/sha}","git_commits_url":"https://api.github.com/repos/wind0727/incubator-zeppelin/git/commits{/sha}","comments_url":"https://api.github.com/repos/wind0727/incubator-zeppelin/comments{/number}","issue_comment_url":"https://api.github.com/repos/wind0727/incubator-zeppelin/issues/comments{/number}","contents_url":"https://api.github.com/repos/wind0727/incubator-zeppelin/contents/{+path}","compare_url":"https://api.github.com/repos/wind0727/incubator-zeppelin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wind0727/incubator-zeppelin/merges","archive_url":"https://api.github.com/repos/wind0727/incubator-zeppelin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wind0727/incubator-zeppelin/downloads","issues_url":"https://api.github.com/repos/wind0727/incubator-zeppelin/issues{/number}","pulls_url":"https://api.github.com/repos/wind0727/incubator-zeppelin/pulls{/number}","milestones_url":"https://api.github.com/repos/wind0727/incubator-zeppelin/milestones{/number}","notifications_url":"https://api.github.com/repos/wind0727/incubator-zeppelin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wind0727/incubator-zeppelin/labels{/name}","releases_url":"https://api.github.com/repos/wind0727/incubator-zeppelin/releases{/id}","deployments_url":"https://api.github.com/repos/wind0727/incubator-zeppelin/deployments","created_at":"2016-04-28T08:31:32Z","updated_at":"2016-04-28T08:31:34Z","pushed_at":"2016-05-01T02:36:32Z","git_url":"git://github.com/wind0727/incubator-zeppelin.git","ssh_url":"git@github.com:wind0727/incubator-zeppelin.git","clone_url":"https://github.com/wind0727/incubator-zeppelin.git","svn_url":"https://github.com/wind0727/incubator-zeppelin","homepage":null,"size":23273,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"bd4eaf8a35370f5f702444e576058b8c1c920acd","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":32848140,"name":"incubator-zeppelin","full_name":"apache/incubator-zeppelin","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-zeppelin","description":"Mirror of Apache Zeppelin (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-zeppelin","forks_url":"https://api.github.com/repos/apache/incubator-zeppelin/forks","keys_url":"https://api.github.com/repos/apache/incubator-zeppelin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-zeppelin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-zeppelin/teams","hooks_url":"https://api.github.com/repos/apache/incubator-zeppelin/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-zeppelin/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-zeppelin/events","assignees_url":"https://api.github.com/repos/apache/incubator-zeppelin/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-zeppelin/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-zeppelin/tags","blobs_url":"https://api.github.com/repos/apache/incubator-zeppelin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-zeppelin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-zeppelin/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-zeppelin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-zeppelin/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-zeppelin/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-zeppelin/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-zeppelin/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-zeppelin/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-zeppelin/subscription","commits_url":"https://api.github.com/repos/apache/incubator-zeppelin/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-zeppelin/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-zeppelin/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-zeppelin/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-zeppelin/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-zeppelin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-zeppelin/merges","archive_url":"https://api.github.com/repos/apache/incubator-zeppelin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-zeppelin/downloads","issues_url":"https://api.github.com/repos/apache/incubator-zeppelin/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-zeppelin/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-zeppelin/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-zeppelin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-zeppelin/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-zeppelin/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-zeppelin/deployments","created_at":"2015-03-25T07:00:06Z","updated_at":"2016-05-02T15:49:19Z","pushed_at":"2016-05-02T16:58:47Z","git_url":"git://github.com/apache/incubator-zeppelin.git","ssh_url":"git@github.com:apache/incubator-zeppelin.git","clone_url":"https://github.com/apache/incubator-zeppelin.git","svn_url":"https://github.com/apache/incubator-zeppelin","homepage":null,"size":100113,"stargazers_count":1412,"watchers_count":1412,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":703,"mirror_url":"git://git.apache.org/incubator-zeppelin.git","open_issues_count":96,"forks":703,"open_issues":96,"watchers":1412,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-zeppelin/pulls/861"},"html":{"href":"https://github.com/apache/incubator-zeppelin/pull/861"},"issue":{"href":"https://api.github.com/repos/apache/incubator-zeppelin/issues/861"},"comments":{"href":"https://api.github.com/repos/apache/incubator-zeppelin/issues/861/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-zeppelin/pulls/861/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-zeppelin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-zeppelin/pulls/861/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-zeppelin/statuses/461adab8b9a0e8492854bbaba560e857fe2e776a"}}}}