{"action":"created","comment":{"url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/pulls/comments/79639867","id":79639867,"diff_hunk":"@@ -0,0 +1,14 @@\n+require 'spec_helper'\n+\n+module FeatureFlagger\n+  RSpec.describe Configuration do\n+    context 'accessors methods' do\n+      subject(:configuration) { described_class.new }\n+\n+      it { expect(configuration).to respond_to(:storage) }\n+      it { expect(configuration).to respond_to(:storage=) }\n+      it { expect(configuration).to respond_to(:yaml_filepath) }\n+      it { expect(configuration).to respond_to(:info) }\n+    end","path":"spec/feature_flagger/configuration_spec.rb","position":12,"original_position":12,"commit_id":"47b87a5cc27efad7c5919d53fb7302179e517d52","original_commit_id":"47b87a5cc27efad7c5919d53fb7302179e517d52","user":{"login":"lccezinha","id":2160392,"avatar_url":"https://avatars.githubusercontent.com/u/2160392?v=3","gravatar_id":"","url":"https://api.github.com/users/lccezinha","html_url":"https://github.com/lccezinha","followers_url":"https://api.github.com/users/lccezinha/followers","following_url":"https://api.github.com/users/lccezinha/following{/other_user}","gists_url":"https://api.github.com/users/lccezinha/gists{/gist_id}","starred_url":"https://api.github.com/users/lccezinha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lccezinha/subscriptions","organizations_url":"https://api.github.com/users/lccezinha/orgs","repos_url":"https://api.github.com/users/lccezinha/repos","events_url":"https://api.github.com/users/lccezinha/events{/privacy}","received_events_url":"https://api.github.com/users/lccezinha/received_events","type":"User","site_admin":false},"body":"So, it's better to keep de load of `yaml_filepath` in main module, and then pass the loaded file as arg, and just assign in Configuration, right ?\r\n\r\nSo, with this change of dependency, Configuration class will just handle the `storage` config, right ?","created_at":"2016-09-20T15:30:48Z","updated_at":"2016-09-20T15:30:48Z","html_url":"https://github.com/ResultadosDigitais/feature_flagger/pull/17#discussion_r79639867","pull_request_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/pulls/comments/79639867"},"html":{"href":"https://github.com/ResultadosDigitais/feature_flagger/pull/17#discussion_r79639867"},"pull_request":{"href":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/pulls/17","id":85143248,"html_url":"https://github.com/ResultadosDigitais/feature_flagger/pull/17","diff_url":"https://github.com/ResultadosDigitais/feature_flagger/pull/17.diff","patch_url":"https://github.com/ResultadosDigitais/feature_flagger/pull/17.patch","issue_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/issues/17","number":17,"state":"open","locked":false,"title":"Uncople Configuration to own class","user":{"login":"lccezinha","id":2160392,"avatar_url":"https://avatars.githubusercontent.com/u/2160392?v=3","gravatar_id":"","url":"https://api.github.com/users/lccezinha","html_url":"https://github.com/lccezinha","followers_url":"https://api.github.com/users/lccezinha/followers","following_url":"https://api.github.com/users/lccezinha/following{/other_user}","gists_url":"https://api.github.com/users/lccezinha/gists{/gist_id}","starred_url":"https://api.github.com/users/lccezinha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lccezinha/subscriptions","organizations_url":"https://api.github.com/users/lccezinha/orgs","repos_url":"https://api.github.com/users/lccezinha/repos","events_url":"https://api.github.com/users/lccezinha/events{/privacy}","received_events_url":"https://api.github.com/users/lccezinha/received_events","type":"User","site_admin":false},"body":"Fix #2\r\n\r\nThis PR is to solve issue #2 and move all related code for configuration from `FeatureFlagger` module to a specific `Configuration` class.\r\n\r\n","created_at":"2016-09-13T23:23:34Z","updated_at":"2016-09-20T15:30:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db09c0b4ee3fe1cd56e610f00f1fdd8731b33511","assignee":{"login":"geisonbiazus","id":499193,"avatar_url":"https://avatars.githubusercontent.com/u/499193?v=3","gravatar_id":"","url":"https://api.github.com/users/geisonbiazus","html_url":"https://github.com/geisonbiazus","followers_url":"https://api.github.com/users/geisonbiazus/followers","following_url":"https://api.github.com/users/geisonbiazus/following{/other_user}","gists_url":"https://api.github.com/users/geisonbiazus/gists{/gist_id}","starred_url":"https://api.github.com/users/geisonbiazus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geisonbiazus/subscriptions","organizations_url":"https://api.github.com/users/geisonbiazus/orgs","repos_url":"https://api.github.com/users/geisonbiazus/repos","events_url":"https://api.github.com/users/geisonbiazus/events{/privacy}","received_events_url":"https://api.github.com/users/geisonbiazus/received_events","type":"User","site_admin":false},"assignees":[{"login":"geisonbiazus","id":499193,"avatar_url":"https://avatars.githubusercontent.com/u/499193?v=3","gravatar_id":"","url":"https://api.github.com/users/geisonbiazus","html_url":"https://github.com/geisonbiazus","followers_url":"https://api.github.com/users/geisonbiazus/followers","following_url":"https://api.github.com/users/geisonbiazus/following{/other_user}","gists_url":"https://api.github.com/users/geisonbiazus/gists{/gist_id}","starred_url":"https://api.github.com/users/geisonbiazus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geisonbiazus/subscriptions","organizations_url":"https://api.github.com/users/geisonbiazus/orgs","repos_url":"https://api.github.com/users/geisonbiazus/repos","events_url":"https://api.github.com/users/geisonbiazus/events{/privacy}","received_events_url":"https://api.github.com/users/geisonbiazus/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/pulls/17/commits","review_comments_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/pulls/17/comments","review_comment_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/issues/17/comments","statuses_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/statuses/47b87a5cc27efad7c5919d53fb7302179e517d52","head":{"label":"ResultadosDigitais:add-configuration-class","ref":"add-configuration-class","sha":"47b87a5cc27efad7c5919d53fb7302179e517d52","user":{"login":"ResultadosDigitais","id":817058,"avatar_url":"https://avatars.githubusercontent.com/u/817058?v=3","gravatar_id":"","url":"https://api.github.com/users/ResultadosDigitais","html_url":"https://github.com/ResultadosDigitais","followers_url":"https://api.github.com/users/ResultadosDigitais/followers","following_url":"https://api.github.com/users/ResultadosDigitais/following{/other_user}","gists_url":"https://api.github.com/users/ResultadosDigitais/gists{/gist_id}","starred_url":"https://api.github.com/users/ResultadosDigitais/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ResultadosDigitais/subscriptions","organizations_url":"https://api.github.com/users/ResultadosDigitais/orgs","repos_url":"https://api.github.com/users/ResultadosDigitais/repos","events_url":"https://api.github.com/users/ResultadosDigitais/events{/privacy}","received_events_url":"https://api.github.com/users/ResultadosDigitais/received_events","type":"Organization","site_admin":false},"repo":{"id":65386486,"name":"feature_flagger","full_name":"ResultadosDigitais/feature_flagger","owner":{"login":"ResultadosDigitais","id":817058,"avatar_url":"https://avatars.githubusercontent.com/u/817058?v=3","gravatar_id":"","url":"https://api.github.com/users/ResultadosDigitais","html_url":"https://github.com/ResultadosDigitais","followers_url":"https://api.github.com/users/ResultadosDigitais/followers","following_url":"https://api.github.com/users/ResultadosDigitais/following{/other_user}","gists_url":"https://api.github.com/users/ResultadosDigitais/gists{/gist_id}","starred_url":"https://api.github.com/users/ResultadosDigitais/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ResultadosDigitais/subscriptions","organizations_url":"https://api.github.com/users/ResultadosDigitais/orgs","repos_url":"https://api.github.com/users/ResultadosDigitais/repos","events_url":"https://api.github.com/users/ResultadosDigitais/events{/privacy}","received_events_url":"https://api.github.com/users/ResultadosDigitais/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ResultadosDigitais/feature_flagger","description":"Management tool to make it easier rollouting features to customers. ","fork":false,"url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger","forks_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/forks","keys_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/teams","hooks_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/hooks","issue_events_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/issues/events{/number}","events_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/events","assignees_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/assignees{/user}","branches_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/branches{/branch}","tags_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/tags","blobs_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/git/refs{/sha}","trees_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/statuses/{sha}","languages_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/languages","stargazers_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/stargazers","contributors_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/contributors","subscribers_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/subscribers","subscription_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/subscription","commits_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/commits{/sha}","git_commits_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/git/commits{/sha}","comments_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/comments{/number}","issue_comment_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/issues/comments{/number}","contents_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/contents/{+path}","compare_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/merges","archive_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/downloads","issues_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/issues{/number}","pulls_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/pulls{/number}","milestones_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/milestones{/number}","notifications_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/labels{/name}","releases_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/releases{/id}","deployments_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/deployments","created_at":"2016-08-10T13:52:15Z","updated_at":"2016-09-09T15:34:32Z","pushed_at":"2016-09-20T13:02:28Z","git_url":"git://github.com/ResultadosDigitais/feature_flagger.git","ssh_url":"git@github.com:ResultadosDigitais/feature_flagger.git","clone_url":"https://github.com/ResultadosDigitais/feature_flagger.git","svn_url":"https://github.com/ResultadosDigitais/feature_flagger","homepage":null,"size":45,"stargazers_count":12,"watchers_count":12,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":12,"default_branch":"master"}},"base":{"label":"ResultadosDigitais:master","ref":"master","sha":"3ec6eb3eea362982e6eb2766c590779cd3af3494","user":{"login":"ResultadosDigitais","id":817058,"avatar_url":"https://avatars.githubusercontent.com/u/817058?v=3","gravatar_id":"","url":"https://api.github.com/users/ResultadosDigitais","html_url":"https://github.com/ResultadosDigitais","followers_url":"https://api.github.com/users/ResultadosDigitais/followers","following_url":"https://api.github.com/users/ResultadosDigitais/following{/other_user}","gists_url":"https://api.github.com/users/ResultadosDigitais/gists{/gist_id}","starred_url":"https://api.github.com/users/ResultadosDigitais/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ResultadosDigitais/subscriptions","organizations_url":"https://api.github.com/users/ResultadosDigitais/orgs","repos_url":"https://api.github.com/users/ResultadosDigitais/repos","events_url":"https://api.github.com/users/ResultadosDigitais/events{/privacy}","received_events_url":"https://api.github.com/users/ResultadosDigitais/received_events","type":"Organization","site_admin":false},"repo":{"id":65386486,"name":"feature_flagger","full_name":"ResultadosDigitais/feature_flagger","owner":{"login":"ResultadosDigitais","id":817058,"avatar_url":"https://avatars.githubusercontent.com/u/817058?v=3","gravatar_id":"","url":"https://api.github.com/users/ResultadosDigitais","html_url":"https://github.com/ResultadosDigitais","followers_url":"https://api.github.com/users/ResultadosDigitais/followers","following_url":"https://api.github.com/users/ResultadosDigitais/following{/other_user}","gists_url":"https://api.github.com/users/ResultadosDigitais/gists{/gist_id}","starred_url":"https://api.github.com/users/ResultadosDigitais/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ResultadosDigitais/subscriptions","organizations_url":"https://api.github.com/users/ResultadosDigitais/orgs","repos_url":"https://api.github.com/users/ResultadosDigitais/repos","events_url":"https://api.github.com/users/ResultadosDigitais/events{/privacy}","received_events_url":"https://api.github.com/users/ResultadosDigitais/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ResultadosDigitais/feature_flagger","description":"Management tool to make it easier rollouting features to customers. ","fork":false,"url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger","forks_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/forks","keys_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/teams","hooks_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/hooks","issue_events_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/issues/events{/number}","events_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/events","assignees_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/assignees{/user}","branches_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/branches{/branch}","tags_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/tags","blobs_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/git/refs{/sha}","trees_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/statuses/{sha}","languages_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/languages","stargazers_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/stargazers","contributors_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/contributors","subscribers_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/subscribers","subscription_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/subscription","commits_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/commits{/sha}","git_commits_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/git/commits{/sha}","comments_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/comments{/number}","issue_comment_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/issues/comments{/number}","contents_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/contents/{+path}","compare_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/merges","archive_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/downloads","issues_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/issues{/number}","pulls_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/pulls{/number}","milestones_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/milestones{/number}","notifications_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/labels{/name}","releases_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/releases{/id}","deployments_url":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/deployments","created_at":"2016-08-10T13:52:15Z","updated_at":"2016-09-09T15:34:32Z","pushed_at":"2016-09-20T13:02:28Z","git_url":"git://github.com/ResultadosDigitais/feature_flagger.git","ssh_url":"git@github.com:ResultadosDigitais/feature_flagger.git","clone_url":"https://github.com/ResultadosDigitais/feature_flagger.git","svn_url":"https://github.com/ResultadosDigitais/feature_flagger","homepage":null,"size":45,"stargazers_count":12,"watchers_count":12,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/pulls/17"},"html":{"href":"https://github.com/ResultadosDigitais/feature_flagger/pull/17"},"issue":{"href":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/issues/17"},"comments":{"href":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/ResultadosDigitais/feature_flagger/statuses/47b87a5cc27efad7c5919d53fb7302179e517d52"}}}}
{"actor":{"display_login":"lccezinha"}}