{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/51893924","id":51893924,"diff_hunk":"@@ -85,6 +85,14 @@ def add_node_data(node)\n \n   # Rewrite a given file resource with the metadata from a fileserver based file\n   def replace_metadata(resource, metadata)\n+    if resource[:links] == \"manage\" && metadata.ftype == \"link\"\n+      resource.delete(:source)","path":"lib/puppet/indirector/catalog/compiler.rb","position":5,"original_position":5,"commit_id":"28f145809799413abc5c0d71610130f72caf364f","original_commit_id":"28f145809799413abc5c0d71610130f72caf364f","user":{"login":"joshcooper","id":737664,"avatar_url":"https://avatars.githubusercontent.com/u/737664?v=3","gravatar_id":"","url":"https://api.github.com/users/joshcooper","html_url":"https://github.com/joshcooper","followers_url":"https://api.github.com/users/joshcooper/followers","following_url":"https://api.github.com/users/joshcooper/following{/other_user}","gists_url":"https://api.github.com/users/joshcooper/gists{/gist_id}","starred_url":"https://api.github.com/users/joshcooper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshcooper/subscriptions","organizations_url":"https://api.github.com/users/joshcooper/orgs","repos_url":"https://api.github.com/users/joshcooper/repos","events_url":"https://api.github.com/users/joshcooper/events{/privacy}","received_events_url":"https://api.github.com/users/joshcooper/received_events","type":"User","site_admin":false},"body":"It seems inconsistent to delete `source` here, but not `links => follow` below? Should we delete `source` when `ensure => directory`? Originally we were planning on always preserving `source`, but perhaps it's not needed in some cases? How about if we preserve `source` for now, merge this PR, and talk about when to preserve `source` at today's sync up?","created_at":"2016-02-04T16:07:25Z","updated_at":"2016-02-04T16:07:25Z","html_url":"https://github.com/puppetlabs/puppet/pull/4619#discussion_r51893924","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/4619","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/51893924"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/4619#discussion_r51893924"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/4619"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/4619","id":58082265,"html_url":"https://github.com/puppetlabs/puppet/pull/4619","diff_url":"https://github.com/puppetlabs/puppet/pull/4619.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/4619.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/4619","number":4619,"state":"open","locked":false,"title":"(PUP-5699) Inline symlink metadata in static catalog","user":{"login":"whopper","id":507621,"avatar_url":"https://avatars.githubusercontent.com/u/507621?v=3","gravatar_id":"","url":"https://api.github.com/users/whopper","html_url":"https://github.com/whopper","followers_url":"https://api.github.com/users/whopper/followers","following_url":"https://api.github.com/users/whopper/following{/other_user}","gists_url":"https://api.github.com/users/whopper/gists{/gist_id}","starred_url":"https://api.github.com/users/whopper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whopper/subscriptions","organizations_url":"https://api.github.com/users/whopper/orgs","repos_url":"https://api.github.com/users/whopper/repos","events_url":"https://api.github.com/users/whopper/events{/privacy}","received_events_url":"https://api.github.com/users/whopper/received_events","type":"User","site_admin":false},"body":"This commit updates the static compilation inlining logic to\r\nhandle symlinks which have their `links` parameter set to manage.\r\nThe `source` parameter of such a resource references one of two\r\nitems: a link or a regular file.\r\n\r\nWhen `source` references a link, the destination of that link is\r\ninlined directly into the `target` parameter of the new resource.\r\n\r\nIf `source` references a regular file, the existing logic holds\r\nand file content is copied into the new resource.\r\n\r\nWhen `links` is set to `follow`, we fall back to the regular\r\ncontent inlining behavior, which sets the `checksum_value` of\r\nthe new resource.","created_at":"2016-02-03T02:19:25Z","updated_at":"2016-02-04T16:07:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"36300e21212cde05b9890c6e0ee39f07429deb3b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/4619/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/4619/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/4619/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/28f145809799413abc5c0d71610130f72caf364f","head":{"label":"whopper:PUP-5699/master/inline-symlink-metadata","ref":"PUP-5699/master/inline-symlink-metadata","sha":"28f145809799413abc5c0d71610130f72caf364f","user":{"login":"whopper","id":507621,"avatar_url":"https://avatars.githubusercontent.com/u/507621?v=3","gravatar_id":"","url":"https://api.github.com/users/whopper","html_url":"https://github.com/whopper","followers_url":"https://api.github.com/users/whopper/followers","following_url":"https://api.github.com/users/whopper/following{/other_user}","gists_url":"https://api.github.com/users/whopper/gists{/gist_id}","starred_url":"https://api.github.com/users/whopper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whopper/subscriptions","organizations_url":"https://api.github.com/users/whopper/orgs","repos_url":"https://api.github.com/users/whopper/repos","events_url":"https://api.github.com/users/whopper/events{/privacy}","received_events_url":"https://api.github.com/users/whopper/received_events","type":"User","site_admin":false},"repo":{"id":4678592,"name":"puppet","full_name":"whopper/puppet","owner":{"login":"whopper","id":507621,"avatar_url":"https://avatars.githubusercontent.com/u/507621?v=3","gravatar_id":"","url":"https://api.github.com/users/whopper","html_url":"https://github.com/whopper","followers_url":"https://api.github.com/users/whopper/followers","following_url":"https://api.github.com/users/whopper/following{/other_user}","gists_url":"https://api.github.com/users/whopper/gists{/gist_id}","starred_url":"https://api.github.com/users/whopper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whopper/subscriptions","organizations_url":"https://api.github.com/users/whopper/orgs","repos_url":"https://api.github.com/users/whopper/repos","events_url":"https://api.github.com/users/whopper/events{/privacy}","received_events_url":"https://api.github.com/users/whopper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/whopper/puppet","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/whopper/puppet","forks_url":"https://api.github.com/repos/whopper/puppet/forks","keys_url":"https://api.github.com/repos/whopper/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whopper/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whopper/puppet/teams","hooks_url":"https://api.github.com/repos/whopper/puppet/hooks","issue_events_url":"https://api.github.com/repos/whopper/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/whopper/puppet/events","assignees_url":"https://api.github.com/repos/whopper/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/whopper/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/whopper/puppet/tags","blobs_url":"https://api.github.com/repos/whopper/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whopper/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whopper/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/whopper/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whopper/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/whopper/puppet/languages","stargazers_url":"https://api.github.com/repos/whopper/puppet/stargazers","contributors_url":"https://api.github.com/repos/whopper/puppet/contributors","subscribers_url":"https://api.github.com/repos/whopper/puppet/subscribers","subscription_url":"https://api.github.com/repos/whopper/puppet/subscription","commits_url":"https://api.github.com/repos/whopper/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/whopper/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/whopper/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/whopper/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/whopper/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/whopper/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whopper/puppet/merges","archive_url":"https://api.github.com/repos/whopper/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whopper/puppet/downloads","issues_url":"https://api.github.com/repos/whopper/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/whopper/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/whopper/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/whopper/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whopper/puppet/labels{/name}","releases_url":"https://api.github.com/repos/whopper/puppet/releases{/id}","deployments_url":"https://api.github.com/repos/whopper/puppet/deployments","created_at":"2012-06-15T18:31:29Z","updated_at":"2014-09-29T18:19:22Z","pushed_at":"2016-02-04T00:46:17Z","git_url":"git://github.com/whopper/puppet.git","ssh_url":"git@github.com:whopper/puppet.git","clone_url":"https://github.com/whopper/puppet.git","svn_url":"https://github.com/whopper/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":52134,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"715124af9c07a075243bb102650dbeed1aafe38c","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910744,"name":"puppet","full_name":"puppetlabs/puppet","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet","forks_url":"https://api.github.com/repos/puppetlabs/puppet/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppet/deployments","created_at":"2010-09-14T19:26:44Z","updated_at":"2016-02-04T10:33:35Z","pushed_at":"2016-02-04T12:04:56Z","git_url":"git://github.com/puppetlabs/puppet.git","ssh_url":"git@github.com:puppetlabs/puppet.git","clone_url":"https://github.com/puppetlabs/puppet.git","svn_url":"https://github.com/puppetlabs/puppet","homepage":"https://puppetlabs.com/puppet/what-is-puppet","size":78251,"stargazers_count":3797,"watchers_count":3797,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1566,"mirror_url":null,"open_issues_count":28,"forks":1566,"open_issues":28,"watchers":3797,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/4619"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/4619"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/4619"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/4619/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/4619/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/4619/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet/statuses/28f145809799413abc5c0d71610130f72caf364f"}}}}