{"action":"created","comment":{"url":"https://api.github.com/repos/allegro/hermes/pulls/comments/62026436","id":62026436,"diff_hunk":"@@ -1,10 +1,18 @@\n package pl.allegro.tech.hermes.consumers.consumer.sender;\n \n import pl.allegro.tech.hermes.api.EndpointAddress;\n+import pl.allegro.tech.hermes.api.Subscription;\n \n public interface ProtocolMessageSenderProvider {\n \n-    MessageSender create(EndpointAddress endpoint);\n+    @Deprecated\n+    default MessageSender create(EndpointAddress endpoint) {\n+        throw new UnsupportedOperationException();\n+    }\n+\n+    default MessageSender create(Subscription subscription) {\n+        return create(subscription.getEndpoint());","path":"hermes-consumers/src/main/java/pl/allegro/tech/hermes/consumers/consumer/sender/ProtocolMessageSenderProvider.java","position":15,"original_position":15,"commit_id":"7deb37e841fe8de20e50001181d5fdc0f6e4af28","original_commit_id":"7deb37e841fe8de20e50001181d5fdc0f6e4af28","user":{"login":"adamdubiel","id":5269406,"avatar_url":"https://avatars.githubusercontent.com/u/5269406?v=3","gravatar_id":"","url":"https://api.github.com/users/adamdubiel","html_url":"https://github.com/adamdubiel","followers_url":"https://api.github.com/users/adamdubiel/followers","following_url":"https://api.github.com/users/adamdubiel/following{/other_user}","gists_url":"https://api.github.com/users/adamdubiel/gists{/gist_id}","starred_url":"https://api.github.com/users/adamdubiel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamdubiel/subscriptions","organizations_url":"https://api.github.com/users/adamdubiel/orgs","repos_url":"https://api.github.com/users/adamdubiel/repos","events_url":"https://api.github.com/users/adamdubiel/events{/privacy}","received_events_url":"https://api.github.com/users/adamdubiel/received_events","type":"User","site_admin":false},"body":"ok, go for it","created_at":"2016-05-04T11:56:04Z","updated_at":"2016-05-04T11:56:05Z","html_url":"https://github.com/allegro/hermes/pull/459#discussion_r62026436","pull_request_url":"https://api.github.com/repos/allegro/hermes/pulls/459","_links":{"self":{"href":"https://api.github.com/repos/allegro/hermes/pulls/comments/62026436"},"html":{"href":"https://github.com/allegro/hermes/pull/459#discussion_r62026436"},"pull_request":{"href":"https://api.github.com/repos/allegro/hermes/pulls/459"}}},"pull_request":{"url":"https://api.github.com/repos/allegro/hermes/pulls/459","id":67501236,"html_url":"https://github.com/allegro/hermes/pull/459","diff_url":"https://github.com/allegro/hermes/pull/459.diff","patch_url":"https://github.com/allegro/hermes/pull/459.patch","issue_url":"https://api.github.com/repos/allegro/hermes/issues/459","number":459,"state":"open","locked":false,"title":"#458 | Timeouts configurable per subscription","user":{"login":"tmmi","id":9470151,"avatar_url":"https://avatars.githubusercontent.com/u/9470151?v=3","gravatar_id":"","url":"https://api.github.com/users/tmmi","html_url":"https://github.com/tmmi","followers_url":"https://api.github.com/users/tmmi/followers","following_url":"https://api.github.com/users/tmmi/following{/other_user}","gists_url":"https://api.github.com/users/tmmi/gists{/gist_id}","starred_url":"https://api.github.com/users/tmmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmmi/subscriptions","organizations_url":"https://api.github.com/users/tmmi/orgs","repos_url":"https://api.github.com/users/tmmi/repos","events_url":"https://api.github.com/users/tmmi/events{/privacy}","received_events_url":"https://api.github.com/users/tmmi/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-04-22T12:07:04Z","updated_at":"2016-05-04T11:56:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"daf0916577b5b3e5d36ce274646b368aa5a8a6b5","assignee":null,"milestone":{"url":"https://api.github.com/repos/allegro/hermes/milestones/15","html_url":"https://github.com/allegro/hermes/milestones/0.8.8","labels_url":"https://api.github.com/repos/allegro/hermes/milestones/15/labels","id":1731775,"number":15,"title":"0.8.8","description":null,"creator":{"login":"adamdubiel","id":5269406,"avatar_url":"https://avatars.githubusercontent.com/u/5269406?v=3","gravatar_id":"","url":"https://api.github.com/users/adamdubiel","html_url":"https://github.com/adamdubiel","followers_url":"https://api.github.com/users/adamdubiel/followers","following_url":"https://api.github.com/users/adamdubiel/following{/other_user}","gists_url":"https://api.github.com/users/adamdubiel/gists{/gist_id}","starred_url":"https://api.github.com/users/adamdubiel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamdubiel/subscriptions","organizations_url":"https://api.github.com/users/adamdubiel/orgs","repos_url":"https://api.github.com/users/adamdubiel/repos","events_url":"https://api.github.com/users/adamdubiel/events{/privacy}","received_events_url":"https://api.github.com/users/adamdubiel/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":0,"state":"open","created_at":"2016-04-26T12:51:26Z","updated_at":"2016-04-26T12:55:36Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/allegro/hermes/pulls/459/commits","review_comments_url":"https://api.github.com/repos/allegro/hermes/pulls/459/comments","review_comment_url":"https://api.github.com/repos/allegro/hermes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/allegro/hermes/issues/459/comments","statuses_url":"https://api.github.com/repos/allegro/hermes/statuses/7deb37e841fe8de20e50001181d5fdc0f6e4af28","head":{"label":"allegro:458_timeouts_per_subscription","ref":"458_timeouts_per_subscription","sha":"7deb37e841fe8de20e50001181d5fdc0f6e4af28","user":{"login":"allegro","id":562236,"avatar_url":"https://avatars.githubusercontent.com/u/562236?v=3","gravatar_id":"","url":"https://api.github.com/users/allegro","html_url":"https://github.com/allegro","followers_url":"https://api.github.com/users/allegro/followers","following_url":"https://api.github.com/users/allegro/following{/other_user}","gists_url":"https://api.github.com/users/allegro/gists{/gist_id}","starred_url":"https://api.github.com/users/allegro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allegro/subscriptions","organizations_url":"https://api.github.com/users/allegro/orgs","repos_url":"https://api.github.com/users/allegro/repos","events_url":"https://api.github.com/users/allegro/events{/privacy}","received_events_url":"https://api.github.com/users/allegro/received_events","type":"Organization","site_admin":false},"repo":{"id":35662043,"name":"hermes","full_name":"allegro/hermes","owner":{"login":"allegro","id":562236,"avatar_url":"https://avatars.githubusercontent.com/u/562236?v=3","gravatar_id":"","url":"https://api.github.com/users/allegro","html_url":"https://github.com/allegro","followers_url":"https://api.github.com/users/allegro/followers","following_url":"https://api.github.com/users/allegro/following{/other_user}","gists_url":"https://api.github.com/users/allegro/gists{/gist_id}","starred_url":"https://api.github.com/users/allegro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allegro/subscriptions","organizations_url":"https://api.github.com/users/allegro/orgs","repos_url":"https://api.github.com/users/allegro/repos","events_url":"https://api.github.com/users/allegro/events{/privacy}","received_events_url":"https://api.github.com/users/allegro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/allegro/hermes","description":"Fast and reliable message broker built on top of Kafka.","fork":false,"url":"https://api.github.com/repos/allegro/hermes","forks_url":"https://api.github.com/repos/allegro/hermes/forks","keys_url":"https://api.github.com/repos/allegro/hermes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/allegro/hermes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/allegro/hermes/teams","hooks_url":"https://api.github.com/repos/allegro/hermes/hooks","issue_events_url":"https://api.github.com/repos/allegro/hermes/issues/events{/number}","events_url":"https://api.github.com/repos/allegro/hermes/events","assignees_url":"https://api.github.com/repos/allegro/hermes/assignees{/user}","branches_url":"https://api.github.com/repos/allegro/hermes/branches{/branch}","tags_url":"https://api.github.com/repos/allegro/hermes/tags","blobs_url":"https://api.github.com/repos/allegro/hermes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/allegro/hermes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/allegro/hermes/git/refs{/sha}","trees_url":"https://api.github.com/repos/allegro/hermes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/allegro/hermes/statuses/{sha}","languages_url":"https://api.github.com/repos/allegro/hermes/languages","stargazers_url":"https://api.github.com/repos/allegro/hermes/stargazers","contributors_url":"https://api.github.com/repos/allegro/hermes/contributors","subscribers_url":"https://api.github.com/repos/allegro/hermes/subscribers","subscription_url":"https://api.github.com/repos/allegro/hermes/subscription","commits_url":"https://api.github.com/repos/allegro/hermes/commits{/sha}","git_commits_url":"https://api.github.com/repos/allegro/hermes/git/commits{/sha}","comments_url":"https://api.github.com/repos/allegro/hermes/comments{/number}","issue_comment_url":"https://api.github.com/repos/allegro/hermes/issues/comments{/number}","contents_url":"https://api.github.com/repos/allegro/hermes/contents/{+path}","compare_url":"https://api.github.com/repos/allegro/hermes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/allegro/hermes/merges","archive_url":"https://api.github.com/repos/allegro/hermes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/allegro/hermes/downloads","issues_url":"https://api.github.com/repos/allegro/hermes/issues{/number}","pulls_url":"https://api.github.com/repos/allegro/hermes/pulls{/number}","milestones_url":"https://api.github.com/repos/allegro/hermes/milestones{/number}","notifications_url":"https://api.github.com/repos/allegro/hermes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/allegro/hermes/labels{/name}","releases_url":"https://api.github.com/repos/allegro/hermes/releases{/id}","deployments_url":"https://api.github.com/repos/allegro/hermes/deployments","created_at":"2015-05-15T08:11:16Z","updated_at":"2016-05-04T10:02:35Z","pushed_at":"2016-05-04T11:43:21Z","git_url":"git://github.com/allegro/hermes.git","ssh_url":"git@github.com:allegro/hermes.git","clone_url":"https://github.com/allegro/hermes.git","svn_url":"https://github.com/allegro/hermes","homepage":"http://hermes.allegro.tech","size":4603,"stargazers_count":176,"watchers_count":176,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":40,"forks":32,"open_issues":40,"watchers":176,"default_branch":"master"}},"base":{"label":"allegro:develop","ref":"develop","sha":"ca3ce9732bf93c69989c7416b5655540e2c257c1","user":{"login":"allegro","id":562236,"avatar_url":"https://avatars.githubusercontent.com/u/562236?v=3","gravatar_id":"","url":"https://api.github.com/users/allegro","html_url":"https://github.com/allegro","followers_url":"https://api.github.com/users/allegro/followers","following_url":"https://api.github.com/users/allegro/following{/other_user}","gists_url":"https://api.github.com/users/allegro/gists{/gist_id}","starred_url":"https://api.github.com/users/allegro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allegro/subscriptions","organizations_url":"https://api.github.com/users/allegro/orgs","repos_url":"https://api.github.com/users/allegro/repos","events_url":"https://api.github.com/users/allegro/events{/privacy}","received_events_url":"https://api.github.com/users/allegro/received_events","type":"Organization","site_admin":false},"repo":{"id":35662043,"name":"hermes","full_name":"allegro/hermes","owner":{"login":"allegro","id":562236,"avatar_url":"https://avatars.githubusercontent.com/u/562236?v=3","gravatar_id":"","url":"https://api.github.com/users/allegro","html_url":"https://github.com/allegro","followers_url":"https://api.github.com/users/allegro/followers","following_url":"https://api.github.com/users/allegro/following{/other_user}","gists_url":"https://api.github.com/users/allegro/gists{/gist_id}","starred_url":"https://api.github.com/users/allegro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allegro/subscriptions","organizations_url":"https://api.github.com/users/allegro/orgs","repos_url":"https://api.github.com/users/allegro/repos","events_url":"https://api.github.com/users/allegro/events{/privacy}","received_events_url":"https://api.github.com/users/allegro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/allegro/hermes","description":"Fast and reliable message broker built on top of Kafka.","fork":false,"url":"https://api.github.com/repos/allegro/hermes","forks_url":"https://api.github.com/repos/allegro/hermes/forks","keys_url":"https://api.github.com/repos/allegro/hermes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/allegro/hermes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/allegro/hermes/teams","hooks_url":"https://api.github.com/repos/allegro/hermes/hooks","issue_events_url":"https://api.github.com/repos/allegro/hermes/issues/events{/number}","events_url":"https://api.github.com/repos/allegro/hermes/events","assignees_url":"https://api.github.com/repos/allegro/hermes/assignees{/user}","branches_url":"https://api.github.com/repos/allegro/hermes/branches{/branch}","tags_url":"https://api.github.com/repos/allegro/hermes/tags","blobs_url":"https://api.github.com/repos/allegro/hermes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/allegro/hermes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/allegro/hermes/git/refs{/sha}","trees_url":"https://api.github.com/repos/allegro/hermes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/allegro/hermes/statuses/{sha}","languages_url":"https://api.github.com/repos/allegro/hermes/languages","stargazers_url":"https://api.github.com/repos/allegro/hermes/stargazers","contributors_url":"https://api.github.com/repos/allegro/hermes/contributors","subscribers_url":"https://api.github.com/repos/allegro/hermes/subscribers","subscription_url":"https://api.github.com/repos/allegro/hermes/subscription","commits_url":"https://api.github.com/repos/allegro/hermes/commits{/sha}","git_commits_url":"https://api.github.com/repos/allegro/hermes/git/commits{/sha}","comments_url":"https://api.github.com/repos/allegro/hermes/comments{/number}","issue_comment_url":"https://api.github.com/repos/allegro/hermes/issues/comments{/number}","contents_url":"https://api.github.com/repos/allegro/hermes/contents/{+path}","compare_url":"https://api.github.com/repos/allegro/hermes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/allegro/hermes/merges","archive_url":"https://api.github.com/repos/allegro/hermes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/allegro/hermes/downloads","issues_url":"https://api.github.com/repos/allegro/hermes/issues{/number}","pulls_url":"https://api.github.com/repos/allegro/hermes/pulls{/number}","milestones_url":"https://api.github.com/repos/allegro/hermes/milestones{/number}","notifications_url":"https://api.github.com/repos/allegro/hermes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/allegro/hermes/labels{/name}","releases_url":"https://api.github.com/repos/allegro/hermes/releases{/id}","deployments_url":"https://api.github.com/repos/allegro/hermes/deployments","created_at":"2015-05-15T08:11:16Z","updated_at":"2016-05-04T10:02:35Z","pushed_at":"2016-05-04T11:43:21Z","git_url":"git://github.com/allegro/hermes.git","ssh_url":"git@github.com:allegro/hermes.git","clone_url":"https://github.com/allegro/hermes.git","svn_url":"https://github.com/allegro/hermes","homepage":"http://hermes.allegro.tech","size":4603,"stargazers_count":176,"watchers_count":176,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":40,"forks":32,"open_issues":40,"watchers":176,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/allegro/hermes/pulls/459"},"html":{"href":"https://github.com/allegro/hermes/pull/459"},"issue":{"href":"https://api.github.com/repos/allegro/hermes/issues/459"},"comments":{"href":"https://api.github.com/repos/allegro/hermes/issues/459/comments"},"review_comments":{"href":"https://api.github.com/repos/allegro/hermes/pulls/459/comments"},"review_comment":{"href":"https://api.github.com/repos/allegro/hermes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/allegro/hermes/pulls/459/commits"},"statuses":{"href":"https://api.github.com/repos/allegro/hermes/statuses/7deb37e841fe8de20e50001181d5fdc0f6e4af28"}}}}