{"action":"created","comment":{"url":"https://api.github.com/repos/delphix/dxLog/pulls/comments/49419712","id":49419712,"diff_hunk":"@@ -0,0 +1,172 @@\n+/*\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+/*\n+ * Copyright (c) 2015, 2016 by Delphix. All rights reserved.","path":"Gruntfile.js","position":16,"original_position":16,"commit_id":"03218a8fd08d40a6134ab5252eab5d9a8d716cd6","original_commit_id":"03218a8fd08d40a6134ab5252eab5d9a8d716cd6","user":{"login":"blazarus","id":1447698,"avatar_url":"https://avatars.githubusercontent.com/u/1447698?v=3","gravatar_id":"","url":"https://api.github.com/users/blazarus","html_url":"https://github.com/blazarus","followers_url":"https://api.github.com/users/blazarus/followers","following_url":"https://api.github.com/users/blazarus/following{/other_user}","gists_url":"https://api.github.com/users/blazarus/gists{/gist_id}","starred_url":"https://api.github.com/users/blazarus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blazarus/subscriptions","organizations_url":"https://api.github.com/users/blazarus/orgs","repos_url":"https://api.github.com/users/blazarus/repos","events_url":"https://api.github.com/users/blazarus/events{/privacy}","received_events_url":"https://api.github.com/users/blazarus/received_events","type":"User","site_admin":false},"body":"Huh. Fair enough.","created_at":"2016-01-12T06:33:37Z","updated_at":"2016-01-12T06:33:37Z","html_url":"https://github.com/delphix/dxLog/pull/1#discussion_r49419712","pull_request_url":"https://api.github.com/repos/delphix/dxLog/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/delphix/dxLog/pulls/comments/49419712"},"html":{"href":"https://github.com/delphix/dxLog/pull/1#discussion_r49419712"},"pull_request":{"href":"https://api.github.com/repos/delphix/dxLog/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/delphix/dxLog/pulls/1","id":54946653,"html_url":"https://github.com/delphix/dxLog/pull/1","diff_url":"https://github.com/delphix/dxLog/pull/1.diff","patch_url":"https://github.com/delphix/dxLog/pull/1.patch","issue_url":"https://api.github.com/repos/delphix/dxLog/issues/1","number":1,"state":"open","locked":false,"title":"First version","user":{"login":"dburrowes","id":16064912,"avatar_url":"https://avatars.githubusercontent.com/u/16064912?v=3","gravatar_id":"","url":"https://api.github.com/users/dburrowes","html_url":"https://github.com/dburrowes","followers_url":"https://api.github.com/users/dburrowes/followers","following_url":"https://api.github.com/users/dburrowes/following{/other_user}","gists_url":"https://api.github.com/users/dburrowes/gists{/gist_id}","starred_url":"https://api.github.com/users/dburrowes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dburrowes/subscriptions","organizations_url":"https://api.github.com/users/dburrowes/orgs","repos_url":"https://api.github.com/users/dburrowes/repos","events_url":"https://api.github.com/users/dburrowes/events{/privacy}","received_events_url":"https://api.github.com/users/dburrowes/received_events","type":"User","site_admin":false},"body":"PROBLEM\r\n===\r\nWe could/should move our logging to a consistent logging module (with an eye to eventually connecting that to angular, delivering the information to the server, etc).\r\n\r\nTHIS PROBLEM\r\n====\r\nThis is the general purpose dxLog module.  It will be consumed by the tranformation of dxData that is going on.\r\n\r\nDISCUSSION\r\n===\r\nAfter the previous review, I went back and decided to revisit some of my assumptions, and also move the piece, so to speak, another couple steps ahead of where I was thinking at the time.\r\nThus, this provides a full dxLog module, with all the build etc processes to support that.  \r\n\r\nSome things to note about this:\r\n* Do note that this is a source tree (a git repo), whose source directory contains information to build (among other things) an npm module.  Thus, you'll find a package.json, README, etc. for both the source tree and as a source file that will be added to the distribution npm module.\r\n* The build process will run our style checks, unit tests and code coverage against this code, report all this to the client, and then assemble the code both as an npm module and as an es5 javascript file\r\n\r\n-----\r\n\r\n\r\n\r\nRunning \"karma:dist\" (karma) task\r\nSafari 9.0.2 (Mac OS X 10.11.2): Executed 10 of 10 SUCCESS (0.107 secs / 0.026 secs)\r\nPhantomJS 2.0.0 (Mac OS X 0.0.0): Executed 10 of 10 SUCCESS (0.015 secs / 0.04 secs)\r\nChrome 47.0.2526 (Mac OS X 10.11.2): Executed 10 of 10 SUCCESS (0.073 secs / 0.026 secs)\r\nFirefox 42.0.0 (Mac OS X 10.11.0): Executed 10 of 10 SUCCESS (0.009 secs / 0.032 secs)\r\nTOTAL: 40 SUCCESS\r\n\r\nRunning \"_testreport\" task\r\nStyle Checks passed\r\nFull coverage details in: : file:///Users/dburrowes/dburrowes/dxLog/temp/testCoverage/report-html/index.html\r\nCoverge summary:\r\n\r\nRunning \"cat:testReport\" (cat) task\r\n```\r\n-----------|----------|----------|----------|----------|----------------|\r\nFile       |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |\r\n-----------|----------|----------|----------|----------|----------------|\r\n source/   |      100 |      100 |      100 |      100 |                |\r\n  index.js |      100 |      100 |      100 |      100 |                |\r\n-----------|----------|----------|----------|----------|----------------|\r\nAll files  |      100 |      100 |      100 |      100 |                |\r\n-----------|----------|----------|----------|----------|----------------|\r\n```\r\n\r\nRunning \"karma:dist\" (karma) task\r\nIE 9.0.0 (Windows 7 0.0.0): Executed 10 of 10 SUCCESS (0.059 secs / 0.008 secs)\r\nPhantomJS 2.0.0 (Windows 7 0.0.0): Executed 10 of 10 SUCCESS (0.024 secs / 0.011\r\n secs)\r\nChrome 47.0.2526 (Windows 7 0.0.0): Executed 10 of 10 SUCCESS (0.221 secs / 0.01\r\n2 secs)\r\nFirefox 43.0.0 (Windows 7 0.0.0): Executed 10 of 10 SUCCESS (14.726 secs / 0.008\r\n secs)\r\nTOTAL: 30 SUCCESS\r\n\r\nRunning \"_testreport\" task\r\nStyle Checks passed\r\nFull coverage details in: : file://c:\\Users\\IEUser\\dxLog/temp/testCoverage/repor\r\nt-html/index.html\r\nCoverge summary:\r\n\r\nRunning \"cat:testReport\" (cat) task\r\n```\r\n-----------|----------|----------|----------|----------|----------------|\r\nFile       |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |\r\n-----------|----------|----------|----------|----------|----------------|\r\n source\\   |      100 |      100 |      100 |      100 |                |\r\n  index.js |      100 |      100 |      100 |      100 |                |\r\n-----------|----------|----------|----------|----------|----------------|\r\nAll files  |      100 |      100 |      100 |      100 |                |\r\n-----------|----------|----------|----------|----------|----------------|\r\n```\r\n","created_at":"2016-01-04T06:27:40Z","updated_at":"2016-01-12T06:33:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"648dcf4e5c42376a853f8ddf6c7a692847ac8927","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/delphix/dxLog/pulls/1/commits","review_comments_url":"https://api.github.com/repos/delphix/dxLog/pulls/1/comments","review_comment_url":"https://api.github.com/repos/delphix/dxLog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/delphix/dxLog/issues/1/comments","statuses_url":"https://api.github.com/repos/delphix/dxLog/statuses/03218a8fd08d40a6134ab5252eab5d9a8d716cd6","head":{"label":"dburrowes:master","ref":"master","sha":"03218a8fd08d40a6134ab5252eab5d9a8d716cd6","user":{"login":"dburrowes","id":16064912,"avatar_url":"https://avatars.githubusercontent.com/u/16064912?v=3","gravatar_id":"","url":"https://api.github.com/users/dburrowes","html_url":"https://github.com/dburrowes","followers_url":"https://api.github.com/users/dburrowes/followers","following_url":"https://api.github.com/users/dburrowes/following{/other_user}","gists_url":"https://api.github.com/users/dburrowes/gists{/gist_id}","starred_url":"https://api.github.com/users/dburrowes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dburrowes/subscriptions","organizations_url":"https://api.github.com/users/dburrowes/orgs","repos_url":"https://api.github.com/users/dburrowes/repos","events_url":"https://api.github.com/users/dburrowes/events{/privacy}","received_events_url":"https://api.github.com/users/dburrowes/received_events","type":"User","site_admin":false},"repo":{"id":48976986,"name":"dxLog","full_name":"dburrowes/dxLog","owner":{"login":"dburrowes","id":16064912,"avatar_url":"https://avatars.githubusercontent.com/u/16064912?v=3","gravatar_id":"","url":"https://api.github.com/users/dburrowes","html_url":"https://github.com/dburrowes","followers_url":"https://api.github.com/users/dburrowes/followers","following_url":"https://api.github.com/users/dburrowes/following{/other_user}","gists_url":"https://api.github.com/users/dburrowes/gists{/gist_id}","starred_url":"https://api.github.com/users/dburrowes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dburrowes/subscriptions","organizations_url":"https://api.github.com/users/dburrowes/orgs","repos_url":"https://api.github.com/users/dburrowes/repos","events_url":"https://api.github.com/users/dburrowes/events{/privacy}","received_events_url":"https://api.github.com/users/dburrowes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dburrowes/dxLog","description":"dxLog is a nearly trivial logging system used by dxData. It has a couple advantages over writing directly to console.log and kin.","fork":true,"url":"https://api.github.com/repos/dburrowes/dxLog","forks_url":"https://api.github.com/repos/dburrowes/dxLog/forks","keys_url":"https://api.github.com/repos/dburrowes/dxLog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dburrowes/dxLog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dburrowes/dxLog/teams","hooks_url":"https://api.github.com/repos/dburrowes/dxLog/hooks","issue_events_url":"https://api.github.com/repos/dburrowes/dxLog/issues/events{/number}","events_url":"https://api.github.com/repos/dburrowes/dxLog/events","assignees_url":"https://api.github.com/repos/dburrowes/dxLog/assignees{/user}","branches_url":"https://api.github.com/repos/dburrowes/dxLog/branches{/branch}","tags_url":"https://api.github.com/repos/dburrowes/dxLog/tags","blobs_url":"https://api.github.com/repos/dburrowes/dxLog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dburrowes/dxLog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dburrowes/dxLog/git/refs{/sha}","trees_url":"https://api.github.com/repos/dburrowes/dxLog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dburrowes/dxLog/statuses/{sha}","languages_url":"https://api.github.com/repos/dburrowes/dxLog/languages","stargazers_url":"https://api.github.com/repos/dburrowes/dxLog/stargazers","contributors_url":"https://api.github.com/repos/dburrowes/dxLog/contributors","subscribers_url":"https://api.github.com/repos/dburrowes/dxLog/subscribers","subscription_url":"https://api.github.com/repos/dburrowes/dxLog/subscription","commits_url":"https://api.github.com/repos/dburrowes/dxLog/commits{/sha}","git_commits_url":"https://api.github.com/repos/dburrowes/dxLog/git/commits{/sha}","comments_url":"https://api.github.com/repos/dburrowes/dxLog/comments{/number}","issue_comment_url":"https://api.github.com/repos/dburrowes/dxLog/issues/comments{/number}","contents_url":"https://api.github.com/repos/dburrowes/dxLog/contents/{+path}","compare_url":"https://api.github.com/repos/dburrowes/dxLog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dburrowes/dxLog/merges","archive_url":"https://api.github.com/repos/dburrowes/dxLog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dburrowes/dxLog/downloads","issues_url":"https://api.github.com/repos/dburrowes/dxLog/issues{/number}","pulls_url":"https://api.github.com/repos/dburrowes/dxLog/pulls{/number}","milestones_url":"https://api.github.com/repos/dburrowes/dxLog/milestones{/number}","notifications_url":"https://api.github.com/repos/dburrowes/dxLog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dburrowes/dxLog/labels{/name}","releases_url":"https://api.github.com/repos/dburrowes/dxLog/releases{/id}","created_at":"2016-01-04T05:41:27Z","updated_at":"2016-01-04T06:26:25Z","pushed_at":"2016-01-04T06:26:25Z","git_url":"git://github.com/dburrowes/dxLog.git","ssh_url":"git@github.com:dburrowes/dxLog.git","clone_url":"https://github.com/dburrowes/dxLog.git","svn_url":"https://github.com/dburrowes/dxLog","homepage":null,"size":18,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"delphix:master","ref":"master","sha":"3c793af99bb71452d76f9b73e03c920ff71cd5a2","user":{"login":"delphix","id":682240,"avatar_url":"https://avatars.githubusercontent.com/u/682240?v=3","gravatar_id":"","url":"https://api.github.com/users/delphix","html_url":"https://github.com/delphix","followers_url":"https://api.github.com/users/delphix/followers","following_url":"https://api.github.com/users/delphix/following{/other_user}","gists_url":"https://api.github.com/users/delphix/gists{/gist_id}","starred_url":"https://api.github.com/users/delphix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delphix/subscriptions","organizations_url":"https://api.github.com/users/delphix/orgs","repos_url":"https://api.github.com/users/delphix/repos","events_url":"https://api.github.com/users/delphix/events{/privacy}","received_events_url":"https://api.github.com/users/delphix/received_events","type":"Organization","site_admin":false},"repo":{"id":48976572,"name":"dxLog","full_name":"delphix/dxLog","owner":{"login":"delphix","id":682240,"avatar_url":"https://avatars.githubusercontent.com/u/682240?v=3","gravatar_id":"","url":"https://api.github.com/users/delphix","html_url":"https://github.com/delphix","followers_url":"https://api.github.com/users/delphix/followers","following_url":"https://api.github.com/users/delphix/following{/other_user}","gists_url":"https://api.github.com/users/delphix/gists{/gist_id}","starred_url":"https://api.github.com/users/delphix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delphix/subscriptions","organizations_url":"https://api.github.com/users/delphix/orgs","repos_url":"https://api.github.com/users/delphix/repos","events_url":"https://api.github.com/users/delphix/events{/privacy}","received_events_url":"https://api.github.com/users/delphix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/delphix/dxLog","description":"dxLog is a nearly trivial logging system used by dxData. It has a couple advantages over writing directly to console.log and kin.","fork":false,"url":"https://api.github.com/repos/delphix/dxLog","forks_url":"https://api.github.com/repos/delphix/dxLog/forks","keys_url":"https://api.github.com/repos/delphix/dxLog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/delphix/dxLog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/delphix/dxLog/teams","hooks_url":"https://api.github.com/repos/delphix/dxLog/hooks","issue_events_url":"https://api.github.com/repos/delphix/dxLog/issues/events{/number}","events_url":"https://api.github.com/repos/delphix/dxLog/events","assignees_url":"https://api.github.com/repos/delphix/dxLog/assignees{/user}","branches_url":"https://api.github.com/repos/delphix/dxLog/branches{/branch}","tags_url":"https://api.github.com/repos/delphix/dxLog/tags","blobs_url":"https://api.github.com/repos/delphix/dxLog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/delphix/dxLog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/delphix/dxLog/git/refs{/sha}","trees_url":"https://api.github.com/repos/delphix/dxLog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/delphix/dxLog/statuses/{sha}","languages_url":"https://api.github.com/repos/delphix/dxLog/languages","stargazers_url":"https://api.github.com/repos/delphix/dxLog/stargazers","contributors_url":"https://api.github.com/repos/delphix/dxLog/contributors","subscribers_url":"https://api.github.com/repos/delphix/dxLog/subscribers","subscription_url":"https://api.github.com/repos/delphix/dxLog/subscription","commits_url":"https://api.github.com/repos/delphix/dxLog/commits{/sha}","git_commits_url":"https://api.github.com/repos/delphix/dxLog/git/commits{/sha}","comments_url":"https://api.github.com/repos/delphix/dxLog/comments{/number}","issue_comment_url":"https://api.github.com/repos/delphix/dxLog/issues/comments{/number}","contents_url":"https://api.github.com/repos/delphix/dxLog/contents/{+path}","compare_url":"https://api.github.com/repos/delphix/dxLog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/delphix/dxLog/merges","archive_url":"https://api.github.com/repos/delphix/dxLog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/delphix/dxLog/downloads","issues_url":"https://api.github.com/repos/delphix/dxLog/issues{/number}","pulls_url":"https://api.github.com/repos/delphix/dxLog/pulls{/number}","milestones_url":"https://api.github.com/repos/delphix/dxLog/milestones{/number}","notifications_url":"https://api.github.com/repos/delphix/dxLog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/delphix/dxLog/labels{/name}","releases_url":"https://api.github.com/repos/delphix/dxLog/releases{/id}","created_at":"2016-01-04T05:30:28Z","updated_at":"2016-01-04T05:30:28Z","pushed_at":"2016-01-04T06:27:40Z","git_url":"git://github.com/delphix/dxLog.git","ssh_url":"git@github.com:delphix/dxLog.git","clone_url":"https://github.com/delphix/dxLog.git","svn_url":"https://github.com/delphix/dxLog","homepage":null,"size":4,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/delphix/dxLog/pulls/1"},"html":{"href":"https://github.com/delphix/dxLog/pull/1"},"issue":{"href":"https://api.github.com/repos/delphix/dxLog/issues/1"},"comments":{"href":"https://api.github.com/repos/delphix/dxLog/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/delphix/dxLog/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/delphix/dxLog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/delphix/dxLog/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/delphix/dxLog/statuses/03218a8fd08d40a6134ab5252eab5d9a8d716cd6"}}}}