{"action":"created","issue":{"url":"https://api.github.com/repos/twingly/twingly-url/issues/104","repository_url":"https://api.github.com/repos/twingly/twingly-url","labels_url":"https://api.github.com/repos/twingly/twingly-url/issues/104/labels{/name}","comments_url":"https://api.github.com/repos/twingly/twingly-url/issues/104/comments","events_url":"https://api.github.com/repos/twingly/twingly-url/issues/104/events","html_url":"https://github.com/twingly/twingly-url/issues/104","id":187503444,"number":104,"title":"Dependencies not locked correctly","user":{"login":"dentarg","id":42626,"avatar_url":"https://avatars.githubusercontent.com/u/42626?v=3","gravatar_id":"","url":"https://api.github.com/users/dentarg","html_url":"https://github.com/dentarg","followers_url":"https://api.github.com/users/dentarg/followers","following_url":"https://api.github.com/users/dentarg/following{/other_user}","gists_url":"https://api.github.com/users/dentarg/gists{/gist_id}","starred_url":"https://api.github.com/users/dentarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dentarg/subscriptions","organizations_url":"https://api.github.com/users/dentarg/orgs","repos_url":"https://api.github.com/users/dentarg/repos","events_url":"https://api.github.com/users/dentarg/events{/privacy}","received_events_url":"https://api.github.com/users/dentarg/received_events","type":"User","site_admin":false},"labels":[{"id":57091456,"url":"https://api.github.com/repos/twingly/twingly-url/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-11-05T15:30:04Z","updated_at":"2016-11-05T15:52:54Z","closed_at":null,"body":"https://github.com/twingly/twingly-url/commit/b61f962115c7aa6e85f6da9c80dcac102d924e2e got it all wrong. Discovered as Addressable 2.5.0 was released yesterday (all Travis build failed).\r\n\r\n```\r\n$ rm Gemfile.lock\r\n\r\n~/twingly/ruby/twingly-url master\r\n$ bundle\r\nFetching gem metadata from https://rubygems.org/........\r\nFetching version metadata from https://rubygems.org/.\r\nResolving dependencies...\r\nUsing rake 10.5.0\r\nUsing coderay 1.1.1\r\nUsing diff-lcs 1.2.5\r\nUsing idn-ruby 0.1.0\r\nUsing method_source 0.8.2\r\nUsing slop 3.6.0\r\nUsing rspec-support 3.5.0\r\nUsing bundler 1.13.3\r\nUsing pry 0.10.4\r\nInstalling ruby-prof 0.16.2 with native extensions\r\nInstalling public_suffix 2.0.3\r\nInstalling rspec-core 3.5.4\r\nUsing rspec-expectations 3.5.0\r\nUsing rspec-mocks 3.5.0\r\nUsing rspec 3.5.0\r\nInstalling addressable 2.5.0\r\nUsing twingly-url 5.0.1 from source at `.`\r\nBundle complete! 5 Gemfile dependencies, 17 gems now installed.\r\nUse `bundle show [gemname]` to see where a bundled gem is installed.\r\n```\r\n\r\n```\r\n$ rm Gemfile.lock\r\n\r\n~/twingly/ruby/twingly-url master*\r\n$ git d\r\ndiff --git a/twingly-url.gemspec b/twingly-url.gemspec\r\nindex e5b5f6f..0034d19 100644\r\n--- a/twingly-url.gemspec\r\n+++ b/twingly-url.gemspec\r\n@@ -12,8 +12,8 @@ Gem::Specification.new do |s|\r\n   s.license     = \"MIT\"\r\n   s.required_ruby_version = \"~> 2.2\"\r\n\r\n-  s.add_dependency \"addressable\", \"~> 2.4\", \">= 2.4.0\"\r\n-  s.add_dependency \"public_suffix\", \"~> 2.0\", \">= 2.0.2\"\r\n+  s.add_dependency \"addressable\", \"~> 2.4\", \"<= 2.4.0\"\r\n+  s.add_dependency \"public_suffix\", \"~> 2.0\", \"<= 2.0.2\"\r\n   s.add_dependency \"idn-ruby\", \"~> 0.1\"\r\n\r\n   s.add_development_dependency \"rake\", \"~> 10\"\r\n\r\n~/twingly/ruby/twingly-url master*\r\n$ bundle\r\nFetching gem metadata from https://rubygems.org/........\r\nFetching version metadata from https://rubygems.org/.\r\nResolving dependencies...\r\nUsing rake 10.5.0\r\nUsing addressable 2.4.0\r\nUsing coderay 1.1.1\r\nUsing diff-lcs 1.2.5\r\nUsing idn-ruby 0.1.0\r\nUsing method_source 0.8.2\r\nUsing slop 3.6.0\r\nUsing public_suffix 2.0.2\r\nUsing rspec-support 3.5.0\r\nUsing ruby-prof 0.16.2\r\nUsing bundler 1.13.3\r\nUsing pry 0.10.4\r\nUsing twingly-url 5.0.1 from source at `.`\r\nUsing rspec-core 3.5.4\r\nUsing rspec-expectations 3.5.0\r\nUsing rspec-mocks 3.5.0\r\nUsing rspec 3.5.0\r\nBundle complete! 5 Gemfile dependencies, 17 gems now installed.\r\nUse `bundle show [gemname]` to see where a bundled gem is installed.\r\n```"},"comment":{"url":"https://api.github.com/repos/twingly/twingly-url/issues/comments/258620311","html_url":"https://github.com/twingly/twingly-url/issues/104#issuecomment-258620311","issue_url":"https://api.github.com/repos/twingly/twingly-url/issues/104","id":258620311,"user":{"login":"dentarg","id":42626,"avatar_url":"https://avatars.githubusercontent.com/u/42626?v=3","gravatar_id":"","url":"https://api.github.com/users/dentarg","html_url":"https://github.com/dentarg","followers_url":"https://api.github.com/users/dentarg/followers","following_url":"https://api.github.com/users/dentarg/following{/other_user}","gists_url":"https://api.github.com/users/dentarg/gists{/gist_id}","starred_url":"https://api.github.com/users/dentarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dentarg/subscriptions","organizations_url":"https://api.github.com/users/dentarg/orgs","repos_url":"https://api.github.com/users/dentarg/repos","events_url":"https://api.github.com/users/dentarg/events{/privacy}","received_events_url":"https://api.github.com/users/dentarg/received_events","type":"User","site_admin":false},"created_at":"2016-11-05T15:52:54Z","updated_at":"2016-11-05T15:52:54Z","body":"Re-open because what I added:\r\n\r\n```ruby\r\n  s.add_dependency \"addressable\", \"~> 2.4\", \"<= 2.4.0\"\r\n  s.add_dependency \"public_suffix\", \"~> 2.0\", \"<= 2.0.2\"\r\n```\r\n\r\n...doesn't make sense :) (there will likely never be any addressable 2.4.x version, and public_suffix can be locked directly)"}}
{"actor":{"display_login":"dentarg"}}