{"action":"created","comment":{"url":"https://api.github.com/repos/ScottLogic/StockFlux/pulls/comments/77257903","id":77257903,"diff_hunk":"@@ -48,6 +48,15 @@ class Favourites extends Component {\n         });\n     }\n \n+    componentWillReceiveProps(nextProps) {\n+        // onDragEnd is not called when a tile is successfully dragged into","path":"src/child/containers/sidebars/favourites/Favourites.js","position":5,"original_position":5,"commit_id":"a1a4c5068f82b34937cfa30a3312b1d521f4eff8","original_commit_id":"a1a4c5068f82b34937cfa30a3312b1d521f4eff8","user":{"login":"jleft","id":2017615,"avatar_url":"https://avatars.githubusercontent.com/u/2017615?v=3","gravatar_id":"","url":"https://api.github.com/users/jleft","html_url":"https://github.com/jleft","followers_url":"https://api.github.com/users/jleft/followers","following_url":"https://api.github.com/users/jleft/following{/other_user}","gists_url":"https://api.github.com/users/jleft/gists{/gist_id}","starred_url":"https://api.github.com/users/jleft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jleft/subscriptions","organizations_url":"https://api.github.com/users/jleft/orgs","repos_url":"https://api.github.com/users/jleft/repos","events_url":"https://api.github.com/users/jleft/events{/privacy}","received_events_url":"https://api.github.com/users/jleft/received_events","type":"User","site_admin":false},"body":"I think it _should_ be called - is it definitely not being called? And if so, any idea why?","created_at":"2016-09-01T21:31:08Z","updated_at":"2016-09-01T21:31:08Z","html_url":"https://github.com/ScottLogic/StockFlux/pull/894#discussion_r77257903","pull_request_url":"https://api.github.com/repos/ScottLogic/StockFlux/pulls/894","_links":{"self":{"href":"https://api.github.com/repos/ScottLogic/StockFlux/pulls/comments/77257903"},"html":{"href":"https://github.com/ScottLogic/StockFlux/pull/894#discussion_r77257903"},"pull_request":{"href":"https://api.github.com/repos/ScottLogic/StockFlux/pulls/894"}}},"pull_request":{"url":"https://api.github.com/repos/ScottLogic/StockFlux/pulls/894","id":82719484,"html_url":"https://github.com/ScottLogic/StockFlux/pull/894","diff_url":"https://github.com/ScottLogic/StockFlux/pull/894.diff","patch_url":"https://github.com/ScottLogic/StockFlux/pull/894.patch","issue_url":"https://api.github.com/repos/ScottLogic/StockFlux/issues/894","number":894,"state":"open","locked":false,"title":"feat: drag favourite from window x to window y","user":{"login":"jdhodges","id":14218569,"avatar_url":"https://avatars.githubusercontent.com/u/14218569?v=3","gravatar_id":"","url":"https://api.github.com/users/jdhodges","html_url":"https://github.com/jdhodges","followers_url":"https://api.github.com/users/jdhodges/followers","following_url":"https://api.github.com/users/jdhodges/following{/other_user}","gists_url":"https://api.github.com/users/jdhodges/gists{/gist_id}","starred_url":"https://api.github.com/users/jdhodges/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdhodges/subscriptions","organizations_url":"https://api.github.com/users/jdhodges/orgs","repos_url":"https://api.github.com/users/jdhodges/repos","events_url":"https://api.github.com/users/jdhodges/events{/privacy}","received_events_url":"https://api.github.com/users/jdhodges/received_events","type":"User","site_admin":false},"body":"replaces #864","created_at":"2016-08-25T13:28:43Z","updated_at":"2016-09-01T21:31:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"049d45d5303dbabd5a3504367eb55671ecbdba70","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ScottLogic/StockFlux/pulls/894/commits","review_comments_url":"https://api.github.com/repos/ScottLogic/StockFlux/pulls/894/comments","review_comment_url":"https://api.github.com/repos/ScottLogic/StockFlux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ScottLogic/StockFlux/issues/894/comments","statuses_url":"https://api.github.com/repos/ScottLogic/StockFlux/statuses/a1a4c5068f82b34937cfa30a3312b1d521f4eff8","head":{"label":"jdhodges:feat/drag-favourite-from-window-x-to-y","ref":"feat/drag-favourite-from-window-x-to-y","sha":"a1a4c5068f82b34937cfa30a3312b1d521f4eff8","user":{"login":"jdhodges","id":14218569,"avatar_url":"https://avatars.githubusercontent.com/u/14218569?v=3","gravatar_id":"","url":"https://api.github.com/users/jdhodges","html_url":"https://github.com/jdhodges","followers_url":"https://api.github.com/users/jdhodges/followers","following_url":"https://api.github.com/users/jdhodges/following{/other_user}","gists_url":"https://api.github.com/users/jdhodges/gists{/gist_id}","starred_url":"https://api.github.com/users/jdhodges/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdhodges/subscriptions","organizations_url":"https://api.github.com/users/jdhodges/orgs","repos_url":"https://api.github.com/users/jdhodges/repos","events_url":"https://api.github.com/users/jdhodges/events{/privacy}","received_events_url":"https://api.github.com/users/jdhodges/received_events","type":"User","site_admin":false},"repo":{"id":58470172,"name":"StockFlux","full_name":"jdhodges/StockFlux","owner":{"login":"jdhodges","id":14218569,"avatar_url":"https://avatars.githubusercontent.com/u/14218569?v=3","gravatar_id":"","url":"https://api.github.com/users/jdhodges","html_url":"https://github.com/jdhodges","followers_url":"https://api.github.com/users/jdhodges/followers","following_url":"https://api.github.com/users/jdhodges/following{/other_user}","gists_url":"https://api.github.com/users/jdhodges/gists{/gist_id}","starred_url":"https://api.github.com/users/jdhodges/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdhodges/subscriptions","organizations_url":"https://api.github.com/users/jdhodges/orgs","repos_url":"https://api.github.com/users/jdhodges/repos","events_url":"https://api.github.com/users/jdhodges/events{/privacy}","received_events_url":"https://api.github.com/users/jdhodges/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jdhodges/StockFlux","description":"StockFlux is a desktop application developed by Scott Logic that uses the OpenFin HTML5 container together with AngularJS, ES2015 and d3fc","fork":true,"url":"https://api.github.com/repos/jdhodges/StockFlux","forks_url":"https://api.github.com/repos/jdhodges/StockFlux/forks","keys_url":"https://api.github.com/repos/jdhodges/StockFlux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdhodges/StockFlux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdhodges/StockFlux/teams","hooks_url":"https://api.github.com/repos/jdhodges/StockFlux/hooks","issue_events_url":"https://api.github.com/repos/jdhodges/StockFlux/issues/events{/number}","events_url":"https://api.github.com/repos/jdhodges/StockFlux/events","assignees_url":"https://api.github.com/repos/jdhodges/StockFlux/assignees{/user}","branches_url":"https://api.github.com/repos/jdhodges/StockFlux/branches{/branch}","tags_url":"https://api.github.com/repos/jdhodges/StockFlux/tags","blobs_url":"https://api.github.com/repos/jdhodges/StockFlux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdhodges/StockFlux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdhodges/StockFlux/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdhodges/StockFlux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdhodges/StockFlux/statuses/{sha}","languages_url":"https://api.github.com/repos/jdhodges/StockFlux/languages","stargazers_url":"https://api.github.com/repos/jdhodges/StockFlux/stargazers","contributors_url":"https://api.github.com/repos/jdhodges/StockFlux/contributors","subscribers_url":"https://api.github.com/repos/jdhodges/StockFlux/subscribers","subscription_url":"https://api.github.com/repos/jdhodges/StockFlux/subscription","commits_url":"https://api.github.com/repos/jdhodges/StockFlux/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdhodges/StockFlux/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdhodges/StockFlux/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdhodges/StockFlux/issues/comments{/number}","contents_url":"https://api.github.com/repos/jdhodges/StockFlux/contents/{+path}","compare_url":"https://api.github.com/repos/jdhodges/StockFlux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdhodges/StockFlux/merges","archive_url":"https://api.github.com/repos/jdhodges/StockFlux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdhodges/StockFlux/downloads","issues_url":"https://api.github.com/repos/jdhodges/StockFlux/issues{/number}","pulls_url":"https://api.github.com/repos/jdhodges/StockFlux/pulls{/number}","milestones_url":"https://api.github.com/repos/jdhodges/StockFlux/milestones{/number}","notifications_url":"https://api.github.com/repos/jdhodges/StockFlux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdhodges/StockFlux/labels{/name}","releases_url":"https://api.github.com/repos/jdhodges/StockFlux/releases{/id}","deployments_url":"https://api.github.com/repos/jdhodges/StockFlux/deployments","created_at":"2016-05-10T14:53:12Z","updated_at":"2016-05-10T14:53:13Z","pushed_at":"2016-09-01T16:04:01Z","git_url":"git://github.com/jdhodges/StockFlux.git","ssh_url":"git@github.com:jdhodges/StockFlux.git","clone_url":"https://github.com/jdhodges/StockFlux.git","svn_url":"https://github.com/jdhodges/StockFlux","homepage":"","size":3030,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ScottLogic:react_redux","ref":"react_redux","sha":"de2bd994e7082b08609b2fef8935ada712928c77","user":{"login":"ScottLogic","id":2046037,"avatar_url":"https://avatars.githubusercontent.com/u/2046037?v=3","gravatar_id":"","url":"https://api.github.com/users/ScottLogic","html_url":"https://github.com/ScottLogic","followers_url":"https://api.github.com/users/ScottLogic/followers","following_url":"https://api.github.com/users/ScottLogic/following{/other_user}","gists_url":"https://api.github.com/users/ScottLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/ScottLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScottLogic/subscriptions","organizations_url":"https://api.github.com/users/ScottLogic/orgs","repos_url":"https://api.github.com/users/ScottLogic/repos","events_url":"https://api.github.com/users/ScottLogic/events{/privacy}","received_events_url":"https://api.github.com/users/ScottLogic/received_events","type":"Organization","site_admin":false},"repo":{"id":47250097,"name":"StockFlux","full_name":"ScottLogic/StockFlux","owner":{"login":"ScottLogic","id":2046037,"avatar_url":"https://avatars.githubusercontent.com/u/2046037?v=3","gravatar_id":"","url":"https://api.github.com/users/ScottLogic","html_url":"https://github.com/ScottLogic","followers_url":"https://api.github.com/users/ScottLogic/followers","following_url":"https://api.github.com/users/ScottLogic/following{/other_user}","gists_url":"https://api.github.com/users/ScottLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/ScottLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScottLogic/subscriptions","organizations_url":"https://api.github.com/users/ScottLogic/orgs","repos_url":"https://api.github.com/users/ScottLogic/repos","events_url":"https://api.github.com/users/ScottLogic/events{/privacy}","received_events_url":"https://api.github.com/users/ScottLogic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ScottLogic/StockFlux","description":"StockFlux is a desktop application developed by Scott Logic that uses the OpenFin HTML5 container together with AngularJS, ES2015 and d3fc","fork":false,"url":"https://api.github.com/repos/ScottLogic/StockFlux","forks_url":"https://api.github.com/repos/ScottLogic/StockFlux/forks","keys_url":"https://api.github.com/repos/ScottLogic/StockFlux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ScottLogic/StockFlux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ScottLogic/StockFlux/teams","hooks_url":"https://api.github.com/repos/ScottLogic/StockFlux/hooks","issue_events_url":"https://api.github.com/repos/ScottLogic/StockFlux/issues/events{/number}","events_url":"https://api.github.com/repos/ScottLogic/StockFlux/events","assignees_url":"https://api.github.com/repos/ScottLogic/StockFlux/assignees{/user}","branches_url":"https://api.github.com/repos/ScottLogic/StockFlux/branches{/branch}","tags_url":"https://api.github.com/repos/ScottLogic/StockFlux/tags","blobs_url":"https://api.github.com/repos/ScottLogic/StockFlux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ScottLogic/StockFlux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ScottLogic/StockFlux/git/refs{/sha}","trees_url":"https://api.github.com/repos/ScottLogic/StockFlux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ScottLogic/StockFlux/statuses/{sha}","languages_url":"https://api.github.com/repos/ScottLogic/StockFlux/languages","stargazers_url":"https://api.github.com/repos/ScottLogic/StockFlux/stargazers","contributors_url":"https://api.github.com/repos/ScottLogic/StockFlux/contributors","subscribers_url":"https://api.github.com/repos/ScottLogic/StockFlux/subscribers","subscription_url":"https://api.github.com/repos/ScottLogic/StockFlux/subscription","commits_url":"https://api.github.com/repos/ScottLogic/StockFlux/commits{/sha}","git_commits_url":"https://api.github.com/repos/ScottLogic/StockFlux/git/commits{/sha}","comments_url":"https://api.github.com/repos/ScottLogic/StockFlux/comments{/number}","issue_comment_url":"https://api.github.com/repos/ScottLogic/StockFlux/issues/comments{/number}","contents_url":"https://api.github.com/repos/ScottLogic/StockFlux/contents/{+path}","compare_url":"https://api.github.com/repos/ScottLogic/StockFlux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ScottLogic/StockFlux/merges","archive_url":"https://api.github.com/repos/ScottLogic/StockFlux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ScottLogic/StockFlux/downloads","issues_url":"https://api.github.com/repos/ScottLogic/StockFlux/issues{/number}","pulls_url":"https://api.github.com/repos/ScottLogic/StockFlux/pulls{/number}","milestones_url":"https://api.github.com/repos/ScottLogic/StockFlux/milestones{/number}","notifications_url":"https://api.github.com/repos/ScottLogic/StockFlux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ScottLogic/StockFlux/labels{/name}","releases_url":"https://api.github.com/repos/ScottLogic/StockFlux/releases{/id}","deployments_url":"https://api.github.com/repos/ScottLogic/StockFlux/deployments","created_at":"2015-12-02T09:18:18Z","updated_at":"2016-08-27T16:17:13Z","pushed_at":"2016-09-01T19:21:51Z","git_url":"git://github.com/ScottLogic/StockFlux.git","ssh_url":"git@github.com:ScottLogic/StockFlux.git","clone_url":"https://github.com/ScottLogic/StockFlux.git","svn_url":"https://github.com/ScottLogic/StockFlux","homepage":"","size":5776,"stargazers_count":26,"watchers_count":26,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":11,"mirror_url":null,"open_issues_count":47,"forks":11,"open_issues":47,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ScottLogic/StockFlux/pulls/894"},"html":{"href":"https://github.com/ScottLogic/StockFlux/pull/894"},"issue":{"href":"https://api.github.com/repos/ScottLogic/StockFlux/issues/894"},"comments":{"href":"https://api.github.com/repos/ScottLogic/StockFlux/issues/894/comments"},"review_comments":{"href":"https://api.github.com/repos/ScottLogic/StockFlux/pulls/894/comments"},"review_comment":{"href":"https://api.github.com/repos/ScottLogic/StockFlux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ScottLogic/StockFlux/pulls/894/commits"},"statuses":{"href":"https://api.github.com/repos/ScottLogic/StockFlux/statuses/a1a4c5068f82b34937cfa30a3312b1d521f4eff8"}}}}
{"actor":{"display_login":"jleft"}}