{"action":"created","issue":{"url":"https://api.github.com/repos/BelaPlatform/Bela/issues/170","repository_url":"https://api.github.com/repos/BelaPlatform/Bela","labels_url":"https://api.github.com/repos/BelaPlatform/Bela/issues/170/labels{/name}","comments_url":"https://api.github.com/repos/BelaPlatform/Bela/issues/170/comments","events_url":"https://api.github.com/repos/BelaPlatform/Bela/issues/170/events","html_url":"https://github.com/BelaPlatform/Bela/issues/170","id":183267854,"number":170,"title":"Example: sinetone_optimized ","user":{"login":"roberthjack","id":11576979,"avatar_url":"https://avatars.githubusercontent.com/u/11576979?v=3","gravatar_id":"","url":"https://api.github.com/users/roberthjack","html_url":"https://github.com/roberthjack","followers_url":"https://api.github.com/users/roberthjack/followers","following_url":"https://api.github.com/users/roberthjack/following{/other_user}","gists_url":"https://api.github.com/users/roberthjack/gists{/gist_id}","starred_url":"https://api.github.com/users/roberthjack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roberthjack/subscriptions","organizations_url":"https://api.github.com/users/roberthjack/orgs","repos_url":"https://api.github.com/users/roberthjack/repos","events_url":"https://api.github.com/users/roberthjack/events{/privacy}","received_events_url":"https://api.github.com/users/roberthjack/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/BelaPlatform/Bela/labels/resolved","name":"resolved","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-16T13:48:56Z","updated_at":"2016-10-16T15:48:34Z","closed_at":null,"body":"Should perhaps be more than a single frequency played by 120 oscillators, oscillator bank?"},"comment":{"url":"https://api.github.com/repos/BelaPlatform/Bela/issues/comments/254054660","html_url":"https://github.com/BelaPlatform/Bela/issues/170#issuecomment-254054660","issue_url":"https://api.github.com/repos/BelaPlatform/Bela/issues/170","id":254054660,"user":{"login":"giuliomoro","id":4260604,"avatar_url":"https://avatars.githubusercontent.com/u/4260604?v=3","gravatar_id":"","url":"https://api.github.com/users/giuliomoro","html_url":"https://github.com/giuliomoro","followers_url":"https://api.github.com/users/giuliomoro/followers","following_url":"https://api.github.com/users/giuliomoro/following{/other_user}","gists_url":"https://api.github.com/users/giuliomoro/gists{/gist_id}","starred_url":"https://api.github.com/users/giuliomoro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giuliomoro/subscriptions","organizations_url":"https://api.github.com/users/giuliomoro/orgs","repos_url":"https://api.github.com/users/giuliomoro/repos","events_url":"https://api.github.com/users/giuliomoro/events{/privacy}","received_events_url":"https://api.github.com/users/giuliomoro/received_events","type":"User","site_admin":false},"created_at":"2016-10-16T15:48:34Z","updated_at":"2016-10-16T15:48:34Z","body":"Very nice example.\r\nCan you make it stereo ?\r\n\r\nSome remarks:\r\n\r\n- we should replace all the instances of the likes of \r\n```\r\n\t\t\tif(gPhases[k] > 2.0 * M_PI)\r\n\t\t\t\tgPhases[k] -= 2.0 * M_PI;\r\n```\r\nwith \r\n```\r\n\t\t\tif(gPhases[k] > M_PI)\r\n\t\t\t\tgPhases[k] -= 2.0 * M_PI;\r\n```\r\nbecause approximated version of sinf are more likely to work nicely in the `-M_PI,M_PI` range.\r\n- there are two ways of doing things more efficiently than this.\r\nOne is [`sinfv_c` / `sinfv_neon`](http://192.168.7.2/Documentation/math__neon_8h.html#a1d6a154aac95df2c81c6b5ef8f625005), which computes the sine of an array of phases. This is at least3X faster than the code you wrote.\r\nThe other one is the current oscillator-bank example, which is even faster.\r\nI am not sure if we should provide example for each of them or create a blog article about \"incrementally make the best oscillator bank\". Thoughts?\r\n"}}
{"actor":{"display_login":"giuliomoro"}}