{"action":"closed","number":221,"pull_request":{"url":"https://api.github.com/repos/Lukasa/hyper/pulls/221","id":66219260,"html_url":"https://github.com/Lukasa/hyper/pull/221","diff_url":"https://github.com/Lukasa/hyper/pull/221.diff","patch_url":"https://github.com/Lukasa/hyper/pull/221.patch","issue_url":"https://api.github.com/repos/Lukasa/hyper/issues/221","number":221,"state":"closed","locked":false,"title":"Improve handling of socket errors","user":{"login":"tbetbetbe","id":9272342,"avatar_url":"https://avatars.githubusercontent.com/u/9272342?v=3","gravatar_id":"","url":"https://api.github.com/users/tbetbetbe","html_url":"https://github.com/tbetbetbe","followers_url":"https://api.github.com/users/tbetbetbe/followers","following_url":"https://api.github.com/users/tbetbetbe/following{/other_user}","gists_url":"https://api.github.com/users/tbetbetbe/gists{/gist_id}","starred_url":"https://api.github.com/users/tbetbetbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbetbetbe/subscriptions","organizations_url":"https://api.github.com/users/tbetbetbe/orgs","repos_url":"https://api.github.com/users/tbetbetbe/repos","events_url":"https://api.github.com/users/tbetbetbe/events{/privacy}","received_events_url":"https://api.github.com/users/tbetbetbe/received_events","type":"User","site_admin":false},"body":"- Use the default connection timeout set by socket.setdefaulttimeout().\r\n\r\n* I.e, don't specify one, until there is [an API][1] for timeouts, it's\r\nprobably better for libraries to be able to set the socket timeout\r\noutside of hyper via [setdefaulttimeout][2]\r\n\r\n- Updates error handling to simulate blocking behaviour when the socket\r\n  is in timeout mode (which is internally a kind of non-blocking\r\n  mode). Specifically, during reads, add\r\n  * handling of specific ssl.SSLErrors WANT_READ and WANT_WRITE\r\n  * handling of errno.EAGAIN and errno.EINTR\r\n\r\n[1]: https://github.com/Lukasa/hyper/issues/187\r\n[2]: https://docs.python.org/2/library/socket.html#socket.setdefaulttimeout","created_at":"2016-04-12T20:07:00Z","updated_at":"2016-04-13T14:42:02Z","closed_at":"2016-04-13T14:42:02Z","merged_at":"2016-04-13T14:42:02Z","merge_commit_sha":"9a9b04887247a32a0f626e23f0cd6f33a483e86a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Lukasa/hyper/pulls/221/commits","review_comments_url":"https://api.github.com/repos/Lukasa/hyper/pulls/221/comments","review_comment_url":"https://api.github.com/repos/Lukasa/hyper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Lukasa/hyper/issues/221/comments","statuses_url":"https://api.github.com/repos/Lukasa/hyper/statuses/1d1d9814123883c05d494be29dbe91792c244494","head":{"label":"tbetbetbe:development-ssl-connection-error-reduction","ref":"development-ssl-connection-error-reduction","sha":"1d1d9814123883c05d494be29dbe91792c244494","user":{"login":"tbetbetbe","id":9272342,"avatar_url":"https://avatars.githubusercontent.com/u/9272342?v=3","gravatar_id":"","url":"https://api.github.com/users/tbetbetbe","html_url":"https://github.com/tbetbetbe","followers_url":"https://api.github.com/users/tbetbetbe/followers","following_url":"https://api.github.com/users/tbetbetbe/following{/other_user}","gists_url":"https://api.github.com/users/tbetbetbe/gists{/gist_id}","starred_url":"https://api.github.com/users/tbetbetbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbetbetbe/subscriptions","organizations_url":"https://api.github.com/users/tbetbetbe/orgs","repos_url":"https://api.github.com/users/tbetbetbe/repos","events_url":"https://api.github.com/users/tbetbetbe/events{/privacy}","received_events_url":"https://api.github.com/users/tbetbetbe/received_events","type":"User","site_admin":false},"repo":{"id":47692989,"name":"hyper","full_name":"tbetbetbe/hyper","owner":{"login":"tbetbetbe","id":9272342,"avatar_url":"https://avatars.githubusercontent.com/u/9272342?v=3","gravatar_id":"","url":"https://api.github.com/users/tbetbetbe","html_url":"https://github.com/tbetbetbe","followers_url":"https://api.github.com/users/tbetbetbe/followers","following_url":"https://api.github.com/users/tbetbetbe/following{/other_user}","gists_url":"https://api.github.com/users/tbetbetbe/gists{/gist_id}","starred_url":"https://api.github.com/users/tbetbetbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbetbetbe/subscriptions","organizations_url":"https://api.github.com/users/tbetbetbe/orgs","repos_url":"https://api.github.com/users/tbetbetbe/repos","events_url":"https://api.github.com/users/tbetbetbe/events{/privacy}","received_events_url":"https://api.github.com/users/tbetbetbe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tbetbetbe/hyper","description":"HTTP/2 for Python.","fork":true,"url":"https://api.github.com/repos/tbetbetbe/hyper","forks_url":"https://api.github.com/repos/tbetbetbe/hyper/forks","keys_url":"https://api.github.com/repos/tbetbetbe/hyper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tbetbetbe/hyper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tbetbetbe/hyper/teams","hooks_url":"https://api.github.com/repos/tbetbetbe/hyper/hooks","issue_events_url":"https://api.github.com/repos/tbetbetbe/hyper/issues/events{/number}","events_url":"https://api.github.com/repos/tbetbetbe/hyper/events","assignees_url":"https://api.github.com/repos/tbetbetbe/hyper/assignees{/user}","branches_url":"https://api.github.com/repos/tbetbetbe/hyper/branches{/branch}","tags_url":"https://api.github.com/repos/tbetbetbe/hyper/tags","blobs_url":"https://api.github.com/repos/tbetbetbe/hyper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tbetbetbe/hyper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tbetbetbe/hyper/git/refs{/sha}","trees_url":"https://api.github.com/repos/tbetbetbe/hyper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tbetbetbe/hyper/statuses/{sha}","languages_url":"https://api.github.com/repos/tbetbetbe/hyper/languages","stargazers_url":"https://api.github.com/repos/tbetbetbe/hyper/stargazers","contributors_url":"https://api.github.com/repos/tbetbetbe/hyper/contributors","subscribers_url":"https://api.github.com/repos/tbetbetbe/hyper/subscribers","subscription_url":"https://api.github.com/repos/tbetbetbe/hyper/subscription","commits_url":"https://api.github.com/repos/tbetbetbe/hyper/commits{/sha}","git_commits_url":"https://api.github.com/repos/tbetbetbe/hyper/git/commits{/sha}","comments_url":"https://api.github.com/repos/tbetbetbe/hyper/comments{/number}","issue_comment_url":"https://api.github.com/repos/tbetbetbe/hyper/issues/comments{/number}","contents_url":"https://api.github.com/repos/tbetbetbe/hyper/contents/{+path}","compare_url":"https://api.github.com/repos/tbetbetbe/hyper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tbetbetbe/hyper/merges","archive_url":"https://api.github.com/repos/tbetbetbe/hyper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tbetbetbe/hyper/downloads","issues_url":"https://api.github.com/repos/tbetbetbe/hyper/issues{/number}","pulls_url":"https://api.github.com/repos/tbetbetbe/hyper/pulls{/number}","milestones_url":"https://api.github.com/repos/tbetbetbe/hyper/milestones{/number}","notifications_url":"https://api.github.com/repos/tbetbetbe/hyper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tbetbetbe/hyper/labels{/name}","releases_url":"https://api.github.com/repos/tbetbetbe/hyper/releases{/id}","deployments_url":"https://api.github.com/repos/tbetbetbe/hyper/deployments","created_at":"2015-12-09T13:27:44Z","updated_at":"2015-12-09T13:27:45Z","pushed_at":"2016-04-12T20:24:25Z","git_url":"git://github.com/tbetbetbe/hyper.git","ssh_url":"git@github.com:tbetbetbe/hyper.git","clone_url":"https://github.com/tbetbetbe/hyper.git","svn_url":"https://github.com/tbetbetbe/hyper","homepage":"http://hyper.rtfd.org/en/latest/","size":11745,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"Lukasa:development","ref":"development","sha":"0837669922e12579084fff58e31b05b9b198d30e","user":{"login":"Lukasa","id":1382556,"avatar_url":"https://avatars.githubusercontent.com/u/1382556?v=3","gravatar_id":"","url":"https://api.github.com/users/Lukasa","html_url":"https://github.com/Lukasa","followers_url":"https://api.github.com/users/Lukasa/followers","following_url":"https://api.github.com/users/Lukasa/following{/other_user}","gists_url":"https://api.github.com/users/Lukasa/gists{/gist_id}","starred_url":"https://api.github.com/users/Lukasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lukasa/subscriptions","organizations_url":"https://api.github.com/users/Lukasa/orgs","repos_url":"https://api.github.com/users/Lukasa/repos","events_url":"https://api.github.com/users/Lukasa/events{/privacy}","received_events_url":"https://api.github.com/users/Lukasa/received_events","type":"User","site_admin":false},"repo":{"id":16165969,"name":"hyper","full_name":"Lukasa/hyper","owner":{"login":"Lukasa","id":1382556,"avatar_url":"https://avatars.githubusercontent.com/u/1382556?v=3","gravatar_id":"","url":"https://api.github.com/users/Lukasa","html_url":"https://github.com/Lukasa","followers_url":"https://api.github.com/users/Lukasa/followers","following_url":"https://api.github.com/users/Lukasa/following{/other_user}","gists_url":"https://api.github.com/users/Lukasa/gists{/gist_id}","starred_url":"https://api.github.com/users/Lukasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lukasa/subscriptions","organizations_url":"https://api.github.com/users/Lukasa/orgs","repos_url":"https://api.github.com/users/Lukasa/repos","events_url":"https://api.github.com/users/Lukasa/events{/privacy}","received_events_url":"https://api.github.com/users/Lukasa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Lukasa/hyper","description":"HTTP/2 for Python.","fork":false,"url":"https://api.github.com/repos/Lukasa/hyper","forks_url":"https://api.github.com/repos/Lukasa/hyper/forks","keys_url":"https://api.github.com/repos/Lukasa/hyper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lukasa/hyper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lukasa/hyper/teams","hooks_url":"https://api.github.com/repos/Lukasa/hyper/hooks","issue_events_url":"https://api.github.com/repos/Lukasa/hyper/issues/events{/number}","events_url":"https://api.github.com/repos/Lukasa/hyper/events","assignees_url":"https://api.github.com/repos/Lukasa/hyper/assignees{/user}","branches_url":"https://api.github.com/repos/Lukasa/hyper/branches{/branch}","tags_url":"https://api.github.com/repos/Lukasa/hyper/tags","blobs_url":"https://api.github.com/repos/Lukasa/hyper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lukasa/hyper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lukasa/hyper/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lukasa/hyper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lukasa/hyper/statuses/{sha}","languages_url":"https://api.github.com/repos/Lukasa/hyper/languages","stargazers_url":"https://api.github.com/repos/Lukasa/hyper/stargazers","contributors_url":"https://api.github.com/repos/Lukasa/hyper/contributors","subscribers_url":"https://api.github.com/repos/Lukasa/hyper/subscribers","subscription_url":"https://api.github.com/repos/Lukasa/hyper/subscription","commits_url":"https://api.github.com/repos/Lukasa/hyper/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lukasa/hyper/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lukasa/hyper/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lukasa/hyper/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lukasa/hyper/contents/{+path}","compare_url":"https://api.github.com/repos/Lukasa/hyper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lukasa/hyper/merges","archive_url":"https://api.github.com/repos/Lukasa/hyper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lukasa/hyper/downloads","issues_url":"https://api.github.com/repos/Lukasa/hyper/issues{/number}","pulls_url":"https://api.github.com/repos/Lukasa/hyper/pulls{/number}","milestones_url":"https://api.github.com/repos/Lukasa/hyper/milestones{/number}","notifications_url":"https://api.github.com/repos/Lukasa/hyper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lukasa/hyper/labels{/name}","releases_url":"https://api.github.com/repos/Lukasa/hyper/releases{/id}","deployments_url":"https://api.github.com/repos/Lukasa/hyper/deployments","created_at":"2014-01-23T07:53:47Z","updated_at":"2016-04-11T06:02:14Z","pushed_at":"2016-04-13T14:42:02Z","git_url":"git://github.com/Lukasa/hyper.git","ssh_url":"git@github.com:Lukasa/hyper.git","clone_url":"https://github.com/Lukasa/hyper.git","svn_url":"https://github.com/Lukasa/hyper","homepage":"http://hyper.rtfd.org/en/latest/","size":12216,"stargazers_count":461,"watchers_count":461,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"open_issues_count":29,"forks":65,"open_issues":29,"watchers":461,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/Lukasa/hyper/pulls/221"},"html":{"href":"https://github.com/Lukasa/hyper/pull/221"},"issue":{"href":"https://api.github.com/repos/Lukasa/hyper/issues/221"},"comments":{"href":"https://api.github.com/repos/Lukasa/hyper/issues/221/comments"},"review_comments":{"href":"https://api.github.com/repos/Lukasa/hyper/pulls/221/comments"},"review_comment":{"href":"https://api.github.com/repos/Lukasa/hyper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Lukasa/hyper/pulls/221/commits"},"statuses":{"href":"https://api.github.com/repos/Lukasa/hyper/statuses/1d1d9814123883c05d494be29dbe91792c244494"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Lukasa","id":1382556,"avatar_url":"https://avatars.githubusercontent.com/u/1382556?v=3","gravatar_id":"","url":"https://api.github.com/users/Lukasa","html_url":"https://github.com/Lukasa","followers_url":"https://api.github.com/users/Lukasa/followers","following_url":"https://api.github.com/users/Lukasa/following{/other_user}","gists_url":"https://api.github.com/users/Lukasa/gists{/gist_id}","starred_url":"https://api.github.com/users/Lukasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lukasa/subscriptions","organizations_url":"https://api.github.com/users/Lukasa/orgs","repos_url":"https://api.github.com/users/Lukasa/repos","events_url":"https://api.github.com/users/Lukasa/events{/privacy}","received_events_url":"https://api.github.com/users/Lukasa/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":1,"additions":22,"deletions":3,"changed_files":2}}