{"action":"opened","issue":{"url":"https://api.github.com/repos/honeybee/honeybee-agavi-cmf-vendor/issues/34","repository_url":"https://api.github.com/repos/honeybee/honeybee-agavi-cmf-vendor","labels_url":"https://api.github.com/repos/honeybee/honeybee-agavi-cmf-vendor/issues/34/labels{/name}","comments_url":"https://api.github.com/repos/honeybee/honeybee-agavi-cmf-vendor/issues/34/comments","events_url":"https://api.github.com/repos/honeybee/honeybee-agavi-cmf-vendor/issues/34/events","html_url":"https://github.com/honeybee/honeybee-agavi-cmf-vendor/issues/34","id":188783533,"number":34,"title":"Embed rendering should consider settings from the parent ListAttribute renderer","user":{"login":"Pictor13","id":6748874,"avatar_url":"https://avatars.githubusercontent.com/u/6748874?v=3","gravatar_id":"","url":"https://api.github.com/users/Pictor13","html_url":"https://github.com/Pictor13","followers_url":"https://api.github.com/users/Pictor13/followers","following_url":"https://api.github.com/users/Pictor13/following{/other_user}","gists_url":"https://api.github.com/users/Pictor13/gists{/gist_id}","starred_url":"https://api.github.com/users/Pictor13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pictor13/subscriptions","organizations_url":"https://api.github.com/users/Pictor13/orgs","repos_url":"https://api.github.com/users/Pictor13/repos","events_url":"https://api.github.com/users/Pictor13/events{/privacy}","received_events_url":"https://api.github.com/users/Pictor13/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"Pictor13","id":6748874,"avatar_url":"https://avatars.githubusercontent.com/u/6748874?v=3","gravatar_id":"","url":"https://api.github.com/users/Pictor13","html_url":"https://github.com/Pictor13","followers_url":"https://api.github.com/users/Pictor13/followers","following_url":"https://api.github.com/users/Pictor13/following{/other_user}","gists_url":"https://api.github.com/users/Pictor13/gists{/gist_id}","starred_url":"https://api.github.com/users/Pictor13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pictor13/subscriptions","organizations_url":"https://api.github.com/users/Pictor13/orgs","repos_url":"https://api.github.com/users/Pictor13/repos","events_url":"https://api.github.com/users/Pictor13/events{/privacy}","received_events_url":"https://api.github.com/users/Pictor13/received_events","type":"User","site_admin":false},"assignees":[{"login":"Pictor13","id":6748874,"avatar_url":"https://avatars.githubusercontent.com/u/6748874?v=3","gravatar_id":"","url":"https://api.github.com/users/Pictor13","html_url":"https://github.com/Pictor13","followers_url":"https://api.github.com/users/Pictor13/followers","following_url":"https://api.github.com/users/Pictor13/following{/other_user}","gists_url":"https://api.github.com/users/Pictor13/gists{/gist_id}","starred_url":"https://api.github.com/users/Pictor13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pictor13/subscriptions","organizations_url":"https://api.github.com/users/Pictor13/orgs","repos_url":"https://api.github.com/users/Pictor13/repos","events_url":"https://api.github.com/users/Pictor13/events{/privacy}","received_events_url":"https://api.github.com/users/Pictor13/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2016-11-11T15:25:26Z","updated_at":"2016-11-11T15:25:26Z","closed_at":null,"body":"*Embed* and *Resource/Embed* actions extend the **view_config** from the *Resource/Modify* action.\r\nAfter the changes into the *EntityRenderer* for supporting render configs per-attribute-type (https://github.com/honeybee/honeybee-agavi-cmf-vendor/commit/0e27d77705ced34f2a2ceff8c43928447af4cfff#diff-432b947b0745690628fc16b20021548fR87) one is induced to define settings for the subject **entity_reference_list_attribute** instead of duplicating them for each entity-reference.\r\n\r\nE.g.\r\n```\r\n<renderer_config subject=\"entity_reference_list_attribute\">\r\n    <settings>\r\n        <setting name=\"entity_template\">html/embedded_entity/as_fields_with_viewtemplate_without_tabs.twig</setting>\r\n    </settings>\r\n</renderer_config>\r\n```\r\ninstead of (multiple times)\r\n```\r\n<renderer_config subject=\"<vendor>.<package>.<resource_prefix>.<entity_reference_list_attribute>.<reference_type_prefix>\">\r\n    <settings>\r\n        <setting name=\"template\">html/embedded_entity/as_fields_with_viewtemplate_without_tabs.twig</setting>\r\n    </settings>\r\n</renderer_config>\r\n```\r\n\r\nBut the rendering of embeds does not get any propagated rendering setting from the attribute they belong to (*entity-reference-list* or *embedded-entity-list*).\r\n\r\nIn particular the embed rendering doesn't consider the **entity_template** setting (https://github.com/honeybee/honeybee-agavi-cmf-vendor/commit/e7e0ed9f0f2f8640d6116dd367debd78852e691f) that specifies the template to use, falling back to the default template of the *EntityRenderer*.\r\n\r\n*EmbedSuccessView* should consider eventual settings propagated from the parent attribute of the rendered embed."}}
{"actor":{"display_login":"Pictor13"}}