{"action":"created","issue":{"url":"https://api.github.com/repos/LorandBiro/OctoPack.Precompile/issues/1","repository_url":"https://api.github.com/repos/LorandBiro/OctoPack.Precompile","labels_url":"https://api.github.com/repos/LorandBiro/OctoPack.Precompile/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/LorandBiro/OctoPack.Precompile/issues/1/comments","events_url":"https://api.github.com/repos/LorandBiro/OctoPack.Precompile/issues/1/events","html_url":"https://github.com/LorandBiro/OctoPack.Precompile/pull/1","id":166094055,"number":1,"title":"Added TypeScriptCompile to CollectedFiles.","user":{"login":"dlemstra","id":10426229,"avatar_url":"https://avatars.githubusercontent.com/u/10426229?v=3","gravatar_id":"","url":"https://api.github.com/users/dlemstra","html_url":"https://github.com/dlemstra","followers_url":"https://api.github.com/users/dlemstra/followers","following_url":"https://api.github.com/users/dlemstra/following{/other_user}","gists_url":"https://api.github.com/users/dlemstra/gists{/gist_id}","starred_url":"https://api.github.com/users/dlemstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlemstra/subscriptions","organizations_url":"https://api.github.com/users/dlemstra/orgs","repos_url":"https://api.github.com/users/dlemstra/repos","events_url":"https://api.github.com/users/dlemstra/events{/privacy}","received_events_url":"https://api.github.com/users/dlemstra/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-07-18T13:31:39Z","updated_at":"2016-07-18T22:04:13Z","closed_at":"2016-07-18T21:17:37Z","pull_request":{"url":"https://api.github.com/repos/LorandBiro/OctoPack.Precompile/pulls/1","html_url":"https://github.com/LorandBiro/OctoPack.Precompile/pull/1","diff_url":"https://github.com/LorandBiro/OctoPack.Precompile/pull/1.diff","patch_url":"https://github.com/LorandBiro/OctoPack.Precompile/pull/1.patch"},"body":"Your comment states that CollectedFiles should collect the files the same way as OctoPack but you did not include `@(TypeScriptCompile)` (https://github.com/OctopusDeploy/OctoPack/blob/abd0c5d30cfd0572ff066b83436969661b9cdbd4/source/tools/OctoPack.targets#L73) and this patch adds that. You might want to change your comment if you did not include this on purpose."},"comment":{"url":"https://api.github.com/repos/LorandBiro/OctoPack.Precompile/issues/comments/233473159","html_url":"https://github.com/LorandBiro/OctoPack.Precompile/pull/1#issuecomment-233473159","issue_url":"https://api.github.com/repos/LorandBiro/OctoPack.Precompile/issues/1","id":233473159,"user":{"login":"LorandBiro","id":7293272,"avatar_url":"https://avatars.githubusercontent.com/u/7293272?v=3","gravatar_id":"","url":"https://api.github.com/users/LorandBiro","html_url":"https://github.com/LorandBiro","followers_url":"https://api.github.com/users/LorandBiro/followers","following_url":"https://api.github.com/users/LorandBiro/following{/other_user}","gists_url":"https://api.github.com/users/LorandBiro/gists{/gist_id}","starred_url":"https://api.github.com/users/LorandBiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LorandBiro/subscriptions","organizations_url":"https://api.github.com/users/LorandBiro/orgs","repos_url":"https://api.github.com/users/LorandBiro/repos","events_url":"https://api.github.com/users/LorandBiro/events{/privacy}","received_events_url":"https://api.github.com/users/LorandBiro/received_events","type":"User","site_admin":false},"created_at":"2016-07-18T22:04:13Z","updated_at":"2016-07-18T22:04:13Z","body":"I was a little confused for a while. I was guessing that @(TypeScriptCompile) contains the output of the TypeScript compiler (which would be a real problem to ignore), but it contains the TypeScript source files. I noticed that the Octopack target contains a flag (OctoPackIncludeTypeScriptSourceFiles) to instruct Octopack whether to include the TypeScript source files or not. It's false by default.\r\n\r\nI'm not sure what is exactly the use case. When would someone want to deploy their TypeScript source files?\r\n\r\nAnyway, the goal is really to follow the original behavior, so I added the condition. See de52049cda0efd2e8170f6953bbd15bc6d458d57."}}
{"actor":{"display_login":"LorandBiro"}}