{"action":"created","issue":{"url":"https://api.github.com/repos/FAForever/fa/issues/1351","repository_url":"https://api.github.com/repos/FAForever/fa","labels_url":"https://api.github.com/repos/FAForever/fa/issues/1351/labels{/name}","comments_url":"https://api.github.com/repos/FAForever/fa/issues/1351/comments","events_url":"https://api.github.com/repos/FAForever/fa/issues/1351/events","html_url":"https://github.com/FAForever/fa/pull/1351","id":159052445,"number":1351,"title":"Turn off deflate compression","user":{"login":"Crotalus","id":254972,"avatar_url":"https://avatars.githubusercontent.com/u/254972?v=3","gravatar_id":"","url":"https://api.github.com/users/Crotalus","html_url":"https://github.com/Crotalus","followers_url":"https://api.github.com/users/Crotalus/followers","following_url":"https://api.github.com/users/Crotalus/following{/other_user}","gists_url":"https://api.github.com/users/Crotalus/gists{/gist_id}","starred_url":"https://api.github.com/users/Crotalus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crotalus/subscriptions","organizations_url":"https://api.github.com/users/Crotalus/orgs","repos_url":"https://api.github.com/users/Crotalus/repos","events_url":"https://api.github.com/users/Crotalus/events{/privacy}","received_events_url":"https://api.github.com/users/Crotalus/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/FAForever/fa/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/FAForever/fa/milestones/11","html_url":"https://github.com/FAForever/fa/milestones/3656","labels_url":"https://api.github.com/repos/FAForever/fa/milestones/11/labels","id":1193550,"number":11,"title":"3656","description":"","creator":{"login":"Sheeo","id":37968,"avatar_url":"https://avatars.githubusercontent.com/u/37968?v=3","gravatar_id":"","url":"https://api.github.com/users/Sheeo","html_url":"https://github.com/Sheeo","followers_url":"https://api.github.com/users/Sheeo/followers","following_url":"https://api.github.com/users/Sheeo/following{/other_user}","gists_url":"https://api.github.com/users/Sheeo/gists{/gist_id}","starred_url":"https://api.github.com/users/Sheeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sheeo/subscriptions","organizations_url":"https://api.github.com/users/Sheeo/orgs","repos_url":"https://api.github.com/users/Sheeo/repos","events_url":"https://api.github.com/users/Sheeo/events{/privacy}","received_events_url":"https://api.github.com/users/Sheeo/received_events","type":"User","site_admin":false},"open_issues":32,"closed_issues":19,"state":"open","created_at":"2015-07-05T10:46:17Z","updated_at":"2016-06-08T00:24:24Z","due_on":"2016-06-12T22:00:00Z","closed_at":null},"comments":14,"created_at":"2016-06-08T00:11:07Z","updated_at":"2016-06-09T16:13:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/FAForever/fa/pulls/1351","html_url":"https://github.com/FAForever/fa/pull/1351","diff_url":"https://github.com/FAForever/fa/pull/1351.diff","patch_url":"https://github.com/FAForever/fa/pull/1351.patch"},"body":"Some players crash due to deflate compression algorithm trying to unpack corrupt packets.\r\n\r\nSome reports:\r\nhttp://forums.faforever.com/viewtopic.php?f=3&t=12552\r\nhttps://forums.faforever.com/viewtopic.php?f=3&t=9811\r\nhttps://forums.faforever.com/viewtopic.php?f=3&t=10542\r\n\r\nIf we need compression we can do that in the FAF client instead, multicore ftw ;) (although I guess FA probably runs this in own thread)"},"comment":{"url":"https://api.github.com/repos/FAForever/fa/issues/comments/224945652","html_url":"https://github.com/FAForever/fa/pull/1351#issuecomment-224945652","issue_url":"https://api.github.com/repos/FAForever/fa/issues/1351","id":224945652,"user":{"login":"ChrisKitching","id":3526849,"avatar_url":"https://avatars.githubusercontent.com/u/3526849?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisKitching","html_url":"https://github.com/ChrisKitching","followers_url":"https://api.github.com/users/ChrisKitching/followers","following_url":"https://api.github.com/users/ChrisKitching/following{/other_user}","gists_url":"https://api.github.com/users/ChrisKitching/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisKitching/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisKitching/subscriptions","organizations_url":"https://api.github.com/users/ChrisKitching/orgs","repos_url":"https://api.github.com/users/ChrisKitching/repos","events_url":"https://api.github.com/users/ChrisKitching/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisKitching/received_events","type":"User","site_admin":false},"created_at":"2016-06-09T16:13:46Z","updated_at":"2016-06-09T16:13:46Z","body":"> The UDP handler won't see that the packet is corrupt, the checksum validates the corrupt payload. Not something that happens often but still possible.\r\n\r\nRight, you can corrupt the payload and the checksum in complementary ways so the checksum is still \"correct\", but now you're screwed either way, aren't you? Now you have a corrupt message. It doesn't matter if it's compressed or not, it's still going to break everything. Why would disabling compression change that?"}}
{"actor":{"display_login":"ChrisKitching"}}