{"action":"created","comment":{"url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/pulls/comments/90000054","pull_request_review_id":10525033,"id":90000054,"diff_hunk":"@@ -26,7 +26,7 @@ Feature:\n     When I give my consent\n      And I pass through EngineBlock\n     Then the url should match \"functional-testing/SP-with-Attribute-Manipulations/acs\"\n-     And the response should match xpath '/samlp:Response/saml:Assertion/saml:AttributeStatement/saml:Attribute[@Name=\"nl:surf:test:something\"]/saml:AttributeValue[\"arbitrary-value\"]'\n+     And the response should match xpath '/samlp:Response/saml:Assertion/saml:AttributeStatement/saml:Attribute[@Name=\"nl:surf:test:something\"]/saml:AttributeValue[text()=\"arbitrary-value\"]'","path":"src/OpenConext/EngineBlockFunctionalTestingBundle/Features/AttributeManipulation.feature","position":5,"original_position":5,"commit_id":"375f0eef5ec36240f8e645a40120bff0ff00e958","original_commit_id":"204f10a67ba40a30896c63e632e9cc3e469817f1","user":{"login":"arothuis","id":3816591,"avatar_url":"https://avatars.githubusercontent.com/u/3816591?v=3","gravatar_id":"","url":"https://api.github.com/users/arothuis","html_url":"https://github.com/arothuis","followers_url":"https://api.github.com/users/arothuis/followers","following_url":"https://api.github.com/users/arothuis/following{/other_user}","gists_url":"https://api.github.com/users/arothuis/gists{/gist_id}","starred_url":"https://api.github.com/users/arothuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arothuis/subscriptions","organizations_url":"https://api.github.com/users/arothuis/orgs","repos_url":"https://api.github.com/users/arothuis/repos","events_url":"https://api.github.com/users/arothuis/events{/privacy}","received_events_url":"https://api.github.com/users/arothuis/received_events","type":"User","site_admin":false},"body":"Before the change it disregarded the `[\"arbitrary-value\"]`, afterwards it enforces it.\r\n","created_at":"2016-11-29T12:36:19Z","updated_at":"2016-11-29T12:36:19Z","html_url":"https://github.com/OpenConext/OpenConext-engineblock/pull/360#discussion_r90000054","pull_request_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/pulls/360","_links":{"self":{"href":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/pulls/comments/90000054"},"html":{"href":"https://github.com/OpenConext/OpenConext-engineblock/pull/360#discussion_r90000054"},"pull_request":{"href":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/pulls/360"}}},"pull_request":{"url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/pulls/360","id":95519345,"html_url":"https://github.com/OpenConext/OpenConext-engineblock/pull/360","diff_url":"https://github.com/OpenConext/OpenConext-engineblock/pull/360.diff","patch_url":"https://github.com/OpenConext/OpenConext-engineblock/pull/360.patch","issue_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/issues/360","number":360,"state":"open","locked":false,"title":"Replace @-sign in collab person ids for compatibility","user":{"login":"arothuis","id":3816591,"avatar_url":"https://avatars.githubusercontent.com/u/3816591?v=3","gravatar_id":"","url":"https://api.github.com/users/arothuis","html_url":"https://github.com/arothuis","followers_url":"https://api.github.com/users/arothuis/followers","following_url":"https://api.github.com/users/arothuis/following{/other_user}","gists_url":"https://api.github.com/users/arothuis/gists{/gist_id}","starred_url":"https://api.github.com/users/arothuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arothuis/subscriptions","organizations_url":"https://api.github.com/users/arothuis/orgs","repos_url":"https://api.github.com/users/arothuis/repos","events_url":"https://api.github.com/users/arothuis/events{/privacy}","received_events_url":"https://api.github.com/users/arothuis/received_events","type":"User","site_admin":false},"body":"[134915765](https://www.pivotaltracker.com/story/show/134915765)\r\n\r\nIn the past, at-signs were replaced by underscores because LDAP had trouble dealing with them. Recently, the way collabPersonIds are generated has changed, breaking compatibility with earlier versions of EB across the platform. In order to reinstate this, a method has been added to reinstate compatibility with all the collabPersonIds present in the platform already.\r\n\r\nI have deliberately chosen to create another method for this to be explicit about the quirky implementation of collabPersonIds.\r\n\r\nIn the future, a way of migrating from old to new collabPersonIds should be devised. Then, we can use the original `CollabPersonId::generateFrom()` method.","created_at":"2016-11-28T15:28:51Z","updated_at":"2016-11-29T12:36:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eeee5ce42114973985d8e4e87b0dde35e7dad331","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/pulls/360/commits","review_comments_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/pulls/360/comments","review_comment_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/issues/360/comments","statuses_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/statuses/375f0eef5ec36240f8e645a40120bff0ff00e958","head":{"label":"OpenConext:bugfix/replace-at-sign-in-collab-person-ids-for-compatibility","ref":"bugfix/replace-at-sign-in-collab-person-ids-for-compatibility","sha":"375f0eef5ec36240f8e645a40120bff0ff00e958","user":{"login":"OpenConext","id":1457650,"avatar_url":"https://avatars.githubusercontent.com/u/1457650?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenConext","html_url":"https://github.com/OpenConext","followers_url":"https://api.github.com/users/OpenConext/followers","following_url":"https://api.github.com/users/OpenConext/following{/other_user}","gists_url":"https://api.github.com/users/OpenConext/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenConext/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenConext/subscriptions","organizations_url":"https://api.github.com/users/OpenConext/orgs","repos_url":"https://api.github.com/users/OpenConext/repos","events_url":"https://api.github.com/users/OpenConext/events{/privacy}","received_events_url":"https://api.github.com/users/OpenConext/received_events","type":"Organization","site_admin":false},"repo":{"id":3900071,"name":"OpenConext-engineblock","full_name":"OpenConext/OpenConext-engineblock","owner":{"login":"OpenConext","id":1457650,"avatar_url":"https://avatars.githubusercontent.com/u/1457650?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenConext","html_url":"https://github.com/OpenConext","followers_url":"https://api.github.com/users/OpenConext/followers","following_url":"https://api.github.com/users/OpenConext/following{/other_user}","gists_url":"https://api.github.com/users/OpenConext/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenConext/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenConext/subscriptions","organizations_url":"https://api.github.com/users/OpenConext/orgs","repos_url":"https://api.github.com/users/OpenConext/repos","events_url":"https://api.github.com/users/OpenConext/events{/privacy}","received_events_url":"https://api.github.com/users/OpenConext/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenConext/OpenConext-engineblock","description":"OpenConext SAML 2.0 IdP/SP Gateway","fork":false,"url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock","forks_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/forks","keys_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/teams","hooks_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/hooks","issue_events_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/issues/events{/number}","events_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/events","assignees_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/assignees{/user}","branches_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/branches{/branch}","tags_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/tags","blobs_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/languages","stargazers_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/stargazers","contributors_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/contributors","subscribers_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/subscribers","subscription_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/subscription","commits_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/contents/{+path}","compare_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/merges","archive_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/downloads","issues_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/issues{/number}","pulls_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/labels{/name}","releases_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/releases{/id}","deployments_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/deployments","created_at":"2012-04-02T11:49:31Z","updated_at":"2016-10-31T15:55:36Z","pushed_at":"2016-11-29T09:00:17Z","git_url":"git://github.com/OpenConext/OpenConext-engineblock.git","ssh_url":"git@github.com:OpenConext/OpenConext-engineblock.git","clone_url":"https://github.com/OpenConext/OpenConext-engineblock.git","svn_url":"https://github.com/OpenConext/OpenConext-engineblock","homepage":"","size":20703,"stargazers_count":6,"watchers_count":6,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":54,"forks":15,"open_issues":54,"watchers":6,"default_branch":"master"}},"base":{"label":"OpenConext:master","ref":"master","sha":"e71ffd6db4fd3e971fea4c8362585e52e81edb68","user":{"login":"OpenConext","id":1457650,"avatar_url":"https://avatars.githubusercontent.com/u/1457650?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenConext","html_url":"https://github.com/OpenConext","followers_url":"https://api.github.com/users/OpenConext/followers","following_url":"https://api.github.com/users/OpenConext/following{/other_user}","gists_url":"https://api.github.com/users/OpenConext/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenConext/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenConext/subscriptions","organizations_url":"https://api.github.com/users/OpenConext/orgs","repos_url":"https://api.github.com/users/OpenConext/repos","events_url":"https://api.github.com/users/OpenConext/events{/privacy}","received_events_url":"https://api.github.com/users/OpenConext/received_events","type":"Organization","site_admin":false},"repo":{"id":3900071,"name":"OpenConext-engineblock","full_name":"OpenConext/OpenConext-engineblock","owner":{"login":"OpenConext","id":1457650,"avatar_url":"https://avatars.githubusercontent.com/u/1457650?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenConext","html_url":"https://github.com/OpenConext","followers_url":"https://api.github.com/users/OpenConext/followers","following_url":"https://api.github.com/users/OpenConext/following{/other_user}","gists_url":"https://api.github.com/users/OpenConext/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenConext/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenConext/subscriptions","organizations_url":"https://api.github.com/users/OpenConext/orgs","repos_url":"https://api.github.com/users/OpenConext/repos","events_url":"https://api.github.com/users/OpenConext/events{/privacy}","received_events_url":"https://api.github.com/users/OpenConext/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenConext/OpenConext-engineblock","description":"OpenConext SAML 2.0 IdP/SP Gateway","fork":false,"url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock","forks_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/forks","keys_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/teams","hooks_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/hooks","issue_events_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/issues/events{/number}","events_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/events","assignees_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/assignees{/user}","branches_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/branches{/branch}","tags_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/tags","blobs_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/languages","stargazers_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/stargazers","contributors_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/contributors","subscribers_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/subscribers","subscription_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/subscription","commits_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/contents/{+path}","compare_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/merges","archive_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/downloads","issues_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/issues{/number}","pulls_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/labels{/name}","releases_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/releases{/id}","deployments_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/deployments","created_at":"2012-04-02T11:49:31Z","updated_at":"2016-10-31T15:55:36Z","pushed_at":"2016-11-29T09:00:17Z","git_url":"git://github.com/OpenConext/OpenConext-engineblock.git","ssh_url":"git@github.com:OpenConext/OpenConext-engineblock.git","clone_url":"https://github.com/OpenConext/OpenConext-engineblock.git","svn_url":"https://github.com/OpenConext/OpenConext-engineblock","homepage":"","size":20703,"stargazers_count":6,"watchers_count":6,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":54,"forks":15,"open_issues":54,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/pulls/360"},"html":{"href":"https://github.com/OpenConext/OpenConext-engineblock/pull/360"},"issue":{"href":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/issues/360"},"comments":{"href":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/issues/360/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/pulls/360/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/pulls/360/commits"},"statuses":{"href":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/statuses/375f0eef5ec36240f8e645a40120bff0ff00e958"}}}}
{"actor":{"display_login":"arothuis"}}