{"action":"created","comment":{"url":"https://api.github.com/repos/Exygy/sf-dahlia-web/pulls/comments/77894251","id":77894251,"diff_hunk":"@@ -38,10 +40,71 @@\n \n   # ---- end Jasmine fixtures\n \n+  describe 'show_application' do\n+    before do\n+      Api::V1::ShortFormController.any_instance\n+                                  .stub(:user_can_access?).and_return(true)\n+      Api::V1::ShortFormController.any_instance\n+                                  .stub(:map_listing_to_application)\n+                                  .and_return(true)\n+    end\n+\n+    it 'returns an application object' do\n+      VCR.use_cassette('shortform/show_application') do\n+        get '/api/v1/short-form/application/a0tf0000000xw9pAAA.json', {}, @auth_headers\n+      end\n+      json = JSON.parse(response.body)\n+      expect(response).to be_success\n+      expect(json).not_to be_nil\n+    end\n+  end\n+\n+  describe 'show_listing_application_for_user' do\n+    before do\n+      Api::V1::ShortFormController.any_instance\n+                                  .stub(:find_listing_application).and_return(true)\n+      Api::V1::ShortFormController.any_instance\n+                                  .stub(:find_application_files)\n+                                  .and_return(true)\n+    end\n+\n+    it 'returns successful response' do\n+      url = '/api/v1/short-form/listing-application/a0Wf0000003j03WEAQ.json'\n+      VCR.use_cassette('shortform/show_application') do\n+        get url, {}, @auth_headers\n+      end\n+      expect(response).to be_success\n+    end\n+  end\n+\n+  # describe 'submit_application' do\n+  # RSPEC IS CONVERTING THE BOOLEAN TO STRINGS, SALESFORCE REJECTING PARAMS","path":"spec/requests/api/v1/short_form_spec.rb","position":68,"original_position":68,"commit_id":"8777867dfb22646b376d941c9826d375861051f9","original_commit_id":"8777867dfb22646b376d941c9826d375861051f9","user":{"login":"kaptron","id":318100,"avatar_url":"https://avatars.githubusercontent.com/u/318100?v=3","gravatar_id":"","url":"https://api.github.com/users/kaptron","html_url":"https://github.com/kaptron","followers_url":"https://api.github.com/users/kaptron/followers","following_url":"https://api.github.com/users/kaptron/following{/other_user}","gists_url":"https://api.github.com/users/kaptron/gists{/gist_id}","starred_url":"https://api.github.com/users/kaptron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaptron/subscriptions","organizations_url":"https://api.github.com/users/kaptron/orgs","repos_url":"https://api.github.com/users/kaptron/repos","events_url":"https://api.github.com/users/kaptron/events{/privacy}","received_events_url":"https://api.github.com/users/kaptron/received_events","type":"User","site_admin":false},"body":"hm it does make sense that the params are converted to strings, anything you post via a request will be strings. I can take a look at it and see what you mean.","created_at":"2016-09-07T20:09:51Z","updated_at":"2016-09-07T20:09:51Z","html_url":"https://github.com/Exygy/sf-dahlia-web/pull/377#discussion_r77894251","pull_request_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/pulls/377","_links":{"self":{"href":"https://api.github.com/repos/Exygy/sf-dahlia-web/pulls/comments/77894251"},"html":{"href":"https://github.com/Exygy/sf-dahlia-web/pull/377#discussion_r77894251"},"pull_request":{"href":"https://api.github.com/repos/Exygy/sf-dahlia-web/pulls/377"}}},"pull_request":{"url":"https://api.github.com/repos/Exygy/sf-dahlia-web/pulls/377","id":84362125,"html_url":"https://github.com/Exygy/sf-dahlia-web/pull/377","diff_url":"https://github.com/Exygy/sf-dahlia-web/pull/377.diff","patch_url":"https://github.com/Exygy/sf-dahlia-web/pull/377.patch","issue_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/issues/377","number":377,"state":"open","locked":false,"title":"Chores/update missing short form tests #126468679","user":{"login":"chrisdolendo","id":5904673,"avatar_url":"https://avatars.githubusercontent.com/u/5904673?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisdolendo","html_url":"https://github.com/chrisdolendo","followers_url":"https://api.github.com/users/chrisdolendo/followers","following_url":"https://api.github.com/users/chrisdolendo/following{/other_user}","gists_url":"https://api.github.com/users/chrisdolendo/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisdolendo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisdolendo/subscriptions","organizations_url":"https://api.github.com/users/chrisdolendo/orgs","repos_url":"https://api.github.com/users/chrisdolendo/repos","events_url":"https://api.github.com/users/chrisdolendo/events{/privacy}","received_events_url":"https://api.github.com/users/chrisdolendo/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-07T19:51:45Z","updated_at":"2016-09-07T20:09:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf21e67062a2171062a1deb8b417582edd7900a0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/pulls/377/commits","review_comments_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/pulls/377/comments","review_comment_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/issues/377/comments","statuses_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/statuses/8777867dfb22646b376d941c9826d375861051f9","head":{"label":"Exygy:chores/update-missing-short-form-tests-#126468679","ref":"chores/update-missing-short-form-tests-#126468679","sha":"8777867dfb22646b376d941c9826d375861051f9","user":{"login":"Exygy","id":689564,"avatar_url":"https://avatars.githubusercontent.com/u/689564?v=3","gravatar_id":"","url":"https://api.github.com/users/Exygy","html_url":"https://github.com/Exygy","followers_url":"https://api.github.com/users/Exygy/followers","following_url":"https://api.github.com/users/Exygy/following{/other_user}","gists_url":"https://api.github.com/users/Exygy/gists{/gist_id}","starred_url":"https://api.github.com/users/Exygy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Exygy/subscriptions","organizations_url":"https://api.github.com/users/Exygy/orgs","repos_url":"https://api.github.com/users/Exygy/repos","events_url":"https://api.github.com/users/Exygy/events{/privacy}","received_events_url":"https://api.github.com/users/Exygy/received_events","type":"Organization","site_admin":false},"repo":{"id":43323246,"name":"sf-dahlia-web","full_name":"Exygy/sf-dahlia-web","owner":{"login":"Exygy","id":689564,"avatar_url":"https://avatars.githubusercontent.com/u/689564?v=3","gravatar_id":"","url":"https://api.github.com/users/Exygy","html_url":"https://github.com/Exygy","followers_url":"https://api.github.com/users/Exygy/followers","following_url":"https://api.github.com/users/Exygy/following{/other_user}","gists_url":"https://api.github.com/users/Exygy/gists{/gist_id}","starred_url":"https://api.github.com/users/Exygy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Exygy/subscriptions","organizations_url":"https://api.github.com/users/Exygy/orgs","repos_url":"https://api.github.com/users/Exygy/repos","events_url":"https://api.github.com/users/Exygy/events{/privacy}","received_events_url":"https://api.github.com/users/Exygy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Exygy/sf-dahlia-web","description":"","fork":false,"url":"https://api.github.com/repos/Exygy/sf-dahlia-web","forks_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/forks","keys_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/teams","hooks_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/hooks","issue_events_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/issues/events{/number}","events_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/events","assignees_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/assignees{/user}","branches_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/branches{/branch}","tags_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/tags","blobs_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/statuses/{sha}","languages_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/languages","stargazers_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/stargazers","contributors_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/contributors","subscribers_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/subscribers","subscription_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/subscription","commits_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/contents/{+path}","compare_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/merges","archive_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/downloads","issues_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/issues{/number}","pulls_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/pulls{/number}","milestones_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/milestones{/number}","notifications_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/labels{/name}","releases_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/releases{/id}","deployments_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/deployments","created_at":"2015-09-28T19:48:45Z","updated_at":"2016-07-29T18:00:31Z","pushed_at":"2016-09-07T20:01:50Z","git_url":"git://github.com/Exygy/sf-dahlia-web.git","ssh_url":"git@github.com:Exygy/sf-dahlia-web.git","clone_url":"https://github.com/Exygy/sf-dahlia-web.git","svn_url":"https://github.com/Exygy/sf-dahlia-web","homepage":null,"size":24155,"stargazers_count":3,"watchers_count":3,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":5,"forks":10,"open_issues":5,"watchers":3,"default_branch":"master"}},"base":{"label":"Exygy:master","ref":"master","sha":"b278fa29d3fd81db42545cd554ed196d318d60a4","user":{"login":"Exygy","id":689564,"avatar_url":"https://avatars.githubusercontent.com/u/689564?v=3","gravatar_id":"","url":"https://api.github.com/users/Exygy","html_url":"https://github.com/Exygy","followers_url":"https://api.github.com/users/Exygy/followers","following_url":"https://api.github.com/users/Exygy/following{/other_user}","gists_url":"https://api.github.com/users/Exygy/gists{/gist_id}","starred_url":"https://api.github.com/users/Exygy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Exygy/subscriptions","organizations_url":"https://api.github.com/users/Exygy/orgs","repos_url":"https://api.github.com/users/Exygy/repos","events_url":"https://api.github.com/users/Exygy/events{/privacy}","received_events_url":"https://api.github.com/users/Exygy/received_events","type":"Organization","site_admin":false},"repo":{"id":43323246,"name":"sf-dahlia-web","full_name":"Exygy/sf-dahlia-web","owner":{"login":"Exygy","id":689564,"avatar_url":"https://avatars.githubusercontent.com/u/689564?v=3","gravatar_id":"","url":"https://api.github.com/users/Exygy","html_url":"https://github.com/Exygy","followers_url":"https://api.github.com/users/Exygy/followers","following_url":"https://api.github.com/users/Exygy/following{/other_user}","gists_url":"https://api.github.com/users/Exygy/gists{/gist_id}","starred_url":"https://api.github.com/users/Exygy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Exygy/subscriptions","organizations_url":"https://api.github.com/users/Exygy/orgs","repos_url":"https://api.github.com/users/Exygy/repos","events_url":"https://api.github.com/users/Exygy/events{/privacy}","received_events_url":"https://api.github.com/users/Exygy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Exygy/sf-dahlia-web","description":"","fork":false,"url":"https://api.github.com/repos/Exygy/sf-dahlia-web","forks_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/forks","keys_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/teams","hooks_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/hooks","issue_events_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/issues/events{/number}","events_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/events","assignees_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/assignees{/user}","branches_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/branches{/branch}","tags_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/tags","blobs_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/statuses/{sha}","languages_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/languages","stargazers_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/stargazers","contributors_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/contributors","subscribers_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/subscribers","subscription_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/subscription","commits_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/contents/{+path}","compare_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/merges","archive_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/downloads","issues_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/issues{/number}","pulls_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/pulls{/number}","milestones_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/milestones{/number}","notifications_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/labels{/name}","releases_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/releases{/id}","deployments_url":"https://api.github.com/repos/Exygy/sf-dahlia-web/deployments","created_at":"2015-09-28T19:48:45Z","updated_at":"2016-07-29T18:00:31Z","pushed_at":"2016-09-07T20:01:50Z","git_url":"git://github.com/Exygy/sf-dahlia-web.git","ssh_url":"git@github.com:Exygy/sf-dahlia-web.git","clone_url":"https://github.com/Exygy/sf-dahlia-web.git","svn_url":"https://github.com/Exygy/sf-dahlia-web","homepage":null,"size":24155,"stargazers_count":3,"watchers_count":3,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":5,"forks":10,"open_issues":5,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Exygy/sf-dahlia-web/pulls/377"},"html":{"href":"https://github.com/Exygy/sf-dahlia-web/pull/377"},"issue":{"href":"https://api.github.com/repos/Exygy/sf-dahlia-web/issues/377"},"comments":{"href":"https://api.github.com/repos/Exygy/sf-dahlia-web/issues/377/comments"},"review_comments":{"href":"https://api.github.com/repos/Exygy/sf-dahlia-web/pulls/377/comments"},"review_comment":{"href":"https://api.github.com/repos/Exygy/sf-dahlia-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Exygy/sf-dahlia-web/pulls/377/commits"},"statuses":{"href":"https://api.github.com/repos/Exygy/sf-dahlia-web/statuses/8777867dfb22646b376d941c9826d375861051f9"}}}}
{"actor":{"display_login":"kaptron"}}