{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments/72579604","id":72579604,"diff_hunk":"@@ -112,6 +112,18 @@\n end\n memcached_servers.sort!\n \n+\n+serialproxies = search_env_filtered(:node, \"roles:nova-controller\")\n+if serialproxies.length > 0","path":"chef/cookbooks/nova/recipes/config.rb","position":6,"original_position":6,"commit_id":"261573903e03f3c51c4bef53bc6ed41a630c6ef7","original_commit_id":"261573903e03f3c51c4bef53bc6ed41a630c6ef7","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Style/ZeroLengthPredicate: Use `!empty?` instead of `length > 0`.","created_at":"2016-07-28T08:03:09Z","updated_at":"2016-07-28T08:03:09Z","html_url":"https://github.com/crowbar/crowbar-openstack/pull/471#discussion_r72579604","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/471","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments/72579604"},"html":{"href":"https://github.com/crowbar/crowbar-openstack/pull/471#discussion_r72579604"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/471"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/471","id":79152623,"html_url":"https://github.com/crowbar/crowbar-openstack/pull/471","diff_url":"https://github.com/crowbar/crowbar-openstack/pull/471.diff","patch_url":"https://github.com/crowbar/crowbar-openstack/pull/471.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/471","number":471,"state":"open","locked":false,"title":"Enable serial console access","user":{"login":"dirkmueller","id":1029152,"avatar_url":"https://avatars.githubusercontent.com/u/1029152?v=3","gravatar_id":"","url":"https://api.github.com/users/dirkmueller","html_url":"https://github.com/dirkmueller","followers_url":"https://api.github.com/users/dirkmueller/followers","following_url":"https://api.github.com/users/dirkmueller/following{/other_user}","gists_url":"https://api.github.com/users/dirkmueller/gists{/gist_id}","starred_url":"https://api.github.com/users/dirkmueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirkmueller/subscriptions","organizations_url":"https://api.github.com/users/dirkmueller/orgs","repos_url":"https://api.github.com/users/dirkmueller/repos","events_url":"https://api.github.com/users/dirkmueller/events{/privacy}","received_events_url":"https://api.github.com/users/dirkmueller/received_events","type":"User","site_admin":false},"body":"On non-x86 there is currently no support for VNC, so we need to enable\r\nserial","created_at":"2016-07-28T08:03:03Z","updated_at":"2016-07-28T08:03:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0babd0eb6c6e887d0d657d3bf41c6abb8567eeac","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/471/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/471/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/471/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/261573903e03f3c51c4bef53bc6ed41a630c6ef7","head":{"label":"dirkmueller:aarch64","ref":"aarch64","sha":"261573903e03f3c51c4bef53bc6ed41a630c6ef7","user":{"login":"dirkmueller","id":1029152,"avatar_url":"https://avatars.githubusercontent.com/u/1029152?v=3","gravatar_id":"","url":"https://api.github.com/users/dirkmueller","html_url":"https://github.com/dirkmueller","followers_url":"https://api.github.com/users/dirkmueller/followers","following_url":"https://api.github.com/users/dirkmueller/following{/other_user}","gists_url":"https://api.github.com/users/dirkmueller/gists{/gist_id}","starred_url":"https://api.github.com/users/dirkmueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirkmueller/subscriptions","organizations_url":"https://api.github.com/users/dirkmueller/orgs","repos_url":"https://api.github.com/users/dirkmueller/repos","events_url":"https://api.github.com/users/dirkmueller/events{/privacy}","received_events_url":"https://api.github.com/users/dirkmueller/received_events","type":"User","site_admin":false},"repo":{"id":41291687,"name":"crowbar-openstack","full_name":"dirkmueller/crowbar-openstack","owner":{"login":"dirkmueller","id":1029152,"avatar_url":"https://avatars.githubusercontent.com/u/1029152?v=3","gravatar_id":"","url":"https://api.github.com/users/dirkmueller","html_url":"https://github.com/dirkmueller","followers_url":"https://api.github.com/users/dirkmueller/followers","following_url":"https://api.github.com/users/dirkmueller/following{/other_user}","gists_url":"https://api.github.com/users/dirkmueller/gists{/gist_id}","starred_url":"https://api.github.com/users/dirkmueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirkmueller/subscriptions","organizations_url":"https://api.github.com/users/dirkmueller/orgs","repos_url":"https://api.github.com/users/dirkmueller/repos","events_url":"https://api.github.com/users/dirkmueller/events{/privacy}","received_events_url":"https://api.github.com/users/dirkmueller/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dirkmueller/crowbar-openstack","description":"Openstack deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/dirkmueller/crowbar-openstack","forks_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/forks","keys_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/teams","hooks_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/hooks","issue_events_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/events","assignees_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/tags","blobs_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/languages","stargazers_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/stargazers","contributors_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/contributors","subscribers_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/subscribers","subscription_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/subscription","commits_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/merges","archive_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/downloads","issues_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/labels{/name}","releases_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/deployments","created_at":"2015-08-24T08:33:53Z","updated_at":"2016-01-29T14:23:45Z","pushed_at":"2016-07-28T08:02:25Z","git_url":"git://github.com/dirkmueller/crowbar-openstack.git","ssh_url":"git@github.com:dirkmueller/crowbar-openstack.git","clone_url":"https://github.com/dirkmueller/crowbar-openstack.git","svn_url":"https://github.com/dirkmueller/crowbar-openstack","homepage":null,"size":16807,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"adf8b1a7c2511f9ed8b5e9cb5974b25f8ef0f452","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39006903,"name":"crowbar-openstack","full_name":"crowbar/crowbar-openstack","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-openstack","description":"Openstack deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-openstack","forks_url":"https://api.github.com/repos/crowbar/crowbar-openstack/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-openstack/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-openstack/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-openstack/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-openstack/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-openstack/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-openstack/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-openstack/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-openstack/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-openstack/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-openstack/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-openstack/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-openstack/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/deployments","created_at":"2015-07-13T10:55:33Z","updated_at":"2016-01-11T12:29:07Z","pushed_at":"2016-07-28T08:03:06Z","git_url":"git://github.com/crowbar/crowbar-openstack.git","ssh_url":"git@github.com:crowbar/crowbar-openstack.git","clone_url":"https://github.com/crowbar/crowbar-openstack.git","svn_url":"https://github.com/crowbar/crowbar-openstack","homepage":null,"size":17546,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":36,"forks":32,"open_issues":36,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/471"},"html":{"href":"https://github.com/crowbar/crowbar-openstack/pull/471"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/471"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/471/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/471/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/471/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/261573903e03f3c51c4bef53bc6ed41a630c6ef7"}}}}
{"actor":{"display_login":"houndci-bot"}}