{"push_id":1366113986,"size":37,"distinct_size":37,"ref":"refs/heads/MM-resources","head":"1df9e8ccda2a9d6a3fb792004a279b42fdf02167","before":"69e50c64d75a3eb21702a1a9a9c29188f74ecabb","commits":[{"sha":"92911263cae189653935975c46954ad51ed73188","author":{"name":"Casey Marshall","email":"c8754909bb626c7783c6ff2cfe173b8b81ba9672@canonical.com"},"message":"Use the mock clock in TestMeterStatusSuccesfulSend.\n\nThis fixes an \"intermittent\" test failure which could have been caused\nby the real-world clock time from setup to the affected test being > 1s.","distinct":true,"url":"https://api.github.com/repos/mjs/juju/commits/92911263cae189653935975c46954ad51ed73188"},{"sha":"82bbf52ba7a7108e4d4e2e04f40770fe5ab5924a","author":{"name":"Juju bot","email":"5ad2d950345774e38fdffd280b9d5ad799044aa9@users.noreply.github.com"},"message":"Merge pull request #6446 from cmars/fix-lp1626187\n\nUse the mock clock in TestMeterStatusSuccesfulSend.\n\nThis fixes an \"intermittent\" test failure which could have been caused\r\nby the real-world clock time from setup to the affected test being > 1s.","distinct":true,"url":"https://api.github.com/repos/mjs/juju/commits/82bbf52ba7a7108e4d4e2e04f40770fe5ab5924a"},{"sha":"3dc459638f733853e9981fac558f5245c431816c","author":{"name":"Menno Smits","email":"a33df8ec827d17b7ead5375d3839b3e099ba0581@canonical.com"},"message":"featuretests: API error handling in upgrade logins\n\nThe call to FullStatus was always expected to work but would\noccasionally fail if the apiserver worker was in the middle of being\nrestarted. Instead of failing immediately allow retries to continue.\n\nFixes https://bugs.launchpad.net/juju/+bug/1619744","distinct":true,"url":"https://api.github.com/repos/mjs/juju/commits/3dc459638f733853e9981fac558f5245c431816c"},{"sha":"6e02cec74b3e2d763fcde1537ef7768099bdebd0","author":{"name":"Juju bot","email":"5ad2d950345774e38fdffd280b9d5ad799044aa9@users.noreply.github.com"},"message":"Merge pull request #6450 from mjs/1619744-TestLoginsDuringUpgrade\n\nfeaturetests: API error handling in upgrade logins\n\nThe call to FullStatus was always expected to work but would\r\noccasionally fail if the apiserver worker was in the middle of being\r\nrestarted. Instead of failing immediately allow retries to continue.\r\n\r\nFixes https://bugs.launchpad.net/juju/+bug/1619744","distinct":true,"url":"https://api.github.com/repos/mjs/juju/commits/6e02cec74b3e2d763fcde1537ef7768099bdebd0"},{"sha":"f2fe2d0e4289e1fa26a00fc81d784ba0cdd9b0b4","author":{"name":"Roger Peppe","email":"1fc2218fc28b8262889f07d240ee50ae4754500f@gmail.com"},"message":"api: add SNIHostName to Info\n\nThis means that we can have an arbitrary API addresses\nin api.Info, including resolved IP addresses, but still connect\nusing the officially signed certificate to check. If there's\na private Juju CA cert available, we use that by preference\nto make it possible to connect even if the server cannot\nobtain an officially signed certificate.\n\nWe also add a DialWebsocket field to api.DialOpts\nso that we can use a fake dialer function in tests.","distinct":true,"url":"https://api.github.com/repos/mjs/juju/commits/f2fe2d0e4289e1fa26a00fc81d784ba0cdd9b0b4"},{"sha":"30d9f27af8e4234a297ba19ce8a430c1f27e6514","author":{"name":"Juju bot","email":"5ad2d950345774e38fdffd280b9d5ad799044aa9@users.noreply.github.com"},"message":"Merge pull request #6407 from rogpeppe/109-apiclient-snihostname\n\napi: add SNIHostName to Info\n\nThis means that we can have an arbitrary API addresses\r\nin api.Info, including resolved IP addresses, but still connect\r\nusing the officially signed certificate to check. If there's\r\na private Juju CA cert available, we use that by preference\r\nto make it possible to connect even if the server cannot\r\nobtain an officially signed certificate.","distinct":true,"url":"https://api.github.com/repos/mjs/juju/commits/30d9f27af8e4234a297ba19ce8a430c1f27e6514"},{"sha":"6a110cf2224eb63538fe0dda320e3769f662a2ee","author":{"name":"Katherine Cox-Buday","email":"6683470312e80d8d1d3ae4c7e9572199805ff0e5@gmail.com"},"message":"Corrects panics on MacOS Sierra\n\nAddresses lp:1633495.\n\nThe code was already in place, we just weren't utilizing the correct commits.","distinct":true,"url":"https://api.github.com/repos/mjs/juju/commits/6a110cf2224eb63538fe0dda320e3769f662a2ee"},{"sha":"c2a80a8345d7f7ade62dfa5893c7454a44bca11c","author":{"name":"Juju bot","email":"5ad2d950345774e38fdffd280b9d5ad799044aa9@users.noreply.github.com"},"message":"Merge pull request #6455 from kat-co/fixes-1633495-sierra-panic\n\nCorrects panics on MacOS Sierra\n\nAddresses lp:1633495.\r\n\r\nThe code was already in place, we just weren't utilizing the correct commits.","distinct":true,"url":"https://api.github.com/repos/mjs/juju/commits/c2a80a8345d7f7ade62dfa5893c7454a44bca11c"},{"sha":"43f0d8f4d310cca073fc9e518fe8b6ac0b7bdc74","author":{"name":"Menno Smits","email":"a33df8ec827d17b7ead5375d3839b3e099ba0581@canonical.com"},"message":"worker/logforwarder: Make tests reliable\n\nThe tests were using a convoluted mess of channels in an attempt to\nsynchronise the multiple goroutines being tested with the test\ncode. This was hard to understand and work with and is likely to be\ncaused the observed intermittent test failures.\n\nChanges:\n- use independent stubs for the stream and sender to make it easier to\n  assert calls and to have faked errors always be returned by the\n  correct instance.\n- use a single simpler \"activity\" channel in the stub sender to\n  synchronise test and code-under-test progress\n- make checks more reliable by only checking stubs once worker has shut\n  down.\n- removed unnecessary record sending goroutine in stub stream (just\n  stack a buffered channel instead.\n\nLikely fix for https://bugs.launchpad.net/juju/+bug/1606568","distinct":true,"url":"https://api.github.com/repos/mjs/juju/commits/43f0d8f4d310cca073fc9e518fe8b6ac0b7bdc74"},{"sha":"3c63cd80fb772744592c537e37f91e35b5758372","author":{"name":"Juju bot","email":"5ad2d950345774e38fdffd280b9d5ad799044aa9@users.noreply.github.com"},"message":"Merge pull request #6456 from mjs/1606568-TestStreamError\n\nworker/logforwarder: Make tests reliable\n\nThe tests were using a convoluted mess of channels in an attempt to synchronise the multiple goroutines being tested with the test code. This was hard to understand and work with and is likely to be\r\ncaused the observed intermittent test failures.\r\n\r\nChanges:\r\n- use independent stubs for the stream and sender to make it easier to assert calls and to have faked errors always be returned by the correct instance.\r\n- use a single simpler \"activity\" channel in the stub sender to synchronise test and code-under-test progress\r\n- make checks more reliable by only checking stubs once worker has shut down.\r\n- removed unnecessary record sending goroutine in stub stream (just stack a buffered channel instead.\r\n\r\nLikely fix for https://bugs.launchpad.net/juju/+bug/1606568\r\n\r\n### QA\r\n\r\nMany runs of the test suite with the race stress tester. This is a unit test only change so there's other QA to do.","distinct":true,"url":"https://api.github.com/repos/mjs/juju/commits/3c63cd80fb772744592c537e37f91e35b5758372"},{"sha":"24022099d1894b1ab8517fdd1acb15fa42bf26a2","author":{"name":"anastasia","email":"21ee4bc1f0d65bd13c426ffc979159e9487d655d@canonical.com"},"message":"Make obvious that --refresh is a flag on controllers command not juju itself.","distinct":true,"url":"https://api.github.com/repos/mjs/juju/commits/24022099d1894b1ab8517fdd1acb15fa42bf26a2"},{"sha":"bf7defbbe3f9c3f6f2b45c3884df8d02365f3c7a","author":{"name":"anastasia","email":"21ee4bc1f0d65bd13c426ffc979159e9487d655d@canonical.com"},"message":"Buh -  now actually make obvious that --refresh is a flag on controllers command not juju itself.","distinct":true,"url":"https://api.github.com/repos/mjs/juju/commits/bf7defbbe3f9c3f6f2b45c3884df8d02365f3c7a"},{"sha":"19caaa444d4ada9470d33d9f16a5d90faccc7bcf","author":{"name":"anastasia","email":"21ee4bc1f0d65bd13c426ffc979159e9487d655d@canonical.com"},"message":"Renamed \"service\" to \"application\".","distinct":true,"url":"https://api.github.com/repos/mjs/juju/commits/19caaa444d4ada9470d33d9f16a5d90faccc7bcf"},{"sha":"84d054f90b5cec856d8c1e8b81b1835dd4b2eb47","author":{"name":"anastasia","email":"21ee4bc1f0d65bd13c426ffc979159e9487d655d@canonical.com"},"message":"Move valid arguments before examples.","distinct":true,"url":"https://api.github.com/repos/mjs/juju/commits/84d054f90b5cec856d8c1e8b81b1835dd4b2eb47"},{"sha":"35df8de402538cb4b2f502f2319d71ce980a1809","author":{"name":"anastasia","email":"21ee4bc1f0d65bd13c426ffc979159e9487d655d@canonical.com"},"message":"Fix test to take new output into account.","distinct":true,"url":"https://api.github.com/repos/mjs/juju/commits/35df8de402538cb4b2f502f2319d71ce980a1809"},{"sha":"632a66a265d16a1fd4c478be963ed1cd514535be","author":{"name":"Juju bot","email":"5ad2d950345774e38fdffd280b9d5ad799044aa9@users.noreply.github.com"},"message":"Merge pull request #6457 from anastasiamac/controllers-refresh-clarification\n\nControllers cmd help change.\n\nThere is potential for user confusion about how to update controllers information when listing controllers.\r\nWe do guide users to \"Use --refresh to see the latest information.\" \r\nHowever, sometimes users can interprete it as a direction to run \"juju --refresh\" (see https://bugs.launchpad.net/bugs/1632699)\r\n\r\nThis PR attempts to make obvious that --refresh is a flag on \"juju controllers\" command not \"juju\" itself.","distinct":true,"url":"https://api.github.com/repos/mjs/juju/commits/632a66a265d16a1fd4c478be963ed1cd514535be"},{"sha":"60d98486795493f242766fb1cba22be2c2ec0960","author":{"name":"Juju bot","email":"5ad2d950345774e38fdffd280b9d5ad799044aa9@users.noreply.github.com"},"message":"Merge pull request #6458 from anastasiamac/service-rename-oversight-lp1633604\n\nFixes lp#1633604: Renamed \"service\" to \"application\".\n\nAn oversight during renaming -  resources command outputs \"Service\" instead of \"Application\".","distinct":true,"url":"https://api.github.com/repos/mjs/juju/commits/60d98486795493f242766fb1cba22be2c2ec0960"},{"sha":"49bfc94e6922780cfd0254df4cf85313f705a86b","author":{"name":"Juju bot","email":"5ad2d950345774e38fdffd280b9d5ad799044aa9@users.noreply.github.com"},"message":"Merge pull request #6459 from anastasiamac/grant-help-lp1633607\n\nFixes lp#1633607: move content of \"grant\" command help.\n\nMove valid arguments before examples.","distinct":true,"url":"https://api.github.com/repos/mjs/juju/commits/49bfc94e6922780cfd0254df4cf85313f705a86b"},{"sha":"ba5e377f486bb880b09f1291e823fd2d9a349ae8","author":{"name":"Roger Peppe","email":"1fc2218fc28b8262889f07d240ee50ae4754500f@gmail.com"},"message":"api: fix intermittent test failures","distinct":true,"url":"https://api.github.com/repos/mjs/juju/commits/ba5e377f486bb880b09f1291e823fd2d9a349ae8"},{"sha":"809dc26b1ecb5727cdcfbfa3511eb67bf9f02db5","author":{"name":"Juju bot","email":"5ad2d950345774e38fdffd280b9d5ad799044aa9@users.noreply.github.com"},"message":"Merge pull request #6461 from rogpeppe/119-fix-snihostname-test-intermittent-failure\n\napi: fix intermittent test failures\n\nThe test code assumed that we'd get dial requests in the\r\norder they are specified, but in a heavily loaded test server\r\nthis is not necessarily the case, leading to failures like this one:\r\n\r\n​http://reports.vapour.ws/releases/4490/job/run-unit-tests-xenial-amd64/attempt/1427#highlight​\r\n\r\nThis fixes the test so that we don't rely on the sequential try ordering - the\r\nconcurrent retry mechanism isn't something we need to test in this test,\r\nso just connect to a single address in each test.","distinct":true,"url":"https://api.github.com/repos/mjs/juju/commits/809dc26b1ecb5727cdcfbfa3511eb67bf9f02db5"}]}
{"actor":{"display_login":"mjs"}}