{"action":"created","issue":{"url":"https://api.github.com/repos/ReactiveX/rxjs/issues/2235","repository_url":"https://api.github.com/repos/ReactiveX/rxjs","labels_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/2235/labels{/name}","comments_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/2235/comments","events_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/2235/events","html_url":"https://github.com/ReactiveX/rxjs/pull/2235","id":198278726,"number":2235,"title":"test(testSchedulerUi): do not convert synchronous test to async test","user":{"login":"kwonoj","id":1210596,"avatar_url":"https://avatars.githubusercontent.com/u/1210596?v=3","gravatar_id":"","url":"https://api.github.com/users/kwonoj","html_url":"https://github.com/kwonoj","followers_url":"https://api.github.com/users/kwonoj/followers","following_url":"https://api.github.com/users/kwonoj/following{/other_user}","gists_url":"https://api.github.com/users/kwonoj/gists{/gist_id}","starred_url":"https://api.github.com/users/kwonoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwonoj/subscriptions","organizations_url":"https://api.github.com/users/kwonoj/orgs","repos_url":"https://api.github.com/users/kwonoj/repos","events_url":"https://api.github.com/users/kwonoj/events{/privacy}","received_events_url":"https://api.github.com/users/kwonoj/received_events","type":"User","site_admin":false},"labels":[{"id":502331411,"url":"https://api.github.com/repos/ReactiveX/rxjs/labels/Next%20Patch%20Version","name":"Next Patch Version","color":"bfd4f2","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-01-01T19:33:03Z","updated_at":"2017-01-01T19:46:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ReactiveX/rxjs/pulls/2235","html_url":"https://github.com/ReactiveX/rxjs/pull/2235","diff_url":"https://github.com/ReactiveX/rxjs/pull/2235.diff","patch_url":"https://github.com/ReactiveX/rxjs/pull/2235.patch"},"body":"<!--\r\nThank you very much for your pull request!\r\n\r\nIf your PR is the addition of a new operator, please make sure all these boxes are ticked with an x:\r\n\r\n- [ ] Add the operator to Rx\r\n- [ ] It must have a `-spec.ts` tests file covering the canonical corner cases, with marble diagram tests\r\n- [ ] If possible, write a `asDiagram` test case too, for PNG diagram generation purposes\r\n- [ ] The spec file should have a type definition test at the end of the spec to verify type definition for various use cases\r\n- [ ] The operator must be documented in JSDoc style in the implementation file, including also the PNG marble diagram image\r\n- [ ] The operator should be listed in `doc/operators.md` in a category of operators\r\n- [ ] It should also be inserted in the operator decision tree file `doc/decision-tree-widget/tree.yml`\r\n- [ ] You may need to update `MIGRATION.md` if the operator differs from the corresponding one in RxJS v4\r\n-->\r\n\r\n**Description:**\r\nThis PR includes minor enhancements to `testSchedulerUi`, do not convert sync test to async unnecessarily. also converted some tests to sync, use fake timers to reduce test execution time where possible.\r\n\r\n**Related issue (if exists):**\r\n#1660"},"comment":{"url":"https://api.github.com/repos/ReactiveX/rxjs/issues/comments/269916578","html_url":"https://github.com/ReactiveX/rxjs/pull/2235#issuecomment-269916578","issue_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/2235","id":269916578,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2017-01-01T19:46:11Z","updated_at":"2017-01-01T19:46:11Z","body":"\n[![Coverage Status](https://coveralls.io/builds/9483955/badge)](https://coveralls.io/builds/9483955)\n\nCoverage remained the same at 97.69% when pulling **441997b2a2c1f174ef2efcdce09cdd72b1ca3304 on kwonoj:chore-test-cleanup** into **6922b16f4a297a4acbe8ad2b086c947b7c0d8315 on ReactiveX:master**.\n"}}
{"actor":{"display_login":"coveralls"}}