{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/addons-server/pulls/comments/88668290","pull_request_review_id":9236001,"id":88668290,"diff_hunk":"@@ -1 +1,64 @@\n-New DevHub Landing\n+<!DOCTYPE html>\n+<html lang=\"{{ LANG }}\" dir=\"{{ DIR }}\">\n+  <head>\n+    <meta charset=\"utf-8\">\n+    <meta name=\"viewport\" content=\"width=device-width, initial-scale=1\">\n+    {% if not settings.ENGAGE_ROBOTS %}\n+      <meta name=\"robots\" content=\"noindex\">\n+    {% endif %}\n+    {% block extrameta %}{% endblock %}\n+\n+    <title>{% block title %}{{ dev_page_title() }}{% endblock %}</title>\n+\n+    <link rel=\"shortcut icon\" type=\"image/x-icon\"\n+          href=\"{{ STATIC_URL }}img/favicon.ico\">\n+\n+    {% block rss_feed %}{% endblock %}\n+\n+    {# L10n: {0} is an application, like Firefox. #}\n+    <link title=\"{{ _('{0} Add-ons')|f(APP.pretty) }}\"\n+          rel=\"search\" type=\"application/opensearchdescription+xml\"\n+          href=\"{{ url('amo.opensearch') }}\" />\n+\n+    {% block site_css %}\n+      {{ css('devhub/css') }}\n+    {% endblock %}\n+\n+    {% block extrahead %}{% endblock %}\n+\n+    {% if request.user.is_authenticated() %}\n+      <meta name=\"csrf\" content=\"{{ csrf_token }}\">\n+    {% endif %}\n+\n+    {{ js('preload') }}\n+  </head>\n+  <body class=\"html-{{ DIR }} {{ request.APP.short }} {% block bodyclass %}{% endblock %}\"\n+        data-raven-dsn=\"{{ settings.RAVEN_DSN }}\"\n+        data-raven-urls=\"{{ settings.RAVEN_ALLOW_LIST }}\"\n+        {% block bodyattrs %}{% endblock %}>\n+\n+    <nav class=\"DevHub-Navigation\">\n+      <ul>\n+        <li><a href=\"#\"><div class=\"Logo\" alt=\"{{ _('Mozilla Firefox') }}\" /></a></li>\n+        <li><a href=\"#\">Docs</a></li>\n+        <li><a href=\"#\">Support</a></li>\n+        <li><a href=\"#\">Blog</a></li>\n+      </ul>\n+    </nav>\n+\n+    <section class=\"DevHub-Header\">\n+      <h1>{{ _('Customize Your Firefox') }}</h1>\n+      <p>\n+        {% trans %}\n+        Add-ons let millions of Firefox users enhance their browsing experience.\n+        If you know <a href=\"#\">HTML</a>, <a href=\"#\">JavaScript</a>, and <a href=\"#\">CSS</a>,","path":"src/olympia/devhub/templates/devhub/new-landing/index.html","position":55,"original_position":55,"commit_id":"e51ff165c0eba04bda0f38d591a8bc02899d88cc","original_commit_id":"e51ff165c0eba04bda0f38d591a8bc02899d88cc","user":{"login":"muffinresearch","id":1514,"avatar_url":"https://avatars.githubusercontent.com/u/1514?v=3","gravatar_id":"","url":"https://api.github.com/users/muffinresearch","html_url":"https://github.com/muffinresearch","followers_url":"https://api.github.com/users/muffinresearch/followers","following_url":"https://api.github.com/users/muffinresearch/following{/other_user}","gists_url":"https://api.github.com/users/muffinresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/muffinresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muffinresearch/subscriptions","organizations_url":"https://api.github.com/users/muffinresearch/orgs","repos_url":"https://api.github.com/users/muffinresearch/repos","events_url":"https://api.github.com/users/muffinresearch/events{/privacy}","received_events_url":"https://api.github.com/users/muffinresearch/received_events","type":"User","site_admin":false},"body":"I still reckon these could be moved out as placeholders unless I'm missing something about the need to translate the technology names inside the anchors. Could be a follow-up though.","created_at":"2016-11-18T14:41:58Z","updated_at":"2016-11-18T14:41:59Z","html_url":"https://github.com/mozilla/addons-server/pull/4000#discussion_r88668290","pull_request_url":"https://api.github.com/repos/mozilla/addons-server/pulls/4000","_links":{"self":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/comments/88668290"},"html":{"href":"https://github.com/mozilla/addons-server/pull/4000#discussion_r88668290"},"pull_request":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/4000"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/addons-server/pulls/4000","id":93613005,"html_url":"https://github.com/mozilla/addons-server/pull/4000","diff_url":"https://github.com/mozilla/addons-server/pull/4000.diff","patch_url":"https://github.com/mozilla/addons-server/pull/4000.patch","issue_url":"https://api.github.com/repos/mozilla/addons-server/issues/4000","number":4000,"state":"open","locked":false,"title":"[WIP] Devhub Landing Navigation & Section Header","user":{"login":"EnTeQuAk","id":139033,"avatar_url":"https://avatars.githubusercontent.com/u/139033?v=3","gravatar_id":"","url":"https://api.github.com/users/EnTeQuAk","html_url":"https://github.com/EnTeQuAk","followers_url":"https://api.github.com/users/EnTeQuAk/followers","following_url":"https://api.github.com/users/EnTeQuAk/following{/other_user}","gists_url":"https://api.github.com/users/EnTeQuAk/gists{/gist_id}","starred_url":"https://api.github.com/users/EnTeQuAk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EnTeQuAk/subscriptions","organizations_url":"https://api.github.com/users/EnTeQuAk/orgs","repos_url":"https://api.github.com/users/EnTeQuAk/repos","events_url":"https://api.github.com/users/EnTeQuAk/events{/privacy}","received_events_url":"https://api.github.com/users/EnTeQuAk/received_events","type":"User","site_admin":false},"body":"This is the first version and probably breaks a few tests (hopefully?) \r\n\r\nIt's reusing pretty much nothing from the main site for now, this might change but it's a lot easier to change later (since all devhub pages get the new design eventually and they can just inherit from a new base-template) than to fiddle around with the general page styles.\r\n\r\nVery minimalistic and mobile first (and only) for now.\r\n\r\n* [x] Add mobile navigation\r\n* [x] Navigation scales responsively (logo stay left, links move to the right, will be a bit more centered on desktop though...)\r\n* [x] Add section header\r\n* [x] optimize SVG\r\n* [x] Fix tests...\r\n* [x] Add `<meta name=\"viewport\" ...>`\r\n* [x] Add normalize.css\r\n* [x] Follow suitcss naming\r\n* [x] Properly extract color-codes into variables\r\n* [x] Extract navigation into separate section and template to make it reusable and not bound to a section\r\n* [x] alpha-sort names\r\n* [x] use stylelint config (needs to be integrated into test/build process but that's another PR)\r\n\r\n@tofumatt @muffinresearch ready for first comments :)\r\n\r\nIt's theoretically looking like this…\r\n![screenshot from 2016-11-18 14-56-55](https://cloud.githubusercontent.com/assets/139033/20432410/64ffcc26-ad9f-11e6-9c35-7a57d154fade.png)\r\n\r\nAnd should look like this…\r\n\r\nhttps://github.com/mozilla/addons-frontend/issues/1021#issuecomment-252804561","created_at":"2016-11-14T17:42:42Z","updated_at":"2016-11-18T14:41:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"794ba5b64abcb1f485d675fb42cd67d2143f6078","assignee":{"login":"muffinresearch","id":1514,"avatar_url":"https://avatars.githubusercontent.com/u/1514?v=3","gravatar_id":"","url":"https://api.github.com/users/muffinresearch","html_url":"https://github.com/muffinresearch","followers_url":"https://api.github.com/users/muffinresearch/followers","following_url":"https://api.github.com/users/muffinresearch/following{/other_user}","gists_url":"https://api.github.com/users/muffinresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/muffinresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muffinresearch/subscriptions","organizations_url":"https://api.github.com/users/muffinresearch/orgs","repos_url":"https://api.github.com/users/muffinresearch/repos","events_url":"https://api.github.com/users/muffinresearch/events{/privacy}","received_events_url":"https://api.github.com/users/muffinresearch/received_events","type":"User","site_admin":false},"assignees":[{"login":"muffinresearch","id":1514,"avatar_url":"https://avatars.githubusercontent.com/u/1514?v=3","gravatar_id":"","url":"https://api.github.com/users/muffinresearch","html_url":"https://github.com/muffinresearch","followers_url":"https://api.github.com/users/muffinresearch/followers","following_url":"https://api.github.com/users/muffinresearch/following{/other_user}","gists_url":"https://api.github.com/users/muffinresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/muffinresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muffinresearch/subscriptions","organizations_url":"https://api.github.com/users/muffinresearch/orgs","repos_url":"https://api.github.com/users/muffinresearch/repos","events_url":"https://api.github.com/users/muffinresearch/events{/privacy}","received_events_url":"https://api.github.com/users/muffinresearch/received_events","type":"User","site_admin":false},{"login":"tofumatt","id":90871,"avatar_url":"https://avatars.githubusercontent.com/u/90871?v=3","gravatar_id":"","url":"https://api.github.com/users/tofumatt","html_url":"https://github.com/tofumatt","followers_url":"https://api.github.com/users/tofumatt/followers","following_url":"https://api.github.com/users/tofumatt/following{/other_user}","gists_url":"https://api.github.com/users/tofumatt/gists{/gist_id}","starred_url":"https://api.github.com/users/tofumatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tofumatt/subscriptions","organizations_url":"https://api.github.com/users/tofumatt/orgs","repos_url":"https://api.github.com/users/tofumatt/repos","events_url":"https://api.github.com/users/tofumatt/events{/privacy}","received_events_url":"https://api.github.com/users/tofumatt/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/addons-server/pulls/4000/commits","review_comments_url":"https://api.github.com/repos/mozilla/addons-server/pulls/4000/comments","review_comment_url":"https://api.github.com/repos/mozilla/addons-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/addons-server/issues/4000/comments","statuses_url":"https://api.github.com/repos/mozilla/addons-server/statuses/e51ff165c0eba04bda0f38d591a8bc02899d88cc","head":{"label":"mozilla:feature/3849-new-devhub-landing-navigation","ref":"feature/3849-new-devhub-landing-navigation","sha":"e51ff165c0eba04bda0f38d591a8bc02899d88cc","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":16416867,"name":"addons-server","full_name":"mozilla/addons-server","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/addons-server","description":"🕶 addons.mozilla.org Django app 🎉","fork":false,"url":"https://api.github.com/repos/mozilla/addons-server","forks_url":"https://api.github.com/repos/mozilla/addons-server/forks","keys_url":"https://api.github.com/repos/mozilla/addons-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/addons-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/addons-server/teams","hooks_url":"https://api.github.com/repos/mozilla/addons-server/hooks","issue_events_url":"https://api.github.com/repos/mozilla/addons-server/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/addons-server/events","assignees_url":"https://api.github.com/repos/mozilla/addons-server/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/addons-server/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/addons-server/tags","blobs_url":"https://api.github.com/repos/mozilla/addons-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/addons-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/addons-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/addons-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/addons-server/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/addons-server/languages","stargazers_url":"https://api.github.com/repos/mozilla/addons-server/stargazers","contributors_url":"https://api.github.com/repos/mozilla/addons-server/contributors","subscribers_url":"https://api.github.com/repos/mozilla/addons-server/subscribers","subscription_url":"https://api.github.com/repos/mozilla/addons-server/subscription","commits_url":"https://api.github.com/repos/mozilla/addons-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/addons-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/addons-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/addons-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/addons-server/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/addons-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/addons-server/merges","archive_url":"https://api.github.com/repos/mozilla/addons-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/addons-server/downloads","issues_url":"https://api.github.com/repos/mozilla/addons-server/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/addons-server/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/addons-server/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/addons-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/addons-server/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/addons-server/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/addons-server/deployments","created_at":"2014-01-31T18:44:15Z","updated_at":"2016-11-17T12:43:48Z","pushed_at":"2016-11-18T14:25:13Z","git_url":"git://github.com/mozilla/addons-server.git","ssh_url":"git@github.com:mozilla/addons-server.git","clone_url":"https://github.com/mozilla/addons-server.git","svn_url":"https://github.com/mozilla/addons-server","homepage":"https://addons.mozilla.org/","size":723463,"stargazers_count":130,"watchers_count":130,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":183,"mirror_url":null,"open_issues_count":280,"forks":183,"open_issues":280,"watchers":130,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"76893203cf27aa6ba7cf2087ce58168f1b0fc595","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":16416867,"name":"addons-server","full_name":"mozilla/addons-server","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/addons-server","description":"🕶 addons.mozilla.org Django app 🎉","fork":false,"url":"https://api.github.com/repos/mozilla/addons-server","forks_url":"https://api.github.com/repos/mozilla/addons-server/forks","keys_url":"https://api.github.com/repos/mozilla/addons-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/addons-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/addons-server/teams","hooks_url":"https://api.github.com/repos/mozilla/addons-server/hooks","issue_events_url":"https://api.github.com/repos/mozilla/addons-server/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/addons-server/events","assignees_url":"https://api.github.com/repos/mozilla/addons-server/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/addons-server/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/addons-server/tags","blobs_url":"https://api.github.com/repos/mozilla/addons-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/addons-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/addons-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/addons-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/addons-server/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/addons-server/languages","stargazers_url":"https://api.github.com/repos/mozilla/addons-server/stargazers","contributors_url":"https://api.github.com/repos/mozilla/addons-server/contributors","subscribers_url":"https://api.github.com/repos/mozilla/addons-server/subscribers","subscription_url":"https://api.github.com/repos/mozilla/addons-server/subscription","commits_url":"https://api.github.com/repos/mozilla/addons-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/addons-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/addons-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/addons-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/addons-server/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/addons-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/addons-server/merges","archive_url":"https://api.github.com/repos/mozilla/addons-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/addons-server/downloads","issues_url":"https://api.github.com/repos/mozilla/addons-server/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/addons-server/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/addons-server/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/addons-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/addons-server/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/addons-server/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/addons-server/deployments","created_at":"2014-01-31T18:44:15Z","updated_at":"2016-11-17T12:43:48Z","pushed_at":"2016-11-18T14:25:13Z","git_url":"git://github.com/mozilla/addons-server.git","ssh_url":"git@github.com:mozilla/addons-server.git","clone_url":"https://github.com/mozilla/addons-server.git","svn_url":"https://github.com/mozilla/addons-server","homepage":"https://addons.mozilla.org/","size":723463,"stargazers_count":130,"watchers_count":130,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":183,"mirror_url":null,"open_issues_count":280,"forks":183,"open_issues":280,"watchers":130,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/4000"},"html":{"href":"https://github.com/mozilla/addons-server/pull/4000"},"issue":{"href":"https://api.github.com/repos/mozilla/addons-server/issues/4000"},"comments":{"href":"https://api.github.com/repos/mozilla/addons-server/issues/4000/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/4000/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/4000/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/addons-server/statuses/e51ff165c0eba04bda0f38d591a8bc02899d88cc"}}}}
{"actor":{"display_login":"muffinresearch"}}