{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/15175","repository_url":"https://api.github.com/repos/dotnet/roslyn","labels_url":"https://api.github.com/repos/dotnet/roslyn/issues/15175/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/15175/comments","events_url":"https://api.github.com/repos/dotnet/roslyn/issues/15175/events","html_url":"https://github.com/dotnet/roslyn/pull/15175","id":188833774,"number":15175,"title":"Reduce completion annoyances when typing deconstruction declarations","user":{"login":"jcouv","id":12466233,"avatar_url":"https://avatars.githubusercontent.com/u/12466233?v=3","gravatar_id":"","url":"https://api.github.com/users/jcouv","html_url":"https://github.com/jcouv","followers_url":"https://api.github.com/users/jcouv/followers","following_url":"https://api.github.com/users/jcouv/following{/other_user}","gists_url":"https://api.github.com/users/jcouv/gists{/gist_id}","starred_url":"https://api.github.com/users/jcouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcouv/subscriptions","organizations_url":"https://api.github.com/users/jcouv/orgs","repos_url":"https://api.github.com/users/jcouv/repos","events_url":"https://api.github.com/users/jcouv/events{/privacy}","received_events_url":"https://api.github.com/users/jcouv/received_events","type":"User","site_admin":false},"labels":[{"id":166673288,"url":"https://api.github.com/repos/dotnet/roslyn/labels/Area-Compilers","name":"Area-Compilers","color":"5319e7","default":false},{"id":197452922,"url":"https://api.github.com/repos/dotnet/roslyn/labels/cla-already-signed","name":"cla-already-signed","color":"009800","default":false},{"id":332342663,"url":"https://api.github.com/repos/dotnet/roslyn/labels/New%20Language%20Feature%20-%20Tuples","name":"New Language Feature - Tuples","color":"bfd4f2","default":false}],"state":"open","locked":false,"assignee":{"login":"jcouv","id":12466233,"avatar_url":"https://avatars.githubusercontent.com/u/12466233?v=3","gravatar_id":"","url":"https://api.github.com/users/jcouv","html_url":"https://github.com/jcouv","followers_url":"https://api.github.com/users/jcouv/followers","following_url":"https://api.github.com/users/jcouv/following{/other_user}","gists_url":"https://api.github.com/users/jcouv/gists{/gist_id}","starred_url":"https://api.github.com/users/jcouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcouv/subscriptions","organizations_url":"https://api.github.com/users/jcouv/orgs","repos_url":"https://api.github.com/users/jcouv/repos","events_url":"https://api.github.com/users/jcouv/events{/privacy}","received_events_url":"https://api.github.com/users/jcouv/received_events","type":"User","site_admin":false},"assignees":[{"login":"jcouv","id":12466233,"avatar_url":"https://avatars.githubusercontent.com/u/12466233?v=3","gravatar_id":"","url":"https://api.github.com/users/jcouv","html_url":"https://github.com/jcouv","followers_url":"https://api.github.com/users/jcouv/followers","following_url":"https://api.github.com/users/jcouv/following{/other_user}","gists_url":"https://api.github.com/users/jcouv/gists{/gist_id}","starred_url":"https://api.github.com/users/jcouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcouv/subscriptions","organizations_url":"https://api.github.com/users/jcouv/orgs","repos_url":"https://api.github.com/users/jcouv/repos","events_url":"https://api.github.com/users/jcouv/events{/privacy}","received_events_url":"https://api.github.com/users/jcouv/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/roslyn/milestones/24","html_url":"https://github.com/dotnet/roslyn/milestones/2.0%20(RC.2)","labels_url":"https://api.github.com/repos/dotnet/roslyn/milestones/24/labels","id":2090735,"number":24,"title":"2.0 (RC.2)","description":"","creator":{"login":"jaredpar","id":146967,"avatar_url":"https://avatars.githubusercontent.com/u/146967?v=3","gravatar_id":"","url":"https://api.github.com/users/jaredpar","html_url":"https://github.com/jaredpar","followers_url":"https://api.github.com/users/jaredpar/followers","following_url":"https://api.github.com/users/jaredpar/following{/other_user}","gists_url":"https://api.github.com/users/jaredpar/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredpar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredpar/subscriptions","organizations_url":"https://api.github.com/users/jaredpar/orgs","repos_url":"https://api.github.com/users/jaredpar/repos","events_url":"https://api.github.com/users/jaredpar/events{/privacy}","received_events_url":"https://api.github.com/users/jaredpar/received_events","type":"User","site_admin":false},"open_issues":164,"closed_issues":98,"state":"open","created_at":"2016-10-24T21:54:24Z","updated_at":"2016-11-22T03:33:18Z","due_on":null,"closed_at":null},"comments":8,"created_at":"2016-11-11T19:35:32Z","updated_at":"2016-11-22T04:11:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/15175","html_url":"https://github.com/dotnet/roslyn/pull/15175","diff_url":"https://github.com/dotnet/roslyn/pull/15175.diff","patch_url":"https://github.com/dotnet/roslyn/pull/15175.patch"},"body":"Fixes https://github.com/dotnet/roslyn/issues/14901\r\n\r\nTwo completions were still getting in the way:\r\n\r\n1. Symbol completion if you have any symbol that looks like \"var\" (would get in the way of typing \"var\")\r\n2. As and Is keyword completion would get in the way of typing designation identifiers (such as \"a\" in \"(int a, int b) = ...\")\r\n\r\nNow, the \"var\" keyword is also suggested in deconstruction contexts and a suggestion/builder mode is added when typing a likely designation.\r\n\r\n@CyrusNajmabadi and @dotnet/roslyn-ide for RC2 review. Thanks\r\nFYI @dotnet/roslyn-compiler "},"comment":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/comments/262142959","html_url":"https://github.com/dotnet/roslyn/pull/15175#issuecomment-262142959","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/15175","id":262142959,"user":{"login":"jcouv","id":12466233,"avatar_url":"https://avatars.githubusercontent.com/u/12466233?v=3","gravatar_id":"","url":"https://api.github.com/users/jcouv","html_url":"https://github.com/jcouv","followers_url":"https://api.github.com/users/jcouv/followers","following_url":"https://api.github.com/users/jcouv/following{/other_user}","gists_url":"https://api.github.com/users/jcouv/gists{/gist_id}","starred_url":"https://api.github.com/users/jcouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcouv/subscriptions","organizations_url":"https://api.github.com/users/jcouv/orgs","repos_url":"https://api.github.com/users/jcouv/repos","events_url":"https://api.github.com/users/jcouv/events{/privacy}","received_events_url":"https://api.github.com/users/jcouv/received_events","type":"User","site_admin":false},"created_at":"2016-11-22T04:11:37Z","updated_at":"2016-11-22T04:11:37Z","body":"@MattGertz @Pilchie @ManishJayaswal for RC2 approval.\r\n\r\nThis is an IDE fix that allows some keywords (like \"var\") to be suggested when typing a deconstruction and toggles the suggestions to be soft-selected in some parts of deconstructions (when you may be typing a brand new identifier).\r\n\r\n- Fixes #14901, which was raised by a customer and prompted to expand the test coverage (there are many scenarios where a partially-typed deconstruction may not be recognized as such by the parser).\r\n- Users however can work around the completion annoyance (pressing escape to close intellisense).\r\n- There is no expected performance impact. We already had logic for those scenarios, but the logic was refined to recognize more variations.\r\n\r\nFYI @jaredpar "}}
{"actor":{"display_login":"jcouv"}}