{"action":"closed","number":4655,"pull_request":{"url":"https://api.github.com/repos/PX4/Firmware/pulls/4655","id":71713304,"html_url":"https://github.com/PX4/Firmware/pull/4655","diff_url":"https://github.com/PX4/Firmware/pull/4655.diff","patch_url":"https://github.com/PX4/Firmware/pull/4655.patch","issue_url":"https://api.github.com/repos/PX4/Firmware/issues/4655","number":4655,"state":"closed","locked":false,"title":"Offboard lost actions with additional timeout","user":{"login":"AndreasAntener","id":5750020,"avatar_url":"https://avatars.githubusercontent.com/u/5750020?v=3","gravatar_id":"","url":"https://api.github.com/users/AndreasAntener","html_url":"https://github.com/AndreasAntener","followers_url":"https://api.github.com/users/AndreasAntener/followers","following_url":"https://api.github.com/users/AndreasAntener/following{/other_user}","gists_url":"https://api.github.com/users/AndreasAntener/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreasAntener/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreasAntener/subscriptions","organizations_url":"https://api.github.com/users/AndreasAntener/orgs","repos_url":"https://api.github.com/users/AndreasAntener/repos","events_url":"https://api.github.com/users/AndreasAntener/events{/privacy}","received_events_url":"https://api.github.com/users/AndreasAntener/received_events","type":"User","site_admin":false},"body":"Reimplemented offboard lost handling from #3404\r\n@LorenzMeier before I go ahead with this, I'd like some feedback on where the states should switch. Since my earlier version you started to add failsafe handling in the navigator (e.g. here: https://github.com/PX4/Firmware/blob/master/src/modules/navigator/navigator_main.cpp#L570), and now we have 2 places where nav state decisions happen, a duplication of responsibilities. So in contrary of how RC and DL loss got implemented on master, the state switching here is all in state_machine_helper.","created_at":"2016-05-27T13:31:57Z","updated_at":"2016-06-20T18:23:52Z","closed_at":"2016-06-20T18:23:52Z","merged_at":"2016-06-20T18:23:52Z","merge_commit_sha":"d1b27ab056d35f695b33d1a021d8900a4d69ba61","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PX4/Firmware/pulls/4655/commits","review_comments_url":"https://api.github.com/repos/PX4/Firmware/pulls/4655/comments","review_comment_url":"https://api.github.com/repos/PX4/Firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PX4/Firmware/issues/4655/comments","statuses_url":"https://api.github.com/repos/PX4/Firmware/statuses/d1b27ab056d35f695b33d1a021d8900a4d69ba61","head":{"label":"PX4:offboard_lost","ref":"offboard_lost","sha":"d1b27ab056d35f695b33d1a021d8900a4d69ba61","user":{"login":"PX4","id":2096014,"avatar_url":"https://avatars.githubusercontent.com/u/2096014?v=3","gravatar_id":"","url":"https://api.github.com/users/PX4","html_url":"https://github.com/PX4","followers_url":"https://api.github.com/users/PX4/followers","following_url":"https://api.github.com/users/PX4/following{/other_user}","gists_url":"https://api.github.com/users/PX4/gists{/gist_id}","starred_url":"https://api.github.com/users/PX4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PX4/subscriptions","organizations_url":"https://api.github.com/users/PX4/orgs","repos_url":"https://api.github.com/users/PX4/repos","events_url":"https://api.github.com/users/PX4/events{/privacy}","received_events_url":"https://api.github.com/users/PX4/received_events","type":"Organization","site_admin":false},"repo":{"id":5298790,"name":"Firmware","full_name":"PX4/Firmware","owner":{"login":"PX4","id":2096014,"avatar_url":"https://avatars.githubusercontent.com/u/2096014?v=3","gravatar_id":"","url":"https://api.github.com/users/PX4","html_url":"https://github.com/PX4","followers_url":"https://api.github.com/users/PX4/followers","following_url":"https://api.github.com/users/PX4/following{/other_user}","gists_url":"https://api.github.com/users/PX4/gists{/gist_id}","starred_url":"https://api.github.com/users/PX4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PX4/subscriptions","organizations_url":"https://api.github.com/users/PX4/orgs","repos_url":"https://api.github.com/users/PX4/repos","events_url":"https://api.github.com/users/PX4/events{/privacy}","received_events_url":"https://api.github.com/users/PX4/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PX4/Firmware","description":"PX4 Pro Autopilot Software","fork":false,"url":"https://api.github.com/repos/PX4/Firmware","forks_url":"https://api.github.com/repos/PX4/Firmware/forks","keys_url":"https://api.github.com/repos/PX4/Firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PX4/Firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PX4/Firmware/teams","hooks_url":"https://api.github.com/repos/PX4/Firmware/hooks","issue_events_url":"https://api.github.com/repos/PX4/Firmware/issues/events{/number}","events_url":"https://api.github.com/repos/PX4/Firmware/events","assignees_url":"https://api.github.com/repos/PX4/Firmware/assignees{/user}","branches_url":"https://api.github.com/repos/PX4/Firmware/branches{/branch}","tags_url":"https://api.github.com/repos/PX4/Firmware/tags","blobs_url":"https://api.github.com/repos/PX4/Firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PX4/Firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PX4/Firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/PX4/Firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PX4/Firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/PX4/Firmware/languages","stargazers_url":"https://api.github.com/repos/PX4/Firmware/stargazers","contributors_url":"https://api.github.com/repos/PX4/Firmware/contributors","subscribers_url":"https://api.github.com/repos/PX4/Firmware/subscribers","subscription_url":"https://api.github.com/repos/PX4/Firmware/subscription","commits_url":"https://api.github.com/repos/PX4/Firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/PX4/Firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/PX4/Firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/PX4/Firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/PX4/Firmware/contents/{+path}","compare_url":"https://api.github.com/repos/PX4/Firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PX4/Firmware/merges","archive_url":"https://api.github.com/repos/PX4/Firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PX4/Firmware/downloads","issues_url":"https://api.github.com/repos/PX4/Firmware/issues{/number}","pulls_url":"https://api.github.com/repos/PX4/Firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/PX4/Firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/PX4/Firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PX4/Firmware/labels{/name}","releases_url":"https://api.github.com/repos/PX4/Firmware/releases{/id}","deployments_url":"https://api.github.com/repos/PX4/Firmware/deployments","created_at":"2012-08-04T21:19:36Z","updated_at":"2016-06-20T07:09:03Z","pushed_at":"2016-06-20T18:23:48Z","git_url":"git://github.com/PX4/Firmware.git","ssh_url":"git@github.com:PX4/Firmware.git","clone_url":"https://github.com/PX4/Firmware.git","svn_url":"https://github.com/PX4/Firmware","homepage":"http://px4.io","size":196951,"stargazers_count":645,"watchers_count":645,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2355,"mirror_url":null,"open_issues_count":346,"forks":2355,"open_issues":346,"watchers":645,"default_branch":"master"}},"base":{"label":"PX4:master","ref":"master","sha":"e42b5804a0c166f883da50d91aefa0060606e1fb","user":{"login":"PX4","id":2096014,"avatar_url":"https://avatars.githubusercontent.com/u/2096014?v=3","gravatar_id":"","url":"https://api.github.com/users/PX4","html_url":"https://github.com/PX4","followers_url":"https://api.github.com/users/PX4/followers","following_url":"https://api.github.com/users/PX4/following{/other_user}","gists_url":"https://api.github.com/users/PX4/gists{/gist_id}","starred_url":"https://api.github.com/users/PX4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PX4/subscriptions","organizations_url":"https://api.github.com/users/PX4/orgs","repos_url":"https://api.github.com/users/PX4/repos","events_url":"https://api.github.com/users/PX4/events{/privacy}","received_events_url":"https://api.github.com/users/PX4/received_events","type":"Organization","site_admin":false},"repo":{"id":5298790,"name":"Firmware","full_name":"PX4/Firmware","owner":{"login":"PX4","id":2096014,"avatar_url":"https://avatars.githubusercontent.com/u/2096014?v=3","gravatar_id":"","url":"https://api.github.com/users/PX4","html_url":"https://github.com/PX4","followers_url":"https://api.github.com/users/PX4/followers","following_url":"https://api.github.com/users/PX4/following{/other_user}","gists_url":"https://api.github.com/users/PX4/gists{/gist_id}","starred_url":"https://api.github.com/users/PX4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PX4/subscriptions","organizations_url":"https://api.github.com/users/PX4/orgs","repos_url":"https://api.github.com/users/PX4/repos","events_url":"https://api.github.com/users/PX4/events{/privacy}","received_events_url":"https://api.github.com/users/PX4/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PX4/Firmware","description":"PX4 Pro Autopilot Software","fork":false,"url":"https://api.github.com/repos/PX4/Firmware","forks_url":"https://api.github.com/repos/PX4/Firmware/forks","keys_url":"https://api.github.com/repos/PX4/Firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PX4/Firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PX4/Firmware/teams","hooks_url":"https://api.github.com/repos/PX4/Firmware/hooks","issue_events_url":"https://api.github.com/repos/PX4/Firmware/issues/events{/number}","events_url":"https://api.github.com/repos/PX4/Firmware/events","assignees_url":"https://api.github.com/repos/PX4/Firmware/assignees{/user}","branches_url":"https://api.github.com/repos/PX4/Firmware/branches{/branch}","tags_url":"https://api.github.com/repos/PX4/Firmware/tags","blobs_url":"https://api.github.com/repos/PX4/Firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PX4/Firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PX4/Firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/PX4/Firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PX4/Firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/PX4/Firmware/languages","stargazers_url":"https://api.github.com/repos/PX4/Firmware/stargazers","contributors_url":"https://api.github.com/repos/PX4/Firmware/contributors","subscribers_url":"https://api.github.com/repos/PX4/Firmware/subscribers","subscription_url":"https://api.github.com/repos/PX4/Firmware/subscription","commits_url":"https://api.github.com/repos/PX4/Firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/PX4/Firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/PX4/Firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/PX4/Firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/PX4/Firmware/contents/{+path}","compare_url":"https://api.github.com/repos/PX4/Firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PX4/Firmware/merges","archive_url":"https://api.github.com/repos/PX4/Firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PX4/Firmware/downloads","issues_url":"https://api.github.com/repos/PX4/Firmware/issues{/number}","pulls_url":"https://api.github.com/repos/PX4/Firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/PX4/Firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/PX4/Firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PX4/Firmware/labels{/name}","releases_url":"https://api.github.com/repos/PX4/Firmware/releases{/id}","deployments_url":"https://api.github.com/repos/PX4/Firmware/deployments","created_at":"2012-08-04T21:19:36Z","updated_at":"2016-06-20T07:09:03Z","pushed_at":"2016-06-20T18:23:48Z","git_url":"git://github.com/PX4/Firmware.git","ssh_url":"git@github.com:PX4/Firmware.git","clone_url":"https://github.com/PX4/Firmware.git","svn_url":"https://github.com/PX4/Firmware","homepage":"http://px4.io","size":196951,"stargazers_count":645,"watchers_count":645,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2355,"mirror_url":null,"open_issues_count":346,"forks":2355,"open_issues":346,"watchers":645,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/4655"},"html":{"href":"https://github.com/PX4/Firmware/pull/4655"},"issue":{"href":"https://api.github.com/repos/PX4/Firmware/issues/4655"},"comments":{"href":"https://api.github.com/repos/PX4/Firmware/issues/4655/comments"},"review_comments":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/4655/comments"},"review_comment":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/4655/commits"},"statuses":{"href":"https://api.github.com/repos/PX4/Firmware/statuses/d1b27ab056d35f695b33d1a021d8900a4d69ba61"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"AndreasAntener","id":5750020,"avatar_url":"https://avatars.githubusercontent.com/u/5750020?v=3","gravatar_id":"","url":"https://api.github.com/users/AndreasAntener","html_url":"https://github.com/AndreasAntener","followers_url":"https://api.github.com/users/AndreasAntener/followers","following_url":"https://api.github.com/users/AndreasAntener/following{/other_user}","gists_url":"https://api.github.com/users/AndreasAntener/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreasAntener/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreasAntener/subscriptions","organizations_url":"https://api.github.com/users/AndreasAntener/orgs","repos_url":"https://api.github.com/users/AndreasAntener/repos","events_url":"https://api.github.com/users/AndreasAntener/events{/privacy}","received_events_url":"https://api.github.com/users/AndreasAntener/received_events","type":"User","site_admin":false},"comments":5,"review_comments":10,"commits":6,"additions":146,"deletions":11,"changed_files":5}}
{"actor":{"display_login":"AndreasAntener"}}