{"action":"closed","number":4,"pull_request":{"url":"https://api.github.com/repos/cyraxx/node-pogo-protos/pulls/4","id":82116098,"html_url":"https://github.com/cyraxx/node-pogo-protos/pull/4","diff_url":"https://github.com/cyraxx/node-pogo-protos/pull/4.diff","patch_url":"https://github.com/cyraxx/node-pogo-protos/pull/4.patch","issue_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/issues/4","number":4,"state":"closed","locked":false,"title":"typings support","user":{"login":"likerRr","id":1290558,"avatar_url":"https://avatars.githubusercontent.com/u/1290558?v=3","gravatar_id":"","url":"https://api.github.com/users/likerRr","html_url":"https://github.com/likerRr","followers_url":"https://api.github.com/users/likerRr/followers","following_url":"https://api.github.com/users/likerRr/following{/other_user}","gists_url":"https://api.github.com/users/likerRr/gists{/gist_id}","starred_url":"https://api.github.com/users/likerRr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/likerRr/subscriptions","organizations_url":"https://api.github.com/users/likerRr/orgs","repos_url":"https://api.github.com/users/likerRr/repos","events_url":"https://api.github.com/users/likerRr/events{/privacy}","received_events_url":"https://api.github.com/users/likerRr/received_events","type":"User","site_admin":false},"body":"Hi!\r\n\r\nJust noticed that you've committed [typings support](https://github.com/cyraxx/node-pogo-protos/commit/1e65b475fb102a0a78257514e5713ed74f293312). I've been working on ts support for few last days and I wanted to make pull request today, but you've beaten me :) Nice that you did it, but unfortunately this automatic generated file has some issues in it. \r\n\r\nThe meaning of \"module\" in typescript is no longer used as it's done in [Proto2TypeScript](https://github.com/SINTEF-9012/Proto2TypeScript). The \"namespace\"-way is [prefered now](https://www.typescriptlang.org/docs/handbook/modules.html).\r\n\r\nSecond issues are praised auto completeion and go-to declaration benefits. Look how it works with Proto2TypeScript in WebStorm:\r\n\r\n![7205e-clip-59kb](https://cloud.githubusercontent.com/assets/1290558/17839577/bca8f682-67f4-11e6-90c9-6efee24d29dd.png)\r\n> At the picture there is no auto completeion after the \"Messages.\"\r\n\r\n![e8bec-clip-78kb](https://cloud.githubusercontent.com/assets/1290558/17839572/8047f904-67f4-11e6-8e0a-5ca75d8dd4eb.png)\r\n> Go to declaration feature goes crazy\r\n\r\nAnd the last what I've noticed it doesn't allow you to use your module with ES6 module syntax:\r\n`import * as POGOProtos from 'node-pogo-protos';`\r\n\r\n## Solution\r\n\r\nI made a generator that produced attached pogo-protos.d.ts file. You can notice the advantages over the Proto2TypeScript:\r\n\r\n1. The declaration file doesn't declare any external module.\r\n2. All messages are grouped by the namespace that allows better code completion and go to declaration features.\r\n![6dcce-clip-76kb](https://cloud.githubusercontent.com/assets/1290558/17839613/f2e49ff2-67f5-11e6-9d17-bda1adf53b6f.png)\r\n> better auto complete\r\n\r\n![47fc3-clip-30kb](https://cloud.githubusercontent.com/assets/1290558/17839627/410bdc18-67f6-11e6-9b90-4a9187b3c3be.png)\r\n> Go to declaration moves you to class's declaration\r\n\r\n3. You can use ES6 module syntax :+1: \r\n\r\nI made it special for the `node-pogo-protos` so if you like it, I will update generator package and will push it at github and provide you with instruction how to generate such files.","created_at":"2016-08-21T20:27:43Z","updated_at":"2016-08-30T08:26:07Z","closed_at":"2016-08-30T08:26:07Z","merged_at":"2016-08-30T08:26:07Z","merge_commit_sha":"d549e645ed27c855a7a59595f0c1976ab35adfb6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/pulls/4/commits","review_comments_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/pulls/4/comments","review_comment_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/issues/4/comments","statuses_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/statuses/9d570ce00e7d18f65e9df4cef17b0fe410230200","head":{"label":"likerRr:typings_support","ref":"typings_support","sha":"9d570ce00e7d18f65e9df4cef17b0fe410230200","user":{"login":"likerRr","id":1290558,"avatar_url":"https://avatars.githubusercontent.com/u/1290558?v=3","gravatar_id":"","url":"https://api.github.com/users/likerRr","html_url":"https://github.com/likerRr","followers_url":"https://api.github.com/users/likerRr/followers","following_url":"https://api.github.com/users/likerRr/following{/other_user}","gists_url":"https://api.github.com/users/likerRr/gists{/gist_id}","starred_url":"https://api.github.com/users/likerRr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/likerRr/subscriptions","organizations_url":"https://api.github.com/users/likerRr/orgs","repos_url":"https://api.github.com/users/likerRr/repos","events_url":"https://api.github.com/users/likerRr/events{/privacy}","received_events_url":"https://api.github.com/users/likerRr/received_events","type":"User","site_admin":false},"repo":{"id":64927572,"name":"node-pogo-protos","full_name":"likerRr/node-pogo-protos","owner":{"login":"likerRr","id":1290558,"avatar_url":"https://avatars.githubusercontent.com/u/1290558?v=3","gravatar_id":"","url":"https://api.github.com/users/likerRr","html_url":"https://github.com/likerRr","followers_url":"https://api.github.com/users/likerRr/followers","following_url":"https://api.github.com/users/likerRr/following{/other_user}","gists_url":"https://api.github.com/users/likerRr/gists{/gist_id}","starred_url":"https://api.github.com/users/likerRr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/likerRr/subscriptions","organizations_url":"https://api.github.com/users/likerRr/orgs","repos_url":"https://api.github.com/users/likerRr/repos","events_url":"https://api.github.com/users/likerRr/events{/privacy}","received_events_url":"https://api.github.com/users/likerRr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/likerRr/node-pogo-protos","description":"Pokémon Go Protobuf files from POGOProtos, wrapped up in a Node module using protobuf.js","fork":true,"url":"https://api.github.com/repos/likerRr/node-pogo-protos","forks_url":"https://api.github.com/repos/likerRr/node-pogo-protos/forks","keys_url":"https://api.github.com/repos/likerRr/node-pogo-protos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/likerRr/node-pogo-protos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/likerRr/node-pogo-protos/teams","hooks_url":"https://api.github.com/repos/likerRr/node-pogo-protos/hooks","issue_events_url":"https://api.github.com/repos/likerRr/node-pogo-protos/issues/events{/number}","events_url":"https://api.github.com/repos/likerRr/node-pogo-protos/events","assignees_url":"https://api.github.com/repos/likerRr/node-pogo-protos/assignees{/user}","branches_url":"https://api.github.com/repos/likerRr/node-pogo-protos/branches{/branch}","tags_url":"https://api.github.com/repos/likerRr/node-pogo-protos/tags","blobs_url":"https://api.github.com/repos/likerRr/node-pogo-protos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/likerRr/node-pogo-protos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/likerRr/node-pogo-protos/git/refs{/sha}","trees_url":"https://api.github.com/repos/likerRr/node-pogo-protos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/likerRr/node-pogo-protos/statuses/{sha}","languages_url":"https://api.github.com/repos/likerRr/node-pogo-protos/languages","stargazers_url":"https://api.github.com/repos/likerRr/node-pogo-protos/stargazers","contributors_url":"https://api.github.com/repos/likerRr/node-pogo-protos/contributors","subscribers_url":"https://api.github.com/repos/likerRr/node-pogo-protos/subscribers","subscription_url":"https://api.github.com/repos/likerRr/node-pogo-protos/subscription","commits_url":"https://api.github.com/repos/likerRr/node-pogo-protos/commits{/sha}","git_commits_url":"https://api.github.com/repos/likerRr/node-pogo-protos/git/commits{/sha}","comments_url":"https://api.github.com/repos/likerRr/node-pogo-protos/comments{/number}","issue_comment_url":"https://api.github.com/repos/likerRr/node-pogo-protos/issues/comments{/number}","contents_url":"https://api.github.com/repos/likerRr/node-pogo-protos/contents/{+path}","compare_url":"https://api.github.com/repos/likerRr/node-pogo-protos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/likerRr/node-pogo-protos/merges","archive_url":"https://api.github.com/repos/likerRr/node-pogo-protos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/likerRr/node-pogo-protos/downloads","issues_url":"https://api.github.com/repos/likerRr/node-pogo-protos/issues{/number}","pulls_url":"https://api.github.com/repos/likerRr/node-pogo-protos/pulls{/number}","milestones_url":"https://api.github.com/repos/likerRr/node-pogo-protos/milestones{/number}","notifications_url":"https://api.github.com/repos/likerRr/node-pogo-protos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/likerRr/node-pogo-protos/labels{/name}","releases_url":"https://api.github.com/repos/likerRr/node-pogo-protos/releases{/id}","deployments_url":"https://api.github.com/repos/likerRr/node-pogo-protos/deployments","created_at":"2016-08-04T11:01:05Z","updated_at":"2016-08-04T11:01:06Z","pushed_at":"2016-08-25T14:27:50Z","git_url":"git://github.com/likerRr/node-pogo-protos.git","ssh_url":"git@github.com:likerRr/node-pogo-protos.git","clone_url":"https://github.com/likerRr/node-pogo-protos.git","svn_url":"https://github.com/likerRr/node-pogo-protos","homepage":null,"size":165,"stargazers_count":0,"watchers_count":0,"language":"Protocol Buffer","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cyraxx:master","ref":"master","sha":"5ea53fdc952a497301eb1f008e7f06cc883f3c40","user":{"login":"cyraxx","id":337029,"avatar_url":"https://avatars.githubusercontent.com/u/337029?v=3","gravatar_id":"","url":"https://api.github.com/users/cyraxx","html_url":"https://github.com/cyraxx","followers_url":"https://api.github.com/users/cyraxx/followers","following_url":"https://api.github.com/users/cyraxx/following{/other_user}","gists_url":"https://api.github.com/users/cyraxx/gists{/gist_id}","starred_url":"https://api.github.com/users/cyraxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyraxx/subscriptions","organizations_url":"https://api.github.com/users/cyraxx/orgs","repos_url":"https://api.github.com/users/cyraxx/repos","events_url":"https://api.github.com/users/cyraxx/events{/privacy}","received_events_url":"https://api.github.com/users/cyraxx/received_events","type":"User","site_admin":false},"repo":{"id":64037821,"name":"node-pogo-protos","full_name":"cyraxx/node-pogo-protos","owner":{"login":"cyraxx","id":337029,"avatar_url":"https://avatars.githubusercontent.com/u/337029?v=3","gravatar_id":"","url":"https://api.github.com/users/cyraxx","html_url":"https://github.com/cyraxx","followers_url":"https://api.github.com/users/cyraxx/followers","following_url":"https://api.github.com/users/cyraxx/following{/other_user}","gists_url":"https://api.github.com/users/cyraxx/gists{/gist_id}","starred_url":"https://api.github.com/users/cyraxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyraxx/subscriptions","organizations_url":"https://api.github.com/users/cyraxx/orgs","repos_url":"https://api.github.com/users/cyraxx/repos","events_url":"https://api.github.com/users/cyraxx/events{/privacy}","received_events_url":"https://api.github.com/users/cyraxx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cyraxx/node-pogo-protos","description":"Pokémon Go Protobuf files from POGOProtos, wrapped up in a Node module using protobuf.js","fork":false,"url":"https://api.github.com/repos/cyraxx/node-pogo-protos","forks_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/forks","keys_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/teams","hooks_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/hooks","issue_events_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/issues/events{/number}","events_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/events","assignees_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/assignees{/user}","branches_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/branches{/branch}","tags_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/tags","blobs_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/statuses/{sha}","languages_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/languages","stargazers_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/stargazers","contributors_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/contributors","subscribers_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/subscribers","subscription_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/subscription","commits_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/contents/{+path}","compare_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/merges","archive_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/downloads","issues_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/issues{/number}","pulls_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/pulls{/number}","milestones_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/milestones{/number}","notifications_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/labels{/name}","releases_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/releases{/id}","deployments_url":"https://api.github.com/repos/cyraxx/node-pogo-protos/deployments","created_at":"2016-07-23T22:03:19Z","updated_at":"2016-08-27T21:12:23Z","pushed_at":"2016-08-30T08:26:07Z","git_url":"git://github.com/cyraxx/node-pogo-protos.git","ssh_url":"git@github.com:cyraxx/node-pogo-protos.git","clone_url":"https://github.com/cyraxx/node-pogo-protos.git","svn_url":"https://github.com/cyraxx/node-pogo-protos","homepage":null,"size":93,"stargazers_count":25,"watchers_count":25,"language":"Protocol Buffer","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":0,"forks":8,"open_issues":0,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cyraxx/node-pogo-protos/pulls/4"},"html":{"href":"https://github.com/cyraxx/node-pogo-protos/pull/4"},"issue":{"href":"https://api.github.com/repos/cyraxx/node-pogo-protos/issues/4"},"comments":{"href":"https://api.github.com/repos/cyraxx/node-pogo-protos/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/cyraxx/node-pogo-protos/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/cyraxx/node-pogo-protos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cyraxx/node-pogo-protos/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/cyraxx/node-pogo-protos/statuses/9d570ce00e7d18f65e9df4cef17b0fe410230200"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"cyraxx","id":337029,"avatar_url":"https://avatars.githubusercontent.com/u/337029?v=3","gravatar_id":"","url":"https://api.github.com/users/cyraxx","html_url":"https://github.com/cyraxx","followers_url":"https://api.github.com/users/cyraxx/followers","following_url":"https://api.github.com/users/cyraxx/following{/other_user}","gists_url":"https://api.github.com/users/cyraxx/gists{/gist_id}","starred_url":"https://api.github.com/users/cyraxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyraxx/subscriptions","organizations_url":"https://api.github.com/users/cyraxx/orgs","repos_url":"https://api.github.com/users/cyraxx/repos","events_url":"https://api.github.com/users/cyraxx/events{/privacy}","received_events_url":"https://api.github.com/users/cyraxx/received_events","type":"User","site_admin":false},"comments":17,"review_comments":0,"commits":4,"additions":5858,"deletions":3958,"changed_files":5}}
{"actor":{"display_login":"cyraxx"}}