{"action":"created","issue":{"url":"https://api.github.com/repos/codice/ddf/issues/936","repository_url":"https://api.github.com/repos/codice/ddf","labels_url":"https://api.github.com/repos/codice/ddf/issues/936/labels{/name}","comments_url":"https://api.github.com/repos/codice/ddf/issues/936/comments","events_url":"https://api.github.com/repos/codice/ddf/issues/936/events","html_url":"https://github.com/codice/ddf/pull/936","id":162744335,"number":936,"title":"DDF-2250 Make SaxEventToXmlConverter handle edge cases","user":{"login":"harrison-tarr","id":14062223,"avatar_url":"https://avatars.githubusercontent.com/u/14062223?v=3","gravatar_id":"","url":"https://api.github.com/users/harrison-tarr","html_url":"https://github.com/harrison-tarr","followers_url":"https://api.github.com/users/harrison-tarr/followers","following_url":"https://api.github.com/users/harrison-tarr/following{/other_user}","gists_url":"https://api.github.com/users/harrison-tarr/gists{/gist_id}","starred_url":"https://api.github.com/users/harrison-tarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harrison-tarr/subscriptions","organizations_url":"https://api.github.com/users/harrison-tarr/orgs","repos_url":"https://api.github.com/users/harrison-tarr/repos","events_url":"https://api.github.com/users/harrison-tarr/events{/privacy}","received_events_url":"https://api.github.com/users/harrison-tarr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-06-28T17:42:40Z","updated_at":"2016-06-30T20:44:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/936","html_url":"https://github.com/codice/ddf/pull/936","diff_url":"https://github.com/codice/ddf/pull/936.diff","patch_url":"https://github.com/codice/ddf/pull/936.patch"},"body":"#### What does this PR do?\r\nSaxEventToXmlConverter can handle nested prefix redeclarations\r\n#### Who is reviewing it (please choose AT LEAST two reviewers that need to approve the PR before it can get merged; if a component team is listed, at least one of its members needs to approve)?\r\n@AzGoalie @brendan-hofmann \r\n#### Choose 2 committers to review/merge the PR (please choose ONLY two committers from below, delete the rest).\r\n@kcwire\r\n@shaundmorris\r\n#### How should this be tested?\r\nThe unit tests should be sufficient\r\n#### Any background context you want to provide?\r\n#### What are the relevant tickets?\r\nDDF-2250\r\n#### Screenshots (if appropriate)\r\n#### Checklist:\r\n- [ ] Documentation Updated\r\n- [x] Update / Add Unit Tests\r\n- [ ] Update / Add Integration Tests\r\n\r\nspecifically nested redeclaration of a namespace prefix"},"comment":{"url":"https://api.github.com/repos/codice/ddf/issues/comments/229783166","html_url":"https://github.com/codice/ddf/pull/936#issuecomment-229783166","issue_url":"https://api.github.com/repos/codice/ddf/issues/936","id":229783166,"user":{"login":"coyotesqrl","id":1469860,"avatar_url":"https://avatars.githubusercontent.com/u/1469860?v=3","gravatar_id":"","url":"https://api.github.com/users/coyotesqrl","html_url":"https://github.com/coyotesqrl","followers_url":"https://api.github.com/users/coyotesqrl/followers","following_url":"https://api.github.com/users/coyotesqrl/following{/other_user}","gists_url":"https://api.github.com/users/coyotesqrl/gists{/gist_id}","starred_url":"https://api.github.com/users/coyotesqrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coyotesqrl/subscriptions","organizations_url":"https://api.github.com/users/coyotesqrl/orgs","repos_url":"https://api.github.com/users/coyotesqrl/repos","events_url":"https://api.github.com/users/coyotesqrl/events{/privacy}","received_events_url":"https://api.github.com/users/coyotesqrl/received_events","type":"User","site_admin":false},"created_at":"2016-06-30T20:44:07Z","updated_at":"2016-06-30T20:44:07Z","body":"I'm pretty rusty with the odder corners of xml, but as I recall, namespace prefixes are scoped. This (while not quite valid xml) is effectively legal if I remember correctly:\r\n```xml\r\n<?xml version=\"1.0\" encoding=\"UTF-8\" ?>\r\n<outer xmlns:aaa=\"whocares\">\r\n    <aaa:foo name=\"outside\">\r\n        <aaa:bar xmlns:bbb=\"inside1\">\r\n            <bbb:baz xmlns:aaa=\"inside2\">\r\n                <aaa:verybad name=\"scope matters\"/>\r\n            </bbb:baz>\r\n        </aaa:bar>\r\n    </aaa:foo>\r\n</outer>\r\n```\r\nThis means the prefix `aaa` defined in the outer block and the prefix `aaa` in the inner block really do refer to two different uris. Your logic doesn't appear to take this into account.\r\n\r\nIt is another edge case and I would understand opening a new ticket for it and not holding this work back as it is incredibly unlikely someone would reuse the same prefix in a scoped context like this; however, it should be investigated, verified, and the code updated to handle (assuming my recollection isn't faulty)."}}
{"actor":{"display_login":"coyotesqrl"}}