{"action":"created","comment":{"url":"https://api.github.com/repos/IQSS/dataverse/pulls/comments/81370941","pull_request_review_id":2357108,"id":81370941,"diff_hunk":"@@ -236,7 +236,8 @@ public boolean isUniqueIdentifier(String userIdentifier, String protocol, String\n         boolean u = em.createQuery(query).getResultList().size() == 0;\n         String nonNullDefaultIfKeyNotFound = \"\";\n         String doiProvider = settingsService.getValueForKey(SettingsServiceBean.Key.DoiProvider, nonNullDefaultIfKeyNotFound);\n-        if (doiProvider.equals(\"EZID\")) {\n+        if (protocol.equals(\"doi\") && doiProvider.equals(\"EZID\")) {","path":"src/main/java/edu/harvard/iq/dataverse/DatasetServiceBean.java","position":5,"original_position":5,"commit_id":"354e6247ea4f4e086c71263b7039b42d9e62d687","original_commit_id":"354e6247ea4f4e086c71263b7039b42d9e62d687","user":{"login":"raprasad","id":1036060,"avatar_url":"https://avatars.githubusercontent.com/u/1036060?v=3","gravatar_id":"","url":"https://api.github.com/users/raprasad","html_url":"https://github.com/raprasad","followers_url":"https://api.github.com/users/raprasad/followers","following_url":"https://api.github.com/users/raprasad/following{/other_user}","gists_url":"https://api.github.com/users/raprasad/gists{/gist_id}","starred_url":"https://api.github.com/users/raprasad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raprasad/subscriptions","organizations_url":"https://api.github.com/users/raprasad/orgs","repos_url":"https://api.github.com/users/raprasad/repos","events_url":"https://api.github.com/users/raprasad/events{/privacy}","received_events_url":"https://api.github.com/users/raprasad/received_events","type":"User","site_admin":false},"body":"\r\n- [ ] Please make the strings \"doi\" and \"EZID\" into re-usable static variables.\r\n\r\n","created_at":"2016-09-30T16:21:04Z","updated_at":"2016-09-30T16:44:04Z","html_url":"https://github.com/IQSS/dataverse/pull/3146#discussion_r81370941","pull_request_url":"https://api.github.com/repos/IQSS/dataverse/pulls/3146","_links":{"self":{"href":"https://api.github.com/repos/IQSS/dataverse/pulls/comments/81370941"},"html":{"href":"https://github.com/IQSS/dataverse/pull/3146#discussion_r81370941"},"pull_request":{"href":"https://api.github.com/repos/IQSS/dataverse/pulls/3146"}}},"pull_request":{"url":"https://api.github.com/repos/IQSS/dataverse/pulls/3146","id":71973236,"html_url":"https://github.com/IQSS/dataverse/pull/3146","diff_url":"https://github.com/IQSS/dataverse/pull/3146.diff","patch_url":"https://github.com/IQSS/dataverse/pull/3146.patch","issue_url":"https://api.github.com/repos/IQSS/dataverse/issues/3146","number":3146,"state":"open","locked":false,"title":"Minting Handles For Datasets","user":{"login":"jo-pol","id":10553630,"avatar_url":"https://avatars.githubusercontent.com/u/10553630?v=3","gravatar_id":"","url":"https://api.github.com/users/jo-pol","html_url":"https://github.com/jo-pol","followers_url":"https://api.github.com/users/jo-pol/followers","following_url":"https://api.github.com/users/jo-pol/following{/other_user}","gists_url":"https://api.github.com/users/jo-pol/gists{/gist_id}","starred_url":"https://api.github.com/users/jo-pol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jo-pol/subscriptions","organizations_url":"https://api.github.com/users/jo-pol/orgs","repos_url":"https://api.github.com/users/jo-pol/repos","events_url":"https://api.github.com/users/jo-pol/events{/privacy}","received_events_url":"https://api.github.com/users/jo-pol/received_events","type":"User","site_admin":false},"body":"Implementation of Minting Handles For Datasets, see [BRD] \n\nSome refactoring makes the dataset commands classes agnostic which IdServiceBean is configured: DOIEZIDServiceBean, DOIDataciteServiceBean or HandlenetServiceBean. When an id is registered is hard coded per bean: upon creation for EZID, upon publishing for DataCite and Handlenet.\n\n---\n### 1. Related Issues\n\n- #2437 Handles: Restore handle registration functionality in 4.x\n- the ServiceBeans implementing an interface/abstract-class meets the [Registration API] halfway\n- see also the [initial discussion]\n\n[Registration API]: https://docs.google.com/document/d/1KW_zticHqudDjeVD7UjFq9OlnY5eJAqpGL87tVegwSc/edit\n[initial discussion]: https://groups.google.com/forum/#!msg/dataverse-community/xM6vmat0LFI/Aq-WcWDeBAAJ\n[BRD]: https://docs.google.com/document/d/1-S0G1wLuxF_eomdLSiFDNU8LWi0XmiJnzU6nfXfY5wE/edit?pref=2&pli=1\n\n---\n### 2. Pull Request Checklist\n\n- [ ]  Functionality completed as described in FRD\n- [ ]  Dependencies, risks, assumptions in FRD addressed\n- [ ]  Unit tests completed\n- [ ]  Deployment requirements identified (e.g., SQL scripts, indexing)\n- [ ]  Documentation completed\n- [ ]  All code checkins completed\n\n---\n### 3. Review Checklist\n\n_**After** the pull request has been submitted, fill out this section._\n\n- [ ]  Code review completed or waived\n- [ ]  Testing requirements completed\n- [ ]  Usability testing completed or waived\n- [ ]  Support testing completed or waived\n- [ ]  Merged with develop branch and resolved conflicts\n\n… warnings\n\nConnects to #2437.","created_at":"2016-05-31T08:03:11Z","updated_at":"2016-09-30T16:44:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d95ad4fe2dfa03753f0af7a7b264bd29203b791","assignee":{"login":"sekmiller","id":2364928,"avatar_url":"https://avatars.githubusercontent.com/u/2364928?v=3","gravatar_id":"","url":"https://api.github.com/users/sekmiller","html_url":"https://github.com/sekmiller","followers_url":"https://api.github.com/users/sekmiller/followers","following_url":"https://api.github.com/users/sekmiller/following{/other_user}","gists_url":"https://api.github.com/users/sekmiller/gists{/gist_id}","starred_url":"https://api.github.com/users/sekmiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sekmiller/subscriptions","organizations_url":"https://api.github.com/users/sekmiller/orgs","repos_url":"https://api.github.com/users/sekmiller/repos","events_url":"https://api.github.com/users/sekmiller/events{/privacy}","received_events_url":"https://api.github.com/users/sekmiller/received_events","type":"User","site_admin":false},"assignees":[{"login":"sekmiller","id":2364928,"avatar_url":"https://avatars.githubusercontent.com/u/2364928?v=3","gravatar_id":"","url":"https://api.github.com/users/sekmiller","html_url":"https://github.com/sekmiller","followers_url":"https://api.github.com/users/sekmiller/followers","following_url":"https://api.github.com/users/sekmiller/following{/other_user}","gists_url":"https://api.github.com/users/sekmiller/gists{/gist_id}","starred_url":"https://api.github.com/users/sekmiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sekmiller/subscriptions","organizations_url":"https://api.github.com/users/sekmiller/orgs","repos_url":"https://api.github.com/users/sekmiller/repos","events_url":"https://api.github.com/users/sekmiller/events{/privacy}","received_events_url":"https://api.github.com/users/sekmiller/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/IQSS/dataverse/pulls/3146/commits","review_comments_url":"https://api.github.com/repos/IQSS/dataverse/pulls/3146/comments","review_comment_url":"https://api.github.com/repos/IQSS/dataverse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IQSS/dataverse/issues/3146/comments","statuses_url":"https://api.github.com/repos/IQSS/dataverse/statuses/354e6247ea4f4e086c71263b7039b42d9e62d687","head":{"label":"DANS-KNAW-jp:DDN-184-DOI-interface","ref":"DDN-184-DOI-interface","sha":"354e6247ea4f4e086c71263b7039b42d9e62d687","user":{"login":"DANS-KNAW-jp","id":21305289,"avatar_url":"https://avatars.githubusercontent.com/u/21305289?v=3","gravatar_id":"","url":"https://api.github.com/users/DANS-KNAW-jp","html_url":"https://github.com/DANS-KNAW-jp","followers_url":"https://api.github.com/users/DANS-KNAW-jp/followers","following_url":"https://api.github.com/users/DANS-KNAW-jp/following{/other_user}","gists_url":"https://api.github.com/users/DANS-KNAW-jp/gists{/gist_id}","starred_url":"https://api.github.com/users/DANS-KNAW-jp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DANS-KNAW-jp/subscriptions","organizations_url":"https://api.github.com/users/DANS-KNAW-jp/orgs","repos_url":"https://api.github.com/users/DANS-KNAW-jp/repos","events_url":"https://api.github.com/users/DANS-KNAW-jp/events{/privacy}","received_events_url":"https://api.github.com/users/DANS-KNAW-jp/received_events","type":"Organization","site_admin":false},"repo":{"id":56050867,"name":"dataverse","full_name":"DANS-KNAW-jp/dataverse","owner":{"login":"DANS-KNAW-jp","id":21305289,"avatar_url":"https://avatars.githubusercontent.com/u/21305289?v=3","gravatar_id":"","url":"https://api.github.com/users/DANS-KNAW-jp","html_url":"https://github.com/DANS-KNAW-jp","followers_url":"https://api.github.com/users/DANS-KNAW-jp/followers","following_url":"https://api.github.com/users/DANS-KNAW-jp/following{/other_user}","gists_url":"https://api.github.com/users/DANS-KNAW-jp/gists{/gist_id}","starred_url":"https://api.github.com/users/DANS-KNAW-jp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DANS-KNAW-jp/subscriptions","organizations_url":"https://api.github.com/users/DANS-KNAW-jp/orgs","repos_url":"https://api.github.com/users/DANS-KNAW-jp/repos","events_url":"https://api.github.com/users/DANS-KNAW-jp/events{/privacy}","received_events_url":"https://api.github.com/users/DANS-KNAW-jp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DANS-KNAW-jp/dataverse","description":"A data repository framework to share and publish research data.","fork":true,"url":"https://api.github.com/repos/DANS-KNAW-jp/dataverse","forks_url":"https://api.github.com/repos/DANS-KNAW-jp/dataverse/forks","keys_url":"https://api.github.com/repos/DANS-KNAW-jp/dataverse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DANS-KNAW-jp/dataverse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DANS-KNAW-jp/dataverse/teams","hooks_url":"https://api.github.com/repos/DANS-KNAW-jp/dataverse/hooks","issue_events_url":"https://api.github.com/repos/DANS-KNAW-jp/dataverse/issues/events{/number}","events_url":"https://api.github.com/repos/DANS-KNAW-jp/dataverse/events","assignees_url":"https://api.github.com/repos/DANS-KNAW-jp/dataverse/assignees{/user}","branches_url":"https://api.github.com/repos/DANS-KNAW-jp/dataverse/branches{/branch}","tags_url":"https://api.github.com/repos/DANS-KNAW-jp/dataverse/tags","blobs_url":"https://api.github.com/repos/DANS-KNAW-jp/dataverse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DANS-KNAW-jp/dataverse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DANS-KNAW-jp/dataverse/git/refs{/sha}","trees_url":"https://api.github.com/repos/DANS-KNAW-jp/dataverse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DANS-KNAW-jp/dataverse/statuses/{sha}","languages_url":"https://api.github.com/repos/DANS-KNAW-jp/dataverse/languages","stargazers_url":"https://api.github.com/repos/DANS-KNAW-jp/dataverse/stargazers","contributors_url":"https://api.github.com/repos/DANS-KNAW-jp/dataverse/contributors","subscribers_url":"https://api.github.com/repos/DANS-KNAW-jp/dataverse/subscribers","subscription_url":"https://api.github.com/repos/DANS-KNAW-jp/dataverse/subscription","commits_url":"https://api.github.com/repos/DANS-KNAW-jp/dataverse/commits{/sha}","git_commits_url":"https://api.github.com/repos/DANS-KNAW-jp/dataverse/git/commits{/sha}","comments_url":"https://api.github.com/repos/DANS-KNAW-jp/dataverse/comments{/number}","issue_comment_url":"https://api.github.com/repos/DANS-KNAW-jp/dataverse/issues/comments{/number}","contents_url":"https://api.github.com/repos/DANS-KNAW-jp/dataverse/contents/{+path}","compare_url":"https://api.github.com/repos/DANS-KNAW-jp/dataverse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DANS-KNAW-jp/dataverse/merges","archive_url":"https://api.github.com/repos/DANS-KNAW-jp/dataverse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DANS-KNAW-jp/dataverse/downloads","issues_url":"https://api.github.com/repos/DANS-KNAW-jp/dataverse/issues{/number}","pulls_url":"https://api.github.com/repos/DANS-KNAW-jp/dataverse/pulls{/number}","milestones_url":"https://api.github.com/repos/DANS-KNAW-jp/dataverse/milestones{/number}","notifications_url":"https://api.github.com/repos/DANS-KNAW-jp/dataverse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DANS-KNAW-jp/dataverse/labels{/name}","releases_url":"https://api.github.com/repos/DANS-KNAW-jp/dataverse/releases{/id}","deployments_url":"https://api.github.com/repos/DANS-KNAW-jp/dataverse/deployments","created_at":"2016-04-12T09:46:25Z","updated_at":"2016-08-29T08:58:35Z","pushed_at":"2016-09-27T06:23:34Z","git_url":"git://github.com/DANS-KNAW-jp/dataverse.git","ssh_url":"git@github.com:DANS-KNAW-jp/dataverse.git","clone_url":"https://github.com/DANS-KNAW-jp/dataverse.git","svn_url":"https://github.com/DANS-KNAW-jp/dataverse","homepage":"http://dataverse.org","size":31282,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dans-master"}},"base":{"label":"IQSS:develop","ref":"develop","sha":"3a753cacb52eef009ae96fd89cf5ee1d193a8a9c","user":{"login":"IQSS","id":675237,"avatar_url":"https://avatars.githubusercontent.com/u/675237?v=3","gravatar_id":"","url":"https://api.github.com/users/IQSS","html_url":"https://github.com/IQSS","followers_url":"https://api.github.com/users/IQSS/followers","following_url":"https://api.github.com/users/IQSS/following{/other_user}","gists_url":"https://api.github.com/users/IQSS/gists{/gist_id}","starred_url":"https://api.github.com/users/IQSS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IQSS/subscriptions","organizations_url":"https://api.github.com/users/IQSS/orgs","repos_url":"https://api.github.com/users/IQSS/repos","events_url":"https://api.github.com/users/IQSS/events{/privacy}","received_events_url":"https://api.github.com/users/IQSS/received_events","type":"Organization","site_admin":false},"repo":{"id":14051004,"name":"dataverse","full_name":"IQSS/dataverse","owner":{"login":"IQSS","id":675237,"avatar_url":"https://avatars.githubusercontent.com/u/675237?v=3","gravatar_id":"","url":"https://api.github.com/users/IQSS","html_url":"https://github.com/IQSS","followers_url":"https://api.github.com/users/IQSS/followers","following_url":"https://api.github.com/users/IQSS/following{/other_user}","gists_url":"https://api.github.com/users/IQSS/gists{/gist_id}","starred_url":"https://api.github.com/users/IQSS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IQSS/subscriptions","organizations_url":"https://api.github.com/users/IQSS/orgs","repos_url":"https://api.github.com/users/IQSS/repos","events_url":"https://api.github.com/users/IQSS/events{/privacy}","received_events_url":"https://api.github.com/users/IQSS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IQSS/dataverse","description":"A data repository framework to share and publish research data.","fork":false,"url":"https://api.github.com/repos/IQSS/dataverse","forks_url":"https://api.github.com/repos/IQSS/dataverse/forks","keys_url":"https://api.github.com/repos/IQSS/dataverse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IQSS/dataverse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IQSS/dataverse/teams","hooks_url":"https://api.github.com/repos/IQSS/dataverse/hooks","issue_events_url":"https://api.github.com/repos/IQSS/dataverse/issues/events{/number}","events_url":"https://api.github.com/repos/IQSS/dataverse/events","assignees_url":"https://api.github.com/repos/IQSS/dataverse/assignees{/user}","branches_url":"https://api.github.com/repos/IQSS/dataverse/branches{/branch}","tags_url":"https://api.github.com/repos/IQSS/dataverse/tags","blobs_url":"https://api.github.com/repos/IQSS/dataverse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IQSS/dataverse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IQSS/dataverse/git/refs{/sha}","trees_url":"https://api.github.com/repos/IQSS/dataverse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IQSS/dataverse/statuses/{sha}","languages_url":"https://api.github.com/repos/IQSS/dataverse/languages","stargazers_url":"https://api.github.com/repos/IQSS/dataverse/stargazers","contributors_url":"https://api.github.com/repos/IQSS/dataverse/contributors","subscribers_url":"https://api.github.com/repos/IQSS/dataverse/subscribers","subscription_url":"https://api.github.com/repos/IQSS/dataverse/subscription","commits_url":"https://api.github.com/repos/IQSS/dataverse/commits{/sha}","git_commits_url":"https://api.github.com/repos/IQSS/dataverse/git/commits{/sha}","comments_url":"https://api.github.com/repos/IQSS/dataverse/comments{/number}","issue_comment_url":"https://api.github.com/repos/IQSS/dataverse/issues/comments{/number}","contents_url":"https://api.github.com/repos/IQSS/dataverse/contents/{+path}","compare_url":"https://api.github.com/repos/IQSS/dataverse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IQSS/dataverse/merges","archive_url":"https://api.github.com/repos/IQSS/dataverse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IQSS/dataverse/downloads","issues_url":"https://api.github.com/repos/IQSS/dataverse/issues{/number}","pulls_url":"https://api.github.com/repos/IQSS/dataverse/pulls{/number}","milestones_url":"https://api.github.com/repos/IQSS/dataverse/milestones{/number}","notifications_url":"https://api.github.com/repos/IQSS/dataverse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IQSS/dataverse/labels{/name}","releases_url":"https://api.github.com/repos/IQSS/dataverse/releases{/id}","deployments_url":"https://api.github.com/repos/IQSS/dataverse/deployments","created_at":"2013-11-01T18:47:39Z","updated_at":"2016-09-29T19:28:50Z","pushed_at":"2016-09-30T13:49:14Z","git_url":"git://github.com/IQSS/dataverse.git","ssh_url":"git@github.com:IQSS/dataverse.git","clone_url":"https://github.com/IQSS/dataverse.git","svn_url":"https://github.com/IQSS/dataverse","homepage":"http://dataverse.org","size":64772,"stargazers_count":124,"watchers_count":124,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":77,"mirror_url":null,"open_issues_count":757,"forks":77,"open_issues":757,"watchers":124,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/IQSS/dataverse/pulls/3146"},"html":{"href":"https://github.com/IQSS/dataverse/pull/3146"},"issue":{"href":"https://api.github.com/repos/IQSS/dataverse/issues/3146"},"comments":{"href":"https://api.github.com/repos/IQSS/dataverse/issues/3146/comments"},"review_comments":{"href":"https://api.github.com/repos/IQSS/dataverse/pulls/3146/comments"},"review_comment":{"href":"https://api.github.com/repos/IQSS/dataverse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IQSS/dataverse/pulls/3146/commits"},"statuses":{"href":"https://api.github.com/repos/IQSS/dataverse/statuses/354e6247ea4f4e086c71263b7039b42d9e62d687"}}}}
{"actor":{"display_login":"raprasad"}}