{"action":"created","issue":{"url":"https://api.github.com/repos/facebookincubator/create-react-app/issues/170","repository_url":"https://api.github.com/repos/facebookincubator/create-react-app","labels_url":"https://api.github.com/repos/facebookincubator/create-react-app/issues/170/labels{/name}","comments_url":"https://api.github.com/repos/facebookincubator/create-react-app/issues/170/comments","events_url":"https://api.github.com/repos/facebookincubator/create-react-app/issues/170/events","html_url":"https://github.com/facebookincubator/create-react-app/issues/170","id":167355281,"number":170,"title":"Polyfill","user":{"login":"ForbesLindesay","id":1260646,"avatar_url":"https://avatars.githubusercontent.com/u/1260646?v=3","gravatar_id":"","url":"https://api.github.com/users/ForbesLindesay","html_url":"https://github.com/ForbesLindesay","followers_url":"https://api.github.com/users/ForbesLindesay/followers","following_url":"https://api.github.com/users/ForbesLindesay/following{/other_user}","gists_url":"https://api.github.com/users/ForbesLindesay/gists{/gist_id}","starred_url":"https://api.github.com/users/ForbesLindesay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ForbesLindesay/subscriptions","organizations_url":"https://api.github.com/users/ForbesLindesay/orgs","repos_url":"https://api.github.com/users/ForbesLindesay/repos","events_url":"https://api.github.com/users/ForbesLindesay/events{/privacy}","received_events_url":"https://api.github.com/users/ForbesLindesay/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebookincubator/create-react-app/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/facebookincubator/create-react-app/milestones/2","html_url":"https://github.com/facebookincubator/create-react-app/milestones/0.2.0","labels_url":"https://api.github.com/repos/facebookincubator/create-react-app/milestones/2/labels","id":1902637,"number":2,"title":"0.2.0","description":"","creator":{"login":"gaearon","id":810438,"avatar_url":"https://avatars.githubusercontent.com/u/810438?v=3","gravatar_id":"","url":"https://api.github.com/users/gaearon","html_url":"https://github.com/gaearon","followers_url":"https://api.github.com/users/gaearon/followers","following_url":"https://api.github.com/users/gaearon/following{/other_user}","gists_url":"https://api.github.com/users/gaearon/gists{/gist_id}","starred_url":"https://api.github.com/users/gaearon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaearon/subscriptions","organizations_url":"https://api.github.com/users/gaearon/orgs","repos_url":"https://api.github.com/users/gaearon/repos","events_url":"https://api.github.com/users/gaearon/events{/privacy}","received_events_url":"https://api.github.com/users/gaearon/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":14,"state":"open","created_at":"2016-07-25T14:32:36Z","updated_at":"2016-07-26T14:00:51Z","due_on":null,"closed_at":null},"comments":35,"created_at":"2016-07-25T12:33:51Z","updated_at":"2016-07-26T15:49:20Z","closed_at":null,"body":"Polyfilling via babel doesn't work very well in my experience since you don't normally run babel against node_modules.  For apps (rather than libraries) I think it's generally best to just have global polyfills.\r\n\r\nWith this in mind, we could consider just adding a script to link to https://polyfill.io/v2/docs/ as the default polyfill.  It provides a polyfill based on the user agent string so is a decent future proof default.\r\n\r\nFor non-polyfill babel-runtime components, we should do as @insin suggest in https://github.com/facebookincubator/create-react-app/issues/51#issuecomment-234215045"},"comment":{"url":"https://api.github.com/repos/facebookincubator/create-react-app/issues/comments/235311903","html_url":"https://github.com/facebookincubator/create-react-app/issues/170#issuecomment-235311903","issue_url":"https://api.github.com/repos/facebookincubator/create-react-app/issues/170","id":235311903,"user":{"login":"ForbesLindesay","id":1260646,"avatar_url":"https://avatars.githubusercontent.com/u/1260646?v=3","gravatar_id":"","url":"https://api.github.com/users/ForbesLindesay","html_url":"https://github.com/ForbesLindesay","followers_url":"https://api.github.com/users/ForbesLindesay/followers","following_url":"https://api.github.com/users/ForbesLindesay/following{/other_user}","gists_url":"https://api.github.com/users/ForbesLindesay/gists{/gist_id}","starred_url":"https://api.github.com/users/ForbesLindesay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ForbesLindesay/subscriptions","organizations_url":"https://api.github.com/users/ForbesLindesay/orgs","repos_url":"https://api.github.com/users/ForbesLindesay/repos","events_url":"https://api.github.com/users/ForbesLindesay/events{/privacy}","received_events_url":"https://api.github.com/users/ForbesLindesay/received_events","type":"User","site_admin":false},"created_at":"2016-07-26T15:49:20Z","updated_at":"2016-07-26T15:49:20Z","body":"The issue with babel-runtime is that it doesn't polyfill things that are used by dependencies in node_modules.  Increasingly (with the popularity of node v4/v5/v6 starting to overtake 0.10) people will start shipping modules to npm that depend on things like `Map` and `Set` being implemented.  It doesn't make sense for all of those modules to ship with separate polyfills for Map and Set.  Polyfills just don't work properly if they're not global.\r\n\r\nI'm keen for us to implement @gaearon's solution in the short term.  In the longer term, we can make something clever enough to load only the required dependencies, but do so globally for all modules."}}
{"actor":{"display_login":"ForbesLindesay"}}