{"action":"created","comment":{"url":"https://api.github.com/repos/uber/tchannel-go/pulls/comments/49245210","id":49245210,"diff_hunk":"@@ -370,7 +370,10 @@ func (ch *Channel) serve() {\n \t\t\t\tif max := 1 * time.Second; acceptBackoff > max {\n \t\t\t\t\tacceptBackoff = max\n \t\t\t\t}\n-\t\t\t\tch.log.Warnf(\"accept error: %v; retrying in %v\", err, acceptBackoff)\n+\t\t\t\tch.log.WithFields(\n+\t\t\t\t\tLogField{\"error\", err.Error()},\n+\t\t\t\t\tLogField{\"backoff\", acceptBackoff},\n+\t\t\t\t).Warn(\"Accept error, will wait and retry.\")","path":"channel.go","position":8,"original_position":8,"commit_id":"a6b9911b16495040d478e183652ecba9f3614d85","original_commit_id":"a6b9911b16495040d478e183652ecba9f3614d85","user":{"login":"akshayjshah","id":972790,"avatar_url":"https://avatars.githubusercontent.com/u/972790?v=3","gravatar_id":"","url":"https://api.github.com/users/akshayjshah","html_url":"https://github.com/akshayjshah","followers_url":"https://api.github.com/users/akshayjshah/followers","following_url":"https://api.github.com/users/akshayjshah/following{/other_user}","gists_url":"https://api.github.com/users/akshayjshah/gists{/gist_id}","starred_url":"https://api.github.com/users/akshayjshah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akshayjshah/subscriptions","organizations_url":"https://api.github.com/users/akshayjshah/orgs","repos_url":"https://api.github.com/users/akshayjshah/repos","events_url":"https://api.github.com/users/akshayjshah/events{/privacy}","received_events_url":"https://api.github.com/users/akshayjshah/received_events","type":"User","site_admin":false},"body":"Was intentional on my part - I think of logs as letters to future me. All Warn, Error, and Fatal logs in tchannel-go should now have terminal punctuation.\r\n\r\nI haven't noticed a strong convention in go-common re: initial capitals and sentence-style punctuation - does Google recommend a particular logging style? I'm happy to change if necessary.","created_at":"2016-01-08T22:17:12Z","updated_at":"2016-01-08T22:17:12Z","html_url":"https://github.com/uber/tchannel-go/pull/167#discussion_r49245210","pull_request_url":"https://api.github.com/repos/uber/tchannel-go/pulls/167","_links":{"self":{"href":"https://api.github.com/repos/uber/tchannel-go/pulls/comments/49245210"},"html":{"href":"https://github.com/uber/tchannel-go/pull/167#discussion_r49245210"},"pull_request":{"href":"https://api.github.com/repos/uber/tchannel-go/pulls/167"}}},"pull_request":{"url":"https://api.github.com/repos/uber/tchannel-go/pulls/167","id":55503294,"html_url":"https://github.com/uber/tchannel-go/pull/167","diff_url":"https://github.com/uber/tchannel-go/pull/167.diff","patch_url":"https://github.com/uber/tchannel-go/pull/167.patch","issue_url":"https://api.github.com/repos/uber/tchannel-go/issues/167","number":167,"state":"open","locked":false,"title":"Remove high-priority string-munging logger methods","user":{"login":"akshayjshah","id":972790,"avatar_url":"https://avatars.githubusercontent.com/u/972790?v=3","gravatar_id":"","url":"https://api.github.com/users/akshayjshah","html_url":"https://github.com/akshayjshah","followers_url":"https://api.github.com/users/akshayjshah/followers","following_url":"https://api.github.com/users/akshayjshah/following{/other_user}","gists_url":"https://api.github.com/users/akshayjshah/gists{/gist_id}","starred_url":"https://api.github.com/users/akshayjshah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akshayjshah/subscriptions","organizations_url":"https://api.github.com/users/akshayjshah/orgs","repos_url":"https://api.github.com/users/akshayjshah/repos","events_url":"https://api.github.com/users/akshayjshah/events{/privacy}","received_events_url":"https://api.github.com/users/akshayjshah/received_events","type":"User","site_admin":false},"body":"Resolves #76.\r\n\r\nMigrates all Sentry-able logging to use fields and a constant message, and then removes `logger.Warnf`, `logger.Errorf`, and `logger.Panicf`.","created_at":"2016-01-08T19:56:12Z","updated_at":"2016-01-08T22:17:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e74cb34b4b8e1597700ceaa8e62759a5766e8158","assignee":{"login":"prashantv","id":140159,"avatar_url":"https://avatars.githubusercontent.com/u/140159?v=3","gravatar_id":"","url":"https://api.github.com/users/prashantv","html_url":"https://github.com/prashantv","followers_url":"https://api.github.com/users/prashantv/followers","following_url":"https://api.github.com/users/prashantv/following{/other_user}","gists_url":"https://api.github.com/users/prashantv/gists{/gist_id}","starred_url":"https://api.github.com/users/prashantv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prashantv/subscriptions","organizations_url":"https://api.github.com/users/prashantv/orgs","repos_url":"https://api.github.com/users/prashantv/repos","events_url":"https://api.github.com/users/prashantv/events{/privacy}","received_events_url":"https://api.github.com/users/prashantv/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/uber/tchannel-go/pulls/167/commits","review_comments_url":"https://api.github.com/repos/uber/tchannel-go/pulls/167/comments","review_comment_url":"https://api.github.com/repos/uber/tchannel-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/tchannel-go/issues/167/comments","statuses_url":"https://api.github.com/repos/uber/tchannel-go/statuses/a6b9911b16495040d478e183652ecba9f3614d85","head":{"label":"uber:ajs-logger","ref":"ajs-logger","sha":"a6b9911b16495040d478e183652ecba9f3614d85","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":42740141,"name":"tchannel-go","full_name":"uber/tchannel-go","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/tchannel-go","description":"","fork":false,"url":"https://api.github.com/repos/uber/tchannel-go","forks_url":"https://api.github.com/repos/uber/tchannel-go/forks","keys_url":"https://api.github.com/repos/uber/tchannel-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/tchannel-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/tchannel-go/teams","hooks_url":"https://api.github.com/repos/uber/tchannel-go/hooks","issue_events_url":"https://api.github.com/repos/uber/tchannel-go/issues/events{/number}","events_url":"https://api.github.com/repos/uber/tchannel-go/events","assignees_url":"https://api.github.com/repos/uber/tchannel-go/assignees{/user}","branches_url":"https://api.github.com/repos/uber/tchannel-go/branches{/branch}","tags_url":"https://api.github.com/repos/uber/tchannel-go/tags","blobs_url":"https://api.github.com/repos/uber/tchannel-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/tchannel-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/tchannel-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/tchannel-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/tchannel-go/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/tchannel-go/languages","stargazers_url":"https://api.github.com/repos/uber/tchannel-go/stargazers","contributors_url":"https://api.github.com/repos/uber/tchannel-go/contributors","subscribers_url":"https://api.github.com/repos/uber/tchannel-go/subscribers","subscription_url":"https://api.github.com/repos/uber/tchannel-go/subscription","commits_url":"https://api.github.com/repos/uber/tchannel-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/tchannel-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/tchannel-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/tchannel-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/tchannel-go/contents/{+path}","compare_url":"https://api.github.com/repos/uber/tchannel-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/tchannel-go/merges","archive_url":"https://api.github.com/repos/uber/tchannel-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/tchannel-go/downloads","issues_url":"https://api.github.com/repos/uber/tchannel-go/issues{/number}","pulls_url":"https://api.github.com/repos/uber/tchannel-go/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/tchannel-go/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/tchannel-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/tchannel-go/labels{/name}","releases_url":"https://api.github.com/repos/uber/tchannel-go/releases{/id}","created_at":"2015-09-18T18:28:15Z","updated_at":"2016-01-01T21:10:38Z","pushed_at":"2016-01-08T19:56:12Z","git_url":"git://github.com/uber/tchannel-go.git","ssh_url":"git@github.com:uber/tchannel-go.git","clone_url":"https://github.com/uber/tchannel-go.git","svn_url":"https://github.com/uber/tchannel-go","homepage":null,"size":1644,"stargazers_count":47,"watchers_count":47,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":19,"forks":8,"open_issues":19,"watchers":47,"default_branch":"master"}},"base":{"label":"uber:master","ref":"master","sha":"b944119b20989db1f28a3ff4227429bbcb74165f","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":42740141,"name":"tchannel-go","full_name":"uber/tchannel-go","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/tchannel-go","description":"","fork":false,"url":"https://api.github.com/repos/uber/tchannel-go","forks_url":"https://api.github.com/repos/uber/tchannel-go/forks","keys_url":"https://api.github.com/repos/uber/tchannel-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/tchannel-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/tchannel-go/teams","hooks_url":"https://api.github.com/repos/uber/tchannel-go/hooks","issue_events_url":"https://api.github.com/repos/uber/tchannel-go/issues/events{/number}","events_url":"https://api.github.com/repos/uber/tchannel-go/events","assignees_url":"https://api.github.com/repos/uber/tchannel-go/assignees{/user}","branches_url":"https://api.github.com/repos/uber/tchannel-go/branches{/branch}","tags_url":"https://api.github.com/repos/uber/tchannel-go/tags","blobs_url":"https://api.github.com/repos/uber/tchannel-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/tchannel-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/tchannel-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/tchannel-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/tchannel-go/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/tchannel-go/languages","stargazers_url":"https://api.github.com/repos/uber/tchannel-go/stargazers","contributors_url":"https://api.github.com/repos/uber/tchannel-go/contributors","subscribers_url":"https://api.github.com/repos/uber/tchannel-go/subscribers","subscription_url":"https://api.github.com/repos/uber/tchannel-go/subscription","commits_url":"https://api.github.com/repos/uber/tchannel-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/tchannel-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/tchannel-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/tchannel-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/tchannel-go/contents/{+path}","compare_url":"https://api.github.com/repos/uber/tchannel-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/tchannel-go/merges","archive_url":"https://api.github.com/repos/uber/tchannel-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/tchannel-go/downloads","issues_url":"https://api.github.com/repos/uber/tchannel-go/issues{/number}","pulls_url":"https://api.github.com/repos/uber/tchannel-go/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/tchannel-go/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/tchannel-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/tchannel-go/labels{/name}","releases_url":"https://api.github.com/repos/uber/tchannel-go/releases{/id}","created_at":"2015-09-18T18:28:15Z","updated_at":"2016-01-01T21:10:38Z","pushed_at":"2016-01-08T19:56:12Z","git_url":"git://github.com/uber/tchannel-go.git","ssh_url":"git@github.com:uber/tchannel-go.git","clone_url":"https://github.com/uber/tchannel-go.git","svn_url":"https://github.com/uber/tchannel-go","homepage":null,"size":1644,"stargazers_count":47,"watchers_count":47,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":19,"forks":8,"open_issues":19,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/tchannel-go/pulls/167"},"html":{"href":"https://github.com/uber/tchannel-go/pull/167"},"issue":{"href":"https://api.github.com/repos/uber/tchannel-go/issues/167"},"comments":{"href":"https://api.github.com/repos/uber/tchannel-go/issues/167/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/tchannel-go/pulls/167/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/tchannel-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/tchannel-go/pulls/167/commits"},"statuses":{"href":"https://api.github.com/repos/uber/tchannel-go/statuses/a6b9911b16495040d478e183652ecba9f3614d85"}}}}