{"action":"created","issue":{"url":"https://api.github.com/repos/bbatsov/rubocop/issues/3149","repository_url":"https://api.github.com/repos/bbatsov/rubocop","labels_url":"https://api.github.com/repos/bbatsov/rubocop/issues/3149/labels{/name}","comments_url":"https://api.github.com/repos/bbatsov/rubocop/issues/3149/comments","events_url":"https://api.github.com/repos/bbatsov/rubocop/issues/3149/events","html_url":"https://github.com/bbatsov/rubocop/pull/3149","id":155818473,"number":3149,"title":"Ignore symbols ending with ?/! in `Style/HashSyntax`","user":{"login":"owst","id":117234,"avatar_url":"https://avatars.githubusercontent.com/u/117234?v=3","gravatar_id":"","url":"https://api.github.com/users/owst","html_url":"https://github.com/owst","followers_url":"https://api.github.com/users/owst/followers","following_url":"https://api.github.com/users/owst/following{/other_user}","gists_url":"https://api.github.com/users/owst/gists{/gist_id}","starred_url":"https://api.github.com/users/owst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owst/subscriptions","organizations_url":"https://api.github.com/users/owst/orgs","repos_url":"https://api.github.com/users/owst/repos","events_url":"https://api.github.com/users/owst/events{/privacy}","received_events_url":"https://api.github.com/users/owst/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-05-19T19:42:11Z","updated_at":"2016-05-26T23:38:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bbatsov/rubocop/pulls/3149","html_url":"https://github.com/bbatsov/rubocop/pull/3149","diff_url":"https://github.com/bbatsov/rubocop/pull/3149.diff","patch_url":"https://github.com/bbatsov/rubocop/pull/3149.patch"},"body":"Perhaps a slightly personal taste, but I think \r\n```\r\n{ :development? => true }\r\n```\r\n reads better/is clearer than \r\n```\r\n{ development?: true }\r\n```\r\nand therefore Rubocop shouldn't suggest changing the former to the latter. (Similarly for symbols ending in `!` e.g. `{ :raise_on_invalid! => true }`.\r\n\r\nAs an example, the original line I wrote that triggered this was:\r\n```\r\nexpect(Rails).to receive(:env).and_return(double(:production? => true)) \r\n```\r\n\r\nI'd be interested to know what others think of this one.\r\n\r\n-----------------\r\n\r\nBefore submitting the PR make sure the following are checked:\r\n\r\n* [x] Wrote [good commit messages][1].\r\n* [x] Used the same coding conventions as the rest of the project.\r\n* [x] Feature branch is up-to-date with `master` (if not - rebase it)\r\n* [x] Squashed related commits together.\r\n* [x] Added tests.\r\n* [x] Added an entry to the [Changelog](../blob/master/CHANGELOG.md) if the new code introduces user-observable changes. See [changelog entry format](../blob/master/CONTRIBUTING.md#changelog-entry-format).\r\n* [x] All tests are passing.\r\n* [x] The new code doesn't generate RuboCop offenses.\r\n* [x] The PR relates to *only* one subject with a clear title\r\n  and description in grammatically correct, complete sentences.\r\n\r\n[1]: http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/bbatsov/rubocop/issues/comments/222024632","html_url":"https://github.com/bbatsov/rubocop/pull/3149#issuecomment-222024632","issue_url":"https://api.github.com/repos/bbatsov/rubocop/issues/3149","id":222024632,"user":{"login":"owst","id":117234,"avatar_url":"https://avatars.githubusercontent.com/u/117234?v=3","gravatar_id":"","url":"https://api.github.com/users/owst","html_url":"https://github.com/owst","followers_url":"https://api.github.com/users/owst/followers","following_url":"https://api.github.com/users/owst/following{/other_user}","gists_url":"https://api.github.com/users/owst/gists{/gist_id}","starred_url":"https://api.github.com/users/owst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owst/subscriptions","organizations_url":"https://api.github.com/users/owst/orgs","repos_url":"https://api.github.com/users/owst/repos","events_url":"https://api.github.com/users/owst/events{/privacy}","received_events_url":"https://api.github.com/users/owst/received_events","type":"User","site_admin":false},"created_at":"2016-05-26T23:38:12Z","updated_at":"2016-05-26T23:38:12Z","body":"I'll repaste my reply to @bbatsov since it was hidden by my change:\r\n\r\nhaha, yeah definitely, I struggled with it! What about\r\n\r\n1. AllowNonAlnumEndingSymbolHashRockets\r\n2. AllowHashRocketsForPunctuationEndingSymbols\r\n3. HashRocketsAllowedWithEndingPunctuation\r\n4. PreferHashRocketsForNonAlnumEndingSymbols\r\n\r\ncontrasting with the current\r\n\r\n- AllowHashRocketsWithSymbolValuesEndingInNonAlnum\r\n\r\nOk, I'll rebase and make it false by default and for now use 4.\r\n"}}
{"actor":{"display_login":"owst"}}