{"action":"opened","number":193,"pull_request":{"url":"https://api.github.com/repos/BryanEngler/liferay-portal/pulls/193","id":88746126,"html_url":"https://github.com/BryanEngler/liferay-portal/pull/193","diff_url":"https://github.com/BryanEngler/liferay-portal/pull/193.diff","patch_url":"https://github.com/BryanEngler/liferay-portal/pull/193.patch","issue_url":"https://api.github.com/repos/BryanEngler/liferay-portal/issues/193","number":193,"state":"open","locked":false,"title":"LPS-68191","user":{"login":"ericyanLr","id":12802270,"avatar_url":"https://avatars.githubusercontent.com/u/12802270?v=3","gravatar_id":"","url":"https://api.github.com/users/ericyanLr","html_url":"https://github.com/ericyanLr","followers_url":"https://api.github.com/users/ericyanLr/followers","following_url":"https://api.github.com/users/ericyanLr/following{/other_user}","gists_url":"https://api.github.com/users/ericyanLr/gists{/gist_id}","starred_url":"https://api.github.com/users/ericyanLr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericyanLr/subscriptions","organizations_url":"https://api.github.com/users/ericyanLr/orgs","repos_url":"https://api.github.com/users/ericyanLr/repos","events_url":"https://api.github.com/users/ericyanLr/events{/privacy}","received_events_url":"https://api.github.com/users/ericyanLr/received_events","type":"User","site_admin":false},"body":"Hey @BryanEngler,\r\n\r\nOriginal LPP Ticket: [LPP-22447](https://issues.liferay.com/browse/LPP-22447)\r\n\r\nThis pull request is to resolve the issue, where the AssetPublisher configuration is exported with unnecessary references to AssetTypes, which causes missing-references errors during import.\r\n\r\nWe decided to approach this on the export-side, which would allow us to retain the flexibility of the AssetPublisher configuration, as well as not having to worry about existing AssetPublisher preferences.\r\n\r\n**Main Goal**\r\nModify/exclude AssetType preferences for export, based on the selected options and intended behavior.\r\n\r\n**Main Cases to Handle**\r\n- 'Any' is selected for AssetType or SubType\r\n- 'Select More Than One..' is selected for AssetType or Subtype\r\n- Single AssetType or SubType is selected\r\n- Combinations of the cases above\r\n- 'Manual' Asset Selection is chosen\r\n\r\n**Next Reviewer: Eduardo**\r\nFrom the email thread, Eduardo mentioned that we could send the PR to him and he can solve any remaining questions with Julio and Edualdo during the review.\r\n\r\nPlease let me know if you have any questions or if there's anything I can improve on this PR.\r\nThanks!\r\n\r\n\r\n","created_at":"2016-10-10T23:10:16Z","updated_at":"2016-10-10T23:10:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/BryanEngler/liferay-portal/pulls/193/commits","review_comments_url":"https://api.github.com/repos/BryanEngler/liferay-portal/pulls/193/comments","review_comment_url":"https://api.github.com/repos/BryanEngler/liferay-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BryanEngler/liferay-portal/issues/193/comments","statuses_url":"https://api.github.com/repos/BryanEngler/liferay-portal/statuses/7d13d4e272a431407b2d312d39be54b5a0609341","head":{"label":"ericyanLr:LPS-68191-2","ref":"LPS-68191-2","sha":"7d13d4e272a431407b2d312d39be54b5a0609341","user":{"login":"ericyanLr","id":12802270,"avatar_url":"https://avatars.githubusercontent.com/u/12802270?v=3","gravatar_id":"","url":"https://api.github.com/users/ericyanLr","html_url":"https://github.com/ericyanLr","followers_url":"https://api.github.com/users/ericyanLr/followers","following_url":"https://api.github.com/users/ericyanLr/following{/other_user}","gists_url":"https://api.github.com/users/ericyanLr/gists{/gist_id}","starred_url":"https://api.github.com/users/ericyanLr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericyanLr/subscriptions","organizations_url":"https://api.github.com/users/ericyanLr/orgs","repos_url":"https://api.github.com/users/ericyanLr/repos","events_url":"https://api.github.com/users/ericyanLr/events{/privacy}","received_events_url":"https://api.github.com/users/ericyanLr/received_events","type":"User","site_admin":false},"repo":{"id":37331503,"name":"liferay-portal","full_name":"ericyanLr/liferay-portal","owner":{"login":"ericyanLr","id":12802270,"avatar_url":"https://avatars.githubusercontent.com/u/12802270?v=3","gravatar_id":"","url":"https://api.github.com/users/ericyanLr","html_url":"https://github.com/ericyanLr","followers_url":"https://api.github.com/users/ericyanLr/followers","following_url":"https://api.github.com/users/ericyanLr/following{/other_user}","gists_url":"https://api.github.com/users/ericyanLr/gists{/gist_id}","starred_url":"https://api.github.com/users/ericyanLr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericyanLr/subscriptions","organizations_url":"https://api.github.com/users/ericyanLr/orgs","repos_url":"https://api.github.com/users/ericyanLr/repos","events_url":"https://api.github.com/users/ericyanLr/events{/privacy}","received_events_url":"https://api.github.com/users/ericyanLr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericyanLr/liferay-portal","description":"","fork":true,"url":"https://api.github.com/repos/ericyanLr/liferay-portal","forks_url":"https://api.github.com/repos/ericyanLr/liferay-portal/forks","keys_url":"https://api.github.com/repos/ericyanLr/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericyanLr/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericyanLr/liferay-portal/teams","hooks_url":"https://api.github.com/repos/ericyanLr/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/ericyanLr/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/ericyanLr/liferay-portal/events","assignees_url":"https://api.github.com/repos/ericyanLr/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/ericyanLr/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/ericyanLr/liferay-portal/tags","blobs_url":"https://api.github.com/repos/ericyanLr/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericyanLr/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericyanLr/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericyanLr/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericyanLr/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/ericyanLr/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/ericyanLr/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/ericyanLr/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/ericyanLr/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/ericyanLr/liferay-portal/subscription","commits_url":"https://api.github.com/repos/ericyanLr/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericyanLr/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericyanLr/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericyanLr/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericyanLr/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/ericyanLr/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericyanLr/liferay-portal/merges","archive_url":"https://api.github.com/repos/ericyanLr/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericyanLr/liferay-portal/downloads","issues_url":"https://api.github.com/repos/ericyanLr/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/ericyanLr/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/ericyanLr/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/ericyanLr/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericyanLr/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/ericyanLr/liferay-portal/releases{/id}","deployments_url":"https://api.github.com/repos/ericyanLr/liferay-portal/deployments","created_at":"2015-06-12T16:06:54Z","updated_at":"2016-01-12T22:37:18Z","pushed_at":"2016-10-10T23:06:49Z","git_url":"git://github.com/ericyanLr/liferay-portal.git","ssh_url":"git@github.com:ericyanLr/liferay-portal.git","clone_url":"https://github.com/ericyanLr/liferay-portal.git","svn_url":"https://github.com/ericyanLr/liferay-portal","homepage":"http://liferay.com","size":10556730,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"BryanEngler:master","ref":"master","sha":"b55fcfe0e5306855c16efa4251314158c6dc057d","user":{"login":"BryanEngler","id":2111174,"avatar_url":"https://avatars.githubusercontent.com/u/2111174?v=3","gravatar_id":"","url":"https://api.github.com/users/BryanEngler","html_url":"https://github.com/BryanEngler","followers_url":"https://api.github.com/users/BryanEngler/followers","following_url":"https://api.github.com/users/BryanEngler/following{/other_user}","gists_url":"https://api.github.com/users/BryanEngler/gists{/gist_id}","starred_url":"https://api.github.com/users/BryanEngler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BryanEngler/subscriptions","organizations_url":"https://api.github.com/users/BryanEngler/orgs","repos_url":"https://api.github.com/users/BryanEngler/repos","events_url":"https://api.github.com/users/BryanEngler/events{/privacy}","received_events_url":"https://api.github.com/users/BryanEngler/received_events","type":"User","site_admin":false},"repo":{"id":5331035,"name":"liferay-portal","full_name":"BryanEngler/liferay-portal","owner":{"login":"BryanEngler","id":2111174,"avatar_url":"https://avatars.githubusercontent.com/u/2111174?v=3","gravatar_id":"","url":"https://api.github.com/users/BryanEngler","html_url":"https://github.com/BryanEngler","followers_url":"https://api.github.com/users/BryanEngler/followers","following_url":"https://api.github.com/users/BryanEngler/following{/other_user}","gists_url":"https://api.github.com/users/BryanEngler/gists{/gist_id}","starred_url":"https://api.github.com/users/BryanEngler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BryanEngler/subscriptions","organizations_url":"https://api.github.com/users/BryanEngler/orgs","repos_url":"https://api.github.com/users/BryanEngler/repos","events_url":"https://api.github.com/users/BryanEngler/events{/privacy}","received_events_url":"https://api.github.com/users/BryanEngler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BryanEngler/liferay-portal","description":"","fork":true,"url":"https://api.github.com/repos/BryanEngler/liferay-portal","forks_url":"https://api.github.com/repos/BryanEngler/liferay-portal/forks","keys_url":"https://api.github.com/repos/BryanEngler/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BryanEngler/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BryanEngler/liferay-portal/teams","hooks_url":"https://api.github.com/repos/BryanEngler/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/BryanEngler/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/BryanEngler/liferay-portal/events","assignees_url":"https://api.github.com/repos/BryanEngler/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/BryanEngler/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/BryanEngler/liferay-portal/tags","blobs_url":"https://api.github.com/repos/BryanEngler/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BryanEngler/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BryanEngler/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/BryanEngler/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BryanEngler/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/BryanEngler/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/BryanEngler/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/BryanEngler/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/BryanEngler/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/BryanEngler/liferay-portal/subscription","commits_url":"https://api.github.com/repos/BryanEngler/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/BryanEngler/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/BryanEngler/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/BryanEngler/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/BryanEngler/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/BryanEngler/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BryanEngler/liferay-portal/merges","archive_url":"https://api.github.com/repos/BryanEngler/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BryanEngler/liferay-portal/downloads","issues_url":"https://api.github.com/repos/BryanEngler/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/BryanEngler/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/BryanEngler/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/BryanEngler/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BryanEngler/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/BryanEngler/liferay-portal/releases{/id}","deployments_url":"https://api.github.com/repos/BryanEngler/liferay-portal/deployments","created_at":"2012-08-07T17:29:23Z","updated_at":"2016-01-05T15:49:55Z","pushed_at":"2016-10-10T23:10:16Z","git_url":"git://github.com/BryanEngler/liferay-portal.git","ssh_url":"git@github.com:BryanEngler/liferay-portal.git","clone_url":"https://github.com/BryanEngler/liferay-portal.git","svn_url":"https://github.com/BryanEngler/liferay-portal","homepage":"http://liferay.com","size":10231835,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BryanEngler/liferay-portal/pulls/193"},"html":{"href":"https://github.com/BryanEngler/liferay-portal/pull/193"},"issue":{"href":"https://api.github.com/repos/BryanEngler/liferay-portal/issues/193"},"comments":{"href":"https://api.github.com/repos/BryanEngler/liferay-portal/issues/193/comments"},"review_comments":{"href":"https://api.github.com/repos/BryanEngler/liferay-portal/pulls/193/comments"},"review_comment":{"href":"https://api.github.com/repos/BryanEngler/liferay-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BryanEngler/liferay-portal/pulls/193/commits"},"statuses":{"href":"https://api.github.com/repos/BryanEngler/liferay-portal/statuses/7d13d4e272a431407b2d312d39be54b5a0609341"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":255,"additions":6347,"deletions":3167,"changed_files":375}}
{"actor":{"display_login":"ericyanLr"}}