{"action":"closed","number":270,"pull_request":{"url":"https://api.github.com/repos/WP-API/node-wpapi/pulls/270","id":96667159,"html_url":"https://github.com/WP-API/node-wpapi/pull/270","diff_url":"https://github.com/WP-API/node-wpapi/pull/270.diff","patch_url":"https://github.com/WP-API/node-wpapi/pull/270.patch","issue_url":"https://api.github.com/repos/WP-API/node-wpapi/issues/270","number":270,"state":"closed","locked":false,"title":"Breaking: Remove \"merge\" argument from `.param` method (Closes #227)","user":{"login":"kadamwhite","id":442115,"avatar_url":"https://avatars.githubusercontent.com/u/442115?v=3","gravatar_id":"","url":"https://api.github.com/users/kadamwhite","html_url":"https://github.com/kadamwhite","followers_url":"https://api.github.com/users/kadamwhite/followers","following_url":"https://api.github.com/users/kadamwhite/following{/other_user}","gists_url":"https://api.github.com/users/kadamwhite/gists{/gist_id}","starred_url":"https://api.github.com/users/kadamwhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadamwhite/subscriptions","organizations_url":"https://api.github.com/users/kadamwhite/orgs","repos_url":"https://api.github.com/users/kadamwhite/repos","events_url":"https://api.github.com/users/kadamwhite/events{/privacy}","received_events_url":"https://api.github.com/users/kadamwhite/received_events","type":"User","site_admin":false},"body":"The third \"merge\" argument in `.param( key, val, merge )` has been on the chopping block for two months and is now being removed prior to the 1.0 release.\r\n\r\nWPRequest instances are intended to be transient: It is much easier to understand building a single array of values, and then call `.param( 'key', valuesArr )` once at the end, than it is to mentally keep track of calling `.param( 'key', value, true )` multiple times.\r\n\r\nIt is also one of the only mysterious boolean arguments in the entire library, and we normally aim to avoid those.\r\n\r\nIt is _also_ only used in one place (the `.parent` mixin), and is the only place the `lodash.uniq` NPM dependency is used within node-wpapi. Removing the argument allows us to simplify code in several places and permits the removal of that dependency library, slightly decreasing the size of the built browser UMD bundles.\r\n\r\nAs an aside, passing an array of parents returns posts under ANY of the provided parents.","created_at":"2016-12-06T06:15:45Z","updated_at":"2016-12-06T06:18:22Z","closed_at":"2016-12-06T06:18:22Z","merged_at":"2016-12-06T06:18:22Z","merge_commit_sha":"3d0778bc98df9453f54bd1ba71184127524768d0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/WP-API/node-wpapi/pulls/270/commits","review_comments_url":"https://api.github.com/repos/WP-API/node-wpapi/pulls/270/comments","review_comment_url":"https://api.github.com/repos/WP-API/node-wpapi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WP-API/node-wpapi/issues/270/comments","statuses_url":"https://api.github.com/repos/WP-API/node-wpapi/statuses/3d0778bc98df9453f54bd1ba71184127524768d0","head":{"label":"WP-API:remove-param-merge-argument","ref":"remove-param-merge-argument","sha":"3d0778bc98df9453f54bd1ba71184127524768d0","user":{"login":"WP-API","id":5706008,"avatar_url":"https://avatars.githubusercontent.com/u/5706008?v=3","gravatar_id":"","url":"https://api.github.com/users/WP-API","html_url":"https://github.com/WP-API","followers_url":"https://api.github.com/users/WP-API/followers","following_url":"https://api.github.com/users/WP-API/following{/other_user}","gists_url":"https://api.github.com/users/WP-API/gists{/gist_id}","starred_url":"https://api.github.com/users/WP-API/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WP-API/subscriptions","organizations_url":"https://api.github.com/users/WP-API/orgs","repos_url":"https://api.github.com/users/WP-API/repos","events_url":"https://api.github.com/users/WP-API/events{/privacy}","received_events_url":"https://api.github.com/users/WP-API/received_events","type":"Organization","site_admin":false},"repo":{"id":20412692,"name":"node-wpapi","full_name":"WP-API/node-wpapi","owner":{"login":"WP-API","id":5706008,"avatar_url":"https://avatars.githubusercontent.com/u/5706008?v=3","gravatar_id":"","url":"https://api.github.com/users/WP-API","html_url":"https://github.com/WP-API","followers_url":"https://api.github.com/users/WP-API/followers","following_url":"https://api.github.com/users/WP-API/following{/other_user}","gists_url":"https://api.github.com/users/WP-API/gists{/gist_id}","starred_url":"https://api.github.com/users/WP-API/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WP-API/subscriptions","organizations_url":"https://api.github.com/users/WP-API/orgs","repos_url":"https://api.github.com/users/WP-API/repos","events_url":"https://api.github.com/users/WP-API/events{/privacy}","received_events_url":"https://api.github.com/users/WP-API/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WP-API/node-wpapi","description":"A JavaScript client for the WordPress JSON API","fork":false,"url":"https://api.github.com/repos/WP-API/node-wpapi","forks_url":"https://api.github.com/repos/WP-API/node-wpapi/forks","keys_url":"https://api.github.com/repos/WP-API/node-wpapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WP-API/node-wpapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WP-API/node-wpapi/teams","hooks_url":"https://api.github.com/repos/WP-API/node-wpapi/hooks","issue_events_url":"https://api.github.com/repos/WP-API/node-wpapi/issues/events{/number}","events_url":"https://api.github.com/repos/WP-API/node-wpapi/events","assignees_url":"https://api.github.com/repos/WP-API/node-wpapi/assignees{/user}","branches_url":"https://api.github.com/repos/WP-API/node-wpapi/branches{/branch}","tags_url":"https://api.github.com/repos/WP-API/node-wpapi/tags","blobs_url":"https://api.github.com/repos/WP-API/node-wpapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WP-API/node-wpapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WP-API/node-wpapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/WP-API/node-wpapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WP-API/node-wpapi/statuses/{sha}","languages_url":"https://api.github.com/repos/WP-API/node-wpapi/languages","stargazers_url":"https://api.github.com/repos/WP-API/node-wpapi/stargazers","contributors_url":"https://api.github.com/repos/WP-API/node-wpapi/contributors","subscribers_url":"https://api.github.com/repos/WP-API/node-wpapi/subscribers","subscription_url":"https://api.github.com/repos/WP-API/node-wpapi/subscription","commits_url":"https://api.github.com/repos/WP-API/node-wpapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/WP-API/node-wpapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/WP-API/node-wpapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/WP-API/node-wpapi/issues/comments{/number}","contents_url":"https://api.github.com/repos/WP-API/node-wpapi/contents/{+path}","compare_url":"https://api.github.com/repos/WP-API/node-wpapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WP-API/node-wpapi/merges","archive_url":"https://api.github.com/repos/WP-API/node-wpapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WP-API/node-wpapi/downloads","issues_url":"https://api.github.com/repos/WP-API/node-wpapi/issues{/number}","pulls_url":"https://api.github.com/repos/WP-API/node-wpapi/pulls{/number}","milestones_url":"https://api.github.com/repos/WP-API/node-wpapi/milestones{/number}","notifications_url":"https://api.github.com/repos/WP-API/node-wpapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WP-API/node-wpapi/labels{/name}","releases_url":"https://api.github.com/repos/WP-API/node-wpapi/releases{/id}","deployments_url":"https://api.github.com/repos/WP-API/node-wpapi/deployments","created_at":"2014-06-02T17:20:53Z","updated_at":"2016-12-06T04:56:33Z","pushed_at":"2016-12-06T06:18:21Z","git_url":"git://github.com/WP-API/node-wpapi.git","ssh_url":"git@github.com:WP-API/node-wpapi.git","clone_url":"https://github.com/WP-API/node-wpapi.git","svn_url":"https://github.com/WP-API/node-wpapi","homepage":"","size":2252,"stargazers_count":468,"watchers_count":468,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":68,"mirror_url":null,"open_issues_count":8,"forks":68,"open_issues":8,"watchers":468,"default_branch":"master"}},"base":{"label":"WP-API:master","ref":"master","sha":"5581ac0cb9133a2c30fbebbfb64fe9908f24e9dc","user":{"login":"WP-API","id":5706008,"avatar_url":"https://avatars.githubusercontent.com/u/5706008?v=3","gravatar_id":"","url":"https://api.github.com/users/WP-API","html_url":"https://github.com/WP-API","followers_url":"https://api.github.com/users/WP-API/followers","following_url":"https://api.github.com/users/WP-API/following{/other_user}","gists_url":"https://api.github.com/users/WP-API/gists{/gist_id}","starred_url":"https://api.github.com/users/WP-API/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WP-API/subscriptions","organizations_url":"https://api.github.com/users/WP-API/orgs","repos_url":"https://api.github.com/users/WP-API/repos","events_url":"https://api.github.com/users/WP-API/events{/privacy}","received_events_url":"https://api.github.com/users/WP-API/received_events","type":"Organization","site_admin":false},"repo":{"id":20412692,"name":"node-wpapi","full_name":"WP-API/node-wpapi","owner":{"login":"WP-API","id":5706008,"avatar_url":"https://avatars.githubusercontent.com/u/5706008?v=3","gravatar_id":"","url":"https://api.github.com/users/WP-API","html_url":"https://github.com/WP-API","followers_url":"https://api.github.com/users/WP-API/followers","following_url":"https://api.github.com/users/WP-API/following{/other_user}","gists_url":"https://api.github.com/users/WP-API/gists{/gist_id}","starred_url":"https://api.github.com/users/WP-API/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WP-API/subscriptions","organizations_url":"https://api.github.com/users/WP-API/orgs","repos_url":"https://api.github.com/users/WP-API/repos","events_url":"https://api.github.com/users/WP-API/events{/privacy}","received_events_url":"https://api.github.com/users/WP-API/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WP-API/node-wpapi","description":"A JavaScript client for the WordPress JSON API","fork":false,"url":"https://api.github.com/repos/WP-API/node-wpapi","forks_url":"https://api.github.com/repos/WP-API/node-wpapi/forks","keys_url":"https://api.github.com/repos/WP-API/node-wpapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WP-API/node-wpapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WP-API/node-wpapi/teams","hooks_url":"https://api.github.com/repos/WP-API/node-wpapi/hooks","issue_events_url":"https://api.github.com/repos/WP-API/node-wpapi/issues/events{/number}","events_url":"https://api.github.com/repos/WP-API/node-wpapi/events","assignees_url":"https://api.github.com/repos/WP-API/node-wpapi/assignees{/user}","branches_url":"https://api.github.com/repos/WP-API/node-wpapi/branches{/branch}","tags_url":"https://api.github.com/repos/WP-API/node-wpapi/tags","blobs_url":"https://api.github.com/repos/WP-API/node-wpapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WP-API/node-wpapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WP-API/node-wpapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/WP-API/node-wpapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WP-API/node-wpapi/statuses/{sha}","languages_url":"https://api.github.com/repos/WP-API/node-wpapi/languages","stargazers_url":"https://api.github.com/repos/WP-API/node-wpapi/stargazers","contributors_url":"https://api.github.com/repos/WP-API/node-wpapi/contributors","subscribers_url":"https://api.github.com/repos/WP-API/node-wpapi/subscribers","subscription_url":"https://api.github.com/repos/WP-API/node-wpapi/subscription","commits_url":"https://api.github.com/repos/WP-API/node-wpapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/WP-API/node-wpapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/WP-API/node-wpapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/WP-API/node-wpapi/issues/comments{/number}","contents_url":"https://api.github.com/repos/WP-API/node-wpapi/contents/{+path}","compare_url":"https://api.github.com/repos/WP-API/node-wpapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WP-API/node-wpapi/merges","archive_url":"https://api.github.com/repos/WP-API/node-wpapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WP-API/node-wpapi/downloads","issues_url":"https://api.github.com/repos/WP-API/node-wpapi/issues{/number}","pulls_url":"https://api.github.com/repos/WP-API/node-wpapi/pulls{/number}","milestones_url":"https://api.github.com/repos/WP-API/node-wpapi/milestones{/number}","notifications_url":"https://api.github.com/repos/WP-API/node-wpapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WP-API/node-wpapi/labels{/name}","releases_url":"https://api.github.com/repos/WP-API/node-wpapi/releases{/id}","deployments_url":"https://api.github.com/repos/WP-API/node-wpapi/deployments","created_at":"2014-06-02T17:20:53Z","updated_at":"2016-12-06T04:56:33Z","pushed_at":"2016-12-06T06:18:21Z","git_url":"git://github.com/WP-API/node-wpapi.git","ssh_url":"git@github.com:WP-API/node-wpapi.git","clone_url":"https://github.com/WP-API/node-wpapi.git","svn_url":"https://github.com/WP-API/node-wpapi","homepage":"","size":2252,"stargazers_count":468,"watchers_count":468,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":68,"mirror_url":null,"open_issues_count":8,"forks":68,"open_issues":8,"watchers":468,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WP-API/node-wpapi/pulls/270"},"html":{"href":"https://github.com/WP-API/node-wpapi/pull/270"},"issue":{"href":"https://api.github.com/repos/WP-API/node-wpapi/issues/270"},"comments":{"href":"https://api.github.com/repos/WP-API/node-wpapi/issues/270/comments"},"review_comments":{"href":"https://api.github.com/repos/WP-API/node-wpapi/pulls/270/comments"},"review_comment":{"href":"https://api.github.com/repos/WP-API/node-wpapi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WP-API/node-wpapi/pulls/270/commits"},"statuses":{"href":"https://api.github.com/repos/WP-API/node-wpapi/statuses/3d0778bc98df9453f54bd1ba71184127524768d0"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kadamwhite","id":442115,"avatar_url":"https://avatars.githubusercontent.com/u/442115?v=3","gravatar_id":"","url":"https://api.github.com/users/kadamwhite","html_url":"https://github.com/kadamwhite","followers_url":"https://api.github.com/users/kadamwhite/followers","following_url":"https://api.github.com/users/kadamwhite/following{/other_user}","gists_url":"https://api.github.com/users/kadamwhite/gists{/gist_id}","starred_url":"https://api.github.com/users/kadamwhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadamwhite/subscriptions","organizations_url":"https://api.github.com/users/kadamwhite/orgs","repos_url":"https://api.github.com/users/kadamwhite/repos","events_url":"https://api.github.com/users/kadamwhite/events{/privacy}","received_events_url":"https://api.github.com/users/kadamwhite/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":16,"deletions":48,"changed_files":5}}
{"actor":{"display_login":"kadamwhite"}}