{"action":"created","comment":{"url":"https://api.github.com/repos/uf-mil/Navigator/pulls/comments/85633798","pull_request_review_id":6341882,"id":85633798,"diff_hunk":"@@ -0,0 +1,80 @@\n+#include \"TrackedShape.h\"\n+int TrackedShape::MIN_COUNT = 20;\n+double TrackedShape::MAX_DISTANCE = 5;\n+ros::Duration TrackedShape::MAX_TIME_GAP = ros::Duration(0, 0.5 * 1000000000);","path":"perception/navigator_perception/nodes/shape_identification/TrackedShape.cpp","position":4,"original_position":4,"commit_id":"a0d1b99821b659c2c203aef8aba6e4ef6f5dc908","original_commit_id":"a0d1b99821b659c2c203aef8aba6e4ef6f5dc908","user":{"login":"DSsoto","id":8714358,"avatar_url":"https://avatars.githubusercontent.com/u/8714358?v=3","gravatar_id":"","url":"https://api.github.com/users/DSsoto","html_url":"https://github.com/DSsoto","followers_url":"https://api.github.com/users/DSsoto/followers","following_url":"https://api.github.com/users/DSsoto/following{/other_user}","gists_url":"https://api.github.com/users/DSsoto/gists{/gist_id}","starred_url":"https://api.github.com/users/DSsoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DSsoto/subscriptions","organizations_url":"https://api.github.com/users/DSsoto/orgs","repos_url":"https://api.github.com/users/DSsoto/repos","events_url":"https://api.github.com/users/DSsoto/events{/privacy}","received_events_url":"https://api.github.com/users/DSsoto/received_events","type":"User","site_admin":false},"body":"`1E9` is much easier to read","created_at":"2016-10-29T04:36:32Z","updated_at":"2016-10-29T04:36:32Z","html_url":"https://github.com/uf-mil/Navigator/pull/107#discussion_r85633798","pull_request_url":"https://api.github.com/repos/uf-mil/Navigator/pulls/107","_links":{"self":{"href":"https://api.github.com/repos/uf-mil/Navigator/pulls/comments/85633798"},"html":{"href":"https://github.com/uf-mil/Navigator/pull/107#discussion_r85633798"},"pull_request":{"href":"https://api.github.com/repos/uf-mil/Navigator/pulls/107"}}},"pull_request":{"url":"https://api.github.com/repos/uf-mil/Navigator/pulls/107","id":91466040,"html_url":"https://github.com/uf-mil/Navigator/pull/107","diff_url":"https://github.com/uf-mil/Navigator/pull/107.diff","patch_url":"https://github.com/uf-mil/Navigator/pull/107.patch","issue_url":"https://api.github.com/repos/uf-mil/Navigator/issues/107","number":107,"state":"open","locked":false,"title":"DETECT DELIVER: Track shapes for more reliable perception + colors","user":{"login":"ironmig","id":9502636,"avatar_url":"https://avatars.githubusercontent.com/u/9502636?v=3","gravatar_id":"","url":"https://api.github.com/users/ironmig","html_url":"https://github.com/ironmig","followers_url":"https://api.github.com/users/ironmig/followers","following_url":"https://api.github.com/users/ironmig/following{/other_user}","gists_url":"https://api.github.com/users/ironmig/gists{/gist_id}","starred_url":"https://api.github.com/users/ironmig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironmig/subscriptions","organizations_url":"https://api.github.com/users/ironmig/orgs","repos_url":"https://api.github.com/users/ironmig/repos","events_url":"https://api.github.com/users/ironmig/events{/privacy}","received_events_url":"https://api.github.com/users/ironmig/received_events","type":"User","site_admin":false},"body":"Includes improvements from this week on detect deliver, mostly with the perception but also with the mission.\r\n\r\n1.  Camera/lidar transformer and mission don't have a hardcoded frame id so it will adapt better if this changes, or we use a different camera with this node\r\n2. Instead of storing a buffer of recent shapes to determine which are legit, contours are tracked over time. Those that remain for a while are considered legit\r\n3. A major bug in color classification was fixed  after using DDB™ (David Debugger), so it should much more reliably select which color a shape is\r\n4. Various clean ups such as moving into perception package and renaming things","created_at":"2016-10-28T23:05:31Z","updated_at":"2016-10-29T04:36:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1d65cc306192e4024b2d9ce487780c6902e297c6","assignee":{"login":"DSsoto","id":8714358,"avatar_url":"https://avatars.githubusercontent.com/u/8714358?v=3","gravatar_id":"","url":"https://api.github.com/users/DSsoto","html_url":"https://github.com/DSsoto","followers_url":"https://api.github.com/users/DSsoto/followers","following_url":"https://api.github.com/users/DSsoto/following{/other_user}","gists_url":"https://api.github.com/users/DSsoto/gists{/gist_id}","starred_url":"https://api.github.com/users/DSsoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DSsoto/subscriptions","organizations_url":"https://api.github.com/users/DSsoto/orgs","repos_url":"https://api.github.com/users/DSsoto/repos","events_url":"https://api.github.com/users/DSsoto/events{/privacy}","received_events_url":"https://api.github.com/users/DSsoto/received_events","type":"User","site_admin":false},"assignees":[{"login":"DSsoto","id":8714358,"avatar_url":"https://avatars.githubusercontent.com/u/8714358?v=3","gravatar_id":"","url":"https://api.github.com/users/DSsoto","html_url":"https://github.com/DSsoto","followers_url":"https://api.github.com/users/DSsoto/followers","following_url":"https://api.github.com/users/DSsoto/following{/other_user}","gists_url":"https://api.github.com/users/DSsoto/gists{/gist_id}","starred_url":"https://api.github.com/users/DSsoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DSsoto/subscriptions","organizations_url":"https://api.github.com/users/DSsoto/orgs","repos_url":"https://api.github.com/users/DSsoto/repos","events_url":"https://api.github.com/users/DSsoto/events{/privacy}","received_events_url":"https://api.github.com/users/DSsoto/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/uf-mil/Navigator/pulls/107/commits","review_comments_url":"https://api.github.com/repos/uf-mil/Navigator/pulls/107/comments","review_comment_url":"https://api.github.com/repos/uf-mil/Navigator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uf-mil/Navigator/issues/107/comments","statuses_url":"https://api.github.com/repos/uf-mil/Navigator/statuses/a0d1b99821b659c2c203aef8aba6e4ef6f5dc908","head":{"label":"ironmig:detect-deliver-dev","ref":"detect-deliver-dev","sha":"a0d1b99821b659c2c203aef8aba6e4ef6f5dc908","user":{"login":"ironmig","id":9502636,"avatar_url":"https://avatars.githubusercontent.com/u/9502636?v=3","gravatar_id":"","url":"https://api.github.com/users/ironmig","html_url":"https://github.com/ironmig","followers_url":"https://api.github.com/users/ironmig/followers","following_url":"https://api.github.com/users/ironmig/following{/other_user}","gists_url":"https://api.github.com/users/ironmig/gists{/gist_id}","starred_url":"https://api.github.com/users/ironmig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironmig/subscriptions","organizations_url":"https://api.github.com/users/ironmig/orgs","repos_url":"https://api.github.com/users/ironmig/repos","events_url":"https://api.github.com/users/ironmig/events{/privacy}","received_events_url":"https://api.github.com/users/ironmig/received_events","type":"User","site_admin":false},"repo":{"id":62825057,"name":"Navigator","full_name":"ironmig/Navigator","owner":{"login":"ironmig","id":9502636,"avatar_url":"https://avatars.githubusercontent.com/u/9502636?v=3","gravatar_id":"","url":"https://api.github.com/users/ironmig","html_url":"https://github.com/ironmig","followers_url":"https://api.github.com/users/ironmig/followers","following_url":"https://api.github.com/users/ironmig/following{/other_user}","gists_url":"https://api.github.com/users/ironmig/gists{/gist_id}","starred_url":"https://api.github.com/users/ironmig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironmig/subscriptions","organizations_url":"https://api.github.com/users/ironmig/orgs","repos_url":"https://api.github.com/users/ironmig/repos","events_url":"https://api.github.com/users/ironmig/events{/privacy}","received_events_url":"https://api.github.com/users/ironmig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ironmig/Navigator","description":"On board software for UF's NaviGator Autonomous Surface Vehicle","fork":true,"url":"https://api.github.com/repos/ironmig/Navigator","forks_url":"https://api.github.com/repos/ironmig/Navigator/forks","keys_url":"https://api.github.com/repos/ironmig/Navigator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ironmig/Navigator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ironmig/Navigator/teams","hooks_url":"https://api.github.com/repos/ironmig/Navigator/hooks","issue_events_url":"https://api.github.com/repos/ironmig/Navigator/issues/events{/number}","events_url":"https://api.github.com/repos/ironmig/Navigator/events","assignees_url":"https://api.github.com/repos/ironmig/Navigator/assignees{/user}","branches_url":"https://api.github.com/repos/ironmig/Navigator/branches{/branch}","tags_url":"https://api.github.com/repos/ironmig/Navigator/tags","blobs_url":"https://api.github.com/repos/ironmig/Navigator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ironmig/Navigator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ironmig/Navigator/git/refs{/sha}","trees_url":"https://api.github.com/repos/ironmig/Navigator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ironmig/Navigator/statuses/{sha}","languages_url":"https://api.github.com/repos/ironmig/Navigator/languages","stargazers_url":"https://api.github.com/repos/ironmig/Navigator/stargazers","contributors_url":"https://api.github.com/repos/ironmig/Navigator/contributors","subscribers_url":"https://api.github.com/repos/ironmig/Navigator/subscribers","subscription_url":"https://api.github.com/repos/ironmig/Navigator/subscription","commits_url":"https://api.github.com/repos/ironmig/Navigator/commits{/sha}","git_commits_url":"https://api.github.com/repos/ironmig/Navigator/git/commits{/sha}","comments_url":"https://api.github.com/repos/ironmig/Navigator/comments{/number}","issue_comment_url":"https://api.github.com/repos/ironmig/Navigator/issues/comments{/number}","contents_url":"https://api.github.com/repos/ironmig/Navigator/contents/{+path}","compare_url":"https://api.github.com/repos/ironmig/Navigator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ironmig/Navigator/merges","archive_url":"https://api.github.com/repos/ironmig/Navigator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ironmig/Navigator/downloads","issues_url":"https://api.github.com/repos/ironmig/Navigator/issues{/number}","pulls_url":"https://api.github.com/repos/ironmig/Navigator/pulls{/number}","milestones_url":"https://api.github.com/repos/ironmig/Navigator/milestones{/number}","notifications_url":"https://api.github.com/repos/ironmig/Navigator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ironmig/Navigator/labels{/name}","releases_url":"https://api.github.com/repos/ironmig/Navigator/releases{/id}","deployments_url":"https://api.github.com/repos/ironmig/Navigator/deployments","created_at":"2016-07-07T17:18:13Z","updated_at":"2016-07-07T17:18:14Z","pushed_at":"2016-10-29T01:07:16Z","git_url":"git://github.com/ironmig/Navigator.git","ssh_url":"git@github.com:ironmig/Navigator.git","clone_url":"https://github.com/ironmig/Navigator.git","svn_url":"https://github.com/ironmig/Navigator","homepage":"","size":3365,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"uf-mil:dev","ref":"dev","sha":"6fef2996a587c8831502fa4c53181586c2fe9e5a","user":{"login":"uf-mil","id":6162945,"avatar_url":"https://avatars.githubusercontent.com/u/6162945?v=3","gravatar_id":"","url":"https://api.github.com/users/uf-mil","html_url":"https://github.com/uf-mil","followers_url":"https://api.github.com/users/uf-mil/followers","following_url":"https://api.github.com/users/uf-mil/following{/other_user}","gists_url":"https://api.github.com/users/uf-mil/gists{/gist_id}","starred_url":"https://api.github.com/users/uf-mil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uf-mil/subscriptions","organizations_url":"https://api.github.com/users/uf-mil/orgs","repos_url":"https://api.github.com/users/uf-mil/repos","events_url":"https://api.github.com/users/uf-mil/events{/privacy}","received_events_url":"https://api.github.com/users/uf-mil/received_events","type":"Organization","site_admin":false},"repo":{"id":42456121,"name":"Navigator","full_name":"uf-mil/Navigator","owner":{"login":"uf-mil","id":6162945,"avatar_url":"https://avatars.githubusercontent.com/u/6162945?v=3","gravatar_id":"","url":"https://api.github.com/users/uf-mil","html_url":"https://github.com/uf-mil","followers_url":"https://api.github.com/users/uf-mil/followers","following_url":"https://api.github.com/users/uf-mil/following{/other_user}","gists_url":"https://api.github.com/users/uf-mil/gists{/gist_id}","starred_url":"https://api.github.com/users/uf-mil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uf-mil/subscriptions","organizations_url":"https://api.github.com/users/uf-mil/orgs","repos_url":"https://api.github.com/users/uf-mil/repos","events_url":"https://api.github.com/users/uf-mil/events{/privacy}","received_events_url":"https://api.github.com/users/uf-mil/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uf-mil/Navigator","description":"On board software for UF's NaviGator Autonomous Surface Vehicle","fork":false,"url":"https://api.github.com/repos/uf-mil/Navigator","forks_url":"https://api.github.com/repos/uf-mil/Navigator/forks","keys_url":"https://api.github.com/repos/uf-mil/Navigator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uf-mil/Navigator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uf-mil/Navigator/teams","hooks_url":"https://api.github.com/repos/uf-mil/Navigator/hooks","issue_events_url":"https://api.github.com/repos/uf-mil/Navigator/issues/events{/number}","events_url":"https://api.github.com/repos/uf-mil/Navigator/events","assignees_url":"https://api.github.com/repos/uf-mil/Navigator/assignees{/user}","branches_url":"https://api.github.com/repos/uf-mil/Navigator/branches{/branch}","tags_url":"https://api.github.com/repos/uf-mil/Navigator/tags","blobs_url":"https://api.github.com/repos/uf-mil/Navigator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uf-mil/Navigator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uf-mil/Navigator/git/refs{/sha}","trees_url":"https://api.github.com/repos/uf-mil/Navigator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uf-mil/Navigator/statuses/{sha}","languages_url":"https://api.github.com/repos/uf-mil/Navigator/languages","stargazers_url":"https://api.github.com/repos/uf-mil/Navigator/stargazers","contributors_url":"https://api.github.com/repos/uf-mil/Navigator/contributors","subscribers_url":"https://api.github.com/repos/uf-mil/Navigator/subscribers","subscription_url":"https://api.github.com/repos/uf-mil/Navigator/subscription","commits_url":"https://api.github.com/repos/uf-mil/Navigator/commits{/sha}","git_commits_url":"https://api.github.com/repos/uf-mil/Navigator/git/commits{/sha}","comments_url":"https://api.github.com/repos/uf-mil/Navigator/comments{/number}","issue_comment_url":"https://api.github.com/repos/uf-mil/Navigator/issues/comments{/number}","contents_url":"https://api.github.com/repos/uf-mil/Navigator/contents/{+path}","compare_url":"https://api.github.com/repos/uf-mil/Navigator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uf-mil/Navigator/merges","archive_url":"https://api.github.com/repos/uf-mil/Navigator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uf-mil/Navigator/downloads","issues_url":"https://api.github.com/repos/uf-mil/Navigator/issues{/number}","pulls_url":"https://api.github.com/repos/uf-mil/Navigator/pulls{/number}","milestones_url":"https://api.github.com/repos/uf-mil/Navigator/milestones{/number}","notifications_url":"https://api.github.com/repos/uf-mil/Navigator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uf-mil/Navigator/labels{/name}","releases_url":"https://api.github.com/repos/uf-mil/Navigator/releases{/id}","deployments_url":"https://api.github.com/repos/uf-mil/Navigator/deployments","created_at":"2015-09-14T15:07:13Z","updated_at":"2016-10-28T20:42:01Z","pushed_at":"2016-10-29T04:34:19Z","git_url":"git://github.com/uf-mil/Navigator.git","ssh_url":"git@github.com:uf-mil/Navigator.git","clone_url":"https://github.com/uf-mil/Navigator.git","svn_url":"https://github.com/uf-mil/Navigator","homepage":"","size":3431,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":12,"forks":13,"open_issues":12,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uf-mil/Navigator/pulls/107"},"html":{"href":"https://github.com/uf-mil/Navigator/pull/107"},"issue":{"href":"https://api.github.com/repos/uf-mil/Navigator/issues/107"},"comments":{"href":"https://api.github.com/repos/uf-mil/Navigator/issues/107/comments"},"review_comments":{"href":"https://api.github.com/repos/uf-mil/Navigator/pulls/107/comments"},"review_comment":{"href":"https://api.github.com/repos/uf-mil/Navigator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uf-mil/Navigator/pulls/107/commits"},"statuses":{"href":"https://api.github.com/repos/uf-mil/Navigator/statuses/a0d1b99821b659c2c203aef8aba6e4ef6f5dc908"}}}}
{"actor":{"display_login":"DSsoto"}}