{"action":"created","comment":{"url":"https://api.github.com/repos/zaproxy/zap-extensions/pulls/comments/73132950","id":73132950,"diff_hunk":"@@ -50,7 +52,32 @@ public void scanHttpRequestSend(HttpMessage msg, int id) {\n \r\n \t@Override\r\n \tpublic void scanHttpResponseReceive(HttpMessage msg, int id, Source source) {\r\n-\t\tif (msg.getRequestHeader().isSecure() && !msg.getRequestHeader().getURI().toString().toLowerCase().endsWith(\".css\") && !msg.getResponseHeader().isImage() && msg.getResponseBody().length() > 0) {\r\n+\t\tif (msg.getRequestHeader().isSecure() && msg.getResponseBody().length() > 0) {\r\n+\t\t\t\r\n+\t\t\tif (AlertThreshold.LOW.equals(this.getLevel())) {\r\n+\t\t\t\tif (msg.getResponseHeader().isImage()) {\r\n+\t\t\t\t\treturn;\r\n+\t\t\t\t}\r\n+\t\t\t\tif (msg.getRequestHeader().getURI().toString().toLowerCase().endsWith(\".css\")) {\r\n+\t\t\t\t\t\r","path":"src/org/zaproxy/zap/extension/pscanrules/CacheControlScanner.java","position":23,"original_position":23,"commit_id":"80f831c861a502332e3e8bffa21009a10c1190e4","original_commit_id":"80f831c861a502332e3e8bffa21009a10c1190e4","user":{"login":"kingthorin","id":7570458,"avatar_url":"https://avatars.githubusercontent.com/u/7570458?v=3","gravatar_id":"","url":"https://api.github.com/users/kingthorin","html_url":"https://github.com/kingthorin","followers_url":"https://api.github.com/users/kingthorin/followers","following_url":"https://api.github.com/users/kingthorin/following{/other_user}","gists_url":"https://api.github.com/users/kingthorin/gists{/gist_id}","starred_url":"https://api.github.com/users/kingthorin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingthorin/subscriptions","organizations_url":"https://api.github.com/users/kingthorin/orgs","repos_url":"https://api.github.com/users/kingthorin/repos","events_url":"https://api.github.com/users/kingthorin/events{/privacy}","received_events_url":"https://api.github.com/users/kingthorin/received_events","type":"User","site_admin":false},"body":"Should there be an action inside this if?","created_at":"2016-08-02T10:42:46Z","updated_at":"2016-08-02T10:42:46Z","html_url":"https://github.com/zaproxy/zap-extensions/pull/473#discussion_r73132950","pull_request_url":"https://api.github.com/repos/zaproxy/zap-extensions/pulls/473","_links":{"self":{"href":"https://api.github.com/repos/zaproxy/zap-extensions/pulls/comments/73132950"},"html":{"href":"https://github.com/zaproxy/zap-extensions/pull/473#discussion_r73132950"},"pull_request":{"href":"https://api.github.com/repos/zaproxy/zap-extensions/pulls/473"}}},"pull_request":{"url":"https://api.github.com/repos/zaproxy/zap-extensions/pulls/473","id":79192349,"html_url":"https://github.com/zaproxy/zap-extensions/pull/473","diff_url":"https://github.com/zaproxy/zap-extensions/pull/473.diff","patch_url":"https://github.com/zaproxy/zap-extensions/pull/473.patch","issue_url":"https://api.github.com/repos/zaproxy/zap-extensions/issues/473","number":473,"state":"open","locked":false,"title":"Pscan rule tweaks","user":{"login":"psiinon","id":1081115,"avatar_url":"https://avatars.githubusercontent.com/u/1081115?v=3","gravatar_id":"","url":"https://api.github.com/users/psiinon","html_url":"https://github.com/psiinon","followers_url":"https://api.github.com/users/psiinon/followers","following_url":"https://api.github.com/users/psiinon/following{/other_user}","gists_url":"https://api.github.com/users/psiinon/gists{/gist_id}","starred_url":"https://api.github.com/users/psiinon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psiinon/subscriptions","organizations_url":"https://api.github.com/users/psiinon/orgs","repos_url":"https://api.github.com/users/psiinon/repos","events_url":"https://api.github.com/users/psiinon/events{/privacy}","received_events_url":"https://api.github.com/users/psiinon/received_events","type":"User","site_admin":false},"body":"As per https://groups.google.com/d/msg/zaproxy-develop/6IAnEHANWpI/zva5350aBgAJ","created_at":"2016-07-28T13:08:35Z","updated_at":"2016-08-02T10:42:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c330351ed50d13d5d9e75213d7341df66b3dd6a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zaproxy/zap-extensions/pulls/473/commits","review_comments_url":"https://api.github.com/repos/zaproxy/zap-extensions/pulls/473/comments","review_comment_url":"https://api.github.com/repos/zaproxy/zap-extensions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zaproxy/zap-extensions/issues/473/comments","statuses_url":"https://api.github.com/repos/zaproxy/zap-extensions/statuses/80f831c861a502332e3e8bffa21009a10c1190e4","head":{"label":"psiinon:master","ref":"master","sha":"80f831c861a502332e3e8bffa21009a10c1190e4","user":{"login":"psiinon","id":1081115,"avatar_url":"https://avatars.githubusercontent.com/u/1081115?v=3","gravatar_id":"","url":"https://api.github.com/users/psiinon","html_url":"https://github.com/psiinon","followers_url":"https://api.github.com/users/psiinon/followers","following_url":"https://api.github.com/users/psiinon/following{/other_user}","gists_url":"https://api.github.com/users/psiinon/gists{/gist_id}","starred_url":"https://api.github.com/users/psiinon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psiinon/subscriptions","organizations_url":"https://api.github.com/users/psiinon/orgs","repos_url":"https://api.github.com/users/psiinon/repos","events_url":"https://api.github.com/users/psiinon/events{/privacy}","received_events_url":"https://api.github.com/users/psiinon/received_events","type":"User","site_admin":false},"repo":{"id":36720860,"name":"zap-extensions","full_name":"psiinon/zap-extensions","owner":{"login":"psiinon","id":1081115,"avatar_url":"https://avatars.githubusercontent.com/u/1081115?v=3","gravatar_id":"","url":"https://api.github.com/users/psiinon","html_url":"https://github.com/psiinon","followers_url":"https://api.github.com/users/psiinon/followers","following_url":"https://api.github.com/users/psiinon/following{/other_user}","gists_url":"https://api.github.com/users/psiinon/gists{/gist_id}","starred_url":"https://api.github.com/users/psiinon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psiinon/subscriptions","organizations_url":"https://api.github.com/users/psiinon/orgs","repos_url":"https://api.github.com/users/psiinon/repos","events_url":"https://api.github.com/users/psiinon/events{/privacy}","received_events_url":"https://api.github.com/users/psiinon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/psiinon/zap-extensions","description":"OWASP ZAP Add-ons","fork":true,"url":"https://api.github.com/repos/psiinon/zap-extensions","forks_url":"https://api.github.com/repos/psiinon/zap-extensions/forks","keys_url":"https://api.github.com/repos/psiinon/zap-extensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/psiinon/zap-extensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/psiinon/zap-extensions/teams","hooks_url":"https://api.github.com/repos/psiinon/zap-extensions/hooks","issue_events_url":"https://api.github.com/repos/psiinon/zap-extensions/issues/events{/number}","events_url":"https://api.github.com/repos/psiinon/zap-extensions/events","assignees_url":"https://api.github.com/repos/psiinon/zap-extensions/assignees{/user}","branches_url":"https://api.github.com/repos/psiinon/zap-extensions/branches{/branch}","tags_url":"https://api.github.com/repos/psiinon/zap-extensions/tags","blobs_url":"https://api.github.com/repos/psiinon/zap-extensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/psiinon/zap-extensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/psiinon/zap-extensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/psiinon/zap-extensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/psiinon/zap-extensions/statuses/{sha}","languages_url":"https://api.github.com/repos/psiinon/zap-extensions/languages","stargazers_url":"https://api.github.com/repos/psiinon/zap-extensions/stargazers","contributors_url":"https://api.github.com/repos/psiinon/zap-extensions/contributors","subscribers_url":"https://api.github.com/repos/psiinon/zap-extensions/subscribers","subscription_url":"https://api.github.com/repos/psiinon/zap-extensions/subscription","commits_url":"https://api.github.com/repos/psiinon/zap-extensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/psiinon/zap-extensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/psiinon/zap-extensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/psiinon/zap-extensions/issues/comments{/number}","contents_url":"https://api.github.com/repos/psiinon/zap-extensions/contents/{+path}","compare_url":"https://api.github.com/repos/psiinon/zap-extensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/psiinon/zap-extensions/merges","archive_url":"https://api.github.com/repos/psiinon/zap-extensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/psiinon/zap-extensions/downloads","issues_url":"https://api.github.com/repos/psiinon/zap-extensions/issues{/number}","pulls_url":"https://api.github.com/repos/psiinon/zap-extensions/pulls{/number}","milestones_url":"https://api.github.com/repos/psiinon/zap-extensions/milestones{/number}","notifications_url":"https://api.github.com/repos/psiinon/zap-extensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/psiinon/zap-extensions/labels{/name}","releases_url":"https://api.github.com/repos/psiinon/zap-extensions/releases{/id}","deployments_url":"https://api.github.com/repos/psiinon/zap-extensions/deployments","created_at":"2015-06-02T08:57:37Z","updated_at":"2016-02-03T14:14:59Z","pushed_at":"2016-08-02T10:34:12Z","git_url":"git://github.com/psiinon/zap-extensions.git","ssh_url":"git@github.com:psiinon/zap-extensions.git","clone_url":"https://github.com/psiinon/zap-extensions.git","svn_url":"https://github.com/psiinon/zap-extensions","homepage":"","size":655346,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zaproxy:master","ref":"master","sha":"f4f1bc998336496c683ab71407182b7a786b3535","user":{"login":"zaproxy","id":6716868,"avatar_url":"https://avatars.githubusercontent.com/u/6716868?v=3","gravatar_id":"","url":"https://api.github.com/users/zaproxy","html_url":"https://github.com/zaproxy","followers_url":"https://api.github.com/users/zaproxy/followers","following_url":"https://api.github.com/users/zaproxy/following{/other_user}","gists_url":"https://api.github.com/users/zaproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/zaproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaproxy/subscriptions","organizations_url":"https://api.github.com/users/zaproxy/orgs","repos_url":"https://api.github.com/users/zaproxy/repos","events_url":"https://api.github.com/users/zaproxy/events{/privacy}","received_events_url":"https://api.github.com/users/zaproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":35210580,"name":"zap-extensions","full_name":"zaproxy/zap-extensions","owner":{"login":"zaproxy","id":6716868,"avatar_url":"https://avatars.githubusercontent.com/u/6716868?v=3","gravatar_id":"","url":"https://api.github.com/users/zaproxy","html_url":"https://github.com/zaproxy","followers_url":"https://api.github.com/users/zaproxy/followers","following_url":"https://api.github.com/users/zaproxy/following{/other_user}","gists_url":"https://api.github.com/users/zaproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/zaproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaproxy/subscriptions","organizations_url":"https://api.github.com/users/zaproxy/orgs","repos_url":"https://api.github.com/users/zaproxy/repos","events_url":"https://api.github.com/users/zaproxy/events{/privacy}","received_events_url":"https://api.github.com/users/zaproxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zaproxy/zap-extensions","description":"OWASP ZAP Add-ons","fork":false,"url":"https://api.github.com/repos/zaproxy/zap-extensions","forks_url":"https://api.github.com/repos/zaproxy/zap-extensions/forks","keys_url":"https://api.github.com/repos/zaproxy/zap-extensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zaproxy/zap-extensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zaproxy/zap-extensions/teams","hooks_url":"https://api.github.com/repos/zaproxy/zap-extensions/hooks","issue_events_url":"https://api.github.com/repos/zaproxy/zap-extensions/issues/events{/number}","events_url":"https://api.github.com/repos/zaproxy/zap-extensions/events","assignees_url":"https://api.github.com/repos/zaproxy/zap-extensions/assignees{/user}","branches_url":"https://api.github.com/repos/zaproxy/zap-extensions/branches{/branch}","tags_url":"https://api.github.com/repos/zaproxy/zap-extensions/tags","blobs_url":"https://api.github.com/repos/zaproxy/zap-extensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zaproxy/zap-extensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zaproxy/zap-extensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/zaproxy/zap-extensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zaproxy/zap-extensions/statuses/{sha}","languages_url":"https://api.github.com/repos/zaproxy/zap-extensions/languages","stargazers_url":"https://api.github.com/repos/zaproxy/zap-extensions/stargazers","contributors_url":"https://api.github.com/repos/zaproxy/zap-extensions/contributors","subscribers_url":"https://api.github.com/repos/zaproxy/zap-extensions/subscribers","subscription_url":"https://api.github.com/repos/zaproxy/zap-extensions/subscription","commits_url":"https://api.github.com/repos/zaproxy/zap-extensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/zaproxy/zap-extensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/zaproxy/zap-extensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/zaproxy/zap-extensions/issues/comments{/number}","contents_url":"https://api.github.com/repos/zaproxy/zap-extensions/contents/{+path}","compare_url":"https://api.github.com/repos/zaproxy/zap-extensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zaproxy/zap-extensions/merges","archive_url":"https://api.github.com/repos/zaproxy/zap-extensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zaproxy/zap-extensions/downloads","issues_url":"https://api.github.com/repos/zaproxy/zap-extensions/issues{/number}","pulls_url":"https://api.github.com/repos/zaproxy/zap-extensions/pulls{/number}","milestones_url":"https://api.github.com/repos/zaproxy/zap-extensions/milestones{/number}","notifications_url":"https://api.github.com/repos/zaproxy/zap-extensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zaproxy/zap-extensions/labels{/name}","releases_url":"https://api.github.com/repos/zaproxy/zap-extensions/releases{/id}","deployments_url":"https://api.github.com/repos/zaproxy/zap-extensions/deployments","created_at":"2015-05-07T09:17:13Z","updated_at":"2016-07-28T13:30:37Z","pushed_at":"2016-08-02T10:34:13Z","git_url":"git://github.com/zaproxy/zap-extensions.git","ssh_url":"git@github.com:zaproxy/zap-extensions.git","clone_url":"https://github.com/zaproxy/zap-extensions.git","svn_url":"https://github.com/zaproxy/zap-extensions","homepage":"","size":677740,"stargazers_count":84,"watchers_count":84,"language":"HTML","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":100,"mirror_url":null,"open_issues_count":11,"forks":100,"open_issues":11,"watchers":84,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zaproxy/zap-extensions/pulls/473"},"html":{"href":"https://github.com/zaproxy/zap-extensions/pull/473"},"issue":{"href":"https://api.github.com/repos/zaproxy/zap-extensions/issues/473"},"comments":{"href":"https://api.github.com/repos/zaproxy/zap-extensions/issues/473/comments"},"review_comments":{"href":"https://api.github.com/repos/zaproxy/zap-extensions/pulls/473/comments"},"review_comment":{"href":"https://api.github.com/repos/zaproxy/zap-extensions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zaproxy/zap-extensions/pulls/473/commits"},"statuses":{"href":"https://api.github.com/repos/zaproxy/zap-extensions/statuses/80f831c861a502332e3e8bffa21009a10c1190e4"}}}}
{"actor":{"display_login":"kingthorin"}}