{"action":"created","issue":{"url":"https://api.github.com/repos/kodi-game/game.libretro.pcsx-rearmed/issues/2","labels_url":"https://api.github.com/repos/kodi-game/game.libretro.pcsx-rearmed/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/kodi-game/game.libretro.pcsx-rearmed/issues/2/comments","events_url":"https://api.github.com/repos/kodi-game/game.libretro.pcsx-rearmed/issues/2/events","html_url":"https://github.com/kodi-game/game.libretro.pcsx-rearmed/issues/2","id":125700978,"number":2,"title":"buttonmap","user":{"login":"zach-morris","id":12554283,"avatar_url":"https://avatars.githubusercontent.com/u/12554283?v=3","gravatar_id":"","url":"https://api.github.com/users/zach-morris","html_url":"https://github.com/zach-morris","followers_url":"https://api.github.com/users/zach-morris/followers","following_url":"https://api.github.com/users/zach-morris/following{/other_user}","gists_url":"https://api.github.com/users/zach-morris/gists{/gist_id}","starred_url":"https://api.github.com/users/zach-morris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zach-morris/subscriptions","organizations_url":"https://api.github.com/users/zach-morris/orgs","repos_url":"https://api.github.com/users/zach-morris/repos","events_url":"https://api.github.com/users/zach-morris/events{/privacy}","received_events_url":"https://api.github.com/users/zach-morris/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-01-08T21:44:51Z","updated_at":"2016-01-10T18:46:14Z","closed_at":"2016-01-09T21:06:33Z","body":"[buttonmap.xml](https://github.com/kodi-game/game.libretro.pcsx-rearmed/blob/master/game.libretro.pcsx-rearmed/resources/buttonmap.xml#L14) mapping error:\r\n```\r\n\t\t<feature name=\"l1\" mapto=\"l\"/>\r\n\t\t<feature name=\"r1\" mapto=\"r\"/>\r\n\t\t<feature name=\"l2\" mapto=\"l2\"/>\r\n\t\t<feature name=\"r2\" mapto=\"r2\"/>\r\n```\r\nshould be\r\n```\r\n\t\t<feature name=\"l1\" mapto=\"leftbumper\"/>\r\n\t\t<feature name=\"r1\" mapto=\"rightbumper\"/>\r\n\t\t<feature name=\"l2\" mapto=\"lefttrigger\"/>\r\n\t\t<feature name=\"r2\" mapto=\"righttrigger\"/>\r\n```"},"comment":{"url":"https://api.github.com/repos/kodi-game/game.libretro.pcsx-rearmed/issues/comments/170381276","html_url":"https://github.com/kodi-game/game.libretro.pcsx-rearmed/issues/2#issuecomment-170381276","issue_url":"https://api.github.com/repos/kodi-game/game.libretro.pcsx-rearmed/issues/2","id":170381276,"user":{"login":"zach-morris","id":12554283,"avatar_url":"https://avatars.githubusercontent.com/u/12554283?v=3","gravatar_id":"","url":"https://api.github.com/users/zach-morris","html_url":"https://github.com/zach-morris","followers_url":"https://api.github.com/users/zach-morris/followers","following_url":"https://api.github.com/users/zach-morris/following{/other_user}","gists_url":"https://api.github.com/users/zach-morris/gists{/gist_id}","starred_url":"https://api.github.com/users/zach-morris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zach-morris/subscriptions","organizations_url":"https://api.github.com/users/zach-morris/orgs","repos_url":"https://api.github.com/users/zach-morris/repos","events_url":"https://api.github.com/users/zach-morris/events{/privacy}","received_events_url":"https://api.github.com/users/zach-morris/received_events","type":"User","site_admin":false},"created_at":"2016-01-10T18:46:14Z","updated_at":"2016-01-10T18:46:14Z","body":"Shouldn't the above be?\r\n```\r\n      if (strFeatureName == \"lefttrigger\")   return RETRO_DEVICE_ID_JOYPAD_L2;\r\n      if (strFeatureName == \"righttrigger\")  return RETRO_DEVICE_ID_JOYPAD_R2;\r\n      if (strFeatureName == \"leftbumper\")    return RETRO_DEVICE_ID_JOYPAD_L;\r\n      if (strFeatureName == \"rightbumper\")   return RETRO_DEVICE_ID_JOYPAD_R;\r\n      if (strFeatureName == \"up\")           return RETRO_DEVICE_ID_JOYPAD_UP;\r\n      if (strFeatureName == \"down\")         return RETRO_DEVICE_ID_JOYPAD_DOWN;\r\n      if (strFeatureName == \"right\")        return RETRO_DEVICE_ID_JOYPAD_RIGHT;\r\n      if (strFeatureName == \"left\")         return RETRO_DEVICE_ID_JOYPAD_LEFT;\r\n      if (strFeatureName == \"leftthumb\")  return RETRO_DEVICE_ID_JOYPAD_L3;\r\n      if (strFeatureName == \"rightthumb\") return RETRO_DEVICE_ID_JOYPAD_R3;\r\n```\r\n\r\nLeft and Right thumb work for naming (a picture will eventually say all thats needed I think).  As someone who grew up with a PS, L3 and R3 have always been what they've been called for me.\r\n\r\nAlso, take a look at [these images](https://github.com/RetroPie/RetroPie-Setup/wiki/RetroArch-Configuration#default-core-controls-for-all-emulators) as they do a pretty good job of showing the controller and at the same time showing what they should map to in libretro."}}