{"action":"created","comment":{"url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/pulls/comments/59832908","id":59832908,"diff_hunk":"@@ -87,7 +93,7 @@ var cacheProvision = function(log, params) {\n         if (_.indexOf(regions, loc) != -1) return true;\n \n         log.error('Redis Cache Provision: Location is not correct');","path":"lib/services/azurerediscache/cmd-provision.js","position":27,"original_position":27,"commit_id":"46f3361c6c88168781080f02da797d122f5be7a9","original_commit_id":"46f3361c6c88168781080f02da797d122f5be7a9","user":{"login":"bingosummer","id":4787647,"avatar_url":"https://avatars.githubusercontent.com/u/4787647?v=3","gravatar_id":"","url":"https://api.github.com/users/bingosummer","html_url":"https://github.com/bingosummer","followers_url":"https://api.github.com/users/bingosummer/followers","following_url":"https://api.github.com/users/bingosummer/following{/other_user}","gists_url":"https://api.github.com/users/bingosummer/gists{/gist_id}","starred_url":"https://api.github.com/users/bingosummer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bingosummer/subscriptions","organizations_url":"https://api.github.com/users/bingosummer/orgs","repos_url":"https://api.github.com/users/bingosummer/repos","events_url":"https://api.github.com/users/bingosummer/events{/privacy}","received_events_url":"https://api.github.com/users/bingosummer/received_events","type":"User","site_admin":false},"body":"Should we check the location in our codes? Or let Azure check the location?\r\n\r\nIf our codes check the location, we should make sure all the locations are listed in the array. For instance, if users want to create a redis cache service in China East, it will throw the error `Redis Cache Provision: Location is not correct`.","created_at":"2016-04-15T06:47:36Z","updated_at":"2016-04-15T06:47:36Z","html_url":"https://github.com/bingosummer/meta-azure-service-broker/pull/11#discussion_r59832908","pull_request_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/pulls/comments/59832908"},"html":{"href":"https://github.com/bingosummer/meta-azure-service-broker/pull/11#discussion_r59832908"},"pull_request":{"href":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/pulls/11","id":66527773,"html_url":"https://github.com/bingosummer/meta-azure-service-broker/pull/11","diff_url":"https://github.com/bingosummer/meta-azure-service-broker/pull/11.diff","patch_url":"https://github.com/bingosummer/meta-azure-service-broker/pull/11.patch","issue_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/issues/11","number":11,"state":"open","locked":false,"title":"Doc db merge","user":{"login":"sebastus","id":1289132,"avatar_url":"https://avatars.githubusercontent.com/u/1289132?v=3","gravatar_id":"","url":"https://api.github.com/users/sebastus","html_url":"https://github.com/sebastus","followers_url":"https://api.github.com/users/sebastus/followers","following_url":"https://api.github.com/users/sebastus/following{/other_user}","gists_url":"https://api.github.com/users/sebastus/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastus/subscriptions","organizations_url":"https://api.github.com/users/sebastus/orgs","repos_url":"https://api.github.com/users/sebastus/repos","events_url":"https://api.github.com/users/sebastus/events{/privacy}","received_events_url":"https://api.github.com/users/sebastus/received_events","type":"User","site_admin":false},"body":"I merged everything from my local branch with changes that you made to a few files (package.json, testlist, etc)  need to confirm that my edits of your changes are correct.  for example, I checked the format of \"license\" in package.json and fixed it according to spec @ npm documentation.  Also, I require a \"engines\" >5.0 which I changed as well.","created_at":"2016-04-14T18:03:15Z","updated_at":"2016-04-15T06:47:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9716a52403058e8551a19148798c6465a6566337","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/pulls/11/commits","review_comments_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/pulls/11/comments","review_comment_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/issues/11/comments","statuses_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/statuses/46f3361c6c88168781080f02da797d122f5be7a9","head":{"label":"sebastus:DocDb-merge","ref":"DocDb-merge","sha":"46f3361c6c88168781080f02da797d122f5be7a9","user":{"login":"sebastus","id":1289132,"avatar_url":"https://avatars.githubusercontent.com/u/1289132?v=3","gravatar_id":"","url":"https://api.github.com/users/sebastus","html_url":"https://github.com/sebastus","followers_url":"https://api.github.com/users/sebastus/followers","following_url":"https://api.github.com/users/sebastus/following{/other_user}","gists_url":"https://api.github.com/users/sebastus/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastus/subscriptions","organizations_url":"https://api.github.com/users/sebastus/orgs","repos_url":"https://api.github.com/users/sebastus/repos","events_url":"https://api.github.com/users/sebastus/events{/privacy}","received_events_url":"https://api.github.com/users/sebastus/received_events","type":"User","site_admin":false},"repo":{"id":54423589,"name":"meta-azure-service-broker","full_name":"sebastus/meta-azure-service-broker","owner":{"login":"sebastus","id":1289132,"avatar_url":"https://avatars.githubusercontent.com/u/1289132?v=3","gravatar_id":"","url":"https://api.github.com/users/sebastus","html_url":"https://github.com/sebastus","followers_url":"https://api.github.com/users/sebastus/followers","following_url":"https://api.github.com/users/sebastus/following{/other_user}","gists_url":"https://api.github.com/users/sebastus/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastus/subscriptions","organizations_url":"https://api.github.com/users/sebastus/orgs","repos_url":"https://api.github.com/users/sebastus/repos","events_url":"https://api.github.com/users/sebastus/events{/privacy}","received_events_url":"https://api.github.com/users/sebastus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sebastus/meta-azure-service-broker","description":"","fork":true,"url":"https://api.github.com/repos/sebastus/meta-azure-service-broker","forks_url":"https://api.github.com/repos/sebastus/meta-azure-service-broker/forks","keys_url":"https://api.github.com/repos/sebastus/meta-azure-service-broker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sebastus/meta-azure-service-broker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sebastus/meta-azure-service-broker/teams","hooks_url":"https://api.github.com/repos/sebastus/meta-azure-service-broker/hooks","issue_events_url":"https://api.github.com/repos/sebastus/meta-azure-service-broker/issues/events{/number}","events_url":"https://api.github.com/repos/sebastus/meta-azure-service-broker/events","assignees_url":"https://api.github.com/repos/sebastus/meta-azure-service-broker/assignees{/user}","branches_url":"https://api.github.com/repos/sebastus/meta-azure-service-broker/branches{/branch}","tags_url":"https://api.github.com/repos/sebastus/meta-azure-service-broker/tags","blobs_url":"https://api.github.com/repos/sebastus/meta-azure-service-broker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sebastus/meta-azure-service-broker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sebastus/meta-azure-service-broker/git/refs{/sha}","trees_url":"https://api.github.com/repos/sebastus/meta-azure-service-broker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sebastus/meta-azure-service-broker/statuses/{sha}","languages_url":"https://api.github.com/repos/sebastus/meta-azure-service-broker/languages","stargazers_url":"https://api.github.com/repos/sebastus/meta-azure-service-broker/stargazers","contributors_url":"https://api.github.com/repos/sebastus/meta-azure-service-broker/contributors","subscribers_url":"https://api.github.com/repos/sebastus/meta-azure-service-broker/subscribers","subscription_url":"https://api.github.com/repos/sebastus/meta-azure-service-broker/subscription","commits_url":"https://api.github.com/repos/sebastus/meta-azure-service-broker/commits{/sha}","git_commits_url":"https://api.github.com/repos/sebastus/meta-azure-service-broker/git/commits{/sha}","comments_url":"https://api.github.com/repos/sebastus/meta-azure-service-broker/comments{/number}","issue_comment_url":"https://api.github.com/repos/sebastus/meta-azure-service-broker/issues/comments{/number}","contents_url":"https://api.github.com/repos/sebastus/meta-azure-service-broker/contents/{+path}","compare_url":"https://api.github.com/repos/sebastus/meta-azure-service-broker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sebastus/meta-azure-service-broker/merges","archive_url":"https://api.github.com/repos/sebastus/meta-azure-service-broker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sebastus/meta-azure-service-broker/downloads","issues_url":"https://api.github.com/repos/sebastus/meta-azure-service-broker/issues{/number}","pulls_url":"https://api.github.com/repos/sebastus/meta-azure-service-broker/pulls{/number}","milestones_url":"https://api.github.com/repos/sebastus/meta-azure-service-broker/milestones{/number}","notifications_url":"https://api.github.com/repos/sebastus/meta-azure-service-broker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sebastus/meta-azure-service-broker/labels{/name}","releases_url":"https://api.github.com/repos/sebastus/meta-azure-service-broker/releases{/id}","deployments_url":"https://api.github.com/repos/sebastus/meta-azure-service-broker/deployments","created_at":"2016-03-21T21:20:46Z","updated_at":"2016-03-21T21:20:47Z","pushed_at":"2016-04-15T03:06:18Z","git_url":"git://github.com/sebastus/meta-azure-service-broker.git","ssh_url":"git@github.com:sebastus/meta-azure-service-broker.git","clone_url":"https://github.com/sebastus/meta-azure-service-broker.git","svn_url":"https://github.com/sebastus/meta-azure-service-broker","homepage":null,"size":130,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bingosummer:master","ref":"master","sha":"480053502828f3b86279525eb6ee7dbd58f601fc","user":{"login":"bingosummer","id":4787647,"avatar_url":"https://avatars.githubusercontent.com/u/4787647?v=3","gravatar_id":"","url":"https://api.github.com/users/bingosummer","html_url":"https://github.com/bingosummer","followers_url":"https://api.github.com/users/bingosummer/followers","following_url":"https://api.github.com/users/bingosummer/following{/other_user}","gists_url":"https://api.github.com/users/bingosummer/gists{/gist_id}","starred_url":"https://api.github.com/users/bingosummer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bingosummer/subscriptions","organizations_url":"https://api.github.com/users/bingosummer/orgs","repos_url":"https://api.github.com/users/bingosummer/repos","events_url":"https://api.github.com/users/bingosummer/events{/privacy}","received_events_url":"https://api.github.com/users/bingosummer/received_events","type":"User","site_admin":false},"repo":{"id":53308130,"name":"meta-azure-service-broker","full_name":"bingosummer/meta-azure-service-broker","owner":{"login":"bingosummer","id":4787647,"avatar_url":"https://avatars.githubusercontent.com/u/4787647?v=3","gravatar_id":"","url":"https://api.github.com/users/bingosummer","html_url":"https://github.com/bingosummer","followers_url":"https://api.github.com/users/bingosummer/followers","following_url":"https://api.github.com/users/bingosummer/following{/other_user}","gists_url":"https://api.github.com/users/bingosummer/gists{/gist_id}","starred_url":"https://api.github.com/users/bingosummer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bingosummer/subscriptions","organizations_url":"https://api.github.com/users/bingosummer/orgs","repos_url":"https://api.github.com/users/bingosummer/repos","events_url":"https://api.github.com/users/bingosummer/events{/privacy}","received_events_url":"https://api.github.com/users/bingosummer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bingosummer/meta-azure-service-broker","description":"","fork":false,"url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker","forks_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/forks","keys_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/teams","hooks_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/hooks","issue_events_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/issues/events{/number}","events_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/events","assignees_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/assignees{/user}","branches_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/branches{/branch}","tags_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/tags","blobs_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/git/refs{/sha}","trees_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/statuses/{sha}","languages_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/languages","stargazers_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/stargazers","contributors_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/contributors","subscribers_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/subscribers","subscription_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/subscription","commits_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/commits{/sha}","git_commits_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/git/commits{/sha}","comments_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/comments{/number}","issue_comment_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/issues/comments{/number}","contents_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/contents/{+path}","compare_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/merges","archive_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/downloads","issues_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/issues{/number}","pulls_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/pulls{/number}","milestones_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/milestones{/number}","notifications_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/labels{/name}","releases_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/releases{/id}","deployments_url":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/deployments","created_at":"2016-03-07T08:20:46Z","updated_at":"2016-03-08T05:27:42Z","pushed_at":"2016-04-14T18:03:15Z","git_url":"git://github.com/bingosummer/meta-azure-service-broker.git","ssh_url":"git@github.com:bingosummer/meta-azure-service-broker.git","clone_url":"https://github.com/bingosummer/meta-azure-service-broker.git","svn_url":"https://github.com/bingosummer/meta-azure-service-broker","homepage":null,"size":141,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/pulls/11"},"html":{"href":"https://github.com/bingosummer/meta-azure-service-broker/pull/11"},"issue":{"href":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/issues/11"},"comments":{"href":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/bingosummer/meta-azure-service-broker/statuses/46f3361c6c88168781080f02da797d122f5be7a9"}}}}