{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/comments/87174482","pull_request_review_id":7795845,"id":87174482,"diff_hunk":"@@ -110,10 +101,21 @@\n         enabled: yes\n       when: is_systemd\n \n-    - name: select a running monitor\n+    - name: set mon_host_count\n+      set_fact: mon_host_count={{ groups.mons | length }}\n+","path":"infrastructure-playbooks/rolling_update.yml","position":46,"original_position":46,"commit_id":"cce0f57dce1a81af2d726a51ab0de4cbed46cace","original_commit_id":"cce0f57dce1a81af2d726a51ab0de4cbed46cace","user":{"login":"leseb","id":912735,"avatar_url":"https://avatars.githubusercontent.com/u/912735?v=3","gravatar_id":"","url":"https://api.github.com/users/leseb","html_url":"https://github.com/leseb","followers_url":"https://api.github.com/users/leseb/followers","following_url":"https://api.github.com/users/leseb/following{/other_user}","gists_url":"https://api.github.com/users/leseb/gists{/gist_id}","starred_url":"https://api.github.com/users/leseb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leseb/subscriptions","organizations_url":"https://api.github.com/users/leseb/orgs","repos_url":"https://api.github.com/users/leseb/repos","events_url":"https://api.github.com/users/leseb/events{/privacy}","received_events_url":"https://api.github.com/users/leseb/received_events","type":"User","site_admin":false},"body":"can we prompt a message if `mon_host_count=1`? Something like: \"are you sure you want to continue?\"","created_at":"2016-11-09T11:22:43Z","updated_at":"2016-11-09T11:22:43Z","html_url":"https://github.com/ceph/ceph-ansible/pull/1077#discussion_r87174482","pull_request_url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/1077","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/comments/87174482"},"html":{"href":"https://github.com/ceph/ceph-ansible/pull/1077#discussion_r87174482"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/1077"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/1077","id":92476872,"html_url":"https://github.com/ceph/ceph-ansible/pull/1077","diff_url":"https://github.com/ceph/ceph-ansible/pull/1077.diff","patch_url":"https://github.com/ceph/ceph-ansible/pull/1077.patch","issue_url":"https://api.github.com/repos/ceph/ceph-ansible/issues/1077","number":1077,"state":"open","locked":false,"title":"Support containerized rolling update","user":{"login":"font","id":3596535,"avatar_url":"https://avatars.githubusercontent.com/u/3596535?v=3","gravatar_id":"","url":"https://api.github.com/users/font","html_url":"https://github.com/font","followers_url":"https://api.github.com/users/font/followers","following_url":"https://api.github.com/users/font/following{/other_user}","gists_url":"https://api.github.com/users/font/gists{/gist_id}","starred_url":"https://api.github.com/users/font/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/font/subscriptions","organizations_url":"https://api.github.com/users/font/orgs","repos_url":"https://api.github.com/users/font/repos","events_url":"https://api.github.com/users/font/events{/privacy}","received_events_url":"https://api.github.com/users/font/received_events","type":"User","site_admin":false},"body":"- Update rolling update playbook to support containerized deployments\r\n  for mons, osds, mdss, and rgws\r\n- Skip checking if existing cluster is running when performing a rolling\r\n  update\r\n- Fixed bug where we were failing to start the mds container because it\r\n  was missing the admin keyring. The admin keyring was missing because\r\n  it was not being pushed from the mon host to the ansible host due to\r\n  the keyring not being available before running the copy_configs.yml\r\n  task include file. Now we forcefully wait for the admin keyring to be\r\n  generated before continuing with the copy_configs.yml task include file\r\n- Skip pre_requisite.yml when running on atomic host. This technically\r\n  no longer requires specifying to skip tasks containing the with_pkg tag\r\n- Add missing variables to all.docker.sample\r\n- Misc. cleanup\r\n\r\nSigned-off-by: Ivan Font <ifont@redhat.com>\r\n\r\nThis was tested on CentOS Atomic host.","created_at":"2016-11-06T04:30:10Z","updated_at":"2016-11-09T11:34:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"199e4dc12acceb60aa32c5eaefb1ad05638a03d1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/1077/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/1077/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph-ansible/issues/1077/comments","statuses_url":"https://api.github.com/repos/ceph/ceph-ansible/statuses/cce0f57dce1a81af2d726a51ab0de4cbed46cace","head":{"label":"font:rolling_update","ref":"rolling_update","sha":"cce0f57dce1a81af2d726a51ab0de4cbed46cace","user":{"login":"font","id":3596535,"avatar_url":"https://avatars.githubusercontent.com/u/3596535?v=3","gravatar_id":"","url":"https://api.github.com/users/font","html_url":"https://github.com/font","followers_url":"https://api.github.com/users/font/followers","following_url":"https://api.github.com/users/font/following{/other_user}","gists_url":"https://api.github.com/users/font/gists{/gist_id}","starred_url":"https://api.github.com/users/font/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/font/subscriptions","organizations_url":"https://api.github.com/users/font/orgs","repos_url":"https://api.github.com/users/font/repos","events_url":"https://api.github.com/users/font/events{/privacy}","received_events_url":"https://api.github.com/users/font/received_events","type":"User","site_admin":false},"repo":{"id":60714762,"name":"ceph-ansible","full_name":"font/ceph-ansible","owner":{"login":"font","id":3596535,"avatar_url":"https://avatars.githubusercontent.com/u/3596535?v=3","gravatar_id":"","url":"https://api.github.com/users/font","html_url":"https://github.com/font","followers_url":"https://api.github.com/users/font/followers","following_url":"https://api.github.com/users/font/following{/other_user}","gists_url":"https://api.github.com/users/font/gists{/gist_id}","starred_url":"https://api.github.com/users/font/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/font/subscriptions","organizations_url":"https://api.github.com/users/font/orgs","repos_url":"https://api.github.com/users/font/repos","events_url":"https://api.github.com/users/font/events{/privacy}","received_events_url":"https://api.github.com/users/font/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/font/ceph-ansible","description":"Ansible playbooks for Ceph","fork":true,"url":"https://api.github.com/repos/font/ceph-ansible","forks_url":"https://api.github.com/repos/font/ceph-ansible/forks","keys_url":"https://api.github.com/repos/font/ceph-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/font/ceph-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/font/ceph-ansible/teams","hooks_url":"https://api.github.com/repos/font/ceph-ansible/hooks","issue_events_url":"https://api.github.com/repos/font/ceph-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/font/ceph-ansible/events","assignees_url":"https://api.github.com/repos/font/ceph-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/font/ceph-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/font/ceph-ansible/tags","blobs_url":"https://api.github.com/repos/font/ceph-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/font/ceph-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/font/ceph-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/font/ceph-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/font/ceph-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/font/ceph-ansible/languages","stargazers_url":"https://api.github.com/repos/font/ceph-ansible/stargazers","contributors_url":"https://api.github.com/repos/font/ceph-ansible/contributors","subscribers_url":"https://api.github.com/repos/font/ceph-ansible/subscribers","subscription_url":"https://api.github.com/repos/font/ceph-ansible/subscription","commits_url":"https://api.github.com/repos/font/ceph-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/font/ceph-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/font/ceph-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/font/ceph-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/font/ceph-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/font/ceph-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/font/ceph-ansible/merges","archive_url":"https://api.github.com/repos/font/ceph-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/font/ceph-ansible/downloads","issues_url":"https://api.github.com/repos/font/ceph-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/font/ceph-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/font/ceph-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/font/ceph-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/font/ceph-ansible/labels{/name}","releases_url":"https://api.github.com/repos/font/ceph-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/font/ceph-ansible/deployments","created_at":"2016-06-08T16:58:40Z","updated_at":"2016-06-08T16:58:42Z","pushed_at":"2016-11-06T04:27:36Z","git_url":"git://github.com/font/ceph-ansible.git","ssh_url":"git@github.com:font/ceph-ansible.git","clone_url":"https://github.com/font/ceph-ansible.git","svn_url":"https://github.com/font/ceph-ansible","homepage":null,"size":1857,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"e25042f65ec823e407daca2aadc178c35f922632","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":17373313,"name":"ceph-ansible","full_name":"ceph/ceph-ansible","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph-ansible","description":"Ansible playbooks for Ceph","fork":false,"url":"https://api.github.com/repos/ceph/ceph-ansible","forks_url":"https://api.github.com/repos/ceph/ceph-ansible/forks","keys_url":"https://api.github.com/repos/ceph/ceph-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph-ansible/teams","hooks_url":"https://api.github.com/repos/ceph/ceph-ansible/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph-ansible/events","assignees_url":"https://api.github.com/repos/ceph/ceph-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph-ansible/tags","blobs_url":"https://api.github.com/repos/ceph/ceph-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph-ansible/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph-ansible/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph-ansible/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph-ansible/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph-ansible/subscription","commits_url":"https://api.github.com/repos/ceph/ceph-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph-ansible/merges","archive_url":"https://api.github.com/repos/ceph/ceph-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph-ansible/downloads","issues_url":"https://api.github.com/repos/ceph/ceph-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph-ansible/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph-ansible/deployments","created_at":"2014-03-03T17:12:09Z","updated_at":"2016-11-07T11:06:58Z","pushed_at":"2016-11-09T11:09:01Z","git_url":"git://github.com/ceph/ceph-ansible.git","ssh_url":"git@github.com:ceph/ceph-ansible.git","clone_url":"https://github.com/ceph/ceph-ansible.git","svn_url":"https://github.com/ceph/ceph-ansible","homepage":null,"size":24485,"stargazers_count":334,"watchers_count":334,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":233,"mirror_url":null,"open_issues_count":58,"forks":233,"open_issues":58,"watchers":334,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/1077"},"html":{"href":"https://github.com/ceph/ceph-ansible/pull/1077"},"issue":{"href":"https://api.github.com/repos/ceph/ceph-ansible/issues/1077"},"comments":{"href":"https://api.github.com/repos/ceph/ceph-ansible/issues/1077/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/1077/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/1077/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph-ansible/statuses/cce0f57dce1a81af2d726a51ab0de4cbed46cace"}}}}
{"actor":{"display_login":"leseb"}}