{"action":"created","issue":{"url":"https://api.github.com/repos/spring-projects/spring-boot/issues/5546","repository_url":"https://api.github.com/repos/spring-projects/spring-boot","labels_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/5546/labels{/name}","comments_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/5546/comments","events_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/5546/events","html_url":"https://github.com/spring-projects/spring-boot/pull/5546","id":144969204,"number":5546,"title":"Deprecate constructors with port parameter in UndertowEmbeddedServletContainer","user":{"login":"dreis2211","id":6304496,"avatar_url":"https://avatars.githubusercontent.com/u/6304496?v=3","gravatar_id":"","url":"https://api.github.com/users/dreis2211","html_url":"https://github.com/dreis2211","followers_url":"https://api.github.com/users/dreis2211/followers","following_url":"https://api.github.com/users/dreis2211/following{/other_user}","gists_url":"https://api.github.com/users/dreis2211/gists{/gist_id}","starred_url":"https://api.github.com/users/dreis2211/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dreis2211/subscriptions","organizations_url":"https://api.github.com/users/dreis2211/orgs","repos_url":"https://api.github.com/users/dreis2211/repos","events_url":"https://api.github.com/users/dreis2211/events{/privacy}","received_events_url":"https://api.github.com/users/dreis2211/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"wilkinsona","id":914682,"avatar_url":"https://avatars.githubusercontent.com/u/914682?v=3","gravatar_id":"","url":"https://api.github.com/users/wilkinsona","html_url":"https://github.com/wilkinsona","followers_url":"https://api.github.com/users/wilkinsona/followers","following_url":"https://api.github.com/users/wilkinsona/following{/other_user}","gists_url":"https://api.github.com/users/wilkinsona/gists{/gist_id}","starred_url":"https://api.github.com/users/wilkinsona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilkinsona/subscriptions","organizations_url":"https://api.github.com/users/wilkinsona/orgs","repos_url":"https://api.github.com/users/wilkinsona/repos","events_url":"https://api.github.com/users/wilkinsona/events{/privacy}","received_events_url":"https://api.github.com/users/wilkinsona/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/spring-projects/spring-boot/milestones/58","html_url":"https://github.com/spring-projects/spring-boot/milestones/1.4.0.M2","labels_url":"https://api.github.com/repos/spring-projects/spring-boot/milestones/58/labels","id":1489613,"number":58,"title":"1.4.0.M2","description":"","creator":{"login":"philwebb","id":519772,"avatar_url":"https://avatars.githubusercontent.com/u/519772?v=3","gravatar_id":"","url":"https://api.github.com/users/philwebb","html_url":"https://github.com/philwebb","followers_url":"https://api.github.com/users/philwebb/followers","following_url":"https://api.github.com/users/philwebb/following{/other_user}","gists_url":"https://api.github.com/users/philwebb/gists{/gist_id}","starred_url":"https://api.github.com/users/philwebb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philwebb/subscriptions","organizations_url":"https://api.github.com/users/philwebb/orgs","repos_url":"https://api.github.com/users/philwebb/repos","events_url":"https://api.github.com/users/philwebb/events{/privacy}","received_events_url":"https://api.github.com/users/philwebb/received_events","type":"User","site_admin":false},"open_issues":74,"closed_issues":110,"state":"open","created_at":"2016-01-07T14:25:32Z","updated_at":"2016-04-05T10:27:12Z","due_on":"2016-04-06T07:00:00Z","closed_at":null},"comments":3,"created_at":"2016-03-31T17:40:58Z","updated_at":"2016-04-05T10:27:24Z","closed_at":"2016-04-05T10:27:12Z","pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-boot/pulls/5546","html_url":"https://github.com/spring-projects/spring-boot/pull/5546","diff_url":"https://github.com/spring-projects/spring-boot/pull/5546.diff","patch_url":"https://github.com/spring-projects/spring-boot/pull/5546.patch"},"body":"Hey,\r\n\r\nsince commit e927f52f2674fe0dd85ad2a051b1bb9cacaaf975 respectively #2584 the port field in the UndertowEmbeddedServletContainer was removed, but the parameter stayed although it isn't used anymore. This PR removes the unused parameter.\r\n\r\nI thought about deprecating the constructor first, but decided against it as the container should be instantiated via the factory and not in a standalone-fashion anyways. But if you want I could do it like that. Just let me know.\r\n\r\n- [X] I have signed the CLA\r\n\r\nCheers,\r\nChristoph"},"comment":{"url":"https://api.github.com/repos/spring-projects/spring-boot/issues/comments/205746002","html_url":"https://github.com/spring-projects/spring-boot/pull/5546#issuecomment-205746002","issue_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/5546","id":205746002,"user":{"login":"wilkinsona","id":914682,"avatar_url":"https://avatars.githubusercontent.com/u/914682?v=3","gravatar_id":"","url":"https://api.github.com/users/wilkinsona","html_url":"https://github.com/wilkinsona","followers_url":"https://api.github.com/users/wilkinsona/followers","following_url":"https://api.github.com/users/wilkinsona/following{/other_user}","gists_url":"https://api.github.com/users/wilkinsona/gists{/gist_id}","starred_url":"https://api.github.com/users/wilkinsona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilkinsona/subscriptions","organizations_url":"https://api.github.com/users/wilkinsona/orgs","repos_url":"https://api.github.com/users/wilkinsona/repos","events_url":"https://api.github.com/users/wilkinsona/events{/privacy}","received_events_url":"https://api.github.com/users/wilkinsona/received_events","type":"User","site_admin":false},"created_at":"2016-04-05T10:27:24Z","updated_at":"2016-04-05T10:27:24Z","body":"Merged. Thanks again for the pull request."}}