{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/57364463","id":57364463,"diff_hunk":"@@ -116,22 +115,38 @@ start() {\n \n     cd $ES_HOME\n     echo -n $\"Starting $prog: \"\n-    # if not running, start it up here, usually something like \"daemon $exec\"\n-    daemon --user $ES_USER --pidfile $pidfile $exec -p $pidfile -d -Ees.default.path.home=$ES_HOME -Ees.default.path.logs=$LOG_DIR -Ees.default.path.data=$DATA_DIR -Ees.default.path.conf=$CONF_DIR\n-    retval=$?\n-    echo\n-    [ $retval -eq 0 ] && touch $lockfile\n-    return $retval\n+    # if not running, start it up here.\n+\n+    retval=''\n+    if [ $SUSE ]; then\n+        # SLES uses startproc\n+        startproc -u $ES_USER $exec -p $pidfile -d -Des.default.path.home=$ES_HOME -Des.default.path.logs=$LOG_DIR -Des.default.path.data=$DATA_DIR -Des.default.path.conf=$CONF_DIR &\n+        retval=$?\n+        rc_status -v\n+    else\n+        # For non-SLES usually something like \"daemon $exec\"\n+        daemon --user $ES_USER --pidfile $pidfile $exec -p $pidfile -d -Des.default.path.home=$ES_HOME -Des.default.path.logs=$LOG_DIR -Des.default.path.data=$DATA_DIR -Des.default.path.conf=$CONF_DIR","path":"distribution/rpm/src/main/packaging/init.d/elasticsearch","position":56,"original_position":56,"commit_id":"f65026876a72977f73cb68999a26edac6feb1f29","original_commit_id":"f65026876a72977f73cb68999a26edac6feb1f29","user":{"login":"jasontedor","id":4744941,"avatar_url":"https://avatars.githubusercontent.com/u/4744941?v=3","gravatar_id":"","url":"https://api.github.com/users/jasontedor","html_url":"https://github.com/jasontedor","followers_url":"https://api.github.com/users/jasontedor/followers","following_url":"https://api.github.com/users/jasontedor/following{/other_user}","gists_url":"https://api.github.com/users/jasontedor/gists{/gist_id}","starred_url":"https://api.github.com/users/jasontedor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasontedor/subscriptions","organizations_url":"https://api.github.com/users/jasontedor/orgs","repos_url":"https://api.github.com/users/jasontedor/repos","events_url":"https://api.github.com/users/jasontedor/events{/privacy}","received_events_url":"https://api.github.com/users/jasontedor/received_events","type":"User","site_admin":false},"body":"This stomps the previous change to the init script to pass parameters using `-E`.","created_at":"2016-03-24T18:24:40Z","updated_at":"2016-03-24T18:24:40Z","html_url":"https://github.com/elastic/elasticsearch/pull/12555#discussion_r57364463","pull_request_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/12555","_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/57364463"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/12555#discussion_r57364463"},"pull_request":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/12555"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/12555","id":41223265,"html_url":"https://github.com/elastic/elasticsearch/pull/12555","diff_url":"https://github.com/elastic/elasticsearch/pull/12555.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/12555.patch","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/12555","number":12555,"state":"open","locked":false,"title":"Removed unused lockfile, Added SLES 11 support","user":{"login":"jjfalling","id":1078616,"avatar_url":"https://avatars.githubusercontent.com/u/1078616?v=3","gravatar_id":"","url":"https://api.github.com/users/jjfalling","html_url":"https://github.com/jjfalling","followers_url":"https://api.github.com/users/jjfalling/followers","following_url":"https://api.github.com/users/jjfalling/following{/other_user}","gists_url":"https://api.github.com/users/jjfalling/gists{/gist_id}","starred_url":"https://api.github.com/users/jjfalling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjfalling/subscriptions","organizations_url":"https://api.github.com/users/jjfalling/orgs","repos_url":"https://api.github.com/users/jjfalling/repos","events_url":"https://api.github.com/users/jjfalling/events{/privacy}","received_events_url":"https://api.github.com/users/jjfalling/received_events","type":"User","site_admin":false},"body":"I removed the lockfile as it is not used anywhere and the service manager should take care of the locking. I also added SLES 11 support. \r\nTested on RHEL 6.7 and SLES 11 SP3\r\n\r\nThis fixes #6798 and #9366","created_at":"2015-07-30T11:24:27Z","updated_at":"2016-03-24T18:24:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21256529e9a92dd4d72a19e0c01db10af18bebcd","assignee":{"login":"jjfalling","id":1078616,"avatar_url":"https://avatars.githubusercontent.com/u/1078616?v=3","gravatar_id":"","url":"https://api.github.com/users/jjfalling","html_url":"https://github.com/jjfalling","followers_url":"https://api.github.com/users/jjfalling/followers","following_url":"https://api.github.com/users/jjfalling/following{/other_user}","gists_url":"https://api.github.com/users/jjfalling/gists{/gist_id}","starred_url":"https://api.github.com/users/jjfalling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjfalling/subscriptions","organizations_url":"https://api.github.com/users/jjfalling/orgs","repos_url":"https://api.github.com/users/jjfalling/repos","events_url":"https://api.github.com/users/jjfalling/events{/privacy}","received_events_url":"https://api.github.com/users/jjfalling/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/12555/commits","review_comments_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/12555/comments","review_comment_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/12555/comments","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/f65026876a72977f73cb68999a26edac6feb1f29","head":{"label":"jjfalling:master","ref":"master","sha":"f65026876a72977f73cb68999a26edac6feb1f29","user":{"login":"jjfalling","id":1078616,"avatar_url":"https://avatars.githubusercontent.com/u/1078616?v=3","gravatar_id":"","url":"https://api.github.com/users/jjfalling","html_url":"https://github.com/jjfalling","followers_url":"https://api.github.com/users/jjfalling/followers","following_url":"https://api.github.com/users/jjfalling/following{/other_user}","gists_url":"https://api.github.com/users/jjfalling/gists{/gist_id}","starred_url":"https://api.github.com/users/jjfalling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjfalling/subscriptions","organizations_url":"https://api.github.com/users/jjfalling/orgs","repos_url":"https://api.github.com/users/jjfalling/repos","events_url":"https://api.github.com/users/jjfalling/events{/privacy}","received_events_url":"https://api.github.com/users/jjfalling/received_events","type":"User","site_admin":false},"repo":{"id":39946654,"name":"elasticsearch","full_name":"jjfalling/elasticsearch","owner":{"login":"jjfalling","id":1078616,"avatar_url":"https://avatars.githubusercontent.com/u/1078616?v=3","gravatar_id":"","url":"https://api.github.com/users/jjfalling","html_url":"https://github.com/jjfalling","followers_url":"https://api.github.com/users/jjfalling/followers","following_url":"https://api.github.com/users/jjfalling/following{/other_user}","gists_url":"https://api.github.com/users/jjfalling/gists{/gist_id}","starred_url":"https://api.github.com/users/jjfalling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjfalling/subscriptions","organizations_url":"https://api.github.com/users/jjfalling/orgs","repos_url":"https://api.github.com/users/jjfalling/repos","events_url":"https://api.github.com/users/jjfalling/events{/privacy}","received_events_url":"https://api.github.com/users/jjfalling/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jjfalling/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/jjfalling/elasticsearch","forks_url":"https://api.github.com/repos/jjfalling/elasticsearch/forks","keys_url":"https://api.github.com/repos/jjfalling/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jjfalling/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jjfalling/elasticsearch/teams","hooks_url":"https://api.github.com/repos/jjfalling/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/jjfalling/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/jjfalling/elasticsearch/events","assignees_url":"https://api.github.com/repos/jjfalling/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/jjfalling/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/jjfalling/elasticsearch/tags","blobs_url":"https://api.github.com/repos/jjfalling/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jjfalling/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jjfalling/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/jjfalling/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jjfalling/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/jjfalling/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/jjfalling/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/jjfalling/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/jjfalling/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/jjfalling/elasticsearch/subscription","commits_url":"https://api.github.com/repos/jjfalling/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/jjfalling/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/jjfalling/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/jjfalling/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/jjfalling/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/jjfalling/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jjfalling/elasticsearch/merges","archive_url":"https://api.github.com/repos/jjfalling/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jjfalling/elasticsearch/downloads","issues_url":"https://api.github.com/repos/jjfalling/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/jjfalling/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/jjfalling/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/jjfalling/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jjfalling/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/jjfalling/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/jjfalling/elasticsearch/deployments","created_at":"2015-07-30T11:15:50Z","updated_at":"2016-03-24T12:53:04Z","pushed_at":"2016-03-24T14:33:12Z","git_url":"git://github.com/jjfalling/elasticsearch.git","ssh_url":"git@github.com:jjfalling/elasticsearch.git","clone_url":"https://github.com/jjfalling/elasticsearch.git","svn_url":"https://github.com/jjfalling/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":187570,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"bb364cc793feb57f46dea33fcf4112277da1055a","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":507775,"name":"elasticsearch","full_name":"elastic/elasticsearch","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":false,"url":"https://api.github.com/repos/elastic/elasticsearch","forks_url":"https://api.github.com/repos/elastic/elasticsearch/forks","keys_url":"https://api.github.com/repos/elastic/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/elasticsearch/teams","hooks_url":"https://api.github.com/repos/elastic/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/elasticsearch/events","assignees_url":"https://api.github.com/repos/elastic/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/elasticsearch/tags","blobs_url":"https://api.github.com/repos/elastic/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/elastic/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/elastic/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/elastic/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/elastic/elasticsearch/subscription","commits_url":"https://api.github.com/repos/elastic/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/elasticsearch/merges","archive_url":"https://api.github.com/repos/elastic/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/elasticsearch/downloads","issues_url":"https://api.github.com/repos/elastic/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/elastic/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/elasticsearch/deployments","created_at":"2010-02-08T13:20:56Z","updated_at":"2016-03-24T17:54:05Z","pushed_at":"2016-03-24T18:22:18Z","git_url":"git://github.com/elastic/elasticsearch.git","ssh_url":"git@github.com:elastic/elasticsearch.git","clone_url":"https://github.com/elastic/elasticsearch.git","svn_url":"https://github.com/elastic/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":298612,"stargazers_count":15685,"watchers_count":15685,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5235,"mirror_url":null,"open_issues_count":1071,"forks":5235,"open_issues":1071,"watchers":15685,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/12555"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/12555"},"issue":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/12555"},"comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/12555/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/12555/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/12555/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/elasticsearch/statuses/f65026876a72977f73cb68999a26edac6feb1f29"}}}}