{"action":"created","comment":{"url":"https://api.github.com/repos/ericzundel/zookeeper/pulls/comments/68026587","id":68026587,"diff_hunk":"@@ -0,0 +1,12 @@\n+--- src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java\t(revision 1716354)\n++++ src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java\t(working copy)\n+@@ -148,7 +148,8 @@\n+                 // We check if write interest here because if it is NOT set,\n+                 // nothing is queued, so we can try to send the buffer right\n+                 // away without waking up the selector\n+-                if ((sk.interestOps() & SelectionKey.OP_WRITE) == 0) {","path":"zookeeper-2044.patch","position":7,"original_position":7,"commit_id":"a690e0f7a067dc8ea812727b9d91b379720c1394","original_commit_id":"a690e0f7a067dc8ea812727b9d91b379720c1394","user":{"login":"ericzundel","id":119728,"avatar_url":"https://avatars.githubusercontent.com/u/119728?v=3","gravatar_id":"","url":"https://api.github.com/users/ericzundel","html_url":"https://github.com/ericzundel","followers_url":"https://api.github.com/users/ericzundel/followers","following_url":"https://api.github.com/users/ericzundel/following{/other_user}","gists_url":"https://api.github.com/users/ericzundel/gists{/gist_id}","starred_url":"https://api.github.com/users/ericzundel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericzundel/subscriptions","organizations_url":"https://api.github.com/users/ericzundel/orgs","repos_url":"https://api.github.com/users/ericzundel/repos","events_url":"https://api.github.com/users/ericzundel/events{/privacy}","received_events_url":"https://api.github.com/users/ericzundel/received_events","type":"User","site_admin":false},"body":"I downloaded the patch file and saved it.  There were two there but I thought that one superceded the other but maybe we need both.  All of the comments say that this is a false alarm so maybe just catching the exception and suppressing it is the right thing to do for our own patch.","created_at":"2016-06-22T10:05:33Z","updated_at":"2016-06-22T10:05:33Z","html_url":"https://github.com/ericzundel/zookeeper/pull/1#discussion_r68026587","pull_request_url":"https://api.github.com/repos/ericzundel/zookeeper/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/ericzundel/zookeeper/pulls/comments/68026587"},"html":{"href":"https://github.com/ericzundel/zookeeper/pull/1#discussion_r68026587"},"pull_request":{"href":"https://api.github.com/repos/ericzundel/zookeeper/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/ericzundel/zookeeper/pulls/1","id":74586990,"html_url":"https://github.com/ericzundel/zookeeper/pull/1","diff_url":"https://github.com/ericzundel/zookeeper/pull/1.diff","patch_url":"https://github.com/ericzundel/zookeeper/pull/1.patch","issue_url":"https://api.github.com/repos/ericzundel/zookeeper/issues/1","number":1,"state":"open","locked":false,"title":"Apply patch from ZOOKEEPER-2044 Prevent CancelledKeyException","user":{"login":"ericzundel","id":119728,"avatar_url":"https://avatars.githubusercontent.com/u/119728?v=3","gravatar_id":"","url":"https://api.github.com/users/ericzundel","html_url":"https://github.com/ericzundel","followers_url":"https://api.github.com/users/ericzundel/followers","following_url":"https://api.github.com/users/ericzundel/following{/other_user}","gists_url":"https://api.github.com/users/ericzundel/gists{/gist_id}","starred_url":"https://api.github.com/users/ericzundel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericzundel/subscriptions","organizations_url":"https://api.github.com/users/ericzundel/orgs","repos_url":"https://api.github.com/users/ericzundel/repos","events_url":"https://api.github.com/users/ericzundel/events{/privacy}","received_events_url":"https://api.github.com/users/ericzundel/received_events","type":"User","site_admin":false},"body":"Set also STWO-857 where this pages us for global-zk","created_at":"2016-06-21T10:27:46Z","updated_at":"2016-06-22T10:05:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b1ee28808481fbc35a1e25569450b0d09a2f874c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ericzundel/zookeeper/pulls/1/commits","review_comments_url":"https://api.github.com/repos/ericzundel/zookeeper/pulls/1/comments","review_comment_url":"https://api.github.com/repos/ericzundel/zookeeper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ericzundel/zookeeper/issues/1/comments","statuses_url":"https://api.github.com/repos/ericzundel/zookeeper/statuses/a690e0f7a067dc8ea812727b9d91b379720c1394","head":{"label":"ericzundel:zundel/fix-cancelled-key-exception","ref":"zundel/fix-cancelled-key-exception","sha":"a690e0f7a067dc8ea812727b9d91b379720c1394","user":{"login":"ericzundel","id":119728,"avatar_url":"https://avatars.githubusercontent.com/u/119728?v=3","gravatar_id":"","url":"https://api.github.com/users/ericzundel","html_url":"https://github.com/ericzundel","followers_url":"https://api.github.com/users/ericzundel/followers","following_url":"https://api.github.com/users/ericzundel/following{/other_user}","gists_url":"https://api.github.com/users/ericzundel/gists{/gist_id}","starred_url":"https://api.github.com/users/ericzundel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericzundel/subscriptions","organizations_url":"https://api.github.com/users/ericzundel/orgs","repos_url":"https://api.github.com/users/ericzundel/repos","events_url":"https://api.github.com/users/ericzundel/events{/privacy}","received_events_url":"https://api.github.com/users/ericzundel/received_events","type":"User","site_admin":false},"repo":{"id":61624169,"name":"zookeeper","full_name":"ericzundel/zookeeper","owner":{"login":"ericzundel","id":119728,"avatar_url":"https://avatars.githubusercontent.com/u/119728?v=3","gravatar_id":"","url":"https://api.github.com/users/ericzundel","html_url":"https://github.com/ericzundel","followers_url":"https://api.github.com/users/ericzundel/followers","following_url":"https://api.github.com/users/ericzundel/following{/other_user}","gists_url":"https://api.github.com/users/ericzundel/gists{/gist_id}","starred_url":"https://api.github.com/users/ericzundel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericzundel/subscriptions","organizations_url":"https://api.github.com/users/ericzundel/orgs","repos_url":"https://api.github.com/users/ericzundel/repos","events_url":"https://api.github.com/users/ericzundel/events{/privacy}","received_events_url":"https://api.github.com/users/ericzundel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericzundel/zookeeper","description":"Mirror of Apache Hadoop ZooKeeper","fork":true,"url":"https://api.github.com/repos/ericzundel/zookeeper","forks_url":"https://api.github.com/repos/ericzundel/zookeeper/forks","keys_url":"https://api.github.com/repos/ericzundel/zookeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericzundel/zookeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericzundel/zookeeper/teams","hooks_url":"https://api.github.com/repos/ericzundel/zookeeper/hooks","issue_events_url":"https://api.github.com/repos/ericzundel/zookeeper/issues/events{/number}","events_url":"https://api.github.com/repos/ericzundel/zookeeper/events","assignees_url":"https://api.github.com/repos/ericzundel/zookeeper/assignees{/user}","branches_url":"https://api.github.com/repos/ericzundel/zookeeper/branches{/branch}","tags_url":"https://api.github.com/repos/ericzundel/zookeeper/tags","blobs_url":"https://api.github.com/repos/ericzundel/zookeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericzundel/zookeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericzundel/zookeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericzundel/zookeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericzundel/zookeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/ericzundel/zookeeper/languages","stargazers_url":"https://api.github.com/repos/ericzundel/zookeeper/stargazers","contributors_url":"https://api.github.com/repos/ericzundel/zookeeper/contributors","subscribers_url":"https://api.github.com/repos/ericzundel/zookeeper/subscribers","subscription_url":"https://api.github.com/repos/ericzundel/zookeeper/subscription","commits_url":"https://api.github.com/repos/ericzundel/zookeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericzundel/zookeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericzundel/zookeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericzundel/zookeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericzundel/zookeeper/contents/{+path}","compare_url":"https://api.github.com/repos/ericzundel/zookeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericzundel/zookeeper/merges","archive_url":"https://api.github.com/repos/ericzundel/zookeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericzundel/zookeeper/downloads","issues_url":"https://api.github.com/repos/ericzundel/zookeeper/issues{/number}","pulls_url":"https://api.github.com/repos/ericzundel/zookeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/ericzundel/zookeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/ericzundel/zookeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericzundel/zookeeper/labels{/name}","releases_url":"https://api.github.com/repos/ericzundel/zookeeper/releases{/id}","deployments_url":"https://api.github.com/repos/ericzundel/zookeeper/deployments","created_at":"2016-06-21T10:15:23Z","updated_at":"2016-06-21T10:15:28Z","pushed_at":"2016-06-21T10:32:43Z","git_url":"git://github.com/ericzundel/zookeeper.git","ssh_url":"git@github.com:ericzundel/zookeeper.git","clone_url":"https://github.com/ericzundel/zookeeper.git","svn_url":"https://github.com/ericzundel/zookeeper","homepage":null,"size":22489,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"branch-3.4"}},"base":{"label":"ericzundel:jbr-ssl-context-factory-for-quorum-socket-factory","ref":"jbr-ssl-context-factory-for-quorum-socket-factory","sha":"8b52951a8f446fc2c95bd6cdb3cc3a302a979096","user":{"login":"ericzundel","id":119728,"avatar_url":"https://avatars.githubusercontent.com/u/119728?v=3","gravatar_id":"","url":"https://api.github.com/users/ericzundel","html_url":"https://github.com/ericzundel","followers_url":"https://api.github.com/users/ericzundel/followers","following_url":"https://api.github.com/users/ericzundel/following{/other_user}","gists_url":"https://api.github.com/users/ericzundel/gists{/gist_id}","starred_url":"https://api.github.com/users/ericzundel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericzundel/subscriptions","organizations_url":"https://api.github.com/users/ericzundel/orgs","repos_url":"https://api.github.com/users/ericzundel/repos","events_url":"https://api.github.com/users/ericzundel/events{/privacy}","received_events_url":"https://api.github.com/users/ericzundel/received_events","type":"User","site_admin":false},"repo":{"id":61624169,"name":"zookeeper","full_name":"ericzundel/zookeeper","owner":{"login":"ericzundel","id":119728,"avatar_url":"https://avatars.githubusercontent.com/u/119728?v=3","gravatar_id":"","url":"https://api.github.com/users/ericzundel","html_url":"https://github.com/ericzundel","followers_url":"https://api.github.com/users/ericzundel/followers","following_url":"https://api.github.com/users/ericzundel/following{/other_user}","gists_url":"https://api.github.com/users/ericzundel/gists{/gist_id}","starred_url":"https://api.github.com/users/ericzundel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericzundel/subscriptions","organizations_url":"https://api.github.com/users/ericzundel/orgs","repos_url":"https://api.github.com/users/ericzundel/repos","events_url":"https://api.github.com/users/ericzundel/events{/privacy}","received_events_url":"https://api.github.com/users/ericzundel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericzundel/zookeeper","description":"Mirror of Apache Hadoop ZooKeeper","fork":true,"url":"https://api.github.com/repos/ericzundel/zookeeper","forks_url":"https://api.github.com/repos/ericzundel/zookeeper/forks","keys_url":"https://api.github.com/repos/ericzundel/zookeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericzundel/zookeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericzundel/zookeeper/teams","hooks_url":"https://api.github.com/repos/ericzundel/zookeeper/hooks","issue_events_url":"https://api.github.com/repos/ericzundel/zookeeper/issues/events{/number}","events_url":"https://api.github.com/repos/ericzundel/zookeeper/events","assignees_url":"https://api.github.com/repos/ericzundel/zookeeper/assignees{/user}","branches_url":"https://api.github.com/repos/ericzundel/zookeeper/branches{/branch}","tags_url":"https://api.github.com/repos/ericzundel/zookeeper/tags","blobs_url":"https://api.github.com/repos/ericzundel/zookeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericzundel/zookeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericzundel/zookeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericzundel/zookeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericzundel/zookeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/ericzundel/zookeeper/languages","stargazers_url":"https://api.github.com/repos/ericzundel/zookeeper/stargazers","contributors_url":"https://api.github.com/repos/ericzundel/zookeeper/contributors","subscribers_url":"https://api.github.com/repos/ericzundel/zookeeper/subscribers","subscription_url":"https://api.github.com/repos/ericzundel/zookeeper/subscription","commits_url":"https://api.github.com/repos/ericzundel/zookeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericzundel/zookeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericzundel/zookeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericzundel/zookeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericzundel/zookeeper/contents/{+path}","compare_url":"https://api.github.com/repos/ericzundel/zookeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericzundel/zookeeper/merges","archive_url":"https://api.github.com/repos/ericzundel/zookeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericzundel/zookeeper/downloads","issues_url":"https://api.github.com/repos/ericzundel/zookeeper/issues{/number}","pulls_url":"https://api.github.com/repos/ericzundel/zookeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/ericzundel/zookeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/ericzundel/zookeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericzundel/zookeeper/labels{/name}","releases_url":"https://api.github.com/repos/ericzundel/zookeeper/releases{/id}","deployments_url":"https://api.github.com/repos/ericzundel/zookeeper/deployments","created_at":"2016-06-21T10:15:23Z","updated_at":"2016-06-21T10:15:28Z","pushed_at":"2016-06-21T10:32:43Z","git_url":"git://github.com/ericzundel/zookeeper.git","ssh_url":"git@github.com:ericzundel/zookeeper.git","clone_url":"https://github.com/ericzundel/zookeeper.git","svn_url":"https://github.com/ericzundel/zookeeper","homepage":null,"size":22489,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"branch-3.4"}},"_links":{"self":{"href":"https://api.github.com/repos/ericzundel/zookeeper/pulls/1"},"html":{"href":"https://github.com/ericzundel/zookeeper/pull/1"},"issue":{"href":"https://api.github.com/repos/ericzundel/zookeeper/issues/1"},"comments":{"href":"https://api.github.com/repos/ericzundel/zookeeper/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/ericzundel/zookeeper/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/ericzundel/zookeeper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ericzundel/zookeeper/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/ericzundel/zookeeper/statuses/a690e0f7a067dc8ea812727b9d91b379720c1394"}}}}
{"actor":{"display_login":"ericzundel"}}