{"action":"created","issue":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/9149","repository_url":"https://api.github.com/repos/highfidelity/hifi","labels_url":"https://api.github.com/repos/highfidelity/hifi/issues/9149/labels{/name}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/9149/comments","events_url":"https://api.github.com/repos/highfidelity/hifi/issues/9149/events","html_url":"https://github.com/highfidelity/hifi/pull/9149","id":193441726,"number":9149,"title":"Fix the lighting problem at the outline of the shapes","user":{"login":"samcake","id":2230265,"avatar_url":"https://avatars.githubusercontent.com/u/2230265?v=3","gravatar_id":"","url":"https://api.github.com/users/samcake","html_url":"https://github.com/samcake","followers_url":"https://api.github.com/users/samcake/followers","following_url":"https://api.github.com/users/samcake/following{/other_user}","gists_url":"https://api.github.com/users/samcake/gists{/gist_id}","starred_url":"https://api.github.com/users/samcake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samcake/subscriptions","organizations_url":"https://api.github.com/users/samcake/orgs","repos_url":"https://api.github.com/users/samcake/repos","events_url":"https://api.github.com/users/samcake/events{/privacy}","received_events_url":"https://api.github.com/users/samcake/received_events","type":"User","site_admin":false},"labels":[{"id":412774488,"url":"https://api.github.com/repos/highfidelity/hifi/labels/Critical%20Fix","name":"Critical Fix","color":"fbca04","default":false},{"id":313595519,"url":"https://api.github.com/repos/highfidelity/hifi/labels/QA%20Ready","name":"QA Ready","color":"bfd4f2","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-12-05T08:55:14Z","updated_at":"2016-12-05T18:05:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/9149","html_url":"https://github.com/highfidelity/hifi/pull/9149","diff_url":"https://github.com/highfidelity/hifi/pull/9149.diff","patch_url":"https://github.com/highfidelity/hifi/pull/9149.patch"},"body":"use the depth buffer instead of the Linear depth buffer to evaluate the fragment position from the deferred buffer.\r\n\r\nTest Plan:\r\nCompare the rendering of a shape lit by light entities (spot or point) in this PR vs the RC29 pr (https://github.com/highfidelity/hifi/pull/9145)\r\n\r\nThe problem identified by PIper should not show anymore:\r\nLook at the edges of the avatars in the images. Top image has strange edge artifacts compared to current release.\r\n\r\n![9145_edgeissue](https://cloud.githubusercontent.com/assets/7314019/20861017/5afbbcdc-b97d-11e6-8ed4-82d99ed10a30.png)\r\n\r\n\r\n![current_release](https://cloud.githubusercontent.com/assets/7314019/20861020/61c5fa28-b97d-11e6-89a9-cd2f6c441502.png)\r\n\r\nAnd now with this PR (Matthew's avatar):\r\n![hifi-snap-by-sam-on-2016-12-05_00-58-44](https://cloud.githubusercontent.com/assets/2230265/20878973/633e5dfa-ba86-11e6-875e-520b4574817d.jpg)\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/comments/264928615","html_url":"https://github.com/highfidelity/hifi/pull/9149#issuecomment-264928615","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/9149","id":264928615,"user":{"login":"OmegaHeron","id":8539933,"avatar_url":"https://avatars.githubusercontent.com/u/8539933?v=3","gravatar_id":"","url":"https://api.github.com/users/OmegaHeron","html_url":"https://github.com/OmegaHeron","followers_url":"https://api.github.com/users/OmegaHeron/followers","following_url":"https://api.github.com/users/OmegaHeron/following{/other_user}","gists_url":"https://api.github.com/users/OmegaHeron/gists{/gist_id}","starred_url":"https://api.github.com/users/OmegaHeron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OmegaHeron/subscriptions","organizations_url":"https://api.github.com/users/OmegaHeron/orgs","repos_url":"https://api.github.com/users/OmegaHeron/repos","events_url":"https://api.github.com/users/OmegaHeron/events{/privacy}","received_events_url":"https://api.github.com/users/OmegaHeron/received_events","type":"User","site_admin":false},"created_at":"2016-12-05T18:05:00Z","updated_at":"2016-12-05T18:05:00Z","body":"Running general smoke test and FPS rates now"}}
{"actor":{"display_login":"OmegaHeron"}}