{"action":"created","comment":{"url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/pulls/comments/87352639","pull_request_review_id":7967255,"id":87352639,"diff_hunk":"@@ -12,9 +12,20 @@\n     \"eslint\",\n     \"eslintconfig\"\n   ],\n-  \"main\": \"react.js\",\n+  \"main\": \"index.js\",\n+  \"files\": [\n+    \"base.js\",\n+    \"common.js\",\n+    \"react.js\"\n+  ],\n   \"peerDependencies\": {\n-    \"eslint\": \"^3.9.1\",\n-    \"eslint-plugin-import\": \"^2.2.0\"\n+    \"eslint\": \"^3.9.1\"\n+  },\n+  \"dependencies\": {\n+    \"eslint-config-airbnb\": \"^13.0.0\",\n+    \"eslint-config-airbnb-base\": \"^10.0.1\",","path":"package.json","position":18,"original_position":18,"commit_id":"bde98cd13f2f7cb6d4e7b4d950691a486e0f260e","original_commit_id":"bde98cd13f2f7cb6d4e7b4d950691a486e0f260e","user":{"login":"ryym","id":12684251,"avatar_url":"https://avatars.githubusercontent.com/u/12684251?v=3","gravatar_id":"","url":"https://api.github.com/users/ryym","html_url":"https://github.com/ryym","followers_url":"https://api.github.com/users/ryym/followers","following_url":"https://api.github.com/users/ryym/following{/other_user}","gists_url":"https://api.github.com/users/ryym/gists{/gist_id}","starred_url":"https://api.github.com/users/ryym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryym/subscriptions","organizations_url":"https://api.github.com/users/ryym/orgs","repos_url":"https://api.github.com/users/ryym/repos","events_url":"https://api.github.com/users/ryym/events{/privacy}","received_events_url":"https://api.github.com/users/ryym/received_events","type":"User","site_admin":false},"body":"気づきませんでした! 👍 ","created_at":"2016-11-10T09:04:12Z","updated_at":"2016-11-10T09:04:12Z","html_url":"https://github.com/interfirm/eslint-config-interfirm/pull/4#discussion_r87352639","pull_request_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/interfirm/eslint-config-interfirm/pulls/comments/87352639"},"html":{"href":"https://github.com/interfirm/eslint-config-interfirm/pull/4#discussion_r87352639"},"pull_request":{"href":"https://api.github.com/repos/interfirm/eslint-config-interfirm/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/pulls/4","id":93092279,"html_url":"https://github.com/interfirm/eslint-config-interfirm/pull/4","diff_url":"https://github.com/interfirm/eslint-config-interfirm/pull/4.diff","patch_url":"https://github.com/interfirm/eslint-config-interfirm/pull/4.patch","issue_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/issues/4","number":4,"state":"open","locked":false,"title":"Improve package.json and README","user":{"login":"ryym","id":12684251,"avatar_url":"https://avatars.githubusercontent.com/u/12684251?v=3","gravatar_id":"","url":"https://api.github.com/users/ryym","html_url":"https://github.com/ryym","followers_url":"https://api.github.com/users/ryym/followers","following_url":"https://api.github.com/users/ryym/following{/other_user}","gists_url":"https://api.github.com/users/ryym/gists{/gist_id}","starred_url":"https://api.github.com/users/ryym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryym/subscriptions","organizations_url":"https://api.github.com/users/ryym/orgs","repos_url":"https://api.github.com/users/ryym/repos","events_url":"https://api.github.com/users/ryym/events{/privacy}","received_events_url":"https://api.github.com/users/ryym/received_events","type":"User","site_admin":false},"body":"connect to #3 \r\n\r\n@ybiquitous さんのアドバイスで、`eslint-config-airbnb`などの依存関係を`dependencies`に含める事にしました。こうすれば、他のプロジェクトでは`eslint`と`eslint-config-interfirm`だけをインストールすれば良くなります。","created_at":"2016-11-10T06:08:47Z","updated_at":"2016-11-10T09:04:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f0dc5d59c5f4056da36a772c48d05cae7a3c5b3a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/pulls/4/commits","review_comments_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/pulls/4/comments","review_comment_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/issues/4/comments","statuses_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/statuses/bde98cd13f2f7cb6d4e7b4d950691a486e0f260e","head":{"label":"interfirm:i3-chore","ref":"i3-chore","sha":"bde98cd13f2f7cb6d4e7b4d950691a486e0f260e","user":{"login":"interfirm","id":7741630,"avatar_url":"https://avatars.githubusercontent.com/u/7741630?v=3","gravatar_id":"","url":"https://api.github.com/users/interfirm","html_url":"https://github.com/interfirm","followers_url":"https://api.github.com/users/interfirm/followers","following_url":"https://api.github.com/users/interfirm/following{/other_user}","gists_url":"https://api.github.com/users/interfirm/gists{/gist_id}","starred_url":"https://api.github.com/users/interfirm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interfirm/subscriptions","organizations_url":"https://api.github.com/users/interfirm/orgs","repos_url":"https://api.github.com/users/interfirm/repos","events_url":"https://api.github.com/users/interfirm/events{/privacy}","received_events_url":"https://api.github.com/users/interfirm/received_events","type":"Organization","site_admin":false},"repo":{"id":73153265,"name":"eslint-config-interfirm","full_name":"interfirm/eslint-config-interfirm","owner":{"login":"interfirm","id":7741630,"avatar_url":"https://avatars.githubusercontent.com/u/7741630?v=3","gravatar_id":"","url":"https://api.github.com/users/interfirm","html_url":"https://github.com/interfirm","followers_url":"https://api.github.com/users/interfirm/followers","following_url":"https://api.github.com/users/interfirm/following{/other_user}","gists_url":"https://api.github.com/users/interfirm/gists{/gist_id}","starred_url":"https://api.github.com/users/interfirm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interfirm/subscriptions","organizations_url":"https://api.github.com/users/interfirm/orgs","repos_url":"https://api.github.com/users/interfirm/repos","events_url":"https://api.github.com/users/interfirm/events{/privacy}","received_events_url":"https://api.github.com/users/interfirm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/interfirm/eslint-config-interfirm","description":"ESLint sharable config for INTERFIRM developers","fork":false,"url":"https://api.github.com/repos/interfirm/eslint-config-interfirm","forks_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/forks","keys_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/teams","hooks_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/hooks","issue_events_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/issues/events{/number}","events_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/events","assignees_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/assignees{/user}","branches_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/branches{/branch}","tags_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/tags","blobs_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/git/refs{/sha}","trees_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/statuses/{sha}","languages_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/languages","stargazers_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/stargazers","contributors_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/contributors","subscribers_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/subscribers","subscription_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/subscription","commits_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/commits{/sha}","git_commits_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/git/commits{/sha}","comments_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/comments{/number}","issue_comment_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/issues/comments{/number}","contents_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/contents/{+path}","compare_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/merges","archive_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/downloads","issues_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/issues{/number}","pulls_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/pulls{/number}","milestones_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/milestones{/number}","notifications_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/labels{/name}","releases_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/releases{/id}","deployments_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/deployments","created_at":"2016-11-08T05:44:18Z","updated_at":"2016-11-09T04:28:39Z","pushed_at":"2016-11-10T06:08:48Z","git_url":"git://github.com/interfirm/eslint-config-interfirm.git","ssh_url":"git@github.com:interfirm/eslint-config-interfirm.git","clone_url":"https://github.com/interfirm/eslint-config-interfirm.git","svn_url":"https://github.com/interfirm/eslint-config-interfirm","homepage":null,"size":25,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"interfirm:master","ref":"master","sha":"1b2a514e57e7bc2de2153d15605af7f8f9a4aea1","user":{"login":"interfirm","id":7741630,"avatar_url":"https://avatars.githubusercontent.com/u/7741630?v=3","gravatar_id":"","url":"https://api.github.com/users/interfirm","html_url":"https://github.com/interfirm","followers_url":"https://api.github.com/users/interfirm/followers","following_url":"https://api.github.com/users/interfirm/following{/other_user}","gists_url":"https://api.github.com/users/interfirm/gists{/gist_id}","starred_url":"https://api.github.com/users/interfirm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interfirm/subscriptions","organizations_url":"https://api.github.com/users/interfirm/orgs","repos_url":"https://api.github.com/users/interfirm/repos","events_url":"https://api.github.com/users/interfirm/events{/privacy}","received_events_url":"https://api.github.com/users/interfirm/received_events","type":"Organization","site_admin":false},"repo":{"id":73153265,"name":"eslint-config-interfirm","full_name":"interfirm/eslint-config-interfirm","owner":{"login":"interfirm","id":7741630,"avatar_url":"https://avatars.githubusercontent.com/u/7741630?v=3","gravatar_id":"","url":"https://api.github.com/users/interfirm","html_url":"https://github.com/interfirm","followers_url":"https://api.github.com/users/interfirm/followers","following_url":"https://api.github.com/users/interfirm/following{/other_user}","gists_url":"https://api.github.com/users/interfirm/gists{/gist_id}","starred_url":"https://api.github.com/users/interfirm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interfirm/subscriptions","organizations_url":"https://api.github.com/users/interfirm/orgs","repos_url":"https://api.github.com/users/interfirm/repos","events_url":"https://api.github.com/users/interfirm/events{/privacy}","received_events_url":"https://api.github.com/users/interfirm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/interfirm/eslint-config-interfirm","description":"ESLint sharable config for INTERFIRM developers","fork":false,"url":"https://api.github.com/repos/interfirm/eslint-config-interfirm","forks_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/forks","keys_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/teams","hooks_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/hooks","issue_events_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/issues/events{/number}","events_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/events","assignees_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/assignees{/user}","branches_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/branches{/branch}","tags_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/tags","blobs_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/git/refs{/sha}","trees_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/statuses/{sha}","languages_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/languages","stargazers_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/stargazers","contributors_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/contributors","subscribers_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/subscribers","subscription_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/subscription","commits_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/commits{/sha}","git_commits_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/git/commits{/sha}","comments_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/comments{/number}","issue_comment_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/issues/comments{/number}","contents_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/contents/{+path}","compare_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/merges","archive_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/downloads","issues_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/issues{/number}","pulls_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/pulls{/number}","milestones_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/milestones{/number}","notifications_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/labels{/name}","releases_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/releases{/id}","deployments_url":"https://api.github.com/repos/interfirm/eslint-config-interfirm/deployments","created_at":"2016-11-08T05:44:18Z","updated_at":"2016-11-09T04:28:39Z","pushed_at":"2016-11-10T06:08:48Z","git_url":"git://github.com/interfirm/eslint-config-interfirm.git","ssh_url":"git@github.com:interfirm/eslint-config-interfirm.git","clone_url":"https://github.com/interfirm/eslint-config-interfirm.git","svn_url":"https://github.com/interfirm/eslint-config-interfirm","homepage":null,"size":25,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/interfirm/eslint-config-interfirm/pulls/4"},"html":{"href":"https://github.com/interfirm/eslint-config-interfirm/pull/4"},"issue":{"href":"https://api.github.com/repos/interfirm/eslint-config-interfirm/issues/4"},"comments":{"href":"https://api.github.com/repos/interfirm/eslint-config-interfirm/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/interfirm/eslint-config-interfirm/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/interfirm/eslint-config-interfirm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/interfirm/eslint-config-interfirm/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/interfirm/eslint-config-interfirm/statuses/bde98cd13f2f7cb6d4e7b4d950691a486e0f260e"}}}}
{"actor":{"display_login":"ryym"}}