{"action":"created","comment":{"url":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/comments/51479724","id":51479724,"diff_hunk":"@@ -2666,6 +2666,54 @@ def compact_metadata_test(self):\n             res = cursor.execute(\"SELECT * FROM bar\")\n             assert rows_to_list(res) == [[1, 2]], res\n \n+    def query_compact_tables_during_upgrade_test(self):\n+        \"\"\"\n+        Check that un-upgraded sstables for compact storage tables\n+        can be read after an upgrade. Checks for a regression where\n+        when the coordinator is on < 3.0, a replica at >= 3.0 returns\n+        0 results for any read request. When the >= 3.0 node is\n+        the coordinator, the problem does not manifest. Likewise, if\n+        the data is inserted after the replica is upgraded, or if\n+        upgradesstables is run after upgrade, the query succeeds, so\n+        the issue is with reading legacy format sstables in response to\n+        a legacy format read request\n+        @jira_ticket CASSANDRA-11087\n+        \"\"\"\n+        cursor = self.prepare()\n+        cursor.execute(\"\"\"\n+            CREATE TABLE t1 (\n+                a int PRIMARY KEY,\n+                b int\n+            ) WITH COMPACT STORAGE;\n+        \"\"\")\n+\n+        for i in range(0, 100, 1):\n+            cursor.execute(\"INSERT INTO t1 (a, b) VALUES ({a}, {b})\".format(a=i, b=i))\n+        self.cluster.flush()\n+\n+        def check_read_all(cursor):\n+            read_count = 0\n+            # first read each row separately - obviously, we should be able to retrieve all 100\n+            for i in xrange(100):\n+                res = cursor.execute(\"SELECT * FROM t1 WHERE a = {a}\".format(a=i))\n+                read_count += len(rows_to_list(res))\n+            debug(\"Querying for individual keys retrieved {c} results\".format(c=read_count))\n+            assert read_count == 100","path":"upgrade_tests/cql_tests.py","position":36,"original_position":36,"commit_id":"0ac300285d92dc78d503611c84d674cc90c94037","original_commit_id":"0ac300285d92dc78d503611c84d674cc90c94037","user":{"login":"mambocab","id":3753769,"avatar_url":"https://avatars.githubusercontent.com/u/3753769?v=3","gravatar_id":"","url":"https://api.github.com/users/mambocab","html_url":"https://github.com/mambocab","followers_url":"https://api.github.com/users/mambocab/followers","following_url":"https://api.github.com/users/mambocab/following{/other_user}","gists_url":"https://api.github.com/users/mambocab/gists{/gist_id}","starred_url":"https://api.github.com/users/mambocab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mambocab/subscriptions","organizations_url":"https://api.github.com/users/mambocab/orgs","repos_url":"https://api.github.com/users/mambocab/repos","events_url":"https://api.github.com/users/mambocab/events{/privacy}","received_events_url":"https://api.github.com/users/mambocab/received_events","type":"User","site_admin":false},"body":"Could you please use `self.assertEqual` here, and elsewhere, rather than bare assertions?","created_at":"2016-02-01T21:00:00Z","updated_at":"2016-02-01T21:00:00Z","html_url":"https://github.com/riptano/cassandra-dtest/pull/777#discussion_r51479724","pull_request_url":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/777","_links":{"self":{"href":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/comments/51479724"},"html":{"href":"https://github.com/riptano/cassandra-dtest/pull/777#discussion_r51479724"},"pull_request":{"href":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/777"}}},"pull_request":{"url":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/777","id":57812177,"html_url":"https://github.com/riptano/cassandra-dtest/pull/777","diff_url":"https://github.com/riptano/cassandra-dtest/pull/777.diff","patch_url":"https://github.com/riptano/cassandra-dtest/pull/777.patch","issue_url":"https://api.github.com/repos/riptano/cassandra-dtest/issues/777","number":777,"state":"open","locked":false,"title":"Add test of reading compact tables during upgrade","user":{"login":"beobal","id":32783,"avatar_url":"https://avatars.githubusercontent.com/u/32783?v=3","gravatar_id":"","url":"https://api.github.com/users/beobal","html_url":"https://github.com/beobal","followers_url":"https://api.github.com/users/beobal/followers","following_url":"https://api.github.com/users/beobal/following{/other_user}","gists_url":"https://api.github.com/users/beobal/gists{/gist_id}","starred_url":"https://api.github.com/users/beobal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beobal/subscriptions","organizations_url":"https://api.github.com/users/beobal/orgs","repos_url":"https://api.github.com/users/beobal/repos","events_url":"https://api.github.com/users/beobal/events{/privacy}","received_events_url":"https://api.github.com/users/beobal/received_events","type":"User","site_admin":false},"body":"CASSANDRA-11087","created_at":"2016-02-01T09:04:33Z","updated_at":"2016-02-01T21:00:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4cc6c2a96d64c1267aa8c4d85429d0c3d9fe4cc1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/777/commits","review_comments_url":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/777/comments","review_comment_url":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/riptano/cassandra-dtest/issues/777/comments","statuses_url":"https://api.github.com/repos/riptano/cassandra-dtest/statuses/0ac300285d92dc78d503611c84d674cc90c94037","head":{"label":"beobal:11087","ref":"11087","sha":"0ac300285d92dc78d503611c84d674cc90c94037","user":{"login":"beobal","id":32783,"avatar_url":"https://avatars.githubusercontent.com/u/32783?v=3","gravatar_id":"","url":"https://api.github.com/users/beobal","html_url":"https://github.com/beobal","followers_url":"https://api.github.com/users/beobal/followers","following_url":"https://api.github.com/users/beobal/following{/other_user}","gists_url":"https://api.github.com/users/beobal/gists{/gist_id}","starred_url":"https://api.github.com/users/beobal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beobal/subscriptions","organizations_url":"https://api.github.com/users/beobal/orgs","repos_url":"https://api.github.com/users/beobal/repos","events_url":"https://api.github.com/users/beobal/events{/privacy}","received_events_url":"https://api.github.com/users/beobal/received_events","type":"User","site_admin":false},"repo":{"id":13472609,"name":"cassandra-dtest","full_name":"beobal/cassandra-dtest","owner":{"login":"beobal","id":32783,"avatar_url":"https://avatars.githubusercontent.com/u/32783?v=3","gravatar_id":"","url":"https://api.github.com/users/beobal","html_url":"https://github.com/beobal","followers_url":"https://api.github.com/users/beobal/followers","following_url":"https://api.github.com/users/beobal/following{/other_user}","gists_url":"https://api.github.com/users/beobal/gists{/gist_id}","starred_url":"https://api.github.com/users/beobal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beobal/subscriptions","organizations_url":"https://api.github.com/users/beobal/orgs","repos_url":"https://api.github.com/users/beobal/repos","events_url":"https://api.github.com/users/beobal/events{/privacy}","received_events_url":"https://api.github.com/users/beobal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/beobal/cassandra-dtest","description":"Cassandra Distributed Tests","fork":true,"url":"https://api.github.com/repos/beobal/cassandra-dtest","forks_url":"https://api.github.com/repos/beobal/cassandra-dtest/forks","keys_url":"https://api.github.com/repos/beobal/cassandra-dtest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/beobal/cassandra-dtest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/beobal/cassandra-dtest/teams","hooks_url":"https://api.github.com/repos/beobal/cassandra-dtest/hooks","issue_events_url":"https://api.github.com/repos/beobal/cassandra-dtest/issues/events{/number}","events_url":"https://api.github.com/repos/beobal/cassandra-dtest/events","assignees_url":"https://api.github.com/repos/beobal/cassandra-dtest/assignees{/user}","branches_url":"https://api.github.com/repos/beobal/cassandra-dtest/branches{/branch}","tags_url":"https://api.github.com/repos/beobal/cassandra-dtest/tags","blobs_url":"https://api.github.com/repos/beobal/cassandra-dtest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/beobal/cassandra-dtest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/beobal/cassandra-dtest/git/refs{/sha}","trees_url":"https://api.github.com/repos/beobal/cassandra-dtest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/beobal/cassandra-dtest/statuses/{sha}","languages_url":"https://api.github.com/repos/beobal/cassandra-dtest/languages","stargazers_url":"https://api.github.com/repos/beobal/cassandra-dtest/stargazers","contributors_url":"https://api.github.com/repos/beobal/cassandra-dtest/contributors","subscribers_url":"https://api.github.com/repos/beobal/cassandra-dtest/subscribers","subscription_url":"https://api.github.com/repos/beobal/cassandra-dtest/subscription","commits_url":"https://api.github.com/repos/beobal/cassandra-dtest/commits{/sha}","git_commits_url":"https://api.github.com/repos/beobal/cassandra-dtest/git/commits{/sha}","comments_url":"https://api.github.com/repos/beobal/cassandra-dtest/comments{/number}","issue_comment_url":"https://api.github.com/repos/beobal/cassandra-dtest/issues/comments{/number}","contents_url":"https://api.github.com/repos/beobal/cassandra-dtest/contents/{+path}","compare_url":"https://api.github.com/repos/beobal/cassandra-dtest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/beobal/cassandra-dtest/merges","archive_url":"https://api.github.com/repos/beobal/cassandra-dtest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/beobal/cassandra-dtest/downloads","issues_url":"https://api.github.com/repos/beobal/cassandra-dtest/issues{/number}","pulls_url":"https://api.github.com/repos/beobal/cassandra-dtest/pulls{/number}","milestones_url":"https://api.github.com/repos/beobal/cassandra-dtest/milestones{/number}","notifications_url":"https://api.github.com/repos/beobal/cassandra-dtest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/beobal/cassandra-dtest/labels{/name}","releases_url":"https://api.github.com/repos/beobal/cassandra-dtest/releases{/id}","deployments_url":"https://api.github.com/repos/beobal/cassandra-dtest/deployments","created_at":"2013-10-10T13:51:34Z","updated_at":"2014-04-15T15:26:11Z","pushed_at":"2016-02-01T08:58:41Z","git_url":"git://github.com/beobal/cassandra-dtest.git","ssh_url":"git@github.com:beobal/cassandra-dtest.git","clone_url":"https://github.com/beobal/cassandra-dtest.git","svn_url":"https://github.com/beobal/cassandra-dtest","homepage":"","size":13501,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"riptano:master","ref":"master","sha":"eba2c09b6aec46d8971f194b8d881e91fd352c2c","user":{"login":"riptano","id":275430,"avatar_url":"https://avatars.githubusercontent.com/u/275430?v=3","gravatar_id":"","url":"https://api.github.com/users/riptano","html_url":"https://github.com/riptano","followers_url":"https://api.github.com/users/riptano/followers","following_url":"https://api.github.com/users/riptano/following{/other_user}","gists_url":"https://api.github.com/users/riptano/gists{/gist_id}","starred_url":"https://api.github.com/users/riptano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riptano/subscriptions","organizations_url":"https://api.github.com/users/riptano/orgs","repos_url":"https://api.github.com/users/riptano/repos","events_url":"https://api.github.com/users/riptano/events{/privacy}","received_events_url":"https://api.github.com/users/riptano/received_events","type":"Organization","site_admin":false},"repo":{"id":2674774,"name":"cassandra-dtest","full_name":"riptano/cassandra-dtest","owner":{"login":"riptano","id":275430,"avatar_url":"https://avatars.githubusercontent.com/u/275430?v=3","gravatar_id":"","url":"https://api.github.com/users/riptano","html_url":"https://github.com/riptano","followers_url":"https://api.github.com/users/riptano/followers","following_url":"https://api.github.com/users/riptano/following{/other_user}","gists_url":"https://api.github.com/users/riptano/gists{/gist_id}","starred_url":"https://api.github.com/users/riptano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riptano/subscriptions","organizations_url":"https://api.github.com/users/riptano/orgs","repos_url":"https://api.github.com/users/riptano/repos","events_url":"https://api.github.com/users/riptano/events{/privacy}","received_events_url":"https://api.github.com/users/riptano/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/riptano/cassandra-dtest","description":"Cassandra Distributed Tests","fork":false,"url":"https://api.github.com/repos/riptano/cassandra-dtest","forks_url":"https://api.github.com/repos/riptano/cassandra-dtest/forks","keys_url":"https://api.github.com/repos/riptano/cassandra-dtest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/riptano/cassandra-dtest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/riptano/cassandra-dtest/teams","hooks_url":"https://api.github.com/repos/riptano/cassandra-dtest/hooks","issue_events_url":"https://api.github.com/repos/riptano/cassandra-dtest/issues/events{/number}","events_url":"https://api.github.com/repos/riptano/cassandra-dtest/events","assignees_url":"https://api.github.com/repos/riptano/cassandra-dtest/assignees{/user}","branches_url":"https://api.github.com/repos/riptano/cassandra-dtest/branches{/branch}","tags_url":"https://api.github.com/repos/riptano/cassandra-dtest/tags","blobs_url":"https://api.github.com/repos/riptano/cassandra-dtest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/riptano/cassandra-dtest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/riptano/cassandra-dtest/git/refs{/sha}","trees_url":"https://api.github.com/repos/riptano/cassandra-dtest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/riptano/cassandra-dtest/statuses/{sha}","languages_url":"https://api.github.com/repos/riptano/cassandra-dtest/languages","stargazers_url":"https://api.github.com/repos/riptano/cassandra-dtest/stargazers","contributors_url":"https://api.github.com/repos/riptano/cassandra-dtest/contributors","subscribers_url":"https://api.github.com/repos/riptano/cassandra-dtest/subscribers","subscription_url":"https://api.github.com/repos/riptano/cassandra-dtest/subscription","commits_url":"https://api.github.com/repos/riptano/cassandra-dtest/commits{/sha}","git_commits_url":"https://api.github.com/repos/riptano/cassandra-dtest/git/commits{/sha}","comments_url":"https://api.github.com/repos/riptano/cassandra-dtest/comments{/number}","issue_comment_url":"https://api.github.com/repos/riptano/cassandra-dtest/issues/comments{/number}","contents_url":"https://api.github.com/repos/riptano/cassandra-dtest/contents/{+path}","compare_url":"https://api.github.com/repos/riptano/cassandra-dtest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/riptano/cassandra-dtest/merges","archive_url":"https://api.github.com/repos/riptano/cassandra-dtest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/riptano/cassandra-dtest/downloads","issues_url":"https://api.github.com/repos/riptano/cassandra-dtest/issues{/number}","pulls_url":"https://api.github.com/repos/riptano/cassandra-dtest/pulls{/number}","milestones_url":"https://api.github.com/repos/riptano/cassandra-dtest/milestones{/number}","notifications_url":"https://api.github.com/repos/riptano/cassandra-dtest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/riptano/cassandra-dtest/labels{/name}","releases_url":"https://api.github.com/repos/riptano/cassandra-dtest/releases{/id}","deployments_url":"https://api.github.com/repos/riptano/cassandra-dtest/deployments","created_at":"2011-10-30T11:15:44Z","updated_at":"2015-12-23T10:09:34Z","pushed_at":"2016-02-01T20:37:55Z","git_url":"git://github.com/riptano/cassandra-dtest.git","ssh_url":"git@github.com:riptano/cassandra-dtest.git","clone_url":"https://github.com/riptano/cassandra-dtest.git","svn_url":"https://github.com/riptano/cassandra-dtest","homepage":"","size":14235,"stargazers_count":70,"watchers_count":70,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":53,"mirror_url":null,"open_issues_count":53,"forks":53,"open_issues":53,"watchers":70,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/777"},"html":{"href":"https://github.com/riptano/cassandra-dtest/pull/777"},"issue":{"href":"https://api.github.com/repos/riptano/cassandra-dtest/issues/777"},"comments":{"href":"https://api.github.com/repos/riptano/cassandra-dtest/issues/777/comments"},"review_comments":{"href":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/777/comments"},"review_comment":{"href":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/777/commits"},"statuses":{"href":"https://api.github.com/repos/riptano/cassandra-dtest/statuses/0ac300285d92dc78d503611c84d674cc90c94037"}}}}