{"action":"created","issue":{"url":"https://api.github.com/repos/ProcedureKit/ProcedureKit/issues/419","repository_url":"https://api.github.com/repos/ProcedureKit/ProcedureKit","labels_url":"https://api.github.com/repos/ProcedureKit/ProcedureKit/issues/419/labels{/name}","comments_url":"https://api.github.com/repos/ProcedureKit/ProcedureKit/issues/419/comments","events_url":"https://api.github.com/repos/ProcedureKit/ProcedureKit/issues/419/events","html_url":"https://github.com/ProcedureKit/ProcedureKit/pull/419","id":173066847,"number":419,"title":"Tests may randomly fail due to a bug in expectation fulfillment","user":{"login":"swiftlyfalling","id":18540905,"avatar_url":"https://avatars.githubusercontent.com/u/18540905?v=3","gravatar_id":"","url":"https://api.github.com/users/swiftlyfalling","html_url":"https://github.com/swiftlyfalling","followers_url":"https://api.github.com/users/swiftlyfalling/followers","following_url":"https://api.github.com/users/swiftlyfalling/following{/other_user}","gists_url":"https://api.github.com/users/swiftlyfalling/gists{/gist_id}","starred_url":"https://api.github.com/users/swiftlyfalling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swiftlyfalling/subscriptions","organizations_url":"https://api.github.com/users/swiftlyfalling/orgs","repos_url":"https://api.github.com/users/swiftlyfalling/repos","events_url":"https://api.github.com/users/swiftlyfalling/events{/privacy}","received_events_url":"https://api.github.com/users/swiftlyfalling/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ProcedureKit/ProcedureKit/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/ProcedureKit/ProcedureKit/labels/in%20progress","name":"in progress","color":"bfdadc"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/ProcedureKit/ProcedureKit/milestones/35","html_url":"https://github.com/ProcedureKit/ProcedureKit/milestones/3.1.2","labels_url":"https://api.github.com/repos/ProcedureKit/ProcedureKit/milestones/35/labels","id":1961778,"number":35,"title":"3.1.2","description":"","creator":{"login":"danthorpe","id":309420,"avatar_url":"https://avatars.githubusercontent.com/u/309420?v=3","gravatar_id":"","url":"https://api.github.com/users/danthorpe","html_url":"https://github.com/danthorpe","followers_url":"https://api.github.com/users/danthorpe/followers","following_url":"https://api.github.com/users/danthorpe/following{/other_user}","gists_url":"https://api.github.com/users/danthorpe/gists{/gist_id}","starred_url":"https://api.github.com/users/danthorpe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danthorpe/subscriptions","organizations_url":"https://api.github.com/users/danthorpe/orgs","repos_url":"https://api.github.com/users/danthorpe/repos","events_url":"https://api.github.com/users/danthorpe/events{/privacy}","received_events_url":"https://api.github.com/users/danthorpe/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":1,"state":"open","created_at":"2016-08-24T22:03:11Z","updated_at":"2016-08-24T22:03:32Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2016-08-24T21:51:45Z","updated_at":"2016-08-25T18:24:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ProcedureKit/ProcedureKit/pulls/419","html_url":"https://github.com/ProcedureKit/ProcedureKit/pull/419","diff_url":"https://github.com/ProcedureKit/ProcedureKit/pull/419.diff","patch_url":"https://github.com/ProcedureKit/ProcedureKit/pull/419.patch"},"body":"If `XCTestExpectation`s are not fulfilled on the main thread, `waitForExpectationsWithTimeout` may occasionally fail with the timeout.\r\n\r\nFix: Ensure that `XCTestExpectation.fulfill()` is always called on the main thread.\r\n\r\nSome places this needs to be fixed:\r\n\r\n- [x] `OperationTests.addCompletionBlockToTestOperation()`\r\n\r\nIn BasicTests.swift:\r\n- [x] `test__add_multiple_completion_blocks`\r\n- [x] `test__block_operation_with_default_block_runs_completion_block_once`\r\n- [x] `test__nsblockoperation_runs_completion_block_once`\r\n- [x] `test__dependent_operations_always_run`\r\n- [x] `test__delay_operation_completes_after_interval`\r\n\r\nIn BlockConditionTests.swift:\r\n\r\n- [x] `test__operation_with_unsuccessful_block_condition_errors`\r\n- [x] `test__operation_with_block_which_throws_condition_errors`\r\n\r\nIn CloudCapabilitiesTests.swift:\r\n- [x] `test__request_permissions`\r\n\r\nIn GroupOperationTests.swift:\r\n- [x] `test__group_operations_are_performed_in_order`\r\n- [x] `test__adding_operation_to_running_group`\r\n\r\nIn NegatedConditionTests.swift:\r\n- [x] `test__operation_with_successful_block_condition_fails`\r\n\r\nIn RemoteNotificationConditionTests.swift:\r\n- [x] `test__condition_fails__when_registration_fails`\r\n\r\nIn StressTests.swift:\r\n- [x] `test__completion_blocks`\r\n- [x] `test__SR_192_OperationQueue_delegate_weak_var_thread_safety`\r\n"},"comment":{"url":"https://api.github.com/repos/ProcedureKit/ProcedureKit/issues/comments/242491155","html_url":"https://github.com/ProcedureKit/ProcedureKit/pull/419#issuecomment-242491155","issue_url":"https://api.github.com/repos/ProcedureKit/ProcedureKit/issues/419","id":242491155,"user":{"login":"swiftlyfalling","id":18540905,"avatar_url":"https://avatars.githubusercontent.com/u/18540905?v=3","gravatar_id":"","url":"https://api.github.com/users/swiftlyfalling","html_url":"https://github.com/swiftlyfalling","followers_url":"https://api.github.com/users/swiftlyfalling/followers","following_url":"https://api.github.com/users/swiftlyfalling/following{/other_user}","gists_url":"https://api.github.com/users/swiftlyfalling/gists{/gist_id}","starred_url":"https://api.github.com/users/swiftlyfalling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swiftlyfalling/subscriptions","organizations_url":"https://api.github.com/users/swiftlyfalling/orgs","repos_url":"https://api.github.com/users/swiftlyfalling/repos","events_url":"https://api.github.com/users/swiftlyfalling/events{/privacy}","received_events_url":"https://api.github.com/users/swiftlyfalling/received_events","type":"User","site_admin":false},"created_at":"2016-08-25T18:24:13Z","updated_at":"2016-08-25T18:24:13Z","body":"@danthorpe: Much appreciated. Tuning the StressTest timeouts for the CI machine sight-unseen is problematic. 😁"}}
{"actor":{"display_login":"swiftlyfalling"}}