{"action":"created","comment":{"url":"https://api.github.com/repos/playframework/playframework/pulls/comments/58907044","id":58907044,"diff_hunk":"@@ -35,8 +37,9 @@ public static GuiceApplicationBuilder fromScalaBuilder(play.api.inject.guice.Gui\n      * @param load the configuration loader\n      * @return the configured application builder\n      */\n-    public GuiceApplicationBuilder loadConfig(Function<Environment, Configuration> load) {\n-        return newBuilder(delegate.loadConfig(func((play.api.Environment env) -> load.apply(new Environment(env)).getWrappedConfiguration())));\n+    public GuiceApplicationBuilder loadConfig(Function<Environment, Config> load) {","path":"framework/src/play-java/src/main/java/play/inject/guice/GuiceApplicationBuilder.java","position":24,"original_position":24,"commit_id":"8dec8775df4b5db33f94c69dd66f14ecec93c4b5","original_commit_id":"8dec8775df4b5db33f94c69dd66f14ecec93c4b5","user":{"login":"marcospereira","id":4576,"avatar_url":"https://avatars.githubusercontent.com/u/4576?v=3","gravatar_id":"","url":"https://api.github.com/users/marcospereira","html_url":"https://github.com/marcospereira","followers_url":"https://api.github.com/users/marcospereira/followers","following_url":"https://api.github.com/users/marcospereira/following{/other_user}","gists_url":"https://api.github.com/users/marcospereira/gists{/gist_id}","starred_url":"https://api.github.com/users/marcospereira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcospereira/subscriptions","organizations_url":"https://api.github.com/users/marcospereira/orgs","repos_url":"https://api.github.com/users/marcospereira/repos","events_url":"https://api.github.com/users/marcospereira/events{/privacy}","received_events_url":"https://api.github.com/users/marcospereira/received_events","type":"User","site_admin":false},"body":"Should also be overloaded with a deprecated version accepting `Configuration`.","created_at":"2016-04-07T17:00:48Z","updated_at":"2016-04-07T17:00:48Z","html_url":"https://github.com/playframework/playframework/pull/6001#discussion_r58907044","pull_request_url":"https://api.github.com/repos/playframework/playframework/pulls/6001","_links":{"self":{"href":"https://api.github.com/repos/playframework/playframework/pulls/comments/58907044"},"html":{"href":"https://github.com/playframework/playframework/pull/6001#discussion_r58907044"},"pull_request":{"href":"https://api.github.com/repos/playframework/playframework/pulls/6001"}}},"pull_request":{"url":"https://api.github.com/repos/playframework/playframework/pulls/6001","id":65583159,"html_url":"https://github.com/playframework/playframework/pull/6001","diff_url":"https://github.com/playframework/playframework/pull/6001.diff","patch_url":"https://github.com/playframework/playframework/pull/6001.patch","issue_url":"https://api.github.com/repos/playframework/playframework/issues/6001","number":6001,"state":"open","locked":false,"title":"Configuration refactor","user":{"login":"gmethvin","id":171663,"avatar_url":"https://avatars.githubusercontent.com/u/171663?v=3","gravatar_id":"","url":"https://api.github.com/users/gmethvin","html_url":"https://github.com/gmethvin","followers_url":"https://api.github.com/users/gmethvin/followers","following_url":"https://api.github.com/users/gmethvin/following{/other_user}","gists_url":"https://api.github.com/users/gmethvin/gists{/gist_id}","starred_url":"https://api.github.com/users/gmethvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmethvin/subscriptions","organizations_url":"https://api.github.com/users/gmethvin/orgs","repos_url":"https://api.github.com/users/gmethvin/repos","events_url":"https://api.github.com/users/gmethvin/events{/privacy}","received_events_url":"https://api.github.com/users/gmethvin/received_events","type":"User","site_admin":false},"body":" - Deprecate Java `play.Configuration` and prefer raw `Config`.\r\n - Deprecate several methods in `play.api.Configuration` and several methods currently on `play.api.PlayConfig`, including `get[T: ConfigLoader]` and `getOptional[T: ConfigLoader]` that use the `ConfigLoader` typeclass to load arbitrary types.\r\n - Replace several config uses in the codebase with the new versions and deprecate old methods using `play.Configuration`.\r\n\r\nThis fixes several API issues with the current classes:\r\n - The methods in the Configuration APIs don't promote the use of `reference.conf` to declare default values. This is not idiomatic Config usage.\r\n - `play.api.Configuration` has many apparently unnecessary that return Java types. Now there is one method that can be used with a typeclass to load any type you want.\r\n - `play.Configuration` provides little in terms of functionality over raw `Config` and is an unnecessary level of indirection.","created_at":"2016-04-07T07:08:30Z","updated_at":"2016-04-07T17:00:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e497795d25e948cb52f6fcb9ac781ea090131d0a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/playframework/playframework/pulls/6001/commits","review_comments_url":"https://api.github.com/repos/playframework/playframework/pulls/6001/comments","review_comment_url":"https://api.github.com/repos/playframework/playframework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/playframework/playframework/issues/6001/comments","statuses_url":"https://api.github.com/repos/playframework/playframework/statuses/8dec8775df4b5db33f94c69dd66f14ecec93c4b5","head":{"label":"gmethvin:config","ref":"config","sha":"8dec8775df4b5db33f94c69dd66f14ecec93c4b5","user":{"login":"gmethvin","id":171663,"avatar_url":"https://avatars.githubusercontent.com/u/171663?v=3","gravatar_id":"","url":"https://api.github.com/users/gmethvin","html_url":"https://github.com/gmethvin","followers_url":"https://api.github.com/users/gmethvin/followers","following_url":"https://api.github.com/users/gmethvin/following{/other_user}","gists_url":"https://api.github.com/users/gmethvin/gists{/gist_id}","starred_url":"https://api.github.com/users/gmethvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmethvin/subscriptions","organizations_url":"https://api.github.com/users/gmethvin/orgs","repos_url":"https://api.github.com/users/gmethvin/repos","events_url":"https://api.github.com/users/gmethvin/events{/privacy}","received_events_url":"https://api.github.com/users/gmethvin/received_events","type":"User","site_admin":false},"repo":{"id":10559361,"name":"playframework","full_name":"gmethvin/playframework","owner":{"login":"gmethvin","id":171663,"avatar_url":"https://avatars.githubusercontent.com/u/171663?v=3","gravatar_id":"","url":"https://api.github.com/users/gmethvin","html_url":"https://github.com/gmethvin","followers_url":"https://api.github.com/users/gmethvin/followers","following_url":"https://api.github.com/users/gmethvin/following{/other_user}","gists_url":"https://api.github.com/users/gmethvin/gists{/gist_id}","starred_url":"https://api.github.com/users/gmethvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmethvin/subscriptions","organizations_url":"https://api.github.com/users/gmethvin/orgs","repos_url":"https://api.github.com/users/gmethvin/repos","events_url":"https://api.github.com/users/gmethvin/events{/privacy}","received_events_url":"https://api.github.com/users/gmethvin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gmethvin/playframework","description":"Play framework 2.x","fork":true,"url":"https://api.github.com/repos/gmethvin/playframework","forks_url":"https://api.github.com/repos/gmethvin/playframework/forks","keys_url":"https://api.github.com/repos/gmethvin/playframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gmethvin/playframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gmethvin/playframework/teams","hooks_url":"https://api.github.com/repos/gmethvin/playframework/hooks","issue_events_url":"https://api.github.com/repos/gmethvin/playframework/issues/events{/number}","events_url":"https://api.github.com/repos/gmethvin/playframework/events","assignees_url":"https://api.github.com/repos/gmethvin/playframework/assignees{/user}","branches_url":"https://api.github.com/repos/gmethvin/playframework/branches{/branch}","tags_url":"https://api.github.com/repos/gmethvin/playframework/tags","blobs_url":"https://api.github.com/repos/gmethvin/playframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gmethvin/playframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gmethvin/playframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/gmethvin/playframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gmethvin/playframework/statuses/{sha}","languages_url":"https://api.github.com/repos/gmethvin/playframework/languages","stargazers_url":"https://api.github.com/repos/gmethvin/playframework/stargazers","contributors_url":"https://api.github.com/repos/gmethvin/playframework/contributors","subscribers_url":"https://api.github.com/repos/gmethvin/playframework/subscribers","subscription_url":"https://api.github.com/repos/gmethvin/playframework/subscription","commits_url":"https://api.github.com/repos/gmethvin/playframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/gmethvin/playframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/gmethvin/playframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/gmethvin/playframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/gmethvin/playframework/contents/{+path}","compare_url":"https://api.github.com/repos/gmethvin/playframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gmethvin/playframework/merges","archive_url":"https://api.github.com/repos/gmethvin/playframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gmethvin/playframework/downloads","issues_url":"https://api.github.com/repos/gmethvin/playframework/issues{/number}","pulls_url":"https://api.github.com/repos/gmethvin/playframework/pulls{/number}","milestones_url":"https://api.github.com/repos/gmethvin/playframework/milestones{/number}","notifications_url":"https://api.github.com/repos/gmethvin/playframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gmethvin/playframework/labels{/name}","releases_url":"https://api.github.com/repos/gmethvin/playframework/releases{/id}","deployments_url":"https://api.github.com/repos/gmethvin/playframework/deployments","created_at":"2013-06-07T21:37:27Z","updated_at":"2014-07-24T15:49:25Z","pushed_at":"2016-04-07T08:07:41Z","git_url":"git://github.com/gmethvin/playframework.git","ssh_url":"git@github.com:gmethvin/playframework.git","clone_url":"https://github.com/gmethvin/playframework.git","svn_url":"https://github.com/gmethvin/playframework","homepage":"http://www.playframework.org/","size":81447,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"playframework:master","ref":"master","sha":"990c3f95d1cbcef9b3838f7a9ddd37c57d1c7215","user":{"login":"playframework","id":319107,"avatar_url":"https://avatars.githubusercontent.com/u/319107?v=3","gravatar_id":"","url":"https://api.github.com/users/playframework","html_url":"https://github.com/playframework","followers_url":"https://api.github.com/users/playframework/followers","following_url":"https://api.github.com/users/playframework/following{/other_user}","gists_url":"https://api.github.com/users/playframework/gists{/gist_id}","starred_url":"https://api.github.com/users/playframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playframework/subscriptions","organizations_url":"https://api.github.com/users/playframework/orgs","repos_url":"https://api.github.com/users/playframework/repos","events_url":"https://api.github.com/users/playframework/events{/privacy}","received_events_url":"https://api.github.com/users/playframework/received_events","type":"Organization","site_admin":false},"repo":{"id":2340549,"name":"playframework","full_name":"playframework/playframework","owner":{"login":"playframework","id":319107,"avatar_url":"https://avatars.githubusercontent.com/u/319107?v=3","gravatar_id":"","url":"https://api.github.com/users/playframework","html_url":"https://github.com/playframework","followers_url":"https://api.github.com/users/playframework/followers","following_url":"https://api.github.com/users/playframework/following{/other_user}","gists_url":"https://api.github.com/users/playframework/gists{/gist_id}","starred_url":"https://api.github.com/users/playframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playframework/subscriptions","organizations_url":"https://api.github.com/users/playframework/orgs","repos_url":"https://api.github.com/users/playframework/repos","events_url":"https://api.github.com/users/playframework/events{/privacy}","received_events_url":"https://api.github.com/users/playframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/playframework/playframework","description":"Play Framework","fork":false,"url":"https://api.github.com/repos/playframework/playframework","forks_url":"https://api.github.com/repos/playframework/playframework/forks","keys_url":"https://api.github.com/repos/playframework/playframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/playframework/playframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/playframework/playframework/teams","hooks_url":"https://api.github.com/repos/playframework/playframework/hooks","issue_events_url":"https://api.github.com/repos/playframework/playframework/issues/events{/number}","events_url":"https://api.github.com/repos/playframework/playframework/events","assignees_url":"https://api.github.com/repos/playframework/playframework/assignees{/user}","branches_url":"https://api.github.com/repos/playframework/playframework/branches{/branch}","tags_url":"https://api.github.com/repos/playframework/playframework/tags","blobs_url":"https://api.github.com/repos/playframework/playframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/playframework/playframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/playframework/playframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/playframework/playframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/playframework/playframework/statuses/{sha}","languages_url":"https://api.github.com/repos/playframework/playframework/languages","stargazers_url":"https://api.github.com/repos/playframework/playframework/stargazers","contributors_url":"https://api.github.com/repos/playframework/playframework/contributors","subscribers_url":"https://api.github.com/repos/playframework/playframework/subscribers","subscription_url":"https://api.github.com/repos/playframework/playframework/subscription","commits_url":"https://api.github.com/repos/playframework/playframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/playframework/playframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/playframework/playframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/playframework/playframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/playframework/playframework/contents/{+path}","compare_url":"https://api.github.com/repos/playframework/playframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/playframework/playframework/merges","archive_url":"https://api.github.com/repos/playframework/playframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/playframework/playframework/downloads","issues_url":"https://api.github.com/repos/playframework/playframework/issues{/number}","pulls_url":"https://api.github.com/repos/playframework/playframework/pulls{/number}","milestones_url":"https://api.github.com/repos/playframework/playframework/milestones{/number}","notifications_url":"https://api.github.com/repos/playframework/playframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/playframework/playframework/labels{/name}","releases_url":"https://api.github.com/repos/playframework/playframework/releases{/id}","deployments_url":"https://api.github.com/repos/playframework/playframework/deployments","created_at":"2011-09-07T09:24:08Z","updated_at":"2016-04-07T15:22:59Z","pushed_at":"2016-04-07T16:02:15Z","git_url":"git://github.com/playframework/playframework.git","ssh_url":"git@github.com:playframework/playframework.git","clone_url":"https://github.com/playframework/playframework.git","svn_url":"https://github.com/playframework/playframework","homepage":"http://www.playframework.com/","size":93042,"stargazers_count":7685,"watchers_count":7685,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2672,"mirror_url":null,"open_issues_count":254,"forks":2672,"open_issues":254,"watchers":7685,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/playframework/playframework/pulls/6001"},"html":{"href":"https://github.com/playframework/playframework/pull/6001"},"issue":{"href":"https://api.github.com/repos/playframework/playframework/issues/6001"},"comments":{"href":"https://api.github.com/repos/playframework/playframework/issues/6001/comments"},"review_comments":{"href":"https://api.github.com/repos/playframework/playframework/pulls/6001/comments"},"review_comment":{"href":"https://api.github.com/repos/playframework/playframework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/playframework/playframework/pulls/6001/commits"},"statuses":{"href":"https://api.github.com/repos/playframework/playframework/statuses/8dec8775df4b5db33f94c69dd66f14ecec93c4b5"}}}}