{"action":"created","comment":{"url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/pulls/comments/93887986","pull_request_review_id":14420098,"id":93887986,"diff_hunk":"@@ -0,0 +1,70 @@\n+/// <reference path=\"../typings/expect/expect.d.ts\" />\n+/// <reference path=\"../typings/jasmine/jasmine.d.ts\" />\n+/// <reference path=\"../typings/custom/require.d.ts\" />\n+\n+import {QDLParser} from '../app/parsing/QDLParser'\n+import {prettifyMsgs} from '../app/parsing/Logger'\n+import {BlockList} from '../app/parsing/block/BlockList'\n+import {XMLRenderer} from '../app/parsing/render/XMLRenderer'\n+\n+const Errors: any = require('./errors');\n+const expect: any = require('expect');\n+const DocGenerator: any = require('./docGenerator');\n+\n+// Re-generate the docs whenever you run the tests\n+DocGenerator.generate();","path":"errors/errors.test.tsx","position":15,"original_position":15,"commit_id":"cdfae0e3f21b27107610f6f24c142b000de397eb","original_commit_id":"cdfae0e3f21b27107610f6f24c142b000de397eb","user":{"login":"toddmedema","id":775657,"avatar_url":"https://avatars.githubusercontent.com/u/775657?v=3","gravatar_id":"","url":"https://api.github.com/users/toddmedema","html_url":"https://github.com/toddmedema","followers_url":"https://api.github.com/users/toddmedema/followers","following_url":"https://api.github.com/users/toddmedema/following{/other_user}","gists_url":"https://api.github.com/users/toddmedema/gists{/gist_id}","starred_url":"https://api.github.com/users/toddmedema/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toddmedema/subscriptions","organizations_url":"https://api.github.com/users/toddmedema/orgs","repos_url":"https://api.github.com/users/toddmedema/repos","events_url":"https://api.github.com/users/toddmedema/events{/privacy}","received_events_url":"https://api.github.com/users/toddmedema/received_events","type":"User","site_admin":false},"body":"Hmm.\r\n\r\nSo the original idea was that rebuilding the docs when tests are run would keep the docs always up to date (rather than having to remember to run a separate build step)\r\n\r\nDoes that premise seem reasonable? (aka clarifying: is this query just about putting it in a separate file that also gets executed on `npm test`? Or is it outside the scope of running tests?)","created_at":"2016-12-27T00:41:56Z","updated_at":"2016-12-27T00:41:56Z","html_url":"https://github.com/Fabricate-IO/expedition-quest-creator/pull/103#discussion_r93887986","pull_request_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/pulls/103","_links":{"self":{"href":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/pulls/comments/93887986"},"html":{"href":"https://github.com/Fabricate-IO/expedition-quest-creator/pull/103#discussion_r93887986"},"pull_request":{"href":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/pulls/103"}}},"pull_request":{"url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/pulls/103","id":98622914,"html_url":"https://github.com/Fabricate-IO/expedition-quest-creator/pull/103","diff_url":"https://github.com/Fabricate-IO/expedition-quest-creator/pull/103.diff","patch_url":"https://github.com/Fabricate-IO/expedition-quest-creator/pull/103.patch","issue_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/issues/103","number":103,"state":"open","locked":false,"title":"Programmatic errors","user":{"login":"toddmedema","id":775657,"avatar_url":"https://avatars.githubusercontent.com/u/775657?v=3","gravatar_id":"","url":"https://api.github.com/users/toddmedema","html_url":"https://github.com/toddmedema","followers_url":"https://api.github.com/users/toddmedema/followers","following_url":"https://api.github.com/users/toddmedema/following{/other_user}","gists_url":"https://api.github.com/users/toddmedema/gists{/gist_id}","starred_url":"https://api.github.com/users/toddmedema/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toddmedema/subscriptions","organizations_url":"https://api.github.com/users/toddmedema/orgs","repos_url":"https://api.github.com/users/toddmedema/repos","events_url":"https://api.github.com/users/toddmedema/events{/privacy}","received_events_url":"https://api.github.com/users/toddmedema/received_events","type":"User","site_admin":false},"body":"TODO: \r\n- review breaking tests:\r\n  - 412 - can't reproduce, triggers 414 and 417 if just _combat_, but not 412\r\n  - 413 - can't reproduce, if it's `_combat_`, it's unbroken, anything else is just a roleplay title\r\n  - 415 - can't reproduce, seems redundant with 416\r\n  - 419 - can't reproduce, seems to only be possible w/ purposefully broken XML\r\n  - 425 - can't reproduce, every data type works as a string\r\n\r\nDONE:\r\n- fix broken table of contents error links\r\n- combine error documentation with test cases to eliminate redundancy and improve maintainability and quality of documentation.\r\n  - create error definition files with examples of broken and fixed cases\r\n  - auto-generate test cases against all broken and fixed test cases\r\n    - removed simple error test cases from other tests (ie if a test case is checking for a specific, single error, makes more sense to live in the error definition file)\r\n  - generate error doc markdown files based on error definitions; automatically generated on each test run (quite fast) so the docs are always up to date\r\n\r\ncloses #16 ","created_at":"2016-12-19T19:15:48Z","updated_at":"2016-12-27T00:41:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"84fdb419dc182126556a9b66e10db1b1e15962d8","assignee":{"login":"smartin015","id":607666,"avatar_url":"https://avatars.githubusercontent.com/u/607666?v=3","gravatar_id":"","url":"https://api.github.com/users/smartin015","html_url":"https://github.com/smartin015","followers_url":"https://api.github.com/users/smartin015/followers","following_url":"https://api.github.com/users/smartin015/following{/other_user}","gists_url":"https://api.github.com/users/smartin015/gists{/gist_id}","starred_url":"https://api.github.com/users/smartin015/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartin015/subscriptions","organizations_url":"https://api.github.com/users/smartin015/orgs","repos_url":"https://api.github.com/users/smartin015/repos","events_url":"https://api.github.com/users/smartin015/events{/privacy}","received_events_url":"https://api.github.com/users/smartin015/received_events","type":"User","site_admin":false},"assignees":[{"login":"smartin015","id":607666,"avatar_url":"https://avatars.githubusercontent.com/u/607666?v=3","gravatar_id":"","url":"https://api.github.com/users/smartin015","html_url":"https://github.com/smartin015","followers_url":"https://api.github.com/users/smartin015/followers","following_url":"https://api.github.com/users/smartin015/following{/other_user}","gists_url":"https://api.github.com/users/smartin015/gists{/gist_id}","starred_url":"https://api.github.com/users/smartin015/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartin015/subscriptions","organizations_url":"https://api.github.com/users/smartin015/orgs","repos_url":"https://api.github.com/users/smartin015/repos","events_url":"https://api.github.com/users/smartin015/events{/privacy}","received_events_url":"https://api.github.com/users/smartin015/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/pulls/103/commits","review_comments_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/pulls/103/comments","review_comment_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/issues/103/comments","statuses_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/statuses/cdfae0e3f21b27107610f6f24c142b000de397eb","head":{"label":"Fabricate-IO:dev","ref":"dev","sha":"cdfae0e3f21b27107610f6f24c142b000de397eb","user":{"login":"Fabricate-IO","id":17938647,"avatar_url":"https://avatars.githubusercontent.com/u/17938647?v=3","gravatar_id":"","url":"https://api.github.com/users/Fabricate-IO","html_url":"https://github.com/Fabricate-IO","followers_url":"https://api.github.com/users/Fabricate-IO/followers","following_url":"https://api.github.com/users/Fabricate-IO/following{/other_user}","gists_url":"https://api.github.com/users/Fabricate-IO/gists{/gist_id}","starred_url":"https://api.github.com/users/Fabricate-IO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fabricate-IO/subscriptions","organizations_url":"https://api.github.com/users/Fabricate-IO/orgs","repos_url":"https://api.github.com/users/Fabricate-IO/repos","events_url":"https://api.github.com/users/Fabricate-IO/events{/privacy}","received_events_url":"https://api.github.com/users/Fabricate-IO/received_events","type":"Organization","site_admin":false},"repo":{"id":66146816,"name":"expedition-quest-creator","full_name":"Fabricate-IO/expedition-quest-creator","owner":{"login":"Fabricate-IO","id":17938647,"avatar_url":"https://avatars.githubusercontent.com/u/17938647?v=3","gravatar_id":"","url":"https://api.github.com/users/Fabricate-IO","html_url":"https://github.com/Fabricate-IO","followers_url":"https://api.github.com/users/Fabricate-IO/followers","following_url":"https://api.github.com/users/Fabricate-IO/following{/other_user}","gists_url":"https://api.github.com/users/Fabricate-IO/gists{/gist_id}","starred_url":"https://api.github.com/users/Fabricate-IO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fabricate-IO/subscriptions","organizations_url":"https://api.github.com/users/Fabricate-IO/orgs","repos_url":"https://api.github.com/users/Fabricate-IO/repos","events_url":"https://api.github.com/users/Fabricate-IO/events{/privacy}","received_events_url":"https://api.github.com/users/Fabricate-IO/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Fabricate-IO/expedition-quest-creator","description":"The Quest Creator tool for Expedition: The Roleplaying Card Game","fork":false,"url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator","forks_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/forks","keys_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/teams","hooks_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/hooks","issue_events_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/issues/events{/number}","events_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/events","assignees_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/assignees{/user}","branches_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/branches{/branch}","tags_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/tags","blobs_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/statuses/{sha}","languages_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/languages","stargazers_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/stargazers","contributors_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/contributors","subscribers_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/subscribers","subscription_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/subscription","commits_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/issues/comments{/number}","contents_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/contents/{+path}","compare_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/merges","archive_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/downloads","issues_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/issues{/number}","pulls_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/pulls{/number}","milestones_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/milestones{/number}","notifications_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/labels{/name}","releases_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/releases{/id}","deployments_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/deployments","created_at":"2016-08-20T12:57:14Z","updated_at":"2016-12-21T01:12:28Z","pushed_at":"2016-12-26T23:44:46Z","git_url":"git://github.com/Fabricate-IO/expedition-quest-creator.git","ssh_url":"git@github.com:Fabricate-IO/expedition-quest-creator.git","clone_url":"https://github.com/Fabricate-IO/expedition-quest-creator.git","svn_url":"https://github.com/Fabricate-IO/expedition-quest-creator","homepage":"http://quests.expeditiongame.com","size":16260,"stargazers_count":2,"watchers_count":2,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":38,"forks":1,"open_issues":38,"watchers":2,"default_branch":"master"}},"base":{"label":"Fabricate-IO:master","ref":"master","sha":"5b310977bc68cd96270d083e21d58b75effdcbfe","user":{"login":"Fabricate-IO","id":17938647,"avatar_url":"https://avatars.githubusercontent.com/u/17938647?v=3","gravatar_id":"","url":"https://api.github.com/users/Fabricate-IO","html_url":"https://github.com/Fabricate-IO","followers_url":"https://api.github.com/users/Fabricate-IO/followers","following_url":"https://api.github.com/users/Fabricate-IO/following{/other_user}","gists_url":"https://api.github.com/users/Fabricate-IO/gists{/gist_id}","starred_url":"https://api.github.com/users/Fabricate-IO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fabricate-IO/subscriptions","organizations_url":"https://api.github.com/users/Fabricate-IO/orgs","repos_url":"https://api.github.com/users/Fabricate-IO/repos","events_url":"https://api.github.com/users/Fabricate-IO/events{/privacy}","received_events_url":"https://api.github.com/users/Fabricate-IO/received_events","type":"Organization","site_admin":false},"repo":{"id":66146816,"name":"expedition-quest-creator","full_name":"Fabricate-IO/expedition-quest-creator","owner":{"login":"Fabricate-IO","id":17938647,"avatar_url":"https://avatars.githubusercontent.com/u/17938647?v=3","gravatar_id":"","url":"https://api.github.com/users/Fabricate-IO","html_url":"https://github.com/Fabricate-IO","followers_url":"https://api.github.com/users/Fabricate-IO/followers","following_url":"https://api.github.com/users/Fabricate-IO/following{/other_user}","gists_url":"https://api.github.com/users/Fabricate-IO/gists{/gist_id}","starred_url":"https://api.github.com/users/Fabricate-IO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fabricate-IO/subscriptions","organizations_url":"https://api.github.com/users/Fabricate-IO/orgs","repos_url":"https://api.github.com/users/Fabricate-IO/repos","events_url":"https://api.github.com/users/Fabricate-IO/events{/privacy}","received_events_url":"https://api.github.com/users/Fabricate-IO/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Fabricate-IO/expedition-quest-creator","description":"The Quest Creator tool for Expedition: The Roleplaying Card Game","fork":false,"url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator","forks_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/forks","keys_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/teams","hooks_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/hooks","issue_events_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/issues/events{/number}","events_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/events","assignees_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/assignees{/user}","branches_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/branches{/branch}","tags_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/tags","blobs_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/statuses/{sha}","languages_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/languages","stargazers_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/stargazers","contributors_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/contributors","subscribers_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/subscribers","subscription_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/subscription","commits_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/issues/comments{/number}","contents_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/contents/{+path}","compare_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/merges","archive_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/downloads","issues_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/issues{/number}","pulls_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/pulls{/number}","milestones_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/milestones{/number}","notifications_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/labels{/name}","releases_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/releases{/id}","deployments_url":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/deployments","created_at":"2016-08-20T12:57:14Z","updated_at":"2016-12-21T01:12:28Z","pushed_at":"2016-12-26T23:44:46Z","git_url":"git://github.com/Fabricate-IO/expedition-quest-creator.git","ssh_url":"git@github.com:Fabricate-IO/expedition-quest-creator.git","clone_url":"https://github.com/Fabricate-IO/expedition-quest-creator.git","svn_url":"https://github.com/Fabricate-IO/expedition-quest-creator","homepage":"http://quests.expeditiongame.com","size":16260,"stargazers_count":2,"watchers_count":2,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":38,"forks":1,"open_issues":38,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/pulls/103"},"html":{"href":"https://github.com/Fabricate-IO/expedition-quest-creator/pull/103"},"issue":{"href":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/issues/103"},"comments":{"href":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/issues/103/comments"},"review_comments":{"href":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/pulls/103/comments"},"review_comment":{"href":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/pulls/103/commits"},"statuses":{"href":"https://api.github.com/repos/Fabricate-IO/expedition-quest-creator/statuses/cdfae0e3f21b27107610f6f24c142b000de397eb"}}}}
{"actor":{"display_login":"toddmedema"}}