{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/15755","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15755/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15755/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15755/events","html_url":"https://github.com/cms-sw/cmssw/pull/15755","id":175424078,"number":15755,"title":"Pix raw2digi phase1 l1","user":{"login":"dkotlins","id":4726262,"avatar_url":"https://avatars.githubusercontent.com/u/4726262?v=3","gravatar_id":"","url":"https://api.github.com/users/dkotlins","html_url":"https://github.com/dkotlins","followers_url":"https://api.github.com/users/dkotlins/followers","following_url":"https://api.github.com/users/dkotlins/following{/other_user}","gists_url":"https://api.github.com/users/dkotlins/gists{/gist_id}","starred_url":"https://api.github.com/users/dkotlins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkotlins/subscriptions","organizations_url":"https://api.github.com/users/dkotlins/orgs","repos_url":"https://api.github.com/users/dkotlins/repos","events_url":"https://api.github.com/users/dkotlins/events{/privacy}","received_events_url":"https://api.github.com/users/dkotlins/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/alca-pending","name":"alca-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/db-pending","name":"db-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"009800"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_1_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59/labels","id":1590252,"number":59,"title":"Next CMSSW_8_1_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":68,"closed_issues":1441,"state":"open","created_at":"2016-02-18T09:12:12Z","updated_at":"2016-09-15T16:55:46Z","due_on":null,"closed_at":null},"comments":25,"created_at":"2016-09-07T06:36:09Z","updated_at":"2016-09-15T19:21:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/15755","html_url":"https://github.com/cms-sw/cmssw/pull/15755","diff_url":"https://github.com/cms-sw/cmssw/pull/15755.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/15755.patch"},"body":"Modify pixel raw2digi to handle phase1 layer 1 ROC data (PROC600).\r\nThe data format is different, roc-column and -row instead of double-column and pixel index.\r\nMain modifications in EventFilter/SiPixelRawToDigi/src/PixelDataFormatter.cc, minor in *.h \r\nand PixelRoc.cc/h.\r\nHas the same problem as the previous version, it uses hardwired constants in PixelRoc\r\nto recognized layer 1 ROCs. To fix it one needs to find a way to pass Topology to PixelROC \r\nin a way which is tread-safe.\r\n "},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/247425922","html_url":"https://github.com/cms-sw/cmssw/pull/15755#issuecomment-247425922","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15755","id":247425922,"user":{"login":"cvuosalo","id":5736159,"avatar_url":"https://avatars.githubusercontent.com/u/5736159?v=3","gravatar_id":"","url":"https://api.github.com/users/cvuosalo","html_url":"https://github.com/cvuosalo","followers_url":"https://api.github.com/users/cvuosalo/followers","following_url":"https://api.github.com/users/cvuosalo/following{/other_user}","gists_url":"https://api.github.com/users/cvuosalo/gists{/gist_id}","starred_url":"https://api.github.com/users/cvuosalo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvuosalo/subscriptions","organizations_url":"https://api.github.com/users/cvuosalo/orgs","repos_url":"https://api.github.com/users/cvuosalo/repos","events_url":"https://api.github.com/users/cvuosalo/events{/privacy}","received_events_url":"https://api.github.com/users/cvuosalo/received_events","type":"User","site_admin":false},"created_at":"2016-09-15T19:21:58Z","updated_at":"2016-09-15T19:21:58Z","body":"+1\r\n\r\nFor #15755 7b0acec9ce975e97203ed62b1155bd06568bed2e\r\n\r\nModifying Pixel raw2digi to handle Phase 1 layer 1 ROC data.\r\n\r\nThe code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-09-13-1100 show no significant differences, as expected. A test of workflow 10224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU with 100 events against baseline CMSSW_8_1_0_pre9 shows no significant differences and no significant change in CPU time or memory usage."}}
{"actor":{"display_login":"cvuosalo"}}