{"action":"created","comment":{"url":"https://api.github.com/repos/openssl/openssl/pulls/comments/63007355","id":63007355,"diff_hunk":"@@ -294,25 +294,22 @@ X509_LOOKUP *X509_STORE_add_lookup(X509_STORE *v, X509_LOOKUP_METHOD *m)\n     }\n }\n \n-X509_OBJECT *X509_STORE_get_X509_by_subject(X509_STORE_CTX *vs, int type,\n-                                                  X509_NAME *name)\n+X509_OBJECT *X509_STORE_CTX_get_obj_by_subject(X509_STORE_CTX *vs, int type,\n+                                               X509_NAME *name)\n {\n-    X509_OBJECT *ret;\n+    X509_OBJECT *ret = X509_OBJECT_new();\n \n-    ret = OPENSSL_malloc(sizeof (*ret));\n-    if (ret == NULL) {\n-        X509err(X509_F_X509_STORE_GET_X509_BY_SUBJECT, ERR_R_MALLOC_FAILURE);\n+    if (ret == NULL)\n         return NULL;\n-    }\n-    if (!X509_STORE_get_by_subject(vs, type, name, ret)) {\n-        OPENSSL_free(ret);\n+    if (!X509_STORE_CTX_get_by_subject(vs, type, name, ret)) {\n+        X509_OBJECT_free(ret);\n         return NULL;\n     }\n     return ret;\n }\n \n-int X509_STORE_get_by_subject(X509_STORE_CTX *vs, X509_LOOKUP_TYPE type,\n-                              X509_NAME *name, X509_OBJECT *ret)\n+int X509_STORE_CTX_get_by_subject(X509_STORE_CTX *vs, X509_LOOKUP_TYPE type,","path":"crypto/x509/x509_lu.c","position":29,"original_position":29,"commit_id":"299a0c0891448e20ca18f35915068e1f151672fa","original_commit_id":"299a0c0891448e20ca18f35915068e1f151672fa","user":{"login":"levitte","id":698918,"avatar_url":"https://avatars.githubusercontent.com/u/698918?v=3","gravatar_id":"","url":"https://api.github.com/users/levitte","html_url":"https://github.com/levitte","followers_url":"https://api.github.com/users/levitte/followers","following_url":"https://api.github.com/users/levitte/following{/other_user}","gists_url":"https://api.github.com/users/levitte/gists{/gist_id}","starred_url":"https://api.github.com/users/levitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levitte/subscriptions","organizations_url":"https://api.github.com/users/levitte/orgs","repos_url":"https://api.github.com/users/levitte/repos","events_url":"https://api.github.com/users/levitte/events{/privacy}","received_events_url":"https://api.github.com/users/levitte/received_events","type":"User","site_admin":false},"body":"Same thing here, please change the prefix back from `X509_STORE_CTX_` to `X509_STORE_`.","created_at":"2016-05-12T11:59:56Z","updated_at":"2016-05-12T11:59:56Z","html_url":"https://github.com/openssl/openssl/pull/1044#discussion_r63007355","pull_request_url":"https://api.github.com/repos/openssl/openssl/pulls/1044","_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments/63007355"},"html":{"href":"https://github.com/openssl/openssl/pull/1044#discussion_r63007355"},"pull_request":{"href":"https://api.github.com/repos/openssl/openssl/pulls/1044"}}},"pull_request":{"url":"https://api.github.com/repos/openssl/openssl/pulls/1044","id":69383728,"html_url":"https://github.com/openssl/openssl/pull/1044","diff_url":"https://github.com/openssl/openssl/pull/1044.diff","patch_url":"https://github.com/openssl/openssl/pull/1044.patch","issue_url":"https://api.github.com/repos/openssl/openssl/issues/1044","number":1044,"state":"open","locked":false,"title":"X509_STORE_CTX accessors.","user":{"login":"richsalz","id":7332500,"avatar_url":"https://avatars.githubusercontent.com/u/7332500?v=3","gravatar_id":"","url":"https://api.github.com/users/richsalz","html_url":"https://github.com/richsalz","followers_url":"https://api.github.com/users/richsalz/followers","following_url":"https://api.github.com/users/richsalz/following{/other_user}","gists_url":"https://api.github.com/users/richsalz/gists{/gist_id}","starred_url":"https://api.github.com/users/richsalz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richsalz/subscriptions","organizations_url":"https://api.github.com/users/richsalz/orgs","repos_url":"https://api.github.com/users/richsalz/repos","events_url":"https://api.github.com/users/richsalz/events{/privacy}","received_events_url":"https://api.github.com/users/richsalz/received_events","type":"User","site_admin":false},"body":"Add some functions that were missing when a number of X509\r\nobjects became opaque (thanks, Roumen!)","created_at":"2016-05-09T17:51:02Z","updated_at":"2016-05-12T11:59:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f5e21ba9a9dd22a5ea6d90006cdc0ef6fa620ed","assignee":{"login":"richsalz","id":7332500,"avatar_url":"https://avatars.githubusercontent.com/u/7332500?v=3","gravatar_id":"","url":"https://api.github.com/users/richsalz","html_url":"https://github.com/richsalz","followers_url":"https://api.github.com/users/richsalz/followers","following_url":"https://api.github.com/users/richsalz/following{/other_user}","gists_url":"https://api.github.com/users/richsalz/gists{/gist_id}","starred_url":"https://api.github.com/users/richsalz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richsalz/subscriptions","organizations_url":"https://api.github.com/users/richsalz/orgs","repos_url":"https://api.github.com/users/richsalz/repos","events_url":"https://api.github.com/users/richsalz/events{/privacy}","received_events_url":"https://api.github.com/users/richsalz/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/openssl/openssl/milestones/1","html_url":"https://github.com/openssl/openssl/milestones/1.1.0","labels_url":"https://api.github.com/repos/openssl/openssl/milestones/1/labels","id":1748232,"number":1,"title":"1.1.0","description":"","creator":{"login":"levitte","id":698918,"avatar_url":"https://avatars.githubusercontent.com/u/698918?v=3","gravatar_id":"","url":"https://api.github.com/users/levitte","html_url":"https://github.com/levitte","followers_url":"https://api.github.com/users/levitte/followers","following_url":"https://api.github.com/users/levitte/following{/other_user}","gists_url":"https://api.github.com/users/levitte/gists{/gist_id}","starred_url":"https://api.github.com/users/levitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levitte/subscriptions","organizations_url":"https://api.github.com/users/levitte/orgs","repos_url":"https://api.github.com/users/levitte/repos","events_url":"https://api.github.com/users/levitte/events{/privacy}","received_events_url":"https://api.github.com/users/levitte/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":1,"state":"open","created_at":"2016-05-04T17:53:39Z","updated_at":"2016-05-12T11:53:09Z","due_on":"2016-05-11T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/openssl/openssl/pulls/1044/commits","review_comments_url":"https://api.github.com/repos/openssl/openssl/pulls/1044/comments","review_comment_url":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openssl/openssl/issues/1044/comments","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/299a0c0891448e20ca18f35915068e1f151672fa","head":{"label":"richsalz:x509lu-adds","ref":"x509lu-adds","sha":"299a0c0891448e20ca18f35915068e1f151672fa","user":{"login":"richsalz","id":7332500,"avatar_url":"https://avatars.githubusercontent.com/u/7332500?v=3","gravatar_id":"","url":"https://api.github.com/users/richsalz","html_url":"https://github.com/richsalz","followers_url":"https://api.github.com/users/richsalz/followers","following_url":"https://api.github.com/users/richsalz/following{/other_user}","gists_url":"https://api.github.com/users/richsalz/gists{/gist_id}","starred_url":"https://api.github.com/users/richsalz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richsalz/subscriptions","organizations_url":"https://api.github.com/users/richsalz/orgs","repos_url":"https://api.github.com/users/richsalz/repos","events_url":"https://api.github.com/users/richsalz/events{/privacy}","received_events_url":"https://api.github.com/users/richsalz/received_events","type":"User","site_admin":false},"repo":{"id":44908226,"name":"openssl","full_name":"richsalz/openssl","owner":{"login":"richsalz","id":7332500,"avatar_url":"https://avatars.githubusercontent.com/u/7332500?v=3","gravatar_id":"","url":"https://api.github.com/users/richsalz","html_url":"https://github.com/richsalz","followers_url":"https://api.github.com/users/richsalz/followers","following_url":"https://api.github.com/users/richsalz/following{/other_user}","gists_url":"https://api.github.com/users/richsalz/gists{/gist_id}","starred_url":"https://api.github.com/users/richsalz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richsalz/subscriptions","organizations_url":"https://api.github.com/users/richsalz/orgs","repos_url":"https://api.github.com/users/richsalz/repos","events_url":"https://api.github.com/users/richsalz/events{/privacy}","received_events_url":"https://api.github.com/users/richsalz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/richsalz/openssl","description":"","fork":true,"url":"https://api.github.com/repos/richsalz/openssl","forks_url":"https://api.github.com/repos/richsalz/openssl/forks","keys_url":"https://api.github.com/repos/richsalz/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/richsalz/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/richsalz/openssl/teams","hooks_url":"https://api.github.com/repos/richsalz/openssl/hooks","issue_events_url":"https://api.github.com/repos/richsalz/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/richsalz/openssl/events","assignees_url":"https://api.github.com/repos/richsalz/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/richsalz/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/richsalz/openssl/tags","blobs_url":"https://api.github.com/repos/richsalz/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/richsalz/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/richsalz/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/richsalz/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/richsalz/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/richsalz/openssl/languages","stargazers_url":"https://api.github.com/repos/richsalz/openssl/stargazers","contributors_url":"https://api.github.com/repos/richsalz/openssl/contributors","subscribers_url":"https://api.github.com/repos/richsalz/openssl/subscribers","subscription_url":"https://api.github.com/repos/richsalz/openssl/subscription","commits_url":"https://api.github.com/repos/richsalz/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/richsalz/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/richsalz/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/richsalz/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/richsalz/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/richsalz/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/richsalz/openssl/merges","archive_url":"https://api.github.com/repos/richsalz/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/richsalz/openssl/downloads","issues_url":"https://api.github.com/repos/richsalz/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/richsalz/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/richsalz/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/richsalz/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/richsalz/openssl/labels{/name}","releases_url":"https://api.github.com/repos/richsalz/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/richsalz/openssl/deployments","created_at":"2015-10-25T12:01:24Z","updated_at":"2015-12-19T13:23:40Z","pushed_at":"2016-05-11T02:41:38Z","git_url":"git://github.com/richsalz/openssl.git","ssh_url":"git@github.com:richsalz/openssl.git","clone_url":"https://github.com/richsalz/openssl.git","svn_url":"https://github.com/richsalz/openssl","homepage":null,"size":84123,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"openssl:master","ref":"master","sha":"9b5164ce7788d6985b005e410bb7b53bd553c99e","user":{"login":"openssl","id":3279138,"avatar_url":"https://avatars.githubusercontent.com/u/3279138?v=3","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"repo":{"id":7634677,"name":"openssl","full_name":"openssl/openssl","owner":{"login":"openssl","id":3279138,"avatar_url":"https://avatars.githubusercontent.com/u/3279138?v=3","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openssl/openssl","description":"TLS/SSL and crypto library","fork":false,"url":"https://api.github.com/repos/openssl/openssl","forks_url":"https://api.github.com/repos/openssl/openssl/forks","keys_url":"https://api.github.com/repos/openssl/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openssl/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openssl/openssl/teams","hooks_url":"https://api.github.com/repos/openssl/openssl/hooks","issue_events_url":"https://api.github.com/repos/openssl/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/openssl/openssl/events","assignees_url":"https://api.github.com/repos/openssl/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/openssl/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/openssl/openssl/tags","blobs_url":"https://api.github.com/repos/openssl/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openssl/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openssl/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/openssl/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/openssl/openssl/languages","stargazers_url":"https://api.github.com/repos/openssl/openssl/stargazers","contributors_url":"https://api.github.com/repos/openssl/openssl/contributors","subscribers_url":"https://api.github.com/repos/openssl/openssl/subscribers","subscription_url":"https://api.github.com/repos/openssl/openssl/subscription","commits_url":"https://api.github.com/repos/openssl/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/openssl/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/openssl/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/openssl/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/openssl/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/openssl/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openssl/openssl/merges","archive_url":"https://api.github.com/repos/openssl/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openssl/openssl/downloads","issues_url":"https://api.github.com/repos/openssl/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/openssl/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/openssl/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/openssl/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openssl/openssl/labels{/name}","releases_url":"https://api.github.com/repos/openssl/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/openssl/openssl/deployments","created_at":"2013-01-15T22:34:48Z","updated_at":"2016-05-12T09:04:49Z","pushed_at":"2016-05-12T11:46:38Z","git_url":"git://github.com/openssl/openssl.git","ssh_url":"git@github.com:openssl/openssl.git","clone_url":"https://github.com/openssl/openssl.git","svn_url":"https://github.com/openssl/openssl","homepage":"https://www.openssl.org","size":106092,"stargazers_count":2611,"watchers_count":2611,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1493,"mirror_url":null,"open_issues_count":148,"forks":1493,"open_issues":148,"watchers":2611,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/1044"},"html":{"href":"https://github.com/openssl/openssl/pull/1044"},"issue":{"href":"https://api.github.com/repos/openssl/openssl/issues/1044"},"comments":{"href":"https://api.github.com/repos/openssl/openssl/issues/1044/comments"},"review_comments":{"href":"https://api.github.com/repos/openssl/openssl/pulls/1044/comments"},"review_comment":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openssl/openssl/pulls/1044/commits"},"statuses":{"href":"https://api.github.com/repos/openssl/openssl/statuses/299a0c0891448e20ca18f35915068e1f151672fa"}}}}