{"action":"opened","number":3984,"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/3984","id":91809848,"html_url":"https://github.com/theforeman/foreman/pull/3984","diff_url":"https://github.com/theforeman/foreman/pull/3984.diff","patch_url":"https://github.com/theforeman/foreman/pull/3984.patch","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/3984","number":3984,"state":"open","locked":false,"title":"Fixes #16739 - unify parameters permissions","user":{"login":"ares","id":109773,"avatar_url":"https://avatars.githubusercontent.com/u/109773?v=3","gravatar_id":"","url":"https://api.github.com/users/ares","html_url":"https://github.com/ares","followers_url":"https://api.github.com/users/ares/followers","following_url":"https://api.github.com/users/ares/following{/other_user}","gists_url":"https://api.github.com/users/ares/gists{/gist_id}","starred_url":"https://api.github.com/users/ares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ares/subscriptions","organizations_url":"https://api.github.com/users/ares/orgs","repos_url":"https://api.github.com/users/ares/repos","events_url":"https://api.github.com/users/ares/events{/privacy}","received_events_url":"https://api.github.com/users/ares/received_events","type":"User","site_admin":false},"body":"This unifies `view_globals` used for global parameters with `view_params` used for the rest of parameters. And all other similar permissions of course. Shared and only resource type for such filters is `Parameter`. It also fixes the autocompletion for parameter filters so you can define a fllter like this\r\n\r\n    \"name ~ a* or domain_name ~ example*com\"\r\n\r\nother resources can be used too, e.g. host_name, hostgroup_name, subnet_name etc. One can also filter on type so to limit to global parameters only we can use `type = CommonParameter` condition. And finally, it adds integration test covering granular permissions for user.\r\n\r\nThe PR includes the migration for existing CommonParameter filters.","created_at":"2016-11-01T15:57:19Z","updated_at":"2016-11-01T15:57:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/foreman/pulls/3984/commits","review_comments_url":"https://api.github.com/repos/theforeman/foreman/pulls/3984/comments","review_comment_url":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/3984/comments","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/ecb2b1e5c717fbdf9c4071b5dcf0324e20c3547e","head":{"label":"ares:fix/16739","ref":"fix/16739","sha":"ecb2b1e5c717fbdf9c4071b5dcf0324e20c3547e","user":{"login":"ares","id":109773,"avatar_url":"https://avatars.githubusercontent.com/u/109773?v=3","gravatar_id":"","url":"https://api.github.com/users/ares","html_url":"https://github.com/ares","followers_url":"https://api.github.com/users/ares/followers","following_url":"https://api.github.com/users/ares/following{/other_user}","gists_url":"https://api.github.com/users/ares/gists{/gist_id}","starred_url":"https://api.github.com/users/ares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ares/subscriptions","organizations_url":"https://api.github.com/users/ares/orgs","repos_url":"https://api.github.com/users/ares/repos","events_url":"https://api.github.com/users/ares/events{/privacy}","received_events_url":"https://api.github.com/users/ares/received_events","type":"User","site_admin":false},"repo":{"id":8576886,"name":"foreman","full_name":"ares/foreman","owner":{"login":"ares","id":109773,"avatar_url":"https://avatars.githubusercontent.com/u/109773?v=3","gravatar_id":"","url":"https://api.github.com/users/ares","html_url":"https://github.com/ares","followers_url":"https://api.github.com/users/ares/followers","following_url":"https://api.github.com/users/ares/following{/other_user}","gists_url":"https://api.github.com/users/ares/gists{/gist_id}","starred_url":"https://api.github.com/users/ares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ares/subscriptions","organizations_url":"https://api.github.com/users/ares/orgs","repos_url":"https://api.github.com/users/ares/repos","events_url":"https://api.github.com/users/ares/events{/privacy}","received_events_url":"https://api.github.com/users/ares/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ares/foreman","description":"an application that automates the lifecycle of servers ","fork":true,"url":"https://api.github.com/repos/ares/foreman","forks_url":"https://api.github.com/repos/ares/foreman/forks","keys_url":"https://api.github.com/repos/ares/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ares/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ares/foreman/teams","hooks_url":"https://api.github.com/repos/ares/foreman/hooks","issue_events_url":"https://api.github.com/repos/ares/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/ares/foreman/events","assignees_url":"https://api.github.com/repos/ares/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/ares/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/ares/foreman/tags","blobs_url":"https://api.github.com/repos/ares/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ares/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ares/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/ares/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ares/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/ares/foreman/languages","stargazers_url":"https://api.github.com/repos/ares/foreman/stargazers","contributors_url":"https://api.github.com/repos/ares/foreman/contributors","subscribers_url":"https://api.github.com/repos/ares/foreman/subscribers","subscription_url":"https://api.github.com/repos/ares/foreman/subscription","commits_url":"https://api.github.com/repos/ares/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/ares/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/ares/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/ares/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/ares/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/ares/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ares/foreman/merges","archive_url":"https://api.github.com/repos/ares/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ares/foreman/downloads","issues_url":"https://api.github.com/repos/ares/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/ares/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/ares/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/ares/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ares/foreman/labels{/name}","releases_url":"https://api.github.com/repos/ares/foreman/releases{/id}","deployments_url":"https://api.github.com/repos/ares/foreman/deployments","created_at":"2013-03-05T09:59:59Z","updated_at":"2014-08-19T11:27:01Z","pushed_at":"2016-11-01T15:56:06Z","git_url":"git://github.com/ares/foreman.git","ssh_url":"git@github.com:ares/foreman.git","clone_url":"https://github.com/ares/foreman.git","svn_url":"https://github.com/ares/foreman","homepage":"http://theforeman.org","size":42695,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"theforeman:develop","ref":"develop","sha":"5db3608703f36ab416596e2f7cf20c732054ac84","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":258750,"name":"foreman","full_name":"theforeman/foreman","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/foreman","description":"an application that automates the lifecycle of servers ","fork":false,"url":"https://api.github.com/repos/theforeman/foreman","forks_url":"https://api.github.com/repos/theforeman/foreman/forks","keys_url":"https://api.github.com/repos/theforeman/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/foreman/teams","hooks_url":"https://api.github.com/repos/theforeman/foreman/hooks","issue_events_url":"https://api.github.com/repos/theforeman/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/foreman/events","assignees_url":"https://api.github.com/repos/theforeman/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/foreman/tags","blobs_url":"https://api.github.com/repos/theforeman/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/foreman/languages","stargazers_url":"https://api.github.com/repos/theforeman/foreman/stargazers","contributors_url":"https://api.github.com/repos/theforeman/foreman/contributors","subscribers_url":"https://api.github.com/repos/theforeman/foreman/subscribers","subscription_url":"https://api.github.com/repos/theforeman/foreman/subscription","commits_url":"https://api.github.com/repos/theforeman/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/foreman/merges","archive_url":"https://api.github.com/repos/theforeman/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/foreman/downloads","issues_url":"https://api.github.com/repos/theforeman/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/foreman/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/foreman/releases{/id}","deployments_url":"https://api.github.com/repos/theforeman/foreman/deployments","created_at":"2009-07-23T15:07:00Z","updated_at":"2016-11-01T00:21:21Z","pushed_at":"2016-11-01T15:57:19Z","git_url":"git://github.com/theforeman/foreman.git","ssh_url":"git@github.com:theforeman/foreman.git","clone_url":"https://github.com/theforeman/foreman.git","svn_url":"https://github.com/theforeman/foreman","homepage":"http://theforeman.org","size":72706,"stargazers_count":1108,"watchers_count":1108,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":561,"mirror_url":null,"open_issues_count":92,"forks":561,"open_issues":92,"watchers":1108,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3984"},"html":{"href":"https://github.com/theforeman/foreman/pull/3984"},"issue":{"href":"https://api.github.com/repos/theforeman/foreman/issues/3984"},"comments":{"href":"https://api.github.com/repos/theforeman/foreman/issues/3984/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3984/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3984/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/foreman/statuses/ecb2b1e5c717fbdf9c4071b5dcf0324e20c3547e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":274,"deletions":54,"changed_files":29}}
{"actor":{"display_login":"ares"}}