{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react-native/pulls/comments/62429513","id":62429513,"diff_hunk":"@@ -137,11 +153,11 @@ const RefreshControl = React.createClass({\n   },\n \n   _onRefresh() {\n+    this._lastNativeRefreshing = true;\n+\n     this.props.onRefresh && this.props.onRefresh();\n \n-    if (this._nativeRef) {\n-      this._nativeRef.setNativeProps({refreshing: this.props.refreshing});\n-    }\n+    this.forceUpdate();","path":"Libraries/Components/RefreshControl/RefreshControl.js","position":45,"original_position":45,"commit_id":"35a056aa42e2c08c4de420290ae8588a6a9c5a32","original_commit_id":"35a056aa42e2c08c4de420290ae8588a6a9c5a32","user":{"login":"ide","id":379606,"avatar_url":"https://avatars.githubusercontent.com/u/379606?v=3","gravatar_id":"","url":"https://api.github.com/users/ide","html_url":"https://github.com/ide","followers_url":"https://api.github.com/users/ide/followers","following_url":"https://api.github.com/users/ide/following{/other_user}","gists_url":"https://api.github.com/users/ide/gists{/gist_id}","starred_url":"https://api.github.com/users/ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ide/subscriptions","organizations_url":"https://api.github.com/users/ide/orgs","repos_url":"https://api.github.com/users/ide/repos","events_url":"https://api.github.com/users/ide/events{/privacy}","received_events_url":"https://api.github.com/users/ide/received_events","type":"User","site_admin":false},"body":"If the user calls `setState`, we'll run a render pass and `componentDidUpdate` will be called by React as usual, so this `forceUpdate` call is necessary only when the user doesn't re-render the RefreshControl (I think?).\r\n\r\nCan you add a short comment explaining that we want to update this component to reconcile the refreshing state between native and JS whether or not the user updates this component in the `onRefresh` callback?","created_at":"2016-05-08T09:49:40Z","updated_at":"2016-05-08T09:49:40Z","html_url":"https://github.com/facebook/react-native/pull/7445#discussion_r62429513","pull_request_url":"https://api.github.com/repos/facebook/react-native/pulls/7445","_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments/62429513"},"html":{"href":"https://github.com/facebook/react-native/pull/7445#discussion_r62429513"},"pull_request":{"href":"https://api.github.com/repos/facebook/react-native/pulls/7445"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/7445","id":69262498,"html_url":"https://github.com/facebook/react-native/pull/7445","diff_url":"https://github.com/facebook/react-native/pull/7445.diff","patch_url":"https://github.com/facebook/react-native/pull/7445.patch","issue_url":"https://api.github.com/repos/facebook/react-native/issues/7445","number":7445,"state":"open","locked":false,"title":"Make RefreshControl properly controlled by JS","user":{"login":"janicduplessis","id":2677334,"avatar_url":"https://avatars.githubusercontent.com/u/2677334?v=3","gravatar_id":"","url":"https://api.github.com/users/janicduplessis","html_url":"https://github.com/janicduplessis","followers_url":"https://api.github.com/users/janicduplessis/followers","following_url":"https://api.github.com/users/janicduplessis/following{/other_user}","gists_url":"https://api.github.com/users/janicduplessis/gists{/gist_id}","starred_url":"https://api.github.com/users/janicduplessis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janicduplessis/subscriptions","organizations_url":"https://api.github.com/users/janicduplessis/orgs","repos_url":"https://api.github.com/users/janicduplessis/repos","events_url":"https://api.github.com/users/janicduplessis/events{/privacy}","received_events_url":"https://api.github.com/users/janicduplessis/received_events","type":"User","site_admin":false},"body":"There was an issue with the way we made `RefreshControl` a controlled component when react doesn't render synchronously. This fixes the issue by using the same technique used in the commit 0cd2904b235f53ed684bb9898280461e2cee0b5b for`PickerAndroid`\r\n\r\n**Test plan (required)**\r\n\r\nTested normal behaviour and tested that if not setting the `refreshing` prop to `true` during the `onRefresh` callback that the `RefreshControl` stops refreshing immediately. Also made sure that `setNativeProps` is only called if needed when the native refreshing state is not in sync with JS.\r\n\r\nFix #7414","created_at":"2016-05-08T07:05:03Z","updated_at":"2016-05-08T09:49:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"746ed32bab64dec7e0b0be3e14b67d7c99cdb711","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react-native/pulls/7445/commits","review_comments_url":"https://api.github.com/repos/facebook/react-native/pulls/7445/comments","review_comment_url":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/7445/comments","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/35a056aa42e2c08c4de420290ae8588a6a9c5a32","head":{"label":"janicduplessis:refresh-control-controlled","ref":"refresh-control-controlled","sha":"35a056aa42e2c08c4de420290ae8588a6a9c5a32","user":{"login":"janicduplessis","id":2677334,"avatar_url":"https://avatars.githubusercontent.com/u/2677334?v=3","gravatar_id":"","url":"https://api.github.com/users/janicduplessis","html_url":"https://github.com/janicduplessis","followers_url":"https://api.github.com/users/janicduplessis/followers","following_url":"https://api.github.com/users/janicduplessis/following{/other_user}","gists_url":"https://api.github.com/users/janicduplessis/gists{/gist_id}","starred_url":"https://api.github.com/users/janicduplessis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janicduplessis/subscriptions","organizations_url":"https://api.github.com/users/janicduplessis/orgs","repos_url":"https://api.github.com/users/janicduplessis/repos","events_url":"https://api.github.com/users/janicduplessis/events{/privacy}","received_events_url":"https://api.github.com/users/janicduplessis/received_events","type":"User","site_admin":false},"repo":{"id":33167181,"name":"react-native","full_name":"janicduplessis/react-native","owner":{"login":"janicduplessis","id":2677334,"avatar_url":"https://avatars.githubusercontent.com/u/2677334?v=3","gravatar_id":"","url":"https://api.github.com/users/janicduplessis","html_url":"https://github.com/janicduplessis","followers_url":"https://api.github.com/users/janicduplessis/followers","following_url":"https://api.github.com/users/janicduplessis/following{/other_user}","gists_url":"https://api.github.com/users/janicduplessis/gists{/gist_id}","starred_url":"https://api.github.com/users/janicduplessis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janicduplessis/subscriptions","organizations_url":"https://api.github.com/users/janicduplessis/orgs","repos_url":"https://api.github.com/users/janicduplessis/repos","events_url":"https://api.github.com/users/janicduplessis/events{/privacy}","received_events_url":"https://api.github.com/users/janicduplessis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/janicduplessis/react-native","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/janicduplessis/react-native","forks_url":"https://api.github.com/repos/janicduplessis/react-native/forks","keys_url":"https://api.github.com/repos/janicduplessis/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/janicduplessis/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/janicduplessis/react-native/teams","hooks_url":"https://api.github.com/repos/janicduplessis/react-native/hooks","issue_events_url":"https://api.github.com/repos/janicduplessis/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/janicduplessis/react-native/events","assignees_url":"https://api.github.com/repos/janicduplessis/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/janicduplessis/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/janicduplessis/react-native/tags","blobs_url":"https://api.github.com/repos/janicduplessis/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/janicduplessis/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/janicduplessis/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/janicduplessis/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/janicduplessis/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/janicduplessis/react-native/languages","stargazers_url":"https://api.github.com/repos/janicduplessis/react-native/stargazers","contributors_url":"https://api.github.com/repos/janicduplessis/react-native/contributors","subscribers_url":"https://api.github.com/repos/janicduplessis/react-native/subscribers","subscription_url":"https://api.github.com/repos/janicduplessis/react-native/subscription","commits_url":"https://api.github.com/repos/janicduplessis/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/janicduplessis/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/janicduplessis/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/janicduplessis/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/janicduplessis/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/janicduplessis/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/janicduplessis/react-native/merges","archive_url":"https://api.github.com/repos/janicduplessis/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/janicduplessis/react-native/downloads","issues_url":"https://api.github.com/repos/janicduplessis/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/janicduplessis/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/janicduplessis/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/janicduplessis/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/janicduplessis/react-native/labels{/name}","releases_url":"https://api.github.com/repos/janicduplessis/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/janicduplessis/react-native/deployments","created_at":"2015-03-31T05:43:42Z","updated_at":"2016-04-24T06:19:07Z","pushed_at":"2016-05-08T08:44:13Z","git_url":"git://github.com/janicduplessis/react-native.git","ssh_url":"git@github.com:janicduplessis/react-native.git","clone_url":"https://github.com/janicduplessis/react-native.git","svn_url":"https://github.com/janicduplessis/react-native","homepage":"http://facebook.github.io/react-native/","size":43184,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"0cd2904b235f53ed684bb9898280461e2cee0b5b","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":29028775,"name":"react-native","full_name":"facebook/react-native","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react-native","description":"A framework for building native apps with React.","fork":false,"url":"https://api.github.com/repos/facebook/react-native","forks_url":"https://api.github.com/repos/facebook/react-native/forks","keys_url":"https://api.github.com/repos/facebook/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react-native/teams","hooks_url":"https://api.github.com/repos/facebook/react-native/hooks","issue_events_url":"https://api.github.com/repos/facebook/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react-native/events","assignees_url":"https://api.github.com/repos/facebook/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react-native/tags","blobs_url":"https://api.github.com/repos/facebook/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react-native/languages","stargazers_url":"https://api.github.com/repos/facebook/react-native/stargazers","contributors_url":"https://api.github.com/repos/facebook/react-native/contributors","subscribers_url":"https://api.github.com/repos/facebook/react-native/subscribers","subscription_url":"https://api.github.com/repos/facebook/react-native/subscription","commits_url":"https://api.github.com/repos/facebook/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react-native/merges","archive_url":"https://api.github.com/repos/facebook/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react-native/downloads","issues_url":"https://api.github.com/repos/facebook/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react-native/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react-native/deployments","created_at":"2015-01-09T18:10:16Z","updated_at":"2016-05-08T09:25:46Z","pushed_at":"2016-05-08T08:53:51Z","git_url":"git://github.com/facebook/react-native.git","ssh_url":"git@github.com:facebook/react-native.git","clone_url":"https://github.com/facebook/react-native.git","svn_url":"https://github.com/facebook/react-native","homepage":"http://facebook.github.io/react-native/","size":100255,"stargazers_count":31829,"watchers_count":31829,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6405,"mirror_url":null,"open_issues_count":742,"forks":6405,"open_issues":742,"watchers":31829,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/7445"},"html":{"href":"https://github.com/facebook/react-native/pull/7445"},"issue":{"href":"https://api.github.com/repos/facebook/react-native/issues/7445"},"comments":{"href":"https://api.github.com/repos/facebook/react-native/issues/7445/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react-native/pulls/7445/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react-native/pulls/7445/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react-native/statuses/35a056aa42e2c08c4de420290ae8588a6a9c5a32"}}}}