{"action":"created","comment":{"url":"https://api.github.com/repos/keybase/client/pulls/comments/72874601","id":72874601,"diff_hunk":"@@ -91,7 +91,8 @@ const styleHeaderThemed = {\n }\n \n const styleTLFHeader = {\n-  height: 64,\n+  ...globalStyles.flexBoxColumn,\n+  minHeight: 64,","path":"shared/folders/files/render.native.js","position":56,"original_position":56,"commit_id":"b7d5e9e30d24053ac10008f99631d5404a9df7ad","original_commit_id":"b7d5e9e30d24053ac10008f99631d5404a9df7ad","user":{"login":"awendland","id":1152104,"avatar_url":"https://avatars.githubusercontent.com/u/1152104?v=3","gravatar_id":"","url":"https://api.github.com/users/awendland","html_url":"https://github.com/awendland","followers_url":"https://api.github.com/users/awendland/followers","following_url":"https://api.github.com/users/awendland/following{/other_user}","gists_url":"https://api.github.com/users/awendland/gists{/gist_id}","starred_url":"https://api.github.com/users/awendland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awendland/subscriptions","organizations_url":"https://api.github.com/users/awendland/orgs","repos_url":"https://api.github.com/users/awendland/repos","events_url":"https://api.github.com/users/awendland/events{/privacy}","received_events_url":"https://api.github.com/users/awendland/received_events","type":"User","site_admin":false},"body":"Is minHeight supported on Android now? I can't find a mention of it in the changelog for RC 0.30. While iOS support is mentioned in RC 0.29.","created_at":"2016-07-29T23:31:29Z","updated_at":"2016-07-29T23:31:29Z","html_url":"https://github.com/keybase/client/pull/3616#discussion_r72874601","pull_request_url":"https://api.github.com/repos/keybase/client/pulls/3616","_links":{"self":{"href":"https://api.github.com/repos/keybase/client/pulls/comments/72874601"},"html":{"href":"https://github.com/keybase/client/pull/3616#discussion_r72874601"},"pull_request":{"href":"https://api.github.com/repos/keybase/client/pulls/3616"}}},"pull_request":{"url":"https://api.github.com/repos/keybase/client/pulls/3616","id":78916852,"html_url":"https://github.com/keybase/client/pull/3616","diff_url":"https://github.com/keybase/client/pull/3616.diff","patch_url":"https://github.com/keybase/client/pull/3616.patch","issue_url":"https://api.github.com/repos/keybase/client/issues/3616","number":3616,"state":"open","locked":false,"title":"Folder tweaks","user":{"login":"chrisnojima","id":516435,"avatar_url":"https://avatars.githubusercontent.com/u/516435?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisnojima","html_url":"https://github.com/chrisnojima","followers_url":"https://api.github.com/users/chrisnojima/followers","following_url":"https://api.github.com/users/chrisnojima/following{/other_user}","gists_url":"https://api.github.com/users/chrisnojima/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisnojima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisnojima/subscriptions","organizations_url":"https://api.github.com/users/chrisnojima/orgs","repos_url":"https://api.github.com/users/chrisnojima/repos","events_url":"https://api.github.com/users/chrisnojima/events{/privacy}","received_events_url":"https://api.github.com/users/chrisnojima/received_events","type":"User","site_admin":false},"body":"- [x] When I click through deeper into a public TLF, then click back, it sends me back to the private tab in scroll top position. It should bring me back to the same tab, with the same scrolling position I was in (this last point concerns the private tab as well).\r\n- [x] After I ignore a public folder, it bumps me back to the private tab - should stay on public (same for Unignore)\r\n- [x] Ignored folder sections should stay open if I opened them - right now they collapse if I go to an inner folder and go back\r\n\r\n Ignored folders:\r\n- [x] Avatars should be at 50% opacity\r\n- [x] Text that shows up when you expand: this looks semibold? Should be Lato regular (regular body small on dark)\r\nTop tabs:\r\n- [x] change font weight of private/ and public/ to semibold\r\n- [x] When scrolling - maintain 1px line underneath the tabbed headers so it looks separated from the content below (see more general ticket  DESKTOP-1307 TO DO  to fix list dividers)\r\n\r\nInterior folder view:\r\n- [x] Add 64px padding around the text area so that longer folder names don't crash into the right-hand nav\r\n- [x] When the folder name wraps to two lines, it crashes into to avatars, and then when it wraps to three lines, it crashes into avatars + avatars then crash into back button (see attached). Let's have this area expand downward instead.\r\n- [x] Divider is missing underneath section divider, should be white 5% on dark blue and black 5% on white. See: https://zpl.io/Z1008aU. And it should also be here when closed: https://zpl.io/TyTsH. Devices tab also has it wrong (only when open).\r\n- [x] Little caret not aligned with section header. Push down of about 4px.\r\n- [x] Let's stack \"open\" and \"ignore\" buttons on top of each other with open on top, it's weird to have them next to each other with the Ignore first.\r\n- [x] Ignore button on private folders should follow the \"Secondary for dark backgrounds\" button style: https://zpl.io/2rqNgg\r\n- [x] Folder row: Open link should get underlined on hover\r\n- [x] Disallow ignore on your own folders\r\n- [x] Page background should be darkBlue3 (#0a3052) - the darkBlue (#195080) should only go on the row itself.\r\n- [x] Damier pattern on retina screens looks bad - we should use the @2x version on retina screens\r\n- [x] Row background should be darkBlue4\r\n- [x] Folder title should be white_40\r\n- [x] Avatars should sit on a midnightBlue background and then be turned down to 50% opacity (if no background, we will see the damier pattern behind, which we don't want)\r\n- [x] When on the public tab, the public/ title should be black 75% and the private/ title should be black 60%\r\n- [x] Open link missing on hover (white on white) - design: https://zpl.io/1G9mVx\r\n- [x] If you have a long folder list (I have a long list of public folders), clicking the ignore expands it but you don't see that it actually expanded until you scroll. Can we add in a little bit of scrolling (+ ease-in animation) upon click to expand and show you what just showed up? If this is unclear just swing by my desk and I'll explain \r\n\r\nOther:\r\n- [x] On avatars: Weird aliasing around avatar images that looks like a subtle white stroke around them (ticket   DESKTOP-1041 TO DO  )\r\n- [x] Damier pattern on the left for ignored and locked private folders is a different one, I added it to the styleguide: https://zpl.io/1hpA2P (scroll all the way down) (take @2x version for retina screens too)\r\n- [x] Folder title should be yellowGreen2_75 (< new color!)\r\n- [x] row background should be white_40\r\n- [x] Avatars should be 50% opaque\r\n- [x] I clicked \"ignore\" on my own public folder and it let me! Ahh! Maybe we should not surface that button for my own personal, permanent folders, unless we plan to allow for this kind of ignoring?\r\n- [ ] ~~Group icon and has-stuff icon for ignored or locked folders are different (darker) - assets available on the Zeplin sheet above.~~\r\n- [ ] ~~Ignored public folders style: (all detailed on Zeplin here: https://zpl.io/Z2p7znW - section Folder list item)~~\r\n- [ ] ~~Left column background should be yellowGreen3~~\r\n- [ ] ~~Group icon and has-stuff icon are different (more faded) - assets available on the Zeplin sheet above.~~\r\n- [ ] ~~When I clicked \"open folder\" on an ignored folder it caused the app to seize up a bit - maybe just some weird latency caused by the fact that you're also \"un-ignoring\" it once you click it?~~\r\n- [ ] ~~Inner ignored folder pages: should we add that text again? \"This folder won't show up on your computer and  you won't receive alerts about it. \"~~\r\n- [ ] ~~On group folders, avatar should be the group icon and expand to all avatars on hover with a nice ease-in animation~~\r\n- [ ] ~~When I tab between folders in a the same app session, it should remember the scroll position of where I was - it looks like now it remembers the same scroll position for both tabs, so if I scroll one up, it scrolls the other tab up.~~ [a lot more work than we can do in this ticket]\r\n","created_at":"2016-07-26T20:10:46Z","updated_at":"2016-07-29T23:31:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8fe21dd129597cfd79aca526b14bd6aeeb8fd263","assignee":{"login":"awendland","id":1152104,"avatar_url":"https://avatars.githubusercontent.com/u/1152104?v=3","gravatar_id":"","url":"https://api.github.com/users/awendland","html_url":"https://github.com/awendland","followers_url":"https://api.github.com/users/awendland/followers","following_url":"https://api.github.com/users/awendland/following{/other_user}","gists_url":"https://api.github.com/users/awendland/gists{/gist_id}","starred_url":"https://api.github.com/users/awendland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awendland/subscriptions","organizations_url":"https://api.github.com/users/awendland/orgs","repos_url":"https://api.github.com/users/awendland/repos","events_url":"https://api.github.com/users/awendland/events{/privacy}","received_events_url":"https://api.github.com/users/awendland/received_events","type":"User","site_admin":false},"assignees":[{"login":"awendland","id":1152104,"avatar_url":"https://avatars.githubusercontent.com/u/1152104?v=3","gravatar_id":"","url":"https://api.github.com/users/awendland","html_url":"https://github.com/awendland","followers_url":"https://api.github.com/users/awendland/followers","following_url":"https://api.github.com/users/awendland/following{/other_user}","gists_url":"https://api.github.com/users/awendland/gists{/gist_id}","starred_url":"https://api.github.com/users/awendland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awendland/subscriptions","organizations_url":"https://api.github.com/users/awendland/orgs","repos_url":"https://api.github.com/users/awendland/repos","events_url":"https://api.github.com/users/awendland/events{/privacy}","received_events_url":"https://api.github.com/users/awendland/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/keybase/client/pulls/3616/commits","review_comments_url":"https://api.github.com/repos/keybase/client/pulls/3616/comments","review_comment_url":"https://api.github.com/repos/keybase/client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keybase/client/issues/3616/comments","statuses_url":"https://api.github.com/repos/keybase/client/statuses/b7d5e9e30d24053ac10008f99631d5404a9df7ad","head":{"label":"keybase:nojima/DESKTOP-1507-folder-tweaks","ref":"nojima/DESKTOP-1507-folder-tweaks","sha":"b7d5e9e30d24053ac10008f99631d5404a9df7ad","user":{"login":"keybase","id":5400834,"avatar_url":"https://avatars.githubusercontent.com/u/5400834?v=3","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"repo":{"id":29099181,"name":"client","full_name":"keybase/client","owner":{"login":"keybase","id":5400834,"avatar_url":"https://avatars.githubusercontent.com/u/5400834?v=3","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keybase/client","description":"Keybase Go Library, Client, Service, OS X, iOS, Android, Electron","fork":false,"url":"https://api.github.com/repos/keybase/client","forks_url":"https://api.github.com/repos/keybase/client/forks","keys_url":"https://api.github.com/repos/keybase/client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keybase/client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keybase/client/teams","hooks_url":"https://api.github.com/repos/keybase/client/hooks","issue_events_url":"https://api.github.com/repos/keybase/client/issues/events{/number}","events_url":"https://api.github.com/repos/keybase/client/events","assignees_url":"https://api.github.com/repos/keybase/client/assignees{/user}","branches_url":"https://api.github.com/repos/keybase/client/branches{/branch}","tags_url":"https://api.github.com/repos/keybase/client/tags","blobs_url":"https://api.github.com/repos/keybase/client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keybase/client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keybase/client/git/refs{/sha}","trees_url":"https://api.github.com/repos/keybase/client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keybase/client/statuses/{sha}","languages_url":"https://api.github.com/repos/keybase/client/languages","stargazers_url":"https://api.github.com/repos/keybase/client/stargazers","contributors_url":"https://api.github.com/repos/keybase/client/contributors","subscribers_url":"https://api.github.com/repos/keybase/client/subscribers","subscription_url":"https://api.github.com/repos/keybase/client/subscription","commits_url":"https://api.github.com/repos/keybase/client/commits{/sha}","git_commits_url":"https://api.github.com/repos/keybase/client/git/commits{/sha}","comments_url":"https://api.github.com/repos/keybase/client/comments{/number}","issue_comment_url":"https://api.github.com/repos/keybase/client/issues/comments{/number}","contents_url":"https://api.github.com/repos/keybase/client/contents/{+path}","compare_url":"https://api.github.com/repos/keybase/client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keybase/client/merges","archive_url":"https://api.github.com/repos/keybase/client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keybase/client/downloads","issues_url":"https://api.github.com/repos/keybase/client/issues{/number}","pulls_url":"https://api.github.com/repos/keybase/client/pulls{/number}","milestones_url":"https://api.github.com/repos/keybase/client/milestones{/number}","notifications_url":"https://api.github.com/repos/keybase/client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keybase/client/labels{/name}","releases_url":"https://api.github.com/repos/keybase/client/releases{/id}","deployments_url":"https://api.github.com/repos/keybase/client/deployments","created_at":"2015-01-11T17:17:12Z","updated_at":"2016-07-29T22:37:03Z","pushed_at":"2016-07-29T23:11:30Z","git_url":"git://github.com/keybase/client.git","ssh_url":"git@github.com:keybase/client.git","clone_url":"https://github.com/keybase/client.git","svn_url":"https://github.com/keybase/client","homepage":"","size":160343,"stargazers_count":636,"watchers_count":636,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":343,"forks":51,"open_issues":343,"watchers":636,"default_branch":"master"}},"base":{"label":"keybase:master","ref":"master","sha":"d7bc0a49f69125a0339251d5f1600b2c5167f35b","user":{"login":"keybase","id":5400834,"avatar_url":"https://avatars.githubusercontent.com/u/5400834?v=3","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"repo":{"id":29099181,"name":"client","full_name":"keybase/client","owner":{"login":"keybase","id":5400834,"avatar_url":"https://avatars.githubusercontent.com/u/5400834?v=3","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keybase/client","description":"Keybase Go Library, Client, Service, OS X, iOS, Android, Electron","fork":false,"url":"https://api.github.com/repos/keybase/client","forks_url":"https://api.github.com/repos/keybase/client/forks","keys_url":"https://api.github.com/repos/keybase/client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keybase/client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keybase/client/teams","hooks_url":"https://api.github.com/repos/keybase/client/hooks","issue_events_url":"https://api.github.com/repos/keybase/client/issues/events{/number}","events_url":"https://api.github.com/repos/keybase/client/events","assignees_url":"https://api.github.com/repos/keybase/client/assignees{/user}","branches_url":"https://api.github.com/repos/keybase/client/branches{/branch}","tags_url":"https://api.github.com/repos/keybase/client/tags","blobs_url":"https://api.github.com/repos/keybase/client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keybase/client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keybase/client/git/refs{/sha}","trees_url":"https://api.github.com/repos/keybase/client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keybase/client/statuses/{sha}","languages_url":"https://api.github.com/repos/keybase/client/languages","stargazers_url":"https://api.github.com/repos/keybase/client/stargazers","contributors_url":"https://api.github.com/repos/keybase/client/contributors","subscribers_url":"https://api.github.com/repos/keybase/client/subscribers","subscription_url":"https://api.github.com/repos/keybase/client/subscription","commits_url":"https://api.github.com/repos/keybase/client/commits{/sha}","git_commits_url":"https://api.github.com/repos/keybase/client/git/commits{/sha}","comments_url":"https://api.github.com/repos/keybase/client/comments{/number}","issue_comment_url":"https://api.github.com/repos/keybase/client/issues/comments{/number}","contents_url":"https://api.github.com/repos/keybase/client/contents/{+path}","compare_url":"https://api.github.com/repos/keybase/client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keybase/client/merges","archive_url":"https://api.github.com/repos/keybase/client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keybase/client/downloads","issues_url":"https://api.github.com/repos/keybase/client/issues{/number}","pulls_url":"https://api.github.com/repos/keybase/client/pulls{/number}","milestones_url":"https://api.github.com/repos/keybase/client/milestones{/number}","notifications_url":"https://api.github.com/repos/keybase/client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keybase/client/labels{/name}","releases_url":"https://api.github.com/repos/keybase/client/releases{/id}","deployments_url":"https://api.github.com/repos/keybase/client/deployments","created_at":"2015-01-11T17:17:12Z","updated_at":"2016-07-29T22:37:03Z","pushed_at":"2016-07-29T23:11:30Z","git_url":"git://github.com/keybase/client.git","ssh_url":"git@github.com:keybase/client.git","clone_url":"https://github.com/keybase/client.git","svn_url":"https://github.com/keybase/client","homepage":"","size":160343,"stargazers_count":636,"watchers_count":636,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":343,"forks":51,"open_issues":343,"watchers":636,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/keybase/client/pulls/3616"},"html":{"href":"https://github.com/keybase/client/pull/3616"},"issue":{"href":"https://api.github.com/repos/keybase/client/issues/3616"},"comments":{"href":"https://api.github.com/repos/keybase/client/issues/3616/comments"},"review_comments":{"href":"https://api.github.com/repos/keybase/client/pulls/3616/comments"},"review_comment":{"href":"https://api.github.com/repos/keybase/client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keybase/client/pulls/3616/commits"},"statuses":{"href":"https://api.github.com/repos/keybase/client/statuses/b7d5e9e30d24053ac10008f99631d5404a9df7ad"}}}}
{"actor":{"display_login":"awendland"}}