{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/63288337","id":63288337,"diff_hunk":"@@ -16,9 +16,11 @@ public function __toString()\n         try {\n             throw $this->exception;\n         } catch (\\Exception $e) {\n-            // Using user_error() here is on purpose so we do not forget\n-            // that this alias also should work alongside with trigger_error().\n-            return user_error($e, E_USER_ERROR);\n+        } catch (\\Throwable $e) {","path":"src/Symfony/Component/Debug/Tests/Fixtures/ToStringThrower.php","position":7,"original_position":7,"commit_id":"c450d19db669de8dd487f320896890401b69b02b","original_commit_id":"fab7d232c7c50505f1f0e15dd335b4dc587fb344","user":{"login":"nicolas-grekas","id":243674,"avatar_url":"https://avatars.githubusercontent.com/u/243674?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"body":"should be removed (test fixture with predefined behavior)","created_at":"2016-05-15T08:42:14Z","updated_at":"2016-05-15T08:42:14Z","html_url":"https://github.com/symfony/symfony/pull/18765#discussion_r63288337","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/18765","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/63288337"},"html":{"href":"https://github.com/symfony/symfony/pull/18765#discussion_r63288337"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/18765"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/18765","id":69861727,"html_url":"https://github.com/symfony/symfony/pull/18765","diff_url":"https://github.com/symfony/symfony/pull/18765.diff","patch_url":"https://github.com/symfony/symfony/pull/18765.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/18765","number":18765,"state":"open","locked":false,"title":"Catch \\Throwable","user":{"login":"fprochazka","id":158625,"avatar_url":"https://avatars.githubusercontent.com/u/158625?v=3","gravatar_id":"","url":"https://api.github.com/users/fprochazka","html_url":"https://github.com/fprochazka","followers_url":"https://api.github.com/users/fprochazka/followers","following_url":"https://api.github.com/users/fprochazka/following{/other_user}","gists_url":"https://api.github.com/users/fprochazka/gists{/gist_id}","starred_url":"https://api.github.com/users/fprochazka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fprochazka/subscriptions","organizations_url":"https://api.github.com/users/fprochazka/orgs","repos_url":"https://api.github.com/users/fprochazka/repos","events_url":"https://api.github.com/users/fprochazka/events{/privacy}","received_events_url":"https://api.github.com/users/fprochazka/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | 2.3, 2.7, 2.8, 3.0\r\n| Bug fix?      | no\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | Mostly!\r\n| Fixed tickets | n/a\r\n| License       | MIT\r\n| Doc PR        | n/a\r\n\r\nThe first commit is based on symfony/symfony#15949 \r\n\r\n----\r\n\r\nI'm new to symfony, so I'm not sure where are all the places where it makes sense to actually catch the throwable and where not. I added most places that seemed logical and when I wasn't sure, I added it anyway. I'm hoping you guys (and girls?) can point out the places where the catch should not be added, I'll fix it and then I can create several PR's for the older branches. A lot of this IMHO should go also to 3.0.","created_at":"2016-05-12T15:54:00Z","updated_at":"2016-05-15T08:42:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e505b8c82d308361ee7e4d5133a5c0c369112056","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/18765/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/18765/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/18765/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/c450d19db669de8dd487f320896890401b69b02b","head":{"label":"fprochazka:php7-throwable","ref":"php7-throwable","sha":"c450d19db669de8dd487f320896890401b69b02b","user":{"login":"fprochazka","id":158625,"avatar_url":"https://avatars.githubusercontent.com/u/158625?v=3","gravatar_id":"","url":"https://api.github.com/users/fprochazka","html_url":"https://github.com/fprochazka","followers_url":"https://api.github.com/users/fprochazka/followers","following_url":"https://api.github.com/users/fprochazka/following{/other_user}","gists_url":"https://api.github.com/users/fprochazka/gists{/gist_id}","starred_url":"https://api.github.com/users/fprochazka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fprochazka/subscriptions","organizations_url":"https://api.github.com/users/fprochazka/orgs","repos_url":"https://api.github.com/users/fprochazka/repos","events_url":"https://api.github.com/users/fprochazka/events{/privacy}","received_events_url":"https://api.github.com/users/fprochazka/received_events","type":"User","site_admin":false},"repo":{"id":58651158,"name":"symfony","full_name":"fprochazka/symfony","owner":{"login":"fprochazka","id":158625,"avatar_url":"https://avatars.githubusercontent.com/u/158625?v=3","gravatar_id":"","url":"https://api.github.com/users/fprochazka","html_url":"https://github.com/fprochazka","followers_url":"https://api.github.com/users/fprochazka/followers","following_url":"https://api.github.com/users/fprochazka/following{/other_user}","gists_url":"https://api.github.com/users/fprochazka/gists{/gist_id}","starred_url":"https://api.github.com/users/fprochazka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fprochazka/subscriptions","organizations_url":"https://api.github.com/users/fprochazka/orgs","repos_url":"https://api.github.com/users/fprochazka/repos","events_url":"https://api.github.com/users/fprochazka/events{/privacy}","received_events_url":"https://api.github.com/users/fprochazka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fprochazka/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/fprochazka/symfony","forks_url":"https://api.github.com/repos/fprochazka/symfony/forks","keys_url":"https://api.github.com/repos/fprochazka/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fprochazka/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fprochazka/symfony/teams","hooks_url":"https://api.github.com/repos/fprochazka/symfony/hooks","issue_events_url":"https://api.github.com/repos/fprochazka/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/fprochazka/symfony/events","assignees_url":"https://api.github.com/repos/fprochazka/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/fprochazka/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/fprochazka/symfony/tags","blobs_url":"https://api.github.com/repos/fprochazka/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fprochazka/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fprochazka/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/fprochazka/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fprochazka/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/fprochazka/symfony/languages","stargazers_url":"https://api.github.com/repos/fprochazka/symfony/stargazers","contributors_url":"https://api.github.com/repos/fprochazka/symfony/contributors","subscribers_url":"https://api.github.com/repos/fprochazka/symfony/subscribers","subscription_url":"https://api.github.com/repos/fprochazka/symfony/subscription","commits_url":"https://api.github.com/repos/fprochazka/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/fprochazka/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/fprochazka/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/fprochazka/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/fprochazka/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/fprochazka/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fprochazka/symfony/merges","archive_url":"https://api.github.com/repos/fprochazka/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fprochazka/symfony/downloads","issues_url":"https://api.github.com/repos/fprochazka/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/fprochazka/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/fprochazka/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/fprochazka/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fprochazka/symfony/labels{/name}","releases_url":"https://api.github.com/repos/fprochazka/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/fprochazka/symfony/deployments","created_at":"2016-05-12T14:56:36Z","updated_at":"2016-05-12T14:56:53Z","pushed_at":"2016-05-13T09:37:23Z","git_url":"git://github.com/fprochazka/symfony.git","ssh_url":"git@github.com:fprochazka/symfony.git","clone_url":"https://github.com/fprochazka/symfony.git","svn_url":"https://github.com/fprochazka/symfony","homepage":"symfony.com","size":70866,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:2.8","ref":"2.8","sha":"c96d76dd5e6d3fe27548498a98fd3544536bb297","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2016-05-15T06:17:14Z","pushed_at":"2016-05-15T03:17:44Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":129772,"stargazers_count":12320,"watchers_count":12320,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4834,"mirror_url":null,"open_issues_count":745,"forks":4834,"open_issues":745,"watchers":12320,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/18765"},"html":{"href":"https://github.com/symfony/symfony/pull/18765"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/18765"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/18765/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/18765/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/18765/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/c450d19db669de8dd487f320896890401b69b02b"}}}}