{"push_id":1104165274,"size":17,"distinct_size":17,"ref":"refs/heads/master","head":"4d769497c950c1c12dfa8401fa70dfaebf2f0dc7","before":"c77e763eca48a7d81ddc11fd8b60c0b3f011fdbb","commits":[{"sha":"d9ab3baf84a7762aa516eb2dbd97b07d6b3b1824","author":{"email":"f92d001239d67d58ac1d75c5ef3e0a48eba1f658@yahoo.com","name":"skyscraper"},"message":"RC_Channel: Refactor to make data members private\n\nrename all public data members of RC_Channnels with\nleading underscore and make all data members private.\nProvide get_xx and set_xx methods for access\n\n Rationale:\n\n        RC_Channel is a complicated class, which combines\n        several functionalities dealing with stick inputs\n        in pwm and logical units, logical and actual actuator\n        outputs, unit conversion etc, etc\n        The intent of this PR is to clarify existing use of\n        the class. At the basic level it should now be possible\n        to grep all places where private variable is set by\n        searching for the set_xx function.\n\n        (The wider purpose is to provide a more generic and\n        logically simpler method of output mixing. This is a small step)\n\nadd function to save radio trim\n(expression where c is an object of type RC_Channel)\nold public member(int16_t)   get function -> int16_t     set function (int16_t)\n\n(expression where c is an object of type RC_Channel)\n\nc.radio_in                     c.get_radio_in()           c.set_radio_in(v)\nc.control_in                   c.get_control_in()         c.set_control_in(v)\nc.servo_out                    c.get_servo_out()          c.set_servo_out(v)\nc.pwm_out                      c.get_pwm_out()            // use existing\nc.radio_out                    c.get_radio_out()          c.set_radio_out(v)\nc.radio_max                    c.get_radio_max()          c.set_radio_max(v)\nc.radio_min                    c.get_radio_min()          c.set_radio_min(v)\nc.radio_trim                   c.get_radio_trim()         c.set_radio_trim(v);\n// other\nc.min_max_configured() // return true if min and max are configured\nc.save_radio_trim()    // save radio trim to eeprom","distinct":true,"url":"https://api.github.com/repos/ArduPilot/ardupilot/commits/d9ab3baf84a7762aa516eb2dbd97b07d6b3b1824"},{"sha":"d16659331f26f80e89783c76b2e77e0c36c5730f","author":{"email":"f92d001239d67d58ac1d75c5ef3e0a48eba1f658@yahoo.com","name":"skyscraper"},"message":"RC_Channel_aux: Rename static member functions\n\nFurther to refactor of RC_Channel class which included\nadding get_xx set_xx methods, some methods names are now\nin conflict with those in the derived RC_Channel_aux class.\nTo keep a uniform naming convention in RC_Channel where\nfunctions are most used and most numerous, the offending\nfunctions in RC_Channel__aux are renamed as follows\n\n RC_Channel_aux::set_radio_trim(Aux_servo_function_t function)\n    to RC_Channel_aux::set_trim_to_radio_in_for(Aux_servo_function_t function)\n\n RC_Channel_aux::set_servo_out(Aux_servo_function_t function, int16_t value)\n    to RC_Channel_aux::set_servo_out_for(Aux_servo_function_t function, int16_t value)\n\n Rationale:\n\n        RC_Channel is a complicated class, which combines\n        several functionalities dealing with stick inputs\n        in pwm and logical units, logical and actual actuator\n        outputs, unit conversion etc, etc\n        The intent of this PR is to clarify existing use of\n        the class. At the basic level it should now be possible\n        to grep all places where private variable is set by\n        searching for the set_xx function.\n\n        (The wider purpose is to provide a more generic and\n        logically simpler method of output mixing. This is a small step)","distinct":true,"url":"https://api.github.com/repos/ArduPilot/ardupilot/commits/d16659331f26f80e89783c76b2e77e0c36c5730f"},{"sha":"ba9462d13d1ef6bf1d0962ad028c1dc4c6065ddb","author":{"email":"f92d001239d67d58ac1d75c5ef3e0a48eba1f658@yahoo.com","name":"skyscraper"},"message":"APM_OBC: Fix up after RC_Channels refactor\n\nFurther to refactor of RC_Channel class which included\nadding get_xx set_xx methods, change reads and writes to the public members\nto calls to  get and set functionsss\n\nold public member(int16_t)   get function -> int16_t     set function (int16_t)\n(expression where c is an object of type RC_Channel)\nc.radio_in                     c.get_radio_in()           c.set_radio_in(v)\nc.control_in                   c.get_control_in()         c.set_control_in(v)\nc.servo_out                    c.get_servo_out()          c.set_servo_out(v)\nc.pwm_out                      c.get_pwm_out()            // use existing\nc.radio_out                    c.get_radio_out()          c.set_radio_out(v)\nc.radio_max                    c.get_radio_max()          c.set_radio_max(v)\nc.radio_min                    c.get_radio_min()          c.set_radio_min(v)\nc.radio_trim                   c.get_radio_trim()         c.set_radio_trim(v);\n\nc.min_max_configured() // return true if min and max are configured\n\nBecause data members of RC_Channels are now private and so cannot be written directly\n some overloads are provided in the Plane classes to provide the old functionality\n\nnew overload Plane::stick_mix_channel(RC_Channel *channel)\nwhich forwards to the previously existing\nvoid stick_mix_channel(RC_Channel *channel, int16_t &servo_out);\n\nnew overload Plane::channel_output_mixer(Rc_Channel* , RC_Channel*)const\nwhich forwards to\n(uint8_t mixing_type, int16_t & chan1, int16_t & chan2)const;\n\nRename functions\n\n RC_Channel_aux::set_radio_trim(Aux_servo_function_t function)\n    to RC_Channel_aux::set_trim_to_radio_in_for(Aux_servo_function_t function)\n\n RC_Channel_aux::set_servo_out(Aux_servo_function_t function, int16_t value)\n    to RC_Channel_aux::set_servo_out_for(Aux_servo_function_t function, int16_t value)\n\n Rationale:\n\n        RC_Channel is a complicated class, which combines\n        several functionalities dealing with stick inputs\n        in pwm and logical units, logical and actual actuator\n        outputs, unit conversion etc, etc\n        The intent of this PR is to clarify existing use of\n        the class. At the basic level it should now be possible\n        to grep all places where private variable is set by\n        searching for the set_xx function.\n\n        (The wider purpose is to provide a more generic and\n        logically simpler method of output mixing. This is a small step)","distinct":true,"url":"https://api.github.com/repos/ArduPilot/ardupilot/commits/ba9462d13d1ef6bf1d0962ad028c1dc4c6065ddb"},{"sha":"daec4ea10e4d4ab5e423796ab33738b6b15445b3","author":{"email":"f92d001239d67d58ac1d75c5ef3e0a48eba1f658@yahoo.com","name":"skyscraper"},"message":"AP_Motors: Fix up after RC_Channels refactor\n\nFurther to refactor of RC_Channel class which included\nadding get_xx set_xx methods, change reads and writes to the public members\nto calls to  get and set functionsss\n\nold public member(int16_t)   get function -> int16_t     set function (int16_t)\n(expression where c is an object of type RC_Channel)\nc.radio_in                     c.get_radio_in()           c.set_radio_in(v)\nc.control_in                   c.get_control_in()         c.set_control_in(v)\nc.servo_out                    c.get_servo_out()          c.set_servo_out(v)\nc.pwm_out                      c.get_pwm_out()            // use existing\nc.radio_out                    c.get_radio_out()          c.set_radio_out(v)\nc.radio_max                    c.get_radio_max()          c.set_radio_max(v)\nc.radio_min                    c.get_radio_min()          c.set_radio_min(v)\nc.radio_trim                   c.get_radio_trim()         c.set_radio_trim(v);\n\nc.min_max_configured() // return true if min and max are configured\n\nBecause data members of RC_Channels are now private and so cannot be written directly\n some overloads are provided in the Plane classes to provide the old functionality\n\nnew overload Plane::stick_mix_channel(RC_Channel *channel)\nwhich forwards to the previously existing\nvoid stick_mix_channel(RC_Channel *channel, int16_t &servo_out);\n\nnew overload Plane::channel_output_mixer(Rc_Channel* , RC_Channel*)const\nwhich forwards to\n(uint8_t mixing_type, int16_t & chan1, int16_t & chan2)const;\n\nRename functions\n\n RC_Channel_aux::set_radio_trim(Aux_servo_function_t function)\n    to RC_Channel_aux::set_trim_to_radio_in_for(Aux_servo_function_t function)\n\n RC_Channel_aux::set_servo_out(Aux_servo_function_t function, int16_t value)\n    to RC_Channel_aux::set_servo_out_for(Aux_servo_function_t function, int16_t value)\n\n Rationale:\n\n        RC_Channel is a complicated class, which combines\n        several functionalities dealing with stick inputs\n        in pwm and logical units, logical and actual actuator\n        outputs, unit conversion etc, etc\n        The intent of this PR is to clarify existing use of\n        the class. At the basic level it should now be possible\n        to grep all places where private variable is set by\n        searching for the set_xx function.\n\n        (The wider purpose is to provide a more generic and\n        logically simpler method of output mixing. This is a small step)","distinct":true,"url":"https://api.github.com/repos/ArduPilot/ardupilot/commits/daec4ea10e4d4ab5e423796ab33738b6b15445b3"},{"sha":"8b9c96814b61153b6f31e2bccfbc4149c6a8527c","author":{"email":"f92d001239d67d58ac1d75c5ef3e0a48eba1f658@yahoo.com","name":"skyscraper"},"message":"AP_Mount: Fix up after RC_Channels refactor\n\nFurther to refactor of RC_Channel class which included\nadding get_xx set_xx methods, change reads and writes to the public members\nto calls to  get and set functionsss\n\nold public member(int16_t)   get function -> int16_t     set function (int16_t)\n(expression where c is an object of type RC_Channel)\nc.radio_in                     c.get_radio_in()           c.set_radio_in(v)\nc.control_in                   c.get_control_in()         c.set_control_in(v)\nc.servo_out                    c.get_servo_out()          c.set_servo_out(v)\nc.pwm_out                      c.get_pwm_out()            // use existing\nc.radio_out                    c.get_radio_out()          c.set_radio_out(v)\nc.radio_max                    c.get_radio_max()          c.set_radio_max(v)\nc.radio_min                    c.get_radio_min()          c.set_radio_min(v)\nc.radio_trim                   c.get_radio_trim()         c.set_radio_trim(v);\n\nc.min_max_configured() // return true if min and max are configured\n\nBecause data members of RC_Channels are now private and so cannot be written directly\n some overloads are provided in the Plane classes to provide the old functionality\n\nnew overload Plane::stick_mix_channel(RC_Channel *channel)\nwhich forwards to the previously existing\nvoid stick_mix_channel(RC_Channel *channel, int16_t &servo_out);\n\nnew overload Plane::channel_output_mixer(Rc_Channel* , RC_Channel*)const\nwhich forwards to\n(uint8_t mixing_type, int16_t & chan1, int16_t & chan2)const;\n\nRename functions\n\n RC_Channel_aux::set_radio_trim(Aux_servo_function_t function)\n    to RC_Channel_aux::set_trim_to_radio_in_for(Aux_servo_function_t function)\n\n RC_Channel_aux::set_servo_out(Aux_servo_function_t function, int16_t value)\n    to RC_Channel_aux::set_servo_out_for(Aux_servo_function_t function, int16_t value)\n\n Rationale:\n\n        RC_Channel is a complicated class, which combines\n        several functionalities dealing with stick inputs\n        in pwm and logical units, logical and actual actuator\n        outputs, unit conversion etc, etc\n        The intent of this PR is to clarify existing use of\n        the class. At the basic level it should now be possible\n        to grep all places where private variable is set by\n        searching for the set_xx function.\n\n        (The wider purpose is to provide a more generic and\n        logically simpler method of output mixing. This is a small step)","distinct":true,"url":"https://api.github.com/repos/ArduPilot/ardupilot/commits/8b9c96814b61153b6f31e2bccfbc4149c6a8527c"},{"sha":"c4aa55a6d92b2f96314693920adb6cd6164286bc","author":{"email":"f92d001239d67d58ac1d75c5ef3e0a48eba1f658@yahoo.com","name":"skyscraper"},"message":"AP_ServoRelayEvents: Fix up after RC_Channels refactor\n\nFurther to refactor of RC_Channel class which included\nadding get_xx set_xx methods, change reads and writes to the public members\nto calls to  get and set functionsss\n\nold public member(int16_t)   get function -> int16_t     set function (int16_t)\n(expression where c is an object of type RC_Channel)\nc.radio_in                     c.get_radio_in()           c.set_radio_in(v)\nc.control_in                   c.get_control_in()         c.set_control_in(v)\nc.servo_out                    c.get_servo_out()          c.set_servo_out(v)\nc.pwm_out                      c.get_pwm_out()            // use existing\nc.radio_out                    c.get_radio_out()          c.set_radio_out(v)\nc.radio_max                    c.get_radio_max()          c.set_radio_max(v)\nc.radio_min                    c.get_radio_min()          c.set_radio_min(v)\nc.radio_trim                   c.get_radio_trim()         c.set_radio_trim(v);\n\nc.min_max_configured() // return true if min and max are configured\n\nBecause data members of RC_Channels are now private and so cannot be written directly\n some overloads are provided in the Plane classes to provide the old functionality\n\nnew overload Plane::stick_mix_channel(RC_Channel *channel)\nwhich forwards to the previously existing\nvoid stick_mix_channel(RC_Channel *channel, int16_t &servo_out);\n\nnew overload Plane::channel_output_mixer(Rc_Channel* , RC_Channel*)const\nwhich forwards to\n(uint8_t mixing_type, int16_t & chan1, int16_t & chan2)const;\n\nRename functions\n\n RC_Channel_aux::set_radio_trim(Aux_servo_function_t function)\n    to RC_Channel_aux::set_trim_to_radio_in_for(Aux_servo_function_t function)\n\n RC_Channel_aux::set_servo_out(Aux_servo_function_t function, int16_t value)\n    to RC_Channel_aux::set_servo_out_for(Aux_servo_function_t function, int16_t value)\n\n Rationale:\n\n        RC_Channel is a complicated class, which combines\n        several functionalities dealing with stick inputs\n        in pwm and logical units, logical and actual actuator\n        outputs, unit conversion etc, etc\n        The intent of this PR is to clarify existing use of\n        the class. At the basic level it should now be possible\n        to grep all places where private variable is set by\n        searching for the set_xx function.\n\n        (The wider purpose is to provide a more generic and\n        logically simpler method of output mixing. This is a small step)","distinct":true,"url":"https://api.github.com/repos/ArduPilot/ardupilot/commits/c4aa55a6d92b2f96314693920adb6cd6164286bc"},{"sha":"7f29903287555946b96d613aa15dafa113e8e745","author":{"email":"f92d001239d67d58ac1d75c5ef3e0a48eba1f658@yahoo.com","name":"skyscraper"},"message":"ArduPlane: Fix up after refactoring RC_Channel class\n\nFurther to refactor of RC_Channel class which included\nadding get_xx set_xx methods, change reads and writes to the public members\nto calls to  get and set functionsss\n\nold public member(int16_t)   get function -> int16_t     set function (int16_t)\n(expression where c is an object of type RC_Channel)\nc.radio_in                     c.get_radio_in()           c.set_radio_in(v)\nc.control_in                   c.get_control_in()         c.set_control_in(v)\nc.servo_out                    c.get_servo_out()          c.set_servo_out(v)\nc.pwm_out                      c.get_pwm_out()            // use existing\nc.radio_out                    c.get_radio_out()          c.set_radio_out(v)\nc.radio_max                    c.get_radio_max()          c.set_radio_max(v)\nc.radio_min                    c.get_radio_min()          c.set_radio_min(v)\nc.radio_trim                   c.get_radio_trim()         c.set_radio_trim(v);\n\nc.min_max_configured() // return true if min and max are configured\n\nBecause data members of RC_Channels are now private and so cannot be written directly\n some overloads are provided in the Plane classes to provide the old functionality\n\nnew overload Plane::stick_mix_channel(RC_Channel *channel)\nwhich forwards to the previously existing\nvoid stick_mix_channel(RC_Channel *channel, int16_t &servo_out);\n\nnew overload Plane::channel_output_mixer(Rc_Channel* , RC_Channel*)const\nwhich forwards to\n(uint8_t mixing_type, int16_t & chan1, int16_t & chan2)const;\n\nRename functions\n\n RC_Channel_aux::set_radio_trim(Aux_servo_function_t function)\n    to RC_Channel_aux::set_trim_to_radio_in_for(Aux_servo_function_t function)\n\n RC_Channel_aux::set_servo_out(Aux_servo_function_t function, int16_t value)\n    to RC_Channel_aux::set_servo_out_for(Aux_servo_function_t function, int16_t value)\n\n Rationale:\n\n        RC_Channel is a complicated class, which combines\n        several functionalities dealing with stick inputs\n        in pwm and logical units, logical and actual actuator\n        outputs, unit conversion etc, etc\n        The intent of this PR is to clarify existing use of\n        the class. At the basic level it should now be possible\n        to grep all places where private variable is set by\n        searching for the set_xx function.\n\n        (The wider purpose is to provide a more generic and\n        logically simpler method of output mixing. This is a small step)","distinct":true,"url":"https://api.github.com/repos/ArduPilot/ardupilot/commits/7f29903287555946b96d613aa15dafa113e8e745"},{"sha":"6f200fa9231f9a90ab3ebbb79382229b2ab80e77","author":{"email":"f92d001239d67d58ac1d75c5ef3e0a48eba1f658@yahoo.com","name":"skyscraper"},"message":"ArduCopter: Fix up after refactoring RC_Channel class\n\nFurther to refactor of RC_Channel class which included\nadding get_xx set_xx methods, change reads and writes to the public members\nto calls to  get and set functionsss\n\nold public member(int16_t)   get function -> int16_t     set function (int16_t)\n(expression where c is an object of type RC_Channel)\nc.radio_in                     c.get_radio_in()           c.set_radio_in(v)\nc.control_in                   c.get_control_in()         c.set_control_in(v)\nc.servo_out                    c.get_servo_out()          c.set_servo_out(v)\nc.pwm_out                      c.get_pwm_out()            // use existing\nc.radio_out                    c.get_radio_out()          c.set_radio_out(v)\nc.radio_max                    c.get_radio_max()          c.set_radio_max(v)\nc.radio_min                    c.get_radio_min()          c.set_radio_min(v)\nc.radio_trim                   c.get_radio_trim()         c.set_radio_trim(v);\n\nc.min_max_configured() // return true if min and max are configured\n\nBecause data members of RC_Channels are now private and so cannot be written directly\n some overloads are provided in the Plane classes to provide the old functionality\n\nnew overload Plane::stick_mix_channel(RC_Channel *channel)\nwhich forwards to the previously existing\nvoid stick_mix_channel(RC_Channel *channel, int16_t &servo_out);\n\nnew overload Plane::channel_output_mixer(Rc_Channel* , RC_Channel*)const\nwhich forwards to\n(uint8_t mixing_type, int16_t & chan1, int16_t & chan2)const;\n\nRename functions\n\n RC_Channel_aux::set_radio_trim(Aux_servo_function_t function)\n    to RC_Channel_aux::set_trim_to_radio_in_for(Aux_servo_function_t function)\n\n RC_Channel_aux::set_servo_out(Aux_servo_function_t function, int16_t value)\n    to RC_Channel_aux::set_servo_out_for(Aux_servo_function_t function, int16_t value)\n\n Rationale:\n\n        RC_Channel is a complicated class, which combines\n        several functionalities dealing with stick inputs\n        in pwm and logical units, logical and actual actuator\n        outputs, unit conversion etc, etc\n        The intent of this PR is to clarify existing use of\n        the class. At the basic level it should now be possible\n        to grep all places where private variable is set by\n        searching for the set_xx function.\n\n        (The wider purpose is to provide a more generic and\n        logically simpler method of output mixing. This is a small step)","distinct":true,"url":"https://api.github.com/repos/ArduPilot/ardupilot/commits/6f200fa9231f9a90ab3ebbb79382229b2ab80e77"},{"sha":"8c9e55edfa73d8f9ca677e53dde87e780fd3617d","author":{"email":"f92d001239d67d58ac1d75c5ef3e0a48eba1f658@yahoo.com","name":"skyscraper"},"message":"APMRover2:  Fix up after refactoring RC_Channel class\n\nFurther to refactor of RC_Channel class which included\nadding get_xx set_xx methods, change reads and writes to the public members\nto calls to  get and set functionsss\n\nold public member(int16_t)   get function -> int16_t     set function (int16_t)\n(expression where c is an object of type RC_Channel)\nc.radio_in                     c.get_radio_in()           c.set_radio_in(v)\nc.control_in                   c.get_control_in()         c.set_control_in(v)\nc.servo_out                    c.get_servo_out()          c.set_servo_out(v)\nc.pwm_out                      c.get_pwm_out()            // use existing\nc.radio_out                    c.get_radio_out()          c.set_radio_out(v)\nc.radio_max                    c.get_radio_max()          c.set_radio_max(v)\nc.radio_min                    c.get_radio_min()          c.set_radio_min(v)\nc.radio_trim                   c.get_radio_trim()         c.set_radio_trim(v);\n\nc.min_max_configured() // return true if min and max are configured\n\nBecause data members of RC_Channels are now private and so cannot be written directly\n some overloads are provided in the Plane classes to provide the old functionality\n\nnew overload Plane::stick_mix_channel(RC_Channel *channel)\nwhich forwards to the previously existing\nvoid stick_mix_channel(RC_Channel *channel, int16_t &servo_out);\n\nnew overload Plane::channel_output_mixer(Rc_Channel* , RC_Channel*)const\nwhich forwards to\n(uint8_t mixing_type, int16_t & chan1, int16_t & chan2)const;\n\nRename functions\n\n RC_Channel_aux::set_radio_trim(Aux_servo_function_t function)\n    to RC_Channel_aux::set_trim_to_radio_in_for(Aux_servo_function_t function)\n\n RC_Channel_aux::set_servo_out(Aux_servo_function_t function, int16_t value)\n    to RC_Channel_aux::set_servo_out_for(Aux_servo_function_t function, int16_t value)\n\n Rationale:\n\n        RC_Channel is a complicated class, which combines\n        several functionalities dealing with stick inputs\n        in pwm and logical units, logical and actual actuator\n        outputs, unit conversion etc, etc\n        The intent of this PR is to clarify existing use of\n        the class. At the basic level it should now be possible\n        to grep all places where private variable is set by\n        searching for the set_xx function.\n\n        (The wider purpose is to provide a more generic and\n        logically simpler method of output mixing. This is a small step)","distinct":true,"url":"https://api.github.com/repos/ArduPilot/ardupilot/commits/8c9e55edfa73d8f9ca677e53dde87e780fd3617d"},{"sha":"662cefd0860eea3990b34cdbdac4da5386850f43","author":{"email":"f92d001239d67d58ac1d75c5ef3e0a48eba1f658@yahoo.com","name":"skyscraper"},"message":"AntennaTracker:  Fix up after refactoring RC_Channel class\n\nFurther to refactor of RC_Channel class which included\nadding get_xx set_xx methods, change reads and writes to the public members\nto calls to  get and set functionsss\n\nold public member(int16_t)   get function -> int16_t     set function (int16_t)\n(expression where c is an object of type RC_Channel)\nc.radio_in                     c.get_radio_in()           c.set_radio_in(v)\nc.control_in                   c.get_control_in()         c.set_control_in(v)\nc.servo_out                    c.get_servo_out()          c.set_servo_out(v)\nc.pwm_out                      c.get_pwm_out()            // use existing\nc.radio_out                    c.get_radio_out()          c.set_radio_out(v)\nc.radio_max                    c.get_radio_max()          c.set_radio_max(v)\nc.radio_min                    c.get_radio_min()          c.set_radio_min(v)\nc.radio_trim                   c.get_radio_trim()         c.set_radio_trim(v);\n\nc.min_max_configured() // return true if min and max are configured\n\nBecause data members of RC_Channels are now private and so cannot be written directly\n some overloads are provided in the Plane classes to provide the old functionality\n\nnew overload Plane::stick_mix_channel(RC_Channel *channel)\nwhich forwards to the previously existing\nvoid stick_mix_channel(RC_Channel *channel, int16_t &servo_out);\n\nnew overload Plane::channel_output_mixer(Rc_Channel* , RC_Channel*)const\nwhich forwards to\n(uint8_t mixing_type, int16_t & chan1, int16_t & chan2)const;\n\nRename functions\n\n RC_Channel_aux::set_radio_trim(Aux_servo_function_t function)\n    to RC_Channel_aux::set_trim_to_radio_in_for(Aux_servo_function_t function)\n\n RC_Channel_aux::set_servo_out(Aux_servo_function_t function, int16_t value)\n    to RC_Channel_aux::set_servo_out_for(Aux_servo_function_t function, int16_t value)\n\n Rationale:\n\n        RC_Channel is a complicated class, which combines\n        several functionalities dealing with stick inputs\n        in pwm and logical units, logical and actual actuator\n        outputs, unit conversion etc, etc\n        The intent of this PR is to clarify existing use of\n        the class. At the basic level it should now be possible\n        to grep all places where private variable is set by\n        searching for the set_xx function.\n\n        (The wider purpose is to provide a more generic and\n        logically simpler method of output mixing. This is a small step)","distinct":true,"url":"https://api.github.com/repos/ArduPilot/ardupilot/commits/662cefd0860eea3990b34cdbdac4da5386850f43"},{"sha":"12cf65baedd23cdaf50d20a72cddf5a2dec811de","author":{"email":"f92d001239d67d58ac1d75c5ef3e0a48eba1f658@yahoo.com","name":"skyscraper"},"message":"AP_Tuning: Fix up after RC_Channels refactor\n\nFurther to refactor of RC_Channel class which included\nadding get_xx set_xx methods, change reads and writes to the public members\nto calls to  get and set functionsss\n\nold public member(int16_t)   get function -> int16_t     set function (int16_t)\n(expression where c is an object of type RC_Channel)\nc.radio_in                     c.get_radio_in()           c.set_radio_in(v)\nc.control_in                   c.get_control_in()         c.set_control_in(v)\nc.servo_out                    c.get_servo_out()          c.set_servo_out(v)\nc.pwm_out                      c.get_pwm_out()            // use existing\nc.radio_out                    c.get_radio_out()          c.set_radio_out(v)\nc.radio_max                    c.get_radio_max()          c.set_radio_max(v)\nc.radio_min                    c.get_radio_min()          c.set_radio_min(v)\nc.radio_trim                   c.get_radio_trim()         c.set_radio_trim(v);\n\nc.min_max_configured() // return true if min and max are configured\n\nBecause data members of RC_Channels are now private and so cannot be written directly\n some overloads are provided in the Plane classes to provide the old functionality\n\nnew overload Plane::stick_mix_channel(RC_Channel *channel)\nwhich forwards to the previously existing\nvoid stick_mix_channel(RC_Channel *channel, int16_t &servo_out);\n\nnew overload Plane::channel_output_mixer(Rc_Channel* , RC_Channel*)const\nwhich forwards to\n(uint8_t mixing_type, int16_t & chan1, int16_t & chan2)const;\n\nRename functions\n\n RC_Channel_aux::set_radio_trim(Aux_servo_function_t function)\n    to RC_Channel_aux::set_trim_to_radio_in_for(Aux_servo_function_t function)\n\n RC_Channel_aux::set_servo_out(Aux_servo_function_t function, int16_t value)\n    to RC_Channel_aux::set_servo_out_for(Aux_servo_function_t function, int16_t value)\n\n Rationale:\n\n        RC_Channel is a complicated class, which combines\n        several functionalities dealing with stick inputs\n        in pwm and logical units, logical and actual actuator\n        outputs, unit conversion etc, etc\n        The intent of this PR is to clarify existing use of\n        the class. At the basic level it should now be possible\n        to grep all places where private variable is set by\n        searching for the set_xx function.\n\n        (The wider purpose is to provide a more generic and\n        logically simpler method of output mixing. This is a small step)","distinct":true,"url":"https://api.github.com/repos/ArduPilot/ardupilot/commits/12cf65baedd23cdaf50d20a72cddf5a2dec811de"},{"sha":"49d3410896a98b196bc83f6a19d66ba3eadca83c","author":{"email":"f92d001239d67d58ac1d75c5ef3e0a48eba1f658@yahoo.com","name":"skyscraper"},"message":"ArduCopter: fixup RC_Channel data member accesses to function calls","distinct":true,"url":"https://api.github.com/repos/ArduPilot/ardupilot/commits/49d3410896a98b196bc83f6a19d66ba3eadca83c"},{"sha":"4980c8bc94d7701b717ce209798a7ef8f74a5b73","author":{"email":"f92d001239d67d58ac1d75c5ef3e0a48eba1f658@yahoo.com","name":"skyscraper"},"message":"ArduCopter: RC_Channel refactor\n\nMore fixing up of RC_Channel change direct access to data members\nto access via member functions.","distinct":true,"url":"https://api.github.com/repos/ArduPilot/ardupilot/commits/4980c8bc94d7701b717ce209798a7ef8f74a5b73"},{"sha":"de5130fa1371b1e57c3718444c4ebe1a4bb6a2aa","author":{"email":"f92d001239d67d58ac1d75c5ef3e0a48eba1f658@yahoo.com","name":"skyscraper"},"message":"AP_Motors: RC_Channel refactor\n\nMore fixing up of RC_Channel change access to\ndata members to functions","distinct":true,"url":"https://api.github.com/repos/ArduPilot/ardupilot/commits/de5130fa1371b1e57c3718444c4ebe1a4bb6a2aa"},{"sha":"c0c8f1a5cced17c1452a70299a4d33b08679bc99","author":{"email":"f92d001239d67d58ac1d75c5ef3e0a48eba1f658@yahoo.com","name":"skyscraper"},"message":"RC_Channel: RC_Channel refactor\n\nFix up RC_Channel examples.\n\nChange direct access to data members\nto access via member functions","distinct":true,"url":"https://api.github.com/repos/ArduPilot/ardupilot/commits/c0c8f1a5cced17c1452a70299a4d33b08679bc99"},{"sha":"e9e2f9020d676093d20f3d0ae91350d5125ad95a","author":{"email":"f92d001239d67d58ac1d75c5ef3e0a48eba1f658@yahoo.com","name":"skyscraper"},"message":"ArduPlane: RC_Channel refactor, reimplement stick_mix_channels\n\nreimplement the new overload of Plane::stick_mix_channel so\nthat it calls the existing overload","distinct":true,"url":"https://api.github.com/repos/ArduPilot/ardupilot/commits/e9e2f9020d676093d20f3d0ae91350d5125ad95a"},{"sha":"4d769497c950c1c12dfa8401fa70dfaebf2f0dc7","author":{"email":"f92d001239d67d58ac1d75c5ef3e0a48eba1f658@yahoo.com","name":"skyscraper"},"message":"ArduPlane: RC_Channel refactor\n\nFix white space after function name","distinct":true,"url":"https://api.github.com/repos/ArduPilot/ardupilot/commits/4d769497c950c1c12dfa8401fa70dfaebf2f0dc7"}]}