{"action":"created","comment":{"url":"https://api.github.com/repos/gparmer/Composite/pulls/comments/74655089","id":74655089,"diff_hunk":"@@ -141,12 +152,16 @@ kern_boot_comp(void)\n \tassert(thd_mem && tcap_mem);\n         if (captbl_activate_boot(ct, BOOT_CAPTBL_SELF_CT)) assert(0);\n         if (sret_activate(ct, BOOT_CAPTBL_SELF_CT, BOOT_CAPTBL_SRET)) assert(0);\n-        if (pgtbl_activate(ct, BOOT_CAPTBL_SELF_CT, BOOT_CAPTBL_SELF_PT, pgtbl, 0)) assert(0);\n \n \thw_asndcap_init();\n \tif (hw_activate(ct, BOOT_CAPTBL_SELF_CT, BOOT_CAPTBL_SELF_INITHW_BASE, hw_bitmap)) assert(0);\n \n-\tprintk(\"\\tCapability table and page-table created.\\n\");\n+\t/*\n+\t * separate pgd for boot component virtual memory\n+\t */\n+\tboot_vm_pgd = (pgtbl_t)mem_boot_alloc(1);\n+\tmemcpy((void *)boot_vm_pgd + KERNEL_PGD_REGION_OFFSET,  (void *)(&boot_comp_pgd) + KERNEL_PGD_REGION_OFFSET, KERNEL_PGD_REGION_SIZE); \n+\tif (pgtbl_activate(ct, BOOT_CAPTBL_SELF_CT, BOOT_CAPTBL_SELF_PT, (pgtbl_t)chal_va2pa(boot_vm_pgd), 0)) assert(0);","path":"src/platform/i386/boot_comp.c","position":81,"original_position":81,"commit_id":"033a2cdf04d2fc4fcba4fd70beb68848658ec4c8","original_commit_id":"033a2cdf04d2fc4fcba4fd70beb68848658ec4c8","user":{"login":"ryuxin","id":6014153,"avatar_url":"https://avatars.githubusercontent.com/u/6014153?v=3","gravatar_id":"","url":"https://api.github.com/users/ryuxin","html_url":"https://github.com/ryuxin","followers_url":"https://api.github.com/users/ryuxin/followers","following_url":"https://api.github.com/users/ryuxin/following{/other_user}","gists_url":"https://api.github.com/users/ryuxin/gists{/gist_id}","starred_url":"https://api.github.com/users/ryuxin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryuxin/subscriptions","organizations_url":"https://api.github.com/users/ryuxin/orgs","repos_url":"https://api.github.com/users/ryuxin/repos","events_url":"https://api.github.com/users/ryuxin/events{/privacy}","received_events_url":"https://api.github.com/users/ryuxin/received_events","type":"User","site_admin":false},"body":"Yes, I think so. Each time we create a new page table at the boot time, we need those operations","created_at":"2016-08-12T20:25:15Z","updated_at":"2016-08-12T20:25:15Z","html_url":"https://github.com/gparmer/Composite/pull/191#discussion_r74655089","pull_request_url":"https://api.github.com/repos/gparmer/Composite/pulls/191","_links":{"self":{"href":"https://api.github.com/repos/gparmer/Composite/pulls/comments/74655089"},"html":{"href":"https://github.com/gparmer/Composite/pull/191#discussion_r74655089"},"pull_request":{"href":"https://api.github.com/repos/gparmer/Composite/pulls/191"}}},"pull_request":{"url":"https://api.github.com/repos/gparmer/Composite/pulls/191","id":80986717,"html_url":"https://github.com/gparmer/Composite/pull/191","diff_url":"https://github.com/gparmer/Composite/pull/191.diff","patch_url":"https://github.com/gparmer/Composite/pull/191.patch","issue_url":"https://api.github.com/repos/gparmer/Composite/issues/191","number":191,"state":"open","locked":false,"title":"Adds vkernel feature, fix for copying Kernel PTEs to booter's pgtbl, other minor cleanups","user":{"login":"phanikishoreg","id":13894584,"avatar_url":"https://avatars.githubusercontent.com/u/13894584?v=3","gravatar_id":"","url":"https://api.github.com/users/phanikishoreg","html_url":"https://github.com/phanikishoreg","followers_url":"https://api.github.com/users/phanikishoreg/followers","following_url":"https://api.github.com/users/phanikishoreg/following{/other_user}","gists_url":"https://api.github.com/users/phanikishoreg/gists{/gist_id}","starred_url":"https://api.github.com/users/phanikishoreg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phanikishoreg/subscriptions","organizations_url":"https://api.github.com/users/phanikishoreg/orgs","repos_url":"https://api.github.com/users/phanikishoreg/repos","events_url":"https://api.github.com/users/phanikishoreg/events{/privacy}","received_events_url":"https://api.github.com/users/phanikishoreg/received_events","type":"User","site_admin":false},"body":"### Summary of this PR\r\n\r\nMajor feature added is vkernel, which boots up multiple VMs (components) and runs micro_booter (unit & ubench tests) in each of the components. vkernel component schedules VMs in a simple round-robin way. Added API to allocate untyped memory to each VM starting from the end of the untyped_frontier for isolated chunck of memory for each VM. \r\nFixed a bug that doesn't copy kernel PTEs into the booter component's pgtbl. \r\n\r\nTodo in vkernel: (Which I'll add iteratively, along with if any review comments in this pull-request)\r\n1. Shared-memory feature\r\n2. cross-vm communication channels\r\n3. asnd/rcv capabilities between vkernel<->vms for tcaps delegation.\r\n\r\n### Code Quality\r\n\r\nAs part of this pull request, I've considered the following:\r\n\r\nStyle:\r\n\r\n- [x] Comments adhere to the Style Guide (SG)\r\n- [x] Spacing adhere's to the SG \r\n- [x] Naming adhere's to the SG\r\n- [x] All other aspects of the SG are adhered to, or exceptions are justified in this pull request\r\n\r\nCode Craftsmanship:\r\n\r\n- [x] I've made an attempt to remove all redundant code\r\n- [x] I've considered ways in which my changes might impact existing code, and cleaned it up\r\n- [x] I've formatted the code in an effort to make it easier to read (proper error handling, function use, etc...)\r\n- [x] I've commented appropriately where code is tricky\r\n- [x] I agree that there is no \"throw-away\" code, and that code in this PR is of high quality: *any such hackish code is well commented with `TODO`/`FIXME`s*\r\n","created_at":"2016-08-11T16:17:31Z","updated_at":"2016-08-12T20:25:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6fd6424ba602d116f17902e0033b69bd72d0b850","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/gparmer/Composite/pulls/191/commits","review_comments_url":"https://api.github.com/repos/gparmer/Composite/pulls/191/comments","review_comment_url":"https://api.github.com/repos/gparmer/Composite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gparmer/Composite/issues/191/comments","statuses_url":"https://api.github.com/repos/gparmer/Composite/statuses/033a2cdf04d2fc4fcba4fd70beb68848658ec4c8","head":{"label":"phanikishoreg:ppos","ref":"ppos","sha":"033a2cdf04d2fc4fcba4fd70beb68848658ec4c8","user":{"login":"phanikishoreg","id":13894584,"avatar_url":"https://avatars.githubusercontent.com/u/13894584?v=3","gravatar_id":"","url":"https://api.github.com/users/phanikishoreg","html_url":"https://github.com/phanikishoreg","followers_url":"https://api.github.com/users/phanikishoreg/followers","following_url":"https://api.github.com/users/phanikishoreg/following{/other_user}","gists_url":"https://api.github.com/users/phanikishoreg/gists{/gist_id}","starred_url":"https://api.github.com/users/phanikishoreg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phanikishoreg/subscriptions","organizations_url":"https://api.github.com/users/phanikishoreg/orgs","repos_url":"https://api.github.com/users/phanikishoreg/repos","events_url":"https://api.github.com/users/phanikishoreg/events{/privacy}","received_events_url":"https://api.github.com/users/phanikishoreg/received_events","type":"User","site_admin":false},"repo":{"id":45254686,"name":"Composite","full_name":"phanikishoreg/Composite","owner":{"login":"phanikishoreg","id":13894584,"avatar_url":"https://avatars.githubusercontent.com/u/13894584?v=3","gravatar_id":"","url":"https://api.github.com/users/phanikishoreg","html_url":"https://github.com/phanikishoreg","followers_url":"https://api.github.com/users/phanikishoreg/followers","following_url":"https://api.github.com/users/phanikishoreg/following{/other_user}","gists_url":"https://api.github.com/users/phanikishoreg/gists{/gist_id}","starred_url":"https://api.github.com/users/phanikishoreg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phanikishoreg/subscriptions","organizations_url":"https://api.github.com/users/phanikishoreg/orgs","repos_url":"https://api.github.com/users/phanikishoreg/repos","events_url":"https://api.github.com/users/phanikishoreg/events{/privacy}","received_events_url":"https://api.github.com/users/phanikishoreg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/phanikishoreg/Composite","description":"A component-based OS","fork":true,"url":"https://api.github.com/repos/phanikishoreg/Composite","forks_url":"https://api.github.com/repos/phanikishoreg/Composite/forks","keys_url":"https://api.github.com/repos/phanikishoreg/Composite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phanikishoreg/Composite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phanikishoreg/Composite/teams","hooks_url":"https://api.github.com/repos/phanikishoreg/Composite/hooks","issue_events_url":"https://api.github.com/repos/phanikishoreg/Composite/issues/events{/number}","events_url":"https://api.github.com/repos/phanikishoreg/Composite/events","assignees_url":"https://api.github.com/repos/phanikishoreg/Composite/assignees{/user}","branches_url":"https://api.github.com/repos/phanikishoreg/Composite/branches{/branch}","tags_url":"https://api.github.com/repos/phanikishoreg/Composite/tags","blobs_url":"https://api.github.com/repos/phanikishoreg/Composite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phanikishoreg/Composite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phanikishoreg/Composite/git/refs{/sha}","trees_url":"https://api.github.com/repos/phanikishoreg/Composite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phanikishoreg/Composite/statuses/{sha}","languages_url":"https://api.github.com/repos/phanikishoreg/Composite/languages","stargazers_url":"https://api.github.com/repos/phanikishoreg/Composite/stargazers","contributors_url":"https://api.github.com/repos/phanikishoreg/Composite/contributors","subscribers_url":"https://api.github.com/repos/phanikishoreg/Composite/subscribers","subscription_url":"https://api.github.com/repos/phanikishoreg/Composite/subscription","commits_url":"https://api.github.com/repos/phanikishoreg/Composite/commits{/sha}","git_commits_url":"https://api.github.com/repos/phanikishoreg/Composite/git/commits{/sha}","comments_url":"https://api.github.com/repos/phanikishoreg/Composite/comments{/number}","issue_comment_url":"https://api.github.com/repos/phanikishoreg/Composite/issues/comments{/number}","contents_url":"https://api.github.com/repos/phanikishoreg/Composite/contents/{+path}","compare_url":"https://api.github.com/repos/phanikishoreg/Composite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phanikishoreg/Composite/merges","archive_url":"https://api.github.com/repos/phanikishoreg/Composite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phanikishoreg/Composite/downloads","issues_url":"https://api.github.com/repos/phanikishoreg/Composite/issues{/number}","pulls_url":"https://api.github.com/repos/phanikishoreg/Composite/pulls{/number}","milestones_url":"https://api.github.com/repos/phanikishoreg/Composite/milestones{/number}","notifications_url":"https://api.github.com/repos/phanikishoreg/Composite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phanikishoreg/Composite/labels{/name}","releases_url":"https://api.github.com/repos/phanikishoreg/Composite/releases{/id}","deployments_url":"https://api.github.com/repos/phanikishoreg/Composite/deployments","created_at":"2015-10-30T14:08:49Z","updated_at":"2016-01-17T00:19:00Z","pushed_at":"2016-08-11T15:59:53Z","git_url":"git://github.com/phanikishoreg/Composite.git","ssh_url":"git@github.com:phanikishoreg/Composite.git","clone_url":"https://github.com/phanikishoreg/Composite.git","svn_url":"https://github.com/phanikishoreg/Composite","homepage":"composite.seas.gwu.edu","size":17491,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"ppos"}},"base":{"label":"gparmer:ppos","ref":"ppos","sha":"0a91250c946ef97181dfca5086c116964d1b40f0","user":{"login":"gparmer","id":454733,"avatar_url":"https://avatars.githubusercontent.com/u/454733?v=3","gravatar_id":"","url":"https://api.github.com/users/gparmer","html_url":"https://github.com/gparmer","followers_url":"https://api.github.com/users/gparmer/followers","following_url":"https://api.github.com/users/gparmer/following{/other_user}","gists_url":"https://api.github.com/users/gparmer/gists{/gist_id}","starred_url":"https://api.github.com/users/gparmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gparmer/subscriptions","organizations_url":"https://api.github.com/users/gparmer/orgs","repos_url":"https://api.github.com/users/gparmer/repos","events_url":"https://api.github.com/users/gparmer/events{/privacy}","received_events_url":"https://api.github.com/users/gparmer/received_events","type":"User","site_admin":false},"repo":{"id":3140667,"name":"Composite","full_name":"gparmer/Composite","owner":{"login":"gparmer","id":454733,"avatar_url":"https://avatars.githubusercontent.com/u/454733?v=3","gravatar_id":"","url":"https://api.github.com/users/gparmer","html_url":"https://github.com/gparmer","followers_url":"https://api.github.com/users/gparmer/followers","following_url":"https://api.github.com/users/gparmer/following{/other_user}","gists_url":"https://api.github.com/users/gparmer/gists{/gist_id}","starred_url":"https://api.github.com/users/gparmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gparmer/subscriptions","organizations_url":"https://api.github.com/users/gparmer/orgs","repos_url":"https://api.github.com/users/gparmer/repos","events_url":"https://api.github.com/users/gparmer/events{/privacy}","received_events_url":"https://api.github.com/users/gparmer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gparmer/Composite","description":"A component-based OS","fork":false,"url":"https://api.github.com/repos/gparmer/Composite","forks_url":"https://api.github.com/repos/gparmer/Composite/forks","keys_url":"https://api.github.com/repos/gparmer/Composite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gparmer/Composite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gparmer/Composite/teams","hooks_url":"https://api.github.com/repos/gparmer/Composite/hooks","issue_events_url":"https://api.github.com/repos/gparmer/Composite/issues/events{/number}","events_url":"https://api.github.com/repos/gparmer/Composite/events","assignees_url":"https://api.github.com/repos/gparmer/Composite/assignees{/user}","branches_url":"https://api.github.com/repos/gparmer/Composite/branches{/branch}","tags_url":"https://api.github.com/repos/gparmer/Composite/tags","blobs_url":"https://api.github.com/repos/gparmer/Composite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gparmer/Composite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gparmer/Composite/git/refs{/sha}","trees_url":"https://api.github.com/repos/gparmer/Composite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gparmer/Composite/statuses/{sha}","languages_url":"https://api.github.com/repos/gparmer/Composite/languages","stargazers_url":"https://api.github.com/repos/gparmer/Composite/stargazers","contributors_url":"https://api.github.com/repos/gparmer/Composite/contributors","subscribers_url":"https://api.github.com/repos/gparmer/Composite/subscribers","subscription_url":"https://api.github.com/repos/gparmer/Composite/subscription","commits_url":"https://api.github.com/repos/gparmer/Composite/commits{/sha}","git_commits_url":"https://api.github.com/repos/gparmer/Composite/git/commits{/sha}","comments_url":"https://api.github.com/repos/gparmer/Composite/comments{/number}","issue_comment_url":"https://api.github.com/repos/gparmer/Composite/issues/comments{/number}","contents_url":"https://api.github.com/repos/gparmer/Composite/contents/{+path}","compare_url":"https://api.github.com/repos/gparmer/Composite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gparmer/Composite/merges","archive_url":"https://api.github.com/repos/gparmer/Composite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gparmer/Composite/downloads","issues_url":"https://api.github.com/repos/gparmer/Composite/issues{/number}","pulls_url":"https://api.github.com/repos/gparmer/Composite/pulls{/number}","milestones_url":"https://api.github.com/repos/gparmer/Composite/milestones{/number}","notifications_url":"https://api.github.com/repos/gparmer/Composite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gparmer/Composite/labels{/name}","releases_url":"https://api.github.com/repos/gparmer/Composite/releases{/id}","deployments_url":"https://api.github.com/repos/gparmer/Composite/deployments","created_at":"2012-01-09T22:20:27Z","updated_at":"2016-06-09T14:43:56Z","pushed_at":"2016-08-11T16:17:31Z","git_url":"git://github.com/gparmer/Composite.git","ssh_url":"git@github.com:gparmer/Composite.git","clone_url":"https://github.com/gparmer/Composite.git","svn_url":"https://github.com/gparmer/Composite","homepage":"composite.seas.gwu.edu","size":19414,"stargazers_count":43,"watchers_count":43,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":48,"forks":26,"open_issues":48,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gparmer/Composite/pulls/191"},"html":{"href":"https://github.com/gparmer/Composite/pull/191"},"issue":{"href":"https://api.github.com/repos/gparmer/Composite/issues/191"},"comments":{"href":"https://api.github.com/repos/gparmer/Composite/issues/191/comments"},"review_comments":{"href":"https://api.github.com/repos/gparmer/Composite/pulls/191/comments"},"review_comment":{"href":"https://api.github.com/repos/gparmer/Composite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gparmer/Composite/pulls/191/commits"},"statuses":{"href":"https://api.github.com/repos/gparmer/Composite/statuses/033a2cdf04d2fc4fcba4fd70beb68848658ec4c8"}}}}
{"actor":{"display_login":"ryuxin"}}