{"action":"created","issue":{"url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/117","repository_url":"https://api.github.com/repos/Caltech-IPAC/firefly","labels_url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/117/labels{/name}","comments_url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/117/comments","events_url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/117/events","html_url":"https://github.com/Caltech-IPAC/firefly/pull/117","id":165458058,"number":117,"title":"DM-6516-footprint footprint tool implementation. Integrating with the  implementation of marker tool. Both are made in consistent style.","user":{"login":"cwang2016","id":17187356,"avatar_url":"https://avatars.githubusercontent.com/u/17187356?v=3","gravatar_id":"","url":"https://api.github.com/users/cwang2016","html_url":"https://github.com/cwang2016","followers_url":"https://api.github.com/users/cwang2016/followers","following_url":"https://api.github.com/users/cwang2016/following{/other_user}","gists_url":"https://api.github.com/users/cwang2016/gists{/gist_id}","starred_url":"https://api.github.com/users/cwang2016/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwang2016/subscriptions","organizations_url":"https://api.github.com/users/cwang2016/orgs","repos_url":"https://api.github.com/users/cwang2016/repos","events_url":"https://api.github.com/users/cwang2016/events{/privacy}","received_events_url":"https://api.github.com/users/cwang2016/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-07-14T01:40:14Z","updated_at":"2016-07-18T19:44:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/117","html_url":"https://github.com/Caltech-IPAC/firefly/pull/117","diff_url":"https://github.com/Caltech-IPAC/firefly/pull/117.diff","patch_url":"https://github.com/Caltech-IPAC/firefly/pull/117.patch"},"body":"Implementation: (both footprint tool and marker tool are made in consistent style)   \r\n- footprint description file - in DS9 region format, footprint description is located at the server side.\r\n-  update the service to load the footprint description from the server. \r\n-  create footprint factory to produce regions and drawing objects based on footprint description. \r\n-  create  drawing layer for footprint.\r\n-  create functions to handle the operation on footprint (or marker) on the drawing layer - rotate, resize, or relocate or translation.\r\n-  handle the cases that the footprint coverage is bigger than the image size or the footprint's position is out of image covered area.          \r\n- UI components for drawing layer panel\r\n\r\nNotes for operation: \r\nRotate handle, resize handle and outline box are provided for the user to rotate, resize and relocate the footprint or marker on the U if any of the operations is applied.\r\n- Outline box is initially an upright rectangle which\r\n    a) encloses all footprint regions or\r\n    b) is around the center of the footprint (marked by a cross symbol on the UI) or the marker if a) is not visible or \r\n    c) is around the plot center if none of a) and  b) is visible.  \r\n    The outline box becomes slanted as the footprint is rotated. \r\n- Resize handles appear at the corners of the outline box. (marker is resizable and footprint is not resizable).\r\n- Rotate handle appears only at one side of the outline box, starting from the right, the top, the left, or the bottom side  according to its visibility on the plot.\r\n  \r\nTesting example,\r\n   1. get image from image search panel (Images), target: m51, select WISE and click search button\r\n   2. click icon for \"overlay marker and instrument footprints\"\r\n      and select \"add marker\" or any item for adding footprint from the dropdown list\r\n      => a marker or the footprint will appear in the middle of the plot\r\n   3. click the mouse at the place where you want to locate the footprint           \r\n\r\n   When the mouse hovers over the footprint, the cursor will change to be 'pointer'.\r\n   Once 'pointer' is clicked down, an outline box with either resize or rotate handle will appear for 3 seconds after the mouse is up.\r\n  \r\n   4. Click the resize handle and drag to resize the marker,  or \r\n       click the rotate handle and drag to rotate the footprint or\r\n       click on the pointer and drag to move the marker or footprint. \r\n\r\n   If the outline box is moved out of the plot area  while operating the footprint or marker, the outline box of other kind will continue to appear. \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/comments/233436770","html_url":"https://github.com/Caltech-IPAC/firefly/pull/117#issuecomment-233436770","issue_url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/117","id":233436770,"user":{"login":"ejoliet","id":770124,"avatar_url":"https://avatars.githubusercontent.com/u/770124?v=3","gravatar_id":"","url":"https://api.github.com/users/ejoliet","html_url":"https://github.com/ejoliet","followers_url":"https://api.github.com/users/ejoliet/followers","following_url":"https://api.github.com/users/ejoliet/following{/other_user}","gists_url":"https://api.github.com/users/ejoliet/gists{/gist_id}","starred_url":"https://api.github.com/users/ejoliet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejoliet/subscriptions","organizations_url":"https://api.github.com/users/ejoliet/orgs","repos_url":"https://api.github.com/users/ejoliet/repos","events_url":"https://api.github.com/users/ejoliet/events{/privacy}","received_events_url":"https://api.github.com/users/ejoliet/received_events","type":"User","site_admin":false},"created_at":"2016-07-18T19:44:48Z","updated_at":"2016-07-18T19:44:48Z","body":"You are right. And i would add that i am also concerned that we are changing the server too. Java classes are changing in dev but we are not testing for IFE app as well in those cases.\n\n--\nEmmanuel Joliet\nNASA/IPAC  Infrared Science Archive\nMS 100-22, Caltech, Pasadena, CA 91125\nOffice: 170\nEmail:  ejoliet@ipac.caltech.edu\nPhone:  (626) 395-1489\n\n> On Jul 18, 2016, at 12:12, Trey Roby <notifications@github.com> wrote:\n> \n> The code looks good. However, it is so much it is hard to evaluate. This is a problem with code reviews.\n> \n> I have notice in the last couple of months. In May I, @loitly, @tgoldina and @ejoliet all had really big commits. How do we look at large commits? I think we should bring it up for ideas in our Wednesday meeting.\n> \n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub, or mute the thread.\n> \n"}}
{"actor":{"display_login":"ejoliet"}}