{"action":"created","issue":{"url":"https://api.github.com/repos/beowulfe/HAP-Java/issues/17","repository_url":"https://api.github.com/repos/beowulfe/HAP-Java","labels_url":"https://api.github.com/repos/beowulfe/HAP-Java/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/beowulfe/HAP-Java/issues/17/comments","events_url":"https://api.github.com/repos/beowulfe/HAP-Java/issues/17/events","html_url":"https://github.com/beowulfe/HAP-Java/pull/17","id":168930802,"number":17,"title":"We can now specify service name","user":{"login":"gdombiak","id":1791267,"avatar_url":"https://avatars.githubusercontent.com/u/1791267?v=3","gravatar_id":"","url":"https://api.github.com/users/gdombiak","html_url":"https://github.com/gdombiak","followers_url":"https://api.github.com/users/gdombiak/followers","following_url":"https://api.github.com/users/gdombiak/following{/other_user}","gists_url":"https://api.github.com/users/gdombiak/gists{/gist_id}","starred_url":"https://api.github.com/users/gdombiak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdombiak/subscriptions","organizations_url":"https://api.github.com/users/gdombiak/orgs","repos_url":"https://api.github.com/users/gdombiak/repos","events_url":"https://api.github.com/users/gdombiak/events{/privacy}","received_events_url":"https://api.github.com/users/gdombiak/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-08-02T16:32:53Z","updated_at":"2016-08-19T03:04:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/beowulfe/HAP-Java/pulls/17","html_url":"https://github.com/beowulfe/HAP-Java/pull/17","diff_url":"https://github.com/beowulfe/HAP-Java/pull/17.diff","patch_url":"https://github.com/beowulfe/HAP-Java/pull/17.patch"},"body":"Andy,\r\n\r\nHere are 2 small improvements:\r\n1. It is now possible to specify service name. Still defaults to accessory label\r\n2. Log IOExceptions using DEBUG level. Before it was only one type of timeout.\r\n\r\nI have an accessory that  offers 2 services and both services were appearing with the same name (the name of the accessory). I added a new constructor to ServicesImpl so that we can pass a serviceName. Old constructor is still around and defaults to accessory label. \r\nFine-prints: 1) Had to remove the deprecated constructor in AbstractServiceImpl. I think you were ok with this. 2) Changed constructor of Name to accept a String instead of a HomekitAccessory.\r\n\r\nNoticed a few more \"noisy\" entries in the log around IOExceptions so went ahead and change code to log with DEBUG all IOExceptions instead of just \"Connection timed out\".\r\n\r\nLet me know if you are ok with these changes.\r\nThanks,\r\nGaston"},"comment":{"url":"https://api.github.com/repos/beowulfe/HAP-Java/issues/comments/240916023","html_url":"https://github.com/beowulfe/HAP-Java/pull/17#issuecomment-240916023","issue_url":"https://api.github.com/repos/beowulfe/HAP-Java/issues/17","id":240916023,"user":{"login":"beowulfe","id":78016,"avatar_url":"https://avatars.githubusercontent.com/u/78016?v=3","gravatar_id":"","url":"https://api.github.com/users/beowulfe","html_url":"https://github.com/beowulfe","followers_url":"https://api.github.com/users/beowulfe/followers","following_url":"https://api.github.com/users/beowulfe/following{/other_user}","gists_url":"https://api.github.com/users/beowulfe/gists{/gist_id}","starred_url":"https://api.github.com/users/beowulfe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beowulfe/subscriptions","organizations_url":"https://api.github.com/users/beowulfe/orgs","repos_url":"https://api.github.com/users/beowulfe/repos","events_url":"https://api.github.com/users/beowulfe/events{/privacy}","received_events_url":"https://api.github.com/users/beowulfe/received_events","type":"User","site_admin":false},"created_at":"2016-08-19T03:04:28Z","updated_at":"2016-08-19T03:04:28Z","body":"Thanks for another great contribution!"}}
{"actor":{"display_login":"beowulfe"}}