{"action":"created","comment":{"url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/comments/77493657","id":77493657,"diff_hunk":"@@ -105,16 +110,21 @@\n     /**\n      * Reach {@link ModAchievements#ACHIEVEMENT_SIZE_SETTLEMENT} citizens.\n      */\n-    public static final Achievement achievementSizeSettlement = new MineColoniesAchievement(\"size.pioneer\", \"size.settlement\", 2, -2, Items.iron_ingot, null).registerStat();\n+    public static final Achievement achievementSizeSettlement = new MineColoniesAchievement(\"size.pioneer\", \"size.settlement\", 2, -2, ModItems.itemProxySizeSettlement, null).registerStat();\n     /**\n      * Reach {@link ModAchievements#ACHIEVEMENT_SIZE_TOWN} citizens.\n      */\n-    public static final Achievement achievementSizeTown       = new MineColoniesAchievement(\"size.town\", \"size.town\", 4, -2, Items.gold_ingot, achievementSizeSettlement)\n+    public static final Achievement achievementSizeTown       = new MineColoniesAchievement(\"size.town\", \"size.town\", 4, -2, ModItems.itemProxySizeTown, achievementSizeSettlement)\n             .registerStat();\n     /**\n      * Reach {@link ModAchievements#ACHIEVEMENT_SIZE_CITY} citizens.\n      */\n-    public static final Achievement achievementSizeCity       = new MineColoniesAchievement(\"size.city\", \"size.city\", 6, -2, Items.diamond, achievementSizeTown).registerStat();\n+    public static final Achievement achievementSizeCity       = new MineColoniesAchievement(\"size.city\", \"size.city\", 6, -2, ModItems.itemProxySizeCity, achievementSizeTown).registerStat();","path":"src/main/java/com/minecolonies/achievements/ModAchievements.java","position":53,"original_position":53,"commit_id":"7997d498e665152c56cef495b1d4c47e7e3c2d6c","original_commit_id":"7997d498e665152c56cef495b1d4c47e7e3c2d6c","user":{"login":"MinecoloniesSonar","id":19393044,"avatar_url":"https://avatars.githubusercontent.com/u/19393044?v=3","gravatar_id":"","url":"https://api.github.com/users/MinecoloniesSonar","html_url":"https://github.com/MinecoloniesSonar","followers_url":"https://api.github.com/users/MinecoloniesSonar/followers","following_url":"https://api.github.com/users/MinecoloniesSonar/following{/other_user}","gists_url":"https://api.github.com/users/MinecoloniesSonar/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecoloniesSonar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecoloniesSonar/subscriptions","organizations_url":"https://api.github.com/users/MinecoloniesSonar/orgs","repos_url":"https://api.github.com/users/MinecoloniesSonar/repos","events_url":"https://api.github.com/users/MinecoloniesSonar/events{/privacy}","received_events_url":"https://api.github.com/users/MinecoloniesSonar/received_events","type":"User","site_admin":false},"body":"![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) Split this 189 characters long line (which is greater than 180 authorized). [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://home.kk-sc.de:9000/coding_rules#rule_key=squid%3AS00103)\n","created_at":"2016-09-05T09:27:23Z","updated_at":"2016-09-05T09:27:23Z","html_url":"https://github.com/Minecolonies/minecolonies/pull/82#discussion_r77493657","pull_request_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/82","_links":{"self":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/comments/77493657"},"html":{"href":"https://github.com/Minecolonies/minecolonies/pull/82#discussion_r77493657"},"pull_request":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/82"}}},"pull_request":{"url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/82","id":83646351,"html_url":"https://github.com/Minecolonies/minecolonies/pull/82","diff_url":"https://github.com/Minecolonies/minecolonies/pull/82.diff","patch_url":"https://github.com/Minecolonies/minecolonies/pull/82.patch","issue_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/82","number":82,"state":"open","locked":false,"title":"HOTFIXED","user":{"login":"Isfirs","id":2435878,"avatar_url":"https://avatars.githubusercontent.com/u/2435878?v=3","gravatar_id":"","url":"https://api.github.com/users/Isfirs","html_url":"https://github.com/Isfirs","followers_url":"https://api.github.com/users/Isfirs/followers","following_url":"https://api.github.com/users/Isfirs/following{/other_user}","gists_url":"https://api.github.com/users/Isfirs/gists{/gist_id}","starred_url":"https://api.github.com/users/Isfirs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Isfirs/subscriptions","organizations_url":"https://api.github.com/users/Isfirs/orgs","repos_url":"https://api.github.com/users/Isfirs/repos","events_url":"https://api.github.com/users/Isfirs/events{/privacy}","received_events_url":"https://api.github.com/users/Isfirs/received_events","type":"User","site_admin":false},"body":"Fixes #79  .\r\n\r\n# Changes proposed in this pull request:\r\n- Added the behavior of MineColonies related achievements\r\n- Achievements now fire to the colony and sync with players with at least `Permissions.Rank.OFFICER`\r\n- Fixes server crash of @Kostronor lambda expression\r\n\r\nReview please @Minecolonies/maintainers\r\n\r\nPlease test all achievements (creative playthrough will do it, maybe with multiple players)","created_at":"2016-09-01T14:45:51Z","updated_at":"2016-09-05T09:27:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bff355c7e55d16f9dc27f27fa5c627cfa950bce4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/82/commits","review_comments_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/82/comments","review_comment_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/82/comments","statuses_url":"https://api.github.com/repos/Minecolonies/minecolonies/statuses/7997d498e665152c56cef495b1d4c47e7e3c2d6c","head":{"label":"Minecolonies:hotfix/#79-size-achievements-crash","ref":"hotfix/#79-size-achievements-crash","sha":"7997d498e665152c56cef495b1d4c47e7e3c2d6c","user":{"login":"Minecolonies","id":5167336,"avatar_url":"https://avatars.githubusercontent.com/u/5167336?v=3","gravatar_id":"","url":"https://api.github.com/users/Minecolonies","html_url":"https://github.com/Minecolonies","followers_url":"https://api.github.com/users/Minecolonies/followers","following_url":"https://api.github.com/users/Minecolonies/following{/other_user}","gists_url":"https://api.github.com/users/Minecolonies/gists{/gist_id}","starred_url":"https://api.github.com/users/Minecolonies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Minecolonies/subscriptions","organizations_url":"https://api.github.com/users/Minecolonies/orgs","repos_url":"https://api.github.com/users/Minecolonies/repos","events_url":"https://api.github.com/users/Minecolonies/events{/privacy}","received_events_url":"https://api.github.com/users/Minecolonies/received_events","type":"Organization","site_admin":false},"repo":{"id":65616760,"name":"minecolonies","full_name":"Minecolonies/minecolonies","owner":{"login":"Minecolonies","id":5167336,"avatar_url":"https://avatars.githubusercontent.com/u/5167336?v=3","gravatar_id":"","url":"https://api.github.com/users/Minecolonies","html_url":"https://github.com/Minecolonies","followers_url":"https://api.github.com/users/Minecolonies/followers","following_url":"https://api.github.com/users/Minecolonies/following{/other_user}","gists_url":"https://api.github.com/users/Minecolonies/gists{/gist_id}","starred_url":"https://api.github.com/users/Minecolonies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Minecolonies/subscriptions","organizations_url":"https://api.github.com/users/Minecolonies/orgs","repos_url":"https://api.github.com/users/Minecolonies/repos","events_url":"https://api.github.com/users/Minecolonies/events{/privacy}","received_events_url":"https://api.github.com/users/Minecolonies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Minecolonies/minecolonies","description":"Minecolonies minecraft mod","fork":false,"url":"https://api.github.com/repos/Minecolonies/minecolonies","forks_url":"https://api.github.com/repos/Minecolonies/minecolonies/forks","keys_url":"https://api.github.com/repos/Minecolonies/minecolonies/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Minecolonies/minecolonies/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Minecolonies/minecolonies/teams","hooks_url":"https://api.github.com/repos/Minecolonies/minecolonies/hooks","issue_events_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/events{/number}","events_url":"https://api.github.com/repos/Minecolonies/minecolonies/events","assignees_url":"https://api.github.com/repos/Minecolonies/minecolonies/assignees{/user}","branches_url":"https://api.github.com/repos/Minecolonies/minecolonies/branches{/branch}","tags_url":"https://api.github.com/repos/Minecolonies/minecolonies/tags","blobs_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/refs{/sha}","trees_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Minecolonies/minecolonies/statuses/{sha}","languages_url":"https://api.github.com/repos/Minecolonies/minecolonies/languages","stargazers_url":"https://api.github.com/repos/Minecolonies/minecolonies/stargazers","contributors_url":"https://api.github.com/repos/Minecolonies/minecolonies/contributors","subscribers_url":"https://api.github.com/repos/Minecolonies/minecolonies/subscribers","subscription_url":"https://api.github.com/repos/Minecolonies/minecolonies/subscription","commits_url":"https://api.github.com/repos/Minecolonies/minecolonies/commits{/sha}","git_commits_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/commits{/sha}","comments_url":"https://api.github.com/repos/Minecolonies/minecolonies/comments{/number}","issue_comment_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/comments{/number}","contents_url":"https://api.github.com/repos/Minecolonies/minecolonies/contents/{+path}","compare_url":"https://api.github.com/repos/Minecolonies/minecolonies/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Minecolonies/minecolonies/merges","archive_url":"https://api.github.com/repos/Minecolonies/minecolonies/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Minecolonies/minecolonies/downloads","issues_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues{/number}","pulls_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls{/number}","milestones_url":"https://api.github.com/repos/Minecolonies/minecolonies/milestones{/number}","notifications_url":"https://api.github.com/repos/Minecolonies/minecolonies/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Minecolonies/minecolonies/labels{/name}","releases_url":"https://api.github.com/repos/Minecolonies/minecolonies/releases{/id}","deployments_url":"https://api.github.com/repos/Minecolonies/minecolonies/deployments","created_at":"2016-08-13T12:45:38Z","updated_at":"2016-09-02T09:47:18Z","pushed_at":"2016-09-05T09:20:35Z","git_url":"git://github.com/Minecolonies/minecolonies.git","ssh_url":"git@github.com:Minecolonies/minecolonies.git","clone_url":"https://github.com/Minecolonies/minecolonies.git","svn_url":"https://github.com/Minecolonies/minecolonies","homepage":"http://minecolonies.com/","size":7006,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":39,"forks":4,"open_issues":39,"watchers":4,"default_branch":"develop"}},"base":{"label":"Minecolonies:develop","ref":"develop","sha":"630591ddc6dd01bedfe5fb361147add480411424","user":{"login":"Minecolonies","id":5167336,"avatar_url":"https://avatars.githubusercontent.com/u/5167336?v=3","gravatar_id":"","url":"https://api.github.com/users/Minecolonies","html_url":"https://github.com/Minecolonies","followers_url":"https://api.github.com/users/Minecolonies/followers","following_url":"https://api.github.com/users/Minecolonies/following{/other_user}","gists_url":"https://api.github.com/users/Minecolonies/gists{/gist_id}","starred_url":"https://api.github.com/users/Minecolonies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Minecolonies/subscriptions","organizations_url":"https://api.github.com/users/Minecolonies/orgs","repos_url":"https://api.github.com/users/Minecolonies/repos","events_url":"https://api.github.com/users/Minecolonies/events{/privacy}","received_events_url":"https://api.github.com/users/Minecolonies/received_events","type":"Organization","site_admin":false},"repo":{"id":65616760,"name":"minecolonies","full_name":"Minecolonies/minecolonies","owner":{"login":"Minecolonies","id":5167336,"avatar_url":"https://avatars.githubusercontent.com/u/5167336?v=3","gravatar_id":"","url":"https://api.github.com/users/Minecolonies","html_url":"https://github.com/Minecolonies","followers_url":"https://api.github.com/users/Minecolonies/followers","following_url":"https://api.github.com/users/Minecolonies/following{/other_user}","gists_url":"https://api.github.com/users/Minecolonies/gists{/gist_id}","starred_url":"https://api.github.com/users/Minecolonies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Minecolonies/subscriptions","organizations_url":"https://api.github.com/users/Minecolonies/orgs","repos_url":"https://api.github.com/users/Minecolonies/repos","events_url":"https://api.github.com/users/Minecolonies/events{/privacy}","received_events_url":"https://api.github.com/users/Minecolonies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Minecolonies/minecolonies","description":"Minecolonies minecraft mod","fork":false,"url":"https://api.github.com/repos/Minecolonies/minecolonies","forks_url":"https://api.github.com/repos/Minecolonies/minecolonies/forks","keys_url":"https://api.github.com/repos/Minecolonies/minecolonies/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Minecolonies/minecolonies/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Minecolonies/minecolonies/teams","hooks_url":"https://api.github.com/repos/Minecolonies/minecolonies/hooks","issue_events_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/events{/number}","events_url":"https://api.github.com/repos/Minecolonies/minecolonies/events","assignees_url":"https://api.github.com/repos/Minecolonies/minecolonies/assignees{/user}","branches_url":"https://api.github.com/repos/Minecolonies/minecolonies/branches{/branch}","tags_url":"https://api.github.com/repos/Minecolonies/minecolonies/tags","blobs_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/refs{/sha}","trees_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Minecolonies/minecolonies/statuses/{sha}","languages_url":"https://api.github.com/repos/Minecolonies/minecolonies/languages","stargazers_url":"https://api.github.com/repos/Minecolonies/minecolonies/stargazers","contributors_url":"https://api.github.com/repos/Minecolonies/minecolonies/contributors","subscribers_url":"https://api.github.com/repos/Minecolonies/minecolonies/subscribers","subscription_url":"https://api.github.com/repos/Minecolonies/minecolonies/subscription","commits_url":"https://api.github.com/repos/Minecolonies/minecolonies/commits{/sha}","git_commits_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/commits{/sha}","comments_url":"https://api.github.com/repos/Minecolonies/minecolonies/comments{/number}","issue_comment_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/comments{/number}","contents_url":"https://api.github.com/repos/Minecolonies/minecolonies/contents/{+path}","compare_url":"https://api.github.com/repos/Minecolonies/minecolonies/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Minecolonies/minecolonies/merges","archive_url":"https://api.github.com/repos/Minecolonies/minecolonies/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Minecolonies/minecolonies/downloads","issues_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues{/number}","pulls_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls{/number}","milestones_url":"https://api.github.com/repos/Minecolonies/minecolonies/milestones{/number}","notifications_url":"https://api.github.com/repos/Minecolonies/minecolonies/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Minecolonies/minecolonies/labels{/name}","releases_url":"https://api.github.com/repos/Minecolonies/minecolonies/releases{/id}","deployments_url":"https://api.github.com/repos/Minecolonies/minecolonies/deployments","created_at":"2016-08-13T12:45:38Z","updated_at":"2016-09-02T09:47:18Z","pushed_at":"2016-09-05T09:20:35Z","git_url":"git://github.com/Minecolonies/minecolonies.git","ssh_url":"git@github.com:Minecolonies/minecolonies.git","clone_url":"https://github.com/Minecolonies/minecolonies.git","svn_url":"https://github.com/Minecolonies/minecolonies","homepage":"http://minecolonies.com/","size":7006,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":39,"forks":4,"open_issues":39,"watchers":4,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/82"},"html":{"href":"https://github.com/Minecolonies/minecolonies/pull/82"},"issue":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/issues/82"},"comments":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/statuses/7997d498e665152c56cef495b1d4c47e7e3c2d6c"}}}}
{"actor":{"display_login":"MinecoloniesSonar"}}