{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/coreclr/issues/7244","repository_url":"https://api.github.com/repos/dotnet/coreclr","labels_url":"https://api.github.com/repos/dotnet/coreclr/issues/7244/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/7244/comments","events_url":"https://api.github.com/repos/dotnet/coreclr/issues/7244/events","html_url":"https://github.com/dotnet/coreclr/pull/7244","id":177583400,"number":7244,"title":"Beef up / clean up GenTree struct info dumps.","user":{"login":"pkukol","id":148817,"avatar_url":"https://avatars.githubusercontent.com/u/148817?v=3","gravatar_id":"","url":"https://api.github.com/users/pkukol","html_url":"https://github.com/pkukol","followers_url":"https://api.github.com/users/pkukol/followers","following_url":"https://api.github.com/users/pkukol/following{/other_user}","gists_url":"https://api.github.com/users/pkukol/gists{/gist_id}","starred_url":"https://api.github.com/users/pkukol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkukol/subscriptions","organizations_url":"https://api.github.com/users/pkukol/orgs","repos_url":"https://api.github.com/users/pkukol/repos","events_url":"https://api.github.com/users/pkukol/events{/privacy}","received_events_url":"https://api.github.com/users/pkukol/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/coreclr/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-09-17T15:08:05Z","updated_at":"2016-09-19T17:46:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/7244","html_url":"https://github.com/dotnet/coreclr/pull/7244","diff_url":"https://github.com/dotnet/coreclr/pull/7244.diff","patch_url":"https://github.com/dotnet/coreclr/pull/7244.patch"},"body":"Moves most of the GenTree dump stuff from compiler.cpp into gentree.cpp, dumps a lot more info, fixes a few things; all of this is #if'd out by default.\r\n\r\nY'all PTAL ... @pgavlin @BruceForstall @CarolEidt\r\n/cc @dotnet/jit-contrib "},"comment":{"url":"https://api.github.com/repos/dotnet/coreclr/issues/comments/248066601","html_url":"https://github.com/dotnet/coreclr/pull/7244#issuecomment-248066601","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/7244","id":248066601,"user":{"login":"pkukol","id":148817,"avatar_url":"https://avatars.githubusercontent.com/u/148817?v=3","gravatar_id":"","url":"https://api.github.com/users/pkukol","html_url":"https://github.com/pkukol","followers_url":"https://api.github.com/users/pkukol/followers","following_url":"https://api.github.com/users/pkukol/following{/other_user}","gists_url":"https://api.github.com/users/pkukol/gists{/gist_id}","starred_url":"https://api.github.com/users/pkukol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkukol/subscriptions","organizations_url":"https://api.github.com/users/pkukol/orgs","repos_url":"https://api.github.com/users/pkukol/repos","events_url":"https://api.github.com/users/pkukol/events{/privacy}","received_events_url":"https://api.github.com/users/pkukol/received_events","type":"User","site_admin":false},"created_at":"2016-09-19T17:46:50Z","updated_at":"2016-09-19T17:46:50Z","body":"@mikedn , that little utility is a good starting point - thanks for posting it. Now that I've thought about it a lot more, it may not be a bad idea to try both avenues for a while and see what works best (anything we do will be 100% optional to begin with anyway, I assume). The code I added to gentree.cpp doesn't cost anything in the resulting binary but it does add a lot more text to the source etc which is certainly not completely without cost, so we could move it out into a .hpp file that is only #include'd when the macro is enabled, or alternatively we could stuff it at the end of gentree.h (since the hope is that when people mess with things in there that's the time to update the dumping code and also make sure no bad surprises have been introduced), or we could say that everything to do with GenTree sizes / layout should be in one place where folks won't miss it. Thoughts, please @pgavlin @BruceForstall @CarolEidt ."}}
{"actor":{"display_login":"pkukol"}}