{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/69775843","id":69775843,"diff_hunk":"@@ -128,6 +128,9 @@ def hostname_uniqueness_valid?\n   virtual_column :total_vms_suspended,     :type => :integer\n   virtual_total  :total_subnets,           :cloud_subnets\n \n+  virtual_total  :connection_definitions, :type => :array","path":"app/models/ext_management_system.rb","position":4,"original_position":4,"commit_id":"099f0fb4b3046253a8dc8b806f83d3baf8c0621f","original_commit_id":"099f0fb4b3046253a8dc8b806f83d3baf8c0621f","user":{"login":"imtayadeway","id":1710874,"avatar_url":"https://avatars.githubusercontent.com/u/1710874?v=3","gravatar_id":"","url":"https://api.github.com/users/imtayadeway","html_url":"https://github.com/imtayadeway","followers_url":"https://api.github.com/users/imtayadeway/followers","following_url":"https://api.github.com/users/imtayadeway/following{/other_user}","gists_url":"https://api.github.com/users/imtayadeway/gists{/gist_id}","starred_url":"https://api.github.com/users/imtayadeway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imtayadeway/subscriptions","organizations_url":"https://api.github.com/users/imtayadeway/orgs","repos_url":"https://api.github.com/users/imtayadeway/repos","events_url":"https://api.github.com/users/imtayadeway/events{/privacy}","received_events_url":"https://api.github.com/users/imtayadeway/received_events","type":"User","site_admin":false},"body":"Does this work? Looking at the definition for `virtual_total` it looks like it should take a `name` and a `relation` argument.","created_at":"2016-07-06T17:36:15Z","updated_at":"2016-07-06T17:36:15Z","html_url":"https://github.com/ManageIQ/manageiq/pull/9502#discussion_r69775843","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9502","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/69775843"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/9502#discussion_r69775843"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9502"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9502","id":75614509,"html_url":"https://github.com/ManageIQ/manageiq/pull/9502","diff_url":"https://github.com/ManageIQ/manageiq/pull/9502.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/9502.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/9502","number":9502,"state":"open","locked":false,"title":"Add multiendpoint support to providers API","user":{"login":"yaacov","id":2181522,"avatar_url":"https://avatars.githubusercontent.com/u/2181522?v=3","gravatar_id":"","url":"https://api.github.com/users/yaacov","html_url":"https://github.com/yaacov","followers_url":"https://api.github.com/users/yaacov/followers","following_url":"https://api.github.com/users/yaacov/following{/other_user}","gists_url":"https://api.github.com/users/yaacov/gists{/gist_id}","starred_url":"https://api.github.com/users/yaacov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaacov/subscriptions","organizations_url":"https://api.github.com/users/yaacov/orgs","repos_url":"https://api.github.com/users/yaacov/repos","events_url":"https://api.github.com/users/yaacov/events{/privacy}","received_events_url":"https://api.github.com/users/yaacov/received_events","type":"User","site_admin":false},"body":"**Descriptions**:\r\nAdd the `connection_definitions` field to the API GET method. It returns an array of endpoints and authentications hashes.\r\nAdd the `connection_definitions` settings to the API POST method's create and edit actions.\r\n\r\n**Examples**:\r\nGET `http://localhost:3000/api/providers/139?attributes=connection_definitions` renders:\r\n```\r\n{\r\n  \"href\": \"http://localhost:3000/api/providers/139\",\r\n  \"id\": 139,\r\n  \"name\": \"LABz\",\r\n  \"created_on\": \"2016-07-05T12:43:52.458Z\",\r\n  ...\r\n  \"connection_definitions\": [\r\n    {\r\n      \"endpoint\": {\r\n        \"id\": 334,\r\n        \"role\": \"default\",\r\n        ...\r\n      },\r\n      \"authentication\": {\r\n        \"id\": 235,\r\n        \"name\": \"ManageIQ::Providers::Openshift::ContainerManager LABz\",\r\n        \"authtype\": \"bearer\",\r\n        ...\r\n  ...\r\n```\r\nPOST `http://localhost:3000/api/providers` with the json body:\r\n```\r\n{\r\n    \"name\"                      : \"LAB\",\r\n    \"zone_id\"                   : \"1\",\r\n    \"type\": \"ManageIQ::Providers::Openshift::ContainerManager\",\r\n    \"connection_definitions\" : [\r\n        {\"endpoint\"       : {\"role\"     : \"default\",\r\n                             \"hostname\" : \"example.com\",\r\n                             \"port\"     : \"8443\"},\r\n          \"authentication\" : {\"role\"     : \"bearer\",\r\n                              \"auth_key\" : \"eyJhbGciOi ...\",\r\n                              \"userid\"   : \"_\"}},\r\n         {\"endpoint\"       : {\"role\"     : \"hawkular\",\r\n                              \"hostname\" : \"example.com\",\r\n                              \"port\"     : \"443\"},\r\n           \"authentication\" : {\"role\"     : \"hawkular\",\r\n                               \"auth_key\" : \"eyJhbGciOi ...\",\r\n                               \"userid\"   : \"_\"}}\r\n    ]\r\n}\r\n```\r\nwill crate a new OpenShift provider.\r\n\r\n**Links**:\r\nIssue: https://github.com/ManageIQ/manageiq/issues/9506","created_at":"2016-06-29T09:21:26Z","updated_at":"2016-07-06T17:36:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"12eefb7655b30c8a01ac1c72c64fb881d2484fd4","assignee":{"login":"yaacov","id":2181522,"avatar_url":"https://avatars.githubusercontent.com/u/2181522?v=3","gravatar_id":"","url":"https://api.github.com/users/yaacov","html_url":"https://github.com/yaacov","followers_url":"https://api.github.com/users/yaacov/followers","following_url":"https://api.github.com/users/yaacov/following{/other_user}","gists_url":"https://api.github.com/users/yaacov/gists{/gist_id}","starred_url":"https://api.github.com/users/yaacov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaacov/subscriptions","organizations_url":"https://api.github.com/users/yaacov/orgs","repos_url":"https://api.github.com/users/yaacov/repos","events_url":"https://api.github.com/users/yaacov/events{/privacy}","received_events_url":"https://api.github.com/users/yaacov/received_events","type":"User","site_admin":false},"assignees":[{"login":"yaacov","id":2181522,"avatar_url":"https://avatars.githubusercontent.com/u/2181522?v=3","gravatar_id":"","url":"https://api.github.com/users/yaacov","html_url":"https://github.com/yaacov","followers_url":"https://api.github.com/users/yaacov/followers","following_url":"https://api.github.com/users/yaacov/following{/other_user}","gists_url":"https://api.github.com/users/yaacov/gists{/gist_id}","starred_url":"https://api.github.com/users/yaacov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaacov/subscriptions","organizations_url":"https://api.github.com/users/yaacov/orgs","repos_url":"https://api.github.com/users/yaacov/repos","events_url":"https://api.github.com/users/yaacov/events{/privacy}","received_events_url":"https://api.github.com/users/yaacov/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9502/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9502/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/9502/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/099f0fb4b3046253a8dc8b806f83d3baf8c0621f","head":{"label":"yaacov:add-provider-endpoints-to-api","ref":"add-provider-endpoints-to-api","sha":"099f0fb4b3046253a8dc8b806f83d3baf8c0621f","user":{"login":"yaacov","id":2181522,"avatar_url":"https://avatars.githubusercontent.com/u/2181522?v=3","gravatar_id":"","url":"https://api.github.com/users/yaacov","html_url":"https://github.com/yaacov","followers_url":"https://api.github.com/users/yaacov/followers","following_url":"https://api.github.com/users/yaacov/following{/other_user}","gists_url":"https://api.github.com/users/yaacov/gists{/gist_id}","starred_url":"https://api.github.com/users/yaacov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaacov/subscriptions","organizations_url":"https://api.github.com/users/yaacov/orgs","repos_url":"https://api.github.com/users/yaacov/repos","events_url":"https://api.github.com/users/yaacov/events{/privacy}","received_events_url":"https://api.github.com/users/yaacov/received_events","type":"User","site_admin":false},"repo":{"id":49647502,"name":"manageiq","full_name":"yaacov/manageiq","owner":{"login":"yaacov","id":2181522,"avatar_url":"https://avatars.githubusercontent.com/u/2181522?v=3","gravatar_id":"","url":"https://api.github.com/users/yaacov","html_url":"https://github.com/yaacov","followers_url":"https://api.github.com/users/yaacov/followers","following_url":"https://api.github.com/users/yaacov/following{/other_user}","gists_url":"https://api.github.com/users/yaacov/gists{/gist_id}","starred_url":"https://api.github.com/users/yaacov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaacov/subscriptions","organizations_url":"https://api.github.com/users/yaacov/orgs","repos_url":"https://api.github.com/users/yaacov/repos","events_url":"https://api.github.com/users/yaacov/events{/privacy}","received_events_url":"https://api.github.com/users/yaacov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yaacov/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/yaacov/manageiq","forks_url":"https://api.github.com/repos/yaacov/manageiq/forks","keys_url":"https://api.github.com/repos/yaacov/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yaacov/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yaacov/manageiq/teams","hooks_url":"https://api.github.com/repos/yaacov/manageiq/hooks","issue_events_url":"https://api.github.com/repos/yaacov/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/yaacov/manageiq/events","assignees_url":"https://api.github.com/repos/yaacov/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/yaacov/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/yaacov/manageiq/tags","blobs_url":"https://api.github.com/repos/yaacov/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yaacov/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yaacov/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/yaacov/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yaacov/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/yaacov/manageiq/languages","stargazers_url":"https://api.github.com/repos/yaacov/manageiq/stargazers","contributors_url":"https://api.github.com/repos/yaacov/manageiq/contributors","subscribers_url":"https://api.github.com/repos/yaacov/manageiq/subscribers","subscription_url":"https://api.github.com/repos/yaacov/manageiq/subscription","commits_url":"https://api.github.com/repos/yaacov/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/yaacov/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/yaacov/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/yaacov/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/yaacov/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/yaacov/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yaacov/manageiq/merges","archive_url":"https://api.github.com/repos/yaacov/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yaacov/manageiq/downloads","issues_url":"https://api.github.com/repos/yaacov/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/yaacov/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/yaacov/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/yaacov/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yaacov/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/yaacov/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/yaacov/manageiq/deployments","created_at":"2016-01-14T13:01:10Z","updated_at":"2016-01-14T13:01:27Z","pushed_at":"2016-07-06T15:56:08Z","git_url":"git://github.com/yaacov/manageiq.git","ssh_url":"git@github.com:yaacov/manageiq.git","clone_url":"https://github.com/yaacov/manageiq.git","svn_url":"https://github.com/yaacov/manageiq","homepage":"manageiq.org","size":132886,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"3d9e3f379c534b5ba68d43ae8c4c222762416e5b","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq/deployments","created_at":"2014-06-13T02:31:26Z","updated_at":"2016-07-05T04:27:49Z","pushed_at":"2016-07-06T17:25:35Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":174744,"stargazers_count":290,"watchers_count":290,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":319,"mirror_url":null,"open_issues_count":737,"forks":319,"open_issues":737,"watchers":290,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9502"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/9502"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/9502"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/9502/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9502/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9502/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/099f0fb4b3046253a8dc8b806f83d3baf8c0621f"}}}}
{"actor":{"display_login":"imtayadeway"}}