{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/mail/issues/1448","repository_url":"https://api.github.com/repos/owncloud/mail","labels_url":"https://api.github.com/repos/owncloud/mail/issues/1448/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/mail/issues/1448/comments","events_url":"https://api.github.com/repos/owncloud/mail/issues/1448/events","html_url":"https://github.com/owncloud/mail/pull/1448","id":150643702,"number":1448,"title":"Show attachments as blocks instead of list to allow enhanced actions","user":{"login":"ChristophWurst","id":1374172,"avatar_url":"https://avatars.githubusercontent.com/u/1374172?v=3","gravatar_id":"","url":"https://api.github.com/users/ChristophWurst","html_url":"https://github.com/ChristophWurst","followers_url":"https://api.github.com/users/ChristophWurst/followers","following_url":"https://api.github.com/users/ChristophWurst/following{/other_user}","gists_url":"https://api.github.com/users/ChristophWurst/gists{/gist_id}","starred_url":"https://api.github.com/users/ChristophWurst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChristophWurst/subscriptions","organizations_url":"https://api.github.com/users/ChristophWurst/orgs","repos_url":"https://api.github.com/users/ChristophWurst/repos","events_url":"https://api.github.com/users/ChristophWurst/events{/privacy}","received_events_url":"https://api.github.com/users/ChristophWurst/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/owncloud/mail/labels/3%20-%20to%20review","name":"3 - to review","color":"009800"},{"url":"https://api.github.com/repos/owncloud/mail/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/owncloud/mail/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/owncloud/mail/milestones/11","html_url":"https://github.com/owncloud/mail/milestones/0.4.4","labels_url":"https://api.github.com/repos/owncloud/mail/milestones/11/labels","id":1726535,"number":11,"title":"0.4.4","description":"","creator":{"login":"ChristophWurst","id":1374172,"avatar_url":"https://avatars.githubusercontent.com/u/1374172?v=3","gravatar_id":"","url":"https://api.github.com/users/ChristophWurst","html_url":"https://github.com/ChristophWurst","followers_url":"https://api.github.com/users/ChristophWurst/followers","following_url":"https://api.github.com/users/ChristophWurst/following{/other_user}","gists_url":"https://api.github.com/users/ChristophWurst/gists{/gist_id}","starred_url":"https://api.github.com/users/ChristophWurst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChristophWurst/subscriptions","organizations_url":"https://api.github.com/users/ChristophWurst/orgs","repos_url":"https://api.github.com/users/ChristophWurst/repos","events_url":"https://api.github.com/users/ChristophWurst/events{/privacy}","received_events_url":"https://api.github.com/users/ChristophWurst/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":11,"state":"open","created_at":"2016-04-23T11:07:11Z","updated_at":"2016-05-03T19:28:28Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2016-04-24T09:28:46Z","updated_at":"2016-05-04T03:49:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/owncloud/mail/pulls/1448","html_url":"https://github.com/owncloud/mail/pull/1448","diff_url":"https://github.com/owncloud/mail/pull/1448.diff","patch_url":"https://github.com/owncloud/mail/pull/1448.patch"},"body":"This moves attachment rendering out of the message view and shows attachment as blocks instead of a simple list:\r\n![bildschirmfoto von 2016-04-24 15-48-31](https://cloud.githubusercontent.com/assets/1374172/14767969/f00e43f2-0a33-11e6-9622-74a01398a841.png)\r\n\r\n\r\nMy goal is to make the attachments view ready for enhanced attachment actions, like integration with other apps (contacts, calendar, maps) and previews of other file types (ref #1374, #79).\r\n\r\nTODO:\r\n- [x] fix single attachment\r\n- [x] make attachment width responsive (on mobile there should be only a single attachment per line)\r\n- [x] rebase onto #1447 once it's merged so the save-attachment-methods can be moved into the attachment(s) view\r\n- [x] show attachments with previews first? cc @jancborchardt (is done [by the server](https://github.com/owncloud/mail/blob/master/lib/controller/messagescontroller.php#L470-L479) already)\r\n- [x] show full attachment name on hover\r\n- [x] open attachment on click (ref #1308)\r\n- [x] fix 'save to cloud' urls (fixes #1437)\r\n- [x] find out while core failes saving the files – it failed only on my dev instance apparently\r\n\r\nIdeas for future PRs:\r\n- use popover for download and other attachment actions\r\n\r\nfixes #1308"},"comment":{"url":"https://api.github.com/repos/owncloud/mail/issues/comments/216734980","html_url":"https://github.com/owncloud/mail/pull/1448#issuecomment-216734980","issue_url":"https://api.github.com/repos/owncloud/mail/issues/1448","id":216734980,"user":{"login":"skjnldsv","id":14975046,"avatar_url":"https://avatars.githubusercontent.com/u/14975046?v=3","gravatar_id":"","url":"https://api.github.com/users/skjnldsv","html_url":"https://github.com/skjnldsv","followers_url":"https://api.github.com/users/skjnldsv/followers","following_url":"https://api.github.com/users/skjnldsv/following{/other_user}","gists_url":"https://api.github.com/users/skjnldsv/gists{/gist_id}","starred_url":"https://api.github.com/users/skjnldsv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skjnldsv/subscriptions","organizations_url":"https://api.github.com/users/skjnldsv/orgs","repos_url":"https://api.github.com/users/skjnldsv/repos","events_url":"https://api.github.com/users/skjnldsv/events{/privacy}","received_events_url":"https://api.github.com/users/skjnldsv/received_events","type":"User","site_admin":false},"created_at":"2016-05-04T03:49:18Z","updated_at":"2016-05-04T03:49:18Z","body":"Can't save on my owncloud file:\r\n```\r\nError\tindex\tOCP\\Lock\\LockedException: \"Site.zip\" is locked\r\n/usr/share/webapps/owncloud/lib/private/files/view.php - line 1085: OC\\Files\\View-changeLock('/admin/files/Si...', 1)\r\n/usr/share/webapps/owncloud/lib/private/files/view.php - line 506: OC\\Files\\View-basicOperation('touch', '/admin/files/Si...', Array, NULL)\r\n/usr/share/webapps/owncloud/lib/private/files/node/folder.php - line 165: OC\\Files\\View-touch('/admin/files/Si...')\r\n/usr/share/webapps/owncloud/apps/mail/lib/controller/messagescontroller.php - line 307: OC\\Files\\Node\\Folder->newFile('//Site.zip')\r\n[internal function] OCA\\Mail\\Controller\\MessagesController->saveAttachment(2, 'QXJjaGl2ZXM=', '50', 2, '/')\r\n/usr/share/webapps/owncloud/lib/private/appframework/http/dispatcher.php - line 159: call_user_func_array(Array, Array)\r\n/usr/share/webapps/owncloud/lib/private/appframework/http/dispatcher.php - line 89: OC\\AppFramework\\Http\\Dispatcher->executeController(Object(OCA\\Mail\\Controller\\MessagesController), 'saveAttachment')\r\n/usr/share/webapps/owncloud/lib/private/appframework/app.php - line 110: OC\\AppFramework\\Http\\Dispatcher->dispatch(Object(OCA\\Mail\\Controller\\MessagesController), 'saveAttachment')\r\n/usr/share/webapps/owncloud/lib/private/appframework/routing/routeactionhandler.php - line 45: OC\\AppFramework\\App main('OCA\\\\Mail\\\\Contro...', 'saveAttachment', Object(OC\\AppFramework\\DependencyInjection\\DIContainer), Array)\r\n[internal function] OC\\AppFramework\\routing\\RouteActionHandler->__invoke(Array)\r\n/usr/share/webapps/owncloud/lib/private/route/router.php - line 276: call_user_func(Object(OC\\AppFramework\\routing\\RouteActionHandler), Array)\r\n/usr/share/webapps/owncloud/lib/base.php - line 882: OC\\Route\\Router->match('/apps/mail/acco...')\r\n/usr/share/webapps/owncloud/index.php - line 39: OC handleRequest()\r\n{main}\r\n```"}}