{"push_id":1258299727,"size":2,"distinct_size":1,"ref":"refs/heads/yujieproject/build_ignore_exclude_target_regexp_v2_engine","head":"b6fe17d760f897688e8b1d40528ebfd1c50b8480","before":"56bbe7aea41a586da8ed912c88836ea2a760d01f","commits":[{"sha":"fb960ab39609b964f560afc59a0cff7a18f2ca42","author":{"name":"Lex Spoon","email":"b8a07ae435b8bc9412aa378f87867c52a87a06e7@squareup.com"},"message":"Adjust the output file locations for the Antlr task.\n\nThe Antlr rules don't currently lead to a happy IntelliJ configuration. This PR is one way to fix it, although I'm not really sure what the best approach is.\n\nThe root problem is that Antlr dumps its output files into a path determined by the relative path specified for the input file. This PR takes the simple approach of moving all the files once they have been generated.\n\nAs a possible alternative, the files could be left in their current location, and the IntelliJ support could be modified to generate a better source root for the resulting code. It seemed slightly better, though, to try and fix the file locations earlier in the pipeline, right when they are generated. Antlr has predictable output, so it's not too hard to just fix it up.\n\nTesting Done:\nI checked the behavior with the checked-in Antlr samples:\n```\n./pants  idea ./examples/src/java/org/pantsbuild/example/antlr3::\n./pants  idea ./examples/src/java/org/pantsbuild/example/antlr4::\n```\nI also ran the the `unit-test.sh` script.\n\nTravis CI has passed: https://travis-ci.org/pantsbuild/pants/builds/152249047\n\nBugs closed: 3787\n\nReviewed at https://rbcommons.com/s/twitter/r/4161/","distinct":false,"url":"https://api.github.com/repos/JieGhost/pants/commits/fb960ab39609b964f560afc59a0cff7a18f2ca42"},{"sha":"b6fe17d760f897688e8b1d40528ebfd1c50b8480","author":{"name":"Yujie Chen","email":"65c382bc2340b7893f23fa0d1be4ebac3c5fd60c@gmail.com"},"message":"Merge branch 'master' into yujieproject/build_ignore_exclude_target_regexp_v2_engine","distinct":true,"url":"https://api.github.com/repos/JieGhost/pants/commits/b6fe17d760f897688e8b1d40528ebfd1c50b8480"}]}
{"actor":{"display_login":"JieGhost"}}