{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/17241","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/17241/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/17241/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/17241/events","html_url":"https://github.com/NixOS/nixpkgs/pull/17241","id":167250088,"number":17241,"title":"antBuild: run default hooks","user":{"login":"rasendubi","id":1366419,"avatar_url":"https://avatars.githubusercontent.com/u/1366419?v=3","gravatar_id":"","url":"https://api.github.com/users/rasendubi","html_url":"https://github.com/rasendubi","followers_url":"https://api.github.com/users/rasendubi/followers","following_url":"https://api.github.com/users/rasendubi/following{/other_user}","gists_url":"https://api.github.com/users/rasendubi/gists{/gist_id}","starred_url":"https://api.github.com/users/rasendubi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rasendubi/subscriptions","organizations_url":"https://api.github.com/users/rasendubi/orgs","repos_url":"https://api.github.com/users/rasendubi/repos","events_url":"https://api.github.com/users/rasendubi/events{/privacy}","received_events_url":"https://api.github.com/users/rasendubi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-07-24T19:38:24Z","updated_at":"2016-07-25T22:52:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/17241","html_url":"https://github.com/NixOS/nixpkgs/pull/17241","diff_url":"https://github.com/NixOS/nixpkgs/pull/17241.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/17241.patch"},"body":"###### Motivation for this change\r\nFixes https://github.com/NixOS/nixpkgs/issues/10931.\r\nantBuild overrides buildPhase and installPhase without calling default\r\nhooks.\r\n\r\n###### Things done\r\n\r\n- [ ] Tested using sandboxing\r\n  ([nix.useChroot](http://nixos.org/nixos/manual/options.html#opt-nix.useChroot) on NixOS,\r\n    or option `build-use-chroot` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)\r\n    on non-NixOS)\r\n- Built on platform(s)\r\n   - [ ] NixOS\r\n   - [ ] OS X\r\n   - [ ] Linux\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\nNOT TESTED"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/235110833","html_url":"https://github.com/NixOS/nixpkgs/pull/17241#issuecomment-235110833","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/17241","id":235110833,"user":{"login":"rasendubi","id":1366419,"avatar_url":"https://avatars.githubusercontent.com/u/1366419?v=3","gravatar_id":"","url":"https://api.github.com/users/rasendubi","html_url":"https://github.com/rasendubi","followers_url":"https://api.github.com/users/rasendubi/followers","following_url":"https://api.github.com/users/rasendubi/following{/other_user}","gists_url":"https://api.github.com/users/rasendubi/gists{/gist_id}","starred_url":"https://api.github.com/users/rasendubi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rasendubi/subscriptions","organizations_url":"https://api.github.com/users/rasendubi/orgs","repos_url":"https://api.github.com/users/rasendubi/repos","events_url":"https://api.github.com/users/rasendubi/events{/privacy}","received_events_url":"https://api.github.com/users/rasendubi/received_events","type":"User","site_admin":false},"created_at":"2016-07-25T22:52:44Z","updated_at":"2016-07-25T22:52:44Z","body":"Found it! I've confused `++` with `+` for string concatenation. Now junit should fail as expected ;)"}}
{"actor":{"display_login":"rasendubi"}}