{"action":"created","issue":{"url":"https://api.github.com/repos/ldc-developers/ldc/issues/1717","repository_url":"https://api.github.com/repos/ldc-developers/ldc","labels_url":"https://api.github.com/repos/ldc-developers/ldc/issues/1717/labels{/name}","comments_url":"https://api.github.com/repos/ldc-developers/ldc/issues/1717/comments","events_url":"https://api.github.com/repos/ldc-developers/ldc/issues/1717/events","html_url":"https://github.com/ldc-developers/ldc/pull/1717","id":172333431,"number":1717,"title":"Issue 1716: Improve CodeView debug info","user":{"login":"rainers","id":702284,"avatar_url":"https://avatars.githubusercontent.com/u/702284?v=3","gravatar_id":"","url":"https://api.github.com/users/rainers","html_url":"https://github.com/rainers","followers_url":"https://api.github.com/users/rainers/followers","following_url":"https://api.github.com/users/rainers/following{/other_user}","gists_url":"https://api.github.com/users/rainers/gists{/gist_id}","starred_url":"https://api.github.com/users/rainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rainers/subscriptions","organizations_url":"https://api.github.com/users/rainers/orgs","repos_url":"https://api.github.com/users/rainers/repos","events_url":"https://api.github.com/users/rainers/events{/privacy}","received_events_url":"https://api.github.com/users/rainers/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2016-08-21T18:19:33Z","updated_at":"2016-08-24T22:29:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ldc-developers/ldc/pulls/1717","html_url":"https://github.com/ldc-developers/ldc/pull/1717","diff_url":"https://github.com/ldc-developers/ldc/pull/1717.diff","patch_url":"https://github.com/ldc-developers/ldc/pull/1717.patch"},"body":"Changes:\r\n- byte,ubyte should be encoded as DW_ATE_signed_char/DW_ATE_unsigned_char, not DW_ATE_signed/DW_ATE_unsigned\r\n- encode wchar,dchar as UTF\r\n- do not declare struct/class definitions as FlagFwdDecl\r\n- pass deco as unique identifier to UDTs\r\n- dynamic arrays: use type name, don't leave it empty\r\n- use proper type name for delegates\r\n- add support for type \"void\" and \"typeof(null)\"\r\n\r\nNot sure how much of this can negatively affect other platforms. Should I put it under some Windows/codeView specific conditional?\r\n"},"comment":{"url":"https://api.github.com/repos/ldc-developers/ldc/issues/comments/242228648","html_url":"https://github.com/ldc-developers/ldc/pull/1717#issuecomment-242228648","issue_url":"https://api.github.com/repos/ldc-developers/ldc/issues/1717","id":242228648,"user":{"login":"klickverbot","id":19335,"avatar_url":"https://avatars.githubusercontent.com/u/19335?v=3","gravatar_id":"","url":"https://api.github.com/users/klickverbot","html_url":"https://github.com/klickverbot","followers_url":"https://api.github.com/users/klickverbot/followers","following_url":"https://api.github.com/users/klickverbot/following{/other_user}","gists_url":"https://api.github.com/users/klickverbot/gists{/gist_id}","starred_url":"https://api.github.com/users/klickverbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klickverbot/subscriptions","organizations_url":"https://api.github.com/users/klickverbot/orgs","repos_url":"https://api.github.com/users/klickverbot/repos","events_url":"https://api.github.com/users/klickverbot/events{/privacy}","received_events_url":"https://api.github.com/users/klickverbot/received_events","type":"User","site_admin":false},"created_at":"2016-08-24T22:29:49Z","updated_at":"2016-08-24T22:29:49Z","body":"@JohanEngelen: Definitely agreed on the alignment use case. My claim is just that for debug info, the IR layer is not the correct place for tests, as it doesn't really have much meaning by itself – as you pointed out from Clang, it is a rather leaky abstraction. What we really want to test is that debug info is lowered to the object/PDB files in a way we know works with the target debuggers. We can probably dump the debug info into a textual form, though, and use FileCheck on that."}}
{"actor":{"display_login":"klickverbot"}}