{"action":"created","issue":{"url":"https://api.github.com/repos/KeepSafe/aiohttp/issues/1411","repository_url":"https://api.github.com/repos/KeepSafe/aiohttp","labels_url":"https://api.github.com/repos/KeepSafe/aiohttp/issues/1411/labels{/name}","comments_url":"https://api.github.com/repos/KeepSafe/aiohttp/issues/1411/comments","events_url":"https://api.github.com/repos/KeepSafe/aiohttp/issues/1411/events","html_url":"https://github.com/KeepSafe/aiohttp/pull/1411","id":190533746,"number":1411,"title":"Fix bug: connection not close except exceptions occured.","user":{"login":"jiajunhuang","id":5924269,"avatar_url":"https://avatars.githubusercontent.com/u/5924269?v=3","gravatar_id":"","url":"https://api.github.com/users/jiajunhuang","html_url":"https://github.com/jiajunhuang","followers_url":"https://api.github.com/users/jiajunhuang/followers","following_url":"https://api.github.com/users/jiajunhuang/following{/other_user}","gists_url":"https://api.github.com/users/jiajunhuang/gists{/gist_id}","starred_url":"https://api.github.com/users/jiajunhuang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiajunhuang/subscriptions","organizations_url":"https://api.github.com/users/jiajunhuang/orgs","repos_url":"https://api.github.com/users/jiajunhuang/repos","events_url":"https://api.github.com/users/jiajunhuang/events{/privacy}","received_events_url":"https://api.github.com/users/jiajunhuang/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-20T01:59:05Z","updated_at":"2016-11-20T07:53:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/1411","html_url":"https://github.com/KeepSafe/aiohttp/pull/1411","diff_url":"https://github.com/KeepSafe/aiohttp/pull/1411.diff","patch_url":"https://github.com/KeepSafe/aiohttp/pull/1411.patch"},"body":"## What do these changes do?\r\n\r\nit seems that the connection to will not close until exceptions occured.\r\n\r\n## Are there changes in behavior for the user?\r\n\r\nNope\r\n\r\n## Related issue number\r\n\r\nNope\r\n\r\n## Checklist\r\n\r\n- [ ] I think the code is well written\r\n- [ ] Unit tests for the changes exist\r\n- [ ] Documentation reflects the changes\r\n- [ ] Add yourself to `CONTRIBUTORS.txt`\r\n  * The format is &lt;Name&gt; &lt;Surname&gt;.\r\n  * Please keep alphabetical order, the file is sorted by names. \r\n- [ ] Add a new entry to `CHANGES.rst`\r\n  * Choose any open position to avoid merge conflicts with other PRs.\r\n  * Add a link to the issue you are fixing (if any) using `#issue_number` format at the end of changelog message. Use Pull Request number if there are no issues for PR or PR covers the issue only partially.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/KeepSafe/aiohttp/issues/comments/261764377","html_url":"https://github.com/KeepSafe/aiohttp/pull/1411#issuecomment-261764377","issue_url":"https://api.github.com/repos/KeepSafe/aiohttp/issues/1411","id":261764377,"user":{"login":"asvetlov","id":356399,"avatar_url":"https://avatars.githubusercontent.com/u/356399?v=3","gravatar_id":"","url":"https://api.github.com/users/asvetlov","html_url":"https://github.com/asvetlov","followers_url":"https://api.github.com/users/asvetlov/followers","following_url":"https://api.github.com/users/asvetlov/following{/other_user}","gists_url":"https://api.github.com/users/asvetlov/gists{/gist_id}","starred_url":"https://api.github.com/users/asvetlov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asvetlov/subscriptions","organizations_url":"https://api.github.com/users/asvetlov/orgs","repos_url":"https://api.github.com/users/asvetlov/repos","events_url":"https://api.github.com/users/asvetlov/events{/privacy}","received_events_url":"https://api.github.com/users/asvetlov/received_events","type":"User","site_admin":false},"created_at":"2016-11-20T07:53:42Z","updated_at":"2016-11-20T07:53:42Z","body":"Are you aware about unit tests existing?\r\nYour PR breaks 47 tests.\r\n\r\nMoreover, it's useless: `response.close()` calls `connection.close()` internally, isn't it?"}}
{"actor":{"display_login":"asvetlov"}}