{"action":"created","comment":{"url":"https://api.github.com/repos/ember-cli/ember-cli/pulls/comments/69255210","id":69255210,"diff_hunk":"@@ -34,22 +34,23 @@ module.exports = Task.extend({\n \n     ui.startProgress(chalk.green('Installing addon package'), chalk.green('.'));\n \n+    var willSave = this.project.isEmberCLIAddon() && commandOptions.save;\n     return npmInstall.run({\n       packages: packageNames,\n-      'save-dev': true,\n+      'save-dev': !willSave,\n       'save-exact': true\n     }).then(function() {\n       return this.project.reloadAddons();\n     }.bind(this)).then(function() {\n-      return this.installBlueprint(blueprintInstall, packageNames, blueprintOptions);\n+      return this.installBlueprint(blueprintInstall, packageNames);","path":"lib/tasks/addon-install.js","position":25,"original_position":25,"commit_id":"81985dd0a6452131b7a995dfc4b46b00a9407e95","original_commit_id":"81985dd0a6452131b7a995dfc4b46b00a9407e95","user":{"login":"xcambar","id":657654,"avatar_url":"https://avatars.githubusercontent.com/u/657654?v=3","gravatar_id":"","url":"https://api.github.com/users/xcambar","html_url":"https://github.com/xcambar","followers_url":"https://api.github.com/users/xcambar/followers","following_url":"https://api.github.com/users/xcambar/following{/other_user}","gists_url":"https://api.github.com/users/xcambar/gists{/gist_id}","starred_url":"https://api.github.com/users/xcambar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xcambar/subscriptions","organizations_url":"https://api.github.com/users/xcambar/orgs","repos_url":"https://api.github.com/users/xcambar/repos","events_url":"https://api.github.com/users/xcambar/events{/privacy}","received_events_url":"https://api.github.com/users/xcambar/received_events","type":"User","site_admin":false},"body":"Code and tests seem to indicate there is no breakage here.\r\n\r\nBut I'm an untrained eye when it comes to the source code of ember-cli, so thanks for asking for another perspective.","created_at":"2016-07-01T06:34:54Z","updated_at":"2016-07-01T06:34:54Z","html_url":"https://github.com/ember-cli/ember-cli/pull/6017#discussion_r69255210","pull_request_url":"https://api.github.com/repos/ember-cli/ember-cli/pulls/6017","_links":{"self":{"href":"https://api.github.com/repos/ember-cli/ember-cli/pulls/comments/69255210"},"html":{"href":"https://github.com/ember-cli/ember-cli/pull/6017#discussion_r69255210"},"pull_request":{"href":"https://api.github.com/repos/ember-cli/ember-cli/pulls/6017"}}},"pull_request":{"url":"https://api.github.com/repos/ember-cli/ember-cli/pulls/6017","id":74932932,"html_url":"https://github.com/ember-cli/ember-cli/pull/6017","diff_url":"https://github.com/ember-cli/ember-cli/pull/6017.diff","patch_url":"https://github.com/ember-cli/ember-cli/pull/6017.patch","issue_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/6017","number":6017,"state":"open","locked":false,"title":"Allow `ember install addon_name --save` in addons.","user":{"login":"xcambar","id":657654,"avatar_url":"https://avatars.githubusercontent.com/u/657654?v=3","gravatar_id":"","url":"https://api.github.com/users/xcambar","html_url":"https://github.com/xcambar","followers_url":"https://api.github.com/users/xcambar/followers","following_url":"https://api.github.com/users/xcambar/following{/other_user}","gists_url":"https://api.github.com/users/xcambar/gists{/gist_id}","starred_url":"https://api.github.com/users/xcambar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xcambar/subscriptions","organizations_url":"https://api.github.com/users/xcambar/orgs","repos_url":"https://api.github.com/users/xcambar/repos","events_url":"https://api.github.com/users/xcambar/events{/privacy}","received_events_url":"https://api.github.com/users/xcambar/received_events","type":"User","site_admin":false},"body":"My team and I are regularly annoyed when developing addons with the following scenario:\r\n\r\n* execute `ember install whatever_addon` in the addon `our_addon`\r\n* execute `ember install `our_addon` in the app `our_app`\r\n* Realise that `whatever addon` is not packaged in the app `our_app`\r\n* Cringe\r\n* Remind ourselves why it's a perfectly sane situation\r\n* Update `package.json` in `our_addon` to move `whatever_addon` from `devDependencies` to `dependencies`\r\n* Rinse\r\n* Repeat\r\n\r\nThis PR add the option `--save` to `ember install` that saves addons in `dependencies` instead of `devDependencies` iff the command is run in an addon.\r\n\r\nHope you'll like it!","created_at":"2016-06-23T10:43:19Z","updated_at":"2016-07-01T06:34:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d6880d11cb98e2f520987d7e5e92d77488435a95","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ember-cli/ember-cli/pulls/6017/commits","review_comments_url":"https://api.github.com/repos/ember-cli/ember-cli/pulls/6017/comments","review_comment_url":"https://api.github.com/repos/ember-cli/ember-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/6017/comments","statuses_url":"https://api.github.com/repos/ember-cli/ember-cli/statuses/81985dd0a6452131b7a995dfc4b46b00a9407e95","head":{"label":"xcambar:install_save","ref":"install_save","sha":"81985dd0a6452131b7a995dfc4b46b00a9407e95","user":{"login":"xcambar","id":657654,"avatar_url":"https://avatars.githubusercontent.com/u/657654?v=3","gravatar_id":"","url":"https://api.github.com/users/xcambar","html_url":"https://github.com/xcambar","followers_url":"https://api.github.com/users/xcambar/followers","following_url":"https://api.github.com/users/xcambar/following{/other_user}","gists_url":"https://api.github.com/users/xcambar/gists{/gist_id}","starred_url":"https://api.github.com/users/xcambar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xcambar/subscriptions","organizations_url":"https://api.github.com/users/xcambar/orgs","repos_url":"https://api.github.com/users/xcambar/repos","events_url":"https://api.github.com/users/xcambar/events{/privacy}","received_events_url":"https://api.github.com/users/xcambar/received_events","type":"User","site_admin":false},"repo":{"id":42076094,"name":"ember-cli","full_name":"xcambar/ember-cli","owner":{"login":"xcambar","id":657654,"avatar_url":"https://avatars.githubusercontent.com/u/657654?v=3","gravatar_id":"","url":"https://api.github.com/users/xcambar","html_url":"https://github.com/xcambar","followers_url":"https://api.github.com/users/xcambar/followers","following_url":"https://api.github.com/users/xcambar/following{/other_user}","gists_url":"https://api.github.com/users/xcambar/gists{/gist_id}","starred_url":"https://api.github.com/users/xcambar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xcambar/subscriptions","organizations_url":"https://api.github.com/users/xcambar/orgs","repos_url":"https://api.github.com/users/xcambar/repos","events_url":"https://api.github.com/users/xcambar/events{/privacy}","received_events_url":"https://api.github.com/users/xcambar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xcambar/ember-cli","description":"","fork":true,"url":"https://api.github.com/repos/xcambar/ember-cli","forks_url":"https://api.github.com/repos/xcambar/ember-cli/forks","keys_url":"https://api.github.com/repos/xcambar/ember-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xcambar/ember-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xcambar/ember-cli/teams","hooks_url":"https://api.github.com/repos/xcambar/ember-cli/hooks","issue_events_url":"https://api.github.com/repos/xcambar/ember-cli/issues/events{/number}","events_url":"https://api.github.com/repos/xcambar/ember-cli/events","assignees_url":"https://api.github.com/repos/xcambar/ember-cli/assignees{/user}","branches_url":"https://api.github.com/repos/xcambar/ember-cli/branches{/branch}","tags_url":"https://api.github.com/repos/xcambar/ember-cli/tags","blobs_url":"https://api.github.com/repos/xcambar/ember-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xcambar/ember-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xcambar/ember-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/xcambar/ember-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xcambar/ember-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/xcambar/ember-cli/languages","stargazers_url":"https://api.github.com/repos/xcambar/ember-cli/stargazers","contributors_url":"https://api.github.com/repos/xcambar/ember-cli/contributors","subscribers_url":"https://api.github.com/repos/xcambar/ember-cli/subscribers","subscription_url":"https://api.github.com/repos/xcambar/ember-cli/subscription","commits_url":"https://api.github.com/repos/xcambar/ember-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/xcambar/ember-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/xcambar/ember-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/xcambar/ember-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/xcambar/ember-cli/contents/{+path}","compare_url":"https://api.github.com/repos/xcambar/ember-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xcambar/ember-cli/merges","archive_url":"https://api.github.com/repos/xcambar/ember-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xcambar/ember-cli/downloads","issues_url":"https://api.github.com/repos/xcambar/ember-cli/issues{/number}","pulls_url":"https://api.github.com/repos/xcambar/ember-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/xcambar/ember-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/xcambar/ember-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xcambar/ember-cli/labels{/name}","releases_url":"https://api.github.com/repos/xcambar/ember-cli/releases{/id}","deployments_url":"https://api.github.com/repos/xcambar/ember-cli/deployments","created_at":"2015-09-07T21:50:01Z","updated_at":"2015-09-07T21:50:03Z","pushed_at":"2016-06-23T11:53:52Z","git_url":"git://github.com/xcambar/ember-cli.git","ssh_url":"git@github.com:xcambar/ember-cli.git","clone_url":"https://github.com/xcambar/ember-cli.git","svn_url":"https://github.com/xcambar/ember-cli","homepage":"http://www.ember-cli.com/","size":10499,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ember-cli:master","ref":"master","sha":"5c83db55a7a4756f4acaa69185d2874c407063e3","user":{"login":"ember-cli","id":10262982,"avatar_url":"https://avatars.githubusercontent.com/u/10262982?v=3","gravatar_id":"","url":"https://api.github.com/users/ember-cli","html_url":"https://github.com/ember-cli","followers_url":"https://api.github.com/users/ember-cli/followers","following_url":"https://api.github.com/users/ember-cli/following{/other_user}","gists_url":"https://api.github.com/users/ember-cli/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-cli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-cli/subscriptions","organizations_url":"https://api.github.com/users/ember-cli/orgs","repos_url":"https://api.github.com/users/ember-cli/repos","events_url":"https://api.github.com/users/ember-cli/events{/privacy}","received_events_url":"https://api.github.com/users/ember-cli/received_events","type":"Organization","site_admin":false},"repo":{"id":14089735,"name":"ember-cli","full_name":"ember-cli/ember-cli","owner":{"login":"ember-cli","id":10262982,"avatar_url":"https://avatars.githubusercontent.com/u/10262982?v=3","gravatar_id":"","url":"https://api.github.com/users/ember-cli","html_url":"https://github.com/ember-cli","followers_url":"https://api.github.com/users/ember-cli/followers","following_url":"https://api.github.com/users/ember-cli/following{/other_user}","gists_url":"https://api.github.com/users/ember-cli/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-cli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-cli/subscriptions","organizations_url":"https://api.github.com/users/ember-cli/orgs","repos_url":"https://api.github.com/users/ember-cli/repos","events_url":"https://api.github.com/users/ember-cli/events{/privacy}","received_events_url":"https://api.github.com/users/ember-cli/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ember-cli/ember-cli","description":"The Ember.js command line utility","fork":false,"url":"https://api.github.com/repos/ember-cli/ember-cli","forks_url":"https://api.github.com/repos/ember-cli/ember-cli/forks","keys_url":"https://api.github.com/repos/ember-cli/ember-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ember-cli/ember-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ember-cli/ember-cli/teams","hooks_url":"https://api.github.com/repos/ember-cli/ember-cli/hooks","issue_events_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/events{/number}","events_url":"https://api.github.com/repos/ember-cli/ember-cli/events","assignees_url":"https://api.github.com/repos/ember-cli/ember-cli/assignees{/user}","branches_url":"https://api.github.com/repos/ember-cli/ember-cli/branches{/branch}","tags_url":"https://api.github.com/repos/ember-cli/ember-cli/tags","blobs_url":"https://api.github.com/repos/ember-cli/ember-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ember-cli/ember-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ember-cli/ember-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/ember-cli/ember-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ember-cli/ember-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/ember-cli/ember-cli/languages","stargazers_url":"https://api.github.com/repos/ember-cli/ember-cli/stargazers","contributors_url":"https://api.github.com/repos/ember-cli/ember-cli/contributors","subscribers_url":"https://api.github.com/repos/ember-cli/ember-cli/subscribers","subscription_url":"https://api.github.com/repos/ember-cli/ember-cli/subscription","commits_url":"https://api.github.com/repos/ember-cli/ember-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/ember-cli/ember-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/ember-cli/ember-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/ember-cli/ember-cli/contents/{+path}","compare_url":"https://api.github.com/repos/ember-cli/ember-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ember-cli/ember-cli/merges","archive_url":"https://api.github.com/repos/ember-cli/ember-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ember-cli/ember-cli/downloads","issues_url":"https://api.github.com/repos/ember-cli/ember-cli/issues{/number}","pulls_url":"https://api.github.com/repos/ember-cli/ember-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/ember-cli/ember-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/ember-cli/ember-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ember-cli/ember-cli/labels{/name}","releases_url":"https://api.github.com/repos/ember-cli/ember-cli/releases{/id}","deployments_url":"https://api.github.com/repos/ember-cli/ember-cli/deployments","created_at":"2013-11-03T17:34:43Z","updated_at":"2016-06-30T22:03:11Z","pushed_at":"2016-07-01T04:12:52Z","git_url":"git://github.com/ember-cli/ember-cli.git","ssh_url":"git@github.com:ember-cli/ember-cli.git","clone_url":"https://github.com/ember-cli/ember-cli.git","svn_url":"https://github.com/ember-cli/ember-cli","homepage":"http://ember-cli.com/","size":18797,"stargazers_count":2902,"watchers_count":2902,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":853,"mirror_url":null,"open_issues_count":86,"forks":853,"open_issues":86,"watchers":2902,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ember-cli/ember-cli/pulls/6017"},"html":{"href":"https://github.com/ember-cli/ember-cli/pull/6017"},"issue":{"href":"https://api.github.com/repos/ember-cli/ember-cli/issues/6017"},"comments":{"href":"https://api.github.com/repos/ember-cli/ember-cli/issues/6017/comments"},"review_comments":{"href":"https://api.github.com/repos/ember-cli/ember-cli/pulls/6017/comments"},"review_comment":{"href":"https://api.github.com/repos/ember-cli/ember-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ember-cli/ember-cli/pulls/6017/commits"},"statuses":{"href":"https://api.github.com/repos/ember-cli/ember-cli/statuses/81985dd0a6452131b7a995dfc4b46b00a9407e95"}}}}
{"actor":{"display_login":"xcambar"}}