{"action":"created","comment":{"url":"https://api.github.com/repos/fastlane/fastlane/pulls/comments/92312104","pull_request_review_id":12824304,"id":92312104,"diff_hunk":"@@ -62,6 +66,19 @@ def upload_metadata\n       UploadAssets.new.upload(options) # e.g. app icon\n     end\n \n+    def prepare_app_icons(options = {})\n+      app_icon_path = options[:app_icon] if options[:app_icon]\n+      app_icon_metadata = File.join(options[:metadata_path], \"app_icon.png\")\n+      if app_icon_path.nil? && File.exist?(app_icon_metadata)\n+        options[:app_icon] = app_icon_metadata\n+      end\n+      watch_icon_path = options[:apple_watch_app_icon] if options[:apple_watch_app_icon]","path":"deliver/lib/deliver/runner.rb","position":21,"original_position":21,"commit_id":"bb96ffc4d4c6199c6558c37732b5700da9f67e34","original_commit_id":"bb96ffc4d4c6199c6558c37732b5700da9f67e34","user":{"login":"KrauseFx","id":869950,"avatar_url":"https://avatars.githubusercontent.com/u/869950?v=3","gravatar_id":"","url":"https://api.github.com/users/KrauseFx","html_url":"https://github.com/KrauseFx","followers_url":"https://api.github.com/users/KrauseFx/followers","following_url":"https://api.github.com/users/KrauseFx/following{/other_user}","gists_url":"https://api.github.com/users/KrauseFx/gists{/gist_id}","starred_url":"https://api.github.com/users/KrauseFx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KrauseFx/subscriptions","organizations_url":"https://api.github.com/users/KrauseFx/orgs","repos_url":"https://api.github.com/users/KrauseFx/repos","events_url":"https://api.github.com/users/KrauseFx/events{/privacy}","received_events_url":"https://api.github.com/users/KrauseFx/received_events","type":"User","site_admin":false},"body":"Both code blocks seem overly complicated, can we use\r\n\r\n```ruby\r\ndefault_app_icon_path = File.join(options[:metadata_path], \"app_icon.png\")\r\noptions[:app_icon] ||= default_app_icon_path if File.exist?(default_app_icon_path)\r\n```\r\nThis should have the same effect, right? ","created_at":"2016-12-14T02:31:29Z","updated_at":"2016-12-14T02:31:40Z","html_url":"https://github.com/fastlane/fastlane/pull/7398#discussion_r92312104","pull_request_url":"https://api.github.com/repos/fastlane/fastlane/pulls/7398","_links":{"self":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/comments/92312104"},"html":{"href":"https://github.com/fastlane/fastlane/pull/7398#discussion_r92312104"},"pull_request":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/7398"}}},"pull_request":{"url":"https://api.github.com/repos/fastlane/fastlane/pulls/7398","id":97263631,"html_url":"https://github.com/fastlane/fastlane/pull/7398","diff_url":"https://github.com/fastlane/fastlane/pull/7398.diff","patch_url":"https://github.com/fastlane/fastlane/pull/7398.patch","issue_url":"https://api.github.com/repos/fastlane/fastlane/issues/7398","number":7398,"state":"open","locked":false,"title":"[deliver] support app_icons via metadata","user":{"login":"hjanuschka","id":2891702,"avatar_url":"https://avatars.githubusercontent.com/u/2891702?v=3","gravatar_id":"","url":"https://api.github.com/users/hjanuschka","html_url":"https://github.com/hjanuschka","followers_url":"https://api.github.com/users/hjanuschka/followers","following_url":"https://api.github.com/users/hjanuschka/following{/other_user}","gists_url":"https://api.github.com/users/hjanuschka/gists{/gist_id}","starred_url":"https://api.github.com/users/hjanuschka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjanuschka/subscriptions","organizations_url":"https://api.github.com/users/hjanuschka/orgs","repos_url":"https://api.github.com/users/hjanuschka/repos","events_url":"https://api.github.com/users/hjanuschka/events{/privacy}","received_events_url":"https://api.github.com/users/hjanuschka/received_events","type":"User","site_admin":false},"body":"This one adds support for upload/download of app_icon/apple_watch_icon.\r\n\r\nicons are stored int `metdata/app_icon.png` `metdata/watch_icon.png`\r\n\r\n# Upload\r\nas there is an option to explicit set a path to an app_icon, and to not break existing usage of this flags, the option will be used if set. otherwise if unset, and a file exists in the metdata folder root this file will be used\r\n\r\n![bildschirmfoto 2016-12-09 um 08 31 43](https://cloud.githubusercontent.com/assets/2891702/21041276/3a3543d0-bdea-11e6-8195-1c3d7ad1c1f4.png)\r\n\r\n<img width=\"651\" alt=\"bildschirmfoto 2016-12-09 um 08 41 47\" src=\"https://cloud.githubusercontent.com/assets/2891702/21041455/5bc193b8-bdeb-11e6-9482-275220d234b6.png\">\r\n\r\n\r\n# Download\r\n`download_metadata`  also downloads existing app icons.\r\n\r\n![bildschirmfoto 2016-12-09 um 12 23 49](https://cloud.githubusercontent.com/assets/2891702/21047469/66ee6224-be0a-11e6-94d0-d5b388859b84.png)\r\n\r\n\r\n> App icon redacted 👍 ","created_at":"2016-12-09T07:35:44Z","updated_at":"2016-12-14T02:31:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8fea1b32fafeaa5c107f666203a393b0e6de3c15","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/fastlane/fastlane/pulls/7398/commits","review_comments_url":"https://api.github.com/repos/fastlane/fastlane/pulls/7398/comments","review_comment_url":"https://api.github.com/repos/fastlane/fastlane/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fastlane/fastlane/issues/7398/comments","statuses_url":"https://api.github.com/repos/fastlane/fastlane/statuses/bb96ffc4d4c6199c6558c37732b5700da9f67e34","head":{"label":"hjanuschka:deliver_app_icons","ref":"deliver_app_icons","sha":"bb96ffc4d4c6199c6558c37732b5700da9f67e34","user":{"login":"hjanuschka","id":2891702,"avatar_url":"https://avatars.githubusercontent.com/u/2891702?v=3","gravatar_id":"","url":"https://api.github.com/users/hjanuschka","html_url":"https://github.com/hjanuschka","followers_url":"https://api.github.com/users/hjanuschka/followers","following_url":"https://api.github.com/users/hjanuschka/following{/other_user}","gists_url":"https://api.github.com/users/hjanuschka/gists{/gist_id}","starred_url":"https://api.github.com/users/hjanuschka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjanuschka/subscriptions","organizations_url":"https://api.github.com/users/hjanuschka/orgs","repos_url":"https://api.github.com/users/hjanuschka/repos","events_url":"https://api.github.com/users/hjanuschka/events{/privacy}","received_events_url":"https://api.github.com/users/hjanuschka/received_events","type":"User","site_admin":false},"repo":{"id":54015246,"name":"fastlane","full_name":"hjanuschka/fastlane","owner":{"login":"hjanuschka","id":2891702,"avatar_url":"https://avatars.githubusercontent.com/u/2891702?v=3","gravatar_id":"","url":"https://api.github.com/users/hjanuschka","html_url":"https://github.com/hjanuschka","followers_url":"https://api.github.com/users/hjanuschka/followers","following_url":"https://api.github.com/users/hjanuschka/following{/other_user}","gists_url":"https://api.github.com/users/hjanuschka/gists{/gist_id}","starred_url":"https://api.github.com/users/hjanuschka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjanuschka/subscriptions","organizations_url":"https://api.github.com/users/hjanuschka/orgs","repos_url":"https://api.github.com/users/hjanuschka/repos","events_url":"https://api.github.com/users/hjanuschka/events{/privacy}","received_events_url":"https://api.github.com/users/hjanuschka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hjanuschka/fastlane","description":"Connect all iOS and Android deployment tools into one streamlined workflow","fork":true,"url":"https://api.github.com/repos/hjanuschka/fastlane","forks_url":"https://api.github.com/repos/hjanuschka/fastlane/forks","keys_url":"https://api.github.com/repos/hjanuschka/fastlane/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hjanuschka/fastlane/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hjanuschka/fastlane/teams","hooks_url":"https://api.github.com/repos/hjanuschka/fastlane/hooks","issue_events_url":"https://api.github.com/repos/hjanuschka/fastlane/issues/events{/number}","events_url":"https://api.github.com/repos/hjanuschka/fastlane/events","assignees_url":"https://api.github.com/repos/hjanuschka/fastlane/assignees{/user}","branches_url":"https://api.github.com/repos/hjanuschka/fastlane/branches{/branch}","tags_url":"https://api.github.com/repos/hjanuschka/fastlane/tags","blobs_url":"https://api.github.com/repos/hjanuschka/fastlane/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hjanuschka/fastlane/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hjanuschka/fastlane/git/refs{/sha}","trees_url":"https://api.github.com/repos/hjanuschka/fastlane/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hjanuschka/fastlane/statuses/{sha}","languages_url":"https://api.github.com/repos/hjanuschka/fastlane/languages","stargazers_url":"https://api.github.com/repos/hjanuschka/fastlane/stargazers","contributors_url":"https://api.github.com/repos/hjanuschka/fastlane/contributors","subscribers_url":"https://api.github.com/repos/hjanuschka/fastlane/subscribers","subscription_url":"https://api.github.com/repos/hjanuschka/fastlane/subscription","commits_url":"https://api.github.com/repos/hjanuschka/fastlane/commits{/sha}","git_commits_url":"https://api.github.com/repos/hjanuschka/fastlane/git/commits{/sha}","comments_url":"https://api.github.com/repos/hjanuschka/fastlane/comments{/number}","issue_comment_url":"https://api.github.com/repos/hjanuschka/fastlane/issues/comments{/number}","contents_url":"https://api.github.com/repos/hjanuschka/fastlane/contents/{+path}","compare_url":"https://api.github.com/repos/hjanuschka/fastlane/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hjanuschka/fastlane/merges","archive_url":"https://api.github.com/repos/hjanuschka/fastlane/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hjanuschka/fastlane/downloads","issues_url":"https://api.github.com/repos/hjanuschka/fastlane/issues{/number}","pulls_url":"https://api.github.com/repos/hjanuschka/fastlane/pulls{/number}","milestones_url":"https://api.github.com/repos/hjanuschka/fastlane/milestones{/number}","notifications_url":"https://api.github.com/repos/hjanuschka/fastlane/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hjanuschka/fastlane/labels{/name}","releases_url":"https://api.github.com/repos/hjanuschka/fastlane/releases{/id}","deployments_url":"https://api.github.com/repos/hjanuschka/fastlane/deployments","created_at":"2016-03-16T08:46:49Z","updated_at":"2016-03-16T08:46:53Z","pushed_at":"2016-12-13T21:05:25Z","git_url":"git://github.com/hjanuschka/fastlane.git","ssh_url":"git@github.com:hjanuschka/fastlane.git","clone_url":"https://github.com/hjanuschka/fastlane.git","svn_url":"https://github.com/hjanuschka/fastlane","homepage":"https://fastlane.tools","size":53643,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fastlane:master","ref":"master","sha":"ed5ce02f853dc7d892d8382ada4e795651d83fdd","user":{"login":"fastlane","id":11098337,"avatar_url":"https://avatars.githubusercontent.com/u/11098337?v=3","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"repo":{"id":27442967,"name":"fastlane","full_name":"fastlane/fastlane","owner":{"login":"fastlane","id":11098337,"avatar_url":"https://avatars.githubusercontent.com/u/11098337?v=3","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fastlane/fastlane","description":"🚀 The easiest way to automate building and releasing your iOS and Android apps","fork":false,"url":"https://api.github.com/repos/fastlane/fastlane","forks_url":"https://api.github.com/repos/fastlane/fastlane/forks","keys_url":"https://api.github.com/repos/fastlane/fastlane/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fastlane/fastlane/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fastlane/fastlane/teams","hooks_url":"https://api.github.com/repos/fastlane/fastlane/hooks","issue_events_url":"https://api.github.com/repos/fastlane/fastlane/issues/events{/number}","events_url":"https://api.github.com/repos/fastlane/fastlane/events","assignees_url":"https://api.github.com/repos/fastlane/fastlane/assignees{/user}","branches_url":"https://api.github.com/repos/fastlane/fastlane/branches{/branch}","tags_url":"https://api.github.com/repos/fastlane/fastlane/tags","blobs_url":"https://api.github.com/repos/fastlane/fastlane/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fastlane/fastlane/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fastlane/fastlane/git/refs{/sha}","trees_url":"https://api.github.com/repos/fastlane/fastlane/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fastlane/fastlane/statuses/{sha}","languages_url":"https://api.github.com/repos/fastlane/fastlane/languages","stargazers_url":"https://api.github.com/repos/fastlane/fastlane/stargazers","contributors_url":"https://api.github.com/repos/fastlane/fastlane/contributors","subscribers_url":"https://api.github.com/repos/fastlane/fastlane/subscribers","subscription_url":"https://api.github.com/repos/fastlane/fastlane/subscription","commits_url":"https://api.github.com/repos/fastlane/fastlane/commits{/sha}","git_commits_url":"https://api.github.com/repos/fastlane/fastlane/git/commits{/sha}","comments_url":"https://api.github.com/repos/fastlane/fastlane/comments{/number}","issue_comment_url":"https://api.github.com/repos/fastlane/fastlane/issues/comments{/number}","contents_url":"https://api.github.com/repos/fastlane/fastlane/contents/{+path}","compare_url":"https://api.github.com/repos/fastlane/fastlane/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fastlane/fastlane/merges","archive_url":"https://api.github.com/repos/fastlane/fastlane/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fastlane/fastlane/downloads","issues_url":"https://api.github.com/repos/fastlane/fastlane/issues{/number}","pulls_url":"https://api.github.com/repos/fastlane/fastlane/pulls{/number}","milestones_url":"https://api.github.com/repos/fastlane/fastlane/milestones{/number}","notifications_url":"https://api.github.com/repos/fastlane/fastlane/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fastlane/fastlane/labels{/name}","releases_url":"https://api.github.com/repos/fastlane/fastlane/releases{/id}","deployments_url":"https://api.github.com/repos/fastlane/fastlane/deployments","created_at":"2014-12-02T17:00:38Z","updated_at":"2016-12-14T00:49:55Z","pushed_at":"2016-12-14T00:36:13Z","git_url":"git://github.com/fastlane/fastlane.git","ssh_url":"git@github.com:fastlane/fastlane.git","clone_url":"https://github.com/fastlane/fastlane.git","svn_url":"https://github.com/fastlane/fastlane","homepage":"https://fastlane.tools","size":54084,"stargazers_count":12822,"watchers_count":12822,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1925,"mirror_url":null,"open_issues_count":410,"forks":1925,"open_issues":410,"watchers":12822,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/7398"},"html":{"href":"https://github.com/fastlane/fastlane/pull/7398"},"issue":{"href":"https://api.github.com/repos/fastlane/fastlane/issues/7398"},"comments":{"href":"https://api.github.com/repos/fastlane/fastlane/issues/7398/comments"},"review_comments":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/7398/comments"},"review_comment":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/7398/commits"},"statuses":{"href":"https://api.github.com/repos/fastlane/fastlane/statuses/bb96ffc4d4c6199c6558c37732b5700da9f67e34"}}}}
{"actor":{"display_login":"KrauseFx"}}