{"action":"created","issue":{"url":"https://api.github.com/repos/libgit2/libgit2sharp/issues/1298","repository_url":"https://api.github.com/repos/libgit2/libgit2sharp","labels_url":"https://api.github.com/repos/libgit2/libgit2sharp/issues/1298/labels{/name}","comments_url":"https://api.github.com/repos/libgit2/libgit2sharp/issues/1298/comments","events_url":"https://api.github.com/repos/libgit2/libgit2sharp/issues/1298/events","html_url":"https://github.com/libgit2/libgit2sharp/pull/1298","id":145416469,"number":1298,"title":"Update libgit2","user":{"login":"ethomson","id":1130014,"avatar_url":"https://avatars.githubusercontent.com/u/1130014?v=3","gravatar_id":"","url":"https://api.github.com/users/ethomson","html_url":"https://github.com/ethomson","followers_url":"https://api.github.com/users/ethomson/followers","following_url":"https://api.github.com/users/ethomson/following{/other_user}","gists_url":"https://api.github.com/users/ethomson/gists{/gist_id}","starred_url":"https://api.github.com/users/ethomson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethomson/subscriptions","organizations_url":"https://api.github.com/users/ethomson/orgs","repos_url":"https://api.github.com/users/ethomson/repos","events_url":"https://api.github.com/users/ethomson/events{/privacy}","received_events_url":"https://api.github.com/users/ethomson/received_events","type":"User","site_admin":true},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":17,"created_at":"2016-04-02T20:49:06Z","updated_at":"2016-04-13T21:42:48Z","closed_at":"2016-04-12T17:47:30Z","pull_request":{"url":"https://api.github.com/repos/libgit2/libgit2sharp/pulls/1298","html_url":"https://github.com/libgit2/libgit2sharp/pull/1298","diff_url":"https://github.com/libgit2/libgit2sharp/pull/1298.diff","patch_url":"https://github.com/libgit2/libgit2sharp/pull/1298.patch"},"body":"This depends on https://github.com/libgit2/libgit2/pull/3724, as we were bombing one of the submodule status tests when [looking for a submodule named `sm_changed_head/` with a trailing slash](https://github.com/libgit2/libgit2sharp/blob/master/LibGit2Sharp.Tests/SubmoduleFixture.cs#L137).  (Sigh.)\r\n\r\nThis uses the fancy new LibGit2Sharp.NativeBinaries where the native binaries now live in `lib` instead of `NativeBinaries`.  That means that this _should_ fix #1170.  So please argue if you think this is a terrible idea.\r\n\r\nOtherwise, once https://github.com/libgit2/libgit2/pull/3724 is merged, I will reroll a new LibGit2Sharp.NativeBinaries nuget package and update this to use that."},"comment":{"url":"https://api.github.com/repos/libgit2/libgit2sharp/issues/comments/209660704","html_url":"https://github.com/libgit2/libgit2sharp/pull/1298#issuecomment-209660704","issue_url":"https://api.github.com/repos/libgit2/libgit2sharp/issues/1298","id":209660704,"user":{"login":"asbjornu","id":12283,"avatar_url":"https://avatars.githubusercontent.com/u/12283?v=3","gravatar_id":"","url":"https://api.github.com/users/asbjornu","html_url":"https://github.com/asbjornu","followers_url":"https://api.github.com/users/asbjornu/followers","following_url":"https://api.github.com/users/asbjornu/following{/other_user}","gists_url":"https://api.github.com/users/asbjornu/gists{/gist_id}","starred_url":"https://api.github.com/users/asbjornu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asbjornu/subscriptions","organizations_url":"https://api.github.com/users/asbjornu/orgs","repos_url":"https://api.github.com/users/asbjornu/repos","events_url":"https://api.github.com/users/asbjornu/events{/privacy}","received_events_url":"https://api.github.com/users/asbjornu/received_events","type":"User","site_admin":false},"created_at":"2016-04-13T21:42:47Z","updated_at":"2016-04-13T21:42:47Z","body":"@bording That's weird, because all the references in `packages.config` and `.csproj` files are pointing to the `0.23.0-dev00000000000000` version. I've now removed the old packages and when running the tests again, they fail with this:\r\n\r\n```csharp\r\nSystem.TypeInitializationException : The type initializer for 'LibGit2Sharp.Core.NativeMethods' threw an exception.\r\n  ----> System.DllNotFoundException : git2-381caf5\r\n   at LibGit2Sharp.Core.Proxy.git_repository_init_ext (LibGit2Sharp.Core.FilePath workdirPath, LibGit2Sharp.Core.FilePath gitdirPath, Boolean isBare) in <filename unknown>:line 0\r\n   at LibGit2Sharp.Repository.Init (System.String path, Boolean isBare) in <filename unknown>:line 0\r\n   at LibGit2Sharp.Repository.Init (System.String path) in <filename unknown>:line 0\r\n   at GitTools.Testing.EmptyRepositoryFixture.CreateNewRepository (System.String path) in <filename unknown>:line 0\r\n   at GitTools.Testing.RepositoryFixtureBase..ctor (System.Func`2 repoBuilder) in <filename unknown>:line 0\r\n   at GitTools.Testing.EmptyRepositoryFixture..ctor () in <filename unknown>:line 0\r\n   at PullRequestInTeamCityTest.GivenARemoteWithATagOnMaster_AndAPullRequestWithTwoCommits_AndBuildIsRunningInTeamCity_VersionIsCalculatedProperly (System.String pullRequestRef) in <filename unknown>:line 0\r\n   at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (System.Reflection.MonoMethod,object,object[],System.Exception&)\r\n   at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) in <filename unknown>:line 0\r\n--DllNotFoundException\r\n   at (wrapper managed-to-native) LibGit2Sharp.Core.NativeMethods:git_libgit2_init ()\r\n   at LibGit2Sharp.Core.NativeMethods+LibraryLifetimeObject..ctor () in <filename unknown>:line 0\r\n   at LibGit2Sharp.Core.NativeMethods..cctor () in <filename unknown>:line 0\r\n```\r\n\r\nSeems like `git2-381caf5` is the name of the Windows `.dll`, so it's now looking for the incorrect native binary?"}}