{"action":"closed","number":38,"pull_request":{"url":"https://api.github.com/repos/yohcop/openid-go/pulls/38","id":60100081,"html_url":"https://github.com/yohcop/openid-go/pull/38","diff_url":"https://github.com/yohcop/openid-go/pull/38.diff","patch_url":"https://github.com/yohcop/openid-go/pull/38.patch","issue_url":"https://api.github.com/repos/yohcop/openid-go/issues/38","number":38,"state":"closed","locked":false,"title":"Don't override discovered ids with identifier_select URLs","user":{"login":"xStrom","id":754881,"avatar_url":"https://avatars.githubusercontent.com/u/754881?v=3","gravatar_id":"","url":"https://api.github.com/users/xStrom","html_url":"https://github.com/xStrom","followers_url":"https://api.github.com/users/xStrom/followers","following_url":"https://api.github.com/users/xStrom/following{/other_user}","gists_url":"https://api.github.com/users/xStrom/gists{/gist_id}","starred_url":"https://api.github.com/users/xStrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xStrom/subscriptions","organizations_url":"https://api.github.com/users/xStrom/orgs","repos_url":"https://api.github.com/users/xStrom/repos","events_url":"https://api.github.com/users/xStrom/events{/privacy}","received_events_url":"https://api.github.com/users/xStrom/received_events","type":"User","site_admin":false},"body":"The [OpenID 2.0 spec point 7.3.1](http://openid.net/specs/openid-authentication-2_0.html#discovery) states that *For the purposes of making OpenID Authentication requests, the value \"http://specs.openid.net/auth/2.0/identifier_select\" MUST be used as both the Claimed Identifier and the OP-Local Identifier when an OP Identifier is entered*.\r\n\r\nThis authentication request is being built in the `buildRedirectURL` function in the `redirect.go` file. The `identifier_select` URL is assigned there as needed. The `discover` function does not need to return this.","created_at":"2016-02-21T19:23:10Z","updated_at":"2016-03-04T16:36:54Z","closed_at":"2016-03-04T16:36:54Z","merged_at":"2016-03-04T16:36:54Z","merge_commit_sha":"4fef87a2279a3cfbf84d0bb4eac3ac711165d40d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yohcop/openid-go/pulls/38/commits","review_comments_url":"https://api.github.com/repos/yohcop/openid-go/pulls/38/comments","review_comment_url":"https://api.github.com/repos/yohcop/openid-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yohcop/openid-go/issues/38/comments","statuses_url":"https://api.github.com/repos/yohcop/openid-go/statuses/ceb53d317b1e975eeb1e42a9eea8c395d6391613","head":{"label":"xStrom:discoresult","ref":"discoresult","sha":"ceb53d317b1e975eeb1e42a9eea8c395d6391613","user":{"login":"xStrom","id":754881,"avatar_url":"https://avatars.githubusercontent.com/u/754881?v=3","gravatar_id":"","url":"https://api.github.com/users/xStrom","html_url":"https://github.com/xStrom","followers_url":"https://api.github.com/users/xStrom/followers","following_url":"https://api.github.com/users/xStrom/following{/other_user}","gists_url":"https://api.github.com/users/xStrom/gists{/gist_id}","starred_url":"https://api.github.com/users/xStrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xStrom/subscriptions","organizations_url":"https://api.github.com/users/xStrom/orgs","repos_url":"https://api.github.com/users/xStrom/repos","events_url":"https://api.github.com/users/xStrom/events{/privacy}","received_events_url":"https://api.github.com/users/xStrom/received_events","type":"User","site_admin":false},"repo":{"id":49795449,"name":"openid-go","full_name":"xStrom/openid-go","owner":{"login":"xStrom","id":754881,"avatar_url":"https://avatars.githubusercontent.com/u/754881?v=3","gravatar_id":"","url":"https://api.github.com/users/xStrom","html_url":"https://github.com/xStrom","followers_url":"https://api.github.com/users/xStrom/followers","following_url":"https://api.github.com/users/xStrom/following{/other_user}","gists_url":"https://api.github.com/users/xStrom/gists{/gist_id}","starred_url":"https://api.github.com/users/xStrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xStrom/subscriptions","organizations_url":"https://api.github.com/users/xStrom/orgs","repos_url":"https://api.github.com/users/xStrom/repos","events_url":"https://api.github.com/users/xStrom/events{/privacy}","received_events_url":"https://api.github.com/users/xStrom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xStrom/openid-go","description":"OpenID consumer implementation in Go - golang","fork":true,"url":"https://api.github.com/repos/xStrom/openid-go","forks_url":"https://api.github.com/repos/xStrom/openid-go/forks","keys_url":"https://api.github.com/repos/xStrom/openid-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xStrom/openid-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xStrom/openid-go/teams","hooks_url":"https://api.github.com/repos/xStrom/openid-go/hooks","issue_events_url":"https://api.github.com/repos/xStrom/openid-go/issues/events{/number}","events_url":"https://api.github.com/repos/xStrom/openid-go/events","assignees_url":"https://api.github.com/repos/xStrom/openid-go/assignees{/user}","branches_url":"https://api.github.com/repos/xStrom/openid-go/branches{/branch}","tags_url":"https://api.github.com/repos/xStrom/openid-go/tags","blobs_url":"https://api.github.com/repos/xStrom/openid-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xStrom/openid-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xStrom/openid-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/xStrom/openid-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xStrom/openid-go/statuses/{sha}","languages_url":"https://api.github.com/repos/xStrom/openid-go/languages","stargazers_url":"https://api.github.com/repos/xStrom/openid-go/stargazers","contributors_url":"https://api.github.com/repos/xStrom/openid-go/contributors","subscribers_url":"https://api.github.com/repos/xStrom/openid-go/subscribers","subscription_url":"https://api.github.com/repos/xStrom/openid-go/subscription","commits_url":"https://api.github.com/repos/xStrom/openid-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/xStrom/openid-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/xStrom/openid-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/xStrom/openid-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/xStrom/openid-go/contents/{+path}","compare_url":"https://api.github.com/repos/xStrom/openid-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xStrom/openid-go/merges","archive_url":"https://api.github.com/repos/xStrom/openid-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xStrom/openid-go/downloads","issues_url":"https://api.github.com/repos/xStrom/openid-go/issues{/number}","pulls_url":"https://api.github.com/repos/xStrom/openid-go/pulls{/number}","milestones_url":"https://api.github.com/repos/xStrom/openid-go/milestones{/number}","notifications_url":"https://api.github.com/repos/xStrom/openid-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xStrom/openid-go/labels{/name}","releases_url":"https://api.github.com/repos/xStrom/openid-go/releases{/id}","deployments_url":"https://api.github.com/repos/xStrom/openid-go/deployments","created_at":"2016-01-16T23:34:05Z","updated_at":"2016-01-16T23:34:06Z","pushed_at":"2016-02-21T19:14:44Z","git_url":"git://github.com/xStrom/openid-go.git","ssh_url":"git@github.com:xStrom/openid-go.git","clone_url":"https://github.com/xStrom/openid-go.git","svn_url":"https://github.com/xStrom/openid-go","homepage":"","size":76,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yohcop:master","ref":"master","sha":"804fd15d29539e137dd9add94a62c1e2f85b4107","user":{"login":"yohcop","id":455541,"avatar_url":"https://avatars.githubusercontent.com/u/455541?v=3","gravatar_id":"","url":"https://api.github.com/users/yohcop","html_url":"https://github.com/yohcop","followers_url":"https://api.github.com/users/yohcop/followers","following_url":"https://api.github.com/users/yohcop/following{/other_user}","gists_url":"https://api.github.com/users/yohcop/gists{/gist_id}","starred_url":"https://api.github.com/users/yohcop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yohcop/subscriptions","organizations_url":"https://api.github.com/users/yohcop/orgs","repos_url":"https://api.github.com/users/yohcop/repos","events_url":"https://api.github.com/users/yohcop/events{/privacy}","received_events_url":"https://api.github.com/users/yohcop/received_events","type":"User","site_admin":false},"repo":{"id":1472997,"name":"openid-go","full_name":"yohcop/openid-go","owner":{"login":"yohcop","id":455541,"avatar_url":"https://avatars.githubusercontent.com/u/455541?v=3","gravatar_id":"","url":"https://api.github.com/users/yohcop","html_url":"https://github.com/yohcop","followers_url":"https://api.github.com/users/yohcop/followers","following_url":"https://api.github.com/users/yohcop/following{/other_user}","gists_url":"https://api.github.com/users/yohcop/gists{/gist_id}","starred_url":"https://api.github.com/users/yohcop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yohcop/subscriptions","organizations_url":"https://api.github.com/users/yohcop/orgs","repos_url":"https://api.github.com/users/yohcop/repos","events_url":"https://api.github.com/users/yohcop/events{/privacy}","received_events_url":"https://api.github.com/users/yohcop/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yohcop/openid-go","description":"OpenID consumer implementation in Go - golang","fork":false,"url":"https://api.github.com/repos/yohcop/openid-go","forks_url":"https://api.github.com/repos/yohcop/openid-go/forks","keys_url":"https://api.github.com/repos/yohcop/openid-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yohcop/openid-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yohcop/openid-go/teams","hooks_url":"https://api.github.com/repos/yohcop/openid-go/hooks","issue_events_url":"https://api.github.com/repos/yohcop/openid-go/issues/events{/number}","events_url":"https://api.github.com/repos/yohcop/openid-go/events","assignees_url":"https://api.github.com/repos/yohcop/openid-go/assignees{/user}","branches_url":"https://api.github.com/repos/yohcop/openid-go/branches{/branch}","tags_url":"https://api.github.com/repos/yohcop/openid-go/tags","blobs_url":"https://api.github.com/repos/yohcop/openid-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yohcop/openid-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yohcop/openid-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/yohcop/openid-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yohcop/openid-go/statuses/{sha}","languages_url":"https://api.github.com/repos/yohcop/openid-go/languages","stargazers_url":"https://api.github.com/repos/yohcop/openid-go/stargazers","contributors_url":"https://api.github.com/repos/yohcop/openid-go/contributors","subscribers_url":"https://api.github.com/repos/yohcop/openid-go/subscribers","subscription_url":"https://api.github.com/repos/yohcop/openid-go/subscription","commits_url":"https://api.github.com/repos/yohcop/openid-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/yohcop/openid-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/yohcop/openid-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/yohcop/openid-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/yohcop/openid-go/contents/{+path}","compare_url":"https://api.github.com/repos/yohcop/openid-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yohcop/openid-go/merges","archive_url":"https://api.github.com/repos/yohcop/openid-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yohcop/openid-go/downloads","issues_url":"https://api.github.com/repos/yohcop/openid-go/issues{/number}","pulls_url":"https://api.github.com/repos/yohcop/openid-go/pulls{/number}","milestones_url":"https://api.github.com/repos/yohcop/openid-go/milestones{/number}","notifications_url":"https://api.github.com/repos/yohcop/openid-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yohcop/openid-go/labels{/name}","releases_url":"https://api.github.com/repos/yohcop/openid-go/releases{/id}","deployments_url":"https://api.github.com/repos/yohcop/openid-go/deployments","created_at":"2011-03-12T23:00:38Z","updated_at":"2016-01-16T23:33:50Z","pushed_at":"2016-03-04T16:36:54Z","git_url":"git://github.com/yohcop/openid-go.git","ssh_url":"git@github.com:yohcop/openid-go.git","clone_url":"https://github.com/yohcop/openid-go.git","svn_url":"https://github.com/yohcop/openid-go","homepage":"","size":79,"stargazers_count":33,"watchers_count":33,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":5,"forks":28,"open_issues":5,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yohcop/openid-go/pulls/38"},"html":{"href":"https://github.com/yohcop/openid-go/pull/38"},"issue":{"href":"https://api.github.com/repos/yohcop/openid-go/issues/38"},"comments":{"href":"https://api.github.com/repos/yohcop/openid-go/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/yohcop/openid-go/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/yohcop/openid-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yohcop/openid-go/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/yohcop/openid-go/statuses/ceb53d317b1e975eeb1e42a9eea8c395d6391613"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"yohcop","id":455541,"avatar_url":"https://avatars.githubusercontent.com/u/455541?v=3","gravatar_id":"","url":"https://api.github.com/users/yohcop","html_url":"https://github.com/yohcop","followers_url":"https://api.github.com/users/yohcop/followers","following_url":"https://api.github.com/users/yohcop/following{/other_user}","gists_url":"https://api.github.com/users/yohcop/gists{/gist_id}","starred_url":"https://api.github.com/users/yohcop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yohcop/subscriptions","organizations_url":"https://api.github.com/users/yohcop/orgs","repos_url":"https://api.github.com/users/yohcop/repos","events_url":"https://api.github.com/users/yohcop/events{/privacy}","received_events_url":"https://api.github.com/users/yohcop/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":8,"deletions":15,"changed_files":3}}