{"action":"created","comment":{"url":"https://api.github.com/repos/ua-eas/kfs/pulls/comments/93787442","pull_request_review_id":14323989,"id":93787442,"diff_hunk":"@@ -0,0 +1,558 @@\n+package edu.arizona.kfs.pdp.batch.service.impl;\r\n+\r\n+import java.sql.Timestamp;\r\n+import java.util.ArrayList;\r\n+import java.util.Collection;\r\n+import java.util.Collections;\r\n+import java.util.Date;\r\n+import java.util.HashMap;\r\n+import java.util.List;\r\n+import java.util.Map;\r\n+import java.util.StringTokenizer;\r\n+\r\n+import org.apache.commons.lang.StringUtils;\r\n+import org.kuali.kfs.coa.businessobject.Account;\r\n+import org.kuali.kfs.coa.service.AccountService;\r\n+import org.kuali.kfs.fp.document.DisbursementVoucherConstants;\r\n+import org.kuali.kfs.pdp.PdpConstants;\r\n+import org.kuali.kfs.pdp.PdpKeyConstants;\r\n+import org.kuali.kfs.pdp.PdpPropertyConstants;\r\n+import org.kuali.kfs.pdp.businessobject.Batch;\r\n+import org.kuali.kfs.pdp.businessobject.CustomerProfile;\r\n+import org.kuali.kfs.pdp.businessobject.PaymentAccountDetail;\r\n+import org.kuali.kfs.pdp.businessobject.PaymentDetail;\r\n+import org.kuali.kfs.pdp.businessobject.PaymentGroup;\r\n+import org.kuali.kfs.pdp.businessobject.PaymentNoteText;\r\n+import org.kuali.kfs.pdp.businessobject.PaymentStatus;\r\n+import org.kuali.kfs.sys.context.SpringContext;\r\n+import org.kuali.kfs.vnd.VendorConstants;\r\n+import org.kuali.kfs.vnd.businessobject.VendorAddress;\r\n+import org.kuali.kfs.vnd.businessobject.VendorDetail;\r\n+import org.kuali.kfs.vnd.businessobject.VendorHeader;\r\n+import org.kuali.kfs.vnd.document.service.VendorService;\r\n+import org.kuali.rice.core.api.datetime.DateTimeService;\r\n+import org.kuali.rice.core.api.util.type.KualiDecimal;\r\n+import org.kuali.rice.core.api.util.type.KualiInteger;\r\n+import org.kuali.rice.coreservice.framework.parameter.ParameterService;\r\n+import org.kuali.rice.krad.service.BusinessObjectService;\r\n+import org.kuali.rice.krad.util.ObjectUtils;\r\n+import org.springframework.transaction.annotation.Transactional;\r\n+\r\n+import edu.arizona.kfs.pdp.batch.service.ShippingInvoiceProcessService;\r\n+import edu.arizona.kfs.pdp.businessobject.ShippingAccount;\r\n+import edu.arizona.kfs.pdp.businessobject.ShippingInvoice;\r\n+import edu.arizona.kfs.pdp.businessobject.ShippingInvoiceTracking;\r\n+import edu.arizona.kfs.pdp.dataaccess.ShippingInvoiceDao;\r\n+import edu.arizona.kfs.sys.KFSConstants;\r\n+import edu.arizona.kfs.sys.KFSParameterKeyConstants;\r\n+\r\n+/**\r\n+ * This is the default implementation of the ShippingInvoiceProcessService interface.\r\n+ * \r\n+ * @see edu.arizona.kfs.pdp.batch.service.ShippingInvoiceProcessService\r\n+ */\r\n+@Transactional\r\n+public class ShippingInvoiceProcessServiceImpl implements ShippingInvoiceProcessService {\r\n+    private static org.apache.log4j.Logger LOG = org.apache.log4j.Logger.getLogger(ShippingInvoiceProcessServiceImpl.class);\r\n+    \r\n+    protected BusinessObjectService businessObjectService;\r\n+    protected ParameterService parameterService;\r\n+    protected DateTimeService dateTimeService;\r\n+    protected AccountService accountService;\r\n+    protected ShippingInvoiceDao shippingInvoiceDao;\r\n+    \r\n+    protected class KFSAccountingInfo {\r","path":"kfs-core/src/main/java/edu/arizona/kfs/pdp/batch/service/impl/ShippingInvoiceProcessServiceImpl.java","position":64,"original_position":64,"commit_id":"a7482b1ec33d850cb90575b5d319ce22b43ce376","original_commit_id":"a7482b1ec33d850cb90575b5d319ce22b43ce376","user":{"login":"heather-lo","id":1987656,"avatar_url":"https://avatars.githubusercontent.com/u/1987656?v=3","gravatar_id":"","url":"https://api.github.com/users/heather-lo","html_url":"https://github.com/heather-lo","followers_url":"https://api.github.com/users/heather-lo/followers","following_url":"https://api.github.com/users/heather-lo/following{/other_user}","gists_url":"https://api.github.com/users/heather-lo/gists{/gist_id}","starred_url":"https://api.github.com/users/heather-lo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heather-lo/subscriptions","organizations_url":"https://api.github.com/users/heather-lo/orgs","repos_url":"https://api.github.com/users/heather-lo/repos","events_url":"https://api.github.com/users/heather-lo/events{/privacy}","received_events_url":"https://api.github.com/users/heather-lo/received_events","type":"User","site_admin":false},"body":"I did some poking around in the KFS 3 code, and it goes back to how we integrated account info with the PaymentDetail object.","created_at":"2016-12-23T17:33:46Z","updated_at":"2016-12-23T17:54:16Z","html_url":"https://github.com/ua-eas/kfs/pull/239#discussion_r93787442","pull_request_url":"https://api.github.com/repos/ua-eas/kfs/pulls/239","_links":{"self":{"href":"https://api.github.com/repos/ua-eas/kfs/pulls/comments/93787442"},"html":{"href":"https://github.com/ua-eas/kfs/pull/239#discussion_r93787442"},"pull_request":{"href":"https://api.github.com/repos/ua-eas/kfs/pulls/239"}}},"pull_request":{"url":"https://api.github.com/repos/ua-eas/kfs/pulls/239","id":99184085,"html_url":"https://github.com/ua-eas/kfs/pull/239","diff_url":"https://github.com/ua-eas/kfs/pull/239.diff","patch_url":"https://github.com/ua-eas/kfs/pull/239.patch","issue_url":"https://api.github.com/repos/ua-eas/kfs/issues/239","number":239,"state":"open","locked":false,"title":"UAF-3283 : MOD-PA3006 Shipping Account Step 3 (Batch) - Code Feature","user":{"login":"jreeseUA","id":18427293,"avatar_url":"https://avatars.githubusercontent.com/u/18427293?v=3","gravatar_id":"","url":"https://api.github.com/users/jreeseUA","html_url":"https://github.com/jreeseUA","followers_url":"https://api.github.com/users/jreeseUA/followers","following_url":"https://api.github.com/users/jreeseUA/following{/other_user}","gists_url":"https://api.github.com/users/jreeseUA/gists{/gist_id}","starred_url":"https://api.github.com/users/jreeseUA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreeseUA/subscriptions","organizations_url":"https://api.github.com/users/jreeseUA/orgs","repos_url":"https://api.github.com/users/jreeseUA/repos","events_url":"https://api.github.com/users/jreeseUA/events{/privacy}","received_events_url":"https://api.github.com/users/jreeseUA/received_events","type":"User","site_admin":false},"body":"UAF-3283 : MOD-PA3006 Shipping Account Step 3 (Batch) - Code Feature.  Modification allows the University of Arizona to process payments to shipping companies on a large scale.","created_at":"2016-12-22T23:11:31Z","updated_at":"2016-12-23T17:54:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fcd811c68214d9d5bd8431d709c5528e4dc01f65","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ua-eas/kfs/pulls/239/commits","review_comments_url":"https://api.github.com/repos/ua-eas/kfs/pulls/239/comments","review_comment_url":"https://api.github.com/repos/ua-eas/kfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ua-eas/kfs/issues/239/comments","statuses_url":"https://api.github.com/repos/ua-eas/kfs/statuses/a7482b1ec33d850cb90575b5d319ce22b43ce376","head":{"label":"ua-eas:UAF-3283","ref":"UAF-3283","sha":"a7482b1ec33d850cb90575b5d319ce22b43ce376","user":{"login":"ua-eas","id":3485494,"avatar_url":"https://avatars.githubusercontent.com/u/3485494?v=3","gravatar_id":"","url":"https://api.github.com/users/ua-eas","html_url":"https://github.com/ua-eas","followers_url":"https://api.github.com/users/ua-eas/followers","following_url":"https://api.github.com/users/ua-eas/following{/other_user}","gists_url":"https://api.github.com/users/ua-eas/gists{/gist_id}","starred_url":"https://api.github.com/users/ua-eas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ua-eas/subscriptions","organizations_url":"https://api.github.com/users/ua-eas/orgs","repos_url":"https://api.github.com/users/ua-eas/repos","events_url":"https://api.github.com/users/ua-eas/events{/privacy}","received_events_url":"https://api.github.com/users/ua-eas/received_events","type":"Organization","site_admin":false},"repo":{"id":39457535,"name":"kfs","full_name":"ua-eas/kfs","owner":{"login":"ua-eas","id":3485494,"avatar_url":"https://avatars.githubusercontent.com/u/3485494?v=3","gravatar_id":"","url":"https://api.github.com/users/ua-eas","html_url":"https://github.com/ua-eas","followers_url":"https://api.github.com/users/ua-eas/followers","following_url":"https://api.github.com/users/ua-eas/following{/other_user}","gists_url":"https://api.github.com/users/ua-eas/gists{/gist_id}","starred_url":"https://api.github.com/users/ua-eas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ua-eas/subscriptions","organizations_url":"https://api.github.com/users/ua-eas/orgs","repos_url":"https://api.github.com/users/ua-eas/repos","events_url":"https://api.github.com/users/ua-eas/events{/privacy}","received_events_url":"https://api.github.com/users/ua-eas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ua-eas/kfs","description":"Kuali Financial System","fork":true,"url":"https://api.github.com/repos/ua-eas/kfs","forks_url":"https://api.github.com/repos/ua-eas/kfs/forks","keys_url":"https://api.github.com/repos/ua-eas/kfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ua-eas/kfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ua-eas/kfs/teams","hooks_url":"https://api.github.com/repos/ua-eas/kfs/hooks","issue_events_url":"https://api.github.com/repos/ua-eas/kfs/issues/events{/number}","events_url":"https://api.github.com/repos/ua-eas/kfs/events","assignees_url":"https://api.github.com/repos/ua-eas/kfs/assignees{/user}","branches_url":"https://api.github.com/repos/ua-eas/kfs/branches{/branch}","tags_url":"https://api.github.com/repos/ua-eas/kfs/tags","blobs_url":"https://api.github.com/repos/ua-eas/kfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ua-eas/kfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ua-eas/kfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ua-eas/kfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ua-eas/kfs/statuses/{sha}","languages_url":"https://api.github.com/repos/ua-eas/kfs/languages","stargazers_url":"https://api.github.com/repos/ua-eas/kfs/stargazers","contributors_url":"https://api.github.com/repos/ua-eas/kfs/contributors","subscribers_url":"https://api.github.com/repos/ua-eas/kfs/subscribers","subscription_url":"https://api.github.com/repos/ua-eas/kfs/subscription","commits_url":"https://api.github.com/repos/ua-eas/kfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ua-eas/kfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ua-eas/kfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ua-eas/kfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ua-eas/kfs/contents/{+path}","compare_url":"https://api.github.com/repos/ua-eas/kfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ua-eas/kfs/merges","archive_url":"https://api.github.com/repos/ua-eas/kfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ua-eas/kfs/downloads","issues_url":"https://api.github.com/repos/ua-eas/kfs/issues{/number}","pulls_url":"https://api.github.com/repos/ua-eas/kfs/pulls{/number}","milestones_url":"https://api.github.com/repos/ua-eas/kfs/milestones{/number}","notifications_url":"https://api.github.com/repos/ua-eas/kfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ua-eas/kfs/labels{/name}","releases_url":"https://api.github.com/repos/ua-eas/kfs/releases{/id}","deployments_url":"https://api.github.com/repos/ua-eas/kfs/deployments","created_at":"2015-07-21T16:41:24Z","updated_at":"2016-10-24T18:28:00Z","pushed_at":"2016-12-23T17:08:56Z","git_url":"git://github.com/ua-eas/kfs.git","ssh_url":"git@github.com:ua-eas/kfs.git","clone_url":"https://github.com/ua-eas/kfs.git","svn_url":"https://github.com/ua-eas/kfs","homepage":null,"size":442477,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":5,"forks":3,"open_issues":5,"watchers":2,"default_branch":"ua-development"}},"base":{"label":"ua-eas:ua-development","ref":"ua-development","sha":"b9a53b6aff8b6650b769156db43dbdef7ea60808","user":{"login":"ua-eas","id":3485494,"avatar_url":"https://avatars.githubusercontent.com/u/3485494?v=3","gravatar_id":"","url":"https://api.github.com/users/ua-eas","html_url":"https://github.com/ua-eas","followers_url":"https://api.github.com/users/ua-eas/followers","following_url":"https://api.github.com/users/ua-eas/following{/other_user}","gists_url":"https://api.github.com/users/ua-eas/gists{/gist_id}","starred_url":"https://api.github.com/users/ua-eas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ua-eas/subscriptions","organizations_url":"https://api.github.com/users/ua-eas/orgs","repos_url":"https://api.github.com/users/ua-eas/repos","events_url":"https://api.github.com/users/ua-eas/events{/privacy}","received_events_url":"https://api.github.com/users/ua-eas/received_events","type":"Organization","site_admin":false},"repo":{"id":39457535,"name":"kfs","full_name":"ua-eas/kfs","owner":{"login":"ua-eas","id":3485494,"avatar_url":"https://avatars.githubusercontent.com/u/3485494?v=3","gravatar_id":"","url":"https://api.github.com/users/ua-eas","html_url":"https://github.com/ua-eas","followers_url":"https://api.github.com/users/ua-eas/followers","following_url":"https://api.github.com/users/ua-eas/following{/other_user}","gists_url":"https://api.github.com/users/ua-eas/gists{/gist_id}","starred_url":"https://api.github.com/users/ua-eas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ua-eas/subscriptions","organizations_url":"https://api.github.com/users/ua-eas/orgs","repos_url":"https://api.github.com/users/ua-eas/repos","events_url":"https://api.github.com/users/ua-eas/events{/privacy}","received_events_url":"https://api.github.com/users/ua-eas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ua-eas/kfs","description":"Kuali Financial System","fork":true,"url":"https://api.github.com/repos/ua-eas/kfs","forks_url":"https://api.github.com/repos/ua-eas/kfs/forks","keys_url":"https://api.github.com/repos/ua-eas/kfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ua-eas/kfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ua-eas/kfs/teams","hooks_url":"https://api.github.com/repos/ua-eas/kfs/hooks","issue_events_url":"https://api.github.com/repos/ua-eas/kfs/issues/events{/number}","events_url":"https://api.github.com/repos/ua-eas/kfs/events","assignees_url":"https://api.github.com/repos/ua-eas/kfs/assignees{/user}","branches_url":"https://api.github.com/repos/ua-eas/kfs/branches{/branch}","tags_url":"https://api.github.com/repos/ua-eas/kfs/tags","blobs_url":"https://api.github.com/repos/ua-eas/kfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ua-eas/kfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ua-eas/kfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ua-eas/kfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ua-eas/kfs/statuses/{sha}","languages_url":"https://api.github.com/repos/ua-eas/kfs/languages","stargazers_url":"https://api.github.com/repos/ua-eas/kfs/stargazers","contributors_url":"https://api.github.com/repos/ua-eas/kfs/contributors","subscribers_url":"https://api.github.com/repos/ua-eas/kfs/subscribers","subscription_url":"https://api.github.com/repos/ua-eas/kfs/subscription","commits_url":"https://api.github.com/repos/ua-eas/kfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ua-eas/kfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ua-eas/kfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ua-eas/kfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ua-eas/kfs/contents/{+path}","compare_url":"https://api.github.com/repos/ua-eas/kfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ua-eas/kfs/merges","archive_url":"https://api.github.com/repos/ua-eas/kfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ua-eas/kfs/downloads","issues_url":"https://api.github.com/repos/ua-eas/kfs/issues{/number}","pulls_url":"https://api.github.com/repos/ua-eas/kfs/pulls{/number}","milestones_url":"https://api.github.com/repos/ua-eas/kfs/milestones{/number}","notifications_url":"https://api.github.com/repos/ua-eas/kfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ua-eas/kfs/labels{/name}","releases_url":"https://api.github.com/repos/ua-eas/kfs/releases{/id}","deployments_url":"https://api.github.com/repos/ua-eas/kfs/deployments","created_at":"2015-07-21T16:41:24Z","updated_at":"2016-10-24T18:28:00Z","pushed_at":"2016-12-23T17:08:56Z","git_url":"git://github.com/ua-eas/kfs.git","ssh_url":"git@github.com:ua-eas/kfs.git","clone_url":"https://github.com/ua-eas/kfs.git","svn_url":"https://github.com/ua-eas/kfs","homepage":null,"size":442477,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":5,"forks":3,"open_issues":5,"watchers":2,"default_branch":"ua-development"}},"_links":{"self":{"href":"https://api.github.com/repos/ua-eas/kfs/pulls/239"},"html":{"href":"https://github.com/ua-eas/kfs/pull/239"},"issue":{"href":"https://api.github.com/repos/ua-eas/kfs/issues/239"},"comments":{"href":"https://api.github.com/repos/ua-eas/kfs/issues/239/comments"},"review_comments":{"href":"https://api.github.com/repos/ua-eas/kfs/pulls/239/comments"},"review_comment":{"href":"https://api.github.com/repos/ua-eas/kfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ua-eas/kfs/pulls/239/commits"},"statuses":{"href":"https://api.github.com/repos/ua-eas/kfs/statuses/a7482b1ec33d850cb90575b5d319ce22b43ce376"}}}}
{"actor":{"display_login":"heather-lo"}}