{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/18987","repository_url":"https://api.github.com/repos/elastic/elasticsearch","labels_url":"https://api.github.com/repos/elastic/elasticsearch/issues/18987/labels{/name}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/18987/comments","events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/18987/events","html_url":"https://github.com/elastic/elasticsearch/pull/18987","id":161327135,"number":18987,"title":"Fix ignore_failure behavior in _simulate?verbose and more cleanup","user":{"login":"talevy","id":388837,"avatar_url":"https://avatars.githubusercontent.com/u/388837?v=3","gravatar_id":"","url":"https://api.github.com/users/talevy","html_url":"https://github.com/talevy","followers_url":"https://api.github.com/users/talevy/followers","following_url":"https://api.github.com/users/talevy/following{/other_user}","gists_url":"https://api.github.com/users/talevy/gists{/gist_id}","starred_url":"https://api.github.com/users/talevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talevy/subscriptions","organizations_url":"https://api.github.com/users/talevy/orgs","repos_url":"https://api.github.com/users/talevy/repos","events_url":"https://api.github.com/users/talevy/events{/privacy}","received_events_url":"https://api.github.com/users/talevy/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/:Ingest","name":":Ingest","color":"009800"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/bug","name":"bug","color":"9e2c2c"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/discuss","name":"discuss","color":"fbca04"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/review","name":"review","color":"0052cc"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/v5.0.0","name":"v5.0.0","color":"dddddd"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-06-21T00:47:57Z","updated_at":"2016-06-21T07:19:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/18987","html_url":"https://github.com/elastic/elasticsearch/pull/18987","diff_url":"https://github.com/elastic/elasticsearch/pull/18987.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/18987.patch"},"body":"- fix it so that processors with the `ignore_failure` option do not\r\nrecord their exception in the response\r\n- add more tests to make empty `on_failure` block behavior more explicit\r\n\r\n🎩  tip to @BigFunger for reporting these issues!"},"comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments/227360047","html_url":"https://github.com/elastic/elasticsearch/pull/18987#issuecomment-227360047","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/18987","id":227360047,"user":{"login":"martijnvg","id":580421,"avatar_url":"https://avatars.githubusercontent.com/u/580421?v=3","gravatar_id":"","url":"https://api.github.com/users/martijnvg","html_url":"https://github.com/martijnvg","followers_url":"https://api.github.com/users/martijnvg/followers","following_url":"https://api.github.com/users/martijnvg/following{/other_user}","gists_url":"https://api.github.com/users/martijnvg/gists{/gist_id}","starred_url":"https://api.github.com/users/martijnvg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martijnvg/subscriptions","organizations_url":"https://api.github.com/users/martijnvg/orgs","repos_url":"https://api.github.com/users/martijnvg/repos","events_url":"https://api.github.com/users/martijnvg/events{/privacy}","received_events_url":"https://api.github.com/users/martijnvg/received_events","type":"User","site_admin":false},"created_at":"2016-06-21T07:19:05Z","updated_at":"2016-06-21T07:19:05Z","body":"> Looks like we missed this bug regarding ignore_failure.\r\n\r\nI completely forgot to check how this setting affects the simulate api, thanks for fixing! \r\n\r\nIn my mind I thought I had this covered, but because of how the tracking processors get decorated\r\nthe tracking processor doesn't know about the ignore flag in the CompoundProcessor.\r\n\r\nI think your fix looks good. Not sure how to do this differently with how currently the processor get decorated.\r\n\r\n> should we reject configurations with empty on_failure blocks?\r\n\r\n+1 I think this makes sense. "}}
{"actor":{"display_login":"martijnvg"}}