{"action":"created","issue":{"url":"https://api.github.com/repos/ripple/rippled/issues/1825","repository_url":"https://api.github.com/repos/ripple/rippled","labels_url":"https://api.github.com/repos/ripple/rippled/issues/1825/labels{/name}","comments_url":"https://api.github.com/repos/ripple/rippled/issues/1825/comments","events_url":"https://api.github.com/repos/ripple/rippled/issues/1825/events","html_url":"https://github.com/ripple/rippled/pull/1825","id":173453421,"number":1825,"title":"Don't include unit test sources in code coverage (RIPD-1132)","user":{"login":"bachase","id":14430,"avatar_url":"https://avatars.githubusercontent.com/u/14430?v=3","gravatar_id":"","url":"https://api.github.com/users/bachase","html_url":"https://github.com/bachase","followers_url":"https://api.github.com/users/bachase/followers","following_url":"https://api.github.com/users/bachase/following{/other_user}","gists_url":"https://api.github.com/users/bachase/gists{/gist_id}","starred_url":"https://api.github.com/users/bachase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bachase/subscriptions","organizations_url":"https://api.github.com/users/bachase/orgs","repos_url":"https://api.github.com/users/bachase/repos","events_url":"https://api.github.com/users/bachase/events{/privacy}","received_events_url":"https://api.github.com/users/bachase/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"mellery451","id":463430,"avatar_url":"https://avatars.githubusercontent.com/u/463430?v=3","gravatar_id":"","url":"https://api.github.com/users/mellery451","html_url":"https://github.com/mellery451","followers_url":"https://api.github.com/users/mellery451/followers","following_url":"https://api.github.com/users/mellery451/following{/other_user}","gists_url":"https://api.github.com/users/mellery451/gists{/gist_id}","starred_url":"https://api.github.com/users/mellery451/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellery451/subscriptions","organizations_url":"https://api.github.com/users/mellery451/orgs","repos_url":"https://api.github.com/users/mellery451/repos","events_url":"https://api.github.com/users/mellery451/events{/privacy}","received_events_url":"https://api.github.com/users/mellery451/received_events","type":"User","site_admin":false},"assignees":[{"login":"mellery451","id":463430,"avatar_url":"https://avatars.githubusercontent.com/u/463430?v=3","gravatar_id":"","url":"https://api.github.com/users/mellery451","html_url":"https://github.com/mellery451","followers_url":"https://api.github.com/users/mellery451/followers","following_url":"https://api.github.com/users/mellery451/following{/other_user}","gists_url":"https://api.github.com/users/mellery451/gists{/gist_id}","starred_url":"https://api.github.com/users/mellery451/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellery451/subscriptions","organizations_url":"https://api.github.com/users/mellery451/orgs","repos_url":"https://api.github.com/users/mellery451/repos","events_url":"https://api.github.com/users/mellery451/events{/privacy}","received_events_url":"https://api.github.com/users/mellery451/received_events","type":"User","site_admin":false}],"milestone":null,"comments":18,"created_at":"2016-08-26T13:30:14Z","updated_at":"2016-08-30T21:43:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ripple/rippled/pulls/1825","html_url":"https://github.com/ripple/rippled/pull/1825","diff_url":"https://github.com/ripple/rippled/pull/1825.diff","patch_url":"https://github.com/ripple/rippled/pull/1825.patch"},"body":"Migrates all unit tests under `src/ripple` to `src/test`.  A unit test is any cpp that has the BEAST_DEFINE_TESTSUITE* macro in it.   This will exclude the unit test implementation from contributing to code coverage.\r\n\r\n* Standardize unit test file names to `foo_test.cpp`\r\n* A handful of tests were in the same cpp as the feature being tested, e.g. `Workers.cpp`.  I broke the test out to a standalone file in these cases.\r\n* A handful of tests were only in the unity builds or excluded from all builds (at least under VS) and are now included in both unity and non-unity. \r\n* There were two `hash_speed_impl_test.cpp` files, but one was not included in any configuration and looked to be an older version of the one that was.  I deleted the old one.\r\n\r\nThings I don't like:\r\n* `src\\unity\\test_unity.cpp` is big and takes a long time to compile.\r\n* I added snappy include directory for all unit test sources in scons and cmake, but only the nodestore tests need them.\r\n* `beast_Zero_test.cpp` caused ADL issues in the unity build.  I changed a namespace to workaround and it is still testing ADL now, but someone with more ADL-fu may have a better solution."},"comment":{"url":"https://api.github.com/repos/ripple/rippled/issues/comments/243590953","html_url":"https://github.com/ripple/rippled/pull/1825#issuecomment-243590953","issue_url":"https://api.github.com/repos/ripple/rippled/issues/1825","id":243590953,"user":{"login":"mellery451","id":463430,"avatar_url":"https://avatars.githubusercontent.com/u/463430?v=3","gravatar_id":"","url":"https://api.github.com/users/mellery451","html_url":"https://github.com/mellery451","followers_url":"https://api.github.com/users/mellery451/followers","following_url":"https://api.github.com/users/mellery451/following{/other_user}","gists_url":"https://api.github.com/users/mellery451/gists{/gist_id}","starred_url":"https://api.github.com/users/mellery451/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellery451/subscriptions","organizations_url":"https://api.github.com/users/mellery451/orgs","repos_url":"https://api.github.com/users/mellery451/repos","events_url":"https://api.github.com/users/mellery451/events{/privacy}","received_events_url":"https://api.github.com/users/mellery451/received_events","type":"User","site_admin":false},"created_at":"2016-08-30T21:43:13Z","updated_at":"2016-08-30T21:43:13Z","body":"👍 "}}
{"actor":{"display_login":"mellery451"}}