{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/69928629","id":69928629,"diff_hunk":"@@ -187,10 +188,9 @@ pushd _thirdpartyhacks\n popd\n export GOPATH=$(pwd)/_build:$(pwd)/_thirdpartyhacks:%{buildroot}%{gopath}:%{gopath}\n # Build all linux components we care about\n-for cmd in oc openshift dockerregistry\n-do\n-        go install -ldflags \"%{ldflags}\" %{import_path}/cmd/${cmd}\n-done\n+go install -ldflags \"%{ldflags}\" %{import_path}/cmd/dockerregistry\n+go install -ldflags \"%{ldflags}\" -tags=gssapi %{import_path}/cmd/openshift\n+go install -ldflags \"%{ldflags}\" -tags=gssapi %{import_path}/cmd/oc\n go test -c -o _build/bin/extended.test -ldflags \"%{ldflags}\" %{import_path}/test/extended","path":"origin.spec","position":19,"original_position":19,"commit_id":"98bfc0f49867dbd846996074ed5d8f6666a6aaa0","original_commit_id":"98bfc0f49867dbd846996074ed5d8f6666a6aaa0","user":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"body":"not yet, because we don't have a kerberos ticket server running. @enj is writing extended tests that will spin up a ticket server and exercise the kerberos auth","created_at":"2016-07-07T15:28:52Z","updated_at":"2016-07-07T15:28:52Z","html_url":"https://github.com/openshift/origin/pull/4566#discussion_r69928629","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/4566","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/69928629"},"html":{"href":"https://github.com/openshift/origin/pull/4566#discussion_r69928629"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/4566"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/4566","id":44390248,"html_url":"https://github.com/openshift/origin/pull/4566","diff_url":"https://github.com/openshift/origin/pull/4566.diff","patch_url":"https://github.com/openshift/origin/pull/4566.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/4566","number":4566,"state":"open","locked":false,"title":"Kerberize oc","user":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"body":"Tasks:\r\n- [x] Add `CompleteChallenge` to challenge handler interface\r\n- [x] Select challenge handler from list of optional handlers\r\n- [x] Implement negotiate handler\r\n- [x] Unit tests\r\n- [x] Enable for linux/darwin\r\n- [x] Build for linux in brew builds\r\n- [x] Include linux in make-release.sh builds\r\n\r\nFollow ups:\r\n- [ ] Build for darwin in brew builds\r\n- [ ] Include darwin in make-release.sh builds\r\n\r\n**Building**\r\n  * To build on linux:\r\n\r\n    ```\r\n    sudo yum install -y krb5-devel\r\n    hack/build-go.sh cmd/oc -tags=gssapi\r\n    ```    \r\n\r\n  * To build on OS X:\r\n\r\n    ```\r\n    brew install homebrew/dupes/heimdal --without-x11\r\n    hack/build-go.sh cmd/oc -tags=gssapi\r\n    ```\r\n\r\n  * To verify that the currently built binary has support enabled:\r\n\r\n    ```\r\n    $ oc version\r\n    ...\r\n    features: Basic-Auth GSSAPI Kerberos SPNEGO\r\n    ```\r\n\r\n**Testing**\r\n\r\nFollowing the instructions at https://github.com/liggitt/auth-proxy/:\r\n* run the liggitt/auth-proxy docker image\r\n* set up your local Kerberos and browser to point `mydomain.com` to the running container\r\n* set an an identity provider like this:\r\n```\r\n  identityProviders:\r\n  - challenge: true\r\n    login: true\r\n    name: header\r\n    provider:\r\n      apiVersion: v1\r\n      challengeURL: \"http://mydomain.com/mod_auth_gssapi_basic/oauth/authorize?${query}\"\r\n      loginURL:     \"http://mydomain.com/mod_auth_gssapi/oauth/authorize?${query}\"\r\n      kind: RequestHeaderIdentityProvider\r\n      headers:\r\n      - Remote-User\r\n```\r\n\r\nWith an active Kerberos ticket (`kinit user1@MYDOMAIN.COM`, `password`):\r\n* Browser is automatically logged in\r\n* `oc login` automatically logs you in\r\n\r\nWithout an active Kerberos ticket (`kdestroy`):\r\n* Browser displays Unauthorized page\r\n* `oc login` falls back to basic auth","created_at":"2015-09-08T03:35:21Z","updated_at":"2016-07-07T15:28:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39716187a67fd7f641eb1d079a8b0a8b2d29d926","assignee":{"login":"sgallagher","id":739555,"avatar_url":"https://avatars.githubusercontent.com/u/739555?v=3","gravatar_id":"","url":"https://api.github.com/users/sgallagher","html_url":"https://github.com/sgallagher","followers_url":"https://api.github.com/users/sgallagher/followers","following_url":"https://api.github.com/users/sgallagher/following{/other_user}","gists_url":"https://api.github.com/users/sgallagher/gists{/gist_id}","starred_url":"https://api.github.com/users/sgallagher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgallagher/subscriptions","organizations_url":"https://api.github.com/users/sgallagher/orgs","repos_url":"https://api.github.com/users/sgallagher/repos","events_url":"https://api.github.com/users/sgallagher/events{/privacy}","received_events_url":"https://api.github.com/users/sgallagher/received_events","type":"User","site_admin":false},"assignees":[{"login":"sgallagher","id":739555,"avatar_url":"https://avatars.githubusercontent.com/u/739555?v=3","gravatar_id":"","url":"https://api.github.com/users/sgallagher","html_url":"https://github.com/sgallagher","followers_url":"https://api.github.com/users/sgallagher/followers","following_url":"https://api.github.com/users/sgallagher/following{/other_user}","gists_url":"https://api.github.com/users/sgallagher/gists{/gist_id}","starred_url":"https://api.github.com/users/sgallagher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgallagher/subscriptions","organizations_url":"https://api.github.com/users/sgallagher/orgs","repos_url":"https://api.github.com/users/sgallagher/repos","events_url":"https://api.github.com/users/sgallagher/events{/privacy}","received_events_url":"https://api.github.com/users/sgallagher/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/4566/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/4566/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/4566/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/98bfc0f49867dbd846996074ed5d8f6666a6aaa0","head":{"label":"liggitt:kerberos","ref":"kerberos","sha":"98bfc0f49867dbd846996074ed5d8f6666a6aaa0","user":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"repo":{"id":23198153,"name":"origin","full_name":"liggitt/origin","owner":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/liggitt/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/liggitt/origin","forks_url":"https://api.github.com/repos/liggitt/origin/forks","keys_url":"https://api.github.com/repos/liggitt/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liggitt/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liggitt/origin/teams","hooks_url":"https://api.github.com/repos/liggitt/origin/hooks","issue_events_url":"https://api.github.com/repos/liggitt/origin/issues/events{/number}","events_url":"https://api.github.com/repos/liggitt/origin/events","assignees_url":"https://api.github.com/repos/liggitt/origin/assignees{/user}","branches_url":"https://api.github.com/repos/liggitt/origin/branches{/branch}","tags_url":"https://api.github.com/repos/liggitt/origin/tags","blobs_url":"https://api.github.com/repos/liggitt/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liggitt/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liggitt/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/liggitt/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liggitt/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/liggitt/origin/languages","stargazers_url":"https://api.github.com/repos/liggitt/origin/stargazers","contributors_url":"https://api.github.com/repos/liggitt/origin/contributors","subscribers_url":"https://api.github.com/repos/liggitt/origin/subscribers","subscription_url":"https://api.github.com/repos/liggitt/origin/subscription","commits_url":"https://api.github.com/repos/liggitt/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/liggitt/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/liggitt/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/liggitt/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/liggitt/origin/contents/{+path}","compare_url":"https://api.github.com/repos/liggitt/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liggitt/origin/merges","archive_url":"https://api.github.com/repos/liggitt/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liggitt/origin/downloads","issues_url":"https://api.github.com/repos/liggitt/origin/issues{/number}","pulls_url":"https://api.github.com/repos/liggitt/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/liggitt/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/liggitt/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liggitt/origin/labels{/name}","releases_url":"https://api.github.com/repos/liggitt/origin/releases{/id}","deployments_url":"https://api.github.com/repos/liggitt/origin/deployments","created_at":"2014-08-21T18:23:05Z","updated_at":"2016-01-11T15:42:07Z","pushed_at":"2016-07-07T04:26:24Z","git_url":"git://github.com/liggitt/origin.git","ssh_url":"git@github.com:liggitt/origin.git","clone_url":"https://github.com/liggitt/origin.git","svn_url":"https://github.com/liggitt/origin","homepage":"https://openshift.github.io","size":298725,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"4173361bc526c7fb355d75715dbfe793721518b2","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"Enterprise-Ready Kubernetes for Developers","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2016-07-07T06:29:39Z","pushed_at":"2016-07-07T15:28:51Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":538669,"stargazers_count":1460,"watchers_count":1460,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":864,"mirror_url":null,"open_issues_count":1062,"forks":864,"open_issues":1062,"watchers":1460,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/4566"},"html":{"href":"https://github.com/openshift/origin/pull/4566"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/4566"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/4566/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/4566/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/4566/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/98bfc0f49867dbd846996074ed5d8f6666a6aaa0"}}}}
{"actor":{"display_login":"liggitt"}}