{"action":"created","comment":{"url":"https://api.github.com/repos/ga4gh/schemas/pulls/comments/70007993","id":70007993,"diff_hunk":"@@ -91,6 +99,52 @@ message GetReadGroupSetRequest {\n   string read_group_set_id = 1;\n }\n \n+// ******************  /readgroups  *********************/\n+\n+// This request maps to the body of `POST /readgroups/search` as JSON.\n+\n+\n+message SearchReadGroupsRequest {\n+  // The dataset to search.\n+  string dataset_id = 1;\n+  \n+  // Only return readgroups within the provided read group set ID.\n+  string read_group_set_id = 2;\n+\n+  // Only return read groups with this name (case-sensitive, exact match).\n+  string name = 3;\n+\n+  //  Specifying the id of a BioSample record will return only readgroups\n+  //  with the given bioSampleId.\n+  string bio_sample_id = 4;","path":"src/main/proto/ga4gh/read_service.proto","position":60,"original_position":60,"commit_id":"fa3162c068b6fc22c920502d526b2e482ab5f546","original_commit_id":"fa3162c068b6fc22c920502d526b2e482ab5f546","user":{"login":"calbach","id":822298,"avatar_url":"https://avatars.githubusercontent.com/u/822298?v=3","gravatar_id":"","url":"https://api.github.com/users/calbach","html_url":"https://github.com/calbach","followers_url":"https://api.github.com/users/calbach/followers","following_url":"https://api.github.com/users/calbach/following{/other_user}","gists_url":"https://api.github.com/users/calbach/gists{/gist_id}","starred_url":"https://api.github.com/users/calbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calbach/subscriptions","organizations_url":"https://api.github.com/users/calbach/orgs","repos_url":"https://api.github.com/users/calbach/repos","events_url":"https://api.github.com/users/calbach/events{/privacy}","received_events_url":"https://api.github.com/users/calbach/received_events","type":"User","site_admin":false},"body":"Is there background on why bio_sample_id is per-`ReadGroup` and not per-`ReadGroupSet`? I don't see any discussion of this on the original PR. I would have thought the latter would be more natural (and would side-step this PR).","created_at":"2016-07-07T23:57:49Z","updated_at":"2016-07-07T23:57:49Z","html_url":"https://github.com/ga4gh/schemas/pull/652#discussion_r70007993","pull_request_url":"https://api.github.com/repos/ga4gh/schemas/pulls/652","_links":{"self":{"href":"https://api.github.com/repos/ga4gh/schemas/pulls/comments/70007993"},"html":{"href":"https://github.com/ga4gh/schemas/pull/652#discussion_r70007993"},"pull_request":{"href":"https://api.github.com/repos/ga4gh/schemas/pulls/652"}}},"pull_request":{"url":"https://api.github.com/repos/ga4gh/schemas/pulls/652","id":76660419,"html_url":"https://github.com/ga4gh/schemas/pull/652","diff_url":"https://github.com/ga4gh/schemas/pull/652.diff","patch_url":"https://github.com/ga4gh/schemas/pull/652.patch","issue_url":"https://api.github.com/repos/ga4gh/schemas/issues/652","number":652,"state":"open","locked":false,"title":"Readgroups Endpoint","user":{"login":"david4096","id":3795586,"avatar_url":"https://avatars.githubusercontent.com/u/3795586?v=3","gravatar_id":"","url":"https://api.github.com/users/david4096","html_url":"https://github.com/david4096","followers_url":"https://api.github.com/users/david4096/followers","following_url":"https://api.github.com/users/david4096/following{/other_user}","gists_url":"https://api.github.com/users/david4096/gists{/gist_id}","starred_url":"https://api.github.com/users/david4096/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david4096/subscriptions","organizations_url":"https://api.github.com/users/david4096/orgs","repos_url":"https://api.github.com/users/david4096/repos","events_url":"https://api.github.com/users/david4096/events{/privacy}","received_events_url":"https://api.github.com/users/david4096/received_events","type":"User","site_admin":false},"body":"The access patterns for the reads API would be improved by adding a read groups endpoint (#650). Currently the readgroupset endpoint returns a repeated list of readgroups matching the search criteria. This is confusing because the readgroupset record is modified at query time.\r\n\r\nThis PR adds the `/readgroups/search` endpoint, which exposes the available read groups using familiar strict matching on name, `bio_sample_id`, `dataset_id`, and `read_group_set_id`. Read group set messages no longer contain the list of readgroups since they can be retrieved using `readgroups/<read_group_id>`. This simplifies the read group set endpoint by moving the `bio_sample_id` filter to the appropriate entity, `ReadGroup`, as a single read group set might contain reads for many samples.","created_at":"2016-07-07T20:33:15Z","updated_at":"2016-07-07T23:57:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f199d76611ad3c45b97eb949e3e9559253eb629","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ga4gh/schemas/pulls/652/commits","review_comments_url":"https://api.github.com/repos/ga4gh/schemas/pulls/652/comments","review_comment_url":"https://api.github.com/repos/ga4gh/schemas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ga4gh/schemas/issues/652/comments","statuses_url":"https://api.github.com/repos/ga4gh/schemas/statuses/fa3162c068b6fc22c920502d526b2e482ab5f546","head":{"label":"david4096:readgroups","ref":"readgroups","sha":"fa3162c068b6fc22c920502d526b2e482ab5f546","user":{"login":"david4096","id":3795586,"avatar_url":"https://avatars.githubusercontent.com/u/3795586?v=3","gravatar_id":"","url":"https://api.github.com/users/david4096","html_url":"https://github.com/david4096","followers_url":"https://api.github.com/users/david4096/followers","following_url":"https://api.github.com/users/david4096/following{/other_user}","gists_url":"https://api.github.com/users/david4096/gists{/gist_id}","starred_url":"https://api.github.com/users/david4096/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david4096/subscriptions","organizations_url":"https://api.github.com/users/david4096/orgs","repos_url":"https://api.github.com/users/david4096/repos","events_url":"https://api.github.com/users/david4096/events{/privacy}","received_events_url":"https://api.github.com/users/david4096/received_events","type":"User","site_admin":false},"repo":{"id":47650483,"name":"schemas","full_name":"david4096/schemas","owner":{"login":"david4096","id":3795586,"avatar_url":"https://avatars.githubusercontent.com/u/3795586?v=3","gravatar_id":"","url":"https://api.github.com/users/david4096","html_url":"https://github.com/david4096","followers_url":"https://api.github.com/users/david4096/followers","following_url":"https://api.github.com/users/david4096/following{/other_user}","gists_url":"https://api.github.com/users/david4096/gists{/gist_id}","starred_url":"https://api.github.com/users/david4096/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david4096/subscriptions","organizations_url":"https://api.github.com/users/david4096/orgs","repos_url":"https://api.github.com/users/david4096/repos","events_url":"https://api.github.com/users/david4096/events{/privacy}","received_events_url":"https://api.github.com/users/david4096/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/david4096/schemas","description":"Work on data models and APIs for Genomic data.","fork":true,"url":"https://api.github.com/repos/david4096/schemas","forks_url":"https://api.github.com/repos/david4096/schemas/forks","keys_url":"https://api.github.com/repos/david4096/schemas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/david4096/schemas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/david4096/schemas/teams","hooks_url":"https://api.github.com/repos/david4096/schemas/hooks","issue_events_url":"https://api.github.com/repos/david4096/schemas/issues/events{/number}","events_url":"https://api.github.com/repos/david4096/schemas/events","assignees_url":"https://api.github.com/repos/david4096/schemas/assignees{/user}","branches_url":"https://api.github.com/repos/david4096/schemas/branches{/branch}","tags_url":"https://api.github.com/repos/david4096/schemas/tags","blobs_url":"https://api.github.com/repos/david4096/schemas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/david4096/schemas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/david4096/schemas/git/refs{/sha}","trees_url":"https://api.github.com/repos/david4096/schemas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/david4096/schemas/statuses/{sha}","languages_url":"https://api.github.com/repos/david4096/schemas/languages","stargazers_url":"https://api.github.com/repos/david4096/schemas/stargazers","contributors_url":"https://api.github.com/repos/david4096/schemas/contributors","subscribers_url":"https://api.github.com/repos/david4096/schemas/subscribers","subscription_url":"https://api.github.com/repos/david4096/schemas/subscription","commits_url":"https://api.github.com/repos/david4096/schemas/commits{/sha}","git_commits_url":"https://api.github.com/repos/david4096/schemas/git/commits{/sha}","comments_url":"https://api.github.com/repos/david4096/schemas/comments{/number}","issue_comment_url":"https://api.github.com/repos/david4096/schemas/issues/comments{/number}","contents_url":"https://api.github.com/repos/david4096/schemas/contents/{+path}","compare_url":"https://api.github.com/repos/david4096/schemas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/david4096/schemas/merges","archive_url":"https://api.github.com/repos/david4096/schemas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/david4096/schemas/downloads","issues_url":"https://api.github.com/repos/david4096/schemas/issues{/number}","pulls_url":"https://api.github.com/repos/david4096/schemas/pulls{/number}","milestones_url":"https://api.github.com/repos/david4096/schemas/milestones{/number}","notifications_url":"https://api.github.com/repos/david4096/schemas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/david4096/schemas/labels{/name}","releases_url":"https://api.github.com/repos/david4096/schemas/releases{/id}","deployments_url":"https://api.github.com/repos/david4096/schemas/deployments","created_at":"2015-12-08T21:26:20Z","updated_at":"2016-06-16T21:43:03Z","pushed_at":"2016-07-07T23:57:01Z","git_url":"git://github.com/david4096/schemas.git","ssh_url":"git@github.com:david4096/schemas.git","clone_url":"https://github.com/david4096/schemas.git","svn_url":"https://github.com/david4096/schemas","homepage":"http://ga4gh.org/#/api","size":1917,"stargazers_count":0,"watchers_count":0,"language":"Protocol Buffer","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ga4gh:master","ref":"master","sha":"48b0ce91db0ff1458736b86221d243ed430838d6","user":{"login":"ga4gh","id":6921777,"avatar_url":"https://avatars.githubusercontent.com/u/6921777?v=3","gravatar_id":"","url":"https://api.github.com/users/ga4gh","html_url":"https://github.com/ga4gh","followers_url":"https://api.github.com/users/ga4gh/followers","following_url":"https://api.github.com/users/ga4gh/following{/other_user}","gists_url":"https://api.github.com/users/ga4gh/gists{/gist_id}","starred_url":"https://api.github.com/users/ga4gh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ga4gh/subscriptions","organizations_url":"https://api.github.com/users/ga4gh/orgs","repos_url":"https://api.github.com/users/ga4gh/repos","events_url":"https://api.github.com/users/ga4gh/events{/privacy}","received_events_url":"https://api.github.com/users/ga4gh/received_events","type":"Organization","site_admin":false},"repo":{"id":17925227,"name":"schemas","full_name":"ga4gh/schemas","owner":{"login":"ga4gh","id":6921777,"avatar_url":"https://avatars.githubusercontent.com/u/6921777?v=3","gravatar_id":"","url":"https://api.github.com/users/ga4gh","html_url":"https://github.com/ga4gh","followers_url":"https://api.github.com/users/ga4gh/followers","following_url":"https://api.github.com/users/ga4gh/following{/other_user}","gists_url":"https://api.github.com/users/ga4gh/gists{/gist_id}","starred_url":"https://api.github.com/users/ga4gh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ga4gh/subscriptions","organizations_url":"https://api.github.com/users/ga4gh/orgs","repos_url":"https://api.github.com/users/ga4gh/repos","events_url":"https://api.github.com/users/ga4gh/events{/privacy}","received_events_url":"https://api.github.com/users/ga4gh/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ga4gh/schemas","description":"Work on data models and APIs for Genomic data.","fork":false,"url":"https://api.github.com/repos/ga4gh/schemas","forks_url":"https://api.github.com/repos/ga4gh/schemas/forks","keys_url":"https://api.github.com/repos/ga4gh/schemas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ga4gh/schemas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ga4gh/schemas/teams","hooks_url":"https://api.github.com/repos/ga4gh/schemas/hooks","issue_events_url":"https://api.github.com/repos/ga4gh/schemas/issues/events{/number}","events_url":"https://api.github.com/repos/ga4gh/schemas/events","assignees_url":"https://api.github.com/repos/ga4gh/schemas/assignees{/user}","branches_url":"https://api.github.com/repos/ga4gh/schemas/branches{/branch}","tags_url":"https://api.github.com/repos/ga4gh/schemas/tags","blobs_url":"https://api.github.com/repos/ga4gh/schemas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ga4gh/schemas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ga4gh/schemas/git/refs{/sha}","trees_url":"https://api.github.com/repos/ga4gh/schemas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ga4gh/schemas/statuses/{sha}","languages_url":"https://api.github.com/repos/ga4gh/schemas/languages","stargazers_url":"https://api.github.com/repos/ga4gh/schemas/stargazers","contributors_url":"https://api.github.com/repos/ga4gh/schemas/contributors","subscribers_url":"https://api.github.com/repos/ga4gh/schemas/subscribers","subscription_url":"https://api.github.com/repos/ga4gh/schemas/subscription","commits_url":"https://api.github.com/repos/ga4gh/schemas/commits{/sha}","git_commits_url":"https://api.github.com/repos/ga4gh/schemas/git/commits{/sha}","comments_url":"https://api.github.com/repos/ga4gh/schemas/comments{/number}","issue_comment_url":"https://api.github.com/repos/ga4gh/schemas/issues/comments{/number}","contents_url":"https://api.github.com/repos/ga4gh/schemas/contents/{+path}","compare_url":"https://api.github.com/repos/ga4gh/schemas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ga4gh/schemas/merges","archive_url":"https://api.github.com/repos/ga4gh/schemas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ga4gh/schemas/downloads","issues_url":"https://api.github.com/repos/ga4gh/schemas/issues{/number}","pulls_url":"https://api.github.com/repos/ga4gh/schemas/pulls{/number}","milestones_url":"https://api.github.com/repos/ga4gh/schemas/milestones{/number}","notifications_url":"https://api.github.com/repos/ga4gh/schemas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ga4gh/schemas/labels{/name}","releases_url":"https://api.github.com/repos/ga4gh/schemas/releases{/id}","deployments_url":"https://api.github.com/repos/ga4gh/schemas/deployments","created_at":"2014-03-20T00:13:40Z","updated_at":"2016-06-29T17:37:30Z","pushed_at":"2016-07-07T23:25:24Z","git_url":"git://github.com/ga4gh/schemas.git","ssh_url":"git@github.com:ga4gh/schemas.git","clone_url":"https://github.com/ga4gh/schemas.git","svn_url":"https://github.com/ga4gh/schemas","homepage":"http://ga4gh.org/#/api","size":15261,"stargazers_count":183,"watchers_count":183,"language":"Protocol Buffer","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":101,"mirror_url":null,"open_issues_count":170,"forks":101,"open_issues":170,"watchers":183,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ga4gh/schemas/pulls/652"},"html":{"href":"https://github.com/ga4gh/schemas/pull/652"},"issue":{"href":"https://api.github.com/repos/ga4gh/schemas/issues/652"},"comments":{"href":"https://api.github.com/repos/ga4gh/schemas/issues/652/comments"},"review_comments":{"href":"https://api.github.com/repos/ga4gh/schemas/pulls/652/comments"},"review_comment":{"href":"https://api.github.com/repos/ga4gh/schemas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ga4gh/schemas/pulls/652/commits"},"statuses":{"href":"https://api.github.com/repos/ga4gh/schemas/statuses/fa3162c068b6fc22c920502d526b2e482ab5f546"}}}}
{"actor":{"display_login":"calbach"}}