{"action":"created","comment":{"url":"https://api.github.com/repos/fluent/fluentd/pulls/comments/59693081","id":59693081,"diff_hunk":"@@ -61,6 +61,14 @@ def initialize\n     config_param :multiline_flush_interval, :time, default: nil\n     desc 'Enable the additional watch timer.'\n     config_param :enable_watch_timer, :bool, default: true\n+    desc 'The encoding of the input.'\n+    config_param :encoding, default: nil do |encoding_name|\n+      begin\n+        Encoding.find(encoding_name)\n+      rescue ArgumentError => e\n+        raise ConfigError.new(e.message)","path":"lib/fluent/plugin/in_tail.rb","position":9,"original_position":9,"commit_id":"a8d4ba6e2ccd8b655b4f0a01acc32906ec196956","original_commit_id":"a8d4ba6e2ccd8b655b4f0a01acc32906ec196956","user":{"login":"tagomoris","id":230654,"avatar_url":"https://avatars.githubusercontent.com/u/230654?v=3","gravatar_id":"","url":"https://api.github.com/users/tagomoris","html_url":"https://github.com/tagomoris","followers_url":"https://api.github.com/users/tagomoris/followers","following_url":"https://api.github.com/users/tagomoris/following{/other_user}","gists_url":"https://api.github.com/users/tagomoris/gists{/gist_id}","starred_url":"https://api.github.com/users/tagomoris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tagomoris/subscriptions","organizations_url":"https://api.github.com/users/tagomoris/orgs","repos_url":"https://api.github.com/users/tagomoris/repos","events_url":"https://api.github.com/users/tagomoris/events{/privacy}","received_events_url":"https://api.github.com/users/tagomoris/received_events","type":"User","site_admin":false},"body":"Newing error looks a bit curious for me. I like: `raise ConfigError, e.message`","created_at":"2016-04-14T10:17:16Z","updated_at":"2016-04-14T10:17:16Z","html_url":"https://github.com/fluent/fluentd/pull/889#discussion_r59693081","pull_request_url":"https://api.github.com/repos/fluent/fluentd/pulls/889","_links":{"self":{"href":"https://api.github.com/repos/fluent/fluentd/pulls/comments/59693081"},"html":{"href":"https://github.com/fluent/fluentd/pull/889#discussion_r59693081"},"pull_request":{"href":"https://api.github.com/repos/fluent/fluentd/pulls/889"}}},"pull_request":{"url":"https://api.github.com/repos/fluent/fluentd/pulls/889","id":65910928,"html_url":"https://github.com/fluent/fluentd/pull/889","diff_url":"https://github.com/fluent/fluentd/pull/889.diff","patch_url":"https://github.com/fluent/fluentd/pull/889.patch","issue_url":"https://api.github.com/repos/fluent/fluentd/issues/889","number":889,"state":"open","locked":false,"title":"Add \"encoding\" parameter to in_tail plugin","user":{"login":"miyakawataku","id":712804,"avatar_url":"https://avatars.githubusercontent.com/u/712804?v=3","gravatar_id":"","url":"https://api.github.com/users/miyakawataku","html_url":"https://github.com/miyakawataku","followers_url":"https://api.github.com/users/miyakawataku/followers","following_url":"https://api.github.com/users/miyakawataku/following{/other_user}","gists_url":"https://api.github.com/users/miyakawataku/gists{/gist_id}","starred_url":"https://api.github.com/users/miyakawataku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miyakawataku/subscriptions","organizations_url":"https://api.github.com/users/miyakawataku/orgs","repos_url":"https://api.github.com/users/miyakawataku/repos","events_url":"https://api.github.com/users/miyakawataku/events{/privacy}","received_events_url":"https://api.github.com/users/miyakawataku/received_events","type":"User","site_admin":false},"body":"Currently, ``in_tail`` plugin emits strings with ASCII-8BIT encoding, which is resulted from IO#readpartial. This behavior entails inconvenience when filtering records. For example:\r\n\r\n- [What do we write regex at filter-grep in Japanease? / Fluentd Google Group](https://groups.google.com/forum/#!topic/fluentd/0AxzJu2SMS4)\r\n\r\nThis PR adds ``encoding`` parameter to in_tail plugin, leaving ASCII-8BIT as default for compatibility.","created_at":"2016-04-10T13:50:06Z","updated_at":"2016-04-14T10:17:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45a4c78c2ddc10cfb3ff0d067350b4e0f35bdb87","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fluent/fluentd/pulls/889/commits","review_comments_url":"https://api.github.com/repos/fluent/fluentd/pulls/889/comments","review_comment_url":"https://api.github.com/repos/fluent/fluentd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fluent/fluentd/issues/889/comments","statuses_url":"https://api.github.com/repos/fluent/fluentd/statuses/a8d4ba6e2ccd8b655b4f0a01acc32906ec196956","head":{"label":"miyakawataku:encoding-param-for-tail-plugin","ref":"encoding-param-for-tail-plugin","sha":"a8d4ba6e2ccd8b655b4f0a01acc32906ec196956","user":{"login":"miyakawataku","id":712804,"avatar_url":"https://avatars.githubusercontent.com/u/712804?v=3","gravatar_id":"","url":"https://api.github.com/users/miyakawataku","html_url":"https://github.com/miyakawataku","followers_url":"https://api.github.com/users/miyakawataku/followers","following_url":"https://api.github.com/users/miyakawataku/following{/other_user}","gists_url":"https://api.github.com/users/miyakawataku/gists{/gist_id}","starred_url":"https://api.github.com/users/miyakawataku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miyakawataku/subscriptions","organizations_url":"https://api.github.com/users/miyakawataku/orgs","repos_url":"https://api.github.com/users/miyakawataku/repos","events_url":"https://api.github.com/users/miyakawataku/events{/privacy}","received_events_url":"https://api.github.com/users/miyakawataku/received_events","type":"User","site_admin":false},"repo":{"id":51740835,"name":"fluentd","full_name":"miyakawataku/fluentd","owner":{"login":"miyakawataku","id":712804,"avatar_url":"https://avatars.githubusercontent.com/u/712804?v=3","gravatar_id":"","url":"https://api.github.com/users/miyakawataku","html_url":"https://github.com/miyakawataku","followers_url":"https://api.github.com/users/miyakawataku/followers","following_url":"https://api.github.com/users/miyakawataku/following{/other_user}","gists_url":"https://api.github.com/users/miyakawataku/gists{/gist_id}","starred_url":"https://api.github.com/users/miyakawataku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miyakawataku/subscriptions","organizations_url":"https://api.github.com/users/miyakawataku/orgs","repos_url":"https://api.github.com/users/miyakawataku/repos","events_url":"https://api.github.com/users/miyakawataku/events{/privacy}","received_events_url":"https://api.github.com/users/miyakawataku/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/miyakawataku/fluentd","description":"Fluentd data collector","fork":true,"url":"https://api.github.com/repos/miyakawataku/fluentd","forks_url":"https://api.github.com/repos/miyakawataku/fluentd/forks","keys_url":"https://api.github.com/repos/miyakawataku/fluentd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/miyakawataku/fluentd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/miyakawataku/fluentd/teams","hooks_url":"https://api.github.com/repos/miyakawataku/fluentd/hooks","issue_events_url":"https://api.github.com/repos/miyakawataku/fluentd/issues/events{/number}","events_url":"https://api.github.com/repos/miyakawataku/fluentd/events","assignees_url":"https://api.github.com/repos/miyakawataku/fluentd/assignees{/user}","branches_url":"https://api.github.com/repos/miyakawataku/fluentd/branches{/branch}","tags_url":"https://api.github.com/repos/miyakawataku/fluentd/tags","blobs_url":"https://api.github.com/repos/miyakawataku/fluentd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/miyakawataku/fluentd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/miyakawataku/fluentd/git/refs{/sha}","trees_url":"https://api.github.com/repos/miyakawataku/fluentd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/miyakawataku/fluentd/statuses/{sha}","languages_url":"https://api.github.com/repos/miyakawataku/fluentd/languages","stargazers_url":"https://api.github.com/repos/miyakawataku/fluentd/stargazers","contributors_url":"https://api.github.com/repos/miyakawataku/fluentd/contributors","subscribers_url":"https://api.github.com/repos/miyakawataku/fluentd/subscribers","subscription_url":"https://api.github.com/repos/miyakawataku/fluentd/subscription","commits_url":"https://api.github.com/repos/miyakawataku/fluentd/commits{/sha}","git_commits_url":"https://api.github.com/repos/miyakawataku/fluentd/git/commits{/sha}","comments_url":"https://api.github.com/repos/miyakawataku/fluentd/comments{/number}","issue_comment_url":"https://api.github.com/repos/miyakawataku/fluentd/issues/comments{/number}","contents_url":"https://api.github.com/repos/miyakawataku/fluentd/contents/{+path}","compare_url":"https://api.github.com/repos/miyakawataku/fluentd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/miyakawataku/fluentd/merges","archive_url":"https://api.github.com/repos/miyakawataku/fluentd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/miyakawataku/fluentd/downloads","issues_url":"https://api.github.com/repos/miyakawataku/fluentd/issues{/number}","pulls_url":"https://api.github.com/repos/miyakawataku/fluentd/pulls{/number}","milestones_url":"https://api.github.com/repos/miyakawataku/fluentd/milestones{/number}","notifications_url":"https://api.github.com/repos/miyakawataku/fluentd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/miyakawataku/fluentd/labels{/name}","releases_url":"https://api.github.com/repos/miyakawataku/fluentd/releases{/id}","deployments_url":"https://api.github.com/repos/miyakawataku/fluentd/deployments","created_at":"2016-02-15T08:23:31Z","updated_at":"2016-02-15T08:23:32Z","pushed_at":"2016-04-13T11:23:27Z","git_url":"git://github.com/miyakawataku/fluentd.git","ssh_url":"git@github.com:miyakawataku/fluentd.git","clone_url":"https://github.com/miyakawataku/fluentd.git","svn_url":"https://github.com/miyakawataku/fluentd","homepage":"http://www.fluentd.org/","size":14036,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fluent:master","ref":"master","sha":"beebe98c278bed50a65072d43d42db14b3511899","user":{"login":"fluent","id":859518,"avatar_url":"https://avatars.githubusercontent.com/u/859518?v=3","gravatar_id":"","url":"https://api.github.com/users/fluent","html_url":"https://github.com/fluent","followers_url":"https://api.github.com/users/fluent/followers","following_url":"https://api.github.com/users/fluent/following{/other_user}","gists_url":"https://api.github.com/users/fluent/gists{/gist_id}","starred_url":"https://api.github.com/users/fluent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluent/subscriptions","organizations_url":"https://api.github.com/users/fluent/orgs","repos_url":"https://api.github.com/users/fluent/repos","events_url":"https://api.github.com/users/fluent/events{/privacy}","received_events_url":"https://api.github.com/users/fluent/received_events","type":"Organization","site_admin":false},"repo":{"id":1918677,"name":"fluentd","full_name":"fluent/fluentd","owner":{"login":"fluent","id":859518,"avatar_url":"https://avatars.githubusercontent.com/u/859518?v=3","gravatar_id":"","url":"https://api.github.com/users/fluent","html_url":"https://github.com/fluent","followers_url":"https://api.github.com/users/fluent/followers","following_url":"https://api.github.com/users/fluent/following{/other_user}","gists_url":"https://api.github.com/users/fluent/gists{/gist_id}","starred_url":"https://api.github.com/users/fluent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluent/subscriptions","organizations_url":"https://api.github.com/users/fluent/orgs","repos_url":"https://api.github.com/users/fluent/repos","events_url":"https://api.github.com/users/fluent/events{/privacy}","received_events_url":"https://api.github.com/users/fluent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fluent/fluentd","description":"Fluentd data collector","fork":false,"url":"https://api.github.com/repos/fluent/fluentd","forks_url":"https://api.github.com/repos/fluent/fluentd/forks","keys_url":"https://api.github.com/repos/fluent/fluentd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fluent/fluentd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fluent/fluentd/teams","hooks_url":"https://api.github.com/repos/fluent/fluentd/hooks","issue_events_url":"https://api.github.com/repos/fluent/fluentd/issues/events{/number}","events_url":"https://api.github.com/repos/fluent/fluentd/events","assignees_url":"https://api.github.com/repos/fluent/fluentd/assignees{/user}","branches_url":"https://api.github.com/repos/fluent/fluentd/branches{/branch}","tags_url":"https://api.github.com/repos/fluent/fluentd/tags","blobs_url":"https://api.github.com/repos/fluent/fluentd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fluent/fluentd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fluent/fluentd/git/refs{/sha}","trees_url":"https://api.github.com/repos/fluent/fluentd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fluent/fluentd/statuses/{sha}","languages_url":"https://api.github.com/repos/fluent/fluentd/languages","stargazers_url":"https://api.github.com/repos/fluent/fluentd/stargazers","contributors_url":"https://api.github.com/repos/fluent/fluentd/contributors","subscribers_url":"https://api.github.com/repos/fluent/fluentd/subscribers","subscription_url":"https://api.github.com/repos/fluent/fluentd/subscription","commits_url":"https://api.github.com/repos/fluent/fluentd/commits{/sha}","git_commits_url":"https://api.github.com/repos/fluent/fluentd/git/commits{/sha}","comments_url":"https://api.github.com/repos/fluent/fluentd/comments{/number}","issue_comment_url":"https://api.github.com/repos/fluent/fluentd/issues/comments{/number}","contents_url":"https://api.github.com/repos/fluent/fluentd/contents/{+path}","compare_url":"https://api.github.com/repos/fluent/fluentd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fluent/fluentd/merges","archive_url":"https://api.github.com/repos/fluent/fluentd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fluent/fluentd/downloads","issues_url":"https://api.github.com/repos/fluent/fluentd/issues{/number}","pulls_url":"https://api.github.com/repos/fluent/fluentd/pulls{/number}","milestones_url":"https://api.github.com/repos/fluent/fluentd/milestones{/number}","notifications_url":"https://api.github.com/repos/fluent/fluentd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fluent/fluentd/labels{/name}","releases_url":"https://api.github.com/repos/fluent/fluentd/releases{/id}","deployments_url":"https://api.github.com/repos/fluent/fluentd/deployments","created_at":"2011-06-19T08:41:40Z","updated_at":"2016-04-14T02:39:56Z","pushed_at":"2016-04-14T10:15:18Z","git_url":"git://github.com/fluent/fluentd.git","ssh_url":"git@github.com:fluent/fluentd.git","clone_url":"https://github.com/fluent/fluentd.git","svn_url":"https://github.com/fluent/fluentd","homepage":"http://www.fluentd.org/","size":14872,"stargazers_count":3988,"watchers_count":3988,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":463,"mirror_url":null,"open_issues_count":67,"forks":463,"open_issues":67,"watchers":3988,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fluent/fluentd/pulls/889"},"html":{"href":"https://github.com/fluent/fluentd/pull/889"},"issue":{"href":"https://api.github.com/repos/fluent/fluentd/issues/889"},"comments":{"href":"https://api.github.com/repos/fluent/fluentd/issues/889/comments"},"review_comments":{"href":"https://api.github.com/repos/fluent/fluentd/pulls/889/comments"},"review_comment":{"href":"https://api.github.com/repos/fluent/fluentd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fluent/fluentd/pulls/889/commits"},"statuses":{"href":"https://api.github.com/repos/fluent/fluentd/statuses/a8d4ba6e2ccd8b655b4f0a01acc32906ec196956"}}}}