{"action":"created","comment":{"url":"https://api.github.com/repos/CustomSDL/sdl_core/pulls/comments/74547666","id":74547666,"diff_hunk":"@@ -0,0 +1,58 @@\n+/*\n+ * Copyright (c) 2016, Ford Motor Company\n+ * All rights reserved.\n+ *\n+ * Redistribution and use in source and binary forms, with or without\n+ * modification, are permitted provided that the following conditions are met:\n+ *\n+ * Redistributions of source code must retain the above copyright notice, this\n+ * list of conditions and the following disclaimer.\n+ *\n+ * Redistributions in binary form must reproduce the above copyright notice,\n+ * this list of conditions and the following\n+ * disclaimer in the documentation and/or other materials provided with the\n+ * distribution.\n+ *\n+ * Neither the name of the Ford Motor Company nor the names of its contributors\n+ * may be used to endorse or promote products derived from this software\n+ * without specific prior written permission.\n+ *\n+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS \"AS IS\"\n+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE\n+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE\n+ * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE\n+ * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR\n+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF\n+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS\n+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN\n+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)\n+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE\n+ * POSSIBILITY OF SUCH DAMAGE.\n+ */\n+\n+#include \"vr_cooperation/commands/on_service_deactivated_notification.h\"\n+#include \"utils/logger.h\"\n+\n+namespace vr_cooperation {\n+\n+namespace commands {\n+\n+CREATE_LOGGERPTR_GLOBAL(logger_, \"OnServiceDeactivatedNotification\")","path":"src/components/vr_cooperation/src/on_service_deactivated_notification.cc","position":40,"original_position":40,"commit_id":"287775a8612dec7e11c1773600a0eb8f98e716b2","original_commit_id":"287775a8612dec7e11c1773600a0eb8f98e716b2","user":{"login":"bonewell","id":1861963,"avatar_url":"https://avatars.githubusercontent.com/u/1861963?v=3","gravatar_id":"","url":"https://api.github.com/users/bonewell","html_url":"https://github.com/bonewell","followers_url":"https://api.github.com/users/bonewell/followers","following_url":"https://api.github.com/users/bonewell/following{/other_user}","gists_url":"https://api.github.com/users/bonewell/gists{/gist_id}","starred_url":"https://api.github.com/users/bonewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bonewell/subscriptions","organizations_url":"https://api.github.com/users/bonewell/orgs","repos_url":"https://api.github.com/users/bonewell/repos","events_url":"https://api.github.com/users/bonewell/events{/privacy}","received_events_url":"https://api.github.com/users/bonewell/received_events","type":"User","site_admin":false},"body":"Using of component name for every class of that component is better practice.","created_at":"2016-08-12T06:47:54Z","updated_at":"2016-08-12T06:47:54Z","html_url":"https://github.com/CustomSDL/sdl_core/pull/180#discussion_r74547666","pull_request_url":"https://api.github.com/repos/CustomSDL/sdl_core/pulls/180","_links":{"self":{"href":"https://api.github.com/repos/CustomSDL/sdl_core/pulls/comments/74547666"},"html":{"href":"https://github.com/CustomSDL/sdl_core/pull/180#discussion_r74547666"},"pull_request":{"href":"https://api.github.com/repos/CustomSDL/sdl_core/pulls/180"}}},"pull_request":{"url":"https://api.github.com/repos/CustomSDL/sdl_core/pulls/180","id":81072800,"html_url":"https://github.com/CustomSDL/sdl_core/pull/180","diff_url":"https://github.com/CustomSDL/sdl_core/pull/180.diff","patch_url":"https://github.com/CustomSDL/sdl_core/pull/180.patch","issue_url":"https://api.github.com/repos/CustomSDL/sdl_core/issues/180","number":180,"state":"open","locked":false,"title":"REVSDL-2389 OnServiceDeactivated notification implementation","user":{"login":"giangtqh","id":7510885,"avatar_url":"https://avatars.githubusercontent.com/u/7510885?v=3","gravatar_id":"","url":"https://api.github.com/users/giangtqh","html_url":"https://github.com/giangtqh","followers_url":"https://api.github.com/users/giangtqh/followers","following_url":"https://api.github.com/users/giangtqh/following{/other_user}","gists_url":"https://api.github.com/users/giangtqh/gists{/gist_id}","starred_url":"https://api.github.com/users/giangtqh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giangtqh/subscriptions","organizations_url":"https://api.github.com/users/giangtqh/orgs","repos_url":"https://api.github.com/users/giangtqh/repos","events_url":"https://api.github.com/users/giangtqh/events{/privacy}","received_events_url":"https://api.github.com/users/giangtqh/received_events","type":"User","site_admin":false},"body":"@bonewell \r\n@KKarlash \r\n@VladSemenyuk \r\n@DKlimenko \r\n@thinhts \r\nplease review","created_at":"2016-08-12T06:25:22Z","updated_at":"2016-08-12T06:47:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd5abc2dd11a0b9f15f51facfe27e8bf2933a4b4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/CustomSDL/sdl_core/pulls/180/commits","review_comments_url":"https://api.github.com/repos/CustomSDL/sdl_core/pulls/180/comments","review_comment_url":"https://api.github.com/repos/CustomSDL/sdl_core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CustomSDL/sdl_core/issues/180/comments","statuses_url":"https://api.github.com/repos/CustomSDL/sdl_core/statuses/287775a8612dec7e11c1773600a0eb8f98e716b2","head":{"label":"CustomSDL:REVSDL-2389-OnServiceDeactivated_notification_implementation","ref":"REVSDL-2389-OnServiceDeactivated_notification_implementation","sha":"287775a8612dec7e11c1773600a0eb8f98e716b2","user":{"login":"CustomSDL","id":11158379,"avatar_url":"https://avatars.githubusercontent.com/u/11158379?v=3","gravatar_id":"","url":"https://api.github.com/users/CustomSDL","html_url":"https://github.com/CustomSDL","followers_url":"https://api.github.com/users/CustomSDL/followers","following_url":"https://api.github.com/users/CustomSDL/following{/other_user}","gists_url":"https://api.github.com/users/CustomSDL/gists{/gist_id}","starred_url":"https://api.github.com/users/CustomSDL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CustomSDL/subscriptions","organizations_url":"https://api.github.com/users/CustomSDL/orgs","repos_url":"https://api.github.com/users/CustomSDL/repos","events_url":"https://api.github.com/users/CustomSDL/events{/privacy}","received_events_url":"https://api.github.com/users/CustomSDL/received_events","type":"Organization","site_admin":false},"repo":{"id":33346123,"name":"sdl_core","full_name":"CustomSDL/sdl_core","owner":{"login":"CustomSDL","id":11158379,"avatar_url":"https://avatars.githubusercontent.com/u/11158379?v=3","gravatar_id":"","url":"https://api.github.com/users/CustomSDL","html_url":"https://github.com/CustomSDL","followers_url":"https://api.github.com/users/CustomSDL/followers","following_url":"https://api.github.com/users/CustomSDL/following{/other_user}","gists_url":"https://api.github.com/users/CustomSDL/gists{/gist_id}","starred_url":"https://api.github.com/users/CustomSDL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CustomSDL/subscriptions","organizations_url":"https://api.github.com/users/CustomSDL/orgs","repos_url":"https://api.github.com/users/CustomSDL/repos","events_url":"https://api.github.com/users/CustomSDL/events{/privacy}","received_events_url":"https://api.github.com/users/CustomSDL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CustomSDL/sdl_core","description":"SmartDeviceLink Head Unit Emulator","fork":true,"url":"https://api.github.com/repos/CustomSDL/sdl_core","forks_url":"https://api.github.com/repos/CustomSDL/sdl_core/forks","keys_url":"https://api.github.com/repos/CustomSDL/sdl_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CustomSDL/sdl_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CustomSDL/sdl_core/teams","hooks_url":"https://api.github.com/repos/CustomSDL/sdl_core/hooks","issue_events_url":"https://api.github.com/repos/CustomSDL/sdl_core/issues/events{/number}","events_url":"https://api.github.com/repos/CustomSDL/sdl_core/events","assignees_url":"https://api.github.com/repos/CustomSDL/sdl_core/assignees{/user}","branches_url":"https://api.github.com/repos/CustomSDL/sdl_core/branches{/branch}","tags_url":"https://api.github.com/repos/CustomSDL/sdl_core/tags","blobs_url":"https://api.github.com/repos/CustomSDL/sdl_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CustomSDL/sdl_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CustomSDL/sdl_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/CustomSDL/sdl_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CustomSDL/sdl_core/statuses/{sha}","languages_url":"https://api.github.com/repos/CustomSDL/sdl_core/languages","stargazers_url":"https://api.github.com/repos/CustomSDL/sdl_core/stargazers","contributors_url":"https://api.github.com/repos/CustomSDL/sdl_core/contributors","subscribers_url":"https://api.github.com/repos/CustomSDL/sdl_core/subscribers","subscription_url":"https://api.github.com/repos/CustomSDL/sdl_core/subscription","commits_url":"https://api.github.com/repos/CustomSDL/sdl_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/CustomSDL/sdl_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/CustomSDL/sdl_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/CustomSDL/sdl_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/CustomSDL/sdl_core/contents/{+path}","compare_url":"https://api.github.com/repos/CustomSDL/sdl_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CustomSDL/sdl_core/merges","archive_url":"https://api.github.com/repos/CustomSDL/sdl_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CustomSDL/sdl_core/downloads","issues_url":"https://api.github.com/repos/CustomSDL/sdl_core/issues{/number}","pulls_url":"https://api.github.com/repos/CustomSDL/sdl_core/pulls{/number}","milestones_url":"https://api.github.com/repos/CustomSDL/sdl_core/milestones{/number}","notifications_url":"https://api.github.com/repos/CustomSDL/sdl_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CustomSDL/sdl_core/labels{/name}","releases_url":"https://api.github.com/repos/CustomSDL/sdl_core/releases{/id}","deployments_url":"https://api.github.com/repos/CustomSDL/sdl_core/deployments","created_at":"2015-04-03T04:26:56Z","updated_at":"2016-01-13T08:32:21Z","pushed_at":"2016-08-12T06:30:01Z","git_url":"git://github.com/CustomSDL/sdl_core.git","ssh_url":"git@github.com:CustomSDL/sdl_core.git","clone_url":"https://github.com/CustomSDL/sdl_core.git","svn_url":"https://github.com/CustomSDL/sdl_core","homepage":"","size":310900,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"CustomSDL:SDLRPCService","ref":"SDLRPCService","sha":"fdd63f7339777f757295e032c1ff08b294bb8768","user":{"login":"CustomSDL","id":11158379,"avatar_url":"https://avatars.githubusercontent.com/u/11158379?v=3","gravatar_id":"","url":"https://api.github.com/users/CustomSDL","html_url":"https://github.com/CustomSDL","followers_url":"https://api.github.com/users/CustomSDL/followers","following_url":"https://api.github.com/users/CustomSDL/following{/other_user}","gists_url":"https://api.github.com/users/CustomSDL/gists{/gist_id}","starred_url":"https://api.github.com/users/CustomSDL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CustomSDL/subscriptions","organizations_url":"https://api.github.com/users/CustomSDL/orgs","repos_url":"https://api.github.com/users/CustomSDL/repos","events_url":"https://api.github.com/users/CustomSDL/events{/privacy}","received_events_url":"https://api.github.com/users/CustomSDL/received_events","type":"Organization","site_admin":false},"repo":{"id":33346123,"name":"sdl_core","full_name":"CustomSDL/sdl_core","owner":{"login":"CustomSDL","id":11158379,"avatar_url":"https://avatars.githubusercontent.com/u/11158379?v=3","gravatar_id":"","url":"https://api.github.com/users/CustomSDL","html_url":"https://github.com/CustomSDL","followers_url":"https://api.github.com/users/CustomSDL/followers","following_url":"https://api.github.com/users/CustomSDL/following{/other_user}","gists_url":"https://api.github.com/users/CustomSDL/gists{/gist_id}","starred_url":"https://api.github.com/users/CustomSDL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CustomSDL/subscriptions","organizations_url":"https://api.github.com/users/CustomSDL/orgs","repos_url":"https://api.github.com/users/CustomSDL/repos","events_url":"https://api.github.com/users/CustomSDL/events{/privacy}","received_events_url":"https://api.github.com/users/CustomSDL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CustomSDL/sdl_core","description":"SmartDeviceLink Head Unit Emulator","fork":true,"url":"https://api.github.com/repos/CustomSDL/sdl_core","forks_url":"https://api.github.com/repos/CustomSDL/sdl_core/forks","keys_url":"https://api.github.com/repos/CustomSDL/sdl_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CustomSDL/sdl_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CustomSDL/sdl_core/teams","hooks_url":"https://api.github.com/repos/CustomSDL/sdl_core/hooks","issue_events_url":"https://api.github.com/repos/CustomSDL/sdl_core/issues/events{/number}","events_url":"https://api.github.com/repos/CustomSDL/sdl_core/events","assignees_url":"https://api.github.com/repos/CustomSDL/sdl_core/assignees{/user}","branches_url":"https://api.github.com/repos/CustomSDL/sdl_core/branches{/branch}","tags_url":"https://api.github.com/repos/CustomSDL/sdl_core/tags","blobs_url":"https://api.github.com/repos/CustomSDL/sdl_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CustomSDL/sdl_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CustomSDL/sdl_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/CustomSDL/sdl_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CustomSDL/sdl_core/statuses/{sha}","languages_url":"https://api.github.com/repos/CustomSDL/sdl_core/languages","stargazers_url":"https://api.github.com/repos/CustomSDL/sdl_core/stargazers","contributors_url":"https://api.github.com/repos/CustomSDL/sdl_core/contributors","subscribers_url":"https://api.github.com/repos/CustomSDL/sdl_core/subscribers","subscription_url":"https://api.github.com/repos/CustomSDL/sdl_core/subscription","commits_url":"https://api.github.com/repos/CustomSDL/sdl_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/CustomSDL/sdl_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/CustomSDL/sdl_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/CustomSDL/sdl_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/CustomSDL/sdl_core/contents/{+path}","compare_url":"https://api.github.com/repos/CustomSDL/sdl_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CustomSDL/sdl_core/merges","archive_url":"https://api.github.com/repos/CustomSDL/sdl_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CustomSDL/sdl_core/downloads","issues_url":"https://api.github.com/repos/CustomSDL/sdl_core/issues{/number}","pulls_url":"https://api.github.com/repos/CustomSDL/sdl_core/pulls{/number}","milestones_url":"https://api.github.com/repos/CustomSDL/sdl_core/milestones{/number}","notifications_url":"https://api.github.com/repos/CustomSDL/sdl_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CustomSDL/sdl_core/labels{/name}","releases_url":"https://api.github.com/repos/CustomSDL/sdl_core/releases{/id}","deployments_url":"https://api.github.com/repos/CustomSDL/sdl_core/deployments","created_at":"2015-04-03T04:26:56Z","updated_at":"2016-01-13T08:32:21Z","pushed_at":"2016-08-12T06:30:01Z","git_url":"git://github.com/CustomSDL/sdl_core.git","ssh_url":"git@github.com:CustomSDL/sdl_core.git","clone_url":"https://github.com/CustomSDL/sdl_core.git","svn_url":"https://github.com/CustomSDL/sdl_core","homepage":"","size":310900,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CustomSDL/sdl_core/pulls/180"},"html":{"href":"https://github.com/CustomSDL/sdl_core/pull/180"},"issue":{"href":"https://api.github.com/repos/CustomSDL/sdl_core/issues/180"},"comments":{"href":"https://api.github.com/repos/CustomSDL/sdl_core/issues/180/comments"},"review_comments":{"href":"https://api.github.com/repos/CustomSDL/sdl_core/pulls/180/comments"},"review_comment":{"href":"https://api.github.com/repos/CustomSDL/sdl_core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CustomSDL/sdl_core/pulls/180/commits"},"statuses":{"href":"https://api.github.com/repos/CustomSDL/sdl_core/statuses/287775a8612dec7e11c1773600a0eb8f98e716b2"}}}}
{"actor":{"display_login":"bonewell"}}