{"action":"created","issue":{"url":"https://api.github.com/repos/meteor/meteor/issues/6914","repository_url":"https://api.github.com/repos/meteor/meteor","labels_url":"https://api.github.com/repos/meteor/meteor/issues/6914/labels{/name}","comments_url":"https://api.github.com/repos/meteor/meteor/issues/6914/comments","events_url":"https://api.github.com/repos/meteor/meteor/issues/6914/events","html_url":"https://github.com/meteor/meteor/pull/6914","id":151162601,"number":6914,"title":"meteor shell: warn when using \"import\" in a way likely to fail","user":{"login":"gadicc","id":381978,"avatar_url":"https://avatars.githubusercontent.com/u/381978?v=3","gravatar_id":"","url":"https://api.github.com/users/gadicc","html_url":"https://github.com/gadicc","followers_url":"https://api.github.com/users/gadicc/followers","following_url":"https://api.github.com/users/gadicc/following{/other_user}","gists_url":"https://api.github.com/users/gadicc/gists{/gist_id}","starred_url":"https://api.github.com/users/gadicc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gadicc/subscriptions","organizations_url":"https://api.github.com/users/gadicc/orgs","repos_url":"https://api.github.com/users/gadicc/repos","events_url":"https://api.github.com/users/gadicc/events{/privacy}","received_events_url":"https://api.github.com/users/gadicc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-26T15:16:29Z","updated_at":"2016-04-27T05:02:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/meteor/meteor/pulls/6914","html_url":"https://github.com/meteor/meteor/pull/6914","diff_url":"https://github.com/meteor/meteor/pull/6914.diff","patch_url":"https://github.com/meteor/meteor/pull/6914.patch"},"body":"PR for #6764 (cc: @benjamn)\r\n\r\nI originally wanted to warn rather than fail, but with the way the result is sent back via a callback, it's one or the other.  Nevertheless, we can avoid failing on cases where we're confident the user actually knows what they're doing (i.e. using the imported var on the same line, see notes in `ecmascript.js` and test cases).\r\n\r\nNot sure where the best place is to redirect for more info; happy to amend the (currently linked) original issue to explain what's going on here in more depth, and then I guess it will (helpfully) be an obvious place to report unexpected errors relating to importing from the shell.  Otherwise will amend however you suggest."},"comment":{"url":"https://api.github.com/repos/meteor/meteor/issues/comments/214970575","html_url":"https://github.com/meteor/meteor/pull/6914#issuecomment-214970575","issue_url":"https://api.github.com/repos/meteor/meteor/issues/6914","id":214970575,"user":{"login":"gadicc","id":381978,"avatar_url":"https://avatars.githubusercontent.com/u/381978?v=3","gravatar_id":"","url":"https://api.github.com/users/gadicc","html_url":"https://github.com/gadicc","followers_url":"https://api.github.com/users/gadicc/followers","following_url":"https://api.github.com/users/gadicc/following{/other_user}","gists_url":"https://api.github.com/users/gadicc/gists{/gist_id}","starred_url":"https://api.github.com/users/gadicc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gadicc/subscriptions","organizations_url":"https://api.github.com/users/gadicc/orgs","repos_url":"https://api.github.com/users/gadicc/repos","events_url":"https://api.github.com/users/gadicc/events{/privacy}","received_events_url":"https://api.github.com/users/gadicc/received_events","type":"User","site_admin":false},"created_at":"2016-04-27T05:02:12Z","updated_at":"2016-04-27T05:02:12Z","body":"Just noticed the failing test, but it's unrelated to my commit:\r\n\r\n```\r\nC: tinytest - livedata stub - reconnect non-idempotent method : !!!!!!!!! FAIL !!!!!!!!!!!\r\n{\"groupPath\":[\"tinytest\",\"livedata stub\"],\"test\":\"reconnect non-idempotent method\",\"events\":[{\"sequence\":2489,\"type\":\"fail\",\"details\":{\"type\":\"true\",\"not\":false},\"cookie\":{\"name\":\"livedata stub - reconnect non-idempotent method\",\"offset\":0,\"groupPath\":[\"tinytest\",\"livedata stub\"],\"shortName\":\"reconnect non-idempotent method\"}}]}\r\n```\r\n\r\nI did add one test which is passing:\r\n\r\n```\r\nS: tinytest - ecmascript - server - compileForShell - warn on imports : OK\r\n```\r\n\r\nand all tests passed on my system, not sure what's specific about the above test that is failing on CI."}}