{"action":"created","issue":{"url":"https://api.github.com/repos/fastlane/fastlane/issues/4628","repository_url":"https://api.github.com/repos/fastlane/fastlane","labels_url":"https://api.github.com/repos/fastlane/fastlane/issues/4628/labels{/name}","comments_url":"https://api.github.com/repos/fastlane/fastlane/issues/4628/comments","events_url":"https://api.github.com/repos/fastlane/fastlane/issues/4628/events","html_url":"https://github.com/fastlane/fastlane/issues/4628","id":154485141,"number":4628,"title":"admin: would be great if you could set some expectations around pull request timing","user":{"login":"ConfusedVorlon","id":586910,"avatar_url":"https://avatars.githubusercontent.com/u/586910?v=3","gravatar_id":"","url":"https://api.github.com/users/ConfusedVorlon","html_url":"https://github.com/ConfusedVorlon","followers_url":"https://api.github.com/users/ConfusedVorlon/followers","following_url":"https://api.github.com/users/ConfusedVorlon/following{/other_user}","gists_url":"https://api.github.com/users/ConfusedVorlon/gists{/gist_id}","starred_url":"https://api.github.com/users/ConfusedVorlon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConfusedVorlon/subscriptions","organizations_url":"https://api.github.com/users/ConfusedVorlon/orgs","repos_url":"https://api.github.com/users/ConfusedVorlon/repos","events_url":"https://api.github.com/users/ConfusedVorlon/events{/privacy}","received_events_url":"https://api.github.com/users/ConfusedVorlon/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"vpolouchkine","id":915660,"avatar_url":"https://avatars.githubusercontent.com/u/915660?v=3","gravatar_id":"","url":"https://api.github.com/users/vpolouchkine","html_url":"https://github.com/vpolouchkine","followers_url":"https://api.github.com/users/vpolouchkine/followers","following_url":"https://api.github.com/users/vpolouchkine/following{/other_user}","gists_url":"https://api.github.com/users/vpolouchkine/gists{/gist_id}","starred_url":"https://api.github.com/users/vpolouchkine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vpolouchkine/subscriptions","organizations_url":"https://api.github.com/users/vpolouchkine/orgs","repos_url":"https://api.github.com/users/vpolouchkine/repos","events_url":"https://api.github.com/users/vpolouchkine/events{/privacy}","received_events_url":"https://api.github.com/users/vpolouchkine/received_events","type":"User","site_admin":false},"milestone":null,"comments":4,"created_at":"2016-05-12T13:41:15Z","updated_at":"2016-05-30T11:43:02Z","closed_at":"2016-05-16T17:11:10Z","body":"\r\n### Issue Description\r\n\r\nwhat is the expectation for a response from the fastlane team to a pull request?\r\n\r\nto take my own example, I sent a pretty simple and (I think) non-controversial pull request nearly two weeks ago.\r\n\r\nother than somebody adding a label to show which project it hits (frameit), I haven't had any communication at all.\r\n\r\nI don't know whether this is a perfectly normal timeline and I should just sit tight, or whether this is an abnormal delay.\r\n\r\nI do know that it is discouraging in the least, and at the worst leads to stale pull requests. (I actually submitted a less good request to do a similar job - many months ago, but by the time anyone really looked at it, it was not able to merge).\r\n\r\nIt would be great if you had some kind of guidelines on what we should expect in the contributing doc\r\n\r\ne.g.\r\n\r\n```\r\n1) we'll generally get someone to have a look and comment on the general idea in xxx \r\n2) we'll aim to have a first code review and feedback in yyy\r\netc...\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/fastlane/fastlane/issues/comments/222474741","html_url":"https://github.com/fastlane/fastlane/issues/4628#issuecomment-222474741","issue_url":"https://api.github.com/repos/fastlane/fastlane/issues/4628","id":222474741,"user":{"login":"ConfusedVorlon","id":586910,"avatar_url":"https://avatars.githubusercontent.com/u/586910?v=3","gravatar_id":"","url":"https://api.github.com/users/ConfusedVorlon","html_url":"https://github.com/ConfusedVorlon","followers_url":"https://api.github.com/users/ConfusedVorlon/followers","following_url":"https://api.github.com/users/ConfusedVorlon/following{/other_user}","gists_url":"https://api.github.com/users/ConfusedVorlon/gists{/gist_id}","starred_url":"https://api.github.com/users/ConfusedVorlon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConfusedVorlon/subscriptions","organizations_url":"https://api.github.com/users/ConfusedVorlon/orgs","repos_url":"https://api.github.com/users/ConfusedVorlon/repos","events_url":"https://api.github.com/users/ConfusedVorlon/events{/privacy}","received_events_url":"https://api.github.com/users/ConfusedVorlon/received_events","type":"User","site_admin":false},"created_at":"2016-05-30T11:43:02Z","updated_at":"2016-05-30T11:43:02Z","body":"It has been a month now since I submitted what is essentially a 4-line pull request.\r\nThe only feedback I have had is that essentially you're focussing elsewhere at the moment.\r\n\r\nPull requests don't stay fresh. The exact thing I submitted is a rehash of a pull request that I submitted long ago, and where it became un-mergable due to changes to master. My current pull request will no doubt become stale before too long.\r\n\r\nThe message I'm getting is that submitting a pull request is a waste of my time.\r\n\r\nTo be clear - I totally understand that you are focussing on your own efforts to make fastlane stable, and that is an entirely reasonable choice. I use fastlane all the time, and stability is something I value.\r\n\r\nHowever - it would be polite to post a notice in the contribution guidelines to say that pull requests are only being looked under <insert details here> circumstances at the moment."}}
{"actor":{"display_login":"ConfusedVorlon"}}