{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-build/scikit-build/issues/38","repository_url":"https://api.github.com/repos/scikit-build/scikit-build","labels_url":"https://api.github.com/repos/scikit-build/scikit-build/issues/38/labels{/name}","comments_url":"https://api.github.com/repos/scikit-build/scikit-build/issues/38/comments","events_url":"https://api.github.com/repos/scikit-build/scikit-build/issues/38/events","html_url":"https://github.com/scikit-build/scikit-build/pull/38","id":159464453,"number":38,"title":"Testing/Bug Fixes (2016-06-06)","user":{"login":"opadron","id":2837854,"avatar_url":"https://avatars.githubusercontent.com/u/2837854?v=3","gravatar_id":"","url":"https://api.github.com/users/opadron","html_url":"https://github.com/opadron","followers_url":"https://api.github.com/users/opadron/followers","following_url":"https://api.github.com/users/opadron/following{/other_user}","gists_url":"https://api.github.com/users/opadron/gists{/gist_id}","starred_url":"https://api.github.com/users/opadron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opadron/subscriptions","organizations_url":"https://api.github.com/users/opadron/orgs","repos_url":"https://api.github.com/users/opadron/repos","events_url":"https://api.github.com/users/opadron/events{/privacy}","received_events_url":"https://api.github.com/users/opadron/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":70,"created_at":"2016-06-09T17:29:32Z","updated_at":"2016-06-29T20:57:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scikit-build/scikit-build/pulls/38","html_url":"https://github.com/scikit-build/scikit-build/pull/38","diff_url":"https://github.com/scikit-build/scikit-build/pull/38.diff","patch_url":"https://github.com/scikit-build/scikit-build/pull/38.patch"},"body":"Continues the work in #36.\r\n\r\nExtends the testing coverage to include the new features and demo applications introduced in #36.\r\n\r\n#### TODO\r\n\r\n - [ ] Extend testing coverage to include the new apps and new features.\r\n\r\n   - [x] Projects that attempt to CMake-install files outside of its designated project installation root should fail to install.\r\n\r\n     - [x] Ideally, they should fail prior to the CMake-install step (i.e.: before any problematic files are actually installed).  This will need code to determine the would-be files without the aid of the install manifest.\r\n\r\n   - [ ] Each of the sample projects should have their own tests to at least ensure that they build correctly, and that any produced applications run without issue.\r\n\r\n    - [ ] Add tests for pen2_cython\r\n\r\n    - [ ] Add tests for tower-of-babel\r\n\r\n - [ ] There are multiple bugs in the way command line arguments are processed and forwarded in scikit-build.  It's not clear if they were introduced by these changes, or if they predate them.\r\n\r\n   - [ ] There is a bug when trying to specify the desired CMake build type via the `--build-type` option in scikit-build.  It seems that some sections of the code are looking for `CMAKE_BUILD_DIR/CMAKE_BUILD_TYPE` as the ultimate location of the cmake build directory.  I think handling multiple builds in one tree is desirable and we should probably extend this handling to the other temporary staging directories, but right now, these improvements were not expecting this.  We'll need to go through the various code sections and make sure everyone's on the same page.\r\n\r\n   - [ ] On a related note, I tried to pass options directly to CMake through scikit-build using the `--` argument seperator.  Scikit-build is currently written to expect up to three sections of such options: the first for scikit-build options, the second for CMake config options, and the third for options to the build step.  However, since CMake is used to drive the build step, options meant for the actual build tool (e.g.: make) must be separated by another `--` separator.  Currently scikit-build fails to properly handle this fourth separator.\r\n\r\n - [ ] Currently the only way to add to the Cython module search path for `add_cython_target` is to use the outdated `include_directories` CMake command.  Ideally, we would be able to use `target_include_directories` or something similar.  This may involve the creation of an actual CMake target."},"comment":{"url":"https://api.github.com/repos/scikit-build/scikit-build/issues/comments/229486386","html_url":"https://github.com/scikit-build/scikit-build/pull/38#issuecomment-229486386","issue_url":"https://api.github.com/repos/scikit-build/scikit-build/issues/38","id":229486386,"user":{"login":"thewtex","id":25432,"avatar_url":"https://avatars.githubusercontent.com/u/25432?v=3","gravatar_id":"","url":"https://api.github.com/users/thewtex","html_url":"https://github.com/thewtex","followers_url":"https://api.github.com/users/thewtex/followers","following_url":"https://api.github.com/users/thewtex/following{/other_user}","gists_url":"https://api.github.com/users/thewtex/gists{/gist_id}","starred_url":"https://api.github.com/users/thewtex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thewtex/subscriptions","organizations_url":"https://api.github.com/users/thewtex/orgs","repos_url":"https://api.github.com/users/thewtex/repos","events_url":"https://api.github.com/users/thewtex/events{/privacy}","received_events_url":"https://api.github.com/users/thewtex/received_events","type":"User","site_admin":false},"created_at":"2016-06-29T20:57:08Z","updated_at":"2016-06-29T20:57:08Z","body":"Congrats!\n\nOn Wed, Jun 29, 2016 at 4:42 PM, Jean-Christophe Fillion-Robin <\nnotifications@github.com> wrote:\n\n> Looking good 🎱\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/scikit-build/scikit-build/pull/38#issuecomment-229482126>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe/AABjWEh1JG9Sbk8yCSS8EcqlK2jQCTReks5qQtiugaJpZM4IyN0r>\n> .\n>\n"}}
{"actor":{"display_login":"thewtex"}}