{"action":"created","comment":{"url":"https://api.github.com/repos/Workday/metajava/pulls/comments/49349777","id":49349777,"diff_hunk":"@@ -124,36 +122,34 @@ private Node findDeepestMatchingNode(List<PackageElement> hierarchy) {\n      * rootNode}.\n      * @param rootNode The Node to start after.\n      */\n-    private void addPackageToNode(List<PackageElement> hierarchy, Node rootNode) {\n+    private void addPackageToNode(List<String> hierarchy, Node rootNode) {\n         if (hierarchy.isEmpty()) {\n             return;\n         }\n \n-        PackageElement root = hierarchy.get(0);\n-        String rootName = root.getSimpleName().toString();\n-        Node parentNode = rootNode.children.get(rootName);\n+        String root = hierarchy.get(0);\n+        Node parentNode = rootNode.children.get(root);\n         if (parentNode == null) {\n-            parentNode = createNodeForPackage(hierarchy);\n+            parentNode = createNodeForPackage(hierarchy, rootNode.canonicalName);\n             rootNode.children.put(parentNode.packagePoint, parentNode);\n         } else if (hierarchy.size() == 1) {\n-            parentNode.packageElement = root;\n+            parentNode.isValid = true;","path":"src/main/java/com/workday/meta/PackageTree.java","position":110,"original_position":110,"commit_id":"20d3511555e846af6dcae47d52d22beaf4d6afa8","original_commit_id":"20d3511555e846af6dcae47d52d22beaf4d6afa8","user":{"login":"ndtaylor","id":1548942,"avatar_url":"https://avatars.githubusercontent.com/u/1548942?v=3","gravatar_id":"","url":"https://api.github.com/users/ndtaylor","html_url":"https://github.com/ndtaylor","followers_url":"https://api.github.com/users/ndtaylor/followers","following_url":"https://api.github.com/users/ndtaylor/following{/other_user}","gists_url":"https://api.github.com/users/ndtaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/ndtaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndtaylor/subscriptions","organizations_url":"https://api.github.com/users/ndtaylor/orgs","repos_url":"https://api.github.com/users/ndtaylor/repos","events_url":"https://api.github.com/users/ndtaylor/events{/privacy}","received_events_url":"https://api.github.com/users/ndtaylor/received_events","type":"User","site_admin":false},"body":"I'm not sure isValid is the right name here. How about isCompletePackage?","created_at":"2016-01-11T17:27:37Z","updated_at":"2016-01-11T17:27:37Z","html_url":"https://github.com/Workday/metajava/pull/4#discussion_r49349777","pull_request_url":"https://api.github.com/repos/Workday/metajava/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/Workday/metajava/pulls/comments/49349777"},"html":{"href":"https://github.com/Workday/metajava/pull/4#discussion_r49349777"},"pull_request":{"href":"https://api.github.com/repos/Workday/metajava/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/Workday/metajava/pulls/4","id":55517256,"html_url":"https://github.com/Workday/metajava/pull/4","diff_url":"https://github.com/Workday/metajava/pull/4.diff","patch_url":"https://github.com/Workday/metajava/pull/4.patch","issue_url":"https://api.github.com/repos/Workday/metajava/issues/4","number":4,"state":"open","locked":false,"title":"Addressing bug in hierarchy creation.","user":{"login":"traviswestbrook","id":15273323,"avatar_url":"https://avatars.githubusercontent.com/u/15273323?v=3","gravatar_id":"","url":"https://api.github.com/users/traviswestbrook","html_url":"https://github.com/traviswestbrook","followers_url":"https://api.github.com/users/traviswestbrook/followers","following_url":"https://api.github.com/users/traviswestbrook/following{/other_user}","gists_url":"https://api.github.com/users/traviswestbrook/gists{/gist_id}","starred_url":"https://api.github.com/users/traviswestbrook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/traviswestbrook/subscriptions","organizations_url":"https://api.github.com/users/traviswestbrook/orgs","repos_url":"https://api.github.com/users/traviswestbrook/repos","events_url":"https://api.github.com/users/traviswestbrook/events{/privacy}","received_events_url":"https://api.github.com/users/traviswestbrook/received_events","type":"User","site_admin":false},"body":"Removed calls to getContainingElement and instead use the canonical name of a package to derive hierarchy","created_at":"2016-01-08T22:09:45Z","updated_at":"2016-01-11T17:27:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a210990516435c70bd339f6265f961a4bb4a7bcc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Workday/metajava/pulls/4/commits","review_comments_url":"https://api.github.com/repos/Workday/metajava/pulls/4/comments","review_comment_url":"https://api.github.com/repos/Workday/metajava/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Workday/metajava/issues/4/comments","statuses_url":"https://api.github.com/repos/Workday/metajava/statuses/20d3511555e846af6dcae47d52d22beaf4d6afa8","head":{"label":"traviswestbrook:master","ref":"master","sha":"20d3511555e846af6dcae47d52d22beaf4d6afa8","user":{"login":"traviswestbrook","id":15273323,"avatar_url":"https://avatars.githubusercontent.com/u/15273323?v=3","gravatar_id":"","url":"https://api.github.com/users/traviswestbrook","html_url":"https://github.com/traviswestbrook","followers_url":"https://api.github.com/users/traviswestbrook/followers","following_url":"https://api.github.com/users/traviswestbrook/following{/other_user}","gists_url":"https://api.github.com/users/traviswestbrook/gists{/gist_id}","starred_url":"https://api.github.com/users/traviswestbrook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/traviswestbrook/subscriptions","organizations_url":"https://api.github.com/users/traviswestbrook/orgs","repos_url":"https://api.github.com/users/traviswestbrook/repos","events_url":"https://api.github.com/users/traviswestbrook/events{/privacy}","received_events_url":"https://api.github.com/users/traviswestbrook/received_events","type":"User","site_admin":false},"repo":{"id":49298870,"name":"metajava","full_name":"traviswestbrook/metajava","owner":{"login":"traviswestbrook","id":15273323,"avatar_url":"https://avatars.githubusercontent.com/u/15273323?v=3","gravatar_id":"","url":"https://api.github.com/users/traviswestbrook","html_url":"https://github.com/traviswestbrook","followers_url":"https://api.github.com/users/traviswestbrook/followers","following_url":"https://api.github.com/users/traviswestbrook/following{/other_user}","gists_url":"https://api.github.com/users/traviswestbrook/gists{/gist_id}","starred_url":"https://api.github.com/users/traviswestbrook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/traviswestbrook/subscriptions","organizations_url":"https://api.github.com/users/traviswestbrook/orgs","repos_url":"https://api.github.com/users/traviswestbrook/repos","events_url":"https://api.github.com/users/traviswestbrook/events{/privacy}","received_events_url":"https://api.github.com/users/traviswestbrook/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/traviswestbrook/metajava","description":"Java annotation processor utils.","fork":true,"url":"https://api.github.com/repos/traviswestbrook/metajava","forks_url":"https://api.github.com/repos/traviswestbrook/metajava/forks","keys_url":"https://api.github.com/repos/traviswestbrook/metajava/keys{/key_id}","collaborators_url":"https://api.github.com/repos/traviswestbrook/metajava/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/traviswestbrook/metajava/teams","hooks_url":"https://api.github.com/repos/traviswestbrook/metajava/hooks","issue_events_url":"https://api.github.com/repos/traviswestbrook/metajava/issues/events{/number}","events_url":"https://api.github.com/repos/traviswestbrook/metajava/events","assignees_url":"https://api.github.com/repos/traviswestbrook/metajava/assignees{/user}","branches_url":"https://api.github.com/repos/traviswestbrook/metajava/branches{/branch}","tags_url":"https://api.github.com/repos/traviswestbrook/metajava/tags","blobs_url":"https://api.github.com/repos/traviswestbrook/metajava/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/traviswestbrook/metajava/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/traviswestbrook/metajava/git/refs{/sha}","trees_url":"https://api.github.com/repos/traviswestbrook/metajava/git/trees{/sha}","statuses_url":"https://api.github.com/repos/traviswestbrook/metajava/statuses/{sha}","languages_url":"https://api.github.com/repos/traviswestbrook/metajava/languages","stargazers_url":"https://api.github.com/repos/traviswestbrook/metajava/stargazers","contributors_url":"https://api.github.com/repos/traviswestbrook/metajava/contributors","subscribers_url":"https://api.github.com/repos/traviswestbrook/metajava/subscribers","subscription_url":"https://api.github.com/repos/traviswestbrook/metajava/subscription","commits_url":"https://api.github.com/repos/traviswestbrook/metajava/commits{/sha}","git_commits_url":"https://api.github.com/repos/traviswestbrook/metajava/git/commits{/sha}","comments_url":"https://api.github.com/repos/traviswestbrook/metajava/comments{/number}","issue_comment_url":"https://api.github.com/repos/traviswestbrook/metajava/issues/comments{/number}","contents_url":"https://api.github.com/repos/traviswestbrook/metajava/contents/{+path}","compare_url":"https://api.github.com/repos/traviswestbrook/metajava/compare/{base}...{head}","merges_url":"https://api.github.com/repos/traviswestbrook/metajava/merges","archive_url":"https://api.github.com/repos/traviswestbrook/metajava/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/traviswestbrook/metajava/downloads","issues_url":"https://api.github.com/repos/traviswestbrook/metajava/issues{/number}","pulls_url":"https://api.github.com/repos/traviswestbrook/metajava/pulls{/number}","milestones_url":"https://api.github.com/repos/traviswestbrook/metajava/milestones{/number}","notifications_url":"https://api.github.com/repos/traviswestbrook/metajava/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/traviswestbrook/metajava/labels{/name}","releases_url":"https://api.github.com/repos/traviswestbrook/metajava/releases{/id}","created_at":"2016-01-08T21:56:24Z","updated_at":"2016-01-08T21:56:25Z","pushed_at":"2016-01-08T22:08:28Z","git_url":"git://github.com/traviswestbrook/metajava.git","ssh_url":"git@github.com:traviswestbrook/metajava.git","clone_url":"https://github.com/traviswestbrook/metajava.git","svn_url":"https://github.com/traviswestbrook/metajava","homepage":"","size":68,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Workday:master","ref":"master","sha":"4cf264ccbeccf659bfb5bde598c5ac97adde6aba","user":{"login":"Workday","id":328102,"avatar_url":"https://avatars.githubusercontent.com/u/328102?v=3","gravatar_id":"","url":"https://api.github.com/users/Workday","html_url":"https://github.com/Workday","followers_url":"https://api.github.com/users/Workday/followers","following_url":"https://api.github.com/users/Workday/following{/other_user}","gists_url":"https://api.github.com/users/Workday/gists{/gist_id}","starred_url":"https://api.github.com/users/Workday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Workday/subscriptions","organizations_url":"https://api.github.com/users/Workday/orgs","repos_url":"https://api.github.com/users/Workday/repos","events_url":"https://api.github.com/users/Workday/events{/privacy}","received_events_url":"https://api.github.com/users/Workday/received_events","type":"Organization","site_admin":false},"repo":{"id":36572617,"name":"metajava","full_name":"Workday/metajava","owner":{"login":"Workday","id":328102,"avatar_url":"https://avatars.githubusercontent.com/u/328102?v=3","gravatar_id":"","url":"https://api.github.com/users/Workday","html_url":"https://github.com/Workday","followers_url":"https://api.github.com/users/Workday/followers","following_url":"https://api.github.com/users/Workday/following{/other_user}","gists_url":"https://api.github.com/users/Workday/gists{/gist_id}","starred_url":"https://api.github.com/users/Workday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Workday/subscriptions","organizations_url":"https://api.github.com/users/Workday/orgs","repos_url":"https://api.github.com/users/Workday/repos","events_url":"https://api.github.com/users/Workday/events{/privacy}","received_events_url":"https://api.github.com/users/Workday/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Workday/metajava","description":"Java annotation processor utils.","fork":false,"url":"https://api.github.com/repos/Workday/metajava","forks_url":"https://api.github.com/repos/Workday/metajava/forks","keys_url":"https://api.github.com/repos/Workday/metajava/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Workday/metajava/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Workday/metajava/teams","hooks_url":"https://api.github.com/repos/Workday/metajava/hooks","issue_events_url":"https://api.github.com/repos/Workday/metajava/issues/events{/number}","events_url":"https://api.github.com/repos/Workday/metajava/events","assignees_url":"https://api.github.com/repos/Workday/metajava/assignees{/user}","branches_url":"https://api.github.com/repos/Workday/metajava/branches{/branch}","tags_url":"https://api.github.com/repos/Workday/metajava/tags","blobs_url":"https://api.github.com/repos/Workday/metajava/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Workday/metajava/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Workday/metajava/git/refs{/sha}","trees_url":"https://api.github.com/repos/Workday/metajava/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Workday/metajava/statuses/{sha}","languages_url":"https://api.github.com/repos/Workday/metajava/languages","stargazers_url":"https://api.github.com/repos/Workday/metajava/stargazers","contributors_url":"https://api.github.com/repos/Workday/metajava/contributors","subscribers_url":"https://api.github.com/repos/Workday/metajava/subscribers","subscription_url":"https://api.github.com/repos/Workday/metajava/subscription","commits_url":"https://api.github.com/repos/Workday/metajava/commits{/sha}","git_commits_url":"https://api.github.com/repos/Workday/metajava/git/commits{/sha}","comments_url":"https://api.github.com/repos/Workday/metajava/comments{/number}","issue_comment_url":"https://api.github.com/repos/Workday/metajava/issues/comments{/number}","contents_url":"https://api.github.com/repos/Workday/metajava/contents/{+path}","compare_url":"https://api.github.com/repos/Workday/metajava/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Workday/metajava/merges","archive_url":"https://api.github.com/repos/Workday/metajava/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Workday/metajava/downloads","issues_url":"https://api.github.com/repos/Workday/metajava/issues{/number}","pulls_url":"https://api.github.com/repos/Workday/metajava/pulls{/number}","milestones_url":"https://api.github.com/repos/Workday/metajava/milestones{/number}","notifications_url":"https://api.github.com/repos/Workday/metajava/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Workday/metajava/labels{/name}","releases_url":"https://api.github.com/repos/Workday/metajava/releases{/id}","created_at":"2015-05-30T19:31:56Z","updated_at":"2015-10-24T02:56:32Z","pushed_at":"2016-01-08T22:09:45Z","git_url":"git://github.com/Workday/metajava.git","ssh_url":"git@github.com:Workday/metajava.git","clone_url":"https://github.com/Workday/metajava.git","svn_url":"https://github.com/Workday/metajava","homepage":"","size":280,"stargazers_count":13,"watchers_count":13,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Workday/metajava/pulls/4"},"html":{"href":"https://github.com/Workday/metajava/pull/4"},"issue":{"href":"https://api.github.com/repos/Workday/metajava/issues/4"},"comments":{"href":"https://api.github.com/repos/Workday/metajava/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/Workday/metajava/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/Workday/metajava/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Workday/metajava/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/Workday/metajava/statuses/20d3511555e846af6dcae47d52d22beaf4d6afa8"}}}}