{"action":"created","issue":{"url":"https://api.github.com/repos/SvenDowideit/dockerfiles/issues/37","labels_url":"https://api.github.com/repos/SvenDowideit/dockerfiles/issues/37/labels{/name}","comments_url":"https://api.github.com/repos/SvenDowideit/dockerfiles/issues/37/comments","events_url":"https://api.github.com/repos/SvenDowideit/dockerfiles/issues/37/events","html_url":"https://github.com/SvenDowideit/dockerfiles/pull/37","id":119825784,"number":37,"title":"Ambassador fix to allow multiple ports","user":{"login":"gaborcsardi","id":660288,"avatar_url":"https://avatars.githubusercontent.com/u/660288?v=3","gravatar_id":"","url":"https://api.github.com/users/gaborcsardi","html_url":"https://github.com/gaborcsardi","followers_url":"https://api.github.com/users/gaborcsardi/followers","following_url":"https://api.github.com/users/gaborcsardi/following{/other_user}","gists_url":"https://api.github.com/users/gaborcsardi/gists{/gist_id}","starred_url":"https://api.github.com/users/gaborcsardi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaborcsardi/subscriptions","organizations_url":"https://api.github.com/users/gaborcsardi/orgs","repos_url":"https://api.github.com/users/gaborcsardi/repos","events_url":"https://api.github.com/users/gaborcsardi/events{/privacy}","received_events_url":"https://api.github.com/users/gaborcsardi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-12-01T22:45:39Z","updated_at":"2016-01-12T01:39:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/SvenDowideit/dockerfiles/pulls/37","html_url":"https://github.com/SvenDowideit/dockerfiles/pull/37","diff_url":"https://github.com/SvenDowideit/dockerfiles/pull/37.diff","patch_url":"https://github.com/SvenDowideit/dockerfiles/pull/37.patch"},"body":"The little shell script in the ambassador image breaks if there are multiple ports that need to be forwarded. The problem is that you have a `wait` after every `socat` line, and then the script stops running at the first `wait` and the other ports won't be forwarded. \r\n\r\nThis came up in the `dokku-rabbitmq` project, that exposes 4 ports using the ambassador image:\r\nhttps://github.com/dokku/dokku-rabbitmq/issues/27\r\n\r\nThis is the problematic line: https://github.com/SvenDowideit/dockerfiles/blob/5bfe59de304fe6f1489e42ddceb37bb980f38a9e/ambassador/Dockerfile#L19\r\n\r\nMy fix calls `wait` only once, after all `socat` processes have started in the background.\r\n\r\nSo I guess whether you want this fix depends on whether you want to support multiple ports. If not, then I suggest to document this somewhere, because it causes a lot of confusion and delay. :)\r\n"},"comment":{"url":"https://api.github.com/repos/SvenDowideit/dockerfiles/issues/comments/170754579","html_url":"https://github.com/SvenDowideit/dockerfiles/pull/37#issuecomment-170754579","issue_url":"https://api.github.com/repos/SvenDowideit/dockerfiles/issues/37","id":170754579,"user":{"login":"SvenDowideit","id":28492,"avatar_url":"https://avatars.githubusercontent.com/u/28492?v=3","gravatar_id":"","url":"https://api.github.com/users/SvenDowideit","html_url":"https://github.com/SvenDowideit","followers_url":"https://api.github.com/users/SvenDowideit/followers","following_url":"https://api.github.com/users/SvenDowideit/following{/other_user}","gists_url":"https://api.github.com/users/SvenDowideit/gists{/gist_id}","starred_url":"https://api.github.com/users/SvenDowideit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SvenDowideit/subscriptions","organizations_url":"https://api.github.com/users/SvenDowideit/orgs","repos_url":"https://api.github.com/users/SvenDowideit/repos","events_url":"https://api.github.com/users/SvenDowideit/events{/privacy}","received_events_url":"https://api.github.com/users/SvenDowideit/received_events","type":"User","site_admin":false},"created_at":"2016-01-12T01:39:10Z","updated_at":"2016-01-12T01:39:10Z","body":"LGTM - thank you!"}}