{"action":"created","comment":{"url":"https://api.github.com/repos/projectfluent/fluent-rs/pulls/comments/94173706","pull_request_review_id":14704804,"id":94173706,"diff_hunk":"@@ -30,15 +30,14 @@ impl MessageContext {\n         Ok(())\n     }\n \n-    pub fn format(&self, id: &str) -> Result<String, ContextError> {\n-        match self.entries.get(id) {\n-            Some(ref value) => {\n-                match resolve(self, value) {\n-                    Ok(msg) => Ok(msg),\n-                    Err(_) => Err(ContextError::Generic),\n-                }\n-            }\n-            None => Err(ContextError::Generic),\n+    pub fn get_message(&self, id: &str) -> Option<&ast::Value> {\n+        self.entries.get(id)","path":"src/context/mod.rs","position":14,"original_position":14,"commit_id":"61eff6e03d910a5f45495da6a1e5425487a242f5","original_commit_id":"61eff6e03d910a5f45495da6a1e5425487a242f5","user":{"login":"stasm","id":265818,"avatar_url":"https://avatars.githubusercontent.com/u/265818?v=3","gravatar_id":"","url":"https://api.github.com/users/stasm","html_url":"https://github.com/stasm","followers_url":"https://api.github.com/users/stasm/followers","following_url":"https://api.github.com/users/stasm/following{/other_user}","gists_url":"https://api.github.com/users/stasm/gists{/gist_id}","starred_url":"https://api.github.com/users/stasm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stasm/subscriptions","organizations_url":"https://api.github.com/users/stasm/orgs","repos_url":"https://api.github.com/users/stasm/repos","events_url":"https://api.github.com/users/stasm/events{/privacy}","received_events_url":"https://api.github.com/users/stasm/received_events","type":"User","site_admin":false},"body":"I understand that right now `MessageContext` uses the runtime AST. I wonder if that's needed. Could we do without this special version of the AST in the Rust implementation?","created_at":"2016-12-29T19:52:37Z","updated_at":"2016-12-29T19:52:37Z","html_url":"https://github.com/projectfluent/fluent-rs/pull/1#discussion_r94173706","pull_request_url":"https://api.github.com/repos/projectfluent/fluent-rs/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/projectfluent/fluent-rs/pulls/comments/94173706"},"html":{"href":"https://github.com/projectfluent/fluent-rs/pull/1#discussion_r94173706"},"pull_request":{"href":"https://api.github.com/repos/projectfluent/fluent-rs/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/projectfluent/fluent-rs/pulls/1","id":99692127,"html_url":"https://github.com/projectfluent/fluent-rs/pull/1","diff_url":"https://github.com/projectfluent/fluent-rs/pull/1.diff","patch_url":"https://github.com/projectfluent/fluent-rs/pull/1.patch","issue_url":"https://api.github.com/repos/projectfluent/fluent-rs/issues/1","number":1,"state":"open","locked":false,"title":"MessageContext::get_message","user":{"login":"stasm","id":265818,"avatar_url":"https://avatars.githubusercontent.com/u/265818?v=3","gravatar_id":"","url":"https://api.github.com/users/stasm","html_url":"https://github.com/stasm","followers_url":"https://api.github.com/users/stasm/followers","following_url":"https://api.github.com/users/stasm/following{/other_user}","gists_url":"https://api.github.com/users/stasm/gists{/gist_id}","starred_url":"https://api.github.com/users/stasm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stasm/subscriptions","organizations_url":"https://api.github.com/users/stasm/orgs","repos_url":"https://api.github.com/users/stasm/repos","events_url":"https://api.github.com/users/stasm/events{/privacy}","received_events_url":"https://api.github.com/users/stasm/received_events","type":"User","site_admin":false},"body":"This aligns the `MessageContext` public API to that of its JS equivalent. `format` takes a Value object which must be first acquired via `get_message`.","created_at":"2016-12-29T19:50:16Z","updated_at":"2016-12-29T19:52:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d3fee801140ac0e8e462569df32afa6621b165e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/projectfluent/fluent-rs/pulls/1/commits","review_comments_url":"https://api.github.com/repos/projectfluent/fluent-rs/pulls/1/comments","review_comment_url":"https://api.github.com/repos/projectfluent/fluent-rs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectfluent/fluent-rs/issues/1/comments","statuses_url":"https://api.github.com/repos/projectfluent/fluent-rs/statuses/61eff6e03d910a5f45495da6a1e5425487a242f5","head":{"label":"stasm:get_message","ref":"get_message","sha":"61eff6e03d910a5f45495da6a1e5425487a242f5","user":{"login":"stasm","id":265818,"avatar_url":"https://avatars.githubusercontent.com/u/265818?v=3","gravatar_id":"","url":"https://api.github.com/users/stasm","html_url":"https://github.com/stasm","followers_url":"https://api.github.com/users/stasm/followers","following_url":"https://api.github.com/users/stasm/following{/other_user}","gists_url":"https://api.github.com/users/stasm/gists{/gist_id}","starred_url":"https://api.github.com/users/stasm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stasm/subscriptions","organizations_url":"https://api.github.com/users/stasm/orgs","repos_url":"https://api.github.com/users/stasm/repos","events_url":"https://api.github.com/users/stasm/events{/privacy}","received_events_url":"https://api.github.com/users/stasm/received_events","type":"User","site_admin":false},"repo":{"id":77635990,"name":"fluent-rs","full_name":"stasm/fluent-rs","owner":{"login":"stasm","id":265818,"avatar_url":"https://avatars.githubusercontent.com/u/265818?v=3","gravatar_id":"","url":"https://api.github.com/users/stasm","html_url":"https://github.com/stasm","followers_url":"https://api.github.com/users/stasm/followers","following_url":"https://api.github.com/users/stasm/following{/other_user}","gists_url":"https://api.github.com/users/stasm/gists{/gist_id}","starred_url":"https://api.github.com/users/stasm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stasm/subscriptions","organizations_url":"https://api.github.com/users/stasm/orgs","repos_url":"https://api.github.com/users/stasm/repos","events_url":"https://api.github.com/users/stasm/events{/privacy}","received_events_url":"https://api.github.com/users/stasm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stasm/fluent-rs","description":"Rust implementation of Project Fluent","fork":true,"url":"https://api.github.com/repos/stasm/fluent-rs","forks_url":"https://api.github.com/repos/stasm/fluent-rs/forks","keys_url":"https://api.github.com/repos/stasm/fluent-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stasm/fluent-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stasm/fluent-rs/teams","hooks_url":"https://api.github.com/repos/stasm/fluent-rs/hooks","issue_events_url":"https://api.github.com/repos/stasm/fluent-rs/issues/events{/number}","events_url":"https://api.github.com/repos/stasm/fluent-rs/events","assignees_url":"https://api.github.com/repos/stasm/fluent-rs/assignees{/user}","branches_url":"https://api.github.com/repos/stasm/fluent-rs/branches{/branch}","tags_url":"https://api.github.com/repos/stasm/fluent-rs/tags","blobs_url":"https://api.github.com/repos/stasm/fluent-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stasm/fluent-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stasm/fluent-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/stasm/fluent-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stasm/fluent-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/stasm/fluent-rs/languages","stargazers_url":"https://api.github.com/repos/stasm/fluent-rs/stargazers","contributors_url":"https://api.github.com/repos/stasm/fluent-rs/contributors","subscribers_url":"https://api.github.com/repos/stasm/fluent-rs/subscribers","subscription_url":"https://api.github.com/repos/stasm/fluent-rs/subscription","commits_url":"https://api.github.com/repos/stasm/fluent-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/stasm/fluent-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/stasm/fluent-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/stasm/fluent-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/stasm/fluent-rs/contents/{+path}","compare_url":"https://api.github.com/repos/stasm/fluent-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stasm/fluent-rs/merges","archive_url":"https://api.github.com/repos/stasm/fluent-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stasm/fluent-rs/downloads","issues_url":"https://api.github.com/repos/stasm/fluent-rs/issues{/number}","pulls_url":"https://api.github.com/repos/stasm/fluent-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/stasm/fluent-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/stasm/fluent-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stasm/fluent-rs/labels{/name}","releases_url":"https://api.github.com/repos/stasm/fluent-rs/releases{/id}","deployments_url":"https://api.github.com/repos/stasm/fluent-rs/deployments","created_at":"2016-12-29T19:45:29Z","updated_at":"2016-12-29T19:45:30Z","pushed_at":"2016-12-29T19:49:12Z","git_url":"git://github.com/stasm/fluent-rs.git","ssh_url":"git@github.com:stasm/fluent-rs.git","clone_url":"https://github.com/stasm/fluent-rs.git","svn_url":"https://github.com/stasm/fluent-rs","homepage":null,"size":5,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projectfluent:master","ref":"master","sha":"f2f3891a77bfc2fcd3b29b65ba9e42b7ee1bbdd3","user":{"login":"projectfluent","id":24696436,"avatar_url":"https://avatars.githubusercontent.com/u/24696436?v=3","gravatar_id":"","url":"https://api.github.com/users/projectfluent","html_url":"https://github.com/projectfluent","followers_url":"https://api.github.com/users/projectfluent/followers","following_url":"https://api.github.com/users/projectfluent/following{/other_user}","gists_url":"https://api.github.com/users/projectfluent/gists{/gist_id}","starred_url":"https://api.github.com/users/projectfluent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectfluent/subscriptions","organizations_url":"https://api.github.com/users/projectfluent/orgs","repos_url":"https://api.github.com/users/projectfluent/repos","events_url":"https://api.github.com/users/projectfluent/events{/privacy}","received_events_url":"https://api.github.com/users/projectfluent/received_events","type":"Organization","site_admin":false},"repo":{"id":77560730,"name":"fluent-rs","full_name":"projectfluent/fluent-rs","owner":{"login":"projectfluent","id":24696436,"avatar_url":"https://avatars.githubusercontent.com/u/24696436?v=3","gravatar_id":"","url":"https://api.github.com/users/projectfluent","html_url":"https://github.com/projectfluent","followers_url":"https://api.github.com/users/projectfluent/followers","following_url":"https://api.github.com/users/projectfluent/following{/other_user}","gists_url":"https://api.github.com/users/projectfluent/gists{/gist_id}","starred_url":"https://api.github.com/users/projectfluent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectfluent/subscriptions","organizations_url":"https://api.github.com/users/projectfluent/orgs","repos_url":"https://api.github.com/users/projectfluent/repos","events_url":"https://api.github.com/users/projectfluent/events{/privacy}","received_events_url":"https://api.github.com/users/projectfluent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectfluent/fluent-rs","description":"Rust implementation of Project Fluent","fork":false,"url":"https://api.github.com/repos/projectfluent/fluent-rs","forks_url":"https://api.github.com/repos/projectfluent/fluent-rs/forks","keys_url":"https://api.github.com/repos/projectfluent/fluent-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectfluent/fluent-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectfluent/fluent-rs/teams","hooks_url":"https://api.github.com/repos/projectfluent/fluent-rs/hooks","issue_events_url":"https://api.github.com/repos/projectfluent/fluent-rs/issues/events{/number}","events_url":"https://api.github.com/repos/projectfluent/fluent-rs/events","assignees_url":"https://api.github.com/repos/projectfluent/fluent-rs/assignees{/user}","branches_url":"https://api.github.com/repos/projectfluent/fluent-rs/branches{/branch}","tags_url":"https://api.github.com/repos/projectfluent/fluent-rs/tags","blobs_url":"https://api.github.com/repos/projectfluent/fluent-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectfluent/fluent-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectfluent/fluent-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectfluent/fluent-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectfluent/fluent-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/projectfluent/fluent-rs/languages","stargazers_url":"https://api.github.com/repos/projectfluent/fluent-rs/stargazers","contributors_url":"https://api.github.com/repos/projectfluent/fluent-rs/contributors","subscribers_url":"https://api.github.com/repos/projectfluent/fluent-rs/subscribers","subscription_url":"https://api.github.com/repos/projectfluent/fluent-rs/subscription","commits_url":"https://api.github.com/repos/projectfluent/fluent-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectfluent/fluent-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectfluent/fluent-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectfluent/fluent-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectfluent/fluent-rs/contents/{+path}","compare_url":"https://api.github.com/repos/projectfluent/fluent-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectfluent/fluent-rs/merges","archive_url":"https://api.github.com/repos/projectfluent/fluent-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectfluent/fluent-rs/downloads","issues_url":"https://api.github.com/repos/projectfluent/fluent-rs/issues{/number}","pulls_url":"https://api.github.com/repos/projectfluent/fluent-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/projectfluent/fluent-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/projectfluent/fluent-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectfluent/fluent-rs/labels{/name}","releases_url":"https://api.github.com/repos/projectfluent/fluent-rs/releases{/id}","deployments_url":"https://api.github.com/repos/projectfluent/fluent-rs/deployments","created_at":"2016-12-28T20:53:44Z","updated_at":"2016-12-28T20:55:14Z","pushed_at":"2016-12-29T19:50:16Z","git_url":"git://github.com/projectfluent/fluent-rs.git","ssh_url":"git@github.com:projectfluent/fluent-rs.git","clone_url":"https://github.com/projectfluent/fluent-rs.git","svn_url":"https://github.com/projectfluent/fluent-rs","homepage":null,"size":5,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectfluent/fluent-rs/pulls/1"},"html":{"href":"https://github.com/projectfluent/fluent-rs/pull/1"},"issue":{"href":"https://api.github.com/repos/projectfluent/fluent-rs/issues/1"},"comments":{"href":"https://api.github.com/repos/projectfluent/fluent-rs/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/projectfluent/fluent-rs/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/projectfluent/fluent-rs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectfluent/fluent-rs/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/projectfluent/fluent-rs/statuses/61eff6e03d910a5f45495da6a1e5425487a242f5"}}}}
{"actor":{"display_login":"stasm"}}