{"action":"created","comment":{"url":"https://api.github.com/repos/prometheus/client_java/pulls/comments/73167041","id":73167041,"diff_hunk":"@@ -137,15 +168,15 @@ public double observeDuration() {\n    * {@link SimpleCollector#remove} or {@link SimpleCollector#clear}.\n    */\n   public static class Child {\n-    public static class Value {\n-      public final double count;\n-      public final double sum;\n-      public final CKMSQuantiles quantiles;\n+    private static class Value {","path":"simpleclient/src/main/java/io/prometheus/client/Summary.java","position":null,"original_position":137,"commit_id":"c4bc42c48906d9a0bb1d514e9c912051a7f3d9c7","original_commit_id":"c4bc42c48906d9a0bb1d514e9c912051a7f3d9c7","user":{"login":"brian-brazil","id":7115638,"avatar_url":"https://avatars.githubusercontent.com/u/7115638?v=3","gravatar_id":"","url":"https://api.github.com/users/brian-brazil","html_url":"https://github.com/brian-brazil","followers_url":"https://api.github.com/users/brian-brazil/followers","following_url":"https://api.github.com/users/brian-brazil/following{/other_user}","gists_url":"https://api.github.com/users/brian-brazil/gists{/gist_id}","starred_url":"https://api.github.com/users/brian-brazil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brian-brazil/subscriptions","organizations_url":"https://api.github.com/users/brian-brazil/orgs","repos_url":"https://api.github.com/users/brian-brazil/repos","events_url":"https://api.github.com/users/brian-brazil/events{/privacy}","received_events_url":"https://api.github.com/users/brian-brazil/received_events","type":"User","site_admin":false},"body":"This is meant to be public","created_at":"2016-08-02T14:37:30Z","updated_at":"2016-08-02T14:37:30Z","html_url":"https://github.com/prometheus/client_java/pull/134#discussion_r73167041","pull_request_url":"https://api.github.com/repos/prometheus/client_java/pulls/134","_links":{"self":{"href":"https://api.github.com/repos/prometheus/client_java/pulls/comments/73167041"},"html":{"href":"https://github.com/prometheus/client_java/pull/134#discussion_r73167041"},"pull_request":{"href":"https://api.github.com/repos/prometheus/client_java/pulls/134"}}},"pull_request":{"url":"https://api.github.com/repos/prometheus/client_java/pulls/134","id":79575922,"html_url":"https://github.com/prometheus/client_java/pull/134","diff_url":"https://github.com/prometheus/client_java/pull/134.diff","patch_url":"https://github.com/prometheus/client_java/pull/134.patch","issue_url":"https://api.github.com/repos/prometheus/client_java/issues/134","number":134,"state":"open","locked":false,"title":"Added quantiles to summary metric (same algorithm as in client_golang).","user":{"login":"fstab","id":330535,"avatar_url":"https://avatars.githubusercontent.com/u/330535?v=3","gravatar_id":"","url":"https://api.github.com/users/fstab","html_url":"https://github.com/fstab","followers_url":"https://api.github.com/users/fstab/followers","following_url":"https://api.github.com/users/fstab/following{/other_user}","gists_url":"https://api.github.com/users/fstab/gists{/gist_id}","starred_url":"https://api.github.com/users/fstab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fstab/subscriptions","organizations_url":"https://api.github.com/users/fstab/orgs","repos_url":"https://api.github.com/users/fstab/repos","events_url":"https://api.github.com/users/fstab/events{/privacy}","received_events_url":"https://api.github.com/users/fstab/received_events","type":"User","site_admin":false},"body":"As mentioned in the comment on CKMSQuantiles: The algorithm isn't implemented by me, I just found the implementation on github.com/Netflix/ocelli (apache license) and integrated it. The Netflix implementation looks good, though.","created_at":"2016-08-01T14:19:47Z","updated_at":"2016-08-02T14:37:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df6980683010373d5b2ee2fa6c3759dcdc96d69b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/prometheus/client_java/pulls/134/commits","review_comments_url":"https://api.github.com/repos/prometheus/client_java/pulls/134/comments","review_comment_url":"https://api.github.com/repos/prometheus/client_java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prometheus/client_java/issues/134/comments","statuses_url":"https://api.github.com/repos/prometheus/client_java/statuses/c4bc42c48906d9a0bb1d514e9c912051a7f3d9c7","head":{"label":"fstab:summary-with-quantiles","ref":"summary-with-quantiles","sha":"c4bc42c48906d9a0bb1d514e9c912051a7f3d9c7","user":{"login":"fstab","id":330535,"avatar_url":"https://avatars.githubusercontent.com/u/330535?v=3","gravatar_id":"","url":"https://api.github.com/users/fstab","html_url":"https://github.com/fstab","followers_url":"https://api.github.com/users/fstab/followers","following_url":"https://api.github.com/users/fstab/following{/other_user}","gists_url":"https://api.github.com/users/fstab/gists{/gist_id}","starred_url":"https://api.github.com/users/fstab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fstab/subscriptions","organizations_url":"https://api.github.com/users/fstab/orgs","repos_url":"https://api.github.com/users/fstab/repos","events_url":"https://api.github.com/users/fstab/events{/privacy}","received_events_url":"https://api.github.com/users/fstab/received_events","type":"User","site_admin":false},"repo":{"id":64672798,"name":"client_java","full_name":"fstab/client_java","owner":{"login":"fstab","id":330535,"avatar_url":"https://avatars.githubusercontent.com/u/330535?v=3","gravatar_id":"","url":"https://api.github.com/users/fstab","html_url":"https://github.com/fstab","followers_url":"https://api.github.com/users/fstab/followers","following_url":"https://api.github.com/users/fstab/following{/other_user}","gists_url":"https://api.github.com/users/fstab/gists{/gist_id}","starred_url":"https://api.github.com/users/fstab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fstab/subscriptions","organizations_url":"https://api.github.com/users/fstab/orgs","repos_url":"https://api.github.com/users/fstab/repos","events_url":"https://api.github.com/users/fstab/events{/privacy}","received_events_url":"https://api.github.com/users/fstab/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fstab/client_java","description":"Prometheus instrumentation library for JVM applications","fork":true,"url":"https://api.github.com/repos/fstab/client_java","forks_url":"https://api.github.com/repos/fstab/client_java/forks","keys_url":"https://api.github.com/repos/fstab/client_java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fstab/client_java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fstab/client_java/teams","hooks_url":"https://api.github.com/repos/fstab/client_java/hooks","issue_events_url":"https://api.github.com/repos/fstab/client_java/issues/events{/number}","events_url":"https://api.github.com/repos/fstab/client_java/events","assignees_url":"https://api.github.com/repos/fstab/client_java/assignees{/user}","branches_url":"https://api.github.com/repos/fstab/client_java/branches{/branch}","tags_url":"https://api.github.com/repos/fstab/client_java/tags","blobs_url":"https://api.github.com/repos/fstab/client_java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fstab/client_java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fstab/client_java/git/refs{/sha}","trees_url":"https://api.github.com/repos/fstab/client_java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fstab/client_java/statuses/{sha}","languages_url":"https://api.github.com/repos/fstab/client_java/languages","stargazers_url":"https://api.github.com/repos/fstab/client_java/stargazers","contributors_url":"https://api.github.com/repos/fstab/client_java/contributors","subscribers_url":"https://api.github.com/repos/fstab/client_java/subscribers","subscription_url":"https://api.github.com/repos/fstab/client_java/subscription","commits_url":"https://api.github.com/repos/fstab/client_java/commits{/sha}","git_commits_url":"https://api.github.com/repos/fstab/client_java/git/commits{/sha}","comments_url":"https://api.github.com/repos/fstab/client_java/comments{/number}","issue_comment_url":"https://api.github.com/repos/fstab/client_java/issues/comments{/number}","contents_url":"https://api.github.com/repos/fstab/client_java/contents/{+path}","compare_url":"https://api.github.com/repos/fstab/client_java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fstab/client_java/merges","archive_url":"https://api.github.com/repos/fstab/client_java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fstab/client_java/downloads","issues_url":"https://api.github.com/repos/fstab/client_java/issues{/number}","pulls_url":"https://api.github.com/repos/fstab/client_java/pulls{/number}","milestones_url":"https://api.github.com/repos/fstab/client_java/milestones{/number}","notifications_url":"https://api.github.com/repos/fstab/client_java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fstab/client_java/labels{/name}","releases_url":"https://api.github.com/repos/fstab/client_java/releases{/id}","deployments_url":"https://api.github.com/repos/fstab/client_java/deployments","created_at":"2016-08-01T14:15:41Z","updated_at":"2016-08-01T14:15:42Z","pushed_at":"2016-08-02T11:38:44Z","git_url":"git://github.com/fstab/client_java.git","ssh_url":"git@github.com:fstab/client_java.git","clone_url":"https://github.com/fstab/client_java.git","svn_url":"https://github.com/fstab/client_java","homepage":"","size":1767,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prometheus:master","ref":"master","sha":"ff3c8d7ef6c0879d6f643c938ed70488d8be8093","user":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"repo":{"id":7997879,"name":"client_java","full_name":"prometheus/client_java","owner":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prometheus/client_java","description":"Prometheus instrumentation library for JVM applications","fork":false,"url":"https://api.github.com/repos/prometheus/client_java","forks_url":"https://api.github.com/repos/prometheus/client_java/forks","keys_url":"https://api.github.com/repos/prometheus/client_java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prometheus/client_java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prometheus/client_java/teams","hooks_url":"https://api.github.com/repos/prometheus/client_java/hooks","issue_events_url":"https://api.github.com/repos/prometheus/client_java/issues/events{/number}","events_url":"https://api.github.com/repos/prometheus/client_java/events","assignees_url":"https://api.github.com/repos/prometheus/client_java/assignees{/user}","branches_url":"https://api.github.com/repos/prometheus/client_java/branches{/branch}","tags_url":"https://api.github.com/repos/prometheus/client_java/tags","blobs_url":"https://api.github.com/repos/prometheus/client_java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prometheus/client_java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prometheus/client_java/git/refs{/sha}","trees_url":"https://api.github.com/repos/prometheus/client_java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prometheus/client_java/statuses/{sha}","languages_url":"https://api.github.com/repos/prometheus/client_java/languages","stargazers_url":"https://api.github.com/repos/prometheus/client_java/stargazers","contributors_url":"https://api.github.com/repos/prometheus/client_java/contributors","subscribers_url":"https://api.github.com/repos/prometheus/client_java/subscribers","subscription_url":"https://api.github.com/repos/prometheus/client_java/subscription","commits_url":"https://api.github.com/repos/prometheus/client_java/commits{/sha}","git_commits_url":"https://api.github.com/repos/prometheus/client_java/git/commits{/sha}","comments_url":"https://api.github.com/repos/prometheus/client_java/comments{/number}","issue_comment_url":"https://api.github.com/repos/prometheus/client_java/issues/comments{/number}","contents_url":"https://api.github.com/repos/prometheus/client_java/contents/{+path}","compare_url":"https://api.github.com/repos/prometheus/client_java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prometheus/client_java/merges","archive_url":"https://api.github.com/repos/prometheus/client_java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prometheus/client_java/downloads","issues_url":"https://api.github.com/repos/prometheus/client_java/issues{/number}","pulls_url":"https://api.github.com/repos/prometheus/client_java/pulls{/number}","milestones_url":"https://api.github.com/repos/prometheus/client_java/milestones{/number}","notifications_url":"https://api.github.com/repos/prometheus/client_java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prometheus/client_java/labels{/name}","releases_url":"https://api.github.com/repos/prometheus/client_java/releases{/id}","deployments_url":"https://api.github.com/repos/prometheus/client_java/deployments","created_at":"2013-02-03T22:55:49Z","updated_at":"2016-08-02T06:23:51Z","pushed_at":"2016-08-02T11:38:44Z","git_url":"git://github.com/prometheus/client_java.git","ssh_url":"git@github.com:prometheus/client_java.git","clone_url":"https://github.com/prometheus/client_java.git","svn_url":"https://github.com/prometheus/client_java","homepage":"","size":1858,"stargazers_count":51,"watchers_count":51,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":58,"mirror_url":null,"open_issues_count":21,"forks":58,"open_issues":21,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prometheus/client_java/pulls/134"},"html":{"href":"https://github.com/prometheus/client_java/pull/134"},"issue":{"href":"https://api.github.com/repos/prometheus/client_java/issues/134"},"comments":{"href":"https://api.github.com/repos/prometheus/client_java/issues/134/comments"},"review_comments":{"href":"https://api.github.com/repos/prometheus/client_java/pulls/134/comments"},"review_comment":{"href":"https://api.github.com/repos/prometheus/client_java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prometheus/client_java/pulls/134/commits"},"statuses":{"href":"https://api.github.com/repos/prometheus/client_java/statuses/c4bc42c48906d9a0bb1d514e9c912051a7f3d9c7"}}}}
{"actor":{"display_login":"brian-brazil"}}