{"action":"created","comment":{"url":"https://api.github.com/repos/WebAudio/web-audio-api/pulls/comments/80537747","id":80537747,"diff_hunk":"@@ -1034,13 +1038,19 @@ <h2 id=\"BaseAudioContext\">\n               <li>In case of failure, queue a task on the <a>control thread</a>\n               to execute the following, and abort these steps\n                 <ol>\n+                  <li>Reject all promises from <a>pendingResumePromises</a> in\n+                  order, then clear <a>pendingResumePromises</a>.\n+                  </li>\n                   <li>Reject <em>promise</em>","path":"index.html","position":18,"original_position":18,"commit_id":"07b9b9e9eea93141ef6545a2453ec904eaa4f6ed","original_commit_id":"07b9b9e9eea93141ef6545a2453ec904eaa4f6ed","user":{"login":"rtoy","id":663356,"avatar_url":"https://avatars.githubusercontent.com/u/663356?v=3","gravatar_id":"","url":"https://api.github.com/users/rtoy","html_url":"https://github.com/rtoy","followers_url":"https://api.github.com/users/rtoy/followers","following_url":"https://api.github.com/users/rtoy/following{/other_user}","gists_url":"https://api.github.com/users/rtoy/gists{/gist_id}","starred_url":"https://api.github.com/users/rtoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtoy/subscriptions","organizations_url":"https://api.github.com/users/rtoy/orgs","repos_url":"https://api.github.com/users/rtoy/repos","events_url":"https://api.github.com/users/rtoy/events{/privacy}","received_events_url":"https://api.github.com/users/rtoy/received_events","type":"User","site_admin":false},"body":"This is a little confusing?  You've already added the promise to `pendingResumePromises` above because the context is not allowed to start.  So you reject the promise when handling `pendingResumePromises`, and then reject the promise again in this step.","created_at":"2016-09-26T18:14:39Z","updated_at":"2016-09-26T18:18:14Z","html_url":"https://github.com/WebAudio/web-audio-api/pull/991#discussion_r80537747","pull_request_url":"https://api.github.com/repos/WebAudio/web-audio-api/pulls/991","_links":{"self":{"href":"https://api.github.com/repos/WebAudio/web-audio-api/pulls/comments/80537747"},"html":{"href":"https://github.com/WebAudio/web-audio-api/pull/991#discussion_r80537747"},"pull_request":{"href":"https://api.github.com/repos/WebAudio/web-audio-api/pulls/991"}}},"pull_request":{"url":"https://api.github.com/repos/WebAudio/web-audio-api/pulls/991","id":86621284,"html_url":"https://github.com/WebAudio/web-audio-api/pull/991","diff_url":"https://github.com/WebAudio/web-audio-api/pull/991.diff","patch_url":"https://github.com/WebAudio/web-audio-api/pull/991.patch","issue_url":"https://api.github.com/repos/WebAudio/web-audio-api/issues/991","number":991,"state":"open","locked":false,"title":"Add a concept of 'allowed to start' and use it when creating an AudioContext and resuming it (closes #836).","user":{"login":"mounirlamouri","id":573590,"avatar_url":"https://avatars.githubusercontent.com/u/573590?v=3","gravatar_id":"","url":"https://api.github.com/users/mounirlamouri","html_url":"https://github.com/mounirlamouri","followers_url":"https://api.github.com/users/mounirlamouri/followers","following_url":"https://api.github.com/users/mounirlamouri/following{/other_user}","gists_url":"https://api.github.com/users/mounirlamouri/gists{/gist_id}","starred_url":"https://api.github.com/users/mounirlamouri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mounirlamouri/subscriptions","organizations_url":"https://api.github.com/users/mounirlamouri/orgs","repos_url":"https://api.github.com/users/mounirlamouri/repos","events_url":"https://api.github.com/users/mounirlamouri/events{/privacy}","received_events_url":"https://api.github.com/users/mounirlamouri/received_events","type":"User","site_admin":false},"body":"@rtoy and @padenot PTAL","created_at":"2016-09-24T15:37:38Z","updated_at":"2016-09-26T18:18:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"51c4365f927c3eaf20aafa57d97575530845553e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/WebAudio/web-audio-api/pulls/991/commits","review_comments_url":"https://api.github.com/repos/WebAudio/web-audio-api/pulls/991/comments","review_comment_url":"https://api.github.com/repos/WebAudio/web-audio-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WebAudio/web-audio-api/issues/991/comments","statuses_url":"https://api.github.com/repos/WebAudio/web-audio-api/statuses/07b9b9e9eea93141ef6545a2453ec904eaa4f6ed","head":{"label":"mounirlamouri:allowed-to-start","ref":"allowed-to-start","sha":"07b9b9e9eea93141ef6545a2453ec904eaa4f6ed","user":{"login":"mounirlamouri","id":573590,"avatar_url":"https://avatars.githubusercontent.com/u/573590?v=3","gravatar_id":"","url":"https://api.github.com/users/mounirlamouri","html_url":"https://github.com/mounirlamouri","followers_url":"https://api.github.com/users/mounirlamouri/followers","following_url":"https://api.github.com/users/mounirlamouri/following{/other_user}","gists_url":"https://api.github.com/users/mounirlamouri/gists{/gist_id}","starred_url":"https://api.github.com/users/mounirlamouri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mounirlamouri/subscriptions","organizations_url":"https://api.github.com/users/mounirlamouri/orgs","repos_url":"https://api.github.com/users/mounirlamouri/repos","events_url":"https://api.github.com/users/mounirlamouri/events{/privacy}","received_events_url":"https://api.github.com/users/mounirlamouri/received_events","type":"User","site_admin":false},"repo":{"id":69108736,"name":"web-audio-api","full_name":"mounirlamouri/web-audio-api","owner":{"login":"mounirlamouri","id":573590,"avatar_url":"https://avatars.githubusercontent.com/u/573590?v=3","gravatar_id":"","url":"https://api.github.com/users/mounirlamouri","html_url":"https://github.com/mounirlamouri","followers_url":"https://api.github.com/users/mounirlamouri/followers","following_url":"https://api.github.com/users/mounirlamouri/following{/other_user}","gists_url":"https://api.github.com/users/mounirlamouri/gists{/gist_id}","starred_url":"https://api.github.com/users/mounirlamouri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mounirlamouri/subscriptions","organizations_url":"https://api.github.com/users/mounirlamouri/orgs","repos_url":"https://api.github.com/users/mounirlamouri/repos","events_url":"https://api.github.com/users/mounirlamouri/events{/privacy}","received_events_url":"https://api.github.com/users/mounirlamouri/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mounirlamouri/web-audio-api","description":"The Web Audio API, developed by the W3C Audio WG","fork":true,"url":"https://api.github.com/repos/mounirlamouri/web-audio-api","forks_url":"https://api.github.com/repos/mounirlamouri/web-audio-api/forks","keys_url":"https://api.github.com/repos/mounirlamouri/web-audio-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mounirlamouri/web-audio-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mounirlamouri/web-audio-api/teams","hooks_url":"https://api.github.com/repos/mounirlamouri/web-audio-api/hooks","issue_events_url":"https://api.github.com/repos/mounirlamouri/web-audio-api/issues/events{/number}","events_url":"https://api.github.com/repos/mounirlamouri/web-audio-api/events","assignees_url":"https://api.github.com/repos/mounirlamouri/web-audio-api/assignees{/user}","branches_url":"https://api.github.com/repos/mounirlamouri/web-audio-api/branches{/branch}","tags_url":"https://api.github.com/repos/mounirlamouri/web-audio-api/tags","blobs_url":"https://api.github.com/repos/mounirlamouri/web-audio-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mounirlamouri/web-audio-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mounirlamouri/web-audio-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/mounirlamouri/web-audio-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mounirlamouri/web-audio-api/statuses/{sha}","languages_url":"https://api.github.com/repos/mounirlamouri/web-audio-api/languages","stargazers_url":"https://api.github.com/repos/mounirlamouri/web-audio-api/stargazers","contributors_url":"https://api.github.com/repos/mounirlamouri/web-audio-api/contributors","subscribers_url":"https://api.github.com/repos/mounirlamouri/web-audio-api/subscribers","subscription_url":"https://api.github.com/repos/mounirlamouri/web-audio-api/subscription","commits_url":"https://api.github.com/repos/mounirlamouri/web-audio-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/mounirlamouri/web-audio-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/mounirlamouri/web-audio-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/mounirlamouri/web-audio-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/mounirlamouri/web-audio-api/contents/{+path}","compare_url":"https://api.github.com/repos/mounirlamouri/web-audio-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mounirlamouri/web-audio-api/merges","archive_url":"https://api.github.com/repos/mounirlamouri/web-audio-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mounirlamouri/web-audio-api/downloads","issues_url":"https://api.github.com/repos/mounirlamouri/web-audio-api/issues{/number}","pulls_url":"https://api.github.com/repos/mounirlamouri/web-audio-api/pulls{/number}","milestones_url":"https://api.github.com/repos/mounirlamouri/web-audio-api/milestones{/number}","notifications_url":"https://api.github.com/repos/mounirlamouri/web-audio-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mounirlamouri/web-audio-api/labels{/name}","releases_url":"https://api.github.com/repos/mounirlamouri/web-audio-api/releases{/id}","deployments_url":"https://api.github.com/repos/mounirlamouri/web-audio-api/deployments","created_at":"2016-09-24T14:58:28Z","updated_at":"2016-09-24T14:58:29Z","pushed_at":"2016-09-26T15:57:21Z","git_url":"git://github.com/mounirlamouri/web-audio-api.git","ssh_url":"git@github.com:mounirlamouri/web-audio-api.git","clone_url":"https://github.com/mounirlamouri/web-audio-api.git","svn_url":"https://github.com/mounirlamouri/web-audio-api","homepage":"http://www.w3.org/2011/audio/wiki/","size":20625,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"gh-pages"}},"base":{"label":"WebAudio:gh-pages","ref":"gh-pages","sha":"894da33aee7257c17892d2e745378474faf1f71b","user":{"login":"WebAudio","id":3079689,"avatar_url":"https://avatars.githubusercontent.com/u/3079689?v=3","gravatar_id":"","url":"https://api.github.com/users/WebAudio","html_url":"https://github.com/WebAudio","followers_url":"https://api.github.com/users/WebAudio/followers","following_url":"https://api.github.com/users/WebAudio/following{/other_user}","gists_url":"https://api.github.com/users/WebAudio/gists{/gist_id}","starred_url":"https://api.github.com/users/WebAudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebAudio/subscriptions","organizations_url":"https://api.github.com/users/WebAudio/orgs","repos_url":"https://api.github.com/users/WebAudio/repos","events_url":"https://api.github.com/users/WebAudio/events{/privacy}","received_events_url":"https://api.github.com/users/WebAudio/received_events","type":"Organization","site_admin":false},"repo":{"id":12484936,"name":"web-audio-api","full_name":"WebAudio/web-audio-api","owner":{"login":"WebAudio","id":3079689,"avatar_url":"https://avatars.githubusercontent.com/u/3079689?v=3","gravatar_id":"","url":"https://api.github.com/users/WebAudio","html_url":"https://github.com/WebAudio","followers_url":"https://api.github.com/users/WebAudio/followers","following_url":"https://api.github.com/users/WebAudio/following{/other_user}","gists_url":"https://api.github.com/users/WebAudio/gists{/gist_id}","starred_url":"https://api.github.com/users/WebAudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebAudio/subscriptions","organizations_url":"https://api.github.com/users/WebAudio/orgs","repos_url":"https://api.github.com/users/WebAudio/repos","events_url":"https://api.github.com/users/WebAudio/events{/privacy}","received_events_url":"https://api.github.com/users/WebAudio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WebAudio/web-audio-api","description":"The Web Audio API, developed by the W3C Audio WG","fork":false,"url":"https://api.github.com/repos/WebAudio/web-audio-api","forks_url":"https://api.github.com/repos/WebAudio/web-audio-api/forks","keys_url":"https://api.github.com/repos/WebAudio/web-audio-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WebAudio/web-audio-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WebAudio/web-audio-api/teams","hooks_url":"https://api.github.com/repos/WebAudio/web-audio-api/hooks","issue_events_url":"https://api.github.com/repos/WebAudio/web-audio-api/issues/events{/number}","events_url":"https://api.github.com/repos/WebAudio/web-audio-api/events","assignees_url":"https://api.github.com/repos/WebAudio/web-audio-api/assignees{/user}","branches_url":"https://api.github.com/repos/WebAudio/web-audio-api/branches{/branch}","tags_url":"https://api.github.com/repos/WebAudio/web-audio-api/tags","blobs_url":"https://api.github.com/repos/WebAudio/web-audio-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WebAudio/web-audio-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WebAudio/web-audio-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/WebAudio/web-audio-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WebAudio/web-audio-api/statuses/{sha}","languages_url":"https://api.github.com/repos/WebAudio/web-audio-api/languages","stargazers_url":"https://api.github.com/repos/WebAudio/web-audio-api/stargazers","contributors_url":"https://api.github.com/repos/WebAudio/web-audio-api/contributors","subscribers_url":"https://api.github.com/repos/WebAudio/web-audio-api/subscribers","subscription_url":"https://api.github.com/repos/WebAudio/web-audio-api/subscription","commits_url":"https://api.github.com/repos/WebAudio/web-audio-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/WebAudio/web-audio-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/WebAudio/web-audio-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/WebAudio/web-audio-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/WebAudio/web-audio-api/contents/{+path}","compare_url":"https://api.github.com/repos/WebAudio/web-audio-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WebAudio/web-audio-api/merges","archive_url":"https://api.github.com/repos/WebAudio/web-audio-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WebAudio/web-audio-api/downloads","issues_url":"https://api.github.com/repos/WebAudio/web-audio-api/issues{/number}","pulls_url":"https://api.github.com/repos/WebAudio/web-audio-api/pulls{/number}","milestones_url":"https://api.github.com/repos/WebAudio/web-audio-api/milestones{/number}","notifications_url":"https://api.github.com/repos/WebAudio/web-audio-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WebAudio/web-audio-api/labels{/name}","releases_url":"https://api.github.com/repos/WebAudio/web-audio-api/releases{/id}","deployments_url":"https://api.github.com/repos/WebAudio/web-audio-api/deployments","created_at":"2013-08-30T11:29:49Z","updated_at":"2016-09-25T17:35:00Z","pushed_at":"2016-09-26T15:57:21Z","git_url":"git://github.com/WebAudio/web-audio-api.git","ssh_url":"git@github.com:WebAudio/web-audio-api.git","clone_url":"https://github.com/WebAudio/web-audio-api.git","svn_url":"https://github.com/WebAudio/web-audio-api","homepage":"http://www.w3.org/2011/audio/wiki/","size":22188,"stargazers_count":360,"watchers_count":360,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":74,"mirror_url":null,"open_issues_count":108,"forks":74,"open_issues":108,"watchers":360,"default_branch":"gh-pages"}},"_links":{"self":{"href":"https://api.github.com/repos/WebAudio/web-audio-api/pulls/991"},"html":{"href":"https://github.com/WebAudio/web-audio-api/pull/991"},"issue":{"href":"https://api.github.com/repos/WebAudio/web-audio-api/issues/991"},"comments":{"href":"https://api.github.com/repos/WebAudio/web-audio-api/issues/991/comments"},"review_comments":{"href":"https://api.github.com/repos/WebAudio/web-audio-api/pulls/991/comments"},"review_comment":{"href":"https://api.github.com/repos/WebAudio/web-audio-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WebAudio/web-audio-api/pulls/991/commits"},"statuses":{"href":"https://api.github.com/repos/WebAudio/web-audio-api/statuses/07b9b9e9eea93141ef6545a2453ec904eaa4f6ed"}}}}
{"actor":{"display_login":"rtoy"}}