{"push_id":1237401593,"size":7,"distinct_size":3,"ref":"refs/heads/fix/pr108-tests","head":"acb106d3772acc78f7f4c4ce9b3ea7a59ddea1cf","before":"e8317c60e85a093d129fec3839ebf0b8bd9455da","commits":[{"sha":"9ac92e4d8086958c87e368a2b549449f66b3c334","author":{"name":"Andy Boughton","email":"119de137a4172aca75f250ded880d8e263b1a913@gmail.com"},"message":"Bump i18n dependency version\n\nThis fixes an issue that broke addon-consuming apps that used ember 2.7. (ember internals were reorganized. See ember-i18n/issues/385","distinct":false,"url":"https://api.github.com/repos/abought/ember-osf/commits/9ac92e4d8086958c87e368a2b549449f66b3c334"},{"sha":"2f97faf87667591e6deeaf84a63c2d69f7e9c84f","author":{"name":"Andy Boughton","email":"0fa5198f277965b1dfce76ed3a8af90a7b1992bb@gmail.com"},"message":"Merge pull request #109 from abought/fix/i18n-bump-version\n\nBump i18n dependency version","distinct":false,"url":"https://api.github.com/repos/abought/ember-osf/commits/2f97faf87667591e6deeaf84a63c2d69f7e9c84f"},{"sha":"50ff1f14a3657584c7088bde13666bfce3d4d1b0","author":{"name":"Andy Boughton","email":"119de137a4172aca75f250ded880d8e263b1a913@gmail.com"},"message":"Fix error where cookie auth beforeModel hook failed\n\nWhen user was not logged in, beforeModel hook returned a rejected promise and failed. Catch that error and do nothing, so hook can pass through.\n(it just\n\nBeforeModel hook (and ember simple auth) expect an ember promise, but receives a jquery object. Massage the promise type so things work correctly.\n\n[#PREP-87]","distinct":false,"url":"https://api.github.com/repos/abought/ember-osf/commits/50ff1f14a3657584c7088bde13666bfce3d4d1b0"},{"sha":"642da90f02119ad4af5a4ba3cfac129962f96761","author":{"name":"Andy Boughton","email":"119de137a4172aca75f250ded880d8e263b1a913@gmail.com"},"message":"Quick hack: for cookie auth, let the user override the login button (via block component usage) with a button of their choosing.\n\n[#PREP-87]\n[ci skip]","distinct":false,"url":"https://api.github.com/repos/abought/ember-osf/commits/642da90f02119ad4af5a4ba3cfac129962f96761"},{"sha":"8c397df18bd2f444c9f6af2ded03577ce22297c1","author":{"name":"Andy Boughton","email":"0fa5198f277965b1dfce76ed3a8af90a7b1992bb@gmail.com"},"message":"Merge pull request #110 from abought/fix/prep87-auth-errors\n\nFix error where cookie auth beforeModel hook failed","distinct":true,"url":"https://api.github.com/repos/abought/ember-osf/commits/8c397df18bd2f444c9f6af2ded03577ce22297c1"},{"sha":"29584c2a4de36840cc345def6987565fde3ce504","author":{"name":"Andy Boughton","email":"119de137a4172aca75f250ded880d8e263b1a913@gmail.com"},"message":"Merge branch 'develop' of https://github.com/CenterForOpenScience/ember-osf into fix/pr108-tests","distinct":true,"url":"https://api.github.com/repos/abought/ember-osf/commits/29584c2a4de36840cc345def6987565fde3ce504"},{"sha":"acb106d3772acc78f7f4c4ce9b3ea7a59ddea1cf","author":{"name":"Andy Boughton","email":"119de137a4172aca75f250ded880d8e263b1a913@gmail.com"},"message":"Remove nice-to-have regression test because it doesn't work\n\nMaking this test work will require mocking out some calls, which is tricky because we have multiple uses of a method wrapped inside a single save() call. When we stub contributor.save completely, the test passes even on develop (because we're bypassing the very store manipulation that was causing the regression. This will require a different approach to how/what we mock, and contributors have some unique save rules layered on.\n\nSuggested future regression test:\n- Add a contributor\n- Then edit the contributor's permissions and commit the data. (in the OSF contribs page, this calls node.save). As of 8c397df18bd2f444c9f6af2ded03577ce22297c1, this should fail, but the same test should be expected to pass with this PR in place.\n\nThe failure was evidenced in the browser address bar, shown by a JS console error about `s.record` not being found.\n\n[#EOSF-136]","distinct":true,"url":"https://api.github.com/repos/abought/ember-osf/commits/acb106d3772acc78f7f4c4ce9b3ea7a59ddea1cf"}]}
{"actor":{"display_login":"abought"}}