{"action":"closed","number":12069,"pull_request":{"url":"https://api.github.com/repos/yiisoft/yii2/pulls/12069","id":79853524,"html_url":"https://github.com/yiisoft/yii2/pull/12069","diff_url":"https://github.com/yiisoft/yii2/pull/12069.diff","patch_url":"https://github.com/yiisoft/yii2/pull/12069.patch","issue_url":"https://api.github.com/repos/yiisoft/yii2/issues/12069","number":12069,"state":"closed","locked":false,"title":"Reverted fix of beforeValidate event calling in `yii.activeForm.js`","user":{"login":"SilverFire","id":4499203,"avatar_url":"https://avatars.githubusercontent.com/u/4499203?v=3","gravatar_id":"","url":"https://api.github.com/users/SilverFire","html_url":"https://github.com/SilverFire","followers_url":"https://api.github.com/users/SilverFire/followers","following_url":"https://api.github.com/users/SilverFire/following{/other_user}","gists_url":"https://api.github.com/users/SilverFire/gists{/gist_id}","starred_url":"https://api.github.com/users/SilverFire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SilverFire/subscriptions","organizations_url":"https://api.github.com/users/SilverFire/orgs","repos_url":"https://api.github.com/users/SilverFire/repos","events_url":"https://api.github.com/users/SilverFire/events{/privacy}","received_events_url":"https://api.github.com/users/SilverFire/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Is bugfix?    | yes\r\n| New feature?  | no\r\n| Breaks BC?    | yes (fixes)\r\n| Fixed issues  | #10681, #11972, probably #11992\r\n\r\nI'm reverting @lynicidn commit e8bcb93 because it introduces buggy behavior. The problem that was reported in #10681 is not a bug indeed.\r\n\r\n1. From the docs: \r\n> beforeValidate event is triggered before validating the whole form\r\n2. AJAX validation is being executed each time for all available inputs, but the result of AJAX validation will be used for each particular input only when it was touched at least once. It means, that each AJAX validation call does not mean full form validation.\r\n2. For Ajax validation we have `ajaxBeforeSend` and `ajaxComplete` events\r\n\r\n\r\n@nkovacs, @samdark, @githkim, @lynicidn - if you have something to add - feel free to text your ideas. Otherwise, the PR will be merged in 3 days.\r\n\r\nThank you\r\n","created_at":"2016-08-03T06:19:54Z","updated_at":"2016-08-05T10:56:42Z","closed_at":"2016-08-05T10:56:42Z","merged_at":"2016-08-05T10:56:42Z","merge_commit_sha":"418b27326c8753e1224080a958930550ff4d11ac","assignee":{"login":"SilverFire","id":4499203,"avatar_url":"https://avatars.githubusercontent.com/u/4499203?v=3","gravatar_id":"","url":"https://api.github.com/users/SilverFire","html_url":"https://github.com/SilverFire","followers_url":"https://api.github.com/users/SilverFire/followers","following_url":"https://api.github.com/users/SilverFire/following{/other_user}","gists_url":"https://api.github.com/users/SilverFire/gists{/gist_id}","starred_url":"https://api.github.com/users/SilverFire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SilverFire/subscriptions","organizations_url":"https://api.github.com/users/SilverFire/orgs","repos_url":"https://api.github.com/users/SilverFire/repos","events_url":"https://api.github.com/users/SilverFire/events{/privacy}","received_events_url":"https://api.github.com/users/SilverFire/received_events","type":"User","site_admin":false},"assignees":[{"login":"SilverFire","id":4499203,"avatar_url":"https://avatars.githubusercontent.com/u/4499203?v=3","gravatar_id":"","url":"https://api.github.com/users/SilverFire","html_url":"https://github.com/SilverFire","followers_url":"https://api.github.com/users/SilverFire/followers","following_url":"https://api.github.com/users/SilverFire/following{/other_user}","gists_url":"https://api.github.com/users/SilverFire/gists{/gist_id}","starred_url":"https://api.github.com/users/SilverFire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SilverFire/subscriptions","organizations_url":"https://api.github.com/users/SilverFire/orgs","repos_url":"https://api.github.com/users/SilverFire/repos","events_url":"https://api.github.com/users/SilverFire/events{/privacy}","received_events_url":"https://api.github.com/users/SilverFire/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/yiisoft/yii2/milestones/18","html_url":"https://github.com/yiisoft/yii2/milestones/2.0.10","labels_url":"https://api.github.com/repos/yiisoft/yii2/milestones/18/labels","id":1679982,"number":18,"title":"2.0.10","description":"","creator":{"login":"cebe","id":189796,"avatar_url":"https://avatars.githubusercontent.com/u/189796?v=3","gravatar_id":"","url":"https://api.github.com/users/cebe","html_url":"https://github.com/cebe","followers_url":"https://api.github.com/users/cebe/followers","following_url":"https://api.github.com/users/cebe/following{/other_user}","gists_url":"https://api.github.com/users/cebe/gists{/gist_id}","starred_url":"https://api.github.com/users/cebe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cebe/subscriptions","organizations_url":"https://api.github.com/users/cebe/orgs","repos_url":"https://api.github.com/users/cebe/repos","events_url":"https://api.github.com/users/cebe/events{/privacy}","received_events_url":"https://api.github.com/users/cebe/received_events","type":"User","site_admin":false},"open_issues":84,"closed_issues":36,"state":"open","created_at":"2016-04-03T04:39:22Z","updated_at":"2016-08-05T10:56:42Z","due_on":"2016-09-10T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/yiisoft/yii2/pulls/12069/commits","review_comments_url":"https://api.github.com/repos/yiisoft/yii2/pulls/12069/comments","review_comment_url":"https://api.github.com/repos/yiisoft/yii2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yiisoft/yii2/issues/12069/comments","statuses_url":"https://api.github.com/repos/yiisoft/yii2/statuses/ffb121ba63a9a19e70659dca8ea5b3193875c522","head":{"label":"SilverFire:12069-revert-activeform-validation","ref":"12069-revert-activeform-validation","sha":"ffb121ba63a9a19e70659dca8ea5b3193875c522","user":{"login":"SilverFire","id":4499203,"avatar_url":"https://avatars.githubusercontent.com/u/4499203?v=3","gravatar_id":"","url":"https://api.github.com/users/SilverFire","html_url":"https://github.com/SilverFire","followers_url":"https://api.github.com/users/SilverFire/followers","following_url":"https://api.github.com/users/SilverFire/following{/other_user}","gists_url":"https://api.github.com/users/SilverFire/gists{/gist_id}","starred_url":"https://api.github.com/users/SilverFire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SilverFire/subscriptions","organizations_url":"https://api.github.com/users/SilverFire/orgs","repos_url":"https://api.github.com/users/SilverFire/repos","events_url":"https://api.github.com/users/SilverFire/events{/privacy}","received_events_url":"https://api.github.com/users/SilverFire/received_events","type":"User","site_admin":false},"repo":{"id":31335145,"name":"yii2","full_name":"SilverFire/yii2","owner":{"login":"SilverFire","id":4499203,"avatar_url":"https://avatars.githubusercontent.com/u/4499203?v=3","gravatar_id":"","url":"https://api.github.com/users/SilverFire","html_url":"https://github.com/SilverFire","followers_url":"https://api.github.com/users/SilverFire/followers","following_url":"https://api.github.com/users/SilverFire/following{/other_user}","gists_url":"https://api.github.com/users/SilverFire/gists{/gist_id}","starred_url":"https://api.github.com/users/SilverFire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SilverFire/subscriptions","organizations_url":"https://api.github.com/users/SilverFire/orgs","repos_url":"https://api.github.com/users/SilverFire/repos","events_url":"https://api.github.com/users/SilverFire/events{/privacy}","received_events_url":"https://api.github.com/users/SilverFire/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SilverFire/yii2","description":"Yii 2 framework main development repo","fork":true,"url":"https://api.github.com/repos/SilverFire/yii2","forks_url":"https://api.github.com/repos/SilverFire/yii2/forks","keys_url":"https://api.github.com/repos/SilverFire/yii2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SilverFire/yii2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SilverFire/yii2/teams","hooks_url":"https://api.github.com/repos/SilverFire/yii2/hooks","issue_events_url":"https://api.github.com/repos/SilverFire/yii2/issues/events{/number}","events_url":"https://api.github.com/repos/SilverFire/yii2/events","assignees_url":"https://api.github.com/repos/SilverFire/yii2/assignees{/user}","branches_url":"https://api.github.com/repos/SilverFire/yii2/branches{/branch}","tags_url":"https://api.github.com/repos/SilverFire/yii2/tags","blobs_url":"https://api.github.com/repos/SilverFire/yii2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SilverFire/yii2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SilverFire/yii2/git/refs{/sha}","trees_url":"https://api.github.com/repos/SilverFire/yii2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SilverFire/yii2/statuses/{sha}","languages_url":"https://api.github.com/repos/SilverFire/yii2/languages","stargazers_url":"https://api.github.com/repos/SilverFire/yii2/stargazers","contributors_url":"https://api.github.com/repos/SilverFire/yii2/contributors","subscribers_url":"https://api.github.com/repos/SilverFire/yii2/subscribers","subscription_url":"https://api.github.com/repos/SilverFire/yii2/subscription","commits_url":"https://api.github.com/repos/SilverFire/yii2/commits{/sha}","git_commits_url":"https://api.github.com/repos/SilverFire/yii2/git/commits{/sha}","comments_url":"https://api.github.com/repos/SilverFire/yii2/comments{/number}","issue_comment_url":"https://api.github.com/repos/SilverFire/yii2/issues/comments{/number}","contents_url":"https://api.github.com/repos/SilverFire/yii2/contents/{+path}","compare_url":"https://api.github.com/repos/SilverFire/yii2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SilverFire/yii2/merges","archive_url":"https://api.github.com/repos/SilverFire/yii2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SilverFire/yii2/downloads","issues_url":"https://api.github.com/repos/SilverFire/yii2/issues{/number}","pulls_url":"https://api.github.com/repos/SilverFire/yii2/pulls{/number}","milestones_url":"https://api.github.com/repos/SilverFire/yii2/milestones{/number}","notifications_url":"https://api.github.com/repos/SilverFire/yii2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SilverFire/yii2/labels{/name}","releases_url":"https://api.github.com/repos/SilverFire/yii2/releases{/id}","deployments_url":"https://api.github.com/repos/SilverFire/yii2/deployments","created_at":"2015-02-25T20:50:16Z","updated_at":"2016-01-15T11:13:55Z","pushed_at":"2016-08-03T06:05:23Z","git_url":"git://github.com/SilverFire/yii2.git","ssh_url":"git@github.com:SilverFire/yii2.git","clone_url":"https://github.com/SilverFire/yii2.git","svn_url":"https://github.com/SilverFire/yii2","homepage":"http://www.yiiframework.com","size":38044,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yiisoft:master","ref":"master","sha":"1c65516153253e8a8084be2d9e5bce56febde95a","user":{"login":"yiisoft","id":993323,"avatar_url":"https://avatars.githubusercontent.com/u/993323?v=3","gravatar_id":"","url":"https://api.github.com/users/yiisoft","html_url":"https://github.com/yiisoft","followers_url":"https://api.github.com/users/yiisoft/followers","following_url":"https://api.github.com/users/yiisoft/following{/other_user}","gists_url":"https://api.github.com/users/yiisoft/gists{/gist_id}","starred_url":"https://api.github.com/users/yiisoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiisoft/subscriptions","organizations_url":"https://api.github.com/users/yiisoft/orgs","repos_url":"https://api.github.com/users/yiisoft/repos","events_url":"https://api.github.com/users/yiisoft/events{/privacy}","received_events_url":"https://api.github.com/users/yiisoft/received_events","type":"Organization","site_admin":false},"repo":{"id":3431193,"name":"yii2","full_name":"yiisoft/yii2","owner":{"login":"yiisoft","id":993323,"avatar_url":"https://avatars.githubusercontent.com/u/993323?v=3","gravatar_id":"","url":"https://api.github.com/users/yiisoft","html_url":"https://github.com/yiisoft","followers_url":"https://api.github.com/users/yiisoft/followers","following_url":"https://api.github.com/users/yiisoft/following{/other_user}","gists_url":"https://api.github.com/users/yiisoft/gists{/gist_id}","starred_url":"https://api.github.com/users/yiisoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiisoft/subscriptions","organizations_url":"https://api.github.com/users/yiisoft/orgs","repos_url":"https://api.github.com/users/yiisoft/repos","events_url":"https://api.github.com/users/yiisoft/events{/privacy}","received_events_url":"https://api.github.com/users/yiisoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yiisoft/yii2","description":"Yii 2 framework main development repo","fork":false,"url":"https://api.github.com/repos/yiisoft/yii2","forks_url":"https://api.github.com/repos/yiisoft/yii2/forks","keys_url":"https://api.github.com/repos/yiisoft/yii2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yiisoft/yii2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yiisoft/yii2/teams","hooks_url":"https://api.github.com/repos/yiisoft/yii2/hooks","issue_events_url":"https://api.github.com/repos/yiisoft/yii2/issues/events{/number}","events_url":"https://api.github.com/repos/yiisoft/yii2/events","assignees_url":"https://api.github.com/repos/yiisoft/yii2/assignees{/user}","branches_url":"https://api.github.com/repos/yiisoft/yii2/branches{/branch}","tags_url":"https://api.github.com/repos/yiisoft/yii2/tags","blobs_url":"https://api.github.com/repos/yiisoft/yii2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yiisoft/yii2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yiisoft/yii2/git/refs{/sha}","trees_url":"https://api.github.com/repos/yiisoft/yii2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yiisoft/yii2/statuses/{sha}","languages_url":"https://api.github.com/repos/yiisoft/yii2/languages","stargazers_url":"https://api.github.com/repos/yiisoft/yii2/stargazers","contributors_url":"https://api.github.com/repos/yiisoft/yii2/contributors","subscribers_url":"https://api.github.com/repos/yiisoft/yii2/subscribers","subscription_url":"https://api.github.com/repos/yiisoft/yii2/subscription","commits_url":"https://api.github.com/repos/yiisoft/yii2/commits{/sha}","git_commits_url":"https://api.github.com/repos/yiisoft/yii2/git/commits{/sha}","comments_url":"https://api.github.com/repos/yiisoft/yii2/comments{/number}","issue_comment_url":"https://api.github.com/repos/yiisoft/yii2/issues/comments{/number}","contents_url":"https://api.github.com/repos/yiisoft/yii2/contents/{+path}","compare_url":"https://api.github.com/repos/yiisoft/yii2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yiisoft/yii2/merges","archive_url":"https://api.github.com/repos/yiisoft/yii2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yiisoft/yii2/downloads","issues_url":"https://api.github.com/repos/yiisoft/yii2/issues{/number}","pulls_url":"https://api.github.com/repos/yiisoft/yii2/pulls{/number}","milestones_url":"https://api.github.com/repos/yiisoft/yii2/milestones{/number}","notifications_url":"https://api.github.com/repos/yiisoft/yii2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yiisoft/yii2/labels{/name}","releases_url":"https://api.github.com/repos/yiisoft/yii2/releases{/id}","deployments_url":"https://api.github.com/repos/yiisoft/yii2/deployments","created_at":"2012-02-13T15:32:36Z","updated_at":"2016-08-05T09:21:18Z","pushed_at":"2016-08-05T10:56:42Z","git_url":"git://github.com/yiisoft/yii2.git","ssh_url":"git@github.com:yiisoft/yii2.git","clone_url":"https://github.com/yiisoft/yii2.git","svn_url":"https://github.com/yiisoft/yii2","homepage":"http://www.yiiframework.com","size":60991,"stargazers_count":8532,"watchers_count":8532,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4978,"mirror_url":null,"open_issues_count":1040,"forks":4978,"open_issues":1040,"watchers":8532,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/12069"},"html":{"href":"https://github.com/yiisoft/yii2/pull/12069"},"issue":{"href":"https://api.github.com/repos/yiisoft/yii2/issues/12069"},"comments":{"href":"https://api.github.com/repos/yiisoft/yii2/issues/12069/comments"},"review_comments":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/12069/comments"},"review_comment":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/12069/commits"},"statuses":{"href":"https://api.github.com/repos/yiisoft/yii2/statuses/ffb121ba63a9a19e70659dca8ea5b3193875c522"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"SilverFire","id":4499203,"avatar_url":"https://avatars.githubusercontent.com/u/4499203?v=3","gravatar_id":"","url":"https://api.github.com/users/SilverFire","html_url":"https://github.com/SilverFire","followers_url":"https://api.github.com/users/SilverFire/followers","following_url":"https://api.github.com/users/SilverFire/following{/other_user}","gists_url":"https://api.github.com/users/SilverFire/gists{/gist_id}","starred_url":"https://api.github.com/users/SilverFire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SilverFire/subscriptions","organizations_url":"https://api.github.com/users/SilverFire/orgs","repos_url":"https://api.github.com/users/SilverFire/repos","events_url":"https://api.github.com/users/SilverFire/events{/privacy}","received_events_url":"https://api.github.com/users/SilverFire/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":1,"additions":4,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"SilverFire"}}