{"action":"created","comment":{"url":"https://api.github.com/repos/lede-project/source/pulls/comments/81695835","pull_request_review_id":2656749,"id":81695835,"diff_hunk":"@@ -1,34 +1,41 @@\n #!/bin/sh\n+# Copyright (C) 2016 Henryk Heisig hyniu@o2.pl\n \n . /lib/functions/leds.sh\n . /lib/ipq806x.sh\n \n-get_status_led() {\n-\tcase $(ipq806x_board_name) in\n-\tc2600)\n-\t\tstatus_led=\"c2600:blue:status\"\n-\t\t;;\n-\tea8500)\n-\t\tstatus_led=\"ea8500:white:power\"\n-\t\t;;\n-\tesac\n-}\n+boot=\"$(ipq806x_get_dt_led_chosen boot)\"\n+failsafe=\"$(ipq806x_get_dt_led_chosen failsafe)\"\n+running=\"$(ipq806x_get_dt_led_chosen running)\"\n+upgrade=\"$(ipq806x_get_dt_led_chosen upgrade)\"\n \n set_state() {\n-\tget_status_led\n+\tstatus_led=\"$boot\"\n \n \tcase \"$1\" in\n \tpreinit)\n \t\tstatus_led_blink_preinit\n \t\t;;\n \tfailsafe)\n+\t\tstatus_led_off\n+\t\tstatus_led=\"$failsafe\"\n \t\tstatus_led_blink_failsafe\n \t\t;;\n \tpreinit_regular)\n \t\tstatus_led_blink_preinit_regular\n \t\t;;\n+\tupgrade)\n+\t\t[ -n \"$running\" ] & {\n+\t\t\tstatus_led=\"$upgrade\"","path":"target/linux/ipq806x/base-files/etc/diag.sh","position":40,"original_position":40,"commit_id":"6203d20d2f1c989ffdc43ebf6f49489a63014f9a","original_commit_id":"ab265802977f2d888d52d171effe57f6bcdb11da","user":{"login":"mkresin","id":4547948,"avatar_url":"https://avatars.githubusercontent.com/u/4547948?v=3","gravatar_id":"","url":"https://api.github.com/users/mkresin","html_url":"https://github.com/mkresin","followers_url":"https://api.github.com/users/mkresin/followers","following_url":"https://api.github.com/users/mkresin/following{/other_user}","gists_url":"https://api.github.com/users/mkresin/gists{/gist_id}","starred_url":"https://api.github.com/users/mkresin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkresin/subscriptions","organizations_url":"https://api.github.com/users/mkresin/orgs","repos_url":"https://api.github.com/users/mkresin/repos","events_url":"https://api.github.com/users/mkresin/events{/privacy}","received_events_url":"https://api.github.com/users/mkresin/received_events","type":"User","site_admin":false},"body":"It have to. Same typo that I've introduced with my lantiq patch back in the time...","created_at":"2016-10-04T07:04:01Z","updated_at":"2016-10-04T07:04:02Z","html_url":"https://github.com/lede-project/source/pull/359#discussion_r81695835","pull_request_url":"https://api.github.com/repos/lede-project/source/pulls/359","_links":{"self":{"href":"https://api.github.com/repos/lede-project/source/pulls/comments/81695835"},"html":{"href":"https://github.com/lede-project/source/pull/359#discussion_r81695835"},"pull_request":{"href":"https://api.github.com/repos/lede-project/source/pulls/359"}}},"pull_request":{"url":"https://api.github.com/repos/lede-project/source/pulls/359","id":87556433,"html_url":"https://github.com/lede-project/source/pull/359","diff_url":"https://github.com/lede-project/source/pull/359.diff","patch_url":"https://github.com/lede-project/source/pull/359.patch","issue_url":"https://api.github.com/repos/lede-project/source/issues/359","number":359,"state":"open","locked":false,"title":"ipq806x: add support for indicating the boot and upgrade state using four leds 2","user":{"login":"heinzek","id":19577155,"avatar_url":"https://avatars.githubusercontent.com/u/19577155?v=3","gravatar_id":"","url":"https://api.github.com/users/heinzek","html_url":"https://github.com/heinzek","followers_url":"https://api.github.com/users/heinzek/followers","following_url":"https://api.github.com/users/heinzek/following{/other_user}","gists_url":"https://api.github.com/users/heinzek/gists{/gist_id}","starred_url":"https://api.github.com/users/heinzek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heinzek/subscriptions","organizations_url":"https://api.github.com/users/heinzek/orgs","repos_url":"https://api.github.com/users/heinzek/repos","events_url":"https://api.github.com/users/heinzek/events{/privacy}","received_events_url":"https://api.github.com/users/heinzek/received_events","type":"User","site_admin":false},"body":"Tested on Archer C2600.\r\n\r\nSigned-off-by: Henryk Heisig hyniu@o2.pl","created_at":"2016-09-30T19:57:13Z","updated_at":"2016-10-04T07:04:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"536bb450640cfd8f6717a615adebe702672907c7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/lede-project/source/pulls/359/commits","review_comments_url":"https://api.github.com/repos/lede-project/source/pulls/359/comments","review_comment_url":"https://api.github.com/repos/lede-project/source/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lede-project/source/issues/359/comments","statuses_url":"https://api.github.com/repos/lede-project/source/statuses/6203d20d2f1c989ffdc43ebf6f49489a63014f9a","head":{"label":"heinzek:ipq","ref":"ipq","sha":"6203d20d2f1c989ffdc43ebf6f49489a63014f9a","user":{"login":"heinzek","id":19577155,"avatar_url":"https://avatars.githubusercontent.com/u/19577155?v=3","gravatar_id":"","url":"https://api.github.com/users/heinzek","html_url":"https://github.com/heinzek","followers_url":"https://api.github.com/users/heinzek/followers","following_url":"https://api.github.com/users/heinzek/following{/other_user}","gists_url":"https://api.github.com/users/heinzek/gists{/gist_id}","starred_url":"https://api.github.com/users/heinzek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heinzek/subscriptions","organizations_url":"https://api.github.com/users/heinzek/orgs","repos_url":"https://api.github.com/users/heinzek/repos","events_url":"https://api.github.com/users/heinzek/events{/privacy}","received_events_url":"https://api.github.com/users/heinzek/received_events","type":"User","site_admin":false},"repo":{"id":69122878,"name":"source","full_name":"heinzek/source","owner":{"login":"heinzek","id":19577155,"avatar_url":"https://avatars.githubusercontent.com/u/19577155?v=3","gravatar_id":"","url":"https://api.github.com/users/heinzek","html_url":"https://github.com/heinzek","followers_url":"https://api.github.com/users/heinzek/followers","following_url":"https://api.github.com/users/heinzek/following{/other_user}","gists_url":"https://api.github.com/users/heinzek/gists{/gist_id}","starred_url":"https://api.github.com/users/heinzek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heinzek/subscriptions","organizations_url":"https://api.github.com/users/heinzek/orgs","repos_url":"https://api.github.com/users/heinzek/repos","events_url":"https://api.github.com/users/heinzek/events{/privacy}","received_events_url":"https://api.github.com/users/heinzek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/heinzek/source","description":"Mirror of https://git.lede-project.org/?p=source.git Please send your PRs against this tree. They will be merged via staging trees and appear in this tree once the staging trees get merged back into source.git","fork":true,"url":"https://api.github.com/repos/heinzek/source","forks_url":"https://api.github.com/repos/heinzek/source/forks","keys_url":"https://api.github.com/repos/heinzek/source/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heinzek/source/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heinzek/source/teams","hooks_url":"https://api.github.com/repos/heinzek/source/hooks","issue_events_url":"https://api.github.com/repos/heinzek/source/issues/events{/number}","events_url":"https://api.github.com/repos/heinzek/source/events","assignees_url":"https://api.github.com/repos/heinzek/source/assignees{/user}","branches_url":"https://api.github.com/repos/heinzek/source/branches{/branch}","tags_url":"https://api.github.com/repos/heinzek/source/tags","blobs_url":"https://api.github.com/repos/heinzek/source/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heinzek/source/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heinzek/source/git/refs{/sha}","trees_url":"https://api.github.com/repos/heinzek/source/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heinzek/source/statuses/{sha}","languages_url":"https://api.github.com/repos/heinzek/source/languages","stargazers_url":"https://api.github.com/repos/heinzek/source/stargazers","contributors_url":"https://api.github.com/repos/heinzek/source/contributors","subscribers_url":"https://api.github.com/repos/heinzek/source/subscribers","subscription_url":"https://api.github.com/repos/heinzek/source/subscription","commits_url":"https://api.github.com/repos/heinzek/source/commits{/sha}","git_commits_url":"https://api.github.com/repos/heinzek/source/git/commits{/sha}","comments_url":"https://api.github.com/repos/heinzek/source/comments{/number}","issue_comment_url":"https://api.github.com/repos/heinzek/source/issues/comments{/number}","contents_url":"https://api.github.com/repos/heinzek/source/contents/{+path}","compare_url":"https://api.github.com/repos/heinzek/source/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heinzek/source/merges","archive_url":"https://api.github.com/repos/heinzek/source/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heinzek/source/downloads","issues_url":"https://api.github.com/repos/heinzek/source/issues{/number}","pulls_url":"https://api.github.com/repos/heinzek/source/pulls{/number}","milestones_url":"https://api.github.com/repos/heinzek/source/milestones{/number}","notifications_url":"https://api.github.com/repos/heinzek/source/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heinzek/source/labels{/name}","releases_url":"https://api.github.com/repos/heinzek/source/releases{/id}","deployments_url":"https://api.github.com/repos/heinzek/source/deployments","created_at":"2016-09-24T19:23:34Z","updated_at":"2016-09-24T19:23:51Z","pushed_at":"2016-10-02T20:23:37Z","git_url":"git://github.com/heinzek/source.git","ssh_url":"git@github.com:heinzek/source.git","clone_url":"https://github.com/heinzek/source.git","svn_url":"https://github.com/heinzek/source","homepage":"","size":128777,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lede-project:master","ref":"master","sha":"ba1024b9c921db36df2eae0ebb8adf5b648d4882","user":{"login":"lede-project","id":18146401,"avatar_url":"https://avatars.githubusercontent.com/u/18146401?v=3","gravatar_id":"","url":"https://api.github.com/users/lede-project","html_url":"https://github.com/lede-project","followers_url":"https://api.github.com/users/lede-project/followers","following_url":"https://api.github.com/users/lede-project/following{/other_user}","gists_url":"https://api.github.com/users/lede-project/gists{/gist_id}","starred_url":"https://api.github.com/users/lede-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lede-project/subscriptions","organizations_url":"https://api.github.com/users/lede-project/orgs","repos_url":"https://api.github.com/users/lede-project/repos","events_url":"https://api.github.com/users/lede-project/events{/privacy}","received_events_url":"https://api.github.com/users/lede-project/received_events","type":"Organization","site_admin":false},"repo":{"id":58552470,"name":"source","full_name":"lede-project/source","owner":{"login":"lede-project","id":18146401,"avatar_url":"https://avatars.githubusercontent.com/u/18146401?v=3","gravatar_id":"","url":"https://api.github.com/users/lede-project","html_url":"https://github.com/lede-project","followers_url":"https://api.github.com/users/lede-project/followers","following_url":"https://api.github.com/users/lede-project/following{/other_user}","gists_url":"https://api.github.com/users/lede-project/gists{/gist_id}","starred_url":"https://api.github.com/users/lede-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lede-project/subscriptions","organizations_url":"https://api.github.com/users/lede-project/orgs","repos_url":"https://api.github.com/users/lede-project/repos","events_url":"https://api.github.com/users/lede-project/events{/privacy}","received_events_url":"https://api.github.com/users/lede-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lede-project/source","description":"Mirror of https://git.lede-project.org/?p=source.git Please send your PRs against this tree. They will be merged via staging trees and appear in this tree once the staging trees get merged back into source.git","fork":false,"url":"https://api.github.com/repos/lede-project/source","forks_url":"https://api.github.com/repos/lede-project/source/forks","keys_url":"https://api.github.com/repos/lede-project/source/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lede-project/source/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lede-project/source/teams","hooks_url":"https://api.github.com/repos/lede-project/source/hooks","issue_events_url":"https://api.github.com/repos/lede-project/source/issues/events{/number}","events_url":"https://api.github.com/repos/lede-project/source/events","assignees_url":"https://api.github.com/repos/lede-project/source/assignees{/user}","branches_url":"https://api.github.com/repos/lede-project/source/branches{/branch}","tags_url":"https://api.github.com/repos/lede-project/source/tags","blobs_url":"https://api.github.com/repos/lede-project/source/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lede-project/source/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lede-project/source/git/refs{/sha}","trees_url":"https://api.github.com/repos/lede-project/source/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lede-project/source/statuses/{sha}","languages_url":"https://api.github.com/repos/lede-project/source/languages","stargazers_url":"https://api.github.com/repos/lede-project/source/stargazers","contributors_url":"https://api.github.com/repos/lede-project/source/contributors","subscribers_url":"https://api.github.com/repos/lede-project/source/subscribers","subscription_url":"https://api.github.com/repos/lede-project/source/subscription","commits_url":"https://api.github.com/repos/lede-project/source/commits{/sha}","git_commits_url":"https://api.github.com/repos/lede-project/source/git/commits{/sha}","comments_url":"https://api.github.com/repos/lede-project/source/comments{/number}","issue_comment_url":"https://api.github.com/repos/lede-project/source/issues/comments{/number}","contents_url":"https://api.github.com/repos/lede-project/source/contents/{+path}","compare_url":"https://api.github.com/repos/lede-project/source/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lede-project/source/merges","archive_url":"https://api.github.com/repos/lede-project/source/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lede-project/source/downloads","issues_url":"https://api.github.com/repos/lede-project/source/issues{/number}","pulls_url":"https://api.github.com/repos/lede-project/source/pulls{/number}","milestones_url":"https://api.github.com/repos/lede-project/source/milestones{/number}","notifications_url":"https://api.github.com/repos/lede-project/source/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lede-project/source/labels{/name}","releases_url":"https://api.github.com/repos/lede-project/source/releases{/id}","deployments_url":"https://api.github.com/repos/lede-project/source/deployments","created_at":"2016-05-11T14:31:34Z","updated_at":"2016-10-02T09:26:27Z","pushed_at":"2016-10-04T04:04:45Z","git_url":"git://github.com/lede-project/source.git","ssh_url":"git@github.com:lede-project/source.git","clone_url":"https://github.com/lede-project/source.git","svn_url":"https://github.com/lede-project/source","homepage":"","size":144442,"stargazers_count":267,"watchers_count":267,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":156,"mirror_url":null,"open_issues_count":22,"forks":156,"open_issues":22,"watchers":267,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lede-project/source/pulls/359"},"html":{"href":"https://github.com/lede-project/source/pull/359"},"issue":{"href":"https://api.github.com/repos/lede-project/source/issues/359"},"comments":{"href":"https://api.github.com/repos/lede-project/source/issues/359/comments"},"review_comments":{"href":"https://api.github.com/repos/lede-project/source/pulls/359/comments"},"review_comment":{"href":"https://api.github.com/repos/lede-project/source/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lede-project/source/pulls/359/commits"},"statuses":{"href":"https://api.github.com/repos/lede-project/source/statuses/6203d20d2f1c989ffdc43ebf6f49489a63014f9a"}}}}
{"actor":{"display_login":"mkresin"}}