{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/83953664","pull_request_review_id":4763267,"id":83953664,"diff_hunk":"@@ -1488,6 +1488,13 @@ bool AppInit2(boost::thread_group& threadGroup, CScheduler& scheduler)\n         uiInterface.NotifyBlockTip.disconnect(BlockNotifyGenesisWait);\n     }\n \n+#ifdef ENABLE_WALLET","path":"src/init.cpp","position":4,"original_position":4,"commit_id":"37aefff5fcf7169a1b07ff8939850f630640f7e7","original_commit_id":"37aefff5fcf7169a1b07ff8939850f630640f7e7","user":{"login":"laanwj","id":126646,"avatar_url":"https://avatars.githubusercontent.com/u/126646?v=3","gravatar_id":"","url":"https://api.github.com/users/laanwj","html_url":"https://github.com/laanwj","followers_url":"https://api.github.com/users/laanwj/followers","following_url":"https://api.github.com/users/laanwj/following{/other_user}","gists_url":"https://api.github.com/users/laanwj/gists{/gist_id}","starred_url":"https://api.github.com/users/laanwj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laanwj/subscriptions","organizations_url":"https://api.github.com/users/laanwj/orgs","repos_url":"https://api.github.com/users/laanwj/repos","events_url":"https://api.github.com/users/laanwj/events{/privacy}","received_events_url":"https://api.github.com/users/laanwj/received_events","type":"User","site_admin":false},"body":"It's unfortunate that this has to introduce a new `#ifdef ENABLE_WALLET` here, and ref to pWalletMain.\r\nWe're trying to get rid of them to remove the circular dependency between` _wallet` and `_server` libs (#7965), and in the interest of multi-wallet support.","created_at":"2016-10-18T21:21:37Z","updated_at":"2016-10-18T21:21:37Z","html_url":"https://github.com/bitcoin/bitcoin/pull/8928#discussion_r83953664","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8928","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/83953664"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/8928#discussion_r83953664"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8928"}}},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8928","id":89499884,"html_url":"https://github.com/bitcoin/bitcoin/pull/8928","diff_url":"https://github.com/bitcoin/bitcoin/pull/8928.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/8928.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8928","number":8928,"state":"open","locked":false,"title":"Fix init segfault where InitLoadWallet() calls ATMP before genesis","user":{"login":"TheBlueMatt","id":649246,"avatar_url":"https://avatars.githubusercontent.com/u/649246?v=3","gravatar_id":"","url":"https://api.github.com/users/TheBlueMatt","html_url":"https://github.com/TheBlueMatt","followers_url":"https://api.github.com/users/TheBlueMatt/followers","following_url":"https://api.github.com/users/TheBlueMatt/following{/other_user}","gists_url":"https://api.github.com/users/TheBlueMatt/gists{/gist_id}","starred_url":"https://api.github.com/users/TheBlueMatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheBlueMatt/subscriptions","organizations_url":"https://api.github.com/users/TheBlueMatt/orgs","repos_url":"https://api.github.com/users/TheBlueMatt/repos","events_url":"https://api.github.com/users/TheBlueMatt/events{/privacy}","received_events_url":"https://api.github.com/users/TheBlueMatt/received_events","type":"User","site_admin":false},"body":"I honestly have no idea how the wallet.py tests are passing for anyone, but they reliably cause segfault here for me.","created_at":"2016-10-15T17:21:07Z","updated_at":"2016-10-18T21:21:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"47f5e4cd93e0f1e4c1b47eef67b5f8b47d61f189","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8928/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8928/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8928/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/37aefff5fcf7169a1b07ff8939850f630640f7e7","head":{"label":"TheBlueMatt:2016-10-fix-segfault","ref":"2016-10-fix-segfault","sha":"37aefff5fcf7169a1b07ff8939850f630640f7e7","user":{"login":"TheBlueMatt","id":649246,"avatar_url":"https://avatars.githubusercontent.com/u/649246?v=3","gravatar_id":"","url":"https://api.github.com/users/TheBlueMatt","html_url":"https://github.com/TheBlueMatt","followers_url":"https://api.github.com/users/TheBlueMatt/followers","following_url":"https://api.github.com/users/TheBlueMatt/following{/other_user}","gists_url":"https://api.github.com/users/TheBlueMatt/gists{/gist_id}","starred_url":"https://api.github.com/users/TheBlueMatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheBlueMatt/subscriptions","organizations_url":"https://api.github.com/users/TheBlueMatt/orgs","repos_url":"https://api.github.com/users/TheBlueMatt/repos","events_url":"https://api.github.com/users/TheBlueMatt/events{/privacy}","received_events_url":"https://api.github.com/users/TheBlueMatt/received_events","type":"User","site_admin":false},"repo":{"id":1443291,"name":"bitcoin","full_name":"TheBlueMatt/bitcoin","owner":{"login":"TheBlueMatt","id":649246,"avatar_url":"https://avatars.githubusercontent.com/u/649246?v=3","gravatar_id":"","url":"https://api.github.com/users/TheBlueMatt","html_url":"https://github.com/TheBlueMatt","followers_url":"https://api.github.com/users/TheBlueMatt/followers","following_url":"https://api.github.com/users/TheBlueMatt/following{/other_user}","gists_url":"https://api.github.com/users/TheBlueMatt/gists{/gist_id}","starred_url":"https://api.github.com/users/TheBlueMatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheBlueMatt/subscriptions","organizations_url":"https://api.github.com/users/TheBlueMatt/orgs","repos_url":"https://api.github.com/users/TheBlueMatt/repos","events_url":"https://api.github.com/users/TheBlueMatt/events{/privacy}","received_events_url":"https://api.github.com/users/TheBlueMatt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TheBlueMatt/bitcoin","description":"Bitcoin (dont fork from here, fork from bitcoin/bitcoin)","fork":true,"url":"https://api.github.com/repos/TheBlueMatt/bitcoin","forks_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/forks","keys_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/teams","hooks_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/events","assignees_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/tags","blobs_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/languages","stargazers_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/subscription","commits_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/merges","archive_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/downloads","issues_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/deployments","created_at":"2011-03-05T14:14:49Z","updated_at":"2016-06-20T06:00:29Z","pushed_at":"2016-10-18T20:56:57Z","git_url":"git://github.com/TheBlueMatt/bitcoin.git","ssh_url":"git@github.com:TheBlueMatt/bitcoin.git","clone_url":"https://github.com/TheBlueMatt/bitcoin.git","svn_url":"https://github.com/TheBlueMatt/bitcoin","homepage":"http://www.bitcoin.org/","size":78766,"stargazers_count":11,"watchers_count":11,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":11,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"49c5910372899a365fd6b57b9e227518e24541fa","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2016-10-18T20:03:26Z","pushed_at":"2016-10-18T20:59:59Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":157575,"stargazers_count":10173,"watchers_count":10173,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":6747,"mirror_url":null,"open_issues_count":515,"forks":6747,"open_issues":515,"watchers":10173,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8928"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/8928"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/8928"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/8928/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8928/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8928/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/37aefff5fcf7169a1b07ff8939850f630640f7e7"}}}}
{"actor":{"display_login":"laanwj"}}