{"action":"created","issue":{"url":"https://api.github.com/repos/eslint/eslint/issues/5398","repository_url":"https://api.github.com/repos/eslint/eslint","labels_url":"https://api.github.com/repos/eslint/eslint/issues/5398/labels{/name}","comments_url":"https://api.github.com/repos/eslint/eslint/issues/5398/comments","events_url":"https://api.github.com/repos/eslint/eslint/issues/5398/events","html_url":"https://github.com/eslint/eslint/pull/5398","id":136463099,"number":5398,"title":"Update: Exclude ES5 constructors from consistent-return (fixes #5379)","user":{"login":"kevinoid","id":336433,"avatar_url":"https://avatars.githubusercontent.com/u/336433?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinoid","html_url":"https://github.com/kevinoid","followers_url":"https://api.github.com/users/kevinoid/followers","following_url":"https://api.github.com/users/kevinoid/following{/other_user}","gists_url":"https://api.github.com/users/kevinoid/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinoid/subscriptions","organizations_url":"https://api.github.com/users/kevinoid/orgs","repos_url":"https://api.github.com/users/kevinoid/repos","events_url":"https://api.github.com/users/kevinoid/events{/privacy}","received_events_url":"https://api.github.com/users/kevinoid/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/eslint/eslint/labels/cla%20found","name":"cla found","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-02-25T17:57:59Z","updated_at":"2016-02-25T20:14:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/eslint/eslint/pulls/5398","html_url":"https://github.com/eslint/eslint/pull/5398","diff_url":"https://github.com/eslint/eslint/pull/5398.diff","patch_url":"https://github.com/eslint/eslint/pull/5398.patch"},"body":"This PR makes the change requested in #5379 using the implementation outlined by @mysticatea in https://github.com/eslint/eslint/issues/5379#issuecomment-187997133 as I understood it.  If it missed the mark, please let me know and I'll update it.\r\n\r\nIt makes the exclusion of constructors unconditional, as it is for `no-invalid-this`.  If an option for conditional exclusion would be preferable, let me know what you'd prefer for name and behavior.\r\n\r\nNote: This commit also exposes `isES5Constructor` from `ast-utils` so that it can be used by `consistent-return`.  If that is inappropriate or should be handled differently, let me know.\r\n\r\nThanks for considering,\r\nKevin"},"comment":{"url":"https://api.github.com/repos/eslint/eslint/issues/comments/188960333","html_url":"https://github.com/eslint/eslint/pull/5398#issuecomment-188960333","issue_url":"https://api.github.com/repos/eslint/eslint/issues/5398","id":188960333,"user":{"login":"kevinoid","id":336433,"avatar_url":"https://avatars.githubusercontent.com/u/336433?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinoid","html_url":"https://github.com/kevinoid","followers_url":"https://api.github.com/users/kevinoid/followers","following_url":"https://api.github.com/users/kevinoid/following{/other_user}","gists_url":"https://api.github.com/users/kevinoid/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinoid/subscriptions","organizations_url":"https://api.github.com/users/kevinoid/orgs","repos_url":"https://api.github.com/users/kevinoid/repos","events_url":"https://api.github.com/users/kevinoid/events{/privacy}","received_events_url":"https://api.github.com/users/kevinoid/received_events","type":"User","site_admin":false},"created_at":"2016-02-25T20:14:33Z","updated_at":"2016-02-25T20:14:33Z","body":"Great.  Thanks for the review and feedback @ilyavolodin!"}}