{"action":"closed","number":385,"pull_request":{"url":"https://api.github.com/repos/tumblr/colossus/pulls/385","id":69409106,"html_url":"https://github.com/tumblr/colossus/pull/385","diff_url":"https://github.com/tumblr/colossus/pull/385.diff","patch_url":"https://github.com/tumblr/colossus/pull/385.patch","issue_url":"https://api.github.com/repos/tumblr/colossus/issues/385","number":385,"state":"closed","locked":false,"title":"Connection handler config","user":{"login":"nsauro","id":2262111,"avatar_url":"https://avatars.githubusercontent.com/u/2262111?v=3","gravatar_id":"","url":"https://api.github.com/users/nsauro","html_url":"https://github.com/nsauro","followers_url":"https://api.github.com/users/nsauro/followers","following_url":"https://api.github.com/users/nsauro/following{/other_user}","gists_url":"https://api.github.com/users/nsauro/gists{/gist_id}","starred_url":"https://api.github.com/users/nsauro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsauro/subscriptions","organizations_url":"https://api.github.com/users/nsauro/orgs","repos_url":"https://api.github.com/users/nsauro/repos","events_url":"https://api.github.com/users/nsauro/events{/privacy}","received_events_url":"https://api.github.com/users/nsauro/received_events","type":"User","site_admin":false},"body":"A few things here:\r\n\r\n- ServiceConfig can now be loaded from configuration sources.  It's values are nested in `colossus.server.connection-handler`.\r\n- Service metrics are added to `colossus.metrics`, so that they can be loaded at runtime.\r\n- `DataSize` got a bit of love:\r\n  - Added the ability to create one from a String(needed for config loading)\r\n  - Added an unapply for pattern matching\r\n  - Added some implicit objects to make it smell a bit like Durations ie: `1.KB`.  This was there before, but each invocation would create multiple instances.  This can be backed out if there is any strong resistance.  (Mainly b/c after I did this, I realized that it already existed by way of the existing implicit and instance functions 🙈  )\r\n\r\nNote:  There is now naming ambiguity in this branch. ConnectionHandlers are called, well, ConnectionHandlers and/or Service.  This PR doesn't help this at all.  We should make a full name change on this pretty quickly to clean up this ambiguity.  I'm fine with doing in this branch, or saving it for another.","created_at":"2016-05-09T20:54:16Z","updated_at":"2016-05-11T13:44:45Z","closed_at":"2016-05-11T13:44:45Z","merged_at":"2016-05-11T13:44:45Z","merge_commit_sha":"879e6b1761b5413e28c7568396aa5a9401953c57","assignee":null,"milestone":{"url":"https://api.github.com/repos/tumblr/colossus/milestones/25","html_url":"https://github.com/tumblr/colossus/milestones/0.8.0","labels_url":"https://api.github.com/repos/tumblr/colossus/milestones/25/labels","id":1427821,"number":25,"title":"0.8.0","description":"","creator":{"login":"DanSimon","id":287961,"avatar_url":"https://avatars.githubusercontent.com/u/287961?v=3","gravatar_id":"","url":"https://api.github.com/users/DanSimon","html_url":"https://github.com/DanSimon","followers_url":"https://api.github.com/users/DanSimon/followers","following_url":"https://api.github.com/users/DanSimon/following{/other_user}","gists_url":"https://api.github.com/users/DanSimon/gists{/gist_id}","starred_url":"https://api.github.com/users/DanSimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanSimon/subscriptions","organizations_url":"https://api.github.com/users/DanSimon/orgs","repos_url":"https://api.github.com/users/DanSimon/repos","events_url":"https://api.github.com/users/DanSimon/events{/privacy}","received_events_url":"https://api.github.com/users/DanSimon/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":14,"state":"open","created_at":"2015-11-24T18:24:01Z","updated_at":"2016-05-11T13:44:45Z","due_on":"2016-05-20T04:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/tumblr/colossus/pulls/385/commits","review_comments_url":"https://api.github.com/repos/tumblr/colossus/pulls/385/comments","review_comment_url":"https://api.github.com/repos/tumblr/colossus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tumblr/colossus/issues/385/comments","statuses_url":"https://api.github.com/repos/tumblr/colossus/statuses/803e8dada96c0b2514152c2deb136db29105d8ea","head":{"label":"tumblr:connetion_handler_config","ref":"connetion_handler_config","sha":"803e8dada96c0b2514152c2deb136db29105d8ea","user":{"login":"tumblr","id":366151,"avatar_url":"https://avatars.githubusercontent.com/u/366151?v=3","gravatar_id":"","url":"https://api.github.com/users/tumblr","html_url":"https://github.com/tumblr","followers_url":"https://api.github.com/users/tumblr/followers","following_url":"https://api.github.com/users/tumblr/following{/other_user}","gists_url":"https://api.github.com/users/tumblr/gists{/gist_id}","starred_url":"https://api.github.com/users/tumblr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tumblr/subscriptions","organizations_url":"https://api.github.com/users/tumblr/orgs","repos_url":"https://api.github.com/users/tumblr/repos","events_url":"https://api.github.com/users/tumblr/events{/privacy}","received_events_url":"https://api.github.com/users/tumblr/received_events","type":"Organization","site_admin":false},"repo":{"id":26492586,"name":"colossus","full_name":"tumblr/colossus","owner":{"login":"tumblr","id":366151,"avatar_url":"https://avatars.githubusercontent.com/u/366151?v=3","gravatar_id":"","url":"https://api.github.com/users/tumblr","html_url":"https://github.com/tumblr","followers_url":"https://api.github.com/users/tumblr/followers","following_url":"https://api.github.com/users/tumblr/following{/other_user}","gists_url":"https://api.github.com/users/tumblr/gists{/gist_id}","starred_url":"https://api.github.com/users/tumblr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tumblr/subscriptions","organizations_url":"https://api.github.com/users/tumblr/orgs","repos_url":"https://api.github.com/users/tumblr/repos","events_url":"https://api.github.com/users/tumblr/events{/privacy}","received_events_url":"https://api.github.com/users/tumblr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tumblr/colossus","description":"I/O and Microservice library for Scala","fork":false,"url":"https://api.github.com/repos/tumblr/colossus","forks_url":"https://api.github.com/repos/tumblr/colossus/forks","keys_url":"https://api.github.com/repos/tumblr/colossus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tumblr/colossus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tumblr/colossus/teams","hooks_url":"https://api.github.com/repos/tumblr/colossus/hooks","issue_events_url":"https://api.github.com/repos/tumblr/colossus/issues/events{/number}","events_url":"https://api.github.com/repos/tumblr/colossus/events","assignees_url":"https://api.github.com/repos/tumblr/colossus/assignees{/user}","branches_url":"https://api.github.com/repos/tumblr/colossus/branches{/branch}","tags_url":"https://api.github.com/repos/tumblr/colossus/tags","blobs_url":"https://api.github.com/repos/tumblr/colossus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tumblr/colossus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tumblr/colossus/git/refs{/sha}","trees_url":"https://api.github.com/repos/tumblr/colossus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tumblr/colossus/statuses/{sha}","languages_url":"https://api.github.com/repos/tumblr/colossus/languages","stargazers_url":"https://api.github.com/repos/tumblr/colossus/stargazers","contributors_url":"https://api.github.com/repos/tumblr/colossus/contributors","subscribers_url":"https://api.github.com/repos/tumblr/colossus/subscribers","subscription_url":"https://api.github.com/repos/tumblr/colossus/subscription","commits_url":"https://api.github.com/repos/tumblr/colossus/commits{/sha}","git_commits_url":"https://api.github.com/repos/tumblr/colossus/git/commits{/sha}","comments_url":"https://api.github.com/repos/tumblr/colossus/comments{/number}","issue_comment_url":"https://api.github.com/repos/tumblr/colossus/issues/comments{/number}","contents_url":"https://api.github.com/repos/tumblr/colossus/contents/{+path}","compare_url":"https://api.github.com/repos/tumblr/colossus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tumblr/colossus/merges","archive_url":"https://api.github.com/repos/tumblr/colossus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tumblr/colossus/downloads","issues_url":"https://api.github.com/repos/tumblr/colossus/issues{/number}","pulls_url":"https://api.github.com/repos/tumblr/colossus/pulls{/number}","milestones_url":"https://api.github.com/repos/tumblr/colossus/milestones{/number}","notifications_url":"https://api.github.com/repos/tumblr/colossus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tumblr/colossus/labels{/name}","releases_url":"https://api.github.com/repos/tumblr/colossus/releases{/id}","deployments_url":"https://api.github.com/repos/tumblr/colossus/deployments","created_at":"2014-11-11T16:06:06Z","updated_at":"2016-05-06T10:59:03Z","pushed_at":"2016-05-11T13:44:45Z","git_url":"git://github.com/tumblr/colossus.git","ssh_url":"git@github.com:tumblr/colossus.git","clone_url":"https://github.com/tumblr/colossus.git","svn_url":"https://github.com/tumblr/colossus","homepage":"","size":6229,"stargazers_count":768,"watchers_count":768,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":66,"mirror_url":null,"open_issues_count":23,"forks":66,"open_issues":23,"watchers":768,"default_branch":"master"}},"base":{"label":"tumblr:develop","ref":"develop","sha":"a233bf4e85347734255e08f87bdc015837259833","user":{"login":"tumblr","id":366151,"avatar_url":"https://avatars.githubusercontent.com/u/366151?v=3","gravatar_id":"","url":"https://api.github.com/users/tumblr","html_url":"https://github.com/tumblr","followers_url":"https://api.github.com/users/tumblr/followers","following_url":"https://api.github.com/users/tumblr/following{/other_user}","gists_url":"https://api.github.com/users/tumblr/gists{/gist_id}","starred_url":"https://api.github.com/users/tumblr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tumblr/subscriptions","organizations_url":"https://api.github.com/users/tumblr/orgs","repos_url":"https://api.github.com/users/tumblr/repos","events_url":"https://api.github.com/users/tumblr/events{/privacy}","received_events_url":"https://api.github.com/users/tumblr/received_events","type":"Organization","site_admin":false},"repo":{"id":26492586,"name":"colossus","full_name":"tumblr/colossus","owner":{"login":"tumblr","id":366151,"avatar_url":"https://avatars.githubusercontent.com/u/366151?v=3","gravatar_id":"","url":"https://api.github.com/users/tumblr","html_url":"https://github.com/tumblr","followers_url":"https://api.github.com/users/tumblr/followers","following_url":"https://api.github.com/users/tumblr/following{/other_user}","gists_url":"https://api.github.com/users/tumblr/gists{/gist_id}","starred_url":"https://api.github.com/users/tumblr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tumblr/subscriptions","organizations_url":"https://api.github.com/users/tumblr/orgs","repos_url":"https://api.github.com/users/tumblr/repos","events_url":"https://api.github.com/users/tumblr/events{/privacy}","received_events_url":"https://api.github.com/users/tumblr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tumblr/colossus","description":"I/O and Microservice library for Scala","fork":false,"url":"https://api.github.com/repos/tumblr/colossus","forks_url":"https://api.github.com/repos/tumblr/colossus/forks","keys_url":"https://api.github.com/repos/tumblr/colossus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tumblr/colossus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tumblr/colossus/teams","hooks_url":"https://api.github.com/repos/tumblr/colossus/hooks","issue_events_url":"https://api.github.com/repos/tumblr/colossus/issues/events{/number}","events_url":"https://api.github.com/repos/tumblr/colossus/events","assignees_url":"https://api.github.com/repos/tumblr/colossus/assignees{/user}","branches_url":"https://api.github.com/repos/tumblr/colossus/branches{/branch}","tags_url":"https://api.github.com/repos/tumblr/colossus/tags","blobs_url":"https://api.github.com/repos/tumblr/colossus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tumblr/colossus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tumblr/colossus/git/refs{/sha}","trees_url":"https://api.github.com/repos/tumblr/colossus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tumblr/colossus/statuses/{sha}","languages_url":"https://api.github.com/repos/tumblr/colossus/languages","stargazers_url":"https://api.github.com/repos/tumblr/colossus/stargazers","contributors_url":"https://api.github.com/repos/tumblr/colossus/contributors","subscribers_url":"https://api.github.com/repos/tumblr/colossus/subscribers","subscription_url":"https://api.github.com/repos/tumblr/colossus/subscription","commits_url":"https://api.github.com/repos/tumblr/colossus/commits{/sha}","git_commits_url":"https://api.github.com/repos/tumblr/colossus/git/commits{/sha}","comments_url":"https://api.github.com/repos/tumblr/colossus/comments{/number}","issue_comment_url":"https://api.github.com/repos/tumblr/colossus/issues/comments{/number}","contents_url":"https://api.github.com/repos/tumblr/colossus/contents/{+path}","compare_url":"https://api.github.com/repos/tumblr/colossus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tumblr/colossus/merges","archive_url":"https://api.github.com/repos/tumblr/colossus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tumblr/colossus/downloads","issues_url":"https://api.github.com/repos/tumblr/colossus/issues{/number}","pulls_url":"https://api.github.com/repos/tumblr/colossus/pulls{/number}","milestones_url":"https://api.github.com/repos/tumblr/colossus/milestones{/number}","notifications_url":"https://api.github.com/repos/tumblr/colossus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tumblr/colossus/labels{/name}","releases_url":"https://api.github.com/repos/tumblr/colossus/releases{/id}","deployments_url":"https://api.github.com/repos/tumblr/colossus/deployments","created_at":"2014-11-11T16:06:06Z","updated_at":"2016-05-06T10:59:03Z","pushed_at":"2016-05-11T13:44:45Z","git_url":"git://github.com/tumblr/colossus.git","ssh_url":"git@github.com:tumblr/colossus.git","clone_url":"https://github.com/tumblr/colossus.git","svn_url":"https://github.com/tumblr/colossus","homepage":"","size":6229,"stargazers_count":768,"watchers_count":768,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":66,"mirror_url":null,"open_issues_count":23,"forks":66,"open_issues":23,"watchers":768,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tumblr/colossus/pulls/385"},"html":{"href":"https://github.com/tumblr/colossus/pull/385"},"issue":{"href":"https://api.github.com/repos/tumblr/colossus/issues/385"},"comments":{"href":"https://api.github.com/repos/tumblr/colossus/issues/385/comments"},"review_comments":{"href":"https://api.github.com/repos/tumblr/colossus/pulls/385/comments"},"review_comment":{"href":"https://api.github.com/repos/tumblr/colossus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tumblr/colossus/pulls/385/commits"},"statuses":{"href":"https://api.github.com/repos/tumblr/colossus/statuses/803e8dada96c0b2514152c2deb136db29105d8ea"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"nsauro","id":2262111,"avatar_url":"https://avatars.githubusercontent.com/u/2262111?v=3","gravatar_id":"","url":"https://api.github.com/users/nsauro","html_url":"https://github.com/nsauro","followers_url":"https://api.github.com/users/nsauro/followers","following_url":"https://api.github.com/users/nsauro/following{/other_user}","gists_url":"https://api.github.com/users/nsauro/gists{/gist_id}","starred_url":"https://api.github.com/users/nsauro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsauro/subscriptions","organizations_url":"https://api.github.com/users/nsauro/orgs","repos_url":"https://api.github.com/users/nsauro/repos","events_url":"https://api.github.com/users/nsauro/events{/privacy}","received_events_url":"https://api.github.com/users/nsauro/received_events","type":"User","site_admin":false},"comments":1,"review_comments":2,"commits":4,"additions":181,"deletions":93,"changed_files":13}}