{"action":"created","comment":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments/73260220","id":73260220,"diff_hunk":"@@ -0,0 +1,39 @@\n+/*\n+ * Minecraft Forge\n+ * Copyright (c) 2016.\n+ *\n+ * This library is free software; you can redistribute it and/or\n+ * modify it under the terms of the GNU Lesser General Public\n+ * License as published by the Free Software Foundation version 2.1\n+ * of the License.\n+ *\n+ * This library is distributed in the hope that it will be useful,\n+ * but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU\n+ * Lesser General Public License for more details.\n+ *\n+ * You should have received a copy of the GNU Lesser General Public\n+ * License along with this library; if not, write to the Free Software\n+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA\n+ */\n+\n+package net.minecraftforge.server.permission;\n+\n+import com.mojang.authlib.GameProfile;\n+import net.minecraft.server.MinecraftServer;\n+import net.minecraftforge.fml.common.FMLCommonHandler;\n+\n+import javax.annotation.ParametersAreNonnullByDefault;\n+\n+@ParametersAreNonnullByDefault\n+public enum DefaultPermissionHandler implements IPermissionHandler\n+{\n+    INSTANCE;\n+\n+    @Override\n+    public boolean hasPermission(GameProfile profile, String permission, boolean defaultForPlayer, Context context)\n+    {\n+        MinecraftServer server = FMLCommonHandler.instance().getMinecraftServerInstance();\n+        return defaultForPlayer || server == null || !server.isDedicatedServer() || server.getPlayerList().getOppedPlayers().getPermissionLevel(profile) > 0;","path":"src/main/java/net/minecraftforge/server/permission/DefaultPermissionHandler.java","position":37,"original_position":37,"commit_id":"24c547b105bf7ea699670d8dabf859c44d35670a","original_commit_id":"24c547b105bf7ea699670d8dabf859c44d35670a","user":{"login":"LatvianModder","id":3844385,"avatar_url":"https://avatars.githubusercontent.com/u/3844385?v=3","gravatar_id":"","url":"https://api.github.com/users/LatvianModder","html_url":"https://github.com/LatvianModder","followers_url":"https://api.github.com/users/LatvianModder/followers","following_url":"https://api.github.com/users/LatvianModder/following{/other_user}","gists_url":"https://api.github.com/users/LatvianModder/gists{/gist_id}","starred_url":"https://api.github.com/users/LatvianModder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LatvianModder/subscriptions","organizations_url":"https://api.github.com/users/LatvianModder/orgs","repos_url":"https://api.github.com/users/LatvianModder/repos","events_url":"https://api.github.com/users/LatvianModder/events{/privacy}","received_events_url":"https://api.github.com/users/LatvianModder/received_events","type":"User","site_admin":false},"body":"That's the plan. In LAN, you probably won't try to setup ranks or restrict your friends from doing anything. Because its LAN. You could just yell at them or smth","created_at":"2016-08-02T23:58:57Z","updated_at":"2016-08-02T23:58:57Z","html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/3155#discussion_r73260220","pull_request_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/3155","_links":{"self":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments/73260220"},"html":{"href":"https://github.com/MinecraftForge/MinecraftForge/pull/3155#discussion_r73260220"},"pull_request":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/3155"}}},"pull_request":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/3155","id":79825081,"html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/3155","diff_url":"https://github.com/MinecraftForge/MinecraftForge/pull/3155.diff","patch_url":"https://github.com/MinecraftForge/MinecraftForge/pull/3155.patch","issue_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/3155","number":3155,"state":"open","locked":false,"title":"Added PermissionAPI","user":{"login":"LatvianModder","id":3844385,"avatar_url":"https://avatars.githubusercontent.com/u/3844385?v=3","gravatar_id":"","url":"https://api.github.com/users/LatvianModder","html_url":"https://github.com/LatvianModder","followers_url":"https://api.github.com/users/LatvianModder/followers","following_url":"https://api.github.com/users/LatvianModder/following{/other_user}","gists_url":"https://api.github.com/users/LatvianModder/gists{/gist_id}","starred_url":"https://api.github.com/users/LatvianModder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LatvianModder/subscriptions","organizations_url":"https://api.github.com/users/LatvianModder/orgs","repos_url":"https://api.github.com/users/LatvianModder/repos","events_url":"https://api.github.com/users/LatvianModder/events{/privacy}","received_events_url":"https://api.github.com/users/LatvianModder/received_events","type":"User","site_admin":false},"body":"Closes #2899\r\nThis PermissionAPI was designed based on this issue\r\n\r\nDoesn't need a registry: ✓\r\nCan be merged with current version and doesn't need any existing code changed: ✓\r\n\r\nhttps://github.com/MinecraftForge/MinecraftForge/issues/2899#issuecomment-221765300\r\nContext that essentially is a Map of String:Object: ✓\r\n\r\nhttps://github.com/MinecraftForge/MinecraftForge/issues/2899#issuecomment-221297416\r\nShould only be available from the server: ✓\r\nBuiltin system should be an abstract layer: ✓","created_at":"2016-08-02T23:16:18Z","updated_at":"2016-08-02T23:58:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"638ce9fe56c8af932cdeb8296fbde374e74cbd19","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/3155/commits","review_comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/3155/comments","review_comment_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/3155/comments","statuses_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/24c547b105bf7ea699670d8dabf859c44d35670a","head":{"label":"LatvianModder:permissions","ref":"permissions","sha":"24c547b105bf7ea699670d8dabf859c44d35670a","user":{"login":"LatvianModder","id":3844385,"avatar_url":"https://avatars.githubusercontent.com/u/3844385?v=3","gravatar_id":"","url":"https://api.github.com/users/LatvianModder","html_url":"https://github.com/LatvianModder","followers_url":"https://api.github.com/users/LatvianModder/followers","following_url":"https://api.github.com/users/LatvianModder/following{/other_user}","gists_url":"https://api.github.com/users/LatvianModder/gists{/gist_id}","starred_url":"https://api.github.com/users/LatvianModder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LatvianModder/subscriptions","organizations_url":"https://api.github.com/users/LatvianModder/orgs","repos_url":"https://api.github.com/users/LatvianModder/repos","events_url":"https://api.github.com/users/LatvianModder/events{/privacy}","received_events_url":"https://api.github.com/users/LatvianModder/received_events","type":"User","site_admin":false},"repo":{"id":64758584,"name":"MinecraftForge","full_name":"LatvianModder/MinecraftForge","owner":{"login":"LatvianModder","id":3844385,"avatar_url":"https://avatars.githubusercontent.com/u/3844385?v=3","gravatar_id":"","url":"https://api.github.com/users/LatvianModder","html_url":"https://github.com/LatvianModder","followers_url":"https://api.github.com/users/LatvianModder/followers","following_url":"https://api.github.com/users/LatvianModder/following{/other_user}","gists_url":"https://api.github.com/users/LatvianModder/gists{/gist_id}","starred_url":"https://api.github.com/users/LatvianModder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LatvianModder/subscriptions","organizations_url":"https://api.github.com/users/LatvianModder/orgs","repos_url":"https://api.github.com/users/LatvianModder/repos","events_url":"https://api.github.com/users/LatvianModder/events{/privacy}","received_events_url":"https://api.github.com/users/LatvianModder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LatvianModder/MinecraftForge","description":"Modifications to the Minecraft base files to assist in compatibility between mods.","fork":true,"url":"https://api.github.com/repos/LatvianModder/MinecraftForge","forks_url":"https://api.github.com/repos/LatvianModder/MinecraftForge/forks","keys_url":"https://api.github.com/repos/LatvianModder/MinecraftForge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LatvianModder/MinecraftForge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LatvianModder/MinecraftForge/teams","hooks_url":"https://api.github.com/repos/LatvianModder/MinecraftForge/hooks","issue_events_url":"https://api.github.com/repos/LatvianModder/MinecraftForge/issues/events{/number}","events_url":"https://api.github.com/repos/LatvianModder/MinecraftForge/events","assignees_url":"https://api.github.com/repos/LatvianModder/MinecraftForge/assignees{/user}","branches_url":"https://api.github.com/repos/LatvianModder/MinecraftForge/branches{/branch}","tags_url":"https://api.github.com/repos/LatvianModder/MinecraftForge/tags","blobs_url":"https://api.github.com/repos/LatvianModder/MinecraftForge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LatvianModder/MinecraftForge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LatvianModder/MinecraftForge/git/refs{/sha}","trees_url":"https://api.github.com/repos/LatvianModder/MinecraftForge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LatvianModder/MinecraftForge/statuses/{sha}","languages_url":"https://api.github.com/repos/LatvianModder/MinecraftForge/languages","stargazers_url":"https://api.github.com/repos/LatvianModder/MinecraftForge/stargazers","contributors_url":"https://api.github.com/repos/LatvianModder/MinecraftForge/contributors","subscribers_url":"https://api.github.com/repos/LatvianModder/MinecraftForge/subscribers","subscription_url":"https://api.github.com/repos/LatvianModder/MinecraftForge/subscription","commits_url":"https://api.github.com/repos/LatvianModder/MinecraftForge/commits{/sha}","git_commits_url":"https://api.github.com/repos/LatvianModder/MinecraftForge/git/commits{/sha}","comments_url":"https://api.github.com/repos/LatvianModder/MinecraftForge/comments{/number}","issue_comment_url":"https://api.github.com/repos/LatvianModder/MinecraftForge/issues/comments{/number}","contents_url":"https://api.github.com/repos/LatvianModder/MinecraftForge/contents/{+path}","compare_url":"https://api.github.com/repos/LatvianModder/MinecraftForge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LatvianModder/MinecraftForge/merges","archive_url":"https://api.github.com/repos/LatvianModder/MinecraftForge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LatvianModder/MinecraftForge/downloads","issues_url":"https://api.github.com/repos/LatvianModder/MinecraftForge/issues{/number}","pulls_url":"https://api.github.com/repos/LatvianModder/MinecraftForge/pulls{/number}","milestones_url":"https://api.github.com/repos/LatvianModder/MinecraftForge/milestones{/number}","notifications_url":"https://api.github.com/repos/LatvianModder/MinecraftForge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LatvianModder/MinecraftForge/labels{/name}","releases_url":"https://api.github.com/repos/LatvianModder/MinecraftForge/releases{/id}","deployments_url":"https://api.github.com/repos/LatvianModder/MinecraftForge/deployments","created_at":"2016-08-02T13:20:32Z","updated_at":"2016-08-02T13:55:10Z","pushed_at":"2016-08-02T23:46:54Z","git_url":"git://github.com/LatvianModder/MinecraftForge.git","ssh_url":"git@github.com:LatvianModder/MinecraftForge.git","clone_url":"https://github.com/LatvianModder/MinecraftForge.git","svn_url":"https://github.com/LatvianModder/MinecraftForge","homepage":"","size":87888,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"permissions"}},"base":{"label":"MinecraftForge:1.10.x","ref":"1.10.x","sha":"7c4ffde39cbc4f7ddcf30b2d3ad591af673a89de","user":{"login":"MinecraftForge","id":1390178,"avatar_url":"https://avatars.githubusercontent.com/u/1390178?v=3","gravatar_id":"","url":"https://api.github.com/users/MinecraftForge","html_url":"https://github.com/MinecraftForge","followers_url":"https://api.github.com/users/MinecraftForge/followers","following_url":"https://api.github.com/users/MinecraftForge/following{/other_user}","gists_url":"https://api.github.com/users/MinecraftForge/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecraftForge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecraftForge/subscriptions","organizations_url":"https://api.github.com/users/MinecraftForge/orgs","repos_url":"https://api.github.com/users/MinecraftForge/repos","events_url":"https://api.github.com/users/MinecraftForge/events{/privacy}","received_events_url":"https://api.github.com/users/MinecraftForge/received_events","type":"Organization","site_admin":false},"repo":{"id":3301400,"name":"MinecraftForge","full_name":"MinecraftForge/MinecraftForge","owner":{"login":"MinecraftForge","id":1390178,"avatar_url":"https://avatars.githubusercontent.com/u/1390178?v=3","gravatar_id":"","url":"https://api.github.com/users/MinecraftForge","html_url":"https://github.com/MinecraftForge","followers_url":"https://api.github.com/users/MinecraftForge/followers","following_url":"https://api.github.com/users/MinecraftForge/following{/other_user}","gists_url":"https://api.github.com/users/MinecraftForge/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecraftForge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecraftForge/subscriptions","organizations_url":"https://api.github.com/users/MinecraftForge/orgs","repos_url":"https://api.github.com/users/MinecraftForge/repos","events_url":"https://api.github.com/users/MinecraftForge/events{/privacy}","received_events_url":"https://api.github.com/users/MinecraftForge/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MinecraftForge/MinecraftForge","description":"Modifications to the Minecraft base files to assist in compatibility between mods.","fork":false,"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge","forks_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/forks","keys_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/teams","hooks_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/hooks","issue_events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/events{/number}","events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/events","assignees_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/assignees{/user}","branches_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/branches{/branch}","tags_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/tags","blobs_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/refs{/sha}","trees_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/{sha}","languages_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/languages","stargazers_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/stargazers","contributors_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/contributors","subscribers_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/subscribers","subscription_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/subscription","commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/commits{/sha}","git_commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/commits{/sha}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/comments{/number}","issue_comment_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/comments{/number}","contents_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/contents/{+path}","compare_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/merges","archive_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/downloads","issues_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues{/number}","pulls_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls{/number}","milestones_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/milestones{/number}","notifications_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/labels{/name}","releases_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/releases{/id}","deployments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/deployments","created_at":"2012-01-30T01:35:01Z","updated_at":"2016-07-31T19:02:01Z","pushed_at":"2016-08-02T23:46:55Z","git_url":"git://github.com/MinecraftForge/MinecraftForge.git","ssh_url":"git@github.com:MinecraftForge/MinecraftForge.git","clone_url":"https://github.com/MinecraftForge/MinecraftForge.git","svn_url":"https://github.com/MinecraftForge/MinecraftForge","homepage":"","size":152945,"stargazers_count":1485,"watchers_count":1485,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":812,"mirror_url":null,"open_issues_count":254,"forks":812,"open_issues":254,"watchers":1485,"default_branch":"1.10.x"}},"_links":{"self":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/3155"},"html":{"href":"https://github.com/MinecraftForge/MinecraftForge/pull/3155"},"issue":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/3155"},"comments":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/3155/comments"},"review_comments":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/3155/comments"},"review_comment":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/3155/commits"},"statuses":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/24c547b105bf7ea699670d8dabf859c44d35670a"}}}}
{"actor":{"display_login":"LatvianModder"}}