{"action":"created","comment":{"url":"https://api.github.com/repos/rhq-project/rhq/pulls/comments/66794261","id":66794261,"diff_hunk":"@@ -109,6 +109,7 @@ public void onFailure(Throwable throwable) {\n \n                         private void createAndAddConfigurationEditor(ConfigurationDefinition def) {\n                             editor = new ConfigurationEditor(def, startingConfig);\n+                            editor.enableMapValidations(true);","path":"modules/enterprise/gui/coregui/src/main/java/org/rhq/coregui/client/inventory/resource/factory/ResourceFactoryConfigurationStep.java","position":13,"original_position":13,"commit_id":"cbcc869abc0631b37dd9064d5dc9fbdb29076a66","original_commit_id":"cbcc869abc0631b37dd9064d5dc9fbdb29076a66","user":{"login":"rubenvp8510","id":3799716,"avatar_url":"https://avatars.githubusercontent.com/u/3799716?v=3","gravatar_id":"","url":"https://api.github.com/users/rubenvp8510","html_url":"https://github.com/rubenvp8510","followers_url":"https://api.github.com/users/rubenvp8510/followers","following_url":"https://api.github.com/users/rubenvp8510/following{/other_user}","gists_url":"https://api.github.com/users/rubenvp8510/gists{/gist_id}","starred_url":"https://api.github.com/users/rubenvp8510/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubenvp8510/subscriptions","organizations_url":"https://api.github.com/users/rubenvp8510/orgs","repos_url":"https://api.github.com/users/rubenvp8510/repos","events_url":"https://api.github.com/users/rubenvp8510/events{/privacy}","received_events_url":"https://api.github.com/users/rubenvp8510/received_events","type":"User","site_admin":false},"body":"The thing is, that component is used in a lot of parts of the UI, I just did it  as a precaution, trying to minimize the impact on the other parts of the code, but you're right probably I should remove it. I tested as far as I could and it seems that all works well.","created_at":"2016-06-13T13:51:15Z","updated_at":"2016-06-13T13:51:15Z","html_url":"https://github.com/rhq-project/rhq/pull/267#discussion_r66794261","pull_request_url":"https://api.github.com/repos/rhq-project/rhq/pulls/267","_links":{"self":{"href":"https://api.github.com/repos/rhq-project/rhq/pulls/comments/66794261"},"html":{"href":"https://github.com/rhq-project/rhq/pull/267#discussion_r66794261"},"pull_request":{"href":"https://api.github.com/repos/rhq-project/rhq/pulls/267"}}},"pull_request":{"url":"https://api.github.com/repos/rhq-project/rhq/pulls/267","id":73285621,"html_url":"https://github.com/rhq-project/rhq/pull/267","diff_url":"https://github.com/rhq-project/rhq/pull/267.diff","patch_url":"https://github.com/rhq-project/rhq/pull/267.patch","issue_url":"https://api.github.com/repos/rhq-project/rhq/issues/267","number":267,"state":"open","locked":false,"title":"Bug 1328316 - Required fields in map-property does not prevent finish…","user":{"login":"rubenvp8510","id":3799716,"avatar_url":"https://avatars.githubusercontent.com/u/3799716?v=3","gravatar_id":"","url":"https://api.github.com/users/rubenvp8510","html_url":"https://github.com/rubenvp8510","followers_url":"https://api.github.com/users/rubenvp8510/followers","following_url":"https://api.github.com/users/rubenvp8510/following{/other_user}","gists_url":"https://api.github.com/users/rubenvp8510/gists{/gist_id}","starred_url":"https://api.github.com/users/rubenvp8510/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubenvp8510/subscriptions","organizations_url":"https://api.github.com/users/rubenvp8510/orgs","repos_url":"https://api.github.com/users/rubenvp8510/repos","events_url":"https://api.github.com/users/rubenvp8510/events{/privacy}","received_events_url":"https://api.github.com/users/rubenvp8510/received_events","type":"User","site_admin":false},"body":"…ing the Resource Create Wizard","created_at":"2016-06-09T21:04:40Z","updated_at":"2016-06-13T13:51:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b8913868ba4388550e126e3115e8845e95969d1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rhq-project/rhq/pulls/267/commits","review_comments_url":"https://api.github.com/repos/rhq-project/rhq/pulls/267/comments","review_comment_url":"https://api.github.com/repos/rhq-project/rhq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rhq-project/rhq/issues/267/comments","statuses_url":"https://api.github.com/repos/rhq-project/rhq/statuses/cbcc869abc0631b37dd9064d5dc9fbdb29076a66","head":{"label":"rubenvp8510:Bug/1328316","ref":"Bug/1328316","sha":"cbcc869abc0631b37dd9064d5dc9fbdb29076a66","user":{"login":"rubenvp8510","id":3799716,"avatar_url":"https://avatars.githubusercontent.com/u/3799716?v=3","gravatar_id":"","url":"https://api.github.com/users/rubenvp8510","html_url":"https://github.com/rubenvp8510","followers_url":"https://api.github.com/users/rubenvp8510/followers","following_url":"https://api.github.com/users/rubenvp8510/following{/other_user}","gists_url":"https://api.github.com/users/rubenvp8510/gists{/gist_id}","starred_url":"https://api.github.com/users/rubenvp8510/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubenvp8510/subscriptions","organizations_url":"https://api.github.com/users/rubenvp8510/orgs","repos_url":"https://api.github.com/users/rubenvp8510/repos","events_url":"https://api.github.com/users/rubenvp8510/events{/privacy}","received_events_url":"https://api.github.com/users/rubenvp8510/received_events","type":"User","site_admin":false},"repo":{"id":52982919,"name":"rhq","full_name":"rubenvp8510/rhq","owner":{"login":"rubenvp8510","id":3799716,"avatar_url":"https://avatars.githubusercontent.com/u/3799716?v=3","gravatar_id":"","url":"https://api.github.com/users/rubenvp8510","html_url":"https://github.com/rubenvp8510","followers_url":"https://api.github.com/users/rubenvp8510/followers","following_url":"https://api.github.com/users/rubenvp8510/following{/other_user}","gists_url":"https://api.github.com/users/rubenvp8510/gists{/gist_id}","starred_url":"https://api.github.com/users/rubenvp8510/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubenvp8510/subscriptions","organizations_url":"https://api.github.com/users/rubenvp8510/orgs","repos_url":"https://api.github.com/users/rubenvp8510/repos","events_url":"https://api.github.com/users/rubenvp8510/events{/privacy}","received_events_url":"https://api.github.com/users/rubenvp8510/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rubenvp8510/rhq","description":"RHQ system management and monitoring framework","fork":true,"url":"https://api.github.com/repos/rubenvp8510/rhq","forks_url":"https://api.github.com/repos/rubenvp8510/rhq/forks","keys_url":"https://api.github.com/repos/rubenvp8510/rhq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubenvp8510/rhq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubenvp8510/rhq/teams","hooks_url":"https://api.github.com/repos/rubenvp8510/rhq/hooks","issue_events_url":"https://api.github.com/repos/rubenvp8510/rhq/issues/events{/number}","events_url":"https://api.github.com/repos/rubenvp8510/rhq/events","assignees_url":"https://api.github.com/repos/rubenvp8510/rhq/assignees{/user}","branches_url":"https://api.github.com/repos/rubenvp8510/rhq/branches{/branch}","tags_url":"https://api.github.com/repos/rubenvp8510/rhq/tags","blobs_url":"https://api.github.com/repos/rubenvp8510/rhq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubenvp8510/rhq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubenvp8510/rhq/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubenvp8510/rhq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubenvp8510/rhq/statuses/{sha}","languages_url":"https://api.github.com/repos/rubenvp8510/rhq/languages","stargazers_url":"https://api.github.com/repos/rubenvp8510/rhq/stargazers","contributors_url":"https://api.github.com/repos/rubenvp8510/rhq/contributors","subscribers_url":"https://api.github.com/repos/rubenvp8510/rhq/subscribers","subscription_url":"https://api.github.com/repos/rubenvp8510/rhq/subscription","commits_url":"https://api.github.com/repos/rubenvp8510/rhq/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubenvp8510/rhq/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubenvp8510/rhq/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubenvp8510/rhq/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubenvp8510/rhq/contents/{+path}","compare_url":"https://api.github.com/repos/rubenvp8510/rhq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubenvp8510/rhq/merges","archive_url":"https://api.github.com/repos/rubenvp8510/rhq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubenvp8510/rhq/downloads","issues_url":"https://api.github.com/repos/rubenvp8510/rhq/issues{/number}","pulls_url":"https://api.github.com/repos/rubenvp8510/rhq/pulls{/number}","milestones_url":"https://api.github.com/repos/rubenvp8510/rhq/milestones{/number}","notifications_url":"https://api.github.com/repos/rubenvp8510/rhq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubenvp8510/rhq/labels{/name}","releases_url":"https://api.github.com/repos/rubenvp8510/rhq/releases{/id}","deployments_url":"https://api.github.com/repos/rubenvp8510/rhq/deployments","created_at":"2016-03-02T17:34:47Z","updated_at":"2016-03-02T17:35:17Z","pushed_at":"2016-06-09T21:03:59Z","git_url":"git://github.com/rubenvp8510/rhq.git","ssh_url":"git@github.com:rubenvp8510/rhq.git","clone_url":"https://github.com/rubenvp8510/rhq.git","svn_url":"https://github.com/rubenvp8510/rhq","homepage":"http://jboss.org/rhq","size":138216,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rhq-project:master","ref":"master","sha":"1d73d1e8a7bbc5ec3c99893f39bcb965e5371e17","user":{"login":"rhq-project","id":1080166,"avatar_url":"https://avatars.githubusercontent.com/u/1080166?v=3","gravatar_id":"","url":"https://api.github.com/users/rhq-project","html_url":"https://github.com/rhq-project","followers_url":"https://api.github.com/users/rhq-project/followers","following_url":"https://api.github.com/users/rhq-project/following{/other_user}","gists_url":"https://api.github.com/users/rhq-project/gists{/gist_id}","starred_url":"https://api.github.com/users/rhq-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhq-project/subscriptions","organizations_url":"https://api.github.com/users/rhq-project/orgs","repos_url":"https://api.github.com/users/rhq-project/repos","events_url":"https://api.github.com/users/rhq-project/events{/privacy}","received_events_url":"https://api.github.com/users/rhq-project/received_events","type":"Organization","site_admin":false},"repo":{"id":17278009,"name":"rhq","full_name":"rhq-project/rhq","owner":{"login":"rhq-project","id":1080166,"avatar_url":"https://avatars.githubusercontent.com/u/1080166?v=3","gravatar_id":"","url":"https://api.github.com/users/rhq-project","html_url":"https://github.com/rhq-project","followers_url":"https://api.github.com/users/rhq-project/followers","following_url":"https://api.github.com/users/rhq-project/following{/other_user}","gists_url":"https://api.github.com/users/rhq-project/gists{/gist_id}","starred_url":"https://api.github.com/users/rhq-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhq-project/subscriptions","organizations_url":"https://api.github.com/users/rhq-project/orgs","repos_url":"https://api.github.com/users/rhq-project/repos","events_url":"https://api.github.com/users/rhq-project/events{/privacy}","received_events_url":"https://api.github.com/users/rhq-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rhq-project/rhq","description":"RHQ system management and monitoring framework","fork":false,"url":"https://api.github.com/repos/rhq-project/rhq","forks_url":"https://api.github.com/repos/rhq-project/rhq/forks","keys_url":"https://api.github.com/repos/rhq-project/rhq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhq-project/rhq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhq-project/rhq/teams","hooks_url":"https://api.github.com/repos/rhq-project/rhq/hooks","issue_events_url":"https://api.github.com/repos/rhq-project/rhq/issues/events{/number}","events_url":"https://api.github.com/repos/rhq-project/rhq/events","assignees_url":"https://api.github.com/repos/rhq-project/rhq/assignees{/user}","branches_url":"https://api.github.com/repos/rhq-project/rhq/branches{/branch}","tags_url":"https://api.github.com/repos/rhq-project/rhq/tags","blobs_url":"https://api.github.com/repos/rhq-project/rhq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhq-project/rhq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhq-project/rhq/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhq-project/rhq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhq-project/rhq/statuses/{sha}","languages_url":"https://api.github.com/repos/rhq-project/rhq/languages","stargazers_url":"https://api.github.com/repos/rhq-project/rhq/stargazers","contributors_url":"https://api.github.com/repos/rhq-project/rhq/contributors","subscribers_url":"https://api.github.com/repos/rhq-project/rhq/subscribers","subscription_url":"https://api.github.com/repos/rhq-project/rhq/subscription","commits_url":"https://api.github.com/repos/rhq-project/rhq/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhq-project/rhq/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhq-project/rhq/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhq-project/rhq/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhq-project/rhq/contents/{+path}","compare_url":"https://api.github.com/repos/rhq-project/rhq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhq-project/rhq/merges","archive_url":"https://api.github.com/repos/rhq-project/rhq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhq-project/rhq/downloads","issues_url":"https://api.github.com/repos/rhq-project/rhq/issues{/number}","pulls_url":"https://api.github.com/repos/rhq-project/rhq/pulls{/number}","milestones_url":"https://api.github.com/repos/rhq-project/rhq/milestones{/number}","notifications_url":"https://api.github.com/repos/rhq-project/rhq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhq-project/rhq/labels{/name}","releases_url":"https://api.github.com/repos/rhq-project/rhq/releases{/id}","deployments_url":"https://api.github.com/repos/rhq-project/rhq/deployments","created_at":"2014-02-28T06:54:47Z","updated_at":"2016-05-25T12:35:31Z","pushed_at":"2016-06-11T08:16:12Z","git_url":"git://github.com/rhq-project/rhq.git","ssh_url":"git@github.com:rhq-project/rhq.git","clone_url":"https://github.com/rhq-project/rhq.git","svn_url":"https://github.com/rhq-project/rhq","homepage":"http://jboss.org/rhq","size":152344,"stargazers_count":91,"watchers_count":91,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":62,"mirror_url":null,"open_issues_count":23,"forks":62,"open_issues":23,"watchers":91,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rhq-project/rhq/pulls/267"},"html":{"href":"https://github.com/rhq-project/rhq/pull/267"},"issue":{"href":"https://api.github.com/repos/rhq-project/rhq/issues/267"},"comments":{"href":"https://api.github.com/repos/rhq-project/rhq/issues/267/comments"},"review_comments":{"href":"https://api.github.com/repos/rhq-project/rhq/pulls/267/comments"},"review_comment":{"href":"https://api.github.com/repos/rhq-project/rhq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rhq-project/rhq/pulls/267/commits"},"statuses":{"href":"https://api.github.com/repos/rhq-project/rhq/statuses/cbcc869abc0631b37dd9064d5dc9fbdb29076a66"}}}}
{"actor":{"display_login":"rubenvp8510"}}