{"action":"created","issue":{"url":"https://api.github.com/repos/openscenegraph/OpenSceneGraph/issues/134","repository_url":"https://api.github.com/repos/openscenegraph/OpenSceneGraph","labels_url":"https://api.github.com/repos/openscenegraph/OpenSceneGraph/issues/134/labels{/name}","comments_url":"https://api.github.com/repos/openscenegraph/OpenSceneGraph/issues/134/comments","events_url":"https://api.github.com/repos/openscenegraph/OpenSceneGraph/issues/134/events","html_url":"https://github.com/openscenegraph/OpenSceneGraph/pull/134","id":177455042,"number":134,"title":"Visual Studio 2015: disable C4589: Constructor of abstract class X ignores initializer for virtual base class Y","user":{"login":"LaurensVoerman","id":19814874,"avatar_url":"https://avatars.githubusercontent.com/u/19814874?v=3","gravatar_id":"","url":"https://api.github.com/users/LaurensVoerman","html_url":"https://github.com/LaurensVoerman","followers_url":"https://api.github.com/users/LaurensVoerman/followers","following_url":"https://api.github.com/users/LaurensVoerman/following{/other_user}","gists_url":"https://api.github.com/users/LaurensVoerman/gists{/gist_id}","starred_url":"https://api.github.com/users/LaurensVoerman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LaurensVoerman/subscriptions","organizations_url":"https://api.github.com/users/LaurensVoerman/orgs","repos_url":"https://api.github.com/users/LaurensVoerman/repos","events_url":"https://api.github.com/users/LaurensVoerman/events{/privacy}","received_events_url":"https://api.github.com/users/LaurensVoerman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-16T15:32:02Z","updated_at":"2016-09-17T10:13:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openscenegraph/OpenSceneGraph/pulls/134","html_url":"https://github.com/openscenegraph/OpenSceneGraph/pull/134","diff_url":"https://github.com/openscenegraph/OpenSceneGraph/pull/134.diff","patch_url":"https://github.com/openscenegraph/OpenSceneGraph/pull/134.patch"},"body":"Hi Robert,\r\n\r\nI failed to see the g++ -Wextra warnings because my cmake (version 2.8.9) is to old for the current script. Here is an enhanced version with support for a few more cmake version, and added warning flags for g++ 4.7 and 4.8 (-Wmaybe-uninitialized -Wextra).\r\nI left -Wshadow out because my 4.7 compiler (4.7.2 ) generates a huge number of shadow warnings.\r\nFor g++ 6 and above I added -Wno-misleading-indentation ; I checked all warning g++ 6.1 generated and currently they don't indicate actual bugs.\r\n\r\nRegards, Laurens."},"comment":{"url":"https://api.github.com/repos/openscenegraph/OpenSceneGraph/issues/comments/247761211","html_url":"https://github.com/openscenegraph/OpenSceneGraph/pull/134#issuecomment-247761211","issue_url":"https://api.github.com/repos/openscenegraph/OpenSceneGraph/issues/134","id":247761211,"user":{"login":"robertosfield","id":1327952,"avatar_url":"https://avatars.githubusercontent.com/u/1327952?v=3","gravatar_id":"","url":"https://api.github.com/users/robertosfield","html_url":"https://github.com/robertosfield","followers_url":"https://api.github.com/users/robertosfield/followers","following_url":"https://api.github.com/users/robertosfield/following{/other_user}","gists_url":"https://api.github.com/users/robertosfield/gists{/gist_id}","starred_url":"https://api.github.com/users/robertosfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertosfield/subscriptions","organizations_url":"https://api.github.com/users/robertosfield/orgs","repos_url":"https://api.github.com/users/robertosfield/repos","events_url":"https://api.github.com/users/robertosfield/events{/privacy}","received_events_url":"https://api.github.com/users/robertosfield/received_events","type":"User","site_admin":false},"created_at":"2016-09-17T10:12:59Z","updated_at":"2016-09-17T10:12:59Z","body":"Hi Laurens,\r\n\r\nThe number of changes feels far more extensive than the change in functionality warrants.  If users want to add extra warnings then they can via ccmake  and just editing the approprirate variable.\r\n\r\nFYI, my plan is to make CMake 2.8 the minimum for git master and hence OSG-3.6."}}
{"actor":{"display_login":"robertosfield"}}