{"action":"created","issue":{"url":"https://api.github.com/repos/paolorotolo/AppIntro/issues/337","repository_url":"https://api.github.com/repos/paolorotolo/AppIntro","labels_url":"https://api.github.com/repos/paolorotolo/AppIntro/issues/337/labels{/name}","comments_url":"https://api.github.com/repos/paolorotolo/AppIntro/issues/337/comments","events_url":"https://api.github.com/repos/paolorotolo/AppIntro/issues/337/events","html_url":"https://github.com/paolorotolo/AppIntro/issues/337","id":183407475,"number":337,"title":"ProGuard rules causing issues on consumer apps","user":{"login":"jrgonzalezg","id":4630806,"avatar_url":"https://avatars.githubusercontent.com/u/4630806?v=3","gravatar_id":"","url":"https://api.github.com/users/jrgonzalezg","html_url":"https://github.com/jrgonzalezg","followers_url":"https://api.github.com/users/jrgonzalezg/followers","following_url":"https://api.github.com/users/jrgonzalezg/following{/other_user}","gists_url":"https://api.github.com/users/jrgonzalezg/gists{/gist_id}","starred_url":"https://api.github.com/users/jrgonzalezg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrgonzalezg/subscriptions","organizations_url":"https://api.github.com/users/jrgonzalezg/orgs","repos_url":"https://api.github.com/users/jrgonzalezg/repos","events_url":"https://api.github.com/users/jrgonzalezg/events{/privacy}","received_events_url":"https://api.github.com/users/jrgonzalezg/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-10-17T12:50:53Z","updated_at":"2016-11-30T06:19:13Z","closed_at":"2016-11-29T22:56:00Z","body":"It seems that at some point between 4.0.0 and 4.1.0 there has been a change on the ProGuard rules for this library that is affecting any app that depends on it. I noticed that the APKs for newer version of my apps were both much bigger and much less obfuscated than before with no obvious reason, and it took me all morning to narrow it down to this library.\n\nThe reason seems to be that the ProGuard rules for this library are being completely exported to be included on any consumer apps due to declaring them in consumerProguardRules on AppIntro/library/build.gradle . I do not know the reason for this ProGuard rules but they seem far too many for what consumers may need to preserve. Maybe they could be divided in two parts, one for the compilation of the library and one for consumers by using both the consumerProguardRules (with a much reduced proguard file) and normal proguardFile declarations for the remaining rules.\n\nAlso, the last rule on the proguard-project.txt already seems to tell consumers to preserve all of the classes from this library, so i am not sure if any of the other rules there is needed at all for consumers, and maybe even this last rule could be rewritten to include only a minimal set of needed things. Additionally, the proguard-rules.pro file seems to be unused and could be deleted.\n"},"comment":{"url":"https://api.github.com/repos/paolorotolo/AppIntro/issues/comments/263793036","html_url":"https://github.com/paolorotolo/AppIntro/issues/337#issuecomment-263793036","issue_url":"https://api.github.com/repos/paolorotolo/AppIntro/issues/337","id":263793036,"user":{"login":"jrgonzalezg","id":4630806,"avatar_url":"https://avatars.githubusercontent.com/u/4630806?v=3","gravatar_id":"","url":"https://api.github.com/users/jrgonzalezg","html_url":"https://github.com/jrgonzalezg","followers_url":"https://api.github.com/users/jrgonzalezg/followers","following_url":"https://api.github.com/users/jrgonzalezg/following{/other_user}","gists_url":"https://api.github.com/users/jrgonzalezg/gists{/gist_id}","starred_url":"https://api.github.com/users/jrgonzalezg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrgonzalezg/subscriptions","organizations_url":"https://api.github.com/users/jrgonzalezg/orgs","repos_url":"https://api.github.com/users/jrgonzalezg/repos","events_url":"https://api.github.com/users/jrgonzalezg/events{/privacy}","received_events_url":"https://api.github.com/users/jrgonzalezg/received_events","type":"User","site_admin":false},"created_at":"2016-11-30T06:19:13Z","updated_at":"2016-11-30T06:19:13Z","body":"I was under the impression that a closed issue was either a fixed issue or one that won't be accepted / fixed. But here \"closed\" must have a different meaning, because if you follow the instructions to use this library you introduce problems in your apps and that is still the case since the last published version (and the one mentioned on the README.md) is still the same. So here \"closed\" is not fixed, because the issue persists. On the other hand, some work has been done on modifying the proguard rules that may lead to a \"fix\" on the future by publishing a new version. So here \"closed\" is also not a \"won't fix\" statement..."}}
{"actor":{"display_login":"jrgonzalezg"}}