{"action":"closed","number":382,"pull_request":{"url":"https://api.github.com/repos/typesafehub/config/pulls/382","id":64677402,"html_url":"https://github.com/typesafehub/config/pull/382","diff_url":"https://github.com/typesafehub/config/pull/382.diff","patch_url":"https://github.com/typesafehub/config/pull/382.patch","issue_url":"https://api.github.com/repos/typesafehub/config/issues/382","number":382,"state":"closed","locked":false,"title":"Issue 380 - Empty string as a valid value for empty list","user":{"login":"PhilippeCollin","id":8934059,"avatar_url":"https://avatars.githubusercontent.com/u/8934059?v=3","gravatar_id":"","url":"https://api.github.com/users/PhilippeCollin","html_url":"https://github.com/PhilippeCollin","followers_url":"https://api.github.com/users/PhilippeCollin/followers","following_url":"https://api.github.com/users/PhilippeCollin/following{/other_user}","gists_url":"https://api.github.com/users/PhilippeCollin/gists{/gist_id}","starred_url":"https://api.github.com/users/PhilippeCollin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhilippeCollin/subscriptions","organizations_url":"https://api.github.com/users/PhilippeCollin/orgs","repos_url":"https://api.github.com/users/PhilippeCollin/repos","events_url":"https://api.github.com/users/PhilippeCollin/events{/privacy}","received_events_url":"https://api.github.com/users/PhilippeCollin/received_events","type":"User","site_admin":false},"body":"As stated in #380 by @michellemay (colleague of mine), it is currently impossible to override a config value with an empty list using standard command line arguments (e.g. `-Dfoo=`).\n\nThis pull request attempts to solve the problem by allowing empty strings as valid values for lists and by converting them to empty lists.\n\nThis means `foo=\"\"` would become valid for all `getList` methods and all would return an empty list of appropriate type.\nIt would also be possible to override a config value with an empty list using command line arguments like so: `-Dfoo=` .\n","created_at":"2016-03-30T18:48:47Z","updated_at":"2016-11-30T03:59:03Z","closed_at":"2016-11-30T03:59:03Z","merged_at":null,"merge_commit_sha":"1c82494540fca37aea022725f36b96526bb411d5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/typesafehub/config/pulls/382/commits","review_comments_url":"https://api.github.com/repos/typesafehub/config/pulls/382/comments","review_comment_url":"https://api.github.com/repos/typesafehub/config/pulls/comments{/number}","comments_url":"https://api.github.com/repos/typesafehub/config/issues/382/comments","statuses_url":"https://api.github.com/repos/typesafehub/config/statuses/9be41b7a6956e611ae85aa71969ba3af1a555db3","head":{"label":"PhilippeCollin:issue-380","ref":"issue-380","sha":"9be41b7a6956e611ae85aa71969ba3af1a555db3","user":{"login":"PhilippeCollin","id":8934059,"avatar_url":"https://avatars.githubusercontent.com/u/8934059?v=3","gravatar_id":"","url":"https://api.github.com/users/PhilippeCollin","html_url":"https://github.com/PhilippeCollin","followers_url":"https://api.github.com/users/PhilippeCollin/followers","following_url":"https://api.github.com/users/PhilippeCollin/following{/other_user}","gists_url":"https://api.github.com/users/PhilippeCollin/gists{/gist_id}","starred_url":"https://api.github.com/users/PhilippeCollin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhilippeCollin/subscriptions","organizations_url":"https://api.github.com/users/PhilippeCollin/orgs","repos_url":"https://api.github.com/users/PhilippeCollin/repos","events_url":"https://api.github.com/users/PhilippeCollin/events{/privacy}","received_events_url":"https://api.github.com/users/PhilippeCollin/received_events","type":"User","site_admin":false},"repo":{"id":55058003,"name":"config","full_name":"PhilippeCollin/config","owner":{"login":"PhilippeCollin","id":8934059,"avatar_url":"https://avatars.githubusercontent.com/u/8934059?v=3","gravatar_id":"","url":"https://api.github.com/users/PhilippeCollin","html_url":"https://github.com/PhilippeCollin","followers_url":"https://api.github.com/users/PhilippeCollin/followers","following_url":"https://api.github.com/users/PhilippeCollin/following{/other_user}","gists_url":"https://api.github.com/users/PhilippeCollin/gists{/gist_id}","starred_url":"https://api.github.com/users/PhilippeCollin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhilippeCollin/subscriptions","organizations_url":"https://api.github.com/users/PhilippeCollin/orgs","repos_url":"https://api.github.com/users/PhilippeCollin/repos","events_url":"https://api.github.com/users/PhilippeCollin/events{/privacy}","received_events_url":"https://api.github.com/users/PhilippeCollin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PhilippeCollin/config","description":"Configuration library for JVM languages","fork":true,"url":"https://api.github.com/repos/PhilippeCollin/config","forks_url":"https://api.github.com/repos/PhilippeCollin/config/forks","keys_url":"https://api.github.com/repos/PhilippeCollin/config/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PhilippeCollin/config/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PhilippeCollin/config/teams","hooks_url":"https://api.github.com/repos/PhilippeCollin/config/hooks","issue_events_url":"https://api.github.com/repos/PhilippeCollin/config/issues/events{/number}","events_url":"https://api.github.com/repos/PhilippeCollin/config/events","assignees_url":"https://api.github.com/repos/PhilippeCollin/config/assignees{/user}","branches_url":"https://api.github.com/repos/PhilippeCollin/config/branches{/branch}","tags_url":"https://api.github.com/repos/PhilippeCollin/config/tags","blobs_url":"https://api.github.com/repos/PhilippeCollin/config/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PhilippeCollin/config/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PhilippeCollin/config/git/refs{/sha}","trees_url":"https://api.github.com/repos/PhilippeCollin/config/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PhilippeCollin/config/statuses/{sha}","languages_url":"https://api.github.com/repos/PhilippeCollin/config/languages","stargazers_url":"https://api.github.com/repos/PhilippeCollin/config/stargazers","contributors_url":"https://api.github.com/repos/PhilippeCollin/config/contributors","subscribers_url":"https://api.github.com/repos/PhilippeCollin/config/subscribers","subscription_url":"https://api.github.com/repos/PhilippeCollin/config/subscription","commits_url":"https://api.github.com/repos/PhilippeCollin/config/commits{/sha}","git_commits_url":"https://api.github.com/repos/PhilippeCollin/config/git/commits{/sha}","comments_url":"https://api.github.com/repos/PhilippeCollin/config/comments{/number}","issue_comment_url":"https://api.github.com/repos/PhilippeCollin/config/issues/comments{/number}","contents_url":"https://api.github.com/repos/PhilippeCollin/config/contents/{+path}","compare_url":"https://api.github.com/repos/PhilippeCollin/config/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PhilippeCollin/config/merges","archive_url":"https://api.github.com/repos/PhilippeCollin/config/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PhilippeCollin/config/downloads","issues_url":"https://api.github.com/repos/PhilippeCollin/config/issues{/number}","pulls_url":"https://api.github.com/repos/PhilippeCollin/config/pulls{/number}","milestones_url":"https://api.github.com/repos/PhilippeCollin/config/milestones{/number}","notifications_url":"https://api.github.com/repos/PhilippeCollin/config/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PhilippeCollin/config/labels{/name}","releases_url":"https://api.github.com/repos/PhilippeCollin/config/releases{/id}","deployments_url":"https://api.github.com/repos/PhilippeCollin/config/deployments","created_at":"2016-03-30T11:37:41Z","updated_at":"2016-03-30T11:37:42Z","pushed_at":"2016-04-06T12:29:36Z","git_url":"git://github.com/PhilippeCollin/config.git","ssh_url":"git@github.com:PhilippeCollin/config.git","clone_url":"https://github.com/PhilippeCollin/config.git","svn_url":"https://github.com/PhilippeCollin/config","homepage":"http://typesafe.com","size":4778,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"typesafehub:master","ref":"master","sha":"09146706db07d6415548da28c7c6604d0fb5f7a3","user":{"login":"typesafehub","id":784923,"avatar_url":"https://avatars.githubusercontent.com/u/784923?v=3","gravatar_id":"","url":"https://api.github.com/users/typesafehub","html_url":"https://github.com/typesafehub","followers_url":"https://api.github.com/users/typesafehub/followers","following_url":"https://api.github.com/users/typesafehub/following{/other_user}","gists_url":"https://api.github.com/users/typesafehub/gists{/gist_id}","starred_url":"https://api.github.com/users/typesafehub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typesafehub/subscriptions","organizations_url":"https://api.github.com/users/typesafehub/orgs","repos_url":"https://api.github.com/users/typesafehub/repos","events_url":"https://api.github.com/users/typesafehub/events{/privacy}","received_events_url":"https://api.github.com/users/typesafehub/received_events","type":"Organization","site_admin":false},"repo":{"id":2923236,"name":"config","full_name":"typesafehub/config","owner":{"login":"typesafehub","id":784923,"avatar_url":"https://avatars.githubusercontent.com/u/784923?v=3","gravatar_id":"","url":"https://api.github.com/users/typesafehub","html_url":"https://github.com/typesafehub","followers_url":"https://api.github.com/users/typesafehub/followers","following_url":"https://api.github.com/users/typesafehub/following{/other_user}","gists_url":"https://api.github.com/users/typesafehub/gists{/gist_id}","starred_url":"https://api.github.com/users/typesafehub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typesafehub/subscriptions","organizations_url":"https://api.github.com/users/typesafehub/orgs","repos_url":"https://api.github.com/users/typesafehub/repos","events_url":"https://api.github.com/users/typesafehub/events{/privacy}","received_events_url":"https://api.github.com/users/typesafehub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/typesafehub/config","description":"Configuration library for JVM languages","fork":false,"url":"https://api.github.com/repos/typesafehub/config","forks_url":"https://api.github.com/repos/typesafehub/config/forks","keys_url":"https://api.github.com/repos/typesafehub/config/keys{/key_id}","collaborators_url":"https://api.github.com/repos/typesafehub/config/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/typesafehub/config/teams","hooks_url":"https://api.github.com/repos/typesafehub/config/hooks","issue_events_url":"https://api.github.com/repos/typesafehub/config/issues/events{/number}","events_url":"https://api.github.com/repos/typesafehub/config/events","assignees_url":"https://api.github.com/repos/typesafehub/config/assignees{/user}","branches_url":"https://api.github.com/repos/typesafehub/config/branches{/branch}","tags_url":"https://api.github.com/repos/typesafehub/config/tags","blobs_url":"https://api.github.com/repos/typesafehub/config/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/typesafehub/config/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/typesafehub/config/git/refs{/sha}","trees_url":"https://api.github.com/repos/typesafehub/config/git/trees{/sha}","statuses_url":"https://api.github.com/repos/typesafehub/config/statuses/{sha}","languages_url":"https://api.github.com/repos/typesafehub/config/languages","stargazers_url":"https://api.github.com/repos/typesafehub/config/stargazers","contributors_url":"https://api.github.com/repos/typesafehub/config/contributors","subscribers_url":"https://api.github.com/repos/typesafehub/config/subscribers","subscription_url":"https://api.github.com/repos/typesafehub/config/subscription","commits_url":"https://api.github.com/repos/typesafehub/config/commits{/sha}","git_commits_url":"https://api.github.com/repos/typesafehub/config/git/commits{/sha}","comments_url":"https://api.github.com/repos/typesafehub/config/comments{/number}","issue_comment_url":"https://api.github.com/repos/typesafehub/config/issues/comments{/number}","contents_url":"https://api.github.com/repos/typesafehub/config/contents/{+path}","compare_url":"https://api.github.com/repos/typesafehub/config/compare/{base}...{head}","merges_url":"https://api.github.com/repos/typesafehub/config/merges","archive_url":"https://api.github.com/repos/typesafehub/config/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/typesafehub/config/downloads","issues_url":"https://api.github.com/repos/typesafehub/config/issues{/number}","pulls_url":"https://api.github.com/repos/typesafehub/config/pulls{/number}","milestones_url":"https://api.github.com/repos/typesafehub/config/milestones{/number}","notifications_url":"https://api.github.com/repos/typesafehub/config/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/typesafehub/config/labels{/name}","releases_url":"https://api.github.com/repos/typesafehub/config/releases{/id}","deployments_url":"https://api.github.com/repos/typesafehub/config/deployments","created_at":"2011-12-06T08:02:29Z","updated_at":"2016-11-29T15:59:56Z","pushed_at":"2016-11-08T19:13:44Z","git_url":"git://github.com/typesafehub/config.git","ssh_url":"git@github.com:typesafehub/config.git","clone_url":"https://github.com/typesafehub/config.git","svn_url":"https://github.com/typesafehub/config","homepage":"https://typesafehub.github.io/config/","size":4379,"stargazers_count":2327,"watchers_count":2327,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":364,"mirror_url":null,"open_issues_count":94,"forks":364,"open_issues":94,"watchers":2327,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/typesafehub/config/pulls/382"},"html":{"href":"https://github.com/typesafehub/config/pull/382"},"issue":{"href":"https://api.github.com/repos/typesafehub/config/issues/382"},"comments":{"href":"https://api.github.com/repos/typesafehub/config/issues/382/comments"},"review_comments":{"href":"https://api.github.com/repos/typesafehub/config/pulls/382/comments"},"review_comment":{"href":"https://api.github.com/repos/typesafehub/config/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/typesafehub/config/pulls/382/commits"},"statuses":{"href":"https://api.github.com/repos/typesafehub/config/statuses/9be41b7a6956e611ae85aa71969ba3af1a555db3"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":7,"review_comments":5,"commits":3,"additions":36,"deletions":7,"changed_files":7}}
{"actor":{"display_login":"PhilippeCollin"}}