{"action":"created","comment":{"url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/pulls/comments/52274448","id":52274448,"diff_hunk":"@@ -381,12 +381,27 @@ def update_flight(link, campaign, az_campaign):\n         })\n \n     if campaign.platform != 'all':\n-        d.update({\n-            'SiteZoneTargeting': [{\n-                'SiteId': g.az_selfserve_site_ids[campaign.platform],\n-                'IsExclude': False,\n-            }],\n-        })\n+        site_targeting = [{\n+            'SiteId': g.az_selfserve_site_ids[campaign.platform],\n+            'IsExclude': False,\n+            'ZoneId': None,","path":"reddit_adzerk/adzerkpromote.py","position":13,"original_position":13,"commit_id":"0235636359bc503f6b65db86077cb8b118c60fd4","original_commit_id":"0235636359bc503f6b65db86077cb8b118c60fd4","user":{"login":"zeantsoi","id":339024,"avatar_url":"https://avatars.githubusercontent.com/u/339024?v=3","gravatar_id":"","url":"https://api.github.com/users/zeantsoi","html_url":"https://github.com/zeantsoi","followers_url":"https://api.github.com/users/zeantsoi/followers","following_url":"https://api.github.com/users/zeantsoi/following{/other_user}","gists_url":"https://api.github.com/users/zeantsoi/gists{/gist_id}","starred_url":"https://api.github.com/users/zeantsoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeantsoi/subscriptions","organizations_url":"https://api.github.com/users/zeantsoi/orgs","repos_url":"https://api.github.com/users/zeantsoi/repos","events_url":"https://api.github.com/users/zeantsoi/events{/privacy}","received_events_url":"https://api.github.com/users/zeantsoi/received_events","type":"User","site_admin":false},"body":"Why are we setting ZoneId and FlightId now, but not before?","created_at":"2016-02-09T07:29:52Z","updated_at":"2016-02-09T07:29:52Z","html_url":"https://github.com/reddit/reddit-plugin-adzerk/pull/149#discussion_r52274448","pull_request_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/pulls/149","_links":{"self":{"href":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/pulls/comments/52274448"},"html":{"href":"https://github.com/reddit/reddit-plugin-adzerk/pull/149#discussion_r52274448"},"pull_request":{"href":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/pulls/149"}}},"pull_request":{"url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/pulls/149","id":58701737,"html_url":"https://github.com/reddit/reddit-plugin-adzerk/pull/149","diff_url":"https://github.com/reddit/reddit-plugin-adzerk/pull/149.diff","patch_url":"https://github.com/reddit/reddit-plugin-adzerk/pull/149.patch","issue_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/issues/149","number":149,"state":"open","locked":false,"title":"Stop unnecessarily updating `SiteZoneTargeting`","user":{"login":"dwick","id":823747,"avatar_url":"https://avatars.githubusercontent.com/u/823747?v=3","gravatar_id":"","url":"https://api.github.com/users/dwick","html_url":"https://github.com/dwick","followers_url":"https://api.github.com/users/dwick/followers","following_url":"https://api.github.com/users/dwick/following{/other_user}","gists_url":"https://api.github.com/users/dwick/gists{/gist_id}","starred_url":"https://api.github.com/users/dwick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwick/subscriptions","organizations_url":"https://api.github.com/users/dwick/orgs","repos_url":"https://api.github.com/users/dwick/repos","events_url":"https://api.github.com/users/dwick/events{/privacy}","received_events_url":"https://api.github.com/users/dwick/received_events","type":"User","site_admin":false},"body":"SiteZoneTargeting hardly ever changes, but causes unchanged flights\r\nto be updated unnecessarily/spam the `PromotionLog` because adzerk\r\nalso includes `Id`s in the GET results.\r\n\r\n\r\n:eyeglasses: @zeantsoi ","created_at":"2016-02-09T03:41:37Z","updated_at":"2016-02-09T07:29:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"913a1b3e66903aead6b1125e054d4588f2286aed","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/pulls/149/commits","review_comments_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/pulls/149/comments","review_comment_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/issues/149/comments","statuses_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/statuses/0235636359bc503f6b65db86077cb8b118c60fd4","head":{"label":"dwick:idempotent","ref":"idempotent","sha":"0235636359bc503f6b65db86077cb8b118c60fd4","user":{"login":"dwick","id":823747,"avatar_url":"https://avatars.githubusercontent.com/u/823747?v=3","gravatar_id":"","url":"https://api.github.com/users/dwick","html_url":"https://github.com/dwick","followers_url":"https://api.github.com/users/dwick/followers","following_url":"https://api.github.com/users/dwick/following{/other_user}","gists_url":"https://api.github.com/users/dwick/gists{/gist_id}","starred_url":"https://api.github.com/users/dwick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwick/subscriptions","organizations_url":"https://api.github.com/users/dwick/orgs","repos_url":"https://api.github.com/users/dwick/repos","events_url":"https://api.github.com/users/dwick/events{/privacy}","received_events_url":"https://api.github.com/users/dwick/received_events","type":"User","site_admin":false},"repo":{"id":30618338,"name":"reddit-plugin-adzerk","full_name":"dwick/reddit-plugin-adzerk","owner":{"login":"dwick","id":823747,"avatar_url":"https://avatars.githubusercontent.com/u/823747?v=3","gravatar_id":"","url":"https://api.github.com/users/dwick","html_url":"https://github.com/dwick","followers_url":"https://api.github.com/users/dwick/followers","following_url":"https://api.github.com/users/dwick/following{/other_user}","gists_url":"https://api.github.com/users/dwick/gists{/gist_id}","starred_url":"https://api.github.com/users/dwick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwick/subscriptions","organizations_url":"https://api.github.com/users/dwick/orgs","repos_url":"https://api.github.com/users/dwick/repos","events_url":"https://api.github.com/users/dwick/events{/privacy}","received_events_url":"https://api.github.com/users/dwick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dwick/reddit-plugin-adzerk","description":"reddit plugin for adzerk-hosted adverts","fork":true,"url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk","forks_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/forks","keys_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/teams","hooks_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/hooks","issue_events_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/issues/events{/number}","events_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/events","assignees_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/assignees{/user}","branches_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/branches{/branch}","tags_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/tags","blobs_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/git/refs{/sha}","trees_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/statuses/{sha}","languages_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/languages","stargazers_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/stargazers","contributors_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/contributors","subscribers_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/subscribers","subscription_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/subscription","commits_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/commits{/sha}","git_commits_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/git/commits{/sha}","comments_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/comments{/number}","issue_comment_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/issues/comments{/number}","contents_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/contents/{+path}","compare_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/merges","archive_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/downloads","issues_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/issues{/number}","pulls_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/pulls{/number}","milestones_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/milestones{/number}","notifications_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/labels{/name}","releases_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/releases{/id}","deployments_url":"https://api.github.com/repos/dwick/reddit-plugin-adzerk/deployments","created_at":"2015-02-10T22:37:08Z","updated_at":"2015-02-10T22:37:09Z","pushed_at":"2016-02-09T03:41:22Z","git_url":"git://github.com/dwick/reddit-plugin-adzerk.git","ssh_url":"git@github.com:dwick/reddit-plugin-adzerk.git","clone_url":"https://github.com/dwick/reddit-plugin-adzerk.git","svn_url":"https://github.com/dwick/reddit-plugin-adzerk","homepage":"","size":457,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"reddit:master","ref":"master","sha":"97fa23303660da448fd38311d8bc6c977de79243","user":{"login":"reddit","id":14248,"avatar_url":"https://avatars.githubusercontent.com/u/14248?v=3","gravatar_id":"","url":"https://api.github.com/users/reddit","html_url":"https://github.com/reddit","followers_url":"https://api.github.com/users/reddit/followers","following_url":"https://api.github.com/users/reddit/following{/other_user}","gists_url":"https://api.github.com/users/reddit/gists{/gist_id}","starred_url":"https://api.github.com/users/reddit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddit/subscriptions","organizations_url":"https://api.github.com/users/reddit/orgs","repos_url":"https://api.github.com/users/reddit/repos","events_url":"https://api.github.com/users/reddit/events{/privacy}","received_events_url":"https://api.github.com/users/reddit/received_events","type":"Organization","site_admin":false},"repo":{"id":7122209,"name":"reddit-plugin-adzerk","full_name":"reddit/reddit-plugin-adzerk","owner":{"login":"reddit","id":14248,"avatar_url":"https://avatars.githubusercontent.com/u/14248?v=3","gravatar_id":"","url":"https://api.github.com/users/reddit","html_url":"https://github.com/reddit","followers_url":"https://api.github.com/users/reddit/followers","following_url":"https://api.github.com/users/reddit/following{/other_user}","gists_url":"https://api.github.com/users/reddit/gists{/gist_id}","starred_url":"https://api.github.com/users/reddit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddit/subscriptions","organizations_url":"https://api.github.com/users/reddit/orgs","repos_url":"https://api.github.com/users/reddit/repos","events_url":"https://api.github.com/users/reddit/events{/privacy}","received_events_url":"https://api.github.com/users/reddit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reddit/reddit-plugin-adzerk","description":"reddit plugin for adzerk-hosted adverts","fork":false,"url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk","forks_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/forks","keys_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/teams","hooks_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/hooks","issue_events_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/issues/events{/number}","events_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/events","assignees_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/assignees{/user}","branches_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/branches{/branch}","tags_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/tags","blobs_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/git/refs{/sha}","trees_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/statuses/{sha}","languages_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/languages","stargazers_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/stargazers","contributors_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/contributors","subscribers_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/subscribers","subscription_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/subscription","commits_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/commits{/sha}","git_commits_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/git/commits{/sha}","comments_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/comments{/number}","issue_comment_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/issues/comments{/number}","contents_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/contents/{+path}","compare_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/merges","archive_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/downloads","issues_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/issues{/number}","pulls_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/pulls{/number}","milestones_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/milestones{/number}","notifications_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/labels{/name}","releases_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/releases{/id}","deployments_url":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/deployments","created_at":"2012-12-12T00:59:20Z","updated_at":"2016-01-11T22:07:18Z","pushed_at":"2016-02-09T03:41:38Z","git_url":"git://github.com/reddit/reddit-plugin-adzerk.git","ssh_url":"git@github.com:reddit/reddit-plugin-adzerk.git","clone_url":"https://github.com/reddit/reddit-plugin-adzerk.git","svn_url":"https://github.com/reddit/reddit-plugin-adzerk","homepage":"","size":509,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":2,"forks":14,"open_issues":2,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/pulls/149"},"html":{"href":"https://github.com/reddit/reddit-plugin-adzerk/pull/149"},"issue":{"href":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/issues/149"},"comments":{"href":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/issues/149/comments"},"review_comments":{"href":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/pulls/149/comments"},"review_comment":{"href":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/pulls/149/commits"},"statuses":{"href":"https://api.github.com/repos/reddit/reddit-plugin-adzerk/statuses/0235636359bc503f6b65db86077cb8b118c60fd4"}}}}