{"push_id":1114281780,"size":9,"distinct_size":9,"ref":"refs/heads/add_breadcrumbs","head":"ff362d0d1d36b2f37a1472e4a2b18a40eacc0b8a","before":"1af942b2e525bd8bd40149d377d6e26bab3e8d5d","commits":[{"sha":"2265b08a31743c0a1adfb1507dc43a85c0970f81","author":{"email":"3095e5b75e26c9656f0f4ea2a363b7a67d313afd@gmail.com","name":"Kevin Attfield"},"message":"Remove unused template\n\nI believe the correct form is admin/properties/_form.html.erb","distinct":true,"url":"https://api.github.com/repos/Murph33/solidus/commits/2265b08a31743c0a1adfb1507dc43a85c0970f81"},{"sha":"5f4b1785c482b2d59ff3f23c5502f91ed3815621","author":{"email":"3095e5b75e26c9656f0f4ea2a363b7a67d313afd@gmail.com","name":"Kevin Attfield"},"message":"Rename frontend breadcrumbs helper\n\nThis is used only to display breadcrumbs for Taxons on the frontend.\nSince it has so much taxon specific knowledge, and I don't think we\nplan on keeping the current frontend around, instead of abstracting\nout \"creating breadcrumbs\", I would rather just steal the name.","distinct":true,"url":"https://api.github.com/repos/Murph33/solidus/commits/5f4b1785c482b2d59ff3f23c5502f91ed3815621"},{"sha":"ad9b1d2da865aa539e3d9bfa0b787eefea5c4130","author":{"email":"3095e5b75e26c9656f0f4ea2a363b7a67d313afd@gmail.com","name":"Kevin Attfield"},"message":"Add breadcrumbs helpers\n\nCurrently breadcrumbs are created by piling content into the\n\"page_title\" yield block.\n\nIt would be great if the breadcrumbs were somehow \"meta\" information,\nprovided by a controller action. This would require better organization\nof the backend controllers. For now, I'd like to add some structure to\nthe breadcrumb information by separating the \"levels\" into individual\nentries. This does two things for us:\n\n1. It homogeonizes the way in which breadcrumbs are created and makes it\nmore clear how different pages are related. This could help us move them\naround or develop a better systme for organizing the backend.\n2. It gives us easier access to \"the last breadcrumb\" which is very\noften \"the actual title of the page\". This then allows us to pick better\npage titles, and maybe in the future *only* show the page title, and\ndrop the breadcrumbs altogether, in favour of a better navigation.","distinct":true,"url":"https://api.github.com/repos/Murph33/solidus/commits/ad9b1d2da865aa539e3d9bfa0b787eefea5c4130"},{"sha":"63be6354e92ef03e95145f3cb0fa99ac86e8ddbd","author":{"email":"3095e5b75e26c9656f0f4ea2a363b7a67d313afd@gmail.com","name":"Kevin Attfield"},"message":"Use new breadcrumbs in layout\n\nThis will make all breadcrumbs go away until we swap them over, but\notherwise this change will get lost in a hundred view changes.","distinct":true,"url":"https://api.github.com/repos/Murph33/solidus/commits/63be6354e92ef03e95145f3cb0fa99ac86e8ddbd"},{"sha":"92633826b91db1cab599a2b5f50e01840dbd7302","author":{"email":"3095e5b75e26c9656f0f4ea2a363b7a67d313afd@gmail.com","name":"Kevin Attfield"},"message":"Always show the page header\n\nThere will now *always* be something we can show as the page title, so\nthe header will no long be \"an optional thing that just happens to\nalways be there\".\n\nThe header is a big part of our layout, it should be clear that it is\nalways going to be present.","distinct":true,"url":"https://api.github.com/repos/Murph33/solidus/commits/92633826b91db1cab599a2b5f50e01840dbd7302"},{"sha":"216760714f525d59e8fa4eff2725aeb9bd994737","author":{"email":"3095e5b75e26c9656f0f4ea2a363b7a67d313afd@gmail.com","name":"Kevin Attfield"},"message":"Prefer last level of breadcrumb over fallback page title\n\nThis change was mostly to move some logic out into a helper, but I also\nprefer to see the last item in the breadcrumbs be the page title rather\nthan the controller name.\n\nI would be fine with any page title pattern which isn't too long. We\nmight want to consider prepneding or appending something like\n\"Admin: \" or \"| Admin\".","distinct":true,"url":"https://api.github.com/repos/Murph33/solidus/commits/216760714f525d59e8fa4eff2725aeb9bd994737"},{"sha":"cbae8d3b1880cf0cdd15046f1dfa313d4d72ea01","author":{"email":"3095e5b75e26c9656f0f4ea2a363b7a67d313afd@gmail.com","name":"Kevin Attfield"},"message":"Style admin breadcrumbs\n\nWe don't want Boostrap's default grey background right now, because\nthese things are hiding out in the header which currently has a blue\nbackground. Also the margin-bottom makes the header look misaligned.","distinct":true,"url":"https://api.github.com/repos/Murph33/solidus/commits/cbae8d3b1880cf0cdd15046f1dfa313d4d72ea01"},{"sha":"9ec39a2e6338e0238f19f037f0bfa9910a1144ee","author":{"email":"3095e5b75e26c9656f0f4ea2a363b7a67d313afd@gmail.com","name":"Kevin Attfield"},"message":"Use new breadcrumb helpers instead of content_for(:page_title)","distinct":true,"url":"https://api.github.com/repos/Murph33/solidus/commits/9ec39a2e6338e0238f19f037f0bfa9910a1144ee"},{"sha":"ff362d0d1d36b2f37a1472e4a2b18a40eacc0b8a","author":{"email":"7e036e205a3d0ed3281108b8c0c39732cd748d3b@users.noreply.github.com","name":"Murph33"},"message":"Merge pull request #1 from Sinetheta/breadcrumbs\n\nThanks @Sinetheta for making this more like code and less like HTML","distinct":true,"url":"https://api.github.com/repos/Murph33/solidus/commits/ff362d0d1d36b2f37a1472e4a2b18a40eacc0b8a"}]}