{"action":"opened","issue":{"url":"https://api.github.com/repos/jetstream-g5/CustomShader/issues/3","repository_url":"https://api.github.com/repos/jetstream-g5/CustomShader","labels_url":"https://api.github.com/repos/jetstream-g5/CustomShader/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/jetstream-g5/CustomShader/issues/3/comments","events_url":"https://api.github.com/repos/jetstream-g5/CustomShader/issues/3/events","html_url":"https://github.com/jetstream-g5/CustomShader/issues/3","id":186773583,"number":3,"title":"Wees flexibel met je code","user":{"login":"erwinhenraat","id":1262745,"avatar_url":"https://avatars.githubusercontent.com/u/1262745?v=3","gravatar_id":"","url":"https://api.github.com/users/erwinhenraat","html_url":"https://github.com/erwinhenraat","followers_url":"https://api.github.com/users/erwinhenraat/followers","following_url":"https://api.github.com/users/erwinhenraat/following{/other_user}","gists_url":"https://api.github.com/users/erwinhenraat/gists{/gist_id}","starred_url":"https://api.github.com/users/erwinhenraat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erwinhenraat/subscriptions","organizations_url":"https://api.github.com/users/erwinhenraat/orgs","repos_url":"https://api.github.com/users/erwinhenraat/repos","events_url":"https://api.github.com/users/erwinhenraat/events{/privacy}","received_events_url":"https://api.github.com/users/erwinhenraat/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-11-02T11:17:07Z","updated_at":"2016-11-02T11:17:07Z","closed_at":null,"body":"Je hebt feedback gekregen van **erwinhenraat**\nop:\n```c\n      if (Input.GetKey(KeyCode.D))\n        {\n            CharacterRotation.RotateRight += Rotate;\n            transform.Translate(Vector3.forward * Time.deltaTime * _speed);\n            isMoving = true;\n        }\n        else if (Input.GetKey(KeyCode.A))\n        { \n```\n\nURL: https://github.com/jetstream-g5/CustomShader/blob/master/Assets/Scripts/CharacterMovement.cs\n\nFeedback: De keycodes zijn hard vastgelegd. Werk met een aparte input class waarmee je de keys koppelt aan acties die daardoor getriggerd moeten worden. Deze acties zet je weer in andere classes zoals deze CharacterMovement.\n\nAls je hiervoor ook delegates gebruikt heb je hele flexibele code die je heel makkelijk kunt hergebruiken voor andere projecten.[](http://www.studiozoetekauw.nl/codereview-in-het-onderwijs/ '#cr:{\"sha\":\"fd37bee713cf3c0292a02cd20932b201ffbbccfa\",\"path\":\"Assets/Scripts/CharacterMovement.cs\",\"reviewer\":\"erwinhenraat\"}')"}}
{"actor":{"display_login":"erwinhenraat"}}