{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/79690446","id":79690446,"diff_hunk":"@@ -3,7 +3,7 @@\n /*\n  * Ceph distributed storage system\n  *\n- * Copyright (C) 2014 Cloudwatt <libre.licensing@cloudwatt.com>","path":"src/erasure-code/jerasure/jerasure_init.cc","position":7,"original_position":4,"commit_id":"d43c5c4e4bf807e05a180f114d7dc13d1af51a8d","original_commit_id":"c35c54e830dbb9333f28354b2f5a933a238f94d5","user":{"login":"bassamtabbara","id":1463491,"avatar_url":"https://avatars.githubusercontent.com/u/1463491?v=3","gravatar_id":"","url":"https://api.github.com/users/bassamtabbara","html_url":"https://github.com/bassamtabbara","followers_url":"https://api.github.com/users/bassamtabbara/followers","following_url":"https://api.github.com/users/bassamtabbara/following{/other_user}","gists_url":"https://api.github.com/users/bassamtabbara/gists{/gist_id}","starred_url":"https://api.github.com/users/bassamtabbara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bassamtabbara/subscriptions","organizations_url":"https://api.github.com/users/bassamtabbara/orgs","repos_url":"https://api.github.com/users/bassamtabbara/repos","events_url":"https://api.github.com/users/bassamtabbara/events{/privacy}","received_events_url":"https://api.github.com/users/bassamtabbara/received_events","type":"User","site_admin":false},"body":"Looking more closely they do seem different. I'll cleanup. thanks.","created_at":"2016-09-20T19:16:58Z","updated_at":"2016-09-20T19:16:58Z","html_url":"https://github.com/ceph/ceph/pull/11086#discussion_r79690446","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/11086","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/79690446"},"html":{"href":"https://github.com/ceph/ceph/pull/11086#discussion_r79690446"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/11086"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/11086","id":85308338,"html_url":"https://github.com/ceph/ceph/pull/11086","diff_url":"https://github.com/ceph/ceph/pull/11086.diff","patch_url":"https://github.com/ceph/ceph/pull/11086.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/11086","number":11086,"state":"open","locked":false,"title":"erasure-code: Runtime detection of SIMD for jerasure and shec","user":{"login":"bassamtabbara","id":1463491,"avatar_url":"https://avatars.githubusercontent.com/u/1463491?v=3","gravatar_id":"","url":"https://api.github.com/users/bassamtabbara","html_url":"https://github.com/bassamtabbara","followers_url":"https://api.github.com/users/bassamtabbara/followers","following_url":"https://api.github.com/users/bassamtabbara/following{/other_user}","gists_url":"https://api.github.com/users/bassamtabbara/gists{/gist_id}","starred_url":"https://api.github.com/users/bassamtabbara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bassamtabbara/subscriptions","organizations_url":"https://api.github.com/users/bassamtabbara/orgs","repos_url":"https://api.github.com/users/bassamtabbara/repos","events_url":"https://api.github.com/users/bassamtabbara/events{/privacy}","received_events_url":"https://api.github.com/users/bassamtabbara/received_events","type":"User","site_admin":false},"body":"The PR completes the first part of http://pad.ceph.com/p/erasure-coding-runtime-simd-detection.\r\n\r\nBy switching to a new gf-complete (v3) with SIMD runtime detection, we can now remove all the different flavors of jerasure and shec. This simplifies deployment and configuration of erasure coding, enables hetergenous OSDs, and enables us to take advantage of new performance improvements in jerasure without config/build changes.\r\n\r\nThis PR removes flavors from cmake, removes ErasureCodePluginSelect___, and fixes unit tests. There is now a single plugin for jerasure and a single plugin for shec.\r\n\r\nSIMDExt.cmake was changed so that its a little more generic, and is not polluted with gf-complete specific CFLAG defines.\r\n\r\nI also added a small init helper for jerasure that has code that was common between jerasure and shec.","created_at":"2016-09-14T21:26:24Z","updated_at":"2016-09-20T19:16:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b337bb04e69a88148ed28a4711d72da9d8f0a9e9","assignee":{"login":"dachary","id":433594,"avatar_url":"https://avatars.githubusercontent.com/u/433594?v=3","gravatar_id":"","url":"https://api.github.com/users/dachary","html_url":"https://github.com/dachary","followers_url":"https://api.github.com/users/dachary/followers","following_url":"https://api.github.com/users/dachary/following{/other_user}","gists_url":"https://api.github.com/users/dachary/gists{/gist_id}","starred_url":"https://api.github.com/users/dachary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dachary/subscriptions","organizations_url":"https://api.github.com/users/dachary/orgs","repos_url":"https://api.github.com/users/dachary/repos","events_url":"https://api.github.com/users/dachary/events{/privacy}","received_events_url":"https://api.github.com/users/dachary/received_events","type":"User","site_admin":false},"assignees":[{"login":"dachary","id":433594,"avatar_url":"https://avatars.githubusercontent.com/u/433594?v=3","gravatar_id":"","url":"https://api.github.com/users/dachary","html_url":"https://github.com/dachary","followers_url":"https://api.github.com/users/dachary/followers","following_url":"https://api.github.com/users/dachary/following{/other_user}","gists_url":"https://api.github.com/users/dachary/gists{/gist_id}","starred_url":"https://api.github.com/users/dachary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dachary/subscriptions","organizations_url":"https://api.github.com/users/dachary/orgs","repos_url":"https://api.github.com/users/dachary/repos","events_url":"https://api.github.com/users/dachary/events{/privacy}","received_events_url":"https://api.github.com/users/dachary/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/11086/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/11086/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/11086/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/d43c5c4e4bf807e05a180f114d7dc13d1af51a8d","head":{"label":"bassamtabbara:wip-ec-simd-runtime-detection","ref":"wip-ec-simd-runtime-detection","sha":"d43c5c4e4bf807e05a180f114d7dc13d1af51a8d","user":{"login":"bassamtabbara","id":1463491,"avatar_url":"https://avatars.githubusercontent.com/u/1463491?v=3","gravatar_id":"","url":"https://api.github.com/users/bassamtabbara","html_url":"https://github.com/bassamtabbara","followers_url":"https://api.github.com/users/bassamtabbara/followers","following_url":"https://api.github.com/users/bassamtabbara/following{/other_user}","gists_url":"https://api.github.com/users/bassamtabbara/gists{/gist_id}","starred_url":"https://api.github.com/users/bassamtabbara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bassamtabbara/subscriptions","organizations_url":"https://api.github.com/users/bassamtabbara/orgs","repos_url":"https://api.github.com/users/bassamtabbara/repos","events_url":"https://api.github.com/users/bassamtabbara/events{/privacy}","received_events_url":"https://api.github.com/users/bassamtabbara/received_events","type":"User","site_admin":false},"repo":{"id":67741532,"name":"ceph","full_name":"bassamtabbara/ceph","owner":{"login":"bassamtabbara","id":1463491,"avatar_url":"https://avatars.githubusercontent.com/u/1463491?v=3","gravatar_id":"","url":"https://api.github.com/users/bassamtabbara","html_url":"https://github.com/bassamtabbara","followers_url":"https://api.github.com/users/bassamtabbara/followers","following_url":"https://api.github.com/users/bassamtabbara/following{/other_user}","gists_url":"https://api.github.com/users/bassamtabbara/gists{/gist_id}","starred_url":"https://api.github.com/users/bassamtabbara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bassamtabbara/subscriptions","organizations_url":"https://api.github.com/users/bassamtabbara/orgs","repos_url":"https://api.github.com/users/bassamtabbara/repos","events_url":"https://api.github.com/users/bassamtabbara/events{/privacy}","received_events_url":"https://api.github.com/users/bassamtabbara/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bassamtabbara/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/bassamtabbara/ceph","forks_url":"https://api.github.com/repos/bassamtabbara/ceph/forks","keys_url":"https://api.github.com/repos/bassamtabbara/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bassamtabbara/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bassamtabbara/ceph/teams","hooks_url":"https://api.github.com/repos/bassamtabbara/ceph/hooks","issue_events_url":"https://api.github.com/repos/bassamtabbara/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/bassamtabbara/ceph/events","assignees_url":"https://api.github.com/repos/bassamtabbara/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/bassamtabbara/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/bassamtabbara/ceph/tags","blobs_url":"https://api.github.com/repos/bassamtabbara/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bassamtabbara/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bassamtabbara/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/bassamtabbara/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bassamtabbara/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/bassamtabbara/ceph/languages","stargazers_url":"https://api.github.com/repos/bassamtabbara/ceph/stargazers","contributors_url":"https://api.github.com/repos/bassamtabbara/ceph/contributors","subscribers_url":"https://api.github.com/repos/bassamtabbara/ceph/subscribers","subscription_url":"https://api.github.com/repos/bassamtabbara/ceph/subscription","commits_url":"https://api.github.com/repos/bassamtabbara/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/bassamtabbara/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/bassamtabbara/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/bassamtabbara/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/bassamtabbara/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/bassamtabbara/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bassamtabbara/ceph/merges","archive_url":"https://api.github.com/repos/bassamtabbara/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bassamtabbara/ceph/downloads","issues_url":"https://api.github.com/repos/bassamtabbara/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/bassamtabbara/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/bassamtabbara/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/bassamtabbara/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bassamtabbara/ceph/labels{/name}","releases_url":"https://api.github.com/repos/bassamtabbara/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/bassamtabbara/ceph/deployments","created_at":"2016-09-08T21:26:48Z","updated_at":"2016-09-08T21:27:26Z","pushed_at":"2016-09-20T15:52:20Z","git_url":"git://github.com/bassamtabbara/ceph.git","ssh_url":"git@github.com:bassamtabbara/ceph.git","clone_url":"https://github.com/bassamtabbara/ceph.git","svn_url":"https://github.com/bassamtabbara/ceph","homepage":"http://ceph.com","size":183901,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"7ba8d71f127e7e1656a78b21c1f616ffc2576a88","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2016-09-20T14:05:02Z","pushed_at":"2016-09-20T18:56:18Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":243462,"stargazers_count":2483,"watchers_count":2483,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1467,"mirror_url":null,"open_issues_count":426,"forks":1467,"open_issues":426,"watchers":2483,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/11086"},"html":{"href":"https://github.com/ceph/ceph/pull/11086"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/11086"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/11086/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/11086/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/11086/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/d43c5c4e4bf807e05a180f114d7dc13d1af51a8d"}}}}
{"actor":{"display_login":"bassamtabbara"}}