{"action":"closed","number":34,"pull_request":{"url":"https://api.github.com/repos/khiet/eho/pulls/34","id":60947493,"html_url":"https://github.com/khiet/eho/pull/34","diff_url":"https://github.com/khiet/eho/pull/34.diff","patch_url":"https://github.com/khiet/eho/pull/34.patch","issue_url":"https://api.github.com/repos/khiet/eho/issues/34","number":34,"state":"closed","locked":false,"title":"Enable search menus by geolocation","user":{"login":"khiet","id":310614,"avatar_url":"https://avatars.githubusercontent.com/u/310614?v=3","gravatar_id":"","url":"https://api.github.com/users/khiet","html_url":"https://github.com/khiet","followers_url":"https://api.github.com/users/khiet/followers","following_url":"https://api.github.com/users/khiet/following{/other_user}","gists_url":"https://api.github.com/users/khiet/gists{/gist_id}","starred_url":"https://api.github.com/users/khiet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khiet/subscriptions","organizations_url":"https://api.github.com/users/khiet/orgs","repos_url":"https://api.github.com/users/khiet/repos","events_url":"https://api.github.com/users/khiet/events{/privacy}","received_events_url":"https://api.github.com/users/khiet/received_events","type":"User","site_admin":false},"body":"  - user has postcode, lat, lng\r\n  - menu has lat, lng which gets copied from user's for efficient search\r\n    on menus\r\n  - lat/lng from user gets copied into menus when user's postcode is added/changed\r\n  - user has a validation to ensure postcode exists before saving it into the column, the lat/lng will be set together with the correct postcode\r\n  - menus's lat/lng will be updated whenever user successfully updates\r\n    postcode\r\n  - menu will have lat/lng set to nil if user doesn't have them set yet\r\n    - assumptions:\r\n      - menus are not published until user completes essential details\r\n        inc. postocde (to be implemented later)\r\n      - user can never change postcode to invalid postcode (inc. nil)\r\n        once set so that any update on postcode will be valid postcode\r\n        on user and subsequently, menus will have correct lat/lng\r\n  - postcode lookup is via postcode.io which seems to be more accurate\r\n    than using GoogleGeocoder from Geokit","created_at":"2016-02-27T11:40:12Z","updated_at":"2016-02-27T13:11:26Z","closed_at":"2016-02-27T13:11:26Z","merged_at":"2016-02-27T13:11:26Z","merge_commit_sha":"822cf5aed76e2c1543f195de39ef55e0e7999dc7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/khiet/eho/pulls/34/commits","review_comments_url":"https://api.github.com/repos/khiet/eho/pulls/34/comments","review_comment_url":"https://api.github.com/repos/khiet/eho/pulls/comments{/number}","comments_url":"https://api.github.com/repos/khiet/eho/issues/34/comments","statuses_url":"https://api.github.com/repos/khiet/eho/statuses/c116e2f0d20236d8dd6ef113dd53ca1bd398c06e","head":{"label":"khiet:enable-search-menus-by-geolocation","ref":"enable-search-menus-by-geolocation","sha":"c116e2f0d20236d8dd6ef113dd53ca1bd398c06e","user":{"login":"khiet","id":310614,"avatar_url":"https://avatars.githubusercontent.com/u/310614?v=3","gravatar_id":"","url":"https://api.github.com/users/khiet","html_url":"https://github.com/khiet","followers_url":"https://api.github.com/users/khiet/followers","following_url":"https://api.github.com/users/khiet/following{/other_user}","gists_url":"https://api.github.com/users/khiet/gists{/gist_id}","starred_url":"https://api.github.com/users/khiet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khiet/subscriptions","organizations_url":"https://api.github.com/users/khiet/orgs","repos_url":"https://api.github.com/users/khiet/repos","events_url":"https://api.github.com/users/khiet/events{/privacy}","received_events_url":"https://api.github.com/users/khiet/received_events","type":"User","site_admin":false},"repo":{"id":45418314,"name":"eho","full_name":"khiet/eho","owner":{"login":"khiet","id":310614,"avatar_url":"https://avatars.githubusercontent.com/u/310614?v=3","gravatar_id":"","url":"https://api.github.com/users/khiet","html_url":"https://github.com/khiet","followers_url":"https://api.github.com/users/khiet/followers","following_url":"https://api.github.com/users/khiet/following{/other_user}","gists_url":"https://api.github.com/users/khiet/gists{/gist_id}","starred_url":"https://api.github.com/users/khiet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khiet/subscriptions","organizations_url":"https://api.github.com/users/khiet/orgs","repos_url":"https://api.github.com/users/khiet/repos","events_url":"https://api.github.com/users/khiet/events{/privacy}","received_events_url":"https://api.github.com/users/khiet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/khiet/eho","description":"","fork":false,"url":"https://api.github.com/repos/khiet/eho","forks_url":"https://api.github.com/repos/khiet/eho/forks","keys_url":"https://api.github.com/repos/khiet/eho/keys{/key_id}","collaborators_url":"https://api.github.com/repos/khiet/eho/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/khiet/eho/teams","hooks_url":"https://api.github.com/repos/khiet/eho/hooks","issue_events_url":"https://api.github.com/repos/khiet/eho/issues/events{/number}","events_url":"https://api.github.com/repos/khiet/eho/events","assignees_url":"https://api.github.com/repos/khiet/eho/assignees{/user}","branches_url":"https://api.github.com/repos/khiet/eho/branches{/branch}","tags_url":"https://api.github.com/repos/khiet/eho/tags","blobs_url":"https://api.github.com/repos/khiet/eho/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/khiet/eho/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/khiet/eho/git/refs{/sha}","trees_url":"https://api.github.com/repos/khiet/eho/git/trees{/sha}","statuses_url":"https://api.github.com/repos/khiet/eho/statuses/{sha}","languages_url":"https://api.github.com/repos/khiet/eho/languages","stargazers_url":"https://api.github.com/repos/khiet/eho/stargazers","contributors_url":"https://api.github.com/repos/khiet/eho/contributors","subscribers_url":"https://api.github.com/repos/khiet/eho/subscribers","subscription_url":"https://api.github.com/repos/khiet/eho/subscription","commits_url":"https://api.github.com/repos/khiet/eho/commits{/sha}","git_commits_url":"https://api.github.com/repos/khiet/eho/git/commits{/sha}","comments_url":"https://api.github.com/repos/khiet/eho/comments{/number}","issue_comment_url":"https://api.github.com/repos/khiet/eho/issues/comments{/number}","contents_url":"https://api.github.com/repos/khiet/eho/contents/{+path}","compare_url":"https://api.github.com/repos/khiet/eho/compare/{base}...{head}","merges_url":"https://api.github.com/repos/khiet/eho/merges","archive_url":"https://api.github.com/repos/khiet/eho/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/khiet/eho/downloads","issues_url":"https://api.github.com/repos/khiet/eho/issues{/number}","pulls_url":"https://api.github.com/repos/khiet/eho/pulls{/number}","milestones_url":"https://api.github.com/repos/khiet/eho/milestones{/number}","notifications_url":"https://api.github.com/repos/khiet/eho/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/khiet/eho/labels{/name}","releases_url":"https://api.github.com/repos/khiet/eho/releases{/id}","deployments_url":"https://api.github.com/repos/khiet/eho/deployments","created_at":"2015-11-02T19:54:04Z","updated_at":"2016-01-11T21:27:41Z","pushed_at":"2016-02-27T13:11:26Z","git_url":"git://github.com/khiet/eho.git","ssh_url":"git@github.com:khiet/eho.git","clone_url":"https://github.com/khiet/eho.git","svn_url":"https://github.com/khiet/eho","homepage":null,"size":1102,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"khiet:master","ref":"master","sha":"1070ca25469d5f9e0e724b28c051a57403bb8696","user":{"login":"khiet","id":310614,"avatar_url":"https://avatars.githubusercontent.com/u/310614?v=3","gravatar_id":"","url":"https://api.github.com/users/khiet","html_url":"https://github.com/khiet","followers_url":"https://api.github.com/users/khiet/followers","following_url":"https://api.github.com/users/khiet/following{/other_user}","gists_url":"https://api.github.com/users/khiet/gists{/gist_id}","starred_url":"https://api.github.com/users/khiet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khiet/subscriptions","organizations_url":"https://api.github.com/users/khiet/orgs","repos_url":"https://api.github.com/users/khiet/repos","events_url":"https://api.github.com/users/khiet/events{/privacy}","received_events_url":"https://api.github.com/users/khiet/received_events","type":"User","site_admin":false},"repo":{"id":45418314,"name":"eho","full_name":"khiet/eho","owner":{"login":"khiet","id":310614,"avatar_url":"https://avatars.githubusercontent.com/u/310614?v=3","gravatar_id":"","url":"https://api.github.com/users/khiet","html_url":"https://github.com/khiet","followers_url":"https://api.github.com/users/khiet/followers","following_url":"https://api.github.com/users/khiet/following{/other_user}","gists_url":"https://api.github.com/users/khiet/gists{/gist_id}","starred_url":"https://api.github.com/users/khiet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khiet/subscriptions","organizations_url":"https://api.github.com/users/khiet/orgs","repos_url":"https://api.github.com/users/khiet/repos","events_url":"https://api.github.com/users/khiet/events{/privacy}","received_events_url":"https://api.github.com/users/khiet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/khiet/eho","description":"","fork":false,"url":"https://api.github.com/repos/khiet/eho","forks_url":"https://api.github.com/repos/khiet/eho/forks","keys_url":"https://api.github.com/repos/khiet/eho/keys{/key_id}","collaborators_url":"https://api.github.com/repos/khiet/eho/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/khiet/eho/teams","hooks_url":"https://api.github.com/repos/khiet/eho/hooks","issue_events_url":"https://api.github.com/repos/khiet/eho/issues/events{/number}","events_url":"https://api.github.com/repos/khiet/eho/events","assignees_url":"https://api.github.com/repos/khiet/eho/assignees{/user}","branches_url":"https://api.github.com/repos/khiet/eho/branches{/branch}","tags_url":"https://api.github.com/repos/khiet/eho/tags","blobs_url":"https://api.github.com/repos/khiet/eho/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/khiet/eho/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/khiet/eho/git/refs{/sha}","trees_url":"https://api.github.com/repos/khiet/eho/git/trees{/sha}","statuses_url":"https://api.github.com/repos/khiet/eho/statuses/{sha}","languages_url":"https://api.github.com/repos/khiet/eho/languages","stargazers_url":"https://api.github.com/repos/khiet/eho/stargazers","contributors_url":"https://api.github.com/repos/khiet/eho/contributors","subscribers_url":"https://api.github.com/repos/khiet/eho/subscribers","subscription_url":"https://api.github.com/repos/khiet/eho/subscription","commits_url":"https://api.github.com/repos/khiet/eho/commits{/sha}","git_commits_url":"https://api.github.com/repos/khiet/eho/git/commits{/sha}","comments_url":"https://api.github.com/repos/khiet/eho/comments{/number}","issue_comment_url":"https://api.github.com/repos/khiet/eho/issues/comments{/number}","contents_url":"https://api.github.com/repos/khiet/eho/contents/{+path}","compare_url":"https://api.github.com/repos/khiet/eho/compare/{base}...{head}","merges_url":"https://api.github.com/repos/khiet/eho/merges","archive_url":"https://api.github.com/repos/khiet/eho/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/khiet/eho/downloads","issues_url":"https://api.github.com/repos/khiet/eho/issues{/number}","pulls_url":"https://api.github.com/repos/khiet/eho/pulls{/number}","milestones_url":"https://api.github.com/repos/khiet/eho/milestones{/number}","notifications_url":"https://api.github.com/repos/khiet/eho/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/khiet/eho/labels{/name}","releases_url":"https://api.github.com/repos/khiet/eho/releases{/id}","deployments_url":"https://api.github.com/repos/khiet/eho/deployments","created_at":"2015-11-02T19:54:04Z","updated_at":"2016-01-11T21:27:41Z","pushed_at":"2016-02-27T13:11:26Z","git_url":"git://github.com/khiet/eho.git","ssh_url":"git@github.com:khiet/eho.git","clone_url":"https://github.com/khiet/eho.git","svn_url":"https://github.com/khiet/eho","homepage":null,"size":1102,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/khiet/eho/pulls/34"},"html":{"href":"https://github.com/khiet/eho/pull/34"},"issue":{"href":"https://api.github.com/repos/khiet/eho/issues/34"},"comments":{"href":"https://api.github.com/repos/khiet/eho/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/khiet/eho/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/khiet/eho/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/khiet/eho/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/khiet/eho/statuses/c116e2f0d20236d8dd6ef113dd53ca1bd398c06e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"khiet","id":310614,"avatar_url":"https://avatars.githubusercontent.com/u/310614?v=3","gravatar_id":"","url":"https://api.github.com/users/khiet","html_url":"https://github.com/khiet","followers_url":"https://api.github.com/users/khiet/followers","following_url":"https://api.github.com/users/khiet/following{/other_user}","gists_url":"https://api.github.com/users/khiet/gists{/gist_id}","starred_url":"https://api.github.com/users/khiet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khiet/subscriptions","organizations_url":"https://api.github.com/users/khiet/orgs","repos_url":"https://api.github.com/users/khiet/repos","events_url":"https://api.github.com/users/khiet/events{/privacy}","received_events_url":"https://api.github.com/users/khiet/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":326,"deletions":28,"changed_files":19}}