{"action":"created","issue":{"url":"https://api.github.com/repos/slamdata/slamdata/issues/915","repository_url":"https://api.github.com/repos/slamdata/slamdata","labels_url":"https://api.github.com/repos/slamdata/slamdata/issues/915/labels{/name}","comments_url":"https://api.github.com/repos/slamdata/slamdata/issues/915/comments","events_url":"https://api.github.com/repos/slamdata/slamdata/issues/915/events","html_url":"https://github.com/slamdata/slamdata/pull/915","id":165653796,"number":915,"title":"SD-1783: chart options error","user":{"login":"cryogenian","id":10245930,"avatar_url":"https://avatars.githubusercontent.com/u/10245930?v=3","gravatar_id":"","url":"https://api.github.com/users/cryogenian","html_url":"https://github.com/cryogenian","followers_url":"https://api.github.com/users/cryogenian/followers","following_url":"https://api.github.com/users/cryogenian/following{/other_user}","gists_url":"https://api.github.com/users/cryogenian/gists{/gist_id}","starred_url":"https://api.github.com/users/cryogenian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cryogenian/subscriptions","organizations_url":"https://api.github.com/users/cryogenian/orgs","repos_url":"https://api.github.com/users/cryogenian/repos","events_url":"https://api.github.com/users/cryogenian/events{/privacy}","received_events_url":"https://api.github.com/users/cryogenian/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/slamdata/slamdata/labels/in%20review","name":"in review","color":"fbca04"}],"state":"open","locked":false,"assignee":{"login":"natefaubion","id":144058,"avatar_url":"https://avatars.githubusercontent.com/u/144058?v=3","gravatar_id":"","url":"https://api.github.com/users/natefaubion","html_url":"https://github.com/natefaubion","followers_url":"https://api.github.com/users/natefaubion/followers","following_url":"https://api.github.com/users/natefaubion/following{/other_user}","gists_url":"https://api.github.com/users/natefaubion/gists{/gist_id}","starred_url":"https://api.github.com/users/natefaubion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natefaubion/subscriptions","organizations_url":"https://api.github.com/users/natefaubion/orgs","repos_url":"https://api.github.com/users/natefaubion/repos","events_url":"https://api.github.com/users/natefaubion/events{/privacy}","received_events_url":"https://api.github.com/users/natefaubion/received_events","type":"User","site_admin":false},"assignees":[{"login":"natefaubion","id":144058,"avatar_url":"https://avatars.githubusercontent.com/u/144058?v=3","gravatar_id":"","url":"https://api.github.com/users/natefaubion","html_url":"https://github.com/natefaubion","followers_url":"https://api.github.com/users/natefaubion/followers","following_url":"https://api.github.com/users/natefaubion/following{/other_user}","gists_url":"https://api.github.com/users/natefaubion/gists{/gist_id}","starred_url":"https://api.github.com/users/natefaubion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natefaubion/subscriptions","organizations_url":"https://api.github.com/users/natefaubion/orgs","repos_url":"https://api.github.com/users/natefaubion/repos","events_url":"https://api.github.com/users/natefaubion/events{/privacy}","received_events_url":"https://api.github.com/users/natefaubion/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-07-14T20:41:32Z","updated_at":"2016-07-14T21:49:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/slamdata/slamdata/pulls/915","html_url":"https://github.com/slamdata/slamdata/pull/915","diff_url":"https://github.com/slamdata/slamdata/pull/915.diff","patch_url":"https://github.com/slamdata/slamdata/pull/915.patch"},"body":"Moved almost all preparation from `Component` to `Eval` \r\n\r\nThis fixes \r\n+ No available chart types returns error. User can't add chart after this card\r\n+ User must select at least one measure and dimension or category. \r\n\r\nThis doesn't fix \r\n+ When user fixes underlying datasource that previously had no available chart types it's possible to have empty chart. I don't know how to achieve this w/o modifying `CardError String -> CardError String (AnyCardState -> AnyCardState)`. If this modification sounds ok, I'll make an issue in jira, and fix it in separate pr. \r\n\r\n@natefaubion Please, review"},"comment":{"url":"https://api.github.com/repos/slamdata/slamdata/issues/comments/232802850","html_url":"https://github.com/slamdata/slamdata/pull/915#issuecomment-232802850","issue_url":"https://api.github.com/repos/slamdata/slamdata/issues/915","id":232802850,"user":{"login":"cryogenian","id":10245930,"avatar_url":"https://avatars.githubusercontent.com/u/10245930?v=3","gravatar_id":"","url":"https://api.github.com/users/cryogenian","html_url":"https://github.com/cryogenian","followers_url":"https://api.github.com/users/cryogenian/followers","following_url":"https://api.github.com/users/cryogenian/following{/other_user}","gists_url":"https://api.github.com/users/cryogenian/gists{/gist_id}","starred_url":"https://api.github.com/users/cryogenian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cryogenian/subscriptions","organizations_url":"https://api.github.com/users/cryogenian/orgs","repos_url":"https://api.github.com/users/cryogenian/repos","events_url":"https://api.github.com/users/cryogenian/events{/privacy}","received_events_url":"https://api.github.com/users/cryogenian/received_events","type":"User","site_admin":false},"created_at":"2016-07-14T21:49:34Z","updated_at":"2016-07-14T21:49:34Z","body":"Actually if we had two different cards it would work like \r\n+ Datasource is changed \r\n+ Data analyzed in `Save` handler and emits `Model` that can be rendered as form. \r\n+ Form selects activated and chart options are emitted. \r\n+ Chart displayed\r\n+ Datasource is changed\r\n+ Data analyzed in `Save`, `Model` has no available charts or empty or something\r\n+ Analyze card emits error \r\n+ Chart and Form are hidden\r\n+ Datasource is changed \r\n+ Data analyzed in `Save`, `Model` is emitted\r\n+ Form is updated and reset. It has no any selected values and emits error\r\n+ Chart is hidden\r\n:tada: "}}
{"actor":{"display_login":"cryogenian"}}