{"action":"created","comment":{"url":"https://api.github.com/repos/inliniac/suricata/pulls/comments/66712212","id":66712212,"diff_hunk":"@@ -153,8 +153,8 @@ int UnixNew(UnixCommand * this)\n     /* set address */\n     addr.sun_family = AF_UNIX;\n     strlcpy(addr.sun_path, sockettarget, sizeof(addr.sun_path));\n-    addr.sun_path[sizeof(addr.sun_path) - 1] = 0;\n-    len = strlen(addr.sun_path) + sizeof(addr.sun_family);\n+    addr.sun_path[sizeof(addr.sun_path) - 1] = 0;    ","path":"src/unix-manager.c","position":6,"original_position":6,"commit_id":"e51aa82db1be288264a1dd879b7728d53b1b67fa","original_commit_id":"57e21be61ea5ae5aca308791c2e83a699ab25ed0","user":{"login":"regit","id":308616,"avatar_url":"https://avatars.githubusercontent.com/u/308616?v=3","gravatar_id":"","url":"https://api.github.com/users/regit","html_url":"https://github.com/regit","followers_url":"https://api.github.com/users/regit/followers","following_url":"https://api.github.com/users/regit/following{/other_user}","gists_url":"https://api.github.com/users/regit/gists{/gist_id}","starred_url":"https://api.github.com/users/regit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/regit/subscriptions","organizations_url":"https://api.github.com/users/regit/orgs","repos_url":"https://api.github.com/users/regit/repos","events_url":"https://api.github.com/users/regit/events{/privacy}","received_events_url":"https://api.github.com/users/regit/received_events","type":"User","site_admin":false},"body":"White added space at end of line.","created_at":"2016-06-11T21:50:38Z","updated_at":"2016-06-11T21:50:38Z","html_url":"https://github.com/inliniac/suricata/pull/2145#discussion_r66712212","pull_request_url":"https://api.github.com/repos/inliniac/suricata/pulls/2145","_links":{"self":{"href":"https://api.github.com/repos/inliniac/suricata/pulls/comments/66712212"},"html":{"href":"https://github.com/inliniac/suricata/pull/2145#discussion_r66712212"},"pull_request":{"href":"https://api.github.com/repos/inliniac/suricata/pulls/2145"}}},"pull_request":{"url":"https://api.github.com/repos/inliniac/suricata/pulls/2145","id":73406989,"html_url":"https://github.com/inliniac/suricata/pull/2145","diff_url":"https://github.com/inliniac/suricata/pull/2145.diff","patch_url":"https://github.com/inliniac/suricata/pull/2145.patch","issue_url":"https://api.github.com/repos/inliniac/suricata/issues/2145","number":2145,"state":"open","locked":false,"title":"minor issue fixed about unix-manager.c","user":{"login":"hellojixian","id":3461930,"avatar_url":"https://avatars.githubusercontent.com/u/3461930?v=3","gravatar_id":"","url":"https://api.github.com/users/hellojixian","html_url":"https://github.com/hellojixian","followers_url":"https://api.github.com/users/hellojixian/followers","following_url":"https://api.github.com/users/hellojixian/following{/other_user}","gists_url":"https://api.github.com/users/hellojixian/gists{/gist_id}","starred_url":"https://api.github.com/users/hellojixian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hellojixian/subscriptions","organizations_url":"https://api.github.com/users/hellojixian/orgs","repos_url":"https://api.github.com/users/hellojixian/repos","events_url":"https://api.github.com/users/hellojixian/events{/privacy}","received_events_url":"https://api.github.com/users/hellojixian/received_events","type":"User","site_admin":false},"body":"the LEN calculation of unix socket address is incorrect, it will cause the last character get cut off.\r\nby referencing the unix manual, its recommended to use SUN_LEN Marco instead of do it manually\r\n\r\nreference link:\r\nhttps://www.freebsd.org/cgi/man.cgi?query=unix&sektion=4&manpath=FreeBSD+7.2-RELEASE\r\n\"The length\tof UNIX-domain address,\trequired by bind(2) and\tconnect(2),\r\n     can be calculated by the macro SUN_LEN() defined in <sys/un.h>.  The\r\n     sun_path field must be terminated by a NUL\tcharacter to be\tused with\r\n     SUN_LEN(),\tbut the\tterminating NUL\tis not part of the address.\"","created_at":"2016-06-10T17:20:13Z","updated_at":"2016-06-11T21:50:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da02d13a88f22321fd2e3fae89864879b8b7718a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/inliniac/suricata/pulls/2145/commits","review_comments_url":"https://api.github.com/repos/inliniac/suricata/pulls/2145/comments","review_comment_url":"https://api.github.com/repos/inliniac/suricata/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inliniac/suricata/issues/2145/comments","statuses_url":"https://api.github.com/repos/inliniac/suricata/statuses/e51aa82db1be288264a1dd879b7728d53b1b67fa","head":{"label":"hellojixian:master","ref":"master","sha":"e51aa82db1be288264a1dd879b7728d53b1b67fa","user":{"login":"hellojixian","id":3461930,"avatar_url":"https://avatars.githubusercontent.com/u/3461930?v=3","gravatar_id":"","url":"https://api.github.com/users/hellojixian","html_url":"https://github.com/hellojixian","followers_url":"https://api.github.com/users/hellojixian/followers","following_url":"https://api.github.com/users/hellojixian/following{/other_user}","gists_url":"https://api.github.com/users/hellojixian/gists{/gist_id}","starred_url":"https://api.github.com/users/hellojixian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hellojixian/subscriptions","organizations_url":"https://api.github.com/users/hellojixian/orgs","repos_url":"https://api.github.com/users/hellojixian/repos","events_url":"https://api.github.com/users/hellojixian/events{/privacy}","received_events_url":"https://api.github.com/users/hellojixian/received_events","type":"User","site_admin":false},"repo":{"id":58284180,"name":"suricata","full_name":"hellojixian/suricata","owner":{"login":"hellojixian","id":3461930,"avatar_url":"https://avatars.githubusercontent.com/u/3461930?v=3","gravatar_id":"","url":"https://api.github.com/users/hellojixian","html_url":"https://github.com/hellojixian","followers_url":"https://api.github.com/users/hellojixian/followers","following_url":"https://api.github.com/users/hellojixian/following{/other_user}","gists_url":"https://api.github.com/users/hellojixian/gists{/gist_id}","starred_url":"https://api.github.com/users/hellojixian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hellojixian/subscriptions","organizations_url":"https://api.github.com/users/hellojixian/orgs","repos_url":"https://api.github.com/users/hellojixian/repos","events_url":"https://api.github.com/users/hellojixian/events{/privacy}","received_events_url":"https://api.github.com/users/hellojixian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hellojixian/suricata","description":"Mirror of the official OISF Suricata git repository","fork":true,"url":"https://api.github.com/repos/hellojixian/suricata","forks_url":"https://api.github.com/repos/hellojixian/suricata/forks","keys_url":"https://api.github.com/repos/hellojixian/suricata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hellojixian/suricata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hellojixian/suricata/teams","hooks_url":"https://api.github.com/repos/hellojixian/suricata/hooks","issue_events_url":"https://api.github.com/repos/hellojixian/suricata/issues/events{/number}","events_url":"https://api.github.com/repos/hellojixian/suricata/events","assignees_url":"https://api.github.com/repos/hellojixian/suricata/assignees{/user}","branches_url":"https://api.github.com/repos/hellojixian/suricata/branches{/branch}","tags_url":"https://api.github.com/repos/hellojixian/suricata/tags","blobs_url":"https://api.github.com/repos/hellojixian/suricata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hellojixian/suricata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hellojixian/suricata/git/refs{/sha}","trees_url":"https://api.github.com/repos/hellojixian/suricata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hellojixian/suricata/statuses/{sha}","languages_url":"https://api.github.com/repos/hellojixian/suricata/languages","stargazers_url":"https://api.github.com/repos/hellojixian/suricata/stargazers","contributors_url":"https://api.github.com/repos/hellojixian/suricata/contributors","subscribers_url":"https://api.github.com/repos/hellojixian/suricata/subscribers","subscription_url":"https://api.github.com/repos/hellojixian/suricata/subscription","commits_url":"https://api.github.com/repos/hellojixian/suricata/commits{/sha}","git_commits_url":"https://api.github.com/repos/hellojixian/suricata/git/commits{/sha}","comments_url":"https://api.github.com/repos/hellojixian/suricata/comments{/number}","issue_comment_url":"https://api.github.com/repos/hellojixian/suricata/issues/comments{/number}","contents_url":"https://api.github.com/repos/hellojixian/suricata/contents/{+path}","compare_url":"https://api.github.com/repos/hellojixian/suricata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hellojixian/suricata/merges","archive_url":"https://api.github.com/repos/hellojixian/suricata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hellojixian/suricata/downloads","issues_url":"https://api.github.com/repos/hellojixian/suricata/issues{/number}","pulls_url":"https://api.github.com/repos/hellojixian/suricata/pulls{/number}","milestones_url":"https://api.github.com/repos/hellojixian/suricata/milestones{/number}","notifications_url":"https://api.github.com/repos/hellojixian/suricata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hellojixian/suricata/labels{/name}","releases_url":"https://api.github.com/repos/hellojixian/suricata/releases{/id}","deployments_url":"https://api.github.com/repos/hellojixian/suricata/deployments","created_at":"2016-05-07T20:57:56Z","updated_at":"2016-05-07T20:58:01Z","pushed_at":"2016-06-10T17:55:04Z","git_url":"git://github.com/hellojixian/suricata.git","ssh_url":"git@github.com:hellojixian/suricata.git","clone_url":"https://github.com/hellojixian/suricata.git","svn_url":"https://github.com/hellojixian/suricata","homepage":"http://suricata-ids.org/","size":38494,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"inliniac:master","ref":"master","sha":"66346e463211044d82bd80e943bd0cfc5b8c7bd2","user":{"login":"inliniac","id":719366,"avatar_url":"https://avatars.githubusercontent.com/u/719366?v=3","gravatar_id":"","url":"https://api.github.com/users/inliniac","html_url":"https://github.com/inliniac","followers_url":"https://api.github.com/users/inliniac/followers","following_url":"https://api.github.com/users/inliniac/following{/other_user}","gists_url":"https://api.github.com/users/inliniac/gists{/gist_id}","starred_url":"https://api.github.com/users/inliniac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inliniac/subscriptions","organizations_url":"https://api.github.com/users/inliniac/orgs","repos_url":"https://api.github.com/users/inliniac/repos","events_url":"https://api.github.com/users/inliniac/events{/privacy}","received_events_url":"https://api.github.com/users/inliniac/received_events","type":"User","site_admin":false},"repo":{"id":5410234,"name":"suricata","full_name":"inliniac/suricata","owner":{"login":"inliniac","id":719366,"avatar_url":"https://avatars.githubusercontent.com/u/719366?v=3","gravatar_id":"","url":"https://api.github.com/users/inliniac","html_url":"https://github.com/inliniac","followers_url":"https://api.github.com/users/inliniac/followers","following_url":"https://api.github.com/users/inliniac/following{/other_user}","gists_url":"https://api.github.com/users/inliniac/gists{/gist_id}","starred_url":"https://api.github.com/users/inliniac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inliniac/subscriptions","organizations_url":"https://api.github.com/users/inliniac/orgs","repos_url":"https://api.github.com/users/inliniac/repos","events_url":"https://api.github.com/users/inliniac/events{/privacy}","received_events_url":"https://api.github.com/users/inliniac/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/inliniac/suricata","description":"Mirror of the official OISF Suricata git repository","fork":false,"url":"https://api.github.com/repos/inliniac/suricata","forks_url":"https://api.github.com/repos/inliniac/suricata/forks","keys_url":"https://api.github.com/repos/inliniac/suricata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inliniac/suricata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inliniac/suricata/teams","hooks_url":"https://api.github.com/repos/inliniac/suricata/hooks","issue_events_url":"https://api.github.com/repos/inliniac/suricata/issues/events{/number}","events_url":"https://api.github.com/repos/inliniac/suricata/events","assignees_url":"https://api.github.com/repos/inliniac/suricata/assignees{/user}","branches_url":"https://api.github.com/repos/inliniac/suricata/branches{/branch}","tags_url":"https://api.github.com/repos/inliniac/suricata/tags","blobs_url":"https://api.github.com/repos/inliniac/suricata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inliniac/suricata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inliniac/suricata/git/refs{/sha}","trees_url":"https://api.github.com/repos/inliniac/suricata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inliniac/suricata/statuses/{sha}","languages_url":"https://api.github.com/repos/inliniac/suricata/languages","stargazers_url":"https://api.github.com/repos/inliniac/suricata/stargazers","contributors_url":"https://api.github.com/repos/inliniac/suricata/contributors","subscribers_url":"https://api.github.com/repos/inliniac/suricata/subscribers","subscription_url":"https://api.github.com/repos/inliniac/suricata/subscription","commits_url":"https://api.github.com/repos/inliniac/suricata/commits{/sha}","git_commits_url":"https://api.github.com/repos/inliniac/suricata/git/commits{/sha}","comments_url":"https://api.github.com/repos/inliniac/suricata/comments{/number}","issue_comment_url":"https://api.github.com/repos/inliniac/suricata/issues/comments{/number}","contents_url":"https://api.github.com/repos/inliniac/suricata/contents/{+path}","compare_url":"https://api.github.com/repos/inliniac/suricata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inliniac/suricata/merges","archive_url":"https://api.github.com/repos/inliniac/suricata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inliniac/suricata/downloads","issues_url":"https://api.github.com/repos/inliniac/suricata/issues{/number}","pulls_url":"https://api.github.com/repos/inliniac/suricata/pulls{/number}","milestones_url":"https://api.github.com/repos/inliniac/suricata/milestones{/number}","notifications_url":"https://api.github.com/repos/inliniac/suricata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inliniac/suricata/labels{/name}","releases_url":"https://api.github.com/repos/inliniac/suricata/releases{/id}","deployments_url":"https://api.github.com/repos/inliniac/suricata/deployments","created_at":"2012-08-14T08:30:06Z","updated_at":"2016-06-08T08:25:13Z","pushed_at":"2016-06-10T17:55:05Z","git_url":"git://github.com/inliniac/suricata.git","ssh_url":"git@github.com:inliniac/suricata.git","clone_url":"https://github.com/inliniac/suricata.git","svn_url":"https://github.com/inliniac/suricata","homepage":"http://suricata-ids.org/","size":60919,"stargazers_count":269,"watchers_count":269,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":251,"mirror_url":null,"open_issues_count":35,"forks":251,"open_issues":35,"watchers":269,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inliniac/suricata/pulls/2145"},"html":{"href":"https://github.com/inliniac/suricata/pull/2145"},"issue":{"href":"https://api.github.com/repos/inliniac/suricata/issues/2145"},"comments":{"href":"https://api.github.com/repos/inliniac/suricata/issues/2145/comments"},"review_comments":{"href":"https://api.github.com/repos/inliniac/suricata/pulls/2145/comments"},"review_comment":{"href":"https://api.github.com/repos/inliniac/suricata/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inliniac/suricata/pulls/2145/commits"},"statuses":{"href":"https://api.github.com/repos/inliniac/suricata/statuses/e51aa82db1be288264a1dd879b7728d53b1b67fa"}}}}
{"actor":{"display_login":"regit"}}