{"push_id":1219019423,"size":24,"distinct_size":1,"ref":"refs/heads/extended_tls_sockets","head":"3545b926af3f672fb14929f19c4ed0f2ad22b966","before":"9b8fd53c77f61640b8e53f0834cd7c545b5a7c9c","commits":[{"sha":"c6db49066fbac12712011ac8dd7bb67cf5f7ad34","author":{"name":"David Cooper","email":"bd07968fe1548f762be87be0de640b4db395569f@gmail.com"},"message":"run_allciphers(),run_cipher_per_proto(), and SSLv2\n\nThis PR addresses two problems related to SSLv2 in run_allciphers() and run_cipher_per_proto().\r\n\r\nIn run_cipher_per_proto(), the call to \"$OPENSSL s_client\" is changed to that $SNI is not included if $proto is -sslv2 or -sslv3. As noted in a comment within run_prototest_openssl(), \"newer openssl throw an error if SNI is supplied with SSLv2\" and \"SSLv3 doesn't have SNI (openssl doesn't complain though -- yet).\"\r\n\r\nrun_allciphers() will sometimes incorrectly report that a server supports an SSLv2 cipher, even if the server does not support SSLv2 at all. The problem occurs if there is a supported SSLv3 cipher suite that has the same OpenSSL name as an SSLv2 cipher suite (e.g., RC4-MD5). Since the call to \"$OPENSSL s_client\" only uses the OpenSSL name, but the results report both the name, hexcode, and RFC cipher suite name, both the SSLv2 and SSLv3 cipher suites are reported as being supported (e.g., 0x04=RC4-MD5=TLS_RSA_WITH_RC4_128_MD5 and x010080=RC4-MD5=SSL_CK_RC4_128_WITH_MD5). This PR fixes the problem by testing SSLv2 cipher suites separately from non-SSLv2 cipher suites.","distinct":false,"url":"https://api.github.com/repos/dcooper16/testssl.sh/commits/c6db49066fbac12712011ac8dd7bb67cf5f7ad34"},{"sha":"fe098d4b394be0ebe230c5332dbbf876426fd6e1","author":{"name":"David Cooper","email":"bd07968fe1548f762be87be0de640b4db395569f@gmail.com"},"message":"Use $HAS_SSL2\n\nI changed the code to use the global $HAS_SSL2 rather than $sslv2_locally_supported.\r\n\r\nI don't think there's a need to use $HAS_SSL3 in run_allciphers(), since the call to \"$OPENSSL s_client\" for non-SSLv2 ciphers does not specify a protocol. It's also not needed in run_cipher_per_proto(), since there is already a call to locally_supported() before anything further is done with a protocol.","distinct":false,"url":"https://api.github.com/repos/dcooper16/testssl.sh/commits/fe098d4b394be0ebe230c5332dbbf876426fd6e1"},{"sha":"91bab81e26e2711d14d64602f7e741ebc9f87b0c","author":{"name":"David Cooper","email":"bd07968fe1548f762be87be0de640b4db395569f@gmail.com"},"message":"\"$OPENSSL ciphers\" ignores \"-tls1_1\" and \"-tls1_2\"\n\nVersions of OpenSSL prior to 1.1.0 ignore the options \"-tls1_1\" and \"-tls1_2\". So, a call of the form \"$OPENSSL ciphers -tls1_2 -V 'ALL:COMPLEMENTOFALL:@STRENGTH' would list all supported ciphers (including SSLv2 ciphers), not just ciphers appropriate for TLS1.2.\r\n\r\nThis changes the code to use \"-tls1\" instead of \"-tls1_1\" or \"-tls1_2\" if a version of OpenSSL other than 1.1.0 is being used.","distinct":false,"url":"https://api.github.com/repos/dcooper16/testssl.sh/commits/91bab81e26e2711d14d64602f7e741ebc9f87b0c"},{"sha":"a503d883c769014cac4ce5412bbfd12bdcdecf60","author":{"name":"David Cooper","email":"bd07968fe1548f762be87be0de640b4db395569f@gmail.com"},"message":"Merge branch 'master' into run_allciphers(),run_cipher_per_proto(),-and-SSLv2","distinct":false,"url":"https://api.github.com/repos/dcooper16/testssl.sh/commits/a503d883c769014cac4ce5412bbfd12bdcdecf60"},{"sha":"f5fcff22d67571162e940a119bf92770b1dfa1e3","author":{"name":"David Cooper","email":"bd07968fe1548f762be87be0de640b4db395569f@gmail.com"},"message":"Merge branch 'master' into run_allciphers(),run_cipher_per_proto(),-and-SSLv2","distinct":false,"url":"https://api.github.com/repos/dcooper16/testssl.sh/commits/f5fcff22d67571162e940a119bf92770b1dfa1e3"},{"sha":"c50f2cc79656382508332d161f3a3c2a00fd9db5","author":{"name":"David Cooper","email":"bd07968fe1548f762be87be0de640b4db395569f@gmail.com"},"message":"Merge branch 'master' into run_allciphers(),run_cipher_per_proto(),-and-SSLv2","distinct":false,"url":"https://api.github.com/repos/dcooper16/testssl.sh/commits/c50f2cc79656382508332d161f3a3c2a00fd9db5"},{"sha":"130aa350d2532e4aa98bdf33ec94c74f1c7621ce","author":{"name":"David Cooper","email":"bd07968fe1548f762be87be0de640b4db395569f@gmail.com"},"message":"Merge branch 'master' into run_allciphers(),run_cipher_per_proto(),-and-SSLv2","distinct":false,"url":"https://api.github.com/repos/dcooper16/testssl.sh/commits/130aa350d2532e4aa98bdf33ec94c74f1c7621ce"},{"sha":"ce9b277b2cac2326fb419bf99c4bce061203dc0a","author":{"name":"David Cooper","email":"bd07968fe1548f762be87be0de640b4db395569f@gmail.com"},"message":"Merge branch 'master' into run_allciphers(),run_cipher_per_proto(),-and-SSLv2","distinct":false,"url":"https://api.github.com/repos/dcooper16/testssl.sh/commits/ce9b277b2cac2326fb419bf99c4bce061203dc0a"},{"sha":"d2bded111414ebf3acfac8207f351cccf38a8fe5","author":{"name":"David Cooper","email":"bd07968fe1548f762be87be0de640b4db395569f@gmail.com"},"message":"Merge branch 'master' into run_allciphers(),run_cipher_per_proto(),-and-SSLv2","distinct":false,"url":"https://api.github.com/repos/dcooper16/testssl.sh/commits/d2bded111414ebf3acfac8207f351cccf38a8fe5"},{"sha":"bf4134844c3cfbad90bda07a23d6e3b08ed15837","author":{"name":"David Cooper","email":"bd07968fe1548f762be87be0de640b4db395569f@gmail.com"},"message":"Merge branch 'master' into run_allciphers(),run_cipher_per_proto(),-and-SSLv2","distinct":false,"url":"https://api.github.com/repos/dcooper16/testssl.sh/commits/bf4134844c3cfbad90bda07a23d6e3b08ed15837"},{"sha":"76ea57863a67e2c0e973a15cb13364e1d7976ea3","author":{"name":"David Cooper","email":"bd07968fe1548f762be87be0de640b4db395569f@gmail.com"},"message":"Merge branch 'master' into run_allciphers(),run_cipher_per_proto(),-and-SSLv2","distinct":false,"url":"https://api.github.com/repos/dcooper16/testssl.sh/commits/76ea57863a67e2c0e973a15cb13364e1d7976ea3"},{"sha":"321a8bfe579c642669d769351b93a835b062d9d0","author":{"name":"David Cooper","email":"bd07968fe1548f762be87be0de640b4db395569f@gmail.com"},"message":"Merge branch 'master' into run_allciphers(),run_cipher_per_proto(),-and-SSLv2","distinct":false,"url":"https://api.github.com/repos/dcooper16/testssl.sh/commits/321a8bfe579c642669d769351b93a835b062d9d0"},{"sha":"a53ee051f6ab83f9cc2d88a961a6b6ed1bcd3bcc","author":{"name":"David Cooper","email":"bd07968fe1548f762be87be0de640b4db395569f@gmail.com"},"message":"Merge branch 'master' into run_allciphers(),run_cipher_per_proto(),-and-SSLv2","distinct":false,"url":"https://api.github.com/repos/dcooper16/testssl.sh/commits/a53ee051f6ab83f9cc2d88a961a6b6ed1bcd3bcc"},{"sha":"0a51239cda106c1ee3650d47a911c4a5431271a2","author":{"name":"David Cooper","email":"bd07968fe1548f762be87be0de640b4db395569f@gmail.com"},"message":"Merge branch 'master' into run_allciphers(),run_cipher_per_proto(),-and-SSLv2","distinct":false,"url":"https://api.github.com/repos/dcooper16/testssl.sh/commits/0a51239cda106c1ee3650d47a911c4a5431271a2"},{"sha":"df2904edbf472f07832073e4e4a5552e69bd5171","author":{"name":"David Cooper","email":"bd07968fe1548f762be87be0de640b4db395569f@gmail.com"},"message":"Merge branch 'master' into run_allciphers(),run_cipher_per_proto(),-and-SSLv2","distinct":false,"url":"https://api.github.com/repos/dcooper16/testssl.sh/commits/df2904edbf472f07832073e4e4a5552e69bd5171"},{"sha":"31c3a87a72d27d8d2843e0ad636d1bddd7898322","author":{"name":"David Cooper","email":"bd07968fe1548f762be87be0de640b4db395569f@gmail.com"},"message":"Merge branch 'master' into run_allciphers(),run_cipher_per_proto(),-and-SSLv2","distinct":false,"url":"https://api.github.com/repos/dcooper16/testssl.sh/commits/31c3a87a72d27d8d2843e0ad636d1bddd7898322"},{"sha":"a534b8de5fbf2cfc4f64e705c9f4e2ab9de6fb68","author":{"name":"David Cooper","email":"bd07968fe1548f762be87be0de640b4db395569f@gmail.com"},"message":"Merge branch 'master' into run_allciphers(),run_cipher_per_proto(),-and-SSLv2","distinct":false,"url":"https://api.github.com/repos/dcooper16/testssl.sh/commits/a534b8de5fbf2cfc4f64e705c9f4e2ab9de6fb68"},{"sha":"1102ef324cefabba475892dc661ce2dc61b7bf09","author":{"name":"David Cooper","email":"bd07968fe1548f762be87be0de640b4db395569f@gmail.com"},"message":"Merge branch 'master' into run_allciphers(),run_cipher_per_proto(),-and-SSLv2","distinct":false,"url":"https://api.github.com/repos/dcooper16/testssl.sh/commits/1102ef324cefabba475892dc661ce2dc61b7bf09"},{"sha":"02a39e4859cfdccb6eeca3d39dbe9e03e52e4c73","author":{"name":"David Cooper","email":"bd07968fe1548f762be87be0de640b4db395569f@gmail.com"},"message":"Merge branch 'master' into run_allciphers(),run_cipher_per_proto(),-and-SSLv2","distinct":false,"url":"https://api.github.com/repos/dcooper16/testssl.sh/commits/02a39e4859cfdccb6eeca3d39dbe9e03e52e4c73"},{"sha":"197bee86584e8ec4dad986e2f8040dc3d2b56b64","author":{"name":"David Cooper","email":"bd07968fe1548f762be87be0de640b4db395569f@gmail.com"},"message":"Merge branch 'master' into run_allciphers(),run_cipher_per_proto(),-and-SSLv2","distinct":false,"url":"https://api.github.com/repos/dcooper16/testssl.sh/commits/197bee86584e8ec4dad986e2f8040dc3d2b56b64"}]}
{"actor":{"display_login":"dcooper16"}}