{"action":"opened","issue":{"url":"https://api.github.com/repos/tkinsman/StaShit/issues/3","repository_url":"https://api.github.com/repos/tkinsman/StaShit","labels_url":"https://api.github.com/repos/tkinsman/StaShit/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/tkinsman/StaShit/issues/3/comments","events_url":"https://api.github.com/repos/tkinsman/StaShit/issues/3/events","html_url":"https://github.com/tkinsman/StaShit/issues/3","id":193008013,"number":3,"title":"Instructor Review - Week 14","user":{"login":"pawaitemadisoncollege","id":13874466,"avatar_url":"https://avatars.githubusercontent.com/u/13874466?v=3","gravatar_id":"","url":"https://api.github.com/users/pawaitemadisoncollege","html_url":"https://github.com/pawaitemadisoncollege","followers_url":"https://api.github.com/users/pawaitemadisoncollege/followers","following_url":"https://api.github.com/users/pawaitemadisoncollege/following{/other_user}","gists_url":"https://api.github.com/users/pawaitemadisoncollege/gists{/gist_id}","starred_url":"https://api.github.com/users/pawaitemadisoncollege/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pawaitemadisoncollege/subscriptions","organizations_url":"https://api.github.com/users/pawaitemadisoncollege/orgs","repos_url":"https://api.github.com/users/pawaitemadisoncollege/repos","events_url":"https://api.github.com/users/pawaitemadisoncollege/events{/privacy}","received_events_url":"https://api.github.com/users/pawaitemadisoncollege/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-12-02T01:16:10Z","updated_at":"2016-12-02T01:16:10Z","closed_at":null,"body":"You've put in good consistent work on this and it shows! A few things as you enter the home stretch:\r\n\r\n- [ ] have you considered front end validation to supplement back end? There are bootstrap and jquery libraries that help with this, or simple javascript.\r\n- [ ] you asked about servlet/controller size, in looking at this, I agree you could move some of the code out. AddUser, is big for example. Consider using a factory or builder to create the beans/objects. \r\n- [ ] Hibernate does have annotation based validation that you might find interesting: http://hibernate.org/validator/ \r\n- [ ] I like that you are using variables for the destination jsps. What do you think about have a constant for this public static final DESTINATION_JSP? Might be easier than searching into the method for the string jsp name. Picky, I know...\r\n- [ ] Don't be afraid to delete code that's no longer needed rather than commenting it out, you can always get it back from git. For example: UserLoggedIn\r\n- [ ]  Remember to call no-arg constructor from overridden constructors. Example: StorageSpace\r\n- [ ] Make sure all entities/beans have a no-arg constructor. It appears that it is missing in UserRoles\r\n- [ ] Watch for those sneaky  e.printStackTrace(); and replace with error log messages\r\n- [ ] What is the user experience if there is an error (an issue with the db connection for example)? Error page?\r\n- [ ] Consider the generic dao to minimize repetitive code in the daos\r\n- [ ]  You have a good start with unit tests -I think this is on your radar, but could use more tests: for example,  exceptions and utility classes."}}
{"actor":{"display_login":"pawaitemadisoncollege"}}