{"action":"closed","number":13518,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/13518","id":72626473,"html_url":"https://github.com/apache/spark/pull/13518","diff_url":"https://github.com/apache/spark/pull/13518.diff","patch_url":"https://github.com/apache/spark/pull/13518.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/13518","number":13518,"state":"closed","locked":false,"title":"[WIP][SPARK-15472][SQL] Add support for writing in `csv`, `json`, `text` formats in Structured Streaming","user":{"login":"lw-lin","id":15843379,"avatar_url":"https://avatars.githubusercontent.com/u/15843379?v=3","gravatar_id":"","url":"https://api.github.com/users/lw-lin","html_url":"https://github.com/lw-lin","followers_url":"https://api.github.com/users/lw-lin/followers","following_url":"https://api.github.com/users/lw-lin/following{/other_user}","gists_url":"https://api.github.com/users/lw-lin/gists{/gist_id}","starred_url":"https://api.github.com/users/lw-lin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lw-lin/subscriptions","organizations_url":"https://api.github.com/users/lw-lin/orgs","repos_url":"https://api.github.com/users/lw-lin/repos","events_url":"https://api.github.com/users/lw-lin/events{/privacy}","received_events_url":"https://api.github.com/users/lw-lin/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nThis patch adds support for writing in `csv`, `json`, `text` formats in Structured Streaming:\r\n\r\n**1. at a high level, this patch forms the following hierarchy**(`text` as an example):\r\n```\r\n                <OutputWriter>\r\n                      ↑\r\n             TextOutputWriterBase\r\n                 ↗          ↖\r\nBatchTextOutputWriter   StreamingTextOutputWriter\r\n```\r\n```\r\n                    <OutputWriterFactory>\r\n                        ↗          ↖\r\nBatchTextOutputWriterFactory   StreamingOutputWriterFactory\r\n                                              ↑\r\n                              StreamingTextOutputWriterFactory\r\n```\r\nThe `StreamingTextOutputWriter` and other 'streaming' output writers would write data **without** using an `OutputCommitter`. This was the same approach taken by [SPARK-14716](https://github.com/apache/spark/pull/12409).\r\n\r\n**2. to support compression, this patch attaches an extension to the path assigned by `FileStreamSink`**, which is slightly different from [SPARK-14716](https://github.com/apache/spark/pull/12409). For example, if we are writing out using the `gzip` compression and `FileStreamSink` assigns path `${uuid}` to a text writer, then in the end the file written out will be `${uuid}.txt.gz` -- so that when we read the file back, we'll correctly interpret it as `gzip` compressed.\r\n\r\n## How was this patch tested?\r\n\r\n`FileStreamSinkSuite` is expanded much more to cover the added `csv`, `json`, `text` formats:\r\n\r\n```scala\r\ntest(\" csv - unpartitioned data - codecs: none/gzip\")\r\ntest(\"json - unpartitioned data - codecs: none/gzip\")\r\ntest(\"text - unpartitioned data - codecs: none/gzip\")\r\n\r\ntest(\" csv - partitioned data - codecs: none/gzip\")\r\ntest(\"json - partitioned data - codecs: none/gzip\")\r\ntest(\"text - partitioned data - codecs: none/gzip\")\r\n\r\ntest(\" csv - unpartitioned writing and batch reading - codecs: none/gzip\")\r\ntest(\"json - unpartitioned writing and batch reading - codecs: none/gzip\")\r\ntest(\"text - unpartitioned writing and batch reading - codecs: none/gzip\")\r\n\r\ntest(\" csv - partitioned writing and batch reading - codecs: none/gzip\")\r\ntest(\"json - partitioned writing and batch reading - codecs: none/gzip\")\r\ntest(\"text - partitioned writing and batch reading - codecs: none/gzip\")\r\n```","created_at":"2016-06-05T11:02:44Z","updated_at":"2016-06-17T02:24:54Z","closed_at":"2016-06-17T02:24:54Z","merged_at":null,"merge_commit_sha":"e9074e290f7be4af1a248d997a16a371b64f2c7a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/13518/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/13518/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/13518/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/ec51f9878d971a14b56375ae4f8d6f33ec64e751","head":{"label":"lw-lin:add-csv-json-text-for-ss","ref":"add-csv-json-text-for-ss","sha":"ec51f9878d971a14b56375ae4f8d6f33ec64e751","user":{"login":"lw-lin","id":15843379,"avatar_url":"https://avatars.githubusercontent.com/u/15843379?v=3","gravatar_id":"","url":"https://api.github.com/users/lw-lin","html_url":"https://github.com/lw-lin","followers_url":"https://api.github.com/users/lw-lin/followers","following_url":"https://api.github.com/users/lw-lin/following{/other_user}","gists_url":"https://api.github.com/users/lw-lin/gists{/gist_id}","starred_url":"https://api.github.com/users/lw-lin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lw-lin/subscriptions","organizations_url":"https://api.github.com/users/lw-lin/orgs","repos_url":"https://api.github.com/users/lw-lin/repos","events_url":"https://api.github.com/users/lw-lin/events{/privacy}","received_events_url":"https://api.github.com/users/lw-lin/received_events","type":"User","site_admin":false},"repo":{"id":49997538,"name":"spark","full_name":"lw-lin/spark","owner":{"login":"lw-lin","id":15843379,"avatar_url":"https://avatars.githubusercontent.com/u/15843379?v=3","gravatar_id":"","url":"https://api.github.com/users/lw-lin","html_url":"https://github.com/lw-lin","followers_url":"https://api.github.com/users/lw-lin/followers","following_url":"https://api.github.com/users/lw-lin/following{/other_user}","gists_url":"https://api.github.com/users/lw-lin/gists{/gist_id}","starred_url":"https://api.github.com/users/lw-lin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lw-lin/subscriptions","organizations_url":"https://api.github.com/users/lw-lin/orgs","repos_url":"https://api.github.com/users/lw-lin/repos","events_url":"https://api.github.com/users/lw-lin/events{/privacy}","received_events_url":"https://api.github.com/users/lw-lin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lw-lin/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/lw-lin/spark","forks_url":"https://api.github.com/repos/lw-lin/spark/forks","keys_url":"https://api.github.com/repos/lw-lin/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lw-lin/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lw-lin/spark/teams","hooks_url":"https://api.github.com/repos/lw-lin/spark/hooks","issue_events_url":"https://api.github.com/repos/lw-lin/spark/issues/events{/number}","events_url":"https://api.github.com/repos/lw-lin/spark/events","assignees_url":"https://api.github.com/repos/lw-lin/spark/assignees{/user}","branches_url":"https://api.github.com/repos/lw-lin/spark/branches{/branch}","tags_url":"https://api.github.com/repos/lw-lin/spark/tags","blobs_url":"https://api.github.com/repos/lw-lin/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lw-lin/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lw-lin/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/lw-lin/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lw-lin/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/lw-lin/spark/languages","stargazers_url":"https://api.github.com/repos/lw-lin/spark/stargazers","contributors_url":"https://api.github.com/repos/lw-lin/spark/contributors","subscribers_url":"https://api.github.com/repos/lw-lin/spark/subscribers","subscription_url":"https://api.github.com/repos/lw-lin/spark/subscription","commits_url":"https://api.github.com/repos/lw-lin/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/lw-lin/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/lw-lin/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/lw-lin/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/lw-lin/spark/contents/{+path}","compare_url":"https://api.github.com/repos/lw-lin/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lw-lin/spark/merges","archive_url":"https://api.github.com/repos/lw-lin/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lw-lin/spark/downloads","issues_url":"https://api.github.com/repos/lw-lin/spark/issues{/number}","pulls_url":"https://api.github.com/repos/lw-lin/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/lw-lin/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/lw-lin/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lw-lin/spark/labels{/name}","releases_url":"https://api.github.com/repos/lw-lin/spark/releases{/id}","deployments_url":"https://api.github.com/repos/lw-lin/spark/deployments","created_at":"2016-01-20T02:10:13Z","updated_at":"2016-01-20T02:10:37Z","pushed_at":"2016-06-16T14:08:47Z","git_url":"git://github.com/lw-lin/spark.git","ssh_url":"git@github.com:lw-lin/spark.git","clone_url":"https://github.com/lw-lin/spark.git","svn_url":"https://github.com/lw-lin/spark","homepage":null,"size":177270,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"7c6c6926376c93acc42dd56a399d816f4838f28c","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2016-06-17T01:53:19Z","pushed_at":"2016-06-17T02:01:50Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":497543,"stargazers_count":8952,"watchers_count":8952,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8314,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":376,"forks":8314,"open_issues":376,"watchers":8952,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/13518"},"html":{"href":"https://github.com/apache/spark/pull/13518"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/13518"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/13518/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/13518/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/13518/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/ec51f9878d971a14b56375ae4f8d6f33ec64e751"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":27,"review_comments":0,"commits":1,"additions":295,"deletions":68,"changed_files":5}}
{"actor":{"display_login":"lw-lin"}}