{"action":"created","comment":{"url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/pulls/comments/61519257","id":61519257,"diff_hunk":"@@ -30,7 +30,12 @@ @implementation LDTAppDelegate\n - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions {\n     NSDictionary *keysDict = [NSDictionary dictionaryWithContentsOfFile:[[NSBundle mainBundle] pathForResource:@\"keys\" ofType:@\"plist\"]];\n     NSDictionary *environmentDict = [NSDictionary dictionaryWithContentsOfFile:[[NSBundle mainBundle] pathForResource:@\"environment\" ofType:@\"plist\"]];\n-    \n+\n+    [NRLogger setLogLevels:NRLogLevelNone];\n+    if (environmentDict[@\"NewRelicLoggerEnabled\"] && [environmentDict[@\"NewRelicLoggerEnabled\"] boolValue]) {\n+        [NRLogger setLogLevels:NRLogLevelError|NRLogLevelWarning];","path":"Lets Do This/Classes/LDTAppDelegate.m","position":8,"original_position":8,"commit_id":"3190d848ff98585797bd15004e24fe157d3dd0ed","original_commit_id":"3190d848ff98585797bd15004e24fe157d3dd0ed","user":{"login":"aaronschachter","id":1236811,"avatar_url":"https://avatars.githubusercontent.com/u/1236811?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronschachter","html_url":"https://github.com/aaronschachter","followers_url":"https://api.github.com/users/aaronschachter/followers","following_url":"https://api.github.com/users/aaronschachter/following{/other_user}","gists_url":"https://api.github.com/users/aaronschachter/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronschachter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronschachter/subscriptions","organizations_url":"https://api.github.com/users/aaronschachter/orgs","repos_url":"https://api.github.com/users/aaronschachter/repos","events_url":"https://api.github.com/users/aaronschachter/events{/privacy}","received_events_url":"https://api.github.com/users/aaronschachter/received_events","type":"User","site_admin":false},"body":"From NRLogger.h:\r\n> /*******************************************************************************\r\n * Log levels used in the agent's internal logger\r\n *\r\n * When calling NRLogger setLogLevels: pass in a bitmask of the levels you want\r\n * enabled, ORed together e.g.\r\n *   [NRLogger setLogLevels:NRLogLevelError|NRLogLevelWarning|NRLogLevelInfo];\r\n *\r\n * NRLogLevelALL is a convenience definition.\r\n *\r\n * NRLogger's default log level is NRLogLevelError|NRLogLevelWarning\r\n *******************************************************************************/\r\n","created_at":"2016-04-28T23:36:50Z","updated_at":"2016-04-28T23:36:50Z","html_url":"https://github.com/DoSomething/LetsDoThis-iOS/pull/1007#discussion_r61519257","pull_request_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/pulls/1007","_links":{"self":{"href":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/pulls/comments/61519257"},"html":{"href":"https://github.com/DoSomething/LetsDoThis-iOS/pull/1007#discussion_r61519257"},"pull_request":{"href":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/pulls/1007"}}},"pull_request":{"url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/pulls/1007","id":68304513,"html_url":"https://github.com/DoSomething/LetsDoThis-iOS/pull/1007","diff_url":"https://github.com/DoSomething/LetsDoThis-iOS/pull/1007.diff","patch_url":"https://github.com/DoSomething/LetsDoThis-iOS/pull/1007.patch","issue_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/issues/1007","number":1007,"state":"open","locked":false,"title":"Updates NewRelicAgent to 5.4.1","user":{"login":"aaronschachter","id":1236811,"avatar_url":"https://avatars.githubusercontent.com/u/1236811?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronschachter","html_url":"https://github.com/aaronschachter","followers_url":"https://api.github.com/users/aaronschachter/followers","following_url":"https://api.github.com/users/aaronschachter/following{/other_user}","gists_url":"https://api.github.com/users/aaronschachter/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronschachter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronschachter/subscriptions","organizations_url":"https://api.github.com/users/aaronschachter/orgs","repos_url":"https://api.github.com/users/aaronschachter/repos","events_url":"https://api.github.com/users/aaronschachter/events{/privacy}","received_events_url":"https://api.github.com/users/aaronschachter/received_events","type":"User","site_admin":false},"body":"Closes #970 - Upgrade looks ok -- Apparently these messages when running on Simulator are [not unexpected](https://discuss.newrelic.com/t/unable-to-remove-session-attribute/35466). Will be adding a new entry to `environments.plist` to disable.\r\n> 2016-04-28 15:46:50.463 DoSomething[4873:37082] NewRelic(5.4.1,0x7ff73b601730):\tSessionAttributeManager.cxx:315\tremoveSessionAttribute\r\n\tUnable to remove session attribute \"upgradeFrom\"; attribute not found.\r\n2016-04-28 15:46:50.463 DoSomething[4873:37082] NewRelic(5.4.1,0x7ff73b601730):\tSessionAttributeManager.cxx:315\tremoveSessionAttribute\r\n\tUnable to remove session attribute \"com.newrelic.SecureUDID.returnedNil\"; attribute not found.\r\n2016-04-28 15:46:50.464 DoSomething[4873:37082] NewRelic(5.4.1,0x7ff73b601730):\tSessionAttributeManager.cxx:315\tremoveSessionAttribute\r\n\tUnable to remove session attribute \"nr.deviceDidChange\"; attribute not found.\r\n2016-04-28 15:46:50.464 DoSomething[4873:37082] NewRelic(5.4.1,0x7ff73b601730):\tSessionAttributeManager.cxx:315\tremoveSessionAttribute\r\n\tUnable to remove session attribute \"install\"; attribute not found.\r\n2016-04-28 15:46:50.464 DoSomething[4873:37082] NewRelic(5.4.1,0x7ff73b601730):\tSessionAttributeManager.cxx:315\tremoveSessionAttribute\r\n\tUnable to remove session attribute \"sessionDuration\"; attribute not found.\r\n2016-04-28 15:46:50.482 DoSomething[4873:37238] NewRelic(5.4.1,0x7ff73b66e2d0):\tNRMAUncaughtExceptionHandler.m:88\t__37-[NRMAUncaughtExceptionHandler start]_block_invoke\r\n\tNew Relic Crash Reporting is DISABLED because it has detected the debugger is enabled.","created_at":"2016-04-28T23:05:43Z","updated_at":"2016-04-28T23:36:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"06e4c99db9d70bba9b8e645174fe581d582cbf21","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/pulls/1007/commits","review_comments_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/pulls/1007/comments","review_comment_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/issues/1007/comments","statuses_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/statuses/3190d848ff98585797bd15004e24fe157d3dd0ed","head":{"label":"DoSomething:issue-970","ref":"issue-970","sha":"3190d848ff98585797bd15004e24fe157d3dd0ed","user":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars.githubusercontent.com/u/731685?v=3","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"repo":{"id":33381932,"name":"LetsDoThis-iOS","full_name":"DoSomething/LetsDoThis-iOS","owner":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars.githubusercontent.com/u/731685?v=3","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DoSomething/LetsDoThis-iOS","description":"iOS source code for DoSomething: Take Action on the News","fork":false,"url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS","forks_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/forks","keys_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/teams","hooks_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/hooks","issue_events_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/events","assignees_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/tags","blobs_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/languages","stargazers_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/stargazers","contributors_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/contributors","subscribers_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/subscribers","subscription_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/subscription","commits_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/merges","archive_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/downloads","issues_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/labels{/name}","releases_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/deployments","created_at":"2015-04-03T20:42:47Z","updated_at":"2016-04-26T21:49:26Z","pushed_at":"2016-04-28T23:34:19Z","git_url":"git://github.com/DoSomething/LetsDoThis-iOS.git","ssh_url":"git@github.com:DoSomething/LetsDoThis-iOS.git","clone_url":"https://github.com/DoSomething/LetsDoThis-iOS.git","svn_url":"https://github.com/DoSomething/LetsDoThis-iOS","homepage":"http://app.dosomething.org","size":54846,"stargazers_count":1,"watchers_count":1,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":37,"forks":0,"open_issues":37,"watchers":1,"default_branch":"develop"}},"base":{"label":"DoSomething:develop","ref":"develop","sha":"c06cbd7f1a70ab6c1c0b1f2cd3f43b132b967395","user":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars.githubusercontent.com/u/731685?v=3","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"repo":{"id":33381932,"name":"LetsDoThis-iOS","full_name":"DoSomething/LetsDoThis-iOS","owner":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars.githubusercontent.com/u/731685?v=3","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DoSomething/LetsDoThis-iOS","description":"iOS source code for DoSomething: Take Action on the News","fork":false,"url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS","forks_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/forks","keys_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/teams","hooks_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/hooks","issue_events_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/events","assignees_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/tags","blobs_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/languages","stargazers_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/stargazers","contributors_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/contributors","subscribers_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/subscribers","subscription_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/subscription","commits_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/merges","archive_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/downloads","issues_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/labels{/name}","releases_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/deployments","created_at":"2015-04-03T20:42:47Z","updated_at":"2016-04-26T21:49:26Z","pushed_at":"2016-04-28T23:34:19Z","git_url":"git://github.com/DoSomething/LetsDoThis-iOS.git","ssh_url":"git@github.com:DoSomething/LetsDoThis-iOS.git","clone_url":"https://github.com/DoSomething/LetsDoThis-iOS.git","svn_url":"https://github.com/DoSomething/LetsDoThis-iOS","homepage":"http://app.dosomething.org","size":54846,"stargazers_count":1,"watchers_count":1,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":37,"forks":0,"open_issues":37,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/pulls/1007"},"html":{"href":"https://github.com/DoSomething/LetsDoThis-iOS/pull/1007"},"issue":{"href":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/issues/1007"},"comments":{"href":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/issues/1007/comments"},"review_comments":{"href":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/pulls/1007/comments"},"review_comment":{"href":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/pulls/1007/commits"},"statuses":{"href":"https://api.github.com/repos/DoSomething/LetsDoThis-iOS/statuses/3190d848ff98585797bd15004e24fe157d3dd0ed"}}}}