{"push_id":1394536096,"size":25,"distinct_size":25,"ref":"refs/heads/mmc-status-support","head":"6f664b735432d61eed0e0a7dfafffa197ca94d18","before":"0dcdfb297b78f6ca2f12a8b2e1cc1e2ff0588052","commits":[{"sha":"57fd1c5f24ba6fdcdef4d282943600429f8d4282","author":{"name":"jer.noble@apple.com","email":"6204b61587c40a0ef5a6eb5bb72176f55ab1e072@apple.com"},"message":"REGRESSION (r208149): Media scrubber is not displayed in media controls\nhttps://bugs.webkit.org/show_bug.cgi?id=164514\n\nReviewed by Darin Adler.\n\nFixes broken Media Controls API tests.\n\nAdded a new PlatformMediaSessionType; need to add that same type to the TYPE_TRAITS section of\nMediaElementSession.h so that is<> and downcast<> work correctly.\n\n* html/MediaElementSession.h:\n(isType):\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@208464 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/graouts/webkit/commits/57fd1c5f24ba6fdcdef4d282943600429f8d4282"},{"sha":"90a29b725dcdcd61a4280be30e5ad29d8ab46c1b","author":{"name":"zalan@apple.com","email":"b46bdec880c65ffca065f4a1ea9e1a30e6bb3837@apple.com"},"message":"RenderFlowThread::flowThreadRelativeWillBeRemoved should take RenderObject& instead of RenderObject*\nhttps://bugs.webkit.org/show_bug.cgi?id=164543\n\nReviewed by Simon Fraser.\n\nNo change in functionality.\n\n* rendering/RenderBlockFlow.cpp:\n(WebCore::RenderBlockFlow::removeChild):\n* rendering/RenderFlowThread.h:\n* rendering/RenderMultiColumnFlowThread.cpp:\n(WebCore::RenderMultiColumnFlowThread::handleSpannerRemoval):\n(WebCore::RenderMultiColumnFlowThread::flowThreadRelativeWillBeRemoved):\n* rendering/RenderMultiColumnFlowThread.h:\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@208465 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/graouts/webkit/commits/90a29b725dcdcd61a4280be30e5ad29d8ab46c1b"},{"sha":"f4274cfe61fac7ba86550432b317b2647d7d5296","author":{"name":"simon.fraser@apple.com","email":"daa055b893832bbe20acb7911685e075f8a9ec26@apple.com"},"message":"Allow customization of TextStream-based logging for geometry types\nhttps://bugs.webkit.org/show_bug.cgi?id=164460\n\nReviewed by Zalan Bujtas.\n\nTextStream-based logging was constrained by the requirement to maintain compatibility\nwith DRT-style output, which includes cumbersome rect logging (\"at (5,0) size 40x40\")\nand dumping LayoutRects as IntRects.\n\nAdd some formatting flags so that other TextStream clients (e.g. logging) can have\nmore readable output, and opt into automatic FormatNumberRespectingIntegers behavior.\n\nTextStreams whose output appears in test results are given flags to avoid behavior\nchanges, but in the longer term test results should be updated.\n\n* html/canvas/CanvasRenderingContext2D.cpp:\n(WebCore::CanvasRenderingContext2D::replayDisplayListAsText):\n* page/scrolling/ScrollingStateNode.cpp:\n(WebCore::ScrollingStateNode::scrollingStateTreeAsText):\n* platform/graphics/FloatPoint.cpp:\n(WebCore::operator<<):\n* platform/graphics/FloatRect.cpp:\n(WebCore::operator<<):\n* platform/graphics/GraphicsLayer.cpp:\n(WebCore::GraphicsLayer::layerTreeAsText):\n* platform/graphics/IntRect.cpp:\n(WebCore::operator<<):\n* platform/graphics/LayoutPoint.cpp:\n(WebCore::operator<<):\n* platform/graphics/LayoutRect.cpp:\n(WebCore::operator<<):\n* platform/graphics/ca/GraphicsLayerCA.cpp:\n(WebCore::GraphicsLayerCA::replayDisplayListAsText):\n* platform/graphics/displaylists/DisplayList.cpp:\n(WebCore::DisplayList::DisplayList::asText):\n* platform/text/TextStream.cpp:\n(WebCore::TextStream::operator<<):\n* platform/text/TextStream.h:\n(WebCore::TextStream::TextStream):\n(WebCore::TextStream::formattingFlags):\n(WebCore::TextStream::setFormattingFlags):\n(WebCore::TextStream::hasFormattingFlag):\n(WebCore::TextStream::increaseIndent):\n(WebCore::TextStream::decreaseIndent):\n* rendering/RenderTreeAsText.cpp:\n(WebCore::externalRepresentation):\n(WebCore::counterValueForElement):\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@208466 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/graouts/webkit/commits/f4274cfe61fac7ba86550432b317b2647d7d5296"},{"sha":"2be6f4340e1575158a11b886420e5143b5f00042","author":{"name":"beidson@apple.com","email":"ce942fc9826cadb48b468e5bf27275fdc71fca66@apple.com"},"message":"IndexedDB 2.0: Clean up more transaction abort behavior, including tweaks to Index/ObjectStore lifetime.\nhttps://bugs.webkit.org/show_bug.cgi?id=164466\n\nReviewed by Alex Christensen.\n\nLayoutTests/imported/w3c:\n\n* web-platform-tests/IndexedDB/transaction-abort-index-metadata-revert-expected.txt:\n* web-platform-tests/IndexedDB/transaction-abort-multiple-metadata-revert-expected.txt:\n* web-platform-tests/IndexedDB/transaction-abort-object-store-metadata-revert-expected.txt:\n\nSource/WebCore:\n\nNo new tests (Covered by existing tests that now pass).\n\nPreviously, IDBIndex ref/deref didn't track a traditional ref count but instead kept the owning object store alive.\nNow, IDBObjectStore ref/deref do the same thing for the owning transaction.\n\nNow when a version change transaction is rolled back, some object stores and indexes get pulled out of the \"deleted\"\nset and get promoted back up into the \"referenced\" set.\n\nNow deleted object stores/indexes are considered opaque roots, as live objects in the deleted state *can* get back\nto the owning objects.\n\n* CMakeLists.txt:\n* WebCore.xcodeproj/project.pbxproj:\n\n* Modules/indexeddb/IDBIndex.cpp:\n(WebCore::IDBIndex::rollbackInfoForVersionChangeAbort):\n\n* Modules/indexeddb/IDBObjectStore.cpp:\n(WebCore::IDBObjectStore::IDBObjectStore):\n(WebCore::IDBObjectStore::indexNames):\n(WebCore::IDBObjectStore::transaction):\n(WebCore::IDBObjectStore::openCursor):\n(WebCore::IDBObjectStore::openKeyCursor):\n(WebCore::IDBObjectStore::deleteIndex):\n(WebCore::IDBObjectStore::rollbackForVersionChangeAbort):\n(WebCore::IDBObjectStore::visitReferencedIndexes):\n(WebCore::IDBObjectStore::ref):\n(WebCore::IDBObjectStore::deref):\n(WebCore::IDBObjectStore::create): Deleted.\n* Modules/indexeddb/IDBObjectStore.h:\n\n* Modules/indexeddb/IDBTransaction.cpp:\n(WebCore::IDBTransaction::objectStore):\n(WebCore::IDBTransaction::transitionedToFinishing):\n(WebCore::IDBTransaction::internalAbort):\n(WebCore::IDBTransaction::createObjectStore):\n(WebCore::IDBTransaction::deleteObjectStore):\n(WebCore::IDBTransaction::visitReferencedObjectStores):\n* Modules/indexeddb/IDBTransaction.h:\n* Modules/indexeddb/IDBTransaction.idl:\n\n* bindings/js/JSIDBTransactionCustom.cpp: Added.\n(WebCore::JSIDBTransaction::visitAdditionalChildren):\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@208467 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/graouts/webkit/commits/2be6f4340e1575158a11b886420e5143b5f00042"},{"sha":"7eabef7eca8c268929eba6a7b7563beee19f9511","author":{"name":"bdakin@apple.com","email":"cef530b6b63f42c59349ccc5945140ae8dc95731@apple.com"},"message":"Attempted build fix.\n\n* platform/spi/cocoa/AVKitSPI.h:\n\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@208468 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/graouts/webkit/commits/7eabef7eca8c268929eba6a7b7563beee19f9511"},{"sha":"314df6c57e5ba7c4042c862cfcdceffd5917b071","author":{"name":"pvollan@apple.com","email":"90d85dc4ba3db7612f668a3d2943b25025e1262d@apple.com"},"message":"[Win][Direct2D] Incomplete image decoding.\nhttps://bugs.webkit.org/show_bug.cgi?id=164511\n\nReviewed by Darin Adler.\n\nCreate native decoder when all image data has been received.\n\n* platform/graphics/win/ImageDecoderDirect2D.cpp:\n(WebCore::ImageDecoder::setData):\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@208469 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/graouts/webkit/commits/314df6c57e5ba7c4042c862cfcdceffd5917b071"},{"sha":"a183dade6e26f1708659a8f0a04a19c191ce9954","author":{"name":"zalan@apple.com","email":"b46bdec880c65ffca065f4a1ea9e1a30e6bb3837@apple.com"},"message":"Move RenderNamedFlowThread nextRendererForElement logic to RenderTreeUpdater.\nhttps://bugs.webkit.org/show_bug.cgi?id=164503\n\nReviewed by Antti Koivisto.\n\nWhen we insert a renderer into the render tree, we need to know both its parent\nand its next sibling. Normally the parent and the sibling are based on the DOM, but\nwhen this renderer is part of a flow thread, its insertion sibling is not necessarily the DOM sibling.\nTo find the correct sibling, we call RenderNamedFlowThread's nextRendererForElement().\nRenderNamedFlowThread keeps track of its children so that it can compute the next sibling\nfor the insertion point.\n\nThis patch eliminates the need for keeping track of the child renderers of each\nflow by moving the 'next sibling' logic to RenderTreePosition.\n\nNo change in functionality.\n\n* rendering/RenderElement.cpp:\n(WebCore::RenderElement::insertedIntoTree):\n(WebCore::RenderElement::willBeDestroyed):\n(WebCore::RenderElement::removeFromRenderFlowThread):\n(WebCore::RenderElement::renderNamedFlowThreadWrapper): Deleted.\n* rendering/RenderElement.h:\n* rendering/RenderNamedFlowThread.cpp:\n(WebCore::RenderNamedFlowThread::nextRendererForElement): Deleted.\n(WebCore::RenderNamedFlowThread::addFlowChild): Deleted.\n(WebCore::RenderNamedFlowThread::removeFlowChild): Deleted.\n* rendering/RenderNamedFlowThread.h:\n* style/RenderTreePosition.cpp:\n(WebCore::RenderTreePosition::previousSiblingRenderer):\n(WebCore::RenderTreePosition::flowThreadInsertionContext):\n* style/RenderTreePosition.h:\n(WebCore::RenderTreePosition::RenderTreePosition):\n(WebCore::RenderTreePosition::parent):\n* style/RenderTreeUpdater.cpp:\n(WebCore::registerElementForFlowThreadIfNeeded): We need to registed the element even when it does not create renderer (display: none).\n(WebCore::RenderTreeUpdater::createRenderer):\n(WebCore::moveToFlowThreadIfNeeded): Deleted.\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@208470 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/graouts/webkit/commits/a183dade6e26f1708659a8f0a04a19c191ce9954"},{"sha":"2d39325481efc863c23d52c2a8c296f06c4d812f","author":{"name":"beidson@apple.com","email":"ce942fc9826cadb48b468e5bf27275fdc71fca66@apple.com"},"message":"Followup to https://bugs.webkit.org/show_bug.cgi?id=164466 - Make an IDBTransaction* be an IDBTransaction&\n\nRubberstamped by Alex Christensen.\n\nNo new tests (No behavior change).\n\n* Modules/indexeddb/IDBObjectStore.cpp:\n(WebCore::IDBObjectStore::IDBObjectStore):\n(WebCore::IDBObjectStore::~IDBObjectStore):\n(WebCore::IDBObjectStore::hasPendingActivity):\n(WebCore::IDBObjectStore::name):\n(WebCore::IDBObjectStore::setName):\n(WebCore::IDBObjectStore::keyPath):\n(WebCore::IDBObjectStore::indexNames):\n(WebCore::IDBObjectStore::transaction):\n(WebCore::IDBObjectStore::autoIncrement):\n(WebCore::IDBObjectStore::openCursor):\n(WebCore::IDBObjectStore::openKeyCursor):\n(WebCore::IDBObjectStore::get):\n(WebCore::IDBObjectStore::putOrAdd):\n(WebCore::IDBObjectStore::doDelete):\n(WebCore::IDBObjectStore::clear):\n(WebCore::IDBObjectStore::createIndex):\n(WebCore::IDBObjectStore::index):\n(WebCore::IDBObjectStore::deleteIndex):\n(WebCore::IDBObjectStore::doCount):\n(WebCore::IDBObjectStore::getAll):\n(WebCore::IDBObjectStore::getAllKeys):\n(WebCore::IDBObjectStore::markAsDeleted):\n(WebCore::IDBObjectStore::rollbackForVersionChangeAbort):\n(WebCore::IDBObjectStore::ref):\n(WebCore::IDBObjectStore::deref):\n* Modules/indexeddb/IDBObjectStore.h:\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@208471 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/graouts/webkit/commits/2d39325481efc863c23d52c2a8c296f06c4d812f"},{"sha":"354f05c40054913430f8ca6ee806815189c43974","author":{"name":"commit-queue@webkit.org","email":"bf5a5ee7740adc2e16c9908c58a0c6d4239e6078@webkit.org"},"message":"[WebIDL] Add proper parsing for Promises\nhttps://bugs.webkit.org/show_bug.cgi?id=164497\n\nPatch by Sam Weinig <sam@webkit.org> on 2016-11-09\nReviewed by Tim Horton.\n\n* bindings/scripts/IDLParser.pm:\n(parseNonAnyType):\n(parseStringType):\nRequire Promise types to declare the type they resolve to.\n\n* bindings/js/JSDOMPromise.h:\nAllow DOMPromise to be be parameterized on void. Add an SFINAE guarded\noverload of resolve that takes no arguments when in a DOMPromise<void>.\n\n* Modules/applepay/ApplePaySession.idl:\n* Modules/fetch/DOMWindowFetch.idl:\n* Modules/fetch/FetchBody.idl:\n* Modules/fetch/FetchResponse.idl:\n* Modules/fetch/WorkerGlobalScopeFetch.idl:\n* Modules/mediastream/MediaDevices.idl:\n* Modules/mediastream/MediaStreamTrack.idl:\n* Modules/mediastream/RTCPeerConnection.idl:\n* Modules/mediastream/RTCRtpSender.idl:\n* Modules/mediastream/RTCStatsReport.idl:\n* Modules/streams/ReadableStream.idl:\n* Modules/streams/ReadableStreamDefaultReader.idl:\n* Modules/streams/ReadableStreamSource.idl:\n* Modules/streams/WritableStream.idl:\n* Modules/webaudio/AudioContext.idl:\n* bindings/scripts/test/TestNode.idl:\n* bindings/scripts/test/TestObj.idl:\n* crypto/SubtleCrypto.idl:\n* crypto/WebKitSubtleCrypto.idl:\n* css/FontFace.idl:\n* css/FontFaceSet.idl:\n* dom/CustomElementRegistry.idl:\n* html/HTMLMediaElement.idl:\nUpdate IDLs to specify the resolve type of promise types.\n\n* Modules/mediastream/MediaEndpointPeerConnection.cpp:\n(WebCore::MediaEndpointPeerConnection::replaceTrack):\n(WebCore::MediaEndpointPeerConnection::replaceTrackTask):\n* Modules/mediastream/MediaStreamTrack.cpp:\n(WebCore::MediaStreamTrack::applyConstraints):\n* Modules/mediastream/MediaStreamTrack.h:\n* Modules/mediastream/PeerConnectionBackend.cpp:\n(WebCore::PeerConnectionBackend::setLocalDescriptionSucceeded):\n(WebCore::PeerConnectionBackend::setRemoteDescriptionSucceeded):\n(WebCore::PeerConnectionBackend::addIceCandidateSucceeded):\n* Modules/mediastream/PeerConnectionBackend.h:\n* Modules/streams/ReadableStreamSource.h:\n(WebCore::ReadableStreamSource::start):\n(WebCore::ReadableStreamSource::pull):\n(WebCore::ReadableStreamSource::startFinished):\n(WebCore::ReadableStreamSource::pullFinished):\n* Modules/webaudio/AudioContext.cpp:\n(WebCore::AudioContext::addReaction):\n(WebCore::AudioContext::setState):\n(WebCore::AudioContext::suspend):\n(WebCore::AudioContext::resume):\n(WebCore::AudioContext::close):\n* Modules/webaudio/AudioContext.h:\n* html/HTMLMediaElement.cpp:\n(WebCore::HTMLMediaElement::rejectPendingPlayPromises):\n(WebCore::HTMLMediaElement::resolvePendingPlayPromises):\n(WebCore::HTMLMediaElement::play):\n* html/HTMLMediaElement.h:\nUpdate implementations to use DOMPromise<void> rather than DOMPromise<nullptr_t>\nand use the new resolve() overload.\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@208474 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/graouts/webkit/commits/354f05c40054913430f8ca6ee806815189c43974"},{"sha":"6a4004175f80265ac5cc5d30e6cce81925260016","author":{"name":"dbates@webkit.org","email":"39f539c3440d966c455439489b845f9555be0ccf@webkit.org"},"message":"Add test infrastructure and tests for existing HTTP 0.9 sandbox machinery\nhttps://bugs.webkit.org/show_bug.cgi?id=164389\n<rdar://problem/29101072>\n\nReviewed by Alex Christensen.\n\nSource/WebCore:\n\nAdd test infrastructure to support registering an arbitrary port as the default port\nfor a protocol. The behavior of various machinery, including the HTTP 0.9 machinery,\ncan be effected by whether the resource request was made using the default port for\nthe protocol. We expose window.internals.registerDefaultPortForProtocol() to allow\na test to override the default port associated with a protocol so as to support\ntesting these code paths using the existing port 8000 server started by run-webkit-httpd.\nWithout window.internals.registerDefaultPortForProtocol() we would need to teach\nrun-webkit-httpd to run a web server on port 80, which requires superuser privileges\n(since it is a privileged port number) and is more likely to interfere with an\nexisting web server setup.\n\nTests: http/tests/security/http-0.9/default-port-plugin-blocked.html\n       http/tests/security/http-0.9/default-port-script-blocked.html\n       http/tests/security/http-0.9/iframe-blocked.html\n       http/tests/security/http-0.9/image-blocked.html\n       http/tests/security/http-0.9/image-on-HTTP-0.9-default-port-page-allowed-ref-test.html\n       http/tests/security/http-0.9/image-on-HTTP-0.9-default-port-page-allowed.html\n       http/tests/security/http-0.9/image-on-HTTP-0.9-page-blocked.html\n       http/tests/security/http-0.9/worker-connect-src-blocked.html\n       http/tests/security/http-0.9/worker-importScripts-blocked.html\n       http/tests/security/http-0.9/xhr-asynchronous-blocked.html\n\n* platform/URL.cpp:\n(WebCore::defaultPortForProtocolMapForTesting): Added.\n(WebCore::registerDefaultPortForProtocolForTesting): Adds the specified (protocol, port) to the\nmapping used for testing.\n(WebCore::clearDefaultPortForProtocolMapForTesting): Clears the protocol to default port testing map.\nWe call this function from Internals::resetToConsistentState() so that the mapping is cleared between\ntest runs.\n(WebCore::defaultPortForProtocol): Modified to check the protocol to default port map for testing\nbefore consulting URLParser::defaultPortForProtocol().\n* platform/URL.h:\n* testing/Internals.cpp:\n(WebCore::Internals::resetToConsistentState): Clear the default port mapping used for testing.\n(WebCore::Internals::registerDefaultPortForProtocol): Added.\n* testing/Internals.h:\n* testing/Internals.idl: Added declaration for registerDefaultPortForProtocol().\n\nLayoutTests:\n\nAdd tests for the existing HTTP 0.9 sandbox machinery. Until we fix <https://bugs.webkit.org/show_bug.cgi?id=164387>,\nthese tests can only be run singly (i.e. pass --run-singly to run-webkit-tests). So, we skip\nthese tests to avoid test failures when run-webkit-tests runs in parallel mode (the default\nmode and the mode used on the buildbots).\n\n* TestExpectations:\n* http/tests/security/http-0.9/default-port-plugin-blocked-expected.txt: Added.\n* http/tests/security/http-0.9/default-port-plugin-blocked.html: Added.\n* http/tests/security/http-0.9/default-port-script-blocked-expected.txt: Added.\n* http/tests/security/http-0.9/default-port-script-blocked.html: Added.\n* http/tests/security/http-0.9/iframe-blocked-expected.txt: Added.\n* http/tests/security/http-0.9/iframe-blocked.html: Added.\n* http/tests/security/http-0.9/image-blocked-expected.txt: Added.\n* http/tests/security/http-0.9/image-blocked.html: Added.\n* http/tests/security/http-0.9/image-on-HTTP-0.9-default-port-page-allowed-expected.txt: Added.\n* http/tests/security/http-0.9/image-on-HTTP-0.9-default-port-page-allowed-ref-test-expected.html: Added.\n* http/tests/security/http-0.9/image-on-HTTP-0.9-default-port-page-allowed-ref-test.html: Added.\n* http/tests/security/http-0.9/image-on-HTTP-0.9-default-port-page-allowed.html: Added.\n* http/tests/security/http-0.9/image-on-HTTP-0.9-page-blocked-expected.txt: Added.\n* http/tests/security/http-0.9/image-on-HTTP-0.9-page-blocked.html: Added.\n* http/tests/security/http-0.9/resources/blue-square.png: Added.\n* http/tests/security/http-0.9/resources/nph-alert-fail.pl: Added.\n* http/tests/security/http-0.9/resources/nph-fail.pl: Added.\n* http/tests/security/http-0.9/resources/nph-image-on-HTTP-0.9-default-port-page-allowed.pl: Added.\n* http/tests/security/http-0.9/resources/nph-image-on-HTTP-0.9-page-blocked.pl: Added.\n* http/tests/security/http-0.9/resources/nph-image.pl: Added.\n* http/tests/security/http-0.9/resources/nph-load-plugin-fail.pl: Added.\n* http/tests/security/http-0.9/resources/nph-worker-fail.pl: Added.\n* http/tests/security/http-0.9/worker-connect-src-blocked-expected.txt: Added.\n* http/tests/security/http-0.9/worker-connect-src-blocked.html: Added.\n* http/tests/security/http-0.9/worker-importScripts-blocked-expected.txt: Added.\n* http/tests/security/http-0.9/worker-importScripts-blocked.html: Added.\n* http/tests/security/http-0.9/xhr-asynchronous-blocked-expected.txt: Added.\n* http/tests/security/http-0.9/xhr-asynchronous-blocked.html: Added.\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@208475 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/graouts/webkit/commits/6a4004175f80265ac5cc5d30e6cce81925260016"},{"sha":"0797fdc9856c0edbd196cf42df869f464911fa42","author":{"name":"darin@apple.com","email":"009da5f71ae5055bc6ae7b3a9c8f8ed7c370e31b@apple.com"},"message":"Move EventTarget from ExceptionCode to ExceptionOr\nhttps://bugs.webkit.org/show_bug.cgi?id=164465\n\nReviewed by Youenn Fablet.\n\nSource/WebCore:\n\n* Modules/indexeddb/IDBRequest.h: Added now-needed forward\nclass declarations.\n* Modules/webaudio/AudioContext.h: Ditto.\n\n* bindings/js/JSEventListener.cpp:\n(WebCore::eventHandlerAttribute): Updated for name change of the\nattributeEventListener function.\n(WebCore::documentEventHandlerAttribute): Ditto.\n* dom/Document.cpp:\n(WebCore::Document::getWindowAttributeEventListener): Ditto.\n\n* dom/EventTarget.cpp:\n(WebCore::EventTarget::setAttributeEventListener): Updated for\nname change.\n(WebCore::EventTarget::attributeEventListener): Ditto.\n(WebCore::EventTarget::dispatchEventForBindings): Use ExceptionOr.\n(WebCore::legacyType): Use null instead of empty for no type, since\nit's more efficient to check for null.\n(WebCore::EventTarget::fireEventListeners): Check for null.\nAlso streamlined logic a little bit and removed a very old comment.\n(WebCore::EventTarget::eventListeners): Renamed from getEventListeners.\n* dom/EventTarget.h: Removed lots of unneeded declarations. Renamed\nsome functions to remove get prefix. Updated for above changes.\nMoved one inline function out of the class header. Made the destructor\nfor EventTarget be inline to make the destructors for derived classes\nslightly more efficient.\n* dom/EventTarget.idl: Use non-legacy exception.\n\n* dom/Node.cpp:\n(WebCore::Node::didMoveToNewDocument): Updated for name change.\n* editing/ReplaceSelectionCommand.cpp:\n(WebCore::ReplacementFragment::ReplacementFragment): Ditto.\n\n* inspector/InspectorCSSAgent.h: Added now-needed forward declaration.\n\n* inspector/InspectorDOMAgent.cpp:\n(WebCore::InspectorDOMAgent::getEventListeners): Updated for name change.\n\n* inspector/InspectorInstrumentation.h: Added now-needed forward declaration.\n* page/DOMWindow.h: Ditto.\n* xml/XMLHttpRequest.h: Ditto.\n\nSource/WebKit/mac:\n\n* DOM/DOMNode.mm:\n(-[DOMNode dispatchEvent:]): Updated exception handling.\n\nSource/WebKit/win:\n\n* DOMCoreClasses.cpp:\n(DOMNode::dispatchEvent): Updated exception handling.\n(DOMWindow::dispatchEvent): Ditto.\n\nSource/WebKit2:\n\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMAttr.cpp:\n(webkit_dom_attr_dispatch_event): Updated exception handling.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMCDATASection.cpp:\n(webkit_dom_cdata_section_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMCharacterData.cpp:\n(webkit_dom_character_data_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMComment.cpp:\n(webkit_dom_comment_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDOMWindow.cpp:\n(webkit_dom_dom_window_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocument.cpp:\n(webkit_dom_document_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocumentFragment.cpp:\n(webkit_dom_document_fragment_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocumentType.cpp:\n(webkit_dom_document_type_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElement.cpp:\n(webkit_dom_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLAnchorElement.cpp:\n(webkit_dom_html_anchor_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLAppletElement.cpp:\n(webkit_dom_html_applet_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLAreaElement.cpp:\n(webkit_dom_html_area_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLBRElement.cpp:\n(webkit_dom_html_br_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLBaseElement.cpp:\n(webkit_dom_html_base_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLBodyElement.cpp:\n(webkit_dom_html_body_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLButtonElement.cpp:\n(webkit_dom_html_button_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLCanvasElement.cpp:\n(webkit_dom_html_canvas_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLDListElement.cpp:\n(webkit_dom_html_d_list_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLDirectoryElement.cpp:\n(webkit_dom_html_directory_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLDivElement.cpp:\n(webkit_dom_html_div_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLDocument.cpp:\n(webkit_dom_html_document_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLElement.cpp:\n(webkit_dom_html_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLEmbedElement.cpp:\n(webkit_dom_html_embed_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLFieldSetElement.cpp:\n(webkit_dom_html_field_set_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLFontElement.cpp:\n(webkit_dom_html_font_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLFormElement.cpp:\n(webkit_dom_html_form_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLFrameElement.cpp:\n(webkit_dom_html_frame_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLFrameSetElement.cpp:\n(webkit_dom_html_frame_set_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLHRElement.cpp:\n(webkit_dom_html_hr_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLHeadingElement.cpp:\n(webkit_dom_html_heading_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLHeadElement.cpp:\n(webkit_dom_html_head_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLHtmlElement.cpp:\n(webkit_dom_html_html_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLIFrameElement.cpp:\n(webkit_dom_html_iframe_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLImageElement.cpp:\n(webkit_dom_html_image_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLInputElement.cpp:\n(webkit_dom_html_input_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLLIElement.cpp:\n(webkit_dom_html_li_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLLabelElement.cpp:\n(webkit_dom_html_label_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLLegendElement.cpp:\n(webkit_dom_html_legend_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLLinkElement.cpp:\n(webkit_dom_html_link_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLMapElement.cpp:\n(webkit_dom_html_map_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLMarqueeElement.cpp:\n(webkit_dom_html_marquee_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLMenuElement.cpp:\n(webkit_dom_html_menu_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLMetaElement.cpp:\n(webkit_dom_html_meta_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLModElement.cpp:\n(webkit_dom_html_mod_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLOListElement.cpp:\n(webkit_dom_html_o_list_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLObjectElement.cpp:\n(webkit_dom_html_object_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLOptGroupElement.cpp:\n(webkit_dom_html_opt_group_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLOptionElement.cpp:\n(webkit_dom_html_option_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLParagraphElement.cpp:\n(webkit_dom_html_paragraph_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLParamElement.cpp:\n(webkit_dom_html_param_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLPreElement.cpp:\n(webkit_dom_html_pre_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLQuoteElement.cpp:\n(webkit_dom_html_quote_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLScriptElement.cpp:\n(webkit_dom_html_script_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLSelectElement.cpp:\n(webkit_dom_html_select_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLStyleElement.cpp:\n(webkit_dom_html_style_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLTableCaptionElement.cpp:\n(webkit_dom_html_table_caption_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLTableCellElement.cpp:\n(webkit_dom_html_table_cell_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLTableColElement.cpp:\n(webkit_dom_html_table_col_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLTableElement.cpp:\n(webkit_dom_html_table_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLTableRowElement.cpp:\n(webkit_dom_html_table_row_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLTableSectionElement.cpp:\n(webkit_dom_html_table_section_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLTextAreaElement.cpp:\n(webkit_dom_html_text_area_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLTitleElement.cpp:\n(webkit_dom_html_title_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLUListElement.cpp:\n(webkit_dom_html_u_list_element_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMNode.cpp:\n(webkit_dom_node_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMProcessingInstruction.cpp:\n(webkit_dom_processing_instruction_dispatch_event): Ditto.\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMText.cpp:\n(webkit_dom_text_dispatch_event): Ditto.\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@208476 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/graouts/webkit/commits/0797fdc9856c0edbd196cf42df869f464911fa42"},{"sha":"f752374543e17859b809fd7864cb8803f2f618d4","author":{"name":"ryanhaddad@apple.com","email":"044732395dbd3a6b887403c0dc03a062a8c4066e@apple.com"},"message":"Correct a typo in the name of a flaky test.\nhttps://bugs.webkit.org/show_bug.cgi?id=164388\n\nUnreviewed test gardening.\n\n* platform/mac/TestExpectations:\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@208477 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/graouts/webkit/commits/f752374543e17859b809fd7864cb8803f2f618d4"},{"sha":"1c8ae0078884b9032289ed8c2c93c34fda07f931","author":{"name":"hyatt@apple.com","email":"9abeb171ebfeffd5098091200b715df64b104425@apple.com"},"message":"[CSS Parser] Fix grid layout parsing\nhttps://bugs.webkit.org/show_bug.cgi?id=164489\n\nReviewed by Dean Jackson.\n\nSource/WebCore:\n\n* css/CSSValueKeywords.in:\n* css/parser/CSSPropertyParser.cpp:\n(WebCore::consumeFitContent):\n(WebCore::isGridTrackFixedSized):\n(WebCore::consumeGridTrackSize):\n(WebCore::consumeGridTrackRepeatFunction):\n(WebCore::consumeGridTrackList):\n(WebCore::isCustomIdentValue):\n(WebCore::CSSPropertyParser::consumeGridItemPositionShorthand):\n(WebCore::CSSPropertyParser::consumeGridAreaShorthand):\n(WebCore::consumeImplicitGridAutoFlow):\n(WebCore::CSSPropertyParser::consumeGridShorthand):\n\nLayoutTests:\n\n* fast/css-grid-layout/grid-auto-columns-rows-auto-flow-resolution.html:\n\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@208478 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/graouts/webkit/commits/1c8ae0078884b9032289ed8c2c93c34fda07f931"},{"sha":"6a9a3bf1021ef4624a33183066f5ef313cd3317f","author":{"name":"darin@apple.com","email":"009da5f71ae5055bc6ae7b3a9c8f8ed7c370e31b@apple.com"},"message":"Move Range from ExceptionCode to ExceptionOr\nhttps://bugs.webkit.org/show_bug.cgi?id=164457\n\nReviewed by Alex Christensen.\n\nSource/WebCore:\n\n* accessibility/AXObjectCache.cpp:\n(WebCore::AXObjectCache::rangeForNodeContents): Update to use ExceptionOr,\nkeeping behavior the same.\n(WebCore::characterOffsetsInOrder): Ditto.\n(WebCore::setRangeStartOrEndWithCharacterOffset): Changed argument to a\nreference instead of a pointer. Use a boolean return value to indicate\nsuccess rather than an exception, since the callers don't need to know\nwhich exception it is.\n(WebCore::AXObjectCache::rangeForUnorderedCharacterOffsets): Updated for\nthe above.\n(WebCore::AXObjectCache::nextBoundary): Ditto.\n(WebCore::AXObjectCache::previousBoundary): Ditto.\n\n* accessibility/AccessibilityObject.cpp:\n(WebCore::AccessibilityObject::rangeOfStringClosestToRangeInDirection):\nUpdate to use ExceptionOr, keeping behavior the same.\n* accessibility/AccessibilityRenderObject.cpp:\n(WebCore::AccessibilityRenderObject::documentBasedSelectedTextRange): Ditto.\n* accessibility/atk/WebKitAccessibleUtil.cpp:\n(selectionBelongsToObject): Ditto.\n* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:\n(-[WebAccessibilityObjectWrapper _convertToNSRange:]): Ditto.\n* dom/Node.cpp:\n(WebCore::Node::textRects): Ditto.\n\n* dom/Range.cpp:\n(WebCore::Range::~Range): Remove old comment that no longer makes sense now\nthat the detach function no longer does anything.\n(WebCore::checkForDifferentRootContainer): Updated to use ExceptionOr,\nkeeping behavior the same.\n(WebCore::Range::setStart): Ditto.\n(WebCore::Range::setEnd): Ditto.\n(WebCore::Range::isPointInRange): Ditto.\n(WebCore::Range::comparePoint): Ditto.\n(WebCore::Range::compareNode): Ditto.\n(WebCore::top): Added helper function so that compareBoundaryPoints doesn't\nneed to have two identical loops in it.\n(WebCore::Range::compareBoundaryPoints): Updated to use ExceptionOr,\nkeeping behavior the same.\n(WebCore::Range::compareBoundaryPointsForBindings): Ditto. Also use a switch\ninstead of relying on the order of the values to check for unsupported values.\n(WebCore::Range::boundaryPointsValid): Ditto.\n(WebCore::Range::deleteContents): Ditto.\n(WebCore::Range::intersectsNode): Ditto.\n(WebCore::Range::processContents): Ditto.\n(WebCore::deleteCharacterData): Ditto.\n(WebCore::processContentsBetweenOffsets): Ditto. Also changed to be a\nnon-member function and private to this file instead of in the class.\n(WebCore::processNodes): Ditto. Also changed one argument to be a RefPtr\nsince the code relies on using it after mutating the DOM.\n(WebCore::processAncestorsAndTheirSiblings): Ditto. Changed one argument type\nto use ExceptionOr so the caller doesn't have to check the exception first.\n(WebCore::Range::extractContents): Ditto.\n(WebCore::Range::cloneContents): Ditto.\n(WebCore::Range::insertNode): Ditto. Also fixed to only call nodeType once\ninstead of three times.\n(WebCore::Range::toString): Ditto. Also fixed to call nodeType only once\nper node instead of twice, to use downcast instead of static_cast, and to\nuse the word \"node\" instead of \"n\" for the local variable name.\n(WebCore::Range::createContextualFragment): Ditto.\n(WebCore::Range::checkNodeWOffset): Ditto.\n(WebCore::Range::setStartAfter): Ditto.\n(WebCore::Range::setEndBefore): Ditto.\n(WebCore::Range::setEndAfter): Ditto.\n(WebCore::Range::selectNode): Ditto.\n(WebCore::Range::selectNodeContents): Ditto.\n(WebCore::Range::surroundContents): Ditto.\n(WebCore::Range::setStartBefore): Ditto.\n(WebCore::Range::contains): Ditto. Except added code to handle exception\ncase to return false without asserting because I saw at least one crash\nthat seemed to imply this behavior was needed.\n(WebCore::rangesOverlap): Ditto.\n(WebCore::rangeOfContents): Ditto.\n(WebCore::Range::expand): Ditto.\n(WebCore::Range::getClientRects): Ditto.\n(WebCore::Range::getBoundingClientRect): Ditto.\n(WebCore::Range::borderAndTextQuads): Changed to use return value\ninstead of out argument, since it's a private function used only\nwithin this class so it was easy to update all call sites.\n(WebCore::Range::boundingRect): Updated for above. Also renamed since\nthere was no need for the name \"internal\" in this.\n(WebCore::Range::absoluteBoundingRect): Ditto.\n* dom/Range.h: Updated for above.\n* dom/Range.idl: Use non-legacy exceptions. Also changed the default value\nof the string argument to the expand function to the empty string rather\nthan \"undefined\", because the function silently does nothing when passed\nany unrecognized string, and so this leaves behavior unchanged. I removed\nthe comment saying that the \"undefined\" default is wrong.\n\n* editing/AlternativeTextController.cpp:\n(WebCore::AlternativeTextController::applyAlternativeTextToRange): Updated\nto use ExceptionOr but behave the same.\n* editing/Editor.cpp:\n(WebCore::Editor::advanceToNextMisspelling): Ditto.\n(WebCore::Editor::markAndReplaceFor): Ditto.\n(WebCore::isFrameInRange): Ditto. Also made a few style tweaks.\n(WebCore::Editor::countMatchesForText): Ditto.\n* editing/EditorCommand.cpp:\n(WebCore::unionDOMRanges): Ditto.\n* editing/FrameSelection.cpp:\n(WebCore::FrameSelection::respondToNodeModification): Ditto.\n* editing/InsertListCommand.cpp:\n(WebCore::InsertListCommand::doApplyForSingleParagraph): Ditto.\n* editing/TextCheckingHelper.cpp:\n(WebCore::TextCheckingParagraph::offsetTo): Ditto.\n* editing/TextCheckingHelper.h: Updated for above and also deleted\nunneeded private function checkingRange, which just churned the\nreference count unnecessarily; instead use m_checkingRange directly.\n* editing/TextIterator.cpp:\n(WebCore::TextIterator::getLocationAndLengthFromRange): Ditto.\n* editing/VisiblePosition.cpp:\n(WebCore::setStart): Ditto.\n(WebCore::setEnd): Ditto.\n* editing/VisibleSelection.cpp:\n(WebCore::makeSearchRange): Ditto.\n\n* editing/VisibleUnits.cpp:\n(WebCore::suffixLengthForRange): Changed argument from RefPtr to\na reference.\n(WebCore::prefixLengthForRange): Ditto.\n(WebCore::previousBoundary): Updated for ExceptionOr and the change\nabove.\n(WebCore::nextBoundary): Ditto.\n* editing/VisibleUnits.h: Updated for above.\n\n* editing/htmlediting.cpp:\n(WebCore::comparePositions): Updated to use ExceptionOr but behave\nthe same.\n(WebCore::visiblePositionForIndexUsingCharacterIterator): Ditto.\n(WebCore::isNodeVisiblyContainedWithin): Ditto.\n* editing/ios/EditorIOS.mm:\n(WebCore::Editor::setDictationPhrasesAsChildOfElement): Ditto.\n(WebCore::Editor::setTextAsChildOfElement): Ditto.\n* editing/mac/EditorMac.mm:\n(WebCore::Editor::adjustedSelectionRange): Ditto.\n* editing/markup.cpp:\n(WebCore::createMarkupInternal): Ditto.\n* page/ContextMenuController.cpp:\n(WebCore::ContextMenuController::contextMenuItemSelected): Ditto.\n* page/DOMSelection.cpp:\n(WebCore::DOMSelection::addRange): Ditto.\n(WebCore::DOMSelection::deleteFromDocument): Ditto.\n(WebCore::DOMSelection::containsNode): Ditto.\n\n* page/EventHandler.cpp:\n(WebCore::EventHandler::dispatchMouseEvent): Updated for change to\nuse ExceptionOr in Ragne::compareNode. Also refactored the function\nto make the logic a little mroe straightforward and nest less of it\ninside a loop.\n\n* page/Page.cpp:\n(WebCore::Page::findStringMatchingRanges): Updated for ExceptionOr\nwithout changing behavior.\n* page/TextIndicator.cpp:\n(WebCore::hasNonInlineOrReplacedElements): Ditto.\n* rendering/RenderNamedFlowThread.cpp:\n(WebCore::RenderNamedFlowThread::getRanges): Ditto.\n\nSource/WebKit/mac:\n\n* DOM/DOMRange.mm:\n(-[DOMRange setStart:offset:]): Updated exception handling.\n(-[DOMRange setEnd:offset:]): Ditto.\n(-[DOMRange setStartBefore:]): Ditto.\n(-[DOMRange setStartAfter:]): Ditto.\n(-[DOMRange setEndBefore:]): Ditto.\n(-[DOMRange setEndAfter:]): Ditto.\n(-[DOMRange selectNode:]): Ditto.\n(-[DOMRange selectNodeContents:]): Ditto.\n(-[DOMRange compareBoundaryPoints:sourceRange:]): Ditto.\n(-[DOMRange deleteContents]): Ditto.\n(-[DOMRange extractContents]): Ditto.\n(-[DOMRange cloneContents]): Ditto.\n(-[DOMRange insertNode:]): Ditto.\n(-[DOMRange surroundContents:]): Ditto.\n(-[DOMRange createContextualFragment:]): Ditto.\n(-[DOMRange compareNode:]): Ditto.\n(-[DOMRange intersectsNode:]): Ditto.\n(-[DOMRange comparePoint:offset:]): Ditto.\n(-[DOMRange isPointInRange:offset:]): Ditto.\n(-[DOMRange expand:]): Ditto.\n* WebView/WebFrame.mm:\n(-[WebFrame _documentFragmentWithMarkupString:baseURLString:]): Ditto.\n(-[WebFrame _smartDeleteRangeForProposedRange:]): Deleted.\nThis function was incorrectly implemented (set both start and end of\nthe range to the computed start), not declared in any header file,\nnot used anywhere inside WebKit, and I also could not find a use of it\nin outside-WebKit Apple code.\n* mac/DOM/DOMUIKitExtensions.mm:\n(-[DOMRange move:inDirection:]): Ditto.\n(-[DOMRange extend:inDirection:]): Ditto.\n\nSource/WebKit/win:\n\n* WebView.cpp:\n(WebView::onIMERequestCharPosition): Updated for new exception handling.\n\nSource/WebKit2:\n\n* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMRange.cpp:\n(webkit_dom_range_set_start): Updated exception handling.\n(webkit_dom_range_set_end): Ditto.\n(webkit_dom_range_set_start_before): Ditto.\n(webkit_dom_range_set_start_after): Ditto.\n(webkit_dom_range_set_end_before): Ditto.\n(webkit_dom_range_set_end_after): Ditto.\n(webkit_dom_range_select_node): Ditto.\n(webkit_dom_range_select_node_contents): Ditto.\n(webkit_dom_range_compare_boundary_points): Ditto.\n(webkit_dom_range_delete_contents): Ditto.\n(webkit_dom_range_extract_contents): Ditto.\n(webkit_dom_range_clone_contents): Ditto.\n(webkit_dom_range_insert_node): Ditto.\n(webkit_dom_range_surround_contents): Ditto.\n(webkit_dom_range_create_contextual_fragment): Ditto.\n(webkit_dom_range_compare_node): Ditto.\n(webkit_dom_range_intersects_node): Ditto.\n(webkit_dom_range_compare_point): Ditto.\n(webkit_dom_range_is_point_in_range): Ditto.\n(webkit_dom_range_expand): Ditto.\n* WebProcess/InjectedBundle/API/mac/WKDOMRange.mm:\n(-[WKDOMRange setStart:offset:]): Ditto.\n(-[WKDOMRange setEnd:offset:]): Ditto.\n(-[WKDOMRange selectNode:]): Ditto.\n(-[WKDOMRange selectNodeContents:]): Ditto.\n* WebProcess/WebPage/WebFrame.cpp:\n(WebKit::WebFrame::contentsAsString): Ditto.\n* WebProcess/WebPage/ios/WebPageIOS.mm:\n(WebKit::WebPage::rangeForWebSelectionAtPosition): Ditto.\n(WebKit::WebPage::rangeForBlockAtPoint): Ditto.\n(WebKit::WebPage::selectWithGesture): Ditto.\n(WebKit::containsRange): Ditto.\n(WebKit::unionDOMRanges): Ditto.\n(WebKit::WebPage::switchToBlockSelectionAtPoint): Ditto.\n(WebKit::WebPage::getPositionInformation): Ditto.\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@208479 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/graouts/webkit/commits/6a9a3bf1021ef4624a33183066f5ef313cd3317f"},{"sha":"def470bd6b42108195ddd8b523267a04e4e7b702","author":{"name":"commit-queue@webkit.org","email":"bf5a5ee7740adc2e16c9908c58a0c6d4239e6078@webkit.org"},"message":"[SVG] Start moving special casing of SVG out of the bindings - SVGAngle\nhttps://bugs.webkit.org/show_bug.cgi?id=164496\n\nPatch by Sam Weinig <sam@webkit.org> on 2016-11-09\nReviewed by Darin Adler.\n\nThere is quite a bit of special casing of SVG types in the bindings that adds\na lot of complexity and is relatively fragile, as it is based on type naming.\n\nInstead of keeping the complexity in the bindings, I am going to move it into\nthe implementation, where it has also longed to be.\n\nStarting small, with just SVGAngle. It has been split in two, with the existing\nSVGAngle being renamed SVGAngleValue, and the bound instance, which used to be name\nSVGPropertyTearOff<SVGAngle>, taking the name SVGAngle (and inheriting from\nSVGPropertyTearOff<SVGAngleValue>).\n\n* CMakeLists.txt:\n* WebCore.xcodeproj/project.pbxproj:\nAdd SVGAngleValue.cpp\n\n* bindings/scripts/CodeGenerator.pm:\nRemove SVGAngle as a special case.\n\n* svg/SVGAngle.cpp: Removed.\n* svg/SVGAngle.h:\nAdded. Implements the SVGAngle interface explicitly, getting to\nthe SVGAngleValue through propertyReference().\n\n* svg/SVGAngle.idl:\n* svg/SVGAngleValue.cpp: Copied from Source/WebCore/svg/SVGAngle.cpp.\n* svg/SVGAngleValue.h: Copied from Source/WebCore/svg/SVGAngle.h.\nMove old SVGAngle implementation to SVGAngleValue.\n\n* svg/SVGAnimatedAngle.cpp:\nReplace SVGAngle usage with SVGAngleValue.\n\n* svg/SVGAnimatedAngle.h:\nSwitch SVGAnimatedAngle to be a type alias. This remains SVGAnimatedPropertyTearOff<SVGAngle>\nas SVGAnimatedPropertyTearOff has been changed to take the TearOff type as its parameter.\n\n* svg/SVGAnimatedLength.h:\n* svg/SVGAnimatedPreserveAspectRatio.h:\n* svg/SVGAnimatedRect.h:\nSwitch to using type aliases and pass the TearOff to SVGAnimatedPropertyTearOff.\n\n* svg/SVGAnimatedType.cpp:\n(WebCore::SVGAnimatedType::createAngleAndEnumeration):\n* svg/SVGAnimatedType.h:\n(WebCore::SVGAnimatedType::angleAndEnumeration):\nUse SVGAngleValue.\n\n* svg/SVGComponentTransferFunctionElement.h:\nAdd missing include of SVGElement.h (need because it removed from SVGPropertyTearOff).\n\n* svg/SVGMarkerElement.cpp:\n(WebCore::SVGMarkerElement::parseAttribute):\n(WebCore::SVGMarkerElement::setOrient):\nSwitch to take an SVGAngleValue.\n\n(WebCore::SVGMarkerElement::setOrientToAngle):\nUpdate to pull the value out via propertyReference().\n\n* svg/SVGMarkerElement.h:\nSwitch to take an SVGAngleValue.\n\n* svg/SVGLengthList.h:\n* svg/SVGNumberList.h:\n* svg/SVGPathSegList.h:\n* svg/SVGPointList.h:\n* svg/SVGStringList.h:\n* svg/SVGTransformList.h:\nSwitch to using type aliases in SVGPropertyTraits and add an alias for\nListItemTearOff.\n\n* svg/SVGSVGElement.cpp:\n(WebCore::SVGSVGElement::createSVGAngle):\n* svg/SVGSVGElement.h:\nChange createSVGAngle to return a Ref<SVGAngle> and create one.\n\n* svg/SVGSVGElement.idl:\nAnnotate IDL to indicate that a new value is being returned.\n\n* svg/SVGTransform.cpp:\nRemove unnecessary include of SVGAngle.h.\n\n* svg/SVGViewSpec.cpp:\nAdd missing include of SVGElement.h (need because it removed from SVGPropertyTearOff).\n\n* svg/properties/SVGAnimatedPropertyTearOff.h:\nChange to be parameterized on the TearOffType, rather than the PropertyType itself. Get the\nProperty type from the TearOffType.\n\n* svg/properties/SVGListProperty.h:\n* svg/properties/SVGListPropertyTearOff.h:\nFix assumption that all TearOffTypes are just a SVGPropertyTearOff templatized on a property\ntype. This is no longer true for SVGAngle. Instead, get the TearOffType for lists via SVGPropertyTraits.\n\n* svg/properties/SVGPropertyTearOff.h:\nMake the PropertyType available by exposing it as a type alias.\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@208480 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/graouts/webkit/commits/def470bd6b42108195ddd8b523267a04e4e7b702"},{"sha":"8375ee35192d1bcd6a3a9c9b5483274fb1ea157c","author":{"name":"utatane.tea@gmail.com","email":"5b6caba828616d83be87379dfbd4f472729de13f@gmail.com"},"message":"[DOMJIT] Implement Node::ownerDocument\nhttps://bugs.webkit.org/show_bug.cgi?id=164004\n\nReviewed by Darin Adler.\n\nSource/WebCore:\n\nTest: js/dom/domjit-accessor-owner-document.html\n\nStill I cannot reproduce this crash in x64 environment, according to the crash log, it accesses 0x8 address.\nThis can happen if document() accidentally returns nullptr. In the C++ ownerDocument implementation,\nif document() returns nullptr, it just returns nullptr. But in the DOMJIT implementation, we assume that\ndocument() won't return nullptr and access the member of it.\n\nThis patch aligns the DOMJIT implementation strictly to the C++ one.\n\n* dom/Node.idl:\n* domjit/JSNodeDOMJIT.cpp:\n(WebCore::NodeOwnerDocumentDOMJIT::checkDOM):\n(WebCore::NodeOwnerDocumentDOMJIT::callDOMGetter):\n\nLayoutTests:\n\n* js/dom/domjit-accessor-owner-document-expected.txt: Added.\n* js/dom/domjit-accessor-owner-document.html: Added.\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@208481 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/graouts/webkit/commits/8375ee35192d1bcd6a3a9c9b5483274fb1ea157c"},{"sha":"45a15a1ee5104a9ccf8fa9675e87f54cfbfb4a0a","author":{"name":"commit-queue@webkit.org","email":"bf5a5ee7740adc2e16c9908c58a0c6d4239e6078@webkit.org"},"message":"Allow RefPtrs of const ThreadSafeRefCounted types\nhttps://bugs.webkit.org/show_bug.cgi?id=164548\n\nPatch by Alex Christensen <achristensen@webkit.org> on 2016-11-09\nReviewed by Tim Horton.\n\n* wtf/ThreadSafeRefCounted.h:\nMake m_refCount mutable like we did with RefCounted in r203257.\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@208482 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/graouts/webkit/commits/45a15a1ee5104a9ccf8fa9675e87f54cfbfb4a0a"},{"sha":"5cf2cf7ea8a21b249d842e4462d9540c883360b1","author":{"name":"Antoine Quint","email":"707822a6054eb24ecb3c3cd12d7b302f419ccc2c@apple.com"},"message":"StatusSupport.","distinct":true,"url":"https://api.github.com/repos/graouts/webkit/commits/5cf2cf7ea8a21b249d842e4462d9540c883360b1"},{"sha":"ca8f3fb2bfa660f14c2712d045a20c53c9b95c64","author":{"name":"Antoine Quint","email":"707822a6054eb24ecb3c3cd12d7b302f419ccc2c@apple.com"},"message":"Testcase for Error.","distinct":true,"url":"https://api.github.com/repos/graouts/webkit/commits/ca8f3fb2bfa660f14c2712d045a20c53c9b95c64"},{"sha":"83ffa6a2de586c8684629e7771e4ead8ddb4832e","author":{"name":"Antoine Quint","email":"707822a6054eb24ecb3c3cd12d7b302f419ccc2c@apple.com"},"message":"Test for \"Loading\" state.","distinct":true,"url":"https://api.github.com/repos/graouts/webkit/commits/83ffa6a2de586c8684629e7771e4ead8ddb4832e"}]}
{"actor":{"display_login":"graouts"}}