{"action":"created","comment":{"url":"https://api.github.com/repos/jlongster/debugger.html/pulls/comments/70693374","id":70693374,"diff_hunk":"@@ -37,10 +53,11 @@ function addBreakpoint(location, { condition, getTextForLine } = {}) {\n       breakpoint: bp.toJS(),\n       condition: condition,\n       [PROMISE]: Task.spawn(function* () {\n-        const { id, actualLocation } = yield client.setBreakpoint(\n+        const res: any = yield client.setBreakpoint(","path":"public/js/actions/breakpoints.js","position":57,"original_position":57,"commit_id":"269192373febaefb50c325cea6aede8e81ad2dd5","original_commit_id":"269192373febaefb50c325cea6aede8e81ad2dd5","user":{"login":"jasonLaster","id":254562,"avatar_url":"https://avatars.githubusercontent.com/u/254562?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonLaster","html_url":"https://github.com/jasonLaster","followers_url":"https://api.github.com/users/jasonLaster/followers","following_url":"https://api.github.com/users/jasonLaster/following{/other_user}","gists_url":"https://api.github.com/users/jasonLaster/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonLaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonLaster/subscriptions","organizations_url":"https://api.github.com/users/jasonLaster/orgs","repos_url":"https://api.github.com/users/jasonLaster/repos","events_url":"https://api.github.com/users/jasonLaster/events{/privacy}","received_events_url":"https://api.github.com/users/jasonLaster/received_events","type":"User","site_admin":false},"body":"This also seems unhelpful. It might be nice to type the client, but on the other hand I also don't expect it to change much and I appreciate being able to destructure on assignments.","created_at":"2016-07-13T19:36:00Z","updated_at":"2016-07-13T19:36:00Z","html_url":"https://github.com/jlongster/debugger.html/pull/325#discussion_r70693374","pull_request_url":"https://api.github.com/repos/jlongster/debugger.html/pulls/325","_links":{"self":{"href":"https://api.github.com/repos/jlongster/debugger.html/pulls/comments/70693374"},"html":{"href":"https://github.com/jlongster/debugger.html/pull/325#discussion_r70693374"},"pull_request":{"href":"https://api.github.com/repos/jlongster/debugger.html/pulls/325"}}},"pull_request":{"url":"https://api.github.com/repos/jlongster/debugger.html/pulls/325","id":77343330,"html_url":"https://github.com/jlongster/debugger.html/pull/325","diff_url":"https://github.com/jlongster/debugger.html/pull/325.diff","patch_url":"https://github.com/jlongster/debugger.html/pull/325.patch","issue_url":"https://api.github.com/repos/jlongster/debugger.html/issues/325","number":325,"state":"open","locked":false,"title":"Flow","user":{"login":"jlongster","id":17031,"avatar_url":"https://avatars.githubusercontent.com/u/17031?v=3","gravatar_id":"","url":"https://api.github.com/users/jlongster","html_url":"https://github.com/jlongster","followers_url":"https://api.github.com/users/jlongster/followers","following_url":"https://api.github.com/users/jlongster/following{/other_user}","gists_url":"https://api.github.com/users/jlongster/gists{/gist_id}","starred_url":"https://api.github.com/users/jlongster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlongster/subscriptions","organizations_url":"https://api.github.com/users/jlongster/orgs","repos_url":"https://api.github.com/users/jlongster/repos","events_url":"https://api.github.com/users/jlongster/events{/privacy}","received_events_url":"https://api.github.com/users/jlongster/received_events","type":"User","site_admin":false},"body":"I'm so sorry for the size of this PR.\r\n\r\nFlow makes us use babel to strip the types, and that tends to have a cascading effect. I'm not sure if we'll be able to avoid babel in the long run though. The immediate thing that comes to mind is JSX. If we are ok with a build step (which we are), we'll probably end up using that.\r\n\r\nThe main annoyance was that the linter was complaining now because the \"use strict\" directive is redundant; all files are passed through babel which forces strict mode. So the majority of the files changes is just removing all strict directives.\r\n\r\nThe interesting parts are the files that I annotated with flow:\r\n\r\n```\r\n./public/js/actions/breakpoints.js\r\n./public/js/actions/types.js\r\n./public/js/reducers/sources.js\r\n./public/js/reducers/tests/sources.js\r\n./public/js/selectors.js\r\n./public/js/util/fromJS.js\r\n./public/js/util/makeRecord.js\r\n./public/js/util/test-head.js\r\n```\r\n\r\nI wanted to have one of each type of file annotated: a reducer, an action creator, the selectors, and a test. For example, if you go into `selectors.js`, in `getSources`, and introduce a typo like `return state.sources.sources2`, you will see a type error when you run `flow` (or `npm run flow`). There are several places in the above files where this will happen now.\r\n\r\nI went through many attempts at the initial integration, so some things might still be leftover from that. There are still several places in these files that aren't type-checked, and we need to figure out how to check everything in them, but this PR is already large enough.\r\n\r\nAnother example is going into `public/js/reducers/tests/sources.js` and changing the action type to a typo like `ADD_SOURCE2`. You'll see that even the action objects are fully type-checked; they need to conform to a specific action type specified in `actions/types.js`.\r\n","created_at":"2016-07-13T19:03:13Z","updated_at":"2016-07-13T19:36:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1afe49f8d125040ca4db7927568aae73663b15ba","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jlongster/debugger.html/pulls/325/commits","review_comments_url":"https://api.github.com/repos/jlongster/debugger.html/pulls/325/comments","review_comment_url":"https://api.github.com/repos/jlongster/debugger.html/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jlongster/debugger.html/issues/325/comments","statuses_url":"https://api.github.com/repos/jlongster/debugger.html/statuses/269192373febaefb50c325cea6aede8e81ad2dd5","head":{"label":"jlongster:flow","ref":"flow","sha":"269192373febaefb50c325cea6aede8e81ad2dd5","user":{"login":"jlongster","id":17031,"avatar_url":"https://avatars.githubusercontent.com/u/17031?v=3","gravatar_id":"","url":"https://api.github.com/users/jlongster","html_url":"https://github.com/jlongster","followers_url":"https://api.github.com/users/jlongster/followers","following_url":"https://api.github.com/users/jlongster/following{/other_user}","gists_url":"https://api.github.com/users/jlongster/gists{/gist_id}","starred_url":"https://api.github.com/users/jlongster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlongster/subscriptions","organizations_url":"https://api.github.com/users/jlongster/orgs","repos_url":"https://api.github.com/users/jlongster/repos","events_url":"https://api.github.com/users/jlongster/events{/privacy}","received_events_url":"https://api.github.com/users/jlongster/received_events","type":"User","site_admin":false},"repo":{"id":54585418,"name":"debugger.html","full_name":"jlongster/debugger.html","owner":{"login":"jlongster","id":17031,"avatar_url":"https://avatars.githubusercontent.com/u/17031?v=3","gravatar_id":"","url":"https://api.github.com/users/jlongster","html_url":"https://github.com/jlongster","followers_url":"https://api.github.com/users/jlongster/followers","following_url":"https://api.github.com/users/jlongster/following{/other_user}","gists_url":"https://api.github.com/users/jlongster/gists{/gist_id}","starred_url":"https://api.github.com/users/jlongster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlongster/subscriptions","organizations_url":"https://api.github.com/users/jlongster/orgs","repos_url":"https://api.github.com/users/jlongster/repos","events_url":"https://api.github.com/users/jlongster/events{/privacy}","received_events_url":"https://api.github.com/users/jlongster/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jlongster/debugger.html","description":"An experimental debugger interface.","fork":false,"url":"https://api.github.com/repos/jlongster/debugger.html","forks_url":"https://api.github.com/repos/jlongster/debugger.html/forks","keys_url":"https://api.github.com/repos/jlongster/debugger.html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jlongster/debugger.html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jlongster/debugger.html/teams","hooks_url":"https://api.github.com/repos/jlongster/debugger.html/hooks","issue_events_url":"https://api.github.com/repos/jlongster/debugger.html/issues/events{/number}","events_url":"https://api.github.com/repos/jlongster/debugger.html/events","assignees_url":"https://api.github.com/repos/jlongster/debugger.html/assignees{/user}","branches_url":"https://api.github.com/repos/jlongster/debugger.html/branches{/branch}","tags_url":"https://api.github.com/repos/jlongster/debugger.html/tags","blobs_url":"https://api.github.com/repos/jlongster/debugger.html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jlongster/debugger.html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jlongster/debugger.html/git/refs{/sha}","trees_url":"https://api.github.com/repos/jlongster/debugger.html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jlongster/debugger.html/statuses/{sha}","languages_url":"https://api.github.com/repos/jlongster/debugger.html/languages","stargazers_url":"https://api.github.com/repos/jlongster/debugger.html/stargazers","contributors_url":"https://api.github.com/repos/jlongster/debugger.html/contributors","subscribers_url":"https://api.github.com/repos/jlongster/debugger.html/subscribers","subscription_url":"https://api.github.com/repos/jlongster/debugger.html/subscription","commits_url":"https://api.github.com/repos/jlongster/debugger.html/commits{/sha}","git_commits_url":"https://api.github.com/repos/jlongster/debugger.html/git/commits{/sha}","comments_url":"https://api.github.com/repos/jlongster/debugger.html/comments{/number}","issue_comment_url":"https://api.github.com/repos/jlongster/debugger.html/issues/comments{/number}","contents_url":"https://api.github.com/repos/jlongster/debugger.html/contents/{+path}","compare_url":"https://api.github.com/repos/jlongster/debugger.html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jlongster/debugger.html/merges","archive_url":"https://api.github.com/repos/jlongster/debugger.html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jlongster/debugger.html/downloads","issues_url":"https://api.github.com/repos/jlongster/debugger.html/issues{/number}","pulls_url":"https://api.github.com/repos/jlongster/debugger.html/pulls{/number}","milestones_url":"https://api.github.com/repos/jlongster/debugger.html/milestones{/number}","notifications_url":"https://api.github.com/repos/jlongster/debugger.html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jlongster/debugger.html/labels{/name}","releases_url":"https://api.github.com/repos/jlongster/debugger.html/releases{/id}","deployments_url":"https://api.github.com/repos/jlongster/debugger.html/deployments","created_at":"2016-03-23T18:55:36Z","updated_at":"2016-07-13T13:45:30Z","pushed_at":"2016-07-13T19:03:14Z","git_url":"git://github.com/jlongster/debugger.html.git","ssh_url":"git@github.com:jlongster/debugger.html.git","clone_url":"https://github.com/jlongster/debugger.html.git","svn_url":"https://github.com/jlongster/debugger.html","homepage":"","size":1927,"stargazers_count":79,"watchers_count":79,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":36,"forks":21,"open_issues":36,"watchers":79,"default_branch":"master"}},"base":{"label":"jlongster:master","ref":"master","sha":"21906c183001006f4e0d89e8354fc5f6a8b0e941","user":{"login":"jlongster","id":17031,"avatar_url":"https://avatars.githubusercontent.com/u/17031?v=3","gravatar_id":"","url":"https://api.github.com/users/jlongster","html_url":"https://github.com/jlongster","followers_url":"https://api.github.com/users/jlongster/followers","following_url":"https://api.github.com/users/jlongster/following{/other_user}","gists_url":"https://api.github.com/users/jlongster/gists{/gist_id}","starred_url":"https://api.github.com/users/jlongster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlongster/subscriptions","organizations_url":"https://api.github.com/users/jlongster/orgs","repos_url":"https://api.github.com/users/jlongster/repos","events_url":"https://api.github.com/users/jlongster/events{/privacy}","received_events_url":"https://api.github.com/users/jlongster/received_events","type":"User","site_admin":false},"repo":{"id":54585418,"name":"debugger.html","full_name":"jlongster/debugger.html","owner":{"login":"jlongster","id":17031,"avatar_url":"https://avatars.githubusercontent.com/u/17031?v=3","gravatar_id":"","url":"https://api.github.com/users/jlongster","html_url":"https://github.com/jlongster","followers_url":"https://api.github.com/users/jlongster/followers","following_url":"https://api.github.com/users/jlongster/following{/other_user}","gists_url":"https://api.github.com/users/jlongster/gists{/gist_id}","starred_url":"https://api.github.com/users/jlongster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlongster/subscriptions","organizations_url":"https://api.github.com/users/jlongster/orgs","repos_url":"https://api.github.com/users/jlongster/repos","events_url":"https://api.github.com/users/jlongster/events{/privacy}","received_events_url":"https://api.github.com/users/jlongster/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jlongster/debugger.html","description":"An experimental debugger interface.","fork":false,"url":"https://api.github.com/repos/jlongster/debugger.html","forks_url":"https://api.github.com/repos/jlongster/debugger.html/forks","keys_url":"https://api.github.com/repos/jlongster/debugger.html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jlongster/debugger.html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jlongster/debugger.html/teams","hooks_url":"https://api.github.com/repos/jlongster/debugger.html/hooks","issue_events_url":"https://api.github.com/repos/jlongster/debugger.html/issues/events{/number}","events_url":"https://api.github.com/repos/jlongster/debugger.html/events","assignees_url":"https://api.github.com/repos/jlongster/debugger.html/assignees{/user}","branches_url":"https://api.github.com/repos/jlongster/debugger.html/branches{/branch}","tags_url":"https://api.github.com/repos/jlongster/debugger.html/tags","blobs_url":"https://api.github.com/repos/jlongster/debugger.html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jlongster/debugger.html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jlongster/debugger.html/git/refs{/sha}","trees_url":"https://api.github.com/repos/jlongster/debugger.html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jlongster/debugger.html/statuses/{sha}","languages_url":"https://api.github.com/repos/jlongster/debugger.html/languages","stargazers_url":"https://api.github.com/repos/jlongster/debugger.html/stargazers","contributors_url":"https://api.github.com/repos/jlongster/debugger.html/contributors","subscribers_url":"https://api.github.com/repos/jlongster/debugger.html/subscribers","subscription_url":"https://api.github.com/repos/jlongster/debugger.html/subscription","commits_url":"https://api.github.com/repos/jlongster/debugger.html/commits{/sha}","git_commits_url":"https://api.github.com/repos/jlongster/debugger.html/git/commits{/sha}","comments_url":"https://api.github.com/repos/jlongster/debugger.html/comments{/number}","issue_comment_url":"https://api.github.com/repos/jlongster/debugger.html/issues/comments{/number}","contents_url":"https://api.github.com/repos/jlongster/debugger.html/contents/{+path}","compare_url":"https://api.github.com/repos/jlongster/debugger.html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jlongster/debugger.html/merges","archive_url":"https://api.github.com/repos/jlongster/debugger.html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jlongster/debugger.html/downloads","issues_url":"https://api.github.com/repos/jlongster/debugger.html/issues{/number}","pulls_url":"https://api.github.com/repos/jlongster/debugger.html/pulls{/number}","milestones_url":"https://api.github.com/repos/jlongster/debugger.html/milestones{/number}","notifications_url":"https://api.github.com/repos/jlongster/debugger.html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jlongster/debugger.html/labels{/name}","releases_url":"https://api.github.com/repos/jlongster/debugger.html/releases{/id}","deployments_url":"https://api.github.com/repos/jlongster/debugger.html/deployments","created_at":"2016-03-23T18:55:36Z","updated_at":"2016-07-13T13:45:30Z","pushed_at":"2016-07-13T19:03:14Z","git_url":"git://github.com/jlongster/debugger.html.git","ssh_url":"git@github.com:jlongster/debugger.html.git","clone_url":"https://github.com/jlongster/debugger.html.git","svn_url":"https://github.com/jlongster/debugger.html","homepage":"","size":1927,"stargazers_count":79,"watchers_count":79,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":36,"forks":21,"open_issues":36,"watchers":79,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jlongster/debugger.html/pulls/325"},"html":{"href":"https://github.com/jlongster/debugger.html/pull/325"},"issue":{"href":"https://api.github.com/repos/jlongster/debugger.html/issues/325"},"comments":{"href":"https://api.github.com/repos/jlongster/debugger.html/issues/325/comments"},"review_comments":{"href":"https://api.github.com/repos/jlongster/debugger.html/pulls/325/comments"},"review_comment":{"href":"https://api.github.com/repos/jlongster/debugger.html/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jlongster/debugger.html/pulls/325/commits"},"statuses":{"href":"https://api.github.com/repos/jlongster/debugger.html/statuses/269192373febaefb50c325cea6aede8e81ad2dd5"}}}}
{"actor":{"display_login":"jasonLaster"}}