{"action":"created","issue":{"url":"https://api.github.com/repos/inikep/lzbench/issues/24","repository_url":"https://api.github.com/repos/inikep/lzbench","labels_url":"https://api.github.com/repos/inikep/lzbench/issues/24/labels{/name}","comments_url":"https://api.github.com/repos/inikep/lzbench/issues/24/comments","events_url":"https://api.github.com/repos/inikep/lzbench/issues/24/events","html_url":"https://github.com/inikep/lzbench/issues/24","id":179311854,"number":24,"title":"Problems with statistics.","user":{"login":"reedacartwright","id":101918,"avatar_url":"https://avatars.githubusercontent.com/u/101918?v=3","gravatar_id":"","url":"https://api.github.com/users/reedacartwright","html_url":"https://github.com/reedacartwright","followers_url":"https://api.github.com/users/reedacartwright/followers","following_url":"https://api.github.com/users/reedacartwright/following{/other_user}","gists_url":"https://api.github.com/users/reedacartwright/gists{/gist_id}","starred_url":"https://api.github.com/users/reedacartwright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reedacartwright/subscriptions","organizations_url":"https://api.github.com/users/reedacartwright/orgs","repos_url":"https://api.github.com/users/reedacartwright/repos","events_url":"https://api.github.com/users/reedacartwright/events{/privacy}","received_events_url":"https://api.github.com/users/reedacartwright/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-26T19:08:20Z","updated_at":"2016-09-28T19:44:07Z","closed_at":null,"body":"In `lzbench_test`, the compression and decompression steps are run 1 or more times until the total time is above a threshold. If the time an iteration takes is above 10000 nanoseconds, then that time is pushed onto a vector.\r\n - https://github.com/inikep/lzbench/blob/master/_lzbench/lzbench.cpp#L315\r\n - https://github.com/inikep/lzbench/blob/master/_lzbench/lzbench.cpp#L348\r\n\r\nAfter that time is done, the average time is also placed onto the vector.\r\n - https://github.com/inikep/lzbench/blob/master/_lzbench/lzbench.cpp#L354\r\n - https://github.com/inikep/lzbench/blob/master/_lzbench/lzbench.cpp#L321\r\n\r\nBecause there are two different types of values on the vector, then the statistics (fastest, average, median) collected on the algorithms are not as accurate as they could be."},"comment":{"url":"https://api.github.com/repos/inikep/lzbench/issues/comments/250278145","html_url":"https://github.com/inikep/lzbench/issues/24#issuecomment-250278145","issue_url":"https://api.github.com/repos/inikep/lzbench/issues/24","id":250278145,"user":{"login":"inikep","id":15112322,"avatar_url":"https://avatars.githubusercontent.com/u/15112322?v=3","gravatar_id":"","url":"https://api.github.com/users/inikep","html_url":"https://github.com/inikep","followers_url":"https://api.github.com/users/inikep/followers","following_url":"https://api.github.com/users/inikep/following{/other_user}","gists_url":"https://api.github.com/users/inikep/gists{/gist_id}","starred_url":"https://api.github.com/users/inikep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inikep/subscriptions","organizations_url":"https://api.github.com/users/inikep/orgs","repos_url":"https://api.github.com/users/inikep/repos","events_url":"https://api.github.com/users/inikep/events{/privacy}","received_events_url":"https://api.github.com/users/inikep/received_events","type":"User","site_admin":false},"created_at":"2016-09-28T19:44:07Z","updated_at":"2016-09-28T19:44:07Z","body":"There is an issue with benchmarking files smaller than 100 KB and with decompressors with speed of 3 GB/s or faster: subsequent measurements may vary considerably. To solve this problem I decided that it is better to have only average value and `if (nanosec >= 10000)` detect this case. For bigger files or slower compressors/decompressors the condition `if (nanosec >= 10000)` is always fulfilled therefore statistics should be as accurate as possible."}}
{"actor":{"display_login":"inikep"}}