{"action":"created","comment":{"url":"https://api.github.com/repos/zalando/nakadi/pulls/comments/58185513","id":58185513,"diff_hunk":"@@ -91,13 +97,23 @@ private void init() {\n     @Scheduled(fixedDelay = 30000)\n     private void updateBrokers() {\n         if (kafkaProperties != null) {\n+            final Properties oldProperties = getKafkaProperties();\n+\n             final List<Broker> brokers = fetchBrokers();\n             if (!brokers.isEmpty()) {","path":"src/main/java/de/zalando/aruha/nakadi/repository/kafka/KafkaLocationManager.java","position":27,"original_position":27,"commit_id":"0b73763c0b9a19109fac0d7c50fc25fbc502ccac","original_commit_id":"0b73763c0b9a19109fac0d7c50fc25fbc502ccac","user":{"login":"tmuehl","id":6663328,"avatar_url":"https://avatars.githubusercontent.com/u/6663328?v=3","gravatar_id":"","url":"https://api.github.com/users/tmuehl","html_url":"https://github.com/tmuehl","followers_url":"https://api.github.com/users/tmuehl/followers","following_url":"https://api.github.com/users/tmuehl/following{/other_user}","gists_url":"https://api.github.com/users/tmuehl/gists{/gist_id}","starred_url":"https://api.github.com/users/tmuehl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmuehl/subscriptions","organizations_url":"https://api.github.com/users/tmuehl/orgs","repos_url":"https://api.github.com/users/tmuehl/repos","events_url":"https://api.github.com/users/tmuehl/events{/privacy}","received_events_url":"https://api.github.com/users/tmuehl/received_events","type":"User","site_admin":false},"body":"Same here, haven't touched that code. :) And I agree with you, if there is no single broker that's a bigger issue not solved by just keeping the old brokers.\r\n\r\nMaybe the idea was that if the list of brokers is empty the reason is that the reading from Zookeeper was faulty. So rather stay with the current list. But I don't know.","created_at":"2016-04-01T09:59:55Z","updated_at":"2016-04-01T09:59:55Z","html_url":"https://github.com/zalando/nakadi/pull/201#discussion_r58185513","pull_request_url":"https://api.github.com/repos/zalando/nakadi/pulls/201","_links":{"self":{"href":"https://api.github.com/repos/zalando/nakadi/pulls/comments/58185513"},"html":{"href":"https://github.com/zalando/nakadi/pull/201#discussion_r58185513"},"pull_request":{"href":"https://api.github.com/repos/zalando/nakadi/pulls/201"}}},"pull_request":{"url":"https://api.github.com/repos/zalando/nakadi/pulls/201","id":64792027,"html_url":"https://github.com/zalando/nakadi/pull/201","diff_url":"https://github.com/zalando/nakadi/pull/201.diff","patch_url":"https://github.com/zalando/nakadi/pull/201.patch","issue_url":"https://api.github.com/repos/zalando/nakadi/issues/201","number":201,"state":"open","locked":false,"title":"ARUHA-157 Update Kafka Broker List for KafkaProducer","user":{"login":"tmuehl","id":6663328,"avatar_url":"https://avatars.githubusercontent.com/u/6663328?v=3","gravatar_id":"","url":"https://api.github.com/users/tmuehl","html_url":"https://github.com/tmuehl","followers_url":"https://api.github.com/users/tmuehl/followers","following_url":"https://api.github.com/users/tmuehl/following{/other_user}","gists_url":"https://api.github.com/users/tmuehl/gists{/gist_id}","starred_url":"https://api.github.com/users/tmuehl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmuehl/subscriptions","organizations_url":"https://api.github.com/users/tmuehl/orgs","repos_url":"https://api.github.com/users/tmuehl/repos","events_url":"https://api.github.com/users/tmuehl/events{/privacy}","received_events_url":"https://api.github.com/users/tmuehl/received_events","type":"User","site_admin":false},"body":"When the Kafka brokers change, create a new producer to take new brokers into account and remove old ones.\r\n\r\nFixes #188 ","created_at":"2016-03-31T13:42:58Z","updated_at":"2016-04-01T09:59:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f93d454609b3bba3e507059c6a0ff020017a3fff","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zalando/nakadi/pulls/201/commits","review_comments_url":"https://api.github.com/repos/zalando/nakadi/pulls/201/comments","review_comment_url":"https://api.github.com/repos/zalando/nakadi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zalando/nakadi/issues/201/comments","statuses_url":"https://api.github.com/repos/zalando/nakadi/statuses/0b73763c0b9a19109fac0d7c50fc25fbc502ccac","head":{"label":"zalando:ARUHA-157-recognise-new-kafka-brokers","ref":"ARUHA-157-recognise-new-kafka-brokers","sha":"0b73763c0b9a19109fac0d7c50fc25fbc502ccac","user":{"login":"zalando","id":1564818,"avatar_url":"https://avatars.githubusercontent.com/u/1564818?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando","html_url":"https://github.com/zalando","followers_url":"https://api.github.com/users/zalando/followers","following_url":"https://api.github.com/users/zalando/following{/other_user}","gists_url":"https://api.github.com/users/zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando/subscriptions","organizations_url":"https://api.github.com/users/zalando/orgs","repos_url":"https://api.github.com/users/zalando/repos","events_url":"https://api.github.com/users/zalando/events{/privacy}","received_events_url":"https://api.github.com/users/zalando/received_events","type":"Organization","site_admin":false},"repo":{"id":44234368,"name":"nakadi","full_name":"zalando/nakadi","owner":{"login":"zalando","id":1564818,"avatar_url":"https://avatars.githubusercontent.com/u/1564818?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando","html_url":"https://github.com/zalando","followers_url":"https://api.github.com/users/zalando/followers","following_url":"https://api.github.com/users/zalando/following{/other_user}","gists_url":"https://api.github.com/users/zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando/subscriptions","organizations_url":"https://api.github.com/users/zalando/orgs","repos_url":"https://api.github.com/users/zalando/repos","events_url":"https://api.github.com/users/zalando/events{/privacy}","received_events_url":"https://api.github.com/users/zalando/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zalando/nakadi","description":"A distributed event bus that implements a RESTful API abstraction instead of Kafka-like queues","fork":false,"url":"https://api.github.com/repos/zalando/nakadi","forks_url":"https://api.github.com/repos/zalando/nakadi/forks","keys_url":"https://api.github.com/repos/zalando/nakadi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando/nakadi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando/nakadi/teams","hooks_url":"https://api.github.com/repos/zalando/nakadi/hooks","issue_events_url":"https://api.github.com/repos/zalando/nakadi/issues/events{/number}","events_url":"https://api.github.com/repos/zalando/nakadi/events","assignees_url":"https://api.github.com/repos/zalando/nakadi/assignees{/user}","branches_url":"https://api.github.com/repos/zalando/nakadi/branches{/branch}","tags_url":"https://api.github.com/repos/zalando/nakadi/tags","blobs_url":"https://api.github.com/repos/zalando/nakadi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando/nakadi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando/nakadi/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando/nakadi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando/nakadi/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando/nakadi/languages","stargazers_url":"https://api.github.com/repos/zalando/nakadi/stargazers","contributors_url":"https://api.github.com/repos/zalando/nakadi/contributors","subscribers_url":"https://api.github.com/repos/zalando/nakadi/subscribers","subscription_url":"https://api.github.com/repos/zalando/nakadi/subscription","commits_url":"https://api.github.com/repos/zalando/nakadi/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando/nakadi/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando/nakadi/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando/nakadi/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando/nakadi/contents/{+path}","compare_url":"https://api.github.com/repos/zalando/nakadi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando/nakadi/merges","archive_url":"https://api.github.com/repos/zalando/nakadi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando/nakadi/downloads","issues_url":"https://api.github.com/repos/zalando/nakadi/issues{/number}","pulls_url":"https://api.github.com/repos/zalando/nakadi/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando/nakadi/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando/nakadi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando/nakadi/labels{/name}","releases_url":"https://api.github.com/repos/zalando/nakadi/releases{/id}","deployments_url":"https://api.github.com/repos/zalando/nakadi/deployments","created_at":"2015-10-14T08:30:17Z","updated_at":"2016-03-30T12:23:27Z","pushed_at":"2016-04-01T09:25:25Z","git_url":"git://github.com/zalando/nakadi.git","ssh_url":"git@github.com:zalando/nakadi.git","clone_url":"https://github.com/zalando/nakadi.git","svn_url":"https://github.com/zalando/nakadi","homepage":"","size":2036,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":10,"forks":8,"open_issues":10,"watchers":9,"default_branch":"nakadi-jvm"}},"base":{"label":"zalando:nakadi-jvm","ref":"nakadi-jvm","sha":"6ca16852ac50ad7cc1182e5f085493ae42fc1747","user":{"login":"zalando","id":1564818,"avatar_url":"https://avatars.githubusercontent.com/u/1564818?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando","html_url":"https://github.com/zalando","followers_url":"https://api.github.com/users/zalando/followers","following_url":"https://api.github.com/users/zalando/following{/other_user}","gists_url":"https://api.github.com/users/zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando/subscriptions","organizations_url":"https://api.github.com/users/zalando/orgs","repos_url":"https://api.github.com/users/zalando/repos","events_url":"https://api.github.com/users/zalando/events{/privacy}","received_events_url":"https://api.github.com/users/zalando/received_events","type":"Organization","site_admin":false},"repo":{"id":44234368,"name":"nakadi","full_name":"zalando/nakadi","owner":{"login":"zalando","id":1564818,"avatar_url":"https://avatars.githubusercontent.com/u/1564818?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando","html_url":"https://github.com/zalando","followers_url":"https://api.github.com/users/zalando/followers","following_url":"https://api.github.com/users/zalando/following{/other_user}","gists_url":"https://api.github.com/users/zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando/subscriptions","organizations_url":"https://api.github.com/users/zalando/orgs","repos_url":"https://api.github.com/users/zalando/repos","events_url":"https://api.github.com/users/zalando/events{/privacy}","received_events_url":"https://api.github.com/users/zalando/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zalando/nakadi","description":"A distributed event bus that implements a RESTful API abstraction instead of Kafka-like queues","fork":false,"url":"https://api.github.com/repos/zalando/nakadi","forks_url":"https://api.github.com/repos/zalando/nakadi/forks","keys_url":"https://api.github.com/repos/zalando/nakadi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando/nakadi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando/nakadi/teams","hooks_url":"https://api.github.com/repos/zalando/nakadi/hooks","issue_events_url":"https://api.github.com/repos/zalando/nakadi/issues/events{/number}","events_url":"https://api.github.com/repos/zalando/nakadi/events","assignees_url":"https://api.github.com/repos/zalando/nakadi/assignees{/user}","branches_url":"https://api.github.com/repos/zalando/nakadi/branches{/branch}","tags_url":"https://api.github.com/repos/zalando/nakadi/tags","blobs_url":"https://api.github.com/repos/zalando/nakadi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando/nakadi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando/nakadi/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando/nakadi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando/nakadi/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando/nakadi/languages","stargazers_url":"https://api.github.com/repos/zalando/nakadi/stargazers","contributors_url":"https://api.github.com/repos/zalando/nakadi/contributors","subscribers_url":"https://api.github.com/repos/zalando/nakadi/subscribers","subscription_url":"https://api.github.com/repos/zalando/nakadi/subscription","commits_url":"https://api.github.com/repos/zalando/nakadi/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando/nakadi/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando/nakadi/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando/nakadi/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando/nakadi/contents/{+path}","compare_url":"https://api.github.com/repos/zalando/nakadi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando/nakadi/merges","archive_url":"https://api.github.com/repos/zalando/nakadi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando/nakadi/downloads","issues_url":"https://api.github.com/repos/zalando/nakadi/issues{/number}","pulls_url":"https://api.github.com/repos/zalando/nakadi/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando/nakadi/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando/nakadi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando/nakadi/labels{/name}","releases_url":"https://api.github.com/repos/zalando/nakadi/releases{/id}","deployments_url":"https://api.github.com/repos/zalando/nakadi/deployments","created_at":"2015-10-14T08:30:17Z","updated_at":"2016-03-30T12:23:27Z","pushed_at":"2016-04-01T09:25:25Z","git_url":"git://github.com/zalando/nakadi.git","ssh_url":"git@github.com:zalando/nakadi.git","clone_url":"https://github.com/zalando/nakadi.git","svn_url":"https://github.com/zalando/nakadi","homepage":"","size":2036,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":10,"forks":8,"open_issues":10,"watchers":9,"default_branch":"nakadi-jvm"}},"_links":{"self":{"href":"https://api.github.com/repos/zalando/nakadi/pulls/201"},"html":{"href":"https://github.com/zalando/nakadi/pull/201"},"issue":{"href":"https://api.github.com/repos/zalando/nakadi/issues/201"},"comments":{"href":"https://api.github.com/repos/zalando/nakadi/issues/201/comments"},"review_comments":{"href":"https://api.github.com/repos/zalando/nakadi/pulls/201/comments"},"review_comment":{"href":"https://api.github.com/repos/zalando/nakadi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zalando/nakadi/pulls/201/commits"},"statuses":{"href":"https://api.github.com/repos/zalando/nakadi/statuses/0b73763c0b9a19109fac0d7c50fc25fbc502ccac"}}}}