{"action":"created","comment":{"url":"https://api.github.com/repos/keystonejs/keystone/pulls/comments/59457963","id":59457963,"diff_hunk":"@@ -0,0 +1,75 @@\n+import path from 'path';\n+import webpack from 'webpack';\n+\n+let config = {\n+\tadmin: path.resolve(__dirname, './admin/client/index'),\n+\tentry: {\n+\t\tpackages: [\n+\t\t\t'async',\n+\t\t\t'blacklist',\n+\t\t\t'bytes',\n+\t\t\t'classnames',\n+\t\t\t'color',\n+\t\t\t'display-name',\n+\t\t\t'elemental',\n+\t\t\t'expression-match',\n+\t\t\t'history',\n+\t\t\t'i',\n+\t\t\t'list-to-array',\n+\t\t\t'marked',\n+\t\t\t'moment',\n+\t\t\t'numeral',\n+\t\t\t'qs',\n+\t\t\t'react-addons-css-transition-group',\n+\t\t\t'react-alt-text',\n+\t\t\t'react-color',\n+\t\t\t'react-day-picker',\n+\t\t\t'react-dnd',\n+\t\t\t'react-dnd-html5-backend',\n+\t\t\t'react-dom',\n+\t\t\t'react-select',\n+\t\t\t'react',\n+\t\t\t'store-prototype',\n+\t\t\t'vkey',\n+\t\t\t'xhr'\n+\t\t]\n+\t},\n+\toutput: {\n+\t\tfilename: '[name].js',\n+\t\tpath: path.resolve(__dirname, './admin/public/js')\n+\t},\n+\tmodule: {\n+\t\tloaders: [\n+\t\t\t{ test: /\\.jsx?$/, loader: 'babel', exclude: /node_modules/ }\n+\t\t]\n+\t},\n+\tplugins: [\n+\t\tnew webpack.DefinePlugin({\n+\t\t\tENV: process.env.NODE_ENV\n+\t\t}),\n+\t\tnew webpack.optimize.CommonsChunkPlugin('packages', 'packages.js')\n+\t]\n+}\n+\n+if (process.env.NODE_ENV === 'production') {\n+\tconfig = createProdConfig(config);\n+}\n+\n+function createProdConfig(config) {\n+\tlet plugins = [\n+\t\tnew webpack.optimize.UglifyJsPlugin({\n+\t\t    compress: {\n+\t\t        warnings: false\n+\t\t    },\n+\t\t    mangle: true,\n+\t\t    output: {\n+\t\t    \tcomments: false","path":"webpack.config.babel.js","position":66,"original_position":66,"commit_id":"a0cc1187843124c8eda9da92f778fc25d40ec996","original_commit_id":"a0cc1187843124c8eda9da92f778fc25d40ec996","user":{"login":"wmertens","id":54934,"avatar_url":"https://avatars.githubusercontent.com/u/54934?v=3","gravatar_id":"","url":"https://api.github.com/users/wmertens","html_url":"https://github.com/wmertens","followers_url":"https://api.github.com/users/wmertens/followers","following_url":"https://api.github.com/users/wmertens/following{/other_user}","gists_url":"https://api.github.com/users/wmertens/gists{/gist_id}","starred_url":"https://api.github.com/users/wmertens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmertens/subscriptions","organizations_url":"https://api.github.com/users/wmertens/orgs","repos_url":"https://api.github.com/users/wmertens/repos","events_url":"https://api.github.com/users/wmertens/events{/privacy}","received_events_url":"https://api.github.com/users/wmertens/received_events","type":"User","site_admin":false},"body":"Here's two more options I like:\r\n\r\n    screw_ie8: true,\r\n    semicolons: false\r\n\r\nWithout semicolons you get the same filesize but editors can handle the file much better because the lines are short. And of course, IE8 is not supported by React either.","created_at":"2016-04-12T21:33:06Z","updated_at":"2016-04-12T21:33:06Z","html_url":"https://github.com/keystonejs/keystone/pull/2608#discussion_r59457963","pull_request_url":"https://api.github.com/repos/keystonejs/keystone/pulls/2608","_links":{"self":{"href":"https://api.github.com/repos/keystonejs/keystone/pulls/comments/59457963"},"html":{"href":"https://github.com/keystonejs/keystone/pull/2608#discussion_r59457963"},"pull_request":{"href":"https://api.github.com/repos/keystonejs/keystone/pulls/2608"}}},"pull_request":{"url":"https://api.github.com/repos/keystonejs/keystone/pulls/2608","id":66035249,"html_url":"https://github.com/keystonejs/keystone/pull/2608","diff_url":"https://github.com/keystonejs/keystone/pull/2608.diff","patch_url":"https://github.com/keystonejs/keystone/pull/2608.patch","issue_url":"https://api.github.com/repos/keystonejs/keystone/issues/2608","number":2608,"state":"open","locked":false,"title":"Begin migration to webpack","user":{"login":"cameronroe","id":1614348,"avatar_url":"https://avatars.githubusercontent.com/u/1614348?v=3","gravatar_id":"","url":"https://api.github.com/users/cameronroe","html_url":"https://github.com/cameronroe","followers_url":"https://api.github.com/users/cameronroe/followers","following_url":"https://api.github.com/users/cameronroe/following{/other_user}","gists_url":"https://api.github.com/users/cameronroe/gists{/gist_id}","starred_url":"https://api.github.com/users/cameronroe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cameronroe/subscriptions","organizations_url":"https://api.github.com/users/cameronroe/orgs","repos_url":"https://api.github.com/users/cameronroe/repos","events_url":"https://api.github.com/users/cameronroe/events{/privacy}","received_events_url":"https://api.github.com/users/cameronroe/received_events","type":"User","site_admin":false},"body":"I think it might make sense to start transitioning over to webpack as you begin to introduce more React/Redux code and remove gulp.","created_at":"2016-04-11T17:57:31Z","updated_at":"2016-04-12T21:33:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b8a14cae99595c6e470624dc906012d3dd1b4512","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/keystonejs/keystone/pulls/2608/commits","review_comments_url":"https://api.github.com/repos/keystonejs/keystone/pulls/2608/comments","review_comment_url":"https://api.github.com/repos/keystonejs/keystone/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keystonejs/keystone/issues/2608/comments","statuses_url":"https://api.github.com/repos/keystonejs/keystone/statuses/a0cc1187843124c8eda9da92f778fc25d40ec996","head":{"label":"cameronroe:support/webpack","ref":"support/webpack","sha":"a0cc1187843124c8eda9da92f778fc25d40ec996","user":{"login":"cameronroe","id":1614348,"avatar_url":"https://avatars.githubusercontent.com/u/1614348?v=3","gravatar_id":"","url":"https://api.github.com/users/cameronroe","html_url":"https://github.com/cameronroe","followers_url":"https://api.github.com/users/cameronroe/followers","following_url":"https://api.github.com/users/cameronroe/following{/other_user}","gists_url":"https://api.github.com/users/cameronroe/gists{/gist_id}","starred_url":"https://api.github.com/users/cameronroe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cameronroe/subscriptions","organizations_url":"https://api.github.com/users/cameronroe/orgs","repos_url":"https://api.github.com/users/cameronroe/repos","events_url":"https://api.github.com/users/cameronroe/events{/privacy}","received_events_url":"https://api.github.com/users/cameronroe/received_events","type":"User","site_admin":false},"repo":{"id":55871238,"name":"keystone","full_name":"cameronroe/keystone","owner":{"login":"cameronroe","id":1614348,"avatar_url":"https://avatars.githubusercontent.com/u/1614348?v=3","gravatar_id":"","url":"https://api.github.com/users/cameronroe","html_url":"https://github.com/cameronroe","followers_url":"https://api.github.com/users/cameronroe/followers","following_url":"https://api.github.com/users/cameronroe/following{/other_user}","gists_url":"https://api.github.com/users/cameronroe/gists{/gist_id}","starred_url":"https://api.github.com/users/cameronroe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cameronroe/subscriptions","organizations_url":"https://api.github.com/users/cameronroe/orgs","repos_url":"https://api.github.com/users/cameronroe/repos","events_url":"https://api.github.com/users/cameronroe/events{/privacy}","received_events_url":"https://api.github.com/users/cameronroe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cameronroe/keystone","description":"node.js cms and web app framework","fork":true,"url":"https://api.github.com/repos/cameronroe/keystone","forks_url":"https://api.github.com/repos/cameronroe/keystone/forks","keys_url":"https://api.github.com/repos/cameronroe/keystone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cameronroe/keystone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cameronroe/keystone/teams","hooks_url":"https://api.github.com/repos/cameronroe/keystone/hooks","issue_events_url":"https://api.github.com/repos/cameronroe/keystone/issues/events{/number}","events_url":"https://api.github.com/repos/cameronroe/keystone/events","assignees_url":"https://api.github.com/repos/cameronroe/keystone/assignees{/user}","branches_url":"https://api.github.com/repos/cameronroe/keystone/branches{/branch}","tags_url":"https://api.github.com/repos/cameronroe/keystone/tags","blobs_url":"https://api.github.com/repos/cameronroe/keystone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cameronroe/keystone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cameronroe/keystone/git/refs{/sha}","trees_url":"https://api.github.com/repos/cameronroe/keystone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cameronroe/keystone/statuses/{sha}","languages_url":"https://api.github.com/repos/cameronroe/keystone/languages","stargazers_url":"https://api.github.com/repos/cameronroe/keystone/stargazers","contributors_url":"https://api.github.com/repos/cameronroe/keystone/contributors","subscribers_url":"https://api.github.com/repos/cameronroe/keystone/subscribers","subscription_url":"https://api.github.com/repos/cameronroe/keystone/subscription","commits_url":"https://api.github.com/repos/cameronroe/keystone/commits{/sha}","git_commits_url":"https://api.github.com/repos/cameronroe/keystone/git/commits{/sha}","comments_url":"https://api.github.com/repos/cameronroe/keystone/comments{/number}","issue_comment_url":"https://api.github.com/repos/cameronroe/keystone/issues/comments{/number}","contents_url":"https://api.github.com/repos/cameronroe/keystone/contents/{+path}","compare_url":"https://api.github.com/repos/cameronroe/keystone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cameronroe/keystone/merges","archive_url":"https://api.github.com/repos/cameronroe/keystone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cameronroe/keystone/downloads","issues_url":"https://api.github.com/repos/cameronroe/keystone/issues{/number}","pulls_url":"https://api.github.com/repos/cameronroe/keystone/pulls{/number}","milestones_url":"https://api.github.com/repos/cameronroe/keystone/milestones{/number}","notifications_url":"https://api.github.com/repos/cameronroe/keystone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cameronroe/keystone/labels{/name}","releases_url":"https://api.github.com/repos/cameronroe/keystone/releases{/id}","deployments_url":"https://api.github.com/repos/cameronroe/keystone/deployments","created_at":"2016-04-09T23:11:31Z","updated_at":"2016-04-09T23:11:35Z","pushed_at":"2016-04-11T17:55:19Z","git_url":"git://github.com/cameronroe/keystone.git","ssh_url":"git@github.com:cameronroe/keystone.git","clone_url":"https://github.com/cameronroe/keystone.git","svn_url":"https://github.com/cameronroe/keystone","homepage":"http://www.keystonejs.com","size":75556,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"keystonejs:master","ref":"master","sha":"fc697250194c6b17be530d5221c990ff9f6a5684","user":{"login":"keystonejs","id":6118534,"avatar_url":"https://avatars.githubusercontent.com/u/6118534?v=3","gravatar_id":"","url":"https://api.github.com/users/keystonejs","html_url":"https://github.com/keystonejs","followers_url":"https://api.github.com/users/keystonejs/followers","following_url":"https://api.github.com/users/keystonejs/following{/other_user}","gists_url":"https://api.github.com/users/keystonejs/gists{/gist_id}","starred_url":"https://api.github.com/users/keystonejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keystonejs/subscriptions","organizations_url":"https://api.github.com/users/keystonejs/orgs","repos_url":"https://api.github.com/users/keystonejs/repos","events_url":"https://api.github.com/users/keystonejs/events{/privacy}","received_events_url":"https://api.github.com/users/keystonejs/received_events","type":"Organization","site_admin":false},"repo":{"id":11116372,"name":"keystone","full_name":"keystonejs/keystone","owner":{"login":"keystonejs","id":6118534,"avatar_url":"https://avatars.githubusercontent.com/u/6118534?v=3","gravatar_id":"","url":"https://api.github.com/users/keystonejs","html_url":"https://github.com/keystonejs","followers_url":"https://api.github.com/users/keystonejs/followers","following_url":"https://api.github.com/users/keystonejs/following{/other_user}","gists_url":"https://api.github.com/users/keystonejs/gists{/gist_id}","starred_url":"https://api.github.com/users/keystonejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keystonejs/subscriptions","organizations_url":"https://api.github.com/users/keystonejs/orgs","repos_url":"https://api.github.com/users/keystonejs/repos","events_url":"https://api.github.com/users/keystonejs/events{/privacy}","received_events_url":"https://api.github.com/users/keystonejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keystonejs/keystone","description":"node.js cms and web app framework","fork":false,"url":"https://api.github.com/repos/keystonejs/keystone","forks_url":"https://api.github.com/repos/keystonejs/keystone/forks","keys_url":"https://api.github.com/repos/keystonejs/keystone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keystonejs/keystone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keystonejs/keystone/teams","hooks_url":"https://api.github.com/repos/keystonejs/keystone/hooks","issue_events_url":"https://api.github.com/repos/keystonejs/keystone/issues/events{/number}","events_url":"https://api.github.com/repos/keystonejs/keystone/events","assignees_url":"https://api.github.com/repos/keystonejs/keystone/assignees{/user}","branches_url":"https://api.github.com/repos/keystonejs/keystone/branches{/branch}","tags_url":"https://api.github.com/repos/keystonejs/keystone/tags","blobs_url":"https://api.github.com/repos/keystonejs/keystone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keystonejs/keystone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keystonejs/keystone/git/refs{/sha}","trees_url":"https://api.github.com/repos/keystonejs/keystone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keystonejs/keystone/statuses/{sha}","languages_url":"https://api.github.com/repos/keystonejs/keystone/languages","stargazers_url":"https://api.github.com/repos/keystonejs/keystone/stargazers","contributors_url":"https://api.github.com/repos/keystonejs/keystone/contributors","subscribers_url":"https://api.github.com/repos/keystonejs/keystone/subscribers","subscription_url":"https://api.github.com/repos/keystonejs/keystone/subscription","commits_url":"https://api.github.com/repos/keystonejs/keystone/commits{/sha}","git_commits_url":"https://api.github.com/repos/keystonejs/keystone/git/commits{/sha}","comments_url":"https://api.github.com/repos/keystonejs/keystone/comments{/number}","issue_comment_url":"https://api.github.com/repos/keystonejs/keystone/issues/comments{/number}","contents_url":"https://api.github.com/repos/keystonejs/keystone/contents/{+path}","compare_url":"https://api.github.com/repos/keystonejs/keystone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keystonejs/keystone/merges","archive_url":"https://api.github.com/repos/keystonejs/keystone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keystonejs/keystone/downloads","issues_url":"https://api.github.com/repos/keystonejs/keystone/issues{/number}","pulls_url":"https://api.github.com/repos/keystonejs/keystone/pulls{/number}","milestones_url":"https://api.github.com/repos/keystonejs/keystone/milestones{/number}","notifications_url":"https://api.github.com/repos/keystonejs/keystone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keystonejs/keystone/labels{/name}","releases_url":"https://api.github.com/repos/keystonejs/keystone/releases{/id}","deployments_url":"https://api.github.com/repos/keystonejs/keystone/deployments","created_at":"2013-07-02T05:01:55Z","updated_at":"2016-04-12T21:28:10Z","pushed_at":"2016-04-12T21:07:48Z","git_url":"git://github.com/keystonejs/keystone.git","ssh_url":"git@github.com:keystonejs/keystone.git","clone_url":"https://github.com/keystonejs/keystone.git","svn_url":"https://github.com/keystonejs/keystone","homepage":"http://www.keystonejs.com","size":82721,"stargazers_count":6100,"watchers_count":6100,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1013,"mirror_url":null,"open_issues_count":563,"forks":1013,"open_issues":563,"watchers":6100,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/keystonejs/keystone/pulls/2608"},"html":{"href":"https://github.com/keystonejs/keystone/pull/2608"},"issue":{"href":"https://api.github.com/repos/keystonejs/keystone/issues/2608"},"comments":{"href":"https://api.github.com/repos/keystonejs/keystone/issues/2608/comments"},"review_comments":{"href":"https://api.github.com/repos/keystonejs/keystone/pulls/2608/comments"},"review_comment":{"href":"https://api.github.com/repos/keystonejs/keystone/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keystonejs/keystone/pulls/2608/commits"},"statuses":{"href":"https://api.github.com/repos/keystonejs/keystone/statuses/a0cc1187843124c8eda9da92f778fc25d40ec996"}}}}