{"action":"created","issue":{"url":"https://api.github.com/repos/jackhumbert/qmk_firmware/issues/492","repository_url":"https://api.github.com/repos/jackhumbert/qmk_firmware","labels_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/issues/492/labels{/name}","comments_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/issues/492/comments","events_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/issues/492/events","html_url":"https://github.com/jackhumbert/qmk_firmware/issues/492","id":164426692,"number":492,"title":"Make RGB controls proper keys","user":{"login":"TerryMathews","id":1971461,"avatar_url":"https://avatars.githubusercontent.com/u/1971461?v=3","gravatar_id":"","url":"https://api.github.com/users/TerryMathews","html_url":"https://github.com/TerryMathews","followers_url":"https://api.github.com/users/TerryMathews/followers","following_url":"https://api.github.com/users/TerryMathews/following{/other_user}","gists_url":"https://api.github.com/users/TerryMathews/gists{/gist_id}","starred_url":"https://api.github.com/users/TerryMathews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TerryMathews/subscriptions","organizations_url":"https://api.github.com/users/TerryMathews/orgs","repos_url":"https://api.github.com/users/TerryMathews/repos","events_url":"https://api.github.com/users/TerryMathews/events{/privacy}","received_events_url":"https://api.github.com/users/TerryMathews/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-07T23:05:29Z","updated_at":"2016-07-07T23:09:56Z","closed_at":null,"body":"The RGB code is currently being handled as a macro, where the macro pushes the action out. This is in contrast to the backlight code which has dedicated keycodes and doesn't have to go through the pretense of defining macros.\r\n\r\nIt appears that making the RGB controls into proper keystrokes would only require changes in quantum\\keymap.c and keymap.h. I think I can tackle those changes, but before I do I wanted to check and see if you were adverse to fixing that for some reason, perhaps an issue I'm not aware of."},"comment":{"url":"https://api.github.com/repos/jackhumbert/qmk_firmware/issues/comments/231234172","html_url":"https://github.com/jackhumbert/qmk_firmware/issues/492#issuecomment-231234172","issue_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/issues/492","id":231234172,"user":{"login":"jackhumbert","id":141431,"avatar_url":"https://avatars.githubusercontent.com/u/141431?v=3","gravatar_id":"","url":"https://api.github.com/users/jackhumbert","html_url":"https://github.com/jackhumbert","followers_url":"https://api.github.com/users/jackhumbert/followers","following_url":"https://api.github.com/users/jackhumbert/following{/other_user}","gists_url":"https://api.github.com/users/jackhumbert/gists{/gist_id}","starred_url":"https://api.github.com/users/jackhumbert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackhumbert/subscriptions","organizations_url":"https://api.github.com/users/jackhumbert/orgs","repos_url":"https://api.github.com/users/jackhumbert/repos","events_url":"https://api.github.com/users/jackhumbert/events{/privacy}","received_events_url":"https://api.github.com/users/jackhumbert/received_events","type":"User","site_admin":false},"created_at":"2016-07-07T23:09:56Z","updated_at":"2016-07-07T23:09:56Z","body":"Yeap! That's all that needs to be changed. It should be `quantum/quantum.c` and `quantum/keymap.h` though. The prefix `RGB_` should be a good one to use. If you can think of 3 character codes (`RGB_XXX`) that should work well with what we have already. "}}
{"actor":{"display_login":"jackhumbert"}}