{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rust/issues/35054","repository_url":"https://api.github.com/repos/rust-lang/rust","labels_url":"https://api.github.com/repos/rust-lang/rust/issues/35054/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/35054/comments","events_url":"https://api.github.com/repos/rust-lang/rust/issues/35054/events","html_url":"https://github.com/rust-lang/rust/pull/35054","id":167715129,"number":35054,"title":"implement `From<Vec<char>>` and `From<&'a [char]>` for `String`","user":{"login":"pwoolcoc","id":620392,"avatar_url":"https://avatars.githubusercontent.com/u/620392?v=3","gravatar_id":"","url":"https://api.github.com/users/pwoolcoc","html_url":"https://github.com/pwoolcoc","followers_url":"https://api.github.com/users/pwoolcoc/followers","following_url":"https://api.github.com/users/pwoolcoc/following{/other_user}","gists_url":"https://api.github.com/users/pwoolcoc/gists{/gist_id}","starred_url":"https://api.github.com/users/pwoolcoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwoolcoc/subscriptions","organizations_url":"https://api.github.com/users/pwoolcoc/orgs","repos_url":"https://api.github.com/users/pwoolcoc/repos","events_url":"https://api.github.com/users/pwoolcoc/events{/privacy}","received_events_url":"https://api.github.com/users/pwoolcoc/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/rust-lang/rust/labels/I-nominated","name":"I-nominated","color":"e10c02"},{"url":"https://api.github.com/repos/rust-lang/rust/labels/T-libs","name":"T-libs","color":"bfd4f2"}],"state":"open","locked":false,"assignee":{"login":"brson","id":147214,"avatar_url":"https://avatars.githubusercontent.com/u/147214?v=3","gravatar_id":"","url":"https://api.github.com/users/brson","html_url":"https://github.com/brson","followers_url":"https://api.github.com/users/brson/followers","following_url":"https://api.github.com/users/brson/following{/other_user}","gists_url":"https://api.github.com/users/brson/gists{/gist_id}","starred_url":"https://api.github.com/users/brson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brson/subscriptions","organizations_url":"https://api.github.com/users/brson/orgs","repos_url":"https://api.github.com/users/brson/repos","events_url":"https://api.github.com/users/brson/events{/privacy}","received_events_url":"https://api.github.com/users/brson/received_events","type":"User","site_admin":false},"assignees":[{"login":"brson","id":147214,"avatar_url":"https://avatars.githubusercontent.com/u/147214?v=3","gravatar_id":"","url":"https://api.github.com/users/brson","html_url":"https://github.com/brson","followers_url":"https://api.github.com/users/brson/followers","following_url":"https://api.github.com/users/brson/following{/other_user}","gists_url":"https://api.github.com/users/brson/gists{/gist_id}","starred_url":"https://api.github.com/users/brson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brson/subscriptions","organizations_url":"https://api.github.com/users/brson/orgs","repos_url":"https://api.github.com/users/brson/repos","events_url":"https://api.github.com/users/brson/events{/privacy}","received_events_url":"https://api.github.com/users/brson/received_events","type":"User","site_admin":false}],"milestone":null,"comments":15,"created_at":"2016-07-26T21:21:41Z","updated_at":"2016-07-27T17:06:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/35054","html_url":"https://github.com/rust-lang/rust/pull/35054","diff_url":"https://github.com/rust-lang/rust/pull/35054.diff","patch_url":"https://github.com/rust-lang/rust/pull/35054.patch"},"body":"Though there are ways to convert a slice or vec of chars into a string,\r\nit would be nice to be able to just do `String::from(&['a', 'b', 'c'])`,\r\nso this PR implements `From<Vec<char>>` and `From<&'a [char]>` for\r\nString."},"comment":{"url":"https://api.github.com/repos/rust-lang/rust/issues/comments/235652392","html_url":"https://github.com/rust-lang/rust/pull/35054#issuecomment-235652392","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/35054","id":235652392,"user":{"login":"nagisa","id":679122,"avatar_url":"https://avatars.githubusercontent.com/u/679122?v=3","gravatar_id":"","url":"https://api.github.com/users/nagisa","html_url":"https://github.com/nagisa","followers_url":"https://api.github.com/users/nagisa/followers","following_url":"https://api.github.com/users/nagisa/following{/other_user}","gists_url":"https://api.github.com/users/nagisa/gists{/gist_id}","starred_url":"https://api.github.com/users/nagisa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nagisa/subscriptions","organizations_url":"https://api.github.com/users/nagisa/orgs","repos_url":"https://api.github.com/users/nagisa/repos","events_url":"https://api.github.com/users/nagisa/events{/privacy}","received_events_url":"https://api.github.com/users/nagisa/received_events","type":"User","site_admin":false},"created_at":"2016-07-27T17:06:20Z","updated_at":"2016-07-27T17:06:20Z","body":"> but for now it doesn't seem worth the unsafe complexity when no one's clamboring for it.\r\n\r\nSeems to go at odds with the philosophy of `From` conversions being cheap to me. \r\n\r\nI’d like to point out that I implemented the code I pasted above manually two or three times already in various locations and so far the desire to reuse the allocation was pretty strong in each use-case. The implementation as proposed by the PR is plain useless as far as I’m and my code are concerned, which is exactly why I am complaining.\r\n\r\nShall I send a PR against this PR?"}}
{"actor":{"display_login":"nagisa"}}