{"action":"created","issue":{"url":"https://api.github.com/repos/esnacc/esnacc-ng/issues/35","repository_url":"https://api.github.com/repos/esnacc/esnacc-ng","labels_url":"https://api.github.com/repos/esnacc/esnacc-ng/issues/35/labels{/name}","comments_url":"https://api.github.com/repos/esnacc/esnacc-ng/issues/35/comments","events_url":"https://api.github.com/repos/esnacc/esnacc-ng/issues/35/events","html_url":"https://github.com/esnacc/esnacc-ng/issues/35","id":167892414,"number":35,"title":"\"make check\" fails on Mac OS X","user":{"login":"mouse07410","id":5923577,"avatar_url":"https://avatars.githubusercontent.com/u/5923577?v=3","gravatar_id":"","url":"https://api.github.com/users/mouse07410","html_url":"https://github.com/mouse07410","followers_url":"https://api.github.com/users/mouse07410/followers","following_url":"https://api.github.com/users/mouse07410/following{/other_user}","gists_url":"https://api.github.com/users/mouse07410/gists{/gist_id}","starred_url":"https://api.github.com/users/mouse07410/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mouse07410/subscriptions","organizations_url":"https://api.github.com/users/mouse07410/orgs","repos_url":"https://api.github.com/users/mouse07410/repos","events_url":"https://api.github.com/users/mouse07410/events{/privacy}","received_events_url":"https://api.github.com/users/mouse07410/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-07-27T16:04:38Z","updated_at":"2016-07-29T18:45:16Z","closed_at":null,"body":"Mac OS X 10.11.6, Xcode-7.3.1, Macports-installed autotools (current).\r\n\r\n```\r\n$ make check\r\n/Applications/Xcode.app/Contents/Developer/usr/bin/make  check-am\r\n/Applications/Xcode.app/Contents/Developer/usr/bin/make  c-examples/simple/genber c-examples/simple/minbuf c-examples/simple/expbuf c-examples/simple/sbuf c-examples/test-lib/testlib cxx-examples/main  \\\r\n\t  \r\nmake[2]: `c-examples/simple/genber' is up to date.\r\nmake[2]: `c-examples/simple/minbuf' is up to date.\r\nmake[2]: `c-examples/simple/expbuf' is up to date.\r\nmake[2]: `c-examples/simple/sbuf' is up to date.\r\nmake[2]: `c-examples/test-lib/testlib' is up to date.\r\nclang++ -DHAVE_CONFIG_H -I.    -I./cxx-lib/inc -I./cxx-examples/src -Qunused-arguments -pthread -maes -mpclmul -mrdrnd -msse2 -mssse3 -msse4.1 -msse4.2 -std=c++11 -Os -Ofast -Wall -Wextra -MT cxx-examples/src/cxx_examples_main-automatic.o -MD -MP -MF cxx-examples/src/.deps/cxx_examples_main-automatic.Tpo -c -o cxx-examples/src/cxx_examples_main-automatic.o `test -f 'cxx-examples/src/automatic.cpp' || echo './'`cxx-examples/src/automatic.cpp\r\nIn file included from cxx-examples/src/automatic.cpp:1:\r\nIn file included from ./cxx-examples/src/autotags.h:12:\r\n./cxx-lib/inc/asn-listset.h:53:29: warning: unused parameter 'size' [-Wunused-parameter]\r\n        virtual void Allocate(long size)                                                {}\r\n                                   ^\r\n./cxx-lib/inc/asn-listset.h:69:15: warning: unused parameter 'offset' [-Wunused-parameter]\r\n                                                   long offset)\r\n                                                        ^\r\ncxx-examples/src/automatic.cpp:31:24: error: constant expression evaluates to 128 which cannot be narrowed to type\r\n      'char' [-Wc++11-narrowing]\r\n            {0x30,0x0B,0x80,0x04,0x41,0x64,0x61,0x6D,0xA2,0x03,0x81,0x01,0x5A,},\r\n                       ^~~~\r\ncxx-examples/src/automatic.cpp:31:24: note: insert an explicit cast to silence this issue\r\n            {0x30,0x0B,0x80,0x04,0x41,0x64,0x61,0x6D,0xA2,0x03,0x81,0x01,0x5A,},\r\n                       ^~~~\r\n                       static_cast<char>( )\r\ncxx-examples/src/automatic.cpp:31:54: error: constant expression evaluates to 162 which cannot be narrowed to type\r\n      'char' [-Wc++11-narrowing]\r\n            {0x30,0x0B,0x80,0x04,0x41,0x64,0x61,0x6D,0xA2,0x03,0x81,0x01,0x5A,},\r\n                                                     ^~~~\r\ncxx-examples/src/automatic.cpp:31:54: note: insert an explicit cast to silence this issue\r\n            {0x30,0x0B,0x80,0x04,0x41,0x64,0x61,0x6D,0xA2,0x03,0x81,0x01,0x5A,},\r\n                                                     ^~~~\r\n                                                     static_cast<char>( )\r\ncxx-examples/src/automatic.cpp:31:64: error: constant expression evaluates to 129 which cannot be narrowed to type\r\n      'char' [-Wc++11-narrowing]\r\n            {0x30,0x0B,0x80,0x04,0x41,0x64,0x61,0x6D,0xA2,0x03,0x81,0x01,0x5A,},\r\n                                                               ^~~~\r\ncxx-examples/src/automatic.cpp:31:64: note: insert an explicit cast to silence this issue\r\n            {0x30,0x0B,0x80,0x04,0x41,0x64,0x61,0x6D,0xA2,0x03,0x81,0x01,0x5A,},\r\n                                                               ^~~~\r\n                                                               static_cast<char>( )\r\ncxx-examples/src/automatic.cpp:37:24: error: constant expression evaluates to 128 which cannot be narrowed to type\r\n      'char' [-Wc++11-narrowing]\r\n            {0x30,0x0C,0x80,0x04,0x41,0x64,0x61,0x6D,0xA2,0x04,0x80,0x02,0x03,\r\n                       ^~~~\r\ncxx-examples/src/automatic.cpp:37:24: note: insert an explicit cast to silence this issue\r\n            {0x30,0x0C,0x80,0x04,0x41,0x64,0x61,0x6D,0xA2,0x04,0x80,0x02,0x03,\r\n                       ^~~~\r\n                       static_cast<char>( )\r\ncxx-examples/src/automatic.cpp:37:54: error: constant expression evaluates to 162 which cannot be narrowed to type\r\n      'char' [-Wc++11-narrowing]\r\n            {0x30,0x0C,0x80,0x04,0x41,0x64,0x61,0x6D,0xA2,0x04,0x80,0x02,0x03,\r\n                                                     ^~~~\r\ncxx-examples/src/automatic.cpp:37:54: note: insert an explicit cast to silence this issue\r\n            {0x30,0x0C,0x80,0x04,0x41,0x64,0x61,0x6D,0xA2,0x04,0x80,0x02,0x03,\r\n                                                     ^~~~\r\n                                                     static_cast<char>( )\r\ncxx-examples/src/automatic.cpp:37:64: error: constant expression evaluates to 128 which cannot be narrowed to type\r\n      'char' [-Wc++11-narrowing]\r\n            {0x30,0x0C,0x80,0x04,0x41,0x64,0x61,0x6D,0xA2,0x04,0x80,0x02,0x03,\r\n                                                               ^~~~\r\ncxx-examples/src/automatic.cpp:37:64: note: insert an explicit cast to silence this issue\r\n            {0x30,0x0C,0x80,0x04,0x41,0x64,0x61,0x6D,0xA2,0x04,0x80,0x02,0x03,\r\n                                                               ^~~~\r\n                                                               static_cast<char>( )\r\ncxx-examples/src/automatic.cpp:38:14: error: constant expression evaluates to 132 which cannot be narrowed to type\r\n      'char' [-Wc++11-narrowing]\r\n             0x84,},\r\n             ^~~~\r\ncxx-examples/src/automatic.cpp:38:14: note: insert an explicit cast to silence this issue\r\n             0x84,},\r\n             ^~~~\r\n             static_cast<char>( )\r\ncxx-examples/src/automatic.cpp:44:24: error: constant expression evaluates to 128 which cannot be narrowed to type\r\n      'char' [-Wc++11-narrowing]\r\n            {0x30,0x1A,0x80,0x04,0x41,0x64,0x61,0x6D,0x81,0x0D,0x67,0x6F,0x6F,\r\n                       ^~~~\r\ncxx-examples/src/automatic.cpp:44:24: note: insert an explicit cast to silence this issue\r\n            {0x30,0x1A,0x80,0x04,0x41,0x64,0x61,0x6D,0x81,0x0D,0x67,0x6F,0x6F,\r\n                       ^~~~\r\n                       static_cast<char>( )\r\ncxx-examples/src/automatic.cpp:44:54: error: constant expression evaluates to 129 which cannot be narrowed to type\r\n      'char' [-Wc++11-narrowing]\r\n            {0x30,0x1A,0x80,0x04,0x41,0x64,0x61,0x6D,0x81,0x0D,0x67,0x6F,0x6F,\r\n                                                     ^~~~\r\ncxx-examples/src/automatic.cpp:44:54: note: insert an explicit cast to silence this issue\r\n            {0x30,0x1A,0x80,0x04,0x41,0x64,0x61,0x6D,0x81,0x0D,0x67,0x6F,0x6F,\r\n                                                     ^~~~\r\n                                                     static_cast<char>( )\r\ncxx-examples/src/automatic.cpp:45:64: error: constant expression evaluates to 162 which cannot be narrowed to type\r\n      'char' [-Wc++11-narrowing]\r\n             0x20,0x67,0x6F,0x6F,0x20,0x67,0x61,0x20,0x67,0x61,0xA2,0x03,0x81,\r\n                                                               ^~~~\r\ncxx-examples/src/automatic.cpp:45:64: note: insert an explicit cast to silence this issue\r\n             0x20,0x67,0x6F,0x6F,0x20,0x67,0x61,0x20,0x67,0x61,0xA2,0x03,0x81,\r\n                                                               ^~~~\r\n                                                               static_cast<char>( )\r\ncxx-examples/src/automatic.cpp:45:74: error: constant expression evaluates to 129 which cannot be narrowed to type\r\n      'char' [-Wc++11-narrowing]\r\n             0x20,0x67,0x6F,0x6F,0x20,0x67,0x61,0x20,0x67,0x61,0xA2,0x03,0x81,\r\n                                                                         ^~~~\r\ncxx-examples/src/automatic.cpp:45:74: note: insert an explicit cast to silence this issue\r\n             0x20,0x67,0x6F,0x6F,0x20,0x67,0x61,0x20,0x67,0x61,0xA2,0x03,0x81,\r\n                                                                         ^~~~\r\n                                                                         static_cast<char>( )\r\ncxx-examples/src/automatic.cpp:52:24: error: constant expression evaluates to 128 which cannot be narrowed to type\r\n      'char' [-Wc++11-narrowing]\r\n            {0x30,0x1B,0x80,0x04,0x41,0x64,0x61,0x6D,0x81,0x0D,0x67,0x6F,0x6F,\r\n                       ^~~~\r\ncxx-examples/src/automatic.cpp:52:24: note: insert an explicit cast to silence this issue\r\n            {0x30,0x1B,0x80,0x04,0x41,0x64,0x61,0x6D,0x81,0x0D,0x67,0x6F,0x6F,\r\n                       ^~~~\r\n                       static_cast<char>( )\r\ncxx-examples/src/automatic.cpp:52:54: error: constant expression evaluates to 129 which cannot be narrowed to type\r\n      'char' [-Wc++11-narrowing]\r\n            {0x30,0x1B,0x80,0x04,0x41,0x64,0x61,0x6D,0x81,0x0D,0x67,0x6F,0x6F,\r\n                                                     ^~~~\r\ncxx-examples/src/automatic.cpp:52:54: note: insert an explicit cast to silence this issue\r\n            {0x30,0x1B,0x80,0x04,0x41,0x64,0x61,0x6D,0x81,0x0D,0x67,0x6F,0x6F,\r\n                                                     ^~~~\r\n                                                     static_cast<char>( )\r\ncxx-examples/src/automatic.cpp:53:64: error: constant expression evaluates to 162 which cannot be narrowed to type\r\n      'char' [-Wc++11-narrowing]\r\n             0x20,0x67,0x6F,0x6F,0x20,0x67,0x61,0x20,0x67,0x61,0xA2,0x04,0x80,\r\n                                                               ^~~~\r\ncxx-examples/src/automatic.cpp:53:64: note: insert an explicit cast to silence this issue\r\n             0x20,0x67,0x6F,0x6F,0x20,0x67,0x61,0x20,0x67,0x61,0xA2,0x04,0x80,\r\n                                                               ^~~~\r\n                                                               static_cast<char>( )\r\ncxx-examples/src/automatic.cpp:53:74: error: constant expression evaluates to 128 which cannot be narrowed to type\r\n      'char' [-Wc++11-narrowing]\r\n             0x20,0x67,0x6F,0x6F,0x20,0x67,0x61,0x20,0x67,0x61,0xA2,0x04,0x80,\r\n                                                                         ^~~~\r\ncxx-examples/src/automatic.cpp:53:74: note: insert an explicit cast to silence this issue\r\n             0x20,0x67,0x6F,0x6F,0x20,0x67,0x61,0x20,0x67,0x61,0xA2,0x04,0x80,\r\n                                                                         ^~~~\r\n                                                                         static_cast<char>( )\r\ncxx-examples/src/automatic.cpp:54:24: error: constant expression evaluates to 132 which cannot be narrowed to type\r\n      'char' [-Wc++11-narrowing]\r\n             0x02,0x03,0x84,},\r\n                       ^~~~\r\ncxx-examples/src/automatic.cpp:54:24: note: insert an explicit cast to silence this issue\r\n             0x02,0x03,0x84,},\r\n                       ^~~~\r\n                       static_cast<char>( )\r\n2 warnings and 16 errors generated.\r\nmake[2]: *** [cxx-examples/src/cxx_examples_main-automatic.o] Error 1\r\nmake[1]: *** [check-am] Error 2\r\nmake: *** [check] Error 2\r\n$ \r\n```\r\n\r\n[config.log.txt](https://github.com/esnacc/esnacc-ng/files/386515/config.log.txt)\r\n"},"comment":{"url":"https://api.github.com/repos/esnacc/esnacc-ng/issues/comments/236262053","html_url":"https://github.com/esnacc/esnacc-ng/issues/35#issuecomment-236262053","issue_url":"https://api.github.com/repos/esnacc/esnacc-ng/issues/35","id":236262053,"user":{"login":"mouse07410","id":5923577,"avatar_url":"https://avatars.githubusercontent.com/u/5923577?v=3","gravatar_id":"","url":"https://api.github.com/users/mouse07410","html_url":"https://github.com/mouse07410","followers_url":"https://api.github.com/users/mouse07410/followers","following_url":"https://api.github.com/users/mouse07410/following{/other_user}","gists_url":"https://api.github.com/users/mouse07410/gists{/gist_id}","starred_url":"https://api.github.com/users/mouse07410/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mouse07410/subscriptions","organizations_url":"https://api.github.com/users/mouse07410/orgs","repos_url":"https://api.github.com/users/mouse07410/repos","events_url":"https://api.github.com/users/mouse07410/events{/privacy}","received_events_url":"https://api.github.com/users/mouse07410/received_events","type":"User","site_admin":false},"created_at":"2016-07-29T18:45:16Z","updated_at":"2016-07-29T18:45:16Z","body":"> char is an 8-bit type\r\n\r\nStrictly speaking you're correct here - but the code is still wrong: `char` is a signed type, so the range of values it can legally accept is `[-127, 127]`. That means this compiler complaint\r\n```\r\ncxx-examples/src/automatic.cpp:52:54: error: constant expression evaluates to 129 which cannot be narrowed to type\r\n      'char' [-Wc++11-narrowing]\r\n            {0x30,0x1B,0x80,0x04,0x41,0x64,0x61,0x6D,0x81,0x0D,0x67,0x6F,0x6F,\r\n                                                     ^~~~\r\ncxx-examples/src/automatic.cpp:52:54: note: insert an explicit cast to silence this issue\r\n            {0x30,0x1B,0x80,0x04,0x41,0x64,0x61,0x6D,0x81,0x0D,0x67,0x6F,0x6F,\r\n                                                     ^~~~\r\n                                                     static_cast<char>( )\r\n```\r\nis legitimate.\r\n\r\n> I need time to consider the solution, \r\n\r\nI think the best solution is to change `char` to `unsigned char`. However I'd like to think about it a bit.\r\n\r\n> but just had a birth so I don't trust my judgement at the moment. I'll get back to this in a week. Sorry for the delay - hope you understand.\r\n\r\nOh yes, I understand very well. Best of luck to you, and take it easy! Nothing urgent is going to happen here, I'm pretty certain. ;)\r\n\r\n> If you want to post a patch for it, though, you can send it to dev@lists.esnacc.org and Sagara can review and possibly merge it for you and do the back port to the 1.8.0 branch for the next 1.8 release in a few weeks.\r\n\r\nThanks! Let me think and maybe develop a patch. ;)"}}
{"actor":{"display_login":"mouse07410"}}