{"action":"created","comment":{"url":"https://api.github.com/repos/cfpb/capital-framework/pulls/comments/83272542","pull_request_review_id":4127578,"id":83272542,"diff_hunk":"@@ -0,0 +1,103 @@\n+//\n+// Unstyled list modifier\n+//\n+\n+.m-list__unstyled,\n+.m-list__horizontal,\n+.m-list__icons,\n+.m-list__links {\n+    padding-left: 0;\n+\n+    list-style-type: none;\n+\n+    // This is needed for dd elements.\n+    .a-list-item {\n+        margin-left: 0;\n+    }\n+}\n+\n+//\n+// Spaced list modifier\n+//\n+\n+.m-list__spaced {\n+    .m-list__spaced,\n+    .a-list-item + .a-list-item {\n+        margin-top: unit( 24px / @base-font-size-px, em );\n+    }\n+}\n+\n+//\n+// Horizontal list modifier\n+//\n+\n+.m-list__horizontal {\n+    .a-list-item {\n+        display: inline-block;\n+\n+        // Assuming a natural space of 4px between inline block items\n+        // then the space between would be 8px (4px natural + 4px added).\n+        margin-right: unit( 4px / @base-font-size-px, em );\n+    }\n+}\n+\n+//\n+// Icon list modifier\n+//\n+\n+.m-list__icons {\n+    .a-list-item {\n+        padding-left: 1.5em;\n+        position: relative;\n+    }\n+\n+    .cf-icon {\n+        position: absolute;\n+        left: 0;\n+        width: 1.5em;\n+        text-align: center;\n+        top: 0.1em;\n+    }\n+}\n+\n+//\n+// Link list modifier\n+//\n+\n+.m-list__links {\n+    .a-list-item {\n+        .respond-to-max( @bp-xs-max, {\n+            margin-bottom: 0;\n+\n+            &:nth-child(n+2) .a-link {\n+                border-top-width: 0;\n+            }\n+        } );\n+    }\n+\n+    .a-link {","path":"src/cf-typography/src/molecules/list.less","position":71,"original_position":78,"commit_id":"3f3a65b4d7c5d78eb3e35a75f547a908f0c749d6","original_commit_id":"16739b10f723ce91537ec78aa964c6777c904f25","user":{"login":"Scotchester","id":1044670,"avatar_url":"https://avatars.githubusercontent.com/u/1044670?v=3","gravatar_id":"","url":"https://api.github.com/users/Scotchester","html_url":"https://github.com/Scotchester","followers_url":"https://api.github.com/users/Scotchester/followers","following_url":"https://api.github.com/users/Scotchester/following{/other_user}","gists_url":"https://api.github.com/users/Scotchester/gists{/gist_id}","starred_url":"https://api.github.com/users/Scotchester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scotchester/subscriptions","organizations_url":"https://api.github.com/users/Scotchester/orgs","repos_url":"https://api.github.com/users/Scotchester/repos","events_url":"https://api.github.com/users/Scotchester/events{/privacy}","received_events_url":"https://api.github.com/users/Scotchester/received_events","type":"User","site_admin":false},"body":"I think we're going to have to pair for me to understand what you're talking about here. 3–3:30?","created_at":"2016-10-13T17:46:56Z","updated_at":"2016-10-13T17:46:56Z","html_url":"https://github.com/cfpb/capital-framework/pull/412#discussion_r83272542","pull_request_url":"https://api.github.com/repos/cfpb/capital-framework/pulls/412","_links":{"self":{"href":"https://api.github.com/repos/cfpb/capital-framework/pulls/comments/83272542"},"html":{"href":"https://github.com/cfpb/capital-framework/pull/412#discussion_r83272542"},"pull_request":{"href":"https://api.github.com/repos/cfpb/capital-framework/pulls/412"}}},"pull_request":{"url":"https://api.github.com/repos/cfpb/capital-framework/pulls/412","id":88902613,"html_url":"https://github.com/cfpb/capital-framework/pull/412","diff_url":"https://github.com/cfpb/capital-framework/pull/412.diff","patch_url":"https://github.com/cfpb/capital-framework/pull/412.patch","issue_url":"https://api.github.com/repos/cfpb/capital-framework/issues/412","number":412,"state":"open","locked":false,"title":"Atomic/typography","user":{"login":"jimmynotjim","id":1280430,"avatar_url":"https://avatars.githubusercontent.com/u/1280430?v=3","gravatar_id":"","url":"https://api.github.com/users/jimmynotjim","html_url":"https://github.com/jimmynotjim","followers_url":"https://api.github.com/users/jimmynotjim/followers","following_url":"https://api.github.com/users/jimmynotjim/following{/other_user}","gists_url":"https://api.github.com/users/jimmynotjim/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmynotjim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmynotjim/subscriptions","organizations_url":"https://api.github.com/users/jimmynotjim/orgs","repos_url":"https://api.github.com/users/jimmynotjim/repos","events_url":"https://api.github.com/users/jimmynotjim/events{/privacy}","received_events_url":"https://api.github.com/users/jimmynotjim/received_events","type":"User","site_admin":false},"body":"Converted cf-typography to atomic standards\r\n\r\n## Removals\r\n\r\n- Removed custom bullet mixin because it is no longer used\r\n- Removed fancy slug because it is no longer used\r\n- Removed short-desc because we are now using Avenir as our standard body font\r\n- Temporarily removed list link with icon layout due to mix in how icons are implemented (will fix in a soon to come PR). Falls back to normal icon links inside a list for the time being.\r\n\r\n## Changes\r\n\r\n- Broke links apart to create less repetitive code\r\n- Broke headings and headers apart to create a better parent/child relationship and handle layout according to our best practices.\r\n\r\n## Testing\r\n\r\n- check out `example/cf-typography ` sandbox branch and run `npm run build && npm start`\r\n- navigate to `http://localhost:3000/components/cf-typography/`\r\n\r\n## Review\r\n\r\n- @Scotchester \r\n\r\n## Screenshots\r\n\r\nToo many to list, but everything should really look the same as the examples at `https://cfpb.github.io/capital-framework/components/cf-typography/#pull-quote` \r\n\r\n## Notes\r\n\r\n- `a-heading` is a placeholder much like `a-list`. There are no uniform styles between the headings, but it makes the most sense, especially when controlling the layout/margin of stylized headings nested inside headers.\r\n- __Reduces output by 4kb__. Small gains but still a positive impact.\r\n\r\n## Todos\r\n\r\n- Clean up the way we're handling icons. There's a ton of repetitive code due to icons and I have an idea of how it could be better implemented.\r\n\r\n## Checklist\r\n\r\n* [ ] Changes are limited to a single goal (no scope creep)\r\n* [ ] Code can be automatically merged (no conflicts)\r\n* [ ] Code follows the standards laid out in the [front end playbook](https://github.com/cfpb/front-end)\r\n* [ ] Passes all existing automated tests\r\n* [ ] New functions include new tests\r\n* [ ] New functions are documented (with a description, list of inputs, and expected output)\r\n* [ ] Placeholder code is flagged\r\n* [ ] Visually tested in supported browsers and devices\r\n* [ ] Project documentation has been updated (including the \"Unreleased\" section of the CHANGELOG)\r\n","created_at":"2016-10-11T20:14:39Z","updated_at":"2016-10-13T17:46:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe18d4f4cefe8a923747c40a482abf127526174c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cfpb/capital-framework/pulls/412/commits","review_comments_url":"https://api.github.com/repos/cfpb/capital-framework/pulls/412/comments","review_comment_url":"https://api.github.com/repos/cfpb/capital-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cfpb/capital-framework/issues/412/comments","statuses_url":"https://api.github.com/repos/cfpb/capital-framework/statuses/3f3a65b4d7c5d78eb3e35a75f547a908f0c749d6","head":{"label":"cfpb:atomic/typography","ref":"atomic/typography","sha":"3f3a65b4d7c5d78eb3e35a75f547a908f0c749d6","user":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"repo":{"id":17405777,"name":"capital-framework","full_name":"cfpb/capital-framework","owner":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cfpb/capital-framework","description":"The Consumer Financial Protection Bureau's user interface framework","fork":false,"url":"https://api.github.com/repos/cfpb/capital-framework","forks_url":"https://api.github.com/repos/cfpb/capital-framework/forks","keys_url":"https://api.github.com/repos/cfpb/capital-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cfpb/capital-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cfpb/capital-framework/teams","hooks_url":"https://api.github.com/repos/cfpb/capital-framework/hooks","issue_events_url":"https://api.github.com/repos/cfpb/capital-framework/issues/events{/number}","events_url":"https://api.github.com/repos/cfpb/capital-framework/events","assignees_url":"https://api.github.com/repos/cfpb/capital-framework/assignees{/user}","branches_url":"https://api.github.com/repos/cfpb/capital-framework/branches{/branch}","tags_url":"https://api.github.com/repos/cfpb/capital-framework/tags","blobs_url":"https://api.github.com/repos/cfpb/capital-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cfpb/capital-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cfpb/capital-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/cfpb/capital-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cfpb/capital-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/cfpb/capital-framework/languages","stargazers_url":"https://api.github.com/repos/cfpb/capital-framework/stargazers","contributors_url":"https://api.github.com/repos/cfpb/capital-framework/contributors","subscribers_url":"https://api.github.com/repos/cfpb/capital-framework/subscribers","subscription_url":"https://api.github.com/repos/cfpb/capital-framework/subscription","commits_url":"https://api.github.com/repos/cfpb/capital-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/cfpb/capital-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/cfpb/capital-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/cfpb/capital-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/cfpb/capital-framework/contents/{+path}","compare_url":"https://api.github.com/repos/cfpb/capital-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cfpb/capital-framework/merges","archive_url":"https://api.github.com/repos/cfpb/capital-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cfpb/capital-framework/downloads","issues_url":"https://api.github.com/repos/cfpb/capital-framework/issues{/number}","pulls_url":"https://api.github.com/repos/cfpb/capital-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/cfpb/capital-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/cfpb/capital-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cfpb/capital-framework/labels{/name}","releases_url":"https://api.github.com/repos/cfpb/capital-framework/releases{/id}","deployments_url":"https://api.github.com/repos/cfpb/capital-framework/deployments","created_at":"2014-03-04T14:57:06Z","updated_at":"2016-09-30T13:24:17Z","pushed_at":"2016-10-13T16:26:28Z","git_url":"git://github.com/cfpb/capital-framework.git","ssh_url":"git@github.com:cfpb/capital-framework.git","clone_url":"https://github.com/cfpb/capital-framework.git","svn_url":"https://github.com/cfpb/capital-framework","homepage":"https://cfpb.github.io/capital-framework/","size":9503,"stargazers_count":27,"watchers_count":27,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":23,"mirror_url":null,"open_issues_count":70,"forks":23,"open_issues":70,"watchers":27,"default_branch":"canary"}},"base":{"label":"cfpb:prerelease-ver-4","ref":"prerelease-ver-4","sha":"67f4dccf53ea7c444a43d3a216c45f64146876b8","user":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"repo":{"id":17405777,"name":"capital-framework","full_name":"cfpb/capital-framework","owner":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cfpb/capital-framework","description":"The Consumer Financial Protection Bureau's user interface framework","fork":false,"url":"https://api.github.com/repos/cfpb/capital-framework","forks_url":"https://api.github.com/repos/cfpb/capital-framework/forks","keys_url":"https://api.github.com/repos/cfpb/capital-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cfpb/capital-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cfpb/capital-framework/teams","hooks_url":"https://api.github.com/repos/cfpb/capital-framework/hooks","issue_events_url":"https://api.github.com/repos/cfpb/capital-framework/issues/events{/number}","events_url":"https://api.github.com/repos/cfpb/capital-framework/events","assignees_url":"https://api.github.com/repos/cfpb/capital-framework/assignees{/user}","branches_url":"https://api.github.com/repos/cfpb/capital-framework/branches{/branch}","tags_url":"https://api.github.com/repos/cfpb/capital-framework/tags","blobs_url":"https://api.github.com/repos/cfpb/capital-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cfpb/capital-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cfpb/capital-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/cfpb/capital-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cfpb/capital-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/cfpb/capital-framework/languages","stargazers_url":"https://api.github.com/repos/cfpb/capital-framework/stargazers","contributors_url":"https://api.github.com/repos/cfpb/capital-framework/contributors","subscribers_url":"https://api.github.com/repos/cfpb/capital-framework/subscribers","subscription_url":"https://api.github.com/repos/cfpb/capital-framework/subscription","commits_url":"https://api.github.com/repos/cfpb/capital-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/cfpb/capital-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/cfpb/capital-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/cfpb/capital-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/cfpb/capital-framework/contents/{+path}","compare_url":"https://api.github.com/repos/cfpb/capital-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cfpb/capital-framework/merges","archive_url":"https://api.github.com/repos/cfpb/capital-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cfpb/capital-framework/downloads","issues_url":"https://api.github.com/repos/cfpb/capital-framework/issues{/number}","pulls_url":"https://api.github.com/repos/cfpb/capital-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/cfpb/capital-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/cfpb/capital-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cfpb/capital-framework/labels{/name}","releases_url":"https://api.github.com/repos/cfpb/capital-framework/releases{/id}","deployments_url":"https://api.github.com/repos/cfpb/capital-framework/deployments","created_at":"2014-03-04T14:57:06Z","updated_at":"2016-09-30T13:24:17Z","pushed_at":"2016-10-13T16:26:28Z","git_url":"git://github.com/cfpb/capital-framework.git","ssh_url":"git@github.com:cfpb/capital-framework.git","clone_url":"https://github.com/cfpb/capital-framework.git","svn_url":"https://github.com/cfpb/capital-framework","homepage":"https://cfpb.github.io/capital-framework/","size":9503,"stargazers_count":27,"watchers_count":27,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":23,"mirror_url":null,"open_issues_count":70,"forks":23,"open_issues":70,"watchers":27,"default_branch":"canary"}},"_links":{"self":{"href":"https://api.github.com/repos/cfpb/capital-framework/pulls/412"},"html":{"href":"https://github.com/cfpb/capital-framework/pull/412"},"issue":{"href":"https://api.github.com/repos/cfpb/capital-framework/issues/412"},"comments":{"href":"https://api.github.com/repos/cfpb/capital-framework/issues/412/comments"},"review_comments":{"href":"https://api.github.com/repos/cfpb/capital-framework/pulls/412/comments"},"review_comment":{"href":"https://api.github.com/repos/cfpb/capital-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cfpb/capital-framework/pulls/412/commits"},"statuses":{"href":"https://api.github.com/repos/cfpb/capital-framework/statuses/3f3a65b4d7c5d78eb3e35a75f547a908f0c749d6"}}}}
{"actor":{"display_login":"Scotchester"}}