{"action":"created","issue":{"url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/issues/797","repository_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner","labels_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/issues/797/labels{/name}","comments_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/issues/797/comments","events_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/issues/797/events","html_url":"https://github.com/ONSdigital/eq-survey-runner/pull/797","id":196921197,"number":797,"title":"Support `or` rules for group skip_condition","user":{"login":"benjefferies","id":15050019,"avatar_url":"https://avatars.githubusercontent.com/u/15050019?v=3","gravatar_id":"","url":"https://api.github.com/users/benjefferies","html_url":"https://github.com/benjefferies","followers_url":"https://api.github.com/users/benjefferies/followers","following_url":"https://api.github.com/users/benjefferies/following{/other_user}","gists_url":"https://api.github.com/users/benjefferies/gists{/gist_id}","starred_url":"https://api.github.com/users/benjefferies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjefferies/subscriptions","organizations_url":"https://api.github.com/users/benjefferies/orgs","repos_url":"https://api.github.com/users/benjefferies/repos","events_url":"https://api.github.com/users/benjefferies/events{/privacy}","received_events_url":"https://api.github.com/users/benjefferies/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-21T12:29:25Z","updated_at":"2016-12-21T12:32:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/pulls/797","html_url":"https://github.com/ONSdigital/eq-survey-runner/pull/797","diff_url":"https://github.com/ONSdigital/eq-survey-runner/pull/797.diff","patch_url":"https://github.com/ONSdigital/eq-survey-runner/pull/797.patch"},"body":"### What is the context of this PR?\r\nWe need to be able to support `or` rules for the census visitors\r\ninterstitial page so that it is skipped when the number of visitors is 0\r\nor skipped via navigation. We have changed the skip_condition\r\nconfiguration to take an array of when elements. Adding more than one\r\nwhen element creates a `or` rule like so.\r\n\r\n```\r\n\"skip_condition\": [\r\n                {\r\n                    \"when\": [\r\n                        {\r\n                            \"id\": \"overnight-visitors-answer\",\r\n                            \"condition\": \"equals\",\r\n                            \"value\": \"0\"\r\n                        }\r\n                    ]\r\n                },\r\n                {\r\n                   \"when\": [\r\n                       {\r\n                           \"id\" : \"overnight-visitors-answer\",\r\n                           \"condition\": \"not set\"\r\n                       }\r\n                   ]\r\n                }\r\n            ],\r\n```\r\n### How to review \r\n1. Load the census_household schema\r\n1. Skip to the household and accommodation section\r\n1. Complete the household and accommodation section\r\n\r\nExpect to be routed to the `who lives here` section"},"comment":{"url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/issues/comments/268511892","html_url":"https://github.com/ONSdigital/eq-survey-runner/pull/797#issuecomment-268511892","issue_url":"https://api.github.com/repos/ONSdigital/eq-survey-runner/issues/797","id":268511892,"user":{"login":"collisdigital","id":14041600,"avatar_url":"https://avatars.githubusercontent.com/u/14041600?v=3","gravatar_id":"","url":"https://api.github.com/users/collisdigital","html_url":"https://github.com/collisdigital","followers_url":"https://api.github.com/users/collisdigital/followers","following_url":"https://api.github.com/users/collisdigital/following{/other_user}","gists_url":"https://api.github.com/users/collisdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/collisdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/collisdigital/subscriptions","organizations_url":"https://api.github.com/users/collisdigital/orgs","repos_url":"https://api.github.com/users/collisdigital/repos","events_url":"https://api.github.com/users/collisdigital/events{/privacy}","received_events_url":"https://api.github.com/users/collisdigital/received_events","type":"User","site_admin":false},"created_at":"2016-12-21T12:32:13Z","updated_at":"2016-12-21T12:32:13Z","body":"The title of this PR doesn't use smart quotes 👎 "}}
{"actor":{"display_login":"collisdigital"}}