{"action":"created","issue":{"url":"https://api.github.com/repos/silvershop/silvershop-discounts/issues/34","repository_url":"https://api.github.com/repos/silvershop/silvershop-discounts","labels_url":"https://api.github.com/repos/silvershop/silvershop-discounts/issues/34/labels{/name}","comments_url":"https://api.github.com/repos/silvershop/silvershop-discounts/issues/34/comments","events_url":"https://api.github.com/repos/silvershop/silvershop-discounts/issues/34/events","html_url":"https://github.com/silvershop/silvershop-discounts/issues/34","id":57046560,"number":34,"title":"This module relies on class `ShippingFrameworkModifier` existing","user":{"login":"jameshoward","id":202539,"avatar_url":"https://avatars.githubusercontent.com/u/202539?v=3","gravatar_id":"","url":"https://api.github.com/users/jameshoward","html_url":"https://github.com/jameshoward","followers_url":"https://api.github.com/users/jameshoward/followers","following_url":"https://api.github.com/users/jameshoward/following{/other_user}","gists_url":"https://api.github.com/users/jameshoward/gists{/gist_id}","starred_url":"https://api.github.com/users/jameshoward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jameshoward/subscriptions","organizations_url":"https://api.github.com/users/jameshoward/orgs","repos_url":"https://api.github.com/users/jameshoward/repos","events_url":"https://api.github.com/users/jameshoward/events{/privacy}","received_events_url":"https://api.github.com/users/jameshoward/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2015-02-09T15:39:17Z","updated_at":"2016-09-06T04:15:03Z","closed_at":"2016-02-02T21:33:03Z","body":"If I install the discount module on a base shop install I get the following notice:\r\n\r\n`Modifier class \"ShippingFrameworkModifier\" does not exist.`\r\n\r\nI've tracked this down to `Shop\\Discount\\Calculator` line 92:\r\n\r\n`if($shipping = $this->order->getModifier(\"ShippingFrameworkModifier\")){`\r\n\r\nIn `Order::getModifier` there's a `ClassInfo::exists` check that's throwing the `user_error` because that class doesn't exist.\r\n\r\nEither there's a dependency on `silverstripe-shop-shipping` or a better way of determining if the order has that modifier without needing the class to exist."},"comment":{"url":"https://api.github.com/repos/silvershop/silvershop-discounts/issues/comments/244845867","html_url":"https://github.com/silvershop/silvershop-discounts/issues/34#issuecomment-244845867","issue_url":"https://api.github.com/repos/silvershop/silvershop-discounts/issues/34","id":244845867,"user":{"login":"isaac-at-room9","id":22018845,"avatar_url":"https://avatars.githubusercontent.com/u/22018845?v=3","gravatar_id":"","url":"https://api.github.com/users/isaac-at-room9","html_url":"https://github.com/isaac-at-room9","followers_url":"https://api.github.com/users/isaac-at-room9/followers","following_url":"https://api.github.com/users/isaac-at-room9/following{/other_user}","gists_url":"https://api.github.com/users/isaac-at-room9/gists{/gist_id}","starred_url":"https://api.github.com/users/isaac-at-room9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaac-at-room9/subscriptions","organizations_url":"https://api.github.com/users/isaac-at-room9/orgs","repos_url":"https://api.github.com/users/isaac-at-room9/repos","events_url":"https://api.github.com/users/isaac-at-room9/events{/privacy}","received_events_url":"https://api.github.com/users/isaac-at-room9/received_events","type":"User","site_admin":false},"created_at":"2016-09-06T04:15:03Z","updated_at":"2016-09-06T04:15:03Z","body":"How long until this is released? We're using this module and it has been over a year since anything was released. Ran into this issue today with the latest release, had to fix the package at a commit (not preferable)"}}
{"actor":{"display_login":"isaac-at-room9"}}