{"action":"created","comment":{"url":"https://api.github.com/repos/pagespeed/mod_pagespeed/pulls/comments/91579715","pull_request_review_id":12081213,"id":91579715,"diff_hunk":"@@ -321,6 +322,13 @@ void SystemServerContext::ApplySessionFetchers(\n         system_request->local_port(), driver->async_fetcher()));\n   }\n \n+  if (options->max_fetch_redirects() > 0) {\n+    driver->SetSessionFetcher(new RedirectFollowingUrlAsyncFetcher(\n+        driver->async_fetcher(), system_request->url().as_string(),\n+        thread_system(), statistics(), options->max_fetch_redirects(),\n+        options));\n+  }\n+\n   if (driver->options()->num_custom_fetch_headers() > 0) {\n     driver->SetSessionFetcher(new AddHeadersFetcher(driver->options(),\n                                                     driver->async_fetcher()));","path":"pagespeed/system/system_server_context.cc","position":30,"original_position":30,"commit_id":"b015716207a3a297387defcd0d0027f3a63c5146","original_commit_id":"b015716207a3a297387defcd0d0027f3a63c5146","user":{"login":"morlovich","id":3765572,"avatar_url":"https://avatars.githubusercontent.com/u/3765572?v=3","gravatar_id":"","url":"https://api.github.com/users/morlovich","html_url":"https://github.com/morlovich","followers_url":"https://api.github.com/users/morlovich/followers","following_url":"https://api.github.com/users/morlovich/following{/other_user}","gists_url":"https://api.github.com/users/morlovich/gists{/gist_id}","starred_url":"https://api.github.com/users/morlovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morlovich/subscriptions","organizations_url":"https://api.github.com/users/morlovich/orgs","repos_url":"https://api.github.com/users/morlovich/repos","events_url":"https://api.github.com/users/morlovich/events{/privacy}","received_events_url":"https://api.github.com/users/morlovich/received_events","type":"User","site_admin":false},"body":"Hmm, might want to add your thing later in the list compares to the AddHeadersFetcher if we want every step of the redirect to get those custom headers.","created_at":"2016-12-08T18:46:31Z","updated_at":"2016-12-08T18:47:45Z","html_url":"https://github.com/pagespeed/mod_pagespeed/pull/1436#discussion_r91579715","pull_request_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/pulls/1436","_links":{"self":{"href":"https://api.github.com/repos/pagespeed/mod_pagespeed/pulls/comments/91579715"},"html":{"href":"https://github.com/pagespeed/mod_pagespeed/pull/1436#discussion_r91579715"},"pull_request":{"href":"https://api.github.com/repos/pagespeed/mod_pagespeed/pulls/1436"}}},"pull_request":{"url":"https://api.github.com/repos/pagespeed/mod_pagespeed/pulls/1436","id":94674231,"html_url":"https://github.com/pagespeed/mod_pagespeed/pull/1436","diff_url":"https://github.com/pagespeed/mod_pagespeed/pull/1436.diff","patch_url":"https://github.com/pagespeed/mod_pagespeed/pull/1436.patch","issue_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/issues/1436","number":1436,"state":"open","locked":false,"title":"Redirect following capability","user":{"login":"oschaaf","id":2239556,"avatar_url":"https://avatars.githubusercontent.com/u/2239556?v=3","gravatar_id":"","url":"https://api.github.com/users/oschaaf","html_url":"https://github.com/oschaaf","followers_url":"https://api.github.com/users/oschaaf/followers","following_url":"https://api.github.com/users/oschaaf/following{/other_user}","gists_url":"https://api.github.com/users/oschaaf/gists{/gist_id}","starred_url":"https://api.github.com/users/oschaaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oschaaf/subscriptions","organizations_url":"https://api.github.com/users/oschaaf/orgs","repos_url":"https://api.github.com/users/oschaaf/repos","events_url":"https://api.github.com/users/oschaaf/events{/privacy}","received_events_url":"https://api.github.com/users/oschaaf/received_events","type":"User","site_admin":false},"body":"This adds the capability of following redirects for resource fetches to PageSpeed.\r\n\r\nFixes https://github.com/pagespeed/mod_pagespeed/issues/262","created_at":"2016-11-21T18:53:31Z","updated_at":"2016-12-08T18:47:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4337c8b9e97af0c3f15412d9670ee0f6e4581c4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/pulls/1436/commits","review_comments_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/pulls/1436/comments","review_comment_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/issues/1436/comments","statuses_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/statuses/b015716207a3a297387defcd0d0027f3a63c5146","head":{"label":"pagespeed:oschaaf-master-redirecting-fetch","ref":"oschaaf-master-redirecting-fetch","sha":"b015716207a3a297387defcd0d0027f3a63c5146","user":{"login":"pagespeed","id":1880112,"avatar_url":"https://avatars.githubusercontent.com/u/1880112?v=3","gravatar_id":"","url":"https://api.github.com/users/pagespeed","html_url":"https://github.com/pagespeed","followers_url":"https://api.github.com/users/pagespeed/followers","following_url":"https://api.github.com/users/pagespeed/following{/other_user}","gists_url":"https://api.github.com/users/pagespeed/gists{/gist_id}","starred_url":"https://api.github.com/users/pagespeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pagespeed/subscriptions","organizations_url":"https://api.github.com/users/pagespeed/orgs","repos_url":"https://api.github.com/users/pagespeed/repos","events_url":"https://api.github.com/users/pagespeed/events{/privacy}","received_events_url":"https://api.github.com/users/pagespeed/received_events","type":"Organization","site_admin":false},"repo":{"id":33489346,"name":"mod_pagespeed","full_name":"pagespeed/mod_pagespeed","owner":{"login":"pagespeed","id":1880112,"avatar_url":"https://avatars.githubusercontent.com/u/1880112?v=3","gravatar_id":"","url":"https://api.github.com/users/pagespeed","html_url":"https://github.com/pagespeed","followers_url":"https://api.github.com/users/pagespeed/followers","following_url":"https://api.github.com/users/pagespeed/following{/other_user}","gists_url":"https://api.github.com/users/pagespeed/gists{/gist_id}","starred_url":"https://api.github.com/users/pagespeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pagespeed/subscriptions","organizations_url":"https://api.github.com/users/pagespeed/orgs","repos_url":"https://api.github.com/users/pagespeed/repos","events_url":"https://api.github.com/users/pagespeed/events{/privacy}","received_events_url":"https://api.github.com/users/pagespeed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pagespeed/mod_pagespeed","description":"Apache module for rewriting web pages to reduce latency and bandwidth.","fork":false,"url":"https://api.github.com/repos/pagespeed/mod_pagespeed","forks_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/forks","keys_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/teams","hooks_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/hooks","issue_events_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/issues/events{/number}","events_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/events","assignees_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/assignees{/user}","branches_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/branches{/branch}","tags_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/tags","blobs_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/git/refs{/sha}","trees_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/statuses/{sha}","languages_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/languages","stargazers_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/stargazers","contributors_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/contributors","subscribers_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/subscribers","subscription_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/subscription","commits_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/commits{/sha}","git_commits_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/git/commits{/sha}","comments_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/comments{/number}","issue_comment_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/issues/comments{/number}","contents_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/contents/{+path}","compare_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/merges","archive_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/downloads","issues_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/issues{/number}","pulls_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/pulls{/number}","milestones_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/milestones{/number}","notifications_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/labels{/name}","releases_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/releases{/id}","deployments_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/deployments","created_at":"2015-04-06T15:31:46Z","updated_at":"2016-12-08T09:31:18Z","pushed_at":"2016-12-08T15:52:35Z","git_url":"git://github.com/pagespeed/mod_pagespeed.git","ssh_url":"git@github.com:pagespeed/mod_pagespeed.git","clone_url":"https://github.com/pagespeed/mod_pagespeed.git","svn_url":"https://github.com/pagespeed/mod_pagespeed","homepage":"http://modpagespeed.com","size":48201,"stargazers_count":304,"watchers_count":304,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"open_issues_count":351,"forks":48,"open_issues":351,"watchers":304,"default_branch":"master"}},"base":{"label":"pagespeed:master","ref":"master","sha":"fe326271dc5eb0c6894217d3c960c70f2c95b33e","user":{"login":"pagespeed","id":1880112,"avatar_url":"https://avatars.githubusercontent.com/u/1880112?v=3","gravatar_id":"","url":"https://api.github.com/users/pagespeed","html_url":"https://github.com/pagespeed","followers_url":"https://api.github.com/users/pagespeed/followers","following_url":"https://api.github.com/users/pagespeed/following{/other_user}","gists_url":"https://api.github.com/users/pagespeed/gists{/gist_id}","starred_url":"https://api.github.com/users/pagespeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pagespeed/subscriptions","organizations_url":"https://api.github.com/users/pagespeed/orgs","repos_url":"https://api.github.com/users/pagespeed/repos","events_url":"https://api.github.com/users/pagespeed/events{/privacy}","received_events_url":"https://api.github.com/users/pagespeed/received_events","type":"Organization","site_admin":false},"repo":{"id":33489346,"name":"mod_pagespeed","full_name":"pagespeed/mod_pagespeed","owner":{"login":"pagespeed","id":1880112,"avatar_url":"https://avatars.githubusercontent.com/u/1880112?v=3","gravatar_id":"","url":"https://api.github.com/users/pagespeed","html_url":"https://github.com/pagespeed","followers_url":"https://api.github.com/users/pagespeed/followers","following_url":"https://api.github.com/users/pagespeed/following{/other_user}","gists_url":"https://api.github.com/users/pagespeed/gists{/gist_id}","starred_url":"https://api.github.com/users/pagespeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pagespeed/subscriptions","organizations_url":"https://api.github.com/users/pagespeed/orgs","repos_url":"https://api.github.com/users/pagespeed/repos","events_url":"https://api.github.com/users/pagespeed/events{/privacy}","received_events_url":"https://api.github.com/users/pagespeed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pagespeed/mod_pagespeed","description":"Apache module for rewriting web pages to reduce latency and bandwidth.","fork":false,"url":"https://api.github.com/repos/pagespeed/mod_pagespeed","forks_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/forks","keys_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/teams","hooks_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/hooks","issue_events_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/issues/events{/number}","events_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/events","assignees_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/assignees{/user}","branches_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/branches{/branch}","tags_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/tags","blobs_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/git/refs{/sha}","trees_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/statuses/{sha}","languages_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/languages","stargazers_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/stargazers","contributors_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/contributors","subscribers_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/subscribers","subscription_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/subscription","commits_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/commits{/sha}","git_commits_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/git/commits{/sha}","comments_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/comments{/number}","issue_comment_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/issues/comments{/number}","contents_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/contents/{+path}","compare_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/merges","archive_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/downloads","issues_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/issues{/number}","pulls_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/pulls{/number}","milestones_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/milestones{/number}","notifications_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/labels{/name}","releases_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/releases{/id}","deployments_url":"https://api.github.com/repos/pagespeed/mod_pagespeed/deployments","created_at":"2015-04-06T15:31:46Z","updated_at":"2016-12-08T09:31:18Z","pushed_at":"2016-12-08T15:52:35Z","git_url":"git://github.com/pagespeed/mod_pagespeed.git","ssh_url":"git@github.com:pagespeed/mod_pagespeed.git","clone_url":"https://github.com/pagespeed/mod_pagespeed.git","svn_url":"https://github.com/pagespeed/mod_pagespeed","homepage":"http://modpagespeed.com","size":48201,"stargazers_count":304,"watchers_count":304,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"open_issues_count":351,"forks":48,"open_issues":351,"watchers":304,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pagespeed/mod_pagespeed/pulls/1436"},"html":{"href":"https://github.com/pagespeed/mod_pagespeed/pull/1436"},"issue":{"href":"https://api.github.com/repos/pagespeed/mod_pagespeed/issues/1436"},"comments":{"href":"https://api.github.com/repos/pagespeed/mod_pagespeed/issues/1436/comments"},"review_comments":{"href":"https://api.github.com/repos/pagespeed/mod_pagespeed/pulls/1436/comments"},"review_comment":{"href":"https://api.github.com/repos/pagespeed/mod_pagespeed/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pagespeed/mod_pagespeed/pulls/1436/commits"},"statuses":{"href":"https://api.github.com/repos/pagespeed/mod_pagespeed/statuses/b015716207a3a297387defcd0d0027f3a63c5146"}}}}
{"actor":{"display_login":"morlovich"}}