{"action":"opened","number":202,"pull_request":{"url":"https://api.github.com/repos/jenkinsci/git-client-plugin/pulls/202","id":66293265,"html_url":"https://github.com/jenkinsci/git-client-plugin/pull/202","diff_url":"https://github.com/jenkinsci/git-client-plugin/pull/202.diff","patch_url":"https://github.com/jenkinsci/git-client-plugin/pull/202.patch","issue_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/issues/202","number":202,"state":"open","locked":false,"title":"(WIP) Recursive push","user":{"login":"praqma-thi","id":12794699,"avatar_url":"https://avatars.githubusercontent.com/u/12794699?v=3","gravatar_id":"","url":"https://api.github.com/users/praqma-thi","html_url":"https://github.com/praqma-thi","followers_url":"https://api.github.com/users/praqma-thi/followers","following_url":"https://api.github.com/users/praqma-thi/following{/other_user}","gists_url":"https://api.github.com/users/praqma-thi/gists{/gist_id}","starred_url":"https://api.github.com/users/praqma-thi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praqma-thi/subscriptions","organizations_url":"https://api.github.com/users/praqma-thi/orgs","repos_url":"https://api.github.com/users/praqma-thi/repos","events_url":"https://api.github.com/users/praqma-thi/events{/privacy}","received_events_url":"https://api.github.com/users/praqma-thi/received_events","type":"User","site_admin":false},"body":"# Recursive push\r\nI'm working on adding support for recursive pushing of submodules to the PushCommand.\r\nThe eventual goal is adding support for this to the Git plugin's publisher.\r\n\r\n## Changes\r\n\r\n### PushCommand\r\nI added `recurseSubmodules(String recurseOption)` to the PushCommand interface.\r\nI contemplated making recurseOption an enum, but decided against it for simplicity's sake.\r\n\r\n### CliGitAPIImpl\r\nFor the CLI implementation I simply add `--recurse-submodules=${option}` to the command args. In line with all the other options.\r\n\r\n### JGitAPIImpl\r\nAs far as I can tell, JGit doesn't seem to support this at the time, so I left this empty with a TODO for now. Should I leave it as is or try to find a workaround?\r\n\r\n### GitAPITestCase\r\nI added a zipped up test setup to the resources containing a number of repositories.\r\nTheir links are all relative so I just unzip it, execute my push command and check the results.\r\nI added three tests, testing each valid option respectively.\r\n\r\nOriginally, I created the test setup from scratch, which made their contents clearer, but made the tests themselves rather big. Which approach do you prefer?\r\n\r\n#### Other\r\nI removed some unused imports throughout the files I touched.","created_at":"2016-04-13T09:49:29Z","updated_at":"2016-04-13T09:49:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c6dbfb851d3282f37cbc6a5a82c75dfd16b2d34","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/pulls/202/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/pulls/202/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/issues/202/comments","statuses_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/statuses/ffb163cf5e32f7edf4c60f61bec667b062521a6a","head":{"label":"praqma-thi:ready/recursive-push","ref":"ready/recursive-push","sha":"ffb163cf5e32f7edf4c60f61bec667b062521a6a","user":{"login":"praqma-thi","id":12794699,"avatar_url":"https://avatars.githubusercontent.com/u/12794699?v=3","gravatar_id":"","url":"https://api.github.com/users/praqma-thi","html_url":"https://github.com/praqma-thi","followers_url":"https://api.github.com/users/praqma-thi/followers","following_url":"https://api.github.com/users/praqma-thi/following{/other_user}","gists_url":"https://api.github.com/users/praqma-thi/gists{/gist_id}","starred_url":"https://api.github.com/users/praqma-thi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praqma-thi/subscriptions","organizations_url":"https://api.github.com/users/praqma-thi/orgs","repos_url":"https://api.github.com/users/praqma-thi/repos","events_url":"https://api.github.com/users/praqma-thi/events{/privacy}","received_events_url":"https://api.github.com/users/praqma-thi/received_events","type":"User","site_admin":false},"repo":{"id":55947907,"name":"git-client-plugin","full_name":"praqma-thi/git-client-plugin","owner":{"login":"praqma-thi","id":12794699,"avatar_url":"https://avatars.githubusercontent.com/u/12794699?v=3","gravatar_id":"","url":"https://api.github.com/users/praqma-thi","html_url":"https://github.com/praqma-thi","followers_url":"https://api.github.com/users/praqma-thi/followers","following_url":"https://api.github.com/users/praqma-thi/following{/other_user}","gists_url":"https://api.github.com/users/praqma-thi/gists{/gist_id}","starred_url":"https://api.github.com/users/praqma-thi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praqma-thi/subscriptions","organizations_url":"https://api.github.com/users/praqma-thi/orgs","repos_url":"https://api.github.com/users/praqma-thi/repos","events_url":"https://api.github.com/users/praqma-thi/events{/privacy}","received_events_url":"https://api.github.com/users/praqma-thi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/praqma-thi/git-client-plugin","description":"Jenkins git client plugin","fork":true,"url":"https://api.github.com/repos/praqma-thi/git-client-plugin","forks_url":"https://api.github.com/repos/praqma-thi/git-client-plugin/forks","keys_url":"https://api.github.com/repos/praqma-thi/git-client-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/praqma-thi/git-client-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/praqma-thi/git-client-plugin/teams","hooks_url":"https://api.github.com/repos/praqma-thi/git-client-plugin/hooks","issue_events_url":"https://api.github.com/repos/praqma-thi/git-client-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/praqma-thi/git-client-plugin/events","assignees_url":"https://api.github.com/repos/praqma-thi/git-client-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/praqma-thi/git-client-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/praqma-thi/git-client-plugin/tags","blobs_url":"https://api.github.com/repos/praqma-thi/git-client-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/praqma-thi/git-client-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/praqma-thi/git-client-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/praqma-thi/git-client-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/praqma-thi/git-client-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/praqma-thi/git-client-plugin/languages","stargazers_url":"https://api.github.com/repos/praqma-thi/git-client-plugin/stargazers","contributors_url":"https://api.github.com/repos/praqma-thi/git-client-plugin/contributors","subscribers_url":"https://api.github.com/repos/praqma-thi/git-client-plugin/subscribers","subscription_url":"https://api.github.com/repos/praqma-thi/git-client-plugin/subscription","commits_url":"https://api.github.com/repos/praqma-thi/git-client-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/praqma-thi/git-client-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/praqma-thi/git-client-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/praqma-thi/git-client-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/praqma-thi/git-client-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/praqma-thi/git-client-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/praqma-thi/git-client-plugin/merges","archive_url":"https://api.github.com/repos/praqma-thi/git-client-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/praqma-thi/git-client-plugin/downloads","issues_url":"https://api.github.com/repos/praqma-thi/git-client-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/praqma-thi/git-client-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/praqma-thi/git-client-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/praqma-thi/git-client-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/praqma-thi/git-client-plugin/labels{/name}","releases_url":"https://api.github.com/repos/praqma-thi/git-client-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/praqma-thi/git-client-plugin/deployments","created_at":"2016-04-11T06:38:26Z","updated_at":"2016-04-11T06:38:26Z","pushed_at":"2016-04-13T09:24:51Z","git_url":"git://github.com/praqma-thi/git-client-plugin.git","ssh_url":"git@github.com:praqma-thi/git-client-plugin.git","clone_url":"https://github.com/praqma-thi/git-client-plugin.git","svn_url":"https://github.com/praqma-thi/git-client-plugin","homepage":"https://wiki.jenkins-ci.org/display/JENKINS/Git+Client+Plugin","size":2798,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:1.20.0-beta2","ref":"1.20.0-beta2","sha":"9288123b521ca002afb3e3f0df5ddad95826cafb","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":8263652,"name":"git-client-plugin","full_name":"jenkinsci/git-client-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/git-client-plugin","description":"Jenkins git client plugin","fork":false,"url":"https://api.github.com/repos/jenkinsci/git-client-plugin","forks_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/git-client-plugin/deployments","created_at":"2013-02-18T07:23:45Z","updated_at":"2016-04-05T17:42:39Z","pushed_at":"2016-04-13T09:49:29Z","git_url":"git://github.com/jenkinsci/git-client-plugin.git","ssh_url":"git@github.com:jenkinsci/git-client-plugin.git","clone_url":"https://github.com/jenkinsci/git-client-plugin.git","svn_url":"https://github.com/jenkinsci/git-client-plugin","homepage":"https://wiki.jenkins-ci.org/display/JENKINS/Git+Client+Plugin","size":7061,"stargazers_count":46,"watchers_count":46,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":163,"mirror_url":null,"open_issues_count":10,"forks":163,"open_issues":10,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/git-client-plugin/pulls/202"},"html":{"href":"https://github.com/jenkinsci/git-client-plugin/pull/202"},"issue":{"href":"https://api.github.com/repos/jenkinsci/git-client-plugin/issues/202"},"comments":{"href":"https://api.github.com/repos/jenkinsci/git-client-plugin/issues/202/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/git-client-plugin/pulls/202/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/git-client-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/git-client-plugin/pulls/202/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/git-client-plugin/statuses/ffb163cf5e32f7edf4c60f61bec667b062521a6a"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":86,"deletions":4,"changed_files":5}}