{"action":"created","comment":{"url":"https://api.github.com/repos/googleapis/artman/pulls/comments/76671293","id":76671293,"diff_hunk":"@@ -0,0 +1,133 @@\n+# Copyright 2016 Google Inc. All Rights Reserved.\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+# http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n+\n+\"\"\"Pipelines that run GAPIC\"\"\"\n+\n+import yaml\n+import glob\n+\n+from pipeline.pipelines import code_generation_pipeline as code_gen\n+from pipeline.tasks import batch_tasks\n+from taskflow.patterns import linear_flow\n+from pipeline.utils import config_util, pipeline_util, task_utils\n+\n+\n+class BatchPipeline(code_gen.CodeGenerationPipelineBase):\n+\n+    def __init__(self, get_pipeline_tasks_func, **kwargs):\n+        task_factory = BatchTaskFactory(get_pipeline_tasks_func)\n+        super(BatchPipeline, self).__init__(\n+            task_factory, **kwargs)\n+\n+    def validate_kwargs(self, **kwargs):\n+        required = ['apis', 'languages', 'api_config_pattern',\n+                    'artman_language_yaml', 'batch_output_dir']\n+        pipeline_util.validate_exists(required, **kwargs)","path":"pipeline/pipelines/batch_generation_pipeline.py","position":36,"original_position":36,"commit_id":"2bfd5faa121238eabdffb85e7d3be1e3dc88b317","original_commit_id":"2bfd5faa121238eabdffb85e7d3be1e3dc88b317","user":{"login":"garrettjonesgoogle","id":13341017,"avatar_url":"https://avatars.githubusercontent.com/u/13341017?v=3","gravatar_id":"","url":"https://api.github.com/users/garrettjonesgoogle","html_url":"https://github.com/garrettjonesgoogle","followers_url":"https://api.github.com/users/garrettjonesgoogle/followers","following_url":"https://api.github.com/users/garrettjonesgoogle/following{/other_user}","gists_url":"https://api.github.com/users/garrettjonesgoogle/gists{/gist_id}","starred_url":"https://api.github.com/users/garrettjonesgoogle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garrettjonesgoogle/subscriptions","organizations_url":"https://api.github.com/users/garrettjonesgoogle/orgs","repos_url":"https://api.github.com/users/garrettjonesgoogle/repos","events_url":"https://api.github.com/users/garrettjonesgoogle/events{/privacy}","received_events_url":"https://api.github.com/users/garrettjonesgoogle/received_events","type":"User","site_admin":false},"body":"So the parent class (CodeGenerationPipelineBase) has an existing validate_kwargs which calls pipeline_util.validate_exists itself (indirectly), and it gets extra kwargs to validate from the task factory. Couldn't you provide the kwargs to validate through get_validate_kwargs? I know that _validate_codegen_kwargs in code_generation_pipeline has some kwargs that are not relevant to the BatchPipeline, but maybe those should just be moved to the task factory(s) for the non-batch pipelines, and not have CodeGenerationPipelineBase assume anything.","created_at":"2016-08-29T19:31:30Z","updated_at":"2016-08-29T19:31:30Z","html_url":"https://github.com/googleapis/artman/pull/68#discussion_r76671293","pull_request_url":"https://api.github.com/repos/googleapis/artman/pulls/68","_links":{"self":{"href":"https://api.github.com/repos/googleapis/artman/pulls/comments/76671293"},"html":{"href":"https://github.com/googleapis/artman/pull/68#discussion_r76671293"},"pull_request":{"href":"https://api.github.com/repos/googleapis/artman/pulls/68"}}},"pull_request":{"url":"https://api.github.com/repos/googleapis/artman/pulls/68","id":82059992,"html_url":"https://github.com/googleapis/artman/pull/68","diff_url":"https://github.com/googleapis/artman/pull/68.diff","patch_url":"https://github.com/googleapis/artman/pull/68.patch","issue_url":"https://api.github.com/repos/googleapis/artman/issues/68","number":68,"state":"open","locked":false,"title":"Create GapicClientBatchPipeline","user":{"login":"michaelbausor","id":14846209,"avatar_url":"https://avatars.githubusercontent.com/u/14846209?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelbausor","html_url":"https://github.com/michaelbausor","followers_url":"https://api.github.com/users/michaelbausor/followers","following_url":"https://api.github.com/users/michaelbausor/following{/other_user}","gists_url":"https://api.github.com/users/michaelbausor/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelbausor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelbausor/subscriptions","organizations_url":"https://api.github.com/users/michaelbausor/orgs","repos_url":"https://api.github.com/users/michaelbausor/repos","events_url":"https://api.github.com/users/michaelbausor/events{/privacy}","received_events_url":"https://api.github.com/users/michaelbausor/received_events","type":"User","site_admin":false},"body":"Creates a new pipeline called GapicClientBatchPipeline which generates multiple API and language combinations.\r\n\r\nThis pipeline uses a new config file at `googleapis/gapic/batch/staging.yaml` (see https://github.com/googleapis/googleapis/pull/96)\r\n\r\nGeneration by the batch task can be toggled in the artman yaml file for each API, and in the artman language yaml for each language.\r\n\r\nThis PR also includes:\r\n- Modifying task factories to return a list of task classes, which are instantiated separately\r\n- Simplifies creation of dummy files in test","created_at":"2016-08-19T23:39:05Z","updated_at":"2016-08-29T19:31:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0b5a83738011130eeedbc5842716334036b36776","assignee":{"login":"bjwatson","id":471755,"avatar_url":"https://avatars.githubusercontent.com/u/471755?v=3","gravatar_id":"","url":"https://api.github.com/users/bjwatson","html_url":"https://github.com/bjwatson","followers_url":"https://api.github.com/users/bjwatson/followers","following_url":"https://api.github.com/users/bjwatson/following{/other_user}","gists_url":"https://api.github.com/users/bjwatson/gists{/gist_id}","starred_url":"https://api.github.com/users/bjwatson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjwatson/subscriptions","organizations_url":"https://api.github.com/users/bjwatson/orgs","repos_url":"https://api.github.com/users/bjwatson/repos","events_url":"https://api.github.com/users/bjwatson/events{/privacy}","received_events_url":"https://api.github.com/users/bjwatson/received_events","type":"User","site_admin":false},"assignees":[{"login":"bjwatson","id":471755,"avatar_url":"https://avatars.githubusercontent.com/u/471755?v=3","gravatar_id":"","url":"https://api.github.com/users/bjwatson","html_url":"https://github.com/bjwatson","followers_url":"https://api.github.com/users/bjwatson/followers","following_url":"https://api.github.com/users/bjwatson/following{/other_user}","gists_url":"https://api.github.com/users/bjwatson/gists{/gist_id}","starred_url":"https://api.github.com/users/bjwatson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjwatson/subscriptions","organizations_url":"https://api.github.com/users/bjwatson/orgs","repos_url":"https://api.github.com/users/bjwatson/repos","events_url":"https://api.github.com/users/bjwatson/events{/privacy}","received_events_url":"https://api.github.com/users/bjwatson/received_events","type":"User","site_admin":false},{"login":"jmuk","id":816093,"avatar_url":"https://avatars.githubusercontent.com/u/816093?v=3","gravatar_id":"","url":"https://api.github.com/users/jmuk","html_url":"https://github.com/jmuk","followers_url":"https://api.github.com/users/jmuk/followers","following_url":"https://api.github.com/users/jmuk/following{/other_user}","gists_url":"https://api.github.com/users/jmuk/gists{/gist_id}","starred_url":"https://api.github.com/users/jmuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmuk/subscriptions","organizations_url":"https://api.github.com/users/jmuk/orgs","repos_url":"https://api.github.com/users/jmuk/repos","events_url":"https://api.github.com/users/jmuk/events{/privacy}","received_events_url":"https://api.github.com/users/jmuk/received_events","type":"User","site_admin":false},{"login":"ethanbao","id":11670828,"avatar_url":"https://avatars.githubusercontent.com/u/11670828?v=3","gravatar_id":"","url":"https://api.github.com/users/ethanbao","html_url":"https://github.com/ethanbao","followers_url":"https://api.github.com/users/ethanbao/followers","following_url":"https://api.github.com/users/ethanbao/following{/other_user}","gists_url":"https://api.github.com/users/ethanbao/gists{/gist_id}","starred_url":"https://api.github.com/users/ethanbao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethanbao/subscriptions","organizations_url":"https://api.github.com/users/ethanbao/orgs","repos_url":"https://api.github.com/users/ethanbao/repos","events_url":"https://api.github.com/users/ethanbao/events{/privacy}","received_events_url":"https://api.github.com/users/ethanbao/received_events","type":"User","site_admin":false},{"login":"garrettjonesgoogle","id":13341017,"avatar_url":"https://avatars.githubusercontent.com/u/13341017?v=3","gravatar_id":"","url":"https://api.github.com/users/garrettjonesgoogle","html_url":"https://github.com/garrettjonesgoogle","followers_url":"https://api.github.com/users/garrettjonesgoogle/followers","following_url":"https://api.github.com/users/garrettjonesgoogle/following{/other_user}","gists_url":"https://api.github.com/users/garrettjonesgoogle/gists{/gist_id}","starred_url":"https://api.github.com/users/garrettjonesgoogle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garrettjonesgoogle/subscriptions","organizations_url":"https://api.github.com/users/garrettjonesgoogle/orgs","repos_url":"https://api.github.com/users/garrettjonesgoogle/repos","events_url":"https://api.github.com/users/garrettjonesgoogle/events{/privacy}","received_events_url":"https://api.github.com/users/garrettjonesgoogle/received_events","type":"User","site_admin":false},{"login":"geigerj","id":14222439,"avatar_url":"https://avatars.githubusercontent.com/u/14222439?v=3","gravatar_id":"","url":"https://api.github.com/users/geigerj","html_url":"https://github.com/geigerj","followers_url":"https://api.github.com/users/geigerj/followers","following_url":"https://api.github.com/users/geigerj/following{/other_user}","gists_url":"https://api.github.com/users/geigerj/gists{/gist_id}","starred_url":"https://api.github.com/users/geigerj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geigerj/subscriptions","organizations_url":"https://api.github.com/users/geigerj/orgs","repos_url":"https://api.github.com/users/geigerj/repos","events_url":"https://api.github.com/users/geigerj/events{/privacy}","received_events_url":"https://api.github.com/users/geigerj/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/googleapis/artman/pulls/68/commits","review_comments_url":"https://api.github.com/repos/googleapis/artman/pulls/68/comments","review_comment_url":"https://api.github.com/repos/googleapis/artman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googleapis/artman/issues/68/comments","statuses_url":"https://api.github.com/repos/googleapis/artman/statuses/2bfd5faa121238eabdffb85e7d3be1e3dc88b317","head":{"label":"michaelbausor:pipeline-batch","ref":"pipeline-batch","sha":"2bfd5faa121238eabdffb85e7d3be1e3dc88b317","user":{"login":"michaelbausor","id":14846209,"avatar_url":"https://avatars.githubusercontent.com/u/14846209?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelbausor","html_url":"https://github.com/michaelbausor","followers_url":"https://api.github.com/users/michaelbausor/followers","following_url":"https://api.github.com/users/michaelbausor/following{/other_user}","gists_url":"https://api.github.com/users/michaelbausor/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelbausor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelbausor/subscriptions","organizations_url":"https://api.github.com/users/michaelbausor/orgs","repos_url":"https://api.github.com/users/michaelbausor/repos","events_url":"https://api.github.com/users/michaelbausor/events{/privacy}","received_events_url":"https://api.github.com/users/michaelbausor/received_events","type":"User","site_admin":false},"repo":{"id":55555691,"name":"artman","full_name":"michaelbausor/artman","owner":{"login":"michaelbausor","id":14846209,"avatar_url":"https://avatars.githubusercontent.com/u/14846209?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelbausor","html_url":"https://github.com/michaelbausor","followers_url":"https://api.github.com/users/michaelbausor/followers","following_url":"https://api.github.com/users/michaelbausor/following{/other_user}","gists_url":"https://api.github.com/users/michaelbausor/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelbausor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelbausor/subscriptions","organizations_url":"https://api.github.com/users/michaelbausor/orgs","repos_url":"https://api.github.com/users/michaelbausor/repos","events_url":"https://api.github.com/users/michaelbausor/events{/privacy}","received_events_url":"https://api.github.com/users/michaelbausor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/michaelbausor/artman","description":"","fork":true,"url":"https://api.github.com/repos/michaelbausor/artman","forks_url":"https://api.github.com/repos/michaelbausor/artman/forks","keys_url":"https://api.github.com/repos/michaelbausor/artman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/michaelbausor/artman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/michaelbausor/artman/teams","hooks_url":"https://api.github.com/repos/michaelbausor/artman/hooks","issue_events_url":"https://api.github.com/repos/michaelbausor/artman/issues/events{/number}","events_url":"https://api.github.com/repos/michaelbausor/artman/events","assignees_url":"https://api.github.com/repos/michaelbausor/artman/assignees{/user}","branches_url":"https://api.github.com/repos/michaelbausor/artman/branches{/branch}","tags_url":"https://api.github.com/repos/michaelbausor/artman/tags","blobs_url":"https://api.github.com/repos/michaelbausor/artman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/michaelbausor/artman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/michaelbausor/artman/git/refs{/sha}","trees_url":"https://api.github.com/repos/michaelbausor/artman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/michaelbausor/artman/statuses/{sha}","languages_url":"https://api.github.com/repos/michaelbausor/artman/languages","stargazers_url":"https://api.github.com/repos/michaelbausor/artman/stargazers","contributors_url":"https://api.github.com/repos/michaelbausor/artman/contributors","subscribers_url":"https://api.github.com/repos/michaelbausor/artman/subscribers","subscription_url":"https://api.github.com/repos/michaelbausor/artman/subscription","commits_url":"https://api.github.com/repos/michaelbausor/artman/commits{/sha}","git_commits_url":"https://api.github.com/repos/michaelbausor/artman/git/commits{/sha}","comments_url":"https://api.github.com/repos/michaelbausor/artman/comments{/number}","issue_comment_url":"https://api.github.com/repos/michaelbausor/artman/issues/comments{/number}","contents_url":"https://api.github.com/repos/michaelbausor/artman/contents/{+path}","compare_url":"https://api.github.com/repos/michaelbausor/artman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/michaelbausor/artman/merges","archive_url":"https://api.github.com/repos/michaelbausor/artman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/michaelbausor/artman/downloads","issues_url":"https://api.github.com/repos/michaelbausor/artman/issues{/number}","pulls_url":"https://api.github.com/repos/michaelbausor/artman/pulls{/number}","milestones_url":"https://api.github.com/repos/michaelbausor/artman/milestones{/number}","notifications_url":"https://api.github.com/repos/michaelbausor/artman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/michaelbausor/artman/labels{/name}","releases_url":"https://api.github.com/repos/michaelbausor/artman/releases{/id}","deployments_url":"https://api.github.com/repos/michaelbausor/artman/deployments","created_at":"2016-04-05T21:45:25Z","updated_at":"2016-05-02T21:37:16Z","pushed_at":"2016-08-26T21:47:25Z","git_url":"git://github.com/michaelbausor/artman.git","ssh_url":"git@github.com:michaelbausor/artman.git","clone_url":"https://github.com/michaelbausor/artman.git","svn_url":"https://github.com/michaelbausor/artman","homepage":null,"size":321,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"googleapis:master","ref":"master","sha":"89695ad1b819cfb9c725c1206e7d6767cf7ae12d","user":{"login":"googleapis","id":16785467,"avatar_url":"https://avatars.githubusercontent.com/u/16785467?v=3","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"repo":{"id":55101236,"name":"artman","full_name":"googleapis/artman","owner":{"login":"googleapis","id":16785467,"avatar_url":"https://avatars.githubusercontent.com/u/16785467?v=3","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googleapis/artman","description":"Google API Artifact manager","fork":false,"url":"https://api.github.com/repos/googleapis/artman","forks_url":"https://api.github.com/repos/googleapis/artman/forks","keys_url":"https://api.github.com/repos/googleapis/artman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googleapis/artman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googleapis/artman/teams","hooks_url":"https://api.github.com/repos/googleapis/artman/hooks","issue_events_url":"https://api.github.com/repos/googleapis/artman/issues/events{/number}","events_url":"https://api.github.com/repos/googleapis/artman/events","assignees_url":"https://api.github.com/repos/googleapis/artman/assignees{/user}","branches_url":"https://api.github.com/repos/googleapis/artman/branches{/branch}","tags_url":"https://api.github.com/repos/googleapis/artman/tags","blobs_url":"https://api.github.com/repos/googleapis/artman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googleapis/artman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googleapis/artman/git/refs{/sha}","trees_url":"https://api.github.com/repos/googleapis/artman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googleapis/artman/statuses/{sha}","languages_url":"https://api.github.com/repos/googleapis/artman/languages","stargazers_url":"https://api.github.com/repos/googleapis/artman/stargazers","contributors_url":"https://api.github.com/repos/googleapis/artman/contributors","subscribers_url":"https://api.github.com/repos/googleapis/artman/subscribers","subscription_url":"https://api.github.com/repos/googleapis/artman/subscription","commits_url":"https://api.github.com/repos/googleapis/artman/commits{/sha}","git_commits_url":"https://api.github.com/repos/googleapis/artman/git/commits{/sha}","comments_url":"https://api.github.com/repos/googleapis/artman/comments{/number}","issue_comment_url":"https://api.github.com/repos/googleapis/artman/issues/comments{/number}","contents_url":"https://api.github.com/repos/googleapis/artman/contents/{+path}","compare_url":"https://api.github.com/repos/googleapis/artman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googleapis/artman/merges","archive_url":"https://api.github.com/repos/googleapis/artman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googleapis/artman/downloads","issues_url":"https://api.github.com/repos/googleapis/artman/issues{/number}","pulls_url":"https://api.github.com/repos/googleapis/artman/pulls{/number}","milestones_url":"https://api.github.com/repos/googleapis/artman/milestones{/number}","notifications_url":"https://api.github.com/repos/googleapis/artman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googleapis/artman/labels{/name}","releases_url":"https://api.github.com/repos/googleapis/artman/releases{/id}","deployments_url":"https://api.github.com/repos/googleapis/artman/deployments","created_at":"2016-03-30T22:09:32Z","updated_at":"2016-08-25T13:45:24Z","pushed_at":"2016-08-27T01:11:22Z","git_url":"git://github.com/googleapis/artman.git","ssh_url":"git@github.com:googleapis/artman.git","clone_url":"https://github.com/googleapis/artman.git","svn_url":"https://github.com/googleapis/artman","homepage":"","size":418,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":17,"forks":13,"open_issues":17,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googleapis/artman/pulls/68"},"html":{"href":"https://github.com/googleapis/artman/pull/68"},"issue":{"href":"https://api.github.com/repos/googleapis/artman/issues/68"},"comments":{"href":"https://api.github.com/repos/googleapis/artman/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/googleapis/artman/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/googleapis/artman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googleapis/artman/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/googleapis/artman/statuses/2bfd5faa121238eabdffb85e7d3be1e3dc88b317"}}}}
{"actor":{"display_login":"garrettjonesgoogle"}}