{"action":"created","issue":{"url":"https://api.github.com/repos/zestedesavoir/zds-site/issues/3924","repository_url":"https://api.github.com/repos/zestedesavoir/zds-site","labels_url":"https://api.github.com/repos/zestedesavoir/zds-site/issues/3924/labels{/name}","comments_url":"https://api.github.com/repos/zestedesavoir/zds-site/issues/3924/comments","events_url":"https://api.github.com/repos/zestedesavoir/zds-site/issues/3924/events","html_url":"https://github.com/zestedesavoir/zds-site/issues/3924","id":186140473,"number":3924,"title":"Les tests unitaires ne passent plus depuis le changement d'heure","user":{"login":"DevHugo","id":6099338,"avatar_url":"https://avatars.githubusercontent.com/u/6099338?v=3","gravatar_id":"","url":"https://api.github.com/users/DevHugo","html_url":"https://github.com/DevHugo","followers_url":"https://api.github.com/users/DevHugo/followers","following_url":"https://api.github.com/users/DevHugo/following{/other_user}","gists_url":"https://api.github.com/users/DevHugo/gists{/gist_id}","starred_url":"https://api.github.com/users/DevHugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevHugo/subscriptions","organizations_url":"https://api.github.com/users/DevHugo/orgs","repos_url":"https://api.github.com/users/DevHugo/repos","events_url":"https://api.github.com/users/DevHugo/events{/privacy}","received_events_url":"https://api.github.com/users/DevHugo/received_events","type":"User","site_admin":false},"labels":[{"id":104879870,"url":"https://api.github.com/repos/zestedesavoir/zds-site/labels/C-Back","name":"C-Back","color":"207de5","default":false},{"id":411494231,"url":"https://api.github.com/repos/zestedesavoir/zds-site/labels/P-Haute","name":"P-Haute","color":"5319e7","default":false},{"id":104709492,"url":"https://api.github.com/repos/zestedesavoir/zds-site/labels/S-R%C3%A9gression","name":"S-Régression","color":"e11d21","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-10-30T14:44:44Z","updated_at":"2016-10-31T10:44:00Z","closed_at":"2016-10-31T10:11:06Z","body":"Bonjour,\n\nLe test unitaire `\"test_humane_time\"(ligne 118)` dans le fichier `\"zds-site/zds/utils/templatetags/tests/tests_date.py\"` ne passe plus à cause du changement d’horaire !\n\n`Cause: AssertionError: u'jeudi 01 janvier 1970 \\xe0 01h00' != u'jeudi 01 janvier 1970 \\xe0 00h00'`\n\n[Exemple de build qui ne passe plus.](https://travis-ci.org/zestedesavoir/zds-site/jobs/171775668)\n"},"comment":{"url":"https://api.github.com/repos/zestedesavoir/zds-site/issues/comments/257262914","html_url":"https://github.com/zestedesavoir/zds-site/issues/3924#issuecomment-257262914","issue_url":"https://api.github.com/repos/zestedesavoir/zds-site/issues/3924","id":257262914,"user":{"login":"pquentin","id":42327,"avatar_url":"https://avatars.githubusercontent.com/u/42327?v=3","gravatar_id":"","url":"https://api.github.com/users/pquentin","html_url":"https://github.com/pquentin","followers_url":"https://api.github.com/users/pquentin/followers","following_url":"https://api.github.com/users/pquentin/following{/other_user}","gists_url":"https://api.github.com/users/pquentin/gists{/gist_id}","starred_url":"https://api.github.com/users/pquentin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pquentin/subscriptions","organizations_url":"https://api.github.com/users/pquentin/orgs","repos_url":"https://api.github.com/users/pquentin/repos","events_url":"https://api.github.com/users/pquentin/events{/privacy}","received_events_url":"https://api.github.com/users/pquentin/received_events","type":"User","site_admin":false},"created_at":"2016-10-31T10:44:00Z","updated_at":"2016-10-31T10:44:00Z","body":"Je suis dans le fuseau horaire Indian/Reunion, et voilà ce que ton code donne pour moi :\r\n\r\n```>>> import datetime\r\n>>> t = datetime.datetime.fromtimestamp(42)\r\n>>> print(t)\r\n1970-01-01 04:00:42```\r\n\r\nÇa veut dire qu'au timestamp 42, il était 1h du matin à Paris et 4h du matin à l'île de la Réunion. Et ça ne dépend effectivement pas du fuseau horaire au moment où on exécute le code, donc ce test était effectivement mauvais, désolé. Il aurait fallu mocker le temps pour s'assurer que cet test était valide.\r\n\r\n(Je suis désolé pour ce test, mais je suis toujours aussi fier du reste du code, de la pull request à GitPython et de mon message de commit que j'ai trouvé limpide un an après l'avoir écrit. Donc ça valait le coup de faire du zèle.)"}}
{"actor":{"display_login":"pquentin"}}