{"action":"created","issue":{"url":"https://api.github.com/repos/thp/psmoveapi/issues/183","repository_url":"https://api.github.com/repos/thp/psmoveapi","labels_url":"https://api.github.com/repos/thp/psmoveapi/issues/183/labels{/name}","comments_url":"https://api.github.com/repos/thp/psmoveapi/issues/183/comments","events_url":"https://api.github.com/repos/thp/psmoveapi/issues/183/events","html_url":"https://github.com/thp/psmoveapi/issues/183","id":95548317,"number":183,"title":"auto dimming seems broken","user":{"login":"cboulay","id":303797,"avatar_url":"https://avatars.githubusercontent.com/u/303797?v=3","gravatar_id":"","url":"https://api.github.com/users/cboulay","html_url":"https://github.com/cboulay","followers_url":"https://api.github.com/users/cboulay/followers","following_url":"https://api.github.com/users/cboulay/following{/other_user}","gists_url":"https://api.github.com/users/cboulay/gists{/gist_id}","starred_url":"https://api.github.com/users/cboulay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cboulay/subscriptions","organizations_url":"https://api.github.com/users/cboulay/orgs","repos_url":"https://api.github.com/users/cboulay/repos","events_url":"https://api.github.com/users/cboulay/events{/privacy}","received_events_url":"https://api.github.com/users/cboulay/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-07-16T22:55:53Z","updated_at":"2016-05-17T17:31:34Z","closed_at":"2016-05-17T17:31:34Z","body":"[This chunk of code](https://github.com/thp/psmoveapi/blob/master/src/tracker/psmove_tracker.c#L957-L968) suggests to me that you are checking to see if the average colour in the illuminated sphere has a saturation of > 128, then stop, we're good with this dimming. However, if the saturation is less, then make the sphere dimmer! What!? Am I missing something?\r\n\r\nAlso, what's the point anyway? Why not always use maximum brightness? Under what circumstances would making the sphere less-bright give you better tracking?\r\n\r\nIf it's meant to give you better battery life, then wouldn't you want to start at the lower range of dimming then increase until you crossed 128?\r\n\r\nP.S. While you're looking at this section of code, I think [line 936](https://github.com/thp/psmoveapi/blob/master/src/tracker/psmove_tracker.c#L936) is supposed to have `mask` here instead of `diffs[0]`."},"comment":{"url":"https://api.github.com/repos/thp/psmoveapi/issues/comments/219793121","html_url":"https://github.com/thp/psmoveapi/issues/183#issuecomment-219793121","issue_url":"https://api.github.com/repos/thp/psmoveapi/issues/183","id":219793121,"user":{"login":"thp","id":135241,"avatar_url":"https://avatars.githubusercontent.com/u/135241?v=3","gravatar_id":"","url":"https://api.github.com/users/thp","html_url":"https://github.com/thp","followers_url":"https://api.github.com/users/thp/followers","following_url":"https://api.github.com/users/thp/following{/other_user}","gists_url":"https://api.github.com/users/thp/gists{/gist_id}","starred_url":"https://api.github.com/users/thp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thp/subscriptions","organizations_url":"https://api.github.com/users/thp/orgs","repos_url":"https://api.github.com/users/thp/repos","events_url":"https://api.github.com/users/thp/events{/privacy}","received_events_url":"https://api.github.com/users/thp/received_events","type":"User","site_admin":false},"created_at":"2016-05-17T17:31:34Z","updated_at":"2016-05-17T17:31:34Z","body":"The initial thing with reducing brightness was in cases where the sphere when too brightly lit would appear as white in the camera image, and reducing the brightness would lead to the sphere eventually appearing colored. This must have been with dark rooms where the exposure was set very high (to lighten up the surroundings) which caused the controller to light at full intensity.\r\n\r\nClosing this in favor of #208, let's continue the discussion there."}}