{"action":"created","issue":{"url":"https://api.github.com/repos/AlternC/alternc-mailman/issues/1","repository_url":"https://api.github.com/repos/AlternC/alternc-mailman","labels_url":"https://api.github.com/repos/AlternC/alternc-mailman/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/AlternC/alternc-mailman/issues/1/comments","events_url":"https://api.github.com/repos/AlternC/alternc-mailman/issues/1/events","html_url":"https://github.com/AlternC/alternc-mailman/issues/1","id":148184059,"number":1,"title":"a new list with a ` in the password will result in a crashing cronjob every minute","user":{"login":"lelutin","id":108728,"avatar_url":"https://avatars.githubusercontent.com/u/108728?v=3","gravatar_id":"","url":"https://api.github.com/users/lelutin","html_url":"https://github.com/lelutin","followers_url":"https://api.github.com/users/lelutin/followers","following_url":"https://api.github.com/users/lelutin/following{/other_user}","gists_url":"https://api.github.com/users/lelutin/gists{/gist_id}","starred_url":"https://api.github.com/users/lelutin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lelutin/subscriptions","organizations_url":"https://api.github.com/users/lelutin/orgs","repos_url":"https://api.github.com/users/lelutin/repos","events_url":"https://api.github.com/users/lelutin/events{/privacy}","received_events_url":"https://api.github.com/users/lelutin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-04-13T21:09:45Z","updated_at":"2016-05-05T22:03:51Z","closed_at":null,"body":"The password field is either too permissive with its contents or the way the password is being set is problematic. in any case, when a new mailing list is created and a backtick is present in the password, the update_mailman.sh cronjob will crash on every run.\r\n\r\nthis is caused by the way \"newlist\" is called here: https://github.com/AlternC/alternc-mailman/blob/088df951fd41b6cfddf6062d68acda49300fb7f4/src/update_mailman.sh#L44\r\n\r\nthe backtick gets interpreted and sh complains about a syntax error.\r\n\r\nI don't know yet if that might have security implications too: I haven't tested whether shell injection is possible through the password, but I surmise it probably is.\r\n\r\nmy suggestion would be to make alternc reject passwords that contain a backtick.\r\n\r\nnote: this might be applicable to double quotes too"},"comment":{"url":"https://api.github.com/repos/AlternC/alternc-mailman/issues/comments/217293068","html_url":"https://github.com/AlternC/alternc-mailman/issues/1#issuecomment-217293068","issue_url":"https://api.github.com/repos/AlternC/alternc-mailman/issues/1","id":217293068,"user":{"login":"lelutin","id":108728,"avatar_url":"https://avatars.githubusercontent.com/u/108728?v=3","gravatar_id":"","url":"https://api.github.com/users/lelutin","html_url":"https://github.com/lelutin","followers_url":"https://api.github.com/users/lelutin/followers","following_url":"https://api.github.com/users/lelutin/following{/other_user}","gists_url":"https://api.github.com/users/lelutin/gists{/gist_id}","starred_url":"https://api.github.com/users/lelutin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lelutin/subscriptions","organizations_url":"https://api.github.com/users/lelutin/orgs","repos_url":"https://api.github.com/users/lelutin/repos","events_url":"https://api.github.com/users/lelutin/events{/privacy}","received_events_url":"https://api.github.com/users/lelutin/received_events","type":"User","site_admin":false},"created_at":"2016-05-05T22:03:51Z","updated_at":"2016-05-05T22:03:51Z","body":"la modification n'a pas fonctionné: j'obtenais l'erreur suivante dans le retour email de la cronjob:\r\n\r\n~~~\r\n-su: /usr/lib/mailman/bin/newlist -q 'navet@compte123.koumbit.org' 'navet@koumbit.org' '': Aucun fichier ou dossier de ce type\r\n~~~\r\n\r\npour tenter de faire fonctionner le script j'ai retiré les \\\" à l'intérieur du printf, mais alors la commande de création de liste a réussie mais la commande insérée dans le mot de passe a tout de même été interprétée.\r\n\r\ndonc retour à la case départ.."}}