{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/65275294","id":65275294,"diff_hunk":"@@ -1870,11 +1870,16 @@ namespace UnifiedRegex\n     }\n #endif\n \n-    const int  CharSetNode::directBits;\n+\t// The VS2013 linker treats this as a redefinition of an already\n+\t// defined constant and complains. So skip the declaration if we're compiling\n+\t// with VS2013 or below.\n+#if !defined(_MSC_VER) || _MSC_VER >= 1900\n+\tconst int  CharSetNode::directBits;","path":"lib/Parser/CharSet.cpp","position":9,"original_position":9,"commit_id":"01817a16a6ec3b5faeb09c6600382621bb65fcbc","original_commit_id":"01817a16a6ec3b5faeb09c6600382621bb65fcbc","user":{"login":"jianchun","id":11861955,"avatar_url":"https://avatars.githubusercontent.com/u/11861955?v=3","gravatar_id":"","url":"https://api.github.com/users/jianchun","html_url":"https://github.com/jianchun","followers_url":"https://api.github.com/users/jianchun/followers","following_url":"https://api.github.com/users/jianchun/following{/other_user}","gists_url":"https://api.github.com/users/jianchun/gists{/gist_id}","starred_url":"https://api.github.com/users/jianchun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jianchun/subscriptions","organizations_url":"https://api.github.com/users/jianchun/orgs","repos_url":"https://api.github.com/users/jianchun/repos","events_url":"https://api.github.com/users/jianchun/events{/privacy}","received_events_url":"https://api.github.com/users/jianchun/received_events","type":"User","site_admin":false},"body":"tab?","created_at":"2016-05-31T22:35:18Z","updated_at":"2016-05-31T22:35:18Z","html_url":"https://github.com/Microsoft/ChakraCore/pull/1067#discussion_r65275294","pull_request_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1067","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/65275294"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/1067#discussion_r65275294"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1067"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1067","id":72089324,"html_url":"https://github.com/Microsoft/ChakraCore/pull/1067","diff_url":"https://github.com/Microsoft/ChakraCore/pull/1067.diff","patch_url":"https://github.com/Microsoft/ChakraCore/pull/1067.patch","issue_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1067","number":1067,"state":"open","locked":false,"title":"Fix dev12 build","user":{"login":"digitalinfinity","id":158390,"avatar_url":"https://avatars.githubusercontent.com/u/158390?v=3","gravatar_id":"","url":"https://api.github.com/users/digitalinfinity","html_url":"https://github.com/digitalinfinity","followers_url":"https://api.github.com/users/digitalinfinity/followers","following_url":"https://api.github.com/users/digitalinfinity/following{/other_user}","gists_url":"https://api.github.com/users/digitalinfinity/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalinfinity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalinfinity/subscriptions","organizations_url":"https://api.github.com/users/digitalinfinity/orgs","repos_url":"https://api.github.com/users/digitalinfinity/repos","events_url":"https://api.github.com/users/digitalinfinity/events{/privacy}","received_events_url":"https://api.github.com/users/digitalinfinity/received_events","type":"User","site_admin":false},"body":"The dev12 toolset was unhappy with the redeclaration of class static\nconstants, that was done to satisfy clang. Dev12 treats the second\ndeclaration as a second definition and makes the linker unhappy.\nConditionally compiled out the redeclarations on dev12.\n","created_at":"2016-05-31T21:31:42Z","updated_at":"2016-05-31T22:35:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3dcb4d09045ee3c773f8a4d57d34b7b672528f21","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1067/commits","review_comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1067/comments","review_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1067/comments","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/01817a16a6ec3b5faeb09c6600382621bb65fcbc","head":{"label":"digitalinfinity:build/hiteshk/dev12_fixes","ref":"build/hiteshk/dev12_fixes","sha":"01817a16a6ec3b5faeb09c6600382621bb65fcbc","user":{"login":"digitalinfinity","id":158390,"avatar_url":"https://avatars.githubusercontent.com/u/158390?v=3","gravatar_id":"","url":"https://api.github.com/users/digitalinfinity","html_url":"https://github.com/digitalinfinity","followers_url":"https://api.github.com/users/digitalinfinity/followers","following_url":"https://api.github.com/users/digitalinfinity/following{/other_user}","gists_url":"https://api.github.com/users/digitalinfinity/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalinfinity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalinfinity/subscriptions","organizations_url":"https://api.github.com/users/digitalinfinity/orgs","repos_url":"https://api.github.com/users/digitalinfinity/repos","events_url":"https://api.github.com/users/digitalinfinity/events{/privacy}","received_events_url":"https://api.github.com/users/digitalinfinity/received_events","type":"User","site_admin":false},"repo":{"id":51317761,"name":"ChakraCore","full_name":"digitalinfinity/ChakraCore","owner":{"login":"digitalinfinity","id":158390,"avatar_url":"https://avatars.githubusercontent.com/u/158390?v=3","gravatar_id":"","url":"https://api.github.com/users/digitalinfinity","html_url":"https://github.com/digitalinfinity","followers_url":"https://api.github.com/users/digitalinfinity/followers","following_url":"https://api.github.com/users/digitalinfinity/following{/other_user}","gists_url":"https://api.github.com/users/digitalinfinity/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalinfinity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalinfinity/subscriptions","organizations_url":"https://api.github.com/users/digitalinfinity/orgs","repos_url":"https://api.github.com/users/digitalinfinity/repos","events_url":"https://api.github.com/users/digitalinfinity/events{/privacy}","received_events_url":"https://api.github.com/users/digitalinfinity/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/digitalinfinity/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":true,"url":"https://api.github.com/repos/digitalinfinity/ChakraCore","forks_url":"https://api.github.com/repos/digitalinfinity/ChakraCore/forks","keys_url":"https://api.github.com/repos/digitalinfinity/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/digitalinfinity/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/digitalinfinity/ChakraCore/teams","hooks_url":"https://api.github.com/repos/digitalinfinity/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/digitalinfinity/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/digitalinfinity/ChakraCore/events","assignees_url":"https://api.github.com/repos/digitalinfinity/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/digitalinfinity/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/digitalinfinity/ChakraCore/tags","blobs_url":"https://api.github.com/repos/digitalinfinity/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/digitalinfinity/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/digitalinfinity/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/digitalinfinity/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/digitalinfinity/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/digitalinfinity/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/digitalinfinity/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/digitalinfinity/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/digitalinfinity/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/digitalinfinity/ChakraCore/subscription","commits_url":"https://api.github.com/repos/digitalinfinity/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/digitalinfinity/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/digitalinfinity/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/digitalinfinity/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/digitalinfinity/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/digitalinfinity/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/digitalinfinity/ChakraCore/merges","archive_url":"https://api.github.com/repos/digitalinfinity/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/digitalinfinity/ChakraCore/downloads","issues_url":"https://api.github.com/repos/digitalinfinity/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/digitalinfinity/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/digitalinfinity/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/digitalinfinity/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/digitalinfinity/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/digitalinfinity/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/digitalinfinity/ChakraCore/deployments","created_at":"2016-02-08T18:38:27Z","updated_at":"2016-03-11T01:41:49Z","pushed_at":"2016-05-31T21:31:41Z","git_url":"git://github.com/digitalinfinity/ChakraCore.git","ssh_url":"git@github.com:digitalinfinity/ChakraCore.git","clone_url":"https://github.com/digitalinfinity/ChakraCore.git","svn_url":"https://github.com/digitalinfinity/ChakraCore","homepage":null,"size":31226,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"658d94710d2742801ca5e4f0a8b3ed473c4506e7","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":49086513,"name":"ChakraCore","full_name":"Microsoft/ChakraCore","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":false,"url":"https://api.github.com/repos/Microsoft/ChakraCore","forks_url":"https://api.github.com/repos/Microsoft/ChakraCore/forks","keys_url":"https://api.github.com/repos/Microsoft/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ChakraCore/teams","hooks_url":"https://api.github.com/repos/Microsoft/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ChakraCore/events","assignees_url":"https://api.github.com/repos/Microsoft/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/tags","blobs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscription","commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ChakraCore/merges","archive_url":"https://api.github.com/repos/Microsoft/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ChakraCore/downloads","issues_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ChakraCore/deployments","created_at":"2016-01-05T19:05:31Z","updated_at":"2016-05-31T18:04:17Z","pushed_at":"2016-05-31T21:50:00Z","git_url":"git://github.com/Microsoft/ChakraCore.git","ssh_url":"git@github.com:Microsoft/ChakraCore.git","clone_url":"https://github.com/Microsoft/ChakraCore.git","svn_url":"https://github.com/Microsoft/ChakraCore","homepage":null,"size":39499,"stargazers_count":5226,"watchers_count":5226,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":584,"mirror_url":null,"open_issues_count":137,"forks":584,"open_issues":137,"watchers":5226,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1067"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/1067"},"issue":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1067"},"comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1067/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1067/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1067/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/01817a16a6ec3b5faeb09c6600382621bb65fcbc"}}}}
{"actor":{"display_login":"jianchun"}}