{"action":"created","comment":{"url":"https://api.github.com/repos/crossbario/autobahn-python/pulls/comments/62439254","id":62439254,"diff_hunk":"@@ -2758,7 +2759,10 @@ def succeedHandshake(self, res):\n         if self.factory.server is not None and self.factory.server != \"\":\n             response += \"Server: %s\\x0d\\x0a\" % self.factory.server\n \n-        response += \"X-Powered-By: AutobahnPython/{0}\\x0d\\x0a\".format(__version__)\n+        if self.showServerVersion:\n+            response += \"X-Powered-By: AutobahnPython/{0}\\x0d\\x0a\".format(__version__)\n+        else:\n+            response += \"X-Powered-By: AutobahnPython\\x0d\\x0a\".format(__version__)","path":"autobahn/websocket/protocol.py","position":16,"original_position":16,"commit_id":"5ad3e9d0a6f02738d8ff79ed1c7131212051328f","original_commit_id":"5ad3e9d0a6f02738d8ff79ed1c7131212051328f","user":{"login":"oberstet","id":233340,"avatar_url":"https://avatars.githubusercontent.com/u/233340?v=3","gravatar_id":"","url":"https://api.github.com/users/oberstet","html_url":"https://github.com/oberstet","followers_url":"https://api.github.com/users/oberstet/followers","following_url":"https://api.github.com/users/oberstet/following{/other_user}","gists_url":"https://api.github.com/users/oberstet/gists{/gist_id}","starred_url":"https://api.github.com/users/oberstet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oberstet/subscriptions","organizations_url":"https://api.github.com/users/oberstet/orgs","repos_url":"https://api.github.com/users/oberstet/repos","events_url":"https://api.github.com/users/oberstet/events{/privacy}","received_events_url":"https://api.github.com/users/oberstet/received_events","type":"User","site_admin":false},"body":"Should probably not have a __version__ formatting arg - but on the other hand, maybe do away with \"X-Powered-By\" header altogether. One server header is enough.","created_at":"2016-05-08T21:55:57Z","updated_at":"2016-05-08T21:55:57Z","html_url":"https://github.com/crossbario/autobahn-python/pull/675#discussion_r62439254","pull_request_url":"https://api.github.com/repos/crossbario/autobahn-python/pulls/675","_links":{"self":{"href":"https://api.github.com/repos/crossbario/autobahn-python/pulls/comments/62439254"},"html":{"href":"https://github.com/crossbario/autobahn-python/pull/675#discussion_r62439254"},"pull_request":{"href":"https://api.github.com/repos/crossbario/autobahn-python/pulls/675"}}},"pull_request":{"url":"https://api.github.com/repos/crossbario/autobahn-python/pulls/675","id":69053155,"html_url":"https://github.com/crossbario/autobahn-python/pull/675","diff_url":"https://github.com/crossbario/autobahn-python/pull/675.diff","patch_url":"https://github.com/crossbario/autobahn-python/pull/675.patch","issue_url":"https://api.github.com/repos/crossbario/autobahn-python/issues/675","number":675,"state":"open","locked":false,"title":"Add showServerVersion controlling full/partial version in headers","user":{"login":"meejah","id":145599,"avatar_url":"https://avatars.githubusercontent.com/u/145599?v=3","gravatar_id":"","url":"https://api.github.com/users/meejah","html_url":"https://github.com/meejah","followers_url":"https://api.github.com/users/meejah/followers","following_url":"https://api.github.com/users/meejah/following{/other_user}","gists_url":"https://api.github.com/users/meejah/gists{/gist_id}","starred_url":"https://api.github.com/users/meejah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meejah/subscriptions","organizations_url":"https://api.github.com/users/meejah/orgs","repos_url":"https://api.github.com/users/meejah/repos","events_url":"https://api.github.com/users/meejah/events{/privacy}","received_events_url":"https://api.github.com/users/meejah/received_events","type":"User","site_admin":false},"body":"This defaults to False, and so will only show that we're using \"Autobahn\" and not the precise version.\r\n\r\n(See https://github.com/crossbario/crossbar/issues/770 for discussion)","created_at":"2016-05-05T19:02:22Z","updated_at":"2016-05-08T21:55:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"90f55be9376763d1974b184b2432eb711fd25b00","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crossbario/autobahn-python/pulls/675/commits","review_comments_url":"https://api.github.com/repos/crossbario/autobahn-python/pulls/675/comments","review_comment_url":"https://api.github.com/repos/crossbario/autobahn-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crossbario/autobahn-python/issues/675/comments","statuses_url":"https://api.github.com/repos/crossbario/autobahn-python/statuses/5ad3e9d0a6f02738d8ff79ed1c7131212051328f","head":{"label":"meejah:no-version-headers","ref":"no-version-headers","sha":"5ad3e9d0a6f02738d8ff79ed1c7131212051328f","user":{"login":"meejah","id":145599,"avatar_url":"https://avatars.githubusercontent.com/u/145599?v=3","gravatar_id":"","url":"https://api.github.com/users/meejah","html_url":"https://github.com/meejah","followers_url":"https://api.github.com/users/meejah/followers","following_url":"https://api.github.com/users/meejah/following{/other_user}","gists_url":"https://api.github.com/users/meejah/gists{/gist_id}","starred_url":"https://api.github.com/users/meejah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meejah/subscriptions","organizations_url":"https://api.github.com/users/meejah/orgs","repos_url":"https://api.github.com/users/meejah/repos","events_url":"https://api.github.com/users/meejah/events{/privacy}","received_events_url":"https://api.github.com/users/meejah/received_events","type":"User","site_admin":false},"repo":{"id":30720845,"name":"AutobahnPython","full_name":"meejah/AutobahnPython","owner":{"login":"meejah","id":145599,"avatar_url":"https://avatars.githubusercontent.com/u/145599?v=3","gravatar_id":"","url":"https://api.github.com/users/meejah","html_url":"https://github.com/meejah","followers_url":"https://api.github.com/users/meejah/followers","following_url":"https://api.github.com/users/meejah/following{/other_user}","gists_url":"https://api.github.com/users/meejah/gists{/gist_id}","starred_url":"https://api.github.com/users/meejah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meejah/subscriptions","organizations_url":"https://api.github.com/users/meejah/orgs","repos_url":"https://api.github.com/users/meejah/repos","events_url":"https://api.github.com/users/meejah/events{/privacy}","received_events_url":"https://api.github.com/users/meejah/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/meejah/AutobahnPython","description":"WebSocket & WAMP for Python on Twisted and asyncio","fork":true,"url":"https://api.github.com/repos/meejah/AutobahnPython","forks_url":"https://api.github.com/repos/meejah/AutobahnPython/forks","keys_url":"https://api.github.com/repos/meejah/AutobahnPython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meejah/AutobahnPython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meejah/AutobahnPython/teams","hooks_url":"https://api.github.com/repos/meejah/AutobahnPython/hooks","issue_events_url":"https://api.github.com/repos/meejah/AutobahnPython/issues/events{/number}","events_url":"https://api.github.com/repos/meejah/AutobahnPython/events","assignees_url":"https://api.github.com/repos/meejah/AutobahnPython/assignees{/user}","branches_url":"https://api.github.com/repos/meejah/AutobahnPython/branches{/branch}","tags_url":"https://api.github.com/repos/meejah/AutobahnPython/tags","blobs_url":"https://api.github.com/repos/meejah/AutobahnPython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meejah/AutobahnPython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meejah/AutobahnPython/git/refs{/sha}","trees_url":"https://api.github.com/repos/meejah/AutobahnPython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meejah/AutobahnPython/statuses/{sha}","languages_url":"https://api.github.com/repos/meejah/AutobahnPython/languages","stargazers_url":"https://api.github.com/repos/meejah/AutobahnPython/stargazers","contributors_url":"https://api.github.com/repos/meejah/AutobahnPython/contributors","subscribers_url":"https://api.github.com/repos/meejah/AutobahnPython/subscribers","subscription_url":"https://api.github.com/repos/meejah/AutobahnPython/subscription","commits_url":"https://api.github.com/repos/meejah/AutobahnPython/commits{/sha}","git_commits_url":"https://api.github.com/repos/meejah/AutobahnPython/git/commits{/sha}","comments_url":"https://api.github.com/repos/meejah/AutobahnPython/comments{/number}","issue_comment_url":"https://api.github.com/repos/meejah/AutobahnPython/issues/comments{/number}","contents_url":"https://api.github.com/repos/meejah/AutobahnPython/contents/{+path}","compare_url":"https://api.github.com/repos/meejah/AutobahnPython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meejah/AutobahnPython/merges","archive_url":"https://api.github.com/repos/meejah/AutobahnPython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meejah/AutobahnPython/downloads","issues_url":"https://api.github.com/repos/meejah/AutobahnPython/issues{/number}","pulls_url":"https://api.github.com/repos/meejah/AutobahnPython/pulls{/number}","milestones_url":"https://api.github.com/repos/meejah/AutobahnPython/milestones{/number}","notifications_url":"https://api.github.com/repos/meejah/AutobahnPython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meejah/AutobahnPython/labels{/name}","releases_url":"https://api.github.com/repos/meejah/AutobahnPython/releases{/id}","deployments_url":"https://api.github.com/repos/meejah/AutobahnPython/deployments","created_at":"2015-02-12T19:58:50Z","updated_at":"2016-02-03T23:20:21Z","pushed_at":"2016-05-05T19:03:52Z","git_url":"git://github.com/meejah/AutobahnPython.git","ssh_url":"git@github.com:meejah/AutobahnPython.git","clone_url":"https://github.com/meejah/AutobahnPython.git","svn_url":"https://github.com/meejah/AutobahnPython","homepage":"http://autobahn.ws/python","size":11917,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crossbario:master","ref":"master","sha":"54da8882eea3f4b1da62a6d3481556ab77720d41","user":{"login":"crossbario","id":5656948,"avatar_url":"https://avatars.githubusercontent.com/u/5656948?v=3","gravatar_id":"","url":"https://api.github.com/users/crossbario","html_url":"https://github.com/crossbario","followers_url":"https://api.github.com/users/crossbario/followers","following_url":"https://api.github.com/users/crossbario/following{/other_user}","gists_url":"https://api.github.com/users/crossbario/gists{/gist_id}","starred_url":"https://api.github.com/users/crossbario/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crossbario/subscriptions","organizations_url":"https://api.github.com/users/crossbario/orgs","repos_url":"https://api.github.com/users/crossbario/repos","events_url":"https://api.github.com/users/crossbario/events{/privacy}","received_events_url":"https://api.github.com/users/crossbario/received_events","type":"Organization","site_admin":false},"repo":{"id":2113510,"name":"autobahn-python","full_name":"crossbario/autobahn-python","owner":{"login":"crossbario","id":5656948,"avatar_url":"https://avatars.githubusercontent.com/u/5656948?v=3","gravatar_id":"","url":"https://api.github.com/users/crossbario","html_url":"https://github.com/crossbario","followers_url":"https://api.github.com/users/crossbario/followers","following_url":"https://api.github.com/users/crossbario/following{/other_user}","gists_url":"https://api.github.com/users/crossbario/gists{/gist_id}","starred_url":"https://api.github.com/users/crossbario/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crossbario/subscriptions","organizations_url":"https://api.github.com/users/crossbario/orgs","repos_url":"https://api.github.com/users/crossbario/repos","events_url":"https://api.github.com/users/crossbario/events{/privacy}","received_events_url":"https://api.github.com/users/crossbario/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crossbario/autobahn-python","description":"WebSocket & WAMP for Python on Twisted and asyncio","fork":false,"url":"https://api.github.com/repos/crossbario/autobahn-python","forks_url":"https://api.github.com/repos/crossbario/autobahn-python/forks","keys_url":"https://api.github.com/repos/crossbario/autobahn-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crossbario/autobahn-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crossbario/autobahn-python/teams","hooks_url":"https://api.github.com/repos/crossbario/autobahn-python/hooks","issue_events_url":"https://api.github.com/repos/crossbario/autobahn-python/issues/events{/number}","events_url":"https://api.github.com/repos/crossbario/autobahn-python/events","assignees_url":"https://api.github.com/repos/crossbario/autobahn-python/assignees{/user}","branches_url":"https://api.github.com/repos/crossbario/autobahn-python/branches{/branch}","tags_url":"https://api.github.com/repos/crossbario/autobahn-python/tags","blobs_url":"https://api.github.com/repos/crossbario/autobahn-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crossbario/autobahn-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crossbario/autobahn-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/crossbario/autobahn-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crossbario/autobahn-python/statuses/{sha}","languages_url":"https://api.github.com/repos/crossbario/autobahn-python/languages","stargazers_url":"https://api.github.com/repos/crossbario/autobahn-python/stargazers","contributors_url":"https://api.github.com/repos/crossbario/autobahn-python/contributors","subscribers_url":"https://api.github.com/repos/crossbario/autobahn-python/subscribers","subscription_url":"https://api.github.com/repos/crossbario/autobahn-python/subscription","commits_url":"https://api.github.com/repos/crossbario/autobahn-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/crossbario/autobahn-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/crossbario/autobahn-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/crossbario/autobahn-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/crossbario/autobahn-python/contents/{+path}","compare_url":"https://api.github.com/repos/crossbario/autobahn-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crossbario/autobahn-python/merges","archive_url":"https://api.github.com/repos/crossbario/autobahn-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crossbario/autobahn-python/downloads","issues_url":"https://api.github.com/repos/crossbario/autobahn-python/issues{/number}","pulls_url":"https://api.github.com/repos/crossbario/autobahn-python/pulls{/number}","milestones_url":"https://api.github.com/repos/crossbario/autobahn-python/milestones{/number}","notifications_url":"https://api.github.com/repos/crossbario/autobahn-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crossbario/autobahn-python/labels{/name}","releases_url":"https://api.github.com/repos/crossbario/autobahn-python/releases{/id}","deployments_url":"https://api.github.com/repos/crossbario/autobahn-python/deployments","created_at":"2011-07-27T15:22:13Z","updated_at":"2016-05-07T10:30:26Z","pushed_at":"2016-05-05T19:03:53Z","git_url":"git://github.com/crossbario/autobahn-python.git","ssh_url":"git@github.com:crossbario/autobahn-python.git","clone_url":"https://github.com/crossbario/autobahn-python.git","svn_url":"https://github.com/crossbario/autobahn-python","homepage":"http://crossbar.io/autobahn","size":13197,"stargazers_count":1112,"watchers_count":1112,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":360,"mirror_url":null,"open_issues_count":83,"forks":360,"open_issues":83,"watchers":1112,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crossbario/autobahn-python/pulls/675"},"html":{"href":"https://github.com/crossbario/autobahn-python/pull/675"},"issue":{"href":"https://api.github.com/repos/crossbario/autobahn-python/issues/675"},"comments":{"href":"https://api.github.com/repos/crossbario/autobahn-python/issues/675/comments"},"review_comments":{"href":"https://api.github.com/repos/crossbario/autobahn-python/pulls/675/comments"},"review_comment":{"href":"https://api.github.com/repos/crossbario/autobahn-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crossbario/autobahn-python/pulls/675/commits"},"statuses":{"href":"https://api.github.com/repos/crossbario/autobahn-python/statuses/5ad3e9d0a6f02738d8ff79ed1c7131212051328f"}}}}