{"action":"created","comment":{"url":"https://api.github.com/repos/geotrellis/geotrellis/pulls/comments/66714847","id":66714847,"diff_hunk":"@@ -259,6 +263,13 @@ class IntColorMap(breaksToColors: Map[Int, Int], val options: Options = Options.\n     h.foreachValue(z => ch.setItem(z, map(z)))\n     new IntCachedColorMap(orderedColors, ch, options)\n   }\n+\n+  lazy val breaksString: String = {","path":"raster/src/main/scala/geotrellis/raster/render/ColorMap.scala","position":25,"original_position":25,"commit_id":"234df5e7fc617831a4701a02f903762afb25359d","original_commit_id":"234df5e7fc617831a4701a02f903762afb25359d","user":{"login":"lossyrob","id":2320142,"avatar_url":"https://avatars.githubusercontent.com/u/2320142?v=3","gravatar_id":"","url":"https://api.github.com/users/lossyrob","html_url":"https://github.com/lossyrob","followers_url":"https://api.github.com/users/lossyrob/followers","following_url":"https://api.github.com/users/lossyrob/following{/other_user}","gists_url":"https://api.github.com/users/lossyrob/gists{/gist_id}","starred_url":"https://api.github.com/users/lossyrob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lossyrob/subscriptions","organizations_url":"https://api.github.com/users/lossyrob/orgs","repos_url":"https://api.github.com/users/lossyrob/repos","events_url":"https://api.github.com/users/lossyrob/events{/privacy}","received_events_url":"https://api.github.com/users/lossyrob/received_events","type":"User","site_admin":false},"body":"I wasn't thinking vals...why not defs? Is there ever a reason to hold them in memory after calculation (e.g. its an expensive operation that will be reused many times to justify the instance footprint)?","created_at":"2016-06-12T02:13:42Z","updated_at":"2016-06-12T02:13:42Z","html_url":"https://github.com/geotrellis/geotrellis/pull/1512#discussion_r66714847","pull_request_url":"https://api.github.com/repos/geotrellis/geotrellis/pulls/1512","_links":{"self":{"href":"https://api.github.com/repos/geotrellis/geotrellis/pulls/comments/66714847"},"html":{"href":"https://github.com/geotrellis/geotrellis/pull/1512#discussion_r66714847"},"pull_request":{"href":"https://api.github.com/repos/geotrellis/geotrellis/pulls/1512"}}},"pull_request":{"url":"https://api.github.com/repos/geotrellis/geotrellis/pulls/1512","id":72922396,"html_url":"https://github.com/geotrellis/geotrellis/pull/1512","diff_url":"https://github.com/geotrellis/geotrellis/pull/1512.diff","patch_url":"https://github.com/geotrellis/geotrellis/pull/1512.patch","issue_url":"https://api.github.com/repos/geotrellis/geotrellis/issues/1512","number":1512,"state":"open","locked":false,"title":"ColorMap => String","user":{"login":"fosskers","id":229679,"avatar_url":"https://avatars.githubusercontent.com/u/229679?v=3","gravatar_id":"","url":"https://api.github.com/users/fosskers","html_url":"https://github.com/fosskers","followers_url":"https://api.github.com/users/fosskers/followers","following_url":"https://api.github.com/users/fosskers/following{/other_user}","gists_url":"https://api.github.com/users/fosskers/gists{/gist_id}","starred_url":"https://api.github.com/users/fosskers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fosskers/subscriptions","organizations_url":"https://api.github.com/users/fosskers/orgs","repos_url":"https://api.github.com/users/fosskers/repos","events_url":"https://api.github.com/users/fosskers/events{/privacy}","received_events_url":"https://api.github.com/users/fosskers/received_events","type":"User","site_admin":false},"body":"## TODO\r\n- [x] Basic functionality\r\n- [x] Move `breaksString` into trait and inherit\r\n- [x] Special definition for `IntCachedColorMap`\r\n- [x] Tests\r\n\r\n## Motivation\r\nWhen using the `render` output module in the ETL process, one must provide a `breaks` argument, or all tiles will be rendered grayscale. Example:\r\n\r\n```console\r\n--output render -O encoding=png path=file:///home/colin/tiles/{name}/{z}-{x}-{y}.png breaks=\"23:cc00ccff;30:aa00aaff;120:ff0000ff\"\r\n```\r\nThe problem is that for datasets which don't have well-defined colour breaks ahead of time like `nlcd`, there's no way to know what your break string should be for input into ETL. A `ColorMap` object can be created easily given `RDD.colorBreaks` and then rendered to a PNG within Scala code, but there is no way to know what `String` would represent that `ColorMap` from the outside. This chicken-and-egg problem requires a greater fix to how ETL accepts breaks information from the outside, but this is a start. \r\n","created_at":"2016-06-07T18:13:34Z","updated_at":"2016-06-12T02:13:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b5c4b0cfeefa4f652e83166ddab21456029afb2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/geotrellis/geotrellis/pulls/1512/commits","review_comments_url":"https://api.github.com/repos/geotrellis/geotrellis/pulls/1512/comments","review_comment_url":"https://api.github.com/repos/geotrellis/geotrellis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/geotrellis/geotrellis/issues/1512/comments","statuses_url":"https://api.github.com/repos/geotrellis/geotrellis/statuses/234df5e7fc617831a4701a02f903762afb25359d","head":{"label":"fosskers:enhancement/colormap-to-string","ref":"enhancement/colormap-to-string","sha":"234df5e7fc617831a4701a02f903762afb25359d","user":{"login":"fosskers","id":229679,"avatar_url":"https://avatars.githubusercontent.com/u/229679?v=3","gravatar_id":"","url":"https://api.github.com/users/fosskers","html_url":"https://github.com/fosskers","followers_url":"https://api.github.com/users/fosskers/followers","following_url":"https://api.github.com/users/fosskers/following{/other_user}","gists_url":"https://api.github.com/users/fosskers/gists{/gist_id}","starred_url":"https://api.github.com/users/fosskers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fosskers/subscriptions","organizations_url":"https://api.github.com/users/fosskers/orgs","repos_url":"https://api.github.com/users/fosskers/repos","events_url":"https://api.github.com/users/fosskers/events{/privacy}","received_events_url":"https://api.github.com/users/fosskers/received_events","type":"User","site_admin":false},"repo":{"id":59325809,"name":"geotrellis","full_name":"fosskers/geotrellis","owner":{"login":"fosskers","id":229679,"avatar_url":"https://avatars.githubusercontent.com/u/229679?v=3","gravatar_id":"","url":"https://api.github.com/users/fosskers","html_url":"https://github.com/fosskers","followers_url":"https://api.github.com/users/fosskers/followers","following_url":"https://api.github.com/users/fosskers/following{/other_user}","gists_url":"https://api.github.com/users/fosskers/gists{/gist_id}","starred_url":"https://api.github.com/users/fosskers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fosskers/subscriptions","organizations_url":"https://api.github.com/users/fosskers/orgs","repos_url":"https://api.github.com/users/fosskers/repos","events_url":"https://api.github.com/users/fosskers/events{/privacy}","received_events_url":"https://api.github.com/users/fosskers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fosskers/geotrellis","description":"GeoTrellis is a geographic data processing engine for high performance applications.","fork":true,"url":"https://api.github.com/repos/fosskers/geotrellis","forks_url":"https://api.github.com/repos/fosskers/geotrellis/forks","keys_url":"https://api.github.com/repos/fosskers/geotrellis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fosskers/geotrellis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fosskers/geotrellis/teams","hooks_url":"https://api.github.com/repos/fosskers/geotrellis/hooks","issue_events_url":"https://api.github.com/repos/fosskers/geotrellis/issues/events{/number}","events_url":"https://api.github.com/repos/fosskers/geotrellis/events","assignees_url":"https://api.github.com/repos/fosskers/geotrellis/assignees{/user}","branches_url":"https://api.github.com/repos/fosskers/geotrellis/branches{/branch}","tags_url":"https://api.github.com/repos/fosskers/geotrellis/tags","blobs_url":"https://api.github.com/repos/fosskers/geotrellis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fosskers/geotrellis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fosskers/geotrellis/git/refs{/sha}","trees_url":"https://api.github.com/repos/fosskers/geotrellis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fosskers/geotrellis/statuses/{sha}","languages_url":"https://api.github.com/repos/fosskers/geotrellis/languages","stargazers_url":"https://api.github.com/repos/fosskers/geotrellis/stargazers","contributors_url":"https://api.github.com/repos/fosskers/geotrellis/contributors","subscribers_url":"https://api.github.com/repos/fosskers/geotrellis/subscribers","subscription_url":"https://api.github.com/repos/fosskers/geotrellis/subscription","commits_url":"https://api.github.com/repos/fosskers/geotrellis/commits{/sha}","git_commits_url":"https://api.github.com/repos/fosskers/geotrellis/git/commits{/sha}","comments_url":"https://api.github.com/repos/fosskers/geotrellis/comments{/number}","issue_comment_url":"https://api.github.com/repos/fosskers/geotrellis/issues/comments{/number}","contents_url":"https://api.github.com/repos/fosskers/geotrellis/contents/{+path}","compare_url":"https://api.github.com/repos/fosskers/geotrellis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fosskers/geotrellis/merges","archive_url":"https://api.github.com/repos/fosskers/geotrellis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fosskers/geotrellis/downloads","issues_url":"https://api.github.com/repos/fosskers/geotrellis/issues{/number}","pulls_url":"https://api.github.com/repos/fosskers/geotrellis/pulls{/number}","milestones_url":"https://api.github.com/repos/fosskers/geotrellis/milestones{/number}","notifications_url":"https://api.github.com/repos/fosskers/geotrellis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fosskers/geotrellis/labels{/name}","releases_url":"https://api.github.com/repos/fosskers/geotrellis/releases{/id}","deployments_url":"https://api.github.com/repos/fosskers/geotrellis/deployments","created_at":"2016-05-20T20:54:53Z","updated_at":"2016-05-20T20:55:06Z","pushed_at":"2016-06-07T21:40:10Z","git_url":"git://github.com/fosskers/geotrellis.git","ssh_url":"git@github.com:fosskers/geotrellis.git","clone_url":"https://github.com/fosskers/geotrellis.git","svn_url":"https://github.com/fosskers/geotrellis","homepage":"http://geotrellis.io","size":267934,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"geotrellis:master","ref":"master","sha":"14d6d1e007fcc4ed3a6352b36208a37211d2fcd9","user":{"login":"geotrellis","id":3129444,"avatar_url":"https://avatars.githubusercontent.com/u/3129444?v=3","gravatar_id":"","url":"https://api.github.com/users/geotrellis","html_url":"https://github.com/geotrellis","followers_url":"https://api.github.com/users/geotrellis/followers","following_url":"https://api.github.com/users/geotrellis/following{/other_user}","gists_url":"https://api.github.com/users/geotrellis/gists{/gist_id}","starred_url":"https://api.github.com/users/geotrellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geotrellis/subscriptions","organizations_url":"https://api.github.com/users/geotrellis/orgs","repos_url":"https://api.github.com/users/geotrellis/repos","events_url":"https://api.github.com/users/geotrellis/events{/privacy}","received_events_url":"https://api.github.com/users/geotrellis/received_events","type":"Organization","site_admin":false},"repo":{"id":3040675,"name":"geotrellis","full_name":"geotrellis/geotrellis","owner":{"login":"geotrellis","id":3129444,"avatar_url":"https://avatars.githubusercontent.com/u/3129444?v=3","gravatar_id":"","url":"https://api.github.com/users/geotrellis","html_url":"https://github.com/geotrellis","followers_url":"https://api.github.com/users/geotrellis/followers","following_url":"https://api.github.com/users/geotrellis/following{/other_user}","gists_url":"https://api.github.com/users/geotrellis/gists{/gist_id}","starred_url":"https://api.github.com/users/geotrellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geotrellis/subscriptions","organizations_url":"https://api.github.com/users/geotrellis/orgs","repos_url":"https://api.github.com/users/geotrellis/repos","events_url":"https://api.github.com/users/geotrellis/events{/privacy}","received_events_url":"https://api.github.com/users/geotrellis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geotrellis/geotrellis","description":"GeoTrellis is a geographic data processing engine for high performance applications.","fork":false,"url":"https://api.github.com/repos/geotrellis/geotrellis","forks_url":"https://api.github.com/repos/geotrellis/geotrellis/forks","keys_url":"https://api.github.com/repos/geotrellis/geotrellis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geotrellis/geotrellis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geotrellis/geotrellis/teams","hooks_url":"https://api.github.com/repos/geotrellis/geotrellis/hooks","issue_events_url":"https://api.github.com/repos/geotrellis/geotrellis/issues/events{/number}","events_url":"https://api.github.com/repos/geotrellis/geotrellis/events","assignees_url":"https://api.github.com/repos/geotrellis/geotrellis/assignees{/user}","branches_url":"https://api.github.com/repos/geotrellis/geotrellis/branches{/branch}","tags_url":"https://api.github.com/repos/geotrellis/geotrellis/tags","blobs_url":"https://api.github.com/repos/geotrellis/geotrellis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geotrellis/geotrellis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geotrellis/geotrellis/git/refs{/sha}","trees_url":"https://api.github.com/repos/geotrellis/geotrellis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geotrellis/geotrellis/statuses/{sha}","languages_url":"https://api.github.com/repos/geotrellis/geotrellis/languages","stargazers_url":"https://api.github.com/repos/geotrellis/geotrellis/stargazers","contributors_url":"https://api.github.com/repos/geotrellis/geotrellis/contributors","subscribers_url":"https://api.github.com/repos/geotrellis/geotrellis/subscribers","subscription_url":"https://api.github.com/repos/geotrellis/geotrellis/subscription","commits_url":"https://api.github.com/repos/geotrellis/geotrellis/commits{/sha}","git_commits_url":"https://api.github.com/repos/geotrellis/geotrellis/git/commits{/sha}","comments_url":"https://api.github.com/repos/geotrellis/geotrellis/comments{/number}","issue_comment_url":"https://api.github.com/repos/geotrellis/geotrellis/issues/comments{/number}","contents_url":"https://api.github.com/repos/geotrellis/geotrellis/contents/{+path}","compare_url":"https://api.github.com/repos/geotrellis/geotrellis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geotrellis/geotrellis/merges","archive_url":"https://api.github.com/repos/geotrellis/geotrellis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geotrellis/geotrellis/downloads","issues_url":"https://api.github.com/repos/geotrellis/geotrellis/issues{/number}","pulls_url":"https://api.github.com/repos/geotrellis/geotrellis/pulls{/number}","milestones_url":"https://api.github.com/repos/geotrellis/geotrellis/milestones{/number}","notifications_url":"https://api.github.com/repos/geotrellis/geotrellis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geotrellis/geotrellis/labels{/name}","releases_url":"https://api.github.com/repos/geotrellis/geotrellis/releases{/id}","deployments_url":"https://api.github.com/repos/geotrellis/geotrellis/deployments","created_at":"2011-12-23T14:56:54Z","updated_at":"2016-06-06T20:04:02Z","pushed_at":"2016-06-12T01:57:06Z","git_url":"git://github.com/geotrellis/geotrellis.git","ssh_url":"git@github.com:geotrellis/geotrellis.git","clone_url":"https://github.com/geotrellis/geotrellis.git","svn_url":"https://github.com/geotrellis/geotrellis","homepage":"http://geotrellis.io","size":283865,"stargazers_count":437,"watchers_count":437,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":126,"mirror_url":null,"open_issues_count":74,"forks":126,"open_issues":74,"watchers":437,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/geotrellis/geotrellis/pulls/1512"},"html":{"href":"https://github.com/geotrellis/geotrellis/pull/1512"},"issue":{"href":"https://api.github.com/repos/geotrellis/geotrellis/issues/1512"},"comments":{"href":"https://api.github.com/repos/geotrellis/geotrellis/issues/1512/comments"},"review_comments":{"href":"https://api.github.com/repos/geotrellis/geotrellis/pulls/1512/comments"},"review_comment":{"href":"https://api.github.com/repos/geotrellis/geotrellis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/geotrellis/geotrellis/pulls/1512/commits"},"statuses":{"href":"https://api.github.com/repos/geotrellis/geotrellis/statuses/234df5e7fc617831a4701a02f903762afb25359d"}}}}
{"actor":{"display_login":"lossyrob"}}