{"action":"closed","number":288,"pull_request":{"url":"https://api.github.com/repos/ktbyers/netmiko/pulls/288","id":87615902,"html_url":"https://github.com/ktbyers/netmiko/pull/288","diff_url":"https://github.com/ktbyers/netmiko/pull/288.diff","patch_url":"https://github.com/ktbyers/netmiko/pull/288.patch","issue_url":"https://api.github.com/repos/ktbyers/netmiko/issues/288","number":288,"state":"closed","locked":false,"title":"Fixed vyos timing issues when exiting configuration mode","user":{"login":"rollerr","id":8158330,"avatar_url":"https://avatars.githubusercontent.com/u/8158330?v=3","gravatar_id":"","url":"https://api.github.com/users/rollerr","html_url":"https://github.com/rollerr","followers_url":"https://api.github.com/users/rollerr/followers","following_url":"https://api.github.com/users/rollerr/following{/other_user}","gists_url":"https://api.github.com/users/rollerr/gists{/gist_id}","starred_url":"https://api.github.com/users/rollerr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rollerr/subscriptions","organizations_url":"https://api.github.com/users/rollerr/orgs","repos_url":"https://api.github.com/users/rollerr/repos","events_url":"https://api.github.com/users/rollerr/events{/privacy}","received_events_url":"https://api.github.com/users/rollerr/received_events","type":"User","site_admin":false},"body":"Existing from vyos config needs a minor delay to obtain output. Currently the send_command method is timing out. \r\n\r\nPrior to changes:\r\n\r\n```\r\n\r\nIn [8]: b.device_type\r\nOut[8]: 'vyos'\r\n\r\nIn [9]: results = b.send_config_from_file('branch2-edg-r1.conf', exit_config_mode=False)\r\n\r\nIn [10]: b.host\r\nOut[10]: 'branch2-edg-r1'\r\n\r\nIn [11]: b.exit_config_mode()\r\n---------------------------------------------------------------------------\r\nIOError                                   Traceback (most recent call last)\r\n<ipython-input-11-bdf81436692a> in <module>()\r\n----> 1 b.exit_config_mode()\r\n\r\n/usr/local/lib/python2.7/dist-packages/netmiko/vyos/vyos_ssh.pyc in exit_config_mode(self, exit_config, pattern)\r\n     39             if 'Cannot exit: configuration modified' in output:\r\n     40                 # insert delay?\r\n---> 41                 output += self.send_command('exit discard', strip_prompt=False, strip_command=False)\r\n     42             if self.check_config_mode():\r\n     43                 raise ValueError(\"Failed to exit configuration mode\")\r\n\r\n/usr/local/lib/python2.7/dist-packages/netmiko/base_connection.pyc in send_command(self, command_string, expect_string, delay_factor, max_loops, auto_find_prompt, strip_prompt, strip_command)\r\n    656         else:   # nobreak\r\n    657             raise IOError(\"Search pattern never detected in send_command_expect: {0}\".format(\r\n--> 658                 search_pattern))\r\n    659\r\n    660         output = self._sanitize_output(output, strip_command=strip_command,\r\n\r\nIOError: Search pattern never detected in send_command_expect: admin\\@branch2\\-edg\\-r1\\#\r\n```\r\n\r\nAfter adjusting:\r\n```\r\nIn [4]: b.send_config_from_file('/home/ubuntu/workplace/ansible_vyos/vyos/output/branch2-edg-r1.conf', exit_config_mode=False)\r\nOut[4]: u'set interfaces ethernet eth5 address 18.0.0.42/30\\n\\n  Configuration path: [interfaces ethernet eth5 address 18.0.0.42/30] already exists\\n\\n[edit]\\nadmin@branch2-edg-r1# set interfaces ethernet eth5 description \"--> super-pe-r1  \\r| eth11\"\\n\\n  Configuration path: [interfaces ethernet eth5 description --> super-pe-r1 | eth11] already exists\\n\\n[edit]\\nadmin@branch2-edg-r1# set interfaces ethernet eth6 address 18.0.0.46/30\\n\\n  Configuration path: [interfaces ethernet eth6 address 18.0.0.46/30] already exists\\n\\n[edit]\\nadmin@branch2-edg-r1# set interfaces ethernet eth6 description \"--> super-pe-r1  \\r| eth12\"\\n\\n  Configuration path: [interfaces ethernet eth6 description --> super-pe-r1 | eth12] already exists\\n\\n[edit]\\nadmin@branch2-edg-r1# '\r\n\r\nIn [5]: b.commit()\r\nOut[5]: u'commit\\nNo configuration changes to commit\\n[edit]\\nadmin@branch2-edg-r1# '\r\n\r\nIn [6]: b.exit_config_mode()\r\nOut[6]: u'exit\\nexit\\nadmin@branch2-edg-r1:~$ '\r\n\r\nIn [7]:\r\n```","created_at":"2016-10-01T21:15:57Z","updated_at":"2016-10-16T16:44:43Z","closed_at":"2016-10-16T16:44:43Z","merged_at":null,"merge_commit_sha":"1f63b3b85e81918499ffc5da8e532ee6cf75b9f5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ktbyers/netmiko/pulls/288/commits","review_comments_url":"https://api.github.com/repos/ktbyers/netmiko/pulls/288/comments","review_comment_url":"https://api.github.com/repos/ktbyers/netmiko/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ktbyers/netmiko/issues/288/comments","statuses_url":"https://api.github.com/repos/ktbyers/netmiko/statuses/e46e3bf88d9831c544eb426528f9aa9a60b22f45","head":{"label":"rollerr:timing_fix","ref":"timing_fix","sha":"e46e3bf88d9831c544eb426528f9aa9a60b22f45","user":{"login":"rollerr","id":8158330,"avatar_url":"https://avatars.githubusercontent.com/u/8158330?v=3","gravatar_id":"","url":"https://api.github.com/users/rollerr","html_url":"https://github.com/rollerr","followers_url":"https://api.github.com/users/rollerr/followers","following_url":"https://api.github.com/users/rollerr/following{/other_user}","gists_url":"https://api.github.com/users/rollerr/gists{/gist_id}","starred_url":"https://api.github.com/users/rollerr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rollerr/subscriptions","organizations_url":"https://api.github.com/users/rollerr/orgs","repos_url":"https://api.github.com/users/rollerr/repos","events_url":"https://api.github.com/users/rollerr/events{/privacy}","received_events_url":"https://api.github.com/users/rollerr/received_events","type":"User","site_admin":false},"repo":{"id":69763555,"name":"netmiko","full_name":"rollerr/netmiko","owner":{"login":"rollerr","id":8158330,"avatar_url":"https://avatars.githubusercontent.com/u/8158330?v=3","gravatar_id":"","url":"https://api.github.com/users/rollerr","html_url":"https://github.com/rollerr","followers_url":"https://api.github.com/users/rollerr/followers","following_url":"https://api.github.com/users/rollerr/following{/other_user}","gists_url":"https://api.github.com/users/rollerr/gists{/gist_id}","starred_url":"https://api.github.com/users/rollerr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rollerr/subscriptions","organizations_url":"https://api.github.com/users/rollerr/orgs","repos_url":"https://api.github.com/users/rollerr/repos","events_url":"https://api.github.com/users/rollerr/events{/privacy}","received_events_url":"https://api.github.com/users/rollerr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rollerr/netmiko","description":"Multi-vendor library to simplify Paramiko SSH connections to network devices","fork":true,"url":"https://api.github.com/repos/rollerr/netmiko","forks_url":"https://api.github.com/repos/rollerr/netmiko/forks","keys_url":"https://api.github.com/repos/rollerr/netmiko/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rollerr/netmiko/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rollerr/netmiko/teams","hooks_url":"https://api.github.com/repos/rollerr/netmiko/hooks","issue_events_url":"https://api.github.com/repos/rollerr/netmiko/issues/events{/number}","events_url":"https://api.github.com/repos/rollerr/netmiko/events","assignees_url":"https://api.github.com/repos/rollerr/netmiko/assignees{/user}","branches_url":"https://api.github.com/repos/rollerr/netmiko/branches{/branch}","tags_url":"https://api.github.com/repos/rollerr/netmiko/tags","blobs_url":"https://api.github.com/repos/rollerr/netmiko/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rollerr/netmiko/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rollerr/netmiko/git/refs{/sha}","trees_url":"https://api.github.com/repos/rollerr/netmiko/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rollerr/netmiko/statuses/{sha}","languages_url":"https://api.github.com/repos/rollerr/netmiko/languages","stargazers_url":"https://api.github.com/repos/rollerr/netmiko/stargazers","contributors_url":"https://api.github.com/repos/rollerr/netmiko/contributors","subscribers_url":"https://api.github.com/repos/rollerr/netmiko/subscribers","subscription_url":"https://api.github.com/repos/rollerr/netmiko/subscription","commits_url":"https://api.github.com/repos/rollerr/netmiko/commits{/sha}","git_commits_url":"https://api.github.com/repos/rollerr/netmiko/git/commits{/sha}","comments_url":"https://api.github.com/repos/rollerr/netmiko/comments{/number}","issue_comment_url":"https://api.github.com/repos/rollerr/netmiko/issues/comments{/number}","contents_url":"https://api.github.com/repos/rollerr/netmiko/contents/{+path}","compare_url":"https://api.github.com/repos/rollerr/netmiko/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rollerr/netmiko/merges","archive_url":"https://api.github.com/repos/rollerr/netmiko/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rollerr/netmiko/downloads","issues_url":"https://api.github.com/repos/rollerr/netmiko/issues{/number}","pulls_url":"https://api.github.com/repos/rollerr/netmiko/pulls{/number}","milestones_url":"https://api.github.com/repos/rollerr/netmiko/milestones{/number}","notifications_url":"https://api.github.com/repos/rollerr/netmiko/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rollerr/netmiko/labels{/name}","releases_url":"https://api.github.com/repos/rollerr/netmiko/releases{/id}","deployments_url":"https://api.github.com/repos/rollerr/netmiko/deployments","created_at":"2016-10-01T21:01:45Z","updated_at":"2016-10-01T21:01:47Z","pushed_at":"2016-10-03T01:02:33Z","git_url":"git://github.com/rollerr/netmiko.git","ssh_url":"git@github.com:rollerr/netmiko.git","clone_url":"https://github.com/rollerr/netmiko.git","svn_url":"https://github.com/rollerr/netmiko","homepage":null,"size":775,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ktbyers:master","ref":"master","sha":"96a6fce610710077dc6b9959a7371dd42b0ea5cb","user":{"login":"ktbyers","id":899716,"avatar_url":"https://avatars.githubusercontent.com/u/899716?v=3","gravatar_id":"","url":"https://api.github.com/users/ktbyers","html_url":"https://github.com/ktbyers","followers_url":"https://api.github.com/users/ktbyers/followers","following_url":"https://api.github.com/users/ktbyers/following{/other_user}","gists_url":"https://api.github.com/users/ktbyers/gists{/gist_id}","starred_url":"https://api.github.com/users/ktbyers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktbyers/subscriptions","organizations_url":"https://api.github.com/users/ktbyers/orgs","repos_url":"https://api.github.com/users/ktbyers/repos","events_url":"https://api.github.com/users/ktbyers/events{/privacy}","received_events_url":"https://api.github.com/users/ktbyers/received_events","type":"User","site_admin":false},"repo":{"id":27283062,"name":"netmiko","full_name":"ktbyers/netmiko","owner":{"login":"ktbyers","id":899716,"avatar_url":"https://avatars.githubusercontent.com/u/899716?v=3","gravatar_id":"","url":"https://api.github.com/users/ktbyers","html_url":"https://github.com/ktbyers","followers_url":"https://api.github.com/users/ktbyers/followers","following_url":"https://api.github.com/users/ktbyers/following{/other_user}","gists_url":"https://api.github.com/users/ktbyers/gists{/gist_id}","starred_url":"https://api.github.com/users/ktbyers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktbyers/subscriptions","organizations_url":"https://api.github.com/users/ktbyers/orgs","repos_url":"https://api.github.com/users/ktbyers/repos","events_url":"https://api.github.com/users/ktbyers/events{/privacy}","received_events_url":"https://api.github.com/users/ktbyers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ktbyers/netmiko","description":"Multi-vendor library to simplify Paramiko SSH connections to network devices","fork":false,"url":"https://api.github.com/repos/ktbyers/netmiko","forks_url":"https://api.github.com/repos/ktbyers/netmiko/forks","keys_url":"https://api.github.com/repos/ktbyers/netmiko/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ktbyers/netmiko/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ktbyers/netmiko/teams","hooks_url":"https://api.github.com/repos/ktbyers/netmiko/hooks","issue_events_url":"https://api.github.com/repos/ktbyers/netmiko/issues/events{/number}","events_url":"https://api.github.com/repos/ktbyers/netmiko/events","assignees_url":"https://api.github.com/repos/ktbyers/netmiko/assignees{/user}","branches_url":"https://api.github.com/repos/ktbyers/netmiko/branches{/branch}","tags_url":"https://api.github.com/repos/ktbyers/netmiko/tags","blobs_url":"https://api.github.com/repos/ktbyers/netmiko/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ktbyers/netmiko/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ktbyers/netmiko/git/refs{/sha}","trees_url":"https://api.github.com/repos/ktbyers/netmiko/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ktbyers/netmiko/statuses/{sha}","languages_url":"https://api.github.com/repos/ktbyers/netmiko/languages","stargazers_url":"https://api.github.com/repos/ktbyers/netmiko/stargazers","contributors_url":"https://api.github.com/repos/ktbyers/netmiko/contributors","subscribers_url":"https://api.github.com/repos/ktbyers/netmiko/subscribers","subscription_url":"https://api.github.com/repos/ktbyers/netmiko/subscription","commits_url":"https://api.github.com/repos/ktbyers/netmiko/commits{/sha}","git_commits_url":"https://api.github.com/repos/ktbyers/netmiko/git/commits{/sha}","comments_url":"https://api.github.com/repos/ktbyers/netmiko/comments{/number}","issue_comment_url":"https://api.github.com/repos/ktbyers/netmiko/issues/comments{/number}","contents_url":"https://api.github.com/repos/ktbyers/netmiko/contents/{+path}","compare_url":"https://api.github.com/repos/ktbyers/netmiko/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ktbyers/netmiko/merges","archive_url":"https://api.github.com/repos/ktbyers/netmiko/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ktbyers/netmiko/downloads","issues_url":"https://api.github.com/repos/ktbyers/netmiko/issues{/number}","pulls_url":"https://api.github.com/repos/ktbyers/netmiko/pulls{/number}","milestones_url":"https://api.github.com/repos/ktbyers/netmiko/milestones{/number}","notifications_url":"https://api.github.com/repos/ktbyers/netmiko/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ktbyers/netmiko/labels{/name}","releases_url":"https://api.github.com/repos/ktbyers/netmiko/releases{/id}","deployments_url":"https://api.github.com/repos/ktbyers/netmiko/deployments","created_at":"2014-11-28T21:42:52Z","updated_at":"2016-10-14T07:10:38Z","pushed_at":"2016-10-16T16:44:21Z","git_url":"git://github.com/ktbyers/netmiko.git","ssh_url":"git@github.com:ktbyers/netmiko.git","clone_url":"https://github.com/ktbyers/netmiko.git","svn_url":"https://github.com/ktbyers/netmiko","homepage":null,"size":1144,"stargazers_count":365,"watchers_count":365,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":162,"mirror_url":null,"open_issues_count":45,"forks":162,"open_issues":45,"watchers":365,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ktbyers/netmiko/pulls/288"},"html":{"href":"https://github.com/ktbyers/netmiko/pull/288"},"issue":{"href":"https://api.github.com/repos/ktbyers/netmiko/issues/288"},"comments":{"href":"https://api.github.com/repos/ktbyers/netmiko/issues/288/comments"},"review_comments":{"href":"https://api.github.com/repos/ktbyers/netmiko/pulls/288/comments"},"review_comment":{"href":"https://api.github.com/repos/ktbyers/netmiko/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ktbyers/netmiko/pulls/288/commits"},"statuses":{"href":"https://api.github.com/repos/ktbyers/netmiko/statuses/e46e3bf88d9831c544eb426528f9aa9a60b22f45"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":0,"commits":2,"additions":10,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"ktbyers"}}