{"action":"created","issue":{"url":"https://api.github.com/repos/Valloric/ycmd/issues/506","repository_url":"https://api.github.com/repos/Valloric/ycmd","labels_url":"https://api.github.com/repos/Valloric/ycmd/issues/506/labels{/name}","comments_url":"https://api.github.com/repos/Valloric/ycmd/issues/506/comments","events_url":"https://api.github.com/repos/Valloric/ycmd/issues/506/events","html_url":"https://github.com/Valloric/ycmd/pull/506","id":156174896,"number":506,"title":"[WIP] Make completer interface uniform throughout completers","user":{"login":"vheon","id":90633,"avatar_url":"https://avatars.githubusercontent.com/u/90633?v=3","gravatar_id":"","url":"https://api.github.com/users/vheon","html_url":"https://github.com/vheon","followers_url":"https://api.github.com/users/vheon/followers","following_url":"https://api.github.com/users/vheon/following{/other_user}","gists_url":"https://api.github.com/users/vheon/gists{/gist_id}","starred_url":"https://api.github.com/users/vheon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vheon/subscriptions","organizations_url":"https://api.github.com/users/vheon/orgs","repos_url":"https://api.github.com/users/vheon/repos","events_url":"https://api.github.com/users/vheon/events{/privacy}","received_events_url":"https://api.github.com/users/vheon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":29,"created_at":"2016-05-22T21:42:35Z","updated_at":"2016-06-09T21:17:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Valloric/ycmd/pulls/506","html_url":"https://github.com/Valloric/ycmd/pull/506","diff_url":"https://github.com/Valloric/ycmd/pull/506.diff","patch_url":"https://github.com/Valloric/ycmd/pull/506.patch"},"body":"This should cover the first point from https://github.com/Valloric/ycmd/pull/282#issuecomment-220062574\r\n\r\nWhat I did was:\r\n- Remove `StartServer` from completers\r\n- Add `RestartServer` to completers\r\n- Make `StopServer` unavailable to the end user but usable for testing porpuse\r\n\r\nThis change didn't involve the `Go` completer because I knew that @micbou was working on it.\r\n\r\nI'm still not fully convinced about the C# completer, so I'm marking this as WIP\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/valloric/ycmd/506)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/Valloric/ycmd/issues/comments/225029685","html_url":"https://github.com/Valloric/ycmd/pull/506#issuecomment-225029685","issue_url":"https://api.github.com/repos/Valloric/ycmd/issues/506","id":225029685,"user":{"login":"micbou","id":10026824,"avatar_url":"https://avatars.githubusercontent.com/u/10026824?v=3","gravatar_id":"","url":"https://api.github.com/users/micbou","html_url":"https://github.com/micbou","followers_url":"https://api.github.com/users/micbou/followers","following_url":"https://api.github.com/users/micbou/following{/other_user}","gists_url":"https://api.github.com/users/micbou/gists{/gist_id}","starred_url":"https://api.github.com/users/micbou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micbou/subscriptions","organizations_url":"https://api.github.com/users/micbou/orgs","repos_url":"https://api.github.com/users/micbou/repos","events_url":"https://api.github.com/users/micbou/events{/privacy}","received_events_url":"https://api.github.com/users/micbou/received_events","type":"User","site_admin":false},"created_at":"2016-06-09T21:17:43Z","updated_at":"2016-06-09T21:17:43Z","body":"Could you push force your branch? Tests didn't even start.\n\n<details><summary><i>Previously, vheon (Andrea Cedraro) wrote…</i></summary>\n> > You need to rebase the PR to make the tests pass on Linux.\r> \n> \r> \n> Done\n</details>\n\n\n---\n\nReviewed 1 of 1 files at r14, 2 of 2 files at r15, 2 of 2 files at r16.\nReview status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.\n\n---\n\n*[ycmd/completers/completer.py, line 251 \\[r16\\]](https://reviewable.io:443/reviews/valloric/ycmd/506#-KJqzS1QujQ0MbpOWa5F:-KJqzS1RC6wPuP39tHYg:-789101262) ([raw file](https://github.com/valloric/ycmd/blob/80aeb33d1d7106262cc6572f942f2e02040bcf83/ycmd/completers/completer.py#L251)):*\nCould we rewrite this comment to:\n\n> We don't want **to** expose this **subcommand** because **it** is not really needed for the user but **it** is useful in tests for tearing down the server**.**\n\n(I've marked the differences in bold)?\n\n---\n\n*[ycmd/completers/typescript/typescript_completer.py, line 558 \\[r16\\]](https://reviewable.io:443/reviews/valloric/ycmd/506#-KJr-srrJ12ny1J1Andq:-KJr-srrJ12ny1J1Andr:338325618) ([raw file](https://github.com/valloric/ycmd/blob/80aeb33d1d7106262cc6572f942f2e02040bcf83/ycmd/completers/typescript/typescript_completer.py#L558)):*\n> ```Python\n>         return ( 'Typescript completer debug informations:\\n'\n>                  '  TSServer is not running\\n'\n>                  '  TSServer logfile:\\n  {0}' ).format( self._logfile )\n> ```\n\n`\\n  {0}` should be replaced by ` {0}`.\n\n---\n\n*[ycmd/tests/go/subcommands_test.py, line 45 \\[r16\\]](https://reviewable.io:443/reviews/valloric/ycmd/506#-KJqyGYIwPuKfslk3V9G:-KJqyGYIwPuKfslk3V9H:851616228) ([raw file](https://github.com/valloric/ycmd/blob/ec3c0f19e68db1254b8e641cc857019d40866cb3/ycmd/tests/go/subcommands_test.py#L45)):*\n> ```Python\n>                  'GoToDeclaration' ] ),\n>        app.post_json( '/defined_subcommands',\n>                       subcommands_data ).json )\n> ```\n\nWhy are we removing this? It is useful to check if the `GetSubcommandsMap` method contains no errors. In fact, we should add a test like this for other completers (already done for the JavaScript completer).\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/valloric/ycmd/506#-:-KJqz6lij66BaDnhEwGc:-1369808153)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"micbou"}}