{"action":"created","comment":{"url":"https://api.github.com/repos/openssl/openssl/pulls/comments/86695479","pull_request_review_id":7340588,"id":86695479,"diff_hunk":"@@ -756,11 +756,22 @@ while (@argvcopy)\n \t\t\t$disabled{\"shared\"} = \"forced\";\n \t\t\t$disabled{\"threads\"} = \"forced\";\n \t\t\t}\n-\t\telsif (/^-D(.*)$/)\n+\t\telsif (/^[-\\/]D(.*)$/)\n \t\t\t{\n \t\t\tpush @user_defines, $1;\n \t\t\t}\n-\t\telse\t# common if (/^[-+]/), just pass down...\n+\t\telsif (/^\\/link$/)\n+\t\t\t{\n+\t\t\t# This is Visual Studio-specific thing.\n+\t\t\t# Consume all options that start with slash, e.g.\n+\t\t\t# /link /subsystem:console,5.1. Yes, it has to\n+\t\t\t# be last or terminated with non-slash option.\n+\t\t\twhile (@argvcopy[0] =~ /^\\//)\n+\t\t\t\t{\n+\t\t\t\t$libs.=shift(@argvcopy) . \" \";\n+\t\t\t\t}\n+\t\t\t}","path":"Configure","position":29,"original_position":29,"commit_id":"fe54642861e51ed04a29812a37b4d9d8f4527e67","original_commit_id":"fe54642861e51ed04a29812a37b4d9d8f4527e67","user":{"login":"dot-asm","id":9038069,"avatar_url":"https://avatars.githubusercontent.com/u/9038069?v=3","gravatar_id":"","url":"https://api.github.com/users/dot-asm","html_url":"https://github.com/dot-asm","followers_url":"https://api.github.com/users/dot-asm/followers","following_url":"https://api.github.com/users/dot-asm/following{/other_user}","gists_url":"https://api.github.com/users/dot-asm/gists{/gist_id}","starred_url":"https://api.github.com/users/dot-asm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dot-asm/subscriptions","organizations_url":"https://api.github.com/users/dot-asm/orgs","repos_url":"https://api.github.com/users/dot-asm/repos","events_url":"https://api.github.com/users/dot-asm/events{/privacy}","received_events_url":"https://api.github.com/users/dot-asm/received_events","type":"User","site_admin":false},"body":"Well, it's not worse than having pass-through options and having them mixed with non-pass-through ones. It's kind of like irregular verbs, it doesn't matter if you find them illogical, you have no option not to use them :-) Well, it's somewhat flawed comparison, but consider all the times we said \"pass it as additional option at config-time\". I'd argue that if we go for `--cflags`, then we probably have to maintain legacy way for substantial time anyway, At least it would be inappropriate to remove it in 1.1.x...","created_at":"2016-11-06T20:32:22Z","updated_at":"2016-11-06T20:32:22Z","html_url":"https://github.com/openssl/openssl/pull/1863#discussion_r86695479","pull_request_url":"https://api.github.com/repos/openssl/openssl/pulls/1863","_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments/86695479"},"html":{"href":"https://github.com/openssl/openssl/pull/1863#discussion_r86695479"},"pull_request":{"href":"https://api.github.com/repos/openssl/openssl/pulls/1863"}}},"pull_request":{"url":"https://api.github.com/repos/openssl/openssl/pulls/1863","id":92499462,"html_url":"https://github.com/openssl/openssl/pull/1863","diff_url":"https://github.com/openssl/openssl/pull/1863.diff","patch_url":"https://github.com/openssl/openssl/pull/1863.patch","issue_url":"https://api.github.com/repos/openssl/openssl/issues/1863","number":1863,"state":"open","locked":false,"title":"Configure: tolerate slash-style pass-through options.","user":{"login":"dot-asm","id":9038069,"avatar_url":"https://avatars.githubusercontent.com/u/9038069?v=3","gravatar_id":"","url":"https://api.github.com/users/dot-asm","html_url":"https://github.com/dot-asm","followers_url":"https://api.github.com/users/dot-asm/followers","following_url":"https://api.github.com/users/dot-asm/following{/other_user}","gists_url":"https://api.github.com/users/dot-asm/gists{/gist_id}","starred_url":"https://api.github.com/users/dot-asm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dot-asm/subscriptions","organizations_url":"https://api.github.com/users/dot-asm/orgs","repos_url":"https://api.github.com/users/dot-asm/repos","events_url":"https://api.github.com/users/dot-asm/events{/privacy}","received_events_url":"https://api.github.com/users/dot-asm/received_events","type":"User","site_admin":false},"body":"Even though Visual Studio compiler accepts dash-style command-line\r\noptions, slash-style are likely to appear more natural to user. In\r\naddition recognize /link option that collects following slash-style\r\noptions to link command line. Even though dash-style would work even\r\nhere, we adhere to slash-style in order to preclude slashes with\r\nother systems.","created_at":"2016-11-06T19:36:40Z","updated_at":"2016-11-06T20:32:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dcd630361397eaa80d3564c1c5d0053c21bfad99","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openssl/openssl/pulls/1863/commits","review_comments_url":"https://api.github.com/repos/openssl/openssl/pulls/1863/comments","review_comment_url":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openssl/openssl/issues/1863/comments","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/fe54642861e51ed04a29812a37b4d9d8f4527e67","head":{"label":"dot-asm:vc-friendly-config-flags","ref":"vc-friendly-config-flags","sha":"fe54642861e51ed04a29812a37b4d9d8f4527e67","user":{"login":"dot-asm","id":9038069,"avatar_url":"https://avatars.githubusercontent.com/u/9038069?v=3","gravatar_id":"","url":"https://api.github.com/users/dot-asm","html_url":"https://github.com/dot-asm","followers_url":"https://api.github.com/users/dot-asm/followers","following_url":"https://api.github.com/users/dot-asm/following{/other_user}","gists_url":"https://api.github.com/users/dot-asm/gists{/gist_id}","starred_url":"https://api.github.com/users/dot-asm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dot-asm/subscriptions","organizations_url":"https://api.github.com/users/dot-asm/orgs","repos_url":"https://api.github.com/users/dot-asm/repos","events_url":"https://api.github.com/users/dot-asm/events{/privacy}","received_events_url":"https://api.github.com/users/dot-asm/received_events","type":"User","site_admin":false},"repo":{"id":58874005,"name":"openssl","full_name":"dot-asm/openssl","owner":{"login":"dot-asm","id":9038069,"avatar_url":"https://avatars.githubusercontent.com/u/9038069?v=3","gravatar_id":"","url":"https://api.github.com/users/dot-asm","html_url":"https://github.com/dot-asm","followers_url":"https://api.github.com/users/dot-asm/followers","following_url":"https://api.github.com/users/dot-asm/following{/other_user}","gists_url":"https://api.github.com/users/dot-asm/gists{/gist_id}","starred_url":"https://api.github.com/users/dot-asm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dot-asm/subscriptions","organizations_url":"https://api.github.com/users/dot-asm/orgs","repos_url":"https://api.github.com/users/dot-asm/repos","events_url":"https://api.github.com/users/dot-asm/events{/privacy}","received_events_url":"https://api.github.com/users/dot-asm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dot-asm/openssl","description":"TLS/SSL and crypto library","fork":true,"url":"https://api.github.com/repos/dot-asm/openssl","forks_url":"https://api.github.com/repos/dot-asm/openssl/forks","keys_url":"https://api.github.com/repos/dot-asm/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dot-asm/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dot-asm/openssl/teams","hooks_url":"https://api.github.com/repos/dot-asm/openssl/hooks","issue_events_url":"https://api.github.com/repos/dot-asm/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/dot-asm/openssl/events","assignees_url":"https://api.github.com/repos/dot-asm/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/dot-asm/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/dot-asm/openssl/tags","blobs_url":"https://api.github.com/repos/dot-asm/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dot-asm/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dot-asm/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/dot-asm/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dot-asm/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/dot-asm/openssl/languages","stargazers_url":"https://api.github.com/repos/dot-asm/openssl/stargazers","contributors_url":"https://api.github.com/repos/dot-asm/openssl/contributors","subscribers_url":"https://api.github.com/repos/dot-asm/openssl/subscribers","subscription_url":"https://api.github.com/repos/dot-asm/openssl/subscription","commits_url":"https://api.github.com/repos/dot-asm/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/dot-asm/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/dot-asm/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/dot-asm/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/dot-asm/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/dot-asm/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dot-asm/openssl/merges","archive_url":"https://api.github.com/repos/dot-asm/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dot-asm/openssl/downloads","issues_url":"https://api.github.com/repos/dot-asm/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/dot-asm/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/dot-asm/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/dot-asm/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dot-asm/openssl/labels{/name}","releases_url":"https://api.github.com/repos/dot-asm/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/dot-asm/openssl/deployments","created_at":"2016-05-15T17:10:40Z","updated_at":"2016-05-15T17:10:52Z","pushed_at":"2016-11-06T19:35:18Z","git_url":"git://github.com/dot-asm/openssl.git","ssh_url":"git@github.com:dot-asm/openssl.git","clone_url":"https://github.com/dot-asm/openssl.git","svn_url":"https://github.com/dot-asm/openssl","homepage":"https://www.openssl.org","size":99790,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openssl:master","ref":"master","sha":"1186a2b3d40e33cbf42d4fd3c7cc679f9f6e14f2","user":{"login":"openssl","id":3279138,"avatar_url":"https://avatars.githubusercontent.com/u/3279138?v=3","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"repo":{"id":7634677,"name":"openssl","full_name":"openssl/openssl","owner":{"login":"openssl","id":3279138,"avatar_url":"https://avatars.githubusercontent.com/u/3279138?v=3","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openssl/openssl","description":"TLS/SSL and crypto library","fork":false,"url":"https://api.github.com/repos/openssl/openssl","forks_url":"https://api.github.com/repos/openssl/openssl/forks","keys_url":"https://api.github.com/repos/openssl/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openssl/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openssl/openssl/teams","hooks_url":"https://api.github.com/repos/openssl/openssl/hooks","issue_events_url":"https://api.github.com/repos/openssl/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/openssl/openssl/events","assignees_url":"https://api.github.com/repos/openssl/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/openssl/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/openssl/openssl/tags","blobs_url":"https://api.github.com/repos/openssl/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openssl/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openssl/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/openssl/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/openssl/openssl/languages","stargazers_url":"https://api.github.com/repos/openssl/openssl/stargazers","contributors_url":"https://api.github.com/repos/openssl/openssl/contributors","subscribers_url":"https://api.github.com/repos/openssl/openssl/subscribers","subscription_url":"https://api.github.com/repos/openssl/openssl/subscription","commits_url":"https://api.github.com/repos/openssl/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/openssl/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/openssl/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/openssl/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/openssl/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/openssl/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openssl/openssl/merges","archive_url":"https://api.github.com/repos/openssl/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openssl/openssl/downloads","issues_url":"https://api.github.com/repos/openssl/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/openssl/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/openssl/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/openssl/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openssl/openssl/labels{/name}","releases_url":"https://api.github.com/repos/openssl/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/openssl/openssl/deployments","created_at":"2013-01-15T22:34:48Z","updated_at":"2016-11-06T14:08:17Z","pushed_at":"2016-11-06T19:36:40Z","git_url":"git://github.com/openssl/openssl.git","ssh_url":"git@github.com:openssl/openssl.git","clone_url":"https://github.com/openssl/openssl.git","svn_url":"https://github.com/openssl/openssl","homepage":"https://www.openssl.org","size":124579,"stargazers_count":3519,"watchers_count":3519,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1964,"mirror_url":null,"open_issues_count":220,"forks":1964,"open_issues":220,"watchers":3519,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/1863"},"html":{"href":"https://github.com/openssl/openssl/pull/1863"},"issue":{"href":"https://api.github.com/repos/openssl/openssl/issues/1863"},"comments":{"href":"https://api.github.com/repos/openssl/openssl/issues/1863/comments"},"review_comments":{"href":"https://api.github.com/repos/openssl/openssl/pulls/1863/comments"},"review_comment":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openssl/openssl/pulls/1863/commits"},"statuses":{"href":"https://api.github.com/repos/openssl/openssl/statuses/fe54642861e51ed04a29812a37b4d9d8f4527e67"}}}}
{"actor":{"display_login":"dot-asm"}}