{"action":"created","comment":{"url":"https://api.github.com/repos/apache/brooklyn-server/pulls/comments/81122326","pull_request_review_id":2124749,"id":81122326,"diff_hunk":"@@ -34,5 +34,7 @@\n      * a higher value appears higher in the list. the default is 1.\n      * (negative values may be used to indicate advanced config which might not be shown unless requested.) */ \n     double priority() default 1;\n-    \n+\n+     /** a pinned configuration means that it should be displayed, regardless of its priority */\n+    boolean pinned() default false;","path":"api/src/main/java/org/apache/brooklyn/api/catalog/CatalogConfig.java","position":7,"original_position":7,"commit_id":"bdd1f726cf4af3bfc9e3f66191cbf4b77520f243","original_commit_id":"bdd1f726cf4af3bfc9e3f66191cbf4b77520f243","user":{"login":"tbouron","id":2082759,"avatar_url":"https://avatars.githubusercontent.com/u/2082759?v=3","gravatar_id":"","url":"https://api.github.com/users/tbouron","html_url":"https://github.com/tbouron","followers_url":"https://api.github.com/users/tbouron/followers","following_url":"https://api.github.com/users/tbouron/following{/other_user}","gists_url":"https://api.github.com/users/tbouron/gists{/gist_id}","starred_url":"https://api.github.com/users/tbouron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbouron/subscriptions","organizations_url":"https://api.github.com/users/tbouron/orgs","repos_url":"https://api.github.com/users/tbouron/repos","events_url":"https://api.github.com/users/tbouron/events{/privacy}","received_events_url":"https://api.github.com/users/tbouron/received_events","type":"User","site_admin":false},"body":"Yeah, make sense. I'll update the Javadoc","created_at":"2016-09-29T12:13:12Z","updated_at":"2016-09-29T12:13:12Z","html_url":"https://github.com/apache/brooklyn-server/pull/358#discussion_r81122326","pull_request_url":"https://api.github.com/repos/apache/brooklyn-server/pulls/358","_links":{"self":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/comments/81122326"},"html":{"href":"https://github.com/apache/brooklyn-server/pull/358#discussion_r81122326"},"pull_request":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/358"}}},"pull_request":{"url":"https://api.github.com/repos/apache/brooklyn-server/pulls/358","id":87103838,"html_url":"https://github.com/apache/brooklyn-server/pull/358","diff_url":"https://github.com/apache/brooklyn-server/pull/358.diff","patch_url":"https://github.com/apache/brooklyn-server/pull/358.patch","issue_url":"https://api.github.com/repos/apache/brooklyn-server/issues/358","number":358,"state":"open","locked":false,"title":"Allow REST API to return the config key's constraints for catalog apps ","user":{"login":"tbouron","id":2082759,"avatar_url":"https://avatars.githubusercontent.com/u/2082759?v=3","gravatar_id":"","url":"https://api.github.com/users/tbouron","html_url":"https://github.com/tbouron","followers_url":"https://api.github.com/users/tbouron/followers","following_url":"https://api.github.com/users/tbouron/following{/other_user}","gists_url":"https://api.github.com/users/tbouron/gists{/gist_id}","starred_url":"https://api.github.com/users/tbouron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbouron/subscriptions","organizations_url":"https://api.github.com/users/tbouron/orgs","repos_url":"https://api.github.com/users/tbouron/repos","events_url":"https://api.github.com/users/tbouron/events{/privacy}","received_events_url":"https://api.github.com/users/tbouron/received_events","type":"User","site_admin":false},"body":"Based on https://github.com/apache/brooklyn-server/pull/354 (needs to be merged first)\r\n\r\nThis changes the underlying structure of how the constraints are stored for the config keys. Instead of a single field `Predicates.and(Predicates...)`, there is a `Map<String, Predicate>` to store the keys and predicates to use. This allows the REST API to returns what constraint (keys) a config key is using.\r\n\r\nThe validation still do a `AND` to validate the value.","created_at":"2016-09-28T11:47:01Z","updated_at":"2016-09-29T12:13:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54f3d305dff29ff02774a1231649cdafdf38e08b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/brooklyn-server/pulls/358/commits","review_comments_url":"https://api.github.com/repos/apache/brooklyn-server/pulls/358/comments","review_comment_url":"https://api.github.com/repos/apache/brooklyn-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/brooklyn-server/issues/358/comments","statuses_url":"https://api.github.com/repos/apache/brooklyn-server/statuses/bdd1f726cf4af3bfc9e3f66191cbf4b77520f243","head":{"label":"tbouron:fix/parameter-contraints","ref":"fix/parameter-contraints","sha":"bdd1f726cf4af3bfc9e3f66191cbf4b77520f243","user":{"login":"tbouron","id":2082759,"avatar_url":"https://avatars.githubusercontent.com/u/2082759?v=3","gravatar_id":"","url":"https://api.github.com/users/tbouron","html_url":"https://github.com/tbouron","followers_url":"https://api.github.com/users/tbouron/followers","following_url":"https://api.github.com/users/tbouron/following{/other_user}","gists_url":"https://api.github.com/users/tbouron/gists{/gist_id}","starred_url":"https://api.github.com/users/tbouron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbouron/subscriptions","organizations_url":"https://api.github.com/users/tbouron/orgs","repos_url":"https://api.github.com/users/tbouron/repos","events_url":"https://api.github.com/users/tbouron/events{/privacy}","received_events_url":"https://api.github.com/users/tbouron/received_events","type":"User","site_admin":false},"repo":{"id":69347875,"name":"brooklyn-server","full_name":"tbouron/brooklyn-server","owner":{"login":"tbouron","id":2082759,"avatar_url":"https://avatars.githubusercontent.com/u/2082759?v=3","gravatar_id":"","url":"https://api.github.com/users/tbouron","html_url":"https://github.com/tbouron","followers_url":"https://api.github.com/users/tbouron/followers","following_url":"https://api.github.com/users/tbouron/following{/other_user}","gists_url":"https://api.github.com/users/tbouron/gists{/gist_id}","starred_url":"https://api.github.com/users/tbouron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbouron/subscriptions","organizations_url":"https://api.github.com/users/tbouron/orgs","repos_url":"https://api.github.com/users/tbouron/repos","events_url":"https://api.github.com/users/tbouron/events{/privacy}","received_events_url":"https://api.github.com/users/tbouron/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tbouron/brooklyn-server","description":"Mirror of Apache Brooklyn server","fork":true,"url":"https://api.github.com/repos/tbouron/brooklyn-server","forks_url":"https://api.github.com/repos/tbouron/brooklyn-server/forks","keys_url":"https://api.github.com/repos/tbouron/brooklyn-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tbouron/brooklyn-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tbouron/brooklyn-server/teams","hooks_url":"https://api.github.com/repos/tbouron/brooklyn-server/hooks","issue_events_url":"https://api.github.com/repos/tbouron/brooklyn-server/issues/events{/number}","events_url":"https://api.github.com/repos/tbouron/brooklyn-server/events","assignees_url":"https://api.github.com/repos/tbouron/brooklyn-server/assignees{/user}","branches_url":"https://api.github.com/repos/tbouron/brooklyn-server/branches{/branch}","tags_url":"https://api.github.com/repos/tbouron/brooklyn-server/tags","blobs_url":"https://api.github.com/repos/tbouron/brooklyn-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tbouron/brooklyn-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tbouron/brooklyn-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/tbouron/brooklyn-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tbouron/brooklyn-server/statuses/{sha}","languages_url":"https://api.github.com/repos/tbouron/brooklyn-server/languages","stargazers_url":"https://api.github.com/repos/tbouron/brooklyn-server/stargazers","contributors_url":"https://api.github.com/repos/tbouron/brooklyn-server/contributors","subscribers_url":"https://api.github.com/repos/tbouron/brooklyn-server/subscribers","subscription_url":"https://api.github.com/repos/tbouron/brooklyn-server/subscription","commits_url":"https://api.github.com/repos/tbouron/brooklyn-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/tbouron/brooklyn-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/tbouron/brooklyn-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/tbouron/brooklyn-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/tbouron/brooklyn-server/contents/{+path}","compare_url":"https://api.github.com/repos/tbouron/brooklyn-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tbouron/brooklyn-server/merges","archive_url":"https://api.github.com/repos/tbouron/brooklyn-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tbouron/brooklyn-server/downloads","issues_url":"https://api.github.com/repos/tbouron/brooklyn-server/issues{/number}","pulls_url":"https://api.github.com/repos/tbouron/brooklyn-server/pulls{/number}","milestones_url":"https://api.github.com/repos/tbouron/brooklyn-server/milestones{/number}","notifications_url":"https://api.github.com/repos/tbouron/brooklyn-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tbouron/brooklyn-server/labels{/name}","releases_url":"https://api.github.com/repos/tbouron/brooklyn-server/releases{/id}","deployments_url":"https://api.github.com/repos/tbouron/brooklyn-server/deployments","created_at":"2016-09-27T11:02:43Z","updated_at":"2016-09-27T11:02:53Z","pushed_at":"2016-09-28T11:38:43Z","git_url":"git://github.com/tbouron/brooklyn-server.git","ssh_url":"git@github.com:tbouron/brooklyn-server.git","clone_url":"https://github.com/tbouron/brooklyn-server.git","svn_url":"https://github.com/tbouron/brooklyn-server","homepage":null,"size":31320,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"d9e4bac32c9b0fd8f897d7d27cc2fc75402e77c6","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":47246081,"name":"brooklyn-server","full_name":"apache/brooklyn-server","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/brooklyn-server","description":"Mirror of Apache Brooklyn server","fork":false,"url":"https://api.github.com/repos/apache/brooklyn-server","forks_url":"https://api.github.com/repos/apache/brooklyn-server/forks","keys_url":"https://api.github.com/repos/apache/brooklyn-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/brooklyn-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/brooklyn-server/teams","hooks_url":"https://api.github.com/repos/apache/brooklyn-server/hooks","issue_events_url":"https://api.github.com/repos/apache/brooklyn-server/issues/events{/number}","events_url":"https://api.github.com/repos/apache/brooklyn-server/events","assignees_url":"https://api.github.com/repos/apache/brooklyn-server/assignees{/user}","branches_url":"https://api.github.com/repos/apache/brooklyn-server/branches{/branch}","tags_url":"https://api.github.com/repos/apache/brooklyn-server/tags","blobs_url":"https://api.github.com/repos/apache/brooklyn-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/brooklyn-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/brooklyn-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/brooklyn-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/brooklyn-server/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/brooklyn-server/languages","stargazers_url":"https://api.github.com/repos/apache/brooklyn-server/stargazers","contributors_url":"https://api.github.com/repos/apache/brooklyn-server/contributors","subscribers_url":"https://api.github.com/repos/apache/brooklyn-server/subscribers","subscription_url":"https://api.github.com/repos/apache/brooklyn-server/subscription","commits_url":"https://api.github.com/repos/apache/brooklyn-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/brooklyn-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/brooklyn-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/brooklyn-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/brooklyn-server/contents/{+path}","compare_url":"https://api.github.com/repos/apache/brooklyn-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/brooklyn-server/merges","archive_url":"https://api.github.com/repos/apache/brooklyn-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/brooklyn-server/downloads","issues_url":"https://api.github.com/repos/apache/brooklyn-server/issues{/number}","pulls_url":"https://api.github.com/repos/apache/brooklyn-server/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/brooklyn-server/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/brooklyn-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/brooklyn-server/labels{/name}","releases_url":"https://api.github.com/repos/apache/brooklyn-server/releases{/id}","deployments_url":"https://api.github.com/repos/apache/brooklyn-server/deployments","created_at":"2015-12-02T08:00:06Z","updated_at":"2016-09-04T17:03:47Z","pushed_at":"2016-09-29T11:35:51Z","git_url":"git://github.com/apache/brooklyn-server.git","ssh_url":"git@github.com:apache/brooklyn-server.git","clone_url":"https://github.com/apache/brooklyn-server.git","svn_url":"https://github.com/apache/brooklyn-server","homepage":null,"size":31649,"stargazers_count":11,"watchers_count":11,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":38,"mirror_url":"git://git.apache.org/brooklyn-server.git","open_issues_count":26,"forks":38,"open_issues":26,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/358"},"html":{"href":"https://github.com/apache/brooklyn-server/pull/358"},"issue":{"href":"https://api.github.com/repos/apache/brooklyn-server/issues/358"},"comments":{"href":"https://api.github.com/repos/apache/brooklyn-server/issues/358/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/358/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/358/commits"},"statuses":{"href":"https://api.github.com/repos/apache/brooklyn-server/statuses/bdd1f726cf4af3bfc9e3f66191cbf4b77520f243"}}}}
{"actor":{"display_login":"tbouron"}}