{"action":"created","issue":{"url":"https://api.github.com/repos/brayniac/histogram/issues/18","repository_url":"https://api.github.com/repos/brayniac/histogram","labels_url":"https://api.github.com/repos/brayniac/histogram/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/brayniac/histogram/issues/18/comments","events_url":"https://api.github.com/repos/brayniac/histogram/issues/18/events","html_url":"https://github.com/brayniac/histogram/issues/18","id":158849862,"number":18,"title":"HistogramConfig API","user":{"login":"xitep","id":8274125,"avatar_url":"https://avatars.githubusercontent.com/u/8274125?v=3","gravatar_id":"","url":"https://api.github.com/users/xitep","html_url":"https://github.com/xitep","followers_url":"https://api.github.com/users/xitep/followers","following_url":"https://api.github.com/users/xitep/following{/other_user}","gists_url":"https://api.github.com/users/xitep/gists{/gist_id}","starred_url":"https://api.github.com/users/xitep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xitep/subscriptions","organizations_url":"https://api.github.com/users/xitep/orgs","repos_url":"https://api.github.com/users/xitep/repos","events_url":"https://api.github.com/users/xitep/events{/privacy}","received_events_url":"https://api.github.com/users/xitep/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-07T06:38:03Z","updated_at":"2016-06-08T05:59:19Z","closed_at":null,"body":"Would there be any argument against having `HistogramConfig`'s methods return `Self` instead of `&mut Self`? This would allow a very nice:\r\n\r\n```\r\nlet h = Histogram::configured(\r\n              HistogramConfig::new()\r\n              .max_value(100)\r\n              .precision(1));\r\n```\r\n\r\nAlternatively, I could imagine the following _additional_ methods (while keeping the old ones as their are):\r\n\r\n```\r\nlet h = Histogram::configured(\r\n              HistogramConfig::new()\r\n              .with_max_value(100)\r\n              .with_precision(1));\r\n```\r\n\r\nIf one of these would be ok from your side, I could submit a PR."},"comment":{"url":"https://api.github.com/repos/brayniac/histogram/issues/comments/224496254","html_url":"https://github.com/brayniac/histogram/issues/18#issuecomment-224496254","issue_url":"https://api.github.com/repos/brayniac/histogram/issues/18","id":224496254,"user":{"login":"xitep","id":8274125,"avatar_url":"https://avatars.githubusercontent.com/u/8274125?v=3","gravatar_id":"","url":"https://api.github.com/users/xitep","html_url":"https://github.com/xitep","followers_url":"https://api.github.com/users/xitep/followers","following_url":"https://api.github.com/users/xitep/following{/other_user}","gists_url":"https://api.github.com/users/xitep/gists{/gist_id}","starred_url":"https://api.github.com/users/xitep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xitep/subscriptions","organizations_url":"https://api.github.com/users/xitep/orgs","repos_url":"https://api.github.com/users/xitep/repos","events_url":"https://api.github.com/users/xitep/events{/privacy}","received_events_url":"https://api.github.com/users/xitep/received_events","type":"User","site_admin":false},"created_at":"2016-06-08T05:59:19Z","updated_at":"2016-06-08T05:59:19Z","body":"would you still be fine with the `.with_` methods? it's fine if you're not, feel free to close this issue then. otherwise i'd submit a PR."}}
{"actor":{"display_login":"xitep"}}