{"action":"created","comment":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/comments/51362827","id":51362827,"diff_hunk":"@@ -4251,6 +4257,34 @@ public void rebootVM(final Connection conn, final VM vm, final String vmName) th\n         }\n     }\n \n+    protected String skipOrRemoveSR(Connection conn, SR sr) {","path":"plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java","position":17,"original_position":17,"commit_id":"c91f100b64e17b042dc1596e162f36e344389bcb","original_commit_id":"c91f100b64e17b042dc1596e162f36e344389bcb","user":{"login":"GabrielBrascher","id":5025148,"avatar_url":"https://avatars.githubusercontent.com/u/5025148?v=3","gravatar_id":"","url":"https://api.github.com/users/GabrielBrascher","html_url":"https://github.com/GabrielBrascher","followers_url":"https://api.github.com/users/GabrielBrascher/followers","following_url":"https://api.github.com/users/GabrielBrascher/following{/other_user}","gists_url":"https://api.github.com/users/GabrielBrascher/gists{/gist_id}","starred_url":"https://api.github.com/users/GabrielBrascher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GabrielBrascher/subscriptions","organizations_url":"https://api.github.com/users/GabrielBrascher/orgs","repos_url":"https://api.github.com/users/GabrielBrascher/repos","events_url":"https://api.github.com/users/GabrielBrascher/events{/privacy}","received_events_url":"https://api.github.com/users/GabrielBrascher/received_events","type":"User","site_admin":false},"body":"@anshul1886 @DaanHoogland @rodrigo93 As an ideia. Maybe it could have a name like \"removeSrIfNotNull\" or \"removeSrIfVdiOperationAndSrNotNull\".\r\n\r\nAs an example, a documetation could look like:\r\n`/** Removes the SR if the SR is not null and exists a VDI operation for this SR*/`\r\n\r\nDo you think that one of this options (or anoter in your mind) could improve this code? :-)\r\n\r\nThanks","created_at":"2016-01-31T16:20:17Z","updated_at":"2016-01-31T16:20:17Z","html_url":"https://github.com/apache/cloudstack/pull/672#discussion_r51362827","pull_request_url":"https://api.github.com/repos/apache/cloudstack/pulls/672","_links":{"self":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/comments/51362827"},"html":{"href":"https://github.com/apache/cloudstack/pull/672#discussion_r51362827"},"pull_request":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/672"}}},"pull_request":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/672","id":42000930,"html_url":"https://github.com/apache/cloudstack/pull/672","diff_url":"https://github.com/apache/cloudstack/pull/672.diff","patch_url":"https://github.com/apache/cloudstack/pull/672.patch","issue_url":"https://api.github.com/repos/apache/cloudstack/issues/672","number":672,"state":"open","locked":false,"title":"Allow VM snapshots and volume snapshots to exist together","user":{"login":"anshul1886","id":1712815,"avatar_url":"https://avatars.githubusercontent.com/u/1712815?v=3","gravatar_id":"","url":"https://api.github.com/users/anshul1886","html_url":"https://github.com/anshul1886","followers_url":"https://api.github.com/users/anshul1886/followers","following_url":"https://api.github.com/users/anshul1886/following{/other_user}","gists_url":"https://api.github.com/users/anshul1886/gists{/gist_id}","starred_url":"https://api.github.com/users/anshul1886/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anshul1886/subscriptions","organizations_url":"https://api.github.com/users/anshul1886/orgs","repos_url":"https://api.github.com/users/anshul1886/repos","events_url":"https://api.github.com/users/anshul1886/events{/privacy}","received_events_url":"https://api.github.com/users/anshul1886/received_events","type":"User","site_admin":false},"body":"This branch fixes issues involved in allowing VM snapshots and volume snapshots to exist together.\r\n\r\nhttps://issues.apache.org/jira/browse/CLOUDSTACK-8663","created_at":"2015-08-10T09:20:45Z","updated_at":"2016-01-31T16:20:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e8cb2749a0929d363cb6743b804373ce2110eee","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/cloudstack/pulls/672/commits","review_comments_url":"https://api.github.com/repos/apache/cloudstack/pulls/672/comments","review_comment_url":"https://api.github.com/repos/apache/cloudstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/cloudstack/issues/672/comments","statuses_url":"https://api.github.com/repos/apache/cloudstack/statuses/c91f100b64e17b042dc1596e162f36e344389bcb","head":{"label":"anshul1886:vmsnapshots","ref":"vmsnapshots","sha":"c91f100b64e17b042dc1596e162f36e344389bcb","user":{"login":"anshul1886","id":1712815,"avatar_url":"https://avatars.githubusercontent.com/u/1712815?v=3","gravatar_id":"","url":"https://api.github.com/users/anshul1886","html_url":"https://github.com/anshul1886","followers_url":"https://api.github.com/users/anshul1886/followers","following_url":"https://api.github.com/users/anshul1886/following{/other_user}","gists_url":"https://api.github.com/users/anshul1886/gists{/gist_id}","starred_url":"https://api.github.com/users/anshul1886/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anshul1886/subscriptions","organizations_url":"https://api.github.com/users/anshul1886/orgs","repos_url":"https://api.github.com/users/anshul1886/repos","events_url":"https://api.github.com/users/anshul1886/events{/privacy}","received_events_url":"https://api.github.com/users/anshul1886/received_events","type":"User","site_admin":false},"repo":{"id":25956790,"name":"cloudstack-1","full_name":"anshul1886/cloudstack-1","owner":{"login":"anshul1886","id":1712815,"avatar_url":"https://avatars.githubusercontent.com/u/1712815?v=3","gravatar_id":"","url":"https://api.github.com/users/anshul1886","html_url":"https://github.com/anshul1886","followers_url":"https://api.github.com/users/anshul1886/followers","following_url":"https://api.github.com/users/anshul1886/following{/other_user}","gists_url":"https://api.github.com/users/anshul1886/gists{/gist_id}","starred_url":"https://api.github.com/users/anshul1886/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anshul1886/subscriptions","organizations_url":"https://api.github.com/users/anshul1886/orgs","repos_url":"https://api.github.com/users/anshul1886/repos","events_url":"https://api.github.com/users/anshul1886/events{/privacy}","received_events_url":"https://api.github.com/users/anshul1886/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anshul1886/cloudstack-1","description":"Mirror of Apache Cloudstack","fork":true,"url":"https://api.github.com/repos/anshul1886/cloudstack-1","forks_url":"https://api.github.com/repos/anshul1886/cloudstack-1/forks","keys_url":"https://api.github.com/repos/anshul1886/cloudstack-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anshul1886/cloudstack-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anshul1886/cloudstack-1/teams","hooks_url":"https://api.github.com/repos/anshul1886/cloudstack-1/hooks","issue_events_url":"https://api.github.com/repos/anshul1886/cloudstack-1/issues/events{/number}","events_url":"https://api.github.com/repos/anshul1886/cloudstack-1/events","assignees_url":"https://api.github.com/repos/anshul1886/cloudstack-1/assignees{/user}","branches_url":"https://api.github.com/repos/anshul1886/cloudstack-1/branches{/branch}","tags_url":"https://api.github.com/repos/anshul1886/cloudstack-1/tags","blobs_url":"https://api.github.com/repos/anshul1886/cloudstack-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anshul1886/cloudstack-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anshul1886/cloudstack-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/anshul1886/cloudstack-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anshul1886/cloudstack-1/statuses/{sha}","languages_url":"https://api.github.com/repos/anshul1886/cloudstack-1/languages","stargazers_url":"https://api.github.com/repos/anshul1886/cloudstack-1/stargazers","contributors_url":"https://api.github.com/repos/anshul1886/cloudstack-1/contributors","subscribers_url":"https://api.github.com/repos/anshul1886/cloudstack-1/subscribers","subscription_url":"https://api.github.com/repos/anshul1886/cloudstack-1/subscription","commits_url":"https://api.github.com/repos/anshul1886/cloudstack-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/anshul1886/cloudstack-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/anshul1886/cloudstack-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/anshul1886/cloudstack-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/anshul1886/cloudstack-1/contents/{+path}","compare_url":"https://api.github.com/repos/anshul1886/cloudstack-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anshul1886/cloudstack-1/merges","archive_url":"https://api.github.com/repos/anshul1886/cloudstack-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anshul1886/cloudstack-1/downloads","issues_url":"https://api.github.com/repos/anshul1886/cloudstack-1/issues{/number}","pulls_url":"https://api.github.com/repos/anshul1886/cloudstack-1/pulls{/number}","milestones_url":"https://api.github.com/repos/anshul1886/cloudstack-1/milestones{/number}","notifications_url":"https://api.github.com/repos/anshul1886/cloudstack-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anshul1886/cloudstack-1/labels{/name}","releases_url":"https://api.github.com/repos/anshul1886/cloudstack-1/releases{/id}","deployments_url":"https://api.github.com/repos/anshul1886/cloudstack-1/deployments","created_at":"2014-10-30T05:52:06Z","updated_at":"2014-11-18T06:08:32Z","pushed_at":"2015-12-24T11:16:48Z","git_url":"git://github.com/anshul1886/cloudstack-1.git","ssh_url":"git@github.com:anshul1886/cloudstack-1.git","clone_url":"https://github.com/anshul1886/cloudstack-1.git","svn_url":"https://github.com/anshul1886/cloudstack-1","homepage":null,"size":494598,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"e8ade2dd9edb59f2bb5aaee1573e03363586c2c2","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":9759448,"name":"cloudstack","full_name":"apache/cloudstack","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/cloudstack","description":"Mirror of Apache Cloudstack","fork":false,"url":"https://api.github.com/repos/apache/cloudstack","forks_url":"https://api.github.com/repos/apache/cloudstack/forks","keys_url":"https://api.github.com/repos/apache/cloudstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/cloudstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/cloudstack/teams","hooks_url":"https://api.github.com/repos/apache/cloudstack/hooks","issue_events_url":"https://api.github.com/repos/apache/cloudstack/issues/events{/number}","events_url":"https://api.github.com/repos/apache/cloudstack/events","assignees_url":"https://api.github.com/repos/apache/cloudstack/assignees{/user}","branches_url":"https://api.github.com/repos/apache/cloudstack/branches{/branch}","tags_url":"https://api.github.com/repos/apache/cloudstack/tags","blobs_url":"https://api.github.com/repos/apache/cloudstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/cloudstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/cloudstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/cloudstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/cloudstack/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/cloudstack/languages","stargazers_url":"https://api.github.com/repos/apache/cloudstack/stargazers","contributors_url":"https://api.github.com/repos/apache/cloudstack/contributors","subscribers_url":"https://api.github.com/repos/apache/cloudstack/subscribers","subscription_url":"https://api.github.com/repos/apache/cloudstack/subscription","commits_url":"https://api.github.com/repos/apache/cloudstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/cloudstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/cloudstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/cloudstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/cloudstack/contents/{+path}","compare_url":"https://api.github.com/repos/apache/cloudstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/cloudstack/merges","archive_url":"https://api.github.com/repos/apache/cloudstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/cloudstack/downloads","issues_url":"https://api.github.com/repos/apache/cloudstack/issues{/number}","pulls_url":"https://api.github.com/repos/apache/cloudstack/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/cloudstack/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/cloudstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/cloudstack/labels{/name}","releases_url":"https://api.github.com/repos/apache/cloudstack/releases{/id}","deployments_url":"https://api.github.com/repos/apache/cloudstack/deployments","created_at":"2013-04-29T22:27:12Z","updated_at":"2016-01-30T06:18:28Z","pushed_at":"2016-01-30T18:02:22Z","git_url":"git://github.com/apache/cloudstack.git","ssh_url":"git@github.com:apache/cloudstack.git","clone_url":"https://github.com/apache/cloudstack.git","svn_url":"https://github.com/apache/cloudstack","homepage":null,"size":511852,"stargazers_count":338,"watchers_count":338,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":428,"mirror_url":"git://git.apache.org/cloudstack.git","open_issues_count":166,"forks":428,"open_issues":166,"watchers":338,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/672"},"html":{"href":"https://github.com/apache/cloudstack/pull/672"},"issue":{"href":"https://api.github.com/repos/apache/cloudstack/issues/672"},"comments":{"href":"https://api.github.com/repos/apache/cloudstack/issues/672/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/672/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/672/commits"},"statuses":{"href":"https://api.github.com/repos/apache/cloudstack/statuses/c91f100b64e17b042dc1596e162f36e344389bcb"}}}}