{"action":"created","issue":{"url":"https://api.github.com/repos/fish-shell/fish-shell/issues/3142","repository_url":"https://api.github.com/repos/fish-shell/fish-shell","labels_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/3142/labels{/name}","comments_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/3142/comments","events_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/3142/events","html_url":"https://github.com/fish-shell/fish-shell/pull/3142","id":160092398,"number":3142,"title":"A couple checks for builtin string in scripts","user":{"login":"floam","id":291142,"avatar_url":"https://avatars.githubusercontent.com/u/291142?v=3","gravatar_id":"","url":"https://api.github.com/users/floam","html_url":"https://github.com/floam","followers_url":"https://api.github.com/users/floam/followers","following_url":"https://api.github.com/users/floam/following{/other_user}","gists_url":"https://api.github.com/users/floam/gists{/gist_id}","starred_url":"https://api.github.com/users/floam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floam/subscriptions","organizations_url":"https://api.github.com/users/floam/orgs","repos_url":"https://api.github.com/users/floam/repos","events_url":"https://api.github.com/users/floam/events{/privacy}","received_events_url":"https://api.github.com/users/floam/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-06-14T03:54:45Z","updated_at":"2016-06-14T09:43:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/fish-shell/fish-shell/pulls/3142","html_url":"https://github.com/fish-shell/fish-shell/pull/3142","diff_url":"https://github.com/fish-shell/fish-shell/pull/3142.diff","patch_url":"https://github.com/fish-shell/fish-shell/pull/3142.patch"},"body":"Improves experience when upgrading from 2.2.0 or accidentally running an a pre-2.3.0 fish on an environment that uses `string`. This nixes errors caused just printing a prompt. Fixes #3141. I only tested this on my system but I think it's pretty reasonable. Only a couple changes were necessary to axe annoying errors which cause a lot of noise. "},"comment":{"url":"https://api.github.com/repos/fish-shell/fish-shell/issues/comments/225831508","html_url":"https://github.com/fish-shell/fish-shell/pull/3142#issuecomment-225831508","issue_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/3142","id":225831508,"user":{"login":"faho","id":5185367,"avatar_url":"https://avatars.githubusercontent.com/u/5185367?v=3","gravatar_id":"","url":"https://api.github.com/users/faho","html_url":"https://github.com/faho","followers_url":"https://api.github.com/users/faho/followers","following_url":"https://api.github.com/users/faho/following{/other_user}","gists_url":"https://api.github.com/users/faho/gists{/gist_id}","starred_url":"https://api.github.com/users/faho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faho/subscriptions","organizations_url":"https://api.github.com/users/faho/orgs","repos_url":"https://api.github.com/users/faho/repos","events_url":"https://api.github.com/users/faho/events{/privacy}","received_events_url":"https://api.github.com/users/faho/received_events","type":"User","site_admin":false},"created_at":"2016-06-14T09:43:00Z","updated_at":"2016-06-14T09:43:00Z","body":"@floam: Did you actually see any issues without the check in config.fish? I don't think you'd hit that one on upgrade. And even if you did, because of #1428 it would be too late anyway, as pre-2.3.0 fish would already be in the if-branch.\r\n\r\nAnyway, this is papering over an issue - running 2.3.0 scripts with 2.2.0. `string` is certainly the most visible issue there, but I think the `and`/`or` changes could also break a few things - it would just be much harder to figure that one out.\r\n\r\nThat means we currently absolutely want the user to stop using old fish instances. How would this look if we printed a message to that effect?"}}
{"actor":{"display_login":"faho"}}