{"action":"created","issue":{"url":"https://api.github.com/repos/seccomp/libseccomp-golang/issues/15","repository_url":"https://api.github.com/repos/seccomp/libseccomp-golang","labels_url":"https://api.github.com/repos/seccomp/libseccomp-golang/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/seccomp/libseccomp-golang/issues/15/comments","events_url":"https://api.github.com/repos/seccomp/libseccomp-golang/issues/15/events","html_url":"https://github.com/seccomp/libseccomp-golang/pull/15","id":191215047,"number":15,"title":"seccomp, utility: Introduce GetRuntimeLibraryVersion.","user":{"login":"thorduri","id":1232165,"avatar_url":"https://avatars.githubusercontent.com/u/1232165?v=3","gravatar_id":"","url":"https://api.github.com/users/thorduri","html_url":"https://github.com/thorduri","followers_url":"https://api.github.com/users/thorduri/followers","following_url":"https://api.github.com/users/thorduri/following{/other_user}","gists_url":"https://api.github.com/users/thorduri/gists{/gist_id}","starred_url":"https://api.github.com/users/thorduri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thorduri/subscriptions","organizations_url":"https://api.github.com/users/thorduri/orgs","repos_url":"https://api.github.com/users/thorduri/repos","events_url":"https://api.github.com/users/thorduri/events{/privacy}","received_events_url":"https://api.github.com/users/thorduri/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-23T08:50:43Z","updated_at":"2016-11-23T16:56:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/seccomp/libseccomp-golang/pulls/15","html_url":"https://github.com/seccomp/libseccomp-golang/pull/15","diff_url":"https://github.com/seccomp/libseccomp-golang/pull/15.diff","patch_url":"https://github.com/seccomp/libseccomp-golang/pull/15.patch"},"body":"Uses the libseccomp `seccomp_version` (v2.3.0) to retrive the runtime version of the library.\r\n\r\nThis should probably not be merged until the discussions in #11 and #4 are finished.\r\n\r\nI'd like to advocate for the removal of the `init()` error and exit, it's unidiomatic.\r\nReturning an error from `NewFilter` based off of the current release of the bindings\r\nwhen that happens, and the runtime version (slight modification of #6).\r\n\r\nSigned-off-by: Thordur Bjornsson <thorduri@secnorth.net>"},"comment":{"url":"https://api.github.com/repos/seccomp/libseccomp-golang/issues/comments/262571631","html_url":"https://github.com/seccomp/libseccomp-golang/pull/15#issuecomment-262571631","issue_url":"https://api.github.com/repos/seccomp/libseccomp-golang/issues/15","id":262571631,"user":{"login":"thorduri","id":1232165,"avatar_url":"https://avatars.githubusercontent.com/u/1232165?v=3","gravatar_id":"","url":"https://api.github.com/users/thorduri","html_url":"https://github.com/thorduri","followers_url":"https://api.github.com/users/thorduri/followers","following_url":"https://api.github.com/users/thorduri/following{/other_user}","gists_url":"https://api.github.com/users/thorduri/gists{/gist_id}","starred_url":"https://api.github.com/users/thorduri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thorduri/subscriptions","organizations_url":"https://api.github.com/users/thorduri/orgs","repos_url":"https://api.github.com/users/thorduri/repos","events_url":"https://api.github.com/users/thorduri/events{/privacy}","received_events_url":"https://api.github.com/users/thorduri/received_events","type":"User","site_admin":false},"created_at":"2016-11-23T16:56:42Z","updated_at":"2016-11-23T16:56:42Z","body":"> Looks good when built against versions of libseccomp supplying seccomp_version, but we can't guarantee we're building against v2.3.0.\r\n\r\nApologies if I wasn't clear enough, or failed to communicate my assumptions. \r\n\r\nMy hope is that when the discussions in #11 and #4 are concluded, and tagging parity is reached is\r\nthat version x.y.z of the bindings works with version x.y.z of the library, without any gating of functionality -- i.e. building version x.y.z of the binding, must be done against version x.y.z of the library, and the runtime must be x.y.z as well.\r\n \r\nIs that reasonable ?\r\n\r\n> On the init() error - I tend to agree, though I'd prefer if we don't just check at NewFilter() but also all the non-filter-related functions that call into the library (for example GetSyscallFromName).\r\n\r\nGood point. I will do the `checkVersionAbove` dance where applicable.\r\n"}}
{"actor":{"display_login":"thorduri"}}