{"action":"created","comment":{"url":"https://api.github.com/repos/lsst/ip_diffim/pulls/comments/60329401","id":60329401,"diff_hunk":"@@ -74,34 +83,35 @@ def __init__(self, xc=np.array([65.3, 24.2]), yc=np.array([38.6, 78.5])):\n             xcenNeg=self.xc - self.offsets,\n             ycenNeg=self.yc - self.offsets,\n             flux=self.flux, fluxNeg=self.flux,\n+            noise=2.,  # Note the input noise - this affects the relative tolerances used.\n             gradientParams=self.gradientParams)\n \n         self.catalog = self.testImage.detectDipoleSources()\n+        self.rtol = 0.01  # This is okay given the default noise of 2. set above.","path":"tests/testDipoleFitter.py","position":null,"original_position":62,"commit_id":"280ef1ee5793beff086801d11d024b3833035cb0","original_commit_id":"280ef1ee5793beff086801d11d024b3833035cb0","user":{"login":"PaulPrice","id":1334980,"avatar_url":"https://avatars.githubusercontent.com/u/1334980?v=3","gravatar_id":"","url":"https://api.github.com/users/PaulPrice","html_url":"https://github.com/PaulPrice","followers_url":"https://api.github.com/users/PaulPrice/followers","following_url":"https://api.github.com/users/PaulPrice/following{/other_user}","gists_url":"https://api.github.com/users/PaulPrice/gists{/gist_id}","starred_url":"https://api.github.com/users/PaulPrice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaulPrice/subscriptions","organizations_url":"https://api.github.com/users/PaulPrice/orgs","repos_url":"https://api.github.com/users/PaulPrice/repos","events_url":"https://api.github.com/users/PaulPrice/events{/privacy}","received_events_url":"https://api.github.com/users/PaulPrice/received_events","type":"User","site_admin":false},"body":"Why use a single tolerance for the fluxes and centroids, when they're known to have different performance?","created_at":"2016-04-19T23:25:58Z","updated_at":"2016-04-19T23:25:58Z","html_url":"https://github.com/lsst/ip_diffim/pull/10#discussion_r60329401","pull_request_url":"https://api.github.com/repos/lsst/ip_diffim/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/lsst/ip_diffim/pulls/comments/60329401"},"html":{"href":"https://github.com/lsst/ip_diffim/pull/10#discussion_r60329401"},"pull_request":{"href":"https://api.github.com/repos/lsst/ip_diffim/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/lsst/ip_diffim/pulls/10","id":66172682,"html_url":"https://github.com/lsst/ip_diffim/pull/10","diff_url":"https://github.com/lsst/ip_diffim/pull/10.diff","patch_url":"https://github.com/lsst/ip_diffim/pull/10.patch","issue_url":"https://api.github.com/repos/lsst/ip_diffim/issues/10","number":10,"state":"open","locked":false,"title":"Rewrite unit tests for new dipole measurement task","user":{"login":"timj","id":60622,"avatar_url":"https://avatars.githubusercontent.com/u/60622?v=3","gravatar_id":"","url":"https://api.github.com/users/timj","html_url":"https://github.com/timj","followers_url":"https://api.github.com/users/timj/followers","following_url":"https://api.github.com/users/timj/following{/other_user}","gists_url":"https://api.github.com/users/timj/gists{/gist_id}","starred_url":"https://api.github.com/users/timj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timj/subscriptions","organizations_url":"https://api.github.com/users/timj/orgs","repos_url":"https://api.github.com/users/timj/repos","events_url":"https://api.github.com/users/timj/events{/privacy}","received_events_url":"https://api.github.com/users/timj/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-04-12T14:58:56Z","updated_at":"2016-04-19T23:25:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80ffeb16d2604d64627e34572f3fd2d55409d725","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lsst/ip_diffim/pulls/10/commits","review_comments_url":"https://api.github.com/repos/lsst/ip_diffim/pulls/10/comments","review_comment_url":"https://api.github.com/repos/lsst/ip_diffim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lsst/ip_diffim/issues/10/comments","statuses_url":"https://api.github.com/repos/lsst/ip_diffim/statuses/280ef1ee5793beff086801d11d024b3833035cb0","head":{"label":"lsst:tickets/DM-5296","ref":"tickets/DM-5296","sha":"280ef1ee5793beff086801d11d024b3833035cb0","user":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":23013321,"name":"ip_diffim","full_name":"lsst/ip_diffim","owner":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/ip_diffim","description":"LSST data management: astronomical image differencing","fork":false,"url":"https://api.github.com/repos/lsst/ip_diffim","forks_url":"https://api.github.com/repos/lsst/ip_diffim/forks","keys_url":"https://api.github.com/repos/lsst/ip_diffim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/ip_diffim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/ip_diffim/teams","hooks_url":"https://api.github.com/repos/lsst/ip_diffim/hooks","issue_events_url":"https://api.github.com/repos/lsst/ip_diffim/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/ip_diffim/events","assignees_url":"https://api.github.com/repos/lsst/ip_diffim/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/ip_diffim/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/ip_diffim/tags","blobs_url":"https://api.github.com/repos/lsst/ip_diffim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/ip_diffim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/ip_diffim/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/ip_diffim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/ip_diffim/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/ip_diffim/languages","stargazers_url":"https://api.github.com/repos/lsst/ip_diffim/stargazers","contributors_url":"https://api.github.com/repos/lsst/ip_diffim/contributors","subscribers_url":"https://api.github.com/repos/lsst/ip_diffim/subscribers","subscription_url":"https://api.github.com/repos/lsst/ip_diffim/subscription","commits_url":"https://api.github.com/repos/lsst/ip_diffim/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/ip_diffim/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/ip_diffim/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/ip_diffim/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/ip_diffim/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/ip_diffim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/ip_diffim/merges","archive_url":"https://api.github.com/repos/lsst/ip_diffim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/ip_diffim/downloads","issues_url":"https://api.github.com/repos/lsst/ip_diffim/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/ip_diffim/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/ip_diffim/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/ip_diffim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/ip_diffim/labels{/name}","releases_url":"https://api.github.com/repos/lsst/ip_diffim/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/ip_diffim/deployments","created_at":"2014-08-16T07:44:12Z","updated_at":"2016-04-11T22:01:34Z","pushed_at":"2016-04-19T16:34:51Z","git_url":"git://github.com/lsst/ip_diffim.git","ssh_url":"git@github.com:lsst/ip_diffim.git","clone_url":"https://github.com/lsst/ip_diffim.git","svn_url":"https://github.com/lsst/ip_diffim","homepage":"http://dm.lsst.org/","size":16118,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"lsst:master","ref":"master","sha":"0f48044308d38af9aa6ab6a59b64f54fb453ded4","user":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":23013321,"name":"ip_diffim","full_name":"lsst/ip_diffim","owner":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/ip_diffim","description":"LSST data management: astronomical image differencing","fork":false,"url":"https://api.github.com/repos/lsst/ip_diffim","forks_url":"https://api.github.com/repos/lsst/ip_diffim/forks","keys_url":"https://api.github.com/repos/lsst/ip_diffim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/ip_diffim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/ip_diffim/teams","hooks_url":"https://api.github.com/repos/lsst/ip_diffim/hooks","issue_events_url":"https://api.github.com/repos/lsst/ip_diffim/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/ip_diffim/events","assignees_url":"https://api.github.com/repos/lsst/ip_diffim/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/ip_diffim/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/ip_diffim/tags","blobs_url":"https://api.github.com/repos/lsst/ip_diffim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/ip_diffim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/ip_diffim/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/ip_diffim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/ip_diffim/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/ip_diffim/languages","stargazers_url":"https://api.github.com/repos/lsst/ip_diffim/stargazers","contributors_url":"https://api.github.com/repos/lsst/ip_diffim/contributors","subscribers_url":"https://api.github.com/repos/lsst/ip_diffim/subscribers","subscription_url":"https://api.github.com/repos/lsst/ip_diffim/subscription","commits_url":"https://api.github.com/repos/lsst/ip_diffim/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/ip_diffim/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/ip_diffim/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/ip_diffim/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/ip_diffim/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/ip_diffim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/ip_diffim/merges","archive_url":"https://api.github.com/repos/lsst/ip_diffim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/ip_diffim/downloads","issues_url":"https://api.github.com/repos/lsst/ip_diffim/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/ip_diffim/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/ip_diffim/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/ip_diffim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/ip_diffim/labels{/name}","releases_url":"https://api.github.com/repos/lsst/ip_diffim/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/ip_diffim/deployments","created_at":"2014-08-16T07:44:12Z","updated_at":"2016-04-11T22:01:34Z","pushed_at":"2016-04-19T16:34:51Z","git_url":"git://github.com/lsst/ip_diffim.git","ssh_url":"git@github.com:lsst/ip_diffim.git","clone_url":"https://github.com/lsst/ip_diffim.git","svn_url":"https://github.com/lsst/ip_diffim","homepage":"http://dm.lsst.org/","size":16118,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lsst/ip_diffim/pulls/10"},"html":{"href":"https://github.com/lsst/ip_diffim/pull/10"},"issue":{"href":"https://api.github.com/repos/lsst/ip_diffim/issues/10"},"comments":{"href":"https://api.github.com/repos/lsst/ip_diffim/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/lsst/ip_diffim/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/lsst/ip_diffim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lsst/ip_diffim/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/lsst/ip_diffim/statuses/280ef1ee5793beff086801d11d024b3833035cb0"}}}}