{"action":"created","issue":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17850","repository_url":"https://api.github.com/repos/TrinityCore/TrinityCore","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17850/labels{/name}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17850/comments","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17850/events","html_url":"https://github.com/TrinityCore/TrinityCore/pull/17850","id":172772703,"number":17850,"title":"[WIP] Core/Movement: Targeted MoveGen Improvements","user":{"login":"chaodhib","id":6612710,"avatar_url":"https://avatars.githubusercontent.com/u/6612710?v=3","gravatar_id":"","url":"https://api.github.com/users/chaodhib","html_url":"https://github.com/chaodhib","followers_url":"https://api.github.com/users/chaodhib/followers","following_url":"https://api.github.com/users/chaodhib/following{/other_user}","gists_url":"https://api.github.com/users/chaodhib/gists{/gist_id}","starred_url":"https://api.github.com/users/chaodhib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaodhib/subscriptions","organizations_url":"https://api.github.com/users/chaodhib/orgs","repos_url":"https://api.github.com/users/chaodhib/repos","events_url":"https://api.github.com/users/chaodhib/events{/privacy}","received_events_url":"https://api.github.com/users/chaodhib/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels/Branch-3.3.5a","name":"Branch-3.3.5a","color":"188846"},{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels/Comp-Core","name":"Comp-Core","color":"FF6600"},{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels/Feedback-FixOutdatedMissingWIP","name":"Feedback-FixOutdatedMissingWIP","color":"d7e102"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2016-08-23T18:31:34Z","updated_at":"2016-08-29T15:23:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/17850","html_url":"https://github.com/TrinityCore/TrinityCore/pull/17850","diff_url":"https://github.com/TrinityCore/TrinityCore/pull/17850.diff","patch_url":"https://github.com/TrinityCore/TrinityCore/pull/17850.patch"},"body":"# Work in progress PR\r\n\r\n## **Planned changes:**\r\nMajor changes:\r\n- Changing how the way the destination point of each NPC path is determined. Up until now, each time a creature had to move, first a destination point was computed. And only then a path leading to that point was generated. Now it's the other way around. The destination point is actually deduced from the path itself. We first generate a path to the target's location and then remove from the path a certain length: the distance at which the npc should stand.\r\n\r\nIn the only commit yet, this is already implemented but only for MoveChase. Also, ReducePathLenghtByDist needs to be improved in order to make sure that after that method call, the last point of the path is always in LoS of the target & at the right distance.\r\n\r\nMinor changes:\r\n-  From sniff analysis, I found that the standard distance at which NPCs stand after chasing another unit is 'Chaser->CombatReach + Target->CombatReach' instead of 'Chaser->CombatReach + Target->CombatReach + 0.5'.\r\n- From sniff analysis, I believe pets follow their masters at a 3 constant yard distance.\r\n-  Planning to remove the third parameter of MoveChase (the angle).\r\n\r\n**Target branch(es):** 3.3.5\r\n\r\n**Issues addressed:** Should fix quite a lot of issues related to NPC movements\r\n\r\n**Tests performed:** WIP. Build and tested IG for what I have so far.\r\n"},"comment":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments/243157199","html_url":"https://github.com/TrinityCore/TrinityCore/pull/17850#issuecomment-243157199","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17850","id":243157199,"user":{"login":"jackpoz","id":1153754,"avatar_url":"https://avatars.githubusercontent.com/u/1153754?v=3","gravatar_id":"","url":"https://api.github.com/users/jackpoz","html_url":"https://github.com/jackpoz","followers_url":"https://api.github.com/users/jackpoz/followers","following_url":"https://api.github.com/users/jackpoz/following{/other_user}","gists_url":"https://api.github.com/users/jackpoz/gists{/gist_id}","starred_url":"https://api.github.com/users/jackpoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackpoz/subscriptions","organizations_url":"https://api.github.com/users/jackpoz/orgs","repos_url":"https://api.github.com/users/jackpoz/repos","events_url":"https://api.github.com/users/jackpoz/events{/privacy}","received_events_url":"https://api.github.com/users/jackpoz/received_events","type":"User","site_admin":false},"created_at":"2016-08-29T15:23:28Z","updated_at":"2016-08-29T15:23:28Z","body":"> 1. Take a straight line from self to target\r\n\r\nisn't the current 1st step \"find a point close to target\" https://github.com/TrinityCore/TrinityCore/pull/17850/files#diff-268a0e4eced8ee7bb5139f6c2b47034cL61 ?\r\nwhat's the difference between \"find a point close to target then walk to the point\" to \"walk to target then find a point close to target\" ? Just the angle between where the unit is walking from, the target and when the unit will stand when it stops ?"}}
{"actor":{"display_login":"jackpoz"}}