{"action":"closed","number":15248,"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/15248","id":65026152,"html_url":"https://github.com/ansible/ansible/pull/15248","diff_url":"https://github.com/ansible/ansible/pull/15248.diff","patch_url":"https://github.com/ansible/ansible/pull/15248.patch","issue_url":"https://api.github.com/repos/ansible/ansible/issues/15248","number":15248,"state":"closed","locked":false,"title":"Fix async for old style modules and don't send an args file for new-style modules","user":{"login":"abadger","id":209242,"avatar_url":"https://avatars.githubusercontent.com/u/209242?v=3","gravatar_id":"","url":"https://api.github.com/users/abadger","html_url":"https://github.com/abadger","followers_url":"https://api.github.com/users/abadger/followers","following_url":"https://api.github.com/users/abadger/following{/other_user}","gists_url":"https://api.github.com/users/abadger/gists{/gist_id}","starred_url":"https://api.github.com/users/abadger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abadger/subscriptions","organizations_url":"https://api.github.com/users/abadger/orgs","repos_url":"https://api.github.com/users/abadger/repos","events_url":"https://api.github.com/users/abadger/events{/privacy}","received_events_url":"https://api.github.com/users/abadger/received_events","type":"User","site_admin":false},"body":"##### ISSUE TYPE\r\n - Bugfix Pull Request\r\n\r\n##### SUMMARY\r\n\r\nDiscovered that async wasn't properly formatting arguments for old-style modules.  They need key=value but async was trying to send json.\r\n\r\nAlso made it so we don't send an argument file for new-style modules.  New-style modules have the arguments embedded inside of them so there's no need to send arguments as a separate file.","created_at":"2016-04-02T02:58:57Z","updated_at":"2016-04-02T03:04:37Z","closed_at":"2016-04-02T03:04:36Z","merged_at":"2016-04-02T03:04:36Z","merge_commit_sha":"441fe445697f0f6a9c4edd146800eef4551ba9a1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible/pulls/15248/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible/pulls/15248/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/15248/comments","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/4ccea9905b2484ade3f91cdc5be9a9c0867e9672","head":{"label":"abadger:fix-async","ref":"fix-async","sha":"4ccea9905b2484ade3f91cdc5be9a9c0867e9672","user":{"login":"abadger","id":209242,"avatar_url":"https://avatars.githubusercontent.com/u/209242?v=3","gravatar_id":"","url":"https://api.github.com/users/abadger","html_url":"https://github.com/abadger","followers_url":"https://api.github.com/users/abadger/followers","following_url":"https://api.github.com/users/abadger/following{/other_user}","gists_url":"https://api.github.com/users/abadger/gists{/gist_id}","starred_url":"https://api.github.com/users/abadger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abadger/subscriptions","organizations_url":"https://api.github.com/users/abadger/orgs","repos_url":"https://api.github.com/users/abadger/repos","events_url":"https://api.github.com/users/abadger/events{/privacy}","received_events_url":"https://api.github.com/users/abadger/received_events","type":"User","site_admin":false},"repo":{"id":17755774,"name":"ansible","full_name":"abadger/ansible","owner":{"login":"abadger","id":209242,"avatar_url":"https://avatars.githubusercontent.com/u/209242?v=3","gravatar_id":"","url":"https://api.github.com/users/abadger","html_url":"https://github.com/abadger","followers_url":"https://api.github.com/users/abadger/followers","following_url":"https://api.github.com/users/abadger/following{/other_user}","gists_url":"https://api.github.com/users/abadger/gists{/gist_id}","starred_url":"https://api.github.com/users/abadger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abadger/subscriptions","organizations_url":"https://api.github.com/users/abadger/orgs","repos_url":"https://api.github.com/users/abadger/repos","events_url":"https://api.github.com/users/abadger/events{/privacy}","received_events_url":"https://api.github.com/users/abadger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abadger/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":true,"url":"https://api.github.com/repos/abadger/ansible","forks_url":"https://api.github.com/repos/abadger/ansible/forks","keys_url":"https://api.github.com/repos/abadger/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abadger/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abadger/ansible/teams","hooks_url":"https://api.github.com/repos/abadger/ansible/hooks","issue_events_url":"https://api.github.com/repos/abadger/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/abadger/ansible/events","assignees_url":"https://api.github.com/repos/abadger/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/abadger/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/abadger/ansible/tags","blobs_url":"https://api.github.com/repos/abadger/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abadger/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abadger/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/abadger/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abadger/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/abadger/ansible/languages","stargazers_url":"https://api.github.com/repos/abadger/ansible/stargazers","contributors_url":"https://api.github.com/repos/abadger/ansible/contributors","subscribers_url":"https://api.github.com/repos/abadger/ansible/subscribers","subscription_url":"https://api.github.com/repos/abadger/ansible/subscription","commits_url":"https://api.github.com/repos/abadger/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/abadger/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/abadger/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/abadger/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/abadger/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/abadger/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abadger/ansible/merges","archive_url":"https://api.github.com/repos/abadger/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abadger/ansible/downloads","issues_url":"https://api.github.com/repos/abadger/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/abadger/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/abadger/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/abadger/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abadger/ansible/labels{/name}","releases_url":"https://api.github.com/repos/abadger/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/abadger/ansible/deployments","created_at":"2014-03-14T18:20:10Z","updated_at":"2016-03-10T15:07:40Z","pushed_at":"2016-04-02T03:04:31Z","git_url":"git://github.com/abadger/ansible.git","ssh_url":"git@github.com:abadger/ansible.git","clone_url":"https://github.com/abadger/ansible.git","svn_url":"https://github.com/abadger/ansible","homepage":"http://ansible.com/","size":40060,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"d9ecff9d4f1b007c782c77952624c05ec66f1dea","user":{"login":"ansible","id":1507452,"avatar_url":"https://avatars.githubusercontent.com/u/1507452?v=3","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":3638964,"name":"ansible","full_name":"ansible/ansible","owner":{"login":"ansible","id":1507452,"avatar_url":"https://avatars.githubusercontent.com/u/1507452?v=3","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ansible/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":false,"url":"https://api.github.com/repos/ansible/ansible","forks_url":"https://api.github.com/repos/ansible/ansible/forks","keys_url":"https://api.github.com/repos/ansible/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible/teams","hooks_url":"https://api.github.com/repos/ansible/ansible/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible/events","assignees_url":"https://api.github.com/repos/ansible/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible/tags","blobs_url":"https://api.github.com/repos/ansible/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible/subscription","commits_url":"https://api.github.com/repos/ansible/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible/merges","archive_url":"https://api.github.com/repos/ansible/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible/downloads","issues_url":"https://api.github.com/repos/ansible/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/ansible/deployments","created_at":"2012-03-06T14:58:02Z","updated_at":"2016-04-01T22:55:35Z","pushed_at":"2016-04-02T03:04:36Z","git_url":"git://github.com/ansible/ansible.git","ssh_url":"git@github.com:ansible/ansible.git","clone_url":"https://github.com/ansible/ansible.git","svn_url":"https://github.com/ansible/ansible","homepage":"http://ansible.com/","size":55133,"stargazers_count":16119,"watchers_count":16119,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4808,"mirror_url":null,"open_issues_count":1242,"forks":4808,"open_issues":1242,"watchers":16119,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/15248"},"html":{"href":"https://github.com/ansible/ansible/pull/15248"},"issue":{"href":"https://api.github.com/repos/ansible/ansible/issues/15248"},"comments":{"href":"https://api.github.com/repos/ansible/ansible/issues/15248/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible/pulls/15248/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible/pulls/15248/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible/statuses/4ccea9905b2484ade3f91cdc5be9a9c0867e9672"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"nitzmahone","id":6775756,"avatar_url":"https://avatars.githubusercontent.com/u/6775756?v=3","gravatar_id":"","url":"https://api.github.com/users/nitzmahone","html_url":"https://github.com/nitzmahone","followers_url":"https://api.github.com/users/nitzmahone/followers","following_url":"https://api.github.com/users/nitzmahone/following{/other_user}","gists_url":"https://api.github.com/users/nitzmahone/gists{/gist_id}","starred_url":"https://api.github.com/users/nitzmahone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitzmahone/subscriptions","organizations_url":"https://api.github.com/users/nitzmahone/orgs","repos_url":"https://api.github.com/users/nitzmahone/repos","events_url":"https://api.github.com/users/nitzmahone/events{/privacy}","received_events_url":"https://api.github.com/users/nitzmahone/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":13,"deletions":3,"changed_files":1}}