{"action":"created","issue":{"url":"https://api.github.com/repos/exercism/xelixir/issues/99","labels_url":"https://api.github.com/repos/exercism/xelixir/issues/99/labels{/name}","comments_url":"https://api.github.com/repos/exercism/xelixir/issues/99/comments","events_url":"https://api.github.com/repos/exercism/xelixir/issues/99/events","html_url":"https://github.com/exercism/xelixir/pull/99","id":128265623,"number":99,"title":"dries up the code loading logic for each test file","user":{"login":"mindreframer","id":1232,"avatar_url":"https://avatars.githubusercontent.com/u/1232?v=3","gravatar_id":"","url":"https://api.github.com/users/mindreframer","html_url":"https://github.com/mindreframer","followers_url":"https://api.github.com/users/mindreframer/followers","following_url":"https://api.github.com/users/mindreframer/following{/other_user}","gists_url":"https://api.github.com/users/mindreframer/gists{/gist_id}","starred_url":"https://api.github.com/users/mindreframer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mindreframer/subscriptions","organizations_url":"https://api.github.com/users/mindreframer/orgs","repos_url":"https://api.github.com/users/mindreframer/repos","events_url":"https://api.github.com/users/mindreframer/events{/privacy}","received_events_url":"https://api.github.com/users/mindreframer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-01-22T22:54:00Z","updated_at":"2016-01-26T04:24:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/exercism/xelixir/pulls/99","html_url":"https://github.com/exercism/xelixir/pull/99","diff_url":"https://github.com/exercism/xelixir/pull/99.diff","patch_url":"https://github.com/exercism/xelixir/pull/99.patch"},"body":"problem: \r\n- each test file has some boilerplate code for loading either example or the users implementation  + starting ExUnit\r\n- running all tests with test/test_helper via `mix test` did not work\r\n\r\n\r\nsolution: \r\n- provide a file_loader, that has the logic bits which file to load\r\n- it is also starting the ExUnit and centralizes the configuration for it\r\n- update the test/test_helper to do a bit less\r\n- update SETUP.md with instructions how to run test for all examples \r\n\r\n\r\nGotchas: \r\n- you will see warnings due to redefined FileLoader module: \r\n`file_loader.ex:1: warning: redefining module FileLoader`"},"comment":{"url":"https://api.github.com/repos/exercism/xelixir/issues/comments/174815540","html_url":"https://github.com/exercism/xelixir/pull/99#issuecomment-174815540","issue_url":"https://api.github.com/repos/exercism/xelixir/issues/99","id":174815540,"user":{"login":"parkerl","id":450084,"avatar_url":"https://avatars.githubusercontent.com/u/450084?v=3","gravatar_id":"","url":"https://api.github.com/users/parkerl","html_url":"https://github.com/parkerl","followers_url":"https://api.github.com/users/parkerl/followers","following_url":"https://api.github.com/users/parkerl/following{/other_user}","gists_url":"https://api.github.com/users/parkerl/gists{/gist_id}","starred_url":"https://api.github.com/users/parkerl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parkerl/subscriptions","organizations_url":"https://api.github.com/users/parkerl/orgs","repos_url":"https://api.github.com/users/parkerl/repos","events_url":"https://api.github.com/users/parkerl/events{/privacy}","received_events_url":"https://api.github.com/users/parkerl/received_events","type":"User","site_admin":false},"created_at":"2016-01-26T04:24:11Z","updated_at":"2016-01-26T04:24:11Z","body":"@mindreframer thanks for your PR! As you said above, the expected way to run all tests is in the travis.yml. We do need to document that in the README asap. \r\n\r\nI have mixed feelings about merging this PR. I appreciate your hard work but this is a rather sweeping change that was not previously discussed. I humbly suggest that in the future you open an issue before composing such a PR. \r\n\r\n@rubysolo what are your thoughts on this one?"}}