{"action":"closed","number":310,"pull_request":{"url":"https://api.github.com/repos/line/armeria/pulls/310","id":89962251,"html_url":"https://github.com/line/armeria/pull/310","diff_url":"https://github.com/line/armeria/pull/310.diff","patch_url":"https://github.com/line/armeria/pull/310.patch","issue_url":"https://api.github.com/repos/line/armeria/issues/310","number":310,"state":"closed","locked":false,"title":"Make EndpointGroupRegistry.register() replace and Add unregister()","user":{"login":"trustin","id":173918,"avatar_url":"https://avatars.githubusercontent.com/u/173918?v=3","gravatar_id":"","url":"https://api.github.com/users/trustin","html_url":"https://github.com/trustin","followers_url":"https://api.github.com/users/trustin/followers","following_url":"https://api.github.com/users/trustin/following{/other_user}","gists_url":"https://api.github.com/users/trustin/gists{/gist_id}","starred_url":"https://api.github.com/users/trustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustin/subscriptions","organizations_url":"https://api.github.com/users/trustin/orgs","repos_url":"https://api.github.com/users/trustin/repos","events_url":"https://api.github.com/users/trustin/events{/privacy}","received_events_url":"https://api.github.com/users/trustin/received_events","type":"User","site_admin":false},"body":"Motivation:\r\n\r\nIn a multiple-classloader environment, an application can invoke\r\nEndpointGroupRegistry.register() multiple times with the same group name\r\nwhen the application is reloaded by the class loader, causing register()\r\ntrigger an EndpointGroupException.\r\n\r\nModifications:\r\n\r\n- Remove EndpointGroupRegistry.replace()\r\n- Make EndpointGroupRegistry.register() replace.\r\n- Add EndpointGroupRegistry.unregister()\r\n\r\nResult:\r\n\r\nLess surprising behavior","created_at":"2016-10-19T08:25:35Z","updated_at":"2016-10-19T09:03:43Z","closed_at":"2016-10-19T09:03:43Z","merged_at":"2016-10-19T09:03:43Z","merge_commit_sha":"1e6b034c3a06decb57a504af84af11f48cae3bc1","assignee":{"login":"imasahiro","id":73532,"avatar_url":"https://avatars.githubusercontent.com/u/73532?v=3","gravatar_id":"","url":"https://api.github.com/users/imasahiro","html_url":"https://github.com/imasahiro","followers_url":"https://api.github.com/users/imasahiro/followers","following_url":"https://api.github.com/users/imasahiro/following{/other_user}","gists_url":"https://api.github.com/users/imasahiro/gists{/gist_id}","starred_url":"https://api.github.com/users/imasahiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imasahiro/subscriptions","organizations_url":"https://api.github.com/users/imasahiro/orgs","repos_url":"https://api.github.com/users/imasahiro/repos","events_url":"https://api.github.com/users/imasahiro/events{/privacy}","received_events_url":"https://api.github.com/users/imasahiro/received_events","type":"User","site_admin":false},"assignees":[{"login":"imasahiro","id":73532,"avatar_url":"https://avatars.githubusercontent.com/u/73532?v=3","gravatar_id":"","url":"https://api.github.com/users/imasahiro","html_url":"https://github.com/imasahiro","followers_url":"https://api.github.com/users/imasahiro/followers","following_url":"https://api.github.com/users/imasahiro/following{/other_user}","gists_url":"https://api.github.com/users/imasahiro/gists{/gist_id}","starred_url":"https://api.github.com/users/imasahiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imasahiro/subscriptions","organizations_url":"https://api.github.com/users/imasahiro/orgs","repos_url":"https://api.github.com/users/imasahiro/repos","events_url":"https://api.github.com/users/imasahiro/events{/privacy}","received_events_url":"https://api.github.com/users/imasahiro/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/line/armeria/milestones/50","html_url":"https://github.com/line/armeria/milestones/0.29.0.Final","labels_url":"https://api.github.com/repos/line/armeria/milestones/50/labels","id":2051238,"number":50,"title":"0.29.0.Final","description":null,"creator":{"login":"trustin","id":173918,"avatar_url":"https://avatars.githubusercontent.com/u/173918?v=3","gravatar_id":"","url":"https://api.github.com/users/trustin","html_url":"https://github.com/trustin","followers_url":"https://api.github.com/users/trustin/followers","following_url":"https://api.github.com/users/trustin/following{/other_user}","gists_url":"https://api.github.com/users/trustin/gists{/gist_id}","starred_url":"https://api.github.com/users/trustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustin/subscriptions","organizations_url":"https://api.github.com/users/trustin/orgs","repos_url":"https://api.github.com/users/trustin/repos","events_url":"https://api.github.com/users/trustin/events{/privacy}","received_events_url":"https://api.github.com/users/trustin/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":9,"state":"open","created_at":"2016-10-06T05:27:25Z","updated_at":"2016-10-19T09:03:43Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/line/armeria/pulls/310/commits","review_comments_url":"https://api.github.com/repos/line/armeria/pulls/310/comments","review_comment_url":"https://api.github.com/repos/line/armeria/pulls/comments{/number}","comments_url":"https://api.github.com/repos/line/armeria/issues/310/comments","statuses_url":"https://api.github.com/repos/line/armeria/statuses/7d921a4fc76dfd019565f60f65459c80c54514da","head":{"label":"trustin:endpointgroupregistry_fixes","ref":"endpointgroupregistry_fixes","sha":"7d921a4fc76dfd019565f60f65459c80c54514da","user":{"login":"trustin","id":173918,"avatar_url":"https://avatars.githubusercontent.com/u/173918?v=3","gravatar_id":"","url":"https://api.github.com/users/trustin","html_url":"https://github.com/trustin","followers_url":"https://api.github.com/users/trustin/followers","following_url":"https://api.github.com/users/trustin/following{/other_user}","gists_url":"https://api.github.com/users/trustin/gists{/gist_id}","starred_url":"https://api.github.com/users/trustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustin/subscriptions","organizations_url":"https://api.github.com/users/trustin/orgs","repos_url":"https://api.github.com/users/trustin/repos","events_url":"https://api.github.com/users/trustin/events{/privacy}","received_events_url":"https://api.github.com/users/trustin/received_events","type":"User","site_admin":false},"repo":{"id":46322160,"name":"armeria","full_name":"trustin/armeria","owner":{"login":"trustin","id":173918,"avatar_url":"https://avatars.githubusercontent.com/u/173918?v=3","gravatar_id":"","url":"https://api.github.com/users/trustin","html_url":"https://github.com/trustin","followers_url":"https://api.github.com/users/trustin/followers","following_url":"https://api.github.com/users/trustin/following{/other_user}","gists_url":"https://api.github.com/users/trustin/gists{/gist_id}","starred_url":"https://api.github.com/users/trustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustin/subscriptions","organizations_url":"https://api.github.com/users/trustin/orgs","repos_url":"https://api.github.com/users/trustin/repos","events_url":"https://api.github.com/users/trustin/events{/privacy}","received_events_url":"https://api.github.com/users/trustin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trustin/armeria","description":"Asynchronous RPC/API client/server library built on top of Java 8, Netty 4.1, HTTP/2, and Thrift","fork":true,"url":"https://api.github.com/repos/trustin/armeria","forks_url":"https://api.github.com/repos/trustin/armeria/forks","keys_url":"https://api.github.com/repos/trustin/armeria/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trustin/armeria/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trustin/armeria/teams","hooks_url":"https://api.github.com/repos/trustin/armeria/hooks","issue_events_url":"https://api.github.com/repos/trustin/armeria/issues/events{/number}","events_url":"https://api.github.com/repos/trustin/armeria/events","assignees_url":"https://api.github.com/repos/trustin/armeria/assignees{/user}","branches_url":"https://api.github.com/repos/trustin/armeria/branches{/branch}","tags_url":"https://api.github.com/repos/trustin/armeria/tags","blobs_url":"https://api.github.com/repos/trustin/armeria/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trustin/armeria/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trustin/armeria/git/refs{/sha}","trees_url":"https://api.github.com/repos/trustin/armeria/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trustin/armeria/statuses/{sha}","languages_url":"https://api.github.com/repos/trustin/armeria/languages","stargazers_url":"https://api.github.com/repos/trustin/armeria/stargazers","contributors_url":"https://api.github.com/repos/trustin/armeria/contributors","subscribers_url":"https://api.github.com/repos/trustin/armeria/subscribers","subscription_url":"https://api.github.com/repos/trustin/armeria/subscription","commits_url":"https://api.github.com/repos/trustin/armeria/commits{/sha}","git_commits_url":"https://api.github.com/repos/trustin/armeria/git/commits{/sha}","comments_url":"https://api.github.com/repos/trustin/armeria/comments{/number}","issue_comment_url":"https://api.github.com/repos/trustin/armeria/issues/comments{/number}","contents_url":"https://api.github.com/repos/trustin/armeria/contents/{+path}","compare_url":"https://api.github.com/repos/trustin/armeria/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trustin/armeria/merges","archive_url":"https://api.github.com/repos/trustin/armeria/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trustin/armeria/downloads","issues_url":"https://api.github.com/repos/trustin/armeria/issues{/number}","pulls_url":"https://api.github.com/repos/trustin/armeria/pulls{/number}","milestones_url":"https://api.github.com/repos/trustin/armeria/milestones{/number}","notifications_url":"https://api.github.com/repos/trustin/armeria/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trustin/armeria/labels{/name}","releases_url":"https://api.github.com/repos/trustin/armeria/releases{/id}","deployments_url":"https://api.github.com/repos/trustin/armeria/deployments","created_at":"2015-11-17T03:59:08Z","updated_at":"2016-02-26T14:00:08Z","pushed_at":"2016-10-19T08:47:08Z","git_url":"git://github.com/trustin/armeria.git","ssh_url":"git@github.com:trustin/armeria.git","clone_url":"https://github.com/trustin/armeria.git","svn_url":"https://github.com/trustin/armeria","homepage":"http://line.github.io/armeria/","size":11817,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"line:master","ref":"master","sha":"2d422e1a375d42272a8d2e481cba3cd84246abd6","user":{"login":"line","id":13128444,"avatar_url":"https://avatars.githubusercontent.com/u/13128444?v=3","gravatar_id":"","url":"https://api.github.com/users/line","html_url":"https://github.com/line","followers_url":"https://api.github.com/users/line/followers","following_url":"https://api.github.com/users/line/following{/other_user}","gists_url":"https://api.github.com/users/line/gists{/gist_id}","starred_url":"https://api.github.com/users/line/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/line/subscriptions","organizations_url":"https://api.github.com/users/line/orgs","repos_url":"https://api.github.com/users/line/repos","events_url":"https://api.github.com/users/line/events{/privacy}","received_events_url":"https://api.github.com/users/line/received_events","type":"Organization","site_admin":false},"repo":{"id":46251204,"name":"armeria","full_name":"line/armeria","owner":{"login":"line","id":13128444,"avatar_url":"https://avatars.githubusercontent.com/u/13128444?v=3","gravatar_id":"","url":"https://api.github.com/users/line","html_url":"https://github.com/line","followers_url":"https://api.github.com/users/line/followers","following_url":"https://api.github.com/users/line/following{/other_user}","gists_url":"https://api.github.com/users/line/gists{/gist_id}","starred_url":"https://api.github.com/users/line/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/line/subscriptions","organizations_url":"https://api.github.com/users/line/orgs","repos_url":"https://api.github.com/users/line/repos","events_url":"https://api.github.com/users/line/events{/privacy}","received_events_url":"https://api.github.com/users/line/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/line/armeria","description":"Asynchronous RPC/API client/server library built on top of Java 8, Netty 4.1, HTTP/2, and Thrift","fork":false,"url":"https://api.github.com/repos/line/armeria","forks_url":"https://api.github.com/repos/line/armeria/forks","keys_url":"https://api.github.com/repos/line/armeria/keys{/key_id}","collaborators_url":"https://api.github.com/repos/line/armeria/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/line/armeria/teams","hooks_url":"https://api.github.com/repos/line/armeria/hooks","issue_events_url":"https://api.github.com/repos/line/armeria/issues/events{/number}","events_url":"https://api.github.com/repos/line/armeria/events","assignees_url":"https://api.github.com/repos/line/armeria/assignees{/user}","branches_url":"https://api.github.com/repos/line/armeria/branches{/branch}","tags_url":"https://api.github.com/repos/line/armeria/tags","blobs_url":"https://api.github.com/repos/line/armeria/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/line/armeria/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/line/armeria/git/refs{/sha}","trees_url":"https://api.github.com/repos/line/armeria/git/trees{/sha}","statuses_url":"https://api.github.com/repos/line/armeria/statuses/{sha}","languages_url":"https://api.github.com/repos/line/armeria/languages","stargazers_url":"https://api.github.com/repos/line/armeria/stargazers","contributors_url":"https://api.github.com/repos/line/armeria/contributors","subscribers_url":"https://api.github.com/repos/line/armeria/subscribers","subscription_url":"https://api.github.com/repos/line/armeria/subscription","commits_url":"https://api.github.com/repos/line/armeria/commits{/sha}","git_commits_url":"https://api.github.com/repos/line/armeria/git/commits{/sha}","comments_url":"https://api.github.com/repos/line/armeria/comments{/number}","issue_comment_url":"https://api.github.com/repos/line/armeria/issues/comments{/number}","contents_url":"https://api.github.com/repos/line/armeria/contents/{+path}","compare_url":"https://api.github.com/repos/line/armeria/compare/{base}...{head}","merges_url":"https://api.github.com/repos/line/armeria/merges","archive_url":"https://api.github.com/repos/line/armeria/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/line/armeria/downloads","issues_url":"https://api.github.com/repos/line/armeria/issues{/number}","pulls_url":"https://api.github.com/repos/line/armeria/pulls{/number}","milestones_url":"https://api.github.com/repos/line/armeria/milestones{/number}","notifications_url":"https://api.github.com/repos/line/armeria/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/line/armeria/labels{/name}","releases_url":"https://api.github.com/repos/line/armeria/releases{/id}","deployments_url":"https://api.github.com/repos/line/armeria/deployments","created_at":"2015-11-16T04:04:01Z","updated_at":"2016-10-16T08:14:50Z","pushed_at":"2016-10-19T09:03:43Z","git_url":"git://github.com/line/armeria.git","ssh_url":"git@github.com:line/armeria.git","clone_url":"https://github.com/line/armeria.git","svn_url":"https://github.com/line/armeria","homepage":"http://line.github.io/armeria/","size":15130,"stargazers_count":555,"watchers_count":555,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":133,"mirror_url":null,"open_issues_count":39,"forks":133,"open_issues":39,"watchers":555,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/line/armeria/pulls/310"},"html":{"href":"https://github.com/line/armeria/pull/310"},"issue":{"href":"https://api.github.com/repos/line/armeria/issues/310"},"comments":{"href":"https://api.github.com/repos/line/armeria/issues/310/comments"},"review_comments":{"href":"https://api.github.com/repos/line/armeria/pulls/310/comments"},"review_comment":{"href":"https://api.github.com/repos/line/armeria/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/line/armeria/pulls/310/commits"},"statuses":{"href":"https://api.github.com/repos/line/armeria/statuses/7d921a4fc76dfd019565f60f65459c80c54514da"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"imasahiro","id":73532,"avatar_url":"https://avatars.githubusercontent.com/u/73532?v=3","gravatar_id":"","url":"https://api.github.com/users/imasahiro","html_url":"https://github.com/imasahiro","followers_url":"https://api.github.com/users/imasahiro/followers","following_url":"https://api.github.com/users/imasahiro/following{/other_user}","gists_url":"https://api.github.com/users/imasahiro/gists{/gist_id}","starred_url":"https://api.github.com/users/imasahiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imasahiro/subscriptions","organizations_url":"https://api.github.com/users/imasahiro/orgs","repos_url":"https://api.github.com/users/imasahiro/repos","events_url":"https://api.github.com/users/imasahiro/events{/privacy}","received_events_url":"https://api.github.com/users/imasahiro/received_events","type":"User","site_admin":false},"comments":1,"review_comments":3,"commits":1,"additions":81,"deletions":22,"changed_files":4}}
{"actor":{"display_login":"imasahiro"}}