{"action":"created","issue":{"url":"https://api.github.com/repos/apple/swift/issues/1374","repository_url":"https://api.github.com/repos/apple/swift","labels_url":"https://api.github.com/repos/apple/swift/issues/1374/labels{/name}","comments_url":"https://api.github.com/repos/apple/swift/issues/1374/comments","events_url":"https://api.github.com/repos/apple/swift/issues/1374/events","html_url":"https://github.com/apple/swift/pull/1374","id":135040206,"number":1374,"title":"[Python] Argument names should be lowercase by convention","user":{"login":"practicalswift","id":7826565,"avatar_url":"https://avatars.githubusercontent.com/u/7826565?v=3","gravatar_id":"","url":"https://api.github.com/users/practicalswift","html_url":"https://github.com/practicalswift","followers_url":"https://api.github.com/users/practicalswift/followers","following_url":"https://api.github.com/users/practicalswift/following{/other_user}","gists_url":"https://api.github.com/users/practicalswift/gists{/gist_id}","starred_url":"https://api.github.com/users/practicalswift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/practicalswift/subscriptions","organizations_url":"https://api.github.com/users/practicalswift/orgs","repos_url":"https://api.github.com/users/practicalswift/repos","events_url":"https://api.github.com/users/practicalswift/events{/privacy}","received_events_url":"https://api.github.com/users/practicalswift/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-02-20T06:41:32Z","updated_at":"2016-02-21T17:12:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/1374","html_url":"https://github.com/apple/swift/pull/1374","diff_url":"https://github.com/apple/swift/pull/1374.diff","patch_url":"https://github.com/apple/swift/pull/1374.patch"},"body":"Fix 16 \"argument name should be lowercase\" violations.\r\n\r\nAs discussed with @modocache and @nadavrot in #1369.\r\n\r\nSignature changes: \r\n\r\n```\r\n-def addFunction(sizes, function, startAddr, endAddr, groupByPrefix):\r\n+def addFunction(sizes, function, start_addr, end_addr, group_by_prefix):\r\n-def readSizes(sizes, fileName, functionDetails, groupByPrefix):\r\n+def readSizes(sizes, file_name, function_details, group_by_prefix):\r\n-def compareSizes(oldSizes, newSizes, nameKey, title):\r\n+def compareSizes(old_sizes, new_sizes, name_key, title):\r\n-def compareSizesOfFile(oldFiles, newFiles, allSections, listCategories):\r\n+def compareSizesOfFile(old_files, new_files, all_sections, list_categories):\r\n-def listFunctionSizes(sizeArray):\r\n+def listFunctionSizes(size_array):\r\n-def compareFunctionSizes(oldFiles, newFiles):\r\n+def compareFunctionSizes(old_files, new_files):\r\n-def tokenPosToIndex(tokenPos, start, lineStarts):\r\n+def tokenPosToIndex(token_pos, start, line_starts):\r\n-def tokenizePythonToUnmatchedCloseCurly(sourceText, start, lineStarts):\r\n+def tokenizePythonToUnmatchedCloseCurly(source_text, start, line_starts):\r\n-def tokenizeTemplate(templateText):\r\n+def tokenizeTemplate(template_text):\r\n-def splitGybLines(sourceLines):\r\n+def splitGybLines(source_lines):\r\n-def codeStartsWithDedentKeyword(sourceLines):\r\n+def codeStartsWithDedentKeyword(source_lines):\r\n-    def tokenGenerator(self, baseTokens):\r\n+    def tokenGenerator(self, base_tokens):\r\n-    def __init__(self, lineDirective='// ###line', **localBindings):\r\n+    def __init__(self, line_directive='// ###line', **local_bindings):\r\n-def executeTemplate(ast, lineDirective='', **localBindings):\r\n+def executeTemplate(ast, line_directive='', **local_bindings):\r\n-def bodyLines(bodyText):\r\n+def bodyLines(body_text):\r\n-  def __init__(self, name, source, processedSource, binary):\r\n+  def __init__(self, name, source, processed_source, binary):\r\n```"},"comment":{"url":"https://api.github.com/repos/apple/swift/issues/comments/186861769","html_url":"https://github.com/apple/swift/pull/1374#issuecomment-186861769","issue_url":"https://api.github.com/repos/apple/swift/issues/1374","id":186861769,"user":{"login":"dabrahams","id":44065,"avatar_url":"https://avatars.githubusercontent.com/u/44065?v=3","gravatar_id":"","url":"https://api.github.com/users/dabrahams","html_url":"https://github.com/dabrahams","followers_url":"https://api.github.com/users/dabrahams/followers","following_url":"https://api.github.com/users/dabrahams/following{/other_user}","gists_url":"https://api.github.com/users/dabrahams/gists{/gist_id}","starred_url":"https://api.github.com/users/dabrahams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dabrahams/subscriptions","organizations_url":"https://api.github.com/users/dabrahams/orgs","repos_url":"https://api.github.com/users/dabrahams/repos","events_url":"https://api.github.com/users/dabrahams/events{/privacy}","received_events_url":"https://api.github.com/users/dabrahams/received_events","type":"User","site_admin":false},"created_at":"2016-02-21T17:12:50Z","updated_at":"2016-02-21T17:12:50Z","body":"Does it really make sense to use a different case convention for every language in the repo?  Seems like we'd be better off following Swift convention in the absence of compelling reasons to do otherwise. "}}