{"action":"closed","number":9014,"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/9014","id":57782588,"html_url":"https://github.com/xbmc/xbmc/pull/9014","diff_url":"https://github.com/xbmc/xbmc/pull/9014.diff","patch_url":"https://github.com/xbmc/xbmc/pull/9014.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/9014","number":9014,"state":"closed","locked":false,"title":"Replace year with a full date in movies and musicvideos","user":{"login":"phate89","id":1254959,"avatar_url":"https://avatars.githubusercontent.com/u/1254959?v=3","gravatar_id":"","url":"https://api.github.com/users/phate89","html_url":"https://github.com/phate89","followers_url":"https://api.github.com/users/phate89/followers","following_url":"https://api.github.com/users/phate89/following{/other_user}","gists_url":"https://api.github.com/users/phate89/gists{/gist_id}","starred_url":"https://api.github.com/users/phate89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phate89/subscriptions","organizations_url":"https://api.github.com/users/phate89/orgs","repos_url":"https://api.github.com/users/phate89/repos","events_url":"https://api.github.com/users/phate89/events{/privacy}","received_events_url":"https://api.github.com/users/phate89/received_events","type":"User","site_admin":false},"body":"This allows to store the full date of a movie and a musicvideo.\r\nI left the \"year\" label because it's the same for tv show. \r\nSince there's no way to rescan all the dates with the scrapers (or at least I think so) I set the current dates to the 1st January of the existing year.\r\n\r\nedit:\r\nactualy thinking about it I'm not sure if it's the right way to go. \r\nThere are 2 ways:\r\n\r\nthis implementation. One field in the database and extract the year from it. This should be a no brainer but the problem is that we don't have the full date and the only way to update current movies is to rescrape the library. skins have no way to distinguish if the date is good or is a dummy year-01-01\r\nAdd a second field with the full date. In this way skins could show the full date only if it's a true full date. The problem is that we will have to keep 2 fields with the same info and keep 2 different variables in check in CVideoInfoTag for a long time.\r\nChange between this 2 version is easy.. What do you think it's best?","created_at":"2016-01-31T22:29:33Z","updated_at":"2016-06-04T10:18:05Z","closed_at":"2016-06-04T10:18:04Z","merged_at":"2016-06-04T10:18:04Z","merge_commit_sha":"cfdff88cf34c459c3a739b20e54ec5f9237dd1a9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/9014/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/9014/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/9014/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/a261526efccfb0494bca43d7dfa1d98fa8dea345","head":{"label":"phate89:add_release_date","ref":"add_release_date","sha":"a261526efccfb0494bca43d7dfa1d98fa8dea345","user":{"login":"phate89","id":1254959,"avatar_url":"https://avatars.githubusercontent.com/u/1254959?v=3","gravatar_id":"","url":"https://api.github.com/users/phate89","html_url":"https://github.com/phate89","followers_url":"https://api.github.com/users/phate89/followers","following_url":"https://api.github.com/users/phate89/following{/other_user}","gists_url":"https://api.github.com/users/phate89/gists{/gist_id}","starred_url":"https://api.github.com/users/phate89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phate89/subscriptions","organizations_url":"https://api.github.com/users/phate89/orgs","repos_url":"https://api.github.com/users/phate89/repos","events_url":"https://api.github.com/users/phate89/events{/privacy}","received_events_url":"https://api.github.com/users/phate89/received_events","type":"User","site_admin":false},"repo":{"id":25815543,"name":"xbmc","full_name":"phate89/xbmc","owner":{"login":"phate89","id":1254959,"avatar_url":"https://avatars.githubusercontent.com/u/1254959?v=3","gravatar_id":"","url":"https://api.github.com/users/phate89","html_url":"https://github.com/phate89","followers_url":"https://api.github.com/users/phate89/followers","following_url":"https://api.github.com/users/phate89/following{/other_user}","gists_url":"https://api.github.com/users/phate89/gists{/gist_id}","starred_url":"https://api.github.com/users/phate89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phate89/subscriptions","organizations_url":"https://api.github.com/users/phate89/orgs","repos_url":"https://api.github.com/users/phate89/repos","events_url":"https://api.github.com/users/phate89/events{/privacy}","received_events_url":"https://api.github.com/users/phate89/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/phate89/xbmc","description":"XBMC Main Repository","fork":true,"url":"https://api.github.com/repos/phate89/xbmc","forks_url":"https://api.github.com/repos/phate89/xbmc/forks","keys_url":"https://api.github.com/repos/phate89/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phate89/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phate89/xbmc/teams","hooks_url":"https://api.github.com/repos/phate89/xbmc/hooks","issue_events_url":"https://api.github.com/repos/phate89/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/phate89/xbmc/events","assignees_url":"https://api.github.com/repos/phate89/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/phate89/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/phate89/xbmc/tags","blobs_url":"https://api.github.com/repos/phate89/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phate89/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phate89/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/phate89/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phate89/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/phate89/xbmc/languages","stargazers_url":"https://api.github.com/repos/phate89/xbmc/stargazers","contributors_url":"https://api.github.com/repos/phate89/xbmc/contributors","subscribers_url":"https://api.github.com/repos/phate89/xbmc/subscribers","subscription_url":"https://api.github.com/repos/phate89/xbmc/subscription","commits_url":"https://api.github.com/repos/phate89/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/phate89/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/phate89/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/phate89/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/phate89/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/phate89/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phate89/xbmc/merges","archive_url":"https://api.github.com/repos/phate89/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phate89/xbmc/downloads","issues_url":"https://api.github.com/repos/phate89/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/phate89/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/phate89/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/phate89/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phate89/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/phate89/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/phate89/xbmc/deployments","created_at":"2014-10-27T11:20:57Z","updated_at":"2016-01-15T19:10:17Z","pushed_at":"2016-06-04T09:27:08Z","git_url":"git://github.com/phate89/xbmc.git","ssh_url":"git@github.com:phate89/xbmc.git","clone_url":"https://github.com/phate89/xbmc.git","svn_url":"https://github.com/phate89/xbmc","homepage":"http://xbmc.org","size":533225,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"d46a7068a79a265ac8606049266b240f209c4fcb","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/xbmc/xbmc/deployments","created_at":"2011-01-03T21:18:51Z","updated_at":"2016-06-03T18:34:24Z","pushed_at":"2016-06-04T10:18:05Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1743494,"stargazers_count":4822,"watchers_count":4822,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3536,"mirror_url":null,"open_issues_count":185,"forks":3536,"open_issues":185,"watchers":4822,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/9014"},"html":{"href":"https://github.com/xbmc/xbmc/pull/9014"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/9014"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/9014/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/9014/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/9014/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/a261526efccfb0494bca43d7dfa1d98fa8dea345"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"phate89","id":1254959,"avatar_url":"https://avatars.githubusercontent.com/u/1254959?v=3","gravatar_id":"","url":"https://api.github.com/users/phate89","html_url":"https://github.com/phate89","followers_url":"https://api.github.com/users/phate89/followers","following_url":"https://api.github.com/users/phate89/following{/other_user}","gists_url":"https://api.github.com/users/phate89/gists{/gist_id}","starred_url":"https://api.github.com/users/phate89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phate89/subscriptions","organizations_url":"https://api.github.com/users/phate89/orgs","repos_url":"https://api.github.com/users/phate89/repos","events_url":"https://api.github.com/users/phate89/events{/privacy}","received_events_url":"https://api.github.com/users/phate89/received_events","type":"User","site_admin":false},"comments":27,"review_comments":10,"commits":2,"additions":246,"deletions":165,"changed_files":21}}
{"actor":{"display_login":"phate89"}}