{"action":"created","comment":{"url":"https://api.github.com/repos/sequelize/sequelize/pulls/comments/77959338","id":77959338,"diff_hunk":"@@ -285,14 +285,15 @@ describe(Support.getTestDialectTeaser('DataTypes'), function() {\n \n     return new Sequelize.Promise((resolve, reject) => {\n       if (/^postgres/.test(dialect)) {\n-        current.query(`SELECT extversion FROM pg_catalog.pg_extension WHERE extname='postgis';`)\n-            .then((result) => {\n-              if (result[0][0] && semver.lte(result[0][0].extversion, '2.1.7')) {\n-                resolve(true);\n-              } else {\n-                resolve();\n-              }\n-            }).catch(reject);\n+        current.query(`SELECT PostGIS_full_version();`)\n+          .then((result) => {\n+            const version = result[0][0].postgis_full_version.match(/^POSTGIS=\"(\\d*.\\d*.\\d*)/)[1];","path":"test/integration/data-types.test.js","position":14,"original_position":14,"commit_id":"c4729bdebccf90c628c7a495e1253908dc80fe51","original_commit_id":"c4729bdebccf90c628c7a495e1253908dc80fe51","user":{"login":"sushantdhiman","id":9989487,"avatar_url":"https://avatars.githubusercontent.com/u/9989487?v=3","gravatar_id":"","url":"https://api.github.com/users/sushantdhiman","html_url":"https://github.com/sushantdhiman","followers_url":"https://api.github.com/users/sushantdhiman/followers","following_url":"https://api.github.com/users/sushantdhiman/following{/other_user}","gists_url":"https://api.github.com/users/sushantdhiman/gists{/gist_id}","starred_url":"https://api.github.com/users/sushantdhiman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sushantdhiman/subscriptions","organizations_url":"https://api.github.com/users/sushantdhiman/orgs","repos_url":"https://api.github.com/users/sushantdhiman/repos","events_url":"https://api.github.com/users/sushantdhiman/events{/privacy}","received_events_url":"https://api.github.com/users/sushantdhiman/received_events","type":"User","site_admin":false},"body":"that didn't worked on my local setup. But current one is same thing as it reads direct tables which `PostGIS_lib_version` would have accessed :)","created_at":"2016-09-08T07:44:36Z","updated_at":"2016-09-08T07:44:36Z","html_url":"https://github.com/sequelize/sequelize/pull/6443#discussion_r77959338","pull_request_url":"https://api.github.com/repos/sequelize/sequelize/pulls/6443","_links":{"self":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/comments/77959338"},"html":{"href":"https://github.com/sequelize/sequelize/pull/6443#discussion_r77959338"},"pull_request":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/6443"}}},"pull_request":{"url":"https://api.github.com/repos/sequelize/sequelize/pulls/6443","id":81398602,"html_url":"https://github.com/sequelize/sequelize/pull/6443","diff_url":"https://github.com/sequelize/sequelize/pull/6443.diff","patch_url":"https://github.com/sequelize/sequelize/pull/6443.patch","issue_url":"https://api.github.com/repos/sequelize/sequelize/issues/6443","number":6443,"state":"open","locked":false,"title":"Update Travis-CI to use Docker","user":{"login":"toddbluhm","id":197282,"avatar_url":"https://avatars.githubusercontent.com/u/197282?v=3","gravatar_id":"","url":"https://api.github.com/users/toddbluhm","html_url":"https://github.com/toddbluhm","followers_url":"https://api.github.com/users/toddbluhm/followers","following_url":"https://api.github.com/users/toddbluhm/following{/other_user}","gists_url":"https://api.github.com/users/toddbluhm/gists{/gist_id}","starred_url":"https://api.github.com/users/toddbluhm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toddbluhm/subscriptions","organizations_url":"https://api.github.com/users/toddbluhm/orgs","repos_url":"https://api.github.com/users/toddbluhm/repos","events_url":"https://api.github.com/users/toddbluhm/events{/privacy}","received_events_url":"https://api.github.com/users/toddbluhm/received_events","type":"User","site_admin":false},"body":"Attempt to move travis-ci over to using docker to help with #4727 \r\n\r\nMy goal for this PR was to keep the same matrix style in travis-ci that already existed, leverage the existing docker/docker-compose and just get it working on travis-ci.\r\n\r\n### Pull Request check-list\r\n\r\n_Please make sure to review and check all of these items:_\r\n\r\n- [x] Does `npm run test` or `npm run test-DIALECT` pass with this change (including linting)?**Currently not all the tests pass due to: #6345 and #6279 (same error: Too few ordinates in GeoJSON)**\r\n- [x] Does your issue contain a link to existing issue (Closes #[issue]) or a description of the issue you are solving? **#4727**\r\n- [x] Have you added new tests to prevent regressions?\r\n**I tweaked the incorrect password integration test case because the error was different from what was expected (but consistent across all dialects). My guess is it has to do with running in the docker environment. I left the original code commented out until I know this is the way we want to go.**\r\n- [x] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)? **Updated contributor readme file with new docker instructions**\r\n- [x] Have you added an entry under `Future` in the changelog?\r\n**I added an entry for it**\r\n\r\n### Description of change\r\n\r\n- Tweaked travis.yml to use docker for running the dbs\r\n- Removed existing docker file as it was no longer needed\r\n- Updated docker compose to the new v2 style\r\n- Updated postgres docker container to a postgis container to support the new postgis queries\r\n- Removed the ./node_modules/.bin/... from package.json scripts because they are not needed when run from npm (it by default looks in that folder)\r\n- Updated package.json docker test scripts to include new env's for the docker db host/port settings\r\n\r\n","created_at":"2016-08-16T00:36:35Z","updated_at":"2016-09-08T07:44:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0f880a2848f53e8bd1af3f31030126fe50d7431","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sequelize/sequelize/pulls/6443/commits","review_comments_url":"https://api.github.com/repos/sequelize/sequelize/pulls/6443/comments","review_comment_url":"https://api.github.com/repos/sequelize/sequelize/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sequelize/sequelize/issues/6443/comments","statuses_url":"https://api.github.com/repos/sequelize/sequelize/statuses/c4729bdebccf90c628c7a495e1253908dc80fe51","head":{"label":"toddbluhm:travis-ci-docker","ref":"travis-ci-docker","sha":"c4729bdebccf90c628c7a495e1253908dc80fe51","user":{"login":"toddbluhm","id":197282,"avatar_url":"https://avatars.githubusercontent.com/u/197282?v=3","gravatar_id":"","url":"https://api.github.com/users/toddbluhm","html_url":"https://github.com/toddbluhm","followers_url":"https://api.github.com/users/toddbluhm/followers","following_url":"https://api.github.com/users/toddbluhm/following{/other_user}","gists_url":"https://api.github.com/users/toddbluhm/gists{/gist_id}","starred_url":"https://api.github.com/users/toddbluhm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toddbluhm/subscriptions","organizations_url":"https://api.github.com/users/toddbluhm/orgs","repos_url":"https://api.github.com/users/toddbluhm/repos","events_url":"https://api.github.com/users/toddbluhm/events{/privacy}","received_events_url":"https://api.github.com/users/toddbluhm/received_events","type":"User","site_admin":false},"repo":{"id":65695924,"name":"sequelize","full_name":"toddbluhm/sequelize","owner":{"login":"toddbluhm","id":197282,"avatar_url":"https://avatars.githubusercontent.com/u/197282?v=3","gravatar_id":"","url":"https://api.github.com/users/toddbluhm","html_url":"https://github.com/toddbluhm","followers_url":"https://api.github.com/users/toddbluhm/followers","following_url":"https://api.github.com/users/toddbluhm/following{/other_user}","gists_url":"https://api.github.com/users/toddbluhm/gists{/gist_id}","starred_url":"https://api.github.com/users/toddbluhm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toddbluhm/subscriptions","organizations_url":"https://api.github.com/users/toddbluhm/orgs","repos_url":"https://api.github.com/users/toddbluhm/repos","events_url":"https://api.github.com/users/toddbluhm/events{/privacy}","received_events_url":"https://api.github.com/users/toddbluhm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/toddbluhm/sequelize","description":"Sequelize is an easy-to-use multi sql dialect ORM for Node.js & io.js. It currently supports MySQL, MariaDB, SQLite, PostgreSQL and MSSQL.","fork":true,"url":"https://api.github.com/repos/toddbluhm/sequelize","forks_url":"https://api.github.com/repos/toddbluhm/sequelize/forks","keys_url":"https://api.github.com/repos/toddbluhm/sequelize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toddbluhm/sequelize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toddbluhm/sequelize/teams","hooks_url":"https://api.github.com/repos/toddbluhm/sequelize/hooks","issue_events_url":"https://api.github.com/repos/toddbluhm/sequelize/issues/events{/number}","events_url":"https://api.github.com/repos/toddbluhm/sequelize/events","assignees_url":"https://api.github.com/repos/toddbluhm/sequelize/assignees{/user}","branches_url":"https://api.github.com/repos/toddbluhm/sequelize/branches{/branch}","tags_url":"https://api.github.com/repos/toddbluhm/sequelize/tags","blobs_url":"https://api.github.com/repos/toddbluhm/sequelize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toddbluhm/sequelize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toddbluhm/sequelize/git/refs{/sha}","trees_url":"https://api.github.com/repos/toddbluhm/sequelize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toddbluhm/sequelize/statuses/{sha}","languages_url":"https://api.github.com/repos/toddbluhm/sequelize/languages","stargazers_url":"https://api.github.com/repos/toddbluhm/sequelize/stargazers","contributors_url":"https://api.github.com/repos/toddbluhm/sequelize/contributors","subscribers_url":"https://api.github.com/repos/toddbluhm/sequelize/subscribers","subscription_url":"https://api.github.com/repos/toddbluhm/sequelize/subscription","commits_url":"https://api.github.com/repos/toddbluhm/sequelize/commits{/sha}","git_commits_url":"https://api.github.com/repos/toddbluhm/sequelize/git/commits{/sha}","comments_url":"https://api.github.com/repos/toddbluhm/sequelize/comments{/number}","issue_comment_url":"https://api.github.com/repos/toddbluhm/sequelize/issues/comments{/number}","contents_url":"https://api.github.com/repos/toddbluhm/sequelize/contents/{+path}","compare_url":"https://api.github.com/repos/toddbluhm/sequelize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toddbluhm/sequelize/merges","archive_url":"https://api.github.com/repos/toddbluhm/sequelize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toddbluhm/sequelize/downloads","issues_url":"https://api.github.com/repos/toddbluhm/sequelize/issues{/number}","pulls_url":"https://api.github.com/repos/toddbluhm/sequelize/pulls{/number}","milestones_url":"https://api.github.com/repos/toddbluhm/sequelize/milestones{/number}","notifications_url":"https://api.github.com/repos/toddbluhm/sequelize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toddbluhm/sequelize/labels{/name}","releases_url":"https://api.github.com/repos/toddbluhm/sequelize/releases{/id}","deployments_url":"https://api.github.com/repos/toddbluhm/sequelize/deployments","created_at":"2016-08-15T01:45:12Z","updated_at":"2016-08-15T01:45:19Z","pushed_at":"2016-09-08T00:46:10Z","git_url":"git://github.com/toddbluhm/sequelize.git","ssh_url":"git@github.com:toddbluhm/sequelize.git","clone_url":"https://github.com/toddbluhm/sequelize.git","svn_url":"https://github.com/toddbluhm/sequelize","homepage":"http://sequelizejs.com","size":18634,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sequelize:master","ref":"master","sha":"6d90b5ba66a4ae44cd5fb81cf0a7288115ca4482","user":{"login":"sequelize","id":3591786,"avatar_url":"https://avatars.githubusercontent.com/u/3591786?v=3","gravatar_id":"","url":"https://api.github.com/users/sequelize","html_url":"https://github.com/sequelize","followers_url":"https://api.github.com/users/sequelize/followers","following_url":"https://api.github.com/users/sequelize/following{/other_user}","gists_url":"https://api.github.com/users/sequelize/gists{/gist_id}","starred_url":"https://api.github.com/users/sequelize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sequelize/subscriptions","organizations_url":"https://api.github.com/users/sequelize/orgs","repos_url":"https://api.github.com/users/sequelize/repos","events_url":"https://api.github.com/users/sequelize/events{/privacy}","received_events_url":"https://api.github.com/users/sequelize/received_events","type":"Organization","site_admin":false},"repo":{"id":790359,"name":"sequelize","full_name":"sequelize/sequelize","owner":{"login":"sequelize","id":3591786,"avatar_url":"https://avatars.githubusercontent.com/u/3591786?v=3","gravatar_id":"","url":"https://api.github.com/users/sequelize","html_url":"https://github.com/sequelize","followers_url":"https://api.github.com/users/sequelize/followers","following_url":"https://api.github.com/users/sequelize/following{/other_user}","gists_url":"https://api.github.com/users/sequelize/gists{/gist_id}","starred_url":"https://api.github.com/users/sequelize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sequelize/subscriptions","organizations_url":"https://api.github.com/users/sequelize/orgs","repos_url":"https://api.github.com/users/sequelize/repos","events_url":"https://api.github.com/users/sequelize/events{/privacy}","received_events_url":"https://api.github.com/users/sequelize/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sequelize/sequelize","description":"An easy-to-use multi SQL dialect ORM for Node.js","fork":false,"url":"https://api.github.com/repos/sequelize/sequelize","forks_url":"https://api.github.com/repos/sequelize/sequelize/forks","keys_url":"https://api.github.com/repos/sequelize/sequelize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sequelize/sequelize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sequelize/sequelize/teams","hooks_url":"https://api.github.com/repos/sequelize/sequelize/hooks","issue_events_url":"https://api.github.com/repos/sequelize/sequelize/issues/events{/number}","events_url":"https://api.github.com/repos/sequelize/sequelize/events","assignees_url":"https://api.github.com/repos/sequelize/sequelize/assignees{/user}","branches_url":"https://api.github.com/repos/sequelize/sequelize/branches{/branch}","tags_url":"https://api.github.com/repos/sequelize/sequelize/tags","blobs_url":"https://api.github.com/repos/sequelize/sequelize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sequelize/sequelize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sequelize/sequelize/git/refs{/sha}","trees_url":"https://api.github.com/repos/sequelize/sequelize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sequelize/sequelize/statuses/{sha}","languages_url":"https://api.github.com/repos/sequelize/sequelize/languages","stargazers_url":"https://api.github.com/repos/sequelize/sequelize/stargazers","contributors_url":"https://api.github.com/repos/sequelize/sequelize/contributors","subscribers_url":"https://api.github.com/repos/sequelize/sequelize/subscribers","subscription_url":"https://api.github.com/repos/sequelize/sequelize/subscription","commits_url":"https://api.github.com/repos/sequelize/sequelize/commits{/sha}","git_commits_url":"https://api.github.com/repos/sequelize/sequelize/git/commits{/sha}","comments_url":"https://api.github.com/repos/sequelize/sequelize/comments{/number}","issue_comment_url":"https://api.github.com/repos/sequelize/sequelize/issues/comments{/number}","contents_url":"https://api.github.com/repos/sequelize/sequelize/contents/{+path}","compare_url":"https://api.github.com/repos/sequelize/sequelize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sequelize/sequelize/merges","archive_url":"https://api.github.com/repos/sequelize/sequelize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sequelize/sequelize/downloads","issues_url":"https://api.github.com/repos/sequelize/sequelize/issues{/number}","pulls_url":"https://api.github.com/repos/sequelize/sequelize/pulls{/number}","milestones_url":"https://api.github.com/repos/sequelize/sequelize/milestones{/number}","notifications_url":"https://api.github.com/repos/sequelize/sequelize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sequelize/sequelize/labels{/name}","releases_url":"https://api.github.com/repos/sequelize/sequelize/releases{/id}","deployments_url":"https://api.github.com/repos/sequelize/sequelize/deployments","created_at":"2010-07-22T07:11:11Z","updated_at":"2016-09-08T02:32:25Z","pushed_at":"2016-09-08T07:07:45Z","git_url":"git://github.com/sequelize/sequelize.git","ssh_url":"git@github.com:sequelize/sequelize.git","clone_url":"https://github.com/sequelize/sequelize.git","svn_url":"https://github.com/sequelize/sequelize","homepage":"http://sequelizejs.com","size":55934,"stargazers_count":7469,"watchers_count":7469,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1530,"mirror_url":null,"open_issues_count":702,"forks":1530,"open_issues":702,"watchers":7469,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/6443"},"html":{"href":"https://github.com/sequelize/sequelize/pull/6443"},"issue":{"href":"https://api.github.com/repos/sequelize/sequelize/issues/6443"},"comments":{"href":"https://api.github.com/repos/sequelize/sequelize/issues/6443/comments"},"review_comments":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/6443/comments"},"review_comment":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/6443/commits"},"statuses":{"href":"https://api.github.com/repos/sequelize/sequelize/statuses/c4729bdebccf90c628c7a495e1253908dc80fe51"}}}}
{"actor":{"display_login":"sushantdhiman"}}