{"action":"opened","number":3900,"pull_request":{"url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/3900","id":54946047,"html_url":"https://github.com/D-Programming-Language/phobos/pull/3900","diff_url":"https://github.com/D-Programming-Language/phobos/pull/3900.diff","patch_url":"https://github.com/D-Programming-Language/phobos/pull/3900.patch","issue_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/3900","number":3900,"state":"open","locked":false,"title":"Issue 15276: Allow users to specify shell for executeShell, pipeShell, spawnShell","user":{"login":"markisaa","id":2280568,"avatar_url":"https://avatars.githubusercontent.com/u/2280568?v=3","gravatar_id":"","url":"https://api.github.com/users/markisaa","html_url":"https://github.com/markisaa","followers_url":"https://api.github.com/users/markisaa/followers","following_url":"https://api.github.com/users/markisaa/following{/other_user}","gists_url":"https://api.github.com/users/markisaa/gists{/gist_id}","starred_url":"https://api.github.com/users/markisaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markisaa/subscriptions","organizations_url":"https://api.github.com/users/markisaa/orgs","repos_url":"https://api.github.com/users/markisaa/repos","events_url":"https://api.github.com/users/markisaa/events{/privacy}","received_events_url":"https://api.github.com/users/markisaa/received_events","type":"User","site_admin":false},"body":"This diff: This diff makes it possible to specify your preferred shell for the various `*shell` functions in `std.process`. By default it uses the new `nativeShell` function. `nativeShell` to always returns the native system shell (see the \"some history\" section for why this is the default value). I chose to create `nativeShell` rather than changeing `userShell` because I think it is still valuable to have something like `userShell` around in Phobos.\r\n\r\nThe one part of this diff I'm not super thrilled by is the use of variadic arguments (easier to see than to explain); if you have a suggestion for something better I'd love to hear it :).\r\n\r\nNote: The default shell is a breaking change for Windows, which probably *should have* been broken same as posix in the diffs listed in the history section below, but I suspect was overlooked. Find rationale behind making a breaking change at all here: https://issues.dlang.org/show_bug.cgi?id=15000.\r\n\r\nSome history:\r\nhttps://github.com/D-Programming-Language/phobos/commit/a524a3571b18e440c4dd751fcf4e2d00b834fb22\r\nand\r\nhttps://github.com/D-Programming-Language/phobos/commit/f537cb50b5f8f9ad6d841db14b2e0a6cb845d008\r\n\r\nTried to move us from a world where we preferred the shell specified in the SHELL environment variable to a world where we always went with the native system shell, /bin/sh for posix. The former of those revisions was reverted in:\r\nhttps://github.com/D-Programming-Language/phobos/commit/5b2b1fb59450cfc32ecec3252f543a9f6f34c2a4\r\nBecause the documentation was not updated to reflect the change.\r\n\r\nPresently: we are in a state of schism, whereby `userShell` has behavior that does not align with what is actually used in `executeShell`, `pipeShell`, and `spawnShell`. This is something we *must* resolve.\r\n\r\nPersonal pain: This bit me when one of my scripts at work stopped working because it dependend on features that don't exist in `sh` (but do in `bash`, `zsh`, etc). It was really frustrating that there was no simple way to work around this and specify my preferred shell; it is, of course, possible to leverage the various `escape*` functions from `std.process` and `spawnProcess` to use whichever shell I prefer, but this seems like something warranting first class support. I was sad to not have something like this after a breaking change.","created_at":"2016-01-04T06:13:01Z","updated_at":"2016-01-04T06:13:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/3900/commits","review_comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/3900/comments","review_comment_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/3900/comments","statuses_url":"https://api.github.com/repos/D-Programming-Language/phobos/statuses/e5b74a726663ec06d417fac7a5724c3463afc46c","head":{"label":"markisaa:issue_15276","ref":"issue_15276","sha":"e5b74a726663ec06d417fac7a5724c3463afc46c","user":{"login":"markisaa","id":2280568,"avatar_url":"https://avatars.githubusercontent.com/u/2280568?v=3","gravatar_id":"","url":"https://api.github.com/users/markisaa","html_url":"https://github.com/markisaa","followers_url":"https://api.github.com/users/markisaa/followers","following_url":"https://api.github.com/users/markisaa/following{/other_user}","gists_url":"https://api.github.com/users/markisaa/gists{/gist_id}","starred_url":"https://api.github.com/users/markisaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markisaa/subscriptions","organizations_url":"https://api.github.com/users/markisaa/orgs","repos_url":"https://api.github.com/users/markisaa/repos","events_url":"https://api.github.com/users/markisaa/events{/privacy}","received_events_url":"https://api.github.com/users/markisaa/received_events","type":"User","site_admin":false},"repo":{"id":19586686,"name":"phobos","full_name":"markisaa/phobos","owner":{"login":"markisaa","id":2280568,"avatar_url":"https://avatars.githubusercontent.com/u/2280568?v=3","gravatar_id":"","url":"https://api.github.com/users/markisaa","html_url":"https://github.com/markisaa","followers_url":"https://api.github.com/users/markisaa/followers","following_url":"https://api.github.com/users/markisaa/following{/other_user}","gists_url":"https://api.github.com/users/markisaa/gists{/gist_id}","starred_url":"https://api.github.com/users/markisaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markisaa/subscriptions","organizations_url":"https://api.github.com/users/markisaa/orgs","repos_url":"https://api.github.com/users/markisaa/repos","events_url":"https://api.github.com/users/markisaa/events{/privacy}","received_events_url":"https://api.github.com/users/markisaa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/markisaa/phobos","description":"The standard library of the D programming language","fork":true,"url":"https://api.github.com/repos/markisaa/phobos","forks_url":"https://api.github.com/repos/markisaa/phobos/forks","keys_url":"https://api.github.com/repos/markisaa/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/markisaa/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/markisaa/phobos/teams","hooks_url":"https://api.github.com/repos/markisaa/phobos/hooks","issue_events_url":"https://api.github.com/repos/markisaa/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/markisaa/phobos/events","assignees_url":"https://api.github.com/repos/markisaa/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/markisaa/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/markisaa/phobos/tags","blobs_url":"https://api.github.com/repos/markisaa/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/markisaa/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/markisaa/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/markisaa/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/markisaa/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/markisaa/phobos/languages","stargazers_url":"https://api.github.com/repos/markisaa/phobos/stargazers","contributors_url":"https://api.github.com/repos/markisaa/phobos/contributors","subscribers_url":"https://api.github.com/repos/markisaa/phobos/subscribers","subscription_url":"https://api.github.com/repos/markisaa/phobos/subscription","commits_url":"https://api.github.com/repos/markisaa/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/markisaa/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/markisaa/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/markisaa/phobos/issues/comments{/number}","contents_url":"https://api.github.com/repos/markisaa/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/markisaa/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/markisaa/phobos/merges","archive_url":"https://api.github.com/repos/markisaa/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/markisaa/phobos/downloads","issues_url":"https://api.github.com/repos/markisaa/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/markisaa/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/markisaa/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/markisaa/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/markisaa/phobos/labels{/name}","releases_url":"https://api.github.com/repos/markisaa/phobos/releases{/id}","created_at":"2014-05-08T19:49:28Z","updated_at":"2014-09-28T23:42:00Z","pushed_at":"2016-01-04T06:08:37Z","git_url":"git://github.com/markisaa/phobos.git","ssh_url":"git@github.com:markisaa/phobos.git","clone_url":"https://github.com/markisaa/phobos.git","svn_url":"https://github.com/markisaa/phobos","homepage":"dlang.org/phobos","size":47938,"stargazers_count":0,"watchers_count":0,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"D-Programming-Language:master","ref":"master","sha":"1f249eaf13b449471754a4a91c812d2159a31c0b","user":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"repo":{"id":1257084,"name":"phobos","full_name":"D-Programming-Language/phobos","owner":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/D-Programming-Language/phobos","description":"The standard library of the D programming language","fork":false,"url":"https://api.github.com/repos/D-Programming-Language/phobos","forks_url":"https://api.github.com/repos/D-Programming-Language/phobos/forks","keys_url":"https://api.github.com/repos/D-Programming-Language/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/D-Programming-Language/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/D-Programming-Language/phobos/teams","hooks_url":"https://api.github.com/repos/D-Programming-Language/phobos/hooks","issue_events_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/D-Programming-Language/phobos/events","assignees_url":"https://api.github.com/repos/D-Programming-Language/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/D-Programming-Language/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/D-Programming-Language/phobos/tags","blobs_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/D-Programming-Language/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/D-Programming-Language/phobos/languages","stargazers_url":"https://api.github.com/repos/D-Programming-Language/phobos/stargazers","contributors_url":"https://api.github.com/repos/D-Programming-Language/phobos/contributors","subscribers_url":"https://api.github.com/repos/D-Programming-Language/phobos/subscribers","subscription_url":"https://api.github.com/repos/D-Programming-Language/phobos/subscription","commits_url":"https://api.github.com/repos/D-Programming-Language/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/comments{/number}","contents_url":"https://api.github.com/repos/D-Programming-Language/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/D-Programming-Language/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/D-Programming-Language/phobos/merges","archive_url":"https://api.github.com/repos/D-Programming-Language/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/D-Programming-Language/phobos/downloads","issues_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/D-Programming-Language/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/D-Programming-Language/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/D-Programming-Language/phobos/labels{/name}","releases_url":"https://api.github.com/repos/D-Programming-Language/phobos/releases{/id}","created_at":"2011-01-15T07:00:06Z","updated_at":"2016-01-03T02:17:42Z","pushed_at":"2016-01-04T05:09:09Z","git_url":"git://github.com/D-Programming-Language/phobos.git","ssh_url":"git@github.com:D-Programming-Language/phobos.git","clone_url":"https://github.com/D-Programming-Language/phobos.git","svn_url":"https://github.com/D-Programming-Language/phobos","homepage":"dlang.org/phobos","size":68405,"stargazers_count":660,"watchers_count":660,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":438,"mirror_url":null,"open_issues_count":79,"forks":438,"open_issues":79,"watchers":660,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/3900"},"html":{"href":"https://github.com/D-Programming-Language/phobos/pull/3900"},"issue":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/issues/3900"},"comments":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/issues/3900/comments"},"review_comments":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/3900/comments"},"review_comment":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/3900/commits"},"statuses":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/statuses/e5b74a726663ec06d417fac7a5724c3463afc46c"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":73,"deletions":39,"changed_files":1}}