{"action":"closed","number":462,"pull_request":{"url":"https://api.github.com/repos/tlswg/tls13-spec/pulls/462","id":70750261,"html_url":"https://github.com/tlswg/tls13-spec/pull/462","diff_url":"https://github.com/tlswg/tls13-spec/pull/462.diff","patch_url":"https://github.com/tlswg/tls13-spec/pull/462.patch","issue_url":"https://api.github.com/repos/tlswg/tls13-spec/issues/462","number":462,"state":"closed","locked":false,"title":"Preserve leading zeros in Diffie-Hellman secrets.","user":{"login":"davidben","id":109690,"avatar_url":"https://avatars.githubusercontent.com/u/109690?v=3","gravatar_id":"","url":"https://api.github.com/users/davidben","html_url":"https://github.com/davidben","followers_url":"https://api.github.com/users/davidben/followers","following_url":"https://api.github.com/users/davidben/following{/other_user}","gists_url":"https://api.github.com/users/davidben/gists{/gist_id}","starred_url":"https://api.github.com/users/davidben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidben/subscriptions","organizations_url":"https://api.github.com/users/davidben/orgs","repos_url":"https://api.github.com/users/davidben/repos","events_url":"https://api.github.com/users/davidben/events{/privacy}","received_events_url":"https://api.github.com/users/davidben/received_events","type":"User","site_admin":false},"body":"Every other use of Diffie-Hellman preserves leading zeros. See PKCS #3 section\r\n8.3, RFC 2631 section 2.1.2, and SP 800-56A section C.1. I assume X9.42 says\r\nsomething similar to RFC 2631, but I do not have a copy of it. This discrepancy\r\nhas caused sporadic interoperability issues in TLS 1.2's DHE construction, so\r\nclearly it's confusing.\r\n\r\nMoreover, having variable-length secrets is generally dubious. It exposes an\r\nunnecessary side channel.\r\n\r\nSince TLS 1.2's server-fiat DHE and TLS 1.3's negotiated DHE are already very\r\ndifferent animals (1.3 DHE is more like 1.2 ECDHE than anything else), change\r\nit to the more reasonable scheme going forward. This is not compatible with 1.2\r\nand does risk a different set of sporadic interop issues if implementations do\r\nnot realize this changed, but we already have those with 1.2 implementations\r\ntoday.","created_at":"2016-05-19T19:22:05Z","updated_at":"2016-05-20T17:44:06Z","closed_at":"2016-05-20T17:44:06Z","merged_at":"2016-05-20T17:44:06Z","merge_commit_sha":"2e7c11cf9824d4726587a6d6f18fd6bb2a958cc5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tlswg/tls13-spec/pulls/462/commits","review_comments_url":"https://api.github.com/repos/tlswg/tls13-spec/pulls/462/comments","review_comment_url":"https://api.github.com/repos/tlswg/tls13-spec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tlswg/tls13-spec/issues/462/comments","statuses_url":"https://api.github.com/repos/tlswg/tls13-spec/statuses/6af2cd01e8b3109651dcde667aa030b26f459321","head":{"label":"davidben:dhe-pad2","ref":"dhe-pad2","sha":"6af2cd01e8b3109651dcde667aa030b26f459321","user":{"login":"davidben","id":109690,"avatar_url":"https://avatars.githubusercontent.com/u/109690?v=3","gravatar_id":"","url":"https://api.github.com/users/davidben","html_url":"https://github.com/davidben","followers_url":"https://api.github.com/users/davidben/followers","following_url":"https://api.github.com/users/davidben/following{/other_user}","gists_url":"https://api.github.com/users/davidben/gists{/gist_id}","starred_url":"https://api.github.com/users/davidben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidben/subscriptions","organizations_url":"https://api.github.com/users/davidben/orgs","repos_url":"https://api.github.com/users/davidben/repos","events_url":"https://api.github.com/users/davidben/events{/privacy}","received_events_url":"https://api.github.com/users/davidben/received_events","type":"User","site_admin":false},"repo":{"id":50207621,"name":"tls13-spec","full_name":"davidben/tls13-spec","owner":{"login":"davidben","id":109690,"avatar_url":"https://avatars.githubusercontent.com/u/109690?v=3","gravatar_id":"","url":"https://api.github.com/users/davidben","html_url":"https://github.com/davidben","followers_url":"https://api.github.com/users/davidben/followers","following_url":"https://api.github.com/users/davidben/following{/other_user}","gists_url":"https://api.github.com/users/davidben/gists{/gist_id}","starred_url":"https://api.github.com/users/davidben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidben/subscriptions","organizations_url":"https://api.github.com/users/davidben/orgs","repos_url":"https://api.github.com/users/davidben/repos","events_url":"https://api.github.com/users/davidben/events{/privacy}","received_events_url":"https://api.github.com/users/davidben/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidben/tls13-spec","description":"TLS 1.3 Specification","fork":true,"url":"https://api.github.com/repos/davidben/tls13-spec","forks_url":"https://api.github.com/repos/davidben/tls13-spec/forks","keys_url":"https://api.github.com/repos/davidben/tls13-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidben/tls13-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidben/tls13-spec/teams","hooks_url":"https://api.github.com/repos/davidben/tls13-spec/hooks","issue_events_url":"https://api.github.com/repos/davidben/tls13-spec/issues/events{/number}","events_url":"https://api.github.com/repos/davidben/tls13-spec/events","assignees_url":"https://api.github.com/repos/davidben/tls13-spec/assignees{/user}","branches_url":"https://api.github.com/repos/davidben/tls13-spec/branches{/branch}","tags_url":"https://api.github.com/repos/davidben/tls13-spec/tags","blobs_url":"https://api.github.com/repos/davidben/tls13-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidben/tls13-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidben/tls13-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidben/tls13-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidben/tls13-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/davidben/tls13-spec/languages","stargazers_url":"https://api.github.com/repos/davidben/tls13-spec/stargazers","contributors_url":"https://api.github.com/repos/davidben/tls13-spec/contributors","subscribers_url":"https://api.github.com/repos/davidben/tls13-spec/subscribers","subscription_url":"https://api.github.com/repos/davidben/tls13-spec/subscription","commits_url":"https://api.github.com/repos/davidben/tls13-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidben/tls13-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidben/tls13-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidben/tls13-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidben/tls13-spec/contents/{+path}","compare_url":"https://api.github.com/repos/davidben/tls13-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidben/tls13-spec/merges","archive_url":"https://api.github.com/repos/davidben/tls13-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidben/tls13-spec/downloads","issues_url":"https://api.github.com/repos/davidben/tls13-spec/issues{/number}","pulls_url":"https://api.github.com/repos/davidben/tls13-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/davidben/tls13-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/davidben/tls13-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidben/tls13-spec/labels{/name}","releases_url":"https://api.github.com/repos/davidben/tls13-spec/releases{/id}","deployments_url":"https://api.github.com/repos/davidben/tls13-spec/deployments","created_at":"2016-01-22T21:07:51Z","updated_at":"2016-01-22T21:07:52Z","pushed_at":"2016-05-19T20:06:19Z","git_url":"git://github.com/davidben/tls13-spec.git","ssh_url":"git@github.com:davidben/tls13-spec.git","clone_url":"https://github.com/davidben/tls13-spec.git","svn_url":"https://github.com/davidben/tls13-spec","homepage":null,"size":2083,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tlswg:master","ref":"master","sha":"3dabad540a5702b4167c891f01532e808df9fb57","user":{"login":"tlswg","id":6699659,"avatar_url":"https://avatars.githubusercontent.com/u/6699659?v=3","gravatar_id":"","url":"https://api.github.com/users/tlswg","html_url":"https://github.com/tlswg","followers_url":"https://api.github.com/users/tlswg/followers","following_url":"https://api.github.com/users/tlswg/following{/other_user}","gists_url":"https://api.github.com/users/tlswg/gists{/gist_id}","starred_url":"https://api.github.com/users/tlswg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlswg/subscriptions","organizations_url":"https://api.github.com/users/tlswg/orgs","repos_url":"https://api.github.com/users/tlswg/repos","events_url":"https://api.github.com/users/tlswg/events{/privacy}","received_events_url":"https://api.github.com/users/tlswg/received_events","type":"Organization","site_admin":false},"repo":{"id":18887842,"name":"tls13-spec","full_name":"tlswg/tls13-spec","owner":{"login":"tlswg","id":6699659,"avatar_url":"https://avatars.githubusercontent.com/u/6699659?v=3","gravatar_id":"","url":"https://api.github.com/users/tlswg","html_url":"https://github.com/tlswg","followers_url":"https://api.github.com/users/tlswg/followers","following_url":"https://api.github.com/users/tlswg/following{/other_user}","gists_url":"https://api.github.com/users/tlswg/gists{/gist_id}","starred_url":"https://api.github.com/users/tlswg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlswg/subscriptions","organizations_url":"https://api.github.com/users/tlswg/orgs","repos_url":"https://api.github.com/users/tlswg/repos","events_url":"https://api.github.com/users/tlswg/events{/privacy}","received_events_url":"https://api.github.com/users/tlswg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tlswg/tls13-spec","description":"TLS 1.3 Specification","fork":false,"url":"https://api.github.com/repos/tlswg/tls13-spec","forks_url":"https://api.github.com/repos/tlswg/tls13-spec/forks","keys_url":"https://api.github.com/repos/tlswg/tls13-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tlswg/tls13-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tlswg/tls13-spec/teams","hooks_url":"https://api.github.com/repos/tlswg/tls13-spec/hooks","issue_events_url":"https://api.github.com/repos/tlswg/tls13-spec/issues/events{/number}","events_url":"https://api.github.com/repos/tlswg/tls13-spec/events","assignees_url":"https://api.github.com/repos/tlswg/tls13-spec/assignees{/user}","branches_url":"https://api.github.com/repos/tlswg/tls13-spec/branches{/branch}","tags_url":"https://api.github.com/repos/tlswg/tls13-spec/tags","blobs_url":"https://api.github.com/repos/tlswg/tls13-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tlswg/tls13-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tlswg/tls13-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/tlswg/tls13-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tlswg/tls13-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/tlswg/tls13-spec/languages","stargazers_url":"https://api.github.com/repos/tlswg/tls13-spec/stargazers","contributors_url":"https://api.github.com/repos/tlswg/tls13-spec/contributors","subscribers_url":"https://api.github.com/repos/tlswg/tls13-spec/subscribers","subscription_url":"https://api.github.com/repos/tlswg/tls13-spec/subscription","commits_url":"https://api.github.com/repos/tlswg/tls13-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/tlswg/tls13-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/tlswg/tls13-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/tlswg/tls13-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/tlswg/tls13-spec/contents/{+path}","compare_url":"https://api.github.com/repos/tlswg/tls13-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tlswg/tls13-spec/merges","archive_url":"https://api.github.com/repos/tlswg/tls13-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tlswg/tls13-spec/downloads","issues_url":"https://api.github.com/repos/tlswg/tls13-spec/issues{/number}","pulls_url":"https://api.github.com/repos/tlswg/tls13-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/tlswg/tls13-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/tlswg/tls13-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tlswg/tls13-spec/labels{/name}","releases_url":"https://api.github.com/repos/tlswg/tls13-spec/releases{/id}","deployments_url":"https://api.github.com/repos/tlswg/tls13-spec/deployments","created_at":"2014-04-17T17:52:32Z","updated_at":"2016-05-20T15:46:58Z","pushed_at":"2016-05-20T17:44:06Z","git_url":"git://github.com/tlswg/tls13-spec.git","ssh_url":"git@github.com:tlswg/tls13-spec.git","clone_url":"https://github.com/tlswg/tls13-spec.git","svn_url":"https://github.com/tlswg/tls13-spec","homepage":null,"size":3192,"stargazers_count":146,"watchers_count":146,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":63,"mirror_url":null,"open_issues_count":31,"forks":63,"open_issues":31,"watchers":146,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tlswg/tls13-spec/pulls/462"},"html":{"href":"https://github.com/tlswg/tls13-spec/pull/462"},"issue":{"href":"https://api.github.com/repos/tlswg/tls13-spec/issues/462"},"comments":{"href":"https://api.github.com/repos/tlswg/tls13-spec/issues/462/comments"},"review_comments":{"href":"https://api.github.com/repos/tlswg/tls13-spec/pulls/462/comments"},"review_comment":{"href":"https://api.github.com/repos/tlswg/tls13-spec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tlswg/tls13-spec/pulls/462/commits"},"statuses":{"href":"https://api.github.com/repos/tlswg/tls13-spec/statuses/6af2cd01e8b3109651dcde667aa030b26f459321"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ekr","id":1111457,"avatar_url":"https://avatars.githubusercontent.com/u/1111457?v=3","gravatar_id":"","url":"https://api.github.com/users/ekr","html_url":"https://github.com/ekr","followers_url":"https://api.github.com/users/ekr/followers","following_url":"https://api.github.com/users/ekr/following{/other_user}","gists_url":"https://api.github.com/users/ekr/gists{/gist_id}","starred_url":"https://api.github.com/users/ekr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekr/subscriptions","organizations_url":"https://api.github.com/users/ekr/orgs","repos_url":"https://api.github.com/users/ekr/repos","events_url":"https://api.github.com/users/ekr/events{/privacy}","received_events_url":"https://api.github.com/users/ekr/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":8,"deletions":5,"changed_files":1}}
{"actor":{"display_login":"ekr"}}