{"action":"created","comment":{"url":"https://api.github.com/repos/nodes-android/nstack/pulls/comments/92432986","pull_request_review_id":12947883,"id":92432986,"diff_hunk":"@@ -46,22 +42,29 @@\n \n     private VersionControlCallbacks versionControlListener;\n     private AppOpen appOpen;\n-    private AppOpenSettings settings = new AppOpenSettings();\n-    //private TranslationOptions translationOptions = new TranslationOptions();\n+    private AppOpenSettings settings;\n \n-    public AppOpenManager(  ) {\n+    private Context context;\n+    private CacheManager cacheManager;\n+    private TranslationManager translationManager;\n+\n+    public AppOpenManager(Context context, TranslationManager translationManager) {\n+        this.context = context;\n+        this.translationManager = translationManager;\n+        cacheManager = new CacheManager(context);","path":"app/src/main/java/dk/nodes/nstack/util/appopen/AppOpenManager.java","position":37,"original_position":37,"commit_id":"510306613090a54ac7f80df1076749f269c95071","original_commit_id":"510306613090a54ac7f80df1076749f269c95071","user":{"login":"jcmsalves","id":9438692,"avatar_url":"https://avatars.githubusercontent.com/u/9438692?v=3","gravatar_id":"","url":"https://api.github.com/users/jcmsalves","html_url":"https://github.com/jcmsalves","followers_url":"https://api.github.com/users/jcmsalves/followers","following_url":"https://api.github.com/users/jcmsalves/following{/other_user}","gists_url":"https://api.github.com/users/jcmsalves/gists{/gist_id}","starred_url":"https://api.github.com/users/jcmsalves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcmsalves/subscriptions","organizations_url":"https://api.github.com/users/jcmsalves/orgs","repos_url":"https://api.github.com/users/jcmsalves/repos","events_url":"https://api.github.com/users/jcmsalves/events{/privacy}","received_events_url":"https://api.github.com/users/jcmsalves/received_events","type":"User","site_admin":false},"body":"done","created_at":"2016-12-14T16:34:20Z","updated_at":"2016-12-14T16:34:20Z","html_url":"https://github.com/nodes-android/nstack/pull/15#discussion_r92432986","pull_request_url":"https://api.github.com/repos/nodes-android/nstack/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/nodes-android/nstack/pulls/comments/92432986"},"html":{"href":"https://github.com/nodes-android/nstack/pull/15#discussion_r92432986"},"pull_request":{"href":"https://api.github.com/repos/nodes-android/nstack/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/nodes-android/nstack/pulls/15","id":97753745,"html_url":"https://github.com/nodes-android/nstack/pull/15","diff_url":"https://github.com/nodes-android/nstack/pull/15.diff","patch_url":"https://github.com/nodes-android/nstack/pull/15.patch","issue_url":"https://api.github.com/repos/nodes-android/nstack/issues/15","number":15,"state":"open","locked":false,"title":"NStack refactor","user":{"login":"jcmsalves","id":9438692,"avatar_url":"https://avatars.githubusercontent.com/u/9438692?v=3","gravatar_id":"","url":"https://api.github.com/users/jcmsalves","html_url":"https://github.com/jcmsalves","followers_url":"https://api.github.com/users/jcmsalves/followers","following_url":"https://api.github.com/users/jcmsalves/following{/other_user}","gists_url":"https://api.github.com/users/jcmsalves/gists{/gist_id}","starred_url":"https://api.github.com/users/jcmsalves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcmsalves/subscriptions","organizations_url":"https://api.github.com/users/jcmsalves/orgs","repos_url":"https://api.github.com/users/jcmsalves/repos","events_url":"https://api.github.com/users/jcmsalves/events{/privacy}","received_events_url":"https://api.github.com/users/jcmsalves/received_events","type":"User","site_admin":false},"body":"- TranslationOptions moved out of translation manager\r\n- Remove singletons -> access through NStack\r\n- Make resource files private\r\n- save()/load() in app open settings -> cachemanager\r\n- Move all PrefsManager code to CacheManager","created_at":"2016-12-13T13:46:39Z","updated_at":"2016-12-14T16:34:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ee993033ceda91afd653386d16c66b2f19a7d8e","assignee":{"login":"johsoe","id":1464994,"avatar_url":"https://avatars.githubusercontent.com/u/1464994?v=3","gravatar_id":"","url":"https://api.github.com/users/johsoe","html_url":"https://github.com/johsoe","followers_url":"https://api.github.com/users/johsoe/followers","following_url":"https://api.github.com/users/johsoe/following{/other_user}","gists_url":"https://api.github.com/users/johsoe/gists{/gist_id}","starred_url":"https://api.github.com/users/johsoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johsoe/subscriptions","organizations_url":"https://api.github.com/users/johsoe/orgs","repos_url":"https://api.github.com/users/johsoe/repos","events_url":"https://api.github.com/users/johsoe/events{/privacy}","received_events_url":"https://api.github.com/users/johsoe/received_events","type":"User","site_admin":false},"assignees":[{"login":"johsoe","id":1464994,"avatar_url":"https://avatars.githubusercontent.com/u/1464994?v=3","gravatar_id":"","url":"https://api.github.com/users/johsoe","html_url":"https://github.com/johsoe","followers_url":"https://api.github.com/users/johsoe/followers","following_url":"https://api.github.com/users/johsoe/following{/other_user}","gists_url":"https://api.github.com/users/johsoe/gists{/gist_id}","starred_url":"https://api.github.com/users/johsoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johsoe/subscriptions","organizations_url":"https://api.github.com/users/johsoe/orgs","repos_url":"https://api.github.com/users/johsoe/repos","events_url":"https://api.github.com/users/johsoe/events{/privacy}","received_events_url":"https://api.github.com/users/johsoe/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodes-android/nstack/pulls/15/commits","review_comments_url":"https://api.github.com/repos/nodes-android/nstack/pulls/15/comments","review_comment_url":"https://api.github.com/repos/nodes-android/nstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodes-android/nstack/issues/15/comments","statuses_url":"https://api.github.com/repos/nodes-android/nstack/statuses/510306613090a54ac7f80df1076749f269c95071","head":{"label":"nodes-android:feature/refactor","ref":"feature/refactor","sha":"510306613090a54ac7f80df1076749f269c95071","user":{"login":"nodes-android","id":15651607,"avatar_url":"https://avatars.githubusercontent.com/u/15651607?v=3","gravatar_id":"","url":"https://api.github.com/users/nodes-android","html_url":"https://github.com/nodes-android","followers_url":"https://api.github.com/users/nodes-android/followers","following_url":"https://api.github.com/users/nodes-android/following{/other_user}","gists_url":"https://api.github.com/users/nodes-android/gists{/gist_id}","starred_url":"https://api.github.com/users/nodes-android/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodes-android/subscriptions","organizations_url":"https://api.github.com/users/nodes-android/orgs","repos_url":"https://api.github.com/users/nodes-android/repos","events_url":"https://api.github.com/users/nodes-android/events{/privacy}","received_events_url":"https://api.github.com/users/nodes-android/received_events","type":"Organization","site_admin":false},"repo":{"id":58360471,"name":"nstack","full_name":"nodes-android/nstack","owner":{"login":"nodes-android","id":15651607,"avatar_url":"https://avatars.githubusercontent.com/u/15651607?v=3","gravatar_id":"","url":"https://api.github.com/users/nodes-android","html_url":"https://github.com/nodes-android","followers_url":"https://api.github.com/users/nodes-android/followers","following_url":"https://api.github.com/users/nodes-android/following{/other_user}","gists_url":"https://api.github.com/users/nodes-android/gists{/gist_id}","starred_url":"https://api.github.com/users/nodes-android/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodes-android/subscriptions","organizations_url":"https://api.github.com/users/nodes-android/orgs","repos_url":"https://api.github.com/users/nodes-android/repos","events_url":"https://api.github.com/users/nodes-android/events{/privacy}","received_events_url":"https://api.github.com/users/nodes-android/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodes-android/nstack","description":null,"fork":false,"url":"https://api.github.com/repos/nodes-android/nstack","forks_url":"https://api.github.com/repos/nodes-android/nstack/forks","keys_url":"https://api.github.com/repos/nodes-android/nstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodes-android/nstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodes-android/nstack/teams","hooks_url":"https://api.github.com/repos/nodes-android/nstack/hooks","issue_events_url":"https://api.github.com/repos/nodes-android/nstack/issues/events{/number}","events_url":"https://api.github.com/repos/nodes-android/nstack/events","assignees_url":"https://api.github.com/repos/nodes-android/nstack/assignees{/user}","branches_url":"https://api.github.com/repos/nodes-android/nstack/branches{/branch}","tags_url":"https://api.github.com/repos/nodes-android/nstack/tags","blobs_url":"https://api.github.com/repos/nodes-android/nstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodes-android/nstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodes-android/nstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodes-android/nstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodes-android/nstack/statuses/{sha}","languages_url":"https://api.github.com/repos/nodes-android/nstack/languages","stargazers_url":"https://api.github.com/repos/nodes-android/nstack/stargazers","contributors_url":"https://api.github.com/repos/nodes-android/nstack/contributors","subscribers_url":"https://api.github.com/repos/nodes-android/nstack/subscribers","subscription_url":"https://api.github.com/repos/nodes-android/nstack/subscription","commits_url":"https://api.github.com/repos/nodes-android/nstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodes-android/nstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodes-android/nstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodes-android/nstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodes-android/nstack/contents/{+path}","compare_url":"https://api.github.com/repos/nodes-android/nstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodes-android/nstack/merges","archive_url":"https://api.github.com/repos/nodes-android/nstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodes-android/nstack/downloads","issues_url":"https://api.github.com/repos/nodes-android/nstack/issues{/number}","pulls_url":"https://api.github.com/repos/nodes-android/nstack/pulls{/number}","milestones_url":"https://api.github.com/repos/nodes-android/nstack/milestones{/number}","notifications_url":"https://api.github.com/repos/nodes-android/nstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodes-android/nstack/labels{/name}","releases_url":"https://api.github.com/repos/nodes-android/nstack/releases{/id}","deployments_url":"https://api.github.com/repos/nodes-android/nstack/deployments","created_at":"2016-05-09T08:22:20Z","updated_at":"2016-11-14T16:14:31Z","pushed_at":"2016-12-13T13:46:39Z","git_url":"git://github.com/nodes-android/nstack.git","ssh_url":"git@github.com:nodes-android/nstack.git","clone_url":"https://github.com/nodes-android/nstack.git","svn_url":"https://github.com/nodes-android/nstack","homepage":null,"size":1416,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"nodes-android:master","ref":"master","sha":"e54e7b56e629c1dc9e54549c9eda9e0a6fea6ad7","user":{"login":"nodes-android","id":15651607,"avatar_url":"https://avatars.githubusercontent.com/u/15651607?v=3","gravatar_id":"","url":"https://api.github.com/users/nodes-android","html_url":"https://github.com/nodes-android","followers_url":"https://api.github.com/users/nodes-android/followers","following_url":"https://api.github.com/users/nodes-android/following{/other_user}","gists_url":"https://api.github.com/users/nodes-android/gists{/gist_id}","starred_url":"https://api.github.com/users/nodes-android/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodes-android/subscriptions","organizations_url":"https://api.github.com/users/nodes-android/orgs","repos_url":"https://api.github.com/users/nodes-android/repos","events_url":"https://api.github.com/users/nodes-android/events{/privacy}","received_events_url":"https://api.github.com/users/nodes-android/received_events","type":"Organization","site_admin":false},"repo":{"id":58360471,"name":"nstack","full_name":"nodes-android/nstack","owner":{"login":"nodes-android","id":15651607,"avatar_url":"https://avatars.githubusercontent.com/u/15651607?v=3","gravatar_id":"","url":"https://api.github.com/users/nodes-android","html_url":"https://github.com/nodes-android","followers_url":"https://api.github.com/users/nodes-android/followers","following_url":"https://api.github.com/users/nodes-android/following{/other_user}","gists_url":"https://api.github.com/users/nodes-android/gists{/gist_id}","starred_url":"https://api.github.com/users/nodes-android/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodes-android/subscriptions","organizations_url":"https://api.github.com/users/nodes-android/orgs","repos_url":"https://api.github.com/users/nodes-android/repos","events_url":"https://api.github.com/users/nodes-android/events{/privacy}","received_events_url":"https://api.github.com/users/nodes-android/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodes-android/nstack","description":null,"fork":false,"url":"https://api.github.com/repos/nodes-android/nstack","forks_url":"https://api.github.com/repos/nodes-android/nstack/forks","keys_url":"https://api.github.com/repos/nodes-android/nstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodes-android/nstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodes-android/nstack/teams","hooks_url":"https://api.github.com/repos/nodes-android/nstack/hooks","issue_events_url":"https://api.github.com/repos/nodes-android/nstack/issues/events{/number}","events_url":"https://api.github.com/repos/nodes-android/nstack/events","assignees_url":"https://api.github.com/repos/nodes-android/nstack/assignees{/user}","branches_url":"https://api.github.com/repos/nodes-android/nstack/branches{/branch}","tags_url":"https://api.github.com/repos/nodes-android/nstack/tags","blobs_url":"https://api.github.com/repos/nodes-android/nstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodes-android/nstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodes-android/nstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodes-android/nstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodes-android/nstack/statuses/{sha}","languages_url":"https://api.github.com/repos/nodes-android/nstack/languages","stargazers_url":"https://api.github.com/repos/nodes-android/nstack/stargazers","contributors_url":"https://api.github.com/repos/nodes-android/nstack/contributors","subscribers_url":"https://api.github.com/repos/nodes-android/nstack/subscribers","subscription_url":"https://api.github.com/repos/nodes-android/nstack/subscription","commits_url":"https://api.github.com/repos/nodes-android/nstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodes-android/nstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodes-android/nstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodes-android/nstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodes-android/nstack/contents/{+path}","compare_url":"https://api.github.com/repos/nodes-android/nstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodes-android/nstack/merges","archive_url":"https://api.github.com/repos/nodes-android/nstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodes-android/nstack/downloads","issues_url":"https://api.github.com/repos/nodes-android/nstack/issues{/number}","pulls_url":"https://api.github.com/repos/nodes-android/nstack/pulls{/number}","milestones_url":"https://api.github.com/repos/nodes-android/nstack/milestones{/number}","notifications_url":"https://api.github.com/repos/nodes-android/nstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodes-android/nstack/labels{/name}","releases_url":"https://api.github.com/repos/nodes-android/nstack/releases{/id}","deployments_url":"https://api.github.com/repos/nodes-android/nstack/deployments","created_at":"2016-05-09T08:22:20Z","updated_at":"2016-11-14T16:14:31Z","pushed_at":"2016-12-13T13:46:39Z","git_url":"git://github.com/nodes-android/nstack.git","ssh_url":"git@github.com:nodes-android/nstack.git","clone_url":"https://github.com/nodes-android/nstack.git","svn_url":"https://github.com/nodes-android/nstack","homepage":null,"size":1416,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodes-android/nstack/pulls/15"},"html":{"href":"https://github.com/nodes-android/nstack/pull/15"},"issue":{"href":"https://api.github.com/repos/nodes-android/nstack/issues/15"},"comments":{"href":"https://api.github.com/repos/nodes-android/nstack/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/nodes-android/nstack/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/nodes-android/nstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodes-android/nstack/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/nodes-android/nstack/statuses/510306613090a54ac7f80df1076749f269c95071"}}}}
{"actor":{"display_login":"jcmsalves"}}