{"action":"opened","issue":{"url":"https://api.github.com/repos/HSAFoundation/HSA-Debugger-Source-AMD/issues/2","labels_url":"https://api.github.com/repos/HSAFoundation/HSA-Debugger-Source-AMD/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/HSAFoundation/HSA-Debugger-Source-AMD/issues/2/comments","events_url":"https://api.github.com/repos/HSAFoundation/HSA-Debugger-Source-AMD/issues/2/events","html_url":"https://github.com/HSAFoundation/HSA-Debugger-Source-AMD/issues/2","id":129487795,"number":2,"title":"Completion of error handling","user":{"login":"elfring","id":660477,"avatar_url":"https://avatars.githubusercontent.com/u/660477?v=3","gravatar_id":"","url":"https://api.github.com/users/elfring","html_url":"https://github.com/elfring","followers_url":"https://api.github.com/users/elfring/followers","following_url":"https://api.github.com/users/elfring/following{/other_user}","gists_url":"https://api.github.com/users/elfring/gists{/gist_id}","starred_url":"https://api.github.com/users/elfring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elfring/subscriptions","organizations_url":"https://api.github.com/users/elfring/orgs","repos_url":"https://api.github.com/users/elfring/repos","events_url":"https://api.github.com/users/elfring/events{/privacy}","received_events_url":"https://api.github.com/users/elfring/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-01-28T15:43:42Z","updated_at":"2016-01-28T15:43:42Z","closed_at":null,"body":"I have looked at a few source files for your current software. I have noticed that some checks for return codes are missing.\r\n\r\nWould you like to add more error handling for return values from functions like the following?\r\n- [fclose](http://en.cppreference.com/w/cpp/io/c/fclose \"Close a file stream.\") ⇒ [AgentBinary::WriteBinaryToFile](https://github.com/HSAFoundation/HSA-Debugger-Source-AMD/blob/9d71dfca811f59c2a64f5c9f48fc98f2a0b7f3c0/src/HSADebugAgent/AgentBinary.cpp#L615)\r\n- [signal](http://pubs.opengroup.org/onlinepubs/9699919799/functions/signal.html \"Signal management\") ⇒ [InitHsaAgent](https://github.com/HSAFoundation/HSA-Debugger-Source-AMD/blob/9d71dfca811f59c2a64f5c9f48fc98f2a0b7f3c0/src/HSADebugAgent/HSADebugAgent.cpp#L143)"}}