{"action":"created","comment":{"url":"https://api.github.com/repos/etorreborre/specs2/pulls/comments/77953544","id":77953544,"diff_hunk":"@@ -0,0 +1,76 @@\n+package org.specs2.matcher\n+\n+import org.specs2.execute._\n+import org.specs2.matcher.describe.{DefaultDifferenceInspector, DifferenceInspectable, DifferenceInspector}\n+import org.specs2.text.NotNullStrings._\n+\n+import scala.collection.{GenTraversable, GenTraversableOnce}\n+\n+\n+class BeTypedEqualTo2[T : DifferenceInspectable](t: =>T, equality: (T, T) => Boolean = (t1:T, t2:T) => t1 == t2) extends AdaptableMatcher[T] {","path":"matcher/src/main/scala/org/specs2/matcher/BeTypedEqualTo2.scala","position":10,"original_position":10,"commit_id":"b945dedda2e7ec073e2febc1b3efa46084092037","original_commit_id":"b945dedda2e7ec073e2febc1b3efa46084092037","user":{"login":"etorreborre","id":10988,"avatar_url":"https://avatars.githubusercontent.com/u/10988?v=3","gravatar_id":"","url":"https://api.github.com/users/etorreborre","html_url":"https://github.com/etorreborre","followers_url":"https://api.github.com/users/etorreborre/followers","following_url":"https://api.github.com/users/etorreborre/following{/other_user}","gists_url":"https://api.github.com/users/etorreborre/gists{/gist_id}","starred_url":"https://api.github.com/users/etorreborre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etorreborre/subscriptions","organizations_url":"https://api.github.com/users/etorreborre/orgs","repos_url":"https://api.github.com/users/etorreborre/repos","events_url":"https://api.github.com/users/etorreborre/events{/privacy}","received_events_url":"https://api.github.com/users/etorreborre/received_events","type":"User","site_admin":false},"body":"Why did you create a `BeTypedEqualTo2` class instead of modifying `BeTypedEqualTo`? I'm pretty sure there is code out there using that class directly so we should better leave it and just replace it with your code for `BeTypedEqualTo2`.","created_at":"2016-09-08T06:49:41Z","updated_at":"2016-09-08T06:49:41Z","html_url":"https://github.com/etorreborre/specs2/pull/500#discussion_r77953544","pull_request_url":"https://api.github.com/repos/etorreborre/specs2/pulls/500","_links":{"self":{"href":"https://api.github.com/repos/etorreborre/specs2/pulls/comments/77953544"},"html":{"href":"https://github.com/etorreborre/specs2/pull/500#discussion_r77953544"},"pull_request":{"href":"https://api.github.com/repos/etorreborre/specs2/pulls/500"}}},"pull_request":{"url":"https://api.github.com/repos/etorreborre/specs2/pulls/500","id":81841993,"html_url":"https://github.com/etorreborre/specs2/pull/500","diff_url":"https://github.com/etorreborre/specs2/pull/500.diff","patch_url":"https://github.com/etorreborre/specs2/pull/500.patch","issue_url":"https://api.github.com/repos/etorreborre/specs2/issues/500","number":500,"state":"open","locked":false,"title":"[WIP] BeEqualTo should support deeper compare","user":{"login":"noam-almog","id":4091923,"avatar_url":"https://avatars.githubusercontent.com/u/4091923?v=3","gravatar_id":"","url":"https://api.github.com/users/noam-almog","html_url":"https://github.com/noam-almog","followers_url":"https://api.github.com/users/noam-almog/followers","following_url":"https://api.github.com/users/noam-almog/following{/other_user}","gists_url":"https://api.github.com/users/noam-almog/gists{/gist_id}","starred_url":"https://api.github.com/users/noam-almog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noam-almog/subscriptions","organizations_url":"https://api.github.com/users/noam-almog/orgs","repos_url":"https://api.github.com/users/noam-almog/repos","events_url":"https://api.github.com/users/noam-almog/events{/privacy}","received_events_url":"https://api.github.com/users/noam-almog/received_events","type":"User","site_admin":false},"body":"Hi Eric,\r\n\r\nDecided to let you in on the current progress and get some feedback.\r\nThis is an implementation of issue #341 \r\n\r\nError messages are:\r\nPrimitives: 1 != 2  and 'a' != 'b'\r\n\r\nScala Collections:\r\n   Sets: Set('a', 'b', added: 'c', 'd', removed: 'e')\r\n   Seq: Seq('a', 'b' != 'c', added: 'd', 'e', removed: 'f')\r\n   Map: Map('a' -> 'b', 'c' -> {'d' != 'x'}, added: 'g' -> 'h', removed: 'e' -> 'f')\r\n\r\nScala:\r\n   Option: Some('abc' != 'def'), None ==> Some(...)\r\n   Either: Right('abc' != 'def'), Right(...) ==> Left(...)\r\n\r\nCase Class:\r\n   Some case class: ClassName(prop: 'val1' != 'val2', prop2: 'val')\r\n\r\nRight now the code is not attached to the BeEqualTo matcher because it's using BeEqualTo on the tests that tests the code.","created_at":"2016-08-18T15:59:48Z","updated_at":"2016-09-08T06:49:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e643fcf68845211bdce5f8a500edf0e9840a492","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/etorreborre/specs2/pulls/500/commits","review_comments_url":"https://api.github.com/repos/etorreborre/specs2/pulls/500/comments","review_comment_url":"https://api.github.com/repos/etorreborre/specs2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/etorreborre/specs2/issues/500/comments","statuses_url":"https://api.github.com/repos/etorreborre/specs2/statuses/b945dedda2e7ec073e2febc1b3efa46084092037","head":{"label":"noam-almog:equal-to-enhancements","ref":"equal-to-enhancements","sha":"b945dedda2e7ec073e2febc1b3efa46084092037","user":{"login":"noam-almog","id":4091923,"avatar_url":"https://avatars.githubusercontent.com/u/4091923?v=3","gravatar_id":"","url":"https://api.github.com/users/noam-almog","html_url":"https://github.com/noam-almog","followers_url":"https://api.github.com/users/noam-almog/followers","following_url":"https://api.github.com/users/noam-almog/following{/other_user}","gists_url":"https://api.github.com/users/noam-almog/gists{/gist_id}","starred_url":"https://api.github.com/users/noam-almog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noam-almog/subscriptions","organizations_url":"https://api.github.com/users/noam-almog/orgs","repos_url":"https://api.github.com/users/noam-almog/repos","events_url":"https://api.github.com/users/noam-almog/events{/privacy}","received_events_url":"https://api.github.com/users/noam-almog/received_events","type":"User","site_admin":false},"repo":{"id":64660570,"name":"specs2","full_name":"noam-almog/specs2","owner":{"login":"noam-almog","id":4091923,"avatar_url":"https://avatars.githubusercontent.com/u/4091923?v=3","gravatar_id":"","url":"https://api.github.com/users/noam-almog","html_url":"https://github.com/noam-almog","followers_url":"https://api.github.com/users/noam-almog/followers","following_url":"https://api.github.com/users/noam-almog/following{/other_user}","gists_url":"https://api.github.com/users/noam-almog/gists{/gist_id}","starred_url":"https://api.github.com/users/noam-almog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noam-almog/subscriptions","organizations_url":"https://api.github.com/users/noam-almog/orgs","repos_url":"https://api.github.com/users/noam-almog/repos","events_url":"https://api.github.com/users/noam-almog/events{/privacy}","received_events_url":"https://api.github.com/users/noam-almog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/noam-almog/specs2","description":"Software Specifications for Scala","fork":true,"url":"https://api.github.com/repos/noam-almog/specs2","forks_url":"https://api.github.com/repos/noam-almog/specs2/forks","keys_url":"https://api.github.com/repos/noam-almog/specs2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/noam-almog/specs2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/noam-almog/specs2/teams","hooks_url":"https://api.github.com/repos/noam-almog/specs2/hooks","issue_events_url":"https://api.github.com/repos/noam-almog/specs2/issues/events{/number}","events_url":"https://api.github.com/repos/noam-almog/specs2/events","assignees_url":"https://api.github.com/repos/noam-almog/specs2/assignees{/user}","branches_url":"https://api.github.com/repos/noam-almog/specs2/branches{/branch}","tags_url":"https://api.github.com/repos/noam-almog/specs2/tags","blobs_url":"https://api.github.com/repos/noam-almog/specs2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/noam-almog/specs2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/noam-almog/specs2/git/refs{/sha}","trees_url":"https://api.github.com/repos/noam-almog/specs2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/noam-almog/specs2/statuses/{sha}","languages_url":"https://api.github.com/repos/noam-almog/specs2/languages","stargazers_url":"https://api.github.com/repos/noam-almog/specs2/stargazers","contributors_url":"https://api.github.com/repos/noam-almog/specs2/contributors","subscribers_url":"https://api.github.com/repos/noam-almog/specs2/subscribers","subscription_url":"https://api.github.com/repos/noam-almog/specs2/subscription","commits_url":"https://api.github.com/repos/noam-almog/specs2/commits{/sha}","git_commits_url":"https://api.github.com/repos/noam-almog/specs2/git/commits{/sha}","comments_url":"https://api.github.com/repos/noam-almog/specs2/comments{/number}","issue_comment_url":"https://api.github.com/repos/noam-almog/specs2/issues/comments{/number}","contents_url":"https://api.github.com/repos/noam-almog/specs2/contents/{+path}","compare_url":"https://api.github.com/repos/noam-almog/specs2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/noam-almog/specs2/merges","archive_url":"https://api.github.com/repos/noam-almog/specs2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/noam-almog/specs2/downloads","issues_url":"https://api.github.com/repos/noam-almog/specs2/issues{/number}","pulls_url":"https://api.github.com/repos/noam-almog/specs2/pulls{/number}","milestones_url":"https://api.github.com/repos/noam-almog/specs2/milestones{/number}","notifications_url":"https://api.github.com/repos/noam-almog/specs2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/noam-almog/specs2/labels{/name}","releases_url":"https://api.github.com/repos/noam-almog/specs2/releases{/id}","deployments_url":"https://api.github.com/repos/noam-almog/specs2/deployments","created_at":"2016-08-01T11:11:08Z","updated_at":"2016-08-02T12:40:34Z","pushed_at":"2016-09-07T09:15:03Z","git_url":"git://github.com/noam-almog/specs2.git","ssh_url":"git@github.com:noam-almog/specs2.git","clone_url":"https://github.com/noam-almog/specs2.git","svn_url":"https://github.com/noam-almog/specs2","homepage":"http://specs2.org","size":74244,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"etorreborre:master","ref":"master","sha":"8470e96680bcf5dce34b8b0e86b05276a22cca22","user":{"login":"etorreborre","id":10988,"avatar_url":"https://avatars.githubusercontent.com/u/10988?v=3","gravatar_id":"","url":"https://api.github.com/users/etorreborre","html_url":"https://github.com/etorreborre","followers_url":"https://api.github.com/users/etorreborre/followers","following_url":"https://api.github.com/users/etorreborre/following{/other_user}","gists_url":"https://api.github.com/users/etorreborre/gists{/gist_id}","starred_url":"https://api.github.com/users/etorreborre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etorreborre/subscriptions","organizations_url":"https://api.github.com/users/etorreborre/orgs","repos_url":"https://api.github.com/users/etorreborre/repos","events_url":"https://api.github.com/users/etorreborre/events{/privacy}","received_events_url":"https://api.github.com/users/etorreborre/received_events","type":"User","site_admin":false},"repo":{"id":884800,"name":"specs2","full_name":"etorreborre/specs2","owner":{"login":"etorreborre","id":10988,"avatar_url":"https://avatars.githubusercontent.com/u/10988?v=3","gravatar_id":"","url":"https://api.github.com/users/etorreborre","html_url":"https://github.com/etorreborre","followers_url":"https://api.github.com/users/etorreborre/followers","following_url":"https://api.github.com/users/etorreborre/following{/other_user}","gists_url":"https://api.github.com/users/etorreborre/gists{/gist_id}","starred_url":"https://api.github.com/users/etorreborre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etorreborre/subscriptions","organizations_url":"https://api.github.com/users/etorreborre/orgs","repos_url":"https://api.github.com/users/etorreborre/repos","events_url":"https://api.github.com/users/etorreborre/events{/privacy}","received_events_url":"https://api.github.com/users/etorreborre/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/etorreborre/specs2","description":"Software Specifications for Scala","fork":false,"url":"https://api.github.com/repos/etorreborre/specs2","forks_url":"https://api.github.com/repos/etorreborre/specs2/forks","keys_url":"https://api.github.com/repos/etorreborre/specs2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/etorreborre/specs2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/etorreborre/specs2/teams","hooks_url":"https://api.github.com/repos/etorreborre/specs2/hooks","issue_events_url":"https://api.github.com/repos/etorreborre/specs2/issues/events{/number}","events_url":"https://api.github.com/repos/etorreborre/specs2/events","assignees_url":"https://api.github.com/repos/etorreborre/specs2/assignees{/user}","branches_url":"https://api.github.com/repos/etorreborre/specs2/branches{/branch}","tags_url":"https://api.github.com/repos/etorreborre/specs2/tags","blobs_url":"https://api.github.com/repos/etorreborre/specs2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/etorreborre/specs2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/etorreborre/specs2/git/refs{/sha}","trees_url":"https://api.github.com/repos/etorreborre/specs2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/etorreborre/specs2/statuses/{sha}","languages_url":"https://api.github.com/repos/etorreborre/specs2/languages","stargazers_url":"https://api.github.com/repos/etorreborre/specs2/stargazers","contributors_url":"https://api.github.com/repos/etorreborre/specs2/contributors","subscribers_url":"https://api.github.com/repos/etorreborre/specs2/subscribers","subscription_url":"https://api.github.com/repos/etorreborre/specs2/subscription","commits_url":"https://api.github.com/repos/etorreborre/specs2/commits{/sha}","git_commits_url":"https://api.github.com/repos/etorreborre/specs2/git/commits{/sha}","comments_url":"https://api.github.com/repos/etorreborre/specs2/comments{/number}","issue_comment_url":"https://api.github.com/repos/etorreborre/specs2/issues/comments{/number}","contents_url":"https://api.github.com/repos/etorreborre/specs2/contents/{+path}","compare_url":"https://api.github.com/repos/etorreborre/specs2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/etorreborre/specs2/merges","archive_url":"https://api.github.com/repos/etorreborre/specs2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/etorreborre/specs2/downloads","issues_url":"https://api.github.com/repos/etorreborre/specs2/issues{/number}","pulls_url":"https://api.github.com/repos/etorreborre/specs2/pulls{/number}","milestones_url":"https://api.github.com/repos/etorreborre/specs2/milestones{/number}","notifications_url":"https://api.github.com/repos/etorreborre/specs2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/etorreborre/specs2/labels{/name}","releases_url":"https://api.github.com/repos/etorreborre/specs2/releases{/id}","deployments_url":"https://api.github.com/repos/etorreborre/specs2/deployments","created_at":"2010-09-03T01:55:10Z","updated_at":"2016-09-05T20:34:39Z","pushed_at":"2016-09-07T09:15:04Z","git_url":"git://github.com/etorreborre/specs2.git","ssh_url":"git@github.com:etorreborre/specs2.git","clone_url":"https://github.com/etorreborre/specs2.git","svn_url":"https://github.com/etorreborre/specs2","homepage":"http://specs2.org","size":76323,"stargazers_count":531,"watchers_count":531,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":132,"mirror_url":null,"open_issues_count":6,"forks":132,"open_issues":6,"watchers":531,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/etorreborre/specs2/pulls/500"},"html":{"href":"https://github.com/etorreborre/specs2/pull/500"},"issue":{"href":"https://api.github.com/repos/etorreborre/specs2/issues/500"},"comments":{"href":"https://api.github.com/repos/etorreborre/specs2/issues/500/comments"},"review_comments":{"href":"https://api.github.com/repos/etorreborre/specs2/pulls/500/comments"},"review_comment":{"href":"https://api.github.com/repos/etorreborre/specs2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/etorreborre/specs2/pulls/500/commits"},"statuses":{"href":"https://api.github.com/repos/etorreborre/specs2/statuses/b945dedda2e7ec073e2febc1b3efa46084092037"}}}}
{"actor":{"display_login":"etorreborre"}}