{"action":"created","comment":{"url":"https://api.github.com/repos/BlueBrain/Livre/pulls/comments/83819572","pull_request_review_id":4636151,"id":83819572,"diff_hunk":"@@ -538,8 +553,45 @@ struct RayCastRenderer::Impl\n         glUseProgram( 0 );\n     }\n \n-    void onFrameEnd()\n+    void onFrameEnd( const Frustum& frustum )\n     {\n+        if( _drawAxis )\n+        {\n+            GLSLShaders::Handle program = _axisShaders.getProgram( );\n+            LBASSERT( program );\n+            glUseProgram( program );\n+\n+            glBindImageTexture( 0, _renderTexture.getName(),\n+                                0, GL_FALSE, 0, GL_READ_WRITE,\n+                                _renderTexture.getInternalFormat( ));\n+\n+            GLint tParamNameGL = glGetUniformLocation( program, \"renderTexture\" );\n+            glUniform1i( tParamNameGL, 0 );\n+\n+            tParamNameGL = glGetUniformLocation( program, \"modelViewProjectionMatrix\" );\n+            glUniformMatrix4fv( tParamNameGL, 1, false, frustum.getMVPMatrix( ).array );\n+\n+            tParamNameGL = glGetUniformLocation( program, \"normalMatrix\" );\n+            glUniformMatrix4fv( tParamNameGL, 1, false, frustum.getNormalMatrix( ).array );\n+\n+            Vector4i viewport;\n+            glGetIntegerv( GL_VIEWPORT, viewport.array );\n+            tParamNameGL = glGetUniformLocation( program, \"viewport\" );\n+            glUniform4iv( tParamNameGL, 1, viewport.array );\n+\n+            Vector2f depthRange;\n+            glGetFloatv( GL_DEPTH_RANGE, depthRange.array );\n+            tParamNameGL = glGetUniformLocation( program, \"depthRange\" );\n+            glUniform2fv( tParamNameGL, 1, depthRange.array );\n+\n+            tParamNameGL = glGetUniformLocation( program, \"invProjectionMatrix\" );\n+            glUniformMatrix4fv( tParamNameGL, 1, false, frustum.getInvProjMatrix( ).array );\n+\n+            _axis.draw();\n+\n+            glUseProgram( 0 );\n+        }","path":"livre/eq/render/RayCastRenderer.cpp","position":96,"original_position":96,"commit_id":"0745280e8136e58e65dea80947f4c1a7cc8a68bb","original_commit_id":"0745280e8136e58e65dea80947f4c1a7cc8a68bb","user":{"login":"eile","id":354947,"avatar_url":"https://avatars.githubusercontent.com/u/354947?v=3","gravatar_id":"","url":"https://api.github.com/users/eile","html_url":"https://github.com/eile","followers_url":"https://api.github.com/users/eile/followers","following_url":"https://api.github.com/users/eile/following{/other_user}","gists_url":"https://api.github.com/users/eile/gists{/gist_id}","starred_url":"https://api.github.com/users/eile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eile/subscriptions","organizations_url":"https://api.github.com/users/eile/orgs","repos_url":"https://api.github.com/users/eile/repos","events_url":"https://api.github.com/users/eile/events{/privacy}","received_events_url":"https://api.github.com/users/eile/received_events","type":"User","site_admin":false},"body":"refactor if scope into method","created_at":"2016-10-18T09:55:23Z","updated_at":"2016-10-18T09:55:23Z","html_url":"https://github.com/BlueBrain/Livre/pull/346#discussion_r83819572","pull_request_url":"https://api.github.com/repos/BlueBrain/Livre/pulls/346","_links":{"self":{"href":"https://api.github.com/repos/BlueBrain/Livre/pulls/comments/83819572"},"html":{"href":"https://github.com/BlueBrain/Livre/pull/346#discussion_r83819572"},"pull_request":{"href":"https://api.github.com/repos/BlueBrain/Livre/pulls/346"}}},"pull_request":{"url":"https://api.github.com/repos/BlueBrain/Livre/pulls/346","id":89769123,"html_url":"https://github.com/BlueBrain/Livre/pull/346","diff_url":"https://github.com/BlueBrain/Livre/pull/346.diff","patch_url":"https://github.com/BlueBrain/Livre/pull/346.patch","issue_url":"https://api.github.com/repos/BlueBrain/Livre/issues/346","number":346,"state":"open","locked":false,"title":"Axis drawing is working","user":{"login":"chevtche","id":10452408,"avatar_url":"https://avatars.githubusercontent.com/u/10452408?v=3","gravatar_id":"","url":"https://api.github.com/users/chevtche","html_url":"https://github.com/chevtche","followers_url":"https://api.github.com/users/chevtche/followers","following_url":"https://api.github.com/users/chevtche/following{/other_user}","gists_url":"https://api.github.com/users/chevtche/gists{/gist_id}","starred_url":"https://api.github.com/users/chevtche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chevtche/subscriptions","organizations_url":"https://api.github.com/users/chevtche/orgs","repos_url":"https://api.github.com/users/chevtche/repos","events_url":"https://api.github.com/users/chevtche/events{/privacy}","received_events_url":"https://api.github.com/users/chevtche/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-18T08:35:27Z","updated_at":"2016-10-18T09:58:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f82c4f14359c53997deb29ad1833a1a86494a13","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/BlueBrain/Livre/pulls/346/commits","review_comments_url":"https://api.github.com/repos/BlueBrain/Livre/pulls/346/comments","review_comment_url":"https://api.github.com/repos/BlueBrain/Livre/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BlueBrain/Livre/issues/346/comments","statuses_url":"https://api.github.com/repos/BlueBrain/Livre/statuses/0745280e8136e58e65dea80947f4c1a7cc8a68bb","head":{"label":"chevtche:master","ref":"master","sha":"0745280e8136e58e65dea80947f4c1a7cc8a68bb","user":{"login":"chevtche","id":10452408,"avatar_url":"https://avatars.githubusercontent.com/u/10452408?v=3","gravatar_id":"","url":"https://api.github.com/users/chevtche","html_url":"https://github.com/chevtche","followers_url":"https://api.github.com/users/chevtche/followers","following_url":"https://api.github.com/users/chevtche/following{/other_user}","gists_url":"https://api.github.com/users/chevtche/gists{/gist_id}","starred_url":"https://api.github.com/users/chevtche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chevtche/subscriptions","organizations_url":"https://api.github.com/users/chevtche/orgs","repos_url":"https://api.github.com/users/chevtche/repos","events_url":"https://api.github.com/users/chevtche/events{/privacy}","received_events_url":"https://api.github.com/users/chevtche/received_events","type":"User","site_admin":false},"repo":{"id":34253801,"name":"Livre","full_name":"chevtche/Livre","owner":{"login":"chevtche","id":10452408,"avatar_url":"https://avatars.githubusercontent.com/u/10452408?v=3","gravatar_id":"","url":"https://api.github.com/users/chevtche","html_url":"https://github.com/chevtche","followers_url":"https://api.github.com/users/chevtche/followers","following_url":"https://api.github.com/users/chevtche/following{/other_user}","gists_url":"https://api.github.com/users/chevtche/gists{/gist_id}","starred_url":"https://api.github.com/users/chevtche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chevtche/subscriptions","organizations_url":"https://api.github.com/users/chevtche/orgs","repos_url":"https://api.github.com/users/chevtche/repos","events_url":"https://api.github.com/users/chevtche/events{/privacy}","received_events_url":"https://api.github.com/users/chevtche/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chevtche/Livre","description":"Largescale Interactive Volume Rendering Engine","fork":true,"url":"https://api.github.com/repos/chevtche/Livre","forks_url":"https://api.github.com/repos/chevtche/Livre/forks","keys_url":"https://api.github.com/repos/chevtche/Livre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chevtche/Livre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chevtche/Livre/teams","hooks_url":"https://api.github.com/repos/chevtche/Livre/hooks","issue_events_url":"https://api.github.com/repos/chevtche/Livre/issues/events{/number}","events_url":"https://api.github.com/repos/chevtche/Livre/events","assignees_url":"https://api.github.com/repos/chevtche/Livre/assignees{/user}","branches_url":"https://api.github.com/repos/chevtche/Livre/branches{/branch}","tags_url":"https://api.github.com/repos/chevtche/Livre/tags","blobs_url":"https://api.github.com/repos/chevtche/Livre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chevtche/Livre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chevtche/Livre/git/refs{/sha}","trees_url":"https://api.github.com/repos/chevtche/Livre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chevtche/Livre/statuses/{sha}","languages_url":"https://api.github.com/repos/chevtche/Livre/languages","stargazers_url":"https://api.github.com/repos/chevtche/Livre/stargazers","contributors_url":"https://api.github.com/repos/chevtche/Livre/contributors","subscribers_url":"https://api.github.com/repos/chevtche/Livre/subscribers","subscription_url":"https://api.github.com/repos/chevtche/Livre/subscription","commits_url":"https://api.github.com/repos/chevtche/Livre/commits{/sha}","git_commits_url":"https://api.github.com/repos/chevtche/Livre/git/commits{/sha}","comments_url":"https://api.github.com/repos/chevtche/Livre/comments{/number}","issue_comment_url":"https://api.github.com/repos/chevtche/Livre/issues/comments{/number}","contents_url":"https://api.github.com/repos/chevtche/Livre/contents/{+path}","compare_url":"https://api.github.com/repos/chevtche/Livre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chevtche/Livre/merges","archive_url":"https://api.github.com/repos/chevtche/Livre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chevtche/Livre/downloads","issues_url":"https://api.github.com/repos/chevtche/Livre/issues{/number}","pulls_url":"https://api.github.com/repos/chevtche/Livre/pulls{/number}","milestones_url":"https://api.github.com/repos/chevtche/Livre/milestones{/number}","notifications_url":"https://api.github.com/repos/chevtche/Livre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chevtche/Livre/labels{/name}","releases_url":"https://api.github.com/repos/chevtche/Livre/releases{/id}","deployments_url":"https://api.github.com/repos/chevtche/Livre/deployments","created_at":"2015-04-20T10:22:23Z","updated_at":"2016-03-22T16:31:40Z","pushed_at":"2016-10-18T08:32:01Z","git_url":"git://github.com/chevtche/Livre.git","ssh_url":"git@github.com:chevtche/Livre.git","clone_url":"https://github.com/chevtche/Livre.git","svn_url":"https://github.com/chevtche/Livre","homepage":"https://bluebrain.github.io","size":8644,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BlueBrain:master","ref":"master","sha":"399090933212e487546abae94f882c92159cc4c2","user":{"login":"BlueBrain","id":1479142,"avatar_url":"https://avatars.githubusercontent.com/u/1479142?v=3","gravatar_id":"","url":"https://api.github.com/users/BlueBrain","html_url":"https://github.com/BlueBrain","followers_url":"https://api.github.com/users/BlueBrain/followers","following_url":"https://api.github.com/users/BlueBrain/following{/other_user}","gists_url":"https://api.github.com/users/BlueBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/BlueBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlueBrain/subscriptions","organizations_url":"https://api.github.com/users/BlueBrain/orgs","repos_url":"https://api.github.com/users/BlueBrain/repos","events_url":"https://api.github.com/users/BlueBrain/events{/privacy}","received_events_url":"https://api.github.com/users/BlueBrain/received_events","type":"Organization","site_admin":false},"repo":{"id":10625435,"name":"Livre","full_name":"BlueBrain/Livre","owner":{"login":"BlueBrain","id":1479142,"avatar_url":"https://avatars.githubusercontent.com/u/1479142?v=3","gravatar_id":"","url":"https://api.github.com/users/BlueBrain","html_url":"https://github.com/BlueBrain","followers_url":"https://api.github.com/users/BlueBrain/followers","following_url":"https://api.github.com/users/BlueBrain/following{/other_user}","gists_url":"https://api.github.com/users/BlueBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/BlueBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlueBrain/subscriptions","organizations_url":"https://api.github.com/users/BlueBrain/orgs","repos_url":"https://api.github.com/users/BlueBrain/repos","events_url":"https://api.github.com/users/BlueBrain/events{/privacy}","received_events_url":"https://api.github.com/users/BlueBrain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BlueBrain/Livre","description":"Large-scale Interactive Volume Rendering Engine","fork":false,"url":"https://api.github.com/repos/BlueBrain/Livre","forks_url":"https://api.github.com/repos/BlueBrain/Livre/forks","keys_url":"https://api.github.com/repos/BlueBrain/Livre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BlueBrain/Livre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BlueBrain/Livre/teams","hooks_url":"https://api.github.com/repos/BlueBrain/Livre/hooks","issue_events_url":"https://api.github.com/repos/BlueBrain/Livre/issues/events{/number}","events_url":"https://api.github.com/repos/BlueBrain/Livre/events","assignees_url":"https://api.github.com/repos/BlueBrain/Livre/assignees{/user}","branches_url":"https://api.github.com/repos/BlueBrain/Livre/branches{/branch}","tags_url":"https://api.github.com/repos/BlueBrain/Livre/tags","blobs_url":"https://api.github.com/repos/BlueBrain/Livre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BlueBrain/Livre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BlueBrain/Livre/git/refs{/sha}","trees_url":"https://api.github.com/repos/BlueBrain/Livre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BlueBrain/Livre/statuses/{sha}","languages_url":"https://api.github.com/repos/BlueBrain/Livre/languages","stargazers_url":"https://api.github.com/repos/BlueBrain/Livre/stargazers","contributors_url":"https://api.github.com/repos/BlueBrain/Livre/contributors","subscribers_url":"https://api.github.com/repos/BlueBrain/Livre/subscribers","subscription_url":"https://api.github.com/repos/BlueBrain/Livre/subscription","commits_url":"https://api.github.com/repos/BlueBrain/Livre/commits{/sha}","git_commits_url":"https://api.github.com/repos/BlueBrain/Livre/git/commits{/sha}","comments_url":"https://api.github.com/repos/BlueBrain/Livre/comments{/number}","issue_comment_url":"https://api.github.com/repos/BlueBrain/Livre/issues/comments{/number}","contents_url":"https://api.github.com/repos/BlueBrain/Livre/contents/{+path}","compare_url":"https://api.github.com/repos/BlueBrain/Livre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BlueBrain/Livre/merges","archive_url":"https://api.github.com/repos/BlueBrain/Livre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BlueBrain/Livre/downloads","issues_url":"https://api.github.com/repos/BlueBrain/Livre/issues{/number}","pulls_url":"https://api.github.com/repos/BlueBrain/Livre/pulls{/number}","milestones_url":"https://api.github.com/repos/BlueBrain/Livre/milestones{/number}","notifications_url":"https://api.github.com/repos/BlueBrain/Livre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BlueBrain/Livre/labels{/name}","releases_url":"https://api.github.com/repos/BlueBrain/Livre/releases{/id}","deployments_url":"https://api.github.com/repos/BlueBrain/Livre/deployments","created_at":"2013-06-11T16:13:56Z","updated_at":"2016-10-15T14:26:59Z","pushed_at":"2016-10-18T08:35:27Z","git_url":"git://github.com/BlueBrain/Livre.git","ssh_url":"git@github.com:BlueBrain/Livre.git","clone_url":"https://github.com/BlueBrain/Livre.git","svn_url":"https://github.com/BlueBrain/Livre","homepage":"https://bluebrain.github.io","size":8856,"stargazers_count":12,"watchers_count":12,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":26,"forks":14,"open_issues":26,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BlueBrain/Livre/pulls/346"},"html":{"href":"https://github.com/BlueBrain/Livre/pull/346"},"issue":{"href":"https://api.github.com/repos/BlueBrain/Livre/issues/346"},"comments":{"href":"https://api.github.com/repos/BlueBrain/Livre/issues/346/comments"},"review_comments":{"href":"https://api.github.com/repos/BlueBrain/Livre/pulls/346/comments"},"review_comment":{"href":"https://api.github.com/repos/BlueBrain/Livre/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BlueBrain/Livre/pulls/346/commits"},"statuses":{"href":"https://api.github.com/repos/BlueBrain/Livre/statuses/0745280e8136e58e65dea80947f4c1a7cc8a68bb"}}}}
{"actor":{"display_login":"eile"}}