{"action":"closed","number":314,"pull_request":{"url":"https://api.github.com/repos/nextcloud/server/pulls/314","id":76324545,"html_url":"https://github.com/nextcloud/server/pull/314","diff_url":"https://github.com/nextcloud/server/pull/314.diff","patch_url":"https://github.com/nextcloud/server/pull/314.patch","issue_url":"https://api.github.com/repos/nextcloud/server/issues/314","number":314,"state":"closed","locked":false,"title":"Allow wildcard * to be used in trusted domains","user":{"login":"jernst","id":874785,"avatar_url":"https://avatars.githubusercontent.com/u/874785?v=3","gravatar_id":"","url":"https://api.github.com/users/jernst","html_url":"https://github.com/jernst","followers_url":"https://api.github.com/users/jernst/followers","following_url":"https://api.github.com/users/jernst/following{/other_user}","gists_url":"https://api.github.com/users/jernst/gists{/gist_id}","starred_url":"https://api.github.com/users/jernst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jernst/subscriptions","organizations_url":"https://api.github.com/users/jernst/orgs","repos_url":"https://api.github.com/users/jernst/repos","events_url":"https://api.github.com/users/jernst/events{/privacy}","received_events_url":"https://api.github.com/users/jernst/received_events","type":"User","site_admin":false},"body":"This is to support setups where no reliable DNS entry is available (e.g. mDNS) or for simple-to-setup aliasing (e.g. *.example.com)\r\n\r\nThis time, I hope, tabs and formatting are all in the right places for your coding standards. We had been doing this patch just for UBOS, but now that you are doing checksums on PHP files, such as private patch leads to warnings in the management console, and I hope it can be merged into the main.\r\n\r\nAs using a * in a trusted domain is entirely optional, this should have no security implications for the default setup.\r\n\r\nIf you'd like me to augment some existing tests, I'd appreciate a pointer to which tests.","created_at":"2016-07-05T18:57:06Z","updated_at":"2016-07-07T17:34:12Z","closed_at":"2016-07-07T17:34:11Z","merged_at":"2016-07-07T17:34:11Z","merge_commit_sha":"487d15011cade51a91ea8e5d06540721d46429cc","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/nextcloud/server/milestones/2","html_url":"https://github.com/nextcloud/server/milestones/Nextcloud%20Next","labels_url":"https://api.github.com/repos/nextcloud/server/milestones/2/labels","id":1812017,"number":2,"title":"Nextcloud Next","description":"","creator":{"login":"jancborchardt","id":925062,"avatar_url":"https://avatars.githubusercontent.com/u/925062?v=3","gravatar_id":"","url":"https://api.github.com/users/jancborchardt","html_url":"https://github.com/jancborchardt","followers_url":"https://api.github.com/users/jancborchardt/followers","following_url":"https://api.github.com/users/jancborchardt/following{/other_user}","gists_url":"https://api.github.com/users/jancborchardt/gists{/gist_id}","starred_url":"https://api.github.com/users/jancborchardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jancborchardt/subscriptions","organizations_url":"https://api.github.com/users/jancborchardt/orgs","repos_url":"https://api.github.com/users/jancborchardt/repos","events_url":"https://api.github.com/users/jancborchardt/events{/privacy}","received_events_url":"https://api.github.com/users/jancborchardt/received_events","type":"User","site_admin":false},"open_issues":20,"closed_issues":102,"state":"open","created_at":"2016-06-06T21:28:18Z","updated_at":"2016-07-07T17:34:12Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/nextcloud/server/pulls/314/commits","review_comments_url":"https://api.github.com/repos/nextcloud/server/pulls/314/comments","review_comment_url":"https://api.github.com/repos/nextcloud/server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nextcloud/server/issues/314/comments","statuses_url":"https://api.github.com/repos/nextcloud/server/statuses/2b96e904d092f6e44be7df1380fbaf64821b2b50","head":{"label":"jernst:master","ref":"master","sha":"2b96e904d092f6e44be7df1380fbaf64821b2b50","user":{"login":"jernst","id":874785,"avatar_url":"https://avatars.githubusercontent.com/u/874785?v=3","gravatar_id":"","url":"https://api.github.com/users/jernst","html_url":"https://github.com/jernst","followers_url":"https://api.github.com/users/jernst/followers","following_url":"https://api.github.com/users/jernst/following{/other_user}","gists_url":"https://api.github.com/users/jernst/gists{/gist_id}","starred_url":"https://api.github.com/users/jernst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jernst/subscriptions","organizations_url":"https://api.github.com/users/jernst/orgs","repos_url":"https://api.github.com/users/jernst/repos","events_url":"https://api.github.com/users/jernst/events{/privacy}","received_events_url":"https://api.github.com/users/jernst/received_events","type":"User","site_admin":false},"repo":{"id":62660495,"name":"nextcloud-server","full_name":"jernst/nextcloud-server","owner":{"login":"jernst","id":874785,"avatar_url":"https://avatars.githubusercontent.com/u/874785?v=3","gravatar_id":"","url":"https://api.github.com/users/jernst","html_url":"https://github.com/jernst","followers_url":"https://api.github.com/users/jernst/followers","following_url":"https://api.github.com/users/jernst/following{/other_user}","gists_url":"https://api.github.com/users/jernst/gists{/gist_id}","starred_url":"https://api.github.com/users/jernst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jernst/subscriptions","organizations_url":"https://api.github.com/users/jernst/orgs","repos_url":"https://api.github.com/users/jernst/repos","events_url":"https://api.github.com/users/jernst/events{/privacy}","received_events_url":"https://api.github.com/users/jernst/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jernst/nextcloud-server","description":"☁️ Nextcloud server component","fork":true,"url":"https://api.github.com/repos/jernst/nextcloud-server","forks_url":"https://api.github.com/repos/jernst/nextcloud-server/forks","keys_url":"https://api.github.com/repos/jernst/nextcloud-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jernst/nextcloud-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jernst/nextcloud-server/teams","hooks_url":"https://api.github.com/repos/jernst/nextcloud-server/hooks","issue_events_url":"https://api.github.com/repos/jernst/nextcloud-server/issues/events{/number}","events_url":"https://api.github.com/repos/jernst/nextcloud-server/events","assignees_url":"https://api.github.com/repos/jernst/nextcloud-server/assignees{/user}","branches_url":"https://api.github.com/repos/jernst/nextcloud-server/branches{/branch}","tags_url":"https://api.github.com/repos/jernst/nextcloud-server/tags","blobs_url":"https://api.github.com/repos/jernst/nextcloud-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jernst/nextcloud-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jernst/nextcloud-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/jernst/nextcloud-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jernst/nextcloud-server/statuses/{sha}","languages_url":"https://api.github.com/repos/jernst/nextcloud-server/languages","stargazers_url":"https://api.github.com/repos/jernst/nextcloud-server/stargazers","contributors_url":"https://api.github.com/repos/jernst/nextcloud-server/contributors","subscribers_url":"https://api.github.com/repos/jernst/nextcloud-server/subscribers","subscription_url":"https://api.github.com/repos/jernst/nextcloud-server/subscription","commits_url":"https://api.github.com/repos/jernst/nextcloud-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/jernst/nextcloud-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/jernst/nextcloud-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/jernst/nextcloud-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/jernst/nextcloud-server/contents/{+path}","compare_url":"https://api.github.com/repos/jernst/nextcloud-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jernst/nextcloud-server/merges","archive_url":"https://api.github.com/repos/jernst/nextcloud-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jernst/nextcloud-server/downloads","issues_url":"https://api.github.com/repos/jernst/nextcloud-server/issues{/number}","pulls_url":"https://api.github.com/repos/jernst/nextcloud-server/pulls{/number}","milestones_url":"https://api.github.com/repos/jernst/nextcloud-server/milestones{/number}","notifications_url":"https://api.github.com/repos/jernst/nextcloud-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jernst/nextcloud-server/labels{/name}","releases_url":"https://api.github.com/repos/jernst/nextcloud-server/releases{/id}","deployments_url":"https://api.github.com/repos/jernst/nextcloud-server/deployments","created_at":"2016-07-05T18:37:05Z","updated_at":"2016-07-05T18:37:44Z","pushed_at":"2016-07-07T16:24:29Z","git_url":"git://github.com/jernst/nextcloud-server.git","ssh_url":"git@github.com:jernst/nextcloud-server.git","clone_url":"https://github.com/jernst/nextcloud-server.git","svn_url":"https://github.com/jernst/nextcloud-server","homepage":"https://nextcloud.com","size":210342,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nextcloud:master","ref":"master","sha":"83ea738522a2a293e019b9ba6065b41c9fd64384","user":{"login":"nextcloud","id":19211038,"avatar_url":"https://avatars.githubusercontent.com/u/19211038?v=3","gravatar_id":"","url":"https://api.github.com/users/nextcloud","html_url":"https://github.com/nextcloud","followers_url":"https://api.github.com/users/nextcloud/followers","following_url":"https://api.github.com/users/nextcloud/following{/other_user}","gists_url":"https://api.github.com/users/nextcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/nextcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nextcloud/subscriptions","organizations_url":"https://api.github.com/users/nextcloud/orgs","repos_url":"https://api.github.com/users/nextcloud/repos","events_url":"https://api.github.com/users/nextcloud/events{/privacy}","received_events_url":"https://api.github.com/users/nextcloud/received_events","type":"Organization","site_admin":false},"repo":{"id":60243197,"name":"server","full_name":"nextcloud/server","owner":{"login":"nextcloud","id":19211038,"avatar_url":"https://avatars.githubusercontent.com/u/19211038?v=3","gravatar_id":"","url":"https://api.github.com/users/nextcloud","html_url":"https://github.com/nextcloud","followers_url":"https://api.github.com/users/nextcloud/followers","following_url":"https://api.github.com/users/nextcloud/following{/other_user}","gists_url":"https://api.github.com/users/nextcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/nextcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nextcloud/subscriptions","organizations_url":"https://api.github.com/users/nextcloud/orgs","repos_url":"https://api.github.com/users/nextcloud/repos","events_url":"https://api.github.com/users/nextcloud/events{/privacy}","received_events_url":"https://api.github.com/users/nextcloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nextcloud/server","description":"☁️ Nextcloud server component","fork":false,"url":"https://api.github.com/repos/nextcloud/server","forks_url":"https://api.github.com/repos/nextcloud/server/forks","keys_url":"https://api.github.com/repos/nextcloud/server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nextcloud/server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nextcloud/server/teams","hooks_url":"https://api.github.com/repos/nextcloud/server/hooks","issue_events_url":"https://api.github.com/repos/nextcloud/server/issues/events{/number}","events_url":"https://api.github.com/repos/nextcloud/server/events","assignees_url":"https://api.github.com/repos/nextcloud/server/assignees{/user}","branches_url":"https://api.github.com/repos/nextcloud/server/branches{/branch}","tags_url":"https://api.github.com/repos/nextcloud/server/tags","blobs_url":"https://api.github.com/repos/nextcloud/server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nextcloud/server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nextcloud/server/git/refs{/sha}","trees_url":"https://api.github.com/repos/nextcloud/server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nextcloud/server/statuses/{sha}","languages_url":"https://api.github.com/repos/nextcloud/server/languages","stargazers_url":"https://api.github.com/repos/nextcloud/server/stargazers","contributors_url":"https://api.github.com/repos/nextcloud/server/contributors","subscribers_url":"https://api.github.com/repos/nextcloud/server/subscribers","subscription_url":"https://api.github.com/repos/nextcloud/server/subscription","commits_url":"https://api.github.com/repos/nextcloud/server/commits{/sha}","git_commits_url":"https://api.github.com/repos/nextcloud/server/git/commits{/sha}","comments_url":"https://api.github.com/repos/nextcloud/server/comments{/number}","issue_comment_url":"https://api.github.com/repos/nextcloud/server/issues/comments{/number}","contents_url":"https://api.github.com/repos/nextcloud/server/contents/{+path}","compare_url":"https://api.github.com/repos/nextcloud/server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nextcloud/server/merges","archive_url":"https://api.github.com/repos/nextcloud/server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nextcloud/server/downloads","issues_url":"https://api.github.com/repos/nextcloud/server/issues{/number}","pulls_url":"https://api.github.com/repos/nextcloud/server/pulls{/number}","milestones_url":"https://api.github.com/repos/nextcloud/server/milestones{/number}","notifications_url":"https://api.github.com/repos/nextcloud/server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nextcloud/server/labels{/name}","releases_url":"https://api.github.com/repos/nextcloud/server/releases{/id}","deployments_url":"https://api.github.com/repos/nextcloud/server/deployments","created_at":"2016-06-02T07:44:14Z","updated_at":"2016-07-07T13:34:22Z","pushed_at":"2016-07-07T17:34:12Z","git_url":"git://github.com/nextcloud/server.git","ssh_url":"git@github.com:nextcloud/server.git","clone_url":"https://github.com/nextcloud/server.git","svn_url":"https://github.com/nextcloud/server","homepage":"https://nextcloud.com","size":228782,"stargazers_count":423,"watchers_count":423,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":83,"forks":46,"open_issues":83,"watchers":423,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nextcloud/server/pulls/314"},"html":{"href":"https://github.com/nextcloud/server/pull/314"},"issue":{"href":"https://api.github.com/repos/nextcloud/server/issues/314"},"comments":{"href":"https://api.github.com/repos/nextcloud/server/issues/314/comments"},"review_comments":{"href":"https://api.github.com/repos/nextcloud/server/pulls/314/comments"},"review_comment":{"href":"https://api.github.com/repos/nextcloud/server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nextcloud/server/pulls/314/commits"},"statuses":{"href":"https://api.github.com/repos/nextcloud/server/statuses/2b96e904d092f6e44be7df1380fbaf64821b2b50"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"LukasReschke","id":878997,"avatar_url":"https://avatars.githubusercontent.com/u/878997?v=3","gravatar_id":"","url":"https://api.github.com/users/LukasReschke","html_url":"https://github.com/LukasReschke","followers_url":"https://api.github.com/users/LukasReschke/followers","following_url":"https://api.github.com/users/LukasReschke/following{/other_user}","gists_url":"https://api.github.com/users/LukasReschke/gists{/gist_id}","starred_url":"https://api.github.com/users/LukasReschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukasReschke/subscriptions","organizations_url":"https://api.github.com/users/LukasReschke/orgs","repos_url":"https://api.github.com/users/LukasReschke/repos","events_url":"https://api.github.com/users/LukasReschke/events{/privacy}","received_events_url":"https://api.github.com/users/LukasReschke/received_events","type":"User","site_admin":false},"comments":11,"review_comments":2,"commits":5,"additions":51,"deletions":9,"changed_files":3}}
{"actor":{"display_login":"LukasReschke"}}