{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments/75180337","id":75180337,"diff_hunk":"@@ -0,0 +1,44 @@\n+//******************************************************************************\n+//\n+// Copyright (c) 2016 Microsoft Corporation. All rights reserved.\n+//\n+// This code is licensed under the MIT License (MIT).\n+//\n+// THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR\n+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,\n+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE\n+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER\n+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,\n+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN\n+// THE SOFTWARE.\n+//\n+//******************************************************************************\n+\n+#pragma once\n+\n+#import <AddressBook/ABMultiValue.h>\n+#import <Foundation/Foundation.h>\n+\n+@interface _ABMultiValue : NSObject\n+\n+- (id)initWithPropertyType:(ABPropertyType)propertyType;\n+\n+// Once the MultiValue is made immutable,\n+// appendPairWithLabel:andValue: no longer does anything;\n+// it returns YES if the appending occurred, or NO if the\n+// MultiValue is immutable and no change was made.","path":"Frameworks/include/ABMultiValueInternal.h","position":29,"original_position":29,"commit_id":"616d5ac24bc7ec7bc66355555f5fec9a95412f3c","original_commit_id":"616d5ac24bc7ec7bc66355555f5fec9a95412f3c","user":{"login":"bbowman","id":15642573,"avatar_url":"https://avatars.githubusercontent.com/u/15642573?v=3","gravatar_id":"","url":"https://api.github.com/users/bbowman","html_url":"https://github.com/bbowman","followers_url":"https://api.github.com/users/bbowman/followers","following_url":"https://api.github.com/users/bbowman/following{/other_user}","gists_url":"https://api.github.com/users/bbowman/gists{/gist_id}","starred_url":"https://api.github.com/users/bbowman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbowman/subscriptions","organizations_url":"https://api.github.com/users/bbowman/orgs","repos_url":"https://api.github.com/users/bbowman/repos","events_url":"https://api.github.com/users/bbowman/events{/privacy}","received_events_url":"https://api.github.com/users/bbowman/received_events","type":"User","site_admin":false},"body":"since this is logically a one way valve, why not just make it part of the init call? init could take an array/dictionary of pairs and then it would never need to deal with mutability.","created_at":"2016-08-17T18:33:11Z","updated_at":"2016-08-17T18:33:11Z","html_url":"https://github.com/Microsoft/WinObjC/pull/884#discussion_r75180337","pull_request_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/884","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments/75180337"},"html":{"href":"https://github.com/Microsoft/WinObjC/pull/884#discussion_r75180337"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/884"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/884","id":81571327,"html_url":"https://github.com/Microsoft/WinObjC/pull/884","diff_url":"https://github.com/Microsoft/WinObjC/pull/884.diff","patch_url":"https://github.com/Microsoft/WinObjC/pull/884.patch","issue_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/884","number":884,"state":"open","locked":false,"title":"AddressBook Framework -- MultiValue Support","user":{"login":"chadimoussi","id":9374918,"avatar_url":"https://avatars.githubusercontent.com/u/9374918?v=3","gravatar_id":"","url":"https://api.github.com/users/chadimoussi","html_url":"https://github.com/chadimoussi","followers_url":"https://api.github.com/users/chadimoussi/followers","following_url":"https://api.github.com/users/chadimoussi/following{/other_user}","gists_url":"https://api.github.com/users/chadimoussi/gists{/gist_id}","starred_url":"https://api.github.com/users/chadimoussi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadimoussi/subscriptions","organizations_url":"https://api.github.com/users/chadimoussi/orgs","repos_url":"https://api.github.com/users/chadimoussi/repos","events_url":"https://api.github.com/users/chadimoussi/events{/privacy}","received_events_url":"https://api.github.com/users/chadimoussi/received_events","type":"User","site_admin":false},"body":"Fixes #678\r\nAdded support for Multi-Values,\r\nwhich now allows more complex\r\ncontact values to be queried.","created_at":"2016-08-17T01:27:16Z","updated_at":"2016-08-17T18:33:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"418ad85fc6d301f148a6b2a19122ba492c44d726","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/884/commits","review_comments_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/884/comments","review_comment_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/884/comments","statuses_url":"https://api.github.com/repos/Microsoft/WinObjC/statuses/616d5ac24bc7ec7bc66355555f5fec9a95412f3c","head":{"label":"chadimoussi:t-chmou/addressbook_multi_value","ref":"t-chmou/addressbook_multi_value","sha":"616d5ac24bc7ec7bc66355555f5fec9a95412f3c","user":{"login":"chadimoussi","id":9374918,"avatar_url":"https://avatars.githubusercontent.com/u/9374918?v=3","gravatar_id":"","url":"https://api.github.com/users/chadimoussi","html_url":"https://github.com/chadimoussi","followers_url":"https://api.github.com/users/chadimoussi/followers","following_url":"https://api.github.com/users/chadimoussi/following{/other_user}","gists_url":"https://api.github.com/users/chadimoussi/gists{/gist_id}","starred_url":"https://api.github.com/users/chadimoussi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadimoussi/subscriptions","organizations_url":"https://api.github.com/users/chadimoussi/orgs","repos_url":"https://api.github.com/users/chadimoussi/repos","events_url":"https://api.github.com/users/chadimoussi/events{/privacy}","received_events_url":"https://api.github.com/users/chadimoussi/received_events","type":"User","site_admin":false},"repo":{"id":62256166,"name":"WinObjC","full_name":"chadimoussi/WinObjC","owner":{"login":"chadimoussi","id":9374918,"avatar_url":"https://avatars.githubusercontent.com/u/9374918?v=3","gravatar_id":"","url":"https://api.github.com/users/chadimoussi","html_url":"https://github.com/chadimoussi","followers_url":"https://api.github.com/users/chadimoussi/followers","following_url":"https://api.github.com/users/chadimoussi/following{/other_user}","gists_url":"https://api.github.com/users/chadimoussi/gists{/gist_id}","starred_url":"https://api.github.com/users/chadimoussi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadimoussi/subscriptions","organizations_url":"https://api.github.com/users/chadimoussi/orgs","repos_url":"https://api.github.com/users/chadimoussi/repos","events_url":"https://api.github.com/users/chadimoussi/events{/privacy}","received_events_url":"https://api.github.com/users/chadimoussi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chadimoussi/WinObjC","description":"Objective-C for Windows","fork":true,"url":"https://api.github.com/repos/chadimoussi/WinObjC","forks_url":"https://api.github.com/repos/chadimoussi/WinObjC/forks","keys_url":"https://api.github.com/repos/chadimoussi/WinObjC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chadimoussi/WinObjC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chadimoussi/WinObjC/teams","hooks_url":"https://api.github.com/repos/chadimoussi/WinObjC/hooks","issue_events_url":"https://api.github.com/repos/chadimoussi/WinObjC/issues/events{/number}","events_url":"https://api.github.com/repos/chadimoussi/WinObjC/events","assignees_url":"https://api.github.com/repos/chadimoussi/WinObjC/assignees{/user}","branches_url":"https://api.github.com/repos/chadimoussi/WinObjC/branches{/branch}","tags_url":"https://api.github.com/repos/chadimoussi/WinObjC/tags","blobs_url":"https://api.github.com/repos/chadimoussi/WinObjC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chadimoussi/WinObjC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chadimoussi/WinObjC/git/refs{/sha}","trees_url":"https://api.github.com/repos/chadimoussi/WinObjC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chadimoussi/WinObjC/statuses/{sha}","languages_url":"https://api.github.com/repos/chadimoussi/WinObjC/languages","stargazers_url":"https://api.github.com/repos/chadimoussi/WinObjC/stargazers","contributors_url":"https://api.github.com/repos/chadimoussi/WinObjC/contributors","subscribers_url":"https://api.github.com/repos/chadimoussi/WinObjC/subscribers","subscription_url":"https://api.github.com/repos/chadimoussi/WinObjC/subscription","commits_url":"https://api.github.com/repos/chadimoussi/WinObjC/commits{/sha}","git_commits_url":"https://api.github.com/repos/chadimoussi/WinObjC/git/commits{/sha}","comments_url":"https://api.github.com/repos/chadimoussi/WinObjC/comments{/number}","issue_comment_url":"https://api.github.com/repos/chadimoussi/WinObjC/issues/comments{/number}","contents_url":"https://api.github.com/repos/chadimoussi/WinObjC/contents/{+path}","compare_url":"https://api.github.com/repos/chadimoussi/WinObjC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chadimoussi/WinObjC/merges","archive_url":"https://api.github.com/repos/chadimoussi/WinObjC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chadimoussi/WinObjC/downloads","issues_url":"https://api.github.com/repos/chadimoussi/WinObjC/issues{/number}","pulls_url":"https://api.github.com/repos/chadimoussi/WinObjC/pulls{/number}","milestones_url":"https://api.github.com/repos/chadimoussi/WinObjC/milestones{/number}","notifications_url":"https://api.github.com/repos/chadimoussi/WinObjC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chadimoussi/WinObjC/labels{/name}","releases_url":"https://api.github.com/repos/chadimoussi/WinObjC/releases{/id}","deployments_url":"https://api.github.com/repos/chadimoussi/WinObjC/deployments","created_at":"2016-06-29T20:36:14Z","updated_at":"2016-06-29T20:36:28Z","pushed_at":"2016-08-17T01:20:46Z","git_url":"git://github.com/chadimoussi/WinObjC.git","ssh_url":"git@github.com:chadimoussi/WinObjC.git","clone_url":"https://github.com/chadimoussi/WinObjC.git","svn_url":"https://github.com/chadimoussi/WinObjC","homepage":"","size":331238,"stargazers_count":0,"watchers_count":0,"language":"Objective-C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"Microsoft:develop","ref":"develop","sha":"6931960e97139000a79ffee7138e50284a2281c4","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":37950166,"name":"WinObjC","full_name":"Microsoft/WinObjC","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/WinObjC","description":"Objective-C for Windows","fork":false,"url":"https://api.github.com/repos/Microsoft/WinObjC","forks_url":"https://api.github.com/repos/Microsoft/WinObjC/forks","keys_url":"https://api.github.com/repos/Microsoft/WinObjC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/WinObjC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/WinObjC/teams","hooks_url":"https://api.github.com/repos/Microsoft/WinObjC/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/WinObjC/events","assignees_url":"https://api.github.com/repos/Microsoft/WinObjC/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/WinObjC/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/WinObjC/tags","blobs_url":"https://api.github.com/repos/Microsoft/WinObjC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/WinObjC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/WinObjC/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/WinObjC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/WinObjC/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/WinObjC/languages","stargazers_url":"https://api.github.com/repos/Microsoft/WinObjC/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/WinObjC/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/WinObjC/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/WinObjC/subscription","commits_url":"https://api.github.com/repos/Microsoft/WinObjC/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/WinObjC/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/WinObjC/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/WinObjC/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/WinObjC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/WinObjC/merges","archive_url":"https://api.github.com/repos/Microsoft/WinObjC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/WinObjC/downloads","issues_url":"https://api.github.com/repos/Microsoft/WinObjC/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/WinObjC/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/WinObjC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/WinObjC/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/WinObjC/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/WinObjC/deployments","created_at":"2015-06-23T23:14:58Z","updated_at":"2016-08-17T18:06:39Z","pushed_at":"2016-08-17T17:43:32Z","git_url":"git://github.com/Microsoft/WinObjC.git","ssh_url":"git@github.com:Microsoft/WinObjC.git","clone_url":"https://github.com/Microsoft/WinObjC.git","svn_url":"https://github.com/Microsoft/WinObjC","homepage":"","size":334266,"stargazers_count":5415,"watchers_count":5415,"language":"Objective-C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":690,"mirror_url":null,"open_issues_count":219,"forks":690,"open_issues":219,"watchers":5415,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/884"},"html":{"href":"https://github.com/Microsoft/WinObjC/pull/884"},"issue":{"href":"https://api.github.com/repos/Microsoft/WinObjC/issues/884"},"comments":{"href":"https://api.github.com/repos/Microsoft/WinObjC/issues/884/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/884/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/884/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/WinObjC/statuses/616d5ac24bc7ec7bc66355555f5fec9a95412f3c"}}}}
{"actor":{"display_login":"bbowman"}}