{"action":"created","issue":{"url":"https://api.github.com/repos/liqd/adhocracy3/issues/2380","repository_url":"https://api.github.com/repos/liqd/adhocracy3","labels_url":"https://api.github.com/repos/liqd/adhocracy3/issues/2380/labels{/name}","comments_url":"https://api.github.com/repos/liqd/adhocracy3/issues/2380/comments","events_url":"https://api.github.com/repos/liqd/adhocracy3/issues/2380/events","html_url":"https://github.com/liqd/adhocracy3/pull/2380","id":158686002,"number":2380,"title":"fix comment navigation in mercator","user":{"login":"der-john","id":16540898,"avatar_url":"https://avatars.githubusercontent.com/u/16540898?v=3","gravatar_id":"","url":"https://api.github.com/users/der-john","html_url":"https://github.com/der-john","followers_url":"https://api.github.com/users/der-john/followers","following_url":"https://api.github.com/users/der-john/following{/other_user}","gists_url":"https://api.github.com/users/der-john/gists{/gist_id}","starred_url":"https://api.github.com/users/der-john/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/der-john/subscriptions","organizations_url":"https://api.github.com/users/der-john/orgs","repos_url":"https://api.github.com/users/der-john/repos","events_url":"https://api.github.com/users/der-john/events{/privacy}","received_events_url":"https://api.github.com/users/der-john/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/liqd/adhocracy3/labels/bug","name":"bug","color":"c52020"},{"url":"https://api.github.com/repos/liqd/adhocracy3/labels/frontend","name":"frontend","color":"bfd4f2"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-06-06T14:04:51Z","updated_at":"2016-06-06T14:57:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/liqd/adhocracy3/pulls/2380","html_url":"https://github.com/liqd/adhocracy3/pull/2380","diff_url":"https://github.com/liqd/adhocracy3/pull/2380.diff","patch_url":"https://github.com/liqd/adhocracy3/pull/2380.patch"},"body":"This fixes #2205 in a surprisingly indirect way.\r\n\r\n`AdhListing` didn't use, nor watch, the `refersTo` value of comments. This value is crucial in Mercator, since all comments on (any parts of) a proposal are stored in one `pool`, but their `refersTo` values indicate which subresource they belong to.\r\n\r\n(When you first loaded a given subresource comment view, this wan't a problem:\r\nIn `src/mercator/mercator/static/js/Packages/Mercator/2016/Workbench/Workbench.ts`, in `registerRoutes.specific` assigned this same subresource as `commentableUrl`. But `registerRoutes` is not executed in the case of #2205.)"},"comment":{"url":"https://api.github.com/repos/liqd/adhocracy3/issues/comments/223984677","html_url":"https://github.com/liqd/adhocracy3/pull/2380#issuecomment-223984677","issue_url":"https://api.github.com/repos/liqd/adhocracy3/issues/2380","id":223984677,"user":{"login":"xi","id":202576,"avatar_url":"https://avatars.githubusercontent.com/u/202576?v=3","gravatar_id":"","url":"https://api.github.com/users/xi","html_url":"https://github.com/xi","followers_url":"https://api.github.com/users/xi/followers","following_url":"https://api.github.com/users/xi/following{/other_user}","gists_url":"https://api.github.com/users/xi/gists{/gist_id}","starred_url":"https://api.github.com/users/xi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xi/subscriptions","organizations_url":"https://api.github.com/users/xi/orgs","repos_url":"https://api.github.com/users/xi/repos","events_url":"https://api.github.com/users/xi/events{/privacy}","received_events_url":"https://api.github.com/users/xi/received_events","type":"User","site_admin":false},"created_at":"2016-06-06T14:57:33Z","updated_at":"2016-06-06T14:57:33Z","body":"> `AdhListing` didn't use, nor watch, the `refersTo` value of comments\r\n\r\nThat is not completely right. `refersTo` is passed to the listing via the `params` parameter in [Comment.ts:103](https://github.com/liqd/adhocracy3/blob/a9f5f17/src/adhocracy_frontend/adhocracy_frontend/static/js/Packages/Comment/Comment.ts#L103). We should really not add comment-specific code to the listing. I guess this can be fixed by also watching `params`."}}
{"actor":{"display_login":"xi"}}