{"action":"created","issue":{"url":"https://api.github.com/repos/palantir/http-remoting/issues/115","repository_url":"https://api.github.com/repos/palantir/http-remoting","labels_url":"https://api.github.com/repos/palantir/http-remoting/issues/115/labels{/name}","comments_url":"https://api.github.com/repos/palantir/http-remoting/issues/115/comments","events_url":"https://api.github.com/repos/palantir/http-remoting/issues/115/events","html_url":"https://github.com/palantir/http-remoting/pull/115","id":152605533,"number":115,"title":"Add call tracing","user":{"login":"markelliot","id":685891,"avatar_url":"https://avatars.githubusercontent.com/u/685891?v=3","gravatar_id":"","url":"https://api.github.com/users/markelliot","html_url":"https://github.com/markelliot","followers_url":"https://api.github.com/users/markelliot/followers","following_url":"https://api.github.com/users/markelliot/following{/other_user}","gists_url":"https://api.github.com/users/markelliot/gists{/gist_id}","starred_url":"https://api.github.com/users/markelliot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markelliot/subscriptions","organizations_url":"https://api.github.com/users/markelliot/orgs","repos_url":"https://api.github.com/users/markelliot/repos","events_url":"https://api.github.com/users/markelliot/events{/privacy}","received_events_url":"https://api.github.com/users/markelliot/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"uschi2000","id":6528449,"avatar_url":"https://avatars.githubusercontent.com/u/6528449?v=3","gravatar_id":"","url":"https://api.github.com/users/uschi2000","html_url":"https://github.com/uschi2000","followers_url":"https://api.github.com/users/uschi2000/followers","following_url":"https://api.github.com/users/uschi2000/following{/other_user}","gists_url":"https://api.github.com/users/uschi2000/gists{/gist_id}","starred_url":"https://api.github.com/users/uschi2000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uschi2000/subscriptions","organizations_url":"https://api.github.com/users/uschi2000/orgs","repos_url":"https://api.github.com/users/uschi2000/repos","events_url":"https://api.github.com/users/uschi2000/events{/privacy}","received_events_url":"https://api.github.com/users/uschi2000/received_events","type":"User","site_admin":false},"milestone":null,"comments":21,"created_at":"2016-05-02T17:52:30Z","updated_at":"2016-06-02T14:45:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/palantir/http-remoting/pulls/115","html_url":"https://github.com/palantir/http-remoting/pull/115","diff_url":"https://github.com/palantir/http-remoting/pull/115.diff","patch_url":"https://github.com/palantir/http-remoting/pull/115.patch"},"body":"All remoting calls will now emit standard Zipkin-style tracing headers for traceId and spanId.\r\n\r\nAdditionally, applications including the tracing library can start and stop traces\r\ninside the application using `Traces.deriveTrace(String)` and a completion call\r\nto emit a span `Traces.complete()`. (Traces must happen within a single\r\nthread, work dispatched to executors may not track correctly given current\r\nimplementation details.)\r\n\r\nServers can interpret, load, and will automatically continue passing\r\nthe same trace identifier by installing the `TraceInheritingFilter`\r\nJersey resource. Calls that did not include a trace will emit an identified trace\r\nas a result of installing the filter."},"comment":{"url":"https://api.github.com/repos/palantir/http-remoting/issues/comments/223314324","html_url":"https://github.com/palantir/http-remoting/pull/115#issuecomment-223314324","issue_url":"https://api.github.com/repos/palantir/http-remoting/issues/115","id":223314324,"user":{"login":"uschi2000","id":6528449,"avatar_url":"https://avatars.githubusercontent.com/u/6528449?v=3","gravatar_id":"","url":"https://api.github.com/users/uschi2000","html_url":"https://github.com/uschi2000","followers_url":"https://api.github.com/users/uschi2000/followers","following_url":"https://api.github.com/users/uschi2000/following{/other_user}","gists_url":"https://api.github.com/users/uschi2000/gists{/gist_id}","starred_url":"https://api.github.com/users/uschi2000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uschi2000/subscriptions","organizations_url":"https://api.github.com/users/uschi2000/orgs","repos_url":"https://api.github.com/users/uschi2000/repos","events_url":"https://api.github.com/users/uschi2000/events{/privacy}","received_events_url":"https://api.github.com/users/uschi2000/received_events","type":"User","site_admin":false},"created_at":"2016-06-02T14:45:33Z","updated_at":"2016-06-02T14:45:33Z","body":"Generally, the Brave code-base looks very solid (and has no external\ndependencies), so I think we should consider it, even if it's currently\nlacking that feature. (We could always push for adding it there.)\n\nOn Thu, Jun 2, 2016 at 4:43 PM Robert Fink <rf@robertfink.de> wrote:\n\n> Haven't dug in enough detail to answer this either, sorry.\n>\n> On Thu, Jun 2, 2016 at 4:07 PM Mark Elliot <notifications@github.com>\n> wrote:\n>\n>> Maybe I'm misreading the code, but that doesn't seem to allow nesting of\n>> recorded local spans?\n>>\n>> —\n>> You are receiving this because you were mentioned.\n>> Reply to this email directly, view it on GitHub\n>> <https://github.com/palantir/http-remoting/pull/115#issuecomment-223302373>,\n>> or mute the thread\n>> <https://github.com/notifications/unsubscribe/AGOdwSVk2zaaxSvkY6kZ-L-_Z429tYOPks5qHuOMgaJpZM4IVjpL>\n>> .\n>>\n>\n"}}
{"actor":{"display_login":"uschi2000"}}