{"action":"created","issue":{"url":"https://api.github.com/repos/mkucej/i-librarian/issues/3","labels_url":"https://api.github.com/repos/mkucej/i-librarian/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/mkucej/i-librarian/issues/3/comments","events_url":"https://api.github.com/repos/mkucej/i-librarian/issues/3/events","html_url":"https://github.com/mkucej/i-librarian/pull/3","id":49907220,"number":3,"title":"LDAP Improvements","user":{"login":"robodendron","id":6247004,"avatar_url":"https://avatars.githubusercontent.com/u/6247004?v=3","gravatar_id":"","url":"https://api.github.com/users/robodendron","html_url":"https://github.com/robodendron","followers_url":"https://api.github.com/users/robodendron/followers","following_url":"https://api.github.com/users/robodendron/following{/other_user}","gists_url":"https://api.github.com/users/robodendron/gists{/gist_id}","starred_url":"https://api.github.com/users/robodendron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robodendron/subscriptions","organizations_url":"https://api.github.com/users/robodendron/orgs","repos_url":"https://api.github.com/users/robodendron/repos","events_url":"https://api.github.com/users/robodendron/events{/privacy}","received_events_url":"https://api.github.com/users/robodendron/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2014-11-24T16:06:01Z","updated_at":"2016-01-08T22:11:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mkucej/i-librarian/pulls/3","html_url":"https://github.com/mkucej/i-librarian/pull/3","diff_url":"https://github.com/mkucej/i-librarian/pull/3.diff","patch_url":"https://github.com/mkucej/i-librarian/pull/3.patch"},"body":"This PR refactors the LDAP authentication mechanism. The new implementation was tested with both the test LDAP server at ldap.testathon.net and our local Active Directory LDAP server at MLU Halle-Wittenberg.\r\n\r\nThe new implementation provides the following benefits:\r\n\r\n- It uses a proxy user to do username and DN lookups. The previous implementation did not allow for users in nested OUs to log in. (Anonymous LDAP binds should work as well, just leave `ldap_binduser_rdn` and `ldap_binduser_pw` as empty strings for now.)\r\n- It (optionally) allows to restrict logins to members of an LDAP group. If recursive membership checking is needed, this can be done with a custom `ldap_filter` setting, an example of which is provided in `ilibrarian.ini`.\r\n\r\nThere is also one disadvantage I can see:\r\n- For now, the bind user DN and password are stored as plaintext in `ilibrarian.ini`. Therefore, the example webserver configuration in `README.txt` has been updated to deny access to this file by default. **If this PR is merged in, the documentation on the homepage should also be updated accordingly.**\r\n\r\nThings I would like to address in the future:\r\n- Commenting out `ldap_binduser_rdn` and/or `ldap_binduser_pw` should perform the correct form of anonymous bind to LDAP implementations that support it.\r\n- Address I, Librarian's behavior where the first user to populate the database is always given admin permissions, even if she is not a member of the I, Librarian LDAP admin group.\r\n\r\nIf there are any things I should change or improve, just say so. Cheers! :)"},"comment":{"url":"https://api.github.com/repos/mkucej/i-librarian/issues/comments/170142125","html_url":"https://github.com/mkucej/i-librarian/pull/3#issuecomment-170142125","issue_url":"https://api.github.com/repos/mkucej/i-librarian/issues/3","id":170142125,"user":{"login":"mkucej","id":4523894,"avatar_url":"https://avatars.githubusercontent.com/u/4523894?v=3","gravatar_id":"","url":"https://api.github.com/users/mkucej","html_url":"https://github.com/mkucej","followers_url":"https://api.github.com/users/mkucej/followers","following_url":"https://api.github.com/users/mkucej/following{/other_user}","gists_url":"https://api.github.com/users/mkucej/gists{/gist_id}","starred_url":"https://api.github.com/users/mkucej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkucej/subscriptions","organizations_url":"https://api.github.com/users/mkucej/orgs","repos_url":"https://api.github.com/users/mkucej/repos","events_url":"https://api.github.com/users/mkucej/events{/privacy}","received_events_url":"https://api.github.com/users/mkucej/received_events","type":"User","site_admin":false},"created_at":"2016-01-08T22:11:33Z","updated_at":"2016-01-08T22:11:33Z","body":"I pushed the `develop` branch. I would not recommend to run it on your library. It is not stable yet."}}