{"action":"created","issue":{"url":"https://api.github.com/repos/mhallsmoore/qstrader/issues/102","repository_url":"https://api.github.com/repos/mhallsmoore/qstrader","labels_url":"https://api.github.com/repos/mhallsmoore/qstrader/issues/102/labels{/name}","comments_url":"https://api.github.com/repos/mhallsmoore/qstrader/issues/102/comments","events_url":"https://api.github.com/repos/mhallsmoore/qstrader/issues/102/events","html_url":"https://github.com/mhallsmoore/qstrader/issues/102","id":167172358,"number":102,"title":"System Design","user":{"login":"ryankennedyio","id":11158006,"avatar_url":"https://avatars.githubusercontent.com/u/11158006?v=3","gravatar_id":"","url":"https://api.github.com/users/ryankennedyio","html_url":"https://github.com/ryankennedyio","followers_url":"https://api.github.com/users/ryankennedyio/followers","following_url":"https://api.github.com/users/ryankennedyio/following{/other_user}","gists_url":"https://api.github.com/users/ryankennedyio/gists{/gist_id}","starred_url":"https://api.github.com/users/ryankennedyio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryankennedyio/subscriptions","organizations_url":"https://api.github.com/users/ryankennedyio/orgs","repos_url":"https://api.github.com/users/ryankennedyio/repos","events_url":"https://api.github.com/users/ryankennedyio/events{/privacy}","received_events_url":"https://api.github.com/users/ryankennedyio/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-07-23T07:18:18Z","updated_at":"2016-07-23T19:52:44Z","closed_at":null,"body":"A few thoughts today to have come out from this. This can get locked down as we move closer to a Beta version with proper documentation, etc. Main thing would just be that we want clean & lean interfaces. \r\n\r\n(used draw.io -- simple XML (import & export)[https://raw.githubusercontent.com/ryankennedyio/qstrader/sys-diagrams/system-design.xml])\r\n\r\n![qstrader](https://cloud.githubusercontent.com/assets/11158006/17076413/150e09aa-50f0-11e6-9c66-794d254600f6.png)\r\n\r\nStatistics should have a link to PriceParser, but actually PriceParser needlessly adds things to this diagram. Also the direction of some arrows is currently incorrect (e.g. Statistics pulls from PortfolioHandler, but PortfolioHandler can't push to Statistics)\r\n\r\nJust visually, PortfolioHandler and Backtest share a lot of the same moving parts (Strategy, PositionSizer, RiskManager, Statistics, PriceHandler). This is pretty necessary though. Should help a bit with seeing how we can tackle #91 correctly.\r\n"},"comment":{"url":"https://api.github.com/repos/mhallsmoore/qstrader/issues/comments/234736809","html_url":"https://github.com/mhallsmoore/qstrader/issues/102#issuecomment-234736809","issue_url":"https://api.github.com/repos/mhallsmoore/qstrader/issues/102","id":234736809,"user":{"login":"muke5hy","id":545172,"avatar_url":"https://avatars.githubusercontent.com/u/545172?v=3","gravatar_id":"","url":"https://api.github.com/users/muke5hy","html_url":"https://github.com/muke5hy","followers_url":"https://api.github.com/users/muke5hy/followers","following_url":"https://api.github.com/users/muke5hy/following{/other_user}","gists_url":"https://api.github.com/users/muke5hy/gists{/gist_id}","starred_url":"https://api.github.com/users/muke5hy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muke5hy/subscriptions","organizations_url":"https://api.github.com/users/muke5hy/orgs","repos_url":"https://api.github.com/users/muke5hy/repos","events_url":"https://api.github.com/users/muke5hy/events{/privacy}","received_events_url":"https://api.github.com/users/muke5hy/received_events","type":"User","site_admin":false},"created_at":"2016-07-23T19:52:44Z","updated_at":"2016-07-23T19:52:44Z","body":"@femtotrader your implementation seems logical. Can we have this in QsTrader ? @ryankennedyio What's your point in this? "}}
{"actor":{"display_login":"muke5hy"}}