{"action":"created","comment":{"url":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/comments/94263632","pull_request_review_id":14794926,"id":94263632,"diff_hunk":"@@ -0,0 +1,139 @@\n+defmodule Thrift.Generator.Server do\n+  @moduledoc false\n+\n+  defmodule Framed do\n+    alias Thrift.Generator.{\n+      Service,\n+      Utils\n+    }\n+    alias Thrift.Parser.FileGroup\n+    alias Thrift.Parser.Models.Function\n+    alias Thrift.Servers.BinaryFramed\n+\n+    def generate(service_module, service, file_group) do\n+      functions = service.functions\n+      |> Map.values\n+      |> Enum.map(&generate_handler_function(file_group, service_module, &1))\n+\n+      quote do\n+        defmodule Server.Framed do","path":"lib/thrift/generator/server.ex","position":19,"original_position":19,"commit_id":"93e13d713243fbf681c8551946694771052ad9bd","original_commit_id":"93e13d713243fbf681c8551946694771052ad9bd","user":{"login":"pinterest-ebert","id":24738485,"avatar_url":"https://avatars.githubusercontent.com/u/24738485?v=3","gravatar_id":"","url":"https://api.github.com/users/pinterest-ebert","html_url":"https://github.com/pinterest-ebert","followers_url":"https://api.github.com/users/pinterest-ebert/followers","following_url":"https://api.github.com/users/pinterest-ebert/following{/other_user}","gists_url":"https://api.github.com/users/pinterest-ebert/gists{/gist_id}","starred_url":"https://api.github.com/users/pinterest-ebert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pinterest-ebert/subscriptions","organizations_url":"https://api.github.com/users/pinterest-ebert/orgs","repos_url":"https://api.github.com/users/pinterest-ebert/repos","events_url":"https://api.github.com/users/pinterest-ebert/events{/privacy}","received_events_url":"https://api.github.com/users/pinterest-ebert/received_events","type":"User","site_admin":false},"body":"Modules should have a @moduledoc tag.","created_at":"2016-12-30T23:09:05Z","updated_at":"2016-12-30T23:09:05Z","html_url":"https://github.com/pinterest/elixir-thrift/pull/116#discussion_r94263632","pull_request_url":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/116","_links":{"self":{"href":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/comments/94263632"},"html":{"href":"https://github.com/pinterest/elixir-thrift/pull/116#discussion_r94263632"},"pull_request":{"href":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/116"}}},"pull_request":{"url":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/116","id":99789508,"html_url":"https://github.com/pinterest/elixir-thrift/pull/116","diff_url":"https://github.com/pinterest/elixir-thrift/pull/116.diff","patch_url":"https://github.com/pinterest/elixir-thrift/pull/116.patch","issue_url":"https://api.github.com/repos/pinterest/elixir-thrift/issues/116","number":116,"state":"open","locked":false,"title":"Binary Framed server","user":{"login":"scohen","id":55809,"avatar_url":"https://avatars.githubusercontent.com/u/55809?v=3","gravatar_id":"","url":"https://api.github.com/users/scohen","html_url":"https://github.com/scohen","followers_url":"https://api.github.com/users/scohen/followers","following_url":"https://api.github.com/users/scohen/following{/other_user}","gists_url":"https://api.github.com/users/scohen/gists{/gist_id}","starred_url":"https://api.github.com/users/scohen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scohen/subscriptions","organizations_url":"https://api.github.com/users/scohen/orgs","repos_url":"https://api.github.com/users/scohen/repos","events_url":"https://api.github.com/users/scohen/events{/privacy}","received_events_url":"https://api.github.com/users/scohen/received_events","type":"User","site_admin":false},"body":"This is the implementation of the binary thrift framed server. It features\r\na configurable acceptor pool and generates code to make serialization and\r\ndeserialization automatic.\r\n\r\n@fishcakez, if you would be so kind. \r\n\r\nI'm concerned if using a supervisor of acceptor processes is good enough for a pool. ","created_at":"2016-12-30T23:08:29Z","updated_at":"2016-12-30T23:09:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"375390dbe07e407c4de6d2ea4619bb1811f5a1b2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/116/commits","review_comments_url":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/116/comments","review_comment_url":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pinterest/elixir-thrift/issues/116/comments","statuses_url":"https://api.github.com/repos/pinterest/elixir-thrift/statuses/93e13d713243fbf681c8551946694771052ad9bd","head":{"label":"scohen:framed_server","ref":"framed_server","sha":"93e13d713243fbf681c8551946694771052ad9bd","user":{"login":"scohen","id":55809,"avatar_url":"https://avatars.githubusercontent.com/u/55809?v=3","gravatar_id":"","url":"https://api.github.com/users/scohen","html_url":"https://github.com/scohen","followers_url":"https://api.github.com/users/scohen/followers","following_url":"https://api.github.com/users/scohen/following{/other_user}","gists_url":"https://api.github.com/users/scohen/gists{/gist_id}","starred_url":"https://api.github.com/users/scohen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scohen/subscriptions","organizations_url":"https://api.github.com/users/scohen/orgs","repos_url":"https://api.github.com/users/scohen/repos","events_url":"https://api.github.com/users/scohen/events{/privacy}","received_events_url":"https://api.github.com/users/scohen/received_events","type":"User","site_admin":false},"repo":{"id":49535237,"name":"elixir-thrift","full_name":"scohen/elixir-thrift","owner":{"login":"scohen","id":55809,"avatar_url":"https://avatars.githubusercontent.com/u/55809?v=3","gravatar_id":"","url":"https://api.github.com/users/scohen","html_url":"https://github.com/scohen","followers_url":"https://api.github.com/users/scohen/followers","following_url":"https://api.github.com/users/scohen/following{/other_user}","gists_url":"https://api.github.com/users/scohen/gists{/gist_id}","starred_url":"https://api.github.com/users/scohen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scohen/subscriptions","organizations_url":"https://api.github.com/users/scohen/orgs","repos_url":"https://api.github.com/users/scohen/repos","events_url":"https://api.github.com/users/scohen/events{/privacy}","received_events_url":"https://api.github.com/users/scohen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/scohen/elixir-thrift","description":"Elixir utilities for working with Thrift","fork":true,"url":"https://api.github.com/repos/scohen/elixir-thrift","forks_url":"https://api.github.com/repos/scohen/elixir-thrift/forks","keys_url":"https://api.github.com/repos/scohen/elixir-thrift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scohen/elixir-thrift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scohen/elixir-thrift/teams","hooks_url":"https://api.github.com/repos/scohen/elixir-thrift/hooks","issue_events_url":"https://api.github.com/repos/scohen/elixir-thrift/issues/events{/number}","events_url":"https://api.github.com/repos/scohen/elixir-thrift/events","assignees_url":"https://api.github.com/repos/scohen/elixir-thrift/assignees{/user}","branches_url":"https://api.github.com/repos/scohen/elixir-thrift/branches{/branch}","tags_url":"https://api.github.com/repos/scohen/elixir-thrift/tags","blobs_url":"https://api.github.com/repos/scohen/elixir-thrift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scohen/elixir-thrift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scohen/elixir-thrift/git/refs{/sha}","trees_url":"https://api.github.com/repos/scohen/elixir-thrift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scohen/elixir-thrift/statuses/{sha}","languages_url":"https://api.github.com/repos/scohen/elixir-thrift/languages","stargazers_url":"https://api.github.com/repos/scohen/elixir-thrift/stargazers","contributors_url":"https://api.github.com/repos/scohen/elixir-thrift/contributors","subscribers_url":"https://api.github.com/repos/scohen/elixir-thrift/subscribers","subscription_url":"https://api.github.com/repos/scohen/elixir-thrift/subscription","commits_url":"https://api.github.com/repos/scohen/elixir-thrift/commits{/sha}","git_commits_url":"https://api.github.com/repos/scohen/elixir-thrift/git/commits{/sha}","comments_url":"https://api.github.com/repos/scohen/elixir-thrift/comments{/number}","issue_comment_url":"https://api.github.com/repos/scohen/elixir-thrift/issues/comments{/number}","contents_url":"https://api.github.com/repos/scohen/elixir-thrift/contents/{+path}","compare_url":"https://api.github.com/repos/scohen/elixir-thrift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scohen/elixir-thrift/merges","archive_url":"https://api.github.com/repos/scohen/elixir-thrift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scohen/elixir-thrift/downloads","issues_url":"https://api.github.com/repos/scohen/elixir-thrift/issues{/number}","pulls_url":"https://api.github.com/repos/scohen/elixir-thrift/pulls{/number}","milestones_url":"https://api.github.com/repos/scohen/elixir-thrift/milestones{/number}","notifications_url":"https://api.github.com/repos/scohen/elixir-thrift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scohen/elixir-thrift/labels{/name}","releases_url":"https://api.github.com/repos/scohen/elixir-thrift/releases{/id}","deployments_url":"https://api.github.com/repos/scohen/elixir-thrift/deployments","created_at":"2016-01-12T23:17:51Z","updated_at":"2016-12-29T18:43:11Z","pushed_at":"2016-12-30T23:06:16Z","git_url":"git://github.com/scohen/elixir-thrift.git","ssh_url":"git@github.com:scohen/elixir-thrift.git","clone_url":"https://github.com/scohen/elixir-thrift.git","svn_url":"https://github.com/scohen/elixir-thrift","homepage":null,"size":277,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"pinterest:thrift_tng","ref":"thrift_tng","sha":"0517ba9485524272eaa2b220e6ba5766fdda18a7","user":{"login":"pinterest","id":541152,"avatar_url":"https://avatars.githubusercontent.com/u/541152?v=3","gravatar_id":"","url":"https://api.github.com/users/pinterest","html_url":"https://github.com/pinterest","followers_url":"https://api.github.com/users/pinterest/followers","following_url":"https://api.github.com/users/pinterest/following{/other_user}","gists_url":"https://api.github.com/users/pinterest/gists{/gist_id}","starred_url":"https://api.github.com/users/pinterest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pinterest/subscriptions","organizations_url":"https://api.github.com/users/pinterest/orgs","repos_url":"https://api.github.com/users/pinterest/repos","events_url":"https://api.github.com/users/pinterest/events{/privacy}","received_events_url":"https://api.github.com/users/pinterest/received_events","type":"Organization","site_admin":false},"repo":{"id":43914111,"name":"elixir-thrift","full_name":"pinterest/elixir-thrift","owner":{"login":"pinterest","id":541152,"avatar_url":"https://avatars.githubusercontent.com/u/541152?v=3","gravatar_id":"","url":"https://api.github.com/users/pinterest","html_url":"https://github.com/pinterest","followers_url":"https://api.github.com/users/pinterest/followers","following_url":"https://api.github.com/users/pinterest/following{/other_user}","gists_url":"https://api.github.com/users/pinterest/gists{/gist_id}","starred_url":"https://api.github.com/users/pinterest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pinterest/subscriptions","organizations_url":"https://api.github.com/users/pinterest/orgs","repos_url":"https://api.github.com/users/pinterest/repos","events_url":"https://api.github.com/users/pinterest/events{/privacy}","received_events_url":"https://api.github.com/users/pinterest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pinterest/elixir-thrift","description":"Thrift Utilities for Elixir","fork":false,"url":"https://api.github.com/repos/pinterest/elixir-thrift","forks_url":"https://api.github.com/repos/pinterest/elixir-thrift/forks","keys_url":"https://api.github.com/repos/pinterest/elixir-thrift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pinterest/elixir-thrift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pinterest/elixir-thrift/teams","hooks_url":"https://api.github.com/repos/pinterest/elixir-thrift/hooks","issue_events_url":"https://api.github.com/repos/pinterest/elixir-thrift/issues/events{/number}","events_url":"https://api.github.com/repos/pinterest/elixir-thrift/events","assignees_url":"https://api.github.com/repos/pinterest/elixir-thrift/assignees{/user}","branches_url":"https://api.github.com/repos/pinterest/elixir-thrift/branches{/branch}","tags_url":"https://api.github.com/repos/pinterest/elixir-thrift/tags","blobs_url":"https://api.github.com/repos/pinterest/elixir-thrift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pinterest/elixir-thrift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pinterest/elixir-thrift/git/refs{/sha}","trees_url":"https://api.github.com/repos/pinterest/elixir-thrift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pinterest/elixir-thrift/statuses/{sha}","languages_url":"https://api.github.com/repos/pinterest/elixir-thrift/languages","stargazers_url":"https://api.github.com/repos/pinterest/elixir-thrift/stargazers","contributors_url":"https://api.github.com/repos/pinterest/elixir-thrift/contributors","subscribers_url":"https://api.github.com/repos/pinterest/elixir-thrift/subscribers","subscription_url":"https://api.github.com/repos/pinterest/elixir-thrift/subscription","commits_url":"https://api.github.com/repos/pinterest/elixir-thrift/commits{/sha}","git_commits_url":"https://api.github.com/repos/pinterest/elixir-thrift/git/commits{/sha}","comments_url":"https://api.github.com/repos/pinterest/elixir-thrift/comments{/number}","issue_comment_url":"https://api.github.com/repos/pinterest/elixir-thrift/issues/comments{/number}","contents_url":"https://api.github.com/repos/pinterest/elixir-thrift/contents/{+path}","compare_url":"https://api.github.com/repos/pinterest/elixir-thrift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pinterest/elixir-thrift/merges","archive_url":"https://api.github.com/repos/pinterest/elixir-thrift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pinterest/elixir-thrift/downloads","issues_url":"https://api.github.com/repos/pinterest/elixir-thrift/issues{/number}","pulls_url":"https://api.github.com/repos/pinterest/elixir-thrift/pulls{/number}","milestones_url":"https://api.github.com/repos/pinterest/elixir-thrift/milestones{/number}","notifications_url":"https://api.github.com/repos/pinterest/elixir-thrift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pinterest/elixir-thrift/labels{/name}","releases_url":"https://api.github.com/repos/pinterest/elixir-thrift/releases{/id}","deployments_url":"https://api.github.com/repos/pinterest/elixir-thrift/deployments","created_at":"2015-10-08T20:17:30Z","updated_at":"2016-12-19T20:27:29Z","pushed_at":"2016-12-30T23:08:29Z","git_url":"git://github.com/pinterest/elixir-thrift.git","ssh_url":"git@github.com:pinterest/elixir-thrift.git","clone_url":"https://github.com/pinterest/elixir-thrift.git","svn_url":"https://github.com/pinterest/elixir-thrift","homepage":"https://hexdocs.pm/thrift/","size":245,"stargazers_count":36,"watchers_count":36,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":9,"forks":12,"open_issues":9,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/116"},"html":{"href":"https://github.com/pinterest/elixir-thrift/pull/116"},"issue":{"href":"https://api.github.com/repos/pinterest/elixir-thrift/issues/116"},"comments":{"href":"https://api.github.com/repos/pinterest/elixir-thrift/issues/116/comments"},"review_comments":{"href":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/116/comments"},"review_comment":{"href":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pinterest/elixir-thrift/pulls/116/commits"},"statuses":{"href":"https://api.github.com/repos/pinterest/elixir-thrift/statuses/93e13d713243fbf681c8551946694771052ad9bd"}}}}
{"actor":{"display_login":"pinterest-ebert"}}