{"action":"created","issue":{"url":"https://api.github.com/repos/AffiliateWP/AffiliateWP/issues/1470","repository_url":"https://api.github.com/repos/AffiliateWP/AffiliateWP","labels_url":"https://api.github.com/repos/AffiliateWP/AffiliateWP/issues/1470/labels{/name}","comments_url":"https://api.github.com/repos/AffiliateWP/AffiliateWP/issues/1470/comments","events_url":"https://api.github.com/repos/AffiliateWP/AffiliateWP/issues/1470/events","html_url":"https://github.com/AffiliateWP/AffiliateWP/issues/1470","id":167267365,"number":1470,"title":"Visits/cookies not being stored with fallback tracking/pretty URLs/campaigns","user":{"login":"sumobi","id":52581,"avatar_url":"https://avatars.githubusercontent.com/u/52581?v=3","gravatar_id":"","url":"https://api.github.com/users/sumobi","html_url":"https://github.com/sumobi","followers_url":"https://api.github.com/users/sumobi/followers","following_url":"https://api.github.com/users/sumobi/following{/other_user}","gists_url":"https://api.github.com/users/sumobi/gists{/gist_id}","starred_url":"https://api.github.com/users/sumobi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumobi/subscriptions","organizations_url":"https://api.github.com/users/sumobi/orgs","repos_url":"https://api.github.com/users/sumobi/repos","events_url":"https://api.github.com/users/sumobi/events{/privacy}","received_events_url":"https://api.github.com/users/sumobi/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/AffiliateWP/AffiliateWP/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/AffiliateWP/AffiliateWP/labels/Has%20PR","name":"Has PR","color":"bfe5bf"}],"state":"open","locked":false,"assignee":{"login":"sumobi","id":52581,"avatar_url":"https://avatars.githubusercontent.com/u/52581?v=3","gravatar_id":"","url":"https://api.github.com/users/sumobi","html_url":"https://github.com/sumobi","followers_url":"https://api.github.com/users/sumobi/followers","following_url":"https://api.github.com/users/sumobi/following{/other_user}","gists_url":"https://api.github.com/users/sumobi/gists{/gist_id}","starred_url":"https://api.github.com/users/sumobi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumobi/subscriptions","organizations_url":"https://api.github.com/users/sumobi/orgs","repos_url":"https://api.github.com/users/sumobi/repos","events_url":"https://api.github.com/users/sumobi/events{/privacy}","received_events_url":"https://api.github.com/users/sumobi/received_events","type":"User","site_admin":false},"assignees":[{"login":"sumobi","id":52581,"avatar_url":"https://avatars.githubusercontent.com/u/52581?v=3","gravatar_id":"","url":"https://api.github.com/users/sumobi","html_url":"https://github.com/sumobi","followers_url":"https://api.github.com/users/sumobi/followers","following_url":"https://api.github.com/users/sumobi/following{/other_user}","gists_url":"https://api.github.com/users/sumobi/gists{/gist_id}","starred_url":"https://api.github.com/users/sumobi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumobi/subscriptions","organizations_url":"https://api.github.com/users/sumobi/orgs","repos_url":"https://api.github.com/users/sumobi/repos","events_url":"https://api.github.com/users/sumobi/events{/privacy}","received_events_url":"https://api.github.com/users/sumobi/received_events","type":"User","site_admin":false},{"login":"DrewAPicture","id":995399,"avatar_url":"https://avatars.githubusercontent.com/u/995399?v=3","gravatar_id":"","url":"https://api.github.com/users/DrewAPicture","html_url":"https://github.com/DrewAPicture","followers_url":"https://api.github.com/users/DrewAPicture/followers","following_url":"https://api.github.com/users/DrewAPicture/following{/other_user}","gists_url":"https://api.github.com/users/DrewAPicture/gists{/gist_id}","starred_url":"https://api.github.com/users/DrewAPicture/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrewAPicture/subscriptions","organizations_url":"https://api.github.com/users/DrewAPicture/orgs","repos_url":"https://api.github.com/users/DrewAPicture/repos","events_url":"https://api.github.com/users/DrewAPicture/events{/privacy}","received_events_url":"https://api.github.com/users/DrewAPicture/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/AffiliateWP/AffiliateWP/milestones/45","html_url":"https://github.com/AffiliateWP/AffiliateWP/milestones/1.9","labels_url":"https://api.github.com/repos/AffiliateWP/AffiliateWP/milestones/45/labels","id":1319634,"number":45,"title":"1.9","description":"","creator":{"login":"pippinsplugins","id":1034109,"avatar_url":"https://avatars.githubusercontent.com/u/1034109?v=3","gravatar_id":"","url":"https://api.github.com/users/pippinsplugins","html_url":"https://github.com/pippinsplugins","followers_url":"https://api.github.com/users/pippinsplugins/followers","following_url":"https://api.github.com/users/pippinsplugins/following{/other_user}","gists_url":"https://api.github.com/users/pippinsplugins/gists{/gist_id}","starred_url":"https://api.github.com/users/pippinsplugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pippinsplugins/subscriptions","organizations_url":"https://api.github.com/users/pippinsplugins/orgs","repos_url":"https://api.github.com/users/pippinsplugins/repos","events_url":"https://api.github.com/users/pippinsplugins/events{/privacy}","received_events_url":"https://api.github.com/users/pippinsplugins/received_events","type":"User","site_admin":false},"open_issues":68,"closed_issues":17,"state":"open","created_at":"2015-09-23T02:20:27Z","updated_at":"2016-07-28T17:50:47Z","due_on":"2016-08-31T06:00:00Z","closed_at":null},"comments":6,"created_at":"2016-07-25T01:40:18Z","updated_at":"2016-07-28T22:22:51Z","closed_at":null,"body":"To replicate:\r\n\r\n- Master branch\r\n- Enable \"Use Fallback Referral Tracking Method?\" option in Settings -> Misc\r\n\r\n## Issue 1: \r\n\r\nPR: #1472 \r\n\r\nWhen fallback tracking is enabled & pretty affiliate URLs are used, referral links generated within the Affiliate Area that include a \"campaign\" do not work. They don't store any cookies, which means no visit stored.\r\n\r\nThe pretty URLs generated in the Affiliate Area when using a campaign look like this:\r\n\r\nhttp://mysite.com/ref/john?campaign=test\r\n\r\nHowever, this URL works (note the forward slash after john):\r\n\r\nhttp://mysite.com/ref/john/?campaign=test\r\n\r\nWith fallback tracking **disabled**, both variations work as expected:\r\n\r\nhttp://mysite.com/ref/john?campaign=test\r\nhttp://mysite.com/ref/john/?campaign=test\r\n\r\nClue:\r\n\r\nIf you turn on debugging you'll see this error log message when using the URL above that doesn't store a visit:\r\n\r\n> No user account found for given affiliate ID or login during get_fallback_affiliate_id()\r\n\r\nhttps://github.com/AffiliateWP/AffiliateWP/blob/master/includes/class-tracking.php#L440\r\n\r\n## Issue 2 (related)\r\n\r\nWhen a custom slug is used (via the Custom Affiliate Slugs add-on) with a pretty URL, and with fallback tracking enabled, visits are not being stored. \r\n\r\nE.g. http://mysite.com/ref/mycustomslug\r\n\r\nSame log message:\r\n\r\n> No user account found for given affiliate ID or login during get_fallback_affiliate_id()\r\n\r\nI suspect it's related to the same issue. Without a pretty URL, it stores a visit + cookies fine.\r\n\r\nE.g. http://mysite.com/?ref=mycustomslug\r\n\r\n@pippinsplugins @DrewAPicture Can we please give this some attention as soon as possible?"},"comment":{"url":"https://api.github.com/repos/AffiliateWP/AffiliateWP/issues/comments/236043162","html_url":"https://github.com/AffiliateWP/AffiliateWP/issues/1470#issuecomment-236043162","issue_url":"https://api.github.com/repos/AffiliateWP/AffiliateWP/issues/1470","id":236043162,"user":{"login":"sumobi","id":52581,"avatar_url":"https://avatars.githubusercontent.com/u/52581?v=3","gravatar_id":"","url":"https://api.github.com/users/sumobi","html_url":"https://github.com/sumobi","followers_url":"https://api.github.com/users/sumobi/followers","following_url":"https://api.github.com/users/sumobi/following{/other_user}","gists_url":"https://api.github.com/users/sumobi/gists{/gist_id}","starred_url":"https://api.github.com/users/sumobi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumobi/subscriptions","organizations_url":"https://api.github.com/users/sumobi/orgs","repos_url":"https://api.github.com/users/sumobi/repos","events_url":"https://api.github.com/users/sumobi/events{/privacy}","received_events_url":"https://api.github.com/users/sumobi/received_events","type":"User","site_admin":false},"created_at":"2016-07-28T22:22:51Z","updated_at":"2016-07-28T22:22:51Z","body":"@DrewAPicture Yeah, sounds like a challenge for sure 👍 \r\n\r\n>  We've seen this problem other places where visits aren't tracking (and therefore referrals not being created) because of an omitted trailing slash.\r\n\r\nIssue link? I haven't seen this before I don't think\r\n\r\nIMO it's a bit sad if we provide customers with this magical \"fallback tracking\" option because their site has JS errors, but have them discover that fallback tracking itself is crippled in some way with certain URL structures. If URLs work without fallback tracking, they should also work with fallback tracking. Hopefully we can find a way :)"}}
{"actor":{"display_login":"sumobi"}}