{"action":"created","issue":{"url":"https://api.github.com/repos/akka/akka-http/issues/325","repository_url":"https://api.github.com/repos/akka/akka-http","labels_url":"https://api.github.com/repos/akka/akka-http/issues/325/labels{/name}","comments_url":"https://api.github.com/repos/akka/akka-http/issues/325/comments","events_url":"https://api.github.com/repos/akka/akka-http/issues/325/events","html_url":"https://github.com/akka/akka-http/pull/325","id":177508718,"number":325,"title":"Add compile dependency to akka-http-testkit on scalatest","user":{"login":"richard-imaoka","id":7414320,"avatar_url":"https://avatars.githubusercontent.com/u/7414320?v=3","gravatar_id":"","url":"https://api.github.com/users/richard-imaoka","html_url":"https://github.com/richard-imaoka","followers_url":"https://api.github.com/users/richard-imaoka/followers","following_url":"https://api.github.com/users/richard-imaoka/following{/other_user}","gists_url":"https://api.github.com/users/richard-imaoka/gists{/gist_id}","starred_url":"https://api.github.com/users/richard-imaoka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richard-imaoka/subscriptions","organizations_url":"https://api.github.com/users/richard-imaoka/orgs","repos_url":"https://api.github.com/users/richard-imaoka/repos","events_url":"https://api.github.com/users/richard-imaoka/events{/privacy}","received_events_url":"https://api.github.com/users/richard-imaoka/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/akka/akka-http/labels/needs-attention","name":"needs-attention","color":"e10c02"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-16T20:03:01Z","updated_at":"2016-09-16T22:02:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/akka/akka-http/pulls/325","html_url":"https://github.com/akka/akka-http/pull/325","diff_url":"https://github.com/akka/akka-http/pull/325.diff","patch_url":"https://github.com/akka/akka-http/pull/325.patch"},"body":"For the first issue in #216. Work in progress as the second issue not fixed yet, or I can create another PR for the issue 2 later.\r\n\r\n> 1. Projects using JUnitRouteTest must declare a dependency on scalatest themselves, since it's not a declared compile dependency for akka-testkit (apparently).\r\n\r\nThis is fixed as in before/after below.\r\n\r\n#### Before \r\n\r\n```\r\n<dependency org=\"org.scalatest\" name=\"scalatest_2.11\" rev=\"3.0.0\" conf=\"provided->default(compile);test->default(compile)\"/>\r\n```\r\n    \r\n#### After\r\n    \r\n```\r\n<dependency org=\"org.scalatest\" name=\"scalatest_2.11\" rev=\"3.0.0\" conf=\"compile->default(compile)\"/>   \r\n```\r\n\r\nHowever, I didn't fix the second issue yet.\r\n\r\n> 2. All Java test classes now are marked Serializable (since Suite is), triggering compiler warnings by default.\r\n\r\n Actually I didn't see any warning in my sbt, so wondering what the warnining @jypma saw.\r\n\r\n> Is the warning for 2 = \"Serializable class without serialVersionUID\"?\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/akka/akka-http/issues/comments/247719319","html_url":"https://github.com/akka/akka-http/pull/325#issuecomment-247719319","issue_url":"https://api.github.com/repos/akka/akka-http/issues/325","id":247719319,"user":{"login":"richard-imaoka","id":7414320,"avatar_url":"https://avatars.githubusercontent.com/u/7414320?v=3","gravatar_id":"","url":"https://api.github.com/users/richard-imaoka","html_url":"https://github.com/richard-imaoka","followers_url":"https://api.github.com/users/richard-imaoka/followers","following_url":"https://api.github.com/users/richard-imaoka/following{/other_user}","gists_url":"https://api.github.com/users/richard-imaoka/gists{/gist_id}","starred_url":"https://api.github.com/users/richard-imaoka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richard-imaoka/subscriptions","organizations_url":"https://api.github.com/users/richard-imaoka/orgs","repos_url":"https://api.github.com/users/richard-imaoka/repos","events_url":"https://api.github.com/users/richard-imaoka/events{/privacy}","received_events_url":"https://api.github.com/users/richard-imaoka/received_events","type":"User","site_admin":false},"created_at":"2016-09-16T22:02:02Z","updated_at":"2016-09-16T22:02:02Z","body":"All tests passed but unsuccessfull ? :(\r\n\r\n```\r\n[info] All tests passed.\r\n[info] Passed: Total 1108, Failed 0, Errors 0, Passed 1108, Pending 38\r\n[error] (akka-http-core/test:test) sbt.TestsFailedException: Tests unsuccessful\r\n```"}}
{"actor":{"display_login":"richard-imaoka"}}