{"push_id":1187739790,"size":6,"distinct_size":6,"ref":"refs/heads/5698-sorter-total-resources-check-failure","head":"e6318eb5caafa799cc58959a7d1f900ec70475a0","before":"dfe0ff9a54cf931895feb2c7c3aa66de788a58bb","commits":[{"sha":"52d9ecda110880649b3d10d092514349f5f9a6d2","author":{"name":"Michael Park","email":"bac0ffda7d72f4343e2a300a79c430f125d5e7e6@apache.org"},"message":"Used the `char` version of `strings::startsWith` in stout.\n\nReview: https://reviews.apache.org/r/49581","distinct":true,"url":"https://api.github.com/repos/neilconway/mesos/commits/52d9ecda110880649b3d10d092514349f5f9a6d2"},{"sha":"854d8328fe7ca7cce329806147b0971a038392d3","author":{"name":"Michael Park","email":"bac0ffda7d72f4343e2a300a79c430f125d5e7e6@apache.org"},"message":"Used the `char` version of `strings::startsWith` in mesos.\n\nReview: https://reviews.apache.org/r/49582","distinct":true,"url":"https://api.github.com/repos/neilconway/mesos/commits/854d8328fe7ca7cce329806147b0971a038392d3"},{"sha":"84e95b77b086b03ed553b2916a144130bcfa66e8","author":{"name":"Neil Conway","email":"4f41ed19fc3accf446ec9111a93682686fd4d3d9@gmail.com"},"message":"Added tests that combine the two ways of creating volumes.\n\nThese tests check that dynamic reservations and persistent volumes can\nbe created via the offer API and then removed via the HTTP endpoints,\nand vice versa.\n\nReview: https://reviews.apache.org/r/49323","distinct":true,"url":"https://api.github.com/repos/neilconway/mesos/commits/84e95b77b086b03ed553b2916a144130bcfa66e8"},{"sha":"464215677e9114d8a01932cd17e5911492a7baa9","author":{"name":"Neil Conway","email":"4f41ed19fc3accf446ec9111a93682686fd4d3d9@gmail.com"},"message":"Simplified DRFSorter to not track per-slave total resources.\n\nThe DRFSorter previously kept the total resources at each slave, along\nwith the total quantity of resources in the cluster. The latter figure\nis what most of the clients of the sorter care about. In the few places\nwhere the previous coding was using the per-slave total resources, it is\nrelatively easy to adjust the code to remove this dependency.\n\nAs part of this change, remove `total()` and `update(const SlaveID&\nslaveId, const Resources& resources)` from the Sorter interface. The\nformer was unused; for the latter, code that used it can instead be\nrewritten to adjust the total resources in the cluster by first removing\nthe previous resources at a slave and then adding the new resources.\n\nReview: https://reviews.apache.org/r/49375","distinct":true,"url":"https://api.github.com/repos/neilconway/mesos/commits/464215677e9114d8a01932cd17e5911492a7baa9"},{"sha":"c88470770b783021ed00acbdd6e31986bba3b980","author":{"name":"Neil Conway","email":"4f41ed19fc3accf446ec9111a93682686fd4d3d9@gmail.com"},"message":"Added assertions to DRFSorter.\n\nReview: https://reviews.apache.org/r/49376","distinct":true,"url":"https://api.github.com/repos/neilconway/mesos/commits/c88470770b783021ed00acbdd6e31986bba3b980"},{"sha":"e6318eb5caafa799cc58959a7d1f900ec70475a0","author":{"name":"Neil Conway","email":"4f41ed19fc3accf446ec9111a93682686fd4d3d9@gmail.com"},"message":"Fixed allocator to update total resources in quota sorter.\n\nEach DRFSorter tracks the total resources in the cluster. This means\nthat each sorter must be updated when the resources in the cluster have\nchanged, e.g., due to the creation of a dynamic reservation or a\npersistent volume. In the previous implementation, the quota role sorter\nwas not updated for non-quota roles when a reservation or persistent\nvolume was created by a framework. This resulted in inconsistency\nbetween the total resources in the allocator and the quota role sorter.\n\nThis could cause several problems. First, removing a slave from the\ncluster would leak resources in the quota role sorter. Second, certain\ninterleavings of slave removals and reserve/unreserve operations by\nframeworks and via HTTP endpoints could lead to CHECK failures.\n\nReview: https://reviews.apache.org/r/49377","distinct":true,"url":"https://api.github.com/repos/neilconway/mesos/commits/e6318eb5caafa799cc58959a7d1f900ec70475a0"}]}
{"actor":{"display_login":"neilconway"}}