{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/71217282","id":71217282,"diff_hunk":"@@ -145,12 +145,12 @@ def self.generate_attribute_hash(input_hash)\n       attribute_hash[:password] = '*'\n     else\n       embedded_binary_plist = get_embedded_binary_plist(attribute_hash[:shadowhashdata])\n-      if embedded_binary_plist['SALTED-SHA512']\n-        attribute_hash[:password] = get_salted_sha512(embedded_binary_plist)\n-      else\n+      if embedded_binary_plist['SALTED-SHA512-PBKDF2']","path":"lib/puppet/provider/user/directoryservice.rb","position":16,"original_position":16,"commit_id":"b547b29a89ce74b90c5e2a6fdb6af906d82484ae","original_commit_id":"b547b29a89ce74b90c5e2a6fdb6af906d82484ae","user":{"login":"adrienthebo","id":172194,"avatar_url":"https://avatars.githubusercontent.com/u/172194?v=3","gravatar_id":"","url":"https://api.github.com/users/adrienthebo","html_url":"https://github.com/adrienthebo","followers_url":"https://api.github.com/users/adrienthebo/followers","following_url":"https://api.github.com/users/adrienthebo/following{/other_user}","gists_url":"https://api.github.com/users/adrienthebo/gists{/gist_id}","starred_url":"https://api.github.com/users/adrienthebo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrienthebo/subscriptions","organizations_url":"https://api.github.com/users/adrienthebo/orgs","repos_url":"https://api.github.com/users/adrienthebo/repos","events_url":"https://api.github.com/users/adrienthebo/events{/privacy}","received_events_url":"https://api.github.com/users/adrienthebo/received_events","type":"User","site_admin":false},"body":"It seems like this diff here just reorders the conditionals, why was this done?","created_at":"2016-07-18T19:56:44Z","updated_at":"2016-07-18T19:56:44Z","html_url":"https://github.com/puppetlabs/puppet/pull/5119#discussion_r71217282","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/5119","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/71217282"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/5119#discussion_r71217282"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/5119"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/5119","id":77367498,"html_url":"https://github.com/puppetlabs/puppet/pull/5119","diff_url":"https://github.com/puppetlabs/puppet/pull/5119.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/5119.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/5119","number":5119,"state":"open","locked":false,"title":"(PUP-6502) Use some memoization to stop calling dscl pathologically","user":{"login":"ccaviness","id":378350,"avatar_url":"https://avatars.githubusercontent.com/u/378350?v=3","gravatar_id":"","url":"https://api.github.com/users/ccaviness","html_url":"https://github.com/ccaviness","followers_url":"https://api.github.com/users/ccaviness/followers","following_url":"https://api.github.com/users/ccaviness/following{/other_user}","gists_url":"https://api.github.com/users/ccaviness/gists{/gist_id}","starred_url":"https://api.github.com/users/ccaviness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccaviness/subscriptions","organizations_url":"https://api.github.com/users/ccaviness/orgs","repos_url":"https://api.github.com/users/ccaviness/repos","events_url":"https://api.github.com/users/ccaviness/events{/privacy}","received_events_url":"https://api.github.com/users/ccaviness/received_events","type":"User","site_admin":false},"body":"We get all the data we need from the initial `dscl -readall /Users`; there's no need to specifically go through each user to ask for `ShadowHashData` later on.","created_at":"2016-07-13T21:46:57Z","updated_at":"2016-07-18T19:56:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d7160d4da1c9bf42218852a7ff98be6b19bf578","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/5119/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/5119/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/5119/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/b547b29a89ce74b90c5e2a6fdb6af906d82484ae","head":{"label":"ccaviness:dscl","ref":"dscl","sha":"b547b29a89ce74b90c5e2a6fdb6af906d82484ae","user":{"login":"ccaviness","id":378350,"avatar_url":"https://avatars.githubusercontent.com/u/378350?v=3","gravatar_id":"","url":"https://api.github.com/users/ccaviness","html_url":"https://github.com/ccaviness","followers_url":"https://api.github.com/users/ccaviness/followers","following_url":"https://api.github.com/users/ccaviness/following{/other_user}","gists_url":"https://api.github.com/users/ccaviness/gists{/gist_id}","starred_url":"https://api.github.com/users/ccaviness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccaviness/subscriptions","organizations_url":"https://api.github.com/users/ccaviness/orgs","repos_url":"https://api.github.com/users/ccaviness/repos","events_url":"https://api.github.com/users/ccaviness/events{/privacy}","received_events_url":"https://api.github.com/users/ccaviness/received_events","type":"User","site_admin":false},"repo":{"id":10845730,"name":"puppet","full_name":"ccaviness/puppet","owner":{"login":"ccaviness","id":378350,"avatar_url":"https://avatars.githubusercontent.com/u/378350?v=3","gravatar_id":"","url":"https://api.github.com/users/ccaviness","html_url":"https://github.com/ccaviness","followers_url":"https://api.github.com/users/ccaviness/followers","following_url":"https://api.github.com/users/ccaviness/following{/other_user}","gists_url":"https://api.github.com/users/ccaviness/gists{/gist_id}","starred_url":"https://api.github.com/users/ccaviness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccaviness/subscriptions","organizations_url":"https://api.github.com/users/ccaviness/orgs","repos_url":"https://api.github.com/users/ccaviness/repos","events_url":"https://api.github.com/users/ccaviness/events{/privacy}","received_events_url":"https://api.github.com/users/ccaviness/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ccaviness/puppet","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/ccaviness/puppet","forks_url":"https://api.github.com/repos/ccaviness/puppet/forks","keys_url":"https://api.github.com/repos/ccaviness/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ccaviness/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ccaviness/puppet/teams","hooks_url":"https://api.github.com/repos/ccaviness/puppet/hooks","issue_events_url":"https://api.github.com/repos/ccaviness/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/ccaviness/puppet/events","assignees_url":"https://api.github.com/repos/ccaviness/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/ccaviness/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/ccaviness/puppet/tags","blobs_url":"https://api.github.com/repos/ccaviness/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ccaviness/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ccaviness/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/ccaviness/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ccaviness/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/ccaviness/puppet/languages","stargazers_url":"https://api.github.com/repos/ccaviness/puppet/stargazers","contributors_url":"https://api.github.com/repos/ccaviness/puppet/contributors","subscribers_url":"https://api.github.com/repos/ccaviness/puppet/subscribers","subscription_url":"https://api.github.com/repos/ccaviness/puppet/subscription","commits_url":"https://api.github.com/repos/ccaviness/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/ccaviness/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/ccaviness/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/ccaviness/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/ccaviness/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/ccaviness/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ccaviness/puppet/merges","archive_url":"https://api.github.com/repos/ccaviness/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ccaviness/puppet/downloads","issues_url":"https://api.github.com/repos/ccaviness/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/ccaviness/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/ccaviness/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/ccaviness/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ccaviness/puppet/labels{/name}","releases_url":"https://api.github.com/repos/ccaviness/puppet/releases{/id}","deployments_url":"https://api.github.com/repos/ccaviness/puppet/deployments","created_at":"2013-06-21T15:38:06Z","updated_at":"2015-09-11T19:13:06Z","pushed_at":"2016-07-15T16:35:12Z","git_url":"git://github.com/ccaviness/puppet.git","ssh_url":"git@github.com:ccaviness/puppet.git","clone_url":"https://github.com/ccaviness/puppet.git","svn_url":"https://github.com/ccaviness/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":52801,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"6da96e1aed15ab16fec4ac9b22108ae6c79bbdad","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910744,"name":"puppet","full_name":"puppetlabs/puppet","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet","forks_url":"https://api.github.com/repos/puppetlabs/puppet/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppet/deployments","created_at":"2010-09-14T19:26:44Z","updated_at":"2016-07-18T14:53:35Z","pushed_at":"2016-07-18T16:54:48Z","git_url":"git://github.com/puppetlabs/puppet.git","ssh_url":"git@github.com:puppetlabs/puppet.git","clone_url":"https://github.com/puppetlabs/puppet.git","svn_url":"https://github.com/puppetlabs/puppet","homepage":"https://puppet.com/puppet/what-is-puppet","size":82108,"stargazers_count":4052,"watchers_count":4052,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1685,"mirror_url":null,"open_issues_count":50,"forks":1685,"open_issues":50,"watchers":4052,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/5119"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/5119"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/5119"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/5119/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/5119/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/5119/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet/statuses/b547b29a89ce74b90c5e2a6fdb6af906d82484ae"}}}}
{"actor":{"display_login":"adrienthebo"}}