{"action":"created","comment":{"url":"https://api.github.com/repos/rexim/Morganey/pulls/comments/76043791","id":76043791,"diff_hunk":"@@ -134,23 +124,16 @@ private[meta] class QuotationMacro(val c: Context) {\n         (q\"_root_.scala.Some((..$ys))\", q\"_root_.scala.None\")\n     }\n \n-    if (!hasSubpatterns() && ps.size == 1) {\n-      q\"\"\"\n-        new {\n-          def unapply(input: $LambdaTermTpe) = Option(input)\n-        }.unapply(..$args)\n-      \"\"\"\n-    } else {\n-      q\"\"\"\n-        new {\n-          def unapply(input: $LambdaTermTpe) = input match {\n-            case $term => $ifp\n-            case _     => $elp\n-          }\n-        }.unapply(..$args)\n-      \"\"\"\n-    }\n-\n+    val identName = TermName(c.freshName())\n+    q\"\"\"\n+      new {\n+        val $identName = true","path":"macros/src/main/scala/me/rexim/morganey/meta/QuotationMacro.scala","position":41,"original_position":41,"commit_id":"01059b389e64f29e12450544a79c6123f77841bd","original_commit_id":"01059b389e64f29e12450544a79c6123f77841bd","user":{"login":"rexim","id":165283,"avatar_url":"https://avatars.githubusercontent.com/u/165283?v=3","gravatar_id":"","url":"https://api.github.com/users/rexim","html_url":"https://github.com/rexim","followers_url":"https://api.github.com/users/rexim/followers","following_url":"https://api.github.com/users/rexim/following{/other_user}","gists_url":"https://api.github.com/users/rexim/gists{/gist_id}","starred_url":"https://api.github.com/users/rexim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rexim/subscriptions","organizations_url":"https://api.github.com/users/rexim/orgs","repos_url":"https://api.github.com/users/rexim/repos","events_url":"https://api.github.com/users/rexim/events{/privacy}","received_events_url":"https://api.github.com/users/rexim/received_events","type":"User","site_admin":false},"body":"I remove that and the tests show the warning:\r\n```\r\n[warn] /home/rexim/Programming/rexim/Morganey/macros/src/test/scala/me/rexim/morganey/meta/InterpolatorSpec.scala:70: patterns after a variable pattern cannot match (SLS 8.1.1)\r\n[warn]     val m\"$wholeApp\" = m\"b c d\"\r\n[warn]         ^\r\n[warn] /home/rexim/Programming/rexim/Morganey/macros/src/test/scala/me/rexim/morganey/meta/InterpolatorSpec.scala:84: patterns after a variable pattern cannot match (SLS 8.1.1)\r\n[warn]     val m\"$wholeApp\" = m\"\\\\b.b\"\r\n[warn]         ^\r\n[warn] two warnings found\r\n```","created_at":"2016-08-24T12:06:25Z","updated_at":"2016-08-24T12:06:25Z","html_url":"https://github.com/rexim/Morganey/pull/141#discussion_r76043791","pull_request_url":"https://api.github.com/repos/rexim/Morganey/pulls/141","_links":{"self":{"href":"https://api.github.com/repos/rexim/Morganey/pulls/comments/76043791"},"html":{"href":"https://github.com/rexim/Morganey/pull/141#discussion_r76043791"},"pull_request":{"href":"https://api.github.com/repos/rexim/Morganey/pulls/141"}}},"pull_request":{"url":"https://api.github.com/repos/rexim/Morganey/pulls/141","id":82416113,"html_url":"https://github.com/rexim/Morganey/pull/141","diff_url":"https://github.com/rexim/Morganey/pull/141.diff","patch_url":"https://github.com/rexim/Morganey/pull/141.patch","issue_url":"https://api.github.com/repos/rexim/Morganey/issues/141","number":141,"state":"open","locked":false,"title":"Fix unexpected behavior in unquotation macro","user":{"login":"keddelzz","id":3746739,"avatar_url":"https://avatars.githubusercontent.com/u/3746739?v=3","gravatar_id":"","url":"https://api.github.com/users/keddelzz","html_url":"https://github.com/keddelzz","followers_url":"https://api.github.com/users/keddelzz/followers","following_url":"https://api.github.com/users/keddelzz/following{/other_user}","gists_url":"https://api.github.com/users/keddelzz/gists{/gist_id}","starred_url":"https://api.github.com/users/keddelzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keddelzz/subscriptions","organizations_url":"https://api.github.com/users/keddelzz/orgs","repos_url":"https://api.github.com/users/keddelzz/repos","events_url":"https://api.github.com/users/keddelzz/events{/privacy}","received_events_url":"https://api.github.com/users/keddelzz/received_events","type":"User","site_admin":false},"body":"A pattern of one variable won't match the whole term anymore. Instead it will match the correct subtree. \r\ncloses #127\r\n","created_at":"2016-08-23T18:26:11Z","updated_at":"2016-08-24T12:06:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f3ab9fa7ddf234ec479b087dde5f690250ed0a0","assignee":{"login":"ForNeVeR","id":92793,"avatar_url":"https://avatars.githubusercontent.com/u/92793?v=3","gravatar_id":"","url":"https://api.github.com/users/ForNeVeR","html_url":"https://github.com/ForNeVeR","followers_url":"https://api.github.com/users/ForNeVeR/followers","following_url":"https://api.github.com/users/ForNeVeR/following{/other_user}","gists_url":"https://api.github.com/users/ForNeVeR/gists{/gist_id}","starred_url":"https://api.github.com/users/ForNeVeR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ForNeVeR/subscriptions","organizations_url":"https://api.github.com/users/ForNeVeR/orgs","repos_url":"https://api.github.com/users/ForNeVeR/repos","events_url":"https://api.github.com/users/ForNeVeR/events{/privacy}","received_events_url":"https://api.github.com/users/ForNeVeR/received_events","type":"User","site_admin":false},"assignees":[{"login":"ForNeVeR","id":92793,"avatar_url":"https://avatars.githubusercontent.com/u/92793?v=3","gravatar_id":"","url":"https://api.github.com/users/ForNeVeR","html_url":"https://github.com/ForNeVeR","followers_url":"https://api.github.com/users/ForNeVeR/followers","following_url":"https://api.github.com/users/ForNeVeR/following{/other_user}","gists_url":"https://api.github.com/users/ForNeVeR/gists{/gist_id}","starred_url":"https://api.github.com/users/ForNeVeR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ForNeVeR/subscriptions","organizations_url":"https://api.github.com/users/ForNeVeR/orgs","repos_url":"https://api.github.com/users/ForNeVeR/repos","events_url":"https://api.github.com/users/ForNeVeR/events{/privacy}","received_events_url":"https://api.github.com/users/ForNeVeR/received_events","type":"User","site_admin":false},{"login":"rexim","id":165283,"avatar_url":"https://avatars.githubusercontent.com/u/165283?v=3","gravatar_id":"","url":"https://api.github.com/users/rexim","html_url":"https://github.com/rexim","followers_url":"https://api.github.com/users/rexim/followers","following_url":"https://api.github.com/users/rexim/following{/other_user}","gists_url":"https://api.github.com/users/rexim/gists{/gist_id}","starred_url":"https://api.github.com/users/rexim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rexim/subscriptions","organizations_url":"https://api.github.com/users/rexim/orgs","repos_url":"https://api.github.com/users/rexim/repos","events_url":"https://api.github.com/users/rexim/events{/privacy}","received_events_url":"https://api.github.com/users/rexim/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rexim/Morganey/pulls/141/commits","review_comments_url":"https://api.github.com/repos/rexim/Morganey/pulls/141/comments","review_comment_url":"https://api.github.com/repos/rexim/Morganey/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rexim/Morganey/issues/141/comments","statuses_url":"https://api.github.com/repos/rexim/Morganey/statuses/01059b389e64f29e12450544a79c6123f77841bd","head":{"label":"rexim:127-bug-unquotation-macro","ref":"127-bug-unquotation-macro","sha":"01059b389e64f29e12450544a79c6123f77841bd","user":{"login":"rexim","id":165283,"avatar_url":"https://avatars.githubusercontent.com/u/165283?v=3","gravatar_id":"","url":"https://api.github.com/users/rexim","html_url":"https://github.com/rexim","followers_url":"https://api.github.com/users/rexim/followers","following_url":"https://api.github.com/users/rexim/following{/other_user}","gists_url":"https://api.github.com/users/rexim/gists{/gist_id}","starred_url":"https://api.github.com/users/rexim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rexim/subscriptions","organizations_url":"https://api.github.com/users/rexim/orgs","repos_url":"https://api.github.com/users/rexim/repos","events_url":"https://api.github.com/users/rexim/events{/privacy}","received_events_url":"https://api.github.com/users/rexim/received_events","type":"User","site_admin":false},"repo":{"id":47073664,"name":"Morganey","full_name":"rexim/Morganey","owner":{"login":"rexim","id":165283,"avatar_url":"https://avatars.githubusercontent.com/u/165283?v=3","gravatar_id":"","url":"https://api.github.com/users/rexim","html_url":"https://github.com/rexim","followers_url":"https://api.github.com/users/rexim/followers","following_url":"https://api.github.com/users/rexim/following{/other_user}","gists_url":"https://api.github.com/users/rexim/gists{/gist_id}","starred_url":"https://api.github.com/users/rexim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rexim/subscriptions","organizations_url":"https://api.github.com/users/rexim/orgs","repos_url":"https://api.github.com/users/rexim/repos","events_url":"https://api.github.com/users/rexim/events{/privacy}","received_events_url":"https://api.github.com/users/rexim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rexim/Morganey","description":"Lambda Calculus based programming language","fork":false,"url":"https://api.github.com/repos/rexim/Morganey","forks_url":"https://api.github.com/repos/rexim/Morganey/forks","keys_url":"https://api.github.com/repos/rexim/Morganey/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rexim/Morganey/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rexim/Morganey/teams","hooks_url":"https://api.github.com/repos/rexim/Morganey/hooks","issue_events_url":"https://api.github.com/repos/rexim/Morganey/issues/events{/number}","events_url":"https://api.github.com/repos/rexim/Morganey/events","assignees_url":"https://api.github.com/repos/rexim/Morganey/assignees{/user}","branches_url":"https://api.github.com/repos/rexim/Morganey/branches{/branch}","tags_url":"https://api.github.com/repos/rexim/Morganey/tags","blobs_url":"https://api.github.com/repos/rexim/Morganey/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rexim/Morganey/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rexim/Morganey/git/refs{/sha}","trees_url":"https://api.github.com/repos/rexim/Morganey/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rexim/Morganey/statuses/{sha}","languages_url":"https://api.github.com/repos/rexim/Morganey/languages","stargazers_url":"https://api.github.com/repos/rexim/Morganey/stargazers","contributors_url":"https://api.github.com/repos/rexim/Morganey/contributors","subscribers_url":"https://api.github.com/repos/rexim/Morganey/subscribers","subscription_url":"https://api.github.com/repos/rexim/Morganey/subscription","commits_url":"https://api.github.com/repos/rexim/Morganey/commits{/sha}","git_commits_url":"https://api.github.com/repos/rexim/Morganey/git/commits{/sha}","comments_url":"https://api.github.com/repos/rexim/Morganey/comments{/number}","issue_comment_url":"https://api.github.com/repos/rexim/Morganey/issues/comments{/number}","contents_url":"https://api.github.com/repos/rexim/Morganey/contents/{+path}","compare_url":"https://api.github.com/repos/rexim/Morganey/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rexim/Morganey/merges","archive_url":"https://api.github.com/repos/rexim/Morganey/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rexim/Morganey/downloads","issues_url":"https://api.github.com/repos/rexim/Morganey/issues{/number}","pulls_url":"https://api.github.com/repos/rexim/Morganey/pulls{/number}","milestones_url":"https://api.github.com/repos/rexim/Morganey/milestones{/number}","notifications_url":"https://api.github.com/repos/rexim/Morganey/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rexim/Morganey/labels{/name}","releases_url":"https://api.github.com/repos/rexim/Morganey/releases{/id}","deployments_url":"https://api.github.com/repos/rexim/Morganey/deployments","created_at":"2015-11-29T17:48:12Z","updated_at":"2016-08-23T14:52:21Z","pushed_at":"2016-08-23T18:26:11Z","git_url":"git://github.com/rexim/Morganey.git","ssh_url":"git@github.com:rexim/Morganey.git","clone_url":"https://github.com/rexim/Morganey.git","svn_url":"https://github.com/rexim/Morganey","homepage":"","size":252,"stargazers_count":9,"watchers_count":9,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":47,"forks":2,"open_issues":47,"watchers":9,"default_branch":"master"}},"base":{"label":"rexim:master","ref":"master","sha":"ffbb176dfe0873e549e88f8845b8c8f26c23096a","user":{"login":"rexim","id":165283,"avatar_url":"https://avatars.githubusercontent.com/u/165283?v=3","gravatar_id":"","url":"https://api.github.com/users/rexim","html_url":"https://github.com/rexim","followers_url":"https://api.github.com/users/rexim/followers","following_url":"https://api.github.com/users/rexim/following{/other_user}","gists_url":"https://api.github.com/users/rexim/gists{/gist_id}","starred_url":"https://api.github.com/users/rexim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rexim/subscriptions","organizations_url":"https://api.github.com/users/rexim/orgs","repos_url":"https://api.github.com/users/rexim/repos","events_url":"https://api.github.com/users/rexim/events{/privacy}","received_events_url":"https://api.github.com/users/rexim/received_events","type":"User","site_admin":false},"repo":{"id":47073664,"name":"Morganey","full_name":"rexim/Morganey","owner":{"login":"rexim","id":165283,"avatar_url":"https://avatars.githubusercontent.com/u/165283?v=3","gravatar_id":"","url":"https://api.github.com/users/rexim","html_url":"https://github.com/rexim","followers_url":"https://api.github.com/users/rexim/followers","following_url":"https://api.github.com/users/rexim/following{/other_user}","gists_url":"https://api.github.com/users/rexim/gists{/gist_id}","starred_url":"https://api.github.com/users/rexim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rexim/subscriptions","organizations_url":"https://api.github.com/users/rexim/orgs","repos_url":"https://api.github.com/users/rexim/repos","events_url":"https://api.github.com/users/rexim/events{/privacy}","received_events_url":"https://api.github.com/users/rexim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rexim/Morganey","description":"Lambda Calculus based programming language","fork":false,"url":"https://api.github.com/repos/rexim/Morganey","forks_url":"https://api.github.com/repos/rexim/Morganey/forks","keys_url":"https://api.github.com/repos/rexim/Morganey/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rexim/Morganey/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rexim/Morganey/teams","hooks_url":"https://api.github.com/repos/rexim/Morganey/hooks","issue_events_url":"https://api.github.com/repos/rexim/Morganey/issues/events{/number}","events_url":"https://api.github.com/repos/rexim/Morganey/events","assignees_url":"https://api.github.com/repos/rexim/Morganey/assignees{/user}","branches_url":"https://api.github.com/repos/rexim/Morganey/branches{/branch}","tags_url":"https://api.github.com/repos/rexim/Morganey/tags","blobs_url":"https://api.github.com/repos/rexim/Morganey/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rexim/Morganey/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rexim/Morganey/git/refs{/sha}","trees_url":"https://api.github.com/repos/rexim/Morganey/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rexim/Morganey/statuses/{sha}","languages_url":"https://api.github.com/repos/rexim/Morganey/languages","stargazers_url":"https://api.github.com/repos/rexim/Morganey/stargazers","contributors_url":"https://api.github.com/repos/rexim/Morganey/contributors","subscribers_url":"https://api.github.com/repos/rexim/Morganey/subscribers","subscription_url":"https://api.github.com/repos/rexim/Morganey/subscription","commits_url":"https://api.github.com/repos/rexim/Morganey/commits{/sha}","git_commits_url":"https://api.github.com/repos/rexim/Morganey/git/commits{/sha}","comments_url":"https://api.github.com/repos/rexim/Morganey/comments{/number}","issue_comment_url":"https://api.github.com/repos/rexim/Morganey/issues/comments{/number}","contents_url":"https://api.github.com/repos/rexim/Morganey/contents/{+path}","compare_url":"https://api.github.com/repos/rexim/Morganey/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rexim/Morganey/merges","archive_url":"https://api.github.com/repos/rexim/Morganey/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rexim/Morganey/downloads","issues_url":"https://api.github.com/repos/rexim/Morganey/issues{/number}","pulls_url":"https://api.github.com/repos/rexim/Morganey/pulls{/number}","milestones_url":"https://api.github.com/repos/rexim/Morganey/milestones{/number}","notifications_url":"https://api.github.com/repos/rexim/Morganey/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rexim/Morganey/labels{/name}","releases_url":"https://api.github.com/repos/rexim/Morganey/releases{/id}","deployments_url":"https://api.github.com/repos/rexim/Morganey/deployments","created_at":"2015-11-29T17:48:12Z","updated_at":"2016-08-23T14:52:21Z","pushed_at":"2016-08-23T18:26:11Z","git_url":"git://github.com/rexim/Morganey.git","ssh_url":"git@github.com:rexim/Morganey.git","clone_url":"https://github.com/rexim/Morganey.git","svn_url":"https://github.com/rexim/Morganey","homepage":"","size":252,"stargazers_count":9,"watchers_count":9,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":47,"forks":2,"open_issues":47,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rexim/Morganey/pulls/141"},"html":{"href":"https://github.com/rexim/Morganey/pull/141"},"issue":{"href":"https://api.github.com/repos/rexim/Morganey/issues/141"},"comments":{"href":"https://api.github.com/repos/rexim/Morganey/issues/141/comments"},"review_comments":{"href":"https://api.github.com/repos/rexim/Morganey/pulls/141/comments"},"review_comment":{"href":"https://api.github.com/repos/rexim/Morganey/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rexim/Morganey/pulls/141/commits"},"statuses":{"href":"https://api.github.com/repos/rexim/Morganey/statuses/01059b389e64f29e12450544a79c6123f77841bd"}}}}
{"actor":{"display_login":"rexim"}}