{"action":"created","issue":{"url":"https://api.github.com/repos/mxstbr/react-boilerplate/issues/980","repository_url":"https://api.github.com/repos/mxstbr/react-boilerplate","labels_url":"https://api.github.com/repos/mxstbr/react-boilerplate/issues/980/labels{/name}","comments_url":"https://api.github.com/repos/mxstbr/react-boilerplate/issues/980/comments","events_url":"https://api.github.com/repos/mxstbr/react-boilerplate/issues/980/events","html_url":"https://github.com/mxstbr/react-boilerplate/pull/980","id":176243138,"number":980,"title":"Add Jest","user":{"login":"dmitriiabramov","id":940133,"avatar_url":"https://avatars.githubusercontent.com/u/940133?v=3","gravatar_id":"","url":"https://api.github.com/users/dmitriiabramov","html_url":"https://github.com/dmitriiabramov","followers_url":"https://api.github.com/users/dmitriiabramov/followers","following_url":"https://api.github.com/users/dmitriiabramov/following{/other_user}","gists_url":"https://api.github.com/users/dmitriiabramov/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitriiabramov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitriiabramov/subscriptions","organizations_url":"https://api.github.com/users/dmitriiabramov/orgs","repos_url":"https://api.github.com/users/dmitriiabramov/repos","events_url":"https://api.github.com/users/dmitriiabramov/events{/privacy}","received_events_url":"https://api.github.com/users/dmitriiabramov/received_events","type":"User","site_admin":false},"labels":[{"id":391912623,"url":"https://api.github.com/repos/mxstbr/react-boilerplate/labels/in%20progress","name":"in progress","color":"FEF9F0","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":44,"created_at":"2016-09-11T13:11:14Z","updated_at":"2016-11-22T19:11:03Z","closed_at":"2016-11-03T18:39:17Z","pull_request":{"url":"https://api.github.com/repos/mxstbr/react-boilerplate/pulls/980","html_url":"https://github.com/mxstbr/react-boilerplate/pull/980","diff_url":"https://github.com/mxstbr/react-boilerplate/pull/980.diff","patch_url":"https://github.com/mxstbr/react-boilerplate/pull/980.patch"},"body":"The two main things that need to be done first:\n- `jest/jasmine` does not support generator functions in test descriptions. We can either add suporrt for it to jest and remove those tests from react boilerplate for now.\n- `chai` and `jest` both use `expect` for assertions and that can get a little confusing. I can either migrate everything from `chai` to `jest-matchers`, or we can import `const jestExpect = require('jest-matchers')` separately to use jest snapshot testing feature (will require some work on jest side as well)\n"},"comment":{"url":"https://api.github.com/repos/mxstbr/react-boilerplate/issues/comments/262335467","html_url":"https://github.com/mxstbr/react-boilerplate/pull/980#issuecomment-262335467","issue_url":"https://api.github.com/repos/mxstbr/react-boilerplate/issues/980","id":262335467,"user":{"login":"mxstbr","id":7525670,"avatar_url":"https://avatars.githubusercontent.com/u/7525670?v=3","gravatar_id":"","url":"https://api.github.com/users/mxstbr","html_url":"https://github.com/mxstbr","followers_url":"https://api.github.com/users/mxstbr/followers","following_url":"https://api.github.com/users/mxstbr/following{/other_user}","gists_url":"https://api.github.com/users/mxstbr/gists{/gist_id}","starred_url":"https://api.github.com/users/mxstbr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxstbr/subscriptions","organizations_url":"https://api.github.com/users/mxstbr/orgs","repos_url":"https://api.github.com/users/mxstbr/repos","events_url":"https://api.github.com/users/mxstbr/events{/privacy}","received_events_url":"https://api.github.com/users/mxstbr/received_events","type":"User","site_admin":false},"created_at":"2016-11-22T19:11:03Z","updated_at":"2016-11-22T19:11:03Z","body":"> Also, we don't get test coverage statistics with this configuration. Can we have this back?\r\n\r\n`npm run test -- --coverage` and you're done. Jest has coverage built in!"}}
{"actor":{"display_login":"mxstbr"}}