{"action":"opened","number":79,"pull_request":{"url":"https://api.github.com/repos/sorm/sorm/pulls/79","id":83964699,"html_url":"https://github.com/sorm/sorm/pull/79","diff_url":"https://github.com/sorm/sorm/pull/79.diff","patch_url":"https://github.com/sorm/sorm/pull/79.patch","issue_url":"https://api.github.com/repos/sorm/sorm/issues/79","number":79,"state":"open","locked":false,"title":"Preliminary, work-in-progress SQLite support","user":{"login":"csachs","id":8251055,"avatar_url":"https://avatars.githubusercontent.com/u/8251055?v=3","gravatar_id":"","url":"https://api.github.com/users/csachs","html_url":"https://github.com/csachs","followers_url":"https://api.github.com/users/csachs/followers","following_url":"https://api.github.com/users/csachs/following{/other_user}","gists_url":"https://api.github.com/users/csachs/gists{/gist_id}","starred_url":"https://api.github.com/users/csachs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csachs/subscriptions","organizations_url":"https://api.github.com/users/csachs/orgs","repos_url":"https://api.github.com/users/csachs/repos","events_url":"https://api.github.com/users/csachs/events{/privacy}","received_events_url":"https://api.github.com/users/csachs/received_events","type":"User","site_admin":false},"body":"While I thought that development of SORM might be inactive, some recent commits have proven the opposite, so I'd like to propose another addition ...\r\nI'm using SORM and I'm quite happy with it, but I would prefer to use SQLite over other embedded databases, as SQLite interoperability with other languages is much easier than e.g. H2.\r\n\r\nThus I've looked into adding SQLite support to SORM.\r\n\r\nThe patch so far passes many tests, however still has some weak spots:\r\n- Some errors in DateTime (de)serialization, might be similar to problems described [here](https://bitbucket.org/xerial/sqlite-jdbc/issues/23/getdate-returns-wrong-values), apparently dates can be stored in different ways in SQLite, but the JDBC adapter only understands one ...\r\n- Missing RegEx functionality. SQLite has no built-in regex engine, however, it could be added by using a user defined function, one would need to circumvent c3p0 to get a real SQLite connection object ...\r\n- Concurrency problems ... somehow puzzle me as SQLite by itself tend to handle concurrency really well, maybe some default options lead to overzealous locking …\r\n\r\nI'm putting it here, as I guess it might already be in a state where it might be useful to others, and furthermore, some problems (like the DateTime serialization issue) might be much easier fixed if someone with more in-depth knowledge to SORM might take a look at it.\r\n\r\nWhat do you think? I'll further take a look at the problems, but I'd be really happy if someone can point me to the right points; and afterwards this new database support could get added.\r\n\r\nBest regards,\r\nChristian","created_at":"2016-09-05T08:14:08Z","updated_at":"2016-09-05T08:14:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c7c25e1f201e55f3369c819391b1ac3509bd74c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sorm/sorm/pulls/79/commits","review_comments_url":"https://api.github.com/repos/sorm/sorm/pulls/79/comments","review_comment_url":"https://api.github.com/repos/sorm/sorm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sorm/sorm/issues/79/comments","statuses_url":"https://api.github.com/repos/sorm/sorm/statuses/701731b47fc6188a390dd4192927330263f2f026","head":{"label":"csachs:sqlite","ref":"sqlite","sha":"701731b47fc6188a390dd4192927330263f2f026","user":{"login":"csachs","id":8251055,"avatar_url":"https://avatars.githubusercontent.com/u/8251055?v=3","gravatar_id":"","url":"https://api.github.com/users/csachs","html_url":"https://github.com/csachs","followers_url":"https://api.github.com/users/csachs/followers","following_url":"https://api.github.com/users/csachs/following{/other_user}","gists_url":"https://api.github.com/users/csachs/gists{/gist_id}","starred_url":"https://api.github.com/users/csachs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csachs/subscriptions","organizations_url":"https://api.github.com/users/csachs/orgs","repos_url":"https://api.github.com/users/csachs/repos","events_url":"https://api.github.com/users/csachs/events{/privacy}","received_events_url":"https://api.github.com/users/csachs/received_events","type":"User","site_admin":false},"repo":{"id":28911529,"name":"sorm","full_name":"csachs/sorm","owner":{"login":"csachs","id":8251055,"avatar_url":"https://avatars.githubusercontent.com/u/8251055?v=3","gravatar_id":"","url":"https://api.github.com/users/csachs","html_url":"https://github.com/csachs","followers_url":"https://api.github.com/users/csachs/followers","following_url":"https://api.github.com/users/csachs/following{/other_user}","gists_url":"https://api.github.com/users/csachs/gists{/gist_id}","starred_url":"https://api.github.com/users/csachs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csachs/subscriptions","organizations_url":"https://api.github.com/users/csachs/orgs","repos_url":"https://api.github.com/users/csachs/repos","events_url":"https://api.github.com/users/csachs/events{/privacy}","received_events_url":"https://api.github.com/users/csachs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/csachs/sorm","description":"A functional boilerplate-free Scala ORM","fork":true,"url":"https://api.github.com/repos/csachs/sorm","forks_url":"https://api.github.com/repos/csachs/sorm/forks","keys_url":"https://api.github.com/repos/csachs/sorm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/csachs/sorm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/csachs/sorm/teams","hooks_url":"https://api.github.com/repos/csachs/sorm/hooks","issue_events_url":"https://api.github.com/repos/csachs/sorm/issues/events{/number}","events_url":"https://api.github.com/repos/csachs/sorm/events","assignees_url":"https://api.github.com/repos/csachs/sorm/assignees{/user}","branches_url":"https://api.github.com/repos/csachs/sorm/branches{/branch}","tags_url":"https://api.github.com/repos/csachs/sorm/tags","blobs_url":"https://api.github.com/repos/csachs/sorm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/csachs/sorm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/csachs/sorm/git/refs{/sha}","trees_url":"https://api.github.com/repos/csachs/sorm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/csachs/sorm/statuses/{sha}","languages_url":"https://api.github.com/repos/csachs/sorm/languages","stargazers_url":"https://api.github.com/repos/csachs/sorm/stargazers","contributors_url":"https://api.github.com/repos/csachs/sorm/contributors","subscribers_url":"https://api.github.com/repos/csachs/sorm/subscribers","subscription_url":"https://api.github.com/repos/csachs/sorm/subscription","commits_url":"https://api.github.com/repos/csachs/sorm/commits{/sha}","git_commits_url":"https://api.github.com/repos/csachs/sorm/git/commits{/sha}","comments_url":"https://api.github.com/repos/csachs/sorm/comments{/number}","issue_comment_url":"https://api.github.com/repos/csachs/sorm/issues/comments{/number}","contents_url":"https://api.github.com/repos/csachs/sorm/contents/{+path}","compare_url":"https://api.github.com/repos/csachs/sorm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/csachs/sorm/merges","archive_url":"https://api.github.com/repos/csachs/sorm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/csachs/sorm/downloads","issues_url":"https://api.github.com/repos/csachs/sorm/issues{/number}","pulls_url":"https://api.github.com/repos/csachs/sorm/pulls{/number}","milestones_url":"https://api.github.com/repos/csachs/sorm/milestones{/number}","notifications_url":"https://api.github.com/repos/csachs/sorm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/csachs/sorm/labels{/name}","releases_url":"https://api.github.com/repos/csachs/sorm/releases{/id}","deployments_url":"https://api.github.com/repos/csachs/sorm/deployments","created_at":"2015-01-07T11:23:01Z","updated_at":"2016-05-19T10:57:59Z","pushed_at":"2016-09-02T16:02:14Z","git_url":"git://github.com/csachs/sorm.git","ssh_url":"git@github.com:csachs/sorm.git","clone_url":"https://github.com/csachs/sorm.git","svn_url":"https://github.com/csachs/sorm","homepage":"sorm-framework.org","size":3778,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sorm:master","ref":"master","sha":"6e2725fd10a03e8d2970ddd93ad53bc942151401","user":{"login":"sorm","id":3649448,"avatar_url":"https://avatars.githubusercontent.com/u/3649448?v=3","gravatar_id":"","url":"https://api.github.com/users/sorm","html_url":"https://github.com/sorm","followers_url":"https://api.github.com/users/sorm/followers","following_url":"https://api.github.com/users/sorm/following{/other_user}","gists_url":"https://api.github.com/users/sorm/gists{/gist_id}","starred_url":"https://api.github.com/users/sorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sorm/subscriptions","organizations_url":"https://api.github.com/users/sorm/orgs","repos_url":"https://api.github.com/users/sorm/repos","events_url":"https://api.github.com/users/sorm/events{/privacy}","received_events_url":"https://api.github.com/users/sorm/received_events","type":"Organization","site_admin":false},"repo":{"id":4229245,"name":"sorm","full_name":"sorm/sorm","owner":{"login":"sorm","id":3649448,"avatar_url":"https://avatars.githubusercontent.com/u/3649448?v=3","gravatar_id":"","url":"https://api.github.com/users/sorm","html_url":"https://github.com/sorm","followers_url":"https://api.github.com/users/sorm/followers","following_url":"https://api.github.com/users/sorm/following{/other_user}","gists_url":"https://api.github.com/users/sorm/gists{/gist_id}","starred_url":"https://api.github.com/users/sorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sorm/subscriptions","organizations_url":"https://api.github.com/users/sorm/orgs","repos_url":"https://api.github.com/users/sorm/repos","events_url":"https://api.github.com/users/sorm/events{/privacy}","received_events_url":"https://api.github.com/users/sorm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sorm/sorm","description":"A functional boilerplate-free Scala ORM","fork":false,"url":"https://api.github.com/repos/sorm/sorm","forks_url":"https://api.github.com/repos/sorm/sorm/forks","keys_url":"https://api.github.com/repos/sorm/sorm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sorm/sorm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sorm/sorm/teams","hooks_url":"https://api.github.com/repos/sorm/sorm/hooks","issue_events_url":"https://api.github.com/repos/sorm/sorm/issues/events{/number}","events_url":"https://api.github.com/repos/sorm/sorm/events","assignees_url":"https://api.github.com/repos/sorm/sorm/assignees{/user}","branches_url":"https://api.github.com/repos/sorm/sorm/branches{/branch}","tags_url":"https://api.github.com/repos/sorm/sorm/tags","blobs_url":"https://api.github.com/repos/sorm/sorm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sorm/sorm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sorm/sorm/git/refs{/sha}","trees_url":"https://api.github.com/repos/sorm/sorm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sorm/sorm/statuses/{sha}","languages_url":"https://api.github.com/repos/sorm/sorm/languages","stargazers_url":"https://api.github.com/repos/sorm/sorm/stargazers","contributors_url":"https://api.github.com/repos/sorm/sorm/contributors","subscribers_url":"https://api.github.com/repos/sorm/sorm/subscribers","subscription_url":"https://api.github.com/repos/sorm/sorm/subscription","commits_url":"https://api.github.com/repos/sorm/sorm/commits{/sha}","git_commits_url":"https://api.github.com/repos/sorm/sorm/git/commits{/sha}","comments_url":"https://api.github.com/repos/sorm/sorm/comments{/number}","issue_comment_url":"https://api.github.com/repos/sorm/sorm/issues/comments{/number}","contents_url":"https://api.github.com/repos/sorm/sorm/contents/{+path}","compare_url":"https://api.github.com/repos/sorm/sorm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sorm/sorm/merges","archive_url":"https://api.github.com/repos/sorm/sorm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sorm/sorm/downloads","issues_url":"https://api.github.com/repos/sorm/sorm/issues{/number}","pulls_url":"https://api.github.com/repos/sorm/sorm/pulls{/number}","milestones_url":"https://api.github.com/repos/sorm/sorm/milestones{/number}","notifications_url":"https://api.github.com/repos/sorm/sorm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sorm/sorm/labels{/name}","releases_url":"https://api.github.com/repos/sorm/sorm/releases{/id}","deployments_url":"https://api.github.com/repos/sorm/sorm/deployments","created_at":"2012-05-04T21:17:13Z","updated_at":"2016-08-26T16:18:53Z","pushed_at":"2016-09-05T08:14:08Z","git_url":"git://github.com/sorm/sorm.git","ssh_url":"git@github.com:sorm/sorm.git","clone_url":"https://github.com/sorm/sorm.git","svn_url":"https://github.com/sorm/sorm","homepage":"sorm-framework.org","size":4016,"stargazers_count":223,"watchers_count":223,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":31,"mirror_url":null,"open_issues_count":27,"forks":31,"open_issues":27,"watchers":223,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sorm/sorm/pulls/79"},"html":{"href":"https://github.com/sorm/sorm/pull/79"},"issue":{"href":"https://api.github.com/repos/sorm/sorm/issues/79"},"comments":{"href":"https://api.github.com/repos/sorm/sorm/issues/79/comments"},"review_comments":{"href":"https://api.github.com/repos/sorm/sorm/pulls/79/comments"},"review_comment":{"href":"https://api.github.com/repos/sorm/sorm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sorm/sorm/pulls/79/commits"},"statuses":{"href":"https://api.github.com/repos/sorm/sorm/statuses/701731b47fc6188a390dd4192927330263f2f026"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":140,"deletions":5,"changed_files":8}}
{"actor":{"display_login":"csachs"}}