{"action":"created","issue":{"url":"https://api.github.com/repos/hrydgard/ppsspp/issues/8937","repository_url":"https://api.github.com/repos/hrydgard/ppsspp","labels_url":"https://api.github.com/repos/hrydgard/ppsspp/issues/8937/labels{/name}","comments_url":"https://api.github.com/repos/hrydgard/ppsspp/issues/8937/comments","events_url":"https://api.github.com/repos/hrydgard/ppsspp/issues/8937/events","html_url":"https://github.com/hrydgard/ppsspp/pull/8937","id":173645451,"number":8937,"title":"Implement W^X-compatible JIT. Hopefully makes JIT work on iOS again","user":{"login":"hrydgard","id":130929,"avatar_url":"https://avatars.githubusercontent.com/u/130929?v=3","gravatar_id":"","url":"https://api.github.com/users/hrydgard","html_url":"https://github.com/hrydgard","followers_url":"https://api.github.com/users/hrydgard/followers","following_url":"https://api.github.com/users/hrydgard/following{/other_user}","gists_url":"https://api.github.com/users/hrydgard/gists{/gist_id}","starred_url":"https://api.github.com/users/hrydgard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrydgard/subscriptions","organizations_url":"https://api.github.com/users/hrydgard/orgs","repos_url":"https://api.github.com/users/hrydgard/repos","events_url":"https://api.github.com/users/hrydgard/events{/privacy}","received_events_url":"https://api.github.com/users/hrydgard/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2016-08-28T12:56:55Z","updated_at":"2016-09-03T18:16:09Z","closed_at":"2016-08-28T16:19:54Z","pull_request":{"url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/8937","html_url":"https://github.com/hrydgard/ppsspp/pull/8937","diff_url":"https://github.com/hrydgard/ppsspp/pull/8937.diff","patch_url":"https://github.com/hrydgard/ppsspp/pull/8937.patch"},"body":"Will hopefully fix issue #8122, with a lot less of a speed hit than @vit9696's patch (thanks for that!)\r\n\r\nFor now, block linking is disabled in this mode. Would like confirmation that this works on iOS before doing the work to enable it.\r\n\r\nTo play around with this mode on other platforms, simply change PlatformIsWXExclusive in MemoryUtil.cpp to always return true. Speed hit appears to be minimal, disregarding the loss of block linking.\r\n\r\nPlease let me know if this works or not in the comments. I've enabled the mode and tested on Android and Windows, and those are fine."},"comment":{"url":"https://api.github.com/repos/hrydgard/ppsspp/issues/comments/244561841","html_url":"https://github.com/hrydgard/ppsspp/pull/8937#issuecomment-244561841","issue_url":"https://api.github.com/repos/hrydgard/ppsspp/issues/8937","id":244561841,"user":{"login":"unknownbrackets","id":191233,"avatar_url":"https://avatars.githubusercontent.com/u/191233?v=3","gravatar_id":"","url":"https://api.github.com/users/unknownbrackets","html_url":"https://github.com/unknownbrackets","followers_url":"https://api.github.com/users/unknownbrackets/followers","following_url":"https://api.github.com/users/unknownbrackets/following{/other_user}","gists_url":"https://api.github.com/users/unknownbrackets/gists{/gist_id}","starred_url":"https://api.github.com/users/unknownbrackets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unknownbrackets/subscriptions","organizations_url":"https://api.github.com/users/unknownbrackets/orgs","repos_url":"https://api.github.com/users/unknownbrackets/repos","events_url":"https://api.github.com/users/unknownbrackets/events{/privacy}","received_events_url":"https://api.github.com/users/unknownbrackets/received_events","type":"User","site_admin":false},"created_at":"2016-09-03T18:16:09Z","updated_at":"2016-09-03T18:16:09Z","body":"Just to say, the 3GS couldn't even run most easy/simple games at full speed with frameskip iirc.  Also, last I checked my iOS version was too low to run PPSSPP anymore, but not a huge loss.\r\n\r\nThe performance impact is likely to vary by operating system.  hrydgard could test on Windows, let's say, or Android, but it might not reflect the performance impact on iOS.\r\n\r\nSo someone with an iOS device that doesn't need W^X would likely need to perform the tests, but this would likely require writing code to get a good sense of the compilation performance impact (since runtime won't be affected, and loading times are harder to measure.)\r\n\r\n-[Unknown]"}}
{"actor":{"display_login":"unknownbrackets"}}