{"action":"created","issue":{"url":"https://api.github.com/repos/kako-nawao/ffconv/issues/20","repository_url":"https://api.github.com/repos/kako-nawao/ffconv","labels_url":"https://api.github.com/repos/kako-nawao/ffconv/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/kako-nawao/ffconv/issues/20/comments","events_url":"https://api.github.com/repos/kako-nawao/ffconv/issues/20/events","html_url":"https://github.com/kako-nawao/ffconv/pull/20","id":131035379,"number":20,"title":"Re-structured code, added lots of docstrings and comments","user":{"login":"kako-nawao","id":3527011,"avatar_url":"https://avatars.githubusercontent.com/u/3527011?v=3","gravatar_id":"","url":"https://api.github.com/users/kako-nawao","html_url":"https://github.com/kako-nawao","followers_url":"https://api.github.com/users/kako-nawao/followers","following_url":"https://api.github.com/users/kako-nawao/following{/other_user}","gists_url":"https://api.github.com/users/kako-nawao/gists{/gist_id}","starred_url":"https://api.github.com/users/kako-nawao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kako-nawao/subscriptions","organizations_url":"https://api.github.com/users/kako-nawao/orgs","repos_url":"https://api.github.com/users/kako-nawao/repos","events_url":"https://api.github.com/users/kako-nawao/events{/privacy}","received_events_url":"https://api.github.com/users/kako-nawao/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-03T14:04:28Z","updated_at":"2016-02-03T14:30:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kako-nawao/ffconv/pulls/20","html_url":"https://github.com/kako-nawao/ffconv/pull/20","diff_url":"https://github.com/kako-nawao/ffconv/pull/20.diff","patch_url":"https://github.com/kako-nawao/ffconv/pull/20.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/kako-nawao/ffconv/issues/comments/179265782","html_url":"https://github.com/kako-nawao/ffconv/pull/20#issuecomment-179265782","issue_url":"https://api.github.com/repos/kako-nawao/ffconv/issues/20","id":179265782,"user":{"login":"kako-nawao","id":3527011,"avatar_url":"https://avatars.githubusercontent.com/u/3527011?v=3","gravatar_id":"","url":"https://api.github.com/users/kako-nawao","html_url":"https://github.com/kako-nawao","followers_url":"https://api.github.com/users/kako-nawao/followers","following_url":"https://api.github.com/users/kako-nawao/following{/other_user}","gists_url":"https://api.github.com/users/kako-nawao/gists{/gist_id}","starred_url":"https://api.github.com/users/kako-nawao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kako-nawao/subscriptions","organizations_url":"https://api.github.com/users/kako-nawao/orgs","repos_url":"https://api.github.com/users/kako-nawao/repos","events_url":"https://api.github.com/users/kako-nawao/events{/privacy}","received_events_url":"https://api.github.com/users/kako-nawao/received_events","type":"User","site_admin":false},"created_at":"2016-02-03T14:30:27Z","updated_at":"2016-02-03T14:30:27Z","body":"SonarQube analysis reported 18 issues:\n* ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) 2 major\n* ![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) 16 minor\n\nWatch the comments in this conversation to review them.\nNote: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:\n* ![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) [The line contains 124 characters which is greater than 120 authorized.](https://github.com/kako-nawao/ffconv/blob/dcda3bc2ab50ec7f809c3993c6910e663ef99ca7/ffconv/file_processor.py#L150) [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://localhost:9000/coding_rules#rule_key=python%3ALineLength)\n* ![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) [Redefining built-in 'input'](https://github.com/kako-nawao/ffconv/blob/dcda3bc2ab50ec7f809c3993c6910e663ef99ca7/ffconv/file_processor.py#L71) [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://localhost:9000/coding_rules#rule_key=Pylint%3AW0622)\n* ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [Raising NoneType while only classes or instances are allowed](https://github.com/kako-nawao/ffconv/blob/dcda3bc2ab50ec7f809c3993c6910e663ef99ca7/ffconv/file_processor.py#L113) [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://localhost:9000/coding_rules#rule_key=Pylint%3AE0702)\n* ![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) [Catching too general exception Exception](https://github.com/kako-nawao/ffconv/blob/dcda3bc2ab50ec7f809c3993c6910e663ef99ca7/ffconv/file_processor.py#L152) [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://localhost:9000/coding_rules#rule_key=Pylint%3AW0703)\n* ![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) [Used builtin function 'filter'. Using a list comprehension can be clearer.](https://github.com/kako-nawao/ffconv/blob/dcda3bc2ab50ec7f809c3993c6910e663ef99ca7/ffconv/file_processor.py#L140) [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://localhost:9000/coding_rules#rule_key=Pylint%3AW0141)\n* ![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) [Catching too general exception Exception](https://github.com/kako-nawao/ffconv/blob/dcda3bc2ab50ec7f809c3993c6910e663ef99ca7/ffconv/file_processor.py#L179) [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://localhost:9000/coding_rules#rule_key=Pylint%3AW0703)\n"}}