{"action":"closed","number":2386,"pull_request":{"url":"https://api.github.com/repos/snipe/snipe-it/pulls/2386","id":79794806,"html_url":"https://github.com/snipe/snipe-it/pull/2386","diff_url":"https://github.com/snipe/snipe-it/pull/2386.diff","patch_url":"https://github.com/snipe/snipe-it/pull/2386.patch","issue_url":"https://api.github.com/repos/snipe/snipe-it/issues/2386","number":2386,"state":"closed","locked":false,"title":"Explicitly set the favicon in the basic and default layout templates","user":{"login":"bobeagan","id":100226,"avatar_url":"https://avatars.githubusercontent.com/u/100226?v=3","gravatar_id":"","url":"https://api.github.com/users/bobeagan","html_url":"https://github.com/bobeagan","followers_url":"https://api.github.com/users/bobeagan/followers","following_url":"https://api.github.com/users/bobeagan/following{/other_user}","gists_url":"https://api.github.com/users/bobeagan/gists{/gist_id}","starred_url":"https://api.github.com/users/bobeagan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobeagan/subscriptions","organizations_url":"https://api.github.com/users/bobeagan/orgs","repos_url":"https://api.github.com/users/bobeagan/repos","events_url":"https://api.github.com/users/bobeagan/events{/privacy}","received_events_url":"https://api.github.com/users/bobeagan/received_events","type":"User","site_admin":false},"body":"This is a temporary workaround to solve the issue of using the included favicon.ico file when installing to a subdirectory rather than to the root of the domain.  If you install to a subdirectory and the root domain already includes a favicon, that will be used rather than the included favicon.\r\n\r\nA better approach would be to allow users to upload their own favicon in the same fashion as is done with logos.\r\n\r\n*sorry for the auto whitespace cleanup that my editor did when I saved the default layout file","created_at":"2016-08-02T19:34:36Z","updated_at":"2016-08-02T19:36:33Z","closed_at":"2016-08-02T19:36:33Z","merged_at":null,"merge_commit_sha":"fa3ae248ccd42d2df9527ec7d39eaa3b5d262e50","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/snipe/snipe-it/pulls/2386/commits","review_comments_url":"https://api.github.com/repos/snipe/snipe-it/pulls/2386/comments","review_comment_url":"https://api.github.com/repos/snipe/snipe-it/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snipe/snipe-it/issues/2386/comments","statuses_url":"https://api.github.com/repos/snipe/snipe-it/statuses/32099d0e0c7dbd3f8056c08777aa7239f723db9d","head":{"label":"bobeagan:feature/explicit-favicon","ref":"feature/explicit-favicon","sha":"32099d0e0c7dbd3f8056c08777aa7239f723db9d","user":{"login":"bobeagan","id":100226,"avatar_url":"https://avatars.githubusercontent.com/u/100226?v=3","gravatar_id":"","url":"https://api.github.com/users/bobeagan","html_url":"https://github.com/bobeagan","followers_url":"https://api.github.com/users/bobeagan/followers","following_url":"https://api.github.com/users/bobeagan/following{/other_user}","gists_url":"https://api.github.com/users/bobeagan/gists{/gist_id}","starred_url":"https://api.github.com/users/bobeagan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobeagan/subscriptions","organizations_url":"https://api.github.com/users/bobeagan/orgs","repos_url":"https://api.github.com/users/bobeagan/repos","events_url":"https://api.github.com/users/bobeagan/events{/privacy}","received_events_url":"https://api.github.com/users/bobeagan/received_events","type":"User","site_admin":false},"repo":{"id":64786421,"name":"snipe-it","full_name":"bobeagan/snipe-it","owner":{"login":"bobeagan","id":100226,"avatar_url":"https://avatars.githubusercontent.com/u/100226?v=3","gravatar_id":"","url":"https://api.github.com/users/bobeagan","html_url":"https://github.com/bobeagan","followers_url":"https://api.github.com/users/bobeagan/followers","following_url":"https://api.github.com/users/bobeagan/following{/other_user}","gists_url":"https://api.github.com/users/bobeagan/gists{/gist_id}","starred_url":"https://api.github.com/users/bobeagan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobeagan/subscriptions","organizations_url":"https://api.github.com/users/bobeagan/orgs","repos_url":"https://api.github.com/users/bobeagan/repos","events_url":"https://api.github.com/users/bobeagan/events{/privacy}","received_events_url":"https://api.github.com/users/bobeagan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bobeagan/snipe-it","description":"A free open source IT asset/license management system built in PHP on Laravel 5.2 and Bootstrap 3. ","fork":true,"url":"https://api.github.com/repos/bobeagan/snipe-it","forks_url":"https://api.github.com/repos/bobeagan/snipe-it/forks","keys_url":"https://api.github.com/repos/bobeagan/snipe-it/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bobeagan/snipe-it/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bobeagan/snipe-it/teams","hooks_url":"https://api.github.com/repos/bobeagan/snipe-it/hooks","issue_events_url":"https://api.github.com/repos/bobeagan/snipe-it/issues/events{/number}","events_url":"https://api.github.com/repos/bobeagan/snipe-it/events","assignees_url":"https://api.github.com/repos/bobeagan/snipe-it/assignees{/user}","branches_url":"https://api.github.com/repos/bobeagan/snipe-it/branches{/branch}","tags_url":"https://api.github.com/repos/bobeagan/snipe-it/tags","blobs_url":"https://api.github.com/repos/bobeagan/snipe-it/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bobeagan/snipe-it/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bobeagan/snipe-it/git/refs{/sha}","trees_url":"https://api.github.com/repos/bobeagan/snipe-it/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bobeagan/snipe-it/statuses/{sha}","languages_url":"https://api.github.com/repos/bobeagan/snipe-it/languages","stargazers_url":"https://api.github.com/repos/bobeagan/snipe-it/stargazers","contributors_url":"https://api.github.com/repos/bobeagan/snipe-it/contributors","subscribers_url":"https://api.github.com/repos/bobeagan/snipe-it/subscribers","subscription_url":"https://api.github.com/repos/bobeagan/snipe-it/subscription","commits_url":"https://api.github.com/repos/bobeagan/snipe-it/commits{/sha}","git_commits_url":"https://api.github.com/repos/bobeagan/snipe-it/git/commits{/sha}","comments_url":"https://api.github.com/repos/bobeagan/snipe-it/comments{/number}","issue_comment_url":"https://api.github.com/repos/bobeagan/snipe-it/issues/comments{/number}","contents_url":"https://api.github.com/repos/bobeagan/snipe-it/contents/{+path}","compare_url":"https://api.github.com/repos/bobeagan/snipe-it/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bobeagan/snipe-it/merges","archive_url":"https://api.github.com/repos/bobeagan/snipe-it/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bobeagan/snipe-it/downloads","issues_url":"https://api.github.com/repos/bobeagan/snipe-it/issues{/number}","pulls_url":"https://api.github.com/repos/bobeagan/snipe-it/pulls{/number}","milestones_url":"https://api.github.com/repos/bobeagan/snipe-it/milestones{/number}","notifications_url":"https://api.github.com/repos/bobeagan/snipe-it/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bobeagan/snipe-it/labels{/name}","releases_url":"https://api.github.com/repos/bobeagan/snipe-it/releases{/id}","deployments_url":"https://api.github.com/repos/bobeagan/snipe-it/deployments","created_at":"2016-08-02T19:29:38Z","updated_at":"2016-08-02T19:29:45Z","pushed_at":"2016-08-02T19:30:37Z","git_url":"git://github.com/bobeagan/snipe-it.git","ssh_url":"git@github.com:bobeagan/snipe-it.git","clone_url":"https://github.com/bobeagan/snipe-it.git","svn_url":"https://github.com/bobeagan/snipe-it","homepage":"https://snipeitapp.com","size":27116,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"snipe:master","ref":"master","sha":"1c09479d5fc1e60361c40fba4bf5a351358ca0e4","user":{"login":"snipe","id":197404,"avatar_url":"https://avatars.githubusercontent.com/u/197404?v=3","gravatar_id":"","url":"https://api.github.com/users/snipe","html_url":"https://github.com/snipe","followers_url":"https://api.github.com/users/snipe/followers","following_url":"https://api.github.com/users/snipe/following{/other_user}","gists_url":"https://api.github.com/users/snipe/gists{/gist_id}","starred_url":"https://api.github.com/users/snipe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snipe/subscriptions","organizations_url":"https://api.github.com/users/snipe/orgs","repos_url":"https://api.github.com/users/snipe/repos","events_url":"https://api.github.com/users/snipe/events{/privacy}","received_events_url":"https://api.github.com/users/snipe/received_events","type":"User","site_admin":false},"repo":{"id":14346979,"name":"snipe-it","full_name":"snipe/snipe-it","owner":{"login":"snipe","id":197404,"avatar_url":"https://avatars.githubusercontent.com/u/197404?v=3","gravatar_id":"","url":"https://api.github.com/users/snipe","html_url":"https://github.com/snipe","followers_url":"https://api.github.com/users/snipe/followers","following_url":"https://api.github.com/users/snipe/following{/other_user}","gists_url":"https://api.github.com/users/snipe/gists{/gist_id}","starred_url":"https://api.github.com/users/snipe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snipe/subscriptions","organizations_url":"https://api.github.com/users/snipe/orgs","repos_url":"https://api.github.com/users/snipe/repos","events_url":"https://api.github.com/users/snipe/events{/privacy}","received_events_url":"https://api.github.com/users/snipe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/snipe/snipe-it","description":"A free open source IT asset/license management system built in PHP on Laravel 5.2 and Bootstrap 3. ","fork":false,"url":"https://api.github.com/repos/snipe/snipe-it","forks_url":"https://api.github.com/repos/snipe/snipe-it/forks","keys_url":"https://api.github.com/repos/snipe/snipe-it/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snipe/snipe-it/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snipe/snipe-it/teams","hooks_url":"https://api.github.com/repos/snipe/snipe-it/hooks","issue_events_url":"https://api.github.com/repos/snipe/snipe-it/issues/events{/number}","events_url":"https://api.github.com/repos/snipe/snipe-it/events","assignees_url":"https://api.github.com/repos/snipe/snipe-it/assignees{/user}","branches_url":"https://api.github.com/repos/snipe/snipe-it/branches{/branch}","tags_url":"https://api.github.com/repos/snipe/snipe-it/tags","blobs_url":"https://api.github.com/repos/snipe/snipe-it/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snipe/snipe-it/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snipe/snipe-it/git/refs{/sha}","trees_url":"https://api.github.com/repos/snipe/snipe-it/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snipe/snipe-it/statuses/{sha}","languages_url":"https://api.github.com/repos/snipe/snipe-it/languages","stargazers_url":"https://api.github.com/repos/snipe/snipe-it/stargazers","contributors_url":"https://api.github.com/repos/snipe/snipe-it/contributors","subscribers_url":"https://api.github.com/repos/snipe/snipe-it/subscribers","subscription_url":"https://api.github.com/repos/snipe/snipe-it/subscription","commits_url":"https://api.github.com/repos/snipe/snipe-it/commits{/sha}","git_commits_url":"https://api.github.com/repos/snipe/snipe-it/git/commits{/sha}","comments_url":"https://api.github.com/repos/snipe/snipe-it/comments{/number}","issue_comment_url":"https://api.github.com/repos/snipe/snipe-it/issues/comments{/number}","contents_url":"https://api.github.com/repos/snipe/snipe-it/contents/{+path}","compare_url":"https://api.github.com/repos/snipe/snipe-it/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snipe/snipe-it/merges","archive_url":"https://api.github.com/repos/snipe/snipe-it/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snipe/snipe-it/downloads","issues_url":"https://api.github.com/repos/snipe/snipe-it/issues{/number}","pulls_url":"https://api.github.com/repos/snipe/snipe-it/pulls{/number}","milestones_url":"https://api.github.com/repos/snipe/snipe-it/milestones{/number}","notifications_url":"https://api.github.com/repos/snipe/snipe-it/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snipe/snipe-it/labels{/name}","releases_url":"https://api.github.com/repos/snipe/snipe-it/releases{/id}","deployments_url":"https://api.github.com/repos/snipe/snipe-it/deployments","created_at":"2013-11-12T22:25:47Z","updated_at":"2016-08-02T16:03:23Z","pushed_at":"2016-08-02T19:34:37Z","git_url":"git://github.com/snipe/snipe-it.git","ssh_url":"git@github.com:snipe/snipe-it.git","clone_url":"https://github.com/snipe/snipe-it.git","svn_url":"https://github.com/snipe/snipe-it","homepage":"https://snipeitapp.com","size":27116,"stargazers_count":832,"watchers_count":832,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":413,"mirror_url":null,"open_issues_count":398,"forks":413,"open_issues":398,"watchers":832,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snipe/snipe-it/pulls/2386"},"html":{"href":"https://github.com/snipe/snipe-it/pull/2386"},"issue":{"href":"https://api.github.com/repos/snipe/snipe-it/issues/2386"},"comments":{"href":"https://api.github.com/repos/snipe/snipe-it/issues/2386/comments"},"review_comments":{"href":"https://api.github.com/repos/snipe/snipe-it/pulls/2386/comments"},"review_comment":{"href":"https://api.github.com/repos/snipe/snipe-it/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snipe/snipe-it/pulls/2386/commits"},"statuses":{"href":"https://api.github.com/repos/snipe/snipe-it/statuses/32099d0e0c7dbd3f8056c08777aa7239f723db9d"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":6,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"bobeagan"}}