{"action":"created","comment":{"url":"https://api.github.com/repos/broadinstitute/viral-ngs/pulls/comments/63084248","id":63084248,"diff_hunk":"@@ -99,7 +99,10 @@ def execute(self, command, options=None, option_string=None, return_stdout=False\n         if option_string:\n             cmd.extend(shlex.split(option_string))\n         log.debug(\"Calling {}: {}\".format(command, \" \".join(cmd)))\n-        return util.misc.run(cmd, stdout=subprocess.PIPE, stderr=subprocess.STDOUT)\n+        res = util.misc.run_and_print(cmd)","path":"tools/diamond.py","position":14,"original_position":14,"commit_id":"ab518300787a8677c1345eef9a415a2edc8cfc78","original_commit_id":"ab518300787a8677c1345eef9a415a2edc8cfc78","user":{"login":"dpark01","id":8513746,"avatar_url":"https://avatars.githubusercontent.com/u/8513746?v=3","gravatar_id":"","url":"https://api.github.com/users/dpark01","html_url":"https://github.com/dpark01","followers_url":"https://api.github.com/users/dpark01/followers","following_url":"https://api.github.com/users/dpark01/following{/other_user}","gists_url":"https://api.github.com/users/dpark01/gists{/gist_id}","starred_url":"https://api.github.com/users/dpark01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpark01/subscriptions","organizations_url":"https://api.github.com/users/dpark01/orgs","repos_url":"https://api.github.com/users/dpark01/repos","events_url":"https://api.github.com/users/dpark01/events{/privacy}","received_events_url":"https://api.github.com/users/dpark01/received_events","type":"User","site_admin":false},"body":"two thoughts:\r\n\r\n1. why run_and_print and not subprocess.check_call?\r\n2. if run_and_print, how about log.error(res.stdout.decode('utf-8')) instead of print()?","created_at":"2016-05-12T19:44:21Z","updated_at":"2016-05-12T19:44:21Z","html_url":"https://github.com/broadinstitute/viral-ngs/pull/301#discussion_r63084248","pull_request_url":"https://api.github.com/repos/broadinstitute/viral-ngs/pulls/301","_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/viral-ngs/pulls/comments/63084248"},"html":{"href":"https://github.com/broadinstitute/viral-ngs/pull/301#discussion_r63084248"},"pull_request":{"href":"https://api.github.com/repos/broadinstitute/viral-ngs/pulls/301"}}},"pull_request":{"url":"https://api.github.com/repos/broadinstitute/viral-ngs/pulls/301","id":69893881,"html_url":"https://github.com/broadinstitute/viral-ngs/pull/301","diff_url":"https://github.com/broadinstitute/viral-ngs/pull/301.diff","patch_url":"https://github.com/broadinstitute/viral-ngs/pull/301.patch","issue_url":"https://api.github.com/repos/broadinstitute/viral-ngs/issues/301","number":301,"state":"open","locked":false,"title":"Diamond integration test with pytest","user":{"login":"yesimon","id":601839,"avatar_url":"https://avatars.githubusercontent.com/u/601839?v=3","gravatar_id":"","url":"https://api.github.com/users/yesimon","html_url":"https://github.com/yesimon","followers_url":"https://api.github.com/users/yesimon/followers","following_url":"https://api.github.com/users/yesimon/following{/other_user}","gists_url":"https://api.github.com/users/yesimon/gists{/gist_id}","starred_url":"https://api.github.com/users/yesimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yesimon/subscriptions","organizations_url":"https://api.github.com/users/yesimon/orgs","repos_url":"https://api.github.com/users/yesimon/repos","events_url":"https://api.github.com/users/yesimon/events{/privacy}","received_events_url":"https://api.github.com/users/yesimon/received_events","type":"User","site_admin":false},"body":"Also rename test input folder to reflect multiple usages.","created_at":"2016-05-12T19:34:52Z","updated_at":"2016-05-12T19:44:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6fbc8a79267a56958479c7f3c8389b7e99c41ebf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/broadinstitute/viral-ngs/pulls/301/commits","review_comments_url":"https://api.github.com/repos/broadinstitute/viral-ngs/pulls/301/comments","review_comment_url":"https://api.github.com/repos/broadinstitute/viral-ngs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/broadinstitute/viral-ngs/issues/301/comments","statuses_url":"https://api.github.com/repos/broadinstitute/viral-ngs/statuses/ab518300787a8677c1345eef9a415a2edc8cfc78","head":{"label":"broadinstitute:sy-diamond-integration","ref":"sy-diamond-integration","sha":"ab518300787a8677c1345eef9a415a2edc8cfc78","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":24471201,"name":"viral-ngs","full_name":"broadinstitute/viral-ngs","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/viral-ngs","description":"Viral genomics analysis pipelines","fork":false,"url":"https://api.github.com/repos/broadinstitute/viral-ngs","forks_url":"https://api.github.com/repos/broadinstitute/viral-ngs/forks","keys_url":"https://api.github.com/repos/broadinstitute/viral-ngs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/viral-ngs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/viral-ngs/teams","hooks_url":"https://api.github.com/repos/broadinstitute/viral-ngs/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/viral-ngs/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/viral-ngs/events","assignees_url":"https://api.github.com/repos/broadinstitute/viral-ngs/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/viral-ngs/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/viral-ngs/tags","blobs_url":"https://api.github.com/repos/broadinstitute/viral-ngs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/viral-ngs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/viral-ngs/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/viral-ngs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/viral-ngs/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/viral-ngs/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/viral-ngs/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/viral-ngs/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/viral-ngs/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/viral-ngs/subscription","commits_url":"https://api.github.com/repos/broadinstitute/viral-ngs/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/viral-ngs/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/viral-ngs/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/viral-ngs/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/viral-ngs/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/viral-ngs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/viral-ngs/merges","archive_url":"https://api.github.com/repos/broadinstitute/viral-ngs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/viral-ngs/downloads","issues_url":"https://api.github.com/repos/broadinstitute/viral-ngs/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/viral-ngs/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/viral-ngs/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/viral-ngs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/viral-ngs/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/viral-ngs/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/viral-ngs/deployments","created_at":"2014-09-25T19:00:24Z","updated_at":"2016-05-11T16:41:38Z","pushed_at":"2016-05-12T19:34:53Z","git_url":"git://github.com/broadinstitute/viral-ngs.git","ssh_url":"git@github.com:broadinstitute/viral-ngs.git","clone_url":"https://github.com/broadinstitute/viral-ngs.git","svn_url":"https://github.com/broadinstitute/viral-ngs","homepage":"","size":25894,"stargazers_count":23,"watchers_count":23,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"open_issues_count":13,"forks":10,"open_issues":13,"watchers":23,"default_branch":"master"}},"base":{"label":"broadinstitute:master","ref":"master","sha":"5caf13db2e54c927bdb33dde365b05048cfe06ae","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":24471201,"name":"viral-ngs","full_name":"broadinstitute/viral-ngs","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/viral-ngs","description":"Viral genomics analysis pipelines","fork":false,"url":"https://api.github.com/repos/broadinstitute/viral-ngs","forks_url":"https://api.github.com/repos/broadinstitute/viral-ngs/forks","keys_url":"https://api.github.com/repos/broadinstitute/viral-ngs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/viral-ngs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/viral-ngs/teams","hooks_url":"https://api.github.com/repos/broadinstitute/viral-ngs/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/viral-ngs/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/viral-ngs/events","assignees_url":"https://api.github.com/repos/broadinstitute/viral-ngs/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/viral-ngs/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/viral-ngs/tags","blobs_url":"https://api.github.com/repos/broadinstitute/viral-ngs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/viral-ngs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/viral-ngs/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/viral-ngs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/viral-ngs/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/viral-ngs/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/viral-ngs/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/viral-ngs/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/viral-ngs/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/viral-ngs/subscription","commits_url":"https://api.github.com/repos/broadinstitute/viral-ngs/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/viral-ngs/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/viral-ngs/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/viral-ngs/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/viral-ngs/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/viral-ngs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/viral-ngs/merges","archive_url":"https://api.github.com/repos/broadinstitute/viral-ngs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/viral-ngs/downloads","issues_url":"https://api.github.com/repos/broadinstitute/viral-ngs/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/viral-ngs/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/viral-ngs/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/viral-ngs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/viral-ngs/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/viral-ngs/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/viral-ngs/deployments","created_at":"2014-09-25T19:00:24Z","updated_at":"2016-05-11T16:41:38Z","pushed_at":"2016-05-12T19:34:53Z","git_url":"git://github.com/broadinstitute/viral-ngs.git","ssh_url":"git@github.com:broadinstitute/viral-ngs.git","clone_url":"https://github.com/broadinstitute/viral-ngs.git","svn_url":"https://github.com/broadinstitute/viral-ngs","homepage":"","size":25894,"stargazers_count":23,"watchers_count":23,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"open_issues_count":13,"forks":10,"open_issues":13,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/viral-ngs/pulls/301"},"html":{"href":"https://github.com/broadinstitute/viral-ngs/pull/301"},"issue":{"href":"https://api.github.com/repos/broadinstitute/viral-ngs/issues/301"},"comments":{"href":"https://api.github.com/repos/broadinstitute/viral-ngs/issues/301/comments"},"review_comments":{"href":"https://api.github.com/repos/broadinstitute/viral-ngs/pulls/301/comments"},"review_comment":{"href":"https://api.github.com/repos/broadinstitute/viral-ngs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/broadinstitute/viral-ngs/pulls/301/commits"},"statuses":{"href":"https://api.github.com/repos/broadinstitute/viral-ngs/statuses/ab518300787a8677c1345eef9a415a2edc8cfc78"}}}}