{"comment":{"url":"https://api.github.com/repos/ksprashu/consent-framework/comments/19675531","html_url":"https://github.com/ksprashu/consent-framework/commit/6ffeab5ac470871d4857dd083cdf7f98ee1dcb91#commitcomment-19675531","id":19675531,"user":{"login":"ksprashu","id":476729,"avatar_url":"https://avatars.githubusercontent.com/u/476729?v=3","gravatar_id":"","url":"https://api.github.com/users/ksprashu","html_url":"https://github.com/ksprashu","followers_url":"https://api.github.com/users/ksprashu/followers","following_url":"https://api.github.com/users/ksprashu/following{/other_user}","gists_url":"https://api.github.com/users/ksprashu/gists{/gist_id}","starred_url":"https://api.github.com/users/ksprashu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksprashu/subscriptions","organizations_url":"https://api.github.com/users/ksprashu/orgs","repos_url":"https://api.github.com/users/ksprashu/repos","events_url":"https://api.github.com/users/ksprashu/events{/privacy}","received_events_url":"https://api.github.com/users/ksprashu/received_events","type":"User","site_admin":false},"position":14,"line":14,"path":"consent.js","commit_id":"6ffeab5ac470871d4857dd083cdf7f98ee1dcb91","created_at":"2016-11-03T09:24:23Z","updated_at":"2016-11-03T09:24:23Z","body":"There seems to be too many usage of new function(), unless really needed let us avoid that. \r\n\r\nWe could do like this\r\n\r\n// custom implementation is just an object instead of a constructor.\r\nvar customConsentImp = {\r\n  prepareCustom... : function () {},\r\n  customFn2: function () {},\r\n  customFn3: function () {}\r\n}\r\n\r\nmaybe this will fix the issue with the 'new' as well\r\n"}}
{"actor":{"display_login":"ksprashu"}}