{"push_id":1360503542,"size":2,"distinct_size":2,"ref":"refs/heads/master","head":"e1edb10dcc186895fcb2b56fb0e72be406188721","before":"31bb936cdedea4774ea5b035ada70746980ea0f5","commits":[{"sha":"874b6c4ccfb75ba8b15f90c74b9c68a009e50395","author":{"name":"Rick Lavoie","email":"20a9e6eabaf8dcd122edbecc1bf9d3e297707eb1@fb.com"},"message":"Fix inlining functions with iterators\n\nSummary:\nWhen processing frame-state changes for DefInlineFP, we were only adjusting the\nBC stack pointer by the number of locals, not including the number of\niterators. As a result, the iterators and a portion of the stack aliased each\nother.\n\nReviewed By: paulbiss\n\nDifferential Revision: D3851386\n\nfbshipit-source-id: 7c4c513e1eb505f0af76f6f81f0752fbff408981","distinct":true,"url":"https://api.github.com/repos/facebook/hhvm/commits/874b6c4ccfb75ba8b15f90c74b9c68a009e50395"},{"sha":"e1edb10dcc186895fcb2b56fb0e72be406188721","author":{"name":"Rick Lavoie","email":"20a9e6eabaf8dcd122edbecc1bf9d3e297707eb1@fb.com"},"message":"Improve Vcost heuristic for inlining\n\nSummary:\nWhen deciding to inline a callee or not, one of the factors is the\n\"cost\" of the inlined unit. This is done by generating the unit, and calculating\nits \"Vcost\". Along with the rough number of instructions, this includes whether\nor not the unit is \"complete\". Complete meaning that there's no bind or fallback\ninstructions in the main area. If the unit isn't complete, we assign it a\nmaximum weight, which effectively keeps it from being inlined. The idea is that\nwe don't want to inline callees which don't have a full region. However, this\ncompletion heuristic considers Vasm instructions such as bindcc and fallbackcc\nthe same as bind and fallback. However, these instructions are typically used as\nside-exits, and do not mean the unit is incomplete, even if on the main path. By\nremoving them we can inline more functions.\n\nReviewed By: paulbiss\n\nDifferential Revision: D3851561\n\nfbshipit-source-id: e5b99947f4ba75da87932da666486cf78ceafdf9","distinct":true,"url":"https://api.github.com/repos/facebook/hhvm/commits/e1edb10dcc186895fcb2b56fb0e72be406188721"}]}
{"actor":{"display_login":"hhvm-bot"}}