{"action":"created","comment":{"url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments/74726312","id":74726312,"diff_hunk":"@@ -0,0 +1,60 @@\n+// Copyright (c) 2016 Intel Corporation. All rights reserved.\n+// Use of this source code is governed by a BSD-style license that can be\n+// found in the LICENSE file.\n+\n+#ifndef XWALK_RUNTIME_COMMON_XWALK_RESOURCE_DELEGATE_H_\n+#define XWALK_RUNTIME_COMMON_XWALK_RESOURCE_DELEGATE_H_\n+\n+#include <memory>\n+#include <string>\n+#include <unordered_map>\n+\n+#include \"base/macros.h\"\n+#include \"base/memory/ref_counted_memory.h\"\n+#include \"ui/base/resource/resource_bundle.h\"\n+\n+namespace base {\n+class FilePath;\n+}\n+\n+namespace gfx {\n+class Image;\n+}\n+\n+namespace xwalk {\n+\n+// In Chrome,the locales path is set as \"locales/\" which potentially conflicts\n+// with it is in Crosswalk. So purpose of XWalkResourceDelegate is to set the\n+// locale pack path of Crosswalk as \"locales/xwalk/\".\n+class XWalkResourceDelegate : public ui::ResourceBundle::Delegate {\n+ public:\n+  // Returns the singleton of delegate. It doesn't create an instance.","path":"runtime/common/xwalk_resource_delegate.h","position":31,"original_position":31,"commit_id":"0cb853bb068443bf481f6f14d673551e616ac72d","original_commit_id":"0cb853bb068443bf481f6f14d673551e616ac72d","user":{"login":"heke123","id":3487569,"avatar_url":"https://avatars.githubusercontent.com/u/3487569?v=3","gravatar_id":"","url":"https://api.github.com/users/heke123","html_url":"https://github.com/heke123","followers_url":"https://api.github.com/users/heke123/followers","following_url":"https://api.github.com/users/heke123/following{/other_user}","gists_url":"https://api.github.com/users/heke123/gists{/gist_id}","starred_url":"https://api.github.com/users/heke123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heke123/subscriptions","organizations_url":"https://api.github.com/users/heke123/orgs","repos_url":"https://api.github.com/users/heke123/repos","events_url":"https://api.github.com/users/heke123/events{/privacy}","received_events_url":"https://api.github.com/users/heke123/received_events","type":"User","site_admin":false},"body":"Yes you are right, it is not referenced anywhere.  When I \"copy\" this part code from the src/chromecast, I noticed in cast_resource_delegate of the chromecast, the getinstance() is defined but not referenced either.  \r\nMy understanding is:  Since it is designed as a singleton pattern by using the g_instance member,  It is good to provide interface to get this instance. Although it is true we don't reference it so far. That's why I didn't remove it.","created_at":"2016-08-15T07:06:57Z","updated_at":"2016-08-15T07:06:57Z","html_url":"https://github.com/crosswalk-project/crosswalk/pull/3842#discussion_r74726312","pull_request_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/3842","_links":{"self":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments/74726312"},"html":{"href":"https://github.com/crosswalk-project/crosswalk/pull/3842#discussion_r74726312"},"pull_request":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/3842"}}},"pull_request":{"url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/3842","id":80423785,"html_url":"https://github.com/crosswalk-project/crosswalk/pull/3842","diff_url":"https://github.com/crosswalk-project/crosswalk/pull/3842.diff","patch_url":"https://github.com/crosswalk-project/crosswalk/pull/3842.patch","issue_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/3842","number":3842,"state":"open","locked":false,"title":"Change locale path from \"locales\" to \"locales/xwalk\"","user":{"login":"heke123","id":3487569,"avatar_url":"https://avatars.githubusercontent.com/u/3487569?v=3","gravatar_id":"","url":"https://api.github.com/users/heke123","html_url":"https://github.com/heke123","followers_url":"https://api.github.com/users/heke123/followers","following_url":"https://api.github.com/users/heke123/following{/other_user}","gists_url":"https://api.github.com/users/heke123/gists{/gist_id}","starred_url":"https://api.github.com/users/heke123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heke123/subscriptions","organizations_url":"https://api.github.com/users/heke123/orgs","repos_url":"https://api.github.com/users/heke123/repos","events_url":"https://api.github.com/users/heke123/events{/privacy}","received_events_url":"https://api.github.com/users/heke123/received_events","type":"User","site_admin":false},"body":"Both Crosswalk and Chrome they place the en-US.pak into folder\r\n\"locales\" in build of Linux and windows. Potientially there is\r\nconflicts, so it's better to set Crosswalk's locale-path as\r\n\"locales/xwalk\".\r\nAdd a \"xwalk_resource_delegate\" class which indicates the right\r\nlocale pack file to load for Crosswalk.","created_at":"2016-08-08T09:58:31Z","updated_at":"2016-08-15T07:06:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6750c8bd42343b7a11ed348f90a069c8337be229","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/3842/commits","review_comments_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/3842/comments","review_comment_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/3842/comments","statuses_url":"https://api.github.com/repos/crosswalk-project/crosswalk/statuses/0cb853bb068443bf481f6f14d673551e616ac72d","head":{"label":"heke123:set-locales","ref":"set-locales","sha":"0cb853bb068443bf481f6f14d673551e616ac72d","user":{"login":"heke123","id":3487569,"avatar_url":"https://avatars.githubusercontent.com/u/3487569?v=3","gravatar_id":"","url":"https://api.github.com/users/heke123","html_url":"https://github.com/heke123","followers_url":"https://api.github.com/users/heke123/followers","following_url":"https://api.github.com/users/heke123/following{/other_user}","gists_url":"https://api.github.com/users/heke123/gists{/gist_id}","starred_url":"https://api.github.com/users/heke123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heke123/subscriptions","organizations_url":"https://api.github.com/users/heke123/orgs","repos_url":"https://api.github.com/users/heke123/repos","events_url":"https://api.github.com/users/heke123/events{/privacy}","received_events_url":"https://api.github.com/users/heke123/received_events","type":"User","site_admin":false},"repo":{"id":56668949,"name":"crosswalk","full_name":"heke123/crosswalk","owner":{"login":"heke123","id":3487569,"avatar_url":"https://avatars.githubusercontent.com/u/3487569?v=3","gravatar_id":"","url":"https://api.github.com/users/heke123","html_url":"https://github.com/heke123","followers_url":"https://api.github.com/users/heke123/followers","following_url":"https://api.github.com/users/heke123/following{/other_user}","gists_url":"https://api.github.com/users/heke123/gists{/gist_id}","starred_url":"https://api.github.com/users/heke123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heke123/subscriptions","organizations_url":"https://api.github.com/users/heke123/orgs","repos_url":"https://api.github.com/users/heke123/repos","events_url":"https://api.github.com/users/heke123/events{/privacy}","received_events_url":"https://api.github.com/users/heke123/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/heke123/crosswalk","description":"","fork":true,"url":"https://api.github.com/repos/heke123/crosswalk","forks_url":"https://api.github.com/repos/heke123/crosswalk/forks","keys_url":"https://api.github.com/repos/heke123/crosswalk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heke123/crosswalk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heke123/crosswalk/teams","hooks_url":"https://api.github.com/repos/heke123/crosswalk/hooks","issue_events_url":"https://api.github.com/repos/heke123/crosswalk/issues/events{/number}","events_url":"https://api.github.com/repos/heke123/crosswalk/events","assignees_url":"https://api.github.com/repos/heke123/crosswalk/assignees{/user}","branches_url":"https://api.github.com/repos/heke123/crosswalk/branches{/branch}","tags_url":"https://api.github.com/repos/heke123/crosswalk/tags","blobs_url":"https://api.github.com/repos/heke123/crosswalk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heke123/crosswalk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heke123/crosswalk/git/refs{/sha}","trees_url":"https://api.github.com/repos/heke123/crosswalk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heke123/crosswalk/statuses/{sha}","languages_url":"https://api.github.com/repos/heke123/crosswalk/languages","stargazers_url":"https://api.github.com/repos/heke123/crosswalk/stargazers","contributors_url":"https://api.github.com/repos/heke123/crosswalk/contributors","subscribers_url":"https://api.github.com/repos/heke123/crosswalk/subscribers","subscription_url":"https://api.github.com/repos/heke123/crosswalk/subscription","commits_url":"https://api.github.com/repos/heke123/crosswalk/commits{/sha}","git_commits_url":"https://api.github.com/repos/heke123/crosswalk/git/commits{/sha}","comments_url":"https://api.github.com/repos/heke123/crosswalk/comments{/number}","issue_comment_url":"https://api.github.com/repos/heke123/crosswalk/issues/comments{/number}","contents_url":"https://api.github.com/repos/heke123/crosswalk/contents/{+path}","compare_url":"https://api.github.com/repos/heke123/crosswalk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heke123/crosswalk/merges","archive_url":"https://api.github.com/repos/heke123/crosswalk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heke123/crosswalk/downloads","issues_url":"https://api.github.com/repos/heke123/crosswalk/issues{/number}","pulls_url":"https://api.github.com/repos/heke123/crosswalk/pulls{/number}","milestones_url":"https://api.github.com/repos/heke123/crosswalk/milestones{/number}","notifications_url":"https://api.github.com/repos/heke123/crosswalk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heke123/crosswalk/labels{/name}","releases_url":"https://api.github.com/repos/heke123/crosswalk/releases{/id}","deployments_url":"https://api.github.com/repos/heke123/crosswalk/deployments","created_at":"2016-04-20T08:18:05Z","updated_at":"2016-04-20T08:18:09Z","pushed_at":"2016-08-12T09:59:03Z","git_url":"git://github.com/heke123/crosswalk.git","ssh_url":"git@github.com:heke123/crosswalk.git","clone_url":"https://github.com/heke123/crosswalk.git","svn_url":"https://github.com/heke123/crosswalk","homepage":"https://crosswalk-project.org/","size":17432,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"gyp-to-gn"}},"base":{"label":"crosswalk-project:master","ref":"master","sha":"d740eadc14b30a33d32f545787d2209035510650","user":{"login":"crosswalk-project","id":4867377,"avatar_url":"https://avatars.githubusercontent.com/u/4867377?v=3","gravatar_id":"","url":"https://api.github.com/users/crosswalk-project","html_url":"https://github.com/crosswalk-project","followers_url":"https://api.github.com/users/crosswalk-project/followers","following_url":"https://api.github.com/users/crosswalk-project/following{/other_user}","gists_url":"https://api.github.com/users/crosswalk-project/gists{/gist_id}","starred_url":"https://api.github.com/users/crosswalk-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosswalk-project/subscriptions","organizations_url":"https://api.github.com/users/crosswalk-project/orgs","repos_url":"https://api.github.com/users/crosswalk-project/repos","events_url":"https://api.github.com/users/crosswalk-project/events{/privacy}","received_events_url":"https://api.github.com/users/crosswalk-project/received_events","type":"Organization","site_admin":false},"repo":{"id":9207280,"name":"crosswalk","full_name":"crosswalk-project/crosswalk","owner":{"login":"crosswalk-project","id":4867377,"avatar_url":"https://avatars.githubusercontent.com/u/4867377?v=3","gravatar_id":"","url":"https://api.github.com/users/crosswalk-project","html_url":"https://github.com/crosswalk-project","followers_url":"https://api.github.com/users/crosswalk-project/followers","following_url":"https://api.github.com/users/crosswalk-project/following{/other_user}","gists_url":"https://api.github.com/users/crosswalk-project/gists{/gist_id}","starred_url":"https://api.github.com/users/crosswalk-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosswalk-project/subscriptions","organizations_url":"https://api.github.com/users/crosswalk-project/orgs","repos_url":"https://api.github.com/users/crosswalk-project/repos","events_url":"https://api.github.com/users/crosswalk-project/events{/privacy}","received_events_url":"https://api.github.com/users/crosswalk-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crosswalk-project/crosswalk","description":"","fork":false,"url":"https://api.github.com/repos/crosswalk-project/crosswalk","forks_url":"https://api.github.com/repos/crosswalk-project/crosswalk/forks","keys_url":"https://api.github.com/repos/crosswalk-project/crosswalk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crosswalk-project/crosswalk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crosswalk-project/crosswalk/teams","hooks_url":"https://api.github.com/repos/crosswalk-project/crosswalk/hooks","issue_events_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/events{/number}","events_url":"https://api.github.com/repos/crosswalk-project/crosswalk/events","assignees_url":"https://api.github.com/repos/crosswalk-project/crosswalk/assignees{/user}","branches_url":"https://api.github.com/repos/crosswalk-project/crosswalk/branches{/branch}","tags_url":"https://api.github.com/repos/crosswalk-project/crosswalk/tags","blobs_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/refs{/sha}","trees_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crosswalk-project/crosswalk/statuses/{sha}","languages_url":"https://api.github.com/repos/crosswalk-project/crosswalk/languages","stargazers_url":"https://api.github.com/repos/crosswalk-project/crosswalk/stargazers","contributors_url":"https://api.github.com/repos/crosswalk-project/crosswalk/contributors","subscribers_url":"https://api.github.com/repos/crosswalk-project/crosswalk/subscribers","subscription_url":"https://api.github.com/repos/crosswalk-project/crosswalk/subscription","commits_url":"https://api.github.com/repos/crosswalk-project/crosswalk/commits{/sha}","git_commits_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/commits{/sha}","comments_url":"https://api.github.com/repos/crosswalk-project/crosswalk/comments{/number}","issue_comment_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/comments{/number}","contents_url":"https://api.github.com/repos/crosswalk-project/crosswalk/contents/{+path}","compare_url":"https://api.github.com/repos/crosswalk-project/crosswalk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crosswalk-project/crosswalk/merges","archive_url":"https://api.github.com/repos/crosswalk-project/crosswalk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crosswalk-project/crosswalk/downloads","issues_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues{/number}","pulls_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls{/number}","milestones_url":"https://api.github.com/repos/crosswalk-project/crosswalk/milestones{/number}","notifications_url":"https://api.github.com/repos/crosswalk-project/crosswalk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crosswalk-project/crosswalk/labels{/name}","releases_url":"https://api.github.com/repos/crosswalk-project/crosswalk/releases{/id}","deployments_url":"https://api.github.com/repos/crosswalk-project/crosswalk/deployments","created_at":"2013-04-03T23:30:12Z","updated_at":"2016-08-15T01:13:11Z","pushed_at":"2016-08-15T06:21:32Z","git_url":"git://github.com/crosswalk-project/crosswalk.git","ssh_url":"git@github.com:crosswalk-project/crosswalk.git","clone_url":"https://github.com/crosswalk-project/crosswalk.git","svn_url":"https://github.com/crosswalk-project/crosswalk","homepage":"https://crosswalk-project.org/","size":125694,"stargazers_count":1529,"watchers_count":1529,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":391,"mirror_url":null,"open_issues_count":79,"forks":391,"open_issues":79,"watchers":1529,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/3842"},"html":{"href":"https://github.com/crosswalk-project/crosswalk/pull/3842"},"issue":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/3842"},"comments":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/3842/comments"},"review_comments":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/3842/comments"},"review_comment":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/3842/commits"},"statuses":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/statuses/0cb853bb068443bf481f6f14d673551e616ac72d"}}}}
{"actor":{"display_login":"heke123"}}