{"action":"created","issue":{"url":"https://api.github.com/repos/contao/image/issues/25","repository_url":"https://api.github.com/repos/contao/image","labels_url":"https://api.github.com/repos/contao/image/issues/25/labels{/name}","comments_url":"https://api.github.com/repos/contao/image/issues/25/comments","events_url":"https://api.github.com/repos/contao/image/issues/25/events","html_url":"https://github.com/contao/image/pull/25","id":190518110,"number":25,"title":"Use an optional image dimensions cache","user":{"login":"ausi","id":367169,"avatar_url":"https://avatars.githubusercontent.com/u/367169?v=3","gravatar_id":"","url":"https://api.github.com/users/ausi","html_url":"https://github.com/ausi","followers_url":"https://api.github.com/users/ausi/followers","following_url":"https://api.github.com/users/ausi/following{/other_user}","gists_url":"https://api.github.com/users/ausi/gists{/gist_id}","starred_url":"https://api.github.com/users/ausi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ausi/subscriptions","organizations_url":"https://api.github.com/users/ausi/orgs","repos_url":"https://api.github.com/users/ausi/repos","events_url":"https://api.github.com/users/ausi/events{/privacy}","received_events_url":"https://api.github.com/users/ausi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-11-19T20:23:15Z","updated_at":"2016-11-21T19:26:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/contao/image/pulls/25","html_url":"https://github.com/contao/image/pull/25","diff_url":"https://github.com/contao/image/pull/25.diff","patch_url":"https://github.com/contao/image/pull/25.patch"},"body":"A single request in Contao causes many (hundreds) calls to `Image::getDimensions()`, e.g. for every icon shown on a backend page. A cache for the dimensions off all images would be a big performance boost.\r\n\r\n@contao/developers does this implementation make sense that way?\r\nIf yes, I can make a pull request to the core-bundle to use the cache there."},"comment":{"url":"https://api.github.com/repos/contao/image/issues/comments/262040568","html_url":"https://github.com/contao/image/pull/25#issuecomment-262040568","issue_url":"https://api.github.com/repos/contao/image/issues/25","id":262040568,"user":{"login":"aschempp","id":1073273,"avatar_url":"https://avatars.githubusercontent.com/u/1073273?v=3","gravatar_id":"","url":"https://api.github.com/users/aschempp","html_url":"https://github.com/aschempp","followers_url":"https://api.github.com/users/aschempp/followers","following_url":"https://api.github.com/users/aschempp/following{/other_user}","gists_url":"https://api.github.com/users/aschempp/gists{/gist_id}","starred_url":"https://api.github.com/users/aschempp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aschempp/subscriptions","organizations_url":"https://api.github.com/users/aschempp/orgs","repos_url":"https://api.github.com/users/aschempp/repos","events_url":"https://api.github.com/users/aschempp/events{/privacy}","received_events_url":"https://api.github.com/users/aschempp/received_events","type":"User","site_admin":false},"created_at":"2016-11-21T19:26:34Z","updated_at":"2016-11-21T19:26:34Z","body":"The resizer uses the concrete class, so it knows the method is there. The interface is for injection and methods to use, setting the cache layer is not relevant for that."}}
{"actor":{"display_login":"aschempp"}}