{"action":"created","comment":{"url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/pulls/comments/78954099","id":78954099,"diff_hunk":"@@ -145,27 +145,31 @@ public HttpResponseMessage GetKeys(string dropLocation)\n             var fileName = string.Empty;\n             string username = null, password = null;\n \n-\n-            if (!dropLocation.StartsWith(\"\\\\\"))\n+            try\n             {\n-                // open volitle data.\n-                var volitleData = FileHelpers.ReadConfigAsData(\"volitleData.config\");\n-                var folderRoot = volitleData.Find(x => x.Contains(\"BUILD_FOLDER_ROOT\"));\n-                folderRoot = folderRoot.Substring(folderRoot.IndexOf(@\"\\\"));\n-                folderRoot = folderRoot.Replace(\"\\\"\", \"\");\n-                log.Add(\"....checking volitleData for build folder root \");\n-                dropLocation = folderRoot + @\"\\\" + dropLocation;\n-                if (!dropLocation.EndsWith(@\"\\\"))\n+                if (!dropLocation.StartsWith(\"\\\\\"))\n                 {\n-                    dropLocation = dropLocation + @\"\\\";\n+                    // open volitle data.\n+                    var volitleData = FileHelpers.ReadConfigAsData(\"volitleData.config\");\n+                    var folderRoot = volitleData.Find(x => x.Contains(\"BUILD_FOLDER_ROOT\"));\n+                    if (string.IsNullOrEmpty(folderRoot))\n+                    {\n+                        throw new Exception(\"BUILD_FOLDER_ROOT not set in config\");","path":"src/InstallerService/InstallerService/Daemon/Controllers/AvailableFeaturesController.cs","position":33,"original_position":33,"commit_id":"8837ec5f6f71ab0f6f2edcb3386ffc08c4eabd78","original_commit_id":"8837ec5f6f71ab0f6f2edcb3386ffc08c4eabd78","user":{"login":"jakebrown58","id":382808,"avatar_url":"https://avatars.githubusercontent.com/u/382808?v=3","gravatar_id":"","url":"https://api.github.com/users/jakebrown58","html_url":"https://github.com/jakebrown58","followers_url":"https://api.github.com/users/jakebrown58/followers","following_url":"https://api.github.com/users/jakebrown58/following{/other_user}","gists_url":"https://api.github.com/users/jakebrown58/gists{/gist_id}","starred_url":"https://api.github.com/users/jakebrown58/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakebrown58/subscriptions","organizations_url":"https://api.github.com/users/jakebrown58/orgs","repos_url":"https://api.github.com/users/jakebrown58/repos","events_url":"https://api.github.com/users/jakebrown58/events{/privacy}","received_events_url":"https://api.github.com/users/jakebrown58/received_events","type":"User","site_admin":false},"body":"What http response does this give if we throw an exception?\r\nWill this response be understandable to the consumer?\r\n\r\nWould be smart to split this logic into a helper and add tests, as this code is pretty squirrely.  (It's a complicated mess - I wrote it - Without Tests.    !Sorry!)","created_at":"2016-09-15T12:44:11Z","updated_at":"2016-09-15T12:45:41Z","html_url":"https://github.com/fti-technology/ringtail-deploy-service/pull/49#discussion_r78954099","pull_request_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/pulls/49","_links":{"self":{"href":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/pulls/comments/78954099"},"html":{"href":"https://github.com/fti-technology/ringtail-deploy-service/pull/49#discussion_r78954099"},"pull_request":{"href":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/pulls/49"}}},"pull_request":{"url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/pulls/49","id":85313633,"html_url":"https://github.com/fti-technology/ringtail-deploy-service/pull/49","diff_url":"https://github.com/fti-technology/ringtail-deploy-service/pull/49.diff","patch_url":"https://github.com/fti-technology/ringtail-deploy-service/pull/49.patch","issue_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/issues/49","number":49,"state":"open","locked":false,"title":"Json serialization","user":{"login":"jsnmc","id":361126,"avatar_url":"https://avatars.githubusercontent.com/u/361126?v=3","gravatar_id":"","url":"https://api.github.com/users/jsnmc","html_url":"https://github.com/jsnmc","followers_url":"https://api.github.com/users/jsnmc/followers","following_url":"https://api.github.com/users/jsnmc/following{/other_user}","gists_url":"https://api.github.com/users/jsnmc/gists{/gist_id}","starred_url":"https://api.github.com/users/jsnmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsnmc/subscriptions","organizations_url":"https://api.github.com/users/jsnmc/orgs","repos_url":"https://api.github.com/users/jsnmc/repos","events_url":"https://api.github.com/users/jsnmc/events{/privacy}","received_events_url":"https://api.github.com/users/jsnmc/received_events","type":"User","site_admin":false},"body":"Leverage the JavaScriptserializer to build up the json instead of building up the json from strings.\r\n(Bug: 272033 Feature keys - handle special characters in description field)","created_at":"2016-09-14T22:02:49Z","updated_at":"2016-09-15T12:45:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d20493e6545e4ef543be9d56344460b7b4c75f5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/pulls/49/commits","review_comments_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/pulls/49/comments","review_comment_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/issues/49/comments","statuses_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/statuses/8837ec5f6f71ab0f6f2edcb3386ffc08c4eabd78","head":{"label":"fti-technology:JSON_SERIALIZATION","ref":"JSON_SERIALIZATION","sha":"8837ec5f6f71ab0f6f2edcb3386ffc08c4eabd78","user":{"login":"fti-technology","id":10236764,"avatar_url":"https://avatars.githubusercontent.com/u/10236764?v=3","gravatar_id":"","url":"https://api.github.com/users/fti-technology","html_url":"https://github.com/fti-technology","followers_url":"https://api.github.com/users/fti-technology/followers","following_url":"https://api.github.com/users/fti-technology/following{/other_user}","gists_url":"https://api.github.com/users/fti-technology/gists{/gist_id}","starred_url":"https://api.github.com/users/fti-technology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fti-technology/subscriptions","organizations_url":"https://api.github.com/users/fti-technology/orgs","repos_url":"https://api.github.com/users/fti-technology/repos","events_url":"https://api.github.com/users/fti-technology/events{/privacy}","received_events_url":"https://api.github.com/users/fti-technology/received_events","type":"Organization","site_admin":false},"repo":{"id":30554299,"name":"ringtail-deploy-service","full_name":"fti-technology/ringtail-deploy-service","owner":{"login":"fti-technology","id":10236764,"avatar_url":"https://avatars.githubusercontent.com/u/10236764?v=3","gravatar_id":"","url":"https://api.github.com/users/fti-technology","html_url":"https://github.com/fti-technology","followers_url":"https://api.github.com/users/fti-technology/followers","following_url":"https://api.github.com/users/fti-technology/following{/other_user}","gists_url":"https://api.github.com/users/fti-technology/gists{/gist_id}","starred_url":"https://api.github.com/users/fti-technology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fti-technology/subscriptions","organizations_url":"https://api.github.com/users/fti-technology/orgs","repos_url":"https://api.github.com/users/fti-technology/repos","events_url":"https://api.github.com/users/fti-technology/events{/privacy}","received_events_url":"https://api.github.com/users/fti-technology/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fti-technology/ringtail-deploy-service","description":"Ringtail installation and deployment service","fork":false,"url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service","forks_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/forks","keys_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/teams","hooks_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/hooks","issue_events_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/issues/events{/number}","events_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/events","assignees_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/assignees{/user}","branches_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/branches{/branch}","tags_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/tags","blobs_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/statuses/{sha}","languages_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/languages","stargazers_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/stargazers","contributors_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/contributors","subscribers_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/subscribers","subscription_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/subscription","commits_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/contents/{+path}","compare_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/merges","archive_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/downloads","issues_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/issues{/number}","pulls_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/pulls{/number}","milestones_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/milestones{/number}","notifications_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/labels{/name}","releases_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/releases{/id}","deployments_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/deployments","created_at":"2015-02-09T19:34:25Z","updated_at":"2016-01-20T20:41:24Z","pushed_at":"2016-09-14T22:02:49Z","git_url":"git://github.com/fti-technology/ringtail-deploy-service.git","ssh_url":"git@github.com:fti-technology/ringtail-deploy-service.git","clone_url":"https://github.com/fti-technology/ringtail-deploy-service.git","svn_url":"https://github.com/fti-technology/ringtail-deploy-service","homepage":null,"size":2058,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":17,"forks":1,"open_issues":17,"watchers":1,"default_branch":"master"}},"base":{"label":"fti-technology:master","ref":"master","sha":"b318efe64723302f571e52e3358c3662a4e3fb08","user":{"login":"fti-technology","id":10236764,"avatar_url":"https://avatars.githubusercontent.com/u/10236764?v=3","gravatar_id":"","url":"https://api.github.com/users/fti-technology","html_url":"https://github.com/fti-technology","followers_url":"https://api.github.com/users/fti-technology/followers","following_url":"https://api.github.com/users/fti-technology/following{/other_user}","gists_url":"https://api.github.com/users/fti-technology/gists{/gist_id}","starred_url":"https://api.github.com/users/fti-technology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fti-technology/subscriptions","organizations_url":"https://api.github.com/users/fti-technology/orgs","repos_url":"https://api.github.com/users/fti-technology/repos","events_url":"https://api.github.com/users/fti-technology/events{/privacy}","received_events_url":"https://api.github.com/users/fti-technology/received_events","type":"Organization","site_admin":false},"repo":{"id":30554299,"name":"ringtail-deploy-service","full_name":"fti-technology/ringtail-deploy-service","owner":{"login":"fti-technology","id":10236764,"avatar_url":"https://avatars.githubusercontent.com/u/10236764?v=3","gravatar_id":"","url":"https://api.github.com/users/fti-technology","html_url":"https://github.com/fti-technology","followers_url":"https://api.github.com/users/fti-technology/followers","following_url":"https://api.github.com/users/fti-technology/following{/other_user}","gists_url":"https://api.github.com/users/fti-technology/gists{/gist_id}","starred_url":"https://api.github.com/users/fti-technology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fti-technology/subscriptions","organizations_url":"https://api.github.com/users/fti-technology/orgs","repos_url":"https://api.github.com/users/fti-technology/repos","events_url":"https://api.github.com/users/fti-technology/events{/privacy}","received_events_url":"https://api.github.com/users/fti-technology/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fti-technology/ringtail-deploy-service","description":"Ringtail installation and deployment service","fork":false,"url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service","forks_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/forks","keys_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/teams","hooks_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/hooks","issue_events_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/issues/events{/number}","events_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/events","assignees_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/assignees{/user}","branches_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/branches{/branch}","tags_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/tags","blobs_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/statuses/{sha}","languages_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/languages","stargazers_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/stargazers","contributors_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/contributors","subscribers_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/subscribers","subscription_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/subscription","commits_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/contents/{+path}","compare_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/merges","archive_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/downloads","issues_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/issues{/number}","pulls_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/pulls{/number}","milestones_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/milestones{/number}","notifications_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/labels{/name}","releases_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/releases{/id}","deployments_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/deployments","created_at":"2015-02-09T19:34:25Z","updated_at":"2016-01-20T20:41:24Z","pushed_at":"2016-09-14T22:02:49Z","git_url":"git://github.com/fti-technology/ringtail-deploy-service.git","ssh_url":"git@github.com:fti-technology/ringtail-deploy-service.git","clone_url":"https://github.com/fti-technology/ringtail-deploy-service.git","svn_url":"https://github.com/fti-technology/ringtail-deploy-service","homepage":null,"size":2058,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":17,"forks":1,"open_issues":17,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/pulls/49"},"html":{"href":"https://github.com/fti-technology/ringtail-deploy-service/pull/49"},"issue":{"href":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/issues/49"},"comments":{"href":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/fti-technology/ringtail-deploy-service/statuses/8837ec5f6f71ab0f6f2edcb3386ffc08c4eabd78"}}}}
{"actor":{"display_login":"jakebrown58"}}