{"action":"created","comment":{"url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/pulls/comments/68490639","id":68490639,"diff_hunk":"@@ -60,6 +60,26 @@ function FanMaster (numberOfExpectedFans) {\n             this.rescanForFans();\n         }\n     }.bind(this)\n+    */\n+        handleNewFan = function(msg, address) {\n+        if (msg[0] == \"ALL\") {\n+            return; // Message not addressed to us\n+        }\n+        if (msg[4] == \"FAN,LSERIES\") { //this is less than perfect, but at least allows a program to continue passed the onfanfullyupdated function when a wall control is present - obviously needs to not be LSERIES specfic - need a function to just look at the \"FAN\" part of that string\n+            \tvar newFan = new BigAssFan(msg[0], msg[3], address, this);\n+            \tthis.allFans[msg[0]] = newFan;\n+            \tthis.onFanConnection(newFan);\n+            \tnewFan.updateAll(function() {\n+                \tthis.onFanFullyUpdated(newFan)\n+            \t}.bind(this));\n+            }\n+        if (msg[4] == \"SWITCH,SENSEME\") {\n+            myLogWrapper(\"skipping wall control for now\")}\n+         else {","path":"BigAssApi.js","position":28,"original_position":28,"commit_id":"bbef79782d819c0579da61f8f609943bcd07e174","original_commit_id":"bbef79782d819c0579da61f8f609943bcd07e174","user":{"login":"sean9keenan","id":2107356,"avatar_url":"https://avatars.githubusercontent.com/u/2107356?v=3","gravatar_id":"","url":"https://api.github.com/users/sean9keenan","html_url":"https://github.com/sean9keenan","followers_url":"https://api.github.com/users/sean9keenan/followers","following_url":"https://api.github.com/users/sean9keenan/following{/other_user}","gists_url":"https://api.github.com/users/sean9keenan/gists{/gist_id}","starred_url":"https://api.github.com/users/sean9keenan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sean9keenan/subscriptions","organizations_url":"https://api.github.com/users/sean9keenan/orgs","repos_url":"https://api.github.com/users/sean9keenan/repos","events_url":"https://api.github.com/users/sean9keenan/events{/privacy}","received_events_url":"https://api.github.com/users/sean9keenan/received_events","type":"User","site_admin":false},"body":"Extra space before else","created_at":"2016-06-25T16:39:45Z","updated_at":"2016-06-25T16:39:45Z","html_url":"https://github.com/sean9keenan/BigAssFansAPI/pull/3#discussion_r68490639","pull_request_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/pulls/comments/68490639"},"html":{"href":"https://github.com/sean9keenan/BigAssFansAPI/pull/3#discussion_r68490639"},"pull_request":{"href":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/pulls/3","id":75194095,"html_url":"https://github.com/sean9keenan/BigAssFansAPI/pull/3","diff_url":"https://github.com/sean9keenan/BigAssFansAPI/pull/3.diff","patch_url":"https://github.com/sean9keenan/BigAssFansAPI/pull/3.patch","issue_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/issues/3","number":3,"state":"open","locked":false,"title":"Fixing API Calls","user":{"login":"pedroserano","id":12992264,"avatar_url":"https://avatars.githubusercontent.com/u/12992264?v=3","gravatar_id":"","url":"https://api.github.com/users/pedroserano","html_url":"https://github.com/pedroserano","followers_url":"https://api.github.com/users/pedroserano/followers","following_url":"https://api.github.com/users/pedroserano/following{/other_user}","gists_url":"https://api.github.com/users/pedroserano/gists{/gist_id}","starred_url":"https://api.github.com/users/pedroserano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedroserano/subscriptions","organizations_url":"https://api.github.com/users/pedroserano/orgs","repos_url":"https://api.github.com/users/pedroserano/repos","events_url":"https://api.github.com/users/pedroserano/events{/privacy}","received_events_url":"https://api.github.com/users/pedroserano/received_events","type":"User","site_admin":false},"body":"\"CURR\" is not valid for light brightness and fan speed, the call is \"ACTUAL\". For fan direction in reverse, it's \"REV\", rather than \"BKW\".","created_at":"2016-06-25T03:04:18Z","updated_at":"2016-06-25T16:39:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0bf66918c87bac685df71d28ec10bf46ecdea53c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/pulls/3/commits","review_comments_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/pulls/3/comments","review_comment_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/issues/3/comments","statuses_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/statuses/bbef79782d819c0579da61f8f609943bcd07e174","head":{"label":"pedroserano:master","ref":"master","sha":"bbef79782d819c0579da61f8f609943bcd07e174","user":{"login":"pedroserano","id":12992264,"avatar_url":"https://avatars.githubusercontent.com/u/12992264?v=3","gravatar_id":"","url":"https://api.github.com/users/pedroserano","html_url":"https://github.com/pedroserano","followers_url":"https://api.github.com/users/pedroserano/followers","following_url":"https://api.github.com/users/pedroserano/following{/other_user}","gists_url":"https://api.github.com/users/pedroserano/gists{/gist_id}","starred_url":"https://api.github.com/users/pedroserano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedroserano/subscriptions","organizations_url":"https://api.github.com/users/pedroserano/orgs","repos_url":"https://api.github.com/users/pedroserano/repos","events_url":"https://api.github.com/users/pedroserano/events{/privacy}","received_events_url":"https://api.github.com/users/pedroserano/received_events","type":"User","site_admin":false},"repo":{"id":61923973,"name":"BigAssFansAPI","full_name":"pedroserano/BigAssFansAPI","owner":{"login":"pedroserano","id":12992264,"avatar_url":"https://avatars.githubusercontent.com/u/12992264?v=3","gravatar_id":"","url":"https://api.github.com/users/pedroserano","html_url":"https://github.com/pedroserano","followers_url":"https://api.github.com/users/pedroserano/followers","following_url":"https://api.github.com/users/pedroserano/following{/other_user}","gists_url":"https://api.github.com/users/pedroserano/gists{/gist_id}","starred_url":"https://api.github.com/users/pedroserano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedroserano/subscriptions","organizations_url":"https://api.github.com/users/pedroserano/orgs","repos_url":"https://api.github.com/users/pedroserano/repos","events_url":"https://api.github.com/users/pedroserano/events{/privacy}","received_events_url":"https://api.github.com/users/pedroserano/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pedroserano/BigAssFansAPI","description":"Unofficial API for Big Ass Fans!","fork":true,"url":"https://api.github.com/repos/pedroserano/BigAssFansAPI","forks_url":"https://api.github.com/repos/pedroserano/BigAssFansAPI/forks","keys_url":"https://api.github.com/repos/pedroserano/BigAssFansAPI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pedroserano/BigAssFansAPI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pedroserano/BigAssFansAPI/teams","hooks_url":"https://api.github.com/repos/pedroserano/BigAssFansAPI/hooks","issue_events_url":"https://api.github.com/repos/pedroserano/BigAssFansAPI/issues/events{/number}","events_url":"https://api.github.com/repos/pedroserano/BigAssFansAPI/events","assignees_url":"https://api.github.com/repos/pedroserano/BigAssFansAPI/assignees{/user}","branches_url":"https://api.github.com/repos/pedroserano/BigAssFansAPI/branches{/branch}","tags_url":"https://api.github.com/repos/pedroserano/BigAssFansAPI/tags","blobs_url":"https://api.github.com/repos/pedroserano/BigAssFansAPI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pedroserano/BigAssFansAPI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pedroserano/BigAssFansAPI/git/refs{/sha}","trees_url":"https://api.github.com/repos/pedroserano/BigAssFansAPI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pedroserano/BigAssFansAPI/statuses/{sha}","languages_url":"https://api.github.com/repos/pedroserano/BigAssFansAPI/languages","stargazers_url":"https://api.github.com/repos/pedroserano/BigAssFansAPI/stargazers","contributors_url":"https://api.github.com/repos/pedroserano/BigAssFansAPI/contributors","subscribers_url":"https://api.github.com/repos/pedroserano/BigAssFansAPI/subscribers","subscription_url":"https://api.github.com/repos/pedroserano/BigAssFansAPI/subscription","commits_url":"https://api.github.com/repos/pedroserano/BigAssFansAPI/commits{/sha}","git_commits_url":"https://api.github.com/repos/pedroserano/BigAssFansAPI/git/commits{/sha}","comments_url":"https://api.github.com/repos/pedroserano/BigAssFansAPI/comments{/number}","issue_comment_url":"https://api.github.com/repos/pedroserano/BigAssFansAPI/issues/comments{/number}","contents_url":"https://api.github.com/repos/pedroserano/BigAssFansAPI/contents/{+path}","compare_url":"https://api.github.com/repos/pedroserano/BigAssFansAPI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pedroserano/BigAssFansAPI/merges","archive_url":"https://api.github.com/repos/pedroserano/BigAssFansAPI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pedroserano/BigAssFansAPI/downloads","issues_url":"https://api.github.com/repos/pedroserano/BigAssFansAPI/issues{/number}","pulls_url":"https://api.github.com/repos/pedroserano/BigAssFansAPI/pulls{/number}","milestones_url":"https://api.github.com/repos/pedroserano/BigAssFansAPI/milestones{/number}","notifications_url":"https://api.github.com/repos/pedroserano/BigAssFansAPI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pedroserano/BigAssFansAPI/labels{/name}","releases_url":"https://api.github.com/repos/pedroserano/BigAssFansAPI/releases{/id}","deployments_url":"https://api.github.com/repos/pedroserano/BigAssFansAPI/deployments","created_at":"2016-06-25T02:54:05Z","updated_at":"2016-06-25T02:54:06Z","pushed_at":"2016-06-25T14:49:52Z","git_url":"git://github.com/pedroserano/BigAssFansAPI.git","ssh_url":"git@github.com:pedroserano/BigAssFansAPI.git","clone_url":"https://github.com/pedroserano/BigAssFansAPI.git","svn_url":"https://github.com/pedroserano/BigAssFansAPI","homepage":null,"size":16,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sean9keenan:master","ref":"master","sha":"4c9f0011e17326d859763dde3f59b9af66e02def","user":{"login":"sean9keenan","id":2107356,"avatar_url":"https://avatars.githubusercontent.com/u/2107356?v=3","gravatar_id":"","url":"https://api.github.com/users/sean9keenan","html_url":"https://github.com/sean9keenan","followers_url":"https://api.github.com/users/sean9keenan/followers","following_url":"https://api.github.com/users/sean9keenan/following{/other_user}","gists_url":"https://api.github.com/users/sean9keenan/gists{/gist_id}","starred_url":"https://api.github.com/users/sean9keenan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sean9keenan/subscriptions","organizations_url":"https://api.github.com/users/sean9keenan/orgs","repos_url":"https://api.github.com/users/sean9keenan/repos","events_url":"https://api.github.com/users/sean9keenan/events{/privacy}","received_events_url":"https://api.github.com/users/sean9keenan/received_events","type":"User","site_admin":false},"repo":{"id":39365322,"name":"BigAssFansAPI","full_name":"sean9keenan/BigAssFansAPI","owner":{"login":"sean9keenan","id":2107356,"avatar_url":"https://avatars.githubusercontent.com/u/2107356?v=3","gravatar_id":"","url":"https://api.github.com/users/sean9keenan","html_url":"https://github.com/sean9keenan","followers_url":"https://api.github.com/users/sean9keenan/followers","following_url":"https://api.github.com/users/sean9keenan/following{/other_user}","gists_url":"https://api.github.com/users/sean9keenan/gists{/gist_id}","starred_url":"https://api.github.com/users/sean9keenan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sean9keenan/subscriptions","organizations_url":"https://api.github.com/users/sean9keenan/orgs","repos_url":"https://api.github.com/users/sean9keenan/repos","events_url":"https://api.github.com/users/sean9keenan/events{/privacy}","received_events_url":"https://api.github.com/users/sean9keenan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sean9keenan/BigAssFansAPI","description":"Unofficial API for Big Ass Fans!","fork":false,"url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI","forks_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/forks","keys_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/teams","hooks_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/hooks","issue_events_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/issues/events{/number}","events_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/events","assignees_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/assignees{/user}","branches_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/branches{/branch}","tags_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/tags","blobs_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/git/refs{/sha}","trees_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/statuses/{sha}","languages_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/languages","stargazers_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/stargazers","contributors_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/contributors","subscribers_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/subscribers","subscription_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/subscription","commits_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/commits{/sha}","git_commits_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/git/commits{/sha}","comments_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/comments{/number}","issue_comment_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/issues/comments{/number}","contents_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/contents/{+path}","compare_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/merges","archive_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/downloads","issues_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/issues{/number}","pulls_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/pulls{/number}","milestones_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/milestones{/number}","notifications_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/labels{/name}","releases_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/releases{/id}","deployments_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/deployments","created_at":"2015-07-20T05:43:37Z","updated_at":"2016-06-24T17:50:01Z","pushed_at":"2016-06-25T14:49:52Z","git_url":"git://github.com/sean9keenan/BigAssFansAPI.git","ssh_url":"git@github.com:sean9keenan/BigAssFansAPI.git","clone_url":"https://github.com/sean9keenan/BigAssFansAPI.git","svn_url":"https://github.com/sean9keenan/BigAssFansAPI","homepage":null,"size":148,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/pulls/3"},"html":{"href":"https://github.com/sean9keenan/BigAssFansAPI/pull/3"},"issue":{"href":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/issues/3"},"comments":{"href":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/statuses/bbef79782d819c0579da61f8f609943bcd07e174"}}}}
{"actor":{"display_login":"sean9keenan"}}