{"action":"created","issue":{"url":"https://api.github.com/repos/Teradata/presto/issues/458","repository_url":"https://api.github.com/repos/Teradata/presto","labels_url":"https://api.github.com/repos/Teradata/presto/issues/458/labels{/name}","comments_url":"https://api.github.com/repos/Teradata/presto/issues/458/comments","events_url":"https://api.github.com/repos/Teradata/presto/issues/458/events","html_url":"https://github.com/Teradata/presto/pull/458","id":193218602,"number":458,"title":" Add product tests to verify owner privileges","user":{"login":"amrutagokhale","id":9261099,"avatar_url":"https://avatars.githubusercontent.com/u/9261099?v=3","gravatar_id":"","url":"https://api.github.com/users/amrutagokhale","html_url":"https://github.com/amrutagokhale","followers_url":"https://api.github.com/users/amrutagokhale/followers","following_url":"https://api.github.com/users/amrutagokhale/following{/other_user}","gists_url":"https://api.github.com/users/amrutagokhale/gists{/gist_id}","starred_url":"https://api.github.com/users/amrutagokhale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amrutagokhale/subscriptions","organizations_url":"https://api.github.com/users/amrutagokhale/orgs","repos_url":"https://api.github.com/users/amrutagokhale/repos","events_url":"https://api.github.com/users/amrutagokhale/events{/privacy}","received_events_url":"https://api.github.com/users/amrutagokhale/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-02T21:10:38Z","updated_at":"2016-12-21T14:54:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Teradata/presto/pulls/458","html_url":"https://github.com/Teradata/presto/pull/458","diff_url":"https://github.com/Teradata/presto/pull/458.diff","patch_url":"https://github.com/Teradata/presto/pull/458.patch"},"body":"Add product tests to verify that the owner of a table/view has the `SELECT`, `INSERT`, `UPDATE` and `DELETE` privileges.\r\n\r\nThese tests are for the commits that fixed a bug: \r\nhttps://github.com/prestodb/presto/commit/29319c52954f9b874de625c124e18209e573f44b\r\nhttps://github.com/prestodb/presto/commit/fc36eff0dc985f06ac030b75b7746ad6ffdd84ae\r\n\r\nI chose to use `SHOW GRANTS` for verifying the privileges, since there is no way to perform an `UPDATE` operation, if we go via the path of verifying the privileges by checking whether the owner can perform those operations."},"comment":{"url":"https://api.github.com/repos/Teradata/presto/issues/comments/268542006","html_url":"https://github.com/Teradata/presto/pull/458#issuecomment-268542006","issue_url":"https://api.github.com/repos/Teradata/presto/issues/458","id":268542006,"user":{"login":"amrutagokhale","id":9261099,"avatar_url":"https://avatars.githubusercontent.com/u/9261099?v=3","gravatar_id":"","url":"https://api.github.com/users/amrutagokhale","html_url":"https://github.com/amrutagokhale","followers_url":"https://api.github.com/users/amrutagokhale/followers","following_url":"https://api.github.com/users/amrutagokhale/following{/other_user}","gists_url":"https://api.github.com/users/amrutagokhale/gists{/gist_id}","starred_url":"https://api.github.com/users/amrutagokhale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amrutagokhale/subscriptions","organizations_url":"https://api.github.com/users/amrutagokhale/orgs","repos_url":"https://api.github.com/users/amrutagokhale/repos","events_url":"https://api.github.com/users/amrutagokhale/events{/privacy}","received_events_url":"https://api.github.com/users/amrutagokhale/received_events","type":"User","site_admin":false},"created_at":"2016-12-21T14:54:59Z","updated_at":"2016-12-21T14:54:59Z","body":"I have updated the product test to use the `SHOW GRANT` command from Hive. \r\nNote: \r\n* The `DOCKER_IMAGES_VERSION` is temporary; I will update it to the appropriate release version once those docker images are pushed.\r\n* Certain column values of `SHOW GRANT` command are not relevant or cannot be pre-computed (such as the timestamp at which grant was give). So I am skipping such columns when comparing results.\r\n* Even thought the PR is against TD release version, I will merge it to the sprint branch instead."}}
{"actor":{"display_login":"amrutagokhale"}}