{"action":"created","issue":{"url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/2047","repository_url":"https://api.github.com/repos/hpcugent/easybuild-framework","labels_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/2047/labels{/name}","comments_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/2047/comments","events_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/2047/events","html_url":"https://github.com/hpcugent/easybuild-framework/pull/2047","id":194121106,"number":2047,"title":"add 'rpath' toolchain option to selectively disable use of RPATH wrappers","user":{"login":"boegel","id":620876,"avatar_url":"https://avatars.githubusercontent.com/u/620876?v=3","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/hpcugent/easybuild-framework/milestones/42","html_url":"https://github.com/hpcugent/easybuild-framework/milestone/42","labels_url":"https://api.github.com/repos/hpcugent/easybuild-framework/milestones/42/labels","id":2171167,"number":42,"title":"3.0.2","description":"","creator":{"login":"boegel","id":620876,"avatar_url":"https://avatars.githubusercontent.com/u/620876?v=3","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":5,"state":"open","created_at":"2016-12-02T13:46:49Z","updated_at":"2016-12-09T15:24:39Z","due_on":"2016-12-14T00:00:00Z","closed_at":null},"comments":3,"created_at":"2016-12-07T17:57:22Z","updated_at":"2016-12-09T21:21:23Z","closed_at":"2016-12-09T15:24:39Z","pull_request":{"url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/2047","html_url":"https://github.com/hpcugent/easybuild-framework/pull/2047","diff_url":"https://github.com/hpcugent/easybuild-framework/pull/2047.diff","patch_url":"https://github.com/hpcugent/easybuild-framework/pull/2047.patch"},"body":"@pescobar this probably works, but needs to be tested. Can you give it a try?\r\n\r\nI'll also look into a dedicated test for this."},"comment":{"url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/comments/266126762","html_url":"https://github.com/hpcugent/easybuild-framework/pull/2047#issuecomment-266126762","issue_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/2047","id":266126762,"user":{"login":"boegel","id":620876,"avatar_url":"https://avatars.githubusercontent.com/u/620876?v=3","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"created_at":"2016-12-09T21:21:23Z","updated_at":"2016-12-09T21:21:23Z","body":"@pescobar urgh, indeed, the RPATH sanity check should of course also be checked if no RPATH'ing was done...\r\n\r\nTry this patch?\r\n\r\n```diff\r\ndiff --git a/easybuild/framework/easyblock.py b/easybuild/framework/easyblock.py\r\nindex dbce5c3..8aa5cb3 100644\r\n--- a/easybuild/framework/easyblock.py\r\n+++ b/easybuild/framework/easyblock.py\r\n@@ -1982,7 +1982,7 @@ class EasyBlock(object):\r\n         else:\r\n             self.dry_run_msg(\"  (none)\")\r\n \r\n-        if build_option('rpath'):\r\n+        if build_option('rpath') and self.toolchain.options.get('rpath', True):\r\n             self.sanity_check_rpath()\r\n \r\n     def _sanity_check_step(self, custom_paths=None, custom_commands=None, extension=False):\r\n\r\n```"}}
{"actor":{"display_login":"boegel"}}