{"action":"created","issue":{"url":"https://api.github.com/repos/jaywink/ansible-letsencrypt/issues/10","repository_url":"https://api.github.com/repos/jaywink/ansible-letsencrypt","labels_url":"https://api.github.com/repos/jaywink/ansible-letsencrypt/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/jaywink/ansible-letsencrypt/issues/10/comments","events_url":"https://api.github.com/repos/jaywink/ansible-letsencrypt/issues/10/events","html_url":"https://github.com/jaywink/ansible-letsencrypt/pull/10","id":175229978,"number":10,"title":"Do not install apache2","user":{"login":"gronke","id":473924,"avatar_url":"https://avatars.githubusercontent.com/u/473924?v=3","gravatar_id":"","url":"https://api.github.com/users/gronke","html_url":"https://github.com/gronke","followers_url":"https://api.github.com/users/gronke/followers","following_url":"https://api.github.com/users/gronke/following{/other_user}","gists_url":"https://api.github.com/users/gronke/gists{/gist_id}","starred_url":"https://api.github.com/users/gronke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gronke/subscriptions","organizations_url":"https://api.github.com/users/gronke/orgs","repos_url":"https://api.github.com/users/gronke/repos","events_url":"https://api.github.com/users/gronke/events{/privacy}","received_events_url":"https://api.github.com/users/gronke/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-06T12:03:57Z","updated_at":"2016-09-06T19:00:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jaywink/ansible-letsencrypt/pulls/10","html_url":"https://github.com/jaywink/ansible-letsencrypt/pull/10","diff_url":"https://github.com/jaywink/ansible-letsencrypt/pull/10.diff","patch_url":"https://github.com/jaywink/ansible-letsencrypt/pull/10.patch"},"body":"Installing apache2 as dependency was legacy before merging #4 - without apache2 being is installed this role would fail with it's default configuration, but the `ignore_errors: yes` option allows us to just skip about that."},"comment":{"url":"https://api.github.com/repos/jaywink/ansible-letsencrypt/issues/comments/245054456","html_url":"https://github.com/jaywink/ansible-letsencrypt/pull/10#issuecomment-245054456","issue_url":"https://api.github.com/repos/jaywink/ansible-letsencrypt/issues/10","id":245054456,"user":{"login":"jaywink","id":1174866,"avatar_url":"https://avatars.githubusercontent.com/u/1174866?v=3","gravatar_id":"","url":"https://api.github.com/users/jaywink","html_url":"https://github.com/jaywink","followers_url":"https://api.github.com/users/jaywink/followers","following_url":"https://api.github.com/users/jaywink/following{/other_user}","gists_url":"https://api.github.com/users/jaywink/gists{/gist_id}","starred_url":"https://api.github.com/users/jaywink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaywink/subscriptions","organizations_url":"https://api.github.com/users/jaywink/orgs","repos_url":"https://api.github.com/users/jaywink/repos","events_url":"https://api.github.com/users/jaywink/events{/privacy}","received_events_url":"https://api.github.com/users/jaywink/received_events","type":"User","site_admin":false},"created_at":"2016-09-06T19:00:48Z","updated_at":"2016-09-06T19:00:48Z","body":"The danger with ignoring errors, for the restart of services in this case, is that the role would silently go about forward and the server might be left with the services not started. The error might not even be related, but I think it's a dangerous road if the role doesn't crash - thus notifying of a problem.\r\n\r\nHow about this. If the stopping of services fails, then the starting is skipped (since this makes the assumption the service is unknown)? This way the initial run (before main app role) would breeze through and future runs would not risk services being left stopped after stopping them.\r\n\r\nI agree `apache2` should be removed from the requirements. We could remove it and add to the readme a note that any services listed in `letsencrypt_pause_services` should be installed. Even better, `letsencrypt_pause_services` could itself be initially empty with an installation note and example in the readme to note that the role should be configured with the correct web server in this list. Would that make sense?"}}
{"actor":{"display_login":"jaywink"}}