{"action":"created","issue":{"url":"https://api.github.com/repos/ethcore/parity/issues/3768","repository_url":"https://api.github.com/repos/ethcore/parity","labels_url":"https://api.github.com/repos/ethcore/parity/issues/3768/labels{/name}","comments_url":"https://api.github.com/repos/ethcore/parity/issues/3768/comments","events_url":"https://api.github.com/repos/ethcore/parity/issues/3768/events","html_url":"https://github.com/ethcore/parity/pull/3768","id":194584905,"number":3768,"title":"get certifications from BadgeReg, show them in accounts overview","user":{"login":"derhuerst","id":5072613,"avatar_url":"https://avatars.githubusercontent.com/u/5072613?v=3","gravatar_id":"","url":"https://api.github.com/users/derhuerst","html_url":"https://github.com/derhuerst","followers_url":"https://api.github.com/users/derhuerst/followers","following_url":"https://api.github.com/users/derhuerst/following{/other_user}","gists_url":"https://api.github.com/users/derhuerst/gists{/gist_id}","starred_url":"https://api.github.com/users/derhuerst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derhuerst/subscriptions","organizations_url":"https://api.github.com/users/derhuerst/orgs","repos_url":"https://api.github.com/users/derhuerst/repos","events_url":"https://api.github.com/users/derhuerst/events{/privacy}","received_events_url":"https://api.github.com/users/derhuerst/received_events","type":"User","site_admin":false},"labels":[{"id":312492515,"url":"https://api.github.com/repos/ethcore/parity/labels/A6-mustntgrumble","name":"A6-mustntgrumble","color":"fef2c0","default":false},{"id":441816465,"url":"https://api.github.com/repos/ethcore/parity/labels/M7-ui","name":"M7-ui","color":"eaefff","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-12-09T12:26:32Z","updated_at":"2016-12-15T13:49:51Z","closed_at":"2016-12-15T13:43:05Z","pull_request":{"url":"https://api.github.com/repos/ethcore/parity/pulls/3768","html_url":"https://github.com/ethcore/parity/pull/3768","diff_url":"https://github.com/ethcore/parity/pull/3768.diff","patch_url":"https://github.com/ethcore/parity/pull/3768.patch"},"body":"The PR makes the certifications/badges show up in the accounts overview and in the address book.\r\n\r\nTriggered by the action `fetchCertifiers`, it uses [`BadgeReg.sol`](https://github.com/ethcore/contracts/blob/2fbb19d/BadgeReg.sol) to fetch the addresses & metadata of all certifiers (contracts issuing certifications/badges). It then uses a filter to check for [`Confirmed` events](https://github.com/ethcore/contracts/blob/d3213cd/Certifier.sol#L8).\r\n\r\n![badges](https://cloud.githubusercontent.com/assets/5072613/21049062/ecf41a3c-be12-11e6-87f1-a782024c82e2.png)\r\n\r\nStill to do:\r\n\r\n- ~~Listen for [`Revoked`](https://github.com/ethcore/contracts/blob/d3213cd/Certifier.sol#L9) and remove the certification.~~\r\n- Consider renaming \"certifications\" to \"badges\". I kept it compatible with the rest of the code for now."},"comment":{"url":"https://api.github.com/repos/ethcore/parity/issues/comments/267331495","html_url":"https://github.com/ethcore/parity/pull/3768#issuecomment-267331495","issue_url":"https://api.github.com/repos/ethcore/parity/issues/3768","id":267331495,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-12-15T13:49:51Z","updated_at":"2016-12-15T13:49:51Z","body":"\n[![Coverage Status](https://coveralls.io/builds/9296400/badge)](https://coveralls.io/builds/9296400)\n\nCoverage increased (+0.3%) to 85.859% when pulling **4c42dedcad11969a58cf381cc0328da7db770817 on jr-use-badge-reg** into **03db4d0373d48cb36d3ad5fe3ec8575951a99562 on master**.\n"}}
{"actor":{"display_login":"coveralls"}}