{"action":"closed","number":333,"pull_request":{"url":"https://api.github.com/repos/cibernox/ember-power-select/pulls/333","id":61025322,"html_url":"https://github.com/cibernox/ember-power-select/pull/333","diff_url":"https://github.com/cibernox/ember-power-select/pull/333.diff","patch_url":"https://github.com/cibernox/ember-power-select/pull/333.patch","issue_url":"https://api.github.com/repos/cibernox/ember-power-select/issues/333","number":333,"state":"closed","locked":false,"title":"Seperated handleKeyDown into seperate overridable methods","user":{"login":"cah-briangantzler","id":1529286,"avatar_url":"https://avatars.githubusercontent.com/u/1529286?v=3","gravatar_id":"","url":"https://api.github.com/users/cah-briangantzler","html_url":"https://github.com/cah-briangantzler","followers_url":"https://api.github.com/users/cah-briangantzler/followers","following_url":"https://api.github.com/users/cah-briangantzler/following{/other_user}","gists_url":"https://api.github.com/users/cah-briangantzler/gists{/gist_id}","starred_url":"https://api.github.com/users/cah-briangantzler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cah-briangantzler/subscriptions","organizations_url":"https://api.github.com/users/cah-briangantzler/orgs","repos_url":"https://api.github.com/users/cah-briangantzler/repos","events_url":"https://api.github.com/users/cah-briangantzler/events{/privacy}","received_events_url":"https://api.github.com/users/cah-briangantzler/received_events","type":"User","site_admin":false},"body":"I would like to implement a selectOnTab property to allow the option to be selected when tabbed. It appeared I had to override the entire handleKeyDown action, but this was problematic based on the action keydown, if I did my code first, the action wouldn't fire.\r\n\r\nIt would be easier to just override the key I wanted to handle. To do this I split out the handling of each key into a method that could be overridden in an extended class.\r\n\r\nThis pull request does nothing but split the handling into those methods.\r\n\r\nOnce accepted I will follow up with a PR for implementing the selectOnTab. I did not include it in this request as I think this request would be useful to anyone extending the class and gives you the opportunity to not to take the selectOnTab functionally while still giving me the ability to implement it.","created_at":"2016-02-29T04:04:11Z","updated_at":"2016-02-29T15:53:16Z","closed_at":"2016-02-29T15:53:16Z","merged_at":"2016-02-29T15:53:16Z","merge_commit_sha":"fcae2fd8b123ab3cb01833627a1acee7ead92ad7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cibernox/ember-power-select/pulls/333/commits","review_comments_url":"https://api.github.com/repos/cibernox/ember-power-select/pulls/333/comments","review_comment_url":"https://api.github.com/repos/cibernox/ember-power-select/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cibernox/ember-power-select/issues/333/comments","statuses_url":"https://api.github.com/repos/cibernox/ember-power-select/statuses/c8c187c448e4edb4718d2fcbc575cb93bc8e52ef","head":{"label":"cahcommercial:master","ref":"master","sha":"c8c187c448e4edb4718d2fcbc575cb93bc8e52ef","user":{"login":"cahcommercial","id":1528901,"avatar_url":"https://avatars.githubusercontent.com/u/1528901?v=3","gravatar_id":"","url":"https://api.github.com/users/cahcommercial","html_url":"https://github.com/cahcommercial","followers_url":"https://api.github.com/users/cahcommercial/followers","following_url":"https://api.github.com/users/cahcommercial/following{/other_user}","gists_url":"https://api.github.com/users/cahcommercial/gists{/gist_id}","starred_url":"https://api.github.com/users/cahcommercial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cahcommercial/subscriptions","organizations_url":"https://api.github.com/users/cahcommercial/orgs","repos_url":"https://api.github.com/users/cahcommercial/repos","events_url":"https://api.github.com/users/cahcommercial/events{/privacy}","received_events_url":"https://api.github.com/users/cahcommercial/received_events","type":"Organization","site_admin":false},"repo":{"id":52761887,"name":"ember-power-select","full_name":"cahcommercial/ember-power-select","owner":{"login":"cahcommercial","id":1528901,"avatar_url":"https://avatars.githubusercontent.com/u/1528901?v=3","gravatar_id":"","url":"https://api.github.com/users/cahcommercial","html_url":"https://github.com/cahcommercial","followers_url":"https://api.github.com/users/cahcommercial/followers","following_url":"https://api.github.com/users/cahcommercial/following{/other_user}","gists_url":"https://api.github.com/users/cahcommercial/gists{/gist_id}","starred_url":"https://api.github.com/users/cahcommercial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cahcommercial/subscriptions","organizations_url":"https://api.github.com/users/cahcommercial/orgs","repos_url":"https://api.github.com/users/cahcommercial/repos","events_url":"https://api.github.com/users/cahcommercial/events{/privacy}","received_events_url":"https://api.github.com/users/cahcommercial/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cahcommercial/ember-power-select","description":"The extensible select component built for ember.","fork":true,"url":"https://api.github.com/repos/cahcommercial/ember-power-select","forks_url":"https://api.github.com/repos/cahcommercial/ember-power-select/forks","keys_url":"https://api.github.com/repos/cahcommercial/ember-power-select/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cahcommercial/ember-power-select/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cahcommercial/ember-power-select/teams","hooks_url":"https://api.github.com/repos/cahcommercial/ember-power-select/hooks","issue_events_url":"https://api.github.com/repos/cahcommercial/ember-power-select/issues/events{/number}","events_url":"https://api.github.com/repos/cahcommercial/ember-power-select/events","assignees_url":"https://api.github.com/repos/cahcommercial/ember-power-select/assignees{/user}","branches_url":"https://api.github.com/repos/cahcommercial/ember-power-select/branches{/branch}","tags_url":"https://api.github.com/repos/cahcommercial/ember-power-select/tags","blobs_url":"https://api.github.com/repos/cahcommercial/ember-power-select/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cahcommercial/ember-power-select/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cahcommercial/ember-power-select/git/refs{/sha}","trees_url":"https://api.github.com/repos/cahcommercial/ember-power-select/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cahcommercial/ember-power-select/statuses/{sha}","languages_url":"https://api.github.com/repos/cahcommercial/ember-power-select/languages","stargazers_url":"https://api.github.com/repos/cahcommercial/ember-power-select/stargazers","contributors_url":"https://api.github.com/repos/cahcommercial/ember-power-select/contributors","subscribers_url":"https://api.github.com/repos/cahcommercial/ember-power-select/subscribers","subscription_url":"https://api.github.com/repos/cahcommercial/ember-power-select/subscription","commits_url":"https://api.github.com/repos/cahcommercial/ember-power-select/commits{/sha}","git_commits_url":"https://api.github.com/repos/cahcommercial/ember-power-select/git/commits{/sha}","comments_url":"https://api.github.com/repos/cahcommercial/ember-power-select/comments{/number}","issue_comment_url":"https://api.github.com/repos/cahcommercial/ember-power-select/issues/comments{/number}","contents_url":"https://api.github.com/repos/cahcommercial/ember-power-select/contents/{+path}","compare_url":"https://api.github.com/repos/cahcommercial/ember-power-select/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cahcommercial/ember-power-select/merges","archive_url":"https://api.github.com/repos/cahcommercial/ember-power-select/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cahcommercial/ember-power-select/downloads","issues_url":"https://api.github.com/repos/cahcommercial/ember-power-select/issues{/number}","pulls_url":"https://api.github.com/repos/cahcommercial/ember-power-select/pulls{/number}","milestones_url":"https://api.github.com/repos/cahcommercial/ember-power-select/milestones{/number}","notifications_url":"https://api.github.com/repos/cahcommercial/ember-power-select/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cahcommercial/ember-power-select/labels{/name}","releases_url":"https://api.github.com/repos/cahcommercial/ember-power-select/releases{/id}","deployments_url":"https://api.github.com/repos/cahcommercial/ember-power-select/deployments","created_at":"2016-02-29T03:38:57Z","updated_at":"2016-02-29T03:38:58Z","pushed_at":"2016-02-29T03:58:29Z","git_url":"git://github.com/cahcommercial/ember-power-select.git","ssh_url":"git@github.com:cahcommercial/ember-power-select.git","clone_url":"https://github.com/cahcommercial/ember-power-select.git","svn_url":"https://github.com/cahcommercial/ember-power-select","homepage":"http://www.ember-power-select.com","size":1222,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cibernox:master","ref":"master","sha":"c4096a3374bc6c6cb8c37b5b51b4ad1f5d55943e","user":{"login":"cibernox","id":265339,"avatar_url":"https://avatars.githubusercontent.com/u/265339?v=3","gravatar_id":"","url":"https://api.github.com/users/cibernox","html_url":"https://github.com/cibernox","followers_url":"https://api.github.com/users/cibernox/followers","following_url":"https://api.github.com/users/cibernox/following{/other_user}","gists_url":"https://api.github.com/users/cibernox/gists{/gist_id}","starred_url":"https://api.github.com/users/cibernox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cibernox/subscriptions","organizations_url":"https://api.github.com/users/cibernox/orgs","repos_url":"https://api.github.com/users/cibernox/repos","events_url":"https://api.github.com/users/cibernox/events{/privacy}","received_events_url":"https://api.github.com/users/cibernox/received_events","type":"User","site_admin":false},"repo":{"id":43177821,"name":"ember-power-select","full_name":"cibernox/ember-power-select","owner":{"login":"cibernox","id":265339,"avatar_url":"https://avatars.githubusercontent.com/u/265339?v=3","gravatar_id":"","url":"https://api.github.com/users/cibernox","html_url":"https://github.com/cibernox","followers_url":"https://api.github.com/users/cibernox/followers","following_url":"https://api.github.com/users/cibernox/following{/other_user}","gists_url":"https://api.github.com/users/cibernox/gists{/gist_id}","starred_url":"https://api.github.com/users/cibernox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cibernox/subscriptions","organizations_url":"https://api.github.com/users/cibernox/orgs","repos_url":"https://api.github.com/users/cibernox/repos","events_url":"https://api.github.com/users/cibernox/events{/privacy}","received_events_url":"https://api.github.com/users/cibernox/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cibernox/ember-power-select","description":"The extensible select component built for ember.","fork":false,"url":"https://api.github.com/repos/cibernox/ember-power-select","forks_url":"https://api.github.com/repos/cibernox/ember-power-select/forks","keys_url":"https://api.github.com/repos/cibernox/ember-power-select/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cibernox/ember-power-select/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cibernox/ember-power-select/teams","hooks_url":"https://api.github.com/repos/cibernox/ember-power-select/hooks","issue_events_url":"https://api.github.com/repos/cibernox/ember-power-select/issues/events{/number}","events_url":"https://api.github.com/repos/cibernox/ember-power-select/events","assignees_url":"https://api.github.com/repos/cibernox/ember-power-select/assignees{/user}","branches_url":"https://api.github.com/repos/cibernox/ember-power-select/branches{/branch}","tags_url":"https://api.github.com/repos/cibernox/ember-power-select/tags","blobs_url":"https://api.github.com/repos/cibernox/ember-power-select/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cibernox/ember-power-select/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cibernox/ember-power-select/git/refs{/sha}","trees_url":"https://api.github.com/repos/cibernox/ember-power-select/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cibernox/ember-power-select/statuses/{sha}","languages_url":"https://api.github.com/repos/cibernox/ember-power-select/languages","stargazers_url":"https://api.github.com/repos/cibernox/ember-power-select/stargazers","contributors_url":"https://api.github.com/repos/cibernox/ember-power-select/contributors","subscribers_url":"https://api.github.com/repos/cibernox/ember-power-select/subscribers","subscription_url":"https://api.github.com/repos/cibernox/ember-power-select/subscription","commits_url":"https://api.github.com/repos/cibernox/ember-power-select/commits{/sha}","git_commits_url":"https://api.github.com/repos/cibernox/ember-power-select/git/commits{/sha}","comments_url":"https://api.github.com/repos/cibernox/ember-power-select/comments{/number}","issue_comment_url":"https://api.github.com/repos/cibernox/ember-power-select/issues/comments{/number}","contents_url":"https://api.github.com/repos/cibernox/ember-power-select/contents/{+path}","compare_url":"https://api.github.com/repos/cibernox/ember-power-select/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cibernox/ember-power-select/merges","archive_url":"https://api.github.com/repos/cibernox/ember-power-select/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cibernox/ember-power-select/downloads","issues_url":"https://api.github.com/repos/cibernox/ember-power-select/issues{/number}","pulls_url":"https://api.github.com/repos/cibernox/ember-power-select/pulls{/number}","milestones_url":"https://api.github.com/repos/cibernox/ember-power-select/milestones{/number}","notifications_url":"https://api.github.com/repos/cibernox/ember-power-select/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cibernox/ember-power-select/labels{/name}","releases_url":"https://api.github.com/repos/cibernox/ember-power-select/releases{/id}","deployments_url":"https://api.github.com/repos/cibernox/ember-power-select/deployments","created_at":"2015-09-25T22:10:36Z","updated_at":"2016-02-27T15:06:38Z","pushed_at":"2016-02-29T15:53:16Z","git_url":"git://github.com/cibernox/ember-power-select.git","ssh_url":"git@github.com:cibernox/ember-power-select.git","clone_url":"https://github.com/cibernox/ember-power-select.git","svn_url":"https://github.com/cibernox/ember-power-select","homepage":"http://www.ember-power-select.com","size":1238,"stargazers_count":163,"watchers_count":163,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":28,"forks":42,"open_issues":28,"watchers":163,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cibernox/ember-power-select/pulls/333"},"html":{"href":"https://github.com/cibernox/ember-power-select/pull/333"},"issue":{"href":"https://api.github.com/repos/cibernox/ember-power-select/issues/333"},"comments":{"href":"https://api.github.com/repos/cibernox/ember-power-select/issues/333/comments"},"review_comments":{"href":"https://api.github.com/repos/cibernox/ember-power-select/pulls/333/comments"},"review_comment":{"href":"https://api.github.com/repos/cibernox/ember-power-select/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cibernox/ember-power-select/pulls/333/commits"},"statuses":{"href":"https://api.github.com/repos/cibernox/ember-power-select/statuses/c8c187c448e4edb4718d2fcbc575cb93bc8e52ef"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"cibernox","id":265339,"avatar_url":"https://avatars.githubusercontent.com/u/265339?v=3","gravatar_id":"","url":"https://api.github.com/users/cibernox","html_url":"https://github.com/cibernox","followers_url":"https://api.github.com/users/cibernox/followers","following_url":"https://api.github.com/users/cibernox/following{/other_user}","gists_url":"https://api.github.com/users/cibernox/gists{/gist_id}","starred_url":"https://api.github.com/users/cibernox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cibernox/subscriptions","organizations_url":"https://api.github.com/users/cibernox/orgs","repos_url":"https://api.github.com/users/cibernox/repos","events_url":"https://api.github.com/users/cibernox/events{/privacy}","received_events_url":"https://api.github.com/users/cibernox/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":32,"deletions":12,"changed_files":1}}