{"action":"closed","number":4019,"pull_request":{"url":"https://api.github.com/repos/dlang/phobos/pulls/4019","id":60655820,"html_url":"https://github.com/dlang/phobos/pull/4019","diff_url":"https://github.com/dlang/phobos/pull/4019.diff","patch_url":"https://github.com/dlang/phobos/pull/4019.patch","issue_url":"https://api.github.com/repos/dlang/phobos/issues/4019","number":4019,"state":"closed","locked":false,"title":"min/max with keyfunction + for a single range","user":{"login":"wilzbach","id":4370550,"avatar_url":"https://avatars.githubusercontent.com/u/4370550?v=3","gravatar_id":"","url":"https://api.github.com/users/wilzbach","html_url":"https://github.com/wilzbach","followers_url":"https://api.github.com/users/wilzbach/followers","following_url":"https://api.github.com/users/wilzbach/following{/other_user}","gists_url":"https://api.github.com/users/wilzbach/gists{/gist_id}","starred_url":"https://api.github.com/users/wilzbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilzbach/subscriptions","organizations_url":"https://api.github.com/users/wilzbach/orgs","repos_url":"https://api.github.com/users/wilzbach/repos","events_url":"https://api.github.com/users/wilzbach/events{/privacy}","received_events_url":"https://api.github.com/users/wilzbach/received_events","type":"User","site_admin":false},"body":"Hey all,\r\n\r\nthis PR allows the `min`/`max` function to be used with a single range and with a custom key getter.\r\nThis topic has been mentioned quite often (e.g. [Issue 4705](https://issues.dlang.org/show_bug.cgi?id=4705)), however imho the solution is trivial.\r\n\r\nWhy is this cool? Because with this we can do a couple of useful queries - most notably `argMin/argMax`, e.g.\r\n\r\n```\r\nassert([5,2,4].enumerate.min!\"a[1]\".index == 1);\r\n```\r\n(see the tests for more examples)\r\n\r\nA couple of comments\r\n\r\n1) I am still new to D - so please let me know your comments about the code ;-)\r\n2) I didn't know how I should change the function ddox header for `min/max` as ","created_at":"2016-02-25T10:25:38Z","updated_at":"2016-04-20T00:10:04Z","closed_at":"2016-04-20T00:10:04Z","merged_at":null,"merge_commit_sha":"859ec6c5200f6b10472d2062514d35fa915ec060","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dlang/phobos/pulls/4019/commits","review_comments_url":"https://api.github.com/repos/dlang/phobos/pulls/4019/comments","review_comment_url":"https://api.github.com/repos/dlang/phobos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dlang/phobos/issues/4019/comments","statuses_url":"https://api.github.com/repos/dlang/phobos/statuses/dee39ba30874ee4b1d9d7ea1b83cb14be9907a51","head":{"label":"wilzbach:min_max","ref":"min_max","sha":"dee39ba30874ee4b1d9d7ea1b83cb14be9907a51","user":{"login":"wilzbach","id":4370550,"avatar_url":"https://avatars.githubusercontent.com/u/4370550?v=3","gravatar_id":"","url":"https://api.github.com/users/wilzbach","html_url":"https://github.com/wilzbach","followers_url":"https://api.github.com/users/wilzbach/followers","following_url":"https://api.github.com/users/wilzbach/following{/other_user}","gists_url":"https://api.github.com/users/wilzbach/gists{/gist_id}","starred_url":"https://api.github.com/users/wilzbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilzbach/subscriptions","organizations_url":"https://api.github.com/users/wilzbach/orgs","repos_url":"https://api.github.com/users/wilzbach/repos","events_url":"https://api.github.com/users/wilzbach/events{/privacy}","received_events_url":"https://api.github.com/users/wilzbach/received_events","type":"User","site_admin":false},"repo":{"id":52009651,"name":"phobos","full_name":"wilzbach/phobos","owner":{"login":"wilzbach","id":4370550,"avatar_url":"https://avatars.githubusercontent.com/u/4370550?v=3","gravatar_id":"","url":"https://api.github.com/users/wilzbach","html_url":"https://github.com/wilzbach","followers_url":"https://api.github.com/users/wilzbach/followers","following_url":"https://api.github.com/users/wilzbach/following{/other_user}","gists_url":"https://api.github.com/users/wilzbach/gists{/gist_id}","starred_url":"https://api.github.com/users/wilzbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilzbach/subscriptions","organizations_url":"https://api.github.com/users/wilzbach/orgs","repos_url":"https://api.github.com/users/wilzbach/repos","events_url":"https://api.github.com/users/wilzbach/events{/privacy}","received_events_url":"https://api.github.com/users/wilzbach/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wilzbach/phobos","description":"The standard library of the D programming language","fork":true,"url":"https://api.github.com/repos/wilzbach/phobos","forks_url":"https://api.github.com/repos/wilzbach/phobos/forks","keys_url":"https://api.github.com/repos/wilzbach/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wilzbach/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wilzbach/phobos/teams","hooks_url":"https://api.github.com/repos/wilzbach/phobos/hooks","issue_events_url":"https://api.github.com/repos/wilzbach/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/wilzbach/phobos/events","assignees_url":"https://api.github.com/repos/wilzbach/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/wilzbach/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/wilzbach/phobos/tags","blobs_url":"https://api.github.com/repos/wilzbach/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wilzbach/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wilzbach/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/wilzbach/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wilzbach/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/wilzbach/phobos/languages","stargazers_url":"https://api.github.com/repos/wilzbach/phobos/stargazers","contributors_url":"https://api.github.com/repos/wilzbach/phobos/contributors","subscribers_url":"https://api.github.com/repos/wilzbach/phobos/subscribers","subscription_url":"https://api.github.com/repos/wilzbach/phobos/subscription","commits_url":"https://api.github.com/repos/wilzbach/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/wilzbach/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/wilzbach/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/wilzbach/phobos/issues/comments{/number}","contents_url":"https://api.github.com/repos/wilzbach/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/wilzbach/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wilzbach/phobos/merges","archive_url":"https://api.github.com/repos/wilzbach/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wilzbach/phobos/downloads","issues_url":"https://api.github.com/repos/wilzbach/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/wilzbach/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/wilzbach/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/wilzbach/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wilzbach/phobos/labels{/name}","releases_url":"https://api.github.com/repos/wilzbach/phobos/releases{/id}","deployments_url":"https://api.github.com/repos/wilzbach/phobos/deployments","created_at":"2016-02-18T13:38:55Z","updated_at":"2016-03-08T13:03:37Z","pushed_at":"2016-04-20T00:07:49Z","git_url":"git://github.com/wilzbach/phobos.git","ssh_url":"git@github.com:wilzbach/phobos.git","clone_url":"https://github.com/wilzbach/phobos.git","svn_url":"https://github.com/wilzbach/phobos","homepage":"dlang.org/phobos","size":47463,"stargazers_count":1,"watchers_count":1,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dlang:master","ref":"master","sha":"d90273a86a21b02ed6a41bbc8cfde9b2c78deee2","user":{"login":"dlang","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"repo":{"id":1257084,"name":"phobos","full_name":"dlang/phobos","owner":{"login":"dlang","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dlang/phobos","description":"The standard library of the D programming language","fork":false,"url":"https://api.github.com/repos/dlang/phobos","forks_url":"https://api.github.com/repos/dlang/phobos/forks","keys_url":"https://api.github.com/repos/dlang/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dlang/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dlang/phobos/teams","hooks_url":"https://api.github.com/repos/dlang/phobos/hooks","issue_events_url":"https://api.github.com/repos/dlang/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/dlang/phobos/events","assignees_url":"https://api.github.com/repos/dlang/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/dlang/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/dlang/phobos/tags","blobs_url":"https://api.github.com/repos/dlang/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dlang/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dlang/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/dlang/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dlang/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/dlang/phobos/languages","stargazers_url":"https://api.github.com/repos/dlang/phobos/stargazers","contributors_url":"https://api.github.com/repos/dlang/phobos/contributors","subscribers_url":"https://api.github.com/repos/dlang/phobos/subscribers","subscription_url":"https://api.github.com/repos/dlang/phobos/subscription","commits_url":"https://api.github.com/repos/dlang/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/dlang/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/dlang/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/dlang/phobos/issues/comments{/number}","contents_url":"https://api.github.com/repos/dlang/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/dlang/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dlang/phobos/merges","archive_url":"https://api.github.com/repos/dlang/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dlang/phobos/downloads","issues_url":"https://api.github.com/repos/dlang/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/dlang/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/dlang/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/dlang/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dlang/phobos/labels{/name}","releases_url":"https://api.github.com/repos/dlang/phobos/releases{/id}","deployments_url":"https://api.github.com/repos/dlang/phobos/deployments","created_at":"2011-01-15T07:00:06Z","updated_at":"2016-04-19T12:12:53Z","pushed_at":"2016-04-20T00:08:04Z","git_url":"git://github.com/dlang/phobos.git","ssh_url":"git@github.com:dlang/phobos.git","clone_url":"https://github.com/dlang/phobos.git","svn_url":"https://github.com/dlang/phobos","homepage":"dlang.org/phobos","size":75081,"stargazers_count":700,"watchers_count":700,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":474,"mirror_url":null,"open_issues_count":92,"forks":474,"open_issues":92,"watchers":700,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dlang/phobos/pulls/4019"},"html":{"href":"https://github.com/dlang/phobos/pull/4019"},"issue":{"href":"https://api.github.com/repos/dlang/phobos/issues/4019"},"comments":{"href":"https://api.github.com/repos/dlang/phobos/issues/4019/comments"},"review_comments":{"href":"https://api.github.com/repos/dlang/phobos/pulls/4019/comments"},"review_comment":{"href":"https://api.github.com/repos/dlang/phobos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dlang/phobos/pulls/4019/commits"},"statuses":{"href":"https://api.github.com/repos/dlang/phobos/statuses/dee39ba30874ee4b1d9d7ea1b83cb14be9907a51"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":30,"review_comments":24,"commits":1,"additions":192,"deletions":0,"changed_files":3}}