{"action":"created","issue":{"url":"https://api.github.com/repos/RTICWDT/open-data-maker/issues/6","repository_url":"https://api.github.com/repos/RTICWDT/open-data-maker","labels_url":"https://api.github.com/repos/RTICWDT/open-data-maker/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/RTICWDT/open-data-maker/issues/6/comments","events_url":"https://api.github.com/repos/RTICWDT/open-data-maker/issues/6/events","html_url":"https://github.com/RTICWDT/open-data-maker/pull/6","id":169685841,"number":6,"title":"Check for multiple s3 key names for using the s3_bucket_service","user":{"login":"kynetiv","id":3484017,"avatar_url":"https://avatars.githubusercontent.com/u/3484017?v=3","gravatar_id":"","url":"https://api.github.com/users/kynetiv","html_url":"https://github.com/kynetiv","followers_url":"https://api.github.com/users/kynetiv/followers","following_url":"https://api.github.com/users/kynetiv/following{/other_user}","gists_url":"https://api.github.com/users/kynetiv/gists{/gist_id}","starred_url":"https://api.github.com/users/kynetiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kynetiv/subscriptions","organizations_url":"https://api.github.com/users/kynetiv/orgs","repos_url":"https://api.github.com/users/kynetiv/repos","events_url":"https://api.github.com/users/kynetiv/events{/privacy}","received_events_url":"https://api.github.com/users/kynetiv/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-05T20:05:50Z","updated_at":"2016-08-29T14:28:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/RTICWDT/open-data-maker/pulls/6","html_url":"https://github.com/RTICWDT/open-data-maker/pull/6","diff_url":"https://github.com/RTICWDT/open-data-maker/pull/6.diff","patch_url":"https://github.com/RTICWDT/open-data-maker/pull/6.patch"},"body":"This PR updates how we provision the s3 client by allowing the credentials to be completely set in the environment, even if running in cloud foundry. This helps when we are using different kinds of services instances (`user-provided` or `s3`) and keys are stored in different places, with different names.\r\n\r\nThis also checks to see if the credentials are set in another key, to allow for an s3 client provided by an  `s3` cloud foundry service instance."},"comment":{"url":"https://api.github.com/repos/RTICWDT/open-data-maker/issues/comments/243140368","html_url":"https://github.com/RTICWDT/open-data-maker/pull/6#issuecomment-243140368","issue_url":"https://api.github.com/repos/RTICWDT/open-data-maker/issues/6","id":243140368,"user":{"login":"kynetiv","id":3484017,"avatar_url":"https://avatars.githubusercontent.com/u/3484017?v=3","gravatar_id":"","url":"https://api.github.com/users/kynetiv","html_url":"https://github.com/kynetiv","followers_url":"https://api.github.com/users/kynetiv/followers","following_url":"https://api.github.com/users/kynetiv/following{/other_user}","gists_url":"https://api.github.com/users/kynetiv/gists{/gist_id}","starred_url":"https://api.github.com/users/kynetiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kynetiv/subscriptions","organizations_url":"https://api.github.com/users/kynetiv/orgs","repos_url":"https://api.github.com/users/kynetiv/repos","events_url":"https://api.github.com/users/kynetiv/events{/privacy}","received_events_url":"https://api.github.com/users/kynetiv/received_events","type":"User","site_admin":false},"created_at":"2016-08-29T14:28:22Z","updated_at":"2016-08-29T14:28:22Z","body":"I've simplified this PR to utilize the existing `s3_bucket_service` environment variable if we want to specify a bucket other than one named `bservice`. Either service found will then check for the applicable keys in the two ways they come (depending on if using the `s3 basic` bucket service or any existing ad hoc bucket services). \r\n\r\nThe newer `s3` service uses the keys `access_key_id` & `secret_access_key` which have now been added in this PR."}}
{"actor":{"display_login":"kynetiv"}}