{"action":"closed","number":351,"pull_request":{"url":"https://api.github.com/repos/spotify/docker-client/pulls/351","id":59840685,"html_url":"https://github.com/spotify/docker-client/pull/351","diff_url":"https://github.com/spotify/docker-client/pull/351.diff","patch_url":"https://github.com/spotify/docker-client/pull/351.patch","issue_url":"https://api.github.com/repos/spotify/docker-client/issues/351","number":351,"state":"closed","locked":false,"title":"Add 'Tty' flag for the execStart call.","user":{"login":"rgrunber","id":1417342,"avatar_url":"https://avatars.githubusercontent.com/u/1417342?v=3","gravatar_id":"","url":"https://api.github.com/users/rgrunber","html_url":"https://github.com/rgrunber","followers_url":"https://api.github.com/users/rgrunber/followers","following_url":"https://api.github.com/users/rgrunber/following{/other_user}","gists_url":"https://api.github.com/users/rgrunber/gists{/gist_id}","starred_url":"https://api.github.com/users/rgrunber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgrunber/subscriptions","organizations_url":"https://api.github.com/users/rgrunber/orgs","repos_url":"https://api.github.com/users/rgrunber/repos","events_url":"https://api.github.com/users/rgrunber/events{/privacy}","received_events_url":"https://api.github.com/users/rgrunber/received_events","type":"User","site_admin":false},"body":"The Docker reference implementation for the remote api passes 'Tty' to\r\nboth 'Exec Create' and 'Exec Start' when the '-t' option is supplied to\r\n'docker exec' so the option should exist in both cases.\r\n\r\nIf you look in https://github.com/docker/docker/blob/master/api/client/exec.go#L51 , you'll see this to be the case. Without the option it's still possible to interact with some shell, but some characters that have special meaning in the shell (carriage return, tab, ctrl+c) don't seem to be interpreted correctly.","created_at":"2016-02-18T18:17:55Z","updated_at":"2016-03-01T18:26:03Z","closed_at":"2016-03-01T18:26:03Z","merged_at":"2016-03-01T18:26:03Z","merge_commit_sha":"40575dfcef68c99bc3994e00b2c2d92e93ec63b2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spotify/docker-client/pulls/351/commits","review_comments_url":"https://api.github.com/repos/spotify/docker-client/pulls/351/comments","review_comment_url":"https://api.github.com/repos/spotify/docker-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spotify/docker-client/issues/351/comments","statuses_url":"https://api.github.com/repos/spotify/docker-client/statuses/40715905c4c5aa77db9ac620098b25a1919c3997","head":{"label":"rgrunber:tty-execstart","ref":"tty-execstart","sha":"40715905c4c5aa77db9ac620098b25a1919c3997","user":{"login":"rgrunber","id":1417342,"avatar_url":"https://avatars.githubusercontent.com/u/1417342?v=3","gravatar_id":"","url":"https://api.github.com/users/rgrunber","html_url":"https://github.com/rgrunber","followers_url":"https://api.github.com/users/rgrunber/followers","following_url":"https://api.github.com/users/rgrunber/following{/other_user}","gists_url":"https://api.github.com/users/rgrunber/gists{/gist_id}","starred_url":"https://api.github.com/users/rgrunber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgrunber/subscriptions","organizations_url":"https://api.github.com/users/rgrunber/orgs","repos_url":"https://api.github.com/users/rgrunber/repos","events_url":"https://api.github.com/users/rgrunber/events{/privacy}","received_events_url":"https://api.github.com/users/rgrunber/received_events","type":"User","site_admin":false},"repo":{"id":26975518,"name":"docker-client","full_name":"rgrunber/docker-client","owner":{"login":"rgrunber","id":1417342,"avatar_url":"https://avatars.githubusercontent.com/u/1417342?v=3","gravatar_id":"","url":"https://api.github.com/users/rgrunber","html_url":"https://github.com/rgrunber","followers_url":"https://api.github.com/users/rgrunber/followers","following_url":"https://api.github.com/users/rgrunber/following{/other_user}","gists_url":"https://api.github.com/users/rgrunber/gists{/gist_id}","starred_url":"https://api.github.com/users/rgrunber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgrunber/subscriptions","organizations_url":"https://api.github.com/users/rgrunber/orgs","repos_url":"https://api.github.com/users/rgrunber/repos","events_url":"https://api.github.com/users/rgrunber/events{/privacy}","received_events_url":"https://api.github.com/users/rgrunber/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rgrunber/docker-client","description":"A simple docker client for the JVM","fork":true,"url":"https://api.github.com/repos/rgrunber/docker-client","forks_url":"https://api.github.com/repos/rgrunber/docker-client/forks","keys_url":"https://api.github.com/repos/rgrunber/docker-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rgrunber/docker-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rgrunber/docker-client/teams","hooks_url":"https://api.github.com/repos/rgrunber/docker-client/hooks","issue_events_url":"https://api.github.com/repos/rgrunber/docker-client/issues/events{/number}","events_url":"https://api.github.com/repos/rgrunber/docker-client/events","assignees_url":"https://api.github.com/repos/rgrunber/docker-client/assignees{/user}","branches_url":"https://api.github.com/repos/rgrunber/docker-client/branches{/branch}","tags_url":"https://api.github.com/repos/rgrunber/docker-client/tags","blobs_url":"https://api.github.com/repos/rgrunber/docker-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rgrunber/docker-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rgrunber/docker-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/rgrunber/docker-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rgrunber/docker-client/statuses/{sha}","languages_url":"https://api.github.com/repos/rgrunber/docker-client/languages","stargazers_url":"https://api.github.com/repos/rgrunber/docker-client/stargazers","contributors_url":"https://api.github.com/repos/rgrunber/docker-client/contributors","subscribers_url":"https://api.github.com/repos/rgrunber/docker-client/subscribers","subscription_url":"https://api.github.com/repos/rgrunber/docker-client/subscription","commits_url":"https://api.github.com/repos/rgrunber/docker-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/rgrunber/docker-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/rgrunber/docker-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/rgrunber/docker-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/rgrunber/docker-client/contents/{+path}","compare_url":"https://api.github.com/repos/rgrunber/docker-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rgrunber/docker-client/merges","archive_url":"https://api.github.com/repos/rgrunber/docker-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rgrunber/docker-client/downloads","issues_url":"https://api.github.com/repos/rgrunber/docker-client/issues{/number}","pulls_url":"https://api.github.com/repos/rgrunber/docker-client/pulls{/number}","milestones_url":"https://api.github.com/repos/rgrunber/docker-client/milestones{/number}","notifications_url":"https://api.github.com/repos/rgrunber/docker-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rgrunber/docker-client/labels{/name}","releases_url":"https://api.github.com/repos/rgrunber/docker-client/releases{/id}","deployments_url":"https://api.github.com/repos/rgrunber/docker-client/deployments","created_at":"2014-11-21T19:54:08Z","updated_at":"2016-02-18T14:58:28Z","pushed_at":"2016-02-23T17:01:20Z","git_url":"git://github.com/rgrunber/docker-client.git","ssh_url":"git@github.com:rgrunber/docker-client.git","clone_url":"https://github.com/rgrunber/docker-client.git","svn_url":"https://github.com/rgrunber/docker-client","homepage":"","size":1078,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spotify:master","ref":"master","sha":"98c29b907ea2926d3a83f24a33798dda57974ce2","user":{"login":"spotify","id":251374,"avatar_url":"https://avatars.githubusercontent.com/u/251374?v=3","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"repo":{"id":20484506,"name":"docker-client","full_name":"spotify/docker-client","owner":{"login":"spotify","id":251374,"avatar_url":"https://avatars.githubusercontent.com/u/251374?v=3","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spotify/docker-client","description":"A simple docker client for the JVM","fork":false,"url":"https://api.github.com/repos/spotify/docker-client","forks_url":"https://api.github.com/repos/spotify/docker-client/forks","keys_url":"https://api.github.com/repos/spotify/docker-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spotify/docker-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spotify/docker-client/teams","hooks_url":"https://api.github.com/repos/spotify/docker-client/hooks","issue_events_url":"https://api.github.com/repos/spotify/docker-client/issues/events{/number}","events_url":"https://api.github.com/repos/spotify/docker-client/events","assignees_url":"https://api.github.com/repos/spotify/docker-client/assignees{/user}","branches_url":"https://api.github.com/repos/spotify/docker-client/branches{/branch}","tags_url":"https://api.github.com/repos/spotify/docker-client/tags","blobs_url":"https://api.github.com/repos/spotify/docker-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spotify/docker-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spotify/docker-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/spotify/docker-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spotify/docker-client/statuses/{sha}","languages_url":"https://api.github.com/repos/spotify/docker-client/languages","stargazers_url":"https://api.github.com/repos/spotify/docker-client/stargazers","contributors_url":"https://api.github.com/repos/spotify/docker-client/contributors","subscribers_url":"https://api.github.com/repos/spotify/docker-client/subscribers","subscription_url":"https://api.github.com/repos/spotify/docker-client/subscription","commits_url":"https://api.github.com/repos/spotify/docker-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/spotify/docker-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/spotify/docker-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/spotify/docker-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/spotify/docker-client/contents/{+path}","compare_url":"https://api.github.com/repos/spotify/docker-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spotify/docker-client/merges","archive_url":"https://api.github.com/repos/spotify/docker-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spotify/docker-client/downloads","issues_url":"https://api.github.com/repos/spotify/docker-client/issues{/number}","pulls_url":"https://api.github.com/repos/spotify/docker-client/pulls{/number}","milestones_url":"https://api.github.com/repos/spotify/docker-client/milestones{/number}","notifications_url":"https://api.github.com/repos/spotify/docker-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spotify/docker-client/labels{/name}","releases_url":"https://api.github.com/repos/spotify/docker-client/releases{/id}","deployments_url":"https://api.github.com/repos/spotify/docker-client/deployments","created_at":"2014-06-04T13:22:10Z","updated_at":"2016-02-29T16:04:16Z","pushed_at":"2016-03-01T18:26:03Z","git_url":"git://github.com/spotify/docker-client.git","ssh_url":"git@github.com:spotify/docker-client.git","clone_url":"https://github.com/spotify/docker-client.git","svn_url":"https://github.com/spotify/docker-client","homepage":"","size":1654,"stargazers_count":284,"watchers_count":284,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":144,"mirror_url":null,"open_issues_count":36,"forks":144,"open_issues":36,"watchers":284,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spotify/docker-client/pulls/351"},"html":{"href":"https://github.com/spotify/docker-client/pull/351"},"issue":{"href":"https://api.github.com/repos/spotify/docker-client/issues/351"},"comments":{"href":"https://api.github.com/repos/spotify/docker-client/issues/351/comments"},"review_comments":{"href":"https://api.github.com/repos/spotify/docker-client/pulls/351/comments"},"review_comment":{"href":"https://api.github.com/repos/spotify/docker-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spotify/docker-client/pulls/351/commits"},"statuses":{"href":"https://api.github.com/repos/spotify/docker-client/statuses/40715905c4c5aa77db9ac620098b25a1919c3997"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"davidxia","id":480621,"avatar_url":"https://avatars.githubusercontent.com/u/480621?v=3","gravatar_id":"","url":"https://api.github.com/users/davidxia","html_url":"https://github.com/davidxia","followers_url":"https://api.github.com/users/davidxia/followers","following_url":"https://api.github.com/users/davidxia/following{/other_user}","gists_url":"https://api.github.com/users/davidxia/gists{/gist_id}","starred_url":"https://api.github.com/users/davidxia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidxia/subscriptions","organizations_url":"https://api.github.com/users/davidxia/orgs","repos_url":"https://api.github.com/users/davidxia/repos","events_url":"https://api.github.com/users/davidxia/events{/privacy}","received_events_url":"https://api.github.com/users/davidxia/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":2,"deletions":1,"changed_files":1}}