{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/pulls/comments/62943054","id":62943054,"diff_hunk":"@@ -32,6 +32,10 @@\n #include <stdarg.h>\n #include <unistd.h>\n #include <fcntl.h>\n+#ifndef __APPLE__\n+#include <stdio.h>","path":"dispatch/dispatch.h","position":5,"original_position":5,"commit_id":"28128e13396915ca347075fd44dd48c5fd955133","original_commit_id":"28128e13396915ca347075fd44dd48c5fd955133","user":{"login":"MadCoder","id":44708,"avatar_url":"https://avatars.githubusercontent.com/u/44708?v=3","gravatar_id":"","url":"https://api.github.com/users/MadCoder","html_url":"https://github.com/MadCoder","followers_url":"https://api.github.com/users/MadCoder/followers","following_url":"https://api.github.com/users/MadCoder/following{/other_user}","gists_url":"https://api.github.com/users/MadCoder/gists{/gist_id}","starred_url":"https://api.github.com/users/MadCoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MadCoder/subscriptions","organizations_url":"https://api.github.com/users/MadCoder/orgs","repos_url":"https://api.github.com/users/MadCoder/repos","events_url":"https://api.github.com/users/MadCoder/events{/privacy}","received_events_url":"https://api.github.com/users/MadCoder/received_events","type":"User","site_admin":false},"body":"why do you need that in a public header? we kind of try to restrict what we export to a bare minimum, <sys/types.h> I understand, but stdio seems to point toward something else being wrong.\r\n\r\nI would also add <sys/types.h> for everyone not only !__APPLE__ it's fine","created_at":"2016-05-11T23:17:19Z","updated_at":"2016-05-11T23:17:19Z","html_url":"https://github.com/apple/swift-corelibs-libdispatch/pull/62#discussion_r62943054","pull_request_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/pulls/62","_links":{"self":{"href":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/pulls/comments/62943054"},"html":{"href":"https://github.com/apple/swift-corelibs-libdispatch/pull/62#discussion_r62943054"},"pull_request":{"href":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/pulls/62"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/pulls/62","id":64198144,"html_url":"https://github.com/apple/swift-corelibs-libdispatch/pull/62","diff_url":"https://github.com/apple/swift-corelibs-libdispatch/pull/62.diff","patch_url":"https://github.com/apple/swift-corelibs-libdispatch/pull/62.patch","issue_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/issues/62","number":62,"state":"open","locked":false,"title":"Build fix for Linux overlay with 03242016 compiler.","user":{"login":"dgrove-oss","id":5099100,"avatar_url":"https://avatars.githubusercontent.com/u/5099100?v=3","gravatar_id":"","url":"https://api.github.com/users/dgrove-oss","html_url":"https://github.com/dgrove-oss","followers_url":"https://api.github.com/users/dgrove-oss/followers","following_url":"https://api.github.com/users/dgrove-oss/following{/other_user}","gists_url":"https://api.github.com/users/dgrove-oss/gists{/gist_id}","starred_url":"https://api.github.com/users/dgrove-oss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgrove-oss/subscriptions","organizations_url":"https://api.github.com/users/dgrove-oss/orgs","repos_url":"https://api.github.com/users/dgrove-oss/repos","events_url":"https://api.github.com/users/dgrove-oss/events{/privacy}","received_events_url":"https://api.github.com/users/dgrove-oss/received_events","type":"User","site_admin":false},"body":"With the 03242016 development drop, building the\r\nDispatch overlay on Linux fails because mode_t and\r\noff_t are not defined.  This is a minimal fix to\r\ninclude the needed header files and get the build\r\nworking again.","created_at":"2016-03-25T19:29:54Z","updated_at":"2016-05-11T23:17:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"effed5cf58d23b6bcb1a877c42f6cb6ec2ff17e4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/pulls/62/commits","review_comments_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/pulls/62/comments","review_comment_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/issues/62/comments","statuses_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/statuses/28128e13396915ca347075fd44dd48c5fd955133","head":{"label":"dgrove-oss:fix-import-for-03242016-drop","ref":"fix-import-for-03242016-drop","sha":"28128e13396915ca347075fd44dd48c5fd955133","user":{"login":"dgrove-oss","id":5099100,"avatar_url":"https://avatars.githubusercontent.com/u/5099100?v=3","gravatar_id":"","url":"https://api.github.com/users/dgrove-oss","html_url":"https://github.com/dgrove-oss","followers_url":"https://api.github.com/users/dgrove-oss/followers","following_url":"https://api.github.com/users/dgrove-oss/following{/other_user}","gists_url":"https://api.github.com/users/dgrove-oss/gists{/gist_id}","starred_url":"https://api.github.com/users/dgrove-oss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgrove-oss/subscriptions","organizations_url":"https://api.github.com/users/dgrove-oss/orgs","repos_url":"https://api.github.com/users/dgrove-oss/repos","events_url":"https://api.github.com/users/dgrove-oss/events{/privacy}","received_events_url":"https://api.github.com/users/dgrove-oss/received_events","type":"User","site_admin":false},"repo":{"id":47428328,"name":"swift-corelibs-libdispatch","full_name":"dgrove-oss/swift-corelibs-libdispatch","owner":{"login":"dgrove-oss","id":5099100,"avatar_url":"https://avatars.githubusercontent.com/u/5099100?v=3","gravatar_id":"","url":"https://api.github.com/users/dgrove-oss","html_url":"https://github.com/dgrove-oss","followers_url":"https://api.github.com/users/dgrove-oss/followers","following_url":"https://api.github.com/users/dgrove-oss/following{/other_user}","gists_url":"https://api.github.com/users/dgrove-oss/gists{/gist_id}","starred_url":"https://api.github.com/users/dgrove-oss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgrove-oss/subscriptions","organizations_url":"https://api.github.com/users/dgrove-oss/orgs","repos_url":"https://api.github.com/users/dgrove-oss/repos","events_url":"https://api.github.com/users/dgrove-oss/events{/privacy}","received_events_url":"https://api.github.com/users/dgrove-oss/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dgrove-oss/swift-corelibs-libdispatch","description":"The libdispatch Project, (a.k.a. Grand Central Dispatch), for concurrency on multicore hardware","fork":true,"url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch","forks_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/forks","keys_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/teams","hooks_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/hooks","issue_events_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/issues/events{/number}","events_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/events","assignees_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/assignees{/user}","branches_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/branches{/branch}","tags_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/tags","blobs_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/git/refs{/sha}","trees_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/statuses/{sha}","languages_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/languages","stargazers_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/stargazers","contributors_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/contributors","subscribers_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/subscribers","subscription_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/subscription","commits_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/commits{/sha}","git_commits_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/git/commits{/sha}","comments_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/comments{/number}","issue_comment_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/issues/comments{/number}","contents_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/contents/{+path}","compare_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/merges","archive_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/downloads","issues_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/issues{/number}","pulls_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/pulls{/number}","milestones_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/milestones{/number}","notifications_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/labels{/name}","releases_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/releases{/id}","deployments_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/deployments","created_at":"2015-12-04T20:54:44Z","updated_at":"2016-01-11T16:59:40Z","pushed_at":"2016-05-11T18:14:27Z","git_url":"git://github.com/dgrove-oss/swift-corelibs-libdispatch.git","ssh_url":"git@github.com:dgrove-oss/swift-corelibs-libdispatch.git","clone_url":"https://github.com/dgrove-oss/swift-corelibs-libdispatch.git","svn_url":"https://github.com/dgrove-oss/swift-corelibs-libdispatch","homepage":"swift.org","size":639,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"054d938078af66ea2e53d1d54e4b1833a43395ee","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":45863965,"name":"swift-corelibs-libdispatch","full_name":"apple/swift-corelibs-libdispatch","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift-corelibs-libdispatch","description":"The libdispatch Project, (a.k.a. Grand Central Dispatch), for concurrency on multicore hardware","fork":false,"url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch","forks_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/forks","keys_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/teams","hooks_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/hooks","issue_events_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/events","assignees_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/tags","blobs_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/languages","stargazers_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/stargazers","contributors_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/contributors","subscribers_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/subscribers","subscription_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/subscription","commits_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/merges","archive_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/downloads","issues_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/deployments","created_at":"2015-11-09T20:13:55Z","updated_at":"2016-05-09T19:16:24Z","pushed_at":"2016-05-11T17:14:25Z","git_url":"git://github.com/apple/swift-corelibs-libdispatch.git","ssh_url":"git@github.com:apple/swift-corelibs-libdispatch.git","clone_url":"https://github.com/apple/swift-corelibs-libdispatch.git","svn_url":"https://github.com/apple/swift-corelibs-libdispatch","homepage":"swift.org","size":795,"stargazers_count":677,"watchers_count":677,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":93,"mirror_url":null,"open_issues_count":9,"forks":93,"open_issues":9,"watchers":677,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/pulls/62"},"html":{"href":"https://github.com/apple/swift-corelibs-libdispatch/pull/62"},"issue":{"href":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/issues/62"},"comments":{"href":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/statuses/28128e13396915ca347075fd44dd48c5fd955133"}}}}