{"action":"closed","number":97,"pull_request":{"url":"https://api.github.com/repos/TTLabs/EvaporateJS/pulls/97","id":53993346,"html_url":"https://github.com/TTLabs/EvaporateJS/pull/97","diff_url":"https://github.com/TTLabs/EvaporateJS/pull/97.diff","patch_url":"https://github.com/TTLabs/EvaporateJS/pull/97.patch","issue_url":"https://api.github.com/repos/TTLabs/EvaporateJS/issues/97","number":97,"state":"closed","locked":false,"title":"Issue 96: Adds Support for AWS Content-MD5 Request Headers","user":{"login":"bikeath1337","id":243237,"avatar_url":"https://avatars.githubusercontent.com/u/243237?v=3","gravatar_id":"","url":"https://api.github.com/users/bikeath1337","html_url":"https://github.com/bikeath1337","followers_url":"https://api.github.com/users/bikeath1337/followers","following_url":"https://api.github.com/users/bikeath1337/following{/other_user}","gists_url":"https://api.github.com/users/bikeath1337/gists{/gist_id}","starred_url":"https://api.github.com/users/bikeath1337/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bikeath1337/subscriptions","organizations_url":"https://api.github.com/users/bikeath1337/orgs","repos_url":"https://api.github.com/users/bikeath1337/repos","events_url":"https://api.github.com/users/bikeath1337/events{/privacy}","received_events_url":"https://api.github.com/users/bikeath1337/received_events","type":"User","site_admin":false},"body":"This pull request adds support for MD5 digest transmission to AWS and addresses https://github.com/TTLabs/EvaporateJS/issues/96.\r\n\r\nNotes: The choice of cryptographic MD5 digest implementation is pluggable in this branch. I tried several implementations but settled on Spark MD5. Instructions on how to get this JavaScript library are in the README changes.\r\n\r\nThis branch uses 2 new configuration options: `computeContentMd5` is already used in the AWS JavaScript for Browsers SDK, so I chose that name for consistency. To make the checksum method pluggable, developers can define that method with the `cryptoMd5Method`.\r\n\r\nNote that on initialization, if `computeContentMd5`, then the code uses `alert()` if `cryptoMd5Method` is not defined as a function. Clearly this is harsh but could be considered necessary so that later indeterminate behavior can be avoided.\r\n\r\nThe way this works is to use a FileReader object. To get the contents of the object so that we can create the MD5 digest requires an asynchronous call where the digest is completed in the callback. I tried to make minimal changes to the existing code to enable better review.\r\n\r\nThis pull request also reads the AWS response object, parsed the XML and replies in the upload's on onerror callback.","created_at":"2015-12-17T15:53:02Z","updated_at":"2016-01-17T11:45:47Z","closed_at":"2016-01-17T11:45:47Z","merged_at":null,"merge_commit_sha":"7b83c122147f71bb7a47c17b9caaff7eed2b5a7f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TTLabs/EvaporateJS/pulls/97/commits","review_comments_url":"https://api.github.com/repos/TTLabs/EvaporateJS/pulls/97/comments","review_comment_url":"https://api.github.com/repos/TTLabs/EvaporateJS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TTLabs/EvaporateJS/issues/97/comments","statuses_url":"https://api.github.com/repos/TTLabs/EvaporateJS/statuses/1fccf5813df58196332b3dcdb0e85d72083913f7","head":{"label":"bikeath1337:breakdown","ref":"breakdown","sha":"1fccf5813df58196332b3dcdb0e85d72083913f7","user":{"login":"bikeath1337","id":243237,"avatar_url":"https://avatars.githubusercontent.com/u/243237?v=3","gravatar_id":"","url":"https://api.github.com/users/bikeath1337","html_url":"https://github.com/bikeath1337","followers_url":"https://api.github.com/users/bikeath1337/followers","following_url":"https://api.github.com/users/bikeath1337/following{/other_user}","gists_url":"https://api.github.com/users/bikeath1337/gists{/gist_id}","starred_url":"https://api.github.com/users/bikeath1337/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bikeath1337/subscriptions","organizations_url":"https://api.github.com/users/bikeath1337/orgs","repos_url":"https://api.github.com/users/bikeath1337/repos","events_url":"https://api.github.com/users/bikeath1337/events{/privacy}","received_events_url":"https://api.github.com/users/bikeath1337/received_events","type":"User","site_admin":false},"repo":{"id":47833508,"name":"EvaporateJS","full_name":"bikeath1337/EvaporateJS","owner":{"login":"bikeath1337","id":243237,"avatar_url":"https://avatars.githubusercontent.com/u/243237?v=3","gravatar_id":"","url":"https://api.github.com/users/bikeath1337","html_url":"https://github.com/bikeath1337","followers_url":"https://api.github.com/users/bikeath1337/followers","following_url":"https://api.github.com/users/bikeath1337/following{/other_user}","gists_url":"https://api.github.com/users/bikeath1337/gists{/gist_id}","starred_url":"https://api.github.com/users/bikeath1337/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bikeath1337/subscriptions","organizations_url":"https://api.github.com/users/bikeath1337/orgs","repos_url":"https://api.github.com/users/bikeath1337/repos","events_url":"https://api.github.com/users/bikeath1337/events{/privacy}","received_events_url":"https://api.github.com/users/bikeath1337/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bikeath1337/EvaporateJS","description":"Javascript library for browser to S3 multipart resumable uploads","fork":true,"url":"https://api.github.com/repos/bikeath1337/EvaporateJS","forks_url":"https://api.github.com/repos/bikeath1337/EvaporateJS/forks","keys_url":"https://api.github.com/repos/bikeath1337/EvaporateJS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bikeath1337/EvaporateJS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bikeath1337/EvaporateJS/teams","hooks_url":"https://api.github.com/repos/bikeath1337/EvaporateJS/hooks","issue_events_url":"https://api.github.com/repos/bikeath1337/EvaporateJS/issues/events{/number}","events_url":"https://api.github.com/repos/bikeath1337/EvaporateJS/events","assignees_url":"https://api.github.com/repos/bikeath1337/EvaporateJS/assignees{/user}","branches_url":"https://api.github.com/repos/bikeath1337/EvaporateJS/branches{/branch}","tags_url":"https://api.github.com/repos/bikeath1337/EvaporateJS/tags","blobs_url":"https://api.github.com/repos/bikeath1337/EvaporateJS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bikeath1337/EvaporateJS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bikeath1337/EvaporateJS/git/refs{/sha}","trees_url":"https://api.github.com/repos/bikeath1337/EvaporateJS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bikeath1337/EvaporateJS/statuses/{sha}","languages_url":"https://api.github.com/repos/bikeath1337/EvaporateJS/languages","stargazers_url":"https://api.github.com/repos/bikeath1337/EvaporateJS/stargazers","contributors_url":"https://api.github.com/repos/bikeath1337/EvaporateJS/contributors","subscribers_url":"https://api.github.com/repos/bikeath1337/EvaporateJS/subscribers","subscription_url":"https://api.github.com/repos/bikeath1337/EvaporateJS/subscription","commits_url":"https://api.github.com/repos/bikeath1337/EvaporateJS/commits{/sha}","git_commits_url":"https://api.github.com/repos/bikeath1337/EvaporateJS/git/commits{/sha}","comments_url":"https://api.github.com/repos/bikeath1337/EvaporateJS/comments{/number}","issue_comment_url":"https://api.github.com/repos/bikeath1337/EvaporateJS/issues/comments{/number}","contents_url":"https://api.github.com/repos/bikeath1337/EvaporateJS/contents/{+path}","compare_url":"https://api.github.com/repos/bikeath1337/EvaporateJS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bikeath1337/EvaporateJS/merges","archive_url":"https://api.github.com/repos/bikeath1337/EvaporateJS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bikeath1337/EvaporateJS/downloads","issues_url":"https://api.github.com/repos/bikeath1337/EvaporateJS/issues{/number}","pulls_url":"https://api.github.com/repos/bikeath1337/EvaporateJS/pulls{/number}","milestones_url":"https://api.github.com/repos/bikeath1337/EvaporateJS/milestones{/number}","notifications_url":"https://api.github.com/repos/bikeath1337/EvaporateJS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bikeath1337/EvaporateJS/labels{/name}","releases_url":"https://api.github.com/repos/bikeath1337/EvaporateJS/releases{/id}","created_at":"2015-12-11T15:14:53Z","updated_at":"2015-12-11T15:14:53Z","pushed_at":"2016-01-17T11:45:47Z","git_url":"git://github.com/bikeath1337/EvaporateJS.git","ssh_url":"git@github.com:bikeath1337/EvaporateJS.git","clone_url":"https://github.com/bikeath1337/EvaporateJS.git","svn_url":"https://github.com/bikeath1337/EvaporateJS","homepage":null,"size":202,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TTLabs:master","ref":"master","sha":"1a806997959df2e14cd4b7ce21120e75ec9e4fe7","user":{"login":"TTLabs","id":814544,"avatar_url":"https://avatars.githubusercontent.com/u/814544?v=3","gravatar_id":"","url":"https://api.github.com/users/TTLabs","html_url":"https://github.com/TTLabs","followers_url":"https://api.github.com/users/TTLabs/followers","following_url":"https://api.github.com/users/TTLabs/following{/other_user}","gists_url":"https://api.github.com/users/TTLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/TTLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TTLabs/subscriptions","organizations_url":"https://api.github.com/users/TTLabs/orgs","repos_url":"https://api.github.com/users/TTLabs/repos","events_url":"https://api.github.com/users/TTLabs/events{/privacy}","received_events_url":"https://api.github.com/users/TTLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":7264874,"name":"EvaporateJS","full_name":"TTLabs/EvaporateJS","owner":{"login":"TTLabs","id":814544,"avatar_url":"https://avatars.githubusercontent.com/u/814544?v=3","gravatar_id":"","url":"https://api.github.com/users/TTLabs","html_url":"https://github.com/TTLabs","followers_url":"https://api.github.com/users/TTLabs/followers","following_url":"https://api.github.com/users/TTLabs/following{/other_user}","gists_url":"https://api.github.com/users/TTLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/TTLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TTLabs/subscriptions","organizations_url":"https://api.github.com/users/TTLabs/orgs","repos_url":"https://api.github.com/users/TTLabs/repos","events_url":"https://api.github.com/users/TTLabs/events{/privacy}","received_events_url":"https://api.github.com/users/TTLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TTLabs/EvaporateJS","description":"Javascript library for browser to S3 multipart resumable uploads","fork":false,"url":"https://api.github.com/repos/TTLabs/EvaporateJS","forks_url":"https://api.github.com/repos/TTLabs/EvaporateJS/forks","keys_url":"https://api.github.com/repos/TTLabs/EvaporateJS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TTLabs/EvaporateJS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TTLabs/EvaporateJS/teams","hooks_url":"https://api.github.com/repos/TTLabs/EvaporateJS/hooks","issue_events_url":"https://api.github.com/repos/TTLabs/EvaporateJS/issues/events{/number}","events_url":"https://api.github.com/repos/TTLabs/EvaporateJS/events","assignees_url":"https://api.github.com/repos/TTLabs/EvaporateJS/assignees{/user}","branches_url":"https://api.github.com/repos/TTLabs/EvaporateJS/branches{/branch}","tags_url":"https://api.github.com/repos/TTLabs/EvaporateJS/tags","blobs_url":"https://api.github.com/repos/TTLabs/EvaporateJS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TTLabs/EvaporateJS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TTLabs/EvaporateJS/git/refs{/sha}","trees_url":"https://api.github.com/repos/TTLabs/EvaporateJS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TTLabs/EvaporateJS/statuses/{sha}","languages_url":"https://api.github.com/repos/TTLabs/EvaporateJS/languages","stargazers_url":"https://api.github.com/repos/TTLabs/EvaporateJS/stargazers","contributors_url":"https://api.github.com/repos/TTLabs/EvaporateJS/contributors","subscribers_url":"https://api.github.com/repos/TTLabs/EvaporateJS/subscribers","subscription_url":"https://api.github.com/repos/TTLabs/EvaporateJS/subscription","commits_url":"https://api.github.com/repos/TTLabs/EvaporateJS/commits{/sha}","git_commits_url":"https://api.github.com/repos/TTLabs/EvaporateJS/git/commits{/sha}","comments_url":"https://api.github.com/repos/TTLabs/EvaporateJS/comments{/number}","issue_comment_url":"https://api.github.com/repos/TTLabs/EvaporateJS/issues/comments{/number}","contents_url":"https://api.github.com/repos/TTLabs/EvaporateJS/contents/{+path}","compare_url":"https://api.github.com/repos/TTLabs/EvaporateJS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TTLabs/EvaporateJS/merges","archive_url":"https://api.github.com/repos/TTLabs/EvaporateJS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TTLabs/EvaporateJS/downloads","issues_url":"https://api.github.com/repos/TTLabs/EvaporateJS/issues{/number}","pulls_url":"https://api.github.com/repos/TTLabs/EvaporateJS/pulls{/number}","milestones_url":"https://api.github.com/repos/TTLabs/EvaporateJS/milestones{/number}","notifications_url":"https://api.github.com/repos/TTLabs/EvaporateJS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TTLabs/EvaporateJS/labels{/name}","releases_url":"https://api.github.com/repos/TTLabs/EvaporateJS/releases{/id}","created_at":"2012-12-20T21:49:38Z","updated_at":"2016-01-13T20:53:29Z","pushed_at":"2016-01-12T23:39:10Z","git_url":"git://github.com/TTLabs/EvaporateJS.git","ssh_url":"git@github.com:TTLabs/EvaporateJS.git","clone_url":"https://github.com/TTLabs/EvaporateJS.git","svn_url":"https://github.com/TTLabs/EvaporateJS","homepage":null,"size":674,"stargazers_count":974,"watchers_count":974,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":82,"mirror_url":null,"open_issues_count":34,"forks":82,"open_issues":34,"watchers":974,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TTLabs/EvaporateJS/pulls/97"},"html":{"href":"https://github.com/TTLabs/EvaporateJS/pull/97"},"issue":{"href":"https://api.github.com/repos/TTLabs/EvaporateJS/issues/97"},"comments":{"href":"https://api.github.com/repos/TTLabs/EvaporateJS/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/TTLabs/EvaporateJS/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/TTLabs/EvaporateJS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TTLabs/EvaporateJS/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/TTLabs/EvaporateJS/statuses/1fccf5813df58196332b3dcdb0e85d72083913f7"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":3,"commits":12,"additions":114,"deletions":20,"changed_files":2}}