{"action":"created","comment":{"url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/pulls/comments/71043292","id":71043292,"diff_hunk":"@@ -0,0 +1,20 @@\n+/*eslint-env node*/\n+\n+'use strict';\n+\n+var join = require('path').join;\n+var asyncExec = require('./async-exec');\n+\n+/**\n+ * Get the path to the ESLint executable in the dependencies\n+ *\n+ * @returns {Promise->String} the path to the ESLint executable\n+ */\n+module.exports = function() {\n+  return asyncExec('npm', ['bin'])\n+    .then(function(location) {\n+      return join(\n+        location.trim(), '../ember-cli-eslint/node_modules/.bin/eslint'","path":"lib/helpers/path-to-eslint.js","position":null,"original_position":17,"commit_id":"0fcab0ade6480f47abdba5c17fee7e9c16a09e4d","original_commit_id":"91b6c075602293ded9bdbc45865d5fbb9ce861cc","user":{"login":"alexlafroscia","id":1645881,"avatar_url":"https://avatars.githubusercontent.com/u/1645881?v=3","gravatar_id":"","url":"https://api.github.com/users/alexlafroscia","html_url":"https://github.com/alexlafroscia","followers_url":"https://api.github.com/users/alexlafroscia/followers","following_url":"https://api.github.com/users/alexlafroscia/following{/other_user}","gists_url":"https://api.github.com/users/alexlafroscia/gists{/gist_id}","starred_url":"https://api.github.com/users/alexlafroscia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexlafroscia/subscriptions","organizations_url":"https://api.github.com/users/alexlafroscia/orgs","repos_url":"https://api.github.com/users/alexlafroscia/repos","events_url":"https://api.github.com/users/alexlafroscia/events{/privacy}","received_events_url":"https://api.github.com/users/alexlafroscia/received_events","type":"User","site_admin":false},"body":"Yeah, I made that comment looking for help before I remembered `require.resolve`.  That's exactly what I'm doing now.\r\n\r\nhttps://github.com/alexlafroscia/ember-cli-eslint/blob/0fcab0ade6480f47abdba5c17fee7e9c16a09e4d/lib/helpers/eslint-command.js#L8","created_at":"2016-07-15T21:27:48Z","updated_at":"2016-07-15T21:27:48Z","html_url":"https://github.com/ember-cli/ember-cli-eslint/pull/93#discussion_r71043292","pull_request_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/pulls/93","_links":{"self":{"href":"https://api.github.com/repos/ember-cli/ember-cli-eslint/pulls/comments/71043292"},"html":{"href":"https://github.com/ember-cli/ember-cli-eslint/pull/93#discussion_r71043292"},"pull_request":{"href":"https://api.github.com/repos/ember-cli/ember-cli-eslint/pulls/93"}}},"pull_request":{"url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/pulls/93","id":77231476,"html_url":"https://github.com/ember-cli/ember-cli-eslint/pull/93","diff_url":"https://github.com/ember-cli/ember-cli-eslint/pull/93.diff","patch_url":"https://github.com/ember-cli/ember-cli-eslint/pull/93.patch","issue_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/issues/93","number":93,"state":"open","locked":false,"title":"Add `ember lint` command","user":{"login":"alexlafroscia","id":1645881,"avatar_url":"https://avatars.githubusercontent.com/u/1645881?v=3","gravatar_id":"","url":"https://api.github.com/users/alexlafroscia","html_url":"https://github.com/alexlafroscia","followers_url":"https://api.github.com/users/alexlafroscia/followers","following_url":"https://api.github.com/users/alexlafroscia/following{/other_user}","gists_url":"https://api.github.com/users/alexlafroscia/gists{/gist_id}","starred_url":"https://api.github.com/users/alexlafroscia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexlafroscia/subscriptions","organizations_url":"https://api.github.com/users/alexlafroscia/orgs","repos_url":"https://api.github.com/users/alexlafroscia/repos","events_url":"https://api.github.com/users/alexlafroscia/events{/privacy}","received_events_url":"https://api.github.com/users/alexlafroscia/received_events","type":"User","site_admin":false},"body":"`ember lint` run `eslint` on the `app` and `tests` directories.\r\n\r\nThe only issue right now is that the output of the ESLint command is grabbed from the `STDOUT` of the child process and then passed through to the output of the Ember process, so we lose the original colors.  I would love to maintain them, but I'm just not sure how.  I'd love a pointer in the right direction!\r\n\r\nAlso, I used `Promise` in the new task; I'm guessing that won't be a problem but if I should write that another way, I'm happy to.\r\n\r\nCloses #92 \r\n\r\n## Todo List\r\n\r\n- [x] Refactor the ESLint-running code to be more re-usable\r\n- [x] Add `ember lint:fix` command\r\n- [ ] Add tests (?)","created_at":"2016-07-13T05:18:00Z","updated_at":"2016-07-15T21:27:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5d4c56eecab8d1f2e7f6e11f21359b901973d36","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/pulls/93/commits","review_comments_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/pulls/93/comments","review_comment_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/issues/93/comments","statuses_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/statuses/0fcab0ade6480f47abdba5c17fee7e9c16a09e4d","head":{"label":"alexlafroscia:add-lint-command","ref":"add-lint-command","sha":"0fcab0ade6480f47abdba5c17fee7e9c16a09e4d","user":{"login":"alexlafroscia","id":1645881,"avatar_url":"https://avatars.githubusercontent.com/u/1645881?v=3","gravatar_id":"","url":"https://api.github.com/users/alexlafroscia","html_url":"https://github.com/alexlafroscia","followers_url":"https://api.github.com/users/alexlafroscia/followers","following_url":"https://api.github.com/users/alexlafroscia/following{/other_user}","gists_url":"https://api.github.com/users/alexlafroscia/gists{/gist_id}","starred_url":"https://api.github.com/users/alexlafroscia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexlafroscia/subscriptions","organizations_url":"https://api.github.com/users/alexlafroscia/orgs","repos_url":"https://api.github.com/users/alexlafroscia/repos","events_url":"https://api.github.com/users/alexlafroscia/events{/privacy}","received_events_url":"https://api.github.com/users/alexlafroscia/received_events","type":"User","site_admin":false},"repo":{"id":54216850,"name":"ember-cli-eslint","full_name":"alexlafroscia/ember-cli-eslint","owner":{"login":"alexlafroscia","id":1645881,"avatar_url":"https://avatars.githubusercontent.com/u/1645881?v=3","gravatar_id":"","url":"https://api.github.com/users/alexlafroscia","html_url":"https://github.com/alexlafroscia","followers_url":"https://api.github.com/users/alexlafroscia/followers","following_url":"https://api.github.com/users/alexlafroscia/following{/other_user}","gists_url":"https://api.github.com/users/alexlafroscia/gists{/gist_id}","starred_url":"https://api.github.com/users/alexlafroscia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexlafroscia/subscriptions","organizations_url":"https://api.github.com/users/alexlafroscia/orgs","repos_url":"https://api.github.com/users/alexlafroscia/repos","events_url":"https://api.github.com/users/alexlafroscia/events{/privacy}","received_events_url":"https://api.github.com/users/alexlafroscia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexlafroscia/ember-cli-eslint","description":"ember-cli-eslint package for linting ember-cli with ESLint","fork":true,"url":"https://api.github.com/repos/alexlafroscia/ember-cli-eslint","forks_url":"https://api.github.com/repos/alexlafroscia/ember-cli-eslint/forks","keys_url":"https://api.github.com/repos/alexlafroscia/ember-cli-eslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexlafroscia/ember-cli-eslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexlafroscia/ember-cli-eslint/teams","hooks_url":"https://api.github.com/repos/alexlafroscia/ember-cli-eslint/hooks","issue_events_url":"https://api.github.com/repos/alexlafroscia/ember-cli-eslint/issues/events{/number}","events_url":"https://api.github.com/repos/alexlafroscia/ember-cli-eslint/events","assignees_url":"https://api.github.com/repos/alexlafroscia/ember-cli-eslint/assignees{/user}","branches_url":"https://api.github.com/repos/alexlafroscia/ember-cli-eslint/branches{/branch}","tags_url":"https://api.github.com/repos/alexlafroscia/ember-cli-eslint/tags","blobs_url":"https://api.github.com/repos/alexlafroscia/ember-cli-eslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexlafroscia/ember-cli-eslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexlafroscia/ember-cli-eslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexlafroscia/ember-cli-eslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexlafroscia/ember-cli-eslint/statuses/{sha}","languages_url":"https://api.github.com/repos/alexlafroscia/ember-cli-eslint/languages","stargazers_url":"https://api.github.com/repos/alexlafroscia/ember-cli-eslint/stargazers","contributors_url":"https://api.github.com/repos/alexlafroscia/ember-cli-eslint/contributors","subscribers_url":"https://api.github.com/repos/alexlafroscia/ember-cli-eslint/subscribers","subscription_url":"https://api.github.com/repos/alexlafroscia/ember-cli-eslint/subscription","commits_url":"https://api.github.com/repos/alexlafroscia/ember-cli-eslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexlafroscia/ember-cli-eslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexlafroscia/ember-cli-eslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexlafroscia/ember-cli-eslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexlafroscia/ember-cli-eslint/contents/{+path}","compare_url":"https://api.github.com/repos/alexlafroscia/ember-cli-eslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexlafroscia/ember-cli-eslint/merges","archive_url":"https://api.github.com/repos/alexlafroscia/ember-cli-eslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexlafroscia/ember-cli-eslint/downloads","issues_url":"https://api.github.com/repos/alexlafroscia/ember-cli-eslint/issues{/number}","pulls_url":"https://api.github.com/repos/alexlafroscia/ember-cli-eslint/pulls{/number}","milestones_url":"https://api.github.com/repos/alexlafroscia/ember-cli-eslint/milestones{/number}","notifications_url":"https://api.github.com/repos/alexlafroscia/ember-cli-eslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexlafroscia/ember-cli-eslint/labels{/name}","releases_url":"https://api.github.com/repos/alexlafroscia/ember-cli-eslint/releases{/id}","deployments_url":"https://api.github.com/repos/alexlafroscia/ember-cli-eslint/deployments","created_at":"2016-03-18T16:43:30Z","updated_at":"2016-03-18T16:43:31Z","pushed_at":"2016-07-15T00:55:32Z","git_url":"git://github.com/alexlafroscia/ember-cli-eslint.git","ssh_url":"git@github.com:alexlafroscia/ember-cli-eslint.git","clone_url":"https://github.com/alexlafroscia/ember-cli-eslint.git","svn_url":"https://github.com/alexlafroscia/ember-cli-eslint","homepage":"","size":110,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ember-cli:master","ref":"master","sha":"96b528500ac15c918beee94a45234c1e646f62cf","user":{"login":"ember-cli","id":10262982,"avatar_url":"https://avatars.githubusercontent.com/u/10262982?v=3","gravatar_id":"","url":"https://api.github.com/users/ember-cli","html_url":"https://github.com/ember-cli","followers_url":"https://api.github.com/users/ember-cli/followers","following_url":"https://api.github.com/users/ember-cli/following{/other_user}","gists_url":"https://api.github.com/users/ember-cli/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-cli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-cli/subscriptions","organizations_url":"https://api.github.com/users/ember-cli/orgs","repos_url":"https://api.github.com/users/ember-cli/repos","events_url":"https://api.github.com/users/ember-cli/events{/privacy}","received_events_url":"https://api.github.com/users/ember-cli/received_events","type":"Organization","site_admin":false},"repo":{"id":30788414,"name":"ember-cli-eslint","full_name":"ember-cli/ember-cli-eslint","owner":{"login":"ember-cli","id":10262982,"avatar_url":"https://avatars.githubusercontent.com/u/10262982?v=3","gravatar_id":"","url":"https://api.github.com/users/ember-cli","html_url":"https://github.com/ember-cli","followers_url":"https://api.github.com/users/ember-cli/followers","following_url":"https://api.github.com/users/ember-cli/following{/other_user}","gists_url":"https://api.github.com/users/ember-cli/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-cli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-cli/subscriptions","organizations_url":"https://api.github.com/users/ember-cli/orgs","repos_url":"https://api.github.com/users/ember-cli/repos","events_url":"https://api.github.com/users/ember-cli/events{/privacy}","received_events_url":"https://api.github.com/users/ember-cli/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ember-cli/ember-cli-eslint","description":"ember-cli-eslint package for linting ember-cli with ESLint","fork":false,"url":"https://api.github.com/repos/ember-cli/ember-cli-eslint","forks_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/forks","keys_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/teams","hooks_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/hooks","issue_events_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/issues/events{/number}","events_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/events","assignees_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/assignees{/user}","branches_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/branches{/branch}","tags_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/tags","blobs_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/statuses/{sha}","languages_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/languages","stargazers_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/stargazers","contributors_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/contributors","subscribers_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/subscribers","subscription_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/subscription","commits_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/contents/{+path}","compare_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/merges","archive_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/downloads","issues_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/issues{/number}","pulls_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/pulls{/number}","milestones_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/milestones{/number}","notifications_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/labels{/name}","releases_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/releases{/id}","deployments_url":"https://api.github.com/repos/ember-cli/ember-cli-eslint/deployments","created_at":"2015-02-14T05:45:40Z","updated_at":"2016-07-14T19:11:10Z","pushed_at":"2016-07-15T10:24:09Z","git_url":"git://github.com/ember-cli/ember-cli-eslint.git","ssh_url":"git@github.com:ember-cli/ember-cli-eslint.git","clone_url":"https://github.com/ember-cli/ember-cli-eslint.git","svn_url":"https://github.com/ember-cli/ember-cli-eslint","homepage":"","size":127,"stargazers_count":53,"watchers_count":53,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":15,"forks":24,"open_issues":15,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ember-cli/ember-cli-eslint/pulls/93"},"html":{"href":"https://github.com/ember-cli/ember-cli-eslint/pull/93"},"issue":{"href":"https://api.github.com/repos/ember-cli/ember-cli-eslint/issues/93"},"comments":{"href":"https://api.github.com/repos/ember-cli/ember-cli-eslint/issues/93/comments"},"review_comments":{"href":"https://api.github.com/repos/ember-cli/ember-cli-eslint/pulls/93/comments"},"review_comment":{"href":"https://api.github.com/repos/ember-cli/ember-cli-eslint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ember-cli/ember-cli-eslint/pulls/93/commits"},"statuses":{"href":"https://api.github.com/repos/ember-cli/ember-cli-eslint/statuses/0fcab0ade6480f47abdba5c17fee7e9c16a09e4d"}}}}
{"actor":{"display_login":"alexlafroscia"}}