{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/91862748","pull_request_review_id":12372570,"id":91862748,"diff_hunk":"@@ -490,9 +492,9 @@ fn assert_discr_in_range(min: Disr, max: Disr, discr: Disr) {\n }\n \n /// Access a field, at a point when the value's case is known.\n-pub fn trans_field_ptr<'blk, 'tcx>(bcx: Block<'blk, 'tcx>, t: Ty<'tcx>,\n+pub fn trans_field_ptr<'blk, 'tcx>(bcx: &BlockAndBuilder<'blk, 'tcx>, t: Ty<'tcx>,\n                                    val: MaybeSizedValue, discr: Disr, ix: usize) -> ValueRef {\n-    trans_field_ptr_builder(&bcx.build(), t, val, discr, ix)\n+    trans_field_ptr_builder(bcx, t, val, discr, ix)","path":"src/librustc_trans/adt.rs","position":174,"original_position":174,"commit_id":"8046b2a205529a689f471ef63cc738d77c4a6d19","original_commit_id":"8046b2a205529a689f471ef63cc738d77c4a6d19","user":{"login":"eddyb","id":77424,"avatar_url":"https://avatars.githubusercontent.com/u/77424?v=3","gravatar_id":"","url":"https://api.github.com/users/eddyb","html_url":"https://github.com/eddyb","followers_url":"https://api.github.com/users/eddyb/followers","following_url":"https://api.github.com/users/eddyb/following{/other_user}","gists_url":"https://api.github.com/users/eddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/eddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddyb/subscriptions","organizations_url":"https://api.github.com/users/eddyb/orgs","repos_url":"https://api.github.com/users/eddyb/repos","events_url":"https://api.github.com/users/eddyb/events{/privacy}","received_events_url":"https://api.github.com/users/eddyb/received_events","type":"User","site_admin":false},"body":"Yeah, I also commented on it, there's a bunch like this.","created_at":"2016-12-11T19:12:53Z","updated_at":"2016-12-11T19:12:53Z","html_url":"https://github.com/rust-lang/rust/pull/38302#discussion_r91862748","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/38302","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/91862748"},"html":{"href":"https://github.com/rust-lang/rust/pull/38302#discussion_r91862748"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/38302"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/38302","id":97466206,"html_url":"https://github.com/rust-lang/rust/pull/38302","diff_url":"https://github.com/rust-lang/rust/pull/38302.diff","patch_url":"https://github.com/rust-lang/rust/pull/38302.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/38302","number":38302,"state":"open","locked":false,"title":"Remove build.rs from trans","user":{"login":"Mark-Simulacrum","id":5047365,"avatar_url":"https://avatars.githubusercontent.com/u/5047365?v=3","gravatar_id":"","url":"https://api.github.com/users/Mark-Simulacrum","html_url":"https://github.com/Mark-Simulacrum","followers_url":"https://api.github.com/users/Mark-Simulacrum/followers","following_url":"https://api.github.com/users/Mark-Simulacrum/following{/other_user}","gists_url":"https://api.github.com/users/Mark-Simulacrum/gists{/gist_id}","starred_url":"https://api.github.com/users/Mark-Simulacrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mark-Simulacrum/subscriptions","organizations_url":"https://api.github.com/users/Mark-Simulacrum/orgs","repos_url":"https://api.github.com/users/Mark-Simulacrum/repos","events_url":"https://api.github.com/users/Mark-Simulacrum/events{/privacy}","received_events_url":"https://api.github.com/users/Mark-Simulacrum/received_events","type":"User","site_admin":false},"body":"As a drive-by fix, this makes `drop_in_place` run other destructors in the same function, which it didn't before.\r\n\r\nPotentially fixes #35566, but I don't have a windows machine to test it on. (cc @petrochenkov)\r\n\r\nWe make debuginfo location tracking local, instead of global. There is now only one API in trans which builds LLVM IR, which is the functions on Builder.\r\n\r\nThis also made a few details about debug info more obvious, but these are out of scope for this PR:\r\n - `CustomScope` from cleanup always has `debug_loc = DebugLoc::None`\r\n - `debuginfo/source_loc::set_source_location`:\r\n   - `FunctionDebugContext.source_location_override` is always false.\r\n   - It's possible the code in general in this area can be cleaned up....\r\n\r\n\r\nr? @eddyb ","created_at":"2016-12-11T17:42:15Z","updated_at":"2016-12-11T19:12:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"afa85c13b33f426f644d380c0f3b9ed94c8e62cf","assignee":{"login":"eddyb","id":77424,"avatar_url":"https://avatars.githubusercontent.com/u/77424?v=3","gravatar_id":"","url":"https://api.github.com/users/eddyb","html_url":"https://github.com/eddyb","followers_url":"https://api.github.com/users/eddyb/followers","following_url":"https://api.github.com/users/eddyb/following{/other_user}","gists_url":"https://api.github.com/users/eddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/eddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddyb/subscriptions","organizations_url":"https://api.github.com/users/eddyb/orgs","repos_url":"https://api.github.com/users/eddyb/repos","events_url":"https://api.github.com/users/eddyb/events{/privacy}","received_events_url":"https://api.github.com/users/eddyb/received_events","type":"User","site_admin":false},"assignees":[{"login":"eddyb","id":77424,"avatar_url":"https://avatars.githubusercontent.com/u/77424?v=3","gravatar_id":"","url":"https://api.github.com/users/eddyb","html_url":"https://github.com/eddyb","followers_url":"https://api.github.com/users/eddyb/followers","following_url":"https://api.github.com/users/eddyb/following{/other_user}","gists_url":"https://api.github.com/users/eddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/eddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddyb/subscriptions","organizations_url":"https://api.github.com/users/eddyb/orgs","repos_url":"https://api.github.com/users/eddyb/repos","events_url":"https://api.github.com/users/eddyb/events{/privacy}","received_events_url":"https://api.github.com/users/eddyb/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/38302/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/38302/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/38302/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/8046b2a205529a689f471ef63cc738d77c4a6d19","head":{"label":"Mark-Simulacrum:trans-cleanup","ref":"trans-cleanup","sha":"8046b2a205529a689f471ef63cc738d77c4a6d19","user":{"login":"Mark-Simulacrum","id":5047365,"avatar_url":"https://avatars.githubusercontent.com/u/5047365?v=3","gravatar_id":"","url":"https://api.github.com/users/Mark-Simulacrum","html_url":"https://github.com/Mark-Simulacrum","followers_url":"https://api.github.com/users/Mark-Simulacrum/followers","following_url":"https://api.github.com/users/Mark-Simulacrum/following{/other_user}","gists_url":"https://api.github.com/users/Mark-Simulacrum/gists{/gist_id}","starred_url":"https://api.github.com/users/Mark-Simulacrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mark-Simulacrum/subscriptions","organizations_url":"https://api.github.com/users/Mark-Simulacrum/orgs","repos_url":"https://api.github.com/users/Mark-Simulacrum/repos","events_url":"https://api.github.com/users/Mark-Simulacrum/events{/privacy}","received_events_url":"https://api.github.com/users/Mark-Simulacrum/received_events","type":"User","site_admin":false},"repo":{"id":65503623,"name":"rust","full_name":"Mark-Simulacrum/rust","owner":{"login":"Mark-Simulacrum","id":5047365,"avatar_url":"https://avatars.githubusercontent.com/u/5047365?v=3","gravatar_id":"","url":"https://api.github.com/users/Mark-Simulacrum","html_url":"https://github.com/Mark-Simulacrum","followers_url":"https://api.github.com/users/Mark-Simulacrum/followers","following_url":"https://api.github.com/users/Mark-Simulacrum/following{/other_user}","gists_url":"https://api.github.com/users/Mark-Simulacrum/gists{/gist_id}","starred_url":"https://api.github.com/users/Mark-Simulacrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mark-Simulacrum/subscriptions","organizations_url":"https://api.github.com/users/Mark-Simulacrum/orgs","repos_url":"https://api.github.com/users/Mark-Simulacrum/repos","events_url":"https://api.github.com/users/Mark-Simulacrum/events{/privacy}","received_events_url":"https://api.github.com/users/Mark-Simulacrum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Mark-Simulacrum/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/Mark-Simulacrum/rust","forks_url":"https://api.github.com/repos/Mark-Simulacrum/rust/forks","keys_url":"https://api.github.com/repos/Mark-Simulacrum/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mark-Simulacrum/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mark-Simulacrum/rust/teams","hooks_url":"https://api.github.com/repos/Mark-Simulacrum/rust/hooks","issue_events_url":"https://api.github.com/repos/Mark-Simulacrum/rust/issues/events{/number}","events_url":"https://api.github.com/repos/Mark-Simulacrum/rust/events","assignees_url":"https://api.github.com/repos/Mark-Simulacrum/rust/assignees{/user}","branches_url":"https://api.github.com/repos/Mark-Simulacrum/rust/branches{/branch}","tags_url":"https://api.github.com/repos/Mark-Simulacrum/rust/tags","blobs_url":"https://api.github.com/repos/Mark-Simulacrum/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mark-Simulacrum/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mark-Simulacrum/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mark-Simulacrum/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mark-Simulacrum/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/Mark-Simulacrum/rust/languages","stargazers_url":"https://api.github.com/repos/Mark-Simulacrum/rust/stargazers","contributors_url":"https://api.github.com/repos/Mark-Simulacrum/rust/contributors","subscribers_url":"https://api.github.com/repos/Mark-Simulacrum/rust/subscribers","subscription_url":"https://api.github.com/repos/Mark-Simulacrum/rust/subscription","commits_url":"https://api.github.com/repos/Mark-Simulacrum/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mark-Simulacrum/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mark-Simulacrum/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mark-Simulacrum/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mark-Simulacrum/rust/contents/{+path}","compare_url":"https://api.github.com/repos/Mark-Simulacrum/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mark-Simulacrum/rust/merges","archive_url":"https://api.github.com/repos/Mark-Simulacrum/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mark-Simulacrum/rust/downloads","issues_url":"https://api.github.com/repos/Mark-Simulacrum/rust/issues{/number}","pulls_url":"https://api.github.com/repos/Mark-Simulacrum/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/Mark-Simulacrum/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/Mark-Simulacrum/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mark-Simulacrum/rust/labels{/name}","releases_url":"https://api.github.com/repos/Mark-Simulacrum/rust/releases{/id}","deployments_url":"https://api.github.com/repos/Mark-Simulacrum/rust/deployments","created_at":"2016-08-11T21:46:30Z","updated_at":"2016-08-11T21:46:49Z","pushed_at":"2016-12-11T17:31:38Z","git_url":"git://github.com/Mark-Simulacrum/rust.git","ssh_url":"git@github.com:Mark-Simulacrum/rust.git","clone_url":"https://github.com/Mark-Simulacrum/rust.git","svn_url":"https://github.com/Mark-Simulacrum/rust","homepage":"https://www.rust-lang.org","size":314024,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"fd5dc057936f5d84ccd8c1d5965f60e669b589d8","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2016-12-11T17:45:44Z","pushed_at":"2016-12-11T18:15:49Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":534862,"stargazers_count":19321,"watchers_count":19321,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3708,"mirror_url":null,"open_issues_count":2979,"forks":3708,"open_issues":2979,"watchers":19321,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/38302"},"html":{"href":"https://github.com/rust-lang/rust/pull/38302"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/38302"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/38302/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/38302/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/38302/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/8046b2a205529a689f471ef63cc738d77c4a6d19"}}}}
{"actor":{"display_login":"eddyb"}}