{"action":"closed","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/26300","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/26300/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/26300/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/26300/events","html_url":"https://github.com/kubernetes/kubernetes/issues/26300","id":156846589,"number":26300,"title":"Set timeout for docker image pull calls","user":{"login":"yujuhong","id":10524058,"avatar_url":"https://avatars.githubusercontent.com/u/10524058?v=3","gravatar_id":"","url":"https://api.github.com/users/yujuhong","html_url":"https://github.com/yujuhong","followers_url":"https://api.github.com/users/yujuhong/followers","following_url":"https://api.github.com/users/yujuhong/following{/other_user}","gists_url":"https://api.github.com/users/yujuhong/gists{/gist_id}","starred_url":"https://api.github.com/users/yujuhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yujuhong/subscriptions","organizations_url":"https://api.github.com/users/yujuhong/orgs","repos_url":"https://api.github.com/users/yujuhong/repos","events_url":"https://api.github.com/users/yujuhong/events{/privacy}","received_events_url":"https://api.github.com/users/yujuhong/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/reliability","name":"area/reliability","color":"a10d01"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/team/node","name":"team/node","color":"d2b48c"}],"state":"closed","locked":false,"assignee":{"login":"Random-Liu","id":5821883,"avatar_url":"https://avatars.githubusercontent.com/u/5821883?v=3","gravatar_id":"","url":"https://api.github.com/users/Random-Liu","html_url":"https://github.com/Random-Liu","followers_url":"https://api.github.com/users/Random-Liu/followers","following_url":"https://api.github.com/users/Random-Liu/following{/other_user}","gists_url":"https://api.github.com/users/Random-Liu/gists{/gist_id}","starred_url":"https://api.github.com/users/Random-Liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Random-Liu/subscriptions","organizations_url":"https://api.github.com/users/Random-Liu/orgs","repos_url":"https://api.github.com/users/Random-Liu/repos","events_url":"https://api.github.com/users/Random-Liu/events{/privacy}","received_events_url":"https://api.github.com/users/Random-Liu/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2016-05-25T20:47:19Z","updated_at":"2016-06-03T11:02:20Z","closed_at":"2016-06-03T11:02:20Z","body":"We recently removed the timeout for image pulls because the default is too low (i.e. 2 min), and it's hard to gauge what time will work for the users.\r\n\r\nHowever, it's important that we set \"a certain\" timeout for such requests to resolve the cases where the request hangs indefinitely.\r\nOff the top of my head, there are two options:\r\n\r\n 1. Add the timeout back. Set the default to something longer (e.g., 10 minutes) and make it configurable through kubelet flags.\r\n 2. Detect whether the pull request is making progress by leveraging the pull progress reporter (#26145) and cancel the request if the progress has stalled over a threshold.\r\n\r\n/cc @kubernetes/sig-node "}}
{"actor":{"display_login":"k8s-merge-robot"}}