{"action":"created","issue":{"url":"https://api.github.com/repos/serverless/serverless/issues/2651","repository_url":"https://api.github.com/repos/serverless/serverless","labels_url":"https://api.github.com/repos/serverless/serverless/issues/2651/labels{/name}","comments_url":"https://api.github.com/repos/serverless/serverless/issues/2651/comments","events_url":"https://api.github.com/repos/serverless/serverless/issues/2651/events","html_url":"https://github.com/serverless/serverless/pull/2651","id":187698397,"number":2651,"title":"Fixes --noDeploy without credentials or internet connection","user":{"login":"laardee","id":4726921,"avatar_url":"https://avatars.githubusercontent.com/u/4726921?v=3","gravatar_id":"","url":"https://api.github.com/users/laardee","html_url":"https://github.com/laardee","followers_url":"https://api.github.com/users/laardee/followers","following_url":"https://api.github.com/users/laardee/following{/other_user}","gists_url":"https://api.github.com/users/laardee/gists{/gist_id}","starred_url":"https://api.github.com/users/laardee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laardee/subscriptions","organizations_url":"https://api.github.com/users/laardee/orgs","repos_url":"https://api.github.com/users/laardee/repos","events_url":"https://api.github.com/users/laardee/events{/privacy}","received_events_url":"https://api.github.com/users/laardee/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-11-07T12:22:26Z","updated_at":"2016-11-08T07:59:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/serverless/serverless/pulls/2651","html_url":"https://github.com/serverless/serverless/pull/2651","diff_url":"https://github.com/serverless/serverless/pull/2651.diff","patch_url":"https://github.com/serverless/serverless/pull/2651.patch"},"body":"<!--\r\n1. Please check out and follow our Contributing Guidelines: https://github.com/serverless/serverless/blob/master/CONTRIBUTING.md\r\n2. Do not remove any section of the template. If something is not applicable leave it empty but leave it in the PR\r\n3. Please follow the template, otherwise we'll have to ask you to update it and it will take longer until your PR is merged\r\n-->\r\n\r\n## What did you implement:\r\n\r\nCloses https://github.com/serverless/serverless/issues/2648\r\n\r\n**Before**\r\nWhen deploying without internet connection `serverless deploy --noDeploy` throws following error \r\n```\r\n  Error --------------------------------------------------\r\n\r\n     ServerlessError: ServerlessError: Inaccessible host:\r\n     `cloudformation.us-east-1.amazonaws.com'. This service\r\n     may not be available in the `us-east-1' region.\r\n\r\n     For debugging logs, run again after setting SLS_DEBUG env var.\r\n\r\n  Get Support --------------------------------------------\r\n     Docs:          docs.serverless.com\r\n     Bugs:          github.com/serverless/serverless/issues\r\n\r\n     Please report this error. We think it might be a bug.\r\n\r\n  Your Environment Information -----------------------------\r\n     OS:                 darwin\r\n     Node Version:       6.9.0\r\n     Serverless Version: 1.1.0\r\n```\r\nAnd without valid AWS credential following error is thrown:\r\n```\r\n  Error --------------------------------------------------\r\n\r\n     ServerlessError: ServerlessError: AWS provider credentials\r\n     not found. You can find more info on how to set up provider\r\n     credentials in our docs here: https://git.io/vXsdd\r\n\r\n     For debugging logs, run again after setting SLS_DEBUG env var.\r\n\r\n  Get Support --------------------------------------------\r\n     Docs:          docs.serverless.com\r\n     Bugs:          github.com/serverless/serverless/issues\r\n\r\n     Please report this error. We think it might be a bug.\r\n\r\n  Your Environment Information -----------------------------\r\n     OS:                 darwin\r\n     Node Version:       6.9.0\r\n     Serverless Version: 1.1.0\r\n```\r\n\r\n**After**\r\nRunning `serverless deploy --noDeploy` should only display following output\r\n```\r\nServerless: Packaging service…\r\nServerless: Did not deploy due to --noDeploy\r\n```\r\n\r\n\r\n<!--\r\nBriefly describe the feature if no issue exists for this PR\r\n-->\r\n\r\n## How did you implement it:\r\n\r\n<!--\r\nIf this is a nontrivial change please briefly describe your implementation so its easy for us to understand and review your code.\r\n-->\r\n\r\n## How can we verify it:\r\n\r\n1. Run `serverless deploy --noDeploy` without internet connection.\r\n2. Rename `~/.aws/crendentials` to `~/.aws/crendentials.bk` and run `serverless deploy --noDeploy`.\r\n\r\n<!--\r\nAdd any applicable config, commands, screenshots or other resources\r\nto make it easy for us to verify this works. The easier you make it for us\r\nto review a PR, the faster we can review and merge it.\r\n\r\nExamples:\r\n* serverless.yml - Fully functioning to easily deploy changes\r\n* Screenshots - Showing the difference between your output and the master\r\n* AWS CLI commands - To list AWS resources and show that the correct config is in place\r\n* Other - Anything else that comes to mind to help us evaluate\r\n-->\r\n\r\n\r\n## Todos:\r\n\r\n- [ ] Write tests\r\n- [ ] Write documentation\r\n- [ ] Fix linting errors\r\n- [ ] Make sure code coverage hasn't dropped\r\n- [ ] Provide verification config/commands/resources\r\n- [ ] Change ready for review message below\r\n\r\n\r\n***Is this ready for review?:*** NO\r\n"},"comment":{"url":"https://api.github.com/repos/serverless/serverless/issues/comments/259070149","html_url":"https://github.com/serverless/serverless/pull/2651#issuecomment-259070149","issue_url":"https://api.github.com/repos/serverless/serverless/issues/2651","id":259070149,"user":{"login":"eahefnawy","id":2312463,"avatar_url":"https://avatars.githubusercontent.com/u/2312463?v=3","gravatar_id":"","url":"https://api.github.com/users/eahefnawy","html_url":"https://github.com/eahefnawy","followers_url":"https://api.github.com/users/eahefnawy/followers","following_url":"https://api.github.com/users/eahefnawy/following{/other_user}","gists_url":"https://api.github.com/users/eahefnawy/gists{/gist_id}","starred_url":"https://api.github.com/users/eahefnawy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eahefnawy/subscriptions","organizations_url":"https://api.github.com/users/eahefnawy/orgs","repos_url":"https://api.github.com/users/eahefnawy/repos","events_url":"https://api.github.com/users/eahefnawy/events{/privacy}","received_events_url":"https://api.github.com/users/eahefnawy/received_events","type":"User","site_admin":false},"created_at":"2016-11-08T07:59:10Z","updated_at":"2016-11-08T07:59:10Z","body":"@flomotlik because custom deployment bucket happens in a single step, the framework needs to know whether this single step is a `create` or `update` to output the appropriate template locally, even if no deployment to happen. Hence the checking.\r\n\r\nYou can verify this issue with this PR by creating a new service with the following config:\r\n\r\n```yml\r\nservice: serverless-custom-bucket-no-deploy\r\n\r\nprovider:\r\n  name: aws\r\n  deploymentBucket: mycustombucket0 # bucket must exist in the same region\r\n\r\nfunctions:\r\n  hello:\r\n    handler: handler.hello\r\n```\r\n\r\nthen run `serverless deploy --noDeploy`. You'll find that `cloudformation-template-update-stack.json` is created in the `.serverless` folder, even though this is the first time you deploy the service, and it should be a `create` template instead."}}
{"actor":{"display_login":"eahefnawy"}}