{"action":"created","issue":{"url":"https://api.github.com/repos/ErikDeRoos/koningskerk-beamteam/issues/12","repository_url":"https://api.github.com/repos/ErikDeRoos/koningskerk-beamteam","labels_url":"https://api.github.com/repos/ErikDeRoos/koningskerk-beamteam/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/ErikDeRoos/koningskerk-beamteam/issues/12/comments","events_url":"https://api.github.com/repos/ErikDeRoos/koningskerk-beamteam/issues/12/events","html_url":"https://github.com/ErikDeRoos/koningskerk-beamteam/issues/12","id":135767263,"number":12,"title":"Testability - Unit tests","user":{"login":"ErikDeRoos","id":17176362,"avatar_url":"https://avatars.githubusercontent.com/u/17176362?v=3","gravatar_id":"","url":"https://api.github.com/users/ErikDeRoos","html_url":"https://github.com/ErikDeRoos","followers_url":"https://api.github.com/users/ErikDeRoos/followers","following_url":"https://api.github.com/users/ErikDeRoos/following{/other_user}","gists_url":"https://api.github.com/users/ErikDeRoos/gists{/gist_id}","starred_url":"https://api.github.com/users/ErikDeRoos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ErikDeRoos/subscriptions","organizations_url":"https://api.github.com/users/ErikDeRoos/orgs","repos_url":"https://api.github.com/users/ErikDeRoos/repos","events_url":"https://api.github.com/users/ErikDeRoos/events{/privacy}","received_events_url":"https://api.github.com/users/ErikDeRoos/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ErikDeRoos/koningskerk-beamteam/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/ErikDeRoos/koningskerk-beamteam/milestones/4","html_url":"https://github.com/ErikDeRoos/koningskerk-beamteam/milestones/Testability","labels_url":"https://api.github.com/repos/ErikDeRoos/koningskerk-beamteam/milestones/4/labels","id":1599931,"number":4,"title":"Testability","description":"De applicatie zou baat kunnen hebben bij automatische testen van delen van de code.\r\n\r\nMomenteel heeft de app geen documentatie en ook geen begeleidend schrijven waarom keuzes zijn gemaakt en wat verwacht gedrag is. Unit tests zouden daar al veel aan bij kunnen dragen.","creator":{"login":"ErikDeRoos","id":17176362,"avatar_url":"https://avatars.githubusercontent.com/u/17176362?v=3","gravatar_id":"","url":"https://api.github.com/users/ErikDeRoos","html_url":"https://github.com/ErikDeRoos","followers_url":"https://api.github.com/users/ErikDeRoos/followers","following_url":"https://api.github.com/users/ErikDeRoos/following{/other_user}","gists_url":"https://api.github.com/users/ErikDeRoos/gists{/gist_id}","starred_url":"https://api.github.com/users/ErikDeRoos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ErikDeRoos/subscriptions","organizations_url":"https://api.github.com/users/ErikDeRoos/orgs","repos_url":"https://api.github.com/users/ErikDeRoos/repos","events_url":"https://api.github.com/users/ErikDeRoos/events{/privacy}","received_events_url":"https://api.github.com/users/ErikDeRoos/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":0,"state":"open","created_at":"2016-02-23T15:20:49Z","updated_at":"2016-02-23T15:27:38Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2016-02-23T15:27:38Z","updated_at":"2016-04-28T08:54:52Z","closed_at":null,"body":"We kunnen invulling geven aan testability door belangrijke keuzes en werkingen af te dekken met unit tests. Dat gaan we in de branch testability_unittests doen.\r\nOok gaan we daar waar nodig DI (injection en inversion) verder uitwerken evenals seperation of concerns als dit nodig is voor unit testen.\r\n\r\nBekende problemen: Powerpoint generator is niet te testen in een unit test. Evenals het WinForms programma wat aanstuurt. \r\nAlleen als er belangrijke functionaliteit in zit wat zinvol is om door tests gedekt te worden dan zal het losgekoppeld mogen worden."},"comment":{"url":"https://api.github.com/repos/ErikDeRoos/koningskerk-beamteam/issues/comments/215356935","html_url":"https://github.com/ErikDeRoos/koningskerk-beamteam/issues/12#issuecomment-215356935","issue_url":"https://api.github.com/repos/ErikDeRoos/koningskerk-beamteam/issues/12","id":215356935,"user":{"login":"ErikDeRoos","id":17176362,"avatar_url":"https://avatars.githubusercontent.com/u/17176362?v=3","gravatar_id":"","url":"https://api.github.com/users/ErikDeRoos","html_url":"https://github.com/ErikDeRoos","followers_url":"https://api.github.com/users/ErikDeRoos/followers","following_url":"https://api.github.com/users/ErikDeRoos/following{/other_user}","gists_url":"https://api.github.com/users/ErikDeRoos/gists{/gist_id}","starred_url":"https://api.github.com/users/ErikDeRoos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ErikDeRoos/subscriptions","organizations_url":"https://api.github.com/users/ErikDeRoos/orgs","repos_url":"https://api.github.com/users/ErikDeRoos/repos","events_url":"https://api.github.com/users/ErikDeRoos/events{/privacy}","received_events_url":"https://api.github.com/users/ErikDeRoos/received_events","type":"User","site_admin":false},"created_at":"2016-04-28T08:54:52Z","updated_at":"2016-04-28T08:54:52Z","body":"Voortgang\r\n\r\nAfgedekt door Unit Tests:\r\n- Oplossen liturgie regels\r\n- Verzoeken aan de database\r\n- Visualisatie van liturgie regels\r\n\r\nGebieden die nog aandacht vereisen:\r\n- Functionaliteit op forms zoals laden/opslaan van instellingen en (tijdelijke) liturgie bestanden.\r\n- Daadwerkelijke generatie proces"}}