{"action":"created","issue":{"url":"https://api.github.com/repos/owen234/ra2b2016gh/issues/4","repository_url":"https://api.github.com/repos/owen234/ra2b2016gh","labels_url":"https://api.github.com/repos/owen234/ra2b2016gh/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/owen234/ra2b2016gh/issues/4/comments","events_url":"https://api.github.com/repos/owen234/ra2b2016gh/issues/4/events","html_url":"https://github.com/owen234/ra2b2016gh/pull/4","id":169393811,"number":4,"title":"Adding NJets=2 option to files doSkimSlim.c, data_turnon1.c, fill_data_hists_loop_v2d.c, fill_hists_loop_v2d.c, make_qcdmc_input_files1.c and adding binning.h and run_all.C files","user":{"login":"aminghiasi","id":12805440,"avatar_url":"https://avatars.githubusercontent.com/u/12805440?v=3","gravatar_id":"","url":"https://api.github.com/users/aminghiasi","html_url":"https://github.com/aminghiasi","followers_url":"https://api.github.com/users/aminghiasi/followers","following_url":"https://api.github.com/users/aminghiasi/following{/other_user}","gists_url":"https://api.github.com/users/aminghiasi/gists{/gist_id}","starred_url":"https://api.github.com/users/aminghiasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aminghiasi/subscriptions","organizations_url":"https://api.github.com/users/aminghiasi/orgs","repos_url":"https://api.github.com/users/aminghiasi/repos","events_url":"https://api.github.com/users/aminghiasi/events{/privacy}","received_events_url":"https://api.github.com/users/aminghiasi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-08-04T14:51:23Z","updated_at":"2016-08-04T17:49:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/owen234/ra2b2016gh/pulls/4","html_url":"https://github.com/owen234/ra2b2016gh/pull/4","diff_url":"https://github.com/owen234/ra2b2016gh/pull/4.diff","patch_url":"https://github.com/owen234/ra2b2016gh/pull/4.patch"},"body":"Hi Owen,\r\n\r\nThis is what I have done in this pull request:\r\n\r\n1. I added two files to the repository\r\n\r\n1-a: binning.h: I created a new file that determines the binning (It's a copy of setup_bins() function in \r\nfill_data_hists_loop_v2d.c ). My goal was to have a central definition of binning so if in the future we want to change the binning again, we would only need to change binning.h  and all other parts of the code would automatically inherit the changes in binning. \r\n\r\n1-b: run_all.C: This file will automatically produce all the plots and tables. In other words, my goal is to put all your instructions in this file so we can do everything automatically. I will add every file that I update (to include NJets = 2 option) to run_all.C so I will complete it step by step. \r\nThis file has two options:  run_all(true) will also skim-slim the root files and then produce the results, However, run_all() will only produce the plots and tables using the existing root files. \r\n\r\n\r\n2. I have updated files doSkimSlim.c, data_turnon1.c, fill_data_hists_loop_v2d.c, fill_hists_loop_v2d.c, make_qcdmc_input_files1.c to inherit the binning from binning.h (and therefore being able to run with NJets = 2 included or excluded) \r\n\r\n3. In order to check if the updated files produce the correct results, I did two tests:\r\n\r\n3.1: I turned off the NJets = 2 option (changed binning.h) and compared the results of updated and original codes. The results were exactly the same. \r\n\r\n3.2: I skim-slimed a set of root file with your original code (Excluding all NJets = 2 events). Then I turned on the NJets = 2 option in binning.h and compared the results of updated and original codes.  If I run the updated and original versions of the codes on this set of root files (skim-slimmed), the results should be the same. Because although the NJets = 2 option is on, there is no event with NJets = 2 in the root files (I removed them using your skim-slim code) therefore, all the plots related to NJets = 2 should be empty and other plots should be unchanged. After doing this, I saw that all the plots were unchanged (and NJets = 2 plots were empty)\r\n\r\n4. Now I am working on updating modelfit3.c. As you know, this file will fit the QCD toy model parameters to match the data we have taken at CMS. However, I am not sure if you want to include NJets = 2 in fitting. I mean, do you want to do the fitting including NJets = 2 or you want to exclude NJets = 2, do the fitting and just check how well it matches the NJets = 2 area? I hope my question is clear!\r\n\r\nBest,\r\nAmin"},"comment":{"url":"https://api.github.com/repos/owen234/ra2b2016gh/issues/comments/237629853","html_url":"https://github.com/owen234/ra2b2016gh/pull/4#issuecomment-237629853","issue_url":"https://api.github.com/repos/owen234/ra2b2016gh/issues/4","id":237629853,"user":{"login":"owen234","id":4981485,"avatar_url":"https://avatars.githubusercontent.com/u/4981485?v=3","gravatar_id":"","url":"https://api.github.com/users/owen234","html_url":"https://github.com/owen234","followers_url":"https://api.github.com/users/owen234/followers","following_url":"https://api.github.com/users/owen234/following{/other_user}","gists_url":"https://api.github.com/users/owen234/gists{/gist_id}","starred_url":"https://api.github.com/users/owen234/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owen234/subscriptions","organizations_url":"https://api.github.com/users/owen234/orgs","repos_url":"https://api.github.com/users/owen234/repos","events_url":"https://api.github.com/users/owen234/events{/privacy}","received_events_url":"https://api.github.com/users/owen234/received_events","type":"User","site_admin":false},"created_at":"2016-08-04T17:49:43Z","updated_at":"2016-08-04T17:49:43Z","body":"Hi Amin,\r\nOk, I'm going to try merging in your pull request into the master.\r\nOwen"}}
{"actor":{"display_login":"owen234"}}