{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/4455","repository_url":"https://api.github.com/repos/mozilla/fxa-content-server","labels_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/4455/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/4455/comments","events_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/4455/events","html_url":"https://github.com/mozilla/fxa-content-server/pull/4455","id":191575636,"number":4455,"title":"fix(client): Visible success/error messages stay visible on view render","user":{"login":"shane-tomlinson","id":848085,"avatar_url":"https://avatars.githubusercontent.com/u/848085?v=3","gravatar_id":"","url":"https://api.github.com/users/shane-tomlinson","html_url":"https://github.com/shane-tomlinson","followers_url":"https://api.github.com/users/shane-tomlinson/followers","following_url":"https://api.github.com/users/shane-tomlinson/following{/other_user}","gists_url":"https://api.github.com/users/shane-tomlinson/gists{/gist_id}","starred_url":"https://api.github.com/users/shane-tomlinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shane-tomlinson/subscriptions","organizations_url":"https://api.github.com/users/shane-tomlinson/orgs","repos_url":"https://api.github.com/users/shane-tomlinson/repos","events_url":"https://api.github.com/users/shane-tomlinson/events{/privacy}","received_events_url":"https://api.github.com/users/shane-tomlinson/received_events","type":"User","site_admin":false},"labels":[{"id":346099260,"url":"https://api.github.com/repos/mozilla/fxa-content-server/labels/waffle:active","name":"waffle:active","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"philbooth","id":64367,"avatar_url":"https://avatars.githubusercontent.com/u/64367?v=3","gravatar_id":"","url":"https://api.github.com/users/philbooth","html_url":"https://github.com/philbooth","followers_url":"https://api.github.com/users/philbooth/followers","following_url":"https://api.github.com/users/philbooth/following{/other_user}","gists_url":"https://api.github.com/users/philbooth/gists{/gist_id}","starred_url":"https://api.github.com/users/philbooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philbooth/subscriptions","organizations_url":"https://api.github.com/users/philbooth/orgs","repos_url":"https://api.github.com/users/philbooth/repos","events_url":"https://api.github.com/users/philbooth/events{/privacy}","received_events_url":"https://api.github.com/users/philbooth/received_events","type":"User","site_admin":false},"assignees":[{"login":"philbooth","id":64367,"avatar_url":"https://avatars.githubusercontent.com/u/64367?v=3","gravatar_id":"","url":"https://api.github.com/users/philbooth","html_url":"https://github.com/philbooth","followers_url":"https://api.github.com/users/philbooth/followers","following_url":"https://api.github.com/users/philbooth/following{/other_user}","gists_url":"https://api.github.com/users/philbooth/gists{/gist_id}","starred_url":"https://api.github.com/users/philbooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philbooth/subscriptions","organizations_url":"https://api.github.com/users/philbooth/orgs","repos_url":"https://api.github.com/users/philbooth/repos","events_url":"https://api.github.com/users/philbooth/events{/privacy}","received_events_url":"https://api.github.com/users/philbooth/received_events","type":"User","site_admin":false},{"login":"vladikoff","id":128755,"avatar_url":"https://avatars.githubusercontent.com/u/128755?v=3","gravatar_id":"","url":"https://api.github.com/users/vladikoff","html_url":"https://github.com/vladikoff","followers_url":"https://api.github.com/users/vladikoff/followers","following_url":"https://api.github.com/users/vladikoff/following{/other_user}","gists_url":"https://api.github.com/users/vladikoff/gists{/gist_id}","starred_url":"https://api.github.com/users/vladikoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladikoff/subscriptions","organizations_url":"https://api.github.com/users/vladikoff/orgs","repos_url":"https://api.github.com/users/vladikoff/repos","events_url":"https://api.github.com/users/vladikoff/events{/privacy}","received_events_url":"https://api.github.com/users/vladikoff/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-11-24T18:23:26Z","updated_at":"2016-11-25T10:31:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/4455","html_url":"https://github.com/mozilla/fxa-content-server/pull/4455","diff_url":"https://github.com/mozilla/fxa-content-server/pull/4455.diff","patch_url":"https://github.com/mozilla/fxa-content-server/pull/4455.patch"},"body":"Separate `enableSubmitIfValid` into two functions, `onFormChange`\r\nand `enableSubmitIfValid`. `onFormChange` takes care of hiding\r\nstatus messages `enableSubmitIfValid` only enables the submit button\r\nif the form is valid. `enableSubmitIfValid` is called after\r\nthe view is rendered.\r\n\r\nBecause of this change, the `enableSubmitIfValid` override in\r\n`settings/communication_preferences` is no longer needed.\r\n\r\nA new test template was needed to prevent other tests from failing.\r\n\r\nThis is an extraction from https://github.com/mozilla/fxa-content-server/pull/4370\r\n\r\n@vladikoff or @philbooth - r?"},"comment":{"url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/comments/262927302","html_url":"https://github.com/mozilla/fxa-content-server/pull/4455#issuecomment-262927302","issue_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/4455","id":262927302,"user":{"login":"shane-tomlinson","id":848085,"avatar_url":"https://avatars.githubusercontent.com/u/848085?v=3","gravatar_id":"","url":"https://api.github.com/users/shane-tomlinson","html_url":"https://github.com/shane-tomlinson","followers_url":"https://api.github.com/users/shane-tomlinson/followers","following_url":"https://api.github.com/users/shane-tomlinson/following{/other_user}","gists_url":"https://api.github.com/users/shane-tomlinson/gists{/gist_id}","starred_url":"https://api.github.com/users/shane-tomlinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shane-tomlinson/subscriptions","organizations_url":"https://api.github.com/users/shane-tomlinson/orgs","repos_url":"https://api.github.com/users/shane-tomlinson/repos","events_url":"https://api.github.com/users/shane-tomlinson/events{/privacy}","received_events_url":"https://api.github.com/users/shane-tomlinson/received_events","type":"User","site_admin":false},"created_at":"2016-11-25T10:31:37Z","updated_at":"2016-11-25T10:31:37Z","body":"@philbooth - mind doing a review of the 2nd commit on this? I made some substantial changes to ensure `isSuccessVisible` and `isErrorVisible` return the correct value if the status messages are displayed via the template."}}
{"actor":{"display_login":"shane-tomlinson"}}