{"action":"closed","number":1634,"pull_request":{"url":"https://api.github.com/repos/rejectedsoftware/vibe.d/pulls/1634","id":95380698,"html_url":"https://github.com/rejectedsoftware/vibe.d/pull/1634","diff_url":"https://github.com/rejectedsoftware/vibe.d/pull/1634.diff","patch_url":"https://github.com/rejectedsoftware/vibe.d/pull/1634.patch","issue_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/issues/1634","number":1634,"state":"closed","locked":false,"title":"fix #716 (Add partial content with range)","user":{"login":"WebFreak001","id":2035977,"avatar_url":"https://avatars.githubusercontent.com/u/2035977?v=3","gravatar_id":"","url":"https://api.github.com/users/WebFreak001","html_url":"https://github.com/WebFreak001","followers_url":"https://api.github.com/users/WebFreak001/followers","following_url":"https://api.github.com/users/WebFreak001/following{/other_user}","gists_url":"https://api.github.com/users/WebFreak001/gists{/gist_id}","starred_url":"https://api.github.com/users/WebFreak001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebFreak001/subscriptions","organizations_url":"https://api.github.com/users/WebFreak001/orgs","repos_url":"https://api.github.com/users/WebFreak001/repos","events_url":"https://api.github.com/users/WebFreak001/events{/privacy}","received_events_url":"https://api.github.com/users/WebFreak001/received_events","type":"User","site_admin":false},"body":"Mostly based on https://github.com/rejectedsoftware/vibe.d/issues/716#issuecomment-220606604\r\n\r\nChanges to that comment: added `-[X]` format and sending partialContent status code. Also some cleaner code and checks against bad requests.\r\n\r\nNot sure how to add an automatic test but I did manually test it locally using this very simple file server in chrome and firefox:\r\n\r\n```d\r\nimport vibe.http.server;\r\nimport vibe.http.fileserver;\r\n\r\nshared static this()\r\n{\r\n\tauto settings = new HTTPServerSettings;\r\n\tsettings.port = 10716;\r\n\tlistenHTTP(settings, serveStaticFiles(\"data\"));\r\n}\r\n```\r\n\r\nMy aim was only fixing media streams (audio & video + seeking), but pausing downloads and resuming also works now.","created_at":"2016-11-26T19:36:12Z","updated_at":"2016-11-27T16:23:28Z","closed_at":"2016-11-27T16:23:28Z","merged_at":"2016-11-27T16:23:28Z","merge_commit_sha":"680526765b68101ae191d29811c76301dba5c4e0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/pulls/1634/commits","review_comments_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/pulls/1634/comments","review_comment_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/issues/1634/comments","statuses_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/statuses/85e6ea1cd2b6d09259893408673a0721631bf7ef","head":{"label":"WebFreak001:master","ref":"master","sha":"85e6ea1cd2b6d09259893408673a0721631bf7ef","user":{"login":"WebFreak001","id":2035977,"avatar_url":"https://avatars.githubusercontent.com/u/2035977?v=3","gravatar_id":"","url":"https://api.github.com/users/WebFreak001","html_url":"https://github.com/WebFreak001","followers_url":"https://api.github.com/users/WebFreak001/followers","following_url":"https://api.github.com/users/WebFreak001/following{/other_user}","gists_url":"https://api.github.com/users/WebFreak001/gists{/gist_id}","starred_url":"https://api.github.com/users/WebFreak001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebFreak001/subscriptions","organizations_url":"https://api.github.com/users/WebFreak001/orgs","repos_url":"https://api.github.com/users/WebFreak001/repos","events_url":"https://api.github.com/users/WebFreak001/events{/privacy}","received_events_url":"https://api.github.com/users/WebFreak001/received_events","type":"User","site_admin":false},"repo":{"id":74841896,"name":"vibe.d","full_name":"WebFreak001/vibe.d","owner":{"login":"WebFreak001","id":2035977,"avatar_url":"https://avatars.githubusercontent.com/u/2035977?v=3","gravatar_id":"","url":"https://api.github.com/users/WebFreak001","html_url":"https://github.com/WebFreak001","followers_url":"https://api.github.com/users/WebFreak001/followers","following_url":"https://api.github.com/users/WebFreak001/following{/other_user}","gists_url":"https://api.github.com/users/WebFreak001/gists{/gist_id}","starred_url":"https://api.github.com/users/WebFreak001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebFreak001/subscriptions","organizations_url":"https://api.github.com/users/WebFreak001/orgs","repos_url":"https://api.github.com/users/WebFreak001/repos","events_url":"https://api.github.com/users/WebFreak001/events{/privacy}","received_events_url":"https://api.github.com/users/WebFreak001/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/WebFreak001/vibe.d","description":"Official vibe.d development","fork":true,"url":"https://api.github.com/repos/WebFreak001/vibe.d","forks_url":"https://api.github.com/repos/WebFreak001/vibe.d/forks","keys_url":"https://api.github.com/repos/WebFreak001/vibe.d/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WebFreak001/vibe.d/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WebFreak001/vibe.d/teams","hooks_url":"https://api.github.com/repos/WebFreak001/vibe.d/hooks","issue_events_url":"https://api.github.com/repos/WebFreak001/vibe.d/issues/events{/number}","events_url":"https://api.github.com/repos/WebFreak001/vibe.d/events","assignees_url":"https://api.github.com/repos/WebFreak001/vibe.d/assignees{/user}","branches_url":"https://api.github.com/repos/WebFreak001/vibe.d/branches{/branch}","tags_url":"https://api.github.com/repos/WebFreak001/vibe.d/tags","blobs_url":"https://api.github.com/repos/WebFreak001/vibe.d/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WebFreak001/vibe.d/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WebFreak001/vibe.d/git/refs{/sha}","trees_url":"https://api.github.com/repos/WebFreak001/vibe.d/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WebFreak001/vibe.d/statuses/{sha}","languages_url":"https://api.github.com/repos/WebFreak001/vibe.d/languages","stargazers_url":"https://api.github.com/repos/WebFreak001/vibe.d/stargazers","contributors_url":"https://api.github.com/repos/WebFreak001/vibe.d/contributors","subscribers_url":"https://api.github.com/repos/WebFreak001/vibe.d/subscribers","subscription_url":"https://api.github.com/repos/WebFreak001/vibe.d/subscription","commits_url":"https://api.github.com/repos/WebFreak001/vibe.d/commits{/sha}","git_commits_url":"https://api.github.com/repos/WebFreak001/vibe.d/git/commits{/sha}","comments_url":"https://api.github.com/repos/WebFreak001/vibe.d/comments{/number}","issue_comment_url":"https://api.github.com/repos/WebFreak001/vibe.d/issues/comments{/number}","contents_url":"https://api.github.com/repos/WebFreak001/vibe.d/contents/{+path}","compare_url":"https://api.github.com/repos/WebFreak001/vibe.d/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WebFreak001/vibe.d/merges","archive_url":"https://api.github.com/repos/WebFreak001/vibe.d/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WebFreak001/vibe.d/downloads","issues_url":"https://api.github.com/repos/WebFreak001/vibe.d/issues{/number}","pulls_url":"https://api.github.com/repos/WebFreak001/vibe.d/pulls{/number}","milestones_url":"https://api.github.com/repos/WebFreak001/vibe.d/milestones{/number}","notifications_url":"https://api.github.com/repos/WebFreak001/vibe.d/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WebFreak001/vibe.d/labels{/name}","releases_url":"https://api.github.com/repos/WebFreak001/vibe.d/releases{/id}","deployments_url":"https://api.github.com/repos/WebFreak001/vibe.d/deployments","created_at":"2016-11-26T18:00:27Z","updated_at":"2016-11-26T18:00:29Z","pushed_at":"2016-11-27T13:50:08Z","git_url":"git://github.com/WebFreak001/vibe.d.git","ssh_url":"git@github.com:WebFreak001/vibe.d.git","clone_url":"https://github.com/WebFreak001/vibe.d.git","svn_url":"https://github.com/WebFreak001/vibe.d","homepage":null,"size":17018,"stargazers_count":0,"watchers_count":0,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rejectedsoftware:master","ref":"master","sha":"dbfb12c6780bcc417fb65c86fc84ff84634f906d","user":{"login":"rejectedsoftware","id":1661098,"avatar_url":"https://avatars.githubusercontent.com/u/1661098?v=3","gravatar_id":"","url":"https://api.github.com/users/rejectedsoftware","html_url":"https://github.com/rejectedsoftware","followers_url":"https://api.github.com/users/rejectedsoftware/followers","following_url":"https://api.github.com/users/rejectedsoftware/following{/other_user}","gists_url":"https://api.github.com/users/rejectedsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/rejectedsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rejectedsoftware/subscriptions","organizations_url":"https://api.github.com/users/rejectedsoftware/orgs","repos_url":"https://api.github.com/users/rejectedsoftware/repos","events_url":"https://api.github.com/users/rejectedsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/rejectedsoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":4081150,"name":"vibe.d","full_name":"rejectedsoftware/vibe.d","owner":{"login":"rejectedsoftware","id":1661098,"avatar_url":"https://avatars.githubusercontent.com/u/1661098?v=3","gravatar_id":"","url":"https://api.github.com/users/rejectedsoftware","html_url":"https://github.com/rejectedsoftware","followers_url":"https://api.github.com/users/rejectedsoftware/followers","following_url":"https://api.github.com/users/rejectedsoftware/following{/other_user}","gists_url":"https://api.github.com/users/rejectedsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/rejectedsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rejectedsoftware/subscriptions","organizations_url":"https://api.github.com/users/rejectedsoftware/orgs","repos_url":"https://api.github.com/users/rejectedsoftware/repos","events_url":"https://api.github.com/users/rejectedsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/rejectedsoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rejectedsoftware/vibe.d","description":"Official vibe.d development","fork":false,"url":"https://api.github.com/repos/rejectedsoftware/vibe.d","forks_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/forks","keys_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/teams","hooks_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/hooks","issue_events_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/issues/events{/number}","events_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/events","assignees_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/assignees{/user}","branches_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/branches{/branch}","tags_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/tags","blobs_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/git/refs{/sha}","trees_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/statuses/{sha}","languages_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/languages","stargazers_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/stargazers","contributors_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/contributors","subscribers_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/subscribers","subscription_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/subscription","commits_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/commits{/sha}","git_commits_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/git/commits{/sha}","comments_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/comments{/number}","issue_comment_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/issues/comments{/number}","contents_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/contents/{+path}","compare_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/merges","archive_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/downloads","issues_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/issues{/number}","pulls_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/pulls{/number}","milestones_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/milestones{/number}","notifications_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/labels{/name}","releases_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/releases{/id}","deployments_url":"https://api.github.com/repos/rejectedsoftware/vibe.d/deployments","created_at":"2012-04-19T23:10:11Z","updated_at":"2016-11-27T13:32:08Z","pushed_at":"2016-11-27T16:23:29Z","git_url":"git://github.com/rejectedsoftware/vibe.d.git","ssh_url":"git@github.com:rejectedsoftware/vibe.d.git","clone_url":"https://github.com/rejectedsoftware/vibe.d.git","svn_url":"https://github.com/rejectedsoftware/vibe.d","homepage":null,"size":24733,"stargazers_count":785,"watchers_count":785,"language":"D","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":224,"mirror_url":null,"open_issues_count":306,"forks":224,"open_issues":306,"watchers":785,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rejectedsoftware/vibe.d/pulls/1634"},"html":{"href":"https://github.com/rejectedsoftware/vibe.d/pull/1634"},"issue":{"href":"https://api.github.com/repos/rejectedsoftware/vibe.d/issues/1634"},"comments":{"href":"https://api.github.com/repos/rejectedsoftware/vibe.d/issues/1634/comments"},"review_comments":{"href":"https://api.github.com/repos/rejectedsoftware/vibe.d/pulls/1634/comments"},"review_comment":{"href":"https://api.github.com/repos/rejectedsoftware/vibe.d/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rejectedsoftware/vibe.d/pulls/1634/commits"},"statuses":{"href":"https://api.github.com/repos/rejectedsoftware/vibe.d/statuses/85e6ea1cd2b6d09259893408673a0721631bf7ef"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"s-ludwig","id":1645969,"avatar_url":"https://avatars.githubusercontent.com/u/1645969?v=3","gravatar_id":"","url":"https://api.github.com/users/s-ludwig","html_url":"https://github.com/s-ludwig","followers_url":"https://api.github.com/users/s-ludwig/followers","following_url":"https://api.github.com/users/s-ludwig/following{/other_user}","gists_url":"https://api.github.com/users/s-ludwig/gists{/gist_id}","starred_url":"https://api.github.com/users/s-ludwig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-ludwig/subscriptions","organizations_url":"https://api.github.com/users/s-ludwig/orgs","repos_url":"https://api.github.com/users/s-ludwig/repos","events_url":"https://api.github.com/users/s-ludwig/events{/privacy}","received_events_url":"https://api.github.com/users/s-ludwig/received_events","type":"User","site_admin":false},"comments":3,"review_comments":5,"commits":3,"additions":48,"deletions":5,"changed_files":1}}
{"actor":{"display_login":"s-ludwig"}}