{"action":"created","issue":{"url":"https://api.github.com/repos/juju/utils/issues/195","repository_url":"https://api.github.com/repos/juju/utils","labels_url":"https://api.github.com/repos/juju/utils/issues/195/labels{/name}","comments_url":"https://api.github.com/repos/juju/utils/issues/195/comments","events_url":"https://api.github.com/repos/juju/utils/issues/195/events","html_url":"https://github.com/juju/utils/pull/195","id":135549337,"number":195,"title":"fixes bug #1515289","user":{"login":"cherylj","id":8780970,"avatar_url":"https://avatars.githubusercontent.com/u/8780970?v=3","gravatar_id":"","url":"https://api.github.com/users/cherylj","html_url":"https://github.com/cherylj","followers_url":"https://api.github.com/users/cherylj/followers","following_url":"https://api.github.com/users/cherylj/following{/other_user}","gists_url":"https://api.github.com/users/cherylj/gists{/gist_id}","starred_url":"https://api.github.com/users/cherylj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cherylj/subscriptions","organizations_url":"https://api.github.com/users/cherylj/orgs","repos_url":"https://api.github.com/users/cherylj/repos","events_url":"https://api.github.com/users/cherylj/events{/privacy}","received_events_url":"https://api.github.com/users/cherylj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-02-22T21:28:27Z","updated_at":"2016-02-22T22:17:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/juju/utils/pulls/195","html_url":"https://github.com/juju/utils/pull/195","diff_url":"https://github.com/juju/utils/pull/195.diff","patch_url":"https://github.com/juju/utils/pull/195.patch"},"body":"Cherry-pick from: https://github.com/juju/utils/pull/186\r\n\r\nWe werent setting the proxy field in the HTTP transport struct, which is what\r\nthe http Client uses to figure out how to proxy... so of course, we weren't\r\nrespecting the environment proxy. Oddly enough, tools download is the only logic\r\nusing this code. (However a later patch I'm going to land will cause the metric\r\nsender to use this code as well, since it's rolling its own tls transport, and\r\nmaking the same mistakes.\r\n\r\nAdded a TLS handshake timeout identical to the one used by the default http client,\r\nso behavior will be consistent with the default.\r\n\r\nFor reference, this is the default transport used by the http client:\r\n\r\nvar DefaultTransport RoundTripper = &Transport{\r\n        Proxy: ProxyFromEnvironment,\r\n        Dial: (&net.Dialer{\r\n                Timeout:   30 * time.Second,\r\n                KeepAlive: 30 * time.Second,\r\n        }).Dial,\r\n        TLSHandshakeTimeout: 10 * time.Second,\r\n}\r\n(from https://golang.org/pkg/net/http/#DefaultTransport)\r\n\r\n\n\n(Review request: http://reviews.vapour.ws/r/3935/)"},"comment":{"url":"https://api.github.com/repos/juju/utils/issues/comments/187413718","html_url":"https://github.com/juju/utils/pull/195#issuecomment-187413718","issue_url":"https://api.github.com/repos/juju/utils/issues/195","id":187413718,"user":{"login":"jujubot","id":7779494,"avatar_url":"https://avatars.githubusercontent.com/u/7779494?v=3","gravatar_id":"","url":"https://api.github.com/users/jujubot","html_url":"https://github.com/jujubot","followers_url":"https://api.github.com/users/jujubot/followers","following_url":"https://api.github.com/users/jujubot/following{/other_user}","gists_url":"https://api.github.com/users/jujubot/gists{/gist_id}","starred_url":"https://api.github.com/users/jujubot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jujubot/subscriptions","organizations_url":"https://api.github.com/users/jujubot/orgs","repos_url":"https://api.github.com/users/jujubot/repos","events_url":"https://api.github.com/users/jujubot/events{/privacy}","received_events_url":"https://api.github.com/users/jujubot/received_events","type":"User","site_admin":false},"created_at":"2016-02-22T22:17:08Z","updated_at":"2016-02-22T22:17:08Z","body":"Build failed: Tests failed\n        build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-utils/89\n"}}