{"action":"closed","number":1278,"pull_request":{"url":"https://api.github.com/repos/summernote/summernote/pulls/1278","id":42520699,"html_url":"https://github.com/summernote/summernote/pull/1278","diff_url":"https://github.com/summernote/summernote/pull/1278.diff","patch_url":"https://github.com/summernote/summernote/pull/1278.patch","issue_url":"https://api.github.com/repos/summernote/summernote/issues/1278","number":1278,"state":"closed","locked":false,"title":"Fix URL protocol on links added from selected text","user":{"login":"mstred","id":1061950,"avatar_url":"https://avatars.githubusercontent.com/u/1061950?v=3","gravatar_id":"","url":"https://api.github.com/users/mstred","html_url":"https://github.com/mstred","followers_url":"https://api.github.com/users/mstred/followers","following_url":"https://api.github.com/users/mstred/following{/other_user}","gists_url":"https://api.github.com/users/mstred/gists{/gist_id}","starred_url":"https://api.github.com/users/mstred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstred/subscriptions","organizations_url":"https://api.github.com/users/mstred/orgs","repos_url":"https://api.github.com/users/mstred/repos","events_url":"https://api.github.com/users/mstred/events{/privacy}","received_events_url":"https://api.github.com/users/mstred/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\n\r\n- Provides \"http://\" as default URI schema protocol, when creating links from selected text in editor\r\n\r\n#### Where should the reviewer start?\r\n\r\n- `src/js/module/Editor.js`\r\n\r\n#### How should this be manually tested?\r\n\r\nFollow steps in #1274.\r\n\r\n#### Any background context you want to provide?\r\n\r\n- This is quite useful when creating links such as `github.com`.\r\n- It fixes a bug for external domains, as described above, but is still invalid for relative links in the same domain (needs review).\r\n\r\n#### What are the relevant tickets?\r\n\r\n#1274","created_at":"2015-08-15T15:17:24Z","updated_at":"2016-05-30T18:57:31Z","closed_at":"2016-05-30T18:57:31Z","merged_at":null,"merge_commit_sha":"c85bdb811ee3bb6da4cbf24139659547f26d911c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/summernote/summernote/pulls/1278/commits","review_comments_url":"https://api.github.com/repos/summernote/summernote/pulls/1278/comments","review_comment_url":"https://api.github.com/repos/summernote/summernote/pulls/comments{/number}","comments_url":"https://api.github.com/repos/summernote/summernote/issues/1278/comments","statuses_url":"https://api.github.com/repos/summernote/summernote/statuses/e8b5111646b31048780a68e52e10a4c7f75ce18e","head":{"label":"mstred:fix/url_protocol","ref":"fix/url_protocol","sha":"e8b5111646b31048780a68e52e10a4c7f75ce18e","user":{"login":"mstred","id":1061950,"avatar_url":"https://avatars.githubusercontent.com/u/1061950?v=3","gravatar_id":"","url":"https://api.github.com/users/mstred","html_url":"https://github.com/mstred","followers_url":"https://api.github.com/users/mstred/followers","following_url":"https://api.github.com/users/mstred/following{/other_user}","gists_url":"https://api.github.com/users/mstred/gists{/gist_id}","starred_url":"https://api.github.com/users/mstred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstred/subscriptions","organizations_url":"https://api.github.com/users/mstred/orgs","repos_url":"https://api.github.com/users/mstred/repos","events_url":"https://api.github.com/users/mstred/events{/privacy}","received_events_url":"https://api.github.com/users/mstred/received_events","type":"User","site_admin":false},"repo":{"id":33139885,"name":"summernote","full_name":"mstred/summernote","owner":{"login":"mstred","id":1061950,"avatar_url":"https://avatars.githubusercontent.com/u/1061950?v=3","gravatar_id":"","url":"https://api.github.com/users/mstred","html_url":"https://github.com/mstred","followers_url":"https://api.github.com/users/mstred/followers","following_url":"https://api.github.com/users/mstred/following{/other_user}","gists_url":"https://api.github.com/users/mstred/gists{/gist_id}","starred_url":"https://api.github.com/users/mstred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstred/subscriptions","organizations_url":"https://api.github.com/users/mstred/orgs","repos_url":"https://api.github.com/users/mstred/repos","events_url":"https://api.github.com/users/mstred/events{/privacy}","received_events_url":"https://api.github.com/users/mstred/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mstred/summernote","description":"Super simple WYSIWYG Editor using Bootstrap","fork":true,"url":"https://api.github.com/repos/mstred/summernote","forks_url":"https://api.github.com/repos/mstred/summernote/forks","keys_url":"https://api.github.com/repos/mstred/summernote/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mstred/summernote/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mstred/summernote/teams","hooks_url":"https://api.github.com/repos/mstred/summernote/hooks","issue_events_url":"https://api.github.com/repos/mstred/summernote/issues/events{/number}","events_url":"https://api.github.com/repos/mstred/summernote/events","assignees_url":"https://api.github.com/repos/mstred/summernote/assignees{/user}","branches_url":"https://api.github.com/repos/mstred/summernote/branches{/branch}","tags_url":"https://api.github.com/repos/mstred/summernote/tags","blobs_url":"https://api.github.com/repos/mstred/summernote/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mstred/summernote/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mstred/summernote/git/refs{/sha}","trees_url":"https://api.github.com/repos/mstred/summernote/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mstred/summernote/statuses/{sha}","languages_url":"https://api.github.com/repos/mstred/summernote/languages","stargazers_url":"https://api.github.com/repos/mstred/summernote/stargazers","contributors_url":"https://api.github.com/repos/mstred/summernote/contributors","subscribers_url":"https://api.github.com/repos/mstred/summernote/subscribers","subscription_url":"https://api.github.com/repos/mstred/summernote/subscription","commits_url":"https://api.github.com/repos/mstred/summernote/commits{/sha}","git_commits_url":"https://api.github.com/repos/mstred/summernote/git/commits{/sha}","comments_url":"https://api.github.com/repos/mstred/summernote/comments{/number}","issue_comment_url":"https://api.github.com/repos/mstred/summernote/issues/comments{/number}","contents_url":"https://api.github.com/repos/mstred/summernote/contents/{+path}","compare_url":"https://api.github.com/repos/mstred/summernote/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mstred/summernote/merges","archive_url":"https://api.github.com/repos/mstred/summernote/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mstred/summernote/downloads","issues_url":"https://api.github.com/repos/mstred/summernote/issues{/number}","pulls_url":"https://api.github.com/repos/mstred/summernote/pulls{/number}","milestones_url":"https://api.github.com/repos/mstred/summernote/milestones{/number}","notifications_url":"https://api.github.com/repos/mstred/summernote/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mstred/summernote/labels{/name}","releases_url":"https://api.github.com/repos/mstred/summernote/releases{/id}","deployments_url":"https://api.github.com/repos/mstred/summernote/deployments","created_at":"2015-03-30T18:18:40Z","updated_at":"2015-05-06T17:43:09Z","pushed_at":"2016-05-18T14:30:20Z","git_url":"git://github.com/mstred/summernote.git","ssh_url":"git@github.com:mstred/summernote.git","clone_url":"https://github.com/mstred/summernote.git","svn_url":"https://github.com/mstred/summernote","homepage":"http://summernote.org","size":7381,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"summernote:develop","ref":"develop","sha":"251e68dfec2d12f92028aeff5adf2ff337c8a228","user":{"login":"summernote","id":7778517,"avatar_url":"https://avatars.githubusercontent.com/u/7778517?v=3","gravatar_id":"","url":"https://api.github.com/users/summernote","html_url":"https://github.com/summernote","followers_url":"https://api.github.com/users/summernote/followers","following_url":"https://api.github.com/users/summernote/following{/other_user}","gists_url":"https://api.github.com/users/summernote/gists{/gist_id}","starred_url":"https://api.github.com/users/summernote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/summernote/subscriptions","organizations_url":"https://api.github.com/users/summernote/orgs","repos_url":"https://api.github.com/users/summernote/repos","events_url":"https://api.github.com/users/summernote/events{/privacy}","received_events_url":"https://api.github.com/users/summernote/received_events","type":"Organization","site_admin":false},"repo":{"id":9709563,"name":"summernote","full_name":"summernote/summernote","owner":{"login":"summernote","id":7778517,"avatar_url":"https://avatars.githubusercontent.com/u/7778517?v=3","gravatar_id":"","url":"https://api.github.com/users/summernote","html_url":"https://github.com/summernote","followers_url":"https://api.github.com/users/summernote/followers","following_url":"https://api.github.com/users/summernote/following{/other_user}","gists_url":"https://api.github.com/users/summernote/gists{/gist_id}","starred_url":"https://api.github.com/users/summernote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/summernote/subscriptions","organizations_url":"https://api.github.com/users/summernote/orgs","repos_url":"https://api.github.com/users/summernote/repos","events_url":"https://api.github.com/users/summernote/events{/privacy}","received_events_url":"https://api.github.com/users/summernote/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/summernote/summernote","description":"Super simple WYSIWYG editor","fork":false,"url":"https://api.github.com/repos/summernote/summernote","forks_url":"https://api.github.com/repos/summernote/summernote/forks","keys_url":"https://api.github.com/repos/summernote/summernote/keys{/key_id}","collaborators_url":"https://api.github.com/repos/summernote/summernote/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/summernote/summernote/teams","hooks_url":"https://api.github.com/repos/summernote/summernote/hooks","issue_events_url":"https://api.github.com/repos/summernote/summernote/issues/events{/number}","events_url":"https://api.github.com/repos/summernote/summernote/events","assignees_url":"https://api.github.com/repos/summernote/summernote/assignees{/user}","branches_url":"https://api.github.com/repos/summernote/summernote/branches{/branch}","tags_url":"https://api.github.com/repos/summernote/summernote/tags","blobs_url":"https://api.github.com/repos/summernote/summernote/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/summernote/summernote/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/summernote/summernote/git/refs{/sha}","trees_url":"https://api.github.com/repos/summernote/summernote/git/trees{/sha}","statuses_url":"https://api.github.com/repos/summernote/summernote/statuses/{sha}","languages_url":"https://api.github.com/repos/summernote/summernote/languages","stargazers_url":"https://api.github.com/repos/summernote/summernote/stargazers","contributors_url":"https://api.github.com/repos/summernote/summernote/contributors","subscribers_url":"https://api.github.com/repos/summernote/summernote/subscribers","subscription_url":"https://api.github.com/repos/summernote/summernote/subscription","commits_url":"https://api.github.com/repos/summernote/summernote/commits{/sha}","git_commits_url":"https://api.github.com/repos/summernote/summernote/git/commits{/sha}","comments_url":"https://api.github.com/repos/summernote/summernote/comments{/number}","issue_comment_url":"https://api.github.com/repos/summernote/summernote/issues/comments{/number}","contents_url":"https://api.github.com/repos/summernote/summernote/contents/{+path}","compare_url":"https://api.github.com/repos/summernote/summernote/compare/{base}...{head}","merges_url":"https://api.github.com/repos/summernote/summernote/merges","archive_url":"https://api.github.com/repos/summernote/summernote/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/summernote/summernote/downloads","issues_url":"https://api.github.com/repos/summernote/summernote/issues{/number}","pulls_url":"https://api.github.com/repos/summernote/summernote/pulls{/number}","milestones_url":"https://api.github.com/repos/summernote/summernote/milestones{/number}","notifications_url":"https://api.github.com/repos/summernote/summernote/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/summernote/summernote/labels{/name}","releases_url":"https://api.github.com/repos/summernote/summernote/releases{/id}","deployments_url":"https://api.github.com/repos/summernote/summernote/deployments","created_at":"2013-04-27T04:59:48Z","updated_at":"2016-05-30T09:45:19Z","pushed_at":"2016-05-30T18:56:54Z","git_url":"git://github.com/summernote/summernote.git","ssh_url":"git@github.com:summernote/summernote.git","clone_url":"https://github.com/summernote/summernote.git","svn_url":"https://github.com/summernote/summernote","homepage":"http://summernote.org","size":12363,"stargazers_count":4490,"watchers_count":4490,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":972,"mirror_url":null,"open_issues_count":561,"forks":972,"open_issues":561,"watchers":4490,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/summernote/summernote/pulls/1278"},"html":{"href":"https://github.com/summernote/summernote/pull/1278"},"issue":{"href":"https://api.github.com/repos/summernote/summernote/issues/1278"},"comments":{"href":"https://api.github.com/repos/summernote/summernote/issues/1278/comments"},"review_comments":{"href":"https://api.github.com/repos/summernote/summernote/pulls/1278/comments"},"review_comment":{"href":"https://api.github.com/repos/summernote/summernote/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/summernote/summernote/pulls/1278/commits"},"statuses":{"href":"https://api.github.com/repos/summernote/summernote/statuses/e8b5111646b31048780a68e52e10a4c7f75ce18e"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":0,"commits":1,"additions":9,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"lqez"}}