{"action":"created","comment":{"url":"https://api.github.com/repos/maidsafe/routing/pulls/comments/82761220","pull_request_review_id":3644814,"id":82761220,"diff_hunk":"@@ -602,17 +602,17 @@ fn failing_connections_group_of_three() {\n     network.block_connection(Endpoint(3), Endpoint(2));\n \n     let mut nodes = create_connected_nodes(&network, 5);\n-    verify_kademlia_invariant_for_all_nodes(&nodes);\n+    verify_invariant_for_all_nodes(&nodes);\n     drop_node(&mut nodes, 0); // Drop the tunnel node. Node 4 should replace it.\n-    verify_kademlia_invariant_for_all_nodes(&nodes);\n+    verify_invariant_for_all_nodes(&nodes);\n     drop_node(&mut nodes, 1); // Drop a tunnel client. The others should be notified.\n-    verify_kademlia_invariant_for_all_nodes(&nodes);\n+    verify_invariant_for_all_nodes(&nodes);\n }\n \n #[test]\n fn failing_connections_ring() {\n     let network = Network::new(None);\n-    let len = GROUP_SIZE * 2;\n+    let len = MIN_GROUP_SIZE * 2;","path":"src/core_tests.rs","position":209,"original_position":234,"commit_id":"7493a1aba684cb212a0a17fa369bb15c187b2b58","original_commit_id":"10bb9947baae4d345d110b204c6c93e84ced6a5d","user":{"login":"afck","id":7894725,"avatar_url":"https://avatars.githubusercontent.com/u/7894725?v=3","gravatar_id":"","url":"https://api.github.com/users/afck","html_url":"https://github.com/afck","followers_url":"https://api.github.com/users/afck/followers","following_url":"https://api.github.com/users/afck/following{/other_user}","gists_url":"https://api.github.com/users/afck/gists{/gist_id}","starred_url":"https://api.github.com/users/afck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afck/subscriptions","organizations_url":"https://api.github.com/users/afck/orgs","repos_url":"https://api.github.com/users/afck/repos","events_url":"https://api.github.com/users/afck/events{/privacy}","received_events_url":"https://api.github.com/users/afck/received_events","type":"User","site_admin":false},"body":":+1: ","created_at":"2016-10-11T10:02:30Z","updated_at":"2016-10-11T10:44:01Z","html_url":"https://github.com/maidsafe/routing/pull/1150#discussion_r82761220","pull_request_url":"https://api.github.com/repos/maidsafe/routing/pulls/1150","_links":{"self":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/comments/82761220"},"html":{"href":"https://github.com/maidsafe/routing/pull/1150#discussion_r82761220"},"pull_request":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/1150"}}},"pull_request":{"url":"https://api.github.com/repos/maidsafe/routing/pulls/1150","id":88286789,"html_url":"https://github.com/maidsafe/routing/pull/1150","diff_url":"https://github.com/maidsafe/routing/pull/1150.diff","patch_url":"https://github.com/maidsafe/routing/pull/1150.patch","issue_url":"https://api.github.com/repos/maidsafe/routing/issues/1150","number":1150,"state":"open","locked":false,"title":"Initial work on integrating \"disjoint group\" RoutingTable.","user":{"login":"Fraser999","id":190532,"avatar_url":"https://avatars.githubusercontent.com/u/190532?v=3","gravatar_id":"","url":"https://api.github.com/users/Fraser999","html_url":"https://github.com/Fraser999","followers_url":"https://api.github.com/users/Fraser999/followers","following_url":"https://api.github.com/users/Fraser999/following{/other_user}","gists_url":"https://api.github.com/users/Fraser999/gists{/gist_id}","starred_url":"https://api.github.com/users/Fraser999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fraser999/subscriptions","organizations_url":"https://api.github.com/users/Fraser999/orgs","repos_url":"https://api.github.com/users/Fraser999/repos","events_url":"https://api.github.com/users/Fraser999/events{/privacy}","received_events_url":"https://api.github.com/users/Fraser999/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-06T15:36:01Z","updated_at":"2016-10-11T10:44:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ee7300b06262a3056676cf09e66ae77593de044","assignee":{"login":"afck","id":7894725,"avatar_url":"https://avatars.githubusercontent.com/u/7894725?v=3","gravatar_id":"","url":"https://api.github.com/users/afck","html_url":"https://github.com/afck","followers_url":"https://api.github.com/users/afck/followers","following_url":"https://api.github.com/users/afck/following{/other_user}","gists_url":"https://api.github.com/users/afck/gists{/gist_id}","starred_url":"https://api.github.com/users/afck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afck/subscriptions","organizations_url":"https://api.github.com/users/afck/orgs","repos_url":"https://api.github.com/users/afck/repos","events_url":"https://api.github.com/users/afck/events{/privacy}","received_events_url":"https://api.github.com/users/afck/received_events","type":"User","site_admin":false},"assignees":[{"login":"afck","id":7894725,"avatar_url":"https://avatars.githubusercontent.com/u/7894725?v=3","gravatar_id":"","url":"https://api.github.com/users/afck","html_url":"https://github.com/afck","followers_url":"https://api.github.com/users/afck/followers","following_url":"https://api.github.com/users/afck/following{/other_user}","gists_url":"https://api.github.com/users/afck/gists{/gist_id}","starred_url":"https://api.github.com/users/afck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afck/subscriptions","organizations_url":"https://api.github.com/users/afck/orgs","repos_url":"https://api.github.com/users/afck/repos","events_url":"https://api.github.com/users/afck/events{/privacy}","received_events_url":"https://api.github.com/users/afck/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/maidsafe/routing/pulls/1150/commits","review_comments_url":"https://api.github.com/repos/maidsafe/routing/pulls/1150/comments","review_comment_url":"https://api.github.com/repos/maidsafe/routing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/maidsafe/routing/issues/1150/comments","statuses_url":"https://api.github.com/repos/maidsafe/routing/statuses/7493a1aba684cb212a0a17fa369bb15c187b2b58","head":{"label":"Fraser999:disjoint_groups","ref":"disjoint_groups","sha":"7493a1aba684cb212a0a17fa369bb15c187b2b58","user":{"login":"Fraser999","id":190532,"avatar_url":"https://avatars.githubusercontent.com/u/190532?v=3","gravatar_id":"","url":"https://api.github.com/users/Fraser999","html_url":"https://github.com/Fraser999","followers_url":"https://api.github.com/users/Fraser999/followers","following_url":"https://api.github.com/users/Fraser999/following{/other_user}","gists_url":"https://api.github.com/users/Fraser999/gists{/gist_id}","starred_url":"https://api.github.com/users/Fraser999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fraser999/subscriptions","organizations_url":"https://api.github.com/users/Fraser999/orgs","repos_url":"https://api.github.com/users/Fraser999/repos","events_url":"https://api.github.com/users/Fraser999/events{/privacy}","received_events_url":"https://api.github.com/users/Fraser999/received_events","type":"User","site_admin":false},"repo":{"id":32315702,"name":"routing","full_name":"Fraser999/routing","owner":{"login":"Fraser999","id":190532,"avatar_url":"https://avatars.githubusercontent.com/u/190532?v=3","gravatar_id":"","url":"https://api.github.com/users/Fraser999","html_url":"https://github.com/Fraser999","followers_url":"https://api.github.com/users/Fraser999/followers","following_url":"https://api.github.com/users/Fraser999/following{/other_user}","gists_url":"https://api.github.com/users/Fraser999/gists{/gist_id}","starred_url":"https://api.github.com/users/Fraser999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fraser999/subscriptions","organizations_url":"https://api.github.com/users/Fraser999/orgs","repos_url":"https://api.github.com/users/Fraser999/repos","events_url":"https://api.github.com/users/Fraser999/events{/privacy}","received_events_url":"https://api.github.com/users/Fraser999/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Fraser999/routing","description":"Routing - specialised storage DHT","fork":true,"url":"https://api.github.com/repos/Fraser999/routing","forks_url":"https://api.github.com/repos/Fraser999/routing/forks","keys_url":"https://api.github.com/repos/Fraser999/routing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fraser999/routing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fraser999/routing/teams","hooks_url":"https://api.github.com/repos/Fraser999/routing/hooks","issue_events_url":"https://api.github.com/repos/Fraser999/routing/issues/events{/number}","events_url":"https://api.github.com/repos/Fraser999/routing/events","assignees_url":"https://api.github.com/repos/Fraser999/routing/assignees{/user}","branches_url":"https://api.github.com/repos/Fraser999/routing/branches{/branch}","tags_url":"https://api.github.com/repos/Fraser999/routing/tags","blobs_url":"https://api.github.com/repos/Fraser999/routing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fraser999/routing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fraser999/routing/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fraser999/routing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fraser999/routing/statuses/{sha}","languages_url":"https://api.github.com/repos/Fraser999/routing/languages","stargazers_url":"https://api.github.com/repos/Fraser999/routing/stargazers","contributors_url":"https://api.github.com/repos/Fraser999/routing/contributors","subscribers_url":"https://api.github.com/repos/Fraser999/routing/subscribers","subscription_url":"https://api.github.com/repos/Fraser999/routing/subscription","commits_url":"https://api.github.com/repos/Fraser999/routing/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fraser999/routing/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fraser999/routing/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fraser999/routing/issues/comments{/number}","contents_url":"https://api.github.com/repos/Fraser999/routing/contents/{+path}","compare_url":"https://api.github.com/repos/Fraser999/routing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fraser999/routing/merges","archive_url":"https://api.github.com/repos/Fraser999/routing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fraser999/routing/downloads","issues_url":"https://api.github.com/repos/Fraser999/routing/issues{/number}","pulls_url":"https://api.github.com/repos/Fraser999/routing/pulls{/number}","milestones_url":"https://api.github.com/repos/Fraser999/routing/milestones{/number}","notifications_url":"https://api.github.com/repos/Fraser999/routing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fraser999/routing/labels{/name}","releases_url":"https://api.github.com/repos/Fraser999/routing/releases{/id}","deployments_url":"https://api.github.com/repos/Fraser999/routing/deployments","created_at":"2015-03-16T09:53:56Z","updated_at":"2016-01-11T11:52:43Z","pushed_at":"2016-10-10T07:36:28Z","git_url":"git://github.com/Fraser999/routing.git","ssh_url":"git@github.com:Fraser999/routing.git","clone_url":"https://github.com/Fraser999/routing.git","svn_url":"https://github.com/Fraser999/routing","homepage":null,"size":7578,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"maidsafe:master","ref":"master","sha":"5725a462dfa398c7dfeb4da776fe5e49a62a5e81","user":{"login":"maidsafe","id":536423,"avatar_url":"https://avatars.githubusercontent.com/u/536423?v=3","gravatar_id":"","url":"https://api.github.com/users/maidsafe","html_url":"https://github.com/maidsafe","followers_url":"https://api.github.com/users/maidsafe/followers","following_url":"https://api.github.com/users/maidsafe/following{/other_user}","gists_url":"https://api.github.com/users/maidsafe/gists{/gist_id}","starred_url":"https://api.github.com/users/maidsafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maidsafe/subscriptions","organizations_url":"https://api.github.com/users/maidsafe/orgs","repos_url":"https://api.github.com/users/maidsafe/repos","events_url":"https://api.github.com/users/maidsafe/events{/privacy}","received_events_url":"https://api.github.com/users/maidsafe/received_events","type":"Organization","site_admin":false},"repo":{"id":31270514,"name":"routing","full_name":"maidsafe/routing","owner":{"login":"maidsafe","id":536423,"avatar_url":"https://avatars.githubusercontent.com/u/536423?v=3","gravatar_id":"","url":"https://api.github.com/users/maidsafe","html_url":"https://github.com/maidsafe","followers_url":"https://api.github.com/users/maidsafe/followers","following_url":"https://api.github.com/users/maidsafe/following{/other_user}","gists_url":"https://api.github.com/users/maidsafe/gists{/gist_id}","starred_url":"https://api.github.com/users/maidsafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maidsafe/subscriptions","organizations_url":"https://api.github.com/users/maidsafe/orgs","repos_url":"https://api.github.com/users/maidsafe/repos","events_url":"https://api.github.com/users/maidsafe/events{/privacy}","received_events_url":"https://api.github.com/users/maidsafe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/maidsafe/routing","description":"Routing - specialised storage DHT","fork":false,"url":"https://api.github.com/repos/maidsafe/routing","forks_url":"https://api.github.com/repos/maidsafe/routing/forks","keys_url":"https://api.github.com/repos/maidsafe/routing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maidsafe/routing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maidsafe/routing/teams","hooks_url":"https://api.github.com/repos/maidsafe/routing/hooks","issue_events_url":"https://api.github.com/repos/maidsafe/routing/issues/events{/number}","events_url":"https://api.github.com/repos/maidsafe/routing/events","assignees_url":"https://api.github.com/repos/maidsafe/routing/assignees{/user}","branches_url":"https://api.github.com/repos/maidsafe/routing/branches{/branch}","tags_url":"https://api.github.com/repos/maidsafe/routing/tags","blobs_url":"https://api.github.com/repos/maidsafe/routing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maidsafe/routing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maidsafe/routing/git/refs{/sha}","trees_url":"https://api.github.com/repos/maidsafe/routing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maidsafe/routing/statuses/{sha}","languages_url":"https://api.github.com/repos/maidsafe/routing/languages","stargazers_url":"https://api.github.com/repos/maidsafe/routing/stargazers","contributors_url":"https://api.github.com/repos/maidsafe/routing/contributors","subscribers_url":"https://api.github.com/repos/maidsafe/routing/subscribers","subscription_url":"https://api.github.com/repos/maidsafe/routing/subscription","commits_url":"https://api.github.com/repos/maidsafe/routing/commits{/sha}","git_commits_url":"https://api.github.com/repos/maidsafe/routing/git/commits{/sha}","comments_url":"https://api.github.com/repos/maidsafe/routing/comments{/number}","issue_comment_url":"https://api.github.com/repos/maidsafe/routing/issues/comments{/number}","contents_url":"https://api.github.com/repos/maidsafe/routing/contents/{+path}","compare_url":"https://api.github.com/repos/maidsafe/routing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maidsafe/routing/merges","archive_url":"https://api.github.com/repos/maidsafe/routing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maidsafe/routing/downloads","issues_url":"https://api.github.com/repos/maidsafe/routing/issues{/number}","pulls_url":"https://api.github.com/repos/maidsafe/routing/pulls{/number}","milestones_url":"https://api.github.com/repos/maidsafe/routing/milestones{/number}","notifications_url":"https://api.github.com/repos/maidsafe/routing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maidsafe/routing/labels{/name}","releases_url":"https://api.github.com/repos/maidsafe/routing/releases{/id}","deployments_url":"https://api.github.com/repos/maidsafe/routing/deployments","created_at":"2015-02-24T16:52:53Z","updated_at":"2016-10-07T12:35:54Z","pushed_at":"2016-10-07T15:04:49Z","git_url":"git://github.com/maidsafe/routing.git","ssh_url":"git@github.com:maidsafe/routing.git","clone_url":"https://github.com/maidsafe/routing.git","svn_url":"https://github.com/maidsafe/routing","homepage":null,"size":103911,"stargazers_count":103,"watchers_count":103,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":35,"mirror_url":null,"open_issues_count":8,"forks":35,"open_issues":8,"watchers":103,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/1150"},"html":{"href":"https://github.com/maidsafe/routing/pull/1150"},"issue":{"href":"https://api.github.com/repos/maidsafe/routing/issues/1150"},"comments":{"href":"https://api.github.com/repos/maidsafe/routing/issues/1150/comments"},"review_comments":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/1150/comments"},"review_comment":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/1150/commits"},"statuses":{"href":"https://api.github.com/repos/maidsafe/routing/statuses/7493a1aba684cb212a0a17fa369bb15c187b2b58"}}}}
{"actor":{"display_login":"afck"}}