{"action":"created","comment":{"url":"https://api.github.com/repos/Samsung/jerryscript/pulls/comments/71105295","id":71105295,"diff_hunk":"@@ -31,12 +31,11 @@\n #define __UNSED__ __attribute__((unused))\n \n #define DELCARE_HANDLER(NAME) \\\n-static bool \\\n-NAME ## _handler (const jerry_api_object_t * function_obj_p __UNSED__, \\\n-                  const jerry_api_value_t *  this_p __UNSED__, \\\n-                  jerry_api_value_t *        ret_val_p __UNSED__, \\\n-                  const jerry_api_value_t    args_p[], \\\n-                  const jerry_api_length_t   args_cnt)\n+static jerry_value_t \\\n+NAME ## _handler (const jerry_value_t  function_obj_p __UNSED__, \\\n+                  const jerry_value_t  this_p __UNSED__, \\","path":"targets/esp8266/source/jerry_extapi.c","position":21,"original_position":21,"commit_id":"85b51956273736701864f4c3ae4aebf72afca814","original_commit_id":"85b51956273736701864f4c3ae4aebf72afca814","user":{"login":"LaszloLango","id":10030017,"avatar_url":"https://avatars.githubusercontent.com/u/10030017?v=3","gravatar_id":"","url":"https://api.github.com/users/LaszloLango","html_url":"https://github.com/LaszloLango","followers_url":"https://api.github.com/users/LaszloLango/followers","following_url":"https://api.github.com/users/LaszloLango/following{/other_user}","gists_url":"https://api.github.com/users/LaszloLango/gists{/gist_id}","starred_url":"https://api.github.com/users/LaszloLango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LaszloLango/subscriptions","organizations_url":"https://api.github.com/users/LaszloLango/orgs","repos_url":"https://api.github.com/users/LaszloLango/repos","events_url":"https://api.github.com/users/LaszloLango/events{/privacy}","received_events_url":"https://api.github.com/users/LaszloLango/received_events","type":"User","site_admin":false},"body":"Please remove the `_p` suffix. They are not pointers anymore. ex.: `func_obj_val` and `this_val`","created_at":"2016-07-18T06:56:07Z","updated_at":"2016-07-18T06:56:07Z","html_url":"https://github.com/Samsung/jerryscript/pull/1212#discussion_r71105295","pull_request_url":"https://api.github.com/repos/Samsung/jerryscript/pulls/1212","_links":{"self":{"href":"https://api.github.com/repos/Samsung/jerryscript/pulls/comments/71105295"},"html":{"href":"https://github.com/Samsung/jerryscript/pull/1212#discussion_r71105295"},"pull_request":{"href":"https://api.github.com/repos/Samsung/jerryscript/pulls/1212"}}},"pull_request":{"url":"https://api.github.com/repos/Samsung/jerryscript/pulls/1212","id":77744743,"html_url":"https://github.com/Samsung/jerryscript/pull/1212","diff_url":"https://github.com/Samsung/jerryscript/pull/1212.diff","patch_url":"https://github.com/Samsung/jerryscript/pull/1212.patch","issue_url":"https://api.github.com/repos/Samsung/jerryscript/issues/1212","number":1212,"state":"open","locked":false,"title":"Initial refactoring of the code to match the latest API.","user":{"login":"slaff","id":247452,"avatar_url":"https://avatars.githubusercontent.com/u/247452?v=3","gravatar_id":"","url":"https://api.github.com/users/slaff","html_url":"https://github.com/slaff","followers_url":"https://api.github.com/users/slaff/followers","following_url":"https://api.github.com/users/slaff/following{/other_user}","gists_url":"https://api.github.com/users/slaff/gists{/gist_id}","starred_url":"https://api.github.com/users/slaff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slaff/subscriptions","organizations_url":"https://api.github.com/users/slaff/orgs","repos_url":"https://api.github.com/users/slaff/repos","events_url":"https://api.github.com/users/slaff/events{/privacy}","received_events_url":"https://api.github.com/users/slaff/received_events","type":"User","site_admin":false},"body":"Fixes issue https://github.com/Samsung/jerryscript/issues/1211.","created_at":"2016-07-17T20:14:25Z","updated_at":"2016-07-18T06:56:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e65e29f59b2daf1e047a57a855efad4e5300566","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Samsung/jerryscript/pulls/1212/commits","review_comments_url":"https://api.github.com/repos/Samsung/jerryscript/pulls/1212/comments","review_comment_url":"https://api.github.com/repos/Samsung/jerryscript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Samsung/jerryscript/issues/1212/comments","statuses_url":"https://api.github.com/repos/Samsung/jerryscript/statuses/85b51956273736701864f4c3ae4aebf72afca814","head":{"label":"slaff:master","ref":"master","sha":"85b51956273736701864f4c3ae4aebf72afca814","user":{"login":"slaff","id":247452,"avatar_url":"https://avatars.githubusercontent.com/u/247452?v=3","gravatar_id":"","url":"https://api.github.com/users/slaff","html_url":"https://github.com/slaff","followers_url":"https://api.github.com/users/slaff/followers","following_url":"https://api.github.com/users/slaff/following{/other_user}","gists_url":"https://api.github.com/users/slaff/gists{/gist_id}","starred_url":"https://api.github.com/users/slaff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slaff/subscriptions","organizations_url":"https://api.github.com/users/slaff/orgs","repos_url":"https://api.github.com/users/slaff/repos","events_url":"https://api.github.com/users/slaff/events{/privacy}","received_events_url":"https://api.github.com/users/slaff/received_events","type":"User","site_admin":false},"repo":{"id":63526952,"name":"jerryscript","full_name":"slaff/jerryscript","owner":{"login":"slaff","id":247452,"avatar_url":"https://avatars.githubusercontent.com/u/247452?v=3","gravatar_id":"","url":"https://api.github.com/users/slaff","html_url":"https://github.com/slaff","followers_url":"https://api.github.com/users/slaff/followers","following_url":"https://api.github.com/users/slaff/following{/other_user}","gists_url":"https://api.github.com/users/slaff/gists{/gist_id}","starred_url":"https://api.github.com/users/slaff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slaff/subscriptions","organizations_url":"https://api.github.com/users/slaff/orgs","repos_url":"https://api.github.com/users/slaff/repos","events_url":"https://api.github.com/users/slaff/events{/privacy}","received_events_url":"https://api.github.com/users/slaff/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/slaff/jerryscript","description":"Ultra-lightweight JavaScript engine for the Internet of Things. http://samsung.github.io/jerryscript","fork":true,"url":"https://api.github.com/repos/slaff/jerryscript","forks_url":"https://api.github.com/repos/slaff/jerryscript/forks","keys_url":"https://api.github.com/repos/slaff/jerryscript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slaff/jerryscript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slaff/jerryscript/teams","hooks_url":"https://api.github.com/repos/slaff/jerryscript/hooks","issue_events_url":"https://api.github.com/repos/slaff/jerryscript/issues/events{/number}","events_url":"https://api.github.com/repos/slaff/jerryscript/events","assignees_url":"https://api.github.com/repos/slaff/jerryscript/assignees{/user}","branches_url":"https://api.github.com/repos/slaff/jerryscript/branches{/branch}","tags_url":"https://api.github.com/repos/slaff/jerryscript/tags","blobs_url":"https://api.github.com/repos/slaff/jerryscript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slaff/jerryscript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slaff/jerryscript/git/refs{/sha}","trees_url":"https://api.github.com/repos/slaff/jerryscript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slaff/jerryscript/statuses/{sha}","languages_url":"https://api.github.com/repos/slaff/jerryscript/languages","stargazers_url":"https://api.github.com/repos/slaff/jerryscript/stargazers","contributors_url":"https://api.github.com/repos/slaff/jerryscript/contributors","subscribers_url":"https://api.github.com/repos/slaff/jerryscript/subscribers","subscription_url":"https://api.github.com/repos/slaff/jerryscript/subscription","commits_url":"https://api.github.com/repos/slaff/jerryscript/commits{/sha}","git_commits_url":"https://api.github.com/repos/slaff/jerryscript/git/commits{/sha}","comments_url":"https://api.github.com/repos/slaff/jerryscript/comments{/number}","issue_comment_url":"https://api.github.com/repos/slaff/jerryscript/issues/comments{/number}","contents_url":"https://api.github.com/repos/slaff/jerryscript/contents/{+path}","compare_url":"https://api.github.com/repos/slaff/jerryscript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slaff/jerryscript/merges","archive_url":"https://api.github.com/repos/slaff/jerryscript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slaff/jerryscript/downloads","issues_url":"https://api.github.com/repos/slaff/jerryscript/issues{/number}","pulls_url":"https://api.github.com/repos/slaff/jerryscript/pulls{/number}","milestones_url":"https://api.github.com/repos/slaff/jerryscript/milestones{/number}","notifications_url":"https://api.github.com/repos/slaff/jerryscript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slaff/jerryscript/labels{/name}","releases_url":"https://api.github.com/repos/slaff/jerryscript/releases{/id}","deployments_url":"https://api.github.com/repos/slaff/jerryscript/deployments","created_at":"2016-07-17T10:45:38Z","updated_at":"2016-07-17T10:45:44Z","pushed_at":"2016-07-17T20:12:55Z","git_url":"git://github.com/slaff/jerryscript.git","ssh_url":"git@github.com:slaff/jerryscript.git","clone_url":"https://github.com/slaff/jerryscript.git","svn_url":"https://github.com/slaff/jerryscript","homepage":"","size":24907,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Samsung:master","ref":"master","sha":"3828f08796313888dcc4c01c50c1cb52e961138b","user":{"login":"Samsung","id":6210390,"avatar_url":"https://avatars.githubusercontent.com/u/6210390?v=3","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"repo":{"id":33339660,"name":"jerryscript","full_name":"Samsung/jerryscript","owner":{"login":"Samsung","id":6210390,"avatar_url":"https://avatars.githubusercontent.com/u/6210390?v=3","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Samsung/jerryscript","description":"Ultra-lightweight JavaScript engine for the Internet of Things. http://samsung.github.io/jerryscript","fork":false,"url":"https://api.github.com/repos/Samsung/jerryscript","forks_url":"https://api.github.com/repos/Samsung/jerryscript/forks","keys_url":"https://api.github.com/repos/Samsung/jerryscript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Samsung/jerryscript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Samsung/jerryscript/teams","hooks_url":"https://api.github.com/repos/Samsung/jerryscript/hooks","issue_events_url":"https://api.github.com/repos/Samsung/jerryscript/issues/events{/number}","events_url":"https://api.github.com/repos/Samsung/jerryscript/events","assignees_url":"https://api.github.com/repos/Samsung/jerryscript/assignees{/user}","branches_url":"https://api.github.com/repos/Samsung/jerryscript/branches{/branch}","tags_url":"https://api.github.com/repos/Samsung/jerryscript/tags","blobs_url":"https://api.github.com/repos/Samsung/jerryscript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Samsung/jerryscript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Samsung/jerryscript/git/refs{/sha}","trees_url":"https://api.github.com/repos/Samsung/jerryscript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Samsung/jerryscript/statuses/{sha}","languages_url":"https://api.github.com/repos/Samsung/jerryscript/languages","stargazers_url":"https://api.github.com/repos/Samsung/jerryscript/stargazers","contributors_url":"https://api.github.com/repos/Samsung/jerryscript/contributors","subscribers_url":"https://api.github.com/repos/Samsung/jerryscript/subscribers","subscription_url":"https://api.github.com/repos/Samsung/jerryscript/subscription","commits_url":"https://api.github.com/repos/Samsung/jerryscript/commits{/sha}","git_commits_url":"https://api.github.com/repos/Samsung/jerryscript/git/commits{/sha}","comments_url":"https://api.github.com/repos/Samsung/jerryscript/comments{/number}","issue_comment_url":"https://api.github.com/repos/Samsung/jerryscript/issues/comments{/number}","contents_url":"https://api.github.com/repos/Samsung/jerryscript/contents/{+path}","compare_url":"https://api.github.com/repos/Samsung/jerryscript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Samsung/jerryscript/merges","archive_url":"https://api.github.com/repos/Samsung/jerryscript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Samsung/jerryscript/downloads","issues_url":"https://api.github.com/repos/Samsung/jerryscript/issues{/number}","pulls_url":"https://api.github.com/repos/Samsung/jerryscript/pulls{/number}","milestones_url":"https://api.github.com/repos/Samsung/jerryscript/milestones{/number}","notifications_url":"https://api.github.com/repos/Samsung/jerryscript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Samsung/jerryscript/labels{/name}","releases_url":"https://api.github.com/repos/Samsung/jerryscript/releases{/id}","deployments_url":"https://api.github.com/repos/Samsung/jerryscript/deployments","created_at":"2015-04-03T01:10:31Z","updated_at":"2016-07-18T02:42:49Z","pushed_at":"2016-07-17T20:14:25Z","git_url":"git://github.com/Samsung/jerryscript.git","ssh_url":"git@github.com:Samsung/jerryscript.git","clone_url":"https://github.com/Samsung/jerryscript.git","svn_url":"https://github.com/Samsung/jerryscript","homepage":"","size":27074,"stargazers_count":1364,"watchers_count":1364,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":156,"mirror_url":null,"open_issues_count":68,"forks":156,"open_issues":68,"watchers":1364,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Samsung/jerryscript/pulls/1212"},"html":{"href":"https://github.com/Samsung/jerryscript/pull/1212"},"issue":{"href":"https://api.github.com/repos/Samsung/jerryscript/issues/1212"},"comments":{"href":"https://api.github.com/repos/Samsung/jerryscript/issues/1212/comments"},"review_comments":{"href":"https://api.github.com/repos/Samsung/jerryscript/pulls/1212/comments"},"review_comment":{"href":"https://api.github.com/repos/Samsung/jerryscript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Samsung/jerryscript/pulls/1212/commits"},"statuses":{"href":"https://api.github.com/repos/Samsung/jerryscript/statuses/85b51956273736701864f4c3ae4aebf72afca814"}}}}
{"actor":{"display_login":"LaszloLango"}}