{"action":"closed","number":467,"pull_request":{"url":"https://api.github.com/repos/spark/docs/pulls/467","id":85684149,"html_url":"https://github.com/spark/docs/pull/467","diff_url":"https://github.com/spark/docs/pull/467.diff","patch_url":"https://github.com/spark/docs/pull/467.patch","issue_url":"https://api.github.com/repos/spark/docs/issues/467","number":467,"state":"closed","locked":false,"title":"Use `hostname` instead of `URL` terminology","user":{"login":"dougalcampbell","id":314494,"avatar_url":"https://avatars.githubusercontent.com/u/314494?v=3","gravatar_id":"","url":"https://api.github.com/users/dougalcampbell","html_url":"https://github.com/dougalcampbell","followers_url":"https://api.github.com/users/dougalcampbell/followers","following_url":"https://api.github.com/users/dougalcampbell/following{/other_user}","gists_url":"https://api.github.com/users/dougalcampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/dougalcampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dougalcampbell/subscriptions","organizations_url":"https://api.github.com/users/dougalcampbell/orgs","repos_url":"https://api.github.com/users/dougalcampbell/repos","events_url":"https://api.github.com/users/dougalcampbell/events{/privacy}","received_events_url":"https://api.github.com/users/dougalcampbell/received_events","type":"User","site_admin":false},"body":"It's pedantic, but `URL` really isn't correct in this context (`TCPClient::connect()`). A URL can consist of several pieces, including a scheme, hostname, port, path, etc. If you tried to provide a valid URL like `http://www.google.com/` to `TCPClient::connect()`, it would be an error. We're really just using a host name here.","created_at":"2016-09-17T19:17:24Z","updated_at":"2016-09-18T13:55:21Z","closed_at":"2016-09-18T13:55:21Z","merged_at":"2016-09-18T13:55:21Z","merge_commit_sha":"13711a5a7c4c24c73dcb6a712099ac05de5511a6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/spark/docs/pulls/467/commits","review_comments_url":"https://api.github.com/repos/spark/docs/pulls/467/comments","review_comment_url":"https://api.github.com/repos/spark/docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spark/docs/issues/467/comments","statuses_url":"https://api.github.com/repos/spark/docs/statuses/a1aecc3ad184e5fe9ffd502055e9e708ea917830","head":{"label":"dougalcampbell:patch-1","ref":"patch-1","sha":"a1aecc3ad184e5fe9ffd502055e9e708ea917830","user":{"login":"dougalcampbell","id":314494,"avatar_url":"https://avatars.githubusercontent.com/u/314494?v=3","gravatar_id":"","url":"https://api.github.com/users/dougalcampbell","html_url":"https://github.com/dougalcampbell","followers_url":"https://api.github.com/users/dougalcampbell/followers","following_url":"https://api.github.com/users/dougalcampbell/following{/other_user}","gists_url":"https://api.github.com/users/dougalcampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/dougalcampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dougalcampbell/subscriptions","organizations_url":"https://api.github.com/users/dougalcampbell/orgs","repos_url":"https://api.github.com/users/dougalcampbell/repos","events_url":"https://api.github.com/users/dougalcampbell/events{/privacy}","received_events_url":"https://api.github.com/users/dougalcampbell/received_events","type":"User","site_admin":false},"repo":{"id":42684298,"name":"particle_docs","full_name":"dougalcampbell/particle_docs","owner":{"login":"dougalcampbell","id":314494,"avatar_url":"https://avatars.githubusercontent.com/u/314494?v=3","gravatar_id":"","url":"https://api.github.com/users/dougalcampbell","html_url":"https://github.com/dougalcampbell","followers_url":"https://api.github.com/users/dougalcampbell/followers","following_url":"https://api.github.com/users/dougalcampbell/following{/other_user}","gists_url":"https://api.github.com/users/dougalcampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/dougalcampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dougalcampbell/subscriptions","organizations_url":"https://api.github.com/users/dougalcampbell/orgs","repos_url":"https://api.github.com/users/dougalcampbell/repos","events_url":"https://api.github.com/users/dougalcampbell/events{/privacy}","received_events_url":"https://api.github.com/users/dougalcampbell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dougalcampbell/particle_docs","description":"Documentation for Particle","fork":true,"url":"https://api.github.com/repos/dougalcampbell/particle_docs","forks_url":"https://api.github.com/repos/dougalcampbell/particle_docs/forks","keys_url":"https://api.github.com/repos/dougalcampbell/particle_docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dougalcampbell/particle_docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dougalcampbell/particle_docs/teams","hooks_url":"https://api.github.com/repos/dougalcampbell/particle_docs/hooks","issue_events_url":"https://api.github.com/repos/dougalcampbell/particle_docs/issues/events{/number}","events_url":"https://api.github.com/repos/dougalcampbell/particle_docs/events","assignees_url":"https://api.github.com/repos/dougalcampbell/particle_docs/assignees{/user}","branches_url":"https://api.github.com/repos/dougalcampbell/particle_docs/branches{/branch}","tags_url":"https://api.github.com/repos/dougalcampbell/particle_docs/tags","blobs_url":"https://api.github.com/repos/dougalcampbell/particle_docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dougalcampbell/particle_docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dougalcampbell/particle_docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/dougalcampbell/particle_docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dougalcampbell/particle_docs/statuses/{sha}","languages_url":"https://api.github.com/repos/dougalcampbell/particle_docs/languages","stargazers_url":"https://api.github.com/repos/dougalcampbell/particle_docs/stargazers","contributors_url":"https://api.github.com/repos/dougalcampbell/particle_docs/contributors","subscribers_url":"https://api.github.com/repos/dougalcampbell/particle_docs/subscribers","subscription_url":"https://api.github.com/repos/dougalcampbell/particle_docs/subscription","commits_url":"https://api.github.com/repos/dougalcampbell/particle_docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/dougalcampbell/particle_docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/dougalcampbell/particle_docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/dougalcampbell/particle_docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/dougalcampbell/particle_docs/contents/{+path}","compare_url":"https://api.github.com/repos/dougalcampbell/particle_docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dougalcampbell/particle_docs/merges","archive_url":"https://api.github.com/repos/dougalcampbell/particle_docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dougalcampbell/particle_docs/downloads","issues_url":"https://api.github.com/repos/dougalcampbell/particle_docs/issues{/number}","pulls_url":"https://api.github.com/repos/dougalcampbell/particle_docs/pulls{/number}","milestones_url":"https://api.github.com/repos/dougalcampbell/particle_docs/milestones{/number}","notifications_url":"https://api.github.com/repos/dougalcampbell/particle_docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dougalcampbell/particle_docs/labels{/name}","releases_url":"https://api.github.com/repos/dougalcampbell/particle_docs/releases{/id}","deployments_url":"https://api.github.com/repos/dougalcampbell/particle_docs/deployments","created_at":"2015-09-17T22:02:06Z","updated_at":"2016-09-17T19:02:04Z","pushed_at":"2016-09-17T19:15:09Z","git_url":"git://github.com/dougalcampbell/particle_docs.git","ssh_url":"git@github.com:dougalcampbell/particle_docs.git","clone_url":"https://github.com/dougalcampbell/particle_docs.git","svn_url":"https://github.com/dougalcampbell/particle_docs","homepage":null,"size":356248,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spark:master","ref":"master","sha":"ea7319a0eeb106b2d6d6f133b358b4c279fd2187","user":{"login":"spark","id":2348966,"avatar_url":"https://avatars.githubusercontent.com/u/2348966?v=3","gravatar_id":"","url":"https://api.github.com/users/spark","html_url":"https://github.com/spark","followers_url":"https://api.github.com/users/spark/followers","following_url":"https://api.github.com/users/spark/following{/other_user}","gists_url":"https://api.github.com/users/spark/gists{/gist_id}","starred_url":"https://api.github.com/users/spark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spark/subscriptions","organizations_url":"https://api.github.com/users/spark/orgs","repos_url":"https://api.github.com/users/spark/repos","events_url":"https://api.github.com/users/spark/events{/privacy}","received_events_url":"https://api.github.com/users/spark/received_events","type":"Organization","site_admin":false},"repo":{"id":34815037,"name":"docs","full_name":"spark/docs","owner":{"login":"spark","id":2348966,"avatar_url":"https://avatars.githubusercontent.com/u/2348966?v=3","gravatar_id":"","url":"https://api.github.com/users/spark","html_url":"https://github.com/spark","followers_url":"https://api.github.com/users/spark/followers","following_url":"https://api.github.com/users/spark/following{/other_user}","gists_url":"https://api.github.com/users/spark/gists{/gist_id}","starred_url":"https://api.github.com/users/spark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spark/subscriptions","organizations_url":"https://api.github.com/users/spark/orgs","repos_url":"https://api.github.com/users/spark/repos","events_url":"https://api.github.com/users/spark/events{/privacy}","received_events_url":"https://api.github.com/users/spark/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spark/docs","description":"Documentation for Particle","fork":false,"url":"https://api.github.com/repos/spark/docs","forks_url":"https://api.github.com/repos/spark/docs/forks","keys_url":"https://api.github.com/repos/spark/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spark/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spark/docs/teams","hooks_url":"https://api.github.com/repos/spark/docs/hooks","issue_events_url":"https://api.github.com/repos/spark/docs/issues/events{/number}","events_url":"https://api.github.com/repos/spark/docs/events","assignees_url":"https://api.github.com/repos/spark/docs/assignees{/user}","branches_url":"https://api.github.com/repos/spark/docs/branches{/branch}","tags_url":"https://api.github.com/repos/spark/docs/tags","blobs_url":"https://api.github.com/repos/spark/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spark/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spark/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/spark/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spark/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/spark/docs/languages","stargazers_url":"https://api.github.com/repos/spark/docs/stargazers","contributors_url":"https://api.github.com/repos/spark/docs/contributors","subscribers_url":"https://api.github.com/repos/spark/docs/subscribers","subscription_url":"https://api.github.com/repos/spark/docs/subscription","commits_url":"https://api.github.com/repos/spark/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/spark/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/spark/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/spark/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/spark/docs/contents/{+path}","compare_url":"https://api.github.com/repos/spark/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spark/docs/merges","archive_url":"https://api.github.com/repos/spark/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spark/docs/downloads","issues_url":"https://api.github.com/repos/spark/docs/issues{/number}","pulls_url":"https://api.github.com/repos/spark/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/spark/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/spark/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spark/docs/labels{/name}","releases_url":"https://api.github.com/repos/spark/docs/releases{/id}","deployments_url":"https://api.github.com/repos/spark/docs/deployments","created_at":"2015-04-29T19:53:38Z","updated_at":"2016-09-10T10:20:58Z","pushed_at":"2016-09-18T13:55:21Z","git_url":"git://github.com/spark/docs.git","ssh_url":"git@github.com:spark/docs.git","clone_url":"https://github.com/spark/docs.git","svn_url":"https://github.com/spark/docs","homepage":null,"size":358618,"stargazers_count":53,"watchers_count":53,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":150,"mirror_url":null,"open_issues_count":103,"forks":150,"open_issues":103,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spark/docs/pulls/467"},"html":{"href":"https://github.com/spark/docs/pull/467"},"issue":{"href":"https://api.github.com/repos/spark/docs/issues/467"},"comments":{"href":"https://api.github.com/repos/spark/docs/issues/467/comments"},"review_comments":{"href":"https://api.github.com/repos/spark/docs/pulls/467/comments"},"review_comment":{"href":"https://api.github.com/repos/spark/docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spark/docs/pulls/467/commits"},"statuses":{"href":"https://api.github.com/repos/spark/docs/statuses/a1aecc3ad184e5fe9ffd502055e9e708ea917830"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"technobly","id":2249224,"avatar_url":"https://avatars.githubusercontent.com/u/2249224?v=3","gravatar_id":"","url":"https://api.github.com/users/technobly","html_url":"https://github.com/technobly","followers_url":"https://api.github.com/users/technobly/followers","following_url":"https://api.github.com/users/technobly/following{/other_user}","gists_url":"https://api.github.com/users/technobly/gists{/gist_id}","starred_url":"https://api.github.com/users/technobly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/technobly/subscriptions","organizations_url":"https://api.github.com/users/technobly/orgs","repos_url":"https://api.github.com/users/technobly/repos","events_url":"https://api.github.com/users/technobly/events{/privacy}","received_events_url":"https://api.github.com/users/technobly/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"technobly"}}