{"action":"created","issue":{"url":"https://api.github.com/repos/ceph/ceph/issues/12624","repository_url":"https://api.github.com/repos/ceph/ceph","labels_url":"https://api.github.com/repos/ceph/ceph/issues/12624/labels{/name}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/12624/comments","events_url":"https://api.github.com/repos/ceph/ceph/issues/12624/events","html_url":"https://github.com/ceph/ceph/pull/12624","id":197184397,"number":12624,"title":"common/ceph_crypto: warn + assert if crypto shutdown fails","user":{"login":"liewegas","id":433031,"avatar_url":"https://avatars.githubusercontent.com/u/433031?v=3","gravatar_id":"","url":"https://api.github.com/users/liewegas","html_url":"https://github.com/liewegas","followers_url":"https://api.github.com/users/liewegas/followers","following_url":"https://api.github.com/users/liewegas/following{/other_user}","gists_url":"https://api.github.com/users/liewegas/gists{/gist_id}","starred_url":"https://api.github.com/users/liewegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liewegas/subscriptions","organizations_url":"https://api.github.com/users/liewegas/orgs","repos_url":"https://api.github.com/users/liewegas/repos","events_url":"https://api.github.com/users/liewegas/events{/privacy}","received_events_url":"https://api.github.com/users/liewegas/received_events","type":"User","site_admin":false},"labels":[{"id":199292951,"url":"https://api.github.com/repos/ceph/ceph/labels/common","name":"common","color":"006b75","default":false},{"id":148431321,"url":"https://api.github.com/repos/ceph/ceph/labels/needs-qa","name":"needs-qa","color":"fad8c7","default":false},{"id":290749046,"url":"https://api.github.com/repos/ceph/ceph/labels/wip-sage-testing2","name":"wip-sage-testing2","color":"e11d21","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-12-22T14:19:20Z","updated_at":"2016-12-27T22:56:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/12624","html_url":"https://github.com/ceph/ceph/pull/12624","diff_url":"https://github.com/ceph/ceph/pull/12624.diff","patch_url":"https://github.com/ceph/ceph/pull/12624.patch"},"body":"If we fail to shutdown, subsequent attempts to init within the same\r\nprocess can fail.  This can be triggered by leaked crypto objects (e.g.,\r\nan AsyncConnection).  The symptom is asserts on crypto init like so:\r\n\r\ncommon/ceph_crypto.cc: In function 'void ceph::crypto::init(CephContext*)' thread 7f8d9cd208c0 time 2016-07-14 12:17:44.515176\r\ncommon/ceph_crypto.cc: 73: FAILED assert(crypto_context != __null)\r\n\r\nwhich is quite confusing. See http://tracker.ceph.com/issues/14115.\r\n\r\nWarn and assert early (on shutdown!) so we can catch bugs!\r\n"},"comment":{"url":"https://api.github.com/repos/ceph/ceph/issues/comments/269394727","html_url":"https://github.com/ceph/ceph/pull/12624#issuecomment-269394727","issue_url":"https://api.github.com/repos/ceph/ceph/issues/12624","id":269394727,"user":{"login":"liewegas","id":433031,"avatar_url":"https://avatars.githubusercontent.com/u/433031?v=3","gravatar_id":"","url":"https://api.github.com/users/liewegas","html_url":"https://github.com/liewegas","followers_url":"https://api.github.com/users/liewegas/followers","following_url":"https://api.github.com/users/liewegas/following{/other_user}","gists_url":"https://api.github.com/users/liewegas/gists{/gist_id}","starred_url":"https://api.github.com/users/liewegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liewegas/subscriptions","organizations_url":"https://api.github.com/users/liewegas/orgs","repos_url":"https://api.github.com/users/liewegas/repos","events_url":"https://api.github.com/users/liewegas/events{/privacy}","received_events_url":"https://api.github.com/users/liewegas/received_events","type":"User","site_admin":false},"created_at":"2016-12-27T22:56:58Z","updated_at":"2016-12-27T22:56:58Z","body":"@dillaman @trociny : http://pulpito.ceph.com/sage-2016-12-27_15:31:49-rbd-wip-sage-testing2---basic-smithi/670306\r\nlooks like rbd mirror command is leaking something:\r\n<pre>\r\n2016-12-27T21:41:51.102 INFO:tasks.workunit.cluster1.client.mirror.smithi058.stderr:+ rbd --cluster=cluster2 mirror image demote mirror/test\r\n...\r\n2016-12-27T21:41:51.252 INFO:tasks.workunit.cluster1.client.mirror.smithi058.stdout:Image demoted to non-primary\r\n2016-12-27T21:41:51.255 INFO:tasks.workunit.cluster1.client.mirror.smithi058.stderr:NSS_ShutdownContext failed; leaked objects?\r\n</pre>\r\n"}}
{"actor":{"display_login":"liewegas"}}