{"action":"created","comment":{"url":"https://api.github.com/repos/beproud/beproudbot/pulls/comments/90989313","pull_request_review_id":11501685,"id":90989313,"diff_hunk":"@@ -1,6 +1,10 @@\n Unreleased\n ----------\n \n+Release Notes - 2016-12-01","path":"ChangeLog.txt","position":4,"original_position":4,"commit_id":"160b01b0a7598c55fd9cfcb988403f4f64df79d8","original_commit_id":"160b01b0a7598c55fd9cfcb988403f4f64df79d8","user":{"login":"takanory","id":988241,"avatar_url":"https://avatars.githubusercontent.com/u/988241?v=3","gravatar_id":"","url":"https://api.github.com/users/takanory","html_url":"https://github.com/takanory","followers_url":"https://api.github.com/users/takanory/followers","following_url":"https://api.github.com/users/takanory/following{/other_user}","gists_url":"https://api.github.com/users/takanory/gists{/gist_id}","starred_url":"https://api.github.com/users/takanory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takanory/subscriptions","organizations_url":"https://api.github.com/users/takanory/orgs","repos_url":"https://api.github.com/users/takanory/repos","events_url":"https://api.github.com/users/takanory/events{/privacy}","received_events_url":"https://api.github.com/users/takanory/received_events","type":"User","site_admin":false},"body":"mergeするときに(?)日付を変えるのをお忘れなく","created_at":"2016-12-06T00:34:31Z","updated_at":"2016-12-06T00:42:55Z","html_url":"https://github.com/beproud/beproudbot/pull/17#discussion_r90989313","pull_request_url":"https://api.github.com/repos/beproud/beproudbot/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/beproud/beproudbot/pulls/comments/90989313"},"html":{"href":"https://github.com/beproud/beproudbot/pull/17#discussion_r90989313"},"pull_request":{"href":"https://api.github.com/repos/beproud/beproudbot/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/beproud/beproudbot/pulls/17","id":96464150,"html_url":"https://github.com/beproud/beproudbot/pull/17","diff_url":"https://github.com/beproud/beproudbot/pull/17.diff","patch_url":"https://github.com/beproud/beproudbot/pull/17.patch","issue_url":"https://api.github.com/repos/beproud/beproudbot/issues/17","number":17,"state":"open","locked":false,"title":"refs #10 slackbotでalembicでDBマイグレーションできるようにするコード追加 ","user":{"login":"wanshot","id":13720034,"avatar_url":"https://avatars.githubusercontent.com/u/13720034?v=3","gravatar_id":"","url":"https://api.github.com/users/wanshot","html_url":"https://github.com/wanshot","followers_url":"https://api.github.com/users/wanshot/followers","following_url":"https://api.github.com/users/wanshot/following{/other_user}","gists_url":"https://api.github.com/users/wanshot/gists{/gist_id}","starred_url":"https://api.github.com/users/wanshot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wanshot/subscriptions","organizations_url":"https://api.github.com/users/wanshot/orgs","repos_url":"https://api.github.com/users/wanshot/repos","events_url":"https://api.github.com/users/wanshot/events{/privacy}","received_events_url":"https://api.github.com/users/wanshot/received_events","type":"User","site_admin":false},"body":"ISSUE URL\r\n\r\n- https://github.com/beproud/beproudbot/issues/10\r\n\r\nこのレビューで確認してほしい点\r\n\r\n- slackbot、alembic、SQLAlchemyの連携はこのやり方で問題ないか\r\n\r\nレビューチェックリスト\r\n\r\n- [ ] C2 体を表す名前の公理：あらかじめ決められている以外の汎用的な名前のモジュールを作らない\r\n- [ ] C3 汎用名のモジュール内に長々と具体的処理を書かない\r\n- [ ] C4 単純な処理の長さで分割しない\r\n- [ ] C5 引数の数を減らす\r\n- [ ] C6 パッケージ間で共通した定数を作らない\r\n- [ ] C7 継承の利用を最小限にする\r\n- [ ] C8 親クラスのテストを子クラスでも実行すること\r\n- [ ] C9 オーバーライドを減らす\r\n- [ ] C10 継承やオーバーライドを明示する\r\n","created_at":"2016-12-05T03:27:53Z","updated_at":"2016-12-06T00:42:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b07fed093363cc7ccf321e925b73315c8f91a7b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/beproud/beproudbot/pulls/17/commits","review_comments_url":"https://api.github.com/repos/beproud/beproudbot/pulls/17/comments","review_comment_url":"https://api.github.com/repos/beproud/beproudbot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/beproud/beproudbot/issues/17/comments","statuses_url":"https://api.github.com/repos/beproud/beproudbot/statuses/160b01b0a7598c55fd9cfcb988403f4f64df79d8","head":{"label":"beproud:t10","ref":"t10","sha":"160b01b0a7598c55fd9cfcb988403f4f64df79d8","user":{"login":"beproud","id":643795,"avatar_url":"https://avatars.githubusercontent.com/u/643795?v=3","gravatar_id":"","url":"https://api.github.com/users/beproud","html_url":"https://github.com/beproud","followers_url":"https://api.github.com/users/beproud/followers","following_url":"https://api.github.com/users/beproud/following{/other_user}","gists_url":"https://api.github.com/users/beproud/gists{/gist_id}","starred_url":"https://api.github.com/users/beproud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beproud/subscriptions","organizations_url":"https://api.github.com/users/beproud/orgs","repos_url":"https://api.github.com/users/beproud/repos","events_url":"https://api.github.com/users/beproud/events{/privacy}","received_events_url":"https://api.github.com/users/beproud/received_events","type":"Organization","site_admin":false},"repo":{"id":71103212,"name":"beproudbot","full_name":"beproud/beproudbot","owner":{"login":"beproud","id":643795,"avatar_url":"https://avatars.githubusercontent.com/u/643795?v=3","gravatar_id":"","url":"https://api.github.com/users/beproud","html_url":"https://github.com/beproud","followers_url":"https://api.github.com/users/beproud/followers","following_url":"https://api.github.com/users/beproud/following{/other_user}","gists_url":"https://api.github.com/users/beproud/gists{/gist_id}","starred_url":"https://api.github.com/users/beproud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beproud/subscriptions","organizations_url":"https://api.github.com/users/beproud/orgs","repos_url":"https://api.github.com/users/beproud/repos","events_url":"https://api.github.com/users/beproud/events{/privacy}","received_events_url":"https://api.github.com/users/beproud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/beproud/beproudbot","description":null,"fork":false,"url":"https://api.github.com/repos/beproud/beproudbot","forks_url":"https://api.github.com/repos/beproud/beproudbot/forks","keys_url":"https://api.github.com/repos/beproud/beproudbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/beproud/beproudbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/beproud/beproudbot/teams","hooks_url":"https://api.github.com/repos/beproud/beproudbot/hooks","issue_events_url":"https://api.github.com/repos/beproud/beproudbot/issues/events{/number}","events_url":"https://api.github.com/repos/beproud/beproudbot/events","assignees_url":"https://api.github.com/repos/beproud/beproudbot/assignees{/user}","branches_url":"https://api.github.com/repos/beproud/beproudbot/branches{/branch}","tags_url":"https://api.github.com/repos/beproud/beproudbot/tags","blobs_url":"https://api.github.com/repos/beproud/beproudbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/beproud/beproudbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/beproud/beproudbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/beproud/beproudbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/beproud/beproudbot/statuses/{sha}","languages_url":"https://api.github.com/repos/beproud/beproudbot/languages","stargazers_url":"https://api.github.com/repos/beproud/beproudbot/stargazers","contributors_url":"https://api.github.com/repos/beproud/beproudbot/contributors","subscribers_url":"https://api.github.com/repos/beproud/beproudbot/subscribers","subscription_url":"https://api.github.com/repos/beproud/beproudbot/subscription","commits_url":"https://api.github.com/repos/beproud/beproudbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/beproud/beproudbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/beproud/beproudbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/beproud/beproudbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/beproud/beproudbot/contents/{+path}","compare_url":"https://api.github.com/repos/beproud/beproudbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/beproud/beproudbot/merges","archive_url":"https://api.github.com/repos/beproud/beproudbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/beproud/beproudbot/downloads","issues_url":"https://api.github.com/repos/beproud/beproudbot/issues{/number}","pulls_url":"https://api.github.com/repos/beproud/beproudbot/pulls{/number}","milestones_url":"https://api.github.com/repos/beproud/beproudbot/milestones{/number}","notifications_url":"https://api.github.com/repos/beproud/beproudbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/beproud/beproudbot/labels{/name}","releases_url":"https://api.github.com/repos/beproud/beproudbot/releases{/id}","deployments_url":"https://api.github.com/repos/beproud/beproudbot/deployments","created_at":"2016-10-17T05:35:24Z","updated_at":"2016-10-18T12:56:01Z","pushed_at":"2016-12-06T00:01:57Z","git_url":"git://github.com/beproud/beproudbot.git","ssh_url":"git@github.com:beproud/beproudbot.git","clone_url":"https://github.com/beproud/beproudbot.git","svn_url":"https://github.com/beproud/beproudbot","homepage":null,"size":27,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":11,"forks":0,"open_issues":11,"watchers":0,"default_branch":"master"}},"base":{"label":"beproud:master","ref":"master","sha":"56284b35d9b95d7afe1d1378c46703b8f900c289","user":{"login":"beproud","id":643795,"avatar_url":"https://avatars.githubusercontent.com/u/643795?v=3","gravatar_id":"","url":"https://api.github.com/users/beproud","html_url":"https://github.com/beproud","followers_url":"https://api.github.com/users/beproud/followers","following_url":"https://api.github.com/users/beproud/following{/other_user}","gists_url":"https://api.github.com/users/beproud/gists{/gist_id}","starred_url":"https://api.github.com/users/beproud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beproud/subscriptions","organizations_url":"https://api.github.com/users/beproud/orgs","repos_url":"https://api.github.com/users/beproud/repos","events_url":"https://api.github.com/users/beproud/events{/privacy}","received_events_url":"https://api.github.com/users/beproud/received_events","type":"Organization","site_admin":false},"repo":{"id":71103212,"name":"beproudbot","full_name":"beproud/beproudbot","owner":{"login":"beproud","id":643795,"avatar_url":"https://avatars.githubusercontent.com/u/643795?v=3","gravatar_id":"","url":"https://api.github.com/users/beproud","html_url":"https://github.com/beproud","followers_url":"https://api.github.com/users/beproud/followers","following_url":"https://api.github.com/users/beproud/following{/other_user}","gists_url":"https://api.github.com/users/beproud/gists{/gist_id}","starred_url":"https://api.github.com/users/beproud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beproud/subscriptions","organizations_url":"https://api.github.com/users/beproud/orgs","repos_url":"https://api.github.com/users/beproud/repos","events_url":"https://api.github.com/users/beproud/events{/privacy}","received_events_url":"https://api.github.com/users/beproud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/beproud/beproudbot","description":null,"fork":false,"url":"https://api.github.com/repos/beproud/beproudbot","forks_url":"https://api.github.com/repos/beproud/beproudbot/forks","keys_url":"https://api.github.com/repos/beproud/beproudbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/beproud/beproudbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/beproud/beproudbot/teams","hooks_url":"https://api.github.com/repos/beproud/beproudbot/hooks","issue_events_url":"https://api.github.com/repos/beproud/beproudbot/issues/events{/number}","events_url":"https://api.github.com/repos/beproud/beproudbot/events","assignees_url":"https://api.github.com/repos/beproud/beproudbot/assignees{/user}","branches_url":"https://api.github.com/repos/beproud/beproudbot/branches{/branch}","tags_url":"https://api.github.com/repos/beproud/beproudbot/tags","blobs_url":"https://api.github.com/repos/beproud/beproudbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/beproud/beproudbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/beproud/beproudbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/beproud/beproudbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/beproud/beproudbot/statuses/{sha}","languages_url":"https://api.github.com/repos/beproud/beproudbot/languages","stargazers_url":"https://api.github.com/repos/beproud/beproudbot/stargazers","contributors_url":"https://api.github.com/repos/beproud/beproudbot/contributors","subscribers_url":"https://api.github.com/repos/beproud/beproudbot/subscribers","subscription_url":"https://api.github.com/repos/beproud/beproudbot/subscription","commits_url":"https://api.github.com/repos/beproud/beproudbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/beproud/beproudbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/beproud/beproudbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/beproud/beproudbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/beproud/beproudbot/contents/{+path}","compare_url":"https://api.github.com/repos/beproud/beproudbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/beproud/beproudbot/merges","archive_url":"https://api.github.com/repos/beproud/beproudbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/beproud/beproudbot/downloads","issues_url":"https://api.github.com/repos/beproud/beproudbot/issues{/number}","pulls_url":"https://api.github.com/repos/beproud/beproudbot/pulls{/number}","milestones_url":"https://api.github.com/repos/beproud/beproudbot/milestones{/number}","notifications_url":"https://api.github.com/repos/beproud/beproudbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/beproud/beproudbot/labels{/name}","releases_url":"https://api.github.com/repos/beproud/beproudbot/releases{/id}","deployments_url":"https://api.github.com/repos/beproud/beproudbot/deployments","created_at":"2016-10-17T05:35:24Z","updated_at":"2016-10-18T12:56:01Z","pushed_at":"2016-12-06T00:01:57Z","git_url":"git://github.com/beproud/beproudbot.git","ssh_url":"git@github.com:beproud/beproudbot.git","clone_url":"https://github.com/beproud/beproudbot.git","svn_url":"https://github.com/beproud/beproudbot","homepage":null,"size":27,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":11,"forks":0,"open_issues":11,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/beproud/beproudbot/pulls/17"},"html":{"href":"https://github.com/beproud/beproudbot/pull/17"},"issue":{"href":"https://api.github.com/repos/beproud/beproudbot/issues/17"},"comments":{"href":"https://api.github.com/repos/beproud/beproudbot/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/beproud/beproudbot/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/beproud/beproudbot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/beproud/beproudbot/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/beproud/beproudbot/statuses/160b01b0a7598c55fd9cfcb988403f4f64df79d8"}}}}
{"actor":{"display_login":"takanory"}}