{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/16470","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16470/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16470/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16470/events","html_url":"https://github.com/cms-sw/cmssw/pull/16470","id":187330375,"number":16470,"title":"Fix phase2 pixel in GeometrySearch","user":{"login":"ebrondol","id":5331004,"avatar_url":"https://avatars.githubusercontent.com/u/5331004?v=3","gravatar_id":"","url":"https://api.github.com/users/ebrondol","html_url":"https://github.com/ebrondol","followers_url":"https://api.github.com/users/ebrondol/followers","following_url":"https://api.github.com/users/ebrondol/following{/other_user}","gists_url":"https://api.github.com/users/ebrondol/gists{/gist_id}","starred_url":"https://api.github.com/users/ebrondol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebrondol/subscriptions","organizations_url":"https://api.github.com/users/ebrondol/orgs","repos_url":"https://api.github.com/users/ebrondol/repos","events_url":"https://api.github.com/users/ebrondol/events{/privacy}","received_events_url":"https://api.github.com/users/ebrondol/received_events","type":"User","site_admin":false},"labels":[{"id":88653795,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04","default":false},{"id":56953091,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420","default":false},{"id":52820010,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04","default":false},{"id":56131152,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-pending","name":"tests-pending","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_1_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59/labels","id":1590252,"number":59,"title":"Next CMSSW_8_1_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":56,"closed_issues":1929,"state":"open","created_at":"2016-02-18T09:12:12Z","updated_at":"2016-11-16T16:29:40Z","due_on":"2016-11-26T00:00:00Z","closed_at":null},"comments":26,"created_at":"2016-11-04T13:15:39Z","updated_at":"2016-11-16T17:42:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/16470","html_url":"https://github.com/cms-sw/cmssw/pull/16470","diff_url":"https://github.com/cms-sw/cmssw/pull/16470.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/16470.patch"},"body":"This PR has been developed in CMSSW_8_1_X_2016-11-01-2300 and tested on top of the PR #16407. This is the evolution of the story: with a private branch that produce the hit on track maps for phase2 geometry, I produced the ratio clusters/clusters on track in D4:\r\n![ontrackmultmap_v4021_baseline](https://cloud.githubusercontent.com/assets/5331004/20005936/65407394-a295-11e6-98c2-cb284fb1922e.png)\r\nIt is pretty clear that the forward phase2 pixel detector is missing some hits and the last rings of the last forward layers[8-11] are not included in the search. \r\nThe problem has been cured using not anymore the class `PixelForwardLayerBuilder` but instead adapting `Phase2OTEndcapLayerBuilder` to be also used for the forward phase2 pixel. In this respect the naming has been changed everywhere.\r\nAfter this fix, the new map for D4 looks like:\r\n![ontrackmultmap_v4021_fixphase2pixelgeometry_rebase](https://cloud.githubusercontent.com/assets/5331004/20006102/56e5273a-a296-11e6-8257-0ef19732a0bc.png)\r\nThe code has been changed in such a way that the other D* should not be affected.\r\n\r\nThis impact some track variables such as the #hits vs eta, just two examples for [single mu](http://ebrondol.web.cern.ch/ebrondol/Phase2Tracking/fixPhase2PixelGeometry/20161103_FourMuExtended/plots_ootb/hitsAndPt.pdf) and for [ttbar](http://ebrondol.web.cern.ch/ebrondol/Phase2Tracking/fixPhase2PixelGeometry/20161103_TTbar/plots_ootb/hitsAndPt.pdf). But both seem now much more reasonable respect to before. If you want to have a look at the full set of results you can find them [here](http://ebrondol.web.cern.ch/ebrondol/Phase2Tracking/fixPhase2PixelGeometry/20161103_FourMuExtended/) and [there](http://ebrondol.web.cern.ch/ebrondol/Phase2Tracking/fixPhase2PixelGeometry/20161103_TTbar/). No huge differences have been noticed in eff/fakes.\r\n\r\nThe documentation in `RecoTracker/TkDetLayers/doc/TkDetLayersTree.pdf` has also been update - including the tilted update that was never introduced.\r\n\r\nThanks to @VinInn @rovere @venturia \r\nInforming @delaere @boudoul  @atricomi @kpedro88 "},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/261016956","html_url":"https://github.com/cms-sw/cmssw/pull/16470#issuecomment-261016956","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16470","id":261016956,"user":{"login":"cmsbuild","id":4170616,"avatar_url":"https://avatars.githubusercontent.com/u/4170616?v=3","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"created_at":"2016-11-16T17:42:54Z","updated_at":"2016-11-16T17:42:54Z","body":"The tests are being triggered in jenkins."}}
{"actor":{"display_login":"cmsbuild"}}