{"action":"opened","number":6678,"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/6678","id":97144333,"html_url":"https://github.com/juju/juju/pull/6678","diff_url":"https://github.com/juju/juju/pull/6678.diff","patch_url":"https://github.com/juju/juju/pull/6678.patch","issue_url":"https://api.github.com/repos/juju/juju/issues/6678","number":6678,"state":"open","locked":false,"title":"migrations: don't start model workers while a model is importing","user":{"login":"babbageclunk","id":563399,"avatar_url":"https://avatars.githubusercontent.com/u/563399?v=3","gravatar_id":"","url":"https://api.github.com/users/babbageclunk","html_url":"https://github.com/babbageclunk","followers_url":"https://api.github.com/users/babbageclunk/followers","following_url":"https://api.github.com/users/babbageclunk/following{/other_user}","gists_url":"https://api.github.com/users/babbageclunk/gists{/gist_id}","starred_url":"https://api.github.com/users/babbageclunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babbageclunk/subscriptions","organizations_url":"https://api.github.com/users/babbageclunk/orgs","repos_url":"https://api.github.com/users/babbageclunk/repos","events_url":"https://api.github.com/users/babbageclunk/events{/privacy}","received_events_url":"https://api.github.com/users/babbageclunk/received_events","type":"User","site_admin":false},"body":"Fixes https://bugs.launchpad.net/juju/+bug/1646310\r\n\r\nStarting the migration master while the model was being imported back\r\ninto a controller that it had previously migrated out of caused it to\r\nuninstall itself from the engine (thinking that it was finished\r\nprocessing the old migration), which blocked any workers that depended\r\non ifNotMigrating. To fix this we wait until the model MigrationMode \r\nhas changed to MigrationModeNone - this means the watcher needs to \r\nsignal on any changes to models, rather than just life.\r\n\r\nThe apiserver code to remove state objects from the pool still needs to\r\nwatch life specifically. If the model becomes Dead and is then\r\nremoved within the event coalescence time then the collection watcher\r\nwon't report any event, but a lifecycle watcher will.\r\n\r\n","created_at":"2016-12-08T15:37:11Z","updated_at":"2016-12-08T15:37:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9fbbdddfd129da908132b849673cb77f6a01c463","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju/pulls/6678/commits","review_comments_url":"https://api.github.com/repos/juju/juju/pulls/6678/comments","review_comment_url":"https://api.github.com/repos/juju/juju/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju/juju/issues/6678/comments","statuses_url":"https://api.github.com/repos/juju/juju/statuses/da0d9667760b115b2342e4202a9dfe62908b488e","head":{"label":"babbageclunk:migration-bounce","ref":"migration-bounce","sha":"da0d9667760b115b2342e4202a9dfe62908b488e","user":{"login":"babbageclunk","id":563399,"avatar_url":"https://avatars.githubusercontent.com/u/563399?v=3","gravatar_id":"","url":"https://api.github.com/users/babbageclunk","html_url":"https://github.com/babbageclunk","followers_url":"https://api.github.com/users/babbageclunk/followers","following_url":"https://api.github.com/users/babbageclunk/following{/other_user}","gists_url":"https://api.github.com/users/babbageclunk/gists{/gist_id}","starred_url":"https://api.github.com/users/babbageclunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babbageclunk/subscriptions","organizations_url":"https://api.github.com/users/babbageclunk/orgs","repos_url":"https://api.github.com/users/babbageclunk/repos","events_url":"https://api.github.com/users/babbageclunk/events{/privacy}","received_events_url":"https://api.github.com/users/babbageclunk/received_events","type":"User","site_admin":false},"repo":{"id":54490872,"name":"juju","full_name":"babbageclunk/juju","owner":{"login":"babbageclunk","id":563399,"avatar_url":"https://avatars.githubusercontent.com/u/563399?v=3","gravatar_id":"","url":"https://api.github.com/users/babbageclunk","html_url":"https://github.com/babbageclunk","followers_url":"https://api.github.com/users/babbageclunk/followers","following_url":"https://api.github.com/users/babbageclunk/following{/other_user}","gists_url":"https://api.github.com/users/babbageclunk/gists{/gist_id}","starred_url":"https://api.github.com/users/babbageclunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babbageclunk/subscriptions","organizations_url":"https://api.github.com/users/babbageclunk/orgs","repos_url":"https://api.github.com/users/babbageclunk/repos","events_url":"https://api.github.com/users/babbageclunk/events{/privacy}","received_events_url":"https://api.github.com/users/babbageclunk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/babbageclunk/juju","description":"juju is devops distilled","fork":true,"url":"https://api.github.com/repos/babbageclunk/juju","forks_url":"https://api.github.com/repos/babbageclunk/juju/forks","keys_url":"https://api.github.com/repos/babbageclunk/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/babbageclunk/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/babbageclunk/juju/teams","hooks_url":"https://api.github.com/repos/babbageclunk/juju/hooks","issue_events_url":"https://api.github.com/repos/babbageclunk/juju/issues/events{/number}","events_url":"https://api.github.com/repos/babbageclunk/juju/events","assignees_url":"https://api.github.com/repos/babbageclunk/juju/assignees{/user}","branches_url":"https://api.github.com/repos/babbageclunk/juju/branches{/branch}","tags_url":"https://api.github.com/repos/babbageclunk/juju/tags","blobs_url":"https://api.github.com/repos/babbageclunk/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/babbageclunk/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/babbageclunk/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/babbageclunk/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/babbageclunk/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/babbageclunk/juju/languages","stargazers_url":"https://api.github.com/repos/babbageclunk/juju/stargazers","contributors_url":"https://api.github.com/repos/babbageclunk/juju/contributors","subscribers_url":"https://api.github.com/repos/babbageclunk/juju/subscribers","subscription_url":"https://api.github.com/repos/babbageclunk/juju/subscription","commits_url":"https://api.github.com/repos/babbageclunk/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/babbageclunk/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/babbageclunk/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/babbageclunk/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/babbageclunk/juju/contents/{+path}","compare_url":"https://api.github.com/repos/babbageclunk/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/babbageclunk/juju/merges","archive_url":"https://api.github.com/repos/babbageclunk/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/babbageclunk/juju/downloads","issues_url":"https://api.github.com/repos/babbageclunk/juju/issues{/number}","pulls_url":"https://api.github.com/repos/babbageclunk/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/babbageclunk/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/babbageclunk/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/babbageclunk/juju/labels{/name}","releases_url":"https://api.github.com/repos/babbageclunk/juju/releases{/id}","deployments_url":"https://api.github.com/repos/babbageclunk/juju/deployments","created_at":"2016-03-22T16:26:25Z","updated_at":"2016-03-22T16:26:34Z","pushed_at":"2016-12-08T15:26:47Z","git_url":"git://github.com/babbageclunk/juju.git","ssh_url":"git@github.com:babbageclunk/juju.git","clone_url":"https://github.com/babbageclunk/juju.git","svn_url":"https://github.com/babbageclunk/juju","homepage":"juju.ubuntu.com","size":96456,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juju:develop","ref":"develop","sha":"2f1c93edec08597e9eea057634a5663787f77e9c","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20445947,"name":"juju","full_name":"juju/juju","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju","description":"juju is devops distilled","fork":false,"url":"https://api.github.com/repos/juju/juju","forks_url":"https://api.github.com/repos/juju/juju/forks","keys_url":"https://api.github.com/repos/juju/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju/teams","hooks_url":"https://api.github.com/repos/juju/juju/hooks","issue_events_url":"https://api.github.com/repos/juju/juju/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju/events","assignees_url":"https://api.github.com/repos/juju/juju/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju/tags","blobs_url":"https://api.github.com/repos/juju/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju/languages","stargazers_url":"https://api.github.com/repos/juju/juju/stargazers","contributors_url":"https://api.github.com/repos/juju/juju/contributors","subscribers_url":"https://api.github.com/repos/juju/juju/subscribers","subscription_url":"https://api.github.com/repos/juju/juju/subscription","commits_url":"https://api.github.com/repos/juju/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju/juju/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju/merges","archive_url":"https://api.github.com/repos/juju/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju/downloads","issues_url":"https://api.github.com/repos/juju/juju/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju/releases{/id}","deployments_url":"https://api.github.com/repos/juju/juju/deployments","created_at":"2014-06-03T14:28:10Z","updated_at":"2016-12-07T03:02:43Z","pushed_at":"2016-12-08T15:37:11Z","git_url":"git://github.com/juju/juju.git","ssh_url":"git@github.com:juju/juju.git","clone_url":"https://github.com/juju/juju.git","svn_url":"https://github.com/juju/juju","homepage":"juju.ubuntu.com","size":129195,"stargazers_count":543,"watchers_count":543,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":170,"mirror_url":null,"open_issues_count":21,"forks":170,"open_issues":21,"watchers":543,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/6678"},"html":{"href":"https://github.com/juju/juju/pull/6678"},"issue":{"href":"https://api.github.com/repos/juju/juju/issues/6678"},"comments":{"href":"https://api.github.com/repos/juju/juju/issues/6678/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju/pulls/6678/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju/juju/pulls/6678/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju/statuses/da0d9667760b115b2342e4202a9dfe62908b488e"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":143,"deletions":28,"changed_files":9}}
{"actor":{"display_login":"babbageclunk"}}