{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8453","repository_url":"https://api.github.com/repos/bitcoin/bitcoin","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8453/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8453/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8453/events","html_url":"https://github.com/bitcoin/bitcoin/pull/8453","id":169330231,"number":8453,"title":"Bring secp256k1 subtree up to date with master","user":{"login":"laanwj","id":126646,"avatar_url":"https://avatars.githubusercontent.com/u/126646?v=3","gravatar_id":"","url":"https://api.github.com/users/laanwj","html_url":"https://github.com/laanwj","followers_url":"https://api.github.com/users/laanwj/followers","following_url":"https://api.github.com/users/laanwj/following{/other_user}","gists_url":"https://api.github.com/users/laanwj/gists{/gist_id}","starred_url":"https://api.github.com/users/laanwj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laanwj/subscriptions","organizations_url":"https://api.github.com/users/laanwj/orgs","repos_url":"https://api.github.com/users/laanwj/repos","events_url":"https://api.github.com/users/laanwj/events{/privacy}","received_events_url":"https://api.github.com/users/laanwj/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Utils%20and%20libraries","name":"Utils and libraries","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-04T09:25:30Z","updated_at":"2016-08-04T09:52:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8453","html_url":"https://github.com/bitcoin/bitcoin/pull/8453","diff_url":"https://github.com/bitcoin/bitcoin/pull/8453.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/8453.patch"},"body":"The last update of secp256k1 has been ~9 months ago (6c527ec), probably it is time to update the subtree again.\r\nAt least the (experimental) ARM assembly has been merged since.\r\n\r\nAccording to @sipa on IRC \"there are certainly no regressions known that would make the current master less appropriate than the subtree in bitcoin currently\""},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/237507368","html_url":"https://github.com/bitcoin/bitcoin/pull/8453#issuecomment-237507368","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8453","id":237507368,"user":{"login":"paveljanik","id":6848764,"avatar_url":"https://avatars.githubusercontent.com/u/6848764?v=3","gravatar_id":"","url":"https://api.github.com/users/paveljanik","html_url":"https://github.com/paveljanik","followers_url":"https://api.github.com/users/paveljanik/followers","following_url":"https://api.github.com/users/paveljanik/following{/other_user}","gists_url":"https://api.github.com/users/paveljanik/gists{/gist_id}","starred_url":"https://api.github.com/users/paveljanik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paveljanik/subscriptions","organizations_url":"https://api.github.com/users/paveljanik/orgs","repos_url":"https://api.github.com/users/paveljanik/repos","events_url":"https://api.github.com/users/paveljanik/events{/privacy}","received_events_url":"https://api.github.com/users/paveljanik/received_events","type":"User","site_admin":false},"created_at":"2016-08-04T09:52:45Z","updated_at":"2016-08-04T09:52:45Z","body":"Removal of <string.h> include is probably the source of this warning:\r\n\r\n```\r\n+In file included from src/secp256k1.c:14:\r\n+./src/ecmult_impl.h:186:9: warning: implicitly declaring library function 'memcpy' with type 'void *(void *, const void *, unsigned long)'\r\n+        memcpy(dst->pre_g, src->pre_g, size);\r\n+        ^\r\n+./src/ecmult_impl.h:186:9: note: include the header <string.h> or explicitly provide a declaration for 'memcpy'\r\n+./src/ecmult_impl.h:230:5: warning: implicitly declaring library function 'memset' with type 'void *(void *, int, unsigned long)'\r\n+    memset(wnaf, 0, len * sizeof(wnaf[0]));\r\n+    ^\r\n+./src/ecmult_impl.h:230:5: note: include the header <string.h> or explicitly provide a declaration for 'memset'\r\n+2 warnings generated.\r\n```\r\n\r\nWill report upstream..."}}
{"actor":{"display_login":"paveljanik"}}