{"action":"opened","number":392,"pull_request":{"url":"https://api.github.com/repos/bgrins/spectrum/pulls/392","id":58789525,"html_url":"https://github.com/bgrins/spectrum/pull/392","diff_url":"https://github.com/bgrins/spectrum/pull/392.diff","patch_url":"https://github.com/bgrins/spectrum/pull/392.patch","issue_url":"https://api.github.com/repos/bgrins/spectrum/issues/392","number":392,"state":"open","locked":false,"title":"Remove stopPropagation on choose & cancel buttons","user":{"login":"kesun","id":2268069,"avatar_url":"https://avatars.githubusercontent.com/u/2268069?v=3","gravatar_id":"","url":"https://api.github.com/users/kesun","html_url":"https://github.com/kesun","followers_url":"https://api.github.com/users/kesun/followers","following_url":"https://api.github.com/users/kesun/following{/other_user}","gists_url":"https://api.github.com/users/kesun/gists{/gist_id}","starred_url":"https://api.github.com/users/kesun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kesun/subscriptions","organizations_url":"https://api.github.com/users/kesun/orgs","repos_url":"https://api.github.com/users/kesun/repos","events_url":"https://api.github.com/users/kesun/events{/privacy}","received_events_url":"https://api.github.com/users/kesun/received_events","type":"User","site_admin":false},"body":"It's not ideal to use stopPropagation() on these two bottons in case if users of the library wishes to intercept the clicking event on them and perform explicit actions on colour picked through hex code, for example. There are also plenty of other places that use stopPropagation that may need some cleanup, but let's start with these two for now.","created_at":"2016-02-09T18:36:34Z","updated_at":"2016-02-09T18:36:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bgrins/spectrum/pulls/392/commits","review_comments_url":"https://api.github.com/repos/bgrins/spectrum/pulls/392/comments","review_comment_url":"https://api.github.com/repos/bgrins/spectrum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bgrins/spectrum/issues/392/comments","statuses_url":"https://api.github.com/repos/bgrins/spectrum/statuses/518f8f5e1fc5dd36135d1ce6a556290287e07b75","head":{"label":"kesun:master","ref":"master","sha":"518f8f5e1fc5dd36135d1ce6a556290287e07b75","user":{"login":"kesun","id":2268069,"avatar_url":"https://avatars.githubusercontent.com/u/2268069?v=3","gravatar_id":"","url":"https://api.github.com/users/kesun","html_url":"https://github.com/kesun","followers_url":"https://api.github.com/users/kesun/followers","following_url":"https://api.github.com/users/kesun/following{/other_user}","gists_url":"https://api.github.com/users/kesun/gists{/gist_id}","starred_url":"https://api.github.com/users/kesun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kesun/subscriptions","organizations_url":"https://api.github.com/users/kesun/orgs","repos_url":"https://api.github.com/users/kesun/repos","events_url":"https://api.github.com/users/kesun/events{/privacy}","received_events_url":"https://api.github.com/users/kesun/received_events","type":"User","site_admin":false},"repo":{"id":51388695,"name":"spectrum","full_name":"kesun/spectrum","owner":{"login":"kesun","id":2268069,"avatar_url":"https://avatars.githubusercontent.com/u/2268069?v=3","gravatar_id":"","url":"https://api.github.com/users/kesun","html_url":"https://github.com/kesun","followers_url":"https://api.github.com/users/kesun/followers","following_url":"https://api.github.com/users/kesun/following{/other_user}","gists_url":"https://api.github.com/users/kesun/gists{/gist_id}","starred_url":"https://api.github.com/users/kesun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kesun/subscriptions","organizations_url":"https://api.github.com/users/kesun/orgs","repos_url":"https://api.github.com/users/kesun/repos","events_url":"https://api.github.com/users/kesun/events{/privacy}","received_events_url":"https://api.github.com/users/kesun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kesun/spectrum","description":"The No Hassle JavaScript Colorpicker","fork":true,"url":"https://api.github.com/repos/kesun/spectrum","forks_url":"https://api.github.com/repos/kesun/spectrum/forks","keys_url":"https://api.github.com/repos/kesun/spectrum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kesun/spectrum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kesun/spectrum/teams","hooks_url":"https://api.github.com/repos/kesun/spectrum/hooks","issue_events_url":"https://api.github.com/repos/kesun/spectrum/issues/events{/number}","events_url":"https://api.github.com/repos/kesun/spectrum/events","assignees_url":"https://api.github.com/repos/kesun/spectrum/assignees{/user}","branches_url":"https://api.github.com/repos/kesun/spectrum/branches{/branch}","tags_url":"https://api.github.com/repos/kesun/spectrum/tags","blobs_url":"https://api.github.com/repos/kesun/spectrum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kesun/spectrum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kesun/spectrum/git/refs{/sha}","trees_url":"https://api.github.com/repos/kesun/spectrum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kesun/spectrum/statuses/{sha}","languages_url":"https://api.github.com/repos/kesun/spectrum/languages","stargazers_url":"https://api.github.com/repos/kesun/spectrum/stargazers","contributors_url":"https://api.github.com/repos/kesun/spectrum/contributors","subscribers_url":"https://api.github.com/repos/kesun/spectrum/subscribers","subscription_url":"https://api.github.com/repos/kesun/spectrum/subscription","commits_url":"https://api.github.com/repos/kesun/spectrum/commits{/sha}","git_commits_url":"https://api.github.com/repos/kesun/spectrum/git/commits{/sha}","comments_url":"https://api.github.com/repos/kesun/spectrum/comments{/number}","issue_comment_url":"https://api.github.com/repos/kesun/spectrum/issues/comments{/number}","contents_url":"https://api.github.com/repos/kesun/spectrum/contents/{+path}","compare_url":"https://api.github.com/repos/kesun/spectrum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kesun/spectrum/merges","archive_url":"https://api.github.com/repos/kesun/spectrum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kesun/spectrum/downloads","issues_url":"https://api.github.com/repos/kesun/spectrum/issues{/number}","pulls_url":"https://api.github.com/repos/kesun/spectrum/pulls{/number}","milestones_url":"https://api.github.com/repos/kesun/spectrum/milestones{/number}","notifications_url":"https://api.github.com/repos/kesun/spectrum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kesun/spectrum/labels{/name}","releases_url":"https://api.github.com/repos/kesun/spectrum/releases{/id}","deployments_url":"https://api.github.com/repos/kesun/spectrum/deployments","created_at":"2016-02-09T18:28:43Z","updated_at":"2016-02-09T18:28:45Z","pushed_at":"2016-02-09T18:35:24Z","git_url":"git://github.com/kesun/spectrum.git","ssh_url":"git@github.com:kesun/spectrum.git","clone_url":"https://github.com/kesun/spectrum.git","svn_url":"https://github.com/kesun/spectrum","homepage":"http://bgrins.github.io/spectrum/","size":1902,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bgrins:master","ref":"master","sha":"d4cfb9bebd1c4f57266079b90e46067d1d734ab8","user":{"login":"bgrins","id":95570,"avatar_url":"https://avatars.githubusercontent.com/u/95570?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrins","html_url":"https://github.com/bgrins","followers_url":"https://api.github.com/users/bgrins/followers","following_url":"https://api.github.com/users/bgrins/following{/other_user}","gists_url":"https://api.github.com/users/bgrins/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrins/subscriptions","organizations_url":"https://api.github.com/users/bgrins/orgs","repos_url":"https://api.github.com/users/bgrins/repos","events_url":"https://api.github.com/users/bgrins/events{/privacy}","received_events_url":"https://api.github.com/users/bgrins/received_events","type":"User","site_admin":false},"repo":{"id":2094490,"name":"spectrum","full_name":"bgrins/spectrum","owner":{"login":"bgrins","id":95570,"avatar_url":"https://avatars.githubusercontent.com/u/95570?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrins","html_url":"https://github.com/bgrins","followers_url":"https://api.github.com/users/bgrins/followers","following_url":"https://api.github.com/users/bgrins/following{/other_user}","gists_url":"https://api.github.com/users/bgrins/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrins/subscriptions","organizations_url":"https://api.github.com/users/bgrins/orgs","repos_url":"https://api.github.com/users/bgrins/repos","events_url":"https://api.github.com/users/bgrins/events{/privacy}","received_events_url":"https://api.github.com/users/bgrins/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bgrins/spectrum","description":"The No Hassle JavaScript Colorpicker","fork":false,"url":"https://api.github.com/repos/bgrins/spectrum","forks_url":"https://api.github.com/repos/bgrins/spectrum/forks","keys_url":"https://api.github.com/repos/bgrins/spectrum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bgrins/spectrum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bgrins/spectrum/teams","hooks_url":"https://api.github.com/repos/bgrins/spectrum/hooks","issue_events_url":"https://api.github.com/repos/bgrins/spectrum/issues/events{/number}","events_url":"https://api.github.com/repos/bgrins/spectrum/events","assignees_url":"https://api.github.com/repos/bgrins/spectrum/assignees{/user}","branches_url":"https://api.github.com/repos/bgrins/spectrum/branches{/branch}","tags_url":"https://api.github.com/repos/bgrins/spectrum/tags","blobs_url":"https://api.github.com/repos/bgrins/spectrum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bgrins/spectrum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bgrins/spectrum/git/refs{/sha}","trees_url":"https://api.github.com/repos/bgrins/spectrum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bgrins/spectrum/statuses/{sha}","languages_url":"https://api.github.com/repos/bgrins/spectrum/languages","stargazers_url":"https://api.github.com/repos/bgrins/spectrum/stargazers","contributors_url":"https://api.github.com/repos/bgrins/spectrum/contributors","subscribers_url":"https://api.github.com/repos/bgrins/spectrum/subscribers","subscription_url":"https://api.github.com/repos/bgrins/spectrum/subscription","commits_url":"https://api.github.com/repos/bgrins/spectrum/commits{/sha}","git_commits_url":"https://api.github.com/repos/bgrins/spectrum/git/commits{/sha}","comments_url":"https://api.github.com/repos/bgrins/spectrum/comments{/number}","issue_comment_url":"https://api.github.com/repos/bgrins/spectrum/issues/comments{/number}","contents_url":"https://api.github.com/repos/bgrins/spectrum/contents/{+path}","compare_url":"https://api.github.com/repos/bgrins/spectrum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bgrins/spectrum/merges","archive_url":"https://api.github.com/repos/bgrins/spectrum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bgrins/spectrum/downloads","issues_url":"https://api.github.com/repos/bgrins/spectrum/issues{/number}","pulls_url":"https://api.github.com/repos/bgrins/spectrum/pulls{/number}","milestones_url":"https://api.github.com/repos/bgrins/spectrum/milestones{/number}","notifications_url":"https://api.github.com/repos/bgrins/spectrum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bgrins/spectrum/labels{/name}","releases_url":"https://api.github.com/repos/bgrins/spectrum/releases{/id}","deployments_url":"https://api.github.com/repos/bgrins/spectrum/deployments","created_at":"2011-07-23T20:39:28Z","updated_at":"2016-02-07T16:06:01Z","pushed_at":"2016-02-09T15:32:48Z","git_url":"git://github.com/bgrins/spectrum.git","ssh_url":"git@github.com:bgrins/spectrum.git","clone_url":"https://github.com/bgrins/spectrum.git","svn_url":"https://github.com/bgrins/spectrum","homepage":"http://bgrins.github.io/spectrum/","size":3233,"stargazers_count":1191,"watchers_count":1191,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":305,"mirror_url":null,"open_issues_count":111,"forks":305,"open_issues":111,"watchers":1191,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bgrins/spectrum/pulls/392"},"html":{"href":"https://github.com/bgrins/spectrum/pull/392"},"issue":{"href":"https://api.github.com/repos/bgrins/spectrum/issues/392"},"comments":{"href":"https://api.github.com/repos/bgrins/spectrum/issues/392/comments"},"review_comments":{"href":"https://api.github.com/repos/bgrins/spectrum/pulls/392/comments"},"review_comment":{"href":"https://api.github.com/repos/bgrins/spectrum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bgrins/spectrum/pulls/392/commits"},"statuses":{"href":"https://api.github.com/repos/bgrins/spectrum/statuses/518f8f5e1fc5dd36135d1ce6a556290287e07b75"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":0,"deletions":2,"changed_files":1}}