{"action":"created","comment":{"url":"https://api.github.com/repos/imzhenyu/rDSN/pulls/comments/69674337","id":69674337,"diff_hunk":"@@ -94,9 +94,9 @@ namespace dsn\n         void partition_resolver_simple::on_access_failure(int partition_index, error_code err)\n         {\n             if (-1 != partition_index\n-                && err != ERR_CAPACITY_EXCEEDED\n-                && err != ERR_NOT_ENOUGH_MEMBER\n-                && err != ERR_INVALID_DATA)\n+                && err != ERR_CAPACITY_EXCEEDED // no need for reconfiguration on primary\n+                && err != ERR_NOT_ENOUGH_MEMBER // primary won't change and we only r/w on primary in this provider","path":"src/dist/common_providers/partition_resolver_simple.cpp","position":8,"original_position":8,"commit_id":"c85d1e9bf4449832f615d842d86a7811c5493c09","original_commit_id":"c85d1e9bf4449832f615d842d86a7811c5493c09","user":{"login":"imzhenyu","id":6927143,"avatar_url":"https://avatars.githubusercontent.com/u/6927143?v=3","gravatar_id":"","url":"https://api.github.com/users/imzhenyu","html_url":"https://github.com/imzhenyu","followers_url":"https://api.github.com/users/imzhenyu/followers","following_url":"https://api.github.com/users/imzhenyu/following{/other_user}","gists_url":"https://api.github.com/users/imzhenyu/gists{/gist_id}","starred_url":"https://api.github.com/users/imzhenyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imzhenyu/subscriptions","organizations_url":"https://api.github.com/users/imzhenyu/orgs","repos_url":"https://api.github.com/users/imzhenyu/repos","events_url":"https://api.github.com/users/imzhenyu/events{/privacy}","received_events_url":"https://api.github.com/users/imzhenyu/received_events","type":"User","site_admin":false},"body":"If there is an INVALID_DATA error, the local replica should be turned into PS_ERROR state, therefore we have to clear the partition cache and get the new ones. ","created_at":"2016-07-06T04:33:21Z","updated_at":"2016-07-06T04:33:21Z","html_url":"https://github.com/imzhenyu/rDSN/pull/439#discussion_r69674337","pull_request_url":"https://api.github.com/repos/imzhenyu/rDSN/pulls/439","_links":{"self":{"href":"https://api.github.com/repos/imzhenyu/rDSN/pulls/comments/69674337"},"html":{"href":"https://github.com/imzhenyu/rDSN/pull/439#discussion_r69674337"},"pull_request":{"href":"https://api.github.com/repos/imzhenyu/rDSN/pulls/439"}}},"pull_request":{"url":"https://api.github.com/repos/imzhenyu/rDSN/pulls/439","id":76248200,"html_url":"https://github.com/imzhenyu/rDSN/pull/439","diff_url":"https://github.com/imzhenyu/rDSN/pull/439.diff","patch_url":"https://github.com/imzhenyu/rDSN/pull/439.patch","issue_url":"https://api.github.com/repos/imzhenyu/rDSN/issues/439","number":439,"state":"open","locked":false,"title":"fix layer2 rpc call retry ","user":{"login":"imzhenyu","id":6927143,"avatar_url":"https://avatars.githubusercontent.com/u/6927143?v=3","gravatar_id":"","url":"https://api.github.com/users/imzhenyu","html_url":"https://github.com/imzhenyu","followers_url":"https://api.github.com/users/imzhenyu/followers","following_url":"https://api.github.com/users/imzhenyu/following{/other_user}","gists_url":"https://api.github.com/users/imzhenyu/gists{/gist_id}","starred_url":"https://api.github.com/users/imzhenyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imzhenyu/subscriptions","organizations_url":"https://api.github.com/users/imzhenyu/orgs","repos_url":"https://api.github.com/users/imzhenyu/repos","events_url":"https://api.github.com/users/imzhenyu/events{/privacy}","received_events_url":"https://api.github.com/users/imzhenyu/received_events","type":"User","site_admin":false},"body":"When applications use sync calls for layer 2 rpc calls, the underlying retry becomes useless as the applications always get error code from the initial call. This commit fixes this issues by allowing reusing the same task with additional set_retry method. This is a continue thread for #438 ","created_at":"2016-07-05T10:07:32Z","updated_at":"2016-07-06T04:33:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd7a556a272149b07be7f5ab4b5ba58e89c34220","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/imzhenyu/rDSN/pulls/439/commits","review_comments_url":"https://api.github.com/repos/imzhenyu/rDSN/pulls/439/comments","review_comment_url":"https://api.github.com/repos/imzhenyu/rDSN/pulls/comments{/number}","comments_url":"https://api.github.com/repos/imzhenyu/rDSN/issues/439/comments","statuses_url":"https://api.github.com/repos/imzhenyu/rDSN/statuses/c85d1e9bf4449832f615d842d86a7811c5493c09","head":{"label":"imzhenyu:imzhenyu","ref":"imzhenyu","sha":"c85d1e9bf4449832f615d842d86a7811c5493c09","user":{"login":"imzhenyu","id":6927143,"avatar_url":"https://avatars.githubusercontent.com/u/6927143?v=3","gravatar_id":"","url":"https://api.github.com/users/imzhenyu","html_url":"https://github.com/imzhenyu","followers_url":"https://api.github.com/users/imzhenyu/followers","following_url":"https://api.github.com/users/imzhenyu/following{/other_user}","gists_url":"https://api.github.com/users/imzhenyu/gists{/gist_id}","starred_url":"https://api.github.com/users/imzhenyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imzhenyu/subscriptions","organizations_url":"https://api.github.com/users/imzhenyu/orgs","repos_url":"https://api.github.com/users/imzhenyu/repos","events_url":"https://api.github.com/users/imzhenyu/events{/privacy}","received_events_url":"https://api.github.com/users/imzhenyu/received_events","type":"User","site_admin":false},"repo":{"id":37038578,"name":"rDSN","full_name":"imzhenyu/rDSN","owner":{"login":"imzhenyu","id":6927143,"avatar_url":"https://avatars.githubusercontent.com/u/6927143?v=3","gravatar_id":"","url":"https://api.github.com/users/imzhenyu","html_url":"https://github.com/imzhenyu","followers_url":"https://api.github.com/users/imzhenyu/followers","following_url":"https://api.github.com/users/imzhenyu/following{/other_user}","gists_url":"https://api.github.com/users/imzhenyu/gists{/gist_id}","starred_url":"https://api.github.com/users/imzhenyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imzhenyu/subscriptions","organizations_url":"https://api.github.com/users/imzhenyu/orgs","repos_url":"https://api.github.com/users/imzhenyu/repos","events_url":"https://api.github.com/users/imzhenyu/events{/privacy}","received_events_url":"https://api.github.com/users/imzhenyu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/imzhenyu/rDSN","description":"Robust Distributed System Nucleus (rDSN) is an open framework for quickly building and managing high performance and robust distributed systems.","fork":true,"url":"https://api.github.com/repos/imzhenyu/rDSN","forks_url":"https://api.github.com/repos/imzhenyu/rDSN/forks","keys_url":"https://api.github.com/repos/imzhenyu/rDSN/keys{/key_id}","collaborators_url":"https://api.github.com/repos/imzhenyu/rDSN/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/imzhenyu/rDSN/teams","hooks_url":"https://api.github.com/repos/imzhenyu/rDSN/hooks","issue_events_url":"https://api.github.com/repos/imzhenyu/rDSN/issues/events{/number}","events_url":"https://api.github.com/repos/imzhenyu/rDSN/events","assignees_url":"https://api.github.com/repos/imzhenyu/rDSN/assignees{/user}","branches_url":"https://api.github.com/repos/imzhenyu/rDSN/branches{/branch}","tags_url":"https://api.github.com/repos/imzhenyu/rDSN/tags","blobs_url":"https://api.github.com/repos/imzhenyu/rDSN/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/imzhenyu/rDSN/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/imzhenyu/rDSN/git/refs{/sha}","trees_url":"https://api.github.com/repos/imzhenyu/rDSN/git/trees{/sha}","statuses_url":"https://api.github.com/repos/imzhenyu/rDSN/statuses/{sha}","languages_url":"https://api.github.com/repos/imzhenyu/rDSN/languages","stargazers_url":"https://api.github.com/repos/imzhenyu/rDSN/stargazers","contributors_url":"https://api.github.com/repos/imzhenyu/rDSN/contributors","subscribers_url":"https://api.github.com/repos/imzhenyu/rDSN/subscribers","subscription_url":"https://api.github.com/repos/imzhenyu/rDSN/subscription","commits_url":"https://api.github.com/repos/imzhenyu/rDSN/commits{/sha}","git_commits_url":"https://api.github.com/repos/imzhenyu/rDSN/git/commits{/sha}","comments_url":"https://api.github.com/repos/imzhenyu/rDSN/comments{/number}","issue_comment_url":"https://api.github.com/repos/imzhenyu/rDSN/issues/comments{/number}","contents_url":"https://api.github.com/repos/imzhenyu/rDSN/contents/{+path}","compare_url":"https://api.github.com/repos/imzhenyu/rDSN/compare/{base}...{head}","merges_url":"https://api.github.com/repos/imzhenyu/rDSN/merges","archive_url":"https://api.github.com/repos/imzhenyu/rDSN/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/imzhenyu/rDSN/downloads","issues_url":"https://api.github.com/repos/imzhenyu/rDSN/issues{/number}","pulls_url":"https://api.github.com/repos/imzhenyu/rDSN/pulls{/number}","milestones_url":"https://api.github.com/repos/imzhenyu/rDSN/milestones{/number}","notifications_url":"https://api.github.com/repos/imzhenyu/rDSN/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/imzhenyu/rDSN/labels{/name}","releases_url":"https://api.github.com/repos/imzhenyu/rDSN/releases{/id}","deployments_url":"https://api.github.com/repos/imzhenyu/rDSN/deployments","created_at":"2015-06-08T00:54:11Z","updated_at":"2016-05-31T09:59:35Z","pushed_at":"2016-07-06T02:58:04Z","git_url":"git://github.com/imzhenyu/rDSN.git","ssh_url":"git@github.com:imzhenyu/rDSN.git","clone_url":"https://github.com/imzhenyu/rDSN.git","svn_url":"https://github.com/imzhenyu/rDSN","homepage":null,"size":78420,"stargazers_count":14,"watchers_count":14,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"open_issues_count":29,"forks":10,"open_issues":29,"watchers":14,"default_branch":"master"}},"base":{"label":"imzhenyu:master","ref":"master","sha":"e8825ffa54ed84b99961171ea22ff70a86f6c411","user":{"login":"imzhenyu","id":6927143,"avatar_url":"https://avatars.githubusercontent.com/u/6927143?v=3","gravatar_id":"","url":"https://api.github.com/users/imzhenyu","html_url":"https://github.com/imzhenyu","followers_url":"https://api.github.com/users/imzhenyu/followers","following_url":"https://api.github.com/users/imzhenyu/following{/other_user}","gists_url":"https://api.github.com/users/imzhenyu/gists{/gist_id}","starred_url":"https://api.github.com/users/imzhenyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imzhenyu/subscriptions","organizations_url":"https://api.github.com/users/imzhenyu/orgs","repos_url":"https://api.github.com/users/imzhenyu/repos","events_url":"https://api.github.com/users/imzhenyu/events{/privacy}","received_events_url":"https://api.github.com/users/imzhenyu/received_events","type":"User","site_admin":false},"repo":{"id":37038578,"name":"rDSN","full_name":"imzhenyu/rDSN","owner":{"login":"imzhenyu","id":6927143,"avatar_url":"https://avatars.githubusercontent.com/u/6927143?v=3","gravatar_id":"","url":"https://api.github.com/users/imzhenyu","html_url":"https://github.com/imzhenyu","followers_url":"https://api.github.com/users/imzhenyu/followers","following_url":"https://api.github.com/users/imzhenyu/following{/other_user}","gists_url":"https://api.github.com/users/imzhenyu/gists{/gist_id}","starred_url":"https://api.github.com/users/imzhenyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imzhenyu/subscriptions","organizations_url":"https://api.github.com/users/imzhenyu/orgs","repos_url":"https://api.github.com/users/imzhenyu/repos","events_url":"https://api.github.com/users/imzhenyu/events{/privacy}","received_events_url":"https://api.github.com/users/imzhenyu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/imzhenyu/rDSN","description":"Robust Distributed System Nucleus (rDSN) is an open framework for quickly building and managing high performance and robust distributed systems.","fork":true,"url":"https://api.github.com/repos/imzhenyu/rDSN","forks_url":"https://api.github.com/repos/imzhenyu/rDSN/forks","keys_url":"https://api.github.com/repos/imzhenyu/rDSN/keys{/key_id}","collaborators_url":"https://api.github.com/repos/imzhenyu/rDSN/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/imzhenyu/rDSN/teams","hooks_url":"https://api.github.com/repos/imzhenyu/rDSN/hooks","issue_events_url":"https://api.github.com/repos/imzhenyu/rDSN/issues/events{/number}","events_url":"https://api.github.com/repos/imzhenyu/rDSN/events","assignees_url":"https://api.github.com/repos/imzhenyu/rDSN/assignees{/user}","branches_url":"https://api.github.com/repos/imzhenyu/rDSN/branches{/branch}","tags_url":"https://api.github.com/repos/imzhenyu/rDSN/tags","blobs_url":"https://api.github.com/repos/imzhenyu/rDSN/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/imzhenyu/rDSN/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/imzhenyu/rDSN/git/refs{/sha}","trees_url":"https://api.github.com/repos/imzhenyu/rDSN/git/trees{/sha}","statuses_url":"https://api.github.com/repos/imzhenyu/rDSN/statuses/{sha}","languages_url":"https://api.github.com/repos/imzhenyu/rDSN/languages","stargazers_url":"https://api.github.com/repos/imzhenyu/rDSN/stargazers","contributors_url":"https://api.github.com/repos/imzhenyu/rDSN/contributors","subscribers_url":"https://api.github.com/repos/imzhenyu/rDSN/subscribers","subscription_url":"https://api.github.com/repos/imzhenyu/rDSN/subscription","commits_url":"https://api.github.com/repos/imzhenyu/rDSN/commits{/sha}","git_commits_url":"https://api.github.com/repos/imzhenyu/rDSN/git/commits{/sha}","comments_url":"https://api.github.com/repos/imzhenyu/rDSN/comments{/number}","issue_comment_url":"https://api.github.com/repos/imzhenyu/rDSN/issues/comments{/number}","contents_url":"https://api.github.com/repos/imzhenyu/rDSN/contents/{+path}","compare_url":"https://api.github.com/repos/imzhenyu/rDSN/compare/{base}...{head}","merges_url":"https://api.github.com/repos/imzhenyu/rDSN/merges","archive_url":"https://api.github.com/repos/imzhenyu/rDSN/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/imzhenyu/rDSN/downloads","issues_url":"https://api.github.com/repos/imzhenyu/rDSN/issues{/number}","pulls_url":"https://api.github.com/repos/imzhenyu/rDSN/pulls{/number}","milestones_url":"https://api.github.com/repos/imzhenyu/rDSN/milestones{/number}","notifications_url":"https://api.github.com/repos/imzhenyu/rDSN/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/imzhenyu/rDSN/labels{/name}","releases_url":"https://api.github.com/repos/imzhenyu/rDSN/releases{/id}","deployments_url":"https://api.github.com/repos/imzhenyu/rDSN/deployments","created_at":"2015-06-08T00:54:11Z","updated_at":"2016-05-31T09:59:35Z","pushed_at":"2016-07-06T02:58:04Z","git_url":"git://github.com/imzhenyu/rDSN.git","ssh_url":"git@github.com:imzhenyu/rDSN.git","clone_url":"https://github.com/imzhenyu/rDSN.git","svn_url":"https://github.com/imzhenyu/rDSN","homepage":null,"size":78420,"stargazers_count":14,"watchers_count":14,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"open_issues_count":29,"forks":10,"open_issues":29,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/imzhenyu/rDSN/pulls/439"},"html":{"href":"https://github.com/imzhenyu/rDSN/pull/439"},"issue":{"href":"https://api.github.com/repos/imzhenyu/rDSN/issues/439"},"comments":{"href":"https://api.github.com/repos/imzhenyu/rDSN/issues/439/comments"},"review_comments":{"href":"https://api.github.com/repos/imzhenyu/rDSN/pulls/439/comments"},"review_comment":{"href":"https://api.github.com/repos/imzhenyu/rDSN/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/imzhenyu/rDSN/pulls/439/commits"},"statuses":{"href":"https://api.github.com/repos/imzhenyu/rDSN/statuses/c85d1e9bf4449832f615d842d86a7811c5493c09"}}}}
{"actor":{"display_login":"imzhenyu"}}