{"action":"opened","number":1056,"pull_request":{"url":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/1056","id":69407197,"html_url":"https://github.com/BloomBooks/BloomDesktop/pull/1056","diff_url":"https://github.com/BloomBooks/BloomDesktop/pull/1056.diff","patch_url":"https://github.com/BloomBooks/BloomDesktop/pull/1056.patch","issue_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/1056","number":1056,"state":"open","locked":false,"title":"BL-2324 BookSettings sensitive to if in shellbook or not","user":{"login":"hatton","id":8448,"avatar_url":"https://avatars.githubusercontent.com/u/8448?v=3","gravatar_id":"","url":"https://api.github.com/users/hatton","html_url":"https://github.com/hatton","followers_url":"https://api.github.com/users/hatton/followers","following_url":"https://api.github.com/users/hatton/following{/other_user}","gists_url":"https://api.github.com/users/hatton/gists{/gist_id}","starred_url":"https://api.github.com/users/hatton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hatton/subscriptions","organizations_url":"https://api.github.com/users/hatton/orgs","repos_url":"https://api.github.com/users/hatton/repos","events_url":"https://api.github.com/users/hatton/events{/privacy}","received_events_url":"https://api.github.com/users/hatton/received_events","type":"User","site_admin":false},"body":"Although the intended improvement here was just a few lines, I found several things that offered themselves for clean up. Somewhat after-the-fact, I split these into separate commits in case that helps with review.\n\nThe biggest thing was removing the dependency of various things on the CurrentBookHandler, which wanted to become a nice independent api controller.\n\nIn doing this, I broke the ReadersApi, which was a bunch of statics. That is now, also a normal class that is created by the Project Context and given its dependencies.","created_at":"2016-05-09T20:41:47Z","updated_at":"2016-05-09T20:41:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d50863d6c48dfd9efe99d1746e843c6b12fcfc1c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/1056/commits","review_comments_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/1056/comments","review_comment_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/1056/comments","statuses_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/statuses/5ffc52d532e2da497dd604d420d6e4ebd020cbbc","head":{"label":"hatton:BookSettingsContinued","ref":"BookSettingsContinued","sha":"5ffc52d532e2da497dd604d420d6e4ebd020cbbc","user":{"login":"hatton","id":8448,"avatar_url":"https://avatars.githubusercontent.com/u/8448?v=3","gravatar_id":"","url":"https://api.github.com/users/hatton","html_url":"https://github.com/hatton","followers_url":"https://api.github.com/users/hatton/followers","following_url":"https://api.github.com/users/hatton/following{/other_user}","gists_url":"https://api.github.com/users/hatton/gists{/gist_id}","starred_url":"https://api.github.com/users/hatton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hatton/subscriptions","organizations_url":"https://api.github.com/users/hatton/orgs","repos_url":"https://api.github.com/users/hatton/repos","events_url":"https://api.github.com/users/hatton/events{/privacy}","received_events_url":"https://api.github.com/users/hatton/received_events","type":"User","site_admin":false},"repo":{"id":33460049,"name":"BloomDesktop","full_name":"hatton/BloomDesktop","owner":{"login":"hatton","id":8448,"avatar_url":"https://avatars.githubusercontent.com/u/8448?v=3","gravatar_id":"","url":"https://api.github.com/users/hatton","html_url":"https://github.com/hatton","followers_url":"https://api.github.com/users/hatton/followers","following_url":"https://api.github.com/users/hatton/following{/other_user}","gists_url":"https://api.github.com/users/hatton/gists{/gist_id}","starred_url":"https://api.github.com/users/hatton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hatton/subscriptions","organizations_url":"https://api.github.com/users/hatton/orgs","repos_url":"https://api.github.com/users/hatton/repos","events_url":"https://api.github.com/users/hatton/events{/privacy}","received_events_url":"https://api.github.com/users/hatton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hatton/BloomDesktop","description":"Bloom Desktop is a hybrid c#/javascript/html/css Windows application that dramatically \"lowers the bar\" for language communities who want books in their own languages. Bloom delivers a low-training, high-output system where mother tongue speakers and their advocates work together to foster both community authorship and access to external material in the vernacular.","fork":true,"url":"https://api.github.com/repos/hatton/BloomDesktop","forks_url":"https://api.github.com/repos/hatton/BloomDesktop/forks","keys_url":"https://api.github.com/repos/hatton/BloomDesktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hatton/BloomDesktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hatton/BloomDesktop/teams","hooks_url":"https://api.github.com/repos/hatton/BloomDesktop/hooks","issue_events_url":"https://api.github.com/repos/hatton/BloomDesktop/issues/events{/number}","events_url":"https://api.github.com/repos/hatton/BloomDesktop/events","assignees_url":"https://api.github.com/repos/hatton/BloomDesktop/assignees{/user}","branches_url":"https://api.github.com/repos/hatton/BloomDesktop/branches{/branch}","tags_url":"https://api.github.com/repos/hatton/BloomDesktop/tags","blobs_url":"https://api.github.com/repos/hatton/BloomDesktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hatton/BloomDesktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hatton/BloomDesktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/hatton/BloomDesktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hatton/BloomDesktop/statuses/{sha}","languages_url":"https://api.github.com/repos/hatton/BloomDesktop/languages","stargazers_url":"https://api.github.com/repos/hatton/BloomDesktop/stargazers","contributors_url":"https://api.github.com/repos/hatton/BloomDesktop/contributors","subscribers_url":"https://api.github.com/repos/hatton/BloomDesktop/subscribers","subscription_url":"https://api.github.com/repos/hatton/BloomDesktop/subscription","commits_url":"https://api.github.com/repos/hatton/BloomDesktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/hatton/BloomDesktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/hatton/BloomDesktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/hatton/BloomDesktop/issues/comments{/number}","contents_url":"https://api.github.com/repos/hatton/BloomDesktop/contents/{+path}","compare_url":"https://api.github.com/repos/hatton/BloomDesktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hatton/BloomDesktop/merges","archive_url":"https://api.github.com/repos/hatton/BloomDesktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hatton/BloomDesktop/downloads","issues_url":"https://api.github.com/repos/hatton/BloomDesktop/issues{/number}","pulls_url":"https://api.github.com/repos/hatton/BloomDesktop/pulls{/number}","milestones_url":"https://api.github.com/repos/hatton/BloomDesktop/milestones{/number}","notifications_url":"https://api.github.com/repos/hatton/BloomDesktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hatton/BloomDesktop/labels{/name}","releases_url":"https://api.github.com/repos/hatton/BloomDesktop/releases{/id}","deployments_url":"https://api.github.com/repos/hatton/BloomDesktop/deployments","created_at":"2015-04-06T00:29:28Z","updated_at":"2016-01-12T22:49:53Z","pushed_at":"2016-05-09T20:38:14Z","git_url":"git://github.com/hatton/BloomDesktop.git","ssh_url":"git@github.com:hatton/BloomDesktop.git","clone_url":"https://github.com/hatton/BloomDesktop.git","svn_url":"https://github.com/hatton/BloomDesktop","homepage":"http://bloomlibrary.org/","size":80144,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BloomBooks:master","ref":"master","sha":"4322129457ad2c88d1149186cc55d2536b8a8295","user":{"login":"BloomBooks","id":5853716,"avatar_url":"https://avatars.githubusercontent.com/u/5853716?v=3","gravatar_id":"","url":"https://api.github.com/users/BloomBooks","html_url":"https://github.com/BloomBooks","followers_url":"https://api.github.com/users/BloomBooks/followers","following_url":"https://api.github.com/users/BloomBooks/following{/other_user}","gists_url":"https://api.github.com/users/BloomBooks/gists{/gist_id}","starred_url":"https://api.github.com/users/BloomBooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BloomBooks/subscriptions","organizations_url":"https://api.github.com/users/BloomBooks/orgs","repos_url":"https://api.github.com/users/BloomBooks/repos","events_url":"https://api.github.com/users/BloomBooks/events{/privacy}","received_events_url":"https://api.github.com/users/BloomBooks/received_events","type":"Organization","site_admin":false},"repo":{"id":14133680,"name":"BloomDesktop","full_name":"BloomBooks/BloomDesktop","owner":{"login":"BloomBooks","id":5853716,"avatar_url":"https://avatars.githubusercontent.com/u/5853716?v=3","gravatar_id":"","url":"https://api.github.com/users/BloomBooks","html_url":"https://github.com/BloomBooks","followers_url":"https://api.github.com/users/BloomBooks/followers","following_url":"https://api.github.com/users/BloomBooks/following{/other_user}","gists_url":"https://api.github.com/users/BloomBooks/gists{/gist_id}","starred_url":"https://api.github.com/users/BloomBooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BloomBooks/subscriptions","organizations_url":"https://api.github.com/users/BloomBooks/orgs","repos_url":"https://api.github.com/users/BloomBooks/repos","events_url":"https://api.github.com/users/BloomBooks/events{/privacy}","received_events_url":"https://api.github.com/users/BloomBooks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BloomBooks/BloomDesktop","description":"Let's Grow a Library","fork":false,"url":"https://api.github.com/repos/BloomBooks/BloomDesktop","forks_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/forks","keys_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/teams","hooks_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/hooks","issue_events_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/events{/number}","events_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/events","assignees_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/assignees{/user}","branches_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/branches{/branch}","tags_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/tags","blobs_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/statuses/{sha}","languages_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/languages","stargazers_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/stargazers","contributors_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/contributors","subscribers_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/subscribers","subscription_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/subscription","commits_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/comments{/number}","contents_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/contents/{+path}","compare_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/merges","archive_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/downloads","issues_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues{/number}","pulls_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls{/number}","milestones_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/milestones{/number}","notifications_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/labels{/name}","releases_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/releases{/id}","deployments_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/deployments","created_at":"2013-11-05T06:12:57Z","updated_at":"2016-04-29T11:30:56Z","pushed_at":"2016-05-09T20:41:47Z","git_url":"git://github.com/BloomBooks/BloomDesktop.git","ssh_url":"git@github.com:BloomBooks/BloomDesktop.git","clone_url":"https://github.com/BloomBooks/BloomDesktop.git","svn_url":"https://github.com/BloomBooks/BloomDesktop","homepage":"http://bloomlibrary.org/","size":87600,"stargazers_count":11,"watchers_count":11,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":6,"forks":12,"open_issues":6,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/1056"},"html":{"href":"https://github.com/BloomBooks/BloomDesktop/pull/1056"},"issue":{"href":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/1056"},"comments":{"href":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/1056/comments"},"review_comments":{"href":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/1056/comments"},"review_comment":{"href":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/1056/commits"},"statuses":{"href":"https://api.github.com/repos/BloomBooks/BloomDesktop/statuses/5ffc52d532e2da497dd604d420d6e4ebd020cbbc"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":4,"additions":110,"deletions":103,"changed_files":13}}