{"action":"created","comment":{"url":"https://api.github.com/repos/gemini-hlsw/ocs3/pulls/comments/83903884","pull_request_review_id":4716468,"id":83903884,"diff_hunk":"@@ -21,13 +21,40 @@ object SeqexecEngine {\n \n   sealed trait SeqexecEvent\n   object SeqexecEvent {\n-    case class SequenceStart(view: SequenceView) extends SeqexecEvent\n-    case class StepExecuted(view: SequenceView) extends SeqexecEvent\n-    case class SequenceCompleted(view: SequenceView) extends SeqexecEvent\n-    case class StepBreakpointChanged(view: SequenceView) extends SeqexecEvent\n-    case class StepSkipMarkChanged(view: SequenceView) extends SeqexecEvent\n-    case class SequencePauseRequested(view: SequenceView) extends SeqexecEvent\n-    case class NewLogMessage(msg: LogMsg) extends SeqexecEvent\n+\n+    import edu.gemini.seqexec.engine\n+    import edu.gemini.seqexec.engine.Event\n+\n+    case class SequenceStart(view: List[SequenceView]) extends SeqexecEvent","path":"modules/edu.gemini.seqexec.server/src/main/scala/edu/gemini/seqexec/server/SeqexecEngine.scala","position":15,"original_position":15,"commit_id":"78a4aa833783740c738bfc2181ea9b2b477fda60","original_commit_id":"78a4aa833783740c738bfc2181ea9b2b477fda60","user":{"login":"jdnavarro","id":215438,"avatar_url":"https://avatars.githubusercontent.com/u/215438?v=3","gravatar_id":"","url":"https://api.github.com/users/jdnavarro","html_url":"https://github.com/jdnavarro","followers_url":"https://api.github.com/users/jdnavarro/followers","following_url":"https://api.github.com/users/jdnavarro/following{/other_user}","gists_url":"https://api.github.com/users/jdnavarro/gists{/gist_id}","starred_url":"https://api.github.com/users/jdnavarro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdnavarro/subscriptions","organizations_url":"https://api.github.com/users/jdnavarro/orgs","repos_url":"https://api.github.com/users/jdnavarro/repos","events_url":"https://api.github.com/users/jdnavarro/events{/privacy}","received_events_url":"https://api.github.com/users/jdnavarro/received_events","type":"User","site_admin":false},"body":"This is *very* provisional. The idea here is to have something that can be used directly on the client as it is, so that we can show a quick demo. Isn't a `List[SequenceView]` what the client expects as state from the server?\r\n\r\nThe equivalent to `List[SequenceView]` has a distinct type named just `Queue`. But I was thinking that we could take care of this in the next iteration after watching the demo.","created_at":"2016-10-18T17:12:32Z","updated_at":"2016-10-18T17:12:32Z","html_url":"https://github.com/gemini-hlsw/ocs3/pull/100#discussion_r83903884","pull_request_url":"https://api.github.com/repos/gemini-hlsw/ocs3/pulls/100","_links":{"self":{"href":"https://api.github.com/repos/gemini-hlsw/ocs3/pulls/comments/83903884"},"html":{"href":"https://github.com/gemini-hlsw/ocs3/pull/100#discussion_r83903884"},"pull_request":{"href":"https://api.github.com/repos/gemini-hlsw/ocs3/pulls/100"}}},"pull_request":{"url":"https://api.github.com/repos/gemini-hlsw/ocs3/pulls/100","id":89843932,"html_url":"https://github.com/gemini-hlsw/ocs3/pull/100","diff_url":"https://github.com/gemini-hlsw/ocs3/pull/100.diff","patch_url":"https://github.com/gemini-hlsw/ocs3/pull/100.patch","issue_url":"https://api.github.com/repos/gemini-hlsw/ocs3/issues/100","number":100,"state":"open","locked":false,"title":"SEGNG-34 Attach the event with each generated Engine state output","user":{"login":"jdnavarro","id":215438,"avatar_url":"https://avatars.githubusercontent.com/u/215438?v=3","gravatar_id":"","url":"https://api.github.com/users/jdnavarro","html_url":"https://github.com/jdnavarro","followers_url":"https://api.github.com/users/jdnavarro/followers","following_url":"https://api.github.com/users/jdnavarro/following{/other_user}","gists_url":"https://api.github.com/users/jdnavarro/gists{/gist_id}","starred_url":"https://api.github.com/users/jdnavarro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdnavarro/subscriptions","organizations_url":"https://api.github.com/users/jdnavarro/orgs","repos_url":"https://api.github.com/users/jdnavarro/repos","events_url":"https://api.github.com/users/jdnavarro/events{/privacy}","received_events_url":"https://api.github.com/users/jdnavarro/received_events","type":"User","site_admin":false},"body":"With these changes there is now a Process of `SeqexecEvent`s that in theory could be used directly by the client to display the state of execution.","created_at":"2016-10-18T15:46:58Z","updated_at":"2016-10-18T17:12:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"98a5a93d2fae19be8eb2cbc8b90552af60c5317f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/gemini-hlsw/ocs3/pulls/100/commits","review_comments_url":"https://api.github.com/repos/gemini-hlsw/ocs3/pulls/100/comments","review_comment_url":"https://api.github.com/repos/gemini-hlsw/ocs3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gemini-hlsw/ocs3/issues/100/comments","statuses_url":"https://api.github.com/repos/gemini-hlsw/ocs3/statuses/78a4aa833783740c738bfc2181ea9b2b477fda60","head":{"label":"jdnavarro:feature/SEQNG-34","ref":"feature/SEQNG-34","sha":"78a4aa833783740c738bfc2181ea9b2b477fda60","user":{"login":"jdnavarro","id":215438,"avatar_url":"https://avatars.githubusercontent.com/u/215438?v=3","gravatar_id":"","url":"https://api.github.com/users/jdnavarro","html_url":"https://github.com/jdnavarro","followers_url":"https://api.github.com/users/jdnavarro/followers","following_url":"https://api.github.com/users/jdnavarro/following{/other_user}","gists_url":"https://api.github.com/users/jdnavarro/gists{/gist_id}","starred_url":"https://api.github.com/users/jdnavarro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdnavarro/subscriptions","organizations_url":"https://api.github.com/users/jdnavarro/orgs","repos_url":"https://api.github.com/users/jdnavarro/repos","events_url":"https://api.github.com/users/jdnavarro/events{/privacy}","received_events_url":"https://api.github.com/users/jdnavarro/received_events","type":"User","site_admin":false},"repo":{"id":62576774,"name":"ocs3","full_name":"jdnavarro/ocs3","owner":{"login":"jdnavarro","id":215438,"avatar_url":"https://avatars.githubusercontent.com/u/215438?v=3","gravatar_id":"","url":"https://api.github.com/users/jdnavarro","html_url":"https://github.com/jdnavarro","followers_url":"https://api.github.com/users/jdnavarro/followers","following_url":"https://api.github.com/users/jdnavarro/following{/other_user}","gists_url":"https://api.github.com/users/jdnavarro/gists{/gist_id}","starred_url":"https://api.github.com/users/jdnavarro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdnavarro/subscriptions","organizations_url":"https://api.github.com/users/jdnavarro/orgs","repos_url":"https://api.github.com/users/jdnavarro/repos","events_url":"https://api.github.com/users/jdnavarro/events{/privacy}","received_events_url":"https://api.github.com/users/jdnavarro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jdnavarro/ocs3","description":"Observatory Control Software - New Generation","fork":true,"url":"https://api.github.com/repos/jdnavarro/ocs3","forks_url":"https://api.github.com/repos/jdnavarro/ocs3/forks","keys_url":"https://api.github.com/repos/jdnavarro/ocs3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdnavarro/ocs3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdnavarro/ocs3/teams","hooks_url":"https://api.github.com/repos/jdnavarro/ocs3/hooks","issue_events_url":"https://api.github.com/repos/jdnavarro/ocs3/issues/events{/number}","events_url":"https://api.github.com/repos/jdnavarro/ocs3/events","assignees_url":"https://api.github.com/repos/jdnavarro/ocs3/assignees{/user}","branches_url":"https://api.github.com/repos/jdnavarro/ocs3/branches{/branch}","tags_url":"https://api.github.com/repos/jdnavarro/ocs3/tags","blobs_url":"https://api.github.com/repos/jdnavarro/ocs3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdnavarro/ocs3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdnavarro/ocs3/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdnavarro/ocs3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdnavarro/ocs3/statuses/{sha}","languages_url":"https://api.github.com/repos/jdnavarro/ocs3/languages","stargazers_url":"https://api.github.com/repos/jdnavarro/ocs3/stargazers","contributors_url":"https://api.github.com/repos/jdnavarro/ocs3/contributors","subscribers_url":"https://api.github.com/repos/jdnavarro/ocs3/subscribers","subscription_url":"https://api.github.com/repos/jdnavarro/ocs3/subscription","commits_url":"https://api.github.com/repos/jdnavarro/ocs3/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdnavarro/ocs3/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdnavarro/ocs3/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdnavarro/ocs3/issues/comments{/number}","contents_url":"https://api.github.com/repos/jdnavarro/ocs3/contents/{+path}","compare_url":"https://api.github.com/repos/jdnavarro/ocs3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdnavarro/ocs3/merges","archive_url":"https://api.github.com/repos/jdnavarro/ocs3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdnavarro/ocs3/downloads","issues_url":"https://api.github.com/repos/jdnavarro/ocs3/issues{/number}","pulls_url":"https://api.github.com/repos/jdnavarro/ocs3/pulls{/number}","milestones_url":"https://api.github.com/repos/jdnavarro/ocs3/milestones{/number}","notifications_url":"https://api.github.com/repos/jdnavarro/ocs3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdnavarro/ocs3/labels{/name}","releases_url":"https://api.github.com/repos/jdnavarro/ocs3/releases{/id}","deployments_url":"https://api.github.com/repos/jdnavarro/ocs3/deployments","created_at":"2016-07-04T16:57:22Z","updated_at":"2016-07-04T16:57:24Z","pushed_at":"2016-10-18T15:41:16Z","git_url":"git://github.com/jdnavarro/ocs3.git","ssh_url":"git@github.com:jdnavarro/ocs3.git","clone_url":"https://github.com/jdnavarro/ocs3.git","svn_url":"https://github.com/jdnavarro/ocs3","homepage":null,"size":4207,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"gemini-hlsw:feature/engine","ref":"feature/engine","sha":"f04ecd5f43d8b214ae0b68d60c16f15f568802e8","user":{"login":"gemini-hlsw","id":8593735,"avatar_url":"https://avatars.githubusercontent.com/u/8593735?v=3","gravatar_id":"","url":"https://api.github.com/users/gemini-hlsw","html_url":"https://github.com/gemini-hlsw","followers_url":"https://api.github.com/users/gemini-hlsw/followers","following_url":"https://api.github.com/users/gemini-hlsw/following{/other_user}","gists_url":"https://api.github.com/users/gemini-hlsw/gists{/gist_id}","starred_url":"https://api.github.com/users/gemini-hlsw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemini-hlsw/subscriptions","organizations_url":"https://api.github.com/users/gemini-hlsw/orgs","repos_url":"https://api.github.com/users/gemini-hlsw/repos","events_url":"https://api.github.com/users/gemini-hlsw/events{/privacy}","received_events_url":"https://api.github.com/users/gemini-hlsw/received_events","type":"Organization","site_admin":false},"repo":{"id":54653732,"name":"ocs3","full_name":"gemini-hlsw/ocs3","owner":{"login":"gemini-hlsw","id":8593735,"avatar_url":"https://avatars.githubusercontent.com/u/8593735?v=3","gravatar_id":"","url":"https://api.github.com/users/gemini-hlsw","html_url":"https://github.com/gemini-hlsw","followers_url":"https://api.github.com/users/gemini-hlsw/followers","following_url":"https://api.github.com/users/gemini-hlsw/following{/other_user}","gists_url":"https://api.github.com/users/gemini-hlsw/gists{/gist_id}","starred_url":"https://api.github.com/users/gemini-hlsw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemini-hlsw/subscriptions","organizations_url":"https://api.github.com/users/gemini-hlsw/orgs","repos_url":"https://api.github.com/users/gemini-hlsw/repos","events_url":"https://api.github.com/users/gemini-hlsw/events{/privacy}","received_events_url":"https://api.github.com/users/gemini-hlsw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gemini-hlsw/ocs3","description":"Observatory Control Software - New Generation","fork":false,"url":"https://api.github.com/repos/gemini-hlsw/ocs3","forks_url":"https://api.github.com/repos/gemini-hlsw/ocs3/forks","keys_url":"https://api.github.com/repos/gemini-hlsw/ocs3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gemini-hlsw/ocs3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gemini-hlsw/ocs3/teams","hooks_url":"https://api.github.com/repos/gemini-hlsw/ocs3/hooks","issue_events_url":"https://api.github.com/repos/gemini-hlsw/ocs3/issues/events{/number}","events_url":"https://api.github.com/repos/gemini-hlsw/ocs3/events","assignees_url":"https://api.github.com/repos/gemini-hlsw/ocs3/assignees{/user}","branches_url":"https://api.github.com/repos/gemini-hlsw/ocs3/branches{/branch}","tags_url":"https://api.github.com/repos/gemini-hlsw/ocs3/tags","blobs_url":"https://api.github.com/repos/gemini-hlsw/ocs3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gemini-hlsw/ocs3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gemini-hlsw/ocs3/git/refs{/sha}","trees_url":"https://api.github.com/repos/gemini-hlsw/ocs3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gemini-hlsw/ocs3/statuses/{sha}","languages_url":"https://api.github.com/repos/gemini-hlsw/ocs3/languages","stargazers_url":"https://api.github.com/repos/gemini-hlsw/ocs3/stargazers","contributors_url":"https://api.github.com/repos/gemini-hlsw/ocs3/contributors","subscribers_url":"https://api.github.com/repos/gemini-hlsw/ocs3/subscribers","subscription_url":"https://api.github.com/repos/gemini-hlsw/ocs3/subscription","commits_url":"https://api.github.com/repos/gemini-hlsw/ocs3/commits{/sha}","git_commits_url":"https://api.github.com/repos/gemini-hlsw/ocs3/git/commits{/sha}","comments_url":"https://api.github.com/repos/gemini-hlsw/ocs3/comments{/number}","issue_comment_url":"https://api.github.com/repos/gemini-hlsw/ocs3/issues/comments{/number}","contents_url":"https://api.github.com/repos/gemini-hlsw/ocs3/contents/{+path}","compare_url":"https://api.github.com/repos/gemini-hlsw/ocs3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gemini-hlsw/ocs3/merges","archive_url":"https://api.github.com/repos/gemini-hlsw/ocs3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gemini-hlsw/ocs3/downloads","issues_url":"https://api.github.com/repos/gemini-hlsw/ocs3/issues{/number}","pulls_url":"https://api.github.com/repos/gemini-hlsw/ocs3/pulls{/number}","milestones_url":"https://api.github.com/repos/gemini-hlsw/ocs3/milestones{/number}","notifications_url":"https://api.github.com/repos/gemini-hlsw/ocs3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gemini-hlsw/ocs3/labels{/name}","releases_url":"https://api.github.com/repos/gemini-hlsw/ocs3/releases{/id}","deployments_url":"https://api.github.com/repos/gemini-hlsw/ocs3/deployments","created_at":"2016-03-24T15:40:39Z","updated_at":"2016-07-27T09:26:57Z","pushed_at":"2016-10-18T15:46:58Z","git_url":"git://github.com/gemini-hlsw/ocs3.git","ssh_url":"git@github.com:gemini-hlsw/ocs3.git","clone_url":"https://github.com/gemini-hlsw/ocs3.git","svn_url":"https://github.com/gemini-hlsw/ocs3","homepage":null,"size":4274,"stargazers_count":3,"watchers_count":3,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":16,"forks":3,"open_issues":16,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/gemini-hlsw/ocs3/pulls/100"},"html":{"href":"https://github.com/gemini-hlsw/ocs3/pull/100"},"issue":{"href":"https://api.github.com/repos/gemini-hlsw/ocs3/issues/100"},"comments":{"href":"https://api.github.com/repos/gemini-hlsw/ocs3/issues/100/comments"},"review_comments":{"href":"https://api.github.com/repos/gemini-hlsw/ocs3/pulls/100/comments"},"review_comment":{"href":"https://api.github.com/repos/gemini-hlsw/ocs3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gemini-hlsw/ocs3/pulls/100/commits"},"statuses":{"href":"https://api.github.com/repos/gemini-hlsw/ocs3/statuses/78a4aa833783740c738bfc2181ea9b2b477fda60"}}}}
{"actor":{"display_login":"jdnavarro"}}