{"action":"created","comment":{"url":"https://api.github.com/repos/google/protobuf/pulls/comments/65622735","id":65622735,"diff_hunk":"@@ -87,22 +90,35 @@ if(NOT MSVC)\n else()\n   set(CMAKE_INSTALL_CMAKEDIR \"cmake\" CACHE STRING \"${_cmakedir_desc}\")\n endif()\n+mark_as_advanced(CMAKE_INSTALL_CMAKEDIR)","path":"cmake/install.cmake","position":14,"original_position":14,"commit_id":"437cd369382f310a4adc03c3f8b4470de9f32ca9","original_commit_id":"437cd369382f310a4adc03c3f8b4470de9f32ca9","user":{"login":"podsvirov","id":8400779,"avatar_url":"https://avatars.githubusercontent.com/u/8400779?v=3","gravatar_id":"","url":"https://api.github.com/users/podsvirov","html_url":"https://github.com/podsvirov","followers_url":"https://api.github.com/users/podsvirov/followers","following_url":"https://api.github.com/users/podsvirov/following{/other_user}","gists_url":"https://api.github.com/users/podsvirov/gists{/gist_id}","starred_url":"https://api.github.com/users/podsvirov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/podsvirov/subscriptions","organizations_url":"https://api.github.com/users/podsvirov/orgs","repos_url":"https://api.github.com/users/podsvirov/repos","events_url":"https://api.github.com/users/podsvirov/events{/privacy}","received_events_url":"https://api.github.com/users/podsvirov/received_events","type":"User","site_admin":false},"body":"For example CMAKE_INSTALL_BINDIR and other is advanced variables.\r\nThey are used by advanced users and should not interfere with the basic process.\r\nVariable CMAKE_INSTALL_PREFIX know and use all - it does not need to hide in the normal mode.","created_at":"2016-06-02T21:34:07Z","updated_at":"2016-06-02T21:34:07Z","html_url":"https://github.com/google/protobuf/pull/1642#discussion_r65622735","pull_request_url":"https://api.github.com/repos/google/protobuf/pulls/1642","_links":{"self":{"href":"https://api.github.com/repos/google/protobuf/pulls/comments/65622735"},"html":{"href":"https://github.com/google/protobuf/pull/1642#discussion_r65622735"},"pull_request":{"href":"https://api.github.com/repos/google/protobuf/pulls/1642"}}},"pull_request":{"url":"https://api.github.com/repos/google/protobuf/pulls/1642","id":72318582,"html_url":"https://github.com/google/protobuf/pull/1642","diff_url":"https://github.com/google/protobuf/pull/1642.diff","patch_url":"https://github.com/google/protobuf/pull/1642.patch","issue_url":"https://api.github.com/repos/google/protobuf/issues/1642","number":1642,"state":"open","locked":false,"title":"CMake project updates","user":{"login":"podsvirov","id":8400779,"avatar_url":"https://avatars.githubusercontent.com/u/8400779?v=3","gravatar_id":"","url":"https://api.github.com/users/podsvirov","html_url":"https://github.com/podsvirov","followers_url":"https://api.github.com/users/podsvirov/followers","following_url":"https://api.github.com/users/podsvirov/following{/other_user}","gists_url":"https://api.github.com/users/podsvirov/gists{/gist_id}","starred_url":"https://api.github.com/users/podsvirov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/podsvirov/subscriptions","organizations_url":"https://api.github.com/users/podsvirov/orgs","repos_url":"https://api.github.com/users/podsvirov/repos","events_url":"https://api.github.com/users/podsvirov/events{/privacy}","received_events_url":"https://api.github.com/users/podsvirov/received_events","type":"User","site_admin":false},"body":"A series of improvements:\r\n- Improved  Protobuf module compatibility (disabled by default);\r\n- Hide advanced settings;\r\n- Added build tree configuration;\r\n- Added build of examples.\r\n\r\nDear @xfxyjwf and @yeswalrus please review this changes.\r\n\r\nI propose to accept these changes and then continue to improve from @yeswalrus like #1624.\r\nThis also replace #1631.","created_at":"2016-06-02T09:56:23Z","updated_at":"2016-06-02T21:34:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76b60acb01285f620e252e9ef9e4f94b9bf1eb62","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/protobuf/pulls/1642/commits","review_comments_url":"https://api.github.com/repos/google/protobuf/pulls/1642/comments","review_comment_url":"https://api.github.com/repos/google/protobuf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/protobuf/issues/1642/comments","statuses_url":"https://api.github.com/repos/google/protobuf/statuses/437cd369382f310a4adc03c3f8b4470de9f32ca9","head":{"label":"podsvirov:topic-cmake-project","ref":"topic-cmake-project","sha":"437cd369382f310a4adc03c3f8b4470de9f32ca9","user":{"login":"podsvirov","id":8400779,"avatar_url":"https://avatars.githubusercontent.com/u/8400779?v=3","gravatar_id":"","url":"https://api.github.com/users/podsvirov","html_url":"https://github.com/podsvirov","followers_url":"https://api.github.com/users/podsvirov/followers","following_url":"https://api.github.com/users/podsvirov/following{/other_user}","gists_url":"https://api.github.com/users/podsvirov/gists{/gist_id}","starred_url":"https://api.github.com/users/podsvirov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/podsvirov/subscriptions","organizations_url":"https://api.github.com/users/podsvirov/orgs","repos_url":"https://api.github.com/users/podsvirov/repos","events_url":"https://api.github.com/users/podsvirov/events{/privacy}","received_events_url":"https://api.github.com/users/podsvirov/received_events","type":"User","site_admin":false},"repo":{"id":40021388,"name":"protobuf","full_name":"podsvirov/protobuf","owner":{"login":"podsvirov","id":8400779,"avatar_url":"https://avatars.githubusercontent.com/u/8400779?v=3","gravatar_id":"","url":"https://api.github.com/users/podsvirov","html_url":"https://github.com/podsvirov","followers_url":"https://api.github.com/users/podsvirov/followers","following_url":"https://api.github.com/users/podsvirov/following{/other_user}","gists_url":"https://api.github.com/users/podsvirov/gists{/gist_id}","starred_url":"https://api.github.com/users/podsvirov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/podsvirov/subscriptions","organizations_url":"https://api.github.com/users/podsvirov/orgs","repos_url":"https://api.github.com/users/podsvirov/repos","events_url":"https://api.github.com/users/podsvirov/events{/privacy}","received_events_url":"https://api.github.com/users/podsvirov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/podsvirov/protobuf","description":"Protocol Buffers Contribution fork","fork":true,"url":"https://api.github.com/repos/podsvirov/protobuf","forks_url":"https://api.github.com/repos/podsvirov/protobuf/forks","keys_url":"https://api.github.com/repos/podsvirov/protobuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/podsvirov/protobuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/podsvirov/protobuf/teams","hooks_url":"https://api.github.com/repos/podsvirov/protobuf/hooks","issue_events_url":"https://api.github.com/repos/podsvirov/protobuf/issues/events{/number}","events_url":"https://api.github.com/repos/podsvirov/protobuf/events","assignees_url":"https://api.github.com/repos/podsvirov/protobuf/assignees{/user}","branches_url":"https://api.github.com/repos/podsvirov/protobuf/branches{/branch}","tags_url":"https://api.github.com/repos/podsvirov/protobuf/tags","blobs_url":"https://api.github.com/repos/podsvirov/protobuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/podsvirov/protobuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/podsvirov/protobuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/podsvirov/protobuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/podsvirov/protobuf/statuses/{sha}","languages_url":"https://api.github.com/repos/podsvirov/protobuf/languages","stargazers_url":"https://api.github.com/repos/podsvirov/protobuf/stargazers","contributors_url":"https://api.github.com/repos/podsvirov/protobuf/contributors","subscribers_url":"https://api.github.com/repos/podsvirov/protobuf/subscribers","subscription_url":"https://api.github.com/repos/podsvirov/protobuf/subscription","commits_url":"https://api.github.com/repos/podsvirov/protobuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/podsvirov/protobuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/podsvirov/protobuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/podsvirov/protobuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/podsvirov/protobuf/contents/{+path}","compare_url":"https://api.github.com/repos/podsvirov/protobuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/podsvirov/protobuf/merges","archive_url":"https://api.github.com/repos/podsvirov/protobuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/podsvirov/protobuf/downloads","issues_url":"https://api.github.com/repos/podsvirov/protobuf/issues{/number}","pulls_url":"https://api.github.com/repos/podsvirov/protobuf/pulls{/number}","milestones_url":"https://api.github.com/repos/podsvirov/protobuf/milestones{/number}","notifications_url":"https://api.github.com/repos/podsvirov/protobuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/podsvirov/protobuf/labels{/name}","releases_url":"https://api.github.com/repos/podsvirov/protobuf/releases{/id}","deployments_url":"https://api.github.com/repos/podsvirov/protobuf/deployments","created_at":"2015-07-31T19:24:39Z","updated_at":"2016-06-01T20:12:13Z","pushed_at":"2016-06-02T18:08:08Z","git_url":"git://github.com/podsvirov/protobuf.git","ssh_url":"git@github.com:podsvirov/protobuf.git","clone_url":"https://github.com/podsvirov/protobuf.git","svn_url":"https://github.com/podsvirov/protobuf","homepage":"https://dad.podsvirov.pro","size":32705,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"0ab7a7f74458be56bfc65a71a46711637ee5962b","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":23357588,"name":"protobuf","full_name":"google/protobuf","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/protobuf","description":"Protocol Buffers - Google's data interchange format","fork":false,"url":"https://api.github.com/repos/google/protobuf","forks_url":"https://api.github.com/repos/google/protobuf/forks","keys_url":"https://api.github.com/repos/google/protobuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/protobuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/protobuf/teams","hooks_url":"https://api.github.com/repos/google/protobuf/hooks","issue_events_url":"https://api.github.com/repos/google/protobuf/issues/events{/number}","events_url":"https://api.github.com/repos/google/protobuf/events","assignees_url":"https://api.github.com/repos/google/protobuf/assignees{/user}","branches_url":"https://api.github.com/repos/google/protobuf/branches{/branch}","tags_url":"https://api.github.com/repos/google/protobuf/tags","blobs_url":"https://api.github.com/repos/google/protobuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/protobuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/protobuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/protobuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/protobuf/statuses/{sha}","languages_url":"https://api.github.com/repos/google/protobuf/languages","stargazers_url":"https://api.github.com/repos/google/protobuf/stargazers","contributors_url":"https://api.github.com/repos/google/protobuf/contributors","subscribers_url":"https://api.github.com/repos/google/protobuf/subscribers","subscription_url":"https://api.github.com/repos/google/protobuf/subscription","commits_url":"https://api.github.com/repos/google/protobuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/protobuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/protobuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/protobuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/protobuf/contents/{+path}","compare_url":"https://api.github.com/repos/google/protobuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/protobuf/merges","archive_url":"https://api.github.com/repos/google/protobuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/protobuf/downloads","issues_url":"https://api.github.com/repos/google/protobuf/issues{/number}","pulls_url":"https://api.github.com/repos/google/protobuf/pulls{/number}","milestones_url":"https://api.github.com/repos/google/protobuf/milestones{/number}","notifications_url":"https://api.github.com/repos/google/protobuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/protobuf/labels{/name}","releases_url":"https://api.github.com/repos/google/protobuf/releases{/id}","deployments_url":"https://api.github.com/repos/google/protobuf/deployments","created_at":"2014-08-26T15:52:15Z","updated_at":"2016-06-02T21:07:16Z","pushed_at":"2016-06-02T18:14:26Z","git_url":"git://github.com/google/protobuf.git","ssh_url":"git@github.com:google/protobuf.git","clone_url":"https://github.com/google/protobuf.git","svn_url":"https://github.com/google/protobuf","homepage":"https://developers.google.com/protocol-buffers/","size":60083,"stargazers_count":9287,"watchers_count":9287,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2815,"mirror_url":null,"open_issues_count":398,"forks":2815,"open_issues":398,"watchers":9287,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/protobuf/pulls/1642"},"html":{"href":"https://github.com/google/protobuf/pull/1642"},"issue":{"href":"https://api.github.com/repos/google/protobuf/issues/1642"},"comments":{"href":"https://api.github.com/repos/google/protobuf/issues/1642/comments"},"review_comments":{"href":"https://api.github.com/repos/google/protobuf/pulls/1642/comments"},"review_comment":{"href":"https://api.github.com/repos/google/protobuf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/protobuf/pulls/1642/commits"},"statuses":{"href":"https://api.github.com/repos/google/protobuf/statuses/437cd369382f310a4adc03c3f8b4470de9f32ca9"}}}}
{"actor":{"display_login":"podsvirov"}}