{"action":"created","comment":{"url":"https://api.github.com/repos/sabose/ovirt-georep-backup/pulls/comments/66071605","id":66071605,"diff_hunk":"@@ -151,16 +233,27 @@ def main(args):\n     if ret != 0:\n         logger.error(\"Error:\" + str(out) + \":\" + '.'.join(err))\n         retcode = 1\n+    else:\n+        # delete overlay images from slave\n+        with glustermount(args.slave, args.slavevol) as mnt:\n+            # find overlay image path (returns .lease and .meta files too)\n+            for diskImg in diskimgs_to_del:\n+                imgPaths = findImgPaths(diskImg, mnt)\n+                for imgPath in imgPaths:\n+                    logger.debug(\"IMG PATH:\" + imgPath)\n+                    os.remove(imgPath)\n \n     for vm_to_commit in vms_to_commit:\n         # Block commit VMs\n         try:\n             vm = vm_to_commit['vm']\n-            logger.info(\"Delete snapshot for: \" + vm.name)\n+            logger.debug(\"Deleting snapshot for: \" + vm.name)\n             snapshot = vm_to_commit['snapshot']\n-\n-            # vm.commit_snapshot() - not working  \"Cannot revert to Snapshot. VM's Snapshot does not exist.\"\n+            # live merge\n             snapshot.delete()\n+            # wait for snapshot deletion to complete\n+            wait_for_snapshot_deletion(vm, snapshot.get_id())","path":"vmbackup.py","position":229,"original_position":229,"commit_id":"a3812affa4578f2f00b9a588ea2f13820cfbb292","original_commit_id":"a3812affa4578f2f00b9a588ea2f13820cfbb292","user":{"login":"sabose","id":6857979,"avatar_url":"https://avatars.githubusercontent.com/u/6857979?v=3","gravatar_id":"","url":"https://api.github.com/users/sabose","html_url":"https://github.com/sabose","followers_url":"https://api.github.com/users/sabose/followers","following_url":"https://api.github.com/users/sabose/following{/other_user}","gists_url":"https://api.github.com/users/sabose/gists{/gist_id}","starred_url":"https://api.github.com/users/sabose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sabose/subscriptions","organizations_url":"https://api.github.com/users/sabose/orgs","repos_url":"https://api.github.com/users/sabose/repos","events_url":"https://api.github.com/users/sabose/events{/privacy}","received_events_url":"https://api.github.com/users/sabose/received_events","type":"User","site_admin":false},"body":"will add a timeout check for wait","created_at":"2016-06-07T13:39:39Z","updated_at":"2016-06-07T13:39:39Z","html_url":"https://github.com/sabose/ovirt-georep-backup/pull/1#discussion_r66071605","pull_request_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/sabose/ovirt-georep-backup/pulls/comments/66071605"},"html":{"href":"https://github.com/sabose/ovirt-georep-backup/pull/1#discussion_r66071605"},"pull_request":{"href":"https://api.github.com/repos/sabose/ovirt-georep-backup/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/sabose/ovirt-georep-backup/pulls/1","id":71036750,"html_url":"https://github.com/sabose/ovirt-georep-backup/pull/1","diff_url":"https://github.com/sabose/ovirt-georep-backup/pull/1.diff","patch_url":"https://github.com/sabose/ovirt-georep-backup/pull/1.patch","issue_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/issues/1","number":1,"state":"open","locked":false,"title":"added code to delete overlay images at slave mount point","user":{"login":"sabose","id":6857979,"avatar_url":"https://avatars.githubusercontent.com/u/6857979?v=3","gravatar_id":"","url":"https://api.github.com/users/sabose","html_url":"https://github.com/sabose","followers_url":"https://api.github.com/users/sabose/followers","following_url":"https://api.github.com/users/sabose/following{/other_user}","gists_url":"https://api.github.com/users/sabose/gists{/gist_id}","starred_url":"https://api.github.com/users/sabose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sabose/subscriptions","organizations_url":"https://api.github.com/users/sabose/orgs","repos_url":"https://api.github.com/users/sabose/repos","events_url":"https://api.github.com/users/sabose/events{/privacy}","received_events_url":"https://api.github.com/users/sabose/received_events","type":"User","site_admin":false},"body":"and to wait for snapshot deletion.\r\n\r\nSigned-off-by: Sahina Bose <sabose@redhat.com>","created_at":"2016-05-23T10:16:20Z","updated_at":"2016-06-07T13:39:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb71fc53dacc9de05edcac12d7e4587cf2add471","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/pulls/1/commits","review_comments_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/pulls/1/comments","review_comment_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/issues/1/comments","statuses_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/statuses/a3812affa4578f2f00b9a588ea2f13820cfbb292","head":{"label":"sabose:wip","ref":"wip","sha":"a3812affa4578f2f00b9a588ea2f13820cfbb292","user":{"login":"sabose","id":6857979,"avatar_url":"https://avatars.githubusercontent.com/u/6857979?v=3","gravatar_id":"","url":"https://api.github.com/users/sabose","html_url":"https://github.com/sabose","followers_url":"https://api.github.com/users/sabose/followers","following_url":"https://api.github.com/users/sabose/following{/other_user}","gists_url":"https://api.github.com/users/sabose/gists{/gist_id}","starred_url":"https://api.github.com/users/sabose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sabose/subscriptions","organizations_url":"https://api.github.com/users/sabose/orgs","repos_url":"https://api.github.com/users/sabose/repos","events_url":"https://api.github.com/users/sabose/events{/privacy}","received_events_url":"https://api.github.com/users/sabose/received_events","type":"User","site_admin":false},"repo":{"id":56590937,"name":"ovirt-georep-backup","full_name":"sabose/ovirt-georep-backup","owner":{"login":"sabose","id":6857979,"avatar_url":"https://avatars.githubusercontent.com/u/6857979?v=3","gravatar_id":"","url":"https://api.github.com/users/sabose","html_url":"https://github.com/sabose","followers_url":"https://api.github.com/users/sabose/followers","following_url":"https://api.github.com/users/sabose/following{/other_user}","gists_url":"https://api.github.com/users/sabose/gists{/gist_id}","starred_url":"https://api.github.com/users/sabose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sabose/subscriptions","organizations_url":"https://api.github.com/users/sabose/orgs","repos_url":"https://api.github.com/users/sabose/repos","events_url":"https://api.github.com/users/sabose/events{/privacy}","received_events_url":"https://api.github.com/users/sabose/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sabose/ovirt-georep-backup","description":"","fork":false,"url":"https://api.github.com/repos/sabose/ovirt-georep-backup","forks_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/forks","keys_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/teams","hooks_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/hooks","issue_events_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/issues/events{/number}","events_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/events","assignees_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/assignees{/user}","branches_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/branches{/branch}","tags_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/tags","blobs_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/git/refs{/sha}","trees_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/statuses/{sha}","languages_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/languages","stargazers_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/stargazers","contributors_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/contributors","subscribers_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/subscribers","subscription_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/subscription","commits_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/commits{/sha}","git_commits_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/git/commits{/sha}","comments_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/comments{/number}","issue_comment_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/issues/comments{/number}","contents_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/contents/{+path}","compare_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/merges","archive_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/downloads","issues_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/issues{/number}","pulls_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/pulls{/number}","milestones_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/milestones{/number}","notifications_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/labels{/name}","releases_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/releases{/id}","deployments_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/deployments","created_at":"2016-04-19T11:26:53Z","updated_at":"2016-04-19T12:33:18Z","pushed_at":"2016-05-24T11:09:20Z","git_url":"git://github.com/sabose/ovirt-georep-backup.git","ssh_url":"git@github.com:sabose/ovirt-georep-backup.git","clone_url":"https://github.com/sabose/ovirt-georep-backup.git","svn_url":"https://github.com/sabose/ovirt-georep-backup","homepage":null,"size":7,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"sabose:master","ref":"master","sha":"62c81d6bfa2091fd480a07dd804009c829dd85e7","user":{"login":"sabose","id":6857979,"avatar_url":"https://avatars.githubusercontent.com/u/6857979?v=3","gravatar_id":"","url":"https://api.github.com/users/sabose","html_url":"https://github.com/sabose","followers_url":"https://api.github.com/users/sabose/followers","following_url":"https://api.github.com/users/sabose/following{/other_user}","gists_url":"https://api.github.com/users/sabose/gists{/gist_id}","starred_url":"https://api.github.com/users/sabose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sabose/subscriptions","organizations_url":"https://api.github.com/users/sabose/orgs","repos_url":"https://api.github.com/users/sabose/repos","events_url":"https://api.github.com/users/sabose/events{/privacy}","received_events_url":"https://api.github.com/users/sabose/received_events","type":"User","site_admin":false},"repo":{"id":56590937,"name":"ovirt-georep-backup","full_name":"sabose/ovirt-georep-backup","owner":{"login":"sabose","id":6857979,"avatar_url":"https://avatars.githubusercontent.com/u/6857979?v=3","gravatar_id":"","url":"https://api.github.com/users/sabose","html_url":"https://github.com/sabose","followers_url":"https://api.github.com/users/sabose/followers","following_url":"https://api.github.com/users/sabose/following{/other_user}","gists_url":"https://api.github.com/users/sabose/gists{/gist_id}","starred_url":"https://api.github.com/users/sabose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sabose/subscriptions","organizations_url":"https://api.github.com/users/sabose/orgs","repos_url":"https://api.github.com/users/sabose/repos","events_url":"https://api.github.com/users/sabose/events{/privacy}","received_events_url":"https://api.github.com/users/sabose/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sabose/ovirt-georep-backup","description":"","fork":false,"url":"https://api.github.com/repos/sabose/ovirt-georep-backup","forks_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/forks","keys_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/teams","hooks_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/hooks","issue_events_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/issues/events{/number}","events_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/events","assignees_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/assignees{/user}","branches_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/branches{/branch}","tags_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/tags","blobs_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/git/refs{/sha}","trees_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/statuses/{sha}","languages_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/languages","stargazers_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/stargazers","contributors_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/contributors","subscribers_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/subscribers","subscription_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/subscription","commits_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/commits{/sha}","git_commits_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/git/commits{/sha}","comments_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/comments{/number}","issue_comment_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/issues/comments{/number}","contents_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/contents/{+path}","compare_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/merges","archive_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/downloads","issues_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/issues{/number}","pulls_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/pulls{/number}","milestones_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/milestones{/number}","notifications_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/labels{/name}","releases_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/releases{/id}","deployments_url":"https://api.github.com/repos/sabose/ovirt-georep-backup/deployments","created_at":"2016-04-19T11:26:53Z","updated_at":"2016-04-19T12:33:18Z","pushed_at":"2016-05-24T11:09:20Z","git_url":"git://github.com/sabose/ovirt-georep-backup.git","ssh_url":"git@github.com:sabose/ovirt-georep-backup.git","clone_url":"https://github.com/sabose/ovirt-georep-backup.git","svn_url":"https://github.com/sabose/ovirt-georep-backup","homepage":null,"size":7,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sabose/ovirt-georep-backup/pulls/1"},"html":{"href":"https://github.com/sabose/ovirt-georep-backup/pull/1"},"issue":{"href":"https://api.github.com/repos/sabose/ovirt-georep-backup/issues/1"},"comments":{"href":"https://api.github.com/repos/sabose/ovirt-georep-backup/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/sabose/ovirt-georep-backup/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/sabose/ovirt-georep-backup/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sabose/ovirt-georep-backup/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/sabose/ovirt-georep-backup/statuses/a3812affa4578f2f00b9a588ea2f13820cfbb292"}}}}
{"actor":{"display_login":"sabose"}}