{"push_id":1369508654,"size":1,"distinct_size":1,"ref":"refs/heads/fuse-cli","head":"b8a6108d860faa9f25e796562f2d442367ec53db","before":"3219622affad65d5c1a51cc1ca8c34f341596612","commits":[{"sha":"b8a6108d860faa9f25e796562f2d442367ec53db","author":{"name":"Juan Cruz Viotti","email":"eb0d14b01aa90c30fa44578ffefc31ae745661db@openmailbox.org"},"message":"feat(GUI): spawn CLI directly from the AppImage in GNU/Linux\n\nIf we pass relative paths as arguments to the AppImage, they get\nresolved from `/tmp/.mount_XXXXXX/usr`. We can exploit this to run the\nEtcher CLI directly from the AppImage, rather than having to mount it\nourselves:\n\n```sh\nELECTRON_RUN_AS_NODE=1 Etcher-linux-x64.AppImage bin/resources/app.asar [OPTIONS]\n```\n\nBy using this little trick, we get rid of both our custom mounting logic\nand the need of surrounding the command to run in single quotes,\ntherefore avoiding a whole new kind of escaping issues.\n\nSince running the CLI directly from the AppImage means that the\n`desktopintegration` will be ran for the CLI, we pass the `SKIP`\nenvironment variable to avoid having it prompt the user for\ninstallation.\n\nWe also updated the `desktopintegration` script to the latest version,\nwhich reduces the amount of logging plus other minor fixes.\n\nFixes: https://github.com/resin-io/etcher/issues/637\nChange-Type: patch\nChangelog-Entry: Fix Etcher leaving zombie processes behind in GNU/Linux.\nSigned-off-by: Juan Cruz Viotti <jviotti@openmailbox.org>","distinct":true,"url":"https://api.github.com/repos/resin-io/etcher/commits/b8a6108d860faa9f25e796562f2d442367ec53db"}]}
{"actor":{"display_login":"jviotti"}}