{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/88649470","pull_request_review_id":9217398,"id":88649470,"diff_hunk":"@@ -151,6 +176,15 @@ private SerializationResult getSerializationResult() {\n \t\treturn SerializationResult.PARTIAL_RECORD_MEMORY_SEGMENT_FULL;\n \t}\n \n+\t/**\n+\t * Gets the currently set target buffer and sets its size to the actual\n+\t * number of written bytes.\n+\t *\n+\t * After calling this method, a new target buffer is required to continue\n+\t * writing (see {@link #setNextBuffer(Buffer)}).\n+\t *\n+\t * @return the target buffer that was used\n+\t */","path":"flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpanningRecordSerializer.java","position":58,"original_position":58,"commit_id":"85ac76e097a482ef89d6c3d1a7e913b666de8159","original_commit_id":"85ac76e097a482ef89d6c3d1a7e913b666de8159","user":{"login":"NicoK","id":213026,"avatar_url":"https://avatars.githubusercontent.com/u/213026?v=3","gravatar_id":"","url":"https://api.github.com/users/NicoK","html_url":"https://github.com/NicoK","followers_url":"https://api.github.com/users/NicoK/followers","following_url":"https://api.github.com/users/NicoK/following{/other_user}","gists_url":"https://api.github.com/users/NicoK/gists{/gist_id}","starred_url":"https://api.github.com/users/NicoK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicoK/subscriptions","organizations_url":"https://api.github.com/users/NicoK/orgs","repos_url":"https://api.github.com/users/NicoK/repos","events_url":"https://api.github.com/users/NicoK/events{/privacy}","received_events_url":"https://api.github.com/users/NicoK/received_events","type":"User","site_admin":false},"body":"I wasn't quite sure whether this is the intended behaviour for all (future) implementations of the interface - at the moment, there is only this one though and I described its actual behaviour.","created_at":"2016-11-18T12:35:36Z","updated_at":"2016-11-18T12:35:36Z","html_url":"https://github.com/apache/flink/pull/2829#discussion_r88649470","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/2829","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/88649470"},"html":{"href":"https://github.com/apache/flink/pull/2829#discussion_r88649470"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/2829"}}},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/2829","id":94353782,"html_url":"https://github.com/apache/flink/pull/2829","diff_url":"https://github.com/apache/flink/pull/2829.diff","patch_url":"https://github.com/apache/flink/pull/2829.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/2829","number":2829,"state":"open","locked":false,"title":"Hotfix 2016 11 18","user":{"login":"NicoK","id":213026,"avatar_url":"https://avatars.githubusercontent.com/u/213026?v=3","gravatar_id":"","url":"https://api.github.com/users/NicoK","html_url":"https://github.com/NicoK","followers_url":"https://api.github.com/users/NicoK/followers","following_url":"https://api.github.com/users/NicoK/following{/other_user}","gists_url":"https://api.github.com/users/NicoK/gists{/gist_id}","starred_url":"https://api.github.com/users/NicoK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicoK/subscriptions","organizations_url":"https://api.github.com/users/NicoK/orgs","repos_url":"https://api.github.com/users/NicoK/repos","events_url":"https://api.github.com/users/NicoK/events{/privacy}","received_events_url":"https://api.github.com/users/NicoK/received_events","type":"User","site_admin":false},"body":"Prevent RecordWriter#flush() to clear the serializer twice.\r\nAlso add some documentation to RecordWriter, RecordSerializer and SpanningRecordSerializer.","created_at":"2016-11-18T12:29:54Z","updated_at":"2016-11-18T12:35:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a30e0bfb210eb714e6025c602b127c49c26d14c4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/2829/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/2829/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/2829/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/85ac76e097a482ef89d6c3d1a7e913b666de8159","head":{"label":"NicoK:hotfix_2016-11-18","ref":"hotfix_2016-11-18","sha":"85ac76e097a482ef89d6c3d1a7e913b666de8159","user":{"login":"NicoK","id":213026,"avatar_url":"https://avatars.githubusercontent.com/u/213026?v=3","gravatar_id":"","url":"https://api.github.com/users/NicoK","html_url":"https://github.com/NicoK","followers_url":"https://api.github.com/users/NicoK/followers","following_url":"https://api.github.com/users/NicoK/following{/other_user}","gists_url":"https://api.github.com/users/NicoK/gists{/gist_id}","starred_url":"https://api.github.com/users/NicoK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicoK/subscriptions","organizations_url":"https://api.github.com/users/NicoK/orgs","repos_url":"https://api.github.com/users/NicoK/repos","events_url":"https://api.github.com/users/NicoK/events{/privacy}","received_events_url":"https://api.github.com/users/NicoK/received_events","type":"User","site_admin":false},"repo":{"id":72781206,"name":"flink","full_name":"NicoK/flink","owner":{"login":"NicoK","id":213026,"avatar_url":"https://avatars.githubusercontent.com/u/213026?v=3","gravatar_id":"","url":"https://api.github.com/users/NicoK","html_url":"https://github.com/NicoK","followers_url":"https://api.github.com/users/NicoK/followers","following_url":"https://api.github.com/users/NicoK/following{/other_user}","gists_url":"https://api.github.com/users/NicoK/gists{/gist_id}","starred_url":"https://api.github.com/users/NicoK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicoK/subscriptions","organizations_url":"https://api.github.com/users/NicoK/orgs","repos_url":"https://api.github.com/users/NicoK/repos","events_url":"https://api.github.com/users/NicoK/events{/privacy}","received_events_url":"https://api.github.com/users/NicoK/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NicoK/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/NicoK/flink","forks_url":"https://api.github.com/repos/NicoK/flink/forks","keys_url":"https://api.github.com/repos/NicoK/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NicoK/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NicoK/flink/teams","hooks_url":"https://api.github.com/repos/NicoK/flink/hooks","issue_events_url":"https://api.github.com/repos/NicoK/flink/issues/events{/number}","events_url":"https://api.github.com/repos/NicoK/flink/events","assignees_url":"https://api.github.com/repos/NicoK/flink/assignees{/user}","branches_url":"https://api.github.com/repos/NicoK/flink/branches{/branch}","tags_url":"https://api.github.com/repos/NicoK/flink/tags","blobs_url":"https://api.github.com/repos/NicoK/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NicoK/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NicoK/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/NicoK/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NicoK/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/NicoK/flink/languages","stargazers_url":"https://api.github.com/repos/NicoK/flink/stargazers","contributors_url":"https://api.github.com/repos/NicoK/flink/contributors","subscribers_url":"https://api.github.com/repos/NicoK/flink/subscribers","subscription_url":"https://api.github.com/repos/NicoK/flink/subscription","commits_url":"https://api.github.com/repos/NicoK/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/NicoK/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/NicoK/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/NicoK/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/NicoK/flink/contents/{+path}","compare_url":"https://api.github.com/repos/NicoK/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NicoK/flink/merges","archive_url":"https://api.github.com/repos/NicoK/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NicoK/flink/downloads","issues_url":"https://api.github.com/repos/NicoK/flink/issues{/number}","pulls_url":"https://api.github.com/repos/NicoK/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/NicoK/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/NicoK/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NicoK/flink/labels{/name}","releases_url":"https://api.github.com/repos/NicoK/flink/releases{/id}","deployments_url":"https://api.github.com/repos/NicoK/flink/deployments","created_at":"2016-11-03T19:51:01Z","updated_at":"2016-11-03T19:51:25Z","pushed_at":"2016-11-18T12:27:24Z","git_url":"git://github.com/NicoK/flink.git","ssh_url":"git@github.com:NicoK/flink.git","clone_url":"https://github.com/NicoK/flink.git","svn_url":"https://github.com/NicoK/flink","homepage":null,"size":103416,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"13ebb36bb6c7fbe591d9e7834a2fc34d8469bc00","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"name":"flink","full_name":"apache/flink","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/flink","description":"Mirror of Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink/deployments","created_at":"2014-06-07T07:00:10Z","updated_at":"2016-11-18T08:29:57Z","pushed_at":"2016-11-18T12:29:54Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":null,"size":142614,"stargazers_count":1760,"watchers_count":1760,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1189,"mirror_url":"git://git.apache.org/flink.git","open_issues_count":178,"forks":1189,"open_issues":178,"watchers":1760,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/2829"},"html":{"href":"https://github.com/apache/flink/pull/2829"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/2829"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/2829/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/2829/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/2829/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/85ac76e097a482ef89d6c3d1a7e913b666de8159"}}}}
{"actor":{"display_login":"NicoK"}}