{"action":"closed","number":1559,"pull_request":{"url":"https://api.github.com/repos/mtgred/netrunner/pulls/1559","id":71767276,"html_url":"https://github.com/mtgred/netrunner/pull/1559","diff_url":"https://github.com/mtgred/netrunner/pull/1559.diff","patch_url":"https://github.com/mtgred/netrunner/pull/1559.patch","issue_url":"https://api.github.com/repos/mtgred/netrunner/issues/1559","number":1559,"state":"closed","locked":false,"title":"Rebirth Implementation","user":{"login":"mharris717","id":64296,"avatar_url":"https://avatars.githubusercontent.com/u/64296?v=3","gravatar_id":"","url":"https://api.github.com/users/mharris717","html_url":"https://github.com/mharris717","followers_url":"https://api.github.com/users/mharris717/followers","following_url":"https://api.github.com/users/mharris717/following{/other_user}","gists_url":"https://api.github.com/users/mharris717/gists{/gist_id}","starred_url":"https://api.github.com/users/mharris717/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mharris717/subscriptions","organizations_url":"https://api.github.com/users/mharris717/orgs","repos_url":"https://api.github.com/users/mharris717/repos","events_url":"https://api.github.com/users/mharris717/events{/privacy}","received_events_url":"https://api.github.com/users/mharris717/received_events","type":"User","site_admin":false},"body":"I send all rebirth-able identities as part of the JSON payload for a deck in server.coffee. Opinions on whether this is a good idea or not are welcome. \r\n\r\n## Major Issues\r\n- Passive once per turn abilities (Kate, Gabe, etc) will fire if their condition is met after a Rebirth, even if the condition was met with a different action before the Rebirth. I added a message when Rebirth is played to notify players of this. \r\n\r\n- Recurring credit display is a bit wonky. If you go Whizzard -> Someone Else, his ability no longer works but the 3 recurring credits visually appear at the start of turn.\r\n\r\n## Minor Issues\r\n- The message when Rebirth is played doesn't say what ID was picked. This isn't an actual issue to me, since you can obviously see the new ID.\r\n\r\n- Not positive, but I think how I removed the card from the game was a bit hacky. Levy works by moving the card from play-area to rfg, but I have to move the last card in the discard pile. Pretty sure this has to do with how I used final-effect instead of a different macro, but I don't really understand what's happening, since I was just cargo culting when I chose final-effect\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/mtgred/netrunner/1559)\n<!-- Reviewable:end -->\n","created_at":"2016-05-27T20:17:19Z","updated_at":"2016-06-09T00:18:38Z","closed_at":"2016-06-09T00:18:38Z","merged_at":"2016-06-09T00:18:38Z","merge_commit_sha":"4a286b0737bb34dc7ee57fedd75fa7710e9972e1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mtgred/netrunner/pulls/1559/commits","review_comments_url":"https://api.github.com/repos/mtgred/netrunner/pulls/1559/comments","review_comment_url":"https://api.github.com/repos/mtgred/netrunner/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mtgred/netrunner/issues/1559/comments","statuses_url":"https://api.github.com/repos/mtgred/netrunner/statuses/f4a5d3c7927c40c41a68586ce1fff99598ba5f58","head":{"label":"mharris717:rebirth","ref":"rebirth","sha":"f4a5d3c7927c40c41a68586ce1fff99598ba5f58","user":{"login":"mharris717","id":64296,"avatar_url":"https://avatars.githubusercontent.com/u/64296?v=3","gravatar_id":"","url":"https://api.github.com/users/mharris717","html_url":"https://github.com/mharris717","followers_url":"https://api.github.com/users/mharris717/followers","following_url":"https://api.github.com/users/mharris717/following{/other_user}","gists_url":"https://api.github.com/users/mharris717/gists{/gist_id}","starred_url":"https://api.github.com/users/mharris717/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mharris717/subscriptions","organizations_url":"https://api.github.com/users/mharris717/orgs","repos_url":"https://api.github.com/users/mharris717/repos","events_url":"https://api.github.com/users/mharris717/events{/privacy}","received_events_url":"https://api.github.com/users/mharris717/received_events","type":"User","site_admin":false},"repo":{"id":41459679,"name":"netrunner","full_name":"mharris717/netrunner","owner":{"login":"mharris717","id":64296,"avatar_url":"https://avatars.githubusercontent.com/u/64296?v=3","gravatar_id":"","url":"https://api.github.com/users/mharris717","html_url":"https://github.com/mharris717","followers_url":"https://api.github.com/users/mharris717/followers","following_url":"https://api.github.com/users/mharris717/following{/other_user}","gists_url":"https://api.github.com/users/mharris717/gists{/gist_id}","starred_url":"https://api.github.com/users/mharris717/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mharris717/subscriptions","organizations_url":"https://api.github.com/users/mharris717/orgs","repos_url":"https://api.github.com/users/mharris717/repos","events_url":"https://api.github.com/users/mharris717/events{/privacy}","received_events_url":"https://api.github.com/users/mharris717/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mharris717/netrunner","description":"","fork":true,"url":"https://api.github.com/repos/mharris717/netrunner","forks_url":"https://api.github.com/repos/mharris717/netrunner/forks","keys_url":"https://api.github.com/repos/mharris717/netrunner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mharris717/netrunner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mharris717/netrunner/teams","hooks_url":"https://api.github.com/repos/mharris717/netrunner/hooks","issue_events_url":"https://api.github.com/repos/mharris717/netrunner/issues/events{/number}","events_url":"https://api.github.com/repos/mharris717/netrunner/events","assignees_url":"https://api.github.com/repos/mharris717/netrunner/assignees{/user}","branches_url":"https://api.github.com/repos/mharris717/netrunner/branches{/branch}","tags_url":"https://api.github.com/repos/mharris717/netrunner/tags","blobs_url":"https://api.github.com/repos/mharris717/netrunner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mharris717/netrunner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mharris717/netrunner/git/refs{/sha}","trees_url":"https://api.github.com/repos/mharris717/netrunner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mharris717/netrunner/statuses/{sha}","languages_url":"https://api.github.com/repos/mharris717/netrunner/languages","stargazers_url":"https://api.github.com/repos/mharris717/netrunner/stargazers","contributors_url":"https://api.github.com/repos/mharris717/netrunner/contributors","subscribers_url":"https://api.github.com/repos/mharris717/netrunner/subscribers","subscription_url":"https://api.github.com/repos/mharris717/netrunner/subscription","commits_url":"https://api.github.com/repos/mharris717/netrunner/commits{/sha}","git_commits_url":"https://api.github.com/repos/mharris717/netrunner/git/commits{/sha}","comments_url":"https://api.github.com/repos/mharris717/netrunner/comments{/number}","issue_comment_url":"https://api.github.com/repos/mharris717/netrunner/issues/comments{/number}","contents_url":"https://api.github.com/repos/mharris717/netrunner/contents/{+path}","compare_url":"https://api.github.com/repos/mharris717/netrunner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mharris717/netrunner/merges","archive_url":"https://api.github.com/repos/mharris717/netrunner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mharris717/netrunner/downloads","issues_url":"https://api.github.com/repos/mharris717/netrunner/issues{/number}","pulls_url":"https://api.github.com/repos/mharris717/netrunner/pulls{/number}","milestones_url":"https://api.github.com/repos/mharris717/netrunner/milestones{/number}","notifications_url":"https://api.github.com/repos/mharris717/netrunner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mharris717/netrunner/labels{/name}","releases_url":"https://api.github.com/repos/mharris717/netrunner/releases{/id}","deployments_url":"https://api.github.com/repos/mharris717/netrunner/deployments","created_at":"2015-08-27T01:52:10Z","updated_at":"2016-05-27T17:12:26Z","pushed_at":"2016-06-03T14:15:09Z","git_url":"git://github.com/mharris717/netrunner.git","ssh_url":"git@github.com:mharris717/netrunner.git","clone_url":"https://github.com/mharris717/netrunner.git","svn_url":"https://github.com/mharris717/netrunner","homepage":"http://www.jinteki.net","size":11688,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"mtgred:master","ref":"master","sha":"7b8cda5a5317524c304405369d83c41b39048c73","user":{"login":"mtgred","id":284114,"avatar_url":"https://avatars.githubusercontent.com/u/284114?v=3","gravatar_id":"","url":"https://api.github.com/users/mtgred","html_url":"https://github.com/mtgred","followers_url":"https://api.github.com/users/mtgred/followers","following_url":"https://api.github.com/users/mtgred/following{/other_user}","gists_url":"https://api.github.com/users/mtgred/gists{/gist_id}","starred_url":"https://api.github.com/users/mtgred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtgred/subscriptions","organizations_url":"https://api.github.com/users/mtgred/orgs","repos_url":"https://api.github.com/users/mtgred/repos","events_url":"https://api.github.com/users/mtgred/events{/privacy}","received_events_url":"https://api.github.com/users/mtgred/received_events","type":"User","site_admin":false},"repo":{"id":19079918,"name":"netrunner","full_name":"mtgred/netrunner","owner":{"login":"mtgred","id":284114,"avatar_url":"https://avatars.githubusercontent.com/u/284114?v=3","gravatar_id":"","url":"https://api.github.com/users/mtgred","html_url":"https://github.com/mtgred","followers_url":"https://api.github.com/users/mtgred/followers","following_url":"https://api.github.com/users/mtgred/following{/other_user}","gists_url":"https://api.github.com/users/mtgred/gists{/gist_id}","starred_url":"https://api.github.com/users/mtgred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtgred/subscriptions","organizations_url":"https://api.github.com/users/mtgred/orgs","repos_url":"https://api.github.com/users/mtgred/repos","events_url":"https://api.github.com/users/mtgred/events{/privacy}","received_events_url":"https://api.github.com/users/mtgred/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mtgred/netrunner","description":"","fork":false,"url":"https://api.github.com/repos/mtgred/netrunner","forks_url":"https://api.github.com/repos/mtgred/netrunner/forks","keys_url":"https://api.github.com/repos/mtgred/netrunner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mtgred/netrunner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mtgred/netrunner/teams","hooks_url":"https://api.github.com/repos/mtgred/netrunner/hooks","issue_events_url":"https://api.github.com/repos/mtgred/netrunner/issues/events{/number}","events_url":"https://api.github.com/repos/mtgred/netrunner/events","assignees_url":"https://api.github.com/repos/mtgred/netrunner/assignees{/user}","branches_url":"https://api.github.com/repos/mtgred/netrunner/branches{/branch}","tags_url":"https://api.github.com/repos/mtgred/netrunner/tags","blobs_url":"https://api.github.com/repos/mtgred/netrunner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mtgred/netrunner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mtgred/netrunner/git/refs{/sha}","trees_url":"https://api.github.com/repos/mtgred/netrunner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mtgred/netrunner/statuses/{sha}","languages_url":"https://api.github.com/repos/mtgred/netrunner/languages","stargazers_url":"https://api.github.com/repos/mtgred/netrunner/stargazers","contributors_url":"https://api.github.com/repos/mtgred/netrunner/contributors","subscribers_url":"https://api.github.com/repos/mtgred/netrunner/subscribers","subscription_url":"https://api.github.com/repos/mtgred/netrunner/subscription","commits_url":"https://api.github.com/repos/mtgred/netrunner/commits{/sha}","git_commits_url":"https://api.github.com/repos/mtgred/netrunner/git/commits{/sha}","comments_url":"https://api.github.com/repos/mtgred/netrunner/comments{/number}","issue_comment_url":"https://api.github.com/repos/mtgred/netrunner/issues/comments{/number}","contents_url":"https://api.github.com/repos/mtgred/netrunner/contents/{+path}","compare_url":"https://api.github.com/repos/mtgred/netrunner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mtgred/netrunner/merges","archive_url":"https://api.github.com/repos/mtgred/netrunner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mtgred/netrunner/downloads","issues_url":"https://api.github.com/repos/mtgred/netrunner/issues{/number}","pulls_url":"https://api.github.com/repos/mtgred/netrunner/pulls{/number}","milestones_url":"https://api.github.com/repos/mtgred/netrunner/milestones{/number}","notifications_url":"https://api.github.com/repos/mtgred/netrunner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mtgred/netrunner/labels{/name}","releases_url":"https://api.github.com/repos/mtgred/netrunner/releases{/id}","deployments_url":"https://api.github.com/repos/mtgred/netrunner/deployments","created_at":"2014-04-23T17:57:52Z","updated_at":"2016-06-06T05:02:33Z","pushed_at":"2016-06-09T00:18:39Z","git_url":"git://github.com/mtgred/netrunner.git","ssh_url":"git@github.com:mtgred/netrunner.git","clone_url":"https://github.com/mtgred/netrunner.git","svn_url":"https://github.com/mtgred/netrunner","homepage":"http://www.jinteki.net","size":12793,"stargazers_count":371,"watchers_count":371,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":176,"mirror_url":null,"open_issues_count":145,"forks":176,"open_issues":145,"watchers":371,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mtgred/netrunner/pulls/1559"},"html":{"href":"https://github.com/mtgred/netrunner/pull/1559"},"issue":{"href":"https://api.github.com/repos/mtgred/netrunner/issues/1559"},"comments":{"href":"https://api.github.com/repos/mtgred/netrunner/issues/1559/comments"},"review_comments":{"href":"https://api.github.com/repos/mtgred/netrunner/pulls/1559/comments"},"review_comment":{"href":"https://api.github.com/repos/mtgred/netrunner/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mtgred/netrunner/pulls/1559/commits"},"statuses":{"href":"https://api.github.com/repos/mtgred/netrunner/statuses/f4a5d3c7927c40c41a68586ce1fff99598ba5f58"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mtgred","id":284114,"avatar_url":"https://avatars.githubusercontent.com/u/284114?v=3","gravatar_id":"","url":"https://api.github.com/users/mtgred","html_url":"https://github.com/mtgred","followers_url":"https://api.github.com/users/mtgred/followers","following_url":"https://api.github.com/users/mtgred/following{/other_user}","gists_url":"https://api.github.com/users/mtgred/gists{/gist_id}","starred_url":"https://api.github.com/users/mtgred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtgred/subscriptions","organizations_url":"https://api.github.com/users/mtgred/orgs","repos_url":"https://api.github.com/users/mtgred/repos","events_url":"https://api.github.com/users/mtgred/events{/privacy}","received_events_url":"https://api.github.com/users/mtgred/received_events","type":"User","site_admin":false},"comments":11,"review_comments":0,"commits":2,"additions":180,"deletions":19,"changed_files":6}}
{"actor":{"display_login":"mtgred"}}