{"action":"closed","number":4,"pull_request":{"url":"https://api.github.com/repos/gelogenic/angular-waivers/pulls/4","id":94691893,"html_url":"https://github.com/gelogenic/angular-waivers/pull/4","diff_url":"https://github.com/gelogenic/angular-waivers/pull/4.diff","patch_url":"https://github.com/gelogenic/angular-waivers/pull/4.patch","issue_url":"https://api.github.com/repos/gelogenic/angular-waivers/issues/4","number":4,"state":"closed","locked":false,"title":"Mirror tutorial step 7 - XHR and Dependency Injection","user":{"login":"gelogenic","id":2112103,"avatar_url":"https://avatars.githubusercontent.com/u/2112103?v=3","gravatar_id":"","url":"https://api.github.com/users/gelogenic","html_url":"https://github.com/gelogenic","followers_url":"https://api.github.com/users/gelogenic/followers","following_url":"https://api.github.com/users/gelogenic/following{/other_user}","gists_url":"https://api.github.com/users/gelogenic/gists{/gist_id}","starred_url":"https://api.github.com/users/gelogenic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gelogenic/subscriptions","organizations_url":"https://api.github.com/users/gelogenic/orgs","repos_url":"https://api.github.com/users/gelogenic/repos","events_url":"https://api.github.com/users/gelogenic/events{/privacy}","received_events_url":"https://api.github.com/users/gelogenic/received_events","type":"User","site_admin":false},"body":"Mirror tutorial step 7 - XHR and Dependency Injection\r\n- Replace the in-memory dataset with data loaded from the server (in the form\r\n   of a static 'waivers_faceted.json' file to keep the backend agnostic):\r\n  - The JSON data is loaded using the `$http` service.\r\n- Demonstrate the use of `services` and `dependency injection` (DI):\r\n  - `$http` is injected into the controller through DI.\r\n  - Introduce DI annotation methods: `.$inject` and inline array\r\n- E2E tests (scenarios.js)\r\n  - commented out it('should be possible to control waiver list order via\r\n    the drop-down menu', function() {...]); }); }); until can find better \r\n    metrics across 500+ records\r\n","created_at":"2016-11-21T20:37:34Z","updated_at":"2016-11-21T20:38:01Z","closed_at":"2016-11-21T20:38:01Z","merged_at":"2016-11-21T20:38:01Z","merge_commit_sha":"b98a3fefb7578a636c1e6bc0461a5e092dc0319b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/gelogenic/angular-waivers/pulls/4/commits","review_comments_url":"https://api.github.com/repos/gelogenic/angular-waivers/pulls/4/comments","review_comment_url":"https://api.github.com/repos/gelogenic/angular-waivers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gelogenic/angular-waivers/issues/4/comments","statuses_url":"https://api.github.com/repos/gelogenic/angular-waivers/statuses/8a3f38a5452c2a89323ae7ff2e5e9283fc031e33","head":{"label":"gelogenic:working","ref":"working","sha":"8a3f38a5452c2a89323ae7ff2e5e9283fc031e33","user":{"login":"gelogenic","id":2112103,"avatar_url":"https://avatars.githubusercontent.com/u/2112103?v=3","gravatar_id":"","url":"https://api.github.com/users/gelogenic","html_url":"https://github.com/gelogenic","followers_url":"https://api.github.com/users/gelogenic/followers","following_url":"https://api.github.com/users/gelogenic/following{/other_user}","gists_url":"https://api.github.com/users/gelogenic/gists{/gist_id}","starred_url":"https://api.github.com/users/gelogenic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gelogenic/subscriptions","organizations_url":"https://api.github.com/users/gelogenic/orgs","repos_url":"https://api.github.com/users/gelogenic/repos","events_url":"https://api.github.com/users/gelogenic/events{/privacy}","received_events_url":"https://api.github.com/users/gelogenic/received_events","type":"User","site_admin":false},"repo":{"id":72472525,"name":"angular-waivers","full_name":"gelogenic/angular-waivers","owner":{"login":"gelogenic","id":2112103,"avatar_url":"https://avatars.githubusercontent.com/u/2112103?v=3","gravatar_id":"","url":"https://api.github.com/users/gelogenic","html_url":"https://github.com/gelogenic","followers_url":"https://api.github.com/users/gelogenic/followers","following_url":"https://api.github.com/users/gelogenic/following{/other_user}","gists_url":"https://api.github.com/users/gelogenic/gists{/gist_id}","starred_url":"https://api.github.com/users/gelogenic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gelogenic/subscriptions","organizations_url":"https://api.github.com/users/gelogenic/orgs","repos_url":"https://api.github.com/users/gelogenic/repos","events_url":"https://api.github.com/users/gelogenic/events{/privacy}","received_events_url":"https://api.github.com/users/gelogenic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gelogenic/angular-waivers","description":"Refactor waivers faceted search to use AngularJS","fork":false,"url":"https://api.github.com/repos/gelogenic/angular-waivers","forks_url":"https://api.github.com/repos/gelogenic/angular-waivers/forks","keys_url":"https://api.github.com/repos/gelogenic/angular-waivers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gelogenic/angular-waivers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gelogenic/angular-waivers/teams","hooks_url":"https://api.github.com/repos/gelogenic/angular-waivers/hooks","issue_events_url":"https://api.github.com/repos/gelogenic/angular-waivers/issues/events{/number}","events_url":"https://api.github.com/repos/gelogenic/angular-waivers/events","assignees_url":"https://api.github.com/repos/gelogenic/angular-waivers/assignees{/user}","branches_url":"https://api.github.com/repos/gelogenic/angular-waivers/branches{/branch}","tags_url":"https://api.github.com/repos/gelogenic/angular-waivers/tags","blobs_url":"https://api.github.com/repos/gelogenic/angular-waivers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gelogenic/angular-waivers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gelogenic/angular-waivers/git/refs{/sha}","trees_url":"https://api.github.com/repos/gelogenic/angular-waivers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gelogenic/angular-waivers/statuses/{sha}","languages_url":"https://api.github.com/repos/gelogenic/angular-waivers/languages","stargazers_url":"https://api.github.com/repos/gelogenic/angular-waivers/stargazers","contributors_url":"https://api.github.com/repos/gelogenic/angular-waivers/contributors","subscribers_url":"https://api.github.com/repos/gelogenic/angular-waivers/subscribers","subscription_url":"https://api.github.com/repos/gelogenic/angular-waivers/subscription","commits_url":"https://api.github.com/repos/gelogenic/angular-waivers/commits{/sha}","git_commits_url":"https://api.github.com/repos/gelogenic/angular-waivers/git/commits{/sha}","comments_url":"https://api.github.com/repos/gelogenic/angular-waivers/comments{/number}","issue_comment_url":"https://api.github.com/repos/gelogenic/angular-waivers/issues/comments{/number}","contents_url":"https://api.github.com/repos/gelogenic/angular-waivers/contents/{+path}","compare_url":"https://api.github.com/repos/gelogenic/angular-waivers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gelogenic/angular-waivers/merges","archive_url":"https://api.github.com/repos/gelogenic/angular-waivers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gelogenic/angular-waivers/downloads","issues_url":"https://api.github.com/repos/gelogenic/angular-waivers/issues{/number}","pulls_url":"https://api.github.com/repos/gelogenic/angular-waivers/pulls{/number}","milestones_url":"https://api.github.com/repos/gelogenic/angular-waivers/milestones{/number}","notifications_url":"https://api.github.com/repos/gelogenic/angular-waivers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gelogenic/angular-waivers/labels{/name}","releases_url":"https://api.github.com/repos/gelogenic/angular-waivers/releases{/id}","deployments_url":"https://api.github.com/repos/gelogenic/angular-waivers/deployments","created_at":"2016-10-31T19:52:42Z","updated_at":"2016-11-01T19:56:49Z","pushed_at":"2016-11-21T20:38:01Z","git_url":"git://github.com/gelogenic/angular-waivers.git","ssh_url":"git@github.com:gelogenic/angular-waivers.git","clone_url":"https://github.com/gelogenic/angular-waivers.git","svn_url":"https://github.com/gelogenic/angular-waivers","homepage":null,"size":1474,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gelogenic:master","ref":"master","sha":"cea6a266895da11b69e5beefc4a7107dff3ed73f","user":{"login":"gelogenic","id":2112103,"avatar_url":"https://avatars.githubusercontent.com/u/2112103?v=3","gravatar_id":"","url":"https://api.github.com/users/gelogenic","html_url":"https://github.com/gelogenic","followers_url":"https://api.github.com/users/gelogenic/followers","following_url":"https://api.github.com/users/gelogenic/following{/other_user}","gists_url":"https://api.github.com/users/gelogenic/gists{/gist_id}","starred_url":"https://api.github.com/users/gelogenic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gelogenic/subscriptions","organizations_url":"https://api.github.com/users/gelogenic/orgs","repos_url":"https://api.github.com/users/gelogenic/repos","events_url":"https://api.github.com/users/gelogenic/events{/privacy}","received_events_url":"https://api.github.com/users/gelogenic/received_events","type":"User","site_admin":false},"repo":{"id":72472525,"name":"angular-waivers","full_name":"gelogenic/angular-waivers","owner":{"login":"gelogenic","id":2112103,"avatar_url":"https://avatars.githubusercontent.com/u/2112103?v=3","gravatar_id":"","url":"https://api.github.com/users/gelogenic","html_url":"https://github.com/gelogenic","followers_url":"https://api.github.com/users/gelogenic/followers","following_url":"https://api.github.com/users/gelogenic/following{/other_user}","gists_url":"https://api.github.com/users/gelogenic/gists{/gist_id}","starred_url":"https://api.github.com/users/gelogenic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gelogenic/subscriptions","organizations_url":"https://api.github.com/users/gelogenic/orgs","repos_url":"https://api.github.com/users/gelogenic/repos","events_url":"https://api.github.com/users/gelogenic/events{/privacy}","received_events_url":"https://api.github.com/users/gelogenic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gelogenic/angular-waivers","description":"Refactor waivers faceted search to use AngularJS","fork":false,"url":"https://api.github.com/repos/gelogenic/angular-waivers","forks_url":"https://api.github.com/repos/gelogenic/angular-waivers/forks","keys_url":"https://api.github.com/repos/gelogenic/angular-waivers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gelogenic/angular-waivers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gelogenic/angular-waivers/teams","hooks_url":"https://api.github.com/repos/gelogenic/angular-waivers/hooks","issue_events_url":"https://api.github.com/repos/gelogenic/angular-waivers/issues/events{/number}","events_url":"https://api.github.com/repos/gelogenic/angular-waivers/events","assignees_url":"https://api.github.com/repos/gelogenic/angular-waivers/assignees{/user}","branches_url":"https://api.github.com/repos/gelogenic/angular-waivers/branches{/branch}","tags_url":"https://api.github.com/repos/gelogenic/angular-waivers/tags","blobs_url":"https://api.github.com/repos/gelogenic/angular-waivers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gelogenic/angular-waivers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gelogenic/angular-waivers/git/refs{/sha}","trees_url":"https://api.github.com/repos/gelogenic/angular-waivers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gelogenic/angular-waivers/statuses/{sha}","languages_url":"https://api.github.com/repos/gelogenic/angular-waivers/languages","stargazers_url":"https://api.github.com/repos/gelogenic/angular-waivers/stargazers","contributors_url":"https://api.github.com/repos/gelogenic/angular-waivers/contributors","subscribers_url":"https://api.github.com/repos/gelogenic/angular-waivers/subscribers","subscription_url":"https://api.github.com/repos/gelogenic/angular-waivers/subscription","commits_url":"https://api.github.com/repos/gelogenic/angular-waivers/commits{/sha}","git_commits_url":"https://api.github.com/repos/gelogenic/angular-waivers/git/commits{/sha}","comments_url":"https://api.github.com/repos/gelogenic/angular-waivers/comments{/number}","issue_comment_url":"https://api.github.com/repos/gelogenic/angular-waivers/issues/comments{/number}","contents_url":"https://api.github.com/repos/gelogenic/angular-waivers/contents/{+path}","compare_url":"https://api.github.com/repos/gelogenic/angular-waivers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gelogenic/angular-waivers/merges","archive_url":"https://api.github.com/repos/gelogenic/angular-waivers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gelogenic/angular-waivers/downloads","issues_url":"https://api.github.com/repos/gelogenic/angular-waivers/issues{/number}","pulls_url":"https://api.github.com/repos/gelogenic/angular-waivers/pulls{/number}","milestones_url":"https://api.github.com/repos/gelogenic/angular-waivers/milestones{/number}","notifications_url":"https://api.github.com/repos/gelogenic/angular-waivers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gelogenic/angular-waivers/labels{/name}","releases_url":"https://api.github.com/repos/gelogenic/angular-waivers/releases{/id}","deployments_url":"https://api.github.com/repos/gelogenic/angular-waivers/deployments","created_at":"2016-10-31T19:52:42Z","updated_at":"2016-11-01T19:56:49Z","pushed_at":"2016-11-21T20:38:01Z","git_url":"git://github.com/gelogenic/angular-waivers.git","ssh_url":"git@github.com:gelogenic/angular-waivers.git","clone_url":"https://github.com/gelogenic/angular-waivers.git","svn_url":"https://github.com/gelogenic/angular-waivers","homepage":null,"size":1474,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gelogenic/angular-waivers/pulls/4"},"html":{"href":"https://github.com/gelogenic/angular-waivers/pull/4"},"issue":{"href":"https://api.github.com/repos/gelogenic/angular-waivers/issues/4"},"comments":{"href":"https://api.github.com/repos/gelogenic/angular-waivers/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/gelogenic/angular-waivers/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/gelogenic/angular-waivers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gelogenic/angular-waivers/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/gelogenic/angular-waivers/statuses/8a3f38a5452c2a89323ae7ff2e5e9283fc031e33"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"gelogenic","id":2112103,"avatar_url":"https://avatars.githubusercontent.com/u/2112103?v=3","gravatar_id":"","url":"https://api.github.com/users/gelogenic","html_url":"https://github.com/gelogenic","followers_url":"https://api.github.com/users/gelogenic/followers","following_url":"https://api.github.com/users/gelogenic/following{/other_user}","gists_url":"https://api.github.com/users/gelogenic/gists{/gist_id}","starred_url":"https://api.github.com/users/gelogenic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gelogenic/subscriptions","organizations_url":"https://api.github.com/users/gelogenic/orgs","repos_url":"https://api.github.com/users/gelogenic/repos","events_url":"https://api.github.com/users/gelogenic/events{/privacy}","received_events_url":"https://api.github.com/users/gelogenic/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":25,"deletions":232,"changed_files":3}}
{"actor":{"display_login":"gelogenic"}}