{"action":"closed","number":993,"pull_request":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/993","id":63405981,"html_url":"https://github.com/solidusio/solidus/pull/993","diff_url":"https://github.com/solidusio/solidus/pull/993.diff","patch_url":"https://github.com/solidusio/solidus/pull/993.patch","issue_url":"https://api.github.com/repos/solidusio/solidus/issues/993","number":993,"state":"closed","locked":false,"title":"Assign a line items currency as an attribute, not an option","user":{"login":"mamhoff","id":703401,"avatar_url":"https://avatars.githubusercontent.com/u/703401?v=3","gravatar_id":"","url":"https://api.github.com/users/mamhoff","html_url":"https://github.com/mamhoff","followers_url":"https://api.github.com/users/mamhoff/followers","following_url":"https://api.github.com/users/mamhoff/following{/other_user}","gists_url":"https://api.github.com/users/mamhoff/gists{/gist_id}","starred_url":"https://api.github.com/users/mamhoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mamhoff/subscriptions","organizations_url":"https://api.github.com/users/mamhoff/orgs","repos_url":"https://api.github.com/users/mamhoff/repos","events_url":"https://api.github.com/users/mamhoff/events{/privacy}","received_events_url":"https://api.github.com/users/mamhoff/received_events","type":"User","site_admin":false},"body":"When extracting pricing to service objects I came across a number of\r\nways of setting a line item's currency. In `OrderContents`, the currency,\r\nalthough an attribute of the line item, is passed to the line item\r\nthrough an options Hash designed for an extension point introduced around\r\nSpree 2.2/2.3 while it could just be assigned directly like any other\r\nattribute.\r\n\r\nThis PR refactors that bit of weird code, hopefully relieving us of the\r\n`options=` method on line item entirely in the future.","created_at":"2016-03-18T17:03:57Z","updated_at":"2016-03-21T10:19:27Z","closed_at":"2016-03-21T10:19:26Z","merged_at":null,"merge_commit_sha":"991bb9d518549b7fee683f80d60f5c3ece714a53","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/solidusio/solidus/pulls/993/commits","review_comments_url":"https://api.github.com/repos/solidusio/solidus/pulls/993/comments","review_comment_url":"https://api.github.com/repos/solidusio/solidus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/solidusio/solidus/issues/993/comments","statuses_url":"https://api.github.com/repos/solidusio/solidus/statuses/a05f2aabd56582506493c406c7bd9be3f910c5a1","head":{"label":"magiclabs:assign-currency-as-attribute-not-option","ref":"assign-currency-as-attribute-not-option","sha":"a05f2aabd56582506493c406c7bd9be3f910c5a1","user":{"login":"magiclabs","id":714995,"avatar_url":"https://avatars.githubusercontent.com/u/714995?v=3","gravatar_id":"","url":"https://api.github.com/users/magiclabs","html_url":"https://github.com/magiclabs","followers_url":"https://api.github.com/users/magiclabs/followers","following_url":"https://api.github.com/users/magiclabs/following{/other_user}","gists_url":"https://api.github.com/users/magiclabs/gists{/gist_id}","starred_url":"https://api.github.com/users/magiclabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magiclabs/subscriptions","organizations_url":"https://api.github.com/users/magiclabs/orgs","repos_url":"https://api.github.com/users/magiclabs/repos","events_url":"https://api.github.com/users/magiclabs/events{/privacy}","received_events_url":"https://api.github.com/users/magiclabs/received_events","type":"Organization","site_admin":false},"repo":{"id":45269516,"name":"solidus","full_name":"magiclabs/solidus","owner":{"login":"magiclabs","id":714995,"avatar_url":"https://avatars.githubusercontent.com/u/714995?v=3","gravatar_id":"","url":"https://api.github.com/users/magiclabs","html_url":"https://github.com/magiclabs","followers_url":"https://api.github.com/users/magiclabs/followers","following_url":"https://api.github.com/users/magiclabs/following{/other_user}","gists_url":"https://api.github.com/users/magiclabs/gists{/gist_id}","starred_url":"https://api.github.com/users/magiclabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magiclabs/subscriptions","organizations_url":"https://api.github.com/users/magiclabs/orgs","repos_url":"https://api.github.com/users/magiclabs/repos","events_url":"https://api.github.com/users/magiclabs/events{/privacy}","received_events_url":"https://api.github.com/users/magiclabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/magiclabs/solidus","description":"Solidus, Rails eCommerce System","fork":true,"url":"https://api.github.com/repos/magiclabs/solidus","forks_url":"https://api.github.com/repos/magiclabs/solidus/forks","keys_url":"https://api.github.com/repos/magiclabs/solidus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magiclabs/solidus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magiclabs/solidus/teams","hooks_url":"https://api.github.com/repos/magiclabs/solidus/hooks","issue_events_url":"https://api.github.com/repos/magiclabs/solidus/issues/events{/number}","events_url":"https://api.github.com/repos/magiclabs/solidus/events","assignees_url":"https://api.github.com/repos/magiclabs/solidus/assignees{/user}","branches_url":"https://api.github.com/repos/magiclabs/solidus/branches{/branch}","tags_url":"https://api.github.com/repos/magiclabs/solidus/tags","blobs_url":"https://api.github.com/repos/magiclabs/solidus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magiclabs/solidus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magiclabs/solidus/git/refs{/sha}","trees_url":"https://api.github.com/repos/magiclabs/solidus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magiclabs/solidus/statuses/{sha}","languages_url":"https://api.github.com/repos/magiclabs/solidus/languages","stargazers_url":"https://api.github.com/repos/magiclabs/solidus/stargazers","contributors_url":"https://api.github.com/repos/magiclabs/solidus/contributors","subscribers_url":"https://api.github.com/repos/magiclabs/solidus/subscribers","subscription_url":"https://api.github.com/repos/magiclabs/solidus/subscription","commits_url":"https://api.github.com/repos/magiclabs/solidus/commits{/sha}","git_commits_url":"https://api.github.com/repos/magiclabs/solidus/git/commits{/sha}","comments_url":"https://api.github.com/repos/magiclabs/solidus/comments{/number}","issue_comment_url":"https://api.github.com/repos/magiclabs/solidus/issues/comments{/number}","contents_url":"https://api.github.com/repos/magiclabs/solidus/contents/{+path}","compare_url":"https://api.github.com/repos/magiclabs/solidus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magiclabs/solidus/merges","archive_url":"https://api.github.com/repos/magiclabs/solidus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magiclabs/solidus/downloads","issues_url":"https://api.github.com/repos/magiclabs/solidus/issues{/number}","pulls_url":"https://api.github.com/repos/magiclabs/solidus/pulls{/number}","milestones_url":"https://api.github.com/repos/magiclabs/solidus/milestones{/number}","notifications_url":"https://api.github.com/repos/magiclabs/solidus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magiclabs/solidus/labels{/name}","releases_url":"https://api.github.com/repos/magiclabs/solidus/releases{/id}","deployments_url":"https://api.github.com/repos/magiclabs/solidus/deployments","created_at":"2015-10-30T18:34:37Z","updated_at":"2016-01-21T21:16:31Z","pushed_at":"2016-03-21T10:14:18Z","git_url":"git://github.com/magiclabs/solidus.git","ssh_url":"git@github.com:magiclabs/solidus.git","clone_url":"https://github.com/magiclabs/solidus.git","svn_url":"https://github.com/magiclabs/solidus","homepage":"http://solidus.io/","size":66213,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"solidusio:master","ref":"master","sha":"370dd0be77d2f0b22e74c9ac7132914a9c4f58bc","user":{"login":"solidusio","id":11045486,"avatar_url":"https://avatars.githubusercontent.com/u/11045486?v=3","gravatar_id":"","url":"https://api.github.com/users/solidusio","html_url":"https://github.com/solidusio","followers_url":"https://api.github.com/users/solidusio/followers","following_url":"https://api.github.com/users/solidusio/following{/other_user}","gists_url":"https://api.github.com/users/solidusio/gists{/gist_id}","starred_url":"https://api.github.com/users/solidusio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solidusio/subscriptions","organizations_url":"https://api.github.com/users/solidusio/orgs","repos_url":"https://api.github.com/users/solidusio/repos","events_url":"https://api.github.com/users/solidusio/events{/privacy}","received_events_url":"https://api.github.com/users/solidusio/received_events","type":"Organization","site_admin":false},"repo":{"id":30985840,"name":"solidus","full_name":"solidusio/solidus","owner":{"login":"solidusio","id":11045486,"avatar_url":"https://avatars.githubusercontent.com/u/11045486?v=3","gravatar_id":"","url":"https://api.github.com/users/solidusio","html_url":"https://github.com/solidusio","followers_url":"https://api.github.com/users/solidusio/followers","following_url":"https://api.github.com/users/solidusio/following{/other_user}","gists_url":"https://api.github.com/users/solidusio/gists{/gist_id}","starred_url":"https://api.github.com/users/solidusio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solidusio/subscriptions","organizations_url":"https://api.github.com/users/solidusio/orgs","repos_url":"https://api.github.com/users/solidusio/repos","events_url":"https://api.github.com/users/solidusio/events{/privacy}","received_events_url":"https://api.github.com/users/solidusio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/solidusio/solidus","description":"Solidus, Rails eCommerce System","fork":false,"url":"https://api.github.com/repos/solidusio/solidus","forks_url":"https://api.github.com/repos/solidusio/solidus/forks","keys_url":"https://api.github.com/repos/solidusio/solidus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/solidusio/solidus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/solidusio/solidus/teams","hooks_url":"https://api.github.com/repos/solidusio/solidus/hooks","issue_events_url":"https://api.github.com/repos/solidusio/solidus/issues/events{/number}","events_url":"https://api.github.com/repos/solidusio/solidus/events","assignees_url":"https://api.github.com/repos/solidusio/solidus/assignees{/user}","branches_url":"https://api.github.com/repos/solidusio/solidus/branches{/branch}","tags_url":"https://api.github.com/repos/solidusio/solidus/tags","blobs_url":"https://api.github.com/repos/solidusio/solidus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/solidusio/solidus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/solidusio/solidus/git/refs{/sha}","trees_url":"https://api.github.com/repos/solidusio/solidus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/solidusio/solidus/statuses/{sha}","languages_url":"https://api.github.com/repos/solidusio/solidus/languages","stargazers_url":"https://api.github.com/repos/solidusio/solidus/stargazers","contributors_url":"https://api.github.com/repos/solidusio/solidus/contributors","subscribers_url":"https://api.github.com/repos/solidusio/solidus/subscribers","subscription_url":"https://api.github.com/repos/solidusio/solidus/subscription","commits_url":"https://api.github.com/repos/solidusio/solidus/commits{/sha}","git_commits_url":"https://api.github.com/repos/solidusio/solidus/git/commits{/sha}","comments_url":"https://api.github.com/repos/solidusio/solidus/comments{/number}","issue_comment_url":"https://api.github.com/repos/solidusio/solidus/issues/comments{/number}","contents_url":"https://api.github.com/repos/solidusio/solidus/contents/{+path}","compare_url":"https://api.github.com/repos/solidusio/solidus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/solidusio/solidus/merges","archive_url":"https://api.github.com/repos/solidusio/solidus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/solidusio/solidus/downloads","issues_url":"https://api.github.com/repos/solidusio/solidus/issues{/number}","pulls_url":"https://api.github.com/repos/solidusio/solidus/pulls{/number}","milestones_url":"https://api.github.com/repos/solidusio/solidus/milestones{/number}","notifications_url":"https://api.github.com/repos/solidusio/solidus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/solidusio/solidus/labels{/name}","releases_url":"https://api.github.com/repos/solidusio/solidus/releases{/id}","deployments_url":"https://api.github.com/repos/solidusio/solidus/deployments","created_at":"2015-02-18T20:41:58Z","updated_at":"2016-03-20T12:17:53Z","pushed_at":"2016-03-21T10:14:18Z","git_url":"git://github.com/solidusio/solidus.git","ssh_url":"git@github.com:solidusio/solidus.git","clone_url":"https://github.com/solidusio/solidus.git","svn_url":"https://github.com/solidusio/solidus","homepage":"http://solidus.io/","size":68168,"stargazers_count":851,"watchers_count":851,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":217,"mirror_url":null,"open_issues_count":110,"forks":217,"open_issues":110,"watchers":851,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/993"},"html":{"href":"https://github.com/solidusio/solidus/pull/993"},"issue":{"href":"https://api.github.com/repos/solidusio/solidus/issues/993"},"comments":{"href":"https://api.github.com/repos/solidusio/solidus/issues/993/comments"},"review_comments":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/993/comments"},"review_comment":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/993/commits"},"statuses":{"href":"https://api.github.com/repos/solidusio/solidus/statuses/a05f2aabd56582506493c406c7bd9be3f910c5a1"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":10,"deletions":13,"changed_files":2}}