{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/16471","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16471/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16471/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16471/events","html_url":"https://github.com/cms-sw/cmssw/pull/16471","id":187340186,"number":16471,"title":"CTPPS: raw-to-digi for diamond detectors","user":{"login":"jan-kaspar","id":17830858,"avatar_url":"https://avatars.githubusercontent.com/u/17830858?v=3","gravatar_id":"","url":"https://api.github.com/users/jan-kaspar","html_url":"https://github.com/jan-kaspar","followers_url":"https://api.github.com/users/jan-kaspar/followers","following_url":"https://api.github.com/users/jan-kaspar/following{/other_user}","gists_url":"https://api.github.com/users/jan-kaspar/gists{/gist_id}","starred_url":"https://api.github.com/users/jan-kaspar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jan-kaspar/subscriptions","organizations_url":"https://api.github.com/users/jan-kaspar/orgs","repos_url":"https://api.github.com/users/jan-kaspar/repos","events_url":"https://api.github.com/users/jan-kaspar/events{/privacy}","received_events_url":"https://api.github.com/users/jan-kaspar/received_events","type":"User","site_admin":false},"labels":[{"id":52881463,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/alca-pending","name":"alca-pending","color":"fbca04","default":false},{"id":88645479,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"009800","default":false},{"id":52881476,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/daq-pending","name":"daq-pending","color":"fbca04","default":false},{"id":52881671,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/db-pending","name":"db-pending","color":"fbca04","default":false},{"id":52820549,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/dqm-pending","name":"dqm-pending","color":"fbca04","default":false},{"id":52881721,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/geometry-pending","name":"geometry-pending","color":"fbca04","default":false},{"id":69634213,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/new-package-pending","name":"new-package-pending","color":"e11d21","default":false},{"id":52881747,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/operations-pending","name":"operations-pending","color":"fbca04","default":false},{"id":56953091,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420","default":false},{"id":52882429,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-approved","name":"reconstruction-approved","color":"009800","default":false},{"id":52820523,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/simulation-pending","name":"simulation-pending","color":"fbca04","default":false},{"id":56131195,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_1_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59/labels","id":1590252,"number":59,"title":"Next CMSSW_8_1_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":45,"closed_issues":1966,"state":"open","created_at":"2016-02-18T09:12:12Z","updated_at":"2016-11-25T11:17:58Z","due_on":"2016-11-26T00:00:00Z","closed_at":null},"comments":55,"created_at":"2016-11-04T13:58:51Z","updated_at":"2016-11-25T13:07:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/16471","html_url":"https://github.com/cms-sw/cmssw/pull/16471","diff_url":"https://github.com/cms-sw/cmssw/pull/16471.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/16471.patch"},"body":"Changes to include raw-to-digi code for the diamond detectors of CTPPS.\r\n\r\n * Built on top of #16010 .\r\n * Added `CTPPSDiamondDigi` class.\r\n * Added XML files with \"cabling\" mapping for diamonds.\r\n * \"Cabling\" mapping stored in EventSetup separately for each CTPPS subdetector.\r\n * Added `RawToDigiConverter::Run` for diamonds.\r\n * Added `ctppsRawToDigi` sequence to include all CTPPS modules with proper configuration.\r\n * Updated `EventContent` to include also the diamond products.\r\n * Added event counter to the `TotemVFATStatus` for DQM and debugging.\r\n\r\nBelow, a summary of tests performed.\r\n\r\nllvm-analyzer: no warnings in CTPPS code.\r\n\r\nCTPPS configs:\r\n * EventFilter/CTPPSRawToDigi/test/test_standard_sequence_cfg.py\r\n * RecoCTPPS/Configuration/test/raw_data_test.py\r\n * DQM/CTPPS/test/dqm_test_cfg.py\r\n\r\nSi strip reconstruction (local tracks), one reference run\r\n * identical before and after: http://jkaspar.web.cern.ch/jkaspar/share/github/cmp.pdf\r\n\r\nGlobal CMSSW configs:\r\n * DQM/Integration/python/clients/ctpps_dqm_sourceclient-live_cfg.py\r\n * Configuration/StandardSequences/python/RawToDigi_cff.py\r\n   * tested to include the right CTPPS modules given the Run2_2016 era\r\n * Configuration/StandardSequences/python/Reconstruction_cff.py\r\n   * tested to include the right CTPPS modules given the Run2_2016 era\r\n\r\nMatrix test\r\n * `runTheMatrix.py -l limited` yielded:\r\n   * 14 14 13 11 7 1 1 1 tests passed, 0 0 0 0 0 0 0 0 failed"},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/262954238","html_url":"https://github.com/cms-sw/cmssw/pull/16471#issuecomment-262954238","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16471","id":262954238,"user":{"login":"slava77","id":4676718,"avatar_url":"https://avatars.githubusercontent.com/u/4676718?v=3","gravatar_id":"","url":"https://api.github.com/users/slava77","html_url":"https://github.com/slava77","followers_url":"https://api.github.com/users/slava77/followers","following_url":"https://api.github.com/users/slava77/following{/other_user}","gists_url":"https://api.github.com/users/slava77/gists{/gist_id}","starred_url":"https://api.github.com/users/slava77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slava77/subscriptions","organizations_url":"https://api.github.com/users/slava77/orgs","repos_url":"https://api.github.com/users/slava77/repos","events_url":"https://api.github.com/users/slava77/events{/privacy}","received_events_url":"https://api.github.com/users/slava77/received_events","type":"User","site_admin":false},"created_at":"2016-11-25T13:07:20Z","updated_at":"2016-11-25T13:07:20Z","body":"90 bytes/event in CTPPSDiamondDigiedmDetSetVector_ctppsDiamondRawToDigi_TimingDiamond\r\nis it a normal occupancy?\r\nHow many objects do we have there or is this 90bytes just empty collections?\r\nI'm just trying to understand that we tested files with actual diamonds data."}}
{"actor":{"display_login":"slava77"}}