{"action":"created","issue":{"url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/issues/1183","repository_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push","labels_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/issues/1183/labels{/name}","comments_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/issues/1183/comments","events_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/issues/1183/events","html_url":"https://github.com/phonegap/phonegap-plugin-push/pull/1183","id":173702363,"number":1183,"title":"Update plugin to use GCM Cocoapods <framework> reference in plugin.xml","user":{"login":"shazron","id":36107,"avatar_url":"https://avatars.githubusercontent.com/u/36107?v=3","gravatar_id":"","url":"https://api.github.com/users/shazron","html_url":"https://github.com/shazron","followers_url":"https://api.github.com/users/shazron/followers","following_url":"https://api.github.com/users/shazron/following{/other_user}","gists_url":"https://api.github.com/users/shazron/gists{/gist_id}","starred_url":"https://api.github.com/users/shazron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shazron/subscriptions","organizations_url":"https://api.github.com/users/shazron/orgs","repos_url":"https://api.github.com/users/shazron/repos","events_url":"https://api.github.com/users/shazron/events{/privacy}","received_events_url":"https://api.github.com/users/shazron/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2016-08-29T06:04:14Z","updated_at":"2016-09-09T21:38:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/pulls/1183","html_url":"https://github.com/phonegap/phonegap-plugin-push/pull/1183","diff_url":"https://github.com/phonegap/phonegap-plugin-push/pull/1183.diff","patch_url":"https://github.com/phonegap/phonegap-plugin-push/pull/1183.patch"},"body":"## Description\r\nThis PR is to remove inclusion of GCM inside this plugin, and replace it Instead with a <framework> reference to the Cocoapod itself. A future version of the cordova-cli and the cordova-ios platform will support this new Cocoapod <framework> reference. \r\n\r\n## Motivation and Context\r\nThis change facilitates easy updates of GCM in this plugin.\r\n\r\n## How Has This Been Tested?\r\nNote that `pod setup` will clone a repo that is 475MB in size, so it might take a while.\r\n\r\n**Test only with the cli nightlies starting with the nightly released on Monday Sept 5th 8PM PDT or install the `cordova-ios` platform from the git repo direct**\r\n\r\n```\r\nsudo gem install cocoapods\r\npod setup --verbose\r\nnpm install -g cordova@nightly\r\ncordova create test test test\r\ncd test\r\ncordova platform add ios\r\ncordova plugin add https://github.com/shazron/phonegap-plugin-push.git#gcm-cocoapod-support --variable SENDER_ID=xxxTestingxxx\r\ncordova build\r\n```\r\n\r\nAfter testing, to revert to your original Cordova CLI or the latest:\r\n```\r\nnpm install -g cordova@latest\r\nOR\r\nnpm install -g cordova@VERSION\r\n```\r\nwhere VERSION is your specific version.\r\n\r\n## Types of changes\r\n- [x] New feature (non-breaking change which adds functionality)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [x] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly ('with no dependency on any other plugins.' is not true anymore)\r\n- [x] I have read the **CONTRIBUTING** document.\r\n- [x] All new and existing tests passed.\r\n- [x] Add cordovaDependencies key in package.json http://cordova.apache.org/docs/en/latest/guide/hybrid/plugins/index.html#specifying-cordova-dependencies\r\n- [x] Add engine element to plugin.xml http://cordova.apache.org/docs/en/latest/plugin_ref/spec.html#engines-and-engine\r\n\r\nThis is a packaging change, no new tests need to be added.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/issues/comments/246047769","html_url":"https://github.com/phonegap/phonegap-plugin-push/pull/1183#issuecomment-246047769","issue_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/issues/1183","id":246047769,"user":{"login":"shazron","id":36107,"avatar_url":"https://avatars.githubusercontent.com/u/36107?v=3","gravatar_id":"","url":"https://api.github.com/users/shazron","html_url":"https://github.com/shazron","followers_url":"https://api.github.com/users/shazron/followers","following_url":"https://api.github.com/users/shazron/following{/other_user}","gists_url":"https://api.github.com/users/shazron/gists{/gist_id}","starred_url":"https://api.github.com/users/shazron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shazron/subscriptions","organizations_url":"https://api.github.com/users/shazron/orgs","repos_url":"https://api.github.com/users/shazron/repos","events_url":"https://api.github.com/users/shazron/events{/privacy}","received_events_url":"https://api.github.com/users/shazron/received_events","type":"User","site_admin":false},"created_at":"2016-09-09T21:38:29Z","updated_at":"2016-09-09T21:38:29Z","body":"Ok docs updated for CocoaPods support. Have a look."}}
{"actor":{"display_login":"shazron"}}