{"action":"created","issue":{"url":"https://api.github.com/repos/concubidated/simply-love-openitg/issues/1","repository_url":"https://api.github.com/repos/concubidated/simply-love-openitg","labels_url":"https://api.github.com/repos/concubidated/simply-love-openitg/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/concubidated/simply-love-openitg/issues/1/comments","events_url":"https://api.github.com/repos/concubidated/simply-love-openitg/issues/1/events","html_url":"https://github.com/concubidated/simply-love-openitg/issues/1","id":156385352,"number":1,"title":"Not saving last played song score correctly.","user":{"login":"doublesbrian","id":5795613,"avatar_url":"https://avatars.githubusercontent.com/u/5795613?v=3","gravatar_id":"","url":"https://api.github.com/users/doublesbrian","html_url":"https://github.com/doublesbrian","followers_url":"https://api.github.com/users/doublesbrian/followers","following_url":"https://api.github.com/users/doublesbrian/following{/other_user}","gists_url":"https://api.github.com/users/doublesbrian/gists{/gist_id}","starred_url":"https://api.github.com/users/doublesbrian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doublesbrian/subscriptions","organizations_url":"https://api.github.com/users/doublesbrian/orgs","repos_url":"https://api.github.com/users/doublesbrian/repos","events_url":"https://api.github.com/users/doublesbrian/events{/privacy}","received_events_url":"https://api.github.com/users/doublesbrian/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-05-23T23:00:30Z","updated_at":"2016-07-15T02:41:49Z","closed_at":null,"body":"Hello!\r\n\r\nOne of the biggest issues I've had with Simply Love on openITG is that it doesn't save the score on the last song played properly.\r\n\r\nI tried your build hoping it'd fix it but it has the same error.\r\n\r\nWasn't sure if you'd be willing to take a peek at it?\r\n\r\nI'm using openitg beta 2.\r\n\r\nBasically if you play a 3 song set, the last song in the set will not save the score correctly. This is really bothersome when the person gets the #1 score on the song. What happens it seems to save the score twice but the 2nd time it saves it it kind of keeps name entry open.\r\n\r\nFor example:\r\nIf you're playing 2nd player and you get a score of 99.0% on the last song and it's the #1 score. It will input 2 scores. The top score will be 99.0% and will show #p2#(The place holder for a score before you put your name in) and the second score with the same date and time will be your initials correctly. If you choose the same song next set, even if you do not beat your score(you can even fail immediately), it will ask you to put your name in and it will correctly update.\r\n\r\nAny chance you know what could be causing this and solve it?\r\n\r\nThanks.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/concubidated/simply-love-openitg/issues/comments/232846430","html_url":"https://github.com/concubidated/simply-love-openitg/issues/1#issuecomment-232846430","issue_url":"https://api.github.com/repos/concubidated/simply-love-openitg/issues/1","id":232846430,"user":{"login":"concubidated","id":1231328,"avatar_url":"https://avatars.githubusercontent.com/u/1231328?v=3","gravatar_id":"","url":"https://api.github.com/users/concubidated","html_url":"https://github.com/concubidated","followers_url":"https://api.github.com/users/concubidated/followers","following_url":"https://api.github.com/users/concubidated/following{/other_user}","gists_url":"https://api.github.com/users/concubidated/gists{/gist_id}","starred_url":"https://api.github.com/users/concubidated/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concubidated/subscriptions","organizations_url":"https://api.github.com/users/concubidated/orgs","repos_url":"https://api.github.com/users/concubidated/repos","events_url":"https://api.github.com/users/concubidated/events{/privacy}","received_events_url":"https://api.github.com/users/concubidated/received_events","type":"User","site_admin":false},"created_at":"2016-07-15T02:41:48Z","updated_at":"2016-07-15T02:41:48Z","body":"I'll try moving the function towards the end of the Evaluation function and\nsee if that helps. The ends are correct though, one is for the for loop\nwhile the other is for the if conditional.\n\nI can test this weekend.\n\nOn Thu, Jul 14, 2016 at 6:18 PM, Xaero252 <notifications@github.com> wrote:\n\n> I think lua is probably barfing on AddScoreToListFromEval() and not\n> running the second and third calls in the Evaluation() function. I don't\n> have a good way to test right now, but I think if you simply move\n> AddScoreToListFromEval() as the third function instead of the first,\n> everything should fire.\n> As far as why things might be happening, I see way too many \"end\"\n> statements in AddScoreToListFromEval() for the number of nested loops and\n> conditionals.\n> Specifically see here:\n>\n> https://github.com/concubidated/simply-love-openitg/blob/master/Scripts/Mods.lua#L526-L532\n> I think line 532 should only have one end statement but I'm not completely\n> fluent, matching loops and conditionals to end statements makes that one\n> too many statement right there. I'll test this and see if it actually fixes\n> things at some point, you're free to as well.\n>\n> —\n> You are receiving this because you commented.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/concubidated/simply-love-openitg/issues/1#issuecomment-232836556>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/ABLJ4BYkIqABE5e3kHjqsvtNSAvo1n5rks5qVt_ogaJpZM4Ik9TT>\n> .\n>\n\n\n\n-- \n\nTyler Brekke\nStorage Consultant\nGlobal Storage Consulting\nRed Hat, Inc.\ntbrekke@redhat.com\n"}}
{"actor":{"display_login":"concubidated"}}