{"action":"created","comment":{"url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/pulls/comments/93409068","pull_request_review_id":13934539,"id":93409068,"diff_hunk":"@@ -20,29 +20,29 @@ Feature: Delay of a document sequence\n     # Negative value should really throw an exception\n     | 00:00:10.0 | -00:00:00  | 00:00:10.0         |  \n \n-#TODO: test that the order of documents in the input and output sequence is the same (FIFO) \n+#TODO: test that the order of documents in the input and output sequence is the same (FIFO)\n \n \n   #TBC: this is a change to the spec (passive delay node)\n   @skip\n-  Scenario: Implicitly timed document unchanged sequence identifier \n+  Scenario: BufferDelayNode, unchanged sequence identifier\n     Given an xml file <xml_file>\n     And the document is generated\n     And sequence identifier <sequence_id_1>\n     When the delay node delays it by <delay>\n     Then the delayed document has <sequence_id_2>\n \n     Examples:\n-    | sequence_id_1 | delay      | sequence_id_2 |  \n-    | 1             | 00:00:02.0 | 1             |  \n-    | xxx           | 00:00:00   | xxx           |  \n-    | 99999999999   | 99:00:00   | 99999999999   | \n+    | sequence_id_1 | delay      | sequence_id_2 |\n+    | 1             | 00:00:02.0 | 1             |\n+    | xxx           | 00:00:00   | xxx           |\n+    | 99999999999   | 99:00:00   | 99999999999   |\n     # No document generated for negative delay\n     | 1             | -00:00:01  |               |","path":"testing/bdd/features/timing/delay.feature","position":41,"original_position":37,"commit_id":"c7be5945e72d91cba24d9a8848e9b408e2d3e87e","original_commit_id":"c7be5945e72d91cba24d9a8848e9b408e2d3e87e","user":{"login":"kozmaz87","id":4070837,"avatar_url":"https://avatars.githubusercontent.com/u/4070837?v=3","gravatar_id":"","url":"https://api.github.com/users/kozmaz87","html_url":"https://github.com/kozmaz87","followers_url":"https://api.github.com/users/kozmaz87/followers","following_url":"https://api.github.com/users/kozmaz87/following{/other_user}","gists_url":"https://api.github.com/users/kozmaz87/gists{/gist_id}","starred_url":"https://api.github.com/users/kozmaz87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kozmaz87/subscriptions","organizations_url":"https://api.github.com/users/kozmaz87/orgs","repos_url":"https://api.github.com/users/kozmaz87/repos","events_url":"https://api.github.com/users/kozmaz87/events{/privacy}","received_events_url":"https://api.github.com/users/kozmaz87/received_events","type":"User","site_admin":false},"body":"It is indeed in an odd place to check for the negative delay things","created_at":"2016-12-21T10:06:37Z","updated_at":"2016-12-21T10:06:37Z","html_url":"https://github.com/ebu/ebu-tt-live-toolkit/pull/301#discussion_r93409068","pull_request_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/pulls/301","_links":{"self":{"href":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/pulls/comments/93409068"},"html":{"href":"https://github.com/ebu/ebu-tt-live-toolkit/pull/301#discussion_r93409068"},"pull_request":{"href":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/pulls/301"}}},"pull_request":{"url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/pulls/301","id":98577101,"html_url":"https://github.com/ebu/ebu-tt-live-toolkit/pull/301","diff_url":"https://github.com/ebu/ebu-tt-live-toolkit/pull/301.diff","patch_url":"https://github.com/ebu/ebu-tt-live-toolkit/pull/301.patch","issue_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/issues/301","number":301,"state":"open","locked":false,"title":"Malik/issue 291 implicit explicit conversion","user":{"login":"malikbeytrison","id":17120997,"avatar_url":"https://avatars.githubusercontent.com/u/17120997?v=3","gravatar_id":"","url":"https://api.github.com/users/malikbeytrison","html_url":"https://github.com/malikbeytrison","followers_url":"https://api.github.com/users/malikbeytrison/followers","following_url":"https://api.github.com/users/malikbeytrison/following{/other_user}","gists_url":"https://api.github.com/users/malikbeytrison/gists{/gist_id}","starred_url":"https://api.github.com/users/malikbeytrison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malikbeytrison/subscriptions","organizations_url":"https://api.github.com/users/malikbeytrison/orgs","repos_url":"https://api.github.com/users/malikbeytrison/repos","events_url":"https://api.github.com/users/malikbeytrison/events{/privacy}","received_events_url":"https://api.github.com/users/malikbeytrison/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-12-19T14:44:40Z","updated_at":"2016-12-21T10:06:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a92a16c76ae2b476c20b8f98689bf479c62b81c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/pulls/301/commits","review_comments_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/pulls/301/comments","review_comment_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/issues/301/comments","statuses_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/statuses/c7be5945e72d91cba24d9a8848e9b408e2d3e87e","head":{"label":"ebu:malik/issue-291-implicit-explicit-conversion","ref":"malik/issue-291-implicit-explicit-conversion","sha":"c7be5945e72d91cba24d9a8848e9b408e2d3e87e","user":{"login":"ebu","id":2692549,"avatar_url":"https://avatars.githubusercontent.com/u/2692549?v=3","gravatar_id":"","url":"https://api.github.com/users/ebu","html_url":"https://github.com/ebu","followers_url":"https://api.github.com/users/ebu/followers","following_url":"https://api.github.com/users/ebu/following{/other_user}","gists_url":"https://api.github.com/users/ebu/gists{/gist_id}","starred_url":"https://api.github.com/users/ebu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebu/subscriptions","organizations_url":"https://api.github.com/users/ebu/orgs","repos_url":"https://api.github.com/users/ebu/repos","events_url":"https://api.github.com/users/ebu/events{/privacy}","received_events_url":"https://api.github.com/users/ebu/received_events","type":"Organization","site_admin":false},"repo":{"id":49490064,"name":"ebu-tt-live-toolkit","full_name":"ebu/ebu-tt-live-toolkit","owner":{"login":"ebu","id":2692549,"avatar_url":"https://avatars.githubusercontent.com/u/2692549?v=3","gravatar_id":"","url":"https://api.github.com/users/ebu","html_url":"https://github.com/ebu","followers_url":"https://api.github.com/users/ebu/followers","following_url":"https://api.github.com/users/ebu/following{/other_user}","gists_url":"https://api.github.com/users/ebu/gists{/gist_id}","starred_url":"https://api.github.com/users/ebu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebu/subscriptions","organizations_url":"https://api.github.com/users/ebu/orgs","repos_url":"https://api.github.com/users/ebu/repos","events_url":"https://api.github.com/users/ebu/events{/privacy}","received_events_url":"https://api.github.com/users/ebu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ebu/ebu-tt-live-toolkit","description":null,"fork":false,"url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit","forks_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/forks","keys_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/teams","hooks_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/hooks","issue_events_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/events","assignees_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/tags","blobs_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/languages","stargazers_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/stargazers","contributors_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/contributors","subscribers_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/subscribers","subscription_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/subscription","commits_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/merges","archive_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/downloads","issues_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/labels{/name}","releases_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/releases{/id}","deployments_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/deployments","created_at":"2016-01-12T09:41:21Z","updated_at":"2016-10-25T16:39:50Z","pushed_at":"2016-12-21T09:57:15Z","git_url":"git://github.com/ebu/ebu-tt-live-toolkit.git","ssh_url":"git@github.com:ebu/ebu-tt-live-toolkit.git","clone_url":"https://github.com/ebu/ebu-tt-live-toolkit.git","svn_url":"https://github.com/ebu/ebu-tt-live-toolkit","homepage":null,"size":89402,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":85,"forks":5,"open_issues":85,"watchers":6,"default_branch":"master"}},"base":{"label":"ebu:master","ref":"master","sha":"7b149dd4f9f7bb29be9e3e59aab60d5e9280923a","user":{"login":"ebu","id":2692549,"avatar_url":"https://avatars.githubusercontent.com/u/2692549?v=3","gravatar_id":"","url":"https://api.github.com/users/ebu","html_url":"https://github.com/ebu","followers_url":"https://api.github.com/users/ebu/followers","following_url":"https://api.github.com/users/ebu/following{/other_user}","gists_url":"https://api.github.com/users/ebu/gists{/gist_id}","starred_url":"https://api.github.com/users/ebu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebu/subscriptions","organizations_url":"https://api.github.com/users/ebu/orgs","repos_url":"https://api.github.com/users/ebu/repos","events_url":"https://api.github.com/users/ebu/events{/privacy}","received_events_url":"https://api.github.com/users/ebu/received_events","type":"Organization","site_admin":false},"repo":{"id":49490064,"name":"ebu-tt-live-toolkit","full_name":"ebu/ebu-tt-live-toolkit","owner":{"login":"ebu","id":2692549,"avatar_url":"https://avatars.githubusercontent.com/u/2692549?v=3","gravatar_id":"","url":"https://api.github.com/users/ebu","html_url":"https://github.com/ebu","followers_url":"https://api.github.com/users/ebu/followers","following_url":"https://api.github.com/users/ebu/following{/other_user}","gists_url":"https://api.github.com/users/ebu/gists{/gist_id}","starred_url":"https://api.github.com/users/ebu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebu/subscriptions","organizations_url":"https://api.github.com/users/ebu/orgs","repos_url":"https://api.github.com/users/ebu/repos","events_url":"https://api.github.com/users/ebu/events{/privacy}","received_events_url":"https://api.github.com/users/ebu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ebu/ebu-tt-live-toolkit","description":null,"fork":false,"url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit","forks_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/forks","keys_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/teams","hooks_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/hooks","issue_events_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/events","assignees_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/tags","blobs_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/languages","stargazers_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/stargazers","contributors_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/contributors","subscribers_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/subscribers","subscription_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/subscription","commits_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/merges","archive_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/downloads","issues_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/labels{/name}","releases_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/releases{/id}","deployments_url":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/deployments","created_at":"2016-01-12T09:41:21Z","updated_at":"2016-10-25T16:39:50Z","pushed_at":"2016-12-21T09:57:15Z","git_url":"git://github.com/ebu/ebu-tt-live-toolkit.git","ssh_url":"git@github.com:ebu/ebu-tt-live-toolkit.git","clone_url":"https://github.com/ebu/ebu-tt-live-toolkit.git","svn_url":"https://github.com/ebu/ebu-tt-live-toolkit","homepage":null,"size":89402,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":85,"forks":5,"open_issues":85,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/pulls/301"},"html":{"href":"https://github.com/ebu/ebu-tt-live-toolkit/pull/301"},"issue":{"href":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/issues/301"},"comments":{"href":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/issues/301/comments"},"review_comments":{"href":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/pulls/301/comments"},"review_comment":{"href":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/pulls/301/commits"},"statuses":{"href":"https://api.github.com/repos/ebu/ebu-tt-live-toolkit/statuses/c7be5945e72d91cba24d9a8848e9b408e2d3e87e"}}}}
{"actor":{"display_login":"kozmaz87"}}