{"action":"created","issue":{"url":"https://api.github.com/repos/OCA/connector/issues/188","repository_url":"https://api.github.com/repos/OCA/connector","labels_url":"https://api.github.com/repos/OCA/connector/issues/188/labels{/name}","comments_url":"https://api.github.com/repos/OCA/connector/issues/188/comments","events_url":"https://api.github.com/repos/OCA/connector/issues/188/events","html_url":"https://github.com/OCA/connector/pull/188","id":146615441,"number":188,"title":"8.0 manage invalid data error","user":{"login":"gfcapalbo","id":8994879,"avatar_url":"https://avatars.githubusercontent.com/u/8994879?v=3","gravatar_id":"","url":"https://api.github.com/users/gfcapalbo","html_url":"https://github.com/gfcapalbo","followers_url":"https://api.github.com/users/gfcapalbo/followers","following_url":"https://api.github.com/users/gfcapalbo/following{/other_user}","gists_url":"https://api.github.com/users/gfcapalbo/gists{/gist_id}","starred_url":"https://api.github.com/users/gfcapalbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfcapalbo/subscriptions","organizations_url":"https://api.github.com/users/gfcapalbo/orgs","repos_url":"https://api.github.com/users/gfcapalbo/repos","events_url":"https://api.github.com/users/gfcapalbo/events{/privacy}","received_events_url":"https://api.github.com/users/gfcapalbo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-04-07T13:00:31Z","updated_at":"2016-04-11T07:52:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OCA/connector/pulls/188","html_url":"https://github.com/OCA/connector/pull/188","diff_url":"https://github.com/OCA/connector/pull/188.diff","patch_url":"https://github.com/OCA/connector/pull/188.patch"},"body":"\r\n\r\nProblem:\r\nI would have many jobs stuck in start. THese jobs Had all raised InvalidDataError.\r\nStrangely the Exception was not catched in main.py, but the generic\r\n\r\nTherefore the store function that had to write my failed job would never trigger\r\n\r\nWhen explicitly importing InvalidDataError, the exception was catched (see commit\r\n\r\ngfcapalbo@5b77f3c)\r\n\r\nI replaced except (FailedJobError, InvaliDataError, Exception):\r\n\r\nwith\r\nexcept:\r\n\r\nI am still not sure why this works for me, but it seems OK to set ALL of the forseeable exceptions to fail jobs.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/OCA/connector/issues/comments/208211030","html_url":"https://github.com/OCA/connector/pull/188#issuecomment-208211030","issue_url":"https://api.github.com/repos/OCA/connector/issues/188","id":208211030,"user":{"login":"sbidoul","id":692075,"avatar_url":"https://avatars.githubusercontent.com/u/692075?v=3","gravatar_id":"","url":"https://api.github.com/users/sbidoul","html_url":"https://github.com/sbidoul","followers_url":"https://api.github.com/users/sbidoul/followers","following_url":"https://api.github.com/users/sbidoul/following{/other_user}","gists_url":"https://api.github.com/users/sbidoul/gists{/gist_id}","starred_url":"https://api.github.com/users/sbidoul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbidoul/subscriptions","organizations_url":"https://api.github.com/users/sbidoul/orgs","repos_url":"https://api.github.com/users/sbidoul/repos","events_url":"https://api.github.com/users/sbidoul/events{/privacy}","received_events_url":"https://api.github.com/users/sbidoul/received_events","type":"User","site_admin":false},"created_at":"2016-04-11T07:52:05Z","updated_at":"2016-04-11T07:52:05Z","body":"@guewen \r\n\r\n```python\r\n>>> isinstance(RuntimeError(), Exception)\r\nTrue\r\n```\r\n\r\nSo it must be something else, no?"}}