{"action":"created","comment":{"url":"https://api.github.com/repos/Barteks2x/CubicChunks/pulls/comments/80136573","id":80136573,"diff_hunk":"@@ -45,26 +44,26 @@ public void columnSkylightUpdate(UpdateType type, Column column, int localX, int\n \t\tint blockZ = Coords.localToBlock(column.getZ(), localZ);\n \t\tswitch (type) {\n \t\t\tcase IMMEDIATE:\n-\t\t\t\tSet<Integer> toDiffuse = SkyLightUpdateCubeSelector.getCubesY(column, localX, localZ, minY, maxY);\n-\t\t\t\tfor (int cubeY : toDiffuse) {\n-\t\t\t\t\tboolean success = SkyLightCubeDiffuseCalculator.calculate(column, localX, localZ, cubeY);\n+\t\t\t\tIntSet toDiffuse = SkyLightUpdateCubeSelector.getCubesY(column, localX, localZ, minY, maxY);\n+\t\t\t\tfor (IntCursor cubeY : toDiffuse) {\n+\t\t\t\t\tboolean success = SkyLightCubeDiffuseCalculator.calculate(column, localX, localZ, cubeY.value);\n \t\t\t\t\tif (!success) {\n-\t\t\t\t\t\tqueueDiffuseUpdate(column.getCube(cubeY), blockX, blockZ, minY, maxY);\n+\t\t\t\t\t\tqueueDiffuseUpdate(column.getCube(cubeY.value), blockX, blockZ, minY, maxY);\n \t\t\t\t\t}\n \t\t\t\t}\n \t\t\t\tbreak;\n \t\t\tcase QUEUED:\n \t\t\t\ttoDiffuse = SkyLightUpdateCubeSelector.getCubesY(column, localX, localZ, minY, maxY);\n-\t\t\t\tfor (int cubeY : toDiffuse) {\n-\t\t\t\t\tqueueDiffuseUpdate(column.getCube(cubeY), blockX, blockZ, minY, maxY);\n+\t\t\t\tfor (IntCursor cubeY : toDiffuse) {\n+\t\t\t\t\tqueueDiffuseUpdate(column.getCube(cubeY.value), blockX, blockZ, minY, maxY);\n \t\t\t\t}\n \t\t\t\tbreak;\n \t\t}\n \t}\n \n \tpublic void tick() {\n \t\tlong timeStart = System.currentTimeMillis();\n-\t\tlong timeStop = timeStart + TickBudget;\n+\t\tlong timeStop = timeStart + CubicChunks.Config.getMaxTimeSpentGeneratingCubesPerTick();","path":"src/main/java/cubicchunks/lighting/LightingManager.java","position":51,"original_position":51,"commit_id":"af1272aa07f6099114ba799c808085f21562b1b2","original_commit_id":"af1272aa07f6099114ba799c808085f21562b1b2","user":{"login":"sirsavary","id":718338,"avatar_url":"https://avatars.githubusercontent.com/u/718338?v=3","gravatar_id":"","url":"https://api.github.com/users/sirsavary","html_url":"https://github.com/sirsavary","followers_url":"https://api.github.com/users/sirsavary/followers","following_url":"https://api.github.com/users/sirsavary/following{/other_user}","gists_url":"https://api.github.com/users/sirsavary/gists{/gist_id}","starred_url":"https://api.github.com/users/sirsavary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sirsavary/subscriptions","organizations_url":"https://api.github.com/users/sirsavary/orgs","repos_url":"https://api.github.com/users/sirsavary/repos","events_url":"https://api.github.com/users/sirsavary/events{/privacy}","received_events_url":"https://api.github.com/users/sirsavary/received_events","type":"User","site_admin":false},"body":"Ah, I thought they were the same when I asked you in chat, will change the name of the config option","created_at":"2016-09-22T21:06:35Z","updated_at":"2016-09-22T21:06:35Z","html_url":"https://github.com/Barteks2x/CubicChunks/pull/52#discussion_r80136573","pull_request_url":"https://api.github.com/repos/Barteks2x/CubicChunks/pulls/52","_links":{"self":{"href":"https://api.github.com/repos/Barteks2x/CubicChunks/pulls/comments/80136573"},"html":{"href":"https://github.com/Barteks2x/CubicChunks/pull/52#discussion_r80136573"},"pull_request":{"href":"https://api.github.com/repos/Barteks2x/CubicChunks/pulls/52"}}},"pull_request":{"url":"https://api.github.com/repos/Barteks2x/CubicChunks/pulls/52","id":86411849,"html_url":"https://github.com/Barteks2x/CubicChunks/pull/52","diff_url":"https://github.com/Barteks2x/CubicChunks/pull/52.diff","patch_url":"https://github.com/Barteks2x/CubicChunks/pull/52.patch","issue_url":"https://api.github.com/repos/Barteks2x/CubicChunks/issues/52","number":52,"state":"open","locked":false,"title":"Use primitive collections + add configuration file","user":{"login":"sirsavary","id":718338,"avatar_url":"https://avatars.githubusercontent.com/u/718338?v=3","gravatar_id":"","url":"https://api.github.com/users/sirsavary","html_url":"https://github.com/sirsavary","followers_url":"https://api.github.com/users/sirsavary/followers","following_url":"https://api.github.com/users/sirsavary/following{/other_user}","gists_url":"https://api.github.com/users/sirsavary/gists{/gist_id}","starred_url":"https://api.github.com/users/sirsavary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sirsavary/subscriptions","organizations_url":"https://api.github.com/users/sirsavary/orgs","repos_url":"https://api.github.com/users/sirsavary/repos","events_url":"https://api.github.com/users/sirsavary/events{/privacy}","received_events_url":"https://api.github.com/users/sirsavary/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-22T20:49:42Z","updated_at":"2016-09-22T21:06:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf94df8d77998a1380a56cd74ecb538f698d5be6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Barteks2x/CubicChunks/pulls/52/commits","review_comments_url":"https://api.github.com/repos/Barteks2x/CubicChunks/pulls/52/comments","review_comment_url":"https://api.github.com/repos/Barteks2x/CubicChunks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Barteks2x/CubicChunks/issues/52/comments","statuses_url":"https://api.github.com/repos/Barteks2x/CubicChunks/statuses/af1272aa07f6099114ba799c808085f21562b1b2","head":{"label":"Mordrum:master","ref":"master","sha":"af1272aa07f6099114ba799c808085f21562b1b2","user":{"login":"Mordrum","id":18254407,"avatar_url":"https://avatars.githubusercontent.com/u/18254407?v=3","gravatar_id":"","url":"https://api.github.com/users/Mordrum","html_url":"https://github.com/Mordrum","followers_url":"https://api.github.com/users/Mordrum/followers","following_url":"https://api.github.com/users/Mordrum/following{/other_user}","gists_url":"https://api.github.com/users/Mordrum/gists{/gist_id}","starred_url":"https://api.github.com/users/Mordrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mordrum/subscriptions","organizations_url":"https://api.github.com/users/Mordrum/orgs","repos_url":"https://api.github.com/users/Mordrum/repos","events_url":"https://api.github.com/users/Mordrum/events{/privacy}","received_events_url":"https://api.github.com/users/Mordrum/received_events","type":"Organization","site_admin":false},"repo":{"id":68545418,"name":"CubicChunks","full_name":"Mordrum/CubicChunks","owner":{"login":"Mordrum","id":18254407,"avatar_url":"https://avatars.githubusercontent.com/u/18254407?v=3","gravatar_id":"","url":"https://api.github.com/users/Mordrum","html_url":"https://github.com/Mordrum","followers_url":"https://api.github.com/users/Mordrum/followers","following_url":"https://api.github.com/users/Mordrum/following{/other_user}","gists_url":"https://api.github.com/users/Mordrum/gists{/gist_id}","starred_url":"https://api.github.com/users/Mordrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mordrum/subscriptions","organizations_url":"https://api.github.com/users/Mordrum/orgs","repos_url":"https://api.github.com/users/Mordrum/repos","events_url":"https://api.github.com/users/Mordrum/events{/privacy}","received_events_url":"https://api.github.com/users/Mordrum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Mordrum/CubicChunks","description":"Infinite* height mod for Minecraft","fork":true,"url":"https://api.github.com/repos/Mordrum/CubicChunks","forks_url":"https://api.github.com/repos/Mordrum/CubicChunks/forks","keys_url":"https://api.github.com/repos/Mordrum/CubicChunks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mordrum/CubicChunks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mordrum/CubicChunks/teams","hooks_url":"https://api.github.com/repos/Mordrum/CubicChunks/hooks","issue_events_url":"https://api.github.com/repos/Mordrum/CubicChunks/issues/events{/number}","events_url":"https://api.github.com/repos/Mordrum/CubicChunks/events","assignees_url":"https://api.github.com/repos/Mordrum/CubicChunks/assignees{/user}","branches_url":"https://api.github.com/repos/Mordrum/CubicChunks/branches{/branch}","tags_url":"https://api.github.com/repos/Mordrum/CubicChunks/tags","blobs_url":"https://api.github.com/repos/Mordrum/CubicChunks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mordrum/CubicChunks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mordrum/CubicChunks/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mordrum/CubicChunks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mordrum/CubicChunks/statuses/{sha}","languages_url":"https://api.github.com/repos/Mordrum/CubicChunks/languages","stargazers_url":"https://api.github.com/repos/Mordrum/CubicChunks/stargazers","contributors_url":"https://api.github.com/repos/Mordrum/CubicChunks/contributors","subscribers_url":"https://api.github.com/repos/Mordrum/CubicChunks/subscribers","subscription_url":"https://api.github.com/repos/Mordrum/CubicChunks/subscription","commits_url":"https://api.github.com/repos/Mordrum/CubicChunks/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mordrum/CubicChunks/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mordrum/CubicChunks/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mordrum/CubicChunks/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mordrum/CubicChunks/contents/{+path}","compare_url":"https://api.github.com/repos/Mordrum/CubicChunks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mordrum/CubicChunks/merges","archive_url":"https://api.github.com/repos/Mordrum/CubicChunks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mordrum/CubicChunks/downloads","issues_url":"https://api.github.com/repos/Mordrum/CubicChunks/issues{/number}","pulls_url":"https://api.github.com/repos/Mordrum/CubicChunks/pulls{/number}","milestones_url":"https://api.github.com/repos/Mordrum/CubicChunks/milestones{/number}","notifications_url":"https://api.github.com/repos/Mordrum/CubicChunks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mordrum/CubicChunks/labels{/name}","releases_url":"https://api.github.com/repos/Mordrum/CubicChunks/releases{/id}","deployments_url":"https://api.github.com/repos/Mordrum/CubicChunks/deployments","created_at":"2016-09-18T20:26:14Z","updated_at":"2016-09-18T20:26:15Z","pushed_at":"2016-09-22T20:48:53Z","git_url":"git://github.com/Mordrum/CubicChunks.git","ssh_url":"git@github.com:Mordrum/CubicChunks.git","clone_url":"https://github.com/Mordrum/CubicChunks.git","svn_url":"https://github.com/Mordrum/CubicChunks","homepage":"","size":3786,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Barteks2x:master","ref":"master","sha":"074a8ccad990c1899b483b0d89f880a43c4a3973","user":{"login":"Barteks2x","id":1349112,"avatar_url":"https://avatars.githubusercontent.com/u/1349112?v=3","gravatar_id":"","url":"https://api.github.com/users/Barteks2x","html_url":"https://github.com/Barteks2x","followers_url":"https://api.github.com/users/Barteks2x/followers","following_url":"https://api.github.com/users/Barteks2x/following{/other_user}","gists_url":"https://api.github.com/users/Barteks2x/gists{/gist_id}","starred_url":"https://api.github.com/users/Barteks2x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Barteks2x/subscriptions","organizations_url":"https://api.github.com/users/Barteks2x/orgs","repos_url":"https://api.github.com/users/Barteks2x/repos","events_url":"https://api.github.com/users/Barteks2x/events{/privacy}","received_events_url":"https://api.github.com/users/Barteks2x/received_events","type":"User","site_admin":false},"repo":{"id":43247934,"name":"CubicChunks","full_name":"Barteks2x/CubicChunks","owner":{"login":"Barteks2x","id":1349112,"avatar_url":"https://avatars.githubusercontent.com/u/1349112?v=3","gravatar_id":"","url":"https://api.github.com/users/Barteks2x","html_url":"https://github.com/Barteks2x","followers_url":"https://api.github.com/users/Barteks2x/followers","following_url":"https://api.github.com/users/Barteks2x/following{/other_user}","gists_url":"https://api.github.com/users/Barteks2x/gists{/gist_id}","starred_url":"https://api.github.com/users/Barteks2x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Barteks2x/subscriptions","organizations_url":"https://api.github.com/users/Barteks2x/orgs","repos_url":"https://api.github.com/users/Barteks2x/repos","events_url":"https://api.github.com/users/Barteks2x/events{/privacy}","received_events_url":"https://api.github.com/users/Barteks2x/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Barteks2x/CubicChunks","description":"Infinite* height mod for Minecraft","fork":false,"url":"https://api.github.com/repos/Barteks2x/CubicChunks","forks_url":"https://api.github.com/repos/Barteks2x/CubicChunks/forks","keys_url":"https://api.github.com/repos/Barteks2x/CubicChunks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Barteks2x/CubicChunks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Barteks2x/CubicChunks/teams","hooks_url":"https://api.github.com/repos/Barteks2x/CubicChunks/hooks","issue_events_url":"https://api.github.com/repos/Barteks2x/CubicChunks/issues/events{/number}","events_url":"https://api.github.com/repos/Barteks2x/CubicChunks/events","assignees_url":"https://api.github.com/repos/Barteks2x/CubicChunks/assignees{/user}","branches_url":"https://api.github.com/repos/Barteks2x/CubicChunks/branches{/branch}","tags_url":"https://api.github.com/repos/Barteks2x/CubicChunks/tags","blobs_url":"https://api.github.com/repos/Barteks2x/CubicChunks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Barteks2x/CubicChunks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Barteks2x/CubicChunks/git/refs{/sha}","trees_url":"https://api.github.com/repos/Barteks2x/CubicChunks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Barteks2x/CubicChunks/statuses/{sha}","languages_url":"https://api.github.com/repos/Barteks2x/CubicChunks/languages","stargazers_url":"https://api.github.com/repos/Barteks2x/CubicChunks/stargazers","contributors_url":"https://api.github.com/repos/Barteks2x/CubicChunks/contributors","subscribers_url":"https://api.github.com/repos/Barteks2x/CubicChunks/subscribers","subscription_url":"https://api.github.com/repos/Barteks2x/CubicChunks/subscription","commits_url":"https://api.github.com/repos/Barteks2x/CubicChunks/commits{/sha}","git_commits_url":"https://api.github.com/repos/Barteks2x/CubicChunks/git/commits{/sha}","comments_url":"https://api.github.com/repos/Barteks2x/CubicChunks/comments{/number}","issue_comment_url":"https://api.github.com/repos/Barteks2x/CubicChunks/issues/comments{/number}","contents_url":"https://api.github.com/repos/Barteks2x/CubicChunks/contents/{+path}","compare_url":"https://api.github.com/repos/Barteks2x/CubicChunks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Barteks2x/CubicChunks/merges","archive_url":"https://api.github.com/repos/Barteks2x/CubicChunks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Barteks2x/CubicChunks/downloads","issues_url":"https://api.github.com/repos/Barteks2x/CubicChunks/issues{/number}","pulls_url":"https://api.github.com/repos/Barteks2x/CubicChunks/pulls{/number}","milestones_url":"https://api.github.com/repos/Barteks2x/CubicChunks/milestones{/number}","notifications_url":"https://api.github.com/repos/Barteks2x/CubicChunks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Barteks2x/CubicChunks/labels{/name}","releases_url":"https://api.github.com/repos/Barteks2x/CubicChunks/releases{/id}","deployments_url":"https://api.github.com/repos/Barteks2x/CubicChunks/deployments","created_at":"2015-09-27T13:40:45Z","updated_at":"2016-09-13T23:14:45Z","pushed_at":"2016-09-22T20:49:42Z","git_url":"git://github.com/Barteks2x/CubicChunks.git","ssh_url":"git@github.com:Barteks2x/CubicChunks.git","clone_url":"https://github.com/Barteks2x/CubicChunks.git","svn_url":"https://github.com/Barteks2x/CubicChunks","homepage":"","size":4118,"stargazers_count":28,"watchers_count":28,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":21,"forks":6,"open_issues":21,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Barteks2x/CubicChunks/pulls/52"},"html":{"href":"https://github.com/Barteks2x/CubicChunks/pull/52"},"issue":{"href":"https://api.github.com/repos/Barteks2x/CubicChunks/issues/52"},"comments":{"href":"https://api.github.com/repos/Barteks2x/CubicChunks/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/Barteks2x/CubicChunks/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/Barteks2x/CubicChunks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Barteks2x/CubicChunks/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/Barteks2x/CubicChunks/statuses/af1272aa07f6099114ba799c808085f21562b1b2"}}}}
{"actor":{"display_login":"sirsavary"}}