{"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/tidb-on-k8s/pulls/comments/73463932","id":73463932,"diff_hunk":"@@ -0,0 +1,49 @@\n+apiVersion: extensions/v1beta1\n+kind: Deployment\n+metadata:\n+  name: pd-rc\n+spec:\n+  replicas: 2\n+  template:\n+    metadata:\n+      labels:\n+        app: pd-cluster\n+    spec:\n+      containers:\n+      - image: pingcap/pd:latest\n+        name: pd-container-rc\n+        env:\n+        - name: MY_POD_IP\n+          valueFrom:\n+            fieldRef:\n+              fieldPath: status.podIP\n+        args:\n+        - --name=pd-$(MY_POD_IP)\n+        - --cluster-id=1\n+        - --client-urls=http://0.0.0.0:2379\n+        - --peer-urls=http://0.0.0.0:2380\n+        - --advertise-client-urls=http://$(MY_POD_IP):2379\n+        - --advertise-peer-urls=http://$(MY_POD_IP):2380\n+        - --join=http://pd1:2379","path":"pd-join.yaml","position":27,"original_position":27,"commit_id":"333037ae6cf80b20199bc8729db17adc9c64cb05","original_commit_id":"333037ae6cf80b20199bc8729db17adc9c64cb05","user":{"login":"siddontang","id":1080370,"avatar_url":"https://avatars.githubusercontent.com/u/1080370?v=3","gravatar_id":"","url":"https://api.github.com/users/siddontang","html_url":"https://github.com/siddontang","followers_url":"https://api.github.com/users/siddontang/followers","following_url":"https://api.github.com/users/siddontang/following{/other_user}","gists_url":"https://api.github.com/users/siddontang/gists{/gist_id}","starred_url":"https://api.github.com/users/siddontang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siddontang/subscriptions","organizations_url":"https://api.github.com/users/siddontang/orgs","repos_url":"https://api.github.com/users/siddontang/repos","events_url":"https://api.github.com/users/siddontang/events{/privacy}","received_events_url":"https://api.github.com/users/siddontang/received_events","type":"User","site_admin":false},"body":"Joining itself is ok, but what I mean is if the first member is down, but others is up, how to join?","created_at":"2016-08-04T05:27:31Z","updated_at":"2016-08-04T05:27:31Z","html_url":"https://github.com/pingcap/tidb-on-k8s/pull/3#discussion_r73463932","pull_request_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb-on-k8s/pulls/comments/73463932"},"html":{"href":"https://github.com/pingcap/tidb-on-k8s/pull/3#discussion_r73463932"},"pull_request":{"href":"https://api.github.com/repos/pingcap/tidb-on-k8s/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/pingcap/tidb-on-k8s/pulls/3","id":80019041,"html_url":"https://github.com/pingcap/tidb-on-k8s/pull/3","diff_url":"https://github.com/pingcap/tidb-on-k8s/pull/3.diff","patch_url":"https://github.com/pingcap/tidb-on-k8s/pull/3.patch","issue_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/issues/3","number":3,"state":"open","locked":false,"title":"add pd-join.yaml for pd join method","user":{"login":"GregoryIan","id":10701973,"avatar_url":"https://avatars.githubusercontent.com/u/10701973?v=3","gravatar_id":"","url":"https://api.github.com/users/GregoryIan","html_url":"https://github.com/GregoryIan","followers_url":"https://api.github.com/users/GregoryIan/followers","following_url":"https://api.github.com/users/GregoryIan/following{/other_user}","gists_url":"https://api.github.com/users/GregoryIan/gists{/gist_id}","starred_url":"https://api.github.com/users/GregoryIan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GregoryIan/subscriptions","organizations_url":"https://api.github.com/users/GregoryIan/orgs","repos_url":"https://api.github.com/users/GregoryIan/repos","events_url":"https://api.github.com/users/GregoryIan/events{/privacy}","received_events_url":"https://api.github.com/users/GregoryIan/received_events","type":"User","site_admin":false},"body":"add pd join method in pd-join.yaml, now pd have init-cluster and join methods to join the pd cluster. if you want to add pd node, just kubectl scale deployment pd-rc --replicas=COUNT","created_at":"2016-08-04T05:06:46Z","updated_at":"2016-08-04T05:27:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9faeb684aa66da7624497f201dcb2895914a90eb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/pulls/3/commits","review_comments_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/pulls/3/comments","review_comment_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/issues/3/comments","statuses_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/statuses/333037ae6cf80b20199bc8729db17adc9c64cb05","head":{"label":"GregoryIan:add-pd-join","ref":"add-pd-join","sha":"333037ae6cf80b20199bc8729db17adc9c64cb05","user":{"login":"GregoryIan","id":10701973,"avatar_url":"https://avatars.githubusercontent.com/u/10701973?v=3","gravatar_id":"","url":"https://api.github.com/users/GregoryIan","html_url":"https://github.com/GregoryIan","followers_url":"https://api.github.com/users/GregoryIan/followers","following_url":"https://api.github.com/users/GregoryIan/following{/other_user}","gists_url":"https://api.github.com/users/GregoryIan/gists{/gist_id}","starred_url":"https://api.github.com/users/GregoryIan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GregoryIan/subscriptions","organizations_url":"https://api.github.com/users/GregoryIan/orgs","repos_url":"https://api.github.com/users/GregoryIan/repos","events_url":"https://api.github.com/users/GregoryIan/events{/privacy}","received_events_url":"https://api.github.com/users/GregoryIan/received_events","type":"User","site_admin":false},"repo":{"id":64901031,"name":"tidb-on-k8s","full_name":"GregoryIan/tidb-on-k8s","owner":{"login":"GregoryIan","id":10701973,"avatar_url":"https://avatars.githubusercontent.com/u/10701973?v=3","gravatar_id":"","url":"https://api.github.com/users/GregoryIan","html_url":"https://github.com/GregoryIan","followers_url":"https://api.github.com/users/GregoryIan/followers","following_url":"https://api.github.com/users/GregoryIan/following{/other_user}","gists_url":"https://api.github.com/users/GregoryIan/gists{/gist_id}","starred_url":"https://api.github.com/users/GregoryIan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GregoryIan/subscriptions","organizations_url":"https://api.github.com/users/GregoryIan/orgs","repos_url":"https://api.github.com/users/GregoryIan/repos","events_url":"https://api.github.com/users/GregoryIan/events{/privacy}","received_events_url":"https://api.github.com/users/GregoryIan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GregoryIan/tidb-on-k8s","description":null,"fork":true,"url":"https://api.github.com/repos/GregoryIan/tidb-on-k8s","forks_url":"https://api.github.com/repos/GregoryIan/tidb-on-k8s/forks","keys_url":"https://api.github.com/repos/GregoryIan/tidb-on-k8s/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GregoryIan/tidb-on-k8s/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GregoryIan/tidb-on-k8s/teams","hooks_url":"https://api.github.com/repos/GregoryIan/tidb-on-k8s/hooks","issue_events_url":"https://api.github.com/repos/GregoryIan/tidb-on-k8s/issues/events{/number}","events_url":"https://api.github.com/repos/GregoryIan/tidb-on-k8s/events","assignees_url":"https://api.github.com/repos/GregoryIan/tidb-on-k8s/assignees{/user}","branches_url":"https://api.github.com/repos/GregoryIan/tidb-on-k8s/branches{/branch}","tags_url":"https://api.github.com/repos/GregoryIan/tidb-on-k8s/tags","blobs_url":"https://api.github.com/repos/GregoryIan/tidb-on-k8s/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GregoryIan/tidb-on-k8s/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GregoryIan/tidb-on-k8s/git/refs{/sha}","trees_url":"https://api.github.com/repos/GregoryIan/tidb-on-k8s/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GregoryIan/tidb-on-k8s/statuses/{sha}","languages_url":"https://api.github.com/repos/GregoryIan/tidb-on-k8s/languages","stargazers_url":"https://api.github.com/repos/GregoryIan/tidb-on-k8s/stargazers","contributors_url":"https://api.github.com/repos/GregoryIan/tidb-on-k8s/contributors","subscribers_url":"https://api.github.com/repos/GregoryIan/tidb-on-k8s/subscribers","subscription_url":"https://api.github.com/repos/GregoryIan/tidb-on-k8s/subscription","commits_url":"https://api.github.com/repos/GregoryIan/tidb-on-k8s/commits{/sha}","git_commits_url":"https://api.github.com/repos/GregoryIan/tidb-on-k8s/git/commits{/sha}","comments_url":"https://api.github.com/repos/GregoryIan/tidb-on-k8s/comments{/number}","issue_comment_url":"https://api.github.com/repos/GregoryIan/tidb-on-k8s/issues/comments{/number}","contents_url":"https://api.github.com/repos/GregoryIan/tidb-on-k8s/contents/{+path}","compare_url":"https://api.github.com/repos/GregoryIan/tidb-on-k8s/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GregoryIan/tidb-on-k8s/merges","archive_url":"https://api.github.com/repos/GregoryIan/tidb-on-k8s/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GregoryIan/tidb-on-k8s/downloads","issues_url":"https://api.github.com/repos/GregoryIan/tidb-on-k8s/issues{/number}","pulls_url":"https://api.github.com/repos/GregoryIan/tidb-on-k8s/pulls{/number}","milestones_url":"https://api.github.com/repos/GregoryIan/tidb-on-k8s/milestones{/number}","notifications_url":"https://api.github.com/repos/GregoryIan/tidb-on-k8s/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GregoryIan/tidb-on-k8s/labels{/name}","releases_url":"https://api.github.com/repos/GregoryIan/tidb-on-k8s/releases{/id}","deployments_url":"https://api.github.com/repos/GregoryIan/tidb-on-k8s/deployments","created_at":"2016-08-04T03:58:29Z","updated_at":"2016-08-04T03:58:30Z","pushed_at":"2016-08-04T05:05:02Z","git_url":"git://github.com/GregoryIan/tidb-on-k8s.git","ssh_url":"git@github.com:GregoryIan/tidb-on-k8s.git","clone_url":"https://github.com/GregoryIan/tidb-on-k8s.git","svn_url":"https://github.com/GregoryIan/tidb-on-k8s","homepage":null,"size":7,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"d57cc3177395ad3cade153f77b6f2ac35fceec80","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":64467873,"name":"tidb-on-k8s","full_name":"pingcap/tidb-on-k8s","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tidb-on-k8s","description":null,"fork":true,"url":"https://api.github.com/repos/pingcap/tidb-on-k8s","forks_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/forks","keys_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/teams","hooks_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/events","assignees_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/tags","blobs_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/languages","stargazers_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/subscription","commits_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/merges","archive_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/downloads","issues_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tidb-on-k8s/deployments","created_at":"2016-07-29T09:18:28Z","updated_at":"2016-08-04T05:26:18Z","pushed_at":"2016-08-04T05:06:46Z","git_url":"git://github.com/pingcap/tidb-on-k8s.git","ssh_url":"git@github.com:pingcap/tidb-on-k8s.git","clone_url":"https://github.com/pingcap/tidb-on-k8s.git","svn_url":"https://github.com/pingcap/tidb-on-k8s","homepage":null,"size":7,"stargazers_count":1,"watchers_count":1,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb-on-k8s/pulls/3"},"html":{"href":"https://github.com/pingcap/tidb-on-k8s/pull/3"},"issue":{"href":"https://api.github.com/repos/pingcap/tidb-on-k8s/issues/3"},"comments":{"href":"https://api.github.com/repos/pingcap/tidb-on-k8s/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tidb-on-k8s/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tidb-on-k8s/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tidb-on-k8s/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tidb-on-k8s/statuses/333037ae6cf80b20199bc8729db17adc9c64cb05"}}}}
{"actor":{"display_login":"siddontang"}}