{"action":"created","issue":{"url":"https://api.github.com/repos/cloudfoundry/cli/issues/992","repository_url":"https://api.github.com/repos/cloudfoundry/cli","labels_url":"https://api.github.com/repos/cloudfoundry/cli/issues/992/labels{/name}","comments_url":"https://api.github.com/repos/cloudfoundry/cli/issues/992/comments","events_url":"https://api.github.com/repos/cloudfoundry/cli/issues/992/events","html_url":"https://github.com/cloudfoundry/cli/issues/992","id":187043821,"number":992,"title":"Provide version and SHA within released source tar balls","user":{"login":"svollath","id":1257115,"avatar_url":"https://avatars.githubusercontent.com/u/1257115?v=3","gravatar_id":"","url":"https://api.github.com/users/svollath","html_url":"https://github.com/svollath","followers_url":"https://api.github.com/users/svollath/followers","following_url":"https://api.github.com/users/svollath/following{/other_user}","gists_url":"https://api.github.com/users/svollath/gists{/gist_id}","starred_url":"https://api.github.com/users/svollath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svollath/subscriptions","organizations_url":"https://api.github.com/users/svollath/orgs","repos_url":"https://api.github.com/users/svollath/repos","events_url":"https://api.github.com/users/svollath/events{/privacy}","received_events_url":"https://api.github.com/users/svollath/received_events","type":"User","site_admin":false},"labels":[{"id":371026367,"url":"https://api.github.com/repos/cloudfoundry/cli/labels/unscheduled","name":"unscheduled","color":"D9D9D9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-03T12:16:01Z","updated_at":"2016-11-04T05:47:11Z","closed_at":null,"body":"When building the CLI \"offline\" (e.g. packaging from a released tar ball), \r\n```cf version``` would report ```cf version BUILT_FROM_SOURCE-BUILT_AT_UNKNOWN_TIME```\r\nunless \"cf/app_constants.go\" is patched with the respective values.\r\n\r\nWhile the version (e.g. 6.22.2) is provided within the tar ball, the short SHA of the last commit (e.g. \"61ce394\") isn't.\r\nIn addition, the source folder isn't a git repository, which makes scripts like ```\r\nbin/replace_sha``` fail - and getting the \"CURRENT_SHA\" requires external network.\r\n\r\nIt would be nice, if you could provide a value for \"CURRENT_SHA\" within the source tar ball of a release.\r\nHave this (offline) optional respected by bin/replace_sha, would also be good."},"comment":{"url":"https://api.github.com/repos/cloudfoundry/cli/issues/comments/258349947","html_url":"https://github.com/cloudfoundry/cli/issues/992#issuecomment-258349947","issue_url":"https://api.github.com/repos/cloudfoundry/cli/issues/992","id":258349947,"user":{"login":"dkoper","id":1034538,"avatar_url":"https://avatars.githubusercontent.com/u/1034538?v=3","gravatar_id":"","url":"https://api.github.com/users/dkoper","html_url":"https://github.com/dkoper","followers_url":"https://api.github.com/users/dkoper/followers","following_url":"https://api.github.com/users/dkoper/following{/other_user}","gists_url":"https://api.github.com/users/dkoper/gists{/gist_id}","starred_url":"https://api.github.com/users/dkoper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkoper/subscriptions","organizations_url":"https://api.github.com/users/dkoper/orgs","repos_url":"https://api.github.com/users/dkoper/repos","events_url":"https://api.github.com/users/dkoper/events{/privacy}","received_events_url":"https://api.github.com/users/dkoper/received_events","type":"User","site_admin":false},"created_at":"2016-11-04T05:47:11Z","updated_at":"2016-11-04T05:47:11Z","body":"Hi @svollath \r\n\r\nI don't think it makes sense to include the sha in `cf version` output when it's built from a downloaded tarball (i.e. no longer under git's control). How about we make it default to `6.22.2+unknown-2016-11-04`?"}}
{"actor":{"display_login":"dkoper"}}