{"action":"created","issue":{"url":"https://api.github.com/repos/greenplum-db/gpdb/issues/948","repository_url":"https://api.github.com/repos/greenplum-db/gpdb","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/948/labels{/name}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/948/comments","events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/948/events","html_url":"https://github.com/greenplum-db/gpdb/pull/948","id":165486220,"number":948,"title":"Remove useless idle tracker assert which access shared memory without properly lock.","user":{"login":"Tao-Ma","id":6395057,"avatar_url":"https://avatars.githubusercontent.com/u/6395057?v=3","gravatar_id":"","url":"https://api.github.com/users/Tao-Ma","html_url":"https://github.com/Tao-Ma","followers_url":"https://api.github.com/users/Tao-Ma/followers","following_url":"https://api.github.com/users/Tao-Ma/following{/other_user}","gists_url":"https://api.github.com/users/Tao-Ma/gists{/gist_id}","starred_url":"https://api.github.com/users/Tao-Ma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tao-Ma/subscriptions","organizations_url":"https://api.github.com/users/Tao-Ma/orgs","repos_url":"https://api.github.com/users/Tao-Ma/repos","events_url":"https://api.github.com/users/Tao-Ma/events{/privacy}","received_events_url":"https://api.github.com/users/Tao-Ma/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-07-14T06:32:41Z","updated_at":"2016-07-14T06:45:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/948","html_url":"https://github.com/greenplum-db/gpdb/pull/948","diff_url":"https://github.com/greenplum-db/gpdb/pull/948.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/948.patch"},"body":"I found the a core file with the following info:\r\n\r\n    (gdb) bt\r\n    #0  0x00007f594cfa15f7 in raise () from /lib64/libc.so.6\r\n    #1  0x00007f594cfa2ce8 in abort () from /lib64/libc.so.6\r\n    #2  0x00000000009acf28 in ExceptionalCondition (conditionName=0xd6aaf8 \"!(MySessionState->activeProcessCount < MySessionState->pinCount)\", errorType=0xd6a89f \"FailedAssertion\",\r\n        fileName=0xd6a890 \"idle_tracker.c\", lineNumber=185) at assert.c:59\r\n    #3  0x00000000009f0fa2 in IdleTracker_DeactivateProcess () at idle_tracker.c:185\r\n    #4  0x00000000009f0c13 in IdleTracker_Shutdown () at idle_tracker.c:91\r\n    #5  0x00000000009ef198 in VmemTracker_Shutdown () at vmem_tracker.c:175\r\n    #6  0x00000000009ee703 in GPMemoryProtect_Shutdown () at memprot.c:199\r\n    #7  0x00000000009c5845 in ShutdownPostgres (code=0, arg=0) at postinit.c:1070\r\n    #8  0x0000000000897d46 in shmem_exit (code=0) at ipc.c:255\r\n    #9  0x0000000000897c3a in proc_exit_prepare (code=0) at ipc.c:215\r\n    #10 0x0000000000897b70 in proc_exit (code=0) at ipc.c:95\r\n    #11 0x00000000008bd18f in PostgresMain (argc=1, argv=0x18caf10, dbname=0x18c8ff0 \"tiny_db\", username=0x18c8fb0 \"gpadmin\") at postgres.c:5234\r\n    #12 0x00000000008549af in BackendRun (port=0x18c6760) at postmaster.c:6963\r\n    #13 0x00000000008540b0 in BackendStartup (port=0x18c6760) at postmaster.c:6658\r\n    #14 0x000000000084c77a in ServerLoop () at postmaster.c:2464\r\n    #15 0x000000000084afe1 in PostmasterMain (argc=15, argv=0x189b030) at postmaster.c:1540\r\n    #16 0x000000000076f978 in main (argc=15, argv=0x189b030) at main.c:206\r\n\r\n\r\nThe code in IdleTracker_DeactivateProcess(), access activeProcessCount and pinCount without lock protection.\r\n\r\nIf there are other process go into active just before the assert read activeProcessCount. And get into shutdown and release the session state before the assert read pinCount. The assert will fail.\r\n\r\nThere is assertion to check the equation activeProcessCount < pinCount in SessionState_Release(), so remove this assert is ok."},"comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments/232573701","html_url":"https://github.com/greenplum-db/gpdb/pull/948#issuecomment-232573701","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/948","id":232573701,"user":{"login":"danielgustafsson","id":321790,"avatar_url":"https://avatars.githubusercontent.com/u/321790?v=3","gravatar_id":"","url":"https://api.github.com/users/danielgustafsson","html_url":"https://github.com/danielgustafsson","followers_url":"https://api.github.com/users/danielgustafsson/followers","following_url":"https://api.github.com/users/danielgustafsson/following{/other_user}","gists_url":"https://api.github.com/users/danielgustafsson/gists{/gist_id}","starred_url":"https://api.github.com/users/danielgustafsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielgustafsson/subscriptions","organizations_url":"https://api.github.com/users/danielgustafsson/orgs","repos_url":"https://api.github.com/users/danielgustafsson/repos","events_url":"https://api.github.com/users/danielgustafsson/events{/privacy}","received_events_url":"https://api.github.com/users/danielgustafsson/received_events","type":"User","site_admin":false},"created_at":"2016-07-14T06:45:15Z","updated_at":"2016-07-14T06:45:15Z","body":"Hi @Tao-Ma, thanks for your contribution! Once you've signed the CLA as linked to by the bot above add a comment here and we'll re-trigger the bot to pick it up."}}
{"actor":{"display_login":"danielgustafsson"}}