{"action":"created","issue":{"url":"https://api.github.com/repos/ncapdevi/FragNav/issues/29","repository_url":"https://api.github.com/repos/ncapdevi/FragNav","labels_url":"https://api.github.com/repos/ncapdevi/FragNav/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/ncapdevi/FragNav/issues/29/comments","events_url":"https://api.github.com/repos/ncapdevi/FragNav/issues/29/events","html_url":"https://github.com/ncapdevi/FragNav/issues/29","id":190671214,"number":29,"title":"Bug: Clicking on pre-selected tab shows empty fragment instead of base fragment","user":{"login":"p-fischer","id":8547316,"avatar_url":"https://avatars.githubusercontent.com/u/8547316?v=3","gravatar_id":"","url":"https://api.github.com/users/p-fischer","html_url":"https://github.com/p-fischer","followers_url":"https://api.github.com/users/p-fischer/followers","following_url":"https://api.github.com/users/p-fischer/following{/other_user}","gists_url":"https://api.github.com/users/p-fischer/gists{/gist_id}","starred_url":"https://api.github.com/users/p-fischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p-fischer/subscriptions","organizations_url":"https://api.github.com/users/p-fischer/orgs","repos_url":"https://api.github.com/users/p-fischer/repos","events_url":"https://api.github.com/users/p-fischer/events{/privacy}","received_events_url":"https://api.github.com/users/p-fischer/received_events","type":"User","site_admin":false},"labels":[{"id":348063718,"url":"https://api.github.com/repos/ncapdevi/FragNav/labels/question","name":"question","color":"cc317c","default":true}],"state":"open","locked":false,"assignee":{"login":"ncapdevi","id":933088,"avatar_url":"https://avatars.githubusercontent.com/u/933088?v=3","gravatar_id":"","url":"https://api.github.com/users/ncapdevi","html_url":"https://github.com/ncapdevi","followers_url":"https://api.github.com/users/ncapdevi/followers","following_url":"https://api.github.com/users/ncapdevi/following{/other_user}","gists_url":"https://api.github.com/users/ncapdevi/gists{/gist_id}","starred_url":"https://api.github.com/users/ncapdevi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncapdevi/subscriptions","organizations_url":"https://api.github.com/users/ncapdevi/orgs","repos_url":"https://api.github.com/users/ncapdevi/repos","events_url":"https://api.github.com/users/ncapdevi/events{/privacy}","received_events_url":"https://api.github.com/users/ncapdevi/received_events","type":"User","site_admin":false},"assignees":[{"login":"ncapdevi","id":933088,"avatar_url":"https://avatars.githubusercontent.com/u/933088?v=3","gravatar_id":"","url":"https://api.github.com/users/ncapdevi","html_url":"https://github.com/ncapdevi","followers_url":"https://api.github.com/users/ncapdevi/followers","following_url":"https://api.github.com/users/ncapdevi/following{/other_user}","gists_url":"https://api.github.com/users/ncapdevi/gists{/gist_id}","starred_url":"https://api.github.com/users/ncapdevi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncapdevi/subscriptions","organizations_url":"https://api.github.com/users/ncapdevi/orgs","repos_url":"https://api.github.com/users/ncapdevi/repos","events_url":"https://api.github.com/users/ncapdevi/events{/privacy}","received_events_url":"https://api.github.com/users/ncapdevi/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2016-11-21T10:11:19Z","updated_at":"2016-11-21T14:45:23Z","closed_at":null,"body":"After the long awaited release, I could finally get rid of frag-nav as a locale module and include it as a dependency. Thank you for that! :)\r\n\r\nUnfortunately, I found an issue occurring in both versions 1.1.0 and 1.2.0:\r\n\r\nPreviously I could click on a tab, which already was selected, and go back to the first fragment of the tab's stack. No matter if there were one or multiple fragments on the stack.\r\n\r\nNow, I just see an empty fragment.\r\n\r\nI assume this is a bug or must the library be used differently now?"},"comment":{"url":"https://api.github.com/repos/ncapdevi/FragNav/issues/comments/261956830","html_url":"https://github.com/ncapdevi/FragNav/issues/29#issuecomment-261956830","issue_url":"https://api.github.com/repos/ncapdevi/FragNav/issues/29","id":261956830,"user":{"login":"p-fischer","id":8547316,"avatar_url":"https://avatars.githubusercontent.com/u/8547316?v=3","gravatar_id":"","url":"https://api.github.com/users/p-fischer","html_url":"https://github.com/p-fischer","followers_url":"https://api.github.com/users/p-fischer/followers","following_url":"https://api.github.com/users/p-fischer/following{/other_user}","gists_url":"https://api.github.com/users/p-fischer/gists{/gist_id}","starred_url":"https://api.github.com/users/p-fischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p-fischer/subscriptions","organizations_url":"https://api.github.com/users/p-fischer/orgs","repos_url":"https://api.github.com/users/p-fischer/repos","events_url":"https://api.github.com/users/p-fischer/events{/privacy}","received_events_url":"https://api.github.com/users/p-fischer/received_events","type":"User","site_admin":false},"created_at":"2016-11-21T14:45:23Z","updated_at":"2016-11-21T14:45:23Z","body":"Glad, you're back on active development since I think this lib perfectly captures my desired behavior for bottom bar navigation.\r\n\r\nThis is my code. On re-selection, I'm basically just calling clearStack() - it shoudl be equal as you do in your sample app.\r\n```\r\n        bottomBar.setItemsFromMenu( R.menu.menu_bottombar, new OnMenuTabClickListener()\r\n\t\t{\r\n\t\t\t@Override\r\n\t\t\tpublic void onMenuTabSelected( @IdRes int menuItemId )\r\n\t\t\t{\r\n\t\t\t\tawaitSecondBackPress = true;\r\n\r\n\t\t\t\tView lastSelectedTab = findViewById( lastSelectedTabId );\r\n\t\t\t\tView nowSelectedTab = findViewById( menuItemId );\r\n\r\n\t\t\t\tif ( lastSelectedTab != null )\r\n\t\t\t\t{\r\n\t\t\t\t\tlastSelectedTab.setSelected( false );\r\n\t\t\t\t}\r\n\r\n\t\t\t\tif ( nowSelectedTab != null )\r\n\t\t\t\t{\r\n\t\t\t\t\tnowSelectedTab.setSelected( true );\r\n\t\t\t\t}\r\n\r\n\t\t\t\tlastSelectedTabId = menuItemId;\r\n\r\n\t\t\t\tswitch ( menuItemId )\r\n\t\t\t\t{\r\n\t\t\t\t\tcase R.id.bottombar_1:\r\n\t\t\t\t\t\tnavController.switchTab( INDEX_1 );\r\n\t\t\t\t\t\tbreak;\r\n\t\t\t\t\tcase R.id.bottombar_2:\r\n\t\t\t\t\t\tnavController.switchTab( INDEX_2 );\r\n\t\t\t\t\t\tbreak;\r\n\t\t\t\t\tcase R.id.bottombar_3\r\n\t\t\t\t\t\tnavController.switchTab( INDEX_3 );\r\n\t\t\t\t\t\tbreak;\r\n\t\t\t\t}\r\n\t\t\t}\r\n\r\n\t\t\t@Override\r\n\t\t\tpublic void onMenuTabReSelected( @IdRes int menuItemId )\r\n\t\t\t{\r\n\t\t\t\tlastSelectedTabId = menuItemId;\r\n\t\t\t\tnavController.clearStack();\r\n\t\t\t}\r\n\t\t} );\r\n```"}}
{"actor":{"display_login":"p-fischer"}}