{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/73713082","id":73713082,"diff_hunk":"@@ -555,7 +559,7 @@ func makeWritePod(ns string, pvcName string) *api.Pod {\n \t\t\t\t\tName:    \"write-pod\",\n \t\t\t\t\tImage:   \"gcr.io/google_containers/busybox:1.24\",\n \t\t\t\t\tCommand: []string{\"/bin/sh\"},\n-\t\t\t\t\tArgs:    []string{\"-c\", \"touch /mnt/SUCCESS && exit 0 || exit 1\"},\n+\t\t\t\t\tArgs:    []string{\"-c\", \"touch /mnt/SUCCESS && (id -G | grep ' 777$') && exit 0 || exit 1\"},","path":"test/e2e/persistent_volumes.go","position":32,"original_position":32,"commit_id":"3cd91ea52e938571ff5c4c6de2ed4db219c68efb","original_commit_id":"3cd91ea52e938571ff5c4c6de2ed4db219c68efb","user":{"login":"jsafrane","id":1745006,"avatar_url":"https://avatars.githubusercontent.com/u/1745006?v=3","gravatar_id":"","url":"https://api.github.com/users/jsafrane","html_url":"https://github.com/jsafrane","followers_url":"https://api.github.com/users/jsafrane/followers","following_url":"https://api.github.com/users/jsafrane/following{/other_user}","gists_url":"https://api.github.com/users/jsafrane/gists{/gist_id}","starred_url":"https://api.github.com/users/jsafrane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsafrane/subscriptions","organizations_url":"https://api.github.com/users/jsafrane/orgs","repos_url":"https://api.github.com/users/jsafrane/repos","events_url":"https://api.github.com/users/jsafrane/events{/privacy}","received_events_url":"https://api.github.com/users/jsafrane/received_events","type":"User","site_admin":false},"body":"is `777` always the last? What code ensures that?","created_at":"2016-08-05T15:39:07Z","updated_at":"2016-08-05T15:39:07Z","html_url":"https://github.com/kubernetes/kubernetes/pull/30084#discussion_r73713082","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30084","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/73713082"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/30084#discussion_r73713082"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30084"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30084","id":80110189,"html_url":"https://github.com/kubernetes/kubernetes/pull/30084","diff_url":"https://github.com/kubernetes/kubernetes/pull/30084.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/30084.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/30084","number":30084,"state":"open","locked":false,"title":"Add test for supplemental gid annotation to pv e2e test","user":{"login":"wongma7","id":13111288,"avatar_url":"https://avatars.githubusercontent.com/u/13111288?v=3","gravatar_id":"","url":"https://api.github.com/users/wongma7","html_url":"https://github.com/wongma7","followers_url":"https://api.github.com/users/wongma7/followers","following_url":"https://api.github.com/users/wongma7/following{/other_user}","gists_url":"https://api.github.com/users/wongma7/gists{/gist_id}","starred_url":"https://api.github.com/users/wongma7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wongma7/subscriptions","organizations_url":"https://api.github.com/users/wongma7/orgs","repos_url":"https://api.github.com/users/wongma7/repos","events_url":"https://api.github.com/users/wongma7/events{/privacy}","received_events_url":"https://api.github.com/users/wongma7/received_events","type":"User","site_admin":false},"body":"Test for feature added in #29119. Adds the annotation to the pv in the PersistentVolumes e2e test. It tests it by checking the output of 'id -G.' Also tests the actual use case of an nfs server by using an nfs server image 'volume-nfs-gid', modified slightly from 'volume-nfs' to have some permissions set.\r\n\r\n@pmorie ","created_at":"2016-08-04T16:35:32Z","updated_at":"2016-08-05T15:39:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f7bf623c870f58f204fb5770f33dda636b634de","assignee":{"login":"pmorie","id":366488,"avatar_url":"https://avatars.githubusercontent.com/u/366488?v=3","gravatar_id":"","url":"https://api.github.com/users/pmorie","html_url":"https://github.com/pmorie","followers_url":"https://api.github.com/users/pmorie/followers","following_url":"https://api.github.com/users/pmorie/following{/other_user}","gists_url":"https://api.github.com/users/pmorie/gists{/gist_id}","starred_url":"https://api.github.com/users/pmorie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmorie/subscriptions","organizations_url":"https://api.github.com/users/pmorie/orgs","repos_url":"https://api.github.com/users/pmorie/repos","events_url":"https://api.github.com/users/pmorie/events{/privacy}","received_events_url":"https://api.github.com/users/pmorie/received_events","type":"User","site_admin":false},"assignees":[{"login":"pmorie","id":366488,"avatar_url":"https://avatars.githubusercontent.com/u/366488?v=3","gravatar_id":"","url":"https://api.github.com/users/pmorie","html_url":"https://github.com/pmorie","followers_url":"https://api.github.com/users/pmorie/followers","following_url":"https://api.github.com/users/pmorie/following{/other_user}","gists_url":"https://api.github.com/users/pmorie/gists{/gist_id}","starred_url":"https://api.github.com/users/pmorie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmorie/subscriptions","organizations_url":"https://api.github.com/users/pmorie/orgs","repos_url":"https://api.github.com/users/pmorie/repos","events_url":"https://api.github.com/users/pmorie/events{/privacy}","received_events_url":"https://api.github.com/users/pmorie/received_events","type":"User","site_admin":false},{"login":"spxtr","id":7368979,"avatar_url":"https://avatars.githubusercontent.com/u/7368979?v=3","gravatar_id":"","url":"https://api.github.com/users/spxtr","html_url":"https://github.com/spxtr","followers_url":"https://api.github.com/users/spxtr/followers","following_url":"https://api.github.com/users/spxtr/following{/other_user}","gists_url":"https://api.github.com/users/spxtr/gists{/gist_id}","starred_url":"https://api.github.com/users/spxtr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spxtr/subscriptions","organizations_url":"https://api.github.com/users/spxtr/orgs","repos_url":"https://api.github.com/users/spxtr/repos","events_url":"https://api.github.com/users/spxtr/events{/privacy}","received_events_url":"https://api.github.com/users/spxtr/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30084/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30084/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/30084/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/3cd91ea52e938571ff5c4c6de2ed4db219c68efb","head":{"label":"wongma7:pv-gid-e2e","ref":"pv-gid-e2e","sha":"3cd91ea52e938571ff5c4c6de2ed4db219c68efb","user":{"login":"wongma7","id":13111288,"avatar_url":"https://avatars.githubusercontent.com/u/13111288?v=3","gravatar_id":"","url":"https://api.github.com/users/wongma7","html_url":"https://github.com/wongma7","followers_url":"https://api.github.com/users/wongma7/followers","following_url":"https://api.github.com/users/wongma7/following{/other_user}","gists_url":"https://api.github.com/users/wongma7/gists{/gist_id}","starred_url":"https://api.github.com/users/wongma7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wongma7/subscriptions","organizations_url":"https://api.github.com/users/wongma7/orgs","repos_url":"https://api.github.com/users/wongma7/repos","events_url":"https://api.github.com/users/wongma7/events{/privacy}","received_events_url":"https://api.github.com/users/wongma7/received_events","type":"User","site_admin":false},"repo":{"id":59241959,"name":"kubernetes","full_name":"wongma7/kubernetes","owner":{"login":"wongma7","id":13111288,"avatar_url":"https://avatars.githubusercontent.com/u/13111288?v=3","gravatar_id":"","url":"https://api.github.com/users/wongma7","html_url":"https://github.com/wongma7","followers_url":"https://api.github.com/users/wongma7/followers","following_url":"https://api.github.com/users/wongma7/following{/other_user}","gists_url":"https://api.github.com/users/wongma7/gists{/gist_id}","starred_url":"https://api.github.com/users/wongma7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wongma7/subscriptions","organizations_url":"https://api.github.com/users/wongma7/orgs","repos_url":"https://api.github.com/users/wongma7/repos","events_url":"https://api.github.com/users/wongma7/events{/privacy}","received_events_url":"https://api.github.com/users/wongma7/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wongma7/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/wongma7/kubernetes","forks_url":"https://api.github.com/repos/wongma7/kubernetes/forks","keys_url":"https://api.github.com/repos/wongma7/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wongma7/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wongma7/kubernetes/teams","hooks_url":"https://api.github.com/repos/wongma7/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/wongma7/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/wongma7/kubernetes/events","assignees_url":"https://api.github.com/repos/wongma7/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/wongma7/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/wongma7/kubernetes/tags","blobs_url":"https://api.github.com/repos/wongma7/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wongma7/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wongma7/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/wongma7/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wongma7/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/wongma7/kubernetes/languages","stargazers_url":"https://api.github.com/repos/wongma7/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/wongma7/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/wongma7/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/wongma7/kubernetes/subscription","commits_url":"https://api.github.com/repos/wongma7/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/wongma7/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/wongma7/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/wongma7/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/wongma7/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/wongma7/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wongma7/kubernetes/merges","archive_url":"https://api.github.com/repos/wongma7/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wongma7/kubernetes/downloads","issues_url":"https://api.github.com/repos/wongma7/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/wongma7/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/wongma7/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/wongma7/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wongma7/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/wongma7/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/wongma7/kubernetes/deployments","created_at":"2016-05-19T20:53:26Z","updated_at":"2016-05-19T20:53:49Z","pushed_at":"2016-08-04T16:27:29Z","git_url":"git://github.com/wongma7/kubernetes.git","ssh_url":"git@github.com:wongma7/kubernetes.git","clone_url":"https://github.com/wongma7/kubernetes.git","svn_url":"https://github.com/wongma7/kubernetes","homepage":"http://kubernetes.io","size":300516,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"42a12a4cd6fc3d3f4601e89564c8bfcc8efa1d44","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-08-05T15:23:35Z","pushed_at":"2016-08-05T15:37:56Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":515006,"stargazers_count":15983,"watchers_count":15983,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5060,"mirror_url":null,"open_issues_count":4085,"forks":5060,"open_issues":4085,"watchers":15983,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30084"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/30084"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/30084"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/30084/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30084/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30084/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/3cd91ea52e938571ff5c4c6de2ed4db219c68efb"}}}}
{"actor":{"display_login":"jsafrane"}}