{"action":"created","comment":{"url":"https://api.github.com/repos/chef-cookbooks/docker/pulls/comments/50196337","id":50196337,"diff_hunk":"@@ -32,56 +32,56 @@ class DockerContainer < DockerBase\n     property :repo, String, default: lazy { container_name }\n     property :tag, String, default: 'latest'\n     property :command, ShellCommand\n-    property :attach_stderr, Boolean, desired_state: false\n-    property :attach_stdin, Boolean, desired_state: false\n-    property :attach_stdout, Boolean, desired_state: false\n+    property :attach_stderr, Boolean, default: false, desired_state: false\n+    property :attach_stdin, Boolean, default: false, desired_state: false\n+    property :attach_stdout, Boolean, default: false, desired_state: false\n     property :autoremove, Boolean, desired_state: false\n-    property :cap_add, NonEmptyArray\n-    property :cap_drop, NonEmptyArray\n+    property :cap_add, NonEmptyArray, default: nil\n+    property :cap_drop, NonEmptyArray, default: nil\n     property :cgroup_parent, String, default: ''\n     property :cpu_shares, [Fixnum, nil], default: 0\n     property :cpuset_cpus, String, default: ''\n     property :detach, Boolean, default: true, desired_state: false\n-    property :devices, ArrayType\n-    property :dns, NonEmptyArray\n-    property :dns_search, ArrayType\n+    property :devices, Array, default: []\n+    property :dns, Array, default: []","path":"libraries/docker_container.rb","position":23,"original_position":23,"commit_id":"591edb1b69c7f587fa8099a90586ca0102b3db46","original_commit_id":"591edb1b69c7f587fa8099a90586ca0102b3db46","user":{"login":"someara","id":69068,"avatar_url":"https://avatars.githubusercontent.com/u/69068?v=3","gravatar_id":"","url":"https://api.github.com/users/someara","html_url":"https://github.com/someara","followers_url":"https://api.github.com/users/someara/followers","following_url":"https://api.github.com/users/someara/following{/other_user}","gists_url":"https://api.github.com/users/someara/gists{/gist_id}","starred_url":"https://api.github.com/users/someara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/someara/subscriptions","organizations_url":"https://api.github.com/users/someara/orgs","repos_url":"https://api.github.com/users/someara/repos","events_url":"https://api.github.com/users/someara/events{/privacy}","received_events_url":"https://api.github.com/users/someara/received_events","type":"User","site_admin":false},"body":"Why are these being changed to Array?","created_at":"2016-01-20T00:00:40Z","updated_at":"2016-01-20T00:00:40Z","html_url":"https://github.com/chef-cookbooks/docker/pull/608#discussion_r50196337","pull_request_url":"https://api.github.com/repos/chef-cookbooks/docker/pulls/608","_links":{"self":{"href":"https://api.github.com/repos/chef-cookbooks/docker/pulls/comments/50196337"},"html":{"href":"https://github.com/chef-cookbooks/docker/pull/608#discussion_r50196337"},"pull_request":{"href":"https://api.github.com/repos/chef-cookbooks/docker/pulls/608"}}},"pull_request":{"url":"https://api.github.com/repos/chef-cookbooks/docker/pulls/608","id":56545223,"html_url":"https://github.com/chef-cookbooks/docker/pull/608","diff_url":"https://github.com/chef-cookbooks/docker/pull/608.diff","patch_url":"https://github.com/chef-cookbooks/docker/pull/608.patch","issue_url":"https://api.github.com/repos/chef-cookbooks/docker/issues/608","number":608,"state":"open","locked":false,"title":"setting container property defaults to match docker cli","user":{"login":"chasebolt","id":1222984,"avatar_url":"https://avatars.githubusercontent.com/u/1222984?v=3","gravatar_id":"","url":"https://api.github.com/users/chasebolt","html_url":"https://github.com/chasebolt","followers_url":"https://api.github.com/users/chasebolt/followers","following_url":"https://api.github.com/users/chasebolt/following{/other_user}","gists_url":"https://api.github.com/users/chasebolt/gists{/gist_id}","starred_url":"https://api.github.com/users/chasebolt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chasebolt/subscriptions","organizations_url":"https://api.github.com/users/chasebolt/orgs","repos_url":"https://api.github.com/users/chasebolt/repos","events_url":"https://api.github.com/users/chasebolt/events{/privacy}","received_events_url":"https://api.github.com/users/chasebolt/received_events","type":"User","site_admin":false},"body":"i think this should help resolve #597. compact was clobbering empty settings, which apparently can be important in certain cases.","created_at":"2016-01-19T23:59:04Z","updated_at":"2016-01-20T00:00:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1127c7726a5a3dfc0f0381e9d7135584c862f1a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/chef-cookbooks/docker/pulls/608/commits","review_comments_url":"https://api.github.com/repos/chef-cookbooks/docker/pulls/608/comments","review_comment_url":"https://api.github.com/repos/chef-cookbooks/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef-cookbooks/docker/issues/608/comments","statuses_url":"https://api.github.com/repos/chef-cookbooks/docker/statuses/591edb1b69c7f587fa8099a90586ca0102b3db46","head":{"label":"chasebolt:property-defaults","ref":"property-defaults","sha":"591edb1b69c7f587fa8099a90586ca0102b3db46","user":{"login":"chasebolt","id":1222984,"avatar_url":"https://avatars.githubusercontent.com/u/1222984?v=3","gravatar_id":"","url":"https://api.github.com/users/chasebolt","html_url":"https://github.com/chasebolt","followers_url":"https://api.github.com/users/chasebolt/followers","following_url":"https://api.github.com/users/chasebolt/following{/other_user}","gists_url":"https://api.github.com/users/chasebolt/gists{/gist_id}","starred_url":"https://api.github.com/users/chasebolt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chasebolt/subscriptions","organizations_url":"https://api.github.com/users/chasebolt/orgs","repos_url":"https://api.github.com/users/chasebolt/repos","events_url":"https://api.github.com/users/chasebolt/events{/privacy}","received_events_url":"https://api.github.com/users/chasebolt/received_events","type":"User","site_admin":false},"repo":{"id":40998563,"name":"chef-docker","full_name":"chasebolt/chef-docker","owner":{"login":"chasebolt","id":1222984,"avatar_url":"https://avatars.githubusercontent.com/u/1222984?v=3","gravatar_id":"","url":"https://api.github.com/users/chasebolt","html_url":"https://github.com/chasebolt","followers_url":"https://api.github.com/users/chasebolt/followers","following_url":"https://api.github.com/users/chasebolt/following{/other_user}","gists_url":"https://api.github.com/users/chasebolt/gists{/gist_id}","starred_url":"https://api.github.com/users/chasebolt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chasebolt/subscriptions","organizations_url":"https://api.github.com/users/chasebolt/orgs","repos_url":"https://api.github.com/users/chasebolt/repos","events_url":"https://api.github.com/users/chasebolt/events{/privacy}","received_events_url":"https://api.github.com/users/chasebolt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chasebolt/chef-docker","description":"Chef Cookbook for Docker","fork":true,"url":"https://api.github.com/repos/chasebolt/chef-docker","forks_url":"https://api.github.com/repos/chasebolt/chef-docker/forks","keys_url":"https://api.github.com/repos/chasebolt/chef-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chasebolt/chef-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chasebolt/chef-docker/teams","hooks_url":"https://api.github.com/repos/chasebolt/chef-docker/hooks","issue_events_url":"https://api.github.com/repos/chasebolt/chef-docker/issues/events{/number}","events_url":"https://api.github.com/repos/chasebolt/chef-docker/events","assignees_url":"https://api.github.com/repos/chasebolt/chef-docker/assignees{/user}","branches_url":"https://api.github.com/repos/chasebolt/chef-docker/branches{/branch}","tags_url":"https://api.github.com/repos/chasebolt/chef-docker/tags","blobs_url":"https://api.github.com/repos/chasebolt/chef-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chasebolt/chef-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chasebolt/chef-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/chasebolt/chef-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chasebolt/chef-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/chasebolt/chef-docker/languages","stargazers_url":"https://api.github.com/repos/chasebolt/chef-docker/stargazers","contributors_url":"https://api.github.com/repos/chasebolt/chef-docker/contributors","subscribers_url":"https://api.github.com/repos/chasebolt/chef-docker/subscribers","subscription_url":"https://api.github.com/repos/chasebolt/chef-docker/subscription","commits_url":"https://api.github.com/repos/chasebolt/chef-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/chasebolt/chef-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/chasebolt/chef-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/chasebolt/chef-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/chasebolt/chef-docker/contents/{+path}","compare_url":"https://api.github.com/repos/chasebolt/chef-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chasebolt/chef-docker/merges","archive_url":"https://api.github.com/repos/chasebolt/chef-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chasebolt/chef-docker/downloads","issues_url":"https://api.github.com/repos/chasebolt/chef-docker/issues{/number}","pulls_url":"https://api.github.com/repos/chasebolt/chef-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/chasebolt/chef-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/chasebolt/chef-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chasebolt/chef-docker/labels{/name}","releases_url":"https://api.github.com/repos/chasebolt/chef-docker/releases{/id}","created_at":"2015-08-18T21:32:02Z","updated_at":"2016-01-15T00:03:29Z","pushed_at":"2016-01-19T23:57:51Z","git_url":"git://github.com/chasebolt/chef-docker.git","ssh_url":"git@github.com:chasebolt/chef-docker.git","clone_url":"https://github.com/chasebolt/chef-docker.git","svn_url":"https://github.com/chasebolt/chef-docker","homepage":null,"size":3001,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chef-cookbooks:master","ref":"master","sha":"889c4738a1702e8c010f937ee3526309d111c550","user":{"login":"chef-cookbooks","id":3617830,"avatar_url":"https://avatars.githubusercontent.com/u/3617830?v=3","gravatar_id":"","url":"https://api.github.com/users/chef-cookbooks","html_url":"https://github.com/chef-cookbooks","followers_url":"https://api.github.com/users/chef-cookbooks/followers","following_url":"https://api.github.com/users/chef-cookbooks/following{/other_user}","gists_url":"https://api.github.com/users/chef-cookbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/chef-cookbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef-cookbooks/subscriptions","organizations_url":"https://api.github.com/users/chef-cookbooks/orgs","repos_url":"https://api.github.com/users/chef-cookbooks/repos","events_url":"https://api.github.com/users/chef-cookbooks/events{/privacy}","received_events_url":"https://api.github.com/users/chef-cookbooks/received_events","type":"Organization","site_admin":false},"repo":{"id":9992805,"name":"docker","full_name":"chef-cookbooks/docker","owner":{"login":"chef-cookbooks","id":3617830,"avatar_url":"https://avatars.githubusercontent.com/u/3617830?v=3","gravatar_id":"","url":"https://api.github.com/users/chef-cookbooks","html_url":"https://github.com/chef-cookbooks","followers_url":"https://api.github.com/users/chef-cookbooks/followers","following_url":"https://api.github.com/users/chef-cookbooks/following{/other_user}","gists_url":"https://api.github.com/users/chef-cookbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/chef-cookbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef-cookbooks/subscriptions","organizations_url":"https://api.github.com/users/chef-cookbooks/orgs","repos_url":"https://api.github.com/users/chef-cookbooks/repos","events_url":"https://api.github.com/users/chef-cookbooks/events{/privacy}","received_events_url":"https://api.github.com/users/chef-cookbooks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef-cookbooks/docker","description":"Chef Cookbook for Docker","fork":false,"url":"https://api.github.com/repos/chef-cookbooks/docker","forks_url":"https://api.github.com/repos/chef-cookbooks/docker/forks","keys_url":"https://api.github.com/repos/chef-cookbooks/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef-cookbooks/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef-cookbooks/docker/teams","hooks_url":"https://api.github.com/repos/chef-cookbooks/docker/hooks","issue_events_url":"https://api.github.com/repos/chef-cookbooks/docker/issues/events{/number}","events_url":"https://api.github.com/repos/chef-cookbooks/docker/events","assignees_url":"https://api.github.com/repos/chef-cookbooks/docker/assignees{/user}","branches_url":"https://api.github.com/repos/chef-cookbooks/docker/branches{/branch}","tags_url":"https://api.github.com/repos/chef-cookbooks/docker/tags","blobs_url":"https://api.github.com/repos/chef-cookbooks/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef-cookbooks/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef-cookbooks/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef-cookbooks/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef-cookbooks/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/chef-cookbooks/docker/languages","stargazers_url":"https://api.github.com/repos/chef-cookbooks/docker/stargazers","contributors_url":"https://api.github.com/repos/chef-cookbooks/docker/contributors","subscribers_url":"https://api.github.com/repos/chef-cookbooks/docker/subscribers","subscription_url":"https://api.github.com/repos/chef-cookbooks/docker/subscription","commits_url":"https://api.github.com/repos/chef-cookbooks/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef-cookbooks/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef-cookbooks/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef-cookbooks/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef-cookbooks/docker/contents/{+path}","compare_url":"https://api.github.com/repos/chef-cookbooks/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef-cookbooks/docker/merges","archive_url":"https://api.github.com/repos/chef-cookbooks/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef-cookbooks/docker/downloads","issues_url":"https://api.github.com/repos/chef-cookbooks/docker/issues{/number}","pulls_url":"https://api.github.com/repos/chef-cookbooks/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/chef-cookbooks/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/chef-cookbooks/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef-cookbooks/docker/labels{/name}","releases_url":"https://api.github.com/repos/chef-cookbooks/docker/releases{/id}","created_at":"2013-05-11T00:21:06Z","updated_at":"2016-01-18T14:48:38Z","pushed_at":"2016-01-19T23:59:04Z","git_url":"git://github.com/chef-cookbooks/docker.git","ssh_url":"git@github.com:chef-cookbooks/docker.git","clone_url":"https://github.com/chef-cookbooks/docker.git","svn_url":"https://github.com/chef-cookbooks/docker","homepage":null,"size":3246,"stargazers_count":477,"watchers_count":477,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":275,"mirror_url":null,"open_issues_count":16,"forks":275,"open_issues":16,"watchers":477,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef-cookbooks/docker/pulls/608"},"html":{"href":"https://github.com/chef-cookbooks/docker/pull/608"},"issue":{"href":"https://api.github.com/repos/chef-cookbooks/docker/issues/608"},"comments":{"href":"https://api.github.com/repos/chef-cookbooks/docker/issues/608/comments"},"review_comments":{"href":"https://api.github.com/repos/chef-cookbooks/docker/pulls/608/comments"},"review_comment":{"href":"https://api.github.com/repos/chef-cookbooks/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef-cookbooks/docker/pulls/608/commits"},"statuses":{"href":"https://api.github.com/repos/chef-cookbooks/docker/statuses/591edb1b69c7f587fa8099a90586ca0102b3db46"}}}}