{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/pulls/comments/85470355","pull_request_review_id":6185295,"id":85470355,"diff_hunk":"@@ -84,6 +84,72 @@ public void nodesTest1() throws IOException, ExecutionException, InterruptedExce\n         }\n     }\n \n+    //JENKINS-39203\n+    @Test\n+    public void stepStatusForUnstableBuild() throws Exception{\n+        String p = \"node {\\n\" +\n+                \"   echo 'Hello World'\\n\" +\n+                \"   try{\\n\" +\n+                \"    echo 'Inside try'\\n\" +\n+                \"   }finally{\\n\" +\n+                \"    sh 'echo \\\"blah\\\"' \\n\" +\n+                \"    currentBuild.result = \\\"UNSTABLE\\\"\\n\" +\n+                \"   }\\n\" +\n+                \"}\";\n+\n+        WorkflowJob job1 = j.jenkins.createProject(WorkflowJob.class, \"pipeline1\");\n+\n+        job1.setDefinition(new CpsFlowDefinition(p));\n+\n+        WorkflowRun b1 = job1.scheduleBuild2(0).get();\n+        j.assertBuildStatus(Result.UNSTABLE,b1);\n+\n+        List<Map> resp = get(\"/organizations/jenkins/pipelines/pipeline1/runs/1/steps/\", List.class);\n+        Assert.assertEquals(resp.size(),3);\n+\n+        for(int i=0; i< resp.size();i++) {\n+            Map rn = resp.get(i);\n+            Assert.assertEquals(rn.get(\"result\"), \"SUCCESS\");","path":"blueocean-pipeline-api-impl/src/test/java/io/jenkins/blueocean/rest/impl/pipeline/PipelineNodeTest.java","position":29,"original_position":29,"commit_id":"f3cff490e37f92e8b37d1523762410665a719474","original_commit_id":"f3cff490e37f92e8b37d1523762410665a719474","user":{"login":"vivek","id":38139,"avatar_url":"https://avatars.githubusercontent.com/u/38139?v=3","gravatar_id":"","url":"https://api.github.com/users/vivek","html_url":"https://github.com/vivek","followers_url":"https://api.github.com/users/vivek/followers","following_url":"https://api.github.com/users/vivek/following{/other_user}","gists_url":"https://api.github.com/users/vivek/gists{/gist_id}","starred_url":"https://api.github.com/users/vivek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivek/subscriptions","organizations_url":"https://api.github.com/users/vivek/orgs","repos_url":"https://api.github.com/users/vivek/repos","events_url":"https://api.github.com/users/vivek/events{/privacy}","received_events_url":"https://api.github.com/users/vivek/received_events","type":"User","site_admin":false},"body":"@michaelneale because each step had successful run. See the pipeline script.","created_at":"2016-10-28T04:23:33Z","updated_at":"2016-10-28T04:23:33Z","html_url":"https://github.com/jenkinsci/blueocean-plugin/pull/577#discussion_r85470355","pull_request_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/pulls/577","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/blueocean-plugin/pulls/comments/85470355"},"html":{"href":"https://github.com/jenkinsci/blueocean-plugin/pull/577#discussion_r85470355"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/blueocean-plugin/pulls/577"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/pulls/577","id":91310874,"html_url":"https://github.com/jenkinsci/blueocean-plugin/pull/577","diff_url":"https://github.com/jenkinsci/blueocean-plugin/pull/577.diff","patch_url":"https://github.com/jenkinsci/blueocean-plugin/pull/577.patch","issue_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/issues/577","number":577,"state":"open","locked":false,"title":"JENKINS-39296# Fix to show step's status correctly","user":{"login":"vivek","id":38139,"avatar_url":"https://avatars.githubusercontent.com/u/38139?v=3","gravatar_id":"","url":"https://api.github.com/users/vivek","html_url":"https://github.com/vivek","followers_url":"https://api.github.com/users/vivek/followers","following_url":"https://api.github.com/users/vivek/following{/other_user}","gists_url":"https://api.github.com/users/vivek/gists{/gist_id}","starred_url":"https://api.github.com/users/vivek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivek/subscriptions","organizations_url":"https://api.github.com/users/vivek/orgs","repos_url":"https://api.github.com/users/vivek/repos","events_url":"https://api.github.com/users/vivek/events{/privacy}","received_events_url":"https://api.github.com/users/vivek/received_events","type":"User","site_admin":false},"body":"# Description\r\n\r\nSee [JENKINS-39296](https://issues.jenkins-ci.org/browse/JENKINS-39296).\r\n\r\nTo manually test, create pipeline job to create unstable run with steps that are successful. Also create job with failing and successful steps, each sep should demonstrate correct status.\r\n\r\n**Please note:**\r\n\r\n* Underlying Pipeline library (and bismuth library) doesn't give a ways to determine ABORTED or UNSTABLE result at individual Step FlowNode level. So if a Run is aborted, the step that gets aborted is reported as simply error. There is not status to say if its unstable.\r\n\r\n\r\n# Submitter checklist\r\n- [x] Link to JIRA ticket in description, if appropriate.\r\n- [x] Change is code complete and matches issue description\r\n- [x] Appropriate unit or acceptance tests or explanation to why this change has no tests\r\n- [x] Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.\r\n- [x] Ran Acceptance Test Harness against PR changes.\r\n\r\nTriggered https://ci.blueocean.io/job/ATH-Jenkinsfile/job/master/227/\r\n\r\n# Reviewer checklist\r\n- [ ] Run the changes and verified the change matches the issue description\r\n- [ ] Reviewed the code\r\n- [ ] Verified that the appropriate tests have been written or valid explanation given\r\n\r\n@jenkinsci/code-reviewers @reviewbybees \r\n\r\n","created_at":"2016-10-28T01:58:45Z","updated_at":"2016-10-28T04:23:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77024f634e2ceb73dd9b6e158a1fb730cf8e85d0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/pulls/577/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/pulls/577/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/issues/577/comments","statuses_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/statuses/f3cff490e37f92e8b37d1523762410665a719474","head":{"label":"jenkinsci:bug/JENKINS-39296","ref":"bug/JENKINS-39296","sha":"f3cff490e37f92e8b37d1523762410665a719474","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":50250915,"name":"blueocean-plugin","full_name":"jenkinsci/blueocean-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/blueocean-plugin","description":"Blue Ocean is a reboot of the Jenkins CI/CD User Experience","fork":false,"url":"https://api.github.com/repos/jenkinsci/blueocean-plugin","forks_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/deployments","created_at":"2016-01-23T18:02:45Z","updated_at":"2016-10-28T03:08:01Z","pushed_at":"2016-10-28T01:58:45Z","git_url":"git://github.com/jenkinsci/blueocean-plugin.git","ssh_url":"git@github.com:jenkinsci/blueocean-plugin.git","clone_url":"https://github.com/jenkinsci/blueocean-plugin.git","svn_url":"https://github.com/jenkinsci/blueocean-plugin","homepage":"https://jenkins.io/projects/blueocean/","size":11892,"stargazers_count":1308,"watchers_count":1308,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":115,"mirror_url":null,"open_issues_count":13,"forks":115,"open_issues":13,"watchers":1308,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"47f591995b2360aeb2e828490944a6f892ecfae6","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":50250915,"name":"blueocean-plugin","full_name":"jenkinsci/blueocean-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/blueocean-plugin","description":"Blue Ocean is a reboot of the Jenkins CI/CD User Experience","fork":false,"url":"https://api.github.com/repos/jenkinsci/blueocean-plugin","forks_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/deployments","created_at":"2016-01-23T18:02:45Z","updated_at":"2016-10-28T03:08:01Z","pushed_at":"2016-10-28T01:58:45Z","git_url":"git://github.com/jenkinsci/blueocean-plugin.git","ssh_url":"git@github.com:jenkinsci/blueocean-plugin.git","clone_url":"https://github.com/jenkinsci/blueocean-plugin.git","svn_url":"https://github.com/jenkinsci/blueocean-plugin","homepage":"https://jenkins.io/projects/blueocean/","size":11892,"stargazers_count":1308,"watchers_count":1308,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":115,"mirror_url":null,"open_issues_count":13,"forks":115,"open_issues":13,"watchers":1308,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/blueocean-plugin/pulls/577"},"html":{"href":"https://github.com/jenkinsci/blueocean-plugin/pull/577"},"issue":{"href":"https://api.github.com/repos/jenkinsci/blueocean-plugin/issues/577"},"comments":{"href":"https://api.github.com/repos/jenkinsci/blueocean-plugin/issues/577/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/blueocean-plugin/pulls/577/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/blueocean-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/blueocean-plugin/pulls/577/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/blueocean-plugin/statuses/f3cff490e37f92e8b37d1523762410665a719474"}}}}
{"actor":{"display_login":"vivek"}}