{"action":"created","comment":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/comments/56487403","id":56487403,"diff_hunk":"@@ -400,21 +501,40 @@ CAMLprim value caml_ephe_blit_key (value ars, value ofs,\n       do_set (ard, offset_d + i,  Field (ars, offset_s + i));\n     }\n   }\n+}\n+\n+CAMLprim value caml_ephe_blit_key (value ars, value ofs,\n+                                   value ard, value ofd, value len)\n+{\n+  if (Long_val(len) == 0) return Val_unit;\n+  mlsize_t offset_s = raise_if_invalid_offset(ars, ofs, \"Weak.blit\");\n+  mlsize_t offset_d = raise_if_invalid_offset(ard, ofd, \"Weak.blit\");\n+  mlsize_t length = Long_val (len);","path":"byterun/weak.c","position":545,"original_position":545,"commit_id":"4f156a56b0f361f8f9130512cd09eb092262177c","original_commit_id":"4f156a56b0f361f8f9130512cd09eb092262177c","user":{"login":"mshinwell","id":1315488,"avatar_url":"https://avatars.githubusercontent.com/u/1315488?v=3","gravatar_id":"","url":"https://api.github.com/users/mshinwell","html_url":"https://github.com/mshinwell","followers_url":"https://api.github.com/users/mshinwell/followers","following_url":"https://api.github.com/users/mshinwell/following{/other_user}","gists_url":"https://api.github.com/users/mshinwell/gists{/gist_id}","starred_url":"https://api.github.com/users/mshinwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mshinwell/subscriptions","organizations_url":"https://api.github.com/users/mshinwell/orgs","repos_url":"https://api.github.com/users/mshinwell/repos","events_url":"https://api.github.com/users/mshinwell/events{/privacy}","received_events_url":"https://api.github.com/users/mshinwell/received_events","type":"User","site_admin":false},"body":"It should pass the name then.\r\nWe should never have wrong function names in error messages.","created_at":"2016-03-17T11:06:30Z","updated_at":"2016-03-17T11:06:30Z","html_url":"https://github.com/ocaml/ocaml/pull/515#discussion_r56487403","pull_request_url":"https://api.github.com/repos/ocaml/ocaml/pulls/515","_links":{"self":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/comments/56487403"},"html":{"href":"https://github.com/ocaml/ocaml/pull/515#discussion_r56487403"},"pull_request":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/515"}}},"pull_request":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/515","id":63202167,"html_url":"https://github.com/ocaml/ocaml/pull/515","diff_url":"https://github.com/ocaml/ocaml/pull/515.diff","patch_url":"https://github.com/ocaml/ocaml/pull/515.patch","issue_url":"https://api.github.com/repos/ocaml/ocaml/issues/515","number":515,"state":"open","locked":false,"title":"Add a C api for ephemerons and weak arrays","user":{"login":"bobot","id":102849,"avatar_url":"https://avatars.githubusercontent.com/u/102849?v=3","gravatar_id":"","url":"https://api.github.com/users/bobot","html_url":"https://github.com/bobot","followers_url":"https://api.github.com/users/bobot/followers","following_url":"https://api.github.com/users/bobot/following{/other_user}","gists_url":"https://api.github.com/users/bobot/gists{/gist_id}","starred_url":"https://api.github.com/users/bobot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobot/subscriptions","organizations_url":"https://api.github.com/users/bobot/orgs","repos_url":"https://api.github.com/users/bobot/repos","events_url":"https://api.github.com/users/bobot/events{/privacy}","received_events_url":"https://api.github.com/users/bobot/received_events","type":"User","site_admin":false},"body":"Fix [#7173](http://caml.inria.fr/mantis/view.php?id=7173). There is a discussion in mantis if it should go to 4.03. I'm not convinced, except for the two first commits. I can create a separate GPR for them.","created_at":"2016-03-17T10:37:05Z","updated_at":"2016-03-17T11:06:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aada8761038b485fbe507886e41ca291d48532a4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ocaml/ocaml/pulls/515/commits","review_comments_url":"https://api.github.com/repos/ocaml/ocaml/pulls/515/comments","review_comment_url":"https://api.github.com/repos/ocaml/ocaml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ocaml/ocaml/issues/515/comments","statuses_url":"https://api.github.com/repos/ocaml/ocaml/statuses/4f156a56b0f361f8f9130512cd09eb092262177c","head":{"label":"bobot:ephemeron_c_api","ref":"ephemeron_c_api","sha":"4f156a56b0f361f8f9130512cd09eb092262177c","user":{"login":"bobot","id":102849,"avatar_url":"https://avatars.githubusercontent.com/u/102849?v=3","gravatar_id":"","url":"https://api.github.com/users/bobot","html_url":"https://github.com/bobot","followers_url":"https://api.github.com/users/bobot/followers","following_url":"https://api.github.com/users/bobot/following{/other_user}","gists_url":"https://api.github.com/users/bobot/gists{/gist_id}","starred_url":"https://api.github.com/users/bobot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobot/subscriptions","organizations_url":"https://api.github.com/users/bobot/orgs","repos_url":"https://api.github.com/users/bobot/repos","events_url":"https://api.github.com/users/bobot/events{/privacy}","received_events_url":"https://api.github.com/users/bobot/received_events","type":"User","site_admin":false},"repo":{"id":14594404,"name":"ocaml","full_name":"bobot/ocaml","owner":{"login":"bobot","id":102849,"avatar_url":"https://avatars.githubusercontent.com/u/102849?v=3","gravatar_id":"","url":"https://api.github.com/users/bobot","html_url":"https://github.com/bobot","followers_url":"https://api.github.com/users/bobot/followers","following_url":"https://api.github.com/users/bobot/following{/other_user}","gists_url":"https://api.github.com/users/bobot/gists{/gist_id}","starred_url":"https://api.github.com/users/bobot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobot/subscriptions","organizations_url":"https://api.github.com/users/bobot/orgs","repos_url":"https://api.github.com/users/bobot/repos","events_url":"https://api.github.com/users/bobot/events{/privacy}","received_events_url":"https://api.github.com/users/bobot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bobot/ocaml","description":"Read-only mirror of INRIA SVN","fork":true,"url":"https://api.github.com/repos/bobot/ocaml","forks_url":"https://api.github.com/repos/bobot/ocaml/forks","keys_url":"https://api.github.com/repos/bobot/ocaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bobot/ocaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bobot/ocaml/teams","hooks_url":"https://api.github.com/repos/bobot/ocaml/hooks","issue_events_url":"https://api.github.com/repos/bobot/ocaml/issues/events{/number}","events_url":"https://api.github.com/repos/bobot/ocaml/events","assignees_url":"https://api.github.com/repos/bobot/ocaml/assignees{/user}","branches_url":"https://api.github.com/repos/bobot/ocaml/branches{/branch}","tags_url":"https://api.github.com/repos/bobot/ocaml/tags","blobs_url":"https://api.github.com/repos/bobot/ocaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bobot/ocaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bobot/ocaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/bobot/ocaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bobot/ocaml/statuses/{sha}","languages_url":"https://api.github.com/repos/bobot/ocaml/languages","stargazers_url":"https://api.github.com/repos/bobot/ocaml/stargazers","contributors_url":"https://api.github.com/repos/bobot/ocaml/contributors","subscribers_url":"https://api.github.com/repos/bobot/ocaml/subscribers","subscription_url":"https://api.github.com/repos/bobot/ocaml/subscription","commits_url":"https://api.github.com/repos/bobot/ocaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/bobot/ocaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/bobot/ocaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/bobot/ocaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/bobot/ocaml/contents/{+path}","compare_url":"https://api.github.com/repos/bobot/ocaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bobot/ocaml/merges","archive_url":"https://api.github.com/repos/bobot/ocaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bobot/ocaml/downloads","issues_url":"https://api.github.com/repos/bobot/ocaml/issues{/number}","pulls_url":"https://api.github.com/repos/bobot/ocaml/pulls{/number}","milestones_url":"https://api.github.com/repos/bobot/ocaml/milestones{/number}","notifications_url":"https://api.github.com/repos/bobot/ocaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bobot/ocaml/labels{/name}","releases_url":"https://api.github.com/repos/bobot/ocaml/releases{/id}","deployments_url":"https://api.github.com/repos/bobot/ocaml/deployments","created_at":"2013-11-21T17:21:31Z","updated_at":"2014-04-04T16:31:18Z","pushed_at":"2016-03-17T10:43:17Z","git_url":"git://github.com/bobot/ocaml.git","ssh_url":"git@github.com:bobot/ocaml.git","clone_url":"https://github.com/bobot/ocaml.git","svn_url":"https://github.com/bobot/ocaml","homepage":null,"size":101507,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"feature/ephemeron_kn"}},"base":{"label":"ocaml:4.03","ref":"4.03","sha":"19727817c22e7a968bdda5108b586f4a5730d5b7","user":{"login":"ocaml","id":1841483,"avatar_url":"https://avatars.githubusercontent.com/u/1841483?v=3","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"repo":{"id":6786166,"name":"ocaml","full_name":"ocaml/ocaml","owner":{"login":"ocaml","id":1841483,"avatar_url":"https://avatars.githubusercontent.com/u/1841483?v=3","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ocaml/ocaml","description":"The core OCaml system: compilers, runtime system, base libraries","fork":false,"url":"https://api.github.com/repos/ocaml/ocaml","forks_url":"https://api.github.com/repos/ocaml/ocaml/forks","keys_url":"https://api.github.com/repos/ocaml/ocaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocaml/ocaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocaml/ocaml/teams","hooks_url":"https://api.github.com/repos/ocaml/ocaml/hooks","issue_events_url":"https://api.github.com/repos/ocaml/ocaml/issues/events{/number}","events_url":"https://api.github.com/repos/ocaml/ocaml/events","assignees_url":"https://api.github.com/repos/ocaml/ocaml/assignees{/user}","branches_url":"https://api.github.com/repos/ocaml/ocaml/branches{/branch}","tags_url":"https://api.github.com/repos/ocaml/ocaml/tags","blobs_url":"https://api.github.com/repos/ocaml/ocaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocaml/ocaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocaml/ocaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocaml/ocaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocaml/ocaml/statuses/{sha}","languages_url":"https://api.github.com/repos/ocaml/ocaml/languages","stargazers_url":"https://api.github.com/repos/ocaml/ocaml/stargazers","contributors_url":"https://api.github.com/repos/ocaml/ocaml/contributors","subscribers_url":"https://api.github.com/repos/ocaml/ocaml/subscribers","subscription_url":"https://api.github.com/repos/ocaml/ocaml/subscription","commits_url":"https://api.github.com/repos/ocaml/ocaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocaml/ocaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocaml/ocaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocaml/ocaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocaml/ocaml/contents/{+path}","compare_url":"https://api.github.com/repos/ocaml/ocaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocaml/ocaml/merges","archive_url":"https://api.github.com/repos/ocaml/ocaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocaml/ocaml/downloads","issues_url":"https://api.github.com/repos/ocaml/ocaml/issues{/number}","pulls_url":"https://api.github.com/repos/ocaml/ocaml/pulls{/number}","milestones_url":"https://api.github.com/repos/ocaml/ocaml/milestones{/number}","notifications_url":"https://api.github.com/repos/ocaml/ocaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocaml/ocaml/labels{/name}","releases_url":"https://api.github.com/repos/ocaml/ocaml/releases{/id}","deployments_url":"https://api.github.com/repos/ocaml/ocaml/deployments","created_at":"2012-11-20T22:18:22Z","updated_at":"2016-03-17T07:58:53Z","pushed_at":"2016-03-17T10:43:18Z","git_url":"git://github.com/ocaml/ocaml.git","ssh_url":"git@github.com:ocaml/ocaml.git","clone_url":"https://github.com/ocaml/ocaml.git","svn_url":"https://github.com/ocaml/ocaml","homepage":"","size":231899,"stargazers_count":700,"watchers_count":700,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":226,"mirror_url":null,"open_issues_count":78,"forks":226,"open_issues":78,"watchers":700,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/515"},"html":{"href":"https://github.com/ocaml/ocaml/pull/515"},"issue":{"href":"https://api.github.com/repos/ocaml/ocaml/issues/515"},"comments":{"href":"https://api.github.com/repos/ocaml/ocaml/issues/515/comments"},"review_comments":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/515/comments"},"review_comment":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/515/commits"},"statuses":{"href":"https://api.github.com/repos/ocaml/ocaml/statuses/4f156a56b0f361f8f9130512cd09eb092262177c"}}}}