{"action":"closed","number":4962,"pull_request":{"url":"https://api.github.com/repos/eslint/eslint/pulls/4962","id":56188506,"html_url":"https://github.com/eslint/eslint/pull/4962","diff_url":"https://github.com/eslint/eslint/pull/4962.diff","patch_url":"https://github.com/eslint/eslint/pull/4962.patch","issue_url":"https://api.github.com/repos/eslint/eslint/issues/4962","number":4962,"state":"closed","locked":false,"title":"Update: Rules should get `sourceType` from Program node (fixes #4960)","user":{"login":"nre","id":11390066,"avatar_url":"https://avatars.githubusercontent.com/u/11390066?v=3","gravatar_id":"","url":"https://api.github.com/users/nre","html_url":"https://github.com/nre","followers_url":"https://api.github.com/users/nre/followers","following_url":"https://api.github.com/users/nre/following{/other_user}","gists_url":"https://api.github.com/users/nre/gists{/gist_id}","starred_url":"https://api.github.com/users/nre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nre/subscriptions","organizations_url":"https://api.github.com/users/nre/orgs","repos_url":"https://api.github.com/users/nre/repos","events_url":"https://api.github.com/users/nre/events{/privacy}","received_events_url":"https://api.github.com/users/nre/received_events","type":"User","site_admin":false},"body":"- Update rules:\r\n  - no-eval (and add a 'module' test similar to the 'strict mode' test)\r\n  - no-invalid-this\r\n  - no-redeclare\r\n  - no-use-before-define\r\n- Update 'migrating-to-2.0.0.md'\r\n\r\nNB: The 'strict' rule was updated in #4948.","created_at":"2016-01-15T16:15:25Z","updated_at":"2016-01-16T17:08:59Z","closed_at":"2016-01-16T17:08:59Z","merged_at":"2016-01-16T17:08:59Z","merge_commit_sha":"f4dbaecaed852b1172687ce20e569b610c32cb2e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/eslint/eslint/pulls/4962/commits","review_comments_url":"https://api.github.com/repos/eslint/eslint/pulls/4962/comments","review_comment_url":"https://api.github.com/repos/eslint/eslint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eslint/eslint/issues/4962/comments","statuses_url":"https://api.github.com/repos/eslint/eslint/statuses/da3336cf84e3df800a3a2065dc814a01e3bf6adc","head":{"label":"nre:issue4960","ref":"issue4960","sha":"da3336cf84e3df800a3a2065dc814a01e3bf6adc","user":{"login":"nre","id":11390066,"avatar_url":"https://avatars.githubusercontent.com/u/11390066?v=3","gravatar_id":"","url":"https://api.github.com/users/nre","html_url":"https://github.com/nre","followers_url":"https://api.github.com/users/nre/followers","following_url":"https://api.github.com/users/nre/following{/other_user}","gists_url":"https://api.github.com/users/nre/gists{/gist_id}","starred_url":"https://api.github.com/users/nre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nre/subscriptions","organizations_url":"https://api.github.com/users/nre/orgs","repos_url":"https://api.github.com/users/nre/repos","events_url":"https://api.github.com/users/nre/events{/privacy}","received_events_url":"https://api.github.com/users/nre/received_events","type":"User","site_admin":false},"repo":{"id":47771367,"name":"eslint","full_name":"nre/eslint","owner":{"login":"nre","id":11390066,"avatar_url":"https://avatars.githubusercontent.com/u/11390066?v=3","gravatar_id":"","url":"https://api.github.com/users/nre","html_url":"https://github.com/nre","followers_url":"https://api.github.com/users/nre/followers","following_url":"https://api.github.com/users/nre/following{/other_user}","gists_url":"https://api.github.com/users/nre/gists{/gist_id}","starred_url":"https://api.github.com/users/nre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nre/subscriptions","organizations_url":"https://api.github.com/users/nre/orgs","repos_url":"https://api.github.com/users/nre/repos","events_url":"https://api.github.com/users/nre/events{/privacy}","received_events_url":"https://api.github.com/users/nre/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nre/eslint","description":"A fully pluggable tool for identifying and reporting on patterns in JavaScript.","fork":true,"url":"https://api.github.com/repos/nre/eslint","forks_url":"https://api.github.com/repos/nre/eslint/forks","keys_url":"https://api.github.com/repos/nre/eslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nre/eslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nre/eslint/teams","hooks_url":"https://api.github.com/repos/nre/eslint/hooks","issue_events_url":"https://api.github.com/repos/nre/eslint/issues/events{/number}","events_url":"https://api.github.com/repos/nre/eslint/events","assignees_url":"https://api.github.com/repos/nre/eslint/assignees{/user}","branches_url":"https://api.github.com/repos/nre/eslint/branches{/branch}","tags_url":"https://api.github.com/repos/nre/eslint/tags","blobs_url":"https://api.github.com/repos/nre/eslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nre/eslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nre/eslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/nre/eslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nre/eslint/statuses/{sha}","languages_url":"https://api.github.com/repos/nre/eslint/languages","stargazers_url":"https://api.github.com/repos/nre/eslint/stargazers","contributors_url":"https://api.github.com/repos/nre/eslint/contributors","subscribers_url":"https://api.github.com/repos/nre/eslint/subscribers","subscription_url":"https://api.github.com/repos/nre/eslint/subscription","commits_url":"https://api.github.com/repos/nre/eslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/nre/eslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/nre/eslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/nre/eslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/nre/eslint/contents/{+path}","compare_url":"https://api.github.com/repos/nre/eslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nre/eslint/merges","archive_url":"https://api.github.com/repos/nre/eslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nre/eslint/downloads","issues_url":"https://api.github.com/repos/nre/eslint/issues{/number}","pulls_url":"https://api.github.com/repos/nre/eslint/pulls{/number}","milestones_url":"https://api.github.com/repos/nre/eslint/milestones{/number}","notifications_url":"https://api.github.com/repos/nre/eslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nre/eslint/labels{/name}","releases_url":"https://api.github.com/repos/nre/eslint/releases{/id}","created_at":"2015-12-10T15:47:18Z","updated_at":"2016-01-11T13:04:36Z","pushed_at":"2016-01-15T16:06:53Z","git_url":"git://github.com/nre/eslint.git","ssh_url":"git@github.com:nre/eslint.git","clone_url":"https://github.com/nre/eslint.git","svn_url":"https://github.com/nre/eslint","homepage":"http://eslint.org","size":9020,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eslint:master","ref":"master","sha":"86d64ca571faa7260233d41b8eb0391a51d59ba0","user":{"login":"eslint","id":6019716,"avatar_url":"https://avatars.githubusercontent.com/u/6019716?v=3","gravatar_id":"","url":"https://api.github.com/users/eslint","html_url":"https://github.com/eslint","followers_url":"https://api.github.com/users/eslint/followers","following_url":"https://api.github.com/users/eslint/following{/other_user}","gists_url":"https://api.github.com/users/eslint/gists{/gist_id}","starred_url":"https://api.github.com/users/eslint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eslint/subscriptions","organizations_url":"https://api.github.com/users/eslint/orgs","repos_url":"https://api.github.com/users/eslint/repos","events_url":"https://api.github.com/users/eslint/events{/privacy}","received_events_url":"https://api.github.com/users/eslint/received_events","type":"Organization","site_admin":false},"repo":{"id":11061773,"name":"eslint","full_name":"eslint/eslint","owner":{"login":"eslint","id":6019716,"avatar_url":"https://avatars.githubusercontent.com/u/6019716?v=3","gravatar_id":"","url":"https://api.github.com/users/eslint","html_url":"https://github.com/eslint","followers_url":"https://api.github.com/users/eslint/followers","following_url":"https://api.github.com/users/eslint/following{/other_user}","gists_url":"https://api.github.com/users/eslint/gists{/gist_id}","starred_url":"https://api.github.com/users/eslint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eslint/subscriptions","organizations_url":"https://api.github.com/users/eslint/orgs","repos_url":"https://api.github.com/users/eslint/repos","events_url":"https://api.github.com/users/eslint/events{/privacy}","received_events_url":"https://api.github.com/users/eslint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eslint/eslint","description":"A fully pluggable tool for identifying and reporting on patterns in JavaScript.","fork":false,"url":"https://api.github.com/repos/eslint/eslint","forks_url":"https://api.github.com/repos/eslint/eslint/forks","keys_url":"https://api.github.com/repos/eslint/eslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eslint/eslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eslint/eslint/teams","hooks_url":"https://api.github.com/repos/eslint/eslint/hooks","issue_events_url":"https://api.github.com/repos/eslint/eslint/issues/events{/number}","events_url":"https://api.github.com/repos/eslint/eslint/events","assignees_url":"https://api.github.com/repos/eslint/eslint/assignees{/user}","branches_url":"https://api.github.com/repos/eslint/eslint/branches{/branch}","tags_url":"https://api.github.com/repos/eslint/eslint/tags","blobs_url":"https://api.github.com/repos/eslint/eslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eslint/eslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eslint/eslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/eslint/eslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eslint/eslint/statuses/{sha}","languages_url":"https://api.github.com/repos/eslint/eslint/languages","stargazers_url":"https://api.github.com/repos/eslint/eslint/stargazers","contributors_url":"https://api.github.com/repos/eslint/eslint/contributors","subscribers_url":"https://api.github.com/repos/eslint/eslint/subscribers","subscription_url":"https://api.github.com/repos/eslint/eslint/subscription","commits_url":"https://api.github.com/repos/eslint/eslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/eslint/eslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/eslint/eslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/eslint/eslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/eslint/eslint/contents/{+path}","compare_url":"https://api.github.com/repos/eslint/eslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eslint/eslint/merges","archive_url":"https://api.github.com/repos/eslint/eslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eslint/eslint/downloads","issues_url":"https://api.github.com/repos/eslint/eslint/issues{/number}","pulls_url":"https://api.github.com/repos/eslint/eslint/pulls{/number}","milestones_url":"https://api.github.com/repos/eslint/eslint/milestones{/number}","notifications_url":"https://api.github.com/repos/eslint/eslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eslint/eslint/labels{/name}","releases_url":"https://api.github.com/repos/eslint/eslint/releases{/id}","created_at":"2013-06-29T23:59:48Z","updated_at":"2016-01-16T16:52:13Z","pushed_at":"2016-01-16T17:08:59Z","git_url":"git://github.com/eslint/eslint.git","ssh_url":"git@github.com:eslint/eslint.git","clone_url":"https://github.com/eslint/eslint.git","svn_url":"https://github.com/eslint/eslint","homepage":"http://eslint.org","size":12177,"stargazers_count":3790,"watchers_count":3790,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":730,"mirror_url":null,"open_issues_count":150,"forks":730,"open_issues":150,"watchers":3790,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eslint/eslint/pulls/4962"},"html":{"href":"https://github.com/eslint/eslint/pull/4962"},"issue":{"href":"https://api.github.com/repos/eslint/eslint/issues/4962"},"comments":{"href":"https://api.github.com/repos/eslint/eslint/issues/4962/comments"},"review_comments":{"href":"https://api.github.com/repos/eslint/eslint/pulls/4962/comments"},"review_comment":{"href":"https://api.github.com/repos/eslint/eslint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eslint/eslint/pulls/4962/commits"},"statuses":{"href":"https://api.github.com/repos/eslint/eslint/statuses/da3336cf84e3df800a3a2065dc814a01e3bf6adc"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"nzakas","id":38546,"avatar_url":"https://avatars.githubusercontent.com/u/38546?v=3","gravatar_id":"","url":"https://api.github.com/users/nzakas","html_url":"https://github.com/nzakas","followers_url":"https://api.github.com/users/nzakas/followers","following_url":"https://api.github.com/users/nzakas/following{/other_user}","gists_url":"https://api.github.com/users/nzakas/gists{/gist_id}","starred_url":"https://api.github.com/users/nzakas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nzakas/subscriptions","organizations_url":"https://api.github.com/users/nzakas/orgs","repos_url":"https://api.github.com/users/nzakas/repos","events_url":"https://api.github.com/users/nzakas/events{/privacy}","received_events_url":"https://api.github.com/users/nzakas/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":11,"deletions":11,"changed_files":6}}