{"action":"created","comment":{"url":"https://api.github.com/repos/tkruse/cpplint/pulls/comments/60845506","id":60845506,"diff_hunk":"@@ -867,7 +867,8 @@ def PrintErrorCounts(self):\n     for category, count in iteritems(self.errors_by_category):\n       sys.stderr.write('Category \\'%s\\' errors found: %d\\n' %\n                        (category, count))\n-    sys.stderr.write('Total errors found: %d\\n' % self.error_count)\n+    if self.error_count == 0 and self.verbose_level > 0:","path":"cpplint.py","position":5,"original_position":5,"commit_id":"655437486bb5561ddf5040f84f97d4bb226af9f4","original_commit_id":"655437486bb5561ddf5040f84f97d4bb226af9f4","user":{"login":"tkruse","id":1525116,"avatar_url":"https://avatars.githubusercontent.com/u/1525116?v=3","gravatar_id":"","url":"https://api.github.com/users/tkruse","html_url":"https://github.com/tkruse","followers_url":"https://api.github.com/users/tkruse/followers","following_url":"https://api.github.com/users/tkruse/following{/other_user}","gists_url":"https://api.github.com/users/tkruse/gists{/gist_id}","starred_url":"https://api.github.com/users/tkruse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkruse/subscriptions","organizations_url":"https://api.github.com/users/tkruse/orgs","repos_url":"https://api.github.com/users/tkruse/repos","events_url":"https://api.github.com/users/tkruse/events{/privacy}","received_events_url":"https://api.github.com/users/tkruse/received_events","type":"User","site_admin":false},"body":"duh, good catch. the function was only called for error-count > 0, and I only tested the good case of no errors.","created_at":"2016-04-24T14:33:32Z","updated_at":"2016-04-24T14:33:32Z","html_url":"https://github.com/tkruse/cpplint/pull/23#discussion_r60845506","pull_request_url":"https://api.github.com/repos/tkruse/cpplint/pulls/23","_links":{"self":{"href":"https://api.github.com/repos/tkruse/cpplint/pulls/comments/60845506"},"html":{"href":"https://github.com/tkruse/cpplint/pull/23#discussion_r60845506"},"pull_request":{"href":"https://api.github.com/repos/tkruse/cpplint/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/tkruse/cpplint/pulls/23","id":67636385,"html_url":"https://github.com/tkruse/cpplint/pull/23","diff_url":"https://github.com/tkruse/cpplint/pull/23.diff","patch_url":"https://github.com/tkruse/cpplint/pull/23.patch","issue_url":"https://api.github.com/repos/tkruse/cpplint/issues/23","number":23,"state":"open","locked":false,"title":"Suppress output unless verbosity > 0","user":{"login":"tkruse","id":1525116,"avatar_url":"https://avatars.githubusercontent.com/u/1525116?v=3","gravatar_id":"","url":"https://api.github.com/users/tkruse","html_url":"https://github.com/tkruse","followers_url":"https://api.github.com/users/tkruse/followers","following_url":"https://api.github.com/users/tkruse/following{/other_user}","gists_url":"https://api.github.com/users/tkruse/gists{/gist_id}","starred_url":"https://api.github.com/users/tkruse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkruse/subscriptions","organizations_url":"https://api.github.com/users/tkruse/orgs","repos_url":"https://api.github.com/users/tkruse/repos","events_url":"https://api.github.com/users/tkruse/events{/privacy}","received_events_url":"https://api.github.com/users/tkruse/received_events","type":"User","site_admin":false},"body":"@itamaro : a quick review, is small change anyway","created_at":"2016-04-24T12:49:55Z","updated_at":"2016-04-24T14:33:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7742d68ea8e64db1f5b907b7e5f986b34cf837ff","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tkruse/cpplint/pulls/23/commits","review_comments_url":"https://api.github.com/repos/tkruse/cpplint/pulls/23/comments","review_comment_url":"https://api.github.com/repos/tkruse/cpplint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tkruse/cpplint/issues/23/comments","statuses_url":"https://api.github.com/repos/tkruse/cpplint/statuses/655437486bb5561ddf5040f84f97d4bb226af9f4","head":{"label":"tkruse:less-verbose","ref":"less-verbose","sha":"655437486bb5561ddf5040f84f97d4bb226af9f4","user":{"login":"tkruse","id":1525116,"avatar_url":"https://avatars.githubusercontent.com/u/1525116?v=3","gravatar_id":"","url":"https://api.github.com/users/tkruse","html_url":"https://github.com/tkruse","followers_url":"https://api.github.com/users/tkruse/followers","following_url":"https://api.github.com/users/tkruse/following{/other_user}","gists_url":"https://api.github.com/users/tkruse/gists{/gist_id}","starred_url":"https://api.github.com/users/tkruse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkruse/subscriptions","organizations_url":"https://api.github.com/users/tkruse/orgs","repos_url":"https://api.github.com/users/tkruse/repos","events_url":"https://api.github.com/users/tkruse/events{/privacy}","received_events_url":"https://api.github.com/users/tkruse/received_events","type":"User","site_admin":false},"repo":{"id":6194458,"name":"cpplint","full_name":"tkruse/cpplint","owner":{"login":"tkruse","id":1525116,"avatar_url":"https://avatars.githubusercontent.com/u/1525116?v=3","gravatar_id":"","url":"https://api.github.com/users/tkruse","html_url":"https://github.com/tkruse","followers_url":"https://api.github.com/users/tkruse/followers","following_url":"https://api.github.com/users/tkruse/following{/other_user}","gists_url":"https://api.github.com/users/tkruse/gists{/gist_id}","starred_url":"https://api.github.com/users/tkruse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkruse/subscriptions","organizations_url":"https://api.github.com/users/tkruse/orgs","repos_url":"https://api.github.com/users/tkruse/repos","events_url":"https://api.github.com/users/tkruse/events{/privacy}","received_events_url":"https://api.github.com/users/tkruse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tkruse/cpplint","description":"Fork of google cpplint to allow publishing on pypi","fork":false,"url":"https://api.github.com/repos/tkruse/cpplint","forks_url":"https://api.github.com/repos/tkruse/cpplint/forks","keys_url":"https://api.github.com/repos/tkruse/cpplint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tkruse/cpplint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tkruse/cpplint/teams","hooks_url":"https://api.github.com/repos/tkruse/cpplint/hooks","issue_events_url":"https://api.github.com/repos/tkruse/cpplint/issues/events{/number}","events_url":"https://api.github.com/repos/tkruse/cpplint/events","assignees_url":"https://api.github.com/repos/tkruse/cpplint/assignees{/user}","branches_url":"https://api.github.com/repos/tkruse/cpplint/branches{/branch}","tags_url":"https://api.github.com/repos/tkruse/cpplint/tags","blobs_url":"https://api.github.com/repos/tkruse/cpplint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tkruse/cpplint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tkruse/cpplint/git/refs{/sha}","trees_url":"https://api.github.com/repos/tkruse/cpplint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tkruse/cpplint/statuses/{sha}","languages_url":"https://api.github.com/repos/tkruse/cpplint/languages","stargazers_url":"https://api.github.com/repos/tkruse/cpplint/stargazers","contributors_url":"https://api.github.com/repos/tkruse/cpplint/contributors","subscribers_url":"https://api.github.com/repos/tkruse/cpplint/subscribers","subscription_url":"https://api.github.com/repos/tkruse/cpplint/subscription","commits_url":"https://api.github.com/repos/tkruse/cpplint/commits{/sha}","git_commits_url":"https://api.github.com/repos/tkruse/cpplint/git/commits{/sha}","comments_url":"https://api.github.com/repos/tkruse/cpplint/comments{/number}","issue_comment_url":"https://api.github.com/repos/tkruse/cpplint/issues/comments{/number}","contents_url":"https://api.github.com/repos/tkruse/cpplint/contents/{+path}","compare_url":"https://api.github.com/repos/tkruse/cpplint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tkruse/cpplint/merges","archive_url":"https://api.github.com/repos/tkruse/cpplint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tkruse/cpplint/downloads","issues_url":"https://api.github.com/repos/tkruse/cpplint/issues{/number}","pulls_url":"https://api.github.com/repos/tkruse/cpplint/pulls{/number}","milestones_url":"https://api.github.com/repos/tkruse/cpplint/milestones{/number}","notifications_url":"https://api.github.com/repos/tkruse/cpplint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tkruse/cpplint/labels{/name}","releases_url":"https://api.github.com/repos/tkruse/cpplint/releases{/id}","deployments_url":"https://api.github.com/repos/tkruse/cpplint/deployments","created_at":"2012-10-12T18:26:05Z","updated_at":"2016-03-15T23:30:33Z","pushed_at":"2016-04-24T14:28:00Z","git_url":"git://github.com/tkruse/cpplint.git","ssh_url":"git@github.com:tkruse/cpplint.git","clone_url":"https://github.com/tkruse/cpplint.git","svn_url":"https://github.com/tkruse/cpplint","homepage":null,"size":546,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":15,"forks":2,"open_issues":15,"watchers":2,"default_branch":"master"}},"base":{"label":"tkruse:master","ref":"master","sha":"b066038bf03c6ee7e270c01769da63847c2840d7","user":{"login":"tkruse","id":1525116,"avatar_url":"https://avatars.githubusercontent.com/u/1525116?v=3","gravatar_id":"","url":"https://api.github.com/users/tkruse","html_url":"https://github.com/tkruse","followers_url":"https://api.github.com/users/tkruse/followers","following_url":"https://api.github.com/users/tkruse/following{/other_user}","gists_url":"https://api.github.com/users/tkruse/gists{/gist_id}","starred_url":"https://api.github.com/users/tkruse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkruse/subscriptions","organizations_url":"https://api.github.com/users/tkruse/orgs","repos_url":"https://api.github.com/users/tkruse/repos","events_url":"https://api.github.com/users/tkruse/events{/privacy}","received_events_url":"https://api.github.com/users/tkruse/received_events","type":"User","site_admin":false},"repo":{"id":6194458,"name":"cpplint","full_name":"tkruse/cpplint","owner":{"login":"tkruse","id":1525116,"avatar_url":"https://avatars.githubusercontent.com/u/1525116?v=3","gravatar_id":"","url":"https://api.github.com/users/tkruse","html_url":"https://github.com/tkruse","followers_url":"https://api.github.com/users/tkruse/followers","following_url":"https://api.github.com/users/tkruse/following{/other_user}","gists_url":"https://api.github.com/users/tkruse/gists{/gist_id}","starred_url":"https://api.github.com/users/tkruse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkruse/subscriptions","organizations_url":"https://api.github.com/users/tkruse/orgs","repos_url":"https://api.github.com/users/tkruse/repos","events_url":"https://api.github.com/users/tkruse/events{/privacy}","received_events_url":"https://api.github.com/users/tkruse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tkruse/cpplint","description":"Fork of google cpplint to allow publishing on pypi","fork":false,"url":"https://api.github.com/repos/tkruse/cpplint","forks_url":"https://api.github.com/repos/tkruse/cpplint/forks","keys_url":"https://api.github.com/repos/tkruse/cpplint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tkruse/cpplint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tkruse/cpplint/teams","hooks_url":"https://api.github.com/repos/tkruse/cpplint/hooks","issue_events_url":"https://api.github.com/repos/tkruse/cpplint/issues/events{/number}","events_url":"https://api.github.com/repos/tkruse/cpplint/events","assignees_url":"https://api.github.com/repos/tkruse/cpplint/assignees{/user}","branches_url":"https://api.github.com/repos/tkruse/cpplint/branches{/branch}","tags_url":"https://api.github.com/repos/tkruse/cpplint/tags","blobs_url":"https://api.github.com/repos/tkruse/cpplint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tkruse/cpplint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tkruse/cpplint/git/refs{/sha}","trees_url":"https://api.github.com/repos/tkruse/cpplint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tkruse/cpplint/statuses/{sha}","languages_url":"https://api.github.com/repos/tkruse/cpplint/languages","stargazers_url":"https://api.github.com/repos/tkruse/cpplint/stargazers","contributors_url":"https://api.github.com/repos/tkruse/cpplint/contributors","subscribers_url":"https://api.github.com/repos/tkruse/cpplint/subscribers","subscription_url":"https://api.github.com/repos/tkruse/cpplint/subscription","commits_url":"https://api.github.com/repos/tkruse/cpplint/commits{/sha}","git_commits_url":"https://api.github.com/repos/tkruse/cpplint/git/commits{/sha}","comments_url":"https://api.github.com/repos/tkruse/cpplint/comments{/number}","issue_comment_url":"https://api.github.com/repos/tkruse/cpplint/issues/comments{/number}","contents_url":"https://api.github.com/repos/tkruse/cpplint/contents/{+path}","compare_url":"https://api.github.com/repos/tkruse/cpplint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tkruse/cpplint/merges","archive_url":"https://api.github.com/repos/tkruse/cpplint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tkruse/cpplint/downloads","issues_url":"https://api.github.com/repos/tkruse/cpplint/issues{/number}","pulls_url":"https://api.github.com/repos/tkruse/cpplint/pulls{/number}","milestones_url":"https://api.github.com/repos/tkruse/cpplint/milestones{/number}","notifications_url":"https://api.github.com/repos/tkruse/cpplint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tkruse/cpplint/labels{/name}","releases_url":"https://api.github.com/repos/tkruse/cpplint/releases{/id}","deployments_url":"https://api.github.com/repos/tkruse/cpplint/deployments","created_at":"2012-10-12T18:26:05Z","updated_at":"2016-03-15T23:30:33Z","pushed_at":"2016-04-24T14:28:00Z","git_url":"git://github.com/tkruse/cpplint.git","ssh_url":"git@github.com:tkruse/cpplint.git","clone_url":"https://github.com/tkruse/cpplint.git","svn_url":"https://github.com/tkruse/cpplint","homepage":null,"size":546,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":15,"forks":2,"open_issues":15,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tkruse/cpplint/pulls/23"},"html":{"href":"https://github.com/tkruse/cpplint/pull/23"},"issue":{"href":"https://api.github.com/repos/tkruse/cpplint/issues/23"},"comments":{"href":"https://api.github.com/repos/tkruse/cpplint/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/tkruse/cpplint/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/tkruse/cpplint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tkruse/cpplint/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/tkruse/cpplint/statuses/655437486bb5561ddf5040f84f97d4bb226af9f4"}}}}