{"action":"created","issue":{"url":"https://api.github.com/repos/mbr/flask-bootstrap/issues/148","repository_url":"https://api.github.com/repos/mbr/flask-bootstrap","labels_url":"https://api.github.com/repos/mbr/flask-bootstrap/issues/148/labels{/name}","comments_url":"https://api.github.com/repos/mbr/flask-bootstrap/issues/148/comments","events_url":"https://api.github.com/repos/mbr/flask-bootstrap/issues/148/events","html_url":"https://github.com/mbr/flask-bootstrap/issues/148","id":191857543,"number":148,"title":"Annoying dependencies","user":{"login":"ael-code","id":4229536,"avatar_url":"https://avatars.githubusercontent.com/u/4229536?v=3","gravatar_id":"","url":"https://api.github.com/users/ael-code","html_url":"https://github.com/ael-code","followers_url":"https://api.github.com/users/ael-code/followers","following_url":"https://api.github.com/users/ael-code/following{/other_user}","gists_url":"https://api.github.com/users/ael-code/gists{/gist_id}","starred_url":"https://api.github.com/users/ael-code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ael-code/subscriptions","organizations_url":"https://api.github.com/users/ael-code/orgs","repos_url":"https://api.github.com/users/ael-code/repos","events_url":"https://api.github.com/users/ael-code/events{/privacy}","received_events_url":"https://api.github.com/users/ael-code/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-27T12:00:02Z","updated_at":"2016-11-27T21:19:45Z","closed_at":null,"body":"I think that this library is very useful and I've used it in a lot of my flask projects.\r\nI've one major issue with the dependencies that it kicks in.\r\nThe two python libraries `visitors` and `dominate` are mandatory dependencies even though they are used only for `WTForms` and `Flask-Nav` libraries integration. Since the usage of these two libraries is optional I think that also `visitors` and `dominate` should be optional dependencies.\r\n\r\nI had a lot of problem packaging some of my app due to this mandatory dependencies and I think that there are a lot of people out there that decided not to use this library exactly for the same reason.\r\nUsing a modular approach and making them optional will make it easier to push this library as package in official repositories of the major linux distributions.\r\n\r\nI really hate to start fork project and I hope that we can collaborate to make this very good library even better."},"comment":{"url":"https://api.github.com/repos/mbr/flask-bootstrap/issues/comments/263148338","html_url":"https://github.com/mbr/flask-bootstrap/issues/148#issuecomment-263148338","issue_url":"https://api.github.com/repos/mbr/flask-bootstrap/issues/148","id":263148338,"user":{"login":"mbr","id":110577,"avatar_url":"https://avatars.githubusercontent.com/u/110577?v=3","gravatar_id":"","url":"https://api.github.com/users/mbr","html_url":"https://github.com/mbr","followers_url":"https://api.github.com/users/mbr/followers","following_url":"https://api.github.com/users/mbr/following{/other_user}","gists_url":"https://api.github.com/users/mbr/gists{/gist_id}","starred_url":"https://api.github.com/users/mbr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbr/subscriptions","organizations_url":"https://api.github.com/users/mbr/orgs","repos_url":"https://api.github.com/users/mbr/repos","events_url":"https://api.github.com/users/mbr/events{/privacy}","received_events_url":"https://api.github.com/users/mbr/received_events","type":"User","site_admin":false},"created_at":"2016-11-27T21:19:45Z","updated_at":"2016-11-27T21:19:45Z","body":"> That's not true on Arch linux :)\r\n\r\nWell, considering Flask-Bootstrap is on AUR already (https://aur.archlinux.org/packages/python-flask-bootstrap/), including dependencies (https://aur.archlinux.org/packages/python-dominate/ , https://aur.archlinux.org/packages/python-visitor/), this whole thing seems to a non-issue.\r\n\r\n> According to you, can the visitors/dominate approach be substitute by an\r\n> implementation that use only jinja2?\r\n\r\nIt is actually going the other direction, the jinja2-based approach is not feasible in the longterm, as the macros get too complicated. The visitor-based approach is much cleaner."}}
{"actor":{"display_login":"mbr"}}