{"push_id":922271662,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"65423bc9e6cb679ada9d00d0f41d3ee2d46ffc7c","before":"095ae4715bb677011e020a52062903162eb12f20","commits":[{"sha":"65423bc9e6cb679ada9d00d0f41d3ee2d46ffc7c","author":{"email":"9c12f37d5571062ab58f9c93cbc2b37309e4e8f3@chromium.org","name":"dbeam"},"message":"Revert of GN: Properly mark all NaCl test depencies as data_deps (patchset #2 id:20001 of https://codereview.chromium.org/1547463004/ )\n\nReason for revert:\nbroke windows GN build:\nhttps://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/9754/steps/generate_build_files/logs/stdio\n\nE:\\b\\build\\slave\\Win_x64_GN\\build\\src\\buildtools\\win\\gn gen //out/Release_x64 \"--args=is_debug=false is_component_build=false use_goma=true goma_dir=\\\"E:\\b\\build\\goma\\\" symbol_level=1\" --check\n  -> returned 1\nERROR Input to target not generated by a dependency.\nThe file:\n  //out/Release_x64/nacl_irt_x86_64.nexe\nis listed as an input or source for the target:\n  //chrome/installer/mini_installer:archive(//build/toolchain/win:x64)\nbut this file was not generated by any dependencies of the target. The target\nthat generates the file is:\n  //ppapi/native_client:nacl_irt_debuglink(//build/toolchain/nacl:irt_x64)\n\nOriginal issue's description:\n> GN: Properly mark all NaCl test depencies as data_deps\n>\n> NaCl tests and helpers are build as standalone executables and\n> hence need to be marked as data_deps to be copied over to shards.\n>\n> BUG=462791\n>\n> Committed: https://crrev.com/21255d8b9b0ace0629fd941ee128cf9adf356b31\n> Cr-Commit-Position: refs/heads/master@{#367367}\n\nTBR=brettw@chromium.org,bradnelson@chromium.org,phosek@chromium.org\nNOPRESUBMIT=true\nNOTREECHECKS=true\nNOTRY=true\nBUG=462791\n\nReview URL: https://codereview.chromium.org/1555223002\n\nCr-Commit-Position: refs/heads/master@{#367396}","distinct":true,"url":"https://api.github.com/repos/dstockwell/chromium/commits/65423bc9e6cb679ada9d00d0f41d3ee2d46ffc7c"}]}