{"action":"created","comment":{"url":"https://api.github.com/repos/linagora/james-project/pulls/comments/59353602","id":59353602,"diff_hunk":"@@ -128,6 +129,11 @@ private void validateParent(Mailbox mailbox, MailboxUpdateRequest updateRequest,\n         }\n     }\n \n+    private boolean isParentIdInRequest(MailboxUpdateRequest updateRequest) {\n+        return updateRequest.getParentId() != null","path":"server/protocols/jmap/src/main/java/org/apache/james/jmap/methods/SetMailboxesUpdateProcessor.java","position":null,"original_position":113,"commit_id":"91283c76fdda5419d5f1ac3f9300abb017c2d335","original_commit_id":"91283c76fdda5419d5f1ac3f9300abb017c2d335","user":{"login":"chibenwa","id":6928740,"avatar_url":"https://avatars.githubusercontent.com/u/6928740?v=3","gravatar_id":"","url":"https://api.github.com/users/chibenwa","html_url":"https://github.com/chibenwa","followers_url":"https://api.github.com/users/chibenwa/followers","following_url":"https://api.github.com/users/chibenwa/following{/other_user}","gists_url":"https://api.github.com/users/chibenwa/gists{/gist_id}","starred_url":"https://api.github.com/users/chibenwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chibenwa/subscriptions","organizations_url":"https://api.github.com/users/chibenwa/orgs","repos_url":"https://api.github.com/users/chibenwa/repos","events_url":"https://api.github.com/users/chibenwa/events{/privacy}","received_events_url":"https://api.github.com/users/chibenwa/received_events","type":"User","site_admin":false},"body":"By the way it seems awkward to me that updateRequest.getParentId() could be null.\r\n Maybe you can set it by default to Optional.empty() rathe than null ?","created_at":"2016-04-12T10:25:38Z","updated_at":"2016-04-12T10:25:38Z","html_url":"https://github.com/linagora/james-project/pull/206#discussion_r59353602","pull_request_url":"https://api.github.com/repos/linagora/james-project/pulls/206","_links":{"self":{"href":"https://api.github.com/repos/linagora/james-project/pulls/comments/59353602"},"html":{"href":"https://github.com/linagora/james-project/pull/206#discussion_r59353602"},"pull_request":{"href":"https://api.github.com/repos/linagora/james-project/pulls/206"}}},"pull_request":{"url":"https://api.github.com/repos/linagora/james-project/pulls/206","id":65466496,"html_url":"https://github.com/linagora/james-project/pull/206","diff_url":"https://github.com/linagora/james-project/pull/206.diff","patch_url":"https://github.com/linagora/james-project/pull/206.patch","issue_url":"https://api.github.com/repos/linagora/james-project/issues/206","number":206,"state":"open","locked":false,"title":"JAMES-1714 Implement SetMailboxes: update","user":{"login":"Laura-Royet","id":16225407,"avatar_url":"https://avatars.githubusercontent.com/u/16225407?v=3","gravatar_id":"","url":"https://api.github.com/users/Laura-Royet","html_url":"https://github.com/Laura-Royet","followers_url":"https://api.github.com/users/Laura-Royet/followers","following_url":"https://api.github.com/users/Laura-Royet/following{/other_user}","gists_url":"https://api.github.com/users/Laura-Royet/gists{/gist_id}","starred_url":"https://api.github.com/users/Laura-Royet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Laura-Royet/subscriptions","organizations_url":"https://api.github.com/users/Laura-Royet/orgs","repos_url":"https://api.github.com/users/Laura-Royet/repos","events_url":"https://api.github.com/users/Laura-Royet/events{/privacy}","received_events_url":"https://api.github.com/users/Laura-Royet/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-04-06T13:33:06Z","updated_at":"2016-04-12T10:25:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d23d3528597715cb0bd8c16fe9354d58059452b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/linagora/james-project/pulls/206/commits","review_comments_url":"https://api.github.com/repos/linagora/james-project/pulls/206/comments","review_comment_url":"https://api.github.com/repos/linagora/james-project/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linagora/james-project/issues/206/comments","statuses_url":"https://api.github.com/repos/linagora/james-project/statuses/91283c76fdda5419d5f1ac3f9300abb017c2d335","head":{"label":"Laura-Royet:JAMES-1714-2","ref":"JAMES-1714-2","sha":"91283c76fdda5419d5f1ac3f9300abb017c2d335","user":{"login":"Laura-Royet","id":16225407,"avatar_url":"https://avatars.githubusercontent.com/u/16225407?v=3","gravatar_id":"","url":"https://api.github.com/users/Laura-Royet","html_url":"https://github.com/Laura-Royet","followers_url":"https://api.github.com/users/Laura-Royet/followers","following_url":"https://api.github.com/users/Laura-Royet/following{/other_user}","gists_url":"https://api.github.com/users/Laura-Royet/gists{/gist_id}","starred_url":"https://api.github.com/users/Laura-Royet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Laura-Royet/subscriptions","organizations_url":"https://api.github.com/users/Laura-Royet/orgs","repos_url":"https://api.github.com/users/Laura-Royet/repos","events_url":"https://api.github.com/users/Laura-Royet/events{/privacy}","received_events_url":"https://api.github.com/users/Laura-Royet/received_events","type":"User","site_admin":false},"repo":{"id":49267143,"name":"james-project","full_name":"Laura-Royet/james-project","owner":{"login":"Laura-Royet","id":16225407,"avatar_url":"https://avatars.githubusercontent.com/u/16225407?v=3","gravatar_id":"","url":"https://api.github.com/users/Laura-Royet","html_url":"https://github.com/Laura-Royet","followers_url":"https://api.github.com/users/Laura-Royet/followers","following_url":"https://api.github.com/users/Laura-Royet/following{/other_user}","gists_url":"https://api.github.com/users/Laura-Royet/gists{/gist_id}","starred_url":"https://api.github.com/users/Laura-Royet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Laura-Royet/subscriptions","organizations_url":"https://api.github.com/users/Laura-Royet/orgs","repos_url":"https://api.github.com/users/Laura-Royet/repos","events_url":"https://api.github.com/users/Laura-Royet/events{/privacy}","received_events_url":"https://api.github.com/users/Laura-Royet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Laura-Royet/james-project","description":"Mirror of Apache James Project","fork":true,"url":"https://api.github.com/repos/Laura-Royet/james-project","forks_url":"https://api.github.com/repos/Laura-Royet/james-project/forks","keys_url":"https://api.github.com/repos/Laura-Royet/james-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Laura-Royet/james-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Laura-Royet/james-project/teams","hooks_url":"https://api.github.com/repos/Laura-Royet/james-project/hooks","issue_events_url":"https://api.github.com/repos/Laura-Royet/james-project/issues/events{/number}","events_url":"https://api.github.com/repos/Laura-Royet/james-project/events","assignees_url":"https://api.github.com/repos/Laura-Royet/james-project/assignees{/user}","branches_url":"https://api.github.com/repos/Laura-Royet/james-project/branches{/branch}","tags_url":"https://api.github.com/repos/Laura-Royet/james-project/tags","blobs_url":"https://api.github.com/repos/Laura-Royet/james-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Laura-Royet/james-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Laura-Royet/james-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/Laura-Royet/james-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Laura-Royet/james-project/statuses/{sha}","languages_url":"https://api.github.com/repos/Laura-Royet/james-project/languages","stargazers_url":"https://api.github.com/repos/Laura-Royet/james-project/stargazers","contributors_url":"https://api.github.com/repos/Laura-Royet/james-project/contributors","subscribers_url":"https://api.github.com/repos/Laura-Royet/james-project/subscribers","subscription_url":"https://api.github.com/repos/Laura-Royet/james-project/subscription","commits_url":"https://api.github.com/repos/Laura-Royet/james-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/Laura-Royet/james-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/Laura-Royet/james-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/Laura-Royet/james-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/Laura-Royet/james-project/contents/{+path}","compare_url":"https://api.github.com/repos/Laura-Royet/james-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Laura-Royet/james-project/merges","archive_url":"https://api.github.com/repos/Laura-Royet/james-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Laura-Royet/james-project/downloads","issues_url":"https://api.github.com/repos/Laura-Royet/james-project/issues{/number}","pulls_url":"https://api.github.com/repos/Laura-Royet/james-project/pulls{/number}","milestones_url":"https://api.github.com/repos/Laura-Royet/james-project/milestones{/number}","notifications_url":"https://api.github.com/repos/Laura-Royet/james-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Laura-Royet/james-project/labels{/name}","releases_url":"https://api.github.com/repos/Laura-Royet/james-project/releases{/id}","deployments_url":"https://api.github.com/repos/Laura-Royet/james-project/deployments","created_at":"2016-01-08T10:56:02Z","updated_at":"2016-01-08T10:56:11Z","pushed_at":"2016-04-12T09:41:30Z","git_url":"git://github.com/Laura-Royet/james-project.git","ssh_url":"git@github.com:Laura-Royet/james-project.git","clone_url":"https://github.com/Laura-Royet/james-project.git","svn_url":"https://github.com/Laura-Royet/james-project","homepage":null,"size":10961,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linagora:master","ref":"master","sha":"49b318080201a9e4a1a99851133fed88e5ad8df3","user":{"login":"linagora","id":1230365,"avatar_url":"https://avatars.githubusercontent.com/u/1230365?v=3","gravatar_id":"","url":"https://api.github.com/users/linagora","html_url":"https://github.com/linagora","followers_url":"https://api.github.com/users/linagora/followers","following_url":"https://api.github.com/users/linagora/following{/other_user}","gists_url":"https://api.github.com/users/linagora/gists{/gist_id}","starred_url":"https://api.github.com/users/linagora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linagora/subscriptions","organizations_url":"https://api.github.com/users/linagora/orgs","repos_url":"https://api.github.com/users/linagora/repos","events_url":"https://api.github.com/users/linagora/events{/privacy}","received_events_url":"https://api.github.com/users/linagora/received_events","type":"Organization","site_admin":false},"repo":{"id":39182136,"name":"james-project","full_name":"linagora/james-project","owner":{"login":"linagora","id":1230365,"avatar_url":"https://avatars.githubusercontent.com/u/1230365?v=3","gravatar_id":"","url":"https://api.github.com/users/linagora","html_url":"https://github.com/linagora","followers_url":"https://api.github.com/users/linagora/followers","following_url":"https://api.github.com/users/linagora/following{/other_user}","gists_url":"https://api.github.com/users/linagora/gists{/gist_id}","starred_url":"https://api.github.com/users/linagora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linagora/subscriptions","organizations_url":"https://api.github.com/users/linagora/orgs","repos_url":"https://api.github.com/users/linagora/repos","events_url":"https://api.github.com/users/linagora/events{/privacy}","received_events_url":"https://api.github.com/users/linagora/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linagora/james-project","description":"Mirror of Apache James Project","fork":true,"url":"https://api.github.com/repos/linagora/james-project","forks_url":"https://api.github.com/repos/linagora/james-project/forks","keys_url":"https://api.github.com/repos/linagora/james-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linagora/james-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linagora/james-project/teams","hooks_url":"https://api.github.com/repos/linagora/james-project/hooks","issue_events_url":"https://api.github.com/repos/linagora/james-project/issues/events{/number}","events_url":"https://api.github.com/repos/linagora/james-project/events","assignees_url":"https://api.github.com/repos/linagora/james-project/assignees{/user}","branches_url":"https://api.github.com/repos/linagora/james-project/branches{/branch}","tags_url":"https://api.github.com/repos/linagora/james-project/tags","blobs_url":"https://api.github.com/repos/linagora/james-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linagora/james-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linagora/james-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/linagora/james-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linagora/james-project/statuses/{sha}","languages_url":"https://api.github.com/repos/linagora/james-project/languages","stargazers_url":"https://api.github.com/repos/linagora/james-project/stargazers","contributors_url":"https://api.github.com/repos/linagora/james-project/contributors","subscribers_url":"https://api.github.com/repos/linagora/james-project/subscribers","subscription_url":"https://api.github.com/repos/linagora/james-project/subscription","commits_url":"https://api.github.com/repos/linagora/james-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/linagora/james-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/linagora/james-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/linagora/james-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/linagora/james-project/contents/{+path}","compare_url":"https://api.github.com/repos/linagora/james-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linagora/james-project/merges","archive_url":"https://api.github.com/repos/linagora/james-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linagora/james-project/downloads","issues_url":"https://api.github.com/repos/linagora/james-project/issues{/number}","pulls_url":"https://api.github.com/repos/linagora/james-project/pulls{/number}","milestones_url":"https://api.github.com/repos/linagora/james-project/milestones{/number}","notifications_url":"https://api.github.com/repos/linagora/james-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linagora/james-project/labels{/name}","releases_url":"https://api.github.com/repos/linagora/james-project/releases{/id}","deployments_url":"https://api.github.com/repos/linagora/james-project/deployments","created_at":"2015-07-16T07:04:59Z","updated_at":"2016-03-17T09:08:41Z","pushed_at":"2016-04-12T10:10:10Z","git_url":"git://github.com/linagora/james-project.git","ssh_url":"git@github.com:linagora/james-project.git","clone_url":"https://github.com/linagora/james-project.git","svn_url":"https://github.com/linagora/james-project","homepage":null,"size":12861,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":13,"forks":6,"open_issues":13,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linagora/james-project/pulls/206"},"html":{"href":"https://github.com/linagora/james-project/pull/206"},"issue":{"href":"https://api.github.com/repos/linagora/james-project/issues/206"},"comments":{"href":"https://api.github.com/repos/linagora/james-project/issues/206/comments"},"review_comments":{"href":"https://api.github.com/repos/linagora/james-project/pulls/206/comments"},"review_comment":{"href":"https://api.github.com/repos/linagora/james-project/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linagora/james-project/pulls/206/commits"},"statuses":{"href":"https://api.github.com/repos/linagora/james-project/statuses/91283c76fdda5419d5f1ac3f9300abb017c2d335"}}}}