{"action":"closed","number":33,"pull_request":{"url":"https://api.github.com/repos/basho-labs/thumbs/pulls/33","id":91895149,"html_url":"https://github.com/basho-labs/thumbs/pull/33","diff_url":"https://github.com/basho-labs/thumbs/pull/33.diff","patch_url":"https://github.com/basho-labs/thumbs/pull/33.patch","issue_url":"https://api.github.com/repos/basho-labs/thumbs/issues/33","number":33,"state":"closed","locked":false,"title":"fix for ref with slashes in it","user":{"login":"davidx","id":17162,"avatar_url":"https://avatars.githubusercontent.com/u/17162?v=3","gravatar_id":"","url":"https://api.github.com/users/davidx","html_url":"https://github.com/davidx","followers_url":"https://api.github.com/users/davidx/followers","following_url":"https://api.github.com/users/davidx/following{/other_user}","gists_url":"https://api.github.com/users/davidx/gists{/gist_id}","starred_url":"https://api.github.com/users/davidx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidx/subscriptions","organizations_url":"https://api.github.com/users/davidx/orgs","repos_url":"https://api.github.com/users/davidx/repos","events_url":"https://api.github.com/users/davidx/events{/privacy}","received_events_url":"https://api.github.com/users/davidx/received_events","type":"User","site_admin":false},"body":"This is a fix for a situation where a ref, base or head, happens to include slashes.\r\nThis prohibited persistence of build status as the build guid used in the filename includes the ref.\r\nas a simple initial solution, the build guid has been modified to replace '/' with '_' \r\nExample of bug:  https://github.com/basho/yokozuna/pull/699 \r\nExample of pr with slashes working under this code: https://github.com/davidx/prtester/pull/310","created_at":"2016-11-02T01:33:25Z","updated_at":"2016-11-02T16:46:34Z","closed_at":"2016-11-02T16:46:34Z","merged_at":"2016-11-02T16:46:34Z","merge_commit_sha":"f60360984d125281cf11555dd6f116fd0065c9c0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/basho-labs/thumbs/pulls/33/commits","review_comments_url":"https://api.github.com/repos/basho-labs/thumbs/pulls/33/comments","review_comment_url":"https://api.github.com/repos/basho-labs/thumbs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/basho-labs/thumbs/issues/33/comments","statuses_url":"https://api.github.com/repos/basho-labs/thumbs/statuses/5608e178266c52c6c52b05a38d82ccc2bd784350","head":{"label":"basho-labs:slashes_ref","ref":"slashes_ref","sha":"5608e178266c52c6c52b05a38d82ccc2bd784350","user":{"login":"basho-labs","id":1914338,"avatar_url":"https://avatars.githubusercontent.com/u/1914338?v=3","gravatar_id":"","url":"https://api.github.com/users/basho-labs","html_url":"https://github.com/basho-labs","followers_url":"https://api.github.com/users/basho-labs/followers","following_url":"https://api.github.com/users/basho-labs/following{/other_user}","gists_url":"https://api.github.com/users/basho-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/basho-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basho-labs/subscriptions","organizations_url":"https://api.github.com/users/basho-labs/orgs","repos_url":"https://api.github.com/users/basho-labs/repos","events_url":"https://api.github.com/users/basho-labs/events{/privacy}","received_events_url":"https://api.github.com/users/basho-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":67819365,"name":"thumbs","full_name":"basho-labs/thumbs","owner":{"login":"basho-labs","id":1914338,"avatar_url":"https://avatars.githubusercontent.com/u/1914338?v=3","gravatar_id":"","url":"https://api.github.com/users/basho-labs","html_url":"https://github.com/basho-labs","followers_url":"https://api.github.com/users/basho-labs/followers","following_url":"https://api.github.com/users/basho-labs/following{/other_user}","gists_url":"https://api.github.com/users/basho-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/basho-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basho-labs/subscriptions","organizations_url":"https://api.github.com/users/basho-labs/orgs","repos_url":"https://api.github.com/users/basho-labs/repos","events_url":"https://api.github.com/users/basho-labs/events{/privacy}","received_events_url":"https://api.github.com/users/basho-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/basho-labs/thumbs","description":null,"fork":false,"url":"https://api.github.com/repos/basho-labs/thumbs","forks_url":"https://api.github.com/repos/basho-labs/thumbs/forks","keys_url":"https://api.github.com/repos/basho-labs/thumbs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/basho-labs/thumbs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/basho-labs/thumbs/teams","hooks_url":"https://api.github.com/repos/basho-labs/thumbs/hooks","issue_events_url":"https://api.github.com/repos/basho-labs/thumbs/issues/events{/number}","events_url":"https://api.github.com/repos/basho-labs/thumbs/events","assignees_url":"https://api.github.com/repos/basho-labs/thumbs/assignees{/user}","branches_url":"https://api.github.com/repos/basho-labs/thumbs/branches{/branch}","tags_url":"https://api.github.com/repos/basho-labs/thumbs/tags","blobs_url":"https://api.github.com/repos/basho-labs/thumbs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/basho-labs/thumbs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/basho-labs/thumbs/git/refs{/sha}","trees_url":"https://api.github.com/repos/basho-labs/thumbs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/basho-labs/thumbs/statuses/{sha}","languages_url":"https://api.github.com/repos/basho-labs/thumbs/languages","stargazers_url":"https://api.github.com/repos/basho-labs/thumbs/stargazers","contributors_url":"https://api.github.com/repos/basho-labs/thumbs/contributors","subscribers_url":"https://api.github.com/repos/basho-labs/thumbs/subscribers","subscription_url":"https://api.github.com/repos/basho-labs/thumbs/subscription","commits_url":"https://api.github.com/repos/basho-labs/thumbs/commits{/sha}","git_commits_url":"https://api.github.com/repos/basho-labs/thumbs/git/commits{/sha}","comments_url":"https://api.github.com/repos/basho-labs/thumbs/comments{/number}","issue_comment_url":"https://api.github.com/repos/basho-labs/thumbs/issues/comments{/number}","contents_url":"https://api.github.com/repos/basho-labs/thumbs/contents/{+path}","compare_url":"https://api.github.com/repos/basho-labs/thumbs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/basho-labs/thumbs/merges","archive_url":"https://api.github.com/repos/basho-labs/thumbs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/basho-labs/thumbs/downloads","issues_url":"https://api.github.com/repos/basho-labs/thumbs/issues{/number}","pulls_url":"https://api.github.com/repos/basho-labs/thumbs/pulls{/number}","milestones_url":"https://api.github.com/repos/basho-labs/thumbs/milestones{/number}","notifications_url":"https://api.github.com/repos/basho-labs/thumbs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/basho-labs/thumbs/labels{/name}","releases_url":"https://api.github.com/repos/basho-labs/thumbs/releases{/id}","deployments_url":"https://api.github.com/repos/basho-labs/thumbs/deployments","created_at":"2016-09-09T17:36:43Z","updated_at":"2016-10-26T19:59:43Z","pushed_at":"2016-11-02T16:46:34Z","git_url":"git://github.com/basho-labs/thumbs.git","ssh_url":"git@github.com:basho-labs/thumbs.git","clone_url":"https://github.com/basho-labs/thumbs.git","svn_url":"https://github.com/basho-labs/thumbs","homepage":null,"size":240,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"basho-labs:add_code_approval_support","ref":"add_code_approval_support","sha":"b22042db4b8b43d7359e79f5c3017356cc211d6a","user":{"login":"basho-labs","id":1914338,"avatar_url":"https://avatars.githubusercontent.com/u/1914338?v=3","gravatar_id":"","url":"https://api.github.com/users/basho-labs","html_url":"https://github.com/basho-labs","followers_url":"https://api.github.com/users/basho-labs/followers","following_url":"https://api.github.com/users/basho-labs/following{/other_user}","gists_url":"https://api.github.com/users/basho-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/basho-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basho-labs/subscriptions","organizations_url":"https://api.github.com/users/basho-labs/orgs","repos_url":"https://api.github.com/users/basho-labs/repos","events_url":"https://api.github.com/users/basho-labs/events{/privacy}","received_events_url":"https://api.github.com/users/basho-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":67819365,"name":"thumbs","full_name":"basho-labs/thumbs","owner":{"login":"basho-labs","id":1914338,"avatar_url":"https://avatars.githubusercontent.com/u/1914338?v=3","gravatar_id":"","url":"https://api.github.com/users/basho-labs","html_url":"https://github.com/basho-labs","followers_url":"https://api.github.com/users/basho-labs/followers","following_url":"https://api.github.com/users/basho-labs/following{/other_user}","gists_url":"https://api.github.com/users/basho-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/basho-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basho-labs/subscriptions","organizations_url":"https://api.github.com/users/basho-labs/orgs","repos_url":"https://api.github.com/users/basho-labs/repos","events_url":"https://api.github.com/users/basho-labs/events{/privacy}","received_events_url":"https://api.github.com/users/basho-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/basho-labs/thumbs","description":null,"fork":false,"url":"https://api.github.com/repos/basho-labs/thumbs","forks_url":"https://api.github.com/repos/basho-labs/thumbs/forks","keys_url":"https://api.github.com/repos/basho-labs/thumbs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/basho-labs/thumbs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/basho-labs/thumbs/teams","hooks_url":"https://api.github.com/repos/basho-labs/thumbs/hooks","issue_events_url":"https://api.github.com/repos/basho-labs/thumbs/issues/events{/number}","events_url":"https://api.github.com/repos/basho-labs/thumbs/events","assignees_url":"https://api.github.com/repos/basho-labs/thumbs/assignees{/user}","branches_url":"https://api.github.com/repos/basho-labs/thumbs/branches{/branch}","tags_url":"https://api.github.com/repos/basho-labs/thumbs/tags","blobs_url":"https://api.github.com/repos/basho-labs/thumbs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/basho-labs/thumbs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/basho-labs/thumbs/git/refs{/sha}","trees_url":"https://api.github.com/repos/basho-labs/thumbs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/basho-labs/thumbs/statuses/{sha}","languages_url":"https://api.github.com/repos/basho-labs/thumbs/languages","stargazers_url":"https://api.github.com/repos/basho-labs/thumbs/stargazers","contributors_url":"https://api.github.com/repos/basho-labs/thumbs/contributors","subscribers_url":"https://api.github.com/repos/basho-labs/thumbs/subscribers","subscription_url":"https://api.github.com/repos/basho-labs/thumbs/subscription","commits_url":"https://api.github.com/repos/basho-labs/thumbs/commits{/sha}","git_commits_url":"https://api.github.com/repos/basho-labs/thumbs/git/commits{/sha}","comments_url":"https://api.github.com/repos/basho-labs/thumbs/comments{/number}","issue_comment_url":"https://api.github.com/repos/basho-labs/thumbs/issues/comments{/number}","contents_url":"https://api.github.com/repos/basho-labs/thumbs/contents/{+path}","compare_url":"https://api.github.com/repos/basho-labs/thumbs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/basho-labs/thumbs/merges","archive_url":"https://api.github.com/repos/basho-labs/thumbs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/basho-labs/thumbs/downloads","issues_url":"https://api.github.com/repos/basho-labs/thumbs/issues{/number}","pulls_url":"https://api.github.com/repos/basho-labs/thumbs/pulls{/number}","milestones_url":"https://api.github.com/repos/basho-labs/thumbs/milestones{/number}","notifications_url":"https://api.github.com/repos/basho-labs/thumbs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/basho-labs/thumbs/labels{/name}","releases_url":"https://api.github.com/repos/basho-labs/thumbs/releases{/id}","deployments_url":"https://api.github.com/repos/basho-labs/thumbs/deployments","created_at":"2016-09-09T17:36:43Z","updated_at":"2016-10-26T19:59:43Z","pushed_at":"2016-11-02T16:46:34Z","git_url":"git://github.com/basho-labs/thumbs.git","ssh_url":"git@github.com:basho-labs/thumbs.git","clone_url":"https://github.com/basho-labs/thumbs.git","svn_url":"https://github.com/basho-labs/thumbs","homepage":null,"size":240,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/basho-labs/thumbs/pulls/33"},"html":{"href":"https://github.com/basho-labs/thumbs/pull/33"},"issue":{"href":"https://api.github.com/repos/basho-labs/thumbs/issues/33"},"comments":{"href":"https://api.github.com/repos/basho-labs/thumbs/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/basho-labs/thumbs/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/basho-labs/thumbs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/basho-labs/thumbs/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/basho-labs/thumbs/statuses/5608e178266c52c6c52b05a38d82ccc2bd784350"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"davidx","id":17162,"avatar_url":"https://avatars.githubusercontent.com/u/17162?v=3","gravatar_id":"","url":"https://api.github.com/users/davidx","html_url":"https://github.com/davidx","followers_url":"https://api.github.com/users/davidx/followers","following_url":"https://api.github.com/users/davidx/following{/other_user}","gists_url":"https://api.github.com/users/davidx/gists{/gist_id}","starred_url":"https://api.github.com/users/davidx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidx/subscriptions","organizations_url":"https://api.github.com/users/davidx/orgs","repos_url":"https://api.github.com/users/davidx/repos","events_url":"https://api.github.com/users/davidx/events{/privacy}","received_events_url":"https://api.github.com/users/davidx/received_events","type":"User","site_admin":false},"comments":9,"review_comments":0,"commits":3,"additions":40,"deletions":23,"changed_files":4}}
{"actor":{"display_login":"davidx"}}