{"action":"created","comment":{"url":"https://api.github.com/repos/appc/docker2aci/pulls/comments/73374736","id":73374736,"diff_hunk":"@@ -254,8 +254,10 @@ func (rb *RepositoryBackend) buildACIV22(layerIDs []string, dockerURL *types.Par\n \tvar aciLayerPaths []string\n \tvar aciManifests []*schema.ImageManifest\n \tvar curPwl []string\n-\tfor i := len(layerIDs) - 1; i > 0; i-- {\n-\t\tlog.Debug(\"Generating layer ACI...\")\n+\n+\tlog.Debug(\"Generating layer ACI...\")","path":"lib/internal/backend/repository/repository2.go","position":7,"original_position":7,"commit_id":"b8493e02df28f535c9bef5f24380c26d76ad8e19","original_commit_id":"b8493e02df28f535c9bef5f24380c26d76ad8e19","user":{"login":"sgotti","id":1690273,"avatar_url":"https://avatars.githubusercontent.com/u/1690273?v=3","gravatar_id":"","url":"https://api.github.com/users/sgotti","html_url":"https://github.com/sgotti","followers_url":"https://api.github.com/users/sgotti/followers","following_url":"https://api.github.com/users/sgotti/following{/other_user}","gists_url":"https://api.github.com/users/sgotti/gists{/gist_id}","starred_url":"https://api.github.com/users/sgotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgotti/subscriptions","organizations_url":"https://api.github.com/users/sgotti/orgs","repos_url":"https://api.github.com/users/sgotti/repos","events_url":"https://api.github.com/users/sgotti/events{/privacy}","received_events_url":"https://api.github.com/users/sgotti/received_events","type":"User","site_admin":false},"body":"Because if there's only one layer it won't be written.","created_at":"2016-08-03T16:58:05Z","updated_at":"2016-08-03T16:58:05Z","html_url":"https://github.com/appc/docker2aci/pull/190#discussion_r73374736","pull_request_url":"https://api.github.com/repos/appc/docker2aci/pulls/190","_links":{"self":{"href":"https://api.github.com/repos/appc/docker2aci/pulls/comments/73374736"},"html":{"href":"https://github.com/appc/docker2aci/pull/190#discussion_r73374736"},"pull_request":{"href":"https://api.github.com/repos/appc/docker2aci/pulls/190"}}},"pull_request":{"url":"https://api.github.com/repos/appc/docker2aci/pulls/190","id":79859298,"html_url":"https://github.com/appc/docker2aci/pull/190","diff_url":"https://github.com/appc/docker2aci/pull/190.diff","patch_url":"https://github.com/appc/docker2aci/pull/190.patch","issue_url":"https://api.github.com/repos/appc/docker2aci/issues/190","number":190,"state":"open","locked":false,"title":"repository2: fix manifest v2.2 layer ordering.","user":{"login":"sgotti","id":1690273,"avatar_url":"https://avatars.githubusercontent.com/u/1690273?v=3","gravatar_id":"","url":"https://api.github.com/users/sgotti","html_url":"https://github.com/sgotti","followers_url":"https://api.github.com/users/sgotti/followers","following_url":"https://api.github.com/users/sgotti/following{/other_user}","gists_url":"https://api.github.com/users/sgotti/gists{/gist_id}","starred_url":"https://api.github.com/users/sgotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgotti/subscriptions","organizations_url":"https://api.github.com/users/sgotti/orgs","repos_url":"https://api.github.com/users/sgotti/repos","events_url":"https://api.github.com/users/sgotti/events{/privacy}","received_events_url":"https://api.github.com/users/sgotti/received_events","type":"User","site_admin":false},"body":"With docker manifest v2.2 and oci the layers are ordered from the base layer to\r\nthe topmost layer.\r\n\r\nThis is just a quick fix for review. Next steps will be to add tests and remove duplicated layers.\r\n\r\nFixes #189  ","created_at":"2016-08-03T07:24:21Z","updated_at":"2016-08-03T16:58:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"611927b8ab6726f31410f234054e59e12de6b2c3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/appc/docker2aci/pulls/190/commits","review_comments_url":"https://api.github.com/repos/appc/docker2aci/pulls/190/comments","review_comment_url":"https://api.github.com/repos/appc/docker2aci/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appc/docker2aci/issues/190/comments","statuses_url":"https://api.github.com/repos/appc/docker2aci/statuses/b8493e02df28f535c9bef5f24380c26d76ad8e19","head":{"label":"sgotti:fix_manifestv22_layer_order","ref":"fix_manifestv22_layer_order","sha":"b8493e02df28f535c9bef5f24380c26d76ad8e19","user":{"login":"sgotti","id":1690273,"avatar_url":"https://avatars.githubusercontent.com/u/1690273?v=3","gravatar_id":"","url":"https://api.github.com/users/sgotti","html_url":"https://github.com/sgotti","followers_url":"https://api.github.com/users/sgotti/followers","following_url":"https://api.github.com/users/sgotti/following{/other_user}","gists_url":"https://api.github.com/users/sgotti/gists{/gist_id}","starred_url":"https://api.github.com/users/sgotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgotti/subscriptions","organizations_url":"https://api.github.com/users/sgotti/orgs","repos_url":"https://api.github.com/users/sgotti/repos","events_url":"https://api.github.com/users/sgotti/events{/privacy}","received_events_url":"https://api.github.com/users/sgotti/received_events","type":"User","site_admin":false},"repo":{"id":32387582,"name":"docker2aci","full_name":"sgotti/docker2aci","owner":{"login":"sgotti","id":1690273,"avatar_url":"https://avatars.githubusercontent.com/u/1690273?v=3","gravatar_id":"","url":"https://api.github.com/users/sgotti","html_url":"https://github.com/sgotti","followers_url":"https://api.github.com/users/sgotti/followers","following_url":"https://api.github.com/users/sgotti/following{/other_user}","gists_url":"https://api.github.com/users/sgotti/gists{/gist_id}","starred_url":"https://api.github.com/users/sgotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgotti/subscriptions","organizations_url":"https://api.github.com/users/sgotti/orgs","repos_url":"https://api.github.com/users/sgotti/repos","events_url":"https://api.github.com/users/sgotti/events{/privacy}","received_events_url":"https://api.github.com/users/sgotti/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sgotti/docker2aci","description":"Small tool to convert docker images to ACI","fork":true,"url":"https://api.github.com/repos/sgotti/docker2aci","forks_url":"https://api.github.com/repos/sgotti/docker2aci/forks","keys_url":"https://api.github.com/repos/sgotti/docker2aci/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sgotti/docker2aci/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sgotti/docker2aci/teams","hooks_url":"https://api.github.com/repos/sgotti/docker2aci/hooks","issue_events_url":"https://api.github.com/repos/sgotti/docker2aci/issues/events{/number}","events_url":"https://api.github.com/repos/sgotti/docker2aci/events","assignees_url":"https://api.github.com/repos/sgotti/docker2aci/assignees{/user}","branches_url":"https://api.github.com/repos/sgotti/docker2aci/branches{/branch}","tags_url":"https://api.github.com/repos/sgotti/docker2aci/tags","blobs_url":"https://api.github.com/repos/sgotti/docker2aci/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sgotti/docker2aci/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sgotti/docker2aci/git/refs{/sha}","trees_url":"https://api.github.com/repos/sgotti/docker2aci/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sgotti/docker2aci/statuses/{sha}","languages_url":"https://api.github.com/repos/sgotti/docker2aci/languages","stargazers_url":"https://api.github.com/repos/sgotti/docker2aci/stargazers","contributors_url":"https://api.github.com/repos/sgotti/docker2aci/contributors","subscribers_url":"https://api.github.com/repos/sgotti/docker2aci/subscribers","subscription_url":"https://api.github.com/repos/sgotti/docker2aci/subscription","commits_url":"https://api.github.com/repos/sgotti/docker2aci/commits{/sha}","git_commits_url":"https://api.github.com/repos/sgotti/docker2aci/git/commits{/sha}","comments_url":"https://api.github.com/repos/sgotti/docker2aci/comments{/number}","issue_comment_url":"https://api.github.com/repos/sgotti/docker2aci/issues/comments{/number}","contents_url":"https://api.github.com/repos/sgotti/docker2aci/contents/{+path}","compare_url":"https://api.github.com/repos/sgotti/docker2aci/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sgotti/docker2aci/merges","archive_url":"https://api.github.com/repos/sgotti/docker2aci/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sgotti/docker2aci/downloads","issues_url":"https://api.github.com/repos/sgotti/docker2aci/issues{/number}","pulls_url":"https://api.github.com/repos/sgotti/docker2aci/pulls{/number}","milestones_url":"https://api.github.com/repos/sgotti/docker2aci/milestones{/number}","notifications_url":"https://api.github.com/repos/sgotti/docker2aci/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sgotti/docker2aci/labels{/name}","releases_url":"https://api.github.com/repos/sgotti/docker2aci/releases{/id}","deployments_url":"https://api.github.com/repos/sgotti/docker2aci/deployments","created_at":"2015-03-17T10:44:13Z","updated_at":"2015-03-17T10:44:14Z","pushed_at":"2016-08-03T07:20:25Z","git_url":"git://github.com/sgotti/docker2aci.git","ssh_url":"git@github.com:sgotti/docker2aci.git","clone_url":"https://github.com/sgotti/docker2aci.git","svn_url":"https://github.com/sgotti/docker2aci","homepage":null,"size":755,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"appc:master","ref":"master","sha":"54c5d941eced0af9fd3dc57f7401cc95338118d9","user":{"login":"appc","id":10080092,"avatar_url":"https://avatars.githubusercontent.com/u/10080092?v=3","gravatar_id":"","url":"https://api.github.com/users/appc","html_url":"https://github.com/appc","followers_url":"https://api.github.com/users/appc/followers","following_url":"https://api.github.com/users/appc/following{/other_user}","gists_url":"https://api.github.com/users/appc/gists{/gist_id}","starred_url":"https://api.github.com/users/appc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appc/subscriptions","organizations_url":"https://api.github.com/users/appc/orgs","repos_url":"https://api.github.com/users/appc/repos","events_url":"https://api.github.com/users/appc/events{/privacy}","received_events_url":"https://api.github.com/users/appc/received_events","type":"Organization","site_admin":false},"repo":{"id":29600667,"name":"docker2aci","full_name":"appc/docker2aci","owner":{"login":"appc","id":10080092,"avatar_url":"https://avatars.githubusercontent.com/u/10080092?v=3","gravatar_id":"","url":"https://api.github.com/users/appc","html_url":"https://github.com/appc","followers_url":"https://api.github.com/users/appc/followers","following_url":"https://api.github.com/users/appc/following{/other_user}","gists_url":"https://api.github.com/users/appc/gists{/gist_id}","starred_url":"https://api.github.com/users/appc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appc/subscriptions","organizations_url":"https://api.github.com/users/appc/orgs","repos_url":"https://api.github.com/users/appc/repos","events_url":"https://api.github.com/users/appc/events{/privacy}","received_events_url":"https://api.github.com/users/appc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appc/docker2aci","description":"library and CLI tool to convert Docker images to ACIs","fork":false,"url":"https://api.github.com/repos/appc/docker2aci","forks_url":"https://api.github.com/repos/appc/docker2aci/forks","keys_url":"https://api.github.com/repos/appc/docker2aci/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appc/docker2aci/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appc/docker2aci/teams","hooks_url":"https://api.github.com/repos/appc/docker2aci/hooks","issue_events_url":"https://api.github.com/repos/appc/docker2aci/issues/events{/number}","events_url":"https://api.github.com/repos/appc/docker2aci/events","assignees_url":"https://api.github.com/repos/appc/docker2aci/assignees{/user}","branches_url":"https://api.github.com/repos/appc/docker2aci/branches{/branch}","tags_url":"https://api.github.com/repos/appc/docker2aci/tags","blobs_url":"https://api.github.com/repos/appc/docker2aci/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appc/docker2aci/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appc/docker2aci/git/refs{/sha}","trees_url":"https://api.github.com/repos/appc/docker2aci/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appc/docker2aci/statuses/{sha}","languages_url":"https://api.github.com/repos/appc/docker2aci/languages","stargazers_url":"https://api.github.com/repos/appc/docker2aci/stargazers","contributors_url":"https://api.github.com/repos/appc/docker2aci/contributors","subscribers_url":"https://api.github.com/repos/appc/docker2aci/subscribers","subscription_url":"https://api.github.com/repos/appc/docker2aci/subscription","commits_url":"https://api.github.com/repos/appc/docker2aci/commits{/sha}","git_commits_url":"https://api.github.com/repos/appc/docker2aci/git/commits{/sha}","comments_url":"https://api.github.com/repos/appc/docker2aci/comments{/number}","issue_comment_url":"https://api.github.com/repos/appc/docker2aci/issues/comments{/number}","contents_url":"https://api.github.com/repos/appc/docker2aci/contents/{+path}","compare_url":"https://api.github.com/repos/appc/docker2aci/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appc/docker2aci/merges","archive_url":"https://api.github.com/repos/appc/docker2aci/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appc/docker2aci/downloads","issues_url":"https://api.github.com/repos/appc/docker2aci/issues{/number}","pulls_url":"https://api.github.com/repos/appc/docker2aci/pulls{/number}","milestones_url":"https://api.github.com/repos/appc/docker2aci/milestones{/number}","notifications_url":"https://api.github.com/repos/appc/docker2aci/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appc/docker2aci/labels{/name}","releases_url":"https://api.github.com/repos/appc/docker2aci/releases{/id}","deployments_url":"https://api.github.com/repos/appc/docker2aci/deployments","created_at":"2015-01-21T17:03:40Z","updated_at":"2016-07-22T09:30:07Z","pushed_at":"2016-08-03T14:31:45Z","git_url":"git://github.com/appc/docker2aci.git","ssh_url":"git@github.com:appc/docker2aci.git","clone_url":"https://github.com/appc/docker2aci.git","svn_url":"https://github.com/appc/docker2aci","homepage":"","size":3115,"stargazers_count":123,"watchers_count":123,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":20,"forks":37,"open_issues":20,"watchers":123,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appc/docker2aci/pulls/190"},"html":{"href":"https://github.com/appc/docker2aci/pull/190"},"issue":{"href":"https://api.github.com/repos/appc/docker2aci/issues/190"},"comments":{"href":"https://api.github.com/repos/appc/docker2aci/issues/190/comments"},"review_comments":{"href":"https://api.github.com/repos/appc/docker2aci/pulls/190/comments"},"review_comment":{"href":"https://api.github.com/repos/appc/docker2aci/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appc/docker2aci/pulls/190/commits"},"statuses":{"href":"https://api.github.com/repos/appc/docker2aci/statuses/b8493e02df28f535c9bef5f24380c26d76ad8e19"}}}}
{"actor":{"display_login":"sgotti"}}