{"action":"created","comment":{"url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/pulls/comments/66457227","id":66457227,"diff_hunk":"@@ -17,24 +17,26 @@ module.exports = function(filteredImports) {\n \n       ExpressionStatement: {\n         enter: function() {\n-          shouldRemove.push(false);\n+          if (shouldRemove) {","path":"index.js","position":24,"original_position":24,"commit_id":"72cf54205d5cccc06ca3625f849f1ddc0ff13206","original_commit_id":"72cf54205d5cccc06ca3625f849f1ddc0ff13206","user":{"login":"Turbo87","id":141300,"avatar_url":"https://avatars.githubusercontent.com/u/141300?v=3","gravatar_id":"","url":"https://api.github.com/users/Turbo87","html_url":"https://github.com/Turbo87","followers_url":"https://api.github.com/users/Turbo87/followers","following_url":"https://api.github.com/users/Turbo87/following{/other_user}","gists_url":"https://api.github.com/users/Turbo87/gists{/gist_id}","starred_url":"https://api.github.com/users/Turbo87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Turbo87/subscriptions","organizations_url":"https://api.github.com/users/Turbo87/orgs","repos_url":"https://api.github.com/users/Turbo87/repos","events_url":"https://api.github.com/users/Turbo87/events{/privacy}","received_events_url":"https://api.github.com/users/Turbo87/received_events","type":"User","site_admin":false},"body":"I was surprised by that too, but somehow that's what Babel traversed. If you remove the guard in the `Identifier` method you can see all the tests failing because it will visit a final Identifier after exiting the Program.\r\n\r\nWe could also use a subvisitor inside the Program, but I'd like to avoid that to stay somewhat fast.","created_at":"2016-06-09T14:58:00Z","updated_at":"2016-06-09T14:58:00Z","html_url":"https://github.com/ember-cli/babel-plugin-filter-imports/pull/6#discussion_r66457227","pull_request_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/pulls/comments/66457227"},"html":{"href":"https://github.com/ember-cli/babel-plugin-filter-imports/pull/6#discussion_r66457227"},"pull_request":{"href":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/pulls/6","id":73217959,"html_url":"https://github.com/ember-cli/babel-plugin-filter-imports/pull/6","diff_url":"https://github.com/ember-cli/babel-plugin-filter-imports/pull/6.diff","patch_url":"https://github.com/ember-cli/babel-plugin-filter-imports/pull/6.patch","issue_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/issues/6","number":6,"state":"open","locked":false,"title":"Port plugin to Babel 6 plugin API","user":{"login":"Turbo87","id":141300,"avatar_url":"https://avatars.githubusercontent.com/u/141300?v=3","gravatar_id":"","url":"https://api.github.com/users/Turbo87","html_url":"https://github.com/Turbo87","followers_url":"https://api.github.com/users/Turbo87/followers","following_url":"https://api.github.com/users/Turbo87/following{/other_user}","gists_url":"https://api.github.com/users/Turbo87/gists{/gist_id}","starred_url":"https://api.github.com/users/Turbo87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Turbo87/subscriptions","organizations_url":"https://api.github.com/users/Turbo87/orgs","repos_url":"https://api.github.com/users/Turbo87/repos","events_url":"https://api.github.com/users/Turbo87/events{/privacy}","received_events_url":"https://api.github.com/users/Turbo87/received_events","type":"User","site_admin":false},"body":"/cc @stefanpenner @mmun ","created_at":"2016-06-09T13:55:21Z","updated_at":"2016-06-09T14:58:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4801a5a89292c112217ca53d32b65125d137eace","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/pulls/6/commits","review_comments_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/pulls/6/comments","review_comment_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/issues/6/comments","statuses_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/statuses/72cf54205d5cccc06ca3625f849f1ddc0ff13206","head":{"label":"Turbo87:babel6","ref":"babel6","sha":"72cf54205d5cccc06ca3625f849f1ddc0ff13206","user":{"login":"Turbo87","id":141300,"avatar_url":"https://avatars.githubusercontent.com/u/141300?v=3","gravatar_id":"","url":"https://api.github.com/users/Turbo87","html_url":"https://github.com/Turbo87","followers_url":"https://api.github.com/users/Turbo87/followers","following_url":"https://api.github.com/users/Turbo87/following{/other_user}","gists_url":"https://api.github.com/users/Turbo87/gists{/gist_id}","starred_url":"https://api.github.com/users/Turbo87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Turbo87/subscriptions","organizations_url":"https://api.github.com/users/Turbo87/orgs","repos_url":"https://api.github.com/users/Turbo87/repos","events_url":"https://api.github.com/users/Turbo87/events{/privacy}","received_events_url":"https://api.github.com/users/Turbo87/received_events","type":"User","site_admin":false},"repo":{"id":60778431,"name":"babel-plugin-filter-imports","full_name":"Turbo87/babel-plugin-filter-imports","owner":{"login":"Turbo87","id":141300,"avatar_url":"https://avatars.githubusercontent.com/u/141300?v=3","gravatar_id":"","url":"https://api.github.com/users/Turbo87","html_url":"https://github.com/Turbo87","followers_url":"https://api.github.com/users/Turbo87/followers","following_url":"https://api.github.com/users/Turbo87/following{/other_user}","gists_url":"https://api.github.com/users/Turbo87/gists{/gist_id}","starred_url":"https://api.github.com/users/Turbo87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Turbo87/subscriptions","organizations_url":"https://api.github.com/users/Turbo87/orgs","repos_url":"https://api.github.com/users/Turbo87/repos","events_url":"https://api.github.com/users/Turbo87/events{/privacy}","received_events_url":"https://api.github.com/users/Turbo87/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Turbo87/babel-plugin-filter-imports","description":"A babel transform for filtering out imports","fork":true,"url":"https://api.github.com/repos/Turbo87/babel-plugin-filter-imports","forks_url":"https://api.github.com/repos/Turbo87/babel-plugin-filter-imports/forks","keys_url":"https://api.github.com/repos/Turbo87/babel-plugin-filter-imports/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Turbo87/babel-plugin-filter-imports/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Turbo87/babel-plugin-filter-imports/teams","hooks_url":"https://api.github.com/repos/Turbo87/babel-plugin-filter-imports/hooks","issue_events_url":"https://api.github.com/repos/Turbo87/babel-plugin-filter-imports/issues/events{/number}","events_url":"https://api.github.com/repos/Turbo87/babel-plugin-filter-imports/events","assignees_url":"https://api.github.com/repos/Turbo87/babel-plugin-filter-imports/assignees{/user}","branches_url":"https://api.github.com/repos/Turbo87/babel-plugin-filter-imports/branches{/branch}","tags_url":"https://api.github.com/repos/Turbo87/babel-plugin-filter-imports/tags","blobs_url":"https://api.github.com/repos/Turbo87/babel-plugin-filter-imports/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Turbo87/babel-plugin-filter-imports/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Turbo87/babel-plugin-filter-imports/git/refs{/sha}","trees_url":"https://api.github.com/repos/Turbo87/babel-plugin-filter-imports/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Turbo87/babel-plugin-filter-imports/statuses/{sha}","languages_url":"https://api.github.com/repos/Turbo87/babel-plugin-filter-imports/languages","stargazers_url":"https://api.github.com/repos/Turbo87/babel-plugin-filter-imports/stargazers","contributors_url":"https://api.github.com/repos/Turbo87/babel-plugin-filter-imports/contributors","subscribers_url":"https://api.github.com/repos/Turbo87/babel-plugin-filter-imports/subscribers","subscription_url":"https://api.github.com/repos/Turbo87/babel-plugin-filter-imports/subscription","commits_url":"https://api.github.com/repos/Turbo87/babel-plugin-filter-imports/commits{/sha}","git_commits_url":"https://api.github.com/repos/Turbo87/babel-plugin-filter-imports/git/commits{/sha}","comments_url":"https://api.github.com/repos/Turbo87/babel-plugin-filter-imports/comments{/number}","issue_comment_url":"https://api.github.com/repos/Turbo87/babel-plugin-filter-imports/issues/comments{/number}","contents_url":"https://api.github.com/repos/Turbo87/babel-plugin-filter-imports/contents/{+path}","compare_url":"https://api.github.com/repos/Turbo87/babel-plugin-filter-imports/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Turbo87/babel-plugin-filter-imports/merges","archive_url":"https://api.github.com/repos/Turbo87/babel-plugin-filter-imports/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Turbo87/babel-plugin-filter-imports/downloads","issues_url":"https://api.github.com/repos/Turbo87/babel-plugin-filter-imports/issues{/number}","pulls_url":"https://api.github.com/repos/Turbo87/babel-plugin-filter-imports/pulls{/number}","milestones_url":"https://api.github.com/repos/Turbo87/babel-plugin-filter-imports/milestones{/number}","notifications_url":"https://api.github.com/repos/Turbo87/babel-plugin-filter-imports/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Turbo87/babel-plugin-filter-imports/labels{/name}","releases_url":"https://api.github.com/repos/Turbo87/babel-plugin-filter-imports/releases{/id}","deployments_url":"https://api.github.com/repos/Turbo87/babel-plugin-filter-imports/deployments","created_at":"2016-06-09T13:50:39Z","updated_at":"2016-06-09T13:50:40Z","pushed_at":"2016-06-09T13:51:00Z","git_url":"git://github.com/Turbo87/babel-plugin-filter-imports.git","ssh_url":"git@github.com:Turbo87/babel-plugin-filter-imports.git","clone_url":"https://github.com/Turbo87/babel-plugin-filter-imports.git","svn_url":"https://github.com/Turbo87/babel-plugin-filter-imports","homepage":null,"size":9,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ember-cli:master","ref":"master","sha":"d24c71cbf879b48ed5418f40fdf39a12460e674c","user":{"login":"ember-cli","id":10262982,"avatar_url":"https://avatars.githubusercontent.com/u/10262982?v=3","gravatar_id":"","url":"https://api.github.com/users/ember-cli","html_url":"https://github.com/ember-cli","followers_url":"https://api.github.com/users/ember-cli/followers","following_url":"https://api.github.com/users/ember-cli/following{/other_user}","gists_url":"https://api.github.com/users/ember-cli/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-cli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-cli/subscriptions","organizations_url":"https://api.github.com/users/ember-cli/orgs","repos_url":"https://api.github.com/users/ember-cli/repos","events_url":"https://api.github.com/users/ember-cli/events{/privacy}","received_events_url":"https://api.github.com/users/ember-cli/received_events","type":"Organization","site_admin":false},"repo":{"id":36967730,"name":"babel-plugin-filter-imports","full_name":"ember-cli/babel-plugin-filter-imports","owner":{"login":"ember-cli","id":10262982,"avatar_url":"https://avatars.githubusercontent.com/u/10262982?v=3","gravatar_id":"","url":"https://api.github.com/users/ember-cli","html_url":"https://github.com/ember-cli","followers_url":"https://api.github.com/users/ember-cli/followers","following_url":"https://api.github.com/users/ember-cli/following{/other_user}","gists_url":"https://api.github.com/users/ember-cli/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-cli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-cli/subscriptions","organizations_url":"https://api.github.com/users/ember-cli/orgs","repos_url":"https://api.github.com/users/ember-cli/repos","events_url":"https://api.github.com/users/ember-cli/events{/privacy}","received_events_url":"https://api.github.com/users/ember-cli/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ember-cli/babel-plugin-filter-imports","description":"A babel transform for filtering out imports","fork":false,"url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports","forks_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/forks","keys_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/teams","hooks_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/hooks","issue_events_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/issues/events{/number}","events_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/events","assignees_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/assignees{/user}","branches_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/branches{/branch}","tags_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/tags","blobs_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/git/refs{/sha}","trees_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/statuses/{sha}","languages_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/languages","stargazers_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/stargazers","contributors_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/contributors","subscribers_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/subscribers","subscription_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/subscription","commits_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/commits{/sha}","git_commits_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/git/commits{/sha}","comments_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/comments{/number}","issue_comment_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/issues/comments{/number}","contents_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/contents/{+path}","compare_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/merges","archive_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/downloads","issues_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/issues{/number}","pulls_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/pulls{/number}","milestones_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/milestones{/number}","notifications_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/labels{/name}","releases_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/releases{/id}","deployments_url":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/deployments","created_at":"2015-06-06T04:46:49Z","updated_at":"2015-10-05T04:52:27Z","pushed_at":"2016-06-09T13:55:21Z","git_url":"git://github.com/ember-cli/babel-plugin-filter-imports.git","ssh_url":"git@github.com:ember-cli/babel-plugin-filter-imports.git","clone_url":"https://github.com/ember-cli/babel-plugin-filter-imports.git","svn_url":"https://github.com/ember-cli/babel-plugin-filter-imports","homepage":null,"size":155,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/pulls/6"},"html":{"href":"https://github.com/ember-cli/babel-plugin-filter-imports/pull/6"},"issue":{"href":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/issues/6"},"comments":{"href":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/ember-cli/babel-plugin-filter-imports/statuses/72cf54205d5cccc06ca3625f849f1ddc0ff13206"}}}}
{"actor":{"display_login":"Turbo87"}}