{"action":"closed","number":54,"pull_request":{"url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/pulls/54","id":82389169,"html_url":"https://github.com/CenterForOpenScience/ember-preprints/pull/54","diff_url":"https://github.com/CenterForOpenScience/ember-preprints/pull/54.diff","patch_url":"https://github.com/CenterForOpenScience/ember-preprints/pull/54.patch","issue_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/issues/54","number":54,"state":"closed","locked":false,"title":"Submit page project selector: restrict to relevant items","user":{"login":"abought","id":2957073,"avatar_url":"https://avatars.githubusercontent.com/u/2957073?v=3","gravatar_id":"","url":"https://api.github.com/users/abought","html_url":"https://github.com/abought","followers_url":"https://api.github.com/users/abought/followers","following_url":"https://api.github.com/users/abought/following{/other_user}","gists_url":"https://api.github.com/users/abought/gists{/gist_id}","starred_url":"https://api.github.com/users/abought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abought/subscriptions","organizations_url":"https://api.github.com/users/abought/orgs","repos_url":"https://api.github.com/users/abought/repos","events_url":"https://api.github.com/users/abought/events{/privacy}","received_events_url":"https://api.github.com/users/abought/received_events","type":"User","site_admin":false},"body":"# Purpose\r\nIn the submit page project selector, only show nodes that the user could actually turn into a preprint.\r\n\r\nExclude:\r\n- Things that are already preprints\r\n- Projects where the user does not have admin privileges\r\n\r\n# Summary of changes\r\nChange what shows up in the \"select a project\" dropdown box.\r\n\r\n# Notes for reviewers\r\nIn this version, we filter permissions client side. This is a hack in the interests of time.\r\n\r\nThe API does not currently support [filtering](https://github.com/abought/osf.io/blob/9cf7f7d1b3f0c5e933eedf82c3e1ba388579b3f4/api/nodes/serializers.py#L54-L54) on current_user_permissions.\r\n\r\nAdding a new filter would be good, but is not trivial under current timeline. SerializerMethodField does [not](https://github.com/abought/osf.io/blob/c3d39a3d07ad38cdebaac9280cb928e67179bb59/api/base/filters.py#L132-L132) support the `contains` operator, and there may be performance [implications](https://github.com/CenterForOpenScience/osf.io/blob/develop/api/base/filters.py#L400-L409) for the database in method field filtering because it iterates over a queryset in python.","created_at":"2016-08-23T15:39:16Z","updated_at":"2016-08-23T18:19:09Z","closed_at":"2016-08-23T18:19:08Z","merged_at":"2016-08-23T18:19:08Z","merge_commit_sha":"5fde32b9e5e6532c62788988998a87eb3a994707","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/pulls/54/commits","review_comments_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/pulls/54/comments","review_comment_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/issues/54/comments","statuses_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/statuses/d748e3065a78fe5cb909c60c4080d9f5df16a374","head":{"label":"abought:feature/prepmisc-submit-filter-nodelist","ref":"feature/prepmisc-submit-filter-nodelist","sha":"d748e3065a78fe5cb909c60c4080d9f5df16a374","user":{"login":"abought","id":2957073,"avatar_url":"https://avatars.githubusercontent.com/u/2957073?v=3","gravatar_id":"","url":"https://api.github.com/users/abought","html_url":"https://github.com/abought","followers_url":"https://api.github.com/users/abought/followers","following_url":"https://api.github.com/users/abought/following{/other_user}","gists_url":"https://api.github.com/users/abought/gists{/gist_id}","starred_url":"https://api.github.com/users/abought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abought/subscriptions","organizations_url":"https://api.github.com/users/abought/orgs","repos_url":"https://api.github.com/users/abought/repos","events_url":"https://api.github.com/users/abought/events{/privacy}","received_events_url":"https://api.github.com/users/abought/received_events","type":"User","site_admin":false},"repo":{"id":64674968,"name":"ember-preprints","full_name":"abought/ember-preprints","owner":{"login":"abought","id":2957073,"avatar_url":"https://avatars.githubusercontent.com/u/2957073?v=3","gravatar_id":"","url":"https://api.github.com/users/abought","html_url":"https://github.com/abought","followers_url":"https://api.github.com/users/abought/followers","following_url":"https://api.github.com/users/abought/following{/other_user}","gists_url":"https://api.github.com/users/abought/gists{/gist_id}","starred_url":"https://api.github.com/users/abought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abought/subscriptions","organizations_url":"https://api.github.com/users/abought/orgs","repos_url":"https://api.github.com/users/abought/repos","events_url":"https://api.github.com/users/abought/events{/privacy}","received_events_url":"https://api.github.com/users/abought/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abought/ember-preprints","description":null,"fork":true,"url":"https://api.github.com/repos/abought/ember-preprints","forks_url":"https://api.github.com/repos/abought/ember-preprints/forks","keys_url":"https://api.github.com/repos/abought/ember-preprints/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abought/ember-preprints/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abought/ember-preprints/teams","hooks_url":"https://api.github.com/repos/abought/ember-preprints/hooks","issue_events_url":"https://api.github.com/repos/abought/ember-preprints/issues/events{/number}","events_url":"https://api.github.com/repos/abought/ember-preprints/events","assignees_url":"https://api.github.com/repos/abought/ember-preprints/assignees{/user}","branches_url":"https://api.github.com/repos/abought/ember-preprints/branches{/branch}","tags_url":"https://api.github.com/repos/abought/ember-preprints/tags","blobs_url":"https://api.github.com/repos/abought/ember-preprints/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abought/ember-preprints/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abought/ember-preprints/git/refs{/sha}","trees_url":"https://api.github.com/repos/abought/ember-preprints/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abought/ember-preprints/statuses/{sha}","languages_url":"https://api.github.com/repos/abought/ember-preprints/languages","stargazers_url":"https://api.github.com/repos/abought/ember-preprints/stargazers","contributors_url":"https://api.github.com/repos/abought/ember-preprints/contributors","subscribers_url":"https://api.github.com/repos/abought/ember-preprints/subscribers","subscription_url":"https://api.github.com/repos/abought/ember-preprints/subscription","commits_url":"https://api.github.com/repos/abought/ember-preprints/commits{/sha}","git_commits_url":"https://api.github.com/repos/abought/ember-preprints/git/commits{/sha}","comments_url":"https://api.github.com/repos/abought/ember-preprints/comments{/number}","issue_comment_url":"https://api.github.com/repos/abought/ember-preprints/issues/comments{/number}","contents_url":"https://api.github.com/repos/abought/ember-preprints/contents/{+path}","compare_url":"https://api.github.com/repos/abought/ember-preprints/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abought/ember-preprints/merges","archive_url":"https://api.github.com/repos/abought/ember-preprints/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abought/ember-preprints/downloads","issues_url":"https://api.github.com/repos/abought/ember-preprints/issues{/number}","pulls_url":"https://api.github.com/repos/abought/ember-preprints/pulls{/number}","milestones_url":"https://api.github.com/repos/abought/ember-preprints/milestones{/number}","notifications_url":"https://api.github.com/repos/abought/ember-preprints/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abought/ember-preprints/labels{/name}","releases_url":"https://api.github.com/repos/abought/ember-preprints/releases{/id}","deployments_url":"https://api.github.com/repos/abought/ember-preprints/deployments","created_at":"2016-08-01T14:43:22Z","updated_at":"2016-08-01T14:43:23Z","pushed_at":"2016-08-23T15:30:26Z","git_url":"git://github.com/abought/ember-preprints.git","ssh_url":"git@github.com:abought/ember-preprints.git","clone_url":"https://github.com/abought/ember-preprints.git","svn_url":"https://github.com/abought/ember-preprints","homepage":null,"size":9051,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"CenterForOpenScience:develop","ref":"develop","sha":"6c3fb72d7013207c8b2f48a675231e0f543ea3dd","user":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars.githubusercontent.com/u/3344584?v=3","gravatar_id":"","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"repo":{"id":63790282,"name":"ember-preprints","full_name":"CenterForOpenScience/ember-preprints","owner":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars.githubusercontent.com/u/3344584?v=3","gravatar_id":"","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CenterForOpenScience/ember-preprints","description":null,"fork":false,"url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints","forks_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/forks","keys_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/teams","hooks_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/hooks","issue_events_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/issues/events{/number}","events_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/events","assignees_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/assignees{/user}","branches_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/branches{/branch}","tags_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/tags","blobs_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/git/refs{/sha}","trees_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/statuses/{sha}","languages_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/languages","stargazers_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/stargazers","contributors_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/contributors","subscribers_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/subscribers","subscription_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/subscription","commits_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/commits{/sha}","git_commits_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/git/commits{/sha}","comments_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/comments{/number}","issue_comment_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/issues/comments{/number}","contents_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/contents/{+path}","compare_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/merges","archive_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/downloads","issues_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/issues{/number}","pulls_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/pulls{/number}","milestones_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/milestones{/number}","notifications_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/labels{/name}","releases_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/releases{/id}","deployments_url":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/deployments","created_at":"2016-07-20T14:56:36Z","updated_at":"2016-07-20T14:58:52Z","pushed_at":"2016-08-23T18:19:08Z","git_url":"git://github.com/CenterForOpenScience/ember-preprints.git","ssh_url":"git@github.com:CenterForOpenScience/ember-preprints.git","clone_url":"https://github.com/CenterForOpenScience/ember-preprints.git","svn_url":"https://github.com/CenterForOpenScience/ember-preprints","homepage":null,"size":11283,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":3,"forks":12,"open_issues":3,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/pulls/54"},"html":{"href":"https://github.com/CenterForOpenScience/ember-preprints/pull/54"},"issue":{"href":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/issues/54"},"comments":{"href":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/CenterForOpenScience/ember-preprints/statuses/d748e3065a78fe5cb909c60c4080d9f5df16a374"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"abought","id":2957073,"avatar_url":"https://avatars.githubusercontent.com/u/2957073?v=3","gravatar_id":"","url":"https://api.github.com/users/abought","html_url":"https://github.com/abought","followers_url":"https://api.github.com/users/abought/followers","following_url":"https://api.github.com/users/abought/following{/other_user}","gists_url":"https://api.github.com/users/abought/gists{/gist_id}","starred_url":"https://api.github.com/users/abought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abought/subscriptions","organizations_url":"https://api.github.com/users/abought/orgs","repos_url":"https://api.github.com/users/abought/repos","events_url":"https://api.github.com/users/abought/events{/privacy}","received_events_url":"https://api.github.com/users/abought/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":9,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"abought"}}