{"action":"created","issue":{"url":"https://api.github.com/repos/svaarala/duktape/issues/982","repository_url":"https://api.github.com/repos/svaarala/duktape","labels_url":"https://api.github.com/repos/svaarala/duktape/issues/982/labels{/name}","comments_url":"https://api.github.com/repos/svaarala/duktape/issues/982/comments","events_url":"https://api.github.com/repos/svaarala/duktape/issues/982/events","html_url":"https://github.com/svaarala/duktape/pull/982","id":180200572,"number":982,"title":"Add initial ES6 symbol support","user":{"login":"svaarala","id":6377415,"avatar_url":"https://avatars.githubusercontent.com/u/6377415?v=3","gravatar_id":"","url":"https://api.github.com/users/svaarala","html_url":"https://github.com/svaarala","followers_url":"https://api.github.com/users/svaarala/followers","following_url":"https://api.github.com/users/svaarala/following{/other_user}","gists_url":"https://api.github.com/users/svaarala/gists{/gist_id}","starred_url":"https://api.github.com/users/svaarala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svaarala/subscriptions","organizations_url":"https://api.github.com/users/svaarala/orgs","repos_url":"https://api.github.com/users/svaarala/repos","events_url":"https://api.github.com/users/svaarala/events{/privacy}","received_events_url":"https://api.github.com/users/svaarala/received_events","type":"User","site_admin":false},"labels":[{"id":238834241,"url":"https://api.github.com/repos/svaarala/duktape/labels/es6","name":"es6","color":"bfe5bf","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/svaarala/duktape/milestones/5","html_url":"https://github.com/svaarala/duktape/milestones/v2.0.0","labels_url":"https://api.github.com/repos/svaarala/duktape/milestones/5/labels","id":840957,"number":5,"title":"v2.0.0","description":"","creator":{"login":"svaarala","id":6377415,"avatar_url":"https://avatars.githubusercontent.com/u/6377415?v=3","gravatar_id":"","url":"https://api.github.com/users/svaarala","html_url":"https://github.com/svaarala","followers_url":"https://api.github.com/users/svaarala/followers","following_url":"https://api.github.com/users/svaarala/following{/other_user}","gists_url":"https://api.github.com/users/svaarala/gists{/gist_id}","starred_url":"https://api.github.com/users/svaarala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svaarala/subscriptions","organizations_url":"https://api.github.com/users/svaarala/orgs","repos_url":"https://api.github.com/users/svaarala/repos","events_url":"https://api.github.com/users/svaarala/events{/privacy}","received_events_url":"https://api.github.com/users/svaarala/received_events","type":"User","site_admin":false},"open_issues":61,"closed_issues":242,"state":"open","created_at":"2014-10-26T15:05:37Z","updated_at":"2016-11-29T01:17:15Z","due_on":null,"closed_at":null},"comments":32,"created_at":"2016-09-30T01:28:20Z","updated_at":"2016-11-29T05:02:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/svaarala/duktape/pulls/982","html_url":"https://github.com/svaarala/duktape/pull/982","diff_url":"https://github.com/svaarala/duktape/pull/982.diff","patch_url":"https://github.com/svaarala/duktape/pull/982.patch"},"body":"This is a prototype for an implementation approach where Symbols are `duk_hstring`s with a specific byte prefix which cannot occur for valid (extended) UTF-8 strings. The existing internal string concept is essentially taken a step further to support ES6 Symbols. There's no new internal type for Symbols as such, and the C API sees Symbols as just strings.\r\n\r\n- [ ] Code change for symbol support\r\n- [ ] Fix compiler warnings\r\n- [ ] Testcase support\r\n- [ ] Website\r\n- [ ] Internal documentation\r\n- [ ] Wiki pull for symbols howto (should cover the C API aspects especially)\r\n- [ ] 2.x migration notes\r\n- [ ] Releases entry\r\n- [ ] Read through pull comments and add cleanup issues to #1120"},"comment":{"url":"https://api.github.com/repos/svaarala/duktape/issues/comments/263477090","html_url":"https://github.com/svaarala/duktape/pull/982#issuecomment-263477090","issue_url":"https://api.github.com/repos/svaarala/duktape/issues/982","id":263477090,"user":{"login":"fatcerberus","id":4097841,"avatar_url":"https://avatars.githubusercontent.com/u/4097841?v=3","gravatar_id":"","url":"https://api.github.com/users/fatcerberus","html_url":"https://github.com/fatcerberus","followers_url":"https://api.github.com/users/fatcerberus/followers","following_url":"https://api.github.com/users/fatcerberus/following{/other_user}","gists_url":"https://api.github.com/users/fatcerberus/gists{/gist_id}","starred_url":"https://api.github.com/users/fatcerberus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fatcerberus/subscriptions","organizations_url":"https://api.github.com/users/fatcerberus/orgs","repos_url":"https://api.github.com/users/fatcerberus/repos","events_url":"https://api.github.com/users/fatcerberus/events{/privacy}","received_events_url":"https://api.github.com/users/fatcerberus/received_events","type":"User","site_admin":false},"created_at":"2016-11-29T05:02:53Z","updated_at":"2016-11-29T05:02:53Z","body":"Hm, I don't think this is intended behavior:\r\n\r\n```\r\nduk> String(Symbol.toStringTag)\r\n= \"Symbol(Symbol.toStringTag)\"\r\nduk> Symbol.toStringTag\r\n= undefined\r\n```"}}
{"actor":{"display_login":"fatcerberus"}}