{"action":"opened","number":625,"pull_request":{"url":"https://api.github.com/repos/freeorion/freeorion/pulls/625","id":67648184,"html_url":"https://github.com/freeorion/freeorion/pull/625","diff_url":"https://github.com/freeorion/freeorion/pull/625.diff","patch_url":"https://github.com/freeorion/freeorion/pull/625.patch","issue_url":"https://api.github.com/repos/freeorion/freeorion/issues/625","number":625,"state":"open","locked":false,"title":"Fix bug513 bug597 resetting sitrep","user":{"login":"LGM-Doyle","id":17235966,"avatar_url":"https://avatars.githubusercontent.com/u/17235966?v=3","gravatar_id":"","url":"https://api.github.com/users/LGM-Doyle","html_url":"https://github.com/LGM-Doyle","followers_url":"https://api.github.com/users/LGM-Doyle/followers","following_url":"https://api.github.com/users/LGM-Doyle/following{/other_user}","gists_url":"https://api.github.com/users/LGM-Doyle/gists{/gist_id}","starred_url":"https://api.github.com/users/LGM-Doyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LGM-Doyle/subscriptions","organizations_url":"https://api.github.com/users/LGM-Doyle/orgs","repos_url":"https://api.github.com/users/LGM-Doyle/repos","events_url":"https://api.github.com/users/LGM-Doyle/events{/privacy}","received_events_url":"https://api.github.com/users/LGM-Doyle/received_events","type":"User","site_admin":false},"body":"This PR fixes bug #513 and bug #597, which both deal with the sitrep window resetting when either the MapWnd closes the production window or when the filtering of sitreps is changed.\r\n\r\nIt also fixes two un-reported bugs in GG::List SetFirstRowShown and BringRowIntoView where it was using the height of the target row in place of the height of each individual rows when re-positioning the rows.  This fix was necessary for the fix of the resetting of the sitrep window with changing filtering.\r\n\r\nThe fix for the map window is simply to not update when toggling the sitrep window.\r\n\r\nThe fix for the resetting with filtering is two steps.\r\n1. always restore sitrep->list positioning on each update. \r\n2. Only change which sitrep is displayed in ShowSitRepsForTurn(), which also sets the sitrep window to display the first row.","created_at":"2016-04-24T20:02:40Z","updated_at":"2016-04-24T20:02:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/freeorion/freeorion/pulls/625/commits","review_comments_url":"https://api.github.com/repos/freeorion/freeorion/pulls/625/comments","review_comment_url":"https://api.github.com/repos/freeorion/freeorion/pulls/comments{/number}","comments_url":"https://api.github.com/repos/freeorion/freeorion/issues/625/comments","statuses_url":"https://api.github.com/repos/freeorion/freeorion/statuses/71fdef7d9d63286da5d608663eccedeaab87843b","head":{"label":"LGM-Doyle:fix_bug513_bug597_resetting_sitrep","ref":"fix_bug513_bug597_resetting_sitrep","sha":"71fdef7d9d63286da5d608663eccedeaab87843b","user":{"login":"LGM-Doyle","id":17235966,"avatar_url":"https://avatars.githubusercontent.com/u/17235966?v=3","gravatar_id":"","url":"https://api.github.com/users/LGM-Doyle","html_url":"https://github.com/LGM-Doyle","followers_url":"https://api.github.com/users/LGM-Doyle/followers","following_url":"https://api.github.com/users/LGM-Doyle/following{/other_user}","gists_url":"https://api.github.com/users/LGM-Doyle/gists{/gist_id}","starred_url":"https://api.github.com/users/LGM-Doyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LGM-Doyle/subscriptions","organizations_url":"https://api.github.com/users/LGM-Doyle/orgs","repos_url":"https://api.github.com/users/LGM-Doyle/repos","events_url":"https://api.github.com/users/LGM-Doyle/events{/privacy}","received_events_url":"https://api.github.com/users/LGM-Doyle/received_events","type":"User","site_admin":false},"repo":{"id":51704490,"name":"freeorion","full_name":"LGM-Doyle/freeorion","owner":{"login":"LGM-Doyle","id":17235966,"avatar_url":"https://avatars.githubusercontent.com/u/17235966?v=3","gravatar_id":"","url":"https://api.github.com/users/LGM-Doyle","html_url":"https://github.com/LGM-Doyle","followers_url":"https://api.github.com/users/LGM-Doyle/followers","following_url":"https://api.github.com/users/LGM-Doyle/following{/other_user}","gists_url":"https://api.github.com/users/LGM-Doyle/gists{/gist_id}","starred_url":"https://api.github.com/users/LGM-Doyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LGM-Doyle/subscriptions","organizations_url":"https://api.github.com/users/LGM-Doyle/orgs","repos_url":"https://api.github.com/users/LGM-Doyle/repos","events_url":"https://api.github.com/users/LGM-Doyle/events{/privacy}","received_events_url":"https://api.github.com/users/LGM-Doyle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LGM-Doyle/freeorion","description":"Source code repository of the FreeOrion project.","fork":true,"url":"https://api.github.com/repos/LGM-Doyle/freeorion","forks_url":"https://api.github.com/repos/LGM-Doyle/freeorion/forks","keys_url":"https://api.github.com/repos/LGM-Doyle/freeorion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LGM-Doyle/freeorion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LGM-Doyle/freeorion/teams","hooks_url":"https://api.github.com/repos/LGM-Doyle/freeorion/hooks","issue_events_url":"https://api.github.com/repos/LGM-Doyle/freeorion/issues/events{/number}","events_url":"https://api.github.com/repos/LGM-Doyle/freeorion/events","assignees_url":"https://api.github.com/repos/LGM-Doyle/freeorion/assignees{/user}","branches_url":"https://api.github.com/repos/LGM-Doyle/freeorion/branches{/branch}","tags_url":"https://api.github.com/repos/LGM-Doyle/freeorion/tags","blobs_url":"https://api.github.com/repos/LGM-Doyle/freeorion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LGM-Doyle/freeorion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LGM-Doyle/freeorion/git/refs{/sha}","trees_url":"https://api.github.com/repos/LGM-Doyle/freeorion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LGM-Doyle/freeorion/statuses/{sha}","languages_url":"https://api.github.com/repos/LGM-Doyle/freeorion/languages","stargazers_url":"https://api.github.com/repos/LGM-Doyle/freeorion/stargazers","contributors_url":"https://api.github.com/repos/LGM-Doyle/freeorion/contributors","subscribers_url":"https://api.github.com/repos/LGM-Doyle/freeorion/subscribers","subscription_url":"https://api.github.com/repos/LGM-Doyle/freeorion/subscription","commits_url":"https://api.github.com/repos/LGM-Doyle/freeorion/commits{/sha}","git_commits_url":"https://api.github.com/repos/LGM-Doyle/freeorion/git/commits{/sha}","comments_url":"https://api.github.com/repos/LGM-Doyle/freeorion/comments{/number}","issue_comment_url":"https://api.github.com/repos/LGM-Doyle/freeorion/issues/comments{/number}","contents_url":"https://api.github.com/repos/LGM-Doyle/freeorion/contents/{+path}","compare_url":"https://api.github.com/repos/LGM-Doyle/freeorion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LGM-Doyle/freeorion/merges","archive_url":"https://api.github.com/repos/LGM-Doyle/freeorion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LGM-Doyle/freeorion/downloads","issues_url":"https://api.github.com/repos/LGM-Doyle/freeorion/issues{/number}","pulls_url":"https://api.github.com/repos/LGM-Doyle/freeorion/pulls{/number}","milestones_url":"https://api.github.com/repos/LGM-Doyle/freeorion/milestones{/number}","notifications_url":"https://api.github.com/repos/LGM-Doyle/freeorion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LGM-Doyle/freeorion/labels{/name}","releases_url":"https://api.github.com/repos/LGM-Doyle/freeorion/releases{/id}","deployments_url":"https://api.github.com/repos/LGM-Doyle/freeorion/deployments","created_at":"2016-02-14T17:21:56Z","updated_at":"2016-02-14T17:22:02Z","pushed_at":"2016-04-24T19:25:05Z","git_url":"git://github.com/LGM-Doyle/freeorion.git","ssh_url":"git@github.com:LGM-Doyle/freeorion.git","clone_url":"https://github.com/LGM-Doyle/freeorion.git","svn_url":"https://github.com/LGM-Doyle/freeorion","homepage":"http://www.freeorion.org/","size":515211,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"freeorion:master","ref":"master","sha":"b8d3c481cedb0dcf589b9f5400482d719f99f560","user":{"login":"freeorion","id":1025550,"avatar_url":"https://avatars.githubusercontent.com/u/1025550?v=3","gravatar_id":"","url":"https://api.github.com/users/freeorion","html_url":"https://github.com/freeorion","followers_url":"https://api.github.com/users/freeorion/followers","following_url":"https://api.github.com/users/freeorion/following{/other_user}","gists_url":"https://api.github.com/users/freeorion/gists{/gist_id}","starred_url":"https://api.github.com/users/freeorion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeorion/subscriptions","organizations_url":"https://api.github.com/users/freeorion/orgs","repos_url":"https://api.github.com/users/freeorion/repos","events_url":"https://api.github.com/users/freeorion/events{/privacy}","received_events_url":"https://api.github.com/users/freeorion/received_events","type":"Organization","site_admin":false},"repo":{"id":33066062,"name":"freeorion","full_name":"freeorion/freeorion","owner":{"login":"freeorion","id":1025550,"avatar_url":"https://avatars.githubusercontent.com/u/1025550?v=3","gravatar_id":"","url":"https://api.github.com/users/freeorion","html_url":"https://github.com/freeorion","followers_url":"https://api.github.com/users/freeorion/followers","following_url":"https://api.github.com/users/freeorion/following{/other_user}","gists_url":"https://api.github.com/users/freeorion/gists{/gist_id}","starred_url":"https://api.github.com/users/freeorion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeorion/subscriptions","organizations_url":"https://api.github.com/users/freeorion/orgs","repos_url":"https://api.github.com/users/freeorion/repos","events_url":"https://api.github.com/users/freeorion/events{/privacy}","received_events_url":"https://api.github.com/users/freeorion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/freeorion/freeorion","description":"Source code repository of the FreeOrion project.","fork":false,"url":"https://api.github.com/repos/freeorion/freeorion","forks_url":"https://api.github.com/repos/freeorion/freeorion/forks","keys_url":"https://api.github.com/repos/freeorion/freeorion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freeorion/freeorion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freeorion/freeorion/teams","hooks_url":"https://api.github.com/repos/freeorion/freeorion/hooks","issue_events_url":"https://api.github.com/repos/freeorion/freeorion/issues/events{/number}","events_url":"https://api.github.com/repos/freeorion/freeorion/events","assignees_url":"https://api.github.com/repos/freeorion/freeorion/assignees{/user}","branches_url":"https://api.github.com/repos/freeorion/freeorion/branches{/branch}","tags_url":"https://api.github.com/repos/freeorion/freeorion/tags","blobs_url":"https://api.github.com/repos/freeorion/freeorion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freeorion/freeorion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freeorion/freeorion/git/refs{/sha}","trees_url":"https://api.github.com/repos/freeorion/freeorion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freeorion/freeorion/statuses/{sha}","languages_url":"https://api.github.com/repos/freeorion/freeorion/languages","stargazers_url":"https://api.github.com/repos/freeorion/freeorion/stargazers","contributors_url":"https://api.github.com/repos/freeorion/freeorion/contributors","subscribers_url":"https://api.github.com/repos/freeorion/freeorion/subscribers","subscription_url":"https://api.github.com/repos/freeorion/freeorion/subscription","commits_url":"https://api.github.com/repos/freeorion/freeorion/commits{/sha}","git_commits_url":"https://api.github.com/repos/freeorion/freeorion/git/commits{/sha}","comments_url":"https://api.github.com/repos/freeorion/freeorion/comments{/number}","issue_comment_url":"https://api.github.com/repos/freeorion/freeorion/issues/comments{/number}","contents_url":"https://api.github.com/repos/freeorion/freeorion/contents/{+path}","compare_url":"https://api.github.com/repos/freeorion/freeorion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freeorion/freeorion/merges","archive_url":"https://api.github.com/repos/freeorion/freeorion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freeorion/freeorion/downloads","issues_url":"https://api.github.com/repos/freeorion/freeorion/issues{/number}","pulls_url":"https://api.github.com/repos/freeorion/freeorion/pulls{/number}","milestones_url":"https://api.github.com/repos/freeorion/freeorion/milestones{/number}","notifications_url":"https://api.github.com/repos/freeorion/freeorion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freeorion/freeorion/labels{/name}","releases_url":"https://api.github.com/repos/freeorion/freeorion/releases{/id}","deployments_url":"https://api.github.com/repos/freeorion/freeorion/deployments","created_at":"2015-03-29T08:22:20Z","updated_at":"2016-04-20T10:55:45Z","pushed_at":"2016-04-24T20:02:36Z","git_url":"git://github.com/freeorion/freeorion.git","ssh_url":"git@github.com:freeorion/freeorion.git","clone_url":"https://github.com/freeorion/freeorion.git","svn_url":"https://github.com/freeorion/freeorion","homepage":"http://www.freeorion.org/","size":533409,"stargazers_count":139,"watchers_count":139,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":59,"mirror_url":null,"open_issues_count":64,"forks":59,"open_issues":64,"watchers":139,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/625"},"html":{"href":"https://github.com/freeorion/freeorion/pull/625"},"issue":{"href":"https://api.github.com/repos/freeorion/freeorion/issues/625"},"comments":{"href":"https://api.github.com/repos/freeorion/freeorion/issues/625/comments"},"review_comments":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/625/comments"},"review_comment":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/625/commits"},"statuses":{"href":"https://api.github.com/repos/freeorion/freeorion/statuses/71fdef7d9d63286da5d608663eccedeaab87843b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":20,"deletions":13,"changed_files":3}}