{"action":"created","comment":{"url":"https://api.github.com/repos/AliSoftware/SwiftGen/pulls/comments/65818959","id":65818959,"diff_hunk":"@@ -82,11 +82,12 @@ extension StoryboardParser {\n           .sort({$0.storyboardID < $1.storyboardID})\n           .map { (scene: Scene) -> [String:String] in\n             // Handle special scene.tag cases like navigationController, splitViewController, etc…\n-            let customClass = scene.customClass ??\n-              (scene.tag != \"viewController\" ? uppercaseFirst(scene.tag) : nil)\n-            if let customClass = customClass where scene.customClass == nil {\n-              return [\"identifier\": scene.storyboardID, \"class\": customClass]\n-            } else if let customClass = customClass {\n+            let customClass = scene.customClass ?? uppercaseFirst(scene.tag)\n+            if scene.customClass == nil && scene.tag == \"viewController\" {\n+              return [\"identifier\": scene.storyboardID, \"class\": customClass, \"isBaseViewController\": \"\"]\n+            } else if scene.customClass == nil {\n+                return [\"identifier\": scene.storyboardID, \"class\": customClass]\n+            } else if let customClass = scene.customClass {\n               return [\"identifier\": scene.storyboardID, \"class\": customClass, \"vcType\": customClass]","path":"GenumKit/Stencil/Contexts.swift","position":null,"original_position":15,"commit_id":"8765cf664e2b7a58fd37f89fdfbd9d07baa1d3a6","original_commit_id":"8765cf664e2b7a58fd37f89fdfbd9d07baa1d3a6","user":{"login":"AliSoftware","id":216089,"avatar_url":"https://avatars.githubusercontent.com/u/216089?v=3","gravatar_id":"","url":"https://api.github.com/users/AliSoftware","html_url":"https://github.com/AliSoftware","followers_url":"https://api.github.com/users/AliSoftware/followers","following_url":"https://api.github.com/users/AliSoftware/following{/other_user}","gists_url":"https://api.github.com/users/AliSoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/AliSoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AliSoftware/subscriptions","organizations_url":"https://api.github.com/users/AliSoftware/orgs","repos_url":"https://api.github.com/users/AliSoftware/repos","events_url":"https://api.github.com/users/AliSoftware/events{/privacy}","received_events_url":"https://api.github.com/users/AliSoftware/received_events","type":"User","site_admin":false},"body":"ok 👍  sorry for having reacted _that_ quickly, I'll let you work now 😆 Good luck 😉 ","created_at":"2016-06-05T15:09:32Z","updated_at":"2016-06-05T15:09:32Z","html_url":"https://github.com/AliSoftware/SwiftGen/pull/131#discussion_r65818959","pull_request_url":"https://api.github.com/repos/AliSoftware/SwiftGen/pulls/131","_links":{"self":{"href":"https://api.github.com/repos/AliSoftware/SwiftGen/pulls/comments/65818959"},"html":{"href":"https://github.com/AliSoftware/SwiftGen/pull/131#discussion_r65818959"},"pull_request":{"href":"https://api.github.com/repos/AliSoftware/SwiftGen/pulls/131"}}},"pull_request":{"url":"https://api.github.com/repos/AliSoftware/SwiftGen/pulls/131","id":72619174,"html_url":"https://github.com/AliSoftware/SwiftGen/pull/131","diff_url":"https://github.com/AliSoftware/SwiftGen/pull/131.diff","patch_url":"https://github.com/AliSoftware/SwiftGen/pull/131.patch","issue_url":"https://api.github.com/repos/AliSoftware/SwiftGen/issues/131","number":131,"state":"open","locked":false,"title":"Storyboards templates for OS X","user":{"login":"tbaranes","id":1402212,"avatar_url":"https://avatars.githubusercontent.com/u/1402212?v=3","gravatar_id":"","url":"https://api.github.com/users/tbaranes","html_url":"https://github.com/tbaranes","followers_url":"https://api.github.com/users/tbaranes/followers","following_url":"https://api.github.com/users/tbaranes/following{/other_user}","gists_url":"https://api.github.com/users/tbaranes/gists{/gist_id}","starred_url":"https://api.github.com/users/tbaranes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbaranes/subscriptions","organizations_url":"https://api.github.com/users/tbaranes/orgs","repos_url":"https://api.github.com/users/tbaranes/repos","events_url":"https://api.github.com/users/tbaranes/events{/privacy}","received_events_url":"https://api.github.com/users/tbaranes/received_events","type":"User","site_admin":false},"body":"Just migrated all the works did in my fork in a local branch, closing #128 in favour of this one.\r\n\r\nThings to do (following the previous discussion):\r\n- [ ] Templates: `storyboards-uppercase` and `storyboards-lowercase`\r\n- [ ] Separate iOS and OS X storyboards in different fixtures directory in order to fix tests `testAllStoryboardsWithDefaults` and `testAllStoryboardsWithCustomName`\r\n- [ ] Drop the hard coded `UI` to handle `NS` prefix (cf @AliSoftware explanation below)\r\n- [ ] Find a satisfying output 😆 \r\n\r\n> I annotated the code with 2 // TODO: comments just recently — which will show up as warnings thanks to the new SwiftLint script I recently added — to highlight where that needs to be changed. You might want to rebase your PR on top of master btw to get them here.\r\n\r\n> We'll probably need to add a new field to the stencil context in addition to \"identifier\" and \"class\", like vcType or something, to store the scene.tag there (which is the XML tag name and is usually either <viewController …>, <navigationController …>, <tableViewController …> and the likes). Then we'll have to alter the templates to use either {{scene.class}} if it's defined (if it's a custom class), or the UI{{scene.vcType|titlecase}} if scene.class is nil. And then we can easily change that UI into NS for the OS X template.\r\n\r\n⚠️  The current state of this PR is more a proof of concept to discuss the output than a final implementation ⚠️  \r\n\r\nPS: I will be in vacation starting mid of next week for two weeks, I will get this PR ready once I'm back if anyone finish it 👯 ","created_at":"2016-06-05T03:03:32Z","updated_at":"2016-06-05T15:09:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97af8cf809c2e35e66fa075d82c6c5ecda937de8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AliSoftware/SwiftGen/pulls/131/commits","review_comments_url":"https://api.github.com/repos/AliSoftware/SwiftGen/pulls/131/comments","review_comment_url":"https://api.github.com/repos/AliSoftware/SwiftGen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AliSoftware/SwiftGen/issues/131/comments","statuses_url":"https://api.github.com/repos/AliSoftware/SwiftGen/statuses/8765cf664e2b7a58fd37f89fdfbd9d07baa1d3a6","head":{"label":"AliSoftware:feature/storyboards_osx","ref":"feature/storyboards_osx","sha":"8765cf664e2b7a58fd37f89fdfbd9d07baa1d3a6","user":{"login":"AliSoftware","id":216089,"avatar_url":"https://avatars.githubusercontent.com/u/216089?v=3","gravatar_id":"","url":"https://api.github.com/users/AliSoftware","html_url":"https://github.com/AliSoftware","followers_url":"https://api.github.com/users/AliSoftware/followers","following_url":"https://api.github.com/users/AliSoftware/following{/other_user}","gists_url":"https://api.github.com/users/AliSoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/AliSoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AliSoftware/subscriptions","organizations_url":"https://api.github.com/users/AliSoftware/orgs","repos_url":"https://api.github.com/users/AliSoftware/repos","events_url":"https://api.github.com/users/AliSoftware/events{/privacy}","received_events_url":"https://api.github.com/users/AliSoftware/received_events","type":"User","site_admin":false},"repo":{"id":39166950,"name":"SwiftGen","full_name":"AliSoftware/SwiftGen","owner":{"login":"AliSoftware","id":216089,"avatar_url":"https://avatars.githubusercontent.com/u/216089?v=3","gravatar_id":"","url":"https://api.github.com/users/AliSoftware","html_url":"https://github.com/AliSoftware","followers_url":"https://api.github.com/users/AliSoftware/followers","following_url":"https://api.github.com/users/AliSoftware/following{/other_user}","gists_url":"https://api.github.com/users/AliSoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/AliSoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AliSoftware/subscriptions","organizations_url":"https://api.github.com/users/AliSoftware/orgs","repos_url":"https://api.github.com/users/AliSoftware/repos","events_url":"https://api.github.com/users/AliSoftware/events{/privacy}","received_events_url":"https://api.github.com/users/AliSoftware/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AliSoftware/SwiftGen","description":"A collection of Swift tools to generate Swift code (enums for your assets, storyboards, Localizable.strings, …)","fork":false,"url":"https://api.github.com/repos/AliSoftware/SwiftGen","forks_url":"https://api.github.com/repos/AliSoftware/SwiftGen/forks","keys_url":"https://api.github.com/repos/AliSoftware/SwiftGen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AliSoftware/SwiftGen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AliSoftware/SwiftGen/teams","hooks_url":"https://api.github.com/repos/AliSoftware/SwiftGen/hooks","issue_events_url":"https://api.github.com/repos/AliSoftware/SwiftGen/issues/events{/number}","events_url":"https://api.github.com/repos/AliSoftware/SwiftGen/events","assignees_url":"https://api.github.com/repos/AliSoftware/SwiftGen/assignees{/user}","branches_url":"https://api.github.com/repos/AliSoftware/SwiftGen/branches{/branch}","tags_url":"https://api.github.com/repos/AliSoftware/SwiftGen/tags","blobs_url":"https://api.github.com/repos/AliSoftware/SwiftGen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AliSoftware/SwiftGen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AliSoftware/SwiftGen/git/refs{/sha}","trees_url":"https://api.github.com/repos/AliSoftware/SwiftGen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AliSoftware/SwiftGen/statuses/{sha}","languages_url":"https://api.github.com/repos/AliSoftware/SwiftGen/languages","stargazers_url":"https://api.github.com/repos/AliSoftware/SwiftGen/stargazers","contributors_url":"https://api.github.com/repos/AliSoftware/SwiftGen/contributors","subscribers_url":"https://api.github.com/repos/AliSoftware/SwiftGen/subscribers","subscription_url":"https://api.github.com/repos/AliSoftware/SwiftGen/subscription","commits_url":"https://api.github.com/repos/AliSoftware/SwiftGen/commits{/sha}","git_commits_url":"https://api.github.com/repos/AliSoftware/SwiftGen/git/commits{/sha}","comments_url":"https://api.github.com/repos/AliSoftware/SwiftGen/comments{/number}","issue_comment_url":"https://api.github.com/repos/AliSoftware/SwiftGen/issues/comments{/number}","contents_url":"https://api.github.com/repos/AliSoftware/SwiftGen/contents/{+path}","compare_url":"https://api.github.com/repos/AliSoftware/SwiftGen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AliSoftware/SwiftGen/merges","archive_url":"https://api.github.com/repos/AliSoftware/SwiftGen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AliSoftware/SwiftGen/downloads","issues_url":"https://api.github.com/repos/AliSoftware/SwiftGen/issues{/number}","pulls_url":"https://api.github.com/repos/AliSoftware/SwiftGen/pulls{/number}","milestones_url":"https://api.github.com/repos/AliSoftware/SwiftGen/milestones{/number}","notifications_url":"https://api.github.com/repos/AliSoftware/SwiftGen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AliSoftware/SwiftGen/labels{/name}","releases_url":"https://api.github.com/repos/AliSoftware/SwiftGen/releases{/id}","deployments_url":"https://api.github.com/repos/AliSoftware/SwiftGen/deployments","created_at":"2015-07-15T23:58:44Z","updated_at":"2016-06-05T11:06:57Z","pushed_at":"2016-06-05T15:08:58Z","git_url":"git://github.com/AliSoftware/SwiftGen.git","ssh_url":"git@github.com:AliSoftware/SwiftGen.git","clone_url":"https://github.com/AliSoftware/SwiftGen.git","svn_url":"https://github.com/AliSoftware/SwiftGen","homepage":"","size":3315,"stargazers_count":2006,"watchers_count":2006,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":116,"mirror_url":null,"open_issues_count":22,"forks":116,"open_issues":22,"watchers":2006,"default_branch":"master"}},"base":{"label":"AliSoftware:master","ref":"master","sha":"11e21cf0bcca689f5522b0ca3cba3cfba481d8f6","user":{"login":"AliSoftware","id":216089,"avatar_url":"https://avatars.githubusercontent.com/u/216089?v=3","gravatar_id":"","url":"https://api.github.com/users/AliSoftware","html_url":"https://github.com/AliSoftware","followers_url":"https://api.github.com/users/AliSoftware/followers","following_url":"https://api.github.com/users/AliSoftware/following{/other_user}","gists_url":"https://api.github.com/users/AliSoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/AliSoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AliSoftware/subscriptions","organizations_url":"https://api.github.com/users/AliSoftware/orgs","repos_url":"https://api.github.com/users/AliSoftware/repos","events_url":"https://api.github.com/users/AliSoftware/events{/privacy}","received_events_url":"https://api.github.com/users/AliSoftware/received_events","type":"User","site_admin":false},"repo":{"id":39166950,"name":"SwiftGen","full_name":"AliSoftware/SwiftGen","owner":{"login":"AliSoftware","id":216089,"avatar_url":"https://avatars.githubusercontent.com/u/216089?v=3","gravatar_id":"","url":"https://api.github.com/users/AliSoftware","html_url":"https://github.com/AliSoftware","followers_url":"https://api.github.com/users/AliSoftware/followers","following_url":"https://api.github.com/users/AliSoftware/following{/other_user}","gists_url":"https://api.github.com/users/AliSoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/AliSoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AliSoftware/subscriptions","organizations_url":"https://api.github.com/users/AliSoftware/orgs","repos_url":"https://api.github.com/users/AliSoftware/repos","events_url":"https://api.github.com/users/AliSoftware/events{/privacy}","received_events_url":"https://api.github.com/users/AliSoftware/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AliSoftware/SwiftGen","description":"A collection of Swift tools to generate Swift code (enums for your assets, storyboards, Localizable.strings, …)","fork":false,"url":"https://api.github.com/repos/AliSoftware/SwiftGen","forks_url":"https://api.github.com/repos/AliSoftware/SwiftGen/forks","keys_url":"https://api.github.com/repos/AliSoftware/SwiftGen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AliSoftware/SwiftGen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AliSoftware/SwiftGen/teams","hooks_url":"https://api.github.com/repos/AliSoftware/SwiftGen/hooks","issue_events_url":"https://api.github.com/repos/AliSoftware/SwiftGen/issues/events{/number}","events_url":"https://api.github.com/repos/AliSoftware/SwiftGen/events","assignees_url":"https://api.github.com/repos/AliSoftware/SwiftGen/assignees{/user}","branches_url":"https://api.github.com/repos/AliSoftware/SwiftGen/branches{/branch}","tags_url":"https://api.github.com/repos/AliSoftware/SwiftGen/tags","blobs_url":"https://api.github.com/repos/AliSoftware/SwiftGen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AliSoftware/SwiftGen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AliSoftware/SwiftGen/git/refs{/sha}","trees_url":"https://api.github.com/repos/AliSoftware/SwiftGen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AliSoftware/SwiftGen/statuses/{sha}","languages_url":"https://api.github.com/repos/AliSoftware/SwiftGen/languages","stargazers_url":"https://api.github.com/repos/AliSoftware/SwiftGen/stargazers","contributors_url":"https://api.github.com/repos/AliSoftware/SwiftGen/contributors","subscribers_url":"https://api.github.com/repos/AliSoftware/SwiftGen/subscribers","subscription_url":"https://api.github.com/repos/AliSoftware/SwiftGen/subscription","commits_url":"https://api.github.com/repos/AliSoftware/SwiftGen/commits{/sha}","git_commits_url":"https://api.github.com/repos/AliSoftware/SwiftGen/git/commits{/sha}","comments_url":"https://api.github.com/repos/AliSoftware/SwiftGen/comments{/number}","issue_comment_url":"https://api.github.com/repos/AliSoftware/SwiftGen/issues/comments{/number}","contents_url":"https://api.github.com/repos/AliSoftware/SwiftGen/contents/{+path}","compare_url":"https://api.github.com/repos/AliSoftware/SwiftGen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AliSoftware/SwiftGen/merges","archive_url":"https://api.github.com/repos/AliSoftware/SwiftGen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AliSoftware/SwiftGen/downloads","issues_url":"https://api.github.com/repos/AliSoftware/SwiftGen/issues{/number}","pulls_url":"https://api.github.com/repos/AliSoftware/SwiftGen/pulls{/number}","milestones_url":"https://api.github.com/repos/AliSoftware/SwiftGen/milestones{/number}","notifications_url":"https://api.github.com/repos/AliSoftware/SwiftGen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AliSoftware/SwiftGen/labels{/name}","releases_url":"https://api.github.com/repos/AliSoftware/SwiftGen/releases{/id}","deployments_url":"https://api.github.com/repos/AliSoftware/SwiftGen/deployments","created_at":"2015-07-15T23:58:44Z","updated_at":"2016-06-05T11:06:57Z","pushed_at":"2016-06-05T15:08:58Z","git_url":"git://github.com/AliSoftware/SwiftGen.git","ssh_url":"git@github.com:AliSoftware/SwiftGen.git","clone_url":"https://github.com/AliSoftware/SwiftGen.git","svn_url":"https://github.com/AliSoftware/SwiftGen","homepage":"","size":3315,"stargazers_count":2006,"watchers_count":2006,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":116,"mirror_url":null,"open_issues_count":22,"forks":116,"open_issues":22,"watchers":2006,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AliSoftware/SwiftGen/pulls/131"},"html":{"href":"https://github.com/AliSoftware/SwiftGen/pull/131"},"issue":{"href":"https://api.github.com/repos/AliSoftware/SwiftGen/issues/131"},"comments":{"href":"https://api.github.com/repos/AliSoftware/SwiftGen/issues/131/comments"},"review_comments":{"href":"https://api.github.com/repos/AliSoftware/SwiftGen/pulls/131/comments"},"review_comment":{"href":"https://api.github.com/repos/AliSoftware/SwiftGen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AliSoftware/SwiftGen/pulls/131/commits"},"statuses":{"href":"https://api.github.com/repos/AliSoftware/SwiftGen/statuses/8765cf664e2b7a58fd37f89fdfbd9d07baa1d3a6"}}}}
{"actor":{"display_login":"AliSoftware"}}