{"action":"closed","issue":{"url":"https://api.github.com/repos/osm2vectortiles/osm2vectortiles/issues/74","repository_url":"https://api.github.com/repos/osm2vectortiles/osm2vectortiles","labels_url":"https://api.github.com/repos/osm2vectortiles/osm2vectortiles/issues/74/labels{/name}","comments_url":"https://api.github.com/repos/osm2vectortiles/osm2vectortiles/issues/74/comments","events_url":"https://api.github.com/repos/osm2vectortiles/osm2vectortiles/issues/74/events","html_url":"https://github.com/osm2vectortiles/osm2vectortiles/issues/74","id":117625711,"number":74,"title":"Ignore Water Tiles: prevent rendering","user":{"login":"klokan","id":59284,"avatar_url":"https://avatars.githubusercontent.com/u/59284?v=3","gravatar_id":"","url":"https://api.github.com/users/klokan","html_url":"https://github.com/klokan","followers_url":"https://api.github.com/users/klokan/followers","following_url":"https://api.github.com/users/klokan/following{/other_user}","gists_url":"https://api.github.com/users/klokan/gists{/gist_id}","starred_url":"https://api.github.com/users/klokan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klokan/subscriptions","organizations_url":"https://api.github.com/users/klokan/orgs","repos_url":"https://api.github.com/users/klokan/repos","events_url":"https://api.github.com/users/klokan/events{/privacy}","received_events_url":"https://api.github.com/users/klokan/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/osm2vectortiles/osm2vectortiles/labels/feature","name":"feature","color":"84b6eb"},{"url":"https://api.github.com/repos/osm2vectortiles/osm2vectortiles/labels/wontfix","name":"wontfix","color":"ffffff"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-11-18T16:33:53Z","updated_at":"2016-05-03T07:37:58Z","closed_at":"2016-05-03T07:37:58Z","body":"In #42 we have discussed several approaches for handling water tiles. The selected dummy approach was the render the water - and in post-processing remove it from the produced MBTiles.\r\n\r\nHere we should track improved process preventing rendering of empty tiles - as discussed in #42:\r\n\r\n> ## Variant 1: Query Data in Worker\r\n> \r\n> One is to do the decision whether to render all tiles of z8 directly in the worker and avoid doing any extra work. In this case we need to query whether the source *would* render data. We need to build a query that is coupled to the source project.\r\n> \r\n> Pros:\r\n> - 24% savings in rendering time\r\n> - No additional component needed\r\n>\r\n> Cons:\r\n> - Prone to errors (query needs to be pretty close to the actual source project query)\r\n> - More complex approach\r\n> - How do we know that we haven't missed something?"}}