{"action":"created","comment":{"url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/pulls/comments/56515098","id":56515098,"diff_hunk":"@@ -79,9 +79,20 @@ define([\n       return _apply(this, dataTable);\n     },\n \n-    transform: function(iteratee){\n+    /**","path":"package-res/resources/web/pentaho/data/_filter/AbstractFilter.js","position":14,"original_position":14,"commit_id":"e2b21b96946e3572566b203b4ebd8158cf750f09","original_commit_id":"e2b21b96946e3572566b203b4ebd8158cf750f09","user":{"login":"dcleao","id":284983,"avatar_url":"https://avatars.githubusercontent.com/u/284983?v=3","gravatar_id":"","url":"https://api.github.com/users/dcleao","html_url":"https://github.com/dcleao","followers_url":"https://api.github.com/users/dcleao/followers","following_url":"https://api.github.com/users/dcleao/following{/other_user}","gists_url":"https://api.github.com/users/dcleao/gists{/gist_id}","starred_url":"https://api.github.com/users/dcleao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcleao/subscriptions","organizations_url":"https://api.github.com/users/dcleao/orgs","repos_url":"https://api.github.com/users/dcleao/repos","events_url":"https://api.github.com/users/dcleao/events{/privacy}","received_events_url":"https://api.github.com/users/dcleao/received_events","type":"User","site_admin":false},"body":"Not sure `walk` is the usual term for a traversal function that rewrites or transforms the tree. I saw this on MSDN: https://msdn.microsoft.com/en-us/library/bb882521(v=vs.90).aspx. Please take a look, even seeing if the iteratee contract is similar to ours, and if any better method exists :-)","created_at":"2016-03-17T14:44:19Z","updated_at":"2016-03-17T14:44:19Z","html_url":"https://github.com/pentaho/pentaho-platform-plugin-common-ui/pull/690#discussion_r56515098","pull_request_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/pulls/690","_links":{"self":{"href":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/pulls/comments/56515098"},"html":{"href":"https://github.com/pentaho/pentaho-platform-plugin-common-ui/pull/690#discussion_r56515098"},"pull_request":{"href":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/pulls/690"}}},"pull_request":{"url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/pulls/690","id":63215058,"html_url":"https://github.com/pentaho/pentaho-platform-plugin-common-ui/pull/690","diff_url":"https://github.com/pentaho/pentaho-platform-plugin-common-ui/pull/690.diff","patch_url":"https://github.com/pentaho/pentaho-platform-plugin-common-ui/pull/690.patch","issue_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/issues/690","number":690,"state":"open","locked":false,"title":"[BACKLOG-5985] Added test and documentation to pentaho.data.filter.Ab…","user":{"login":"carlosrusso","id":4909261,"avatar_url":"https://avatars.githubusercontent.com/u/4909261?v=3","gravatar_id":"","url":"https://api.github.com/users/carlosrusso","html_url":"https://github.com/carlosrusso","followers_url":"https://api.github.com/users/carlosrusso/followers","following_url":"https://api.github.com/users/carlosrusso/following{/other_user}","gists_url":"https://api.github.com/users/carlosrusso/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosrusso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosrusso/subscriptions","organizations_url":"https://api.github.com/users/carlosrusso/orgs","repos_url":"https://api.github.com/users/carlosrusso/repos","events_url":"https://api.github.com/users/carlosrusso/events{/privacy}","received_events_url":"https://api.github.com/users/carlosrusso/received_events","type":"User","site_admin":false},"body":"…stractFilter#walk\r\n\r\n@pentaho/millenniumfalcon Please review.\r\nIt was convenient to add a  `walk` method to the filters in order to transform a given filter tree into another.","created_at":"2016-03-17T12:29:20Z","updated_at":"2016-03-17T14:44:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eff9b821445cdfcb33c8c166568bad5a9b937100","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/pulls/690/commits","review_comments_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/pulls/690/comments","review_comment_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/issues/690/comments","statuses_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/statuses/e2b21b96946e3572566b203b4ebd8158cf750f09","head":{"label":"carlosrusso:feature/BACKLOG-5985","ref":"feature/BACKLOG-5985","sha":"e2b21b96946e3572566b203b4ebd8158cf750f09","user":{"login":"carlosrusso","id":4909261,"avatar_url":"https://avatars.githubusercontent.com/u/4909261?v=3","gravatar_id":"","url":"https://api.github.com/users/carlosrusso","html_url":"https://github.com/carlosrusso","followers_url":"https://api.github.com/users/carlosrusso/followers","following_url":"https://api.github.com/users/carlosrusso/following{/other_user}","gists_url":"https://api.github.com/users/carlosrusso/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosrusso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosrusso/subscriptions","organizations_url":"https://api.github.com/users/carlosrusso/orgs","repos_url":"https://api.github.com/users/carlosrusso/repos","events_url":"https://api.github.com/users/carlosrusso/events{/privacy}","received_events_url":"https://api.github.com/users/carlosrusso/received_events","type":"User","site_admin":false},"repo":{"id":49566600,"name":"pentaho-platform-plugin-common-ui","full_name":"carlosrusso/pentaho-platform-plugin-common-ui","owner":{"login":"carlosrusso","id":4909261,"avatar_url":"https://avatars.githubusercontent.com/u/4909261?v=3","gravatar_id":"","url":"https://api.github.com/users/carlosrusso","html_url":"https://github.com/carlosrusso","followers_url":"https://api.github.com/users/carlosrusso/followers","following_url":"https://api.github.com/users/carlosrusso/following{/other_user}","gists_url":"https://api.github.com/users/carlosrusso/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosrusso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosrusso/subscriptions","organizations_url":"https://api.github.com/users/carlosrusso/orgs","repos_url":"https://api.github.com/users/carlosrusso/repos","events_url":"https://api.github.com/users/carlosrusso/events{/privacy}","received_events_url":"https://api.github.com/users/carlosrusso/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/carlosrusso/pentaho-platform-plugin-common-ui","description":"","fork":true,"url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui","forks_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/forks","keys_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/teams","hooks_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/hooks","issue_events_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/issues/events{/number}","events_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/events","assignees_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/assignees{/user}","branches_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/branches{/branch}","tags_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/tags","blobs_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/languages","stargazers_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/stargazers","contributors_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/contributors","subscribers_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/subscribers","subscription_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/subscription","commits_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/contents/{+path}","compare_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/merges","archive_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/downloads","issues_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/issues{/number}","pulls_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/labels{/name}","releases_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/releases{/id}","deployments_url":"https://api.github.com/repos/carlosrusso/pentaho-platform-plugin-common-ui/deployments","created_at":"2016-01-13T10:23:09Z","updated_at":"2016-01-13T10:23:12Z","pushed_at":"2016-03-17T12:27:23Z","git_url":"git://github.com/carlosrusso/pentaho-platform-plugin-common-ui.git","ssh_url":"git@github.com:carlosrusso/pentaho-platform-plugin-common-ui.git","clone_url":"https://github.com/carlosrusso/pentaho-platform-plugin-common-ui.git","svn_url":"https://github.com/carlosrusso/pentaho-platform-plugin-common-ui","homepage":null,"size":15260,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pentaho:master","ref":"master","sha":"6cd8d1c1f46be47e668318ee1b95012b9a83c4ae","user":{"login":"pentaho","id":1022787,"avatar_url":"https://avatars.githubusercontent.com/u/1022787?v=3","gravatar_id":"","url":"https://api.github.com/users/pentaho","html_url":"https://github.com/pentaho","followers_url":"https://api.github.com/users/pentaho/followers","following_url":"https://api.github.com/users/pentaho/following{/other_user}","gists_url":"https://api.github.com/users/pentaho/gists{/gist_id}","starred_url":"https://api.github.com/users/pentaho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pentaho/subscriptions","organizations_url":"https://api.github.com/users/pentaho/orgs","repos_url":"https://api.github.com/users/pentaho/repos","events_url":"https://api.github.com/users/pentaho/events{/privacy}","received_events_url":"https://api.github.com/users/pentaho/received_events","type":"Organization","site_admin":false},"repo":{"id":4597815,"name":"pentaho-platform-plugin-common-ui","full_name":"pentaho/pentaho-platform-plugin-common-ui","owner":{"login":"pentaho","id":1022787,"avatar_url":"https://avatars.githubusercontent.com/u/1022787?v=3","gravatar_id":"","url":"https://api.github.com/users/pentaho","html_url":"https://github.com/pentaho","followers_url":"https://api.github.com/users/pentaho/followers","following_url":"https://api.github.com/users/pentaho/following{/other_user}","gists_url":"https://api.github.com/users/pentaho/gists{/gist_id}","starred_url":"https://api.github.com/users/pentaho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pentaho/subscriptions","organizations_url":"https://api.github.com/users/pentaho/orgs","repos_url":"https://api.github.com/users/pentaho/repos","events_url":"https://api.github.com/users/pentaho/events{/privacy}","received_events_url":"https://api.github.com/users/pentaho/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pentaho/pentaho-platform-plugin-common-ui","description":"","fork":false,"url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui","forks_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/forks","keys_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/teams","hooks_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/hooks","issue_events_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/issues/events{/number}","events_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/events","assignees_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/assignees{/user}","branches_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/branches{/branch}","tags_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/tags","blobs_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/languages","stargazers_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/stargazers","contributors_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/contributors","subscribers_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/subscribers","subscription_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/subscription","commits_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/contents/{+path}","compare_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/merges","archive_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/downloads","issues_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/issues{/number}","pulls_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/labels{/name}","releases_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/releases{/id}","deployments_url":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/deployments","created_at":"2012-06-08T13:53:13Z","updated_at":"2016-01-12T14:57:20Z","pushed_at":"2016-03-17T12:29:20Z","git_url":"git://github.com/pentaho/pentaho-platform-plugin-common-ui.git","ssh_url":"git@github.com:pentaho/pentaho-platform-plugin-common-ui.git","clone_url":"https://github.com/pentaho/pentaho-platform-plugin-common-ui.git","svn_url":"https://github.com/pentaho/pentaho-platform-plugin-common-ui","homepage":null,"size":15659,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":3,"forks":70,"open_issues":3,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/pulls/690"},"html":{"href":"https://github.com/pentaho/pentaho-platform-plugin-common-ui/pull/690"},"issue":{"href":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/issues/690"},"comments":{"href":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/issues/690/comments"},"review_comments":{"href":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/pulls/690/comments"},"review_comment":{"href":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/pulls/690/commits"},"statuses":{"href":"https://api.github.com/repos/pentaho/pentaho-platform-plugin-common-ui/statuses/e2b21b96946e3572566b203b4ebd8158cf750f09"}}}}