{"action":"created","issue":{"url":"https://api.github.com/repos/swagger-api/swagger-codegen/issues/3487","repository_url":"https://api.github.com/repos/swagger-api/swagger-codegen","labels_url":"https://api.github.com/repos/swagger-api/swagger-codegen/issues/3487/labels{/name}","comments_url":"https://api.github.com/repos/swagger-api/swagger-codegen/issues/3487/comments","events_url":"https://api.github.com/repos/swagger-api/swagger-codegen/issues/3487/events","html_url":"https://github.com/swagger-api/swagger-codegen/pull/3487","id":168497507,"number":3487,"title":"fixing bug of rendering an extra spaces into @FeignClient annotation","user":{"login":"szantopeter","id":69414,"avatar_url":"https://avatars.githubusercontent.com/u/69414?v=3","gravatar_id":"","url":"https://api.github.com/users/szantopeter","html_url":"https://github.com/szantopeter","followers_url":"https://api.github.com/users/szantopeter/followers","following_url":"https://api.github.com/users/szantopeter/following{/other_user}","gists_url":"https://api.github.com/users/szantopeter/gists{/gist_id}","starred_url":"https://api.github.com/users/szantopeter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szantopeter/subscriptions","organizations_url":"https://api.github.com/users/szantopeter/orgs","repos_url":"https://api.github.com/users/szantopeter/repos","events_url":"https://api.github.com/users/szantopeter/events{/privacy}","received_events_url":"https://api.github.com/users/szantopeter/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/swagger-api/swagger-codegen/labels/Client:%20Java","name":"Client: Java","color":"fad8c7"},{"url":"https://api.github.com/repos/swagger-api/swagger-codegen/labels/Issue:%20Bug","name":"Issue: Bug","color":"e11d21"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/swagger-api/swagger-codegen/milestones/11","html_url":"https://github.com/swagger-api/swagger-codegen/milestones/v2.2.1","labels_url":"https://api.github.com/repos/swagger-api/swagger-codegen/milestones/11/labels","id":1794308,"number":11,"title":"v2.2.1","description":"","creator":{"login":"wing328","id":934260,"avatar_url":"https://avatars.githubusercontent.com/u/934260?v=3","gravatar_id":"","url":"https://api.github.com/users/wing328","html_url":"https://github.com/wing328","followers_url":"https://api.github.com/users/wing328/followers","following_url":"https://api.github.com/users/wing328/following{/other_user}","gists_url":"https://api.github.com/users/wing328/gists{/gist_id}","starred_url":"https://api.github.com/users/wing328/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wing328/subscriptions","organizations_url":"https://api.github.com/users/wing328/orgs","repos_url":"https://api.github.com/users/wing328/repos","events_url":"https://api.github.com/users/wing328/events{/privacy}","received_events_url":"https://api.github.com/users/wing328/received_events","type":"User","site_admin":false},"open_issues":216,"closed_issues":84,"state":"open","created_at":"2016-05-29T08:58:06Z","updated_at":"2016-08-01T14:58:19Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2016-07-31T02:19:46Z","updated_at":"2016-08-01T15:12:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/swagger-api/swagger-codegen/pulls/3487","html_url":"https://github.com/swagger-api/swagger-codegen/pull/3487","diff_url":"https://github.com/swagger-api/swagger-codegen/pull/3487.diff","patch_url":"https://github.com/swagger-api/swagger-codegen/pull/3487.patch"},"body":"FeignClient annotations are redered incorrectly with an extra space. This causes a problem that spring properties are not loaded. E.g: the below annotation was generated\r\n\r\n```@FeignClient(name=\"${ swaggerPetstoreSimple.name:swaggerPetstoreSimple}\", url=\"${ swaggerPetstoreSimple.url:https://localhost:8080/api}\", configuration = ClientConfiguration.class)```\r\n\r\nand overwriting \r\n\r\nswaggerPetstoreSimple.name:swaggerPetstoreSimple\r\n\r\nwas not possible because of the extra spaces."},"comment":{"url":"https://api.github.com/repos/swagger-api/swagger-codegen/issues/comments/236609983","html_url":"https://github.com/swagger-api/swagger-codegen/pull/3487#issuecomment-236609983","issue_url":"https://api.github.com/repos/swagger-api/swagger-codegen/issues/3487","id":236609983,"user":{"login":"wing328","id":934260,"avatar_url":"https://avatars.githubusercontent.com/u/934260?v=3","gravatar_id":"","url":"https://api.github.com/users/wing328","html_url":"https://github.com/wing328","followers_url":"https://api.github.com/users/wing328/followers","following_url":"https://api.github.com/users/wing328/following{/other_user}","gists_url":"https://api.github.com/users/wing328/gists{/gist_id}","starred_url":"https://api.github.com/users/wing328/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wing328/subscriptions","organizations_url":"https://api.github.com/users/wing328/orgs","repos_url":"https://api.github.com/users/wing328/repos","events_url":"https://api.github.com/users/wing328/events{/privacy}","received_events_url":"https://api.github.com/users/wing328/received_events","type":"User","site_admin":false},"created_at":"2016-08-01T15:12:23Z","updated_at":"2016-08-01T15:12:23Z","body":"@szantopeter thanks for the feedback. We've documented Petstore sample update procedure here: https://github.com/swagger-api/swagger-codegen/blob/master/CONTRIBUTING.md#testing but seems like not many people notice it.\r\n\r\nWe'll probably create a PR template to draw people's attention about updating Petstore sample so that CIs can verify the change."}}
{"actor":{"display_login":"wing328"}}