{"action":"created","issue":{"url":"https://api.github.com/repos/OrN/rscplus/issues/11","repository_url":"https://api.github.com/repos/OrN/rscplus","labels_url":"https://api.github.com/repos/OrN/rscplus/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/OrN/rscplus/issues/11/comments","events_url":"https://api.github.com/repos/OrN/rscplus/issues/11/events","html_url":"https://github.com/OrN/rscplus/pull/11","id":144485590,"number":11,"title":"Comprehensive item name patch","user":{"login":"thelegendofbrian","id":2666891,"avatar_url":"https://avatars.githubusercontent.com/u/2666891?v=3","gravatar_id":"","url":"https://api.github.com/users/thelegendofbrian","html_url":"https://github.com/thelegendofbrian","followers_url":"https://api.github.com/users/thelegendofbrian/followers","following_url":"https://api.github.com/users/thelegendofbrian/following{/other_user}","gists_url":"https://api.github.com/users/thelegendofbrian/gists{/gist_id}","starred_url":"https://api.github.com/users/thelegendofbrian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thelegendofbrian/subscriptions","organizations_url":"https://api.github.com/users/thelegendofbrian/orgs","repos_url":"https://api.github.com/users/thelegendofbrian/repos","events_url":"https://api.github.com/users/thelegendofbrian/events{/privacy}","received_events_url":"https://api.github.com/users/thelegendofbrian/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-30T07:22:28Z","updated_at":"2016-03-31T06:02:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OrN/rscplus/pulls/11","html_url":"https://github.com/OrN/rscplus/pull/11","diff_url":"https://github.com/OrN/rscplus/pull/11.diff","patch_url":"https://github.com/OrN/rscplus/pull/11.patch"},"body":"- Manually went through every item name and made fixes and improvements\r\n- Depending on the user's preferences, the amount that the names deviate from the original item names can be controlled using the **name_patch_type** config, with the default being **3**:\r\n\r\n  0 No item name patching\r\n  1 Purely practical name changes (potion dosages, unidentified herbs, unfinished potions)\r\n  2 Capitalizations and fixed spellings on top of type 1 changes\r\n  3 Reworded vague stuff to be more descriptive on top of type 1 & 2 changes\r\n\r\n- Previously, if a user did not want any item name patching, it wasn't possible. Now it is.\r\n- The SQLite database can be used in the future to patch item examine text or to show item info overlays on dropped items only for selected items instead of everything.\r\n- Added documentation for all of the config.ini options\r\n- I ran into a problem with the build file where it copied the MANIFEST.MF from sqlite-jdbc-3.8.11.2.jar and copied it into the rscplus.jar file next to the manifest file. This caused it to read the incorrect manifest and was unable to find the main class. I don't know the purpose of the tmp file you had ANT make, so I simplified it in a way I understood and resolved the problem I was having, so you might pay extra attention to the build.xml in case I took away something you wanted.\r\n\r\n## name_patch_type examples\r\n\r\n### name_patch_type = 1\r\n![image](https://cloud.githubusercontent.com/assets/2666891/14134547/df04a7bc-f60c-11e5-9517-263e4e12ba00.png)\r\n\r\n### name_patch_type = 2\r\n![image](https://cloud.githubusercontent.com/assets/2666891/14134585/413c2900-f60d-11e5-9dec-9f27099ff9e1.png)\r\n\r\n### name_patch_type = 3\r\n![image](https://cloud.githubusercontent.com/assets/2666891/14134605/57e65428-f60d-11e5-81ad-8da3c6e11392.png)"},"comment":{"url":"https://api.github.com/repos/OrN/rscplus/issues/comments/203769302","html_url":"https://github.com/OrN/rscplus/pull/11#issuecomment-203769302","issue_url":"https://api.github.com/repos/OrN/rscplus/issues/11","id":203769302,"user":{"login":"thelegendofbrian","id":2666891,"avatar_url":"https://avatars.githubusercontent.com/u/2666891?v=3","gravatar_id":"","url":"https://api.github.com/users/thelegendofbrian","html_url":"https://github.com/thelegendofbrian","followers_url":"https://api.github.com/users/thelegendofbrian/followers","following_url":"https://api.github.com/users/thelegendofbrian/following{/other_user}","gists_url":"https://api.github.com/users/thelegendofbrian/gists{/gist_id}","starred_url":"https://api.github.com/users/thelegendofbrian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thelegendofbrian/subscriptions","organizations_url":"https://api.github.com/users/thelegendofbrian/orgs","repos_url":"https://api.github.com/users/thelegendofbrian/repos","events_url":"https://api.github.com/users/thelegendofbrian/events{/privacy}","received_events_url":"https://api.github.com/users/thelegendofbrian/received_events","type":"User","site_admin":false},"created_at":"2016-03-31T06:02:10Z","updated_at":"2016-03-31T06:02:10Z","body":"Ah alright, I've tested it quite a bit over the last few days and it seems to work well on all config settings. It should be ready to merge now."}}