{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker-py/pulls/comments/49752717","id":49752717,"diff_hunk":"@@ -715,6 +715,27 @@ def create_host_config(binds=None, port_bindings=None, lxc_conf=None,\n     return host_config\n \n \n+def create_networking_config(endpoints_config=None):\n+    networking_config = {}\n+\n+    if endpoints_config:\n+        networking_config[\"EndpointsConfig\"] = endpoints_config\n+\n+    return networking_config\n+\n+\n+def create_endpoint_config(version,\n+                           aliases=None):\n+    endpoint_config = {}\n+\n+    if aliases:\n+        if version_lt(version, '1.22'):\n+            raise host_config_version_error('aliases', '1.22')","path":"docker/utils/utils.py","position":19,"original_position":19,"commit_id":"3c789aded020e4f19f0c1cd2097897a874712f82","original_commit_id":"3c789aded020e4f19f0c1cd2097897a874712f82","user":{"login":"aanand","id":1062,"avatar_url":"https://avatars.githubusercontent.com/u/1062?v=3","gravatar_id":"","url":"https://api.github.com/users/aanand","html_url":"https://github.com/aanand","followers_url":"https://api.github.com/users/aanand/followers","following_url":"https://api.github.com/users/aanand/following{/other_user}","gists_url":"https://api.github.com/users/aanand/gists{/gist_id}","starred_url":"https://api.github.com/users/aanand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aanand/subscriptions","organizations_url":"https://api.github.com/users/aanand/orgs","repos_url":"https://api.github.com/users/aanand/repos","events_url":"https://api.github.com/users/aanand/events{/privacy}","received_events_url":"https://api.github.com/users/aanand/received_events","type":"User","site_admin":false},"body":"Yeah. Perhaps just `endpoint_config.aliases`, since the user will have explicitly called `create_endpoint_config`. I'll update it.","created_at":"2016-01-14T17:02:09Z","updated_at":"2016-01-14T17:02:09Z","html_url":"https://github.com/docker/docker-py/pull/895#discussion_r49752717","pull_request_url":"https://api.github.com/repos/docker/docker-py/pulls/895","_links":{"self":{"href":"https://api.github.com/repos/docker/docker-py/pulls/comments/49752717"},"html":{"href":"https://github.com/docker/docker-py/pull/895#discussion_r49752717"},"pull_request":{"href":"https://api.github.com/repos/docker/docker-py/pulls/895"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker-py/pulls/895","id":56059129,"html_url":"https://github.com/docker/docker-py/pull/895","diff_url":"https://github.com/docker/docker-py/pull/895.diff","patch_url":"https://github.com/docker/docker-py/pull/895.patch","issue_url":"https://api.github.com/repos/docker/docker-py/issues/895","number":895,"state":"open","locked":false,"title":"Implement support for network-scoped aliases","user":{"login":"aanand","id":1062,"avatar_url":"https://avatars.githubusercontent.com/u/1062?v=3","gravatar_id":"","url":"https://api.github.com/users/aanand","html_url":"https://github.com/aanand","followers_url":"https://api.github.com/users/aanand/followers","following_url":"https://api.github.com/users/aanand/following{/other_user}","gists_url":"https://api.github.com/users/aanand/gists{/gist_id}","starred_url":"https://api.github.com/users/aanand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aanand/subscriptions","organizations_url":"https://api.github.com/users/aanand/orgs","repos_url":"https://api.github.com/users/aanand/repos","events_url":"https://api.github.com/users/aanand/events{/privacy}","received_events_url":"https://api.github.com/users/aanand/received_events","type":"User","site_admin":false},"body":"Missing docs, but network docs are already lacking. Will fill them out in a follow-up PR.","created_at":"2016-01-14T16:34:39Z","updated_at":"2016-01-14T17:02:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5fcbec52113ad4fb62008948a4d672548ba342a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker-py/pulls/895/commits","review_comments_url":"https://api.github.com/repos/docker/docker-py/pulls/895/comments","review_comment_url":"https://api.github.com/repos/docker/docker-py/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker-py/issues/895/comments","statuses_url":"https://api.github.com/repos/docker/docker-py/statuses/3c789aded020e4f19f0c1cd2097897a874712f82","head":{"label":"aanand:alias","ref":"alias","sha":"3c789aded020e4f19f0c1cd2097897a874712f82","user":{"login":"aanand","id":1062,"avatar_url":"https://avatars.githubusercontent.com/u/1062?v=3","gravatar_id":"","url":"https://api.github.com/users/aanand","html_url":"https://github.com/aanand","followers_url":"https://api.github.com/users/aanand/followers","following_url":"https://api.github.com/users/aanand/following{/other_user}","gists_url":"https://api.github.com/users/aanand/gists{/gist_id}","starred_url":"https://api.github.com/users/aanand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aanand/subscriptions","organizations_url":"https://api.github.com/users/aanand/orgs","repos_url":"https://api.github.com/users/aanand/repos","events_url":"https://api.github.com/users/aanand/events{/privacy}","received_events_url":"https://api.github.com/users/aanand/received_events","type":"User","site_admin":false},"repo":{"id":12514557,"name":"docker-py","full_name":"aanand/docker-py","owner":{"login":"aanand","id":1062,"avatar_url":"https://avatars.githubusercontent.com/u/1062?v=3","gravatar_id":"","url":"https://api.github.com/users/aanand","html_url":"https://github.com/aanand","followers_url":"https://api.github.com/users/aanand/followers","following_url":"https://api.github.com/users/aanand/following{/other_user}","gists_url":"https://api.github.com/users/aanand/gists{/gist_id}","starred_url":"https://api.github.com/users/aanand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aanand/subscriptions","organizations_url":"https://api.github.com/users/aanand/orgs","repos_url":"https://api.github.com/users/aanand/repos","events_url":"https://api.github.com/users/aanand/events{/privacy}","received_events_url":"https://api.github.com/users/aanand/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aanand/docker-py","description":"","fork":true,"url":"https://api.github.com/repos/aanand/docker-py","forks_url":"https://api.github.com/repos/aanand/docker-py/forks","keys_url":"https://api.github.com/repos/aanand/docker-py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aanand/docker-py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aanand/docker-py/teams","hooks_url":"https://api.github.com/repos/aanand/docker-py/hooks","issue_events_url":"https://api.github.com/repos/aanand/docker-py/issues/events{/number}","events_url":"https://api.github.com/repos/aanand/docker-py/events","assignees_url":"https://api.github.com/repos/aanand/docker-py/assignees{/user}","branches_url":"https://api.github.com/repos/aanand/docker-py/branches{/branch}","tags_url":"https://api.github.com/repos/aanand/docker-py/tags","blobs_url":"https://api.github.com/repos/aanand/docker-py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aanand/docker-py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aanand/docker-py/git/refs{/sha}","trees_url":"https://api.github.com/repos/aanand/docker-py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aanand/docker-py/statuses/{sha}","languages_url":"https://api.github.com/repos/aanand/docker-py/languages","stargazers_url":"https://api.github.com/repos/aanand/docker-py/stargazers","contributors_url":"https://api.github.com/repos/aanand/docker-py/contributors","subscribers_url":"https://api.github.com/repos/aanand/docker-py/subscribers","subscription_url":"https://api.github.com/repos/aanand/docker-py/subscription","commits_url":"https://api.github.com/repos/aanand/docker-py/commits{/sha}","git_commits_url":"https://api.github.com/repos/aanand/docker-py/git/commits{/sha}","comments_url":"https://api.github.com/repos/aanand/docker-py/comments{/number}","issue_comment_url":"https://api.github.com/repos/aanand/docker-py/issues/comments{/number}","contents_url":"https://api.github.com/repos/aanand/docker-py/contents/{+path}","compare_url":"https://api.github.com/repos/aanand/docker-py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aanand/docker-py/merges","archive_url":"https://api.github.com/repos/aanand/docker-py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aanand/docker-py/downloads","issues_url":"https://api.github.com/repos/aanand/docker-py/issues{/number}","pulls_url":"https://api.github.com/repos/aanand/docker-py/pulls{/number}","milestones_url":"https://api.github.com/repos/aanand/docker-py/milestones{/number}","notifications_url":"https://api.github.com/repos/aanand/docker-py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aanand/docker-py/labels{/name}","releases_url":"https://api.github.com/repos/aanand/docker-py/releases{/id}","created_at":"2013-09-01T02:24:12Z","updated_at":"2014-07-24T20:52:08Z","pushed_at":"2016-01-14T16:33:32Z","git_url":"git://github.com/aanand/docker-py.git","ssh_url":"git@github.com:aanand/docker-py.git","clone_url":"https://github.com/aanand/docker-py.git","svn_url":"https://github.com/aanand/docker-py","homepage":null,"size":2086,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"e2878cbcc3a7eef99917adc1be252800b0e41ece","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":10247874,"name":"docker-py","full_name":"docker/docker-py","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker-py","description":"An API client for docker written in Python","fork":false,"url":"https://api.github.com/repos/docker/docker-py","forks_url":"https://api.github.com/repos/docker/docker-py/forks","keys_url":"https://api.github.com/repos/docker/docker-py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker-py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker-py/teams","hooks_url":"https://api.github.com/repos/docker/docker-py/hooks","issue_events_url":"https://api.github.com/repos/docker/docker-py/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker-py/events","assignees_url":"https://api.github.com/repos/docker/docker-py/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker-py/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker-py/tags","blobs_url":"https://api.github.com/repos/docker/docker-py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker-py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker-py/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker-py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker-py/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker-py/languages","stargazers_url":"https://api.github.com/repos/docker/docker-py/stargazers","contributors_url":"https://api.github.com/repos/docker/docker-py/contributors","subscribers_url":"https://api.github.com/repos/docker/docker-py/subscribers","subscription_url":"https://api.github.com/repos/docker/docker-py/subscription","commits_url":"https://api.github.com/repos/docker/docker-py/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker-py/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker-py/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker-py/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker-py/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker-py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker-py/merges","archive_url":"https://api.github.com/repos/docker/docker-py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker-py/downloads","issues_url":"https://api.github.com/repos/docker/docker-py/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker-py/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker-py/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker-py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker-py/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker-py/releases{/id}","created_at":"2013-05-23T16:15:07Z","updated_at":"2016-01-13T09:37:05Z","pushed_at":"2016-01-14T16:34:40Z","git_url":"git://github.com/docker/docker-py.git","ssh_url":"git@github.com:docker/docker-py.git","clone_url":"https://github.com/docker/docker-py.git","svn_url":"https://github.com/docker/docker-py","homepage":"","size":3528,"stargazers_count":1244,"watchers_count":1244,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":471,"mirror_url":null,"open_issues_count":66,"forks":471,"open_issues":66,"watchers":1244,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker-py/pulls/895"},"html":{"href":"https://github.com/docker/docker-py/pull/895"},"issue":{"href":"https://api.github.com/repos/docker/docker-py/issues/895"},"comments":{"href":"https://api.github.com/repos/docker/docker-py/issues/895/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker-py/pulls/895/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker-py/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker-py/pulls/895/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker-py/statuses/3c789aded020e4f19f0c1cd2097897a874712f82"}}}}