{"action":"opened","number":137,"pull_request":{"url":"https://api.github.com/repos/gflags/gflags/pulls/137","id":60964195,"html_url":"https://github.com/gflags/gflags/pull/137","diff_url":"https://github.com/gflags/gflags/pull/137.diff","patch_url":"https://github.com/gflags/gflags/pull/137.patch","issue_url":"https://api.github.com/repos/gflags/gflags/issues/137","number":137,"state":"open","locked":false,"title":"properly export the .so minor version","user":{"login":"eklitzke","id":2734,"avatar_url":"https://avatars.githubusercontent.com/u/2734?v=3","gravatar_id":"","url":"https://api.github.com/users/eklitzke","html_url":"https://github.com/eklitzke","followers_url":"https://api.github.com/users/eklitzke/followers","following_url":"https://api.github.com/users/eklitzke/following{/other_user}","gists_url":"https://api.github.com/users/eklitzke/gists{/gist_id}","starred_url":"https://api.github.com/users/eklitzke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eklitzke/subscriptions","organizations_url":"https://api.github.com/users/eklitzke/orgs","repos_url":"https://api.github.com/users/eklitzke/repos","events_url":"https://api.github.com/users/eklitzke/events{/privacy}","received_events_url":"https://api.github.com/users/eklitzke/received_events","type":"User","site_admin":false},"body":"This patch has two consequences:\r\n * previously in lib there would be a file like `libgflags.so.2.2.0` and a symlink named `libgflags.so.2` and `libgflags.so`\r\n * previously the `SONAME` in the ELF files would be `libgflags.so.2`\r\n\r\nThis change updates the `SONAME` to `libflags.so.2.2` and adds an extra symlink `libgflags.so.2.2`.\r\n\r\nNote that this change is already being done upstream by the Fedora packagers.\r\n\r\n**Without This Patch**\r\n\r\n```\r\n$ ls lib/\r\nlibgflags_nothreads.so  libgflags_nothreads.so.2  libgflags_nothreads.so.2.2.0  libgflags.so  libgflags.so.2  libgflags.so.2.2.0\r\n\r\n$ find lib -type f -exec readelf -d {} \\; | grep SONAME\r\n 0x000000000000000e (SONAME)             Library soname: [libgflags.so.2]\r\n 0x000000000000000e (SONAME)             Library soname: [libgflags_nothreads.so.2]\r\n```\r\n \r\n**With This Patch**\r\n \r\n```\r\n$ ls lib/\r\nlibgflags_nothreads.so  libgflags_nothreads.so.2.2  libgflags_nothreads.so.2.2.0  libgflags.so  libgflags.so.2.2  libgflags.so.2.2.0\r\n\r\n$ find lib -type f -exec readelf -d {} \\; | grep SONAME\r\n 0x000000000000000e (SONAME)             Library soname: [libgflags.so.2.2]\r\n 0x000000000000000e (SONAME)             Library soname: [libgflags_nothreads.so.2.2]\r\n```","created_at":"2016-02-27T20:42:32Z","updated_at":"2016-02-27T20:42:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gflags/gflags/pulls/137/commits","review_comments_url":"https://api.github.com/repos/gflags/gflags/pulls/137/comments","review_comment_url":"https://api.github.com/repos/gflags/gflags/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gflags/gflags/issues/137/comments","statuses_url":"https://api.github.com/repos/gflags/gflags/statuses/b90a325ef355ad2ad45c46c7fc73fc3e28d3a33d","head":{"label":"eklitzke:master","ref":"master","sha":"b90a325ef355ad2ad45c46c7fc73fc3e28d3a33d","user":{"login":"eklitzke","id":2734,"avatar_url":"https://avatars.githubusercontent.com/u/2734?v=3","gravatar_id":"","url":"https://api.github.com/users/eklitzke","html_url":"https://github.com/eklitzke","followers_url":"https://api.github.com/users/eklitzke/followers","following_url":"https://api.github.com/users/eklitzke/following{/other_user}","gists_url":"https://api.github.com/users/eklitzke/gists{/gist_id}","starred_url":"https://api.github.com/users/eklitzke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eklitzke/subscriptions","organizations_url":"https://api.github.com/users/eklitzke/orgs","repos_url":"https://api.github.com/users/eklitzke/repos","events_url":"https://api.github.com/users/eklitzke/events{/privacy}","received_events_url":"https://api.github.com/users/eklitzke/received_events","type":"User","site_admin":false},"repo":{"id":52687362,"name":"gflags","full_name":"eklitzke/gflags","owner":{"login":"eklitzke","id":2734,"avatar_url":"https://avatars.githubusercontent.com/u/2734?v=3","gravatar_id":"","url":"https://api.github.com/users/eklitzke","html_url":"https://github.com/eklitzke","followers_url":"https://api.github.com/users/eklitzke/followers","following_url":"https://api.github.com/users/eklitzke/following{/other_user}","gists_url":"https://api.github.com/users/eklitzke/gists{/gist_id}","starred_url":"https://api.github.com/users/eklitzke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eklitzke/subscriptions","organizations_url":"https://api.github.com/users/eklitzke/orgs","repos_url":"https://api.github.com/users/eklitzke/repos","events_url":"https://api.github.com/users/eklitzke/events{/privacy}","received_events_url":"https://api.github.com/users/eklitzke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eklitzke/gflags","description":"The gflags package contains a C++ library that implements commandline flags processing. It includes built-in support for standard types such as string and the ability to define flags in the source file in which they are used. Online documentation available at:","fork":true,"url":"https://api.github.com/repos/eklitzke/gflags","forks_url":"https://api.github.com/repos/eklitzke/gflags/forks","keys_url":"https://api.github.com/repos/eklitzke/gflags/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eklitzke/gflags/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eklitzke/gflags/teams","hooks_url":"https://api.github.com/repos/eklitzke/gflags/hooks","issue_events_url":"https://api.github.com/repos/eklitzke/gflags/issues/events{/number}","events_url":"https://api.github.com/repos/eklitzke/gflags/events","assignees_url":"https://api.github.com/repos/eklitzke/gflags/assignees{/user}","branches_url":"https://api.github.com/repos/eklitzke/gflags/branches{/branch}","tags_url":"https://api.github.com/repos/eklitzke/gflags/tags","blobs_url":"https://api.github.com/repos/eklitzke/gflags/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eklitzke/gflags/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eklitzke/gflags/git/refs{/sha}","trees_url":"https://api.github.com/repos/eklitzke/gflags/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eklitzke/gflags/statuses/{sha}","languages_url":"https://api.github.com/repos/eklitzke/gflags/languages","stargazers_url":"https://api.github.com/repos/eklitzke/gflags/stargazers","contributors_url":"https://api.github.com/repos/eklitzke/gflags/contributors","subscribers_url":"https://api.github.com/repos/eklitzke/gflags/subscribers","subscription_url":"https://api.github.com/repos/eklitzke/gflags/subscription","commits_url":"https://api.github.com/repos/eklitzke/gflags/commits{/sha}","git_commits_url":"https://api.github.com/repos/eklitzke/gflags/git/commits{/sha}","comments_url":"https://api.github.com/repos/eklitzke/gflags/comments{/number}","issue_comment_url":"https://api.github.com/repos/eklitzke/gflags/issues/comments{/number}","contents_url":"https://api.github.com/repos/eklitzke/gflags/contents/{+path}","compare_url":"https://api.github.com/repos/eklitzke/gflags/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eklitzke/gflags/merges","archive_url":"https://api.github.com/repos/eklitzke/gflags/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eklitzke/gflags/downloads","issues_url":"https://api.github.com/repos/eklitzke/gflags/issues{/number}","pulls_url":"https://api.github.com/repos/eklitzke/gflags/pulls{/number}","milestones_url":"https://api.github.com/repos/eklitzke/gflags/milestones{/number}","notifications_url":"https://api.github.com/repos/eklitzke/gflags/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eklitzke/gflags/labels{/name}","releases_url":"https://api.github.com/repos/eklitzke/gflags/releases{/id}","deployments_url":"https://api.github.com/repos/eklitzke/gflags/deployments","created_at":"2016-02-27T20:31:39Z","updated_at":"2016-02-27T20:31:40Z","pushed_at":"2016-02-27T20:36:19Z","git_url":"git://github.com/eklitzke/gflags.git","ssh_url":"git@github.com:eklitzke/gflags.git","clone_url":"https://github.com/eklitzke/gflags.git","svn_url":"https://github.com/eklitzke/gflags","homepage":"https://gflags.github.io/gflags/","size":1327,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gflags:master","ref":"master","sha":"3ae911f3e7eb2ed3f34017355dc5d829f411962b","user":{"login":"gflags","id":11634238,"avatar_url":"https://avatars.githubusercontent.com/u/11634238?v=3","gravatar_id":"","url":"https://api.github.com/users/gflags","html_url":"https://github.com/gflags","followers_url":"https://api.github.com/users/gflags/followers","following_url":"https://api.github.com/users/gflags/following{/other_user}","gists_url":"https://api.github.com/users/gflags/gists{/gist_id}","starred_url":"https://api.github.com/users/gflags/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gflags/subscriptions","organizations_url":"https://api.github.com/users/gflags/orgs","repos_url":"https://api.github.com/users/gflags/repos","events_url":"https://api.github.com/users/gflags/events{/privacy}","received_events_url":"https://api.github.com/users/gflags/received_events","type":"Organization","site_admin":false},"repo":{"id":9571473,"name":"gflags","full_name":"gflags/gflags","owner":{"login":"gflags","id":11634238,"avatar_url":"https://avatars.githubusercontent.com/u/11634238?v=3","gravatar_id":"","url":"https://api.github.com/users/gflags","html_url":"https://github.com/gflags","followers_url":"https://api.github.com/users/gflags/followers","following_url":"https://api.github.com/users/gflags/following{/other_user}","gists_url":"https://api.github.com/users/gflags/gists{/gist_id}","starred_url":"https://api.github.com/users/gflags/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gflags/subscriptions","organizations_url":"https://api.github.com/users/gflags/orgs","repos_url":"https://api.github.com/users/gflags/repos","events_url":"https://api.github.com/users/gflags/events{/privacy}","received_events_url":"https://api.github.com/users/gflags/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gflags/gflags","description":"The gflags package contains a C++ library that implements commandline flags processing. It includes built-in support for standard types such as string and the ability to define flags in the source file in which they are used. Online documentation available at:","fork":false,"url":"https://api.github.com/repos/gflags/gflags","forks_url":"https://api.github.com/repos/gflags/gflags/forks","keys_url":"https://api.github.com/repos/gflags/gflags/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gflags/gflags/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gflags/gflags/teams","hooks_url":"https://api.github.com/repos/gflags/gflags/hooks","issue_events_url":"https://api.github.com/repos/gflags/gflags/issues/events{/number}","events_url":"https://api.github.com/repos/gflags/gflags/events","assignees_url":"https://api.github.com/repos/gflags/gflags/assignees{/user}","branches_url":"https://api.github.com/repos/gflags/gflags/branches{/branch}","tags_url":"https://api.github.com/repos/gflags/gflags/tags","blobs_url":"https://api.github.com/repos/gflags/gflags/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gflags/gflags/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gflags/gflags/git/refs{/sha}","trees_url":"https://api.github.com/repos/gflags/gflags/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gflags/gflags/statuses/{sha}","languages_url":"https://api.github.com/repos/gflags/gflags/languages","stargazers_url":"https://api.github.com/repos/gflags/gflags/stargazers","contributors_url":"https://api.github.com/repos/gflags/gflags/contributors","subscribers_url":"https://api.github.com/repos/gflags/gflags/subscribers","subscription_url":"https://api.github.com/repos/gflags/gflags/subscription","commits_url":"https://api.github.com/repos/gflags/gflags/commits{/sha}","git_commits_url":"https://api.github.com/repos/gflags/gflags/git/commits{/sha}","comments_url":"https://api.github.com/repos/gflags/gflags/comments{/number}","issue_comment_url":"https://api.github.com/repos/gflags/gflags/issues/comments{/number}","contents_url":"https://api.github.com/repos/gflags/gflags/contents/{+path}","compare_url":"https://api.github.com/repos/gflags/gflags/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gflags/gflags/merges","archive_url":"https://api.github.com/repos/gflags/gflags/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gflags/gflags/downloads","issues_url":"https://api.github.com/repos/gflags/gflags/issues{/number}","pulls_url":"https://api.github.com/repos/gflags/gflags/pulls{/number}","milestones_url":"https://api.github.com/repos/gflags/gflags/milestones{/number}","notifications_url":"https://api.github.com/repos/gflags/gflags/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gflags/gflags/labels{/name}","releases_url":"https://api.github.com/repos/gflags/gflags/releases{/id}","deployments_url":"https://api.github.com/repos/gflags/gflags/deployments","created_at":"2013-04-20T22:21:20Z","updated_at":"2016-02-24T09:28:40Z","pushed_at":"2016-02-27T20:42:32Z","git_url":"git://github.com/gflags/gflags.git","ssh_url":"git@github.com:gflags/gflags.git","clone_url":"https://github.com/gflags/gflags.git","svn_url":"https://github.com/gflags/gflags","homepage":"https://gflags.github.io/gflags/","size":1589,"stargazers_count":380,"watchers_count":380,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":156,"mirror_url":null,"open_issues_count":22,"forks":156,"open_issues":22,"watchers":380,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gflags/gflags/pulls/137"},"html":{"href":"https://github.com/gflags/gflags/pull/137"},"issue":{"href":"https://api.github.com/repos/gflags/gflags/issues/137"},"comments":{"href":"https://api.github.com/repos/gflags/gflags/issues/137/comments"},"review_comments":{"href":"https://api.github.com/repos/gflags/gflags/pulls/137/comments"},"review_comment":{"href":"https://api.github.com/repos/gflags/gflags/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gflags/gflags/pulls/137/commits"},"statuses":{"href":"https://api.github.com/repos/gflags/gflags/statuses/b90a325ef355ad2ad45c46c7fc73fc3e28d3a33d"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}