{"action":"created","comment":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/comments/65734496","id":65734496,"diff_hunk":"@@ -0,0 +1,22 @@\n+# Really a generic argument checking class not specific to NotificationDispatcher.\n+# But since we have de-coupled back-ends now, it seemed important to have an\n+# enforceable spec for what these signatures are, so everyone is on the same page.\n+class Spree::NotificationDispatcher::ArgumentChecker\n+  class_attribute :signatures\n+  self.signatures = {\n+\n+  }\n+\n+\n+  attr_reader :message, :args\n+  def initialize(message, *args)\n+    @message, @args = message, args\n+  end\n+\n+  def check!\n+    signature = signatures[message.to_sym]","path":"core/app/models/spree/notification_dispatcher/argument_checker.rb","position":17,"original_position":17,"commit_id":"1ca530b55139afd5e3f4b9c6d0169c490ab2d013","original_commit_id":"1ca530b55139afd5e3f4b9c6d0169c490ab2d013","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Useless assignment to variable - `signature`. Did you mean `signatures`?","created_at":"2016-06-03T16:15:21Z","updated_at":"2016-06-03T16:15:21Z","html_url":"https://github.com/solidusio/solidus/pull/1218#discussion_r65734496","pull_request_url":"https://api.github.com/repos/solidusio/solidus/pulls/1218","_links":{"self":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/comments/65734496"},"html":{"href":"https://github.com/solidusio/solidus/pull/1218#discussion_r65734496"},"pull_request":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/1218"}}},"pull_request":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/1218","id":72532493,"html_url":"https://github.com/solidusio/solidus/pull/1218","diff_url":"https://github.com/solidusio/solidus/pull/1218.diff","patch_url":"https://github.com/solidusio/solidus/pull/1218.patch","issue_url":"https://api.github.com/repos/solidusio/solidus/issues/1218","number":1218,"state":"open","locked":false,"title":"First pass at a NotificationDispatch central abstraction for transactional emails","user":{"login":"jrochkind","id":149304,"avatar_url":"https://avatars.githubusercontent.com/u/149304?v=3","gravatar_id":"","url":"https://api.github.com/users/jrochkind","html_url":"https://github.com/jrochkind","followers_url":"https://api.github.com/users/jrochkind/followers","following_url":"https://api.github.com/users/jrochkind/following{/other_user}","gists_url":"https://api.github.com/users/jrochkind/gists{/gist_id}","starred_url":"https://api.github.com/users/jrochkind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrochkind/subscriptions","organizations_url":"https://api.github.com/users/jrochkind/orgs","repos_url":"https://api.github.com/users/jrochkind/repos","events_url":"https://api.github.com/users/jrochkind/events{/privacy}","received_events_url":"https://api.github.com/users/jrochkind/received_events","type":"User","site_admin":false},"body":null,"created_at":"2016-06-03T16:15:13Z","updated_at":"2016-06-03T16:15:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5150799133535a36158944d92b2ad12c765800af","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/solidusio/solidus/pulls/1218/commits","review_comments_url":"https://api.github.com/repos/solidusio/solidus/pulls/1218/comments","review_comment_url":"https://api.github.com/repos/solidusio/solidus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/solidusio/solidus/issues/1218/comments","statuses_url":"https://api.github.com/repos/solidusio/solidus/statuses/1ca530b55139afd5e3f4b9c6d0169c490ab2d013","head":{"label":"jrochkind:notification_dispatcher","ref":"notification_dispatcher","sha":"1ca530b55139afd5e3f4b9c6d0169c490ab2d013","user":{"login":"jrochkind","id":149304,"avatar_url":"https://avatars.githubusercontent.com/u/149304?v=3","gravatar_id":"","url":"https://api.github.com/users/jrochkind","html_url":"https://github.com/jrochkind","followers_url":"https://api.github.com/users/jrochkind/followers","following_url":"https://api.github.com/users/jrochkind/following{/other_user}","gists_url":"https://api.github.com/users/jrochkind/gists{/gist_id}","starred_url":"https://api.github.com/users/jrochkind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrochkind/subscriptions","organizations_url":"https://api.github.com/users/jrochkind/orgs","repos_url":"https://api.github.com/users/jrochkind/repos","events_url":"https://api.github.com/users/jrochkind/events{/privacy}","received_events_url":"https://api.github.com/users/jrochkind/received_events","type":"User","site_admin":false},"repo":{"id":49728060,"name":"solidus","full_name":"jrochkind/solidus","owner":{"login":"jrochkind","id":149304,"avatar_url":"https://avatars.githubusercontent.com/u/149304?v=3","gravatar_id":"","url":"https://api.github.com/users/jrochkind","html_url":"https://github.com/jrochkind","followers_url":"https://api.github.com/users/jrochkind/followers","following_url":"https://api.github.com/users/jrochkind/following{/other_user}","gists_url":"https://api.github.com/users/jrochkind/gists{/gist_id}","starred_url":"https://api.github.com/users/jrochkind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrochkind/subscriptions","organizations_url":"https://api.github.com/users/jrochkind/orgs","repos_url":"https://api.github.com/users/jrochkind/repos","events_url":"https://api.github.com/users/jrochkind/events{/privacy}","received_events_url":"https://api.github.com/users/jrochkind/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jrochkind/solidus","description":"Solidus, Rails eCommerce System","fork":true,"url":"https://api.github.com/repos/jrochkind/solidus","forks_url":"https://api.github.com/repos/jrochkind/solidus/forks","keys_url":"https://api.github.com/repos/jrochkind/solidus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrochkind/solidus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrochkind/solidus/teams","hooks_url":"https://api.github.com/repos/jrochkind/solidus/hooks","issue_events_url":"https://api.github.com/repos/jrochkind/solidus/issues/events{/number}","events_url":"https://api.github.com/repos/jrochkind/solidus/events","assignees_url":"https://api.github.com/repos/jrochkind/solidus/assignees{/user}","branches_url":"https://api.github.com/repos/jrochkind/solidus/branches{/branch}","tags_url":"https://api.github.com/repos/jrochkind/solidus/tags","blobs_url":"https://api.github.com/repos/jrochkind/solidus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrochkind/solidus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrochkind/solidus/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrochkind/solidus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrochkind/solidus/statuses/{sha}","languages_url":"https://api.github.com/repos/jrochkind/solidus/languages","stargazers_url":"https://api.github.com/repos/jrochkind/solidus/stargazers","contributors_url":"https://api.github.com/repos/jrochkind/solidus/contributors","subscribers_url":"https://api.github.com/repos/jrochkind/solidus/subscribers","subscription_url":"https://api.github.com/repos/jrochkind/solidus/subscription","commits_url":"https://api.github.com/repos/jrochkind/solidus/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrochkind/solidus/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrochkind/solidus/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrochkind/solidus/issues/comments{/number}","contents_url":"https://api.github.com/repos/jrochkind/solidus/contents/{+path}","compare_url":"https://api.github.com/repos/jrochkind/solidus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrochkind/solidus/merges","archive_url":"https://api.github.com/repos/jrochkind/solidus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrochkind/solidus/downloads","issues_url":"https://api.github.com/repos/jrochkind/solidus/issues{/number}","pulls_url":"https://api.github.com/repos/jrochkind/solidus/pulls{/number}","milestones_url":"https://api.github.com/repos/jrochkind/solidus/milestones{/number}","notifications_url":"https://api.github.com/repos/jrochkind/solidus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrochkind/solidus/labels{/name}","releases_url":"https://api.github.com/repos/jrochkind/solidus/releases{/id}","deployments_url":"https://api.github.com/repos/jrochkind/solidus/deployments","created_at":"2016-01-15T15:42:18Z","updated_at":"2016-01-15T15:42:21Z","pushed_at":"2016-06-03T16:03:51Z","git_url":"git://github.com/jrochkind/solidus.git","ssh_url":"git@github.com:jrochkind/solidus.git","clone_url":"https://github.com/jrochkind/solidus.git","svn_url":"https://github.com/jrochkind/solidus","homepage":"http://solidus.io/","size":63479,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"solidusio:master","ref":"master","sha":"adb604ed0b997d0dd8e1f656fbaf36d5a14e1fab","user":{"login":"solidusio","id":11045486,"avatar_url":"https://avatars.githubusercontent.com/u/11045486?v=3","gravatar_id":"","url":"https://api.github.com/users/solidusio","html_url":"https://github.com/solidusio","followers_url":"https://api.github.com/users/solidusio/followers","following_url":"https://api.github.com/users/solidusio/following{/other_user}","gists_url":"https://api.github.com/users/solidusio/gists{/gist_id}","starred_url":"https://api.github.com/users/solidusio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solidusio/subscriptions","organizations_url":"https://api.github.com/users/solidusio/orgs","repos_url":"https://api.github.com/users/solidusio/repos","events_url":"https://api.github.com/users/solidusio/events{/privacy}","received_events_url":"https://api.github.com/users/solidusio/received_events","type":"Organization","site_admin":false},"repo":{"id":30985840,"name":"solidus","full_name":"solidusio/solidus","owner":{"login":"solidusio","id":11045486,"avatar_url":"https://avatars.githubusercontent.com/u/11045486?v=3","gravatar_id":"","url":"https://api.github.com/users/solidusio","html_url":"https://github.com/solidusio","followers_url":"https://api.github.com/users/solidusio/followers","following_url":"https://api.github.com/users/solidusio/following{/other_user}","gists_url":"https://api.github.com/users/solidusio/gists{/gist_id}","starred_url":"https://api.github.com/users/solidusio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solidusio/subscriptions","organizations_url":"https://api.github.com/users/solidusio/orgs","repos_url":"https://api.github.com/users/solidusio/repos","events_url":"https://api.github.com/users/solidusio/events{/privacy}","received_events_url":"https://api.github.com/users/solidusio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/solidusio/solidus","description":"Solidus, Rails eCommerce System","fork":false,"url":"https://api.github.com/repos/solidusio/solidus","forks_url":"https://api.github.com/repos/solidusio/solidus/forks","keys_url":"https://api.github.com/repos/solidusio/solidus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/solidusio/solidus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/solidusio/solidus/teams","hooks_url":"https://api.github.com/repos/solidusio/solidus/hooks","issue_events_url":"https://api.github.com/repos/solidusio/solidus/issues/events{/number}","events_url":"https://api.github.com/repos/solidusio/solidus/events","assignees_url":"https://api.github.com/repos/solidusio/solidus/assignees{/user}","branches_url":"https://api.github.com/repos/solidusio/solidus/branches{/branch}","tags_url":"https://api.github.com/repos/solidusio/solidus/tags","blobs_url":"https://api.github.com/repos/solidusio/solidus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/solidusio/solidus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/solidusio/solidus/git/refs{/sha}","trees_url":"https://api.github.com/repos/solidusio/solidus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/solidusio/solidus/statuses/{sha}","languages_url":"https://api.github.com/repos/solidusio/solidus/languages","stargazers_url":"https://api.github.com/repos/solidusio/solidus/stargazers","contributors_url":"https://api.github.com/repos/solidusio/solidus/contributors","subscribers_url":"https://api.github.com/repos/solidusio/solidus/subscribers","subscription_url":"https://api.github.com/repos/solidusio/solidus/subscription","commits_url":"https://api.github.com/repos/solidusio/solidus/commits{/sha}","git_commits_url":"https://api.github.com/repos/solidusio/solidus/git/commits{/sha}","comments_url":"https://api.github.com/repos/solidusio/solidus/comments{/number}","issue_comment_url":"https://api.github.com/repos/solidusio/solidus/issues/comments{/number}","contents_url":"https://api.github.com/repos/solidusio/solidus/contents/{+path}","compare_url":"https://api.github.com/repos/solidusio/solidus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/solidusio/solidus/merges","archive_url":"https://api.github.com/repos/solidusio/solidus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/solidusio/solidus/downloads","issues_url":"https://api.github.com/repos/solidusio/solidus/issues{/number}","pulls_url":"https://api.github.com/repos/solidusio/solidus/pulls{/number}","milestones_url":"https://api.github.com/repos/solidusio/solidus/milestones{/number}","notifications_url":"https://api.github.com/repos/solidusio/solidus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/solidusio/solidus/labels{/name}","releases_url":"https://api.github.com/repos/solidusio/solidus/releases{/id}","deployments_url":"https://api.github.com/repos/solidusio/solidus/deployments","created_at":"2015-02-18T20:41:58Z","updated_at":"2016-06-03T04:53:32Z","pushed_at":"2016-06-03T16:15:13Z","git_url":"git://github.com/solidusio/solidus.git","ssh_url":"git@github.com:solidusio/solidus.git","clone_url":"https://github.com/solidusio/solidus.git","svn_url":"https://github.com/solidusio/solidus","homepage":"http://solidus.io/","size":69372,"stargazers_count":942,"watchers_count":942,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":267,"mirror_url":null,"open_issues_count":128,"forks":267,"open_issues":128,"watchers":942,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/1218"},"html":{"href":"https://github.com/solidusio/solidus/pull/1218"},"issue":{"href":"https://api.github.com/repos/solidusio/solidus/issues/1218"},"comments":{"href":"https://api.github.com/repos/solidusio/solidus/issues/1218/comments"},"review_comments":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/1218/comments"},"review_comment":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/1218/commits"},"statuses":{"href":"https://api.github.com/repos/solidusio/solidus/statuses/1ca530b55139afd5e3f4b9c6d0169c490ab2d013"}}}}
{"actor":{"display_login":"houndci-bot"}}