{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/9838","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/9838/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/9838/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/9838/events","html_url":"https://github.com/nodejs/node/pull/9838","id":192256474,"number":9838,"title":"buffer: fix transcode for single-byte enc to ucs2","user":{"login":"addaleax","id":899444,"avatar_url":"https://avatars.githubusercontent.com/u/899444?v=3","gravatar_id":"","url":"https://api.github.com/users/addaleax","html_url":"https://github.com/addaleax","followers_url":"https://api.github.com/users/addaleax/followers","following_url":"https://api.github.com/users/addaleax/following{/other_user}","gists_url":"https://api.github.com/users/addaleax/gists{/gist_id}","starred_url":"https://api.github.com/users/addaleax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addaleax/subscriptions","organizations_url":"https://api.github.com/users/addaleax/orgs","repos_url":"https://api.github.com/users/addaleax/repos","events_url":"https://api.github.com/users/addaleax/events{/privacy}","received_events_url":"https://api.github.com/users/addaleax/received_events","type":"User","site_admin":false},"labels":[{"id":155267414,"url":"https://api.github.com/repos/nodejs/node/labels/buffer","name":"buffer","color":"f7c6c7","default":false},{"id":155267502,"url":"https://api.github.com/repos/nodejs/node/labels/c++","name":"c++","color":"e11d21","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-29T11:27:19Z","updated_at":"2016-12-20T20:36:41Z","closed_at":"2016-12-06T00:47:43Z","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/9838","html_url":"https://github.com/nodejs/node/pull/9838","diff_url":"https://github.com/nodejs/node/pull/9838.diff","patch_url":"https://github.com/nodejs/node/pull/9838.patch"},"body":"##### Checklist\r\n\r\n- [x] `make -j8 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n\r\nbuffer\r\n\r\n##### Description of change\r\n\r\nFix `buffer.transcode()` for transcoding from single-byte character\r\nencodings to UCS2.\r\n\r\nThese would previously perform out-of-bounds reads due to an\r\nincorrect `sizeof()` expression.\r\n\r\nFixes: https://github.com/nodejs/node/issues/9834\r\n\r\n/cc @nodejs/buffer "},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/268352047","html_url":"https://github.com/nodejs/node/pull/9838#issuecomment-268352047","issue_url":"https://api.github.com/repos/nodejs/node/issues/9838","id":268352047,"user":{"login":"TheAlphaNerd","id":498775,"avatar_url":"https://avatars.githubusercontent.com/u/498775?v=3","gravatar_id":"","url":"https://api.github.com/users/TheAlphaNerd","html_url":"https://github.com/TheAlphaNerd","followers_url":"https://api.github.com/users/TheAlphaNerd/followers","following_url":"https://api.github.com/users/TheAlphaNerd/following{/other_user}","gists_url":"https://api.github.com/users/TheAlphaNerd/gists{/gist_id}","starred_url":"https://api.github.com/users/TheAlphaNerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheAlphaNerd/subscriptions","organizations_url":"https://api.github.com/users/TheAlphaNerd/orgs","repos_url":"https://api.github.com/users/TheAlphaNerd/repos","events_url":"https://api.github.com/users/TheAlphaNerd/events{/privacy}","received_events_url":"https://api.github.com/users/TheAlphaNerd/received_events","type":"User","site_admin":false},"created_at":"2016-12-20T20:36:41Z","updated_at":"2016-12-20T20:36:41Z","body":"@addaleax this is not landing cleanly on v6.x or v4.x\r\n\r\nThere are some other commits that need to get pulled for this to land cleanly, should we backport?"}}
{"actor":{"display_login":"TheAlphaNerd"}}