{"action":"created","comment":{"url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/pulls/comments/58688731","id":58688731,"diff_hunk":"@@ -72,6 +72,9 @@ export default class PostComment extends React.Component {\n     if (shouldClearText) {\n       this.setState({editText: ''});\n     }\n+    if (this.props.editText !== newProps.editText) {","path":"src/components/post-comment.jsx","position":4,"original_position":4,"commit_id":"c692f509b14312f555e61014a2faf5a0fb989699","original_commit_id":"c692f509b14312f555e61014a2faf5a0fb989699","user":{"login":"kadmil","id":4445523,"avatar_url":"https://avatars.githubusercontent.com/u/4445523?v=3","gravatar_id":"","url":"https://api.github.com/users/kadmil","html_url":"https://github.com/kadmil","followers_url":"https://api.github.com/users/kadmil/followers","following_url":"https://api.github.com/users/kadmil/following{/other_user}","gists_url":"https://api.github.com/users/kadmil/gists{/gist_id}","starred_url":"https://api.github.com/users/kadmil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadmil/subscriptions","organizations_url":"https://api.github.com/users/kadmil/orgs","repos_url":"https://api.github.com/users/kadmil/repos","events_url":"https://api.github.com/users/kadmil/events{/privacy}","received_events_url":"https://api.github.com/users/kadmil/received_events","type":"User","site_admin":false},"body":"We store 'exact input state' in component and update redux version on blur, so we could restore 'new comment' version after cancelling comment. So, 1) props change in the same time redux-stored state change, which happens on things like 'someone clicked a baloon' or so; 2) not every props propagation to comment component is connected with comment text change, so we could be comparing old saved props with newly changed state, cancelling user's hard work on comment edit. Previous solution 'change state if props contain more long comment text' did quite bad here — not by function itself, but by it's complicated semantics.\r\n\r\nSo, for what I know now, checking props comment text change and updating component state after the check is correct thing to do.","created_at":"2016-04-06T11:23:01Z","updated_at":"2016-04-06T11:23:01Z","html_url":"https://github.com/FreeFeed/freefeed-react-client/pull/389#discussion_r58688731","pull_request_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/pulls/389","_links":{"self":{"href":"https://api.github.com/repos/FreeFeed/freefeed-react-client/pulls/comments/58688731"},"html":{"href":"https://github.com/FreeFeed/freefeed-react-client/pull/389#discussion_r58688731"},"pull_request":{"href":"https://api.github.com/repos/FreeFeed/freefeed-react-client/pulls/389"}}},"pull_request":{"url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/pulls/389","id":65268419,"html_url":"https://github.com/FreeFeed/freefeed-react-client/pull/389","diff_url":"https://github.com/FreeFeed/freefeed-react-client/pull/389.diff","patch_url":"https://github.com/FreeFeed/freefeed-react-client/pull/389.patch","issue_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/issues/389","number":389,"state":"open","locked":false,"title":"Add user name and show comment as we should do","user":{"login":"kadmil","id":4445523,"avatar_url":"https://avatars.githubusercontent.com/u/4445523?v=3","gravatar_id":"","url":"https://api.github.com/users/kadmil","html_url":"https://github.com/kadmil","followers_url":"https://api.github.com/users/kadmil/followers","following_url":"https://api.github.com/users/kadmil/following{/other_user}","gists_url":"https://api.github.com/users/kadmil/gists{/gist_id}","starred_url":"https://api.github.com/users/kadmil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadmil/subscriptions","organizations_url":"https://api.github.com/users/kadmil/orgs","repos_url":"https://api.github.com/users/kadmil/repos","events_url":"https://api.github.com/users/kadmil/events{/privacy}","received_events_url":"https://api.github.com/users/kadmil/received_events","type":"User","site_admin":false},"body":"Closes T19","created_at":"2016-04-05T08:47:15Z","updated_at":"2016-04-06T11:23:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45874f2f51fdcbfa87fb2a3d331985e107ccd4b8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/pulls/389/commits","review_comments_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/pulls/389/comments","review_comment_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/issues/389/comments","statuses_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/statuses/c692f509b14312f555e61014a2faf5a0fb989699","head":{"label":"ujenjt:comments-bubbles","ref":"comments-bubbles","sha":"c692f509b14312f555e61014a2faf5a0fb989699","user":{"login":"ujenjt","id":1270671,"avatar_url":"https://avatars.githubusercontent.com/u/1270671?v=3","gravatar_id":"","url":"https://api.github.com/users/ujenjt","html_url":"https://github.com/ujenjt","followers_url":"https://api.github.com/users/ujenjt/followers","following_url":"https://api.github.com/users/ujenjt/following{/other_user}","gists_url":"https://api.github.com/users/ujenjt/gists{/gist_id}","starred_url":"https://api.github.com/users/ujenjt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ujenjt/subscriptions","organizations_url":"https://api.github.com/users/ujenjt/orgs","repos_url":"https://api.github.com/users/ujenjt/repos","events_url":"https://api.github.com/users/ujenjt/events{/privacy}","received_events_url":"https://api.github.com/users/ujenjt/received_events","type":"User","site_admin":false},"repo":{"id":43161571,"name":"freefeed-react-client","full_name":"ujenjt/freefeed-react-client","owner":{"login":"ujenjt","id":1270671,"avatar_url":"https://avatars.githubusercontent.com/u/1270671?v=3","gravatar_id":"","url":"https://api.github.com/users/ujenjt","html_url":"https://github.com/ujenjt","followers_url":"https://api.github.com/users/ujenjt/followers","following_url":"https://api.github.com/users/ujenjt/following{/other_user}","gists_url":"https://api.github.com/users/ujenjt/gists{/gist_id}","starred_url":"https://api.github.com/users/ujenjt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ujenjt/subscriptions","organizations_url":"https://api.github.com/users/ujenjt/orgs","repos_url":"https://api.github.com/users/ujenjt/repos","events_url":"https://api.github.com/users/ujenjt/events{/privacy}","received_events_url":"https://api.github.com/users/ujenjt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ujenjt/freefeed-react-client","description":"Experimental React-based frontend","fork":true,"url":"https://api.github.com/repos/ujenjt/freefeed-react-client","forks_url":"https://api.github.com/repos/ujenjt/freefeed-react-client/forks","keys_url":"https://api.github.com/repos/ujenjt/freefeed-react-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ujenjt/freefeed-react-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ujenjt/freefeed-react-client/teams","hooks_url":"https://api.github.com/repos/ujenjt/freefeed-react-client/hooks","issue_events_url":"https://api.github.com/repos/ujenjt/freefeed-react-client/issues/events{/number}","events_url":"https://api.github.com/repos/ujenjt/freefeed-react-client/events","assignees_url":"https://api.github.com/repos/ujenjt/freefeed-react-client/assignees{/user}","branches_url":"https://api.github.com/repos/ujenjt/freefeed-react-client/branches{/branch}","tags_url":"https://api.github.com/repos/ujenjt/freefeed-react-client/tags","blobs_url":"https://api.github.com/repos/ujenjt/freefeed-react-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ujenjt/freefeed-react-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ujenjt/freefeed-react-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/ujenjt/freefeed-react-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ujenjt/freefeed-react-client/statuses/{sha}","languages_url":"https://api.github.com/repos/ujenjt/freefeed-react-client/languages","stargazers_url":"https://api.github.com/repos/ujenjt/freefeed-react-client/stargazers","contributors_url":"https://api.github.com/repos/ujenjt/freefeed-react-client/contributors","subscribers_url":"https://api.github.com/repos/ujenjt/freefeed-react-client/subscribers","subscription_url":"https://api.github.com/repos/ujenjt/freefeed-react-client/subscription","commits_url":"https://api.github.com/repos/ujenjt/freefeed-react-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/ujenjt/freefeed-react-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/ujenjt/freefeed-react-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/ujenjt/freefeed-react-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/ujenjt/freefeed-react-client/contents/{+path}","compare_url":"https://api.github.com/repos/ujenjt/freefeed-react-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ujenjt/freefeed-react-client/merges","archive_url":"https://api.github.com/repos/ujenjt/freefeed-react-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ujenjt/freefeed-react-client/downloads","issues_url":"https://api.github.com/repos/ujenjt/freefeed-react-client/issues{/number}","pulls_url":"https://api.github.com/repos/ujenjt/freefeed-react-client/pulls{/number}","milestones_url":"https://api.github.com/repos/ujenjt/freefeed-react-client/milestones{/number}","notifications_url":"https://api.github.com/repos/ujenjt/freefeed-react-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ujenjt/freefeed-react-client/labels{/name}","releases_url":"https://api.github.com/repos/ujenjt/freefeed-react-client/releases{/id}","deployments_url":"https://api.github.com/repos/ujenjt/freefeed-react-client/deployments","created_at":"2015-09-25T16:50:30Z","updated_at":"2016-03-30T14:44:47Z","pushed_at":"2016-04-05T15:13:49Z","git_url":"git://github.com/ujenjt/freefeed-react-client.git","ssh_url":"git@github.com:ujenjt/freefeed-react-client.git","clone_url":"https://github.com/ujenjt/freefeed-react-client.git","svn_url":"https://github.com/ujenjt/freefeed-react-client","homepage":null,"size":1449,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"FreeFeed:stable","ref":"stable","sha":"c924db61adecc59c0ada6f1b71cd6207c5e71c23","user":{"login":"FreeFeed","id":11790426,"avatar_url":"https://avatars.githubusercontent.com/u/11790426?v=3","gravatar_id":"","url":"https://api.github.com/users/FreeFeed","html_url":"https://github.com/FreeFeed","followers_url":"https://api.github.com/users/FreeFeed/followers","following_url":"https://api.github.com/users/FreeFeed/following{/other_user}","gists_url":"https://api.github.com/users/FreeFeed/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeFeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeFeed/subscriptions","organizations_url":"https://api.github.com/users/FreeFeed/orgs","repos_url":"https://api.github.com/users/FreeFeed/repos","events_url":"https://api.github.com/users/FreeFeed/events{/privacy}","received_events_url":"https://api.github.com/users/FreeFeed/received_events","type":"Organization","site_admin":false},"repo":{"id":38977139,"name":"freefeed-react-client","full_name":"FreeFeed/freefeed-react-client","owner":{"login":"FreeFeed","id":11790426,"avatar_url":"https://avatars.githubusercontent.com/u/11790426?v=3","gravatar_id":"","url":"https://api.github.com/users/FreeFeed","html_url":"https://github.com/FreeFeed","followers_url":"https://api.github.com/users/FreeFeed/followers","following_url":"https://api.github.com/users/FreeFeed/following{/other_user}","gists_url":"https://api.github.com/users/FreeFeed/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeFeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeFeed/subscriptions","organizations_url":"https://api.github.com/users/FreeFeed/orgs","repos_url":"https://api.github.com/users/FreeFeed/repos","events_url":"https://api.github.com/users/FreeFeed/events{/privacy}","received_events_url":"https://api.github.com/users/FreeFeed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FreeFeed/freefeed-react-client","description":"React-based frontend","fork":false,"url":"https://api.github.com/repos/FreeFeed/freefeed-react-client","forks_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/forks","keys_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/teams","hooks_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/hooks","issue_events_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/issues/events{/number}","events_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/events","assignees_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/assignees{/user}","branches_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/branches{/branch}","tags_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/tags","blobs_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/statuses/{sha}","languages_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/languages","stargazers_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/stargazers","contributors_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/contributors","subscribers_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/subscribers","subscription_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/subscription","commits_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/contents/{+path}","compare_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/merges","archive_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/downloads","issues_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/issues{/number}","pulls_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/pulls{/number}","milestones_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/milestones{/number}","notifications_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/labels{/name}","releases_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/releases{/id}","deployments_url":"https://api.github.com/repos/FreeFeed/freefeed-react-client/deployments","created_at":"2015-07-12T20:38:13Z","updated_at":"2016-03-30T06:33:45Z","pushed_at":"2016-04-05T22:51:23Z","git_url":"git://github.com/FreeFeed/freefeed-react-client.git","ssh_url":"git@github.com:FreeFeed/freefeed-react-client.git","clone_url":"https://github.com/FreeFeed/freefeed-react-client.git","svn_url":"https://github.com/FreeFeed/freefeed-react-client","homepage":"https://beta.freefeed.net","size":1685,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":33,"forks":5,"open_issues":33,"watchers":13,"default_branch":"stable"}},"_links":{"self":{"href":"https://api.github.com/repos/FreeFeed/freefeed-react-client/pulls/389"},"html":{"href":"https://github.com/FreeFeed/freefeed-react-client/pull/389"},"issue":{"href":"https://api.github.com/repos/FreeFeed/freefeed-react-client/issues/389"},"comments":{"href":"https://api.github.com/repos/FreeFeed/freefeed-react-client/issues/389/comments"},"review_comments":{"href":"https://api.github.com/repos/FreeFeed/freefeed-react-client/pulls/389/comments"},"review_comment":{"href":"https://api.github.com/repos/FreeFeed/freefeed-react-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FreeFeed/freefeed-react-client/pulls/389/commits"},"statuses":{"href":"https://api.github.com/repos/FreeFeed/freefeed-react-client/statuses/c692f509b14312f555e61014a2faf5a0fb989699"}}}}