{"action":"created","issue":{"url":"https://api.github.com/repos/odoo/odoo/issues/11410","repository_url":"https://api.github.com/repos/odoo/odoo","labels_url":"https://api.github.com/repos/odoo/odoo/issues/11410/labels{/name}","comments_url":"https://api.github.com/repos/odoo/odoo/issues/11410/comments","events_url":"https://api.github.com/repos/odoo/odoo/issues/11410/events","html_url":"https://github.com/odoo/odoo/pull/11410","id":141934795,"number":11410,"title":"9.0 fixpaymentreferences dle","user":{"login":"beledouxdenis","id":5822488,"avatar_url":"https://avatars.githubusercontent.com/u/5822488?v=3","gravatar_id":"","url":"https://api.github.com/users/beledouxdenis","html_url":"https://github.com/beledouxdenis","followers_url":"https://api.github.com/users/beledouxdenis/followers","following_url":"https://api.github.com/users/beledouxdenis/following{/other_user}","gists_url":"https://api.github.com/users/beledouxdenis/gists{/gist_id}","starred_url":"https://api.github.com/users/beledouxdenis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beledouxdenis/subscriptions","organizations_url":"https://api.github.com/users/beledouxdenis/orgs","repos_url":"https://api.github.com/users/beledouxdenis/repos","events_url":"https://api.github.com/users/beledouxdenis/events{/privacy}","received_events_url":"https://api.github.com/users/beledouxdenis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-03-18T17:49:32Z","updated_at":"2016-03-21T09:57:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/odoo/odoo/pulls/11410","html_url":"https://github.com/odoo/odoo/pull/11410","diff_url":"https://github.com/odoo/odoo/pull/11410.diff","patch_url":"https://github.com/odoo/odoo/pull/11410.patch"},"body":"    [FIX] website_quote: port of cb9d7982c1ffb346fd83cbac9a1bf9c58942c2f5\r\n    \r\n    The above revision need to be applied in website_quote\r\n    as well.\r\n\r\n    [FIX] website_quote: port of f89e8f9df2c4ffaafc846082ac2b252c787e1e65\r\n    \r\n    The above revision needs to be applied on website_quote\r\n    as well.\r\n\r\n    [FIX] website_sale: always re-render the `pay now` button\r\n    \r\n    Before this revision,\r\n    when a user tried to pay his cart with a first acquirer\r\n    e.g. Ogone\r\n    then came back to the shop (using the browser back button)\r\n    then chose another acquirer\r\n    e.g. Paypal\r\n    a new transaction is created, due to the change of acquirer\r\n    (following revision cb9d798)\r\n    and therefore, the transaction has a new reference compared\r\n    to the last payment transaction attempt (e.g. the ogone one)\r\n    but, the old reference is still referenced within\r\n    the `Pay now` form values, because the page wasn't re-rendered,\r\n    because the user pressed the browser back button, and this\r\n    doesn't refresh/re-render the page, and, therefore,\r\n    the old reference was still referenced within the `Pay Now`\r\n    form values.\r\n    \r\n    Therefore, the wrong reference was sent to the acquirer\r\n    (e.g. paypal) and this prevented the payment validation\r\n    at the payment feedback, as the new reference was expected\r\n    in the feedback information, while we receive the older one.\r\n    \r\n    This revision makes sure to always re-render the `Pay now`\r\n    form, so the transaction reference, as well as the other\r\n    possible changes in the values, are correctly set,\r\n    before sending the information to the acquirer."},"comment":{"url":"https://api.github.com/repos/odoo/odoo/issues/comments/199202532","html_url":"https://github.com/odoo/odoo/pull/11410#issuecomment-199202532","issue_url":"https://api.github.com/repos/odoo/odoo/issues/11410","id":199202532,"user":{"login":"dbo-odoo","id":9530767,"avatar_url":"https://avatars.githubusercontent.com/u/9530767?v=3","gravatar_id":"","url":"https://api.github.com/users/dbo-odoo","html_url":"https://github.com/dbo-odoo","followers_url":"https://api.github.com/users/dbo-odoo/followers","following_url":"https://api.github.com/users/dbo-odoo/following{/other_user}","gists_url":"https://api.github.com/users/dbo-odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/dbo-odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbo-odoo/subscriptions","organizations_url":"https://api.github.com/users/dbo-odoo/orgs","repos_url":"https://api.github.com/users/dbo-odoo/repos","events_url":"https://api.github.com/users/dbo-odoo/events{/privacy}","received_events_url":"https://api.github.com/users/dbo-odoo/received_events","type":"User","site_admin":false},"created_at":"2016-03-21T09:57:19Z","updated_at":"2016-03-21T09:57:19Z","body":"I was wondering if it would not be a better idea to simply drop the \"search existing tx\" part, and to simply create a new tx everytime it's requested...\r\n\r\nas for the middle click, i haven't been able to make it *not* work in chrome, in firefox the solution works\r\n\r\nyou can see this in this compare (sorry i did not push on commit/push on friday and i'd rather not push force on your pr) https://github.com/odoo/odoo/compare/9.0...odoo-dev:9.0-fixpaymentreferences-dbo"}}