{"action":"created","issue":{"url":"https://api.github.com/repos/Qabel/qabel-desktop/issues/397","repository_url":"https://api.github.com/repos/Qabel/qabel-desktop","labels_url":"https://api.github.com/repos/Qabel/qabel-desktop/issues/397/labels{/name}","comments_url":"https://api.github.com/repos/Qabel/qabel-desktop/issues/397/comments","events_url":"https://api.github.com/repos/Qabel/qabel-desktop/issues/397/events","html_url":"https://github.com/Qabel/qabel-desktop/pull/397","id":166312916,"number":397,"title":"#307 - Feedback send dialog","user":{"login":"nnice","id":16781049,"avatar_url":"https://avatars.githubusercontent.com/u/16781049?v=3","gravatar_id":"","url":"https://api.github.com/users/nnice","html_url":"https://github.com/nnice","followers_url":"https://api.github.com/users/nnice/followers","following_url":"https://api.github.com/users/nnice/following{/other_user}","gists_url":"https://api.github.com/users/nnice/gists{/gist_id}","starred_url":"https://api.github.com/users/nnice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nnice/subscriptions","organizations_url":"https://api.github.com/users/nnice/orgs","repos_url":"https://api.github.com/users/nnice/repos","events_url":"https://api.github.com/users/nnice/events{/privacy}","received_events_url":"https://api.github.com/users/nnice/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"julianseeger","id":3258762,"avatar_url":"https://avatars.githubusercontent.com/u/3258762?v=3","gravatar_id":"","url":"https://api.github.com/users/julianseeger","html_url":"https://github.com/julianseeger","followers_url":"https://api.github.com/users/julianseeger/followers","following_url":"https://api.github.com/users/julianseeger/following{/other_user}","gists_url":"https://api.github.com/users/julianseeger/gists{/gist_id}","starred_url":"https://api.github.com/users/julianseeger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianseeger/subscriptions","organizations_url":"https://api.github.com/users/julianseeger/orgs","repos_url":"https://api.github.com/users/julianseeger/repos","events_url":"https://api.github.com/users/julianseeger/events{/privacy}","received_events_url":"https://api.github.com/users/julianseeger/received_events","type":"User","site_admin":false},"assignees":[{"login":"julianseeger","id":3258762,"avatar_url":"https://avatars.githubusercontent.com/u/3258762?v=3","gravatar_id":"","url":"https://api.github.com/users/julianseeger","html_url":"https://github.com/julianseeger","followers_url":"https://api.github.com/users/julianseeger/followers","following_url":"https://api.github.com/users/julianseeger/following{/other_user}","gists_url":"https://api.github.com/users/julianseeger/gists{/gist_id}","starred_url":"https://api.github.com/users/julianseeger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianseeger/subscriptions","organizations_url":"https://api.github.com/users/julianseeger/orgs","repos_url":"https://api.github.com/users/julianseeger/repos","events_url":"https://api.github.com/users/julianseeger/events{/privacy}","received_events_url":"https://api.github.com/users/julianseeger/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-07-19T11:54:42Z","updated_at":"2016-07-20T12:57:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Qabel/qabel-desktop/pulls/397","html_url":"https://github.com/Qabel/qabel-desktop/pull/397","diff_url":"https://github.com/Qabel/qabel-desktop/pull/397.diff","patch_url":"https://github.com/Qabel/qabel-desktop/pull/397.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/Qabel/qabel-desktop/issues/comments/233940987","html_url":"https://github.com/Qabel/qabel-desktop/pull/397#issuecomment-233940987","issue_url":"https://api.github.com/repos/Qabel/qabel-desktop/issues/397","id":233940987,"user":{"login":"julianseeger","id":3258762,"avatar_url":"https://avatars.githubusercontent.com/u/3258762?v=3","gravatar_id":"","url":"https://api.github.com/users/julianseeger","html_url":"https://github.com/julianseeger","followers_url":"https://api.github.com/users/julianseeger/followers","following_url":"https://api.github.com/users/julianseeger/following{/other_user}","gists_url":"https://api.github.com/users/julianseeger/gists{/gist_id}","starred_url":"https://api.github.com/users/julianseeger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianseeger/subscriptions","organizations_url":"https://api.github.com/users/julianseeger/orgs","repos_url":"https://api.github.com/users/julianseeger/repos","events_url":"https://api.github.com/users/julianseeger/events{/privacy}","received_events_url":"https://api.github.com/users/julianseeger/received_events","type":"User","site_admin":false},"created_at":"2016-07-20T12:57:36Z","updated_at":"2016-07-20T12:57:36Z","body":"Make sure your tests read like AAA (Arrange, Act, Assert) ... or Given, When, Then if you like\r\n```JAVA\r\n// arrange\r\nsetupStuff(importantVariable=\"significant value\");\r\n// act\r\nString result = subjectUnderTest.executeAction();\r\n// assert\r\nassertEquals(\"significant value\", result);\r\n```\r\neven if the method names don't make sense (like in this example), the flow and re-occurence of the tested values should make the intent and flow of the test very clear.\r\nAct without assert is no test. And if you can delete your prouction code but the tests stay green (like `controller.key = \"value\"; assertEquals(\"value\", controller.key);`, it's useless (and as far from TDD as it can be)"}}
{"actor":{"display_login":"julianseeger"}}