{"action":"created","comment":{"url":"https://api.github.com/repos/bullhorn/novo-elements/pulls/comments/87854777","pull_request_review_id":8449079,"id":87854777,"diff_hunk":"@@ -73,17 +82,25 @@ export class NovoAddressElement implements ControlValueAccessor {\n \n     updateControl() {\n         this.onModelChange(this.model);\n+        this.changeDetectorRef.markForCheck();\n     }\n \n     writeValue(model:any):void {\n-        if (!this.model || !this.model.length) {\n-            this.model = {\n-                countryID: 1,\n-                countryName: 'United States'\n-            };\n-        } else {\n-            this.model = model;\n-        }\n+        setTimeout(() => {","path":"src/elements/form/extras/address/Address.js","position":68,"original_position":68,"commit_id":"5f053407af358c02c68192e307f539530854d726","original_commit_id":"5f053407af358c02c68192e307f539530854d726","user":{"login":"steveerfalot","id":6993848,"avatar_url":"https://avatars.githubusercontent.com/u/6993848?v=3","gravatar_id":"","url":"https://api.github.com/users/steveerfalot","html_url":"https://github.com/steveerfalot","followers_url":"https://api.github.com/users/steveerfalot/followers","following_url":"https://api.github.com/users/steveerfalot/following{/other_user}","gists_url":"https://api.github.com/users/steveerfalot/gists{/gist_id}","starred_url":"https://api.github.com/users/steveerfalot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveerfalot/subscriptions","organizations_url":"https://api.github.com/users/steveerfalot/orgs","repos_url":"https://api.github.com/users/steveerfalot/repos","events_url":"https://api.github.com/users/steveerfalot/events{/privacy}","received_events_url":"https://api.github.com/users/steveerfalot/received_events","type":"User","site_admin":false},"body":"Without the `setTimeout` we get property has changed after it was checked errors. Should we add a check to only set `countryName` if it doesn't exist?","created_at":"2016-11-14T17:53:40Z","updated_at":"2016-11-14T17:53:40Z","html_url":"https://github.com/bullhorn/novo-elements/pull/246#discussion_r87854777","pull_request_url":"https://api.github.com/repos/bullhorn/novo-elements/pulls/246","_links":{"self":{"href":"https://api.github.com/repos/bullhorn/novo-elements/pulls/comments/87854777"},"html":{"href":"https://github.com/bullhorn/novo-elements/pull/246#discussion_r87854777"},"pull_request":{"href":"https://api.github.com/repos/bullhorn/novo-elements/pulls/246"}}},"pull_request":{"url":"https://api.github.com/repos/bullhorn/novo-elements/pulls/246","id":93606852,"html_url":"https://github.com/bullhorn/novo-elements/pull/246","diff_url":"https://github.com/bullhorn/novo-elements/pull/246.diff","patch_url":"https://github.com/bullhorn/novo-elements/pull/246.patch","issue_url":"https://api.github.com/repos/bullhorn/novo-elements/issues/246","number":246,"state":"open","locked":false,"title":"fix:(address fields): Show and populate address fields","user":{"login":"steveerfalot","id":6993848,"avatar_url":"https://avatars.githubusercontent.com/u/6993848?v=3","gravatar_id":"","url":"https://api.github.com/users/steveerfalot","html_url":"https://github.com/steveerfalot","followers_url":"https://api.github.com/users/steveerfalot/followers","following_url":"https://api.github.com/users/steveerfalot/following{/other_user}","gists_url":"https://api.github.com/users/steveerfalot/gists{/gist_id}","starred_url":"https://api.github.com/users/steveerfalot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveerfalot/subscriptions","organizations_url":"https://api.github.com/users/steveerfalot/orgs","repos_url":"https://api.github.com/users/steveerfalot/repos","events_url":"https://api.github.com/users/steveerfalot/events{/privacy}","received_events_url":"https://api.github.com/users/steveerfalot/received_events","type":"User","site_admin":false},"body":"Show and populate address fields\r\n\r\n##### **What did you change?**\r\n\r\nI changed the Address `writeValue` function to actually populate the address field, and changed formUtils to show the address field\r\n\r\n##### **Reviewers**\r\n* @jgodi \r\n* @bvkimball \r\n\r\n##### **Checklist (completed via merger)**\r\n* [ ] Changes are limited to a single goal (no scope creep)\r\n* [ ] Code can be automatically merged (no conflicts)\r\n* [ ] Code follows the standards laid out in the [contributing guide](https://github.com/bullhorn/novo-elements/blob/master/CONTRIBUTING.md)\r\n* [ ] Passes all existing automated tests\r\n* [ ] New functions include new tests\r\n* [ ] New functions are documented (with a description, list of inputs, and expected output)\r\n* [ ] Visually tested in supported browsers and devices","created_at":"2016-11-14T17:08:54Z","updated_at":"2016-11-14T17:53:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f311bb97df6fba58f8101ac33c70e152906ecee","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bullhorn/novo-elements/pulls/246/commits","review_comments_url":"https://api.github.com/repos/bullhorn/novo-elements/pulls/246/comments","review_comment_url":"https://api.github.com/repos/bullhorn/novo-elements/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bullhorn/novo-elements/issues/246/comments","statuses_url":"https://api.github.com/repos/bullhorn/novo-elements/statuses/5f053407af358c02c68192e307f539530854d726","head":{"label":"steveerfalot:master","ref":"master","sha":"5f053407af358c02c68192e307f539530854d726","user":{"login":"steveerfalot","id":6993848,"avatar_url":"https://avatars.githubusercontent.com/u/6993848?v=3","gravatar_id":"","url":"https://api.github.com/users/steveerfalot","html_url":"https://github.com/steveerfalot","followers_url":"https://api.github.com/users/steveerfalot/followers","following_url":"https://api.github.com/users/steveerfalot/following{/other_user}","gists_url":"https://api.github.com/users/steveerfalot/gists{/gist_id}","starred_url":"https://api.github.com/users/steveerfalot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveerfalot/subscriptions","organizations_url":"https://api.github.com/users/steveerfalot/orgs","repos_url":"https://api.github.com/users/steveerfalot/repos","events_url":"https://api.github.com/users/steveerfalot/events{/privacy}","received_events_url":"https://api.github.com/users/steveerfalot/received_events","type":"User","site_admin":false},"repo":{"id":73333162,"name":"novo-elements","full_name":"steveerfalot/novo-elements","owner":{"login":"steveerfalot","id":6993848,"avatar_url":"https://avatars.githubusercontent.com/u/6993848?v=3","gravatar_id":"","url":"https://api.github.com/users/steveerfalot","html_url":"https://github.com/steveerfalot","followers_url":"https://api.github.com/users/steveerfalot/followers","following_url":"https://api.github.com/users/steveerfalot/following{/other_user}","gists_url":"https://api.github.com/users/steveerfalot/gists{/gist_id}","starred_url":"https://api.github.com/users/steveerfalot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveerfalot/subscriptions","organizations_url":"https://api.github.com/users/steveerfalot/orgs","repos_url":"https://api.github.com/users/steveerfalot/repos","events_url":"https://api.github.com/users/steveerfalot/events{/privacy}","received_events_url":"https://api.github.com/users/steveerfalot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/steveerfalot/novo-elements","description":"UI Repository for Bullhorn's Novo Theme","fork":true,"url":"https://api.github.com/repos/steveerfalot/novo-elements","forks_url":"https://api.github.com/repos/steveerfalot/novo-elements/forks","keys_url":"https://api.github.com/repos/steveerfalot/novo-elements/keys{/key_id}","collaborators_url":"https://api.github.com/repos/steveerfalot/novo-elements/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/steveerfalot/novo-elements/teams","hooks_url":"https://api.github.com/repos/steveerfalot/novo-elements/hooks","issue_events_url":"https://api.github.com/repos/steveerfalot/novo-elements/issues/events{/number}","events_url":"https://api.github.com/repos/steveerfalot/novo-elements/events","assignees_url":"https://api.github.com/repos/steveerfalot/novo-elements/assignees{/user}","branches_url":"https://api.github.com/repos/steveerfalot/novo-elements/branches{/branch}","tags_url":"https://api.github.com/repos/steveerfalot/novo-elements/tags","blobs_url":"https://api.github.com/repos/steveerfalot/novo-elements/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/steveerfalot/novo-elements/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/steveerfalot/novo-elements/git/refs{/sha}","trees_url":"https://api.github.com/repos/steveerfalot/novo-elements/git/trees{/sha}","statuses_url":"https://api.github.com/repos/steveerfalot/novo-elements/statuses/{sha}","languages_url":"https://api.github.com/repos/steveerfalot/novo-elements/languages","stargazers_url":"https://api.github.com/repos/steveerfalot/novo-elements/stargazers","contributors_url":"https://api.github.com/repos/steveerfalot/novo-elements/contributors","subscribers_url":"https://api.github.com/repos/steveerfalot/novo-elements/subscribers","subscription_url":"https://api.github.com/repos/steveerfalot/novo-elements/subscription","commits_url":"https://api.github.com/repos/steveerfalot/novo-elements/commits{/sha}","git_commits_url":"https://api.github.com/repos/steveerfalot/novo-elements/git/commits{/sha}","comments_url":"https://api.github.com/repos/steveerfalot/novo-elements/comments{/number}","issue_comment_url":"https://api.github.com/repos/steveerfalot/novo-elements/issues/comments{/number}","contents_url":"https://api.github.com/repos/steveerfalot/novo-elements/contents/{+path}","compare_url":"https://api.github.com/repos/steveerfalot/novo-elements/compare/{base}...{head}","merges_url":"https://api.github.com/repos/steveerfalot/novo-elements/merges","archive_url":"https://api.github.com/repos/steveerfalot/novo-elements/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/steveerfalot/novo-elements/downloads","issues_url":"https://api.github.com/repos/steveerfalot/novo-elements/issues{/number}","pulls_url":"https://api.github.com/repos/steveerfalot/novo-elements/pulls{/number}","milestones_url":"https://api.github.com/repos/steveerfalot/novo-elements/milestones{/number}","notifications_url":"https://api.github.com/repos/steveerfalot/novo-elements/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/steveerfalot/novo-elements/labels{/name}","releases_url":"https://api.github.com/repos/steveerfalot/novo-elements/releases{/id}","deployments_url":"https://api.github.com/repos/steveerfalot/novo-elements/deployments","created_at":"2016-11-10T00:35:03Z","updated_at":"2016-11-10T00:35:05Z","pushed_at":"2016-11-14T17:05:35Z","git_url":"git://github.com/steveerfalot/novo-elements.git","ssh_url":"git@github.com:steveerfalot/novo-elements.git","clone_url":"https://github.com/steveerfalot/novo-elements.git","svn_url":"https://github.com/steveerfalot/novo-elements","homepage":"http://bullhorn.github.io/novo-elements","size":95670,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bullhorn:master","ref":"master","sha":"fd680b652273ef92478070a1ccabc81752f07034","user":{"login":"bullhorn","id":4107582,"avatar_url":"https://avatars.githubusercontent.com/u/4107582?v=3","gravatar_id":"","url":"https://api.github.com/users/bullhorn","html_url":"https://github.com/bullhorn","followers_url":"https://api.github.com/users/bullhorn/followers","following_url":"https://api.github.com/users/bullhorn/following{/other_user}","gists_url":"https://api.github.com/users/bullhorn/gists{/gist_id}","starred_url":"https://api.github.com/users/bullhorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bullhorn/subscriptions","organizations_url":"https://api.github.com/users/bullhorn/orgs","repos_url":"https://api.github.com/users/bullhorn/repos","events_url":"https://api.github.com/users/bullhorn/events{/privacy}","received_events_url":"https://api.github.com/users/bullhorn/received_events","type":"Organization","site_admin":false},"repo":{"id":56453136,"name":"novo-elements","full_name":"bullhorn/novo-elements","owner":{"login":"bullhorn","id":4107582,"avatar_url":"https://avatars.githubusercontent.com/u/4107582?v=3","gravatar_id":"","url":"https://api.github.com/users/bullhorn","html_url":"https://github.com/bullhorn","followers_url":"https://api.github.com/users/bullhorn/followers","following_url":"https://api.github.com/users/bullhorn/following{/other_user}","gists_url":"https://api.github.com/users/bullhorn/gists{/gist_id}","starred_url":"https://api.github.com/users/bullhorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bullhorn/subscriptions","organizations_url":"https://api.github.com/users/bullhorn/orgs","repos_url":"https://api.github.com/users/bullhorn/repos","events_url":"https://api.github.com/users/bullhorn/events{/privacy}","received_events_url":"https://api.github.com/users/bullhorn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bullhorn/novo-elements","description":"UI Repository for Bullhorn's Novo Theme","fork":false,"url":"https://api.github.com/repos/bullhorn/novo-elements","forks_url":"https://api.github.com/repos/bullhorn/novo-elements/forks","keys_url":"https://api.github.com/repos/bullhorn/novo-elements/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bullhorn/novo-elements/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bullhorn/novo-elements/teams","hooks_url":"https://api.github.com/repos/bullhorn/novo-elements/hooks","issue_events_url":"https://api.github.com/repos/bullhorn/novo-elements/issues/events{/number}","events_url":"https://api.github.com/repos/bullhorn/novo-elements/events","assignees_url":"https://api.github.com/repos/bullhorn/novo-elements/assignees{/user}","branches_url":"https://api.github.com/repos/bullhorn/novo-elements/branches{/branch}","tags_url":"https://api.github.com/repos/bullhorn/novo-elements/tags","blobs_url":"https://api.github.com/repos/bullhorn/novo-elements/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bullhorn/novo-elements/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bullhorn/novo-elements/git/refs{/sha}","trees_url":"https://api.github.com/repos/bullhorn/novo-elements/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bullhorn/novo-elements/statuses/{sha}","languages_url":"https://api.github.com/repos/bullhorn/novo-elements/languages","stargazers_url":"https://api.github.com/repos/bullhorn/novo-elements/stargazers","contributors_url":"https://api.github.com/repos/bullhorn/novo-elements/contributors","subscribers_url":"https://api.github.com/repos/bullhorn/novo-elements/subscribers","subscription_url":"https://api.github.com/repos/bullhorn/novo-elements/subscription","commits_url":"https://api.github.com/repos/bullhorn/novo-elements/commits{/sha}","git_commits_url":"https://api.github.com/repos/bullhorn/novo-elements/git/commits{/sha}","comments_url":"https://api.github.com/repos/bullhorn/novo-elements/comments{/number}","issue_comment_url":"https://api.github.com/repos/bullhorn/novo-elements/issues/comments{/number}","contents_url":"https://api.github.com/repos/bullhorn/novo-elements/contents/{+path}","compare_url":"https://api.github.com/repos/bullhorn/novo-elements/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bullhorn/novo-elements/merges","archive_url":"https://api.github.com/repos/bullhorn/novo-elements/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bullhorn/novo-elements/downloads","issues_url":"https://api.github.com/repos/bullhorn/novo-elements/issues{/number}","pulls_url":"https://api.github.com/repos/bullhorn/novo-elements/pulls{/number}","milestones_url":"https://api.github.com/repos/bullhorn/novo-elements/milestones{/number}","notifications_url":"https://api.github.com/repos/bullhorn/novo-elements/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bullhorn/novo-elements/labels{/name}","releases_url":"https://api.github.com/repos/bullhorn/novo-elements/releases{/id}","deployments_url":"https://api.github.com/repos/bullhorn/novo-elements/deployments","created_at":"2016-04-17T19:00:11Z","updated_at":"2016-10-24T15:42:39Z","pushed_at":"2016-11-14T17:08:54Z","git_url":"git://github.com/bullhorn/novo-elements.git","ssh_url":"git@github.com:bullhorn/novo-elements.git","clone_url":"https://github.com/bullhorn/novo-elements.git","svn_url":"https://github.com/bullhorn/novo-elements","homepage":"http://bullhorn.github.io/novo-elements","size":8527,"stargazers_count":24,"watchers_count":24,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":7,"mirror_url":null,"open_issues_count":23,"forks":7,"open_issues":23,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bullhorn/novo-elements/pulls/246"},"html":{"href":"https://github.com/bullhorn/novo-elements/pull/246"},"issue":{"href":"https://api.github.com/repos/bullhorn/novo-elements/issues/246"},"comments":{"href":"https://api.github.com/repos/bullhorn/novo-elements/issues/246/comments"},"review_comments":{"href":"https://api.github.com/repos/bullhorn/novo-elements/pulls/246/comments"},"review_comment":{"href":"https://api.github.com/repos/bullhorn/novo-elements/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bullhorn/novo-elements/pulls/246/commits"},"statuses":{"href":"https://api.github.com/repos/bullhorn/novo-elements/statuses/5f053407af358c02c68192e307f539530854d726"}}}}
{"actor":{"display_login":"steveerfalot"}}