{"action":"created","issue":{"url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/issues/826","repository_url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin","labels_url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/issues/826/labels{/name}","comments_url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/issues/826/comments","events_url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/issues/826/events","html_url":"https://github.com/thaliproject/Thali_CordovaPlugin/pull/826","id":169118554,"number":826,"title":"#819 added basic AppContext functions","user":{"login":"baydet","id":1755124,"avatar_url":"https://avatars.githubusercontent.com/u/1755124?v=3","gravatar_id":"","url":"https://api.github.com/users/baydet","html_url":"https://github.com/baydet","followers_url":"https://api.github.com/users/baydet/followers","following_url":"https://api.github.com/users/baydet/following{/other_user}","gists_url":"https://api.github.com/users/baydet/gists{/gist_id}","starred_url":"https://api.github.com/users/baydet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baydet/subscriptions","organizations_url":"https://api.github.com/users/baydet/orgs","repos_url":"https://api.github.com/users/baydet/repos","events_url":"https://api.github.com/users/baydet/events{/privacy}","received_events_url":"https://api.github.com/users/baydet/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/labels/3%20-%20Working","name":"3 - Working","color":"CCCCCC"},{"url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"baydet","id":1755124,"avatar_url":"https://avatars.githubusercontent.com/u/1755124?v=3","gravatar_id":"","url":"https://api.github.com/users/baydet","html_url":"https://github.com/baydet","followers_url":"https://api.github.com/users/baydet/followers","following_url":"https://api.github.com/users/baydet/following{/other_user}","gists_url":"https://api.github.com/users/baydet/gists{/gist_id}","starred_url":"https://api.github.com/users/baydet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baydet/subscriptions","organizations_url":"https://api.github.com/users/baydet/orgs","repos_url":"https://api.github.com/users/baydet/repos","events_url":"https://api.github.com/users/baydet/events{/privacy}","received_events_url":"https://api.github.com/users/baydet/received_events","type":"User","site_admin":false},"assignees":[{"login":"baydet","id":1755124,"avatar_url":"https://avatars.githubusercontent.com/u/1755124?v=3","gravatar_id":"","url":"https://api.github.com/users/baydet","html_url":"https://github.com/baydet","followers_url":"https://api.github.com/users/baydet/followers","following_url":"https://api.github.com/users/baydet/following{/other_user}","gists_url":"https://api.github.com/users/baydet/gists{/gist_id}","starred_url":"https://api.github.com/users/baydet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baydet/subscriptions","organizations_url":"https://api.github.com/users/baydet/orgs","repos_url":"https://api.github.com/users/baydet/repos","events_url":"https://api.github.com/users/baydet/events{/privacy}","received_events_url":"https://api.github.com/users/baydet/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/milestones/7","html_url":"https://github.com/thaliproject/Thali_CordovaPlugin/milestones/New%20Infra","labels_url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/milestones/7/labels","id":1498038,"number":7,"title":"New Infra","description":"This will be the first release of the new infrastructure working end to end.\r\n\r\n<!---\r\n@huboard:{\"order\":0.25}\r\n-->\r\n","creator":{"login":"yaronyg","id":1480964,"avatar_url":"https://avatars.githubusercontent.com/u/1480964?v=3","gravatar_id":"","url":"https://api.github.com/users/yaronyg","html_url":"https://github.com/yaronyg","followers_url":"https://api.github.com/users/yaronyg/followers","following_url":"https://api.github.com/users/yaronyg/following{/other_user}","gists_url":"https://api.github.com/users/yaronyg/gists{/gist_id}","starred_url":"https://api.github.com/users/yaronyg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaronyg/subscriptions","organizations_url":"https://api.github.com/users/yaronyg/orgs","repos_url":"https://api.github.com/users/yaronyg/repos","events_url":"https://api.github.com/users/yaronyg/events{/privacy}","received_events_url":"https://api.github.com/users/yaronyg/received_events","type":"User","site_admin":false},"open_issues":59,"closed_issues":210,"state":"open","created_at":"2016-01-11T19:12:00Z","updated_at":"2016-08-03T23:15:27Z","due_on":null,"closed_at":null},"comments":8,"created_at":"2016-08-03T12:23:09Z","updated_at":"2016-08-04T08:33:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/pulls/826","html_url":"https://github.com/thaliproject/Thali_CordovaPlugin/pull/826","diff_url":"https://github.com/thaliproject/Thali_CordovaPlugin/pull/826.diff","patch_url":"https://github.com/thaliproject/Thali_CordovaPlugin/pull/826.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/thaliproject/thali_cordovaplugin/826)\n<!-- Reviewable:end -->\n\r\n\r\n<!---\r\n@huboard:{\"order\":2.978481955667248e-08,\"milestone_order\":826.0,\"custom_state\":\"\"}\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/issues/comments/237488746","html_url":"https://github.com/thaliproject/Thali_CordovaPlugin/pull/826#issuecomment-237488746","issue_url":"https://api.github.com/repos/thaliproject/Thali_CordovaPlugin/issues/826","id":237488746,"user":{"login":"baydet","id":1755124,"avatar_url":"https://avatars.githubusercontent.com/u/1755124?v=3","gravatar_id":"","url":"https://api.github.com/users/baydet","html_url":"https://github.com/baydet","followers_url":"https://api.github.com/users/baydet/followers","following_url":"https://api.github.com/users/baydet/following{/other_user}","gists_url":"https://api.github.com/users/baydet/gists{/gist_id}","starred_url":"https://api.github.com/users/baydet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baydet/subscriptions","organizations_url":"https://api.github.com/users/baydet/orgs","repos_url":"https://api.github.com/users/baydet/repos","events_url":"https://api.github.com/users/baydet/events{/privacy}","received_events_url":"https://api.github.com/users/baydet/received_events","type":"User","site_admin":false},"created_at":"2016-08-04T08:33:55Z","updated_at":"2016-08-04T08:33:55Z","body":"\n\n\n\nReview status: all files reviewed at latest revision, 8 unresolved discussions, some commit checks failed.\n\n---\n\n*[lib/ios/ThaliCore/ThaliCore/Core/AppContext.swift, line 48 \\[r1\\]](https://reviewable.io:443/reviews/thaliproject/thali_cordovaplugin/826#-KOIUDvuZhYwsbJiP0k4:-KOJcfSHCF3XDGS0pToK:-934271718) ([raw file](https://github.com/thaliproject/thali_cordovaplugin/blob/2bc7db9d715fb974ee7a199e839ea36f6945ec1b/lib/ios/ThaliCore/ThaliCore/Core/AppContext.swift#L48)):*\n<details><summary><i>Previously, yaronyg (Yaron Y Goland) wrote…</i></summary>\n> Instead of passing in String : AnyObject since eventually all of these objects have expected types, can we define the Swift file to expect the expected types for each API directly and then let those types be marshalled in the JXCoreExtension.m file?\n</details>\nI would like to replace [String  : AnyObject] with some kind of [NetworkStatusOption : Status] where NetworkStatusOption and Status are enums with String raw value. But the problem is that these enums will not be visible in objective-c. And that is the problem if we want to keep JXcoreExtension in objC. \nAlso I think that we shouldn't make a lot of complex logic in JXCoreExtension extension because this logic sits outside of our Core library. It means it will not be covered with unit testing.\nTo make this code more type constrained I can replace [String  : AnyObject] with [String  : String].\n\n---\n\n*[lib/ios/ThaliCore/ThaliCore/Core/AppContext.swift, line 174 \\[r1\\]](https://reviewable.io:443/reviews/thaliproject/thali_cordovaplugin/826#-KOIV4ngfkyKIMjuHc1J:-KOJaw1h_673wCsgKHT4:-96045042) ([raw file](https://github.com/thaliproject/thali_cordovaplugin/blob/2bc7db9d715fb974ee7a199e839ea36f6945ec1b/lib/ios/ThaliCore/ThaliCore/Core/AppContext.swift#L174)):*\n<details><summary><i>Previously, yaronyg (Yaron Y Goland) wrote…</i></summary>\n> Does this function have a purpose anymore?\n</details>\nIn the current version this function is used once on didRegisterToNative. It fired `AppContextDelegate`'s `networkStatusChanged` call. We could resolve this by replacing this function with readonly variable `networkStatus` and and call `networkChanged` implicitly  \n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/thaliproject/thali_cordovaplugin/826)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"baydet"}}