{"action":"created","comment":{"url":"https://api.github.com/repos/snare/voltron/pulls/comments/77441142","id":77441142,"diff_hunk":"@@ -85,13 +88,21 @@ def render(self, results):\n                     chunk = m_res.memory[c:c + self.args.bytes]\n                     addr_str = self.colour(self.format_address(m_res.address + c, size=target['addr_size'], pad=False),\n                                            self.config.format.addr_colour)\n+\n+                    if self.args.track and self.last_memory and self.last_address == m_res.address:\n+                        bytes = []\n+                        for i, x in enumerate(six.iterbytes(chunk)):\n+                            if x != self.last_memory[c + i]:\n+                                bytes.append(self.colour(\"%02X\" % x, 'red'))","path":"voltron/plugins/view/memory.py","position":26,"original_position":26,"commit_id":"4e497b7776545dddb4090aac1b02f06d191bb6a5","original_commit_id":"4e497b7776545dddb4090aac1b02f06d191bb6a5","user":{"login":"Grazfather","id":497310,"avatar_url":"https://avatars.githubusercontent.com/u/497310?v=3","gravatar_id":"","url":"https://api.github.com/users/Grazfather","html_url":"https://github.com/Grazfather","followers_url":"https://api.github.com/users/Grazfather/followers","following_url":"https://api.github.com/users/Grazfather/following{/other_user}","gists_url":"https://api.github.com/users/Grazfather/gists{/gist_id}","starred_url":"https://api.github.com/users/Grazfather/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Grazfather/subscriptions","organizations_url":"https://api.github.com/users/Grazfather/orgs","repos_url":"https://api.github.com/users/Grazfather/repos","events_url":"https://api.github.com/users/Grazfather/events{/privacy}","received_events_url":"https://api.github.com/users/Grazfather/received_events","type":"User","site_admin":false},"body":"Could use a configuration colour here, but the one used in the registers view for tracking changes didn't seem to work here for some reason.","created_at":"2016-09-03T18:32:24Z","updated_at":"2016-09-03T18:32:24Z","html_url":"https://github.com/snare/voltron/pull/168#discussion_r77441142","pull_request_url":"https://api.github.com/repos/snare/voltron/pulls/168","_links":{"self":{"href":"https://api.github.com/repos/snare/voltron/pulls/comments/77441142"},"html":{"href":"https://github.com/snare/voltron/pull/168#discussion_r77441142"},"pull_request":{"href":"https://api.github.com/repos/snare/voltron/pulls/168"}}},"pull_request":{"url":"https://api.github.com/repos/snare/voltron/pulls/168","id":83902382,"html_url":"https://github.com/snare/voltron/pull/168","diff_url":"https://github.com/snare/voltron/pull/168.diff","patch_url":"https://github.com/snare/voltron/pull/168.patch","issue_url":"https://api.github.com/repos/snare/voltron/issues/168","number":168,"state":"open","locked":false,"title":"Add option to track and highlight memory changes","user":{"login":"Grazfather","id":497310,"avatar_url":"https://avatars.githubusercontent.com/u/497310?v=3","gravatar_id":"","url":"https://api.github.com/users/Grazfather","html_url":"https://github.com/Grazfather","followers_url":"https://api.github.com/users/Grazfather/followers","following_url":"https://api.github.com/users/Grazfather/following{/other_user}","gists_url":"https://api.github.com/users/Grazfather/gists{/gist_id}","starred_url":"https://api.github.com/users/Grazfather/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Grazfather/subscriptions","organizations_url":"https://api.github.com/users/Grazfather/orgs","repos_url":"https://api.github.com/users/Grazfather/repos","events_url":"https://api.github.com/users/Grazfather/events{/privacy}","received_events_url":"https://api.github.com/users/Grazfather/received_events","type":"User","site_admin":false},"body":"Implements #167.\r\n\r\nNote that this could be improved: I basically won't highlight if the address jumps around (e.g. using `-r`. We could figure out if the new address buf overlaps the previous (even if the start changed) and maintain our highlights, but I don't think it's worth it.\r\n\r\nI can get this to _crash_ if I shrink the window, hit a BP, and then grow the window and hit another. This is because this causes an `IndexError` when the cache is checked beyond its old capacity.","created_at":"2016-09-03T18:27:41Z","updated_at":"2016-09-03T18:32:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f91c5dca3319b7b8b18a59b5685f57caf22d876b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/snare/voltron/pulls/168/commits","review_comments_url":"https://api.github.com/repos/snare/voltron/pulls/168/comments","review_comment_url":"https://api.github.com/repos/snare/voltron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snare/voltron/issues/168/comments","statuses_url":"https://api.github.com/repos/snare/voltron/statuses/4e497b7776545dddb4090aac1b02f06d191bb6a5","head":{"label":"Grazfather:track_memory","ref":"track_memory","sha":"4e497b7776545dddb4090aac1b02f06d191bb6a5","user":{"login":"Grazfather","id":497310,"avatar_url":"https://avatars.githubusercontent.com/u/497310?v=3","gravatar_id":"","url":"https://api.github.com/users/Grazfather","html_url":"https://github.com/Grazfather","followers_url":"https://api.github.com/users/Grazfather/followers","following_url":"https://api.github.com/users/Grazfather/following{/other_user}","gists_url":"https://api.github.com/users/Grazfather/gists{/gist_id}","starred_url":"https://api.github.com/users/Grazfather/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Grazfather/subscriptions","organizations_url":"https://api.github.com/users/Grazfather/orgs","repos_url":"https://api.github.com/users/Grazfather/repos","events_url":"https://api.github.com/users/Grazfather/events{/privacy}","received_events_url":"https://api.github.com/users/Grazfather/received_events","type":"User","site_admin":false},"repo":{"id":67079217,"name":"voltron","full_name":"Grazfather/voltron","owner":{"login":"Grazfather","id":497310,"avatar_url":"https://avatars.githubusercontent.com/u/497310?v=3","gravatar_id":"","url":"https://api.github.com/users/Grazfather","html_url":"https://github.com/Grazfather","followers_url":"https://api.github.com/users/Grazfather/followers","following_url":"https://api.github.com/users/Grazfather/following{/other_user}","gists_url":"https://api.github.com/users/Grazfather/gists{/gist_id}","starred_url":"https://api.github.com/users/Grazfather/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Grazfather/subscriptions","organizations_url":"https://api.github.com/users/Grazfather/orgs","repos_url":"https://api.github.com/users/Grazfather/repos","events_url":"https://api.github.com/users/Grazfather/events{/privacy}","received_events_url":"https://api.github.com/users/Grazfather/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Grazfather/voltron","description":"A hacky debugger UI for hackers","fork":true,"url":"https://api.github.com/repos/Grazfather/voltron","forks_url":"https://api.github.com/repos/Grazfather/voltron/forks","keys_url":"https://api.github.com/repos/Grazfather/voltron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Grazfather/voltron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Grazfather/voltron/teams","hooks_url":"https://api.github.com/repos/Grazfather/voltron/hooks","issue_events_url":"https://api.github.com/repos/Grazfather/voltron/issues/events{/number}","events_url":"https://api.github.com/repos/Grazfather/voltron/events","assignees_url":"https://api.github.com/repos/Grazfather/voltron/assignees{/user}","branches_url":"https://api.github.com/repos/Grazfather/voltron/branches{/branch}","tags_url":"https://api.github.com/repos/Grazfather/voltron/tags","blobs_url":"https://api.github.com/repos/Grazfather/voltron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Grazfather/voltron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Grazfather/voltron/git/refs{/sha}","trees_url":"https://api.github.com/repos/Grazfather/voltron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Grazfather/voltron/statuses/{sha}","languages_url":"https://api.github.com/repos/Grazfather/voltron/languages","stargazers_url":"https://api.github.com/repos/Grazfather/voltron/stargazers","contributors_url":"https://api.github.com/repos/Grazfather/voltron/contributors","subscribers_url":"https://api.github.com/repos/Grazfather/voltron/subscribers","subscription_url":"https://api.github.com/repos/Grazfather/voltron/subscription","commits_url":"https://api.github.com/repos/Grazfather/voltron/commits{/sha}","git_commits_url":"https://api.github.com/repos/Grazfather/voltron/git/commits{/sha}","comments_url":"https://api.github.com/repos/Grazfather/voltron/comments{/number}","issue_comment_url":"https://api.github.com/repos/Grazfather/voltron/issues/comments{/number}","contents_url":"https://api.github.com/repos/Grazfather/voltron/contents/{+path}","compare_url":"https://api.github.com/repos/Grazfather/voltron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Grazfather/voltron/merges","archive_url":"https://api.github.com/repos/Grazfather/voltron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Grazfather/voltron/downloads","issues_url":"https://api.github.com/repos/Grazfather/voltron/issues{/number}","pulls_url":"https://api.github.com/repos/Grazfather/voltron/pulls{/number}","milestones_url":"https://api.github.com/repos/Grazfather/voltron/milestones{/number}","notifications_url":"https://api.github.com/repos/Grazfather/voltron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Grazfather/voltron/labels{/name}","releases_url":"https://api.github.com/repos/Grazfather/voltron/releases{/id}","deployments_url":"https://api.github.com/repos/Grazfather/voltron/deployments","created_at":"2016-08-31T22:53:24Z","updated_at":"2016-08-31T22:53:25Z","pushed_at":"2016-09-03T18:23:40Z","git_url":"git://github.com/Grazfather/voltron.git","ssh_url":"git@github.com:Grazfather/voltron.git","clone_url":"https://github.com/Grazfather/voltron.git","svn_url":"https://github.com/Grazfather/voltron","homepage":"","size":1582,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"snare:master","ref":"master","sha":"6ad541787885021dd752834005c06d961d56c968","user":{"login":"snare","id":504561,"avatar_url":"https://avatars.githubusercontent.com/u/504561?v=3","gravatar_id":"","url":"https://api.github.com/users/snare","html_url":"https://github.com/snare","followers_url":"https://api.github.com/users/snare/followers","following_url":"https://api.github.com/users/snare/following{/other_user}","gists_url":"https://api.github.com/users/snare/gists{/gist_id}","starred_url":"https://api.github.com/users/snare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snare/subscriptions","organizations_url":"https://api.github.com/users/snare/orgs","repos_url":"https://api.github.com/users/snare/repos","events_url":"https://api.github.com/users/snare/events{/privacy}","received_events_url":"https://api.github.com/users/snare/received_events","type":"User","site_admin":false},"repo":{"id":10934235,"name":"voltron","full_name":"snare/voltron","owner":{"login":"snare","id":504561,"avatar_url":"https://avatars.githubusercontent.com/u/504561?v=3","gravatar_id":"","url":"https://api.github.com/users/snare","html_url":"https://github.com/snare","followers_url":"https://api.github.com/users/snare/followers","following_url":"https://api.github.com/users/snare/following{/other_user}","gists_url":"https://api.github.com/users/snare/gists{/gist_id}","starred_url":"https://api.github.com/users/snare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snare/subscriptions","organizations_url":"https://api.github.com/users/snare/orgs","repos_url":"https://api.github.com/users/snare/repos","events_url":"https://api.github.com/users/snare/events{/privacy}","received_events_url":"https://api.github.com/users/snare/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/snare/voltron","description":"A hacky debugger UI for hackers","fork":false,"url":"https://api.github.com/repos/snare/voltron","forks_url":"https://api.github.com/repos/snare/voltron/forks","keys_url":"https://api.github.com/repos/snare/voltron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snare/voltron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snare/voltron/teams","hooks_url":"https://api.github.com/repos/snare/voltron/hooks","issue_events_url":"https://api.github.com/repos/snare/voltron/issues/events{/number}","events_url":"https://api.github.com/repos/snare/voltron/events","assignees_url":"https://api.github.com/repos/snare/voltron/assignees{/user}","branches_url":"https://api.github.com/repos/snare/voltron/branches{/branch}","tags_url":"https://api.github.com/repos/snare/voltron/tags","blobs_url":"https://api.github.com/repos/snare/voltron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snare/voltron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snare/voltron/git/refs{/sha}","trees_url":"https://api.github.com/repos/snare/voltron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snare/voltron/statuses/{sha}","languages_url":"https://api.github.com/repos/snare/voltron/languages","stargazers_url":"https://api.github.com/repos/snare/voltron/stargazers","contributors_url":"https://api.github.com/repos/snare/voltron/contributors","subscribers_url":"https://api.github.com/repos/snare/voltron/subscribers","subscription_url":"https://api.github.com/repos/snare/voltron/subscription","commits_url":"https://api.github.com/repos/snare/voltron/commits{/sha}","git_commits_url":"https://api.github.com/repos/snare/voltron/git/commits{/sha}","comments_url":"https://api.github.com/repos/snare/voltron/comments{/number}","issue_comment_url":"https://api.github.com/repos/snare/voltron/issues/comments{/number}","contents_url":"https://api.github.com/repos/snare/voltron/contents/{+path}","compare_url":"https://api.github.com/repos/snare/voltron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snare/voltron/merges","archive_url":"https://api.github.com/repos/snare/voltron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snare/voltron/downloads","issues_url":"https://api.github.com/repos/snare/voltron/issues{/number}","pulls_url":"https://api.github.com/repos/snare/voltron/pulls{/number}","milestones_url":"https://api.github.com/repos/snare/voltron/milestones{/number}","notifications_url":"https://api.github.com/repos/snare/voltron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snare/voltron/labels{/name}","releases_url":"https://api.github.com/repos/snare/voltron/releases{/id}","deployments_url":"https://api.github.com/repos/snare/voltron/deployments","created_at":"2013-06-25T09:32:23Z","updated_at":"2016-09-03T14:34:19Z","pushed_at":"2016-09-03T18:27:41Z","git_url":"git://github.com/snare/voltron.git","ssh_url":"git@github.com:snare/voltron.git","clone_url":"https://github.com/snare/voltron.git","svn_url":"https://github.com/snare/voltron","homepage":"","size":1924,"stargazers_count":3338,"watchers_count":3338,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":177,"mirror_url":null,"open_issues_count":25,"forks":177,"open_issues":25,"watchers":3338,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snare/voltron/pulls/168"},"html":{"href":"https://github.com/snare/voltron/pull/168"},"issue":{"href":"https://api.github.com/repos/snare/voltron/issues/168"},"comments":{"href":"https://api.github.com/repos/snare/voltron/issues/168/comments"},"review_comments":{"href":"https://api.github.com/repos/snare/voltron/pulls/168/comments"},"review_comment":{"href":"https://api.github.com/repos/snare/voltron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snare/voltron/pulls/168/commits"},"statuses":{"href":"https://api.github.com/repos/snare/voltron/statuses/4e497b7776545dddb4090aac1b02f06d191bb6a5"}}}}
{"actor":{"display_login":"Grazfather"}}