{"action":"created","issue":{"url":"https://api.github.com/repos/jviereck/regjsparser/issues/78","repository_url":"https://api.github.com/repos/jviereck/regjsparser","labels_url":"https://api.github.com/repos/jviereck/regjsparser/issues/78/labels{/name}","comments_url":"https://api.github.com/repos/jviereck/regjsparser/issues/78/comments","events_url":"https://api.github.com/repos/jviereck/regjsparser/issues/78/events","html_url":"https://github.com/jviereck/regjsparser/pull/78","id":155947927,"number":78,"title":"Parse \\p{…} and \\P{…} in Unicode mode","user":{"login":"mathiasbynens","id":81942,"avatar_url":"https://avatars.githubusercontent.com/u/81942?v=3","gravatar_id":"","url":"https://api.github.com/users/mathiasbynens","html_url":"https://github.com/mathiasbynens","followers_url":"https://api.github.com/users/mathiasbynens/followers","following_url":"https://api.github.com/users/mathiasbynens/following{/other_user}","gists_url":"https://api.github.com/users/mathiasbynens/gists{/gist_id}","starred_url":"https://api.github.com/users/mathiasbynens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathiasbynens/subscriptions","organizations_url":"https://api.github.com/users/mathiasbynens/orgs","repos_url":"https://api.github.com/users/mathiasbynens/repos","events_url":"https://api.github.com/users/mathiasbynens/events{/privacy}","received_events_url":"https://api.github.com/users/mathiasbynens/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-05-20T12:02:18Z","updated_at":"2016-05-22T19:10:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jviereck/regjsparser/pulls/78","html_url":"https://github.com/jviereck/regjsparser/pull/78","diff_url":"https://github.com/jviereck/regjsparser/pull/78.diff","patch_url":"https://github.com/jviereck/regjsparser/pull/78.patch"},"body":"Ref. #77."},"comment":{"url":"https://api.github.com/repos/jviereck/regjsparser/issues/comments/220850082","html_url":"https://github.com/jviereck/regjsparser/pull/78#issuecomment-220850082","issue_url":"https://api.github.com/repos/jviereck/regjsparser/issues/78","id":220850082,"user":{"login":"jviereck","id":191719,"avatar_url":"https://avatars.githubusercontent.com/u/191719?v=3","gravatar_id":"","url":"https://api.github.com/users/jviereck","html_url":"https://github.com/jviereck","followers_url":"https://api.github.com/users/jviereck/followers","following_url":"https://api.github.com/users/jviereck/following{/other_user}","gists_url":"https://api.github.com/users/jviereck/gists{/gist_id}","starred_url":"https://api.github.com/users/jviereck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jviereck/subscriptions","organizations_url":"https://api.github.com/users/jviereck/orgs","repos_url":"https://api.github.com/users/jviereck/repos","events_url":"https://api.github.com/users/jviereck/events{/privacy}","received_events_url":"https://api.github.com/users/jviereck/received_events","type":"User","site_admin":false},"created_at":"2016-05-22T19:10:26Z","updated_at":"2016-05-22T19:10:26Z","body":"Thanks for providing this PR!\r\n\r\n>       } else if (isExperimental && hasUnicodeFlag && (res = matchReg(/^([pP])\\{([^\\}]+)\\}/))) {\r\n\r\nIs that part of the spec, that this feature only becomes active when the unicode flag is set? (Did not read it, just wondering if having this implicit dependency is a good idea / necessary)\r\n\r\nBeside this, the implementation LGTM. I am wondering more what's the best way to support the `{ experimental: true }` of the current PR.\r\n\r\nAdding a third argument to `regjsparser.parse` is good in my opinion. However, I would prefer a solution that scales better. More precise: if another features/experiment comes along, that we don't have to start numbering them as `{ experimental_2: true }`. \r\n\r\nTherefore, how about making the third argument to `regjsparser.parse` a general 'feature' argument? This could then look like `regjsparser.parse(pattern, flags, { unicodePropertyEscape: true })`. Also, this would allow to enable a group-toggle: Assume your proposal gets shipped in ES2018, another feature gets implemented in ES2019 and developers want to activate all features that ship until ES2019, then they could call `regjsparser.parse(pattern, flags, 'es2019')`. (I hope you get the idea).\r\n\r\n@mathiasbynens, what do you think?\r\n\r\nPS: An orthogonal way to your PR would be to extend `regjsparser` by a plugin system (maybe similar to the babel.js parser). Though, I doubt the complexity of introducing/maintaining a plugin system is worth it. In case more features boil up over the next years, we might want to revisit this point, but let's keep things simple for now and add features/experiments/extensions into the codebase directly.\r\n\r\n\r\n"}}
{"actor":{"display_login":"jviereck"}}