{"action":"opened","number":5095,"pull_request":{"url":"https://api.github.com/repos/electron/electron/pulls/5095","id":65840344,"html_url":"https://github.com/electron/electron/pull/5095","diff_url":"https://github.com/electron/electron/pull/5095.diff","patch_url":"https://github.com/electron/electron/pull/5095.patch","issue_url":"https://api.github.com/repos/electron/electron/issues/5095","number":5095,"state":"open","locked":false,"title":"Add `resourceType` to `did-get-response-details` event on WebContents/WebView","user":{"login":"Mr0grog","id":74178,"avatar_url":"https://avatars.githubusercontent.com/u/74178?v=3","gravatar_id":"","url":"https://api.github.com/users/Mr0grog","html_url":"https://github.com/Mr0grog","followers_url":"https://api.github.com/users/Mr0grog/followers","following_url":"https://api.github.com/users/Mr0grog/following{/other_user}","gists_url":"https://api.github.com/users/Mr0grog/gists{/gist_id}","starred_url":"https://api.github.com/users/Mr0grog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mr0grog/subscriptions","organizations_url":"https://api.github.com/users/Mr0grog/orgs","repos_url":"https://api.github.com/users/Mr0grog/repos","events_url":"https://api.github.com/users/Mr0grog/events{/privacy}","received_events_url":"https://api.github.com/users/Mr0grog/received_events","type":"User","site_admin":false},"body":"This resolves #5074 by adding `resourceType` as the last argument for WebContents’s `did-get-response-details` event.\r\n\r\nIn order to do this without duplicating the string conversion logic from `atom_network_delegate`, the `ResourceTypeToString()` function is moved to the `atom` namespace and is exposed publicly (per @zcbenz’s recommendation). In hindsight, that seems less than wonderful, so I wonder whether putting it under another namespace (maybe `atom::net`?) would be better. I don’t know enough about Electron to know where is best or if it just being under the `atom` namespace is ok.","created_at":"2016-04-08T20:07:59Z","updated_at":"2016-04-08T20:07:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/electron/electron/pulls/5095/commits","review_comments_url":"https://api.github.com/repos/electron/electron/pulls/5095/comments","review_comment_url":"https://api.github.com/repos/electron/electron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electron/electron/issues/5095/comments","statuses_url":"https://api.github.com/repos/electron/electron/statuses/50f51899de609d75ea7a33dfb531b79f630d0780","head":{"label":"Mr0grog:5074-did-get-response-details-resource-type","ref":"5074-did-get-response-details-resource-type","sha":"50f51899de609d75ea7a33dfb531b79f630d0780","user":{"login":"Mr0grog","id":74178,"avatar_url":"https://avatars.githubusercontent.com/u/74178?v=3","gravatar_id":"","url":"https://api.github.com/users/Mr0grog","html_url":"https://github.com/Mr0grog","followers_url":"https://api.github.com/users/Mr0grog/followers","following_url":"https://api.github.com/users/Mr0grog/following{/other_user}","gists_url":"https://api.github.com/users/Mr0grog/gists{/gist_id}","starred_url":"https://api.github.com/users/Mr0grog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mr0grog/subscriptions","organizations_url":"https://api.github.com/users/Mr0grog/orgs","repos_url":"https://api.github.com/users/Mr0grog/repos","events_url":"https://api.github.com/users/Mr0grog/events{/privacy}","received_events_url":"https://api.github.com/users/Mr0grog/received_events","type":"User","site_admin":false},"repo":{"id":55460454,"name":"electron","full_name":"Mr0grog/electron","owner":{"login":"Mr0grog","id":74178,"avatar_url":"https://avatars.githubusercontent.com/u/74178?v=3","gravatar_id":"","url":"https://api.github.com/users/Mr0grog","html_url":"https://github.com/Mr0grog","followers_url":"https://api.github.com/users/Mr0grog/followers","following_url":"https://api.github.com/users/Mr0grog/following{/other_user}","gists_url":"https://api.github.com/users/Mr0grog/gists{/gist_id}","starred_url":"https://api.github.com/users/Mr0grog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mr0grog/subscriptions","organizations_url":"https://api.github.com/users/Mr0grog/orgs","repos_url":"https://api.github.com/users/Mr0grog/repos","events_url":"https://api.github.com/users/Mr0grog/events{/privacy}","received_events_url":"https://api.github.com/users/Mr0grog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Mr0grog/electron","description":"Build cross platform desktop apps with web technologies","fork":true,"url":"https://api.github.com/repos/Mr0grog/electron","forks_url":"https://api.github.com/repos/Mr0grog/electron/forks","keys_url":"https://api.github.com/repos/Mr0grog/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mr0grog/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mr0grog/electron/teams","hooks_url":"https://api.github.com/repos/Mr0grog/electron/hooks","issue_events_url":"https://api.github.com/repos/Mr0grog/electron/issues/events{/number}","events_url":"https://api.github.com/repos/Mr0grog/electron/events","assignees_url":"https://api.github.com/repos/Mr0grog/electron/assignees{/user}","branches_url":"https://api.github.com/repos/Mr0grog/electron/branches{/branch}","tags_url":"https://api.github.com/repos/Mr0grog/electron/tags","blobs_url":"https://api.github.com/repos/Mr0grog/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mr0grog/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mr0grog/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mr0grog/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mr0grog/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/Mr0grog/electron/languages","stargazers_url":"https://api.github.com/repos/Mr0grog/electron/stargazers","contributors_url":"https://api.github.com/repos/Mr0grog/electron/contributors","subscribers_url":"https://api.github.com/repos/Mr0grog/electron/subscribers","subscription_url":"https://api.github.com/repos/Mr0grog/electron/subscription","commits_url":"https://api.github.com/repos/Mr0grog/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mr0grog/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mr0grog/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mr0grog/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mr0grog/electron/contents/{+path}","compare_url":"https://api.github.com/repos/Mr0grog/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mr0grog/electron/merges","archive_url":"https://api.github.com/repos/Mr0grog/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mr0grog/electron/downloads","issues_url":"https://api.github.com/repos/Mr0grog/electron/issues{/number}","pulls_url":"https://api.github.com/repos/Mr0grog/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/Mr0grog/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/Mr0grog/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mr0grog/electron/labels{/name}","releases_url":"https://api.github.com/repos/Mr0grog/electron/releases{/id}","deployments_url":"https://api.github.com/repos/Mr0grog/electron/deployments","created_at":"2016-04-05T02:14:59Z","updated_at":"2016-04-05T02:15:05Z","pushed_at":"2016-04-08T20:03:52Z","git_url":"git://github.com/Mr0grog/electron.git","ssh_url":"git@github.com:Mr0grog/electron.git","clone_url":"https://github.com/Mr0grog/electron.git","svn_url":"https://github.com/Mr0grog/electron","homepage":"http://electron.atom.io","size":15194,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"electron:master","ref":"master","sha":"066092abb6d29209f35b6d5c5ce31ce41b181919","user":{"login":"electron","id":13409222,"avatar_url":"https://avatars.githubusercontent.com/u/13409222?v=3","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"name":"electron","full_name":"electron/electron","owner":{"login":"electron","id":13409222,"avatar_url":"https://avatars.githubusercontent.com/u/13409222?v=3","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/electron/electron","description":"Build cross platform desktop apps with web technologies","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2016-04-08T19:59:58Z","pushed_at":"2016-04-08T15:55:52Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"http://electron.atom.io","size":20266,"stargazers_count":26460,"watchers_count":26460,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2702,"mirror_url":null,"open_issues_count":306,"forks":2702,"open_issues":306,"watchers":26460,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electron/electron/pulls/5095"},"html":{"href":"https://github.com/electron/electron/pull/5095"},"issue":{"href":"https://api.github.com/repos/electron/electron/issues/5095"},"comments":{"href":"https://api.github.com/repos/electron/electron/issues/5095/comments"},"review_comments":{"href":"https://api.github.com/repos/electron/electron/pulls/5095/comments"},"review_comment":{"href":"https://api.github.com/repos/electron/electron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electron/electron/pulls/5095/commits"},"statuses":{"href":"https://api.github.com/repos/electron/electron/statuses/50f51899de609d75ea7a33dfb531b79f630d0780"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":75,"deletions":5,"changed_files":13}}