{"action":"created","comment":{"url":"https://api.github.com/repos/fastlane/fastlane/pulls/comments/89215801","pull_request_review_id":9763727,"id":89215801,"diff_hunk":"@@ -172,6 +172,72 @@ def app_name\n       return \"App\" # default value\n     end\n \n+    def build_for?\n+      return :ios_app if ios_app?\n+      return :ios_framework if ios_framework?\n+      return :ios_library if ios_library?\n+      return :mac_app if mac_app?\n+      return :mac_library if mac_library?\n+      return :mac_framework if mac_framework?\n+      return :command_line_tool if command_line_tool?\n+    end\n+\n+    def dynamic_library?\n+      return true if build_settings(key: \"PRODUCT_TYPE\") == \"com.apple.product-type.library.dynamic\"","path":"fastlane_core/lib/fastlane_core/project.rb","position":15,"original_position":15,"commit_id":"ce91efb6f4292b3bd8e0110426873ff30367cc94","original_commit_id":"ce91efb6f4292b3bd8e0110426873ff30367cc94","user":{"login":"ohwutup","id":2587018,"avatar_url":"https://avatars.githubusercontent.com/u/2587018?v=3","gravatar_id":"","url":"https://api.github.com/users/ohwutup","html_url":"https://github.com/ohwutup","followers_url":"https://api.github.com/users/ohwutup/followers","following_url":"https://api.github.com/users/ohwutup/following{/other_user}","gists_url":"https://api.github.com/users/ohwutup/gists{/gist_id}","starred_url":"https://api.github.com/users/ohwutup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ohwutup/subscriptions","organizations_url":"https://api.github.com/users/ohwutup/orgs","repos_url":"https://api.github.com/users/ohwutup/repos","events_url":"https://api.github.com/users/ohwutup/events{/privacy}","received_events_url":"https://api.github.com/users/ohwutup/received_events","type":"User","site_admin":false},"body":"One more thing for all of these `?` methods... would you mind just returning the boolean expression rather than `true if boolean-expression`?","created_at":"2016-11-22T21:40:23Z","updated_at":"2016-11-22T21:40:28Z","html_url":"https://github.com/fastlane/fastlane/pull/7090#discussion_r89215801","pull_request_url":"https://api.github.com/repos/fastlane/fastlane/pulls/7090","_links":{"self":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/comments/89215801"},"html":{"href":"https://github.com/fastlane/fastlane/pull/7090#discussion_r89215801"},"pull_request":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/7090"}}},"pull_request":{"url":"https://api.github.com/repos/fastlane/fastlane/pulls/7090","id":94432759,"html_url":"https://github.com/fastlane/fastlane/pull/7090","diff_url":"https://github.com/fastlane/fastlane/pull/7090.diff","patch_url":"https://github.com/fastlane/fastlane/pull/7090.patch","issue_url":"https://api.github.com/repos/fastlane/fastlane/issues/7090","number":7090,"state":"open","locked":false,"title":"[fastlane_core] support Commandline apps 💪💻  1/2","user":{"login":"hjanuschka","id":2891702,"avatar_url":"https://avatars.githubusercontent.com/u/2891702?v=3","gravatar_id":"","url":"https://api.github.com/users/hjanuschka","html_url":"https://github.com/hjanuschka","followers_url":"https://api.github.com/users/hjanuschka/followers","following_url":"https://api.github.com/users/hjanuschka/following{/other_user}","gists_url":"https://api.github.com/users/hjanuschka/gists{/gist_id}","starred_url":"https://api.github.com/users/hjanuschka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjanuschka/subscriptions","organizations_url":"https://api.github.com/users/hjanuschka/orgs","repos_url":"https://api.github.com/users/hjanuschka/repos","events_url":"https://api.github.com/users/hjanuschka/events{/privacy}","received_events_url":"https://api.github.com/users/hjanuschka/received_events","type":"User","site_admin":false},"body":"split of #7005","created_at":"2016-11-18T20:39:00Z","updated_at":"2016-11-22T21:40:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0bb90b15687d0ee9579bad57a938f1e070a06a3b","assignee":{"login":"ohwutup","id":2587018,"avatar_url":"https://avatars.githubusercontent.com/u/2587018?v=3","gravatar_id":"","url":"https://api.github.com/users/ohwutup","html_url":"https://github.com/ohwutup","followers_url":"https://api.github.com/users/ohwutup/followers","following_url":"https://api.github.com/users/ohwutup/following{/other_user}","gists_url":"https://api.github.com/users/ohwutup/gists{/gist_id}","starred_url":"https://api.github.com/users/ohwutup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ohwutup/subscriptions","organizations_url":"https://api.github.com/users/ohwutup/orgs","repos_url":"https://api.github.com/users/ohwutup/repos","events_url":"https://api.github.com/users/ohwutup/events{/privacy}","received_events_url":"https://api.github.com/users/ohwutup/received_events","type":"User","site_admin":false},"assignees":[{"login":"ohwutup","id":2587018,"avatar_url":"https://avatars.githubusercontent.com/u/2587018?v=3","gravatar_id":"","url":"https://api.github.com/users/ohwutup","html_url":"https://github.com/ohwutup","followers_url":"https://api.github.com/users/ohwutup/followers","following_url":"https://api.github.com/users/ohwutup/following{/other_user}","gists_url":"https://api.github.com/users/ohwutup/gists{/gist_id}","starred_url":"https://api.github.com/users/ohwutup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ohwutup/subscriptions","organizations_url":"https://api.github.com/users/ohwutup/orgs","repos_url":"https://api.github.com/users/ohwutup/repos","events_url":"https://api.github.com/users/ohwutup/events{/privacy}","received_events_url":"https://api.github.com/users/ohwutup/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/fastlane/fastlane/pulls/7090/commits","review_comments_url":"https://api.github.com/repos/fastlane/fastlane/pulls/7090/comments","review_comment_url":"https://api.github.com/repos/fastlane/fastlane/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fastlane/fastlane/issues/7090/comments","statuses_url":"https://api.github.com/repos/fastlane/fastlane/statuses/ce91efb6f4292b3bd8e0110426873ff30367cc94","head":{"label":"hjanuschka:cmdline_apps_core","ref":"cmdline_apps_core","sha":"ce91efb6f4292b3bd8e0110426873ff30367cc94","user":{"login":"hjanuschka","id":2891702,"avatar_url":"https://avatars.githubusercontent.com/u/2891702?v=3","gravatar_id":"","url":"https://api.github.com/users/hjanuschka","html_url":"https://github.com/hjanuschka","followers_url":"https://api.github.com/users/hjanuschka/followers","following_url":"https://api.github.com/users/hjanuschka/following{/other_user}","gists_url":"https://api.github.com/users/hjanuschka/gists{/gist_id}","starred_url":"https://api.github.com/users/hjanuschka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjanuschka/subscriptions","organizations_url":"https://api.github.com/users/hjanuschka/orgs","repos_url":"https://api.github.com/users/hjanuschka/repos","events_url":"https://api.github.com/users/hjanuschka/events{/privacy}","received_events_url":"https://api.github.com/users/hjanuschka/received_events","type":"User","site_admin":false},"repo":{"id":54015246,"name":"fastlane","full_name":"hjanuschka/fastlane","owner":{"login":"hjanuschka","id":2891702,"avatar_url":"https://avatars.githubusercontent.com/u/2891702?v=3","gravatar_id":"","url":"https://api.github.com/users/hjanuschka","html_url":"https://github.com/hjanuschka","followers_url":"https://api.github.com/users/hjanuschka/followers","following_url":"https://api.github.com/users/hjanuschka/following{/other_user}","gists_url":"https://api.github.com/users/hjanuschka/gists{/gist_id}","starred_url":"https://api.github.com/users/hjanuschka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjanuschka/subscriptions","organizations_url":"https://api.github.com/users/hjanuschka/orgs","repos_url":"https://api.github.com/users/hjanuschka/repos","events_url":"https://api.github.com/users/hjanuschka/events{/privacy}","received_events_url":"https://api.github.com/users/hjanuschka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hjanuschka/fastlane","description":"Connect all iOS and Android deployment tools into one streamlined workflow","fork":true,"url":"https://api.github.com/repos/hjanuschka/fastlane","forks_url":"https://api.github.com/repos/hjanuschka/fastlane/forks","keys_url":"https://api.github.com/repos/hjanuschka/fastlane/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hjanuschka/fastlane/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hjanuschka/fastlane/teams","hooks_url":"https://api.github.com/repos/hjanuschka/fastlane/hooks","issue_events_url":"https://api.github.com/repos/hjanuschka/fastlane/issues/events{/number}","events_url":"https://api.github.com/repos/hjanuschka/fastlane/events","assignees_url":"https://api.github.com/repos/hjanuschka/fastlane/assignees{/user}","branches_url":"https://api.github.com/repos/hjanuschka/fastlane/branches{/branch}","tags_url":"https://api.github.com/repos/hjanuschka/fastlane/tags","blobs_url":"https://api.github.com/repos/hjanuschka/fastlane/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hjanuschka/fastlane/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hjanuschka/fastlane/git/refs{/sha}","trees_url":"https://api.github.com/repos/hjanuschka/fastlane/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hjanuschka/fastlane/statuses/{sha}","languages_url":"https://api.github.com/repos/hjanuschka/fastlane/languages","stargazers_url":"https://api.github.com/repos/hjanuschka/fastlane/stargazers","contributors_url":"https://api.github.com/repos/hjanuschka/fastlane/contributors","subscribers_url":"https://api.github.com/repos/hjanuschka/fastlane/subscribers","subscription_url":"https://api.github.com/repos/hjanuschka/fastlane/subscription","commits_url":"https://api.github.com/repos/hjanuschka/fastlane/commits{/sha}","git_commits_url":"https://api.github.com/repos/hjanuschka/fastlane/git/commits{/sha}","comments_url":"https://api.github.com/repos/hjanuschka/fastlane/comments{/number}","issue_comment_url":"https://api.github.com/repos/hjanuschka/fastlane/issues/comments{/number}","contents_url":"https://api.github.com/repos/hjanuschka/fastlane/contents/{+path}","compare_url":"https://api.github.com/repos/hjanuschka/fastlane/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hjanuschka/fastlane/merges","archive_url":"https://api.github.com/repos/hjanuschka/fastlane/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hjanuschka/fastlane/downloads","issues_url":"https://api.github.com/repos/hjanuschka/fastlane/issues{/number}","pulls_url":"https://api.github.com/repos/hjanuschka/fastlane/pulls{/number}","milestones_url":"https://api.github.com/repos/hjanuschka/fastlane/milestones{/number}","notifications_url":"https://api.github.com/repos/hjanuschka/fastlane/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hjanuschka/fastlane/labels{/name}","releases_url":"https://api.github.com/repos/hjanuschka/fastlane/releases{/id}","deployments_url":"https://api.github.com/repos/hjanuschka/fastlane/deployments","created_at":"2016-03-16T08:46:49Z","updated_at":"2016-03-16T08:46:53Z","pushed_at":"2016-11-22T19:04:34Z","git_url":"git://github.com/hjanuschka/fastlane.git","ssh_url":"git@github.com:hjanuschka/fastlane.git","clone_url":"https://github.com/hjanuschka/fastlane.git","svn_url":"https://github.com/hjanuschka/fastlane","homepage":"https://fastlane.tools","size":52854,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fastlane:master","ref":"master","sha":"b33e54eb5fac3918561de3b2ca4e966f76f1ea69","user":{"login":"fastlane","id":11098337,"avatar_url":"https://avatars.githubusercontent.com/u/11098337?v=3","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"repo":{"id":27442967,"name":"fastlane","full_name":"fastlane/fastlane","owner":{"login":"fastlane","id":11098337,"avatar_url":"https://avatars.githubusercontent.com/u/11098337?v=3","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fastlane/fastlane","description":"The easiest way to automate building and releasing your iOS and Android apps","fork":false,"url":"https://api.github.com/repos/fastlane/fastlane","forks_url":"https://api.github.com/repos/fastlane/fastlane/forks","keys_url":"https://api.github.com/repos/fastlane/fastlane/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fastlane/fastlane/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fastlane/fastlane/teams","hooks_url":"https://api.github.com/repos/fastlane/fastlane/hooks","issue_events_url":"https://api.github.com/repos/fastlane/fastlane/issues/events{/number}","events_url":"https://api.github.com/repos/fastlane/fastlane/events","assignees_url":"https://api.github.com/repos/fastlane/fastlane/assignees{/user}","branches_url":"https://api.github.com/repos/fastlane/fastlane/branches{/branch}","tags_url":"https://api.github.com/repos/fastlane/fastlane/tags","blobs_url":"https://api.github.com/repos/fastlane/fastlane/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fastlane/fastlane/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fastlane/fastlane/git/refs{/sha}","trees_url":"https://api.github.com/repos/fastlane/fastlane/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fastlane/fastlane/statuses/{sha}","languages_url":"https://api.github.com/repos/fastlane/fastlane/languages","stargazers_url":"https://api.github.com/repos/fastlane/fastlane/stargazers","contributors_url":"https://api.github.com/repos/fastlane/fastlane/contributors","subscribers_url":"https://api.github.com/repos/fastlane/fastlane/subscribers","subscription_url":"https://api.github.com/repos/fastlane/fastlane/subscription","commits_url":"https://api.github.com/repos/fastlane/fastlane/commits{/sha}","git_commits_url":"https://api.github.com/repos/fastlane/fastlane/git/commits{/sha}","comments_url":"https://api.github.com/repos/fastlane/fastlane/comments{/number}","issue_comment_url":"https://api.github.com/repos/fastlane/fastlane/issues/comments{/number}","contents_url":"https://api.github.com/repos/fastlane/fastlane/contents/{+path}","compare_url":"https://api.github.com/repos/fastlane/fastlane/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fastlane/fastlane/merges","archive_url":"https://api.github.com/repos/fastlane/fastlane/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fastlane/fastlane/downloads","issues_url":"https://api.github.com/repos/fastlane/fastlane/issues{/number}","pulls_url":"https://api.github.com/repos/fastlane/fastlane/pulls{/number}","milestones_url":"https://api.github.com/repos/fastlane/fastlane/milestones{/number}","notifications_url":"https://api.github.com/repos/fastlane/fastlane/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fastlane/fastlane/labels{/name}","releases_url":"https://api.github.com/repos/fastlane/fastlane/releases{/id}","deployments_url":"https://api.github.com/repos/fastlane/fastlane/deployments","created_at":"2014-12-02T17:00:38Z","updated_at":"2016-11-22T20:54:38Z","pushed_at":"2016-11-22T21:37:44Z","git_url":"git://github.com/fastlane/fastlane.git","ssh_url":"git@github.com:fastlane/fastlane.git","clone_url":"https://github.com/fastlane/fastlane.git","svn_url":"https://github.com/fastlane/fastlane","homepage":"https://fastlane.tools","size":65659,"stargazers_count":12452,"watchers_count":12452,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1865,"mirror_url":null,"open_issues_count":365,"forks":1865,"open_issues":365,"watchers":12452,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/7090"},"html":{"href":"https://github.com/fastlane/fastlane/pull/7090"},"issue":{"href":"https://api.github.com/repos/fastlane/fastlane/issues/7090"},"comments":{"href":"https://api.github.com/repos/fastlane/fastlane/issues/7090/comments"},"review_comments":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/7090/comments"},"review_comment":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/7090/commits"},"statuses":{"href":"https://api.github.com/repos/fastlane/fastlane/statuses/ce91efb6f4292b3bd8e0110426873ff30367cc94"}}}}
{"actor":{"display_login":"ohwutup"}}