{"action":"created","issue":{"url":"https://api.github.com/repos/mottosso/Qt.py/issues/81","repository_url":"https://api.github.com/repos/mottosso/Qt.py","labels_url":"https://api.github.com/repos/mottosso/Qt.py/issues/81/labels{/name}","comments_url":"https://api.github.com/repos/mottosso/Qt.py/issues/81/comments","events_url":"https://api.github.com/repos/mottosso/Qt.py/issues/81/events","html_url":"https://github.com/mottosso/Qt.py/pull/81","id":168222347,"number":81,"title":"Add support secondary arguments support to load_ui","user":{"login":"fredrikaverpil","id":994357,"avatar_url":"https://avatars.githubusercontent.com/u/994357?v=3","gravatar_id":"","url":"https://api.github.com/users/fredrikaverpil","html_url":"https://github.com/fredrikaverpil","followers_url":"https://api.github.com/users/fredrikaverpil/followers","following_url":"https://api.github.com/users/fredrikaverpil/following{/other_user}","gists_url":"https://api.github.com/users/fredrikaverpil/gists{/gist_id}","starred_url":"https://api.github.com/users/fredrikaverpil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredrikaverpil/subscriptions","organizations_url":"https://api.github.com/users/fredrikaverpil/orgs","repos_url":"https://api.github.com/users/fredrikaverpil/repos","events_url":"https://api.github.com/users/fredrikaverpil/events{/privacy}","received_events_url":"https://api.github.com/users/fredrikaverpil/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":44,"created_at":"2016-07-28T23:50:07Z","updated_at":"2016-08-01T19:14:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mottosso/Qt.py/pulls/81","html_url":"https://github.com/mottosso/Qt.py/pull/81","diff_url":"https://github.com/mottosso/Qt.py/pull/81.diff","patch_url":"https://github.com/mottosso/Qt.py/pull/81.patch"},"body":"Fix #80 \r\n\r\nWe can now support the base instance argument and the custom widgets argument in `load_ui` thanks to the custom class in [this gist](https://gist.github.com/cpbotha/1b42a20c8f3eb9bb7cb8).\r\n\r\nLet's discuss.\r\n\r\nHow do we deal with the copyright message at the top of the gist?\r\nWe should give Sebastian Wiesner (lunaryorn@gmail.com) credit for this.\r\n\r\n@bpabel - do you know how to use the third (custom widgets) argument?\r\nI've added support for it but I'm not sure about its use case. I'd like to see an example of it being used so that I can add tests for it.\r\n\r\n@mottosso I was unable to remove QStatusBar and QMenuBar from the tests UI without crash."},"comment":{"url":"https://api.github.com/repos/mottosso/Qt.py/issues/comments/236678064","html_url":"https://github.com/mottosso/Qt.py/pull/81#issuecomment-236678064","issue_url":"https://api.github.com/repos/mottosso/Qt.py/issues/81","id":236678064,"user":{"login":"fredrikaverpil","id":994357,"avatar_url":"https://avatars.githubusercontent.com/u/994357?v=3","gravatar_id":"","url":"https://api.github.com/users/fredrikaverpil","html_url":"https://github.com/fredrikaverpil","followers_url":"https://api.github.com/users/fredrikaverpil/followers","following_url":"https://api.github.com/users/fredrikaverpil/following{/other_user}","gists_url":"https://api.github.com/users/fredrikaverpil/gists{/gist_id}","starred_url":"https://api.github.com/users/fredrikaverpil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredrikaverpil/subscriptions","organizations_url":"https://api.github.com/users/fredrikaverpil/orgs","repos_url":"https://api.github.com/users/fredrikaverpil/repos","events_url":"https://api.github.com/users/fredrikaverpil/events{/privacy}","received_events_url":"https://api.github.com/users/fredrikaverpil/received_events","type":"User","site_admin":false},"created_at":"2016-08-01T19:14:14Z","updated_at":"2016-08-01T19:14:14Z","body":"> Maybe let's exclude the doctest for now, and have a chat about that in another PR?\r\n\r\nI think so, yeah.\r\n\r\nI've now made sure to define the UiLoader class once. However, this made the code a bit complex. What do you think, do you have a better suggestion on how to solve that?"}}
{"actor":{"display_login":"fredrikaverpil"}}