{"action":"created","comment":{"url":"https://api.github.com/repos/fluid-project/chartAuthoring/pulls/comments/50896800","id":50896800,"diff_hunk":"@@ -237,6 +347,24 @@ https://raw.githubusercontent.com/fluid-project/chartAuthoring/master/LICENSE.tx\n             $(this).find(dataEntryLabelSelector).val(currentData.label).trigger(\"change\");\n             $(this).find(dataEntryValueSelector).val(currentData.value).trigger(\"change\");\n         });\n+\n+        that.events.onUpdateDataEntryPanel.fire();\n+    };\n+\n+    floe.chartAuthoring.addSonificationControlListeners = function(that) {\n+        var playButton = that.locate(\"sonifierPlay\"),\n+            stopButton = that.locate(\"sonifierStop\");\n+\n+        playButton.click(function(e) {","path":"src/js/chartAuthoring.js","position":209,"original_position":209,"commit_id":"df4055598300fa73f748c58abe7e008c3e92b535","original_commit_id":"df4055598300fa73f748c58abe7e008c3e92b535","user":{"login":"amb26","id":561418,"avatar_url":"https://avatars.githubusercontent.com/u/561418?v=3","gravatar_id":"","url":"https://api.github.com/users/amb26","html_url":"https://github.com/amb26","followers_url":"https://api.github.com/users/amb26/followers","following_url":"https://api.github.com/users/amb26/following{/other_user}","gists_url":"https://api.github.com/users/amb26/gists{/gist_id}","starred_url":"https://api.github.com/users/amb26/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amb26/subscriptions","organizations_url":"https://api.github.com/users/amb26/orgs","repos_url":"https://api.github.com/users/amb26/repos","events_url":"https://api.github.com/users/amb26/events{/privacy}","received_events_url":"https://api.github.com/users/amb26/received_events","type":"User","site_admin":false},"body":"These listeners form a pretty stereotypical pattern. I suggest drawing up some configuration accepted by the component and encoding this declaratively.","created_at":"2016-01-26T20:42:24Z","updated_at":"2016-01-26T20:42:24Z","html_url":"https://github.com/fluid-project/chartAuthoring/pull/11#discussion_r50896800","pull_request_url":"https://api.github.com/repos/fluid-project/chartAuthoring/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/fluid-project/chartAuthoring/pulls/comments/50896800"},"html":{"href":"https://github.com/fluid-project/chartAuthoring/pull/11#discussion_r50896800"},"pull_request":{"href":"https://api.github.com/repos/fluid-project/chartAuthoring/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/fluid-project/chartAuthoring/pulls/11","id":57241161,"html_url":"https://github.com/fluid-project/chartAuthoring/pull/11","diff_url":"https://github.com/fluid-project/chartAuthoring/pull/11.diff","patch_url":"https://github.com/fluid-project/chartAuthoring/pull/11.patch","issue_url":"https://api.github.com/repos/fluid-project/chartAuthoring/issues/11","number":11,"state":"open","locked":false,"title":"FLOE-437 + FLOE-439 + FLOE-441","user":{"login":"waharnum","id":5279051,"avatar_url":"https://avatars.githubusercontent.com/u/5279051?v=3","gravatar_id":"","url":"https://api.github.com/users/waharnum","html_url":"https://github.com/waharnum","followers_url":"https://api.github.com/users/waharnum/followers","following_url":"https://api.github.com/users/waharnum/following{/other_user}","gists_url":"https://api.github.com/users/waharnum/gists{/gist_id}","starred_url":"https://api.github.com/users/waharnum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waharnum/subscriptions","organizations_url":"https://api.github.com/users/waharnum/orgs","repos_url":"https://api.github.com/users/waharnum/repos","events_url":"https://api.github.com/users/waharnum/events{/privacy}","received_events_url":"https://api.github.com/users/waharnum/received_events","type":"User","site_admin":false},"body":"This PR covers three separate issues:\r\n\r\n*Sonifier implementation*: https://issues.fluidproject.org/browse/FLOE-437\r\n\r\n*Better test coverage for existing features*: https://issues.fluidproject.org/browse/FLOE-439\r\n\r\n*Connecting the pie's description and title SVG elements to the inline edit components*: https://issues.fluidproject.org/browse/FLOE-441\r\n\r\nNew files in the `src/lib/flocking` directory don't need to be reviewed - they're dependencies for the data sonification from the http://flockingjs.org/ library.\r\n","created_at":"2016-01-26T17:13:24Z","updated_at":"2016-01-26T20:42:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d48dfab1fd66bd0846fba94a73a04a0a976cb3de","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fluid-project/chartAuthoring/pulls/11/commits","review_comments_url":"https://api.github.com/repos/fluid-project/chartAuthoring/pulls/11/comments","review_comment_url":"https://api.github.com/repos/fluid-project/chartAuthoring/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fluid-project/chartAuthoring/issues/11/comments","statuses_url":"https://api.github.com/repos/fluid-project/chartAuthoring/statuses/df4055598300fa73f748c58abe7e008c3e92b535","head":{"label":"waharnum:FLOE-437","ref":"FLOE-437","sha":"df4055598300fa73f748c58abe7e008c3e92b535","user":{"login":"waharnum","id":5279051,"avatar_url":"https://avatars.githubusercontent.com/u/5279051?v=3","gravatar_id":"","url":"https://api.github.com/users/waharnum","html_url":"https://github.com/waharnum","followers_url":"https://api.github.com/users/waharnum/followers","following_url":"https://api.github.com/users/waharnum/following{/other_user}","gists_url":"https://api.github.com/users/waharnum/gists{/gist_id}","starred_url":"https://api.github.com/users/waharnum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waharnum/subscriptions","organizations_url":"https://api.github.com/users/waharnum/orgs","repos_url":"https://api.github.com/users/waharnum/repos","events_url":"https://api.github.com/users/waharnum/events{/privacy}","received_events_url":"https://api.github.com/users/waharnum/received_events","type":"User","site_admin":false},"repo":{"id":40918997,"name":"chartAuthoring","full_name":"waharnum/chartAuthoring","owner":{"login":"waharnum","id":5279051,"avatar_url":"https://avatars.githubusercontent.com/u/5279051?v=3","gravatar_id":"","url":"https://api.github.com/users/waharnum","html_url":"https://github.com/waharnum","followers_url":"https://api.github.com/users/waharnum/followers","following_url":"https://api.github.com/users/waharnum/following{/other_user}","gists_url":"https://api.github.com/users/waharnum/gists{/gist_id}","starred_url":"https://api.github.com/users/waharnum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waharnum/subscriptions","organizations_url":"https://api.github.com/users/waharnum/orgs","repos_url":"https://api.github.com/users/waharnum/repos","events_url":"https://api.github.com/users/waharnum/events{/privacy}","received_events_url":"https://api.github.com/users/waharnum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/waharnum/chartAuthoring","description":"A tool for authoring accessible charts for the web.","fork":true,"url":"https://api.github.com/repos/waharnum/chartAuthoring","forks_url":"https://api.github.com/repos/waharnum/chartAuthoring/forks","keys_url":"https://api.github.com/repos/waharnum/chartAuthoring/keys{/key_id}","collaborators_url":"https://api.github.com/repos/waharnum/chartAuthoring/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/waharnum/chartAuthoring/teams","hooks_url":"https://api.github.com/repos/waharnum/chartAuthoring/hooks","issue_events_url":"https://api.github.com/repos/waharnum/chartAuthoring/issues/events{/number}","events_url":"https://api.github.com/repos/waharnum/chartAuthoring/events","assignees_url":"https://api.github.com/repos/waharnum/chartAuthoring/assignees{/user}","branches_url":"https://api.github.com/repos/waharnum/chartAuthoring/branches{/branch}","tags_url":"https://api.github.com/repos/waharnum/chartAuthoring/tags","blobs_url":"https://api.github.com/repos/waharnum/chartAuthoring/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/waharnum/chartAuthoring/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/waharnum/chartAuthoring/git/refs{/sha}","trees_url":"https://api.github.com/repos/waharnum/chartAuthoring/git/trees{/sha}","statuses_url":"https://api.github.com/repos/waharnum/chartAuthoring/statuses/{sha}","languages_url":"https://api.github.com/repos/waharnum/chartAuthoring/languages","stargazers_url":"https://api.github.com/repos/waharnum/chartAuthoring/stargazers","contributors_url":"https://api.github.com/repos/waharnum/chartAuthoring/contributors","subscribers_url":"https://api.github.com/repos/waharnum/chartAuthoring/subscribers","subscription_url":"https://api.github.com/repos/waharnum/chartAuthoring/subscription","commits_url":"https://api.github.com/repos/waharnum/chartAuthoring/commits{/sha}","git_commits_url":"https://api.github.com/repos/waharnum/chartAuthoring/git/commits{/sha}","comments_url":"https://api.github.com/repos/waharnum/chartAuthoring/comments{/number}","issue_comment_url":"https://api.github.com/repos/waharnum/chartAuthoring/issues/comments{/number}","contents_url":"https://api.github.com/repos/waharnum/chartAuthoring/contents/{+path}","compare_url":"https://api.github.com/repos/waharnum/chartAuthoring/compare/{base}...{head}","merges_url":"https://api.github.com/repos/waharnum/chartAuthoring/merges","archive_url":"https://api.github.com/repos/waharnum/chartAuthoring/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/waharnum/chartAuthoring/downloads","issues_url":"https://api.github.com/repos/waharnum/chartAuthoring/issues{/number}","pulls_url":"https://api.github.com/repos/waharnum/chartAuthoring/pulls{/number}","milestones_url":"https://api.github.com/repos/waharnum/chartAuthoring/milestones{/number}","notifications_url":"https://api.github.com/repos/waharnum/chartAuthoring/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/waharnum/chartAuthoring/labels{/name}","releases_url":"https://api.github.com/repos/waharnum/chartAuthoring/releases{/id}","deployments_url":"https://api.github.com/repos/waharnum/chartAuthoring/deployments","created_at":"2015-08-17T18:35:53Z","updated_at":"2015-08-17T18:35:54Z","pushed_at":"2016-01-26T20:33:20Z","git_url":"git://github.com/waharnum/chartAuthoring.git","ssh_url":"git@github.com:waharnum/chartAuthoring.git","clone_url":"https://github.com/waharnum/chartAuthoring.git","svn_url":"https://github.com/waharnum/chartAuthoring","homepage":null,"size":2472,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fluid-project:master","ref":"master","sha":"4ffa37fe9cab9c0f2b8d268341554a1586e79f5e","user":{"login":"fluid-project","id":560119,"avatar_url":"https://avatars.githubusercontent.com/u/560119?v=3","gravatar_id":"","url":"https://api.github.com/users/fluid-project","html_url":"https://github.com/fluid-project","followers_url":"https://api.github.com/users/fluid-project/followers","following_url":"https://api.github.com/users/fluid-project/following{/other_user}","gists_url":"https://api.github.com/users/fluid-project/gists{/gist_id}","starred_url":"https://api.github.com/users/fluid-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluid-project/subscriptions","organizations_url":"https://api.github.com/users/fluid-project/orgs","repos_url":"https://api.github.com/users/fluid-project/repos","events_url":"https://api.github.com/users/fluid-project/events{/privacy}","received_events_url":"https://api.github.com/users/fluid-project/received_events","type":"Organization","site_admin":false},"repo":{"id":37926920,"name":"chartAuthoring","full_name":"fluid-project/chartAuthoring","owner":{"login":"fluid-project","id":560119,"avatar_url":"https://avatars.githubusercontent.com/u/560119?v=3","gravatar_id":"","url":"https://api.github.com/users/fluid-project","html_url":"https://github.com/fluid-project","followers_url":"https://api.github.com/users/fluid-project/followers","following_url":"https://api.github.com/users/fluid-project/following{/other_user}","gists_url":"https://api.github.com/users/fluid-project/gists{/gist_id}","starred_url":"https://api.github.com/users/fluid-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluid-project/subscriptions","organizations_url":"https://api.github.com/users/fluid-project/orgs","repos_url":"https://api.github.com/users/fluid-project/repos","events_url":"https://api.github.com/users/fluid-project/events{/privacy}","received_events_url":"https://api.github.com/users/fluid-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fluid-project/chartAuthoring","description":"A tool for authoring accessible charts for the web.","fork":false,"url":"https://api.github.com/repos/fluid-project/chartAuthoring","forks_url":"https://api.github.com/repos/fluid-project/chartAuthoring/forks","keys_url":"https://api.github.com/repos/fluid-project/chartAuthoring/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fluid-project/chartAuthoring/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fluid-project/chartAuthoring/teams","hooks_url":"https://api.github.com/repos/fluid-project/chartAuthoring/hooks","issue_events_url":"https://api.github.com/repos/fluid-project/chartAuthoring/issues/events{/number}","events_url":"https://api.github.com/repos/fluid-project/chartAuthoring/events","assignees_url":"https://api.github.com/repos/fluid-project/chartAuthoring/assignees{/user}","branches_url":"https://api.github.com/repos/fluid-project/chartAuthoring/branches{/branch}","tags_url":"https://api.github.com/repos/fluid-project/chartAuthoring/tags","blobs_url":"https://api.github.com/repos/fluid-project/chartAuthoring/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fluid-project/chartAuthoring/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fluid-project/chartAuthoring/git/refs{/sha}","trees_url":"https://api.github.com/repos/fluid-project/chartAuthoring/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fluid-project/chartAuthoring/statuses/{sha}","languages_url":"https://api.github.com/repos/fluid-project/chartAuthoring/languages","stargazers_url":"https://api.github.com/repos/fluid-project/chartAuthoring/stargazers","contributors_url":"https://api.github.com/repos/fluid-project/chartAuthoring/contributors","subscribers_url":"https://api.github.com/repos/fluid-project/chartAuthoring/subscribers","subscription_url":"https://api.github.com/repos/fluid-project/chartAuthoring/subscription","commits_url":"https://api.github.com/repos/fluid-project/chartAuthoring/commits{/sha}","git_commits_url":"https://api.github.com/repos/fluid-project/chartAuthoring/git/commits{/sha}","comments_url":"https://api.github.com/repos/fluid-project/chartAuthoring/comments{/number}","issue_comment_url":"https://api.github.com/repos/fluid-project/chartAuthoring/issues/comments{/number}","contents_url":"https://api.github.com/repos/fluid-project/chartAuthoring/contents/{+path}","compare_url":"https://api.github.com/repos/fluid-project/chartAuthoring/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fluid-project/chartAuthoring/merges","archive_url":"https://api.github.com/repos/fluid-project/chartAuthoring/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fluid-project/chartAuthoring/downloads","issues_url":"https://api.github.com/repos/fluid-project/chartAuthoring/issues{/number}","pulls_url":"https://api.github.com/repos/fluid-project/chartAuthoring/pulls{/number}","milestones_url":"https://api.github.com/repos/fluid-project/chartAuthoring/milestones{/number}","notifications_url":"https://api.github.com/repos/fluid-project/chartAuthoring/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fluid-project/chartAuthoring/labels{/name}","releases_url":"https://api.github.com/repos/fluid-project/chartAuthoring/releases{/id}","deployments_url":"https://api.github.com/repos/fluid-project/chartAuthoring/deployments","created_at":"2015-06-23T15:16:51Z","updated_at":"2015-06-24T17:07:26Z","pushed_at":"2016-01-26T20:33:21Z","git_url":"git://github.com/fluid-project/chartAuthoring.git","ssh_url":"git@github.com:fluid-project/chartAuthoring.git","clone_url":"https://github.com/fluid-project/chartAuthoring.git","svn_url":"https://github.com/fluid-project/chartAuthoring","homepage":null,"size":2125,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fluid-project/chartAuthoring/pulls/11"},"html":{"href":"https://github.com/fluid-project/chartAuthoring/pull/11"},"issue":{"href":"https://api.github.com/repos/fluid-project/chartAuthoring/issues/11"},"comments":{"href":"https://api.github.com/repos/fluid-project/chartAuthoring/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/fluid-project/chartAuthoring/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/fluid-project/chartAuthoring/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fluid-project/chartAuthoring/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/fluid-project/chartAuthoring/statuses/df4055598300fa73f748c58abe7e008c3e92b535"}}}}