{"action":"created","issue":{"url":"https://api.github.com/repos/maidsafe/crust/issues/784","repository_url":"https://api.github.com/repos/maidsafe/crust","labels_url":"https://api.github.com/repos/maidsafe/crust/issues/784/labels{/name}","comments_url":"https://api.github.com/repos/maidsafe/crust/issues/784/comments","events_url":"https://api.github.com/repos/maidsafe/crust/issues/784/events","html_url":"https://github.com/maidsafe/crust/pull/784","id":162117206,"number":784,"title":"feat/socket: never drop priority 1 messages","user":{"login":"afck","id":7894725,"avatar_url":"https://avatars.githubusercontent.com/u/7894725?v=3","gravatar_id":"","url":"https://api.github.com/users/afck","html_url":"https://github.com/afck","followers_url":"https://api.github.com/users/afck/followers","following_url":"https://api.github.com/users/afck/following{/other_user}","gists_url":"https://api.github.com/users/afck/gists{/gist_id}","starred_url":"https://api.github.com/users/afck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afck/subscriptions","organizations_url":"https://api.github.com/users/afck/orgs","repos_url":"https://api.github.com/users/afck/repos","events_url":"https://api.github.com/users/afck/events{/privacy}","received_events_url":"https://api.github.com/users/afck/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"ustulation","id":8788153,"avatar_url":"https://avatars.githubusercontent.com/u/8788153?v=3","gravatar_id":"","url":"https://api.github.com/users/ustulation","html_url":"https://github.com/ustulation","followers_url":"https://api.github.com/users/ustulation/followers","following_url":"https://api.github.com/users/ustulation/following{/other_user}","gists_url":"https://api.github.com/users/ustulation/gists{/gist_id}","starred_url":"https://api.github.com/users/ustulation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ustulation/subscriptions","organizations_url":"https://api.github.com/users/ustulation/orgs","repos_url":"https://api.github.com/users/ustulation/repos","events_url":"https://api.github.com/users/ustulation/events{/privacy}","received_events_url":"https://api.github.com/users/ustulation/received_events","type":"User","site_admin":false},"assignees":[{"login":"ustulation","id":8788153,"avatar_url":"https://avatars.githubusercontent.com/u/8788153?v=3","gravatar_id":"","url":"https://api.github.com/users/ustulation","html_url":"https://github.com/ustulation","followers_url":"https://api.github.com/users/ustulation/followers","following_url":"https://api.github.com/users/ustulation/following{/other_user}","gists_url":"https://api.github.com/users/ustulation/gists{/gist_id}","starred_url":"https://api.github.com/users/ustulation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ustulation/subscriptions","organizations_url":"https://api.github.com/users/ustulation/orgs","repos_url":"https://api.github.com/users/ustulation/repos","events_url":"https://api.github.com/users/ustulation/events{/privacy}","received_events_url":"https://api.github.com/users/ustulation/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-06-24T10:14:32Z","updated_at":"2016-06-24T10:24:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/maidsafe/crust/pulls/784","html_url":"https://github.com/maidsafe/crust/pull/784","diff_url":"https://github.com/maidsafe/crust/pull/784.diff","patch_url":"https://github.com/maidsafe/crust/pull/784.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/maidsafe/crust/784)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/maidsafe/crust/issues/comments/228311079","html_url":"https://github.com/maidsafe/crust/pull/784#issuecomment-228311079","issue_url":"https://api.github.com/repos/maidsafe/crust/issues/784","id":228311079,"user":{"login":"ustulation","id":8788153,"avatar_url":"https://avatars.githubusercontent.com/u/8788153?v=3","gravatar_id":"","url":"https://api.github.com/users/ustulation","html_url":"https://github.com/ustulation","followers_url":"https://api.github.com/users/ustulation/followers","following_url":"https://api.github.com/users/ustulation/following{/other_user}","gists_url":"https://api.github.com/users/ustulation/gists{/gist_id}","starred_url":"https://api.github.com/users/ustulation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ustulation/subscriptions","organizations_url":"https://api.github.com/users/ustulation/orgs","repos_url":"https://api.github.com/users/ustulation/repos","events_url":"https://api.github.com/users/ustulation/events{/privacy}","received_events_url":"https://api.github.com/users/ustulation/received_events","type":"User","site_admin":false},"created_at":"2016-06-24T10:24:51Z","updated_at":"2016-06-24T10:24:51Z","body":"\n\n\n\nReview status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.\n\n---\n\n*[src/common/socket.rs, line 34 \\[r1\\]](https://reviewable.io:443/reviews/maidsafe/crust/784#-KL0viiYqLIOGtEUkCDU:-KL0viiZ9xrNYVv0szNV:-1048085980) ([raw file](https://github.com/maidsafe/crust/blob/101e30642e70eadbfaeaafad4df613d594921baa/src/common/socket.rs#L34)):*\n> ```Rust\n> const MAX_MSG_AGE_SECS: u64 = 60;\n> // Minimum priority for droppable messages. Messages with lower values will never be dropped.\n> const MSG_DROP_PRIORITY: u8 = 2;\n> ```\n\nThe priority is a public field in `send` function. So the user should be aware of what it means. So i think this should be a public constant in `lib.rs` otherwise we are keeping the users in dark. Also might be worthwhile updating the docs for `common::Priority` now to just say it indicates a message priority instead of more details like `Do not drop 0` etc it says right now\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/maidsafe/crust/784)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"ustulation"}}