{"action":"created","issue":{"url":"https://api.github.com/repos/kaazing/webrtc/issues/25","repository_url":"https://api.github.com/repos/kaazing/webrtc","labels_url":"https://api.github.com/repos/kaazing/webrtc/issues/25/labels{/name}","comments_url":"https://api.github.com/repos/kaazing/webrtc/issues/25/comments","events_url":"https://api.github.com/repos/kaazing/webrtc/issues/25/events","html_url":"https://github.com/kaazing/webrtc/pull/25","id":185157589,"number":25,"title":"DO NOT MERGE - Fix for WebRTC demo appears to not be going through turn proxy","user":{"login":"DoruM","id":3726034,"avatar_url":"https://avatars.githubusercontent.com/u/3726034?v=3","gravatar_id":"","url":"https://api.github.com/users/DoruM","html_url":"https://github.com/DoruM","followers_url":"https://api.github.com/users/DoruM/followers","following_url":"https://api.github.com/users/DoruM/following{/other_user}","gists_url":"https://api.github.com/users/DoruM/gists{/gist_id}","starred_url":"https://api.github.com/users/DoruM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoruM/subscriptions","organizations_url":"https://api.github.com/users/DoruM/orgs","repos_url":"https://api.github.com/users/DoruM/repos","events_url":"https://api.github.com/users/DoruM/events{/privacy}","received_events_url":"https://api.github.com/users/DoruM/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"dpwspoon","id":2014623,"avatar_url":"https://avatars.githubusercontent.com/u/2014623?v=3","gravatar_id":"","url":"https://api.github.com/users/dpwspoon","html_url":"https://github.com/dpwspoon","followers_url":"https://api.github.com/users/dpwspoon/followers","following_url":"https://api.github.com/users/dpwspoon/following{/other_user}","gists_url":"https://api.github.com/users/dpwspoon/gists{/gist_id}","starred_url":"https://api.github.com/users/dpwspoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpwspoon/subscriptions","organizations_url":"https://api.github.com/users/dpwspoon/orgs","repos_url":"https://api.github.com/users/dpwspoon/repos","events_url":"https://api.github.com/users/dpwspoon/events{/privacy}","received_events_url":"https://api.github.com/users/dpwspoon/received_events","type":"User","site_admin":false},"assignees":[{"login":"dpwspoon","id":2014623,"avatar_url":"https://avatars.githubusercontent.com/u/2014623?v=3","gravatar_id":"","url":"https://api.github.com/users/dpwspoon","html_url":"https://github.com/dpwspoon","followers_url":"https://api.github.com/users/dpwspoon/followers","following_url":"https://api.github.com/users/dpwspoon/following{/other_user}","gists_url":"https://api.github.com/users/dpwspoon/gists{/gist_id}","starred_url":"https://api.github.com/users/dpwspoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpwspoon/subscriptions","organizations_url":"https://api.github.com/users/dpwspoon/orgs","repos_url":"https://api.github.com/users/dpwspoon/repos","events_url":"https://api.github.com/users/dpwspoon/events{/privacy}","received_events_url":"https://api.github.com/users/dpwspoon/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-10-25T15:49:04Z","updated_at":"2016-10-26T04:25:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kaazing/webrtc/pulls/25","html_url":"https://github.com/kaazing/webrtc/pull/25","diff_url":"https://github.com/kaazing/webrtc/pull/25.diff","patch_url":"https://github.com/kaazing/webrtc/pull/25.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/kaazing/webrtc/issues/comments/256246323","html_url":"https://github.com/kaazing/webrtc/pull/25#issuecomment-256246323","issue_url":"https://api.github.com/repos/kaazing/webrtc/issues/25","id":256246323,"user":{"login":"DoruM","id":3726034,"avatar_url":"https://avatars.githubusercontent.com/u/3726034?v=3","gravatar_id":"","url":"https://api.github.com/users/DoruM","html_url":"https://github.com/DoruM","followers_url":"https://api.github.com/users/DoruM/followers","following_url":"https://api.github.com/users/DoruM/following{/other_user}","gists_url":"https://api.github.com/users/DoruM/gists{/gist_id}","starred_url":"https://api.github.com/users/DoruM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoruM/subscriptions","organizations_url":"https://api.github.com/users/DoruM/orgs","repos_url":"https://api.github.com/users/DoruM/repos","events_url":"https://api.github.com/users/DoruM/events{/privacy}","received_events_url":"https://api.github.com/users/DoruM/received_events","type":"User","site_admin":false},"created_at":"2016-10-26T04:25:46Z","updated_at":"2016-10-26T04:25:46Z","body":"@dpwspoon \r\nHi David,\r\n\r\n>  shouldn't need to mess with the SDP protocol directly as I would assume javascript should provide a programmatic way to enforce this;\r\n\r\nWell, it turns out it doesn't. Certain \"host\" candidates are sent in the answer and offer although only \"relay\" SDPs are added or sent (via addICECandidate and onICEaddCandidate). I am not sure whether this is by design or not, but I wasn't able to get rid of them unless I actually manually remove them. I am not 100% sure whether this is really needed to be honest, and it might be the case that it is not. I will test today. \r\n\r\nStill, some \"host\" information IS sent via the answer and offer functions and this might be a vulnerability. So I think they should be removed.\r\n\r\nRegards,\r\nDoru"}}
{"actor":{"display_login":"DoruM"}}