{"push_id":1251571355,"size":22,"distinct_size":3,"ref":"refs/heads/master","head":"6e95207a68e4c3f9206a0e9fda2e3d5c0fafc24b","before":"a15cf5e7189f761cc4f22070c5c4e5285b9fac21","commits":[{"sha":"e81b836ea58937be4845cb35dece6d930bcd1af2","author":{"name":"lukasz_czubernat","email":"fe1341cc65e939dff4440536fdf37b2202f19d1c@epam.com"},"message":"Setting everything for integration\nI've refactrored huge part of core and util modules to prepare them for integration with game engine (which will be create soon). Most changes was about prepare to hold data for more than one player. I've also change version on common-collections dependecy because there was a newer version.","distinct":false,"url":"https://api.github.com/repos/ProCodingBad/Battleship/commits/e81b836ea58937be4845cb35dece6d930bcd1af2"},{"sha":"06db5edb63610c250deb099ae2f8870782f91e4a","author":{"name":"lukasz_czubernat","email":"fe1341cc65e939dff4440536fdf37b2202f19d1c@epam.com"},"message":"Cleanup\nFirst of all I've removed board and field representation, because it's not needed anymore (we have gui so there will be \"board\" we need).\nSecondly I've moved player representation to common module (util), because both core and gui will use it.\nLast thing that need to be mention, I've change version of depenencied, because new versions of them were released.","distinct":false,"url":"https://api.github.com/repos/ProCodingBad/Battleship/commits/06db5edb63610c250deb099ae2f8870782f91e4a"},{"sha":"6cd2df06fdb464daed66aae3cfe8cacca4c0c906","author":{"name":"lukasz_czubernat","email":"fe1341cc65e939dff4440536fdf37b2202f19d1c@epam.com"},"message":"Arbiter refactor\nI've changed name of Arbitrer to ArbiterDecisionEngine, because behaviour of this class is more like internal behaviour. Arbiter class will be create and it will receive messages and will generete responses to gui. Also I've refactor ship cache by rename method names and now they suggest what they are for.","distinct":false,"url":"https://api.github.com/repos/ProCodingBad/Battleship/commits/6cd2df06fdb464daed66aae3cfe8cacca4c0c906"},{"sha":"214c696860b5ec2e79e55d63993ba46a0a375833","author":{"name":"kuba","email":"be182995160e9bfeba681f01fa1d7d43e64cb410@gmail.com"},"message":"DragAndDrop first try\nDrag and drop is working but it is little buggy because grid is messed up","distinct":false,"url":"https://api.github.com/repos/ProCodingBad/Battleship/commits/214c696860b5ec2e79e55d63993ba46a0a375833"},{"sha":"1ed8753aad31d13c70acfdc9f5c5c451d8c14998","author":{"name":"lukasz_czubernat","email":"fe1341cc65e939dff4440536fdf37b2202f19d1c@epam.com"},"message":"Arbiter.\nI've added dummy representation for arbiter. It will support decision engine and ship cache and it will generate part of response (REST).\nAlso I've refactored a bit ship cache. We don't need in ship area wrapper information about ship.","distinct":false,"url":"https://api.github.com/repos/ProCodingBad/Battleship/commits/1ed8753aad31d13c70acfdc9f5c5c451d8c14998"},{"sha":"8c263e915348ce52d3b6a93d12888ed476789194","author":{"name":"lukasz_czubernat","email":"fe1341cc65e939dff4440536fdf37b2202f19d1c@epam.com"},"message":"Refactor - more abstraction\nI've refactored almost all classes and add proper interfaces for them. Point of this modification is simple - follow OOP principles :D\nAlso code is more readable.","distinct":false,"url":"https://api.github.com/repos/ProCodingBad/Battleship/commits/8c263e915348ce52d3b6a93d12888ed476789194"},{"sha":"5d118372de610b672064f03b1d1ebf09faef12d4","author":{"name":"lukasz_czubernat","email":"fe1341cc65e939dff4440536fdf37b2202f19d1c@epam.com"},"message":"Change naming convention\nI've changed names of classes and interfaces. Now all names should be more proper and easy to understand what is class or interface for.","distinct":false,"url":"https://api.github.com/repos/ProCodingBad/Battleship/commits/5d118372de610b672064f03b1d1ebf09faef12d4"},{"sha":"71ebb9bfb1e93bf0f5803c49fe2b5ca232d92c5b","author":{"name":"lukasz_czubernat","email":"fe1341cc65e939dff4440536fdf37b2202f19d1c@epam.com"},"message":"Huge amount of changes\nI'll start from minor changes.\nFirst I've renamed Player class to Client, because it represents client side app (GUI app) not player itself. If we add real player in future we won't chage this part of implamentation. Another change in Client (previous Player) class is that I've change integer id to UUID. During talks about architecture we decided that client id (UUID) will be generated on client side (in GUI), this will provide easy identify of GUI instantion. Also I've added to Client new field and bahaviour (isReady) and this will help with decide when start game (both clients need to be mark as 'ready' before start).\nSecond I've modified TurnProvider. New bahaviour allows to get current and next 'player' without changing their order. To change their order we can use newly introduced method ( TurnProvider.changeTurn() ).\nNext this is that I've removed ShipCache. During developmnet I've discovered its not needed any more.\nLast less important thing is that I've moved (renamed) few classes to different packages to keep project structure clean.\nThe last and most important major thing. I've intorduced first version of external interface (Game and its implementation BattleshipGame class). It will be use in REST communication as externat interface. Also I've added GameCache which will contains game id (UUID) and max to 'players' bound to game.","distinct":false,"url":"https://api.github.com/repos/ProCodingBad/Battleship/commits/71ebb9bfb1e93bf0f5803c49fe2b5ca232d92c5b"},{"sha":"9eaa365ea0ad2e65d501868626bf35269a0e1db8","author":{"name":"kuba","email":"be182995160e9bfeba681f01fa1d7d43e64cb410@gmail.com"},"message":"Drag over events\nWith this I can determine over which component ship is dragged and start right acction on drop","distinct":false,"url":"https://api.github.com/repos/ProCodingBad/Battleship/commits/9eaa365ea0ad2e65d501868626bf35269a0e1db8"},{"sha":"7b78689a5371d60850ed2a097c4e94ba7e81842e","author":{"name":"kuba","email":"be182995160e9bfeba681f01fa1d7d43e64cb410@gmail.com"},"message":"Merge branch 'master' into DragAndDrop","distinct":false,"url":"https://api.github.com/repos/ProCodingBad/Battleship/commits/7b78689a5371d60850ed2a097c4e94ba7e81842e"},{"sha":"bdbd7614ef111680f64637d2dbd7bb217491af30","author":{"name":"lukasz_czubernat","email":"fe1341cc65e939dff4440536fdf37b2202f19d1c@epam.com"},"message":"Pom changes\nIncrese version of battleships, because I've added a lot of new functions","distinct":false,"url":"https://api.github.com/repos/ProCodingBad/Battleship/commits/bdbd7614ef111680f64637d2dbd7bb217491af30"},{"sha":"b0658f25d149aa2a4b424bee311e7a2316e4e9bb","author":{"name":"kuba","email":"be182995160e9bfeba681f01fa1d7d43e64cb410@gmail.com"},"message":"Orientation, ship improvment and roatation, coordie changes.\nCoordinates implements now serializeable. I need this for ship.\nShip can be rotated by start dragging with right mouse button. Ship is using orientation enum for determine current orientation.\nSign is having now int representation and overloaded value of because GridPane can only return numeric values of cells.\nI will use it to send coordinates to the Core.\nMoreover I done small refactoring in GiuController.","distinct":false,"url":"https://api.github.com/repos/ProCodingBad/Battleship/commits/b0658f25d149aa2a4b424bee311e7a2316e4e9bb"},{"sha":"fd1b455b99b974d07a019a0911d57a00e05a63c2","author":{"name":"lukasz_czubernat","email":"fe1341cc65e939dff4440536fdf37b2202f19d1c@epam.com"},"message":"Project configuration\nThings that changed:\n1. Increse project version in pom\n2. Extend properties in pom (got rid of any numbers in pom)\n3. Add JaCoCo plugin and build configuration for it (including rules)\n4. Fix log4j2 configuration\n5. Add to .gitignore *.log\nThis commit will break project build process (because of jacoco rules) in next commit I'll add fixed tests.","distinct":false,"url":"https://api.github.com/repos/ProCodingBad/Battleship/commits/fd1b455b99b974d07a019a0911d57a00e05a63c2"},{"sha":"c97fbc78c499cb2397929f9b830a5ba58cf278aa","author":{"name":"lukasz_czubernat","email":"fe1341cc65e939dff4440536fdf37b2202f19d1c@epam.com"},"message":"Test fix and extension\nI've add tests for missing flow branches and also refactor and rename existing ones.\nThis fix problems reported in previous commit.","distinct":false,"url":"https://api.github.com/repos/ProCodingBad/Battleship/commits/c97fbc78c499cb2397929f9b830a5ba58cf278aa"},{"sha":"943845eced076497b0fee361510e283308c863d1","author":{"name":"lukasz_czubernat","email":"fe1341cc65e939dff4440536fdf37b2202f19d1c@epam.com"},"message":"JavaDocs\nI've added javaDocs comments to all classes and interfaces.\nAlso I've renamed main package in Core from controller.* to engine.*. This will prevent from having naming conflicts in project (in GUI there is also main package named controller.*).\nIn addition I've renamed few methods, because their names were not selfexplaining enough","distinct":false,"url":"https://api.github.com/repos/ProCodingBad/Battleship/commits/943845eced076497b0fee361510e283308c863d1"},{"sha":"45dacf8c2cb2d024b323d21353cbf36003d527f0","author":{"name":"lukasz_czubernat","email":"fe1341cc65e939dff4440536fdf37b2202f19d1c@epam.com"},"message":"Useless comments cleanup\nI've deleted reamaining useless commets containing phrase 'Created by ... on ...\", which are generated by IntelliJ by default.","distinct":false,"url":"https://api.github.com/repos/ProCodingBad/Battleship/commits/45dacf8c2cb2d024b323d21353cbf36003d527f0"},{"sha":"fc76ed14f182ef67f4ed349251be722d120e6bca","author":{"name":"kuba","email":"be182995160e9bfeba681f01fa1d7d43e64cb410@gmail.com"},"message":"little refactoring","distinct":false,"url":"https://api.github.com/repos/ProCodingBad/Battleship/commits/fc76ed14f182ef67f4ed349251be722d120e6bca"},{"sha":"84aefd01ea47d56860d11f34c54c3954eaa766e4","author":{"name":"lukasz_czubernat","email":"fe1341cc65e939dff4440536fdf37b2202f19d1c@epam.com"},"message":"Pom changes - add reporting\nI've added reporting section to project pom. Call mvn site to generate:\n1. JavaDocs for project\n2. Jacoco report\n3. Surefire report\nUnfortunately I don't know how to aggregate docs and reports (from each module) to project site directory.\nBacause of that everyone who wants to see reports have to open them separately (like <module>/target/site/index.html)","distinct":false,"url":"https://api.github.com/repos/ProCodingBad/Battleship/commits/84aefd01ea47d56860d11f34c54c3954eaa766e4"},{"sha":"88c326896f611d925bb1adea8d6f656bb5961813","author":{"name":"kuba","email":"be182995160e9bfeba681f01fa1d7d43e64cb410@gmail.com"},"message":"desscryption for maven modules","distinct":false,"url":"https://api.github.com/repos/ProCodingBad/Battleship/commits/88c326896f611d925bb1adea8d6f656bb5961813"},{"sha":"0cea1cf1db0160d6f95fd2e8e6ea0d2a6b4afa70","author":{"name":"Maciej Kocur","email":"39c7a8e75e00764f8af5b82cc490c0f3472dbee8@epam.com"},"message":"Merged GameEngine and DragAndDrop\nTwo working branch were merged.","distinct":true,"url":"https://api.github.com/repos/ProCodingBad/Battleship/commits/0cea1cf1db0160d6f95fd2e8e6ea0d2a6b4afa70"}]}
{"actor":{"display_login":"czyzu0507"}}