{"action":"created","issue":{"url":"https://api.github.com/repos/freedomjs/freedom-for-chrome/issues/90","repository_url":"https://api.github.com/repos/freedomjs/freedom-for-chrome","labels_url":"https://api.github.com/repos/freedomjs/freedom-for-chrome/issues/90/labels{/name}","comments_url":"https://api.github.com/repos/freedomjs/freedom-for-chrome/issues/90/comments","events_url":"https://api.github.com/repos/freedomjs/freedom-for-chrome/issues/90/events","html_url":"https://github.com/freedomjs/freedom-for-chrome/issues/90","id":177827871,"number":90,"title":"TCP socket close behaviour has changed","user":{"login":"trevj","id":5142116,"avatar_url":"https://avatars.githubusercontent.com/u/5142116?v=3","gravatar_id":"","url":"https://api.github.com/users/trevj","html_url":"https://github.com/trevj","followers_url":"https://api.github.com/users/trevj/followers","following_url":"https://api.github.com/users/trevj/following{/other_user}","gists_url":"https://api.github.com/users/trevj/gists{/gist_id}","starred_url":"https://api.github.com/users/trevj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevj/subscriptions","organizations_url":"https://api.github.com/users/trevj/orgs","repos_url":"https://api.github.com/users/trevj/repos","events_url":"https://api.github.com/users/trevj/events{/privacy}","received_events_url":"https://api.github.com/users/trevj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"soycode","id":587921,"avatar_url":"https://avatars.githubusercontent.com/u/587921?v=3","gravatar_id":"","url":"https://api.github.com/users/soycode","html_url":"https://github.com/soycode","followers_url":"https://api.github.com/users/soycode/followers","following_url":"https://api.github.com/users/soycode/following{/other_user}","gists_url":"https://api.github.com/users/soycode/gists{/gist_id}","starred_url":"https://api.github.com/users/soycode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soycode/subscriptions","organizations_url":"https://api.github.com/users/soycode/orgs","repos_url":"https://api.github.com/users/soycode/repos","events_url":"https://api.github.com/users/soycode/events{/privacy}","received_events_url":"https://api.github.com/users/soycode/received_events","type":"User","site_admin":false},"assignees":[{"login":"soycode","id":587921,"avatar_url":"https://avatars.githubusercontent.com/u/587921?v=3","gravatar_id":"","url":"https://api.github.com/users/soycode","html_url":"https://github.com/soycode","followers_url":"https://api.github.com/users/soycode/followers","following_url":"https://api.github.com/users/soycode/following{/other_user}","gists_url":"https://api.github.com/users/soycode/gists{/gist_id}","starred_url":"https://api.github.com/users/soycode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soycode/subscriptions","organizations_url":"https://api.github.com/users/soycode/orgs","repos_url":"https://api.github.com/users/soycode/repos","events_url":"https://api.github.com/users/soycode/events{/privacy}","received_events_url":"https://api.github.com/users/soycode/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-09-19T16:11:41Z","updated_at":"2016-09-27T18:22:46Z","closed_at":null,"body":"I'm running Chrome 53.0.2785.116 on Linux.\r\n\r\nConsider a simple programme which:\r\n * creates a client socket\r\n * connects to some server\r\n * immediately closes that socket\r\n\r\nTwo issues:\r\n 1. unchecked `runtime.lastError` in the javascript console (it comes from `dispatchDisconnect`: https://github.com/freedomjs/freedom-for-chrome/blob/master/providers/core.tcpsocket.js#L419)\r\n 1. `dispatchDisconnect` dispatches the wrong `errcode`: `CONNECTION_CLOSED`, when it should be `SUCCESS` (the problem is Chrome is returning -100 rather than 0 to `handleReadError`: https://github.com/freedomjs/freedom-for-chrome/blob/master/providers/core.tcpsocket.js#L519)"},"comment":{"url":"https://api.github.com/repos/freedomjs/freedom-for-chrome/issues/comments/249952777","html_url":"https://github.com/freedomjs/freedom-for-chrome/issues/90#issuecomment-249952777","issue_url":"https://api.github.com/repos/freedomjs/freedom-for-chrome/issues/90","id":249952777,"user":{"login":"soycode","id":587921,"avatar_url":"https://avatars.githubusercontent.com/u/587921?v=3","gravatar_id":"","url":"https://api.github.com/users/soycode","html_url":"https://github.com/soycode","followers_url":"https://api.github.com/users/soycode/followers","following_url":"https://api.github.com/users/soycode/following{/other_user}","gists_url":"https://api.github.com/users/soycode/gists{/gist_id}","starred_url":"https://api.github.com/users/soycode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soycode/subscriptions","organizations_url":"https://api.github.com/users/soycode/orgs","repos_url":"https://api.github.com/users/soycode/repos","events_url":"https://api.github.com/users/soycode/events{/privacy}","received_events_url":"https://api.github.com/users/soycode/received_events","type":"User","site_admin":false},"created_at":"2016-09-27T18:22:46Z","updated_at":"2016-09-27T18:22:46Z","body":"To document here - we went with the \"paper it over\" approach for now, with the possibility of filing an issue w/Chrome in future. The pull requests linked above handle the issue for now."}}
{"actor":{"display_login":"soycode"}}