{"action":"created","comment":{"url":"https://api.github.com/repos/dlang/druntime/pulls/comments/66440108","id":66440108,"diff_hunk":"@@ -1341,16 +1336,15 @@ version( unittest )\n     }\n \n \n-    void testType(T)( T val = T.init + 1 ) pure nothrow\n+    void testType(T)( T val = T.init + 1 ) pure nothrow @nogc @safe\n     {\n         testCAS!(T)( val );\n         testLoadStore!(MemoryOrder.seq, T)( val );\n         testLoadStore!(MemoryOrder.raw, T)( val );\n     }\n \n-\n-    //@@@BUG@@@ http://d.puremagic.com/issues/show_bug.cgi?id=8081\n-    /+pure nothrow+/ unittest\n+@safe\n+    pure nothrow unittest","path":"src/core/atomic.d","position":680,"original_position":680,"commit_id":"0546a1cb22f5159e0e508fdf1d7d913fe87749e3","original_commit_id":"0546a1cb22f5159e0e508fdf1d7d913fe87749e3","user":{"login":"schveiguy","id":580778,"avatar_url":"https://avatars.githubusercontent.com/u/580778?v=3","gravatar_id":"","url":"https://api.github.com/users/schveiguy","html_url":"https://github.com/schveiguy","followers_url":"https://api.github.com/users/schveiguy/followers","following_url":"https://api.github.com/users/schveiguy/following{/other_user}","gists_url":"https://api.github.com/users/schveiguy/gists{/gist_id}","starred_url":"https://api.github.com/users/schveiguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schveiguy/subscriptions","organizations_url":"https://api.github.com/users/schveiguy/orgs","repos_url":"https://api.github.com/users/schveiguy/repos","events_url":"https://api.github.com/users/schveiguy/events{/privacy}","received_events_url":"https://api.github.com/users/schveiguy/received_events","type":"User","site_admin":false},"body":"The added `@safe` here is causing problems in some builds. But I can't figure out why. The error is on line 1386, can't take the address of a local in a `@safe` function.","created_at":"2016-06-09T13:30:32Z","updated_at":"2016-06-09T13:30:32Z","html_url":"https://github.com/dlang/druntime/pull/1589#discussion_r66440108","pull_request_url":"https://api.github.com/repos/dlang/druntime/pulls/1589","_links":{"self":{"href":"https://api.github.com/repos/dlang/druntime/pulls/comments/66440108"},"html":{"href":"https://github.com/dlang/druntime/pull/1589#discussion_r66440108"},"pull_request":{"href":"https://api.github.com/repos/dlang/druntime/pulls/1589"}}},"pull_request":{"url":"https://api.github.com/repos/dlang/druntime/pulls/1589","id":73192523,"html_url":"https://github.com/dlang/druntime/pull/1589","diff_url":"https://github.com/dlang/druntime/pull/1589.diff","patch_url":"https://github.com/dlang/druntime/pull/1589.patch","issue_url":"https://api.github.com/repos/dlang/druntime/issues/1589","number":1589,"state":"open","locked":false,"title":"fix Issue 14117 - core.atomic should be @safe","user":{"login":"WalterBright","id":568298,"avatar_url":"https://avatars.githubusercontent.com/u/568298?v=3","gravatar_id":"","url":"https://api.github.com/users/WalterBright","html_url":"https://github.com/WalterBright","followers_url":"https://api.github.com/users/WalterBright/followers","following_url":"https://api.github.com/users/WalterBright/following{/other_user}","gists_url":"https://api.github.com/users/WalterBright/gists{/gist_id}","starred_url":"https://api.github.com/users/WalterBright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WalterBright/subscriptions","organizations_url":"https://api.github.com/users/WalterBright/orgs","repos_url":"https://api.github.com/users/WalterBright/repos","events_url":"https://api.github.com/users/WalterBright/events{/privacy}","received_events_url":"https://api.github.com/users/WalterBright/received_events","type":"User","site_admin":false},"body":"Added @trusted and @nogc where necessary, too.","created_at":"2016-06-09T10:44:58Z","updated_at":"2016-06-09T13:30:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78f320b7403633aae664e47158edf433256c6da7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dlang/druntime/pulls/1589/commits","review_comments_url":"https://api.github.com/repos/dlang/druntime/pulls/1589/comments","review_comment_url":"https://api.github.com/repos/dlang/druntime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dlang/druntime/issues/1589/comments","statuses_url":"https://api.github.com/repos/dlang/druntime/statuses/0546a1cb22f5159e0e508fdf1d7d913fe87749e3","head":{"label":"WalterBright:fix14117","ref":"fix14117","sha":"0546a1cb22f5159e0e508fdf1d7d913fe87749e3","user":{"login":"WalterBright","id":568298,"avatar_url":"https://avatars.githubusercontent.com/u/568298?v=3","gravatar_id":"","url":"https://api.github.com/users/WalterBright","html_url":"https://github.com/WalterBright","followers_url":"https://api.github.com/users/WalterBright/followers","following_url":"https://api.github.com/users/WalterBright/following{/other_user}","gists_url":"https://api.github.com/users/WalterBright/gists{/gist_id}","starred_url":"https://api.github.com/users/WalterBright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WalterBright/subscriptions","organizations_url":"https://api.github.com/users/WalterBright/orgs","repos_url":"https://api.github.com/users/WalterBright/repos","events_url":"https://api.github.com/users/WalterBright/events{/privacy}","received_events_url":"https://api.github.com/users/WalterBright/received_events","type":"User","site_admin":false},"repo":{"id":7598904,"name":"druntime","full_name":"WalterBright/druntime","owner":{"login":"WalterBright","id":568298,"avatar_url":"https://avatars.githubusercontent.com/u/568298?v=3","gravatar_id":"","url":"https://api.github.com/users/WalterBright","html_url":"https://github.com/WalterBright","followers_url":"https://api.github.com/users/WalterBright/followers","following_url":"https://api.github.com/users/WalterBright/following{/other_user}","gists_url":"https://api.github.com/users/WalterBright/gists{/gist_id}","starred_url":"https://api.github.com/users/WalterBright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WalterBright/subscriptions","organizations_url":"https://api.github.com/users/WalterBright/orgs","repos_url":"https://api.github.com/users/WalterBright/repos","events_url":"https://api.github.com/users/WalterBright/events{/privacy}","received_events_url":"https://api.github.com/users/WalterBright/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/WalterBright/druntime","description":"Low level runtime library for the D programming language","fork":true,"url":"https://api.github.com/repos/WalterBright/druntime","forks_url":"https://api.github.com/repos/WalterBright/druntime/forks","keys_url":"https://api.github.com/repos/WalterBright/druntime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WalterBright/druntime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WalterBright/druntime/teams","hooks_url":"https://api.github.com/repos/WalterBright/druntime/hooks","issue_events_url":"https://api.github.com/repos/WalterBright/druntime/issues/events{/number}","events_url":"https://api.github.com/repos/WalterBright/druntime/events","assignees_url":"https://api.github.com/repos/WalterBright/druntime/assignees{/user}","branches_url":"https://api.github.com/repos/WalterBright/druntime/branches{/branch}","tags_url":"https://api.github.com/repos/WalterBright/druntime/tags","blobs_url":"https://api.github.com/repos/WalterBright/druntime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WalterBright/druntime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WalterBright/druntime/git/refs{/sha}","trees_url":"https://api.github.com/repos/WalterBright/druntime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WalterBright/druntime/statuses/{sha}","languages_url":"https://api.github.com/repos/WalterBright/druntime/languages","stargazers_url":"https://api.github.com/repos/WalterBright/druntime/stargazers","contributors_url":"https://api.github.com/repos/WalterBright/druntime/contributors","subscribers_url":"https://api.github.com/repos/WalterBright/druntime/subscribers","subscription_url":"https://api.github.com/repos/WalterBright/druntime/subscription","commits_url":"https://api.github.com/repos/WalterBright/druntime/commits{/sha}","git_commits_url":"https://api.github.com/repos/WalterBright/druntime/git/commits{/sha}","comments_url":"https://api.github.com/repos/WalterBright/druntime/comments{/number}","issue_comment_url":"https://api.github.com/repos/WalterBright/druntime/issues/comments{/number}","contents_url":"https://api.github.com/repos/WalterBright/druntime/contents/{+path}","compare_url":"https://api.github.com/repos/WalterBright/druntime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WalterBright/druntime/merges","archive_url":"https://api.github.com/repos/WalterBright/druntime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WalterBright/druntime/downloads","issues_url":"https://api.github.com/repos/WalterBright/druntime/issues{/number}","pulls_url":"https://api.github.com/repos/WalterBright/druntime/pulls{/number}","milestones_url":"https://api.github.com/repos/WalterBright/druntime/milestones{/number}","notifications_url":"https://api.github.com/repos/WalterBright/druntime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WalterBright/druntime/labels{/name}","releases_url":"https://api.github.com/repos/WalterBright/druntime/releases{/id}","deployments_url":"https://api.github.com/repos/WalterBright/druntime/deployments","created_at":"2013-01-14T05:22:04Z","updated_at":"2015-05-02T06:42:28Z","pushed_at":"2016-06-09T10:55:24Z","git_url":"git://github.com/WalterBright/druntime.git","ssh_url":"git@github.com:WalterBright/druntime.git","clone_url":"https://github.com/WalterBright/druntime.git","svn_url":"https://github.com/WalterBright/druntime","homepage":"d-programming-language.org","size":11726,"stargazers_count":0,"watchers_count":0,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dlang:master","ref":"master","sha":"3ac2b3b97347fa444c627d17bbeae0ddc22b01a8","user":{"login":"dlang","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"repo":{"id":1257087,"name":"druntime","full_name":"dlang/druntime","owner":{"login":"dlang","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dlang/druntime","description":"Low level runtime library for the D programming language","fork":false,"url":"https://api.github.com/repos/dlang/druntime","forks_url":"https://api.github.com/repos/dlang/druntime/forks","keys_url":"https://api.github.com/repos/dlang/druntime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dlang/druntime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dlang/druntime/teams","hooks_url":"https://api.github.com/repos/dlang/druntime/hooks","issue_events_url":"https://api.github.com/repos/dlang/druntime/issues/events{/number}","events_url":"https://api.github.com/repos/dlang/druntime/events","assignees_url":"https://api.github.com/repos/dlang/druntime/assignees{/user}","branches_url":"https://api.github.com/repos/dlang/druntime/branches{/branch}","tags_url":"https://api.github.com/repos/dlang/druntime/tags","blobs_url":"https://api.github.com/repos/dlang/druntime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dlang/druntime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dlang/druntime/git/refs{/sha}","trees_url":"https://api.github.com/repos/dlang/druntime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dlang/druntime/statuses/{sha}","languages_url":"https://api.github.com/repos/dlang/druntime/languages","stargazers_url":"https://api.github.com/repos/dlang/druntime/stargazers","contributors_url":"https://api.github.com/repos/dlang/druntime/contributors","subscribers_url":"https://api.github.com/repos/dlang/druntime/subscribers","subscription_url":"https://api.github.com/repos/dlang/druntime/subscription","commits_url":"https://api.github.com/repos/dlang/druntime/commits{/sha}","git_commits_url":"https://api.github.com/repos/dlang/druntime/git/commits{/sha}","comments_url":"https://api.github.com/repos/dlang/druntime/comments{/number}","issue_comment_url":"https://api.github.com/repos/dlang/druntime/issues/comments{/number}","contents_url":"https://api.github.com/repos/dlang/druntime/contents/{+path}","compare_url":"https://api.github.com/repos/dlang/druntime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dlang/druntime/merges","archive_url":"https://api.github.com/repos/dlang/druntime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dlang/druntime/downloads","issues_url":"https://api.github.com/repos/dlang/druntime/issues{/number}","pulls_url":"https://api.github.com/repos/dlang/druntime/pulls{/number}","milestones_url":"https://api.github.com/repos/dlang/druntime/milestones{/number}","notifications_url":"https://api.github.com/repos/dlang/druntime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dlang/druntime/labels{/name}","releases_url":"https://api.github.com/repos/dlang/druntime/releases{/id}","deployments_url":"https://api.github.com/repos/dlang/druntime/deployments","created_at":"2011-01-15T07:01:38Z","updated_at":"2016-06-07T13:18:14Z","pushed_at":"2016-06-09T10:55:24Z","git_url":"git://github.com/dlang/druntime.git","ssh_url":"git@github.com:dlang/druntime.git","clone_url":"https://github.com/dlang/druntime.git","svn_url":"https://github.com/dlang/druntime","homepage":"dlang.org","size":16928,"stargazers_count":404,"watchers_count":404,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":288,"mirror_url":null,"open_issues_count":40,"forks":288,"open_issues":40,"watchers":404,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dlang/druntime/pulls/1589"},"html":{"href":"https://github.com/dlang/druntime/pull/1589"},"issue":{"href":"https://api.github.com/repos/dlang/druntime/issues/1589"},"comments":{"href":"https://api.github.com/repos/dlang/druntime/issues/1589/comments"},"review_comments":{"href":"https://api.github.com/repos/dlang/druntime/pulls/1589/comments"},"review_comment":{"href":"https://api.github.com/repos/dlang/druntime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dlang/druntime/pulls/1589/commits"},"statuses":{"href":"https://api.github.com/repos/dlang/druntime/statuses/0546a1cb22f5159e0e508fdf1d7d913fe87749e3"}}}}
{"actor":{"display_login":"schveiguy"}}