{"action":"created","issue":{"url":"https://api.github.com/repos/xwiki-labs/cryptpad/issues/54","repository_url":"https://api.github.com/repos/xwiki-labs/cryptpad","labels_url":"https://api.github.com/repos/xwiki-labs/cryptpad/issues/54/labels{/name}","comments_url":"https://api.github.com/repos/xwiki-labs/cryptpad/issues/54/comments","events_url":"https://api.github.com/repos/xwiki-labs/cryptpad/issues/54/events","html_url":"https://github.com/xwiki-labs/cryptpad/pull/54","id":184576049,"number":54,"title":"Add spanish translation","user":{"login":"heticor915","id":4080895,"avatar_url":"https://avatars.githubusercontent.com/u/4080895?v=3","gravatar_id":"","url":"https://api.github.com/users/heticor915","html_url":"https://github.com/heticor915","followers_url":"https://api.github.com/users/heticor915/followers","following_url":"https://api.github.com/users/heticor915/following{/other_user}","gists_url":"https://api.github.com/users/heticor915/gists{/gist_id}","starred_url":"https://api.github.com/users/heticor915/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heticor915/subscriptions","organizations_url":"https://api.github.com/users/heticor915/orgs","repos_url":"https://api.github.com/users/heticor915/repos","events_url":"https://api.github.com/users/heticor915/events{/privacy}","received_events_url":"https://api.github.com/users/heticor915/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-10-21T21:41:45Z","updated_at":"2016-10-24T10:10:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xwiki-labs/cryptpad/pulls/54","html_url":"https://github.com/xwiki-labs/cryptpad/pull/54","diff_url":"https://github.com/xwiki-labs/cryptpad/pull/54.diff","patch_url":"https://github.com/xwiki-labs/cryptpad/pull/54.patch"},"body":"Hi I would like to add spanish support to cryptpad, I've follow the standard rules for translatations. Add the hacktoberfest label to this repo, There're many in the world that want to contribute to this repo "},"comment":{"url":"https://api.github.com/repos/xwiki-labs/cryptpad/issues/comments/255700952","html_url":"https://github.com/xwiki-labs/cryptpad/pull/54#issuecomment-255700952","issue_url":"https://api.github.com/repos/xwiki-labs/cryptpad/issues/54","id":255700952,"user":{"login":"ansuz","id":1264398,"avatar_url":"https://avatars.githubusercontent.com/u/1264398?v=3","gravatar_id":"","url":"https://api.github.com/users/ansuz","html_url":"https://github.com/ansuz","followers_url":"https://api.github.com/users/ansuz/followers","following_url":"https://api.github.com/users/ansuz/following{/other_user}","gists_url":"https://api.github.com/users/ansuz/gists{/gist_id}","starred_url":"https://api.github.com/users/ansuz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansuz/subscriptions","organizations_url":"https://api.github.com/users/ansuz/orgs","repos_url":"https://api.github.com/users/ansuz/repos","events_url":"https://api.github.com/users/ansuz/events{/privacy}","received_events_url":"https://api.github.com/users/ansuz/received_events","type":"User","site_admin":false},"created_at":"2016-10-24T10:10:42Z","updated_at":"2016-10-24T10:10:42Z","body":"Hi again @heticor915.\r\n\r\nI've reviewed your PR, and there were a few issues with it.\r\n\r\n1. It's based off of master, and not our development branch [soon](https://github.com/xwiki-labs/cryptpad/tree/soon).\r\n  - that's hardly your fault, as there was no documentation about adding translations, we'll work on this\r\n  - I've gone ahead and merged it into soon, however...\r\n2. Since it's not based against our development branch, there are a few keys that are missing.\r\n  - my knowledge of Spanish is limited, so I'll need some more help with this\r\n  - to make things a little easier, and to make sure we're aware of translation issues in the future, I added [a test](https://github.com/xwiki-labs/cryptpad/commit/841ded8fdc403c53dda9cdffa0a58532f4a83993) that will let us know when a translation is missing a key which is present in the default English version.\r\n  - the report on which keys are missing is included below\r\n\r\n```\r\nkey [yourself] is missing from translation [es]\r\nkey [anonymousUsers] is missing from translation [es]\r\nkey [anonymousUser] is missing from translation [es]\r\nkey [share] is missing from translation [es]\r\nkey [users] is missing from translation [es]\r\nkey [editing] is missing from translation [es]\r\nkey [viewing] is missing from translation [es]\r\nkey [editShare] is missing from translation [es]\r\nkey [editShareTitle] is missing from translation [es]\r\nkey [viewShare] is missing from translation [es]\r\nkey [viewShareTitle] is missing from translation [es]\r\nkey [viewOpen] is missing from translation [es]\r\nkey [viewOpenTitle] is missing from translation [es]\r\nkey [header_xwiki] is missing from translation [es]\r\n```\r\n\r\nOnce those have been added, I'll see about getting this deployed as soon as possible. Thanks for your contribution!"}}
{"actor":{"display_login":"ansuz"}}