{"action":"created","comment":{"url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/pulls/comments/84320003","pull_request_review_id":5105021,"id":84320003,"diff_hunk":"@@ -58,21 +59,29 @@\n     private static transient GSSCredential localIWACredentials;\r\n     private static transient KerberosPrincipal serverPrincipal;\r\n \r\n-    // Shared Map to hold IWA GSS credentials for respective Kerberos servers\r\n-    private static transient Map<String, GSSCredential> gssCredentialMap = new ConcurrentHashMap<>();\r\n     private static Log log = LogFactory.getLog(IWAAuthenticationUtil.class);\r\n \r\n \r\n     public static void initializeIWALocalAuthenticator() throws GSSException, PrivilegedActionException, LoginException {\r\n         RealmService realmService = dataHolder.getRealmService();\r\n+        RealmConfiguration realmConfiguration = realmService.getBootstrapRealmConfiguration();\r\n \r\n-        String servicePrincipalName =\r\n-                realmService.getBootstrapRealmConfiguration().getUserStoreProperty(IWAConstants.SPN_NAME);\r\n-        String servicePrincipalPassword =\r\n-                realmService.getBootstrapRealmConfiguration().getUserStoreProperty(IWAConstants.SPN_PASSWORD);\r\n+        // TODO : read this config from a file in registry\r","path":"components/org.wso2.carbon.identity.application.authenticator.iwa/src/main/java/org/wso2/carbon/identity/application/authenticator/iwa/IWAAuthenticationUtil.java","position":50,"original_position":50,"commit_id":"b50f8f3916432a7ba2f1a3175ee6efc170934cd5","original_commit_id":"b50f8f3916432a7ba2f1a3175ee6efc170934cd5","user":{"login":"Niranjan-K","id":5525926,"avatar_url":"https://avatars.githubusercontent.com/u/5525926?v=3","gravatar_id":"","url":"https://api.github.com/users/Niranjan-K","html_url":"https://github.com/Niranjan-K","followers_url":"https://api.github.com/users/Niranjan-K/followers","following_url":"https://api.github.com/users/Niranjan-K/following{/other_user}","gists_url":"https://api.github.com/users/Niranjan-K/gists{/gist_id}","starred_url":"https://api.github.com/users/Niranjan-K/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Niranjan-K/subscriptions","organizations_url":"https://api.github.com/users/Niranjan-K/orgs","repos_url":"https://api.github.com/users/Niranjan-K/repos","events_url":"https://api.github.com/users/Niranjan-K/events{/privacy}","received_events_url":"https://api.github.com/users/Niranjan-K/received_events","type":"User","site_admin":false},"body":"Do we have a JIRA for ToDo?","created_at":"2016-10-20T16:14:39Z","updated_at":"2016-10-20T16:14:39Z","html_url":"https://github.com/wso2-extensions/identity-local-auth-iwa/pull/32#discussion_r84320003","pull_request_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/pulls/32","_links":{"self":{"href":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/pulls/comments/84320003"},"html":{"href":"https://github.com/wso2-extensions/identity-local-auth-iwa/pull/32#discussion_r84320003"},"pull_request":{"href":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/pulls/32","id":86891120,"html_url":"https://github.com/wso2-extensions/identity-local-auth-iwa/pull/32","diff_url":"https://github.com/wso2-extensions/identity-local-auth-iwa/pull/32.diff","patch_url":"https://github.com/wso2-extensions/identity-local-auth-iwa/pull/32.patch","issue_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/issues/32","number":32,"state":"closed","locked":false,"title":"IDENTITY-4793 : Improving credentials handling IWA federated authenticator","user":{"login":"mefarazath","id":5237653,"avatar_url":"https://avatars.githubusercontent.com/u/5237653?v=3","gravatar_id":"","url":"https://api.github.com/users/mefarazath","html_url":"https://github.com/mefarazath","followers_url":"https://api.github.com/users/mefarazath/followers","following_url":"https://api.github.com/users/mefarazath/following{/other_user}","gists_url":"https://api.github.com/users/mefarazath/gists{/gist_id}","starred_url":"https://api.github.com/users/mefarazath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mefarazath/subscriptions","organizations_url":"https://api.github.com/users/mefarazath/orgs","repos_url":"https://api.github.com/users/mefarazath/repos","events_url":"https://api.github.com/users/mefarazath/events{/privacy}","received_events_url":"https://api.github.com/users/mefarazath/received_events","type":"User","site_admin":false},"body":"* Removed storing credentials in an in-memory concurrent hashmap.\r\n* Moving Util methods from authenticators.\r\n* Use char array for passwords.\r\n* Minor refactoring.","created_at":"2016-09-27T09:19:50Z","updated_at":"2016-10-20T16:16:07Z","closed_at":"2016-09-28T12:40:53Z","merged_at":"2016-09-28T12:40:53Z","merge_commit_sha":"66383c920ff8ae4c57deeb39ac6055ab044bd801","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/pulls/32/commits","review_comments_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/pulls/32/comments","review_comment_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/issues/32/comments","statuses_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/statuses/b50f8f3916432a7ba2f1a3175ee6efc170934cd5","head":{"label":"mefarazath:remove-credential-map","ref":"remove-credential-map","sha":"b50f8f3916432a7ba2f1a3175ee6efc170934cd5","user":{"login":"mefarazath","id":5237653,"avatar_url":"https://avatars.githubusercontent.com/u/5237653?v=3","gravatar_id":"","url":"https://api.github.com/users/mefarazath","html_url":"https://github.com/mefarazath","followers_url":"https://api.github.com/users/mefarazath/followers","following_url":"https://api.github.com/users/mefarazath/following{/other_user}","gists_url":"https://api.github.com/users/mefarazath/gists{/gist_id}","starred_url":"https://api.github.com/users/mefarazath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mefarazath/subscriptions","organizations_url":"https://api.github.com/users/mefarazath/orgs","repos_url":"https://api.github.com/users/mefarazath/repos","events_url":"https://api.github.com/users/mefarazath/events{/privacy}","received_events_url":"https://api.github.com/users/mefarazath/received_events","type":"User","site_admin":false},"repo":{"id":58197725,"name":"identity-local-auth-iwa","full_name":"mefarazath/identity-local-auth-iwa","owner":{"login":"mefarazath","id":5237653,"avatar_url":"https://avatars.githubusercontent.com/u/5237653?v=3","gravatar_id":"","url":"https://api.github.com/users/mefarazath","html_url":"https://github.com/mefarazath","followers_url":"https://api.github.com/users/mefarazath/followers","following_url":"https://api.github.com/users/mefarazath/following{/other_user}","gists_url":"https://api.github.com/users/mefarazath/gists{/gist_id}","starred_url":"https://api.github.com/users/mefarazath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mefarazath/subscriptions","organizations_url":"https://api.github.com/users/mefarazath/orgs","repos_url":"https://api.github.com/users/mefarazath/repos","events_url":"https://api.github.com/users/mefarazath/events{/privacy}","received_events_url":"https://api.github.com/users/mefarazath/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mefarazath/identity-local-auth-iwa","description":null,"fork":true,"url":"https://api.github.com/repos/mefarazath/identity-local-auth-iwa","forks_url":"https://api.github.com/repos/mefarazath/identity-local-auth-iwa/forks","keys_url":"https://api.github.com/repos/mefarazath/identity-local-auth-iwa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mefarazath/identity-local-auth-iwa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mefarazath/identity-local-auth-iwa/teams","hooks_url":"https://api.github.com/repos/mefarazath/identity-local-auth-iwa/hooks","issue_events_url":"https://api.github.com/repos/mefarazath/identity-local-auth-iwa/issues/events{/number}","events_url":"https://api.github.com/repos/mefarazath/identity-local-auth-iwa/events","assignees_url":"https://api.github.com/repos/mefarazath/identity-local-auth-iwa/assignees{/user}","branches_url":"https://api.github.com/repos/mefarazath/identity-local-auth-iwa/branches{/branch}","tags_url":"https://api.github.com/repos/mefarazath/identity-local-auth-iwa/tags","blobs_url":"https://api.github.com/repos/mefarazath/identity-local-auth-iwa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mefarazath/identity-local-auth-iwa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mefarazath/identity-local-auth-iwa/git/refs{/sha}","trees_url":"https://api.github.com/repos/mefarazath/identity-local-auth-iwa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mefarazath/identity-local-auth-iwa/statuses/{sha}","languages_url":"https://api.github.com/repos/mefarazath/identity-local-auth-iwa/languages","stargazers_url":"https://api.github.com/repos/mefarazath/identity-local-auth-iwa/stargazers","contributors_url":"https://api.github.com/repos/mefarazath/identity-local-auth-iwa/contributors","subscribers_url":"https://api.github.com/repos/mefarazath/identity-local-auth-iwa/subscribers","subscription_url":"https://api.github.com/repos/mefarazath/identity-local-auth-iwa/subscription","commits_url":"https://api.github.com/repos/mefarazath/identity-local-auth-iwa/commits{/sha}","git_commits_url":"https://api.github.com/repos/mefarazath/identity-local-auth-iwa/git/commits{/sha}","comments_url":"https://api.github.com/repos/mefarazath/identity-local-auth-iwa/comments{/number}","issue_comment_url":"https://api.github.com/repos/mefarazath/identity-local-auth-iwa/issues/comments{/number}","contents_url":"https://api.github.com/repos/mefarazath/identity-local-auth-iwa/contents/{+path}","compare_url":"https://api.github.com/repos/mefarazath/identity-local-auth-iwa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mefarazath/identity-local-auth-iwa/merges","archive_url":"https://api.github.com/repos/mefarazath/identity-local-auth-iwa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mefarazath/identity-local-auth-iwa/downloads","issues_url":"https://api.github.com/repos/mefarazath/identity-local-auth-iwa/issues{/number}","pulls_url":"https://api.github.com/repos/mefarazath/identity-local-auth-iwa/pulls{/number}","milestones_url":"https://api.github.com/repos/mefarazath/identity-local-auth-iwa/milestones{/number}","notifications_url":"https://api.github.com/repos/mefarazath/identity-local-auth-iwa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mefarazath/identity-local-auth-iwa/labels{/name}","releases_url":"https://api.github.com/repos/mefarazath/identity-local-auth-iwa/releases{/id}","deployments_url":"https://api.github.com/repos/mefarazath/identity-local-auth-iwa/deployments","created_at":"2016-05-06T09:50:30Z","updated_at":"2016-05-06T09:50:31Z","pushed_at":"2016-09-28T12:31:13Z","git_url":"git://github.com/mefarazath/identity-local-auth-iwa.git","ssh_url":"git@github.com:mefarazath/identity-local-auth-iwa.git","clone_url":"https://github.com/mefarazath/identity-local-auth-iwa.git","svn_url":"https://github.com/mefarazath/identity-local-auth-iwa","homepage":null,"size":127,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wso2-extensions:master","ref":"master","sha":"4bd484c1ff52a687e03b7a481c0de5d76d2292c0","user":{"login":"wso2-extensions","id":17171218,"avatar_url":"https://avatars.githubusercontent.com/u/17171218?v=3","gravatar_id":"","url":"https://api.github.com/users/wso2-extensions","html_url":"https://github.com/wso2-extensions","followers_url":"https://api.github.com/users/wso2-extensions/followers","following_url":"https://api.github.com/users/wso2-extensions/following{/other_user}","gists_url":"https://api.github.com/users/wso2-extensions/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2-extensions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2-extensions/subscriptions","organizations_url":"https://api.github.com/users/wso2-extensions/orgs","repos_url":"https://api.github.com/users/wso2-extensions/repos","events_url":"https://api.github.com/users/wso2-extensions/events{/privacy}","received_events_url":"https://api.github.com/users/wso2-extensions/received_events","type":"Organization","site_admin":false},"repo":{"id":52704872,"name":"identity-local-auth-iwa","full_name":"wso2-extensions/identity-local-auth-iwa","owner":{"login":"wso2-extensions","id":17171218,"avatar_url":"https://avatars.githubusercontent.com/u/17171218?v=3","gravatar_id":"","url":"https://api.github.com/users/wso2-extensions","html_url":"https://github.com/wso2-extensions","followers_url":"https://api.github.com/users/wso2-extensions/followers","following_url":"https://api.github.com/users/wso2-extensions/following{/other_user}","gists_url":"https://api.github.com/users/wso2-extensions/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2-extensions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2-extensions/subscriptions","organizations_url":"https://api.github.com/users/wso2-extensions/orgs","repos_url":"https://api.github.com/users/wso2-extensions/repos","events_url":"https://api.github.com/users/wso2-extensions/events{/privacy}","received_events_url":"https://api.github.com/users/wso2-extensions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wso2-extensions/identity-local-auth-iwa","description":null,"fork":false,"url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa","forks_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/forks","keys_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/teams","hooks_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/hooks","issue_events_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/issues/events{/number}","events_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/events","assignees_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/assignees{/user}","branches_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/branches{/branch}","tags_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/tags","blobs_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/git/refs{/sha}","trees_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/statuses/{sha}","languages_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/languages","stargazers_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/stargazers","contributors_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/contributors","subscribers_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/subscribers","subscription_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/subscription","commits_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/commits{/sha}","git_commits_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/git/commits{/sha}","comments_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/comments{/number}","issue_comment_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/issues/comments{/number}","contents_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/contents/{+path}","compare_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/merges","archive_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/downloads","issues_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/issues{/number}","pulls_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/pulls{/number}","milestones_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/milestones{/number}","notifications_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/labels{/name}","releases_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/releases{/id}","deployments_url":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/deployments","created_at":"2016-02-28T04:39:42Z","updated_at":"2016-03-03T05:54:28Z","pushed_at":"2016-10-04T14:24:32Z","git_url":"git://github.com/wso2-extensions/identity-local-auth-iwa.git","ssh_url":"git@github.com:wso2-extensions/identity-local-auth-iwa.git","clone_url":"https://github.com/wso2-extensions/identity-local-auth-iwa.git","svn_url":"https://github.com/wso2-extensions/identity-local-auth-iwa","homepage":null,"size":175,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":0,"forks":10,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/pulls/32"},"html":{"href":"https://github.com/wso2-extensions/identity-local-auth-iwa/pull/32"},"issue":{"href":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/issues/32"},"comments":{"href":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/wso2-extensions/identity-local-auth-iwa/statuses/b50f8f3916432a7ba2f1a3175ee6efc170934cd5"}}}}
{"actor":{"display_login":"Niranjan-K"}}