{"action":"created","issue":{"url":"https://api.github.com/repos/mattstauffer/pulledover/issues/12","repository_url":"https://api.github.com/repos/mattstauffer/pulledover","labels_url":"https://api.github.com/repos/mattstauffer/pulledover/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/mattstauffer/pulledover/issues/12/comments","events_url":"https://api.github.com/repos/mattstauffer/pulledover/issues/12/events","html_url":"https://github.com/mattstauffer/pulledover/pull/12","id":133171319,"number":12,"title":"Style tweaks and Mobile Optimization","user":{"login":"JacobBennett","id":1517011,"avatar_url":"https://avatars.githubusercontent.com/u/1517011?v=3","gravatar_id":"","url":"https://api.github.com/users/JacobBennett","html_url":"https://github.com/JacobBennett","followers_url":"https://api.github.com/users/JacobBennett/followers","following_url":"https://api.github.com/users/JacobBennett/following{/other_user}","gists_url":"https://api.github.com/users/JacobBennett/gists{/gist_id}","starred_url":"https://api.github.com/users/JacobBennett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JacobBennett/subscriptions","organizations_url":"https://api.github.com/users/JacobBennett/orgs","repos_url":"https://api.github.com/users/JacobBennett/repos","events_url":"https://api.github.com/users/JacobBennett/events{/privacy}","received_events_url":"https://api.github.com/users/JacobBennett/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-12T06:57:50Z","updated_at":"2016-02-12T15:30:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mattstauffer/pulledover/pulls/12","html_url":"https://github.com/mattstauffer/pulledover/pull/12","diff_url":"https://github.com/mattstauffer/pulledover/pull/12.diff","patch_url":"https://github.com/mattstauffer/pulledover/pull/12.patch"},"body":"- Included a hero image at a reduced size for mobile viewers (still 2x for retina)\r\n- Fixed an issue where hero section was overflowing viewport size\r\n- Increased hit size on nav for mobile visitors\r\n\r\n**Note:** I decided to use `calc` to determine the height for the `.page-home-hero` only after considering [CanIUse](http://caniuse.com/#feat=calc) stats. Being that the rule using `calc` will only apply to desktop browsers, I would assume coverage for it's use is sufficient. "},"comment":{"url":"https://api.github.com/repos/mattstauffer/pulledover/issues/comments/183374613","html_url":"https://github.com/mattstauffer/pulledover/pull/12#issuecomment-183374613","issue_url":"https://api.github.com/repos/mattstauffer/pulledover/issues/12","id":183374613,"user":{"login":"mattstauffer","id":151829,"avatar_url":"https://avatars.githubusercontent.com/u/151829?v=3","gravatar_id":"","url":"https://api.github.com/users/mattstauffer","html_url":"https://github.com/mattstauffer","followers_url":"https://api.github.com/users/mattstauffer/followers","following_url":"https://api.github.com/users/mattstauffer/following{/other_user}","gists_url":"https://api.github.com/users/mattstauffer/gists{/gist_id}","starred_url":"https://api.github.com/users/mattstauffer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattstauffer/subscriptions","organizations_url":"https://api.github.com/users/mattstauffer/orgs","repos_url":"https://api.github.com/users/mattstauffer/repos","events_url":"https://api.github.com/users/mattstauffer/events{/privacy}","received_events_url":"https://api.github.com/users/mattstauffer/received_events","type":"User","site_admin":false},"created_at":"2016-02-12T15:30:42Z","updated_at":"2016-02-12T15:30:42Z","body":"Thanks for the PR! a few notes:\r\n\r\n- I like using the smaller image at mobile sizes.\r\n- I don't like that this makes the hero full height. I like seeing some of the FAQ peek up so you can know there's more to scroll to. This is overkill:\r\n\r\n![image](https://cloud.githubusercontent.com/assets/151829/13011070/060c9f04-d173-11e5-9b20-7dfd7de43898.png)\r\n\r\n- I actually don't like the mobile image being centered; it makes the text hard to read. I liked it being offset. This PR:\r\n\r\n![image](https://cloud.githubusercontent.com/assets/151829/13011101/24b8ffe2-d173-11e5-866c-07b163f33440.png)\r\n\r\nThe current live site:\r\n\r\n![image](https://cloud.githubusercontent.com/assets/151829/13011108/2d3d0bea-d173-11e5-8692-96110aae5795.png)\r\n\r\nFinally, the smaller image looks super artifact-y. I'm worried it might be a little too compressed. Have you taken a look in a retina iPhone (e.g. 6s) to see how it looks? Thanks!"}}