{"action":"closed","number":317,"pull_request":{"url":"https://api.github.com/repos/aasm/aasm/pulls/317","id":58084131,"html_url":"https://github.com/aasm/aasm/pull/317","diff_url":"https://github.com/aasm/aasm/pull/317.diff","patch_url":"https://github.com/aasm/aasm/pull/317.patch","issue_url":"https://api.github.com/repos/aasm/aasm/issues/317","number":317,"state":"closed","locked":false,"title":"Adding a warning regarding RubyMotion support and KVO","user":{"login":"Infotaku","id":2786888,"avatar_url":"https://avatars.githubusercontent.com/u/2786888?v=3","gravatar_id":"","url":"https://api.github.com/users/Infotaku","html_url":"https://github.com/Infotaku","followers_url":"https://api.github.com/users/Infotaku/followers","following_url":"https://api.github.com/users/Infotaku/following{/other_user}","gists_url":"https://api.github.com/users/Infotaku/gists{/gist_id}","starred_url":"https://api.github.com/users/Infotaku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Infotaku/subscriptions","organizations_url":"https://api.github.com/users/Infotaku/orgs","repos_url":"https://api.github.com/users/Infotaku/repos","events_url":"https://api.github.com/users/Infotaku/events{/privacy}","received_events_url":"https://api.github.com/users/Infotaku/received_events","type":"User","site_admin":false},"body":"I just found an issue with the use of KVO (key-value observer) in RubyMotion.\r\n\r\nSince KVOs change the class of the object, it completely mess with the way you store and retrieve the different state machines (the inherited method does not seem to be called by the KVO), as you use the class as keys to the storing hash.\r\n\r\nI may have an idea on how to fix that, but i may require some time before I crack it so I thought I'd put a warning in the meantime so nobody lose their time trying to find the origin of the issue.\r\n\r\nI'll get back to you once I've got some more details on how I can fix that. (probably through the options though)","created_at":"2016-02-03T02:46:32Z","updated_at":"2016-02-04T22:20:22Z","closed_at":"2016-02-04T22:20:22Z","merged_at":"2016-02-04T22:20:22Z","merge_commit_sha":"576e1cc9f50ae2b6c869755bc37da6a5f0b096ad","assignee":{"login":"alto","id":3209,"avatar_url":"https://avatars.githubusercontent.com/u/3209?v=3","gravatar_id":"","url":"https://api.github.com/users/alto","html_url":"https://github.com/alto","followers_url":"https://api.github.com/users/alto/followers","following_url":"https://api.github.com/users/alto/following{/other_user}","gists_url":"https://api.github.com/users/alto/gists{/gist_id}","starred_url":"https://api.github.com/users/alto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alto/subscriptions","organizations_url":"https://api.github.com/users/alto/orgs","repos_url":"https://api.github.com/users/alto/repos","events_url":"https://api.github.com/users/alto/events{/privacy}","received_events_url":"https://api.github.com/users/alto/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/aasm/aasm/pulls/317/commits","review_comments_url":"https://api.github.com/repos/aasm/aasm/pulls/317/comments","review_comment_url":"https://api.github.com/repos/aasm/aasm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aasm/aasm/issues/317/comments","statuses_url":"https://api.github.com/repos/aasm/aasm/statuses/fa7e786f7adb431ab08d7387defbc230af8f6157","head":{"label":"Infotaku:RubyMotion","ref":"RubyMotion","sha":"fa7e786f7adb431ab08d7387defbc230af8f6157","user":{"login":"Infotaku","id":2786888,"avatar_url":"https://avatars.githubusercontent.com/u/2786888?v=3","gravatar_id":"","url":"https://api.github.com/users/Infotaku","html_url":"https://github.com/Infotaku","followers_url":"https://api.github.com/users/Infotaku/followers","following_url":"https://api.github.com/users/Infotaku/following{/other_user}","gists_url":"https://api.github.com/users/Infotaku/gists{/gist_id}","starred_url":"https://api.github.com/users/Infotaku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Infotaku/subscriptions","organizations_url":"https://api.github.com/users/Infotaku/orgs","repos_url":"https://api.github.com/users/Infotaku/repos","events_url":"https://api.github.com/users/Infotaku/events{/privacy}","received_events_url":"https://api.github.com/users/Infotaku/received_events","type":"User","site_admin":false},"repo":{"id":50745072,"name":"aasm","full_name":"Infotaku/aasm","owner":{"login":"Infotaku","id":2786888,"avatar_url":"https://avatars.githubusercontent.com/u/2786888?v=3","gravatar_id":"","url":"https://api.github.com/users/Infotaku","html_url":"https://github.com/Infotaku","followers_url":"https://api.github.com/users/Infotaku/followers","following_url":"https://api.github.com/users/Infotaku/following{/other_user}","gists_url":"https://api.github.com/users/Infotaku/gists{/gist_id}","starred_url":"https://api.github.com/users/Infotaku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Infotaku/subscriptions","organizations_url":"https://api.github.com/users/Infotaku/orgs","repos_url":"https://api.github.com/users/Infotaku/repos","events_url":"https://api.github.com/users/Infotaku/events{/privacy}","received_events_url":"https://api.github.com/users/Infotaku/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Infotaku/aasm","description":"AASM - State machines for Ruby classes (plain Ruby, ActiveRecord, Mongoid, MongoMapper)","fork":true,"url":"https://api.github.com/repos/Infotaku/aasm","forks_url":"https://api.github.com/repos/Infotaku/aasm/forks","keys_url":"https://api.github.com/repos/Infotaku/aasm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Infotaku/aasm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Infotaku/aasm/teams","hooks_url":"https://api.github.com/repos/Infotaku/aasm/hooks","issue_events_url":"https://api.github.com/repos/Infotaku/aasm/issues/events{/number}","events_url":"https://api.github.com/repos/Infotaku/aasm/events","assignees_url":"https://api.github.com/repos/Infotaku/aasm/assignees{/user}","branches_url":"https://api.github.com/repos/Infotaku/aasm/branches{/branch}","tags_url":"https://api.github.com/repos/Infotaku/aasm/tags","blobs_url":"https://api.github.com/repos/Infotaku/aasm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Infotaku/aasm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Infotaku/aasm/git/refs{/sha}","trees_url":"https://api.github.com/repos/Infotaku/aasm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Infotaku/aasm/statuses/{sha}","languages_url":"https://api.github.com/repos/Infotaku/aasm/languages","stargazers_url":"https://api.github.com/repos/Infotaku/aasm/stargazers","contributors_url":"https://api.github.com/repos/Infotaku/aasm/contributors","subscribers_url":"https://api.github.com/repos/Infotaku/aasm/subscribers","subscription_url":"https://api.github.com/repos/Infotaku/aasm/subscription","commits_url":"https://api.github.com/repos/Infotaku/aasm/commits{/sha}","git_commits_url":"https://api.github.com/repos/Infotaku/aasm/git/commits{/sha}","comments_url":"https://api.github.com/repos/Infotaku/aasm/comments{/number}","issue_comment_url":"https://api.github.com/repos/Infotaku/aasm/issues/comments{/number}","contents_url":"https://api.github.com/repos/Infotaku/aasm/contents/{+path}","compare_url":"https://api.github.com/repos/Infotaku/aasm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Infotaku/aasm/merges","archive_url":"https://api.github.com/repos/Infotaku/aasm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Infotaku/aasm/downloads","issues_url":"https://api.github.com/repos/Infotaku/aasm/issues{/number}","pulls_url":"https://api.github.com/repos/Infotaku/aasm/pulls{/number}","milestones_url":"https://api.github.com/repos/Infotaku/aasm/milestones{/number}","notifications_url":"https://api.github.com/repos/Infotaku/aasm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Infotaku/aasm/labels{/name}","releases_url":"https://api.github.com/repos/Infotaku/aasm/releases{/id}","deployments_url":"https://api.github.com/repos/Infotaku/aasm/deployments","created_at":"2016-01-30T21:10:37Z","updated_at":"2016-01-30T21:10:38Z","pushed_at":"2016-02-03T02:22:37Z","git_url":"git://github.com/Infotaku/aasm.git","ssh_url":"git@github.com:Infotaku/aasm.git","clone_url":"https://github.com/Infotaku/aasm.git","svn_url":"https://github.com/Infotaku/aasm","homepage":"","size":1382,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aasm:master","ref":"master","sha":"ddda181cd500e312c357e3aa2efc16c55986e48f","user":{"login":"aasm","id":1910612,"avatar_url":"https://avatars.githubusercontent.com/u/1910612?v=3","gravatar_id":"","url":"https://api.github.com/users/aasm","html_url":"https://github.com/aasm","followers_url":"https://api.github.com/users/aasm/followers","following_url":"https://api.github.com/users/aasm/following{/other_user}","gists_url":"https://api.github.com/users/aasm/gists{/gist_id}","starred_url":"https://api.github.com/users/aasm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aasm/subscriptions","organizations_url":"https://api.github.com/users/aasm/orgs","repos_url":"https://api.github.com/users/aasm/repos","events_url":"https://api.github.com/users/aasm/events{/privacy}","received_events_url":"https://api.github.com/users/aasm/received_events","type":"Organization","site_admin":false},"repo":{"id":1734,"name":"aasm","full_name":"aasm/aasm","owner":{"login":"aasm","id":1910612,"avatar_url":"https://avatars.githubusercontent.com/u/1910612?v=3","gravatar_id":"","url":"https://api.github.com/users/aasm","html_url":"https://github.com/aasm","followers_url":"https://api.github.com/users/aasm/followers","following_url":"https://api.github.com/users/aasm/following{/other_user}","gists_url":"https://api.github.com/users/aasm/gists{/gist_id}","starred_url":"https://api.github.com/users/aasm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aasm/subscriptions","organizations_url":"https://api.github.com/users/aasm/orgs","repos_url":"https://api.github.com/users/aasm/repos","events_url":"https://api.github.com/users/aasm/events{/privacy}","received_events_url":"https://api.github.com/users/aasm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aasm/aasm","description":"AASM - State machines for Ruby classes (plain Ruby, ActiveRecord, Mongoid, MongoMapper)","fork":false,"url":"https://api.github.com/repos/aasm/aasm","forks_url":"https://api.github.com/repos/aasm/aasm/forks","keys_url":"https://api.github.com/repos/aasm/aasm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aasm/aasm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aasm/aasm/teams","hooks_url":"https://api.github.com/repos/aasm/aasm/hooks","issue_events_url":"https://api.github.com/repos/aasm/aasm/issues/events{/number}","events_url":"https://api.github.com/repos/aasm/aasm/events","assignees_url":"https://api.github.com/repos/aasm/aasm/assignees{/user}","branches_url":"https://api.github.com/repos/aasm/aasm/branches{/branch}","tags_url":"https://api.github.com/repos/aasm/aasm/tags","blobs_url":"https://api.github.com/repos/aasm/aasm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aasm/aasm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aasm/aasm/git/refs{/sha}","trees_url":"https://api.github.com/repos/aasm/aasm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aasm/aasm/statuses/{sha}","languages_url":"https://api.github.com/repos/aasm/aasm/languages","stargazers_url":"https://api.github.com/repos/aasm/aasm/stargazers","contributors_url":"https://api.github.com/repos/aasm/aasm/contributors","subscribers_url":"https://api.github.com/repos/aasm/aasm/subscribers","subscription_url":"https://api.github.com/repos/aasm/aasm/subscription","commits_url":"https://api.github.com/repos/aasm/aasm/commits{/sha}","git_commits_url":"https://api.github.com/repos/aasm/aasm/git/commits{/sha}","comments_url":"https://api.github.com/repos/aasm/aasm/comments{/number}","issue_comment_url":"https://api.github.com/repos/aasm/aasm/issues/comments{/number}","contents_url":"https://api.github.com/repos/aasm/aasm/contents/{+path}","compare_url":"https://api.github.com/repos/aasm/aasm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aasm/aasm/merges","archive_url":"https://api.github.com/repos/aasm/aasm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aasm/aasm/downloads","issues_url":"https://api.github.com/repos/aasm/aasm/issues{/number}","pulls_url":"https://api.github.com/repos/aasm/aasm/pulls{/number}","milestones_url":"https://api.github.com/repos/aasm/aasm/milestones{/number}","notifications_url":"https://api.github.com/repos/aasm/aasm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aasm/aasm/labels{/name}","releases_url":"https://api.github.com/repos/aasm/aasm/releases{/id}","deployments_url":"https://api.github.com/repos/aasm/aasm/deployments","created_at":"2008-02-28T20:40:04Z","updated_at":"2016-02-04T15:42:45Z","pushed_at":"2016-02-04T22:20:23Z","git_url":"git://github.com/aasm/aasm.git","ssh_url":"git@github.com:aasm/aasm.git","clone_url":"https://github.com/aasm/aasm.git","svn_url":"https://github.com/aasm/aasm","homepage":"","size":1692,"stargazers_count":2212,"watchers_count":2212,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":350,"mirror_url":null,"open_issues_count":49,"forks":350,"open_issues":49,"watchers":2212,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aasm/aasm/pulls/317"},"html":{"href":"https://github.com/aasm/aasm/pull/317"},"issue":{"href":"https://api.github.com/repos/aasm/aasm/issues/317"},"comments":{"href":"https://api.github.com/repos/aasm/aasm/issues/317/comments"},"review_comments":{"href":"https://api.github.com/repos/aasm/aasm/pulls/317/comments"},"review_comment":{"href":"https://api.github.com/repos/aasm/aasm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aasm/aasm/pulls/317/commits"},"statuses":{"href":"https://api.github.com/repos/aasm/aasm/statuses/fa7e786f7adb431ab08d7387defbc230af8f6157"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"alto","id":3209,"avatar_url":"https://avatars.githubusercontent.com/u/3209?v=3","gravatar_id":"","url":"https://api.github.com/users/alto","html_url":"https://github.com/alto","followers_url":"https://api.github.com/users/alto/followers","following_url":"https://api.github.com/users/alto/following{/other_user}","gists_url":"https://api.github.com/users/alto/gists{/gist_id}","starred_url":"https://api.github.com/users/alto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alto/subscriptions","organizations_url":"https://api.github.com/users/alto/orgs","repos_url":"https://api.github.com/users/alto/repos","events_url":"https://api.github.com/users/alto/events{/privacy}","received_events_url":"https://api.github.com/users/alto/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":3,"deletions":0,"changed_files":1}}