{"action":"created","comment":{"url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/pulls/comments/57448980","id":57448980,"diff_hunk":"@@ -28,6 +28,17 @@ http {\n         include {{ nginx_conf_dir }}/sites-enabled/*;\n }\n \n+{% if nginx_official_repo_mainline %}","path":"templates/nginx.conf.j2","position":4,"original_position":4,"commit_id":"c59e79b93a0e1993a91495125b20376a3f1607dd","original_commit_id":"c59e79b93a0e1993a91495125b20376a3f1607dd","user":{"login":"jdauphant","id":1238254,"avatar_url":"https://avatars.githubusercontent.com/u/1238254?v=3","gravatar_id":"","url":"https://api.github.com/users/jdauphant","html_url":"https://github.com/jdauphant","followers_url":"https://api.github.com/users/jdauphant/followers","following_url":"https://api.github.com/users/jdauphant/following{/other_user}","gists_url":"https://api.github.com/users/jdauphant/gists{/gist_id}","starred_url":"https://api.github.com/users/jdauphant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdauphant/subscriptions","organizations_url":"https://api.github.com/users/jdauphant/orgs","repos_url":"https://api.github.com/users/jdauphant/repos","events_url":"https://api.github.com/users/jdauphant/events{/privacy}","received_events_url":"https://api.github.com/users/jdauphant/received_events","type":"User","site_admin":false},"body":"I will prefer to check that ```nginx_stream_params``` or ```nginx_stream_configs``` is not empty instead of checking nginx_official_repo_mainline (user is responsable of misconfiguration like that).\r\nYou can made variable \"nginx_official_repo_mainline\" default to \"nginx_stream_params != [] or nginx_stream_configs != [] \" in other hand.","created_at":"2016-03-25T14:35:03Z","updated_at":"2016-03-25T14:35:03Z","html_url":"https://github.com/jdauphant/ansible-role-nginx/pull/107#discussion_r57448980","pull_request_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/pulls/107","_links":{"self":{"href":"https://api.github.com/repos/jdauphant/ansible-role-nginx/pulls/comments/57448980"},"html":{"href":"https://github.com/jdauphant/ansible-role-nginx/pull/107#discussion_r57448980"},"pull_request":{"href":"https://api.github.com/repos/jdauphant/ansible-role-nginx/pulls/107"}}},"pull_request":{"url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/pulls/107","id":64163188,"html_url":"https://github.com/jdauphant/ansible-role-nginx/pull/107","diff_url":"https://github.com/jdauphant/ansible-role-nginx/pull/107.diff","patch_url":"https://github.com/jdauphant/ansible-role-nginx/pull/107.patch","issue_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/issues/107","number":107,"state":"open","locked":false,"title":"Add support for plain TCP loadbalancing","user":{"login":"wkielas","id":8639299,"avatar_url":"https://avatars.githubusercontent.com/u/8639299?v=3","gravatar_id":"","url":"https://api.github.com/users/wkielas","html_url":"https://github.com/wkielas","followers_url":"https://api.github.com/users/wkielas/followers","following_url":"https://api.github.com/users/wkielas/following{/other_user}","gists_url":"https://api.github.com/users/wkielas/gists{/gist_id}","starred_url":"https://api.github.com/users/wkielas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkielas/subscriptions","organizations_url":"https://api.github.com/users/wkielas/orgs","repos_url":"https://api.github.com/users/wkielas/repos","events_url":"https://api.github.com/users/wkielas/events{/privacy}","received_events_url":"https://api.github.com/users/wkielas/received_events","type":"User","site_admin":false},"body":"This adds a `nginx_stream_params` variable to allow configuring the [stream module](http://nginx.org/en/docs/stream/ngx_stream_core_module.html).\r\n\r\nPlease note that to use this you have to use Nginx 1.9 or a newer one. This adds an `nginx_official_repo_mainline` variable that allows using the mainline repo with the newest stable version.\r\n\r\nTo use the stream feature you have to have both `nginx_official_repo` and `nginx_official_repo_mainline` set to `True`.\r\n\r\nWith `nginx_official_repo_mainline` set to `False` (the default) the module behavior does not change and it continues to work with older versions of Nginx.\r\n\r\nI'm open to suggestions, so please don't hesitate if you'd like to see something done differently.","created_at":"2016-03-25T13:43:33Z","updated_at":"2016-03-25T14:35:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8694293d95bf4a19726f060595d6ec4bf2c150f7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/pulls/107/commits","review_comments_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/pulls/107/comments","review_comment_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/issues/107/comments","statuses_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/statuses/c59e79b93a0e1993a91495125b20376a3f1607dd","head":{"label":"wkielas:master","ref":"master","sha":"c59e79b93a0e1993a91495125b20376a3f1607dd","user":{"login":"wkielas","id":8639299,"avatar_url":"https://avatars.githubusercontent.com/u/8639299?v=3","gravatar_id":"","url":"https://api.github.com/users/wkielas","html_url":"https://github.com/wkielas","followers_url":"https://api.github.com/users/wkielas/followers","following_url":"https://api.github.com/users/wkielas/following{/other_user}","gists_url":"https://api.github.com/users/wkielas/gists{/gist_id}","starred_url":"https://api.github.com/users/wkielas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkielas/subscriptions","organizations_url":"https://api.github.com/users/wkielas/orgs","repos_url":"https://api.github.com/users/wkielas/repos","events_url":"https://api.github.com/users/wkielas/events{/privacy}","received_events_url":"https://api.github.com/users/wkielas/received_events","type":"User","site_admin":false},"repo":{"id":54712416,"name":"ansible-role-nginx","full_name":"wkielas/ansible-role-nginx","owner":{"login":"wkielas","id":8639299,"avatar_url":"https://avatars.githubusercontent.com/u/8639299?v=3","gravatar_id":"","url":"https://api.github.com/users/wkielas","html_url":"https://github.com/wkielas","followers_url":"https://api.github.com/users/wkielas/followers","following_url":"https://api.github.com/users/wkielas/following{/other_user}","gists_url":"https://api.github.com/users/wkielas/gists{/gist_id}","starred_url":"https://api.github.com/users/wkielas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkielas/subscriptions","organizations_url":"https://api.github.com/users/wkielas/orgs","repos_url":"https://api.github.com/users/wkielas/repos","events_url":"https://api.github.com/users/wkielas/events{/privacy}","received_events_url":"https://api.github.com/users/wkielas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wkielas/ansible-role-nginx","description":"Ansible role to install and manage nginx configuration","fork":true,"url":"https://api.github.com/repos/wkielas/ansible-role-nginx","forks_url":"https://api.github.com/repos/wkielas/ansible-role-nginx/forks","keys_url":"https://api.github.com/repos/wkielas/ansible-role-nginx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wkielas/ansible-role-nginx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wkielas/ansible-role-nginx/teams","hooks_url":"https://api.github.com/repos/wkielas/ansible-role-nginx/hooks","issue_events_url":"https://api.github.com/repos/wkielas/ansible-role-nginx/issues/events{/number}","events_url":"https://api.github.com/repos/wkielas/ansible-role-nginx/events","assignees_url":"https://api.github.com/repos/wkielas/ansible-role-nginx/assignees{/user}","branches_url":"https://api.github.com/repos/wkielas/ansible-role-nginx/branches{/branch}","tags_url":"https://api.github.com/repos/wkielas/ansible-role-nginx/tags","blobs_url":"https://api.github.com/repos/wkielas/ansible-role-nginx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wkielas/ansible-role-nginx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wkielas/ansible-role-nginx/git/refs{/sha}","trees_url":"https://api.github.com/repos/wkielas/ansible-role-nginx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wkielas/ansible-role-nginx/statuses/{sha}","languages_url":"https://api.github.com/repos/wkielas/ansible-role-nginx/languages","stargazers_url":"https://api.github.com/repos/wkielas/ansible-role-nginx/stargazers","contributors_url":"https://api.github.com/repos/wkielas/ansible-role-nginx/contributors","subscribers_url":"https://api.github.com/repos/wkielas/ansible-role-nginx/subscribers","subscription_url":"https://api.github.com/repos/wkielas/ansible-role-nginx/subscription","commits_url":"https://api.github.com/repos/wkielas/ansible-role-nginx/commits{/sha}","git_commits_url":"https://api.github.com/repos/wkielas/ansible-role-nginx/git/commits{/sha}","comments_url":"https://api.github.com/repos/wkielas/ansible-role-nginx/comments{/number}","issue_comment_url":"https://api.github.com/repos/wkielas/ansible-role-nginx/issues/comments{/number}","contents_url":"https://api.github.com/repos/wkielas/ansible-role-nginx/contents/{+path}","compare_url":"https://api.github.com/repos/wkielas/ansible-role-nginx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wkielas/ansible-role-nginx/merges","archive_url":"https://api.github.com/repos/wkielas/ansible-role-nginx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wkielas/ansible-role-nginx/downloads","issues_url":"https://api.github.com/repos/wkielas/ansible-role-nginx/issues{/number}","pulls_url":"https://api.github.com/repos/wkielas/ansible-role-nginx/pulls{/number}","milestones_url":"https://api.github.com/repos/wkielas/ansible-role-nginx/milestones{/number}","notifications_url":"https://api.github.com/repos/wkielas/ansible-role-nginx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wkielas/ansible-role-nginx/labels{/name}","releases_url":"https://api.github.com/repos/wkielas/ansible-role-nginx/releases{/id}","deployments_url":"https://api.github.com/repos/wkielas/ansible-role-nginx/deployments","created_at":"2016-03-25T10:35:04Z","updated_at":"2016-03-22T09:55:38Z","pushed_at":"2016-03-25T13:37:44Z","git_url":"git://github.com/wkielas/ansible-role-nginx.git","ssh_url":"git@github.com:wkielas/ansible-role-nginx.git","clone_url":"https://github.com/wkielas/ansible-role-nginx.git","svn_url":"https://github.com/wkielas/ansible-role-nginx","homepage":"","size":104,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jdauphant:master","ref":"master","sha":"e70356754e34aba81ac4ec3349879c3a59bb55a8","user":{"login":"jdauphant","id":1238254,"avatar_url":"https://avatars.githubusercontent.com/u/1238254?v=3","gravatar_id":"","url":"https://api.github.com/users/jdauphant","html_url":"https://github.com/jdauphant","followers_url":"https://api.github.com/users/jdauphant/followers","following_url":"https://api.github.com/users/jdauphant/following{/other_user}","gists_url":"https://api.github.com/users/jdauphant/gists{/gist_id}","starred_url":"https://api.github.com/users/jdauphant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdauphant/subscriptions","organizations_url":"https://api.github.com/users/jdauphant/orgs","repos_url":"https://api.github.com/users/jdauphant/repos","events_url":"https://api.github.com/users/jdauphant/events{/privacy}","received_events_url":"https://api.github.com/users/jdauphant/received_events","type":"User","site_admin":false},"repo":{"id":16103903,"name":"ansible-role-nginx","full_name":"jdauphant/ansible-role-nginx","owner":{"login":"jdauphant","id":1238254,"avatar_url":"https://avatars.githubusercontent.com/u/1238254?v=3","gravatar_id":"","url":"https://api.github.com/users/jdauphant","html_url":"https://github.com/jdauphant","followers_url":"https://api.github.com/users/jdauphant/followers","following_url":"https://api.github.com/users/jdauphant/following{/other_user}","gists_url":"https://api.github.com/users/jdauphant/gists{/gist_id}","starred_url":"https://api.github.com/users/jdauphant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdauphant/subscriptions","organizations_url":"https://api.github.com/users/jdauphant/orgs","repos_url":"https://api.github.com/users/jdauphant/repos","events_url":"https://api.github.com/users/jdauphant/events{/privacy}","received_events_url":"https://api.github.com/users/jdauphant/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jdauphant/ansible-role-nginx","description":"Ansible role to install and manage nginx configuration","fork":false,"url":"https://api.github.com/repos/jdauphant/ansible-role-nginx","forks_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/forks","keys_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/teams","hooks_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/hooks","issue_events_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/issues/events{/number}","events_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/events","assignees_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/assignees{/user}","branches_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/branches{/branch}","tags_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/tags","blobs_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/statuses/{sha}","languages_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/languages","stargazers_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/stargazers","contributors_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/contributors","subscribers_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/subscribers","subscription_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/subscription","commits_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/issues/comments{/number}","contents_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/contents/{+path}","compare_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/merges","archive_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/downloads","issues_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/issues{/number}","pulls_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/pulls{/number}","milestones_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/milestones{/number}","notifications_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/labels{/name}","releases_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/releases{/id}","deployments_url":"https://api.github.com/repos/jdauphant/ansible-role-nginx/deployments","created_at":"2014-01-21T13:55:42Z","updated_at":"2016-03-22T09:55:38Z","pushed_at":"2016-03-25T13:43:34Z","git_url":"git://github.com/jdauphant/ansible-role-nginx.git","ssh_url":"git@github.com:jdauphant/ansible-role-nginx.git","clone_url":"https://github.com/jdauphant/ansible-role-nginx.git","svn_url":"https://github.com/jdauphant/ansible-role-nginx","homepage":"","size":212,"stargazers_count":218,"watchers_count":218,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":103,"mirror_url":null,"open_issues_count":13,"forks":103,"open_issues":13,"watchers":218,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jdauphant/ansible-role-nginx/pulls/107"},"html":{"href":"https://github.com/jdauphant/ansible-role-nginx/pull/107"},"issue":{"href":"https://api.github.com/repos/jdauphant/ansible-role-nginx/issues/107"},"comments":{"href":"https://api.github.com/repos/jdauphant/ansible-role-nginx/issues/107/comments"},"review_comments":{"href":"https://api.github.com/repos/jdauphant/ansible-role-nginx/pulls/107/comments"},"review_comment":{"href":"https://api.github.com/repos/jdauphant/ansible-role-nginx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jdauphant/ansible-role-nginx/pulls/107/commits"},"statuses":{"href":"https://api.github.com/repos/jdauphant/ansible-role-nginx/statuses/c59e79b93a0e1993a91495125b20376a3f1607dd"}}}}