{"action":"created","issue":{"url":"https://api.github.com/repos/holidayextras/make-up/issues/37","repository_url":"https://api.github.com/repos/holidayextras/make-up","labels_url":"https://api.github.com/repos/holidayextras/make-up/issues/37/labels{/name}","comments_url":"https://api.github.com/repos/holidayextras/make-up/issues/37/comments","events_url":"https://api.github.com/repos/holidayextras/make-up/issues/37/events","html_url":"https://github.com/holidayextras/make-up/pull/37","id":132357131,"number":37,"title":"Updated linting rules","user":{"login":"putvande","id":4690464,"avatar_url":"https://avatars.githubusercontent.com/u/4690464?v=3","gravatar_id":"","url":"https://api.github.com/users/putvande","html_url":"https://github.com/putvande","followers_url":"https://api.github.com/users/putvande/followers","following_url":"https://api.github.com/users/putvande/following{/other_user}","gists_url":"https://api.github.com/users/putvande/gists{/gist_id}","starred_url":"https://api.github.com/users/putvande/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/putvande/subscriptions","organizations_url":"https://api.github.com/users/putvande/orgs","repos_url":"https://api.github.com/users/putvande/repos","events_url":"https://api.github.com/users/putvande/events{/privacy}","received_events_url":"https://api.github.com/users/putvande/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-02-09T08:18:57Z","updated_at":"2016-02-09T11:49:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/holidayextras/make-up/pulls/37","html_url":"https://github.com/holidayextras/make-up/pull/37","diff_url":"https://github.com/holidayextras/make-up/pull/37.diff","patch_url":"https://github.com/holidayextras/make-up/pull/37.patch"},"body":"#### What are the links to relevant tickets?\r\n\r\nhttps://hxshortbreaks.atlassian.net/browse/WEB-6968\r\n\r\n#### What does this PR do?\r\n\r\nUpdating linting rules. The rules in `scss-lint.yml` are outdated.\r\n\r\n#### What functional/unit tests does this PR have?\r\n\r\nNone\r\n\r\n#### Is there anything a developer should be aware of when reviewing this?\r\n\r\nNot really. Just test it with `npm test` and see that there aren't any problems with it.\r\n\r\n#### Screenshots (if appropriate)\r\n---\r\n#### Quality checklist (for PR author to complete BEFORE code review):\r\n- [ ] I've checked there is appropriate unit test coverage.\r\n- [ ] I've updated documentation with any changes to procedures.\r\n- [x] I've checked this work against the requirements of the Jira.\r\n- [x] This change passes all necessary tests (cross browser, automated or otherwise).\r\n- [x] I am ready for this to be code reviewed, merged and tested.\r\n\r\n#### Reviewer 1\r\n- [x] I agree with the assumptions made in the quality checklist.\r\n- [x] I’ve witnessed the work behaving as expected.\r\n- [x] I’ve checked for appropriate test coverage.\r\n- [x] I’ve checked for coding anti-patterns.\r\n- [x] I've checked this work against the requirements of the Jira.\r\n- [x] I don’t believe this work introduces unnecessary technical debt.\r\n- [x] +1 from me!\r\n\r\n#### Reviewer 2 @taijuten\r\n- [x] I agree with the assumptions made in the quality checklist.\r\n- [ ] I’ve witnessed the work behaving as expected.\r\n- [ ] I’ve checked for appropriate test coverage.\r\n- [x] I’ve checked for coding anti-patterns.\r\n- [x] I've checked this work against the requirements of the Jira.\r\n- [x] I don’t believe this work introduces unnecessary technical debt.\r\n- [x] +1 from me!"},"comment":{"url":"https://api.github.com/repos/holidayextras/make-up/issues/comments/181831200","html_url":"https://github.com/holidayextras/make-up/pull/37#issuecomment-181831200","issue_url":"https://api.github.com/repos/holidayextras/make-up/issues/37","id":181831200,"user":{"login":"hx-markterry","id":3158640,"avatar_url":"https://avatars.githubusercontent.com/u/3158640?v=3","gravatar_id":"","url":"https://api.github.com/users/hx-markterry","html_url":"https://github.com/hx-markterry","followers_url":"https://api.github.com/users/hx-markterry/followers","following_url":"https://api.github.com/users/hx-markterry/following{/other_user}","gists_url":"https://api.github.com/users/hx-markterry/gists{/gist_id}","starred_url":"https://api.github.com/users/hx-markterry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hx-markterry/subscriptions","organizations_url":"https://api.github.com/users/hx-markterry/orgs","repos_url":"https://api.github.com/users/hx-markterry/repos","events_url":"https://api.github.com/users/hx-markterry/events{/privacy}","received_events_url":"https://api.github.com/users/hx-markterry/received_events","type":"User","site_admin":false},"created_at":"2016-02-09T11:49:02Z","updated_at":"2016-02-09T11:49:02Z","body":"ok with me :helicopter: "}}