{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/osquery/pulls/comments/78288283","id":78288283,"diff_hunk":"@@ -0,0 +1,103 @@\n+/*\n+ *  Copyright (c) 2014-present, Facebook, Inc.\n+ *  All rights reserved.\n+ *\n+ *  This source code is licensed under the BSD-style license found in the\n+ *  LICENSE file in the root directory of this source tree. An additional grant\n+ *  of patent rights can be found in the PATENTS file in the same directory.\n+ *\n+ */\n+#include <gtest/gtest.h>\n+\n+#include <osquery/sql.h>\n+\n+namespace osquery {\n+\n+namespace tables {\n+\n+class AugeasTests : public testing::Test {};\n+\n+TEST_F(AugeasTests, select_all) {\n+  auto results = SQL(\"select * from augeas\");\n+  ASSERT_TRUE(results.getStatus().ok()) << results.getStatus().what();\n+  ASSERT_GT(results.rows().size(), 0U);","path":"osquery/tables/other/tests/augeas_tests.cpp","position":23,"original_position":23,"commit_id":"668bc3af7799150e4c35eb632d912a13d785ac36","original_commit_id":"bb1223dbe673581969d7926255799cadb0db0b5f","user":{"login":"thedrow","id":48936,"avatar_url":"https://avatars.githubusercontent.com/u/48936?v=3","gravatar_id":"","url":"https://api.github.com/users/thedrow","html_url":"https://github.com/thedrow","followers_url":"https://api.github.com/users/thedrow/followers","following_url":"https://api.github.com/users/thedrow/following{/other_user}","gists_url":"https://api.github.com/users/thedrow/gists{/gist_id}","starred_url":"https://api.github.com/users/thedrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thedrow/subscriptions","organizations_url":"https://api.github.com/users/thedrow/orgs","repos_url":"https://api.github.com/users/thedrow/repos","events_url":"https://api.github.com/users/thedrow/events{/privacy}","received_events_url":"https://api.github.com/users/thedrow/received_events","type":"User","site_admin":false},"body":"This used to be useful when I was developing the table. I agree we should drop this.","created_at":"2016-09-11T05:45:19Z","updated_at":"2016-09-11T05:45:19Z","html_url":"https://github.com/facebook/osquery/pull/2181#discussion_r78288283","pull_request_url":"https://api.github.com/repos/facebook/osquery/pulls/2181","_links":{"self":{"href":"https://api.github.com/repos/facebook/osquery/pulls/comments/78288283"},"html":{"href":"https://github.com/facebook/osquery/pull/2181#discussion_r78288283"},"pull_request":{"href":"https://api.github.com/repos/facebook/osquery/pulls/2181"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/osquery/pulls/2181","id":75011513,"html_url":"https://github.com/facebook/osquery/pull/2181","diff_url":"https://github.com/facebook/osquery/pull/2181.diff","patch_url":"https://github.com/facebook/osquery/pull/2181.patch","issue_url":"https://api.github.com/repos/facebook/osquery/issues/2181","number":2181,"state":"open","locked":false,"title":"Added the Augeas table","user":{"login":"thedrow","id":48936,"avatar_url":"https://avatars.githubusercontent.com/u/48936?v=3","gravatar_id":"","url":"https://api.github.com/users/thedrow","html_url":"https://github.com/thedrow","followers_url":"https://api.github.com/users/thedrow/followers","following_url":"https://api.github.com/users/thedrow/following{/other_user}","gists_url":"https://api.github.com/users/thedrow/gists{/gist_id}","starred_url":"https://api.github.com/users/thedrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thedrow/subscriptions","organizations_url":"https://api.github.com/users/thedrow/orgs","repos_url":"https://api.github.com/users/thedrow/repos","events_url":"https://api.github.com/users/thedrow/events{/privacy}","received_events_url":"https://api.github.com/users/thedrow/received_events","type":"User","site_admin":false},"body":"This is not ready yet but I'd like to see where it doesn't build yet.\r\nWhat's still missing:\r\n\r\n- [ ] Features\r\n  - [x] Add filename column\r\n  - [x] Add label column\r\n  - [ ] XPath filtering - Augeas allows you to filter by XPath expressions. I'd like to enable that possibility in OSQuery as well.\r\n  - [ ] Cache results.\r\n    - [ ] Update value when one if the files parsed by augeas have changed (Optional).\r\n    - [x] Cache filenames.\r\n    - [x] Cache labels.\r\n- [x] Build\r\n  - [x] Build on OSX.\r\n  - [x] Build on Ubuntu 16.04.\r\n  - [x] Build on Ubuntu 14.04.\r\n  - [x] Build on Ubuntu 12.04.\r\n  - [x] Build on CentOS 6.\r\n  - [x] Build on CentOS 7.\r\n  - [x] Install new build dependencies in the CI environment.\r\n- [x] Add basic tests.\r\n- [x] Error handling.\r\n- [x] Benchmark","created_at":"2016-06-23T19:19:28Z","updated_at":"2016-09-11T05:45:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4376f2c0a9fed9a1fa1d9a340b1680efc1f584ad","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/osquery/pulls/2181/commits","review_comments_url":"https://api.github.com/repos/facebook/osquery/pulls/2181/comments","review_comment_url":"https://api.github.com/repos/facebook/osquery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/osquery/issues/2181/comments","statuses_url":"https://api.github.com/repos/facebook/osquery/statuses/668bc3af7799150e4c35eb632d912a13d785ac36","head":{"label":"thedrow:augeas-table","ref":"augeas-table","sha":"668bc3af7799150e4c35eb632d912a13d785ac36","user":{"login":"thedrow","id":48936,"avatar_url":"https://avatars.githubusercontent.com/u/48936?v=3","gravatar_id":"","url":"https://api.github.com/users/thedrow","html_url":"https://github.com/thedrow","followers_url":"https://api.github.com/users/thedrow/followers","following_url":"https://api.github.com/users/thedrow/following{/other_user}","gists_url":"https://api.github.com/users/thedrow/gists{/gist_id}","starred_url":"https://api.github.com/users/thedrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thedrow/subscriptions","organizations_url":"https://api.github.com/users/thedrow/orgs","repos_url":"https://api.github.com/users/thedrow/repos","events_url":"https://api.github.com/users/thedrow/events{/privacy}","received_events_url":"https://api.github.com/users/thedrow/received_events","type":"User","site_admin":false},"repo":{"id":48216306,"name":"osquery","full_name":"thedrow/osquery","owner":{"login":"thedrow","id":48936,"avatar_url":"https://avatars.githubusercontent.com/u/48936?v=3","gravatar_id":"","url":"https://api.github.com/users/thedrow","html_url":"https://github.com/thedrow","followers_url":"https://api.github.com/users/thedrow/followers","following_url":"https://api.github.com/users/thedrow/following{/other_user}","gists_url":"https://api.github.com/users/thedrow/gists{/gist_id}","starred_url":"https://api.github.com/users/thedrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thedrow/subscriptions","organizations_url":"https://api.github.com/users/thedrow/orgs","repos_url":"https://api.github.com/users/thedrow/repos","events_url":"https://api.github.com/users/thedrow/events{/privacy}","received_events_url":"https://api.github.com/users/thedrow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thedrow/osquery","description":"SQL powered operating system instrumentation, monitoring, and analytics.","fork":true,"url":"https://api.github.com/repos/thedrow/osquery","forks_url":"https://api.github.com/repos/thedrow/osquery/forks","keys_url":"https://api.github.com/repos/thedrow/osquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thedrow/osquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thedrow/osquery/teams","hooks_url":"https://api.github.com/repos/thedrow/osquery/hooks","issue_events_url":"https://api.github.com/repos/thedrow/osquery/issues/events{/number}","events_url":"https://api.github.com/repos/thedrow/osquery/events","assignees_url":"https://api.github.com/repos/thedrow/osquery/assignees{/user}","branches_url":"https://api.github.com/repos/thedrow/osquery/branches{/branch}","tags_url":"https://api.github.com/repos/thedrow/osquery/tags","blobs_url":"https://api.github.com/repos/thedrow/osquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thedrow/osquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thedrow/osquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/thedrow/osquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thedrow/osquery/statuses/{sha}","languages_url":"https://api.github.com/repos/thedrow/osquery/languages","stargazers_url":"https://api.github.com/repos/thedrow/osquery/stargazers","contributors_url":"https://api.github.com/repos/thedrow/osquery/contributors","subscribers_url":"https://api.github.com/repos/thedrow/osquery/subscribers","subscription_url":"https://api.github.com/repos/thedrow/osquery/subscription","commits_url":"https://api.github.com/repos/thedrow/osquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/thedrow/osquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/thedrow/osquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/thedrow/osquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/thedrow/osquery/contents/{+path}","compare_url":"https://api.github.com/repos/thedrow/osquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thedrow/osquery/merges","archive_url":"https://api.github.com/repos/thedrow/osquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thedrow/osquery/downloads","issues_url":"https://api.github.com/repos/thedrow/osquery/issues{/number}","pulls_url":"https://api.github.com/repos/thedrow/osquery/pulls{/number}","milestones_url":"https://api.github.com/repos/thedrow/osquery/milestones{/number}","notifications_url":"https://api.github.com/repos/thedrow/osquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thedrow/osquery/labels{/name}","releases_url":"https://api.github.com/repos/thedrow/osquery/releases{/id}","deployments_url":"https://api.github.com/repos/thedrow/osquery/deployments","created_at":"2015-12-18T05:30:54Z","updated_at":"2016-06-22T17:27:28Z","pushed_at":"2016-08-25T05:12:55Z","git_url":"git://github.com/thedrow/osquery.git","ssh_url":"git@github.com:thedrow/osquery.git","clone_url":"https://github.com/thedrow/osquery.git","svn_url":"https://github.com/thedrow/osquery","homepage":"https://osquery.io","size":8863,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"f1d6686735c4582c8ccbcbb3f7c8bc9825247965","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":22394357,"name":"osquery","full_name":"facebook/osquery","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/osquery","description":"SQL powered operating system instrumentation, monitoring, and analytics.","fork":false,"url":"https://api.github.com/repos/facebook/osquery","forks_url":"https://api.github.com/repos/facebook/osquery/forks","keys_url":"https://api.github.com/repos/facebook/osquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/osquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/osquery/teams","hooks_url":"https://api.github.com/repos/facebook/osquery/hooks","issue_events_url":"https://api.github.com/repos/facebook/osquery/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/osquery/events","assignees_url":"https://api.github.com/repos/facebook/osquery/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/osquery/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/osquery/tags","blobs_url":"https://api.github.com/repos/facebook/osquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/osquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/osquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/osquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/osquery/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/osquery/languages","stargazers_url":"https://api.github.com/repos/facebook/osquery/stargazers","contributors_url":"https://api.github.com/repos/facebook/osquery/contributors","subscribers_url":"https://api.github.com/repos/facebook/osquery/subscribers","subscription_url":"https://api.github.com/repos/facebook/osquery/subscription","commits_url":"https://api.github.com/repos/facebook/osquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/osquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/osquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/osquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/osquery/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/osquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/osquery/merges","archive_url":"https://api.github.com/repos/facebook/osquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/osquery/downloads","issues_url":"https://api.github.com/repos/facebook/osquery/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/osquery/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/osquery/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/osquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/osquery/labels{/name}","releases_url":"https://api.github.com/repos/facebook/osquery/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/osquery/deployments","created_at":"2014-07-29T20:27:33Z","updated_at":"2016-09-11T04:49:55Z","pushed_at":"2016-09-10T02:45:37Z","git_url":"git://github.com/facebook/osquery.git","ssh_url":"git@github.com:facebook/osquery.git","clone_url":"https://github.com/facebook/osquery.git","svn_url":"https://github.com/facebook/osquery","homepage":"https://osquery.io","size":12990,"stargazers_count":6698,"watchers_count":6698,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":744,"mirror_url":null,"open_issues_count":61,"forks":744,"open_issues":61,"watchers":6698,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/osquery/pulls/2181"},"html":{"href":"https://github.com/facebook/osquery/pull/2181"},"issue":{"href":"https://api.github.com/repos/facebook/osquery/issues/2181"},"comments":{"href":"https://api.github.com/repos/facebook/osquery/issues/2181/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/osquery/pulls/2181/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/osquery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/osquery/pulls/2181/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/osquery/statuses/668bc3af7799150e4c35eb632d912a13d785ac36"}}}}
{"actor":{"display_login":"thedrow"}}