{"action":"created","comment":{"url":"https://api.github.com/repos/dgeb/ember-engines/pulls/comments/79443902","id":79443902,"diff_hunk":"@@ -0,0 +1,32 @@\n+import Ember from 'ember';\n+\n+const {\n+  getOwner,\n+  Error: EmberError\n+} = Ember;\n+\n+/*\n+  Returns an arguments array where the route name arg is prefixed based on the mount point\n+*/\n+export function prefixRouteNameArg(funcName, ...args) {\n+  let routeName = args[0];\n+  let owner = getOwner(this);\n+  let prefix = owner.mountPoint;\n+\n+  // only alter the routeName if it's actually referencing a route.\n+  if (owner.routable && typeof routeName === 'string') {\n+    if (resemblesURL(routeName)) {\n+      throw new EmberError(`${funcName} cannot be used for URLs. Please use the route name instead.`);","path":"addon/-private/utils.js","position":19,"original_position":19,"commit_id":"ae51dbdb13b26ba522c7a65ca02df17754ec13c8","original_commit_id":"ae51dbdb13b26ba522c7a65ca02df17754ec13c8","user":{"login":"trentmwillis","id":3526753,"avatar_url":"https://avatars.githubusercontent.com/u/3526753?v=3","gravatar_id":"","url":"https://api.github.com/users/trentmwillis","html_url":"https://github.com/trentmwillis","followers_url":"https://api.github.com/users/trentmwillis/followers","following_url":"https://api.github.com/users/trentmwillis/following{/other_user}","gists_url":"https://api.github.com/users/trentmwillis/gists{/gist_id}","starred_url":"https://api.github.com/users/trentmwillis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trentmwillis/subscriptions","organizations_url":"https://api.github.com/users/trentmwillis/orgs","repos_url":"https://api.github.com/users/trentmwillis/repos","events_url":"https://api.github.com/users/trentmwillis/events{/privacy}","received_events_url":"https://api.github.com/users/trentmwillis/received_events","type":"User","site_admin":false},"body":"Forgot to make this dynamic upstream...will have to do that soon.","created_at":"2016-09-19T17:28:09Z","updated_at":"2016-09-19T17:28:10Z","html_url":"https://github.com/dgeb/ember-engines/pull/188#discussion_r79443902","pull_request_url":"https://api.github.com/repos/dgeb/ember-engines/pulls/188","_links":{"self":{"href":"https://api.github.com/repos/dgeb/ember-engines/pulls/comments/79443902"},"html":{"href":"https://github.com/dgeb/ember-engines/pull/188#discussion_r79443902"},"pull_request":{"href":"https://api.github.com/repos/dgeb/ember-engines/pulls/188"}}},"pull_request":{"url":"https://api.github.com/repos/dgeb/ember-engines/pulls/188","id":83573078,"html_url":"https://github.com/dgeb/ember-engines/pull/188","diff_url":"https://github.com/dgeb/ember-engines/pull/188.diff","patch_url":"https://github.com/dgeb/ember-engines/pull/188.patch","issue_url":"https://api.github.com/repos/dgeb/ember-engines/issues/188","number":188,"state":"open","locked":false,"title":"Make transitionToRoute() and intermediateTransitionTo() work in engines","user":{"login":"dnachev","id":816847,"avatar_url":"https://avatars.githubusercontent.com/u/816847?v=3","gravatar_id":"","url":"https://api.github.com/users/dnachev","html_url":"https://github.com/dnachev","followers_url":"https://api.github.com/users/dnachev/followers","following_url":"https://api.github.com/users/dnachev/following{/other_user}","gists_url":"https://api.github.com/users/dnachev/gists{/gist_id}","starred_url":"https://api.github.com/users/dnachev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnachev/subscriptions","organizations_url":"https://api.github.com/users/dnachev/orgs","repos_url":"https://api.github.com/users/dnachev/repos","events_url":"https://api.github.com/users/dnachev/events{/privacy}","received_events_url":"https://api.github.com/users/dnachev/received_events","type":"User","site_admin":false},"body":"The PR fixes #186 and #159 in v0.2 branch.\r\n\r\nI've added tests, but the one for `intermediateTransitionTo()` is somewhat clunky. I couldn't think of a better way.","created_at":"2016-09-01T05:38:11Z","updated_at":"2016-09-19T17:28:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a839295fc18f6b6e5683ac3bbec3477eca7ac55b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dgeb/ember-engines/pulls/188/commits","review_comments_url":"https://api.github.com/repos/dgeb/ember-engines/pulls/188/comments","review_comment_url":"https://api.github.com/repos/dgeb/ember-engines/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dgeb/ember-engines/issues/188/comments","statuses_url":"https://api.github.com/repos/dgeb/ember-engines/statuses/ae51dbdb13b26ba522c7a65ca02df17754ec13c8","head":{"label":"dnachev:fix-transitions","ref":"fix-transitions","sha":"ae51dbdb13b26ba522c7a65ca02df17754ec13c8","user":{"login":"dnachev","id":816847,"avatar_url":"https://avatars.githubusercontent.com/u/816847?v=3","gravatar_id":"","url":"https://api.github.com/users/dnachev","html_url":"https://github.com/dnachev","followers_url":"https://api.github.com/users/dnachev/followers","following_url":"https://api.github.com/users/dnachev/following{/other_user}","gists_url":"https://api.github.com/users/dnachev/gists{/gist_id}","starred_url":"https://api.github.com/users/dnachev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnachev/subscriptions","organizations_url":"https://api.github.com/users/dnachev/orgs","repos_url":"https://api.github.com/users/dnachev/repos","events_url":"https://api.github.com/users/dnachev/events{/privacy}","received_events_url":"https://api.github.com/users/dnachev/received_events","type":"User","site_admin":false},"repo":{"id":63914758,"name":"ember-engines","full_name":"dnachev/ember-engines","owner":{"login":"dnachev","id":816847,"avatar_url":"https://avatars.githubusercontent.com/u/816847?v=3","gravatar_id":"","url":"https://api.github.com/users/dnachev","html_url":"https://github.com/dnachev","followers_url":"https://api.github.com/users/dnachev/followers","following_url":"https://api.github.com/users/dnachev/following{/other_user}","gists_url":"https://api.github.com/users/dnachev/gists{/gist_id}","starred_url":"https://api.github.com/users/dnachev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnachev/subscriptions","organizations_url":"https://api.github.com/users/dnachev/orgs","repos_url":"https://api.github.com/users/dnachev/repos","events_url":"https://api.github.com/users/dnachev/events{/privacy}","received_events_url":"https://api.github.com/users/dnachev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dnachev/ember-engines","description":"Experimental support for the Ember Engines RFC","fork":true,"url":"https://api.github.com/repos/dnachev/ember-engines","forks_url":"https://api.github.com/repos/dnachev/ember-engines/forks","keys_url":"https://api.github.com/repos/dnachev/ember-engines/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dnachev/ember-engines/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dnachev/ember-engines/teams","hooks_url":"https://api.github.com/repos/dnachev/ember-engines/hooks","issue_events_url":"https://api.github.com/repos/dnachev/ember-engines/issues/events{/number}","events_url":"https://api.github.com/repos/dnachev/ember-engines/events","assignees_url":"https://api.github.com/repos/dnachev/ember-engines/assignees{/user}","branches_url":"https://api.github.com/repos/dnachev/ember-engines/branches{/branch}","tags_url":"https://api.github.com/repos/dnachev/ember-engines/tags","blobs_url":"https://api.github.com/repos/dnachev/ember-engines/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dnachev/ember-engines/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dnachev/ember-engines/git/refs{/sha}","trees_url":"https://api.github.com/repos/dnachev/ember-engines/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dnachev/ember-engines/statuses/{sha}","languages_url":"https://api.github.com/repos/dnachev/ember-engines/languages","stargazers_url":"https://api.github.com/repos/dnachev/ember-engines/stargazers","contributors_url":"https://api.github.com/repos/dnachev/ember-engines/contributors","subscribers_url":"https://api.github.com/repos/dnachev/ember-engines/subscribers","subscription_url":"https://api.github.com/repos/dnachev/ember-engines/subscription","commits_url":"https://api.github.com/repos/dnachev/ember-engines/commits{/sha}","git_commits_url":"https://api.github.com/repos/dnachev/ember-engines/git/commits{/sha}","comments_url":"https://api.github.com/repos/dnachev/ember-engines/comments{/number}","issue_comment_url":"https://api.github.com/repos/dnachev/ember-engines/issues/comments{/number}","contents_url":"https://api.github.com/repos/dnachev/ember-engines/contents/{+path}","compare_url":"https://api.github.com/repos/dnachev/ember-engines/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dnachev/ember-engines/merges","archive_url":"https://api.github.com/repos/dnachev/ember-engines/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dnachev/ember-engines/downloads","issues_url":"https://api.github.com/repos/dnachev/ember-engines/issues{/number}","pulls_url":"https://api.github.com/repos/dnachev/ember-engines/pulls{/number}","milestones_url":"https://api.github.com/repos/dnachev/ember-engines/milestones{/number}","notifications_url":"https://api.github.com/repos/dnachev/ember-engines/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dnachev/ember-engines/labels{/name}","releases_url":"https://api.github.com/repos/dnachev/ember-engines/releases{/id}","deployments_url":"https://api.github.com/repos/dnachev/ember-engines/deployments","created_at":"2016-07-22T01:46:48Z","updated_at":"2016-07-22T01:46:48Z","pushed_at":"2016-09-09T23:06:07Z","git_url":"git://github.com/dnachev/ember-engines.git","ssh_url":"git@github.com:dnachev/ember-engines.git","clone_url":"https://github.com/dnachev/ember-engines.git","svn_url":"https://github.com/dnachev/ember-engines","homepage":"","size":243,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dgeb:v0.2","ref":"v0.2","sha":"75638478ca95f9c8261bf2fd4e68975887486020","user":{"login":"dgeb","id":29122,"avatar_url":"https://avatars.githubusercontent.com/u/29122?v=3","gravatar_id":"","url":"https://api.github.com/users/dgeb","html_url":"https://github.com/dgeb","followers_url":"https://api.github.com/users/dgeb/followers","following_url":"https://api.github.com/users/dgeb/following{/other_user}","gists_url":"https://api.github.com/users/dgeb/gists{/gist_id}","starred_url":"https://api.github.com/users/dgeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgeb/subscriptions","organizations_url":"https://api.github.com/users/dgeb/orgs","repos_url":"https://api.github.com/users/dgeb/repos","events_url":"https://api.github.com/users/dgeb/events{/privacy}","received_events_url":"https://api.github.com/users/dgeb/received_events","type":"User","site_admin":false},"repo":{"id":48006145,"name":"ember-engines","full_name":"dgeb/ember-engines","owner":{"login":"dgeb","id":29122,"avatar_url":"https://avatars.githubusercontent.com/u/29122?v=3","gravatar_id":"","url":"https://api.github.com/users/dgeb","html_url":"https://github.com/dgeb","followers_url":"https://api.github.com/users/dgeb/followers","following_url":"https://api.github.com/users/dgeb/following{/other_user}","gists_url":"https://api.github.com/users/dgeb/gists{/gist_id}","starred_url":"https://api.github.com/users/dgeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgeb/subscriptions","organizations_url":"https://api.github.com/users/dgeb/orgs","repos_url":"https://api.github.com/users/dgeb/repos","events_url":"https://api.github.com/users/dgeb/events{/privacy}","received_events_url":"https://api.github.com/users/dgeb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dgeb/ember-engines","description":"Experimental support for the Ember Engines RFC","fork":false,"url":"https://api.github.com/repos/dgeb/ember-engines","forks_url":"https://api.github.com/repos/dgeb/ember-engines/forks","keys_url":"https://api.github.com/repos/dgeb/ember-engines/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dgeb/ember-engines/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dgeb/ember-engines/teams","hooks_url":"https://api.github.com/repos/dgeb/ember-engines/hooks","issue_events_url":"https://api.github.com/repos/dgeb/ember-engines/issues/events{/number}","events_url":"https://api.github.com/repos/dgeb/ember-engines/events","assignees_url":"https://api.github.com/repos/dgeb/ember-engines/assignees{/user}","branches_url":"https://api.github.com/repos/dgeb/ember-engines/branches{/branch}","tags_url":"https://api.github.com/repos/dgeb/ember-engines/tags","blobs_url":"https://api.github.com/repos/dgeb/ember-engines/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dgeb/ember-engines/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dgeb/ember-engines/git/refs{/sha}","trees_url":"https://api.github.com/repos/dgeb/ember-engines/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dgeb/ember-engines/statuses/{sha}","languages_url":"https://api.github.com/repos/dgeb/ember-engines/languages","stargazers_url":"https://api.github.com/repos/dgeb/ember-engines/stargazers","contributors_url":"https://api.github.com/repos/dgeb/ember-engines/contributors","subscribers_url":"https://api.github.com/repos/dgeb/ember-engines/subscribers","subscription_url":"https://api.github.com/repos/dgeb/ember-engines/subscription","commits_url":"https://api.github.com/repos/dgeb/ember-engines/commits{/sha}","git_commits_url":"https://api.github.com/repos/dgeb/ember-engines/git/commits{/sha}","comments_url":"https://api.github.com/repos/dgeb/ember-engines/comments{/number}","issue_comment_url":"https://api.github.com/repos/dgeb/ember-engines/issues/comments{/number}","contents_url":"https://api.github.com/repos/dgeb/ember-engines/contents/{+path}","compare_url":"https://api.github.com/repos/dgeb/ember-engines/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dgeb/ember-engines/merges","archive_url":"https://api.github.com/repos/dgeb/ember-engines/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dgeb/ember-engines/downloads","issues_url":"https://api.github.com/repos/dgeb/ember-engines/issues{/number}","pulls_url":"https://api.github.com/repos/dgeb/ember-engines/pulls{/number}","milestones_url":"https://api.github.com/repos/dgeb/ember-engines/milestones{/number}","notifications_url":"https://api.github.com/repos/dgeb/ember-engines/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dgeb/ember-engines/labels{/name}","releases_url":"https://api.github.com/repos/dgeb/ember-engines/releases{/id}","deployments_url":"https://api.github.com/repos/dgeb/ember-engines/deployments","created_at":"2015-12-14T22:56:28Z","updated_at":"2016-09-16T17:56:02Z","pushed_at":"2016-09-19T17:03:35Z","git_url":"git://github.com/dgeb/ember-engines.git","ssh_url":"git@github.com:dgeb/ember-engines.git","clone_url":"https://github.com/dgeb/ember-engines.git","svn_url":"https://github.com/dgeb/ember-engines","homepage":"","size":337,"stargazers_count":261,"watchers_count":261,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":31,"forks":36,"open_issues":31,"watchers":261,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dgeb/ember-engines/pulls/188"},"html":{"href":"https://github.com/dgeb/ember-engines/pull/188"},"issue":{"href":"https://api.github.com/repos/dgeb/ember-engines/issues/188"},"comments":{"href":"https://api.github.com/repos/dgeb/ember-engines/issues/188/comments"},"review_comments":{"href":"https://api.github.com/repos/dgeb/ember-engines/pulls/188/comments"},"review_comment":{"href":"https://api.github.com/repos/dgeb/ember-engines/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dgeb/ember-engines/pulls/188/commits"},"statuses":{"href":"https://api.github.com/repos/dgeb/ember-engines/statuses/ae51dbdb13b26ba522c7a65ca02df17754ec13c8"}}}}
{"actor":{"display_login":"trentmwillis"}}