{"action":"closed","number":152,"pull_request":{"url":"https://api.github.com/repos/vimeo/vimeo-networking-java/pulls/152","id":88919122,"html_url":"https://github.com/vimeo/vimeo-networking-java/pull/152","diff_url":"https://github.com/vimeo/vimeo-networking-java/pull/152.diff","patch_url":"https://github.com/vimeo/vimeo-networking-java/pull/152.patch","issue_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/issues/152","number":152,"state":"closed","locked":false,"title":"VA-1728 Improving account manager code","user":{"login":"kevinzetterstrom","id":7053474,"avatar_url":"https://avatars.githubusercontent.com/u/7053474?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinzetterstrom","html_url":"https://github.com/kevinzetterstrom","followers_url":"https://api.github.com/users/kevinzetterstrom/followers","following_url":"https://api.github.com/users/kevinzetterstrom/following{/other_user}","gists_url":"https://api.github.com/users/kevinzetterstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinzetterstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinzetterstrom/subscriptions","organizations_url":"https://api.github.com/users/kevinzetterstrom/orgs","repos_url":"https://api.github.com/users/kevinzetterstrom/repos","events_url":"https://api.github.com/users/kevinzetterstrom/events{/privacy}","received_events_url":"https://api.github.com/users/kevinzetterstrom/received_events","type":"User","site_admin":false},"body":"#### Ticket\r\n[VA-1728](https://vimean.atlassian.net/browse/VA-1728)\r\n\r\n#### Ticket Summary\r\nWe need to make a few adjustments to the networking code to improve auth within the apps\r\n\r\n#### Implementation Summary\r\nThe main aspect of this ticket was to create a synchronous version of the single sign on method, that can be passed a basic auth string. This is needed since this will be called from a background thread within the Android AccountManager system (getAuthToken), and we need the basic auth header of the requesting app, not the basic auth header of the running app - the running app is always the first installed app with a Vimeo AccountManager (authenticator)\r\n\r\nSide effect are cleaning up some of the deprecated methods around the AccountStore, and adding annotation.s\r\n\r\n#### How to Test\r\nUse the VA-1728 branches in vimeo-kit and VimeoMobile to test","created_at":"2016-10-11T21:59:01Z","updated_at":"2016-10-17T14:45:16Z","closed_at":"2016-10-17T14:45:16Z","merged_at":"2016-10-17T14:45:16Z","merge_commit_sha":"008566e13be2fb86250f78043566d0d7e125ab19","assignee":{"login":"howardrigberg","id":1205432,"avatar_url":"https://avatars.githubusercontent.com/u/1205432?v=3","gravatar_id":"","url":"https://api.github.com/users/howardrigberg","html_url":"https://github.com/howardrigberg","followers_url":"https://api.github.com/users/howardrigberg/followers","following_url":"https://api.github.com/users/howardrigberg/following{/other_user}","gists_url":"https://api.github.com/users/howardrigberg/gists{/gist_id}","starred_url":"https://api.github.com/users/howardrigberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/howardrigberg/subscriptions","organizations_url":"https://api.github.com/users/howardrigberg/orgs","repos_url":"https://api.github.com/users/howardrigberg/repos","events_url":"https://api.github.com/users/howardrigberg/events{/privacy}","received_events_url":"https://api.github.com/users/howardrigberg/received_events","type":"User","site_admin":false},"assignees":[{"login":"howardrigberg","id":1205432,"avatar_url":"https://avatars.githubusercontent.com/u/1205432?v=3","gravatar_id":"","url":"https://api.github.com/users/howardrigberg","html_url":"https://github.com/howardrigberg","followers_url":"https://api.github.com/users/howardrigberg/followers","following_url":"https://api.github.com/users/howardrigberg/following{/other_user}","gists_url":"https://api.github.com/users/howardrigberg/gists{/gist_id}","starred_url":"https://api.github.com/users/howardrigberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/howardrigberg/subscriptions","organizations_url":"https://api.github.com/users/howardrigberg/orgs","repos_url":"https://api.github.com/users/howardrigberg/repos","events_url":"https://api.github.com/users/howardrigberg/events{/privacy}","received_events_url":"https://api.github.com/users/howardrigberg/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/pulls/152/commits","review_comments_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/pulls/152/comments","review_comment_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/issues/152/comments","statuses_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/statuses/2d245498c16a0d6309228438c4401a72d61118ff","head":{"label":"vimeo:VA-1728","ref":"VA-1728","sha":"2d245498c16a0d6309228438c4401a72d61118ff","user":{"login":"vimeo","id":317769,"avatar_url":"https://avatars.githubusercontent.com/u/317769?v=3","gravatar_id":"","url":"https://api.github.com/users/vimeo","html_url":"https://github.com/vimeo","followers_url":"https://api.github.com/users/vimeo/followers","following_url":"https://api.github.com/users/vimeo/following{/other_user}","gists_url":"https://api.github.com/users/vimeo/gists{/gist_id}","starred_url":"https://api.github.com/users/vimeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vimeo/subscriptions","organizations_url":"https://api.github.com/users/vimeo/orgs","repos_url":"https://api.github.com/users/vimeo/repos","events_url":"https://api.github.com/users/vimeo/events{/privacy}","received_events_url":"https://api.github.com/users/vimeo/received_events","type":"Organization","site_admin":false},"repo":{"id":41306732,"name":"vimeo-networking-java","full_name":"vimeo/vimeo-networking-java","owner":{"login":"vimeo","id":317769,"avatar_url":"https://avatars.githubusercontent.com/u/317769?v=3","gravatar_id":"","url":"https://api.github.com/users/vimeo","html_url":"https://github.com/vimeo","followers_url":"https://api.github.com/users/vimeo/followers","following_url":"https://api.github.com/users/vimeo/following{/other_user}","gists_url":"https://api.github.com/users/vimeo/gists{/gist_id}","starred_url":"https://api.github.com/users/vimeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vimeo/subscriptions","organizations_url":"https://api.github.com/users/vimeo/orgs","repos_url":"https://api.github.com/users/vimeo/repos","events_url":"https://api.github.com/users/vimeo/events{/privacy}","received_events_url":"https://api.github.com/users/vimeo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vimeo/vimeo-networking-java","description":"The Vimeo Java (Android) SDK","fork":false,"url":"https://api.github.com/repos/vimeo/vimeo-networking-java","forks_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/forks","keys_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/teams","hooks_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/hooks","issue_events_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/issues/events{/number}","events_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/events","assignees_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/assignees{/user}","branches_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/branches{/branch}","tags_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/tags","blobs_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/statuses/{sha}","languages_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/languages","stargazers_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/stargazers","contributors_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/contributors","subscribers_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/subscribers","subscription_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/subscription","commits_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/contents/{+path}","compare_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/merges","archive_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/downloads","issues_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/issues{/number}","pulls_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/pulls{/number}","milestones_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/milestones{/number}","notifications_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/labels{/name}","releases_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/releases{/id}","deployments_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/deployments","created_at":"2015-08-24T14:09:01Z","updated_at":"2016-10-14T04:04:34Z","pushed_at":"2016-10-17T14:45:16Z","git_url":"git://github.com/vimeo/vimeo-networking-java.git","ssh_url":"git@github.com:vimeo/vimeo-networking-java.git","clone_url":"https://github.com/vimeo/vimeo-networking-java.git","svn_url":"https://github.com/vimeo/vimeo-networking-java","homepage":null,"size":778,"stargazers_count":20,"watchers_count":20,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":2,"forks":12,"open_issues":2,"watchers":20,"default_branch":"v2.0.0"}},"base":{"label":"vimeo:v2.0.0","ref":"v2.0.0","sha":"8f6958ebb303a23895b747cd67db4437444c6286","user":{"login":"vimeo","id":317769,"avatar_url":"https://avatars.githubusercontent.com/u/317769?v=3","gravatar_id":"","url":"https://api.github.com/users/vimeo","html_url":"https://github.com/vimeo","followers_url":"https://api.github.com/users/vimeo/followers","following_url":"https://api.github.com/users/vimeo/following{/other_user}","gists_url":"https://api.github.com/users/vimeo/gists{/gist_id}","starred_url":"https://api.github.com/users/vimeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vimeo/subscriptions","organizations_url":"https://api.github.com/users/vimeo/orgs","repos_url":"https://api.github.com/users/vimeo/repos","events_url":"https://api.github.com/users/vimeo/events{/privacy}","received_events_url":"https://api.github.com/users/vimeo/received_events","type":"Organization","site_admin":false},"repo":{"id":41306732,"name":"vimeo-networking-java","full_name":"vimeo/vimeo-networking-java","owner":{"login":"vimeo","id":317769,"avatar_url":"https://avatars.githubusercontent.com/u/317769?v=3","gravatar_id":"","url":"https://api.github.com/users/vimeo","html_url":"https://github.com/vimeo","followers_url":"https://api.github.com/users/vimeo/followers","following_url":"https://api.github.com/users/vimeo/following{/other_user}","gists_url":"https://api.github.com/users/vimeo/gists{/gist_id}","starred_url":"https://api.github.com/users/vimeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vimeo/subscriptions","organizations_url":"https://api.github.com/users/vimeo/orgs","repos_url":"https://api.github.com/users/vimeo/repos","events_url":"https://api.github.com/users/vimeo/events{/privacy}","received_events_url":"https://api.github.com/users/vimeo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vimeo/vimeo-networking-java","description":"The Vimeo Java (Android) SDK","fork":false,"url":"https://api.github.com/repos/vimeo/vimeo-networking-java","forks_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/forks","keys_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/teams","hooks_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/hooks","issue_events_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/issues/events{/number}","events_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/events","assignees_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/assignees{/user}","branches_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/branches{/branch}","tags_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/tags","blobs_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/statuses/{sha}","languages_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/languages","stargazers_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/stargazers","contributors_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/contributors","subscribers_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/subscribers","subscription_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/subscription","commits_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/contents/{+path}","compare_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/merges","archive_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/downloads","issues_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/issues{/number}","pulls_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/pulls{/number}","milestones_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/milestones{/number}","notifications_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/labels{/name}","releases_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/releases{/id}","deployments_url":"https://api.github.com/repos/vimeo/vimeo-networking-java/deployments","created_at":"2015-08-24T14:09:01Z","updated_at":"2016-10-14T04:04:34Z","pushed_at":"2016-10-17T14:45:16Z","git_url":"git://github.com/vimeo/vimeo-networking-java.git","ssh_url":"git@github.com:vimeo/vimeo-networking-java.git","clone_url":"https://github.com/vimeo/vimeo-networking-java.git","svn_url":"https://github.com/vimeo/vimeo-networking-java","homepage":null,"size":778,"stargazers_count":20,"watchers_count":20,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":2,"forks":12,"open_issues":2,"watchers":20,"default_branch":"v2.0.0"}},"_links":{"self":{"href":"https://api.github.com/repos/vimeo/vimeo-networking-java/pulls/152"},"html":{"href":"https://github.com/vimeo/vimeo-networking-java/pull/152"},"issue":{"href":"https://api.github.com/repos/vimeo/vimeo-networking-java/issues/152"},"comments":{"href":"https://api.github.com/repos/vimeo/vimeo-networking-java/issues/152/comments"},"review_comments":{"href":"https://api.github.com/repos/vimeo/vimeo-networking-java/pulls/152/comments"},"review_comment":{"href":"https://api.github.com/repos/vimeo/vimeo-networking-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vimeo/vimeo-networking-java/pulls/152/commits"},"statuses":{"href":"https://api.github.com/repos/vimeo/vimeo-networking-java/statuses/2d245498c16a0d6309228438c4401a72d61118ff"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kevinzetterstrom","id":7053474,"avatar_url":"https://avatars.githubusercontent.com/u/7053474?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinzetterstrom","html_url":"https://github.com/kevinzetterstrom","followers_url":"https://api.github.com/users/kevinzetterstrom/followers","following_url":"https://api.github.com/users/kevinzetterstrom/following{/other_user}","gists_url":"https://api.github.com/users/kevinzetterstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinzetterstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinzetterstrom/subscriptions","organizations_url":"https://api.github.com/users/kevinzetterstrom/orgs","repos_url":"https://api.github.com/users/kevinzetterstrom/repos","events_url":"https://api.github.com/users/kevinzetterstrom/events{/privacy}","received_events_url":"https://api.github.com/users/kevinzetterstrom/received_events","type":"User","site_admin":false},"comments":10,"review_comments":106,"commits":16,"additions":348,"deletions":101,"changed_files":5}}
{"actor":{"display_login":"kevinzetterstrom"}}