{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/11530","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/11530/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/11530/comments","events_url":"https://api.github.com/repos/apache/spark/issues/11530/events","html_url":"https://github.com/apache/spark/pull/11530","id":138619877,"number":11530,"title":"[SPARK-13692] Fix trivial Coverity/Checkstyle defects","user":{"login":"dongjoon-hyun","id":9700541,"avatar_url":"https://avatars.githubusercontent.com/u/9700541?v=3","gravatar_id":"","url":"https://api.github.com/users/dongjoon-hyun","html_url":"https://github.com/dongjoon-hyun","followers_url":"https://api.github.com/users/dongjoon-hyun/followers","following_url":"https://api.github.com/users/dongjoon-hyun/following{/other_user}","gists_url":"https://api.github.com/users/dongjoon-hyun/gists{/gist_id}","starred_url":"https://api.github.com/users/dongjoon-hyun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dongjoon-hyun/subscriptions","organizations_url":"https://api.github.com/users/dongjoon-hyun/orgs","repos_url":"https://api.github.com/users/dongjoon-hyun/repos","events_url":"https://api.github.com/users/dongjoon-hyun/events{/privacy}","received_events_url":"https://api.github.com/users/dongjoon-hyun/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-04T23:49:15Z","updated_at":"2016-03-04T23:50:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/11530","html_url":"https://github.com/apache/spark/pull/11530","diff_url":"https://github.com/apache/spark/pull/11530.diff","patch_url":"https://github.com/apache/spark/pull/11530.patch"},"body":"## What changes were proposed in this pull request?\r\n\r\nThis issue fixes the following potential bugs and Java coding style detected by Coverity and Checkstyle.\r\n\r\n- Implement both null and type checking in equals functions.\r\n- Fix wrong type casting logic in SimpleJavaBean2.equals.\r\n- Add `implement Cloneable` to `UTF8String` and `SortedIterator`.\r\n- Remove dereferencing before null check in `AbstractBytesToBytesMapSuite`.\r\n- Fix coding style: Add '{}' to single `for` statement in mllib examples. \r\n- Remove unused imports in `ColumnarBatch`.\r\n\r\nPlease note that the last two checkstyle errors exist on newly added commits after [SPARK-13583](https://issues.apache.org/jira/browse/SPARK-13583).\r\n\r\n## How was this patch tested?\r\n\r\nmanual via `./dev/lint-java` and Coverity site."},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/192527079","html_url":"https://github.com/apache/spark/pull/11530#issuecomment-192527079","issue_url":"https://api.github.com/repos/apache/spark/issues/11530","id":192527079,"user":{"login":"dongjoon-hyun","id":9700541,"avatar_url":"https://avatars.githubusercontent.com/u/9700541?v=3","gravatar_id":"","url":"https://api.github.com/users/dongjoon-hyun","html_url":"https://github.com/dongjoon-hyun","followers_url":"https://api.github.com/users/dongjoon-hyun/followers","following_url":"https://api.github.com/users/dongjoon-hyun/following{/other_user}","gists_url":"https://api.github.com/users/dongjoon-hyun/gists{/gist_id}","starred_url":"https://api.github.com/users/dongjoon-hyun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dongjoon-hyun/subscriptions","organizations_url":"https://api.github.com/users/dongjoon-hyun/orgs","repos_url":"https://api.github.com/users/dongjoon-hyun/repos","events_url":"https://api.github.com/users/dongjoon-hyun/events{/privacy}","received_events_url":"https://api.github.com/users/dongjoon-hyun/received_events","type":"User","site_admin":false},"created_at":"2016-03-04T23:50:32Z","updated_at":"2016-03-04T23:50:32Z","body":"Hi, @srowen . \r\nThis is based on Coverity reports. Could you review this please?"}}