{"action":"created","comment":{"url":"https://api.github.com/repos/in-toto/in-toto/pulls/comments/85618164","pull_request_review_id":6327044,"id":85618164,"diff_hunk":"@@ -27,11 +27,18 @@\n import sys\n import os\n import tempfile\n+import logging\n+\n \n # POSIX users (Linux, BSD, etc.) are strongly encouraged to\n # install and use the much more recent subprocess32\n if os.name == 'posix' and sys.version_info[0] < 3:\n-  import subprocess32 as subprocess\n+  try:\n+    import subprocess32 as subprocess\n+  except Exception, e:\n+    logging.warning(\"POSIX users (Linux, BSD, etc.) are strongly encouraged to\"\n+        + \" install and use the much more recent subprocess32\")","path":"toto/runlib.py","position":15,"original_position":15,"commit_id":"34a0ad32fc459c3cecc3c0768b1048b8ca9abf3a","original_commit_id":"34a0ad32fc459c3cecc3c0768b1048b8ca9abf3a","user":{"login":"SantiagoTorres","id":3579933,"avatar_url":"https://avatars.githubusercontent.com/u/3579933?v=3","gravatar_id":"","url":"https://api.github.com/users/SantiagoTorres","html_url":"https://github.com/SantiagoTorres","followers_url":"https://api.github.com/users/SantiagoTorres/followers","following_url":"https://api.github.com/users/SantiagoTorres/following{/other_user}","gists_url":"https://api.github.com/users/SantiagoTorres/gists{/gist_id}","starred_url":"https://api.github.com/users/SantiagoTorres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SantiagoTorres/subscriptions","organizations_url":"https://api.github.com/users/SantiagoTorres/orgs","repos_url":"https://api.github.com/users/SantiagoTorres/repos","events_url":"https://api.github.com/users/SantiagoTorres/events{/privacy}","received_events_url":"https://api.github.com/users/SantiagoTorres/received_events","type":"User","site_admin":false},"body":"Take the + out please","created_at":"2016-10-28T22:05:09Z","updated_at":"2016-10-28T22:05:13Z","html_url":"https://github.com/in-toto/in-toto/pull/27#discussion_r85618164","pull_request_url":"https://api.github.com/repos/in-toto/in-toto/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/in-toto/in-toto/pulls/comments/85618164"},"html":{"href":"https://github.com/in-toto/in-toto/pull/27#discussion_r85618164"},"pull_request":{"href":"https://api.github.com/repos/in-toto/in-toto/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/in-toto/in-toto/pulls/27","id":91447616,"html_url":"https://github.com/in-toto/in-toto/pull/27","diff_url":"https://github.com/in-toto/in-toto/pull/27.diff","patch_url":"https://github.com/in-toto/in-toto/pull/27.patch","issue_url":"https://api.github.com/repos/in-toto/in-toto/issues/27","number":27,"state":"open","locked":false,"title":"Adds subprocess fallback for POSIX users","user":{"login":"lukpueh","id":589324,"avatar_url":"https://avatars.githubusercontent.com/u/589324?v=3","gravatar_id":"","url":"https://api.github.com/users/lukpueh","html_url":"https://github.com/lukpueh","followers_url":"https://api.github.com/users/lukpueh/followers","following_url":"https://api.github.com/users/lukpueh/following{/other_user}","gists_url":"https://api.github.com/users/lukpueh/gists{/gist_id}","starred_url":"https://api.github.com/users/lukpueh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukpueh/subscriptions","organizations_url":"https://api.github.com/users/lukpueh/orgs","repos_url":"https://api.github.com/users/lukpueh/repos","events_url":"https://api.github.com/users/lukpueh/events{/privacy}","received_events_url":"https://api.github.com/users/lukpueh/received_events","type":"User","site_admin":false},"body":"Since we only encourage POSIX systems to use subprocess32 we add a fallback to subprocess if the import fails and output a warning.","created_at":"2016-10-28T20:34:28Z","updated_at":"2016-10-28T22:05:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68343bd8f495e60b6bc6597fb7e7e0da3a91edbc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/in-toto/in-toto/pulls/27/commits","review_comments_url":"https://api.github.com/repos/in-toto/in-toto/pulls/27/comments","review_comment_url":"https://api.github.com/repos/in-toto/in-toto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/in-toto/in-toto/issues/27/comments","statuses_url":"https://api.github.com/repos/in-toto/in-toto/statuses/34a0ad32fc459c3cecc3c0768b1048b8ca9abf3a","head":{"label":"in-toto:warn-subprocess","ref":"warn-subprocess","sha":"34a0ad32fc459c3cecc3c0768b1048b8ca9abf3a","user":{"login":"in-toto","id":22891761,"avatar_url":"https://avatars.githubusercontent.com/u/22891761?v=3","gravatar_id":"","url":"https://api.github.com/users/in-toto","html_url":"https://github.com/in-toto","followers_url":"https://api.github.com/users/in-toto/followers","following_url":"https://api.github.com/users/in-toto/following{/other_user}","gists_url":"https://api.github.com/users/in-toto/gists{/gist_id}","starred_url":"https://api.github.com/users/in-toto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/in-toto/subscriptions","organizations_url":"https://api.github.com/users/in-toto/orgs","repos_url":"https://api.github.com/users/in-toto/repos","events_url":"https://api.github.com/users/in-toto/events{/privacy}","received_events_url":"https://api.github.com/users/in-toto/received_events","type":"Organization","site_admin":false},"repo":{"id":59531400,"name":"in-toto","full_name":"in-toto/in-toto","owner":{"login":"in-toto","id":22891761,"avatar_url":"https://avatars.githubusercontent.com/u/22891761?v=3","gravatar_id":"","url":"https://api.github.com/users/in-toto","html_url":"https://github.com/in-toto","followers_url":"https://api.github.com/users/in-toto/followers","following_url":"https://api.github.com/users/in-toto/following{/other_user}","gists_url":"https://api.github.com/users/in-toto/gists{/gist_id}","starred_url":"https://api.github.com/users/in-toto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/in-toto/subscriptions","organizations_url":"https://api.github.com/users/in-toto/orgs","repos_url":"https://api.github.com/users/in-toto/repos","events_url":"https://api.github.com/users/in-toto/events{/privacy}","received_events_url":"https://api.github.com/users/in-toto/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/in-toto/in-toto","description":"Toto is a framework to protect supply chain integrity.","fork":false,"url":"https://api.github.com/repos/in-toto/in-toto","forks_url":"https://api.github.com/repos/in-toto/in-toto/forks","keys_url":"https://api.github.com/repos/in-toto/in-toto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/in-toto/in-toto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/in-toto/in-toto/teams","hooks_url":"https://api.github.com/repos/in-toto/in-toto/hooks","issue_events_url":"https://api.github.com/repos/in-toto/in-toto/issues/events{/number}","events_url":"https://api.github.com/repos/in-toto/in-toto/events","assignees_url":"https://api.github.com/repos/in-toto/in-toto/assignees{/user}","branches_url":"https://api.github.com/repos/in-toto/in-toto/branches{/branch}","tags_url":"https://api.github.com/repos/in-toto/in-toto/tags","blobs_url":"https://api.github.com/repos/in-toto/in-toto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/in-toto/in-toto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/in-toto/in-toto/git/refs{/sha}","trees_url":"https://api.github.com/repos/in-toto/in-toto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/in-toto/in-toto/statuses/{sha}","languages_url":"https://api.github.com/repos/in-toto/in-toto/languages","stargazers_url":"https://api.github.com/repos/in-toto/in-toto/stargazers","contributors_url":"https://api.github.com/repos/in-toto/in-toto/contributors","subscribers_url":"https://api.github.com/repos/in-toto/in-toto/subscribers","subscription_url":"https://api.github.com/repos/in-toto/in-toto/subscription","commits_url":"https://api.github.com/repos/in-toto/in-toto/commits{/sha}","git_commits_url":"https://api.github.com/repos/in-toto/in-toto/git/commits{/sha}","comments_url":"https://api.github.com/repos/in-toto/in-toto/comments{/number}","issue_comment_url":"https://api.github.com/repos/in-toto/in-toto/issues/comments{/number}","contents_url":"https://api.github.com/repos/in-toto/in-toto/contents/{+path}","compare_url":"https://api.github.com/repos/in-toto/in-toto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/in-toto/in-toto/merges","archive_url":"https://api.github.com/repos/in-toto/in-toto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/in-toto/in-toto/downloads","issues_url":"https://api.github.com/repos/in-toto/in-toto/issues{/number}","pulls_url":"https://api.github.com/repos/in-toto/in-toto/pulls{/number}","milestones_url":"https://api.github.com/repos/in-toto/in-toto/milestones{/number}","notifications_url":"https://api.github.com/repos/in-toto/in-toto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/in-toto/in-toto/labels{/name}","releases_url":"https://api.github.com/repos/in-toto/in-toto/releases{/id}","deployments_url":"https://api.github.com/repos/in-toto/in-toto/deployments","created_at":"2016-05-24T01:46:38Z","updated_at":"2016-10-28T16:54:56Z","pushed_at":"2016-10-28T21:55:07Z","git_url":"git://github.com/in-toto/in-toto.git","ssh_url":"git@github.com:in-toto/in-toto.git","clone_url":"https://github.com/in-toto/in-toto.git","svn_url":"https://github.com/in-toto/in-toto","homepage":"","size":257,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":23,"forks":2,"open_issues":23,"watchers":1,"default_branch":"master"}},"base":{"label":"in-toto:develop","ref":"develop","sha":"3697e8b19a08ffb1537835f606a5cfedbeaa7244","user":{"login":"in-toto","id":22891761,"avatar_url":"https://avatars.githubusercontent.com/u/22891761?v=3","gravatar_id":"","url":"https://api.github.com/users/in-toto","html_url":"https://github.com/in-toto","followers_url":"https://api.github.com/users/in-toto/followers","following_url":"https://api.github.com/users/in-toto/following{/other_user}","gists_url":"https://api.github.com/users/in-toto/gists{/gist_id}","starred_url":"https://api.github.com/users/in-toto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/in-toto/subscriptions","organizations_url":"https://api.github.com/users/in-toto/orgs","repos_url":"https://api.github.com/users/in-toto/repos","events_url":"https://api.github.com/users/in-toto/events{/privacy}","received_events_url":"https://api.github.com/users/in-toto/received_events","type":"Organization","site_admin":false},"repo":{"id":59531400,"name":"in-toto","full_name":"in-toto/in-toto","owner":{"login":"in-toto","id":22891761,"avatar_url":"https://avatars.githubusercontent.com/u/22891761?v=3","gravatar_id":"","url":"https://api.github.com/users/in-toto","html_url":"https://github.com/in-toto","followers_url":"https://api.github.com/users/in-toto/followers","following_url":"https://api.github.com/users/in-toto/following{/other_user}","gists_url":"https://api.github.com/users/in-toto/gists{/gist_id}","starred_url":"https://api.github.com/users/in-toto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/in-toto/subscriptions","organizations_url":"https://api.github.com/users/in-toto/orgs","repos_url":"https://api.github.com/users/in-toto/repos","events_url":"https://api.github.com/users/in-toto/events{/privacy}","received_events_url":"https://api.github.com/users/in-toto/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/in-toto/in-toto","description":"Toto is a framework to protect supply chain integrity.","fork":false,"url":"https://api.github.com/repos/in-toto/in-toto","forks_url":"https://api.github.com/repos/in-toto/in-toto/forks","keys_url":"https://api.github.com/repos/in-toto/in-toto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/in-toto/in-toto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/in-toto/in-toto/teams","hooks_url":"https://api.github.com/repos/in-toto/in-toto/hooks","issue_events_url":"https://api.github.com/repos/in-toto/in-toto/issues/events{/number}","events_url":"https://api.github.com/repos/in-toto/in-toto/events","assignees_url":"https://api.github.com/repos/in-toto/in-toto/assignees{/user}","branches_url":"https://api.github.com/repos/in-toto/in-toto/branches{/branch}","tags_url":"https://api.github.com/repos/in-toto/in-toto/tags","blobs_url":"https://api.github.com/repos/in-toto/in-toto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/in-toto/in-toto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/in-toto/in-toto/git/refs{/sha}","trees_url":"https://api.github.com/repos/in-toto/in-toto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/in-toto/in-toto/statuses/{sha}","languages_url":"https://api.github.com/repos/in-toto/in-toto/languages","stargazers_url":"https://api.github.com/repos/in-toto/in-toto/stargazers","contributors_url":"https://api.github.com/repos/in-toto/in-toto/contributors","subscribers_url":"https://api.github.com/repos/in-toto/in-toto/subscribers","subscription_url":"https://api.github.com/repos/in-toto/in-toto/subscription","commits_url":"https://api.github.com/repos/in-toto/in-toto/commits{/sha}","git_commits_url":"https://api.github.com/repos/in-toto/in-toto/git/commits{/sha}","comments_url":"https://api.github.com/repos/in-toto/in-toto/comments{/number}","issue_comment_url":"https://api.github.com/repos/in-toto/in-toto/issues/comments{/number}","contents_url":"https://api.github.com/repos/in-toto/in-toto/contents/{+path}","compare_url":"https://api.github.com/repos/in-toto/in-toto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/in-toto/in-toto/merges","archive_url":"https://api.github.com/repos/in-toto/in-toto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/in-toto/in-toto/downloads","issues_url":"https://api.github.com/repos/in-toto/in-toto/issues{/number}","pulls_url":"https://api.github.com/repos/in-toto/in-toto/pulls{/number}","milestones_url":"https://api.github.com/repos/in-toto/in-toto/milestones{/number}","notifications_url":"https://api.github.com/repos/in-toto/in-toto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/in-toto/in-toto/labels{/name}","releases_url":"https://api.github.com/repos/in-toto/in-toto/releases{/id}","deployments_url":"https://api.github.com/repos/in-toto/in-toto/deployments","created_at":"2016-05-24T01:46:38Z","updated_at":"2016-10-28T16:54:56Z","pushed_at":"2016-10-28T21:55:07Z","git_url":"git://github.com/in-toto/in-toto.git","ssh_url":"git@github.com:in-toto/in-toto.git","clone_url":"https://github.com/in-toto/in-toto.git","svn_url":"https://github.com/in-toto/in-toto","homepage":"","size":257,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":23,"forks":2,"open_issues":23,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/in-toto/in-toto/pulls/27"},"html":{"href":"https://github.com/in-toto/in-toto/pull/27"},"issue":{"href":"https://api.github.com/repos/in-toto/in-toto/issues/27"},"comments":{"href":"https://api.github.com/repos/in-toto/in-toto/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/in-toto/in-toto/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/in-toto/in-toto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/in-toto/in-toto/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/in-toto/in-toto/statuses/34a0ad32fc459c3cecc3c0768b1048b8ca9abf3a"}}}}
{"actor":{"display_login":"SantiagoTorres"}}