{"action":"created","issue":{"url":"https://api.github.com/repos/sourcelair/xterm.js/issues/305","repository_url":"https://api.github.com/repos/sourcelair/xterm.js","labels_url":"https://api.github.com/repos/sourcelair/xterm.js/issues/305/labels{/name}","comments_url":"https://api.github.com/repos/sourcelair/xterm.js/issues/305/comments","events_url":"https://api.github.com/repos/sourcelair/xterm.js/issues/305/events","html_url":"https://github.com/sourcelair/xterm.js/issues/305","id":181520282,"number":305,"title":"Addon loader doesn't work in Electron","user":{"login":"ovanschie","id":3015449,"avatar_url":"https://avatars.githubusercontent.com/u/3015449?v=3","gravatar_id":"","url":"https://api.github.com/users/ovanschie","html_url":"https://github.com/ovanschie","followers_url":"https://api.github.com/users/ovanschie/followers","following_url":"https://api.github.com/users/ovanschie/following{/other_user}","gists_url":"https://api.github.com/users/ovanschie/gists{/gist_id}","starred_url":"https://api.github.com/users/ovanschie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ovanschie/subscriptions","organizations_url":"https://api.github.com/users/ovanschie/orgs","repos_url":"https://api.github.com/users/ovanschie/repos","events_url":"https://api.github.com/users/ovanschie/events{/privacy}","received_events_url":"https://api.github.com/users/ovanschie/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/sourcelair/xterm.js/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":{"login":"parisk","id":1188592,"avatar_url":"https://avatars.githubusercontent.com/u/1188592?v=3","gravatar_id":"","url":"https://api.github.com/users/parisk","html_url":"https://github.com/parisk","followers_url":"https://api.github.com/users/parisk/followers","following_url":"https://api.github.com/users/parisk/following{/other_user}","gists_url":"https://api.github.com/users/parisk/gists{/gist_id}","starred_url":"https://api.github.com/users/parisk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parisk/subscriptions","organizations_url":"https://api.github.com/users/parisk/orgs","repos_url":"https://api.github.com/users/parisk/repos","events_url":"https://api.github.com/users/parisk/events{/privacy}","received_events_url":"https://api.github.com/users/parisk/received_events","type":"User","site_admin":false},"assignees":[{"login":"parisk","id":1188592,"avatar_url":"https://avatars.githubusercontent.com/u/1188592?v=3","gravatar_id":"","url":"https://api.github.com/users/parisk","html_url":"https://github.com/parisk","followers_url":"https://api.github.com/users/parisk/followers","following_url":"https://api.github.com/users/parisk/following{/other_user}","gists_url":"https://api.github.com/users/parisk/gists{/gist_id}","starred_url":"https://api.github.com/users/parisk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parisk/subscriptions","organizations_url":"https://api.github.com/users/parisk/orgs","repos_url":"https://api.github.com/users/parisk/repos","events_url":"https://api.github.com/users/parisk/events{/privacy}","received_events_url":"https://api.github.com/users/parisk/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/sourcelair/xterm.js/milestones/5","html_url":"https://github.com/sourcelair/xterm.js/milestones/2.1.0","labels_url":"https://api.github.com/repos/sourcelair/xterm.js/milestones/5/labels","id":2044676,"number":5,"title":"2.1.0","description":"","creator":{"login":"parisk","id":1188592,"avatar_url":"https://avatars.githubusercontent.com/u/1188592?v=3","gravatar_id":"","url":"https://api.github.com/users/parisk","html_url":"https://github.com/parisk","followers_url":"https://api.github.com/users/parisk/followers","following_url":"https://api.github.com/users/parisk/following{/other_user}","gists_url":"https://api.github.com/users/parisk/gists{/gist_id}","starred_url":"https://api.github.com/users/parisk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parisk/subscriptions","organizations_url":"https://api.github.com/users/parisk/orgs","repos_url":"https://api.github.com/users/parisk/repos","events_url":"https://api.github.com/users/parisk/events{/privacy}","received_events_url":"https://api.github.com/users/parisk/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":0,"state":"open","created_at":"2016-10-03T16:34:37Z","updated_at":"2016-10-08T10:34:22Z","due_on":"2016-11-07T00:00:00Z","closed_at":null},"comments":6,"created_at":"2016-10-06T20:42:35Z","updated_at":"2016-10-09T15:16:08Z","closed_at":null,"body":"Since the 2.0 release the loadAddon method doesn't work anymore in Electron apps.\r\n\r\nCode:\r\n```\r\nvar Terminal = require('xterm');\r\nTerminal.loadAddon('fit');\r\n```\r\nError:\r\n`Uncaught Error: Cannot find module '/src/../addons/fit'`\r\n\r\nThe same code does work with version 1.1.3.\r\n\r\n## Details\r\n- Browser and browser version: Electron 1.4.3 (Chrome 53.0.2785.113)\r\n- OS version: MacOS Sierra\r\n- xterm.js version: 2.0.0 / 2.0.1\r\n"},"comment":{"url":"https://api.github.com/repos/sourcelair/xterm.js/issues/comments/252492278","html_url":"https://github.com/sourcelair/xterm.js/issues/305#issuecomment-252492278","issue_url":"https://api.github.com/repos/sourcelair/xterm.js/issues/305","id":252492278,"user":{"login":"ovanschie","id":3015449,"avatar_url":"https://avatars.githubusercontent.com/u/3015449?v=3","gravatar_id":"","url":"https://api.github.com/users/ovanschie","html_url":"https://github.com/ovanschie","followers_url":"https://api.github.com/users/ovanschie/followers","following_url":"https://api.github.com/users/ovanschie/following{/other_user}","gists_url":"https://api.github.com/users/ovanschie/gists{/gist_id}","starred_url":"https://api.github.com/users/ovanschie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ovanschie/subscriptions","organizations_url":"https://api.github.com/users/ovanschie/orgs","repos_url":"https://api.github.com/users/ovanschie/repos","events_url":"https://api.github.com/users/ovanschie/events{/privacy}","received_events_url":"https://api.github.com/users/ovanschie/received_events","type":"User","site_admin":false},"created_at":"2016-10-09T15:16:08Z","updated_at":"2016-10-09T15:16:08Z","body":"@parisk see my first comment for the import code i used. \r\n\r\nThe updated code in `update-addons-paths` works for me now!"}}
{"actor":{"display_login":"ovanschie"}}