{"action":"created","comment":{"url":"https://api.github.com/repos/pmem/nvml/pulls/comments/90215238","pull_request_review_id":10731558,"id":90215238,"diff_hunk":"@@ -62,7 +62,7 @@ align_addr(char *addr, uintptr_t align)\n  * align_len -- increase len by the amount we gain when we round addr down\n  */\n static size_t\n-align_len(size_t len, char *addr, uintptr_t align)\n+align_len(size_t len, void *addr, uintptr_t align)","path":"src/benchmarks/pmem_flush.c","position":16,"original_position":16,"commit_id":"30efe46a6d3058adb2ff78c90bcc2353b8a30d33","original_commit_id":"30efe46a6d3058adb2ff78c90bcc2353b8a30d33","user":{"login":"pbalcer","id":8775610,"avatar_url":"https://avatars.githubusercontent.com/u/8775610?v=3","gravatar_id":"","url":"https://api.github.com/users/pbalcer","html_url":"https://github.com/pbalcer","followers_url":"https://api.github.com/users/pbalcer/followers","following_url":"https://api.github.com/users/pbalcer/following{/other_user}","gists_url":"https://api.github.com/users/pbalcer/gists{/gist_id}","starred_url":"https://api.github.com/users/pbalcer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbalcer/subscriptions","organizations_url":"https://api.github.com/users/pbalcer/orgs","repos_url":"https://api.github.com/users/pbalcer/repos","events_url":"https://api.github.com/users/pbalcer/events{/privacy}","received_events_url":"https://api.github.com/users/pbalcer/received_events","type":"User","site_admin":false},"body":"The reason that this is char * and not void * is that void pointer arithmetic is a GNU extension and thus non-standard. Leave it as char * please. There are compiler warnings that will complain about this.","created_at":"2016-11-30T11:32:31Z","updated_at":"2016-11-30T11:33:12Z","html_url":"https://github.com/pmem/nvml/pull/1453#discussion_r90215238","pull_request_url":"https://api.github.com/repos/pmem/nvml/pulls/1453","_links":{"self":{"href":"https://api.github.com/repos/pmem/nvml/pulls/comments/90215238"},"html":{"href":"https://github.com/pmem/nvml/pull/1453#discussion_r90215238"},"pull_request":{"href":"https://api.github.com/repos/pmem/nvml/pulls/1453"}}},"pull_request":{"url":"https://api.github.com/repos/pmem/nvml/pulls/1453","id":95160396,"html_url":"https://github.com/pmem/nvml/pull/1453","diff_url":"https://github.com/pmem/nvml/pull/1453.diff","patch_url":"https://github.com/pmem/nvml/pull/1453.patch","issue_url":"https://api.github.com/repos/pmem/nvml/issues/1453","number":1453,"state":"open","locked":false,"title":"win: benchmarks windows port","user":{"login":"lplewa","id":19689632,"avatar_url":"https://avatars.githubusercontent.com/u/19689632?v=3","gravatar_id":"","url":"https://api.github.com/users/lplewa","html_url":"https://github.com/lplewa","followers_url":"https://api.github.com/users/lplewa/followers","following_url":"https://api.github.com/users/lplewa/following{/other_user}","gists_url":"https://api.github.com/users/lplewa/gists{/gist_id}","starred_url":"https://api.github.com/users/lplewa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lplewa/subscriptions","organizations_url":"https://api.github.com/users/lplewa/orgs","repos_url":"https://api.github.com/users/lplewa/repos","events_url":"https://api.github.com/users/lplewa/events{/privacy}","received_events_url":"https://api.github.com/users/lplewa/received_events","type":"User","site_admin":false},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/pmem/nvml/1453)\n<!-- Reviewable:end -->\n","created_at":"2016-11-24T11:20:41Z","updated_at":"2016-11-30T11:50:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f0e546a5363ce5a61f0f49e797ba76a6c33fc0ca","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pmem/nvml/pulls/1453/commits","review_comments_url":"https://api.github.com/repos/pmem/nvml/pulls/1453/comments","review_comment_url":"https://api.github.com/repos/pmem/nvml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pmem/nvml/issues/1453/comments","statuses_url":"https://api.github.com/repos/pmem/nvml/statuses/30efe46a6d3058adb2ff78c90bcc2353b8a30d33","head":{"label":"lplewa:bench","ref":"bench","sha":"30efe46a6d3058adb2ff78c90bcc2353b8a30d33","user":{"login":"lplewa","id":19689632,"avatar_url":"https://avatars.githubusercontent.com/u/19689632?v=3","gravatar_id":"","url":"https://api.github.com/users/lplewa","html_url":"https://github.com/lplewa","followers_url":"https://api.github.com/users/lplewa/followers","following_url":"https://api.github.com/users/lplewa/following{/other_user}","gists_url":"https://api.github.com/users/lplewa/gists{/gist_id}","starred_url":"https://api.github.com/users/lplewa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lplewa/subscriptions","organizations_url":"https://api.github.com/users/lplewa/orgs","repos_url":"https://api.github.com/users/lplewa/repos","events_url":"https://api.github.com/users/lplewa/events{/privacy}","received_events_url":"https://api.github.com/users/lplewa/received_events","type":"User","site_admin":false},"repo":{"id":60242851,"name":"nvml","full_name":"lplewa/nvml","owner":{"login":"lplewa","id":19689632,"avatar_url":"https://avatars.githubusercontent.com/u/19689632?v=3","gravatar_id":"","url":"https://api.github.com/users/lplewa","html_url":"https://github.com/lplewa","followers_url":"https://api.github.com/users/lplewa/followers","following_url":"https://api.github.com/users/lplewa/following{/other_user}","gists_url":"https://api.github.com/users/lplewa/gists{/gist_id}","starred_url":"https://api.github.com/users/lplewa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lplewa/subscriptions","organizations_url":"https://api.github.com/users/lplewa/orgs","repos_url":"https://api.github.com/users/lplewa/repos","events_url":"https://api.github.com/users/lplewa/events{/privacy}","received_events_url":"https://api.github.com/users/lplewa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lplewa/nvml","description":"Active development tree for the NVM Library","fork":true,"url":"https://api.github.com/repos/lplewa/nvml","forks_url":"https://api.github.com/repos/lplewa/nvml/forks","keys_url":"https://api.github.com/repos/lplewa/nvml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lplewa/nvml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lplewa/nvml/teams","hooks_url":"https://api.github.com/repos/lplewa/nvml/hooks","issue_events_url":"https://api.github.com/repos/lplewa/nvml/issues/events{/number}","events_url":"https://api.github.com/repos/lplewa/nvml/events","assignees_url":"https://api.github.com/repos/lplewa/nvml/assignees{/user}","branches_url":"https://api.github.com/repos/lplewa/nvml/branches{/branch}","tags_url":"https://api.github.com/repos/lplewa/nvml/tags","blobs_url":"https://api.github.com/repos/lplewa/nvml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lplewa/nvml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lplewa/nvml/git/refs{/sha}","trees_url":"https://api.github.com/repos/lplewa/nvml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lplewa/nvml/statuses/{sha}","languages_url":"https://api.github.com/repos/lplewa/nvml/languages","stargazers_url":"https://api.github.com/repos/lplewa/nvml/stargazers","contributors_url":"https://api.github.com/repos/lplewa/nvml/contributors","subscribers_url":"https://api.github.com/repos/lplewa/nvml/subscribers","subscription_url":"https://api.github.com/repos/lplewa/nvml/subscription","commits_url":"https://api.github.com/repos/lplewa/nvml/commits{/sha}","git_commits_url":"https://api.github.com/repos/lplewa/nvml/git/commits{/sha}","comments_url":"https://api.github.com/repos/lplewa/nvml/comments{/number}","issue_comment_url":"https://api.github.com/repos/lplewa/nvml/issues/comments{/number}","contents_url":"https://api.github.com/repos/lplewa/nvml/contents/{+path}","compare_url":"https://api.github.com/repos/lplewa/nvml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lplewa/nvml/merges","archive_url":"https://api.github.com/repos/lplewa/nvml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lplewa/nvml/downloads","issues_url":"https://api.github.com/repos/lplewa/nvml/issues{/number}","pulls_url":"https://api.github.com/repos/lplewa/nvml/pulls{/number}","milestones_url":"https://api.github.com/repos/lplewa/nvml/milestones{/number}","notifications_url":"https://api.github.com/repos/lplewa/nvml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lplewa/nvml/labels{/name}","releases_url":"https://api.github.com/repos/lplewa/nvml/releases{/id}","deployments_url":"https://api.github.com/repos/lplewa/nvml/deployments","created_at":"2016-06-02T07:39:34Z","updated_at":"2016-06-02T07:39:43Z","pushed_at":"2016-11-30T09:56:39Z","git_url":"git://github.com/lplewa/nvml.git","ssh_url":"git@github.com:lplewa/nvml.git","clone_url":"https://github.com/lplewa/nvml.git","svn_url":"https://github.com/lplewa/nvml","homepage":"http://pmem.io","size":12513,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"pmem:master","ref":"master","sha":"f5e2e9f6d828adbc77a7fe60f244cc6011a56cb9","user":{"login":"pmem","id":4894933,"avatar_url":"https://avatars.githubusercontent.com/u/4894933?v=3","gravatar_id":"","url":"https://api.github.com/users/pmem","html_url":"https://github.com/pmem","followers_url":"https://api.github.com/users/pmem/followers","following_url":"https://api.github.com/users/pmem/following{/other_user}","gists_url":"https://api.github.com/users/pmem/gists{/gist_id}","starred_url":"https://api.github.com/users/pmem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmem/subscriptions","organizations_url":"https://api.github.com/users/pmem/orgs","repos_url":"https://api.github.com/users/pmem/repos","events_url":"https://api.github.com/users/pmem/events{/privacy}","received_events_url":"https://api.github.com/users/pmem/received_events","type":"Organization","site_admin":false},"repo":{"id":23637153,"name":"nvml","full_name":"pmem/nvml","owner":{"login":"pmem","id":4894933,"avatar_url":"https://avatars.githubusercontent.com/u/4894933?v=3","gravatar_id":"","url":"https://api.github.com/users/pmem","html_url":"https://github.com/pmem","followers_url":"https://api.github.com/users/pmem/followers","following_url":"https://api.github.com/users/pmem/following{/other_user}","gists_url":"https://api.github.com/users/pmem/gists{/gist_id}","starred_url":"https://api.github.com/users/pmem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmem/subscriptions","organizations_url":"https://api.github.com/users/pmem/orgs","repos_url":"https://api.github.com/users/pmem/repos","events_url":"https://api.github.com/users/pmem/events{/privacy}","received_events_url":"https://api.github.com/users/pmem/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pmem/nvml","description":"Active development tree for the NVM Library","fork":false,"url":"https://api.github.com/repos/pmem/nvml","forks_url":"https://api.github.com/repos/pmem/nvml/forks","keys_url":"https://api.github.com/repos/pmem/nvml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmem/nvml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmem/nvml/teams","hooks_url":"https://api.github.com/repos/pmem/nvml/hooks","issue_events_url":"https://api.github.com/repos/pmem/nvml/issues/events{/number}","events_url":"https://api.github.com/repos/pmem/nvml/events","assignees_url":"https://api.github.com/repos/pmem/nvml/assignees{/user}","branches_url":"https://api.github.com/repos/pmem/nvml/branches{/branch}","tags_url":"https://api.github.com/repos/pmem/nvml/tags","blobs_url":"https://api.github.com/repos/pmem/nvml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmem/nvml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmem/nvml/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmem/nvml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmem/nvml/statuses/{sha}","languages_url":"https://api.github.com/repos/pmem/nvml/languages","stargazers_url":"https://api.github.com/repos/pmem/nvml/stargazers","contributors_url":"https://api.github.com/repos/pmem/nvml/contributors","subscribers_url":"https://api.github.com/repos/pmem/nvml/subscribers","subscription_url":"https://api.github.com/repos/pmem/nvml/subscription","commits_url":"https://api.github.com/repos/pmem/nvml/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmem/nvml/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmem/nvml/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmem/nvml/issues/comments{/number}","contents_url":"https://api.github.com/repos/pmem/nvml/contents/{+path}","compare_url":"https://api.github.com/repos/pmem/nvml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmem/nvml/merges","archive_url":"https://api.github.com/repos/pmem/nvml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmem/nvml/downloads","issues_url":"https://api.github.com/repos/pmem/nvml/issues{/number}","pulls_url":"https://api.github.com/repos/pmem/nvml/pulls{/number}","milestones_url":"https://api.github.com/repos/pmem/nvml/milestones{/number}","notifications_url":"https://api.github.com/repos/pmem/nvml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmem/nvml/labels{/name}","releases_url":"https://api.github.com/repos/pmem/nvml/releases{/id}","deployments_url":"https://api.github.com/repos/pmem/nvml/deployments","created_at":"2014-09-03T20:55:23Z","updated_at":"2016-11-29T20:01:36Z","pushed_at":"2016-11-30T10:26:07Z","git_url":"git://github.com/pmem/nvml.git","ssh_url":"git@github.com:pmem/nvml.git","clone_url":"https://github.com/pmem/nvml.git","svn_url":"https://github.com/pmem/nvml","homepage":"http://pmem.io","size":21757,"stargazers_count":184,"watchers_count":184,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":106,"mirror_url":null,"open_issues_count":24,"forks":106,"open_issues":24,"watchers":184,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pmem/nvml/pulls/1453"},"html":{"href":"https://github.com/pmem/nvml/pull/1453"},"issue":{"href":"https://api.github.com/repos/pmem/nvml/issues/1453"},"comments":{"href":"https://api.github.com/repos/pmem/nvml/issues/1453/comments"},"review_comments":{"href":"https://api.github.com/repos/pmem/nvml/pulls/1453/comments"},"review_comment":{"href":"https://api.github.com/repos/pmem/nvml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pmem/nvml/pulls/1453/commits"},"statuses":{"href":"https://api.github.com/repos/pmem/nvml/statuses/30efe46a6d3058adb2ff78c90bcc2353b8a30d33"}}}}
{"actor":{"display_login":"pbalcer"}}