{"action":"created","comment":{"url":"https://api.github.com/repos/quattor/template-library-core/pulls/comments/92763584","pull_request_review_id":13283885,"id":92763584,"diff_hunk":"@@ -103,10 +103,30 @@ type blockdevices_file_type = {\n type raid_device_path = string with exists (\"/system/blockdevices/hwraid/\"\n     + SELF) || is_card_port (SELF);\n \n+@documentation{\n+    blockdevices correct device check based on device size\n+}\n+type blockdevices_correct_size = {\n+    @{allowed absolute margin (in MiB) compared to configured size}\n+    \"diff\" ? long(0..)\n+    @{allowed relative margin compared to configured size}\n+    \"fraction\" ? double\n+};\n+\n+@documentation{\n+    blockdevices correct device check\n+}\n+type blockdevices_correct = {\n+    @{size-based correctness check}\n+    \"size\" ? blockdevices_correct_size\n+};\n+\n type blockdevices_disk_type = {\n     \"device_path\" ? raid_device_path\n     \"label\" : string with match (SELF, (\"^(none|msdos|gpt|aix|bsd)$\"))\n     \"readahead\" ? long # Blocks for readahead\n+    @{enable correctness checks}\n+    \"correct\" ? blockdevices_correct","path":"quattor/blockdevices.pan","position":27,"original_position":27,"commit_id":"29546d277b8e823bc1806b4c59e31d787a41ac33","original_commit_id":"29546d277b8e823bc1806b4c59e31d787a41ac33","user":{"login":"stdweird","id":1517606,"avatar_url":"https://avatars.githubusercontent.com/u/1517606?v=3","gravatar_id":"","url":"https://api.github.com/users/stdweird","html_url":"https://github.com/stdweird","followers_url":"https://api.github.com/users/stdweird/followers","following_url":"https://api.github.com/users/stdweird/following{/other_user}","gists_url":"https://api.github.com/users/stdweird/gists{/gist_id}","starred_url":"https://api.github.com/users/stdweird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stdweird/subscriptions","organizations_url":"https://api.github.com/users/stdweird/orgs","repos_url":"https://api.github.com/users/stdweird/repos","events_url":"https://api.github.com/users/stdweird/events{/privacy}","received_events_url":"https://api.github.com/users/stdweird/received_events","type":"User","site_admin":false},"body":"ok, i can't come up with anything; but it also implies a (small) change in `ncm-lib-blockdeivces`.","created_at":"2016-12-16T07:25:28Z","updated_at":"2016-12-16T07:25:28Z","html_url":"https://github.com/quattor/template-library-core/pull/139#discussion_r92763584","pull_request_url":"https://api.github.com/repos/quattor/template-library-core/pulls/139","_links":{"self":{"href":"https://api.github.com/repos/quattor/template-library-core/pulls/comments/92763584"},"html":{"href":"https://github.com/quattor/template-library-core/pull/139#discussion_r92763584"},"pull_request":{"href":"https://api.github.com/repos/quattor/template-library-core/pulls/139"}}},"pull_request":{"url":"https://api.github.com/repos/quattor/template-library-core/pulls/139","id":98009323,"html_url":"https://github.com/quattor/template-library-core/pull/139","diff_url":"https://github.com/quattor/template-library-core/pull/139.diff","patch_url":"https://github.com/quattor/template-library-core/pull/139.patch","issue_url":"https://api.github.com/repos/quattor/template-library-core/issues/139","number":139,"state":"open","locked":false,"title":"blockdevices: add correctness check configuration to physical devices","user":{"login":"stdweird","id":1517606,"avatar_url":"https://avatars.githubusercontent.com/u/1517606?v=3","gravatar_id":"","url":"https://api.github.com/users/stdweird","html_url":"https://github.com/stdweird","followers_url":"https://api.github.com/users/stdweird/followers","following_url":"https://api.github.com/users/stdweird/following{/other_user}","gists_url":"https://api.github.com/users/stdweird/gists{/gist_id}","starred_url":"https://api.github.com/users/stdweird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stdweird/subscriptions","organizations_url":"https://api.github.com/users/stdweird/orgs","repos_url":"https://api.github.com/users/stdweird/repos","events_url":"https://api.github.com/users/stdweird/events{/privacy}","received_events_url":"https://api.github.com/users/stdweird/received_events","type":"User","site_admin":false},"body":"Was introduced in https://github.com/quattor/ncm-lib-blockdevices/pull/40\r\n\r\nRequires https://github.com/quattor/ncm-lib-blockdevices/pull/73","created_at":"2016-12-14T18:33:13Z","updated_at":"2016-12-16T07:25:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53f3f40875059a522513296f1be956469134b78c","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/quattor/template-library-core/milestones/13","html_url":"https://github.com/quattor/template-library-core/milestone/13","labels_url":"https://api.github.com/repos/quattor/template-library-core/milestones/13/labels","id":2052497,"number":13,"title":"17.2","description":null,"creator":{"login":"jrha","id":323309,"avatar_url":"https://avatars.githubusercontent.com/u/323309?v=3","gravatar_id":"","url":"https://api.github.com/users/jrha","html_url":"https://github.com/jrha","followers_url":"https://api.github.com/users/jrha/followers","following_url":"https://api.github.com/users/jrha/following{/other_user}","gists_url":"https://api.github.com/users/jrha/gists{/gist_id}","starred_url":"https://api.github.com/users/jrha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrha/subscriptions","organizations_url":"https://api.github.com/users/jrha/orgs","repos_url":"https://api.github.com/users/jrha/repos","events_url":"https://api.github.com/users/jrha/events{/privacy}","received_events_url":"https://api.github.com/users/jrha/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":0,"state":"open","created_at":"2016-10-06T14:22:41Z","updated_at":"2016-12-14T18:33:13Z","due_on":"2017-02-28T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/quattor/template-library-core/pulls/139/commits","review_comments_url":"https://api.github.com/repos/quattor/template-library-core/pulls/139/comments","review_comment_url":"https://api.github.com/repos/quattor/template-library-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quattor/template-library-core/issues/139/comments","statuses_url":"https://api.github.com/repos/quattor/template-library-core/statuses/29546d277b8e823bc1806b4c59e31d787a41ac33","head":{"label":"stdweird:blockdev_correct","ref":"blockdev_correct","sha":"29546d277b8e823bc1806b4c59e31d787a41ac33","user":{"login":"stdweird","id":1517606,"avatar_url":"https://avatars.githubusercontent.com/u/1517606?v=3","gravatar_id":"","url":"https://api.github.com/users/stdweird","html_url":"https://github.com/stdweird","followers_url":"https://api.github.com/users/stdweird/followers","following_url":"https://api.github.com/users/stdweird/following{/other_user}","gists_url":"https://api.github.com/users/stdweird/gists{/gist_id}","starred_url":"https://api.github.com/users/stdweird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stdweird/subscriptions","organizations_url":"https://api.github.com/users/stdweird/orgs","repos_url":"https://api.github.com/users/stdweird/repos","events_url":"https://api.github.com/users/stdweird/events{/privacy}","received_events_url":"https://api.github.com/users/stdweird/received_events","type":"User","site_admin":false},"repo":{"id":21003640,"name":"template-library-core","full_name":"stdweird/template-library-core","owner":{"login":"stdweird","id":1517606,"avatar_url":"https://avatars.githubusercontent.com/u/1517606?v=3","gravatar_id":"","url":"https://api.github.com/users/stdweird","html_url":"https://github.com/stdweird","followers_url":"https://api.github.com/users/stdweird/followers","following_url":"https://api.github.com/users/stdweird/following{/other_user}","gists_url":"https://api.github.com/users/stdweird/gists{/gist_id}","starred_url":"https://api.github.com/users/stdweird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stdweird/subscriptions","organizations_url":"https://api.github.com/users/stdweird/orgs","repos_url":"https://api.github.com/users/stdweird/repos","events_url":"https://api.github.com/users/stdweird/events{/privacy}","received_events_url":"https://api.github.com/users/stdweird/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stdweird/template-library-core","description":"Pan templates for the configuration modules","fork":true,"url":"https://api.github.com/repos/stdweird/template-library-core","forks_url":"https://api.github.com/repos/stdweird/template-library-core/forks","keys_url":"https://api.github.com/repos/stdweird/template-library-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stdweird/template-library-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stdweird/template-library-core/teams","hooks_url":"https://api.github.com/repos/stdweird/template-library-core/hooks","issue_events_url":"https://api.github.com/repos/stdweird/template-library-core/issues/events{/number}","events_url":"https://api.github.com/repos/stdweird/template-library-core/events","assignees_url":"https://api.github.com/repos/stdweird/template-library-core/assignees{/user}","branches_url":"https://api.github.com/repos/stdweird/template-library-core/branches{/branch}","tags_url":"https://api.github.com/repos/stdweird/template-library-core/tags","blobs_url":"https://api.github.com/repos/stdweird/template-library-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stdweird/template-library-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stdweird/template-library-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/stdweird/template-library-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stdweird/template-library-core/statuses/{sha}","languages_url":"https://api.github.com/repos/stdweird/template-library-core/languages","stargazers_url":"https://api.github.com/repos/stdweird/template-library-core/stargazers","contributors_url":"https://api.github.com/repos/stdweird/template-library-core/contributors","subscribers_url":"https://api.github.com/repos/stdweird/template-library-core/subscribers","subscription_url":"https://api.github.com/repos/stdweird/template-library-core/subscription","commits_url":"https://api.github.com/repos/stdweird/template-library-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/stdweird/template-library-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/stdweird/template-library-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/stdweird/template-library-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/stdweird/template-library-core/contents/{+path}","compare_url":"https://api.github.com/repos/stdweird/template-library-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stdweird/template-library-core/merges","archive_url":"https://api.github.com/repos/stdweird/template-library-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stdweird/template-library-core/downloads","issues_url":"https://api.github.com/repos/stdweird/template-library-core/issues{/number}","pulls_url":"https://api.github.com/repos/stdweird/template-library-core/pulls{/number}","milestones_url":"https://api.github.com/repos/stdweird/template-library-core/milestones{/number}","notifications_url":"https://api.github.com/repos/stdweird/template-library-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stdweird/template-library-core/labels{/name}","releases_url":"https://api.github.com/repos/stdweird/template-library-core/releases{/id}","deployments_url":"https://api.github.com/repos/stdweird/template-library-core/deployments","created_at":"2014-06-19T14:39:17Z","updated_at":"2014-08-13T15:15:36Z","pushed_at":"2016-12-14T18:31:08Z","git_url":"git://github.com/stdweird/template-library-core.git","ssh_url":"git@github.com:stdweird/template-library-core.git","clone_url":"https://github.com/stdweird/template-library-core.git","svn_url":"https://github.com/stdweird/template-library-core","homepage":null,"size":5322,"stargazers_count":1,"watchers_count":1,"language":"Pan","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"quattor:master","ref":"master","sha":"5f4816abdde34769e715f0d2386f73e04d853798","user":{"login":"quattor","id":1557169,"avatar_url":"https://avatars.githubusercontent.com/u/1557169?v=3","gravatar_id":"","url":"https://api.github.com/users/quattor","html_url":"https://github.com/quattor","followers_url":"https://api.github.com/users/quattor/followers","following_url":"https://api.github.com/users/quattor/following{/other_user}","gists_url":"https://api.github.com/users/quattor/gists{/gist_id}","starred_url":"https://api.github.com/users/quattor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quattor/subscriptions","organizations_url":"https://api.github.com/users/quattor/orgs","repos_url":"https://api.github.com/users/quattor/repos","events_url":"https://api.github.com/users/quattor/events{/privacy}","received_events_url":"https://api.github.com/users/quattor/received_events","type":"Organization","site_admin":false},"repo":{"id":12486277,"name":"template-library-core","full_name":"quattor/template-library-core","owner":{"login":"quattor","id":1557169,"avatar_url":"https://avatars.githubusercontent.com/u/1557169?v=3","gravatar_id":"","url":"https://api.github.com/users/quattor","html_url":"https://github.com/quattor","followers_url":"https://api.github.com/users/quattor/followers","following_url":"https://api.github.com/users/quattor/following{/other_user}","gists_url":"https://api.github.com/users/quattor/gists{/gist_id}","starred_url":"https://api.github.com/users/quattor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quattor/subscriptions","organizations_url":"https://api.github.com/users/quattor/orgs","repos_url":"https://api.github.com/users/quattor/repos","events_url":"https://api.github.com/users/quattor/events{/privacy}","received_events_url":"https://api.github.com/users/quattor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quattor/template-library-core","description":"Pan templates for the configuration modules","fork":false,"url":"https://api.github.com/repos/quattor/template-library-core","forks_url":"https://api.github.com/repos/quattor/template-library-core/forks","keys_url":"https://api.github.com/repos/quattor/template-library-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quattor/template-library-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quattor/template-library-core/teams","hooks_url":"https://api.github.com/repos/quattor/template-library-core/hooks","issue_events_url":"https://api.github.com/repos/quattor/template-library-core/issues/events{/number}","events_url":"https://api.github.com/repos/quattor/template-library-core/events","assignees_url":"https://api.github.com/repos/quattor/template-library-core/assignees{/user}","branches_url":"https://api.github.com/repos/quattor/template-library-core/branches{/branch}","tags_url":"https://api.github.com/repos/quattor/template-library-core/tags","blobs_url":"https://api.github.com/repos/quattor/template-library-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quattor/template-library-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quattor/template-library-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/quattor/template-library-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quattor/template-library-core/statuses/{sha}","languages_url":"https://api.github.com/repos/quattor/template-library-core/languages","stargazers_url":"https://api.github.com/repos/quattor/template-library-core/stargazers","contributors_url":"https://api.github.com/repos/quattor/template-library-core/contributors","subscribers_url":"https://api.github.com/repos/quattor/template-library-core/subscribers","subscription_url":"https://api.github.com/repos/quattor/template-library-core/subscription","commits_url":"https://api.github.com/repos/quattor/template-library-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/quattor/template-library-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/quattor/template-library-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/quattor/template-library-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/quattor/template-library-core/contents/{+path}","compare_url":"https://api.github.com/repos/quattor/template-library-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quattor/template-library-core/merges","archive_url":"https://api.github.com/repos/quattor/template-library-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quattor/template-library-core/downloads","issues_url":"https://api.github.com/repos/quattor/template-library-core/issues{/number}","pulls_url":"https://api.github.com/repos/quattor/template-library-core/pulls{/number}","milestones_url":"https://api.github.com/repos/quattor/template-library-core/milestones{/number}","notifications_url":"https://api.github.com/repos/quattor/template-library-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quattor/template-library-core/labels{/name}","releases_url":"https://api.github.com/repos/quattor/template-library-core/releases{/id}","deployments_url":"https://api.github.com/repos/quattor/template-library-core/deployments","created_at":"2013-08-30T12:52:11Z","updated_at":"2016-11-02T16:09:17Z","pushed_at":"2016-12-15T12:44:27Z","git_url":"git://github.com/quattor/template-library-core.git","ssh_url":"git@github.com:quattor/template-library-core.git","clone_url":"https://github.com/quattor/template-library-core.git","svn_url":"https://github.com/quattor/template-library-core","homepage":null,"size":5719,"stargazers_count":2,"watchers_count":2,"language":"Pan","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":17,"forks":20,"open_issues":17,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quattor/template-library-core/pulls/139"},"html":{"href":"https://github.com/quattor/template-library-core/pull/139"},"issue":{"href":"https://api.github.com/repos/quattor/template-library-core/issues/139"},"comments":{"href":"https://api.github.com/repos/quattor/template-library-core/issues/139/comments"},"review_comments":{"href":"https://api.github.com/repos/quattor/template-library-core/pulls/139/comments"},"review_comment":{"href":"https://api.github.com/repos/quattor/template-library-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quattor/template-library-core/pulls/139/commits"},"statuses":{"href":"https://api.github.com/repos/quattor/template-library-core/statuses/29546d277b8e823bc1806b4c59e31d787a41ac33"}}}}
{"actor":{"display_login":"stdweird"}}