{"action":"created","issue":{"url":"https://api.github.com/repos/nodogsplash/nodogsplash/issues/72","repository_url":"https://api.github.com/repos/nodogsplash/nodogsplash","labels_url":"https://api.github.com/repos/nodogsplash/nodogsplash/issues/72/labels{/name}","comments_url":"https://api.github.com/repos/nodogsplash/nodogsplash/issues/72/comments","events_url":"https://api.github.com/repos/nodogsplash/nodogsplash/issues/72/events","html_url":"https://github.com/nodogsplash/nodogsplash/issues/72","id":78090611,"number":72,"title":"Client “Failed to obtain IP”","user":{"login":"aaronchn","id":6897149,"avatar_url":"https://avatars.githubusercontent.com/u/6897149?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronchn","html_url":"https://github.com/aaronchn","followers_url":"https://api.github.com/users/aaronchn/followers","following_url":"https://api.github.com/users/aaronchn/following{/other_user}","gists_url":"https://api.github.com/users/aaronchn/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronchn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronchn/subscriptions","organizations_url":"https://api.github.com/users/aaronchn/orgs","repos_url":"https://api.github.com/users/aaronchn/repos","events_url":"https://api.github.com/users/aaronchn/events{/privacy}","received_events_url":"https://api.github.com/users/aaronchn/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2015-05-19T13:35:23Z","updated_at":"2016-08-04T19:10:29Z","closed_at":"2016-08-04T19:10:29Z","body":"Thank you for your excellent work!\r\n\r\nWhen I tried the version 0.9_beta9.9.8 and version 0.9_beta9.9.9 with has been customized nodogsplash.conf, the client which is not in “AllowedMACList” will be can’t get IP from the OpenWRT.\r\n\r\nThe normal logic is when the “MACMechanism” set “allow”, just the allowed MAC can get IP via dhcp services from the OpenWRT then triggered the splash page?\r\n\r\nIn my case, anyone who want to use my WiFi are popular, when they connected my SSID with none encryption, they can get IP then see the splash page. But just some MAC can through the authenticated which are in the allowed list. That should be wonderful.\r\n\r\nIs this are real bug? Should I report it on Github? Any resolve tips? \r\n \r\nThe key configurations are following:\r\n<pre>\r\n# Parameter: GatewayInterface\r\nGatewayInterface br-lan\r\n# FirewallRuleSet: users-to-router\r\nFirewallRule allow tcp port 8080 (for my luci on this router)\r\n# Parameter: GatewayAddress\r\nGatewayAddress 192.168.1.1\r\n# Parameter: ExternalInterface\r\nExternalInterface vlan1\r\n# Parameter: RedirectURL\r\nRedirectURL http://192.168.1.1/ (for my lighttpd on this router)\r\n# ClientIdleTimeout\r\nClientIdleTimeout 30\r\n# Parameter: ClientForceTimeout\r\nClientForceTimeout 60\r\n# Parameter: MACMechanism\r\nMACMechanism allow\r\n# Parameter: AllowedMACList\r\nAllowedMACList 00:16:XX:XX:XX,…\r\n</pre>\r\n \r\nThank you！ "},"comment":{"url":"https://api.github.com/repos/nodogsplash/nodogsplash/issues/comments/237653265","html_url":"https://github.com/nodogsplash/nodogsplash/issues/72#issuecomment-237653265","issue_url":"https://api.github.com/repos/nodogsplash/nodogsplash/issues/72","id":237653265,"user":{"login":"mwarning","id":546193,"avatar_url":"https://avatars.githubusercontent.com/u/546193?v=3","gravatar_id":"","url":"https://api.github.com/users/mwarning","html_url":"https://github.com/mwarning","followers_url":"https://api.github.com/users/mwarning/followers","following_url":"https://api.github.com/users/mwarning/following{/other_user}","gists_url":"https://api.github.com/users/mwarning/gists{/gist_id}","starred_url":"https://api.github.com/users/mwarning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwarning/subscriptions","organizations_url":"https://api.github.com/users/mwarning/orgs","repos_url":"https://api.github.com/users/mwarning/repos","events_url":"https://api.github.com/users/mwarning/events{/privacy}","received_events_url":"https://api.github.com/users/mwarning/received_events","type":"User","site_admin":false},"created_at":"2016-08-04T19:10:29Z","updated_at":"2016-08-04T19:10:29Z","body":"NDS does not interfere by with the DHCP server (the port is allowed by default by NDS)"}}
{"actor":{"display_login":"mwarning"}}