{"action":"opened","number":16986,"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/16986","id":61926460,"html_url":"https://github.com/elastic/elasticsearch/pull/16986","diff_url":"https://github.com/elastic/elasticsearch/pull/16986.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/16986.patch","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/16986","number":16986,"state":"open","locked":false,"title":"Enable unmap hack for java 9","user":{"login":"rmuir","id":504194,"avatar_url":"https://avatars.githubusercontent.com/u/504194?v=3","gravatar_id":"","url":"https://api.github.com/users/rmuir","html_url":"https://github.com/rmuir","followers_url":"https://api.github.com/users/rmuir/followers","following_url":"https://api.github.com/users/rmuir/following{/other_user}","gists_url":"https://api.github.com/users/rmuir/gists{/gist_id}","starred_url":"https://api.github.com/users/rmuir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmuir/subscriptions","organizations_url":"https://api.github.com/users/rmuir/orgs","repos_url":"https://api.github.com/users/rmuir/repos","events_url":"https://api.github.com/users/rmuir/events{/privacy}","received_events_url":"https://api.github.com/users/rmuir/received_events","type":"User","site_admin":false},"body":"This mechanism changed for java 9: requires a \"fake\" permission of `accessClassInPackage.jdk.internal.ref`\r\n\r\nCurrently unmapping will not work with java 9 unless we make changes:\r\n```\r\n  2> REPRODUCE WITH: gradle :core:test -Dtests.seed=D11864EB2E98C3EF -Dtests.class=org.elasticsearch.common.lucene.LuceneTests -Dtests.method=\"testMMapHackSupported\" -Des.logger.level=WARN -Dtests.security.manager=true -Dtests.locale=jmc-TZ -Dtests.timezone=Antarctica/DumontDUrville\r\nFAILURE 0.13s J0 | LuceneTests.testMMapHackSupported <<< FAILURES!\r\n   > Throwable #1: java.lang.AssertionError: MMapDirectory does not support unmapping: Unmapping is not supported, because not all required permissions are given to the Lucene JAR file: java.security.AccessControlException: access denied (\"java.lang.RuntimePermission\" \"accessClassInPackage.jdk.internal.ref\") [Please grant at least the following permissions: RuntimePermission(\"accessClassInPackage.sun.misc\"), RuntimePermission(\"accessClassInPackage.jdk.internal.ref\"), and ReflectPermission(\"suppressAccessChecks\")]\r\n``` \r\n\r\nSee https://issues.apache.org/jira/browse/LUCENE-6989 for more information. \r\n\r\nI also had to upgrade my gradle to the latest to work at all with java 9, and fix a test so the source code compiles at all. I only ran this small unit test because hotspot on java 9 has been broken for a long time.","created_at":"2016-03-07T14:47:57Z","updated_at":"2016-03-07T14:47:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/16986/commits","review_comments_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/16986/comments","review_comment_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/16986/comments","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/a0191dff01d137c9cdf039c233654859f9f4b575","head":{"label":"rmuir:mmap_java9","ref":"mmap_java9","sha":"a0191dff01d137c9cdf039c233654859f9f4b575","user":{"login":"rmuir","id":504194,"avatar_url":"https://avatars.githubusercontent.com/u/504194?v=3","gravatar_id":"","url":"https://api.github.com/users/rmuir","html_url":"https://github.com/rmuir","followers_url":"https://api.github.com/users/rmuir/followers","following_url":"https://api.github.com/users/rmuir/following{/other_user}","gists_url":"https://api.github.com/users/rmuir/gists{/gist_id}","starred_url":"https://api.github.com/users/rmuir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmuir/subscriptions","organizations_url":"https://api.github.com/users/rmuir/orgs","repos_url":"https://api.github.com/users/rmuir/repos","events_url":"https://api.github.com/users/rmuir/events{/privacy}","received_events_url":"https://api.github.com/users/rmuir/received_events","type":"User","site_admin":false},"repo":{"id":17824809,"name":"elasticsearch","full_name":"rmuir/elasticsearch","owner":{"login":"rmuir","id":504194,"avatar_url":"https://avatars.githubusercontent.com/u/504194?v=3","gravatar_id":"","url":"https://api.github.com/users/rmuir","html_url":"https://github.com/rmuir","followers_url":"https://api.github.com/users/rmuir/followers","following_url":"https://api.github.com/users/rmuir/following{/other_user}","gists_url":"https://api.github.com/users/rmuir/gists{/gist_id}","starred_url":"https://api.github.com/users/rmuir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmuir/subscriptions","organizations_url":"https://api.github.com/users/rmuir/orgs","repos_url":"https://api.github.com/users/rmuir/repos","events_url":"https://api.github.com/users/rmuir/events{/privacy}","received_events_url":"https://api.github.com/users/rmuir/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rmuir/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/rmuir/elasticsearch","forks_url":"https://api.github.com/repos/rmuir/elasticsearch/forks","keys_url":"https://api.github.com/repos/rmuir/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rmuir/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rmuir/elasticsearch/teams","hooks_url":"https://api.github.com/repos/rmuir/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/rmuir/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/rmuir/elasticsearch/events","assignees_url":"https://api.github.com/repos/rmuir/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/rmuir/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/rmuir/elasticsearch/tags","blobs_url":"https://api.github.com/repos/rmuir/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rmuir/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rmuir/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/rmuir/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rmuir/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/rmuir/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/rmuir/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/rmuir/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/rmuir/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/rmuir/elasticsearch/subscription","commits_url":"https://api.github.com/repos/rmuir/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/rmuir/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/rmuir/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/rmuir/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/rmuir/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/rmuir/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rmuir/elasticsearch/merges","archive_url":"https://api.github.com/repos/rmuir/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rmuir/elasticsearch/downloads","issues_url":"https://api.github.com/repos/rmuir/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/rmuir/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/rmuir/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/rmuir/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rmuir/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/rmuir/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/rmuir/elasticsearch/deployments","created_at":"2014-03-17T10:46:33Z","updated_at":"2015-05-06T05:03:07Z","pushed_at":"2016-03-07T14:46:14Z","git_url":"git://github.com/rmuir/elasticsearch.git","ssh_url":"git@github.com:rmuir/elasticsearch.git","clone_url":"https://github.com/rmuir/elasticsearch.git","svn_url":"https://github.com/rmuir/elasticsearch","homepage":"http://elasticsearch.org","size":188936,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"82d01e431557296ab279c0936a145a2047c2920f","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":507775,"name":"elasticsearch","full_name":"elastic/elasticsearch","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":false,"url":"https://api.github.com/repos/elastic/elasticsearch","forks_url":"https://api.github.com/repos/elastic/elasticsearch/forks","keys_url":"https://api.github.com/repos/elastic/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/elasticsearch/teams","hooks_url":"https://api.github.com/repos/elastic/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/elasticsearch/events","assignees_url":"https://api.github.com/repos/elastic/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/elasticsearch/tags","blobs_url":"https://api.github.com/repos/elastic/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/elastic/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/elastic/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/elastic/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/elastic/elasticsearch/subscription","commits_url":"https://api.github.com/repos/elastic/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/elasticsearch/merges","archive_url":"https://api.github.com/repos/elastic/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/elasticsearch/downloads","issues_url":"https://api.github.com/repos/elastic/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/elastic/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/elasticsearch/deployments","created_at":"2010-02-08T13:20:56Z","updated_at":"2016-03-07T14:33:56Z","pushed_at":"2016-03-07T14:40:06Z","git_url":"git://github.com/elastic/elasticsearch.git","ssh_url":"git@github.com:elastic/elasticsearch.git","clone_url":"https://github.com/elastic/elasticsearch.git","svn_url":"https://github.com/elastic/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":299327,"stargazers_count":15956,"watchers_count":15956,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5115,"mirror_url":null,"open_issues_count":1121,"forks":5115,"open_issues":1121,"watchers":15956,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/16986"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/16986"},"issue":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/16986"},"comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/16986/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/16986/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/16986/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/elasticsearch/statuses/a0191dff01d137c9cdf039c233654859f9f4b575"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":10,"deletions":2,"changed_files":3}}