{"action":"closed","issue":{"url":"https://api.github.com/repos/torchbox/wagtail/issues/2124","repository_url":"https://api.github.com/repos/torchbox/wagtail","labels_url":"https://api.github.com/repos/torchbox/wagtail/issues/2124/labels{/name}","comments_url":"https://api.github.com/repos/torchbox/wagtail/issues/2124/comments","events_url":"https://api.github.com/repos/torchbox/wagtail/issues/2124/events","html_url":"https://github.com/torchbox/wagtail/issues/2124","id":127278317,"number":2124,"title":"Ditch django_compressor in favour of a Node-based bundling setup","user":{"login":"gasman","id":85097,"avatar_url":"https://avatars.githubusercontent.com/u/85097?v=3","gravatar_id":"","url":"https://api.github.com/users/gasman","html_url":"https://github.com/gasman","followers_url":"https://api.github.com/users/gasman/followers","following_url":"https://api.github.com/users/gasman/following{/other_user}","gists_url":"https://api.github.com/users/gasman/gists{/gist_id}","starred_url":"https://api.github.com/users/gasman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gasman/subscriptions","organizations_url":"https://api.github.com/users/gasman/orgs","repos_url":"https://api.github.com/users/gasman/repos","events_url":"https://api.github.com/users/gasman/events{/privacy}","received_events_url":"https://api.github.com/users/gasman/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"kaedroho","id":1093808,"avatar_url":"https://avatars.githubusercontent.com/u/1093808?v=3","gravatar_id":"","url":"https://api.github.com/users/kaedroho","html_url":"https://github.com/kaedroho","followers_url":"https://api.github.com/users/kaedroho/followers","following_url":"https://api.github.com/users/kaedroho/following{/other_user}","gists_url":"https://api.github.com/users/kaedroho/gists{/gist_id}","starred_url":"https://api.github.com/users/kaedroho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaedroho/subscriptions","organizations_url":"https://api.github.com/users/kaedroho/orgs","repos_url":"https://api.github.com/users/kaedroho/repos","events_url":"https://api.github.com/users/kaedroho/events{/privacy}","received_events_url":"https://api.github.com/users/kaedroho/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/torchbox/wagtail/milestones/20","html_url":"https://github.com/torchbox/wagtail/milestones/1.4","labels_url":"https://api.github.com/repos/torchbox/wagtail/milestones/20/labels","id":1439641,"number":20,"title":"1.4","description":"","creator":{"login":"gasman","id":85097,"avatar_url":"https://avatars.githubusercontent.com/u/85097?v=3","gravatar_id":"","url":"https://api.github.com/users/gasman","html_url":"https://github.com/gasman","followers_url":"https://api.github.com/users/gasman/followers","following_url":"https://api.github.com/users/gasman/following{/other_user}","gists_url":"https://api.github.com/users/gasman/gists{/gist_id}","starred_url":"https://api.github.com/users/gasman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gasman/subscriptions","organizations_url":"https://api.github.com/users/gasman/orgs","repos_url":"https://api.github.com/users/gasman/repos","events_url":"https://api.github.com/users/gasman/events{/privacy}","received_events_url":"https://api.github.com/users/gasman/received_events","type":"User","site_admin":false},"open_issues":88,"closed_issues":52,"state":"open","created_at":"2015-12-02T14:10:53Z","updated_at":"2016-02-11T19:20:19Z","due_on":"2016-02-29T00:00:00Z","closed_at":null},"comments":4,"created_at":"2016-01-18T17:47:47Z","updated_at":"2016-02-11T19:20:19Z","closed_at":"2016-02-11T19:20:19Z","body":"As of version 2.0, django_compressor now depends on the packages `rjsmin` and `rcssmin`, which include native extensions and are thus non-trivial to install on Windows (see https://groups.google.com/d/msg/wagtail/-CDQcHk5F9M/aL_DbhjdCQAJ). Additionally, there have been reports of bugs in rjsmin's compression (specifically, SimpleMDE uses the regex `/^ *-+:*$/` which rjsmin incorrectly compresses to `/^*-+:*$/`), and our current django_compressor setup doesn't allow specific addons/apps using the `insert_editor_js` hook to opt out of compression. Finally, it's an extra thing that end users of Wagtail need to configure (or at least, be aware of) when deploying.\r\n\r\nThe main reason for using django_compressor (SASS compilation) has already been superseded by our Node toolchain, and minification/bundling is something else that could certainly be done just as well (or better) through Node. The one thing we'd lose would be the dynamic 'discovery' of bundled assets based on `{% compress %}` tags - and thus the ability for third-party modules to insert themselves into those bundles via `insert_editor_js` - but it's probably a good thing for maintainability for our bundles to be defined statically in a gulp config (or similar), and for third-party modules to deal with minification themselves if they consider it important."}}