{"action":"created","comment":{"url":"https://api.github.com/repos/arrayfire/arrayfire/pulls/comments/86328801","pull_request_review_id":6989950,"id":86328801,"diff_hunk":"@@ -366,6 +424,24 @@ forge::VectorField* ForgeManager::getVectorField(forge::Chart* chart, int nPoint\n     return mVcfMap[keypair];\n }\n \n+bool ForgeManager::getChartAxesOverride(forge::Chart* chart)\n+{\n+    ChartAxesOverrideIter iter = mChartAxesOverrideMap.find(chart);\n+    if (iter == mChartAxesOverrideMap.end()) {\n+        AF_ERROR(\"Chart Not Found!\", AF_ERR_ARG);","path":"src/api/c/graphics_common.cpp","position":102,"original_position":102,"commit_id":"cbc2b3bbd86930697f5464d5db1099a17b76fc33","original_commit_id":"cbc2b3bbd86930697f5464d5db1099a17b76fc33","user":{"login":"9prady9","id":3270458,"avatar_url":"https://avatars.githubusercontent.com/u/3270458?v=3","gravatar_id":"","url":"https://api.github.com/users/9prady9","html_url":"https://github.com/9prady9","followers_url":"https://api.github.com/users/9prady9/followers","following_url":"https://api.github.com/users/9prady9/following{/other_user}","gists_url":"https://api.github.com/users/9prady9/gists{/gist_id}","starred_url":"https://api.github.com/users/9prady9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9prady9/subscriptions","organizations_url":"https://api.github.com/users/9prady9/orgs","repos_url":"https://api.github.com/users/9prady9/repos","events_url":"https://api.github.com/users/9prady9/events{/privacy}","received_events_url":"https://api.github.com/users/9prady9/received_events","type":"User","site_admin":false},"body":"Isn't this error code reserved for API level arguments ? Charts are not exposed to user and the current callee is also not exposed externally. Therefore, i think it should be `AF_ERR_INTERNAL`. The string message can leave more clues if needed.","created_at":"2016-11-03T12:05:09Z","updated_at":"2016-11-03T12:05:09Z","html_url":"https://github.com/arrayfire/arrayfire/pull/1639#discussion_r86328801","pull_request_url":"https://api.github.com/repos/arrayfire/arrayfire/pulls/1639","_links":{"self":{"href":"https://api.github.com/repos/arrayfire/arrayfire/pulls/comments/86328801"},"html":{"href":"https://github.com/arrayfire/arrayfire/pull/1639#discussion_r86328801"},"pull_request":{"href":"https://api.github.com/repos/arrayfire/arrayfire/pulls/1639"}}},"pull_request":{"url":"https://api.github.com/repos/arrayfire/arrayfire/pulls/1639","id":91994421,"html_url":"https://github.com/arrayfire/arrayfire/pull/1639","diff_url":"https://github.com/arrayfire/arrayfire/pull/1639.diff","patch_url":"https://github.com/arrayfire/arrayfire/pull/1639.patch","issue_url":"https://api.github.com/repos/arrayfire/arrayfire/issues/1639","number":1639,"state":"open","locked":false,"title":"Revert to setting chart axes limits automatically","user":{"login":"shehzan10","id":2288659,"avatar_url":"https://avatars.githubusercontent.com/u/2288659?v=3","gravatar_id":"","url":"https://api.github.com/users/shehzan10","html_url":"https://github.com/shehzan10","followers_url":"https://api.github.com/users/shehzan10/followers","following_url":"https://api.github.com/users/shehzan10/following{/other_user}","gists_url":"https://api.github.com/users/shehzan10/gists{/gist_id}","starred_url":"https://api.github.com/users/shehzan10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shehzan10/subscriptions","organizations_url":"https://api.github.com/users/shehzan10/orgs","repos_url":"https://api.github.com/users/shehzan10/repos","events_url":"https://api.github.com/users/shehzan10/events{/privacy}","received_events_url":"https://api.github.com/users/shehzan10/received_events","type":"User","site_admin":false},"body":"* The axes limits will always be the minimum/maximum of the current and new limit.\r\n* The user can still set limits from API calls\r\n  * If the user sets a limit from the API call, then the automatic limit setting will be disabled.\r\n* This PR requires https://github.com/arrayfire/forge/pull/120\r\n\r\nTODO:\r\nUpdate the forge build tag to a version once the version tag is created in Forge.\r\n\r\n[skip arrayfire ci]","created_at":"2016-11-02T15:34:51Z","updated_at":"2016-11-03T12:07:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"93e59193a2044027d3a4bb12fbe28982189526ec","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/arrayfire/arrayfire/milestones/19","html_url":"https://github.com/arrayfire/arrayfire/milestones/v3.4.2","labels_url":"https://api.github.com/repos/arrayfire/arrayfire/milestones/19/labels","id":2065119,"number":19,"title":"v3.4.2","description":"","creator":{"login":"shehzan10","id":2288659,"avatar_url":"https://avatars.githubusercontent.com/u/2288659?v=3","gravatar_id":"","url":"https://api.github.com/users/shehzan10","html_url":"https://github.com/shehzan10","followers_url":"https://api.github.com/users/shehzan10/followers","following_url":"https://api.github.com/users/shehzan10/following{/other_user}","gists_url":"https://api.github.com/users/shehzan10/gists{/gist_id}","starred_url":"https://api.github.com/users/shehzan10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shehzan10/subscriptions","organizations_url":"https://api.github.com/users/shehzan10/orgs","repos_url":"https://api.github.com/users/shehzan10/repos","events_url":"https://api.github.com/users/shehzan10/events{/privacy}","received_events_url":"https://api.github.com/users/shehzan10/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":4,"state":"open","created_at":"2016-10-12T14:48:18Z","updated_at":"2016-11-02T15:35:06Z","due_on":"2016-11-07T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/arrayfire/arrayfire/pulls/1639/commits","review_comments_url":"https://api.github.com/repos/arrayfire/arrayfire/pulls/1639/comments","review_comment_url":"https://api.github.com/repos/arrayfire/arrayfire/pulls/comments{/number}","comments_url":"https://api.github.com/repos/arrayfire/arrayfire/issues/1639/comments","statuses_url":"https://api.github.com/repos/arrayfire/arrayfire/statuses/cbc2b3bbd86930697f5464d5db1099a17b76fc33","head":{"label":"shehzan10:axes-limits-auto","ref":"axes-limits-auto","sha":"cbc2b3bbd86930697f5464d5db1099a17b76fc33","user":{"login":"shehzan10","id":2288659,"avatar_url":"https://avatars.githubusercontent.com/u/2288659?v=3","gravatar_id":"","url":"https://api.github.com/users/shehzan10","html_url":"https://github.com/shehzan10","followers_url":"https://api.github.com/users/shehzan10/followers","following_url":"https://api.github.com/users/shehzan10/following{/other_user}","gists_url":"https://api.github.com/users/shehzan10/gists{/gist_id}","starred_url":"https://api.github.com/users/shehzan10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shehzan10/subscriptions","organizations_url":"https://api.github.com/users/shehzan10/orgs","repos_url":"https://api.github.com/users/shehzan10/repos","events_url":"https://api.github.com/users/shehzan10/events{/privacy}","received_events_url":"https://api.github.com/users/shehzan10/received_events","type":"User","site_admin":false},"repo":{"id":26550179,"name":"arrayfire","full_name":"shehzan10/arrayfire","owner":{"login":"shehzan10","id":2288659,"avatar_url":"https://avatars.githubusercontent.com/u/2288659?v=3","gravatar_id":"","url":"https://api.github.com/users/shehzan10","html_url":"https://github.com/shehzan10","followers_url":"https://api.github.com/users/shehzan10/followers","following_url":"https://api.github.com/users/shehzan10/following{/other_user}","gists_url":"https://api.github.com/users/shehzan10/gists{/gist_id}","starred_url":"https://api.github.com/users/shehzan10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shehzan10/subscriptions","organizations_url":"https://api.github.com/users/shehzan10/orgs","repos_url":"https://api.github.com/users/shehzan10/repos","events_url":"https://api.github.com/users/shehzan10/events{/privacy}","received_events_url":"https://api.github.com/users/shehzan10/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shehzan10/arrayfire","description":"The ArrayFire library","fork":true,"url":"https://api.github.com/repos/shehzan10/arrayfire","forks_url":"https://api.github.com/repos/shehzan10/arrayfire/forks","keys_url":"https://api.github.com/repos/shehzan10/arrayfire/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shehzan10/arrayfire/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shehzan10/arrayfire/teams","hooks_url":"https://api.github.com/repos/shehzan10/arrayfire/hooks","issue_events_url":"https://api.github.com/repos/shehzan10/arrayfire/issues/events{/number}","events_url":"https://api.github.com/repos/shehzan10/arrayfire/events","assignees_url":"https://api.github.com/repos/shehzan10/arrayfire/assignees{/user}","branches_url":"https://api.github.com/repos/shehzan10/arrayfire/branches{/branch}","tags_url":"https://api.github.com/repos/shehzan10/arrayfire/tags","blobs_url":"https://api.github.com/repos/shehzan10/arrayfire/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shehzan10/arrayfire/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shehzan10/arrayfire/git/refs{/sha}","trees_url":"https://api.github.com/repos/shehzan10/arrayfire/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shehzan10/arrayfire/statuses/{sha}","languages_url":"https://api.github.com/repos/shehzan10/arrayfire/languages","stargazers_url":"https://api.github.com/repos/shehzan10/arrayfire/stargazers","contributors_url":"https://api.github.com/repos/shehzan10/arrayfire/contributors","subscribers_url":"https://api.github.com/repos/shehzan10/arrayfire/subscribers","subscription_url":"https://api.github.com/repos/shehzan10/arrayfire/subscription","commits_url":"https://api.github.com/repos/shehzan10/arrayfire/commits{/sha}","git_commits_url":"https://api.github.com/repos/shehzan10/arrayfire/git/commits{/sha}","comments_url":"https://api.github.com/repos/shehzan10/arrayfire/comments{/number}","issue_comment_url":"https://api.github.com/repos/shehzan10/arrayfire/issues/comments{/number}","contents_url":"https://api.github.com/repos/shehzan10/arrayfire/contents/{+path}","compare_url":"https://api.github.com/repos/shehzan10/arrayfire/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shehzan10/arrayfire/merges","archive_url":"https://api.github.com/repos/shehzan10/arrayfire/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shehzan10/arrayfire/downloads","issues_url":"https://api.github.com/repos/shehzan10/arrayfire/issues{/number}","pulls_url":"https://api.github.com/repos/shehzan10/arrayfire/pulls{/number}","milestones_url":"https://api.github.com/repos/shehzan10/arrayfire/milestones{/number}","notifications_url":"https://api.github.com/repos/shehzan10/arrayfire/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shehzan10/arrayfire/labels{/name}","releases_url":"https://api.github.com/repos/shehzan10/arrayfire/releases{/id}","deployments_url":"https://api.github.com/repos/shehzan10/arrayfire/deployments","created_at":"2014-11-12T18:34:01Z","updated_at":"2016-01-14T22:20:40Z","pushed_at":"2016-11-02T15:29:58Z","git_url":"git://github.com/shehzan10/arrayfire.git","ssh_url":"git@github.com:shehzan10/arrayfire.git","clone_url":"https://github.com/shehzan10/arrayfire.git","svn_url":"https://github.com/shehzan10/arrayfire","homepage":null,"size":9644,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"arrayfire:hotfix-3.4.2","ref":"hotfix-3.4.2","sha":"de9ba333534a4b3a7cd98865dac9115790528874","user":{"login":"arrayfire","id":5395442,"avatar_url":"https://avatars.githubusercontent.com/u/5395442?v=3","gravatar_id":"","url":"https://api.github.com/users/arrayfire","html_url":"https://github.com/arrayfire","followers_url":"https://api.github.com/users/arrayfire/followers","following_url":"https://api.github.com/users/arrayfire/following{/other_user}","gists_url":"https://api.github.com/users/arrayfire/gists{/gist_id}","starred_url":"https://api.github.com/users/arrayfire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arrayfire/subscriptions","organizations_url":"https://api.github.com/users/arrayfire/orgs","repos_url":"https://api.github.com/users/arrayfire/repos","events_url":"https://api.github.com/users/arrayfire/events{/privacy}","received_events_url":"https://api.github.com/users/arrayfire/received_events","type":"Organization","site_admin":false},"repo":{"id":25889802,"name":"arrayfire","full_name":"arrayfire/arrayfire","owner":{"login":"arrayfire","id":5395442,"avatar_url":"https://avatars.githubusercontent.com/u/5395442?v=3","gravatar_id":"","url":"https://api.github.com/users/arrayfire","html_url":"https://github.com/arrayfire","followers_url":"https://api.github.com/users/arrayfire/followers","following_url":"https://api.github.com/users/arrayfire/following{/other_user}","gists_url":"https://api.github.com/users/arrayfire/gists{/gist_id}","starred_url":"https://api.github.com/users/arrayfire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arrayfire/subscriptions","organizations_url":"https://api.github.com/users/arrayfire/orgs","repos_url":"https://api.github.com/users/arrayfire/repos","events_url":"https://api.github.com/users/arrayfire/events{/privacy}","received_events_url":"https://api.github.com/users/arrayfire/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/arrayfire/arrayfire","description":"ArrayFire: a general purpose GPU library.","fork":false,"url":"https://api.github.com/repos/arrayfire/arrayfire","forks_url":"https://api.github.com/repos/arrayfire/arrayfire/forks","keys_url":"https://api.github.com/repos/arrayfire/arrayfire/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arrayfire/arrayfire/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arrayfire/arrayfire/teams","hooks_url":"https://api.github.com/repos/arrayfire/arrayfire/hooks","issue_events_url":"https://api.github.com/repos/arrayfire/arrayfire/issues/events{/number}","events_url":"https://api.github.com/repos/arrayfire/arrayfire/events","assignees_url":"https://api.github.com/repos/arrayfire/arrayfire/assignees{/user}","branches_url":"https://api.github.com/repos/arrayfire/arrayfire/branches{/branch}","tags_url":"https://api.github.com/repos/arrayfire/arrayfire/tags","blobs_url":"https://api.github.com/repos/arrayfire/arrayfire/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arrayfire/arrayfire/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arrayfire/arrayfire/git/refs{/sha}","trees_url":"https://api.github.com/repos/arrayfire/arrayfire/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arrayfire/arrayfire/statuses/{sha}","languages_url":"https://api.github.com/repos/arrayfire/arrayfire/languages","stargazers_url":"https://api.github.com/repos/arrayfire/arrayfire/stargazers","contributors_url":"https://api.github.com/repos/arrayfire/arrayfire/contributors","subscribers_url":"https://api.github.com/repos/arrayfire/arrayfire/subscribers","subscription_url":"https://api.github.com/repos/arrayfire/arrayfire/subscription","commits_url":"https://api.github.com/repos/arrayfire/arrayfire/commits{/sha}","git_commits_url":"https://api.github.com/repos/arrayfire/arrayfire/git/commits{/sha}","comments_url":"https://api.github.com/repos/arrayfire/arrayfire/comments{/number}","issue_comment_url":"https://api.github.com/repos/arrayfire/arrayfire/issues/comments{/number}","contents_url":"https://api.github.com/repos/arrayfire/arrayfire/contents/{+path}","compare_url":"https://api.github.com/repos/arrayfire/arrayfire/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arrayfire/arrayfire/merges","archive_url":"https://api.github.com/repos/arrayfire/arrayfire/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arrayfire/arrayfire/downloads","issues_url":"https://api.github.com/repos/arrayfire/arrayfire/issues{/number}","pulls_url":"https://api.github.com/repos/arrayfire/arrayfire/pulls{/number}","milestones_url":"https://api.github.com/repos/arrayfire/arrayfire/milestones{/number}","notifications_url":"https://api.github.com/repos/arrayfire/arrayfire/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arrayfire/arrayfire/labels{/name}","releases_url":"https://api.github.com/repos/arrayfire/arrayfire/releases{/id}","deployments_url":"https://api.github.com/repos/arrayfire/arrayfire/deployments","created_at":"2014-10-28T20:58:33Z","updated_at":"2016-11-03T07:15:35Z","pushed_at":"2016-11-02T15:34:51Z","git_url":"git://github.com/arrayfire/arrayfire.git","ssh_url":"git@github.com:arrayfire/arrayfire.git","clone_url":"https://github.com/arrayfire/arrayfire.git","svn_url":"https://github.com/arrayfire/arrayfire","homepage":"https://arrayfire.com","size":14033,"stargazers_count":1474,"watchers_count":1474,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":227,"mirror_url":null,"open_issues_count":134,"forks":227,"open_issues":134,"watchers":1474,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/arrayfire/arrayfire/pulls/1639"},"html":{"href":"https://github.com/arrayfire/arrayfire/pull/1639"},"issue":{"href":"https://api.github.com/repos/arrayfire/arrayfire/issues/1639"},"comments":{"href":"https://api.github.com/repos/arrayfire/arrayfire/issues/1639/comments"},"review_comments":{"href":"https://api.github.com/repos/arrayfire/arrayfire/pulls/1639/comments"},"review_comment":{"href":"https://api.github.com/repos/arrayfire/arrayfire/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/arrayfire/arrayfire/pulls/1639/commits"},"statuses":{"href":"https://api.github.com/repos/arrayfire/arrayfire/statuses/cbc2b3bbd86930697f5464d5db1099a17b76fc33"}}}}
{"actor":{"display_login":"9prady9"}}