{"action":"closed","number":1746,"pull_request":{"url":"https://api.github.com/repos/nunit/nunit/pulls/1746","id":81288425,"html_url":"https://github.com/nunit/nunit/pull/1746","diff_url":"https://github.com/nunit/nunit/pull/1746.diff","patch_url":"https://github.com/nunit/nunit/pull/1746.patch","issue_url":"https://api.github.com/repos/nunit/nunit/issues/1746","number":1746,"state":"closed","locked":false,"title":"Attributes with description constructors","user":{"login":"asbjornu","id":12283,"avatar_url":"https://avatars.githubusercontent.com/u/12283?v=3","gravatar_id":"","url":"https://api.github.com/users/asbjornu","html_url":"https://github.com/asbjornu","followers_url":"https://api.github.com/users/asbjornu/followers","following_url":"https://api.github.com/users/asbjornu/following{/other_user}","gists_url":"https://api.github.com/users/asbjornu/gists{/gist_id}","starred_url":"https://api.github.com/users/asbjornu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asbjornu/subscriptions","organizations_url":"https://api.github.com/users/asbjornu/orgs","repos_url":"https://api.github.com/users/asbjornu/repos","events_url":"https://api.github.com/users/asbjornu/events{/privacy}","received_events_url":"https://api.github.com/users/asbjornu/received_events","type":"User","site_admin":false},"body":"It has annoyed me to no end that the `Description` on `TestFixtureAttribute` and `TestAttribute` don't have a corresponding constructor argument, meaning I always have to prefix descriptions for these two attributes with `Description = `. Seeing how the `DescriptionAttribute` and in some ways `CategoryAttribute` have the convenient constructors, I would love it if `TestAttribute` and `TestFixtureAttribute` could have them added as well.\r\n\r\nIt's not all sunshine and roses, though. Adding a `.ctor(string description)` to `TestFixtureAttribute` makes it collide with the `.ctor(params object[] arguments)` in cases where the latter is used with only one string parameter as such: `[TestFixture(\"First param argument\")]`. I would still argue that having the constructor taking `description` is so useful that we should do something about it, and this PR provides what I hope are the grounds to discuss exactly **what** can be done.\r\n\r\n@nunit/core-team Thoughts?","created_at":"2016-08-15T09:22:18Z","updated_at":"2016-08-15T22:52:19Z","closed_at":"2016-08-15T22:52:19Z","merged_at":null,"merge_commit_sha":"f84485f247f03dd8c551265d6ea81f87fd78938d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nunit/nunit/pulls/1746/commits","review_comments_url":"https://api.github.com/repos/nunit/nunit/pulls/1746/comments","review_comment_url":"https://api.github.com/repos/nunit/nunit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nunit/nunit/issues/1746/comments","statuses_url":"https://api.github.com/repos/nunit/nunit/statuses/efc63baec3d0316f0fd3126577f27a3a7a2706a9","head":{"label":"asbjornu:feature/attribute-description","ref":"feature/attribute-description","sha":"efc63baec3d0316f0fd3126577f27a3a7a2706a9","user":{"login":"asbjornu","id":12283,"avatar_url":"https://avatars.githubusercontent.com/u/12283?v=3","gravatar_id":"","url":"https://api.github.com/users/asbjornu","html_url":"https://github.com/asbjornu","followers_url":"https://api.github.com/users/asbjornu/followers","following_url":"https://api.github.com/users/asbjornu/following{/other_user}","gists_url":"https://api.github.com/users/asbjornu/gists{/gist_id}","starred_url":"https://api.github.com/users/asbjornu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asbjornu/subscriptions","organizations_url":"https://api.github.com/users/asbjornu/orgs","repos_url":"https://api.github.com/users/asbjornu/repos","events_url":"https://api.github.com/users/asbjornu/events{/privacy}","received_events_url":"https://api.github.com/users/asbjornu/received_events","type":"User","site_admin":false},"repo":{"id":61022734,"name":"nunit","full_name":"asbjornu/nunit","owner":{"login":"asbjornu","id":12283,"avatar_url":"https://avatars.githubusercontent.com/u/12283?v=3","gravatar_id":"","url":"https://api.github.com/users/asbjornu","html_url":"https://github.com/asbjornu","followers_url":"https://api.github.com/users/asbjornu/followers","following_url":"https://api.github.com/users/asbjornu/following{/other_user}","gists_url":"https://api.github.com/users/asbjornu/gists{/gist_id}","starred_url":"https://api.github.com/users/asbjornu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asbjornu/subscriptions","organizations_url":"https://api.github.com/users/asbjornu/orgs","repos_url":"https://api.github.com/users/asbjornu/repos","events_url":"https://api.github.com/users/asbjornu/events{/privacy}","received_events_url":"https://api.github.com/users/asbjornu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/asbjornu/nunit","description":"NUnit 3.0 framework, engine and console runner","fork":true,"url":"https://api.github.com/repos/asbjornu/nunit","forks_url":"https://api.github.com/repos/asbjornu/nunit/forks","keys_url":"https://api.github.com/repos/asbjornu/nunit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asbjornu/nunit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asbjornu/nunit/teams","hooks_url":"https://api.github.com/repos/asbjornu/nunit/hooks","issue_events_url":"https://api.github.com/repos/asbjornu/nunit/issues/events{/number}","events_url":"https://api.github.com/repos/asbjornu/nunit/events","assignees_url":"https://api.github.com/repos/asbjornu/nunit/assignees{/user}","branches_url":"https://api.github.com/repos/asbjornu/nunit/branches{/branch}","tags_url":"https://api.github.com/repos/asbjornu/nunit/tags","blobs_url":"https://api.github.com/repos/asbjornu/nunit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asbjornu/nunit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asbjornu/nunit/git/refs{/sha}","trees_url":"https://api.github.com/repos/asbjornu/nunit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asbjornu/nunit/statuses/{sha}","languages_url":"https://api.github.com/repos/asbjornu/nunit/languages","stargazers_url":"https://api.github.com/repos/asbjornu/nunit/stargazers","contributors_url":"https://api.github.com/repos/asbjornu/nunit/contributors","subscribers_url":"https://api.github.com/repos/asbjornu/nunit/subscribers","subscription_url":"https://api.github.com/repos/asbjornu/nunit/subscription","commits_url":"https://api.github.com/repos/asbjornu/nunit/commits{/sha}","git_commits_url":"https://api.github.com/repos/asbjornu/nunit/git/commits{/sha}","comments_url":"https://api.github.com/repos/asbjornu/nunit/comments{/number}","issue_comment_url":"https://api.github.com/repos/asbjornu/nunit/issues/comments{/number}","contents_url":"https://api.github.com/repos/asbjornu/nunit/contents/{+path}","compare_url":"https://api.github.com/repos/asbjornu/nunit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asbjornu/nunit/merges","archive_url":"https://api.github.com/repos/asbjornu/nunit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asbjornu/nunit/downloads","issues_url":"https://api.github.com/repos/asbjornu/nunit/issues{/number}","pulls_url":"https://api.github.com/repos/asbjornu/nunit/pulls{/number}","milestones_url":"https://api.github.com/repos/asbjornu/nunit/milestones{/number}","notifications_url":"https://api.github.com/repos/asbjornu/nunit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asbjornu/nunit/labels{/name}","releases_url":"https://api.github.com/repos/asbjornu/nunit/releases{/id}","deployments_url":"https://api.github.com/repos/asbjornu/nunit/deployments","created_at":"2016-06-13T09:01:31Z","updated_at":"2016-06-13T09:01:35Z","pushed_at":"2016-08-15T09:45:44Z","git_url":"git://github.com/asbjornu/nunit.git","ssh_url":"git@github.com:asbjornu/nunit.git","clone_url":"https://github.com/asbjornu/nunit.git","svn_url":"https://github.com/asbjornu/nunit","homepage":"http://www.nunit.org/","size":31163,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nunit:master","ref":"master","sha":"38a93ab5f1cb36df2b3c137b69e3f48c78d18147","user":{"login":"nunit","id":2678858,"avatar_url":"https://avatars.githubusercontent.com/u/2678858?v=3","gravatar_id":"","url":"https://api.github.com/users/nunit","html_url":"https://github.com/nunit","followers_url":"https://api.github.com/users/nunit/followers","following_url":"https://api.github.com/users/nunit/following{/other_user}","gists_url":"https://api.github.com/users/nunit/gists{/gist_id}","starred_url":"https://api.github.com/users/nunit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nunit/subscriptions","organizations_url":"https://api.github.com/users/nunit/orgs","repos_url":"https://api.github.com/users/nunit/repos","events_url":"https://api.github.com/users/nunit/events{/privacy}","received_events_url":"https://api.github.com/users/nunit/received_events","type":"Organization","site_admin":false},"repo":{"id":13692183,"name":"nunit","full_name":"nunit/nunit","owner":{"login":"nunit","id":2678858,"avatar_url":"https://avatars.githubusercontent.com/u/2678858?v=3","gravatar_id":"","url":"https://api.github.com/users/nunit","html_url":"https://github.com/nunit","followers_url":"https://api.github.com/users/nunit/followers","following_url":"https://api.github.com/users/nunit/following{/other_user}","gists_url":"https://api.github.com/users/nunit/gists{/gist_id}","starred_url":"https://api.github.com/users/nunit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nunit/subscriptions","organizations_url":"https://api.github.com/users/nunit/orgs","repos_url":"https://api.github.com/users/nunit/repos","events_url":"https://api.github.com/users/nunit/events{/privacy}","received_events_url":"https://api.github.com/users/nunit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nunit/nunit","description":"NUnit 3.0 framework, engine and console runner","fork":false,"url":"https://api.github.com/repos/nunit/nunit","forks_url":"https://api.github.com/repos/nunit/nunit/forks","keys_url":"https://api.github.com/repos/nunit/nunit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nunit/nunit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nunit/nunit/teams","hooks_url":"https://api.github.com/repos/nunit/nunit/hooks","issue_events_url":"https://api.github.com/repos/nunit/nunit/issues/events{/number}","events_url":"https://api.github.com/repos/nunit/nunit/events","assignees_url":"https://api.github.com/repos/nunit/nunit/assignees{/user}","branches_url":"https://api.github.com/repos/nunit/nunit/branches{/branch}","tags_url":"https://api.github.com/repos/nunit/nunit/tags","blobs_url":"https://api.github.com/repos/nunit/nunit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nunit/nunit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nunit/nunit/git/refs{/sha}","trees_url":"https://api.github.com/repos/nunit/nunit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nunit/nunit/statuses/{sha}","languages_url":"https://api.github.com/repos/nunit/nunit/languages","stargazers_url":"https://api.github.com/repos/nunit/nunit/stargazers","contributors_url":"https://api.github.com/repos/nunit/nunit/contributors","subscribers_url":"https://api.github.com/repos/nunit/nunit/subscribers","subscription_url":"https://api.github.com/repos/nunit/nunit/subscription","commits_url":"https://api.github.com/repos/nunit/nunit/commits{/sha}","git_commits_url":"https://api.github.com/repos/nunit/nunit/git/commits{/sha}","comments_url":"https://api.github.com/repos/nunit/nunit/comments{/number}","issue_comment_url":"https://api.github.com/repos/nunit/nunit/issues/comments{/number}","contents_url":"https://api.github.com/repos/nunit/nunit/contents/{+path}","compare_url":"https://api.github.com/repos/nunit/nunit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nunit/nunit/merges","archive_url":"https://api.github.com/repos/nunit/nunit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nunit/nunit/downloads","issues_url":"https://api.github.com/repos/nunit/nunit/issues{/number}","pulls_url":"https://api.github.com/repos/nunit/nunit/pulls{/number}","milestones_url":"https://api.github.com/repos/nunit/nunit/milestones{/number}","notifications_url":"https://api.github.com/repos/nunit/nunit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nunit/nunit/labels{/name}","releases_url":"https://api.github.com/repos/nunit/nunit/releases{/id}","deployments_url":"https://api.github.com/repos/nunit/nunit/deployments","created_at":"2013-10-18T23:43:29Z","updated_at":"2016-08-13T17:02:47Z","pushed_at":"2016-08-15T22:07:11Z","git_url":"git://github.com/nunit/nunit.git","ssh_url":"git@github.com:nunit/nunit.git","clone_url":"https://github.com/nunit/nunit.git","svn_url":"https://github.com/nunit/nunit","homepage":"http://www.nunit.org/","size":38157,"stargazers_count":711,"watchers_count":711,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":278,"mirror_url":null,"open_issues_count":216,"forks":278,"open_issues":216,"watchers":711,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nunit/nunit/pulls/1746"},"html":{"href":"https://github.com/nunit/nunit/pull/1746"},"issue":{"href":"https://api.github.com/repos/nunit/nunit/issues/1746"},"comments":{"href":"https://api.github.com/repos/nunit/nunit/issues/1746/comments"},"review_comments":{"href":"https://api.github.com/repos/nunit/nunit/pulls/1746/comments"},"review_comment":{"href":"https://api.github.com/repos/nunit/nunit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nunit/nunit/pulls/1746/commits"},"statuses":{"href":"https://api.github.com/repos/nunit/nunit/statuses/efc63baec3d0316f0fd3126577f27a3a7a2706a9"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":5,"review_comments":0,"commits":4,"additions":25,"deletions":5,"changed_files":4}}
{"actor":{"display_login":"CharliePoole"}}