{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/58376824","id":58376824,"diff_hunk":"@@ -126,6 +129,13 @@ public SetupWizard(Jenkins j) throws IOException, InterruptedException {\n         } catch (ServletException e) {\n             throw new AssertionError(e);\n         }\n+        \n+        try {\n+            // Make sure plugin metadata is up to date\n+            UpdateCenter.updateDefaultSite();\n+        } catch (Exception e) {","path":"core/src/main/java/jenkins/install/SetupWizard.java","position":41,"original_position":41,"commit_id":"fcc547e846baeced4f5e7073e9c34d0138185e6e","original_commit_id":"fcc547e846baeced4f5e7073e9c34d0138185e6e","user":{"login":"jglick","id":154109,"avatar_url":"https://avatars.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"body":":ant: Huh? That method is already `catch`ing `Exception` and logging it.","created_at":"2016-04-04T13:43:56Z","updated_at":"2016-04-04T13:43:56Z","html_url":"https://github.com/jenkinsci/jenkins/pull/2185#discussion_r58376824","pull_request_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2185","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/58376824"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/2185#discussion_r58376824"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2185"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2185","id":64396446,"html_url":"https://github.com/jenkinsci/jenkins/pull/2185","diff_url":"https://github.com/jenkinsci/jenkins/pull/2185.diff","patch_url":"https://github.com/jenkinsci/jenkins/pull/2185.patch","issue_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/2185","number":2185,"state":"open","locked":false,"title":"[JENKINS-33800] - fileNotFound exception / more accurately determine if this is an upgrade","user":{"login":"kzantow","id":3009477,"avatar_url":"https://avatars.githubusercontent.com/u/3009477?v=3","gravatar_id":"","url":"https://api.github.com/users/kzantow","html_url":"https://github.com/kzantow","followers_url":"https://api.github.com/users/kzantow/followers","following_url":"https://api.github.com/users/kzantow/following{/other_user}","gists_url":"https://api.github.com/users/kzantow/gists{/gist_id}","starred_url":"https://api.github.com/users/kzantow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kzantow/subscriptions","organizations_url":"https://api.github.com/users/kzantow/orgs","repos_url":"https://api.github.com/users/kzantow/repos","events_url":"https://api.github.com/users/kzantow/events{/privacy}","received_events_url":"https://api.github.com/users/kzantow/received_events","type":"User","site_admin":false},"body":"If the Jenkins 1 global settings are never saved and no jobs were created, the setup wizard may treat this case as a new installation. In the case the security config is saved, this causes an issue - this more \"accurately\" determines if this instance is actually an upgrade vs. a new install and prevents a fileNotFound exception looking for the setup token.\r\n\r\nThis addresses issue: https://issues.jenkins-ci.org/browse/JENKINS-33800\r\n\r\n@reviewbybees","created_at":"2016-03-29T00:19:20Z","updated_at":"2016-04-04T13:43:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"407cebc522f42cb595b8dfe5d864576dfe17538b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2185/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2185/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/2185/comments","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/fcc547e846baeced4f5e7073e9c34d0138185e6e","head":{"label":"kzantow:JENKINS-33800-initial-password-file-not-found","ref":"JENKINS-33800-initial-password-file-not-found","sha":"fcc547e846baeced4f5e7073e9c34d0138185e6e","user":{"login":"kzantow","id":3009477,"avatar_url":"https://avatars.githubusercontent.com/u/3009477?v=3","gravatar_id":"","url":"https://api.github.com/users/kzantow","html_url":"https://github.com/kzantow","followers_url":"https://api.github.com/users/kzantow/followers","following_url":"https://api.github.com/users/kzantow/following{/other_user}","gists_url":"https://api.github.com/users/kzantow/gists{/gist_id}","starred_url":"https://api.github.com/users/kzantow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kzantow/subscriptions","organizations_url":"https://api.github.com/users/kzantow/orgs","repos_url":"https://api.github.com/users/kzantow/repos","events_url":"https://api.github.com/users/kzantow/events{/privacy}","received_events_url":"https://api.github.com/users/kzantow/received_events","type":"User","site_admin":false},"repo":{"id":41372898,"name":"jenkins","full_name":"kzantow/jenkins","owner":{"login":"kzantow","id":3009477,"avatar_url":"https://avatars.githubusercontent.com/u/3009477?v=3","gravatar_id":"","url":"https://api.github.com/users/kzantow","html_url":"https://github.com/kzantow","followers_url":"https://api.github.com/users/kzantow/followers","following_url":"https://api.github.com/users/kzantow/following{/other_user}","gists_url":"https://api.github.com/users/kzantow/gists{/gist_id}","starred_url":"https://api.github.com/users/kzantow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kzantow/subscriptions","organizations_url":"https://api.github.com/users/kzantow/orgs","repos_url":"https://api.github.com/users/kzantow/repos","events_url":"https://api.github.com/users/kzantow/events{/privacy}","received_events_url":"https://api.github.com/users/kzantow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kzantow/jenkins","description":"Jenkins Continuous Integration Server","fork":true,"url":"https://api.github.com/repos/kzantow/jenkins","forks_url":"https://api.github.com/repos/kzantow/jenkins/forks","keys_url":"https://api.github.com/repos/kzantow/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kzantow/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kzantow/jenkins/teams","hooks_url":"https://api.github.com/repos/kzantow/jenkins/hooks","issue_events_url":"https://api.github.com/repos/kzantow/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/kzantow/jenkins/events","assignees_url":"https://api.github.com/repos/kzantow/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/kzantow/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/kzantow/jenkins/tags","blobs_url":"https://api.github.com/repos/kzantow/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kzantow/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kzantow/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/kzantow/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kzantow/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/kzantow/jenkins/languages","stargazers_url":"https://api.github.com/repos/kzantow/jenkins/stargazers","contributors_url":"https://api.github.com/repos/kzantow/jenkins/contributors","subscribers_url":"https://api.github.com/repos/kzantow/jenkins/subscribers","subscription_url":"https://api.github.com/repos/kzantow/jenkins/subscription","commits_url":"https://api.github.com/repos/kzantow/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/kzantow/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/kzantow/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/kzantow/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/kzantow/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/kzantow/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kzantow/jenkins/merges","archive_url":"https://api.github.com/repos/kzantow/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kzantow/jenkins/downloads","issues_url":"https://api.github.com/repos/kzantow/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/kzantow/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/kzantow/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/kzantow/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kzantow/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/kzantow/jenkins/releases{/id}","deployments_url":"https://api.github.com/repos/kzantow/jenkins/deployments","created_at":"2015-08-25T15:52:29Z","updated_at":"2015-08-25T15:52:51Z","pushed_at":"2016-04-01T17:25:53Z","git_url":"git://github.com/kzantow/jenkins.git","ssh_url":"git@github.com:kzantow/jenkins.git","clone_url":"https://github.com/kzantow/jenkins.git","svn_url":"https://github.com/kzantow/jenkins","homepage":"http://jenkins-ci.org/","size":93443,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:2.0","ref":"2.0","sha":"b633f883477af58be17b83e10c4d7325c2ed9e13","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":1103607,"name":"jenkins","full_name":"jenkinsci/jenkins","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/jenkins","description":"Jenkins Continuous Integration Server","fork":true,"url":"https://api.github.com/repos/jenkinsci/jenkins","forks_url":"https://api.github.com/repos/jenkinsci/jenkins/forks","keys_url":"https://api.github.com/repos/jenkinsci/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/jenkins/teams","hooks_url":"https://api.github.com/repos/jenkinsci/jenkins/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/jenkins/events","assignees_url":"https://api.github.com/repos/jenkinsci/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/jenkins/tags","blobs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/jenkins/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/jenkins/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/jenkins/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/jenkins/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/jenkins/subscription","commits_url":"https://api.github.com/repos/jenkinsci/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/jenkins/merges","archive_url":"https://api.github.com/repos/jenkinsci/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/jenkins/downloads","issues_url":"https://api.github.com/repos/jenkinsci/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/jenkins/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/jenkins/deployments","created_at":"2010-11-22T21:21:23Z","updated_at":"2016-04-04T13:32:03Z","pushed_at":"2016-04-04T11:28:12Z","git_url":"git://github.com/jenkinsci/jenkins.git","ssh_url":"git@github.com:jenkinsci/jenkins.git","clone_url":"https://github.com/jenkinsci/jenkins.git","svn_url":"https://github.com/jenkinsci/jenkins","homepage":"http://jenkins-ci.org/","size":99347,"stargazers_count":5493,"watchers_count":5493,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2422,"mirror_url":null,"open_issues_count":141,"forks":2422,"open_issues":141,"watchers":5493,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2185"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/2185"},"issue":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/2185"},"comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/2185/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2185/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2185/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/jenkins/statuses/fcc547e846baeced4f5e7073e9c34d0138185e6e"}}}}