{"action":"created","comment":{"url":"https://api.github.com/repos/hyperoslo/Spots/pulls/comments/78279239","id":78279239,"diff_hunk":"@@ -0,0 +1,171 @@\n+@testable import Spots\n+import Brick\n+import Foundation\n+import XCTest\n+\n+extension SpotsController {\n+\n+  func preloadView() {\n+    let _ = view\n+  }","path":"SpotsTests/iOS/TestSpotsScrollView.swift","position":10,"original_position":10,"commit_id":"13cf4efa391e0df46fc5dac627707382b61920b5","original_commit_id":"13cf4efa391e0df46fc5dac627707382b61920b5","user":{"login":"zenangst","id":57446,"avatar_url":"https://avatars.githubusercontent.com/u/57446?v=3","gravatar_id":"","url":"https://api.github.com/users/zenangst","html_url":"https://github.com/zenangst","followers_url":"https://api.github.com/users/zenangst/followers","following_url":"https://api.github.com/users/zenangst/following{/other_user}","gists_url":"https://api.github.com/users/zenangst/gists{/gist_id}","starred_url":"https://api.github.com/users/zenangst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenangst/subscriptions","organizations_url":"https://api.github.com/users/zenangst/orgs","repos_url":"https://api.github.com/users/zenangst/repos","events_url":"https://api.github.com/users/zenangst/events{/privacy}","received_events_url":"https://api.github.com/users/zenangst/received_events","type":"User","site_admin":false},"body":"This ended up kinda handy when testing view controllers.\r\nhttps://www.natashatherobot.com/ios-testing-view-controllers-swift/","created_at":"2016-09-10T15:54:34Z","updated_at":"2016-09-10T15:54:34Z","html_url":"https://github.com/hyperoslo/Spots/pull/294#discussion_r78279239","pull_request_url":"https://api.github.com/repos/hyperoslo/Spots/pulls/294","_links":{"self":{"href":"https://api.github.com/repos/hyperoslo/Spots/pulls/comments/78279239"},"html":{"href":"https://github.com/hyperoslo/Spots/pull/294#discussion_r78279239"},"pull_request":{"href":"https://api.github.com/repos/hyperoslo/Spots/pulls/294"}}},"pull_request":{"url":"https://api.github.com/repos/hyperoslo/Spots/pulls/294","id":84759293,"html_url":"https://github.com/hyperoslo/Spots/pull/294","diff_url":"https://github.com/hyperoslo/Spots/pull/294.diff","patch_url":"https://github.com/hyperoslo/Spots/pull/294.patch","issue_url":"https://api.github.com/repos/hyperoslo/Spots/issues/294","number":294,"state":"open","locked":false,"title":"Improve SpotsScrollView with tests","user":{"login":"zenangst","id":57446,"avatar_url":"https://avatars.githubusercontent.com/u/57446?v=3","gravatar_id":"","url":"https://api.github.com/users/zenangst","html_url":"https://github.com/zenangst","followers_url":"https://api.github.com/users/zenangst/followers","following_url":"https://api.github.com/users/zenangst/following{/other_user}","gists_url":"https://api.github.com/users/zenangst/gists{/gist_id}","starred_url":"https://api.github.com/users/zenangst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenangst/subscriptions","organizations_url":"https://api.github.com/users/zenangst/orgs","repos_url":"https://api.github.com/users/zenangst/repos","events_url":"https://api.github.com/users/zenangst/events{/privacy}","received_events_url":"https://api.github.com/users/zenangst/received_events","type":"User","site_admin":false},"body":"This PR adds test for the `SpotsScrollView` layout. The test is quiet big but if you analyze the test you get a deeper understand about how the internal scrolling in Spots really works.\r\n\r\nIt also removes some usage of `then` in the Spots. We aim to remove all dependencies on Sugar so it felt like a good idea to do.\r\nBut the reason I ended up removing it was that, `then` is only invoked if the lazy method is invoked. This was causing a crash because of that as the cell default cell was not registered on the UI component.\r\n\r\nSomething to think about when adding `lazy` methods with extended `then`-like loading mechanisms.\r\n\r\nOh, and for removing `Sugar`, this also removes the use of `isPresent`, the have been replaced by `!.isEmpty`.","created_at":"2016-09-10T15:52:10Z","updated_at":"2016-09-10T15:54:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2591c32939dc911739e826719aab5aae9a510861","assignee":{"login":"onmyway133","id":2284279,"avatar_url":"https://avatars.githubusercontent.com/u/2284279?v=3","gravatar_id":"","url":"https://api.github.com/users/onmyway133","html_url":"https://github.com/onmyway133","followers_url":"https://api.github.com/users/onmyway133/followers","following_url":"https://api.github.com/users/onmyway133/following{/other_user}","gists_url":"https://api.github.com/users/onmyway133/gists{/gist_id}","starred_url":"https://api.github.com/users/onmyway133/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onmyway133/subscriptions","organizations_url":"https://api.github.com/users/onmyway133/orgs","repos_url":"https://api.github.com/users/onmyway133/repos","events_url":"https://api.github.com/users/onmyway133/events{/privacy}","received_events_url":"https://api.github.com/users/onmyway133/received_events","type":"User","site_admin":false},"assignees":[{"login":"onmyway133","id":2284279,"avatar_url":"https://avatars.githubusercontent.com/u/2284279?v=3","gravatar_id":"","url":"https://api.github.com/users/onmyway133","html_url":"https://github.com/onmyway133","followers_url":"https://api.github.com/users/onmyway133/followers","following_url":"https://api.github.com/users/onmyway133/following{/other_user}","gists_url":"https://api.github.com/users/onmyway133/gists{/gist_id}","starred_url":"https://api.github.com/users/onmyway133/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onmyway133/subscriptions","organizations_url":"https://api.github.com/users/onmyway133/orgs","repos_url":"https://api.github.com/users/onmyway133/repos","events_url":"https://api.github.com/users/onmyway133/events{/privacy}","received_events_url":"https://api.github.com/users/onmyway133/received_events","type":"User","site_admin":false},{"login":"RamonGilabert","id":6138120,"avatar_url":"https://avatars.githubusercontent.com/u/6138120?v=3","gravatar_id":"","url":"https://api.github.com/users/RamonGilabert","html_url":"https://github.com/RamonGilabert","followers_url":"https://api.github.com/users/RamonGilabert/followers","following_url":"https://api.github.com/users/RamonGilabert/following{/other_user}","gists_url":"https://api.github.com/users/RamonGilabert/gists{/gist_id}","starred_url":"https://api.github.com/users/RamonGilabert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RamonGilabert/subscriptions","organizations_url":"https://api.github.com/users/RamonGilabert/orgs","repos_url":"https://api.github.com/users/RamonGilabert/repos","events_url":"https://api.github.com/users/RamonGilabert/events{/privacy}","received_events_url":"https://api.github.com/users/RamonGilabert/received_events","type":"User","site_admin":false},{"login":"vadymmarkov","id":10529867,"avatar_url":"https://avatars.githubusercontent.com/u/10529867?v=3","gravatar_id":"","url":"https://api.github.com/users/vadymmarkov","html_url":"https://github.com/vadymmarkov","followers_url":"https://api.github.com/users/vadymmarkov/followers","following_url":"https://api.github.com/users/vadymmarkov/following{/other_user}","gists_url":"https://api.github.com/users/vadymmarkov/gists{/gist_id}","starred_url":"https://api.github.com/users/vadymmarkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadymmarkov/subscriptions","organizations_url":"https://api.github.com/users/vadymmarkov/orgs","repos_url":"https://api.github.com/users/vadymmarkov/repos","events_url":"https://api.github.com/users/vadymmarkov/events{/privacy}","received_events_url":"https://api.github.com/users/vadymmarkov/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/hyperoslo/Spots/pulls/294/commits","review_comments_url":"https://api.github.com/repos/hyperoslo/Spots/pulls/294/comments","review_comment_url":"https://api.github.com/repos/hyperoslo/Spots/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperoslo/Spots/issues/294/comments","statuses_url":"https://api.github.com/repos/hyperoslo/Spots/statuses/13cf4efa391e0df46fc5dac627707382b61920b5","head":{"label":"hyperoslo:develop","ref":"develop","sha":"13cf4efa391e0df46fc5dac627707382b61920b5","user":{"login":"hyperoslo","id":1340892,"avatar_url":"https://avatars.githubusercontent.com/u/1340892?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperoslo","html_url":"https://github.com/hyperoslo","followers_url":"https://api.github.com/users/hyperoslo/followers","following_url":"https://api.github.com/users/hyperoslo/following{/other_user}","gists_url":"https://api.github.com/users/hyperoslo/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperoslo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperoslo/subscriptions","organizations_url":"https://api.github.com/users/hyperoslo/orgs","repos_url":"https://api.github.com/users/hyperoslo/repos","events_url":"https://api.github.com/users/hyperoslo/events{/privacy}","received_events_url":"https://api.github.com/users/hyperoslo/received_events","type":"Organization","site_admin":false},"repo":{"id":43603611,"name":"Spots","full_name":"hyperoslo/Spots","owner":{"login":"hyperoslo","id":1340892,"avatar_url":"https://avatars.githubusercontent.com/u/1340892?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperoslo","html_url":"https://github.com/hyperoslo","followers_url":"https://api.github.com/users/hyperoslo/followers","following_url":"https://api.github.com/users/hyperoslo/following{/other_user}","gists_url":"https://api.github.com/users/hyperoslo/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperoslo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperoslo/subscriptions","organizations_url":"https://api.github.com/users/hyperoslo/orgs","repos_url":"https://api.github.com/users/hyperoslo/repos","events_url":"https://api.github.com/users/hyperoslo/events{/privacy}","received_events_url":"https://api.github.com/users/hyperoslo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperoslo/Spots","description":":bamboo: Spots is a view controller framework that makes your setup and future development blazingly fast.","fork":false,"url":"https://api.github.com/repos/hyperoslo/Spots","forks_url":"https://api.github.com/repos/hyperoslo/Spots/forks","keys_url":"https://api.github.com/repos/hyperoslo/Spots/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperoslo/Spots/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperoslo/Spots/teams","hooks_url":"https://api.github.com/repos/hyperoslo/Spots/hooks","issue_events_url":"https://api.github.com/repos/hyperoslo/Spots/issues/events{/number}","events_url":"https://api.github.com/repos/hyperoslo/Spots/events","assignees_url":"https://api.github.com/repos/hyperoslo/Spots/assignees{/user}","branches_url":"https://api.github.com/repos/hyperoslo/Spots/branches{/branch}","tags_url":"https://api.github.com/repos/hyperoslo/Spots/tags","blobs_url":"https://api.github.com/repos/hyperoslo/Spots/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperoslo/Spots/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperoslo/Spots/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperoslo/Spots/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperoslo/Spots/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperoslo/Spots/languages","stargazers_url":"https://api.github.com/repos/hyperoslo/Spots/stargazers","contributors_url":"https://api.github.com/repos/hyperoslo/Spots/contributors","subscribers_url":"https://api.github.com/repos/hyperoslo/Spots/subscribers","subscription_url":"https://api.github.com/repos/hyperoslo/Spots/subscription","commits_url":"https://api.github.com/repos/hyperoslo/Spots/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperoslo/Spots/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperoslo/Spots/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperoslo/Spots/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperoslo/Spots/contents/{+path}","compare_url":"https://api.github.com/repos/hyperoslo/Spots/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperoslo/Spots/merges","archive_url":"https://api.github.com/repos/hyperoslo/Spots/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperoslo/Spots/downloads","issues_url":"https://api.github.com/repos/hyperoslo/Spots/issues{/number}","pulls_url":"https://api.github.com/repos/hyperoslo/Spots/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperoslo/Spots/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperoslo/Spots/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperoslo/Spots/labels{/name}","releases_url":"https://api.github.com/repos/hyperoslo/Spots/releases{/id}","deployments_url":"https://api.github.com/repos/hyperoslo/Spots/deployments","created_at":"2015-10-03T15:28:33Z","updated_at":"2016-09-10T10:18:10Z","pushed_at":"2016-09-10T15:52:11Z","git_url":"git://github.com/hyperoslo/Spots.git","ssh_url":"git@github.com:hyperoslo/Spots.git","clone_url":"https://github.com/hyperoslo/Spots.git","svn_url":"https://github.com/hyperoslo/Spots","homepage":"","size":30517,"stargazers_count":515,"watchers_count":515,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":24,"mirror_url":null,"open_issues_count":5,"forks":24,"open_issues":5,"watchers":515,"default_branch":"master"}},"base":{"label":"hyperoslo:master","ref":"master","sha":"6d72099e16192e4cea001dcc57e30a42ea351001","user":{"login":"hyperoslo","id":1340892,"avatar_url":"https://avatars.githubusercontent.com/u/1340892?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperoslo","html_url":"https://github.com/hyperoslo","followers_url":"https://api.github.com/users/hyperoslo/followers","following_url":"https://api.github.com/users/hyperoslo/following{/other_user}","gists_url":"https://api.github.com/users/hyperoslo/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperoslo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperoslo/subscriptions","organizations_url":"https://api.github.com/users/hyperoslo/orgs","repos_url":"https://api.github.com/users/hyperoslo/repos","events_url":"https://api.github.com/users/hyperoslo/events{/privacy}","received_events_url":"https://api.github.com/users/hyperoslo/received_events","type":"Organization","site_admin":false},"repo":{"id":43603611,"name":"Spots","full_name":"hyperoslo/Spots","owner":{"login":"hyperoslo","id":1340892,"avatar_url":"https://avatars.githubusercontent.com/u/1340892?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperoslo","html_url":"https://github.com/hyperoslo","followers_url":"https://api.github.com/users/hyperoslo/followers","following_url":"https://api.github.com/users/hyperoslo/following{/other_user}","gists_url":"https://api.github.com/users/hyperoslo/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperoslo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperoslo/subscriptions","organizations_url":"https://api.github.com/users/hyperoslo/orgs","repos_url":"https://api.github.com/users/hyperoslo/repos","events_url":"https://api.github.com/users/hyperoslo/events{/privacy}","received_events_url":"https://api.github.com/users/hyperoslo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperoslo/Spots","description":":bamboo: Spots is a view controller framework that makes your setup and future development blazingly fast.","fork":false,"url":"https://api.github.com/repos/hyperoslo/Spots","forks_url":"https://api.github.com/repos/hyperoslo/Spots/forks","keys_url":"https://api.github.com/repos/hyperoslo/Spots/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperoslo/Spots/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperoslo/Spots/teams","hooks_url":"https://api.github.com/repos/hyperoslo/Spots/hooks","issue_events_url":"https://api.github.com/repos/hyperoslo/Spots/issues/events{/number}","events_url":"https://api.github.com/repos/hyperoslo/Spots/events","assignees_url":"https://api.github.com/repos/hyperoslo/Spots/assignees{/user}","branches_url":"https://api.github.com/repos/hyperoslo/Spots/branches{/branch}","tags_url":"https://api.github.com/repos/hyperoslo/Spots/tags","blobs_url":"https://api.github.com/repos/hyperoslo/Spots/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperoslo/Spots/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperoslo/Spots/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperoslo/Spots/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperoslo/Spots/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperoslo/Spots/languages","stargazers_url":"https://api.github.com/repos/hyperoslo/Spots/stargazers","contributors_url":"https://api.github.com/repos/hyperoslo/Spots/contributors","subscribers_url":"https://api.github.com/repos/hyperoslo/Spots/subscribers","subscription_url":"https://api.github.com/repos/hyperoslo/Spots/subscription","commits_url":"https://api.github.com/repos/hyperoslo/Spots/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperoslo/Spots/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperoslo/Spots/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperoslo/Spots/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperoslo/Spots/contents/{+path}","compare_url":"https://api.github.com/repos/hyperoslo/Spots/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperoslo/Spots/merges","archive_url":"https://api.github.com/repos/hyperoslo/Spots/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperoslo/Spots/downloads","issues_url":"https://api.github.com/repos/hyperoslo/Spots/issues{/number}","pulls_url":"https://api.github.com/repos/hyperoslo/Spots/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperoslo/Spots/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperoslo/Spots/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperoslo/Spots/labels{/name}","releases_url":"https://api.github.com/repos/hyperoslo/Spots/releases{/id}","deployments_url":"https://api.github.com/repos/hyperoslo/Spots/deployments","created_at":"2015-10-03T15:28:33Z","updated_at":"2016-09-10T10:18:10Z","pushed_at":"2016-09-10T15:52:11Z","git_url":"git://github.com/hyperoslo/Spots.git","ssh_url":"git@github.com:hyperoslo/Spots.git","clone_url":"https://github.com/hyperoslo/Spots.git","svn_url":"https://github.com/hyperoslo/Spots","homepage":"","size":30517,"stargazers_count":515,"watchers_count":515,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":24,"mirror_url":null,"open_issues_count":5,"forks":24,"open_issues":5,"watchers":515,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperoslo/Spots/pulls/294"},"html":{"href":"https://github.com/hyperoslo/Spots/pull/294"},"issue":{"href":"https://api.github.com/repos/hyperoslo/Spots/issues/294"},"comments":{"href":"https://api.github.com/repos/hyperoslo/Spots/issues/294/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperoslo/Spots/pulls/294/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperoslo/Spots/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperoslo/Spots/pulls/294/commits"},"statuses":{"href":"https://api.github.com/repos/hyperoslo/Spots/statuses/13cf4efa391e0df46fc5dac627707382b61920b5"}}}}
{"actor":{"display_login":"zenangst"}}