{"action":"created","issue":{"url":"https://api.github.com/repos/eslint/eslint/issues/7669","repository_url":"https://api.github.com/repos/eslint/eslint","labels_url":"https://api.github.com/repos/eslint/eslint/issues/7669/labels{/name}","comments_url":"https://api.github.com/repos/eslint/eslint/issues/7669/comments","events_url":"https://api.github.com/repos/eslint/eslint/issues/7669/events","html_url":"https://github.com/eslint/eslint/pull/7669","id":191916166,"number":7669,"title":"New: Additional APIs (fixes #6256)","user":{"login":"ilyavolodin","id":1380062,"avatar_url":"https://avatars.githubusercontent.com/u/1380062?v=3","gravatar_id":"","url":"https://api.github.com/users/ilyavolodin","html_url":"https://github.com/ilyavolodin","followers_url":"https://api.github.com/users/ilyavolodin/followers","following_url":"https://api.github.com/users/ilyavolodin/following{/other_user}","gists_url":"https://api.github.com/users/ilyavolodin/gists{/gist_id}","starred_url":"https://api.github.com/users/ilyavolodin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilyavolodin/subscriptions","organizations_url":"https://api.github.com/users/ilyavolodin/orgs","repos_url":"https://api.github.com/users/ilyavolodin/repos","events_url":"https://api.github.com/users/ilyavolodin/events{/privacy}","received_events_url":"https://api.github.com/users/ilyavolodin/received_events","type":"User","site_admin":false},"labels":[{"id":131106229,"url":"https://api.github.com/repos/eslint/eslint/labels/accepted","name":"accepted","color":"0052cc","default":false},{"id":82922548,"url":"https://api.github.com/repos/eslint/eslint/labels/core","name":"core","color":"c7def8","default":false},{"id":253473350,"url":"https://api.github.com/repos/eslint/eslint/labels/feature","name":"feature","color":"bfd4f2","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2016-11-28T04:15:26Z","updated_at":"2016-12-09T04:09:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/eslint/eslint/pulls/7669","html_url":"https://github.com/eslint/eslint/pull/7669","diff_url":"https://github.com/eslint/eslint/pull/7669.diff","patch_url":"https://github.com/eslint/eslint/pull/7669.patch"},"body":"**What is the purpose of this pull request? (put an \"X\" next to item)**\r\n\r\n[x] Add something to the core\r\n\r\n**What changes did you make? (Give an overview)**\r\nAdded 3 new API methods.\r\n* `getRules` to `linter`\r\n* `version` to `linter`\r\n* `version` to `CLIEngine`\r\n\r\n**Is there anything you'd like reviewers to focus on?**\r\nThere's one failing test in the eslint.js file. I honestly don't know how to fix it, since it's only a problem when testing all of the ESLint files. If testing `eslint.js` file by itself, everything passes. This is due to us never cleaning loaded rules (and not having any abilities to clean loaded rules from inside eslint.js file). Any suggestions are welcome. PR is also missing documentation changes. I'll add them once I figure out how to fix failing test.\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/eslint/eslint/issues/comments/265929055","html_url":"https://github.com/eslint/eslint/pull/7669#issuecomment-265929055","issue_url":"https://api.github.com/repos/eslint/eslint/issues/7669","id":265929055,"user":{"login":"ilyavolodin","id":1380062,"avatar_url":"https://avatars.githubusercontent.com/u/1380062?v=3","gravatar_id":"","url":"https://api.github.com/users/ilyavolodin","html_url":"https://github.com/ilyavolodin","followers_url":"https://api.github.com/users/ilyavolodin/followers","following_url":"https://api.github.com/users/ilyavolodin/following{/other_user}","gists_url":"https://api.github.com/users/ilyavolodin/gists{/gist_id}","starred_url":"https://api.github.com/users/ilyavolodin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilyavolodin/subscriptions","organizations_url":"https://api.github.com/users/ilyavolodin/orgs","repos_url":"https://api.github.com/users/ilyavolodin/repos","events_url":"https://api.github.com/users/ilyavolodin/events{/privacy}","received_events_url":"https://api.github.com/users/ilyavolodin/received_events","type":"User","site_admin":false},"created_at":"2016-12-09T04:09:42Z","updated_at":"2016-12-09T04:09:42Z","body":"@platinumazure On one hand, that's a good point, there's no test like that. On the other - it would be pretty hard to create, and I'm not sure how valid it would be. `getAllRules` is exposed on the `linter` API object, however, custom rules (outside of the plugins) could only be loaded through `CLIEngine` API. I'm also not sure if we have any tests that access both APIs at the same time."}}
{"actor":{"display_login":"ilyavolodin"}}