{"action":"closed","number":2644,"pull_request":{"url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2644","id":96504674,"html_url":"https://github.com/MovingBlocks/Terasology/pull/2644","diff_url":"https://github.com/MovingBlocks/Terasology/pull/2644.diff","patch_url":"https://github.com/MovingBlocks/Terasology/pull/2644.patch","issue_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2644","number":2644,"state":"closed","locked":false,"title":"Added UIScrollingText widget and credits screen","user":{"login":"iojw","id":1729493,"avatar_url":"https://avatars.githubusercontent.com/u/1729493?v=3","gravatar_id":"","url":"https://api.github.com/users/iojw","html_url":"https://github.com/iojw","followers_url":"https://api.github.com/users/iojw/followers","following_url":"https://api.github.com/users/iojw/following{/other_user}","gists_url":"https://api.github.com/users/iojw/gists{/gist_id}","starred_url":"https://api.github.com/users/iojw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iojw/subscriptions","organizations_url":"https://api.github.com/users/iojw/orgs","repos_url":"https://api.github.com/users/iojw/repos","events_url":"https://api.github.com/users/iojw/events{/privacy}","received_events_url":"https://api.github.com/users/iojw/received_events","type":"User","site_admin":false},"body":"<!-- Thanks for submitting a pull request for Terasology! :-)\r\nPlease fill in some brief details below about the PR.\r\nIf it contains source code please make sure to run Checkstyle on it first\r\nIf you add unit tests we'll love you forever! -->\r\n\r\n### Contains\r\n\r\nFixes #2578:\r\n\r\n- Contains a new UIScrollingText NUI widget which scrolls through lines of text with methods to start, stop, reset scrolling, set scrolling speed and toggle auto reset for the scrolling.  \r\n- Also contains a new credits screen accessible from the main menu that makes use of UIScrollingText\r\n\r\n### How to test\r\n\r\nOpen the Credits screen from the main menu.\r\n### Outstanding before merging\r\n\r\nNeed some opinions on the font size, scrolling speed, and overall structure of the credits. \r\n\r\n~~As for support for fancy text with UIScrollingText, seems that I would have to make use of drawTextRaw but I'm unsure of how to obtain a new Font object different from the current style.~~\r\n\r\nAlso, the credits are currently loaded as a very long string in CreditsScreen.java - seems like it would be better to read it from an external file, but where would I place this? There doesn't seem to be a place to put text resources in the resources folder.\r\n\r\n🙂 \r\n \r\nEDIT: Seems like you can retrieve Font objects through Assets.getFont(). Will look into implementing support for Markdown/HTML\r\n","created_at":"2016-12-05T10:37:44Z","updated_at":"2016-12-06T10:56:25Z","closed_at":"2016-12-06T10:56:25Z","merged_at":null,"merge_commit_sha":"bea463685c7e1346d93b864966f2a568312de2e9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2644/commits","review_comments_url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2644/comments","review_comment_url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2644/comments","statuses_url":"https://api.github.com/repos/MovingBlocks/Terasology/statuses/75b5e114924269db20f9323fca59af432fe200ea","head":{"label":"iojw:credits","ref":"credits","sha":"75b5e114924269db20f9323fca59af432fe200ea","user":{"login":"iojw","id":1729493,"avatar_url":"https://avatars.githubusercontent.com/u/1729493?v=3","gravatar_id":"","url":"https://api.github.com/users/iojw","html_url":"https://github.com/iojw","followers_url":"https://api.github.com/users/iojw/followers","following_url":"https://api.github.com/users/iojw/following{/other_user}","gists_url":"https://api.github.com/users/iojw/gists{/gist_id}","starred_url":"https://api.github.com/users/iojw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iojw/subscriptions","organizations_url":"https://api.github.com/users/iojw/orgs","repos_url":"https://api.github.com/users/iojw/repos","events_url":"https://api.github.com/users/iojw/events{/privacy}","received_events_url":"https://api.github.com/users/iojw/received_events","type":"User","site_admin":false},"repo":{"id":75058543,"name":"Terasology","full_name":"iojw/Terasology","owner":{"login":"iojw","id":1729493,"avatar_url":"https://avatars.githubusercontent.com/u/1729493?v=3","gravatar_id":"","url":"https://api.github.com/users/iojw","html_url":"https://github.com/iojw","followers_url":"https://api.github.com/users/iojw/followers","following_url":"https://api.github.com/users/iojw/following{/other_user}","gists_url":"https://api.github.com/users/iojw/gists{/gist_id}","starred_url":"https://api.github.com/users/iojw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iojw/subscriptions","organizations_url":"https://api.github.com/users/iojw/orgs","repos_url":"https://api.github.com/users/iojw/repos","events_url":"https://api.github.com/users/iojw/events{/privacy}","received_events_url":"https://api.github.com/users/iojw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iojw/Terasology","description":"Terasology - open source voxel world","fork":true,"url":"https://api.github.com/repos/iojw/Terasology","forks_url":"https://api.github.com/repos/iojw/Terasology/forks","keys_url":"https://api.github.com/repos/iojw/Terasology/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iojw/Terasology/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iojw/Terasology/teams","hooks_url":"https://api.github.com/repos/iojw/Terasology/hooks","issue_events_url":"https://api.github.com/repos/iojw/Terasology/issues/events{/number}","events_url":"https://api.github.com/repos/iojw/Terasology/events","assignees_url":"https://api.github.com/repos/iojw/Terasology/assignees{/user}","branches_url":"https://api.github.com/repos/iojw/Terasology/branches{/branch}","tags_url":"https://api.github.com/repos/iojw/Terasology/tags","blobs_url":"https://api.github.com/repos/iojw/Terasology/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iojw/Terasology/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iojw/Terasology/git/refs{/sha}","trees_url":"https://api.github.com/repos/iojw/Terasology/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iojw/Terasology/statuses/{sha}","languages_url":"https://api.github.com/repos/iojw/Terasology/languages","stargazers_url":"https://api.github.com/repos/iojw/Terasology/stargazers","contributors_url":"https://api.github.com/repos/iojw/Terasology/contributors","subscribers_url":"https://api.github.com/repos/iojw/Terasology/subscribers","subscription_url":"https://api.github.com/repos/iojw/Terasology/subscription","commits_url":"https://api.github.com/repos/iojw/Terasology/commits{/sha}","git_commits_url":"https://api.github.com/repos/iojw/Terasology/git/commits{/sha}","comments_url":"https://api.github.com/repos/iojw/Terasology/comments{/number}","issue_comment_url":"https://api.github.com/repos/iojw/Terasology/issues/comments{/number}","contents_url":"https://api.github.com/repos/iojw/Terasology/contents/{+path}","compare_url":"https://api.github.com/repos/iojw/Terasology/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iojw/Terasology/merges","archive_url":"https://api.github.com/repos/iojw/Terasology/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iojw/Terasology/downloads","issues_url":"https://api.github.com/repos/iojw/Terasology/issues{/number}","pulls_url":"https://api.github.com/repos/iojw/Terasology/pulls{/number}","milestones_url":"https://api.github.com/repos/iojw/Terasology/milestones{/number}","notifications_url":"https://api.github.com/repos/iojw/Terasology/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iojw/Terasology/labels{/name}","releases_url":"https://api.github.com/repos/iojw/Terasology/releases{/id}","deployments_url":"https://api.github.com/repos/iojw/Terasology/deployments","created_at":"2016-11-29T08:13:17Z","updated_at":"2016-11-29T08:13:28Z","pushed_at":"2016-12-06T10:42:09Z","git_url":"git://github.com/iojw/Terasology.git","ssh_url":"git@github.com:iojw/Terasology.git","clone_url":"https://github.com/iojw/Terasology.git","svn_url":"https://github.com/iojw/Terasology","homepage":"http://terasology.org","size":276691,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"MovingBlocks:develop","ref":"develop","sha":"817dc381c2fcea5d64148a562085975b887b1b0d","user":{"login":"MovingBlocks","id":1292442,"avatar_url":"https://avatars.githubusercontent.com/u/1292442?v=3","gravatar_id":"","url":"https://api.github.com/users/MovingBlocks","html_url":"https://github.com/MovingBlocks","followers_url":"https://api.github.com/users/MovingBlocks/followers","following_url":"https://api.github.com/users/MovingBlocks/following{/other_user}","gists_url":"https://api.github.com/users/MovingBlocks/gists{/gist_id}","starred_url":"https://api.github.com/users/MovingBlocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MovingBlocks/subscriptions","organizations_url":"https://api.github.com/users/MovingBlocks/orgs","repos_url":"https://api.github.com/users/MovingBlocks/repos","events_url":"https://api.github.com/users/MovingBlocks/events{/privacy}","received_events_url":"https://api.github.com/users/MovingBlocks/received_events","type":"Organization","site_admin":false},"repo":{"id":1438007,"name":"Terasology","full_name":"MovingBlocks/Terasology","owner":{"login":"MovingBlocks","id":1292442,"avatar_url":"https://avatars.githubusercontent.com/u/1292442?v=3","gravatar_id":"","url":"https://api.github.com/users/MovingBlocks","html_url":"https://github.com/MovingBlocks","followers_url":"https://api.github.com/users/MovingBlocks/followers","following_url":"https://api.github.com/users/MovingBlocks/following{/other_user}","gists_url":"https://api.github.com/users/MovingBlocks/gists{/gist_id}","starred_url":"https://api.github.com/users/MovingBlocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MovingBlocks/subscriptions","organizations_url":"https://api.github.com/users/MovingBlocks/orgs","repos_url":"https://api.github.com/users/MovingBlocks/repos","events_url":"https://api.github.com/users/MovingBlocks/events{/privacy}","received_events_url":"https://api.github.com/users/MovingBlocks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MovingBlocks/Terasology","description":"Terasology - open source voxel world","fork":false,"url":"https://api.github.com/repos/MovingBlocks/Terasology","forks_url":"https://api.github.com/repos/MovingBlocks/Terasology/forks","keys_url":"https://api.github.com/repos/MovingBlocks/Terasology/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MovingBlocks/Terasology/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MovingBlocks/Terasology/teams","hooks_url":"https://api.github.com/repos/MovingBlocks/Terasology/hooks","issue_events_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/events{/number}","events_url":"https://api.github.com/repos/MovingBlocks/Terasology/events","assignees_url":"https://api.github.com/repos/MovingBlocks/Terasology/assignees{/user}","branches_url":"https://api.github.com/repos/MovingBlocks/Terasology/branches{/branch}","tags_url":"https://api.github.com/repos/MovingBlocks/Terasology/tags","blobs_url":"https://api.github.com/repos/MovingBlocks/Terasology/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MovingBlocks/Terasology/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MovingBlocks/Terasology/git/refs{/sha}","trees_url":"https://api.github.com/repos/MovingBlocks/Terasology/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MovingBlocks/Terasology/statuses/{sha}","languages_url":"https://api.github.com/repos/MovingBlocks/Terasology/languages","stargazers_url":"https://api.github.com/repos/MovingBlocks/Terasology/stargazers","contributors_url":"https://api.github.com/repos/MovingBlocks/Terasology/contributors","subscribers_url":"https://api.github.com/repos/MovingBlocks/Terasology/subscribers","subscription_url":"https://api.github.com/repos/MovingBlocks/Terasology/subscription","commits_url":"https://api.github.com/repos/MovingBlocks/Terasology/commits{/sha}","git_commits_url":"https://api.github.com/repos/MovingBlocks/Terasology/git/commits{/sha}","comments_url":"https://api.github.com/repos/MovingBlocks/Terasology/comments{/number}","issue_comment_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/comments{/number}","contents_url":"https://api.github.com/repos/MovingBlocks/Terasology/contents/{+path}","compare_url":"https://api.github.com/repos/MovingBlocks/Terasology/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MovingBlocks/Terasology/merges","archive_url":"https://api.github.com/repos/MovingBlocks/Terasology/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MovingBlocks/Terasology/downloads","issues_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues{/number}","pulls_url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls{/number}","milestones_url":"https://api.github.com/repos/MovingBlocks/Terasology/milestones{/number}","notifications_url":"https://api.github.com/repos/MovingBlocks/Terasology/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MovingBlocks/Terasology/labels{/name}","releases_url":"https://api.github.com/repos/MovingBlocks/Terasology/releases{/id}","deployments_url":"https://api.github.com/repos/MovingBlocks/Terasology/deployments","created_at":"2011-03-04T03:49:19Z","updated_at":"2016-12-06T09:20:45Z","pushed_at":"2016-12-06T10:42:10Z","git_url":"git://github.com/MovingBlocks/Terasology.git","ssh_url":"git@github.com:MovingBlocks/Terasology.git","clone_url":"https://github.com/MovingBlocks/Terasology.git","svn_url":"https://github.com/MovingBlocks/Terasology","homepage":"http://terasology.org","size":346106,"stargazers_count":1760,"watchers_count":1760,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":755,"mirror_url":null,"open_issues_count":320,"forks":755,"open_issues":320,"watchers":1760,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2644"},"html":{"href":"https://github.com/MovingBlocks/Terasology/pull/2644"},"issue":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2644"},"comments":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2644/comments"},"review_comments":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2644/comments"},"review_comment":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2644/commits"},"statuses":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/statuses/75b5e114924269db20f9323fca59af432fe200ea"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":3,"review_comments":4,"commits":4,"additions":662,"deletions":0,"changed_files":8}}
{"actor":{"display_login":"iojw"}}