{"action":"created","comment":{"url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments/75622000","id":75622000,"diff_hunk":"@@ -573,21 +573,17 @@\n \r\n //Somebody cut an important wire and now we're following a new definition of \"pitch.\"\r\n /obj/machinery/vending/proc/throw_item()\r\n-\tvar/obj/throw_item = null\r\n-\tvar/mob/living/target = locate() in view(7,src)\r\n-\tif(!target)\r\n-\t\treturn 0\r\n-\r\n+\tvar/obj/dispensed_item = null\r\n \tfor(var/datum/stored_items/vending_products/R in src.product_records)\r\n-\t\tthrow_item = R.get_product(loc)\r\n-\t\tif (!throw_item)\r\n-\t\t\tcontinue\r\n-\t\tbreak\r\n-\tif (!throw_item)\r\n+\t\tdispensed_item = R.get_product(loc)\r\n+\t\tif (dispensed_item)\r\n+\t\t\tbreak\r\n+\r\n+\tif (!dispensed_item)\r\n \t\treturn 0\r\n-\tspawn(0)\r\n-\t\tthrow_item.throw_at(target, 16, 3, src)\r\n-\tsrc.visible_message(\"<span class='warning'>\\The [src] launches \\a [throw_item] at \\the [target]!</span>\")\r\n+\r\n+\tdispensed_item.forceMove(get_turf(src))\r\n+\tvisible_message(\"<span class='warning'>\\The [src] shudders and \\a [dispensed_item] falls out!</span>\")\r","path":"code/game/machinery/vending.dm","position":27,"original_position":27,"commit_id":"ce036462a517717199c7b293bf79b4d5fa1c8ae1","original_commit_id":"ce036462a517717199c7b293bf79b4d5fa1c8ae1","user":{"login":"PsiOmegaDelta","id":496895,"avatar_url":"https://avatars.githubusercontent.com/u/496895?v=3","gravatar_id":"","url":"https://api.github.com/users/PsiOmegaDelta","html_url":"https://github.com/PsiOmegaDelta","followers_url":"https://api.github.com/users/PsiOmegaDelta/followers","following_url":"https://api.github.com/users/PsiOmegaDelta/following{/other_user}","gists_url":"https://api.github.com/users/PsiOmegaDelta/gists{/gist_id}","starred_url":"https://api.github.com/users/PsiOmegaDelta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PsiOmegaDelta/subscriptions","organizations_url":"https://api.github.com/users/PsiOmegaDelta/orgs","repos_url":"https://api.github.com/users/PsiOmegaDelta/repos","events_url":"https://api.github.com/users/PsiOmegaDelta/events{/privacy}","received_events_url":"https://api.github.com/users/PsiOmegaDelta/received_events","type":"User","site_admin":false},"body":"These unmentioned changes are relevant to cell capacities how?","created_at":"2016-08-22T06:04:18Z","updated_at":"2016-08-22T06:04:18Z","html_url":"https://github.com/Baystation12/Baystation12/pull/13945#discussion_r75622000","pull_request_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/13945","_links":{"self":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments/75622000"},"html":{"href":"https://github.com/Baystation12/Baystation12/pull/13945#discussion_r75622000"},"pull_request":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/13945"}}},"pull_request":{"url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/13945","id":81255922,"html_url":"https://github.com/Baystation12/Baystation12/pull/13945","diff_url":"https://github.com/Baystation12/Baystation12/pull/13945.diff","patch_url":"https://github.com/Baystation12/Baystation12/pull/13945.patch","issue_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/13945","number":13945,"state":"open","locked":false,"title":"Changes Cellrate","user":{"login":"atlantiscze","id":5147960,"avatar_url":"https://avatars.githubusercontent.com/u/5147960?v=3","gravatar_id":"","url":"https://api.github.com/users/atlantiscze","html_url":"https://github.com/atlantiscze","followers_url":"https://api.github.com/users/atlantiscze/followers","following_url":"https://api.github.com/users/atlantiscze/following{/other_user}","gists_url":"https://api.github.com/users/atlantiscze/gists{/gist_id}","starred_url":"https://api.github.com/users/atlantiscze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atlantiscze/subscriptions","organizations_url":"https://api.github.com/users/atlantiscze/orgs","repos_url":"https://api.github.com/users/atlantiscze/repos","events_url":"https://api.github.com/users/atlantiscze/events{/privacy}","received_events_url":"https://api.github.com/users/atlantiscze/received_events","type":"User","site_admin":false},"body":"- Cellrate changed to 1/1800 (1/(3600/machinery controller tick, which is 2 seconds)).\r\n\r\n**Why?**\r\nReason for this is that power cell rating now equals it's actual capacity in watthours. In short, a cell with rating of 1000 can provide 1000W of power over the duration of one hour. It is easier to predict how long a cell might last. Old value was semi-randomly picked one and converting it to watthours required you to do quite some math (convert charge to joules, and joules to watthours).\r\n\r\n- Removes SMESRATE define. SMESes now use CELLRATE instead. There is absolutely no reason, as the value is only used internally, and has no effect on actual game.\r\n- Tweaks SMES magnetic coil properties a bit. Mostly results in rounded values. SMES coils are a little bit smaller capacity wise (about 56~ -> 50kWh for regular coil), but it's not marginal enough to have a major gameplay effect.\r\n- Expands the original fractal reactor (infinite powersource) idea. It no longer produces a world-wide message when spawned. Also adds APC dummy load and power cable dummy load, which are useful for testing of power flow and stuff. These debug items also display powernet information when examined. This information may be hidden by setting a var, for example when an admin wants to use varedit resprited variant for an event or something.\r\n\r\nNOTE: Cell capacities have not yet been changed. I have a piece of debug code in place that will help me trace most power cells, to ensure they are updated properly. This debug code will be removed later.","created_at":"2016-08-14T22:07:57Z","updated_at":"2016-08-22T06:04:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05eec518fcc973242e44fcc53eedda562f74c638","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/13945/commits","review_comments_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/13945/comments","review_comment_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/13945/comments","statuses_url":"https://api.github.com/repos/Baystation12/Baystation12/statuses/ce036462a517717199c7b293bf79b4d5fa1c8ae1","head":{"label":"atlantiscze:2016-08-14-CellrateChange","ref":"2016-08-14-CellrateChange","sha":"ce036462a517717199c7b293bf79b4d5fa1c8ae1","user":{"login":"atlantiscze","id":5147960,"avatar_url":"https://avatars.githubusercontent.com/u/5147960?v=3","gravatar_id":"","url":"https://api.github.com/users/atlantiscze","html_url":"https://github.com/atlantiscze","followers_url":"https://api.github.com/users/atlantiscze/followers","following_url":"https://api.github.com/users/atlantiscze/following{/other_user}","gists_url":"https://api.github.com/users/atlantiscze/gists{/gist_id}","starred_url":"https://api.github.com/users/atlantiscze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atlantiscze/subscriptions","organizations_url":"https://api.github.com/users/atlantiscze/orgs","repos_url":"https://api.github.com/users/atlantiscze/repos","events_url":"https://api.github.com/users/atlantiscze/events{/privacy}","received_events_url":"https://api.github.com/users/atlantiscze/received_events","type":"User","site_admin":false},"repo":{"id":21876216,"name":"Baystation12","full_name":"atlantiscze/Baystation12","owner":{"login":"atlantiscze","id":5147960,"avatar_url":"https://avatars.githubusercontent.com/u/5147960?v=3","gravatar_id":"","url":"https://api.github.com/users/atlantiscze","html_url":"https://github.com/atlantiscze","followers_url":"https://api.github.com/users/atlantiscze/followers","following_url":"https://api.github.com/users/atlantiscze/following{/other_user}","gists_url":"https://api.github.com/users/atlantiscze/gists{/gist_id}","starred_url":"https://api.github.com/users/atlantiscze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atlantiscze/subscriptions","organizations_url":"https://api.github.com/users/atlantiscze/orgs","repos_url":"https://api.github.com/users/atlantiscze/repos","events_url":"https://api.github.com/users/atlantiscze/events{/privacy}","received_events_url":"https://api.github.com/users/atlantiscze/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/atlantiscze/Baystation12","description":"The code for Baystation12's branch of SS13","fork":true,"url":"https://api.github.com/repos/atlantiscze/Baystation12","forks_url":"https://api.github.com/repos/atlantiscze/Baystation12/forks","keys_url":"https://api.github.com/repos/atlantiscze/Baystation12/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atlantiscze/Baystation12/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atlantiscze/Baystation12/teams","hooks_url":"https://api.github.com/repos/atlantiscze/Baystation12/hooks","issue_events_url":"https://api.github.com/repos/atlantiscze/Baystation12/issues/events{/number}","events_url":"https://api.github.com/repos/atlantiscze/Baystation12/events","assignees_url":"https://api.github.com/repos/atlantiscze/Baystation12/assignees{/user}","branches_url":"https://api.github.com/repos/atlantiscze/Baystation12/branches{/branch}","tags_url":"https://api.github.com/repos/atlantiscze/Baystation12/tags","blobs_url":"https://api.github.com/repos/atlantiscze/Baystation12/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atlantiscze/Baystation12/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atlantiscze/Baystation12/git/refs{/sha}","trees_url":"https://api.github.com/repos/atlantiscze/Baystation12/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atlantiscze/Baystation12/statuses/{sha}","languages_url":"https://api.github.com/repos/atlantiscze/Baystation12/languages","stargazers_url":"https://api.github.com/repos/atlantiscze/Baystation12/stargazers","contributors_url":"https://api.github.com/repos/atlantiscze/Baystation12/contributors","subscribers_url":"https://api.github.com/repos/atlantiscze/Baystation12/subscribers","subscription_url":"https://api.github.com/repos/atlantiscze/Baystation12/subscription","commits_url":"https://api.github.com/repos/atlantiscze/Baystation12/commits{/sha}","git_commits_url":"https://api.github.com/repos/atlantiscze/Baystation12/git/commits{/sha}","comments_url":"https://api.github.com/repos/atlantiscze/Baystation12/comments{/number}","issue_comment_url":"https://api.github.com/repos/atlantiscze/Baystation12/issues/comments{/number}","contents_url":"https://api.github.com/repos/atlantiscze/Baystation12/contents/{+path}","compare_url":"https://api.github.com/repos/atlantiscze/Baystation12/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atlantiscze/Baystation12/merges","archive_url":"https://api.github.com/repos/atlantiscze/Baystation12/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atlantiscze/Baystation12/downloads","issues_url":"https://api.github.com/repos/atlantiscze/Baystation12/issues{/number}","pulls_url":"https://api.github.com/repos/atlantiscze/Baystation12/pulls{/number}","milestones_url":"https://api.github.com/repos/atlantiscze/Baystation12/milestones{/number}","notifications_url":"https://api.github.com/repos/atlantiscze/Baystation12/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atlantiscze/Baystation12/labels{/name}","releases_url":"https://api.github.com/repos/atlantiscze/Baystation12/releases{/id}","deployments_url":"https://api.github.com/repos/atlantiscze/Baystation12/deployments","created_at":"2014-07-15T21:17:06Z","updated_at":"2016-01-17T03:45:38Z","pushed_at":"2016-08-22T02:40:57Z","git_url":"git://github.com/atlantiscze/Baystation12.git","ssh_url":"git@github.com:atlantiscze/Baystation12.git","clone_url":"https://github.com/atlantiscze/Baystation12.git","svn_url":"https://github.com/atlantiscze/Baystation12","homepage":"http://baystation12.net/","size":610029,"stargazers_count":1,"watchers_count":1,"language":"DM","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"_BAY-Dev"}},"base":{"label":"Baystation12:dev","ref":"dev","sha":"2a9799679e08b691847d57f39e191679badb2b7b","user":{"login":"Baystation12","id":1174322,"avatar_url":"https://avatars.githubusercontent.com/u/1174322?v=3","gravatar_id":"","url":"https://api.github.com/users/Baystation12","html_url":"https://github.com/Baystation12","followers_url":"https://api.github.com/users/Baystation12/followers","following_url":"https://api.github.com/users/Baystation12/following{/other_user}","gists_url":"https://api.github.com/users/Baystation12/gists{/gist_id}","starred_url":"https://api.github.com/users/Baystation12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baystation12/subscriptions","organizations_url":"https://api.github.com/users/Baystation12/orgs","repos_url":"https://api.github.com/users/Baystation12/repos","events_url":"https://api.github.com/users/Baystation12/events{/privacy}","received_events_url":"https://api.github.com/users/Baystation12/received_events","type":"Organization","site_admin":false},"repo":{"id":2715933,"name":"Baystation12","full_name":"Baystation12/Baystation12","owner":{"login":"Baystation12","id":1174322,"avatar_url":"https://avatars.githubusercontent.com/u/1174322?v=3","gravatar_id":"","url":"https://api.github.com/users/Baystation12","html_url":"https://github.com/Baystation12","followers_url":"https://api.github.com/users/Baystation12/followers","following_url":"https://api.github.com/users/Baystation12/following{/other_user}","gists_url":"https://api.github.com/users/Baystation12/gists{/gist_id}","starred_url":"https://api.github.com/users/Baystation12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baystation12/subscriptions","organizations_url":"https://api.github.com/users/Baystation12/orgs","repos_url":"https://api.github.com/users/Baystation12/repos","events_url":"https://api.github.com/users/Baystation12/events{/privacy}","received_events_url":"https://api.github.com/users/Baystation12/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Baystation12/Baystation12","description":"The code for Baystation12's branch of SS13","fork":false,"url":"https://api.github.com/repos/Baystation12/Baystation12","forks_url":"https://api.github.com/repos/Baystation12/Baystation12/forks","keys_url":"https://api.github.com/repos/Baystation12/Baystation12/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Baystation12/Baystation12/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Baystation12/Baystation12/teams","hooks_url":"https://api.github.com/repos/Baystation12/Baystation12/hooks","issue_events_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/events{/number}","events_url":"https://api.github.com/repos/Baystation12/Baystation12/events","assignees_url":"https://api.github.com/repos/Baystation12/Baystation12/assignees{/user}","branches_url":"https://api.github.com/repos/Baystation12/Baystation12/branches{/branch}","tags_url":"https://api.github.com/repos/Baystation12/Baystation12/tags","blobs_url":"https://api.github.com/repos/Baystation12/Baystation12/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Baystation12/Baystation12/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Baystation12/Baystation12/git/refs{/sha}","trees_url":"https://api.github.com/repos/Baystation12/Baystation12/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Baystation12/Baystation12/statuses/{sha}","languages_url":"https://api.github.com/repos/Baystation12/Baystation12/languages","stargazers_url":"https://api.github.com/repos/Baystation12/Baystation12/stargazers","contributors_url":"https://api.github.com/repos/Baystation12/Baystation12/contributors","subscribers_url":"https://api.github.com/repos/Baystation12/Baystation12/subscribers","subscription_url":"https://api.github.com/repos/Baystation12/Baystation12/subscription","commits_url":"https://api.github.com/repos/Baystation12/Baystation12/commits{/sha}","git_commits_url":"https://api.github.com/repos/Baystation12/Baystation12/git/commits{/sha}","comments_url":"https://api.github.com/repos/Baystation12/Baystation12/comments{/number}","issue_comment_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/comments{/number}","contents_url":"https://api.github.com/repos/Baystation12/Baystation12/contents/{+path}","compare_url":"https://api.github.com/repos/Baystation12/Baystation12/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Baystation12/Baystation12/merges","archive_url":"https://api.github.com/repos/Baystation12/Baystation12/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Baystation12/Baystation12/downloads","issues_url":"https://api.github.com/repos/Baystation12/Baystation12/issues{/number}","pulls_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls{/number}","milestones_url":"https://api.github.com/repos/Baystation12/Baystation12/milestones{/number}","notifications_url":"https://api.github.com/repos/Baystation12/Baystation12/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Baystation12/Baystation12/labels{/name}","releases_url":"https://api.github.com/repos/Baystation12/Baystation12/releases{/id}","deployments_url":"https://api.github.com/repos/Baystation12/Baystation12/deployments","created_at":"2011-11-05T16:12:41Z","updated_at":"2016-08-20T20:32:23Z","pushed_at":"2016-08-22T05:18:52Z","git_url":"git://github.com/Baystation12/Baystation12.git","ssh_url":"git@github.com:Baystation12/Baystation12.git","clone_url":"https://github.com/Baystation12/Baystation12.git","svn_url":"https://github.com/Baystation12/Baystation12","homepage":"http://baystation12.net/","size":1689828,"stargazers_count":222,"watchers_count":222,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":724,"mirror_url":null,"open_issues_count":474,"forks":724,"open_issues":474,"watchers":222,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/13945"},"html":{"href":"https://github.com/Baystation12/Baystation12/pull/13945"},"issue":{"href":"https://api.github.com/repos/Baystation12/Baystation12/issues/13945"},"comments":{"href":"https://api.github.com/repos/Baystation12/Baystation12/issues/13945/comments"},"review_comments":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/13945/comments"},"review_comment":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/13945/commits"},"statuses":{"href":"https://api.github.com/repos/Baystation12/Baystation12/statuses/ce036462a517717199c7b293bf79b4d5fa1c8ae1"}}}}
{"actor":{"display_login":"PsiOmegaDelta"}}