{"action":"created","comment":{"url":"https://api.github.com/repos/sk89q/WorldEdit/pulls/comments/56836174","id":56836174,"diff_hunk":"@@ -0,0 +1,90 @@\n+apply plugin: 'eclipse'\n+apply plugin: 'idea'\n+\n+buildscript {\n+    repositories {\n+        mavenCentral()\n+        maven { url = \"http://files.minecraftforge.net/maven\" }\n+        maven { url = \"https://oss.sonatype.org/content/repositories/snapshots/\" }\n+        jcenter()\n+    }\n+\n+    dependencies {\n+        classpath 'net.minecraftforge.gradle:ForgeGradle:2.1-SNAPSHOT'\n+    }\n+}\n+\n+apply plugin: 'net.minecraftforge.gradle.forge'","path":"worldedit-sponge/build.gradle","position":17,"original_position":17,"commit_id":"7d957081a907833cd9c2d509d3e8960a1c85ef88","original_commit_id":"7d957081a907833cd9c2d509d3e8960a1c85ef88","user":{"login":"DarkArc","id":778012,"avatar_url":"https://avatars.githubusercontent.com/u/778012?v=3","gravatar_id":"","url":"https://api.github.com/users/DarkArc","html_url":"https://github.com/DarkArc","followers_url":"https://api.github.com/users/DarkArc/followers","following_url":"https://api.github.com/users/DarkArc/following{/other_user}","gists_url":"https://api.github.com/users/DarkArc/gists{/gist_id}","starred_url":"https://api.github.com/users/DarkArc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DarkArc/subscriptions","organizations_url":"https://api.github.com/users/DarkArc/orgs","repos_url":"https://api.github.com/users/DarkArc/repos","events_url":"https://api.github.com/users/DarkArc/events{/privacy}","received_events_url":"https://api.github.com/users/DarkArc/received_events","type":"User","site_admin":false},"body":"@wizjany it should be equivalent to using NMS in Bukkit, at that point.","created_at":"2016-03-21T15:00:09Z","updated_at":"2016-03-21T15:00:09Z","html_url":"https://github.com/sk89q/WorldEdit/pull/345#discussion_r56836174","pull_request_url":"https://api.github.com/repos/sk89q/WorldEdit/pulls/345","_links":{"self":{"href":"https://api.github.com/repos/sk89q/WorldEdit/pulls/comments/56836174"},"html":{"href":"https://github.com/sk89q/WorldEdit/pull/345#discussion_r56836174"},"pull_request":{"href":"https://api.github.com/repos/sk89q/WorldEdit/pulls/345"}}},"pull_request":{"url":"https://api.github.com/repos/sk89q/WorldEdit/pulls/345","id":63473914,"html_url":"https://github.com/sk89q/WorldEdit/pull/345","diff_url":"https://github.com/sk89q/WorldEdit/pull/345.diff","patch_url":"https://github.com/sk89q/WorldEdit/pull/345.patch","issue_url":"https://api.github.com/repos/sk89q/WorldEdit/issues/345","number":345,"state":"open","locked":false,"title":"Initial work on WorldEdit Sponge","user":{"login":"DarkArc","id":778012,"avatar_url":"https://avatars.githubusercontent.com/u/778012?v=3","gravatar_id":"","url":"https://api.github.com/users/DarkArc","html_url":"https://github.com/DarkArc","followers_url":"https://api.github.com/users/DarkArc/followers","following_url":"https://api.github.com/users/DarkArc/following{/other_user}","gists_url":"https://api.github.com/users/DarkArc/gists{/gist_id}","starred_url":"https://api.github.com/users/DarkArc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DarkArc/subscriptions","organizations_url":"https://api.github.com/users/DarkArc/orgs","repos_url":"https://api.github.com/users/DarkArc/repos","events_url":"https://api.github.com/users/DarkArc/events{/privacy}","received_events_url":"https://api.github.com/users/DarkArc/received_events","type":"User","site_admin":false},"body":"This is my initial work on making a Sponge API based WorldEdit. \r\n\r\nThis implementation does not try to fully implement purely with the Sponge API, instead this implementation attempts to leverage those parts of the Sponge API which are adequately developed such that WorldEdit can use them. In cases where this is not possible, the implementation tries to find a suitable functionality in SpongeForge, and then drops down to NMS/Forge code.\r\n\r\nThis should be considered an intermediary step in moving fully from Forge to the Sponge API. This is also being done due to some recent issues with WorldEdit and Sponge, where Sponge is attempting to calculate causation for the edits WorldEdit is performing. We can significantly alleviate strain on Sponge based servers by instead providing the cause here while performing our block change operations.\r\n\r\nI should note, I've also made an effort to keep all NMS/SpongeForge code separated from any pure-sponge components. The thought being, checking, and updating a few minor areas will not be as significant of a workload as perusing the entire project for broken code.\r\n\r\nTODO:\r\n- [x] Finish command registration/processing code\r\n- [x] Implement the ID Helper\r\n- [ ] WorldEdit CUI\r\n- [x] Fix the online players cache\r\n- [x] Entity rotation code\r\n- [ ] General cleanup\r\n- [x] Fix some message outputs\r\n- [x] Fix tile entity creation\r\n- [x] Fix entity creation\r\n- [ ] Create a more proper \"Sponge\" configuration\r\n\r\nNote: This PR is purely for centralizing discussion, and as such is setup against forge1.8 instead of master.\r\n\r\nPrevious discussion may be found on #340, due to the merge of feature/forge1.8, the request was automatically closed.","created_at":"2016-03-19T17:48:27Z","updated_at":"2016-03-21T15:00:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef4b6c4b634904104a2e8c039fbd0f00078572d5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sk89q/WorldEdit/pulls/345/commits","review_comments_url":"https://api.github.com/repos/sk89q/WorldEdit/pulls/345/comments","review_comment_url":"https://api.github.com/repos/sk89q/WorldEdit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sk89q/WorldEdit/issues/345/comments","statuses_url":"https://api.github.com/repos/sk89q/WorldEdit/statuses/7d957081a907833cd9c2d509d3e8960a1c85ef88","head":{"label":"sk89q:feature/sponge-new","ref":"feature/sponge-new","sha":"7d957081a907833cd9c2d509d3e8960a1c85ef88","user":{"login":"sk89q","id":38949,"avatar_url":"https://avatars.githubusercontent.com/u/38949?v=3","gravatar_id":"","url":"https://api.github.com/users/sk89q","html_url":"https://github.com/sk89q","followers_url":"https://api.github.com/users/sk89q/followers","following_url":"https://api.github.com/users/sk89q/following{/other_user}","gists_url":"https://api.github.com/users/sk89q/gists{/gist_id}","starred_url":"https://api.github.com/users/sk89q/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sk89q/subscriptions","organizations_url":"https://api.github.com/users/sk89q/orgs","repos_url":"https://api.github.com/users/sk89q/repos","events_url":"https://api.github.com/users/sk89q/events{/privacy}","received_events_url":"https://api.github.com/users/sk89q/received_events","type":"User","site_admin":false},"repo":{"id":944926,"name":"WorldEdit","full_name":"sk89q/WorldEdit","owner":{"login":"sk89q","id":38949,"avatar_url":"https://avatars.githubusercontent.com/u/38949?v=3","gravatar_id":"","url":"https://api.github.com/users/sk89q","html_url":"https://github.com/sk89q","followers_url":"https://api.github.com/users/sk89q/followers","following_url":"https://api.github.com/users/sk89q/following{/other_user}","gists_url":"https://api.github.com/users/sk89q/gists{/gist_id}","starred_url":"https://api.github.com/users/sk89q/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sk89q/subscriptions","organizations_url":"https://api.github.com/users/sk89q/orgs","repos_url":"https://api.github.com/users/sk89q/repos","events_url":"https://api.github.com/users/sk89q/events{/privacy}","received_events_url":"https://api.github.com/users/sk89q/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sk89q/WorldEdit","description":"An in-game voxel map editor for Minecraft","fork":false,"url":"https://api.github.com/repos/sk89q/WorldEdit","forks_url":"https://api.github.com/repos/sk89q/WorldEdit/forks","keys_url":"https://api.github.com/repos/sk89q/WorldEdit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sk89q/WorldEdit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sk89q/WorldEdit/teams","hooks_url":"https://api.github.com/repos/sk89q/WorldEdit/hooks","issue_events_url":"https://api.github.com/repos/sk89q/WorldEdit/issues/events{/number}","events_url":"https://api.github.com/repos/sk89q/WorldEdit/events","assignees_url":"https://api.github.com/repos/sk89q/WorldEdit/assignees{/user}","branches_url":"https://api.github.com/repos/sk89q/WorldEdit/branches{/branch}","tags_url":"https://api.github.com/repos/sk89q/WorldEdit/tags","blobs_url":"https://api.github.com/repos/sk89q/WorldEdit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sk89q/WorldEdit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sk89q/WorldEdit/git/refs{/sha}","trees_url":"https://api.github.com/repos/sk89q/WorldEdit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sk89q/WorldEdit/statuses/{sha}","languages_url":"https://api.github.com/repos/sk89q/WorldEdit/languages","stargazers_url":"https://api.github.com/repos/sk89q/WorldEdit/stargazers","contributors_url":"https://api.github.com/repos/sk89q/WorldEdit/contributors","subscribers_url":"https://api.github.com/repos/sk89q/WorldEdit/subscribers","subscription_url":"https://api.github.com/repos/sk89q/WorldEdit/subscription","commits_url":"https://api.github.com/repos/sk89q/WorldEdit/commits{/sha}","git_commits_url":"https://api.github.com/repos/sk89q/WorldEdit/git/commits{/sha}","comments_url":"https://api.github.com/repos/sk89q/WorldEdit/comments{/number}","issue_comment_url":"https://api.github.com/repos/sk89q/WorldEdit/issues/comments{/number}","contents_url":"https://api.github.com/repos/sk89q/WorldEdit/contents/{+path}","compare_url":"https://api.github.com/repos/sk89q/WorldEdit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sk89q/WorldEdit/merges","archive_url":"https://api.github.com/repos/sk89q/WorldEdit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sk89q/WorldEdit/downloads","issues_url":"https://api.github.com/repos/sk89q/WorldEdit/issues{/number}","pulls_url":"https://api.github.com/repos/sk89q/WorldEdit/pulls{/number}","milestones_url":"https://api.github.com/repos/sk89q/WorldEdit/milestones{/number}","notifications_url":"https://api.github.com/repos/sk89q/WorldEdit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sk89q/WorldEdit/labels{/name}","releases_url":"https://api.github.com/repos/sk89q/WorldEdit/releases{/id}","deployments_url":"https://api.github.com/repos/sk89q/WorldEdit/deployments","created_at":"2010-09-28T08:11:57Z","updated_at":"2016-03-21T09:49:57Z","pushed_at":"2016-03-19T22:43:22Z","git_url":"git://github.com/sk89q/WorldEdit.git","ssh_url":"git@github.com:sk89q/WorldEdit.git","clone_url":"https://github.com/sk89q/WorldEdit.git","svn_url":"https://github.com/sk89q/WorldEdit","homepage":"http://www.enginehub.org/worldedit","size":12729,"stargazers_count":803,"watchers_count":803,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":453,"mirror_url":null,"open_issues_count":16,"forks":453,"open_issues":16,"watchers":803,"default_branch":"master"}},"base":{"label":"sk89q:master","ref":"master","sha":"219d2da0ff5f24d506f5fc62b6caa920fc8485df","user":{"login":"sk89q","id":38949,"avatar_url":"https://avatars.githubusercontent.com/u/38949?v=3","gravatar_id":"","url":"https://api.github.com/users/sk89q","html_url":"https://github.com/sk89q","followers_url":"https://api.github.com/users/sk89q/followers","following_url":"https://api.github.com/users/sk89q/following{/other_user}","gists_url":"https://api.github.com/users/sk89q/gists{/gist_id}","starred_url":"https://api.github.com/users/sk89q/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sk89q/subscriptions","organizations_url":"https://api.github.com/users/sk89q/orgs","repos_url":"https://api.github.com/users/sk89q/repos","events_url":"https://api.github.com/users/sk89q/events{/privacy}","received_events_url":"https://api.github.com/users/sk89q/received_events","type":"User","site_admin":false},"repo":{"id":944926,"name":"WorldEdit","full_name":"sk89q/WorldEdit","owner":{"login":"sk89q","id":38949,"avatar_url":"https://avatars.githubusercontent.com/u/38949?v=3","gravatar_id":"","url":"https://api.github.com/users/sk89q","html_url":"https://github.com/sk89q","followers_url":"https://api.github.com/users/sk89q/followers","following_url":"https://api.github.com/users/sk89q/following{/other_user}","gists_url":"https://api.github.com/users/sk89q/gists{/gist_id}","starred_url":"https://api.github.com/users/sk89q/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sk89q/subscriptions","organizations_url":"https://api.github.com/users/sk89q/orgs","repos_url":"https://api.github.com/users/sk89q/repos","events_url":"https://api.github.com/users/sk89q/events{/privacy}","received_events_url":"https://api.github.com/users/sk89q/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sk89q/WorldEdit","description":"An in-game voxel map editor for Minecraft","fork":false,"url":"https://api.github.com/repos/sk89q/WorldEdit","forks_url":"https://api.github.com/repos/sk89q/WorldEdit/forks","keys_url":"https://api.github.com/repos/sk89q/WorldEdit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sk89q/WorldEdit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sk89q/WorldEdit/teams","hooks_url":"https://api.github.com/repos/sk89q/WorldEdit/hooks","issue_events_url":"https://api.github.com/repos/sk89q/WorldEdit/issues/events{/number}","events_url":"https://api.github.com/repos/sk89q/WorldEdit/events","assignees_url":"https://api.github.com/repos/sk89q/WorldEdit/assignees{/user}","branches_url":"https://api.github.com/repos/sk89q/WorldEdit/branches{/branch}","tags_url":"https://api.github.com/repos/sk89q/WorldEdit/tags","blobs_url":"https://api.github.com/repos/sk89q/WorldEdit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sk89q/WorldEdit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sk89q/WorldEdit/git/refs{/sha}","trees_url":"https://api.github.com/repos/sk89q/WorldEdit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sk89q/WorldEdit/statuses/{sha}","languages_url":"https://api.github.com/repos/sk89q/WorldEdit/languages","stargazers_url":"https://api.github.com/repos/sk89q/WorldEdit/stargazers","contributors_url":"https://api.github.com/repos/sk89q/WorldEdit/contributors","subscribers_url":"https://api.github.com/repos/sk89q/WorldEdit/subscribers","subscription_url":"https://api.github.com/repos/sk89q/WorldEdit/subscription","commits_url":"https://api.github.com/repos/sk89q/WorldEdit/commits{/sha}","git_commits_url":"https://api.github.com/repos/sk89q/WorldEdit/git/commits{/sha}","comments_url":"https://api.github.com/repos/sk89q/WorldEdit/comments{/number}","issue_comment_url":"https://api.github.com/repos/sk89q/WorldEdit/issues/comments{/number}","contents_url":"https://api.github.com/repos/sk89q/WorldEdit/contents/{+path}","compare_url":"https://api.github.com/repos/sk89q/WorldEdit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sk89q/WorldEdit/merges","archive_url":"https://api.github.com/repos/sk89q/WorldEdit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sk89q/WorldEdit/downloads","issues_url":"https://api.github.com/repos/sk89q/WorldEdit/issues{/number}","pulls_url":"https://api.github.com/repos/sk89q/WorldEdit/pulls{/number}","milestones_url":"https://api.github.com/repos/sk89q/WorldEdit/milestones{/number}","notifications_url":"https://api.github.com/repos/sk89q/WorldEdit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sk89q/WorldEdit/labels{/name}","releases_url":"https://api.github.com/repos/sk89q/WorldEdit/releases{/id}","deployments_url":"https://api.github.com/repos/sk89q/WorldEdit/deployments","created_at":"2010-09-28T08:11:57Z","updated_at":"2016-03-21T09:49:57Z","pushed_at":"2016-03-19T22:43:22Z","git_url":"git://github.com/sk89q/WorldEdit.git","ssh_url":"git@github.com:sk89q/WorldEdit.git","clone_url":"https://github.com/sk89q/WorldEdit.git","svn_url":"https://github.com/sk89q/WorldEdit","homepage":"http://www.enginehub.org/worldedit","size":12729,"stargazers_count":803,"watchers_count":803,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":453,"mirror_url":null,"open_issues_count":16,"forks":453,"open_issues":16,"watchers":803,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sk89q/WorldEdit/pulls/345"},"html":{"href":"https://github.com/sk89q/WorldEdit/pull/345"},"issue":{"href":"https://api.github.com/repos/sk89q/WorldEdit/issues/345"},"comments":{"href":"https://api.github.com/repos/sk89q/WorldEdit/issues/345/comments"},"review_comments":{"href":"https://api.github.com/repos/sk89q/WorldEdit/pulls/345/comments"},"review_comment":{"href":"https://api.github.com/repos/sk89q/WorldEdit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sk89q/WorldEdit/pulls/345/commits"},"statuses":{"href":"https://api.github.com/repos/sk89q/WorldEdit/statuses/7d957081a907833cd9c2d509d3e8960a1c85ef88"}}}}