{"action":"created","comment":{"url":"https://api.github.com/repos/stlab/libraries/pulls/comments/69188576","id":69188576,"diff_hunk":"@@ -1042,24 +1047,33 @@ namespace detail\n             , _holds(_remaining)\n         {}\n \n-        std::atomic_size_t                    _remaining{0};\n+        std::atomic_size_t                    _remaining;","path":"stlab/future.hpp","position":76,"original_position":76,"commit_id":"0dc4fda838faa3072f46c1959e9eae2cedd0bdb0","original_commit_id":"0dc4fda838faa3072f46c1959e9eae2cedd0bdb0","user":{"login":"sean-parent","id":2279724,"avatar_url":"https://avatars.githubusercontent.com/u/2279724?v=3","gravatar_id":"","url":"https://api.github.com/users/sean-parent","html_url":"https://github.com/sean-parent","followers_url":"https://api.github.com/users/sean-parent/followers","following_url":"https://api.github.com/users/sean-parent/following{/other_user}","gists_url":"https://api.github.com/users/sean-parent/gists{/gist_id}","starred_url":"https://api.github.com/users/sean-parent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sean-parent/subscriptions","organizations_url":"https://api.github.com/users/sean-parent/orgs","repos_url":"https://api.github.com/users/sean-parent/repos","events_url":"https://api.github.com/users/sean-parent/events{/privacy}","received_events_url":"https://api.github.com/users/sean-parent/received_events","type":"User","site_admin":false},"body":"why remove the initializer? I believe this is no unitialized (the default ctor on atomics are like the default ctors on an int - they don't do anything).","created_at":"2016-06-30T18:48:24Z","updated_at":"2016-06-30T18:48:24Z","html_url":"https://github.com/stlab/libraries/pull/9#discussion_r69188576","pull_request_url":"https://api.github.com/repos/stlab/libraries/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/stlab/libraries/pulls/comments/69188576"},"html":{"href":"https://github.com/stlab/libraries/pull/9#discussion_r69188576"},"pull_request":{"href":"https://api.github.com/repos/stlab/libraries/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/stlab/libraries/pulls/9","id":75718464,"html_url":"https://github.com/stlab/libraries/pull/9","diff_url":"https://github.com/stlab/libraries/pull/9.diff","patch_url":"https://github.com/stlab/libraries/pull/9.patch","issue_url":"https://api.github.com/repos/stlab/libraries/issues/9","number":9,"state":"open","locked":false,"title":"Fixing race condition found by JDurkan.","user":{"login":"FelixPetriconi","id":612377,"avatar_url":"https://avatars.githubusercontent.com/u/612377?v=3","gravatar_id":"","url":"https://api.github.com/users/FelixPetriconi","html_url":"https://github.com/FelixPetriconi","followers_url":"https://api.github.com/users/FelixPetriconi/followers","following_url":"https://api.github.com/users/FelixPetriconi/following{/other_user}","gists_url":"https://api.github.com/users/FelixPetriconi/gists{/gist_id}","starred_url":"https://api.github.com/users/FelixPetriconi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FelixPetriconi/subscriptions","organizations_url":"https://api.github.com/users/FelixPetriconi/orgs","repos_url":"https://api.github.com/users/FelixPetriconi/repos","events_url":"https://api.github.com/users/FelixPetriconi/events{/privacy}","received_events_url":"https://api.github.com/users/FelixPetriconi/received_events","type":"User","site_admin":false},"body":"In this PR three race conditions are fixed. Temporarily the cancel_try() calls are disabled, because they are so far not thread safe.","created_at":"2016-06-29T20:46:43Z","updated_at":"2016-06-30T18:48:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e29b6e31a3cdb9487cc69c9b56d8534feb0c441","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/stlab/libraries/pulls/9/commits","review_comments_url":"https://api.github.com/repos/stlab/libraries/pulls/9/comments","review_comment_url":"https://api.github.com/repos/stlab/libraries/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stlab/libraries/issues/9/comments","statuses_url":"https://api.github.com/repos/stlab/libraries/statuses/0dc4fda838faa3072f46c1959e9eae2cedd0bdb0","head":{"label":"FelixPetriconi:FutureFix","ref":"FutureFix","sha":"0dc4fda838faa3072f46c1959e9eae2cedd0bdb0","user":{"login":"FelixPetriconi","id":612377,"avatar_url":"https://avatars.githubusercontent.com/u/612377?v=3","gravatar_id":"","url":"https://api.github.com/users/FelixPetriconi","html_url":"https://github.com/FelixPetriconi","followers_url":"https://api.github.com/users/FelixPetriconi/followers","following_url":"https://api.github.com/users/FelixPetriconi/following{/other_user}","gists_url":"https://api.github.com/users/FelixPetriconi/gists{/gist_id}","starred_url":"https://api.github.com/users/FelixPetriconi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FelixPetriconi/subscriptions","organizations_url":"https://api.github.com/users/FelixPetriconi/orgs","repos_url":"https://api.github.com/users/FelixPetriconi/repos","events_url":"https://api.github.com/users/FelixPetriconi/events{/privacy}","received_events_url":"https://api.github.com/users/FelixPetriconi/received_events","type":"User","site_admin":false},"repo":{"id":51784606,"name":"libraries","full_name":"FelixPetriconi/libraries","owner":{"login":"FelixPetriconi","id":612377,"avatar_url":"https://avatars.githubusercontent.com/u/612377?v=3","gravatar_id":"","url":"https://api.github.com/users/FelixPetriconi","html_url":"https://github.com/FelixPetriconi","followers_url":"https://api.github.com/users/FelixPetriconi/followers","following_url":"https://api.github.com/users/FelixPetriconi/following{/other_user}","gists_url":"https://api.github.com/users/FelixPetriconi/gists{/gist_id}","starred_url":"https://api.github.com/users/FelixPetriconi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FelixPetriconi/subscriptions","organizations_url":"https://api.github.com/users/FelixPetriconi/orgs","repos_url":"https://api.github.com/users/FelixPetriconi/repos","events_url":"https://api.github.com/users/FelixPetriconi/events{/privacy}","received_events_url":"https://api.github.com/users/FelixPetriconi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/FelixPetriconi/libraries","description":"ASL libraries will be migrated here in the stlab namespace, new libraries will be created here.","fork":true,"url":"https://api.github.com/repos/FelixPetriconi/libraries","forks_url":"https://api.github.com/repos/FelixPetriconi/libraries/forks","keys_url":"https://api.github.com/repos/FelixPetriconi/libraries/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FelixPetriconi/libraries/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FelixPetriconi/libraries/teams","hooks_url":"https://api.github.com/repos/FelixPetriconi/libraries/hooks","issue_events_url":"https://api.github.com/repos/FelixPetriconi/libraries/issues/events{/number}","events_url":"https://api.github.com/repos/FelixPetriconi/libraries/events","assignees_url":"https://api.github.com/repos/FelixPetriconi/libraries/assignees{/user}","branches_url":"https://api.github.com/repos/FelixPetriconi/libraries/branches{/branch}","tags_url":"https://api.github.com/repos/FelixPetriconi/libraries/tags","blobs_url":"https://api.github.com/repos/FelixPetriconi/libraries/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FelixPetriconi/libraries/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FelixPetriconi/libraries/git/refs{/sha}","trees_url":"https://api.github.com/repos/FelixPetriconi/libraries/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FelixPetriconi/libraries/statuses/{sha}","languages_url":"https://api.github.com/repos/FelixPetriconi/libraries/languages","stargazers_url":"https://api.github.com/repos/FelixPetriconi/libraries/stargazers","contributors_url":"https://api.github.com/repos/FelixPetriconi/libraries/contributors","subscribers_url":"https://api.github.com/repos/FelixPetriconi/libraries/subscribers","subscription_url":"https://api.github.com/repos/FelixPetriconi/libraries/subscription","commits_url":"https://api.github.com/repos/FelixPetriconi/libraries/commits{/sha}","git_commits_url":"https://api.github.com/repos/FelixPetriconi/libraries/git/commits{/sha}","comments_url":"https://api.github.com/repos/FelixPetriconi/libraries/comments{/number}","issue_comment_url":"https://api.github.com/repos/FelixPetriconi/libraries/issues/comments{/number}","contents_url":"https://api.github.com/repos/FelixPetriconi/libraries/contents/{+path}","compare_url":"https://api.github.com/repos/FelixPetriconi/libraries/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FelixPetriconi/libraries/merges","archive_url":"https://api.github.com/repos/FelixPetriconi/libraries/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FelixPetriconi/libraries/downloads","issues_url":"https://api.github.com/repos/FelixPetriconi/libraries/issues{/number}","pulls_url":"https://api.github.com/repos/FelixPetriconi/libraries/pulls{/number}","milestones_url":"https://api.github.com/repos/FelixPetriconi/libraries/milestones{/number}","notifications_url":"https://api.github.com/repos/FelixPetriconi/libraries/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FelixPetriconi/libraries/labels{/name}","releases_url":"https://api.github.com/repos/FelixPetriconi/libraries/releases{/id}","deployments_url":"https://api.github.com/repos/FelixPetriconi/libraries/deployments","created_at":"2016-02-15T20:48:39Z","updated_at":"2016-02-15T20:48:39Z","pushed_at":"2016-06-29T20:45:14Z","git_url":"git://github.com/FelixPetriconi/libraries.git","ssh_url":"git@github.com:FelixPetriconi/libraries.git","clone_url":"https://github.com/FelixPetriconi/libraries.git","svn_url":"https://github.com/FelixPetriconi/libraries","homepage":null,"size":179,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"stlab:develop","ref":"develop","sha":"f3d8ed041a5784d763ca5eec1834a60753d13f72","user":{"login":"stlab","id":2448845,"avatar_url":"https://avatars.githubusercontent.com/u/2448845?v=3","gravatar_id":"","url":"https://api.github.com/users/stlab","html_url":"https://github.com/stlab","followers_url":"https://api.github.com/users/stlab/followers","following_url":"https://api.github.com/users/stlab/following{/other_user}","gists_url":"https://api.github.com/users/stlab/gists{/gist_id}","starred_url":"https://api.github.com/users/stlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stlab/subscriptions","organizations_url":"https://api.github.com/users/stlab/orgs","repos_url":"https://api.github.com/users/stlab/repos","events_url":"https://api.github.com/users/stlab/events{/privacy}","received_events_url":"https://api.github.com/users/stlab/received_events","type":"Organization","site_admin":false},"repo":{"id":35681376,"name":"libraries","full_name":"stlab/libraries","owner":{"login":"stlab","id":2448845,"avatar_url":"https://avatars.githubusercontent.com/u/2448845?v=3","gravatar_id":"","url":"https://api.github.com/users/stlab","html_url":"https://github.com/stlab","followers_url":"https://api.github.com/users/stlab/followers","following_url":"https://api.github.com/users/stlab/following{/other_user}","gists_url":"https://api.github.com/users/stlab/gists{/gist_id}","starred_url":"https://api.github.com/users/stlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stlab/subscriptions","organizations_url":"https://api.github.com/users/stlab/orgs","repos_url":"https://api.github.com/users/stlab/repos","events_url":"https://api.github.com/users/stlab/events{/privacy}","received_events_url":"https://api.github.com/users/stlab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stlab/libraries","description":"ASL libraries will be migrated here in the stlab namespace, new libraries will be created here.","fork":false,"url":"https://api.github.com/repos/stlab/libraries","forks_url":"https://api.github.com/repos/stlab/libraries/forks","keys_url":"https://api.github.com/repos/stlab/libraries/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stlab/libraries/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stlab/libraries/teams","hooks_url":"https://api.github.com/repos/stlab/libraries/hooks","issue_events_url":"https://api.github.com/repos/stlab/libraries/issues/events{/number}","events_url":"https://api.github.com/repos/stlab/libraries/events","assignees_url":"https://api.github.com/repos/stlab/libraries/assignees{/user}","branches_url":"https://api.github.com/repos/stlab/libraries/branches{/branch}","tags_url":"https://api.github.com/repos/stlab/libraries/tags","blobs_url":"https://api.github.com/repos/stlab/libraries/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stlab/libraries/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stlab/libraries/git/refs{/sha}","trees_url":"https://api.github.com/repos/stlab/libraries/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stlab/libraries/statuses/{sha}","languages_url":"https://api.github.com/repos/stlab/libraries/languages","stargazers_url":"https://api.github.com/repos/stlab/libraries/stargazers","contributors_url":"https://api.github.com/repos/stlab/libraries/contributors","subscribers_url":"https://api.github.com/repos/stlab/libraries/subscribers","subscription_url":"https://api.github.com/repos/stlab/libraries/subscription","commits_url":"https://api.github.com/repos/stlab/libraries/commits{/sha}","git_commits_url":"https://api.github.com/repos/stlab/libraries/git/commits{/sha}","comments_url":"https://api.github.com/repos/stlab/libraries/comments{/number}","issue_comment_url":"https://api.github.com/repos/stlab/libraries/issues/comments{/number}","contents_url":"https://api.github.com/repos/stlab/libraries/contents/{+path}","compare_url":"https://api.github.com/repos/stlab/libraries/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stlab/libraries/merges","archive_url":"https://api.github.com/repos/stlab/libraries/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stlab/libraries/downloads","issues_url":"https://api.github.com/repos/stlab/libraries/issues{/number}","pulls_url":"https://api.github.com/repos/stlab/libraries/pulls{/number}","milestones_url":"https://api.github.com/repos/stlab/libraries/milestones{/number}","notifications_url":"https://api.github.com/repos/stlab/libraries/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stlab/libraries/labels{/name}","releases_url":"https://api.github.com/repos/stlab/libraries/releases{/id}","deployments_url":"https://api.github.com/repos/stlab/libraries/deployments","created_at":"2015-05-15T15:25:09Z","updated_at":"2016-06-14T17:13:15Z","pushed_at":"2016-06-29T20:46:44Z","git_url":"git://github.com/stlab/libraries.git","ssh_url":"git@github.com:stlab/libraries.git","clone_url":"https://github.com/stlab/libraries.git","svn_url":"https://github.com/stlab/libraries","homepage":null,"size":183,"stargazers_count":54,"watchers_count":54,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":3,"forks":5,"open_issues":3,"watchers":54,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/stlab/libraries/pulls/9"},"html":{"href":"https://github.com/stlab/libraries/pull/9"},"issue":{"href":"https://api.github.com/repos/stlab/libraries/issues/9"},"comments":{"href":"https://api.github.com/repos/stlab/libraries/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/stlab/libraries/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/stlab/libraries/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stlab/libraries/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/stlab/libraries/statuses/0dc4fda838faa3072f46c1959e9eae2cedd0bdb0"}}}}
{"actor":{"display_login":"sean-parent"}}