{"action":"created","issue":{"url":"https://api.github.com/repos/relateiq/soa/issues/24","repository_url":"https://api.github.com/repos/relateiq/soa","labels_url":"https://api.github.com/repos/relateiq/soa/issues/24/labels{/name}","comments_url":"https://api.github.com/repos/relateiq/soa/issues/24/comments","events_url":"https://api.github.com/repos/relateiq/soa/issues/24/events","html_url":"https://github.com/relateiq/soa/pull/24","id":167970607,"number":24,"title":"Jwt shiro","user":{"login":"mjburghoffer","id":2665798,"avatar_url":"https://avatars.githubusercontent.com/u/2665798?v=3","gravatar_id":"","url":"https://api.github.com/users/mjburghoffer","html_url":"https://github.com/mjburghoffer","followers_url":"https://api.github.com/users/mjburghoffer/followers","following_url":"https://api.github.com/users/mjburghoffer/following{/other_user}","gists_url":"https://api.github.com/users/mjburghoffer/gists{/gist_id}","starred_url":"https://api.github.com/users/mjburghoffer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjburghoffer/subscriptions","organizations_url":"https://api.github.com/users/mjburghoffer/orgs","repos_url":"https://api.github.com/users/mjburghoffer/repos","events_url":"https://api.github.com/users/mjburghoffer/events{/privacy}","received_events_url":"https://api.github.com/users/mjburghoffer/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/relateiq/soa/labels/READY%20FOR%20REVIEW","name":"READY FOR REVIEW","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"jontg","id":309263,"avatar_url":"https://avatars.githubusercontent.com/u/309263?v=3","gravatar_id":"","url":"https://api.github.com/users/jontg","html_url":"https://github.com/jontg","followers_url":"https://api.github.com/users/jontg/followers","following_url":"https://api.github.com/users/jontg/following{/other_user}","gists_url":"https://api.github.com/users/jontg/gists{/gist_id}","starred_url":"https://api.github.com/users/jontg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jontg/subscriptions","organizations_url":"https://api.github.com/users/jontg/orgs","repos_url":"https://api.github.com/users/jontg/repos","events_url":"https://api.github.com/users/jontg/events{/privacy}","received_events_url":"https://api.github.com/users/jontg/received_events","type":"User","site_admin":false},"assignees":[{"login":"jontg","id":309263,"avatar_url":"https://avatars.githubusercontent.com/u/309263?v=3","gravatar_id":"","url":"https://api.github.com/users/jontg","html_url":"https://github.com/jontg","followers_url":"https://api.github.com/users/jontg/followers","following_url":"https://api.github.com/users/jontg/following{/other_user}","gists_url":"https://api.github.com/users/jontg/gists{/gist_id}","starred_url":"https://api.github.com/users/jontg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jontg/subscriptions","organizations_url":"https://api.github.com/users/jontg/orgs","repos_url":"https://api.github.com/users/jontg/repos","events_url":"https://api.github.com/users/jontg/events{/privacy}","received_events_url":"https://api.github.com/users/jontg/received_events","type":"User","site_admin":false},{"login":"christydennison","id":1316216,"avatar_url":"https://avatars.githubusercontent.com/u/1316216?v=3","gravatar_id":"","url":"https://api.github.com/users/christydennison","html_url":"https://github.com/christydennison","followers_url":"https://api.github.com/users/christydennison/followers","following_url":"https://api.github.com/users/christydennison/following{/other_user}","gists_url":"https://api.github.com/users/christydennison/gists{/gist_id}","starred_url":"https://api.github.com/users/christydennison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christydennison/subscriptions","organizations_url":"https://api.github.com/users/christydennison/orgs","repos_url":"https://api.github.com/users/christydennison/repos","events_url":"https://api.github.com/users/christydennison/events{/privacy}","received_events_url":"https://api.github.com/users/christydennison/received_events","type":"User","site_admin":false},{"login":"mjburghoffer","id":2665798,"avatar_url":"https://avatars.githubusercontent.com/u/2665798?v=3","gravatar_id":"","url":"https://api.github.com/users/mjburghoffer","html_url":"https://github.com/mjburghoffer","followers_url":"https://api.github.com/users/mjburghoffer/followers","following_url":"https://api.github.com/users/mjburghoffer/following{/other_user}","gists_url":"https://api.github.com/users/mjburghoffer/gists{/gist_id}","starred_url":"https://api.github.com/users/mjburghoffer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjburghoffer/subscriptions","organizations_url":"https://api.github.com/users/mjburghoffer/orgs","repos_url":"https://api.github.com/users/mjburghoffer/repos","events_url":"https://api.github.com/users/mjburghoffer/events{/privacy}","received_events_url":"https://api.github.com/users/mjburghoffer/received_events","type":"User","site_admin":false},{"login":"AndrewWang996","id":6694602,"avatar_url":"https://avatars.githubusercontent.com/u/6694602?v=3","gravatar_id":"","url":"https://api.github.com/users/AndrewWang996","html_url":"https://github.com/AndrewWang996","followers_url":"https://api.github.com/users/AndrewWang996/followers","following_url":"https://api.github.com/users/AndrewWang996/following{/other_user}","gists_url":"https://api.github.com/users/AndrewWang996/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrewWang996/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrewWang996/subscriptions","organizations_url":"https://api.github.com/users/AndrewWang996/orgs","repos_url":"https://api.github.com/users/AndrewWang996/repos","events_url":"https://api.github.com/users/AndrewWang996/events{/privacy}","received_events_url":"https://api.github.com/users/AndrewWang996/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-07-27T22:21:20Z","updated_at":"2016-07-27T22:58:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/relateiq/soa/pulls/24","html_url":"https://github.com/relateiq/soa/pull/24","diff_url":"https://github.com/relateiq/soa/pull/24.diff","patch_url":"https://github.com/relateiq/soa/pull/24.patch"},"body":"Hey guys, this is my first attempt at integrating JWT + Crypter + Shiro.  Shiro in particular is very confusing for me, so please help me review!"},"comment":{"url":"https://api.github.com/repos/relateiq/soa/issues/comments/235747105","html_url":"https://github.com/relateiq/soa/pull/24#issuecomment-235747105","issue_url":"https://api.github.com/repos/relateiq/soa/issues/24","id":235747105,"user":{"login":"relateiq-ec2","id":1441374,"avatar_url":"https://avatars.githubusercontent.com/u/1441374?v=3","gravatar_id":"","url":"https://api.github.com/users/relateiq-ec2","html_url":"https://github.com/relateiq-ec2","followers_url":"https://api.github.com/users/relateiq-ec2/followers","following_url":"https://api.github.com/users/relateiq-ec2/following{/other_user}","gists_url":"https://api.github.com/users/relateiq-ec2/gists{/gist_id}","starred_url":"https://api.github.com/users/relateiq-ec2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/relateiq-ec2/subscriptions","organizations_url":"https://api.github.com/users/relateiq-ec2/orgs","repos_url":"https://api.github.com/users/relateiq-ec2/repos","events_url":"https://api.github.com/users/relateiq-ec2/events{/privacy}","received_events_url":"https://api.github.com/users/relateiq-ec2/received_events","type":"User","site_admin":false},"created_at":"2016-07-27T22:58:22Z","updated_at":"2016-07-27T22:58:22Z","body":"SonarQube analysis reported 18 issues:\n* ![CRITICAL](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-critical.png) 1 critical\n* ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) 1 major\n* ![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) 16 minor\n\nWatch the comments in this conversation to review them.\nNote: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:\n* ![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) [At most one statement is allowed per line, but 2 statements were found on this line.](https://github.com/relateiq/soa/blob/f0ffc48b646ff055040ffe1ac3dca8230bcbb1ae/soa-auth/src/main/java/com/relateiq/soa/auth/jwt/CustomJwtClaims.java#L116) [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://nemo.sonarqube.org/coding_rules#rule_key=squid%3AS00122)\n* ![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) [At most one statement is allowed per line, but 2 statements were found on this line.](https://github.com/relateiq/soa/blob/f0ffc48b646ff055040ffe1ac3dca8230bcbb1ae/soa-auth/src/main/java/com/relateiq/soa/auth/jwt/CustomJwtClaims.java#L115) [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://nemo.sonarqube.org/coding_rules#rule_key=squid%3AS00122)\n* ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation.](https://github.com/relateiq/soa/blob/f0ffc48b646ff055040ffe1ac3dca8230bcbb1ae/soa-auth/src/main/java/com/relateiq/soa/auth/jwt/CustomJwtClaims.java#L21) [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://nemo.sonarqube.org/coding_rules#rule_key=squid%3AS1186)\n"}}
{"actor":{"display_login":"relateiq-ec2"}}