{"action":"created","issue":{"url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/3919","repository_url":"https://api.github.com/repos/Yoast/wordpress-seo","labels_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/3919/labels{/name}","comments_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/3919/comments","events_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/3919/events","html_url":"https://github.com/Yoast/wordpress-seo/issues/3919","id":133060258,"number":3919,"title":"JavaScript call stack overflow problem","user":{"login":"moorscode","id":2005352,"avatar_url":"https://avatars.githubusercontent.com/u/2005352?v=3","gravatar_id":"","url":"https://api.github.com/users/moorscode","html_url":"https://github.com/moorscode","followers_url":"https://api.github.com/users/moorscode/followers","following_url":"https://api.github.com/users/moorscode/following{/other_user}","gists_url":"https://api.github.com/users/moorscode/gists{/gist_id}","starred_url":"https://api.github.com/users/moorscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moorscode/subscriptions","organizations_url":"https://api.github.com/users/moorscode/orgs","repos_url":"https://api.github.com/users/moorscode/repos","events_url":"https://api.github.com/users/moorscode/events{/privacy}","received_events_url":"https://api.github.com/users/moorscode/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Yoast/wordpress-seo/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/Yoast/wordpress-seo/milestones/20","html_url":"https://github.com/Yoast/wordpress-seo/milestones/3.2","labels_url":"https://api.github.com/repos/Yoast/wordpress-seo/milestones/20/labels","id":1404115,"number":20,"title":"3.2","description":"","creator":{"login":"omarreiss","id":1488816,"avatar_url":"https://avatars.githubusercontent.com/u/1488816?v=3","gravatar_id":"","url":"https://api.github.com/users/omarreiss","html_url":"https://github.com/omarreiss","followers_url":"https://api.github.com/users/omarreiss/followers","following_url":"https://api.github.com/users/omarreiss/following{/other_user}","gists_url":"https://api.github.com/users/omarreiss/gists{/gist_id}","starred_url":"https://api.github.com/users/omarreiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omarreiss/subscriptions","organizations_url":"https://api.github.com/users/omarreiss/orgs","repos_url":"https://api.github.com/users/omarreiss/repos","events_url":"https://api.github.com/users/omarreiss/events{/privacy}","received_events_url":"https://api.github.com/users/omarreiss/received_events","type":"User","site_admin":false},"open_issues":34,"closed_issues":1,"state":"open","created_at":"2015-11-10T10:15:34Z","updated_at":"2016-02-11T19:08:02Z","due_on":"2016-04-11T22:00:00Z","closed_at":null},"comments":1,"created_at":"2016-02-11T19:08:02Z","updated_at":"2016-02-11T19:08:26Z","closed_at":null,"body":"The `yst_overrideElemFunction` function replaces the `onclick` of the `#remove-post-thumbnail` element.\r\nThough this function does not check if it has been replaced already.\r\n\r\nThis can trigger the following endless loop:\r\n\r\n**Situation:**\r\n`#remove-post-thumbnail`.onclick = `function_x`\r\n\r\n**Action:**\r\n`removeThumb` = `function_x`\r\n`#remove-post-thumbnail`.onclick = `yst_removeOpengraphWarning`\r\n\r\n**Code is run again:**\r\n`removeThumb` = `yst_removeOpengraphWarning`\r\n`#remove-post-thumbnail`.onclick = `yst_removeOpengraphWarning`\r\n\r\n**`#remove-post-thumbnail` is clicked:**\r\n\r\n`yst_removeOpengraphWarning` internally calls `removeThumb` which points to itself.\r\nResulting in an infinite loop.\r\n\r\n**Solution:**\r\nOnly apply `removeThumb` when it is undefined."},"comment":{"url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/comments/183013623","html_url":"https://github.com/Yoast/wordpress-seo/issues/3919#issuecomment-183013623","issue_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/3919","id":183013623,"user":{"login":"moorscode","id":2005352,"avatar_url":"https://avatars.githubusercontent.com/u/2005352?v=3","gravatar_id":"","url":"https://api.github.com/users/moorscode","html_url":"https://github.com/moorscode","followers_url":"https://api.github.com/users/moorscode/followers","following_url":"https://api.github.com/users/moorscode/following{/other_user}","gists_url":"https://api.github.com/users/moorscode/gists{/gist_id}","starred_url":"https://api.github.com/users/moorscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moorscode/subscriptions","organizations_url":"https://api.github.com/users/moorscode/orgs","repos_url":"https://api.github.com/users/moorscode/repos","events_url":"https://api.github.com/users/moorscode/events{/privacy}","received_events_url":"https://api.github.com/users/moorscode/received_events","type":"User","site_admin":false},"created_at":"2016-02-11T19:08:26Z","updated_at":"2016-02-11T19:08:26Z","body":"@atimmer I found it ;)"}}