{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/contrib/pulls/comments/59141026","id":59141026,"diff_hunk":"@@ -109,6 +109,15 @@ func getLBDetails(kubeClient *unversioned.Client) (*lbInfo, error) {\n \t\treturn nil, fmt.Errorf(\"Unable to get POD information\")\n \t}\n \n+\tif pod.Status.Phase != api.PodRunning {\n+\t\t// we wait up to 30 seconds until the pod is running and\n+\t\t// it is possible to get the IP and name of the node\n+\t\terr := waitForPodRunning(kubeClient, podNs, podName, time.Millisecond*200, time.Second*30)","path":"ingress/controllers/nginx/utils.go","position":23,"original_position":23,"commit_id":"2006518aa01b822a36c8ca72779060e0c3dfb19e","original_commit_id":"2006518aa01b822a36c8ca72779060e0c3dfb19e","user":{"login":"bprashanth","id":10927820,"avatar_url":"https://avatars.githubusercontent.com/u/10927820?v=3","gravatar_id":"","url":"https://api.github.com/users/bprashanth","html_url":"https://github.com/bprashanth","followers_url":"https://api.github.com/users/bprashanth/followers","following_url":"https://api.github.com/users/bprashanth/following{/other_user}","gists_url":"https://api.github.com/users/bprashanth/gists{/gist_id}","starred_url":"https://api.github.com/users/bprashanth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bprashanth/subscriptions","organizations_url":"https://api.github.com/users/bprashanth/orgs","repos_url":"https://api.github.com/users/bprashanth/repos","events_url":"https://api.github.com/users/bprashanth/events{/privacy}","received_events_url":"https://api.github.com/users/bprashanth/received_events","type":"User","site_admin":false},"body":"I think you should either not do it for the mentioned reason, or move it into a generic: getPodDetails function that takes a pod name and returns details only if the pod is running. ","created_at":"2016-04-10T20:38:29Z","updated_at":"2016-04-10T20:38:29Z","html_url":"https://github.com/kubernetes/contrib/pull/707#discussion_r59141026","pull_request_url":"https://api.github.com/repos/kubernetes/contrib/pulls/707","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/comments/59141026"},"html":{"href":"https://github.com/kubernetes/contrib/pull/707#discussion_r59141026"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/707"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/contrib/pulls/707","id":65177664,"html_url":"https://github.com/kubernetes/contrib/pull/707","diff_url":"https://github.com/kubernetes/contrib/pull/707.diff","patch_url":"https://github.com/kubernetes/contrib/pull/707.patch","issue_url":"https://api.github.com/repos/kubernetes/contrib/issues/707","number":707,"state":"open","locked":false,"title":"Allow traffic to default server _ in nginx Ingress controller","user":{"login":"aledbf","id":161571,"avatar_url":"https://avatars.githubusercontent.com/u/161571?v=3","gravatar_id":"","url":"https://api.github.com/users/aledbf","html_url":"https://github.com/aledbf","followers_url":"https://api.github.com/users/aledbf/followers","following_url":"https://api.github.com/users/aledbf/following{/other_user}","gists_url":"https://api.github.com/users/aledbf/gists{/gist_id}","starred_url":"https://api.github.com/users/aledbf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledbf/subscriptions","organizations_url":"https://api.github.com/users/aledbf/orgs","repos_url":"https://api.github.com/users/aledbf/repos","events_url":"https://api.github.com/users/aledbf/events{/privacy}","received_events_url":"https://api.github.com/users/aledbf/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-04-04T16:55:35Z","updated_at":"2016-04-10T20:38:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb0f6d021198946c004b112a6b66460c4307fd47","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/contrib/pulls/707/commits","review_comments_url":"https://api.github.com/repos/kubernetes/contrib/pulls/707/comments","review_comment_url":"https://api.github.com/repos/kubernetes/contrib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/contrib/issues/707/comments","statuses_url":"https://api.github.com/repos/kubernetes/contrib/statuses/2006518aa01b822a36c8ca72779060e0c3dfb19e","head":{"label":"aledbf:default-server","ref":"default-server","sha":"2006518aa01b822a36c8ca72779060e0c3dfb19e","user":{"login":"aledbf","id":161571,"avatar_url":"https://avatars.githubusercontent.com/u/161571?v=3","gravatar_id":"","url":"https://api.github.com/users/aledbf","html_url":"https://github.com/aledbf","followers_url":"https://api.github.com/users/aledbf/followers","following_url":"https://api.github.com/users/aledbf/following{/other_user}","gists_url":"https://api.github.com/users/aledbf/gists{/gist_id}","starred_url":"https://api.github.com/users/aledbf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledbf/subscriptions","organizations_url":"https://api.github.com/users/aledbf/orgs","repos_url":"https://api.github.com/users/aledbf/repos","events_url":"https://api.github.com/users/aledbf/events{/privacy}","received_events_url":"https://api.github.com/users/aledbf/received_events","type":"User","site_admin":false},"repo":{"id":42607552,"name":"contrib","full_name":"aledbf/contrib","owner":{"login":"aledbf","id":161571,"avatar_url":"https://avatars.githubusercontent.com/u/161571?v=3","gravatar_id":"","url":"https://api.github.com/users/aledbf","html_url":"https://github.com/aledbf","followers_url":"https://api.github.com/users/aledbf/followers","following_url":"https://api.github.com/users/aledbf/following{/other_user}","gists_url":"https://api.github.com/users/aledbf/gists{/gist_id}","starred_url":"https://api.github.com/users/aledbf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledbf/subscriptions","organizations_url":"https://api.github.com/users/aledbf/orgs","repos_url":"https://api.github.com/users/aledbf/repos","events_url":"https://api.github.com/users/aledbf/events{/privacy}","received_events_url":"https://api.github.com/users/aledbf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aledbf/contrib","description":"This is a place for various components in the Kubernetes ecosystem that aren't part of the Kubernetes core.","fork":true,"url":"https://api.github.com/repos/aledbf/contrib","forks_url":"https://api.github.com/repos/aledbf/contrib/forks","keys_url":"https://api.github.com/repos/aledbf/contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aledbf/contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aledbf/contrib/teams","hooks_url":"https://api.github.com/repos/aledbf/contrib/hooks","issue_events_url":"https://api.github.com/repos/aledbf/contrib/issues/events{/number}","events_url":"https://api.github.com/repos/aledbf/contrib/events","assignees_url":"https://api.github.com/repos/aledbf/contrib/assignees{/user}","branches_url":"https://api.github.com/repos/aledbf/contrib/branches{/branch}","tags_url":"https://api.github.com/repos/aledbf/contrib/tags","blobs_url":"https://api.github.com/repos/aledbf/contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aledbf/contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aledbf/contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/aledbf/contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aledbf/contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/aledbf/contrib/languages","stargazers_url":"https://api.github.com/repos/aledbf/contrib/stargazers","contributors_url":"https://api.github.com/repos/aledbf/contrib/contributors","subscribers_url":"https://api.github.com/repos/aledbf/contrib/subscribers","subscription_url":"https://api.github.com/repos/aledbf/contrib/subscription","commits_url":"https://api.github.com/repos/aledbf/contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/aledbf/contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/aledbf/contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/aledbf/contrib/issues/comments{/number}","contents_url":"https://api.github.com/repos/aledbf/contrib/contents/{+path}","compare_url":"https://api.github.com/repos/aledbf/contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aledbf/contrib/merges","archive_url":"https://api.github.com/repos/aledbf/contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aledbf/contrib/downloads","issues_url":"https://api.github.com/repos/aledbf/contrib/issues{/number}","pulls_url":"https://api.github.com/repos/aledbf/contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/aledbf/contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/aledbf/contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aledbf/contrib/labels{/name}","releases_url":"https://api.github.com/repos/aledbf/contrib/releases{/id}","deployments_url":"https://api.github.com/repos/aledbf/contrib/deployments","created_at":"2015-09-16T19:04:49Z","updated_at":"2016-01-11T19:27:11Z","pushed_at":"2016-04-10T14:41:34Z","git_url":"git://github.com/aledbf/contrib.git","ssh_url":"git@github.com:aledbf/contrib.git","clone_url":"https://github.com/aledbf/contrib.git","svn_url":"https://github.com/aledbf/contrib","homepage":"","size":24746,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"80799558393878b609e46fcca13132a10040cb6a","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":40686014,"name":"contrib","full_name":"kubernetes/contrib","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/contrib","description":"This is a place for various components in the Kubernetes ecosystem that aren't part of the Kubernetes core.","fork":false,"url":"https://api.github.com/repos/kubernetes/contrib","forks_url":"https://api.github.com/repos/kubernetes/contrib/forks","keys_url":"https://api.github.com/repos/kubernetes/contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/contrib/teams","hooks_url":"https://api.github.com/repos/kubernetes/contrib/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/contrib/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/contrib/events","assignees_url":"https://api.github.com/repos/kubernetes/contrib/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/contrib/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/contrib/tags","blobs_url":"https://api.github.com/repos/kubernetes/contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/contrib/languages","stargazers_url":"https://api.github.com/repos/kubernetes/contrib/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/contrib/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/contrib/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/contrib/subscription","commits_url":"https://api.github.com/repos/kubernetes/contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/contrib/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/contrib/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/contrib/merges","archive_url":"https://api.github.com/repos/kubernetes/contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/contrib/downloads","issues_url":"https://api.github.com/repos/kubernetes/contrib/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/contrib/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/contrib/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/contrib/deployments","created_at":"2015-08-13T23:18:26Z","updated_at":"2016-04-09T14:30:52Z","pushed_at":"2016-04-10T14:41:35Z","git_url":"git://github.com/kubernetes/contrib.git","ssh_url":"git@github.com:kubernetes/contrib.git","clone_url":"https://github.com/kubernetes/contrib.git","svn_url":"https://github.com/kubernetes/contrib","homepage":"","size":40387,"stargazers_count":228,"watchers_count":228,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":206,"mirror_url":null,"open_issues_count":159,"forks":206,"open_issues":159,"watchers":228,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/707"},"html":{"href":"https://github.com/kubernetes/contrib/pull/707"},"issue":{"href":"https://api.github.com/repos/kubernetes/contrib/issues/707"},"comments":{"href":"https://api.github.com/repos/kubernetes/contrib/issues/707/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/707/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/707/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/contrib/statuses/2006518aa01b822a36c8ca72779060e0c3dfb19e"}}}}