{"action":"created","comment":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments/92927843","pull_request_review_id":13452015,"id":92927843,"diff_hunk":"@@ -90,76 +73,24 @@ typedef bmpl::vector<\n     current<UsedParticleCurrentSolver>,\n     massRatio<MassRatioElectrons>,\n     chargeRatio<ChargeRatioElectrons>\n-> ParticleFlagsElectrons;\n+>;\n \n-/*define specie electrons*/\n-typedef Particles<\n+/* define species electrons */\n+using PIC_Electrons = Particles<\n     bmpl::string<'e'>,\n-    DefaultAttributesSeq,\n+    DefaultParticleAttributes,\n     ParticleFlagsElectrons\n-> PIC_Electrons;\n-\n-/*--------------------------- ions -------------------------------------------*/\n-\n-/* ratio relative to BASE_CHARGE and BASE_MASS */\n-//value_identifier(float_X, MassRatioIons, 1836.152672);\n-//value_identifier(float_X, ChargeRatioIons, -1.0);\n-\n-/*! Specify (chemical) element\n- *\n- * Proton and neutron numbers define the chemical element that the ion species\n- * is based on. This value can be non-integer for physical models taking\n- * charge shielding effects into account.\n- * @see http://en.wikipedia.org/wiki/Effective_nuclear_charge\n- *\n- * It is wrapped into a struct because of C++ restricting floats from being\n- * template arguments.\n- *\n- * Do not forget to set the correct mass of the atom in\n- * @see physicalConstants.param !\n- */\n-//struct Hydrogen\n-//{\n-//    static constexpr float_X numberOfProtons  = 1.0;\n-//    static constexpr float_X numberOfNeutrons = 0.0;\n-//};\n-\n-/*! Ionization Model Configuration ----------------------------------------\n- *\n- * - None : no particle is ionized\n- * - BSIHydrogenLike : simple barrier suppression ionization\n- * - ADKLinPol : Ammosov-Delone-Krainov tunneling ionization (H-like)\n- *               -> linearly polarized lasers\n- * - ADKCircPol : Ammosov-Delone-Krainov tunneling ionization (H-like)\n- *                -> circularly polarized lasers\n- * - Keldysh : Keldysh ionization model\n- *\n- * Research and development: ----------------------------------------------\n- * - BSIEffectiveZ : BSI taking electron shielding into account via an effective\n- *                   atomic number Z_eff\n- * - BSIStarkShifted : BSI for hydrogen-like atoms and ions considering the\n- *                     Stark upshift of ionization potentials\n- *\n- * Usage: Add a flag to the list of particle flags that has the following structure\n- *\n- *        ionizer<IonizationModel<Species2BCreated> >\n- */\n+>;\n \n /*########################### end species ####################################*/\n \n-\n-/*! we delete this ugly definition of VectorAllSpecies after all picongpu components\n- * support multi species */\n-/** \\todo: not nice, but this should be changed in the future*/\n-typedef MakeSeq<\n+using VectorAllSpecies = MakeSeq_t<\n+    MakeSeq_t<","path":"examples/SingleParticleTest/include/simulation_defines/param/speciesDefinition.param","position":129,"original_position":129,"commit_id":"c7ac08a29cd288504de585ca57610d1bb31e5ca0","original_commit_id":"c7ac08a29cd288504de585ca57610d1bb31e5ca0","user":{"login":"psychocoderHPC","id":4037125,"avatar_url":"https://avatars.githubusercontent.com/u/4037125?v=3","gravatar_id":"","url":"https://api.github.com/users/psychocoderHPC","html_url":"https://github.com/psychocoderHPC","followers_url":"https://api.github.com/users/psychocoderHPC/followers","following_url":"https://api.github.com/users/psychocoderHPC/following{/other_user}","gists_url":"https://api.github.com/users/psychocoderHPC/gists{/gist_id}","starred_url":"https://api.github.com/users/psychocoderHPC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psychocoderHPC/subscriptions","organizations_url":"https://api.github.com/users/psychocoderHPC/orgs","repos_url":"https://api.github.com/users/psychocoderHPC/repos","events_url":"https://api.github.com/users/psychocoderHPC/events{/privacy}","received_events_url":"https://api.github.com/users/psychocoderHPC/received_events","type":"User","site_admin":false},"body":"Please remove one `MakeSeq_t`","created_at":"2016-12-17T19:49:58Z","updated_at":"2016-12-17T19:55:33Z","html_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/1709#discussion_r92927843","pull_request_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/1709","_links":{"self":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments/92927843"},"html":{"href":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/1709#discussion_r92927843"},"pull_request":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/1709"}}},"pull_request":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/1709","id":98352959,"html_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/1709","diff_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/1709.diff","patch_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/1709.patch","issue_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/1709","number":1709,"state":"open","locked":false,"title":"Param: Type List Syntax","user":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=3","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"body":"Use a more natural `using Sequence = MakeSeq_t< 1, 2, 3 >;` syntax for user input of type lists via `MakeSeq_t` and C++11 `using`.\r\n\r\nAvoids boiler plate code without `=` and additional `::type` access:\r\n`typedef Seq< 1, 2, 3 >::type List;`\r\n\r\nCleaned up syntax of `speciesDefinition` on the way.","created_at":"2016-12-16T15:27:46Z","updated_at":"2016-12-17T19:55:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a570f5f3eca3e76167f8f74a93ecc3c4c8e6537e","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/milestones/4","html_url":"https://github.com/ComputationalRadiationPhysics/picongpu/milestone/4","labels_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/milestones/4/labels","id":499533,"number":4,"title":"Next Stable: 0.3.0 / 1.0.0","description":"Next Milestones after the Beta (0.2.0) release.\r\n\r\nPossible Topics:\r\n- C++11 refactoring\r\n- Better Support for Laser Ion Acceleration\r\n- More in Situ Analysis\r\n- More TBA","creator":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=3","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"open_issues":71,"closed_issues":68,"state":"open","created_at":"2013-11-28T08:56:45Z","updated_at":"2016-12-17T19:41:03Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/1709/commits","review_comments_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/1709/comments","review_comment_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/1709/comments","statuses_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/statuses/c7ac08a29cd288504de585ca57610d1bb31e5ca0","head":{"label":"ax3l:topic-paramTypeListSyntax","ref":"topic-paramTypeListSyntax","sha":"c7ac08a29cd288504de585ca57610d1bb31e5ca0","user":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=3","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"repo":{"id":12108745,"name":"picongpu","full_name":"ax3l/picongpu","owner":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=3","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ax3l/picongpu","description":"PIConGPU - A particle-in-cell code for GPGPUs","fork":true,"url":"https://api.github.com/repos/ax3l/picongpu","forks_url":"https://api.github.com/repos/ax3l/picongpu/forks","keys_url":"https://api.github.com/repos/ax3l/picongpu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ax3l/picongpu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ax3l/picongpu/teams","hooks_url":"https://api.github.com/repos/ax3l/picongpu/hooks","issue_events_url":"https://api.github.com/repos/ax3l/picongpu/issues/events{/number}","events_url":"https://api.github.com/repos/ax3l/picongpu/events","assignees_url":"https://api.github.com/repos/ax3l/picongpu/assignees{/user}","branches_url":"https://api.github.com/repos/ax3l/picongpu/branches{/branch}","tags_url":"https://api.github.com/repos/ax3l/picongpu/tags","blobs_url":"https://api.github.com/repos/ax3l/picongpu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ax3l/picongpu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ax3l/picongpu/git/refs{/sha}","trees_url":"https://api.github.com/repos/ax3l/picongpu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ax3l/picongpu/statuses/{sha}","languages_url":"https://api.github.com/repos/ax3l/picongpu/languages","stargazers_url":"https://api.github.com/repos/ax3l/picongpu/stargazers","contributors_url":"https://api.github.com/repos/ax3l/picongpu/contributors","subscribers_url":"https://api.github.com/repos/ax3l/picongpu/subscribers","subscription_url":"https://api.github.com/repos/ax3l/picongpu/subscription","commits_url":"https://api.github.com/repos/ax3l/picongpu/commits{/sha}","git_commits_url":"https://api.github.com/repos/ax3l/picongpu/git/commits{/sha}","comments_url":"https://api.github.com/repos/ax3l/picongpu/comments{/number}","issue_comment_url":"https://api.github.com/repos/ax3l/picongpu/issues/comments{/number}","contents_url":"https://api.github.com/repos/ax3l/picongpu/contents/{+path}","compare_url":"https://api.github.com/repos/ax3l/picongpu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ax3l/picongpu/merges","archive_url":"https://api.github.com/repos/ax3l/picongpu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ax3l/picongpu/downloads","issues_url":"https://api.github.com/repos/ax3l/picongpu/issues{/number}","pulls_url":"https://api.github.com/repos/ax3l/picongpu/pulls{/number}","milestones_url":"https://api.github.com/repos/ax3l/picongpu/milestones{/number}","notifications_url":"https://api.github.com/repos/ax3l/picongpu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ax3l/picongpu/labels{/name}","releases_url":"https://api.github.com/repos/ax3l/picongpu/releases{/id}","deployments_url":"https://api.github.com/repos/ax3l/picongpu/deployments","created_at":"2013-08-14T12:51:14Z","updated_at":"2015-09-28T23:54:47Z","pushed_at":"2016-12-17T12:43:59Z","git_url":"git://github.com/ax3l/picongpu.git","ssh_url":"git@github.com:ax3l/picongpu.git","clone_url":"https://github.com/ax3l/picongpu.git","svn_url":"https://github.com/ax3l/picongpu","homepage":"http://picongpu.hzdr.de","size":12277,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"ComputationalRadiationPhysics:dev","ref":"dev","sha":"2505743ee1183fe5d0cbdce1eb5975617dcbd780","user":{"login":"ComputationalRadiationPhysics","id":5120388,"avatar_url":"https://avatars.githubusercontent.com/u/5120388?v=3","gravatar_id":"","url":"https://api.github.com/users/ComputationalRadiationPhysics","html_url":"https://github.com/ComputationalRadiationPhysics","followers_url":"https://api.github.com/users/ComputationalRadiationPhysics/followers","following_url":"https://api.github.com/users/ComputationalRadiationPhysics/following{/other_user}","gists_url":"https://api.github.com/users/ComputationalRadiationPhysics/gists{/gist_id}","starred_url":"https://api.github.com/users/ComputationalRadiationPhysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ComputationalRadiationPhysics/subscriptions","organizations_url":"https://api.github.com/users/ComputationalRadiationPhysics/orgs","repos_url":"https://api.github.com/users/ComputationalRadiationPhysics/repos","events_url":"https://api.github.com/users/ComputationalRadiationPhysics/events{/privacy}","received_events_url":"https://api.github.com/users/ComputationalRadiationPhysics/received_events","type":"Organization","site_admin":false},"repo":{"id":11764461,"name":"picongpu","full_name":"ComputationalRadiationPhysics/picongpu","owner":{"login":"ComputationalRadiationPhysics","id":5120388,"avatar_url":"https://avatars.githubusercontent.com/u/5120388?v=3","gravatar_id":"","url":"https://api.github.com/users/ComputationalRadiationPhysics","html_url":"https://github.com/ComputationalRadiationPhysics","followers_url":"https://api.github.com/users/ComputationalRadiationPhysics/followers","following_url":"https://api.github.com/users/ComputationalRadiationPhysics/following{/other_user}","gists_url":"https://api.github.com/users/ComputationalRadiationPhysics/gists{/gist_id}","starred_url":"https://api.github.com/users/ComputationalRadiationPhysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ComputationalRadiationPhysics/subscriptions","organizations_url":"https://api.github.com/users/ComputationalRadiationPhysics/orgs","repos_url":"https://api.github.com/users/ComputationalRadiationPhysics/repos","events_url":"https://api.github.com/users/ComputationalRadiationPhysics/events{/privacy}","received_events_url":"https://api.github.com/users/ComputationalRadiationPhysics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ComputationalRadiationPhysics/picongpu","description":"PIConGPU - A particle-in-cell code for GPGPUs :sparkles:","fork":false,"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu","forks_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/forks","keys_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/teams","hooks_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/hooks","issue_events_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/events{/number}","events_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/events","assignees_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/assignees{/user}","branches_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/branches{/branch}","tags_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/tags","blobs_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/refs{/sha}","trees_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/statuses/{sha}","languages_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/languages","stargazers_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/stargazers","contributors_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/contributors","subscribers_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/subscribers","subscription_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/subscription","commits_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/commits{/sha}","git_commits_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/commits{/sha}","comments_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/comments{/number}","issue_comment_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/comments{/number}","contents_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/contents/{+path}","compare_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/merges","archive_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/downloads","issues_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues{/number}","pulls_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls{/number}","milestones_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/milestones{/number}","notifications_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/labels{/name}","releases_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/releases{/id}","deployments_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/deployments","created_at":"2013-07-30T12:28:20Z","updated_at":"2016-12-17T10:25:10Z","pushed_at":"2016-12-17T19:41:03Z","git_url":"git://github.com/ComputationalRadiationPhysics/picongpu.git","ssh_url":"git@github.com:ComputationalRadiationPhysics/picongpu.git","clone_url":"https://github.com/ComputationalRadiationPhysics/picongpu.git","svn_url":"https://github.com/ComputationalRadiationPhysics/picongpu","homepage":"http://picongpu.hzdr.de","size":12006,"stargazers_count":207,"watchers_count":207,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":94,"mirror_url":null,"open_issues_count":246,"forks":94,"open_issues":246,"watchers":207,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/1709"},"html":{"href":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/1709"},"issue":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/1709"},"comments":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/1709/comments"},"review_comments":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/1709/comments"},"review_comment":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/1709/commits"},"statuses":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/statuses/c7ac08a29cd288504de585ca57610d1bb31e5ca0"}}}}
{"actor":{"display_login":"psychocoderHPC"}}