{"action":"created","issue":{"url":"https://api.github.com/repos/square/p2/issues/723","repository_url":"https://api.github.com/repos/square/p2","labels_url":"https://api.github.com/repos/square/p2/issues/723/labels{/name}","comments_url":"https://api.github.com/repos/square/p2/issues/723/comments","events_url":"https://api.github.com/repos/square/p2/issues/723/events","html_url":"https://github.com/square/p2/pull/723","id":196822583,"number":723,"title":"Mpuncel/unified storage","user":{"login":"mpuncel","id":1444855,"avatar_url":"https://avatars.githubusercontent.com/u/1444855?v=3","gravatar_id":"","url":"https://api.github.com/users/mpuncel","html_url":"https://github.com/mpuncel","followers_url":"https://api.github.com/users/mpuncel/followers","following_url":"https://api.github.com/users/mpuncel/following{/other_user}","gists_url":"https://api.github.com/users/mpuncel/gists{/gist_id}","starred_url":"https://api.github.com/users/mpuncel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpuncel/subscriptions","organizations_url":"https://api.github.com/users/mpuncel/orgs","repos_url":"https://api.github.com/users/mpuncel/repos","events_url":"https://api.github.com/users/mpuncel/events{/privacy}","received_events_url":"https://api.github.com/users/mpuncel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-12-21T01:18:58Z","updated_at":"2016-12-22T18:12:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/square/p2/pulls/723","html_url":"https://github.com/square/p2/pull/723","diff_url":"https://github.com/square/p2/pull/723.diff","patch_url":"https://github.com/square/p2/pull/723.patch"},"body":"This is the beginning of what will be a long effort to decouple P2 from the storage semantics of Consul. The idea is resurrected from https://github.com/square/p2/pull/399\r\n\r\nThis PR moves 3 types into a new package `pkg/store`: `RollingUpdate`, `ReplicationController` and `Manifest`.\r\n\r\nCode behavior should be unchanged, only import paths, type names and in some cases variable names where there were conflicts were changed.\r\n\r\nI will add commits to this PR but each commit passes all tests and is incremental, so if a reviewer jumps in and approves it i'll merge it (if others think this is acceptable of course)."},"comment":{"url":"https://api.github.com/repos/square/p2/issues/comments/268857718","html_url":"https://github.com/square/p2/pull/723#issuecomment-268857718","issue_url":"https://api.github.com/repos/square/p2/issues/723","id":268857718,"user":{"login":"rudle","id":41385,"avatar_url":"https://avatars.githubusercontent.com/u/41385?v=3","gravatar_id":"","url":"https://api.github.com/users/rudle","html_url":"https://github.com/rudle","followers_url":"https://api.github.com/users/rudle/followers","following_url":"https://api.github.com/users/rudle/following{/other_user}","gists_url":"https://api.github.com/users/rudle/gists{/gist_id}","starred_url":"https://api.github.com/users/rudle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rudle/subscriptions","organizations_url":"https://api.github.com/users/rudle/orgs","repos_url":"https://api.github.com/users/rudle/repos","events_url":"https://api.github.com/users/rudle/events{/privacy}","received_events_url":"https://api.github.com/users/rudle/received_events","type":"User","site_admin":false},"created_at":"2016-12-22T18:12:46Z","updated_at":"2016-12-22T18:12:46Z","body":"What about a compromise? When you move `types.go` into this package, can you also move the type definitions from the rest of the files into that one? That will make it easy to extract if we need to in the future."}}
{"actor":{"display_login":"rudle"}}