{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/74843720","id":74843720,"diff_hunk":"@@ -49,7 +51,8 @@ Examples:\n {{end}}{{end}}{{ if or $visibleFlags.HasFlags $explicitlyExposedFlags.HasFlags}}\n Options:\n {{ if $visibleFlags.HasFlags}}{{flagsUsages $visibleFlags}}{{end}}{{ if $explicitlyExposedFlags.HasFlags}}{{flagsUsages $explicitlyExposedFlags}}{{end}}{{end}}{{ if .HasSubCommands }}\n-Use \"{{$rootCmd}} <command> --help\" for more information about a given command.{{end}}{{ if $optionsCmdFor}}\n+Use \"{{$rootCmd}} <command> --help\" for more information about a given command.{{end}}\n+{{ if $optionsCmdFor}}{{ if $hasContainerOption}}Use \"{{$describeCmdFor}} POD\" to obtain container name values for that pod.{{end}}","path":"pkg/cmd/templates/templates.go","position":null,"original_position":15,"commit_id":"94d306f1ec15b5263603c81c7c5554b1038e9293","original_commit_id":"3158bcbaf5069c133c6816aa05705e674e3dab0b","user":{"login":"juanvallejo","id":3902875,"avatar_url":"https://avatars.githubusercontent.com/u/3902875?v=3","gravatar_id":"","url":"https://api.github.com/users/juanvallejo","html_url":"https://github.com/juanvallejo","followers_url":"https://api.github.com/users/juanvallejo/followers","following_url":"https://api.github.com/users/juanvallejo/following{/other_user}","gists_url":"https://api.github.com/users/juanvallejo/gists{/gist_id}","starred_url":"https://api.github.com/users/juanvallejo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanvallejo/subscriptions","organizations_url":"https://api.github.com/users/juanvallejo/orgs","repos_url":"https://api.github.com/users/juanvallejo/repos","events_url":"https://api.github.com/users/juanvallejo/events{/privacy}","received_events_url":"https://api.github.com/users/juanvallejo/received_events","type":"User","site_admin":false},"body":"Thanks! I went ahead and added the linebreak after the `if` statement for `$hasContainerOption` so that it still adds a linebreak in cases like `oc exec -h`, but not extra lines elsewhere","created_at":"2016-08-15T22:02:01Z","updated_at":"2016-08-15T22:02:01Z","html_url":"https://github.com/openshift/origin/pull/10360#discussion_r74843720","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/10360","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/74843720"},"html":{"href":"https://github.com/openshift/origin/pull/10360#discussion_r74843720"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/10360"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/10360","id":80994466,"html_url":"https://github.com/openshift/origin/pull/10360","diff_url":"https://github.com/openshift/origin/pull/10360.diff","patch_url":"https://github.com/openshift/origin/pull/10360.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/10360","number":10360,"state":"open","locked":false,"title":"add suggestion to use `describe` to obtain container names","user":{"login":"juanvallejo","id":3902875,"avatar_url":"https://avatars.githubusercontent.com/u/3902875?v=3","gravatar_id":"","url":"https://api.github.com/users/juanvallejo","html_url":"https://github.com/juanvallejo","followers_url":"https://api.github.com/users/juanvallejo/followers","following_url":"https://api.github.com/users/juanvallejo/following{/other_user}","gists_url":"https://api.github.com/users/juanvallejo/gists{/gist_id}","starred_url":"https://api.github.com/users/juanvallejo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanvallejo/subscriptions","organizations_url":"https://api.github.com/users/juanvallejo/orgs","repos_url":"https://api.github.com/users/juanvallejo/repos","events_url":"https://api.github.com/users/juanvallejo/events{/privacy}","received_events_url":"https://api.github.com/users/juanvallejo/received_events","type":"User","site_admin":false},"body":"Fixes #10283\r\n\r\nCommands with the `--container=` option provide no suggestions to a user\r\non how to obtain a container's name from a pod.\r\n\r\nThis patch adds a suggestion on the usage output to use the `describe`\r\ncommand on a pod to obtain the container value that is passed to the\r\n`--container=` flag.\r\n\r\n##### After\r\n`$ oc exec -h`\r\n```\r\nExecute a command in a container\r\n\r\nUsage:\r\n  oc exec [options] POD [-c CONTAINER] -- COMMAND [args...]\r\n\r\nExamples:\r\n  # Get output from running 'date' in ruby-container from pod 'mypod'\r\n  oc exec mypod -c ruby-container date\r\n\r\n  # Switch to raw terminal mode, sends stdin to 'bash' in ruby-container from pod 'mypod' and sends stdout/stderr from 'bash' back to the client\r\n  oc exec mypod -c ruby-container -i -t -- bash -il\r\n\r\nOptions:\r\n  -c, --container='': Container name. If omitted, the first container in the pod will be chosen\r\n  -p, --pod='': Pod name (deprecated)\r\n  -i, --stdin=false: Pass stdin to the container\r\n  -t, --tty=false: Stdin is a TTY\r\n\r\n\r\nUse \"oc describe POD\" to obtain container name values for a pod.\r\nUse \"oc options\" for a list of global command-line options (applies to all commands).\r\n```\r\n\r\n##### Commands affected\r\n- `oc rsh -h`\r\n- `oc rsync -h`\r\n- `oc exec -h`\r\n- `oc debug -h`\r\n- `oc attach -h`\r\n- `oc logs -h`\r\n- `openshift kube logs -h`\r\n- `openshift kube rolling-update -h`\r\n- `openshift kube attach -h`\r\n- `openshift kube exec -h`\r\n\r\ncc @fabianofranz ","created_at":"2016-08-11T17:09:31Z","updated_at":"2016-08-15T22:02:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e742fbbd81b6a04aa36132c65987a7cc237a1b34","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/10360/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/10360/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/10360/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/94d306f1ec15b5263603c81c7c5554b1038e9293","head":{"label":"juanvallejo:jvallejo_add-oc-describe-suggestion-oc-exec-help","ref":"jvallejo_add-oc-describe-suggestion-oc-exec-help","sha":"94d306f1ec15b5263603c81c7c5554b1038e9293","user":{"login":"juanvallejo","id":3902875,"avatar_url":"https://avatars.githubusercontent.com/u/3902875?v=3","gravatar_id":"","url":"https://api.github.com/users/juanvallejo","html_url":"https://github.com/juanvallejo","followers_url":"https://api.github.com/users/juanvallejo/followers","following_url":"https://api.github.com/users/juanvallejo/following{/other_user}","gists_url":"https://api.github.com/users/juanvallejo/gists{/gist_id}","starred_url":"https://api.github.com/users/juanvallejo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanvallejo/subscriptions","organizations_url":"https://api.github.com/users/juanvallejo/orgs","repos_url":"https://api.github.com/users/juanvallejo/repos","events_url":"https://api.github.com/users/juanvallejo/events{/privacy}","received_events_url":"https://api.github.com/users/juanvallejo/received_events","type":"User","site_admin":false},"repo":{"id":50698131,"name":"origin","full_name":"juanvallejo/origin","owner":{"login":"juanvallejo","id":3902875,"avatar_url":"https://avatars.githubusercontent.com/u/3902875?v=3","gravatar_id":"","url":"https://api.github.com/users/juanvallejo","html_url":"https://github.com/juanvallejo","followers_url":"https://api.github.com/users/juanvallejo/followers","following_url":"https://api.github.com/users/juanvallejo/following{/other_user}","gists_url":"https://api.github.com/users/juanvallejo/gists{/gist_id}","starred_url":"https://api.github.com/users/juanvallejo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanvallejo/subscriptions","organizations_url":"https://api.github.com/users/juanvallejo/orgs","repos_url":"https://api.github.com/users/juanvallejo/repos","events_url":"https://api.github.com/users/juanvallejo/events{/privacy}","received_events_url":"https://api.github.com/users/juanvallejo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/juanvallejo/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/juanvallejo/origin","forks_url":"https://api.github.com/repos/juanvallejo/origin/forks","keys_url":"https://api.github.com/repos/juanvallejo/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juanvallejo/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juanvallejo/origin/teams","hooks_url":"https://api.github.com/repos/juanvallejo/origin/hooks","issue_events_url":"https://api.github.com/repos/juanvallejo/origin/issues/events{/number}","events_url":"https://api.github.com/repos/juanvallejo/origin/events","assignees_url":"https://api.github.com/repos/juanvallejo/origin/assignees{/user}","branches_url":"https://api.github.com/repos/juanvallejo/origin/branches{/branch}","tags_url":"https://api.github.com/repos/juanvallejo/origin/tags","blobs_url":"https://api.github.com/repos/juanvallejo/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juanvallejo/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juanvallejo/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/juanvallejo/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juanvallejo/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/juanvallejo/origin/languages","stargazers_url":"https://api.github.com/repos/juanvallejo/origin/stargazers","contributors_url":"https://api.github.com/repos/juanvallejo/origin/contributors","subscribers_url":"https://api.github.com/repos/juanvallejo/origin/subscribers","subscription_url":"https://api.github.com/repos/juanvallejo/origin/subscription","commits_url":"https://api.github.com/repos/juanvallejo/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/juanvallejo/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/juanvallejo/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/juanvallejo/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/juanvallejo/origin/contents/{+path}","compare_url":"https://api.github.com/repos/juanvallejo/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juanvallejo/origin/merges","archive_url":"https://api.github.com/repos/juanvallejo/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juanvallejo/origin/downloads","issues_url":"https://api.github.com/repos/juanvallejo/origin/issues{/number}","pulls_url":"https://api.github.com/repos/juanvallejo/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/juanvallejo/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/juanvallejo/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juanvallejo/origin/labels{/name}","releases_url":"https://api.github.com/repos/juanvallejo/origin/releases{/id}","deployments_url":"https://api.github.com/repos/juanvallejo/origin/deployments","created_at":"2016-01-29T23:22:53Z","updated_at":"2016-01-29T23:22:58Z","pushed_at":"2016-08-15T22:00:33Z","git_url":"git://github.com/juanvallejo/origin.git","ssh_url":"git@github.com:juanvallejo/origin.git","clone_url":"https://github.com/juanvallejo/origin.git","svn_url":"https://github.com/juanvallejo/origin","homepage":"http://www.openshift.org","size":312174,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"9900542cc9cfc0fb43a6bc1cc2857095ba53642f","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"Enterprise-Ready Kubernetes for Developers","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2016-08-14T19:28:12Z","pushed_at":"2016-08-15T22:00:35Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":562713,"stargazers_count":1594,"watchers_count":1594,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":985,"mirror_url":null,"open_issues_count":1093,"forks":985,"open_issues":1093,"watchers":1594,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/10360"},"html":{"href":"https://github.com/openshift/origin/pull/10360"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/10360"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/10360/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/10360/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/10360/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/94d306f1ec15b5263603c81c7c5554b1038e9293"}}}}
{"actor":{"display_login":"juanvallejo"}}