{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/9072","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/9072/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/9072/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/9072/events","html_url":"https://github.com/ManageIQ/manageiq/pull/9072","id":157882996,"number":9072,"title":"Fix fetching saved chargeback reports","user":{"login":"lpichler","id":14937244,"avatar_url":"https://avatars.githubusercontent.com/u/14937244?v=3","gravatar_id":"","url":"https://api.github.com/users/lpichler","html_url":"https://github.com/lpichler","followers_url":"https://api.github.com/users/lpichler/followers","following_url":"https://api.github.com/users/lpichler/following{/other_user}","gists_url":"https://api.github.com/users/lpichler/gists{/gist_id}","starred_url":"https://api.github.com/users/lpichler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpichler/subscriptions","organizations_url":"https://api.github.com/users/lpichler/orgs","repos_url":"https://api.github.com/users/lpichler/repos","events_url":"https://api.github.com/users/lpichler/events{/privacy}","received_events_url":"https://api.github.com/users/lpichler/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/blocker","name":"blocker","color":"000000"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/chargeback","name":"chargeback","color":"5319e7"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/darga/yes","name":"darga/yes","color":"000000"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/reporting","name":"reporting","color":"5319e7"}],"state":"open","locked":false,"assignee":{"login":"gtanzillo","id":76593,"avatar_url":"https://avatars.githubusercontent.com/u/76593?v=3","gravatar_id":"","url":"https://api.github.com/users/gtanzillo","html_url":"https://github.com/gtanzillo","followers_url":"https://api.github.com/users/gtanzillo/followers","following_url":"https://api.github.com/users/gtanzillo/following{/other_user}","gists_url":"https://api.github.com/users/gtanzillo/gists{/gist_id}","starred_url":"https://api.github.com/users/gtanzillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtanzillo/subscriptions","organizations_url":"https://api.github.com/users/gtanzillo/orgs","repos_url":"https://api.github.com/users/gtanzillo/repos","events_url":"https://api.github.com/users/gtanzillo/events{/privacy}","received_events_url":"https://api.github.com/users/gtanzillo/received_events","type":"User","site_admin":false},"milestone":null,"comments":6,"created_at":"2016-06-01T11:22:40Z","updated_at":"2016-06-02T14:10:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9072","html_url":"https://github.com/ManageIQ/manageiq/pull/9072","diff_url":"https://github.com/ManageIQ/manageiq/pull/9072.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/9072.patch"},"body":"addition for https://bugzilla.redhat.com/show_bug.cgi?id=1336978\r\n\r\nthere was inproper checking of finished state of report's miq_task, the correct name of completed task is\r\n`complete` as we have in general saved reports as we have here https://github.com/ManageIQ/manageiq/blob/master/app/controllers/report_controller/saved_reports.rb#L29\r\nbut now I am using MiqTask method for it.\r\n\r\nscenario CI-> Chargeback -> and click on any saved chargeback report - before fix there was displayed message there are no  \r\n\r\n\r\nalso removed message when report doesn't have records.\r\nand only one message is used from this place https://github.com/ManageIQ/manageiq/blob/master/app/controllers/chargeback_controller.rb#L470 - the red one was removed\r\n\r\n![screen shot 2016-06-01 at 13 36 01](https://cloud.githubusercontent.com/assets/14937244/15708662/13c468aa-2800-11e6-8aca-c53d18ddbdd4.png)\r\n\r\n\r\ncc @gtanzillo \r\n"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/223303183","html_url":"https://github.com/ManageIQ/manageiq/pull/9072#issuecomment-223303183","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/9072","id":223303183,"user":{"login":"jrafanie","id":19339,"avatar_url":"https://avatars.githubusercontent.com/u/19339?v=3","gravatar_id":"","url":"https://api.github.com/users/jrafanie","html_url":"https://github.com/jrafanie","followers_url":"https://api.github.com/users/jrafanie/followers","following_url":"https://api.github.com/users/jrafanie/following{/other_user}","gists_url":"https://api.github.com/users/jrafanie/gists{/gist_id}","starred_url":"https://api.github.com/users/jrafanie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrafanie/subscriptions","organizations_url":"https://api.github.com/users/jrafanie/orgs","repos_url":"https://api.github.com/users/jrafanie/repos","events_url":"https://api.github.com/users/jrafanie/events{/privacy}","received_events_url":"https://api.github.com/users/jrafanie/received_events","type":"User","site_admin":false},"created_at":"2016-06-02T14:10:00Z","updated_at":"2016-06-02T14:10:00Z","body":"The failure is unrelated, we'll fix it as a followup:\r\n\r\n```\r\n  1) ChargebackController Saved chargeback rendering #cb_rpt_build_folder_nodes returns list of saved chargeback report results\r\n     Failure/Error: expect(parent_reports).to eq(expected_result)\r\n\r\n       expected: {\"Test Report 0000000000094\"=>\"509r299-0\"}\r\n            got: {\"Test Report 0000000000001\"=>\"509r299-0\"}\r\n\r\n       (compared using ==)\r\n\r\n       Diff:\r\n       @@ -1,2 +1,2 @@\r\n       -\"Test Report 0000000000094\" => \"509r299-0\",\r\n       +\"Test Report 0000000000001\" => \"509r299-0\",\r\n\r\n     # ./spec/controllers/chargeback_controller_spec.rb:87:in `block (4 levels) in <top (required)>'\r\n     # /Users/joerafaniello/.gem/ruby/2.2.5/gems/bundler-1.12.5/lib/bundler/cli/exec.rb:63:in `load'\r\n     # /Users/joerafaniello/.gem/ruby/2.2.5/gems/bundler-1.12.5/lib/bundler/cli/exec.rb:63:in `kernel_load'\r\n     # /Users/joerafaniello/.gem/ruby/2.2.5/gems/bundler-1.12.5/lib/bundler/cli/exec.rb:24:in `run'\r\n     # /Users/joerafaniello/.gem/ruby/2.2.5/gems/bundler-1.12.5/lib/bundler/cli.rb:304:in `exec'\r\n     # /Users/joerafaniello/.gem/ruby/2.2.5/gems/bundler-1.12.5/lib/bundler/cli.rb:11:in `start'\r\n     # /Users/joerafaniello/.gem/ruby/2.2.5/gems/bundler-1.12.5/exe/bundle:27:in `block in <top (required)>'\r\n     # /Users/joerafaniello/.gem/ruby/2.2.5/gems/bundler-1.12.5/lib/bundler/friendly_errors.rb:98:in `with_friendly_errors'\r\n     # /Users/joerafaniello/.gem/ruby/2.2.5/gems/bundler-1.12.5/exe/bundle:19:in `<top (required)>'\r\n```"}}
{"actor":{"display_login":"jrafanie"}}