{"action":"created","issue":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/19124","repository_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/19124/labels{/name}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/19124/comments","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/19124/events","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/19124","id":187113919,"number":19124,"title":"Skip validation of obsolete mods","user":{"login":"mugling","id":12238606,"avatar_url":"https://avatars.githubusercontent.com/u/12238606?v=3","gravatar_id":"","url":"https://api.github.com/users/mugling","html_url":"https://github.com/mugling","followers_url":"https://api.github.com/users/mugling/followers","following_url":"https://api.github.com/users/mugling/following{/other_user}","gists_url":"https://api.github.com/users/mugling/gists{/gist_id}","starred_url":"https://api.github.com/users/mugling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mugling/subscriptions","organizations_url":"https://api.github.com/users/mugling/orgs","repos_url":"https://api.github.com/users/mugling/repos","events_url":"https://api.github.com/users/mugling/events{/privacy}","received_events_url":"https://api.github.com/users/mugling/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-11-03T16:17:56Z","updated_at":"2016-11-04T10:49:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/19124","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/19124","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/19124.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/19124.patch"},"body":"We have 48 mods (and counting) all of which currently receive the attention of the core developers. This is rapidly becoming unworkable and results in frequent breakage of the mods that actually are popular. No amount of opining is going to change the fact that we have limited resources and should focus them on the core game and popular mods.\r\n\r\nA significant problems is that `--check-mods` now takes ~10 minutes to run and this needs to be done for every PR. This PR aims to improve developer QOL by having `--check-mods` skip mods that are marked `obsolete` (see #19054).\r\n\r\nThe second problem is there sheer number of possible combinations and interactions between mods.\r\n\r\nFour mods are marked obsoleted:\r\n* Animatronics (minimal popularity, outdated)\r\n* Dino mod (minimal popularity, outdated)\r\n* Mundane zombies (list oudated and hard to maintain, nearly duplicated by only wildlife)\r\n* No triffids (minimal popularity)\r\n\r\nPlease no offers to maintain (apart from core developers). The issue being that when a core developer alters the C++ code they have to update all 48 mods and that work can only reasonably be done by them. If your busy penning a 1000+ word ~~shitpost~~ argument consider instead creating a github repo and offering to maintain `contrib` mods there. Again no amount of opining will change the simple fact that we have too few developers to support all of those mods.\r\n\r\nNote this PR does **not** break any savegames"},"comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments/258399889","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/19124#issuecomment-258399889","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/19124","id":258399889,"user":{"login":"Noctifer-de-Mortem","id":16777044,"avatar_url":"https://avatars.githubusercontent.com/u/16777044?v=3","gravatar_id":"","url":"https://api.github.com/users/Noctifer-de-Mortem","html_url":"https://github.com/Noctifer-de-Mortem","followers_url":"https://api.github.com/users/Noctifer-de-Mortem/followers","following_url":"https://api.github.com/users/Noctifer-de-Mortem/following{/other_user}","gists_url":"https://api.github.com/users/Noctifer-de-Mortem/gists{/gist_id}","starred_url":"https://api.github.com/users/Noctifer-de-Mortem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Noctifer-de-Mortem/subscriptions","organizations_url":"https://api.github.com/users/Noctifer-de-Mortem/orgs","repos_url":"https://api.github.com/users/Noctifer-de-Mortem/repos","events_url":"https://api.github.com/users/Noctifer-de-Mortem/events{/privacy}","received_events_url":"https://api.github.com/users/Noctifer-de-Mortem/received_events","type":"User","site_admin":false},"created_at":"2016-11-04T10:49:48Z","updated_at":"2016-11-04T10:49:48Z","body":"I really see no reason to complain, developer time and resources are limited so reducing the workload is desirable. \r\n\r\nIf you really want one of those mods for new worlds just delete the obsolete field in modinfo.json when you download a new experimental and if it has any load issues either fix it yourself or ask for help in the forum. Many mods are run on the forum and are broken all the time by new PRs but are swiftly fixed by their authors or those who use them."}}
{"actor":{"display_login":"Noctifer-de-Mortem"}}