{"action":"created","comment":{"url":"https://api.github.com/repos/socketio/socket.io-client/pulls/comments/52702595","id":52702595,"diff_hunk":"@@ -4,34 +4,39 @@ REPORTER = dot\n build: socket.io.js\n \n socket.io.js: lib/*.js package.json\n-\t@./support/browserify.sh > socket.io.js\n+\t@./node_modules/.bin/gulp\n+\t# @./support/browserify.sh > socket.io.js\n \n test:\n-\t@if [ \"x$(BROWSER_NAME)\" = \"x\" ]; then make test-node; else make test-zuul; fi\n+\t@./node_modules/.bin/gulp test\n+\t# @if [ \"x$(BROWSER_NAME)\" = \"x\" ]; then make test-node; else make test-zuul; fi\n \n test-node:\n-\t@./node_modules/.bin/mocha \\\n-\t\t--reporter $(REPORTER) \\\n-\t\t--require test/support/server.js \\\n-\t\ttest/index.js\n+\t@./node_modules/.bin/gulp test-node\n+\t# @./node_modules/.bin/mocha \\\n+\t# \t--reporter $(REPORTER) \\\n+\t# \t--require test/support/server.js \\\n+\t# \ttest/index.js\n \n test-zuul:\n-\t@if [ \"x$(BROWSER_PLATFORM)\" = \"x\" ]; then \\\n-\t\t./node_modules/zuul/bin/zuul \\\n-\t\t--browser-name $(BROWSER_NAME) \\\n-\t\t--browser-version $(BROWSER_VERSION) \\\n-\t\ttest/index.js; \\\n-\t\telse \\\n-\t\t./node_modules/zuul/bin/zuul \\\n-\t\t--browser-name $(BROWSER_NAME) \\\n-\t\t--browser-version $(BROWSER_VERSION) \\\n-\t\t--browser-platform \"$(BROWSER_PLATFORM)\" \\\n-\t\ttest/index.js; \\\n-\tfi\n+\t@./node_modules/.bin/gulp test-zuul\n+\t# @if [ \"x$(BROWSER_PLATFORM)\" = \"x\" ]; then \\\n+\t# \t./node_modules/zuul/bin/zuul \\\n+\t# \t--browser-name $(BROWSER_NAME) \\\n+\t# \t--browser-version $(BROWSER_VERSION) \\\n+\t# \ttest/index.js; \\\n+\t# \telse \\\n+\t# \t./node_modules/zuul/bin/zuul \\\n+\t# \t--browser-name $(BROWSER_NAME) \\\n+\t# \t--browser-version $(BROWSER_VERSION) \\\n+\t# \t--browser-platform \"$(BROWSER_PLATFORM)\" \\\n+\t# \ttest/index.js; \\\n+\t# fi\n \n test-cov:\n-\t@./node_modules/.bin/istanbul cover ./node_modules/.bin/_mocha -- \\\n-\t\t--reporter $(REPORTER) \\\n-\t\ttest/\n+\t@./node_modules/.bin/gulp test-cov\n+\t# @./node_modules/.bin/istanbul cover ./node_modules/.bin/_mocha -- \\\n+\t# \t--reporter $(REPORTER) \\\n+\t# \ttest/","path":"Makefile","position":58,"original_position":58,"commit_id":"18d6873c649da0592354f033f03832574fcf55b4","original_commit_id":"18d6873c649da0592354f033f03832574fcf55b4","user":{"login":"nkzawa","id":775227,"avatar_url":"https://avatars.githubusercontent.com/u/775227?v=3","gravatar_id":"","url":"https://api.github.com/users/nkzawa","html_url":"https://github.com/nkzawa","followers_url":"https://api.github.com/users/nkzawa/followers","following_url":"https://api.github.com/users/nkzawa/following{/other_user}","gists_url":"https://api.github.com/users/nkzawa/gists{/gist_id}","starred_url":"https://api.github.com/users/nkzawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkzawa/subscriptions","organizations_url":"https://api.github.com/users/nkzawa/orgs","repos_url":"https://api.github.com/users/nkzawa/repos","events_url":"https://api.github.com/users/nkzawa/events{/privacy}","received_events_url":"https://api.github.com/users/nkzawa/received_events","type":"User","site_admin":false},"body":"We can just remove these comments ?","created_at":"2016-02-12T03:33:58Z","updated_at":"2016-02-12T03:33:58Z","html_url":"https://github.com/socketio/socket.io-client/pull/940#discussion_r52702595","pull_request_url":"https://api.github.com/repos/socketio/socket.io-client/pulls/940","_links":{"self":{"href":"https://api.github.com/repos/socketio/socket.io-client/pulls/comments/52702595"},"html":{"href":"https://github.com/socketio/socket.io-client/pull/940#discussion_r52702595"},"pull_request":{"href":"https://api.github.com/repos/socketio/socket.io-client/pulls/940"}}},"pull_request":{"url":"https://api.github.com/repos/socketio/socket.io-client/pulls/940","id":57731494,"html_url":"https://github.com/socketio/socket.io-client/pull/940","diff_url":"https://github.com/socketio/socket.io-client/pull/940.diff","patch_url":"https://github.com/socketio/socket.io-client/pull/940.patch","issue_url":"https://api.github.com/repos/socketio/socket.io-client/issues/940","number":940,"state":"open","locked":false,"title":"Webpack","user":{"login":"whattokingu","id":3874318,"avatar_url":"https://avatars.githubusercontent.com/u/3874318?v=3","gravatar_id":"","url":"https://api.github.com/users/whattokingu","html_url":"https://github.com/whattokingu","followers_url":"https://api.github.com/users/whattokingu/followers","following_url":"https://api.github.com/users/whattokingu/following{/other_user}","gists_url":"https://api.github.com/users/whattokingu/gists{/gist_id}","starred_url":"https://api.github.com/users/whattokingu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whattokingu/subscriptions","organizations_url":"https://api.github.com/users/whattokingu/orgs","repos_url":"https://api.github.com/users/whattokingu/repos","events_url":"https://api.github.com/users/whattokingu/events{/privacy}","received_events_url":"https://api.github.com/users/whattokingu/received_events","type":"User","site_admin":false},"body":"+ Changed task runner to Gulp (`npm test` runs `gulp test` rather than `make test`).\r\n+ Added Webpack (via Gulp) as a build system.\r\n+ Added Babel to both Browserify build and Webpack build.\r\n","created_at":"2016-01-30T05:47:33Z","updated_at":"2016-02-12T03:33:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9da3adbcc0c6afafd9df1f14d2b068679de07609","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/socketio/socket.io-client/pulls/940/commits","review_comments_url":"https://api.github.com/repos/socketio/socket.io-client/pulls/940/comments","review_comment_url":"https://api.github.com/repos/socketio/socket.io-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/socketio/socket.io-client/issues/940/comments","statuses_url":"https://api.github.com/repos/socketio/socket.io-client/statuses/18d6873c649da0592354f033f03832574fcf55b4","head":{"label":"nus-fboa2016-si:webpack","ref":"webpack","sha":"18d6873c649da0592354f033f03832574fcf55b4","user":{"login":"nus-fboa2016-si","id":16642039,"avatar_url":"https://avatars.githubusercontent.com/u/16642039?v=3","gravatar_id":"","url":"https://api.github.com/users/nus-fboa2016-si","html_url":"https://github.com/nus-fboa2016-si","followers_url":"https://api.github.com/users/nus-fboa2016-si/followers","following_url":"https://api.github.com/users/nus-fboa2016-si/following{/other_user}","gists_url":"https://api.github.com/users/nus-fboa2016-si/gists{/gist_id}","starred_url":"https://api.github.com/users/nus-fboa2016-si/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nus-fboa2016-si/subscriptions","organizations_url":"https://api.github.com/users/nus-fboa2016-si/orgs","repos_url":"https://api.github.com/users/nus-fboa2016-si/repos","events_url":"https://api.github.com/users/nus-fboa2016-si/events{/privacy}","received_events_url":"https://api.github.com/users/nus-fboa2016-si/received_events","type":"Organization","site_admin":false},"repo":{"id":50010541,"name":"socket.io-client","full_name":"nus-fboa2016-si/socket.io-client","owner":{"login":"nus-fboa2016-si","id":16642039,"avatar_url":"https://avatars.githubusercontent.com/u/16642039?v=3","gravatar_id":"","url":"https://api.github.com/users/nus-fboa2016-si","html_url":"https://github.com/nus-fboa2016-si","followers_url":"https://api.github.com/users/nus-fboa2016-si/followers","following_url":"https://api.github.com/users/nus-fboa2016-si/following{/other_user}","gists_url":"https://api.github.com/users/nus-fboa2016-si/gists{/gist_id}","starred_url":"https://api.github.com/users/nus-fboa2016-si/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nus-fboa2016-si/subscriptions","organizations_url":"https://api.github.com/users/nus-fboa2016-si/orgs","repos_url":"https://api.github.com/users/nus-fboa2016-si/repos","events_url":"https://api.github.com/users/nus-fboa2016-si/events{/privacy}","received_events_url":"https://api.github.com/users/nus-fboa2016-si/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nus-fboa2016-si/socket.io-client","description":"Realtime application framework (client)","fork":true,"url":"https://api.github.com/repos/nus-fboa2016-si/socket.io-client","forks_url":"https://api.github.com/repos/nus-fboa2016-si/socket.io-client/forks","keys_url":"https://api.github.com/repos/nus-fboa2016-si/socket.io-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nus-fboa2016-si/socket.io-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nus-fboa2016-si/socket.io-client/teams","hooks_url":"https://api.github.com/repos/nus-fboa2016-si/socket.io-client/hooks","issue_events_url":"https://api.github.com/repos/nus-fboa2016-si/socket.io-client/issues/events{/number}","events_url":"https://api.github.com/repos/nus-fboa2016-si/socket.io-client/events","assignees_url":"https://api.github.com/repos/nus-fboa2016-si/socket.io-client/assignees{/user}","branches_url":"https://api.github.com/repos/nus-fboa2016-si/socket.io-client/branches{/branch}","tags_url":"https://api.github.com/repos/nus-fboa2016-si/socket.io-client/tags","blobs_url":"https://api.github.com/repos/nus-fboa2016-si/socket.io-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nus-fboa2016-si/socket.io-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nus-fboa2016-si/socket.io-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/nus-fboa2016-si/socket.io-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nus-fboa2016-si/socket.io-client/statuses/{sha}","languages_url":"https://api.github.com/repos/nus-fboa2016-si/socket.io-client/languages","stargazers_url":"https://api.github.com/repos/nus-fboa2016-si/socket.io-client/stargazers","contributors_url":"https://api.github.com/repos/nus-fboa2016-si/socket.io-client/contributors","subscribers_url":"https://api.github.com/repos/nus-fboa2016-si/socket.io-client/subscribers","subscription_url":"https://api.github.com/repos/nus-fboa2016-si/socket.io-client/subscription","commits_url":"https://api.github.com/repos/nus-fboa2016-si/socket.io-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/nus-fboa2016-si/socket.io-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/nus-fboa2016-si/socket.io-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/nus-fboa2016-si/socket.io-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/nus-fboa2016-si/socket.io-client/contents/{+path}","compare_url":"https://api.github.com/repos/nus-fboa2016-si/socket.io-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nus-fboa2016-si/socket.io-client/merges","archive_url":"https://api.github.com/repos/nus-fboa2016-si/socket.io-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nus-fboa2016-si/socket.io-client/downloads","issues_url":"https://api.github.com/repos/nus-fboa2016-si/socket.io-client/issues{/number}","pulls_url":"https://api.github.com/repos/nus-fboa2016-si/socket.io-client/pulls{/number}","milestones_url":"https://api.github.com/repos/nus-fboa2016-si/socket.io-client/milestones{/number}","notifications_url":"https://api.github.com/repos/nus-fboa2016-si/socket.io-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nus-fboa2016-si/socket.io-client/labels{/name}","releases_url":"https://api.github.com/repos/nus-fboa2016-si/socket.io-client/releases{/id}","deployments_url":"https://api.github.com/repos/nus-fboa2016-si/socket.io-client/deployments","created_at":"2016-01-20T06:46:10Z","updated_at":"2016-01-20T06:46:11Z","pushed_at":"2016-02-10T16:12:14Z","git_url":"git://github.com/nus-fboa2016-si/socket.io-client.git","ssh_url":"git@github.com:nus-fboa2016-si/socket.io-client.git","clone_url":"https://github.com/nus-fboa2016-si/socket.io-client.git","svn_url":"https://github.com/nus-fboa2016-si/socket.io-client","homepage":"http://socket.io","size":4175,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"socketio:master","ref":"master","sha":"5fe7373610ef92de0d34b44d503c22cab5712c8d","user":{"login":"socketio","id":10566080,"avatar_url":"https://avatars.githubusercontent.com/u/10566080?v=3","gravatar_id":"","url":"https://api.github.com/users/socketio","html_url":"https://github.com/socketio","followers_url":"https://api.github.com/users/socketio/followers","following_url":"https://api.github.com/users/socketio/following{/other_user}","gists_url":"https://api.github.com/users/socketio/gists{/gist_id}","starred_url":"https://api.github.com/users/socketio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socketio/subscriptions","organizations_url":"https://api.github.com/users/socketio/orgs","repos_url":"https://api.github.com/users/socketio/repos","events_url":"https://api.github.com/users/socketio/events{/privacy}","received_events_url":"https://api.github.com/users/socketio/received_events","type":"Organization","site_admin":false},"repo":{"id":557977,"name":"socket.io-client","full_name":"socketio/socket.io-client","owner":{"login":"socketio","id":10566080,"avatar_url":"https://avatars.githubusercontent.com/u/10566080?v=3","gravatar_id":"","url":"https://api.github.com/users/socketio","html_url":"https://github.com/socketio","followers_url":"https://api.github.com/users/socketio/followers","following_url":"https://api.github.com/users/socketio/following{/other_user}","gists_url":"https://api.github.com/users/socketio/gists{/gist_id}","starred_url":"https://api.github.com/users/socketio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socketio/subscriptions","organizations_url":"https://api.github.com/users/socketio/orgs","repos_url":"https://api.github.com/users/socketio/repos","events_url":"https://api.github.com/users/socketio/events{/privacy}","received_events_url":"https://api.github.com/users/socketio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/socketio/socket.io-client","description":"Realtime application framework (client)","fork":false,"url":"https://api.github.com/repos/socketio/socket.io-client","forks_url":"https://api.github.com/repos/socketio/socket.io-client/forks","keys_url":"https://api.github.com/repos/socketio/socket.io-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/socketio/socket.io-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/socketio/socket.io-client/teams","hooks_url":"https://api.github.com/repos/socketio/socket.io-client/hooks","issue_events_url":"https://api.github.com/repos/socketio/socket.io-client/issues/events{/number}","events_url":"https://api.github.com/repos/socketio/socket.io-client/events","assignees_url":"https://api.github.com/repos/socketio/socket.io-client/assignees{/user}","branches_url":"https://api.github.com/repos/socketio/socket.io-client/branches{/branch}","tags_url":"https://api.github.com/repos/socketio/socket.io-client/tags","blobs_url":"https://api.github.com/repos/socketio/socket.io-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/socketio/socket.io-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/socketio/socket.io-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/socketio/socket.io-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/socketio/socket.io-client/statuses/{sha}","languages_url":"https://api.github.com/repos/socketio/socket.io-client/languages","stargazers_url":"https://api.github.com/repos/socketio/socket.io-client/stargazers","contributors_url":"https://api.github.com/repos/socketio/socket.io-client/contributors","subscribers_url":"https://api.github.com/repos/socketio/socket.io-client/subscribers","subscription_url":"https://api.github.com/repos/socketio/socket.io-client/subscription","commits_url":"https://api.github.com/repos/socketio/socket.io-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/socketio/socket.io-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/socketio/socket.io-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/socketio/socket.io-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/socketio/socket.io-client/contents/{+path}","compare_url":"https://api.github.com/repos/socketio/socket.io-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/socketio/socket.io-client/merges","archive_url":"https://api.github.com/repos/socketio/socket.io-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/socketio/socket.io-client/downloads","issues_url":"https://api.github.com/repos/socketio/socket.io-client/issues{/number}","pulls_url":"https://api.github.com/repos/socketio/socket.io-client/pulls{/number}","milestones_url":"https://api.github.com/repos/socketio/socket.io-client/milestones{/number}","notifications_url":"https://api.github.com/repos/socketio/socket.io-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/socketio/socket.io-client/labels{/name}","releases_url":"https://api.github.com/repos/socketio/socket.io-client/releases{/id}","deployments_url":"https://api.github.com/repos/socketio/socket.io-client/deployments","created_at":"2010-03-11T18:23:03Z","updated_at":"2016-02-11T09:45:55Z","pushed_at":"2016-02-10T16:12:15Z","git_url":"git://github.com/socketio/socket.io-client.git","ssh_url":"git@github.com:socketio/socket.io-client.git","clone_url":"https://github.com/socketio/socket.io-client.git","svn_url":"https://github.com/socketio/socket.io-client","homepage":"http://socket.io","size":6054,"stargazers_count":3356,"watchers_count":3356,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1212,"mirror_url":null,"open_issues_count":74,"forks":1212,"open_issues":74,"watchers":3356,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/socketio/socket.io-client/pulls/940"},"html":{"href":"https://github.com/socketio/socket.io-client/pull/940"},"issue":{"href":"https://api.github.com/repos/socketio/socket.io-client/issues/940"},"comments":{"href":"https://api.github.com/repos/socketio/socket.io-client/issues/940/comments"},"review_comments":{"href":"https://api.github.com/repos/socketio/socket.io-client/pulls/940/comments"},"review_comment":{"href":"https://api.github.com/repos/socketio/socket.io-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/socketio/socket.io-client/pulls/940/commits"},"statuses":{"href":"https://api.github.com/repos/socketio/socket.io-client/statuses/18d6873c649da0592354f033f03832574fcf55b4"}}}}