{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/jetpack/issues/3606","repository_url":"https://api.github.com/repos/Automattic/jetpack","labels_url":"https://api.github.com/repos/Automattic/jetpack/issues/3606/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/jetpack/issues/3606/comments","events_url":"https://api.github.com/repos/Automattic/jetpack/issues/3606/events","html_url":"https://github.com/Automattic/jetpack/pull/3606","id":144600801,"number":3606,"title":"VideoPress: fix fatal error when module is disabled and Shortcodes module is enabled","user":{"login":"eliorivero","id":1041600,"avatar_url":"https://avatars.githubusercontent.com/u/1041600?v=3","gravatar_id":"","url":"https://api.github.com/users/eliorivero","html_url":"https://github.com/eliorivero","followers_url":"https://api.github.com/users/eliorivero/followers","following_url":"https://api.github.com/users/eliorivero/following{/other_user}","gists_url":"https://api.github.com/users/eliorivero/gists{/gist_id}","starred_url":"https://api.github.com/users/eliorivero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eliorivero/subscriptions","organizations_url":"https://api.github.com/users/eliorivero/orgs","repos_url":"https://api.github.com/users/eliorivero/repos","events_url":"https://api.github.com/users/eliorivero/events{/privacy}","received_events_url":"https://api.github.com/users/eliorivero/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Automattic/jetpack/labels/Shortcodes","name":"Shortcodes","color":"006b75"},{"url":"https://api.github.com/repos/Automattic/jetpack/labels/VideoPress","name":"VideoPress","color":"006b75"},{"url":"https://api.github.com/repos/Automattic/jetpack/labels/[Status]%20Needs%20Review","name":"[Status] Needs Review","color":"fbca04"},{"url":"https://api.github.com/repos/Automattic/jetpack/labels/[Type]%20Bug","name":"[Type] Bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/Automattic/jetpack/milestones/42","html_url":"https://github.com/Automattic/jetpack/milestones/3.9.5","labels_url":"https://api.github.com/repos/Automattic/jetpack/milestones/42/labels","id":1652813,"number":42,"title":"3.9.5","description":"","creator":{"login":"zinigor","id":374293,"avatar_url":"https://avatars.githubusercontent.com/u/374293?v=3","gravatar_id":"","url":"https://api.github.com/users/zinigor","html_url":"https://github.com/zinigor","followers_url":"https://api.github.com/users/zinigor/followers","following_url":"https://api.github.com/users/zinigor/following{/other_user}","gists_url":"https://api.github.com/users/zinigor/gists{/gist_id}","starred_url":"https://api.github.com/users/zinigor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zinigor/subscriptions","organizations_url":"https://api.github.com/users/zinigor/orgs","repos_url":"https://api.github.com/users/zinigor/repos","events_url":"https://api.github.com/users/zinigor/events{/privacy}","received_events_url":"https://api.github.com/users/zinigor/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":30,"state":"open","created_at":"2016-03-18T07:38:06Z","updated_at":"2016-03-30T13:57:15Z","due_on":"2016-03-30T05:00:00Z","closed_at":null},"comments":1,"created_at":"2016-03-30T13:54:41Z","updated_at":"2016-03-30T14:23:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Automattic/jetpack/pulls/3606","html_url":"https://github.com/Automattic/jetpack/pull/3606","diff_url":"https://github.com/Automattic/jetpack/pull/3606.diff","patch_url":"https://github.com/Automattic/jetpack/pull/3606.patch"},"body":"#### Changes proposed in this Pull Request:\r\n- Provides minimum support to embed VideoPress videos.\r\n\r\ncc @georgestephanis \r\n\r\nSteps to reproduce the bug that this PR solves:\r\n\r\n1- Enable VideoPress module and Shortcodes module\r\n\r\n2- Add shortcode `[wpvideo OO4thna8]` in a post\r\n\r\nPost looks good so far\r\n\r\n3- Disable VideoPress module\r\n\r\nPost displays `Fatal error: Call to undefined function videopress_is_valid_guid() in /wp-content/plugins/jetpack/modules/videopress/shortcode.php on line 32`"},"comment":{"url":"https://api.github.com/repos/Automattic/jetpack/issues/comments/203455839","html_url":"https://github.com/Automattic/jetpack/pull/3606#issuecomment-203455839","issue_url":"https://api.github.com/repos/Automattic/jetpack/issues/3606","id":203455839,"user":{"login":"georgestephanis","id":941023,"avatar_url":"https://avatars.githubusercontent.com/u/941023?v=3","gravatar_id":"","url":"https://api.github.com/users/georgestephanis","html_url":"https://github.com/georgestephanis","followers_url":"https://api.github.com/users/georgestephanis/followers","following_url":"https://api.github.com/users/georgestephanis/following{/other_user}","gists_url":"https://api.github.com/users/georgestephanis/gists{/gist_id}","starred_url":"https://api.github.com/users/georgestephanis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgestephanis/subscriptions","organizations_url":"https://api.github.com/users/georgestephanis/orgs","repos_url":"https://api.github.com/users/georgestephanis/repos","events_url":"https://api.github.com/users/georgestephanis/events{/privacy}","received_events_url":"https://api.github.com/users/georgestephanis/received_events","type":"User","site_admin":false},"created_at":"2016-03-30T14:23:23Z","updated_at":"2016-03-30T14:23:23Z","body":"Looks good.  Once this merges, I'll prep a second PR this afternoon to extract the editor view code into a new file that can also be pulled in safely here.\r\n\r\nhttps://github.com/Automattic/jetpack/blob/master/modules/videopress/videopress.php#L735-L789"}}