{"action":"created","comment":{"url":"https://api.github.com/repos/sourcegraph/checkup/pulls/comments/75394317","id":75394317,"diff_hunk":"@@ -0,0 +1,127 @@\n+package checkup\n+\n+\n+import (\n+\t\"fmt\"\n+\t\"log\"\n+\t\"net\"\n+\t\"time\"\n+\t\"github.com/miekg/dns\"\n+\n+)\n+\n+// DNSChecker implements a Checker for TCP endpoints.\n+type DNSChecker struct {\n+\t// Name is the name of the endpoint.\n+\tName string `json:\"endpoint_name\"`\n+\n+\t// This is the name of the DNS server you are testing.\n+\tDNSServer string `json:\"endpoint_url\"`\n+\n+\t// This is the fqdn of the target server to query the DNS server for.\n+\tDNSTarget string `json:\"hostname_fqdn,omitempty\"`","path":"dnschecker.go","position":22,"original_position":22,"commit_id":"ad69cbb957e2e4e1114039c8ffd365e3aee0efac","original_commit_id":"ad69cbb957e2e4e1114039c8ffd365e3aee0efac","user":{"login":"mholt","id":1128849,"avatar_url":"https://avatars.githubusercontent.com/u/1128849?v=3","gravatar_id":"","url":"https://api.github.com/users/mholt","html_url":"https://github.com/mholt","followers_url":"https://api.github.com/users/mholt/followers","following_url":"https://api.github.com/users/mholt/following{/other_user}","gists_url":"https://api.github.com/users/mholt/gists{/gist_id}","starred_url":"https://api.github.com/users/mholt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mholt/subscriptions","organizations_url":"https://api.github.com/users/mholt/orgs","repos_url":"https://api.github.com/users/mholt/repos","events_url":"https://api.github.com/users/mholt/events{/privacy}","received_events_url":"https://api.github.com/users/mholt/received_events","type":"User","site_admin":false},"body":"Any chance we could get the field names to match their JSON equivalents or vice-versa?","created_at":"2016-08-18T21:39:09Z","updated_at":"2016-08-18T21:39:09Z","html_url":"https://github.com/sourcegraph/checkup/pull/12#discussion_r75394317","pull_request_url":"https://api.github.com/repos/sourcegraph/checkup/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/sourcegraph/checkup/pulls/comments/75394317"},"html":{"href":"https://github.com/sourcegraph/checkup/pull/12#discussion_r75394317"},"pull_request":{"href":"https://api.github.com/repos/sourcegraph/checkup/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/sourcegraph/checkup/pulls/12","id":81032335,"html_url":"https://github.com/sourcegraph/checkup/pull/12","diff_url":"https://github.com/sourcegraph/checkup/pull/12.diff","patch_url":"https://github.com/sourcegraph/checkup/pull/12.patch","issue_url":"https://api.github.com/repos/sourcegraph/checkup/issues/12","number":12,"state":"open","locked":false,"title":"Adding named DNS support for consideration","user":{"login":"gogosphere","id":20846757,"avatar_url":"https://avatars.githubusercontent.com/u/20846757?v=3","gravatar_id":"","url":"https://api.github.com/users/gogosphere","html_url":"https://github.com/gogosphere","followers_url":"https://api.github.com/users/gogosphere/followers","following_url":"https://api.github.com/users/gogosphere/following{/other_user}","gists_url":"https://api.github.com/users/gogosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/gogosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gogosphere/subscriptions","organizations_url":"https://api.github.com/users/gogosphere/orgs","repos_url":"https://api.github.com/users/gogosphere/repos","events_url":"https://api.github.com/users/gogosphere/events{/privacy}","received_events_url":"https://api.github.com/users/gogosphere/received_events","type":"User","site_admin":false},"body":" I put the .json config in the top of the dnschecker.go file.  I pulled in \"github.com/miekg/dns\" since a new named server dns client seems like no fun.  If you include a DNSTarget it will query the DNSServer for that and measure the responses.  If you don't care about actually performing a lookup just seeing if there is connectivity you can exclude DNSTarget and it'll just fall back to a tcpDial check.  I hope you find some value in it, I'll just keep it in my private repo if it doesn't meet up with your master plans.  The format is a flat out lift from who ever checked in the tcpchecker last night. =)\r\n\r\n\r\n\r\nThanks for your consideration. \r\n\r\nAlso, if you need me to fix something or somethings suck I'm very happy to resolve whatever.","created_at":"2016-08-11T21:15:05Z","updated_at":"2016-08-18T21:39:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82a59bf9007b70e48c413b51fbc19cdade602db3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sourcegraph/checkup/pulls/12/commits","review_comments_url":"https://api.github.com/repos/sourcegraph/checkup/pulls/12/comments","review_comment_url":"https://api.github.com/repos/sourcegraph/checkup/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sourcegraph/checkup/issues/12/comments","statuses_url":"https://api.github.com/repos/sourcegraph/checkup/statuses/ad69cbb957e2e4e1114039c8ffd365e3aee0efac","head":{"label":"gogosphere:master","ref":"master","sha":"ad69cbb957e2e4e1114039c8ffd365e3aee0efac","user":{"login":"gogosphere","id":20846757,"avatar_url":"https://avatars.githubusercontent.com/u/20846757?v=3","gravatar_id":"","url":"https://api.github.com/users/gogosphere","html_url":"https://github.com/gogosphere","followers_url":"https://api.github.com/users/gogosphere/followers","following_url":"https://api.github.com/users/gogosphere/following{/other_user}","gists_url":"https://api.github.com/users/gogosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/gogosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gogosphere/subscriptions","organizations_url":"https://api.github.com/users/gogosphere/orgs","repos_url":"https://api.github.com/users/gogosphere/repos","events_url":"https://api.github.com/users/gogosphere/events{/privacy}","received_events_url":"https://api.github.com/users/gogosphere/received_events","type":"User","site_admin":false},"repo":{"id":65335523,"name":"checkup","full_name":"gogosphere/checkup","owner":{"login":"gogosphere","id":20846757,"avatar_url":"https://avatars.githubusercontent.com/u/20846757?v=3","gravatar_id":"","url":"https://api.github.com/users/gogosphere","html_url":"https://github.com/gogosphere","followers_url":"https://api.github.com/users/gogosphere/followers","following_url":"https://api.github.com/users/gogosphere/following{/other_user}","gists_url":"https://api.github.com/users/gogosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/gogosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gogosphere/subscriptions","organizations_url":"https://api.github.com/users/gogosphere/orgs","repos_url":"https://api.github.com/users/gogosphere/repos","events_url":"https://api.github.com/users/gogosphere/events{/privacy}","received_events_url":"https://api.github.com/users/gogosphere/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gogosphere/checkup","description":"Distributed, lock-free, self-hosted health checks and status pages","fork":true,"url":"https://api.github.com/repos/gogosphere/checkup","forks_url":"https://api.github.com/repos/gogosphere/checkup/forks","keys_url":"https://api.github.com/repos/gogosphere/checkup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gogosphere/checkup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gogosphere/checkup/teams","hooks_url":"https://api.github.com/repos/gogosphere/checkup/hooks","issue_events_url":"https://api.github.com/repos/gogosphere/checkup/issues/events{/number}","events_url":"https://api.github.com/repos/gogosphere/checkup/events","assignees_url":"https://api.github.com/repos/gogosphere/checkup/assignees{/user}","branches_url":"https://api.github.com/repos/gogosphere/checkup/branches{/branch}","tags_url":"https://api.github.com/repos/gogosphere/checkup/tags","blobs_url":"https://api.github.com/repos/gogosphere/checkup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gogosphere/checkup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gogosphere/checkup/git/refs{/sha}","trees_url":"https://api.github.com/repos/gogosphere/checkup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gogosphere/checkup/statuses/{sha}","languages_url":"https://api.github.com/repos/gogosphere/checkup/languages","stargazers_url":"https://api.github.com/repos/gogosphere/checkup/stargazers","contributors_url":"https://api.github.com/repos/gogosphere/checkup/contributors","subscribers_url":"https://api.github.com/repos/gogosphere/checkup/subscribers","subscription_url":"https://api.github.com/repos/gogosphere/checkup/subscription","commits_url":"https://api.github.com/repos/gogosphere/checkup/commits{/sha}","git_commits_url":"https://api.github.com/repos/gogosphere/checkup/git/commits{/sha}","comments_url":"https://api.github.com/repos/gogosphere/checkup/comments{/number}","issue_comment_url":"https://api.github.com/repos/gogosphere/checkup/issues/comments{/number}","contents_url":"https://api.github.com/repos/gogosphere/checkup/contents/{+path}","compare_url":"https://api.github.com/repos/gogosphere/checkup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gogosphere/checkup/merges","archive_url":"https://api.github.com/repos/gogosphere/checkup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gogosphere/checkup/downloads","issues_url":"https://api.github.com/repos/gogosphere/checkup/issues{/number}","pulls_url":"https://api.github.com/repos/gogosphere/checkup/pulls{/number}","milestones_url":"https://api.github.com/repos/gogosphere/checkup/milestones{/number}","notifications_url":"https://api.github.com/repos/gogosphere/checkup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gogosphere/checkup/labels{/name}","releases_url":"https://api.github.com/repos/gogosphere/checkup/releases{/id}","deployments_url":"https://api.github.com/repos/gogosphere/checkup/deployments","created_at":"2016-08-09T23:41:42Z","updated_at":"2016-08-11T23:25:34Z","pushed_at":"2016-08-13T19:53:05Z","git_url":"git://github.com/gogosphere/checkup.git","ssh_url":"git@github.com:gogosphere/checkup.git","clone_url":"https://github.com/gogosphere/checkup.git","svn_url":"https://github.com/gogosphere/checkup","homepage":"https://sourcegraph.github.io/checkup","size":5569,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"sourcegraph:master","ref":"master","sha":"94097605f5f93dd2235ee9bdedfd54bfab88579e","user":{"login":"sourcegraph","id":3979584,"avatar_url":"https://avatars.githubusercontent.com/u/3979584?v=3","gravatar_id":"","url":"https://api.github.com/users/sourcegraph","html_url":"https://github.com/sourcegraph","followers_url":"https://api.github.com/users/sourcegraph/followers","following_url":"https://api.github.com/users/sourcegraph/following{/other_user}","gists_url":"https://api.github.com/users/sourcegraph/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcegraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcegraph/subscriptions","organizations_url":"https://api.github.com/users/sourcegraph/orgs","repos_url":"https://api.github.com/users/sourcegraph/repos","events_url":"https://api.github.com/users/sourcegraph/events{/privacy}","received_events_url":"https://api.github.com/users/sourcegraph/received_events","type":"Organization","site_admin":false},"repo":{"id":56108598,"name":"checkup","full_name":"sourcegraph/checkup","owner":{"login":"sourcegraph","id":3979584,"avatar_url":"https://avatars.githubusercontent.com/u/3979584?v=3","gravatar_id":"","url":"https://api.github.com/users/sourcegraph","html_url":"https://github.com/sourcegraph","followers_url":"https://api.github.com/users/sourcegraph/followers","following_url":"https://api.github.com/users/sourcegraph/following{/other_user}","gists_url":"https://api.github.com/users/sourcegraph/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcegraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcegraph/subscriptions","organizations_url":"https://api.github.com/users/sourcegraph/orgs","repos_url":"https://api.github.com/users/sourcegraph/repos","events_url":"https://api.github.com/users/sourcegraph/events{/privacy}","received_events_url":"https://api.github.com/users/sourcegraph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sourcegraph/checkup","description":"Distributed, lock-free, self-hosted health checks and status pages","fork":false,"url":"https://api.github.com/repos/sourcegraph/checkup","forks_url":"https://api.github.com/repos/sourcegraph/checkup/forks","keys_url":"https://api.github.com/repos/sourcegraph/checkup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sourcegraph/checkup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sourcegraph/checkup/teams","hooks_url":"https://api.github.com/repos/sourcegraph/checkup/hooks","issue_events_url":"https://api.github.com/repos/sourcegraph/checkup/issues/events{/number}","events_url":"https://api.github.com/repos/sourcegraph/checkup/events","assignees_url":"https://api.github.com/repos/sourcegraph/checkup/assignees{/user}","branches_url":"https://api.github.com/repos/sourcegraph/checkup/branches{/branch}","tags_url":"https://api.github.com/repos/sourcegraph/checkup/tags","blobs_url":"https://api.github.com/repos/sourcegraph/checkup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sourcegraph/checkup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sourcegraph/checkup/git/refs{/sha}","trees_url":"https://api.github.com/repos/sourcegraph/checkup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sourcegraph/checkup/statuses/{sha}","languages_url":"https://api.github.com/repos/sourcegraph/checkup/languages","stargazers_url":"https://api.github.com/repos/sourcegraph/checkup/stargazers","contributors_url":"https://api.github.com/repos/sourcegraph/checkup/contributors","subscribers_url":"https://api.github.com/repos/sourcegraph/checkup/subscribers","subscription_url":"https://api.github.com/repos/sourcegraph/checkup/subscription","commits_url":"https://api.github.com/repos/sourcegraph/checkup/commits{/sha}","git_commits_url":"https://api.github.com/repos/sourcegraph/checkup/git/commits{/sha}","comments_url":"https://api.github.com/repos/sourcegraph/checkup/comments{/number}","issue_comment_url":"https://api.github.com/repos/sourcegraph/checkup/issues/comments{/number}","contents_url":"https://api.github.com/repos/sourcegraph/checkup/contents/{+path}","compare_url":"https://api.github.com/repos/sourcegraph/checkup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sourcegraph/checkup/merges","archive_url":"https://api.github.com/repos/sourcegraph/checkup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sourcegraph/checkup/downloads","issues_url":"https://api.github.com/repos/sourcegraph/checkup/issues{/number}","pulls_url":"https://api.github.com/repos/sourcegraph/checkup/pulls{/number}","milestones_url":"https://api.github.com/repos/sourcegraph/checkup/milestones{/number}","notifications_url":"https://api.github.com/repos/sourcegraph/checkup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sourcegraph/checkup/labels{/name}","releases_url":"https://api.github.com/repos/sourcegraph/checkup/releases{/id}","deployments_url":"https://api.github.com/repos/sourcegraph/checkup/deployments","created_at":"2016-04-13T00:44:55Z","updated_at":"2016-08-18T19:08:33Z","pushed_at":"2016-08-14T17:25:20Z","git_url":"git://github.com/sourcegraph/checkup.git","ssh_url":"git@github.com:sourcegraph/checkup.git","clone_url":"https://github.com/sourcegraph/checkup.git","svn_url":"https://github.com/sourcegraph/checkup","homepage":"https://sourcegraph.github.io/checkup","size":392,"stargazers_count":1185,"watchers_count":1185,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":46,"mirror_url":null,"open_issues_count":13,"forks":46,"open_issues":13,"watchers":1185,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sourcegraph/checkup/pulls/12"},"html":{"href":"https://github.com/sourcegraph/checkup/pull/12"},"issue":{"href":"https://api.github.com/repos/sourcegraph/checkup/issues/12"},"comments":{"href":"https://api.github.com/repos/sourcegraph/checkup/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/sourcegraph/checkup/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/sourcegraph/checkup/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sourcegraph/checkup/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/sourcegraph/checkup/statuses/ad69cbb957e2e4e1114039c8ffd365e3aee0efac"}}}}
{"actor":{"display_login":"mholt"}}