{"action":"created","issue":{"url":"https://api.github.com/repos/lofar-astron/factor/issues/151","repository_url":"https://api.github.com/repos/lofar-astron/factor","labels_url":"https://api.github.com/repos/lofar-astron/factor/issues/151/labels{/name}","comments_url":"https://api.github.com/repos/lofar-astron/factor/issues/151/comments","events_url":"https://api.github.com/repos/lofar-astron/factor/issues/151/events","html_url":"https://github.com/lofar-astron/factor/issues/151","id":186669389,"number":151,"title":"facet imaging picks up artifacts because no proper mask is used","user":{"login":"rvweeren","id":3879473,"avatar_url":"https://avatars.githubusercontent.com/u/3879473?v=3","gravatar_id":"","url":"https://api.github.com/users/rvweeren","html_url":"https://github.com/rvweeren","followers_url":"https://api.github.com/users/rvweeren/followers","following_url":"https://api.github.com/users/rvweeren/following{/other_user}","gists_url":"https://api.github.com/users/rvweeren/gists{/gist_id}","starred_url":"https://api.github.com/users/rvweeren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvweeren/subscriptions","organizations_url":"https://api.github.com/users/rvweeren/orgs","repos_url":"https://api.github.com/users/rvweeren/repos","events_url":"https://api.github.com/users/rvweeren/events{/privacy}","received_events_url":"https://api.github.com/users/rvweeren/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":28,"created_at":"2016-11-01T22:51:21Z","updated_at":"2016-12-08T15:26:21Z","closed_at":null,"body":"I noticed that WSClean now runs only once when making the facet image (during the calibration). It looks like no mask is used anymore (only for the facet boundaries). Now I get clean components on artifacts around sources which subsequently end up in the \"facet model\". This is potentially very dangerous because if these artifacts belong to a source from a neighboring facet, which has not been calibrated yet, you can never get rid of them afterwards when that neighbor facet is calibrated. (because the artifacts now belong to another facet model which components are not added back)\r\n\r\nI see the desire to speed up the imaging, but we should be careful here not pushing things too far here. \r\n\r\n((Ideally we can do source detection on the fly in WSClean at each major cycle (via a sort of restart/resume option), that would remove the need to run WSClean twice.))"},"comment":{"url":"https://api.github.com/repos/lofar-astron/factor/issues/comments/265767381","html_url":"https://github.com/lofar-astron/factor/issues/151#issuecomment-265767381","issue_url":"https://api.github.com/repos/lofar-astron/factor/issues/151","id":265767381,"user":{"login":"aroffringa","id":11645549,"avatar_url":"https://avatars.githubusercontent.com/u/11645549?v=3","gravatar_id":"","url":"https://api.github.com/users/aroffringa","html_url":"https://github.com/aroffringa","followers_url":"https://api.github.com/users/aroffringa/followers","following_url":"https://api.github.com/users/aroffringa/following{/other_user}","gists_url":"https://api.github.com/users/aroffringa/gists{/gist_id}","starred_url":"https://api.github.com/users/aroffringa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aroffringa/subscriptions","organizations_url":"https://api.github.com/users/aroffringa/orgs","repos_url":"https://api.github.com/users/aroffringa/repos","events_url":"https://api.github.com/users/aroffringa/events{/privacy}","received_events_url":"https://api.github.com/users/aroffringa/received_events","type":"User","site_admin":false},"created_at":"2016-12-08T15:26:20Z","updated_at":"2016-12-08T15:26:20Z","body":"Did anyone test without Dysco, just to make sure that that is not the culprit?"}}
{"actor":{"display_login":"aroffringa"}}