{"action":"created","issue":{"url":"https://api.github.com/repos/PaperMC/Paper/issues/349","repository_url":"https://api.github.com/repos/PaperMC/Paper","labels_url":"https://api.github.com/repos/PaperMC/Paper/issues/349/labels{/name}","comments_url":"https://api.github.com/repos/PaperMC/Paper/issues/349/comments","events_url":"https://api.github.com/repos/PaperMC/Paper/issues/349/events","html_url":"https://github.com/PaperMC/Paper/pull/349","id":162059668,"number":349,"title":"Anti-Xray","user":{"login":"stonar96","id":18699205,"avatar_url":"https://avatars.githubusercontent.com/u/18699205?v=3","gravatar_id":"","url":"https://api.github.com/users/stonar96","html_url":"https://github.com/stonar96","followers_url":"https://api.github.com/users/stonar96/followers","following_url":"https://api.github.com/users/stonar96/following{/other_user}","gists_url":"https://api.github.com/users/stonar96/gists{/gist_id}","starred_url":"https://api.github.com/users/stonar96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stonar96/subscriptions","organizations_url":"https://api.github.com/users/stonar96/orgs","repos_url":"https://api.github.com/users/stonar96/repos","events_url":"https://api.github.com/users/stonar96/events{/privacy}","received_events_url":"https://api.github.com/users/stonar96/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":55,"created_at":"2016-06-24T01:45:57Z","updated_at":"2016-09-19T23:52:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PaperMC/Paper/pulls/349","html_url":"https://github.com/PaperMC/Paper/pull/349","diff_url":"https://github.com/PaperMC/Paper/pull/349.diff","patch_url":"https://github.com/PaperMC/Paper/pull/349.patch"},"body":"Paper inbuilt Anti-Xray. Asynchronous mode is configurable."},"comment":{"url":"https://api.github.com/repos/PaperMC/Paper/issues/comments/248162918","html_url":"https://github.com/PaperMC/Paper/pull/349#issuecomment-248162918","issue_url":"https://api.github.com/repos/PaperMC/Paper/issues/349","id":248162918,"user":{"login":"aikar","id":58008,"avatar_url":"https://avatars.githubusercontent.com/u/58008?v=3","gravatar_id":"","url":"https://api.github.com/users/aikar","html_url":"https://github.com/aikar","followers_url":"https://api.github.com/users/aikar/followers","following_url":"https://api.github.com/users/aikar/following{/other_user}","gists_url":"https://api.github.com/users/aikar/gists{/gist_id}","starred_url":"https://api.github.com/users/aikar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aikar/subscriptions","organizations_url":"https://api.github.com/users/aikar/orgs","repos_url":"https://api.github.com/users/aikar/repos","events_url":"https://api.github.com/users/aikar/events{/privacy}","received_events_url":"https://api.github.com/users/aikar/received_events","type":"User","site_admin":false},"created_at":"2016-09-19T23:52:43Z","updated_at":"2016-09-19T23:52:43Z","body":"Spigots anti xray abused \"relatively safe\" async operations in the past. I think I'm more comfortable with accessing the data async w/o locks, with the risk of changing more than the locks.\r\n\r\nWorst case scenario would be a block changing in a chunk that would either cover or uncover an obfuscated block, leaving it without a perfect result.\r\n\r\nHowever, the likelihood of this happening is sooooooo rare, as the player is guaranteed not going to be modifying a chunk that they are receiving, and the likelyhood of another player modifying the chunk as its being sent to another client in a way that actually impacts the receiving player is also rare.\r\n\r\nIf an ore was uncovered, the uncovering player is likely going to collect it themselves. But we are talking such extremely rare chance of this  scenario even occuring.\r\n\r\n@Zbob750 thoughts?\r\n\r\nIf it became a problem, we could work to resolve it then.\r\n\r\n"}}
{"actor":{"display_login":"aikar"}}