{"action":"created","comment":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/80236071","id":80236071,"diff_hunk":"@@ -84,7 +84,21 @@ public String toString()\n     protected final <Value> Value lookup( Key key, Reader<Value> reader ) throws IOException\n     {\n         ValueLookup<Value> lookup = new ValueLookup<>( reader );\n-        return lookup.value( !state.lookup( key, lookup ) );\n+        while ( true )\n+        {\n+            ProgressiveState<Key> originalState = this.state;\n+            try\n+            {\n+                return lookup.value( !this.state.lookup( key, lookup ) );","path":"community/kernel/src/main/java/org/neo4j/kernel/impl/store/kvstore/AbstractKeyValueStore.java","position":19,"original_position":19,"commit_id":"bbff81b8c8728998249e24d4f2d9db2bf2d08587","original_commit_id":"bbff81b8c8728998249e24d4f2d9db2bf2d08587","user":{"login":"thobe","id":104385,"avatar_url":"https://avatars.githubusercontent.com/u/104385?v=3","gravatar_id":"","url":"https://api.github.com/users/thobe","html_url":"https://github.com/thobe","followers_url":"https://api.github.com/users/thobe/followers","following_url":"https://api.github.com/users/thobe/following{/other_user}","gists_url":"https://api.github.com/users/thobe/gists{/gist_id}","starred_url":"https://api.github.com/users/thobe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thobe/subscriptions","organizations_url":"https://api.github.com/users/thobe/orgs","repos_url":"https://api.github.com/users/thobe/repos","events_url":"https://api.github.com/users/thobe/events{/privacy}","received_events_url":"https://api.github.com/users/thobe/received_events","type":"User","site_admin":false},"body":"I'd use `originalState` rather than `this.state` here, to not have to do multiple volatile reads.","created_at":"2016-09-23T12:39:45Z","updated_at":"2016-09-23T12:53:38Z","html_url":"https://github.com/neo4j/neo4j/pull/8003#discussion_r80236071","pull_request_url":"https://api.github.com/repos/neo4j/neo4j/pulls/8003","_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/80236071"},"html":{"href":"https://github.com/neo4j/neo4j/pull/8003#discussion_r80236071"},"pull_request":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/8003"}}},"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/8003","id":86344509,"html_url":"https://github.com/neo4j/neo4j/pull/8003","diff_url":"https://github.com/neo4j/neo4j/pull/8003.diff","patch_url":"https://github.com/neo4j/neo4j/pull/8003.patch","issue_url":"https://api.github.com/repos/neo4j/neo4j/issues/8003","number":8003,"state":"open","locked":false,"title":"Retry count store lookup in case of concurrent state change.","user":{"login":"MishaDemianenko","id":12656787,"avatar_url":"https://avatars.githubusercontent.com/u/12656787?v=3","gravatar_id":"","url":"https://api.github.com/users/MishaDemianenko","html_url":"https://github.com/MishaDemianenko","followers_url":"https://api.github.com/users/MishaDemianenko/followers","following_url":"https://api.github.com/users/MishaDemianenko/following{/other_user}","gists_url":"https://api.github.com/users/MishaDemianenko/gists{/gist_id}","starred_url":"https://api.github.com/users/MishaDemianenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MishaDemianenko/subscriptions","organizations_url":"https://api.github.com/users/MishaDemianenko/orgs","repos_url":"https://api.github.com/users/MishaDemianenko/repos","events_url":"https://api.github.com/users/MishaDemianenko/events{/privacy}","received_events_url":"https://api.github.com/users/MishaDemianenko/received_events","type":"User","site_admin":false},"body":"Count store perform all lookup operation using current state without grabbing any kind of locks.\r\nDuring any rotation that state will be substituted by new state and closed.\r\nAll new readers will use new state automatically.\r\nThe problem manifest itself when reader start lookup operation using state that was active when reader starts, but is already rotated and closed by count store rotation.\r\nThe most simple solution was chosen: we will retry lookup operation in case of IllegalStateException and state change.\r\n\r\nFixes #6787","created_at":"2016-09-22T14:08:24Z","updated_at":"2016-09-23T12:53:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"72767f2ed298b75894529f5575d6d449350382f3","assignee":{"login":"lutovich","id":1638145,"avatar_url":"https://avatars.githubusercontent.com/u/1638145?v=3","gravatar_id":"","url":"https://api.github.com/users/lutovich","html_url":"https://github.com/lutovich","followers_url":"https://api.github.com/users/lutovich/followers","following_url":"https://api.github.com/users/lutovich/following{/other_user}","gists_url":"https://api.github.com/users/lutovich/gists{/gist_id}","starred_url":"https://api.github.com/users/lutovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lutovich/subscriptions","organizations_url":"https://api.github.com/users/lutovich/orgs","repos_url":"https://api.github.com/users/lutovich/repos","events_url":"https://api.github.com/users/lutovich/events{/privacy}","received_events_url":"https://api.github.com/users/lutovich/received_events","type":"User","site_admin":false},"assignees":[{"login":"lutovich","id":1638145,"avatar_url":"https://avatars.githubusercontent.com/u/1638145?v=3","gravatar_id":"","url":"https://api.github.com/users/lutovich","html_url":"https://github.com/lutovich","followers_url":"https://api.github.com/users/lutovich/followers","following_url":"https://api.github.com/users/lutovich/following{/other_user}","gists_url":"https://api.github.com/users/lutovich/gists{/gist_id}","starred_url":"https://api.github.com/users/lutovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lutovich/subscriptions","organizations_url":"https://api.github.com/users/lutovich/orgs","repos_url":"https://api.github.com/users/lutovich/repos","events_url":"https://api.github.com/users/lutovich/events{/privacy}","received_events_url":"https://api.github.com/users/lutovich/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/neo4j/neo4j/pulls/8003/commits","review_comments_url":"https://api.github.com/repos/neo4j/neo4j/pulls/8003/comments","review_comment_url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo4j/neo4j/issues/8003/comments","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/bbff81b8c8728998249e24d4f2d9db2bf2d08587","head":{"label":"MishaDemianenko:2.3-count-store-conc-rotation","ref":"2.3-count-store-conc-rotation","sha":"bbff81b8c8728998249e24d4f2d9db2bf2d08587","user":{"login":"MishaDemianenko","id":12656787,"avatar_url":"https://avatars.githubusercontent.com/u/12656787?v=3","gravatar_id":"","url":"https://api.github.com/users/MishaDemianenko","html_url":"https://github.com/MishaDemianenko","followers_url":"https://api.github.com/users/MishaDemianenko/followers","following_url":"https://api.github.com/users/MishaDemianenko/following{/other_user}","gists_url":"https://api.github.com/users/MishaDemianenko/gists{/gist_id}","starred_url":"https://api.github.com/users/MishaDemianenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MishaDemianenko/subscriptions","organizations_url":"https://api.github.com/users/MishaDemianenko/orgs","repos_url":"https://api.github.com/users/MishaDemianenko/repos","events_url":"https://api.github.com/users/MishaDemianenko/events{/privacy}","received_events_url":"https://api.github.com/users/MishaDemianenko/received_events","type":"User","site_admin":false},"repo":{"id":36607274,"name":"neo4j","full_name":"MishaDemianenko/neo4j","owner":{"login":"MishaDemianenko","id":12656787,"avatar_url":"https://avatars.githubusercontent.com/u/12656787?v=3","gravatar_id":"","url":"https://api.github.com/users/MishaDemianenko","html_url":"https://github.com/MishaDemianenko","followers_url":"https://api.github.com/users/MishaDemianenko/followers","following_url":"https://api.github.com/users/MishaDemianenko/following{/other_user}","gists_url":"https://api.github.com/users/MishaDemianenko/gists{/gist_id}","starred_url":"https://api.github.com/users/MishaDemianenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MishaDemianenko/subscriptions","organizations_url":"https://api.github.com/users/MishaDemianenko/orgs","repos_url":"https://api.github.com/users/MishaDemianenko/repos","events_url":"https://api.github.com/users/MishaDemianenko/events{/privacy}","received_events_url":"https://api.github.com/users/MishaDemianenko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MishaDemianenko/neo4j","description":"Graphs for Everyone","fork":true,"url":"https://api.github.com/repos/MishaDemianenko/neo4j","forks_url":"https://api.github.com/repos/MishaDemianenko/neo4j/forks","keys_url":"https://api.github.com/repos/MishaDemianenko/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MishaDemianenko/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MishaDemianenko/neo4j/teams","hooks_url":"https://api.github.com/repos/MishaDemianenko/neo4j/hooks","issue_events_url":"https://api.github.com/repos/MishaDemianenko/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/MishaDemianenko/neo4j/events","assignees_url":"https://api.github.com/repos/MishaDemianenko/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/MishaDemianenko/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/MishaDemianenko/neo4j/tags","blobs_url":"https://api.github.com/repos/MishaDemianenko/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MishaDemianenko/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MishaDemianenko/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/MishaDemianenko/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MishaDemianenko/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/MishaDemianenko/neo4j/languages","stargazers_url":"https://api.github.com/repos/MishaDemianenko/neo4j/stargazers","contributors_url":"https://api.github.com/repos/MishaDemianenko/neo4j/contributors","subscribers_url":"https://api.github.com/repos/MishaDemianenko/neo4j/subscribers","subscription_url":"https://api.github.com/repos/MishaDemianenko/neo4j/subscription","commits_url":"https://api.github.com/repos/MishaDemianenko/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/MishaDemianenko/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/MishaDemianenko/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/MishaDemianenko/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/MishaDemianenko/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/MishaDemianenko/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MishaDemianenko/neo4j/merges","archive_url":"https://api.github.com/repos/MishaDemianenko/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MishaDemianenko/neo4j/downloads","issues_url":"https://api.github.com/repos/MishaDemianenko/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/MishaDemianenko/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/MishaDemianenko/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/MishaDemianenko/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MishaDemianenko/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/MishaDemianenko/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/MishaDemianenko/neo4j/deployments","created_at":"2015-05-31T14:44:24Z","updated_at":"2015-05-31T14:44:50Z","pushed_at":"2016-09-22T14:07:41Z","git_url":"git://github.com/MishaDemianenko/neo4j.git","ssh_url":"git@github.com:MishaDemianenko/neo4j.git","clone_url":"https://github.com/MishaDemianenko/neo4j.git","svn_url":"https://github.com/MishaDemianenko/neo4j","homepage":"http://neo4j.com","size":306449,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.3"}},"base":{"label":"neo4j:2.3","ref":"2.3","sha":"b94896e4b75a06d8982d4c92bc8f62c5e206f0dc","user":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"repo":{"id":6650539,"name":"neo4j","full_name":"neo4j/neo4j","owner":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo4j/neo4j","description":"Graphs for Everyone","fork":false,"url":"https://api.github.com/repos/neo4j/neo4j","forks_url":"https://api.github.com/repos/neo4j/neo4j/forks","keys_url":"https://api.github.com/repos/neo4j/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4j/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4j/neo4j/teams","hooks_url":"https://api.github.com/repos/neo4j/neo4j/hooks","issue_events_url":"https://api.github.com/repos/neo4j/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/neo4j/neo4j/events","assignees_url":"https://api.github.com/repos/neo4j/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/neo4j/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/neo4j/neo4j/tags","blobs_url":"https://api.github.com/repos/neo4j/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4j/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4j/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4j/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4j/neo4j/languages","stargazers_url":"https://api.github.com/repos/neo4j/neo4j/stargazers","contributors_url":"https://api.github.com/repos/neo4j/neo4j/contributors","subscribers_url":"https://api.github.com/repos/neo4j/neo4j/subscribers","subscription_url":"https://api.github.com/repos/neo4j/neo4j/subscription","commits_url":"https://api.github.com/repos/neo4j/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4j/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4j/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4j/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo4j/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/neo4j/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4j/neo4j/merges","archive_url":"https://api.github.com/repos/neo4j/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4j/neo4j/downloads","issues_url":"https://api.github.com/repos/neo4j/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/neo4j/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4j/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4j/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4j/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/neo4j/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/neo4j/neo4j/deployments","created_at":"2012-11-12T08:46:15Z","updated_at":"2016-09-23T10:37:35Z","pushed_at":"2016-09-23T12:38:20Z","git_url":"git://github.com/neo4j/neo4j.git","ssh_url":"git@github.com:neo4j/neo4j.git","clone_url":"https://github.com/neo4j/neo4j.git","svn_url":"https://github.com/neo4j/neo4j","homepage":"http://neo4j.com","size":373409,"stargazers_count":3006,"watchers_count":3006,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":991,"mirror_url":null,"open_issues_count":399,"forks":991,"open_issues":399,"watchers":3006,"default_branch":"3.1"}},"_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/8003"},"html":{"href":"https://github.com/neo4j/neo4j/pull/8003"},"issue":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/8003"},"comments":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/8003/comments"},"review_comments":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/8003/comments"},"review_comment":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/8003/commits"},"statuses":{"href":"https://api.github.com/repos/neo4j/neo4j/statuses/bbff81b8c8728998249e24d4f2d9db2bf2d08587"}}}}
{"actor":{"display_login":"thobe"}}