{"action":"opened","number":40,"pull_request":{"url":"https://api.github.com/repos/japaric/rustc-builtins/pulls/40","id":81581325,"html_url":"https://github.com/japaric/rustc-builtins/pull/40","diff_url":"https://github.com/japaric/rustc-builtins/pull/40.diff","patch_url":"https://github.com/japaric/rustc-builtins/pull/40.patch","issue_url":"https://api.github.com/repos/japaric/rustc-builtins/issues/40","number":40,"state":"open","locked":false,"title":"Add x86_64 builtins","user":{"login":"mattico","id":853158,"avatar_url":"https://avatars.githubusercontent.com/u/853158?v=3","gravatar_id":"","url":"https://api.github.com/users/mattico","html_url":"https://github.com/mattico","followers_url":"https://api.github.com/users/mattico/followers","following_url":"https://api.github.com/users/mattico/following{/other_user}","gists_url":"https://api.github.com/users/mattico/gists{/gist_id}","starred_url":"https://api.github.com/users/mattico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattico/subscriptions","organizations_url":"https://api.github.com/users/mattico/orgs","repos_url":"https://api.github.com/users/mattico/repos","events_url":"https://api.github.com/users/mattico/events{/privacy}","received_events_url":"https://api.github.com/users/mattico/received_events","type":"User","site_admin":false},"body":"This is a fairly straightforward port of the original assembly files. I'm hoping to help port a whole bunch of these builtins over the next few days, so let me know if you have any style or other concerns. I don't believe that these functions have any tests in compiler-rt and they would be quite difficult functions to test. Nonetheless, I'm going to attempt to find a windows binary that exercises these and swap them in to see if anything breaks.\r\n\r\nTwo notes:\r\n- `__alloca` falls through to `___chkstk` in the original assembly. I think having a function call there is the best way to implement this reliably, other than duplicating the assembly.\r\n- The original assembly files don't appear to be conditionally compiled, but are noted as only being used on Windows, so I am conditionally compiling them now.","created_at":"2016-08-17T04:05:32Z","updated_at":"2016-08-17T04:05:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/japaric/rustc-builtins/pulls/40/commits","review_comments_url":"https://api.github.com/repos/japaric/rustc-builtins/pulls/40/comments","review_comment_url":"https://api.github.com/repos/japaric/rustc-builtins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/japaric/rustc-builtins/issues/40/comments","statuses_url":"https://api.github.com/repos/japaric/rustc-builtins/statuses/b6091ababa6934a13963e56c61501a434d27351b","head":{"label":"mattico:add-x86_64","ref":"add-x86_64","sha":"b6091ababa6934a13963e56c61501a434d27351b","user":{"login":"mattico","id":853158,"avatar_url":"https://avatars.githubusercontent.com/u/853158?v=3","gravatar_id":"","url":"https://api.github.com/users/mattico","html_url":"https://github.com/mattico","followers_url":"https://api.github.com/users/mattico/followers","following_url":"https://api.github.com/users/mattico/following{/other_user}","gists_url":"https://api.github.com/users/mattico/gists{/gist_id}","starred_url":"https://api.github.com/users/mattico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattico/subscriptions","organizations_url":"https://api.github.com/users/mattico/orgs","repos_url":"https://api.github.com/users/mattico/repos","events_url":"https://api.github.com/users/mattico/events{/privacy}","received_events_url":"https://api.github.com/users/mattico/received_events","type":"User","site_admin":false},"repo":{"id":65842253,"name":"rustc-builtins","full_name":"mattico/rustc-builtins","owner":{"login":"mattico","id":853158,"avatar_url":"https://avatars.githubusercontent.com/u/853158?v=3","gravatar_id":"","url":"https://api.github.com/users/mattico","html_url":"https://github.com/mattico","followers_url":"https://api.github.com/users/mattico/followers","following_url":"https://api.github.com/users/mattico/following{/other_user}","gists_url":"https://api.github.com/users/mattico/gists{/gist_id}","starred_url":"https://api.github.com/users/mattico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattico/subscriptions","organizations_url":"https://api.github.com/users/mattico/orgs","repos_url":"https://api.github.com/users/mattico/repos","events_url":"https://api.github.com/users/mattico/events{/privacy}","received_events_url":"https://api.github.com/users/mattico/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mattico/rustc-builtins","description":"[WIP] Porting `compiler-rt` intrinsics to Rust","fork":true,"url":"https://api.github.com/repos/mattico/rustc-builtins","forks_url":"https://api.github.com/repos/mattico/rustc-builtins/forks","keys_url":"https://api.github.com/repos/mattico/rustc-builtins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattico/rustc-builtins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattico/rustc-builtins/teams","hooks_url":"https://api.github.com/repos/mattico/rustc-builtins/hooks","issue_events_url":"https://api.github.com/repos/mattico/rustc-builtins/issues/events{/number}","events_url":"https://api.github.com/repos/mattico/rustc-builtins/events","assignees_url":"https://api.github.com/repos/mattico/rustc-builtins/assignees{/user}","branches_url":"https://api.github.com/repos/mattico/rustc-builtins/branches{/branch}","tags_url":"https://api.github.com/repos/mattico/rustc-builtins/tags","blobs_url":"https://api.github.com/repos/mattico/rustc-builtins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattico/rustc-builtins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattico/rustc-builtins/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattico/rustc-builtins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattico/rustc-builtins/statuses/{sha}","languages_url":"https://api.github.com/repos/mattico/rustc-builtins/languages","stargazers_url":"https://api.github.com/repos/mattico/rustc-builtins/stargazers","contributors_url":"https://api.github.com/repos/mattico/rustc-builtins/contributors","subscribers_url":"https://api.github.com/repos/mattico/rustc-builtins/subscribers","subscription_url":"https://api.github.com/repos/mattico/rustc-builtins/subscription","commits_url":"https://api.github.com/repos/mattico/rustc-builtins/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattico/rustc-builtins/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattico/rustc-builtins/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattico/rustc-builtins/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattico/rustc-builtins/contents/{+path}","compare_url":"https://api.github.com/repos/mattico/rustc-builtins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattico/rustc-builtins/merges","archive_url":"https://api.github.com/repos/mattico/rustc-builtins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattico/rustc-builtins/downloads","issues_url":"https://api.github.com/repos/mattico/rustc-builtins/issues{/number}","pulls_url":"https://api.github.com/repos/mattico/rustc-builtins/pulls{/number}","milestones_url":"https://api.github.com/repos/mattico/rustc-builtins/milestones{/number}","notifications_url":"https://api.github.com/repos/mattico/rustc-builtins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattico/rustc-builtins/labels{/name}","releases_url":"https://api.github.com/repos/mattico/rustc-builtins/releases{/id}","deployments_url":"https://api.github.com/repos/mattico/rustc-builtins/deployments","created_at":"2016-08-16T18:02:23Z","updated_at":"2016-08-16T18:02:24Z","pushed_at":"2016-08-17T00:55:28Z","git_url":"git://github.com/mattico/rustc-builtins.git","ssh_url":"git@github.com:mattico/rustc-builtins.git","clone_url":"https://github.com/mattico/rustc-builtins.git","svn_url":"https://github.com/mattico/rustc-builtins","homepage":"https://github.com/rust-lang/rust/issues/35437","size":85,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"japaric:master","ref":"master","sha":"89594e16aedd50debdefc6f5990bfb6fd55a404a","user":{"login":"japaric","id":5018213,"avatar_url":"https://avatars.githubusercontent.com/u/5018213?v=3","gravatar_id":"","url":"https://api.github.com/users/japaric","html_url":"https://github.com/japaric","followers_url":"https://api.github.com/users/japaric/followers","following_url":"https://api.github.com/users/japaric/following{/other_user}","gists_url":"https://api.github.com/users/japaric/gists{/gist_id}","starred_url":"https://api.github.com/users/japaric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/japaric/subscriptions","organizations_url":"https://api.github.com/users/japaric/orgs","repos_url":"https://api.github.com/users/japaric/repos","events_url":"https://api.github.com/users/japaric/events{/privacy}","received_events_url":"https://api.github.com/users/japaric/received_events","type":"User","site_admin":false},"repo":{"id":65153793,"name":"rustc-builtins","full_name":"japaric/rustc-builtins","owner":{"login":"japaric","id":5018213,"avatar_url":"https://avatars.githubusercontent.com/u/5018213?v=3","gravatar_id":"","url":"https://api.github.com/users/japaric","html_url":"https://github.com/japaric","followers_url":"https://api.github.com/users/japaric/followers","following_url":"https://api.github.com/users/japaric/following{/other_user}","gists_url":"https://api.github.com/users/japaric/gists{/gist_id}","starred_url":"https://api.github.com/users/japaric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/japaric/subscriptions","organizations_url":"https://api.github.com/users/japaric/orgs","repos_url":"https://api.github.com/users/japaric/repos","events_url":"https://api.github.com/users/japaric/events{/privacy}","received_events_url":"https://api.github.com/users/japaric/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/japaric/rustc-builtins","description":"[WIP] Porting `compiler-rt` intrinsics to Rust","fork":false,"url":"https://api.github.com/repos/japaric/rustc-builtins","forks_url":"https://api.github.com/repos/japaric/rustc-builtins/forks","keys_url":"https://api.github.com/repos/japaric/rustc-builtins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/japaric/rustc-builtins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/japaric/rustc-builtins/teams","hooks_url":"https://api.github.com/repos/japaric/rustc-builtins/hooks","issue_events_url":"https://api.github.com/repos/japaric/rustc-builtins/issues/events{/number}","events_url":"https://api.github.com/repos/japaric/rustc-builtins/events","assignees_url":"https://api.github.com/repos/japaric/rustc-builtins/assignees{/user}","branches_url":"https://api.github.com/repos/japaric/rustc-builtins/branches{/branch}","tags_url":"https://api.github.com/repos/japaric/rustc-builtins/tags","blobs_url":"https://api.github.com/repos/japaric/rustc-builtins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/japaric/rustc-builtins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/japaric/rustc-builtins/git/refs{/sha}","trees_url":"https://api.github.com/repos/japaric/rustc-builtins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/japaric/rustc-builtins/statuses/{sha}","languages_url":"https://api.github.com/repos/japaric/rustc-builtins/languages","stargazers_url":"https://api.github.com/repos/japaric/rustc-builtins/stargazers","contributors_url":"https://api.github.com/repos/japaric/rustc-builtins/contributors","subscribers_url":"https://api.github.com/repos/japaric/rustc-builtins/subscribers","subscription_url":"https://api.github.com/repos/japaric/rustc-builtins/subscription","commits_url":"https://api.github.com/repos/japaric/rustc-builtins/commits{/sha}","git_commits_url":"https://api.github.com/repos/japaric/rustc-builtins/git/commits{/sha}","comments_url":"https://api.github.com/repos/japaric/rustc-builtins/comments{/number}","issue_comment_url":"https://api.github.com/repos/japaric/rustc-builtins/issues/comments{/number}","contents_url":"https://api.github.com/repos/japaric/rustc-builtins/contents/{+path}","compare_url":"https://api.github.com/repos/japaric/rustc-builtins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/japaric/rustc-builtins/merges","archive_url":"https://api.github.com/repos/japaric/rustc-builtins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/japaric/rustc-builtins/downloads","issues_url":"https://api.github.com/repos/japaric/rustc-builtins/issues{/number}","pulls_url":"https://api.github.com/repos/japaric/rustc-builtins/pulls{/number}","milestones_url":"https://api.github.com/repos/japaric/rustc-builtins/milestones{/number}","notifications_url":"https://api.github.com/repos/japaric/rustc-builtins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/japaric/rustc-builtins/labels{/name}","releases_url":"https://api.github.com/repos/japaric/rustc-builtins/releases{/id}","deployments_url":"https://api.github.com/repos/japaric/rustc-builtins/deployments","created_at":"2016-08-07T20:58:44Z","updated_at":"2016-08-11T07:08:29Z","pushed_at":"2016-08-16T22:56:37Z","git_url":"git://github.com/japaric/rustc-builtins.git","ssh_url":"git@github.com:japaric/rustc-builtins.git","clone_url":"https://github.com/japaric/rustc-builtins.git","svn_url":"https://github.com/japaric/rustc-builtins","homepage":"https://github.com/rust-lang/rust/issues/35437","size":88,"stargazers_count":6,"watchers_count":6,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/japaric/rustc-builtins/pulls/40"},"html":{"href":"https://github.com/japaric/rustc-builtins/pull/40"},"issue":{"href":"https://api.github.com/repos/japaric/rustc-builtins/issues/40"},"comments":{"href":"https://api.github.com/repos/japaric/rustc-builtins/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/japaric/rustc-builtins/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/japaric/rustc-builtins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/japaric/rustc-builtins/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/japaric/rustc-builtins/statuses/b6091ababa6934a13963e56c61501a434d27351b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":70,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"mattico"}}