{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react/issues/7718","repository_url":"https://api.github.com/repos/facebook/react","labels_url":"https://api.github.com/repos/facebook/react/issues/7718/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react/issues/7718/comments","events_url":"https://api.github.com/repos/facebook/react/issues/7718/events","html_url":"https://github.com/facebook/react/issues/7718","id":176704328,"number":7718,"title":"Bug: False Positive \"plain object\" Warning  ","user":{"login":"spudly","id":487068,"avatar_url":"https://avatars.githubusercontent.com/u/487068?v=3","gravatar_id":"","url":"https://api.github.com/users/spudly","html_url":"https://github.com/spudly","followers_url":"https://api.github.com/users/spudly/followers","following_url":"https://api.github.com/users/spudly/following{/other_user}","gists_url":"https://api.github.com/users/spudly/gists{/gist_id}","starred_url":"https://api.github.com/users/spudly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spudly/subscriptions","organizations_url":"https://api.github.com/users/spudly/orgs","repos_url":"https://api.github.com/users/spudly/repos","events_url":"https://api.github.com/users/spudly/events{/privacy}","received_events_url":"https://api.github.com/users/spudly/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/react/labels/good%20first%20bug","name":"good first bug","color":"009800"},{"url":"https://api.github.com/repos/facebook/react/labels/Type:%20Bug","name":"Type: Bug","color":"fc2929"}],"state":"open","locked":false,"assignee":{"login":"spicyj","id":6820,"avatar_url":"https://avatars.githubusercontent.com/u/6820?v=3","gravatar_id":"","url":"https://api.github.com/users/spicyj","html_url":"https://github.com/spicyj","followers_url":"https://api.github.com/users/spicyj/followers","following_url":"https://api.github.com/users/spicyj/following{/other_user}","gists_url":"https://api.github.com/users/spicyj/gists{/gist_id}","starred_url":"https://api.github.com/users/spicyj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spicyj/subscriptions","organizations_url":"https://api.github.com/users/spicyj/orgs","repos_url":"https://api.github.com/users/spicyj/repos","events_url":"https://api.github.com/users/spicyj/events{/privacy}","received_events_url":"https://api.github.com/users/spicyj/received_events","type":"User","site_admin":false},"assignees":[{"login":"spicyj","id":6820,"avatar_url":"https://avatars.githubusercontent.com/u/6820?v=3","gravatar_id":"","url":"https://api.github.com/users/spicyj","html_url":"https://github.com/spicyj","followers_url":"https://api.github.com/users/spicyj/followers","following_url":"https://api.github.com/users/spicyj/following{/other_user}","gists_url":"https://api.github.com/users/spicyj/gists{/gist_id}","starred_url":"https://api.github.com/users/spicyj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spicyj/subscriptions","organizations_url":"https://api.github.com/users/spicyj/orgs","repos_url":"https://api.github.com/users/spicyj/repos","events_url":"https://api.github.com/users/spicyj/events{/privacy}","received_events_url":"https://api.github.com/users/spicyj/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2016-09-13T17:42:15Z","updated_at":"2016-09-13T23:02:42Z","closed_at":null,"body":"There is a bug in the logic for determining if `props` is a plain object. This bug results in a false positive, flooding the console with hundreds of instances of this warning: \"Expected props argument to be a plain object. Properties defined in its prototype chain will be ignored.\".\r\n\r\nThe code that's failing is in [ReactElement.js, Line 210 in the v15.3.1 branch](https://github.com/facebook/react/blob/v15.3.1/src/isomorphic/classic/element/ReactElement.js#L210) (line number is probably different in master)\r\n\r\n> config.__proto__ == null || config.__proto__ === Object.prototype,\r\n\r\nThis fails when the props object is created in one iframe, but uses an instance of React from another frame. Each browser window/tab/frame has it's own instance of the Object constructor. For instance, `document.querySelector('iframe').contentWindow.Object === Object` always results in `false`.\r\n\r\nCheck out this [demo](https://jsfiddle.net/05ugxo5f/4/), which shows the false-positive warning message."},"comment":{"url":"https://api.github.com/repos/facebook/react/issues/comments/246853571","html_url":"https://github.com/facebook/react/issues/7718#issuecomment-246853571","issue_url":"https://api.github.com/repos/facebook/react/issues/7718","id":246853571,"user":{"login":"spicyj","id":6820,"avatar_url":"https://avatars.githubusercontent.com/u/6820?v=3","gravatar_id":"","url":"https://api.github.com/users/spicyj","html_url":"https://github.com/spicyj","followers_url":"https://api.github.com/users/spicyj/followers","following_url":"https://api.github.com/users/spicyj/following{/other_user}","gists_url":"https://api.github.com/users/spicyj/gists{/gist_id}","starred_url":"https://api.github.com/users/spicyj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spicyj/subscriptions","organizations_url":"https://api.github.com/users/spicyj/orgs","repos_url":"https://api.github.com/users/spicyj/repos","events_url":"https://api.github.com/users/spicyj/events{/privacy}","received_events_url":"https://api.github.com/users/spicyj/received_events","type":"User","site_admin":false},"created_at":"2016-09-13T23:02:42Z","updated_at":"2016-09-13T23:02:42Z","body":"Okay, let's remove these lines and any associated tests:\r\n\r\nhttps://github.com/facebook/react/blob/v15.3.1/src/isomorphic/classic/element/ReactElement.js#L207-L215"}}
{"actor":{"display_login":"spicyj"}}