{"push_id":1213678580,"size":4,"distinct_size":1,"ref":"refs/heads/extended_tls_sockets","head":"2c07ab42367293207f19b09abe853fd26a95a4aa","before":"2c15bdfcf7235c2557f4e847382f2367f331a9b1","commits":[{"sha":"346c52dc7c65b87cce9881b5e045756ee1c26f7e","author":{"name":"David Cooper","email":"bd07968fe1548f762be87be0de640b4db395569f@gmail.com"},"message":"CA names with domain component attributes\n\n`certificate_info()` does not correctly display the Issuer name for CAs that use domain component attributes.\r\n\r\nThere is a server on the NIST intra-net that I test against that has a certificate issued by a NIST CA, and the issuer name in the certificate is of the form: `/DC=net/DC=example/DC=internal/CN=CAname`\r\n\r\nSince there is no organizational name, testssl.sh displays the name as:\r\n```\r\n Issuer                       \"CAname\" (\"\")\r\n```\r\nIn this PR, if the Issuer name has 'DC=' attributes, but does not have an 'O=' attribute, the \"DC=\" attributes are combined into a DNS name that is used as if it were the organizational name:\r\n```\r\n Issuer                       \"CAname\" (\"internal.example.net\")\r\n```\r\nI should note, however, that I have not been able to find any other examples of TLS server certificates that have been issued by CAs that have domain components (\"DC=\") in their names. So, it may not be worthwhile to change the code to try to accommodate such CAs.","distinct":false,"url":"https://api.github.com/repos/dcooper16/testssl.sh/commits/346c52dc7c65b87cce9881b5e045756ee1c26f7e"},{"sha":"bdea1a0971b5023d01038bffce8287b7b968f2f7","author":{"name":"David Cooper","email":"bd07968fe1548f762be87be0de640b4db395569f@gmail.com"},"message":"Merge branch 'master' into issuer2\n\nConflicts:\n\ttestssl.sh","distinct":false,"url":"https://api.github.com/repos/dcooper16/testssl.sh/commits/bdea1a0971b5023d01038bffce8287b7b968f2f7"},{"sha":"ddead05825ca0f27d019bbf8e7ec94a720a0ee55","author":{"name":"Dirk Wetter","email":"df9a1bebbef55e31c4e4a0e37513ff4bffcc13e5@testssl.sh"},"message":"Merge pull request #418 from dcooper16/issuer2\n\nCA names with domain component attributes","distinct":false,"url":"https://api.github.com/repos/dcooper16/testssl.sh/commits/ddead05825ca0f27d019bbf8e7ec94a720a0ee55"},{"sha":"2c07ab42367293207f19b09abe853fd26a95a4aa","author":{"name":"David Cooper","email":"bd07968fe1548f762be87be0de640b4db395569f@gmail.com"},"message":"Merge branch 'master' into extended_tls_sockets","distinct":true,"url":"https://api.github.com/repos/dcooper16/testssl.sh/commits/2c07ab42367293207f19b09abe853fd26a95a4aa"}]}
{"actor":{"display_login":"dcooper16"}}