{"action":"closed","issue":{"url":"https://api.github.com/repos/Rdatatable/data.table/issues/1641","repository_url":"https://api.github.com/repos/Rdatatable/data.table","labels_url":"https://api.github.com/repos/Rdatatable/data.table/issues/1641/labels{/name}","comments_url":"https://api.github.com/repos/Rdatatable/data.table/issues/1641/comments","events_url":"https://api.github.com/repos/Rdatatable/data.table/issues/1641/events","html_url":"https://github.com/Rdatatable/data.table/issues/1641","id":147542905,"number":1641,"title":"maintain R 2.15.0 support (for managed environments)","user":{"login":"jangorecki","id":3627377,"avatar_url":"https://avatars.githubusercontent.com/u/3627377?v=3","gravatar_id":"","url":"https://api.github.com/users/jangorecki","html_url":"https://github.com/jangorecki","followers_url":"https://api.github.com/users/jangorecki/followers","following_url":"https://api.github.com/users/jangorecki/following{/other_user}","gists_url":"https://api.github.com/users/jangorecki/gists{/gist_id}","starred_url":"https://api.github.com/users/jangorecki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jangorecki/subscriptions","organizations_url":"https://api.github.com/users/jangorecki/orgs","repos_url":"https://api.github.com/users/jangorecki/repos","events_url":"https://api.github.com/users/jangorecki/events{/privacy}","received_events_url":"https://api.github.com/users/jangorecki/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Rdatatable/data.table/labels/ci","name":"ci","color":"eb6420"},{"url":"https://api.github.com/repos/Rdatatable/data.table/labels/internals","name":"internals","color":"009800"}],"state":"closed","locked":false,"assignee":{"login":"jangorecki","id":3627377,"avatar_url":"https://avatars.githubusercontent.com/u/3627377?v=3","gravatar_id":"","url":"https://api.github.com/users/jangorecki","html_url":"https://github.com/jangorecki","followers_url":"https://api.github.com/users/jangorecki/followers","following_url":"https://api.github.com/users/jangorecki/following{/other_user}","gists_url":"https://api.github.com/users/jangorecki/gists{/gist_id}","starred_url":"https://api.github.com/users/jangorecki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jangorecki/subscriptions","organizations_url":"https://api.github.com/users/jangorecki/orgs","repos_url":"https://api.github.com/users/jangorecki/repos","events_url":"https://api.github.com/users/jangorecki/events{/privacy}","received_events_url":"https://api.github.com/users/jangorecki/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/Rdatatable/data.table/milestones/3","html_url":"https://github.com/Rdatatable/data.table/milestones/v1.9.8","labels_url":"https://api.github.com/repos/Rdatatable/data.table/milestones/3/labels","id":812342,"number":3,"title":"v1.9.8","description":"","creator":{"login":"arunsrinivasan","id":3102045,"avatar_url":"https://avatars.githubusercontent.com/u/3102045?v=3","gravatar_id":"","url":"https://api.github.com/users/arunsrinivasan","html_url":"https://github.com/arunsrinivasan","followers_url":"https://api.github.com/users/arunsrinivasan/followers","following_url":"https://api.github.com/users/arunsrinivasan/following{/other_user}","gists_url":"https://api.github.com/users/arunsrinivasan/gists{/gist_id}","starred_url":"https://api.github.com/users/arunsrinivasan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arunsrinivasan/subscriptions","organizations_url":"https://api.github.com/users/arunsrinivasan/orgs","repos_url":"https://api.github.com/users/arunsrinivasan/repos","events_url":"https://api.github.com/users/arunsrinivasan/events{/privacy}","received_events_url":"https://api.github.com/users/arunsrinivasan/received_events","type":"User","site_admin":false},"open_issues":24,"closed_issues":138,"state":"open","created_at":"2014-10-03T08:24:10Z","updated_at":"2016-06-10T10:58:31Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2016-04-11T20:17:15Z","updated_at":"2016-06-10T10:58:31Z","closed_at":"2016-06-10T10:58:31Z","body":"Single issue to group changes in the code which breaks stated dependency on R 2.15.0.\r\n\r\n- [x] `R_xlen_t` symbol in `fwrite`\r\n- [x] `anyNA` in `all.equal.data.table`\r\n- [x] `setNames(nm=cols)` in `split.data.table`\r\n- [x] `setNames(nm=sugg_pkgs)` in `tests.Rraw`\r\n- [x] `[<-.data.table` in `transform.data.table` - `transform(.SD)` example in `transform.data.table.Rd`\r\n- [x] R 2.15.0 crashes on `as.factor(NA)` / `factor(NA)`, some tests needs to be altered (4 tests in 1639.x)\r\n- [x] `split.data.frame` crashes when split by NA factors or `NA_character_`, another tests in 1639.x\r\n- [x] non-equi join tests in `tests.Rraw`, `mget` needed environment argument, solved in d41adf1caab24d60cbf9da4938ddcf088a1188ba\r\n- [x] `Comparing ‘knitr.Rout’ to ‘knitr.Rout.save’ ...10d9` - `requireNamespace(quietly=T)` didn't suppress pkg loading message in 2.15\r\n- [x] 2 tests failed: 1613.33, 1613.36 - related to `all.equal.list` which previously didn't output `dQuote(\"a name\")` as component name but just integer\r\n- [x] test 1617 failed - related to #1281 - change in R 3.1\r\n- [ ] another 2 tests 1619.1, 1619.2 related to re-open issue #1270 - tests suppresses (in d41adf1caab24d60cbf9da4938ddcf088a1188ba) till it fixed\r\n- [x] test `1661.1` #1015 fails without giving test number due to R < 3.1 warning\r\n- [x] ~~`as.factor(NA)` can be handled on 2.15.0 with `as.factor(character())[1L]`~~ update: nope, would crash anyway in lower level operations on NA factor\r\n\r\n----\r\n\r\n### Reproducibility:\r\n\r\nJust plain R issue\r\n```\r\ndocker run -it jangorecki/r-2.15.0\r\nas.factor(NA)\r\n```\r\n\r\nwith installation of latest data.table:\r\n```\r\ndocker run -it --net=host jangorecki/r-2.15.0\r\ndownload.packages(\"data.table\", destdir = \".\", repos = \"http://Rdatatable.github.io/data.table\", type = \"source\")\r\ninstall.packages(\"data.table_1.9.7.tar.gz\", repos=NULL, type=\"source\")\r\n```\r\n\r\nOptionally to bash\r\n```\r\ndocker run -it --net=host jangorecki/r-2.15.0 /bin/bash\r\ncurl -O https://Rdatatable.github.io/data.table/src/contrib/data.table_1.9.7.tar.gz\r\nexport _R_CHECK_FORCE_SUGGESTS_=FALSE\r\nR2 CMD check data.table_1.9.7.tar.gz --no-manual --as-cran\r\n```\r\nWhen using from bash remember to use `R2` instead of `R`."}}
{"actor":{"display_login":"jangorecki"}}