{"action":"created","comment":{"url":"https://api.github.com/repos/fxbox/calendar-server/pulls/comments/76633992","id":76633992,"diff_hunk":"@@ -0,0 +1,108 @@\n+const debug = require('debug')('calendar-server:reminders');\n+const bcrypt = require('bcrypt');\n+\n+const database = require('./database');\n+const { NotFoundError } = require('../utils/errors');\n+const {\n+  checkPropertyType, checkIsArray\n+} = require('../utils/object_validator.js');\n+\n+function notFoundError(id) {\n+  return NotFoundError.createWithSubject('user', { name: 'id', value: id });\n+}\n+\n+const BCRYPT_SALT_ROUNDS = 10;\n+const SHA_HASH_SALT = 'todochangeme';","path":"dao/users.js","position":null,"original_position":15,"commit_id":"367e29b7bf5d9d2c6717cbe18ce9267970b4dc09","original_commit_id":"025d1cd00651267b89d8cb2a4d4b0a0a844c2a74","user":{"login":"julienw","id":454175,"avatar_url":"https://avatars.githubusercontent.com/u/454175?v=3","gravatar_id":"","url":"https://api.github.com/users/julienw","html_url":"https://github.com/julienw","followers_url":"https://api.github.com/users/julienw/followers","following_url":"https://api.github.com/users/julienw/following{/other_user}","gists_url":"https://api.github.com/users/julienw/gists{/gist_id}","starred_url":"https://api.github.com/users/julienw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienw/subscriptions","organizations_url":"https://api.github.com/users/julienw/orgs","repos_url":"https://api.github.com/users/julienw/repos","events_url":"https://api.github.com/users/julienw/events{/privacy}","received_events_url":"https://api.github.com/users/julienw/received_events","type":"User","site_admin":false},"body":"that said, looking at the lib API, I'm not convinced we're talking about the same type of salt (as in: `result = salt + bcrypt(salt + password)`).\r\nI'll dig deeper.","created_at":"2016-08-29T16:02:30Z","updated_at":"2016-08-29T16:02:30Z","html_url":"https://github.com/fxbox/calendar-server/pull/41#discussion_r76633992","pull_request_url":"https://api.github.com/repos/fxbox/calendar-server/pulls/41","_links":{"self":{"href":"https://api.github.com/repos/fxbox/calendar-server/pulls/comments/76633992"},"html":{"href":"https://github.com/fxbox/calendar-server/pull/41#discussion_r76633992"},"pull_request":{"href":"https://api.github.com/repos/fxbox/calendar-server/pulls/41"}}},"pull_request":{"url":"https://api.github.com/repos/fxbox/calendar-server/pulls/41","id":81101757,"html_url":"https://github.com/fxbox/calendar-server/pull/41","diff_url":"https://github.com/fxbox/calendar-server/pull/41.diff","patch_url":"https://github.com/fxbox/calendar-server/pull/41.patch","issue_url":"https://api.github.com/repos/fxbox/calendar-server/issues/41","number":41,"state":"open","locked":false,"title":"Groups + Users api [WIP]","user":{"login":"samgiles","id":840334,"avatar_url":"https://avatars.githubusercontent.com/u/840334?v=3","gravatar_id":"","url":"https://api.github.com/users/samgiles","html_url":"https://github.com/samgiles","followers_url":"https://api.github.com/users/samgiles/followers","following_url":"https://api.github.com/users/samgiles/following{/other_user}","gists_url":"https://api.github.com/users/samgiles/gists{/gist_id}","starred_url":"https://api.github.com/users/samgiles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samgiles/subscriptions","organizations_url":"https://api.github.com/users/samgiles/orgs","repos_url":"https://api.github.com/users/samgiles/repos","events_url":"https://api.github.com/users/samgiles/events{/privacy}","received_events_url":"https://api.github.com/users/samgiles/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-12T10:58:48Z","updated_at":"2016-08-29T16:02:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e27987bc019cbc56e67ce2d2a2dc72ef55e19d2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/fxbox/calendar-server/pulls/41/commits","review_comments_url":"https://api.github.com/repos/fxbox/calendar-server/pulls/41/comments","review_comment_url":"https://api.github.com/repos/fxbox/calendar-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fxbox/calendar-server/issues/41/comments","statuses_url":"https://api.github.com/repos/fxbox/calendar-server/statuses/367e29b7bf5d9d2c6717cbe18ce9267970b4dc09","head":{"label":"fxbox:family-api","ref":"family-api","sha":"367e29b7bf5d9d2c6717cbe18ce9267970b4dc09","user":{"login":"fxbox","id":17052474,"avatar_url":"https://avatars.githubusercontent.com/u/17052474?v=3","gravatar_id":"","url":"https://api.github.com/users/fxbox","html_url":"https://github.com/fxbox","followers_url":"https://api.github.com/users/fxbox/followers","following_url":"https://api.github.com/users/fxbox/following{/other_user}","gists_url":"https://api.github.com/users/fxbox/gists{/gist_id}","starred_url":"https://api.github.com/users/fxbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fxbox/subscriptions","organizations_url":"https://api.github.com/users/fxbox/orgs","repos_url":"https://api.github.com/users/fxbox/repos","events_url":"https://api.github.com/users/fxbox/events{/privacy}","received_events_url":"https://api.github.com/users/fxbox/received_events","type":"Organization","site_admin":false},"repo":{"id":61565794,"name":"calendar-server","full_name":"fxbox/calendar-server","owner":{"login":"fxbox","id":17052474,"avatar_url":"https://avatars.githubusercontent.com/u/17052474?v=3","gravatar_id":"","url":"https://api.github.com/users/fxbox","html_url":"https://github.com/fxbox","followers_url":"https://api.github.com/users/fxbox/followers","following_url":"https://api.github.com/users/fxbox/following{/other_user}","gists_url":"https://api.github.com/users/fxbox/gists{/gist_id}","starred_url":"https://api.github.com/users/fxbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fxbox/subscriptions","organizations_url":"https://api.github.com/users/fxbox/orgs","repos_url":"https://api.github.com/users/fxbox/repos","events_url":"https://api.github.com/users/fxbox/events{/privacy}","received_events_url":"https://api.github.com/users/fxbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fxbox/calendar-server","description":"This is the server for https://github.com/fxbox/calendar","fork":false,"url":"https://api.github.com/repos/fxbox/calendar-server","forks_url":"https://api.github.com/repos/fxbox/calendar-server/forks","keys_url":"https://api.github.com/repos/fxbox/calendar-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fxbox/calendar-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fxbox/calendar-server/teams","hooks_url":"https://api.github.com/repos/fxbox/calendar-server/hooks","issue_events_url":"https://api.github.com/repos/fxbox/calendar-server/issues/events{/number}","events_url":"https://api.github.com/repos/fxbox/calendar-server/events","assignees_url":"https://api.github.com/repos/fxbox/calendar-server/assignees{/user}","branches_url":"https://api.github.com/repos/fxbox/calendar-server/branches{/branch}","tags_url":"https://api.github.com/repos/fxbox/calendar-server/tags","blobs_url":"https://api.github.com/repos/fxbox/calendar-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fxbox/calendar-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fxbox/calendar-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/fxbox/calendar-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fxbox/calendar-server/statuses/{sha}","languages_url":"https://api.github.com/repos/fxbox/calendar-server/languages","stargazers_url":"https://api.github.com/repos/fxbox/calendar-server/stargazers","contributors_url":"https://api.github.com/repos/fxbox/calendar-server/contributors","subscribers_url":"https://api.github.com/repos/fxbox/calendar-server/subscribers","subscription_url":"https://api.github.com/repos/fxbox/calendar-server/subscription","commits_url":"https://api.github.com/repos/fxbox/calendar-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/fxbox/calendar-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/fxbox/calendar-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/fxbox/calendar-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/fxbox/calendar-server/contents/{+path}","compare_url":"https://api.github.com/repos/fxbox/calendar-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fxbox/calendar-server/merges","archive_url":"https://api.github.com/repos/fxbox/calendar-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fxbox/calendar-server/downloads","issues_url":"https://api.github.com/repos/fxbox/calendar-server/issues{/number}","pulls_url":"https://api.github.com/repos/fxbox/calendar-server/pulls{/number}","milestones_url":"https://api.github.com/repos/fxbox/calendar-server/milestones{/number}","notifications_url":"https://api.github.com/repos/fxbox/calendar-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fxbox/calendar-server/labels{/name}","releases_url":"https://api.github.com/repos/fxbox/calendar-server/releases{/id}","deployments_url":"https://api.github.com/repos/fxbox/calendar-server/deployments","created_at":"2016-06-20T17:10:15Z","updated_at":"2016-06-20T17:10:37Z","pushed_at":"2016-08-15T10:37:21Z","git_url":"git://github.com/fxbox/calendar-server.git","ssh_url":"git@github.com:fxbox/calendar-server.git","clone_url":"https://github.com/fxbox/calendar-server.git","svn_url":"https://github.com/fxbox/calendar-server","homepage":null,"size":146,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":5,"forks":3,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"fxbox:master","ref":"master","sha":"e75243bf63c735fe029acfd52646f8b44c5c8d95","user":{"login":"fxbox","id":17052474,"avatar_url":"https://avatars.githubusercontent.com/u/17052474?v=3","gravatar_id":"","url":"https://api.github.com/users/fxbox","html_url":"https://github.com/fxbox","followers_url":"https://api.github.com/users/fxbox/followers","following_url":"https://api.github.com/users/fxbox/following{/other_user}","gists_url":"https://api.github.com/users/fxbox/gists{/gist_id}","starred_url":"https://api.github.com/users/fxbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fxbox/subscriptions","organizations_url":"https://api.github.com/users/fxbox/orgs","repos_url":"https://api.github.com/users/fxbox/repos","events_url":"https://api.github.com/users/fxbox/events{/privacy}","received_events_url":"https://api.github.com/users/fxbox/received_events","type":"Organization","site_admin":false},"repo":{"id":61565794,"name":"calendar-server","full_name":"fxbox/calendar-server","owner":{"login":"fxbox","id":17052474,"avatar_url":"https://avatars.githubusercontent.com/u/17052474?v=3","gravatar_id":"","url":"https://api.github.com/users/fxbox","html_url":"https://github.com/fxbox","followers_url":"https://api.github.com/users/fxbox/followers","following_url":"https://api.github.com/users/fxbox/following{/other_user}","gists_url":"https://api.github.com/users/fxbox/gists{/gist_id}","starred_url":"https://api.github.com/users/fxbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fxbox/subscriptions","organizations_url":"https://api.github.com/users/fxbox/orgs","repos_url":"https://api.github.com/users/fxbox/repos","events_url":"https://api.github.com/users/fxbox/events{/privacy}","received_events_url":"https://api.github.com/users/fxbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fxbox/calendar-server","description":"This is the server for https://github.com/fxbox/calendar","fork":false,"url":"https://api.github.com/repos/fxbox/calendar-server","forks_url":"https://api.github.com/repos/fxbox/calendar-server/forks","keys_url":"https://api.github.com/repos/fxbox/calendar-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fxbox/calendar-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fxbox/calendar-server/teams","hooks_url":"https://api.github.com/repos/fxbox/calendar-server/hooks","issue_events_url":"https://api.github.com/repos/fxbox/calendar-server/issues/events{/number}","events_url":"https://api.github.com/repos/fxbox/calendar-server/events","assignees_url":"https://api.github.com/repos/fxbox/calendar-server/assignees{/user}","branches_url":"https://api.github.com/repos/fxbox/calendar-server/branches{/branch}","tags_url":"https://api.github.com/repos/fxbox/calendar-server/tags","blobs_url":"https://api.github.com/repos/fxbox/calendar-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fxbox/calendar-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fxbox/calendar-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/fxbox/calendar-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fxbox/calendar-server/statuses/{sha}","languages_url":"https://api.github.com/repos/fxbox/calendar-server/languages","stargazers_url":"https://api.github.com/repos/fxbox/calendar-server/stargazers","contributors_url":"https://api.github.com/repos/fxbox/calendar-server/contributors","subscribers_url":"https://api.github.com/repos/fxbox/calendar-server/subscribers","subscription_url":"https://api.github.com/repos/fxbox/calendar-server/subscription","commits_url":"https://api.github.com/repos/fxbox/calendar-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/fxbox/calendar-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/fxbox/calendar-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/fxbox/calendar-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/fxbox/calendar-server/contents/{+path}","compare_url":"https://api.github.com/repos/fxbox/calendar-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fxbox/calendar-server/merges","archive_url":"https://api.github.com/repos/fxbox/calendar-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fxbox/calendar-server/downloads","issues_url":"https://api.github.com/repos/fxbox/calendar-server/issues{/number}","pulls_url":"https://api.github.com/repos/fxbox/calendar-server/pulls{/number}","milestones_url":"https://api.github.com/repos/fxbox/calendar-server/milestones{/number}","notifications_url":"https://api.github.com/repos/fxbox/calendar-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fxbox/calendar-server/labels{/name}","releases_url":"https://api.github.com/repos/fxbox/calendar-server/releases{/id}","deployments_url":"https://api.github.com/repos/fxbox/calendar-server/deployments","created_at":"2016-06-20T17:10:15Z","updated_at":"2016-06-20T17:10:37Z","pushed_at":"2016-08-15T10:37:21Z","git_url":"git://github.com/fxbox/calendar-server.git","ssh_url":"git@github.com:fxbox/calendar-server.git","clone_url":"https://github.com/fxbox/calendar-server.git","svn_url":"https://github.com/fxbox/calendar-server","homepage":null,"size":146,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":5,"forks":3,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fxbox/calendar-server/pulls/41"},"html":{"href":"https://github.com/fxbox/calendar-server/pull/41"},"issue":{"href":"https://api.github.com/repos/fxbox/calendar-server/issues/41"},"comments":{"href":"https://api.github.com/repos/fxbox/calendar-server/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/fxbox/calendar-server/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/fxbox/calendar-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fxbox/calendar-server/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/fxbox/calendar-server/statuses/367e29b7bf5d9d2c6717cbe18ce9267970b4dc09"}}}}
{"actor":{"display_login":"julienw"}}