{"action":"created","issue":{"url":"https://api.github.com/repos/travis-ci/travis-build/issues/676","repository_url":"https://api.github.com/repos/travis-ci/travis-build","labels_url":"https://api.github.com/repos/travis-ci/travis-build/issues/676/labels{/name}","comments_url":"https://api.github.com/repos/travis-ci/travis-build/issues/676/comments","events_url":"https://api.github.com/repos/travis-ci/travis-build/issues/676/events","html_url":"https://github.com/travis-ci/travis-build/pull/676","id":139690731,"number":676,"title":"RethinkDB addon (WIP)","user":{"login":"danielmewes","id":505365,"avatar_url":"https://avatars.githubusercontent.com/u/505365?v=3","gravatar_id":"","url":"https://api.github.com/users/danielmewes","html_url":"https://github.com/danielmewes","followers_url":"https://api.github.com/users/danielmewes/followers","following_url":"https://api.github.com/users/danielmewes/following{/other_user}","gists_url":"https://api.github.com/users/danielmewes/gists{/gist_id}","starred_url":"https://api.github.com/users/danielmewes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielmewes/subscriptions","organizations_url":"https://api.github.com/users/danielmewes/orgs","repos_url":"https://api.github.com/users/danielmewes/repos","events_url":"https://api.github.com/users/danielmewes/events{/privacy}","received_events_url":"https://api.github.com/users/danielmewes/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-09T20:22:26Z","updated_at":"2016-03-09T23:36:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/travis-ci/travis-build/pulls/676","html_url":"https://github.com/travis-ci/travis-build/pull/676","diff_url":"https://github.com/travis-ci/travis-build/pull/676.diff","patch_url":"https://github.com/travis-ci/travis-build/pull/676.patch"},"body":"This adds a RethinkDB addon.\r\n\r\nThe supplied test is currently failing as follows, and I'm not sure what that means:\r\n```\r\nFailures:\r\n\r\n  1) Travis::Build::Addons::Rethinkdb \r\n     Failure/Error: raise TaintedOutput if !ignore_taint && script.tainted?\r\n\r\n     Travis::Shell::Generator::TaintedOutput:\r\n       Travis::Shell::Generator::TaintedOutput\r\n     # ./lib/travis/shell/generator.rb:16:in `generate'\r\n     # ./lib/travis/shell.rb:10:in `generate'\r\n     # spec/spec_helpers/sexp.rb:55:in `store_example'\r\n     # ./spec/build/addons/rethinkdb_spec.rb:12:in `block (2 levels) in <top (required)>'\r\n\r\n  2) Travis::Build::Addons::Rethinkdb behaves like compiled script can be compiled\r\n     Failure/Error: expect { subject }.to_not raise_error\r\n\r\n       expected no Exception, got #<Travis::Shell::Generator::TaintedOutput: Travis::Shell::Generator::TaintedOutput> with backtrace:\r\n         # ./lib/travis/shell/generator.rb:16:in `generate'\r\n         # ./lib/travis/shell.rb:10:in `generate'\r\n         # ./lib/travis/build/script.rb:72:in `compile'\r\n         # spec/build/script/shared/script.rb:7:in `block (2 levels) in <top (required)>'\r\n         # spec/build/script/shared/script.rb:14:in `block (3 levels) in <top (required)>'\r\n         # spec/build/script/shared/script.rb:14:in `block (2 levels) in <top (required)>'\r\n     Shared Example Group: \"compiled script\" called from ./spec/build/addons/rethinkdb_spec.rb:14\r\n     # spec/build/script/shared/script.rb:14:in `block (2 levels) in <top (required)>'\r\n\r\n  3) Travis::Build::Addons::Rethinkdb behaves like compiled script includes the expected travis_cmds\r\n     Failure/Error: raise TaintedOutput if !ignore_taint && script.tainted?\r\n\r\n     Travis::Shell::Generator::TaintedOutput:\r\n       Travis::Shell::Generator::TaintedOutput\r\n     Shared Example Group: \"compiled script\" called from ./spec/build/addons/rethinkdb_spec.rb:14\r\n     # ./lib/travis/shell/generator.rb:16:in `generate'\r\n     # ./lib/travis/shell.rb:10:in `generate'\r\n     # ./lib/travis/build/script.rb:72:in `compile'\r\n     # spec/build/script/shared/script.rb:7:in `block (2 levels) in <top (required)>'\r\n     # spec/build/script/shared/script.rb:25:in `block (3 levels) in <top (required)>'\r\n     # spec/build/script/shared/script.rb:24:in `each'\r\n     # spec/build/script/shared/script.rb:24:in `block (2 levels) in <top (required)>'\r\n\r\nFinished in 16.45 seconds (files took 1.77 seconds to load)\r\n3090 examples, 3 failures, 11 pending\r\n\r\nFailed examples:\r\n\r\nrspec ./spec/build/addons/rethinkdb_spec.rb:12 # Travis::Build::Addons::Rethinkdb \r\nrspec ./spec/build/addons/rethinkdb_spec.rb[1:2:1] # Travis::Build::Addons::Rethinkdb behaves like compiled script can be compiled\r\nrspec ./spec/build/addons/rethinkdb_spec.rb[1:2:3] # Travis::Build::Addons::Rethinkdb behaves like compiled script includes the expected travis_cmds\r\n```\r\n\r\nMentioning @joshk who suggested opening the pull request despite the remaining failures."},"comment":{"url":"https://api.github.com/repos/travis-ci/travis-build/issues/comments/194568224","html_url":"https://github.com/travis-ci/travis-build/pull/676#issuecomment-194568224","issue_url":"https://api.github.com/repos/travis-ci/travis-build/issues/676","id":194568224,"user":{"login":"BanzaiMan","id":25666,"avatar_url":"https://avatars.githubusercontent.com/u/25666?v=3","gravatar_id":"","url":"https://api.github.com/users/BanzaiMan","html_url":"https://github.com/BanzaiMan","followers_url":"https://api.github.com/users/BanzaiMan/followers","following_url":"https://api.github.com/users/BanzaiMan/following{/other_user}","gists_url":"https://api.github.com/users/BanzaiMan/gists{/gist_id}","starred_url":"https://api.github.com/users/BanzaiMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BanzaiMan/subscriptions","organizations_url":"https://api.github.com/users/BanzaiMan/orgs","repos_url":"https://api.github.com/users/BanzaiMan/repos","events_url":"https://api.github.com/users/BanzaiMan/events{/privacy}","received_events_url":"https://api.github.com/users/BanzaiMan/received_events","type":"User","site_admin":false},"created_at":"2016-03-09T23:36:48Z","updated_at":"2016-03-09T23:36:48Z","body":"Not sure where the taintedness is coming into play, but with my fixes, that is not a problem when I run the specs locally."}}