{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/pulls/comments/92293554","pull_request_review_id":12806490,"id":92293554,"diff_hunk":"@@ -80,12 +80,34 @@ export class RunDetailsPipeline extends Component {\n     }\n \n     componentWillReceiveProps(nextProps) {\n-        if (this.props.result.isQueued()) {\n+        if (nextProps.result.isQueued()) {\n             return;\n         }\n         const followAlong = this.state.followAlong;\n         this.mergedConfig = this.generateConfig({ ...nextProps, followAlong });\n-\n+        \n+        if (this.mergedConfig.supportsNode && (!nextProps.nodes || !nextProps.nodes[this.mergedConfig.nodeKey])) {\n+            const tryNodes = () => {\n+                // in order to handle queued items during re-run, we need to retry fetching nodes periodically\n+                if (!this.props.nodes || !this.props.nodes[this.mergedConfig.nodeKey]) {","path":"blueocean-dashboard/src/main/js/components/RunDetailsPipeline.jsx","position":15,"original_position":15,"commit_id":"482d372f09c26d41a31dd40174c2908cfc501385","original_commit_id":"482d372f09c26d41a31dd40174c2908cfc501385","user":{"login":"michaelneale","id":14976,"avatar_url":"https://avatars.githubusercontent.com/u/14976?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelneale","html_url":"https://github.com/michaelneale","followers_url":"https://api.github.com/users/michaelneale/followers","following_url":"https://api.github.com/users/michaelneale/following{/other_user}","gists_url":"https://api.github.com/users/michaelneale/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelneale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelneale/subscriptions","organizations_url":"https://api.github.com/users/michaelneale/orgs","repos_url":"https://api.github.com/users/michaelneale/repos","events_url":"https://api.github.com/users/michaelneale/events{/privacy}","received_events_url":"https://api.github.com/users/michaelneale/received_events","type":"User","site_admin":false},"body":"perhaps worth a try @kzantow ?","created_at":"2016-12-13T23:45:35Z","updated_at":"2016-12-13T23:45:35Z","html_url":"https://github.com/jenkinsci/blueocean-plugin/pull/648#discussion_r92293554","pull_request_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/pulls/648","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/blueocean-plugin/pulls/comments/92293554"},"html":{"href":"https://github.com/jenkinsci/blueocean-plugin/pull/648#discussion_r92293554"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/blueocean-plugin/pulls/648"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/pulls/648","id":96795167,"html_url":"https://github.com/jenkinsci/blueocean-plugin/pull/648","diff_url":"https://github.com/jenkinsci/blueocean-plugin/pull/648.diff","patch_url":"https://github.com/jenkinsci/blueocean-plugin/pull/648.patch","issue_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/issues/648","number":648,"state":"open","locked":false,"title":"[FIX JENKINS-39955] re-run broken due to queue/executing timing/disconnect","user":{"login":"kzantow","id":3009477,"avatar_url":"https://avatars.githubusercontent.com/u/3009477?v=3","gravatar_id":"","url":"https://api.github.com/users/kzantow","html_url":"https://github.com/kzantow","followers_url":"https://api.github.com/users/kzantow/followers","following_url":"https://api.github.com/users/kzantow/following{/other_user}","gists_url":"https://api.github.com/users/kzantow/gists{/gist_id}","starred_url":"https://api.github.com/users/kzantow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kzantow/subscriptions","organizations_url":"https://api.github.com/users/kzantow/orgs","repos_url":"https://api.github.com/users/kzantow/repos","events_url":"https://api.github.com/users/kzantow/events{/privacy}","received_events_url":"https://api.github.com/users/kzantow/received_events","type":"User","site_admin":false},"body":"# Description\r\n\r\nRe-run button was broken in a number of cases. Added code to retry in the case of a queued item and failed node/step fetches.\r\n\r\nCan test this with the pipeline provided in the ticket, it runs or 15 seconds with a number of stages and logs.\r\n\r\nSee [JENKINS-39955](https://issues.jenkins-ci.org/browse/JENKINS-39955).\r\n\r\n# Submitter checklist\r\n- [x] Link to JIRA ticket in description, if appropriate.\r\n- [x] Change is code complete and matches issue description\r\n- [x] Appropriate unit or acceptance tests or explanation to why this change has no tests\r\n- [x] Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.\r\n- [x] Ran Acceptance Test Harness against PR changes.\r\n\r\n# Reviewer checklist\r\n- [x] Run the changes and verified the change matches the issue description\r\n- [x] Reviewed the code\r\n- [x] Verified that the appropriate tests have been written or valid explanation given\r\n\r\n@reviewbybees \r\n\r\n","created_at":"2016-12-06T20:01:54Z","updated_at":"2016-12-13T23:45:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c5da849434aebf8e77024319f0b27290cc6ce6f","assignee":{"login":"kzantow","id":3009477,"avatar_url":"https://avatars.githubusercontent.com/u/3009477?v=3","gravatar_id":"","url":"https://api.github.com/users/kzantow","html_url":"https://github.com/kzantow","followers_url":"https://api.github.com/users/kzantow/followers","following_url":"https://api.github.com/users/kzantow/following{/other_user}","gists_url":"https://api.github.com/users/kzantow/gists{/gist_id}","starred_url":"https://api.github.com/users/kzantow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kzantow/subscriptions","organizations_url":"https://api.github.com/users/kzantow/orgs","repos_url":"https://api.github.com/users/kzantow/repos","events_url":"https://api.github.com/users/kzantow/events{/privacy}","received_events_url":"https://api.github.com/users/kzantow/received_events","type":"User","site_admin":false},"assignees":[{"login":"kzantow","id":3009477,"avatar_url":"https://avatars.githubusercontent.com/u/3009477?v=3","gravatar_id":"","url":"https://api.github.com/users/kzantow","html_url":"https://github.com/kzantow","followers_url":"https://api.github.com/users/kzantow/followers","following_url":"https://api.github.com/users/kzantow/following{/other_user}","gists_url":"https://api.github.com/users/kzantow/gists{/gist_id}","starred_url":"https://api.github.com/users/kzantow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kzantow/subscriptions","organizations_url":"https://api.github.com/users/kzantow/orgs","repos_url":"https://api.github.com/users/kzantow/repos","events_url":"https://api.github.com/users/kzantow/events{/privacy}","received_events_url":"https://api.github.com/users/kzantow/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/pulls/648/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/pulls/648/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/issues/648/comments","statuses_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/statuses/482d372f09c26d41a31dd40174c2908cfc501385","head":{"label":"kzantow:JENKINS-39955-re-run-broken","ref":"JENKINS-39955-re-run-broken","sha":"482d372f09c26d41a31dd40174c2908cfc501385","user":{"login":"kzantow","id":3009477,"avatar_url":"https://avatars.githubusercontent.com/u/3009477?v=3","gravatar_id":"","url":"https://api.github.com/users/kzantow","html_url":"https://github.com/kzantow","followers_url":"https://api.github.com/users/kzantow/followers","following_url":"https://api.github.com/users/kzantow/following{/other_user}","gists_url":"https://api.github.com/users/kzantow/gists{/gist_id}","starred_url":"https://api.github.com/users/kzantow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kzantow/subscriptions","organizations_url":"https://api.github.com/users/kzantow/orgs","repos_url":"https://api.github.com/users/kzantow/repos","events_url":"https://api.github.com/users/kzantow/events{/privacy}","received_events_url":"https://api.github.com/users/kzantow/received_events","type":"User","site_admin":false},"repo":{"id":60725922,"name":"blueocean-plugin","full_name":"kzantow/blueocean-plugin","owner":{"login":"kzantow","id":3009477,"avatar_url":"https://avatars.githubusercontent.com/u/3009477?v=3","gravatar_id":"","url":"https://api.github.com/users/kzantow","html_url":"https://github.com/kzantow","followers_url":"https://api.github.com/users/kzantow/followers","following_url":"https://api.github.com/users/kzantow/following{/other_user}","gists_url":"https://api.github.com/users/kzantow/gists{/gist_id}","starred_url":"https://api.github.com/users/kzantow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kzantow/subscriptions","organizations_url":"https://api.github.com/users/kzantow/orgs","repos_url":"https://api.github.com/users/kzantow/repos","events_url":"https://api.github.com/users/kzantow/events{/privacy}","received_events_url":"https://api.github.com/users/kzantow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kzantow/blueocean-plugin","description":"Blue Ocean UI app","fork":true,"url":"https://api.github.com/repos/kzantow/blueocean-plugin","forks_url":"https://api.github.com/repos/kzantow/blueocean-plugin/forks","keys_url":"https://api.github.com/repos/kzantow/blueocean-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kzantow/blueocean-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kzantow/blueocean-plugin/teams","hooks_url":"https://api.github.com/repos/kzantow/blueocean-plugin/hooks","issue_events_url":"https://api.github.com/repos/kzantow/blueocean-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/kzantow/blueocean-plugin/events","assignees_url":"https://api.github.com/repos/kzantow/blueocean-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/kzantow/blueocean-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/kzantow/blueocean-plugin/tags","blobs_url":"https://api.github.com/repos/kzantow/blueocean-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kzantow/blueocean-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kzantow/blueocean-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/kzantow/blueocean-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kzantow/blueocean-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/kzantow/blueocean-plugin/languages","stargazers_url":"https://api.github.com/repos/kzantow/blueocean-plugin/stargazers","contributors_url":"https://api.github.com/repos/kzantow/blueocean-plugin/contributors","subscribers_url":"https://api.github.com/repos/kzantow/blueocean-plugin/subscribers","subscription_url":"https://api.github.com/repos/kzantow/blueocean-plugin/subscription","commits_url":"https://api.github.com/repos/kzantow/blueocean-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/kzantow/blueocean-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/kzantow/blueocean-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/kzantow/blueocean-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/kzantow/blueocean-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/kzantow/blueocean-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kzantow/blueocean-plugin/merges","archive_url":"https://api.github.com/repos/kzantow/blueocean-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kzantow/blueocean-plugin/downloads","issues_url":"https://api.github.com/repos/kzantow/blueocean-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/kzantow/blueocean-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/kzantow/blueocean-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/kzantow/blueocean-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kzantow/blueocean-plugin/labels{/name}","releases_url":"https://api.github.com/repos/kzantow/blueocean-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/kzantow/blueocean-plugin/deployments","created_at":"2016-06-08T19:46:31Z","updated_at":"2016-09-19T17:15:19Z","pushed_at":"2016-12-08T01:10:32Z","git_url":"git://github.com/kzantow/blueocean-plugin.git","ssh_url":"git@github.com:kzantow/blueocean-plugin.git","clone_url":"https://github.com/kzantow/blueocean-plugin.git","svn_url":"https://github.com/kzantow/blueocean-plugin","homepage":null,"size":9380,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"e47c2bd0f46504399ee496fff32fd16a88ff802a","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":50250915,"name":"blueocean-plugin","full_name":"jenkinsci/blueocean-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/blueocean-plugin","description":"Blue Ocean is a reboot of the Jenkins CI/CD User Experience","fork":false,"url":"https://api.github.com/repos/jenkinsci/blueocean-plugin","forks_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/blueocean-plugin/deployments","created_at":"2016-01-23T18:02:45Z","updated_at":"2016-12-13T20:05:01Z","pushed_at":"2016-12-13T23:19:57Z","git_url":"git://github.com/jenkinsci/blueocean-plugin.git","ssh_url":"git@github.com:jenkinsci/blueocean-plugin.git","clone_url":"https://github.com/jenkinsci/blueocean-plugin.git","svn_url":"https://github.com/jenkinsci/blueocean-plugin","homepage":"https://jenkins.io/projects/blueocean/","size":10007,"stargazers_count":1415,"watchers_count":1415,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":128,"mirror_url":null,"open_issues_count":15,"forks":128,"open_issues":15,"watchers":1415,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/blueocean-plugin/pulls/648"},"html":{"href":"https://github.com/jenkinsci/blueocean-plugin/pull/648"},"issue":{"href":"https://api.github.com/repos/jenkinsci/blueocean-plugin/issues/648"},"comments":{"href":"https://api.github.com/repos/jenkinsci/blueocean-plugin/issues/648/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/blueocean-plugin/pulls/648/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/blueocean-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/blueocean-plugin/pulls/648/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/blueocean-plugin/statuses/482d372f09c26d41a31dd40174c2908cfc501385"}}}}
{"actor":{"display_login":"michaelneale"}}