{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/5788","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/5788/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/5788/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/5788/events","html_url":"https://github.com/cockroachdb/cockroach/pull/5788","id":145042778,"number":5788,"title":"roachpb: Assure that key.ShallowNext is fully immutable","user":{"login":"nvanbenschoten","id":5438456,"avatar_url":"https://avatars.githubusercontent.com/u/5438456?v=3","gravatar_id":"","url":"https://api.github.com/users/nvanbenschoten","html_url":"https://github.com/nvanbenschoten","followers_url":"https://api.github.com/users/nvanbenschoten/followers","following_url":"https://api.github.com/users/nvanbenschoten/following{/other_user}","gists_url":"https://api.github.com/users/nvanbenschoten/gists{/gist_id}","starred_url":"https://api.github.com/users/nvanbenschoten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvanbenschoten/subscriptions","organizations_url":"https://api.github.com/users/nvanbenschoten/orgs","repos_url":"https://api.github.com/users/nvanbenschoten/repos","events_url":"https://api.github.com/users/nvanbenschoten/events{/privacy}","received_events_url":"https://api.github.com/users/nvanbenschoten/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"bdarnell","id":160562,"avatar_url":"https://avatars.githubusercontent.com/u/160562?v=3","gravatar_id":"","url":"https://api.github.com/users/bdarnell","html_url":"https://github.com/bdarnell","followers_url":"https://api.github.com/users/bdarnell/followers","following_url":"https://api.github.com/users/bdarnell/following{/other_user}","gists_url":"https://api.github.com/users/bdarnell/gists{/gist_id}","starred_url":"https://api.github.com/users/bdarnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdarnell/subscriptions","organizations_url":"https://api.github.com/users/bdarnell/orgs","repos_url":"https://api.github.com/users/bdarnell/repos","events_url":"https://api.github.com/users/bdarnell/events{/privacy}","received_events_url":"https://api.github.com/users/bdarnell/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2016-03-31T23:16:34Z","updated_at":"2016-04-01T01:45:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/5788","html_url":"https://github.com/cockroachdb/cockroach/pull/5788","diff_url":"https://github.com/cockroachdb/cockroach/pull/5788.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/5788.patch"},"body":"Fixes #5784.\r\n\r\nWe cannot modify `BatchRequest`s, so `ShallowNext` cannot append.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/5788)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/204202954","html_url":"https://github.com/cockroachdb/cockroach/pull/5788#issuecomment-204202954","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/5788","id":204202954,"user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"created_at":"2016-04-01T01:45:10Z","updated_at":"2016-04-01T01:45:10Z","body":"does this version of `ShallowNext` obviate the need to distinguish between it and `Next`?\n\n---\n\nReviewed 2 of 2 files at r1.\nReview status: all files reviewed at latest revision, 1 unresolved discussion.\n\n---\n\n*[roachpb/data_test.go, line 68 \\[r1\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/5788#-KEEULQ6NKDPpjqPyT0b:-KEEULQ6NKDPpjqPyT0c:1091586935) ([raw file](https://github.com/cockroachdb/cockroach/blob/3de282f0e02b35b80a1cd80f43345d72ab854c6f/roachpb/data_test.go#L68)):*\ni think we need another test for the negative case - that is, a test that confirms that ShallowNext() reallocates when it should.\n\n---\n\n\n*Comments from the [review on Reviewable.io](https://reviewable.io:443/reviews/cockroachdb/cockroach/5788#-:-KEEUc0xvPY1TRO9I2s4:-908148595)*\n<!-- Sent from Reviewable.io -->\n"}}