{"action":"created","comment":{"url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/comments/66541366","id":66541366,"diff_hunk":"@@ -55,6 +55,21 @@ function (Okta, Q, Factor, BrowserFeatures, Errors) {\n     });\n   }\n \n+  function getMinutesString(factorLifetimeInMinutes) {\n+    if (factorLifetimeInMinutes > 60 && factorLifetimeInMinutes <= 1440) {\n+      var lifetimeInHours = (factorLifetimeInMinutes / 60);\n+      return Okta.loc('hours', 'login', [lifetimeInHours]);\n+    } else if (factorLifetimeInMinutes > 1440 && factorLifetimeInMinutes < 2880) {\n+      var lifetimeInDays = (factorLifetimeInMinutes / 1440);\n+      return Okta.loc('days', 'login', [lifetimeInDays]);\n+    }","path":"src/models/AppState.js","position":11,"original_position":11,"commit_id":"f80c4b8fa16a314d136df14b44be29433c4cded7","original_commit_id":"f80c4b8fa16a314d136df14b44be29433c4cded7","user":{"login":"mauriciocastillosilva-okta","id":6979296,"avatar_url":"https://avatars.githubusercontent.com/u/6979296?v=3","gravatar_id":"","url":"https://api.github.com/users/mauriciocastillosilva-okta","html_url":"https://github.com/mauriciocastillosilva-okta","followers_url":"https://api.github.com/users/mauriciocastillosilva-okta/followers","following_url":"https://api.github.com/users/mauriciocastillosilva-okta/following{/other_user}","gists_url":"https://api.github.com/users/mauriciocastillosilva-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/mauriciocastillosilva-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mauriciocastillosilva-okta/subscriptions","organizations_url":"https://api.github.com/users/mauriciocastillosilva-okta/orgs","repos_url":"https://api.github.com/users/mauriciocastillosilva-okta/repos","events_url":"https://api.github.com/users/mauriciocastillosilva-okta/events{/privacy}","received_events_url":"https://api.github.com/users/mauriciocastillosilva-okta/received_events","type":"User","site_admin":false},"body":"I tried this and it does not evaluate the same, so I'll keep what I have","created_at":"2016-06-09T23:45:18Z","updated_at":"2016-06-09T23:45:18Z","html_url":"https://github.com/okta/okta-signin-widget/pull/76#discussion_r66541366","pull_request_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/76","_links":{"self":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/comments/66541366"},"html":{"href":"https://github.com/okta/okta-signin-widget/pull/76#discussion_r66541366"},"pull_request":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/76"}}},"pull_request":{"url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/76","id":73134163,"html_url":"https://github.com/okta/okta-signin-widget/pull/76","diff_url":"https://github.com/okta/okta-signin-widget/pull/76.diff","patch_url":"https://github.com/okta/okta-signin-widget/pull/76.patch","issue_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/76","number":76,"state":"open","locked":false,"title":"OKTA-89999: Better label for remember device","user":{"login":"mauriciocastillosilva-okta","id":6979296,"avatar_url":"https://avatars.githubusercontent.com/u/6979296?v=3","gravatar_id":"","url":"https://api.github.com/users/mauriciocastillosilva-okta","html_url":"https://github.com/mauriciocastillosilva-okta","followers_url":"https://api.github.com/users/mauriciocastillosilva-okta/followers","following_url":"https://api.github.com/users/mauriciocastillosilva-okta/following{/other_user}","gists_url":"https://api.github.com/users/mauriciocastillosilva-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/mauriciocastillosilva-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mauriciocastillosilva-okta/subscriptions","organizations_url":"https://api.github.com/users/mauriciocastillosilva-okta/orgs","repos_url":"https://api.github.com/users/mauriciocastillosilva-okta/repos","events_url":"https://api.github.com/users/mauriciocastillosilva-okta/events{/privacy}","received_events_url":"https://api.github.com/users/mauriciocastillosilva-okta/received_events","type":"User","site_admin":false},"body":"Remember Device use to say \"Trust this device\", but now instead it will convey a more meaningful text\r\n- Do not challenge me on this device again\r\n- Do not challenge me on this device for the next 15 minutes\r\n\r\nNote: we won't show it if the server is set to prompt for mfa always\r\n\r\nIn addition I am removing the device cookie since it is no longer needed. The server will handle the logic for that\r\n\r\nScreencast: https://okta.box.com/s/agm58j63aywxclop681r8lvqy4cvh2uw\r\n\r\n@srinivasanagandla-okta can you take a look at FactorUtil.js please? This is the logic to figure out if we check or not the checkbox by default","created_at":"2016-06-08T22:55:15Z","updated_at":"2016-06-09T23:45:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4c6e622d4fe7a92cb958b9158cd8110868762fd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/76/commits","review_comments_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/76/comments","review_comment_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/comments{/number}","comments_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/76/comments","statuses_url":"https://api.github.com/repos/okta/okta-signin-widget/statuses/f80c4b8fa16a314d136df14b44be29433c4cded7","head":{"label":"mauriciocastillosilva-okta:mcs-okta-89999-enhanceRememberDeviceText","ref":"mcs-okta-89999-enhanceRememberDeviceText","sha":"f80c4b8fa16a314d136df14b44be29433c4cded7","user":{"login":"mauriciocastillosilva-okta","id":6979296,"avatar_url":"https://avatars.githubusercontent.com/u/6979296?v=3","gravatar_id":"","url":"https://api.github.com/users/mauriciocastillosilva-okta","html_url":"https://github.com/mauriciocastillosilva-okta","followers_url":"https://api.github.com/users/mauriciocastillosilva-okta/followers","following_url":"https://api.github.com/users/mauriciocastillosilva-okta/following{/other_user}","gists_url":"https://api.github.com/users/mauriciocastillosilva-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/mauriciocastillosilva-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mauriciocastillosilva-okta/subscriptions","organizations_url":"https://api.github.com/users/mauriciocastillosilva-okta/orgs","repos_url":"https://api.github.com/users/mauriciocastillosilva-okta/repos","events_url":"https://api.github.com/users/mauriciocastillosilva-okta/events{/privacy}","received_events_url":"https://api.github.com/users/mauriciocastillosilva-okta/received_events","type":"User","site_admin":false},"repo":{"id":60712695,"name":"okta-signin-widget","full_name":"mauriciocastillosilva-okta/okta-signin-widget","owner":{"login":"mauriciocastillosilva-okta","id":6979296,"avatar_url":"https://avatars.githubusercontent.com/u/6979296?v=3","gravatar_id":"","url":"https://api.github.com/users/mauriciocastillosilva-okta","html_url":"https://github.com/mauriciocastillosilva-okta","followers_url":"https://api.github.com/users/mauriciocastillosilva-okta/followers","following_url":"https://api.github.com/users/mauriciocastillosilva-okta/following{/other_user}","gists_url":"https://api.github.com/users/mauriciocastillosilva-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/mauriciocastillosilva-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mauriciocastillosilva-okta/subscriptions","organizations_url":"https://api.github.com/users/mauriciocastillosilva-okta/orgs","repos_url":"https://api.github.com/users/mauriciocastillosilva-okta/repos","events_url":"https://api.github.com/users/mauriciocastillosilva-okta/events{/privacy}","received_events_url":"https://api.github.com/users/mauriciocastillosilva-okta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mauriciocastillosilva-okta/okta-signin-widget","description":"Okta SignIn widget that renders the new login/auth/recovery flows","fork":true,"url":"https://api.github.com/repos/mauriciocastillosilva-okta/okta-signin-widget","forks_url":"https://api.github.com/repos/mauriciocastillosilva-okta/okta-signin-widget/forks","keys_url":"https://api.github.com/repos/mauriciocastillosilva-okta/okta-signin-widget/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mauriciocastillosilva-okta/okta-signin-widget/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mauriciocastillosilva-okta/okta-signin-widget/teams","hooks_url":"https://api.github.com/repos/mauriciocastillosilva-okta/okta-signin-widget/hooks","issue_events_url":"https://api.github.com/repos/mauriciocastillosilva-okta/okta-signin-widget/issues/events{/number}","events_url":"https://api.github.com/repos/mauriciocastillosilva-okta/okta-signin-widget/events","assignees_url":"https://api.github.com/repos/mauriciocastillosilva-okta/okta-signin-widget/assignees{/user}","branches_url":"https://api.github.com/repos/mauriciocastillosilva-okta/okta-signin-widget/branches{/branch}","tags_url":"https://api.github.com/repos/mauriciocastillosilva-okta/okta-signin-widget/tags","blobs_url":"https://api.github.com/repos/mauriciocastillosilva-okta/okta-signin-widget/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mauriciocastillosilva-okta/okta-signin-widget/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mauriciocastillosilva-okta/okta-signin-widget/git/refs{/sha}","trees_url":"https://api.github.com/repos/mauriciocastillosilva-okta/okta-signin-widget/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mauriciocastillosilva-okta/okta-signin-widget/statuses/{sha}","languages_url":"https://api.github.com/repos/mauriciocastillosilva-okta/okta-signin-widget/languages","stargazers_url":"https://api.github.com/repos/mauriciocastillosilva-okta/okta-signin-widget/stargazers","contributors_url":"https://api.github.com/repos/mauriciocastillosilva-okta/okta-signin-widget/contributors","subscribers_url":"https://api.github.com/repos/mauriciocastillosilva-okta/okta-signin-widget/subscribers","subscription_url":"https://api.github.com/repos/mauriciocastillosilva-okta/okta-signin-widget/subscription","commits_url":"https://api.github.com/repos/mauriciocastillosilva-okta/okta-signin-widget/commits{/sha}","git_commits_url":"https://api.github.com/repos/mauriciocastillosilva-okta/okta-signin-widget/git/commits{/sha}","comments_url":"https://api.github.com/repos/mauriciocastillosilva-okta/okta-signin-widget/comments{/number}","issue_comment_url":"https://api.github.com/repos/mauriciocastillosilva-okta/okta-signin-widget/issues/comments{/number}","contents_url":"https://api.github.com/repos/mauriciocastillosilva-okta/okta-signin-widget/contents/{+path}","compare_url":"https://api.github.com/repos/mauriciocastillosilva-okta/okta-signin-widget/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mauriciocastillosilva-okta/okta-signin-widget/merges","archive_url":"https://api.github.com/repos/mauriciocastillosilva-okta/okta-signin-widget/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mauriciocastillosilva-okta/okta-signin-widget/downloads","issues_url":"https://api.github.com/repos/mauriciocastillosilva-okta/okta-signin-widget/issues{/number}","pulls_url":"https://api.github.com/repos/mauriciocastillosilva-okta/okta-signin-widget/pulls{/number}","milestones_url":"https://api.github.com/repos/mauriciocastillosilva-okta/okta-signin-widget/milestones{/number}","notifications_url":"https://api.github.com/repos/mauriciocastillosilva-okta/okta-signin-widget/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mauriciocastillosilva-okta/okta-signin-widget/labels{/name}","releases_url":"https://api.github.com/repos/mauriciocastillosilva-okta/okta-signin-widget/releases{/id}","deployments_url":"https://api.github.com/repos/mauriciocastillosilva-okta/okta-signin-widget/deployments","created_at":"2016-06-08T16:26:28Z","updated_at":"2016-06-08T16:26:31Z","pushed_at":"2016-06-08T22:49:32Z","git_url":"git://github.com/mauriciocastillosilva-okta/okta-signin-widget.git","ssh_url":"git@github.com:mauriciocastillosilva-okta/okta-signin-widget.git","clone_url":"https://github.com/mauriciocastillosilva-okta/okta-signin-widget.git","svn_url":"https://github.com/mauriciocastillosilva-okta/okta-signin-widget","homepage":null,"size":7273,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"okta:master","ref":"master","sha":"3863393b7ecf08bb4b7afee70b1fb6d574afe198","user":{"login":"okta","id":362460,"avatar_url":"https://avatars.githubusercontent.com/u/362460?v=3","gravatar_id":"","url":"https://api.github.com/users/okta","html_url":"https://github.com/okta","followers_url":"https://api.github.com/users/okta/followers","following_url":"https://api.github.com/users/okta/following{/other_user}","gists_url":"https://api.github.com/users/okta/gists{/gist_id}","starred_url":"https://api.github.com/users/okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okta/subscriptions","organizations_url":"https://api.github.com/users/okta/orgs","repos_url":"https://api.github.com/users/okta/repos","events_url":"https://api.github.com/users/okta/events{/privacy}","received_events_url":"https://api.github.com/users/okta/received_events","type":"Organization","site_admin":false},"repo":{"id":46365690,"name":"okta-signin-widget","full_name":"okta/okta-signin-widget","owner":{"login":"okta","id":362460,"avatar_url":"https://avatars.githubusercontent.com/u/362460?v=3","gravatar_id":"","url":"https://api.github.com/users/okta","html_url":"https://github.com/okta","followers_url":"https://api.github.com/users/okta/followers","following_url":"https://api.github.com/users/okta/following{/other_user}","gists_url":"https://api.github.com/users/okta/gists{/gist_id}","starred_url":"https://api.github.com/users/okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okta/subscriptions","organizations_url":"https://api.github.com/users/okta/orgs","repos_url":"https://api.github.com/users/okta/repos","events_url":"https://api.github.com/users/okta/events{/privacy}","received_events_url":"https://api.github.com/users/okta/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/okta/okta-signin-widget","description":"Okta SignIn widget that renders the new login/auth/recovery flows","fork":false,"url":"https://api.github.com/repos/okta/okta-signin-widget","forks_url":"https://api.github.com/repos/okta/okta-signin-widget/forks","keys_url":"https://api.github.com/repos/okta/okta-signin-widget/keys{/key_id}","collaborators_url":"https://api.github.com/repos/okta/okta-signin-widget/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/okta/okta-signin-widget/teams","hooks_url":"https://api.github.com/repos/okta/okta-signin-widget/hooks","issue_events_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/events{/number}","events_url":"https://api.github.com/repos/okta/okta-signin-widget/events","assignees_url":"https://api.github.com/repos/okta/okta-signin-widget/assignees{/user}","branches_url":"https://api.github.com/repos/okta/okta-signin-widget/branches{/branch}","tags_url":"https://api.github.com/repos/okta/okta-signin-widget/tags","blobs_url":"https://api.github.com/repos/okta/okta-signin-widget/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/okta/okta-signin-widget/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/okta/okta-signin-widget/git/refs{/sha}","trees_url":"https://api.github.com/repos/okta/okta-signin-widget/git/trees{/sha}","statuses_url":"https://api.github.com/repos/okta/okta-signin-widget/statuses/{sha}","languages_url":"https://api.github.com/repos/okta/okta-signin-widget/languages","stargazers_url":"https://api.github.com/repos/okta/okta-signin-widget/stargazers","contributors_url":"https://api.github.com/repos/okta/okta-signin-widget/contributors","subscribers_url":"https://api.github.com/repos/okta/okta-signin-widget/subscribers","subscription_url":"https://api.github.com/repos/okta/okta-signin-widget/subscription","commits_url":"https://api.github.com/repos/okta/okta-signin-widget/commits{/sha}","git_commits_url":"https://api.github.com/repos/okta/okta-signin-widget/git/commits{/sha}","comments_url":"https://api.github.com/repos/okta/okta-signin-widget/comments{/number}","issue_comment_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/comments{/number}","contents_url":"https://api.github.com/repos/okta/okta-signin-widget/contents/{+path}","compare_url":"https://api.github.com/repos/okta/okta-signin-widget/compare/{base}...{head}","merges_url":"https://api.github.com/repos/okta/okta-signin-widget/merges","archive_url":"https://api.github.com/repos/okta/okta-signin-widget/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/okta/okta-signin-widget/downloads","issues_url":"https://api.github.com/repos/okta/okta-signin-widget/issues{/number}","pulls_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls{/number}","milestones_url":"https://api.github.com/repos/okta/okta-signin-widget/milestones{/number}","notifications_url":"https://api.github.com/repos/okta/okta-signin-widget/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/okta/okta-signin-widget/labels{/name}","releases_url":"https://api.github.com/repos/okta/okta-signin-widget/releases{/id}","deployments_url":"https://api.github.com/repos/okta/okta-signin-widget/deployments","created_at":"2015-11-17T18:08:41Z","updated_at":"2016-05-16T19:03:13Z","pushed_at":"2016-06-09T23:44:08Z","git_url":"git://github.com/okta/okta-signin-widget.git","ssh_url":"git@github.com:okta/okta-signin-widget.git","clone_url":"https://github.com/okta/okta-signin-widget.git","svn_url":"https://github.com/okta/okta-signin-widget","homepage":null,"size":6607,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":13,"forks":9,"open_issues":13,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/76"},"html":{"href":"https://github.com/okta/okta-signin-widget/pull/76"},"issue":{"href":"https://api.github.com/repos/okta/okta-signin-widget/issues/76"},"comments":{"href":"https://api.github.com/repos/okta/okta-signin-widget/issues/76/comments"},"review_comments":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/76/comments"},"review_comment":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/76/commits"},"statuses":{"href":"https://api.github.com/repos/okta/okta-signin-widget/statuses/f80c4b8fa16a314d136df14b44be29433c4cded7"}}}}
{"actor":{"display_login":"mauriciocastillosilva-okta"}}