{"action":"created","issue":{"url":"https://api.github.com/repos/zulip/zulip/issues/513","repository_url":"https://api.github.com/repos/zulip/zulip","labels_url":"https://api.github.com/repos/zulip/zulip/issues/513/labels{/name}","comments_url":"https://api.github.com/repos/zulip/zulip/issues/513/comments","events_url":"https://api.github.com/repos/zulip/zulip/issues/513/events","html_url":"https://github.com/zulip/zulip/pull/513","id":140296450,"number":513,"title":"Webhooks refactor","user":{"login":"TomaszKolek","id":5993758,"avatar_url":"https://avatars.githubusercontent.com/u/5993758?v=3","gravatar_id":"","url":"https://api.github.com/users/TomaszKolek","html_url":"https://github.com/TomaszKolek","followers_url":"https://api.github.com/users/TomaszKolek/followers","following_url":"https://api.github.com/users/TomaszKolek/following{/other_user}","gists_url":"https://api.github.com/users/TomaszKolek/gists{/gist_id}","starred_url":"https://api.github.com/users/TomaszKolek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomaszKolek/subscriptions","organizations_url":"https://api.github.com/users/TomaszKolek/orgs","repos_url":"https://api.github.com/users/TomaszKolek/repos","events_url":"https://api.github.com/users/TomaszKolek/events{/privacy}","received_events_url":"https://api.github.com/users/TomaszKolek/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2016-03-11T21:26:19Z","updated_at":"2016-03-13T16:53:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zulip/zulip/pulls/513","html_url":"https://github.com/zulip/zulip/pull/513","diff_url":"https://github.com/zulip/zulip/pull/513.diff","patch_url":"https://github.com/zulip/zulip/pull/513.patch"},"body":"Please look and review if its good approach or not.\r\nthat's probably something wrong with tests - at least locally I will take a look.\r\n"},"comment":{"url":"https://api.github.com/repos/zulip/zulip/issues/comments/195996123","html_url":"https://github.com/zulip/zulip/pull/513#issuecomment-195996123","issue_url":"https://api.github.com/repos/zulip/zulip/issues/513","id":195996123,"user":{"login":"timabbott","id":2746074,"avatar_url":"https://avatars.githubusercontent.com/u/2746074?v=3","gravatar_id":"","url":"https://api.github.com/users/timabbott","html_url":"https://github.com/timabbott","followers_url":"https://api.github.com/users/timabbott/followers","following_url":"https://api.github.com/users/timabbott/following{/other_user}","gists_url":"https://api.github.com/users/timabbott/gists{/gist_id}","starred_url":"https://api.github.com/users/timabbott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timabbott/subscriptions","organizations_url":"https://api.github.com/users/timabbott/orgs","repos_url":"https://api.github.com/users/timabbott/repos","events_url":"https://api.github.com/users/timabbott/events{/privacy}","received_events_url":"https://api.github.com/users/timabbott/received_events","type":"User","site_admin":false},"created_at":"2016-03-13T16:53:30Z","updated_at":"2016-03-13T16:53:30Z","body":"@TomaszKolek thanks for working on this!  I have a few comments:\r\n* A lot of your new files are missing newlines at the end of them -- can you fix that by rebasing to update the commits introducing them?\r\n* You have a commit fixing a mistake in the pivotal webhook -- can you squash that into the original pivotal commit?\r\n* It looks like you've done substantial refactors to the code within the functions as part of moving them to new files.  Unfortunately, this makes it very difficult to review your changes, and it's very common for bugs to be introduced in this sort of migration, so we'll need to fix the commits to be reviewable before this can be merged.  To fix this, can you rebase your branch to have for each webhook, first a commit that moves the code to the new file (and makes absolutely no changes whatsoever to the code other than moving the imports), and then if you'd like to clean up or reformat the code, additional commit(s) that do those cleanups?  In case you're not familiar with how to do this sort of rebase, I'm happy to provide advice -- just let me know!\r\n* http://zulip.readthedocs.org/en/latest/code-style.html#version-control is helpful reading on how we do commit discipline for Zulip.\r\n\r\nThanks again for working on this and I'm sorry I didn't provide a more clear pointer to the Zulip commit style yesterday!  "}}