{"action":"created","comment":{"url":"https://api.github.com/repos/shazow/urllib3/pulls/comments/68083789","id":68083789,"diff_hunk":"@@ -61,91 +54,79 @@ def request(self, method, url, fields=None, headers=None, **urlopen_kw):\n         :meth:`request_encode_url`, :meth:`request_encode_body`,\n         or even the lowest level :meth:`urlopen`.\n         \"\"\"\n+        pops = [\n+            'encode_multipart',\n+            'multipart_boundary',\n+            'form_fields',\n+            'url_params',\n+            'fields'\n+        ]\n         method = method.upper()\n-\n-        if method in self._encode_url_methods:\n-            return self.request_encode_url(method, url, fields=fields,\n-                                           headers=headers,\n-                                           **urlopen_kw)\n-        else:\n-            return self.request_encode_body(method, url, fields=fields,\n-                                            headers=headers,\n-                                            **urlopen_kw)\n-\n-    def request_encode_url(self, method, url, fields=None, headers=None,","path":"urllib3/request.py","position":59,"original_position":59,"commit_id":"7f0cfcd9ecd502505c3679e52987be034ed9c31b","original_commit_id":"7f0cfcd9ecd502505c3679e52987be034ed9c31b","user":{"login":"shazow","id":6292,"avatar_url":"https://avatars.githubusercontent.com/u/6292?v=3","gravatar_id":"","url":"https://api.github.com/users/shazow","html_url":"https://github.com/shazow","followers_url":"https://api.github.com/users/shazow/followers","following_url":"https://api.github.com/users/shazow/following{/other_user}","gists_url":"https://api.github.com/users/shazow/gists{/gist_id}","starred_url":"https://api.github.com/users/shazow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shazow/subscriptions","organizations_url":"https://api.github.com/users/shazow/orgs","repos_url":"https://api.github.com/users/shazow/repos","events_url":"https://api.github.com/users/shazow/events{/privacy}","received_events_url":"https://api.github.com/users/shazow/received_events","type":"User","site_admin":false},"body":"We probably want to keep backwards compat for these public methods?","created_at":"2016-06-22T16:10:46Z","updated_at":"2016-06-22T16:10:46Z","html_url":"https://github.com/shazow/urllib3/pull/903#discussion_r68083789","pull_request_url":"https://api.github.com/repos/shazow/urllib3/pulls/903","_links":{"self":{"href":"https://api.github.com/repos/shazow/urllib3/pulls/comments/68083789"},"html":{"href":"https://github.com/shazow/urllib3/pull/903#discussion_r68083789"},"pull_request":{"href":"https://api.github.com/repos/shazow/urllib3/pulls/903"}}},"pull_request":{"url":"https://api.github.com/repos/shazow/urllib3/pulls/903","id":74662442,"html_url":"https://github.com/shazow/urllib3/pull/903","diff_url":"https://github.com/shazow/urllib3/pull/903.diff","patch_url":"https://github.com/shazow/urllib3/pull/903.patch","issue_url":"https://api.github.com/repos/shazow/urllib3/issues/903","number":903,"state":"open","locked":false,"title":"Discrete field types in RequestMethods","user":{"login":"haikuginger","id":7773758,"avatar_url":"https://avatars.githubusercontent.com/u/7773758?v=3","gravatar_id":"","url":"https://api.github.com/users/haikuginger","html_url":"https://github.com/haikuginger","followers_url":"https://api.github.com/users/haikuginger/followers","following_url":"https://api.github.com/users/haikuginger/following{/other_user}","gists_url":"https://api.github.com/users/haikuginger/gists{/gist_id}","starred_url":"https://api.github.com/users/haikuginger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haikuginger/subscriptions","organizations_url":"https://api.github.com/users/haikuginger/orgs","repos_url":"https://api.github.com/users/haikuginger/repos","events_url":"https://api.github.com/users/haikuginger/events{/privacy}","received_events_url":"https://api.github.com/users/haikuginger/received_events","type":"User","site_admin":false},"body":"Implements #885, in support of #892.","created_at":"2016-06-21T18:31:09Z","updated_at":"2016-06-22T16:10:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ebf6805ec4bd404986d6e13982f1ec37fe39099f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/shazow/urllib3/pulls/903/commits","review_comments_url":"https://api.github.com/repos/shazow/urllib3/pulls/903/comments","review_comment_url":"https://api.github.com/repos/shazow/urllib3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shazow/urllib3/issues/903/comments","statuses_url":"https://api.github.com/repos/shazow/urllib3/statuses/7f0cfcd9ecd502505c3679e52987be034ed9c31b","head":{"label":"haikuginger:discrete-field-types","ref":"discrete-field-types","sha":"7f0cfcd9ecd502505c3679e52987be034ed9c31b","user":{"login":"haikuginger","id":7773758,"avatar_url":"https://avatars.githubusercontent.com/u/7773758?v=3","gravatar_id":"","url":"https://api.github.com/users/haikuginger","html_url":"https://github.com/haikuginger","followers_url":"https://api.github.com/users/haikuginger/followers","following_url":"https://api.github.com/users/haikuginger/following{/other_user}","gists_url":"https://api.github.com/users/haikuginger/gists{/gist_id}","starred_url":"https://api.github.com/users/haikuginger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haikuginger/subscriptions","organizations_url":"https://api.github.com/users/haikuginger/orgs","repos_url":"https://api.github.com/users/haikuginger/repos","events_url":"https://api.github.com/users/haikuginger/events{/privacy}","received_events_url":"https://api.github.com/users/haikuginger/received_events","type":"User","site_admin":false},"repo":{"id":54031804,"name":"urllib3","full_name":"haikuginger/urllib3","owner":{"login":"haikuginger","id":7773758,"avatar_url":"https://avatars.githubusercontent.com/u/7773758?v=3","gravatar_id":"","url":"https://api.github.com/users/haikuginger","html_url":"https://github.com/haikuginger","followers_url":"https://api.github.com/users/haikuginger/followers","following_url":"https://api.github.com/users/haikuginger/following{/other_user}","gists_url":"https://api.github.com/users/haikuginger/gists{/gist_id}","starred_url":"https://api.github.com/users/haikuginger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haikuginger/subscriptions","organizations_url":"https://api.github.com/users/haikuginger/orgs","repos_url":"https://api.github.com/users/haikuginger/repos","events_url":"https://api.github.com/users/haikuginger/events{/privacy}","received_events_url":"https://api.github.com/users/haikuginger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/haikuginger/urllib3","description":"Python HTTP library with thread-safe connection pooling, file post support, sanity friendly, and more.","fork":true,"url":"https://api.github.com/repos/haikuginger/urllib3","forks_url":"https://api.github.com/repos/haikuginger/urllib3/forks","keys_url":"https://api.github.com/repos/haikuginger/urllib3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haikuginger/urllib3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haikuginger/urllib3/teams","hooks_url":"https://api.github.com/repos/haikuginger/urllib3/hooks","issue_events_url":"https://api.github.com/repos/haikuginger/urllib3/issues/events{/number}","events_url":"https://api.github.com/repos/haikuginger/urllib3/events","assignees_url":"https://api.github.com/repos/haikuginger/urllib3/assignees{/user}","branches_url":"https://api.github.com/repos/haikuginger/urllib3/branches{/branch}","tags_url":"https://api.github.com/repos/haikuginger/urllib3/tags","blobs_url":"https://api.github.com/repos/haikuginger/urllib3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haikuginger/urllib3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haikuginger/urllib3/git/refs{/sha}","trees_url":"https://api.github.com/repos/haikuginger/urllib3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haikuginger/urllib3/statuses/{sha}","languages_url":"https://api.github.com/repos/haikuginger/urllib3/languages","stargazers_url":"https://api.github.com/repos/haikuginger/urllib3/stargazers","contributors_url":"https://api.github.com/repos/haikuginger/urllib3/contributors","subscribers_url":"https://api.github.com/repos/haikuginger/urllib3/subscribers","subscription_url":"https://api.github.com/repos/haikuginger/urllib3/subscription","commits_url":"https://api.github.com/repos/haikuginger/urllib3/commits{/sha}","git_commits_url":"https://api.github.com/repos/haikuginger/urllib3/git/commits{/sha}","comments_url":"https://api.github.com/repos/haikuginger/urllib3/comments{/number}","issue_comment_url":"https://api.github.com/repos/haikuginger/urllib3/issues/comments{/number}","contents_url":"https://api.github.com/repos/haikuginger/urllib3/contents/{+path}","compare_url":"https://api.github.com/repos/haikuginger/urllib3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haikuginger/urllib3/merges","archive_url":"https://api.github.com/repos/haikuginger/urllib3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haikuginger/urllib3/downloads","issues_url":"https://api.github.com/repos/haikuginger/urllib3/issues{/number}","pulls_url":"https://api.github.com/repos/haikuginger/urllib3/pulls{/number}","milestones_url":"https://api.github.com/repos/haikuginger/urllib3/milestones{/number}","notifications_url":"https://api.github.com/repos/haikuginger/urllib3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haikuginger/urllib3/labels{/name}","releases_url":"https://api.github.com/repos/haikuginger/urllib3/releases{/id}","deployments_url":"https://api.github.com/repos/haikuginger/urllib3/deployments","created_at":"2016-03-16T12:56:31Z","updated_at":"2016-03-16T12:56:32Z","pushed_at":"2016-06-21T18:23:50Z","git_url":"git://github.com/haikuginger/urllib3.git","ssh_url":"git@github.com:haikuginger/urllib3.git","clone_url":"https://github.com/haikuginger/urllib3.git","svn_url":"https://github.com/haikuginger/urllib3","homepage":"http://urllib3.readthedocs.org/","size":2837,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"shazow:master","ref":"master","sha":"f69ad8e1b3e5c81c82f87a8126dffc3a7f02a3c8","user":{"login":"shazow","id":6292,"avatar_url":"https://avatars.githubusercontent.com/u/6292?v=3","gravatar_id":"","url":"https://api.github.com/users/shazow","html_url":"https://github.com/shazow","followers_url":"https://api.github.com/users/shazow/followers","following_url":"https://api.github.com/users/shazow/following{/other_user}","gists_url":"https://api.github.com/users/shazow/gists{/gist_id}","starred_url":"https://api.github.com/users/shazow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shazow/subscriptions","organizations_url":"https://api.github.com/users/shazow/orgs","repos_url":"https://api.github.com/users/shazow/repos","events_url":"https://api.github.com/users/shazow/events{/privacy}","received_events_url":"https://api.github.com/users/shazow/received_events","type":"User","site_admin":false},"repo":{"id":2410676,"name":"urllib3","full_name":"shazow/urllib3","owner":{"login":"shazow","id":6292,"avatar_url":"https://avatars.githubusercontent.com/u/6292?v=3","gravatar_id":"","url":"https://api.github.com/users/shazow","html_url":"https://github.com/shazow","followers_url":"https://api.github.com/users/shazow/followers","following_url":"https://api.github.com/users/shazow/following{/other_user}","gists_url":"https://api.github.com/users/shazow/gists{/gist_id}","starred_url":"https://api.github.com/users/shazow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shazow/subscriptions","organizations_url":"https://api.github.com/users/shazow/orgs","repos_url":"https://api.github.com/users/shazow/repos","events_url":"https://api.github.com/users/shazow/events{/privacy}","received_events_url":"https://api.github.com/users/shazow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shazow/urllib3","description":"Python HTTP library with thread-safe connection pooling, file post support, sanity friendly, and more.","fork":false,"url":"https://api.github.com/repos/shazow/urllib3","forks_url":"https://api.github.com/repos/shazow/urllib3/forks","keys_url":"https://api.github.com/repos/shazow/urllib3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shazow/urllib3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shazow/urllib3/teams","hooks_url":"https://api.github.com/repos/shazow/urllib3/hooks","issue_events_url":"https://api.github.com/repos/shazow/urllib3/issues/events{/number}","events_url":"https://api.github.com/repos/shazow/urllib3/events","assignees_url":"https://api.github.com/repos/shazow/urllib3/assignees{/user}","branches_url":"https://api.github.com/repos/shazow/urllib3/branches{/branch}","tags_url":"https://api.github.com/repos/shazow/urllib3/tags","blobs_url":"https://api.github.com/repos/shazow/urllib3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shazow/urllib3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shazow/urllib3/git/refs{/sha}","trees_url":"https://api.github.com/repos/shazow/urllib3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shazow/urllib3/statuses/{sha}","languages_url":"https://api.github.com/repos/shazow/urllib3/languages","stargazers_url":"https://api.github.com/repos/shazow/urllib3/stargazers","contributors_url":"https://api.github.com/repos/shazow/urllib3/contributors","subscribers_url":"https://api.github.com/repos/shazow/urllib3/subscribers","subscription_url":"https://api.github.com/repos/shazow/urllib3/subscription","commits_url":"https://api.github.com/repos/shazow/urllib3/commits{/sha}","git_commits_url":"https://api.github.com/repos/shazow/urllib3/git/commits{/sha}","comments_url":"https://api.github.com/repos/shazow/urllib3/comments{/number}","issue_comment_url":"https://api.github.com/repos/shazow/urllib3/issues/comments{/number}","contents_url":"https://api.github.com/repos/shazow/urllib3/contents/{+path}","compare_url":"https://api.github.com/repos/shazow/urllib3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shazow/urllib3/merges","archive_url":"https://api.github.com/repos/shazow/urllib3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shazow/urllib3/downloads","issues_url":"https://api.github.com/repos/shazow/urllib3/issues{/number}","pulls_url":"https://api.github.com/repos/shazow/urllib3/pulls{/number}","milestones_url":"https://api.github.com/repos/shazow/urllib3/milestones{/number}","notifications_url":"https://api.github.com/repos/shazow/urllib3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shazow/urllib3/labels{/name}","releases_url":"https://api.github.com/repos/shazow/urllib3/releases{/id}","deployments_url":"https://api.github.com/repos/shazow/urllib3/deployments","created_at":"2011-09-18T18:08:28Z","updated_at":"2016-06-22T14:15:05Z","pushed_at":"2016-06-22T16:08:16Z","git_url":"git://github.com/shazow/urllib3.git","ssh_url":"git@github.com:shazow/urllib3.git","clone_url":"https://github.com/shazow/urllib3.git","svn_url":"https://github.com/shazow/urllib3","homepage":"https://urllib3.readthedocs.io/","size":4850,"stargazers_count":1060,"watchers_count":1060,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":355,"mirror_url":null,"open_issues_count":120,"forks":355,"open_issues":120,"watchers":1060,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shazow/urllib3/pulls/903"},"html":{"href":"https://github.com/shazow/urllib3/pull/903"},"issue":{"href":"https://api.github.com/repos/shazow/urllib3/issues/903"},"comments":{"href":"https://api.github.com/repos/shazow/urllib3/issues/903/comments"},"review_comments":{"href":"https://api.github.com/repos/shazow/urllib3/pulls/903/comments"},"review_comment":{"href":"https://api.github.com/repos/shazow/urllib3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shazow/urllib3/pulls/903/commits"},"statuses":{"href":"https://api.github.com/repos/shazow/urllib3/statuses/7f0cfcd9ecd502505c3679e52987be034ed9c31b"}}}}
{"actor":{"display_login":"shazow"}}