{"action":"created","issue":{"url":"https://api.github.com/repos/api-php/boilerplate/issues/5","repository_url":"https://api.github.com/repos/api-php/boilerplate","labels_url":"https://api.github.com/repos/api-php/boilerplate/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/api-php/boilerplate/issues/5/comments","events_url":"https://api.github.com/repos/api-php/boilerplate/issues/5/events","html_url":"https://github.com/api-php/boilerplate/issues/5","id":194424720,"number":5,"title":"Use HttpClient in ApiClient constructor","user":{"login":"sagikazarmark","id":1226384,"avatar_url":"https://avatars.githubusercontent.com/u/1226384?v=3","gravatar_id":"","url":"https://api.github.com/users/sagikazarmark","html_url":"https://github.com/sagikazarmark","followers_url":"https://api.github.com/users/sagikazarmark/followers","following_url":"https://api.github.com/users/sagikazarmark/following{/other_user}","gists_url":"https://api.github.com/users/sagikazarmark/gists{/gist_id}","starred_url":"https://api.github.com/users/sagikazarmark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sagikazarmark/subscriptions","organizations_url":"https://api.github.com/users/sagikazarmark/orgs","repos_url":"https://api.github.com/users/sagikazarmark/repos","events_url":"https://api.github.com/users/sagikazarmark/events{/privacy}","received_events_url":"https://api.github.com/users/sagikazarmark/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-12-08T19:36:59Z","updated_at":"2016-12-11T07:08:49Z","closed_at":null,"body":"I would create an `ApiClient::configure` method which accepts the current parameters and injects the HTTP client. Better in case someone configures a client himself."},"comment":{"url":"https://api.github.com/repos/api-php/boilerplate/issues/comments/266267253","html_url":"https://github.com/api-php/boilerplate/issues/5#issuecomment-266267253","issue_url":"https://api.github.com/repos/api-php/boilerplate/issues/5","id":266267253,"user":{"login":"sagikazarmark","id":1226384,"avatar_url":"https://avatars.githubusercontent.com/u/1226384?v=3","gravatar_id":"","url":"https://api.github.com/users/sagikazarmark","html_url":"https://github.com/sagikazarmark","followers_url":"https://api.github.com/users/sagikazarmark/followers","following_url":"https://api.github.com/users/sagikazarmark/following{/other_user}","gists_url":"https://api.github.com/users/sagikazarmark/gists{/gist_id}","starred_url":"https://api.github.com/users/sagikazarmark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sagikazarmark/subscriptions","organizations_url":"https://api.github.com/users/sagikazarmark/orgs","repos_url":"https://api.github.com/users/sagikazarmark/repos","events_url":"https://api.github.com/users/sagikazarmark/events{/privacy}","received_events_url":"https://api.github.com/users/sagikazarmark/received_events","type":"User","site_admin":false},"created_at":"2016-12-11T07:08:49Z","updated_at":"2016-12-11T07:08:49Z","body":"Well, I don't really like how Github does things with the builder. I don't see why modifying dependencies runtime (after instantiation) like cache makes sense. Apart from those, the Builder also caches the client, so upon the first access (if no changes are made) it will always return the same client. So why not do it once then?"}}
{"actor":{"display_login":"sagikazarmark"}}