{"action":"created","comment":{"url":"https://api.github.com/repos/odoo/odoo/pulls/comments/74038239","id":74038239,"diff_hunk":"@@ -1182,7 +1182,7 @@ var ClientListScreenWidget = ScreenWidget.extend({\n         \n         var fields = {};\n         this.$('.client-details-contents .detail').each(function(idx,el){\n-            fields[el.name] = el.value;\n+            fields[el.name] = el.value || false;","path":"addons/point_of_sale/static/src/js/screens.js","position":5,"original_position":5,"commit_id":"404c4e63f46000f49ab2e13bb2b7ca7d6e794cd1","original_commit_id":"404c4e63f46000f49ab2e13bb2b7ca7d6e794cd1","user":{"login":"mart-e","id":564822,"avatar_url":"https://avatars.githubusercontent.com/u/564822?v=3","gravatar_id":"","url":"https://api.github.com/users/mart-e","html_url":"https://github.com/mart-e","followers_url":"https://api.github.com/users/mart-e/followers","following_url":"https://api.github.com/users/mart-e/following{/other_user}","gists_url":"https://api.github.com/users/mart-e/gists{/gist_id}","starred_url":"https://api.github.com/users/mart-e/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mart-e/subscriptions","organizations_url":"https://api.github.com/users/mart-e/orgs","repos_url":"https://api.github.com/users/mart-e/repos","events_url":"https://api.github.com/users/mart-e/events{/privacy}","received_events_url":"https://api.github.com/users/mart-e/received_events","type":"User","site_admin":false},"body":"The `false` was to match the `fields.id = partner.id || false;` just below. Not sure which is better. \r\nDo you mean something like\r\n```javascript\r\nif (el.value && partner.id)\r\n    fields[el.name] = el.value;\r\n```\r\n? We can skip the field only for the create, not the update, as it would prevent to remove a value.","created_at":"2016-08-09T11:08:02Z","updated_at":"2016-08-09T11:08:02Z","html_url":"https://github.com/odoo/odoo/pull/13077#discussion_r74038239","pull_request_url":"https://api.github.com/repos/odoo/odoo/pulls/13077","_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments/74038239"},"html":{"href":"https://github.com/odoo/odoo/pull/13077#discussion_r74038239"},"pull_request":{"href":"https://api.github.com/repos/odoo/odoo/pulls/13077"}}},"pull_request":{"url":"https://api.github.com/repos/odoo/odoo/pulls/13077","id":80587945,"html_url":"https://github.com/odoo/odoo/pull/13077","diff_url":"https://github.com/odoo/odoo/pull/13077.diff","patch_url":"https://github.com/odoo/odoo/pull/13077.patch","issue_url":"https://api.github.com/repos/odoo/odoo/issues/13077","number":13077,"state":"open","locked":false,"title":"[IMP] point_of_sale: create a partner with empty field","user":{"login":"mart-e","id":564822,"avatar_url":"https://avatars.githubusercontent.com/u/564822?v=3","gravatar_id":"","url":"https://api.github.com/users/mart-e","html_url":"https://github.com/mart-e","followers_url":"https://api.github.com/users/mart-e/followers","following_url":"https://api.github.com/users/mart-e/following{/other_user}","gists_url":"https://api.github.com/users/mart-e/gists{/gist_id}","starred_url":"https://api.github.com/users/mart-e/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mart-e/subscriptions","organizations_url":"https://api.github.com/users/mart-e/orgs","repos_url":"https://api.github.com/users/mart-e/repos","events_url":"https://api.github.com/users/mart-e/events{/privacy}","received_events_url":"https://api.github.com/users/mart-e/received_events","type":"User","site_admin":false},"body":"When creating a partner, the fields where the information is not specified are\r\nfilled with an empty string value.\r\nThe empty string value is not ideal as prevents to use filters like \"email not\r\nset\" and forces to use more complexe domain \"... or email = ''\"\r\n\r\nopw-684902","created_at":"2016-08-09T09:25:37Z","updated_at":"2016-08-09T11:08:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b3f3be6a0012e731fe0c2008cdfd701d529250d","assignee":{"login":"mge-odoo","id":8794369,"avatar_url":"https://avatars.githubusercontent.com/u/8794369?v=3","gravatar_id":"","url":"https://api.github.com/users/mge-odoo","html_url":"https://github.com/mge-odoo","followers_url":"https://api.github.com/users/mge-odoo/followers","following_url":"https://api.github.com/users/mge-odoo/following{/other_user}","gists_url":"https://api.github.com/users/mge-odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/mge-odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mge-odoo/subscriptions","organizations_url":"https://api.github.com/users/mge-odoo/orgs","repos_url":"https://api.github.com/users/mge-odoo/repos","events_url":"https://api.github.com/users/mge-odoo/events{/privacy}","received_events_url":"https://api.github.com/users/mge-odoo/received_events","type":"User","site_admin":false},"assignees":[{"login":"mge-odoo","id":8794369,"avatar_url":"https://avatars.githubusercontent.com/u/8794369?v=3","gravatar_id":"","url":"https://api.github.com/users/mge-odoo","html_url":"https://github.com/mge-odoo","followers_url":"https://api.github.com/users/mge-odoo/followers","following_url":"https://api.github.com/users/mge-odoo/following{/other_user}","gists_url":"https://api.github.com/users/mge-odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/mge-odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mge-odoo/subscriptions","organizations_url":"https://api.github.com/users/mge-odoo/orgs","repos_url":"https://api.github.com/users/mge-odoo/repos","events_url":"https://api.github.com/users/mge-odoo/events{/privacy}","received_events_url":"https://api.github.com/users/mge-odoo/received_events","type":"User","site_admin":false},{"login":"jorenvo","id":10252581,"avatar_url":"https://avatars.githubusercontent.com/u/10252581?v=3","gravatar_id":"","url":"https://api.github.com/users/jorenvo","html_url":"https://github.com/jorenvo","followers_url":"https://api.github.com/users/jorenvo/followers","following_url":"https://api.github.com/users/jorenvo/following{/other_user}","gists_url":"https://api.github.com/users/jorenvo/gists{/gist_id}","starred_url":"https://api.github.com/users/jorenvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorenvo/subscriptions","organizations_url":"https://api.github.com/users/jorenvo/orgs","repos_url":"https://api.github.com/users/jorenvo/repos","events_url":"https://api.github.com/users/jorenvo/events{/privacy}","received_events_url":"https://api.github.com/users/jorenvo/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/odoo/odoo/pulls/13077/commits","review_comments_url":"https://api.github.com/repos/odoo/odoo/pulls/13077/comments","review_comment_url":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/odoo/odoo/issues/13077/comments","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/404c4e63f46000f49ab2e13bb2b7ca7d6e794cd1","head":{"label":"odoo-dev:master-pos-create-partner-false-mat","ref":"master-pos-create-partner-false-mat","sha":"404c4e63f46000f49ab2e13bb2b7ca7d6e794cd1","user":{"login":"odoo-dev","id":7466976,"avatar_url":"https://avatars.githubusercontent.com/u/7466976?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo-dev","html_url":"https://github.com/odoo-dev","followers_url":"https://api.github.com/users/odoo-dev/followers","following_url":"https://api.github.com/users/odoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/odoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo-dev/subscriptions","organizations_url":"https://api.github.com/users/odoo-dev/orgs","repos_url":"https://api.github.com/users/odoo-dev/repos","events_url":"https://api.github.com/users/odoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/odoo-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":19853934,"name":"odoo","full_name":"odoo-dev/odoo","owner":{"login":"odoo-dev","id":7466976,"avatar_url":"https://avatars.githubusercontent.com/u/7466976?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo-dev","html_url":"https://github.com/odoo-dev","followers_url":"https://api.github.com/users/odoo-dev/followers","following_url":"https://api.github.com/users/odoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/odoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo-dev/subscriptions","organizations_url":"https://api.github.com/users/odoo-dev/orgs","repos_url":"https://api.github.com/users/odoo-dev/repos","events_url":"https://api.github.com/users/odoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/odoo-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odoo-dev/odoo","description":"RD Dev Repository","fork":true,"url":"https://api.github.com/repos/odoo-dev/odoo","forks_url":"https://api.github.com/repos/odoo-dev/odoo/forks","keys_url":"https://api.github.com/repos/odoo-dev/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo-dev/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo-dev/odoo/teams","hooks_url":"https://api.github.com/repos/odoo-dev/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo-dev/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo-dev/odoo/events","assignees_url":"https://api.github.com/repos/odoo-dev/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo-dev/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo-dev/odoo/tags","blobs_url":"https://api.github.com/repos/odoo-dev/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo-dev/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo-dev/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo-dev/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo-dev/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo-dev/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo-dev/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo-dev/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo-dev/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo-dev/odoo/subscription","commits_url":"https://api.github.com/repos/odoo-dev/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo-dev/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo-dev/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo-dev/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/odoo-dev/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo-dev/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo-dev/odoo/merges","archive_url":"https://api.github.com/repos/odoo-dev/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo-dev/odoo/downloads","issues_url":"https://api.github.com/repos/odoo-dev/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo-dev/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo-dev/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo-dev/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo-dev/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo-dev/odoo/releases{/id}","deployments_url":"https://api.github.com/repos/odoo-dev/odoo/deployments","created_at":"2014-05-16T11:16:19Z","updated_at":"2016-07-08T06:06:40Z","pushed_at":"2016-08-09T10:47:56Z","git_url":"git://github.com/odoo-dev/odoo.git","ssh_url":"git@github.com:odoo-dev/odoo.git","clone_url":"https://github.com/odoo-dev/odoo.git","svn_url":"https://github.com/odoo-dev/odoo","homepage":"https://www.odoo.com","size":3663082,"stargazers_count":70,"watchers_count":70,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":0,"forks":27,"open_issues":0,"watchers":70,"default_branch":"master"}},"base":{"label":"odoo:master","ref":"master","sha":"665d1ec146adc142d63a3b714210b5876c598366","user":{"login":"odoo","id":6368483,"avatar_url":"https://avatars.githubusercontent.com/u/6368483?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"repo":{"id":19745004,"name":"odoo","full_name":"odoo/odoo","owner":{"login":"odoo","id":6368483,"avatar_url":"https://avatars.githubusercontent.com/u/6368483?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odoo/odoo","description":"Odoo (formerly OpenERP). Open Source Apps To Grow Your Business.","fork":false,"url":"https://api.github.com/repos/odoo/odoo","forks_url":"https://api.github.com/repos/odoo/odoo/forks","keys_url":"https://api.github.com/repos/odoo/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo/odoo/teams","hooks_url":"https://api.github.com/repos/odoo/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo/odoo/events","assignees_url":"https://api.github.com/repos/odoo/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo/odoo/tags","blobs_url":"https://api.github.com/repos/odoo/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo/odoo/subscription","commits_url":"https://api.github.com/repos/odoo/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/odoo/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo/odoo/merges","archive_url":"https://api.github.com/repos/odoo/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo/odoo/downloads","issues_url":"https://api.github.com/repos/odoo/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo/odoo/releases{/id}","deployments_url":"https://api.github.com/repos/odoo/odoo/deployments","created_at":"2014-05-13T15:38:58Z","updated_at":"2016-08-09T07:55:30Z","pushed_at":"2016-08-09T10:53:57Z","git_url":"git://github.com/odoo/odoo.git","ssh_url":"git@github.com:odoo/odoo.git","clone_url":"https://github.com/odoo/odoo.git","svn_url":"https://github.com/odoo/odoo","homepage":"https://www.odoo.com","size":1821711,"stargazers_count":4794,"watchers_count":4794,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4568,"mirror_url":null,"open_issues_count":3165,"forks":4568,"open_issues":3165,"watchers":4794,"default_branch":"9.0"}},"_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/13077"},"html":{"href":"https://github.com/odoo/odoo/pull/13077"},"issue":{"href":"https://api.github.com/repos/odoo/odoo/issues/13077"},"comments":{"href":"https://api.github.com/repos/odoo/odoo/issues/13077/comments"},"review_comments":{"href":"https://api.github.com/repos/odoo/odoo/pulls/13077/comments"},"review_comment":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/odoo/odoo/pulls/13077/commits"},"statuses":{"href":"https://api.github.com/repos/odoo/odoo/statuses/404c4e63f46000f49ab2e13bb2b7ca7d6e794cd1"}}}}
{"actor":{"display_login":"mart-e"}}