{"action":"closed","number":3,"pull_request":{"url":"https://api.github.com/repos/sparkeh9/CoreFTP/pulls/3","id":88338838,"html_url":"https://github.com/sparkeh9/CoreFTP/pull/3","diff_url":"https://github.com/sparkeh9/CoreFTP/pull/3.diff","patch_url":"https://github.com/sparkeh9/CoreFTP/pull/3.patch","issue_url":"https://api.github.com/repos/sparkeh9/CoreFTP/issues/3","number":3,"state":"closed","locked":false,"title":"Support NLST for directory listing retrieval","user":{"login":"mormegil-cz","id":432985,"avatar_url":"https://avatars.githubusercontent.com/u/432985?v=3","gravatar_id":"","url":"https://api.github.com/users/mormegil-cz","html_url":"https://github.com/mormegil-cz","followers_url":"https://api.github.com/users/mormegil-cz/followers","following_url":"https://api.github.com/users/mormegil-cz/following{/other_user}","gists_url":"https://api.github.com/users/mormegil-cz/gists{/gist_id}","starred_url":"https://api.github.com/users/mormegil-cz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mormegil-cz/subscriptions","organizations_url":"https://api.github.com/users/mormegil-cz/orgs","repos_url":"https://api.github.com/users/mormegil-cz/repos","events_url":"https://api.github.com/users/mormegil-cz/events{/privacy}","received_events_url":"https://api.github.com/users/mormegil-cz/received_events","type":"User","site_admin":false},"body":"This patch adds alternative directory listing retrieval using NLST to fix #2.\r\n\r\nHowever, NLST is less capable than MLSD, so this does not really fit into the interface split between\r\n`ListFilesAsync` and `ListDirectoriesAsync`, returning detailed `FtpNodeInformation`, etc. Also, a better implementation would be more general, allowing to use still other ways how to list files in FTP, and detecting the correct command once at the connection open, e.g. using the `FEAT` command.\r\n\r\nSo, this is not a perfect final solution, I guess, and it might be rejected and implemented in a better way. However, it is a small improvement over the current version which might be improved later.","created_at":"2016-10-06T20:52:38Z","updated_at":"2016-10-07T21:03:11Z","closed_at":"2016-10-07T21:03:11Z","merged_at":"2016-10-07T21:03:11Z","merge_commit_sha":"378162a9c314fe4a01cbf78063891e813b9c4237","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sparkeh9/CoreFTP/pulls/3/commits","review_comments_url":"https://api.github.com/repos/sparkeh9/CoreFTP/pulls/3/comments","review_comment_url":"https://api.github.com/repos/sparkeh9/CoreFTP/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sparkeh9/CoreFTP/issues/3/comments","statuses_url":"https://api.github.com/repos/sparkeh9/CoreFTP/statuses/d4fd3760b6dd9788d9ca5267ba77dd88732069d3","head":{"label":"mormegil-cz:list-files-using-nlst","ref":"list-files-using-nlst","sha":"d4fd3760b6dd9788d9ca5267ba77dd88732069d3","user":{"login":"mormegil-cz","id":432985,"avatar_url":"https://avatars.githubusercontent.com/u/432985?v=3","gravatar_id":"","url":"https://api.github.com/users/mormegil-cz","html_url":"https://github.com/mormegil-cz","followers_url":"https://api.github.com/users/mormegil-cz/followers","following_url":"https://api.github.com/users/mormegil-cz/following{/other_user}","gists_url":"https://api.github.com/users/mormegil-cz/gists{/gist_id}","starred_url":"https://api.github.com/users/mormegil-cz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mormegil-cz/subscriptions","organizations_url":"https://api.github.com/users/mormegil-cz/orgs","repos_url":"https://api.github.com/users/mormegil-cz/repos","events_url":"https://api.github.com/users/mormegil-cz/events{/privacy}","received_events_url":"https://api.github.com/users/mormegil-cz/received_events","type":"User","site_admin":false},"repo":{"id":69604412,"name":"CoreFTP","full_name":"mormegil-cz/CoreFTP","owner":{"login":"mormegil-cz","id":432985,"avatar_url":"https://avatars.githubusercontent.com/u/432985?v=3","gravatar_id":"","url":"https://api.github.com/users/mormegil-cz","html_url":"https://github.com/mormegil-cz","followers_url":"https://api.github.com/users/mormegil-cz/followers","following_url":"https://api.github.com/users/mormegil-cz/following{/other_user}","gists_url":"https://api.github.com/users/mormegil-cz/gists{/gist_id}","starred_url":"https://api.github.com/users/mormegil-cz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mormegil-cz/subscriptions","organizations_url":"https://api.github.com/users/mormegil-cz/orgs","repos_url":"https://api.github.com/users/mormegil-cz/repos","events_url":"https://api.github.com/users/mormegil-cz/events{/privacy}","received_events_url":"https://api.github.com/users/mormegil-cz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mormegil-cz/CoreFTP","description":"An FTP library written in C# with no external dependencies","fork":true,"url":"https://api.github.com/repos/mormegil-cz/CoreFTP","forks_url":"https://api.github.com/repos/mormegil-cz/CoreFTP/forks","keys_url":"https://api.github.com/repos/mormegil-cz/CoreFTP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mormegil-cz/CoreFTP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mormegil-cz/CoreFTP/teams","hooks_url":"https://api.github.com/repos/mormegil-cz/CoreFTP/hooks","issue_events_url":"https://api.github.com/repos/mormegil-cz/CoreFTP/issues/events{/number}","events_url":"https://api.github.com/repos/mormegil-cz/CoreFTP/events","assignees_url":"https://api.github.com/repos/mormegil-cz/CoreFTP/assignees{/user}","branches_url":"https://api.github.com/repos/mormegil-cz/CoreFTP/branches{/branch}","tags_url":"https://api.github.com/repos/mormegil-cz/CoreFTP/tags","blobs_url":"https://api.github.com/repos/mormegil-cz/CoreFTP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mormegil-cz/CoreFTP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mormegil-cz/CoreFTP/git/refs{/sha}","trees_url":"https://api.github.com/repos/mormegil-cz/CoreFTP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mormegil-cz/CoreFTP/statuses/{sha}","languages_url":"https://api.github.com/repos/mormegil-cz/CoreFTP/languages","stargazers_url":"https://api.github.com/repos/mormegil-cz/CoreFTP/stargazers","contributors_url":"https://api.github.com/repos/mormegil-cz/CoreFTP/contributors","subscribers_url":"https://api.github.com/repos/mormegil-cz/CoreFTP/subscribers","subscription_url":"https://api.github.com/repos/mormegil-cz/CoreFTP/subscription","commits_url":"https://api.github.com/repos/mormegil-cz/CoreFTP/commits{/sha}","git_commits_url":"https://api.github.com/repos/mormegil-cz/CoreFTP/git/commits{/sha}","comments_url":"https://api.github.com/repos/mormegil-cz/CoreFTP/comments{/number}","issue_comment_url":"https://api.github.com/repos/mormegil-cz/CoreFTP/issues/comments{/number}","contents_url":"https://api.github.com/repos/mormegil-cz/CoreFTP/contents/{+path}","compare_url":"https://api.github.com/repos/mormegil-cz/CoreFTP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mormegil-cz/CoreFTP/merges","archive_url":"https://api.github.com/repos/mormegil-cz/CoreFTP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mormegil-cz/CoreFTP/downloads","issues_url":"https://api.github.com/repos/mormegil-cz/CoreFTP/issues{/number}","pulls_url":"https://api.github.com/repos/mormegil-cz/CoreFTP/pulls{/number}","milestones_url":"https://api.github.com/repos/mormegil-cz/CoreFTP/milestones{/number}","notifications_url":"https://api.github.com/repos/mormegil-cz/CoreFTP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mormegil-cz/CoreFTP/labels{/name}","releases_url":"https://api.github.com/repos/mormegil-cz/CoreFTP/releases{/id}","deployments_url":"https://api.github.com/repos/mormegil-cz/CoreFTP/deployments","created_at":"2016-09-29T20:17:16Z","updated_at":"2016-09-29T20:17:17Z","pushed_at":"2016-10-06T20:49:33Z","git_url":"git://github.com/mormegil-cz/CoreFTP.git","ssh_url":"git@github.com:mormegil-cz/CoreFTP.git","clone_url":"https://github.com/mormegil-cz/CoreFTP.git","svn_url":"https://github.com/mormegil-cz/CoreFTP","homepage":null,"size":354,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sparkeh9:master","ref":"master","sha":"7fff3818ea00988e5b643482272e4a8d76c3c3b7","user":{"login":"sparkeh9","id":5622386,"avatar_url":"https://avatars.githubusercontent.com/u/5622386?v=3","gravatar_id":"","url":"https://api.github.com/users/sparkeh9","html_url":"https://github.com/sparkeh9","followers_url":"https://api.github.com/users/sparkeh9/followers","following_url":"https://api.github.com/users/sparkeh9/following{/other_user}","gists_url":"https://api.github.com/users/sparkeh9/gists{/gist_id}","starred_url":"https://api.github.com/users/sparkeh9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sparkeh9/subscriptions","organizations_url":"https://api.github.com/users/sparkeh9/orgs","repos_url":"https://api.github.com/users/sparkeh9/repos","events_url":"https://api.github.com/users/sparkeh9/events{/privacy}","received_events_url":"https://api.github.com/users/sparkeh9/received_events","type":"User","site_admin":false},"repo":{"id":68404794,"name":"CoreFTP","full_name":"sparkeh9/CoreFTP","owner":{"login":"sparkeh9","id":5622386,"avatar_url":"https://avatars.githubusercontent.com/u/5622386?v=3","gravatar_id":"","url":"https://api.github.com/users/sparkeh9","html_url":"https://github.com/sparkeh9","followers_url":"https://api.github.com/users/sparkeh9/followers","following_url":"https://api.github.com/users/sparkeh9/following{/other_user}","gists_url":"https://api.github.com/users/sparkeh9/gists{/gist_id}","starred_url":"https://api.github.com/users/sparkeh9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sparkeh9/subscriptions","organizations_url":"https://api.github.com/users/sparkeh9/orgs","repos_url":"https://api.github.com/users/sparkeh9/repos","events_url":"https://api.github.com/users/sparkeh9/events{/privacy}","received_events_url":"https://api.github.com/users/sparkeh9/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sparkeh9/CoreFTP","description":"An FTP library written in C# with no external dependencies","fork":false,"url":"https://api.github.com/repos/sparkeh9/CoreFTP","forks_url":"https://api.github.com/repos/sparkeh9/CoreFTP/forks","keys_url":"https://api.github.com/repos/sparkeh9/CoreFTP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sparkeh9/CoreFTP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sparkeh9/CoreFTP/teams","hooks_url":"https://api.github.com/repos/sparkeh9/CoreFTP/hooks","issue_events_url":"https://api.github.com/repos/sparkeh9/CoreFTP/issues/events{/number}","events_url":"https://api.github.com/repos/sparkeh9/CoreFTP/events","assignees_url":"https://api.github.com/repos/sparkeh9/CoreFTP/assignees{/user}","branches_url":"https://api.github.com/repos/sparkeh9/CoreFTP/branches{/branch}","tags_url":"https://api.github.com/repos/sparkeh9/CoreFTP/tags","blobs_url":"https://api.github.com/repos/sparkeh9/CoreFTP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sparkeh9/CoreFTP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sparkeh9/CoreFTP/git/refs{/sha}","trees_url":"https://api.github.com/repos/sparkeh9/CoreFTP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sparkeh9/CoreFTP/statuses/{sha}","languages_url":"https://api.github.com/repos/sparkeh9/CoreFTP/languages","stargazers_url":"https://api.github.com/repos/sparkeh9/CoreFTP/stargazers","contributors_url":"https://api.github.com/repos/sparkeh9/CoreFTP/contributors","subscribers_url":"https://api.github.com/repos/sparkeh9/CoreFTP/subscribers","subscription_url":"https://api.github.com/repos/sparkeh9/CoreFTP/subscription","commits_url":"https://api.github.com/repos/sparkeh9/CoreFTP/commits{/sha}","git_commits_url":"https://api.github.com/repos/sparkeh9/CoreFTP/git/commits{/sha}","comments_url":"https://api.github.com/repos/sparkeh9/CoreFTP/comments{/number}","issue_comment_url":"https://api.github.com/repos/sparkeh9/CoreFTP/issues/comments{/number}","contents_url":"https://api.github.com/repos/sparkeh9/CoreFTP/contents/{+path}","compare_url":"https://api.github.com/repos/sparkeh9/CoreFTP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sparkeh9/CoreFTP/merges","archive_url":"https://api.github.com/repos/sparkeh9/CoreFTP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sparkeh9/CoreFTP/downloads","issues_url":"https://api.github.com/repos/sparkeh9/CoreFTP/issues{/number}","pulls_url":"https://api.github.com/repos/sparkeh9/CoreFTP/pulls{/number}","milestones_url":"https://api.github.com/repos/sparkeh9/CoreFTP/milestones{/number}","notifications_url":"https://api.github.com/repos/sparkeh9/CoreFTP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sparkeh9/CoreFTP/labels{/name}","releases_url":"https://api.github.com/repos/sparkeh9/CoreFTP/releases{/id}","deployments_url":"https://api.github.com/repos/sparkeh9/CoreFTP/deployments","created_at":"2016-09-16T18:24:40Z","updated_at":"2016-09-29T19:47:37Z","pushed_at":"2016-10-07T21:03:11Z","git_url":"git://github.com/sparkeh9/CoreFTP.git","ssh_url":"git@github.com:sparkeh9/CoreFTP.git","clone_url":"https://github.com/sparkeh9/CoreFTP.git","svn_url":"https://github.com/sparkeh9/CoreFTP","homepage":null,"size":353,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sparkeh9/CoreFTP/pulls/3"},"html":{"href":"https://github.com/sparkeh9/CoreFTP/pull/3"},"issue":{"href":"https://api.github.com/repos/sparkeh9/CoreFTP/issues/3"},"comments":{"href":"https://api.github.com/repos/sparkeh9/CoreFTP/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/sparkeh9/CoreFTP/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/sparkeh9/CoreFTP/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sparkeh9/CoreFTP/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/sparkeh9/CoreFTP/statuses/d4fd3760b6dd9788d9ca5267ba77dd88732069d3"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"sparkeh9","id":5622386,"avatar_url":"https://avatars.githubusercontent.com/u/5622386?v=3","gravatar_id":"","url":"https://api.github.com/users/sparkeh9","html_url":"https://github.com/sparkeh9","followers_url":"https://api.github.com/users/sparkeh9/followers","following_url":"https://api.github.com/users/sparkeh9/following{/other_user}","gists_url":"https://api.github.com/users/sparkeh9/gists{/gist_id}","starred_url":"https://api.github.com/users/sparkeh9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sparkeh9/subscriptions","organizations_url":"https://api.github.com/users/sparkeh9/orgs","repos_url":"https://api.github.com/users/sparkeh9/repos","events_url":"https://api.github.com/users/sparkeh9/events{/privacy}","received_events_url":"https://api.github.com/users/sparkeh9/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":40,"deletions":20,"changed_files":1}}
{"actor":{"display_login":"sparkeh9"}}