{"action":"created","comment":{"url":"https://api.github.com/repos/SzabolcsBorbely/practice/pulls/comments/66793729","id":66793729,"diff_hunk":"@@ -1,64 +1,56 @@\n package fizzbuzz;\n \n import java.util.List;\n+import java.util.Collections;\n import java.util.ArrayList;\n \n-public class FizzBuzz{\n+public class FizzBuzz {\n+    \n+    final String FIZZ = \"Fizz\";\n+    final String BUZZ = \"Buzz\";\n+    final String FIZZBUZZ = \"FizzBuzz\";\n+    \n+    public List<String> generateFizzBuzzSequence(String range_floor, String range_top) {\n+        if (rangeIsValid(range_floor, range_top)) {\n+            int floor = Integer.parseInt(range_floor);\n+            int top = Integer.parseInt(range_top);\n+            return generateSequence(floor, top);\n+        }\n+        return Collections.emptyList();\n+    }\n \n-\tpublic List<String> fizzBuzzSequence(String range_floor, String range_top){\n-\t\tif (rangeIsValid(range_floor, range_top)){\n-\t\t\tInteger floor = Integer.parseInt(range_floor);\n-\t\t\tInteger top = Integer.parseInt(range_top);\n-\t\t\treturn generateSequence(floor, top);\n-\t\t}\n-\t\t\treturn null;\n-\t}\n-\t\n-\tpublic boolean rangeIsValid(String range_floor, String range_top){\n-\t\ttry{\n-\t\t\tInteger floor = Integer.parseInt(range_floor);\n-\t\t\tInteger top = Integer.parseInt(range_top);\n-\t\t\tif (floor<0 || top<0)\n-\t\t\t\treturn false;\n-\t\t\tif (top<floor)\n-\t\t\t\treturn false;\n-\t\t}\n-\t\tcatch (NumberFormatException e){\n-\t\t\treturn false;\n-\t\t}\n-\t\treturn true;\n-\t}\n-\t\n-\tpublic List<String> generateSequence(Integer range_floor, Integer range_top){\n-\t\tList<String> result_list = new ArrayList<String>();\n-\t\tboolean divisible_by_3, divisible_by_5;\n+    public boolean rangeIsValid(String range_floor, String range_top) {\n+        try {\n+            int floor = Integer.parseInt(range_floor);\n+            int top = Integer.parseInt(range_top);\n+            if (floor <= 0 || top <= 0)","path":"src/main/java/fizzbuzz/FizzBuzz.java","position":54,"original_position":54,"commit_id":"d5326a8abfbaecfbd7d2a2d37c2bbbb36674639e","original_commit_id":"d5326a8abfbaecfbd7d2a2d37c2bbbb36674639e","user":{"login":"ZsoltFabok","id":310193,"avatar_url":"https://avatars.githubusercontent.com/u/310193?v=3","gravatar_id":"","url":"https://api.github.com/users/ZsoltFabok","html_url":"https://github.com/ZsoltFabok","followers_url":"https://api.github.com/users/ZsoltFabok/followers","following_url":"https://api.github.com/users/ZsoltFabok/following{/other_user}","gists_url":"https://api.github.com/users/ZsoltFabok/gists{/gist_id}","starred_url":"https://api.github.com/users/ZsoltFabok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZsoltFabok/subscriptions","organizations_url":"https://api.github.com/users/ZsoltFabok/orgs","repos_url":"https://api.github.com/users/ZsoltFabok/repos","events_url":"https://api.github.com/users/ZsoltFabok/events{/privacy}","received_events_url":"https://api.github.com/users/ZsoltFabok/received_events","type":"User","site_admin":false},"body":"missing {","created_at":"2016-06-13T13:47:59Z","updated_at":"2016-06-13T13:47:59Z","html_url":"https://github.com/SzabolcsBorbely/practice/pull/1#discussion_r66793729","pull_request_url":"https://api.github.com/repos/SzabolcsBorbely/practice/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/SzabolcsBorbely/practice/pulls/comments/66793729"},"html":{"href":"https://github.com/SzabolcsBorbely/practice/pull/1#discussion_r66793729"},"pull_request":{"href":"https://api.github.com/repos/SzabolcsBorbely/practice/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/SzabolcsBorbely/practice/pulls/1","id":73384082,"html_url":"https://github.com/SzabolcsBorbely/practice/pull/1","diff_url":"https://github.com/SzabolcsBorbely/practice/pull/1.diff","patch_url":"https://github.com/SzabolcsBorbely/practice/pull/1.patch","issue_url":"https://api.github.com/repos/SzabolcsBorbely/practice/issues/1","number":1,"state":"open","locked":false,"title":"Added a change to be able to ask for pull request.","user":{"login":"SzabolcsBorbely","id":19801272,"avatar_url":"https://avatars.githubusercontent.com/u/19801272?v=3","gravatar_id":"","url":"https://api.github.com/users/SzabolcsBorbely","html_url":"https://github.com/SzabolcsBorbely","followers_url":"https://api.github.com/users/SzabolcsBorbely/followers","following_url":"https://api.github.com/users/SzabolcsBorbely/following{/other_user}","gists_url":"https://api.github.com/users/SzabolcsBorbely/gists{/gist_id}","starred_url":"https://api.github.com/users/SzabolcsBorbely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SzabolcsBorbely/subscriptions","organizations_url":"https://api.github.com/users/SzabolcsBorbely/orgs","repos_url":"https://api.github.com/users/SzabolcsBorbely/repos","events_url":"https://api.github.com/users/SzabolcsBorbely/events{/privacy}","received_events_url":"https://api.github.com/users/SzabolcsBorbely/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-10T14:39:54Z","updated_at":"2016-06-13T13:47:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41d0871b53b1d13bab681895f0a75607f00a2e2c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SzabolcsBorbely/practice/pulls/1/commits","review_comments_url":"https://api.github.com/repos/SzabolcsBorbely/practice/pulls/1/comments","review_comment_url":"https://api.github.com/repos/SzabolcsBorbely/practice/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SzabolcsBorbely/practice/issues/1/comments","statuses_url":"https://api.github.com/repos/SzabolcsBorbely/practice/statuses/d5326a8abfbaecfbd7d2a2d37c2bbbb36674639e","head":{"label":"SzabolcsBorbely:fizzbuzz_version1","ref":"fizzbuzz_version1","sha":"d5326a8abfbaecfbd7d2a2d37c2bbbb36674639e","user":{"login":"SzabolcsBorbely","id":19801272,"avatar_url":"https://avatars.githubusercontent.com/u/19801272?v=3","gravatar_id":"","url":"https://api.github.com/users/SzabolcsBorbely","html_url":"https://github.com/SzabolcsBorbely","followers_url":"https://api.github.com/users/SzabolcsBorbely/followers","following_url":"https://api.github.com/users/SzabolcsBorbely/following{/other_user}","gists_url":"https://api.github.com/users/SzabolcsBorbely/gists{/gist_id}","starred_url":"https://api.github.com/users/SzabolcsBorbely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SzabolcsBorbely/subscriptions","organizations_url":"https://api.github.com/users/SzabolcsBorbely/orgs","repos_url":"https://api.github.com/users/SzabolcsBorbely/repos","events_url":"https://api.github.com/users/SzabolcsBorbely/events{/privacy}","received_events_url":"https://api.github.com/users/SzabolcsBorbely/received_events","type":"User","site_admin":false},"repo":{"id":60621983,"name":"practice","full_name":"SzabolcsBorbely/practice","owner":{"login":"SzabolcsBorbely","id":19801272,"avatar_url":"https://avatars.githubusercontent.com/u/19801272?v=3","gravatar_id":"","url":"https://api.github.com/users/SzabolcsBorbely","html_url":"https://github.com/SzabolcsBorbely","followers_url":"https://api.github.com/users/SzabolcsBorbely/followers","following_url":"https://api.github.com/users/SzabolcsBorbely/following{/other_user}","gists_url":"https://api.github.com/users/SzabolcsBorbely/gists{/gist_id}","starred_url":"https://api.github.com/users/SzabolcsBorbely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SzabolcsBorbely/subscriptions","organizations_url":"https://api.github.com/users/SzabolcsBorbely/orgs","repos_url":"https://api.github.com/users/SzabolcsBorbely/repos","events_url":"https://api.github.com/users/SzabolcsBorbely/events{/privacy}","received_events_url":"https://api.github.com/users/SzabolcsBorbely/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SzabolcsBorbely/practice","description":"","fork":false,"url":"https://api.github.com/repos/SzabolcsBorbely/practice","forks_url":"https://api.github.com/repos/SzabolcsBorbely/practice/forks","keys_url":"https://api.github.com/repos/SzabolcsBorbely/practice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SzabolcsBorbely/practice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SzabolcsBorbely/practice/teams","hooks_url":"https://api.github.com/repos/SzabolcsBorbely/practice/hooks","issue_events_url":"https://api.github.com/repos/SzabolcsBorbely/practice/issues/events{/number}","events_url":"https://api.github.com/repos/SzabolcsBorbely/practice/events","assignees_url":"https://api.github.com/repos/SzabolcsBorbely/practice/assignees{/user}","branches_url":"https://api.github.com/repos/SzabolcsBorbely/practice/branches{/branch}","tags_url":"https://api.github.com/repos/SzabolcsBorbely/practice/tags","blobs_url":"https://api.github.com/repos/SzabolcsBorbely/practice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SzabolcsBorbely/practice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SzabolcsBorbely/practice/git/refs{/sha}","trees_url":"https://api.github.com/repos/SzabolcsBorbely/practice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SzabolcsBorbely/practice/statuses/{sha}","languages_url":"https://api.github.com/repos/SzabolcsBorbely/practice/languages","stargazers_url":"https://api.github.com/repos/SzabolcsBorbely/practice/stargazers","contributors_url":"https://api.github.com/repos/SzabolcsBorbely/practice/contributors","subscribers_url":"https://api.github.com/repos/SzabolcsBorbely/practice/subscribers","subscription_url":"https://api.github.com/repos/SzabolcsBorbely/practice/subscription","commits_url":"https://api.github.com/repos/SzabolcsBorbely/practice/commits{/sha}","git_commits_url":"https://api.github.com/repos/SzabolcsBorbely/practice/git/commits{/sha}","comments_url":"https://api.github.com/repos/SzabolcsBorbely/practice/comments{/number}","issue_comment_url":"https://api.github.com/repos/SzabolcsBorbely/practice/issues/comments{/number}","contents_url":"https://api.github.com/repos/SzabolcsBorbely/practice/contents/{+path}","compare_url":"https://api.github.com/repos/SzabolcsBorbely/practice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SzabolcsBorbely/practice/merges","archive_url":"https://api.github.com/repos/SzabolcsBorbely/practice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SzabolcsBorbely/practice/downloads","issues_url":"https://api.github.com/repos/SzabolcsBorbely/practice/issues{/number}","pulls_url":"https://api.github.com/repos/SzabolcsBorbely/practice/pulls{/number}","milestones_url":"https://api.github.com/repos/SzabolcsBorbely/practice/milestones{/number}","notifications_url":"https://api.github.com/repos/SzabolcsBorbely/practice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SzabolcsBorbely/practice/labels{/name}","releases_url":"https://api.github.com/repos/SzabolcsBorbely/practice/releases{/id}","deployments_url":"https://api.github.com/repos/SzabolcsBorbely/practice/deployments","created_at":"2016-06-07T14:54:45Z","updated_at":"2016-06-08T13:50:48Z","pushed_at":"2016-06-13T10:44:12Z","git_url":"git://github.com/SzabolcsBorbely/practice.git","ssh_url":"git@github.com:SzabolcsBorbely/practice.git","clone_url":"https://github.com/SzabolcsBorbely/practice.git","svn_url":"https://github.com/SzabolcsBorbely/practice","homepage":null,"size":7,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"SzabolcsBorbely:master","ref":"master","sha":"e23370728d221d03d592652aef1b2adfbe0977f4","user":{"login":"SzabolcsBorbely","id":19801272,"avatar_url":"https://avatars.githubusercontent.com/u/19801272?v=3","gravatar_id":"","url":"https://api.github.com/users/SzabolcsBorbely","html_url":"https://github.com/SzabolcsBorbely","followers_url":"https://api.github.com/users/SzabolcsBorbely/followers","following_url":"https://api.github.com/users/SzabolcsBorbely/following{/other_user}","gists_url":"https://api.github.com/users/SzabolcsBorbely/gists{/gist_id}","starred_url":"https://api.github.com/users/SzabolcsBorbely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SzabolcsBorbely/subscriptions","organizations_url":"https://api.github.com/users/SzabolcsBorbely/orgs","repos_url":"https://api.github.com/users/SzabolcsBorbely/repos","events_url":"https://api.github.com/users/SzabolcsBorbely/events{/privacy}","received_events_url":"https://api.github.com/users/SzabolcsBorbely/received_events","type":"User","site_admin":false},"repo":{"id":60621983,"name":"practice","full_name":"SzabolcsBorbely/practice","owner":{"login":"SzabolcsBorbely","id":19801272,"avatar_url":"https://avatars.githubusercontent.com/u/19801272?v=3","gravatar_id":"","url":"https://api.github.com/users/SzabolcsBorbely","html_url":"https://github.com/SzabolcsBorbely","followers_url":"https://api.github.com/users/SzabolcsBorbely/followers","following_url":"https://api.github.com/users/SzabolcsBorbely/following{/other_user}","gists_url":"https://api.github.com/users/SzabolcsBorbely/gists{/gist_id}","starred_url":"https://api.github.com/users/SzabolcsBorbely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SzabolcsBorbely/subscriptions","organizations_url":"https://api.github.com/users/SzabolcsBorbely/orgs","repos_url":"https://api.github.com/users/SzabolcsBorbely/repos","events_url":"https://api.github.com/users/SzabolcsBorbely/events{/privacy}","received_events_url":"https://api.github.com/users/SzabolcsBorbely/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SzabolcsBorbely/practice","description":"","fork":false,"url":"https://api.github.com/repos/SzabolcsBorbely/practice","forks_url":"https://api.github.com/repos/SzabolcsBorbely/practice/forks","keys_url":"https://api.github.com/repos/SzabolcsBorbely/practice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SzabolcsBorbely/practice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SzabolcsBorbely/practice/teams","hooks_url":"https://api.github.com/repos/SzabolcsBorbely/practice/hooks","issue_events_url":"https://api.github.com/repos/SzabolcsBorbely/practice/issues/events{/number}","events_url":"https://api.github.com/repos/SzabolcsBorbely/practice/events","assignees_url":"https://api.github.com/repos/SzabolcsBorbely/practice/assignees{/user}","branches_url":"https://api.github.com/repos/SzabolcsBorbely/practice/branches{/branch}","tags_url":"https://api.github.com/repos/SzabolcsBorbely/practice/tags","blobs_url":"https://api.github.com/repos/SzabolcsBorbely/practice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SzabolcsBorbely/practice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SzabolcsBorbely/practice/git/refs{/sha}","trees_url":"https://api.github.com/repos/SzabolcsBorbely/practice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SzabolcsBorbely/practice/statuses/{sha}","languages_url":"https://api.github.com/repos/SzabolcsBorbely/practice/languages","stargazers_url":"https://api.github.com/repos/SzabolcsBorbely/practice/stargazers","contributors_url":"https://api.github.com/repos/SzabolcsBorbely/practice/contributors","subscribers_url":"https://api.github.com/repos/SzabolcsBorbely/practice/subscribers","subscription_url":"https://api.github.com/repos/SzabolcsBorbely/practice/subscription","commits_url":"https://api.github.com/repos/SzabolcsBorbely/practice/commits{/sha}","git_commits_url":"https://api.github.com/repos/SzabolcsBorbely/practice/git/commits{/sha}","comments_url":"https://api.github.com/repos/SzabolcsBorbely/practice/comments{/number}","issue_comment_url":"https://api.github.com/repos/SzabolcsBorbely/practice/issues/comments{/number}","contents_url":"https://api.github.com/repos/SzabolcsBorbely/practice/contents/{+path}","compare_url":"https://api.github.com/repos/SzabolcsBorbely/practice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SzabolcsBorbely/practice/merges","archive_url":"https://api.github.com/repos/SzabolcsBorbely/practice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SzabolcsBorbely/practice/downloads","issues_url":"https://api.github.com/repos/SzabolcsBorbely/practice/issues{/number}","pulls_url":"https://api.github.com/repos/SzabolcsBorbely/practice/pulls{/number}","milestones_url":"https://api.github.com/repos/SzabolcsBorbely/practice/milestones{/number}","notifications_url":"https://api.github.com/repos/SzabolcsBorbely/practice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SzabolcsBorbely/practice/labels{/name}","releases_url":"https://api.github.com/repos/SzabolcsBorbely/practice/releases{/id}","deployments_url":"https://api.github.com/repos/SzabolcsBorbely/practice/deployments","created_at":"2016-06-07T14:54:45Z","updated_at":"2016-06-08T13:50:48Z","pushed_at":"2016-06-13T10:44:12Z","git_url":"git://github.com/SzabolcsBorbely/practice.git","ssh_url":"git@github.com:SzabolcsBorbely/practice.git","clone_url":"https://github.com/SzabolcsBorbely/practice.git","svn_url":"https://github.com/SzabolcsBorbely/practice","homepage":null,"size":7,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SzabolcsBorbely/practice/pulls/1"},"html":{"href":"https://github.com/SzabolcsBorbely/practice/pull/1"},"issue":{"href":"https://api.github.com/repos/SzabolcsBorbely/practice/issues/1"},"comments":{"href":"https://api.github.com/repos/SzabolcsBorbely/practice/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/SzabolcsBorbely/practice/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/SzabolcsBorbely/practice/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SzabolcsBorbely/practice/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/SzabolcsBorbely/practice/statuses/d5326a8abfbaecfbd7d2a2d37c2bbbb36674639e"}}}}
{"actor":{"display_login":"ZsoltFabok"}}