{"action":"created","issue":{"url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2463","repository_url":"https://api.github.com/repos/MovingBlocks/Terasology","labels_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2463/labels{/name}","comments_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2463/comments","events_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2463/events","html_url":"https://github.com/MovingBlocks/Terasology/pull/2463","id":174422131,"number":2463,"title":"whitelist a handful of rendering-related engine and library classes","user":{"login":"kaen","id":8729027,"avatar_url":"https://avatars.githubusercontent.com/u/8729027?v=3","gravatar_id":"","url":"https://api.github.com/users/kaen","html_url":"https://github.com/kaen","followers_url":"https://api.github.com/users/kaen/followers","following_url":"https://api.github.com/users/kaen/following{/other_user}","gists_url":"https://api.github.com/users/kaen/gists{/gist_id}","starred_url":"https://api.github.com/users/kaen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaen/subscriptions","organizations_url":"https://api.github.com/users/kaen/orgs","repos_url":"https://api.github.com/users/kaen/repos","events_url":"https://api.github.com/users/kaen/events{/privacy}","received_events_url":"https://api.github.com/users/kaen/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/MovingBlocks/Terasology/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-01T02:26:08Z","updated_at":"2016-09-01T05:47:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2463","html_url":"https://github.com/MovingBlocks/Terasology/pull/2463","diff_url":"https://github.com/MovingBlocks/Terasology/pull/2463.diff","patch_url":"https://github.com/MovingBlocks/Terasology/pull/2463.patch"},"body":"### Contains\r\n\r\nWhitelist entries for low-level rendering classes like `org.lwjgl.opengl.GL11`\r\n\r\n### How to test\r\n\r\nJust try to access one of the listed classes :)\r\n\r\nMy WIP HealthBars module requires this patch to run: https://github.com/kaen/HealthBars/blob/master/src/main/java/org/terasology/healthbars/HealthBarRenderSystem.java#L194\r\n\r\nI looked for any previous discussion of whitelisting these classes and couldn't find any, hopefully there's not an obvious security-related reason for excluding them."},"comment":{"url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/comments/243982170","html_url":"https://github.com/MovingBlocks/Terasology/pull/2463#issuecomment-243982170","issue_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2463","id":243982170,"user":{"login":"Cervator","id":1063833,"avatar_url":"https://avatars.githubusercontent.com/u/1063833?v=3","gravatar_id":"","url":"https://api.github.com/users/Cervator","html_url":"https://github.com/Cervator","followers_url":"https://api.github.com/users/Cervator/followers","following_url":"https://api.github.com/users/Cervator/following{/other_user}","gists_url":"https://api.github.com/users/Cervator/gists{/gist_id}","starred_url":"https://api.github.com/users/Cervator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cervator/subscriptions","organizations_url":"https://api.github.com/users/Cervator/orgs","repos_url":"https://api.github.com/users/Cervator/repos","events_url":"https://api.github.com/users/Cervator/events{/privacy}","received_events_url":"https://api.github.com/users/Cervator/received_events","type":"User","site_admin":false},"created_at":"2016-09-01T05:47:05Z","updated_at":"2016-09-01T05:47:05Z","body":"Cool to see the health bar module :-)\r\n\r\nGenerally we restrict modules from direct access to rendering stuff (think visual cheats or forced crashes from invalid rendering). It may be better to include the health bar rendering directly as engine classes then allow modules to hook them up. How does that sound?"}}
{"actor":{"display_login":"Cervator"}}