{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/68236141","id":68236141,"diff_hunk":"@@ -1452,13 +1472,13 @@ function main() {\n \n     local code\n     if run $dir \"$@\" ; then\n-        code=0\n+        teardown $dir || return 1\n+        return 0\n     else\n         display_logs $dir\n-        code=1\n+        teardown_error $dir\n+        return 1\n     fi\n-    teardown $dir || return 1","path":"qa/workunits/ceph-helpers.sh","position":82,"original_position":82,"commit_id":"657648eeabf7d6371fc17896f75299465a730a98","original_commit_id":"ed009f3826b9a74914e1bd738bf79367ba4bb3c0","user":{"login":"wjwithagen","id":16081914,"avatar_url":"https://avatars.githubusercontent.com/u/16081914?v=3","gravatar_id":"","url":"https://api.github.com/users/wjwithagen","html_url":"https://github.com/wjwithagen","followers_url":"https://api.github.com/users/wjwithagen/followers","following_url":"https://api.github.com/users/wjwithagen/following{/other_user}","gists_url":"https://api.github.com/users/wjwithagen/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwithagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwithagen/subscriptions","organizations_url":"https://api.github.com/users/wjwithagen/orgs","repos_url":"https://api.github.com/users/wjwithagen/repos","events_url":"https://api.github.com/users/wjwithagen/events{/privacy}","received_events_url":"https://api.github.com/users/wjwithagen/received_events","type":"User","site_admin":false},"body":"@tchaikov \r\nIt is not my intention to change any of the behaviour of the tests.\r\nOther than:\r\n  - Fix FreeBSD issues\r\n  - Keep data around when something fails, so one can look at the logfiles\r\nSo if it does change standard behaviour on Linux, when tests go as planned, that should be a mistake.\r\n\r\nBut I'm fine with taking this change to a next set of commits for the next pull.\r\nNote that I talked about it with a few people at Ceph day, and it would be nice if tests also start taking care of situations where things actually fail, and people doing testing/debugging/porting would have easy access to more information.","created_at":"2016-06-23T13:43:29Z","updated_at":"2016-06-23T13:43:29Z","html_url":"https://github.com/ceph/ceph/pull/9504#discussion_r68236141","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/9504","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/68236141"},"html":{"href":"https://github.com/ceph/ceph/pull/9504#discussion_r68236141"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/9504"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/9504","id":72642778,"html_url":"https://github.com/ceph/ceph/pull/9504","diff_url":"https://github.com/ceph/ceph/pull/9504.diff","patch_url":"https://github.com/ceph/ceph/pull/9504.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/9504","number":9504,"state":"open","locked":false,"title":"Unittesting: freebsd changes, part 3","user":{"login":"wjwithagen","id":16081914,"avatar_url":"https://avatars.githubusercontent.com/u/16081914?v=3","gravatar_id":"","url":"https://api.github.com/users/wjwithagen","html_url":"https://github.com/wjwithagen","followers_url":"https://api.github.com/users/wjwithagen/followers","following_url":"https://api.github.com/users/wjwithagen/following{/other_user}","gists_url":"https://api.github.com/users/wjwithagen/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwithagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwithagen/subscriptions","organizations_url":"https://api.github.com/users/wjwithagen/orgs","repos_url":"https://api.github.com/users/wjwithagen/repos","events_url":"https://api.github.com/users/wjwithagen/events{/privacy}","received_events_url":"https://api.github.com/users/wjwithagen/received_events","type":"User","site_admin":false},"body":"This requires Clang to be at least 3.7\r\nIt compiles all ceph code (expect the ones excluded in autogen_freebsd.sh)\r\nIt compiles all tests\r\n\r\nTests will run, but not all complete successfully,\r\n  Currently the only one failing is osd-markup.sh\r\n\r\nOther tests have been execluded from testing, see README.FreeBSD for that\r\n\r\nSigned-off-by: Willem Jan Withagen <wjw@digiware.nl>","created_at":"2016-06-05T22:38:09Z","updated_at":"2016-06-23T13:43:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1acb5d21da7123f0a9a7149230c81842b270660","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/9504/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/9504/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/9504/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/657648eeabf7d6371fc17896f75299465a730a98","head":{"label":"wjwithagen:wip-wjw-freebsd-tests-2","ref":"wip-wjw-freebsd-tests-2","sha":"657648eeabf7d6371fc17896f75299465a730a98","user":{"login":"wjwithagen","id":16081914,"avatar_url":"https://avatars.githubusercontent.com/u/16081914?v=3","gravatar_id":"","url":"https://api.github.com/users/wjwithagen","html_url":"https://github.com/wjwithagen","followers_url":"https://api.github.com/users/wjwithagen/followers","following_url":"https://api.github.com/users/wjwithagen/following{/other_user}","gists_url":"https://api.github.com/users/wjwithagen/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwithagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwithagen/subscriptions","organizations_url":"https://api.github.com/users/wjwithagen/orgs","repos_url":"https://api.github.com/users/wjwithagen/repos","events_url":"https://api.github.com/users/wjwithagen/events{/privacy}","received_events_url":"https://api.github.com/users/wjwithagen/received_events","type":"User","site_admin":false},"repo":{"id":50789401,"name":"ceph","full_name":"wjwithagen/ceph","owner":{"login":"wjwithagen","id":16081914,"avatar_url":"https://avatars.githubusercontent.com/u/16081914?v=3","gravatar_id":"","url":"https://api.github.com/users/wjwithagen","html_url":"https://github.com/wjwithagen","followers_url":"https://api.github.com/users/wjwithagen/followers","following_url":"https://api.github.com/users/wjwithagen/following{/other_user}","gists_url":"https://api.github.com/users/wjwithagen/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwithagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwithagen/subscriptions","organizations_url":"https://api.github.com/users/wjwithagen/orgs","repos_url":"https://api.github.com/users/wjwithagen/repos","events_url":"https://api.github.com/users/wjwithagen/events{/privacy}","received_events_url":"https://api.github.com/users/wjwithagen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wjwithagen/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/wjwithagen/ceph","forks_url":"https://api.github.com/repos/wjwithagen/ceph/forks","keys_url":"https://api.github.com/repos/wjwithagen/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wjwithagen/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wjwithagen/ceph/teams","hooks_url":"https://api.github.com/repos/wjwithagen/ceph/hooks","issue_events_url":"https://api.github.com/repos/wjwithagen/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/wjwithagen/ceph/events","assignees_url":"https://api.github.com/repos/wjwithagen/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/wjwithagen/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/wjwithagen/ceph/tags","blobs_url":"https://api.github.com/repos/wjwithagen/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wjwithagen/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wjwithagen/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/wjwithagen/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wjwithagen/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/wjwithagen/ceph/languages","stargazers_url":"https://api.github.com/repos/wjwithagen/ceph/stargazers","contributors_url":"https://api.github.com/repos/wjwithagen/ceph/contributors","subscribers_url":"https://api.github.com/repos/wjwithagen/ceph/subscribers","subscription_url":"https://api.github.com/repos/wjwithagen/ceph/subscription","commits_url":"https://api.github.com/repos/wjwithagen/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/wjwithagen/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/wjwithagen/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/wjwithagen/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/wjwithagen/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/wjwithagen/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wjwithagen/ceph/merges","archive_url":"https://api.github.com/repos/wjwithagen/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wjwithagen/ceph/downloads","issues_url":"https://api.github.com/repos/wjwithagen/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/wjwithagen/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/wjwithagen/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/wjwithagen/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wjwithagen/ceph/labels{/name}","releases_url":"https://api.github.com/repos/wjwithagen/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/wjwithagen/ceph/deployments","created_at":"2016-01-31T18:48:17Z","updated_at":"2016-06-10T05:43:45Z","pushed_at":"2016-06-19T11:58:13Z","git_url":"git://github.com/wjwithagen/ceph.git","ssh_url":"git@github.com:wjwithagen/ceph.git","clone_url":"https://github.com/wjwithagen/ceph.git","svn_url":"https://github.com/wjwithagen/ceph","homepage":"http://ceph.com","size":166620,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"dbb0a59c88708c532aced95909d3dca795bdfd7a","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2016-06-23T13:42:12Z","pushed_at":"2016-06-23T13:40:42Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":222581,"stargazers_count":2252,"watchers_count":2252,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1346,"mirror_url":null,"open_issues_count":419,"forks":1346,"open_issues":419,"watchers":2252,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/9504"},"html":{"href":"https://github.com/ceph/ceph/pull/9504"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/9504"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/9504/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/9504/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/9504/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/657648eeabf7d6371fc17896f75299465a730a98"}}}}
{"actor":{"display_login":"wjwithagen"}}