{"action":"created","issue":{"url":"https://api.github.com/repos/scp-fs2open/fs2open.github.com/issues/146","repository_url":"https://api.github.com/repos/scp-fs2open/fs2open.github.com","labels_url":"https://api.github.com/repos/scp-fs2open/fs2open.github.com/issues/146/labels{/name}","comments_url":"https://api.github.com/repos/scp-fs2open/fs2open.github.com/issues/146/comments","events_url":"https://api.github.com/repos/scp-fs2open/fs2open.github.com/issues/146/events","html_url":"https://github.com/scp-fs2open/fs2open.github.com/issues/146","id":82464885,"number":146,"title":"Setting standalone server title that is too long crashes standalone server, sort of","user":{"login":"chief1983","id":145825,"avatar_url":"https://avatars.githubusercontent.com/u/145825?v=3","gravatar_id":"","url":"https://api.github.com/users/chief1983","html_url":"https://github.com/chief1983","followers_url":"https://api.github.com/users/chief1983/followers","following_url":"https://api.github.com/users/chief1983/following{/other_user}","gists_url":"https://api.github.com/users/chief1983/gists{/gist_id}","starred_url":"https://api.github.com/users/chief1983/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chief1983/subscriptions","organizations_url":"https://api.github.com/users/chief1983/orgs","repos_url":"https://api.github.com/users/chief1983/repos","events_url":"https://api.github.com/users/chief1983/events{/privacy}","received_events_url":"https://api.github.com/users/chief1983/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/scp-fs2open/fs2open.github.com/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/scp-fs2open/fs2open.github.com/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":21,"created_at":"2015-05-29T15:05:38Z","updated_at":"2016-02-29T06:57:03Z","closed_at":null,"body":"Tried to set an apparently too long title in the standalone, I got this in the standalone output (not in the log file, right on the console):\r\n\r\nERROR: \"ERANGE: String error. Please Report. Trying to put into 33 byte buffer: SCP Test Server 20150517 (Retail)\" at network/stand_gui-unix.cpp:408\r\n\r\nThe program never exited, but the WebUI stopped responding and it disappeared from FS2NetD shortly after, without having updated the title.  The engine side should probably handle an attempt to set a long title more gracefully, and the WebUI should prevent attempting to set one too long.  Whether that should be hardcoded or the engine can feed the UI with the limits dynamically should be investigated."},"comment":{"url":"https://api.github.com/repos/scp-fs2open/fs2open.github.com/issues/comments/190069532","html_url":"https://github.com/scp-fs2open/fs2open.github.com/issues/146#issuecomment-190069532","issue_url":"https://api.github.com/repos/scp-fs2open/fs2open.github.com/issues/146","id":190069532,"user":{"login":"jg18","id":6183333,"avatar_url":"https://avatars.githubusercontent.com/u/6183333?v=3","gravatar_id":"","url":"https://api.github.com/users/jg18","html_url":"https://github.com/jg18","followers_url":"https://api.github.com/users/jg18/followers","following_url":"https://api.github.com/users/jg18/following{/other_user}","gists_url":"https://api.github.com/users/jg18/gists{/gist_id}","starred_url":"https://api.github.com/users/jg18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jg18/subscriptions","organizations_url":"https://api.github.com/users/jg18/orgs","repos_url":"https://api.github.com/users/jg18/repos","events_url":"https://api.github.com/users/jg18/events{/privacy}","received_events_url":"https://api.github.com/users/jg18/received_events","type":"User","site_admin":false},"created_at":"2016-02-29T06:57:03Z","updated_at":"2016-02-29T06:57:03Z","body":"Also, the issue reported here likely also affects game server passwords, which are limited in multi.h (MAX_PASSWD_LEN) to 16 characters. Not sure if setting it too long will cause a crash.\r\n\r\nIt's easy enough in the Unix standalone GUI code to truncate server names/passwords to the appropriate max length when passing the strings along to the engine. However, there's a serious UX problem when it comes to the password. If the standalone host enters a password logner than 16 characters and a truncated version is used as the real password, then the real password will be different from what the standalone user sees in the standalone GUI. I am looking into ways to enforce the length restriction for server names/passwords in the Unix standalone GUI."}}