{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/CORS/pulls/comments/92673718","pull_request_review_id":13193831,"id":92673718,"diff_hunk":"@@ -881,6 +881,24 @@ public void ApplyResult_PreflightMaxAge_MaxAgeHeaderAdded()\n             Assert.Equal(\"30\", httpContext.Response.Headers[\"Access-Control-Max-Age\"]);\n         }\n \n+        [Fact]\n+        public void EvaluatePolicy_MultiOriginsPolicy_ReturnsVaryByOriginHeader()","path":"test/Microsoft.AspNetCore.Cors.Test/CorsServiceTests.cs","position":5,"original_position":5,"commit_id":"c0a77c3e39e7306d1df190cb5bc9ac64d24ce077","original_commit_id":"c0a77c3e39e7306d1df190cb5bc9ac64d24ce077","user":{"login":"kichalla","id":6559784,"avatar_url":"https://avatars.githubusercontent.com/u/6559784?v=3","gravatar_id":"","url":"https://api.github.com/users/kichalla","html_url":"https://github.com/kichalla","followers_url":"https://api.github.com/users/kichalla/followers","following_url":"https://api.github.com/users/kichalla/following{/other_user}","gists_url":"https://api.github.com/users/kichalla/gists{/gist_id}","starred_url":"https://api.github.com/users/kichalla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kichalla/subscriptions","organizations_url":"https://api.github.com/users/kichalla/orgs","repos_url":"https://api.github.com/users/kichalla/repos","events_url":"https://api.github.com/users/kichalla/events{/privacy}","received_events_url":"https://api.github.com/users/kichalla/received_events","type":"User","site_admin":false},"body":"Update this test to have variations: one origin, multiple origins.\r\nAdd a negative test case where multiple origins and request from non-allowable origin doesn't have origin header","created_at":"2016-12-15T18:48:27Z","updated_at":"2016-12-15T18:48:27Z","html_url":"https://github.com/aspnet/CORS/pull/84#discussion_r92673718","pull_request_url":"https://api.github.com/repos/aspnet/CORS/pulls/84","_links":{"self":{"href":"https://api.github.com/repos/aspnet/CORS/pulls/comments/92673718"},"html":{"href":"https://github.com/aspnet/CORS/pull/84#discussion_r92673718"},"pull_request":{"href":"https://api.github.com/repos/aspnet/CORS/pulls/84"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/CORS/pulls/84","id":81629779,"html_url":"https://github.com/aspnet/CORS/pull/84","diff_url":"https://github.com/aspnet/CORS/pull/84.diff","patch_url":"https://github.com/aspnet/CORS/pull/84.patch","issue_url":"https://api.github.com/repos/aspnet/CORS/issues/84","number":84,"state":"open","locked":false,"title":"Include VaryByOrigin when there are multiple Origins configured","user":{"login":"michielpost","id":1315216,"avatar_url":"https://avatars.githubusercontent.com/u/1315216?v=3","gravatar_id":"","url":"https://api.github.com/users/michielpost","html_url":"https://github.com/michielpost","followers_url":"https://api.github.com/users/michielpost/followers","following_url":"https://api.github.com/users/michielpost/following{/other_user}","gists_url":"https://api.github.com/users/michielpost/gists{/gist_id}","starred_url":"https://api.github.com/users/michielpost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michielpost/subscriptions","organizations_url":"https://api.github.com/users/michielpost/orgs","repos_url":"https://api.github.com/users/michielpost/repos","events_url":"https://api.github.com/users/michielpost/events{/privacy}","received_events_url":"https://api.github.com/users/michielpost/received_events","type":"User","site_admin":false},"body":"The Vary: Origin header is currently only returned when AllowAnyOrigin and SupportsCredentials is true\nWhen AllowAnyOrigin is not set and there is a origin match for the request, the AllowedOrigin is returned but without the VaryByOrigin header.\nThat's not a problem when only 1 Origin is configured, but when there are multiple Origins configured, the VaryByOrigin should also be returned.\n","created_at":"2016-08-17T11:57:43Z","updated_at":"2016-12-15T18:48:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63fa9fca150a583806e83643693c51ca707243b3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/CORS/pulls/84/commits","review_comments_url":"https://api.github.com/repos/aspnet/CORS/pulls/84/comments","review_comment_url":"https://api.github.com/repos/aspnet/CORS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/CORS/issues/84/comments","statuses_url":"https://api.github.com/repos/aspnet/CORS/statuses/c0a77c3e39e7306d1df190cb5bc9ac64d24ce077","head":{"label":"michielpost:dev","ref":"dev","sha":"c0a77c3e39e7306d1df190cb5bc9ac64d24ce077","user":{"login":"michielpost","id":1315216,"avatar_url":"https://avatars.githubusercontent.com/u/1315216?v=3","gravatar_id":"","url":"https://api.github.com/users/michielpost","html_url":"https://github.com/michielpost","followers_url":"https://api.github.com/users/michielpost/followers","following_url":"https://api.github.com/users/michielpost/following{/other_user}","gists_url":"https://api.github.com/users/michielpost/gists{/gist_id}","starred_url":"https://api.github.com/users/michielpost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michielpost/subscriptions","organizations_url":"https://api.github.com/users/michielpost/orgs","repos_url":"https://api.github.com/users/michielpost/repos","events_url":"https://api.github.com/users/michielpost/events{/privacy}","received_events_url":"https://api.github.com/users/michielpost/received_events","type":"User","site_admin":false},"repo":{"id":65902814,"name":"CORS","full_name":"michielpost/CORS","owner":{"login":"michielpost","id":1315216,"avatar_url":"https://avatars.githubusercontent.com/u/1315216?v=3","gravatar_id":"","url":"https://api.github.com/users/michielpost","html_url":"https://github.com/michielpost","followers_url":"https://api.github.com/users/michielpost/followers","following_url":"https://api.github.com/users/michielpost/following{/other_user}","gists_url":"https://api.github.com/users/michielpost/gists{/gist_id}","starred_url":"https://api.github.com/users/michielpost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michielpost/subscriptions","organizations_url":"https://api.github.com/users/michielpost/orgs","repos_url":"https://api.github.com/users/michielpost/repos","events_url":"https://api.github.com/users/michielpost/events{/privacy}","received_events_url":"https://api.github.com/users/michielpost/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/michielpost/CORS","description":"Implementations of common CORS policy and CORS middleware","fork":true,"url":"https://api.github.com/repos/michielpost/CORS","forks_url":"https://api.github.com/repos/michielpost/CORS/forks","keys_url":"https://api.github.com/repos/michielpost/CORS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/michielpost/CORS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/michielpost/CORS/teams","hooks_url":"https://api.github.com/repos/michielpost/CORS/hooks","issue_events_url":"https://api.github.com/repos/michielpost/CORS/issues/events{/number}","events_url":"https://api.github.com/repos/michielpost/CORS/events","assignees_url":"https://api.github.com/repos/michielpost/CORS/assignees{/user}","branches_url":"https://api.github.com/repos/michielpost/CORS/branches{/branch}","tags_url":"https://api.github.com/repos/michielpost/CORS/tags","blobs_url":"https://api.github.com/repos/michielpost/CORS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/michielpost/CORS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/michielpost/CORS/git/refs{/sha}","trees_url":"https://api.github.com/repos/michielpost/CORS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/michielpost/CORS/statuses/{sha}","languages_url":"https://api.github.com/repos/michielpost/CORS/languages","stargazers_url":"https://api.github.com/repos/michielpost/CORS/stargazers","contributors_url":"https://api.github.com/repos/michielpost/CORS/contributors","subscribers_url":"https://api.github.com/repos/michielpost/CORS/subscribers","subscription_url":"https://api.github.com/repos/michielpost/CORS/subscription","commits_url":"https://api.github.com/repos/michielpost/CORS/commits{/sha}","git_commits_url":"https://api.github.com/repos/michielpost/CORS/git/commits{/sha}","comments_url":"https://api.github.com/repos/michielpost/CORS/comments{/number}","issue_comment_url":"https://api.github.com/repos/michielpost/CORS/issues/comments{/number}","contents_url":"https://api.github.com/repos/michielpost/CORS/contents/{+path}","compare_url":"https://api.github.com/repos/michielpost/CORS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/michielpost/CORS/merges","archive_url":"https://api.github.com/repos/michielpost/CORS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/michielpost/CORS/downloads","issues_url":"https://api.github.com/repos/michielpost/CORS/issues{/number}","pulls_url":"https://api.github.com/repos/michielpost/CORS/pulls{/number}","milestones_url":"https://api.github.com/repos/michielpost/CORS/milestones{/number}","notifications_url":"https://api.github.com/repos/michielpost/CORS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/michielpost/CORS/labels{/name}","releases_url":"https://api.github.com/repos/michielpost/CORS/releases{/id}","deployments_url":"https://api.github.com/repos/michielpost/CORS/deployments","created_at":"2016-08-17T11:39:28Z","updated_at":"2016-08-17T11:39:29Z","pushed_at":"2016-08-17T11:53:16Z","git_url":"git://github.com/michielpost/CORS.git","ssh_url":"git@github.com:michielpost/CORS.git","clone_url":"https://github.com/michielpost/CORS.git","svn_url":"https://github.com/michielpost/CORS","homepage":null,"size":497,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"66abd74142f05b6605d2407cbb98f2e05682fc74","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30898960,"name":"CORS","full_name":"aspnet/CORS","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/CORS","description":"Implementations of common CORS policy and CORS middleware","fork":false,"url":"https://api.github.com/repos/aspnet/CORS","forks_url":"https://api.github.com/repos/aspnet/CORS/forks","keys_url":"https://api.github.com/repos/aspnet/CORS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/CORS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/CORS/teams","hooks_url":"https://api.github.com/repos/aspnet/CORS/hooks","issue_events_url":"https://api.github.com/repos/aspnet/CORS/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/CORS/events","assignees_url":"https://api.github.com/repos/aspnet/CORS/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/CORS/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/CORS/tags","blobs_url":"https://api.github.com/repos/aspnet/CORS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/CORS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/CORS/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/CORS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/CORS/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/CORS/languages","stargazers_url":"https://api.github.com/repos/aspnet/CORS/stargazers","contributors_url":"https://api.github.com/repos/aspnet/CORS/contributors","subscribers_url":"https://api.github.com/repos/aspnet/CORS/subscribers","subscription_url":"https://api.github.com/repos/aspnet/CORS/subscription","commits_url":"https://api.github.com/repos/aspnet/CORS/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/CORS/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/CORS/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/CORS/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/CORS/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/CORS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/CORS/merges","archive_url":"https://api.github.com/repos/aspnet/CORS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/CORS/downloads","issues_url":"https://api.github.com/repos/aspnet/CORS/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/CORS/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/CORS/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/CORS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/CORS/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/CORS/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/CORS/deployments","created_at":"2015-02-17T02:17:36Z","updated_at":"2016-12-07T11:45:42Z","pushed_at":"2016-12-14T22:55:13Z","git_url":"git://github.com/aspnet/CORS.git","ssh_url":"git@github.com:aspnet/CORS.git","clone_url":"https://github.com/aspnet/CORS.git","svn_url":"https://github.com/aspnet/CORS","homepage":null,"size":542,"stargazers_count":58,"watchers_count":58,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":7,"forks":28,"open_issues":7,"watchers":58,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/CORS/pulls/84"},"html":{"href":"https://github.com/aspnet/CORS/pull/84"},"issue":{"href":"https://api.github.com/repos/aspnet/CORS/issues/84"},"comments":{"href":"https://api.github.com/repos/aspnet/CORS/issues/84/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/CORS/pulls/84/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/CORS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/CORS/pulls/84/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/CORS/statuses/c0a77c3e39e7306d1df190cb5bc9ac64d24ce077"}}}}
{"actor":{"display_login":"kichalla"}}