{"action":"created","issue":{"url":"https://api.github.com/repos/ARGOeu/argo-messaging/issues/59","repository_url":"https://api.github.com/repos/ARGOeu/argo-messaging","labels_url":"https://api.github.com/repos/ARGOeu/argo-messaging/issues/59/labels{/name}","comments_url":"https://api.github.com/repos/ARGOeu/argo-messaging/issues/59/comments","events_url":"https://api.github.com/repos/ARGOeu/argo-messaging/issues/59/events","html_url":"https://github.com/ARGOeu/argo-messaging/pull/59","id":175469057,"number":59,"title":"ARGO-484 When a list of ack IDs is given, take into account the max ackId","user":{"login":"kaggis","id":6143589,"avatar_url":"https://avatars.githubusercontent.com/u/6143589?v=3","gravatar_id":"","url":"https://api.github.com/users/kaggis","html_url":"https://github.com/kaggis","followers_url":"https://api.github.com/users/kaggis/followers","following_url":"https://api.github.com/users/kaggis/following{/other_user}","gists_url":"https://api.github.com/users/kaggis/gists{/gist_id}","starred_url":"https://api.github.com/users/kaggis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaggis/subscriptions","organizations_url":"https://api.github.com/users/kaggis/orgs","repos_url":"https://api.github.com/users/kaggis/repos","events_url":"https://api.github.com/users/kaggis/events{/privacy}","received_events_url":"https://api.github.com/users/kaggis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-07T10:34:47Z","updated_at":"2016-09-07T12:41:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ARGOeu/argo-messaging/pulls/59","html_url":"https://github.com/ARGOeu/argo-messaging/pull/59","diff_url":"https://github.com/ARGOeu/argo-messaging/pull/59.diff","patch_url":"https://github.com/ARGOeu/argo-messaging/pull/59.patch"},"body":"### Issue\r\n\r\nSubscription acknowledge request accepts a list of ackIds but only uses the ackId[0]. Instead the id with the maximum offset should be acknowledged\r\n\r\n### Implementation\r\n- [x] Add GetMaxAckID - returns the max AckID from a list of AckIDs\r\n- [x] Add GetOffsetFromAckID - extracts offset from an AckID string\r\n- [x] Add validAckID - returns true if an AckID is valid for a given project and subscription\r\n- [x] Update unit tests\r\n- [x] Update docs"},"comment":{"url":"https://api.github.com/repos/ARGOeu/argo-messaging/issues/comments/245267937","html_url":"https://github.com/ARGOeu/argo-messaging/pull/59#issuecomment-245267937","issue_url":"https://api.github.com/repos/ARGOeu/argo-messaging/issues/59","id":245267937,"user":{"login":"kaggis","id":6143589,"avatar_url":"https://avatars.githubusercontent.com/u/6143589?v=3","gravatar_id":"","url":"https://api.github.com/users/kaggis","html_url":"https://github.com/kaggis","followers_url":"https://api.github.com/users/kaggis/followers","following_url":"https://api.github.com/users/kaggis/following{/other_user}","gists_url":"https://api.github.com/users/kaggis/gists{/gist_id}","starred_url":"https://api.github.com/users/kaggis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaggis/subscriptions","organizations_url":"https://api.github.com/users/kaggis/orgs","repos_url":"https://api.github.com/users/kaggis/repos","events_url":"https://api.github.com/users/kaggis/events{/privacy}","received_events_url":"https://api.github.com/users/kaggis/received_events","type":"User","site_admin":false},"created_at":"2016-09-07T12:41:14Z","updated_at":"2016-09-07T12:41:14Z","body":"please review\r\n/cc @themiszamani @skanct "}}
{"actor":{"display_login":"kaggis"}}