{"action":"opened","number":4,"pull_request":{"url":"https://api.github.com/repos/usnistgov/jsip/pulls/4","id":76978821,"html_url":"https://github.com/usnistgov/jsip/pull/4","diff_url":"https://github.com/usnistgov/jsip/pull/4.diff","patch_url":"https://github.com/usnistgov/jsip/pull/4.patch","issue_url":"https://api.github.com/repos/usnistgov/jsip/issues/4","number":4,"state":"open","locked":false,"title":"Fix for JSIP-519: OriginFieldParser skips session id and session version","user":{"login":"fre42","id":20402346,"avatar_url":"https://avatars.githubusercontent.com/u/20402346?v=3","gravatar_id":"","url":"https://api.github.com/users/fre42","html_url":"https://github.com/fre42","followers_url":"https://api.github.com/users/fre42/followers","following_url":"https://api.github.com/users/fre42/following{/other_user}","gists_url":"https://api.github.com/users/fre42/gists{/gist_id}","starred_url":"https://api.github.com/users/fre42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fre42/subscriptions","organizations_url":"https://api.github.com/users/fre42/orgs","repos_url":"https://api.github.com/users/fre42/repos","events_url":"https://api.github.com/users/fre42/events{/privacy}","received_events_url":"https://api.github.com/users/fre42/received_events","type":"User","site_admin":false},"body":"Although SDP RFC 4566 does not limit the sess-id and sess-version field the NIST implementation of gov.nist.javax.sdp.parser.OriginFieldParser limits the fields to 18 digits.\r\nThis has been done because the jain.sip API used a Java long field for the session-id and session-version.\r\nUnfortunately the JAVA long allows up to 19 digits (see Long.MAX_VALUE) which means that the SDP parser does not allow the full possible range of values to be used with JAVA long.\r\nThe Mozilla Firefox Browser in WebRTC environment created SDP containing the session-id value using the full range for the long value and therefore the first digit may be cut by the current code of OriginFieldParser.java.\r\nMy attached simple patch allows to use the full value range of Long.MAX_VALUE.","created_at":"2016-07-11T15:58:49Z","updated_at":"2016-07-11T15:58:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/usnistgov/jsip/pulls/4/commits","review_comments_url":"https://api.github.com/repos/usnistgov/jsip/pulls/4/comments","review_comment_url":"https://api.github.com/repos/usnistgov/jsip/pulls/comments{/number}","comments_url":"https://api.github.com/repos/usnistgov/jsip/issues/4/comments","statuses_url":"https://api.github.com/repos/usnistgov/jsip/statuses/4f9c4d36f3cbae0e8e057818e04b55a1f3fd58e5","head":{"label":"fre42:master","ref":"master","sha":"4f9c4d36f3cbae0e8e057818e04b55a1f3fd58e5","user":{"login":"fre42","id":20402346,"avatar_url":"https://avatars.githubusercontent.com/u/20402346?v=3","gravatar_id":"","url":"https://api.github.com/users/fre42","html_url":"https://github.com/fre42","followers_url":"https://api.github.com/users/fre42/followers","following_url":"https://api.github.com/users/fre42/following{/other_user}","gists_url":"https://api.github.com/users/fre42/gists{/gist_id}","starred_url":"https://api.github.com/users/fre42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fre42/subscriptions","organizations_url":"https://api.github.com/users/fre42/orgs","repos_url":"https://api.github.com/users/fre42/repos","events_url":"https://api.github.com/users/fre42/events{/privacy}","received_events_url":"https://api.github.com/users/fre42/received_events","type":"User","site_admin":false},"repo":{"id":63081208,"name":"jsip","full_name":"fre42/jsip","owner":{"login":"fre42","id":20402346,"avatar_url":"https://avatars.githubusercontent.com/u/20402346?v=3","gravatar_id":"","url":"https://api.github.com/users/fre42","html_url":"https://github.com/fre42","followers_url":"https://api.github.com/users/fre42/followers","following_url":"https://api.github.com/users/fre42/following{/other_user}","gists_url":"https://api.github.com/users/fre42/gists{/gist_id}","starred_url":"https://api.github.com/users/fre42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fre42/subscriptions","organizations_url":"https://api.github.com/users/fre42/orgs","repos_url":"https://api.github.com/users/fre42/repos","events_url":"https://api.github.com/users/fre42/events{/privacy}","received_events_url":"https://api.github.com/users/fre42/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fre42/jsip","description":"JSIP: Java SIP specification Reference Implementation (moved from java.net)","fork":true,"url":"https://api.github.com/repos/fre42/jsip","forks_url":"https://api.github.com/repos/fre42/jsip/forks","keys_url":"https://api.github.com/repos/fre42/jsip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fre42/jsip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fre42/jsip/teams","hooks_url":"https://api.github.com/repos/fre42/jsip/hooks","issue_events_url":"https://api.github.com/repos/fre42/jsip/issues/events{/number}","events_url":"https://api.github.com/repos/fre42/jsip/events","assignees_url":"https://api.github.com/repos/fre42/jsip/assignees{/user}","branches_url":"https://api.github.com/repos/fre42/jsip/branches{/branch}","tags_url":"https://api.github.com/repos/fre42/jsip/tags","blobs_url":"https://api.github.com/repos/fre42/jsip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fre42/jsip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fre42/jsip/git/refs{/sha}","trees_url":"https://api.github.com/repos/fre42/jsip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fre42/jsip/statuses/{sha}","languages_url":"https://api.github.com/repos/fre42/jsip/languages","stargazers_url":"https://api.github.com/repos/fre42/jsip/stargazers","contributors_url":"https://api.github.com/repos/fre42/jsip/contributors","subscribers_url":"https://api.github.com/repos/fre42/jsip/subscribers","subscription_url":"https://api.github.com/repos/fre42/jsip/subscription","commits_url":"https://api.github.com/repos/fre42/jsip/commits{/sha}","git_commits_url":"https://api.github.com/repos/fre42/jsip/git/commits{/sha}","comments_url":"https://api.github.com/repos/fre42/jsip/comments{/number}","issue_comment_url":"https://api.github.com/repos/fre42/jsip/issues/comments{/number}","contents_url":"https://api.github.com/repos/fre42/jsip/contents/{+path}","compare_url":"https://api.github.com/repos/fre42/jsip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fre42/jsip/merges","archive_url":"https://api.github.com/repos/fre42/jsip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fre42/jsip/downloads","issues_url":"https://api.github.com/repos/fre42/jsip/issues{/number}","pulls_url":"https://api.github.com/repos/fre42/jsip/pulls{/number}","milestones_url":"https://api.github.com/repos/fre42/jsip/milestones{/number}","notifications_url":"https://api.github.com/repos/fre42/jsip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fre42/jsip/labels{/name}","releases_url":"https://api.github.com/repos/fre42/jsip/releases{/id}","deployments_url":"https://api.github.com/repos/fre42/jsip/deployments","created_at":"2016-07-11T15:48:31Z","updated_at":"2016-07-11T15:48:35Z","pushed_at":"2016-07-11T15:52:54Z","git_url":"git://github.com/fre42/jsip.git","ssh_url":"git@github.com:fre42/jsip.git","clone_url":"https://github.com/fre42/jsip.git","svn_url":"https://github.com/fre42/jsip","homepage":"","size":14289,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"usnistgov:master","ref":"master","sha":"048421ef26a8991c1ef3260feff45ca44cfeb1bd","user":{"login":"usnistgov","id":5330158,"avatar_url":"https://avatars.githubusercontent.com/u/5330158?v=3","gravatar_id":"","url":"https://api.github.com/users/usnistgov","html_url":"https://github.com/usnistgov","followers_url":"https://api.github.com/users/usnistgov/followers","following_url":"https://api.github.com/users/usnistgov/following{/other_user}","gists_url":"https://api.github.com/users/usnistgov/gists{/gist_id}","starred_url":"https://api.github.com/users/usnistgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usnistgov/subscriptions","organizations_url":"https://api.github.com/users/usnistgov/orgs","repos_url":"https://api.github.com/users/usnistgov/repos","events_url":"https://api.github.com/users/usnistgov/events{/privacy}","received_events_url":"https://api.github.com/users/usnistgov/received_events","type":"Organization","site_admin":false},"repo":{"id":57232515,"name":"jsip","full_name":"usnistgov/jsip","owner":{"login":"usnistgov","id":5330158,"avatar_url":"https://avatars.githubusercontent.com/u/5330158?v=3","gravatar_id":"","url":"https://api.github.com/users/usnistgov","html_url":"https://github.com/usnistgov","followers_url":"https://api.github.com/users/usnistgov/followers","following_url":"https://api.github.com/users/usnistgov/following{/other_user}","gists_url":"https://api.github.com/users/usnistgov/gists{/gist_id}","starred_url":"https://api.github.com/users/usnistgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usnistgov/subscriptions","organizations_url":"https://api.github.com/users/usnistgov/orgs","repos_url":"https://api.github.com/users/usnistgov/repos","events_url":"https://api.github.com/users/usnistgov/events{/privacy}","received_events_url":"https://api.github.com/users/usnistgov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/usnistgov/jsip","description":"JSIP: Java SIP specification Reference Implementation (moved from java.net)","fork":false,"url":"https://api.github.com/repos/usnistgov/jsip","forks_url":"https://api.github.com/repos/usnistgov/jsip/forks","keys_url":"https://api.github.com/repos/usnistgov/jsip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/usnistgov/jsip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/usnistgov/jsip/teams","hooks_url":"https://api.github.com/repos/usnistgov/jsip/hooks","issue_events_url":"https://api.github.com/repos/usnistgov/jsip/issues/events{/number}","events_url":"https://api.github.com/repos/usnistgov/jsip/events","assignees_url":"https://api.github.com/repos/usnistgov/jsip/assignees{/user}","branches_url":"https://api.github.com/repos/usnistgov/jsip/branches{/branch}","tags_url":"https://api.github.com/repos/usnistgov/jsip/tags","blobs_url":"https://api.github.com/repos/usnistgov/jsip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/usnistgov/jsip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/usnistgov/jsip/git/refs{/sha}","trees_url":"https://api.github.com/repos/usnistgov/jsip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/usnistgov/jsip/statuses/{sha}","languages_url":"https://api.github.com/repos/usnistgov/jsip/languages","stargazers_url":"https://api.github.com/repos/usnistgov/jsip/stargazers","contributors_url":"https://api.github.com/repos/usnistgov/jsip/contributors","subscribers_url":"https://api.github.com/repos/usnistgov/jsip/subscribers","subscription_url":"https://api.github.com/repos/usnistgov/jsip/subscription","commits_url":"https://api.github.com/repos/usnistgov/jsip/commits{/sha}","git_commits_url":"https://api.github.com/repos/usnistgov/jsip/git/commits{/sha}","comments_url":"https://api.github.com/repos/usnistgov/jsip/comments{/number}","issue_comment_url":"https://api.github.com/repos/usnistgov/jsip/issues/comments{/number}","contents_url":"https://api.github.com/repos/usnistgov/jsip/contents/{+path}","compare_url":"https://api.github.com/repos/usnistgov/jsip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/usnistgov/jsip/merges","archive_url":"https://api.github.com/repos/usnistgov/jsip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/usnistgov/jsip/downloads","issues_url":"https://api.github.com/repos/usnistgov/jsip/issues{/number}","pulls_url":"https://api.github.com/repos/usnistgov/jsip/pulls{/number}","milestones_url":"https://api.github.com/repos/usnistgov/jsip/milestones{/number}","notifications_url":"https://api.github.com/repos/usnistgov/jsip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/usnistgov/jsip/labels{/name}","releases_url":"https://api.github.com/repos/usnistgov/jsip/releases{/id}","deployments_url":"https://api.github.com/repos/usnistgov/jsip/deployments","created_at":"2016-04-27T17:27:00Z","updated_at":"2016-07-03T18:25:51Z","pushed_at":"2016-06-02T19:03:37Z","git_url":"git://github.com/usnistgov/jsip.git","ssh_url":"git@github.com:usnistgov/jsip.git","clone_url":"https://github.com/usnistgov/jsip.git","svn_url":"https://github.com/usnistgov/jsip","homepage":"","size":14289,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/usnistgov/jsip/pulls/4"},"html":{"href":"https://github.com/usnistgov/jsip/pull/4"},"issue":{"href":"https://api.github.com/repos/usnistgov/jsip/issues/4"},"comments":{"href":"https://api.github.com/repos/usnistgov/jsip/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/usnistgov/jsip/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/usnistgov/jsip/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/usnistgov/jsip/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/usnistgov/jsip/statuses/4f9c4d36f3cbae0e8e057818e04b55a1f3fd58e5"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":4,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"fre42"}}