{"action":"created","issue":{"url":"https://api.github.com/repos/SRombauts/SQLiteCpp/issues/86","repository_url":"https://api.github.com/repos/SRombauts/SQLiteCpp","labels_url":"https://api.github.com/repos/SRombauts/SQLiteCpp/issues/86/labels{/name}","comments_url":"https://api.github.com/repos/SRombauts/SQLiteCpp/issues/86/comments","events_url":"https://api.github.com/repos/SRombauts/SQLiteCpp/issues/86/events","html_url":"https://github.com/SRombauts/SQLiteCpp/pull/86","id":162267016,"number":86,"title":"Add bindNoCopy methods to allow binding std::string with SQLITE_STATIC","user":{"login":"DouglasHeriot","id":238401,"avatar_url":"https://avatars.githubusercontent.com/u/238401?v=3","gravatar_id":"","url":"https://api.github.com/users/DouglasHeriot","html_url":"https://github.com/DouglasHeriot","followers_url":"https://api.github.com/users/DouglasHeriot/followers","following_url":"https://api.github.com/users/DouglasHeriot/following{/other_user}","gists_url":"https://api.github.com/users/DouglasHeriot/gists{/gist_id}","starred_url":"https://api.github.com/users/DouglasHeriot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DouglasHeriot/subscriptions","organizations_url":"https://api.github.com/users/DouglasHeriot/orgs","repos_url":"https://api.github.com/users/DouglasHeriot/repos","events_url":"https://api.github.com/users/DouglasHeriot/events{/privacy}","received_events_url":"https://api.github.com/users/DouglasHeriot/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/SRombauts/SQLiteCpp/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-06-25T06:33:42Z","updated_at":"2016-06-25T20:58:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/SRombauts/SQLiteCpp/pulls/86","html_url":"https://github.com/SRombauts/SQLiteCpp/pull/86","diff_url":"https://github.com/SRombauts/SQLiteCpp/pull/86.diff","patch_url":"https://github.com/SRombauts/SQLiteCpp/pull/86.patch"},"body":"Should be safe, as long as you can guarantee the std::string exists while executing the query.\r\n\r\n* Added an accessor to Column that returns a std::string, that can handle BLOB or TEXT values that contain null-bytes.\r\n\r\n* Also more binding & Column cast support for uint32_t - fixes ambiguous overload errors when using unsigned-integer types.\r\n    Note that I didn't use uint64_t, because unsigned 64-bit integers doesn't fit into SQLite (except for using int64_t and dealing with overflow with custom functions).\r\n\r\n* Added a C++11 move constructor to Statement, to allow storing it inside STL containers (eg. vector).\r\n\r\n* When binding, don’t pass int/double types as references – inefficient and unnecessary"},"comment":{"url":"https://api.github.com/repos/SRombauts/SQLiteCpp/issues/comments/228570178","html_url":"https://github.com/SRombauts/SQLiteCpp/pull/86#issuecomment-228570178","issue_url":"https://api.github.com/repos/SRombauts/SQLiteCpp/issues/86","id":228570178,"user":{"login":"SRombauts","id":868490,"avatar_url":"https://avatars.githubusercontent.com/u/868490?v=3","gravatar_id":"","url":"https://api.github.com/users/SRombauts","html_url":"https://github.com/SRombauts","followers_url":"https://api.github.com/users/SRombauts/followers","following_url":"https://api.github.com/users/SRombauts/following{/other_user}","gists_url":"https://api.github.com/users/SRombauts/gists{/gist_id}","starred_url":"https://api.github.com/users/SRombauts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SRombauts/subscriptions","organizations_url":"https://api.github.com/users/SRombauts/orgs","repos_url":"https://api.github.com/users/SRombauts/repos","events_url":"https://api.github.com/users/SRombauts/events{/privacy}","received_events_url":"https://api.github.com/users/SRombauts/received_events","type":"User","site_admin":false},"created_at":"2016-06-25T20:58:02Z","updated_at":"2016-06-25T20:58:02Z","body":"I did a first review of the code, looks great!\r\n\r\nIf you can add some unit tests it would be great. Else I hope to look into it in a few days. "}}
{"actor":{"display_login":"SRombauts"}}