{"action":"created","comment":{"url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/pulls/comments/82534633","pull_request_review_id":3434768,"id":82534633,"diff_hunk":"@@ -32,10 +32,15 @@ google.analytics.id=\n google.analytics.autoLink=\n \n ##\n+# CAS Login URLs\n+#\n+cas.osf.login.url=/login?\n+cas.institution.login.url=/login?campaign=institution\n+","path":"etc/cas.properties","position":8,"original_position":8,"commit_id":"c83d215f1e0b738d3c58c57939f32e1e43d1fff2","original_commit_id":"edeb022e407f6a691dfd17bbb0180720ebbf0d5e","user":{"login":"icereval","id":3111541,"avatar_url":"https://avatars.githubusercontent.com/u/3111541?v=3","gravatar_id":"","url":"https://api.github.com/users/icereval","html_url":"https://github.com/icereval","followers_url":"https://api.github.com/users/icereval/followers","following_url":"https://api.github.com/users/icereval/following{/other_user}","gists_url":"https://api.github.com/users/icereval/gists{/gist_id}","starred_url":"https://api.github.com/users/icereval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icereval/subscriptions","organizations_url":"https://api.github.com/users/icereval/orgs","repos_url":"https://api.github.com/users/icereval/repos","events_url":"https://api.github.com/users/icereval/events{/privacy}","received_events_url":"https://api.github.com/users/icereval/received_events","type":"User","site_admin":false},"body":"if not already done, please note in the pr description","created_at":"2016-10-09T23:28:36Z","updated_at":"2016-10-09T23:29:20Z","html_url":"https://github.com/CenterForOpenScience/cas-overlay/pull/21#discussion_r82534633","pull_request_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/pulls/comments/82534633"},"html":{"href":"https://github.com/CenterForOpenScience/cas-overlay/pull/21#discussion_r82534633"},"pull_request":{"href":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/pulls/21","id":78887988,"html_url":"https://github.com/CenterForOpenScience/cas-overlay/pull/21","diff_url":"https://github.com/CenterForOpenScience/cas-overlay/pull/21.diff","patch_url":"https://github.com/CenterForOpenScience/cas-overlay/pull/21.patch","issue_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/issues/21","number":21,"state":"open","locked":false,"title":"[Feature] CAS Institution Login [#OSF-6655]","user":{"login":"cslzchen","id":3750414,"avatar_url":"https://avatars.githubusercontent.com/u/3750414?v=3","gravatar_id":"","url":"https://api.github.com/users/cslzchen","html_url":"https://github.com/cslzchen","followers_url":"https://api.github.com/users/cslzchen/followers","following_url":"https://api.github.com/users/cslzchen/following{/other_user}","gists_url":"https://api.github.com/users/cslzchen/gists{/gist_id}","starred_url":"https://api.github.com/users/cslzchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cslzchen/subscriptions","organizations_url":"https://api.github.com/users/cslzchen/orgs","repos_url":"https://api.github.com/users/cslzchen/repos","events_url":"https://api.github.com/users/cslzchen/events{/privacy}","received_events_url":"https://api.github.com/users/cslzchen/received_events","type":"User","site_admin":false},"body":"## Tickets and related PRs\r\nTicket: https://openscience.atlassian.net/browse/OSF-6655\r\nOSF-PR: https://github.com/CenterForOpenScience/osf.io/pull/6082\r\n\r\n## Description\r\nUse CAS for institution login.\r\n\r\n## Changes\r\n\r\n### UI\r\n\r\n- New CAS Institution Login Page\r\n![institution](https://cloud.githubusercontent.com/assets/3750414/18142007/b0067d68-6f89-11e6-93f6-5593572f2b1b.png)\r\n\r\n- Old OSF Institution Login Page\r\n![osf-inst-login-old](https://cloud.githubusercontent.com/assets/3750414/17342565/e395af10-58c7-11e6-8218-a5328b4625d2.png)\r\n\r\n- Mobile Friendly Version\r\n![mobile](https://cloud.githubusercontent.com/assets/3750414/18142006/b0022722-6f89-11e6-8aa9-8db11b744daa.png)\r\n\r\n### CAS Backend\r\n\r\n- Refactor `OpenScienceFrameworkLogoutHandler` to `OpenScienceFrameworkInstitutionAuthenticationHandler`: add all institution related fields and add a method to get a map between institutions' name and their login urls.\r\n- New **Action State**: `institutionLogin` and **Action**: `OpenScienceFrameworkLoginThroughInstitutions.getInstitutions`\r\n- New **View State**: `viewInstitutionLoginForms` with alternative login page `casInstitutionLoginView.jsp`\r\n- Modified CAS login flow. In `OpenScienceFrameworkPrincipalFromRequestRemoteUserNonInteractiveCredentialsAction`, if `campaign=institution` is present in  the request context, go to new action `institutionLogin`.\r\n```\r\n... \r\n    -->> remoteAuthenticate\r\n        -->> success: sendTGT\r\n        -->> failure: authFailure\r\n        -->> error: viewLoginForm\r\n        -->> institution: institutionLogin\r\n...\r\n    -->> institutionLogin\r\n        -->> success: viewInstitutionLoginForms\r\n```\r\n\r\n### OSF Backend\r\n\r\nPlease refer to [OSF-PR#6082](https://github.com/CenterForOpenScience/osf.io/pull/6082) for more information.\r\n\r\n## Side Effects\r\nNo","created_at":"2016-07-26T16:59:48Z","updated_at":"2016-10-09T23:29:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e050f8204b801197079baa4e55a6ba2effbe5f19","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/pulls/21/commits","review_comments_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/pulls/21/comments","review_comment_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/issues/21/comments","statuses_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/statuses/c83d215f1e0b738d3c58c57939f32e1e43d1fff2","head":{"label":"cslzchen:feature/cas-institution-login","ref":"feature/cas-institution-login","sha":"c83d215f1e0b738d3c58c57939f32e1e43d1fff2","user":{"login":"cslzchen","id":3750414,"avatar_url":"https://avatars.githubusercontent.com/u/3750414?v=3","gravatar_id":"","url":"https://api.github.com/users/cslzchen","html_url":"https://github.com/cslzchen","followers_url":"https://api.github.com/users/cslzchen/followers","following_url":"https://api.github.com/users/cslzchen/following{/other_user}","gists_url":"https://api.github.com/users/cslzchen/gists{/gist_id}","starred_url":"https://api.github.com/users/cslzchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cslzchen/subscriptions","organizations_url":"https://api.github.com/users/cslzchen/orgs","repos_url":"https://api.github.com/users/cslzchen/repos","events_url":"https://api.github.com/users/cslzchen/events{/privacy}","received_events_url":"https://api.github.com/users/cslzchen/received_events","type":"User","site_admin":false},"repo":{"id":58220600,"name":"cas-overlay","full_name":"cslzchen/cas-overlay","owner":{"login":"cslzchen","id":3750414,"avatar_url":"https://avatars.githubusercontent.com/u/3750414?v=3","gravatar_id":"","url":"https://api.github.com/users/cslzchen","html_url":"https://github.com/cslzchen","followers_url":"https://api.github.com/users/cslzchen/followers","following_url":"https://api.github.com/users/cslzchen/following{/other_user}","gists_url":"https://api.github.com/users/cslzchen/gists{/gist_id}","starred_url":"https://api.github.com/users/cslzchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cslzchen/subscriptions","organizations_url":"https://api.github.com/users/cslzchen/orgs","repos_url":"https://api.github.com/users/cslzchen/repos","events_url":"https://api.github.com/users/cslzchen/events{/privacy}","received_events_url":"https://api.github.com/users/cslzchen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cslzchen/cas-overlay","description":"Center for Open Science CAS Overlay","fork":true,"url":"https://api.github.com/repos/cslzchen/cas-overlay","forks_url":"https://api.github.com/repos/cslzchen/cas-overlay/forks","keys_url":"https://api.github.com/repos/cslzchen/cas-overlay/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cslzchen/cas-overlay/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cslzchen/cas-overlay/teams","hooks_url":"https://api.github.com/repos/cslzchen/cas-overlay/hooks","issue_events_url":"https://api.github.com/repos/cslzchen/cas-overlay/issues/events{/number}","events_url":"https://api.github.com/repos/cslzchen/cas-overlay/events","assignees_url":"https://api.github.com/repos/cslzchen/cas-overlay/assignees{/user}","branches_url":"https://api.github.com/repos/cslzchen/cas-overlay/branches{/branch}","tags_url":"https://api.github.com/repos/cslzchen/cas-overlay/tags","blobs_url":"https://api.github.com/repos/cslzchen/cas-overlay/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cslzchen/cas-overlay/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cslzchen/cas-overlay/git/refs{/sha}","trees_url":"https://api.github.com/repos/cslzchen/cas-overlay/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cslzchen/cas-overlay/statuses/{sha}","languages_url":"https://api.github.com/repos/cslzchen/cas-overlay/languages","stargazers_url":"https://api.github.com/repos/cslzchen/cas-overlay/stargazers","contributors_url":"https://api.github.com/repos/cslzchen/cas-overlay/contributors","subscribers_url":"https://api.github.com/repos/cslzchen/cas-overlay/subscribers","subscription_url":"https://api.github.com/repos/cslzchen/cas-overlay/subscription","commits_url":"https://api.github.com/repos/cslzchen/cas-overlay/commits{/sha}","git_commits_url":"https://api.github.com/repos/cslzchen/cas-overlay/git/commits{/sha}","comments_url":"https://api.github.com/repos/cslzchen/cas-overlay/comments{/number}","issue_comment_url":"https://api.github.com/repos/cslzchen/cas-overlay/issues/comments{/number}","contents_url":"https://api.github.com/repos/cslzchen/cas-overlay/contents/{+path}","compare_url":"https://api.github.com/repos/cslzchen/cas-overlay/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cslzchen/cas-overlay/merges","archive_url":"https://api.github.com/repos/cslzchen/cas-overlay/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cslzchen/cas-overlay/downloads","issues_url":"https://api.github.com/repos/cslzchen/cas-overlay/issues{/number}","pulls_url":"https://api.github.com/repos/cslzchen/cas-overlay/pulls{/number}","milestones_url":"https://api.github.com/repos/cslzchen/cas-overlay/milestones{/number}","notifications_url":"https://api.github.com/repos/cslzchen/cas-overlay/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cslzchen/cas-overlay/labels{/name}","releases_url":"https://api.github.com/repos/cslzchen/cas-overlay/releases{/id}","deployments_url":"https://api.github.com/repos/cslzchen/cas-overlay/deployments","created_at":"2016-05-06T16:32:49Z","updated_at":"2016-05-06T16:32:51Z","pushed_at":"2016-10-06T18:50:24Z","git_url":"git://github.com/cslzchen/cas-overlay.git","ssh_url":"git@github.com:cslzchen/cas-overlay.git","clone_url":"https://github.com/cslzchen/cas-overlay.git","svn_url":"https://github.com/cslzchen/cas-overlay","homepage":"","size":964,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"CenterForOpenScience:develop","ref":"develop","sha":"acc0f57e01d69af2752eb53673af89df26a8c659","user":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars.githubusercontent.com/u/3344584?v=3","gravatar_id":"","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"repo":{"id":33820054,"name":"cas-overlay","full_name":"CenterForOpenScience/cas-overlay","owner":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars.githubusercontent.com/u/3344584?v=3","gravatar_id":"","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CenterForOpenScience/cas-overlay","description":"Center for Open Science CAS Overlay","fork":false,"url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay","forks_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/forks","keys_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/teams","hooks_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/hooks","issue_events_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/issues/events{/number}","events_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/events","assignees_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/assignees{/user}","branches_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/branches{/branch}","tags_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/tags","blobs_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/git/refs{/sha}","trees_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/statuses/{sha}","languages_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/languages","stargazers_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/stargazers","contributors_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/contributors","subscribers_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/subscribers","subscription_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/subscription","commits_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/commits{/sha}","git_commits_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/git/commits{/sha}","comments_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/comments{/number}","issue_comment_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/issues/comments{/number}","contents_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/contents/{+path}","compare_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/merges","archive_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/downloads","issues_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/issues{/number}","pulls_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/pulls{/number}","milestones_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/milestones{/number}","notifications_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/labels{/name}","releases_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/releases{/id}","deployments_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/deployments","created_at":"2015-04-12T14:29:46Z","updated_at":"2016-10-03T14:23:39Z","pushed_at":"2016-10-06T18:50:24Z","git_url":"git://github.com/CenterForOpenScience/cas-overlay.git","ssh_url":"git@github.com:CenterForOpenScience/cas-overlay.git","clone_url":"https://github.com/CenterForOpenScience/cas-overlay.git","svn_url":"https://github.com/CenterForOpenScience/cas-overlay","homepage":"","size":953,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":4,"forks":6,"open_issues":4,"watchers":7,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/pulls/21"},"html":{"href":"https://github.com/CenterForOpenScience/cas-overlay/pull/21"},"issue":{"href":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/issues/21"},"comments":{"href":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/statuses/c83d215f1e0b738d3c58c57939f32e1e43d1fff2"}}}}
{"actor":{"display_login":"icereval"}}