{"push_id":1171073470,"size":11,"distinct_size":7,"ref":"refs/heads/master","head":"25f5b99c9249f572a744ae0a26ab00bc6f43e58c","before":"387bb116c96863aaf2e07fff278a363e15bbfd34","commits":[{"sha":"bde5f2dd7042f2d9f14cf6f480546b44b445036c","author":{"name":"Ebube Chuba","email":"7bb3077f1570f34108e2b6c6ad5ef5509045397a@me.com"},"message":"logs kill server info when creating server\n\nadded clarifying quotations\n\nTesting Done:\n16:24:28 00:00 [main]\n               See a report at: http://localhost:62800/run/pants_run_2016_06_13_16_24_28_848_f721caf57a00436589bd48c31dd925e6\n16:24:28 00:00   [setup]\n16:24:28 00:00     [parse]INFO] Operating on changed 0 target(s):\n\n               Executing tasks in goals: bootstrap -> imports -> unpack-jars -> deferred-sources -> gen -> jvm-platform-validate -> resolve -> resources -> compile -> test -> test-changed\n16:24:29 00:01   [bootstrap]\n16:24:29 00:01     [substitute-aliased-targets]\n16:24:29 00:01     [jar-dependency-management]\n16:24:29 00:01     [bootstrap-jvm-tools]\n16:24:29 00:01   [imports]\n16:24:29 00:01     [ivy-imports]\n16:24:29 00:01   [unpack-jars]\n16:24:29 00:01     [unpack-jars]\n16:24:29 00:01     [unpack-libs]\n16:24:29 00:01   [deferred-sources]\n16:24:29 00:01     [deferred-sources]\n16:24:29 00:01   [gen]\n16:24:29 00:01     [thrift]\n16:24:29 00:01     [protoc]\n16:24:29 00:01     [antlr]\n16:24:29 00:01     [ragel]\n16:24:29 00:01     [jaxb]\n16:24:29 00:01     [wire]\n16:24:29 00:01     [aapt]\n16:24:29 00:01     [go-thrift]\n16:24:29 00:01     [scrooge]\n16:24:29 00:01     [spindle]\n16:24:29 00:01   [jvm-platform-validate]\n16:24:29 00:01     [jvm-platform-validate]\n16:24:29 00:01   [resolve]\n16:24:29 00:01     [ivy]\n16:24:29 00:01     [go]\n16:24:29 00:01     [scala-js-compile]\n16:24:29 00:01     [scala-js-link]\n16:24:29 00:01     [node]\n16:24:29 00:01   [resources]\n16:24:29 00:01     [prepare]\n16:24:29 00:01     [services]\n16:24:29 00:01   [compile]\n16:24:29 00:01     [compile-jvm-prep-command]\n16:24:29 00:01       [jvm_prep_command]\n16:24:29 00:01     [compile-prep-command]\n16:24:29 00:01     [compile]\n16:24:29 00:01     [zinc]\n16:24:29 00:01     [jvm-dep-check]\n16:24:29 00:01     [checkstyle]\n16:24:29 00:01     [scalastyle]\n16:24:29 00:01     [cpp]\n16:24:29 00:01     [findbugs]\n16:24:29 00:01     [go]\n16:24:29 00:01     [gofmt]\n16:24:29 00:01     [python-eval]\n16:24:29 00:01     [pythonstyle]\n16:24:29 00:01   [test]\n16:24:29 00:01     [test-jvm-prep-command]\n16:24:29 00:01       [jvm_prep_command]\n16:24:29 00:01     [test-prep-command]\n16:24:29 00:01     [test]\n16:24:29 00:01     [pytest]\n16:24:29 00:01     [junit]\n16:24:29 00:01     [go]\n16:24:29 00:01     [node]\n16:24:29 00:01   [test-changed]\n16:24:29 00:01     [test-changed]\n16:24:29 00:01   [complete]\n               SUCCESS\n\nReviewed at https://rbcommons.com/s/twitter/r/4002/","distinct":false,"url":"https://api.github.com/repos/twitter/pants/commits/bde5f2dd7042f2d9f14cf6f480546b44b445036c"},{"sha":"1b88b5bf4cfb5224b0ad039fb59229fb375be850","author":{"name":"Stu Hood","email":"50abbb3a4290d1d6c08c7e8a002d0c743d331242@gmail.com"},"message":"[engine] Fix imports of classes that moved from fs to project_tree\n\nFix some imports that were transitive through the `.fs` package.\n\nLikely not an error in any cases, but incorrect anyway.\n\nTesting Done:\nhttp://jenkins.pantsbuild.org/job/pantsbuild/job/pants/branch/PR-3585/2/\n\nBugs closed: 3585\n\nReviewed at https://rbcommons.com/s/twitter/r/4005/","distinct":false,"url":"https://api.github.com/repos/twitter/pants/commits/1b88b5bf4cfb5224b0ad039fb59229fb375be850"},{"sha":"a58f5aed18a3b558818acf89da3f38adae6e09b1","author":{"name":"John Sirois","email":"a3aece39382087830532a4184dc76ba110e155bd@gmail.com"},"message":"Add an :API: public exception for abstract members.\n\nThis is intuitive, helps make more current `:API: public` markings\ncorrect and eases the burden of manually marking classes `:API: public`\ngoing forward.\n\nTesting Done:\nRendered here:\n  https://github.com/jsirois/pants/blob/jsirois/issues/3545/src/docs/deprecation_policy.md\n  http://pantsbuild.github.io/staging/jsirois/issues/3545/deprecation_policy.html\n\nCI went green here:\n  http://jenkins.pantsbuild.org/job/pantsbuild/job/pants/branch/PR-3546/4/\n\nBugs closed: 3545, 3546\n\nReviewed at https://rbcommons.com/s/twitter/r/3968/","distinct":false,"url":"https://api.github.com/repos/twitter/pants/commits/a58f5aed18a3b558818acf89da3f38adae6e09b1"},{"sha":"36cb5752b12289ceefa4312673f813ca9892d5b3","author":{"name":"Peiyu Wang","email":"d174f8fb0d546c0de85a0b484162cd0c833dc038@gmail.com"},"message":"dep-usage: output aliases information\n\nOutput alias information to declared dependencies allows offline\nscript to determine which those aliases can be further cleaned up:\n\n1) aliases without any dependency being used can be removed.\n2) aliases with some dependencies' products uesd can be replaced by\n   those depedencies.\n3) aliases with all their dependencies used won't change.\n\nIt outputs information in json like this:\n```\n  \"a/b/c\":\n    \"cost\": 30862,\n    \"cost_transitive\": 4095740906,\n    \"dependencies\": [\n      {\n        \"aliases\": [\n          \"finagle/finagle-http:finagle-http\"\n        ],\n        \"dependency_type\": \"declared\",\n        \"products_used\": 0,\n        \"products_used_ratio\": 0.0,\n        \"target\": \"finagle/finagle-http/src/main/java:java\"\n      },\n      {\n        \"aliases\": [\n          \"finagle/finagle-http:finagle-http\"\n        ],\n        \"dependency_type\": \"declared\",\n        \"products_used\": 14,\n        \"products_used_ratio\": 0.024013722126929673,\n        \"target\": \"finagle/finagle-http/src/main/scala:scala\"\n      },\n      {\n        \"aliases\": [\n          \"finagle/finagle-stats:finagle-stats\"\n        ],\n        \"dependency_type\": \"declared\",\n        \"products_used\": 0,\n        \"products_used_ratio\": 0.0,\n        \"target\": \"finagle/finagle-stats/src/main/scala:scala\"\n      },\n     ...\n```\n\nIn this example, we know\n1) we can completely get rid of `finagle/finagle-stats:finagle-stats` because its resolved aliases do not provide any products\n2) `finagle/finagle-http:finagle-http` is partially used, we can replace it with `finagle/finagle-http/src/main/scala:scala`, essentially removed the unused `finagle/finagle-http/src/main/java:java`\n\nTesting Done:\nhttps://travis-ci.org/peiyuwang/pants/builds/135994166 passed\nhttps://travis-ci.org/peiyuwang/pants/builds/137144212 passed\n\nBugs closed: 3569\n\nReviewed at https://rbcommons.com/s/twitter/r/3984/","distinct":false,"url":"https://api.github.com/repos/twitter/pants/commits/36cb5752b12289ceefa4312673f813ca9892d5b3"},{"sha":"cdb72c853b0d301dd95c43e2def10cb2da95feeb","author":{"name":"Yi Cheng","email":"8660a3256756ebc6fe8e0173756496a2530ff968@gmail.com"},"message":"[engine] refine exception output\n\n1. Output exception details on leaf trace nodes as opposed to lots of repetitions as linked in the bug.\n2. newline Throw for clarity.\n\nTesting Done:\nhttps://travis-ci.org/pantsbuild/pants/builds/138217773\n\n[tw-mbp-yic pants (3535_b)]$ ./pants --enable-v2-engine dependees examples/tests/::\nException caught: (<class 'pants.build_graph.address_lookup_error.AddressLookupError'>)\n  File \"/Users/yic/workspace/pants/src/python/pants/bin/pants_exe.py\", line 50, in <module>\n    main()\n  File \"/Users/yic/workspace/pants/src/python/pants/bin/pants_exe.py\", line 44, in main\n    PantsRunner(exiter).run()\n  File \"/Users/yic/workspace/pants/src/python/pants/bin/pants_runner.py\", line 57, in run\n    options_bootstrapper=options_bootstrapper)\n  File \"/Users/yic/workspace/pants/src/python/pants/bin/pants_runner.py\", line 46, in _run\n    return LocalPantsRunner(exiter, args, env, options_bootstrapper=options_bootstrapper).run()\n  File \"/Users/yic/workspace/pants/src/python/pants/bin/local_pants_runner.py\", line 53, in run\n    self._maybe_profiled(self._run)\n  File \"/Users/yic/workspace/pants/src/python/pants/bin/local_pants_runner.py\", line 50, in _maybe_profiled\n    runner()\n  File \"/Users/yic/workspace/pants/src/python/pants/bin/local_pants_runner.py\", line 93, in _run\n    self._exiter).setup()\n  File \"/Users/yic/workspace/pants/src/python/pants/bin/goal_runner.py\", line 84, in __init__\n    build_graph)\n  File \"/Users/yic/workspace/pants/src/python/pants/bin/goal_runner.py\", line 99, in _select_buildgraph\n    return graph_helper.create_graph(root_specs)\n  File \"/Users/yic/workspace/pants/src/python/pants/bin/engine_initializer.py\", line 70, in create_graph\n    for _ in graph.inject_specs_closure(spec_roots):  # Ensure the entire generator is unrolled.\n  File \"/Users/yic/workspace/pants/src/python/pants/engine/legacy/graph.py\", line 171, in inject_specs_closure\n    for address in self._inject(specs):\n  File \"/Users/yic/workspace/pants/src/python/pants/engine/legacy/graph.py\", line 183, in _inject\n    self._index(request.roots)\n  File \"/Users/yic/workspace/pants/src/python/pants/engine/legacy/graph.py\", line 68, in _index\n    'Build graph construction failed for {}:\\n{}'.format(node.subject, trace))\n\nException message: Build graph construction failed for DescendantAddresses(directory='examples/tests'):\n  Computing LegacyTarget for DescendantAddresses(directory='examples/tests')\n    Computing LegacyTarget for examples/tests/scala/org/pantsbuild/example/hello/welcome:welcome\n      Computing LegacyTarget for examples/src/scala/org/pantsbuild/example/hello/welcome:welcome\n        Computing LegacyTarget for examples/src/java/org/pantsbuild/example/hello/greet:greet\n          Computing TargetAdaptor for examples/src/java/org/pantsbuild/example/hello/greet:greet\n            Computing Struct for examples/src/java/org/pantsbuild/example/hello/greet:greet\n              Computing UnhydratedStruct for examples/src/java/org/pantsbuild/example/hello/greet:greet\n                Computing AddressFamily for Dir(path=u'examples/src/java/org/pantsbuild/example/hello/greet')\n                  Throw(exc=MappingError(u\"Failed to parse examples/src/java/org/pantsbuild/example/hello/greet/BUILD:\\nname 'abc' is not defined\",))\n    Computing LegacyTarget for examples/tests/java/org/pantsbuild/example/hello/greet:greet\n      Throw(exc=MappingError(u\"Failed to parse examples/src/java/org/pantsbuild/example/hello/greet/BUILD:\\nname 'abc' is not defined\",))\n\nBugs closed: 3535, 3584\n\nReviewed at https://rbcommons.com/s/twitter/r/3992/","distinct":true,"url":"https://api.github.com/repos/twitter/pants/commits/cdb72c853b0d301dd95c43e2def10cb2da95feeb"},{"sha":"0347708756e4849c4166cf235024ea805239ea85","author":{"name":"Chris Heisterkamp","email":"a048f4fe14e5f13c3afe877029f4bf7ea522b2a6@gmail.com"},"message":"Report JUnit tests with failing assumptions as skipped tests\n\nTesting Done:\nTravis CI: https://travis-ci.org/pantsbuild/pants/builds/137691523\n\nBugs closed: 3587\n\nReviewed at https://rbcommons.com/s/twitter/r/4010/","distinct":true,"url":"https://api.github.com/repos/twitter/pants/commits/0347708756e4849c4166cf235024ea805239ea85"},{"sha":"b605e5a83b0a250ff4b422adbd7f1b583cb0a4da","author":{"name":"Eric Ayers","email":"ad822c88bead07678bfed363e8b5b9ac5caffc29@squareup.com"},"message":"pants build committing publish data for push of org.pantsbuild#junit-runner;1.0.10\n# Prevent Travis-CI from running for this automated jar publish commit:\n#   http://docs.travis-ci.com/user/how-to-skip-a-build/\n[ci skip]","distinct":true,"url":"https://api.github.com/repos/twitter/pants/commits/b605e5a83b0a250ff4b422adbd7f1b583cb0a4da"},{"sha":"4b58f02549d400cb9ed95039230eb607b3d1a62d","author":{"name":"Nick Howard (Twitter)","email":"563680712feb31124802cc3475789de064d53427@twopensource.com"},"message":"When source fields are strings, not collections, raise an error; Test deferred sources addresses error\n\nCurrently if a string is passed to sources in a target definition, it will be treated as a list of single character filenames, which blows up in a confusing way later. This makes passing a string an error.\n\nWhile I was in here, I added unit tests covering the too many addresses case for deferred sources and uncovered a bug where if the address kwarg isn't passed, instead of raising WrongNumberOfAddresses, it would instead hit an AttributeError on None.\n\nTesting Done:\nWrote a few regression tests and made them pass.\n\nJenkins and travis passed\n\n- http://jenkins.pantsbuild.org/job/pantsbuild/job/pants/branch/PR-3550/1/\n- https://travis-ci.org/pantsbuild/pants/builds/135065849\n\nBugs closed: 3507, 3550\n\nReviewed at https://rbcommons.com/s/twitter/r/3970/\n\ncloses #3507, closes #3550","distinct":true,"url":"https://api.github.com/repos/twitter/pants/commits/4b58f02549d400cb9ed95039230eb607b3d1a62d"},{"sha":"de65a79cbc3bb87bf44cf1da813c9e24743e5267","author":{"name":"Matt Olsen","email":"31e7b35f7f9f5d76c1e2ef239c79b97264b2f6d0@digital-wanderlust.com"},"message":"Create a hybrid optionally async engine.\n\n* Use futures for backend rather than raw threads\n* Allow for optionally running steps async\n* Abstract common methods from StatefulPool's\n\nTesting Done:\nCI green: https://travis-ci.org/pantsbuild/pants/builds/138965464\n\nBugs closed: 3325, 3457\n\nReviewed at https://rbcommons.com/s/twitter/r/3897/","distinct":true,"url":"https://api.github.com/repos/twitter/pants/commits/de65a79cbc3bb87bf44cf1da813c9e24743e5267"},{"sha":"a5c25d2b17740d449de3bb24780ad1b5d4e63f7f","author":{"name":"Benjy Weinberger","email":"a509d487a5f8dbb865a9ea050fc89e4377b3af8b@gmail.com"},"message":"Ability to filter list options.\n\nGeneralizes the \"EXTEND\" functionality of ListValueComponent to \"MODIFY\".\nEach ListValueComponent now stores a list of appends and a list of filters,\nand these get applied when the final `val` is requested.\n\nIntroduces two new forms of syntax for values of list options:\n\n1. -['foo', 'bar'] filters those values from the running list computation.\n2. ...,...,... splits the value on the commas and merges the results of evaluating the ....\n\nThe latter allows you to both append to and filter a list in, say, pants.ini:\n\n```\nlist_option: -[1,2,3],+[4,5,6]\n\n```\n\nTesting Done:\nAdded tests of the new syntax and functionality. All options tests pass.\nFull CI passes here: http://jenkins.pantsbuild.org/job/pantsbuild/job/pants/branch/PR-3583/\n\nReviewed at https://rbcommons.com/s/twitter/r/3997/","distinct":true,"url":"https://api.github.com/repos/twitter/pants/commits/a5c25d2b17740d449de3bb24780ad1b5d4e63f7f"},{"sha":"25f5b99c9249f572a744ae0a26ab00bc6f43e58c","author":{"name":"Garrett Malmquist","email":"261c35170c3d90a9ed13cb8070ecb826577abca3@gmail.com"},"message":"A `remote_sources` target as a better mechanism for from_target.\n\nStu suggested in https://rbcommons.com/s/twitter/r/3830/ that we\noverhaul the deferred sources system to generate synthetic targets\ninstead. This should eliminate a lot of special casing we've been\nhaving to do around deferred sources, since we can use the same\nlogic that was already handling synthetic targets created from\ngenerated code.\n\nThis change adds the `remote_sources` target as a replacement for\nthe `from_target` object, and deprecates `from_target`.\n\nIn the meantime, I added an option to `deferred_sources_mapper`\nto throw an exception if `from_target` is used, which will allow\nindividual users to eliminate their own usage of `from_target` in\nfavor of the more robust `remote_sources`.\n\nTesting Done:\nAdded unit test.\n\nJenkins went green here: http://jenkins.pantsbuild.org/job/pantsbuild/job/pants/job/PR-3592/2/\nCI went green here: https://travis-ci.org/pantsbuild/pants/builds/139023132\nJenkins went green here: http://jenkins.pantsbuild.org/job/pantsbuild/job/pants/job/PR-3592/4/\n\nBugs closed: 3592\n\nReviewed at https://rbcommons.com/s/twitter/r/4014/","distinct":true,"url":"https://api.github.com/repos/twitter/pants/commits/25f5b99c9249f572a744ae0a26ab00bc6f43e58c"}]}
{"actor":{"display_login":"kwlzn"}}