{"action":"created","comment":{"url":"https://api.github.com/repos/martinisgroup/servers/pulls/comments/67982959","id":67982959,"diff_hunk":"@@ -122,145 +122,204 @@ def reference(self, c, ref=None):\n \n     @setting(14, 'Frequency', f=[': query frequency', 'v[Hz]: set frequency'], returns='v[Hz]')\n     def frequency(self, c, f = None):\n-        \"\"\" Sets/gets the frequency of the internal reference. \"\"\"\n+        \"\"\"Set or get the excitation frequency (when source is internal)\n+\n+        Args:\n+            f (value[Hz]): Frequency to set.  If none, then we query the\n+                existing frequency\n+\n+        Returns:\n+            (value[Hz]): The internal excitation frequency.\n+        \"\"\"\n         dev = self.selectedDevice(c)\n-        if f is None:\n-            resp = yield dev.query('FREQ?')\n-            returnValue(float(resp)*Hz)\n-        else:\n+        if f is not None:\n             yield dev.write('FREQ ' + str(f['Hz']))\n-            resp = yield dev.query('FREQ?')\n-            returnValue(float(resp)*Hz)\n+        resp = yield dev.query('FREQ?')\n+        returnValue(float(resp)*Hz)\n \n     @setting(15, 'External Reference Slope', ers=[': query', 'i: set'], returns='i')\n     def external_reference_slope(self, c, ers = None):\n-        \"\"\"\n-        Get/set the external reference slope.\n-        0 = Sine, 1 = TTL Rising, 2 = TTL Falling\n+        \"\"\"Set or get the external reference slope..\\\n+\n+        Args:\n+            ers (i): Specifies the external reference source..\n+                0 = Sine, 1 = TTL Rising, 2 = TTL Falling\n+\n+        Returns:\n+            (i):  The external reference source.","path":"SR830/SR830.py","position":59,"original_position":59,"commit_id":"c4b32e120f7b66388e451d756b60082abb19c410","original_commit_id":"c4b32e120f7b66388e451d756b60082abb19c410","user":{"login":"maffoo","id":129268,"avatar_url":"https://avatars.githubusercontent.com/u/129268?v=3","gravatar_id":"","url":"https://api.github.com/users/maffoo","html_url":"https://github.com/maffoo","followers_url":"https://api.github.com/users/maffoo/followers","following_url":"https://api.github.com/users/maffoo/following{/other_user}","gists_url":"https://api.github.com/users/maffoo/gists{/gist_id}","starred_url":"https://api.github.com/users/maffoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maffoo/subscriptions","organizations_url":"https://api.github.com/users/maffoo/orgs","repos_url":"https://api.github.com/users/maffoo/repos","events_url":"https://api.github.com/users/maffoo/events{/privacy}","received_events_url":"https://api.github.com/users/maffoo/received_events","type":"User","site_admin":false},"body":"maybe call this `int` (a python type) instead of `i` (a labrad type)","created_at":"2016-06-22T01:44:40Z","updated_at":"2016-06-22T01:44:40Z","html_url":"https://github.com/martinisgroup/servers/pull/353#discussion_r67982959","pull_request_url":"https://api.github.com/repos/martinisgroup/servers/pulls/353","_links":{"self":{"href":"https://api.github.com/repos/martinisgroup/servers/pulls/comments/67982959"},"html":{"href":"https://github.com/martinisgroup/servers/pull/353#discussion_r67982959"},"pull_request":{"href":"https://api.github.com/repos/martinisgroup/servers/pulls/353"}}},"pull_request":{"url":"https://api.github.com/repos/martinisgroup/servers/pulls/353","id":74710084,"html_url":"https://github.com/martinisgroup/servers/pull/353","diff_url":"https://github.com/martinisgroup/servers/pull/353.diff","patch_url":"https://github.com/martinisgroup/servers/pull/353.patch","issue_url":"https://api.github.com/repos/martinisgroup/servers/issues/353","number":353,"state":"open","locked":false,"title":"Fixing up SR830 server","user":{"login":"BrooksCampbell","id":10713905,"avatar_url":"https://avatars.githubusercontent.com/u/10713905?v=3","gravatar_id":"","url":"https://api.github.com/users/BrooksCampbell","html_url":"https://github.com/BrooksCampbell","followers_url":"https://api.github.com/users/BrooksCampbell/followers","following_url":"https://api.github.com/users/BrooksCampbell/following{/other_user}","gists_url":"https://api.github.com/users/BrooksCampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/BrooksCampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrooksCampbell/subscriptions","organizations_url":"https://api.github.com/users/BrooksCampbell/orgs","repos_url":"https://api.github.com/users/BrooksCampbell/repos","events_url":"https://api.github.com/users/BrooksCampbell/events{/privacy}","received_events_url":"https://api.github.com/users/BrooksCampbell/received_events","type":"User","site_admin":false},"body":"Adds documentation, fixes unit issues and modifies functions to always query the device after setting a new value.","created_at":"2016-06-22T01:06:45Z","updated_at":"2016-06-22T01:44:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"19db5d7695195519b456f51425a5169150b3d281","assignee":{"login":"DanielSank","id":4584456,"avatar_url":"https://avatars.githubusercontent.com/u/4584456?v=3","gravatar_id":"","url":"https://api.github.com/users/DanielSank","html_url":"https://github.com/DanielSank","followers_url":"https://api.github.com/users/DanielSank/followers","following_url":"https://api.github.com/users/DanielSank/following{/other_user}","gists_url":"https://api.github.com/users/DanielSank/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielSank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielSank/subscriptions","organizations_url":"https://api.github.com/users/DanielSank/orgs","repos_url":"https://api.github.com/users/DanielSank/repos","events_url":"https://api.github.com/users/DanielSank/events{/privacy}","received_events_url":"https://api.github.com/users/DanielSank/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/martinisgroup/servers/pulls/353/commits","review_comments_url":"https://api.github.com/repos/martinisgroup/servers/pulls/353/comments","review_comment_url":"https://api.github.com/repos/martinisgroup/servers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/martinisgroup/servers/issues/353/comments","statuses_url":"https://api.github.com/repos/martinisgroup/servers/statuses/c4b32e120f7b66388e451d756b60082abb19c410","head":{"label":"martinisgroup:u/Brooks/fpgaTestDCandSquare","ref":"u/Brooks/fpgaTestDCandSquare","sha":"c4b32e120f7b66388e451d756b60082abb19c410","user":{"login":"martinisgroup","id":5026004,"avatar_url":"https://avatars.githubusercontent.com/u/5026004?v=3","gravatar_id":"","url":"https://api.github.com/users/martinisgroup","html_url":"https://github.com/martinisgroup","followers_url":"https://api.github.com/users/martinisgroup/followers","following_url":"https://api.github.com/users/martinisgroup/following{/other_user}","gists_url":"https://api.github.com/users/martinisgroup/gists{/gist_id}","starred_url":"https://api.github.com/users/martinisgroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinisgroup/subscriptions","organizations_url":"https://api.github.com/users/martinisgroup/orgs","repos_url":"https://api.github.com/users/martinisgroup/repos","events_url":"https://api.github.com/users/martinisgroup/events{/privacy}","received_events_url":"https://api.github.com/users/martinisgroup/received_events","type":"Organization","site_admin":false},"repo":{"id":21184808,"name":"servers","full_name":"martinisgroup/servers","owner":{"login":"martinisgroup","id":5026004,"avatar_url":"https://avatars.githubusercontent.com/u/5026004?v=3","gravatar_id":"","url":"https://api.github.com/users/martinisgroup","html_url":"https://github.com/martinisgroup","followers_url":"https://api.github.com/users/martinisgroup/followers","following_url":"https://api.github.com/users/martinisgroup/following{/other_user}","gists_url":"https://api.github.com/users/martinisgroup/gists{/gist_id}","starred_url":"https://api.github.com/users/martinisgroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinisgroup/subscriptions","organizations_url":"https://api.github.com/users/martinisgroup/orgs","repos_url":"https://api.github.com/users/martinisgroup/repos","events_url":"https://api.github.com/users/martinisgroup/events{/privacy}","received_events_url":"https://api.github.com/users/martinisgroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/martinisgroup/servers","description":"LabRAD servers","fork":false,"url":"https://api.github.com/repos/martinisgroup/servers","forks_url":"https://api.github.com/repos/martinisgroup/servers/forks","keys_url":"https://api.github.com/repos/martinisgroup/servers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martinisgroup/servers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martinisgroup/servers/teams","hooks_url":"https://api.github.com/repos/martinisgroup/servers/hooks","issue_events_url":"https://api.github.com/repos/martinisgroup/servers/issues/events{/number}","events_url":"https://api.github.com/repos/martinisgroup/servers/events","assignees_url":"https://api.github.com/repos/martinisgroup/servers/assignees{/user}","branches_url":"https://api.github.com/repos/martinisgroup/servers/branches{/branch}","tags_url":"https://api.github.com/repos/martinisgroup/servers/tags","blobs_url":"https://api.github.com/repos/martinisgroup/servers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martinisgroup/servers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martinisgroup/servers/git/refs{/sha}","trees_url":"https://api.github.com/repos/martinisgroup/servers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martinisgroup/servers/statuses/{sha}","languages_url":"https://api.github.com/repos/martinisgroup/servers/languages","stargazers_url":"https://api.github.com/repos/martinisgroup/servers/stargazers","contributors_url":"https://api.github.com/repos/martinisgroup/servers/contributors","subscribers_url":"https://api.github.com/repos/martinisgroup/servers/subscribers","subscription_url":"https://api.github.com/repos/martinisgroup/servers/subscription","commits_url":"https://api.github.com/repos/martinisgroup/servers/commits{/sha}","git_commits_url":"https://api.github.com/repos/martinisgroup/servers/git/commits{/sha}","comments_url":"https://api.github.com/repos/martinisgroup/servers/comments{/number}","issue_comment_url":"https://api.github.com/repos/martinisgroup/servers/issues/comments{/number}","contents_url":"https://api.github.com/repos/martinisgroup/servers/contents/{+path}","compare_url":"https://api.github.com/repos/martinisgroup/servers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martinisgroup/servers/merges","archive_url":"https://api.github.com/repos/martinisgroup/servers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martinisgroup/servers/downloads","issues_url":"https://api.github.com/repos/martinisgroup/servers/issues{/number}","pulls_url":"https://api.github.com/repos/martinisgroup/servers/pulls{/number}","milestones_url":"https://api.github.com/repos/martinisgroup/servers/milestones{/number}","notifications_url":"https://api.github.com/repos/martinisgroup/servers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martinisgroup/servers/labels{/name}","releases_url":"https://api.github.com/repos/martinisgroup/servers/releases{/id}","deployments_url":"https://api.github.com/repos/martinisgroup/servers/deployments","created_at":"2014-06-25T00:07:25Z","updated_at":"2016-02-03T23:29:43Z","pushed_at":"2016-06-22T01:20:20Z","git_url":"git://github.com/martinisgroup/servers.git","ssh_url":"git@github.com:martinisgroup/servers.git","clone_url":"https://github.com/martinisgroup/servers.git","svn_url":"https://github.com/martinisgroup/servers","homepage":"","size":53698,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":115,"forks":7,"open_issues":115,"watchers":6,"default_branch":"master"}},"base":{"label":"martinisgroup:master","ref":"master","sha":"743ed44e7748067508707f7ed735ea014d75465b","user":{"login":"martinisgroup","id":5026004,"avatar_url":"https://avatars.githubusercontent.com/u/5026004?v=3","gravatar_id":"","url":"https://api.github.com/users/martinisgroup","html_url":"https://github.com/martinisgroup","followers_url":"https://api.github.com/users/martinisgroup/followers","following_url":"https://api.github.com/users/martinisgroup/following{/other_user}","gists_url":"https://api.github.com/users/martinisgroup/gists{/gist_id}","starred_url":"https://api.github.com/users/martinisgroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinisgroup/subscriptions","organizations_url":"https://api.github.com/users/martinisgroup/orgs","repos_url":"https://api.github.com/users/martinisgroup/repos","events_url":"https://api.github.com/users/martinisgroup/events{/privacy}","received_events_url":"https://api.github.com/users/martinisgroup/received_events","type":"Organization","site_admin":false},"repo":{"id":21184808,"name":"servers","full_name":"martinisgroup/servers","owner":{"login":"martinisgroup","id":5026004,"avatar_url":"https://avatars.githubusercontent.com/u/5026004?v=3","gravatar_id":"","url":"https://api.github.com/users/martinisgroup","html_url":"https://github.com/martinisgroup","followers_url":"https://api.github.com/users/martinisgroup/followers","following_url":"https://api.github.com/users/martinisgroup/following{/other_user}","gists_url":"https://api.github.com/users/martinisgroup/gists{/gist_id}","starred_url":"https://api.github.com/users/martinisgroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinisgroup/subscriptions","organizations_url":"https://api.github.com/users/martinisgroup/orgs","repos_url":"https://api.github.com/users/martinisgroup/repos","events_url":"https://api.github.com/users/martinisgroup/events{/privacy}","received_events_url":"https://api.github.com/users/martinisgroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/martinisgroup/servers","description":"LabRAD servers","fork":false,"url":"https://api.github.com/repos/martinisgroup/servers","forks_url":"https://api.github.com/repos/martinisgroup/servers/forks","keys_url":"https://api.github.com/repos/martinisgroup/servers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martinisgroup/servers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martinisgroup/servers/teams","hooks_url":"https://api.github.com/repos/martinisgroup/servers/hooks","issue_events_url":"https://api.github.com/repos/martinisgroup/servers/issues/events{/number}","events_url":"https://api.github.com/repos/martinisgroup/servers/events","assignees_url":"https://api.github.com/repos/martinisgroup/servers/assignees{/user}","branches_url":"https://api.github.com/repos/martinisgroup/servers/branches{/branch}","tags_url":"https://api.github.com/repos/martinisgroup/servers/tags","blobs_url":"https://api.github.com/repos/martinisgroup/servers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martinisgroup/servers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martinisgroup/servers/git/refs{/sha}","trees_url":"https://api.github.com/repos/martinisgroup/servers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martinisgroup/servers/statuses/{sha}","languages_url":"https://api.github.com/repos/martinisgroup/servers/languages","stargazers_url":"https://api.github.com/repos/martinisgroup/servers/stargazers","contributors_url":"https://api.github.com/repos/martinisgroup/servers/contributors","subscribers_url":"https://api.github.com/repos/martinisgroup/servers/subscribers","subscription_url":"https://api.github.com/repos/martinisgroup/servers/subscription","commits_url":"https://api.github.com/repos/martinisgroup/servers/commits{/sha}","git_commits_url":"https://api.github.com/repos/martinisgroup/servers/git/commits{/sha}","comments_url":"https://api.github.com/repos/martinisgroup/servers/comments{/number}","issue_comment_url":"https://api.github.com/repos/martinisgroup/servers/issues/comments{/number}","contents_url":"https://api.github.com/repos/martinisgroup/servers/contents/{+path}","compare_url":"https://api.github.com/repos/martinisgroup/servers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martinisgroup/servers/merges","archive_url":"https://api.github.com/repos/martinisgroup/servers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martinisgroup/servers/downloads","issues_url":"https://api.github.com/repos/martinisgroup/servers/issues{/number}","pulls_url":"https://api.github.com/repos/martinisgroup/servers/pulls{/number}","milestones_url":"https://api.github.com/repos/martinisgroup/servers/milestones{/number}","notifications_url":"https://api.github.com/repos/martinisgroup/servers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martinisgroup/servers/labels{/name}","releases_url":"https://api.github.com/repos/martinisgroup/servers/releases{/id}","deployments_url":"https://api.github.com/repos/martinisgroup/servers/deployments","created_at":"2014-06-25T00:07:25Z","updated_at":"2016-02-03T23:29:43Z","pushed_at":"2016-06-22T01:20:20Z","git_url":"git://github.com/martinisgroup/servers.git","ssh_url":"git@github.com:martinisgroup/servers.git","clone_url":"https://github.com/martinisgroup/servers.git","svn_url":"https://github.com/martinisgroup/servers","homepage":"","size":53698,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":115,"forks":7,"open_issues":115,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/martinisgroup/servers/pulls/353"},"html":{"href":"https://github.com/martinisgroup/servers/pull/353"},"issue":{"href":"https://api.github.com/repos/martinisgroup/servers/issues/353"},"comments":{"href":"https://api.github.com/repos/martinisgroup/servers/issues/353/comments"},"review_comments":{"href":"https://api.github.com/repos/martinisgroup/servers/pulls/353/comments"},"review_comment":{"href":"https://api.github.com/repos/martinisgroup/servers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/martinisgroup/servers/pulls/353/commits"},"statuses":{"href":"https://api.github.com/repos/martinisgroup/servers/statuses/c4b32e120f7b66388e451d756b60082abb19c410"}}}}
{"actor":{"display_login":"maffoo"}}