{"action":"created","issue":{"url":"https://api.github.com/repos/paroga/cbor-js/issues/14","repository_url":"https://api.github.com/repos/paroga/cbor-js","labels_url":"https://api.github.com/repos/paroga/cbor-js/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/paroga/cbor-js/issues/14/comments","events_url":"https://api.github.com/repos/paroga/cbor-js/issues/14/events","html_url":"https://github.com/paroga/cbor-js/pull/14","id":176290985,"number":14,"title":"float 16 & 32 encoding, allowRemainingBytes option, new buffer allocation strategy","user":{"login":"TYoung86","id":6979049,"avatar_url":"https://avatars.githubusercontent.com/u/6979049?v=3","gravatar_id":"","url":"https://api.github.com/users/TYoung86","html_url":"https://github.com/TYoung86","followers_url":"https://api.github.com/users/TYoung86/followers","following_url":"https://api.github.com/users/TYoung86/following{/other_user}","gists_url":"https://api.github.com/users/TYoung86/gists{/gist_id}","starred_url":"https://api.github.com/users/TYoung86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TYoung86/subscriptions","organizations_url":"https://api.github.com/users/TYoung86/orgs","repos_url":"https://api.github.com/users/TYoung86/repos","events_url":"https://api.github.com/users/TYoung86/events{/privacy}","received_events_url":"https://api.github.com/users/TYoung86/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-09-12T04:09:01Z","updated_at":"2016-09-15T12:48:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/paroga/cbor-js/pulls/14","html_url":"https://github.com/paroga/cbor-js/pull/14","diff_url":"https://github.com/paroga/cbor-js/pull/14.diff","patch_url":"https://github.com/paroga/cbor-js/pull/14.patch"},"body":"switched from runtime allocation strategy to exact accounting allocation strategy\r\nthis removes some growth penalties, slicing, and buffer copies at the expense of iterating over the object being encoded twice (not sure if performance impact is beneficial, need to make benchmarks)\r\n\r\nsome methods have been renamed to reflect their intention\r\n\r\nI plan to change (and rename) appendUtf16Data to append chars to string instead of using String.fromCharCode.apply ; this strategy has improved performance in many other scenarios, but not sure of impact here\r\n\r\nI plan to add a small benchmark suite to the tests\r\n\r\ncode coverage needs to be improved, some methods need to be removed, some branches need to be refined\r\n\r\nforked from another fork to pull a string-to-integer key change\r\n\r\nmessed with the tests, added one, changed the forEach to a for loop (to access loop counter, but then did not use yet...) and lots of commented out console.log and console.error statements\r\n\r\n*allowRemainingBytes option not yet tested, default false"},"comment":{"url":"https://api.github.com/repos/paroga/cbor-js/issues/comments/247318477","html_url":"https://github.com/paroga/cbor-js/pull/14#issuecomment-247318477","issue_url":"https://api.github.com/repos/paroga/cbor-js/issues/14","id":247318477,"user":{"login":"TYoung86","id":6979049,"avatar_url":"https://avatars.githubusercontent.com/u/6979049?v=3","gravatar_id":"","url":"https://api.github.com/users/TYoung86","html_url":"https://github.com/TYoung86","followers_url":"https://api.github.com/users/TYoung86/followers","following_url":"https://api.github.com/users/TYoung86/following{/other_user}","gists_url":"https://api.github.com/users/TYoung86/gists{/gist_id}","starred_url":"https://api.github.com/users/TYoung86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TYoung86/subscriptions","organizations_url":"https://api.github.com/users/TYoung86/orgs","repos_url":"https://api.github.com/users/TYoung86/repos","events_url":"https://api.github.com/users/TYoung86/events{/privacy}","received_events_url":"https://api.github.com/users/TYoung86/received_events","type":"User","site_admin":false},"created_at":"2016-09-15T12:48:16Z","updated_at":"2016-09-15T12:48:16Z","body":"Yeah, I'll rebase and make the options change separate first. 2nd, float 16\nand 32 encoding.\n\nThe buffer allocation strategy changes the whole file. I'll keep it out\nuntil I have good code documentation on everything for a formal review.\n\nYou can close the pull request for this one.\n\nOn Sep 14, 2016 3:22 PM, \"Patrick Gansterer\" <notifications@github.com>\nwrote:\n\n> I merged already some of your changes into master. Could you rebase your\n> work on it and try to avoid changing nearly the whole file? That makes an\n> review nearly impossible.\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/paroga/cbor-js/pull/14#issuecomment-247125238>, or mute\n> the thread\n> <https://github.com/notifications/unsubscribe-auth/AGp96Sb8eTP1xd_siti67x-jHtEZyCsxks5qqEmJgaJpZM4J6OCo>\n> .\n>\n"}}
{"actor":{"display_login":"TYoung86"}}