{"action":"created","comment":{"url":"https://api.github.com/repos/nio-blocks/web_handler/pulls/comments/85170382","pull_request_review_id":5901212,"id":85170382,"diff_hunk":"@@ -1,27 +1,28 @@\n import json\n-from nio.common.block.base import Block\n-from nio.common.discovery import Discoverable, DiscoverableType\n-from nio.metadata.properties import VersionProperty, ExpressionProperty, \\\n+from nio.block.base import Block\n+from nio.util.discovery import discoverable\n+from nio.properties import VersionProperty, Property, \\\n     PropertyHolder, ListProperty\n from .broker import RequestResponseBroker\n \n \n class ResponseHeader(PropertyHolder):\n-    header_name = ExpressionProperty(title='Name', default='Content-Type')\n-    header_val = ExpressionProperty(title='Value', default='application/json')\n+    header_name = Property(title='Name', default='Content-Type')\n+    header_val = Property(title='Value', default='application/json')\n \n \n-@Discoverable(DiscoverableType.block)\n+@discoverable\n class WebOutput(Block):\n \n     version = VersionProperty('1.0.0')\n \n-    id_val = ExpressionProperty(title='Request ID', default='{{ $id }}')\n+    id_val = Property(title='Request ID', default='{{ $id }}')\n \n-    response_out = ExpressionProperty(title='Response Body', default='')\n-    response_status = ExpressionProperty(\n+    response_out = Property(title='Response Body', default='')\n+    response_status = Property(","path":"web_output_block.py","position":31,"original_position":31,"commit_id":"6f4e8a2094caebd8ae62137a2920cca35481e05b","original_commit_id":"6f4e8a2094caebd8ae62137a2920cca35481e05b","user":{"login":"hansmosh","id":5524215,"avatar_url":"https://avatars.githubusercontent.com/u/5524215?v=3","gravatar_id":"","url":"https://api.github.com/users/hansmosh","html_url":"https://github.com/hansmosh","followers_url":"https://api.github.com/users/hansmosh/followers","following_url":"https://api.github.com/users/hansmosh/following{/other_user}","gists_url":"https://api.github.com/users/hansmosh/gists{/gist_id}","starred_url":"https://api.github.com/users/hansmosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hansmosh/subscriptions","organizations_url":"https://api.github.com/users/hansmosh/orgs","repos_url":"https://api.github.com/users/hansmosh/repos","events_url":"https://api.github.com/users/hansmosh/events{/privacy}","received_events_url":"https://api.github.com/users/hansmosh/received_events","type":"User","site_admin":false},"body":"It could be, especially considering the code does `rsp_status = int(self.response_status(sig))`. It was previously an expression property so my upgrade script turns that into just `Property`. The only downside to making it an int property would be that it's difficult to set those as an expression with the current builder.","created_at":"2016-10-26T16:59:22Z","updated_at":"2016-10-26T16:59:22Z","html_url":"https://github.com/nio-blocks/web_handler/pull/4#discussion_r85170382","pull_request_url":"https://api.github.com/repos/nio-blocks/web_handler/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/nio-blocks/web_handler/pulls/comments/85170382"},"html":{"href":"https://github.com/nio-blocks/web_handler/pull/4#discussion_r85170382"},"pull_request":{"href":"https://api.github.com/repos/nio-blocks/web_handler/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/nio-blocks/web_handler/pulls/4","id":90913293,"html_url":"https://github.com/nio-blocks/web_handler/pull/4","diff_url":"https://github.com/nio-blocks/web_handler/pull/4.diff","patch_url":"https://github.com/nio-blocks/web_handler/pull/4.patch","issue_url":"https://api.github.com/repos/nio-blocks/web_handler/issues/4","number":4,"state":"open","locked":false,"title":"Upgrade block for nio2","user":{"login":"hansmosh","id":5524215,"avatar_url":"https://avatars.githubusercontent.com/u/5524215?v=3","gravatar_id":"","url":"https://api.github.com/users/hansmosh","html_url":"https://github.com/hansmosh","followers_url":"https://api.github.com/users/hansmosh/followers","following_url":"https://api.github.com/users/hansmosh/following{/other_user}","gists_url":"https://api.github.com/users/hansmosh/gists{/gist_id}","starred_url":"https://api.github.com/users/hansmosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hansmosh/subscriptions","organizations_url":"https://api.github.com/users/hansmosh/orgs","repos_url":"https://api.github.com/users/hansmosh/repos","events_url":"https://api.github.com/users/hansmosh/events{/privacy}","received_events_url":"https://api.github.com/users/hansmosh/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-25T23:51:54Z","updated_at":"2016-10-26T16:59:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ada856a7b82097581cf6d4567cc945d60ecab860","assignee":{"login":"hansmosh","id":5524215,"avatar_url":"https://avatars.githubusercontent.com/u/5524215?v=3","gravatar_id":"","url":"https://api.github.com/users/hansmosh","html_url":"https://github.com/hansmosh","followers_url":"https://api.github.com/users/hansmosh/followers","following_url":"https://api.github.com/users/hansmosh/following{/other_user}","gists_url":"https://api.github.com/users/hansmosh/gists{/gist_id}","starred_url":"https://api.github.com/users/hansmosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hansmosh/subscriptions","organizations_url":"https://api.github.com/users/hansmosh/orgs","repos_url":"https://api.github.com/users/hansmosh/repos","events_url":"https://api.github.com/users/hansmosh/events{/privacy}","received_events_url":"https://api.github.com/users/hansmosh/received_events","type":"User","site_admin":false},"assignees":[{"login":"hansmosh","id":5524215,"avatar_url":"https://avatars.githubusercontent.com/u/5524215?v=3","gravatar_id":"","url":"https://api.github.com/users/hansmosh","html_url":"https://github.com/hansmosh","followers_url":"https://api.github.com/users/hansmosh/followers","following_url":"https://api.github.com/users/hansmosh/following{/other_user}","gists_url":"https://api.github.com/users/hansmosh/gists{/gist_id}","starred_url":"https://api.github.com/users/hansmosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hansmosh/subscriptions","organizations_url":"https://api.github.com/users/hansmosh/orgs","repos_url":"https://api.github.com/users/hansmosh/repos","events_url":"https://api.github.com/users/hansmosh/events{/privacy}","received_events_url":"https://api.github.com/users/hansmosh/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nio-blocks/web_handler/pulls/4/commits","review_comments_url":"https://api.github.com/repos/nio-blocks/web_handler/pulls/4/comments","review_comment_url":"https://api.github.com/repos/nio-blocks/web_handler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nio-blocks/web_handler/issues/4/comments","statuses_url":"https://api.github.com/repos/nio-blocks/web_handler/statuses/6f4e8a2094caebd8ae62137a2920cca35481e05b","head":{"label":"nio-blocks:nio2-init","ref":"nio2-init","sha":"6f4e8a2094caebd8ae62137a2920cca35481e05b","user":{"login":"nio-blocks","id":7684467,"avatar_url":"https://avatars.githubusercontent.com/u/7684467?v=3","gravatar_id":"","url":"https://api.github.com/users/nio-blocks","html_url":"https://github.com/nio-blocks","followers_url":"https://api.github.com/users/nio-blocks/followers","following_url":"https://api.github.com/users/nio-blocks/following{/other_user}","gists_url":"https://api.github.com/users/nio-blocks/gists{/gist_id}","starred_url":"https://api.github.com/users/nio-blocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nio-blocks/subscriptions","organizations_url":"https://api.github.com/users/nio-blocks/orgs","repos_url":"https://api.github.com/users/nio-blocks/repos","events_url":"https://api.github.com/users/nio-blocks/events{/privacy}","received_events_url":"https://api.github.com/users/nio-blocks/received_events","type":"Organization","site_admin":false},"repo":{"id":37231927,"name":"web_handler","full_name":"nio-blocks/web_handler","owner":{"login":"nio-blocks","id":7684467,"avatar_url":"https://avatars.githubusercontent.com/u/7684467?v=3","gravatar_id":"","url":"https://api.github.com/users/nio-blocks","html_url":"https://github.com/nio-blocks","followers_url":"https://api.github.com/users/nio-blocks/followers","following_url":"https://api.github.com/users/nio-blocks/following{/other_user}","gists_url":"https://api.github.com/users/nio-blocks/gists{/gist_id}","starred_url":"https://api.github.com/users/nio-blocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nio-blocks/subscriptions","organizations_url":"https://api.github.com/users/nio-blocks/orgs","repos_url":"https://api.github.com/users/nio-blocks/repos","events_url":"https://api.github.com/users/nio-blocks/events{/privacy}","received_events_url":"https://api.github.com/users/nio-blocks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nio-blocks/web_handler","description":"Handle HTTP requests and build your own API","fork":false,"url":"https://api.github.com/repos/nio-blocks/web_handler","forks_url":"https://api.github.com/repos/nio-blocks/web_handler/forks","keys_url":"https://api.github.com/repos/nio-blocks/web_handler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nio-blocks/web_handler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nio-blocks/web_handler/teams","hooks_url":"https://api.github.com/repos/nio-blocks/web_handler/hooks","issue_events_url":"https://api.github.com/repos/nio-blocks/web_handler/issues/events{/number}","events_url":"https://api.github.com/repos/nio-blocks/web_handler/events","assignees_url":"https://api.github.com/repos/nio-blocks/web_handler/assignees{/user}","branches_url":"https://api.github.com/repos/nio-blocks/web_handler/branches{/branch}","tags_url":"https://api.github.com/repos/nio-blocks/web_handler/tags","blobs_url":"https://api.github.com/repos/nio-blocks/web_handler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nio-blocks/web_handler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nio-blocks/web_handler/git/refs{/sha}","trees_url":"https://api.github.com/repos/nio-blocks/web_handler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nio-blocks/web_handler/statuses/{sha}","languages_url":"https://api.github.com/repos/nio-blocks/web_handler/languages","stargazers_url":"https://api.github.com/repos/nio-blocks/web_handler/stargazers","contributors_url":"https://api.github.com/repos/nio-blocks/web_handler/contributors","subscribers_url":"https://api.github.com/repos/nio-blocks/web_handler/subscribers","subscription_url":"https://api.github.com/repos/nio-blocks/web_handler/subscription","commits_url":"https://api.github.com/repos/nio-blocks/web_handler/commits{/sha}","git_commits_url":"https://api.github.com/repos/nio-blocks/web_handler/git/commits{/sha}","comments_url":"https://api.github.com/repos/nio-blocks/web_handler/comments{/number}","issue_comment_url":"https://api.github.com/repos/nio-blocks/web_handler/issues/comments{/number}","contents_url":"https://api.github.com/repos/nio-blocks/web_handler/contents/{+path}","compare_url":"https://api.github.com/repos/nio-blocks/web_handler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nio-blocks/web_handler/merges","archive_url":"https://api.github.com/repos/nio-blocks/web_handler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nio-blocks/web_handler/downloads","issues_url":"https://api.github.com/repos/nio-blocks/web_handler/issues{/number}","pulls_url":"https://api.github.com/repos/nio-blocks/web_handler/pulls{/number}","milestones_url":"https://api.github.com/repos/nio-blocks/web_handler/milestones{/number}","notifications_url":"https://api.github.com/repos/nio-blocks/web_handler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nio-blocks/web_handler/labels{/name}","releases_url":"https://api.github.com/repos/nio-blocks/web_handler/releases{/id}","deployments_url":"https://api.github.com/repos/nio-blocks/web_handler/deployments","created_at":"2015-06-11T01:20:16Z","updated_at":"2015-06-11T01:21:42Z","pushed_at":"2016-10-25T23:51:54Z","git_url":"git://github.com/nio-blocks/web_handler.git","ssh_url":"git@github.com:nio-blocks/web_handler.git","clone_url":"https://github.com/nio-blocks/web_handler.git","svn_url":"https://github.com/nio-blocks/web_handler","homepage":null,"size":28,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"nio-blocks:nio2","ref":"nio2","sha":"351287d83d3adf9c6246f290efc72c95438c8d3c","user":{"login":"nio-blocks","id":7684467,"avatar_url":"https://avatars.githubusercontent.com/u/7684467?v=3","gravatar_id":"","url":"https://api.github.com/users/nio-blocks","html_url":"https://github.com/nio-blocks","followers_url":"https://api.github.com/users/nio-blocks/followers","following_url":"https://api.github.com/users/nio-blocks/following{/other_user}","gists_url":"https://api.github.com/users/nio-blocks/gists{/gist_id}","starred_url":"https://api.github.com/users/nio-blocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nio-blocks/subscriptions","organizations_url":"https://api.github.com/users/nio-blocks/orgs","repos_url":"https://api.github.com/users/nio-blocks/repos","events_url":"https://api.github.com/users/nio-blocks/events{/privacy}","received_events_url":"https://api.github.com/users/nio-blocks/received_events","type":"Organization","site_admin":false},"repo":{"id":37231927,"name":"web_handler","full_name":"nio-blocks/web_handler","owner":{"login":"nio-blocks","id":7684467,"avatar_url":"https://avatars.githubusercontent.com/u/7684467?v=3","gravatar_id":"","url":"https://api.github.com/users/nio-blocks","html_url":"https://github.com/nio-blocks","followers_url":"https://api.github.com/users/nio-blocks/followers","following_url":"https://api.github.com/users/nio-blocks/following{/other_user}","gists_url":"https://api.github.com/users/nio-blocks/gists{/gist_id}","starred_url":"https://api.github.com/users/nio-blocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nio-blocks/subscriptions","organizations_url":"https://api.github.com/users/nio-blocks/orgs","repos_url":"https://api.github.com/users/nio-blocks/repos","events_url":"https://api.github.com/users/nio-blocks/events{/privacy}","received_events_url":"https://api.github.com/users/nio-blocks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nio-blocks/web_handler","description":"Handle HTTP requests and build your own API","fork":false,"url":"https://api.github.com/repos/nio-blocks/web_handler","forks_url":"https://api.github.com/repos/nio-blocks/web_handler/forks","keys_url":"https://api.github.com/repos/nio-blocks/web_handler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nio-blocks/web_handler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nio-blocks/web_handler/teams","hooks_url":"https://api.github.com/repos/nio-blocks/web_handler/hooks","issue_events_url":"https://api.github.com/repos/nio-blocks/web_handler/issues/events{/number}","events_url":"https://api.github.com/repos/nio-blocks/web_handler/events","assignees_url":"https://api.github.com/repos/nio-blocks/web_handler/assignees{/user}","branches_url":"https://api.github.com/repos/nio-blocks/web_handler/branches{/branch}","tags_url":"https://api.github.com/repos/nio-blocks/web_handler/tags","blobs_url":"https://api.github.com/repos/nio-blocks/web_handler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nio-blocks/web_handler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nio-blocks/web_handler/git/refs{/sha}","trees_url":"https://api.github.com/repos/nio-blocks/web_handler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nio-blocks/web_handler/statuses/{sha}","languages_url":"https://api.github.com/repos/nio-blocks/web_handler/languages","stargazers_url":"https://api.github.com/repos/nio-blocks/web_handler/stargazers","contributors_url":"https://api.github.com/repos/nio-blocks/web_handler/contributors","subscribers_url":"https://api.github.com/repos/nio-blocks/web_handler/subscribers","subscription_url":"https://api.github.com/repos/nio-blocks/web_handler/subscription","commits_url":"https://api.github.com/repos/nio-blocks/web_handler/commits{/sha}","git_commits_url":"https://api.github.com/repos/nio-blocks/web_handler/git/commits{/sha}","comments_url":"https://api.github.com/repos/nio-blocks/web_handler/comments{/number}","issue_comment_url":"https://api.github.com/repos/nio-blocks/web_handler/issues/comments{/number}","contents_url":"https://api.github.com/repos/nio-blocks/web_handler/contents/{+path}","compare_url":"https://api.github.com/repos/nio-blocks/web_handler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nio-blocks/web_handler/merges","archive_url":"https://api.github.com/repos/nio-blocks/web_handler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nio-blocks/web_handler/downloads","issues_url":"https://api.github.com/repos/nio-blocks/web_handler/issues{/number}","pulls_url":"https://api.github.com/repos/nio-blocks/web_handler/pulls{/number}","milestones_url":"https://api.github.com/repos/nio-blocks/web_handler/milestones{/number}","notifications_url":"https://api.github.com/repos/nio-blocks/web_handler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nio-blocks/web_handler/labels{/name}","releases_url":"https://api.github.com/repos/nio-blocks/web_handler/releases{/id}","deployments_url":"https://api.github.com/repos/nio-blocks/web_handler/deployments","created_at":"2015-06-11T01:20:16Z","updated_at":"2015-06-11T01:21:42Z","pushed_at":"2016-10-25T23:51:54Z","git_url":"git://github.com/nio-blocks/web_handler.git","ssh_url":"git@github.com:nio-blocks/web_handler.git","clone_url":"https://github.com/nio-blocks/web_handler.git","svn_url":"https://github.com/nio-blocks/web_handler","homepage":null,"size":28,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nio-blocks/web_handler/pulls/4"},"html":{"href":"https://github.com/nio-blocks/web_handler/pull/4"},"issue":{"href":"https://api.github.com/repos/nio-blocks/web_handler/issues/4"},"comments":{"href":"https://api.github.com/repos/nio-blocks/web_handler/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/nio-blocks/web_handler/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/nio-blocks/web_handler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nio-blocks/web_handler/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/nio-blocks/web_handler/statuses/6f4e8a2094caebd8ae62137a2920cca35481e05b"}}}}
{"actor":{"display_login":"hansmosh"}}