{"action":"created","comment":{"url":"https://api.github.com/repos/apollostack/apollo-android/pulls/comments/93792992","pull_request_review_id":14329705,"id":93792992,"diff_hunk":"@@ -0,0 +1,26 @@\n+package com.example.apollostack.sample;\n+\n+import com.google.auto.value.AutoValue;\n+\n+import com.squareup.moshi.JsonAdapter;\n+import com.squareup.moshi.Moshi;\n+\n+import javax.annotation.Nullable;\n+\n+import generatedIR.DroidDetails;\n+\n+@AutoValue\n+public abstract class DroidDetailsData implements DroidDetails.Data {\n+  @Override @Nullable public abstract Species species();\n+\n+  public static JsonAdapter<DroidDetailsData> jsonAdapter(Moshi moshi) {\n+    return new AutoValue_DroidDetailsData.MoshiJsonAdapter(moshi);\n+  }\n+\n+  @AutoValue\n+  public abstract static class Species implements Specy {","path":"apollo-sample/src/main/java/com/example/apollostack/sample/DroidDetailsData.java","position":21,"original_position":21,"commit_id":"2a5fe56e9d822b8b3574f351e64bbfeabd623a38","original_commit_id":"2a5fe56e9d822b8b3574f351e64bbfeabd623a38","user":{"login":"felipecsl","id":190648,"avatar_url":"https://avatars.githubusercontent.com/u/190648?v=3","gravatar_id":"","url":"https://api.github.com/users/felipecsl","html_url":"https://github.com/felipecsl","followers_url":"https://api.github.com/users/felipecsl/followers","following_url":"https://api.github.com/users/felipecsl/following{/other_user}","gists_url":"https://api.github.com/users/felipecsl/gists{/gist_id}","starred_url":"https://api.github.com/users/felipecsl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felipecsl/subscriptions","organizations_url":"https://api.github.com/users/felipecsl/orgs","repos_url":"https://api.github.com/users/felipecsl/repos","events_url":"https://api.github.com/users/felipecsl/events{/privacy}","received_events_url":"https://api.github.com/users/felipecsl/received_events","type":"User","site_admin":false},"body":"Ah dammit, good catch @marwanad, I'll create an issue for this","created_at":"2016-12-23T18:46:07Z","updated_at":"2016-12-23T18:46:07Z","html_url":"https://github.com/apollostack/apollo-android/pull/73#discussion_r93792992","pull_request_url":"https://api.github.com/repos/apollostack/apollo-android/pulls/73","_links":{"self":{"href":"https://api.github.com/repos/apollostack/apollo-android/pulls/comments/93792992"},"html":{"href":"https://github.com/apollostack/apollo-android/pull/73#discussion_r93792992"},"pull_request":{"href":"https://api.github.com/repos/apollostack/apollo-android/pulls/73"}}},"pull_request":{"url":"https://api.github.com/repos/apollostack/apollo-android/pulls/73","id":99191834,"html_url":"https://github.com/apollostack/apollo-android/pull/73","diff_url":"https://github.com/apollostack/apollo-android/pull/73.diff","patch_url":"https://github.com/apollostack/apollo-android/pull/73.patch","issue_url":"https://api.github.com/repos/apollostack/apollo-android/issues/73","number":73,"state":"closed","locked":false,"title":"[Sample] Make the sample display the response","user":{"login":"felipecsl","id":190648,"avatar_url":"https://avatars.githubusercontent.com/u/190648?v=3","gravatar_id":"","url":"https://api.github.com/users/felipecsl","html_url":"https://github.com/felipecsl","followers_url":"https://api.github.com/users/felipecsl/followers","following_url":"https://api.github.com/users/felipecsl/following{/other_user}","gists_url":"https://api.github.com/users/felipecsl/gists{/gist_id}","starred_url":"https://api.github.com/users/felipecsl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felipecsl/subscriptions","organizations_url":"https://api.github.com/users/felipecsl/orgs","repos_url":"https://api.github.com/users/felipecsl/repos","events_url":"https://api.github.com/users/felipecsl/events{/privacy}","received_events_url":"https://api.github.com/users/felipecsl/received_events","type":"User","site_admin":false},"body":"It actually works 😄 \r\n\r\n## GraphiQL:\r\n\r\n![image](https://cloud.githubusercontent.com/assets/190648/21444858/19f1b2f2-c867-11e6-8b2b-093e9217c281.png)\r\n\r\n## Android emulator: \r\n\r\n![image](https://cloud.githubusercontent.com/assets/190648/21444823/bb588b9e-c866-11e6-8a34-1e8cffb30919.png)\r\n\r\nI had to make one change to `GraphQLID` to treat it as String instead of `long`. According to the spec:\r\n\r\n```\r\nThe ID scalar type represents a unique identifier, often used to refetch an object or\r\n as the key for a cache. The ID type is serialized in the same way as a String; however, \r\nit is not intended to be human‐readable. While it is often numeric, it should always \r\nserialize as a String.\r\n```\r\n\r\nAnnotating the interfaces with `@AutoValue` was actually not a lot of work and I think this is a totally acceptable use case. \r\nGoing back to the debate about generating classes vs. interfaces, I think we should keep generating the interfaces as we are right now and generate POJOs as an opt-in, so we don't ruin the AutoValue use case.","created_at":"2016-12-23T00:53:19Z","updated_at":"2016-12-23T18:46:07Z","closed_at":"2016-12-23T06:09:52Z","merged_at":"2016-12-23T06:09:52Z","merge_commit_sha":"c6fb140d13bb285a25989358242a17617387fae8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apollostack/apollo-android/pulls/73/commits","review_comments_url":"https://api.github.com/repos/apollostack/apollo-android/pulls/73/comments","review_comment_url":"https://api.github.com/repos/apollostack/apollo-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apollostack/apollo-android/issues/73/comments","statuses_url":"https://api.github.com/repos/apollostack/apollo-android/statuses/2a5fe56e9d822b8b3574f351e64bbfeabd623a38","head":{"label":"apollostack:felipe/flesh-out-sample","ref":"felipe/flesh-out-sample","sha":"2a5fe56e9d822b8b3574f351e64bbfeabd623a38","user":{"login":"apollostack","id":17189275,"avatar_url":"https://avatars.githubusercontent.com/u/17189275?v=3","gravatar_id":"","url":"https://api.github.com/users/apollostack","html_url":"https://github.com/apollostack","followers_url":"https://api.github.com/users/apollostack/followers","following_url":"https://api.github.com/users/apollostack/following{/other_user}","gists_url":"https://api.github.com/users/apollostack/gists{/gist_id}","starred_url":"https://api.github.com/users/apollostack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollostack/subscriptions","organizations_url":"https://api.github.com/users/apollostack/orgs","repos_url":"https://api.github.com/users/apollostack/repos","events_url":"https://api.github.com/users/apollostack/events{/privacy}","received_events_url":"https://api.github.com/users/apollostack/received_events","type":"Organization","site_admin":false},"repo":{"id":69469299,"name":"apollo-android","full_name":"apollostack/apollo-android","owner":{"login":"apollostack","id":17189275,"avatar_url":"https://avatars.githubusercontent.com/u/17189275?v=3","gravatar_id":"","url":"https://api.github.com/users/apollostack","html_url":"https://github.com/apollostack","followers_url":"https://api.github.com/users/apollostack/followers","following_url":"https://api.github.com/users/apollostack/following{/other_user}","gists_url":"https://api.github.com/users/apollostack/gists{/gist_id}","starred_url":"https://api.github.com/users/apollostack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollostack/subscriptions","organizations_url":"https://api.github.com/users/apollostack/orgs","repos_url":"https://api.github.com/users/apollostack/repos","events_url":"https://api.github.com/users/apollostack/events{/privacy}","received_events_url":"https://api.github.com/users/apollostack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apollostack/apollo-android","description":":pager: A GraphQL client for Android (WIP)","fork":false,"url":"https://api.github.com/repos/apollostack/apollo-android","forks_url":"https://api.github.com/repos/apollostack/apollo-android/forks","keys_url":"https://api.github.com/repos/apollostack/apollo-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apollostack/apollo-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apollostack/apollo-android/teams","hooks_url":"https://api.github.com/repos/apollostack/apollo-android/hooks","issue_events_url":"https://api.github.com/repos/apollostack/apollo-android/issues/events{/number}","events_url":"https://api.github.com/repos/apollostack/apollo-android/events","assignees_url":"https://api.github.com/repos/apollostack/apollo-android/assignees{/user}","branches_url":"https://api.github.com/repos/apollostack/apollo-android/branches{/branch}","tags_url":"https://api.github.com/repos/apollostack/apollo-android/tags","blobs_url":"https://api.github.com/repos/apollostack/apollo-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apollostack/apollo-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apollostack/apollo-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/apollostack/apollo-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apollostack/apollo-android/statuses/{sha}","languages_url":"https://api.github.com/repos/apollostack/apollo-android/languages","stargazers_url":"https://api.github.com/repos/apollostack/apollo-android/stargazers","contributors_url":"https://api.github.com/repos/apollostack/apollo-android/contributors","subscribers_url":"https://api.github.com/repos/apollostack/apollo-android/subscribers","subscription_url":"https://api.github.com/repos/apollostack/apollo-android/subscription","commits_url":"https://api.github.com/repos/apollostack/apollo-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/apollostack/apollo-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/apollostack/apollo-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/apollostack/apollo-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/apollostack/apollo-android/contents/{+path}","compare_url":"https://api.github.com/repos/apollostack/apollo-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apollostack/apollo-android/merges","archive_url":"https://api.github.com/repos/apollostack/apollo-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apollostack/apollo-android/downloads","issues_url":"https://api.github.com/repos/apollostack/apollo-android/issues{/number}","pulls_url":"https://api.github.com/repos/apollostack/apollo-android/pulls{/number}","milestones_url":"https://api.github.com/repos/apollostack/apollo-android/milestones{/number}","notifications_url":"https://api.github.com/repos/apollostack/apollo-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apollostack/apollo-android/labels{/name}","releases_url":"https://api.github.com/repos/apollostack/apollo-android/releases{/id}","deployments_url":"https://api.github.com/repos/apollostack/apollo-android/deployments","created_at":"2016-09-28T14:03:30Z","updated_at":"2016-12-23T17:02:34Z","pushed_at":"2016-12-23T18:45:30Z","git_url":"git://github.com/apollostack/apollo-android.git","ssh_url":"git@github.com:apollostack/apollo-android.git","clone_url":"https://github.com/apollostack/apollo-android.git","svn_url":"https://github.com/apollostack/apollo-android","homepage":"","size":197256,"stargazers_count":46,"watchers_count":46,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":11,"forks":5,"open_issues":11,"watchers":46,"default_branch":"master"}},"base":{"label":"apollostack:master","ref":"master","sha":"d533446e74d388effde15da30cda1426d558bbe1","user":{"login":"apollostack","id":17189275,"avatar_url":"https://avatars.githubusercontent.com/u/17189275?v=3","gravatar_id":"","url":"https://api.github.com/users/apollostack","html_url":"https://github.com/apollostack","followers_url":"https://api.github.com/users/apollostack/followers","following_url":"https://api.github.com/users/apollostack/following{/other_user}","gists_url":"https://api.github.com/users/apollostack/gists{/gist_id}","starred_url":"https://api.github.com/users/apollostack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollostack/subscriptions","organizations_url":"https://api.github.com/users/apollostack/orgs","repos_url":"https://api.github.com/users/apollostack/repos","events_url":"https://api.github.com/users/apollostack/events{/privacy}","received_events_url":"https://api.github.com/users/apollostack/received_events","type":"Organization","site_admin":false},"repo":{"id":69469299,"name":"apollo-android","full_name":"apollostack/apollo-android","owner":{"login":"apollostack","id":17189275,"avatar_url":"https://avatars.githubusercontent.com/u/17189275?v=3","gravatar_id":"","url":"https://api.github.com/users/apollostack","html_url":"https://github.com/apollostack","followers_url":"https://api.github.com/users/apollostack/followers","following_url":"https://api.github.com/users/apollostack/following{/other_user}","gists_url":"https://api.github.com/users/apollostack/gists{/gist_id}","starred_url":"https://api.github.com/users/apollostack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollostack/subscriptions","organizations_url":"https://api.github.com/users/apollostack/orgs","repos_url":"https://api.github.com/users/apollostack/repos","events_url":"https://api.github.com/users/apollostack/events{/privacy}","received_events_url":"https://api.github.com/users/apollostack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apollostack/apollo-android","description":":pager: A GraphQL client for Android (WIP)","fork":false,"url":"https://api.github.com/repos/apollostack/apollo-android","forks_url":"https://api.github.com/repos/apollostack/apollo-android/forks","keys_url":"https://api.github.com/repos/apollostack/apollo-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apollostack/apollo-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apollostack/apollo-android/teams","hooks_url":"https://api.github.com/repos/apollostack/apollo-android/hooks","issue_events_url":"https://api.github.com/repos/apollostack/apollo-android/issues/events{/number}","events_url":"https://api.github.com/repos/apollostack/apollo-android/events","assignees_url":"https://api.github.com/repos/apollostack/apollo-android/assignees{/user}","branches_url":"https://api.github.com/repos/apollostack/apollo-android/branches{/branch}","tags_url":"https://api.github.com/repos/apollostack/apollo-android/tags","blobs_url":"https://api.github.com/repos/apollostack/apollo-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apollostack/apollo-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apollostack/apollo-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/apollostack/apollo-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apollostack/apollo-android/statuses/{sha}","languages_url":"https://api.github.com/repos/apollostack/apollo-android/languages","stargazers_url":"https://api.github.com/repos/apollostack/apollo-android/stargazers","contributors_url":"https://api.github.com/repos/apollostack/apollo-android/contributors","subscribers_url":"https://api.github.com/repos/apollostack/apollo-android/subscribers","subscription_url":"https://api.github.com/repos/apollostack/apollo-android/subscription","commits_url":"https://api.github.com/repos/apollostack/apollo-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/apollostack/apollo-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/apollostack/apollo-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/apollostack/apollo-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/apollostack/apollo-android/contents/{+path}","compare_url":"https://api.github.com/repos/apollostack/apollo-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apollostack/apollo-android/merges","archive_url":"https://api.github.com/repos/apollostack/apollo-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apollostack/apollo-android/downloads","issues_url":"https://api.github.com/repos/apollostack/apollo-android/issues{/number}","pulls_url":"https://api.github.com/repos/apollostack/apollo-android/pulls{/number}","milestones_url":"https://api.github.com/repos/apollostack/apollo-android/milestones{/number}","notifications_url":"https://api.github.com/repos/apollostack/apollo-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apollostack/apollo-android/labels{/name}","releases_url":"https://api.github.com/repos/apollostack/apollo-android/releases{/id}","deployments_url":"https://api.github.com/repos/apollostack/apollo-android/deployments","created_at":"2016-09-28T14:03:30Z","updated_at":"2016-12-23T17:02:34Z","pushed_at":"2016-12-23T18:45:30Z","git_url":"git://github.com/apollostack/apollo-android.git","ssh_url":"git@github.com:apollostack/apollo-android.git","clone_url":"https://github.com/apollostack/apollo-android.git","svn_url":"https://github.com/apollostack/apollo-android","homepage":"","size":197256,"stargazers_count":46,"watchers_count":46,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":11,"forks":5,"open_issues":11,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apollostack/apollo-android/pulls/73"},"html":{"href":"https://github.com/apollostack/apollo-android/pull/73"},"issue":{"href":"https://api.github.com/repos/apollostack/apollo-android/issues/73"},"comments":{"href":"https://api.github.com/repos/apollostack/apollo-android/issues/73/comments"},"review_comments":{"href":"https://api.github.com/repos/apollostack/apollo-android/pulls/73/comments"},"review_comment":{"href":"https://api.github.com/repos/apollostack/apollo-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apollostack/apollo-android/pulls/73/commits"},"statuses":{"href":"https://api.github.com/repos/apollostack/apollo-android/statuses/2a5fe56e9d822b8b3574f351e64bbfeabd623a38"}}}}
{"actor":{"display_login":"felipecsl"}}