{"action":"closed","issue":{"url":"https://api.github.com/repos/SaschaWillems/Vulkan/issues/172","repository_url":"https://api.github.com/repos/SaschaWillems/Vulkan","labels_url":"https://api.github.com/repos/SaschaWillems/Vulkan/issues/172/labels{/name}","comments_url":"https://api.github.com/repos/SaschaWillems/Vulkan/issues/172/comments","events_url":"https://api.github.com/repos/SaschaWillems/Vulkan/issues/172/events","html_url":"https://github.com/SaschaWillems/Vulkan/issues/172","id":158307424,"number":172,"title":"When allocating memory for the image in vulkantextoverlay.hpp the wrong memory requirements are used","user":{"login":"jherico","id":1533642,"avatar_url":"https://avatars.githubusercontent.com/u/1533642?v=3","gravatar_id":"","url":"https://api.github.com/users/jherico","html_url":"https://github.com/jherico","followers_url":"https://api.github.com/users/jherico/followers","following_url":"https://api.github.com/users/jherico/following{/other_user}","gists_url":"https://api.github.com/users/jherico/gists{/gist_id}","starred_url":"https://api.github.com/users/jherico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jherico/subscriptions","organizations_url":"https://api.github.com/users/jherico/orgs","repos_url":"https://api.github.com/users/jherico/repos","events_url":"https://api.github.com/users/jherico/events{/privacy}","received_events_url":"https://api.github.com/users/jherico/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-06-03T07:28:54Z","updated_at":"2016-06-03T10:20:13Z","closed_at":"2016-06-03T10:20:13Z","body":"On line 213 of vulkantextoverlay.hpp you get the required memory type for the image:\r\n\r\n```\r\nallocInfo.memoryTypeIndex = getMemoryType(\r\n   memReqs.memoryTypeBits,  \r\n   VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT);\r\n```\r\n\r\nHowever, the memReqs structure still contains the data fetched for the buffer allocated above in this line `vkGetBufferMemoryRequirements(device, buffer, &memReqs);`\r\n\r\nThere should be a corresponding call to `vkGetImageMemoryRequirements(device, image, &memReqs);` but there is not.\r\n\r\n"}}
{"actor":{"display_login":"SaschaWillems"}}