{"action":"created","comment":{"url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments/76435976","id":76435976,"diff_hunk":"@@ -126,30 +148,51 @@ public void handleResult(OperationContext.ResultAction resultAction, OperationCo\n         }, OperationContext.Stage.MODEL);\n     }\n \n-    private Map<String, Boolean> determineServerStateChanges(OperationContext context, Resource domainRootResource, ServerOperationResolver resolver,\n-                                                             ContentDownloader contentDownloader) {\n-        final Map<String, Boolean> serverStateChanges = new HashMap<>();\n+    private Map<String, SyncServerResultAction> determineServerStateChanges(final OperationContext context, final Resource domainRootResource, final ServerOperationResolver resolver,\n+                                                                            final ContentDownloader contentDownloader) {\n+        final Map<String, SyncServerResultAction> serverStateChanges = new HashMap<>();\n         for (ModelNode operation : operations) {\n-            PathAddress addr = PathAddress.pathAddress(operation.get(OP_ADDR));\n+            final PathAddress addr = PathAddress.pathAddress(operation.get(OP_ADDR));\n             contentDownloader.checkContent(operation, addr);\n-\n-            Map<Set<ServerIdentity>, ModelNode> serverMap = resolver.getServerOperations(context, operation, addr);\n+            final ImmutableManagementResourceRegistration registration = context.getResourceRegistration();\n+            final Map<Set<ServerIdentity>, ModelNode> serverMap = resolver.getServerOperations(context, operation, addr);\n             for (Map.Entry<Set<ServerIdentity>, ModelNode> entry : serverMap.entrySet()) {\n-                ModelNode op = entry.getValue();\n-                boolean restart = op.get(OP).asString().equals(ServerProcessStateHandler.REQUIRE_RESTART_OPERATION);","path":"host-controller/src/main/java/org/jboss/as/domain/controller/operations/SyncServerStateOperationHandler.java","position":136,"original_position":136,"commit_id":"69e527d47c61473357283aaecb9313cc2e82d431","original_commit_id":"69e527d47c61473357283aaecb9313cc2e82d431","user":{"login":"bstansberry","id":299242,"avatar_url":"https://avatars.githubusercontent.com/u/299242?v=3","gravatar_id":"","url":"https://api.github.com/users/bstansberry","html_url":"https://github.com/bstansberry","followers_url":"https://api.github.com/users/bstansberry/followers","following_url":"https://api.github.com/users/bstansberry/following{/other_user}","gists_url":"https://api.github.com/users/bstansberry/gists{/gist_id}","starred_url":"https://api.github.com/users/bstansberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstansberry/subscriptions","organizations_url":"https://api.github.com/users/bstansberry/orgs","repos_url":"https://api.github.com/users/bstansberry/repos","events_url":"https://api.github.com/users/bstansberry/events{/privacy}","received_events_url":"https://api.github.com/users/bstansberry/received_events","type":"User","site_admin":false},"body":"Further to this, ServerOperationResolver can also return ServerProcessStateHandler.REQUIRE_RELOAD_OPERATION. In this case I *believe* it is fine to accept that result, use SyncServerResultAction.RELOAD_REQUIRED, and skip your new stuff. This needs a bit of confirmation, but I think ServerOperationResolver would not return ServerProcessStateHandler.REQUIRE_RELOAD_OPERATION for an op where actually a restart is needed. It's all custom logic meant for these kind of cases and when it does something specific like this we can just trust it.","created_at":"2016-08-26T15:16:49Z","updated_at":"2016-08-26T15:16:49Z","html_url":"https://github.com/wildfly/wildfly-core/pull/1754#discussion_r76435976","pull_request_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1754","_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments/76435976"},"html":{"href":"https://github.com/wildfly/wildfly-core/pull/1754#discussion_r76435976"},"pull_request":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1754"}}},"pull_request":{"url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1754","id":82764365,"html_url":"https://github.com/wildfly/wildfly-core/pull/1754","diff_url":"https://github.com/wildfly/wildfly-core/pull/1754.diff","patch_url":"https://github.com/wildfly/wildfly-core/pull/1754.patch","issue_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/1754","number":1754,"state":"open","locked":false,"title":"WFCORE-1733 SynchServerOperationHandler op and attribute restart-required checking","user":{"login":"luck3y","id":390016,"avatar_url":"https://avatars.githubusercontent.com/u/390016?v=3","gravatar_id":"","url":"https://api.github.com/users/luck3y","html_url":"https://github.com/luck3y","followers_url":"https://api.github.com/users/luck3y/followers","following_url":"https://api.github.com/users/luck3y/following{/other_user}","gists_url":"https://api.github.com/users/luck3y/gists{/gist_id}","starred_url":"https://api.github.com/users/luck3y/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luck3y/subscriptions","organizations_url":"https://api.github.com/users/luck3y/orgs","repos_url":"https://api.github.com/users/luck3y/repos","events_url":"https://api.github.com/users/luck3y/events{/privacy}","received_events_url":"https://api.github.com/users/luck3y/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-25T17:54:35Z","updated_at":"2016-08-26T15:16:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3591dd717b95547ddada02156ed86816226b8e6d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1754/commits","review_comments_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1754/comments","review_comment_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/1754/comments","statuses_url":"https://api.github.com/repos/wildfly/wildfly-core/statuses/69e527d47c61473357283aaecb9313cc2e82d431","head":{"label":"luck3y:WFCORE-1733","ref":"WFCORE-1733","sha":"69e527d47c61473357283aaecb9313cc2e82d431","user":{"login":"luck3y","id":390016,"avatar_url":"https://avatars.githubusercontent.com/u/390016?v=3","gravatar_id":"","url":"https://api.github.com/users/luck3y","html_url":"https://github.com/luck3y","followers_url":"https://api.github.com/users/luck3y/followers","following_url":"https://api.github.com/users/luck3y/following{/other_user}","gists_url":"https://api.github.com/users/luck3y/gists{/gist_id}","starred_url":"https://api.github.com/users/luck3y/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luck3y/subscriptions","organizations_url":"https://api.github.com/users/luck3y/orgs","repos_url":"https://api.github.com/users/luck3y/repos","events_url":"https://api.github.com/users/luck3y/events{/privacy}","received_events_url":"https://api.github.com/users/luck3y/received_events","type":"User","site_admin":false},"repo":{"id":39265039,"name":"wildfly-core","full_name":"luck3y/wildfly-core","owner":{"login":"luck3y","id":390016,"avatar_url":"https://avatars.githubusercontent.com/u/390016?v=3","gravatar_id":"","url":"https://api.github.com/users/luck3y","html_url":"https://github.com/luck3y","followers_url":"https://api.github.com/users/luck3y/followers","following_url":"https://api.github.com/users/luck3y/following{/other_user}","gists_url":"https://api.github.com/users/luck3y/gists{/gist_id}","starred_url":"https://api.github.com/users/luck3y/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luck3y/subscriptions","organizations_url":"https://api.github.com/users/luck3y/orgs","repos_url":"https://api.github.com/users/luck3y/repos","events_url":"https://api.github.com/users/luck3y/events{/privacy}","received_events_url":"https://api.github.com/users/luck3y/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/luck3y/wildfly-core","description":"The core runtime that is used by the Wildfly application server","fork":true,"url":"https://api.github.com/repos/luck3y/wildfly-core","forks_url":"https://api.github.com/repos/luck3y/wildfly-core/forks","keys_url":"https://api.github.com/repos/luck3y/wildfly-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luck3y/wildfly-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luck3y/wildfly-core/teams","hooks_url":"https://api.github.com/repos/luck3y/wildfly-core/hooks","issue_events_url":"https://api.github.com/repos/luck3y/wildfly-core/issues/events{/number}","events_url":"https://api.github.com/repos/luck3y/wildfly-core/events","assignees_url":"https://api.github.com/repos/luck3y/wildfly-core/assignees{/user}","branches_url":"https://api.github.com/repos/luck3y/wildfly-core/branches{/branch}","tags_url":"https://api.github.com/repos/luck3y/wildfly-core/tags","blobs_url":"https://api.github.com/repos/luck3y/wildfly-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luck3y/wildfly-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luck3y/wildfly-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/luck3y/wildfly-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luck3y/wildfly-core/statuses/{sha}","languages_url":"https://api.github.com/repos/luck3y/wildfly-core/languages","stargazers_url":"https://api.github.com/repos/luck3y/wildfly-core/stargazers","contributors_url":"https://api.github.com/repos/luck3y/wildfly-core/contributors","subscribers_url":"https://api.github.com/repos/luck3y/wildfly-core/subscribers","subscription_url":"https://api.github.com/repos/luck3y/wildfly-core/subscription","commits_url":"https://api.github.com/repos/luck3y/wildfly-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/luck3y/wildfly-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/luck3y/wildfly-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/luck3y/wildfly-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/luck3y/wildfly-core/contents/{+path}","compare_url":"https://api.github.com/repos/luck3y/wildfly-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luck3y/wildfly-core/merges","archive_url":"https://api.github.com/repos/luck3y/wildfly-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luck3y/wildfly-core/downloads","issues_url":"https://api.github.com/repos/luck3y/wildfly-core/issues{/number}","pulls_url":"https://api.github.com/repos/luck3y/wildfly-core/pulls{/number}","milestones_url":"https://api.github.com/repos/luck3y/wildfly-core/milestones{/number}","notifications_url":"https://api.github.com/repos/luck3y/wildfly-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luck3y/wildfly-core/labels{/name}","releases_url":"https://api.github.com/repos/luck3y/wildfly-core/releases{/id}","deployments_url":"https://api.github.com/repos/luck3y/wildfly-core/deployments","created_at":"2015-07-17T16:53:03Z","updated_at":"2016-03-12T17:53:13Z","pushed_at":"2016-08-25T17:53:22Z","git_url":"git://github.com/luck3y/wildfly-core.git","ssh_url":"git@github.com:luck3y/wildfly-core.git","clone_url":"https://github.com/luck3y/wildfly-core.git","svn_url":"https://github.com/luck3y/wildfly-core","homepage":null,"size":50406,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wildfly:master","ref":"master","sha":"a6cc80b934387ee1fdab569b49df4449c517c0c6","user":{"login":"wildfly","id":3066274,"avatar_url":"https://avatars.githubusercontent.com/u/3066274?v=3","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"repo":{"id":21394954,"name":"wildfly-core","full_name":"wildfly/wildfly-core","owner":{"login":"wildfly","id":3066274,"avatar_url":"https://avatars.githubusercontent.com/u/3066274?v=3","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wildfly/wildfly-core","description":"The core runtime that is used by the Wildfly application server","fork":false,"url":"https://api.github.com/repos/wildfly/wildfly-core","forks_url":"https://api.github.com/repos/wildfly/wildfly-core/forks","keys_url":"https://api.github.com/repos/wildfly/wildfly-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wildfly/wildfly-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wildfly/wildfly-core/teams","hooks_url":"https://api.github.com/repos/wildfly/wildfly-core/hooks","issue_events_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/events{/number}","events_url":"https://api.github.com/repos/wildfly/wildfly-core/events","assignees_url":"https://api.github.com/repos/wildfly/wildfly-core/assignees{/user}","branches_url":"https://api.github.com/repos/wildfly/wildfly-core/branches{/branch}","tags_url":"https://api.github.com/repos/wildfly/wildfly-core/tags","blobs_url":"https://api.github.com/repos/wildfly/wildfly-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wildfly/wildfly-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wildfly/wildfly-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/wildfly/wildfly-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wildfly/wildfly-core/statuses/{sha}","languages_url":"https://api.github.com/repos/wildfly/wildfly-core/languages","stargazers_url":"https://api.github.com/repos/wildfly/wildfly-core/stargazers","contributors_url":"https://api.github.com/repos/wildfly/wildfly-core/contributors","subscribers_url":"https://api.github.com/repos/wildfly/wildfly-core/subscribers","subscription_url":"https://api.github.com/repos/wildfly/wildfly-core/subscription","commits_url":"https://api.github.com/repos/wildfly/wildfly-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/wildfly/wildfly-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/wildfly/wildfly-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/wildfly/wildfly-core/contents/{+path}","compare_url":"https://api.github.com/repos/wildfly/wildfly-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wildfly/wildfly-core/merges","archive_url":"https://api.github.com/repos/wildfly/wildfly-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wildfly/wildfly-core/downloads","issues_url":"https://api.github.com/repos/wildfly/wildfly-core/issues{/number}","pulls_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls{/number}","milestones_url":"https://api.github.com/repos/wildfly/wildfly-core/milestones{/number}","notifications_url":"https://api.github.com/repos/wildfly/wildfly-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wildfly/wildfly-core/labels{/name}","releases_url":"https://api.github.com/repos/wildfly/wildfly-core/releases{/id}","deployments_url":"https://api.github.com/repos/wildfly/wildfly-core/deployments","created_at":"2014-07-01T16:33:34Z","updated_at":"2016-08-01T12:37:06Z","pushed_at":"2016-08-26T10:17:49Z","git_url":"git://github.com/wildfly/wildfly-core.git","ssh_url":"git@github.com:wildfly/wildfly-core.git","clone_url":"https://github.com/wildfly/wildfly-core.git","svn_url":"https://github.com/wildfly/wildfly-core","homepage":null,"size":58396,"stargazers_count":56,"watchers_count":56,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":216,"mirror_url":null,"open_issues_count":21,"forks":216,"open_issues":21,"watchers":56,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1754"},"html":{"href":"https://github.com/wildfly/wildfly-core/pull/1754"},"issue":{"href":"https://api.github.com/repos/wildfly/wildfly-core/issues/1754"},"comments":{"href":"https://api.github.com/repos/wildfly/wildfly-core/issues/1754/comments"},"review_comments":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1754/comments"},"review_comment":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1754/commits"},"statuses":{"href":"https://api.github.com/repos/wildfly/wildfly-core/statuses/69e527d47c61473357283aaecb9313cc2e82d431"}}}}
{"actor":{"display_login":"bstansberry"}}