{"action":"created","comment":{"url":"https://api.github.com/repos/msiebeneicher/chapi/pulls/comments/55175584","id":55175584,"diff_hunk":"@@ -23,14 +23,21 @@ class HttpGuzzlClient implements HttpClientInterface\n     private $oGuzzelClient;\n \n     /**\n+     * @var array\n+     */\n+    private $aGuzzelClientConfig;\n+\n+    /**\n      * @param ClientInterface $oGuzzelClient\n+     * @param array $aGuzzelClientConfig\n      */\n     public function __construct(\n-        ClientInterface $oGuzzelClient\n+        ClientInterface $oGuzzelClient,\n+        array $aGuzzelClientConfig = []","path":"src/Component/Http/HttpGuzzlClient.php","position":15,"original_position":15,"commit_id":"8924bcf720d410e411944fb30b197be34602f5fd","original_commit_id":"8924bcf720d410e411944fb30b197be34602f5fd","user":{"login":"msiebeneicher","id":5821183,"avatar_url":"https://avatars.githubusercontent.com/u/5821183?v=3","gravatar_id":"","url":"https://api.github.com/users/msiebeneicher","html_url":"https://github.com/msiebeneicher","followers_url":"https://api.github.com/users/msiebeneicher/followers","following_url":"https://api.github.com/users/msiebeneicher/following{/other_user}","gists_url":"https://api.github.com/users/msiebeneicher/gists{/gist_id}","starred_url":"https://api.github.com/users/msiebeneicher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msiebeneicher/subscriptions","organizations_url":"https://api.github.com/users/msiebeneicher/orgs","repos_url":"https://api.github.com/users/msiebeneicher/repos","events_url":"https://api.github.com/users/msiebeneicher/events{/privacy}","received_events_url":"https://api.github.com/users/msiebeneicher/received_events","type":"User","site_admin":false},"body":"Please use an entity here instead of an array","created_at":"2016-03-07T08:54:46Z","updated_at":"2016-03-07T08:54:46Z","html_url":"https://github.com/msiebeneicher/chapi/pull/46#discussion_r55175584","pull_request_url":"https://api.github.com/repos/msiebeneicher/chapi/pulls/46","_links":{"self":{"href":"https://api.github.com/repos/msiebeneicher/chapi/pulls/comments/55175584"},"html":{"href":"https://github.com/msiebeneicher/chapi/pull/46#discussion_r55175584"},"pull_request":{"href":"https://api.github.com/repos/msiebeneicher/chapi/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/msiebeneicher/chapi/pulls/46","id":61847540,"html_url":"https://github.com/msiebeneicher/chapi/pull/46","diff_url":"https://github.com/msiebeneicher/chapi/pull/46.diff","patch_url":"https://github.com/msiebeneicher/chapi/pull/46.patch","issue_url":"https://api.github.com/repos/msiebeneicher/chapi/issues/46","number":46,"state":"open","locked":false,"title":"Added support for Chronos HTTP Basic Auth","user":{"login":"andygrunwald","id":320064,"avatar_url":"https://avatars.githubusercontent.com/u/320064?v=3","gravatar_id":"","url":"https://api.github.com/users/andygrunwald","html_url":"https://github.com/andygrunwald","followers_url":"https://api.github.com/users/andygrunwald/followers","following_url":"https://api.github.com/users/andygrunwald/following{/other_user}","gists_url":"https://api.github.com/users/andygrunwald/gists{/gist_id}","starred_url":"https://api.github.com/users/andygrunwald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andygrunwald/subscriptions","organizations_url":"https://api.github.com/users/andygrunwald/orgs","repos_url":"https://api.github.com/users/andygrunwald/repos","events_url":"https://api.github.com/users/andygrunwald/events{/privacy}","received_events_url":"https://api.github.com/users/andygrunwald/received_events","type":"User","site_admin":false},"body":"Chronos supports a configuration setting called `http_credentials` to protect the WEB UI and HTTP API.\r\nThis PR adds support for Username and Password to enable chapi to work with a Chronos instance with activated `http_credentials`.\r\n\r\nSome design decisions / implementation details you should consider during review:\r\n\r\n* **Chapi\\Component\\Http\\HttpGuzzlClient**: I decided to inject username and password via Array into `HttpGuzzlClient`. With this the usage of username and password is transparent and you don't have to take special attention to it once you implement a new command for chapi. The constructor of `HttpGuzzlClient` gets a Instance as first argument and an array as second. For the usage of DIC this is transparent.\r\n* **ConfigureCommand**: I implemented optional questions in the configure command. Before all values were required and a simple \"Enter\"-Hit throws an error. Now you can define if your Question requires an answer or not. The configuration will be stored in a backwards compatible way. Old configurations will be work with the new version.\r\n* **Unit Tests**: I decided to copy and extend the existing unit tests instead of adding more complexity to them due to arguments. Why? Because then i would reach the point were the tests need tests as well to cover their complexity.\r\n\r\nThis implementation was tested against a docker setup of Chronos by bobrik: https://github.com/bobrik/mesos-compose\r\n\r\nHere we go. Looking for feedback.","created_at":"2016-03-06T16:45:11Z","updated_at":"2016-03-07T08:54:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d89d53ac0199f48cfe592b0b3ccc71f3df4f1ff9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/msiebeneicher/chapi/pulls/46/commits","review_comments_url":"https://api.github.com/repos/msiebeneicher/chapi/pulls/46/comments","review_comment_url":"https://api.github.com/repos/msiebeneicher/chapi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/msiebeneicher/chapi/issues/46/comments","statuses_url":"https://api.github.com/repos/msiebeneicher/chapi/statuses/8924bcf720d410e411944fb30b197be34602f5fd","head":{"label":"andygrunwald:username-password","ref":"username-password","sha":"8924bcf720d410e411944fb30b197be34602f5fd","user":{"login":"andygrunwald","id":320064,"avatar_url":"https://avatars.githubusercontent.com/u/320064?v=3","gravatar_id":"","url":"https://api.github.com/users/andygrunwald","html_url":"https://github.com/andygrunwald","followers_url":"https://api.github.com/users/andygrunwald/followers","following_url":"https://api.github.com/users/andygrunwald/following{/other_user}","gists_url":"https://api.github.com/users/andygrunwald/gists{/gist_id}","starred_url":"https://api.github.com/users/andygrunwald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andygrunwald/subscriptions","organizations_url":"https://api.github.com/users/andygrunwald/orgs","repos_url":"https://api.github.com/users/andygrunwald/repos","events_url":"https://api.github.com/users/andygrunwald/events{/privacy}","received_events_url":"https://api.github.com/users/andygrunwald/received_events","type":"User","site_admin":false},"repo":{"id":45546382,"name":"chapi","full_name":"andygrunwald/chapi","owner":{"login":"andygrunwald","id":320064,"avatar_url":"https://avatars.githubusercontent.com/u/320064?v=3","gravatar_id":"","url":"https://api.github.com/users/andygrunwald","html_url":"https://github.com/andygrunwald","followers_url":"https://api.github.com/users/andygrunwald/followers","following_url":"https://api.github.com/users/andygrunwald/following{/other_user}","gists_url":"https://api.github.com/users/andygrunwald/gists{/gist_id}","starred_url":"https://api.github.com/users/andygrunwald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andygrunwald/subscriptions","organizations_url":"https://api.github.com/users/andygrunwald/orgs","repos_url":"https://api.github.com/users/andygrunwald/repos","events_url":"https://api.github.com/users/andygrunwald/events{/privacy}","received_events_url":"https://api.github.com/users/andygrunwald/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andygrunwald/chapi","description":"chronos console client - Manage your jobs like a git repository","fork":true,"url":"https://api.github.com/repos/andygrunwald/chapi","forks_url":"https://api.github.com/repos/andygrunwald/chapi/forks","keys_url":"https://api.github.com/repos/andygrunwald/chapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andygrunwald/chapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andygrunwald/chapi/teams","hooks_url":"https://api.github.com/repos/andygrunwald/chapi/hooks","issue_events_url":"https://api.github.com/repos/andygrunwald/chapi/issues/events{/number}","events_url":"https://api.github.com/repos/andygrunwald/chapi/events","assignees_url":"https://api.github.com/repos/andygrunwald/chapi/assignees{/user}","branches_url":"https://api.github.com/repos/andygrunwald/chapi/branches{/branch}","tags_url":"https://api.github.com/repos/andygrunwald/chapi/tags","blobs_url":"https://api.github.com/repos/andygrunwald/chapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andygrunwald/chapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andygrunwald/chapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/andygrunwald/chapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andygrunwald/chapi/statuses/{sha}","languages_url":"https://api.github.com/repos/andygrunwald/chapi/languages","stargazers_url":"https://api.github.com/repos/andygrunwald/chapi/stargazers","contributors_url":"https://api.github.com/repos/andygrunwald/chapi/contributors","subscribers_url":"https://api.github.com/repos/andygrunwald/chapi/subscribers","subscription_url":"https://api.github.com/repos/andygrunwald/chapi/subscription","commits_url":"https://api.github.com/repos/andygrunwald/chapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/andygrunwald/chapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/andygrunwald/chapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/andygrunwald/chapi/issues/comments{/number}","contents_url":"https://api.github.com/repos/andygrunwald/chapi/contents/{+path}","compare_url":"https://api.github.com/repos/andygrunwald/chapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andygrunwald/chapi/merges","archive_url":"https://api.github.com/repos/andygrunwald/chapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andygrunwald/chapi/downloads","issues_url":"https://api.github.com/repos/andygrunwald/chapi/issues{/number}","pulls_url":"https://api.github.com/repos/andygrunwald/chapi/pulls{/number}","milestones_url":"https://api.github.com/repos/andygrunwald/chapi/milestones{/number}","notifications_url":"https://api.github.com/repos/andygrunwald/chapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andygrunwald/chapi/labels{/name}","releases_url":"https://api.github.com/repos/andygrunwald/chapi/releases{/id}","deployments_url":"https://api.github.com/repos/andygrunwald/chapi/deployments","created_at":"2015-11-04T15:03:13Z","updated_at":"2015-11-04T15:03:15Z","pushed_at":"2016-03-06T17:01:15Z","git_url":"git://github.com/andygrunwald/chapi.git","ssh_url":"git@github.com:andygrunwald/chapi.git","clone_url":"https://github.com/andygrunwald/chapi.git","svn_url":"https://github.com/andygrunwald/chapi","homepage":"","size":254,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"msiebeneicher:master","ref":"master","sha":"2b99562bacfcbaf81f9a1af93ae96be492c7b0e0","user":{"login":"msiebeneicher","id":5821183,"avatar_url":"https://avatars.githubusercontent.com/u/5821183?v=3","gravatar_id":"","url":"https://api.github.com/users/msiebeneicher","html_url":"https://github.com/msiebeneicher","followers_url":"https://api.github.com/users/msiebeneicher/followers","following_url":"https://api.github.com/users/msiebeneicher/following{/other_user}","gists_url":"https://api.github.com/users/msiebeneicher/gists{/gist_id}","starred_url":"https://api.github.com/users/msiebeneicher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msiebeneicher/subscriptions","organizations_url":"https://api.github.com/users/msiebeneicher/orgs","repos_url":"https://api.github.com/users/msiebeneicher/repos","events_url":"https://api.github.com/users/msiebeneicher/events{/privacy}","received_events_url":"https://api.github.com/users/msiebeneicher/received_events","type":"User","site_admin":false},"repo":{"id":39820349,"name":"chapi","full_name":"msiebeneicher/chapi","owner":{"login":"msiebeneicher","id":5821183,"avatar_url":"https://avatars.githubusercontent.com/u/5821183?v=3","gravatar_id":"","url":"https://api.github.com/users/msiebeneicher","html_url":"https://github.com/msiebeneicher","followers_url":"https://api.github.com/users/msiebeneicher/followers","following_url":"https://api.github.com/users/msiebeneicher/following{/other_user}","gists_url":"https://api.github.com/users/msiebeneicher/gists{/gist_id}","starred_url":"https://api.github.com/users/msiebeneicher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msiebeneicher/subscriptions","organizations_url":"https://api.github.com/users/msiebeneicher/orgs","repos_url":"https://api.github.com/users/msiebeneicher/repos","events_url":"https://api.github.com/users/msiebeneicher/events{/privacy}","received_events_url":"https://api.github.com/users/msiebeneicher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/msiebeneicher/chapi","description":"chronos console client - Manage your jobs like a git repository","fork":false,"url":"https://api.github.com/repos/msiebeneicher/chapi","forks_url":"https://api.github.com/repos/msiebeneicher/chapi/forks","keys_url":"https://api.github.com/repos/msiebeneicher/chapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/msiebeneicher/chapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/msiebeneicher/chapi/teams","hooks_url":"https://api.github.com/repos/msiebeneicher/chapi/hooks","issue_events_url":"https://api.github.com/repos/msiebeneicher/chapi/issues/events{/number}","events_url":"https://api.github.com/repos/msiebeneicher/chapi/events","assignees_url":"https://api.github.com/repos/msiebeneicher/chapi/assignees{/user}","branches_url":"https://api.github.com/repos/msiebeneicher/chapi/branches{/branch}","tags_url":"https://api.github.com/repos/msiebeneicher/chapi/tags","blobs_url":"https://api.github.com/repos/msiebeneicher/chapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/msiebeneicher/chapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/msiebeneicher/chapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/msiebeneicher/chapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/msiebeneicher/chapi/statuses/{sha}","languages_url":"https://api.github.com/repos/msiebeneicher/chapi/languages","stargazers_url":"https://api.github.com/repos/msiebeneicher/chapi/stargazers","contributors_url":"https://api.github.com/repos/msiebeneicher/chapi/contributors","subscribers_url":"https://api.github.com/repos/msiebeneicher/chapi/subscribers","subscription_url":"https://api.github.com/repos/msiebeneicher/chapi/subscription","commits_url":"https://api.github.com/repos/msiebeneicher/chapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/msiebeneicher/chapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/msiebeneicher/chapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/msiebeneicher/chapi/issues/comments{/number}","contents_url":"https://api.github.com/repos/msiebeneicher/chapi/contents/{+path}","compare_url":"https://api.github.com/repos/msiebeneicher/chapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/msiebeneicher/chapi/merges","archive_url":"https://api.github.com/repos/msiebeneicher/chapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/msiebeneicher/chapi/downloads","issues_url":"https://api.github.com/repos/msiebeneicher/chapi/issues{/number}","pulls_url":"https://api.github.com/repos/msiebeneicher/chapi/pulls{/number}","milestones_url":"https://api.github.com/repos/msiebeneicher/chapi/milestones{/number}","notifications_url":"https://api.github.com/repos/msiebeneicher/chapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/msiebeneicher/chapi/labels{/name}","releases_url":"https://api.github.com/repos/msiebeneicher/chapi/releases{/id}","deployments_url":"https://api.github.com/repos/msiebeneicher/chapi/deployments","created_at":"2015-07-28T07:48:05Z","updated_at":"2016-03-07T08:41:57Z","pushed_at":"2016-03-07T08:48:15Z","git_url":"git://github.com/msiebeneicher/chapi.git","ssh_url":"git@github.com:msiebeneicher/chapi.git","clone_url":"https://github.com/msiebeneicher/chapi.git","svn_url":"https://github.com/msiebeneicher/chapi","homepage":"","size":259,"stargazers_count":6,"watchers_count":6,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/msiebeneicher/chapi/pulls/46"},"html":{"href":"https://github.com/msiebeneicher/chapi/pull/46"},"issue":{"href":"https://api.github.com/repos/msiebeneicher/chapi/issues/46"},"comments":{"href":"https://api.github.com/repos/msiebeneicher/chapi/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/msiebeneicher/chapi/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/msiebeneicher/chapi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/msiebeneicher/chapi/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/msiebeneicher/chapi/statuses/8924bcf720d410e411944fb30b197be34602f5fd"}}}}