{"action":"created","comment":{"url":"https://api.github.com/repos/Swrve/swrve-android-sdk/pulls/comments/49709242","id":49709242,"diff_hunk":"@@ -805,7 +807,7 @@ private boolean checkCampaignRules(int elementCount, String elementName, String\n     @SuppressLint(\"UseSparseArrays\")\n     protected SwrveConversation _getConversationForEvent(String event) {\n         SwrveConversation result = null;\n-        SwrveCampaign campaign = null;\n+        SwrveMessageCampaign campaign = null;","path":"SwrveSDK/src/main/java/com/swrve/sdk/SwrveBase.java","position":23,"original_position":23,"commit_id":"2342e4eb172712000d41d8eb95935edf867a478d","original_commit_id":"2342e4eb172712000d41d8eb95935edf867a478d","user":{"login":"shanetmoore","id":3028279,"avatar_url":"https://avatars.githubusercontent.com/u/3028279?v=3","gravatar_id":"","url":"https://api.github.com/users/shanetmoore","html_url":"https://github.com/shanetmoore","followers_url":"https://api.github.com/users/shanetmoore/followers","following_url":"https://api.github.com/users/shanetmoore/following{/other_user}","gists_url":"https://api.github.com/users/shanetmoore/gists{/gist_id}","starred_url":"https://api.github.com/users/shanetmoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shanetmoore/subscriptions","organizations_url":"https://api.github.com/users/shanetmoore/orgs","repos_url":"https://api.github.com/users/shanetmoore/repos","events_url":"https://api.github.com/users/shanetmoore/events{/privacy}","received_events_url":"https://api.github.com/users/shanetmoore/received_events","type":"User","site_admin":false},"body":"Its mostly because of the initial implementation. We brought in SwrveConversations as a copy of SwrveMessages and theres still some tech debt around it.\r\n\r\nIf the var isn't used however then I'll :hocho: ","created_at":"2016-01-14T10:25:20Z","updated_at":"2016-01-14T10:25:20Z","html_url":"https://github.com/Swrve/swrve-android-sdk/pull/109#discussion_r49709242","pull_request_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/pulls/109","_links":{"self":{"href":"https://api.github.com/repos/Swrve/swrve-android-sdk/pulls/comments/49709242"},"html":{"href":"https://github.com/Swrve/swrve-android-sdk/pull/109#discussion_r49709242"},"pull_request":{"href":"https://api.github.com/repos/Swrve/swrve-android-sdk/pulls/109"}}},"pull_request":{"url":"https://api.github.com/repos/Swrve/swrve-android-sdk/pulls/109","id":55923358,"html_url":"https://github.com/Swrve/swrve-android-sdk/pull/109","diff_url":"https://github.com/Swrve/swrve-android-sdk/pull/109.diff","patch_url":"https://github.com/Swrve/swrve-android-sdk/pull/109.patch","issue_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/issues/109","number":109,"state":"open","locked":false,"title":"10443 asset retrying","user":{"login":"shanetmoore","id":3028279,"avatar_url":"https://avatars.githubusercontent.com/u/3028279?v=3","gravatar_id":"","url":"https://api.github.com/users/shanetmoore","html_url":"https://github.com/shanetmoore","followers_url":"https://api.github.com/users/shanetmoore/followers","following_url":"https://api.github.com/users/shanetmoore/following{/other_user}","gists_url":"https://api.github.com/users/shanetmoore/gists{/gist_id}","starred_url":"https://api.github.com/users/shanetmoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shanetmoore/subscriptions","organizations_url":"https://api.github.com/users/shanetmoore/orgs","repos_url":"https://api.github.com/users/shanetmoore/repos","events_url":"https://api.github.com/users/shanetmoore/events{/privacy}","received_events_url":"https://api.github.com/users/shanetmoore/received_events","type":"User","site_admin":false},"body":"Assets will retry if they fail during synchronous download\r\n\r\nNew refactored mechanism for storing assets in separate class instead of SwrveImp","created_at":"2016-01-13T16:48:13Z","updated_at":"2016-01-14T10:25:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e864fa1c0691f8f22648db30c6e6437102512a7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/pulls/109/commits","review_comments_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/pulls/109/comments","review_comment_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/issues/109/comments","statuses_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/statuses/2342e4eb172712000d41d8eb95935edf867a478d","head":{"label":"Swrve:10443-asset-retrying","ref":"10443-asset-retrying","sha":"2342e4eb172712000d41d8eb95935edf867a478d","user":{"login":"Swrve","id":445249,"avatar_url":"https://avatars.githubusercontent.com/u/445249?v=3","gravatar_id":"","url":"https://api.github.com/users/Swrve","html_url":"https://github.com/Swrve","followers_url":"https://api.github.com/users/Swrve/followers","following_url":"https://api.github.com/users/Swrve/following{/other_user}","gists_url":"https://api.github.com/users/Swrve/gists{/gist_id}","starred_url":"https://api.github.com/users/Swrve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Swrve/subscriptions","organizations_url":"https://api.github.com/users/Swrve/orgs","repos_url":"https://api.github.com/users/Swrve/repos","events_url":"https://api.github.com/users/Swrve/events{/privacy}","received_events_url":"https://api.github.com/users/Swrve/received_events","type":"Organization","site_admin":false},"repo":{"id":23786714,"name":"swrve-android-sdk","full_name":"Swrve/swrve-android-sdk","owner":{"login":"Swrve","id":445249,"avatar_url":"https://avatars.githubusercontent.com/u/445249?v=3","gravatar_id":"","url":"https://api.github.com/users/Swrve","html_url":"https://github.com/Swrve","followers_url":"https://api.github.com/users/Swrve/followers","following_url":"https://api.github.com/users/Swrve/following{/other_user}","gists_url":"https://api.github.com/users/Swrve/gists{/gist_id}","starred_url":"https://api.github.com/users/Swrve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Swrve/subscriptions","organizations_url":"https://api.github.com/users/Swrve/orgs","repos_url":"https://api.github.com/users/Swrve/repos","events_url":"https://api.github.com/users/Swrve/events{/privacy}","received_events_url":"https://api.github.com/users/Swrve/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Swrve/swrve-android-sdk","description":"Swrve Android SDK","fork":false,"url":"https://api.github.com/repos/Swrve/swrve-android-sdk","forks_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/forks","keys_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/teams","hooks_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/hooks","issue_events_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/events","assignees_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/tags","blobs_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/languages","stargazers_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/stargazers","contributors_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/contributors","subscribers_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/subscribers","subscription_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/subscription","commits_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/merges","archive_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/downloads","issues_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/labels{/name}","releases_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/releases{/id}","created_at":"2014-09-08T10:24:14Z","updated_at":"2015-06-01T23:19:19Z","pushed_at":"2016-01-13T16:59:22Z","git_url":"git://github.com/Swrve/swrve-android-sdk.git","ssh_url":"git@github.com:Swrve/swrve-android-sdk.git","clone_url":"https://github.com/Swrve/swrve-android-sdk.git","svn_url":"https://github.com/Swrve/swrve-android-sdk","homepage":"http://www.swrve.com","size":6966,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":2,"default_branch":"release-4_1"}},"base":{"label":"Swrve:release-4_2","ref":"release-4_2","sha":"2c321b83733358fdabda235a29add51dd69c80c1","user":{"login":"Swrve","id":445249,"avatar_url":"https://avatars.githubusercontent.com/u/445249?v=3","gravatar_id":"","url":"https://api.github.com/users/Swrve","html_url":"https://github.com/Swrve","followers_url":"https://api.github.com/users/Swrve/followers","following_url":"https://api.github.com/users/Swrve/following{/other_user}","gists_url":"https://api.github.com/users/Swrve/gists{/gist_id}","starred_url":"https://api.github.com/users/Swrve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Swrve/subscriptions","organizations_url":"https://api.github.com/users/Swrve/orgs","repos_url":"https://api.github.com/users/Swrve/repos","events_url":"https://api.github.com/users/Swrve/events{/privacy}","received_events_url":"https://api.github.com/users/Swrve/received_events","type":"Organization","site_admin":false},"repo":{"id":23786714,"name":"swrve-android-sdk","full_name":"Swrve/swrve-android-sdk","owner":{"login":"Swrve","id":445249,"avatar_url":"https://avatars.githubusercontent.com/u/445249?v=3","gravatar_id":"","url":"https://api.github.com/users/Swrve","html_url":"https://github.com/Swrve","followers_url":"https://api.github.com/users/Swrve/followers","following_url":"https://api.github.com/users/Swrve/following{/other_user}","gists_url":"https://api.github.com/users/Swrve/gists{/gist_id}","starred_url":"https://api.github.com/users/Swrve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Swrve/subscriptions","organizations_url":"https://api.github.com/users/Swrve/orgs","repos_url":"https://api.github.com/users/Swrve/repos","events_url":"https://api.github.com/users/Swrve/events{/privacy}","received_events_url":"https://api.github.com/users/Swrve/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Swrve/swrve-android-sdk","description":"Swrve Android SDK","fork":false,"url":"https://api.github.com/repos/Swrve/swrve-android-sdk","forks_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/forks","keys_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/teams","hooks_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/hooks","issue_events_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/events","assignees_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/tags","blobs_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/languages","stargazers_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/stargazers","contributors_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/contributors","subscribers_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/subscribers","subscription_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/subscription","commits_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/merges","archive_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/downloads","issues_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/labels{/name}","releases_url":"https://api.github.com/repos/Swrve/swrve-android-sdk/releases{/id}","created_at":"2014-09-08T10:24:14Z","updated_at":"2015-06-01T23:19:19Z","pushed_at":"2016-01-13T16:59:22Z","git_url":"git://github.com/Swrve/swrve-android-sdk.git","ssh_url":"git@github.com:Swrve/swrve-android-sdk.git","clone_url":"https://github.com/Swrve/swrve-android-sdk.git","svn_url":"https://github.com/Swrve/swrve-android-sdk","homepage":"http://www.swrve.com","size":6966,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":2,"default_branch":"release-4_1"}},"_links":{"self":{"href":"https://api.github.com/repos/Swrve/swrve-android-sdk/pulls/109"},"html":{"href":"https://github.com/Swrve/swrve-android-sdk/pull/109"},"issue":{"href":"https://api.github.com/repos/Swrve/swrve-android-sdk/issues/109"},"comments":{"href":"https://api.github.com/repos/Swrve/swrve-android-sdk/issues/109/comments"},"review_comments":{"href":"https://api.github.com/repos/Swrve/swrve-android-sdk/pulls/109/comments"},"review_comment":{"href":"https://api.github.com/repos/Swrve/swrve-android-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Swrve/swrve-android-sdk/pulls/109/commits"},"statuses":{"href":"https://api.github.com/repos/Swrve/swrve-android-sdk/statuses/2342e4eb172712000d41d8eb95935edf867a478d"}}}}