{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/346","repository_url":"https://api.github.com/repos/GoogleChrome/lighthouse","labels_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/346/labels{/name}","comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/346/comments","events_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/346/events","html_url":"https://github.com/GoogleChrome/lighthouse/pull/346","id":156003394,"number":346,"title":"Break circular ref in NetworkRequest","user":{"login":"deepanjanroy","id":3505637,"avatar_url":"https://avatars.githubusercontent.com/u/3505637?v=3","gravatar_id":"","url":"https://api.github.com/users/deepanjanroy","html_url":"https://github.com/deepanjanroy","followers_url":"https://api.github.com/users/deepanjanroy/followers","following_url":"https://api.github.com/users/deepanjanroy/following{/other_user}","gists_url":"https://api.github.com/users/deepanjanroy/gists{/gist_id}","starred_url":"https://api.github.com/users/deepanjanroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepanjanroy/subscriptions","organizations_url":"https://api.github.com/users/deepanjanroy/orgs","repos_url":"https://api.github.com/users/deepanjanroy/repos","events_url":"https://api.github.com/users/deepanjanroy/events{/privacy}","received_events_url":"https://api.github.com/users/deepanjanroy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-05-20T16:36:12Z","updated_at":"2016-05-20T17:15:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/346","html_url":"https://github.com/GoogleChrome/lighthouse/pull/346","diff_url":"https://github.com/GoogleChrome/lighthouse/pull/346.diff","patch_url":"https://github.com/GoogleChrome/lighthouse/pull/346.patch"},"body":"This fixes #345, at least for now.\r\n\r\nA more future-proof solution would be to use something like this: https://www.npmjs.com/package/json-stringify-safe. Although I do wonder if we should remove the option of saving artifacts altogether. "},"comment":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/comments/220664942","html_url":"https://github.com/GoogleChrome/lighthouse/pull/346#issuecomment-220664942","issue_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/346","id":220664942,"user":{"login":"brendankenny","id":316891,"avatar_url":"https://avatars.githubusercontent.com/u/316891?v=3","gravatar_id":"","url":"https://api.github.com/users/brendankenny","html_url":"https://github.com/brendankenny","followers_url":"https://api.github.com/users/brendankenny/followers","following_url":"https://api.github.com/users/brendankenny/following{/other_user}","gists_url":"https://api.github.com/users/brendankenny/gists{/gist_id}","starred_url":"https://api.github.com/users/brendankenny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendankenny/subscriptions","organizations_url":"https://api.github.com/users/brendankenny/orgs","repos_url":"https://api.github.com/users/brendankenny/repos","events_url":"https://api.github.com/users/brendankenny/events{/privacy}","received_events_url":"https://api.github.com/users/brendankenny/received_events","type":"User","site_admin":false},"created_at":"2016-05-20T17:15:00Z","updated_at":"2016-05-20T17:15:00Z","body":"`json-stringify-safe` looks nice, has no dependencies, and is well used, but looking at the code, it looks like a performance landmine for serializing any deep objects (https://github.com/isaacs/json-stringify-safe/pull/17 will help quite a bit, though).\r\n\r\n`util.inspect` could be OK, but is the output guaranteed to be deserializable by `JSON.parse`? We'd also want to check perf. It's meant more for logging than for this.\r\n\r\nI also just remembered the critical network chains are already not serializable directly due to them containing circular references, so attempting to fully solve this with a simple layer over `stringify`/`parse` may be a lost cause anyways"}}
{"actor":{"display_login":"brendankenny"}}