{"action":"created","issue":{"url":"https://api.github.com/repos/materialsproject/custodian/issues/37","repository_url":"https://api.github.com/repos/materialsproject/custodian","labels_url":"https://api.github.com/repos/materialsproject/custodian/issues/37/labels{/name}","comments_url":"https://api.github.com/repos/materialsproject/custodian/issues/37/comments","events_url":"https://api.github.com/repos/materialsproject/custodian/issues/37/events","html_url":"https://github.com/materialsproject/custodian/issues/37","id":195682639,"number":37,"title":"If VASP does not even start running custodian doesn't raise error","user":{"login":"albalu","id":14810408,"avatar_url":"https://avatars.githubusercontent.com/u/14810408?v=3","gravatar_id":"","url":"https://api.github.com/users/albalu","html_url":"https://github.com/albalu","followers_url":"https://api.github.com/users/albalu/followers","following_url":"https://api.github.com/users/albalu/following{/other_user}","gists_url":"https://api.github.com/users/albalu/gists{/gist_id}","starred_url":"https://api.github.com/users/albalu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albalu/subscriptions","organizations_url":"https://api.github.com/users/albalu/orgs","repos_url":"https://api.github.com/users/albalu/repos","events_url":"https://api.github.com/users/albalu/events{/privacy}","received_events_url":"https://api.github.com/users/albalu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":33,"created_at":"2016-12-15T00:14:41Z","updated_at":"2016-12-15T17:52:39Z","closed_at":null,"body":"When reporting bugs/issues, please supply the following information. If this \r\nis a feature request, please simply state the requested feature.\r\n\r\n## System\r\n\r\n* Custodian version: 1.0.3 (master)\r\n* Python version: 2.7.12\r\n\r\n## Summary\r\n\r\n* Custodian doesn't raise error if VASP doesn't even run for any reason. \r\n** example of importance: when files like OUTCAR are copied from the previous step, even if this step doesn't run, from OUTCAR and vasprun.xml, it looks like the job is already finished!\r\n* The problem might be in Custodian._run_job() method: after \"p = job.run()\" custodian just assumes that VASP started running while it might not even start due to an error like this.\r\n\r\n## Error message\r\n (this example is on NERSC in std_err.txt):\r\n```\r\nsrun: error: slurm_receive_msg: Socket timed out on send/recv operation\r\nsrun: error: Unable to confirm allocation for job 3178405: Socket timed out on send/recv operation\r\nsrun: Check SLURM_JOB_ID environment variable for expired or invalid job.\r\n```\r\nbut this may happen due to various reasons regardless of what this error message says.\r\n\r\n## Suggested solution (if known)\r\n\r\nI don't exactly know how VASP exits when it can't even start but the machine itself raises various errors like the one copied here. A check for this may be added before p = job.run()\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/materialsproject/custodian/issues/comments/267394852","html_url":"https://github.com/materialsproject/custodian/issues/37#issuecomment-267394852","issue_url":"https://api.github.com/repos/materialsproject/custodian/issues/37","id":267394852,"user":{"login":"shyamd","id":16827130,"avatar_url":"https://avatars.githubusercontent.com/u/16827130?v=3","gravatar_id":"","url":"https://api.github.com/users/shyamd","html_url":"https://github.com/shyamd","followers_url":"https://api.github.com/users/shyamd/followers","following_url":"https://api.github.com/users/shyamd/following{/other_user}","gists_url":"https://api.github.com/users/shyamd/gists{/gist_id}","starred_url":"https://api.github.com/users/shyamd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shyamd/subscriptions","organizations_url":"https://api.github.com/users/shyamd/orgs","repos_url":"https://api.github.com/users/shyamd/repos","events_url":"https://api.github.com/users/shyamd/events{/privacy}","received_events_url":"https://api.github.com/users/shyamd/received_events","type":"User","site_admin":false},"created_at":"2016-12-15T17:52:39Z","updated_at":"2016-12-15T17:52:39Z","body":"Should be taken care of with #38 which checks for return code and throws an error. Also added a test for this in #39. "}}
{"actor":{"display_login":"shyamd"}}