{"action":"created","issue":{"url":"https://api.github.com/repos/cmangos/mangos-classic/issues/240","repository_url":"https://api.github.com/repos/cmangos/mangos-classic","labels_url":"https://api.github.com/repos/cmangos/mangos-classic/issues/240/labels{/name}","comments_url":"https://api.github.com/repos/cmangos/mangos-classic/issues/240/comments","events_url":"https://api.github.com/repos/cmangos/mangos-classic/issues/240/events","html_url":"https://github.com/cmangos/mangos-classic/pull/240","id":196027218,"number":240,"title":"Improve Spell Effect SPELL_EFFECT_TELEPORT_UNITS_FACE_CASTER","user":{"login":"cala","id":1459044,"avatar_url":"https://avatars.githubusercontent.com/u/1459044?v=3","gravatar_id":"","url":"https://api.github.com/users/cala","html_url":"https://github.com/cala","followers_url":"https://api.github.com/users/cala/followers","following_url":"https://api.github.com/users/cala/following{/other_user}","gists_url":"https://api.github.com/users/cala/gists{/gist_id}","starred_url":"https://api.github.com/users/cala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cala/subscriptions","organizations_url":"https://api.github.com/users/cala/orgs","repos_url":"https://api.github.com/users/cala/repos","events_url":"https://api.github.com/users/cala/events{/privacy}","received_events_url":"https://api.github.com/users/cala/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-12-16T10:28:27Z","updated_at":"2016-12-20T16:22:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cmangos/mangos-classic/pulls/240","html_url":"https://github.com/cmangos/mangos-classic/pull/240","diff_url":"https://github.com/cmangos/mangos-classic/pull/240.diff","patch_url":"https://github.com/cmangos/mangos-classic/pull/240.patch"},"body":"When radius is zero, players should be ported at the caster location\r\nwithout using bounding radius (neither for caster nor target).\r\nExemple: Azuregos teleport spell 21150 triggered by spell 21147: all\r\nplayers are to be ported _under_ Azuregos, not close to him\r\n\r\nAlso clean some whitespaces in SpellEffects.cpp"},"comment":{"url":"https://api.github.com/repos/cmangos/mangos-classic/issues/comments/268287078","html_url":"https://github.com/cmangos/mangos-classic/pull/240#issuecomment-268287078","issue_url":"https://api.github.com/repos/cmangos/mangos-classic/issues/240","id":268287078,"user":{"login":"cala","id":1459044,"avatar_url":"https://avatars.githubusercontent.com/u/1459044?v=3","gravatar_id":"","url":"https://api.github.com/users/cala","html_url":"https://github.com/cala","followers_url":"https://api.github.com/users/cala/followers","following_url":"https://api.github.com/users/cala/following{/other_user}","gists_url":"https://api.github.com/users/cala/gists{/gist_id}","starred_url":"https://api.github.com/users/cala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cala/subscriptions","organizations_url":"https://api.github.com/users/cala/orgs","repos_url":"https://api.github.com/users/cala/repos","events_url":"https://api.github.com/users/cala/events{/privacy}","received_events_url":"https://api.github.com/users/cala/received_events","type":"User","site_admin":false},"created_at":"2016-12-20T16:22:40Z","updated_at":"2016-12-20T16:22:40Z","body":"@killerwife thank you for the feedback. I'll have a look at those two encounters when I can get the chance. If they are working as they should, I'll merge this.\r\n\r\n@xfurry this PR is in fact fixing the opposite. In its current state, the spell effect uses the caster boundary, the target boundary and the effect radius to calculate the coordinates. This is correct when the target is expected to be ported in front/near the caster. But there are some spells where the targets must be ported at the caster location without using boundaries. This behaviour is not handled by the current spell effect, so this PR adds this case when the effect radius is zero."}}
{"actor":{"display_login":"cala"}}