{"action":"closed","number":3,"pull_request":{"url":"https://api.github.com/repos/ashaffer/bit-vector/pulls/3","id":55140821,"html_url":"https://github.com/ashaffer/bit-vector/pull/3","diff_url":"https://github.com/ashaffer/bit-vector/pull/3.diff","patch_url":"https://github.com/ashaffer/bit-vector/pull/3.patch","issue_url":"https://api.github.com/repos/ashaffer/bit-vector/issues/3","number":3,"state":"closed","locked":false,"title":"fix module export","user":{"login":"troch","id":1777517,"avatar_url":"https://avatars.githubusercontent.com/u/1777517?v=3","gravatar_id":"","url":"https://api.github.com/users/troch","html_url":"https://github.com/troch","followers_url":"https://api.github.com/users/troch/followers","following_url":"https://api.github.com/users/troch/following{/other_user}","gists_url":"https://api.github.com/users/troch/gists{/gist_id}","starred_url":"https://api.github.com/users/troch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/troch/subscriptions","organizations_url":"https://api.github.com/users/troch/orgs","repos_url":"https://api.github.com/users/troch/repos","events_url":"https://api.github.com/users/troch/events{/privacy}","received_events_url":"https://api.github.com/users/troch/received_events","type":"User","site_admin":false},"body":"Hello, it is me again :)\r\n\r\nWhen trying to build deku with rollup, it has flagged an issue with import / export between bit-vector and dift. If in dift you have named imports:\r\n\r\n```javascript\r\nimport {createBv, setBit, getBit} from 'bit-vector'\r\n```\r\n\r\nThen you need named exports in bit-vector (instead of exporting a default object):\r\n\r\n```javascript\r\nexport {\r\n  createBv,\r\n  setBit,\r\n  clearBit,\r\n  getBit\r\n}\r\n```\r\n\r\nI also took the opportunity to also npmignore .babelrc which I discovered today is best practice.","created_at":"2016-01-05T20:47:37Z","updated_at":"2016-01-05T20:52:31Z","closed_at":"2016-01-05T20:52:31Z","merged_at":"2016-01-05T20:52:31Z","merge_commit_sha":"b8ad386c1a94554feb2616a8b295aaaf2ce69db2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ashaffer/bit-vector/pulls/3/commits","review_comments_url":"https://api.github.com/repos/ashaffer/bit-vector/pulls/3/comments","review_comment_url":"https://api.github.com/repos/ashaffer/bit-vector/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ashaffer/bit-vector/issues/3/comments","statuses_url":"https://api.github.com/repos/ashaffer/bit-vector/statuses/234b9264f67852c4189a27f7698e61ec923984e3","head":{"label":"troch:export","ref":"export","sha":"234b9264f67852c4189a27f7698e61ec923984e3","user":{"login":"troch","id":1777517,"avatar_url":"https://avatars.githubusercontent.com/u/1777517?v=3","gravatar_id":"","url":"https://api.github.com/users/troch","html_url":"https://github.com/troch","followers_url":"https://api.github.com/users/troch/followers","following_url":"https://api.github.com/users/troch/following{/other_user}","gists_url":"https://api.github.com/users/troch/gists{/gist_id}","starred_url":"https://api.github.com/users/troch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/troch/subscriptions","organizations_url":"https://api.github.com/users/troch/orgs","repos_url":"https://api.github.com/users/troch/repos","events_url":"https://api.github.com/users/troch/events{/privacy}","received_events_url":"https://api.github.com/users/troch/received_events","type":"User","site_admin":false},"repo":{"id":49021725,"name":"bit-vector","full_name":"troch/bit-vector","owner":{"login":"troch","id":1777517,"avatar_url":"https://avatars.githubusercontent.com/u/1777517?v=3","gravatar_id":"","url":"https://api.github.com/users/troch","html_url":"https://github.com/troch","followers_url":"https://api.github.com/users/troch/followers","following_url":"https://api.github.com/users/troch/following{/other_user}","gists_url":"https://api.github.com/users/troch/gists{/gist_id}","starred_url":"https://api.github.com/users/troch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/troch/subscriptions","organizations_url":"https://api.github.com/users/troch/orgs","repos_url":"https://api.github.com/users/troch/repos","events_url":"https://api.github.com/users/troch/events{/privacy}","received_events_url":"https://api.github.com/users/troch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/troch/bit-vector","description":null,"fork":true,"url":"https://api.github.com/repos/troch/bit-vector","forks_url":"https://api.github.com/repos/troch/bit-vector/forks","keys_url":"https://api.github.com/repos/troch/bit-vector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/troch/bit-vector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/troch/bit-vector/teams","hooks_url":"https://api.github.com/repos/troch/bit-vector/hooks","issue_events_url":"https://api.github.com/repos/troch/bit-vector/issues/events{/number}","events_url":"https://api.github.com/repos/troch/bit-vector/events","assignees_url":"https://api.github.com/repos/troch/bit-vector/assignees{/user}","branches_url":"https://api.github.com/repos/troch/bit-vector/branches{/branch}","tags_url":"https://api.github.com/repos/troch/bit-vector/tags","blobs_url":"https://api.github.com/repos/troch/bit-vector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/troch/bit-vector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/troch/bit-vector/git/refs{/sha}","trees_url":"https://api.github.com/repos/troch/bit-vector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/troch/bit-vector/statuses/{sha}","languages_url":"https://api.github.com/repos/troch/bit-vector/languages","stargazers_url":"https://api.github.com/repos/troch/bit-vector/stargazers","contributors_url":"https://api.github.com/repos/troch/bit-vector/contributors","subscribers_url":"https://api.github.com/repos/troch/bit-vector/subscribers","subscription_url":"https://api.github.com/repos/troch/bit-vector/subscription","commits_url":"https://api.github.com/repos/troch/bit-vector/commits{/sha}","git_commits_url":"https://api.github.com/repos/troch/bit-vector/git/commits{/sha}","comments_url":"https://api.github.com/repos/troch/bit-vector/comments{/number}","issue_comment_url":"https://api.github.com/repos/troch/bit-vector/issues/comments{/number}","contents_url":"https://api.github.com/repos/troch/bit-vector/contents/{+path}","compare_url":"https://api.github.com/repos/troch/bit-vector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/troch/bit-vector/merges","archive_url":"https://api.github.com/repos/troch/bit-vector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/troch/bit-vector/downloads","issues_url":"https://api.github.com/repos/troch/bit-vector/issues{/number}","pulls_url":"https://api.github.com/repos/troch/bit-vector/pulls{/number}","milestones_url":"https://api.github.com/repos/troch/bit-vector/milestones{/number}","notifications_url":"https://api.github.com/repos/troch/bit-vector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/troch/bit-vector/labels{/name}","releases_url":"https://api.github.com/repos/troch/bit-vector/releases{/id}","created_at":"2016-01-04T20:38:21Z","updated_at":"2016-01-04T20:38:21Z","pushed_at":"2016-01-05T20:37:00Z","git_url":"git://github.com/troch/bit-vector.git","ssh_url":"git@github.com:troch/bit-vector.git","clone_url":"https://github.com/troch/bit-vector.git","svn_url":"https://github.com/troch/bit-vector","homepage":null,"size":7,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ashaffer:master","ref":"master","sha":"325f5e55c14f3198ab6f4d64622b7f358be33177","user":{"login":"ashaffer","id":1871136,"avatar_url":"https://avatars.githubusercontent.com/u/1871136?v=3","gravatar_id":"","url":"https://api.github.com/users/ashaffer","html_url":"https://github.com/ashaffer","followers_url":"https://api.github.com/users/ashaffer/followers","following_url":"https://api.github.com/users/ashaffer/following{/other_user}","gists_url":"https://api.github.com/users/ashaffer/gists{/gist_id}","starred_url":"https://api.github.com/users/ashaffer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashaffer/subscriptions","organizations_url":"https://api.github.com/users/ashaffer/orgs","repos_url":"https://api.github.com/users/ashaffer/repos","events_url":"https://api.github.com/users/ashaffer/events{/privacy}","received_events_url":"https://api.github.com/users/ashaffer/received_events","type":"User","site_admin":false},"repo":{"id":45559280,"name":"bit-vector","full_name":"ashaffer/bit-vector","owner":{"login":"ashaffer","id":1871136,"avatar_url":"https://avatars.githubusercontent.com/u/1871136?v=3","gravatar_id":"","url":"https://api.github.com/users/ashaffer","html_url":"https://github.com/ashaffer","followers_url":"https://api.github.com/users/ashaffer/followers","following_url":"https://api.github.com/users/ashaffer/following{/other_user}","gists_url":"https://api.github.com/users/ashaffer/gists{/gist_id}","starred_url":"https://api.github.com/users/ashaffer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashaffer/subscriptions","organizations_url":"https://api.github.com/users/ashaffer/orgs","repos_url":"https://api.github.com/users/ashaffer/repos","events_url":"https://api.github.com/users/ashaffer/events{/privacy}","received_events_url":"https://api.github.com/users/ashaffer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ashaffer/bit-vector","description":null,"fork":false,"url":"https://api.github.com/repos/ashaffer/bit-vector","forks_url":"https://api.github.com/repos/ashaffer/bit-vector/forks","keys_url":"https://api.github.com/repos/ashaffer/bit-vector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ashaffer/bit-vector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ashaffer/bit-vector/teams","hooks_url":"https://api.github.com/repos/ashaffer/bit-vector/hooks","issue_events_url":"https://api.github.com/repos/ashaffer/bit-vector/issues/events{/number}","events_url":"https://api.github.com/repos/ashaffer/bit-vector/events","assignees_url":"https://api.github.com/repos/ashaffer/bit-vector/assignees{/user}","branches_url":"https://api.github.com/repos/ashaffer/bit-vector/branches{/branch}","tags_url":"https://api.github.com/repos/ashaffer/bit-vector/tags","blobs_url":"https://api.github.com/repos/ashaffer/bit-vector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ashaffer/bit-vector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ashaffer/bit-vector/git/refs{/sha}","trees_url":"https://api.github.com/repos/ashaffer/bit-vector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ashaffer/bit-vector/statuses/{sha}","languages_url":"https://api.github.com/repos/ashaffer/bit-vector/languages","stargazers_url":"https://api.github.com/repos/ashaffer/bit-vector/stargazers","contributors_url":"https://api.github.com/repos/ashaffer/bit-vector/contributors","subscribers_url":"https://api.github.com/repos/ashaffer/bit-vector/subscribers","subscription_url":"https://api.github.com/repos/ashaffer/bit-vector/subscription","commits_url":"https://api.github.com/repos/ashaffer/bit-vector/commits{/sha}","git_commits_url":"https://api.github.com/repos/ashaffer/bit-vector/git/commits{/sha}","comments_url":"https://api.github.com/repos/ashaffer/bit-vector/comments{/number}","issue_comment_url":"https://api.github.com/repos/ashaffer/bit-vector/issues/comments{/number}","contents_url":"https://api.github.com/repos/ashaffer/bit-vector/contents/{+path}","compare_url":"https://api.github.com/repos/ashaffer/bit-vector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ashaffer/bit-vector/merges","archive_url":"https://api.github.com/repos/ashaffer/bit-vector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ashaffer/bit-vector/downloads","issues_url":"https://api.github.com/repos/ashaffer/bit-vector/issues{/number}","pulls_url":"https://api.github.com/repos/ashaffer/bit-vector/pulls{/number}","milestones_url":"https://api.github.com/repos/ashaffer/bit-vector/milestones{/number}","notifications_url":"https://api.github.com/repos/ashaffer/bit-vector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ashaffer/bit-vector/labels{/name}","releases_url":"https://api.github.com/repos/ashaffer/bit-vector/releases{/id}","created_at":"2015-11-04T18:34:56Z","updated_at":"2015-11-09T07:39:40Z","pushed_at":"2016-01-05T20:52:31Z","git_url":"git://github.com/ashaffer/bit-vector.git","ssh_url":"git@github.com:ashaffer/bit-vector.git","clone_url":"https://github.com/ashaffer/bit-vector.git","svn_url":"https://github.com/ashaffer/bit-vector","homepage":null,"size":7,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ashaffer/bit-vector/pulls/3"},"html":{"href":"https://github.com/ashaffer/bit-vector/pull/3"},"issue":{"href":"https://api.github.com/repos/ashaffer/bit-vector/issues/3"},"comments":{"href":"https://api.github.com/repos/ashaffer/bit-vector/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/ashaffer/bit-vector/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/ashaffer/bit-vector/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ashaffer/bit-vector/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/ashaffer/bit-vector/statuses/234b9264f67852c4189a27f7698e61ec923984e3"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ashaffer","id":1871136,"avatar_url":"https://avatars.githubusercontent.com/u/1871136?v=3","gravatar_id":"","url":"https://api.github.com/users/ashaffer","html_url":"https://github.com/ashaffer","followers_url":"https://api.github.com/users/ashaffer/followers","following_url":"https://api.github.com/users/ashaffer/following{/other_user}","gists_url":"https://api.github.com/users/ashaffer/gists{/gist_id}","starred_url":"https://api.github.com/users/ashaffer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashaffer/subscriptions","organizations_url":"https://api.github.com/users/ashaffer/orgs","repos_url":"https://api.github.com/users/ashaffer/repos","events_url":"https://api.github.com/users/ashaffer/events{/privacy}","received_events_url":"https://api.github.com/users/ashaffer/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":2,"deletions":1,"changed_files":2}}