{"action":"created","comment":{"url":"https://api.github.com/repos/istio/mixer/pulls/comments/91189911","pull_request_review_id":11699930,"id":91189911,"diff_hunk":"@@ -18,131 +18,18 @@ package istio.mixer.v1;\n \n option go_package=\"istio.io/mixer/api/v1;mixerpb\";\n \n-import \"google/protobuf/timestamp.proto\";\n-import \"google/protobuf/struct.proto\";\n-import \"google/protobuf/any.proto\";\n+import \"attributes.proto\";\n import \"google/rpc/status.proto\";\n \n // Used to report telemetry after performing an action.\n message ReportRequest {\n   // Uniquely identifies this request, used to match to responses\n   int64 request_id = 1;\n \n-  // The set of discovered facts associated with this request. This value\n-  // represents a delta relative to the facts currently known to the mixer\n-  // within the current stream.\n-  map<string, string> facts = 2;\n-\n-  // The monitored resource type associated with this report.\n-  string monitored_resource_descriptor_name = 3;\n-\n-  // Metric values being reported\n-  repeated MetricValue metric_values = 4;\n-\n-  // Log entries being reported\n-  repeated LogEntry log_entries = 5;\n-}\n-\n-// Represents a single metric value.\n-message MetricValue {\n-  // Name of the MetricDescriptor providing the schema for the metric.\n-  string descriptor_name = 1;\n-\n-  // The start of the time period over which this metric value's measurement\n-  // applies. The time period has different semantics for different metric\n-  // kinds (cumulative, delta, and gauge). See the documentation for the\n-  // MetricDescriptor for more information.\n-  google.protobuf.Timestamp start_time = 3;","path":"api/v1/report.proto","position":39,"original_position":39,"commit_id":"80292326335ea113b2c85e96ba3a95e388d58cac","original_commit_id":"80292326335ea113b2c85e96ba3a95e388d58cac","user":{"login":"louiscryan","id":9046588,"avatar_url":"https://avatars.githubusercontent.com/u/9046588?v=3","gravatar_id":"","url":"https://api.github.com/users/louiscryan","html_url":"https://github.com/louiscryan","followers_url":"https://api.github.com/users/louiscryan/followers","following_url":"https://api.github.com/users/louiscryan/following{/other_user}","gists_url":"https://api.github.com/users/louiscryan/gists{/gist_id}","starred_url":"https://api.github.com/users/louiscryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/louiscryan/subscriptions","organizations_url":"https://api.github.com/users/louiscryan/orgs","repos_url":"https://api.github.com/users/louiscryan/repos","events_url":"https://api.github.com/users/louiscryan/events{/privacy}","received_events_url":"https://api.github.com/users/louiscryan/received_events","type":"User","site_admin":false},"body":"Interval needs to be retained","created_at":"2016-12-06T22:45:09Z","updated_at":"2016-12-06T22:45:09Z","html_url":"https://github.com/istio/mixer/pull/34#discussion_r91189911","pull_request_url":"https://api.github.com/repos/istio/mixer/pulls/34","_links":{"self":{"href":"https://api.github.com/repos/istio/mixer/pulls/comments/91189911"},"html":{"href":"https://github.com/istio/mixer/pull/34#discussion_r91189911"},"pull_request":{"href":"https://api.github.com/repos/istio/mixer/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/istio/mixer/pulls/34","id":96820729,"html_url":"https://github.com/istio/mixer/pull/34","diff_url":"https://github.com/istio/mixer/pull/34.diff","patch_url":"https://github.com/istio/mixer/pull/34.patch","issue_url":"https://api.github.com/repos/istio/mixer/issues/34","number":34,"state":"open","locked":false,"title":"Basic proposal for well-known and strongly typed facts.","user":{"login":"smawson","id":1562325,"avatar_url":"https://avatars.githubusercontent.com/u/1562325?v=3","gravatar_id":"","url":"https://api.github.com/users/smawson","html_url":"https://github.com/smawson","followers_url":"https://api.github.com/users/smawson/followers","following_url":"https://api.github.com/users/smawson/following{/other_user}","gists_url":"https://api.github.com/users/smawson/gists{/gist_id}","starred_url":"https://api.github.com/users/smawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smawson/subscriptions","organizations_url":"https://api.github.com/users/smawson/orgs","repos_url":"https://api.github.com/users/smawson/repos","events_url":"https://api.github.com/users/smawson/events{/privacy}","received_events_url":"https://api.github.com/users/smawson/received_events","type":"User","site_admin":false},"body":"- Renames fact to attribute, and makes attributes typed (using metric value types)\r\n- Adds well known types to an Attributes object\r\n- Replaces map<string, string> facts with Attributes object\r\n- Removes metric values and log entries from report.\r\n- Removes aggregation, I'd like to add aggregation generically for attributes, rather than just for metric values.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/istio/mixer/34)\n<!-- Reviewable:end -->\n","created_at":"2016-12-06T22:34:03Z","updated_at":"2016-12-06T22:45:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cfe6bfc22022a2c676b0ffa1690bbc95762e6a74","assignee":{"login":"mandarjog","id":800375,"avatar_url":"https://avatars.githubusercontent.com/u/800375?v=3","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false},"assignees":[{"login":"mandarjog","id":800375,"avatar_url":"https://avatars.githubusercontent.com/u/800375?v=3","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false},{"login":"louiscryan","id":9046588,"avatar_url":"https://avatars.githubusercontent.com/u/9046588?v=3","gravatar_id":"","url":"https://api.github.com/users/louiscryan","html_url":"https://github.com/louiscryan","followers_url":"https://api.github.com/users/louiscryan/followers","following_url":"https://api.github.com/users/louiscryan/following{/other_user}","gists_url":"https://api.github.com/users/louiscryan/gists{/gist_id}","starred_url":"https://api.github.com/users/louiscryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/louiscryan/subscriptions","organizations_url":"https://api.github.com/users/louiscryan/orgs","repos_url":"https://api.github.com/users/louiscryan/repos","events_url":"https://api.github.com/users/louiscryan/events{/privacy}","received_events_url":"https://api.github.com/users/louiscryan/received_events","type":"User","site_admin":false},{"login":"douglas-reid","id":21148125,"avatar_url":"https://avatars.githubusercontent.com/u/21148125?v=3","gravatar_id":"","url":"https://api.github.com/users/douglas-reid","html_url":"https://github.com/douglas-reid","followers_url":"https://api.github.com/users/douglas-reid/followers","following_url":"https://api.github.com/users/douglas-reid/following{/other_user}","gists_url":"https://api.github.com/users/douglas-reid/gists{/gist_id}","starred_url":"https://api.github.com/users/douglas-reid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/douglas-reid/subscriptions","organizations_url":"https://api.github.com/users/douglas-reid/orgs","repos_url":"https://api.github.com/users/douglas-reid/repos","events_url":"https://api.github.com/users/douglas-reid/events{/privacy}","received_events_url":"https://api.github.com/users/douglas-reid/received_events","type":"User","site_admin":false},{"login":"geeknoid","id":22780957,"avatar_url":"https://avatars.githubusercontent.com/u/22780957?v=3","gravatar_id":"","url":"https://api.github.com/users/geeknoid","html_url":"https://github.com/geeknoid","followers_url":"https://api.github.com/users/geeknoid/followers","following_url":"https://api.github.com/users/geeknoid/following{/other_user}","gists_url":"https://api.github.com/users/geeknoid/gists{/gist_id}","starred_url":"https://api.github.com/users/geeknoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geeknoid/subscriptions","organizations_url":"https://api.github.com/users/geeknoid/orgs","repos_url":"https://api.github.com/users/geeknoid/repos","events_url":"https://api.github.com/users/geeknoid/events{/privacy}","received_events_url":"https://api.github.com/users/geeknoid/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/mixer/pulls/34/commits","review_comments_url":"https://api.github.com/repos/istio/mixer/pulls/34/comments","review_comment_url":"https://api.github.com/repos/istio/mixer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/mixer/issues/34/comments","statuses_url":"https://api.github.com/repos/istio/mixer/statuses/80292326335ea113b2c85e96ba3a95e388d58cac","head":{"label":"smawson:mixer-api-proposal","ref":"mixer-api-proposal","sha":"80292326335ea113b2c85e96ba3a95e388d58cac","user":{"login":"smawson","id":1562325,"avatar_url":"https://avatars.githubusercontent.com/u/1562325?v=3","gravatar_id":"","url":"https://api.github.com/users/smawson","html_url":"https://github.com/smawson","followers_url":"https://api.github.com/users/smawson/followers","following_url":"https://api.github.com/users/smawson/following{/other_user}","gists_url":"https://api.github.com/users/smawson/gists{/gist_id}","starred_url":"https://api.github.com/users/smawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smawson/subscriptions","organizations_url":"https://api.github.com/users/smawson/orgs","repos_url":"https://api.github.com/users/smawson/repos","events_url":"https://api.github.com/users/smawson/events{/privacy}","received_events_url":"https://api.github.com/users/smawson/received_events","type":"User","site_admin":false},"repo":{"id":75775244,"name":"mixer","full_name":"smawson/mixer","owner":{"login":"smawson","id":1562325,"avatar_url":"https://avatars.githubusercontent.com/u/1562325?v=3","gravatar_id":"","url":"https://api.github.com/users/smawson","html_url":"https://github.com/smawson","followers_url":"https://api.github.com/users/smawson/followers","following_url":"https://api.github.com/users/smawson/following{/other_user}","gists_url":"https://api.github.com/users/smawson/gists{/gist_id}","starred_url":"https://api.github.com/users/smawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smawson/subscriptions","organizations_url":"https://api.github.com/users/smawson/orgs","repos_url":"https://api.github.com/users/smawson/repos","events_url":"https://api.github.com/users/smawson/events{/privacy}","received_events_url":"https://api.github.com/users/smawson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smawson/mixer","description":"The Istio mixer and its adapters.","fork":true,"url":"https://api.github.com/repos/smawson/mixer","forks_url":"https://api.github.com/repos/smawson/mixer/forks","keys_url":"https://api.github.com/repos/smawson/mixer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smawson/mixer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smawson/mixer/teams","hooks_url":"https://api.github.com/repos/smawson/mixer/hooks","issue_events_url":"https://api.github.com/repos/smawson/mixer/issues/events{/number}","events_url":"https://api.github.com/repos/smawson/mixer/events","assignees_url":"https://api.github.com/repos/smawson/mixer/assignees{/user}","branches_url":"https://api.github.com/repos/smawson/mixer/branches{/branch}","tags_url":"https://api.github.com/repos/smawson/mixer/tags","blobs_url":"https://api.github.com/repos/smawson/mixer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smawson/mixer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smawson/mixer/git/refs{/sha}","trees_url":"https://api.github.com/repos/smawson/mixer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smawson/mixer/statuses/{sha}","languages_url":"https://api.github.com/repos/smawson/mixer/languages","stargazers_url":"https://api.github.com/repos/smawson/mixer/stargazers","contributors_url":"https://api.github.com/repos/smawson/mixer/contributors","subscribers_url":"https://api.github.com/repos/smawson/mixer/subscribers","subscription_url":"https://api.github.com/repos/smawson/mixer/subscription","commits_url":"https://api.github.com/repos/smawson/mixer/commits{/sha}","git_commits_url":"https://api.github.com/repos/smawson/mixer/git/commits{/sha}","comments_url":"https://api.github.com/repos/smawson/mixer/comments{/number}","issue_comment_url":"https://api.github.com/repos/smawson/mixer/issues/comments{/number}","contents_url":"https://api.github.com/repos/smawson/mixer/contents/{+path}","compare_url":"https://api.github.com/repos/smawson/mixer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smawson/mixer/merges","archive_url":"https://api.github.com/repos/smawson/mixer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smawson/mixer/downloads","issues_url":"https://api.github.com/repos/smawson/mixer/issues{/number}","pulls_url":"https://api.github.com/repos/smawson/mixer/pulls{/number}","milestones_url":"https://api.github.com/repos/smawson/mixer/milestones{/number}","notifications_url":"https://api.github.com/repos/smawson/mixer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smawson/mixer/labels{/name}","releases_url":"https://api.github.com/repos/smawson/mixer/releases{/id}","deployments_url":"https://api.github.com/repos/smawson/mixer/deployments","created_at":"2016-12-06T21:59:28Z","updated_at":"2016-12-06T21:59:29Z","pushed_at":"2016-12-06T22:43:33Z","git_url":"git://github.com/smawson/mixer.git","ssh_url":"git@github.com:smawson/mixer.git","clone_url":"https://github.com/smawson/mixer.git","svn_url":"https://github.com/smawson/mixer","homepage":null,"size":8272,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"f0348663b38d577543a1c772409b7934b2d4eb21","user":{"login":"istio","id":23534644,"avatar_url":"https://avatars.githubusercontent.com/u/23534644?v=3","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74177509,"name":"mixer","full_name":"istio/mixer","owner":{"login":"istio","id":23534644,"avatar_url":"https://avatars.githubusercontent.com/u/23534644?v=3","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/mixer","description":"The Istio mixer and its adapters.","fork":false,"url":"https://api.github.com/repos/istio/mixer","forks_url":"https://api.github.com/repos/istio/mixer/forks","keys_url":"https://api.github.com/repos/istio/mixer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/mixer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/mixer/teams","hooks_url":"https://api.github.com/repos/istio/mixer/hooks","issue_events_url":"https://api.github.com/repos/istio/mixer/issues/events{/number}","events_url":"https://api.github.com/repos/istio/mixer/events","assignees_url":"https://api.github.com/repos/istio/mixer/assignees{/user}","branches_url":"https://api.github.com/repos/istio/mixer/branches{/branch}","tags_url":"https://api.github.com/repos/istio/mixer/tags","blobs_url":"https://api.github.com/repos/istio/mixer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/mixer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/mixer/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/mixer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/mixer/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/mixer/languages","stargazers_url":"https://api.github.com/repos/istio/mixer/stargazers","contributors_url":"https://api.github.com/repos/istio/mixer/contributors","subscribers_url":"https://api.github.com/repos/istio/mixer/subscribers","subscription_url":"https://api.github.com/repos/istio/mixer/subscription","commits_url":"https://api.github.com/repos/istio/mixer/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/mixer/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/mixer/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/mixer/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/mixer/contents/{+path}","compare_url":"https://api.github.com/repos/istio/mixer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/mixer/merges","archive_url":"https://api.github.com/repos/istio/mixer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/mixer/downloads","issues_url":"https://api.github.com/repos/istio/mixer/issues{/number}","pulls_url":"https://api.github.com/repos/istio/mixer/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/mixer/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/mixer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/mixer/labels{/name}","releases_url":"https://api.github.com/repos/istio/mixer/releases{/id}","deployments_url":"https://api.github.com/repos/istio/mixer/deployments","created_at":"2016-11-19T00:40:17Z","updated_at":"2016-12-06T19:45:49Z","pushed_at":"2016-12-06T22:36:08Z","git_url":"git://github.com/istio/mixer.git","ssh_url":"git@github.com:istio/mixer.git","clone_url":"https://github.com/istio/mixer.git","svn_url":"https://github.com/istio/mixer","homepage":null,"size":8272,"stargazers_count":4,"watchers_count":4,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":12,"forks":7,"open_issues":12,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/mixer/pulls/34"},"html":{"href":"https://github.com/istio/mixer/pull/34"},"issue":{"href":"https://api.github.com/repos/istio/mixer/issues/34"},"comments":{"href":"https://api.github.com/repos/istio/mixer/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/mixer/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/mixer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/mixer/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/istio/mixer/statuses/80292326335ea113b2c85e96ba3a95e388d58cac"}}}}
{"actor":{"display_login":"louiscryan"}}