{"action":"created","comment":{"url":"https://api.github.com/repos/exercism/x-common/pulls/comments/75469780","id":75469780,"diff_hunk":"@@ -0,0 +1,60 @@\n+{\n+    \"#\": [\n+        \"Here -1 is used to indicate that the value is not included in the array.\",\n+        \"It should be replaced with the respective expression that is idiomatic\",\n+        \"for the language that implements the tests.\",\n+\n+        \"Following https://github.com/exercism/x-common/issues/234 the exercise\",\n+        \"should NOT include checking whether the array is sorted as it defeats\",\n+        \"the point of the binary search.\",\n+\n+        \"The exercise should utilize an array-like (i.e. constant-time indexed)\",\n+        \"data structure and not a linked list. If something like an array is not\",\n+        \"usually used in the language the problem should not be implemented.\",\n+        \"See https://github.com/exercism/x-common/issues/244 for details.\"\n+    ],\n+    \"cases\": [\n+        {\n+            \"description\": \"finds a value in an array with one element\",\n+            \"array\": [6],\n+            \"value\": 6,\n+            \"expected\": 0\n+        },\n+        {\n+            \"description\": \"finds a value in the middle of an array\",\n+            \"array\": [1, 3, 4, 6, 8, 9, 11],\n+            \"value\": 6,\n+            \"expected\": 3\n+        },\n+        {\n+            \"description\": \"finds a value at the beginning of an array\",\n+            \"array\": [1, 3, 4, 6, 8, 9, 11],\n+            \"value\": 1,\n+            \"expected\": 0\n+        },\n+        {\n+            \"description\": \"finds a value at the end of an array\",\n+            \"array\": [1, 3, 4, 6, 8, 9, 11],\n+            \"value\": 11,\n+            \"expected\": 6\n+        },\n+        {\n+            \"description\": \"finds a value in the middle of an array of odd length\",\n+            \"array\": [1, 3, 5, 8, 13, 34, 34, 55, 89, 144, 233, 377, 634],","path":"binary-search.json","position":43,"original_position":43,"commit_id":"d141af4eb44121ae87b42f63b409a4b6ff7fb26a","original_commit_id":"d141af4eb44121ae87b42f63b409a4b6ff7fb26a","user":{"login":"junedev","id":12543047,"avatar_url":"https://avatars.githubusercontent.com/u/12543047?v=3","gravatar_id":"","url":"https://api.github.com/users/junedev","html_url":"https://github.com/junedev","followers_url":"https://api.github.com/users/junedev/followers","following_url":"https://api.github.com/users/junedev/following{/other_user}","gists_url":"https://api.github.com/users/junedev/gists{/gist_id}","starred_url":"https://api.github.com/users/junedev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junedev/subscriptions","organizations_url":"https://api.github.com/users/junedev/orgs","repos_url":"https://api.github.com/users/junedev/repos","events_url":"https://api.github.com/users/junedev/events{/privacy}","received_events_url":"https://api.github.com/users/junedev/received_events","type":"User","site_admin":false},"body":"Thanks for taking the time to explain. I nobody else votes in favour of keeping it, I will change it to use only unique values. I might not have a chance to update the PR before the weekend. But maybe other points will come up and I can change it all together next week.","created_at":"2016-08-19T12:03:46Z","updated_at":"2016-08-19T12:03:46Z","html_url":"https://github.com/exercism/x-common/pull/349#discussion_r75469780","pull_request_url":"https://api.github.com/repos/exercism/x-common/pulls/349","_links":{"self":{"href":"https://api.github.com/repos/exercism/x-common/pulls/comments/75469780"},"html":{"href":"https://github.com/exercism/x-common/pull/349#discussion_r75469780"},"pull_request":{"href":"https://api.github.com/repos/exercism/x-common/pulls/349"}}},"pull_request":{"url":"https://api.github.com/repos/exercism/x-common/pulls/349","id":81860252,"html_url":"https://github.com/exercism/x-common/pull/349","diff_url":"https://github.com/exercism/x-common/pull/349.diff","patch_url":"https://github.com/exercism/x-common/pull/349.patch","issue_url":"https://api.github.com/repos/exercism/x-common/issues/349","number":349,"state":"open","locked":false,"title":"binary-search: add json test data","user":{"login":"junedev","id":12543047,"avatar_url":"https://avatars.githubusercontent.com/u/12543047?v=3","gravatar_id":"","url":"https://api.github.com/users/junedev","html_url":"https://github.com/junedev","followers_url":"https://api.github.com/users/junedev/followers","following_url":"https://api.github.com/users/junedev/following{/other_user}","gists_url":"https://api.github.com/users/junedev/gists{/gist_id}","starred_url":"https://api.github.com/users/junedev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junedev/subscriptions","organizations_url":"https://api.github.com/users/junedev/orgs","repos_url":"https://api.github.com/users/junedev/repos","events_url":"https://api.github.com/users/junedev/events{/privacy}","received_events_url":"https://api.github.com/users/junedev/received_events","type":"User","site_admin":false},"body":"Following the instructions proposed by @IanWhitney in #230, I created the missing json file with the test data for binary-search. Once this is merged https://github.com/exercism/todo/issues/73 can be closed.\r\n\r\nThere are two open issues regarding the exercise:\r\n#234 - Following (and agreeing with) the majority there I did not include checking for sorted input. I also included a respective comment in the json file. The issue can be closed once the new test data is propagated through the tracks.\r\n#244 - I included a comment with the summary of what was discussed there but the issue seems only partly addressed by this as there are additional ideas on how/where to address the issue.","created_at":"2016-08-18T17:59:49Z","updated_at":"2016-08-19T12:03:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"088f34d3a25e2d4f255a38d84c7fdffc790f4de9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/exercism/x-common/pulls/349/commits","review_comments_url":"https://api.github.com/repos/exercism/x-common/pulls/349/comments","review_comment_url":"https://api.github.com/repos/exercism/x-common/pulls/comments{/number}","comments_url":"https://api.github.com/repos/exercism/x-common/issues/349/comments","statuses_url":"https://api.github.com/repos/exercism/x-common/statuses/d141af4eb44121ae87b42f63b409a4b6ff7fb26a","head":{"label":"junedev:binary_search_json_data","ref":"binary_search_json_data","sha":"d141af4eb44121ae87b42f63b409a4b6ff7fb26a","user":{"login":"junedev","id":12543047,"avatar_url":"https://avatars.githubusercontent.com/u/12543047?v=3","gravatar_id":"","url":"https://api.github.com/users/junedev","html_url":"https://github.com/junedev","followers_url":"https://api.github.com/users/junedev/followers","following_url":"https://api.github.com/users/junedev/following{/other_user}","gists_url":"https://api.github.com/users/junedev/gists{/gist_id}","starred_url":"https://api.github.com/users/junedev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junedev/subscriptions","organizations_url":"https://api.github.com/users/junedev/orgs","repos_url":"https://api.github.com/users/junedev/repos","events_url":"https://api.github.com/users/junedev/events{/privacy}","received_events_url":"https://api.github.com/users/junedev/received_events","type":"User","site_admin":false},"repo":{"id":65845782,"name":"x-common","full_name":"junedev/x-common","owner":{"login":"junedev","id":12543047,"avatar_url":"https://avatars.githubusercontent.com/u/12543047?v=3","gravatar_id":"","url":"https://api.github.com/users/junedev","html_url":"https://github.com/junedev","followers_url":"https://api.github.com/users/junedev/followers","following_url":"https://api.github.com/users/junedev/following{/other_user}","gists_url":"https://api.github.com/users/junedev/gists{/gist_id}","starred_url":"https://api.github.com/users/junedev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junedev/subscriptions","organizations_url":"https://api.github.com/users/junedev/orgs","repos_url":"https://api.github.com/users/junedev/repos","events_url":"https://api.github.com/users/junedev/events{/privacy}","received_events_url":"https://api.github.com/users/junedev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/junedev/x-common","description":"Shared metadata for exercism exercises.","fork":true,"url":"https://api.github.com/repos/junedev/x-common","forks_url":"https://api.github.com/repos/junedev/x-common/forks","keys_url":"https://api.github.com/repos/junedev/x-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/junedev/x-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/junedev/x-common/teams","hooks_url":"https://api.github.com/repos/junedev/x-common/hooks","issue_events_url":"https://api.github.com/repos/junedev/x-common/issues/events{/number}","events_url":"https://api.github.com/repos/junedev/x-common/events","assignees_url":"https://api.github.com/repos/junedev/x-common/assignees{/user}","branches_url":"https://api.github.com/repos/junedev/x-common/branches{/branch}","tags_url":"https://api.github.com/repos/junedev/x-common/tags","blobs_url":"https://api.github.com/repos/junedev/x-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/junedev/x-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/junedev/x-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/junedev/x-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/junedev/x-common/statuses/{sha}","languages_url":"https://api.github.com/repos/junedev/x-common/languages","stargazers_url":"https://api.github.com/repos/junedev/x-common/stargazers","contributors_url":"https://api.github.com/repos/junedev/x-common/contributors","subscribers_url":"https://api.github.com/repos/junedev/x-common/subscribers","subscription_url":"https://api.github.com/repos/junedev/x-common/subscription","commits_url":"https://api.github.com/repos/junedev/x-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/junedev/x-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/junedev/x-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/junedev/x-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/junedev/x-common/contents/{+path}","compare_url":"https://api.github.com/repos/junedev/x-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/junedev/x-common/merges","archive_url":"https://api.github.com/repos/junedev/x-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/junedev/x-common/downloads","issues_url":"https://api.github.com/repos/junedev/x-common/issues{/number}","pulls_url":"https://api.github.com/repos/junedev/x-common/pulls{/number}","milestones_url":"https://api.github.com/repos/junedev/x-common/milestones{/number}","notifications_url":"https://api.github.com/repos/junedev/x-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/junedev/x-common/labels{/name}","releases_url":"https://api.github.com/repos/junedev/x-common/releases{/id}","deployments_url":"https://api.github.com/repos/junedev/x-common/deployments","created_at":"2016-08-16T18:56:40Z","updated_at":"2016-08-16T18:56:41Z","pushed_at":"2016-08-18T18:15:41Z","git_url":"git://github.com/junedev/x-common.git","ssh_url":"git@github.com:junedev/x-common.git","clone_url":"https://github.com/junedev/x-common.git","svn_url":"https://github.com/junedev/x-common","homepage":null,"size":558,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"exercism:master","ref":"master","sha":"f1ba7d095362490c40586d1245dac1e9ec1a9035","user":{"login":"exercism","id":5624255,"avatar_url":"https://avatars.githubusercontent.com/u/5624255?v=3","gravatar_id":"","url":"https://api.github.com/users/exercism","html_url":"https://github.com/exercism","followers_url":"https://api.github.com/users/exercism/followers","following_url":"https://api.github.com/users/exercism/following{/other_user}","gists_url":"https://api.github.com/users/exercism/gists{/gist_id}","starred_url":"https://api.github.com/users/exercism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exercism/subscriptions","organizations_url":"https://api.github.com/users/exercism/orgs","repos_url":"https://api.github.com/users/exercism/repos","events_url":"https://api.github.com/users/exercism/events{/privacy}","received_events_url":"https://api.github.com/users/exercism/received_events","type":"Organization","site_admin":false},"repo":{"id":17259886,"name":"x-common","full_name":"exercism/x-common","owner":{"login":"exercism","id":5624255,"avatar_url":"https://avatars.githubusercontent.com/u/5624255?v=3","gravatar_id":"","url":"https://api.github.com/users/exercism","html_url":"https://github.com/exercism","followers_url":"https://api.github.com/users/exercism/followers","following_url":"https://api.github.com/users/exercism/following{/other_user}","gists_url":"https://api.github.com/users/exercism/gists{/gist_id}","starred_url":"https://api.github.com/users/exercism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exercism/subscriptions","organizations_url":"https://api.github.com/users/exercism/orgs","repos_url":"https://api.github.com/users/exercism/repos","events_url":"https://api.github.com/users/exercism/events{/privacy}","received_events_url":"https://api.github.com/users/exercism/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/exercism/x-common","description":"Shared metadata for exercism exercises.","fork":false,"url":"https://api.github.com/repos/exercism/x-common","forks_url":"https://api.github.com/repos/exercism/x-common/forks","keys_url":"https://api.github.com/repos/exercism/x-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exercism/x-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exercism/x-common/teams","hooks_url":"https://api.github.com/repos/exercism/x-common/hooks","issue_events_url":"https://api.github.com/repos/exercism/x-common/issues/events{/number}","events_url":"https://api.github.com/repos/exercism/x-common/events","assignees_url":"https://api.github.com/repos/exercism/x-common/assignees{/user}","branches_url":"https://api.github.com/repos/exercism/x-common/branches{/branch}","tags_url":"https://api.github.com/repos/exercism/x-common/tags","blobs_url":"https://api.github.com/repos/exercism/x-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exercism/x-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exercism/x-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/exercism/x-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exercism/x-common/statuses/{sha}","languages_url":"https://api.github.com/repos/exercism/x-common/languages","stargazers_url":"https://api.github.com/repos/exercism/x-common/stargazers","contributors_url":"https://api.github.com/repos/exercism/x-common/contributors","subscribers_url":"https://api.github.com/repos/exercism/x-common/subscribers","subscription_url":"https://api.github.com/repos/exercism/x-common/subscription","commits_url":"https://api.github.com/repos/exercism/x-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/exercism/x-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/exercism/x-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/exercism/x-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/exercism/x-common/contents/{+path}","compare_url":"https://api.github.com/repos/exercism/x-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exercism/x-common/merges","archive_url":"https://api.github.com/repos/exercism/x-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exercism/x-common/downloads","issues_url":"https://api.github.com/repos/exercism/x-common/issues{/number}","pulls_url":"https://api.github.com/repos/exercism/x-common/pulls{/number}","milestones_url":"https://api.github.com/repos/exercism/x-common/milestones{/number}","notifications_url":"https://api.github.com/repos/exercism/x-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exercism/x-common/labels{/name}","releases_url":"https://api.github.com/repos/exercism/x-common/releases{/id}","deployments_url":"https://api.github.com/repos/exercism/x-common/deployments","created_at":"2014-02-27T18:40:48Z","updated_at":"2016-08-14T13:44:50Z","pushed_at":"2016-08-19T10:18:13Z","git_url":"git://github.com/exercism/x-common.git","ssh_url":"git@github.com:exercism/x-common.git","clone_url":"https://github.com/exercism/x-common.git","svn_url":"https://github.com/exercism/x-common","homepage":null,"size":728,"stargazers_count":66,"watchers_count":66,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":123,"mirror_url":null,"open_issues_count":50,"forks":123,"open_issues":50,"watchers":66,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/exercism/x-common/pulls/349"},"html":{"href":"https://github.com/exercism/x-common/pull/349"},"issue":{"href":"https://api.github.com/repos/exercism/x-common/issues/349"},"comments":{"href":"https://api.github.com/repos/exercism/x-common/issues/349/comments"},"review_comments":{"href":"https://api.github.com/repos/exercism/x-common/pulls/349/comments"},"review_comment":{"href":"https://api.github.com/repos/exercism/x-common/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/exercism/x-common/pulls/349/commits"},"statuses":{"href":"https://api.github.com/repos/exercism/x-common/statuses/d141af4eb44121ae87b42f63b409a4b6ff7fb26a"}}}}
{"actor":{"display_login":"junedev"}}