{"action":"created","comment":{"url":"https://api.github.com/repos/cloudflare/cfssl/pulls/comments/59486547","id":59486547,"diff_hunk":"@@ -176,6 +177,12 @@ func (cr *CertificateRequest) Name() pkix.Name {\n \treturn name\n }\n \n+// BasicConstraints CSR information RFC 5280, 4.2.1.9\n+type BasicConstraints struct {","path":"csr/csr.go","position":13,"original_position":13,"commit_id":"ff095d6f11e216805f65e1c26ac79c3647145edb","original_commit_id":"ff095d6f11e216805f65e1c26ac79c3647145edb","user":{"login":"lziest","id":1222706,"avatar_url":"https://avatars.githubusercontent.com/u/1222706?v=3","gravatar_id":"","url":"https://api.github.com/users/lziest","html_url":"https://github.com/lziest","followers_url":"https://api.github.com/users/lziest/followers","following_url":"https://api.github.com/users/lziest/following{/other_user}","gists_url":"https://api.github.com/users/lziest/gists{/gist_id}","starred_url":"https://api.github.com/users/lziest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lziest/subscriptions","organizations_url":"https://api.github.com/users/lziest/orgs","repos_url":"https://api.github.com/users/lziest/repos","events_url":"https://api.github.com/users/lziest/events{/privacy}","received_events_url":"https://api.github.com/users/lziest/received_events","type":"User","site_admin":false},"body":"do you think this can be an unexported struct?","created_at":"2016-04-13T02:54:24Z","updated_at":"2016-04-13T02:54:24Z","html_url":"https://github.com/cloudflare/cfssl/pull/586#discussion_r59486547","pull_request_url":"https://api.github.com/repos/cloudflare/cfssl/pulls/586","_links":{"self":{"href":"https://api.github.com/repos/cloudflare/cfssl/pulls/comments/59486547"},"html":{"href":"https://github.com/cloudflare/cfssl/pull/586#discussion_r59486547"},"pull_request":{"href":"https://api.github.com/repos/cloudflare/cfssl/pulls/586"}}},"pull_request":{"url":"https://api.github.com/repos/cloudflare/cfssl/pulls/586","id":65869328,"html_url":"https://github.com/cloudflare/cfssl/pull/586","diff_url":"https://github.com/cloudflare/cfssl/pull/586.diff","patch_url":"https://github.com/cloudflare/cfssl/pull/586.patch","issue_url":"https://api.github.com/repos/cloudflare/cfssl/issues/586","number":586,"state":"open","locked":false,"title":"BasicConstraint CSR support","user":{"login":"tam7t","id":1523807,"avatar_url":"https://avatars.githubusercontent.com/u/1523807?v=3","gravatar_id":"","url":"https://api.github.com/users/tam7t","html_url":"https://github.com/tam7t","followers_url":"https://api.github.com/users/tam7t/followers","following_url":"https://api.github.com/users/tam7t/following{/other_user}","gists_url":"https://api.github.com/users/tam7t/gists{/gist_id}","starred_url":"https://api.github.com/users/tam7t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tam7t/subscriptions","organizations_url":"https://api.github.com/users/tam7t/orgs","repos_url":"https://api.github.com/users/tam7t/repos","events_url":"https://api.github.com/users/tam7t/events{/privacy}","received_events_url":"https://api.github.com/users/tam7t/received_events","type":"User","site_admin":false},"body":"Addresses https://github.com/cloudflare/cfssl/issues/495\r\n\r\nThis adds more complete support for the `BasicConstraint` extension when generating and singing CSRs. Continues from the work in https://github.com/cloudflare/cfssl/pull/576 adding...\r\n- `pathlen` to the CSRs generated by cfssl\r\n- use the `pathlen` info from CSRs when signing requests","created_at":"2016-04-09T03:22:13Z","updated_at":"2016-04-13T02:54:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"022af9830ae9d224886a5566f09f58f01301659e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cloudflare/cfssl/pulls/586/commits","review_comments_url":"https://api.github.com/repos/cloudflare/cfssl/pulls/586/comments","review_comment_url":"https://api.github.com/repos/cloudflare/cfssl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudflare/cfssl/issues/586/comments","statuses_url":"https://api.github.com/repos/cloudflare/cfssl/statuses/ff095d6f11e216805f65e1c26ac79c3647145edb","head":{"label":"tam7t:pathlen-csr-support","ref":"pathlen-csr-support","sha":"ff095d6f11e216805f65e1c26ac79c3647145edb","user":{"login":"tam7t","id":1523807,"avatar_url":"https://avatars.githubusercontent.com/u/1523807?v=3","gravatar_id":"","url":"https://api.github.com/users/tam7t","html_url":"https://github.com/tam7t","followers_url":"https://api.github.com/users/tam7t/followers","following_url":"https://api.github.com/users/tam7t/following{/other_user}","gists_url":"https://api.github.com/users/tam7t/gists{/gist_id}","starred_url":"https://api.github.com/users/tam7t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tam7t/subscriptions","organizations_url":"https://api.github.com/users/tam7t/orgs","repos_url":"https://api.github.com/users/tam7t/repos","events_url":"https://api.github.com/users/tam7t/events{/privacy}","received_events_url":"https://api.github.com/users/tam7t/received_events","type":"User","site_admin":false},"repo":{"id":55258068,"name":"cfssl","full_name":"tam7t/cfssl","owner":{"login":"tam7t","id":1523807,"avatar_url":"https://avatars.githubusercontent.com/u/1523807?v=3","gravatar_id":"","url":"https://api.github.com/users/tam7t","html_url":"https://github.com/tam7t","followers_url":"https://api.github.com/users/tam7t/followers","following_url":"https://api.github.com/users/tam7t/following{/other_user}","gists_url":"https://api.github.com/users/tam7t/gists{/gist_id}","starred_url":"https://api.github.com/users/tam7t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tam7t/subscriptions","organizations_url":"https://api.github.com/users/tam7t/orgs","repos_url":"https://api.github.com/users/tam7t/repos","events_url":"https://api.github.com/users/tam7t/events{/privacy}","received_events_url":"https://api.github.com/users/tam7t/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tam7t/cfssl","description":"CFSSL: CloudFlare's PKI and TLS toolkit","fork":true,"url":"https://api.github.com/repos/tam7t/cfssl","forks_url":"https://api.github.com/repos/tam7t/cfssl/forks","keys_url":"https://api.github.com/repos/tam7t/cfssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tam7t/cfssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tam7t/cfssl/teams","hooks_url":"https://api.github.com/repos/tam7t/cfssl/hooks","issue_events_url":"https://api.github.com/repos/tam7t/cfssl/issues/events{/number}","events_url":"https://api.github.com/repos/tam7t/cfssl/events","assignees_url":"https://api.github.com/repos/tam7t/cfssl/assignees{/user}","branches_url":"https://api.github.com/repos/tam7t/cfssl/branches{/branch}","tags_url":"https://api.github.com/repos/tam7t/cfssl/tags","blobs_url":"https://api.github.com/repos/tam7t/cfssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tam7t/cfssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tam7t/cfssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/tam7t/cfssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tam7t/cfssl/statuses/{sha}","languages_url":"https://api.github.com/repos/tam7t/cfssl/languages","stargazers_url":"https://api.github.com/repos/tam7t/cfssl/stargazers","contributors_url":"https://api.github.com/repos/tam7t/cfssl/contributors","subscribers_url":"https://api.github.com/repos/tam7t/cfssl/subscribers","subscription_url":"https://api.github.com/repos/tam7t/cfssl/subscription","commits_url":"https://api.github.com/repos/tam7t/cfssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/tam7t/cfssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/tam7t/cfssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/tam7t/cfssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/tam7t/cfssl/contents/{+path}","compare_url":"https://api.github.com/repos/tam7t/cfssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tam7t/cfssl/merges","archive_url":"https://api.github.com/repos/tam7t/cfssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tam7t/cfssl/downloads","issues_url":"https://api.github.com/repos/tam7t/cfssl/issues{/number}","pulls_url":"https://api.github.com/repos/tam7t/cfssl/pulls{/number}","milestones_url":"https://api.github.com/repos/tam7t/cfssl/milestones{/number}","notifications_url":"https://api.github.com/repos/tam7t/cfssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tam7t/cfssl/labels{/name}","releases_url":"https://api.github.com/repos/tam7t/cfssl/releases{/id}","deployments_url":"https://api.github.com/repos/tam7t/cfssl/deployments","created_at":"2016-04-01T19:44:17Z","updated_at":"2016-04-01T19:44:18Z","pushed_at":"2016-04-12T14:01:45Z","git_url":"git://github.com/tam7t/cfssl.git","ssh_url":"git@github.com:tam7t/cfssl.git","clone_url":"https://github.com/tam7t/cfssl.git","svn_url":"https://github.com/tam7t/cfssl","homepage":"https://cfssl.org/","size":8304,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cloudflare:master","ref":"master","sha":"fd2e2206fceb0cffb85b02c084da2d64cc4d3bcb","user":{"login":"cloudflare","id":314135,"avatar_url":"https://avatars.githubusercontent.com/u/314135?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudflare","html_url":"https://github.com/cloudflare","followers_url":"https://api.github.com/users/cloudflare/followers","following_url":"https://api.github.com/users/cloudflare/following{/other_user}","gists_url":"https://api.github.com/users/cloudflare/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudflare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudflare/subscriptions","organizations_url":"https://api.github.com/users/cloudflare/orgs","repos_url":"https://api.github.com/users/cloudflare/repos","events_url":"https://api.github.com/users/cloudflare/events{/privacy}","received_events_url":"https://api.github.com/users/cloudflare/received_events","type":"Organization","site_admin":false},"repo":{"id":21591001,"name":"cfssl","full_name":"cloudflare/cfssl","owner":{"login":"cloudflare","id":314135,"avatar_url":"https://avatars.githubusercontent.com/u/314135?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudflare","html_url":"https://github.com/cloudflare","followers_url":"https://api.github.com/users/cloudflare/followers","following_url":"https://api.github.com/users/cloudflare/following{/other_user}","gists_url":"https://api.github.com/users/cloudflare/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudflare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudflare/subscriptions","organizations_url":"https://api.github.com/users/cloudflare/orgs","repos_url":"https://api.github.com/users/cloudflare/repos","events_url":"https://api.github.com/users/cloudflare/events{/privacy}","received_events_url":"https://api.github.com/users/cloudflare/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudflare/cfssl","description":"CFSSL: CloudFlare's PKI and TLS toolkit","fork":false,"url":"https://api.github.com/repos/cloudflare/cfssl","forks_url":"https://api.github.com/repos/cloudflare/cfssl/forks","keys_url":"https://api.github.com/repos/cloudflare/cfssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudflare/cfssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudflare/cfssl/teams","hooks_url":"https://api.github.com/repos/cloudflare/cfssl/hooks","issue_events_url":"https://api.github.com/repos/cloudflare/cfssl/issues/events{/number}","events_url":"https://api.github.com/repos/cloudflare/cfssl/events","assignees_url":"https://api.github.com/repos/cloudflare/cfssl/assignees{/user}","branches_url":"https://api.github.com/repos/cloudflare/cfssl/branches{/branch}","tags_url":"https://api.github.com/repos/cloudflare/cfssl/tags","blobs_url":"https://api.github.com/repos/cloudflare/cfssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudflare/cfssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudflare/cfssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudflare/cfssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudflare/cfssl/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudflare/cfssl/languages","stargazers_url":"https://api.github.com/repos/cloudflare/cfssl/stargazers","contributors_url":"https://api.github.com/repos/cloudflare/cfssl/contributors","subscribers_url":"https://api.github.com/repos/cloudflare/cfssl/subscribers","subscription_url":"https://api.github.com/repos/cloudflare/cfssl/subscription","commits_url":"https://api.github.com/repos/cloudflare/cfssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudflare/cfssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudflare/cfssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudflare/cfssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudflare/cfssl/contents/{+path}","compare_url":"https://api.github.com/repos/cloudflare/cfssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudflare/cfssl/merges","archive_url":"https://api.github.com/repos/cloudflare/cfssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudflare/cfssl/downloads","issues_url":"https://api.github.com/repos/cloudflare/cfssl/issues{/number}","pulls_url":"https://api.github.com/repos/cloudflare/cfssl/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudflare/cfssl/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudflare/cfssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudflare/cfssl/labels{/name}","releases_url":"https://api.github.com/repos/cloudflare/cfssl/releases{/id}","deployments_url":"https://api.github.com/repos/cloudflare/cfssl/deployments","created_at":"2014-07-07T23:49:12Z","updated_at":"2016-04-13T02:40:16Z","pushed_at":"2016-04-12T18:08:44Z","git_url":"git://github.com/cloudflare/cfssl.git","ssh_url":"git@github.com:cloudflare/cfssl.git","clone_url":"https://github.com/cloudflare/cfssl.git","svn_url":"https://github.com/cloudflare/cfssl","homepage":"https://cfssl.org/","size":10924,"stargazers_count":1213,"watchers_count":1213,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":153,"mirror_url":null,"open_issues_count":54,"forks":153,"open_issues":54,"watchers":1213,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudflare/cfssl/pulls/586"},"html":{"href":"https://github.com/cloudflare/cfssl/pull/586"},"issue":{"href":"https://api.github.com/repos/cloudflare/cfssl/issues/586"},"comments":{"href":"https://api.github.com/repos/cloudflare/cfssl/issues/586/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudflare/cfssl/pulls/586/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudflare/cfssl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudflare/cfssl/pulls/586/commits"},"statuses":{"href":"https://api.github.com/repos/cloudflare/cfssl/statuses/ff095d6f11e216805f65e1c26ac79c3647145edb"}}}}