{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/puppet-elasticsearch/issues/705","repository_url":"https://api.github.com/repos/elastic/puppet-elasticsearch","labels_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/issues/705/labels{/name}","comments_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/issues/705/comments","events_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/issues/705/events","html_url":"https://github.com/elastic/puppet-elasticsearch/issues/705","id":178588860,"number":705,"title":"Inconsistent quotation marks in elasticsearch.yml","user":{"login":"ak0ska","id":2640166,"avatar_url":"https://avatars.githubusercontent.com/u/2640166?v=3","gravatar_id":"","url":"https://api.github.com/users/ak0ska","html_url":"https://github.com/ak0ska","followers_url":"https://api.github.com/users/ak0ska/followers","following_url":"https://api.github.com/users/ak0ska/following{/other_user}","gists_url":"https://api.github.com/users/ak0ska/gists{/gist_id}","starred_url":"https://api.github.com/users/ak0ska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ak0ska/subscriptions","organizations_url":"https://api.github.com/users/ak0ska/orgs","repos_url":"https://api.github.com/users/ak0ska/repos","events_url":"https://api.github.com/users/ak0ska/events{/privacy}","received_events_url":"https://api.github.com/users/ak0ska/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/elastic/puppet-elasticsearch/labels/bug","name":"bug","color":"fc2929"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-22T11:49:28Z","updated_at":"2016-10-07T13:18:36Z","closed_at":"2016-10-07T13:18:36Z","body":"* Module version: 0.13.2\r\n* Puppet version: 3.8.7\r\n* OS and version: CentOS 7.2\r\n\r\n## Bug description\r\nHello,\r\n\r\nThis is probably a nitpicky issue, but here it goes: with the current version of the module the generated elasticsearch.yml uses quotation marks around numbers inconsistently. I think it's due to the `to_yaml` call in the template, and how Puppet interprets the types of its own variables. We previously used version 0.10.1 of the module, where this was not an issue.\r\n\r\nHere's an example:\r\n\r\n``` puppet\r\nclass{ 'elasticsearch':\r\n    [..]\r\n    config           => {\r\n      'cluster' => {\r\n        'routing.allocation' => {\r\n          'node_concurrent_recoveries'        => 20,\r\n          'node_initial_primaries_recoveries' => floor(30),\r\n          'awareness.attributes'              => 'landb_parent'\r\n        }\r\n    }\r\n}\r\n``` \r\n\r\nThis will result in the following entries in the yaml file:\r\n``` yaml\r\ncluster.routing.allocation.awareness.attributes: landb_parent\r\ncluster.routing.allocation.node_concurrent_recoveries: \"20\"\r\ncluster.routing.allocation.node_initial_primaries_recoveries: 30\r\n```\r\n\r\nAs you can see the string `landb_parent` has not quotes around it, while the value 20 has. Number 30 has been put through Puppet's `floor` function, and it has no quotes around.\r\n\r\nIn our config we have many more numerical values, some are calculated using arithmetic operators, or put through numerical functions like `floor`. These values have no quotes around them. However the \"static\" numerical values (like the 20 in the example) get quoted in the config file.\r\n\r\nIt does not look pretty. :) Apart from that, does ElasticSearch makes a difference between quoted and unquoted values when parsing the settings file?\r\n\r\nThanks,\r\nAkos\r\n\r\n\r\n\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/elastic/puppet-elasticsearch/issues/comments/252249573","html_url":"https://github.com/elastic/puppet-elasticsearch/issues/705#issuecomment-252249573","issue_url":"https://api.github.com/repos/elastic/puppet-elasticsearch/issues/705","id":252249573,"user":{"login":"tylerjl","id":1733846,"avatar_url":"https://avatars.githubusercontent.com/u/1733846?v=3","gravatar_id":"","url":"https://api.github.com/users/tylerjl","html_url":"https://github.com/tylerjl","followers_url":"https://api.github.com/users/tylerjl/followers","following_url":"https://api.github.com/users/tylerjl/following{/other_user}","gists_url":"https://api.github.com/users/tylerjl/gists{/gist_id}","starred_url":"https://api.github.com/users/tylerjl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylerjl/subscriptions","organizations_url":"https://api.github.com/users/tylerjl/orgs","repos_url":"https://api.github.com/users/tylerjl/repos","events_url":"https://api.github.com/users/tylerjl/events{/privacy}","received_events_url":"https://api.github.com/users/tylerjl/received_events","type":"User","site_admin":false},"created_at":"2016-10-07T13:18:35Z","updated_at":"2016-10-07T13:18:35Z","body":"Fixed in #715 "}}
{"actor":{"display_login":"tylerjl"}}