{"action":"created","issue":{"url":"https://api.github.com/repos/TheTorProject/bwscanner/issues/43","repository_url":"https://api.github.com/repos/TheTorProject/bwscanner","labels_url":"https://api.github.com/repos/TheTorProject/bwscanner/issues/43/labels{/name}","comments_url":"https://api.github.com/repos/TheTorProject/bwscanner/issues/43/comments","events_url":"https://api.github.com/repos/TheTorProject/bwscanner/issues/43/events","html_url":"https://github.com/TheTorProject/bwscanner/pull/43","id":184020183,"number":43,"title":"Add prometheus stats client and shutdown code path triggered by signal handler","user":{"login":"david415","id":50611,"avatar_url":"https://avatars.githubusercontent.com/u/50611?v=3","gravatar_id":"","url":"https://api.github.com/users/david415","html_url":"https://github.com/david415","followers_url":"https://api.github.com/users/david415/followers","following_url":"https://api.github.com/users/david415/following{/other_user}","gists_url":"https://api.github.com/users/david415/gists{/gist_id}","starred_url":"https://api.github.com/users/david415/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david415/subscriptions","organizations_url":"https://api.github.com/users/david415/orgs","repos_url":"https://api.github.com/users/david415/repos","events_url":"https://api.github.com/users/david415/events{/privacy}","received_events_url":"https://api.github.com/users/david415/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/TheTorProject/bwscanner/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-10-19T17:04:25Z","updated_at":"2016-10-19T19:16:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/TheTorProject/bwscanner/pulls/43","html_url":"https://github.com/TheTorProject/bwscanner/pull/43","diff_url":"https://github.com/TheTorProject/bwscanner/pull/43.diff","patch_url":"https://github.com/TheTorProject/bwscanner/pull/43.patch"},"body":"This pull-request only concerns the partition detection scanner... and really has nothing to do with the bandwidth scanner ;-p\r\n\r\nIt may or may not be useful to collect stats about the program as it runs. I'm using the prometheus client library to count the tor circuit build success, fail and timeouts. Prometheus has a query language and i can then for instance see the per minute rate of circuit builds etc. If we want to properly tune the probe scheduler to build more circuits per second then i was thinking it would be good to have metrics that help us find performance bottle necks or at least an indication of where the ceiling is.\r\n\r\nhttps://prometheus.io/\r\nhttps://prometheus.io/docs/querying/basics/\r\nhttps://github.com/prometheus/client_python\r\n\r\nAlso note that I've added the prometheus_client as an \"extras\" dependency in setup.py meaning that the user must do this to install it:\r\n\r\n```\r\npip install .[partition_detection]\r\n```"},"comment":{"url":"https://api.github.com/repos/TheTorProject/bwscanner/issues/comments/254912779","html_url":"https://github.com/TheTorProject/bwscanner/pull/43#issuecomment-254912779","issue_url":"https://api.github.com/repos/TheTorProject/bwscanner/issues/43","id":254912779,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-10-19T19:16:07Z","updated_at":"2016-10-19T19:16:07Z","body":"\n[![Coverage Status](https://coveralls.io/builds/8416836/badge)](https://coveralls.io/builds/8416836)\n\nCoverage increased (+1.2%) to 50.877% when pulling **d35a3285a772b93e61806e89768a6b0f5ce53a3a on david415:partition_scan_add_cancel.0** into **c9c1eebba8263f2441209fc31fc3e0fe105b4559 on TheTorProject:develop**.\n"}}
{"actor":{"display_login":"coveralls"}}