{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/watchman/issues/282","repository_url":"https://api.github.com/repos/facebook/watchman","labels_url":"https://api.github.com/repos/facebook/watchman/issues/282/labels{/name}","comments_url":"https://api.github.com/repos/facebook/watchman/issues/282/comments","events_url":"https://api.github.com/repos/facebook/watchman/issues/282/events","html_url":"https://github.com/facebook/watchman/pull/282","id":160803407,"number":282,"title":"take advantage of FSEventStreamSetExclusionPaths","user":{"login":"wez","id":117777,"avatar_url":"https://avatars.githubusercontent.com/u/117777?v=3","gravatar_id":"","url":"https://api.github.com/users/wez","html_url":"https://github.com/wez","followers_url":"https://api.github.com/users/wez/followers","following_url":"https://api.github.com/users/wez/following{/other_user}","gists_url":"https://api.github.com/users/wez/gists{/gist_id}","starred_url":"https://api.github.com/users/wez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wez/subscriptions","organizations_url":"https://api.github.com/users/wez/orgs","repos_url":"https://api.github.com/users/wez/repos","events_url":"https://api.github.com/users/wez/events{/privacy}","received_events_url":"https://api.github.com/users/wez/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/watchman/labels/CLA%20Signed","name":"CLA Signed","color":"009900"},{"url":"https://api.github.com/repos/facebook/watchman/labels/GH%20Review:%20review-needed","name":"GH Review: review-needed","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-06-17T03:06:27Z","updated_at":"2016-06-17T04:59:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/watchman/pulls/282","html_url":"https://github.com/facebook/watchman/pull/282","diff_url":"https://github.com/facebook/watchman/pull/282.diff","patch_url":"https://github.com/facebook/watchman/pull/282.patch"},"body":"Summary: this isn't indexed from the main fsevents docs, but it is a\r\npublic API; if you google for it, you will find it listed in changelogs.\r\n\r\nThe header file documents that it has a limit of 8 items.  From playing\r\naround with this, if we exceed the limit, the function call will fail\r\nwith no explanation.\r\n\r\nBecause of this limit, it is advantageous to list the highest value\r\nignores in the first 8 entries of the `ignore_dirs` configuration\r\nin `.watchmanconfig`, and we therefore need an ordered list of the\r\nignores; our current datastructures are unordered maps and that results\r\nin a non-deterministic set of excluded paths on any given attempt to\r\nwatch the same dir.\r\n\r\nTest Plan: `make integration` succeeds.  I also added some\r\ninstrumentation to see what the behavior is; the exact path listed in\r\nthe exclusion paths array is delivered to our stream, but any child\r\npaths are ignored.  That's good enough for us."},"comment":{"url":"https://api.github.com/repos/facebook/watchman/issues/comments/226680833","html_url":"https://github.com/facebook/watchman/pull/282#issuecomment-226680833","issue_url":"https://api.github.com/repos/facebook/watchman/issues/282","id":226680833,"user":{"login":"sid0","id":180618,"avatar_url":"https://avatars.githubusercontent.com/u/180618?v=3","gravatar_id":"","url":"https://api.github.com/users/sid0","html_url":"https://github.com/sid0","followers_url":"https://api.github.com/users/sid0/followers","following_url":"https://api.github.com/users/sid0/following{/other_user}","gists_url":"https://api.github.com/users/sid0/gists{/gist_id}","starred_url":"https://api.github.com/users/sid0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sid0/subscriptions","organizations_url":"https://api.github.com/users/sid0/orgs","repos_url":"https://api.github.com/users/sid0/repos","events_url":"https://api.github.com/users/sid0/events{/privacy}","received_events_url":"https://api.github.com/users/sid0/received_events","type":"User","site_admin":false},"created_at":"2016-06-17T04:59:36Z","updated_at":"2016-06-17T04:59:36Z","body":"(Looks fine otherwise.)"}}
{"actor":{"display_login":"sid0"}}