{"action":"closed","number":78,"pull_request":{"url":"https://api.github.com/repos/jupyter/dockerspawner/pulls/78","id":60281565,"html_url":"https://github.com/jupyter/dockerspawner/pull/78","diff_url":"https://github.com/jupyter/dockerspawner/pull/78.diff","patch_url":"https://github.com/jupyter/dockerspawner/pull/78.patch","issue_url":"https://api.github.com/repos/jupyter/dockerspawner/issues/78","number":78,"state":"closed","locked":false,"title":"revert to \"yeild from\" to work with swarm","user":{"login":"EdwardJKim","id":6236795,"avatar_url":"https://avatars.githubusercontent.com/u/6236795?v=3","gravatar_id":"","url":"https://api.github.com/users/EdwardJKim","html_url":"https://github.com/EdwardJKim","followers_url":"https://api.github.com/users/EdwardJKim/followers","following_url":"https://api.github.com/users/EdwardJKim/following{/other_user}","gists_url":"https://api.github.com/users/EdwardJKim/gists{/gist_id}","starred_url":"https://api.github.com/users/EdwardJKim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EdwardJKim/subscriptions","organizations_url":"https://api.github.com/users/EdwardJKim/orgs","repos_url":"https://api.github.com/users/EdwardJKim/repos","events_url":"https://api.github.com/users/EdwardJKim/events{/privacy}","received_events_url":"https://api.github.com/users/EdwardJKim/received_events","type":"User","site_admin":false},"body":"Is there a particular reason why `yield from` was changed to `yield` in a535b08? With the latest master, I get the following error when I use dockerspawner with Swarm.\r\n\r\n```\r\n[E 2016-02-23 01:53:43.647 JupyterHub web:1524] Uncaught exception GET /hub/user/EdwardJKim (192.168.0.10)\r\n    HTTPServerRequest(protocol='http', host='129.114.110.10', method='GET', uri='/hub/user/EdwardJKim', version='HTTP/1.1', remote_ip='192.168.0.10', headers={'X-Forwarded-Host': '129.114.110.10', 'Remote-User': '(null)', 'Accept-Language': 'en-US,en;q=0.8,ko;q=0.6', 'X-Forwarded-For': '192.241.58.150,192.168.0.10', 'Host': '129.114.110.10', 'Referer': 'https://129.114.110.10/hub/home', 'Accept': 'text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,*/*;q=0.8', 'Accept-Encoding': 'gzip, deflate, sdch', 'Cookie': 'jupyter-hub-token=\"2|1:0|10:1456192417|17:jupyter-hub-token|44:NWRmMDY3ZmNmODI3NGNiOWEzMjUxYzk5ZDNmYTc2Nzc=|4bb0a324e2ef35d695841219516c32d9c60c06df5b134313fe4d75810e185f96\"', 'Connection': 'close', 'X-Forwarded-Proto': 'http', 'User-Agent': 'Mozilla/5.0 (X11; CrOS x86_64 7647.84.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/48.0.2564.116 Safari/537.36', 'X-Forwarded-Port': '80', 'X-Forwarded-Server': '129.114.110.10', 'Upgrade-Insecure-Requests': '1'})\r\n    Traceback (most recent call last):\r\n      File \"/opt/conda/lib/python3.5/site-packages/tornado/web.py\", line 1445, in _execute\r\n        result = yield result\r\n      File \"/opt/conda/lib/python3.5/site-packages/jupyterhub/handlers/base.py\", line 463, in get\r\n        yield self.spawn_single_user(current_user)\r\n      File \"/opt/conda/lib/python3.5/site-packages/jupyterhub/handlers/base.py\", line 296, in spawn_single_user\r\n        yield gen.with_timeout(timedelta(seconds=self.slow_spawn_timeout), f)\r\n      File \"/opt/conda/lib/python3.5/site-packages/jupyterhub/user.py\", line 202, in spawn\r\n        raise e\r\n      File \"/opt/conda/lib/python3.5/site-packages/jupyterhub/user.py\", line 183, in spawn\r\n        self.log.info(info)\r\n        yield gen.with_timeout(timedelta(seconds=spawner.start_timeout), f)\r\n      File \"/srv/jupyterhub_config/swarmspawner.py\", line 65, in start\r\n        extra_host_config=extra_host_config)\r\n      File \"/opt/conda/lib/python3.5/site-packages/dockerspawner/dockerspawner.py\", line 415, in start\r\n        ip, port = yield self.get_ip_and_port()\r\n      File \"/opt/conda/lib/python3.5/site-packages/tornado/gen.py\", line 1090, in handle_yield\r\n        self.future = convert_yielded(yielded)\r\n      File \"/opt/conda/lib/python3.5/functools.py\", line 743, in wrapper\r\n        return dispatch(args[0].__class__)(*args, **kw)\r\n      File \"/opt/conda/lib/python3.5/site-packages/tornado/gen.py\", line 1222, in convert_yielded\r\n        raise BadYieldError(\"yielded unknown object %r\" % (yielded,))\r\n    tornado.gen.BadYieldError: yielded unknown object <generator object DockerSpawner.get_ip_and_port at 0x7f44d8502258>\r\n```\r\n\r\nReverting to `yield from` fixes the error.","created_at":"2016-02-23T03:20:05Z","updated_at":"2016-02-23T08:14:55Z","closed_at":"2016-02-23T08:14:55Z","merged_at":"2016-02-23T08:14:55Z","merge_commit_sha":"f0e16d22455facee3d9c1f6d09081b55705df418","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jupyter/dockerspawner/pulls/78/commits","review_comments_url":"https://api.github.com/repos/jupyter/dockerspawner/pulls/78/comments","review_comment_url":"https://api.github.com/repos/jupyter/dockerspawner/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jupyter/dockerspawner/issues/78/comments","statuses_url":"https://api.github.com/repos/jupyter/dockerspawner/statuses/47e0f9e585cb4c925b3b5f6db46c17eeed0e0444","head":{"label":"EdwardJKim:swarm","ref":"swarm","sha":"47e0f9e585cb4c925b3b5f6db46c17eeed0e0444","user":{"login":"EdwardJKim","id":6236795,"avatar_url":"https://avatars.githubusercontent.com/u/6236795?v=3","gravatar_id":"","url":"https://api.github.com/users/EdwardJKim","html_url":"https://github.com/EdwardJKim","followers_url":"https://api.github.com/users/EdwardJKim/followers","following_url":"https://api.github.com/users/EdwardJKim/following{/other_user}","gists_url":"https://api.github.com/users/EdwardJKim/gists{/gist_id}","starred_url":"https://api.github.com/users/EdwardJKim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EdwardJKim/subscriptions","organizations_url":"https://api.github.com/users/EdwardJKim/orgs","repos_url":"https://api.github.com/users/EdwardJKim/repos","events_url":"https://api.github.com/users/EdwardJKim/events{/privacy}","received_events_url":"https://api.github.com/users/EdwardJKim/received_events","type":"User","site_admin":false},"repo":{"id":52324283,"name":"dockerspawner","full_name":"EdwardJKim/dockerspawner","owner":{"login":"EdwardJKim","id":6236795,"avatar_url":"https://avatars.githubusercontent.com/u/6236795?v=3","gravatar_id":"","url":"https://api.github.com/users/EdwardJKim","html_url":"https://github.com/EdwardJKim","followers_url":"https://api.github.com/users/EdwardJKim/followers","following_url":"https://api.github.com/users/EdwardJKim/following{/other_user}","gists_url":"https://api.github.com/users/EdwardJKim/gists{/gist_id}","starred_url":"https://api.github.com/users/EdwardJKim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EdwardJKim/subscriptions","organizations_url":"https://api.github.com/users/EdwardJKim/orgs","repos_url":"https://api.github.com/users/EdwardJKim/repos","events_url":"https://api.github.com/users/EdwardJKim/events{/privacy}","received_events_url":"https://api.github.com/users/EdwardJKim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/EdwardJKim/dockerspawner","description":"Spawns JupyterHub user servers in Docker containers ","fork":true,"url":"https://api.github.com/repos/EdwardJKim/dockerspawner","forks_url":"https://api.github.com/repos/EdwardJKim/dockerspawner/forks","keys_url":"https://api.github.com/repos/EdwardJKim/dockerspawner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EdwardJKim/dockerspawner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EdwardJKim/dockerspawner/teams","hooks_url":"https://api.github.com/repos/EdwardJKim/dockerspawner/hooks","issue_events_url":"https://api.github.com/repos/EdwardJKim/dockerspawner/issues/events{/number}","events_url":"https://api.github.com/repos/EdwardJKim/dockerspawner/events","assignees_url":"https://api.github.com/repos/EdwardJKim/dockerspawner/assignees{/user}","branches_url":"https://api.github.com/repos/EdwardJKim/dockerspawner/branches{/branch}","tags_url":"https://api.github.com/repos/EdwardJKim/dockerspawner/tags","blobs_url":"https://api.github.com/repos/EdwardJKim/dockerspawner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EdwardJKim/dockerspawner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EdwardJKim/dockerspawner/git/refs{/sha}","trees_url":"https://api.github.com/repos/EdwardJKim/dockerspawner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EdwardJKim/dockerspawner/statuses/{sha}","languages_url":"https://api.github.com/repos/EdwardJKim/dockerspawner/languages","stargazers_url":"https://api.github.com/repos/EdwardJKim/dockerspawner/stargazers","contributors_url":"https://api.github.com/repos/EdwardJKim/dockerspawner/contributors","subscribers_url":"https://api.github.com/repos/EdwardJKim/dockerspawner/subscribers","subscription_url":"https://api.github.com/repos/EdwardJKim/dockerspawner/subscription","commits_url":"https://api.github.com/repos/EdwardJKim/dockerspawner/commits{/sha}","git_commits_url":"https://api.github.com/repos/EdwardJKim/dockerspawner/git/commits{/sha}","comments_url":"https://api.github.com/repos/EdwardJKim/dockerspawner/comments{/number}","issue_comment_url":"https://api.github.com/repos/EdwardJKim/dockerspawner/issues/comments{/number}","contents_url":"https://api.github.com/repos/EdwardJKim/dockerspawner/contents/{+path}","compare_url":"https://api.github.com/repos/EdwardJKim/dockerspawner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EdwardJKim/dockerspawner/merges","archive_url":"https://api.github.com/repos/EdwardJKim/dockerspawner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EdwardJKim/dockerspawner/downloads","issues_url":"https://api.github.com/repos/EdwardJKim/dockerspawner/issues{/number}","pulls_url":"https://api.github.com/repos/EdwardJKim/dockerspawner/pulls{/number}","milestones_url":"https://api.github.com/repos/EdwardJKim/dockerspawner/milestones{/number}","notifications_url":"https://api.github.com/repos/EdwardJKim/dockerspawner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EdwardJKim/dockerspawner/labels{/name}","releases_url":"https://api.github.com/repos/EdwardJKim/dockerspawner/releases{/id}","deployments_url":"https://api.github.com/repos/EdwardJKim/dockerspawner/deployments","created_at":"2016-02-23T02:45:47Z","updated_at":"2016-02-23T02:45:47Z","pushed_at":"2016-02-23T02:49:05Z","git_url":"git://github.com/EdwardJKim/dockerspawner.git","ssh_url":"git@github.com:EdwardJKim/dockerspawner.git","clone_url":"https://github.com/EdwardJKim/dockerspawner.git","svn_url":"https://github.com/EdwardJKim/dockerspawner","homepage":"","size":115,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jupyter:master","ref":"master","sha":"57fb98252dc26c5af051752cdd46179aefe3735a","user":{"login":"jupyter","id":7388996,"avatar_url":"https://avatars.githubusercontent.com/u/7388996?v=3","gravatar_id":"","url":"https://api.github.com/users/jupyter","html_url":"https://github.com/jupyter","followers_url":"https://api.github.com/users/jupyter/followers","following_url":"https://api.github.com/users/jupyter/following{/other_user}","gists_url":"https://api.github.com/users/jupyter/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyter/subscriptions","organizations_url":"https://api.github.com/users/jupyter/orgs","repos_url":"https://api.github.com/users/jupyter/repos","events_url":"https://api.github.com/users/jupyter/events{/privacy}","received_events_url":"https://api.github.com/users/jupyter/received_events","type":"Organization","site_admin":false},"repo":{"id":24513798,"name":"dockerspawner","full_name":"jupyter/dockerspawner","owner":{"login":"jupyter","id":7388996,"avatar_url":"https://avatars.githubusercontent.com/u/7388996?v=3","gravatar_id":"","url":"https://api.github.com/users/jupyter","html_url":"https://github.com/jupyter","followers_url":"https://api.github.com/users/jupyter/followers","following_url":"https://api.github.com/users/jupyter/following{/other_user}","gists_url":"https://api.github.com/users/jupyter/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyter/subscriptions","organizations_url":"https://api.github.com/users/jupyter/orgs","repos_url":"https://api.github.com/users/jupyter/repos","events_url":"https://api.github.com/users/jupyter/events{/privacy}","received_events_url":"https://api.github.com/users/jupyter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jupyter/dockerspawner","description":"Spawns JupyterHub user servers in Docker containers ","fork":false,"url":"https://api.github.com/repos/jupyter/dockerspawner","forks_url":"https://api.github.com/repos/jupyter/dockerspawner/forks","keys_url":"https://api.github.com/repos/jupyter/dockerspawner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jupyter/dockerspawner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jupyter/dockerspawner/teams","hooks_url":"https://api.github.com/repos/jupyter/dockerspawner/hooks","issue_events_url":"https://api.github.com/repos/jupyter/dockerspawner/issues/events{/number}","events_url":"https://api.github.com/repos/jupyter/dockerspawner/events","assignees_url":"https://api.github.com/repos/jupyter/dockerspawner/assignees{/user}","branches_url":"https://api.github.com/repos/jupyter/dockerspawner/branches{/branch}","tags_url":"https://api.github.com/repos/jupyter/dockerspawner/tags","blobs_url":"https://api.github.com/repos/jupyter/dockerspawner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jupyter/dockerspawner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jupyter/dockerspawner/git/refs{/sha}","trees_url":"https://api.github.com/repos/jupyter/dockerspawner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jupyter/dockerspawner/statuses/{sha}","languages_url":"https://api.github.com/repos/jupyter/dockerspawner/languages","stargazers_url":"https://api.github.com/repos/jupyter/dockerspawner/stargazers","contributors_url":"https://api.github.com/repos/jupyter/dockerspawner/contributors","subscribers_url":"https://api.github.com/repos/jupyter/dockerspawner/subscribers","subscription_url":"https://api.github.com/repos/jupyter/dockerspawner/subscription","commits_url":"https://api.github.com/repos/jupyter/dockerspawner/commits{/sha}","git_commits_url":"https://api.github.com/repos/jupyter/dockerspawner/git/commits{/sha}","comments_url":"https://api.github.com/repos/jupyter/dockerspawner/comments{/number}","issue_comment_url":"https://api.github.com/repos/jupyter/dockerspawner/issues/comments{/number}","contents_url":"https://api.github.com/repos/jupyter/dockerspawner/contents/{+path}","compare_url":"https://api.github.com/repos/jupyter/dockerspawner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jupyter/dockerspawner/merges","archive_url":"https://api.github.com/repos/jupyter/dockerspawner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jupyter/dockerspawner/downloads","issues_url":"https://api.github.com/repos/jupyter/dockerspawner/issues{/number}","pulls_url":"https://api.github.com/repos/jupyter/dockerspawner/pulls{/number}","milestones_url":"https://api.github.com/repos/jupyter/dockerspawner/milestones{/number}","notifications_url":"https://api.github.com/repos/jupyter/dockerspawner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jupyter/dockerspawner/labels{/name}","releases_url":"https://api.github.com/repos/jupyter/dockerspawner/releases{/id}","deployments_url":"https://api.github.com/repos/jupyter/dockerspawner/deployments","created_at":"2014-09-26T20:08:26Z","updated_at":"2016-02-22T20:14:56Z","pushed_at":"2016-02-23T08:14:55Z","git_url":"git://github.com/jupyter/dockerspawner.git","ssh_url":"git@github.com:jupyter/dockerspawner.git","clone_url":"https://github.com/jupyter/dockerspawner.git","svn_url":"https://github.com/jupyter/dockerspawner","homepage":"","size":196,"stargazers_count":61,"watchers_count":61,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":8,"forks":46,"open_issues":8,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jupyter/dockerspawner/pulls/78"},"html":{"href":"https://github.com/jupyter/dockerspawner/pull/78"},"issue":{"href":"https://api.github.com/repos/jupyter/dockerspawner/issues/78"},"comments":{"href":"https://api.github.com/repos/jupyter/dockerspawner/issues/78/comments"},"review_comments":{"href":"https://api.github.com/repos/jupyter/dockerspawner/pulls/78/comments"},"review_comment":{"href":"https://api.github.com/repos/jupyter/dockerspawner/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jupyter/dockerspawner/pulls/78/commits"},"statuses":{"href":"https://api.github.com/repos/jupyter/dockerspawner/statuses/47e0f9e585cb4c925b3b5f6db46c17eeed0e0444"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"minrk","id":151929,"avatar_url":"https://avatars.githubusercontent.com/u/151929?v=3","gravatar_id":"","url":"https://api.github.com/users/minrk","html_url":"https://github.com/minrk","followers_url":"https://api.github.com/users/minrk/followers","following_url":"https://api.github.com/users/minrk/following{/other_user}","gists_url":"https://api.github.com/users/minrk/gists{/gist_id}","starred_url":"https://api.github.com/users/minrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minrk/subscriptions","organizations_url":"https://api.github.com/users/minrk/orgs","repos_url":"https://api.github.com/users/minrk/repos","events_url":"https://api.github.com/users/minrk/events{/privacy}","received_events_url":"https://api.github.com/users/minrk/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}