{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/comments/80109447","id":80109447,"diff_hunk":"@@ -178,6 +178,22 @@ TEST_F(DBOptionsTest, EnableAutoCompactionAndTriggerStall) {\n   }\n }\n \n+TEST_F(DBOptionsTest, EnableAutoCompactionShouldTriggerCompaction) {\n+  Options options;\n+  options.create_if_missing = true;\n+  options.level0_file_num_compaction_trigger = 1000;\n+  Reopen(options);\n+  for (int i = 0; i < 3; i++) {\n+    ASSERT_OK(Put(ToString(i), ToString(i)));\n+    Flush();\n+  }\n+  ASSERT_EQ(\"3\", FilesPerLevel());\n+  ASSERT_OK(\n+      dbfull()->SetOptions({{\"level0_file_num_compaction_trigger\", \"3\"}}));\n+  dbfull()->TEST_WaitForCompact();\n+  ASSERT_LT(\"0,1\", FilesPerLevel());","path":"db/db_options_test.cc","position":26,"original_position":26,"commit_id":"01167accbe6b906f5b0cccc2e32ce083992f190c","original_commit_id":"01167accbe6b906f5b0cccc2e32ce083992f190c","user":{"login":"IslamAbdelRahman","id":1676006,"avatar_url":"https://avatars.githubusercontent.com/u/1676006?v=3","gravatar_id":"","url":"https://api.github.com/users/IslamAbdelRahman","html_url":"https://github.com/IslamAbdelRahman","followers_url":"https://api.github.com/users/IslamAbdelRahman/followers","following_url":"https://api.github.com/users/IslamAbdelRahman/following{/other_user}","gists_url":"https://api.github.com/users/IslamAbdelRahman/gists{/gist_id}","starred_url":"https://api.github.com/users/IslamAbdelRahman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IslamAbdelRahman/subscriptions","organizations_url":"https://api.github.com/users/IslamAbdelRahman/orgs","repos_url":"https://api.github.com/users/IslamAbdelRahman/repos","events_url":"https://api.github.com/users/IslamAbdelRahman/events{/privacy}","received_events_url":"https://api.github.com/users/IslamAbdelRahman/received_events","type":"User","site_admin":false},"body":"did you mean ASSERT_EQ instead of ASSERT_LT","created_at":"2016-09-22T18:44:59Z","updated_at":"2016-09-22T18:44:59Z","html_url":"https://github.com/facebook/rocksdb/pull/1346#discussion_r80109447","pull_request_url":"https://api.github.com/repos/facebook/rocksdb/pulls/1346","_links":{"self":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/comments/80109447"},"html":{"href":"https://github.com/facebook/rocksdb/pull/1346#discussion_r80109447"},"pull_request":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/1346"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/1346","id":86078419,"html_url":"https://github.com/facebook/rocksdb/pull/1346","diff_url":"https://github.com/facebook/rocksdb/pull/1346.diff","patch_url":"https://github.com/facebook/rocksdb/pull/1346.patch","issue_url":"https://api.github.com/repos/facebook/rocksdb/issues/1346","number":1346,"state":"open","locked":false,"title":"Recompute compaction score on SetOptions","user":{"login":"yiwu-arbug","id":2606959,"avatar_url":"https://avatars.githubusercontent.com/u/2606959?v=3","gravatar_id":"","url":"https://api.github.com/users/yiwu-arbug","html_url":"https://github.com/yiwu-arbug","followers_url":"https://api.github.com/users/yiwu-arbug/followers","following_url":"https://api.github.com/users/yiwu-arbug/following{/other_user}","gists_url":"https://api.github.com/users/yiwu-arbug/gists{/gist_id}","starred_url":"https://api.github.com/users/yiwu-arbug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiwu-arbug/subscriptions","organizations_url":"https://api.github.com/users/yiwu-arbug/orgs","repos_url":"https://api.github.com/users/yiwu-arbug/repos","events_url":"https://api.github.com/users/yiwu-arbug/events{/privacy}","received_events_url":"https://api.github.com/users/yiwu-arbug/received_events","type":"User","site_admin":false},"body":"Summary: We didn't recompute compaction score on SetOptions, and end up not having compaction if no flush happens afterward. The PR fixing it.\r\n\r\nTest Plan: See unit test.\r\n\r\nDifferential Revision: https://reviews.facebook.net/D64167","created_at":"2016-09-21T00:14:33Z","updated_at":"2016-09-22T18:44:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"46cdf4eaa0d285fa1049531bfda8df71c1fc4ba8","assignee":{"login":"siying","id":5334567,"avatar_url":"https://avatars.githubusercontent.com/u/5334567?v=3","gravatar_id":"","url":"https://api.github.com/users/siying","html_url":"https://github.com/siying","followers_url":"https://api.github.com/users/siying/followers","following_url":"https://api.github.com/users/siying/following{/other_user}","gists_url":"https://api.github.com/users/siying/gists{/gist_id}","starred_url":"https://api.github.com/users/siying/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siying/subscriptions","organizations_url":"https://api.github.com/users/siying/orgs","repos_url":"https://api.github.com/users/siying/repos","events_url":"https://api.github.com/users/siying/events{/privacy}","received_events_url":"https://api.github.com/users/siying/received_events","type":"User","site_admin":false},"assignees":[{"login":"siying","id":5334567,"avatar_url":"https://avatars.githubusercontent.com/u/5334567?v=3","gravatar_id":"","url":"https://api.github.com/users/siying","html_url":"https://github.com/siying","followers_url":"https://api.github.com/users/siying/followers","following_url":"https://api.github.com/users/siying/following{/other_user}","gists_url":"https://api.github.com/users/siying/gists{/gist_id}","starred_url":"https://api.github.com/users/siying/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siying/subscriptions","organizations_url":"https://api.github.com/users/siying/orgs","repos_url":"https://api.github.com/users/siying/repos","events_url":"https://api.github.com/users/siying/events{/privacy}","received_events_url":"https://api.github.com/users/siying/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/rocksdb/pulls/1346/commits","review_comments_url":"https://api.github.com/repos/facebook/rocksdb/pulls/1346/comments","review_comment_url":"https://api.github.com/repos/facebook/rocksdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/rocksdb/issues/1346/comments","statuses_url":"https://api.github.com/repos/facebook/rocksdb/statuses/01167accbe6b906f5b0cccc2e32ce083992f190c","head":{"label":"yiwu-arbug:score","ref":"score","sha":"01167accbe6b906f5b0cccc2e32ce083992f190c","user":{"login":"yiwu-arbug","id":2606959,"avatar_url":"https://avatars.githubusercontent.com/u/2606959?v=3","gravatar_id":"","url":"https://api.github.com/users/yiwu-arbug","html_url":"https://github.com/yiwu-arbug","followers_url":"https://api.github.com/users/yiwu-arbug/followers","following_url":"https://api.github.com/users/yiwu-arbug/following{/other_user}","gists_url":"https://api.github.com/users/yiwu-arbug/gists{/gist_id}","starred_url":"https://api.github.com/users/yiwu-arbug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiwu-arbug/subscriptions","organizations_url":"https://api.github.com/users/yiwu-arbug/orgs","repos_url":"https://api.github.com/users/yiwu-arbug/repos","events_url":"https://api.github.com/users/yiwu-arbug/events{/privacy}","received_events_url":"https://api.github.com/users/yiwu-arbug/received_events","type":"User","site_admin":false},"repo":{"id":68760384,"name":"rocksdb","full_name":"yiwu-arbug/rocksdb","owner":{"login":"yiwu-arbug","id":2606959,"avatar_url":"https://avatars.githubusercontent.com/u/2606959?v=3","gravatar_id":"","url":"https://api.github.com/users/yiwu-arbug","html_url":"https://github.com/yiwu-arbug","followers_url":"https://api.github.com/users/yiwu-arbug/followers","following_url":"https://api.github.com/users/yiwu-arbug/following{/other_user}","gists_url":"https://api.github.com/users/yiwu-arbug/gists{/gist_id}","starred_url":"https://api.github.com/users/yiwu-arbug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiwu-arbug/subscriptions","organizations_url":"https://api.github.com/users/yiwu-arbug/orgs","repos_url":"https://api.github.com/users/yiwu-arbug/repos","events_url":"https://api.github.com/users/yiwu-arbug/events{/privacy}","received_events_url":"https://api.github.com/users/yiwu-arbug/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yiwu-arbug/rocksdb","description":"A library that provides an embeddable, persistent key-value store for fast storage.","fork":true,"url":"https://api.github.com/repos/yiwu-arbug/rocksdb","forks_url":"https://api.github.com/repos/yiwu-arbug/rocksdb/forks","keys_url":"https://api.github.com/repos/yiwu-arbug/rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yiwu-arbug/rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yiwu-arbug/rocksdb/teams","hooks_url":"https://api.github.com/repos/yiwu-arbug/rocksdb/hooks","issue_events_url":"https://api.github.com/repos/yiwu-arbug/rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/yiwu-arbug/rocksdb/events","assignees_url":"https://api.github.com/repos/yiwu-arbug/rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/yiwu-arbug/rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/yiwu-arbug/rocksdb/tags","blobs_url":"https://api.github.com/repos/yiwu-arbug/rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yiwu-arbug/rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yiwu-arbug/rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/yiwu-arbug/rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yiwu-arbug/rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/yiwu-arbug/rocksdb/languages","stargazers_url":"https://api.github.com/repos/yiwu-arbug/rocksdb/stargazers","contributors_url":"https://api.github.com/repos/yiwu-arbug/rocksdb/contributors","subscribers_url":"https://api.github.com/repos/yiwu-arbug/rocksdb/subscribers","subscription_url":"https://api.github.com/repos/yiwu-arbug/rocksdb/subscription","commits_url":"https://api.github.com/repos/yiwu-arbug/rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/yiwu-arbug/rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/yiwu-arbug/rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/yiwu-arbug/rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/yiwu-arbug/rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/yiwu-arbug/rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yiwu-arbug/rocksdb/merges","archive_url":"https://api.github.com/repos/yiwu-arbug/rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yiwu-arbug/rocksdb/downloads","issues_url":"https://api.github.com/repos/yiwu-arbug/rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/yiwu-arbug/rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/yiwu-arbug/rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/yiwu-arbug/rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yiwu-arbug/rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/yiwu-arbug/rocksdb/releases{/id}","deployments_url":"https://api.github.com/repos/yiwu-arbug/rocksdb/deployments","created_at":"2016-09-20T23:06:58Z","updated_at":"2016-09-20T23:07:03Z","pushed_at":"2016-09-22T18:20:03Z","git_url":"git://github.com/yiwu-arbug/rocksdb.git","ssh_url":"git@github.com:yiwu-arbug/rocksdb.git","clone_url":"https://github.com/yiwu-arbug/rocksdb.git","svn_url":"https://github.com/yiwu-arbug/rocksdb","homepage":"http://rocksdb.org","size":45382,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"da5a9a65c1a50cb11286a7096795ec415dcd1ede","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":6934395,"name":"rocksdb","full_name":"facebook/rocksdb","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/rocksdb","description":"A library that provides an embeddable, persistent key-value store for fast storage.","fork":false,"url":"https://api.github.com/repos/facebook/rocksdb","forks_url":"https://api.github.com/repos/facebook/rocksdb/forks","keys_url":"https://api.github.com/repos/facebook/rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/rocksdb/teams","hooks_url":"https://api.github.com/repos/facebook/rocksdb/hooks","issue_events_url":"https://api.github.com/repos/facebook/rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/rocksdb/events","assignees_url":"https://api.github.com/repos/facebook/rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/rocksdb/tags","blobs_url":"https://api.github.com/repos/facebook/rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/rocksdb/languages","stargazers_url":"https://api.github.com/repos/facebook/rocksdb/stargazers","contributors_url":"https://api.github.com/repos/facebook/rocksdb/contributors","subscribers_url":"https://api.github.com/repos/facebook/rocksdb/subscribers","subscription_url":"https://api.github.com/repos/facebook/rocksdb/subscription","commits_url":"https://api.github.com/repos/facebook/rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/rocksdb/merges","archive_url":"https://api.github.com/repos/facebook/rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/rocksdb/downloads","issues_url":"https://api.github.com/repos/facebook/rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/facebook/rocksdb/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/rocksdb/deployments","created_at":"2012-11-30T06:16:18Z","updated_at":"2016-09-22T14:08:53Z","pushed_at":"2016-09-22T18:20:05Z","git_url":"git://github.com/facebook/rocksdb.git","ssh_url":"git@github.com:facebook/rocksdb.git","clone_url":"https://github.com/facebook/rocksdb.git","svn_url":"https://github.com/facebook/rocksdb","homepage":"http://rocksdb.org","size":127695,"stargazers_count":6106,"watchers_count":6106,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1257,"mirror_url":null,"open_issues_count":258,"forks":1257,"open_issues":258,"watchers":6106,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/1346"},"html":{"href":"https://github.com/facebook/rocksdb/pull/1346"},"issue":{"href":"https://api.github.com/repos/facebook/rocksdb/issues/1346"},"comments":{"href":"https://api.github.com/repos/facebook/rocksdb/issues/1346/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/1346/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/1346/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/rocksdb/statuses/01167accbe6b906f5b0cccc2e32ce083992f190c"}}}}
{"actor":{"display_login":"IslamAbdelRahman"}}