{"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/rust-prometheus/pulls/comments/78935612","id":78935612,"diff_hunk":"@@ -11,6 +11,7 @@\n // See the License for the specific language governing permissions and\n // limitations under the License.\n \n+#![cfg_attr(test, deny(warnings))]","path":"src/lib.rs","position":4,"original_position":4,"commit_id":"a2dcfb4696186d74372a566f4aa881356844bfee","original_commit_id":"a2dcfb4696186d74372a566f4aa881356844bfee","user":{"login":"BusyJay","id":1701473,"avatar_url":"https://avatars.githubusercontent.com/u/1701473?v=3","gravatar_id":"","url":"https://api.github.com/users/BusyJay","html_url":"https://github.com/BusyJay","followers_url":"https://api.github.com/users/BusyJay/followers","following_url":"https://api.github.com/users/BusyJay/following{/other_user}","gists_url":"https://api.github.com/users/BusyJay/gists{/gist_id}","starred_url":"https://api.github.com/users/BusyJay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BusyJay/subscriptions","organizations_url":"https://api.github.com/users/BusyJay/orgs","repos_url":"https://api.github.com/users/BusyJay/repos","events_url":"https://api.github.com/users/BusyJay/events{/privacy}","received_events_url":"https://api.github.com/users/BusyJay/received_events","type":"User","site_admin":false},"body":"I don't think CI is guaranteed to run the same test cases with the same configuration in same environment as contributors'. It's normal that local tests succeed but CI fails. What is actually needed is clear fail message and logs.","created_at":"2016-09-15T10:46:31Z","updated_at":"2016-09-15T10:46:31Z","html_url":"https://github.com/pingcap/rust-prometheus/pull/60#discussion_r78935612","pull_request_url":"https://api.github.com/repos/pingcap/rust-prometheus/pulls/60","_links":{"self":{"href":"https://api.github.com/repos/pingcap/rust-prometheus/pulls/comments/78935612"},"html":{"href":"https://github.com/pingcap/rust-prometheus/pull/60#discussion_r78935612"},"pull_request":{"href":"https://api.github.com/repos/pingcap/rust-prometheus/pulls/60"}}},"pull_request":{"url":"https://api.github.com/repos/pingcap/rust-prometheus/pulls/60","id":85347286,"html_url":"https://github.com/pingcap/rust-prometheus/pull/60","diff_url":"https://github.com/pingcap/rust-prometheus/pull/60.diff","patch_url":"https://github.com/pingcap/rust-prometheus/pull/60.patch","issue_url":"https://api.github.com/repos/pingcap/rust-prometheus/issues/60","number":60,"state":"open","locked":false,"title":"desc: make clippy happy","user":{"login":"overvenus","id":2150711,"avatar_url":"https://avatars.githubusercontent.com/u/2150711?v=3","gravatar_id":"","url":"https://api.github.com/users/overvenus","html_url":"https://github.com/overvenus","followers_url":"https://api.github.com/users/overvenus/followers","following_url":"https://api.github.com/users/overvenus/following{/other_user}","gists_url":"https://api.github.com/users/overvenus/gists{/gist_id}","starred_url":"https://api.github.com/users/overvenus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/overvenus/subscriptions","organizations_url":"https://api.github.com/users/overvenus/orgs","repos_url":"https://api.github.com/users/overvenus/repos","events_url":"https://api.github.com/users/overvenus/events{/privacy}","received_events_url":"https://api.github.com/users/overvenus/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-15T05:30:21Z","updated_at":"2016-09-15T10:46:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e840a6cec19cdb4cbd138e8c37010c3f533e7ded","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/rust-prometheus/pulls/60/commits","review_comments_url":"https://api.github.com/repos/pingcap/rust-prometheus/pulls/60/comments","review_comment_url":"https://api.github.com/repos/pingcap/rust-prometheus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/rust-prometheus/issues/60/comments","statuses_url":"https://api.github.com/repos/pingcap/rust-prometheus/statuses/a2dcfb4696186d74372a566f4aa881356844bfee","head":{"label":"overvenus:make-clippy-happy","ref":"make-clippy-happy","sha":"a2dcfb4696186d74372a566f4aa881356844bfee","user":{"login":"overvenus","id":2150711,"avatar_url":"https://avatars.githubusercontent.com/u/2150711?v=3","gravatar_id":"","url":"https://api.github.com/users/overvenus","html_url":"https://github.com/overvenus","followers_url":"https://api.github.com/users/overvenus/followers","following_url":"https://api.github.com/users/overvenus/following{/other_user}","gists_url":"https://api.github.com/users/overvenus/gists{/gist_id}","starred_url":"https://api.github.com/users/overvenus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/overvenus/subscriptions","organizations_url":"https://api.github.com/users/overvenus/orgs","repos_url":"https://api.github.com/users/overvenus/repos","events_url":"https://api.github.com/users/overvenus/events{/privacy}","received_events_url":"https://api.github.com/users/overvenus/received_events","type":"User","site_admin":false},"repo":{"id":66003047,"name":"rust-prometheus","full_name":"overvenus/rust-prometheus","owner":{"login":"overvenus","id":2150711,"avatar_url":"https://avatars.githubusercontent.com/u/2150711?v=3","gravatar_id":"","url":"https://api.github.com/users/overvenus","html_url":"https://github.com/overvenus","followers_url":"https://api.github.com/users/overvenus/followers","following_url":"https://api.github.com/users/overvenus/following{/other_user}","gists_url":"https://api.github.com/users/overvenus/gists{/gist_id}","starred_url":"https://api.github.com/users/overvenus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/overvenus/subscriptions","organizations_url":"https://api.github.com/users/overvenus/orgs","repos_url":"https://api.github.com/users/overvenus/repos","events_url":"https://api.github.com/users/overvenus/events{/privacy}","received_events_url":"https://api.github.com/users/overvenus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/overvenus/rust-prometheus","description":"Prometheus instrumentation library for Rust applications","fork":true,"url":"https://api.github.com/repos/overvenus/rust-prometheus","forks_url":"https://api.github.com/repos/overvenus/rust-prometheus/forks","keys_url":"https://api.github.com/repos/overvenus/rust-prometheus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/overvenus/rust-prometheus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/overvenus/rust-prometheus/teams","hooks_url":"https://api.github.com/repos/overvenus/rust-prometheus/hooks","issue_events_url":"https://api.github.com/repos/overvenus/rust-prometheus/issues/events{/number}","events_url":"https://api.github.com/repos/overvenus/rust-prometheus/events","assignees_url":"https://api.github.com/repos/overvenus/rust-prometheus/assignees{/user}","branches_url":"https://api.github.com/repos/overvenus/rust-prometheus/branches{/branch}","tags_url":"https://api.github.com/repos/overvenus/rust-prometheus/tags","blobs_url":"https://api.github.com/repos/overvenus/rust-prometheus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/overvenus/rust-prometheus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/overvenus/rust-prometheus/git/refs{/sha}","trees_url":"https://api.github.com/repos/overvenus/rust-prometheus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/overvenus/rust-prometheus/statuses/{sha}","languages_url":"https://api.github.com/repos/overvenus/rust-prometheus/languages","stargazers_url":"https://api.github.com/repos/overvenus/rust-prometheus/stargazers","contributors_url":"https://api.github.com/repos/overvenus/rust-prometheus/contributors","subscribers_url":"https://api.github.com/repos/overvenus/rust-prometheus/subscribers","subscription_url":"https://api.github.com/repos/overvenus/rust-prometheus/subscription","commits_url":"https://api.github.com/repos/overvenus/rust-prometheus/commits{/sha}","git_commits_url":"https://api.github.com/repos/overvenus/rust-prometheus/git/commits{/sha}","comments_url":"https://api.github.com/repos/overvenus/rust-prometheus/comments{/number}","issue_comment_url":"https://api.github.com/repos/overvenus/rust-prometheus/issues/comments{/number}","contents_url":"https://api.github.com/repos/overvenus/rust-prometheus/contents/{+path}","compare_url":"https://api.github.com/repos/overvenus/rust-prometheus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/overvenus/rust-prometheus/merges","archive_url":"https://api.github.com/repos/overvenus/rust-prometheus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/overvenus/rust-prometheus/downloads","issues_url":"https://api.github.com/repos/overvenus/rust-prometheus/issues{/number}","pulls_url":"https://api.github.com/repos/overvenus/rust-prometheus/pulls{/number}","milestones_url":"https://api.github.com/repos/overvenus/rust-prometheus/milestones{/number}","notifications_url":"https://api.github.com/repos/overvenus/rust-prometheus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/overvenus/rust-prometheus/labels{/name}","releases_url":"https://api.github.com/repos/overvenus/rust-prometheus/releases{/id}","deployments_url":"https://api.github.com/repos/overvenus/rust-prometheus/deployments","created_at":"2016-08-18T14:17:28Z","updated_at":"2016-08-18T14:17:30Z","pushed_at":"2016-09-15T05:58:08Z","git_url":"git://github.com/overvenus/rust-prometheus.git","ssh_url":"git@github.com:overvenus/rust-prometheus.git","clone_url":"https://github.com/overvenus/rust-prometheus.git","svn_url":"https://github.com/overvenus/rust-prometheus","homepage":null,"size":158,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"d5dfe2845289ceeffd0e2c76b5c08245dbc0567f","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":65430363,"name":"rust-prometheus","full_name":"pingcap/rust-prometheus","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/rust-prometheus","description":"Prometheus instrumentation library for Rust applications","fork":false,"url":"https://api.github.com/repos/pingcap/rust-prometheus","forks_url":"https://api.github.com/repos/pingcap/rust-prometheus/forks","keys_url":"https://api.github.com/repos/pingcap/rust-prometheus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/rust-prometheus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/rust-prometheus/teams","hooks_url":"https://api.github.com/repos/pingcap/rust-prometheus/hooks","issue_events_url":"https://api.github.com/repos/pingcap/rust-prometheus/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/rust-prometheus/events","assignees_url":"https://api.github.com/repos/pingcap/rust-prometheus/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/rust-prometheus/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/rust-prometheus/tags","blobs_url":"https://api.github.com/repos/pingcap/rust-prometheus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/rust-prometheus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/rust-prometheus/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/rust-prometheus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/rust-prometheus/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/rust-prometheus/languages","stargazers_url":"https://api.github.com/repos/pingcap/rust-prometheus/stargazers","contributors_url":"https://api.github.com/repos/pingcap/rust-prometheus/contributors","subscribers_url":"https://api.github.com/repos/pingcap/rust-prometheus/subscribers","subscription_url":"https://api.github.com/repos/pingcap/rust-prometheus/subscription","commits_url":"https://api.github.com/repos/pingcap/rust-prometheus/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/rust-prometheus/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/rust-prometheus/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/rust-prometheus/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/rust-prometheus/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/rust-prometheus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/rust-prometheus/merges","archive_url":"https://api.github.com/repos/pingcap/rust-prometheus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/rust-prometheus/downloads","issues_url":"https://api.github.com/repos/pingcap/rust-prometheus/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/rust-prometheus/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/rust-prometheus/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/rust-prometheus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/rust-prometheus/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/rust-prometheus/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/rust-prometheus/deployments","created_at":"2016-08-11T02:06:25Z","updated_at":"2016-09-13T21:01:50Z","pushed_at":"2016-09-15T05:58:09Z","git_url":"git://github.com/pingcap/rust-prometheus.git","ssh_url":"git@github.com:pingcap/rust-prometheus.git","clone_url":"https://github.com/pingcap/rust-prometheus.git","svn_url":"https://github.com/pingcap/rust-prometheus","homepage":null,"size":173,"stargazers_count":13,"watchers_count":13,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":14,"forks":2,"open_issues":14,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/rust-prometheus/pulls/60"},"html":{"href":"https://github.com/pingcap/rust-prometheus/pull/60"},"issue":{"href":"https://api.github.com/repos/pingcap/rust-prometheus/issues/60"},"comments":{"href":"https://api.github.com/repos/pingcap/rust-prometheus/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/rust-prometheus/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/rust-prometheus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/rust-prometheus/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/rust-prometheus/statuses/a2dcfb4696186d74372a566f4aa881356844bfee"}}}}
{"actor":{"display_login":"BusyJay"}}