{"action":"created","comment":{"url":"https://api.github.com/repos/interledger/five-bells-connector/pulls/comments/57661192","id":57661192,"diff_hunk":"@@ -126,6 +126,19 @@ describe('Quotes', function () {\n         .end()\n     })\n \n+    it('should return a 422 if destination_ledger rounded amount is less than or equal to 0', function * () {\n+      yield this.request()\n+        .get('/quote?source_amount=0.00001' +\n+          '&source_ledger=http://eur-ledger.example/EUR' +\n+          '&destination_ledger=http://usd-ledger.example/USD')\n+        .expect(422)\n+        .expect(function (res) {\n+          expect(res.body.id).to.equal('UnacceptableAmountError')\n+          expect(res.body.message).to.equal('Quoted destination amount exceeds minimum amount allowed')","path":"test/quoteSpec.js","position":12,"original_position":12,"commit_id":"40bc7cbc747b72aaf29594b4dedd69611c26e2bc","original_commit_id":"40bc7cbc747b72aaf29594b4dedd69611c26e2bc","user":{"login":"lumberj","id":1812196,"avatar_url":"https://avatars.githubusercontent.com/u/1812196?v=3","gravatar_id":"","url":"https://api.github.com/users/lumberj","html_url":"https://github.com/lumberj","followers_url":"https://api.github.com/users/lumberj/followers","following_url":"https://api.github.com/users/lumberj/following{/other_user}","gists_url":"https://api.github.com/users/lumberj/gists{/gist_id}","starred_url":"https://api.github.com/users/lumberj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lumberj/subscriptions","organizations_url":"https://api.github.com/users/lumberj/orgs","repos_url":"https://api.github.com/users/lumberj/repos","events_url":"https://api.github.com/users/lumberj/events{/privacy}","received_events_url":"https://api.github.com/users/lumberj/received_events","type":"User","site_admin":false},"body":"Or \"to go beyond a permitted limit\". Do you have a suggestion for a\ndifferent word to use?\nOn Mon, Mar 28, 2016 at 5:44 PM Evan Schwartz <notifications@github.com>\nwrote:\n\n> In test/quoteSpec.js\n> <https://github.com/interledger/five-bells-connector/pull/127#discussion_r57658070>\n> :\n>\n> > @@ -126,6 +126,19 @@ describe('Quotes', function () {\n> >          .end()\n> >      })\n> >\n> > +    it('should return a 422 if destination_ledger rounded amount is less than or equal to 0', function * () {\n> > +      yield this.request()\n> > +        .get('/quote?source_amount=0.00001' +\n> > +          '&source_ledger=http://eur-ledger.example/EUR' +\n> > +          '&destination_ledger=http://usd-ledger.example/USD')\n> > +        .expect(422)\n> > +        .expect(function (res) {\n> > +          expect(res.body.id).to.equal('UnacceptableAmountError')\n> > +          expect(res.body.message).to.equal('Quoted destination amount exceeds minimum amount allowed')\n>\n> \"Exceeds\" means \"is greater than\"\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly or view it on GitHub\n> <https://github.com/interledger/five-bells-connector/pull/127/files/02cedba5dacbe99e26bc7460d23232bfe8444d25..40bc7cbc747b72aaf29594b4dedd69611c26e2bc#r57658070>\n>\n","created_at":"2016-03-29T01:26:48Z","updated_at":"2016-03-29T01:26:48Z","html_url":"https://github.com/interledger/five-bells-connector/pull/127#discussion_r57661192","pull_request_url":"https://api.github.com/repos/interledger/five-bells-connector/pulls/127","_links":{"self":{"href":"https://api.github.com/repos/interledger/five-bells-connector/pulls/comments/57661192"},"html":{"href":"https://github.com/interledger/five-bells-connector/pull/127#discussion_r57661192"},"pull_request":{"href":"https://api.github.com/repos/interledger/five-bells-connector/pulls/127"}}},"pull_request":{"url":"https://api.github.com/repos/interledger/five-bells-connector/pulls/127","id":64387245,"html_url":"https://github.com/interledger/five-bells-connector/pull/127","diff_url":"https://github.com/interledger/five-bells-connector/pull/127.diff","patch_url":"https://github.com/interledger/five-bells-connector/pull/127.patch","issue_url":"https://api.github.com/repos/interledger/five-bells-connector/issues/127","number":127,"state":"open","locked":false,"title":"BREAKING | FEATURE: Get precision from ledger","user":{"login":"lumberj","id":1812196,"avatar_url":"https://avatars.githubusercontent.com/u/1812196?v=3","gravatar_id":"","url":"https://api.github.com/users/lumberj","html_url":"https://github.com/lumberj","followers_url":"https://api.github.com/users/lumberj/followers","following_url":"https://api.github.com/users/lumberj/following{/other_user}","gists_url":"https://api.github.com/users/lumberj/gists{/gist_id}","starred_url":"https://api.github.com/users/lumberj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lumberj/subscriptions","organizations_url":"https://api.github.com/users/lumberj/orgs","repos_url":"https://api.github.com/users/lumberj/repos","events_url":"https://api.github.com/users/lumberj/events{/privacy}","received_events_url":"https://api.github.com/users/lumberj/received_events","type":"User","site_admin":false},"body":"Requires the ledger to support returning its precision\r\nhttps://github.com/interledger/five-bells-ledger/commit/87f8622e25ae2b0d3ea9c39d7284c00aaa5b4e83\r\n\r\nTODO:\r\n- Caching ledger precision","created_at":"2016-03-28T22:36:54Z","updated_at":"2016-03-29T01:26:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76daa2e6000ad0ec5e62fd1d04c2eb857327abaf","assignee":{"login":"gip","id":575540,"avatar_url":"https://avatars.githubusercontent.com/u/575540?v=3","gravatar_id":"","url":"https://api.github.com/users/gip","html_url":"https://github.com/gip","followers_url":"https://api.github.com/users/gip/followers","following_url":"https://api.github.com/users/gip/following{/other_user}","gists_url":"https://api.github.com/users/gip/gists{/gist_id}","starred_url":"https://api.github.com/users/gip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gip/subscriptions","organizations_url":"https://api.github.com/users/gip/orgs","repos_url":"https://api.github.com/users/gip/repos","events_url":"https://api.github.com/users/gip/events{/privacy}","received_events_url":"https://api.github.com/users/gip/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/interledger/five-bells-connector/pulls/127/commits","review_comments_url":"https://api.github.com/repos/interledger/five-bells-connector/pulls/127/comments","review_comment_url":"https://api.github.com/repos/interledger/five-bells-connector/pulls/comments{/number}","comments_url":"https://api.github.com/repos/interledger/five-bells-connector/issues/127/comments","statuses_url":"https://api.github.com/repos/interledger/five-bells-connector/statuses/40bc7cbc747b72aaf29594b4dedd69611c26e2bc","head":{"label":"lumberj:feature/get-precision","ref":"feature/get-precision","sha":"40bc7cbc747b72aaf29594b4dedd69611c26e2bc","user":{"login":"lumberj","id":1812196,"avatar_url":"https://avatars.githubusercontent.com/u/1812196?v=3","gravatar_id":"","url":"https://api.github.com/users/lumberj","html_url":"https://github.com/lumberj","followers_url":"https://api.github.com/users/lumberj/followers","following_url":"https://api.github.com/users/lumberj/following{/other_user}","gists_url":"https://api.github.com/users/lumberj/gists{/gist_id}","starred_url":"https://api.github.com/users/lumberj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lumberj/subscriptions","organizations_url":"https://api.github.com/users/lumberj/orgs","repos_url":"https://api.github.com/users/lumberj/repos","events_url":"https://api.github.com/users/lumberj/events{/privacy}","received_events_url":"https://api.github.com/users/lumberj/received_events","type":"User","site_admin":false},"repo":{"id":49222576,"name":"five-bells-connector","full_name":"lumberj/five-bells-connector","owner":{"login":"lumberj","id":1812196,"avatar_url":"https://avatars.githubusercontent.com/u/1812196?v=3","gravatar_id":"","url":"https://api.github.com/users/lumberj","html_url":"https://github.com/lumberj","followers_url":"https://api.github.com/users/lumberj/followers","following_url":"https://api.github.com/users/lumberj/following{/other_user}","gists_url":"https://api.github.com/users/lumberj/gists{/gist_id}","starred_url":"https://api.github.com/users/lumberj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lumberj/subscriptions","organizations_url":"https://api.github.com/users/lumberj/orgs","repos_url":"https://api.github.com/users/lumberj/repos","events_url":"https://api.github.com/users/lumberj/events{/privacy}","received_events_url":"https://api.github.com/users/lumberj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lumberj/five-bells-connector","description":"An implementation of an Interledger connector.","fork":true,"url":"https://api.github.com/repos/lumberj/five-bells-connector","forks_url":"https://api.github.com/repos/lumberj/five-bells-connector/forks","keys_url":"https://api.github.com/repos/lumberj/five-bells-connector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lumberj/five-bells-connector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lumberj/five-bells-connector/teams","hooks_url":"https://api.github.com/repos/lumberj/five-bells-connector/hooks","issue_events_url":"https://api.github.com/repos/lumberj/five-bells-connector/issues/events{/number}","events_url":"https://api.github.com/repos/lumberj/five-bells-connector/events","assignees_url":"https://api.github.com/repos/lumberj/five-bells-connector/assignees{/user}","branches_url":"https://api.github.com/repos/lumberj/five-bells-connector/branches{/branch}","tags_url":"https://api.github.com/repos/lumberj/five-bells-connector/tags","blobs_url":"https://api.github.com/repos/lumberj/five-bells-connector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lumberj/five-bells-connector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lumberj/five-bells-connector/git/refs{/sha}","trees_url":"https://api.github.com/repos/lumberj/five-bells-connector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lumberj/five-bells-connector/statuses/{sha}","languages_url":"https://api.github.com/repos/lumberj/five-bells-connector/languages","stargazers_url":"https://api.github.com/repos/lumberj/five-bells-connector/stargazers","contributors_url":"https://api.github.com/repos/lumberj/five-bells-connector/contributors","subscribers_url":"https://api.github.com/repos/lumberj/five-bells-connector/subscribers","subscription_url":"https://api.github.com/repos/lumberj/five-bells-connector/subscription","commits_url":"https://api.github.com/repos/lumberj/five-bells-connector/commits{/sha}","git_commits_url":"https://api.github.com/repos/lumberj/five-bells-connector/git/commits{/sha}","comments_url":"https://api.github.com/repos/lumberj/five-bells-connector/comments{/number}","issue_comment_url":"https://api.github.com/repos/lumberj/five-bells-connector/issues/comments{/number}","contents_url":"https://api.github.com/repos/lumberj/five-bells-connector/contents/{+path}","compare_url":"https://api.github.com/repos/lumberj/five-bells-connector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lumberj/five-bells-connector/merges","archive_url":"https://api.github.com/repos/lumberj/five-bells-connector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lumberj/five-bells-connector/downloads","issues_url":"https://api.github.com/repos/lumberj/five-bells-connector/issues{/number}","pulls_url":"https://api.github.com/repos/lumberj/five-bells-connector/pulls{/number}","milestones_url":"https://api.github.com/repos/lumberj/five-bells-connector/milestones{/number}","notifications_url":"https://api.github.com/repos/lumberj/five-bells-connector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lumberj/five-bells-connector/labels{/name}","releases_url":"https://api.github.com/repos/lumberj/five-bells-connector/releases{/id}","deployments_url":"https://api.github.com/repos/lumberj/five-bells-connector/deployments","created_at":"2016-01-07T18:30:36Z","updated_at":"2016-01-22T17:36:45Z","pushed_at":"2016-03-28T23:56:24Z","git_url":"git://github.com/lumberj/five-bells-connector.git","ssh_url":"git@github.com:lumberj/five-bells-connector.git","clone_url":"https://github.com/lumberj/five-bells-connector.git","svn_url":"https://github.com/lumberj/five-bells-connector","homepage":"","size":488,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"interledger:master","ref":"master","sha":"e4d7a5aa67c6c57516f1bff1f46453da098aaecc","user":{"login":"interledger","id":14062960,"avatar_url":"https://avatars.githubusercontent.com/u/14062960?v=3","gravatar_id":"","url":"https://api.github.com/users/interledger","html_url":"https://github.com/interledger","followers_url":"https://api.github.com/users/interledger/followers","following_url":"https://api.github.com/users/interledger/following{/other_user}","gists_url":"https://api.github.com/users/interledger/gists{/gist_id}","starred_url":"https://api.github.com/users/interledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interledger/subscriptions","organizations_url":"https://api.github.com/users/interledger/orgs","repos_url":"https://api.github.com/users/interledger/repos","events_url":"https://api.github.com/users/interledger/events{/privacy}","received_events_url":"https://api.github.com/users/interledger/received_events","type":"Organization","site_admin":false},"repo":{"id":30608872,"name":"five-bells-connector","full_name":"interledger/five-bells-connector","owner":{"login":"interledger","id":14062960,"avatar_url":"https://avatars.githubusercontent.com/u/14062960?v=3","gravatar_id":"","url":"https://api.github.com/users/interledger","html_url":"https://github.com/interledger","followers_url":"https://api.github.com/users/interledger/followers","following_url":"https://api.github.com/users/interledger/following{/other_user}","gists_url":"https://api.github.com/users/interledger/gists{/gist_id}","starred_url":"https://api.github.com/users/interledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interledger/subscriptions","organizations_url":"https://api.github.com/users/interledger/orgs","repos_url":"https://api.github.com/users/interledger/repos","events_url":"https://api.github.com/users/interledger/events{/privacy}","received_events_url":"https://api.github.com/users/interledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/interledger/five-bells-connector","description":"An implementation of an Interledger connector.","fork":false,"url":"https://api.github.com/repos/interledger/five-bells-connector","forks_url":"https://api.github.com/repos/interledger/five-bells-connector/forks","keys_url":"https://api.github.com/repos/interledger/five-bells-connector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/interledger/five-bells-connector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/interledger/five-bells-connector/teams","hooks_url":"https://api.github.com/repos/interledger/five-bells-connector/hooks","issue_events_url":"https://api.github.com/repos/interledger/five-bells-connector/issues/events{/number}","events_url":"https://api.github.com/repos/interledger/five-bells-connector/events","assignees_url":"https://api.github.com/repos/interledger/five-bells-connector/assignees{/user}","branches_url":"https://api.github.com/repos/interledger/five-bells-connector/branches{/branch}","tags_url":"https://api.github.com/repos/interledger/five-bells-connector/tags","blobs_url":"https://api.github.com/repos/interledger/five-bells-connector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/interledger/five-bells-connector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/interledger/five-bells-connector/git/refs{/sha}","trees_url":"https://api.github.com/repos/interledger/five-bells-connector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/interledger/five-bells-connector/statuses/{sha}","languages_url":"https://api.github.com/repos/interledger/five-bells-connector/languages","stargazers_url":"https://api.github.com/repos/interledger/five-bells-connector/stargazers","contributors_url":"https://api.github.com/repos/interledger/five-bells-connector/contributors","subscribers_url":"https://api.github.com/repos/interledger/five-bells-connector/subscribers","subscription_url":"https://api.github.com/repos/interledger/five-bells-connector/subscription","commits_url":"https://api.github.com/repos/interledger/five-bells-connector/commits{/sha}","git_commits_url":"https://api.github.com/repos/interledger/five-bells-connector/git/commits{/sha}","comments_url":"https://api.github.com/repos/interledger/five-bells-connector/comments{/number}","issue_comment_url":"https://api.github.com/repos/interledger/five-bells-connector/issues/comments{/number}","contents_url":"https://api.github.com/repos/interledger/five-bells-connector/contents/{+path}","compare_url":"https://api.github.com/repos/interledger/five-bells-connector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/interledger/five-bells-connector/merges","archive_url":"https://api.github.com/repos/interledger/five-bells-connector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/interledger/five-bells-connector/downloads","issues_url":"https://api.github.com/repos/interledger/five-bells-connector/issues{/number}","pulls_url":"https://api.github.com/repos/interledger/five-bells-connector/pulls{/number}","milestones_url":"https://api.github.com/repos/interledger/five-bells-connector/milestones{/number}","notifications_url":"https://api.github.com/repos/interledger/five-bells-connector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/interledger/five-bells-connector/labels{/name}","releases_url":"https://api.github.com/repos/interledger/five-bells-connector/releases{/id}","deployments_url":"https://api.github.com/repos/interledger/five-bells-connector/deployments","created_at":"2015-02-10T19:01:26Z","updated_at":"2016-01-25T22:20:22Z","pushed_at":"2016-03-29T00:05:25Z","git_url":"git://github.com/interledger/five-bells-connector.git","ssh_url":"git@github.com:interledger/five-bells-connector.git","clone_url":"https://github.com/interledger/five-bells-connector.git","svn_url":"https://github.com/interledger/five-bells-connector","homepage":"","size":547,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":8,"forks":5,"open_issues":8,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/interledger/five-bells-connector/pulls/127"},"html":{"href":"https://github.com/interledger/five-bells-connector/pull/127"},"issue":{"href":"https://api.github.com/repos/interledger/five-bells-connector/issues/127"},"comments":{"href":"https://api.github.com/repos/interledger/five-bells-connector/issues/127/comments"},"review_comments":{"href":"https://api.github.com/repos/interledger/five-bells-connector/pulls/127/comments"},"review_comment":{"href":"https://api.github.com/repos/interledger/five-bells-connector/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/interledger/five-bells-connector/pulls/127/commits"},"statuses":{"href":"https://api.github.com/repos/interledger/five-bells-connector/statuses/40bc7cbc747b72aaf29594b4dedd69611c26e2bc"}}}}