{"action":"created","issue":{"url":"https://api.github.com/repos/acdlite/redux-actions/issues/97","repository_url":"https://api.github.com/repos/acdlite/redux-actions","labels_url":"https://api.github.com/repos/acdlite/redux-actions/issues/97/labels{/name}","comments_url":"https://api.github.com/repos/acdlite/redux-actions/issues/97/comments","events_url":"https://api.github.com/repos/acdlite/redux-actions/issues/97/events","html_url":"https://github.com/acdlite/redux-actions/pull/97","id":162794187,"number":97,"title":"Simplified implementation of handleAction","user":{"login":"Lucretiel","id":1823405,"avatar_url":"https://avatars.githubusercontent.com/u/1823405?v=3","gravatar_id":"","url":"https://api.github.com/users/Lucretiel","html_url":"https://github.com/Lucretiel","followers_url":"https://api.github.com/users/Lucretiel/followers","following_url":"https://api.github.com/users/Lucretiel/following{/other_user}","gists_url":"https://api.github.com/users/Lucretiel/gists{/gist_id}","starred_url":"https://api.github.com/users/Lucretiel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lucretiel/subscriptions","organizations_url":"https://api.github.com/users/Lucretiel/orgs","repos_url":"https://api.github.com/users/Lucretiel/repos","events_url":"https://api.github.com/users/Lucretiel/events{/privacy}","received_events_url":"https://api.github.com/users/Lucretiel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-06-28T21:40:27Z","updated_at":"2016-06-30T22:13:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/acdlite/redux-actions/pulls/97","html_url":"https://github.com/acdlite/redux-actions/pull/97","diff_url":"https://github.com/acdlite/redux-actions/pull/97.diff","patch_url":"https://github.com/acdlite/redux-actions/pull/97.patch"},"body":"- Moved the function-or-object check on the `reducers` parameter to outside the closure function\r\n- Removed the use of magic strings\r\n- Removed the mutation of the passed-in `reducers` argument"},"comment":{"url":"https://api.github.com/repos/acdlite/redux-actions/issues/comments/229803961","html_url":"https://github.com/acdlite/redux-actions/pull/97#issuecomment-229803961","issue_url":"https://api.github.com/repos/acdlite/redux-actions/issues/97","id":229803961,"user":{"login":"Lucretiel","id":1823405,"avatar_url":"https://avatars.githubusercontent.com/u/1823405?v=3","gravatar_id":"","url":"https://api.github.com/users/Lucretiel","html_url":"https://github.com/Lucretiel","followers_url":"https://api.github.com/users/Lucretiel/followers","following_url":"https://api.github.com/users/Lucretiel/following{/other_user}","gists_url":"https://api.github.com/users/Lucretiel/gists{/gist_id}","starred_url":"https://api.github.com/users/Lucretiel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lucretiel/subscriptions","organizations_url":"https://api.github.com/users/Lucretiel/orgs","repos_url":"https://api.github.com/users/Lucretiel/repos","events_url":"https://api.github.com/users/Lucretiel/events{/privacy}","received_events_url":"https://api.github.com/users/Lucretiel/received_events","type":"User","site_admin":false},"created_at":"2016-06-30T22:13:19Z","updated_at":"2016-06-30T22:13:19Z","body":"Oh, dear. It actually appears that, based on the tests (thought not the written documentation), the defined behavior is in fact to do nothing if no function is attached to either the `next` or `throw` keys:\r\n\r\nhttps://github.com/acdlite/redux-actions/blob/master/src/__tests__/handleAction-test.js#L87-L92\r\n\r\nThere is no similar test in place for passing a null as the reducer argument itself. This, in fact, was changed from the prior behavior, which DID raise an exception if a function wasn't passed in: https://github.com/Lucretiel/redux-actions/commit/e6591594ba275c001c19390bf4d575adba6455f1#diff-13523acaa823765ceef717519f2dcc3dL75\r\n\r\nIt's not clear to me if this change was made as an explicit API change, or if it was just changed with some subtle javascript thing. Pinging @acdlite for his input, as he wrote the change.\r\n\r\nIt's one thing for it to be a subtle side effect; it's another thing entirely if there's an explicitly described test describing the behavior. At the time, the addition of this (and possibly other) changes were seen as only needing a [minor version bump](https://github.com/Lucretiel/redux-actions/commit/e6591594ba275c001c19390bf4d575adba6455f1). Semver itself leads it up to our interpretation what counts as the \"documented public API.\" It's still my preference that this behavior be changed to raise as error, especially because that error would be raised from `handleAction` and not from the returned action creator. It's also my preference that, because the written documentation in the README does say either way, we consider this only a patch change, or perhaps a new minor feature because of the added type checking. But I'll defer to the wisdom of the rest of you on that."}}
{"actor":{"display_login":"Lucretiel"}}