{"action":"created","issue":{"url":"https://api.github.com/repos/Azure/azure-iot-sdks/issues/485","repository_url":"https://api.github.com/repos/Azure/azure-iot-sdks","labels_url":"https://api.github.com/repos/Azure/azure-iot-sdks/issues/485/labels{/name}","comments_url":"https://api.github.com/repos/Azure/azure-iot-sdks/issues/485/comments","events_url":"https://api.github.com/repos/Azure/azure-iot-sdks/issues/485/events","html_url":"https://github.com/Azure/azure-iot-sdks/pull/485","id":148326766,"number":485,"title":"AmqpWs support for node.js service client","user":{"login":"wmmihaa","id":3214367,"avatar_url":"https://avatars.githubusercontent.com/u/3214367?v=3","gravatar_id":"","url":"https://api.github.com/users/wmmihaa","html_url":"https://github.com/wmmihaa","followers_url":"https://api.github.com/users/wmmihaa/followers","following_url":"https://api.github.com/users/wmmihaa/following{/other_user}","gists_url":"https://api.github.com/users/wmmihaa/gists{/gist_id}","starred_url":"https://api.github.com/users/wmmihaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmmihaa/subscriptions","organizations_url":"https://api.github.com/users/wmmihaa/orgs","repos_url":"https://api.github.com/users/wmmihaa/repos","events_url":"https://api.github.com/users/wmmihaa/events{/privacy}","received_events_url":"https://api.github.com/users/wmmihaa/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Azure/azure-iot-sdks/labels/cla-signed","name":"cla-signed","color":"207de5"}],"state":"open","locked":false,"assignee":{"login":"pierreca","id":4979572,"avatar_url":"https://avatars.githubusercontent.com/u/4979572?v=3","gravatar_id":"","url":"https://api.github.com/users/pierreca","html_url":"https://github.com/pierreca","followers_url":"https://api.github.com/users/pierreca/followers","following_url":"https://api.github.com/users/pierreca/following{/other_user}","gists_url":"https://api.github.com/users/pierreca/gists{/gist_id}","starred_url":"https://api.github.com/users/pierreca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierreca/subscriptions","organizations_url":"https://api.github.com/users/pierreca/orgs","repos_url":"https://api.github.com/users/pierreca/repos","events_url":"https://api.github.com/users/pierreca/events{/privacy}","received_events_url":"https://api.github.com/users/pierreca/received_events","type":"User","site_admin":false},"milestone":null,"comments":4,"created_at":"2016-04-14T11:09:16Z","updated_at":"2016-04-15T06:29:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Azure/azure-iot-sdks/pulls/485","html_url":"https://github.com/Azure/azure-iot-sdks/pull/485","diff_url":"https://github.com/Azure/azure-iot-sdks/pull/485.diff","patch_url":"https://github.com/Azure/azure-iot-sdks/pull/485.patch"},"body":"Added support for AmqpWs to the node.js service client after suggestion from @pierreca. \r\n\r\n**Added**: node/service/lib/amqp-ws.js\r\n_amqp-ws transport class that inherits from the amqp class_\r\n\r\n**Updated**: node/service/iothub.js\r\n_Added exports for Amqp and AmqpWs_\r\n\r\n**Updated**: node/service/lib/client.js\r\n_Updated the fromConnectionString and fromSharedAccessSignature operations as:_\r\n\r\n- Changed the 'value' parameter name to connStr and sharedAccessSignature\r\n- Added Transport parameter\r\n- Added setting Transport to DefaultTransport if not set\r\n- Updated comments\r\n\r\n**Left to do**\r\n_No unit tests has been added or updated_"},"comment":{"url":"https://api.github.com/repos/Azure/azure-iot-sdks/issues/comments/210304545","html_url":"https://github.com/Azure/azure-iot-sdks/pull/485#issuecomment-210304545","issue_url":"https://api.github.com/repos/Azure/azure-iot-sdks/issues/485","id":210304545,"user":{"login":"wmmihaa","id":3214367,"avatar_url":"https://avatars.githubusercontent.com/u/3214367?v=3","gravatar_id":"","url":"https://api.github.com/users/wmmihaa","html_url":"https://github.com/wmmihaa","followers_url":"https://api.github.com/users/wmmihaa/followers","following_url":"https://api.github.com/users/wmmihaa/following{/other_user}","gists_url":"https://api.github.com/users/wmmihaa/gists{/gist_id}","starred_url":"https://api.github.com/users/wmmihaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmmihaa/subscriptions","organizations_url":"https://api.github.com/users/wmmihaa/orgs","repos_url":"https://api.github.com/users/wmmihaa/repos","events_url":"https://api.github.com/users/wmmihaa/events{/privacy}","received_events_url":"https://api.github.com/users/wmmihaa/received_events","type":"User","site_admin":false},"created_at":"2016-04-15T06:29:37Z","updated_at":"2016-04-15T06:29:37Z","body":"My bad ;) \n\nDate: Thu, 14 Apr 2016 16:28:12 -0700\nFrom: notifications@github.com\nTo: azure-iot-sdks@noreply.github.com\nCC: wmmihaa@hotmail.com\nSubject: Re: [Azure/azure-iot-sdks] AmqpWs support for node.js service client (#485)\n\nThanks for the PR @wmmihaa! \n\nI did a first quick pass on the code and it looks good to me, I'll need to spend a little more time on it to run tests on AMQP/AMQP-WS to verify that nothing's been broken.\n\n\nThe one thing I need to ask (per our contribution guidelines)is that you resubmit the PR against the develop branch, that's where we run our gated builds.\n\n\nThanks again, this is awesome :) \n\n\n—\nYou are receiving this because you were mentioned.\nReply to this email directly or view it on GitHub\n\n\n  \n  \n\n\n \t\t \t   \t\t  "}}