{"action":"created","comment":{"url":"https://api.github.com/repos/OSGP/Shared/pulls/comments/53310849","id":53310849,"diff_hunk":"@@ -11,7 +11,8 @@\n \n /**\n  * response to {@link ScalerUnitQuery scaler and unit query} for E or GAS\n- * meters.\n+ * meters. Note that this is the scaler and unit as used on the device, not the","path":"osgp-dto/src/main/java/com/alliander/osgp/dto/valueobjects/smartmetering/ScalerUnit.java","position":5,"original_position":5,"commit_id":"0d3800f5b5694b8336adfafed6e9dad838eb4236","original_commit_id":"0d3800f5b5694b8336adfafed6e9dad838eb4236","user":{"login":"rudidevries","id":5311277,"avatar_url":"https://avatars.githubusercontent.com/u/5311277?v=3","gravatar_id":"","url":"https://api.github.com/users/rudidevries","html_url":"https://github.com/rudidevries","followers_url":"https://api.github.com/users/rudidevries/followers","following_url":"https://api.github.com/users/rudidevries/following{/other_user}","gists_url":"https://api.github.com/users/rudidevries/gists{/gist_id}","starred_url":"https://api.github.com/users/rudidevries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rudidevries/subscriptions","organizations_url":"https://api.github.com/users/rudidevries/orgs","repos_url":"https://api.github.com/users/rudidevries/repos","events_url":"https://api.github.com/users/rudidevries/events{/privacy}","received_events_url":"https://api.github.com/users/rudidevries/received_events","type":"User","site_admin":false},"body":"Is would think that is a matter of with which values you instantiate this class, isn't it?","created_at":"2016-02-18T13:09:25Z","updated_at":"2016-02-18T13:09:25Z","html_url":"https://github.com/OSGP/Shared/pull/60#discussion_r53310849","pull_request_url":"https://api.github.com/repos/OSGP/Shared/pulls/60","_links":{"self":{"href":"https://api.github.com/repos/OSGP/Shared/pulls/comments/53310849"},"html":{"href":"https://github.com/OSGP/Shared/pull/60#discussion_r53310849"},"pull_request":{"href":"https://api.github.com/repos/OSGP/Shared/pulls/60"}}},"pull_request":{"url":"https://api.github.com/repos/OSGP/Shared/pulls/60","id":59662203,"html_url":"https://github.com/OSGP/Shared/pull/60","diff_url":"https://github.com/OSGP/Shared/pull/60.diff","patch_url":"https://github.com/OSGP/Shared/pull/60.patch","issue_url":"https://api.github.com/repos/OSGP/Shared/issues/60","number":60,"state":"open","locked":false,"title":"SLIM-247 Feat convert reads to uniform unit","user":{"login":"eduarddrenth","id":10200360,"avatar_url":"https://avatars.githubusercontent.com/u/10200360?v=3","gravatar_id":"","url":"https://api.github.com/users/eduarddrenth","html_url":"https://github.com/eduarddrenth","followers_url":"https://api.github.com/users/eduarddrenth/followers","following_url":"https://api.github.com/users/eduarddrenth/following{/other_user}","gists_url":"https://api.github.com/users/eduarddrenth/gists{/gist_id}","starred_url":"https://api.github.com/users/eduarddrenth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eduarddrenth/subscriptions","organizations_url":"https://api.github.com/users/eduarddrenth/orgs","repos_url":"https://api.github.com/users/eduarddrenth/repos","events_url":"https://api.github.com/users/eduarddrenth/events{/privacy}","received_events_url":"https://api.github.com/users/eduarddrenth/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-02-17T15:42:56Z","updated_at":"2016-02-18T13:09:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d28612d7c25298bbe19a0a2ae771410c5f81b4f0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OSGP/Shared/pulls/60/commits","review_comments_url":"https://api.github.com/repos/OSGP/Shared/pulls/60/comments","review_comment_url":"https://api.github.com/repos/OSGP/Shared/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OSGP/Shared/issues/60/comments","statuses_url":"https://api.github.com/repos/OSGP/Shared/statuses/0d3800f5b5694b8336adfafed6e9dad838eb4236","head":{"label":"OSGP:feat_convert_reads_to_uniform_unit","ref":"feat_convert_reads_to_uniform_unit","sha":"0d3800f5b5694b8336adfafed6e9dad838eb4236","user":{"login":"OSGP","id":11352045,"avatar_url":"https://avatars.githubusercontent.com/u/11352045?v=3","gravatar_id":"","url":"https://api.github.com/users/OSGP","html_url":"https://github.com/OSGP","followers_url":"https://api.github.com/users/OSGP/followers","following_url":"https://api.github.com/users/OSGP/following{/other_user}","gists_url":"https://api.github.com/users/OSGP/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGP/subscriptions","organizations_url":"https://api.github.com/users/OSGP/orgs","repos_url":"https://api.github.com/users/OSGP/repos","events_url":"https://api.github.com/users/OSGP/events{/privacy}","received_events_url":"https://api.github.com/users/OSGP/received_events","type":"Organization","site_admin":false},"repo":{"id":32739219,"name":"Shared","full_name":"OSGP/Shared","owner":{"login":"OSGP","id":11352045,"avatar_url":"https://avatars.githubusercontent.com/u/11352045?v=3","gravatar_id":"","url":"https://api.github.com/users/OSGP","html_url":"https://github.com/OSGP","followers_url":"https://api.github.com/users/OSGP/followers","following_url":"https://api.github.com/users/OSGP/following{/other_user}","gists_url":"https://api.github.com/users/OSGP/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGP/subscriptions","organizations_url":"https://api.github.com/users/OSGP/orgs","repos_url":"https://api.github.com/users/OSGP/repos","events_url":"https://api.github.com/users/OSGP/events{/privacy}","received_events_url":"https://api.github.com/users/OSGP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OSGP/Shared","description":"Shared libraries.","fork":false,"url":"https://api.github.com/repos/OSGP/Shared","forks_url":"https://api.github.com/repos/OSGP/Shared/forks","keys_url":"https://api.github.com/repos/OSGP/Shared/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OSGP/Shared/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OSGP/Shared/teams","hooks_url":"https://api.github.com/repos/OSGP/Shared/hooks","issue_events_url":"https://api.github.com/repos/OSGP/Shared/issues/events{/number}","events_url":"https://api.github.com/repos/OSGP/Shared/events","assignees_url":"https://api.github.com/repos/OSGP/Shared/assignees{/user}","branches_url":"https://api.github.com/repos/OSGP/Shared/branches{/branch}","tags_url":"https://api.github.com/repos/OSGP/Shared/tags","blobs_url":"https://api.github.com/repos/OSGP/Shared/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OSGP/Shared/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OSGP/Shared/git/refs{/sha}","trees_url":"https://api.github.com/repos/OSGP/Shared/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OSGP/Shared/statuses/{sha}","languages_url":"https://api.github.com/repos/OSGP/Shared/languages","stargazers_url":"https://api.github.com/repos/OSGP/Shared/stargazers","contributors_url":"https://api.github.com/repos/OSGP/Shared/contributors","subscribers_url":"https://api.github.com/repos/OSGP/Shared/subscribers","subscription_url":"https://api.github.com/repos/OSGP/Shared/subscription","commits_url":"https://api.github.com/repos/OSGP/Shared/commits{/sha}","git_commits_url":"https://api.github.com/repos/OSGP/Shared/git/commits{/sha}","comments_url":"https://api.github.com/repos/OSGP/Shared/comments{/number}","issue_comment_url":"https://api.github.com/repos/OSGP/Shared/issues/comments{/number}","contents_url":"https://api.github.com/repos/OSGP/Shared/contents/{+path}","compare_url":"https://api.github.com/repos/OSGP/Shared/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OSGP/Shared/merges","archive_url":"https://api.github.com/repos/OSGP/Shared/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OSGP/Shared/downloads","issues_url":"https://api.github.com/repos/OSGP/Shared/issues{/number}","pulls_url":"https://api.github.com/repos/OSGP/Shared/pulls{/number}","milestones_url":"https://api.github.com/repos/OSGP/Shared/milestones{/number}","notifications_url":"https://api.github.com/repos/OSGP/Shared/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OSGP/Shared/labels{/name}","releases_url":"https://api.github.com/repos/OSGP/Shared/releases{/id}","deployments_url":"https://api.github.com/repos/OSGP/Shared/deployments","created_at":"2015-03-23T15:02:43Z","updated_at":"2016-01-21T15:07:04Z","pushed_at":"2016-02-18T11:13:22Z","git_url":"git://github.com/OSGP/Shared.git","ssh_url":"git@github.com:OSGP/Shared.git","clone_url":"https://github.com/OSGP/Shared.git","svn_url":"https://github.com/OSGP/Shared","homepage":null,"size":454,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":1,"default_branch":"development"}},"base":{"label":"OSGP:development","ref":"development","sha":"d5f32ae5ed1699cfc77f7615992b91c5db059acd","user":{"login":"OSGP","id":11352045,"avatar_url":"https://avatars.githubusercontent.com/u/11352045?v=3","gravatar_id":"","url":"https://api.github.com/users/OSGP","html_url":"https://github.com/OSGP","followers_url":"https://api.github.com/users/OSGP/followers","following_url":"https://api.github.com/users/OSGP/following{/other_user}","gists_url":"https://api.github.com/users/OSGP/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGP/subscriptions","organizations_url":"https://api.github.com/users/OSGP/orgs","repos_url":"https://api.github.com/users/OSGP/repos","events_url":"https://api.github.com/users/OSGP/events{/privacy}","received_events_url":"https://api.github.com/users/OSGP/received_events","type":"Organization","site_admin":false},"repo":{"id":32739219,"name":"Shared","full_name":"OSGP/Shared","owner":{"login":"OSGP","id":11352045,"avatar_url":"https://avatars.githubusercontent.com/u/11352045?v=3","gravatar_id":"","url":"https://api.github.com/users/OSGP","html_url":"https://github.com/OSGP","followers_url":"https://api.github.com/users/OSGP/followers","following_url":"https://api.github.com/users/OSGP/following{/other_user}","gists_url":"https://api.github.com/users/OSGP/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGP/subscriptions","organizations_url":"https://api.github.com/users/OSGP/orgs","repos_url":"https://api.github.com/users/OSGP/repos","events_url":"https://api.github.com/users/OSGP/events{/privacy}","received_events_url":"https://api.github.com/users/OSGP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OSGP/Shared","description":"Shared libraries.","fork":false,"url":"https://api.github.com/repos/OSGP/Shared","forks_url":"https://api.github.com/repos/OSGP/Shared/forks","keys_url":"https://api.github.com/repos/OSGP/Shared/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OSGP/Shared/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OSGP/Shared/teams","hooks_url":"https://api.github.com/repos/OSGP/Shared/hooks","issue_events_url":"https://api.github.com/repos/OSGP/Shared/issues/events{/number}","events_url":"https://api.github.com/repos/OSGP/Shared/events","assignees_url":"https://api.github.com/repos/OSGP/Shared/assignees{/user}","branches_url":"https://api.github.com/repos/OSGP/Shared/branches{/branch}","tags_url":"https://api.github.com/repos/OSGP/Shared/tags","blobs_url":"https://api.github.com/repos/OSGP/Shared/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OSGP/Shared/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OSGP/Shared/git/refs{/sha}","trees_url":"https://api.github.com/repos/OSGP/Shared/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OSGP/Shared/statuses/{sha}","languages_url":"https://api.github.com/repos/OSGP/Shared/languages","stargazers_url":"https://api.github.com/repos/OSGP/Shared/stargazers","contributors_url":"https://api.github.com/repos/OSGP/Shared/contributors","subscribers_url":"https://api.github.com/repos/OSGP/Shared/subscribers","subscription_url":"https://api.github.com/repos/OSGP/Shared/subscription","commits_url":"https://api.github.com/repos/OSGP/Shared/commits{/sha}","git_commits_url":"https://api.github.com/repos/OSGP/Shared/git/commits{/sha}","comments_url":"https://api.github.com/repos/OSGP/Shared/comments{/number}","issue_comment_url":"https://api.github.com/repos/OSGP/Shared/issues/comments{/number}","contents_url":"https://api.github.com/repos/OSGP/Shared/contents/{+path}","compare_url":"https://api.github.com/repos/OSGP/Shared/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OSGP/Shared/merges","archive_url":"https://api.github.com/repos/OSGP/Shared/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OSGP/Shared/downloads","issues_url":"https://api.github.com/repos/OSGP/Shared/issues{/number}","pulls_url":"https://api.github.com/repos/OSGP/Shared/pulls{/number}","milestones_url":"https://api.github.com/repos/OSGP/Shared/milestones{/number}","notifications_url":"https://api.github.com/repos/OSGP/Shared/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OSGP/Shared/labels{/name}","releases_url":"https://api.github.com/repos/OSGP/Shared/releases{/id}","deployments_url":"https://api.github.com/repos/OSGP/Shared/deployments","created_at":"2015-03-23T15:02:43Z","updated_at":"2016-01-21T15:07:04Z","pushed_at":"2016-02-18T11:13:22Z","git_url":"git://github.com/OSGP/Shared.git","ssh_url":"git@github.com:OSGP/Shared.git","clone_url":"https://github.com/OSGP/Shared.git","svn_url":"https://github.com/OSGP/Shared","homepage":null,"size":454,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":1,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/OSGP/Shared/pulls/60"},"html":{"href":"https://github.com/OSGP/Shared/pull/60"},"issue":{"href":"https://api.github.com/repos/OSGP/Shared/issues/60"},"comments":{"href":"https://api.github.com/repos/OSGP/Shared/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/OSGP/Shared/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/OSGP/Shared/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OSGP/Shared/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/OSGP/Shared/statuses/0d3800f5b5694b8336adfafed6e9dad838eb4236"}}}}