{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/kibana/issues/7921","repository_url":"https://api.github.com/repos/elastic/kibana","labels_url":"https://api.github.com/repos/elastic/kibana/issues/7921/labels{/name}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/7921/comments","events_url":"https://api.github.com/repos/elastic/kibana/issues/7921/events","html_url":"https://github.com/elastic/kibana/pull/7921","id":169246954,"number":7921,"title":"Add default map-tiles provider to settings -> advanced (Fixes #7050)","user":{"login":"jayeshmori","id":908489,"avatar_url":"https://avatars.githubusercontent.com/u/908489?v=3","gravatar_id":"","url":"https://api.github.com/users/jayeshmori","html_url":"https://github.com/jayeshmori","followers_url":"https://api.github.com/users/jayeshmori/followers","following_url":"https://api.github.com/users/jayeshmori/following{/other_user}","gists_url":"https://api.github.com/users/jayeshmori/gists{/gist_id}","starred_url":"https://api.github.com/users/jayeshmori/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayeshmori/subscriptions","organizations_url":"https://api.github.com/users/jayeshmori/orgs","repos_url":"https://api.github.com/users/jayeshmori/repos","events_url":"https://api.github.com/users/jayeshmori/events{/privacy}","received_events_url":"https://api.github.com/users/jayeshmori/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-03T22:12:10Z","updated_at":"2016-08-04T11:21:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/7921","html_url":"https://github.com/elastic/kibana/pull/7921","diff_url":"https://github.com/elastic/kibana/pull/7921.diff","patch_url":"https://github.com/elastic/kibana/pull/7921.patch"},"body":"@epixa - Here is the pull request for #7050. Sorry for delays.\r\n\r\nSo far, kibana.yml only contains the server/service configurations, and I think it should stay that way. \r\n\r\nAll global / default visualization configurations are exposed under [settings][advanced]. From the consistency perspective moving the map tile service configs in [settings] [advanced] sounds more logical. As you know, the default WMS service configs for tile maps are available in [settings] [advanced] and tile map service configs can sit alongside it. \r\n\r\nHere is the quick overview of the changes.\r\n\r\n1. Removed tileMap configurations from kibana.yml and config schema\r\n2. Added visualization:tileMap:TMSdefaults config in src/ui/public/settings/defaults.js\r\n3. Updated tile_map in core_plugins/kbn_vislib_vis_types to use visualization:tileMap:TMSdefaults config\r\n4. Updated src/ui/public/vislib/visualizations/_map.js to use tms settings for creating Leaflet tileLayer.\r\n5. Updated test case src/ui/public/vislib/__tests__/visualizations/tile_maps/map.js to use TMS config fixture for unit testing\r\n\r\n---\r\nIf the pull request makes sense and gets accepted, then I would like to extend this feature to allow users to customize tile service from visualization -> options. Below is the business case for the same. \r\n\r\nWe have pre-rendered demographic data into two tile maps being served from Mapbox. One is an income choropleth of US and another one is for ethnicity. We want to visualize financial data on both income and ethnicity choropleth maps side by side. A customization at the visualization level ( like the existing WMS configs) will let users use a variety of tile maps."},"comment":{"url":"https://api.github.com/repos/elastic/kibana/issues/comments/237525817","html_url":"https://github.com/elastic/kibana/pull/7921#issuecomment-237525817","issue_url":"https://api.github.com/repos/elastic/kibana/issues/7921","id":237525817,"user":{"login":"epixa","id":53814,"avatar_url":"https://avatars.githubusercontent.com/u/53814?v=3","gravatar_id":"","url":"https://api.github.com/users/epixa","html_url":"https://github.com/epixa","followers_url":"https://api.github.com/users/epixa/followers","following_url":"https://api.github.com/users/epixa/following{/other_user}","gists_url":"https://api.github.com/users/epixa/gists{/gist_id}","starred_url":"https://api.github.com/users/epixa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epixa/subscriptions","organizations_url":"https://api.github.com/users/epixa/orgs","repos_url":"https://api.github.com/users/epixa/repos","events_url":"https://api.github.com/users/epixa/events{/privacy}","received_events_url":"https://api.github.com/users/epixa/received_events","type":"User","site_admin":false},"created_at":"2016-08-04T11:21:57Z","updated_at":"2016-08-04T11:21:57Z","body":"This looks pretty solid.\r\n\r\nWe could still ship an implementation like this in 5.0, but we can't ship this exact implementation in 4.x because it would break backwards compatibility.  For this to get into 4.x, we'd need to have a solution in place to deprecate the existing yml config while still allowing it to function.\r\n\r\n@spalger @jbudz @pickypg @thomasneirynck What do you guys think?"}}
{"actor":{"display_login":"epixa"}}