{"action":"created","issue":{"url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/issues/579","repository_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone","labels_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/issues/579/labels{/name}","comments_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/issues/579/comments","events_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/issues/579/events","html_url":"https://github.com/mixpanel/mixpanel-iphone/pull/579","id":179592221,"number":579,"title":"Updated defaultDistinctId for iOS 10 changes to limiting ad tracking.","user":{"login":"sfarr","id":3172860,"avatar_url":"https://avatars.githubusercontent.com/u/3172860?v=3","gravatar_id":"","url":"https://api.github.com/users/sfarr","html_url":"https://github.com/sfarr","followers_url":"https://api.github.com/users/sfarr/followers","following_url":"https://api.github.com/users/sfarr/following{/other_user}","gists_url":"https://api.github.com/users/sfarr/gists{/gist_id}","starred_url":"https://api.github.com/users/sfarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfarr/subscriptions","organizations_url":"https://api.github.com/users/sfarr/orgs","repos_url":"https://api.github.com/users/sfarr/repos","events_url":"https://api.github.com/users/sfarr/events{/privacy}","received_events_url":"https://api.github.com/users/sfarr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-09-27T19:38:43Z","updated_at":"2016-09-27T21:10:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/pulls/579","html_url":"https://github.com/mixpanel/mixpanel-iphone/pull/579","diff_url":"https://github.com/mixpanel/mixpanel-iphone/pull/579.diff","patch_url":"https://github.com/mixpanel/mixpanel-iphone/pull/579.patch"},"body":"Starting with iOS 10 a user having \"Limit Ad Tracking\" enabled results in the request for the users IFA to respond with \"00000000-0000-0000-0000-000000000000\".  Since the current IFA check in the defaultDistinctId checking for nil multiple users could be provided with the same DistinctId and therefore combining their data into one mixpanel user.  \r\n\r\nIn order to resolve this I simply added a check to the check if there is a need to fall back to the users IFV instead of their IFA for the 0'd out IFA.\r\n\r\nSee: https://developer.apple.com/reference/adsupport/asidentifiermanager"},"comment":{"url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/issues/comments/249999758","html_url":"https://github.com/mixpanel/mixpanel-iphone/pull/579#issuecomment-249999758","issue_url":"https://api.github.com/repos/mixpanel/mixpanel-iphone/issues/579","id":249999758,"user":{"login":"sfarr","id":3172860,"avatar_url":"https://avatars.githubusercontent.com/u/3172860?v=3","gravatar_id":"","url":"https://api.github.com/users/sfarr","html_url":"https://github.com/sfarr","followers_url":"https://api.github.com/users/sfarr/followers","following_url":"https://api.github.com/users/sfarr/following{/other_user}","gists_url":"https://api.github.com/users/sfarr/gists{/gist_id}","starred_url":"https://api.github.com/users/sfarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfarr/subscriptions","organizations_url":"https://api.github.com/users/sfarr/orgs","repos_url":"https://api.github.com/users/sfarr/repos","events_url":"https://api.github.com/users/sfarr/events{/privacy}","received_events_url":"https://api.github.com/users/sfarr/received_events","type":"User","site_admin":false},"created_at":"2016-09-27T21:10:16Z","updated_at":"2016-09-27T21:10:16Z","body":"We were receiving all 0's but it would appear that it turned out we were using an older version of the SDK in our app than I thought my apologies!  Closing the pull request thank you for the rapid response!"}}
{"actor":{"display_login":"sfarr"}}