{"action":"created","comment":{"url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/pulls/comments/76281679","id":76281679,"diff_hunk":"@@ -57,10 +57,11 @@ const inputs = [\n readSequential(inputs)\n     .then(options => {\n         return getCertificate(options).then(certs => {\n+            if(!certs) return Promise.reject(\"Could not get certs. Check previous errors\");","path":"index.js","position":4,"original_position":4,"commit_id":"4c076239c580f97df3b14b1d310d891015ff7cba","original_commit_id":"4c076239c580f97df3b14b1d310d891015ff7cba","user":{"login":"rolodato","id":829698,"avatar_url":"https://avatars.githubusercontent.com/u/829698?v=3","gravatar_id":"","url":"https://api.github.com/users/rolodato","html_url":"https://github.com/rolodato","followers_url":"https://api.github.com/users/rolodato/followers","following_url":"https://api.github.com/users/rolodato/following{/other_user}","gists_url":"https://api.github.com/users/rolodato/gists{/gist_id}","starred_url":"https://api.github.com/users/rolodato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rolodato/subscriptions","organizations_url":"https://api.github.com/users/rolodato/orgs","repos_url":"https://api.github.com/users/rolodato/repos","events_url":"https://api.github.com/users/rolodato/events{/privacy}","received_events_url":"https://api.github.com/users/rolodato/received_events","type":"User","site_admin":false},"body":"Have you found a case where `getCertificate` returns falsy but the promise is resolved? This error shouldn't be handled here (defeats the purpose of returning a promise).\r\n\r\nAlso, please do not use 1-line blocks (always braces) and use single quotes `''`.","created_at":"2016-08-25T16:51:56Z","updated_at":"2016-08-25T16:51:56Z","html_url":"https://github.com/rolodato/gitlab-letsencrypt/pull/8#discussion_r76281679","pull_request_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/pulls/comments/76281679"},"html":{"href":"https://github.com/rolodato/gitlab-letsencrypt/pull/8#discussion_r76281679"},"pull_request":{"href":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/pulls/8","id":82753265,"html_url":"https://github.com/rolodato/gitlab-letsencrypt/pull/8","diff_url":"https://github.com/rolodato/gitlab-letsencrypt/pull/8.diff","patch_url":"https://github.com/rolodato/gitlab-letsencrypt/pull/8.patch","issue_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/issues/8","number":8,"state":"open","locked":false,"title":"Optimize project fetching and improve feedback on errors and delays","user":{"login":"davidlaym","id":595815,"avatar_url":"https://avatars.githubusercontent.com/u/595815?v=3","gravatar_id":"","url":"https://api.github.com/users/davidlaym","html_url":"https://github.com/davidlaym","followers_url":"https://api.github.com/users/davidlaym/followers","following_url":"https://api.github.com/users/davidlaym/following{/other_user}","gists_url":"https://api.github.com/users/davidlaym/gists{/gist_id}","starred_url":"https://api.github.com/users/davidlaym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidlaym/subscriptions","organizations_url":"https://api.github.com/users/davidlaym/orgs","repos_url":"https://api.github.com/users/davidlaym/repos","events_url":"https://api.github.com/users/davidlaym/events{/privacy}","received_events_url":"https://api.github.com/users/davidlaym/received_events","type":"User","site_admin":false},"body":"I'm submitting this PR  Regarding #6 to correct the following problems:\r\n\r\n* To get the GitLab project, the app was using the project list API resource and then filtering. This is both inefficient and error-prone given there is an alternative to get only one project and that the resource used was paginating results to 20 projects per page and there was no simple way to get all projects at once. This lead to the issue #6\r\n* There was no feedback for a minute or so after the app was initiated (generating rsa keys) which lead to believe that it was hung.\r\n* There was no error message printed if the project was not being found. This was a tricky one given how Promise.join works, but nothing out of the realm of possibility\r\n\r\n\r\n","created_at":"2016-08-25T16:38:03Z","updated_at":"2016-08-25T16:51:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c76412b1ba66ed0f86afce4c277c146076fe7581","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/pulls/8/commits","review_comments_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/pulls/8/comments","review_comment_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/issues/8/comments","statuses_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/statuses/4c076239c580f97df3b14b1d310d891015ff7cba","head":{"label":"davidlaym:optimize-project-fetching","ref":"optimize-project-fetching","sha":"4c076239c580f97df3b14b1d310d891015ff7cba","user":{"login":"davidlaym","id":595815,"avatar_url":"https://avatars.githubusercontent.com/u/595815?v=3","gravatar_id":"","url":"https://api.github.com/users/davidlaym","html_url":"https://github.com/davidlaym","followers_url":"https://api.github.com/users/davidlaym/followers","following_url":"https://api.github.com/users/davidlaym/following{/other_user}","gists_url":"https://api.github.com/users/davidlaym/gists{/gist_id}","starred_url":"https://api.github.com/users/davidlaym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidlaym/subscriptions","organizations_url":"https://api.github.com/users/davidlaym/orgs","repos_url":"https://api.github.com/users/davidlaym/repos","events_url":"https://api.github.com/users/davidlaym/events{/privacy}","received_events_url":"https://api.github.com/users/davidlaym/received_events","type":"User","site_admin":false},"repo":{"id":66565241,"name":"gitlab-letsencrypt","full_name":"davidlaym/gitlab-letsencrypt","owner":{"login":"davidlaym","id":595815,"avatar_url":"https://avatars.githubusercontent.com/u/595815?v=3","gravatar_id":"","url":"https://api.github.com/users/davidlaym","html_url":"https://github.com/davidlaym","followers_url":"https://api.github.com/users/davidlaym/followers","following_url":"https://api.github.com/users/davidlaym/following{/other_user}","gists_url":"https://api.github.com/users/davidlaym/gists{/gist_id}","starred_url":"https://api.github.com/users/davidlaym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidlaym/subscriptions","organizations_url":"https://api.github.com/users/davidlaym/orgs","repos_url":"https://api.github.com/users/davidlaym/repos","events_url":"https://api.github.com/users/davidlaym/events{/privacy}","received_events_url":"https://api.github.com/users/davidlaym/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidlaym/gitlab-letsencrypt","description":"Easily generate a Let's Encrypt certificate for GitLab.com hosted pages","fork":true,"url":"https://api.github.com/repos/davidlaym/gitlab-letsencrypt","forks_url":"https://api.github.com/repos/davidlaym/gitlab-letsencrypt/forks","keys_url":"https://api.github.com/repos/davidlaym/gitlab-letsencrypt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidlaym/gitlab-letsencrypt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidlaym/gitlab-letsencrypt/teams","hooks_url":"https://api.github.com/repos/davidlaym/gitlab-letsencrypt/hooks","issue_events_url":"https://api.github.com/repos/davidlaym/gitlab-letsencrypt/issues/events{/number}","events_url":"https://api.github.com/repos/davidlaym/gitlab-letsencrypt/events","assignees_url":"https://api.github.com/repos/davidlaym/gitlab-letsencrypt/assignees{/user}","branches_url":"https://api.github.com/repos/davidlaym/gitlab-letsencrypt/branches{/branch}","tags_url":"https://api.github.com/repos/davidlaym/gitlab-letsencrypt/tags","blobs_url":"https://api.github.com/repos/davidlaym/gitlab-letsencrypt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidlaym/gitlab-letsencrypt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidlaym/gitlab-letsencrypt/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidlaym/gitlab-letsencrypt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidlaym/gitlab-letsencrypt/statuses/{sha}","languages_url":"https://api.github.com/repos/davidlaym/gitlab-letsencrypt/languages","stargazers_url":"https://api.github.com/repos/davidlaym/gitlab-letsencrypt/stargazers","contributors_url":"https://api.github.com/repos/davidlaym/gitlab-letsencrypt/contributors","subscribers_url":"https://api.github.com/repos/davidlaym/gitlab-letsencrypt/subscribers","subscription_url":"https://api.github.com/repos/davidlaym/gitlab-letsencrypt/subscription","commits_url":"https://api.github.com/repos/davidlaym/gitlab-letsencrypt/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidlaym/gitlab-letsencrypt/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidlaym/gitlab-letsencrypt/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidlaym/gitlab-letsencrypt/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidlaym/gitlab-letsencrypt/contents/{+path}","compare_url":"https://api.github.com/repos/davidlaym/gitlab-letsencrypt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidlaym/gitlab-letsencrypt/merges","archive_url":"https://api.github.com/repos/davidlaym/gitlab-letsencrypt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidlaym/gitlab-letsencrypt/downloads","issues_url":"https://api.github.com/repos/davidlaym/gitlab-letsencrypt/issues{/number}","pulls_url":"https://api.github.com/repos/davidlaym/gitlab-letsencrypt/pulls{/number}","milestones_url":"https://api.github.com/repos/davidlaym/gitlab-letsencrypt/milestones{/number}","notifications_url":"https://api.github.com/repos/davidlaym/gitlab-letsencrypt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidlaym/gitlab-letsencrypt/labels{/name}","releases_url":"https://api.github.com/repos/davidlaym/gitlab-letsencrypt/releases{/id}","deployments_url":"https://api.github.com/repos/davidlaym/gitlab-letsencrypt/deployments","created_at":"2016-08-25T14:30:17Z","updated_at":"2016-08-25T14:30:18Z","pushed_at":"2016-08-25T16:29:19Z","git_url":"git://github.com/davidlaym/gitlab-letsencrypt.git","ssh_url":"git@github.com:davidlaym/gitlab-letsencrypt.git","clone_url":"https://github.com/davidlaym/gitlab-letsencrypt.git","svn_url":"https://github.com/davidlaym/gitlab-letsencrypt","homepage":"","size":24,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rolodato:master","ref":"master","sha":"69f5bf2c3fefe73b7bb28f54692d44924f4deaae","user":{"login":"rolodato","id":829698,"avatar_url":"https://avatars.githubusercontent.com/u/829698?v=3","gravatar_id":"","url":"https://api.github.com/users/rolodato","html_url":"https://github.com/rolodato","followers_url":"https://api.github.com/users/rolodato/followers","following_url":"https://api.github.com/users/rolodato/following{/other_user}","gists_url":"https://api.github.com/users/rolodato/gists{/gist_id}","starred_url":"https://api.github.com/users/rolodato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rolodato/subscriptions","organizations_url":"https://api.github.com/users/rolodato/orgs","repos_url":"https://api.github.com/users/rolodato/repos","events_url":"https://api.github.com/users/rolodato/events{/privacy}","received_events_url":"https://api.github.com/users/rolodato/received_events","type":"User","site_admin":false},"repo":{"id":63467635,"name":"gitlab-letsencrypt","full_name":"rolodato/gitlab-letsencrypt","owner":{"login":"rolodato","id":829698,"avatar_url":"https://avatars.githubusercontent.com/u/829698?v=3","gravatar_id":"","url":"https://api.github.com/users/rolodato","html_url":"https://github.com/rolodato","followers_url":"https://api.github.com/users/rolodato/followers","following_url":"https://api.github.com/users/rolodato/following{/other_user}","gists_url":"https://api.github.com/users/rolodato/gists{/gist_id}","starred_url":"https://api.github.com/users/rolodato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rolodato/subscriptions","organizations_url":"https://api.github.com/users/rolodato/orgs","repos_url":"https://api.github.com/users/rolodato/repos","events_url":"https://api.github.com/users/rolodato/events{/privacy}","received_events_url":"https://api.github.com/users/rolodato/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rolodato/gitlab-letsencrypt","description":"Easily generate a Let's Encrypt certificate for GitLab.com hosted pages","fork":false,"url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt","forks_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/forks","keys_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/teams","hooks_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/hooks","issue_events_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/issues/events{/number}","events_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/events","assignees_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/assignees{/user}","branches_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/branches{/branch}","tags_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/tags","blobs_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/git/refs{/sha}","trees_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/statuses/{sha}","languages_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/languages","stargazers_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/stargazers","contributors_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/contributors","subscribers_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/subscribers","subscription_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/subscription","commits_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/commits{/sha}","git_commits_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/git/commits{/sha}","comments_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/comments{/number}","issue_comment_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/issues/comments{/number}","contents_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/contents/{+path}","compare_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/merges","archive_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/downloads","issues_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/issues{/number}","pulls_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/pulls{/number}","milestones_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/milestones{/number}","notifications_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/labels{/name}","releases_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/releases{/id}","deployments_url":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/deployments","created_at":"2016-07-16T05:44:38Z","updated_at":"2016-08-16T15:19:46Z","pushed_at":"2016-08-25T16:38:03Z","git_url":"git://github.com/rolodato/gitlab-letsencrypt.git","ssh_url":"git@github.com:rolodato/gitlab-letsencrypt.git","clone_url":"https://github.com/rolodato/gitlab-letsencrypt.git","svn_url":"https://github.com/rolodato/gitlab-letsencrypt","homepage":"","size":21,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":7,"forks":2,"open_issues":7,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/pulls/8"},"html":{"href":"https://github.com/rolodato/gitlab-letsencrypt/pull/8"},"issue":{"href":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/issues/8"},"comments":{"href":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/rolodato/gitlab-letsencrypt/statuses/4c076239c580f97df3b14b1d310d891015ff7cba"}}}}
{"actor":{"display_login":"rolodato"}}