{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/19889","labels_url":"https://api.github.com/repos/docker/docker/issues/19889/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/19889/comments","events_url":"https://api.github.com/repos/docker/docker/issues/19889/events","html_url":"https://github.com/docker/docker/pull/19889","id":130451870,"number":19889,"title":"Windows CI: TP4 reliability hack","user":{"login":"jhowardmsft","id":10522484,"avatar_url":"https://avatars.githubusercontent.com/u/10522484?v=3","gravatar_id":"","url":"https://api.github.com/users/jhowardmsft","html_url":"https://github.com/jhowardmsft","followers_url":"https://api.github.com/users/jhowardmsft/followers","following_url":"https://api.github.com/users/jhowardmsft/following{/other_user}","gists_url":"https://api.github.com/users/jhowardmsft/gists{/gist_id}","starred_url":"https://api.github.com/users/jhowardmsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhowardmsft/subscriptions","organizations_url":"https://api.github.com/users/jhowardmsft/orgs","repos_url":"https://api.github.com/users/jhowardmsft/repos","events_url":"https://api.github.com/users/jhowardmsft/events{/privacy}","received_events_url":"https://api.github.com/users/jhowardmsft/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/group/windows","name":"group/windows","color":"F6FBFF"},{"url":"https://api.github.com/repos/docker/docker/labels/status/1-design-review","name":"status/1-design-review","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-02-01T19:02:49Z","updated_at":"2016-02-01T21:45:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/19889","html_url":"https://github.com/docker/docker/pull/19889","diff_url":"https://github.com/docker/docker/pull/19889.diff","patch_url":"https://github.com/docker/docker/pull/19889.patch"},"body":"Signed-off-by: John Howard <jhoward@microsoft.com>\r\n\r\n@mikedougherty @jfrazelle @icecrime @powersplay @friism @tonistiigi\r\n\r\nThis is a WAY better version of #19855. Still a horrible hack :smiling_imp:, but will make TP4 Windows to Windows CI far, far, far more reliable :heart:. I've also in this PR re-enabled the tests which were the most able to cause false failures, recently disabled in #19867. I've run the TestPsListContainers* tests many many times locally on a TP4 machine and not seen failures after this hack is in place.\r\n\r\nIt also has the side effect of making docker more reliable for regular users using TP4 and a newer docker, once this is merged :smile:"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/178209218","html_url":"https://github.com/docker/docker/pull/19889#issuecomment-178209218","issue_url":"https://api.github.com/repos/docker/docker/issues/19889","id":178209218,"user":{"login":"jhowardmsft","id":10522484,"avatar_url":"https://avatars.githubusercontent.com/u/10522484?v=3","gravatar_id":"","url":"https://api.github.com/users/jhowardmsft","html_url":"https://github.com/jhowardmsft","followers_url":"https://api.github.com/users/jhowardmsft/followers","following_url":"https://api.github.com/users/jhowardmsft/following{/other_user}","gists_url":"https://api.github.com/users/jhowardmsft/gists{/gist_id}","starred_url":"https://api.github.com/users/jhowardmsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhowardmsft/subscriptions","organizations_url":"https://api.github.com/users/jhowardmsft/orgs","repos_url":"https://api.github.com/users/jhowardmsft/repos","events_url":"https://api.github.com/users/jhowardmsft/events{/privacy}","received_events_url":"https://api.github.com/users/jhowardmsft/received_events","type":"User","site_admin":false},"created_at":"2016-02-01T21:45:50Z","updated_at":"2016-02-01T21:45:50Z","body":"10 runs of the tests which cause this the most often passed :smile:\r\n\r\n```\r\n\r\nE:\\go\\src\\github.com\\docker\\docker>runtest w TestPsListContainers\r\nRunning test TestPsListContainers\r\nDOCKER_TEST_HOST=tcp://127.0.0.1:2375\r\nDOCKER_HOST=tcp://127.0.0.1:2375\r\n=== RUN   Test\r\nINFO: Testing against a local daemon\r\nPASS: docker_cli_ps_test.go:19: DockerSuite.TestPsListContainersBase    15.697s\r\nPASS: docker_cli_ps_test.go:247: DockerSuite.TestPsListContainersFilterAncestorImage    53.009s\r\nPASS: docker_cli_ps_test.go:497: DockerSuite.TestPsListContainersFilterCreated  0.588s\r\nPASS: docker_cli_ps_test.go:378: DockerSuite.TestPsListContainersFilterExited   21.819s\r\nPASS: docker_cli_ps_test.go:209: DockerSuite.TestPsListContainersFilterID       7.652s\r\nPASS: docker_cli_ps_test.go:342: DockerSuite.TestPsListContainersFilterLabel    11.510s\r\nPASS: docker_cli_ps_test.go:224: DockerSuite.TestPsListContainersFilterName     7.596s\r\nPASS: docker_cli_ps_test.go:170: DockerSuite.TestPsListContainersFilterStatus   8.601s\r\nSKIP: docker_cli_ps_test.go:128: DockerSuite.TestPsListContainersSize (Test requires a Linux daemon)\r\nSKIP: docker_cli_by_digest_test.go:340: DockerRegistrySuite.TestPsListContainersFilterAncestorImageByDigest\r\nOK: 8 passed, 2 skipped\r\n--- PASS: Test (140.67s)\r\nPASS\r\nok      _/E_/go/src/github.com/docker/docker/integration-cli    140.877s\r\n\r\nE:\\go\\src\\github.com\\docker\\docker>runtest w TestPsListContainers\r\nRunning test TestPsListContainers\r\nDOCKER_TEST_HOST=tcp://127.0.0.1:2375\r\nDOCKER_HOST=tcp://127.0.0.1:2375\r\n=== RUN   Test\r\nINFO: Testing against a local daemon\r\nPASS: docker_cli_ps_test.go:19: DockerSuite.TestPsListContainersBase    14.956s\r\nPASS: docker_cli_ps_test.go:247: DockerSuite.TestPsListContainersFilterAncestorImage    42.447s\r\nPASS: docker_cli_ps_test.go:497: DockerSuite.TestPsListContainersFilterCreated  0.602s\r\nPASS: docker_cli_ps_test.go:378: DockerSuite.TestPsListContainersFilterExited   23.691s\r\nPASS: docker_cli_ps_test.go:209: DockerSuite.TestPsListContainersFilterID       8.405s\r\nPASS: docker_cli_ps_test.go:342: DockerSuite.TestPsListContainersFilterLabel    12.349s\r\nPASS: docker_cli_ps_test.go:224: DockerSuite.TestPsListContainersFilterName     7.737s\r\nPASS: docker_cli_ps_test.go:170: DockerSuite.TestPsListContainersFilterStatus   8.435s\r\nSKIP: docker_cli_ps_test.go:128: DockerSuite.TestPsListContainersSize (Test requires a Linux daemon)\r\nSKIP: docker_cli_by_digest_test.go:340: DockerRegistrySuite.TestPsListContainersFilterAncestorImageByDigest\r\nOK: 8 passed, 2 skipped\r\n--- PASS: Test (146.27s)\r\nPASS\r\nok      _/E_/go/src/github.com/docker/docker/integration-cli    146.454s\r\n\r\nE:\\go\\src\\github.com\\docker\\docker>runtest w TestPsListContainers\r\nRunning test TestPsListContainers\r\nDOCKER_TEST_HOST=tcp://127.0.0.1:2375\r\nDOCKER_HOST=tcp://127.0.0.1:2375\r\n=== RUN   Test\r\nINFO: Testing against a local daemon\r\nPASS: docker_cli_ps_test.go:19: DockerSuite.TestPsListContainersBase    17.023s\r\nPASS: docker_cli_ps_test.go:247: DockerSuite.TestPsListContainersFilterAncestorImage    32.006s\r\nPASS: docker_cli_ps_test.go:497: DockerSuite.TestPsListContainersFilterCreated  0.591s\r\nPASS: docker_cli_ps_test.go:378: DockerSuite.TestPsListContainersFilterExited   22.750s\r\nPASS: docker_cli_ps_test.go:209: DockerSuite.TestPsListContainersFilterID       6.897s\r\nPASS: docker_cli_ps_test.go:342: DockerSuite.TestPsListContainersFilterLabel    11.527s\r\nPASS: docker_cli_ps_test.go:224: DockerSuite.TestPsListContainersFilterName     7.913s\r\nPASS: docker_cli_ps_test.go:170: DockerSuite.TestPsListContainersFilterStatus   8.588s\r\nSKIP: docker_cli_ps_test.go:128: DockerSuite.TestPsListContainersSize (Test requires a Linux daemon)\r\nSKIP: docker_cli_by_digest_test.go:340: DockerRegistrySuite.TestPsListContainersFilterAncestorImageByDigest\r\nOK: 8 passed, 2 skipped\r\n--- PASS: Test (122.09s)\r\nPASS\r\nok      _/E_/go/src/github.com/docker/docker/integration-cli    122.211s\r\n\r\nE:\\go\\src\\github.com\\docker\\docker>runtest w TestPsListContainers\r\nRunning test TestPsListContainers\r\nDOCKER_TEST_HOST=tcp://127.0.0.1:2375\r\nDOCKER_HOST=tcp://127.0.0.1:2375\r\n=== RUN   Test\r\nINFO: Testing against a local daemon\r\nPASS: docker_cli_ps_test.go:19: DockerSuite.TestPsListContainersBase    15.735s\r\nPASS: docker_cli_ps_test.go:247: DockerSuite.TestPsListContainersFilterAncestorImage    43.611s\r\nPASS: docker_cli_ps_test.go:497: DockerSuite.TestPsListContainersFilterCreated  0.667s\r\nPASS: docker_cli_ps_test.go:378: DockerSuite.TestPsListContainersFilterExited   27.959s\r\nPASS: docker_cli_ps_test.go:209: DockerSuite.TestPsListContainersFilterID       7.990s\r\nPASS: docker_cli_ps_test.go:342: DockerSuite.TestPsListContainersFilterLabel    11.626s\r\nPASS: docker_cli_ps_test.go:224: DockerSuite.TestPsListContainersFilterName     7.870s\r\nPASS: docker_cli_ps_test.go:170: DockerSuite.TestPsListContainersFilterStatus   9.591s\r\nSKIP: docker_cli_ps_test.go:128: DockerSuite.TestPsListContainersSize (Test requires a Linux daemon)\r\nSKIP: docker_cli_by_digest_test.go:340: DockerRegistrySuite.TestPsListContainersFilterAncestorImageByDigest\r\nOK: 8 passed, 2 skipped\r\n--- PASS: Test (140.44s)\r\nPASS\r\nok      _/E_/go/src/github.com/docker/docker/integration-cli    140.618s\r\n\r\nE:\\go\\src\\github.com\\docker\\docker>runtest w TestPsListContainers\r\nRunning test TestPsListContainers\r\nDOCKER_TEST_HOST=tcp://127.0.0.1:2375\r\nDOCKER_HOST=tcp://127.0.0.1:2375\r\n=== RUN   Test\r\nINFO: Testing against a local daemon\r\nPASS: docker_cli_ps_test.go:19: DockerSuite.TestPsListContainersBase    15.536s\r\nPASS: docker_cli_ps_test.go:247: DockerSuite.TestPsListContainersFilterAncestorImage    22.074s\r\nPASS: docker_cli_ps_test.go:497: DockerSuite.TestPsListContainersFilterCreated  0.617s\r\nPASS: docker_cli_ps_test.go:378: DockerSuite.TestPsListContainersFilterExited   23.262s\r\nPASS: docker_cli_ps_test.go:209: DockerSuite.TestPsListContainersFilterID       7.933s\r\nPASS: docker_cli_ps_test.go:342: DockerSuite.TestPsListContainersFilterLabel    11.540s\r\nPASS: docker_cli_ps_test.go:224: DockerSuite.TestPsListContainersFilterName     7.809s\r\nPASS: docker_cli_ps_test.go:170: DockerSuite.TestPsListContainersFilterStatus   8.776s\r\nSKIP: docker_cli_ps_test.go:128: DockerSuite.TestPsListContainersSize (Test requires a Linux daemon)\r\nSKIP: docker_cli_by_digest_test.go:340: DockerRegistrySuite.TestPsListContainersFilterAncestorImageByDigest\r\nOK: 8 passed, 2 skipped\r\n--- PASS: Test (113.27s)\r\nPASS\r\nok      _/E_/go/src/github.com/docker/docker/integration-cli    113.513s\r\n\r\nE:\\go\\src\\github.com\\docker\\docker>runtest w TestPsListContainers\r\nRunning test TestPsListContainers\r\nDOCKER_TEST_HOST=tcp://127.0.0.1:2375\r\nDOCKER_HOST=tcp://127.0.0.1:2375\r\n=== RUN   Test\r\nINFO: Testing against a local daemon\r\nPASS: docker_cli_ps_test.go:19: DockerSuite.TestPsListContainersBase    15.811s\r\nPASS: docker_cli_ps_test.go:247: DockerSuite.TestPsListContainersFilterAncestorImage    43.078s\r\nPASS: docker_cli_ps_test.go:497: DockerSuite.TestPsListContainersFilterCreated  0.605s\r\nPASS: docker_cli_ps_test.go:378: DockerSuite.TestPsListContainersFilterExited   24.203s\r\nPASS: docker_cli_ps_test.go:209: DockerSuite.TestPsListContainersFilterID       8.334s\r\nPASS: docker_cli_ps_test.go:342: DockerSuite.TestPsListContainersFilterLabel    12.502s\r\nPASS: docker_cli_ps_test.go:224: DockerSuite.TestPsListContainersFilterName     7.389s\r\nPASS: docker_cli_ps_test.go:170: DockerSuite.TestPsListContainersFilterStatus   8.657s\r\nSKIP: docker_cli_ps_test.go:128: DockerSuite.TestPsListContainersSize (Test requires a Linux daemon)\r\nSKIP: docker_cli_by_digest_test.go:340: DockerRegistrySuite.TestPsListContainersFilterAncestorImageByDigest\r\nOK: 8 passed, 2 skipped\r\n--- PASS: Test (135.84s)\r\nPASS\r\nok      _/E_/go/src/github.com/docker/docker/integration-cli    136.039s\r\n\r\nE:\\go\\src\\github.com\\docker\\docker>runtest w TestPsListContainers\r\nRunning test TestPsListContainers\r\nDOCKER_TEST_HOST=tcp://127.0.0.1:2375\r\nDOCKER_HOST=tcp://127.0.0.1:2375\r\n=== RUN   Test\r\nINFO: Testing against a local daemon\r\nPASS: docker_cli_ps_test.go:19: DockerSuite.TestPsListContainersBase    15.732s\r\nPASS: docker_cli_ps_test.go:247: DockerSuite.TestPsListContainersFilterAncestorImage    33.190s\r\nPASS: docker_cli_ps_test.go:497: DockerSuite.TestPsListContainersFilterCreated  0.604s\r\nPASS: docker_cli_ps_test.go:378: DockerSuite.TestPsListContainersFilterExited   24.632s\r\nPASS: docker_cli_ps_test.go:209: DockerSuite.TestPsListContainersFilterID       8.184s\r\nPASS: docker_cli_ps_test.go:342: DockerSuite.TestPsListContainersFilterLabel    13.625s\r\nPASS: docker_cli_ps_test.go:224: DockerSuite.TestPsListContainersFilterName     8.142s\r\nPASS: docker_cli_ps_test.go:170: DockerSuite.TestPsListContainersFilterStatus   8.588s\r\nSKIP: docker_cli_ps_test.go:128: DockerSuite.TestPsListContainersSize (Test requires a Linux daemon)\r\nSKIP: docker_cli_by_digest_test.go:340: DockerRegistrySuite.TestPsListContainersFilterAncestorImageByDigest\r\nOK: 8 passed, 2 skipped\r\n--- PASS: Test (128.10s)\r\nPASS\r\nok      _/E_/go/src/github.com/docker/docker/integration-cli    128.301s\r\n\r\nE:\\go\\src\\github.com\\docker\\docker>runtest w TestPsListContainers\r\nRunning test TestPsListContainers\r\nDOCKER_TEST_HOST=tcp://127.0.0.1:2375\r\nDOCKER_HOST=tcp://127.0.0.1:2375\r\n=== RUN   Test\r\nINFO: Testing against a local daemon\r\nPASS: docker_cli_ps_test.go:19: DockerSuite.TestPsListContainersBase    16.476s\r\nPASS: docker_cli_ps_test.go:247: DockerSuite.TestPsListContainersFilterAncestorImage    53.740s\r\nPASS: docker_cli_ps_test.go:497: DockerSuite.TestPsListContainersFilterCreated  0.621s\r\nPASS: docker_cli_ps_test.go:378: DockerSuite.TestPsListContainersFilterExited   24.519s\r\nPASS: docker_cli_ps_test.go:209: DockerSuite.TestPsListContainersFilterID       8.212s\r\nPASS: docker_cli_ps_test.go:342: DockerSuite.TestPsListContainersFilterLabel    12.629s\r\nPASS: docker_cli_ps_test.go:224: DockerSuite.TestPsListContainersFilterName     7.602s\r\nPASS: docker_cli_ps_test.go:170: DockerSuite.TestPsListContainersFilterStatus   9.254s\r\nSKIP: docker_cli_ps_test.go:128: DockerSuite.TestPsListContainersSize (Test requires a Linux daemon)\r\nSKIP: docker_cli_by_digest_test.go:340: DockerRegistrySuite.TestPsListContainersFilterAncestorImageByDigest\r\nOK: 8 passed, 2 skipped\r\n--- PASS: Test (148.20s)\r\nPASS\r\nok      _/E_/go/src/github.com/docker/docker/integration-cli    148.408s\r\n\r\nE:\\go\\src\\github.com\\docker\\docker>runtest w TestPsListContainers\r\nRunning test TestPsListContainers\r\nDOCKER_TEST_HOST=tcp://127.0.0.1:2375\r\nDOCKER_HOST=tcp://127.0.0.1:2375\r\n=== RUN   Test\r\nINFO: Testing against a local daemon\r\nPASS: docker_cli_ps_test.go:19: DockerSuite.TestPsListContainersBase    17.422s\r\nPASS: docker_cli_ps_test.go:247: DockerSuite.TestPsListContainersFilterAncestorImage    33.367s\r\nPASS: docker_cli_ps_test.go:497: DockerSuite.TestPsListContainersFilterCreated  0.611s\r\nPASS: docker_cli_ps_test.go:378: DockerSuite.TestPsListContainersFilterExited   23.962s\r\nPASS: docker_cli_ps_test.go:209: DockerSuite.TestPsListContainersFilterID       8.698s\r\nPASS: docker_cli_ps_test.go:342: DockerSuite.TestPsListContainersFilterLabel    14.097s\r\nPASS: docker_cli_ps_test.go:224: DockerSuite.TestPsListContainersFilterName     10.033s\r\nPASS: docker_cli_ps_test.go:170: DockerSuite.TestPsListContainersFilterStatus   8.816s\r\nSKIP: docker_cli_ps_test.go:128: DockerSuite.TestPsListContainersSize (Test requires a Linux daemon)\r\nSKIP: docker_cli_by_digest_test.go:340: DockerRegistrySuite.TestPsListContainersFilterAncestorImageByDigest\r\nOK: 8 passed, 2 skipped\r\n--- PASS: Test (132.01s)\r\nPASS\r\nok      _/E_/go/src/github.com/docker/docker/integration-cli    132.291s\r\n\r\nE:\\go\\src\\github.com\\docker\\docker>runtest w TestPsListContainers\r\nRunning test TestPsListContainers\r\nDOCKER_TEST_HOST=tcp://127.0.0.1:2375\r\nDOCKER_HOST=tcp://127.0.0.1:2375\r\n=== RUN   Test\r\nINFO: Testing against a local daemon\r\nPASS: docker_cli_ps_test.go:19: DockerSuite.TestPsListContainersBase    17.061s\r\nPASS: docker_cli_ps_test.go:247: DockerSuite.TestPsListContainersFilterAncestorImage    42.783s\r\nPASS: docker_cli_ps_test.go:497: DockerSuite.TestPsListContainersFilterCreated  0.599s\r\nPASS: docker_cli_ps_test.go:378: DockerSuite.TestPsListContainersFilterExited   23.404s\r\nPASS: docker_cli_ps_test.go:209: DockerSuite.TestPsListContainersFilterID       7.267s\r\nPASS: docker_cli_ps_test.go:342: DockerSuite.TestPsListContainersFilterLabel    11.370s\r\nPASS: docker_cli_ps_test.go:224: DockerSuite.TestPsListContainersFilterName     9.443s\r\nPASS: docker_cli_ps_test.go:170: DockerSuite.TestPsListContainersFilterStatus   8.521s\r\nSKIP: docker_cli_ps_test.go:128: DockerSuite.TestPsListContainersSize (Test requires a Linux daemon)\r\nSKIP: docker_cli_by_digest_test.go:340: DockerRegistrySuite.TestPsListContainersFilterAncestorImageByDigest\r\nOK: 8 passed, 2 skipped\r\n--- PASS: Test (135.02s)\r\nPASS\r\nok      _/E_/go/src/github.com/docker/docker/integration-cli    135.246s\r\n\r\nE:\\go\\src\\github.com\\docker\\docker>\r\n```"}}