{"action":"created","issue":{"url":"https://api.github.com/repos/terhechte/SourceKittenDaemon/issues/50","repository_url":"https://api.github.com/repos/terhechte/SourceKittenDaemon","labels_url":"https://api.github.com/repos/terhechte/SourceKittenDaemon/issues/50/labels{/name}","comments_url":"https://api.github.com/repos/terhechte/SourceKittenDaemon/issues/50/comments","events_url":"https://api.github.com/repos/terhechte/SourceKittenDaemon/issues/50/events","html_url":"https://github.com/terhechte/SourceKittenDaemon/pull/50","id":184988778,"number":50,"title":"Add support for Swift 3 and latest SourceKitten","user":{"login":"nanzhong","id":224216,"avatar_url":"https://avatars.githubusercontent.com/u/224216?v=3","gravatar_id":"","url":"https://api.github.com/users/nanzhong","html_url":"https://github.com/nanzhong","followers_url":"https://api.github.com/users/nanzhong/followers","following_url":"https://api.github.com/users/nanzhong/following{/other_user}","gists_url":"https://api.github.com/users/nanzhong/gists{/gist_id}","starred_url":"https://api.github.com/users/nanzhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nanzhong/subscriptions","organizations_url":"https://api.github.com/users/nanzhong/orgs","repos_url":"https://api.github.com/users/nanzhong/repos","events_url":"https://api.github.com/users/nanzhong/events{/privacy}","received_events_url":"https://api.github.com/users/nanzhong/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2016-10-25T00:24:43Z","updated_at":"2016-11-19T20:51:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/terhechte/SourceKittenDaemon/pulls/50","html_url":"https://github.com/terhechte/SourceKittenDaemon/pull/50","diff_url":"https://github.com/terhechte/SourceKittenDaemon/pull/50.diff","patch_url":"https://github.com/terhechte/SourceKittenDaemon/pull/50.patch"},"body":"I'm totally new to swift and this codebase, but I've had a lot of trouble getting this working and thought I'd try and contribute an update. I've made a number of big changes, so feel free to tell me my understanding and assumptions of this project are not sound and this this PR isn't even salvageable :).\n\nThings that I've changed:\n- Updated the syntax to be swift 3 compliant\n- Removed the xcode project and carthage in favour of the swift package manager (hopefully this will help with [future linux compatibility](https://github.com/terhechte/SourceKittenDaemon/issues/19)\n- Bump all dependencies to their latest versions (Commandant and SourceKitten)\n- Pulled in Xcode.swift's latest version via swift package manager\n- Drop Taylor in favour of Vapor\n- Split the build build targets into the framework (SourceKittenDaemon) and the cli (sourcekittend)\n\nA number of the dependencies are \"almost\" swift package manger ready, so I've forked those repos and made the changes necessary for this to work, but I feel like if this is an acceptable approach to updating this project, I can submit PRs to those repos for the changes.\n\nThings are successfully building and completion seems to work (able to get completion results, but have not yet verified whether the results are the expected ones).\n\nI have not put a lot of thought into the changes to make this compilable in Swift 3 so there's obviously a lot of room of improvement and refactoring, which I will be doing in the next little bit, but I thought I'd share my progress so far.\n\nGive it a try `swift build`.\n\nWould love your feedback on this, and how I could help contribute to this project.\n\n_Note: I have not updated the travis config so the build is going to fail_\n"},"comment":{"url":"https://api.github.com/repos/terhechte/SourceKittenDaemon/issues/comments/261738850","html_url":"https://github.com/terhechte/SourceKittenDaemon/pull/50#issuecomment-261738850","issue_url":"https://api.github.com/repos/terhechte/SourceKittenDaemon/issues/50","id":261738850,"user":{"login":"nanzhong","id":224216,"avatar_url":"https://avatars.githubusercontent.com/u/224216?v=3","gravatar_id":"","url":"https://api.github.com/users/nanzhong","html_url":"https://github.com/nanzhong","followers_url":"https://api.github.com/users/nanzhong/followers","following_url":"https://api.github.com/users/nanzhong/following{/other_user}","gists_url":"https://api.github.com/users/nanzhong/gists{/gist_id}","starred_url":"https://api.github.com/users/nanzhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nanzhong/subscriptions","organizations_url":"https://api.github.com/users/nanzhong/orgs","repos_url":"https://api.github.com/users/nanzhong/repos","events_url":"https://api.github.com/users/nanzhong/events{/privacy}","received_events_url":"https://api.github.com/users/nanzhong/received_events","type":"User","site_admin":false},"created_at":"2016-11-19T20:51:56Z","updated_at":"2016-11-19T20:51:56Z","body":"Ok, auto-generating the project at build time won't work because of the aforementioned assumption about the ordering of the targets. So instead I'm going to create a test Xcode project that will be used specifically for testing. This should work for the time being until we can look into how to remove the assumption regarding the ordering of the targets."}}
{"actor":{"display_login":"nanzhong"}}