{"action":"created","issue":{"url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/3163","repository_url":"https://api.github.com/repos/ansible/ansible-modules-core","labels_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/3163/labels{/name}","comments_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/3163/comments","events_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/3163/events","html_url":"https://github.com/ansible/ansible-modules-core/pull/3163","id":137690160,"number":3163,"title":"add tagging functionality to elb module","user":{"login":"nand0p","id":1916245,"avatar_url":"https://avatars.githubusercontent.com/u/1916245?v=3","gravatar_id":"","url":"https://api.github.com/users/nand0p","html_url":"https://github.com/nand0p","followers_url":"https://api.github.com/users/nand0p/followers","following_url":"https://api.github.com/users/nand0p/following{/other_user}","gists_url":"https://api.github.com/users/nand0p/gists{/gist_id}","starred_url":"https://api.github.com/users/nand0p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nand0p/subscriptions","organizations_url":"https://api.github.com/users/nand0p/orgs","repos_url":"https://api.github.com/users/nand0p/repos","events_url":"https://api.github.com/users/nand0p/events{/privacy}","received_events_url":"https://api.github.com/users/nand0p/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ansible/ansible-modules-core/labels/cloud","name":"cloud","color":"c7def8"},{"url":"https://api.github.com/repos/ansible/ansible-modules-core/labels/shipit","name":"shipit","color":"f7c6c7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":22,"created_at":"2016-03-01T21:19:37Z","updated_at":"2016-03-18T14:50:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ansible/ansible-modules-core/pulls/3163","html_url":"https://github.com/ansible/ansible-modules-core/pull/3163","diff_url":"https://github.com/ansible/ansible-modules-core/pull/3163.diff","patch_url":"https://github.com/ansible/ansible-modules-core/pull/3163.patch"},"body":"##### Issue Type:\r\n\r\n - Feature Pull Request\r\n\r\n##### Plugin Name:\r\n\r\nec2_elb_lb\r\n\r\n##### Summary:\r\n\r\nAdds tagging to ec2_elb_lb module\r\n\r\nthis module will only add + modify tags.  it will not delete tags that are present on elb, but not defined in list of tag dicts.  this is to ensure important tags that are manually added, like janitor monkey or billing codes, are not inadvertantly deleted.\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/comments/198394724","html_url":"https://github.com/ansible/ansible-modules-core/pull/3163#issuecomment-198394724","issue_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/3163","id":198394724,"user":{"login":"mmochan","id":80488,"avatar_url":"https://avatars.githubusercontent.com/u/80488?v=3","gravatar_id":"","url":"https://api.github.com/users/mmochan","html_url":"https://github.com/mmochan","followers_url":"https://api.github.com/users/mmochan/followers","following_url":"https://api.github.com/users/mmochan/following{/other_user}","gists_url":"https://api.github.com/users/mmochan/gists{/gist_id}","starred_url":"https://api.github.com/users/mmochan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmochan/subscriptions","organizations_url":"https://api.github.com/users/mmochan/orgs","repos_url":"https://api.github.com/users/mmochan/repos","events_url":"https://api.github.com/users/mmochan/events{/privacy}","received_events_url":"https://api.github.com/users/mmochan/received_events","type":"User","site_admin":false},"created_at":"2016-03-18T14:50:59Z","updated_at":"2016-03-18T14:50:59Z","body":"@smiller171 Agreed in the ec2_group module there is a parameter that allows you to specify purge_rules, however I fail to see the relevance between Security Group/ Firewall  rules and resource tagging.\r\n\r\nIMHO If you are making manual changes outside of your 'Infrastructure as Code single source of truth\", where do you draw the line about what can be added. You might start with a couple of manually added tags but how many exceptions to the rule are you prepared to make? If you follow on down that track you are in for a whole world of pain.\r\n\r\nIf you have external tools that make changes to your Infra then you need to figure out a way to include those changes into your infra code base.  You need to be able to rebuild everything from your Infrastructure codebase otherwise you are doing it wrong :-)\r\n\r\n\r\n\r\n\r\n\r\n\r\n"}}