{"action":"created","comment":{"url":"https://api.github.com/repos/aframevr/aframe/pulls/comments/57968995","id":57968995,"diff_hunk":"@@ -463,3 +479,35 @@ function strToBool (str) {\n function boolToNum (bool) {\n   return bool ? 1 : 0;\n }\n+\n+/**\n+ * Converts a number 0-255 to hex\n+ * @param {color}\n+ * @returns {string}\n+ */\n+function componentToHex (color) {\n+  var hex = color.toString(16);","path":"src/core/a-animation.js","position":48,"original_position":48,"commit_id":"3987a47255cbb44263553fe473c5fadc4594e087","original_commit_id":"3987a47255cbb44263553fe473c5fadc4594e087","user":{"login":"JohnRodney","id":11075982,"avatar_url":"https://avatars.githubusercontent.com/u/11075982?v=3","gravatar_id":"","url":"https://api.github.com/users/JohnRodney","html_url":"https://github.com/JohnRodney","followers_url":"https://api.github.com/users/JohnRodney/followers","following_url":"https://api.github.com/users/JohnRodney/following{/other_user}","gists_url":"https://api.github.com/users/JohnRodney/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnRodney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnRodney/subscriptions","organizations_url":"https://api.github.com/users/JohnRodney/orgs","repos_url":"https://api.github.com/users/JohnRodney/repos","events_url":"https://api.github.com/users/JohnRodney/events{/privacy}","received_events_url":"https://api.github.com/users/JohnRodney/received_events","type":"User","site_admin":false},"body":"@dmarcos @ngokevin Hey this could be clamped in the function that calls this by doing a:\r\n`  return Math.floor(Match.min(Math.abs(color), 255) * 255);`\r\ninside of the convertToIntegerColor() function.  Would this be acceptable?  Or would you prefer a separate clamp function?\r\n","created_at":"2016-03-30T21:42:18Z","updated_at":"2016-03-30T21:42:18Z","html_url":"https://github.com/aframevr/aframe/pull/1302#discussion_r57968995","pull_request_url":"https://api.github.com/repos/aframevr/aframe/pulls/1302","_links":{"self":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/comments/57968995"},"html":{"href":"https://github.com/aframevr/aframe/pull/1302#discussion_r57968995"},"pull_request":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/1302"}}},"pull_request":{"url":"https://api.github.com/repos/aframevr/aframe/pulls/1302","id":64690366,"html_url":"https://github.com/aframevr/aframe/pull/1302","diff_url":"https://github.com/aframevr/aframe/pull/1302.diff","patch_url":"https://github.com/aframevr/aframe/pull/1302.patch","issue_url":"https://api.github.com/repos/aframevr/aframe/issues/1302","number":1302,"state":"open","locked":false,"title":"adds the feature to animate a color property on the a-animation compo…","user":{"login":"JohnRodney","id":11075982,"avatar_url":"https://avatars.githubusercontent.com/u/11075982?v=3","gravatar_id":"","url":"https://api.github.com/users/JohnRodney","html_url":"https://github.com/JohnRodney","followers_url":"https://api.github.com/users/JohnRodney/followers","following_url":"https://api.github.com/users/JohnRodney/following{/other_user}","gists_url":"https://api.github.com/users/JohnRodney/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnRodney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnRodney/subscriptions","organizations_url":"https://api.github.com/users/JohnRodney/orgs","repos_url":"https://api.github.com/users/JohnRodney/repos","events_url":"https://api.github.com/users/JohnRodney/events{/privacy}","received_events_url":"https://api.github.com/users/JohnRodney/received_events","type":"User","site_admin":false},"body":"**Description:**\r\n  Adds the support for using `a-animation` components in order to animate colors. #733\r\n**Changes proposed:**\r\n-  Adds the detection of a color as an attribute\r\n-  Adds a partialSetAttribute for color\r\n-  Adds a conversion from rgb object to hex (maybe these belong in utils?)\r\n-  Adds two unit tests for start and finish to ensure the color is properly tweened\r\n\r\n…nent","created_at":"2016-03-30T20:20:29Z","updated_at":"2016-03-30T21:42:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"377be0b943ea998aa00036defca2e3638315f918","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aframevr/aframe/pulls/1302/commits","review_comments_url":"https://api.github.com/repos/aframevr/aframe/pulls/1302/comments","review_comment_url":"https://api.github.com/repos/aframevr/aframe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aframevr/aframe/issues/1302/comments","statuses_url":"https://api.github.com/repos/aframevr/aframe/statuses/3987a47255cbb44263553fe473c5fadc4594e087","head":{"label":"JohnRodney:feature/animateColor","ref":"feature/animateColor","sha":"3987a47255cbb44263553fe473c5fadc4594e087","user":{"login":"JohnRodney","id":11075982,"avatar_url":"https://avatars.githubusercontent.com/u/11075982?v=3","gravatar_id":"","url":"https://api.github.com/users/JohnRodney","html_url":"https://github.com/JohnRodney","followers_url":"https://api.github.com/users/JohnRodney/followers","following_url":"https://api.github.com/users/JohnRodney/following{/other_user}","gists_url":"https://api.github.com/users/JohnRodney/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnRodney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnRodney/subscriptions","organizations_url":"https://api.github.com/users/JohnRodney/orgs","repos_url":"https://api.github.com/users/JohnRodney/repos","events_url":"https://api.github.com/users/JohnRodney/events{/privacy}","received_events_url":"https://api.github.com/users/JohnRodney/received_events","type":"User","site_admin":false},"repo":{"id":55091797,"name":"aframe","full_name":"JohnRodney/aframe","owner":{"login":"JohnRodney","id":11075982,"avatar_url":"https://avatars.githubusercontent.com/u/11075982?v=3","gravatar_id":"","url":"https://api.github.com/users/JohnRodney","html_url":"https://github.com/JohnRodney","followers_url":"https://api.github.com/users/JohnRodney/followers","following_url":"https://api.github.com/users/JohnRodney/following{/other_user}","gists_url":"https://api.github.com/users/JohnRodney/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnRodney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnRodney/subscriptions","organizations_url":"https://api.github.com/users/JohnRodney/orgs","repos_url":"https://api.github.com/users/JohnRodney/repos","events_url":"https://api.github.com/users/JohnRodney/events{/privacy}","received_events_url":"https://api.github.com/users/JohnRodney/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JohnRodney/aframe","description":"Building Blocks for the VR Web","fork":true,"url":"https://api.github.com/repos/JohnRodney/aframe","forks_url":"https://api.github.com/repos/JohnRodney/aframe/forks","keys_url":"https://api.github.com/repos/JohnRodney/aframe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JohnRodney/aframe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JohnRodney/aframe/teams","hooks_url":"https://api.github.com/repos/JohnRodney/aframe/hooks","issue_events_url":"https://api.github.com/repos/JohnRodney/aframe/issues/events{/number}","events_url":"https://api.github.com/repos/JohnRodney/aframe/events","assignees_url":"https://api.github.com/repos/JohnRodney/aframe/assignees{/user}","branches_url":"https://api.github.com/repos/JohnRodney/aframe/branches{/branch}","tags_url":"https://api.github.com/repos/JohnRodney/aframe/tags","blobs_url":"https://api.github.com/repos/JohnRodney/aframe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JohnRodney/aframe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JohnRodney/aframe/git/refs{/sha}","trees_url":"https://api.github.com/repos/JohnRodney/aframe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JohnRodney/aframe/statuses/{sha}","languages_url":"https://api.github.com/repos/JohnRodney/aframe/languages","stargazers_url":"https://api.github.com/repos/JohnRodney/aframe/stargazers","contributors_url":"https://api.github.com/repos/JohnRodney/aframe/contributors","subscribers_url":"https://api.github.com/repos/JohnRodney/aframe/subscribers","subscription_url":"https://api.github.com/repos/JohnRodney/aframe/subscription","commits_url":"https://api.github.com/repos/JohnRodney/aframe/commits{/sha}","git_commits_url":"https://api.github.com/repos/JohnRodney/aframe/git/commits{/sha}","comments_url":"https://api.github.com/repos/JohnRodney/aframe/comments{/number}","issue_comment_url":"https://api.github.com/repos/JohnRodney/aframe/issues/comments{/number}","contents_url":"https://api.github.com/repos/JohnRodney/aframe/contents/{+path}","compare_url":"https://api.github.com/repos/JohnRodney/aframe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JohnRodney/aframe/merges","archive_url":"https://api.github.com/repos/JohnRodney/aframe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JohnRodney/aframe/downloads","issues_url":"https://api.github.com/repos/JohnRodney/aframe/issues{/number}","pulls_url":"https://api.github.com/repos/JohnRodney/aframe/pulls{/number}","milestones_url":"https://api.github.com/repos/JohnRodney/aframe/milestones{/number}","notifications_url":"https://api.github.com/repos/JohnRodney/aframe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JohnRodney/aframe/labels{/name}","releases_url":"https://api.github.com/repos/JohnRodney/aframe/releases{/id}","deployments_url":"https://api.github.com/repos/JohnRodney/aframe/deployments","created_at":"2016-03-30T19:35:25Z","updated_at":"2016-03-30T19:35:26Z","pushed_at":"2016-03-30T21:05:06Z","git_url":"git://github.com/JohnRodney/aframe.git","ssh_url":"git@github.com:JohnRodney/aframe.git","clone_url":"https://github.com/JohnRodney/aframe.git","svn_url":"https://github.com/JohnRodney/aframe","homepage":"https://aframe.io/","size":96023,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aframevr:master","ref":"master","sha":"421e1b7dbd6d7af5fbcefc3c4b77eca3ff8ccca8","user":{"login":"aframevr","id":16024092,"avatar_url":"https://avatars.githubusercontent.com/u/16024092?v=3","gravatar_id":"","url":"https://api.github.com/users/aframevr","html_url":"https://github.com/aframevr","followers_url":"https://api.github.com/users/aframevr/followers","following_url":"https://api.github.com/users/aframevr/following{/other_user}","gists_url":"https://api.github.com/users/aframevr/gists{/gist_id}","starred_url":"https://api.github.com/users/aframevr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aframevr/subscriptions","organizations_url":"https://api.github.com/users/aframevr/orgs","repos_url":"https://api.github.com/users/aframevr/repos","events_url":"https://api.github.com/users/aframevr/events{/privacy}","received_events_url":"https://api.github.com/users/aframevr/received_events","type":"Organization","site_admin":false},"repo":{"id":42488903,"name":"aframe","full_name":"aframevr/aframe","owner":{"login":"aframevr","id":16024092,"avatar_url":"https://avatars.githubusercontent.com/u/16024092?v=3","gravatar_id":"","url":"https://api.github.com/users/aframevr","html_url":"https://github.com/aframevr","followers_url":"https://api.github.com/users/aframevr/followers","following_url":"https://api.github.com/users/aframevr/following{/other_user}","gists_url":"https://api.github.com/users/aframevr/gists{/gist_id}","starred_url":"https://api.github.com/users/aframevr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aframevr/subscriptions","organizations_url":"https://api.github.com/users/aframevr/orgs","repos_url":"https://api.github.com/users/aframevr/repos","events_url":"https://api.github.com/users/aframevr/events{/privacy}","received_events_url":"https://api.github.com/users/aframevr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aframevr/aframe","description":"Building Blocks for the VR Web","fork":false,"url":"https://api.github.com/repos/aframevr/aframe","forks_url":"https://api.github.com/repos/aframevr/aframe/forks","keys_url":"https://api.github.com/repos/aframevr/aframe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aframevr/aframe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aframevr/aframe/teams","hooks_url":"https://api.github.com/repos/aframevr/aframe/hooks","issue_events_url":"https://api.github.com/repos/aframevr/aframe/issues/events{/number}","events_url":"https://api.github.com/repos/aframevr/aframe/events","assignees_url":"https://api.github.com/repos/aframevr/aframe/assignees{/user}","branches_url":"https://api.github.com/repos/aframevr/aframe/branches{/branch}","tags_url":"https://api.github.com/repos/aframevr/aframe/tags","blobs_url":"https://api.github.com/repos/aframevr/aframe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aframevr/aframe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aframevr/aframe/git/refs{/sha}","trees_url":"https://api.github.com/repos/aframevr/aframe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aframevr/aframe/statuses/{sha}","languages_url":"https://api.github.com/repos/aframevr/aframe/languages","stargazers_url":"https://api.github.com/repos/aframevr/aframe/stargazers","contributors_url":"https://api.github.com/repos/aframevr/aframe/contributors","subscribers_url":"https://api.github.com/repos/aframevr/aframe/subscribers","subscription_url":"https://api.github.com/repos/aframevr/aframe/subscription","commits_url":"https://api.github.com/repos/aframevr/aframe/commits{/sha}","git_commits_url":"https://api.github.com/repos/aframevr/aframe/git/commits{/sha}","comments_url":"https://api.github.com/repos/aframevr/aframe/comments{/number}","issue_comment_url":"https://api.github.com/repos/aframevr/aframe/issues/comments{/number}","contents_url":"https://api.github.com/repos/aframevr/aframe/contents/{+path}","compare_url":"https://api.github.com/repos/aframevr/aframe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aframevr/aframe/merges","archive_url":"https://api.github.com/repos/aframevr/aframe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aframevr/aframe/downloads","issues_url":"https://api.github.com/repos/aframevr/aframe/issues{/number}","pulls_url":"https://api.github.com/repos/aframevr/aframe/pulls{/number}","milestones_url":"https://api.github.com/repos/aframevr/aframe/milestones{/number}","notifications_url":"https://api.github.com/repos/aframevr/aframe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aframevr/aframe/labels{/name}","releases_url":"https://api.github.com/repos/aframevr/aframe/releases{/id}","deployments_url":"https://api.github.com/repos/aframevr/aframe/deployments","created_at":"2015-09-15T02:04:40Z","updated_at":"2016-03-30T21:02:10Z","pushed_at":"2016-03-30T21:16:06Z","git_url":"git://github.com/aframevr/aframe.git","ssh_url":"git@github.com:aframevr/aframe.git","clone_url":"https://github.com/aframevr/aframe.git","svn_url":"https://github.com/aframevr/aframe","homepage":"https://aframe.io/","size":104134,"stargazers_count":1557,"watchers_count":1557,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":215,"mirror_url":null,"open_issues_count":199,"forks":215,"open_issues":199,"watchers":1557,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/1302"},"html":{"href":"https://github.com/aframevr/aframe/pull/1302"},"issue":{"href":"https://api.github.com/repos/aframevr/aframe/issues/1302"},"comments":{"href":"https://api.github.com/repos/aframevr/aframe/issues/1302/comments"},"review_comments":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/1302/comments"},"review_comment":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/1302/commits"},"statuses":{"href":"https://api.github.com/repos/aframevr/aframe/statuses/3987a47255cbb44263553fe473c5fadc4594e087"}}}}