{"action":"created","issue":{"url":"https://api.github.com/repos/sourcelair/xterm.js/issues/336","repository_url":"https://api.github.com/repos/sourcelair/xterm.js","labels_url":"https://api.github.com/repos/sourcelair/xterm.js/issues/336/labels{/name}","comments_url":"https://api.github.com/repos/sourcelair/xterm.js/issues/336/comments","events_url":"https://api.github.com/repos/sourcelair/xterm.js/issues/336/events","html_url":"https://github.com/sourcelair/xterm.js/pull/336","id":187018923,"number":336,"title":"Stop auto scrolling to bottom on output","user":{"login":"parisk","id":1188592,"avatar_url":"https://avatars.githubusercontent.com/u/1188592?v=3","gravatar_id":"","url":"https://api.github.com/users/parisk","html_url":"https://github.com/parisk","followers_url":"https://api.github.com/users/parisk/followers","following_url":"https://api.github.com/users/parisk/following{/other_user}","gists_url":"https://api.github.com/users/parisk/gists{/gist_id}","starred_url":"https://api.github.com/users/parisk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parisk/subscriptions","organizations_url":"https://api.github.com/users/parisk/orgs","repos_url":"https://api.github.com/users/parisk/repos","events_url":"https://api.github.com/users/parisk/events{/privacy}","received_events_url":"https://api.github.com/users/parisk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/sourcelair/xterm.js/milestones/5","html_url":"https://github.com/sourcelair/xterm.js/milestones/2.1.0","labels_url":"https://api.github.com/repos/sourcelair/xterm.js/milestones/5/labels","id":2044676,"number":5,"title":"2.1.0","description":"","creator":{"login":"parisk","id":1188592,"avatar_url":"https://avatars.githubusercontent.com/u/1188592?v=3","gravatar_id":"","url":"https://api.github.com/users/parisk","html_url":"https://github.com/parisk","followers_url":"https://api.github.com/users/parisk/followers","following_url":"https://api.github.com/users/parisk/following{/other_user}","gists_url":"https://api.github.com/users/parisk/gists{/gist_id}","starred_url":"https://api.github.com/users/parisk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parisk/subscriptions","organizations_url":"https://api.github.com/users/parisk/orgs","repos_url":"https://api.github.com/users/parisk/repos","events_url":"https://api.github.com/users/parisk/events{/privacy}","received_events_url":"https://api.github.com/users/parisk/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":10,"state":"open","created_at":"2016-10-03T16:34:37Z","updated_at":"2016-11-03T10:11:27Z","due_on":"2016-11-07T00:00:00Z","closed_at":null},"comments":0,"created_at":"2016-11-03T10:11:27Z","updated_at":"2016-11-03T17:06:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sourcelair/xterm.js/pulls/336","html_url":"https://github.com/sourcelair/xterm.js/pull/336","diff_url":"https://github.com/sourcelair/xterm.js/pull/336.diff","patch_url":"https://github.com/sourcelair/xterm.js/pull/336.patch"},"body":"This PR is a continuation of #326 by @jupe. I kept all original commits, to maintain the appropriate credits 😊 .\r\n\r\nThis PR introduces this new behavior:\r\n\r\n- When the user has scrolled up the terminal and output is being printed (by the back-end), the terminal now is not scrolling down to bottom, as it used to\r\n- The terminal scrolls down to bottom when the user presses a key\r\n\r\nCloses #216.\r\n\r\n/cc @Tyriar to take a look since you opened the initial issue and commented also in the original PR."},"comment":{"url":"https://api.github.com/repos/sourcelair/xterm.js/issues/comments/258207739","html_url":"https://github.com/sourcelair/xterm.js/pull/336#issuecomment-258207739","issue_url":"https://api.github.com/repos/sourcelair/xterm.js/issues/336","id":258207739,"user":{"login":"Tyriar","id":2193314,"avatar_url":"https://avatars.githubusercontent.com/u/2193314?v=3","gravatar_id":"","url":"https://api.github.com/users/Tyriar","html_url":"https://github.com/Tyriar","followers_url":"https://api.github.com/users/Tyriar/followers","following_url":"https://api.github.com/users/Tyriar/following{/other_user}","gists_url":"https://api.github.com/users/Tyriar/gists{/gist_id}","starred_url":"https://api.github.com/users/Tyriar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tyriar/subscriptions","organizations_url":"https://api.github.com/users/Tyriar/orgs","repos_url":"https://api.github.com/users/Tyriar/repos","events_url":"https://api.github.com/users/Tyriar/events{/privacy}","received_events_url":"https://api.github.com/users/Tyriar/received_events","type":"User","site_admin":false},"created_at":"2016-11-03T17:06:47Z","updated_at":"2016-11-03T17:06:47Z","body":"Would it be easy to write some unit tests for this? For example:\r\n\r\n- Key down always scrolls to bottom of buffer\r\n- Write scrolls down to bottom of buffer when it's already at the bottom\r\n- Write does not scroll down to bottom of buffer when not at the bottom"}}
{"actor":{"display_login":"Tyriar"}}