{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/comments/81677533","pull_request_review_id":2640162,"id":81677533,"diff_hunk":"@@ -159,3 +161,55 @@ def get_changed_packages(blob_name1, blob_name2, package_list):\n             result.add(file_root)\n \n     return sorted(result)\n+\n+\n+def get_files_for_linting(allow_limited=True):\n+    \"\"\"Gets a list of files in the repository.\n+\n+    By default, returns all files via ``git ls-files``. However, in some cases\n+    uses a specific commit or branch (a so-called diff base) to compare\n+    against for changed files. (This requires ``allow_limited=True``.)\n+\n+    To speed up linting on Travis pull requests against master, we manually\n+    set the diff base to the branch the pull request is against. We don't do\n+    this on \"push\" builds since \"master\" will be the currently checked out\n+    code. One could potentially use ${TRAVIS_COMMIT_RANGE} to find a diff base\n+    but this value is not dependable.\n+\n+    To allow faster local ``tox`` runs, the local remote and local branch\n+    environment variables can be set to specify a remote branch to diff\n+    against.\n+\n+    :type allow_limited: bool\n+    :param allow_limited: Boolean indicating if a reduced set of files can\n+                          be used.\n+\n+    :rtype: pair\n+    :returns: Tuple of the diff base using the the list of filenames to be","path":"scripts/script_utils.py","position":37,"original_position":37,"commit_id":"8c8a50b163e7f174103d557345199e7d8023225c","original_commit_id":"8c8a50b163e7f174103d557345199e7d8023225c","user":{"login":"dhermes","id":520669,"avatar_url":"https://avatars.githubusercontent.com/u/520669?v=3","gravatar_id":"","url":"https://api.github.com/users/dhermes","html_url":"https://github.com/dhermes","followers_url":"https://api.github.com/users/dhermes/followers","following_url":"https://api.github.com/users/dhermes/following{/other_user}","gists_url":"https://api.github.com/users/dhermes/gists{/gist_id}","starred_url":"https://api.github.com/users/dhermes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhermes/subscriptions","organizations_url":"https://api.github.com/users/dhermes/orgs","repos_url":"https://api.github.com/users/dhermes/repos","events_url":"https://api.github.com/users/dhermes/events{/privacy}","received_events_url":"https://api.github.com/users/dhermes/received_events","type":"User","site_admin":false},"body":"Just noticed \"the the\" in this docstring. Take this opportunity to fix it? (Almost certainly I am the owner of the original typo.)","created_at":"2016-10-04T02:23:55Z","updated_at":"2016-10-04T02:23:55Z","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/2486#discussion_r81677533","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/2486","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/comments/81677533"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/2486#discussion_r81677533"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/2486"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/2486","id":87796723,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/2486","diff_url":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/2486.diff","patch_url":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/2486.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/2486","number":2486,"state":"open","locked":false,"title":"Use 'diff_base' for pycodestyle check, if set.","user":{"login":"tseaver","id":242750,"avatar_url":"https://avatars.githubusercontent.com/u/242750?v=3","gravatar_id":"","url":"https://api.github.com/users/tseaver","html_url":"https://github.com/tseaver","followers_url":"https://api.github.com/users/tseaver/followers","following_url":"https://api.github.com/users/tseaver/following{/other_user}","gists_url":"https://api.github.com/users/tseaver/gists{/gist_id}","starred_url":"https://api.github.com/users/tseaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tseaver/subscriptions","organizations_url":"https://api.github.com/users/tseaver/orgs","repos_url":"https://api.github.com/users/tseaver/repos","events_url":"https://api.github.com/users/tseaver/events{/privacy}","received_events_url":"https://api.github.com/users/tseaver/received_events","type":"User","site_admin":false},"body":"Speeds it up, plus reduces spew when testing locally.","created_at":"2016-10-03T21:37:48Z","updated_at":"2016-10-04T02:23:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df5c1311cc96b17673a5d223b3a231e4c4b2d41c","assignee":{"login":"daspecster","id":192456,"avatar_url":"https://avatars.githubusercontent.com/u/192456?v=3","gravatar_id":"","url":"https://api.github.com/users/daspecster","html_url":"https://github.com/daspecster","followers_url":"https://api.github.com/users/daspecster/followers","following_url":"https://api.github.com/users/daspecster/following{/other_user}","gists_url":"https://api.github.com/users/daspecster/gists{/gist_id}","starred_url":"https://api.github.com/users/daspecster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daspecster/subscriptions","organizations_url":"https://api.github.com/users/daspecster/orgs","repos_url":"https://api.github.com/users/daspecster/repos","events_url":"https://api.github.com/users/daspecster/events{/privacy}","received_events_url":"https://api.github.com/users/daspecster/received_events","type":"User","site_admin":false},"assignees":[{"login":"daspecster","id":192456,"avatar_url":"https://avatars.githubusercontent.com/u/192456?v=3","gravatar_id":"","url":"https://api.github.com/users/daspecster","html_url":"https://github.com/daspecster","followers_url":"https://api.github.com/users/daspecster/followers","following_url":"https://api.github.com/users/daspecster/following{/other_user}","gists_url":"https://api.github.com/users/daspecster/gists{/gist_id}","starred_url":"https://api.github.com/users/daspecster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daspecster/subscriptions","organizations_url":"https://api.github.com/users/daspecster/orgs","repos_url":"https://api.github.com/users/daspecster/repos","events_url":"https://api.github.com/users/daspecster/events{/privacy}","received_events_url":"https://api.github.com/users/daspecster/received_events","type":"User","site_admin":false},{"login":"dhermes","id":520669,"avatar_url":"https://avatars.githubusercontent.com/u/520669?v=3","gravatar_id":"","url":"https://api.github.com/users/dhermes","html_url":"https://github.com/dhermes","followers_url":"https://api.github.com/users/dhermes/followers","following_url":"https://api.github.com/users/dhermes/following{/other_user}","gists_url":"https://api.github.com/users/dhermes/gists{/gist_id}","starred_url":"https://api.github.com/users/dhermes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhermes/subscriptions","organizations_url":"https://api.github.com/users/dhermes/orgs","repos_url":"https://api.github.com/users/dhermes/repos","events_url":"https://api.github.com/users/dhermes/events{/privacy}","received_events_url":"https://api.github.com/users/dhermes/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/2486/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/2486/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/2486/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/statuses/8c8a50b163e7f174103d557345199e7d8023225c","head":{"label":"tseaver:pycodestyle-use_diff_base","ref":"pycodestyle-use_diff_base","sha":"8c8a50b163e7f174103d557345199e7d8023225c","user":{"login":"tseaver","id":242750,"avatar_url":"https://avatars.githubusercontent.com/u/242750?v=3","gravatar_id":"","url":"https://api.github.com/users/tseaver","html_url":"https://github.com/tseaver","followers_url":"https://api.github.com/users/tseaver/followers","following_url":"https://api.github.com/users/tseaver/following{/other_user}","gists_url":"https://api.github.com/users/tseaver/gists{/gist_id}","starred_url":"https://api.github.com/users/tseaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tseaver/subscriptions","organizations_url":"https://api.github.com/users/tseaver/orgs","repos_url":"https://api.github.com/users/tseaver/repos","events_url":"https://api.github.com/users/tseaver/events{/privacy}","received_events_url":"https://api.github.com/users/tseaver/received_events","type":"User","site_admin":false},"repo":{"id":23322104,"name":"google-cloud-python","full_name":"tseaver/google-cloud-python","owner":{"login":"tseaver","id":242750,"avatar_url":"https://avatars.githubusercontent.com/u/242750?v=3","gravatar_id":"","url":"https://api.github.com/users/tseaver","html_url":"https://github.com/tseaver","followers_url":"https://api.github.com/users/tseaver/followers","following_url":"https://api.github.com/users/tseaver/following{/other_user}","gists_url":"https://api.github.com/users/tseaver/gists{/gist_id}","starred_url":"https://api.github.com/users/tseaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tseaver/subscriptions","organizations_url":"https://api.github.com/users/tseaver/orgs","repos_url":"https://api.github.com/users/tseaver/repos","events_url":"https://api.github.com/users/tseaver/events{/privacy}","received_events_url":"https://api.github.com/users/tseaver/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tseaver/google-cloud-python","description":"Google Cloud Python Client Library","fork":true,"url":"https://api.github.com/repos/tseaver/google-cloud-python","forks_url":"https://api.github.com/repos/tseaver/google-cloud-python/forks","keys_url":"https://api.github.com/repos/tseaver/google-cloud-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tseaver/google-cloud-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tseaver/google-cloud-python/teams","hooks_url":"https://api.github.com/repos/tseaver/google-cloud-python/hooks","issue_events_url":"https://api.github.com/repos/tseaver/google-cloud-python/issues/events{/number}","events_url":"https://api.github.com/repos/tseaver/google-cloud-python/events","assignees_url":"https://api.github.com/repos/tseaver/google-cloud-python/assignees{/user}","branches_url":"https://api.github.com/repos/tseaver/google-cloud-python/branches{/branch}","tags_url":"https://api.github.com/repos/tseaver/google-cloud-python/tags","blobs_url":"https://api.github.com/repos/tseaver/google-cloud-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tseaver/google-cloud-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tseaver/google-cloud-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/tseaver/google-cloud-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tseaver/google-cloud-python/statuses/{sha}","languages_url":"https://api.github.com/repos/tseaver/google-cloud-python/languages","stargazers_url":"https://api.github.com/repos/tseaver/google-cloud-python/stargazers","contributors_url":"https://api.github.com/repos/tseaver/google-cloud-python/contributors","subscribers_url":"https://api.github.com/repos/tseaver/google-cloud-python/subscribers","subscription_url":"https://api.github.com/repos/tseaver/google-cloud-python/subscription","commits_url":"https://api.github.com/repos/tseaver/google-cloud-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/tseaver/google-cloud-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/tseaver/google-cloud-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/tseaver/google-cloud-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/tseaver/google-cloud-python/contents/{+path}","compare_url":"https://api.github.com/repos/tseaver/google-cloud-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tseaver/google-cloud-python/merges","archive_url":"https://api.github.com/repos/tseaver/google-cloud-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tseaver/google-cloud-python/downloads","issues_url":"https://api.github.com/repos/tseaver/google-cloud-python/issues{/number}","pulls_url":"https://api.github.com/repos/tseaver/google-cloud-python/pulls{/number}","milestones_url":"https://api.github.com/repos/tseaver/google-cloud-python/milestones{/number}","notifications_url":"https://api.github.com/repos/tseaver/google-cloud-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tseaver/google-cloud-python/labels{/name}","releases_url":"https://api.github.com/repos/tseaver/google-cloud-python/releases{/id}","deployments_url":"https://api.github.com/repos/tseaver/google-cloud-python/deployments","created_at":"2014-08-25T17:19:33Z","updated_at":"2016-09-07T17:35:47Z","pushed_at":"2016-10-04T01:33:50Z","git_url":"git://github.com/tseaver/google-cloud-python.git","ssh_url":"git@github.com:tseaver/google-cloud-python.git","clone_url":"https://github.com/tseaver/google-cloud-python.git","svn_url":"https://github.com/tseaver/google-cloud-python","homepage":"http://googlecloudplatform.github.io/gcloud-python/","size":12298,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"72291ea6105e8a53761e03abd15bda5bd8c53ee5","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":16316451,"name":"google-cloud-python","full_name":"GoogleCloudPlatform/google-cloud-python","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-python","description":"Google Cloud Client Library for Python","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/deployments","created_at":"2014-01-28T15:51:47Z","updated_at":"2016-10-03T18:55:25Z","pushed_at":"2016-10-04T01:58:18Z","git_url":"git://github.com/GoogleCloudPlatform/google-cloud-python.git","ssh_url":"git@github.com:GoogleCloudPlatform/google-cloud-python.git","clone_url":"https://github.com/GoogleCloudPlatform/google-cloud-python.git","svn_url":"https://github.com/GoogleCloudPlatform/google-cloud-python","homepage":"https://googlecloudplatform.github.io/google-cloud-python/","size":92850,"stargazers_count":407,"watchers_count":407,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":207,"mirror_url":null,"open_issues_count":208,"forks":207,"open_issues":208,"watchers":407,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/2486"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/2486"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/2486"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/2486/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/2486/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/2486/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/statuses/8c8a50b163e7f174103d557345199e7d8023225c"}}}}
{"actor":{"display_login":"dhermes"}}