{"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/55942570","id":55942570,"diff_hunk":"@@ -1236,17 +1236,28 @@ int CRenderManager::AddVideoPicture(DVDVideoPicture& pic)\n   if (!m_pRenderer)\n     return -1;\n \n-  // TODO: this is a Windows onl thing and should go away\n-  if(m_pRenderer->AddVideoPicture(&pic, index))\n-    return 1;\n-\n   YV12Image image;\n   if (m_pRenderer->GetImage(&image, index) < 0)\n     return -1;\n \n-  if(pic.format == RENDER_FMT_YUV420P\n-  || pic.format == RENDER_FMT_YUV420P10\n-  || pic.format == RENDER_FMT_YUV420P16)\n+  if(pic.format == RENDER_FMT_VDPAU\n+  || pic.format == RENDER_FMT_VDPAU_420\n+  || pic.format == RENDER_FMT_OMXEGL\n+  || pic.format == RENDER_FMT_CVBREF\n+  || pic.format == RENDER_FMT_VAAPI\n+  || pic.format == RENDER_FMT_VAAPINV12\n+  || pic.format == RENDER_FMT_MEDIACODEC\n+  || pic.format == RENDER_FMT_MEDIACODECSURFACE\n+  || pic.format == RENDER_FMT_AML\n+  || pic.format == RENDER_FMT_IMXMAP\n+  || pic.format == RENDER_FMT_MMAL\n+  || m_pRenderer->IsPictureHW(pic))","path":"xbmc/cores/VideoPlayer/VideoRenderers/RenderManager.cpp","position":26,"original_position":26,"commit_id":"c15b557acab305f431db21065bd4613081ee589e","original_commit_id":"c15b557acab305f431db21065bd4613081ee589e","user":{"login":"FernetMenta","id":576009,"avatar_url":"https://avatars.githubusercontent.com/u/576009?v=3","gravatar_id":"","url":"https://api.github.com/users/FernetMenta","html_url":"https://github.com/FernetMenta","followers_url":"https://api.github.com/users/FernetMenta/followers","following_url":"https://api.github.com/users/FernetMenta/following{/other_user}","gists_url":"https://api.github.com/users/FernetMenta/gists{/gist_id}","starred_url":"https://api.github.com/users/FernetMenta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FernetMenta/subscriptions","organizations_url":"https://api.github.com/users/FernetMenta/orgs","repos_url":"https://api.github.com/users/FernetMenta/repos","events_url":"https://api.github.com/users/FernetMenta/events{/privacy}","received_events_url":"https://api.github.com/users/FernetMenta/received_events","type":"User","site_admin":false},"body":"Actually it is the other way round. IsPictureHW is misleading. This mode is hijacked to copy a non hw pic into a hw surface.","created_at":"2016-03-13T19:46:59Z","updated_at":"2016-03-13T19:46:59Z","html_url":"https://github.com/xbmc/xbmc/pull/9337#discussion_r55942570","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/9337","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/55942570"},"html":{"href":"https://github.com/xbmc/xbmc/pull/9337#discussion_r55942570"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/9337"}}},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/9337","id":62653791,"html_url":"https://github.com/xbmc/xbmc/pull/9337","diff_url":"https://github.com/xbmc/xbmc/pull/9337.diff","patch_url":"https://github.com/xbmc/xbmc/pull/9337.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/9337","number":9337,"state":"closed","locked":false,"title":"[WinRenderer] Re-factor renderer to make it more similar to others. T…","user":{"login":"afedchin","id":2063885,"avatar_url":"https://avatars.githubusercontent.com/u/2063885?v=3","gravatar_id":"","url":"https://api.github.com/users/afedchin","html_url":"https://github.com/afedchin","followers_url":"https://api.github.com/users/afedchin/followers","following_url":"https://api.github.com/users/afedchin/following{/other_user}","gists_url":"https://api.github.com/users/afedchin/gists{/gist_id}","starred_url":"https://api.github.com/users/afedchin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afedchin/subscriptions","organizations_url":"https://api.github.com/users/afedchin/orgs","repos_url":"https://api.github.com/users/afedchin/repos","events_url":"https://api.github.com/users/afedchin/events{/privacy}","received_events_url":"https://api.github.com/users/afedchin/received_events","type":"User","site_admin":false},"body":"…his should make WinRenderer more stable.\r\n\r\n@FernetMenta ping.","created_at":"2016-03-12T22:04:32Z","updated_at":"2016-03-13T19:46:59Z","closed_at":"2016-03-13T12:43:00Z","merged_at":"2016-03-13T12:43:00Z","merge_commit_sha":"cd5b2cd6d055f68b0293e99d98e8a44e119171f4","assignee":null,"milestone":{"url":"https://api.github.com/repos/xbmc/xbmc/milestones/74","html_url":"https://github.com/xbmc/xbmc/milestones/Krypton%2017.0-alpha1","labels_url":"https://api.github.com/repos/xbmc/xbmc/milestones/74/labels","id":1444499,"number":74,"title":"Krypton 17.0-alpha1","description":"","creator":{"login":"MartijnKaijser","id":907436,"avatar_url":"https://avatars.githubusercontent.com/u/907436?v=3","gravatar_id":"","url":"https://api.github.com/users/MartijnKaijser","html_url":"https://github.com/MartijnKaijser","followers_url":"https://api.github.com/users/MartijnKaijser/followers","following_url":"https://api.github.com/users/MartijnKaijser/following{/other_user}","gists_url":"https://api.github.com/users/MartijnKaijser/gists{/gist_id}","starred_url":"https://api.github.com/users/MartijnKaijser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartijnKaijser/subscriptions","organizations_url":"https://api.github.com/users/MartijnKaijser/orgs","repos_url":"https://api.github.com/users/MartijnKaijser/repos","events_url":"https://api.github.com/users/MartijnKaijser/events{/privacy}","received_events_url":"https://api.github.com/users/MartijnKaijser/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":575,"state":"open","created_at":"2015-12-04T16:31:06Z","updated_at":"2016-03-13T13:55:29Z","due_on":"2016-03-30T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/9337/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/9337/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/9337/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/c15b557acab305f431db21065bd4613081ee589e","head":{"label":"afedchin:winrenderer","ref":"winrenderer","sha":"c15b557acab305f431db21065bd4613081ee589e","user":{"login":"afedchin","id":2063885,"avatar_url":"https://avatars.githubusercontent.com/u/2063885?v=3","gravatar_id":"","url":"https://api.github.com/users/afedchin","html_url":"https://github.com/afedchin","followers_url":"https://api.github.com/users/afedchin/followers","following_url":"https://api.github.com/users/afedchin/following{/other_user}","gists_url":"https://api.github.com/users/afedchin/gists{/gist_id}","starred_url":"https://api.github.com/users/afedchin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afedchin/subscriptions","organizations_url":"https://api.github.com/users/afedchin/orgs","repos_url":"https://api.github.com/users/afedchin/repos","events_url":"https://api.github.com/users/afedchin/events{/privacy}","received_events_url":"https://api.github.com/users/afedchin/received_events","type":"User","site_admin":false},"repo":{"id":8306898,"name":"xbmc","full_name":"afedchin/xbmc","owner":{"login":"afedchin","id":2063885,"avatar_url":"https://avatars.githubusercontent.com/u/2063885?v=3","gravatar_id":"","url":"https://api.github.com/users/afedchin","html_url":"https://github.com/afedchin","followers_url":"https://api.github.com/users/afedchin/followers","following_url":"https://api.github.com/users/afedchin/following{/other_user}","gists_url":"https://api.github.com/users/afedchin/gists{/gist_id}","starred_url":"https://api.github.com/users/afedchin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afedchin/subscriptions","organizations_url":"https://api.github.com/users/afedchin/orgs","repos_url":"https://api.github.com/users/afedchin/repos","events_url":"https://api.github.com/users/afedchin/events{/privacy}","received_events_url":"https://api.github.com/users/afedchin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/afedchin/xbmc","description":"XBMC Main Repository","fork":true,"url":"https://api.github.com/repos/afedchin/xbmc","forks_url":"https://api.github.com/repos/afedchin/xbmc/forks","keys_url":"https://api.github.com/repos/afedchin/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/afedchin/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/afedchin/xbmc/teams","hooks_url":"https://api.github.com/repos/afedchin/xbmc/hooks","issue_events_url":"https://api.github.com/repos/afedchin/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/afedchin/xbmc/events","assignees_url":"https://api.github.com/repos/afedchin/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/afedchin/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/afedchin/xbmc/tags","blobs_url":"https://api.github.com/repos/afedchin/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/afedchin/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/afedchin/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/afedchin/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/afedchin/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/afedchin/xbmc/languages","stargazers_url":"https://api.github.com/repos/afedchin/xbmc/stargazers","contributors_url":"https://api.github.com/repos/afedchin/xbmc/contributors","subscribers_url":"https://api.github.com/repos/afedchin/xbmc/subscribers","subscription_url":"https://api.github.com/repos/afedchin/xbmc/subscription","commits_url":"https://api.github.com/repos/afedchin/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/afedchin/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/afedchin/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/afedchin/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/afedchin/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/afedchin/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/afedchin/xbmc/merges","archive_url":"https://api.github.com/repos/afedchin/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/afedchin/xbmc/downloads","issues_url":"https://api.github.com/repos/afedchin/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/afedchin/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/afedchin/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/afedchin/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/afedchin/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/afedchin/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/afedchin/xbmc/deployments","created_at":"2013-02-20T05:37:45Z","updated_at":"2015-06-20T14:40:05Z","pushed_at":"2016-03-13T15:26:22Z","git_url":"git://github.com/afedchin/xbmc.git","ssh_url":"git@github.com:afedchin/xbmc.git","clone_url":"https://github.com/afedchin/xbmc.git","svn_url":"https://github.com/afedchin/xbmc","homepage":"http://xbmc.org","size":558566,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":0,"forks":6,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"956acd1b6b266126c5c3530363f31e0d93f8636c","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/xbmc/xbmc/deployments","created_at":"2011-01-03T21:18:51Z","updated_at":"2016-03-13T18:16:49Z","pushed_at":"2016-03-13T19:44:23Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1732358,"stargazers_count":4590,"watchers_count":4590,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3378,"mirror_url":null,"open_issues_count":224,"forks":3378,"open_issues":224,"watchers":4590,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/9337"},"html":{"href":"https://github.com/xbmc/xbmc/pull/9337"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/9337"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/9337/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/9337/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/9337/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/c15b557acab305f431db21065bd4613081ee589e"}}}}