{"action":"created","issue":{"url":"https://api.github.com/repos/crossfilter/crossfilter/issues/61","repository_url":"https://api.github.com/repos/crossfilter/crossfilter","labels_url":"https://api.github.com/repos/crossfilter/crossfilter/issues/61/labels{/name}","comments_url":"https://api.github.com/repos/crossfilter/crossfilter/issues/61/comments","events_url":"https://api.github.com/repos/crossfilter/crossfilter/issues/61/events","html_url":"https://github.com/crossfilter/crossfilter/issues/61","id":170771211,"number":61,"title":"\"Maximum call stack size exceeded\", on dimension operation of large json file","user":{"login":"keyscores","id":1364012,"avatar_url":"https://avatars.githubusercontent.com/u/1364012?v=3","gravatar_id":"","url":"https://api.github.com/users/keyscores","html_url":"https://github.com/keyscores","followers_url":"https://api.github.com/users/keyscores/followers","following_url":"https://api.github.com/users/keyscores/following{/other_user}","gists_url":"https://api.github.com/users/keyscores/gists{/gist_id}","starred_url":"https://api.github.com/users/keyscores/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keyscores/subscriptions","organizations_url":"https://api.github.com/users/keyscores/orgs","repos_url":"https://api.github.com/users/keyscores/repos","events_url":"https://api.github.com/users/keyscores/events{/privacy}","received_events_url":"https://api.github.com/users/keyscores/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-08-11T23:36:21Z","updated_at":"2016-08-12T13:12:36Z","closed_at":"2016-08-12T02:40:55Z","body":"I have an 8Mb JSON file, approximately 27K rows. The rows are not always uniform. Some rows might lack a dimension, or that dimension may be 'undefined' or NaN. \r\n\r\nThe very first operation makes the script fail. It's a simple dimension assignment:\r\n`var dimension = cf.dimension(function(fact) { return fact.title ; });\r\n`\r\nI would assume the iterator function 'return fact.title' would already account for undefined types, and exclude. \r\n\r\nIs this a bug, or is there a step I'm missing?\r\n\r\nI see a similar issue in the square/crossfilter repo: https://github.com/square/crossfilter/issues/27"},"comment":{"url":"https://api.github.com/repos/crossfilter/crossfilter/issues/comments/239442249","html_url":"https://github.com/crossfilter/crossfilter/issues/61#issuecomment-239442249","issue_url":"https://api.github.com/repos/crossfilter/crossfilter/issues/61","id":239442249,"user":{"login":"esjewett","id":4822,"avatar_url":"https://avatars.githubusercontent.com/u/4822?v=3","gravatar_id":"","url":"https://api.github.com/users/esjewett","html_url":"https://github.com/esjewett","followers_url":"https://api.github.com/users/esjewett/followers","following_url":"https://api.github.com/users/esjewett/following{/other_user}","gists_url":"https://api.github.com/users/esjewett/gists{/gist_id}","starred_url":"https://api.github.com/users/esjewett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esjewett/subscriptions","organizations_url":"https://api.github.com/users/esjewett/orgs","repos_url":"https://api.github.com/users/esjewett/repos","events_url":"https://api.github.com/users/esjewett/events{/privacy}","received_events_url":"https://api.github.com/users/esjewett/received_events","type":"User","site_admin":false},"created_at":"2016-08-12T13:12:36Z","updated_at":"2016-08-12T13:12:36Z","body":"I agree with @gordonwoodhull's comments.\r\n\r\nOne thing we possibly could do is put some heuristic checks in to the dimension accessor setter. For example, we could check the accessor function that the user provides against a variety of values and make sure that the values that come out are always naturally-ordered. If they are not, then we could put a warning on the console. I'm not really a fan of this idea, but it could be workable. Food for thought."}}
{"actor":{"display_login":"esjewett"}}