{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/12391","repository_url":"https://api.github.com/repos/servo/servo","labels_url":"https://api.github.com/repos/servo/servo/issues/12391/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/12391/comments","events_url":"https://api.github.com/repos/servo/servo/issues/12391/events","html_url":"https://github.com/servo/servo/pull/12391","id":164916134,"number":12391,"title":"Move to cargo workspaces and single toplevel Cargo.lock","user":{"login":"larsbergstrom","id":475847,"avatar_url":"https://avatars.githubusercontent.com/u/475847?v=3","gravatar_id":"","url":"https://api.github.com/users/larsbergstrom","html_url":"https://github.com/larsbergstrom","followers_url":"https://api.github.com/users/larsbergstrom/followers","following_url":"https://api.github.com/users/larsbergstrom/following{/other_user}","gists_url":"https://api.github.com/users/larsbergstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/larsbergstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsbergstrom/subscriptions","organizations_url":"https://api.github.com/users/larsbergstrom/orgs","repos_url":"https://api.github.com/users/larsbergstrom/repos","events_url":"https://api.github.com/users/larsbergstrom/events{/privacy}","received_events_url":"https://api.github.com/users/larsbergstrom/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-review","name":"S-awaiting-review","color":"d4c5f9"},{"url":"https://api.github.com/repos/servo/servo/labels/S-needs-rebase","name":"S-needs-rebase","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"SimonSapin","id":291359,"avatar_url":"https://avatars.githubusercontent.com/u/291359?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonSapin","html_url":"https://github.com/SimonSapin","followers_url":"https://api.github.com/users/SimonSapin/followers","following_url":"https://api.github.com/users/SimonSapin/following{/other_user}","gists_url":"https://api.github.com/users/SimonSapin/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonSapin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonSapin/subscriptions","organizations_url":"https://api.github.com/users/SimonSapin/orgs","repos_url":"https://api.github.com/users/SimonSapin/repos","events_url":"https://api.github.com/users/SimonSapin/events{/privacy}","received_events_url":"https://api.github.com/users/SimonSapin/received_events","type":"User","site_admin":false},"assignees":[{"login":"SimonSapin","id":291359,"avatar_url":"https://avatars.githubusercontent.com/u/291359?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonSapin","html_url":"https://github.com/SimonSapin","followers_url":"https://api.github.com/users/SimonSapin/followers","following_url":"https://api.github.com/users/SimonSapin/following{/other_user}","gists_url":"https://api.github.com/users/SimonSapin/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonSapin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonSapin/subscriptions","organizations_url":"https://api.github.com/users/SimonSapin/orgs","repos_url":"https://api.github.com/users/SimonSapin/repos","events_url":"https://api.github.com/users/SimonSapin/events{/privacy}","received_events_url":"https://api.github.com/users/SimonSapin/received_events","type":"User","site_admin":false}],"milestone":null,"comments":25,"created_at":"2016-07-11T19:34:26Z","updated_at":"2016-08-19T15:47:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/12391","html_url":"https://github.com/servo/servo/pull/12391","diff_url":"https://github.com/servo/servo/pull/12391.diff","patch_url":"https://github.com/servo/servo/pull/12391.patch"},"body":"This seems to work except for a couple of things I'd like feedback from @alexcrichton on:\r\n1) ports/geckolib/Cargo.toml has a `[replace]` block, but that seems to be getting ignored when being built as part of a workspace. You can repro by doing `./mach build-geckolib` from the root - you'll get:\r\n```\r\n[larsberg@larsberg servo]$ ./mach build-geckolib\r\n   Compiling string_cache v0.2.20\r\n/Users/larsberg/servo/.cargo/registry/src/github.com-1ecc6299db9ec823/string_cache-0.2.20/src/lib.rs:15:35: 15:64 error: #[feature] may not be used on the stable release channel\r\n/Users/larsberg/servo/.cargo/registry/src/github.com-1ecc6299db9ec823/string_cache-0.2.20/src/lib.rs:15 #![cfg_attr(feature = \"unstable\", feature(unsafe_no_drop_flag))]\r\n                                                                                                                                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~\r\nerror: aborting due to previous error\r\nerror: Could not compile `string_cache`.\r\n\r\nTo learn more, run the command again with --verbose.\r\nGeckoLib build completed in 0:00:01\r\n[larsberg@larsberg servo]$ \r\n```\r\n\r\n2) Is the right way to perform a `cargo update` still to go to each of the workspaces and perform the update there? That seems to be the only way that works - we get an error if we do it at toplevel.\r\n\r\n3) Minor: the `[root]` name is `webdriver_server`, which seems... really weird.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/12391)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/241055466","html_url":"https://github.com/servo/servo/pull/12391#issuecomment-241055466","issue_url":"https://api.github.com/repos/servo/servo/issues/12391","id":241055466,"user":{"login":"SimonSapin","id":291359,"avatar_url":"https://avatars.githubusercontent.com/u/291359?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonSapin","html_url":"https://github.com/SimonSapin","followers_url":"https://api.github.com/users/SimonSapin/followers","following_url":"https://api.github.com/users/SimonSapin/following{/other_user}","gists_url":"https://api.github.com/users/SimonSapin/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonSapin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonSapin/subscriptions","organizations_url":"https://api.github.com/users/SimonSapin/orgs","repos_url":"https://api.github.com/users/SimonSapin/repos","events_url":"https://api.github.com/users/SimonSapin/events{/privacy}","received_events_url":"https://api.github.com/users/SimonSapin/received_events","type":"User","site_admin":false},"created_at":"2016-08-19T15:47:39Z","updated_at":"2016-08-19T15:47:39Z","body":"r=me with a rebase"}}
{"actor":{"display_login":"SimonSapin"}}