{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/83060899","pull_request_review_id":3926272,"id":83060899,"diff_hunk":"@@ -86,7 +93,13 @@ case class StateStoreSaveExec(\n     child: SparkPlan)\n   extends execution.UnaryExecNode with StatefulOperator {\n \n+  override lazy val metrics = Map(","path":"sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulAggregate.scala","position":12,"original_position":33,"commit_id":"4c08d569f7817e222550ef7578c6e01f90bc4ee0","original_commit_id":"4c08d569f7817e222550ef7578c6e01f90bc4ee0","user":{"login":"marmbrus","id":527,"avatar_url":"https://avatars.githubusercontent.com/u/527?v=3","gravatar_id":"","url":"https://api.github.com/users/marmbrus","html_url":"https://github.com/marmbrus","followers_url":"https://api.github.com/users/marmbrus/followers","following_url":"https://api.github.com/users/marmbrus/following{/other_user}","gists_url":"https://api.github.com/users/marmbrus/gists{/gist_id}","starred_url":"https://api.github.com/users/marmbrus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marmbrus/subscriptions","organizations_url":"https://api.github.com/users/marmbrus/orgs","repos_url":"https://api.github.com/users/marmbrus/repos","events_url":"https://api.github.com/users/marmbrus/events{/privacy}","received_events_url":"https://api.github.com/users/marmbrus/received_events","type":"User","site_admin":false},"body":"Why is this lazy?","created_at":"2016-10-12T17:50:00Z","updated_at":"2016-10-12T17:50:00Z","html_url":"https://github.com/apache/spark/pull/15307#discussion_r83060899","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/15307","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/83060899"},"html":{"href":"https://github.com/apache/spark/pull/15307#discussion_r83060899"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/15307"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/15307","id":87429572,"html_url":"https://github.com/apache/spark/pull/15307","diff_url":"https://github.com/apache/spark/pull/15307.diff","patch_url":"https://github.com/apache/spark/pull/15307.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/15307","number":15307,"state":"open","locked":false,"title":"[SPARK-17731][SQL][STREAMING] Metrics for structured streaming","user":{"login":"tdas","id":663212,"avatar_url":"https://avatars.githubusercontent.com/u/663212?v=3","gravatar_id":"","url":"https://api.github.com/users/tdas","html_url":"https://github.com/tdas","followers_url":"https://api.github.com/users/tdas/followers","following_url":"https://api.github.com/users/tdas/following{/other_user}","gists_url":"https://api.github.com/users/tdas/gists{/gist_id}","starred_url":"https://api.github.com/users/tdas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdas/subscriptions","organizations_url":"https://api.github.com/users/tdas/orgs","repos_url":"https://api.github.com/users/tdas/repos","events_url":"https://api.github.com/users/tdas/events{/privacy}","received_events_url":"https://api.github.com/users/tdas/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nMetrics are needed for monitoring structured streaming apps. Here is the design doc for implementing the necessary metrics.\r\nhttps://docs.google.com/document/d/1NIdcGuR1B3WIe8t7VxLrt58TJB4DtipWEbj5I_mzJys/edit?usp=sharing\r\n\r\nSpecifically, this PR adds the following public APIs changes.\r\n\r\n### New APIs\r\n- `StreamingQuery.status` returns a `StreamingQueryStatus` object (renamed from `StreamingQueryInfo`, see later)\r\n\r\n- `StreamingQueryStatus` has the following important fields\r\n  - inputRate - Current rate (rows/sec) at which data is being generated by all the sources\r\n  - processingRate - Current rate (rows/sec) at which the query is processing data from\r\n                                  all the sources\r\n  - ~~outputRate~~ - *Does not work with wholestage codegen*\r\n  - latency - Current average latency between the data being available in source and the sink writing the corresponding output \r\n  - sourceStatuses: Array[SourceStatus] - Current statuses of the sources\r\n  - sinkStatus: SinkStatus - Current status of the sink\r\n  - triggerStatus - Low-level detailed status of the last completed/currently active trigger\r\n    - latencies - getOffset, getBatch, full trigger, wal writes\r\n    - timestamps - trigger start, finish, after getOffset, after getBatch\r\n    - numRows - input, output, state total/updated rows for aggregations\r\n\r\n- `SourceStatus` has the following important fields\r\n  - inputRate - Current rate (rows/sec) at which data is being generated by the source\r\n  - processingRate - Current rate (rows/sec) at which the query is processing data from the source\r\n  - triggerStatus - Low-level detailed status of the last completed/currently active trigger\r\n\r\n- Python API for `StreamingQuery.status()`\r\n\r\n### Breaking changes to existing APIs\r\n**Existing direct public facing APIs**\r\n- Deprecated direct public-facing APIs `StreamingQuery.sourceStatuses` and `StreamingQuery.sinkStatus` in favour of `StreamingQuery.status.sourceStatuses/sinkStatus`. \r\n  - Branch 2.0 should have it deprecated, master should have it removed. \r\n\r\n**Existing advanced listener APIs**\r\n- `StreamingQueryInfo` renamed to `StreamingQueryStatus` for consistency with `SourceStatus`, `SinkStatus`\r\n   - Earlier StreamingQueryInfo was used only in the advanced listener API, but now it is used in direct public-facing API (StreamingQuery.status)\r\n\r\n- Field `queryInfo` in listener events `QueryStarted`, `QueryProgress`, `QueryTerminated` changed have name `queryStatus` and return type `StreamingQueryStatus`.\r\n\r\n- Field `offsetDesc` in `SourceStatus` was Option[String], converted it to `String`. \r\n\r\n- For `SourceStatus` and `SinkStatus` made constructor private instead of private[sql] to make them more java-safe. Instead added `private[sql] object SourceStatus/SinkStatus.apply()` which are harder to accidentally use in Java.\r\n\r\n## How was this patch tested?\r\n\r\nOld and new unit tests.\r\n- Rate calculation and other internal logic of StreamMetrics tested by StreamMetricsSuite.\r\n- New info in statuses returned through StreamingQueryListener is tested in StreamingQueryListenerSuite.\r\n- New and old info returned through StreamingQuery.status is tested in StreamingQuerySuite.\r\n- Source-specific tests for making sure input rows are counted are is source-specific test suites.\r\n- Additional tests to test minor additions in LocalTableScanExec, StateStore, etc.\r\n\r\nMetrics also manually tested using Ganglia sink","created_at":"2016-09-30T03:33:54Z","updated_at":"2016-10-12T17:50:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8461aa119cba36768f3d97c5763b44b1bf88f3e2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/15307/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/15307/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/15307/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/4c08d569f7817e222550ef7578c6e01f90bc4ee0","head":{"label":"tdas:SPARK-17731","ref":"SPARK-17731","sha":"4c08d569f7817e222550ef7578c6e01f90bc4ee0","user":{"login":"tdas","id":663212,"avatar_url":"https://avatars.githubusercontent.com/u/663212?v=3","gravatar_id":"","url":"https://api.github.com/users/tdas","html_url":"https://github.com/tdas","followers_url":"https://api.github.com/users/tdas/followers","following_url":"https://api.github.com/users/tdas/following{/other_user}","gists_url":"https://api.github.com/users/tdas/gists{/gist_id}","starred_url":"https://api.github.com/users/tdas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdas/subscriptions","organizations_url":"https://api.github.com/users/tdas/orgs","repos_url":"https://api.github.com/users/tdas/repos","events_url":"https://api.github.com/users/tdas/events{/privacy}","received_events_url":"https://api.github.com/users/tdas/received_events","type":"User","site_admin":false},"repo":{"id":17603343,"name":"spark","full_name":"tdas/spark","owner":{"login":"tdas","id":663212,"avatar_url":"https://avatars.githubusercontent.com/u/663212?v=3","gravatar_id":"","url":"https://api.github.com/users/tdas","html_url":"https://github.com/tdas","followers_url":"https://api.github.com/users/tdas/followers","following_url":"https://api.github.com/users/tdas/following{/other_user}","gists_url":"https://api.github.com/users/tdas/gists{/gist_id}","starred_url":"https://api.github.com/users/tdas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdas/subscriptions","organizations_url":"https://api.github.com/users/tdas/orgs","repos_url":"https://api.github.com/users/tdas/repos","events_url":"https://api.github.com/users/tdas/events{/privacy}","received_events_url":"https://api.github.com/users/tdas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tdas/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/tdas/spark","forks_url":"https://api.github.com/repos/tdas/spark/forks","keys_url":"https://api.github.com/repos/tdas/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tdas/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tdas/spark/teams","hooks_url":"https://api.github.com/repos/tdas/spark/hooks","issue_events_url":"https://api.github.com/repos/tdas/spark/issues/events{/number}","events_url":"https://api.github.com/repos/tdas/spark/events","assignees_url":"https://api.github.com/repos/tdas/spark/assignees{/user}","branches_url":"https://api.github.com/repos/tdas/spark/branches{/branch}","tags_url":"https://api.github.com/repos/tdas/spark/tags","blobs_url":"https://api.github.com/repos/tdas/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tdas/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tdas/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/tdas/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tdas/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/tdas/spark/languages","stargazers_url":"https://api.github.com/repos/tdas/spark/stargazers","contributors_url":"https://api.github.com/repos/tdas/spark/contributors","subscribers_url":"https://api.github.com/repos/tdas/spark/subscribers","subscription_url":"https://api.github.com/repos/tdas/spark/subscription","commits_url":"https://api.github.com/repos/tdas/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/tdas/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/tdas/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/tdas/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/tdas/spark/contents/{+path}","compare_url":"https://api.github.com/repos/tdas/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tdas/spark/merges","archive_url":"https://api.github.com/repos/tdas/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tdas/spark/downloads","issues_url":"https://api.github.com/repos/tdas/spark/issues{/number}","pulls_url":"https://api.github.com/repos/tdas/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/tdas/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/tdas/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tdas/spark/labels{/name}","releases_url":"https://api.github.com/repos/tdas/spark/releases{/id}","deployments_url":"https://api.github.com/repos/tdas/spark/deployments","created_at":"2014-03-10T18:19:48Z","updated_at":"2016-06-30T08:57:07Z","pushed_at":"2016-10-12T06:04:43Z","git_url":"git://github.com/tdas/spark.git","ssh_url":"git@github.com:tdas/spark.git","clone_url":"https://github.com/tdas/spark.git","svn_url":"https://github.com/tdas/spark","homepage":null,"size":234680,"stargazers_count":3,"watchers_count":3,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":3,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"23405f324a8089f86ebcbede9bb32944137508e8","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2016-10-12T15:45:48Z","pushed_at":"2016-10-12T17:33:16Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":593584,"stargazers_count":10325,"watchers_count":10325,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9599,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":484,"forks":9599,"open_issues":484,"watchers":10325,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/15307"},"html":{"href":"https://github.com/apache/spark/pull/15307"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/15307"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/15307/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/15307/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/15307/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/4c08d569f7817e222550ef7578c6e01f90bc4ee0"}}}}
{"actor":{"display_login":"marmbrus"}}