{"action":"created","comment":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments/64959471","id":64959471,"diff_hunk":"@@ -80,6 +80,31 @@ define([\n         });\n         this._spSkyFromSpace = undefined;\n         this._spSkyFromAtmosphere = undefined;\n+        \n+        // hue, saturation, and brightness shift values for color adjustment","path":"Source/Scene/SkyAtmosphere.js","position":5,"original_position":5,"commit_id":"8d6d235a1ec863b0e7a3bae809e3f4e48791c44d","original_commit_id":"8d6d235a1ec863b0e7a3bae809e3f4e48791c44d","user":{"login":"lilleyse","id":915398,"avatar_url":"https://avatars.githubusercontent.com/u/915398?v=3","gravatar_id":"","url":"https://api.github.com/users/lilleyse","html_url":"https://github.com/lilleyse","followers_url":"https://api.github.com/users/lilleyse/followers","following_url":"https://api.github.com/users/lilleyse/following{/other_user}","gists_url":"https://api.github.com/users/lilleyse/gists{/gist_id}","starred_url":"https://api.github.com/users/lilleyse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lilleyse/subscriptions","organizations_url":"https://api.github.com/users/lilleyse/orgs","repos_url":"https://api.github.com/users/lilleyse/repos","events_url":"https://api.github.com/users/lilleyse/events{/privacy}","received_events_url":"https://api.github.com/users/lilleyse/received_events","type":"User","site_admin":false},"body":"I think it's clear enough without this comment.","created_at":"2016-05-27T20:00:51Z","updated_at":"2016-05-27T20:00:51Z","html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3971#discussion_r64959471","pull_request_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3971","_links":{"self":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments/64959471"},"html":{"href":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3971#discussion_r64959471"},"pull_request":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3971"}}},"pull_request":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3971","id":71757866,"html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3971","diff_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3971.diff","patch_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3971.patch","issue_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/3971","number":3971,"state":"open","locked":false,"title":"Added HSB color adjustment to the atmosphere and a sandcastle demo","user":{"login":"likangning93","id":5395255,"avatar_url":"https://avatars.githubusercontent.com/u/5395255?v=3","gravatar_id":"","url":"https://api.github.com/users/likangning93","html_url":"https://github.com/likangning93","followers_url":"https://api.github.com/users/likangning93/followers","following_url":"https://api.github.com/users/likangning93/following{/other_user}","gists_url":"https://api.github.com/users/likangning93/gists{/gist_id}","starred_url":"https://api.github.com/users/likangning93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/likangning93/subscriptions","organizations_url":"https://api.github.com/users/likangning93/orgs","repos_url":"https://api.github.com/users/likangning93/repos","events_url":"https://api.github.com/users/likangning93/events{/privacy}","received_events_url":"https://api.github.com/users/likangning93/received_events","type":"User","site_admin":false},"body":"Resolves #3439.\r\n\r\nI added hue/saturation/brightness color adjustment to the atmosphere and a sandcastle demo for this.\r\nSean and I thought color post processing would be the best approach for adjusting the atmosphere color, and it seems like a lot of photo manipulation tools already have HSB color adjustment.\r\n\r\n<img width=\"743\" alt=\"atmosphere hsb color\" src=\"https://cloud.githubusercontent.com/assets/5395255/15618282/2c12712e-241b-11e6-91de-6ae566bd5cc7.PNG\">\r\n\r\nAlso updated CHANGES.md.","created_at":"2016-05-27T18:56:55Z","updated_at":"2016-05-27T20:00:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"771d08094c82825315902c8f79db32f7a849e7db","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3971/commits","review_comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3971/comments","review_comment_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/3971/comments","statuses_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/8d6d235a1ec863b0e7a3bae809e3f4e48791c44d","head":{"label":"likangning93:hueSaturationAtmosphereColorShift","ref":"hueSaturationAtmosphereColorShift","sha":"8d6d235a1ec863b0e7a3bae809e3f4e48791c44d","user":{"login":"likangning93","id":5395255,"avatar_url":"https://avatars.githubusercontent.com/u/5395255?v=3","gravatar_id":"","url":"https://api.github.com/users/likangning93","html_url":"https://github.com/likangning93","followers_url":"https://api.github.com/users/likangning93/followers","following_url":"https://api.github.com/users/likangning93/following{/other_user}","gists_url":"https://api.github.com/users/likangning93/gists{/gist_id}","starred_url":"https://api.github.com/users/likangning93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/likangning93/subscriptions","organizations_url":"https://api.github.com/users/likangning93/orgs","repos_url":"https://api.github.com/users/likangning93/repos","events_url":"https://api.github.com/users/likangning93/events{/privacy}","received_events_url":"https://api.github.com/users/likangning93/received_events","type":"User","site_admin":false},"repo":{"id":59577300,"name":"cesium","full_name":"likangning93/cesium","owner":{"login":"likangning93","id":5395255,"avatar_url":"https://avatars.githubusercontent.com/u/5395255?v=3","gravatar_id":"","url":"https://api.github.com/users/likangning93","html_url":"https://github.com/likangning93","followers_url":"https://api.github.com/users/likangning93/followers","following_url":"https://api.github.com/users/likangning93/following{/other_user}","gists_url":"https://api.github.com/users/likangning93/gists{/gist_id}","starred_url":"https://api.github.com/users/likangning93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/likangning93/subscriptions","organizations_url":"https://api.github.com/users/likangning93/orgs","repos_url":"https://api.github.com/users/likangning93/repos","events_url":"https://api.github.com/users/likangning93/events{/privacy}","received_events_url":"https://api.github.com/users/likangning93/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/likangning93/cesium","description":"WebGL virtual globe and map engine","fork":true,"url":"https://api.github.com/repos/likangning93/cesium","forks_url":"https://api.github.com/repos/likangning93/cesium/forks","keys_url":"https://api.github.com/repos/likangning93/cesium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/likangning93/cesium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/likangning93/cesium/teams","hooks_url":"https://api.github.com/repos/likangning93/cesium/hooks","issue_events_url":"https://api.github.com/repos/likangning93/cesium/issues/events{/number}","events_url":"https://api.github.com/repos/likangning93/cesium/events","assignees_url":"https://api.github.com/repos/likangning93/cesium/assignees{/user}","branches_url":"https://api.github.com/repos/likangning93/cesium/branches{/branch}","tags_url":"https://api.github.com/repos/likangning93/cesium/tags","blobs_url":"https://api.github.com/repos/likangning93/cesium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/likangning93/cesium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/likangning93/cesium/git/refs{/sha}","trees_url":"https://api.github.com/repos/likangning93/cesium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/likangning93/cesium/statuses/{sha}","languages_url":"https://api.github.com/repos/likangning93/cesium/languages","stargazers_url":"https://api.github.com/repos/likangning93/cesium/stargazers","contributors_url":"https://api.github.com/repos/likangning93/cesium/contributors","subscribers_url":"https://api.github.com/repos/likangning93/cesium/subscribers","subscription_url":"https://api.github.com/repos/likangning93/cesium/subscription","commits_url":"https://api.github.com/repos/likangning93/cesium/commits{/sha}","git_commits_url":"https://api.github.com/repos/likangning93/cesium/git/commits{/sha}","comments_url":"https://api.github.com/repos/likangning93/cesium/comments{/number}","issue_comment_url":"https://api.github.com/repos/likangning93/cesium/issues/comments{/number}","contents_url":"https://api.github.com/repos/likangning93/cesium/contents/{+path}","compare_url":"https://api.github.com/repos/likangning93/cesium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/likangning93/cesium/merges","archive_url":"https://api.github.com/repos/likangning93/cesium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/likangning93/cesium/downloads","issues_url":"https://api.github.com/repos/likangning93/cesium/issues{/number}","pulls_url":"https://api.github.com/repos/likangning93/cesium/pulls{/number}","milestones_url":"https://api.github.com/repos/likangning93/cesium/milestones{/number}","notifications_url":"https://api.github.com/repos/likangning93/cesium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/likangning93/cesium/labels{/name}","releases_url":"https://api.github.com/repos/likangning93/cesium/releases{/id}","deployments_url":"https://api.github.com/repos/likangning93/cesium/deployments","created_at":"2016-05-24T13:50:36Z","updated_at":"2016-05-24T13:50:48Z","pushed_at":"2016-05-27T19:23:38Z","git_url":"git://github.com/likangning93/cesium.git","ssh_url":"git@github.com:likangning93/cesium.git","clone_url":"https://github.com/likangning93/cesium.git","svn_url":"https://github.com/likangning93/cesium","homepage":"cesiumjs.org","size":227792,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AnalyticalGraphicsInc:master","ref":"master","sha":"b290fae3e8761cbf3132917ffd97588867cd1d4e","user":{"login":"AnalyticalGraphicsInc","id":1490220,"avatar_url":"https://avatars.githubusercontent.com/u/1490220?v=3","gravatar_id":"","url":"https://api.github.com/users/AnalyticalGraphicsInc","html_url":"https://github.com/AnalyticalGraphicsInc","followers_url":"https://api.github.com/users/AnalyticalGraphicsInc/followers","following_url":"https://api.github.com/users/AnalyticalGraphicsInc/following{/other_user}","gists_url":"https://api.github.com/users/AnalyticalGraphicsInc/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalyticalGraphicsInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalyticalGraphicsInc/subscriptions","organizations_url":"https://api.github.com/users/AnalyticalGraphicsInc/orgs","repos_url":"https://api.github.com/users/AnalyticalGraphicsInc/repos","events_url":"https://api.github.com/users/AnalyticalGraphicsInc/events{/privacy}","received_events_url":"https://api.github.com/users/AnalyticalGraphicsInc/received_events","type":"Organization","site_admin":false},"repo":{"id":3606738,"name":"cesium","full_name":"AnalyticalGraphicsInc/cesium","owner":{"login":"AnalyticalGraphicsInc","id":1490220,"avatar_url":"https://avatars.githubusercontent.com/u/1490220?v=3","gravatar_id":"","url":"https://api.github.com/users/AnalyticalGraphicsInc","html_url":"https://github.com/AnalyticalGraphicsInc","followers_url":"https://api.github.com/users/AnalyticalGraphicsInc/followers","following_url":"https://api.github.com/users/AnalyticalGraphicsInc/following{/other_user}","gists_url":"https://api.github.com/users/AnalyticalGraphicsInc/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalyticalGraphicsInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalyticalGraphicsInc/subscriptions","organizations_url":"https://api.github.com/users/AnalyticalGraphicsInc/orgs","repos_url":"https://api.github.com/users/AnalyticalGraphicsInc/repos","events_url":"https://api.github.com/users/AnalyticalGraphicsInc/events{/privacy}","received_events_url":"https://api.github.com/users/AnalyticalGraphicsInc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AnalyticalGraphicsInc/cesium","description":"WebGL virtual globe and map engine","fork":false,"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium","forks_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/forks","keys_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/teams","hooks_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/hooks","issue_events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/events{/number}","events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/events","assignees_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/assignees{/user}","branches_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/branches{/branch}","tags_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/tags","blobs_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/{sha}","languages_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/languages","stargazers_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/stargazers","contributors_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/contributors","subscribers_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/subscribers","subscription_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/subscription","commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/comments{/number}","contents_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/contents/{+path}","compare_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/merges","archive_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/downloads","issues_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues{/number}","pulls_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls{/number}","milestones_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/milestones{/number}","notifications_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/labels{/name}","releases_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/releases{/id}","deployments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/deployments","created_at":"2012-03-02T22:27:14Z","updated_at":"2016-05-27T16:35:20Z","pushed_at":"2016-05-27T19:23:41Z","git_url":"git://github.com/AnalyticalGraphicsInc/cesium.git","ssh_url":"git@github.com:AnalyticalGraphicsInc/cesium.git","clone_url":"https://github.com/AnalyticalGraphicsInc/cesium.git","svn_url":"https://github.com/AnalyticalGraphicsInc/cesium","homepage":"cesiumjs.org","size":378451,"stargazers_count":1287,"watchers_count":1287,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":733,"mirror_url":null,"open_issues_count":406,"forks":733,"open_issues":406,"watchers":1287,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3971"},"html":{"href":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3971"},"issue":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/3971"},"comments":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/3971/comments"},"review_comments":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3971/comments"},"review_comment":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3971/commits"},"statuses":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/8d6d235a1ec863b0e7a3bae809e3f4e48791c44d"}}}}
{"actor":{"display_login":"lilleyse"}}