{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/msbuild/issues/1074","repository_url":"https://api.github.com/repos/Microsoft/msbuild","labels_url":"https://api.github.com/repos/Microsoft/msbuild/issues/1074/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/msbuild/issues/1074/comments","events_url":"https://api.github.com/repos/Microsoft/msbuild/issues/1074/events","html_url":"https://github.com/Microsoft/msbuild/pull/1074","id":178761436,"number":1074,"title":"Don't discard implicit references from build element cache for each build","user":{"login":"dsplaisted","id":145043,"avatar_url":"https://avatars.githubusercontent.com/u/145043?v=3","gravatar_id":"","url":"https://api.github.com/users/dsplaisted","html_url":"https://github.com/dsplaisted","followers_url":"https://api.github.com/users/dsplaisted/followers","following_url":"https://api.github.com/users/dsplaisted/following{/other_user}","gists_url":"https://api.github.com/users/dsplaisted/gists{/gist_id}","starred_url":"https://api.github.com/users/dsplaisted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsplaisted/subscriptions","organizations_url":"https://api.github.com/users/dsplaisted/orgs","repos_url":"https://api.github.com/users/dsplaisted/repos","events_url":"https://api.github.com/users/dsplaisted/events{/privacy}","received_events_url":"https://api.github.com/users/dsplaisted/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Microsoft/msbuild/labels/cla-already-signed","name":"cla-already-signed","color":"009800"},{"url":"https://api.github.com/repos/Microsoft/msbuild/labels/Needs%20Review","name":"Needs Review","color":"e6e6e6"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-23T01:26:13Z","updated_at":"2016-09-23T21:15:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Microsoft/msbuild/pulls/1074","html_url":"https://github.com/Microsoft/msbuild/pull/1074","diff_url":"https://github.com/Microsoft/msbuild/pull/1074.diff","patch_url":"https://github.com/Microsoft/msbuild/pull/1074.patch"},"body":"Fixes #1068.  With this change, instead of discarding implicit references, the cache will simply remove any entries from the weak dictionary where the value has been garbage collected.  Discarding implicit references for each build doesn't make sense for large solutions, as the implicit references will include the .props and .targets files that are likely to be shared by multiple projects.\r\n\r\nOn a test machine, this reduced the time until Visual Studio finishes initializing projects in the Chromium solution by about 25% (from 19.5 to 14.5 minutes)."},"comment":{"url":"https://api.github.com/repos/Microsoft/msbuild/issues/comments/249304125","html_url":"https://github.com/Microsoft/msbuild/pull/1074#issuecomment-249304125","issue_url":"https://api.github.com/repos/Microsoft/msbuild/issues/1074","id":249304125,"user":{"login":"cdmihai","id":2255729,"avatar_url":"https://avatars.githubusercontent.com/u/2255729?v=3","gravatar_id":"","url":"https://api.github.com/users/cdmihai","html_url":"https://github.com/cdmihai","followers_url":"https://api.github.com/users/cdmihai/followers","following_url":"https://api.github.com/users/cdmihai/following{/other_user}","gists_url":"https://api.github.com/users/cdmihai/gists{/gist_id}","starred_url":"https://api.github.com/users/cdmihai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdmihai/subscriptions","organizations_url":"https://api.github.com/users/cdmihai/orgs","repos_url":"https://api.github.com/users/cdmihai/repos","events_url":"https://api.github.com/users/cdmihai/events{/privacy}","received_events_url":"https://api.github.com/users/cdmihai/received_events","type":"User","site_admin":false},"created_at":"2016-09-23T21:15:02Z","updated_at":"2016-09-23T21:15:02Z","body":"Can you please add a test that asserts the auto reload from disk functionality?"}}
{"actor":{"display_login":"cdmihai"}}