{"action":"closed","number":3,"pull_request":{"url":"https://api.github.com/repos/cytosm/cytosm/pulls/3","id":97992689,"html_url":"https://github.com/cytosm/cytosm/pull/3","diff_url":"https://github.com/cytosm/cytosm/pull/3.diff","patch_url":"https://github.com/cytosm/cytosm/pull/3.patch","issue_url":"https://api.github.com/repos/cytosm/cytosm/issues/3","number":3,"state":"closed","locked":false,"title":"Improve rendering and make AliasVar less buggy.","user":{"login":"Nemikolh","id":4008156,"avatar_url":"https://avatars.githubusercontent.com/u/4008156?v=3","gravatar_id":"","url":"https://api.github.com/users/Nemikolh","html_url":"https://github.com/Nemikolh","followers_url":"https://api.github.com/users/Nemikolh/followers","following_url":"https://api.github.com/users/Nemikolh/following{/other_user}","gists_url":"https://api.github.com/users/Nemikolh/gists{/gist_id}","starred_url":"https://api.github.com/users/Nemikolh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nemikolh/subscriptions","organizations_url":"https://api.github.com/users/Nemikolh/orgs","repos_url":"https://api.github.com/users/Nemikolh/repos","events_url":"https://api.github.com/users/Nemikolh/events{/privacy}","received_events_url":"https://api.github.com/users/Nemikolh/received_events","type":"User","site_admin":false},"body":"After this PR is merged:\r\n- `AliasVar` are treated similarly to other variable. This make the code easier to understand and less magic.\r\n- We have tests for the most important part of the pipeline.\r\n- Variables in the original OpenCypher can be named `count`, `match`, etc.\r\n- `Var` and all subclasses are no longer part of the `Expr` tree. This make a clear separation between the tree and the `Var`s as they should never be created manually in passes other than the `VarDependencies` one.","created_at":"2016-12-14T16:57:32Z","updated_at":"2016-12-14T17:28:55Z","closed_at":"2016-12-14T17:28:55Z","merged_at":"2016-12-14T17:28:55Z","merge_commit_sha":"f13ec4c916c21861e4a2262ffcf6c67a88c2c0df","assignee":{"login":"alzindiq","id":787601,"avatar_url":"https://avatars.githubusercontent.com/u/787601?v=3","gravatar_id":"","url":"https://api.github.com/users/alzindiq","html_url":"https://github.com/alzindiq","followers_url":"https://api.github.com/users/alzindiq/followers","following_url":"https://api.github.com/users/alzindiq/following{/other_user}","gists_url":"https://api.github.com/users/alzindiq/gists{/gist_id}","starred_url":"https://api.github.com/users/alzindiq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alzindiq/subscriptions","organizations_url":"https://api.github.com/users/alzindiq/orgs","repos_url":"https://api.github.com/users/alzindiq/repos","events_url":"https://api.github.com/users/alzindiq/events{/privacy}","received_events_url":"https://api.github.com/users/alzindiq/received_events","type":"User","site_admin":false},"assignees":[{"login":"alzindiq","id":787601,"avatar_url":"https://avatars.githubusercontent.com/u/787601?v=3","gravatar_id":"","url":"https://api.github.com/users/alzindiq","html_url":"https://github.com/alzindiq","followers_url":"https://api.github.com/users/alzindiq/followers","following_url":"https://api.github.com/users/alzindiq/following{/other_user}","gists_url":"https://api.github.com/users/alzindiq/gists{/gist_id}","starred_url":"https://api.github.com/users/alzindiq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alzindiq/subscriptions","organizations_url":"https://api.github.com/users/alzindiq/orgs","repos_url":"https://api.github.com/users/alzindiq/repos","events_url":"https://api.github.com/users/alzindiq/events{/privacy}","received_events_url":"https://api.github.com/users/alzindiq/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cytosm/cytosm/pulls/3/commits","review_comments_url":"https://api.github.com/repos/cytosm/cytosm/pulls/3/comments","review_comment_url":"https://api.github.com/repos/cytosm/cytosm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cytosm/cytosm/issues/3/comments","statuses_url":"https://api.github.com/repos/cytosm/cytosm/statuses/5f98af09bbe15b3f7e6dcb24a4c45f4bdbe3ce20","head":{"label":"Nemikolh:cypher2sql-tests","ref":"cypher2sql-tests","sha":"5f98af09bbe15b3f7e6dcb24a4c45f4bdbe3ce20","user":{"login":"Nemikolh","id":4008156,"avatar_url":"https://avatars.githubusercontent.com/u/4008156?v=3","gravatar_id":"","url":"https://api.github.com/users/Nemikolh","html_url":"https://github.com/Nemikolh","followers_url":"https://api.github.com/users/Nemikolh/followers","following_url":"https://api.github.com/users/Nemikolh/following{/other_user}","gists_url":"https://api.github.com/users/Nemikolh/gists{/gist_id}","starred_url":"https://api.github.com/users/Nemikolh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nemikolh/subscriptions","organizations_url":"https://api.github.com/users/Nemikolh/orgs","repos_url":"https://api.github.com/users/Nemikolh/repos","events_url":"https://api.github.com/users/Nemikolh/events{/privacy}","received_events_url":"https://api.github.com/users/Nemikolh/received_events","type":"User","site_admin":false},"repo":{"id":76373731,"name":"cytosm","full_name":"Nemikolh/cytosm","owner":{"login":"Nemikolh","id":4008156,"avatar_url":"https://avatars.githubusercontent.com/u/4008156?v=3","gravatar_id":"","url":"https://api.github.com/users/Nemikolh","html_url":"https://github.com/Nemikolh","followers_url":"https://api.github.com/users/Nemikolh/followers","following_url":"https://api.github.com/users/Nemikolh/following{/other_user}","gists_url":"https://api.github.com/users/Nemikolh/gists{/gist_id}","starred_url":"https://api.github.com/users/Nemikolh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nemikolh/subscriptions","organizations_url":"https://api.github.com/users/Nemikolh/orgs","repos_url":"https://api.github.com/users/Nemikolh/repos","events_url":"https://api.github.com/users/Nemikolh/events{/privacy}","received_events_url":"https://api.github.com/users/Nemikolh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Nemikolh/cytosm","description":"Cypher to SQL Mapper","fork":true,"url":"https://api.github.com/repos/Nemikolh/cytosm","forks_url":"https://api.github.com/repos/Nemikolh/cytosm/forks","keys_url":"https://api.github.com/repos/Nemikolh/cytosm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nemikolh/cytosm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nemikolh/cytosm/teams","hooks_url":"https://api.github.com/repos/Nemikolh/cytosm/hooks","issue_events_url":"https://api.github.com/repos/Nemikolh/cytosm/issues/events{/number}","events_url":"https://api.github.com/repos/Nemikolh/cytosm/events","assignees_url":"https://api.github.com/repos/Nemikolh/cytosm/assignees{/user}","branches_url":"https://api.github.com/repos/Nemikolh/cytosm/branches{/branch}","tags_url":"https://api.github.com/repos/Nemikolh/cytosm/tags","blobs_url":"https://api.github.com/repos/Nemikolh/cytosm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nemikolh/cytosm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nemikolh/cytosm/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nemikolh/cytosm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nemikolh/cytosm/statuses/{sha}","languages_url":"https://api.github.com/repos/Nemikolh/cytosm/languages","stargazers_url":"https://api.github.com/repos/Nemikolh/cytosm/stargazers","contributors_url":"https://api.github.com/repos/Nemikolh/cytosm/contributors","subscribers_url":"https://api.github.com/repos/Nemikolh/cytosm/subscribers","subscription_url":"https://api.github.com/repos/Nemikolh/cytosm/subscription","commits_url":"https://api.github.com/repos/Nemikolh/cytosm/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nemikolh/cytosm/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nemikolh/cytosm/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nemikolh/cytosm/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nemikolh/cytosm/contents/{+path}","compare_url":"https://api.github.com/repos/Nemikolh/cytosm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nemikolh/cytosm/merges","archive_url":"https://api.github.com/repos/Nemikolh/cytosm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nemikolh/cytosm/downloads","issues_url":"https://api.github.com/repos/Nemikolh/cytosm/issues{/number}","pulls_url":"https://api.github.com/repos/Nemikolh/cytosm/pulls{/number}","milestones_url":"https://api.github.com/repos/Nemikolh/cytosm/milestones{/number}","notifications_url":"https://api.github.com/repos/Nemikolh/cytosm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nemikolh/cytosm/labels{/name}","releases_url":"https://api.github.com/repos/Nemikolh/cytosm/releases{/id}","deployments_url":"https://api.github.com/repos/Nemikolh/cytosm/deployments","created_at":"2016-12-13T15:54:07Z","updated_at":"2016-12-13T15:54:09Z","pushed_at":"2016-12-14T16:51:45Z","git_url":"git://github.com/Nemikolh/cytosm.git","ssh_url":"git@github.com:Nemikolh/cytosm.git","clone_url":"https://github.com/Nemikolh/cytosm.git","svn_url":"https://github.com/Nemikolh/cytosm","homepage":"","size":840,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cytosm:master","ref":"master","sha":"f667f4fbfd9edfb5219e8837bcf478c7f9ef6994","user":{"login":"cytosm","id":24522352,"avatar_url":"https://avatars.githubusercontent.com/u/24522352?v=3","gravatar_id":"","url":"https://api.github.com/users/cytosm","html_url":"https://github.com/cytosm","followers_url":"https://api.github.com/users/cytosm/followers","following_url":"https://api.github.com/users/cytosm/following{/other_user}","gists_url":"https://api.github.com/users/cytosm/gists{/gist_id}","starred_url":"https://api.github.com/users/cytosm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cytosm/subscriptions","organizations_url":"https://api.github.com/users/cytosm/orgs","repos_url":"https://api.github.com/users/cytosm/repos","events_url":"https://api.github.com/users/cytosm/events{/privacy}","received_events_url":"https://api.github.com/users/cytosm/received_events","type":"Organization","site_admin":false},"repo":{"id":76279677,"name":"cytosm","full_name":"cytosm/cytosm","owner":{"login":"cytosm","id":24522352,"avatar_url":"https://avatars.githubusercontent.com/u/24522352?v=3","gravatar_id":"","url":"https://api.github.com/users/cytosm","html_url":"https://github.com/cytosm","followers_url":"https://api.github.com/users/cytosm/followers","following_url":"https://api.github.com/users/cytosm/following{/other_user}","gists_url":"https://api.github.com/users/cytosm/gists{/gist_id}","starred_url":"https://api.github.com/users/cytosm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cytosm/subscriptions","organizations_url":"https://api.github.com/users/cytosm/orgs","repos_url":"https://api.github.com/users/cytosm/repos","events_url":"https://api.github.com/users/cytosm/events{/privacy}","received_events_url":"https://api.github.com/users/cytosm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cytosm/cytosm","description":"OpenCypher to SQL Mapper","fork":false,"url":"https://api.github.com/repos/cytosm/cytosm","forks_url":"https://api.github.com/repos/cytosm/cytosm/forks","keys_url":"https://api.github.com/repos/cytosm/cytosm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cytosm/cytosm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cytosm/cytosm/teams","hooks_url":"https://api.github.com/repos/cytosm/cytosm/hooks","issue_events_url":"https://api.github.com/repos/cytosm/cytosm/issues/events{/number}","events_url":"https://api.github.com/repos/cytosm/cytosm/events","assignees_url":"https://api.github.com/repos/cytosm/cytosm/assignees{/user}","branches_url":"https://api.github.com/repos/cytosm/cytosm/branches{/branch}","tags_url":"https://api.github.com/repos/cytosm/cytosm/tags","blobs_url":"https://api.github.com/repos/cytosm/cytosm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cytosm/cytosm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cytosm/cytosm/git/refs{/sha}","trees_url":"https://api.github.com/repos/cytosm/cytosm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cytosm/cytosm/statuses/{sha}","languages_url":"https://api.github.com/repos/cytosm/cytosm/languages","stargazers_url":"https://api.github.com/repos/cytosm/cytosm/stargazers","contributors_url":"https://api.github.com/repos/cytosm/cytosm/contributors","subscribers_url":"https://api.github.com/repos/cytosm/cytosm/subscribers","subscription_url":"https://api.github.com/repos/cytosm/cytosm/subscription","commits_url":"https://api.github.com/repos/cytosm/cytosm/commits{/sha}","git_commits_url":"https://api.github.com/repos/cytosm/cytosm/git/commits{/sha}","comments_url":"https://api.github.com/repos/cytosm/cytosm/comments{/number}","issue_comment_url":"https://api.github.com/repos/cytosm/cytosm/issues/comments{/number}","contents_url":"https://api.github.com/repos/cytosm/cytosm/contents/{+path}","compare_url":"https://api.github.com/repos/cytosm/cytosm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cytosm/cytosm/merges","archive_url":"https://api.github.com/repos/cytosm/cytosm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cytosm/cytosm/downloads","issues_url":"https://api.github.com/repos/cytosm/cytosm/issues{/number}","pulls_url":"https://api.github.com/repos/cytosm/cytosm/pulls{/number}","milestones_url":"https://api.github.com/repos/cytosm/cytosm/milestones{/number}","notifications_url":"https://api.github.com/repos/cytosm/cytosm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cytosm/cytosm/labels{/name}","releases_url":"https://api.github.com/repos/cytosm/cytosm/releases{/id}","deployments_url":"https://api.github.com/repos/cytosm/cytosm/deployments","created_at":"2016-12-12T17:30:55Z","updated_at":"2016-12-14T13:10:21Z","pushed_at":"2016-12-14T17:28:55Z","git_url":"git://github.com/cytosm/cytosm.git","ssh_url":"git@github.com:cytosm/cytosm.git","clone_url":"https://github.com/cytosm/cytosm.git","svn_url":"https://github.com/cytosm/cytosm","homepage":"","size":830,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cytosm/cytosm/pulls/3"},"html":{"href":"https://github.com/cytosm/cytosm/pull/3"},"issue":{"href":"https://api.github.com/repos/cytosm/cytosm/issues/3"},"comments":{"href":"https://api.github.com/repos/cytosm/cytosm/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/cytosm/cytosm/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/cytosm/cytosm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cytosm/cytosm/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/cytosm/cytosm/statuses/5f98af09bbe15b3f7e6dcb24a4c45f4bdbe3ce20"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"alzindiq","id":787601,"avatar_url":"https://avatars.githubusercontent.com/u/787601?v=3","gravatar_id":"","url":"https://api.github.com/users/alzindiq","html_url":"https://github.com/alzindiq","followers_url":"https://api.github.com/users/alzindiq/followers","following_url":"https://api.github.com/users/alzindiq/following{/other_user}","gists_url":"https://api.github.com/users/alzindiq/gists{/gist_id}","starred_url":"https://api.github.com/users/alzindiq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alzindiq/subscriptions","organizations_url":"https://api.github.com/users/alzindiq/orgs","repos_url":"https://api.github.com/users/alzindiq/repos","events_url":"https://api.github.com/users/alzindiq/events{/privacy}","received_events_url":"https://api.github.com/users/alzindiq/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":5,"additions":1722,"deletions":344,"changed_files":49}}
{"actor":{"display_login":"alzindiq"}}