{"comment":{"url":"https://api.github.com/repos/theuni/bitcoin/comments/18913885","html_url":"https://github.com/theuni/bitcoin/commit/fa88a425c0c1089ab75ea9223699286f40c8eea7#commitcomment-18913885","id":18913885,"user":{"login":"theuni","id":417043,"avatar_url":"https://avatars.githubusercontent.com/u/417043?v=3","gravatar_id":"","url":"https://api.github.com/users/theuni","html_url":"https://github.com/theuni","followers_url":"https://api.github.com/users/theuni/followers","following_url":"https://api.github.com/users/theuni/following{/other_user}","gists_url":"https://api.github.com/users/theuni/gists{/gist_id}","starred_url":"https://api.github.com/users/theuni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theuni/subscriptions","organizations_url":"https://api.github.com/users/theuni/orgs","repos_url":"https://api.github.com/users/theuni/repos","events_url":"https://api.github.com/users/theuni/events{/privacy}","received_events_url":"https://api.github.com/users/theuni/received_events","type":"User","site_admin":false},"position":6,"line":130,"path":"qa/rpc-tests/test_framework/util.py","commit_id":"fa88a425c0c1089ab75ea9223699286f40c8eea7","created_at":"2016-09-06T16:14:07Z","updated_at":"2016-09-06T16:14:07Z","body":"Good point about node0. I think it'd be tough to make sync_wallet non-racy, though, without tying it to a specific block height/hash, which is essentially what this change does.\r\n\r\nI'm pushing up an alternative which compares all block heights instead of revolving around node0's. Since the new rpc functions are essentially free (they don't lock cs_main and only block when necessary), I think that's ok."}}
{"actor":{"display_login":"theuni"}}