{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/90926625","pull_request_review_id":11438677,"id":90926625,"diff_hunk":"@@ -24,7 +22,7 @@ public sealed class DefaultBindingPropertyAttribute : Attribute\n         /// </summary>\n         public DefaultBindingPropertyAttribute()\n         {\n-            _name = null;\n+            Name = null;","path":"src/System.ComponentModel.TypeConverter/src/System/ComponentModel/DefaultBindingPropertyAttribute.cs","position":14,"original_position":14,"commit_id":"9b3eaef5dec8cace82b548792d5cbe9b0d1cc673","original_commit_id":"9b3eaef5dec8cace82b548792d5cbe9b0d1cc673","user":{"login":"AlexGhiondea","id":8396979,"avatar_url":"https://avatars.githubusercontent.com/u/8396979?v=3","gravatar_id":"","url":"https://api.github.com/users/AlexGhiondea","html_url":"https://github.com/AlexGhiondea","followers_url":"https://api.github.com/users/AlexGhiondea/followers","following_url":"https://api.github.com/users/AlexGhiondea/following{/other_user}","gists_url":"https://api.github.com/users/AlexGhiondea/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexGhiondea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexGhiondea/subscriptions","organizations_url":"https://api.github.com/users/AlexGhiondea/orgs","repos_url":"https://api.github.com/users/AlexGhiondea/repos","events_url":"https://api.github.com/users/AlexGhiondea/events{/privacy}","received_events_url":"https://api.github.com/users/AlexGhiondea/received_events","type":"User","site_admin":false},"body":"This is not required","created_at":"2016-12-05T18:33:41Z","updated_at":"2016-12-05T18:33:41Z","html_url":"https://github.com/dotnet/corefx/pull/14154#discussion_r90926625","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/14154","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/90926625"},"html":{"href":"https://github.com/dotnet/corefx/pull/14154#discussion_r90926625"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/14154"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/14154","id":96139409,"html_url":"https://github.com/dotnet/corefx/pull/14154","diff_url":"https://github.com/dotnet/corefx/pull/14154.diff","patch_url":"https://github.com/dotnet/corefx/pull/14154.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/14154","number":14154,"state":"open","locked":false,"title":"Code cleanup in System.ComponentModel.TypeConverter","user":{"login":"bmeverett","id":3941006,"avatar_url":"https://avatars.githubusercontent.com/u/3941006?v=3","gravatar_id":"","url":"https://api.github.com/users/bmeverett","html_url":"https://github.com/bmeverett","followers_url":"https://api.github.com/users/bmeverett/followers","following_url":"https://api.github.com/users/bmeverett/following{/other_user}","gists_url":"https://api.github.com/users/bmeverett/gists{/gist_id}","starred_url":"https://api.github.com/users/bmeverett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmeverett/subscriptions","organizations_url":"https://api.github.com/users/bmeverett/orgs","repos_url":"https://api.github.com/users/bmeverett/repos","events_url":"https://api.github.com/users/bmeverett/events{/privacy}","received_events_url":"https://api.github.com/users/bmeverett/received_events","type":"User","site_admin":false},"body":"Resolves #12160 to clean up code in System.ComponentModel.TypeConverter\r\ncc @AlexGhiondea \r\n\r\n- [x] Remove explicit base() from constructor calls\r\n- [x] Replace explicitly implemented properties with auto-implemented properties when possible\r\n- [x] Simplify members and properties with 1 lines of code to expression bodied members\r\n- [x] Switch over to the ?. operator in C# for null checking\r\n- [x] Switch to string interpolation instead of string concatenation\r\n- [x] Remove unnecessary initialization (ie. Bool foo = false)\r\n- [x] Replace empty arrays with Array.Empty()\r\n- [x] Replace string literals with nameof wherever possible.\r\n- [x] Simplify event handler declarations when no custom code is required\r\n- [x] Introduce readonly modifier for sync objects.\r\n- [x] Replace nongeneric collections with generic collections\r\n- [x] Use foreach instead of manually writing the foreach logic.\r\n- [x] Cache the char[] into a static readonly field (ie. new char[] { '' })\r\n- [x] Simplify the CultureInfoMapper code\r\n\r\nI created an individual commit for each improvement, didn't know if that would make review any easier.  I tried to search the project and make sure everything was accounted for. This is a decent size project so something may have been missed. Feel free to comment and I'll be glad to fix it.","created_at":"2016-12-01T18:01:08Z","updated_at":"2016-12-05T19:03:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c92a5b09337c262ad65fb9439a1aacbdea411d4","assignee":{"login":"bmeverett","id":3941006,"avatar_url":"https://avatars.githubusercontent.com/u/3941006?v=3","gravatar_id":"","url":"https://api.github.com/users/bmeverett","html_url":"https://github.com/bmeverett","followers_url":"https://api.github.com/users/bmeverett/followers","following_url":"https://api.github.com/users/bmeverett/following{/other_user}","gists_url":"https://api.github.com/users/bmeverett/gists{/gist_id}","starred_url":"https://api.github.com/users/bmeverett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmeverett/subscriptions","organizations_url":"https://api.github.com/users/bmeverett/orgs","repos_url":"https://api.github.com/users/bmeverett/repos","events_url":"https://api.github.com/users/bmeverett/events{/privacy}","received_events_url":"https://api.github.com/users/bmeverett/received_events","type":"User","site_admin":false},"assignees":[{"login":"bmeverett","id":3941006,"avatar_url":"https://avatars.githubusercontent.com/u/3941006?v=3","gravatar_id":"","url":"https://api.github.com/users/bmeverett","html_url":"https://github.com/bmeverett","followers_url":"https://api.github.com/users/bmeverett/followers","following_url":"https://api.github.com/users/bmeverett/following{/other_user}","gists_url":"https://api.github.com/users/bmeverett/gists{/gist_id}","starred_url":"https://api.github.com/users/bmeverett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmeverett/subscriptions","organizations_url":"https://api.github.com/users/bmeverett/orgs","repos_url":"https://api.github.com/users/bmeverett/repos","events_url":"https://api.github.com/users/bmeverett/events{/privacy}","received_events_url":"https://api.github.com/users/bmeverett/received_events","type":"User","site_admin":false},{"login":"AlexGhiondea","id":8396979,"avatar_url":"https://avatars.githubusercontent.com/u/8396979?v=3","gravatar_id":"","url":"https://api.github.com/users/AlexGhiondea","html_url":"https://github.com/AlexGhiondea","followers_url":"https://api.github.com/users/AlexGhiondea/followers","following_url":"https://api.github.com/users/AlexGhiondea/following{/other_user}","gists_url":"https://api.github.com/users/AlexGhiondea/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexGhiondea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexGhiondea/subscriptions","organizations_url":"https://api.github.com/users/AlexGhiondea/orgs","repos_url":"https://api.github.com/users/AlexGhiondea/repos","events_url":"https://api.github.com/users/AlexGhiondea/events{/privacy}","received_events_url":"https://api.github.com/users/AlexGhiondea/received_events","type":"User","site_admin":false},{"login":"safern","id":22899328,"avatar_url":"https://avatars.githubusercontent.com/u/22899328?v=3","gravatar_id":"","url":"https://api.github.com/users/safern","html_url":"https://github.com/safern","followers_url":"https://api.github.com/users/safern/followers","following_url":"https://api.github.com/users/safern/following{/other_user}","gists_url":"https://api.github.com/users/safern/gists{/gist_id}","starred_url":"https://api.github.com/users/safern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/safern/subscriptions","organizations_url":"https://api.github.com/users/safern/orgs","repos_url":"https://api.github.com/users/safern/repos","events_url":"https://api.github.com/users/safern/events{/privacy}","received_events_url":"https://api.github.com/users/safern/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/14154/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/14154/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/14154/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/9b3eaef5dec8cace82b548792d5cbe9b0d1cc673","head":{"label":"bmeverett:code-cleanup","ref":"code-cleanup","sha":"9b3eaef5dec8cace82b548792d5cbe9b0d1cc673","user":{"login":"bmeverett","id":3941006,"avatar_url":"https://avatars.githubusercontent.com/u/3941006?v=3","gravatar_id":"","url":"https://api.github.com/users/bmeverett","html_url":"https://github.com/bmeverett","followers_url":"https://api.github.com/users/bmeverett/followers","following_url":"https://api.github.com/users/bmeverett/following{/other_user}","gists_url":"https://api.github.com/users/bmeverett/gists{/gist_id}","starred_url":"https://api.github.com/users/bmeverett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmeverett/subscriptions","organizations_url":"https://api.github.com/users/bmeverett/orgs","repos_url":"https://api.github.com/users/bmeverett/repos","events_url":"https://api.github.com/users/bmeverett/events{/privacy}","received_events_url":"https://api.github.com/users/bmeverett/received_events","type":"User","site_admin":false},"repo":{"id":75095639,"name":"corefx","full_name":"bmeverett/corefx","owner":{"login":"bmeverett","id":3941006,"avatar_url":"https://avatars.githubusercontent.com/u/3941006?v=3","gravatar_id":"","url":"https://api.github.com/users/bmeverett","html_url":"https://github.com/bmeverett","followers_url":"https://api.github.com/users/bmeverett/followers","following_url":"https://api.github.com/users/bmeverett/following{/other_user}","gists_url":"https://api.github.com/users/bmeverett/gists{/gist_id}","starred_url":"https://api.github.com/users/bmeverett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmeverett/subscriptions","organizations_url":"https://api.github.com/users/bmeverett/orgs","repos_url":"https://api.github.com/users/bmeverett/repos","events_url":"https://api.github.com/users/bmeverett/events{/privacy}","received_events_url":"https://api.github.com/users/bmeverett/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bmeverett/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/bmeverett/corefx","forks_url":"https://api.github.com/repos/bmeverett/corefx/forks","keys_url":"https://api.github.com/repos/bmeverett/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bmeverett/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bmeverett/corefx/teams","hooks_url":"https://api.github.com/repos/bmeverett/corefx/hooks","issue_events_url":"https://api.github.com/repos/bmeverett/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/bmeverett/corefx/events","assignees_url":"https://api.github.com/repos/bmeverett/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/bmeverett/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/bmeverett/corefx/tags","blobs_url":"https://api.github.com/repos/bmeverett/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bmeverett/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bmeverett/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/bmeverett/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bmeverett/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/bmeverett/corefx/languages","stargazers_url":"https://api.github.com/repos/bmeverett/corefx/stargazers","contributors_url":"https://api.github.com/repos/bmeverett/corefx/contributors","subscribers_url":"https://api.github.com/repos/bmeverett/corefx/subscribers","subscription_url":"https://api.github.com/repos/bmeverett/corefx/subscription","commits_url":"https://api.github.com/repos/bmeverett/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/bmeverett/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/bmeverett/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/bmeverett/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/bmeverett/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/bmeverett/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bmeverett/corefx/merges","archive_url":"https://api.github.com/repos/bmeverett/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bmeverett/corefx/downloads","issues_url":"https://api.github.com/repos/bmeverett/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/bmeverett/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/bmeverett/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/bmeverett/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bmeverett/corefx/labels{/name}","releases_url":"https://api.github.com/repos/bmeverett/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/bmeverett/corefx/deployments","created_at":"2016-11-29T15:39:20Z","updated_at":"2016-11-29T15:39:49Z","pushed_at":"2016-12-02T20:10:48Z","git_url":"git://github.com/bmeverett/corefx.git","ssh_url":"git@github.com:bmeverett/corefx.git","clone_url":"https://github.com/bmeverett/corefx.git","svn_url":"https://github.com/bmeverett/corefx","homepage":"https://docs.microsoft.com/dotnet/","size":120746,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"d7526947d458ca4c99b16c536cbcf88a2dff4935","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-12-05T17:09:10Z","pushed_at":"2016-12-05T18:50:31Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://docs.microsoft.com/dotnet/","size":168596,"stargazers_count":10891,"watchers_count":10891,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2783,"mirror_url":null,"open_issues_count":1294,"forks":2783,"open_issues":1294,"watchers":10891,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/14154"},"html":{"href":"https://github.com/dotnet/corefx/pull/14154"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/14154"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/14154/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/14154/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/14154/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/9b3eaef5dec8cace82b548792d5cbe9b0d1cc673"}}}}
{"actor":{"display_login":"AlexGhiondea"}}