{"action":"created","comment":{"url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/pulls/comments/52728348","id":52728348,"diff_hunk":"@@ -345,7 +357,12 @@ public function walkJoinCondition(QOM\\SelectorInterface $left, QOM\\SelectorInter\n         }\n \n         if ($condition instanceof QOM\\EquiJoinConditionInterface) {\n-            return $this->walkEquiJoinCondition($left->getSelectorName(), $right->getSelectorName(), $condition);\n+            if (!$left instanceof QOM\\SelectorInterface) {","path":"src/Jackalope/Transport/DoctrineDBAL/Query/QOMWalker.php","position":96,"original_position":96,"commit_id":"867ae81df5aee41d82f0989cd7fc7bd7c7947f26","original_commit_id":"867ae81df5aee41d82f0989cd7fc7bd7c7947f26","user":{"login":"dbu","id":76576,"avatar_url":"https://avatars.githubusercontent.com/u/76576?v=3","gravatar_id":"","url":"https://api.github.com/users/dbu","html_url":"https://github.com/dbu","followers_url":"https://api.github.com/users/dbu/followers","following_url":"https://api.github.com/users/dbu/following{/other_user}","gists_url":"https://api.github.com/users/dbu/gists{/gist_id}","starred_url":"https://api.github.com/users/dbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbu/subscriptions","organizations_url":"https://api.github.com/users/dbu/orgs","repos_url":"https://api.github.com/users/dbu/repos","events_url":"https://api.github.com/users/dbu/events{/privacy}","received_events_url":"https://api.github.com/users/dbu/received_events","type":"User","site_admin":false},"body":"can we invert these for readability? (if $left instanceof then getSelectorName else getJoinCondition...)","created_at":"2016-02-12T10:59:50Z","updated_at":"2016-02-12T10:59:50Z","html_url":"https://github.com/jackalope/jackalope-doctrine-dbal/pull/318#discussion_r52728348","pull_request_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/pulls/318","_links":{"self":{"href":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/pulls/comments/52728348"},"html":{"href":"https://github.com/jackalope/jackalope-doctrine-dbal/pull/318#discussion_r52728348"},"pull_request":{"href":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/pulls/318"}}},"pull_request":{"url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/pulls/318","id":59065619,"html_url":"https://github.com/jackalope/jackalope-doctrine-dbal/pull/318","diff_url":"https://github.com/jackalope/jackalope-doctrine-dbal/pull/318.diff","patch_url":"https://github.com/jackalope/jackalope-doctrine-dbal/pull/318.patch","issue_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/issues/318","number":318,"state":"open","locked":false,"title":"Add the possibility of using nested joins","user":{"login":"richard-fizz","id":12270626,"avatar_url":"https://avatars.githubusercontent.com/u/12270626?v=3","gravatar_id":"","url":"https://api.github.com/users/richard-fizz","html_url":"https://github.com/richard-fizz","followers_url":"https://api.github.com/users/richard-fizz/followers","following_url":"https://api.github.com/users/richard-fizz/following{/other_user}","gists_url":"https://api.github.com/users/richard-fizz/gists{/gist_id}","starred_url":"https://api.github.com/users/richard-fizz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richard-fizz/subscriptions","organizations_url":"https://api.github.com/users/richard-fizz/orgs","repos_url":"https://api.github.com/users/richard-fizz/repos","events_url":"https://api.github.com/users/richard-fizz/events{/privacy}","received_events_url":"https://api.github.com/users/richard-fizz/received_events","type":"User","site_admin":false},"body":"Adds the posibility to use a 'join join' on the left side of the joined selector\r\n\r\nDepends on\r\n- https://github.com/phpcr/phpcr-utils/pull/160\r\n- https://github.com/phpcr/phpcr-api-tests/pull/177","created_at":"2016-02-11T17:31:37Z","updated_at":"2016-02-12T10:59:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc73753c6ddf15274640a0c23ac9e44eb773eb6c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/pulls/318/commits","review_comments_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/pulls/318/comments","review_comment_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/issues/318/comments","statuses_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/statuses/867ae81df5aee41d82f0989cd7fc7bd7c7947f26","head":{"label":"richard-fizz:master","ref":"master","sha":"867ae81df5aee41d82f0989cd7fc7bd7c7947f26","user":{"login":"richard-fizz","id":12270626,"avatar_url":"https://avatars.githubusercontent.com/u/12270626?v=3","gravatar_id":"","url":"https://api.github.com/users/richard-fizz","html_url":"https://github.com/richard-fizz","followers_url":"https://api.github.com/users/richard-fizz/followers","following_url":"https://api.github.com/users/richard-fizz/following{/other_user}","gists_url":"https://api.github.com/users/richard-fizz/gists{/gist_id}","starred_url":"https://api.github.com/users/richard-fizz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richard-fizz/subscriptions","organizations_url":"https://api.github.com/users/richard-fizz/orgs","repos_url":"https://api.github.com/users/richard-fizz/repos","events_url":"https://api.github.com/users/richard-fizz/events{/privacy}","received_events_url":"https://api.github.com/users/richard-fizz/received_events","type":"User","site_admin":false},"repo":{"id":51530993,"name":"jackalope-doctrine-dbal","full_name":"richard-fizz/jackalope-doctrine-dbal","owner":{"login":"richard-fizz","id":12270626,"avatar_url":"https://avatars.githubusercontent.com/u/12270626?v=3","gravatar_id":"","url":"https://api.github.com/users/richard-fizz","html_url":"https://github.com/richard-fizz","followers_url":"https://api.github.com/users/richard-fizz/followers","following_url":"https://api.github.com/users/richard-fizz/following{/other_user}","gists_url":"https://api.github.com/users/richard-fizz/gists{/gist_id}","starred_url":"https://api.github.com/users/richard-fizz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richard-fizz/subscriptions","organizations_url":"https://api.github.com/users/richard-fizz/orgs","repos_url":"https://api.github.com/users/richard-fizz/repos","events_url":"https://api.github.com/users/richard-fizz/events{/privacy}","received_events_url":"https://api.github.com/users/richard-fizz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/richard-fizz/jackalope-doctrine-dbal","description":"Doctrine DBAL transport implementation for Jackalope","fork":true,"url":"https://api.github.com/repos/richard-fizz/jackalope-doctrine-dbal","forks_url":"https://api.github.com/repos/richard-fizz/jackalope-doctrine-dbal/forks","keys_url":"https://api.github.com/repos/richard-fizz/jackalope-doctrine-dbal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/richard-fizz/jackalope-doctrine-dbal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/richard-fizz/jackalope-doctrine-dbal/teams","hooks_url":"https://api.github.com/repos/richard-fizz/jackalope-doctrine-dbal/hooks","issue_events_url":"https://api.github.com/repos/richard-fizz/jackalope-doctrine-dbal/issues/events{/number}","events_url":"https://api.github.com/repos/richard-fizz/jackalope-doctrine-dbal/events","assignees_url":"https://api.github.com/repos/richard-fizz/jackalope-doctrine-dbal/assignees{/user}","branches_url":"https://api.github.com/repos/richard-fizz/jackalope-doctrine-dbal/branches{/branch}","tags_url":"https://api.github.com/repos/richard-fizz/jackalope-doctrine-dbal/tags","blobs_url":"https://api.github.com/repos/richard-fizz/jackalope-doctrine-dbal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/richard-fizz/jackalope-doctrine-dbal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/richard-fizz/jackalope-doctrine-dbal/git/refs{/sha}","trees_url":"https://api.github.com/repos/richard-fizz/jackalope-doctrine-dbal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/richard-fizz/jackalope-doctrine-dbal/statuses/{sha}","languages_url":"https://api.github.com/repos/richard-fizz/jackalope-doctrine-dbal/languages","stargazers_url":"https://api.github.com/repos/richard-fizz/jackalope-doctrine-dbal/stargazers","contributors_url":"https://api.github.com/repos/richard-fizz/jackalope-doctrine-dbal/contributors","subscribers_url":"https://api.github.com/repos/richard-fizz/jackalope-doctrine-dbal/subscribers","subscription_url":"https://api.github.com/repos/richard-fizz/jackalope-doctrine-dbal/subscription","commits_url":"https://api.github.com/repos/richard-fizz/jackalope-doctrine-dbal/commits{/sha}","git_commits_url":"https://api.github.com/repos/richard-fizz/jackalope-doctrine-dbal/git/commits{/sha}","comments_url":"https://api.github.com/repos/richard-fizz/jackalope-doctrine-dbal/comments{/number}","issue_comment_url":"https://api.github.com/repos/richard-fizz/jackalope-doctrine-dbal/issues/comments{/number}","contents_url":"https://api.github.com/repos/richard-fizz/jackalope-doctrine-dbal/contents/{+path}","compare_url":"https://api.github.com/repos/richard-fizz/jackalope-doctrine-dbal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/richard-fizz/jackalope-doctrine-dbal/merges","archive_url":"https://api.github.com/repos/richard-fizz/jackalope-doctrine-dbal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/richard-fizz/jackalope-doctrine-dbal/downloads","issues_url":"https://api.github.com/repos/richard-fizz/jackalope-doctrine-dbal/issues{/number}","pulls_url":"https://api.github.com/repos/richard-fizz/jackalope-doctrine-dbal/pulls{/number}","milestones_url":"https://api.github.com/repos/richard-fizz/jackalope-doctrine-dbal/milestones{/number}","notifications_url":"https://api.github.com/repos/richard-fizz/jackalope-doctrine-dbal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/richard-fizz/jackalope-doctrine-dbal/labels{/name}","releases_url":"https://api.github.com/repos/richard-fizz/jackalope-doctrine-dbal/releases{/id}","deployments_url":"https://api.github.com/repos/richard-fizz/jackalope-doctrine-dbal/deployments","created_at":"2016-02-11T17:11:53Z","updated_at":"2016-02-11T17:11:53Z","pushed_at":"2016-02-12T10:41:45Z","git_url":"git://github.com/richard-fizz/jackalope-doctrine-dbal.git","ssh_url":"git@github.com:richard-fizz/jackalope-doctrine-dbal.git","clone_url":"https://github.com/richard-fizz/jackalope-doctrine-dbal.git","svn_url":"https://github.com/richard-fizz/jackalope-doctrine-dbal","homepage":"http://jackalope.github.io","size":9616,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jackalope:master","ref":"master","sha":"b1088bf844005e856954a64a0ad160cd3de63323","user":{"login":"jackalope","id":70245,"avatar_url":"https://avatars.githubusercontent.com/u/70245?v=3","gravatar_id":"","url":"https://api.github.com/users/jackalope","html_url":"https://github.com/jackalope","followers_url":"https://api.github.com/users/jackalope/followers","following_url":"https://api.github.com/users/jackalope/following{/other_user}","gists_url":"https://api.github.com/users/jackalope/gists{/gist_id}","starred_url":"https://api.github.com/users/jackalope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackalope/subscriptions","organizations_url":"https://api.github.com/users/jackalope/orgs","repos_url":"https://api.github.com/users/jackalope/repos","events_url":"https://api.github.com/users/jackalope/events{/privacy}","received_events_url":"https://api.github.com/users/jackalope/received_events","type":"Organization","site_admin":false},"repo":{"id":3470596,"name":"jackalope-doctrine-dbal","full_name":"jackalope/jackalope-doctrine-dbal","owner":{"login":"jackalope","id":70245,"avatar_url":"https://avatars.githubusercontent.com/u/70245?v=3","gravatar_id":"","url":"https://api.github.com/users/jackalope","html_url":"https://github.com/jackalope","followers_url":"https://api.github.com/users/jackalope/followers","following_url":"https://api.github.com/users/jackalope/following{/other_user}","gists_url":"https://api.github.com/users/jackalope/gists{/gist_id}","starred_url":"https://api.github.com/users/jackalope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackalope/subscriptions","organizations_url":"https://api.github.com/users/jackalope/orgs","repos_url":"https://api.github.com/users/jackalope/repos","events_url":"https://api.github.com/users/jackalope/events{/privacy}","received_events_url":"https://api.github.com/users/jackalope/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jackalope/jackalope-doctrine-dbal","description":"Doctrine DBAL transport implementation for Jackalope","fork":false,"url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal","forks_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/forks","keys_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/teams","hooks_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/hooks","issue_events_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/issues/events{/number}","events_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/events","assignees_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/assignees{/user}","branches_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/branches{/branch}","tags_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/tags","blobs_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/git/refs{/sha}","trees_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/statuses/{sha}","languages_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/languages","stargazers_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/stargazers","contributors_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/contributors","subscribers_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/subscribers","subscription_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/subscription","commits_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/commits{/sha}","git_commits_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/git/commits{/sha}","comments_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/comments{/number}","issue_comment_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/issues/comments{/number}","contents_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/contents/{+path}","compare_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/merges","archive_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/downloads","issues_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/issues{/number}","pulls_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/pulls{/number}","milestones_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/milestones{/number}","notifications_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/labels{/name}","releases_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/releases{/id}","deployments_url":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/deployments","created_at":"2012-02-17T14:35:21Z","updated_at":"2016-02-05T00:06:31Z","pushed_at":"2016-02-12T10:41:46Z","git_url":"git://github.com/jackalope/jackalope-doctrine-dbal.git","ssh_url":"git@github.com:jackalope/jackalope-doctrine-dbal.git","clone_url":"https://github.com/jackalope/jackalope-doctrine-dbal.git","svn_url":"https://github.com/jackalope/jackalope-doctrine-dbal","homepage":"http://jackalope.github.io","size":9884,"stargazers_count":72,"watchers_count":72,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":36,"forks":46,"open_issues":36,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/pulls/318"},"html":{"href":"https://github.com/jackalope/jackalope-doctrine-dbal/pull/318"},"issue":{"href":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/issues/318"},"comments":{"href":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/issues/318/comments"},"review_comments":{"href":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/pulls/318/comments"},"review_comment":{"href":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/pulls/318/commits"},"statuses":{"href":"https://api.github.com/repos/jackalope/jackalope-doctrine-dbal/statuses/867ae81df5aee41d82f0989cd7fc7bd7c7947f26"}}}}