{"action":"created","comment":{"url":"https://api.github.com/repos/Pelagicore/softwarecontainer/pulls/comments/90440671","pull_request_review_id":10958378,"id":90440671,"diff_hunk":"@@ -187,6 +203,53 @@ def test_allow_ping_only_for_specific_domain(self):\n         finally:\n             sc.terminate()\n \n+    def test_whitelist(self):\n+        \"\"\" Tests the whitelisting feauture.\n+            a config for allowing ping to example.com is set first\n+            then another config for allowing ping to iana.org is set\n+            consequences are questioned with asserts\n+        \"\"\"\n+        try:\n+            sc = Container()\n+            sc.start(DATA)\n+\n+            sc.set_gateway_config(\"network\", GW_CONFIG_ACCEPT_EXAMPLE_COM)\n+            sc.set_gateway_config(\"network\", GW_CONFIG_ACCEPT_IANA_ORG)\n+            sc.launch_command(\"python \" +\n+                              sc.get_bind_dir() +\n+                              \"/testhelper.py\" +\n+                              \" --test-dir \" + sc.get_bind_dir() +\n+                              \" --do-ping iana.org\")\n+            time.sleep(2)\n+            helper = NetworkHelper(CURRENT_DIR)\n+            is_pingable = helper.ping_result()\n+            assert is_pingable is True\n+            helper.remove_file()\n+\n+            sc.launch_command(\"python \" +\n+                              sc.get_bind_dir() +\n+                              \"/testhelper.py\" +\n+                              \" --test-dir \" + sc.get_bind_dir() +\n+                              \" --do-ping example.org\")\n+            time.sleep(2)\n+            helper = NetworkHelper(CURRENT_DIR)\n+            is_pingable = helper.ping_result()\n+            assert is_pingable is True\n+            helper.remove_file()\n+\n+            sc.launch_command(\"python \" +\n+                              sc.get_bind_dir() +\n+                              \"/testhelper.py\" +\n+                              \" --test-dir \" + sc.get_bind_dir() +\n+                              \" --do-ping pelagicore.com\")\n+            time.sleep(10)","path":"servicetest/networkgateway/test_network_gateway.py","position":73,"original_position":73,"commit_id":"08727e52ee29186f1ccfa707501c6b7134c61a24","original_commit_id":"08727e52ee29186f1ccfa707501c6b7134c61a24","user":{"login":"breakreturn","id":13065146,"avatar_url":"https://avatars.githubusercontent.com/u/13065146?v=3","gravatar_id":"","url":"https://api.github.com/users/breakreturn","html_url":"https://github.com/breakreturn","followers_url":"https://api.github.com/users/breakreturn/followers","following_url":"https://api.github.com/users/breakreturn/following{/other_user}","gists_url":"https://api.github.com/users/breakreturn/gists{/gist_id}","starred_url":"https://api.github.com/users/breakreturn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/breakreturn/subscriptions","organizations_url":"https://api.github.com/users/breakreturn/orgs","repos_url":"https://api.github.com/users/breakreturn/repos","events_url":"https://api.github.com/users/breakreturn/events{/privacy}","received_events_url":"https://api.github.com/users/breakreturn/received_events","type":"User","site_admin":false},"body":"Could you add some comments describing when we do long-ish sleeps? I think it should be motivated so anyone maintaining this doesn't need to think too much about it.","created_at":"2016-12-01T12:55:11Z","updated_at":"2016-12-01T12:55:11Z","html_url":"https://github.com/Pelagicore/softwarecontainer/pull/189#discussion_r90440671","pull_request_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/pulls/189","_links":{"self":{"href":"https://api.github.com/repos/Pelagicore/softwarecontainer/pulls/comments/90440671"},"html":{"href":"https://github.com/Pelagicore/softwarecontainer/pull/189#discussion_r90440671"},"pull_request":{"href":"https://api.github.com/repos/Pelagicore/softwarecontainer/pulls/189"}}},"pull_request":{"url":"https://api.github.com/repos/Pelagicore/softwarecontainer/pulls/189","id":95921344,"html_url":"https://github.com/Pelagicore/softwarecontainer/pull/189","diff_url":"https://github.com/Pelagicore/softwarecontainer/pull/189.diff","patch_url":"https://github.com/Pelagicore/softwarecontainer/pull/189.patch","issue_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/issues/189","number":189,"state":"open","locked":false,"title":"Add whitelisting test for NetworkGateway","user":{"login":"kursatkobya","id":3169121,"avatar_url":"https://avatars.githubusercontent.com/u/3169121?v=3","gravatar_id":"","url":"https://api.github.com/users/kursatkobya","html_url":"https://github.com/kursatkobya","followers_url":"https://api.github.com/users/kursatkobya/followers","following_url":"https://api.github.com/users/kursatkobya/following{/other_user}","gists_url":"https://api.github.com/users/kursatkobya/gists{/gist_id}","starred_url":"https://api.github.com/users/kursatkobya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kursatkobya/subscriptions","organizations_url":"https://api.github.com/users/kursatkobya/orgs","repos_url":"https://api.github.com/users/kursatkobya/repos","events_url":"https://api.github.com/users/kursatkobya/events{/privacy}","received_events_url":"https://api.github.com/users/kursatkobya/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-30T16:10:45Z","updated_at":"2016-12-01T12:55:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ca2f2db5fbdf7851dfc796fcb2b2e7d1be0e768","assignee":{"login":"tobsan","id":122421,"avatar_url":"https://avatars.githubusercontent.com/u/122421?v=3","gravatar_id":"","url":"https://api.github.com/users/tobsan","html_url":"https://github.com/tobsan","followers_url":"https://api.github.com/users/tobsan/followers","following_url":"https://api.github.com/users/tobsan/following{/other_user}","gists_url":"https://api.github.com/users/tobsan/gists{/gist_id}","starred_url":"https://api.github.com/users/tobsan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobsan/subscriptions","organizations_url":"https://api.github.com/users/tobsan/orgs","repos_url":"https://api.github.com/users/tobsan/repos","events_url":"https://api.github.com/users/tobsan/events{/privacy}","received_events_url":"https://api.github.com/users/tobsan/received_events","type":"User","site_admin":false},"assignees":[{"login":"tobsan","id":122421,"avatar_url":"https://avatars.githubusercontent.com/u/122421?v=3","gravatar_id":"","url":"https://api.github.com/users/tobsan","html_url":"https://github.com/tobsan","followers_url":"https://api.github.com/users/tobsan/followers","following_url":"https://api.github.com/users/tobsan/following{/other_user}","gists_url":"https://api.github.com/users/tobsan/gists{/gist_id}","starred_url":"https://api.github.com/users/tobsan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobsan/subscriptions","organizations_url":"https://api.github.com/users/tobsan/orgs","repos_url":"https://api.github.com/users/tobsan/repos","events_url":"https://api.github.com/users/tobsan/events{/privacy}","received_events_url":"https://api.github.com/users/tobsan/received_events","type":"User","site_admin":false},{"login":"breakreturn","id":13065146,"avatar_url":"https://avatars.githubusercontent.com/u/13065146?v=3","gravatar_id":"","url":"https://api.github.com/users/breakreturn","html_url":"https://github.com/breakreturn","followers_url":"https://api.github.com/users/breakreturn/followers","following_url":"https://api.github.com/users/breakreturn/following{/other_user}","gists_url":"https://api.github.com/users/breakreturn/gists{/gist_id}","starred_url":"https://api.github.com/users/breakreturn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/breakreturn/subscriptions","organizations_url":"https://api.github.com/users/breakreturn/orgs","repos_url":"https://api.github.com/users/breakreturn/repos","events_url":"https://api.github.com/users/breakreturn/events{/privacy}","received_events_url":"https://api.github.com/users/breakreturn/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/pulls/189/commits","review_comments_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/pulls/189/comments","review_comment_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/issues/189/comments","statuses_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/statuses/08727e52ee29186f1ccfa707501c6b7134c61a24","head":{"label":"kursatkobya:SKORPA-242","ref":"SKORPA-242","sha":"08727e52ee29186f1ccfa707501c6b7134c61a24","user":{"login":"kursatkobya","id":3169121,"avatar_url":"https://avatars.githubusercontent.com/u/3169121?v=3","gravatar_id":"","url":"https://api.github.com/users/kursatkobya","html_url":"https://github.com/kursatkobya","followers_url":"https://api.github.com/users/kursatkobya/followers","following_url":"https://api.github.com/users/kursatkobya/following{/other_user}","gists_url":"https://api.github.com/users/kursatkobya/gists{/gist_id}","starred_url":"https://api.github.com/users/kursatkobya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kursatkobya/subscriptions","organizations_url":"https://api.github.com/users/kursatkobya/orgs","repos_url":"https://api.github.com/users/kursatkobya/repos","events_url":"https://api.github.com/users/kursatkobya/events{/privacy}","received_events_url":"https://api.github.com/users/kursatkobya/received_events","type":"User","site_admin":false},"repo":{"id":70566619,"name":"softwarecontainer","full_name":"kursatkobya/softwarecontainer","owner":{"login":"kursatkobya","id":3169121,"avatar_url":"https://avatars.githubusercontent.com/u/3169121?v=3","gravatar_id":"","url":"https://api.github.com/users/kursatkobya","html_url":"https://github.com/kursatkobya","followers_url":"https://api.github.com/users/kursatkobya/followers","following_url":"https://api.github.com/users/kursatkobya/following{/other_user}","gists_url":"https://api.github.com/users/kursatkobya/gists{/gist_id}","starred_url":"https://api.github.com/users/kursatkobya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kursatkobya/subscriptions","organizations_url":"https://api.github.com/users/kursatkobya/orgs","repos_url":"https://api.github.com/users/kursatkobya/repos","events_url":"https://api.github.com/users/kursatkobya/events{/privacy}","received_events_url":"https://api.github.com/users/kursatkobya/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kursatkobya/softwarecontainer","description":"Framework to manage and contain applications in an automotive setting","fork":true,"url":"https://api.github.com/repos/kursatkobya/softwarecontainer","forks_url":"https://api.github.com/repos/kursatkobya/softwarecontainer/forks","keys_url":"https://api.github.com/repos/kursatkobya/softwarecontainer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kursatkobya/softwarecontainer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kursatkobya/softwarecontainer/teams","hooks_url":"https://api.github.com/repos/kursatkobya/softwarecontainer/hooks","issue_events_url":"https://api.github.com/repos/kursatkobya/softwarecontainer/issues/events{/number}","events_url":"https://api.github.com/repos/kursatkobya/softwarecontainer/events","assignees_url":"https://api.github.com/repos/kursatkobya/softwarecontainer/assignees{/user}","branches_url":"https://api.github.com/repos/kursatkobya/softwarecontainer/branches{/branch}","tags_url":"https://api.github.com/repos/kursatkobya/softwarecontainer/tags","blobs_url":"https://api.github.com/repos/kursatkobya/softwarecontainer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kursatkobya/softwarecontainer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kursatkobya/softwarecontainer/git/refs{/sha}","trees_url":"https://api.github.com/repos/kursatkobya/softwarecontainer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kursatkobya/softwarecontainer/statuses/{sha}","languages_url":"https://api.github.com/repos/kursatkobya/softwarecontainer/languages","stargazers_url":"https://api.github.com/repos/kursatkobya/softwarecontainer/stargazers","contributors_url":"https://api.github.com/repos/kursatkobya/softwarecontainer/contributors","subscribers_url":"https://api.github.com/repos/kursatkobya/softwarecontainer/subscribers","subscription_url":"https://api.github.com/repos/kursatkobya/softwarecontainer/subscription","commits_url":"https://api.github.com/repos/kursatkobya/softwarecontainer/commits{/sha}","git_commits_url":"https://api.github.com/repos/kursatkobya/softwarecontainer/git/commits{/sha}","comments_url":"https://api.github.com/repos/kursatkobya/softwarecontainer/comments{/number}","issue_comment_url":"https://api.github.com/repos/kursatkobya/softwarecontainer/issues/comments{/number}","contents_url":"https://api.github.com/repos/kursatkobya/softwarecontainer/contents/{+path}","compare_url":"https://api.github.com/repos/kursatkobya/softwarecontainer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kursatkobya/softwarecontainer/merges","archive_url":"https://api.github.com/repos/kursatkobya/softwarecontainer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kursatkobya/softwarecontainer/downloads","issues_url":"https://api.github.com/repos/kursatkobya/softwarecontainer/issues{/number}","pulls_url":"https://api.github.com/repos/kursatkobya/softwarecontainer/pulls{/number}","milestones_url":"https://api.github.com/repos/kursatkobya/softwarecontainer/milestones{/number}","notifications_url":"https://api.github.com/repos/kursatkobya/softwarecontainer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kursatkobya/softwarecontainer/labels{/name}","releases_url":"https://api.github.com/repos/kursatkobya/softwarecontainer/releases{/id}","deployments_url":"https://api.github.com/repos/kursatkobya/softwarecontainer/deployments","created_at":"2016-10-11T07:17:56Z","updated_at":"2016-10-11T07:17:58Z","pushed_at":"2016-12-01T12:42:32Z","git_url":"git://github.com/kursatkobya/softwarecontainer.git","ssh_url":"git@github.com:kursatkobya/softwarecontainer.git","clone_url":"https://github.com/kursatkobya/softwarecontainer.git","svn_url":"https://github.com/kursatkobya/softwarecontainer","homepage":"","size":1992,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Pelagicore:master","ref":"master","sha":"553e6fb1f87cba19941075b2846ddcbc7015c1e8","user":{"login":"Pelagicore","id":4661080,"avatar_url":"https://avatars.githubusercontent.com/u/4661080?v=3","gravatar_id":"","url":"https://api.github.com/users/Pelagicore","html_url":"https://github.com/Pelagicore","followers_url":"https://api.github.com/users/Pelagicore/followers","following_url":"https://api.github.com/users/Pelagicore/following{/other_user}","gists_url":"https://api.github.com/users/Pelagicore/gists{/gist_id}","starred_url":"https://api.github.com/users/Pelagicore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pelagicore/subscriptions","organizations_url":"https://api.github.com/users/Pelagicore/orgs","repos_url":"https://api.github.com/users/Pelagicore/repos","events_url":"https://api.github.com/users/Pelagicore/events{/privacy}","received_events_url":"https://api.github.com/users/Pelagicore/received_events","type":"Organization","site_admin":false},"repo":{"id":67503064,"name":"softwarecontainer","full_name":"Pelagicore/softwarecontainer","owner":{"login":"Pelagicore","id":4661080,"avatar_url":"https://avatars.githubusercontent.com/u/4661080?v=3","gravatar_id":"","url":"https://api.github.com/users/Pelagicore","html_url":"https://github.com/Pelagicore","followers_url":"https://api.github.com/users/Pelagicore/followers","following_url":"https://api.github.com/users/Pelagicore/following{/other_user}","gists_url":"https://api.github.com/users/Pelagicore/gists{/gist_id}","starred_url":"https://api.github.com/users/Pelagicore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pelagicore/subscriptions","organizations_url":"https://api.github.com/users/Pelagicore/orgs","repos_url":"https://api.github.com/users/Pelagicore/repos","events_url":"https://api.github.com/users/Pelagicore/events{/privacy}","received_events_url":"https://api.github.com/users/Pelagicore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Pelagicore/softwarecontainer","description":"Framework to manage and contain applications in an automotive setting","fork":false,"url":"https://api.github.com/repos/Pelagicore/softwarecontainer","forks_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/forks","keys_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/teams","hooks_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/hooks","issue_events_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/issues/events{/number}","events_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/events","assignees_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/assignees{/user}","branches_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/branches{/branch}","tags_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/tags","blobs_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/statuses/{sha}","languages_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/languages","stargazers_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/stargazers","contributors_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/contributors","subscribers_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/subscribers","subscription_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/subscription","commits_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/contents/{+path}","compare_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/merges","archive_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/downloads","issues_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/issues{/number}","pulls_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/pulls{/number}","milestones_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/milestones{/number}","notifications_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/labels{/name}","releases_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/releases{/id}","deployments_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/deployments","created_at":"2016-09-06T11:46:06Z","updated_at":"2016-10-25T13:24:35Z","pushed_at":"2016-12-01T12:48:57Z","git_url":"git://github.com/Pelagicore/softwarecontainer.git","ssh_url":"git@github.com:Pelagicore/softwarecontainer.git","clone_url":"https://github.com/Pelagicore/softwarecontainer.git","svn_url":"https://github.com/Pelagicore/softwarecontainer","homepage":"https://pelagicore.github.io/softwarecontainer/","size":5490,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":11,"mirror_url":null,"open_issues_count":5,"forks":11,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Pelagicore/softwarecontainer/pulls/189"},"html":{"href":"https://github.com/Pelagicore/softwarecontainer/pull/189"},"issue":{"href":"https://api.github.com/repos/Pelagicore/softwarecontainer/issues/189"},"comments":{"href":"https://api.github.com/repos/Pelagicore/softwarecontainer/issues/189/comments"},"review_comments":{"href":"https://api.github.com/repos/Pelagicore/softwarecontainer/pulls/189/comments"},"review_comment":{"href":"https://api.github.com/repos/Pelagicore/softwarecontainer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Pelagicore/softwarecontainer/pulls/189/commits"},"statuses":{"href":"https://api.github.com/repos/Pelagicore/softwarecontainer/statuses/08727e52ee29186f1ccfa707501c6b7134c61a24"}}}}
{"actor":{"display_login":"breakreturn"}}