{"action":"created","comment":{"url":"https://api.github.com/repos/biocore/emperor/pulls/comments/60094952","id":60094952,"diff_hunk":"@@ -56,62 +55,108 @@ define([\n     var SLICK_WIDTH = 25, scope = this;\n     var name, value, colorItem;\n \n+    // Create scale div and checkbox for whether using scalar data or not\n+    this.$scaleDiv = $('<div></div>')\n+    this.$colorScale = $(\"<svg width='90%' height='40'></svg>\");\n+    this.$scaleDiv.append(this.$colorScale);\n+    this.$scaled = $(\"<input type='checkbox' id='scaled'>\");","path":"emperor/support_files/js/color-view-controller.js","position":16,"original_position":16,"commit_id":"c8896fbb1b35090514974c949912f38de068eb3b","original_commit_id":"c8896fbb1b35090514974c949912f38de068eb3b","user":{"login":"ElDeveloper","id":375307,"avatar_url":"https://avatars.githubusercontent.com/u/375307?v=3","gravatar_id":"","url":"https://api.github.com/users/ElDeveloper","html_url":"https://github.com/ElDeveloper","followers_url":"https://api.github.com/users/ElDeveloper/followers","following_url":"https://api.github.com/users/ElDeveloper/following{/other_user}","gists_url":"https://api.github.com/users/ElDeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/ElDeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElDeveloper/subscriptions","organizations_url":"https://api.github.com/users/ElDeveloper/orgs","repos_url":"https://api.github.com/users/ElDeveloper/repos","events_url":"https://api.github.com/users/ElDeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/ElDeveloper/received_events","type":"User","site_admin":false},"body":"Yeah, you are right Josh, for these properties, there's no need to have\nunique identifiers. However, we have these for the\nEmperorViewControllers in general, we have an `identifier` property and\nit follows a scheme similar to what Daniel suggests.\n\nOn (Apr-18-16| 9:59), Joshua Shorenstein wrote:\n> > @@ -56,62 +55,108 @@ define([\n> >      var SLICK_WIDTH = 25, scope = this;\n> >      var name, value, colorItem;\n> >  \n> > +    // Create scale div and checkbox for whether using scalar data or not\n> > +    this.$scaleDiv = $('<div></div>')\n> > +    this.$colorScale = $(\"<svg width='90%' height='40'></svg>\");\n> > +    this.$scaleDiv.append(this.$colorScale);\n> > +    this.$scaled = $(\"<input type='checkbox' id='scaled'>\");\n> \n> As far as I can tell in the codebase (and @ElDeveloper correct me if I'm wrong) nothing is done through IDs directly, but instead using the objects attached to the controllers, so this is probably not needed.\n> \n> ---\n> You are receiving this because you were mentioned.\n> Reply to this email directly or view it on GitHub:\n> https://github.com/biocore/emperor/pull/456/files/c8896fbb1b35090514974c949912f38de068eb3b#r60094408\n","created_at":"2016-04-18T17:02:51Z","updated_at":"2016-04-18T17:02:51Z","html_url":"https://github.com/biocore/emperor/pull/456#discussion_r60094952","pull_request_url":"https://api.github.com/repos/biocore/emperor/pulls/456","_links":{"self":{"href":"https://api.github.com/repos/biocore/emperor/pulls/comments/60094952"},"html":{"href":"https://github.com/biocore/emperor/pull/456#discussion_r60094952"},"pull_request":{"href":"https://api.github.com/repos/biocore/emperor/pulls/456"}}},"pull_request":{"url":"https://api.github.com/repos/biocore/emperor/pulls/456","id":66724952,"html_url":"https://github.com/biocore/emperor/pull/456","diff_url":"https://github.com/biocore/emperor/pull/456.diff","patch_url":"https://github.com/biocore/emperor/pull/456.patch","issue_url":"https://api.github.com/repos/biocore/emperor/issues/456","number":456,"state":"open","locked":false,"title":"Gradient view and more colormaps","user":{"login":"squirrelo","id":3079066,"avatar_url":"https://avatars.githubusercontent.com/u/3079066?v=3","gravatar_id":"","url":"https://api.github.com/users/squirrelo","html_url":"https://github.com/squirrelo","followers_url":"https://api.github.com/users/squirrelo/followers","following_url":"https://api.github.com/users/squirrelo/following{/other_user}","gists_url":"https://api.github.com/users/squirrelo/gists{/gist_id}","starred_url":"https://api.github.com/users/squirrelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squirrelo/subscriptions","organizations_url":"https://api.github.com/users/squirrelo/orgs","repos_url":"https://api.github.com/users/squirrelo/repos","events_url":"https://api.github.com/users/squirrelo/events{/privacy}","received_events_url":"https://api.github.com/users/squirrelo/received_events","type":"User","site_admin":false},"body":"~~Requires/supersedes #455 depending on how we want to do reviews.~~ Merged\r\n\r\nThis updates the colorview controller to allow gradient-based coloring instead of single-step coloring. It also adds in every available colormap in chroma into emperor.\r\n\r\nThis also fixes an issue found where this.$body was pointing to the slickgrid div itself, instead of a container div for the body with the slickgrid in it. Fixing this allowed the switch between colorbar and discrete category colors in the menu.\r\n\r\n<img width=\"485\" alt=\"screen shot 2016-04-15 at 19 18 27\" src=\"https://cloud.githubusercontent.com/assets/3079066/14578534/5482ebcc-033f-11e6-953b-0e618b427b6a.png\">\r\n\r\n<img width=\"1664\" alt=\"screen shot 2016-04-15 at 19 18 47\" src=\"https://cloud.githubusercontent.com/assets/3079066/14578535/59a9abfe-033f-11e6-8d1c-a7dd17c4b72f.png\">","created_at":"2016-04-16T02:22:12Z","updated_at":"2016-04-18T17:02:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27e166b79225ba163ddf6ca9e52ae22ae169d3c7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/biocore/emperor/pulls/456/commits","review_comments_url":"https://api.github.com/repos/biocore/emperor/pulls/456/comments","review_comment_url":"https://api.github.com/repos/biocore/emperor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/biocore/emperor/issues/456/comments","statuses_url":"https://api.github.com/repos/biocore/emperor/statuses/c8896fbb1b35090514974c949912f38de068eb3b","head":{"label":"squirrelo:colorviewcontroller","ref":"colorviewcontroller","sha":"c8896fbb1b35090514974c949912f38de068eb3b","user":{"login":"squirrelo","id":3079066,"avatar_url":"https://avatars.githubusercontent.com/u/3079066?v=3","gravatar_id":"","url":"https://api.github.com/users/squirrelo","html_url":"https://github.com/squirrelo","followers_url":"https://api.github.com/users/squirrelo/followers","following_url":"https://api.github.com/users/squirrelo/following{/other_user}","gists_url":"https://api.github.com/users/squirrelo/gists{/gist_id}","starred_url":"https://api.github.com/users/squirrelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squirrelo/subscriptions","organizations_url":"https://api.github.com/users/squirrelo/orgs","repos_url":"https://api.github.com/users/squirrelo/repos","events_url":"https://api.github.com/users/squirrelo/events{/privacy}","received_events_url":"https://api.github.com/users/squirrelo/received_events","type":"User","site_admin":false},"repo":{"id":56338855,"name":"emperor","full_name":"squirrelo/emperor","owner":{"login":"squirrelo","id":3079066,"avatar_url":"https://avatars.githubusercontent.com/u/3079066?v=3","gravatar_id":"","url":"https://api.github.com/users/squirrelo","html_url":"https://github.com/squirrelo","followers_url":"https://api.github.com/users/squirrelo/followers","following_url":"https://api.github.com/users/squirrelo/following{/other_user}","gists_url":"https://api.github.com/users/squirrelo/gists{/gist_id}","starred_url":"https://api.github.com/users/squirrelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squirrelo/subscriptions","organizations_url":"https://api.github.com/users/squirrelo/orgs","repos_url":"https://api.github.com/users/squirrelo/repos","events_url":"https://api.github.com/users/squirrelo/events{/privacy}","received_events_url":"https://api.github.com/users/squirrelo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/squirrelo/emperor","description":"Emperor a tool for the analysis and visualization of large microbial ecology datasets","fork":true,"url":"https://api.github.com/repos/squirrelo/emperor","forks_url":"https://api.github.com/repos/squirrelo/emperor/forks","keys_url":"https://api.github.com/repos/squirrelo/emperor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/squirrelo/emperor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/squirrelo/emperor/teams","hooks_url":"https://api.github.com/repos/squirrelo/emperor/hooks","issue_events_url":"https://api.github.com/repos/squirrelo/emperor/issues/events{/number}","events_url":"https://api.github.com/repos/squirrelo/emperor/events","assignees_url":"https://api.github.com/repos/squirrelo/emperor/assignees{/user}","branches_url":"https://api.github.com/repos/squirrelo/emperor/branches{/branch}","tags_url":"https://api.github.com/repos/squirrelo/emperor/tags","blobs_url":"https://api.github.com/repos/squirrelo/emperor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/squirrelo/emperor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/squirrelo/emperor/git/refs{/sha}","trees_url":"https://api.github.com/repos/squirrelo/emperor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/squirrelo/emperor/statuses/{sha}","languages_url":"https://api.github.com/repos/squirrelo/emperor/languages","stargazers_url":"https://api.github.com/repos/squirrelo/emperor/stargazers","contributors_url":"https://api.github.com/repos/squirrelo/emperor/contributors","subscribers_url":"https://api.github.com/repos/squirrelo/emperor/subscribers","subscription_url":"https://api.github.com/repos/squirrelo/emperor/subscription","commits_url":"https://api.github.com/repos/squirrelo/emperor/commits{/sha}","git_commits_url":"https://api.github.com/repos/squirrelo/emperor/git/commits{/sha}","comments_url":"https://api.github.com/repos/squirrelo/emperor/comments{/number}","issue_comment_url":"https://api.github.com/repos/squirrelo/emperor/issues/comments{/number}","contents_url":"https://api.github.com/repos/squirrelo/emperor/contents/{+path}","compare_url":"https://api.github.com/repos/squirrelo/emperor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/squirrelo/emperor/merges","archive_url":"https://api.github.com/repos/squirrelo/emperor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/squirrelo/emperor/downloads","issues_url":"https://api.github.com/repos/squirrelo/emperor/issues{/number}","pulls_url":"https://api.github.com/repos/squirrelo/emperor/pulls{/number}","milestones_url":"https://api.github.com/repos/squirrelo/emperor/milestones{/number}","notifications_url":"https://api.github.com/repos/squirrelo/emperor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/squirrelo/emperor/labels{/name}","releases_url":"https://api.github.com/repos/squirrelo/emperor/releases{/id}","deployments_url":"https://api.github.com/repos/squirrelo/emperor/deployments","created_at":"2016-04-15T17:41:56Z","updated_at":"2016-04-15T17:41:57Z","pushed_at":"2016-04-16T14:40:00Z","git_url":"git://github.com/squirrelo/emperor.git","ssh_url":"git@github.com:squirrelo/emperor.git","clone_url":"https://github.com/squirrelo/emperor.git","svn_url":"https://github.com/squirrelo/emperor","homepage":"http://emperor.microbio.me","size":9802,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"biocore:new-api","ref":"new-api","sha":"b46c8dfcf08fa5e6d77493785110911d066d2579","user":{"login":"biocore","id":6241857,"avatar_url":"https://avatars.githubusercontent.com/u/6241857?v=3","gravatar_id":"","url":"https://api.github.com/users/biocore","html_url":"https://github.com/biocore","followers_url":"https://api.github.com/users/biocore/followers","following_url":"https://api.github.com/users/biocore/following{/other_user}","gists_url":"https://api.github.com/users/biocore/gists{/gist_id}","starred_url":"https://api.github.com/users/biocore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biocore/subscriptions","organizations_url":"https://api.github.com/users/biocore/orgs","repos_url":"https://api.github.com/users/biocore/repos","events_url":"https://api.github.com/users/biocore/events{/privacy}","received_events_url":"https://api.github.com/users/biocore/received_events","type":"Organization","site_admin":false},"repo":{"id":7758329,"name":"emperor","full_name":"biocore/emperor","owner":{"login":"biocore","id":6241857,"avatar_url":"https://avatars.githubusercontent.com/u/6241857?v=3","gravatar_id":"","url":"https://api.github.com/users/biocore","html_url":"https://github.com/biocore","followers_url":"https://api.github.com/users/biocore/followers","following_url":"https://api.github.com/users/biocore/following{/other_user}","gists_url":"https://api.github.com/users/biocore/gists{/gist_id}","starred_url":"https://api.github.com/users/biocore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biocore/subscriptions","organizations_url":"https://api.github.com/users/biocore/orgs","repos_url":"https://api.github.com/users/biocore/repos","events_url":"https://api.github.com/users/biocore/events{/privacy}","received_events_url":"https://api.github.com/users/biocore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/biocore/emperor","description":"Emperor a tool for the analysis and visualization of large microbial ecology datasets","fork":false,"url":"https://api.github.com/repos/biocore/emperor","forks_url":"https://api.github.com/repos/biocore/emperor/forks","keys_url":"https://api.github.com/repos/biocore/emperor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/biocore/emperor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/biocore/emperor/teams","hooks_url":"https://api.github.com/repos/biocore/emperor/hooks","issue_events_url":"https://api.github.com/repos/biocore/emperor/issues/events{/number}","events_url":"https://api.github.com/repos/biocore/emperor/events","assignees_url":"https://api.github.com/repos/biocore/emperor/assignees{/user}","branches_url":"https://api.github.com/repos/biocore/emperor/branches{/branch}","tags_url":"https://api.github.com/repos/biocore/emperor/tags","blobs_url":"https://api.github.com/repos/biocore/emperor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/biocore/emperor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/biocore/emperor/git/refs{/sha}","trees_url":"https://api.github.com/repos/biocore/emperor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/biocore/emperor/statuses/{sha}","languages_url":"https://api.github.com/repos/biocore/emperor/languages","stargazers_url":"https://api.github.com/repos/biocore/emperor/stargazers","contributors_url":"https://api.github.com/repos/biocore/emperor/contributors","subscribers_url":"https://api.github.com/repos/biocore/emperor/subscribers","subscription_url":"https://api.github.com/repos/biocore/emperor/subscription","commits_url":"https://api.github.com/repos/biocore/emperor/commits{/sha}","git_commits_url":"https://api.github.com/repos/biocore/emperor/git/commits{/sha}","comments_url":"https://api.github.com/repos/biocore/emperor/comments{/number}","issue_comment_url":"https://api.github.com/repos/biocore/emperor/issues/comments{/number}","contents_url":"https://api.github.com/repos/biocore/emperor/contents/{+path}","compare_url":"https://api.github.com/repos/biocore/emperor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/biocore/emperor/merges","archive_url":"https://api.github.com/repos/biocore/emperor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/biocore/emperor/downloads","issues_url":"https://api.github.com/repos/biocore/emperor/issues{/number}","pulls_url":"https://api.github.com/repos/biocore/emperor/pulls{/number}","milestones_url":"https://api.github.com/repos/biocore/emperor/milestones{/number}","notifications_url":"https://api.github.com/repos/biocore/emperor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/biocore/emperor/labels{/name}","releases_url":"https://api.github.com/repos/biocore/emperor/releases{/id}","deployments_url":"https://api.github.com/repos/biocore/emperor/deployments","created_at":"2013-01-22T18:27:18Z","updated_at":"2016-02-18T17:53:02Z","pushed_at":"2016-04-16T14:40:00Z","git_url":"git://github.com/biocore/emperor.git","ssh_url":"git@github.com:biocore/emperor.git","clone_url":"https://github.com/biocore/emperor.git","svn_url":"https://github.com/biocore/emperor","homepage":"http://emperor.microbio.me","size":9973,"stargazers_count":30,"watchers_count":30,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":25,"mirror_url":null,"open_issues_count":85,"forks":25,"open_issues":85,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/biocore/emperor/pulls/456"},"html":{"href":"https://github.com/biocore/emperor/pull/456"},"issue":{"href":"https://api.github.com/repos/biocore/emperor/issues/456"},"comments":{"href":"https://api.github.com/repos/biocore/emperor/issues/456/comments"},"review_comments":{"href":"https://api.github.com/repos/biocore/emperor/pulls/456/comments"},"review_comment":{"href":"https://api.github.com/repos/biocore/emperor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/biocore/emperor/pulls/456/commits"},"statuses":{"href":"https://api.github.com/repos/biocore/emperor/statuses/c8896fbb1b35090514974c949912f38de068eb3b"}}}}