{"push_id":1413796114,"size":6,"distinct_size":6,"ref":"refs/heads/feature/enum-uniqueness","head":"e91de55e28f3089b18e1496d96744775dff3b043","before":"e171515b8faad1a66d46691a56a4e069ed454b01","commits":[{"sha":"91288524c5085920857fb22d0a7759f9e4a41f84","author":{"name":"Adam Roben","email":"50deb78d4601f4b197cde493023ef6c76db172af@roben.org"},"message":"Respect DisabledByDefault in parent configs\n\nd956705defbe85037bd0c2dd8ec5ab0ee4398985 changed Config initialization\nsuch that Config#deprecation_check was called before resolving\ninheritance. Config#deprecation_check causes Config#for_all_cops to be\nlazily initialized to a new hash disconnected from Config's primary\nhash. Config#for_all_cops would thus not reflect any settings inherited\nfrom parent configs.\n\nEssentially, it's an error for Config#for_all_cops to be called before\ninheritance is resolved. Perhaps this code could be made more robust.\nFor now I've just moved the deprecation check after resolving\ninheritance as it was before d956705defbe85037bd0c2dd8ec5ab0ee4398985.","distinct":true,"url":"https://api.github.com/repos/olliebennett/rubocop/commits/91288524c5085920857fb22d0a7759f9e4a41f84"},{"sha":"306b0d6fa80052cb3eec612c638424d8e6e222e1","author":{"name":"Jonas Arvidsson","email":"e068a37d26ac79269eef2899b533a36db3c6cf79@gmail.com"},"message":"[Fix #3568] Detect style while handling offense in VariableNumber\n\nWhen the variable name doesn't match the configured style, we should\ndetect which style is used so that the right information is\ngenerated in .rubocop_todo.yml.","distinct":true,"url":"https://api.github.com/repos/olliebennett/rubocop/commits/306b0d6fa80052cb3eec612c638424d8e6e222e1"},{"sha":"1c79633195b44c1802628273b089f1722a2ad44c","author":{"name":"Ana María Martínez Gómez","email":"b70999b43294518f0e4b36588c97d5dd9364caf2@suse.de"},"message":"Add more test cases for TernaryParentheses cop\n\nAdd tests for the TernaryParentheses cop to cover the case that was\nfailing in https://github.com/bbatsov/rubocop/issues/3687.\nIt has already been fixed but there were no tests for this case.","distinct":true,"url":"https://api.github.com/repos/olliebennett/rubocop/commits/1c79633195b44c1802628273b089f1722a2ad44c"},{"sha":"797e56fe19e800034325621584f7c9e13e14c37c","author":{"name":"Ana María Martínez Gómez","email":"b70999b43294518f0e4b36588c97d5dd9364caf2@suse.de"},"message":"Fix non-autocorrected offenses wrong tested\n\nSome cases in the ternary_parentheses_spec.rb are tested as\nautocorrected with the expression corrected being the same as the\noriginal one. This is actually because it is not corrected and it\nshould be tested like an uncorrected case.","distinct":true,"url":"https://api.github.com/repos/olliebennett/rubocop/commits/797e56fe19e800034325621584f7c9e13e14c37c"},{"sha":"b85ad795309f7e381dbee6936d46e321e401fc51","author":{"name":"Ana María Martínez Gómez","email":"b70999b43294518f0e4b36588c97d5dd9364caf2@suse.de"},"message":"Avoid that uncorrected offenses are tested wrongly\n\nAvoid that uncorrected offenses are tested as corrected offenses with\nthe the corrected expression being the same as the original one for the\nTernaryParenthesis cop.","distinct":true,"url":"https://api.github.com/repos/olliebennett/rubocop/commits/b85ad795309f7e381dbee6936d46e321e401fc51"},{"sha":"e91de55e28f3089b18e1496d96744775dff3b043","author":{"name":"Ollie Bennett","email":"99521cbcf8bdf49f7d71dcdf51d7289ebf55d9d6@gmail.com"},"message":"[Fix #3723] Add new Rails/EnumUniqueness cop\n\nThis introduces a new cop which identifies any usage of duplicate values in hash-syntax enum definitions in Rails models.\n\nFor example, the following can lead to an ambiguous \"status\" for the model:\nenum status: { active: 4, archived: 4 }\n\nAn enum in Rails can be defined either as an array or a hash with specific integer keys defined.\nSee: http://edgeapi.rubyonrails.org/classes/ActiveRecord/Enum.html\n\nenum status: [ :active, :archived ]\nenum status: { active: 0, archived: 1 }\n\nWith the latter syntax, it's possible to accidentally specify duplicate keys:\n\nenum status: { active: 4, archived: 4 }\n\nBugs resulting from this can be hard to identify.","distinct":true,"url":"https://api.github.com/repos/olliebennett/rubocop/commits/e91de55e28f3089b18e1496d96744775dff3b043"}]}
{"actor":{"display_login":"olliebennett"}}