{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/charts/pulls/comments/77550248","id":77550248,"diff_hunk":"@@ -0,0 +1,75 @@\n+apiVersion: apps/v1alpha1\n+kind: PetSet\n+metadata:\n+  name: \"{{ printf \"%s-data-%s\" .Release.Name .Values.Name | trunc 24 }}\"\n+  labels:\n+    heritage: {{.Release.Service | quote }}\n+    release: {{.Release.Name | quote }}\n+    chart: \"{{.Chart.Name}}-{{.Chart.Version}}\"\n+    component: \"{{.Release.Name}}-{{.Values.Component}}\"\n+    type: data\n+  annotations:\n+    helm.sh/created: {{.Release.Time.Seconds | quote }}\n+spec:\n+  serviceName: \"{{ printf \"%s-data-%s\" .Release.Name .Values.Name | trunc 24 }}\"\n+  replicas: {{default 3 .Values.DataReplicas | quote }}\n+  template:\n+    metadata:\n+      labels:\n+        heritage: {{.Release.Service | quote }}\n+        release: {{.Release.Name | quote }}\n+        chart: \"{{.Chart.Name}}-{{.Chart.Version}}\"\n+        component: \"{{.Release.Name}}-{{.Values.Component}}\"\n+        type: data\n+      annotations:\n+        helm.sh/created: {{.Release.Time.Seconds | quote }}\n+        pod.alpha.kubernetes.io/initialized: \"true\"\n+    spec:\n+      serviceAccountName: \"{{ printf \"%s-%s\" .Release.Name .Values.Name | trunc 24 }}\"\n+      containers:","path":"incubator/elasticsearch/templates/elasticsearch-data-petset.yaml","position":29,"original_position":29,"commit_id":"f9497bf06614c94fe2902a4c27df3ced63d532d1","original_commit_id":"f9497bf06614c94fe2902a4c27df3ced63d532d1","user":{"login":"chrislovecnm","id":335402,"avatar_url":"https://avatars.githubusercontent.com/u/335402?v=3","gravatar_id":"","url":"https://api.github.com/users/chrislovecnm","html_url":"https://github.com/chrislovecnm","followers_url":"https://api.github.com/users/chrislovecnm/followers","following_url":"https://api.github.com/users/chrislovecnm/following{/other_user}","gists_url":"https://api.github.com/users/chrislovecnm/gists{/gist_id}","starred_url":"https://api.github.com/users/chrislovecnm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrislovecnm/subscriptions","organizations_url":"https://api.github.com/users/chrislovecnm/orgs","repos_url":"https://api.github.com/users/chrislovecnm/repos","events_url":"https://api.github.com/users/chrislovecnm/events{/privacy}","received_events_url":"https://api.github.com/users/chrislovecnm/received_events","type":"User","site_admin":false},"body":"Same comments in regards to min and max heap.  Also security context.","created_at":"2016-09-05T18:44:58Z","updated_at":"2016-09-05T18:44:58Z","html_url":"https://github.com/kubernetes/charts/pull/58#discussion_r77550248","pull_request_url":"https://api.github.com/repos/kubernetes/charts/pulls/58","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/comments/77550248"},"html":{"href":"https://github.com/kubernetes/charts/pull/58#discussion_r77550248"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/58"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/charts/pulls/58","id":83924284,"html_url":"https://github.com/kubernetes/charts/pull/58","diff_url":"https://github.com/kubernetes/charts/pull/58.diff","patch_url":"https://github.com/kubernetes/charts/pull/58.patch","issue_url":"https://api.github.com/repos/kubernetes/charts/issues/58","number":58,"state":"open","locked":false,"title":"Adds multi-role elasticsearch cluster chart #petset","user":{"login":"simonswine","id":223048,"avatar_url":"https://avatars.githubusercontent.com/u/223048?v=3","gravatar_id":"","url":"https://api.github.com/users/simonswine","html_url":"https://github.com/simonswine","followers_url":"https://api.github.com/users/simonswine/followers","following_url":"https://api.github.com/users/simonswine/following{/other_user}","gists_url":"https://api.github.com/users/simonswine/gists{/gist_id}","starred_url":"https://api.github.com/users/simonswine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonswine/subscriptions","organizations_url":"https://api.github.com/users/simonswine/orgs","repos_url":"https://api.github.com/users/simonswine/repos","events_url":"https://api.github.com/users/simonswine/events{/privacy}","received_events_url":"https://api.github.com/users/simonswine/received_events","type":"User","site_admin":false},"body":"This image is using Fabric8's great work around the [kubernetes plugin](https://github.com/fabric8io/elasticsearch-cloud-kubernetes) for elasticsearch and their [image](https://hub.docker.com/r/fabric8/elasticsearch-k8s/) as parent. \r\n\r\nThe PetSet for data nodes is able scale down without data loss (cluster will move data before shutting an instance down). This is implemeted by a simple lifecycle hook:\r\n\r\nhttps://github.com/jetstack/elasticsearch-pet/blob/master/pre-stop-hook.sh\r\n\r\nAs this is the first chart I have written, it's likely that not everything is according to the standards...\r\n\r\nHappy if you could review/test that chart ","created_at":"2016-09-04T14:24:08Z","updated_at":"2016-09-05T18:44:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"637bc0482f079c6ea4df1723f9ef7dc0b874694a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/charts/pulls/58/commits","review_comments_url":"https://api.github.com/repos/kubernetes/charts/pulls/58/comments","review_comment_url":"https://api.github.com/repos/kubernetes/charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/charts/issues/58/comments","statuses_url":"https://api.github.com/repos/kubernetes/charts/statuses/f9497bf06614c94fe2902a4c27df3ced63d532d1","head":{"label":"simonswine:elasticsearch-pet","ref":"elasticsearch-pet","sha":"f9497bf06614c94fe2902a4c27df3ced63d532d1","user":{"login":"simonswine","id":223048,"avatar_url":"https://avatars.githubusercontent.com/u/223048?v=3","gravatar_id":"","url":"https://api.github.com/users/simonswine","html_url":"https://github.com/simonswine","followers_url":"https://api.github.com/users/simonswine/followers","following_url":"https://api.github.com/users/simonswine/following{/other_user}","gists_url":"https://api.github.com/users/simonswine/gists{/gist_id}","starred_url":"https://api.github.com/users/simonswine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonswine/subscriptions","organizations_url":"https://api.github.com/users/simonswine/orgs","repos_url":"https://api.github.com/users/simonswine/repos","events_url":"https://api.github.com/users/simonswine/events{/privacy}","received_events_url":"https://api.github.com/users/simonswine/received_events","type":"User","site_admin":false},"repo":{"id":67306470,"name":"kubernetes-charts","full_name":"simonswine/kubernetes-charts","owner":{"login":"simonswine","id":223048,"avatar_url":"https://avatars.githubusercontent.com/u/223048?v=3","gravatar_id":"","url":"https://api.github.com/users/simonswine","html_url":"https://github.com/simonswine","followers_url":"https://api.github.com/users/simonswine/followers","following_url":"https://api.github.com/users/simonswine/following{/other_user}","gists_url":"https://api.github.com/users/simonswine/gists{/gist_id}","starred_url":"https://api.github.com/users/simonswine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonswine/subscriptions","organizations_url":"https://api.github.com/users/simonswine/orgs","repos_url":"https://api.github.com/users/simonswine/repos","events_url":"https://api.github.com/users/simonswine/events{/privacy}","received_events_url":"https://api.github.com/users/simonswine/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/simonswine/kubernetes-charts","description":"Curated applications for Kubernetes using Helm charts with integrated Deployment Manager templates","fork":true,"url":"https://api.github.com/repos/simonswine/kubernetes-charts","forks_url":"https://api.github.com/repos/simonswine/kubernetes-charts/forks","keys_url":"https://api.github.com/repos/simonswine/kubernetes-charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simonswine/kubernetes-charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simonswine/kubernetes-charts/teams","hooks_url":"https://api.github.com/repos/simonswine/kubernetes-charts/hooks","issue_events_url":"https://api.github.com/repos/simonswine/kubernetes-charts/issues/events{/number}","events_url":"https://api.github.com/repos/simonswine/kubernetes-charts/events","assignees_url":"https://api.github.com/repos/simonswine/kubernetes-charts/assignees{/user}","branches_url":"https://api.github.com/repos/simonswine/kubernetes-charts/branches{/branch}","tags_url":"https://api.github.com/repos/simonswine/kubernetes-charts/tags","blobs_url":"https://api.github.com/repos/simonswine/kubernetes-charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simonswine/kubernetes-charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simonswine/kubernetes-charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/simonswine/kubernetes-charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simonswine/kubernetes-charts/statuses/{sha}","languages_url":"https://api.github.com/repos/simonswine/kubernetes-charts/languages","stargazers_url":"https://api.github.com/repos/simonswine/kubernetes-charts/stargazers","contributors_url":"https://api.github.com/repos/simonswine/kubernetes-charts/contributors","subscribers_url":"https://api.github.com/repos/simonswine/kubernetes-charts/subscribers","subscription_url":"https://api.github.com/repos/simonswine/kubernetes-charts/subscription","commits_url":"https://api.github.com/repos/simonswine/kubernetes-charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/simonswine/kubernetes-charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/simonswine/kubernetes-charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/simonswine/kubernetes-charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/simonswine/kubernetes-charts/contents/{+path}","compare_url":"https://api.github.com/repos/simonswine/kubernetes-charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simonswine/kubernetes-charts/merges","archive_url":"https://api.github.com/repos/simonswine/kubernetes-charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simonswine/kubernetes-charts/downloads","issues_url":"https://api.github.com/repos/simonswine/kubernetes-charts/issues{/number}","pulls_url":"https://api.github.com/repos/simonswine/kubernetes-charts/pulls{/number}","milestones_url":"https://api.github.com/repos/simonswine/kubernetes-charts/milestones{/number}","notifications_url":"https://api.github.com/repos/simonswine/kubernetes-charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simonswine/kubernetes-charts/labels{/name}","releases_url":"https://api.github.com/repos/simonswine/kubernetes-charts/releases{/id}","deployments_url":"https://api.github.com/repos/simonswine/kubernetes-charts/deployments","created_at":"2016-09-03T18:51:37Z","updated_at":"2016-09-03T18:53:35Z","pushed_at":"2016-09-03T20:22:03Z","git_url":"git://github.com/simonswine/kubernetes-charts.git","ssh_url":"git@github.com:simonswine/kubernetes-charts.git","clone_url":"https://github.com/simonswine/kubernetes-charts.git","svn_url":"https://github.com/simonswine/kubernetes-charts","homepage":"","size":167,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"1f7b16a9edb8b957175f51fe2bc93336f63c7ca0","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":46806184,"name":"charts","full_name":"kubernetes/charts","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/charts","description":"Curated applications for Kubernetes using Helm charts with integrated Deployment Manager templates","fork":false,"url":"https://api.github.com/repos/kubernetes/charts","forks_url":"https://api.github.com/repos/kubernetes/charts/forks","keys_url":"https://api.github.com/repos/kubernetes/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/charts/teams","hooks_url":"https://api.github.com/repos/kubernetes/charts/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/charts/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/charts/events","assignees_url":"https://api.github.com/repos/kubernetes/charts/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/charts/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/charts/tags","blobs_url":"https://api.github.com/repos/kubernetes/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/charts/languages","stargazers_url":"https://api.github.com/repos/kubernetes/charts/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/charts/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/charts/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/charts/subscription","commits_url":"https://api.github.com/repos/kubernetes/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/charts/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/charts/merges","archive_url":"https://api.github.com/repos/kubernetes/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/charts/downloads","issues_url":"https://api.github.com/repos/kubernetes/charts/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/charts/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/charts/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/charts/deployments","created_at":"2015-11-24T17:05:28Z","updated_at":"2016-09-03T00:29:23Z","pushed_at":"2016-09-05T09:12:56Z","git_url":"git://github.com/kubernetes/charts.git","ssh_url":"git@github.com:kubernetes/charts.git","clone_url":"https://github.com/kubernetes/charts.git","svn_url":"https://github.com/kubernetes/charts","homepage":"","size":427,"stargazers_count":38,"watchers_count":38,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":16,"forks":33,"open_issues":16,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/58"},"html":{"href":"https://github.com/kubernetes/charts/pull/58"},"issue":{"href":"https://api.github.com/repos/kubernetes/charts/issues/58"},"comments":{"href":"https://api.github.com/repos/kubernetes/charts/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/charts/statuses/f9497bf06614c94fe2902a4c27df3ced63d532d1"}}}}
{"actor":{"display_login":"chrislovecnm"}}