{"action":"created","comment":{"url":"https://api.github.com/repos/openssl/openssl/pulls/comments/55258298","id":55258298,"diff_hunk":"@@ -603,10 +603,28 @@ sub testssl {\n \t}\n     };\n \n+    subtest 'SNI tests' => sub {\n+\n+\tplan tests => 7;\n+\n+      SKIP: {\n+\t  skip \"TLSv1.0 is not supported by this OpenSSL build\", 7\n+\t      if $no_tls1;\n+\n+\t  ok(run(test([@ssltest, \"-bio_pair\", \"-tls1\", \"-sn_client\", \"foo\"])));\n+\t  ok(run(test([@ssltest, \"-bio_pair\", \"-tls1\", \"-sn_server1\", \"foo\"])));\n+\t  ok(run(test([@ssltest, \"-bio_pair\", \"-tls1\", \"-sn_client\", \"foo\", \"-sn_server1\", \"foo\", \"-sn_expect1\"])));\n+\t  ok(run(test([@ssltest, \"-bio_pair\", \"-tls1\", \"-sn_client\", \"foo\", \"-sn_server1\", \"bar\", \"-sn_expect1\"])));\n+\t  ok(run(test([@ssltest, \"-bio_pair\", \"-tls1\", \"-sn_client\", \"foo\", \"-sn_server1\", \"foo\", \"-sn_server2\", \"bar\", \"-sn_expect1\"])));\n+\t  ok(run(test([@ssltest, \"-bio_pair\", \"-tls1\", \"-sn_client\", \"bar\", \"-sn_server1\", \"foo\", \"-sn_server2\", \"bar\", \"-sn_expect2\"])));\n+\t  ok(run(test([@ssltest, \"-bio_pair\", \"-tls1\", \"-sn_client\", \"foobar\", \"-sn_server1\", \"foo\", \"-sn_server2\", \"bar\", \"-sn_expect1\"])));","path":"test/recipes/80-test_ssl.t","position":27,"original_position":27,"commit_id":"2f635844607ae4b1bacb3f8fb1620e4fe2a69b27","original_commit_id":"2f635844607ae4b1bacb3f8fb1620e4fe2a69b27","user":{"login":"ekasper","id":7046250,"avatar_url":"https://avatars.githubusercontent.com/u/7046250?v=3","gravatar_id":"","url":"https://api.github.com/users/ekasper","html_url":"https://github.com/ekasper","followers_url":"https://api.github.com/users/ekasper/followers","following_url":"https://api.github.com/users/ekasper/following{/other_user}","gists_url":"https://api.github.com/users/ekasper/gists{/gist_id}","starred_url":"https://api.github.com/users/ekasper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekasper/subscriptions","organizations_url":"https://api.github.com/users/ekasper/orgs","repos_url":"https://api.github.com/users/ekasper/repos","events_url":"https://api.github.com/users/ekasper/events{/privacy}","received_events_url":"https://api.github.com/users/ekasper/received_events","type":"User","site_admin":false},"body":"Hm, but of course, here we're just testing the choice of ssltest.c, so perhaps just omit this test?","created_at":"2016-03-07T19:34:59Z","updated_at":"2016-03-07T19:34:59Z","html_url":"https://github.com/openssl/openssl/pull/787#discussion_r55258298","pull_request_url":"https://api.github.com/repos/openssl/openssl/pulls/787","_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments/55258298"},"html":{"href":"https://github.com/openssl/openssl/pull/787#discussion_r55258298"},"pull_request":{"href":"https://api.github.com/repos/openssl/openssl/pulls/787"}}},"pull_request":{"url":"https://api.github.com/repos/openssl/openssl/pulls/787","id":61729269,"html_url":"https://github.com/openssl/openssl/pull/787","diff_url":"https://github.com/openssl/openssl/pull/787.diff","patch_url":"https://github.com/openssl/openssl/pull/787.patch","issue_url":"https://api.github.com/repos/openssl/openssl/issues/787","number":787,"state":"open","locked":false,"title":"Fix ALPN","user":{"login":"tmshort","id":10981912,"avatar_url":"https://avatars.githubusercontent.com/u/10981912?v=3","gravatar_id":"","url":"https://api.github.com/users/tmshort","html_url":"https://github.com/tmshort","followers_url":"https://api.github.com/users/tmshort/followers","following_url":"https://api.github.com/users/tmshort/following{/other_user}","gists_url":"https://api.github.com/users/tmshort/gists{/gist_id}","starred_url":"https://api.github.com/users/tmshort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmshort/subscriptions","organizations_url":"https://api.github.com/users/tmshort/orgs","repos_url":"https://api.github.com/users/tmshort/repos","events_url":"https://api.github.com/users/tmshort/events{/privacy}","received_events_url":"https://api.github.com/users/tmshort/received_events","type":"User","site_admin":false},"body":"* Perform ALPN after the SNI callback; the SSL_CTX may change due to\r\n  that processing\r\n* Add flags to indicate that we actually sent ALPN, to properly error\r\n  out if unexpectedly received.\r\n* clean up ssl3_free() no need to explicitly clear when doing memset\r\n* size_t-ify ALPN/NPN code\r\n* document ALPN functions","created_at":"2016-03-04T15:45:45Z","updated_at":"2016-03-07T19:34:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"71f58bdce78666ea01fbafc689e0d0c3970ebd94","assignee":{"login":"richsalz","id":7332500,"avatar_url":"https://avatars.githubusercontent.com/u/7332500?v=3","gravatar_id":"","url":"https://api.github.com/users/richsalz","html_url":"https://github.com/richsalz","followers_url":"https://api.github.com/users/richsalz/followers","following_url":"https://api.github.com/users/richsalz/following{/other_user}","gists_url":"https://api.github.com/users/richsalz/gists{/gist_id}","starred_url":"https://api.github.com/users/richsalz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richsalz/subscriptions","organizations_url":"https://api.github.com/users/richsalz/orgs","repos_url":"https://api.github.com/users/richsalz/repos","events_url":"https://api.github.com/users/richsalz/events{/privacy}","received_events_url":"https://api.github.com/users/richsalz/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/openssl/openssl/pulls/787/commits","review_comments_url":"https://api.github.com/repos/openssl/openssl/pulls/787/comments","review_comment_url":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openssl/openssl/issues/787/comments","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/2f635844607ae4b1bacb3f8fb1620e4fe2a69b27","head":{"label":"akamai:tshort-alpn","ref":"tshort-alpn","sha":"2f635844607ae4b1bacb3f8fb1620e4fe2a69b27","user":{"login":"akamai","id":7504551,"avatar_url":"https://avatars.githubusercontent.com/u/7504551?v=3","gravatar_id":"","url":"https://api.github.com/users/akamai","html_url":"https://github.com/akamai","followers_url":"https://api.github.com/users/akamai/followers","following_url":"https://api.github.com/users/akamai/following{/other_user}","gists_url":"https://api.github.com/users/akamai/gists{/gist_id}","starred_url":"https://api.github.com/users/akamai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akamai/subscriptions","organizations_url":"https://api.github.com/users/akamai/orgs","repos_url":"https://api.github.com/users/akamai/repos","events_url":"https://api.github.com/users/akamai/events{/privacy}","received_events_url":"https://api.github.com/users/akamai/received_events","type":"Organization","site_admin":false},"repo":{"id":19614645,"name":"openssl","full_name":"akamai/openssl","owner":{"login":"akamai","id":7504551,"avatar_url":"https://avatars.githubusercontent.com/u/7504551?v=3","gravatar_id":"","url":"https://api.github.com/users/akamai","html_url":"https://github.com/akamai","followers_url":"https://api.github.com/users/akamai/followers","following_url":"https://api.github.com/users/akamai/following{/other_user}","gists_url":"https://api.github.com/users/akamai/gists{/gist_id}","starred_url":"https://api.github.com/users/akamai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akamai/subscriptions","organizations_url":"https://api.github.com/users/akamai/orgs","repos_url":"https://api.github.com/users/akamai/repos","events_url":"https://api.github.com/users/akamai/events{/privacy}","received_events_url":"https://api.github.com/users/akamai/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akamai/openssl","description":"Akamai fork of openssl master.","fork":true,"url":"https://api.github.com/repos/akamai/openssl","forks_url":"https://api.github.com/repos/akamai/openssl/forks","keys_url":"https://api.github.com/repos/akamai/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akamai/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akamai/openssl/teams","hooks_url":"https://api.github.com/repos/akamai/openssl/hooks","issue_events_url":"https://api.github.com/repos/akamai/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/akamai/openssl/events","assignees_url":"https://api.github.com/repos/akamai/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/akamai/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/akamai/openssl/tags","blobs_url":"https://api.github.com/repos/akamai/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akamai/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akamai/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/akamai/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akamai/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/akamai/openssl/languages","stargazers_url":"https://api.github.com/repos/akamai/openssl/stargazers","contributors_url":"https://api.github.com/repos/akamai/openssl/contributors","subscribers_url":"https://api.github.com/repos/akamai/openssl/subscribers","subscription_url":"https://api.github.com/repos/akamai/openssl/subscription","commits_url":"https://api.github.com/repos/akamai/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/akamai/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/akamai/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/akamai/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/akamai/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/akamai/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akamai/openssl/merges","archive_url":"https://api.github.com/repos/akamai/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akamai/openssl/downloads","issues_url":"https://api.github.com/repos/akamai/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/akamai/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/akamai/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/akamai/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akamai/openssl/labels{/name}","releases_url":"https://api.github.com/repos/akamai/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/akamai/openssl/deployments","created_at":"2014-05-09T14:50:18Z","updated_at":"2016-01-12T00:11:46Z","pushed_at":"2016-03-07T18:25:30Z","git_url":"git://github.com/akamai/openssl.git","ssh_url":"git@github.com:akamai/openssl.git","clone_url":"https://github.com/akamai/openssl.git","svn_url":"https://github.com/akamai/openssl","homepage":"","size":85442,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"openssl:master","ref":"master","sha":"c6912adf0c07227b18be3d8ef12d92ad7fc4318a","user":{"login":"openssl","id":3279138,"avatar_url":"https://avatars.githubusercontent.com/u/3279138?v=3","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"repo":{"id":7634677,"name":"openssl","full_name":"openssl/openssl","owner":{"login":"openssl","id":3279138,"avatar_url":"https://avatars.githubusercontent.com/u/3279138?v=3","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openssl/openssl","description":"TLS/SSL and crypto library","fork":false,"url":"https://api.github.com/repos/openssl/openssl","forks_url":"https://api.github.com/repos/openssl/openssl/forks","keys_url":"https://api.github.com/repos/openssl/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openssl/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openssl/openssl/teams","hooks_url":"https://api.github.com/repos/openssl/openssl/hooks","issue_events_url":"https://api.github.com/repos/openssl/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/openssl/openssl/events","assignees_url":"https://api.github.com/repos/openssl/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/openssl/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/openssl/openssl/tags","blobs_url":"https://api.github.com/repos/openssl/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openssl/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openssl/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/openssl/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/openssl/openssl/languages","stargazers_url":"https://api.github.com/repos/openssl/openssl/stargazers","contributors_url":"https://api.github.com/repos/openssl/openssl/contributors","subscribers_url":"https://api.github.com/repos/openssl/openssl/subscribers","subscription_url":"https://api.github.com/repos/openssl/openssl/subscription","commits_url":"https://api.github.com/repos/openssl/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/openssl/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/openssl/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/openssl/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/openssl/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/openssl/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openssl/openssl/merges","archive_url":"https://api.github.com/repos/openssl/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openssl/openssl/downloads","issues_url":"https://api.github.com/repos/openssl/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/openssl/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/openssl/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/openssl/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openssl/openssl/labels{/name}","releases_url":"https://api.github.com/repos/openssl/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/openssl/openssl/deployments","created_at":"2013-01-15T22:34:48Z","updated_at":"2016-03-07T17:22:35Z","pushed_at":"2016-03-07T18:43:10Z","git_url":"git://github.com/openssl/openssl.git","ssh_url":"git@github.com:openssl/openssl.git","clone_url":"https://github.com/openssl/openssl.git","svn_url":"https://github.com/openssl/openssl","homepage":"https://www.openssl.org","size":91342,"stargazers_count":2243,"watchers_count":2243,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1296,"mirror_url":null,"open_issues_count":143,"forks":1296,"open_issues":143,"watchers":2243,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/787"},"html":{"href":"https://github.com/openssl/openssl/pull/787"},"issue":{"href":"https://api.github.com/repos/openssl/openssl/issues/787"},"comments":{"href":"https://api.github.com/repos/openssl/openssl/issues/787/comments"},"review_comments":{"href":"https://api.github.com/repos/openssl/openssl/pulls/787/comments"},"review_comment":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openssl/openssl/pulls/787/commits"},"statuses":{"href":"https://api.github.com/repos/openssl/openssl/statuses/2f635844607ae4b1bacb3f8fb1620e4fe2a69b27"}}}}