{"action":"created","issue":{"url":"https://api.github.com/repos/tensorflow/skflow/issues/140","repository_url":"https://api.github.com/repos/tensorflow/skflow","labels_url":"https://api.github.com/repos/tensorflow/skflow/issues/140/labels{/name}","comments_url":"https://api.github.com/repos/tensorflow/skflow/issues/140/comments","events_url":"https://api.github.com/repos/tensorflow/skflow/issues/140/events","html_url":"https://github.com/tensorflow/skflow/issues/140","id":139923798,"number":140,"title":"should text transformers return arrays?","user":{"login":"mheilman","id":181744,"avatar_url":"https://avatars.githubusercontent.com/u/181744?v=3","gravatar_id":"","url":"https://api.github.com/users/mheilman","html_url":"https://github.com/mheilman","followers_url":"https://api.github.com/users/mheilman/followers","following_url":"https://api.github.com/users/mheilman/following{/other_user}","gists_url":"https://api.github.com/users/mheilman/gists{/gist_id}","starred_url":"https://api.github.com/users/mheilman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mheilman/subscriptions","organizations_url":"https://api.github.com/users/mheilman/orgs","repos_url":"https://api.github.com/users/mheilman/repos","events_url":"https://api.github.com/users/mheilman/events{/privacy}","received_events_url":"https://api.github.com/users/mheilman/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-03-10T15:36:02Z","updated_at":"2016-10-26T04:29:27Z","closed_at":"2016-10-26T04:29:27Z","body":"The text transformations [currently return generators](https://github.com/tensorflow/skflow/blob/7a7bbcc8b47f54384a43494ac78083de9e3915e4/skflow/preprocessing/text.py#L181), but the sklearn [doc page for the TransformerMixin](http://scikit-learn.org/stable/modules/generated/sklearn.base.TransformerMixin.html) say transformers should return arrays.\r\n\r\nAlso, the skflow text classification example that uses `VocabularyProcessor` [converts the generator to an array](https://github.com/tensorflow/skflow/blob/7a7bbcc8b47f54384a43494ac78083de9e3915e4/examples/text_classification.py#L39).\r\n\r\nI think this means that `VocabularyProcessor` can't be used in a `Pipeline` (except maybe if one makes a generator to array transformer)."},"comment":{"url":"https://api.github.com/repos/tensorflow/skflow/issues/comments/256246725","html_url":"https://github.com/tensorflow/skflow/issues/140#issuecomment-256246725","issue_url":"https://api.github.com/repos/tensorflow/skflow/issues/140","id":256246725,"user":{"login":"ilblackdragon","id":175486,"avatar_url":"https://avatars.githubusercontent.com/u/175486?v=3","gravatar_id":"","url":"https://api.github.com/users/ilblackdragon","html_url":"https://github.com/ilblackdragon","followers_url":"https://api.github.com/users/ilblackdragon/followers","following_url":"https://api.github.com/users/ilblackdragon/following{/other_user}","gists_url":"https://api.github.com/users/ilblackdragon/gists{/gist_id}","starred_url":"https://api.github.com/users/ilblackdragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilblackdragon/subscriptions","organizations_url":"https://api.github.com/users/ilblackdragon/orgs","repos_url":"https://api.github.com/users/ilblackdragon/repos","events_url":"https://api.github.com/users/ilblackdragon/events{/privacy}","received_events_url":"https://api.github.com/users/ilblackdragon/received_events","type":"User","site_admin":false},"created_at":"2016-10-26T04:29:27Z","updated_at":"2016-10-26T04:29:27Z","body":"Processing code was removed from tensorflow in favor of future preprocessing tools and for now - scikit learn tools. Sorry!"}}
{"actor":{"display_login":"ilblackdragon"}}