{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/etcd/pulls/comments/84537402","pull_request_review_id":5312679,"id":84537402,"diff_hunk":"@@ -310,10 +320,24 @@ func runWatcher(eps []string) {\n \t\t\t\t\t\treturn\n \t\t\t\t\t}\n \t\t\t\t}\n-\t\t\t}(prefixes[i])\n+\t\t\t}(roundPrefix + \"-\" + prefixes[i])\n \t\t}\n \t}\n \twg.Wait()\n+\n+\t// cancel all watch channels\n+\tcancelc()\n+","path":"tools/functional-tester/etcd-runner/main.go","position":81,"original_position":81,"commit_id":"c6a8f767dc25ae44d6128b87d2c4bb274846b9f4","original_commit_id":"71225c2ac8b4d9df4f9e592dcb9211cdbe24cd5e","user":{"login":"sinsharat","id":20169156,"avatar_url":"https://avatars.githubusercontent.com/u/20169156?v=3","gravatar_id":"","url":"https://api.github.com/users/sinsharat","html_url":"https://github.com/sinsharat","followers_url":"https://api.github.com/users/sinsharat/followers","following_url":"https://api.github.com/users/sinsharat/following{/other_user}","gists_url":"https://api.github.com/users/sinsharat/gists{/gist_id}","starred_url":"https://api.github.com/users/sinsharat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinsharat/subscriptions","organizations_url":"https://api.github.com/users/sinsharat/orgs","repos_url":"https://api.github.com/users/sinsharat/repos","events_url":"https://api.github.com/users/sinsharat/events{/privacy}","received_events_url":"https://api.github.com/users/sinsharat/received_events","type":"User","site_admin":false},"body":"@xiang90 i tested, even after putting sleep as well still only few channels are closing rest are staying open. All of them are providing empty values though, whether opened or closed.","created_at":"2016-10-21T20:18:52Z","updated_at":"2016-10-21T20:18:52Z","html_url":"https://github.com/coreos/etcd/pull/6695#discussion_r84537402","pull_request_url":"https://api.github.com/repos/coreos/etcd/pulls/6695","_links":{"self":{"href":"https://api.github.com/repos/coreos/etcd/pulls/comments/84537402"},"html":{"href":"https://github.com/coreos/etcd/pull/6695#discussion_r84537402"},"pull_request":{"href":"https://api.github.com/repos/coreos/etcd/pulls/6695"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/etcd/pulls/6695","id":90288755,"html_url":"https://github.com/coreos/etcd/pull/6695","diff_url":"https://github.com/coreos/etcd/pull/6695.diff","patch_url":"https://github.com/coreos/etcd/pull/6695.patch","issue_url":"https://api.github.com/repos/coreos/etcd/issues/6695","number":6695,"state":"open","locked":false,"title":"etcd-runner: watcher runner respect rounds","user":{"login":"sinsharat","id":20169156,"avatar_url":"https://avatars.githubusercontent.com/u/20169156?v=3","gravatar_id":"","url":"https://api.github.com/users/sinsharat","html_url":"https://github.com/sinsharat","followers_url":"https://api.github.com/users/sinsharat/followers","following_url":"https://api.github.com/users/sinsharat/following{/other_user}","gists_url":"https://api.github.com/users/sinsharat/gists{/gist_id}","starred_url":"https://api.github.com/users/sinsharat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinsharat/subscriptions","organizations_url":"https://api.github.com/users/sinsharat/orgs","repos_url":"https://api.github.com/users/sinsharat/repos","events_url":"https://api.github.com/users/sinsharat/events{/privacy}","received_events_url":"https://api.github.com/users/sinsharat/received_events","type":"User","site_admin":false},"body":"made watcher runner respect the round functionality\r\n","created_at":"2016-10-20T21:56:25Z","updated_at":"2016-10-21T20:18:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6508c6290cc50e4baf55490729a25a08537bae1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/coreos/etcd/pulls/6695/commits","review_comments_url":"https://api.github.com/repos/coreos/etcd/pulls/6695/comments","review_comment_url":"https://api.github.com/repos/coreos/etcd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/etcd/issues/6695/comments","statuses_url":"https://api.github.com/repos/coreos/etcd/statuses/c6a8f767dc25ae44d6128b87d2c4bb274846b9f4","head":{"label":"sinsharat:watch_runner_respect_rounds","ref":"watch_runner_respect_rounds","sha":"c6a8f767dc25ae44d6128b87d2c4bb274846b9f4","user":{"login":"sinsharat","id":20169156,"avatar_url":"https://avatars.githubusercontent.com/u/20169156?v=3","gravatar_id":"","url":"https://api.github.com/users/sinsharat","html_url":"https://github.com/sinsharat","followers_url":"https://api.github.com/users/sinsharat/followers","following_url":"https://api.github.com/users/sinsharat/following{/other_user}","gists_url":"https://api.github.com/users/sinsharat/gists{/gist_id}","starred_url":"https://api.github.com/users/sinsharat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinsharat/subscriptions","organizations_url":"https://api.github.com/users/sinsharat/orgs","repos_url":"https://api.github.com/users/sinsharat/repos","events_url":"https://api.github.com/users/sinsharat/events{/privacy}","received_events_url":"https://api.github.com/users/sinsharat/received_events","type":"User","site_admin":false},"repo":{"id":67736780,"name":"etcd","full_name":"sinsharat/etcd","owner":{"login":"sinsharat","id":20169156,"avatar_url":"https://avatars.githubusercontent.com/u/20169156?v=3","gravatar_id":"","url":"https://api.github.com/users/sinsharat","html_url":"https://github.com/sinsharat","followers_url":"https://api.github.com/users/sinsharat/followers","following_url":"https://api.github.com/users/sinsharat/following{/other_user}","gists_url":"https://api.github.com/users/sinsharat/gists{/gist_id}","starred_url":"https://api.github.com/users/sinsharat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinsharat/subscriptions","organizations_url":"https://api.github.com/users/sinsharat/orgs","repos_url":"https://api.github.com/users/sinsharat/repos","events_url":"https://api.github.com/users/sinsharat/events{/privacy}","received_events_url":"https://api.github.com/users/sinsharat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sinsharat/etcd","description":"Distributed reliable key-value store for the most critical data of a distributed system","fork":true,"url":"https://api.github.com/repos/sinsharat/etcd","forks_url":"https://api.github.com/repos/sinsharat/etcd/forks","keys_url":"https://api.github.com/repos/sinsharat/etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sinsharat/etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sinsharat/etcd/teams","hooks_url":"https://api.github.com/repos/sinsharat/etcd/hooks","issue_events_url":"https://api.github.com/repos/sinsharat/etcd/issues/events{/number}","events_url":"https://api.github.com/repos/sinsharat/etcd/events","assignees_url":"https://api.github.com/repos/sinsharat/etcd/assignees{/user}","branches_url":"https://api.github.com/repos/sinsharat/etcd/branches{/branch}","tags_url":"https://api.github.com/repos/sinsharat/etcd/tags","blobs_url":"https://api.github.com/repos/sinsharat/etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sinsharat/etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sinsharat/etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/sinsharat/etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sinsharat/etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/sinsharat/etcd/languages","stargazers_url":"https://api.github.com/repos/sinsharat/etcd/stargazers","contributors_url":"https://api.github.com/repos/sinsharat/etcd/contributors","subscribers_url":"https://api.github.com/repos/sinsharat/etcd/subscribers","subscription_url":"https://api.github.com/repos/sinsharat/etcd/subscription","commits_url":"https://api.github.com/repos/sinsharat/etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/sinsharat/etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/sinsharat/etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/sinsharat/etcd/issues/comments{/number}","contents_url":"https://api.github.com/repos/sinsharat/etcd/contents/{+path}","compare_url":"https://api.github.com/repos/sinsharat/etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sinsharat/etcd/merges","archive_url":"https://api.github.com/repos/sinsharat/etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sinsharat/etcd/downloads","issues_url":"https://api.github.com/repos/sinsharat/etcd/issues{/number}","pulls_url":"https://api.github.com/repos/sinsharat/etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/sinsharat/etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/sinsharat/etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sinsharat/etcd/labels{/name}","releases_url":"https://api.github.com/repos/sinsharat/etcd/releases{/id}","deployments_url":"https://api.github.com/repos/sinsharat/etcd/deployments","created_at":"2016-09-08T20:11:20Z","updated_at":"2016-09-28T20:41:16Z","pushed_at":"2016-10-21T19:35:13Z","git_url":"git://github.com/sinsharat/etcd.git","ssh_url":"git@github.com:sinsharat/etcd.git","clone_url":"https://github.com/sinsharat/etcd.git","svn_url":"https://github.com/sinsharat/etcd","homepage":"https://coreos.com/etcd/docs/latest/","size":25323,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"1ad038d02e82bd2d8679080a97c8138b2ee0d505","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":11225014,"name":"etcd","full_name":"coreos/etcd","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/etcd","description":"Distributed reliable key-value store for the most critical data of a distributed system","fork":false,"url":"https://api.github.com/repos/coreos/etcd","forks_url":"https://api.github.com/repos/coreos/etcd/forks","keys_url":"https://api.github.com/repos/coreos/etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/etcd/teams","hooks_url":"https://api.github.com/repos/coreos/etcd/hooks","issue_events_url":"https://api.github.com/repos/coreos/etcd/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/etcd/events","assignees_url":"https://api.github.com/repos/coreos/etcd/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/etcd/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/etcd/tags","blobs_url":"https://api.github.com/repos/coreos/etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/etcd/languages","stargazers_url":"https://api.github.com/repos/coreos/etcd/stargazers","contributors_url":"https://api.github.com/repos/coreos/etcd/contributors","subscribers_url":"https://api.github.com/repos/coreos/etcd/subscribers","subscription_url":"https://api.github.com/repos/coreos/etcd/subscription","commits_url":"https://api.github.com/repos/coreos/etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/etcd/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/etcd/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/etcd/merges","archive_url":"https://api.github.com/repos/coreos/etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/etcd/downloads","issues_url":"https://api.github.com/repos/coreos/etcd/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/etcd/labels{/name}","releases_url":"https://api.github.com/repos/coreos/etcd/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/etcd/deployments","created_at":"2013-07-06T21:57:21Z","updated_at":"2016-10-21T17:59:10Z","pushed_at":"2016-10-21T19:47:27Z","git_url":"git://github.com/coreos/etcd.git","ssh_url":"git@github.com:coreos/etcd.git","clone_url":"https://github.com/coreos/etcd.git","svn_url":"https://github.com/coreos/etcd","homepage":"https://coreos.com/etcd/docs/latest/","size":32975,"stargazers_count":11175,"watchers_count":11175,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1986,"mirror_url":null,"open_issues_count":132,"forks":1986,"open_issues":132,"watchers":11175,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/etcd/pulls/6695"},"html":{"href":"https://github.com/coreos/etcd/pull/6695"},"issue":{"href":"https://api.github.com/repos/coreos/etcd/issues/6695"},"comments":{"href":"https://api.github.com/repos/coreos/etcd/issues/6695/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/etcd/pulls/6695/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/etcd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/etcd/pulls/6695/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/etcd/statuses/c6a8f767dc25ae44d6128b87d2c4bb274846b9f4"}}}}
{"actor":{"display_login":"sinsharat"}}