{"push_id":1289656228,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"5bc8888e7d7b3badb1499644c0b7818cdc47197d","before":"b71d7694ab2f480943bbd15afc088f8f2ea06ec5","commits":[{"sha":"5bc8888e7d7b3badb1499644c0b7818cdc47197d","author":{"name":"Ian Hickson","email":"668fd45181c31193793d12a7f2ecb1f2376600d1@hixie.ch"},"message":"Make tests more realistic (#5762)\n\nPreviously, pumpWidget() would do a partial pump (it didn't trigger\r\nTicker callbacks or post-frame callbacks), and pump() would do a full\r\npump. This patch brings them closer together. It also makes runApp run a\r\nfull actual frame, rather than skipping the transient callback part of\r\nthe frame logic. Having \"half-frames\" in the system was confusing and\r\ncould lead to bugs where code expecting to run before the next layout\r\npass didn't because a \"half-frame\" ran first.\r\n\r\nAlso, make Tickers start ticking in the frame that they were started in,\r\nif they were started during a frame. This means we no longer spin a\r\nframe for t=0, we jump straight to the first actual frame.\r\n\r\nOther changes in this patch:\r\n\r\n* rename WidgetsBinding._runApp to WidgetsBinding.attachRootWidget, so\r\n  that tests can use it to more accurately mock out runApp.\r\n\r\n* allow loadStructuredData to return synchronously.\r\n\r\n* make handleBeginFrame handle not being given a time stamp.\r\n\r\n* make DataPipeImageProvider.loadAsync protected (rather than private),\r\n  and document it. There wasn't really a reason for it to be private.\r\n\r\n* fix ImageConfiguration.toString.\r\n\r\n* introduce debugPrintBuildScope and debugPrintScheduleBuildForStacks,\r\n  which can help debug problems with widgets getting marked as dirty but\r\n  not cleaned.\r\n\r\n* make debugPrintRebuildDirtyWidgets say \"Building\" the first time and\r\n  \"Rebuilding\" the second, to make it clearer when a widget is first\r\n  created. This makes debugging widget lifecycle issues much easier.\r\n\r\n* make debugDumpApp more resilient.\r\n\r\n* debugPrintStack now takes a label that is printed before the stack.\r\n\r\n* improve the banner shown for debugPrintBeginFrameBanner.\r\n\r\n* various and sundry documentation fixes","distinct":true,"url":"https://api.github.com/repos/flutter/flutter/commits/5bc8888e7d7b3badb1499644c0b7818cdc47197d"}]}
{"actor":{"display_login":"Hixie"}}