{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/pulls/comments/83050741","pull_request_review_id":3915723,"id":83050741,"diff_hunk":"@@ -30,13 +30,17 @@ var isString = require('lodash').isString;\n  */\n function handleStringAsError(err, errorMessage) {\n   var fauxError = new Error();\n-  var errChecked = fauxError.stack;\n+  var fullStack = fauxError.stack.split('\\n');\n+  var cleanedStack = fullStack.slice(0, 1).concat(fullStack.slice(4));","path":"lib/error-handlers/string.js","position":6,"original_position":6,"commit_id":"0fecbb48b0c862efd115c2f82d2a58c8875c3778","original_commit_id":"0fecbb48b0c862efd115c2f82d2a58c8875c3778","user":{"login":"matthewloring","id":1485909,"avatar_url":"https://avatars.githubusercontent.com/u/1485909?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewloring","html_url":"https://github.com/matthewloring","followers_url":"https://api.github.com/users/matthewloring/followers","following_url":"https://api.github.com/users/matthewloring/following{/other_user}","gists_url":"https://api.github.com/users/matthewloring/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewloring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewloring/subscriptions","organizations_url":"https://api.github.com/users/matthewloring/orgs","repos_url":"https://api.github.com/users/matthewloring/repos","events_url":"https://api.github.com/users/matthewloring/events{/privacy}","received_events_url":"https://api.github.com/users/matthewloring/received_events","type":"User","site_admin":false},"body":"Slicing out particular numbers of stack frames could become incorrect as new functions are added. Could we add a test checking that the correct number of stack frames are omitted?","created_at":"2016-10-12T16:58:17Z","updated_at":"2016-10-12T16:58:24Z","html_url":"https://github.com/GoogleCloudPlatform/cloud-errors-nodejs/pull/63#discussion_r83050741","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/pulls/63","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/pulls/comments/83050741"},"html":{"href":"https://github.com/GoogleCloudPlatform/cloud-errors-nodejs/pull/63#discussion_r83050741"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/pulls/63"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/pulls/63","id":89043088,"html_url":"https://github.com/GoogleCloudPlatform/cloud-errors-nodejs/pull/63","diff_url":"https://github.com/GoogleCloudPlatform/cloud-errors-nodejs/pull/63.diff","patch_url":"https://github.com/GoogleCloudPlatform/cloud-errors-nodejs/pull/63.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/issues/63","number":63,"state":"closed","locked":false,"title":"Add error stack substitution to string handler","user":{"login":"cristiancavalli","id":4976075,"avatar_url":"https://avatars.githubusercontent.com/u/4976075?v=3","gravatar_id":"","url":"https://api.github.com/users/cristiancavalli","html_url":"https://github.com/cristiancavalli","followers_url":"https://api.github.com/users/cristiancavalli/followers","following_url":"https://api.github.com/users/cristiancavalli/following{/other_user}","gists_url":"https://api.github.com/users/cristiancavalli/gists{/gist_id}","starred_url":"https://api.github.com/users/cristiancavalli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cristiancavalli/subscriptions","organizations_url":"https://api.github.com/users/cristiancavalli/orgs","repos_url":"https://api.github.com/users/cristiancavalli/repos","events_url":"https://api.github.com/users/cristiancavalli/events{/privacy}","received_events_url":"https://api.github.com/users/cristiancavalli/received_events","type":"User","site_admin":false},"body":"Add logic to provide error stacks for basic non-\r\nerror string tokens given as error values. Update\r\nthe test-servers/manual_scaffold_server.js test\r\nfile to use this new pattern.\r\n\r\nRelated Issues:\r\nFixes #41  ","created_at":"2016-10-12T15:54:57Z","updated_at":"2016-10-12T16:58:24Z","closed_at":"2016-10-12T16:39:52Z","merged_at":"2016-10-12T16:39:52Z","merge_commit_sha":"78c6b5c42e3b6fa4dbc94265756a7ce059ee1ac3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/pulls/63/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/pulls/63/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/issues/63/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/statuses/0fecbb48b0c862efd115c2f82d2a58c8875c3778","head":{"label":"cristiancavalli:single_string_token","ref":"single_string_token","sha":"0fecbb48b0c862efd115c2f82d2a58c8875c3778","user":{"login":"cristiancavalli","id":4976075,"avatar_url":"https://avatars.githubusercontent.com/u/4976075?v=3","gravatar_id":"","url":"https://api.github.com/users/cristiancavalli","html_url":"https://github.com/cristiancavalli","followers_url":"https://api.github.com/users/cristiancavalli/followers","following_url":"https://api.github.com/users/cristiancavalli/following{/other_user}","gists_url":"https://api.github.com/users/cristiancavalli/gists{/gist_id}","starred_url":"https://api.github.com/users/cristiancavalli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cristiancavalli/subscriptions","organizations_url":"https://api.github.com/users/cristiancavalli/orgs","repos_url":"https://api.github.com/users/cristiancavalli/repos","events_url":"https://api.github.com/users/cristiancavalli/events{/privacy}","received_events_url":"https://api.github.com/users/cristiancavalli/received_events","type":"User","site_admin":false},"repo":{"id":63174673,"name":"cloud-errors-nodejs","full_name":"cristiancavalli/cloud-errors-nodejs","owner":{"login":"cristiancavalli","id":4976075,"avatar_url":"https://avatars.githubusercontent.com/u/4976075?v=3","gravatar_id":"","url":"https://api.github.com/users/cristiancavalli","html_url":"https://github.com/cristiancavalli","followers_url":"https://api.github.com/users/cristiancavalli/followers","following_url":"https://api.github.com/users/cristiancavalli/following{/other_user}","gists_url":"https://api.github.com/users/cristiancavalli/gists{/gist_id}","starred_url":"https://api.github.com/users/cristiancavalli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cristiancavalli/subscriptions","organizations_url":"https://api.github.com/users/cristiancavalli/orgs","repos_url":"https://api.github.com/users/cristiancavalli/repos","events_url":"https://api.github.com/users/cristiancavalli/events{/privacy}","received_events_url":"https://api.github.com/users/cristiancavalli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cristiancavalli/cloud-errors-nodejs","description":null,"fork":true,"url":"https://api.github.com/repos/cristiancavalli/cloud-errors-nodejs","forks_url":"https://api.github.com/repos/cristiancavalli/cloud-errors-nodejs/forks","keys_url":"https://api.github.com/repos/cristiancavalli/cloud-errors-nodejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cristiancavalli/cloud-errors-nodejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cristiancavalli/cloud-errors-nodejs/teams","hooks_url":"https://api.github.com/repos/cristiancavalli/cloud-errors-nodejs/hooks","issue_events_url":"https://api.github.com/repos/cristiancavalli/cloud-errors-nodejs/issues/events{/number}","events_url":"https://api.github.com/repos/cristiancavalli/cloud-errors-nodejs/events","assignees_url":"https://api.github.com/repos/cristiancavalli/cloud-errors-nodejs/assignees{/user}","branches_url":"https://api.github.com/repos/cristiancavalli/cloud-errors-nodejs/branches{/branch}","tags_url":"https://api.github.com/repos/cristiancavalli/cloud-errors-nodejs/tags","blobs_url":"https://api.github.com/repos/cristiancavalli/cloud-errors-nodejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cristiancavalli/cloud-errors-nodejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cristiancavalli/cloud-errors-nodejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/cristiancavalli/cloud-errors-nodejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cristiancavalli/cloud-errors-nodejs/statuses/{sha}","languages_url":"https://api.github.com/repos/cristiancavalli/cloud-errors-nodejs/languages","stargazers_url":"https://api.github.com/repos/cristiancavalli/cloud-errors-nodejs/stargazers","contributors_url":"https://api.github.com/repos/cristiancavalli/cloud-errors-nodejs/contributors","subscribers_url":"https://api.github.com/repos/cristiancavalli/cloud-errors-nodejs/subscribers","subscription_url":"https://api.github.com/repos/cristiancavalli/cloud-errors-nodejs/subscription","commits_url":"https://api.github.com/repos/cristiancavalli/cloud-errors-nodejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/cristiancavalli/cloud-errors-nodejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/cristiancavalli/cloud-errors-nodejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/cristiancavalli/cloud-errors-nodejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/cristiancavalli/cloud-errors-nodejs/contents/{+path}","compare_url":"https://api.github.com/repos/cristiancavalli/cloud-errors-nodejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cristiancavalli/cloud-errors-nodejs/merges","archive_url":"https://api.github.com/repos/cristiancavalli/cloud-errors-nodejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cristiancavalli/cloud-errors-nodejs/downloads","issues_url":"https://api.github.com/repos/cristiancavalli/cloud-errors-nodejs/issues{/number}","pulls_url":"https://api.github.com/repos/cristiancavalli/cloud-errors-nodejs/pulls{/number}","milestones_url":"https://api.github.com/repos/cristiancavalli/cloud-errors-nodejs/milestones{/number}","notifications_url":"https://api.github.com/repos/cristiancavalli/cloud-errors-nodejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cristiancavalli/cloud-errors-nodejs/labels{/name}","releases_url":"https://api.github.com/repos/cristiancavalli/cloud-errors-nodejs/releases{/id}","deployments_url":"https://api.github.com/repos/cristiancavalli/cloud-errors-nodejs/deployments","created_at":"2016-07-12T16:33:47Z","updated_at":"2016-07-12T16:33:48Z","pushed_at":"2016-10-12T16:01:54Z","git_url":"git://github.com/cristiancavalli/cloud-errors-nodejs.git","ssh_url":"git@github.com:cristiancavalli/cloud-errors-nodejs.git","clone_url":"https://github.com/cristiancavalli/cloud-errors-nodejs.git","svn_url":"https://github.com/cristiancavalli/cloud-errors-nodejs","homepage":null,"size":275,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"58b007642d15bd360913bef488c465f5be65f074","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":63088322,"name":"cloud-errors-nodejs","full_name":"GoogleCloudPlatform/cloud-errors-nodejs","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/cloud-errors-nodejs","description":"Node.js module for Google Stackdriver Error Reporting","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/deployments","created_at":"2016-07-11T17:32:41Z","updated_at":"2016-10-06T14:56:30Z","pushed_at":"2016-10-12T16:39:52Z","git_url":"git://github.com/GoogleCloudPlatform/cloud-errors-nodejs.git","ssh_url":"git@github.com:GoogleCloudPlatform/cloud-errors-nodejs.git","clone_url":"https://github.com/GoogleCloudPlatform/cloud-errors-nodejs.git","svn_url":"https://github.com/GoogleCloudPlatform/cloud-errors-nodejs","homepage":"https://cloud.google.com/error-reporting","size":286,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":6,"forks":7,"open_issues":6,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/pulls/63"},"html":{"href":"https://github.com/GoogleCloudPlatform/cloud-errors-nodejs/pull/63"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/issues/63"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-errors-nodejs/statuses/0fecbb48b0c862efd115c2f82d2a58c8875c3778"}}}}
{"actor":{"display_login":"matthewloring"}}