{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8285","repository_url":"https://api.github.com/repos/bitcoin/bitcoin","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8285/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8285/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8285/events","html_url":"https://github.com/bitcoin/bitcoin/pull/8285","id":162904464,"number":8285,"title":"windows: Add testnet link to installer","user":{"login":"laanwj","id":126646,"avatar_url":"https://avatars.githubusercontent.com/u/126646?v=3","gravatar_id":"","url":"https://api.github.com/users/laanwj","html_url":"https://github.com/laanwj","followers_url":"https://api.github.com/users/laanwj/followers","following_url":"https://api.github.com/users/laanwj/following{/other_user}","gists_url":"https://api.github.com/users/laanwj/gists{/gist_id}","starred_url":"https://api.github.com/users/laanwj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laanwj/subscriptions","organizations_url":"https://api.github.com/users/laanwj/orgs","repos_url":"https://api.github.com/users/laanwj/repos","events_url":"https://api.github.com/users/laanwj/events{/privacy}","received_events_url":"https://api.github.com/users/laanwj/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Build%20system","name":"Build system","color":"5319e7"},{"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Windows","name":"Windows","color":"884400"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/bitcoin/bitcoin/milestones/20","html_url":"https://github.com/bitcoin/bitcoin/milestones/0.13.0","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones/20/labels","id":1441894,"number":20,"title":"0.13.0","description":"","creator":{"login":"laanwj","id":126646,"avatar_url":"https://avatars.githubusercontent.com/u/126646?v=3","gravatar_id":"","url":"https://api.github.com/users/laanwj","html_url":"https://github.com/laanwj","followers_url":"https://api.github.com/users/laanwj/followers","following_url":"https://api.github.com/users/laanwj/following{/other_user}","gists_url":"https://api.github.com/users/laanwj/gists{/gist_id}","starred_url":"https://api.github.com/users/laanwj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laanwj/subscriptions","organizations_url":"https://api.github.com/users/laanwj/orgs","repos_url":"https://api.github.com/users/laanwj/repos","events_url":"https://api.github.com/users/laanwj/events{/privacy}","received_events_url":"https://api.github.com/users/laanwj/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":21,"state":"open","created_at":"2015-12-03T11:07:58Z","updated_at":"2016-06-30T15:16:17Z","due_on":null,"closed_at":null},"comments":10,"created_at":"2016-06-29T11:40:50Z","updated_at":"2016-06-30T16:54:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8285","html_url":"https://github.com/bitcoin/bitcoin/pull/8285","diff_url":"https://github.com/bitcoin/bitcoin/pull/8285.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/8285.patch"},"body":"Implements #8251\r\n\r\n![testnet](https://cloud.githubusercontent.com/assets/126646/16450613/4021cdde-3dfe-11e6-8066-318832a709ed.png)\r\n\r\n@jonasschnelli I'm not sure what tooling you used in 4c23743, but for some reason icotool, even though I've used the same sizes/bit depths as you, manages to produce a huge icon file:\r\n```\r\n  57964 Feb 18  2015 bitcoin.ico\r\n 295606 Jun 29 13:01 bitcoin_testnet.ico\r\n```\r\n\r\n```\r\n$ icotool -l bitcoin.ico > /tmp/bitcoin.lst\r\nbitcoin.ico: clr_important field in bitmap should be zero\r\nbitcoin.ico: clr_important field in bitmap should be zero\r\nbitcoin.ico: clr_important field in bitmap should be zero\r\n$ icotool -l bitcoin_testnet.ico > /tmp/bitcoin_testnet.lst\r\n$ diff -du /tmp/bitcoin.lst /tmp/bitcoin_testnet.lst\r\n[no output]\r\n$ cat /tmp/bitcoin.lst\r\n--icon --index=1 --width=48 --height=48 --bit-depth=4 --palette-size=16\r\n--icon --index=2 --width=32 --height=32 --bit-depth=4 --palette-size=16\r\n--icon --index=3 --width=16 --height=16 --bit-depth=4 --palette-size=16\r\n--icon --index=4 --width=48 --height=48 --bit-depth=8 --palette-size=256\r\n--icon --index=5 --width=32 --height=32 --bit-depth=8 --palette-size=256\r\n--icon --index=6 --width=16 --height=16 --bit-depth=8 --palette-size=256\r\n--icon --index=7 --width=256 --height=256 --bit-depth=32 --palette-size=0\r\n--icon --index=8 --width=48 --height=48 --bit-depth=32 --palette-size=0\r\n--icon --index=9 --width=32 --height=32 --bit-depth=32 --palette-size=0\r\n--icon --index=10 --width=16 --height=16 --bit-depth=32 --palette-size=0\r\n```\r\nComparing binary, it looks like it's not using PNG compression inside the icon.\r\n\r\nIt also looks like it's picking a smaller and lower-depth icon than it should.\r\n"},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/229719892","html_url":"https://github.com/bitcoin/bitcoin/pull/8285#issuecomment-229719892","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8285","id":229719892,"user":{"login":"laanwj","id":126646,"avatar_url":"https://avatars.githubusercontent.com/u/126646?v=3","gravatar_id":"","url":"https://api.github.com/users/laanwj","html_url":"https://github.com/laanwj","followers_url":"https://api.github.com/users/laanwj/followers","following_url":"https://api.github.com/users/laanwj/following{/other_user}","gists_url":"https://api.github.com/users/laanwj/gists{/gist_id}","starred_url":"https://api.github.com/users/laanwj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laanwj/subscriptions","organizations_url":"https://api.github.com/users/laanwj/orgs","repos_url":"https://api.github.com/users/laanwj/repos","events_url":"https://api.github.com/users/laanwj/events{/privacy}","received_events_url":"https://api.github.com/users/laanwj/received_events","type":"User","site_admin":false},"created_at":"2016-06-30T16:54:08Z","updated_at":"2016-06-30T16:54:08Z","body":"> Sure. I guess this one should be fine:\r\n\r\nAdded. Tested ACK, looks good now, and both icons are ~60kB."}}
{"actor":{"display_login":"laanwj"}}