{"action":"created","issue":{"url":"https://api.github.com/repos/GNS3/gns3-gui/issues/1114","repository_url":"https://api.github.com/repos/GNS3/gns3-gui","labels_url":"https://api.github.com/repos/GNS3/gns3-gui/issues/1114/labels{/name}","comments_url":"https://api.github.com/repos/GNS3/gns3-gui/issues/1114/comments","events_url":"https://api.github.com/repos/GNS3/gns3-gui/issues/1114/events","html_url":"https://github.com/GNS3/gns3-gui/pull/1114","id":140610540,"number":1114,"title":"Ask the user to stop device before closing","user":{"login":"noplay","id":345437,"avatar_url":"https://avatars.githubusercontent.com/u/345437?v=3","gravatar_id":"","url":"https://api.github.com/users/noplay","html_url":"https://github.com/noplay","followers_url":"https://api.github.com/users/noplay/followers","following_url":"https://api.github.com/users/noplay/following{/other_user}","gists_url":"https://api.github.com/users/noplay/gists{/gist_id}","starred_url":"https://api.github.com/users/noplay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noplay/subscriptions","organizations_url":"https://api.github.com/users/noplay/orgs","repos_url":"https://api.github.com/users/noplay/repos","events_url":"https://api.github.com/users/noplay/events{/privacy}","received_events_url":"https://api.github.com/users/noplay/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/GNS3/gns3-gui/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":{"login":"noplay","id":345437,"avatar_url":"https://avatars.githubusercontent.com/u/345437?v=3","gravatar_id":"","url":"https://api.github.com/users/noplay","html_url":"https://github.com/noplay","followers_url":"https://api.github.com/users/noplay/followers","following_url":"https://api.github.com/users/noplay/following{/other_user}","gists_url":"https://api.github.com/users/noplay/gists{/gist_id}","starred_url":"https://api.github.com/users/noplay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noplay/subscriptions","organizations_url":"https://api.github.com/users/noplay/orgs","repos_url":"https://api.github.com/users/noplay/repos","events_url":"https://api.github.com/users/noplay/events{/privacy}","received_events_url":"https://api.github.com/users/noplay/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/GNS3/gns3-gui/milestones/23","html_url":"https://github.com/GNS3/gns3-gui/milestones/1.4.5","labels_url":"https://api.github.com/repos/GNS3/gns3-gui/milestones/23/labels","id":1596387,"number":23,"title":"1.4.5","description":"","creator":{"login":"noplay","id":345437,"avatar_url":"https://avatars.githubusercontent.com/u/345437?v=3","gravatar_id":"","url":"https://api.github.com/users/noplay","html_url":"https://github.com/noplay","followers_url":"https://api.github.com/users/noplay/followers","following_url":"https://api.github.com/users/noplay/following{/other_user}","gists_url":"https://api.github.com/users/noplay/gists{/gist_id}","starred_url":"https://api.github.com/users/noplay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noplay/subscriptions","organizations_url":"https://api.github.com/users/noplay/orgs","repos_url":"https://api.github.com/users/noplay/repos","events_url":"https://api.github.com/users/noplay/events{/privacy}","received_events_url":"https://api.github.com/users/noplay/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":18,"state":"open","created_at":"2016-02-22T07:43:29Z","updated_at":"2016-03-16T00:50:12Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2016-03-14T08:44:15Z","updated_at":"2016-03-16T08:47:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/GNS3/gns3-gui/pulls/1114","html_url":"https://github.com/GNS3/gns3-gui/pull/1114","diff_url":"https://github.com/GNS3/gns3-gui/pull/1114.diff","patch_url":"https://github.com/GNS3/gns3-gui/pull/1114.patch"},"body":"This should avoid some problems with ghost process remaining.\r\n\r\nRef #1088"},"comment":{"url":"https://api.github.com/repos/GNS3/gns3-gui/issues/comments/197214752","html_url":"https://github.com/GNS3/gns3-gui/pull/1114#issuecomment-197214752","issue_url":"https://api.github.com/repos/GNS3/gns3-gui/issues/1114","id":197214752,"user":{"login":"noplay","id":345437,"avatar_url":"https://avatars.githubusercontent.com/u/345437?v=3","gravatar_id":"","url":"https://api.github.com/users/noplay","html_url":"https://github.com/noplay","followers_url":"https://api.github.com/users/noplay/followers","following_url":"https://api.github.com/users/noplay/following{/other_user}","gists_url":"https://api.github.com/users/noplay/gists{/gist_id}","starred_url":"https://api.github.com/users/noplay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noplay/subscriptions","organizations_url":"https://api.github.com/users/noplay/orgs","repos_url":"https://api.github.com/users/noplay/repos","events_url":"https://api.github.com/users/noplay/events{/privacy}","received_events_url":"https://api.github.com/users/noplay/received_events","type":"User","site_admin":false},"created_at":"2016-03-16T08:47:10Z","updated_at":"2016-03-16T08:47:10Z","body":"Problem if we do that we don't wait for everything to exit (signal hell...\n).\n\nOn Wed, Mar 16, 2016 at 1:23 AM Jeremy Grossmann <notifications@github.com>\nwrote:\n\n> Why don't we stop the nodes ourselves? Something like:\n>\n>         if running_node:\n>             reply = QtWidgets.QMessageBox.warning(self, \"GNS3\", \"A device is still running, would you like to continue?\",\n>                                                            QtWidgets.QMessageBox.Yes | QtWidgets.QMessageBox.No)\n>             if reply == QtWidgets.QMessageBox.Yes:\n>                 for node in topology.nodes():\n>                     if hasattr(node, \"stop\") and node.status() == Node.started:\n>                         node.stop()\n>                 return True\n>             else:\n>                 return False\n>\n> —\n> You are receiving this because you were assigned.\n> Reply to this email directly or view it on GitHub\n> <https://github.com/GNS3/gns3-gui/pull/1114#issuecomment-197080899>\n>\n"}}