{"action":"created","comment":{"url":"https://api.github.com/repos/thoughtbot/shoulda/pulls/comments/66694209","id":66694209,"diff_hunk":"@@ -1,77 +1,67 @@\n-PROJECT_ROOT = File.expand_path(File.join(File.dirname(__FILE__), '..', '..')).freeze\n-APP_NAME     = 'testapp'.freeze\n-\n-When /^I generate a new rails application$/ do\n+When 'I generate a new Rails application' do\n   steps %{\n-    When I run `bundle exec rails new #{APP_NAME}`\n+    When I run `bundle exec rails new #{APP_NAME} --skip-bundle --no-rc`\n     And I cd to \"#{APP_NAME}\"\n     And I write to \"Gemfile\" with:\n       \"\"\"\n-      source \"http://rubygems.org\"\n-      gem 'rails', '3.0.12'\n+      source 'https://rubygems.org'\n+      gem 'rails', '#{rails_version}'\n       gem 'sqlite3'\n       \"\"\"\n     And I successfully run `bundle install --local`\n   }\n end\n \n When /^I configure the application to use \"([^\\\"]+)\" from this project$/ do |name|\n-  append_to_gemfile \"gem '#{name}', :path => '#{PROJECT_ROOT}'\"\n+  append_to_gemfile \"gem '#{name}', path: '#{PROJECT_ROOT}'\"\n   steps %{And I run `bundle install --local`}\n end\n \n-When /^I run the rspec generator$/ do\n-  steps %{\n-    When I successfully run `rails generate rspec:install`\n-  }\n-end\n-\n-When /^I configure the application to use rspec\\-rails$/ do\n-  append_to_gemfile \"gem 'rspec-rails'\"\n+When 'I configure the application to use Shoulda' do\n+  append_to_gemfile \"gem 'shoulda', path: '../../..'\"\n   steps %{And I run `bundle install --local`}\n-end\n \n-When /^I configure the application to use shoulda-context$/ do\n-  append_to_gemfile \"gem 'shoulda-context'\"\n-  steps %{And I run `bundle install --local`}\n-end\n-\n-When /^I configure the application to use shoulda$/ do\n-  append_to_gemfile \"gem 'shoulda-matchers', '~> 1.0', :require => false\"\n-  append_to_gemfile \"gem 'shoulda-context', '~> 1.0', :require => false\"\n-  append_to_gemfile \"gem 'shoulda', :path => '../../..'\"\n-  steps %{And I run `bundle install --local`}\n-end\n-\n-When /^I configure the application to use shoulda-matchers$/ do\n-  append_to_gemfile \"gem 'shoulda-matchers', '~> 1.0'\"\n-  steps %{And I run `bundle install --local`}\n+  append_to 'test/test_helper.rb', <<-TEXT\n+    Shoulda::Matchers.configure do |config|\n+      config.integrate do |with|\n+        with.test_framework :#{minitest_identifier}\n+        with.library :rails\n+      end\n+    end\n+  TEXT\n end\n \n-When /^I configure a wildcard route$/ do\n+When 'I configure a wildcard route' do\n   steps %{\n     When I write to \"config/routes.rb\" with:\n     \"\"\"\n     Rails.application.routes.draw do\n-      match ':controller(/:action(/:id(.:format)))'\n+      get ':controller(/:action(/:id(.:format)))'\n     end\n     \"\"\"\n   }\n end\n \n-module AppendHelpers\n-  def append_to(path, contents)\n-    in_current_dir do\n-      File.open(path, \"a\") do |file|\n-        file.puts\n-        file.puts contents\n-      end\n-    end\n-  end\n+When 'I successfully run the \"test\" task' do\n+  steps %{\n+    When I successfully run `bundle exec rake test TESTOPTS='-v' --trace`\n+  }\n+end\n \n-  def append_to_gemfile(contents)\n-    append_to('Gemfile', contents)\n+Then /^the output should indicate that (\\d+) tests were run successfully$/ do |number|","path":"features/step_definitions/rails_steps.rb","position":96,"original_position":96,"commit_id":"801090ba1a945b3de8ad193890715930ccefc064","original_commit_id":"801090ba1a945b3de8ad193890715930ccefc064","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Unused block argument - `number`. You can omit the argument if you don't care about it.<br>Line is too long. [86/80]","created_at":"2016-06-10T23:29:55Z","updated_at":"2016-06-10T23:29:55Z","html_url":"https://github.com/thoughtbot/shoulda/pull/261#discussion_r66694209","pull_request_url":"https://api.github.com/repos/thoughtbot/shoulda/pulls/261","_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/shoulda/pulls/comments/66694209"},"html":{"href":"https://github.com/thoughtbot/shoulda/pull/261#discussion_r66694209"},"pull_request":{"href":"https://api.github.com/repos/thoughtbot/shoulda/pulls/261"}}},"pull_request":{"url":"https://api.github.com/repos/thoughtbot/shoulda/pulls/261","id":73449471,"html_url":"https://github.com/thoughtbot/shoulda/pull/261","diff_url":"https://github.com/thoughtbot/shoulda/pull/261.diff","patch_url":"https://github.com/thoughtbot/shoulda/pull/261.patch","issue_url":"https://api.github.com/repos/thoughtbot/shoulda/issues/261","number":261,"state":"open","locked":false,"title":"Out with the old, in with the new","user":{"login":"mcmire","id":7371,"avatar_url":"https://avatars.githubusercontent.com/u/7371?v=3","gravatar_id":"","url":"https://api.github.com/users/mcmire","html_url":"https://github.com/mcmire","followers_url":"https://api.github.com/users/mcmire/followers","following_url":"https://api.github.com/users/mcmire/following{/other_user}","gists_url":"https://api.github.com/users/mcmire/gists{/gist_id}","starred_url":"https://api.github.com/users/mcmire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcmire/subscriptions","organizations_url":"https://api.github.com/users/mcmire/orgs","repos_url":"https://api.github.com/users/mcmire/repos","events_url":"https://api.github.com/users/mcmire/events{/privacy}","received_events_url":"https://api.github.com/users/mcmire/received_events","type":"User","site_admin":false},"body":"This commit is long overdue. The main change is to upgrade shoulda's\r\nhard dependency on shoulda-matchers from 2.x to 3.x. Since this by\r\nitself is a pretty consequential change, though, I also took the\r\nopportunity to make some more at the same time that I think are\r\nreasonable:\r\n\r\n* Remove support for Rails 3, upgrading dependency to 4, modifying\r\n  Appraisals file and fixing Cucumber specs to match.\r\n* Remove support for RSpec, along with related Cucumber specs. People\r\n  who use RSpec won't be using the `shoulda` gem -- they'll be using\r\n  `shoulda-matchers` instead. There's already a good collection of\r\n  integration specs there, so we don't need the tests here.\r\n* Remove support for Ruby 1.9, along with the entry in .travis.yml.\r\n\r\nDue to the backward-incompatible nature of these changes, my thought is\r\nto release a version 4 of shoulda that includes them.","created_at":"2016-06-10T23:29:51Z","updated_at":"2016-06-10T23:29:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1cc6a0c21485028441e4875ba6bcd4f817f5142f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/thoughtbot/shoulda/pulls/261/commits","review_comments_url":"https://api.github.com/repos/thoughtbot/shoulda/pulls/261/comments","review_comment_url":"https://api.github.com/repos/thoughtbot/shoulda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thoughtbot/shoulda/issues/261/comments","statuses_url":"https://api.github.com/repos/thoughtbot/shoulda/statuses/801090ba1a945b3de8ad193890715930ccefc064","head":{"label":"thoughtbot:ew-out-with-the-old","ref":"ew-out-with-the-old","sha":"801090ba1a945b3de8ad193890715930ccefc064","user":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"repo":{"id":9664,"name":"shoulda","full_name":"thoughtbot/shoulda","owner":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thoughtbot/shoulda","description":"Makes tests easy on the fingers and the eyes","fork":false,"url":"https://api.github.com/repos/thoughtbot/shoulda","forks_url":"https://api.github.com/repos/thoughtbot/shoulda/forks","keys_url":"https://api.github.com/repos/thoughtbot/shoulda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thoughtbot/shoulda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thoughtbot/shoulda/teams","hooks_url":"https://api.github.com/repos/thoughtbot/shoulda/hooks","issue_events_url":"https://api.github.com/repos/thoughtbot/shoulda/issues/events{/number}","events_url":"https://api.github.com/repos/thoughtbot/shoulda/events","assignees_url":"https://api.github.com/repos/thoughtbot/shoulda/assignees{/user}","branches_url":"https://api.github.com/repos/thoughtbot/shoulda/branches{/branch}","tags_url":"https://api.github.com/repos/thoughtbot/shoulda/tags","blobs_url":"https://api.github.com/repos/thoughtbot/shoulda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thoughtbot/shoulda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thoughtbot/shoulda/git/refs{/sha}","trees_url":"https://api.github.com/repos/thoughtbot/shoulda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thoughtbot/shoulda/statuses/{sha}","languages_url":"https://api.github.com/repos/thoughtbot/shoulda/languages","stargazers_url":"https://api.github.com/repos/thoughtbot/shoulda/stargazers","contributors_url":"https://api.github.com/repos/thoughtbot/shoulda/contributors","subscribers_url":"https://api.github.com/repos/thoughtbot/shoulda/subscribers","subscription_url":"https://api.github.com/repos/thoughtbot/shoulda/subscription","commits_url":"https://api.github.com/repos/thoughtbot/shoulda/commits{/sha}","git_commits_url":"https://api.github.com/repos/thoughtbot/shoulda/git/commits{/sha}","comments_url":"https://api.github.com/repos/thoughtbot/shoulda/comments{/number}","issue_comment_url":"https://api.github.com/repos/thoughtbot/shoulda/issues/comments{/number}","contents_url":"https://api.github.com/repos/thoughtbot/shoulda/contents/{+path}","compare_url":"https://api.github.com/repos/thoughtbot/shoulda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thoughtbot/shoulda/merges","archive_url":"https://api.github.com/repos/thoughtbot/shoulda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thoughtbot/shoulda/downloads","issues_url":"https://api.github.com/repos/thoughtbot/shoulda/issues{/number}","pulls_url":"https://api.github.com/repos/thoughtbot/shoulda/pulls{/number}","milestones_url":"https://api.github.com/repos/thoughtbot/shoulda/milestones{/number}","notifications_url":"https://api.github.com/repos/thoughtbot/shoulda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thoughtbot/shoulda/labels{/name}","releases_url":"https://api.github.com/repos/thoughtbot/shoulda/releases{/id}","deployments_url":"https://api.github.com/repos/thoughtbot/shoulda/deployments","created_at":"2008-04-14T13:27:26Z","updated_at":"2016-06-02T08:35:58Z","pushed_at":"2016-06-10T23:29:52Z","git_url":"git://github.com/thoughtbot/shoulda.git","ssh_url":"git@github.com:thoughtbot/shoulda.git","clone_url":"https://github.com/thoughtbot/shoulda.git","svn_url":"https://github.com/thoughtbot/shoulda","homepage":"http://www.thoughtbot.com/community","size":1723,"stargazers_count":1912,"watchers_count":1912,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":200,"mirror_url":null,"open_issues_count":6,"forks":200,"open_issues":6,"watchers":1912,"default_branch":"master"}},"base":{"label":"thoughtbot:master","ref":"master","sha":"b411932fc3afd5a3295d7d8318f5b302e45fd312","user":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"repo":{"id":9664,"name":"shoulda","full_name":"thoughtbot/shoulda","owner":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thoughtbot/shoulda","description":"Makes tests easy on the fingers and the eyes","fork":false,"url":"https://api.github.com/repos/thoughtbot/shoulda","forks_url":"https://api.github.com/repos/thoughtbot/shoulda/forks","keys_url":"https://api.github.com/repos/thoughtbot/shoulda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thoughtbot/shoulda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thoughtbot/shoulda/teams","hooks_url":"https://api.github.com/repos/thoughtbot/shoulda/hooks","issue_events_url":"https://api.github.com/repos/thoughtbot/shoulda/issues/events{/number}","events_url":"https://api.github.com/repos/thoughtbot/shoulda/events","assignees_url":"https://api.github.com/repos/thoughtbot/shoulda/assignees{/user}","branches_url":"https://api.github.com/repos/thoughtbot/shoulda/branches{/branch}","tags_url":"https://api.github.com/repos/thoughtbot/shoulda/tags","blobs_url":"https://api.github.com/repos/thoughtbot/shoulda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thoughtbot/shoulda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thoughtbot/shoulda/git/refs{/sha}","trees_url":"https://api.github.com/repos/thoughtbot/shoulda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thoughtbot/shoulda/statuses/{sha}","languages_url":"https://api.github.com/repos/thoughtbot/shoulda/languages","stargazers_url":"https://api.github.com/repos/thoughtbot/shoulda/stargazers","contributors_url":"https://api.github.com/repos/thoughtbot/shoulda/contributors","subscribers_url":"https://api.github.com/repos/thoughtbot/shoulda/subscribers","subscription_url":"https://api.github.com/repos/thoughtbot/shoulda/subscription","commits_url":"https://api.github.com/repos/thoughtbot/shoulda/commits{/sha}","git_commits_url":"https://api.github.com/repos/thoughtbot/shoulda/git/commits{/sha}","comments_url":"https://api.github.com/repos/thoughtbot/shoulda/comments{/number}","issue_comment_url":"https://api.github.com/repos/thoughtbot/shoulda/issues/comments{/number}","contents_url":"https://api.github.com/repos/thoughtbot/shoulda/contents/{+path}","compare_url":"https://api.github.com/repos/thoughtbot/shoulda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thoughtbot/shoulda/merges","archive_url":"https://api.github.com/repos/thoughtbot/shoulda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thoughtbot/shoulda/downloads","issues_url":"https://api.github.com/repos/thoughtbot/shoulda/issues{/number}","pulls_url":"https://api.github.com/repos/thoughtbot/shoulda/pulls{/number}","milestones_url":"https://api.github.com/repos/thoughtbot/shoulda/milestones{/number}","notifications_url":"https://api.github.com/repos/thoughtbot/shoulda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thoughtbot/shoulda/labels{/name}","releases_url":"https://api.github.com/repos/thoughtbot/shoulda/releases{/id}","deployments_url":"https://api.github.com/repos/thoughtbot/shoulda/deployments","created_at":"2008-04-14T13:27:26Z","updated_at":"2016-06-02T08:35:58Z","pushed_at":"2016-06-10T23:29:52Z","git_url":"git://github.com/thoughtbot/shoulda.git","ssh_url":"git@github.com:thoughtbot/shoulda.git","clone_url":"https://github.com/thoughtbot/shoulda.git","svn_url":"https://github.com/thoughtbot/shoulda","homepage":"http://www.thoughtbot.com/community","size":1723,"stargazers_count":1912,"watchers_count":1912,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":200,"mirror_url":null,"open_issues_count":6,"forks":200,"open_issues":6,"watchers":1912,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/shoulda/pulls/261"},"html":{"href":"https://github.com/thoughtbot/shoulda/pull/261"},"issue":{"href":"https://api.github.com/repos/thoughtbot/shoulda/issues/261"},"comments":{"href":"https://api.github.com/repos/thoughtbot/shoulda/issues/261/comments"},"review_comments":{"href":"https://api.github.com/repos/thoughtbot/shoulda/pulls/261/comments"},"review_comment":{"href":"https://api.github.com/repos/thoughtbot/shoulda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thoughtbot/shoulda/pulls/261/commits"},"statuses":{"href":"https://api.github.com/repos/thoughtbot/shoulda/statuses/801090ba1a945b3de8ad193890715930ccefc064"}}}}
{"actor":{"display_login":"houndci-bot"}}