{"action":"created","issue":{"url":"https://api.github.com/repos/pyrsmk/qwest/issues/100","labels_url":"https://api.github.com/repos/pyrsmk/qwest/issues/100/labels{/name}","comments_url":"https://api.github.com/repos/pyrsmk/qwest/issues/100/comments","events_url":"https://api.github.com/repos/pyrsmk/qwest/issues/100/events","html_url":"https://github.com/pyrsmk/qwest/issues/100","id":125954356,"number":100,"title":"Catch method signature","user":{"login":"fredrikekelund","id":1101677,"avatar_url":"https://avatars.githubusercontent.com/u/1101677?v=3","gravatar_id":"","url":"https://api.github.com/users/fredrikekelund","html_url":"https://github.com/fredrikekelund","followers_url":"https://api.github.com/users/fredrikekelund/followers","following_url":"https://api.github.com/users/fredrikekelund/following{/other_user}","gists_url":"https://api.github.com/users/fredrikekelund/gists{/gist_id}","starred_url":"https://api.github.com/users/fredrikekelund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredrikekelund/subscriptions","organizations_url":"https://api.github.com/users/fredrikekelund/orgs","repos_url":"https://api.github.com/users/fredrikekelund/repos","events_url":"https://api.github.com/users/fredrikekelund/events{/privacy}","received_events_url":"https://api.github.com/users/fredrikekelund/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2016-01-11T14:20:44Z","updated_at":"2016-01-11T16:42:35Z","closed_at":null,"body":"The order of arguments passed to a promise chain's `catch` handler doesn't match the common practice of providing the error as the first argument. This causes issues when another error is thrown as part of the promise chain, since what would have been my `xhr` argument suddenly becomes the error instead. I think it would be a good idea to provide arguments to the catch handler in the order `error, xhr, response`, this would result in more consistent behavior.\r\n\r\nThanks for a really nice library!"},"comment":{"url":"https://api.github.com/repos/pyrsmk/qwest/issues/comments/170612772","html_url":"https://github.com/pyrsmk/qwest/issues/100#issuecomment-170612772","issue_url":"https://api.github.com/repos/pyrsmk/qwest/issues/100","id":170612772,"user":{"login":"fredrikekelund","id":1101677,"avatar_url":"https://avatars.githubusercontent.com/u/1101677?v=3","gravatar_id":"","url":"https://api.github.com/users/fredrikekelund","html_url":"https://github.com/fredrikekelund","followers_url":"https://api.github.com/users/fredrikekelund/followers","following_url":"https://api.github.com/users/fredrikekelund/following{/other_user}","gists_url":"https://api.github.com/users/fredrikekelund/gists{/gist_id}","starred_url":"https://api.github.com/users/fredrikekelund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredrikekelund/subscriptions","organizations_url":"https://api.github.com/users/fredrikekelund/orgs","repos_url":"https://api.github.com/users/fredrikekelund/repos","events_url":"https://api.github.com/users/fredrikekelund/events{/privacy}","received_events_url":"https://api.github.com/users/fredrikekelund/received_events","type":"User","site_admin":false},"created_at":"2016-01-11T16:42:35Z","updated_at":"2016-01-11T16:42:35Z","body":"Agreed that ideally there are tests, but maybe there aren't any. And maybe I've just recently cloned a project and I'm running `npm install` and things aren't working as expected when running the app. Or maybe I have 25 dependencies and I'm running `npm update` because I need the latest version of a single one. Maybe people have implemented some kind of retry strategy for the request in their catch handler, and they're working with the XHR object somehow and suddenly the XHR is an error instead :/\r\n\r\nIn any case, I would recommend bumping the major version number. I know the semver rules are supposed to be more like guidelines than absolute law, but they're pretty clear about the backwards compatibility stuff http://semver.org/"}}