{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/coreclr/issues/6137","repository_url":"https://api.github.com/repos/dotnet/coreclr","labels_url":"https://api.github.com/repos/dotnet/coreclr/issues/6137/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/6137/comments","events_url":"https://api.github.com/repos/dotnet/coreclr/issues/6137/events","html_url":"https://github.com/dotnet/coreclr/pull/6137","id":164031115,"number":6137,"title":"Fix for #5877: pre-spill just the floating arguments","user":{"login":"papaslavik","id":8804118,"avatar_url":"https://avatars.githubusercontent.com/u/8804118?v=3","gravatar_id":"","url":"https://api.github.com/users/papaslavik","html_url":"https://github.com/papaslavik","followers_url":"https://api.github.com/users/papaslavik/followers","following_url":"https://api.github.com/users/papaslavik/following{/other_user}","gists_url":"https://api.github.com/users/papaslavik/gists{/gist_id}","starred_url":"https://api.github.com/users/papaslavik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/papaslavik/subscriptions","organizations_url":"https://api.github.com/users/papaslavik/orgs","repos_url":"https://api.github.com/users/papaslavik/repos","events_url":"https://api.github.com/users/papaslavik/events{/privacy}","received_events_url":"https://api.github.com/users/papaslavik/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/coreclr/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-07-06T09:07:56Z","updated_at":"2016-07-08T17:18:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/6137","html_url":"https://github.com/dotnet/coreclr/pull/6137","diff_url":"https://github.com/dotnet/coreclr/pull/6137.diff","patch_url":"https://github.com/dotnet/coreclr/pull/6137.patch"},"body":"The soft fp is implemented using the VarArgs related existing code, which uses pre-spilling.\r\n\r\nIt doesn't make sense to pre-spill the integer arguments for soft fp, so we added the fix.\r\n\r\n(Moreover, any pre-spills are not just causing the additional push instructions. The pre-spilled local variables will get the stack slots which then will be updated after any manipulations with  the variable which leads to a lot of surplus st and ld operations. This suggests re-writing soft fp support in the future to reduce the code size and the execution time)."},"comment":{"url":"https://api.github.com/repos/dotnet/coreclr/issues/comments/231418967","html_url":"https://github.com/dotnet/coreclr/pull/6137#issuecomment-231418967","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/6137","id":231418967,"user":{"login":"BruceForstall","id":10901265,"avatar_url":"https://avatars.githubusercontent.com/u/10901265?v=3","gravatar_id":"","url":"https://api.github.com/users/BruceForstall","html_url":"https://github.com/BruceForstall","followers_url":"https://api.github.com/users/BruceForstall/followers","following_url":"https://api.github.com/users/BruceForstall/following{/other_user}","gists_url":"https://api.github.com/users/BruceForstall/gists{/gist_id}","starred_url":"https://api.github.com/users/BruceForstall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BruceForstall/subscriptions","organizations_url":"https://api.github.com/users/BruceForstall/orgs","repos_url":"https://api.github.com/users/BruceForstall/repos","events_url":"https://api.github.com/users/BruceForstall/events{/privacy}","received_events_url":"https://api.github.com/users/BruceForstall/received_events","type":"User","site_admin":false},"created_at":"2016-07-08T17:18:54Z","updated_at":"2016-07-08T17:18:54Z","body":"@mmitche It looks like serious problems with the CI (or broken build/test/network?), e.g.:\r\n```\r\n00:09:50 Restoring BuildTools version 1.0.25-prerelease-00507-05...\r\n00:15:50 ERROR: Could not restore build tools correctly. See 'D:\\j\\workspace\\debug_windows---17180f1b\\init-tools.log' for more details.\r\n00:15:50 ERROR: Could not restore build tools.\r\n```\r\n"}}
{"actor":{"display_login":"BruceForstall"}}