{"action":"created","comment":{"url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/comments/72565634","id":72565634,"diff_hunk":"@@ -3,7 +3,13 @@ not be accurate or up-to-date_**\n \n # Marionette.View\n \n-A `View` is a view that represents an item to be displayed with a template.\rThis is typically a `Backbone.Model`, `Backbone.Collection`, or nothing at all.\r\rViews are also used to build up your application hierarchy - you can easily nest\rmultiple views through the `regions` attribute.\r\r**_Note: From Marionette v3.x, `Marionette.View` replaces\n+A `View` is a view that represents an item to be displayed with a template.","path":"docs/marionette.view.md","position":5,"original_position":5,"commit_id":"1fd7cf512373aac5c592b0dac28509bb51749ff5","original_commit_id":"1fd7cf512373aac5c592b0dac28509bb51749ff5","user":{"login":"rafde","id":833429,"avatar_url":"https://avatars.githubusercontent.com/u/833429?v=3","gravatar_id":"","url":"https://api.github.com/users/rafde","html_url":"https://github.com/rafde","followers_url":"https://api.github.com/users/rafde/followers","following_url":"https://api.github.com/users/rafde/following{/other_user}","gists_url":"https://api.github.com/users/rafde/gists{/gist_id}","starred_url":"https://api.github.com/users/rafde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafde/subscriptions","organizations_url":"https://api.github.com/users/rafde/orgs","repos_url":"https://api.github.com/users/rafde/repos","events_url":"https://api.github.com/users/rafde/events{/privacy}","received_events_url":"https://api.github.com/users/rafde/received_events","type":"User","site_admin":false},"body":"> A `View` represents a DOM to be display with a template.\r\nThe `View` gets rendered to display data from a `Backbone.Model`, `Backbone.Collection`, or neither.\r\n\r\nWhat follows is nice and informative.","created_at":"2016-07-28T04:57:22Z","updated_at":"2016-07-28T04:57:23Z","html_url":"https://github.com/marionettejs/backbone.marionette/pull/3085#discussion_r72565634","pull_request_url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/3085","_links":{"self":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/comments/72565634"},"html":{"href":"https://github.com/marionettejs/backbone.marionette/pull/3085#discussion_r72565634"},"pull_request":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/3085"}}},"pull_request":{"url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/3085","id":78944084,"html_url":"https://github.com/marionettejs/backbone.marionette/pull/3085","diff_url":"https://github.com/marionettejs/backbone.marionette/pull/3085.diff","patch_url":"https://github.com/marionettejs/backbone.marionette/pull/3085.patch","issue_url":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/3085","number":3085,"state":"open","locked":false,"title":"Replace onBeforeShow recommendation with onRender","user":{"login":"jcrben","id":5614134,"avatar_url":"https://avatars.githubusercontent.com/u/5614134?v=3","gravatar_id":"","url":"https://api.github.com/users/jcrben","html_url":"https://github.com/jcrben","followers_url":"https://api.github.com/users/jcrben/followers","following_url":"https://api.github.com/users/jcrben/following{/other_user}","gists_url":"https://api.github.com/users/jcrben/gists{/gist_id}","starred_url":"https://api.github.com/users/jcrben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcrben/subscriptions","organizations_url":"https://api.github.com/users/jcrben/orgs","repos_url":"https://api.github.com/users/jcrben/repos","events_url":"https://api.github.com/users/jcrben/events{/privacy}","received_events_url":"https://api.github.com/users/jcrben/received_events","type":"User","site_admin":false},"body":"There's something wrong with the diff here - based on the documentation at https://github.com/marionettejs/backbone.marionette/blob/v3.0.0-pre.4/docs/marionette.view.md the diff should be quite different.\r\n\r\n### Proposed changes\r\n - Replace onBeforeShow recommendation with onRender\r\n\r\nLink to the issue:\r\n\r\nIn https://github.com/marionettejs/backbone.marionette/issues/2539 the usefulness of onBeforeShow was questioned, and in https://github.com/marionettejs/backbone.marionette/pull/2850 it appears to have been mostly removed. But the docs still recommend using it.\r\n\r\nHooking the nested view structure recommendation to onRender accomplishes the same effect.","created_at":"2016-07-26T23:40:09Z","updated_at":"2016-07-28T04:57:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a740a76ee328429189d84e4334ffd5336a525ed","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/3085/commits","review_comments_url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/3085/comments","review_comment_url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/comments{/number}","comments_url":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/3085/comments","statuses_url":"https://api.github.com/repos/marionettejs/backbone.marionette/statuses/1fd7cf512373aac5c592b0dac28509bb51749ff5","head":{"label":"jcrben:patch-1","ref":"patch-1","sha":"1fd7cf512373aac5c592b0dac28509bb51749ff5","user":{"login":"jcrben","id":5614134,"avatar_url":"https://avatars.githubusercontent.com/u/5614134?v=3","gravatar_id":"","url":"https://api.github.com/users/jcrben","html_url":"https://github.com/jcrben","followers_url":"https://api.github.com/users/jcrben/followers","following_url":"https://api.github.com/users/jcrben/following{/other_user}","gists_url":"https://api.github.com/users/jcrben/gists{/gist_id}","starred_url":"https://api.github.com/users/jcrben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcrben/subscriptions","organizations_url":"https://api.github.com/users/jcrben/orgs","repos_url":"https://api.github.com/users/jcrben/repos","events_url":"https://api.github.com/users/jcrben/events{/privacy}","received_events_url":"https://api.github.com/users/jcrben/received_events","type":"User","site_admin":false},"repo":{"id":64261633,"name":"backbone.marionette","full_name":"jcrben/backbone.marionette","owner":{"login":"jcrben","id":5614134,"avatar_url":"https://avatars.githubusercontent.com/u/5614134?v=3","gravatar_id":"","url":"https://api.github.com/users/jcrben","html_url":"https://github.com/jcrben","followers_url":"https://api.github.com/users/jcrben/followers","following_url":"https://api.github.com/users/jcrben/following{/other_user}","gists_url":"https://api.github.com/users/jcrben/gists{/gist_id}","starred_url":"https://api.github.com/users/jcrben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcrben/subscriptions","organizations_url":"https://api.github.com/users/jcrben/orgs","repos_url":"https://api.github.com/users/jcrben/repos","events_url":"https://api.github.com/users/jcrben/events{/privacy}","received_events_url":"https://api.github.com/users/jcrben/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jcrben/backbone.marionette","description":"The Backbone Framework","fork":true,"url":"https://api.github.com/repos/jcrben/backbone.marionette","forks_url":"https://api.github.com/repos/jcrben/backbone.marionette/forks","keys_url":"https://api.github.com/repos/jcrben/backbone.marionette/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jcrben/backbone.marionette/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jcrben/backbone.marionette/teams","hooks_url":"https://api.github.com/repos/jcrben/backbone.marionette/hooks","issue_events_url":"https://api.github.com/repos/jcrben/backbone.marionette/issues/events{/number}","events_url":"https://api.github.com/repos/jcrben/backbone.marionette/events","assignees_url":"https://api.github.com/repos/jcrben/backbone.marionette/assignees{/user}","branches_url":"https://api.github.com/repos/jcrben/backbone.marionette/branches{/branch}","tags_url":"https://api.github.com/repos/jcrben/backbone.marionette/tags","blobs_url":"https://api.github.com/repos/jcrben/backbone.marionette/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jcrben/backbone.marionette/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jcrben/backbone.marionette/git/refs{/sha}","trees_url":"https://api.github.com/repos/jcrben/backbone.marionette/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jcrben/backbone.marionette/statuses/{sha}","languages_url":"https://api.github.com/repos/jcrben/backbone.marionette/languages","stargazers_url":"https://api.github.com/repos/jcrben/backbone.marionette/stargazers","contributors_url":"https://api.github.com/repos/jcrben/backbone.marionette/contributors","subscribers_url":"https://api.github.com/repos/jcrben/backbone.marionette/subscribers","subscription_url":"https://api.github.com/repos/jcrben/backbone.marionette/subscription","commits_url":"https://api.github.com/repos/jcrben/backbone.marionette/commits{/sha}","git_commits_url":"https://api.github.com/repos/jcrben/backbone.marionette/git/commits{/sha}","comments_url":"https://api.github.com/repos/jcrben/backbone.marionette/comments{/number}","issue_comment_url":"https://api.github.com/repos/jcrben/backbone.marionette/issues/comments{/number}","contents_url":"https://api.github.com/repos/jcrben/backbone.marionette/contents/{+path}","compare_url":"https://api.github.com/repos/jcrben/backbone.marionette/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jcrben/backbone.marionette/merges","archive_url":"https://api.github.com/repos/jcrben/backbone.marionette/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jcrben/backbone.marionette/downloads","issues_url":"https://api.github.com/repos/jcrben/backbone.marionette/issues{/number}","pulls_url":"https://api.github.com/repos/jcrben/backbone.marionette/pulls{/number}","milestones_url":"https://api.github.com/repos/jcrben/backbone.marionette/milestones{/number}","notifications_url":"https://api.github.com/repos/jcrben/backbone.marionette/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jcrben/backbone.marionette/labels{/name}","releases_url":"https://api.github.com/repos/jcrben/backbone.marionette/releases{/id}","deployments_url":"https://api.github.com/repos/jcrben/backbone.marionette/deployments","created_at":"2016-07-26T23:31:56Z","updated_at":"2016-07-26T23:31:59Z","pushed_at":"2016-07-26T23:35:34Z","git_url":"git://github.com/jcrben/backbone.marionette.git","ssh_url":"git@github.com:jcrben/backbone.marionette.git","clone_url":"https://github.com/jcrben/backbone.marionette.git","svn_url":"https://github.com/jcrben/backbone.marionette","homepage":"http://marionettejs.com","size":12236,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"marionettejs:v3.0.0-pre.4","ref":"v3.0.0-pre.4","sha":"fa5734ef3fc58e76552b664b5a68fd21943f77d5","user":{"login":"marionettejs","id":2273169,"avatar_url":"https://avatars.githubusercontent.com/u/2273169?v=3","gravatar_id":"","url":"https://api.github.com/users/marionettejs","html_url":"https://github.com/marionettejs","followers_url":"https://api.github.com/users/marionettejs/followers","following_url":"https://api.github.com/users/marionettejs/following{/other_user}","gists_url":"https://api.github.com/users/marionettejs/gists{/gist_id}","starred_url":"https://api.github.com/users/marionettejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marionettejs/subscriptions","organizations_url":"https://api.github.com/users/marionettejs/orgs","repos_url":"https://api.github.com/users/marionettejs/repos","events_url":"https://api.github.com/users/marionettejs/events{/privacy}","received_events_url":"https://api.github.com/users/marionettejs/received_events","type":"Organization","site_admin":false},"repo":{"id":2965621,"name":"backbone.marionette","full_name":"marionettejs/backbone.marionette","owner":{"login":"marionettejs","id":2273169,"avatar_url":"https://avatars.githubusercontent.com/u/2273169?v=3","gravatar_id":"","url":"https://api.github.com/users/marionettejs","html_url":"https://github.com/marionettejs","followers_url":"https://api.github.com/users/marionettejs/followers","following_url":"https://api.github.com/users/marionettejs/following{/other_user}","gists_url":"https://api.github.com/users/marionettejs/gists{/gist_id}","starred_url":"https://api.github.com/users/marionettejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marionettejs/subscriptions","organizations_url":"https://api.github.com/users/marionettejs/orgs","repos_url":"https://api.github.com/users/marionettejs/repos","events_url":"https://api.github.com/users/marionettejs/events{/privacy}","received_events_url":"https://api.github.com/users/marionettejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/marionettejs/backbone.marionette","description":"The Backbone Framework","fork":false,"url":"https://api.github.com/repos/marionettejs/backbone.marionette","forks_url":"https://api.github.com/repos/marionettejs/backbone.marionette/forks","keys_url":"https://api.github.com/repos/marionettejs/backbone.marionette/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marionettejs/backbone.marionette/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marionettejs/backbone.marionette/teams","hooks_url":"https://api.github.com/repos/marionettejs/backbone.marionette/hooks","issue_events_url":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/events{/number}","events_url":"https://api.github.com/repos/marionettejs/backbone.marionette/events","assignees_url":"https://api.github.com/repos/marionettejs/backbone.marionette/assignees{/user}","branches_url":"https://api.github.com/repos/marionettejs/backbone.marionette/branches{/branch}","tags_url":"https://api.github.com/repos/marionettejs/backbone.marionette/tags","blobs_url":"https://api.github.com/repos/marionettejs/backbone.marionette/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marionettejs/backbone.marionette/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marionettejs/backbone.marionette/git/refs{/sha}","trees_url":"https://api.github.com/repos/marionettejs/backbone.marionette/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marionettejs/backbone.marionette/statuses/{sha}","languages_url":"https://api.github.com/repos/marionettejs/backbone.marionette/languages","stargazers_url":"https://api.github.com/repos/marionettejs/backbone.marionette/stargazers","contributors_url":"https://api.github.com/repos/marionettejs/backbone.marionette/contributors","subscribers_url":"https://api.github.com/repos/marionettejs/backbone.marionette/subscribers","subscription_url":"https://api.github.com/repos/marionettejs/backbone.marionette/subscription","commits_url":"https://api.github.com/repos/marionettejs/backbone.marionette/commits{/sha}","git_commits_url":"https://api.github.com/repos/marionettejs/backbone.marionette/git/commits{/sha}","comments_url":"https://api.github.com/repos/marionettejs/backbone.marionette/comments{/number}","issue_comment_url":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/comments{/number}","contents_url":"https://api.github.com/repos/marionettejs/backbone.marionette/contents/{+path}","compare_url":"https://api.github.com/repos/marionettejs/backbone.marionette/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marionettejs/backbone.marionette/merges","archive_url":"https://api.github.com/repos/marionettejs/backbone.marionette/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marionettejs/backbone.marionette/downloads","issues_url":"https://api.github.com/repos/marionettejs/backbone.marionette/issues{/number}","pulls_url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls{/number}","milestones_url":"https://api.github.com/repos/marionettejs/backbone.marionette/milestones{/number}","notifications_url":"https://api.github.com/repos/marionettejs/backbone.marionette/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marionettejs/backbone.marionette/labels{/name}","releases_url":"https://api.github.com/repos/marionettejs/backbone.marionette/releases{/id}","deployments_url":"https://api.github.com/repos/marionettejs/backbone.marionette/deployments","created_at":"2011-12-12T16:36:09Z","updated_at":"2016-07-28T03:43:57Z","pushed_at":"2016-07-26T23:40:09Z","git_url":"git://github.com/marionettejs/backbone.marionette.git","ssh_url":"git@github.com:marionettejs/backbone.marionette.git","clone_url":"https://github.com/marionettejs/backbone.marionette.git","svn_url":"https://github.com/marionettejs/backbone.marionette","homepage":"http://marionettejs.com","size":19859,"stargazers_count":6929,"watchers_count":6929,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1362,"mirror_url":null,"open_issues_count":120,"forks":1362,"open_issues":120,"watchers":6929,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/3085"},"html":{"href":"https://github.com/marionettejs/backbone.marionette/pull/3085"},"issue":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/3085"},"comments":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/3085/comments"},"review_comments":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/3085/comments"},"review_comment":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/3085/commits"},"statuses":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/statuses/1fd7cf512373aac5c592b0dac28509bb51749ff5"}}}}
{"actor":{"display_login":"rafde"}}