{"action":"created","issue":{"url":"https://api.github.com/repos/Unidata/netcdf-c/issues/316","repository_url":"https://api.github.com/repos/Unidata/netcdf-c","labels_url":"https://api.github.com/repos/Unidata/netcdf-c/issues/316/labels{/name}","comments_url":"https://api.github.com/repos/Unidata/netcdf-c/issues/316/comments","events_url":"https://api.github.com/repos/Unidata/netcdf-c/issues/316/events","html_url":"https://github.com/Unidata/netcdf-c/pull/316","id":174792659,"number":316,"title":"Switch NC_CHAR on netCDF4 to use ASCII","user":{"login":"shoyer","id":1217238,"avatar_url":"https://avatars.githubusercontent.com/u/1217238?v=3","gravatar_id":"","url":"https://api.github.com/users/shoyer","html_url":"https://github.com/shoyer","followers_url":"https://api.github.com/users/shoyer/followers","following_url":"https://api.github.com/users/shoyer/following{/other_user}","gists_url":"https://api.github.com/users/shoyer/gists{/gist_id}","starred_url":"https://api.github.com/users/shoyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shoyer/subscriptions","organizations_url":"https://api.github.com/users/shoyer/orgs","repos_url":"https://api.github.com/users/shoyer/repos","events_url":"https://api.github.com/users/shoyer/events{/privacy}","received_events_url":"https://api.github.com/users/shoyer/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-09-02T15:58:03Z","updated_at":"2016-09-02T18:51:01Z","closed_at":"2016-09-02T16:08:33Z","pull_request":{"url":"https://api.github.com/repos/Unidata/netcdf-c/pulls/316","html_url":"https://github.com/Unidata/netcdf-c/pull/316","diff_url":"https://github.com/Unidata/netcdf-c/pull/316.diff","patch_url":"https://github.com/Unidata/netcdf-c/pull/316.patch"},"body":"Fixes #298\r\n\r\nThe new test, a minor modification of `tst_strings2.c` to use `NC_CHAR` and some non-ASCII characters, passes on Travis-CI. Let me know if you need anything else.\r\n\r\nYou'll notice that I didn't modify the reading code at all -- older versions of netCDF4 already read fixed width ASCII as NC_CHAR. Thus this should present no backwards compatibility concerns."},"comment":{"url":"https://api.github.com/repos/Unidata/netcdf-c/issues/comments/244458429","html_url":"https://github.com/Unidata/netcdf-c/pull/316#issuecomment-244458429","issue_url":"https://api.github.com/repos/Unidata/netcdf-c/issues/316","id":244458429,"user":{"login":"DennisHeimbigner","id":905179,"avatar_url":"https://avatars.githubusercontent.com/u/905179?v=3","gravatar_id":"","url":"https://api.github.com/users/DennisHeimbigner","html_url":"https://github.com/DennisHeimbigner","followers_url":"https://api.github.com/users/DennisHeimbigner/followers","following_url":"https://api.github.com/users/DennisHeimbigner/following{/other_user}","gists_url":"https://api.github.com/users/DennisHeimbigner/gists{/gist_id}","starred_url":"https://api.github.com/users/DennisHeimbigner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DennisHeimbigner/subscriptions","organizations_url":"https://api.github.com/users/DennisHeimbigner/orgs","repos_url":"https://api.github.com/users/DennisHeimbigner/repos","events_url":"https://api.github.com/users/DennisHeimbigner/events{/privacy}","received_events_url":"https://api.github.com/users/DennisHeimbigner/received_events","type":"User","site_admin":false},"created_at":"2016-09-02T18:51:01Z","updated_at":"2016-09-02T18:51:01Z","body":"Just looked at the code and it looks ok to me. Only question is\r\nif it breaks some existing tests."}}
{"actor":{"display_login":"DennisHeimbigner"}}