{"action":"created","issue":{"url":"https://api.github.com/repos/babca/python-gsmmodem/issues/8","repository_url":"https://api.github.com/repos/babca/python-gsmmodem","labels_url":"https://api.github.com/repos/babca/python-gsmmodem/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/babca/python-gsmmodem/issues/8/comments","events_url":"https://api.github.com/repos/babca/python-gsmmodem/issues/8/events","html_url":"https://github.com/babca/python-gsmmodem/pull/8","id":176484935,"number":8,"title":"prepending the 'b' letter when using .format() and passing dsrdtr=True and rtscts=True to Serial to avoid Broken Pipe error","user":{"login":"lucasea777","id":8538002,"avatar_url":"https://avatars.githubusercontent.com/u/8538002?v=3","gravatar_id":"","url":"https://api.github.com/users/lucasea777","html_url":"https://github.com/lucasea777","followers_url":"https://api.github.com/users/lucasea777/followers","following_url":"https://api.github.com/users/lucasea777/following{/other_user}","gists_url":"https://api.github.com/users/lucasea777/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasea777/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasea777/subscriptions","organizations_url":"https://api.github.com/users/lucasea777/orgs","repos_url":"https://api.github.com/users/lucasea777/repos","events_url":"https://api.github.com/users/lucasea777/events{/privacy}","received_events_url":"https://api.github.com/users/lucasea777/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-12T21:07:09Z","updated_at":"2016-09-13T14:57:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/babca/python-gsmmodem/pulls/8","html_url":"https://github.com/babca/python-gsmmodem/pull/8","diff_url":"https://github.com/babca/python-gsmmodem/pull/8.diff","patch_url":"https://github.com/babca/python-gsmmodem/pull/8.patch"},"body":"prepending the 'b' letter when using .format()\r\npassing dsrdtr=True and rtscts=True to Serial to avoid Broken Pipe error"},"comment":{"url":"https://api.github.com/repos/babca/python-gsmmodem/issues/comments/246710054","html_url":"https://github.com/babca/python-gsmmodem/pull/8#issuecomment-246710054","issue_url":"https://api.github.com/repos/babca/python-gsmmodem/issues/8","id":246710054,"user":{"login":"lucasea777","id":8538002,"avatar_url":"https://avatars.githubusercontent.com/u/8538002?v=3","gravatar_id":"","url":"https://api.github.com/users/lucasea777","html_url":"https://github.com/lucasea777","followers_url":"https://api.github.com/users/lucasea777/followers","following_url":"https://api.github.com/users/lucasea777/following{/other_user}","gists_url":"https://api.github.com/users/lucasea777/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasea777/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasea777/subscriptions","organizations_url":"https://api.github.com/users/lucasea777/orgs","repos_url":"https://api.github.com/users/lucasea777/repos","events_url":"https://api.github.com/users/lucasea777/events{/privacy}","received_events_url":"https://api.github.com/users/lucasea777/received_events","type":"User","site_admin":false},"created_at":"2016-09-13T14:57:59Z","updated_at":"2016-09-13T14:57:59Z","body":"Sorry, I am not able to find a better solution for now.\r\nAs far as I know, there is no way to properly use `.format()` with Bytes without using `.decode()`.\r\nMaybe is possible to use Unicode instead of Bytes in `modem.py` and only use Bytes inside `SerialComms.write()`, which in my opinion would lead to a much cleaner solution, but it might require more changes.\r\nAlso it might be better to carefully use `.decode()` before `.format()` only when necessary.\r\nI can keep this changes in my fork until a better solution is found."}}
{"actor":{"display_login":"lucasea777"}}