{"action":"created","comment":{"url":"https://api.github.com/repos/azkaban/azkaban/pulls/comments/71082554","id":71082554,"diff_hunk":"@@ -1447,10 +1444,7 @@ private void finalizeFlows(ExecutableFlow flow) {\n         Alerter alerter = alerters.get(alertType);\n         if (alerter != null) {\n           try {\n-            alerter\n-                .alertOnError(\n-                    flow,\n-                    \"Executor no longer seems to be running this execution. Most likely due to executor bounce.\");\n+            alerter.alertOnError(flow);\n           } catch (Exception e) {\n             // TODO Auto-generated catch block\n             e.printStackTrace();","path":"azkaban-common/src/main/java/azkaban/executor/ExecutorManager.java","position":23,"original_position":23,"commit_id":"80f48f901f58723222ea3c54e77fec7e4a4de602","original_commit_id":"80f48f901f58723222ea3c54e77fec7e4a4de602","user":{"login":"juhoautio","id":4446608,"avatar_url":"https://avatars.githubusercontent.com/u/4446608?v=3","gravatar_id":"","url":"https://api.github.com/users/juhoautio","html_url":"https://github.com/juhoautio","followers_url":"https://api.github.com/users/juhoautio/followers","following_url":"https://api.github.com/users/juhoautio/following{/other_user}","gists_url":"https://api.github.com/users/juhoautio/gists{/gist_id}","starred_url":"https://api.github.com/users/juhoautio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juhoautio/subscriptions","organizations_url":"https://api.github.com/users/juhoautio/orgs","repos_url":"https://api.github.com/users/juhoautio/repos","events_url":"https://api.github.com/users/juhoautio/events{/privacy}","received_events_url":"https://api.github.com/users/juhoautio/received_events","type":"User","site_admin":false},"body":"Could change that to `logger.error(e);` if you say so.","created_at":"2016-07-17T13:42:14Z","updated_at":"2016-07-17T13:42:14Z","html_url":"https://github.com/azkaban/azkaban/pull/680#discussion_r71082554","pull_request_url":"https://api.github.com/repos/azkaban/azkaban/pulls/680","_links":{"self":{"href":"https://api.github.com/repos/azkaban/azkaban/pulls/comments/71082554"},"html":{"href":"https://github.com/azkaban/azkaban/pull/680#discussion_r71082554"},"pull_request":{"href":"https://api.github.com/repos/azkaban/azkaban/pulls/680"}}},"pull_request":{"url":"https://api.github.com/repos/azkaban/azkaban/pulls/680","id":77731095,"html_url":"https://github.com/azkaban/azkaban/pull/680","diff_url":"https://github.com/azkaban/azkaban/pull/680.diff","patch_url":"https://github.com/azkaban/azkaban/pull/680.patch","issue_url":"https://api.github.com/repos/azkaban/azkaban/issues/680","number":680,"state":"open","locked":false,"title":"Fixes to flow notification e-mails","user":{"login":"juhoautio","id":4446608,"avatar_url":"https://avatars.githubusercontent.com/u/4446608?v=3","gravatar_id":"","url":"https://api.github.com/users/juhoautio","html_url":"https://github.com/juhoautio","followers_url":"https://api.github.com/users/juhoautio/followers","following_url":"https://api.github.com/users/juhoautio/following{/other_user}","gists_url":"https://api.github.com/users/juhoautio/gists{/gist_id}","starred_url":"https://api.github.com/users/juhoautio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juhoautio/subscriptions","organizations_url":"https://api.github.com/users/juhoautio/orgs","repos_url":"https://api.github.com/users/juhoautio/repos","events_url":"https://api.github.com/users/juhoautio/events{/privacy}","received_events_url":"https://api.github.com/users/juhoautio/received_events","type":"User","site_admin":false},"body":"- Removed misleading mention about \"executor bounce\"[1]\r\n- Fixed e-mail subject of first error message: \"failed\" => \"encountered a failure\"\r\n- All flow notification e-mails to include flow status (as asked by @georgezhlw and @HappyRay)\r\n- Created a unit test for DefaultMailCreator\r\n\r\n--\r\n\r\n[1] One of the \"Reason\" messages for all flow failure alerts used to be this:\r\n\r\n> Executor no longer seems to be running this execution. Most likely due to executor bounce.\r\n\r\nUsually the alert comes because a job itself failed. It's confusing to suggest that executor node would've been restarted, when it's not.\r\n\r\n--\r\n\r\nScreenshots:\r\n\r\n<img width=\"604\" alt=\"azkaban-email-screenshot-2\" src=\"https://cloud.githubusercontent.com/assets/4446608/16899850/83306e1c-4c1a-11e6-8625-428fd53df54d.png\">\r\n<img width=\"596\" alt=\"azkaban-email-screenshot-1\" src=\"https://cloud.githubusercontent.com/assets/4446608/16899851/835b0abe-4c1a-11e6-855b-e3856a907f0b.png\">\r\n<img width=\"601\" alt=\"azkaban-email-screenshot-0\" src=\"https://cloud.githubusercontent.com/assets/4446608/16899852/835b4f38-4c1a-11e6-9a16-4126e829c16f.png\">\r\n","created_at":"2016-07-17T09:32:51Z","updated_at":"2016-07-17T13:42:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3551e3c5e54de94f45c042191ec6dbbfbc6c117a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/azkaban/azkaban/pulls/680/commits","review_comments_url":"https://api.github.com/repos/azkaban/azkaban/pulls/680/comments","review_comment_url":"https://api.github.com/repos/azkaban/azkaban/pulls/comments{/number}","comments_url":"https://api.github.com/repos/azkaban/azkaban/issues/680/comments","statuses_url":"https://api.github.com/repos/azkaban/azkaban/statuses/80f48f901f58723222ea3c54e77fec7e4a4de602","head":{"label":"juhoautio:better_alert_emails_plus_unit_tests","ref":"better_alert_emails_plus_unit_tests","sha":"80f48f901f58723222ea3c54e77fec7e4a4de602","user":{"login":"juhoautio","id":4446608,"avatar_url":"https://avatars.githubusercontent.com/u/4446608?v=3","gravatar_id":"","url":"https://api.github.com/users/juhoautio","html_url":"https://github.com/juhoautio","followers_url":"https://api.github.com/users/juhoautio/followers","following_url":"https://api.github.com/users/juhoautio/following{/other_user}","gists_url":"https://api.github.com/users/juhoautio/gists{/gist_id}","starred_url":"https://api.github.com/users/juhoautio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juhoautio/subscriptions","organizations_url":"https://api.github.com/users/juhoautio/orgs","repos_url":"https://api.github.com/users/juhoautio/repos","events_url":"https://api.github.com/users/juhoautio/events{/privacy}","received_events_url":"https://api.github.com/users/juhoautio/received_events","type":"User","site_admin":false},"repo":{"id":47544338,"name":"azkaban","full_name":"juhoautio/azkaban","owner":{"login":"juhoautio","id":4446608,"avatar_url":"https://avatars.githubusercontent.com/u/4446608?v=3","gravatar_id":"","url":"https://api.github.com/users/juhoautio","html_url":"https://github.com/juhoautio","followers_url":"https://api.github.com/users/juhoautio/followers","following_url":"https://api.github.com/users/juhoautio/following{/other_user}","gists_url":"https://api.github.com/users/juhoautio/gists{/gist_id}","starred_url":"https://api.github.com/users/juhoautio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juhoautio/subscriptions","organizations_url":"https://api.github.com/users/juhoautio/orgs","repos_url":"https://api.github.com/users/juhoautio/repos","events_url":"https://api.github.com/users/juhoautio/events{/privacy}","received_events_url":"https://api.github.com/users/juhoautio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/juhoautio/azkaban","description":"Azkaban workflow manager.","fork":true,"url":"https://api.github.com/repos/juhoautio/azkaban","forks_url":"https://api.github.com/repos/juhoautio/azkaban/forks","keys_url":"https://api.github.com/repos/juhoautio/azkaban/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juhoautio/azkaban/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juhoautio/azkaban/teams","hooks_url":"https://api.github.com/repos/juhoautio/azkaban/hooks","issue_events_url":"https://api.github.com/repos/juhoautio/azkaban/issues/events{/number}","events_url":"https://api.github.com/repos/juhoautio/azkaban/events","assignees_url":"https://api.github.com/repos/juhoautio/azkaban/assignees{/user}","branches_url":"https://api.github.com/repos/juhoautio/azkaban/branches{/branch}","tags_url":"https://api.github.com/repos/juhoautio/azkaban/tags","blobs_url":"https://api.github.com/repos/juhoautio/azkaban/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juhoautio/azkaban/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juhoautio/azkaban/git/refs{/sha}","trees_url":"https://api.github.com/repos/juhoautio/azkaban/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juhoautio/azkaban/statuses/{sha}","languages_url":"https://api.github.com/repos/juhoautio/azkaban/languages","stargazers_url":"https://api.github.com/repos/juhoautio/azkaban/stargazers","contributors_url":"https://api.github.com/repos/juhoautio/azkaban/contributors","subscribers_url":"https://api.github.com/repos/juhoautio/azkaban/subscribers","subscription_url":"https://api.github.com/repos/juhoautio/azkaban/subscription","commits_url":"https://api.github.com/repos/juhoautio/azkaban/commits{/sha}","git_commits_url":"https://api.github.com/repos/juhoautio/azkaban/git/commits{/sha}","comments_url":"https://api.github.com/repos/juhoautio/azkaban/comments{/number}","issue_comment_url":"https://api.github.com/repos/juhoautio/azkaban/issues/comments{/number}","contents_url":"https://api.github.com/repos/juhoautio/azkaban/contents/{+path}","compare_url":"https://api.github.com/repos/juhoautio/azkaban/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juhoautio/azkaban/merges","archive_url":"https://api.github.com/repos/juhoautio/azkaban/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juhoautio/azkaban/downloads","issues_url":"https://api.github.com/repos/juhoautio/azkaban/issues{/number}","pulls_url":"https://api.github.com/repos/juhoautio/azkaban/pulls{/number}","milestones_url":"https://api.github.com/repos/juhoautio/azkaban/milestones{/number}","notifications_url":"https://api.github.com/repos/juhoautio/azkaban/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juhoautio/azkaban/labels{/name}","releases_url":"https://api.github.com/repos/juhoautio/azkaban/releases{/id}","deployments_url":"https://api.github.com/repos/juhoautio/azkaban/deployments","created_at":"2015-12-07T10:05:59Z","updated_at":"2016-01-11T08:35:28Z","pushed_at":"2016-07-17T13:34:36Z","git_url":"git://github.com/juhoautio/azkaban.git","ssh_url":"git@github.com:juhoautio/azkaban.git","clone_url":"https://github.com/juhoautio/azkaban.git","svn_url":"https://github.com/juhoautio/azkaban","homepage":"https://azkaban.github.io","size":32920,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"azkaban:master","ref":"master","sha":"67c7b18655b0a98f08f12be1f561094418a48a41","user":{"login":"azkaban","id":213618,"avatar_url":"https://avatars.githubusercontent.com/u/213618?v=3","gravatar_id":"","url":"https://api.github.com/users/azkaban","html_url":"https://github.com/azkaban","followers_url":"https://api.github.com/users/azkaban/followers","following_url":"https://api.github.com/users/azkaban/following{/other_user}","gists_url":"https://api.github.com/users/azkaban/gists{/gist_id}","starred_url":"https://api.github.com/users/azkaban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azkaban/subscriptions","organizations_url":"https://api.github.com/users/azkaban/orgs","repos_url":"https://api.github.com/users/azkaban/repos","events_url":"https://api.github.com/users/azkaban/events{/privacy}","received_events_url":"https://api.github.com/users/azkaban/received_events","type":"Organization","site_admin":false},"repo":{"id":6271421,"name":"azkaban","full_name":"azkaban/azkaban","owner":{"login":"azkaban","id":213618,"avatar_url":"https://avatars.githubusercontent.com/u/213618?v=3","gravatar_id":"","url":"https://api.github.com/users/azkaban","html_url":"https://github.com/azkaban","followers_url":"https://api.github.com/users/azkaban/followers","following_url":"https://api.github.com/users/azkaban/following{/other_user}","gists_url":"https://api.github.com/users/azkaban/gists{/gist_id}","starred_url":"https://api.github.com/users/azkaban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azkaban/subscriptions","organizations_url":"https://api.github.com/users/azkaban/orgs","repos_url":"https://api.github.com/users/azkaban/repos","events_url":"https://api.github.com/users/azkaban/events{/privacy}","received_events_url":"https://api.github.com/users/azkaban/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/azkaban/azkaban","description":"Azkaban workflow manager.","fork":false,"url":"https://api.github.com/repos/azkaban/azkaban","forks_url":"https://api.github.com/repos/azkaban/azkaban/forks","keys_url":"https://api.github.com/repos/azkaban/azkaban/keys{/key_id}","collaborators_url":"https://api.github.com/repos/azkaban/azkaban/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/azkaban/azkaban/teams","hooks_url":"https://api.github.com/repos/azkaban/azkaban/hooks","issue_events_url":"https://api.github.com/repos/azkaban/azkaban/issues/events{/number}","events_url":"https://api.github.com/repos/azkaban/azkaban/events","assignees_url":"https://api.github.com/repos/azkaban/azkaban/assignees{/user}","branches_url":"https://api.github.com/repos/azkaban/azkaban/branches{/branch}","tags_url":"https://api.github.com/repos/azkaban/azkaban/tags","blobs_url":"https://api.github.com/repos/azkaban/azkaban/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/azkaban/azkaban/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/azkaban/azkaban/git/refs{/sha}","trees_url":"https://api.github.com/repos/azkaban/azkaban/git/trees{/sha}","statuses_url":"https://api.github.com/repos/azkaban/azkaban/statuses/{sha}","languages_url":"https://api.github.com/repos/azkaban/azkaban/languages","stargazers_url":"https://api.github.com/repos/azkaban/azkaban/stargazers","contributors_url":"https://api.github.com/repos/azkaban/azkaban/contributors","subscribers_url":"https://api.github.com/repos/azkaban/azkaban/subscribers","subscription_url":"https://api.github.com/repos/azkaban/azkaban/subscription","commits_url":"https://api.github.com/repos/azkaban/azkaban/commits{/sha}","git_commits_url":"https://api.github.com/repos/azkaban/azkaban/git/commits{/sha}","comments_url":"https://api.github.com/repos/azkaban/azkaban/comments{/number}","issue_comment_url":"https://api.github.com/repos/azkaban/azkaban/issues/comments{/number}","contents_url":"https://api.github.com/repos/azkaban/azkaban/contents/{+path}","compare_url":"https://api.github.com/repos/azkaban/azkaban/compare/{base}...{head}","merges_url":"https://api.github.com/repos/azkaban/azkaban/merges","archive_url":"https://api.github.com/repos/azkaban/azkaban/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/azkaban/azkaban/downloads","issues_url":"https://api.github.com/repos/azkaban/azkaban/issues{/number}","pulls_url":"https://api.github.com/repos/azkaban/azkaban/pulls{/number}","milestones_url":"https://api.github.com/repos/azkaban/azkaban/milestones{/number}","notifications_url":"https://api.github.com/repos/azkaban/azkaban/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/azkaban/azkaban/labels{/name}","releases_url":"https://api.github.com/repos/azkaban/azkaban/releases{/id}","deployments_url":"https://api.github.com/repos/azkaban/azkaban/deployments","created_at":"2012-10-18T01:34:53Z","updated_at":"2016-07-17T09:38:04Z","pushed_at":"2016-07-17T13:35:06Z","git_url":"git://github.com/azkaban/azkaban.git","ssh_url":"git@github.com:azkaban/azkaban.git","clone_url":"https://github.com/azkaban/azkaban.git","svn_url":"https://github.com/azkaban/azkaban","homepage":"https://azkaban.github.io","size":34081,"stargazers_count":722,"watchers_count":722,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":400,"mirror_url":null,"open_issues_count":246,"forks":400,"open_issues":246,"watchers":722,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/azkaban/azkaban/pulls/680"},"html":{"href":"https://github.com/azkaban/azkaban/pull/680"},"issue":{"href":"https://api.github.com/repos/azkaban/azkaban/issues/680"},"comments":{"href":"https://api.github.com/repos/azkaban/azkaban/issues/680/comments"},"review_comments":{"href":"https://api.github.com/repos/azkaban/azkaban/pulls/680/comments"},"review_comment":{"href":"https://api.github.com/repos/azkaban/azkaban/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/azkaban/azkaban/pulls/680/commits"},"statuses":{"href":"https://api.github.com/repos/azkaban/azkaban/statuses/80f48f901f58723222ea3c54e77fec7e4a4de602"}}}}
{"actor":{"display_login":"juhoautio"}}