{"action":"created","issue":{"url":"https://api.github.com/repos/ember-cli/ember-cli/issues/4358","repository_url":"https://api.github.com/repos/ember-cli/ember-cli","labels_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/4358/labels{/name}","comments_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/4358/comments","events_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/4358/events","html_url":"https://github.com/ember-cli/ember-cli/pull/4358","id":91681675,"number":4358,"title":"[ENHANCEMENT] Output build sizes command","user":{"login":"martypenner","id":1819798,"avatar_url":"https://avatars.githubusercontent.com/u/1819798?v=3","gravatar_id":"","url":"https://api.github.com/users/martypenner","html_url":"https://github.com/martypenner","followers_url":"https://api.github.com/users/martypenner/followers","following_url":"https://api.github.com/users/martypenner/following{/other_user}","gists_url":"https://api.github.com/users/martypenner/gists{/gist_id}","starred_url":"https://api.github.com/users/martypenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martypenner/subscriptions","organizations_url":"https://api.github.com/users/martypenner/orgs","repos_url":"https://api.github.com/users/martypenner/repos","events_url":"https://api.github.com/users/martypenner/events{/privacy}","received_events_url":"https://api.github.com/users/martypenner/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ember-cli/ember-cli/labels/Feature","name":"Feature","color":"009800"},{"url":"https://api.github.com/repos/ember-cli/ember-cli/labels/Needs%20Team%20Response","name":"Needs Team Response","color":"9319E0"}],"state":"open","locked":false,"assignee":{"login":"stefanpenner","id":1377,"avatar_url":"https://avatars.githubusercontent.com/u/1377?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanpenner","html_url":"https://github.com/stefanpenner","followers_url":"https://api.github.com/users/stefanpenner/followers","following_url":"https://api.github.com/users/stefanpenner/following{/other_user}","gists_url":"https://api.github.com/users/stefanpenner/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanpenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanpenner/subscriptions","organizations_url":"https://api.github.com/users/stefanpenner/orgs","repos_url":"https://api.github.com/users/stefanpenner/repos","events_url":"https://api.github.com/users/stefanpenner/events{/privacy}","received_events_url":"https://api.github.com/users/stefanpenner/received_events","type":"User","site_admin":false},"milestone":null,"comments":44,"created_at":"2015-06-29T03:16:34Z","updated_at":"2016-03-20T01:59:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ember-cli/ember-cli/pulls/4358","html_url":"https://github.com/ember-cli/ember-cli/pull/4358","diff_url":"https://github.com/ember-cli/ember-cli/pull/4358.diff","patch_url":"https://github.com/ember-cli/ember-cli/pull/4358.patch"},"body":"This is a very naive implementation that simply checks the given asset path (`dist/assets` by default) for any `*.{css,js}` files and outputs their human-readable size. I chose to do it this way because of lack of access to the output tree when running this command.\r\n\r\nThe command itself is run like this: `ember show-asset-sizes`. If assets are stored in a non-standard directory, run `ember show-asset-sizes --asset-path path/to/assets`. The command name is a bit verbose, but I wasn't sure of a better name that would also convey the meaning.\r\n\r\nSome notes:\r\n- The command tests in `show-asset-sizes-test.js` are failing with \"undefined is not a function\". I cannot for the life of me seem to figure out what's going on there. Doing anything but `return`ing the command promise in the tests passes. As soon as I try to `return` the promise, the tests fail. My node-fu is weak.\r\n- It does not run the `Builder` like the `serve` or `test` tasks do. I thought rebuilding the project might be frustrating when simply trying to see your asset sizes. If the asset directory can't be found, the task throws an error instead. If we decide to run the `Builder` in this task, then we could get rid of the cli argument for the asset path.\r\n\r\n#4293"},"comment":{"url":"https://api.github.com/repos/ember-cli/ember-cli/issues/comments/198826396","html_url":"https://github.com/ember-cli/ember-cli/pull/4358#issuecomment-198826396","issue_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/4358","id":198826396,"user":{"login":"homu","id":10212162,"avatar_url":"https://avatars.githubusercontent.com/u/10212162?v=3","gravatar_id":"","url":"https://api.github.com/users/homu","html_url":"https://github.com/homu","followers_url":"https://api.github.com/users/homu/followers","following_url":"https://api.github.com/users/homu/following{/other_user}","gists_url":"https://api.github.com/users/homu/gists{/gist_id}","starred_url":"https://api.github.com/users/homu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/homu/subscriptions","organizations_url":"https://api.github.com/users/homu/orgs","repos_url":"https://api.github.com/users/homu/repos","events_url":"https://api.github.com/users/homu/events{/privacy}","received_events_url":"https://api.github.com/users/homu/received_events","type":"User","site_admin":false},"created_at":"2016-03-20T01:59:59Z","updated_at":"2016-03-20T01:59:59Z","body":":umbrella: The latest upstream changes (presumably #5622) made this pull request unmergeable. Please resolve the merge conflicts."}}