{"action":"created","comment":{"url":"https://api.github.com/repos/natefinch/lumberjack/pulls/comments/84708466","pull_request_review_id":5468652,"id":84708466,"diff_hunk":"@@ -205,6 +211,13 @@ func (l *Logger) openNew() error {\n \t\t\treturn fmt.Errorf(\"can't rename log file: %s\", err)\n \t\t}\n \n+\t\t// Compress the backup if enabled\n+\t\tif l.CompressBackups == true {","path":"lumberjack.go","position":36,"original_position":36,"commit_id":"6e836ae76b5c8920f79dafd745e217cdaa28c8eb","original_commit_id":"6e836ae76b5c8920f79dafd745e217cdaa28c8eb","user":{"login":"natefinch","id":3185864,"avatar_url":"https://avatars.githubusercontent.com/u/3185864?v=3","gravatar_id":"","url":"https://api.github.com/users/natefinch","html_url":"https://github.com/natefinch","followers_url":"https://api.github.com/users/natefinch/followers","following_url":"https://api.github.com/users/natefinch/following{/other_user}","gists_url":"https://api.github.com/users/natefinch/gists{/gist_id}","starred_url":"https://api.github.com/users/natefinch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natefinch/subscriptions","organizations_url":"https://api.github.com/users/natefinch/orgs","repos_url":"https://api.github.com/users/natefinch/repos","events_url":"https://api.github.com/users/natefinch/events{/privacy}","received_events_url":"https://api.github.com/users/natefinch/received_events","type":"User","site_admin":false},"body":"this should really just be `if l.CompressBackups { ` - no need to check == true.\r\n","created_at":"2016-10-24T15:06:33Z","updated_at":"2016-10-24T15:29:18Z","html_url":"https://github.com/natefinch/lumberjack/pull/16#discussion_r84708466","pull_request_url":"https://api.github.com/repos/natefinch/lumberjack/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/natefinch/lumberjack/pulls/comments/84708466"},"html":{"href":"https://github.com/natefinch/lumberjack/pull/16#discussion_r84708466"},"pull_request":{"href":"https://api.github.com/repos/natefinch/lumberjack/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/natefinch/lumberjack/pulls/16","id":48878965,"html_url":"https://github.com/natefinch/lumberjack/pull/16","diff_url":"https://github.com/natefinch/lumberjack/pull/16.diff","patch_url":"https://github.com/natefinch/lumberjack/pull/16.patch","issue_url":"https://api.github.com/repos/natefinch/lumberjack/issues/16","number":16,"state":"open","locked":false,"title":"Adds gzip compression to backup log files","user":{"login":"donovansolms","id":4567303,"avatar_url":"https://avatars.githubusercontent.com/u/4567303?v=3","gravatar_id":"","url":"https://api.github.com/users/donovansolms","html_url":"https://github.com/donovansolms","followers_url":"https://api.github.com/users/donovansolms/followers","following_url":"https://api.github.com/users/donovansolms/following{/other_user}","gists_url":"https://api.github.com/users/donovansolms/gists{/gist_id}","starred_url":"https://api.github.com/users/donovansolms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donovansolms/subscriptions","organizations_url":"https://api.github.com/users/donovansolms/orgs","repos_url":"https://api.github.com/users/donovansolms/repos","events_url":"https://api.github.com/users/donovansolms/events{/privacy}","received_events_url":"https://api.github.com/users/donovansolms/received_events","type":"User","site_admin":false},"body":"This PR adds gzip compression to backup log files via the CompressBackups config option. Tests added and passed. Please let me know if I missed anything.\r\nNote: We're using this library in production (including gzipped backups) with max size as 100MB. Compression doesn't have any noticeable performance impact aside from saving a lot of drive space.  ","created_at":"2015-10-27T14:37:33Z","updated_at":"2016-10-24T15:29:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4d6e11860a9768f1fcb9b4d84de1b3e9bbaa622","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/natefinch/lumberjack/pulls/16/commits","review_comments_url":"https://api.github.com/repos/natefinch/lumberjack/pulls/16/comments","review_comment_url":"https://api.github.com/repos/natefinch/lumberjack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/natefinch/lumberjack/issues/16/comments","statuses_url":"https://api.github.com/repos/natefinch/lumberjack/statuses/6e836ae76b5c8920f79dafd745e217cdaa28c8eb","head":{"label":"donovansolms:v2.0","ref":"v2.0","sha":"6e836ae76b5c8920f79dafd745e217cdaa28c8eb","user":{"login":"donovansolms","id":4567303,"avatar_url":"https://avatars.githubusercontent.com/u/4567303?v=3","gravatar_id":"","url":"https://api.github.com/users/donovansolms","html_url":"https://github.com/donovansolms","followers_url":"https://api.github.com/users/donovansolms/followers","following_url":"https://api.github.com/users/donovansolms/following{/other_user}","gists_url":"https://api.github.com/users/donovansolms/gists{/gist_id}","starred_url":"https://api.github.com/users/donovansolms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donovansolms/subscriptions","organizations_url":"https://api.github.com/users/donovansolms/orgs","repos_url":"https://api.github.com/users/donovansolms/repos","events_url":"https://api.github.com/users/donovansolms/events{/privacy}","received_events_url":"https://api.github.com/users/donovansolms/received_events","type":"User","site_admin":false},"repo":{"id":45039695,"name":"lumberjack","full_name":"donovansolms/lumberjack","owner":{"login":"donovansolms","id":4567303,"avatar_url":"https://avatars.githubusercontent.com/u/4567303?v=3","gravatar_id":"","url":"https://api.github.com/users/donovansolms","html_url":"https://github.com/donovansolms","followers_url":"https://api.github.com/users/donovansolms/followers","following_url":"https://api.github.com/users/donovansolms/following{/other_user}","gists_url":"https://api.github.com/users/donovansolms/gists{/gist_id}","starred_url":"https://api.github.com/users/donovansolms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donovansolms/subscriptions","organizations_url":"https://api.github.com/users/donovansolms/orgs","repos_url":"https://api.github.com/users/donovansolms/repos","events_url":"https://api.github.com/users/donovansolms/events{/privacy}","received_events_url":"https://api.github.com/users/donovansolms/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/donovansolms/lumberjack","description":"lumberjack is a rolling logger for Go","fork":true,"url":"https://api.github.com/repos/donovansolms/lumberjack","forks_url":"https://api.github.com/repos/donovansolms/lumberjack/forks","keys_url":"https://api.github.com/repos/donovansolms/lumberjack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/donovansolms/lumberjack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/donovansolms/lumberjack/teams","hooks_url":"https://api.github.com/repos/donovansolms/lumberjack/hooks","issue_events_url":"https://api.github.com/repos/donovansolms/lumberjack/issues/events{/number}","events_url":"https://api.github.com/repos/donovansolms/lumberjack/events","assignees_url":"https://api.github.com/repos/donovansolms/lumberjack/assignees{/user}","branches_url":"https://api.github.com/repos/donovansolms/lumberjack/branches{/branch}","tags_url":"https://api.github.com/repos/donovansolms/lumberjack/tags","blobs_url":"https://api.github.com/repos/donovansolms/lumberjack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/donovansolms/lumberjack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/donovansolms/lumberjack/git/refs{/sha}","trees_url":"https://api.github.com/repos/donovansolms/lumberjack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/donovansolms/lumberjack/statuses/{sha}","languages_url":"https://api.github.com/repos/donovansolms/lumberjack/languages","stargazers_url":"https://api.github.com/repos/donovansolms/lumberjack/stargazers","contributors_url":"https://api.github.com/repos/donovansolms/lumberjack/contributors","subscribers_url":"https://api.github.com/repos/donovansolms/lumberjack/subscribers","subscription_url":"https://api.github.com/repos/donovansolms/lumberjack/subscription","commits_url":"https://api.github.com/repos/donovansolms/lumberjack/commits{/sha}","git_commits_url":"https://api.github.com/repos/donovansolms/lumberjack/git/commits{/sha}","comments_url":"https://api.github.com/repos/donovansolms/lumberjack/comments{/number}","issue_comment_url":"https://api.github.com/repos/donovansolms/lumberjack/issues/comments{/number}","contents_url":"https://api.github.com/repos/donovansolms/lumberjack/contents/{+path}","compare_url":"https://api.github.com/repos/donovansolms/lumberjack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/donovansolms/lumberjack/merges","archive_url":"https://api.github.com/repos/donovansolms/lumberjack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/donovansolms/lumberjack/downloads","issues_url":"https://api.github.com/repos/donovansolms/lumberjack/issues{/number}","pulls_url":"https://api.github.com/repos/donovansolms/lumberjack/pulls{/number}","milestones_url":"https://api.github.com/repos/donovansolms/lumberjack/milestones{/number}","notifications_url":"https://api.github.com/repos/donovansolms/lumberjack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/donovansolms/lumberjack/labels{/name}","releases_url":"https://api.github.com/repos/donovansolms/lumberjack/releases{/id}","deployments_url":"https://api.github.com/repos/donovansolms/lumberjack/deployments","created_at":"2015-10-27T12:33:15Z","updated_at":"2015-10-27T12:33:16Z","pushed_at":"2015-10-28T19:59:52Z","git_url":"git://github.com/donovansolms/lumberjack.git","ssh_url":"git@github.com:donovansolms/lumberjack.git","clone_url":"https://github.com/donovansolms/lumberjack.git","svn_url":"https://github.com/donovansolms/lumberjack","homepage":null,"size":159,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v2.0"}},"base":{"label":"natefinch:v2.0","ref":"v2.0","sha":"600ceb4523e5b7ff745f91083c8a023c2bf73af5","user":{"login":"natefinch","id":3185864,"avatar_url":"https://avatars.githubusercontent.com/u/3185864?v=3","gravatar_id":"","url":"https://api.github.com/users/natefinch","html_url":"https://github.com/natefinch","followers_url":"https://api.github.com/users/natefinch/followers","following_url":"https://api.github.com/users/natefinch/following{/other_user}","gists_url":"https://api.github.com/users/natefinch/gists{/gist_id}","starred_url":"https://api.github.com/users/natefinch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natefinch/subscriptions","organizations_url":"https://api.github.com/users/natefinch/orgs","repos_url":"https://api.github.com/users/natefinch/repos","events_url":"https://api.github.com/users/natefinch/events{/privacy}","received_events_url":"https://api.github.com/users/natefinch/received_events","type":"User","site_admin":false},"repo":{"id":20831114,"name":"lumberjack","full_name":"natefinch/lumberjack","owner":{"login":"natefinch","id":3185864,"avatar_url":"https://avatars.githubusercontent.com/u/3185864?v=3","gravatar_id":"","url":"https://api.github.com/users/natefinch","html_url":"https://github.com/natefinch","followers_url":"https://api.github.com/users/natefinch/followers","following_url":"https://api.github.com/users/natefinch/following{/other_user}","gists_url":"https://api.github.com/users/natefinch/gists{/gist_id}","starred_url":"https://api.github.com/users/natefinch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natefinch/subscriptions","organizations_url":"https://api.github.com/users/natefinch/orgs","repos_url":"https://api.github.com/users/natefinch/repos","events_url":"https://api.github.com/users/natefinch/events{/privacy}","received_events_url":"https://api.github.com/users/natefinch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/natefinch/lumberjack","description":"lumberjack is a rolling logger for Go","fork":false,"url":"https://api.github.com/repos/natefinch/lumberjack","forks_url":"https://api.github.com/repos/natefinch/lumberjack/forks","keys_url":"https://api.github.com/repos/natefinch/lumberjack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/natefinch/lumberjack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/natefinch/lumberjack/teams","hooks_url":"https://api.github.com/repos/natefinch/lumberjack/hooks","issue_events_url":"https://api.github.com/repos/natefinch/lumberjack/issues/events{/number}","events_url":"https://api.github.com/repos/natefinch/lumberjack/events","assignees_url":"https://api.github.com/repos/natefinch/lumberjack/assignees{/user}","branches_url":"https://api.github.com/repos/natefinch/lumberjack/branches{/branch}","tags_url":"https://api.github.com/repos/natefinch/lumberjack/tags","blobs_url":"https://api.github.com/repos/natefinch/lumberjack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/natefinch/lumberjack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/natefinch/lumberjack/git/refs{/sha}","trees_url":"https://api.github.com/repos/natefinch/lumberjack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/natefinch/lumberjack/statuses/{sha}","languages_url":"https://api.github.com/repos/natefinch/lumberjack/languages","stargazers_url":"https://api.github.com/repos/natefinch/lumberjack/stargazers","contributors_url":"https://api.github.com/repos/natefinch/lumberjack/contributors","subscribers_url":"https://api.github.com/repos/natefinch/lumberjack/subscribers","subscription_url":"https://api.github.com/repos/natefinch/lumberjack/subscription","commits_url":"https://api.github.com/repos/natefinch/lumberjack/commits{/sha}","git_commits_url":"https://api.github.com/repos/natefinch/lumberjack/git/commits{/sha}","comments_url":"https://api.github.com/repos/natefinch/lumberjack/comments{/number}","issue_comment_url":"https://api.github.com/repos/natefinch/lumberjack/issues/comments{/number}","contents_url":"https://api.github.com/repos/natefinch/lumberjack/contents/{+path}","compare_url":"https://api.github.com/repos/natefinch/lumberjack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/natefinch/lumberjack/merges","archive_url":"https://api.github.com/repos/natefinch/lumberjack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/natefinch/lumberjack/downloads","issues_url":"https://api.github.com/repos/natefinch/lumberjack/issues{/number}","pulls_url":"https://api.github.com/repos/natefinch/lumberjack/pulls{/number}","milestones_url":"https://api.github.com/repos/natefinch/lumberjack/milestones{/number}","notifications_url":"https://api.github.com/repos/natefinch/lumberjack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/natefinch/lumberjack/labels{/name}","releases_url":"https://api.github.com/repos/natefinch/lumberjack/releases{/id}","deployments_url":"https://api.github.com/repos/natefinch/lumberjack/deployments","created_at":"2014-06-14T11:55:47Z","updated_at":"2016-10-22T13:36:41Z","pushed_at":"2016-10-21T03:58:19Z","git_url":"git://github.com/natefinch/lumberjack.git","ssh_url":"git@github.com:natefinch/lumberjack.git","clone_url":"https://github.com/natefinch/lumberjack.git","svn_url":"https://github.com/natefinch/lumberjack","homepage":null,"size":72,"stargazers_count":362,"watchers_count":362,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":8,"forks":54,"open_issues":8,"watchers":362,"default_branch":"v2.0"}},"_links":{"self":{"href":"https://api.github.com/repos/natefinch/lumberjack/pulls/16"},"html":{"href":"https://github.com/natefinch/lumberjack/pull/16"},"issue":{"href":"https://api.github.com/repos/natefinch/lumberjack/issues/16"},"comments":{"href":"https://api.github.com/repos/natefinch/lumberjack/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/natefinch/lumberjack/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/natefinch/lumberjack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/natefinch/lumberjack/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/natefinch/lumberjack/statuses/6e836ae76b5c8920f79dafd745e217cdaa28c8eb"}}}}
{"actor":{"display_login":"natefinch"}}