{"action":"created","issue":{"url":"https://api.github.com/repos/berrandonea/moodle-block_catalogue/issues/5","repository_url":"https://api.github.com/repos/berrandonea/moodle-block_catalogue","labels_url":"https://api.github.com/repos/berrandonea/moodle-block_catalogue/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/berrandonea/moodle-block_catalogue/issues/5/comments","events_url":"https://api.github.com/repos/berrandonea/moodle-block_catalogue/issues/5/events","html_url":"https://github.com/berrandonea/moodle-block_catalogue/issues/5","id":165944077,"number":5,"title":"Hard-coded English language strings","user":{"login":"germanvaleroelizondo","id":2671923,"avatar_url":"https://avatars.githubusercontent.com/u/2671923?v=3","gravatar_id":"","url":"https://api.github.com/users/germanvaleroelizondo","html_url":"https://github.com/germanvaleroelizondo","followers_url":"https://api.github.com/users/germanvaleroelizondo/followers","following_url":"https://api.github.com/users/germanvaleroelizondo/following{/other_user}","gists_url":"https://api.github.com/users/germanvaleroelizondo/gists{/gist_id}","starred_url":"https://api.github.com/users/germanvaleroelizondo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/germanvaleroelizondo/subscriptions","organizations_url":"https://api.github.com/users/germanvaleroelizondo/orgs","repos_url":"https://api.github.com/users/germanvaleroelizondo/repos","events_url":"https://api.github.com/users/germanvaleroelizondo/events{/privacy}","received_events_url":"https://api.github.com/users/germanvaleroelizondo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-07-16T19:32:30Z","updated_at":"2016-09-15T21:17:59Z","closed_at":null,"body":"Hi,\r\n\r\nI have been using your Catalogue plugin for Moodle 2.9 and I like it a lot. I already made the translation in AMOS for the Mexican Spanish language pack..\r\n\r\nI think this plugin would be even more useful for Moodlers of Languages other than English (eg,, French, Spanish, Italian,...) if several of the hard-coded English language strings used could be replaced by variables that can be translated in AMOS.\r\n\r\nMay I firstly suggest you to change the text inside the button that says 'Add to course' ? \r\nNot being a programmer (I am a veterinary pathologist), I guess that this one button-string should not be too difficult to change into a translatable string variable.\r\n\r\nLater, may we talk about the likelihood/difficulty of translating the other more visible English language strings for Resources, Activities, enrolments, Grades, Reports and Blocks ?\r\n\r\nThanks in advance for your help and thanks for contribuiting this nice plugin that I am certain will be very useful for many teachers world-wide."},"comment":{"url":"https://api.github.com/repos/berrandonea/moodle-block_catalogue/issues/comments/247458228","html_url":"https://github.com/berrandonea/moodle-block_catalogue/issues/5#issuecomment-247458228","issue_url":"https://api.github.com/repos/berrandonea/moodle-block_catalogue/issues/5","id":247458228,"user":{"login":"germanvaleroelizondo","id":2671923,"avatar_url":"https://avatars.githubusercontent.com/u/2671923?v=3","gravatar_id":"","url":"https://api.github.com/users/germanvaleroelizondo","html_url":"https://github.com/germanvaleroelizondo","followers_url":"https://api.github.com/users/germanvaleroelizondo/followers","following_url":"https://api.github.com/users/germanvaleroelizondo/following{/other_user}","gists_url":"https://api.github.com/users/germanvaleroelizondo/gists{/gist_id}","starred_url":"https://api.github.com/users/germanvaleroelizondo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/germanvaleroelizondo/subscriptions","organizations_url":"https://api.github.com/users/germanvaleroelizondo/orgs","repos_url":"https://api.github.com/users/germanvaleroelizondo/repos","events_url":"https://api.github.com/users/germanvaleroelizondo/events{/privacy}","received_events_url":"https://api.github.com/users/germanvaleroelizondo/received_events","type":"User","site_admin":false},"created_at":"2016-09-15T21:17:59Z","updated_at":"2016-09-15T21:17:59Z","body":"Hi Brice,\r\nI just noticed that all the strings with issues (in the /lang/en/block_catalogue.php file) are declared inmediately after one empty line.\r\n\r\nI have one silly idea (I am not a programmer), but it would be extremely quick to test.\r\n\r\nCan you please replace these empty blank lines with a simple comment line and upload the modified file into the Moodle plugins database, to see if AMOS would now recognize more strings (than the previous 211), as all the strings with issues are not registed in AMOS.\r\n\r\nThanks in advance for your help."}}
{"actor":{"display_login":"germanvaleroelizondo"}}