{"action":"closed","number":261,"pull_request":{"url":"https://api.github.com/repos/redbadger/website-honestly/pulls/261","id":97966719,"html_url":"https://github.com/redbadger/website-honestly/pull/261","diff_url":"https://github.com/redbadger/website-honestly/pull/261.diff","patch_url":"https://github.com/redbadger/website-honestly/pull/261.patch","issue_url":"https://api.github.com/repos/redbadger/website-honestly/issues/261","number":261,"state":"closed","locked":false,"title":"Typechecking at build time","user":{"login":"JoeStanton","id":1161508,"avatar_url":"https://avatars.githubusercontent.com/u/1161508?v=3","gravatar_id":"","url":"https://api.github.com/users/JoeStanton","html_url":"https://github.com/JoeStanton","followers_url":"https://api.github.com/users/JoeStanton/followers","following_url":"https://api.github.com/users/JoeStanton/following{/other_user}","gists_url":"https://api.github.com/users/JoeStanton/gists{/gist_id}","starred_url":"https://api.github.com/users/JoeStanton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoeStanton/subscriptions","organizations_url":"https://api.github.com/users/JoeStanton/orgs","repos_url":"https://api.github.com/users/JoeStanton/repos","events_url":"https://api.github.com/users/JoeStanton/events{/privacy}","received_events_url":"https://api.github.com/users/JoeStanton/received_events","type":"User","site_admin":false},"body":"### Motivation\r\n\r\nWe have added `babel-plugin-typecheck`, which is only enabled when `BABEL_ENV=typecheck`. It will fail the build whenever Flowtypes for a react component are not satisfied by the state data. This will prevent us pushing a broken build to production.\r\n\r\n### Test plan\r\n\r\nWe've already tested the functionality as part of this branch, see recent builds for more info.\r\n\r\n### Pre-merge checklist\r\n\r\n- [ ] Documentation\r\n- [ ] Unit tests\r\n- [ ] Reviews\r\n  - [ ] Code review\r\n  - [ ] Design review\r\n- [ ] Manual testing\r\n  - [ ] Windows 7 IE 11\r\n  - [ ] Windows 10 Edge\r\n  - [ ] Mac OS El Capitan Safari\r\n  - [ ] Mac OS El Capitan Chrome\r\n  - [ ] Mac OS El Capitan Firefox\r\n  - [ ] iOS 9 Safari\r\n  - [ ] Android 6 Chrome\r\n  - [ ] Listen to the site on a screen reader\r\n  - [ ] Navigate the site using the keyboard only\r\n- [ ] Tester approved\r\n","created_at":"2016-12-14T14:52:28Z","updated_at":"2016-12-14T17:15:38Z","closed_at":"2016-12-14T17:15:38Z","merged_at":"2016-12-14T17:15:38Z","merge_commit_sha":"e311265f00611665503b9b4b9ee45b5aee5f7d08","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/redbadger/website-honestly/pulls/261/commits","review_comments_url":"https://api.github.com/repos/redbadger/website-honestly/pulls/261/comments","review_comment_url":"https://api.github.com/repos/redbadger/website-honestly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/redbadger/website-honestly/issues/261/comments","statuses_url":"https://api.github.com/repos/redbadger/website-honestly/statuses/4ea28e2f80de2fa7924485e6bcc28e90b20d6fd6","head":{"label":"redbadger:typechecking-at-build-time","ref":"typechecking-at-build-time","sha":"4ea28e2f80de2fa7924485e6bcc28e90b20d6fd6","user":{"login":"redbadger","id":265650,"avatar_url":"https://avatars.githubusercontent.com/u/265650?v=3","gravatar_id":"","url":"https://api.github.com/users/redbadger","html_url":"https://github.com/redbadger","followers_url":"https://api.github.com/users/redbadger/followers","following_url":"https://api.github.com/users/redbadger/following{/other_user}","gists_url":"https://api.github.com/users/redbadger/gists{/gist_id}","starred_url":"https://api.github.com/users/redbadger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redbadger/subscriptions","organizations_url":"https://api.github.com/users/redbadger/orgs","repos_url":"https://api.github.com/users/redbadger/repos","events_url":"https://api.github.com/users/redbadger/events{/privacy}","received_events_url":"https://api.github.com/users/redbadger/received_events","type":"Organization","site_admin":false},"repo":{"id":68023701,"name":"website-honestly","full_name":"redbadger/website-honestly","owner":{"login":"redbadger","id":265650,"avatar_url":"https://avatars.githubusercontent.com/u/265650?v=3","gravatar_id":"","url":"https://api.github.com/users/redbadger","html_url":"https://github.com/redbadger","followers_url":"https://api.github.com/users/redbadger/followers","following_url":"https://api.github.com/users/redbadger/following{/other_user}","gists_url":"https://api.github.com/users/redbadger/gists{/gist_id}","starred_url":"https://api.github.com/users/redbadger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redbadger/subscriptions","organizations_url":"https://api.github.com/users/redbadger/orgs","repos_url":"https://api.github.com/users/redbadger/repos","events_url":"https://api.github.com/users/redbadger/events{/privacy}","received_events_url":"https://api.github.com/users/redbadger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/redbadger/website-honestly","description":"🦄 The Red Badger website. Honestly.","fork":false,"url":"https://api.github.com/repos/redbadger/website-honestly","forks_url":"https://api.github.com/repos/redbadger/website-honestly/forks","keys_url":"https://api.github.com/repos/redbadger/website-honestly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redbadger/website-honestly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redbadger/website-honestly/teams","hooks_url":"https://api.github.com/repos/redbadger/website-honestly/hooks","issue_events_url":"https://api.github.com/repos/redbadger/website-honestly/issues/events{/number}","events_url":"https://api.github.com/repos/redbadger/website-honestly/events","assignees_url":"https://api.github.com/repos/redbadger/website-honestly/assignees{/user}","branches_url":"https://api.github.com/repos/redbadger/website-honestly/branches{/branch}","tags_url":"https://api.github.com/repos/redbadger/website-honestly/tags","blobs_url":"https://api.github.com/repos/redbadger/website-honestly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redbadger/website-honestly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redbadger/website-honestly/git/refs{/sha}","trees_url":"https://api.github.com/repos/redbadger/website-honestly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redbadger/website-honestly/statuses/{sha}","languages_url":"https://api.github.com/repos/redbadger/website-honestly/languages","stargazers_url":"https://api.github.com/repos/redbadger/website-honestly/stargazers","contributors_url":"https://api.github.com/repos/redbadger/website-honestly/contributors","subscribers_url":"https://api.github.com/repos/redbadger/website-honestly/subscribers","subscription_url":"https://api.github.com/repos/redbadger/website-honestly/subscription","commits_url":"https://api.github.com/repos/redbadger/website-honestly/commits{/sha}","git_commits_url":"https://api.github.com/repos/redbadger/website-honestly/git/commits{/sha}","comments_url":"https://api.github.com/repos/redbadger/website-honestly/comments{/number}","issue_comment_url":"https://api.github.com/repos/redbadger/website-honestly/issues/comments{/number}","contents_url":"https://api.github.com/repos/redbadger/website-honestly/contents/{+path}","compare_url":"https://api.github.com/repos/redbadger/website-honestly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redbadger/website-honestly/merges","archive_url":"https://api.github.com/repos/redbadger/website-honestly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redbadger/website-honestly/downloads","issues_url":"https://api.github.com/repos/redbadger/website-honestly/issues{/number}","pulls_url":"https://api.github.com/repos/redbadger/website-honestly/pulls{/number}","milestones_url":"https://api.github.com/repos/redbadger/website-honestly/milestones{/number}","notifications_url":"https://api.github.com/repos/redbadger/website-honestly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redbadger/website-honestly/labels{/name}","releases_url":"https://api.github.com/repos/redbadger/website-honestly/releases{/id}","deployments_url":"https://api.github.com/repos/redbadger/website-honestly/deployments","created_at":"2016-09-12T15:50:54Z","updated_at":"2016-12-01T09:49:29Z","pushed_at":"2016-12-14T17:15:38Z","git_url":"git://github.com/redbadger/website-honestly.git","ssh_url":"git@github.com:redbadger/website-honestly.git","clone_url":"https://github.com/redbadger/website-honestly.git","svn_url":"https://github.com/redbadger/website-honestly","homepage":"https://red-badger.com","size":8813,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":35,"forks":1,"open_issues":35,"watchers":7,"default_branch":"master"}},"base":{"label":"redbadger:master","ref":"master","sha":"05f68187534b2ebbc9b3f106e148330d987c2349","user":{"login":"redbadger","id":265650,"avatar_url":"https://avatars.githubusercontent.com/u/265650?v=3","gravatar_id":"","url":"https://api.github.com/users/redbadger","html_url":"https://github.com/redbadger","followers_url":"https://api.github.com/users/redbadger/followers","following_url":"https://api.github.com/users/redbadger/following{/other_user}","gists_url":"https://api.github.com/users/redbadger/gists{/gist_id}","starred_url":"https://api.github.com/users/redbadger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redbadger/subscriptions","organizations_url":"https://api.github.com/users/redbadger/orgs","repos_url":"https://api.github.com/users/redbadger/repos","events_url":"https://api.github.com/users/redbadger/events{/privacy}","received_events_url":"https://api.github.com/users/redbadger/received_events","type":"Organization","site_admin":false},"repo":{"id":68023701,"name":"website-honestly","full_name":"redbadger/website-honestly","owner":{"login":"redbadger","id":265650,"avatar_url":"https://avatars.githubusercontent.com/u/265650?v=3","gravatar_id":"","url":"https://api.github.com/users/redbadger","html_url":"https://github.com/redbadger","followers_url":"https://api.github.com/users/redbadger/followers","following_url":"https://api.github.com/users/redbadger/following{/other_user}","gists_url":"https://api.github.com/users/redbadger/gists{/gist_id}","starred_url":"https://api.github.com/users/redbadger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redbadger/subscriptions","organizations_url":"https://api.github.com/users/redbadger/orgs","repos_url":"https://api.github.com/users/redbadger/repos","events_url":"https://api.github.com/users/redbadger/events{/privacy}","received_events_url":"https://api.github.com/users/redbadger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/redbadger/website-honestly","description":"🦄 The Red Badger website. Honestly.","fork":false,"url":"https://api.github.com/repos/redbadger/website-honestly","forks_url":"https://api.github.com/repos/redbadger/website-honestly/forks","keys_url":"https://api.github.com/repos/redbadger/website-honestly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redbadger/website-honestly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redbadger/website-honestly/teams","hooks_url":"https://api.github.com/repos/redbadger/website-honestly/hooks","issue_events_url":"https://api.github.com/repos/redbadger/website-honestly/issues/events{/number}","events_url":"https://api.github.com/repos/redbadger/website-honestly/events","assignees_url":"https://api.github.com/repos/redbadger/website-honestly/assignees{/user}","branches_url":"https://api.github.com/repos/redbadger/website-honestly/branches{/branch}","tags_url":"https://api.github.com/repos/redbadger/website-honestly/tags","blobs_url":"https://api.github.com/repos/redbadger/website-honestly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redbadger/website-honestly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redbadger/website-honestly/git/refs{/sha}","trees_url":"https://api.github.com/repos/redbadger/website-honestly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redbadger/website-honestly/statuses/{sha}","languages_url":"https://api.github.com/repos/redbadger/website-honestly/languages","stargazers_url":"https://api.github.com/repos/redbadger/website-honestly/stargazers","contributors_url":"https://api.github.com/repos/redbadger/website-honestly/contributors","subscribers_url":"https://api.github.com/repos/redbadger/website-honestly/subscribers","subscription_url":"https://api.github.com/repos/redbadger/website-honestly/subscription","commits_url":"https://api.github.com/repos/redbadger/website-honestly/commits{/sha}","git_commits_url":"https://api.github.com/repos/redbadger/website-honestly/git/commits{/sha}","comments_url":"https://api.github.com/repos/redbadger/website-honestly/comments{/number}","issue_comment_url":"https://api.github.com/repos/redbadger/website-honestly/issues/comments{/number}","contents_url":"https://api.github.com/repos/redbadger/website-honestly/contents/{+path}","compare_url":"https://api.github.com/repos/redbadger/website-honestly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redbadger/website-honestly/merges","archive_url":"https://api.github.com/repos/redbadger/website-honestly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redbadger/website-honestly/downloads","issues_url":"https://api.github.com/repos/redbadger/website-honestly/issues{/number}","pulls_url":"https://api.github.com/repos/redbadger/website-honestly/pulls{/number}","milestones_url":"https://api.github.com/repos/redbadger/website-honestly/milestones{/number}","notifications_url":"https://api.github.com/repos/redbadger/website-honestly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redbadger/website-honestly/labels{/name}","releases_url":"https://api.github.com/repos/redbadger/website-honestly/releases{/id}","deployments_url":"https://api.github.com/repos/redbadger/website-honestly/deployments","created_at":"2016-09-12T15:50:54Z","updated_at":"2016-12-01T09:49:29Z","pushed_at":"2016-12-14T17:15:38Z","git_url":"git://github.com/redbadger/website-honestly.git","ssh_url":"git@github.com:redbadger/website-honestly.git","clone_url":"https://github.com/redbadger/website-honestly.git","svn_url":"https://github.com/redbadger/website-honestly","homepage":"https://red-badger.com","size":8813,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":35,"forks":1,"open_issues":35,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/redbadger/website-honestly/pulls/261"},"html":{"href":"https://github.com/redbadger/website-honestly/pull/261"},"issue":{"href":"https://api.github.com/repos/redbadger/website-honestly/issues/261"},"comments":{"href":"https://api.github.com/repos/redbadger/website-honestly/issues/261/comments"},"review_comments":{"href":"https://api.github.com/repos/redbadger/website-honestly/pulls/261/comments"},"review_comment":{"href":"https://api.github.com/repos/redbadger/website-honestly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/redbadger/website-honestly/pulls/261/commits"},"statuses":{"href":"https://api.github.com/repos/redbadger/website-honestly/statuses/4ea28e2f80de2fa7924485e6bcc28e90b20d6fd6"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"asavin","id":487468,"avatar_url":"https://avatars.githubusercontent.com/u/487468?v=3","gravatar_id":"","url":"https://api.github.com/users/asavin","html_url":"https://github.com/asavin","followers_url":"https://api.github.com/users/asavin/followers","following_url":"https://api.github.com/users/asavin/following{/other_user}","gists_url":"https://api.github.com/users/asavin/gists{/gist_id}","starred_url":"https://api.github.com/users/asavin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asavin/subscriptions","organizations_url":"https://api.github.com/users/asavin/orgs","repos_url":"https://api.github.com/users/asavin/repos","events_url":"https://api.github.com/users/asavin/events{/privacy}","received_events_url":"https://api.github.com/users/asavin/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":4,"additions":72,"deletions":40,"changed_files":12}}
{"actor":{"display_login":"asavin"}}