{"action":"closed","number":12,"pull_request":{"url":"https://api.github.com/repos/proninyaroslav/libretorrent/pulls/12","id":90491875,"html_url":"https://github.com/proninyaroslav/libretorrent/pull/12","diff_url":"https://github.com/proninyaroslav/libretorrent/pull/12.diff","patch_url":"https://github.com/proninyaroslav/libretorrent/pull/12.patch","issue_url":"https://api.github.com/repos/proninyaroslav/libretorrent/issues/12","number":12,"state":"closed","locked":false,"title":"remove unstranslatable string from german localised strings","user":{"login":"harkin","id":3344901,"avatar_url":"https://avatars.githubusercontent.com/u/3344901?v=3","gravatar_id":"","url":"https://api.github.com/users/harkin","html_url":"https://github.com/harkin","followers_url":"https://api.github.com/users/harkin/followers","following_url":"https://api.github.com/users/harkin/following{/other_user}","gists_url":"https://api.github.com/users/harkin/gists{/gist_id}","starred_url":"https://api.github.com/users/harkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harkin/subscriptions","organizations_url":"https://api.github.com/users/harkin/orgs","repos_url":"https://api.github.com/users/harkin/repos","events_url":"https://api.github.com/users/harkin/events{/privacy}","received_events_url":"https://api.github.com/users/harkin/received_events","type":"User","site_admin":false},"body":"The `lintVitalRelease` gradle task fails when there's an untranslatable string in one of the localised strings files\r\n\r\n`./gradlew lintVitalRelease` if you want to check, sample output:\r\n```\r\n:app:lintVitalRelease\r\n/path/to/libretorrent/app/src/main/res/values-de/strings.xml:4: Error: Non-translatable resources should only be defined in the base values/ folder [ExtraTranslation]\r\n    <string name=\"app_name\" translatable=\"false\">LibreTorrent</string>\r\n                            ~~~~~~~~~~~~~~~~~~~~\r\n\r\n   Explanation for issues of type \"ExtraTranslation\":\r\n   If a string appears in a specific language translation file, but there is\r\n   no corresponding string in the default locale, then this string is probably\r\n   unused. (It's technically possible that your application is only intended\r\n   to run in a specific locale, but it's still a good idea to provide a\r\n   fallback.).\r\n\r\n   Note that these strings can lead to crashes if the string is looked up on\r\n   any locale not providing a translation, so it's important to clean them\r\n   up.\r\n\r\n1 errors, 0 warnings\r\n:app:lintVitalRelease FAILED\r\n```","created_at":"2016-10-22T19:02:48Z","updated_at":"2016-10-22T19:19:13Z","closed_at":"2016-10-22T19:19:13Z","merged_at":"2016-10-22T19:19:13Z","merge_commit_sha":"113bcf763edd91eb2497aafba3cf97e091e1062a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/proninyaroslav/libretorrent/pulls/12/commits","review_comments_url":"https://api.github.com/repos/proninyaroslav/libretorrent/pulls/12/comments","review_comment_url":"https://api.github.com/repos/proninyaroslav/libretorrent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/proninyaroslav/libretorrent/issues/12/comments","statuses_url":"https://api.github.com/repos/proninyaroslav/libretorrent/statuses/3799035667f8b492c60b620816ce49e05968be97","head":{"label":"harkin:untranslatable-string","ref":"untranslatable-string","sha":"3799035667f8b492c60b620816ce49e05968be97","user":{"login":"harkin","id":3344901,"avatar_url":"https://avatars.githubusercontent.com/u/3344901?v=3","gravatar_id":"","url":"https://api.github.com/users/harkin","html_url":"https://github.com/harkin","followers_url":"https://api.github.com/users/harkin/followers","following_url":"https://api.github.com/users/harkin/following{/other_user}","gists_url":"https://api.github.com/users/harkin/gists{/gist_id}","starred_url":"https://api.github.com/users/harkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harkin/subscriptions","organizations_url":"https://api.github.com/users/harkin/orgs","repos_url":"https://api.github.com/users/harkin/repos","events_url":"https://api.github.com/users/harkin/events{/privacy}","received_events_url":"https://api.github.com/users/harkin/received_events","type":"User","site_admin":false},"repo":{"id":71657744,"name":"libretorrent","full_name":"harkin/libretorrent","owner":{"login":"harkin","id":3344901,"avatar_url":"https://avatars.githubusercontent.com/u/3344901?v=3","gravatar_id":"","url":"https://api.github.com/users/harkin","html_url":"https://github.com/harkin","followers_url":"https://api.github.com/users/harkin/followers","following_url":"https://api.github.com/users/harkin/following{/other_user}","gists_url":"https://api.github.com/users/harkin/gists{/gist_id}","starred_url":"https://api.github.com/users/harkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harkin/subscriptions","organizations_url":"https://api.github.com/users/harkin/orgs","repos_url":"https://api.github.com/users/harkin/repos","events_url":"https://api.github.com/users/harkin/events{/privacy}","received_events_url":"https://api.github.com/users/harkin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/harkin/libretorrent","description":"Free as in Freedom torrent client for Android 4+, based on libtorrent","fork":true,"url":"https://api.github.com/repos/harkin/libretorrent","forks_url":"https://api.github.com/repos/harkin/libretorrent/forks","keys_url":"https://api.github.com/repos/harkin/libretorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harkin/libretorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harkin/libretorrent/teams","hooks_url":"https://api.github.com/repos/harkin/libretorrent/hooks","issue_events_url":"https://api.github.com/repos/harkin/libretorrent/issues/events{/number}","events_url":"https://api.github.com/repos/harkin/libretorrent/events","assignees_url":"https://api.github.com/repos/harkin/libretorrent/assignees{/user}","branches_url":"https://api.github.com/repos/harkin/libretorrent/branches{/branch}","tags_url":"https://api.github.com/repos/harkin/libretorrent/tags","blobs_url":"https://api.github.com/repos/harkin/libretorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harkin/libretorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harkin/libretorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/harkin/libretorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harkin/libretorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/harkin/libretorrent/languages","stargazers_url":"https://api.github.com/repos/harkin/libretorrent/stargazers","contributors_url":"https://api.github.com/repos/harkin/libretorrent/contributors","subscribers_url":"https://api.github.com/repos/harkin/libretorrent/subscribers","subscription_url":"https://api.github.com/repos/harkin/libretorrent/subscription","commits_url":"https://api.github.com/repos/harkin/libretorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/harkin/libretorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/harkin/libretorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/harkin/libretorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/harkin/libretorrent/contents/{+path}","compare_url":"https://api.github.com/repos/harkin/libretorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harkin/libretorrent/merges","archive_url":"https://api.github.com/repos/harkin/libretorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harkin/libretorrent/downloads","issues_url":"https://api.github.com/repos/harkin/libretorrent/issues{/number}","pulls_url":"https://api.github.com/repos/harkin/libretorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/harkin/libretorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/harkin/libretorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harkin/libretorrent/labels{/name}","releases_url":"https://api.github.com/repos/harkin/libretorrent/releases{/id}","deployments_url":"https://api.github.com/repos/harkin/libretorrent/deployments","created_at":"2016-10-22T18:24:22Z","updated_at":"2016-10-22T18:24:24Z","pushed_at":"2016-10-22T18:59:15Z","git_url":"git://github.com/harkin/libretorrent.git","ssh_url":"git@github.com:harkin/libretorrent.git","clone_url":"https://github.com/harkin/libretorrent.git","svn_url":"https://github.com/harkin/libretorrent","homepage":"","size":565,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"proninyaroslav:master","ref":"master","sha":"e1b0f839c75aa2170146c00975b3ab5bb633bb93","user":{"login":"proninyaroslav","id":7840559,"avatar_url":"https://avatars.githubusercontent.com/u/7840559?v=3","gravatar_id":"","url":"https://api.github.com/users/proninyaroslav","html_url":"https://github.com/proninyaroslav","followers_url":"https://api.github.com/users/proninyaroslav/followers","following_url":"https://api.github.com/users/proninyaroslav/following{/other_user}","gists_url":"https://api.github.com/users/proninyaroslav/gists{/gist_id}","starred_url":"https://api.github.com/users/proninyaroslav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/proninyaroslav/subscriptions","organizations_url":"https://api.github.com/users/proninyaroslav/orgs","repos_url":"https://api.github.com/users/proninyaroslav/repos","events_url":"https://api.github.com/users/proninyaroslav/events{/privacy}","received_events_url":"https://api.github.com/users/proninyaroslav/received_events","type":"User","site_admin":false},"repo":{"id":71263775,"name":"libretorrent","full_name":"proninyaroslav/libretorrent","owner":{"login":"proninyaroslav","id":7840559,"avatar_url":"https://avatars.githubusercontent.com/u/7840559?v=3","gravatar_id":"","url":"https://api.github.com/users/proninyaroslav","html_url":"https://github.com/proninyaroslav","followers_url":"https://api.github.com/users/proninyaroslav/followers","following_url":"https://api.github.com/users/proninyaroslav/following{/other_user}","gists_url":"https://api.github.com/users/proninyaroslav/gists{/gist_id}","starred_url":"https://api.github.com/users/proninyaroslav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/proninyaroslav/subscriptions","organizations_url":"https://api.github.com/users/proninyaroslav/orgs","repos_url":"https://api.github.com/users/proninyaroslav/repos","events_url":"https://api.github.com/users/proninyaroslav/events{/privacy}","received_events_url":"https://api.github.com/users/proninyaroslav/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/proninyaroslav/libretorrent","description":"Free as in Freedom torrent client for Android 4+, based on libtorrent","fork":false,"url":"https://api.github.com/repos/proninyaroslav/libretorrent","forks_url":"https://api.github.com/repos/proninyaroslav/libretorrent/forks","keys_url":"https://api.github.com/repos/proninyaroslav/libretorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/proninyaroslav/libretorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/proninyaroslav/libretorrent/teams","hooks_url":"https://api.github.com/repos/proninyaroslav/libretorrent/hooks","issue_events_url":"https://api.github.com/repos/proninyaroslav/libretorrent/issues/events{/number}","events_url":"https://api.github.com/repos/proninyaroslav/libretorrent/events","assignees_url":"https://api.github.com/repos/proninyaroslav/libretorrent/assignees{/user}","branches_url":"https://api.github.com/repos/proninyaroslav/libretorrent/branches{/branch}","tags_url":"https://api.github.com/repos/proninyaroslav/libretorrent/tags","blobs_url":"https://api.github.com/repos/proninyaroslav/libretorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/proninyaroslav/libretorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/proninyaroslav/libretorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/proninyaroslav/libretorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/proninyaroslav/libretorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/proninyaroslav/libretorrent/languages","stargazers_url":"https://api.github.com/repos/proninyaroslav/libretorrent/stargazers","contributors_url":"https://api.github.com/repos/proninyaroslav/libretorrent/contributors","subscribers_url":"https://api.github.com/repos/proninyaroslav/libretorrent/subscribers","subscription_url":"https://api.github.com/repos/proninyaroslav/libretorrent/subscription","commits_url":"https://api.github.com/repos/proninyaroslav/libretorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/proninyaroslav/libretorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/proninyaroslav/libretorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/proninyaroslav/libretorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/proninyaroslav/libretorrent/contents/{+path}","compare_url":"https://api.github.com/repos/proninyaroslav/libretorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/proninyaroslav/libretorrent/merges","archive_url":"https://api.github.com/repos/proninyaroslav/libretorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/proninyaroslav/libretorrent/downloads","issues_url":"https://api.github.com/repos/proninyaroslav/libretorrent/issues{/number}","pulls_url":"https://api.github.com/repos/proninyaroslav/libretorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/proninyaroslav/libretorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/proninyaroslav/libretorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/proninyaroslav/libretorrent/labels{/name}","releases_url":"https://api.github.com/repos/proninyaroslav/libretorrent/releases{/id}","deployments_url":"https://api.github.com/repos/proninyaroslav/libretorrent/deployments","created_at":"2016-10-18T15:38:44Z","updated_at":"2016-10-22T16:32:24Z","pushed_at":"2016-10-22T19:19:13Z","git_url":"git://github.com/proninyaroslav/libretorrent.git","ssh_url":"git@github.com:proninyaroslav/libretorrent.git","clone_url":"https://github.com/proninyaroslav/libretorrent.git","svn_url":"https://github.com/proninyaroslav/libretorrent","homepage":"","size":565,"stargazers_count":155,"watchers_count":155,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":8,"forks":17,"open_issues":8,"watchers":155,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/proninyaroslav/libretorrent/pulls/12"},"html":{"href":"https://github.com/proninyaroslav/libretorrent/pull/12"},"issue":{"href":"https://api.github.com/repos/proninyaroslav/libretorrent/issues/12"},"comments":{"href":"https://api.github.com/repos/proninyaroslav/libretorrent/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/proninyaroslav/libretorrent/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/proninyaroslav/libretorrent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/proninyaroslav/libretorrent/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/proninyaroslav/libretorrent/statuses/3799035667f8b492c60b620816ce49e05968be97"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"proninyaroslav","id":7840559,"avatar_url":"https://avatars.githubusercontent.com/u/7840559?v=3","gravatar_id":"","url":"https://api.github.com/users/proninyaroslav","html_url":"https://github.com/proninyaroslav","followers_url":"https://api.github.com/users/proninyaroslav/followers","following_url":"https://api.github.com/users/proninyaroslav/following{/other_user}","gists_url":"https://api.github.com/users/proninyaroslav/gists{/gist_id}","starred_url":"https://api.github.com/users/proninyaroslav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/proninyaroslav/subscriptions","organizations_url":"https://api.github.com/users/proninyaroslav/orgs","repos_url":"https://api.github.com/users/proninyaroslav/repos","events_url":"https://api.github.com/users/proninyaroslav/events{/privacy}","received_events_url":"https://api.github.com/users/proninyaroslav/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":0,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"proninyaroslav"}}