{"action":"created","issue":{"url":"https://api.github.com/repos/ramda/ramda/issues/1748","repository_url":"https://api.github.com/repos/ramda/ramda","labels_url":"https://api.github.com/repos/ramda/ramda/issues/1748/labels{/name}","comments_url":"https://api.github.com/repos/ramda/ramda/issues/1748/comments","events_url":"https://api.github.com/repos/ramda/ramda/issues/1748/events","html_url":"https://github.com/ramda/ramda/pull/1748","id":150499990,"number":1748,"title":"improve perf of propEq and propIs","user":{"login":"benji6","id":8782055,"avatar_url":"https://avatars.githubusercontent.com/u/8782055?v=3","gravatar_id":"","url":"https://api.github.com/users/benji6","html_url":"https://github.com/benji6","followers_url":"https://api.github.com/users/benji6/followers","following_url":"https://api.github.com/users/benji6/following{/other_user}","gists_url":"https://api.github.com/users/benji6/gists{/gist_id}","starred_url":"https://api.github.com/users/benji6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benji6/subscriptions","organizations_url":"https://api.github.com/users/benji6/orgs","repos_url":"https://api.github.com/users/benji6/repos","events_url":"https://api.github.com/users/benji6/events{/privacy}","received_events_url":"https://api.github.com/users/benji6/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-04-23T00:23:34Z","updated_at":"2016-04-23T00:30:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ramda/ramda/pulls/1748","html_url":"https://github.com/ramda/ramda/pull/1748","diff_url":"https://github.com/ramda/ramda/pull/1748.diff","patch_url":"https://github.com/ramda/ramda/pull/1748.patch"},"body":"I think defining `propEq` and `propIs` in terms of `propSatisfies` is elegant, but having had problems using these functions on large lists I feel performance is probably more important.\r\n\r\nI added a benchmark for `propEq` and had these results running locally:\r\n\r\n```\r\n# original definition\r\npropEq(\"value\", [1, 2… │ 368,588Hz │ 2.06% error margin\r\n\r\n# new definition\r\npropEq(\"value\", [1, 2… │ 438,435Hz │ 1.79% error margin\r\n```\r\nCould add a benchmark for `propIs` too but I expect the results would be quite similar.\r\n\r\nLet me know what you think"},"comment":{"url":"https://api.github.com/repos/ramda/ramda/issues/comments/213635243","html_url":"https://github.com/ramda/ramda/pull/1748#issuecomment-213635243","issue_url":"https://api.github.com/repos/ramda/ramda/issues/1748","id":213635243,"user":{"login":"buzzdecafe","id":716260,"avatar_url":"https://avatars.githubusercontent.com/u/716260?v=3","gravatar_id":"","url":"https://api.github.com/users/buzzdecafe","html_url":"https://github.com/buzzdecafe","followers_url":"https://api.github.com/users/buzzdecafe/followers","following_url":"https://api.github.com/users/buzzdecafe/following{/other_user}","gists_url":"https://api.github.com/users/buzzdecafe/gists{/gist_id}","starred_url":"https://api.github.com/users/buzzdecafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buzzdecafe/subscriptions","organizations_url":"https://api.github.com/users/buzzdecafe/orgs","repos_url":"https://api.github.com/users/buzzdecafe/repos","events_url":"https://api.github.com/users/buzzdecafe/events{/privacy}","received_events_url":"https://api.github.com/users/buzzdecafe/received_events","type":"User","site_admin":false},"created_at":"2016-04-23T00:30:11Z","updated_at":"2016-04-23T00:30:11Z","body":"me too :cow2:"}}