{"action":"created","comment":{"url":"https://api.github.com/repos/rackerlabs/blueflood/pulls/comments/54303516","id":54303516,"diff_hunk":"@@ -145,8 +164,15 @@ public boolean isValid() {\n         public void setTenantId(String tenantId) { this.tenantId = tenantId; }\n \n         @JsonIgnore\n-        public boolean isValid() {\n-            return (tenantId != null && super.isValid());\n+        public List<String> getValidationErrors() {\n+\n+            List<String> errors = super.getValidationErrors();\n+\n+            if( tenantId == null ) {","path":"blueflood-core/src/main/java/com/rackspacecloud/blueflood/inputs/formats/JSONMetricsContainer.java","position":82,"original_position":82,"commit_id":"e68b98f798fb0ccc4fa68101be46a0bac80fb2c3","original_commit_id":"e68b98f798fb0ccc4fa68101be46a0bac80fb2c3","user":{"login":"ChandraAddala","id":1525859,"avatar_url":"https://avatars.githubusercontent.com/u/1525859?v=3","gravatar_id":"","url":"https://api.github.com/users/ChandraAddala","html_url":"https://github.com/ChandraAddala","followers_url":"https://api.github.com/users/ChandraAddala/followers","following_url":"https://api.github.com/users/ChandraAddala/following{/other_user}","gists_url":"https://api.github.com/users/ChandraAddala/gists{/gist_id}","starred_url":"https://api.github.com/users/ChandraAddala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChandraAddala/subscriptions","organizations_url":"https://api.github.com/users/ChandraAddala/orgs","repos_url":"https://api.github.com/users/ChandraAddala/repos","events_url":"https://api.github.com/users/ChandraAddala/events{/privacy}","received_events_url":"https://api.github.com/users/ChandraAddala/received_events","type":"User","site_admin":false},"body":"Is empty tenant id okay?","created_at":"2016-02-26T21:18:55Z","updated_at":"2016-02-26T21:18:55Z","html_url":"https://github.com/rackerlabs/blueflood/pull/633#discussion_r54303516","pull_request_url":"https://api.github.com/repos/rackerlabs/blueflood/pulls/633","_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/blueflood/pulls/comments/54303516"},"html":{"href":"https://github.com/rackerlabs/blueflood/pull/633#discussion_r54303516"},"pull_request":{"href":"https://api.github.com/repos/rackerlabs/blueflood/pulls/633"}}},"pull_request":{"url":"https://api.github.com/repos/rackerlabs/blueflood/pulls/633","id":60715059,"html_url":"https://github.com/rackerlabs/blueflood/pull/633","diff_url":"https://github.com/rackerlabs/blueflood/pull/633.diff","patch_url":"https://github.com/rackerlabs/blueflood/pull/633.patch","issue_url":"https://api.github.com/repos/rackerlabs/blueflood/issues/633","number":633,"state":"open","locked":false,"title":"Adding verification to the attribute 'collectionTime' in a client's ingestion request","user":{"login":"usnavi","id":1426961,"avatar_url":"https://avatars.githubusercontent.com/u/1426961?v=3","gravatar_id":"","url":"https://api.github.com/users/usnavi","html_url":"https://github.com/usnavi","followers_url":"https://api.github.com/users/usnavi/followers","following_url":"https://api.github.com/users/usnavi/following{/other_user}","gists_url":"https://api.github.com/users/usnavi/gists{/gist_id}","starred_url":"https://api.github.com/users/usnavi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usnavi/subscriptions","organizations_url":"https://api.github.com/users/usnavi/orgs","repos_url":"https://api.github.com/users/usnavi/repos","events_url":"https://api.github.com/users/usnavi/events{/privacy}","received_events_url":"https://api.github.com/users/usnavi/received_events","type":"User","site_admin":false},"body":"The collectionTIme can't be older then ```current time - BEFORE_CURRRENT_COLLECTIONTIME_MS``` or newer than ```current time  + AFTER_CURRENT_COLLECTIONTIME_MS```.\r\n\r\nAlso added error messages for the HTTP repsonse body which enumerate the following errors:\r\n- no tenantId, when required\r\n- collectionTime too old\r\n- collectionTime too new","created_at":"2016-02-25T17:22:29Z","updated_at":"2016-02-26T21:18:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea0d8e22752adf387298680393579dc4d7dae62f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rackerlabs/blueflood/pulls/633/commits","review_comments_url":"https://api.github.com/repos/rackerlabs/blueflood/pulls/633/comments","review_comment_url":"https://api.github.com/repos/rackerlabs/blueflood/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rackerlabs/blueflood/issues/633/comments","statuses_url":"https://api.github.com/repos/rackerlabs/blueflood/statuses/e68b98f798fb0ccc4fa68101be46a0bac80fb2c3","head":{"label":"usnavi:verify_timestamp","ref":"verify_timestamp","sha":"e68b98f798fb0ccc4fa68101be46a0bac80fb2c3","user":{"login":"usnavi","id":1426961,"avatar_url":"https://avatars.githubusercontent.com/u/1426961?v=3","gravatar_id":"","url":"https://api.github.com/users/usnavi","html_url":"https://github.com/usnavi","followers_url":"https://api.github.com/users/usnavi/followers","following_url":"https://api.github.com/users/usnavi/following{/other_user}","gists_url":"https://api.github.com/users/usnavi/gists{/gist_id}","starred_url":"https://api.github.com/users/usnavi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usnavi/subscriptions","organizations_url":"https://api.github.com/users/usnavi/orgs","repos_url":"https://api.github.com/users/usnavi/repos","events_url":"https://api.github.com/users/usnavi/events{/privacy}","received_events_url":"https://api.github.com/users/usnavi/received_events","type":"User","site_admin":false},"repo":{"id":45408967,"name":"blueflood","full_name":"usnavi/blueflood","owner":{"login":"usnavi","id":1426961,"avatar_url":"https://avatars.githubusercontent.com/u/1426961?v=3","gravatar_id":"","url":"https://api.github.com/users/usnavi","html_url":"https://github.com/usnavi","followers_url":"https://api.github.com/users/usnavi/followers","following_url":"https://api.github.com/users/usnavi/following{/other_user}","gists_url":"https://api.github.com/users/usnavi/gists{/gist_id}","starred_url":"https://api.github.com/users/usnavi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usnavi/subscriptions","organizations_url":"https://api.github.com/users/usnavi/orgs","repos_url":"https://api.github.com/users/usnavi/repos","events_url":"https://api.github.com/users/usnavi/events{/privacy}","received_events_url":"https://api.github.com/users/usnavi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/usnavi/blueflood","description":"A distributed system designed to ingest and process time series data","fork":true,"url":"https://api.github.com/repos/usnavi/blueflood","forks_url":"https://api.github.com/repos/usnavi/blueflood/forks","keys_url":"https://api.github.com/repos/usnavi/blueflood/keys{/key_id}","collaborators_url":"https://api.github.com/repos/usnavi/blueflood/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/usnavi/blueflood/teams","hooks_url":"https://api.github.com/repos/usnavi/blueflood/hooks","issue_events_url":"https://api.github.com/repos/usnavi/blueflood/issues/events{/number}","events_url":"https://api.github.com/repos/usnavi/blueflood/events","assignees_url":"https://api.github.com/repos/usnavi/blueflood/assignees{/user}","branches_url":"https://api.github.com/repos/usnavi/blueflood/branches{/branch}","tags_url":"https://api.github.com/repos/usnavi/blueflood/tags","blobs_url":"https://api.github.com/repos/usnavi/blueflood/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/usnavi/blueflood/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/usnavi/blueflood/git/refs{/sha}","trees_url":"https://api.github.com/repos/usnavi/blueflood/git/trees{/sha}","statuses_url":"https://api.github.com/repos/usnavi/blueflood/statuses/{sha}","languages_url":"https://api.github.com/repos/usnavi/blueflood/languages","stargazers_url":"https://api.github.com/repos/usnavi/blueflood/stargazers","contributors_url":"https://api.github.com/repos/usnavi/blueflood/contributors","subscribers_url":"https://api.github.com/repos/usnavi/blueflood/subscribers","subscription_url":"https://api.github.com/repos/usnavi/blueflood/subscription","commits_url":"https://api.github.com/repos/usnavi/blueflood/commits{/sha}","git_commits_url":"https://api.github.com/repos/usnavi/blueflood/git/commits{/sha}","comments_url":"https://api.github.com/repos/usnavi/blueflood/comments{/number}","issue_comment_url":"https://api.github.com/repos/usnavi/blueflood/issues/comments{/number}","contents_url":"https://api.github.com/repos/usnavi/blueflood/contents/{+path}","compare_url":"https://api.github.com/repos/usnavi/blueflood/compare/{base}...{head}","merges_url":"https://api.github.com/repos/usnavi/blueflood/merges","archive_url":"https://api.github.com/repos/usnavi/blueflood/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/usnavi/blueflood/downloads","issues_url":"https://api.github.com/repos/usnavi/blueflood/issues{/number}","pulls_url":"https://api.github.com/repos/usnavi/blueflood/pulls{/number}","milestones_url":"https://api.github.com/repos/usnavi/blueflood/milestones{/number}","notifications_url":"https://api.github.com/repos/usnavi/blueflood/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/usnavi/blueflood/labels{/name}","releases_url":"https://api.github.com/repos/usnavi/blueflood/releases{/id}","deployments_url":"https://api.github.com/repos/usnavi/blueflood/deployments","created_at":"2015-11-02T17:04:56Z","updated_at":"2016-01-21T21:52:36Z","pushed_at":"2016-02-26T19:50:07Z","git_url":"git://github.com/usnavi/blueflood.git","ssh_url":"git@github.com:usnavi/blueflood.git","clone_url":"https://github.com/usnavi/blueflood.git","svn_url":"https://github.com/usnavi/blueflood","homepage":"http://www.blueflood.io","size":9048,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rackerlabs:master","ref":"master","sha":"a638d53f69e63a7569ee6bfd344048582c367f22","user":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":10081109,"name":"blueflood","full_name":"rackerlabs/blueflood","owner":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackerlabs/blueflood","description":"A distributed system designed to ingest and process time series data","fork":false,"url":"https://api.github.com/repos/rackerlabs/blueflood","forks_url":"https://api.github.com/repos/rackerlabs/blueflood/forks","keys_url":"https://api.github.com/repos/rackerlabs/blueflood/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackerlabs/blueflood/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackerlabs/blueflood/teams","hooks_url":"https://api.github.com/repos/rackerlabs/blueflood/hooks","issue_events_url":"https://api.github.com/repos/rackerlabs/blueflood/issues/events{/number}","events_url":"https://api.github.com/repos/rackerlabs/blueflood/events","assignees_url":"https://api.github.com/repos/rackerlabs/blueflood/assignees{/user}","branches_url":"https://api.github.com/repos/rackerlabs/blueflood/branches{/branch}","tags_url":"https://api.github.com/repos/rackerlabs/blueflood/tags","blobs_url":"https://api.github.com/repos/rackerlabs/blueflood/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackerlabs/blueflood/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackerlabs/blueflood/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackerlabs/blueflood/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackerlabs/blueflood/statuses/{sha}","languages_url":"https://api.github.com/repos/rackerlabs/blueflood/languages","stargazers_url":"https://api.github.com/repos/rackerlabs/blueflood/stargazers","contributors_url":"https://api.github.com/repos/rackerlabs/blueflood/contributors","subscribers_url":"https://api.github.com/repos/rackerlabs/blueflood/subscribers","subscription_url":"https://api.github.com/repos/rackerlabs/blueflood/subscription","commits_url":"https://api.github.com/repos/rackerlabs/blueflood/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackerlabs/blueflood/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackerlabs/blueflood/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackerlabs/blueflood/issues/comments{/number}","contents_url":"https://api.github.com/repos/rackerlabs/blueflood/contents/{+path}","compare_url":"https://api.github.com/repos/rackerlabs/blueflood/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackerlabs/blueflood/merges","archive_url":"https://api.github.com/repos/rackerlabs/blueflood/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackerlabs/blueflood/downloads","issues_url":"https://api.github.com/repos/rackerlabs/blueflood/issues{/number}","pulls_url":"https://api.github.com/repos/rackerlabs/blueflood/pulls{/number}","milestones_url":"https://api.github.com/repos/rackerlabs/blueflood/milestones{/number}","notifications_url":"https://api.github.com/repos/rackerlabs/blueflood/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackerlabs/blueflood/labels{/name}","releases_url":"https://api.github.com/repos/rackerlabs/blueflood/releases{/id}","deployments_url":"https://api.github.com/repos/rackerlabs/blueflood/deployments","created_at":"2013-05-15T14:50:39Z","updated_at":"2016-02-25T04:58:34Z","pushed_at":"2016-02-26T19:50:08Z","git_url":"git://github.com/rackerlabs/blueflood.git","ssh_url":"git@github.com:rackerlabs/blueflood.git","clone_url":"https://github.com/rackerlabs/blueflood.git","svn_url":"https://github.com/rackerlabs/blueflood","homepage":"http://www.blueflood.io","size":12289,"stargazers_count":409,"watchers_count":409,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":55,"mirror_url":null,"open_issues_count":31,"forks":55,"open_issues":31,"watchers":409,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/blueflood/pulls/633"},"html":{"href":"https://github.com/rackerlabs/blueflood/pull/633"},"issue":{"href":"https://api.github.com/repos/rackerlabs/blueflood/issues/633"},"comments":{"href":"https://api.github.com/repos/rackerlabs/blueflood/issues/633/comments"},"review_comments":{"href":"https://api.github.com/repos/rackerlabs/blueflood/pulls/633/comments"},"review_comment":{"href":"https://api.github.com/repos/rackerlabs/blueflood/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rackerlabs/blueflood/pulls/633/commits"},"statuses":{"href":"https://api.github.com/repos/rackerlabs/blueflood/statuses/e68b98f798fb0ccc4fa68101be46a0bac80fb2c3"}}}}