{"action":"created","comment":{"url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/pulls/comments/51618403","id":51618403,"diff_hunk":"@@ -128,11 +137,34 @@\n       } else {\n         this.setAttribute('aria-modal', 'false');\n       }\n-      // modal implies noCancelOnOutsideClick and withBackdrop if true, don't overwrite\n-      // those properties otherwise.\n+\n+      // modal implies noCancelOnOutsideClick, noCancelOnEscKey and withBackdrop.\n+      // We need to wait for the element to be ready before we can read the\n+      // properties values.\n+      if (!this.__ready) {","path":"paper-dialog-behavior.html","position":35,"original_position":35,"commit_id":"d8ad1a21071392b700a1c499b9209925ef95f8c2","original_commit_id":"d8ad1a21071392b700a1c499b9209925ef95f8c2","user":{"login":"cdata","id":240083,"avatar_url":"https://avatars.githubusercontent.com/u/240083?v=3","gravatar_id":"","url":"https://api.github.com/users/cdata","html_url":"https://github.com/cdata","followers_url":"https://api.github.com/users/cdata/followers","following_url":"https://api.github.com/users/cdata/following{/other_user}","gists_url":"https://api.github.com/users/cdata/gists{/gist_id}","starred_url":"https://api.github.com/users/cdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdata/subscriptions","organizations_url":"https://api.github.com/users/cdata/orgs","repos_url":"https://api.github.com/users/cdata/repos","events_url":"https://api.github.com/users/cdata/events{/privacy}","received_events_url":"https://api.github.com/users/cdata/received_events","type":"User","site_admin":false},"body":"I think there is a `Polymer.Base` property for this. `this._readied` should be true by the time that `ready` is called. Can you try using that instead of creating a new property?","created_at":"2016-02-02T19:11:36Z","updated_at":"2016-02-02T19:11:36Z","html_url":"https://github.com/PolymerElements/paper-dialog-behavior/pull/54#discussion_r51618403","pull_request_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/pulls/54","_links":{"self":{"href":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/pulls/comments/51618403"},"html":{"href":"https://github.com/PolymerElements/paper-dialog-behavior/pull/54#discussion_r51618403"},"pull_request":{"href":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/pulls/54"}}},"pull_request":{"url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/pulls/54","id":54323648,"html_url":"https://github.com/PolymerElements/paper-dialog-behavior/pull/54","diff_url":"https://github.com/PolymerElements/paper-dialog-behavior/pull/54.diff","patch_url":"https://github.com/PolymerElements/paper-dialog-behavior/pull/54.patch","issue_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/issues/54","number":54,"state":"open","locked":false,"title":"set noCancelOnEscKey when modal changes","user":{"login":"valdrinkoshi","id":6173664,"avatar_url":"https://avatars.githubusercontent.com/u/6173664?v=3","gravatar_id":"","url":"https://api.github.com/users/valdrinkoshi","html_url":"https://github.com/valdrinkoshi","followers_url":"https://api.github.com/users/valdrinkoshi/followers","following_url":"https://api.github.com/users/valdrinkoshi/following{/other_user}","gists_url":"https://api.github.com/users/valdrinkoshi/gists{/gist_id}","starred_url":"https://api.github.com/users/valdrinkoshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valdrinkoshi/subscriptions","organizations_url":"https://api.github.com/users/valdrinkoshi/orgs","repos_url":"https://api.github.com/users/valdrinkoshi/repos","events_url":"https://api.github.com/users/valdrinkoshi/events{/privacy}","received_events_url":"https://api.github.com/users/valdrinkoshi/received_events","type":"User","site_admin":false},"body":"Fixes #18, Fixes #64.\r\nSets `noCancelOnEscKey = noCancelOnOutsideClick = withBackdrop = true` when `modal = true` and restores their old values when `modal = false`","created_at":"2015-12-22T01:35:46Z","updated_at":"2016-02-02T19:11:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"37b7195db4d97d5acbb20193310ffe3e2020919a","assignee":{"login":"cdata","id":240083,"avatar_url":"https://avatars.githubusercontent.com/u/240083?v=3","gravatar_id":"","url":"https://api.github.com/users/cdata","html_url":"https://github.com/cdata","followers_url":"https://api.github.com/users/cdata/followers","following_url":"https://api.github.com/users/cdata/following{/other_user}","gists_url":"https://api.github.com/users/cdata/gists{/gist_id}","starred_url":"https://api.github.com/users/cdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdata/subscriptions","organizations_url":"https://api.github.com/users/cdata/orgs","repos_url":"https://api.github.com/users/cdata/repos","events_url":"https://api.github.com/users/cdata/events{/privacy}","received_events_url":"https://api.github.com/users/cdata/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/pulls/54/commits","review_comments_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/pulls/54/comments","review_comment_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/issues/54/comments","statuses_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/statuses/d8ad1a21071392b700a1c499b9209925ef95f8c2","head":{"label":"PolymerElements:issue-27-dialog","ref":"issue-27-dialog","sha":"d8ad1a21071392b700a1c499b9209925ef95f8c2","user":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"repo":{"id":34819734,"name":"paper-dialog-behavior","full_name":"PolymerElements/paper-dialog-behavior","owner":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PolymerElements/paper-dialog-behavior","description":"Makes an element a Material Design dialog","fork":false,"url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior","forks_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/forks","keys_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/teams","hooks_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/hooks","issue_events_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/issues/events{/number}","events_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/events","assignees_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/assignees{/user}","branches_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/branches{/branch}","tags_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/tags","blobs_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/statuses/{sha}","languages_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/languages","stargazers_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/stargazers","contributors_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/contributors","subscribers_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/subscribers","subscription_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/subscription","commits_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/contents/{+path}","compare_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/merges","archive_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/downloads","issues_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/issues{/number}","pulls_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/pulls{/number}","milestones_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/milestones{/number}","notifications_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/labels{/name}","releases_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/releases{/id}","deployments_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/deployments","created_at":"2015-04-29T21:40:00Z","updated_at":"2016-01-12T23:01:12Z","pushed_at":"2016-02-02T19:08:58Z","git_url":"git://github.com/PolymerElements/paper-dialog-behavior.git","ssh_url":"git@github.com:PolymerElements/paper-dialog-behavior.git","clone_url":"https://github.com/PolymerElements/paper-dialog-behavior.git","svn_url":"https://github.com/PolymerElements/paper-dialog-behavior","homepage":null,"size":110,"stargazers_count":4,"watchers_count":4,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":12,"forks":8,"open_issues":12,"watchers":4,"default_branch":"master"}},"base":{"label":"PolymerElements:master","ref":"master","sha":"2f244eb1413fdcac05d741a6bc00417b8ada9e93","user":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"repo":{"id":34819734,"name":"paper-dialog-behavior","full_name":"PolymerElements/paper-dialog-behavior","owner":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PolymerElements/paper-dialog-behavior","description":"Makes an element a Material Design dialog","fork":false,"url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior","forks_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/forks","keys_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/teams","hooks_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/hooks","issue_events_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/issues/events{/number}","events_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/events","assignees_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/assignees{/user}","branches_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/branches{/branch}","tags_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/tags","blobs_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/statuses/{sha}","languages_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/languages","stargazers_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/stargazers","contributors_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/contributors","subscribers_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/subscribers","subscription_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/subscription","commits_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/contents/{+path}","compare_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/merges","archive_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/downloads","issues_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/issues{/number}","pulls_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/pulls{/number}","milestones_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/milestones{/number}","notifications_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/labels{/name}","releases_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/releases{/id}","deployments_url":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/deployments","created_at":"2015-04-29T21:40:00Z","updated_at":"2016-01-12T23:01:12Z","pushed_at":"2016-02-02T19:08:58Z","git_url":"git://github.com/PolymerElements/paper-dialog-behavior.git","ssh_url":"git@github.com:PolymerElements/paper-dialog-behavior.git","clone_url":"https://github.com/PolymerElements/paper-dialog-behavior.git","svn_url":"https://github.com/PolymerElements/paper-dialog-behavior","homepage":null,"size":110,"stargazers_count":4,"watchers_count":4,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":12,"forks":8,"open_issues":12,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/pulls/54"},"html":{"href":"https://github.com/PolymerElements/paper-dialog-behavior/pull/54"},"issue":{"href":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/issues/54"},"comments":{"href":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/PolymerElements/paper-dialog-behavior/statuses/d8ad1a21071392b700a1c499b9209925ef95f8c2"}}}}