{"comment":{"url":"https://api.github.com/repos/kul-forbes/Prox.jl/comments/19070168","html_url":"https://github.com/kul-forbes/Prox.jl/commit/a7e6248dbe59978fb983fa532a7b29520f142c49#commitcomment-19070168","id":19070168,"user":{"login":"mfalt","id":3237193,"avatar_url":"https://avatars.githubusercontent.com/u/3237193?v=3","gravatar_id":"","url":"https://api.github.com/users/mfalt","html_url":"https://github.com/mfalt","followers_url":"https://api.github.com/users/mfalt/followers","following_url":"https://api.github.com/users/mfalt/following{/other_user}","gists_url":"https://api.github.com/users/mfalt/gists{/gist_id}","starred_url":"https://api.github.com/users/mfalt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfalt/subscriptions","organizations_url":"https://api.github.com/users/mfalt/orgs","repos_url":"https://api.github.com/users/mfalt/repos","events_url":"https://api.github.com/users/mfalt/events{/privacy}","received_events_url":"https://api.github.com/users/mfalt/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":null,"commit_id":"a7e6248dbe59978fb983fa532a7b29520f142c49","created_at":"2016-09-18T10:09:14Z","updated_at":"2016-09-18T10:09:14Z","body":"This looks great! I think choosing to supply a separate `y` input is the right way to go. I am still not convinced that it is smart to calculate the prox value in the prox too, but maybe it is.\r\nRegarding the `@inblunds`, I think that we could simply start by checking that the lengths of both inputs are the same. I assume that these functions will eventually be run on slices of the inputs (for example in the cone case where we have different cones for different parts of `x`) so we should verify that it works for that case too.\r\nOne thing that should probably be changed however is that x and y should be the same type. For example:\r\n```julia\r\nfunction prox!(f::SqrDistL2, x::RealOrComplexArray, gamma::Float64, y::RealOrComplexArray)\r\n```\r\nshould probably be\r\n```julia\r\nfunction prox!{T<:RealOrComplexArray}(f::SqrDistL2, x::T, gamma::Float64, y::T)\r\n```"}}
{"actor":{"display_login":"mfalt"}}