{"action":"created","comment":{"url":"https://api.github.com/repos/mrdoob/three.js/pulls/comments/75254573","id":75254573,"diff_hunk":"@@ -4407,17 +4413,78 @@ THREE.MMDHelper.prototype = {\n \n \t},\n \n-\trenderOutline: function ( scene, camera ) {\n+\trenderOutline: function () {\n \n-\t\tvar tmpEnabled = this.renderer.shadowMap.enabled;\n-\t\tthis.renderer.shadowMap.enabled = false;\n+\t\tvar invisibledObjects = [];\n+\t\tvar setInvisible;","path":"examples/js/loaders/MMDLoader.js","position":23,"original_position":23,"commit_id":"dcc288ae8481a7a9c681fe20d87f9956d22bba90","original_commit_id":"dcc288ae8481a7a9c681fe20d87f9956d22bba90","user":{"login":"mrdoob","id":97088,"avatar_url":"https://avatars.githubusercontent.com/u/97088?v=3","gravatar_id":"","url":"https://api.github.com/users/mrdoob","html_url":"https://github.com/mrdoob","followers_url":"https://api.github.com/users/mrdoob/followers","following_url":"https://api.github.com/users/mrdoob/following{/other_user}","gists_url":"https://api.github.com/users/mrdoob/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdoob/subscriptions","organizations_url":"https://api.github.com/users/mrdoob/orgs","repos_url":"https://api.github.com/users/mrdoob/repos","events_url":"https://api.github.com/users/mrdoob/events{/privacy}","received_events_url":"https://api.github.com/users/mrdoob/received_events","type":"User","site_admin":false},"body":"`setInvisible( this, object )`? 😊","created_at":"2016-08-18T06:31:59Z","updated_at":"2016-08-18T06:31:59Z","html_url":"https://github.com/mrdoob/three.js/pull/9472#discussion_r75254573","pull_request_url":"https://api.github.com/repos/mrdoob/three.js/pulls/9472","_links":{"self":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/comments/75254573"},"html":{"href":"https://github.com/mrdoob/three.js/pull/9472#discussion_r75254573"},"pull_request":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/9472"}}},"pull_request":{"url":"https://api.github.com/repos/mrdoob/three.js/pulls/9472","id":80404428,"html_url":"https://github.com/mrdoob/three.js/pull/9472","diff_url":"https://github.com/mrdoob/three.js/pull/9472.diff","patch_url":"https://github.com/mrdoob/three.js/pull/9472.patch","issue_url":"https://api.github.com/repos/mrdoob/three.js/issues/9472","number":9472,"state":"open","locked":false,"title":"Optimize Outline rendering of MMD","user":{"login":"takahirox","id":7637832,"avatar_url":"https://avatars.githubusercontent.com/u/7637832?v=3","gravatar_id":"","url":"https://api.github.com/users/takahirox","html_url":"https://github.com/takahirox","followers_url":"https://api.github.com/users/takahirox/followers","following_url":"https://api.github.com/users/takahirox/following{/other_user}","gists_url":"https://api.github.com/users/takahirox/gists{/gist_id}","starred_url":"https://api.github.com/users/takahirox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takahirox/subscriptions","organizations_url":"https://api.github.com/users/takahirox/orgs","repos_url":"https://api.github.com/users/takahirox/repos","events_url":"https://api.github.com/users/takahirox/events{/privacy}","received_events_url":"https://api.github.com/users/takahirox/received_events","type":"User","site_admin":false},"body":"In outline rendering pass, I set `visible` = false for the objects not to be needed rendering outline\r\nlike the stage of `webgl_loader_mmd_audio` example.","created_at":"2016-08-08T07:21:51Z","updated_at":"2016-08-18T06:31:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb82b862c55ebe4510c4366322f0f4af0ad7d9c1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mrdoob/three.js/pulls/9472/commits","review_comments_url":"https://api.github.com/repos/mrdoob/three.js/pulls/9472/comments","review_comment_url":"https://api.github.com/repos/mrdoob/three.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mrdoob/three.js/issues/9472/comments","statuses_url":"https://api.github.com/repos/mrdoob/three.js/statuses/dcc288ae8481a7a9c681fe20d87f9956d22bba90","head":{"label":"takahirox:MMDLoaderOutlineOptimization","ref":"MMDLoaderOutlineOptimization","sha":"dcc288ae8481a7a9c681fe20d87f9956d22bba90","user":{"login":"takahirox","id":7637832,"avatar_url":"https://avatars.githubusercontent.com/u/7637832?v=3","gravatar_id":"","url":"https://api.github.com/users/takahirox","html_url":"https://github.com/takahirox","followers_url":"https://api.github.com/users/takahirox/followers","following_url":"https://api.github.com/users/takahirox/following{/other_user}","gists_url":"https://api.github.com/users/takahirox/gists{/gist_id}","starred_url":"https://api.github.com/users/takahirox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takahirox/subscriptions","organizations_url":"https://api.github.com/users/takahirox/orgs","repos_url":"https://api.github.com/users/takahirox/repos","events_url":"https://api.github.com/users/takahirox/events{/privacy}","received_events_url":"https://api.github.com/users/takahirox/received_events","type":"User","site_admin":false},"repo":{"id":45166916,"name":"three.js","full_name":"takahirox/three.js","owner":{"login":"takahirox","id":7637832,"avatar_url":"https://avatars.githubusercontent.com/u/7637832?v=3","gravatar_id":"","url":"https://api.github.com/users/takahirox","html_url":"https://github.com/takahirox","followers_url":"https://api.github.com/users/takahirox/followers","following_url":"https://api.github.com/users/takahirox/following{/other_user}","gists_url":"https://api.github.com/users/takahirox/gists{/gist_id}","starred_url":"https://api.github.com/users/takahirox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takahirox/subscriptions","organizations_url":"https://api.github.com/users/takahirox/orgs","repos_url":"https://api.github.com/users/takahirox/repos","events_url":"https://api.github.com/users/takahirox/events{/privacy}","received_events_url":"https://api.github.com/users/takahirox/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/takahirox/three.js","description":"Three.js fork for MMDLoader","fork":true,"url":"https://api.github.com/repos/takahirox/three.js","forks_url":"https://api.github.com/repos/takahirox/three.js/forks","keys_url":"https://api.github.com/repos/takahirox/three.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/takahirox/three.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/takahirox/three.js/teams","hooks_url":"https://api.github.com/repos/takahirox/three.js/hooks","issue_events_url":"https://api.github.com/repos/takahirox/three.js/issues/events{/number}","events_url":"https://api.github.com/repos/takahirox/three.js/events","assignees_url":"https://api.github.com/repos/takahirox/three.js/assignees{/user}","branches_url":"https://api.github.com/repos/takahirox/three.js/branches{/branch}","tags_url":"https://api.github.com/repos/takahirox/three.js/tags","blobs_url":"https://api.github.com/repos/takahirox/three.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/takahirox/three.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/takahirox/three.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/takahirox/three.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/takahirox/three.js/statuses/{sha}","languages_url":"https://api.github.com/repos/takahirox/three.js/languages","stargazers_url":"https://api.github.com/repos/takahirox/three.js/stargazers","contributors_url":"https://api.github.com/repos/takahirox/three.js/contributors","subscribers_url":"https://api.github.com/repos/takahirox/three.js/subscribers","subscription_url":"https://api.github.com/repos/takahirox/three.js/subscription","commits_url":"https://api.github.com/repos/takahirox/three.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/takahirox/three.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/takahirox/three.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/takahirox/three.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/takahirox/three.js/contents/{+path}","compare_url":"https://api.github.com/repos/takahirox/three.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/takahirox/three.js/merges","archive_url":"https://api.github.com/repos/takahirox/three.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/takahirox/three.js/downloads","issues_url":"https://api.github.com/repos/takahirox/three.js/issues{/number}","pulls_url":"https://api.github.com/repos/takahirox/three.js/pulls{/number}","milestones_url":"https://api.github.com/repos/takahirox/three.js/milestones{/number}","notifications_url":"https://api.github.com/repos/takahirox/three.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/takahirox/three.js/labels{/name}","releases_url":"https://api.github.com/repos/takahirox/three.js/releases{/id}","deployments_url":"https://api.github.com/repos/takahirox/three.js/deployments","created_at":"2015-10-29T07:20:39Z","updated_at":"2016-07-27T01:23:12Z","pushed_at":"2016-08-17T03:18:42Z","git_url":"git://github.com/takahirox/three.js.git","ssh_url":"git@github.com:takahirox/three.js.git","clone_url":"https://github.com/takahirox/three.js.git","svn_url":"https://github.com/takahirox/three.js","homepage":"http://takahirox.github.io/three.js/examples/#webgl_loader_mmd","size":396140,"stargazers_count":11,"watchers_count":11,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":0,"forks":4,"open_issues":0,"watchers":11,"default_branch":"master"}},"base":{"label":"mrdoob:dev","ref":"dev","sha":"e9d96c4954e7b07eaf57592e09c4a672193491dc","user":{"login":"mrdoob","id":97088,"avatar_url":"https://avatars.githubusercontent.com/u/97088?v=3","gravatar_id":"","url":"https://api.github.com/users/mrdoob","html_url":"https://github.com/mrdoob","followers_url":"https://api.github.com/users/mrdoob/followers","following_url":"https://api.github.com/users/mrdoob/following{/other_user}","gists_url":"https://api.github.com/users/mrdoob/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdoob/subscriptions","organizations_url":"https://api.github.com/users/mrdoob/orgs","repos_url":"https://api.github.com/users/mrdoob/repos","events_url":"https://api.github.com/users/mrdoob/events{/privacy}","received_events_url":"https://api.github.com/users/mrdoob/received_events","type":"User","site_admin":false},"repo":{"id":576201,"name":"three.js","full_name":"mrdoob/three.js","owner":{"login":"mrdoob","id":97088,"avatar_url":"https://avatars.githubusercontent.com/u/97088?v=3","gravatar_id":"","url":"https://api.github.com/users/mrdoob","html_url":"https://github.com/mrdoob","followers_url":"https://api.github.com/users/mrdoob/followers","following_url":"https://api.github.com/users/mrdoob/following{/other_user}","gists_url":"https://api.github.com/users/mrdoob/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdoob/subscriptions","organizations_url":"https://api.github.com/users/mrdoob/orgs","repos_url":"https://api.github.com/users/mrdoob/repos","events_url":"https://api.github.com/users/mrdoob/events{/privacy}","received_events_url":"https://api.github.com/users/mrdoob/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrdoob/three.js","description":"JavaScript 3D library.","fork":false,"url":"https://api.github.com/repos/mrdoob/three.js","forks_url":"https://api.github.com/repos/mrdoob/three.js/forks","keys_url":"https://api.github.com/repos/mrdoob/three.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrdoob/three.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrdoob/three.js/teams","hooks_url":"https://api.github.com/repos/mrdoob/three.js/hooks","issue_events_url":"https://api.github.com/repos/mrdoob/three.js/issues/events{/number}","events_url":"https://api.github.com/repos/mrdoob/three.js/events","assignees_url":"https://api.github.com/repos/mrdoob/three.js/assignees{/user}","branches_url":"https://api.github.com/repos/mrdoob/three.js/branches{/branch}","tags_url":"https://api.github.com/repos/mrdoob/three.js/tags","blobs_url":"https://api.github.com/repos/mrdoob/three.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrdoob/three.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrdoob/three.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrdoob/three.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrdoob/three.js/statuses/{sha}","languages_url":"https://api.github.com/repos/mrdoob/three.js/languages","stargazers_url":"https://api.github.com/repos/mrdoob/three.js/stargazers","contributors_url":"https://api.github.com/repos/mrdoob/three.js/contributors","subscribers_url":"https://api.github.com/repos/mrdoob/three.js/subscribers","subscription_url":"https://api.github.com/repos/mrdoob/three.js/subscription","commits_url":"https://api.github.com/repos/mrdoob/three.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrdoob/three.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrdoob/three.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrdoob/three.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrdoob/three.js/contents/{+path}","compare_url":"https://api.github.com/repos/mrdoob/three.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrdoob/three.js/merges","archive_url":"https://api.github.com/repos/mrdoob/three.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrdoob/three.js/downloads","issues_url":"https://api.github.com/repos/mrdoob/three.js/issues{/number}","pulls_url":"https://api.github.com/repos/mrdoob/three.js/pulls{/number}","milestones_url":"https://api.github.com/repos/mrdoob/three.js/milestones{/number}","notifications_url":"https://api.github.com/repos/mrdoob/three.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrdoob/three.js/labels{/name}","releases_url":"https://api.github.com/repos/mrdoob/three.js/releases{/id}","deployments_url":"https://api.github.com/repos/mrdoob/three.js/deployments","created_at":"2010-03-23T18:58:01Z","updated_at":"2016-08-18T05:33:49Z","pushed_at":"2016-08-18T06:16:54Z","git_url":"git://github.com/mrdoob/three.js.git","ssh_url":"git@github.com:mrdoob/three.js.git","clone_url":"https://github.com/mrdoob/three.js.git","svn_url":"https://github.com/mrdoob/three.js","homepage":"http://threejs.org/","size":613195,"stargazers_count":26898,"watchers_count":26898,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":9175,"mirror_url":null,"open_issues_count":803,"forks":9175,"open_issues":803,"watchers":26898,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/9472"},"html":{"href":"https://github.com/mrdoob/three.js/pull/9472"},"issue":{"href":"https://api.github.com/repos/mrdoob/three.js/issues/9472"},"comments":{"href":"https://api.github.com/repos/mrdoob/three.js/issues/9472/comments"},"review_comments":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/9472/comments"},"review_comment":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/9472/commits"},"statuses":{"href":"https://api.github.com/repos/mrdoob/three.js/statuses/dcc288ae8481a7a9c681fe20d87f9956d22bba90"}}}}
{"actor":{"display_login":"mrdoob"}}