{"push_id":1442200451,"size":10,"distinct_size":10,"ref":"refs/heads/master","head":"de231cb94a8f2e3ce94530fed0352d23f0d51ddb","before":"f1e2a9cf75af55059513a28c4bda2c92dae6ec3a","commits":[{"sha":"8136dd6d84d520a184a92a1d1e817a7b21c61dc2","author":{"name":"Aki Sasaki","email":"75399a1faca521482466626211a626e3fb10a27f@escapewindow.com"},"message":"allow for three states in the rebuild_gpg_homedirs lockfile\n\nPreviously, we had a single lockfile.  This meant we were busy\nre-creating the gpg homedirs, so don't duplicate the effort, and\ndon't try to read from the new homedirs just yet.  Once we were\ndone rebuilding, we removed the lockfile, so scriptworker could\nclean up, and the next rebuild could happen.\n\nHowever, because there was only two states (locked/unlocked) and\nthere were potentially three competing actions (rebuild1,\nscriptworker copy/cleanup, rebuild2), the latter two raced to\nsee who could fire first.  And because the copy and cleanup were\nnot instantaneous, having the second rebuild start nuking the\ndirectory before the copy was finished was a problem.\n\nThe solution here is to allow for two states in an existing\nlockfile (locked/ready) and the non-existent lockfile makes\nthree.  A nonexistent lockfile means feel free to launch the\nnext rebuild, first creating the lockfile.  A locked lockfile\nmeans don't read from the new gpg homedirs, and don't try to\nlaunch a new rebuild.  A ready state means feel free to read\nfrom the new gpg homedirs, but don't start a new rebuild yet.","distinct":true,"url":"https://api.github.com/repos/mozilla-releng/scriptworker/commits/8136dd6d84d520a184a92a1d1e817a7b21c61dc2"},{"sha":"8858be97bf2be53d6367a92a6ff523d41c0ce1df","author":{"name":"Aki Sasaki","email":"75399a1faca521482466626211a626e3fb10a27f@escapewindow.com"},"message":"remove create_initial_gpg_homedirs\n\nwe'll use rebuild_gpg_homedirs for everything.  We now move the new gpg\nhomedirs in place at the beginning of the loop rather than at the end,\nso rebuild_gpg_homedirs works for initial setup as well.\n\nThis should avoid the issue where puppet populates new gpg pubkeys and\nthen blows away the gpg homedirs, which can break cot verification.","distinct":true,"url":"https://api.github.com/repos/mozilla-releng/scriptworker/commits/8858be97bf2be53d6367a92a6ff523d41c0ce1df"},{"sha":"f0ac9b7b02ebf2f914c78548f1349e76c01db1cb","author":{"name":"Aki Sasaki","email":"75399a1faca521482466626211a626e3fb10a27f@escapewindow.com"},"message":"fix rebuild_gpg_homedirs","distinct":true,"url":"https://api.github.com/repos/mozilla-releng/scriptworker/commits/f0ac9b7b02ebf2f914c78548f1349e76c01db1cb"},{"sha":"55444e68d19f0093827549bd5f4a763003cb7e72","author":{"name":"Aki Sasaki","email":"75399a1faca521482466626211a626e3fb10a27f@escapewindow.com"},"message":"Dockerfile -> docker/Dockerfile.test\n\nI thought it might be nice to have some more developed dockerfiles, in\nwhich case we might want a subdirectory of them, and we can copy them\nto ./Dockerfile.","distinct":true,"url":"https://api.github.com/repos/mozilla-releng/scriptworker/commits/55444e68d19f0093827549bd5f4a763003cb7e72"},{"sha":"ec469fef6b06788cdd5c9412388ab8c15af28fe7","author":{"name":"Aki Sasaki","email":"75399a1faca521482466626211a626e3fb10a27f@escapewindow.com"},"message":"add docker image for gpg testing","distinct":true,"url":"https://api.github.com/repos/mozilla-releng/scriptworker/commits/ec469fef6b06788cdd5c9412388ab8c15af28fe7"},{"sha":"66504a5921c0e5ecef6e493eca27d0d5c1f49aca","author":{"name":"Aki Sasaki","email":"75399a1faca521482466626211a626e3fb10a27f@escapewindow.com"},"message":"update readme and changelog for Dockerfile.gnupg","distinct":true,"url":"https://api.github.com/repos/mozilla-releng/scriptworker/commits/66504a5921c0e5ecef6e493eca27d0d5c1f49aca"},{"sha":"f04d64a4a3ac8bd21fac57e6564561794e0f230a","author":{"name":"Aki Sasaki","email":"75399a1faca521482466626211a626e3fb10a27f@escapewindow.com"},"message":"remove errant create_initial_gpg_homedirs comment in docstring","distinct":true,"url":"https://api.github.com/repos/mozilla-releng/scriptworker/commits/f04d64a4a3ac8bd21fac57e6564561794e0f230a"},{"sha":"4177630b436a2df3178ff0311f65ffc7cea56ae4","author":{"name":"Aki Sasaki","email":"75399a1faca521482466626211a626e3fb10a27f@mozilla.com"},"message":"Merge branch 'master' into fix-gpg","distinct":true,"url":"https://api.github.com/repos/mozilla-releng/scriptworker/commits/4177630b436a2df3178ff0311f65ffc7cea56ae4"},{"sha":"5af4005e845c919ec19c2249570a66d2b2b68e7f","author":{"name":"Aki Sasaki","email":"75399a1faca521482466626211a626e3fb10a27f@escapewindow.com"},"message":"address review comments","distinct":true,"url":"https://api.github.com/repos/mozilla-releng/scriptworker/commits/5af4005e845c919ec19c2249570a66d2b2b68e7f"},{"sha":"de231cb94a8f2e3ce94530fed0352d23f0d51ddb","author":{"name":"Aki Sasaki","email":"75399a1faca521482466626211a626e3fb10a27f@mozilla.com"},"message":"Merge pull request #32 from escapewindow/fix-gpg\n\naddress gpg homedir race conditions","distinct":true,"url":"https://api.github.com/repos/mozilla-releng/scriptworker/commits/de231cb94a8f2e3ce94530fed0352d23f0d51ddb"}]}
{"actor":{"display_login":"escapewindow"}}