{"action":"opened","issue":{"url":"https://api.github.com/repos/Azure/autorest/issues/1190","repository_url":"https://api.github.com/repos/Azure/autorest","labels_url":"https://api.github.com/repos/Azure/autorest/issues/1190/labels{/name}","comments_url":"https://api.github.com/repos/Azure/autorest/issues/1190/comments","events_url":"https://api.github.com/repos/Azure/autorest/issues/1190/events","html_url":"https://github.com/Azure/autorest/issues/1190","id":162050976,"number":1190,"title":"Generating a TypeScript client with -AddCredentials produces code with compile errors","user":{"login":"itsananderson","id":516559,"avatar_url":"https://avatars.githubusercontent.com/u/516559?v=3","gravatar_id":"","url":"https://api.github.com/users/itsananderson","html_url":"https://github.com/itsananderson","followers_url":"https://api.github.com/users/itsananderson/followers","following_url":"https://api.github.com/users/itsananderson/following{/other_user}","gists_url":"https://api.github.com/users/itsananderson/gists{/gist_id}","starred_url":"https://api.github.com/users/itsananderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itsananderson/subscriptions","organizations_url":"https://api.github.com/users/itsananderson/orgs","repos_url":"https://api.github.com/users/itsananderson/repos","events_url":"https://api.github.com/users/itsananderson/events{/privacy}","received_events_url":"https://api.github.com/users/itsananderson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-06-24T00:16:51Z","updated_at":"2016-06-24T00:16:51Z","closed_at":null,"body":"When you generate NodeJS code using the \"AddCredentials\" flag, the generated main client class doesn't compile with the typescript compiler.\r\n\r\nI have a repository with a basic repro: https://github.com/itsananderson/autorest-addcredentials-repro\r\n\r\nIf you look at the [generated d.ts file for the client](https://github.com/itsananderson/autorest-addcredentials-repro/blob/master/lib/autorest/fooClient.d.ts) you can see that it references `ServiceClientCredentials` on lines 30 and 32, but they aren't imported from `ms-rest` on line 7.\r\n\r\nAs far as I can tell, this issue was introduced in the following commit https://github.com/Azure/autorest/commit/55bd11242cd7cbe7b3688cd19d43de26a9bfbdcb, when the `ServiceClientCredentials` type was converted from a composite type to a class.\r\n"}}
{"actor":{"display_login":"itsananderson"}}