{"action":"created","comment":{"url":"https://api.github.com/repos/spdk/spdk/pulls/comments/80733494","pull_request_review_id":1768802,"id":80733494,"diff_hunk":"@@ -126,7 +126,7 @@ blockdev_malloc_read(struct malloc_disk *mdisk, struct copy_task *copy_req,\n \tSPDK_TRACELOG(SPDK_TRACE_MALLOC, \"read %lu bytes from offset %#lx to %p\\n\",\n \t\t      nbytes, offset, buf);\n \n-\treturn spdk_copy_submit(copy_req, buf, mdisk->malloc_buf + offset,\n+\treturn spdk_copy_submit(copy_req, buf, (void *)((char *)mdisk->malloc_buf + offset),","path":"lib/bdev/malloc/blockdev_malloc.c","position":5,"original_position":5,"commit_id":"fa1497eb5a9c8298c7e4def2f63d89f2ea570d25","original_commit_id":"fa1497eb5a9c8298c7e4def2f63d89f2ea570d25","user":{"login":"dverkamp-intel","id":12633103,"avatar_url":"https://avatars.githubusercontent.com/u/12633103?v=3","gravatar_id":"","url":"https://api.github.com/users/dverkamp-intel","html_url":"https://github.com/dverkamp-intel","followers_url":"https://api.github.com/users/dverkamp-intel/followers","following_url":"https://api.github.com/users/dverkamp-intel/following{/other_user}","gists_url":"https://api.github.com/users/dverkamp-intel/gists{/gist_id}","starred_url":"https://api.github.com/users/dverkamp-intel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dverkamp-intel/subscriptions","organizations_url":"https://api.github.com/users/dverkamp-intel/orgs","repos_url":"https://api.github.com/users/dverkamp-intel/repos","events_url":"https://api.github.com/users/dverkamp-intel/events{/privacy}","received_events_url":"https://api.github.com/users/dverkamp-intel/received_events","type":"User","site_admin":false},"body":"This is intentionally using the GCC void pointer arithmetic extension: https://gcc.gnu.org/onlinedocs/gcc/Pointer-Arith.html\r\n\r\nThe same pattern is used throughout the code, so I don't think changing the cases in just this one file is a good idea (and it makes the code harder to read).","created_at":"2016-09-27T16:20:56Z","updated_at":"2016-09-27T16:27:31Z","html_url":"https://github.com/spdk/spdk/pull/41#discussion_r80733494","pull_request_url":"https://api.github.com/repos/spdk/spdk/pulls/41","_links":{"self":{"href":"https://api.github.com/repos/spdk/spdk/pulls/comments/80733494"},"html":{"href":"https://github.com/spdk/spdk/pull/41#discussion_r80733494"},"pull_request":{"href":"https://api.github.com/repos/spdk/spdk/pulls/41"}}},"pull_request":{"url":"https://api.github.com/repos/spdk/spdk/pulls/41","id":86504116,"html_url":"https://github.com/spdk/spdk/pull/41","diff_url":"https://github.com/spdk/spdk/pull/41.diff","patch_url":"https://github.com/spdk/spdk/pull/41.patch","issue_url":"https://api.github.com/repos/spdk/spdk/issues/41","number":41,"state":"open","locked":false,"title":" Fix some cppcheck errors on lib/bdev & lib/iscsi & lib/scsi.","user":{"login":"liupan1111","id":17977187,"avatar_url":"https://avatars.githubusercontent.com/u/17977187?v=3","gravatar_id":"","url":"https://api.github.com/users/liupan1111","html_url":"https://github.com/liupan1111","followers_url":"https://api.github.com/users/liupan1111/followers","following_url":"https://api.github.com/users/liupan1111/following{/other_user}","gists_url":"https://api.github.com/users/liupan1111/gists{/gist_id}","starred_url":"https://api.github.com/users/liupan1111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liupan1111/subscriptions","organizations_url":"https://api.github.com/users/liupan1111/orgs","repos_url":"https://api.github.com/users/liupan1111/repos","events_url":"https://api.github.com/users/liupan1111/events{/privacy}","received_events_url":"https://api.github.com/users/liupan1111/received_events","type":"User","site_admin":false},"body":" Fixed error types:\r\n 1 nullPointerRedundantCheck;\r\n 2 unsignedLessThanZero;\r\n 3 arithOperationsOnVoidPointer;\r\n 4 invalidPrintfArgType_sint;\r\n 5 arrayIndexThenCheck","created_at":"2016-09-23T12:28:00Z","updated_at":"2016-09-27T16:27:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e712fdf38cdd7b855bbb6c010f1dcf01b72eaed","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/spdk/spdk/pulls/41/commits","review_comments_url":"https://api.github.com/repos/spdk/spdk/pulls/41/comments","review_comment_url":"https://api.github.com/repos/spdk/spdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spdk/spdk/issues/41/comments","statuses_url":"https://api.github.com/repos/spdk/spdk/statuses/fa1497eb5a9c8298c7e4def2f63d89f2ea570d25","head":{"label":"liupan1111:master","ref":"master","sha":"fa1497eb5a9c8298c7e4def2f63d89f2ea570d25","user":{"login":"liupan1111","id":17977187,"avatar_url":"https://avatars.githubusercontent.com/u/17977187?v=3","gravatar_id":"","url":"https://api.github.com/users/liupan1111","html_url":"https://github.com/liupan1111","followers_url":"https://api.github.com/users/liupan1111/followers","following_url":"https://api.github.com/users/liupan1111/following{/other_user}","gists_url":"https://api.github.com/users/liupan1111/gists{/gist_id}","starred_url":"https://api.github.com/users/liupan1111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liupan1111/subscriptions","organizations_url":"https://api.github.com/users/liupan1111/orgs","repos_url":"https://api.github.com/users/liupan1111/repos","events_url":"https://api.github.com/users/liupan1111/events{/privacy}","received_events_url":"https://api.github.com/users/liupan1111/received_events","type":"User","site_admin":false},"repo":{"id":69002335,"name":"spdk","full_name":"liupan1111/spdk","owner":{"login":"liupan1111","id":17977187,"avatar_url":"https://avatars.githubusercontent.com/u/17977187?v=3","gravatar_id":"","url":"https://api.github.com/users/liupan1111","html_url":"https://github.com/liupan1111","followers_url":"https://api.github.com/users/liupan1111/followers","following_url":"https://api.github.com/users/liupan1111/following{/other_user}","gists_url":"https://api.github.com/users/liupan1111/gists{/gist_id}","starred_url":"https://api.github.com/users/liupan1111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liupan1111/subscriptions","organizations_url":"https://api.github.com/users/liupan1111/orgs","repos_url":"https://api.github.com/users/liupan1111/repos","events_url":"https://api.github.com/users/liupan1111/events{/privacy}","received_events_url":"https://api.github.com/users/liupan1111/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/liupan1111/spdk","description":"Storage Performance Development Kit - http://spdk.io","fork":true,"url":"https://api.github.com/repos/liupan1111/spdk","forks_url":"https://api.github.com/repos/liupan1111/spdk/forks","keys_url":"https://api.github.com/repos/liupan1111/spdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liupan1111/spdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liupan1111/spdk/teams","hooks_url":"https://api.github.com/repos/liupan1111/spdk/hooks","issue_events_url":"https://api.github.com/repos/liupan1111/spdk/issues/events{/number}","events_url":"https://api.github.com/repos/liupan1111/spdk/events","assignees_url":"https://api.github.com/repos/liupan1111/spdk/assignees{/user}","branches_url":"https://api.github.com/repos/liupan1111/spdk/branches{/branch}","tags_url":"https://api.github.com/repos/liupan1111/spdk/tags","blobs_url":"https://api.github.com/repos/liupan1111/spdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liupan1111/spdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liupan1111/spdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/liupan1111/spdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liupan1111/spdk/statuses/{sha}","languages_url":"https://api.github.com/repos/liupan1111/spdk/languages","stargazers_url":"https://api.github.com/repos/liupan1111/spdk/stargazers","contributors_url":"https://api.github.com/repos/liupan1111/spdk/contributors","subscribers_url":"https://api.github.com/repos/liupan1111/spdk/subscribers","subscription_url":"https://api.github.com/repos/liupan1111/spdk/subscription","commits_url":"https://api.github.com/repos/liupan1111/spdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/liupan1111/spdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/liupan1111/spdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/liupan1111/spdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/liupan1111/spdk/contents/{+path}","compare_url":"https://api.github.com/repos/liupan1111/spdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liupan1111/spdk/merges","archive_url":"https://api.github.com/repos/liupan1111/spdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liupan1111/spdk/downloads","issues_url":"https://api.github.com/repos/liupan1111/spdk/issues{/number}","pulls_url":"https://api.github.com/repos/liupan1111/spdk/pulls{/number}","milestones_url":"https://api.github.com/repos/liupan1111/spdk/milestones{/number}","notifications_url":"https://api.github.com/repos/liupan1111/spdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liupan1111/spdk/labels{/name}","releases_url":"https://api.github.com/repos/liupan1111/spdk/releases{/id}","deployments_url":"https://api.github.com/repos/liupan1111/spdk/deployments","created_at":"2016-09-23T07:50:09Z","updated_at":"2016-09-23T07:50:11Z","pushed_at":"2016-09-23T12:24:20Z","git_url":"git://github.com/liupan1111/spdk.git","ssh_url":"git@github.com:liupan1111/spdk.git","clone_url":"https://github.com/liupan1111/spdk.git","svn_url":"https://github.com/liupan1111/spdk","homepage":"","size":5964,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spdk:master","ref":"master","sha":"6c5f05f177c793bcb53bdd3542a6a0ee03ad8dbc","user":{"login":"spdk","id":13323228,"avatar_url":"https://avatars.githubusercontent.com/u/13323228?v=3","gravatar_id":"","url":"https://api.github.com/users/spdk","html_url":"https://github.com/spdk","followers_url":"https://api.github.com/users/spdk/followers","following_url":"https://api.github.com/users/spdk/following{/other_user}","gists_url":"https://api.github.com/users/spdk/gists{/gist_id}","starred_url":"https://api.github.com/users/spdk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spdk/subscriptions","organizations_url":"https://api.github.com/users/spdk/orgs","repos_url":"https://api.github.com/users/spdk/repos","events_url":"https://api.github.com/users/spdk/events{/privacy}","received_events_url":"https://api.github.com/users/spdk/received_events","type":"Organization","site_admin":false},"repo":{"id":39042157,"name":"spdk","full_name":"spdk/spdk","owner":{"login":"spdk","id":13323228,"avatar_url":"https://avatars.githubusercontent.com/u/13323228?v=3","gravatar_id":"","url":"https://api.github.com/users/spdk","html_url":"https://github.com/spdk","followers_url":"https://api.github.com/users/spdk/followers","following_url":"https://api.github.com/users/spdk/following{/other_user}","gists_url":"https://api.github.com/users/spdk/gists{/gist_id}","starred_url":"https://api.github.com/users/spdk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spdk/subscriptions","organizations_url":"https://api.github.com/users/spdk/orgs","repos_url":"https://api.github.com/users/spdk/repos","events_url":"https://api.github.com/users/spdk/events{/privacy}","received_events_url":"https://api.github.com/users/spdk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spdk/spdk","description":"Storage Performance Development Kit - http://spdk.io","fork":false,"url":"https://api.github.com/repos/spdk/spdk","forks_url":"https://api.github.com/repos/spdk/spdk/forks","keys_url":"https://api.github.com/repos/spdk/spdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spdk/spdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spdk/spdk/teams","hooks_url":"https://api.github.com/repos/spdk/spdk/hooks","issue_events_url":"https://api.github.com/repos/spdk/spdk/issues/events{/number}","events_url":"https://api.github.com/repos/spdk/spdk/events","assignees_url":"https://api.github.com/repos/spdk/spdk/assignees{/user}","branches_url":"https://api.github.com/repos/spdk/spdk/branches{/branch}","tags_url":"https://api.github.com/repos/spdk/spdk/tags","blobs_url":"https://api.github.com/repos/spdk/spdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spdk/spdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spdk/spdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/spdk/spdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spdk/spdk/statuses/{sha}","languages_url":"https://api.github.com/repos/spdk/spdk/languages","stargazers_url":"https://api.github.com/repos/spdk/spdk/stargazers","contributors_url":"https://api.github.com/repos/spdk/spdk/contributors","subscribers_url":"https://api.github.com/repos/spdk/spdk/subscribers","subscription_url":"https://api.github.com/repos/spdk/spdk/subscription","commits_url":"https://api.github.com/repos/spdk/spdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/spdk/spdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/spdk/spdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/spdk/spdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/spdk/spdk/contents/{+path}","compare_url":"https://api.github.com/repos/spdk/spdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spdk/spdk/merges","archive_url":"https://api.github.com/repos/spdk/spdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spdk/spdk/downloads","issues_url":"https://api.github.com/repos/spdk/spdk/issues{/number}","pulls_url":"https://api.github.com/repos/spdk/spdk/pulls{/number}","milestones_url":"https://api.github.com/repos/spdk/spdk/milestones{/number}","notifications_url":"https://api.github.com/repos/spdk/spdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spdk/spdk/labels{/name}","releases_url":"https://api.github.com/repos/spdk/spdk/releases{/id}","deployments_url":"https://api.github.com/repos/spdk/spdk/deployments","created_at":"2015-07-13T23:15:15Z","updated_at":"2016-09-27T07:31:54Z","pushed_at":"2016-09-23T12:28:00Z","git_url":"git://github.com/spdk/spdk.git","ssh_url":"git@github.com:spdk/spdk.git","clone_url":"https://github.com/spdk/spdk.git","svn_url":"https://github.com/spdk/spdk","homepage":"","size":6189,"stargazers_count":329,"watchers_count":329,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":99,"mirror_url":null,"open_issues_count":12,"forks":99,"open_issues":12,"watchers":329,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spdk/spdk/pulls/41"},"html":{"href":"https://github.com/spdk/spdk/pull/41"},"issue":{"href":"https://api.github.com/repos/spdk/spdk/issues/41"},"comments":{"href":"https://api.github.com/repos/spdk/spdk/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/spdk/spdk/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/spdk/spdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spdk/spdk/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/spdk/spdk/statuses/fa1497eb5a9c8298c7e4def2f63d89f2ea570d25"}}}}
{"actor":{"display_login":"dverkamp-intel"}}