{"action":"created","comment":{"url":"https://api.github.com/repos/soft-matter/trackpy/pulls/comments/78033762","id":78033762,"diff_hunk":"@@ -486,14 +492,22 @@ def locate(raw_image, diameter, minmass=None, maxsize=None, separation=None,\n     .. [1] Crocker, J.C., Grier, D.G. http://dx.doi.org/10.1006/jcis.1996.0217\n \n     \"\"\"\n+    if invert:\n+        warnings.warn(\"The invert argument will be deprecated. Use a PIMS \"\n+                      \"pipeline for this.\", DeprecationWarning)\n+    if filter_before is not None:","path":"trackpy/feature.py","position":108,"original_position":108,"commit_id":"7c222f628e8c176e0bcdca0175634e665a97f34a","original_commit_id":"7c222f628e8c176e0bcdca0175634e665a97f34a","user":{"login":"danielballan","id":2279598,"avatar_url":"https://avatars.githubusercontent.com/u/2279598?v=3","gravatar_id":"","url":"https://api.github.com/users/danielballan","html_url":"https://github.com/danielballan","followers_url":"https://api.github.com/users/danielballan/followers","following_url":"https://api.github.com/users/danielballan/following{/other_user}","gists_url":"https://api.github.com/users/danielballan/gists{/gist_id}","starred_url":"https://api.github.com/users/danielballan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielballan/subscriptions","organizations_url":"https://api.github.com/users/danielballan/orgs","repos_url":"https://api.github.com/users/danielballan/repos","events_url":"https://api.github.com/users/danielballan/events{/privacy}","received_events_url":"https://api.github.com/users/danielballan/received_events","type":"User","site_admin":false},"body":"I think this should raise if `filter_before` is True, or at least rephrase the warning. It says the feature \"will be deprecated,\" which I read as meaning \"the filtering is still being done now, but it won't be in a future release.\"","created_at":"2016-09-08T15:48:49Z","updated_at":"2016-09-08T15:48:49Z","html_url":"https://github.com/soft-matter/trackpy/pull/400#discussion_r78033762","pull_request_url":"https://api.github.com/repos/soft-matter/trackpy/pulls/400","_links":{"self":{"href":"https://api.github.com/repos/soft-matter/trackpy/pulls/comments/78033762"},"html":{"href":"https://github.com/soft-matter/trackpy/pull/400#discussion_r78033762"},"pull_request":{"href":"https://api.github.com/repos/soft-matter/trackpy/pulls/400"}}},"pull_request":{"url":"https://api.github.com/repos/soft-matter/trackpy/pulls/400","id":82552370,"html_url":"https://github.com/soft-matter/trackpy/pull/400","diff_url":"https://github.com/soft-matter/trackpy/pull/400.diff","patch_url":"https://github.com/soft-matter/trackpy/pull/400.patch","issue_url":"https://api.github.com/repos/soft-matter/trackpy/issues/400","number":400,"state":"open","locked":false,"title":"Locate refactor: preprocessing and filtering","user":{"login":"caspervdw","id":8937919,"avatar_url":"https://avatars.githubusercontent.com/u/8937919?v=3","gravatar_id":"","url":"https://api.github.com/users/caspervdw","html_url":"https://github.com/caspervdw","followers_url":"https://api.github.com/users/caspervdw/followers","following_url":"https://api.github.com/users/caspervdw/following{/other_user}","gists_url":"https://api.github.com/users/caspervdw/gists{/gist_id}","starred_url":"https://api.github.com/users/caspervdw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caspervdw/subscriptions","organizations_url":"https://api.github.com/users/caspervdw/orgs","repos_url":"https://api.github.com/users/caspervdw/repos","events_url":"https://api.github.com/users/caspervdw/events{/privacy}","received_events_url":"https://api.github.com/users/caspervdw/received_events","type":"User","site_admin":false},"body":"This is a start to making feature-finding more modular (#257). \r\n\r\nAPI changes:\r\n- minmass defaults to 0, not to 100 (integer images) or 1. (float images) (solves obscure behaviour such as in #355)\r\n- filter_before is removed, as it does not increase performance #141.","created_at":"2016-08-24T14:27:31Z","updated_at":"2016-09-08T15:48:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"36ee27f80b2018190ca0c749c28b2bb1d1eab4a4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/soft-matter/trackpy/pulls/400/commits","review_comments_url":"https://api.github.com/repos/soft-matter/trackpy/pulls/400/comments","review_comment_url":"https://api.github.com/repos/soft-matter/trackpy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/soft-matter/trackpy/issues/400/comments","statuses_url":"https://api.github.com/repos/soft-matter/trackpy/statuses/7c222f628e8c176e0bcdca0175634e665a97f34a","head":{"label":"caspervdw:locate-refactor","ref":"locate-refactor","sha":"7c222f628e8c176e0bcdca0175634e665a97f34a","user":{"login":"caspervdw","id":8937919,"avatar_url":"https://avatars.githubusercontent.com/u/8937919?v=3","gravatar_id":"","url":"https://api.github.com/users/caspervdw","html_url":"https://github.com/caspervdw","followers_url":"https://api.github.com/users/caspervdw/followers","following_url":"https://api.github.com/users/caspervdw/following{/other_user}","gists_url":"https://api.github.com/users/caspervdw/gists{/gist_id}","starred_url":"https://api.github.com/users/caspervdw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caspervdw/subscriptions","organizations_url":"https://api.github.com/users/caspervdw/orgs","repos_url":"https://api.github.com/users/caspervdw/repos","events_url":"https://api.github.com/users/caspervdw/events{/privacy}","received_events_url":"https://api.github.com/users/caspervdw/received_events","type":"User","site_admin":false},"repo":{"id":24537865,"name":"trackpy","full_name":"caspervdw/trackpy","owner":{"login":"caspervdw","id":8937919,"avatar_url":"https://avatars.githubusercontent.com/u/8937919?v=3","gravatar_id":"","url":"https://api.github.com/users/caspervdw","html_url":"https://github.com/caspervdw","followers_url":"https://api.github.com/users/caspervdw/followers","following_url":"https://api.github.com/users/caspervdw/following{/other_user}","gists_url":"https://api.github.com/users/caspervdw/gists{/gist_id}","starred_url":"https://api.github.com/users/caspervdw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caspervdw/subscriptions","organizations_url":"https://api.github.com/users/caspervdw/orgs","repos_url":"https://api.github.com/users/caspervdw/repos","events_url":"https://api.github.com/users/caspervdw/events{/privacy}","received_events_url":"https://api.github.com/users/caspervdw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/caspervdw/trackpy","description":"Python particle tracking toolkit","fork":true,"url":"https://api.github.com/repos/caspervdw/trackpy","forks_url":"https://api.github.com/repos/caspervdw/trackpy/forks","keys_url":"https://api.github.com/repos/caspervdw/trackpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caspervdw/trackpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caspervdw/trackpy/teams","hooks_url":"https://api.github.com/repos/caspervdw/trackpy/hooks","issue_events_url":"https://api.github.com/repos/caspervdw/trackpy/issues/events{/number}","events_url":"https://api.github.com/repos/caspervdw/trackpy/events","assignees_url":"https://api.github.com/repos/caspervdw/trackpy/assignees{/user}","branches_url":"https://api.github.com/repos/caspervdw/trackpy/branches{/branch}","tags_url":"https://api.github.com/repos/caspervdw/trackpy/tags","blobs_url":"https://api.github.com/repos/caspervdw/trackpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caspervdw/trackpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caspervdw/trackpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/caspervdw/trackpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caspervdw/trackpy/statuses/{sha}","languages_url":"https://api.github.com/repos/caspervdw/trackpy/languages","stargazers_url":"https://api.github.com/repos/caspervdw/trackpy/stargazers","contributors_url":"https://api.github.com/repos/caspervdw/trackpy/contributors","subscribers_url":"https://api.github.com/repos/caspervdw/trackpy/subscribers","subscription_url":"https://api.github.com/repos/caspervdw/trackpy/subscription","commits_url":"https://api.github.com/repos/caspervdw/trackpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/caspervdw/trackpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/caspervdw/trackpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/caspervdw/trackpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/caspervdw/trackpy/contents/{+path}","compare_url":"https://api.github.com/repos/caspervdw/trackpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caspervdw/trackpy/merges","archive_url":"https://api.github.com/repos/caspervdw/trackpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caspervdw/trackpy/downloads","issues_url":"https://api.github.com/repos/caspervdw/trackpy/issues{/number}","pulls_url":"https://api.github.com/repos/caspervdw/trackpy/pulls{/number}","milestones_url":"https://api.github.com/repos/caspervdw/trackpy/milestones{/number}","notifications_url":"https://api.github.com/repos/caspervdw/trackpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caspervdw/trackpy/labels{/name}","releases_url":"https://api.github.com/repos/caspervdw/trackpy/releases{/id}","deployments_url":"https://api.github.com/repos/caspervdw/trackpy/deployments","created_at":"2014-09-27T17:17:37Z","updated_at":"2016-02-21T14:41:54Z","pushed_at":"2016-09-06T10:34:11Z","git_url":"git://github.com/caspervdw/trackpy.git","ssh_url":"git@github.com:caspervdw/trackpy.git","clone_url":"https://github.com/caspervdw/trackpy.git","svn_url":"https://github.com/caspervdw/trackpy","homepage":"","size":94984,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"soft-matter:master","ref":"master","sha":"c309b83296c720b8b9fd9633259c2b9ea6740eeb","user":{"login":"soft-matter","id":5857177,"avatar_url":"https://avatars.githubusercontent.com/u/5857177?v=3","gravatar_id":"","url":"https://api.github.com/users/soft-matter","html_url":"https://github.com/soft-matter","followers_url":"https://api.github.com/users/soft-matter/followers","following_url":"https://api.github.com/users/soft-matter/following{/other_user}","gists_url":"https://api.github.com/users/soft-matter/gists{/gist_id}","starred_url":"https://api.github.com/users/soft-matter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soft-matter/subscriptions","organizations_url":"https://api.github.com/users/soft-matter/orgs","repos_url":"https://api.github.com/users/soft-matter/repos","events_url":"https://api.github.com/users/soft-matter/events{/privacy}","received_events_url":"https://api.github.com/users/soft-matter/received_events","type":"Organization","site_admin":false},"repo":{"id":4744355,"name":"trackpy","full_name":"soft-matter/trackpy","owner":{"login":"soft-matter","id":5857177,"avatar_url":"https://avatars.githubusercontent.com/u/5857177?v=3","gravatar_id":"","url":"https://api.github.com/users/soft-matter","html_url":"https://github.com/soft-matter","followers_url":"https://api.github.com/users/soft-matter/followers","following_url":"https://api.github.com/users/soft-matter/following{/other_user}","gists_url":"https://api.github.com/users/soft-matter/gists{/gist_id}","starred_url":"https://api.github.com/users/soft-matter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soft-matter/subscriptions","organizations_url":"https://api.github.com/users/soft-matter/orgs","repos_url":"https://api.github.com/users/soft-matter/repos","events_url":"https://api.github.com/users/soft-matter/events{/privacy}","received_events_url":"https://api.github.com/users/soft-matter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/soft-matter/trackpy","description":"Python particle tracking toolkit","fork":false,"url":"https://api.github.com/repos/soft-matter/trackpy","forks_url":"https://api.github.com/repos/soft-matter/trackpy/forks","keys_url":"https://api.github.com/repos/soft-matter/trackpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/soft-matter/trackpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/soft-matter/trackpy/teams","hooks_url":"https://api.github.com/repos/soft-matter/trackpy/hooks","issue_events_url":"https://api.github.com/repos/soft-matter/trackpy/issues/events{/number}","events_url":"https://api.github.com/repos/soft-matter/trackpy/events","assignees_url":"https://api.github.com/repos/soft-matter/trackpy/assignees{/user}","branches_url":"https://api.github.com/repos/soft-matter/trackpy/branches{/branch}","tags_url":"https://api.github.com/repos/soft-matter/trackpy/tags","blobs_url":"https://api.github.com/repos/soft-matter/trackpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/soft-matter/trackpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/soft-matter/trackpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/soft-matter/trackpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/soft-matter/trackpy/statuses/{sha}","languages_url":"https://api.github.com/repos/soft-matter/trackpy/languages","stargazers_url":"https://api.github.com/repos/soft-matter/trackpy/stargazers","contributors_url":"https://api.github.com/repos/soft-matter/trackpy/contributors","subscribers_url":"https://api.github.com/repos/soft-matter/trackpy/subscribers","subscription_url":"https://api.github.com/repos/soft-matter/trackpy/subscription","commits_url":"https://api.github.com/repos/soft-matter/trackpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/soft-matter/trackpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/soft-matter/trackpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/soft-matter/trackpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/soft-matter/trackpy/contents/{+path}","compare_url":"https://api.github.com/repos/soft-matter/trackpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/soft-matter/trackpy/merges","archive_url":"https://api.github.com/repos/soft-matter/trackpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/soft-matter/trackpy/downloads","issues_url":"https://api.github.com/repos/soft-matter/trackpy/issues{/number}","pulls_url":"https://api.github.com/repos/soft-matter/trackpy/pulls{/number}","milestones_url":"https://api.github.com/repos/soft-matter/trackpy/milestones{/number}","notifications_url":"https://api.github.com/repos/soft-matter/trackpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/soft-matter/trackpy/labels{/name}","releases_url":"https://api.github.com/repos/soft-matter/trackpy/releases{/id}","deployments_url":"https://api.github.com/repos/soft-matter/trackpy/deployments","created_at":"2012-06-21T20:56:58Z","updated_at":"2016-08-24T20:51:17Z","pushed_at":"2016-08-29T08:41:22Z","git_url":"git://github.com/soft-matter/trackpy.git","ssh_url":"git@github.com:soft-matter/trackpy.git","clone_url":"https://github.com/soft-matter/trackpy.git","svn_url":"https://github.com/soft-matter/trackpy","homepage":"http://soft-matter.github.io/trackpy","size":92333,"stargazers_count":66,"watchers_count":66,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":55,"forks":43,"open_issues":55,"watchers":66,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/soft-matter/trackpy/pulls/400"},"html":{"href":"https://github.com/soft-matter/trackpy/pull/400"},"issue":{"href":"https://api.github.com/repos/soft-matter/trackpy/issues/400"},"comments":{"href":"https://api.github.com/repos/soft-matter/trackpy/issues/400/comments"},"review_comments":{"href":"https://api.github.com/repos/soft-matter/trackpy/pulls/400/comments"},"review_comment":{"href":"https://api.github.com/repos/soft-matter/trackpy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/soft-matter/trackpy/pulls/400/commits"},"statuses":{"href":"https://api.github.com/repos/soft-matter/trackpy/statuses/7c222f628e8c176e0bcdca0175634e665a97f34a"}}}}
{"actor":{"display_login":"danielballan"}}