{"action":"created","comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/81420210","pull_request_review_id":2404364,"id":81420210,"diff_hunk":"@@ -0,0 +1,76 @@\n+//---------------------------------------------------------------------------\n+//  Greenplum Database\n+//  Copyright (C) 2016 Pivotal Software, Inc.\n+//\n+//  @filename:\n+//    codegen_interface.h\n+//\n+//  @doc:\n+//    Configure Class to handle gucs in gpdb\n+//\n+//---------------------------------------------------------------------------\n+#ifndef GPCODEGEN_CODEGEN_CONFIG_H_  // NOLINT(build/header_guard)\n+#define GPCODEGEN_CODEGEN_CONFIG_H_\n+\n+extern \"C\" {\n+// Variables that are defined in guc\n+extern bool codegen;\n+extern bool init_codegen;","path":"src/backend/codegen/include/codegen/codegen_config.h","position":18,"original_position":18,"commit_id":"490f28becfb314c0a998ad8127b1bca6854573cf","original_commit_id":"e519e4f3dea4c6f1c1458be9f2c94669fd21846c","user":{"login":"xinzweb","id":723898,"avatar_url":"https://avatars.githubusercontent.com/u/723898?v=3","gravatar_id":"","url":"https://api.github.com/users/xinzweb","html_url":"https://github.com/xinzweb","followers_url":"https://api.github.com/users/xinzweb/followers","following_url":"https://api.github.com/users/xinzweb/following{/other_user}","gists_url":"https://api.github.com/users/xinzweb/gists{/gist_id}","starred_url":"https://api.github.com/users/xinzweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xinzweb/subscriptions","organizations_url":"https://api.github.com/users/xinzweb/orgs","repos_url":"https://api.github.com/users/xinzweb/repos","events_url":"https://api.github.com/users/xinzweb/events{/privacy}","received_events_url":"https://api.github.com/users/xinzweb/received_events","type":"User","site_admin":false},"body":"No need to dup the comments, it's already in `guc_gp.c`","created_at":"2016-09-30T21:21:01Z","updated_at":"2016-09-30T21:21:01Z","html_url":"https://github.com/greenplum-db/gpdb/pull/1168#discussion_r81420210","pull_request_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1168","_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/81420210"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/1168#discussion_r81420210"},"pull_request":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1168"}}},"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1168","id":87418490,"html_url":"https://github.com/greenplum-db/gpdb/pull/1168","diff_url":"https://github.com/greenplum-db/gpdb/pull/1168.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/1168.patch","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/1168","number":1168,"state":"open","locked":false,"title":"Improve codegen stability","user":{"login":"karthijrk","id":5432707,"avatar_url":"https://avatars.githubusercontent.com/u/5432707?v=3","gravatar_id":"","url":"https://api.github.com/users/karthijrk","html_url":"https://github.com/karthijrk","followers_url":"https://api.github.com/users/karthijrk/followers","following_url":"https://api.github.com/users/karthijrk/following{/other_user}","gists_url":"https://api.github.com/users/karthijrk/gists{/gist_id}","starred_url":"https://api.github.com/users/karthijrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karthijrk/subscriptions","organizations_url":"https://api.github.com/users/karthijrk/orgs","repos_url":"https://api.github.com/users/karthijrk/repos","events_url":"https://api.github.com/users/karthijrk/events{/privacy}","received_events_url":"https://api.github.com/users/karthijrk/received_events","type":"User","site_admin":false},"body":"In this PR, we addressed the following issues that came out as a result of improving the codegen stability.\r\n\r\n1. Introduced guc to enable / disable generators. \r\n```\r\ncodegen_exec_variable_list;\r\ncodegen_slot_getattr;\r\ncodegen_exec_eval_expression;\r\ncodegen_advance_aggregate;\r\n```\r\n2. `slot_getattr` is moved to .h with 8.3 merge. This cause issue when we register as external function. LLVM expect the name of the external function to be unique for each pointer. In order to fix it, we introduced wrapper function in codegen_wrapper.cc and use that instead of slot_getattr.\r\n\r\n3. In `slot_getattr_codegen`, we found that IR code for logic `!(Expr1 & Expr2)` and `hasnull` is wrong. We fixed in this PR. \r\n\r\n4. We fixed the issue of `slot_getattr` function pointer being null for expression evaluation code generation.\r\n\r\n5. Cpplint was red due to a couple of violation in `advance_aggregate`. This has been fixed in this PR.\r\n\r\nExisting ICG `join.sql` covers pretty much what we fixed here.\r\n\r\n@foyzur @hardikar @armenatzoglou @xinzweb Please take a look when you get a chance.\r\n\r\n\r\n","created_at":"2016-09-30T00:45:41Z","updated_at":"2016-09-30T21:21:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e14b0d0fac2261ecb83bb766a955a359434f41e0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1168/commits","review_comments_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1168/comments","review_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/1168/comments","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/490f28becfb314c0a998ad8127b1bca6854573cf","head":{"label":"karthijrk:exec-var-cg","ref":"exec-var-cg","sha":"490f28becfb314c0a998ad8127b1bca6854573cf","user":{"login":"karthijrk","id":5432707,"avatar_url":"https://avatars.githubusercontent.com/u/5432707?v=3","gravatar_id":"","url":"https://api.github.com/users/karthijrk","html_url":"https://github.com/karthijrk","followers_url":"https://api.github.com/users/karthijrk/followers","following_url":"https://api.github.com/users/karthijrk/following{/other_user}","gists_url":"https://api.github.com/users/karthijrk/gists{/gist_id}","starred_url":"https://api.github.com/users/karthijrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karthijrk/subscriptions","organizations_url":"https://api.github.com/users/karthijrk/orgs","repos_url":"https://api.github.com/users/karthijrk/repos","events_url":"https://api.github.com/users/karthijrk/events{/privacy}","received_events_url":"https://api.github.com/users/karthijrk/received_events","type":"User","site_admin":false},"repo":{"id":46308528,"name":"gpdb","full_name":"karthijrk/gpdb","owner":{"login":"karthijrk","id":5432707,"avatar_url":"https://avatars.githubusercontent.com/u/5432707?v=3","gravatar_id":"","url":"https://api.github.com/users/karthijrk","html_url":"https://github.com/karthijrk","followers_url":"https://api.github.com/users/karthijrk/followers","following_url":"https://api.github.com/users/karthijrk/following{/other_user}","gists_url":"https://api.github.com/users/karthijrk/gists{/gist_id}","starred_url":"https://api.github.com/users/karthijrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karthijrk/subscriptions","organizations_url":"https://api.github.com/users/karthijrk/orgs","repos_url":"https://api.github.com/users/karthijrk/repos","events_url":"https://api.github.com/users/karthijrk/events{/privacy}","received_events_url":"https://api.github.com/users/karthijrk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/karthijrk/gpdb","description":"Pivotal Greenplum Database","fork":true,"url":"https://api.github.com/repos/karthijrk/gpdb","forks_url":"https://api.github.com/repos/karthijrk/gpdb/forks","keys_url":"https://api.github.com/repos/karthijrk/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/karthijrk/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/karthijrk/gpdb/teams","hooks_url":"https://api.github.com/repos/karthijrk/gpdb/hooks","issue_events_url":"https://api.github.com/repos/karthijrk/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/karthijrk/gpdb/events","assignees_url":"https://api.github.com/repos/karthijrk/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/karthijrk/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/karthijrk/gpdb/tags","blobs_url":"https://api.github.com/repos/karthijrk/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/karthijrk/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/karthijrk/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/karthijrk/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/karthijrk/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/karthijrk/gpdb/languages","stargazers_url":"https://api.github.com/repos/karthijrk/gpdb/stargazers","contributors_url":"https://api.github.com/repos/karthijrk/gpdb/contributors","subscribers_url":"https://api.github.com/repos/karthijrk/gpdb/subscribers","subscription_url":"https://api.github.com/repos/karthijrk/gpdb/subscription","commits_url":"https://api.github.com/repos/karthijrk/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/karthijrk/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/karthijrk/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/karthijrk/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/karthijrk/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/karthijrk/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/karthijrk/gpdb/merges","archive_url":"https://api.github.com/repos/karthijrk/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/karthijrk/gpdb/downloads","issues_url":"https://api.github.com/repos/karthijrk/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/karthijrk/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/karthijrk/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/karthijrk/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/karthijrk/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/karthijrk/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/karthijrk/gpdb/deployments","created_at":"2015-11-16T22:58:20Z","updated_at":"2016-04-13T06:48:19Z","pushed_at":"2016-09-30T00:35:39Z","git_url":"git://github.com/karthijrk/gpdb.git","ssh_url":"git@github.com:karthijrk/gpdb.git","clone_url":"https://github.com/karthijrk/gpdb.git","svn_url":"https://github.com/karthijrk/gpdb","homepage":"http://greenplum.org","size":177729,"stargazers_count":1,"watchers_count":1,"language":"PLpgSQL","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"greenplum-db:master","ref":"master","sha":"f10de2773c87907c2db6c5e709ad2a951d176924","user":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars.githubusercontent.com/u/14097842?v=3","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"repo":{"id":44781140,"name":"gpdb","full_name":"greenplum-db/gpdb","owner":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars.githubusercontent.com/u/14097842?v=3","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/greenplum-db/gpdb","description":"Greenplum Database","fork":false,"url":"https://api.github.com/repos/greenplum-db/gpdb","forks_url":"https://api.github.com/repos/greenplum-db/gpdb/forks","keys_url":"https://api.github.com/repos/greenplum-db/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenplum-db/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenplum-db/gpdb/teams","hooks_url":"https://api.github.com/repos/greenplum-db/gpdb/hooks","issue_events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/greenplum-db/gpdb/events","assignees_url":"https://api.github.com/repos/greenplum-db/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/greenplum-db/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/greenplum-db/gpdb/tags","blobs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenplum-db/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenplum-db/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/greenplum-db/gpdb/languages","stargazers_url":"https://api.github.com/repos/greenplum-db/gpdb/stargazers","contributors_url":"https://api.github.com/repos/greenplum-db/gpdb/contributors","subscribers_url":"https://api.github.com/repos/greenplum-db/gpdb/subscribers","subscription_url":"https://api.github.com/repos/greenplum-db/gpdb/subscription","commits_url":"https://api.github.com/repos/greenplum-db/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenplum-db/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenplum-db/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/greenplum-db/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenplum-db/gpdb/merges","archive_url":"https://api.github.com/repos/greenplum-db/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenplum-db/gpdb/downloads","issues_url":"https://api.github.com/repos/greenplum-db/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/greenplum-db/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/greenplum-db/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/greenplum-db/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/greenplum-db/gpdb/deployments","created_at":"2015-10-23T00:25:17Z","updated_at":"2016-09-29T11:42:43Z","pushed_at":"2016-09-30T21:16:51Z","git_url":"git://github.com/greenplum-db/gpdb.git","ssh_url":"git@github.com:greenplum-db/gpdb.git","clone_url":"https://github.com/greenplum-db/gpdb.git","svn_url":"https://github.com/greenplum-db/gpdb","homepage":"http://greenplum.org","size":229598,"stargazers_count":1626,"watchers_count":1626,"language":"PLpgSQL","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":457,"mirror_url":null,"open_issues_count":117,"forks":457,"open_issues":117,"watchers":1626,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1168"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/1168"},"issue":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/1168"},"comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/1168/comments"},"review_comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1168/comments"},"review_comment":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1168/commits"},"statuses":{"href":"https://api.github.com/repos/greenplum-db/gpdb/statuses/490f28becfb314c0a998ad8127b1bca6854573cf"}}}}
{"actor":{"display_login":"xinzweb"}}