{"action":"created","issue":{"url":"https://api.github.com/repos/concrete5/concrete5/issues/3263","labels_url":"https://api.github.com/repos/concrete5/concrete5/issues/3263/labels{/name}","comments_url":"https://api.github.com/repos/concrete5/concrete5/issues/3263/comments","events_url":"https://api.github.com/repos/concrete5/concrete5/issues/3263/events","html_url":"https://github.com/concrete5/concrete5/issues/3263","id":124415640,"number":3263,"title":"Arguments for \"providesAsset\" aren't very clear","user":{"login":"herent","id":676447,"avatar_url":"https://avatars.githubusercontent.com/u/676447?v=3","gravatar_id":"","url":"https://api.github.com/users/herent","html_url":"https://github.com/herent","followers_url":"https://api.github.com/users/herent/followers","following_url":"https://api.github.com/users/herent/following{/other_user}","gists_url":"https://api.github.com/users/herent/gists{/gist_id}","starred_url":"https://api.github.com/users/herent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/herent/subscriptions","organizations_url":"https://api.github.com/users/herent/orgs","repos_url":"https://api.github.com/users/herent/repos","events_url":"https://api.github.com/users/herent/events{/privacy}","received_events_url":"https://api.github.com/users/herent/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-12-30T23:55:40Z","updated_at":"2016-01-06T20:49:28Z","closed_at":"2016-01-04T04:18:03Z","body":"Not too big of a big deal, but when I was trying to figure out how to say that my theme provides entire asset groups, I wasn't able to easily figure out how. It's pretty easy, all you do is pass in the handle. But the first argument is supposed to be type (javascript or css) and the second is the handle. So I didn't know that I could pass in the handle as the first arg and override the whole group.\r\n\r\nhttps://github.com/concrete5/concrete5/blob/develop/web/concrete/src/Page/Theme/Theme.php#L92-L96\r\n\r\nI updated the documentation page, but it feels like a phpdoc block would make it clearer. It would make more sense to have the handle as the first argument, but that would break a lot of sites. ;)"},"comment":{"url":"https://api.github.com/repos/concrete5/concrete5/issues/comments/169456956","html_url":"https://github.com/concrete5/concrete5/issues/3263#issuecomment-169456956","issue_url":"https://api.github.com/repos/concrete5/concrete5/issues/3263","id":169456956,"user":{"login":"herent","id":676447,"avatar_url":"https://avatars.githubusercontent.com/u/676447?v=3","gravatar_id":"","url":"https://api.github.com/users/herent","html_url":"https://github.com/herent","followers_url":"https://api.github.com/users/herent/followers","following_url":"https://api.github.com/users/herent/following{/other_user}","gists_url":"https://api.github.com/users/herent/gists{/gist_id}","starred_url":"https://api.github.com/users/herent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/herent/subscriptions","organizations_url":"https://api.github.com/users/herent/orgs","repos_url":"https://api.github.com/users/herent/repos","events_url":"https://api.github.com/users/herent/events{/privacy}","received_events_url":"https://api.github.com/users/herent/received_events","type":"User","site_admin":false},"created_at":"2016-01-06T20:49:28Z","updated_at":"2016-01-06T20:49:28Z","body":"Actually, looks like it doesn't work at all. The ResponseAssetGroup's markAssetAsIncluded works if you have a second argument, but calling providesAsset() in the page theme without false as the second argument fails. \r\n\r\nShould \r\npublic function providesAsset($assetType, $assetHandle)\r\nbe changed to\r\npublic function providesAsset($assetType, $assetHandle = false)\r\n\r\nThat fixes it so you can pass only one argument in from the page_theme.php \r\n\r\nNot sure if I should open a new issue for that? "}}