{"action":"created","issue":{"url":"https://api.github.com/repos/grpc/grpc/issues/5444","repository_url":"https://api.github.com/repos/grpc/grpc","labels_url":"https://api.github.com/repos/grpc/grpc/issues/5444/labels{/name}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/5444/comments","events_url":"https://api.github.com/repos/grpc/grpc/issues/5444/events","html_url":"https://github.com/grpc/grpc/pull/5444","id":136796768,"number":5444,"title":"Make performance benchmarking code more canonical in structure","user":{"login":"vjpai","id":8864912,"avatar_url":"https://avatars.githubusercontent.com/u/8864912?v=3","gravatar_id":"","url":"https://api.github.com/users/vjpai","html_url":"https://github.com/vjpai","followers_url":"https://api.github.com/users/vjpai/followers","following_url":"https://api.github.com/users/vjpai/following{/other_user}","gists_url":"https://api.github.com/users/vjpai/gists{/gist_id}","starred_url":"https://api.github.com/users/vjpai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjpai/subscriptions","organizations_url":"https://api.github.com/users/vjpai/orgs","repos_url":"https://api.github.com/users/vjpai/repos","events_url":"https://api.github.com/users/vjpai/events{/privacy}","received_events_url":"https://api.github.com/users/vjpai/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/grpc/grpc/labels/c++","name":"c++","color":"eb6420"},{"url":"https://api.github.com/repos/grpc/grpc/labels/cla:%20yes","name":"cla: yes","color":"009800"},{"url":"https://api.github.com/repos/grpc/grpc/labels/performance","name":"performance","color":"fbca04"}],"state":"open","locked":false,"assignee":{"login":"sreecha","id":2754995,"avatar_url":"https://avatars.githubusercontent.com/u/2754995?v=3","gravatar_id":"","url":"https://api.github.com/users/sreecha","html_url":"https://github.com/sreecha","followers_url":"https://api.github.com/users/sreecha/followers","following_url":"https://api.github.com/users/sreecha/following{/other_user}","gists_url":"https://api.github.com/users/sreecha/gists{/gist_id}","starred_url":"https://api.github.com/users/sreecha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sreecha/subscriptions","organizations_url":"https://api.github.com/users/sreecha/orgs","repos_url":"https://api.github.com/users/sreecha/repos","events_url":"https://api.github.com/users/sreecha/events{/privacy}","received_events_url":"https://api.github.com/users/sreecha/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2016-02-26T19:52:55Z","updated_at":"2016-03-11T16:27:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/5444","html_url":"https://github.com/grpc/grpc/pull/5444","diff_url":"https://github.com/grpc/grpc/pull/5444.diff","patch_url":"https://github.com/grpc/grpc/pull/5444.patch"},"body":"1. Do stream processing more conventionally - Writes/WritesDone/Read until Fail/Finish\r\n\r\n2. Simplify the Mark processing code on the client: avoid the use of complications that might lead to races since Histogram was potentially updated without a lock in client->ThreadFunc but can get read under a lock in MergeStatsInto\r\n\r\n3. Finish the clients fully before finishing the servers\r\n"},"comment":{"url":"https://api.github.com/repos/grpc/grpc/issues/comments/195439158","html_url":"https://github.com/grpc/grpc/pull/5444#issuecomment-195439158","issue_url":"https://api.github.com/repos/grpc/grpc/issues/5444","id":195439158,"user":{"login":"sreecha","id":2754995,"avatar_url":"https://avatars.githubusercontent.com/u/2754995?v=3","gravatar_id":"","url":"https://api.github.com/users/sreecha","html_url":"https://github.com/sreecha","followers_url":"https://api.github.com/users/sreecha/followers","following_url":"https://api.github.com/users/sreecha/following{/other_user}","gists_url":"https://api.github.com/users/sreecha/gists{/gist_id}","starred_url":"https://api.github.com/users/sreecha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sreecha/subscriptions","organizations_url":"https://api.github.com/users/sreecha/orgs","repos_url":"https://api.github.com/users/sreecha/repos","events_url":"https://api.github.com/users/sreecha/events{/privacy}","received_events_url":"https://api.github.com/users/sreecha/received_events","type":"User","site_admin":false},"created_at":"2016-03-11T16:27:55Z","updated_at":"2016-03-11T16:27:55Z","body":"LGTM \r\n\r\n(one of the windows tests and a few python tests failed but it is unrelated to this change)"}}