{"action":"created","issue":{"url":"https://api.github.com/repos/angular/material2/issues/343","repository_url":"https://api.github.com/repos/angular/material2","labels_url":"https://api.github.com/repos/angular/material2/issues/343/labels{/name}","comments_url":"https://api.github.com/repos/angular/material2/issues/343/comments","events_url":"https://api.github.com/repos/angular/material2/issues/343/events","html_url":"https://github.com/angular/material2/pull/343","id":150677820,"number":343,"title":"feat(input): add support for more input attributes","user":{"login":"matthewdenobrega","id":1312755,"avatar_url":"https://avatars.githubusercontent.com/u/1312755?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewdenobrega","html_url":"https://github.com/matthewdenobrega","followers_url":"https://api.github.com/users/matthewdenobrega/followers","following_url":"https://api.github.com/users/matthewdenobrega/following{/other_user}","gists_url":"https://api.github.com/users/matthewdenobrega/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewdenobrega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewdenobrega/subscriptions","organizations_url":"https://api.github.com/users/matthewdenobrega/orgs","repos_url":"https://api.github.com/users/matthewdenobrega/repos","events_url":"https://api.github.com/users/matthewdenobrega/events{/privacy}","received_events_url":"https://api.github.com/users/matthewdenobrega/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/angular/material2/labels/cla:%20no","name":"cla: no","color":"e11d21"},{"url":"https://api.github.com/repos/angular/material2/labels/pr:%20lgtm","name":"pr: lgtm","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2016-04-24T16:19:29Z","updated_at":"2016-05-16T07:06:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/angular/material2/pulls/343","html_url":"https://github.com/angular/material2/pull/343","diff_url":"https://github.com/angular/material2/pull/343.diff","patch_url":"https://github.com/angular/material2/pull/343.patch"},"body":"Notes\r\n - I've included all the attributes from [the MDN docs on input](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input) that I thought would potentially be useful and are reasonably widely supported\r\n - I haven't implemented any checking of attributes against the type of the input - for example checking that max is a date when the input type is date - my feeling is this should be up to the developer\r\n - I've followed the pattern of minLength (which was already implemented) and used camelCase for attributes like readOnly\r\n - I've been quite explicit with the tests - I can remove some if this is overkill\r\n - The handling of the spellCheck attribute is different from the other boolean attributes - this is because it is rendered differently (as =\"true\" or =\"false\") by Angular2"},"comment":{"url":"https://api.github.com/repos/angular/material2/issues/comments/219362787","html_url":"https://github.com/angular/material2/pull/343#issuecomment-219362787","issue_url":"https://api.github.com/repos/angular/material2/issues/343","id":219362787,"user":{"login":"matthewdenobrega","id":1312755,"avatar_url":"https://avatars.githubusercontent.com/u/1312755?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewdenobrega","html_url":"https://github.com/matthewdenobrega","followers_url":"https://api.github.com/users/matthewdenobrega/followers","following_url":"https://api.github.com/users/matthewdenobrega/following{/other_user}","gists_url":"https://api.github.com/users/matthewdenobrega/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewdenobrega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewdenobrega/subscriptions","organizations_url":"https://api.github.com/users/matthewdenobrega/orgs","repos_url":"https://api.github.com/users/matthewdenobrega/repos","events_url":"https://api.github.com/users/matthewdenobrega/events{/privacy}","received_events_url":"https://api.github.com/users/matthewdenobrega/received_events","type":"User","site_admin":false},"created_at":"2016-05-16T07:06:12Z","updated_at":"2016-05-16T07:06:12Z","body":"New PR opened: #447 "}}