{"action":"created","issue":{"url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/issues/214","repository_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js","labels_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/issues/214/labels{/name}","comments_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/issues/214/comments","events_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/issues/214/events","html_url":"https://github.com/deepstreamIO/deepstream.io-client-js/pull/214","id":171865259,"number":214,"title":"Optimized records.","user":{"login":"ronag","id":3065230,"avatar_url":"https://avatars.githubusercontent.com/u/3065230?v=3","gravatar_id":"","url":"https://api.github.com/users/ronag","html_url":"https://github.com/ronag","followers_url":"https://api.github.com/users/ronag/followers","following_url":"https://api.github.com/users/ronag/following{/other_user}","gists_url":"https://api.github.com/users/ronag/gists{/gist_id}","starred_url":"https://api.github.com/users/ronag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronag/subscriptions","organizations_url":"https://api.github.com/users/ronag/orgs","repos_url":"https://api.github.com/users/ronag/repos","events_url":"https://api.github.com/users/ronag/events{/privacy}","received_events_url":"https://api.github.com/users/ronag/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/labels/awaiting%20review","name":"awaiting review","color":"e6e6e6"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":46,"created_at":"2016-08-18T10:08:06Z","updated_at":"2016-08-19T08:12:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/pulls/214","html_url":"https://github.com/deepstreamIO/deepstream.io-client-js/pull/214","diff_url":"https://github.com/deepstreamIO/deepstream.io-client-js/pull/214.diff","patch_url":"https://github.com/deepstreamIO/deepstream.io-client-js/pull/214.patch"},"body":"I know that currently this is not something that will get into deepstream but I would at least ask you to consider it, and possibly give some feedback, since we need it.\r\n\r\nOur application is very record heavy and we have some problems with keeping stable 60 fps. We've already improved on this issue with #200 but we still have some performance issues.\r\n\r\nThis pull request optimizes record handling by:\r\n\r\n- No deep copies. Assume immutability.\r\n- No deep equals. Assume reference equality and that `set` is only called when actually changed.\r\n- Cache path tokenisation.\r\n\r\nIn terms of refactoring, which might be interesting:\r\n\r\n- Never directly access _$data, always go through `JsonPath`. This way whether things are cloned or not and deepEquals could be encapsulated into one place.\r\n"},"comment":{"url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/issues/comments/240956191","html_url":"https://github.com/deepstreamIO/deepstream.io-client-js/pull/214#issuecomment-240956191","issue_url":"https://api.github.com/repos/deepstreamIO/deepstream.io-client-js/issues/214","id":240956191,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-08-19T08:12:34Z","updated_at":"2016-08-19T08:12:34Z","body":"\n[![Coverage Status](https://coveralls.io/builds/7519325/badge)](https://coveralls.io/builds/7519325)\n\nCoverage increased (+0.02%) to 97.269% when pulling **6bf4aa2869aae34b3cad02b6783e7a87c28caa5b on nxtedition:feature/optimize-records** into **d6af1ccd704d587d33841d87d513337b3fb0dead on deepstreamIO:master**.\n"}}
{"actor":{"display_login":"coveralls"}}