{"action":"closed","number":64,"pull_request":{"url":"https://api.github.com/repos/futurice/freesound-android/pulls/64","id":87640784,"html_url":"https://github.com/futurice/freesound-android/pull/64","diff_url":"https://github.com/futurice/freesound-android/pull/64.diff","patch_url":"https://github.com/futurice/freesound-android/pull/64.patch","issue_url":"https://api.github.com/repos/futurice/freesound-android/issues/64","number":64,"state":"closed","locked":false,"title":"Extract library versions into ext properties","user":{"login":"peter-tackage","id":1025059,"avatar_url":"https://avatars.githubusercontent.com/u/1025059?v=3","gravatar_id":"","url":"https://api.github.com/users/peter-tackage","html_url":"https://github.com/peter-tackage","followers_url":"https://api.github.com/users/peter-tackage/followers","following_url":"https://api.github.com/users/peter-tackage/following{/other_user}","gists_url":"https://api.github.com/users/peter-tackage/gists{/gist_id}","starred_url":"https://api.github.com/users/peter-tackage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peter-tackage/subscriptions","organizations_url":"https://api.github.com/users/peter-tackage/orgs","repos_url":"https://api.github.com/users/peter-tackage/repos","events_url":"https://api.github.com/users/peter-tackage/events{/privacy}","received_events_url":"https://api.github.com/users/peter-tackage/received_events","type":"User","site_admin":false},"body":"Implementation of #33. Currently I've only done it for the library dependency versions. Should I do the rest too? I've also extracted the versions when they aren't used multiple times, it just seemed neater, although it does add some cognitive load for looking up the version & extra work when adding new libraries (you need to add the version into ext properties list, rather than just copy the suggested gradle dependency).","created_at":"2016-10-02T17:51:57Z","updated_at":"2016-10-05T14:47:28Z","closed_at":"2016-10-05T14:47:28Z","merged_at":"2016-10-05T14:47:28Z","merge_commit_sha":"cd1a0aef53e0d416b755fdeee996d8c542605972","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/futurice/freesound-android/pulls/64/commits","review_comments_url":"https://api.github.com/repos/futurice/freesound-android/pulls/64/comments","review_comment_url":"https://api.github.com/repos/futurice/freesound-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/futurice/freesound-android/issues/64/comments","statuses_url":"https://api.github.com/repos/futurice/freesound-android/statuses/326ba76f7e97028b499553ba68e0bb82dff839ee","head":{"label":"futurice:chore/common-deps","ref":"chore/common-deps","sha":"326ba76f7e97028b499553ba68e0bb82dff839ee","user":{"login":"futurice","id":852157,"avatar_url":"https://avatars.githubusercontent.com/u/852157?v=3","gravatar_id":"","url":"https://api.github.com/users/futurice","html_url":"https://github.com/futurice","followers_url":"https://api.github.com/users/futurice/followers","following_url":"https://api.github.com/users/futurice/following{/other_user}","gists_url":"https://api.github.com/users/futurice/gists{/gist_id}","starred_url":"https://api.github.com/users/futurice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/futurice/subscriptions","organizations_url":"https://api.github.com/users/futurice/orgs","repos_url":"https://api.github.com/users/futurice/repos","events_url":"https://api.github.com/users/futurice/events{/privacy}","received_events_url":"https://api.github.com/users/futurice/received_events","type":"Organization","site_admin":false},"repo":{"id":62079412,"name":"freesound-android","full_name":"futurice/freesound-android","owner":{"login":"futurice","id":852157,"avatar_url":"https://avatars.githubusercontent.com/u/852157?v=3","gravatar_id":"","url":"https://api.github.com/users/futurice","html_url":"https://github.com/futurice","followers_url":"https://api.github.com/users/futurice/followers","following_url":"https://api.github.com/users/futurice/following{/other_user}","gists_url":"https://api.github.com/users/futurice/gists{/gist_id}","starred_url":"https://api.github.com/users/futurice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/futurice/subscriptions","organizations_url":"https://api.github.com/users/futurice/orgs","repos_url":"https://api.github.com/users/futurice/repos","events_url":"https://api.github.com/users/futurice/events{/privacy}","received_events_url":"https://api.github.com/users/futurice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/futurice/freesound-android","description":"Unofficial Android client for the Freesound Project","fork":false,"url":"https://api.github.com/repos/futurice/freesound-android","forks_url":"https://api.github.com/repos/futurice/freesound-android/forks","keys_url":"https://api.github.com/repos/futurice/freesound-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/futurice/freesound-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/futurice/freesound-android/teams","hooks_url":"https://api.github.com/repos/futurice/freesound-android/hooks","issue_events_url":"https://api.github.com/repos/futurice/freesound-android/issues/events{/number}","events_url":"https://api.github.com/repos/futurice/freesound-android/events","assignees_url":"https://api.github.com/repos/futurice/freesound-android/assignees{/user}","branches_url":"https://api.github.com/repos/futurice/freesound-android/branches{/branch}","tags_url":"https://api.github.com/repos/futurice/freesound-android/tags","blobs_url":"https://api.github.com/repos/futurice/freesound-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/futurice/freesound-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/futurice/freesound-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/futurice/freesound-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/futurice/freesound-android/statuses/{sha}","languages_url":"https://api.github.com/repos/futurice/freesound-android/languages","stargazers_url":"https://api.github.com/repos/futurice/freesound-android/stargazers","contributors_url":"https://api.github.com/repos/futurice/freesound-android/contributors","subscribers_url":"https://api.github.com/repos/futurice/freesound-android/subscribers","subscription_url":"https://api.github.com/repos/futurice/freesound-android/subscription","commits_url":"https://api.github.com/repos/futurice/freesound-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/futurice/freesound-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/futurice/freesound-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/futurice/freesound-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/futurice/freesound-android/contents/{+path}","compare_url":"https://api.github.com/repos/futurice/freesound-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/futurice/freesound-android/merges","archive_url":"https://api.github.com/repos/futurice/freesound-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/futurice/freesound-android/downloads","issues_url":"https://api.github.com/repos/futurice/freesound-android/issues{/number}","pulls_url":"https://api.github.com/repos/futurice/freesound-android/pulls{/number}","milestones_url":"https://api.github.com/repos/futurice/freesound-android/milestones{/number}","notifications_url":"https://api.github.com/repos/futurice/freesound-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/futurice/freesound-android/labels{/name}","releases_url":"https://api.github.com/repos/futurice/freesound-android/releases{/id}","deployments_url":"https://api.github.com/repos/futurice/freesound-android/deployments","created_at":"2016-06-27T18:41:00Z","updated_at":"2016-10-02T21:49:46Z","pushed_at":"2016-10-05T14:47:28Z","git_url":"git://github.com/futurice/freesound-android.git","ssh_url":"git@github.com:futurice/freesound-android.git","clone_url":"https://github.com/futurice/freesound-android.git","svn_url":"https://github.com/futurice/freesound-android","homepage":"","size":659,"stargazers_count":8,"watchers_count":8,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":16,"forks":0,"open_issues":16,"watchers":8,"default_branch":"master"}},"base":{"label":"futurice:master","ref":"master","sha":"d999ca903c06567b909cbcc28e3fe815f3ebb61c","user":{"login":"futurice","id":852157,"avatar_url":"https://avatars.githubusercontent.com/u/852157?v=3","gravatar_id":"","url":"https://api.github.com/users/futurice","html_url":"https://github.com/futurice","followers_url":"https://api.github.com/users/futurice/followers","following_url":"https://api.github.com/users/futurice/following{/other_user}","gists_url":"https://api.github.com/users/futurice/gists{/gist_id}","starred_url":"https://api.github.com/users/futurice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/futurice/subscriptions","organizations_url":"https://api.github.com/users/futurice/orgs","repos_url":"https://api.github.com/users/futurice/repos","events_url":"https://api.github.com/users/futurice/events{/privacy}","received_events_url":"https://api.github.com/users/futurice/received_events","type":"Organization","site_admin":false},"repo":{"id":62079412,"name":"freesound-android","full_name":"futurice/freesound-android","owner":{"login":"futurice","id":852157,"avatar_url":"https://avatars.githubusercontent.com/u/852157?v=3","gravatar_id":"","url":"https://api.github.com/users/futurice","html_url":"https://github.com/futurice","followers_url":"https://api.github.com/users/futurice/followers","following_url":"https://api.github.com/users/futurice/following{/other_user}","gists_url":"https://api.github.com/users/futurice/gists{/gist_id}","starred_url":"https://api.github.com/users/futurice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/futurice/subscriptions","organizations_url":"https://api.github.com/users/futurice/orgs","repos_url":"https://api.github.com/users/futurice/repos","events_url":"https://api.github.com/users/futurice/events{/privacy}","received_events_url":"https://api.github.com/users/futurice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/futurice/freesound-android","description":"Unofficial Android client for the Freesound Project","fork":false,"url":"https://api.github.com/repos/futurice/freesound-android","forks_url":"https://api.github.com/repos/futurice/freesound-android/forks","keys_url":"https://api.github.com/repos/futurice/freesound-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/futurice/freesound-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/futurice/freesound-android/teams","hooks_url":"https://api.github.com/repos/futurice/freesound-android/hooks","issue_events_url":"https://api.github.com/repos/futurice/freesound-android/issues/events{/number}","events_url":"https://api.github.com/repos/futurice/freesound-android/events","assignees_url":"https://api.github.com/repos/futurice/freesound-android/assignees{/user}","branches_url":"https://api.github.com/repos/futurice/freesound-android/branches{/branch}","tags_url":"https://api.github.com/repos/futurice/freesound-android/tags","blobs_url":"https://api.github.com/repos/futurice/freesound-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/futurice/freesound-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/futurice/freesound-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/futurice/freesound-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/futurice/freesound-android/statuses/{sha}","languages_url":"https://api.github.com/repos/futurice/freesound-android/languages","stargazers_url":"https://api.github.com/repos/futurice/freesound-android/stargazers","contributors_url":"https://api.github.com/repos/futurice/freesound-android/contributors","subscribers_url":"https://api.github.com/repos/futurice/freesound-android/subscribers","subscription_url":"https://api.github.com/repos/futurice/freesound-android/subscription","commits_url":"https://api.github.com/repos/futurice/freesound-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/futurice/freesound-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/futurice/freesound-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/futurice/freesound-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/futurice/freesound-android/contents/{+path}","compare_url":"https://api.github.com/repos/futurice/freesound-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/futurice/freesound-android/merges","archive_url":"https://api.github.com/repos/futurice/freesound-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/futurice/freesound-android/downloads","issues_url":"https://api.github.com/repos/futurice/freesound-android/issues{/number}","pulls_url":"https://api.github.com/repos/futurice/freesound-android/pulls{/number}","milestones_url":"https://api.github.com/repos/futurice/freesound-android/milestones{/number}","notifications_url":"https://api.github.com/repos/futurice/freesound-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/futurice/freesound-android/labels{/name}","releases_url":"https://api.github.com/repos/futurice/freesound-android/releases{/id}","deployments_url":"https://api.github.com/repos/futurice/freesound-android/deployments","created_at":"2016-06-27T18:41:00Z","updated_at":"2016-10-02T21:49:46Z","pushed_at":"2016-10-05T14:47:28Z","git_url":"git://github.com/futurice/freesound-android.git","ssh_url":"git@github.com:futurice/freesound-android.git","clone_url":"https://github.com/futurice/freesound-android.git","svn_url":"https://github.com/futurice/freesound-android","homepage":"","size":659,"stargazers_count":8,"watchers_count":8,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":16,"forks":0,"open_issues":16,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/futurice/freesound-android/pulls/64"},"html":{"href":"https://github.com/futurice/freesound-android/pull/64"},"issue":{"href":"https://api.github.com/repos/futurice/freesound-android/issues/64"},"comments":{"href":"https://api.github.com/repos/futurice/freesound-android/issues/64/comments"},"review_comments":{"href":"https://api.github.com/repos/futurice/freesound-android/pulls/64/comments"},"review_comment":{"href":"https://api.github.com/repos/futurice/freesound-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/futurice/freesound-android/pulls/64/commits"},"statuses":{"href":"https://api.github.com/repos/futurice/freesound-android/statuses/326ba76f7e97028b499553ba68e0bb82dff839ee"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"peter-tackage","id":1025059,"avatar_url":"https://avatars.githubusercontent.com/u/1025059?v=3","gravatar_id":"","url":"https://api.github.com/users/peter-tackage","html_url":"https://github.com/peter-tackage","followers_url":"https://api.github.com/users/peter-tackage/followers","following_url":"https://api.github.com/users/peter-tackage/following{/other_user}","gists_url":"https://api.github.com/users/peter-tackage/gists{/gist_id}","starred_url":"https://api.github.com/users/peter-tackage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peter-tackage/subscriptions","organizations_url":"https://api.github.com/users/peter-tackage/orgs","repos_url":"https://api.github.com/users/peter-tackage/repos","events_url":"https://api.github.com/users/peter-tackage/events{/privacy}","received_events_url":"https://api.github.com/users/peter-tackage/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":2,"additions":62,"deletions":36,"changed_files":1}}
{"actor":{"display_login":"peter-tackage"}}