{"action":"created","issue":{"url":"https://api.github.com/repos/mirek/node-json-hash/issues/4","repository_url":"https://api.github.com/repos/mirek/node-json-hash","labels_url":"https://api.github.com/repos/mirek/node-json-hash/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/mirek/node-json-hash/issues/4/comments","events_url":"https://api.github.com/repos/mirek/node-json-hash/issues/4/events","html_url":"https://github.com/mirek/node-json-hash/pull/4","id":164108098,"number":4,"title":"Added improvements to array hashing","user":{"login":"ramesees","id":5664446,"avatar_url":"https://avatars.githubusercontent.com/u/5664446?v=3","gravatar_id":"","url":"https://api.github.com/users/ramesees","html_url":"https://github.com/ramesees","followers_url":"https://api.github.com/users/ramesees/followers","following_url":"https://api.github.com/users/ramesees/following{/other_user}","gists_url":"https://api.github.com/users/ramesees/gists{/gist_id}","starred_url":"https://api.github.com/users/ramesees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramesees/subscriptions","organizations_url":"https://api.github.com/users/ramesees/orgs","repos_url":"https://api.github.com/users/ramesees/repos","events_url":"https://api.github.com/users/ramesees/events{/privacy}","received_events_url":"https://api.github.com/users/ramesees/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-06T15:44:38Z","updated_at":"2016-07-07T01:05:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mirek/node-json-hash/pulls/4","html_url":"https://github.com/mirek/node-json-hash/pull/4","diff_url":"https://github.com/mirek/node-json-hash/pull/4.diff","patch_url":"https://github.com/mirek/node-json-hash/pull/4.patch"},"body":"Hi\r\n\r\nI was using your library and discovered that array hashing was failing for some use cases that I felt should have produced the same hash. So I've made some changes that I would like you to review.\r\n\r\nThe changes I've added now sort each array according to the hash of each element and then proceeds as it did before.\r\n\r\nTest cases have been added and I've bumped the version to 1.2.0 to reflect the functionality change."},"comment":{"url":"https://api.github.com/repos/mirek/node-json-hash/issues/comments/230951789","html_url":"https://github.com/mirek/node-json-hash/pull/4#issuecomment-230951789","issue_url":"https://api.github.com/repos/mirek/node-json-hash/issues/4","id":230951789,"user":{"login":"ramesees","id":5664446,"avatar_url":"https://avatars.githubusercontent.com/u/5664446?v=3","gravatar_id":"","url":"https://api.github.com/users/ramesees","html_url":"https://github.com/ramesees","followers_url":"https://api.github.com/users/ramesees/followers","following_url":"https://api.github.com/users/ramesees/following{/other_user}","gists_url":"https://api.github.com/users/ramesees/gists{/gist_id}","starred_url":"https://api.github.com/users/ramesees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramesees/subscriptions","organizations_url":"https://api.github.com/users/ramesees/orgs","repos_url":"https://api.github.com/users/ramesees/repos","events_url":"https://api.github.com/users/ramesees/events{/privacy}","received_events_url":"https://api.github.com/users/ramesees/received_events","type":"User","site_admin":false},"created_at":"2016-07-07T01:05:17Z","updated_at":"2016-07-07T01:05:17Z","body":"Thanks for the feedback.\r\n\r\nThe use cases that I require the hashing functionality for are dynamic json structures which are highly nested which contain objects, arrays and primitives. They can range from several hundred kilobytes to several megabytes in size.\r\n\r\nOptions 2 or 3 wouldn't be practical with the nature of these structures as the idea would be to use the hashing library as a fire and forget with minimal configuration to obtain a hash value which can be used to compare these structures at a later date. \r\n\r\nOption 1 (of adding it to the library) seems to be best solution for me for right now, as the ordering of the values in the arrays has no bearing on its meaning."}}
{"actor":{"display_login":"ramesees"}}