{"action":"created","issue":{"url":"https://api.github.com/repos/plone/mockup/issues/616","repository_url":"https://api.github.com/repos/plone/mockup","labels_url":"https://api.github.com/repos/plone/mockup/issues/616/labels{/name}","comments_url":"https://api.github.com/repos/plone/mockup/issues/616/comments","events_url":"https://api.github.com/repos/plone/mockup/issues/616/events","html_url":"https://github.com/plone/mockup/issues/616","id":121622096,"number":616,"title":"Question: would efforts going towards the decoupling the structure pattern from folder_contents be welcomed?","user":{"login":"metatoaster","id":372914,"avatar_url":"https://avatars.githubusercontent.com/u/372914?v=3","gravatar_id":"","url":"https://api.github.com/users/metatoaster","html_url":"https://github.com/metatoaster","followers_url":"https://api.github.com/users/metatoaster/followers","following_url":"https://api.github.com/users/metatoaster/following{/other_user}","gists_url":"https://api.github.com/users/metatoaster/gists{/gist_id}","starred_url":"https://api.github.com/users/metatoaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metatoaster/subscriptions","organizations_url":"https://api.github.com/users/metatoaster/orgs","repos_url":"https://api.github.com/users/metatoaster/repos","events_url":"https://api.github.com/users/metatoaster/events{/privacy}","received_events_url":"https://api.github.com/users/metatoaster/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":33,"created_at":"2015-12-11T02:22:26Z","updated_at":"2016-03-15T05:09:54Z","closed_at":null,"body":"The structure pattern looks quite useful for any kind of file/folder-like resources, however it makes assumptions on certain things, such as the availability of the paste button (which can be unavailable if the underlying view returns a json string without that button defined), and other Plone \"folder_contents view\"-centric ideas that make presenting a proxy file/folder view of non-Plone local resources (such as a view of some folder on the server, proxy view of git/mercurial repositories) rather difficult, and customization of action buttons isn't fully possible (i.e. paste button must be available even though the specific view implementation may not provide one).  I mostly want to know if this is within the scope of what plone mockup is wanting to achieve, so that no time is wasted on irrelevant goals."},"comment":{"url":"https://api.github.com/repos/plone/mockup/issues/comments/196664489","html_url":"https://github.com/plone/mockup/issues/616#issuecomment-196664489","issue_url":"https://api.github.com/repos/plone/mockup/issues/616","id":196664489,"user":{"login":"metatoaster","id":372914,"avatar_url":"https://avatars.githubusercontent.com/u/372914?v=3","gravatar_id":"","url":"https://api.github.com/users/metatoaster","html_url":"https://github.com/metatoaster","followers_url":"https://api.github.com/users/metatoaster/followers","following_url":"https://api.github.com/users/metatoaster/following{/other_user}","gists_url":"https://api.github.com/users/metatoaster/gists{/gist_id}","starred_url":"https://api.github.com/users/metatoaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metatoaster/subscriptions","organizations_url":"https://api.github.com/users/metatoaster/orgs","repos_url":"https://api.github.com/users/metatoaster/repos","events_url":"https://api.github.com/users/metatoaster/events{/privacy}","received_events_url":"https://api.github.com/users/metatoaster/received_events","type":"User","site_admin":false},"created_at":"2016-03-15T05:09:54Z","updated_at":"2016-03-15T05:09:54Z","body":"Thanks for that.\r\n\r\nI ended up doing a lot of rejuggling of the changesets but I am quite used to doing this since I am the one being pedantic about this, the results ended up being mostly satisfactory (somewhat dissatisfied with how opaque the change to `ActionMenu` was done (as I really hate changing code while moving files around), all things considered it isn't _that_ big of a change).  End result is that there is *one* changeset per feature introduced, and on the plus side I rewrote the history in such a way that the `pushStateUrl` parameter I introduced as an alternative to the `urlStructure` parameter is now completely decoupled from the traverse subview compatible pushState support - again things like this is why I am insisting changesets be done the way it did.\r\n\r\nChangelog entry file has an entry roughly correlating to what I've done. The actual changelogs per commit is still long since I haven't not rewritten them but I did prune off entries that became irrelevant. for the most part.  Changes roughly follows this\r\n\r\n- Code cleanup for flexibility in supporting third-party users and also the changes that follow.\r\n- Complete revamping of the action menu and decoupling of items from its callable.\r\n- Detanglement of the `ResultCollection` and its interaction with `utils.QueryHelper` and relocated its `queryParser` so that `getCurrentPath` / `setCurrentPath` can be consistently used/implemented by other subclasses of `Backbone.Paginator.requestPager`.\r\n- Possibly controversial change - support for a special `viewURL` argument in place of `getURL` for items returned for pre-calculated view urls for the item (as some items will not need `/view`).\r\n- Support for `IPublishTraverse` usages for this pattern, ensuring the pushState urls can be correctly calculated for this\r\n- Finally, the alternative `pushStateUrl` format parameter to `urlStructure`.\r\n\r\nI had planned to also implement the requirejs defined button/action similar to the per-item action item, mostly to make uniform the implementation for both of these things, but I haven't got around to doing that yet.\r\n\r\nI also would like to see the breadcrumbs in here to be its own thing, but that feels too much of a scope creep given the state of things.\r\n\r\nAs usual, please review and let me know what else may be needed to get this merged."}}