{"action":"created","issue":{"url":"https://api.github.com/repos/getquill/quill/issues/332","repository_url":"https://api.github.com/repos/getquill/quill","labels_url":"https://api.github.com/repos/getquill/quill/issues/332/labels{/name}","comments_url":"https://api.github.com/repos/getquill/quill/issues/332/comments","events_url":"https://api.github.com/repos/getquill/quill/issues/332/events","html_url":"https://github.com/getquill/quill/pull/332","id":151184135,"number":332,"title":"[WIP] Change transaction methods to provide similar signatures","user":{"login":"juliano","id":35762,"avatar_url":"https://avatars.githubusercontent.com/u/35762?v=3","gravatar_id":"","url":"https://api.github.com/users/juliano","html_url":"https://github.com/juliano","followers_url":"https://api.github.com/users/juliano/followers","following_url":"https://api.github.com/users/juliano/following{/other_user}","gists_url":"https://api.github.com/users/juliano/gists{/gist_id}","starred_url":"https://api.github.com/users/juliano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliano/subscriptions","organizations_url":"https://api.github.com/users/juliano/orgs","repos_url":"https://api.github.com/users/juliano/repos","events_url":"https://api.github.com/users/juliano/events{/privacy}","received_events_url":"https://api.github.com/users/juliano/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/getquill/quill/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-04-26T16:47:40Z","updated_at":"2016-04-27T04:28:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/getquill/quill/pulls/332","html_url":"https://github.com/getquill/quill/pull/332","diff_url":"https://github.com/getquill/quill/pull/332.diff","patch_url":"https://github.com/getquill/quill/pull/332.patch"},"body":"Fixes #13 \r\n\r\n### Problem\r\n\r\nQuill has support for transactions but it is not documented yet. Each `Source` implementation has a complete different transaction implementation. This PR is the first step to have a standard api and then document the feature.\r\n\r\nTalking to @fwbrasil I am opening this PR to have some feedback, this is the first implementation I am sure there's a lot to improve here - AsyncSource for example I've changed basically the method signature.\r\n\r\n### Solution\r\n\r\nDescribe the modifications you've done.\r\n\r\n### Notes\r\n\r\nAdditional notes.\r\n\r\n### Checklist\r\n\r\n- [ ] Unit test all changes\r\n- [ ] Update `README.md` if applicable\r\n- [ ] Add `[WIP]` to the pull request title if it's work in progress\r\n- [ ] [Squash commits](https://ariejan.net/2011/07/05/git-squash-your-latests-commits-into-one) that aren't meaningful changes\r\n- [ ] Run `sbt scalariformFormat test:scalariformFormat` to make sure that the source files are formatted\r\n\r\n@getquill/maintainers\r\n"},"comment":{"url":"https://api.github.com/repos/getquill/quill/issues/comments/214966934","html_url":"https://github.com/getquill/quill/pull/332#issuecomment-214966934","issue_url":"https://api.github.com/repos/getquill/quill/issues/332","id":214966934,"user":{"login":"fwbrasil","id":831175,"avatar_url":"https://avatars.githubusercontent.com/u/831175?v=3","gravatar_id":"","url":"https://api.github.com/users/fwbrasil","html_url":"https://github.com/fwbrasil","followers_url":"https://api.github.com/users/fwbrasil/followers","following_url":"https://api.github.com/users/fwbrasil/following{/other_user}","gists_url":"https://api.github.com/users/fwbrasil/gists{/gist_id}","starred_url":"https://api.github.com/users/fwbrasil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fwbrasil/subscriptions","organizations_url":"https://api.github.com/users/fwbrasil/orgs","repos_url":"https://api.github.com/users/fwbrasil/repos","events_url":"https://api.github.com/users/fwbrasil/events{/privacy}","received_events_url":"https://api.github.com/users/fwbrasil/received_events","type":"User","site_admin":false},"created_at":"2016-04-27T04:28:27Z","updated_at":"2016-04-27T04:28:27Z","body":"Thanks for working on this! It's an important milestone for the `1.0` release."}}