{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react/issues/7092","repository_url":"https://api.github.com/repos/facebook/react","labels_url":"https://api.github.com/repos/facebook/react/issues/7092/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react/issues/7092/comments","events_url":"https://api.github.com/repos/facebook/react/issues/7092/events","html_url":"https://github.com/facebook/react/issues/7092","id":161334449,"number":7092,"title":"`dist/react-dom.js` cannot get React.__SECRET_DOM_DO_NOT_USE_OR_YOU_WILL_BE_FIRED","user":{"login":"mocheng","id":239291,"avatar_url":"https://avatars.githubusercontent.com/u/239291?v=3","gravatar_id":"","url":"https://api.github.com/users/mocheng","html_url":"https://github.com/mocheng","followers_url":"https://api.github.com/users/mocheng/followers","following_url":"https://api.github.com/users/mocheng/following{/other_user}","gists_url":"https://api.github.com/users/mocheng/gists{/gist_id}","starred_url":"https://api.github.com/users/mocheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mocheng/subscriptions","organizations_url":"https://api.github.com/users/mocheng/orgs","repos_url":"https://api.github.com/users/mocheng/repos","events_url":"https://api.github.com/users/mocheng/events{/privacy}","received_events_url":"https://api.github.com/users/mocheng/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-06-21T02:03:20Z","updated_at":"2016-06-22T12:59:43Z","closed_at":null,"body":"\r\nIn version 15.1.0, npm installed react-dom has `dist/react-dom` file which imports React DOM related stuff from React. However, `require('react')` doesn't have React.__SECRET_DOM_DO_NOT_USE_OR_YOU_WILL_BE_FIRED property, since react doesn't export it.\r\n\r\nAs a result, we cannot use `dist/react-dom` and it is totally useless.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/facebook/react/issues/comments/227735260","html_url":"https://github.com/facebook/react/issues/7092#issuecomment-227735260","issue_url":"https://api.github.com/repos/facebook/react/issues/7092","id":227735260,"user":{"login":"gaearon","id":810438,"avatar_url":"https://avatars.githubusercontent.com/u/810438?v=3","gravatar_id":"","url":"https://api.github.com/users/gaearon","html_url":"https://github.com/gaearon","followers_url":"https://api.github.com/users/gaearon/followers","following_url":"https://api.github.com/users/gaearon/following{/other_user}","gists_url":"https://api.github.com/users/gaearon/gists{/gist_id}","starred_url":"https://api.github.com/users/gaearon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaearon/subscriptions","organizations_url":"https://api.github.com/users/gaearon/orgs","repos_url":"https://api.github.com/users/gaearon/repos","events_url":"https://api.github.com/users/gaearon/events{/privacy}","received_events_url":"https://api.github.com/users/gaearon/received_events","type":"User","site_admin":false},"created_at":"2016-06-22T12:59:43Z","updated_at":"2016-06-22T12:59:43Z","body":">The problem of directly requiring dist/react*.min is that you'll need to change all your requires/imports, or you'll end up with 2 different builds of React. Specifically, if there's a third party library that imports React then you'll need to change that as well :(.\r\n\r\nUsually this is solved by using an option like `alias` in Webpack that just “redirects” requires, e.g. `alias: { 'react': 'react/dist/react.min' }`."}}
{"actor":{"display_login":"gaearon"}}