{"action":"created","issue":{"url":"https://api.github.com/repos/nylas/ansible-test/issues/5","repository_url":"https://api.github.com/repos/nylas/ansible-test","labels_url":"https://api.github.com/repos/nylas/ansible-test/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/nylas/ansible-test/issues/5/comments","events_url":"https://api.github.com/repos/nylas/ansible-test/issues/5/events","html_url":"https://github.com/nylas/ansible-test/pull/5","id":152724127,"number":5,"title":"ansible has deprecated 'sudo', use 'become'","user":{"login":"SJLC","id":3031760,"avatar_url":"https://avatars.githubusercontent.com/u/3031760?v=3","gravatar_id":"","url":"https://api.github.com/users/SJLC","html_url":"https://github.com/SJLC","followers_url":"https://api.github.com/users/SJLC/followers","following_url":"https://api.github.com/users/SJLC/following{/other_user}","gists_url":"https://api.github.com/users/SJLC/gists{/gist_id}","starred_url":"https://api.github.com/users/SJLC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SJLC/subscriptions","organizations_url":"https://api.github.com/users/SJLC/orgs","repos_url":"https://api.github.com/users/SJLC/repos","events_url":"https://api.github.com/users/SJLC/events{/privacy}","received_events_url":"https://api.github.com/users/SJLC/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-05-03T08:32:32Z","updated_at":"2016-05-26T08:59:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nylas/ansible-test/pulls/5","html_url":"https://github.com/nylas/ansible-test/pull/5","diff_url":"https://github.com/nylas/ansible-test/pull/5.diff","patch_url":"https://github.com/nylas/ansible-test/pull/5.patch"},"body":"Fixes nylas/ansible-test#2\r\n\r\nMigrate from ansible's pre-1.9 privilege escalation mechanism\r\nto the current mechanism:\r\n\r\n* Switch 'sudo:' to 'become:' in playbook\r\n* Remove '-s' from ansible-playbook command-line"},"comment":{"url":"https://api.github.com/repos/nylas/ansible-test/issues/comments/221815990","html_url":"https://github.com/nylas/ansible-test/pull/5#issuecomment-221815990","issue_url":"https://api.github.com/repos/nylas/ansible-test/issues/5","id":221815990,"user":{"login":"SJLC","id":3031760,"avatar_url":"https://avatars.githubusercontent.com/u/3031760?v=3","gravatar_id":"","url":"https://api.github.com/users/SJLC","html_url":"https://github.com/SJLC","followers_url":"https://api.github.com/users/SJLC/followers","following_url":"https://api.github.com/users/SJLC/following{/other_user}","gists_url":"https://api.github.com/users/SJLC/gists{/gist_id}","starred_url":"https://api.github.com/users/SJLC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SJLC/subscriptions","organizations_url":"https://api.github.com/users/SJLC/orgs","repos_url":"https://api.github.com/users/SJLC/repos","events_url":"https://api.github.com/users/SJLC/events{/privacy}","received_events_url":"https://api.github.com/users/SJLC/received_events","type":"User","site_admin":false},"created_at":"2016-05-26T08:59:55Z","updated_at":"2016-05-26T08:59:55Z","body":"Maybe... \r\n\r\nThere could be some check on ansible_version to pick whether to execute 'sudo' or 'become' version, though the check on ansible_version wouldn't distingish between a really old version and ansible 2.0 due to a bug (  https://github.com/ansible/ansible/issues/11545 )\r\n\r\nOn the other hand, ansible 2.0 has the 'sudo' backwards compatibility working again, unlike 1.9 ( https://github.com/nylas/ansible-test/issues/2 ), so perhaps the policy could to use sudo if ansible_version < 1.9 **or** ansible_version undefined.\r\n\r\nOn the third hand, is backward compatibility even _useful_ in this specific instance? ansible-test uses pip to install ansible, not the package manager, and without locking it to a specific version. Thus the newest stable ansible is always used for tests, and nowadays that is never going to be a version that lacks 'become' support.\r\n\r\nSo do you want to uglify things for a situation that won't be encountered with the current install strategy? If not, I could just re-base what's here now."}}
{"actor":{"display_login":"SJLC"}}