{"action":"opened","number":5924,"pull_request":{"url":"https://api.github.com/repos/WhisperSystems/Signal-Android/pulls/5924","id":96450353,"html_url":"https://github.com/WhisperSystems/Signal-Android/pull/5924","diff_url":"https://github.com/WhisperSystems/Signal-Android/pull/5924.diff","patch_url":"https://github.com/WhisperSystems/Signal-Android/pull/5924.patch","issue_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/issues/5924","number":5924,"state":"open","locked":false,"title":"fix corrupt messages crashing Signal","user":{"login":"Trolldemorted","id":10261186,"avatar_url":"https://avatars.githubusercontent.com/u/10261186?v=3","gravatar_id":"","url":"https://api.github.com/users/Trolldemorted","html_url":"https://github.com/Trolldemorted","followers_url":"https://api.github.com/users/Trolldemorted/followers","following_url":"https://api.github.com/users/Trolldemorted/following{/other_user}","gists_url":"https://api.github.com/users/Trolldemorted/gists{/gist_id}","starred_url":"https://api.github.com/users/Trolldemorted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trolldemorted/subscriptions","organizations_url":"https://api.github.com/users/Trolldemorted/orgs","repos_url":"https://api.github.com/users/Trolldemorted/repos","events_url":"https://api.github.com/users/Trolldemorted/events{/privacy}","received_events_url":"https://api.github.com/users/Trolldemorted/received_events","type":"User","site_admin":false},"body":"<!-- You can remove this first section if you have contributed before -->\r\n### First time contributor checklist\r\n<!-- replace the empty checkboxes [ ] below with checked ones [x] accordingly -->\r\n- [x] I have read [how to contribute](https://github.com/WhisperSystems/Signal-Android/blob/master/CONTRIBUTING.md) to this project\r\n- [x] I have signed the [Contributor Licence Agreement](https://whispersystems.org/cla/)\r\n\r\n### Contributor checklist\r\n<!-- replace the empty checkboxes [ ] below with checked ones [x] accordingly -->\r\n- [x] I am following the [Code Style Guidelines](https://github.com/WhisperSystems/Signal-Android/wiki/Code-Style-Guidelines)\r\n- [x] I have tested my contribution on these devices:\r\n nexus4\r\n- [x] My contribution is fully baked and ready to be merged as is\r\n- [x] I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the `Fixes #1234` [syntax](https://help.github.com/articles/closing-issues-via-commit-messages/)\r\n- [x] I have made the choice whether I want the [BitHub reward](https://github.com/WhisperSystems/Signal-Android/wiki/BitHub-Rewards) or not by omitting or adding the word `FREEBIE` in the commit message of my first commit\r\n\r\n----------\r\n\r\n### Description\r\n<!--\r\nDescribe briefly what your pull request proposes to fix. Especially if you have more than one commit, it is helpful to give a summary of what your contribution as a whole is trying to solve.\r\nAlso, please describe shortly how you tested that your fix actually works.\r\n-->\r\n\r\nlibsignal throws ArrayIndexOutOfBounds exception which terminate Signal-Android, if the serialized PreKeySignalMessage has the length zero.\r\nThis is fixing the crash in #5922 (and stops this bug from being exploited by adversaries which want to disrupt Signal), but not the cause of the malformed message.\r\n\r\nI could only test if this works with normal signal behaviour, since my device did not receive such a malformed/corrupt message.","created_at":"2016-12-04T22:42:50Z","updated_at":"2016-12-04T22:42:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/pulls/5924/commits","review_comments_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/pulls/5924/comments","review_comment_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/issues/5924/comments","statuses_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/statuses/31d55fd056555fa93253fb8b3ee4fa790de3d24b","head":{"label":"Trolldemorted:corruptmessagefix","ref":"corruptmessagefix","sha":"31d55fd056555fa93253fb8b3ee4fa790de3d24b","user":{"login":"Trolldemorted","id":10261186,"avatar_url":"https://avatars.githubusercontent.com/u/10261186?v=3","gravatar_id":"","url":"https://api.github.com/users/Trolldemorted","html_url":"https://github.com/Trolldemorted","followers_url":"https://api.github.com/users/Trolldemorted/followers","following_url":"https://api.github.com/users/Trolldemorted/following{/other_user}","gists_url":"https://api.github.com/users/Trolldemorted/gists{/gist_id}","starred_url":"https://api.github.com/users/Trolldemorted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trolldemorted/subscriptions","organizations_url":"https://api.github.com/users/Trolldemorted/orgs","repos_url":"https://api.github.com/users/Trolldemorted/repos","events_url":"https://api.github.com/users/Trolldemorted/events{/privacy}","received_events_url":"https://api.github.com/users/Trolldemorted/received_events","type":"User","site_admin":false},"repo":{"id":63255426,"name":"Signal-Android","full_name":"Trolldemorted/Signal-Android","owner":{"login":"Trolldemorted","id":10261186,"avatar_url":"https://avatars.githubusercontent.com/u/10261186?v=3","gravatar_id":"","url":"https://api.github.com/users/Trolldemorted","html_url":"https://github.com/Trolldemorted","followers_url":"https://api.github.com/users/Trolldemorted/followers","following_url":"https://api.github.com/users/Trolldemorted/following{/other_user}","gists_url":"https://api.github.com/users/Trolldemorted/gists{/gist_id}","starred_url":"https://api.github.com/users/Trolldemorted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trolldemorted/subscriptions","organizations_url":"https://api.github.com/users/Trolldemorted/orgs","repos_url":"https://api.github.com/users/Trolldemorted/repos","events_url":"https://api.github.com/users/Trolldemorted/events{/privacy}","received_events_url":"https://api.github.com/users/Trolldemorted/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Trolldemorted/Signal-Android","description":"A private messenger for Android.","fork":true,"url":"https://api.github.com/repos/Trolldemorted/Signal-Android","forks_url":"https://api.github.com/repos/Trolldemorted/Signal-Android/forks","keys_url":"https://api.github.com/repos/Trolldemorted/Signal-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Trolldemorted/Signal-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Trolldemorted/Signal-Android/teams","hooks_url":"https://api.github.com/repos/Trolldemorted/Signal-Android/hooks","issue_events_url":"https://api.github.com/repos/Trolldemorted/Signal-Android/issues/events{/number}","events_url":"https://api.github.com/repos/Trolldemorted/Signal-Android/events","assignees_url":"https://api.github.com/repos/Trolldemorted/Signal-Android/assignees{/user}","branches_url":"https://api.github.com/repos/Trolldemorted/Signal-Android/branches{/branch}","tags_url":"https://api.github.com/repos/Trolldemorted/Signal-Android/tags","blobs_url":"https://api.github.com/repos/Trolldemorted/Signal-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Trolldemorted/Signal-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Trolldemorted/Signal-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/Trolldemorted/Signal-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Trolldemorted/Signal-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/Trolldemorted/Signal-Android/languages","stargazers_url":"https://api.github.com/repos/Trolldemorted/Signal-Android/stargazers","contributors_url":"https://api.github.com/repos/Trolldemorted/Signal-Android/contributors","subscribers_url":"https://api.github.com/repos/Trolldemorted/Signal-Android/subscribers","subscription_url":"https://api.github.com/repos/Trolldemorted/Signal-Android/subscription","commits_url":"https://api.github.com/repos/Trolldemorted/Signal-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/Trolldemorted/Signal-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/Trolldemorted/Signal-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/Trolldemorted/Signal-Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/Trolldemorted/Signal-Android/contents/{+path}","compare_url":"https://api.github.com/repos/Trolldemorted/Signal-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Trolldemorted/Signal-Android/merges","archive_url":"https://api.github.com/repos/Trolldemorted/Signal-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Trolldemorted/Signal-Android/downloads","issues_url":"https://api.github.com/repos/Trolldemorted/Signal-Android/issues{/number}","pulls_url":"https://api.github.com/repos/Trolldemorted/Signal-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/Trolldemorted/Signal-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/Trolldemorted/Signal-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Trolldemorted/Signal-Android/labels{/name}","releases_url":"https://api.github.com/repos/Trolldemorted/Signal-Android/releases{/id}","deployments_url":"https://api.github.com/repos/Trolldemorted/Signal-Android/deployments","created_at":"2016-07-13T14:57:56Z","updated_at":"2016-07-13T14:58:13Z","pushed_at":"2016-12-04T22:27:37Z","git_url":"git://github.com/Trolldemorted/Signal-Android.git","ssh_url":"git@github.com:Trolldemorted/Signal-Android.git","clone_url":"https://github.com/Trolldemorted/Signal-Android.git","svn_url":"https://github.com/Trolldemorted/Signal-Android","homepage":"https://whispersystems.org","size":80846,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"WhisperSystems:master","ref":"master","sha":"5d341e175d086aba5266cb970c70e98c1f25fe14","user":{"login":"WhisperSystems","id":702459,"avatar_url":"https://avatars.githubusercontent.com/u/702459?v=3","gravatar_id":"","url":"https://api.github.com/users/WhisperSystems","html_url":"https://github.com/WhisperSystems","followers_url":"https://api.github.com/users/WhisperSystems/followers","following_url":"https://api.github.com/users/WhisperSystems/following{/other_user}","gists_url":"https://api.github.com/users/WhisperSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/WhisperSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WhisperSystems/subscriptions","organizations_url":"https://api.github.com/users/WhisperSystems/orgs","repos_url":"https://api.github.com/users/WhisperSystems/repos","events_url":"https://api.github.com/users/WhisperSystems/events{/privacy}","received_events_url":"https://api.github.com/users/WhisperSystems/received_events","type":"Organization","site_admin":false},"repo":{"id":2990192,"name":"Signal-Android","full_name":"WhisperSystems/Signal-Android","owner":{"login":"WhisperSystems","id":702459,"avatar_url":"https://avatars.githubusercontent.com/u/702459?v=3","gravatar_id":"","url":"https://api.github.com/users/WhisperSystems","html_url":"https://github.com/WhisperSystems","followers_url":"https://api.github.com/users/WhisperSystems/followers","following_url":"https://api.github.com/users/WhisperSystems/following{/other_user}","gists_url":"https://api.github.com/users/WhisperSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/WhisperSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WhisperSystems/subscriptions","organizations_url":"https://api.github.com/users/WhisperSystems/orgs","repos_url":"https://api.github.com/users/WhisperSystems/repos","events_url":"https://api.github.com/users/WhisperSystems/events{/privacy}","received_events_url":"https://api.github.com/users/WhisperSystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WhisperSystems/Signal-Android","description":"A private messenger for Android.","fork":false,"url":"https://api.github.com/repos/WhisperSystems/Signal-Android","forks_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/forks","keys_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/teams","hooks_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/hooks","issue_events_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/issues/events{/number}","events_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/events","assignees_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/assignees{/user}","branches_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/branches{/branch}","tags_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/tags","blobs_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/languages","stargazers_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/stargazers","contributors_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/contributors","subscribers_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/subscribers","subscription_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/subscription","commits_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/contents/{+path}","compare_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/merges","archive_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/downloads","issues_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/issues{/number}","pulls_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/labels{/name}","releases_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/releases{/id}","deployments_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/deployments","created_at":"2011-12-15T20:01:12Z","updated_at":"2016-12-04T12:33:30Z","pushed_at":"2016-12-04T22:42:50Z","git_url":"git://github.com/WhisperSystems/Signal-Android.git","ssh_url":"git@github.com:WhisperSystems/Signal-Android.git","clone_url":"https://github.com/WhisperSystems/Signal-Android.git","svn_url":"https://github.com/WhisperSystems/Signal-Android","homepage":"https://whispersystems.org","size":119390,"stargazers_count":6998,"watchers_count":6998,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1875,"mirror_url":null,"open_issues_count":765,"forks":1875,"open_issues":765,"watchers":6998,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WhisperSystems/Signal-Android/pulls/5924"},"html":{"href":"https://github.com/WhisperSystems/Signal-Android/pull/5924"},"issue":{"href":"https://api.github.com/repos/WhisperSystems/Signal-Android/issues/5924"},"comments":{"href":"https://api.github.com/repos/WhisperSystems/Signal-Android/issues/5924/comments"},"review_comments":{"href":"https://api.github.com/repos/WhisperSystems/Signal-Android/pulls/5924/comments"},"review_comment":{"href":"https://api.github.com/repos/WhisperSystems/Signal-Android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WhisperSystems/Signal-Android/pulls/5924/commits"},"statuses":{"href":"https://api.github.com/repos/WhisperSystems/Signal-Android/statuses/31d55fd056555fa93253fb8b3ee4fa790de3d24b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":5,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"Trolldemorted"}}