{"action":"created","comment":{"url":"https://api.github.com/repos/byroot/bootscale/pulls/comments/91542667","pull_request_review_id":12052448,"id":91542667,"diff_hunk":"@@ -0,0 +1,40 @@\n+module Bootscale\n+  module ActiveSupport\n+    class Cache < ::Bootscale::Cache\n+      def load_path\n+        ::ActiveSupport::Dependencies.autoload_paths","path":"lib/bootscale/active_support.rb","position":5,"original_position":5,"commit_id":"46a2eff092d2e979e80b44ba02515e57c1bf1efc","original_commit_id":"46a2eff092d2e979e80b44ba02515e57c1bf1efc","user":{"login":"grosser","id":11367,"avatar_url":"https://avatars.githubusercontent.com/u/11367?v=3","gravatar_id":"","url":"https://api.github.com/users/grosser","html_url":"https://github.com/grosser","followers_url":"https://api.github.com/users/grosser/followers","following_url":"https://api.github.com/users/grosser/following{/other_user}","gists_url":"https://api.github.com/users/grosser/gists{/gist_id}","starred_url":"https://api.github.com/users/grosser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grosser/subscriptions","organizations_url":"https://api.github.com/users/grosser/orgs","repos_url":"https://api.github.com/users/grosser/repos","events_url":"https://api.github.com/users/grosser/events{/privacy}","received_events_url":"https://api.github.com/users/grosser/received_events","type":"User","site_admin":false},"body":"nvm wrong file","created_at":"2016-12-08T15:57:17Z","updated_at":"2016-12-08T15:57:17Z","html_url":"https://github.com/byroot/bootscale/pull/40#discussion_r91542667","pull_request_url":"https://api.github.com/repos/byroot/bootscale/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/byroot/bootscale/pulls/comments/91542667"},"html":{"href":"https://github.com/byroot/bootscale/pull/40#discussion_r91542667"},"pull_request":{"href":"https://api.github.com/repos/byroot/bootscale/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/byroot/bootscale/pulls/40","id":97124520,"html_url":"https://github.com/byroot/bootscale/pull/40","diff_url":"https://github.com/byroot/bootscale/pull/40.diff","patch_url":"https://github.com/byroot/bootscale/pull/40.patch","issue_url":"https://api.github.com/repos/byroot/bootscale/issues/40","number":40,"state":"open","locked":false,"title":"Hook into ActiveSupport::Dependency to accelerate search_for_file","user":{"login":"casperisfine","id":19192189,"avatar_url":"https://avatars.githubusercontent.com/u/19192189?v=3","gravatar_id":"","url":"https://api.github.com/users/casperisfine","html_url":"https://github.com/casperisfine","followers_url":"https://api.github.com/users/casperisfine/followers","following_url":"https://api.github.com/users/casperisfine/following{/other_user}","gists_url":"https://api.github.com/users/casperisfine/gists{/gist_id}","starred_url":"https://api.github.com/users/casperisfine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/casperisfine/subscriptions","organizations_url":"https://api.github.com/users/casperisfine/orgs","repos_url":"https://api.github.com/users/casperisfine/repos","events_url":"https://api.github.com/users/casperisfine/events{/privacy}","received_events_url":"https://api.github.com/users/casperisfine/received_events","type":"User","site_admin":false},"body":"Fixes: https://github.com/byroot/bootscale/issues/26\r\n\r\nA big mistake I made in https://github.com/byroot/bootscale/issues/26#issuecomment-135827052 is that I was profiling the development environment, where eagerloading is disabled.\r\n\r\nAs a result `search_for_file` wasn't called that much. With eager loading enabled, this change improve the boot time from `35-47s` to `29-35` seconds. Note that there is a lot of variance, both because it's a quite long operation, and also because it involves quite a bit of IOs. But even if it's hard to measure precisely the improvement, it's easy to witness it's existence.\r\n\r\nI'll run more tests before merging this, but I don't expect much changes.","created_at":"2016-12-08T13:45:53Z","updated_at":"2016-12-08T15:57:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff906a5fbc61e71caa0799f6f4d844eab0c23d74","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/byroot/bootscale/pulls/40/commits","review_comments_url":"https://api.github.com/repos/byroot/bootscale/pulls/40/comments","review_comment_url":"https://api.github.com/repos/byroot/bootscale/pulls/comments{/number}","comments_url":"https://api.github.com/repos/byroot/bootscale/issues/40/comments","statuses_url":"https://api.github.com/repos/byroot/bootscale/statuses/46a2eff092d2e979e80b44ba02515e57c1bf1efc","head":{"label":"Shopify:as-dependency","ref":"as-dependency","sha":"46a2eff092d2e979e80b44ba02515e57c1bf1efc","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":60776259,"name":"bootscale","full_name":"Shopify/bootscale","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/bootscale","description":"Speedup applications boot by caching require calls","fork":true,"url":"https://api.github.com/repos/Shopify/bootscale","forks_url":"https://api.github.com/repos/Shopify/bootscale/forks","keys_url":"https://api.github.com/repos/Shopify/bootscale/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/bootscale/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/bootscale/teams","hooks_url":"https://api.github.com/repos/Shopify/bootscale/hooks","issue_events_url":"https://api.github.com/repos/Shopify/bootscale/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/bootscale/events","assignees_url":"https://api.github.com/repos/Shopify/bootscale/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/bootscale/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/bootscale/tags","blobs_url":"https://api.github.com/repos/Shopify/bootscale/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/bootscale/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/bootscale/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/bootscale/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/bootscale/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/bootscale/languages","stargazers_url":"https://api.github.com/repos/Shopify/bootscale/stargazers","contributors_url":"https://api.github.com/repos/Shopify/bootscale/contributors","subscribers_url":"https://api.github.com/repos/Shopify/bootscale/subscribers","subscription_url":"https://api.github.com/repos/Shopify/bootscale/subscription","commits_url":"https://api.github.com/repos/Shopify/bootscale/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/bootscale/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/bootscale/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/bootscale/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/bootscale/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/bootscale/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/bootscale/merges","archive_url":"https://api.github.com/repos/Shopify/bootscale/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/bootscale/downloads","issues_url":"https://api.github.com/repos/Shopify/bootscale/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/bootscale/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/bootscale/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/bootscale/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/bootscale/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/bootscale/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/bootscale/deployments","created_at":"2016-06-09T13:18:56Z","updated_at":"2016-10-20T16:19:59Z","pushed_at":"2016-12-08T13:33:39Z","git_url":"git://github.com/Shopify/bootscale.git","ssh_url":"git@github.com:Shopify/bootscale.git","clone_url":"https://github.com/Shopify/bootscale.git","svn_url":"https://github.com/Shopify/bootscale","homepage":null,"size":75,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"byroot:master","ref":"master","sha":"921dcd00c68e9c5d912888ddcf66b42669b99f1e","user":{"login":"byroot","id":44640,"avatar_url":"https://avatars.githubusercontent.com/u/44640?v=3","gravatar_id":"","url":"https://api.github.com/users/byroot","html_url":"https://github.com/byroot","followers_url":"https://api.github.com/users/byroot/followers","following_url":"https://api.github.com/users/byroot/following{/other_user}","gists_url":"https://api.github.com/users/byroot/gists{/gist_id}","starred_url":"https://api.github.com/users/byroot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/byroot/subscriptions","organizations_url":"https://api.github.com/users/byroot/orgs","repos_url":"https://api.github.com/users/byroot/repos","events_url":"https://api.github.com/users/byroot/events{/privacy}","received_events_url":"https://api.github.com/users/byroot/received_events","type":"User","site_admin":false},"repo":{"id":41261926,"name":"bootscale","full_name":"byroot/bootscale","owner":{"login":"byroot","id":44640,"avatar_url":"https://avatars.githubusercontent.com/u/44640?v=3","gravatar_id":"","url":"https://api.github.com/users/byroot","html_url":"https://github.com/byroot","followers_url":"https://api.github.com/users/byroot/followers","following_url":"https://api.github.com/users/byroot/following{/other_user}","gists_url":"https://api.github.com/users/byroot/gists{/gist_id}","starred_url":"https://api.github.com/users/byroot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/byroot/subscriptions","organizations_url":"https://api.github.com/users/byroot/orgs","repos_url":"https://api.github.com/users/byroot/repos","events_url":"https://api.github.com/users/byroot/events{/privacy}","received_events_url":"https://api.github.com/users/byroot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/byroot/bootscale","description":"Speedup applications boot by caching require calls","fork":false,"url":"https://api.github.com/repos/byroot/bootscale","forks_url":"https://api.github.com/repos/byroot/bootscale/forks","keys_url":"https://api.github.com/repos/byroot/bootscale/keys{/key_id}","collaborators_url":"https://api.github.com/repos/byroot/bootscale/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/byroot/bootscale/teams","hooks_url":"https://api.github.com/repos/byroot/bootscale/hooks","issue_events_url":"https://api.github.com/repos/byroot/bootscale/issues/events{/number}","events_url":"https://api.github.com/repos/byroot/bootscale/events","assignees_url":"https://api.github.com/repos/byroot/bootscale/assignees{/user}","branches_url":"https://api.github.com/repos/byroot/bootscale/branches{/branch}","tags_url":"https://api.github.com/repos/byroot/bootscale/tags","blobs_url":"https://api.github.com/repos/byroot/bootscale/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/byroot/bootscale/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/byroot/bootscale/git/refs{/sha}","trees_url":"https://api.github.com/repos/byroot/bootscale/git/trees{/sha}","statuses_url":"https://api.github.com/repos/byroot/bootscale/statuses/{sha}","languages_url":"https://api.github.com/repos/byroot/bootscale/languages","stargazers_url":"https://api.github.com/repos/byroot/bootscale/stargazers","contributors_url":"https://api.github.com/repos/byroot/bootscale/contributors","subscribers_url":"https://api.github.com/repos/byroot/bootscale/subscribers","subscription_url":"https://api.github.com/repos/byroot/bootscale/subscription","commits_url":"https://api.github.com/repos/byroot/bootscale/commits{/sha}","git_commits_url":"https://api.github.com/repos/byroot/bootscale/git/commits{/sha}","comments_url":"https://api.github.com/repos/byroot/bootscale/comments{/number}","issue_comment_url":"https://api.github.com/repos/byroot/bootscale/issues/comments{/number}","contents_url":"https://api.github.com/repos/byroot/bootscale/contents/{+path}","compare_url":"https://api.github.com/repos/byroot/bootscale/compare/{base}...{head}","merges_url":"https://api.github.com/repos/byroot/bootscale/merges","archive_url":"https://api.github.com/repos/byroot/bootscale/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/byroot/bootscale/downloads","issues_url":"https://api.github.com/repos/byroot/bootscale/issues{/number}","pulls_url":"https://api.github.com/repos/byroot/bootscale/pulls{/number}","milestones_url":"https://api.github.com/repos/byroot/bootscale/milestones{/number}","notifications_url":"https://api.github.com/repos/byroot/bootscale/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/byroot/bootscale/labels{/name}","releases_url":"https://api.github.com/repos/byroot/bootscale/releases{/id}","deployments_url":"https://api.github.com/repos/byroot/bootscale/deployments","created_at":"2015-08-23T18:33:37Z","updated_at":"2016-12-05T18:36:56Z","pushed_at":"2016-12-08T13:45:53Z","git_url":"git://github.com/byroot/bootscale.git","ssh_url":"git@github.com:byroot/bootscale.git","clone_url":"https://github.com/byroot/bootscale.git","svn_url":"https://github.com/byroot/bootscale","homepage":null,"size":70,"stargazers_count":135,"watchers_count":135,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":5,"forks":9,"open_issues":5,"watchers":135,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/byroot/bootscale/pulls/40"},"html":{"href":"https://github.com/byroot/bootscale/pull/40"},"issue":{"href":"https://api.github.com/repos/byroot/bootscale/issues/40"},"comments":{"href":"https://api.github.com/repos/byroot/bootscale/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/byroot/bootscale/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/byroot/bootscale/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/byroot/bootscale/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/byroot/bootscale/statuses/46a2eff092d2e979e80b44ba02515e57c1bf1efc"}}}}
{"actor":{"display_login":"grosser"}}