{"action":"created","issue":{"url":"https://api.github.com/repos/stratis-storage/stratisd/issues/172","repository_url":"https://api.github.com/repos/stratis-storage/stratisd","labels_url":"https://api.github.com/repos/stratis-storage/stratisd/issues/172/labels{/name}","comments_url":"https://api.github.com/repos/stratis-storage/stratisd/issues/172/comments","events_url":"https://api.github.com/repos/stratis-storage/stratisd/issues/172/events","html_url":"https://github.com/stratis-storage/stratisd/issues/172","id":194057173,"number":172,"title":"Consider abstracting methods that are identical between engines","user":{"login":"mulkieran","id":1218366,"avatar_url":"https://avatars.githubusercontent.com/u/1218366?v=3","gravatar_id":"","url":"https://api.github.com/users/mulkieran","html_url":"https://github.com/mulkieran","followers_url":"https://api.github.com/users/mulkieran/followers","following_url":"https://api.github.com/users/mulkieran/following{/other_user}","gists_url":"https://api.github.com/users/mulkieran/gists{/gist_id}","starred_url":"https://api.github.com/users/mulkieran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mulkieran/subscriptions","organizations_url":"https://api.github.com/users/mulkieran/orgs","repos_url":"https://api.github.com/users/mulkieran/repos","events_url":"https://api.github.com/users/mulkieran/events{/privacy}","received_events_url":"https://api.github.com/users/mulkieran/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"mulkieran","id":1218366,"avatar_url":"https://avatars.githubusercontent.com/u/1218366?v=3","gravatar_id":"","url":"https://api.github.com/users/mulkieran","html_url":"https://github.com/mulkieran","followers_url":"https://api.github.com/users/mulkieran/followers","following_url":"https://api.github.com/users/mulkieran/following{/other_user}","gists_url":"https://api.github.com/users/mulkieran/gists{/gist_id}","starred_url":"https://api.github.com/users/mulkieran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mulkieran/subscriptions","organizations_url":"https://api.github.com/users/mulkieran/orgs","repos_url":"https://api.github.com/users/mulkieran/repos","events_url":"https://api.github.com/users/mulkieran/events{/privacy}","received_events_url":"https://api.github.com/users/mulkieran/received_events","type":"User","site_admin":false},"assignees":[{"login":"mulkieran","id":1218366,"avatar_url":"https://avatars.githubusercontent.com/u/1218366?v=3","gravatar_id":"","url":"https://api.github.com/users/mulkieran","html_url":"https://github.com/mulkieran","followers_url":"https://api.github.com/users/mulkieran/followers","following_url":"https://api.github.com/users/mulkieran/following{/other_user}","gists_url":"https://api.github.com/users/mulkieran/gists{/gist_id}","starred_url":"https://api.github.com/users/mulkieran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mulkieran/subscriptions","organizations_url":"https://api.github.com/users/mulkieran/orgs","repos_url":"https://api.github.com/users/mulkieran/repos","events_url":"https://api.github.com/users/mulkieran/events{/privacy}","received_events_url":"https://api.github.com/users/mulkieran/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2016-12-07T14:02:44Z","updated_at":"2016-12-07T17:17:44Z","closed_at":null,"body":"This is a judgement call, because it would involve exposing more API. The methods that are currently identical are ```get_pool()```, ```destroy_pool()```, and ```rename_pool()```. All these require access to struct members which happen to be the same between the engines, but, being members, are not part of the Engine's public API."},"comment":{"url":"https://api.github.com/repos/stratis-storage/stratisd/issues/comments/265510458","html_url":"https://github.com/stratis-storage/stratisd/issues/172#issuecomment-265510458","issue_url":"https://api.github.com/repos/stratis-storage/stratisd/issues/172","id":265510458,"user":{"login":"mulkieran","id":1218366,"avatar_url":"https://avatars.githubusercontent.com/u/1218366?v=3","gravatar_id":"","url":"https://api.github.com/users/mulkieran","html_url":"https://github.com/mulkieran","followers_url":"https://api.github.com/users/mulkieran/followers","following_url":"https://api.github.com/users/mulkieran/following{/other_user}","gists_url":"https://api.github.com/users/mulkieran/gists{/gist_id}","starred_url":"https://api.github.com/users/mulkieran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mulkieran/subscriptions","organizations_url":"https://api.github.com/users/mulkieran/orgs","repos_url":"https://api.github.com/users/mulkieran/repos","events_url":"https://api.github.com/users/mulkieran/events{/privacy}","received_events_url":"https://api.github.com/users/mulkieran/received_events","type":"User","site_admin":false},"created_at":"2016-12-07T17:17:44Z","updated_at":"2016-12-07T17:17:44Z","body":"I think the macros are working out quite well right now: https://github.com/stratis-storage/stratisd/pull/173.\r\nThey are an improvement in themselves, and will help make any other non-accidental similarities easier to discover.\r\nThey are not a high cost to make, and won't be a high cost to throw away, if necessary.\r\nThey will motivate abstracting the collections into shared code, if possible, to make them, i.e., the macros, not break."}}
{"actor":{"display_login":"mulkieran"}}