{"push_id":1109507948,"size":12,"distinct_size":12,"ref":"refs/heads/master","head":"464db8a8606d069c7060d1adc6db2c36e25ea6bb","before":"484bde354df68f24bed5f1701e0d83d7cac54339","commits":[{"sha":"c86542ac5187680c13245dd3dbc5d6039e54fff0","author":{"email":"801424568fdeda9f30ffa7949021a7e7fd835410@users.noreply.github.com","name":"David Iten"},"message":"Move param checks for domain assignment out of dsiSetIndices and into '='\n\nMove checks to ensure rank and idxType match for domain assignments into\nthe domain '=' function.  Add another check that ensures stridable domains\nare not assigned to unstridable domains. This was previously allowed if the\nstridable domain had stride==1.\n\nThe plan is to add a cast from stridable domains to unstridable.  A regular\n(unsafe) cast could simply drop the stride without checking it, while a\nsafeCast can verify that the stride is 1 first.","distinct":true,"url":"https://api.github.com/repos/daviditen/chapel/commits/c86542ac5187680c13245dd3dbc5d6039e54fff0"},{"sha":"4addc8f7005edee2e13257f251c975b0f11979b0","author":{"email":"801424568fdeda9f30ffa7949021a7e7fd835410@users.noreply.github.com","name":"David Iten"},"message":"Add _cast and safeCast to cast away stride on rectangular domains\n\nThese new casts allow things like:\n\nvar D1 = {1..5}, D2 = {1..20 by 2}, D3 = {1..10 by 1};\n\nD1 = D2:domain(stridable=false); // {1..20}\nD1 = D3.safeCast(domain(stridable=false)); // {1..10}\nD1 = D2.safeCast(domain(stridable=false)); // halt - non-unit stride assigned\n\nAdded an extra check to 'chpl__isRectangularDomType' to allow it to return\nfalse when passed a non-domain type where before it just got an unresolved\ncall error.  This issue was encountered in the where clause of the new cast\nfunctions when trying to cast a domain into an array:\n  var x = {1..3}: [1..3] int;.","distinct":true,"url":"https://api.github.com/repos/daviditen/chapel/commits/4addc8f7005edee2e13257f251c975b0f11979b0"},{"sha":"25784427ec949b8c72451ba90d7cd9fd83df33e4","author":{"email":"801424568fdeda9f30ffa7949021a7e7fd835410@users.noreply.github.com","name":"David Iten"},"message":"Add a test using casts and safeCasts on domains to allow ignoring stridedness\n\nThe test does a handful of casts that can ignore stride and stridedness, and\nsafeCasts that only allow stridedness to be ignored when stride == 1.","distinct":true,"url":"https://api.github.com/repos/daviditen/chapel/commits/25784427ec949b8c72451ba90d7cd9fd83df33e4"},{"sha":"55595e05a27e7091e0d5ec6a6e5a855945542858","author":{"email":"801424568fdeda9f30ffa7949021a7e7fd835410@users.noreply.github.com","name":"David Iten"},"message":"Make assigning a stridable range to non-stridable range a compiler error\n\nAssigning a stridable range to a non-stridable range is now a compiler error.\n\nAdded a cast that can make a stridable range into non-stridable by discarding\nthe stride even if it is not 1.\n\nAdded a safeCast that can make a stridable range into a non-stridable range,\nbut will halt if stride was not 1.\n\nFixed a mistake in the domain _cast and safeCast functions that became\napparent with the new range cast functions.  They were causing stridable\nranges to be assigned to non-stridable by mistake.\n\nUpdated a .good file to expect the compiler error instead of a halt for\nassigning a stridable range to non-stridable with non-unit stride.\n\nAdded safeCasts to StencilDist, BlockDist, and BlockCyclicDist in a few places\nwhere they were assigning a stridable range with unit-stride to a\nnon-stridable range.","distinct":true,"url":"https://api.github.com/repos/daviditen/chapel/commits/55595e05a27e7091e0d5ec6a6e5a855945542858"},{"sha":"fe5fb679f5396ae0d29b69f4f5ad55aaa7a601a4","author":{"email":"801424568fdeda9f30ffa7949021a7e7fd835410@users.noreply.github.com","name":"David Iten"},"message":"Add a test for casts and safeCasts that ignore stridable on ranges\n\nThis test is similar to domains/diten/castAwayStridableDomain, but is for\nranges.","distinct":true,"url":"https://api.github.com/repos/daviditen/chapel/commits/fe5fb679f5396ae0d29b69f4f5ad55aaa7a601a4"},{"sha":"11e5a7bb40d5450b5c2a147213a31c6a102723c6","author":{"email":"801424568fdeda9f30ffa7949021a7e7fd835410@users.noreply.github.com","name":"David Iten"},"message":"Merge branch 'master' of github.com:chapel-lang/chapel into domain-stride-1-to-unstridable","distinct":true,"url":"https://api.github.com/repos/daviditen/chapel/commits/11e5a7bb40d5450b5c2a147213a31c6a102723c6"},{"sha":"5c5c7bf7c3fcbfc0d63eee5802c82f0268d80841","author":{"email":"801424568fdeda9f30ffa7949021a7e7fd835410@users.noreply.github.com","name":"David Iten"},"message":"Address reviewer comments in domain/range stridable assignment PR\n\nUpdate some comments to use suggested wordings.\nPay attention to the idxType of the result type in domain safeCasts and casts.","distinct":true,"url":"https://api.github.com/repos/daviditen/chapel/commits/5c5c7bf7c3fcbfc0d63eee5802c82f0268d80841"},{"sha":"cf9db696652b4851e5b981c69b16c5d39d03cc2c","author":{"email":"801424568fdeda9f30ffa7949021a7e7fd835410@users.noreply.github.com","name":"David Iten"},"message":"Address reviewer comments in range casts\n\nFactor out duplicated code from if/else branches and add casts to the new\ntype's idxType before assigning to fields of a temp with the new type.","distinct":true,"url":"https://api.github.com/repos/daviditen/chapel/commits/cf9db696652b4851e5b981c69b16c5d39d03cc2c"},{"sha":"fb0cb1b2116ee6b1c474657677fd8b3398621dac","author":{"email":"801424568fdeda9f30ffa7949021a7e7fd835410@users.noreply.github.com","name":"David Iten"},"message":"Address reviewer comments in domain assignment\n\nImprove the error message when trying to assign a stridable domain to a\nnon-stridable domain.","distinct":true,"url":"https://api.github.com/repos/daviditen/chapel/commits/fb0cb1b2116ee6b1c474657677fd8b3398621dac"},{"sha":"6389b210dc94f2d028e1128863f70061a1a5d774","author":{"email":"801424568fdeda9f30ffa7949021a7e7fd835410@users.noreply.github.com","name":"David Iten"},"message":"Address reviewer comments in range casts\n\nAdd a compilerError when casting or safeCasting a range tries to change\nbounded-ness.\n\nAdd a test that triggers that error in a few ways.","distinct":true,"url":"https://api.github.com/repos/daviditen/chapel/commits/6389b210dc94f2d028e1128863f70061a1a5d774"},{"sha":"5cf1ca88681bf8f3e546352a0caead80a0aabc1b","author":{"email":"801424568fdeda9f30ffa7949021a7e7fd835410@users.noreply.github.com","name":"David Iten"},"message":"Merge with master and resolve a conflict\n\nBringing this branch up to date had 1 conflict in ChapelArray.chpl. Resolved\nthat conflict.","distinct":true,"url":"https://api.github.com/repos/daviditen/chapel/commits/5cf1ca88681bf8f3e546352a0caead80a0aabc1b"},{"sha":"464db8a8606d069c7060d1adc6db2c36e25ea6bb","author":{"email":"801424568fdeda9f30ffa7949021a7e7fd835410@users.noreply.github.com","name":"David Iten"},"message":"Merge pull request #3778 from daviditen/domain-stride-1-to-unstridable\n\nMake assigning stridable ranges and domains to non-stridable a compilerError\r\n\r\n[reviewed by @vasslitvinov ]\r\n\r\nAdded a cast that can make a stridable range/domain into non-stridable by\r\ndiscarding the stride even if it is not 1.\r\n\r\nAdded a safeCast that can make a stridable range/domain into a non-stridable\r\nrange/domain, but will halt if stride was not 1.\r\n\r\nMoved checks to ensure rank and idxType match for domain assignments into\r\nthe domain '=' function. Added the check that ensures stridable domains are\r\nnot assigned to unstridable domains here as well.\r\n\r\nAdded safeCasts to StencilDist, BlockDist, and BlockCyclicDist in a few places\r\nwhere they were assigning a stridable range with unit-stride to a\r\nnon-stridable range.\r\n\r\nUpdated a .good file to expect the compiler error instead of a halt for\r\nassigning a stridable range to non-stridable with non-unit stride.\r\n\r\nAdded tests for domain and range casts and safeCasts.\r\nAdded a test that attempts to change range boundedness with casts and expects compiler errors.\r\n\r\nThere was some discussion about this in PR #3703","distinct":true,"url":"https://api.github.com/repos/daviditen/chapel/commits/464db8a8606d069c7060d1adc6db2c36e25ea6bb"}]}