{"action":"created","comment":{"url":"https://api.github.com/repos/ESMCI/cime/pulls/comments/54150242","id":54150242,"diff_hunk":"@@ -59,9 +62,11 @@ def __init__(self, test_names,\n         # We will not use batch system if user asked for no_batch or if current\n         # machine is not a batch machine\n         self._no_batch = no_batch or not self._machobj.has_batch_system()\n-\n-        self._test_root = test_root if test_root is not None else self._machobj.get_value(\"CESMSCRATCHROOT\")\n-        if (self._project is not None):\n+        if test_root is None:","path":"utils/python/CIME/system_test.py","position":81,"original_position":81,"commit_id":"426c3567ccdab77b028ca73374e567a583e220f0","original_commit_id":"426c3567ccdab77b028ca73374e567a583e220f0","user":{"login":"jgfouca","id":7292036,"avatar_url":"https://avatars.githubusercontent.com/u/7292036?v=3","gravatar_id":"","url":"https://api.github.com/users/jgfouca","html_url":"https://github.com/jgfouca","followers_url":"https://api.github.com/users/jgfouca/followers","following_url":"https://api.github.com/users/jgfouca/following{/other_user}","gists_url":"https://api.github.com/users/jgfouca/gists{/gist_id}","starred_url":"https://api.github.com/users/jgfouca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgfouca/subscriptions","organizations_url":"https://api.github.com/users/jgfouca/orgs","repos_url":"https://api.github.com/users/jgfouca/repos","events_url":"https://api.github.com/users/jgfouca/events{/privacy}","received_events_url":"https://api.github.com/users/jgfouca/received_events","type":"User","site_admin":false},"body":"Why replace ternary?","created_at":"2016-02-25T19:32:27Z","updated_at":"2016-02-25T19:32:27Z","html_url":"https://github.com/ESMCI/cime/pull/69#discussion_r54150242","pull_request_url":"https://api.github.com/repos/ESMCI/cime/pulls/69","_links":{"self":{"href":"https://api.github.com/repos/ESMCI/cime/pulls/comments/54150242"},"html":{"href":"https://github.com/ESMCI/cime/pull/69#discussion_r54150242"},"pull_request":{"href":"https://api.github.com/repos/ESMCI/cime/pulls/69"}}},"pull_request":{"url":"https://api.github.com/repos/ESMCI/cime/pulls/69","id":60580354,"html_url":"https://github.com/ESMCI/cime/pull/69","diff_url":"https://github.com/ESMCI/cime/pull/69.diff","patch_url":"https://github.com/ESMCI/cime/pull/69.patch","issue_url":"https://api.github.com/repos/ESMCI/cime/issues/69","number":69,"state":"open","locked":false,"title":"Directorycleanup","user":{"login":"jedwards4b","id":6126104,"avatar_url":"https://avatars.githubusercontent.com/u/6126104?v=3","gravatar_id":"","url":"https://api.github.com/users/jedwards4b","html_url":"https://github.com/jedwards4b","followers_url":"https://api.github.com/users/jedwards4b/followers","following_url":"https://api.github.com/users/jedwards4b/following{/other_user}","gists_url":"https://api.github.com/users/jedwards4b/gists{/gist_id}","starred_url":"https://api.github.com/users/jedwards4b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedwards4b/subscriptions","organizations_url":"https://api.github.com/users/jedwards4b/orgs","repos_url":"https://api.github.com/users/jedwards4b/repos","events_url":"https://api.github.com/users/jedwards4b/events{/privacy}","received_events_url":"https://api.github.com/users/jedwards4b/received_events","type":"User","site_admin":false},"body":"This PR begins the process of moving tests from csh to python, this PR handles the build, I plan\r\nto handle the run next.   It also removes the scripts-python directory and merges the python and perl\r\nscripts directories.   ","created_at":"2016-02-24T21:20:51Z","updated_at":"2016-02-25T19:32:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a592204eba7444f7b2c82e4b134cd894a03d3f4","assignee":{"login":"jgfouca","id":7292036,"avatar_url":"https://avatars.githubusercontent.com/u/7292036?v=3","gravatar_id":"","url":"https://api.github.com/users/jgfouca","html_url":"https://github.com/jgfouca","followers_url":"https://api.github.com/users/jgfouca/followers","following_url":"https://api.github.com/users/jgfouca/following{/other_user}","gists_url":"https://api.github.com/users/jgfouca/gists{/gist_id}","starred_url":"https://api.github.com/users/jgfouca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgfouca/subscriptions","organizations_url":"https://api.github.com/users/jgfouca/orgs","repos_url":"https://api.github.com/users/jgfouca/repos","events_url":"https://api.github.com/users/jgfouca/events{/privacy}","received_events_url":"https://api.github.com/users/jgfouca/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/ESMCI/cime/pulls/69/commits","review_comments_url":"https://api.github.com/repos/ESMCI/cime/pulls/69/comments","review_comment_url":"https://api.github.com/repos/ESMCI/cime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ESMCI/cime/issues/69/comments","statuses_url":"https://api.github.com/repos/ESMCI/cime/statuses/426c3567ccdab77b028ca73374e567a583e220f0","head":{"label":"jedwards4b:directorycleanup","ref":"directorycleanup","sha":"426c3567ccdab77b028ca73374e567a583e220f0","user":{"login":"jedwards4b","id":6126104,"avatar_url":"https://avatars.githubusercontent.com/u/6126104?v=3","gravatar_id":"","url":"https://api.github.com/users/jedwards4b","html_url":"https://github.com/jedwards4b","followers_url":"https://api.github.com/users/jedwards4b/followers","following_url":"https://api.github.com/users/jedwards4b/following{/other_user}","gists_url":"https://api.github.com/users/jedwards4b/gists{/gist_id}","starred_url":"https://api.github.com/users/jedwards4b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedwards4b/subscriptions","organizations_url":"https://api.github.com/users/jedwards4b/orgs","repos_url":"https://api.github.com/users/jedwards4b/repos","events_url":"https://api.github.com/users/jedwards4b/events{/privacy}","received_events_url":"https://api.github.com/users/jedwards4b/received_events","type":"User","site_admin":false},"repo":{"id":42525196,"name":"cime","full_name":"jedwards4b/cime","owner":{"login":"jedwards4b","id":6126104,"avatar_url":"https://avatars.githubusercontent.com/u/6126104?v=3","gravatar_id":"","url":"https://api.github.com/users/jedwards4b","html_url":"https://github.com/jedwards4b","followers_url":"https://api.github.com/users/jedwards4b/followers","following_url":"https://api.github.com/users/jedwards4b/following{/other_user}","gists_url":"https://api.github.com/users/jedwards4b/gists{/gist_id}","starred_url":"https://api.github.com/users/jedwards4b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedwards4b/subscriptions","organizations_url":"https://api.github.com/users/jedwards4b/orgs","repos_url":"https://api.github.com/users/jedwards4b/repos","events_url":"https://api.github.com/users/jedwards4b/events{/privacy}","received_events_url":"https://api.github.com/users/jedwards4b/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jedwards4b/cime","description":"Common Infrastructure for Modeling the Environment","fork":true,"url":"https://api.github.com/repos/jedwards4b/cime","forks_url":"https://api.github.com/repos/jedwards4b/cime/forks","keys_url":"https://api.github.com/repos/jedwards4b/cime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jedwards4b/cime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jedwards4b/cime/teams","hooks_url":"https://api.github.com/repos/jedwards4b/cime/hooks","issue_events_url":"https://api.github.com/repos/jedwards4b/cime/issues/events{/number}","events_url":"https://api.github.com/repos/jedwards4b/cime/events","assignees_url":"https://api.github.com/repos/jedwards4b/cime/assignees{/user}","branches_url":"https://api.github.com/repos/jedwards4b/cime/branches{/branch}","tags_url":"https://api.github.com/repos/jedwards4b/cime/tags","blobs_url":"https://api.github.com/repos/jedwards4b/cime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jedwards4b/cime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jedwards4b/cime/git/refs{/sha}","trees_url":"https://api.github.com/repos/jedwards4b/cime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jedwards4b/cime/statuses/{sha}","languages_url":"https://api.github.com/repos/jedwards4b/cime/languages","stargazers_url":"https://api.github.com/repos/jedwards4b/cime/stargazers","contributors_url":"https://api.github.com/repos/jedwards4b/cime/contributors","subscribers_url":"https://api.github.com/repos/jedwards4b/cime/subscribers","subscription_url":"https://api.github.com/repos/jedwards4b/cime/subscription","commits_url":"https://api.github.com/repos/jedwards4b/cime/commits{/sha}","git_commits_url":"https://api.github.com/repos/jedwards4b/cime/git/commits{/sha}","comments_url":"https://api.github.com/repos/jedwards4b/cime/comments{/number}","issue_comment_url":"https://api.github.com/repos/jedwards4b/cime/issues/comments{/number}","contents_url":"https://api.github.com/repos/jedwards4b/cime/contents/{+path}","compare_url":"https://api.github.com/repos/jedwards4b/cime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jedwards4b/cime/merges","archive_url":"https://api.github.com/repos/jedwards4b/cime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jedwards4b/cime/downloads","issues_url":"https://api.github.com/repos/jedwards4b/cime/issues{/number}","pulls_url":"https://api.github.com/repos/jedwards4b/cime/pulls{/number}","milestones_url":"https://api.github.com/repos/jedwards4b/cime/milestones{/number}","notifications_url":"https://api.github.com/repos/jedwards4b/cime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jedwards4b/cime/labels{/name}","releases_url":"https://api.github.com/repos/jedwards4b/cime/releases{/id}","deployments_url":"https://api.github.com/repos/jedwards4b/cime/deployments","created_at":"2015-09-15T14:38:34Z","updated_at":"2016-01-21T01:38:18Z","pushed_at":"2016-02-25T17:59:52Z","git_url":"git://github.com/jedwards4b/cime.git","ssh_url":"git@github.com:jedwards4b/cime.git","clone_url":"https://github.com/jedwards4b/cime.git","svn_url":"https://github.com/jedwards4b/cime","homepage":null,"size":15012,"stargazers_count":0,"watchers_count":0,"language":"FORTRAN","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ESMCI:master","ref":"master","sha":"f024857e1effc4707efde7815d56cad1ac2c0508","user":{"login":"ESMCI","id":10676238,"avatar_url":"https://avatars.githubusercontent.com/u/10676238?v=3","gravatar_id":"","url":"https://api.github.com/users/ESMCI","html_url":"https://github.com/ESMCI","followers_url":"https://api.github.com/users/ESMCI/followers","following_url":"https://api.github.com/users/ESMCI/following{/other_user}","gists_url":"https://api.github.com/users/ESMCI/gists{/gist_id}","starred_url":"https://api.github.com/users/ESMCI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ESMCI/subscriptions","organizations_url":"https://api.github.com/users/ESMCI/orgs","repos_url":"https://api.github.com/users/ESMCI/repos","events_url":"https://api.github.com/users/ESMCI/events{/privacy}","received_events_url":"https://api.github.com/users/ESMCI/received_events","type":"Organization","site_admin":false},"repo":{"id":31605662,"name":"cime","full_name":"ESMCI/cime","owner":{"login":"ESMCI","id":10676238,"avatar_url":"https://avatars.githubusercontent.com/u/10676238?v=3","gravatar_id":"","url":"https://api.github.com/users/ESMCI","html_url":"https://github.com/ESMCI","followers_url":"https://api.github.com/users/ESMCI/followers","following_url":"https://api.github.com/users/ESMCI/following{/other_user}","gists_url":"https://api.github.com/users/ESMCI/gists{/gist_id}","starred_url":"https://api.github.com/users/ESMCI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ESMCI/subscriptions","organizations_url":"https://api.github.com/users/ESMCI/orgs","repos_url":"https://api.github.com/users/ESMCI/repos","events_url":"https://api.github.com/users/ESMCI/events{/privacy}","received_events_url":"https://api.github.com/users/ESMCI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ESMCI/cime","description":"Common Infrastructure for Modeling the Earth","fork":false,"url":"https://api.github.com/repos/ESMCI/cime","forks_url":"https://api.github.com/repos/ESMCI/cime/forks","keys_url":"https://api.github.com/repos/ESMCI/cime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ESMCI/cime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ESMCI/cime/teams","hooks_url":"https://api.github.com/repos/ESMCI/cime/hooks","issue_events_url":"https://api.github.com/repos/ESMCI/cime/issues/events{/number}","events_url":"https://api.github.com/repos/ESMCI/cime/events","assignees_url":"https://api.github.com/repos/ESMCI/cime/assignees{/user}","branches_url":"https://api.github.com/repos/ESMCI/cime/branches{/branch}","tags_url":"https://api.github.com/repos/ESMCI/cime/tags","blobs_url":"https://api.github.com/repos/ESMCI/cime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ESMCI/cime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ESMCI/cime/git/refs{/sha}","trees_url":"https://api.github.com/repos/ESMCI/cime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ESMCI/cime/statuses/{sha}","languages_url":"https://api.github.com/repos/ESMCI/cime/languages","stargazers_url":"https://api.github.com/repos/ESMCI/cime/stargazers","contributors_url":"https://api.github.com/repos/ESMCI/cime/contributors","subscribers_url":"https://api.github.com/repos/ESMCI/cime/subscribers","subscription_url":"https://api.github.com/repos/ESMCI/cime/subscription","commits_url":"https://api.github.com/repos/ESMCI/cime/commits{/sha}","git_commits_url":"https://api.github.com/repos/ESMCI/cime/git/commits{/sha}","comments_url":"https://api.github.com/repos/ESMCI/cime/comments{/number}","issue_comment_url":"https://api.github.com/repos/ESMCI/cime/issues/comments{/number}","contents_url":"https://api.github.com/repos/ESMCI/cime/contents/{+path}","compare_url":"https://api.github.com/repos/ESMCI/cime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ESMCI/cime/merges","archive_url":"https://api.github.com/repos/ESMCI/cime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ESMCI/cime/downloads","issues_url":"https://api.github.com/repos/ESMCI/cime/issues{/number}","pulls_url":"https://api.github.com/repos/ESMCI/cime/pulls{/number}","milestones_url":"https://api.github.com/repos/ESMCI/cime/milestones{/number}","notifications_url":"https://api.github.com/repos/ESMCI/cime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ESMCI/cime/labels{/name}","releases_url":"https://api.github.com/repos/ESMCI/cime/releases{/id}","deployments_url":"https://api.github.com/repos/ESMCI/cime/deployments","created_at":"2015-03-03T15:33:00Z","updated_at":"2016-02-21T17:54:50Z","pushed_at":"2016-02-25T17:59:53Z","git_url":"git://github.com/ESMCI/cime.git","ssh_url":"git@github.com:ESMCI/cime.git","clone_url":"https://github.com/ESMCI/cime.git","svn_url":"https://github.com/ESMCI/cime","homepage":"","size":14279,"stargazers_count":2,"watchers_count":2,"language":"FORTRAN","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":13,"forks":30,"open_issues":13,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ESMCI/cime/pulls/69"},"html":{"href":"https://github.com/ESMCI/cime/pull/69"},"issue":{"href":"https://api.github.com/repos/ESMCI/cime/issues/69"},"comments":{"href":"https://api.github.com/repos/ESMCI/cime/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/ESMCI/cime/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/ESMCI/cime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ESMCI/cime/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/ESMCI/cime/statuses/426c3567ccdab77b028ca73374e567a583e220f0"}}}}