{"action":"created","comment":{"url":"https://api.github.com/repos/stratis-storage/stratisd/pulls/comments/83931628","pull_request_review_id":4741672,"id":83931628,"diff_hunk":"@@ -121,7 +121,30 @@ fn list_pools(m: &MethodInfo<MTFn<TData>, TData>) -> MethodResult {\n \n \n fn create_volumes(m: &MethodInfo<MTFn<TData>, TData>) -> MethodResult {\n+    let message: &Message = m.msg;\n+    let mut iter = message.iter_init();\n+    let dbus_context = m.path.get_data();\n+    let object_path = m.path.get_name();\n+\n+    let receiving = format!(\"{:?}\", message.get_items());\n+    println!(\"Receiving {}\", receiving);\n \n+    println!(\"Object Path {}\", object_path);\n+\n+    match dbus_context.borrow_mut().pools.get(&object_path.clone().to_string()) {\n+        Some(pool) => println!(\"{}: {}\", object_path, pool),\n+        None => println!(\"{} not  found.\", object_path),\n+    }\n+\n+    let _volumes: Array<(&str, &str, &str), _> = try!(iter.read::<Array<(&str, &str, &str), _>>()\n+        .map_err(|_| MethodErr::invalid_arg(&2)));\n+\n+    // let result = {","path":"src/dbus_api.rs","position":22,"original_position":22,"commit_id":"5ebe5a2b8593956033053ced9ac4fe1f4c66fcb5","original_commit_id":"5ebe5a2b8593956033053ced9ac4fe1f4c66fcb5","user":{"login":"mulkieran","id":1218366,"avatar_url":"https://avatars.githubusercontent.com/u/1218366?v=3","gravatar_id":"","url":"https://api.github.com/users/mulkieran","html_url":"https://github.com/mulkieran","followers_url":"https://api.github.com/users/mulkieran/followers","following_url":"https://api.github.com/users/mulkieran/following{/other_user}","gists_url":"https://api.github.com/users/mulkieran/gists{/gist_id}","starred_url":"https://api.github.com/users/mulkieran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mulkieran/subscriptions","organizations_url":"https://api.github.com/users/mulkieran/orgs","repos_url":"https://api.github.com/users/mulkieran/repos","events_url":"https://api.github.com/users/mulkieran/events{/privacy}","received_events_url":"https://api.github.com/users/mulkieran/received_events","type":"User","site_admin":false},"body":"I'ld like to ditch this commented out code.","created_at":"2016-10-18T19:26:41Z","updated_at":"2016-10-18T19:40:48Z","html_url":"https://github.com/stratis-storage/stratisd/pull/94#discussion_r83931628","pull_request_url":"https://api.github.com/repos/stratis-storage/stratisd/pulls/94","_links":{"self":{"href":"https://api.github.com/repos/stratis-storage/stratisd/pulls/comments/83931628"},"html":{"href":"https://github.com/stratis-storage/stratisd/pull/94#discussion_r83931628"},"pull_request":{"href":"https://api.github.com/repos/stratis-storage/stratisd/pulls/94"}}},"pull_request":{"url":"https://api.github.com/repos/stratis-storage/stratisd/pulls/94","id":89872122,"html_url":"https://github.com/stratis-storage/stratisd/pull/94","diff_url":"https://github.com/stratis-storage/stratisd/pull/94.diff","patch_url":"https://github.com/stratis-storage/stratisd/pull/94.patch","issue_url":"https://api.github.com/repos/stratis-storage/stratisd/issues/94","number":94,"state":"open","locked":false,"title":"Add parameters to pool interface / place holders for pool interface pass parameters to engine","user":{"login":"trgill","id":13203542,"avatar_url":"https://avatars.githubusercontent.com/u/13203542?v=3","gravatar_id":"","url":"https://api.github.com/users/trgill","html_url":"https://github.com/trgill","followers_url":"https://api.github.com/users/trgill/followers","following_url":"https://api.github.com/users/trgill/following{/other_user}","gists_url":"https://api.github.com/users/trgill/gists{/gist_id}","starred_url":"https://api.github.com/users/trgill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trgill/subscriptions","organizations_url":"https://api.github.com/users/trgill/orgs","repos_url":"https://api.github.com/users/trgill/repos","events_url":"https://api.github.com/users/trgill/events{/privacy}","received_events_url":"https://api.github.com/users/trgill/received_events","type":"User","site_admin":false},"body":"\r\n- initial place holders for pool parameters\r\n- fixed problem with interface name\r\n- added place holders for parsing the parameters to create_volumes\r\n- insert a mapping of the object path name to the pool name in the dbus_context","created_at":"2016-10-18T18:26:51Z","updated_at":"2016-10-18T19:40:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e83f639a298e68d259648b874f1356012007a07","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/stratis-storage/stratisd/pulls/94/commits","review_comments_url":"https://api.github.com/repos/stratis-storage/stratisd/pulls/94/comments","review_comment_url":"https://api.github.com/repos/stratis-storage/stratisd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stratis-storage/stratisd/issues/94/comments","statuses_url":"https://api.github.com/repos/stratis-storage/stratisd/statuses/5ebe5a2b8593956033053ced9ac4fe1f4c66fcb5","head":{"label":"trgill:add_parameters_to_pool_interface","ref":"add_parameters_to_pool_interface","sha":"5ebe5a2b8593956033053ced9ac4fe1f4c66fcb5","user":{"login":"trgill","id":13203542,"avatar_url":"https://avatars.githubusercontent.com/u/13203542?v=3","gravatar_id":"","url":"https://api.github.com/users/trgill","html_url":"https://github.com/trgill","followers_url":"https://api.github.com/users/trgill/followers","following_url":"https://api.github.com/users/trgill/following{/other_user}","gists_url":"https://api.github.com/users/trgill/gists{/gist_id}","starred_url":"https://api.github.com/users/trgill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trgill/subscriptions","organizations_url":"https://api.github.com/users/trgill/orgs","repos_url":"https://api.github.com/users/trgill/repos","events_url":"https://api.github.com/users/trgill/events{/privacy}","received_events_url":"https://api.github.com/users/trgill/received_events","type":"User","site_admin":false},"repo":{"id":69361555,"name":"stratisd","full_name":"trgill/stratisd","owner":{"login":"trgill","id":13203542,"avatar_url":"https://avatars.githubusercontent.com/u/13203542?v=3","gravatar_id":"","url":"https://api.github.com/users/trgill","html_url":"https://github.com/trgill","followers_url":"https://api.github.com/users/trgill/followers","following_url":"https://api.github.com/users/trgill/following{/other_user}","gists_url":"https://api.github.com/users/trgill/gists{/gist_id}","starred_url":"https://api.github.com/users/trgill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trgill/subscriptions","organizations_url":"https://api.github.com/users/trgill/orgs","repos_url":"https://api.github.com/users/trgill/repos","events_url":"https://api.github.com/users/trgill/events{/privacy}","received_events_url":"https://api.github.com/users/trgill/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trgill/stratisd","description":null,"fork":true,"url":"https://api.github.com/repos/trgill/stratisd","forks_url":"https://api.github.com/repos/trgill/stratisd/forks","keys_url":"https://api.github.com/repos/trgill/stratisd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trgill/stratisd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trgill/stratisd/teams","hooks_url":"https://api.github.com/repos/trgill/stratisd/hooks","issue_events_url":"https://api.github.com/repos/trgill/stratisd/issues/events{/number}","events_url":"https://api.github.com/repos/trgill/stratisd/events","assignees_url":"https://api.github.com/repos/trgill/stratisd/assignees{/user}","branches_url":"https://api.github.com/repos/trgill/stratisd/branches{/branch}","tags_url":"https://api.github.com/repos/trgill/stratisd/tags","blobs_url":"https://api.github.com/repos/trgill/stratisd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trgill/stratisd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trgill/stratisd/git/refs{/sha}","trees_url":"https://api.github.com/repos/trgill/stratisd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trgill/stratisd/statuses/{sha}","languages_url":"https://api.github.com/repos/trgill/stratisd/languages","stargazers_url":"https://api.github.com/repos/trgill/stratisd/stargazers","contributors_url":"https://api.github.com/repos/trgill/stratisd/contributors","subscribers_url":"https://api.github.com/repos/trgill/stratisd/subscribers","subscription_url":"https://api.github.com/repos/trgill/stratisd/subscription","commits_url":"https://api.github.com/repos/trgill/stratisd/commits{/sha}","git_commits_url":"https://api.github.com/repos/trgill/stratisd/git/commits{/sha}","comments_url":"https://api.github.com/repos/trgill/stratisd/comments{/number}","issue_comment_url":"https://api.github.com/repos/trgill/stratisd/issues/comments{/number}","contents_url":"https://api.github.com/repos/trgill/stratisd/contents/{+path}","compare_url":"https://api.github.com/repos/trgill/stratisd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trgill/stratisd/merges","archive_url":"https://api.github.com/repos/trgill/stratisd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trgill/stratisd/downloads","issues_url":"https://api.github.com/repos/trgill/stratisd/issues{/number}","pulls_url":"https://api.github.com/repos/trgill/stratisd/pulls{/number}","milestones_url":"https://api.github.com/repos/trgill/stratisd/milestones{/number}","notifications_url":"https://api.github.com/repos/trgill/stratisd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trgill/stratisd/labels{/name}","releases_url":"https://api.github.com/repos/trgill/stratisd/releases{/id}","deployments_url":"https://api.github.com/repos/trgill/stratisd/deployments","created_at":"2016-09-27T13:47:50Z","updated_at":"2016-09-27T13:47:51Z","pushed_at":"2016-10-18T19:03:43Z","git_url":"git://github.com/trgill/stratisd.git","ssh_url":"git@github.com:trgill/stratisd.git","clone_url":"https://github.com/trgill/stratisd.git","svn_url":"https://github.com/trgill/stratisd","homepage":null,"size":165,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stratis-storage:master","ref":"master","sha":"a6bd5137babe5e1c8175d62984d8290a4d95d2e3","user":{"login":"stratis-storage","id":21202300,"avatar_url":"https://avatars.githubusercontent.com/u/21202300?v=3","gravatar_id":"","url":"https://api.github.com/users/stratis-storage","html_url":"https://github.com/stratis-storage","followers_url":"https://api.github.com/users/stratis-storage/followers","following_url":"https://api.github.com/users/stratis-storage/following{/other_user}","gists_url":"https://api.github.com/users/stratis-storage/gists{/gist_id}","starred_url":"https://api.github.com/users/stratis-storage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratis-storage/subscriptions","organizations_url":"https://api.github.com/users/stratis-storage/orgs","repos_url":"https://api.github.com/users/stratis-storage/repos","events_url":"https://api.github.com/users/stratis-storage/events{/privacy}","received_events_url":"https://api.github.com/users/stratis-storage/received_events","type":"Organization","site_admin":false},"repo":{"id":66564704,"name":"stratisd","full_name":"stratis-storage/stratisd","owner":{"login":"stratis-storage","id":21202300,"avatar_url":"https://avatars.githubusercontent.com/u/21202300?v=3","gravatar_id":"","url":"https://api.github.com/users/stratis-storage","html_url":"https://github.com/stratis-storage","followers_url":"https://api.github.com/users/stratis-storage/followers","following_url":"https://api.github.com/users/stratis-storage/following{/other_user}","gists_url":"https://api.github.com/users/stratis-storage/gists{/gist_id}","starred_url":"https://api.github.com/users/stratis-storage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratis-storage/subscriptions","organizations_url":"https://api.github.com/users/stratis-storage/orgs","repos_url":"https://api.github.com/users/stratis-storage/repos","events_url":"https://api.github.com/users/stratis-storage/events{/privacy}","received_events_url":"https://api.github.com/users/stratis-storage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stratis-storage/stratisd","description":null,"fork":false,"url":"https://api.github.com/repos/stratis-storage/stratisd","forks_url":"https://api.github.com/repos/stratis-storage/stratisd/forks","keys_url":"https://api.github.com/repos/stratis-storage/stratisd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stratis-storage/stratisd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stratis-storage/stratisd/teams","hooks_url":"https://api.github.com/repos/stratis-storage/stratisd/hooks","issue_events_url":"https://api.github.com/repos/stratis-storage/stratisd/issues/events{/number}","events_url":"https://api.github.com/repos/stratis-storage/stratisd/events","assignees_url":"https://api.github.com/repos/stratis-storage/stratisd/assignees{/user}","branches_url":"https://api.github.com/repos/stratis-storage/stratisd/branches{/branch}","tags_url":"https://api.github.com/repos/stratis-storage/stratisd/tags","blobs_url":"https://api.github.com/repos/stratis-storage/stratisd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stratis-storage/stratisd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stratis-storage/stratisd/git/refs{/sha}","trees_url":"https://api.github.com/repos/stratis-storage/stratisd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stratis-storage/stratisd/statuses/{sha}","languages_url":"https://api.github.com/repos/stratis-storage/stratisd/languages","stargazers_url":"https://api.github.com/repos/stratis-storage/stratisd/stargazers","contributors_url":"https://api.github.com/repos/stratis-storage/stratisd/contributors","subscribers_url":"https://api.github.com/repos/stratis-storage/stratisd/subscribers","subscription_url":"https://api.github.com/repos/stratis-storage/stratisd/subscription","commits_url":"https://api.github.com/repos/stratis-storage/stratisd/commits{/sha}","git_commits_url":"https://api.github.com/repos/stratis-storage/stratisd/git/commits{/sha}","comments_url":"https://api.github.com/repos/stratis-storage/stratisd/comments{/number}","issue_comment_url":"https://api.github.com/repos/stratis-storage/stratisd/issues/comments{/number}","contents_url":"https://api.github.com/repos/stratis-storage/stratisd/contents/{+path}","compare_url":"https://api.github.com/repos/stratis-storage/stratisd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stratis-storage/stratisd/merges","archive_url":"https://api.github.com/repos/stratis-storage/stratisd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stratis-storage/stratisd/downloads","issues_url":"https://api.github.com/repos/stratis-storage/stratisd/issues{/number}","pulls_url":"https://api.github.com/repos/stratis-storage/stratisd/pulls{/number}","milestones_url":"https://api.github.com/repos/stratis-storage/stratisd/milestones{/number}","notifications_url":"https://api.github.com/repos/stratis-storage/stratisd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stratis-storage/stratisd/labels{/name}","releases_url":"https://api.github.com/repos/stratis-storage/stratisd/releases{/id}","deployments_url":"https://api.github.com/repos/stratis-storage/stratisd/deployments","created_at":"2016-08-25T14:24:19Z","updated_at":"2016-09-14T23:16:32Z","pushed_at":"2016-10-18T19:10:03Z","git_url":"git://github.com/stratis-storage/stratisd.git","ssh_url":"git@github.com:stratis-storage/stratisd.git","clone_url":"https://github.com/stratis-storage/stratisd.git","svn_url":"https://github.com/stratis-storage/stratisd","homepage":null,"size":178,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":35,"forks":3,"open_issues":35,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stratis-storage/stratisd/pulls/94"},"html":{"href":"https://github.com/stratis-storage/stratisd/pull/94"},"issue":{"href":"https://api.github.com/repos/stratis-storage/stratisd/issues/94"},"comments":{"href":"https://api.github.com/repos/stratis-storage/stratisd/issues/94/comments"},"review_comments":{"href":"https://api.github.com/repos/stratis-storage/stratisd/pulls/94/comments"},"review_comment":{"href":"https://api.github.com/repos/stratis-storage/stratisd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stratis-storage/stratisd/pulls/94/commits"},"statuses":{"href":"https://api.github.com/repos/stratis-storage/stratisd/statuses/5ebe5a2b8593956033053ced9ac4fe1f4c66fcb5"}}}}
{"actor":{"display_login":"mulkieran"}}