{"action":"created","issue":{"url":"https://api.github.com/repos/thefactory/marathon-python/issues/82","repository_url":"https://api.github.com/repos/thefactory/marathon-python","labels_url":"https://api.github.com/repos/thefactory/marathon-python/issues/82/labels{/name}","comments_url":"https://api.github.com/repos/thefactory/marathon-python/issues/82/comments","events_url":"https://api.github.com/repos/thefactory/marathon-python/issues/82/events","html_url":"https://github.com/thefactory/marathon-python/pull/82","id":130754248,"number":82,"title":"fixes travis build matrix and tox to actually use python3","user":{"login":"jofusa","id":800669,"avatar_url":"https://avatars.githubusercontent.com/u/800669?v=3","gravatar_id":"","url":"https://api.github.com/users/jofusa","html_url":"https://github.com/jofusa","followers_url":"https://api.github.com/users/jofusa/followers","following_url":"https://api.github.com/users/jofusa/following{/other_user}","gists_url":"https://api.github.com/users/jofusa/gists{/gist_id}","starred_url":"https://api.github.com/users/jofusa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jofusa/subscriptions","organizations_url":"https://api.github.com/users/jofusa/orgs","repos_url":"https://api.github.com/users/jofusa/repos","events_url":"https://api.github.com/users/jofusa/events{/privacy}","received_events_url":"https://api.github.com/users/jofusa/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-02-02T17:28:49Z","updated_at":"2016-04-18T17:14:16Z","closed_at":"2016-04-18T17:14:16Z","pull_request":{"url":"https://api.github.com/repos/thefactory/marathon-python/pulls/82","html_url":"https://github.com/thefactory/marathon-python/pull/82","diff_url":"https://github.com/thefactory/marathon-python/pull/82.diff","patch_url":"https://github.com/thefactory/marathon-python/pull/82.patch"},"body":"Ok I took a new path. As i was digging into tests that existed there were other issues then just py3 not being tested.\r\n\r\nFirst is that while marathon versions were getting tested, the mesos version was fixed to 0.23.\r\n\r\nSome changes:\r\n- Adds a new docker fixture base class.\r\n- New pytest fixture style docker containers to setup zk, mesos master/slave and marathon.\r\n- marathon/mesos version are now pinned together in the .travis.yml\r\n- Rewrote and removed the behave BDD style tests\r\n- fixes request mocked tests for py3 (can't use fixture style decorator)"},"comment":{"url":"https://api.github.com/repos/thefactory/marathon-python/issues/comments/211481212","html_url":"https://github.com/thefactory/marathon-python/pull/82#issuecomment-211481212","issue_url":"https://api.github.com/repos/thefactory/marathon-python/issues/82","id":211481212,"user":{"login":"solarkennedy","id":370205,"avatar_url":"https://avatars.githubusercontent.com/u/370205?v=3","gravatar_id":"","url":"https://api.github.com/users/solarkennedy","html_url":"https://github.com/solarkennedy","followers_url":"https://api.github.com/users/solarkennedy/followers","following_url":"https://api.github.com/users/solarkennedy/following{/other_user}","gists_url":"https://api.github.com/users/solarkennedy/gists{/gist_id}","starred_url":"https://api.github.com/users/solarkennedy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solarkennedy/subscriptions","organizations_url":"https://api.github.com/users/solarkennedy/orgs","repos_url":"https://api.github.com/users/solarkennedy/repos","events_url":"https://api.github.com/users/solarkennedy/events{/privacy}","received_events_url":"https://api.github.com/users/solarkennedy/received_events","type":"User","site_admin":false},"created_at":"2016-04-18T17:14:16Z","updated_at":"2016-04-18T17:14:16Z","body":"First, I really appreciate your effort here. But I'm going to close this PR.\r\n\r\nIt is trying to do too many things at once. Here is a short list:\r\n* Travis matrix fixes\r\n* Initial migration of behave => pytest\r\n* Conversion to docker-compose\r\n* Makefile tox fixes\r\n\r\nIt is too much. Please try smaller changes and they will be more likely to get merged.\r\n\r\nI don't think there is enough consensus that a migration from behave => pytest is actually worth it, but the other things are. "}}