{"action":"opened","number":3509,"pull_request":{"url":"https://api.github.com/repos/PowerDNS/pdns/pulls/3509","id":61742801,"html_url":"https://github.com/PowerDNS/pdns/pull/3509","diff_url":"https://github.com/PowerDNS/pdns/pull/3509.diff","patch_url":"https://github.com/PowerDNS/pdns/pull/3509.patch","issue_url":"https://api.github.com/repos/PowerDNS/pdns/issues/3509","number":3509,"state":"open","locked":false,"title":"dnsdist: Check response validity over TCP, more cache fixes","user":{"login":"rgacogne","id":1086257,"avatar_url":"https://avatars.githubusercontent.com/u/1086257?v=3","gravatar_id":"","url":"https://api.github.com/users/rgacogne","html_url":"https://github.com/rgacogne","followers_url":"https://api.github.com/users/rgacogne/followers","following_url":"https://api.github.com/users/rgacogne/following{/other_user}","gists_url":"https://api.github.com/users/rgacogne/gists{/gist_id}","starred_url":"https://api.github.com/users/rgacogne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgacogne/subscriptions","organizations_url":"https://api.github.com/users/rgacogne/orgs","repos_url":"https://api.github.com/users/rgacogne/repos","events_url":"https://api.github.com/users/rgacogne/events{/privacy}","received_events_url":"https://api.github.com/users/rgacogne/received_events","type":"User","site_admin":false},"body":"- Add `unsetCache()` to remove the cache from a pool\r\n- Check the response size before caching it, and make no\r\nassumption when getting it from the cache\r\n- Check that the response is larger than sizeof(dnsheader) over\r\nTCP too\r\n- Check that the response matches the query over TCP too, because\r\nwe reuse downstream connections","created_at":"2016-03-04T17:19:40Z","updated_at":"2016-03-04T17:19:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PowerDNS/pdns/pulls/3509/commits","review_comments_url":"https://api.github.com/repos/PowerDNS/pdns/pulls/3509/comments","review_comment_url":"https://api.github.com/repos/PowerDNS/pdns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PowerDNS/pdns/issues/3509/comments","statuses_url":"https://api.github.com/repos/PowerDNS/pdns/statuses/f87c4aff63f32f84d8291a04bdeb887c9562613f","head":{"label":"rgacogne:dnsdist-tcp-cache","ref":"dnsdist-tcp-cache","sha":"f87c4aff63f32f84d8291a04bdeb887c9562613f","user":{"login":"rgacogne","id":1086257,"avatar_url":"https://avatars.githubusercontent.com/u/1086257?v=3","gravatar_id":"","url":"https://api.github.com/users/rgacogne","html_url":"https://github.com/rgacogne","followers_url":"https://api.github.com/users/rgacogne/followers","following_url":"https://api.github.com/users/rgacogne/following{/other_user}","gists_url":"https://api.github.com/users/rgacogne/gists{/gist_id}","starred_url":"https://api.github.com/users/rgacogne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgacogne/subscriptions","organizations_url":"https://api.github.com/users/rgacogne/orgs","repos_url":"https://api.github.com/users/rgacogne/repos","events_url":"https://api.github.com/users/rgacogne/events{/privacy}","received_events_url":"https://api.github.com/users/rgacogne/received_events","type":"User","site_admin":false},"repo":{"id":45459221,"name":"pdns","full_name":"rgacogne/pdns","owner":{"login":"rgacogne","id":1086257,"avatar_url":"https://avatars.githubusercontent.com/u/1086257?v=3","gravatar_id":"","url":"https://api.github.com/users/rgacogne","html_url":"https://github.com/rgacogne","followers_url":"https://api.github.com/users/rgacogne/followers","following_url":"https://api.github.com/users/rgacogne/following{/other_user}","gists_url":"https://api.github.com/users/rgacogne/gists{/gist_id}","starred_url":"https://api.github.com/users/rgacogne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgacogne/subscriptions","organizations_url":"https://api.github.com/users/rgacogne/orgs","repos_url":"https://api.github.com/users/rgacogne/repos","events_url":"https://api.github.com/users/rgacogne/events{/privacy}","received_events_url":"https://api.github.com/users/rgacogne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rgacogne/pdns","description":"PowerDNS","fork":true,"url":"https://api.github.com/repos/rgacogne/pdns","forks_url":"https://api.github.com/repos/rgacogne/pdns/forks","keys_url":"https://api.github.com/repos/rgacogne/pdns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rgacogne/pdns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rgacogne/pdns/teams","hooks_url":"https://api.github.com/repos/rgacogne/pdns/hooks","issue_events_url":"https://api.github.com/repos/rgacogne/pdns/issues/events{/number}","events_url":"https://api.github.com/repos/rgacogne/pdns/events","assignees_url":"https://api.github.com/repos/rgacogne/pdns/assignees{/user}","branches_url":"https://api.github.com/repos/rgacogne/pdns/branches{/branch}","tags_url":"https://api.github.com/repos/rgacogne/pdns/tags","blobs_url":"https://api.github.com/repos/rgacogne/pdns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rgacogne/pdns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rgacogne/pdns/git/refs{/sha}","trees_url":"https://api.github.com/repos/rgacogne/pdns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rgacogne/pdns/statuses/{sha}","languages_url":"https://api.github.com/repos/rgacogne/pdns/languages","stargazers_url":"https://api.github.com/repos/rgacogne/pdns/stargazers","contributors_url":"https://api.github.com/repos/rgacogne/pdns/contributors","subscribers_url":"https://api.github.com/repos/rgacogne/pdns/subscribers","subscription_url":"https://api.github.com/repos/rgacogne/pdns/subscription","commits_url":"https://api.github.com/repos/rgacogne/pdns/commits{/sha}","git_commits_url":"https://api.github.com/repos/rgacogne/pdns/git/commits{/sha}","comments_url":"https://api.github.com/repos/rgacogne/pdns/comments{/number}","issue_comment_url":"https://api.github.com/repos/rgacogne/pdns/issues/comments{/number}","contents_url":"https://api.github.com/repos/rgacogne/pdns/contents/{+path}","compare_url":"https://api.github.com/repos/rgacogne/pdns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rgacogne/pdns/merges","archive_url":"https://api.github.com/repos/rgacogne/pdns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rgacogne/pdns/downloads","issues_url":"https://api.github.com/repos/rgacogne/pdns/issues{/number}","pulls_url":"https://api.github.com/repos/rgacogne/pdns/pulls{/number}","milestones_url":"https://api.github.com/repos/rgacogne/pdns/milestones{/number}","notifications_url":"https://api.github.com/repos/rgacogne/pdns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rgacogne/pdns/labels{/name}","releases_url":"https://api.github.com/repos/rgacogne/pdns/releases{/id}","deployments_url":"https://api.github.com/repos/rgacogne/pdns/deployments","created_at":"2015-11-03T10:29:53Z","updated_at":"2016-01-11T08:35:42Z","pushed_at":"2016-03-04T17:15:56Z","git_url":"git://github.com/rgacogne/pdns.git","ssh_url":"git@github.com:rgacogne/pdns.git","clone_url":"https://github.com/rgacogne/pdns.git","svn_url":"https://github.com/rgacogne/pdns","homepage":null,"size":31518,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PowerDNS:master","ref":"master","sha":"b2eacd67313a8c9f8cb882a1025a3bfed6556d99","user":{"login":"PowerDNS","id":1282630,"avatar_url":"https://avatars.githubusercontent.com/u/1282630?v=3","gravatar_id":"","url":"https://api.github.com/users/PowerDNS","html_url":"https://github.com/PowerDNS","followers_url":"https://api.github.com/users/PowerDNS/followers","following_url":"https://api.github.com/users/PowerDNS/following{/other_user}","gists_url":"https://api.github.com/users/PowerDNS/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerDNS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerDNS/subscriptions","organizations_url":"https://api.github.com/users/PowerDNS/orgs","repos_url":"https://api.github.com/users/PowerDNS/repos","events_url":"https://api.github.com/users/PowerDNS/events{/privacy}","received_events_url":"https://api.github.com/users/PowerDNS/received_events","type":"Organization","site_admin":false},"repo":{"id":9693534,"name":"pdns","full_name":"PowerDNS/pdns","owner":{"login":"PowerDNS","id":1282630,"avatar_url":"https://avatars.githubusercontent.com/u/1282630?v=3","gravatar_id":"","url":"https://api.github.com/users/PowerDNS","html_url":"https://github.com/PowerDNS","followers_url":"https://api.github.com/users/PowerDNS/followers","following_url":"https://api.github.com/users/PowerDNS/following{/other_user}","gists_url":"https://api.github.com/users/PowerDNS/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerDNS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerDNS/subscriptions","organizations_url":"https://api.github.com/users/PowerDNS/orgs","repos_url":"https://api.github.com/users/PowerDNS/repos","events_url":"https://api.github.com/users/PowerDNS/events{/privacy}","received_events_url":"https://api.github.com/users/PowerDNS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PowerDNS/pdns","description":"PowerDNS","fork":false,"url":"https://api.github.com/repos/PowerDNS/pdns","forks_url":"https://api.github.com/repos/PowerDNS/pdns/forks","keys_url":"https://api.github.com/repos/PowerDNS/pdns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PowerDNS/pdns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PowerDNS/pdns/teams","hooks_url":"https://api.github.com/repos/PowerDNS/pdns/hooks","issue_events_url":"https://api.github.com/repos/PowerDNS/pdns/issues/events{/number}","events_url":"https://api.github.com/repos/PowerDNS/pdns/events","assignees_url":"https://api.github.com/repos/PowerDNS/pdns/assignees{/user}","branches_url":"https://api.github.com/repos/PowerDNS/pdns/branches{/branch}","tags_url":"https://api.github.com/repos/PowerDNS/pdns/tags","blobs_url":"https://api.github.com/repos/PowerDNS/pdns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PowerDNS/pdns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PowerDNS/pdns/git/refs{/sha}","trees_url":"https://api.github.com/repos/PowerDNS/pdns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PowerDNS/pdns/statuses/{sha}","languages_url":"https://api.github.com/repos/PowerDNS/pdns/languages","stargazers_url":"https://api.github.com/repos/PowerDNS/pdns/stargazers","contributors_url":"https://api.github.com/repos/PowerDNS/pdns/contributors","subscribers_url":"https://api.github.com/repos/PowerDNS/pdns/subscribers","subscription_url":"https://api.github.com/repos/PowerDNS/pdns/subscription","commits_url":"https://api.github.com/repos/PowerDNS/pdns/commits{/sha}","git_commits_url":"https://api.github.com/repos/PowerDNS/pdns/git/commits{/sha}","comments_url":"https://api.github.com/repos/PowerDNS/pdns/comments{/number}","issue_comment_url":"https://api.github.com/repos/PowerDNS/pdns/issues/comments{/number}","contents_url":"https://api.github.com/repos/PowerDNS/pdns/contents/{+path}","compare_url":"https://api.github.com/repos/PowerDNS/pdns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PowerDNS/pdns/merges","archive_url":"https://api.github.com/repos/PowerDNS/pdns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PowerDNS/pdns/downloads","issues_url":"https://api.github.com/repos/PowerDNS/pdns/issues{/number}","pulls_url":"https://api.github.com/repos/PowerDNS/pdns/pulls{/number}","milestones_url":"https://api.github.com/repos/PowerDNS/pdns/milestones{/number}","notifications_url":"https://api.github.com/repos/PowerDNS/pdns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PowerDNS/pdns/labels{/name}","releases_url":"https://api.github.com/repos/PowerDNS/pdns/releases{/id}","deployments_url":"https://api.github.com/repos/PowerDNS/pdns/deployments","created_at":"2013-04-26T11:16:49Z","updated_at":"2016-03-04T10:09:24Z","pushed_at":"2016-03-04T16:20:09Z","git_url":"git://github.com/PowerDNS/pdns.git","ssh_url":"git@github.com:PowerDNS/pdns.git","clone_url":"https://github.com/PowerDNS/pdns.git","svn_url":"https://github.com/PowerDNS/pdns","homepage":null,"size":35078,"stargazers_count":547,"watchers_count":547,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":208,"mirror_url":null,"open_issues_count":351,"forks":208,"open_issues":351,"watchers":547,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/3509"},"html":{"href":"https://github.com/PowerDNS/pdns/pull/3509"},"issue":{"href":"https://api.github.com/repos/PowerDNS/pdns/issues/3509"},"comments":{"href":"https://api.github.com/repos/PowerDNS/pdns/issues/3509/comments"},"review_comments":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/3509/comments"},"review_comment":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/3509/commits"},"statuses":{"href":"https://api.github.com/repos/PowerDNS/pdns/statuses/f87c4aff63f32f84d8291a04bdeb887c9562613f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":53,"deletions":5,"changed_files":6}}