{"action":"created","comment":{"url":"https://api.github.com/repos/heycam/webidl/pulls/comments/91585023","pull_request_review_id":12094984,"id":91585023,"diff_hunk":"@@ -4427,46 +4427,43 @@ user agent-defined value that provides human readable details of the error.\n \n There are two kinds of exceptions available to be thrown from specifications.\n The first is a <dfn id=\"dfn-simple-exception\" export>simple exception</dfn>, which\n-is identified by one of the following names:\n-\n-*   \"<dfn exception><code>Error</code></dfn>\"\n-*   \"<dfn exception><code>EvalError</code></dfn>\"\n-*   \"<dfn exception><code>RangeError</code></dfn>\"\n-*   \"<dfn exception><code>ReferenceError</code></dfn>\"\n-*   \"<dfn exception><code>TypeError</code></dfn>\"\n-*   \"<dfn exception><code>URIError</code></dfn>\"\n-\n-These correspond to all of the [=ECMAScript error objects=] (apart from\n-<emu-val>SyntaxError</emu-val>, which is deliberately omitted as\n-it is for use only by the ECMAScript parser).\n-The meaning of\n-each [=simple exception=] matches\n-its corresponding <emu-val>Error</emu-val> object in the\n+is identified by one of the following type values:\n+\n+*   <emu-val>EvalError</emu-val>\n+*   <emu-val>RangeError</emu-val>\n+*   <emu-val>ReferenceError</emu-val>\n+*   <emu-val>TypeError</emu-val>\n+*   <emu-val>URIError</emu-val>\n+\n+These correspond to all of the [=ECMAScript error objects=]\n+(apart from <emu-val>SyntaxError</emu-val> and <emu-val>Error</emu-val>,\n+which are deliberately omitted as they are reserved for use\n+by the ECMAScript parser and authors, respectively).\n+The meaning of each [=simple exception=] matches\n+its corresponding error object in the\n ECMAScript specification.\n \n The second kind of exception is a <dfn id=\"dfn-DOMException\" interface export>DOMException</dfn>,\n which is an exception that encapsulates a name and an optional integer code,\n for compatibility with historically defined exceptions in the DOM.\n \n-For [=simple exceptions=],\n-the [=error name=] is the name\n-of the exception.\n-For a {{DOMException}},\n-the [=error name=] must\n-be one of the names listed in the [=error names table=]\n-below.  The table also indicates the {{DOMException}}'s integer code\n-for that error name, if it has one.\n-\n-There are two types that can be used to refer to\n-exception objects: {{Error!!interface}}, which encompasses all exceptions,\n+For [=simple exceptions=], the [=error name=] is the name of the exception.\n+For a {{DOMException}}, the [=error name=] must be one of the names\n+listed in the [=error names table=] below.\n+The table also indicates the {{DOMException}}'s integer code for that error name,\n+if it has one.\n+\n+There are two types that can be used to refer to exception objects:\n+{{Error!!interface}}, which encompasses all exceptions,\n and {{DOMException}} which includes just DOMException objects.\n This allows for example an [=operation=]\n to be declared to have a {{DOMException}}\n [=return type=] or an [=attribute=]\n to be of type {{Error!!interface}}.\n \n-Exceptions can be <dfn id=\"dfn-create-exception\" for=\"exception\" export>created</dfn> by providing its\n-[=error name=].\n+[=Simple exceptions=] can be <dfn id=\"dfn-create-exception\" for=\"exception\" export>created</dfn>\n+by providing their [=error name=].\n+{{DOMException|DOMExceptions}}, by providing their [=error name=] followed by {{DOMException}}.","path":"index.bs","position":68,"original_position":68,"commit_id":"ab2d126df4f867f68adb1923f4bc9881527d0f8a","original_commit_id":"ab2d126df4f867f68adb1923f4bc9881527d0f8a","user":{"login":"domenic","id":617481,"avatar_url":"https://avatars.githubusercontent.com/u/617481?v=3","gravatar_id":"","url":"https://api.github.com/users/domenic","html_url":"https://github.com/domenic","followers_url":"https://api.github.com/users/domenic/followers","following_url":"https://api.github.com/users/domenic/following{/other_user}","gists_url":"https://api.github.com/users/domenic/gists{/gist_id}","starred_url":"https://api.github.com/users/domenic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domenic/subscriptions","organizations_url":"https://api.github.com/users/domenic/orgs","repos_url":"https://api.github.com/users/domenic/repos","events_url":"https://api.github.com/users/domenic/events{/privacy}","received_events_url":"https://api.github.com/users/domenic/received_events","type":"User","site_admin":false},"body":"Grammar is a bit weird. I'd say \"DOMExceptions can be created by providing...\"","created_at":"2016-12-08T19:11:37Z","updated_at":"2016-12-08T19:11:37Z","html_url":"https://github.com/heycam/webidl/pull/250#discussion_r91585023","pull_request_url":"https://api.github.com/repos/heycam/webidl/pulls/250","_links":{"self":{"href":"https://api.github.com/repos/heycam/webidl/pulls/comments/91585023"},"html":{"href":"https://github.com/heycam/webidl/pull/250#discussion_r91585023"},"pull_request":{"href":"https://api.github.com/repos/heycam/webidl/pulls/250"}}},"pull_request":{"url":"https://api.github.com/repos/heycam/webidl/pulls/250","id":97131360,"html_url":"https://github.com/heycam/webidl/pull/250","diff_url":"https://github.com/heycam/webidl/pull/250.diff","patch_url":"https://github.com/heycam/webidl/pull/250.patch","issue_url":"https://api.github.com/repos/heycam/webidl/issues/250","number":250,"state":"open","locked":false,"title":"Exception cleanup","user":{"login":"tobie","id":3392,"avatar_url":"https://avatars.githubusercontent.com/u/3392?v=3","gravatar_id":"","url":"https://api.github.com/users/tobie","html_url":"https://github.com/tobie","followers_url":"https://api.github.com/users/tobie/followers","following_url":"https://api.github.com/users/tobie/following{/other_user}","gists_url":"https://api.github.com/users/tobie/gists{/gist_id}","starred_url":"https://api.github.com/users/tobie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobie/subscriptions","organizations_url":"https://api.github.com/users/tobie/orgs","repos_url":"https://api.github.com/users/tobie/repos","events_url":"https://api.github.com/users/tobie/events{/privacy}","received_events_url":"https://api.github.com/users/tobie/received_events","type":"User","site_admin":false},"body":"* Don't define simple exception names in WebIDL.\r\n* Make Error exclusively for authors.\r\n* Fix syntax for throwing and creating DomExceptions.\r\n* Fix examples.\r\n\r\nCloses #247.\r\n\r\n**NOTE:** This doesn't address the distinction between [#throw](https://heycam.github.io/webidl/#dfn-throw) and [#ecmascript-throw](https://heycam.github.io/webidl/#ecmascript-throw), which I think needs fixing before we merge this.\r\n\r\nI'd be tempted not to export [#ecmascript-throw](https://heycam.github.io/webidl/#ecmascript-throw) and make everything use [#throw](https://heycam.github.io/webidl/#dfn-throw) instead. (Currently all simple exceptions in the spec reference [#ecmascript-throw](https://heycam.github.io/webidl/#ecmascript-throw), which I don't think is the right thing to do.)\r\nWe'd then only use the text around [#ecmascript-throw](https://heycam.github.io/webidl/#ecmascript-throw) in the bindings to describe the behavior of all exceptions (or just simple ones?) in an ES environment. Thoughts?\r\n\r\n**NOTE 2:** I opted for an `\"ExcetionName\" {{DOMException}}` syntax because it reads better, but I'm happy to switch it around if that makes more sense.\r\n\r\n\r\n<!--\r\n    This comment and the below content is programatically generated.\r\n    You may add a comma-separated list of anchors you'd like a\r\n    direct link to below (e.g. #idl-serializers, #idl-sequence):\r\n    \r\n    Don't remove this comment or modify anything below this line.\r\n    If you don't want a preview generated for this pull request,\r\n    just replace the whole of this comment's content by \"no preview\"\r\n    and remove what's below.\r\n-->\r\n***\r\n[Preview](https://cdn.rawgit.com/tobie/webidl/ab2d126/index.html) | [Diff w/ current ED](https://services.w3.org/htmldiff?doc1=https%3A%2F%2Fheycam.github.io%2Fwebidl%2F&doc2=https%3A%2F%2Fcdn.rawgit.com%2Ftobie%2Fwebidl%2Fab2d126%2Findex.html) | [Diff w/ base](https://services.w3.org/htmldiff?doc1=https%3A%2F%2Fcdn.rawgit.com%2Fheycam%2Fwebidl%2F671706d%2Findex.html&doc2=https%3A%2F%2Fcdn.rawgit.com%2Ftobie%2Fwebidl%2Fab2d126%2Findex.html)","created_at":"2016-12-08T14:27:38Z","updated_at":"2016-12-08T19:13:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b87e826be39a1fda7e1881984203cba5a393e1e5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/heycam/webidl/pulls/250/commits","review_comments_url":"https://api.github.com/repos/heycam/webidl/pulls/250/comments","review_comment_url":"https://api.github.com/repos/heycam/webidl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/heycam/webidl/issues/250/comments","statuses_url":"https://api.github.com/repos/heycam/webidl/statuses/ab2d126df4f867f68adb1923f4bc9881527d0f8a","head":{"label":"tobie:fix-247","ref":"fix-247","sha":"ab2d126df4f867f68adb1923f4bc9881527d0f8a","user":{"login":"tobie","id":3392,"avatar_url":"https://avatars.githubusercontent.com/u/3392?v=3","gravatar_id":"","url":"https://api.github.com/users/tobie","html_url":"https://github.com/tobie","followers_url":"https://api.github.com/users/tobie/followers","following_url":"https://api.github.com/users/tobie/following{/other_user}","gists_url":"https://api.github.com/users/tobie/gists{/gist_id}","starred_url":"https://api.github.com/users/tobie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobie/subscriptions","organizations_url":"https://api.github.com/users/tobie/orgs","repos_url":"https://api.github.com/users/tobie/repos","events_url":"https://api.github.com/users/tobie/events{/privacy}","received_events_url":"https://api.github.com/users/tobie/received_events","type":"User","site_admin":false},"repo":{"id":60836489,"name":"webidl","full_name":"tobie/webidl","owner":{"login":"tobie","id":3392,"avatar_url":"https://avatars.githubusercontent.com/u/3392?v=3","gravatar_id":"","url":"https://api.github.com/users/tobie","html_url":"https://github.com/tobie","followers_url":"https://api.github.com/users/tobie/followers","following_url":"https://api.github.com/users/tobie/following{/other_user}","gists_url":"https://api.github.com/users/tobie/gists{/gist_id}","starred_url":"https://api.github.com/users/tobie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobie/subscriptions","organizations_url":"https://api.github.com/users/tobie/orgs","repos_url":"https://api.github.com/users/tobie/repos","events_url":"https://api.github.com/users/tobie/events{/privacy}","received_events_url":"https://api.github.com/users/tobie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tobie/webidl","description":null,"fork":true,"url":"https://api.github.com/repos/tobie/webidl","forks_url":"https://api.github.com/repos/tobie/webidl/forks","keys_url":"https://api.github.com/repos/tobie/webidl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tobie/webidl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tobie/webidl/teams","hooks_url":"https://api.github.com/repos/tobie/webidl/hooks","issue_events_url":"https://api.github.com/repos/tobie/webidl/issues/events{/number}","events_url":"https://api.github.com/repos/tobie/webidl/events","assignees_url":"https://api.github.com/repos/tobie/webidl/assignees{/user}","branches_url":"https://api.github.com/repos/tobie/webidl/branches{/branch}","tags_url":"https://api.github.com/repos/tobie/webidl/tags","blobs_url":"https://api.github.com/repos/tobie/webidl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tobie/webidl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tobie/webidl/git/refs{/sha}","trees_url":"https://api.github.com/repos/tobie/webidl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tobie/webidl/statuses/{sha}","languages_url":"https://api.github.com/repos/tobie/webidl/languages","stargazers_url":"https://api.github.com/repos/tobie/webidl/stargazers","contributors_url":"https://api.github.com/repos/tobie/webidl/contributors","subscribers_url":"https://api.github.com/repos/tobie/webidl/subscribers","subscription_url":"https://api.github.com/repos/tobie/webidl/subscription","commits_url":"https://api.github.com/repos/tobie/webidl/commits{/sha}","git_commits_url":"https://api.github.com/repos/tobie/webidl/git/commits{/sha}","comments_url":"https://api.github.com/repos/tobie/webidl/comments{/number}","issue_comment_url":"https://api.github.com/repos/tobie/webidl/issues/comments{/number}","contents_url":"https://api.github.com/repos/tobie/webidl/contents/{+path}","compare_url":"https://api.github.com/repos/tobie/webidl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tobie/webidl/merges","archive_url":"https://api.github.com/repos/tobie/webidl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tobie/webidl/downloads","issues_url":"https://api.github.com/repos/tobie/webidl/issues{/number}","pulls_url":"https://api.github.com/repos/tobie/webidl/pulls{/number}","milestones_url":"https://api.github.com/repos/tobie/webidl/milestones{/number}","notifications_url":"https://api.github.com/repos/tobie/webidl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tobie/webidl/labels{/name}","releases_url":"https://api.github.com/repos/tobie/webidl/releases{/id}","deployments_url":"https://api.github.com/repos/tobie/webidl/deployments","created_at":"2016-06-10T09:16:53Z","updated_at":"2016-07-08T13:19:18Z","pushed_at":"2016-12-08T16:37:59Z","git_url":"git://github.com/tobie/webidl.git","ssh_url":"git@github.com:tobie/webidl.git","clone_url":"https://github.com/tobie/webidl.git","svn_url":"https://github.com/tobie/webidl","homepage":null,"size":23543,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"bs-conversion-3"}},"base":{"label":"heycam:gh-pages","ref":"gh-pages","sha":"671706df92e2cece78d747c1db73fbf863e7ec86","user":{"login":"heycam","id":1484434,"avatar_url":"https://avatars.githubusercontent.com/u/1484434?v=3","gravatar_id":"","url":"https://api.github.com/users/heycam","html_url":"https://github.com/heycam","followers_url":"https://api.github.com/users/heycam/followers","following_url":"https://api.github.com/users/heycam/following{/other_user}","gists_url":"https://api.github.com/users/heycam/gists{/gist_id}","starred_url":"https://api.github.com/users/heycam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heycam/subscriptions","organizations_url":"https://api.github.com/users/heycam/orgs","repos_url":"https://api.github.com/users/heycam/repos","events_url":"https://api.github.com/users/heycam/events{/privacy}","received_events_url":"https://api.github.com/users/heycam/received_events","type":"User","site_admin":false},"repo":{"id":14131914,"name":"webidl","full_name":"heycam/webidl","owner":{"login":"heycam","id":1484434,"avatar_url":"https://avatars.githubusercontent.com/u/1484434?v=3","gravatar_id":"","url":"https://api.github.com/users/heycam","html_url":"https://github.com/heycam","followers_url":"https://api.github.com/users/heycam/followers","following_url":"https://api.github.com/users/heycam/following{/other_user}","gists_url":"https://api.github.com/users/heycam/gists{/gist_id}","starred_url":"https://api.github.com/users/heycam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heycam/subscriptions","organizations_url":"https://api.github.com/users/heycam/orgs","repos_url":"https://api.github.com/users/heycam/repos","events_url":"https://api.github.com/users/heycam/events{/privacy}","received_events_url":"https://api.github.com/users/heycam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/heycam/webidl","description":null,"fork":false,"url":"https://api.github.com/repos/heycam/webidl","forks_url":"https://api.github.com/repos/heycam/webidl/forks","keys_url":"https://api.github.com/repos/heycam/webidl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heycam/webidl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heycam/webidl/teams","hooks_url":"https://api.github.com/repos/heycam/webidl/hooks","issue_events_url":"https://api.github.com/repos/heycam/webidl/issues/events{/number}","events_url":"https://api.github.com/repos/heycam/webidl/events","assignees_url":"https://api.github.com/repos/heycam/webidl/assignees{/user}","branches_url":"https://api.github.com/repos/heycam/webidl/branches{/branch}","tags_url":"https://api.github.com/repos/heycam/webidl/tags","blobs_url":"https://api.github.com/repos/heycam/webidl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heycam/webidl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heycam/webidl/git/refs{/sha}","trees_url":"https://api.github.com/repos/heycam/webidl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heycam/webidl/statuses/{sha}","languages_url":"https://api.github.com/repos/heycam/webidl/languages","stargazers_url":"https://api.github.com/repos/heycam/webidl/stargazers","contributors_url":"https://api.github.com/repos/heycam/webidl/contributors","subscribers_url":"https://api.github.com/repos/heycam/webidl/subscribers","subscription_url":"https://api.github.com/repos/heycam/webidl/subscription","commits_url":"https://api.github.com/repos/heycam/webidl/commits{/sha}","git_commits_url":"https://api.github.com/repos/heycam/webidl/git/commits{/sha}","comments_url":"https://api.github.com/repos/heycam/webidl/comments{/number}","issue_comment_url":"https://api.github.com/repos/heycam/webidl/issues/comments{/number}","contents_url":"https://api.github.com/repos/heycam/webidl/contents/{+path}","compare_url":"https://api.github.com/repos/heycam/webidl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heycam/webidl/merges","archive_url":"https://api.github.com/repos/heycam/webidl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heycam/webidl/downloads","issues_url":"https://api.github.com/repos/heycam/webidl/issues{/number}","pulls_url":"https://api.github.com/repos/heycam/webidl/pulls{/number}","milestones_url":"https://api.github.com/repos/heycam/webidl/milestones{/number}","notifications_url":"https://api.github.com/repos/heycam/webidl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heycam/webidl/labels{/name}","releases_url":"https://api.github.com/repos/heycam/webidl/releases{/id}","deployments_url":"https://api.github.com/repos/heycam/webidl/deployments","created_at":"2013-11-05T04:17:09Z","updated_at":"2016-10-29T06:52:54Z","pushed_at":"2016-12-08T16:37:59Z","git_url":"git://github.com/heycam/webidl.git","ssh_url":"git@github.com:heycam/webidl.git","clone_url":"https://github.com/heycam/webidl.git","svn_url":"https://github.com/heycam/webidl","homepage":null,"size":18477,"stargazers_count":29,"watchers_count":29,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":30,"mirror_url":null,"open_issues_count":72,"forks":30,"open_issues":72,"watchers":29,"default_branch":"gh-pages"}},"_links":{"self":{"href":"https://api.github.com/repos/heycam/webidl/pulls/250"},"html":{"href":"https://github.com/heycam/webidl/pull/250"},"issue":{"href":"https://api.github.com/repos/heycam/webidl/issues/250"},"comments":{"href":"https://api.github.com/repos/heycam/webidl/issues/250/comments"},"review_comments":{"href":"https://api.github.com/repos/heycam/webidl/pulls/250/comments"},"review_comment":{"href":"https://api.github.com/repos/heycam/webidl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/heycam/webidl/pulls/250/commits"},"statuses":{"href":"https://api.github.com/repos/heycam/webidl/statuses/ab2d126df4f867f68adb1923f4bc9881527d0f8a"}}}}
{"actor":{"display_login":"domenic"}}