{"action":"closed","number":26,"pull_request":{"url":"https://api.github.com/repos/uglybugger/ConfigInjector/pulls/26","id":71016504,"html_url":"https://github.com/uglybugger/ConfigInjector/pull/26","diff_url":"https://github.com/uglybugger/ConfigInjector/pull/26.diff","patch_url":"https://github.com/uglybugger/ConfigInjector/pull/26.patch","issue_url":"https://api.github.com/repos/uglybugger/ConfigInjector/issues/26","number":26,"state":"closed","locked":false,"title":"Sensitive logging","user":{"login":"Craigology","id":950630,"avatar_url":"https://avatars.githubusercontent.com/u/950630?v=3","gravatar_id":"","url":"https://api.github.com/users/Craigology","html_url":"https://github.com/Craigology","followers_url":"https://api.github.com/users/Craigology/followers","following_url":"https://api.github.com/users/Craigology/following{/other_user}","gists_url":"https://api.github.com/users/Craigology/gists{/gist_id}","starred_url":"https://api.github.com/users/Craigology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Craigology/subscriptions","organizations_url":"https://api.github.com/users/Craigology/orgs","repos_url":"https://api.github.com/users/Craigology/repos","events_url":"https://api.github.com/users/Craigology/events{/privacy}","received_events_url":"https://api.github.com/users/Craigology/received_events","type":"User","site_admin":false},"body":"Hey Andrew.\r\nAs discussed, have had a stab at making the log output that `SettingsRegistrationService` produces after parsing a setting and determining if overridden respect the `IsSensitive`/`SanitizedValue` properties. I needed to instantiate the settings object before logging in order to do this, and also needed to pull the `IsSensitive` property up into the `IConfigurationSetting` interface. Let me know your feelings on this. I have added new unit tests that confirm the expected presence/absence of a sanitized setting with/without a value override.\r\nCheers,\r\nCraig.","created_at":"2016-05-23T07:39:03Z","updated_at":"2016-09-06T09:48:10Z","closed_at":"2016-09-06T09:48:09Z","merged_at":"2016-09-06T09:48:09Z","merge_commit_sha":"e82356eddc7db026e11f1a5b46ea1794f6aa9336","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/uglybugger/ConfigInjector/pulls/26/commits","review_comments_url":"https://api.github.com/repos/uglybugger/ConfigInjector/pulls/26/comments","review_comment_url":"https://api.github.com/repos/uglybugger/ConfigInjector/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uglybugger/ConfigInjector/issues/26/comments","statuses_url":"https://api.github.com/repos/uglybugger/ConfigInjector/statuses/e82356eddc7db026e11f1a5b46ea1794f6aa9336","head":{"label":"Craigology:sensitive-logging","ref":"sensitive-logging","sha":"e82356eddc7db026e11f1a5b46ea1794f6aa9336","user":{"login":"Craigology","id":950630,"avatar_url":"https://avatars.githubusercontent.com/u/950630?v=3","gravatar_id":"","url":"https://api.github.com/users/Craigology","html_url":"https://github.com/Craigology","followers_url":"https://api.github.com/users/Craigology/followers","following_url":"https://api.github.com/users/Craigology/following{/other_user}","gists_url":"https://api.github.com/users/Craigology/gists{/gist_id}","starred_url":"https://api.github.com/users/Craigology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Craigology/subscriptions","organizations_url":"https://api.github.com/users/Craigology/orgs","repos_url":"https://api.github.com/users/Craigology/repos","events_url":"https://api.github.com/users/Craigology/events{/privacy}","received_events_url":"https://api.github.com/users/Craigology/received_events","type":"User","site_admin":false},"repo":{"id":59271063,"name":"ConfigInjector","full_name":"Craigology/ConfigInjector","owner":{"login":"Craigology","id":950630,"avatar_url":"https://avatars.githubusercontent.com/u/950630?v=3","gravatar_id":"","url":"https://api.github.com/users/Craigology","html_url":"https://github.com/Craigology","followers_url":"https://api.github.com/users/Craigology/followers","following_url":"https://api.github.com/users/Craigology/following{/other_user}","gists_url":"https://api.github.com/users/Craigology/gists{/gist_id}","starred_url":"https://api.github.com/users/Craigology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Craigology/subscriptions","organizations_url":"https://api.github.com/users/Craigology/orgs","repos_url":"https://api.github.com/users/Craigology/repos","events_url":"https://api.github.com/users/Craigology/events{/privacy}","received_events_url":"https://api.github.com/users/Craigology/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Craigology/ConfigInjector","description":"A simple way to inject strongly-typed configuration settings into your application via [web|app].config.","fork":true,"url":"https://api.github.com/repos/Craigology/ConfigInjector","forks_url":"https://api.github.com/repos/Craigology/ConfigInjector/forks","keys_url":"https://api.github.com/repos/Craigology/ConfigInjector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Craigology/ConfigInjector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Craigology/ConfigInjector/teams","hooks_url":"https://api.github.com/repos/Craigology/ConfigInjector/hooks","issue_events_url":"https://api.github.com/repos/Craigology/ConfigInjector/issues/events{/number}","events_url":"https://api.github.com/repos/Craigology/ConfigInjector/events","assignees_url":"https://api.github.com/repos/Craigology/ConfigInjector/assignees{/user}","branches_url":"https://api.github.com/repos/Craigology/ConfigInjector/branches{/branch}","tags_url":"https://api.github.com/repos/Craigology/ConfigInjector/tags","blobs_url":"https://api.github.com/repos/Craigology/ConfigInjector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Craigology/ConfigInjector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Craigology/ConfigInjector/git/refs{/sha}","trees_url":"https://api.github.com/repos/Craigology/ConfigInjector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Craigology/ConfigInjector/statuses/{sha}","languages_url":"https://api.github.com/repos/Craigology/ConfigInjector/languages","stargazers_url":"https://api.github.com/repos/Craigology/ConfigInjector/stargazers","contributors_url":"https://api.github.com/repos/Craigology/ConfigInjector/contributors","subscribers_url":"https://api.github.com/repos/Craigology/ConfigInjector/subscribers","subscription_url":"https://api.github.com/repos/Craigology/ConfigInjector/subscription","commits_url":"https://api.github.com/repos/Craigology/ConfigInjector/commits{/sha}","git_commits_url":"https://api.github.com/repos/Craigology/ConfigInjector/git/commits{/sha}","comments_url":"https://api.github.com/repos/Craigology/ConfigInjector/comments{/number}","issue_comment_url":"https://api.github.com/repos/Craigology/ConfigInjector/issues/comments{/number}","contents_url":"https://api.github.com/repos/Craigology/ConfigInjector/contents/{+path}","compare_url":"https://api.github.com/repos/Craigology/ConfigInjector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Craigology/ConfigInjector/merges","archive_url":"https://api.github.com/repos/Craigology/ConfigInjector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Craigology/ConfigInjector/downloads","issues_url":"https://api.github.com/repos/Craigology/ConfigInjector/issues{/number}","pulls_url":"https://api.github.com/repos/Craigology/ConfigInjector/pulls{/number}","milestones_url":"https://api.github.com/repos/Craigology/ConfigInjector/milestones{/number}","notifications_url":"https://api.github.com/repos/Craigology/ConfigInjector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Craigology/ConfigInjector/labels{/name}","releases_url":"https://api.github.com/repos/Craigology/ConfigInjector/releases{/id}","deployments_url":"https://api.github.com/repos/Craigology/ConfigInjector/deployments","created_at":"2016-05-20T06:37:45Z","updated_at":"2016-05-20T06:37:46Z","pushed_at":"2016-05-23T07:30:05Z","git_url":"git://github.com/Craigology/ConfigInjector.git","ssh_url":"git@github.com:Craigology/ConfigInjector.git","clone_url":"https://github.com/Craigology/ConfigInjector.git","svn_url":"https://github.com/Craigology/ConfigInjector","homepage":"https://www.nuget.org/packages/ConfigInjector/","size":6584,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"uglybugger:master","ref":"master","sha":"4173364de843b745981b1b7538a7ead022333476","user":{"login":"uglybugger","id":375332,"avatar_url":"https://avatars.githubusercontent.com/u/375332?v=3","gravatar_id":"","url":"https://api.github.com/users/uglybugger","html_url":"https://github.com/uglybugger","followers_url":"https://api.github.com/users/uglybugger/followers","following_url":"https://api.github.com/users/uglybugger/following{/other_user}","gists_url":"https://api.github.com/users/uglybugger/gists{/gist_id}","starred_url":"https://api.github.com/users/uglybugger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uglybugger/subscriptions","organizations_url":"https://api.github.com/users/uglybugger/orgs","repos_url":"https://api.github.com/users/uglybugger/repos","events_url":"https://api.github.com/users/uglybugger/events{/privacy}","received_events_url":"https://api.github.com/users/uglybugger/received_events","type":"User","site_admin":false},"repo":{"id":13294171,"name":"ConfigInjector","full_name":"uglybugger/ConfigInjector","owner":{"login":"uglybugger","id":375332,"avatar_url":"https://avatars.githubusercontent.com/u/375332?v=3","gravatar_id":"","url":"https://api.github.com/users/uglybugger","html_url":"https://github.com/uglybugger","followers_url":"https://api.github.com/users/uglybugger/followers","following_url":"https://api.github.com/users/uglybugger/following{/other_user}","gists_url":"https://api.github.com/users/uglybugger/gists{/gist_id}","starred_url":"https://api.github.com/users/uglybugger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uglybugger/subscriptions","organizations_url":"https://api.github.com/users/uglybugger/orgs","repos_url":"https://api.github.com/users/uglybugger/repos","events_url":"https://api.github.com/users/uglybugger/events{/privacy}","received_events_url":"https://api.github.com/users/uglybugger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/uglybugger/ConfigInjector","description":"A simple way to inject strongly-typed configuration settings into your application via [web|app].config.","fork":false,"url":"https://api.github.com/repos/uglybugger/ConfigInjector","forks_url":"https://api.github.com/repos/uglybugger/ConfigInjector/forks","keys_url":"https://api.github.com/repos/uglybugger/ConfigInjector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uglybugger/ConfigInjector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uglybugger/ConfigInjector/teams","hooks_url":"https://api.github.com/repos/uglybugger/ConfigInjector/hooks","issue_events_url":"https://api.github.com/repos/uglybugger/ConfigInjector/issues/events{/number}","events_url":"https://api.github.com/repos/uglybugger/ConfigInjector/events","assignees_url":"https://api.github.com/repos/uglybugger/ConfigInjector/assignees{/user}","branches_url":"https://api.github.com/repos/uglybugger/ConfigInjector/branches{/branch}","tags_url":"https://api.github.com/repos/uglybugger/ConfigInjector/tags","blobs_url":"https://api.github.com/repos/uglybugger/ConfigInjector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uglybugger/ConfigInjector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uglybugger/ConfigInjector/git/refs{/sha}","trees_url":"https://api.github.com/repos/uglybugger/ConfigInjector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uglybugger/ConfigInjector/statuses/{sha}","languages_url":"https://api.github.com/repos/uglybugger/ConfigInjector/languages","stargazers_url":"https://api.github.com/repos/uglybugger/ConfigInjector/stargazers","contributors_url":"https://api.github.com/repos/uglybugger/ConfigInjector/contributors","subscribers_url":"https://api.github.com/repos/uglybugger/ConfigInjector/subscribers","subscription_url":"https://api.github.com/repos/uglybugger/ConfigInjector/subscription","commits_url":"https://api.github.com/repos/uglybugger/ConfigInjector/commits{/sha}","git_commits_url":"https://api.github.com/repos/uglybugger/ConfigInjector/git/commits{/sha}","comments_url":"https://api.github.com/repos/uglybugger/ConfigInjector/comments{/number}","issue_comment_url":"https://api.github.com/repos/uglybugger/ConfigInjector/issues/comments{/number}","contents_url":"https://api.github.com/repos/uglybugger/ConfigInjector/contents/{+path}","compare_url":"https://api.github.com/repos/uglybugger/ConfigInjector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uglybugger/ConfigInjector/merges","archive_url":"https://api.github.com/repos/uglybugger/ConfigInjector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uglybugger/ConfigInjector/downloads","issues_url":"https://api.github.com/repos/uglybugger/ConfigInjector/issues{/number}","pulls_url":"https://api.github.com/repos/uglybugger/ConfigInjector/pulls{/number}","milestones_url":"https://api.github.com/repos/uglybugger/ConfigInjector/milestones{/number}","notifications_url":"https://api.github.com/repos/uglybugger/ConfigInjector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uglybugger/ConfigInjector/labels{/name}","releases_url":"https://api.github.com/repos/uglybugger/ConfigInjector/releases{/id}","deployments_url":"https://api.github.com/repos/uglybugger/ConfigInjector/deployments","created_at":"2013-10-03T08:51:41Z","updated_at":"2016-09-05T01:35:25Z","pushed_at":"2016-09-06T09:48:09Z","git_url":"git://github.com/uglybugger/ConfigInjector.git","ssh_url":"git@github.com:uglybugger/ConfigInjector.git","clone_url":"https://github.com/uglybugger/ConfigInjector.git","svn_url":"https://github.com/uglybugger/ConfigInjector","homepage":"https://www.nuget.org/packages/ConfigInjector/","size":6628,"stargazers_count":36,"watchers_count":36,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":3,"forks":12,"open_issues":3,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uglybugger/ConfigInjector/pulls/26"},"html":{"href":"https://github.com/uglybugger/ConfigInjector/pull/26"},"issue":{"href":"https://api.github.com/repos/uglybugger/ConfigInjector/issues/26"},"comments":{"href":"https://api.github.com/repos/uglybugger/ConfigInjector/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/uglybugger/ConfigInjector/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/uglybugger/ConfigInjector/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uglybugger/ConfigInjector/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/uglybugger/ConfigInjector/statuses/e82356eddc7db026e11f1a5b46ea1794f6aa9336"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"uglybugger","id":375332,"avatar_url":"https://avatars.githubusercontent.com/u/375332?v=3","gravatar_id":"","url":"https://api.github.com/users/uglybugger","html_url":"https://github.com/uglybugger","followers_url":"https://api.github.com/users/uglybugger/followers","following_url":"https://api.github.com/users/uglybugger/following{/other_user}","gists_url":"https://api.github.com/users/uglybugger/gists{/gist_id}","starred_url":"https://api.github.com/users/uglybugger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uglybugger/subscriptions","organizations_url":"https://api.github.com/users/uglybugger/orgs","repos_url":"https://api.github.com/users/uglybugger/repos","events_url":"https://api.github.com/users/uglybugger/events{/privacy}","received_events_url":"https://api.github.com/users/uglybugger/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":3,"additions":260,"deletions":9,"changed_files":6}}
{"actor":{"display_login":"uglybugger"}}