{"action":"created","issue":{"url":"https://api.github.com/repos/ldc-developers/ldc/issues/1686","repository_url":"https://api.github.com/repos/ldc-developers/ldc","labels_url":"https://api.github.com/repos/ldc-developers/ldc/issues/1686/labels{/name}","comments_url":"https://api.github.com/repos/ldc-developers/ldc/issues/1686/comments","events_url":"https://api.github.com/repos/ldc-developers/ldc/issues/1686/events","html_url":"https://github.com/ldc-developers/ldc/issues/1686","id":171067438,"number":1686,"title":"Test dlang/phobos with LDC","user":{"login":"wilzbach","id":4370550,"avatar_url":"https://avatars.githubusercontent.com/u/4370550?v=3","gravatar_id":"","url":"https://api.github.com/users/wilzbach","html_url":"https://github.com/wilzbach","followers_url":"https://api.github.com/users/wilzbach/followers","following_url":"https://api.github.com/users/wilzbach/following{/other_user}","gists_url":"https://api.github.com/users/wilzbach/gists{/gist_id}","starred_url":"https://api.github.com/users/wilzbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilzbach/subscriptions","organizations_url":"https://api.github.com/users/wilzbach/orgs","repos_url":"https://api.github.com/users/wilzbach/repos","events_url":"https://api.github.com/users/wilzbach/events{/privacy}","received_events_url":"https://api.github.com/users/wilzbach/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-14T16:50:29Z","updated_at":"2016-08-14T17:17:42Z","closed_at":null,"body":"As you all know contributors at Phobos silently broke LDC by checking in new, fancy changes. Now that we have an easy to adapt CI in place, we should be able to tackle this problem and warn the reviewers. Doing this is simply one more job in the queue and I think no one will bother if it doesn't break all the time, so the crucial thing here is to get it right from the beginning, s.t. people don't complain.\r\n\r\nI have played a bit around with your build setup and everything seems straight-forward, except for the most-important bit: merging dlang/phobos with ldc-developers/phobos\r\n\r\nWhy is this so problematic?\r\nWith \"342 commits ahead\" merge conflict arise pretty quickly (with master there are currently five files conflicting) and a CI can't auto-resolve those conflicts intelligently.\r\n\r\nSo imho the only way we can make this happen is cutting down all the modifications and in the best case moving all modifications over to dlang/phobos and dropping the repo.\r\n\r\nWhat's your opinion on this?\r\n\r\nFor the time being we could also just run the LDC test-suite at Phobos, but always return 0 and send a message to a mailing list. However I am not sure whether that's worth it then :7"},"comment":{"url":"https://api.github.com/repos/ldc-developers/ldc/issues/comments/239685105","html_url":"https://github.com/ldc-developers/ldc/issues/1686#issuecomment-239685105","issue_url":"https://api.github.com/repos/ldc-developers/ldc/issues/1686","id":239685105,"user":{"login":"klickverbot","id":19335,"avatar_url":"https://avatars.githubusercontent.com/u/19335?v=3","gravatar_id":"","url":"https://api.github.com/users/klickverbot","html_url":"https://github.com/klickverbot","followers_url":"https://api.github.com/users/klickverbot/followers","following_url":"https://api.github.com/users/klickverbot/following{/other_user}","gists_url":"https://api.github.com/users/klickverbot/gists{/gist_id}","starred_url":"https://api.github.com/users/klickverbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klickverbot/subscriptions","organizations_url":"https://api.github.com/users/klickverbot/orgs","repos_url":"https://api.github.com/users/klickverbot/repos","events_url":"https://api.github.com/users/klickverbot/events{/privacy}","received_events_url":"https://api.github.com/users/klickverbot/received_events","type":"User","site_admin":false},"created_at":"2016-08-14T17:17:42Z","updated_at":"2016-08-14T17:17:42Z","body":"As fas as Phobos in particular goes: 342 commits sounds much worse than the situation actually is, since our fork has existed for quite some time. The actual diff is quite manageable, and mostly consist of back-ported upstream fixed that are absolutely required for LDC, and some code for platforms not supported upstream.\r\n\r\nIdeally, we'd just include the upstream repository as a submodule. The first barrier is of course to get commit access for all the all the LDC devs, etc. But working that situation out would only get us to having an LDC branch in dlang/phobos. Directly using master is illusionary as long as the projects aren't completely in sync."}}
{"actor":{"display_login":"klickverbot"}}