{"action":"created","issue":{"url":"https://api.github.com/repos/eclipse/kura/issues/331","repository_url":"https://api.github.com/repos/eclipse/kura","labels_url":"https://api.github.com/repos/eclipse/kura/issues/331/labels{/name}","comments_url":"https://api.github.com/repos/eclipse/kura/issues/331/comments","events_url":"https://api.github.com/repos/eclipse/kura/issues/331/events","html_url":"https://github.com/eclipse/kura/pull/331","id":165780425,"number":331,"title":"Fix concurrency issue in command service","user":{"login":"ctron","id":202474,"avatar_url":"https://avatars.githubusercontent.com/u/202474?v=3","gravatar_id":"","url":"https://api.github.com/users/ctron","html_url":"https://github.com/ctron","followers_url":"https://api.github.com/users/ctron/followers","following_url":"https://api.github.com/users/ctron/following{/other_user}","gists_url":"https://api.github.com/users/ctron/gists{/gist_id}","starred_url":"https://api.github.com/users/ctron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctron/subscriptions","organizations_url":"https://api.github.com/users/ctron/orgs","repos_url":"https://api.github.com/users/ctron/repos","events_url":"https://api.github.com/users/ctron/events{/privacy}","received_events_url":"https://api.github.com/users/ctron/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-07-15T12:53:45Z","updated_at":"2016-08-02T11:01:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/eclipse/kura/pulls/331","html_url":"https://github.com/eclipse/kura/pull/331","diff_url":"https://github.com/eclipse/kura/pull/331.diff","patch_url":"https://github.com/eclipse/kura/pull/331.patch"},"body":"The command service was implemented in a way that it did execute all\r\ncommand written out to a single shell script. This can cause the issue\r\nthat two requests issued at the same time would fail.\r\n\r\nThis change does write out seperate script files using the\r\nFiles.createTempFile method. It also does not fork \"chmod\" and\r\n\"dos2unix\" since those operations can be performed inside Java which\r\nsaves two additional process forks.\r\n\r\nAlso is the \"cd\" statement not necessary when the ProcessBuilder\r\nis instructed to change the directory first. For this the process\r\nstarted can now accept an optional working directory.\r\n\r\nThis change also includes a unit test for the command service.\r\n\r\nSigned-off-by: Jens Reimann <jreimann@redhat.com>"},"comment":{"url":"https://api.github.com/repos/eclipse/kura/issues/comments/236872244","html_url":"https://github.com/eclipse/kura/pull/331#issuecomment-236872244","issue_url":"https://api.github.com/repos/eclipse/kura/issues/331","id":236872244,"user":{"login":"hekonsek","id":822903,"avatar_url":"https://avatars.githubusercontent.com/u/822903?v=3","gravatar_id":"","url":"https://api.github.com/users/hekonsek","html_url":"https://github.com/hekonsek","followers_url":"https://api.github.com/users/hekonsek/followers","following_url":"https://api.github.com/users/hekonsek/following{/other_user}","gists_url":"https://api.github.com/users/hekonsek/gists{/gist_id}","starred_url":"https://api.github.com/users/hekonsek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hekonsek/subscriptions","organizations_url":"https://api.github.com/users/hekonsek/orgs","repos_url":"https://api.github.com/users/hekonsek/repos","events_url":"https://api.github.com/users/hekonsek/events{/privacy}","received_events_url":"https://api.github.com/users/hekonsek/received_events","type":"User","site_admin":false},"created_at":"2016-08-02T11:01:14Z","updated_at":"2016-08-02T11:01:14Z","body":"Jens, I propose to downgrade this pull request to use Java 6 for a while. When are are done with Java 7 upgrade, then we could create an another PR to make this code more Java 7 friendly.\r\n\r\nIs that OK?"}}
{"actor":{"display_login":"hekonsek"}}