{"action":"created","issue":{"url":"https://api.github.com/repos/docker/swarmkit/issues/1618","repository_url":"https://api.github.com/repos/docker/swarmkit","labels_url":"https://api.github.com/repos/docker/swarmkit/issues/1618/labels{/name}","comments_url":"https://api.github.com/repos/docker/swarmkit/issues/1618/comments","events_url":"https://api.github.com/repos/docker/swarmkit/issues/1618/events","html_url":"https://github.com/docker/swarmkit/pull/1618","id":182407017,"number":1618,"title":"ca: Retry certificate issuance on non-fatal errors","user":{"login":"aaronlehmann","id":10601430,"avatar_url":"https://avatars.githubusercontent.com/u/10601430?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronlehmann","html_url":"https://github.com/aaronlehmann","followers_url":"https://api.github.com/users/aaronlehmann/followers","following_url":"https://api.github.com/users/aaronlehmann/following{/other_user}","gists_url":"https://api.github.com/users/aaronlehmann/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronlehmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronlehmann/subscriptions","organizations_url":"https://api.github.com/users/aaronlehmann/orgs","repos_url":"https://api.github.com/users/aaronlehmann/repos","events_url":"https://api.github.com/users/aaronlehmann/events{/privacy}","received_events_url":"https://api.github.com/users/aaronlehmann/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/swarmkit/labels/status/0-triage","name":"status/0-triage","color":"ededed"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-10-12T00:29:35Z","updated_at":"2016-10-12T17:11:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/swarmkit/pulls/1618","html_url":"https://github.com/docker/swarmkit/pull/1618","diff_url":"https://github.com/docker/swarmkit/pull/1618.diff","patch_url":"https://github.com/docker/swarmkit/pull/1618.patch"},"body":"When there is no signer, or when using an external CA that's\r\nunreachable or not responding properly, add the node to a list of\r\npending certificate requests. Every 10 seconds, run through this list\r\nand try to issue the certificates again.\r\n\r\nFixes #1596\r\n\r\ncc @alexmavr @diogomonica"},"comment":{"url":"https://api.github.com/repos/docker/swarmkit/issues/comments/253276484","html_url":"https://github.com/docker/swarmkit/pull/1618#issuecomment-253276484","issue_url":"https://api.github.com/repos/docker/swarmkit/issues/1618","id":253276484,"user":{"login":"aaronlehmann","id":10601430,"avatar_url":"https://avatars.githubusercontent.com/u/10601430?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronlehmann","html_url":"https://github.com/aaronlehmann","followers_url":"https://api.github.com/users/aaronlehmann/followers","following_url":"https://api.github.com/users/aaronlehmann/following{/other_user}","gists_url":"https://api.github.com/users/aaronlehmann/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronlehmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronlehmann/subscriptions","organizations_url":"https://api.github.com/users/aaronlehmann/orgs","repos_url":"https://api.github.com/users/aaronlehmann/repos","events_url":"https://api.github.com/users/aaronlehmann/events{/privacy}","received_events_url":"https://api.github.com/users/aaronlehmann/received_events","type":"User","site_admin":false},"created_at":"2016-10-12T17:11:36Z","updated_at":"2016-10-12T17:11:36Z","body":"@jlhawn: Thanks for pointing that out - that definitely looks wrong. I can't think of any reason to back off on \"failed\". We should probably open a separate PR to deal with that. Do you want to open one?\r\n\r\nRelated to this, I am having a discussion today about Docker CLI behavior on join. The current model is not fully synchronous or asynchronous, and this concerns me. `docker swarm join` waits for the certificate to be issued, and if it is not issued before a timeout, it shows an error to the user, but keeps waiting for certificate issuance in the background. I think it may be clearer to either give up after the timeout, or make `docker swarm join` a fully asynchronous command. Let me know if you'd like to join this discussion."}}
{"actor":{"display_login":"aaronlehmann"}}