{"action":"created","issue":{"url":"https://api.github.com/repos/ngrunwald/datasplash/issues/7","repository_url":"https://api.github.com/repos/ngrunwald/datasplash","labels_url":"https://api.github.com/repos/ngrunwald/datasplash/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/ngrunwald/datasplash/issues/7/comments","events_url":"https://api.github.com/repos/ngrunwald/datasplash/issues/7/events","html_url":"https://github.com/ngrunwald/datasplash/pull/7","id":183666383,"number":7,"title":"read-json-file: move a test out of the loop","user":{"login":"bfontaine","id":1334295,"avatar_url":"https://avatars.githubusercontent.com/u/1334295?v=3","gravatar_id":"","url":"https://api.github.com/users/bfontaine","html_url":"https://github.com/bfontaine","followers_url":"https://api.github.com/users/bfontaine/followers","following_url":"https://api.github.com/users/bfontaine/following{/other_user}","gists_url":"https://api.github.com/users/bfontaine/gists{/gist_id}","starred_url":"https://api.github.com/users/bfontaine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bfontaine/subscriptions","organizations_url":"https://api.github.com/users/bfontaine/orgs","repos_url":"https://api.github.com/users/bfontaine/repos","events_url":"https://api.github.com/users/bfontaine/events{/privacy}","received_events_url":"https://api.github.com/users/bfontaine/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-18T12:00:08Z","updated_at":"2016-10-19T16:52:20Z","closed_at":"2016-10-19T16:43:56Z","pull_request":{"url":"https://api.github.com/repos/ngrunwald/datasplash/pulls/7","html_url":"https://github.com/ngrunwald/datasplash/pull/7","diff_url":"https://github.com/ngrunwald/datasplash/pull/7.diff","patch_url":"https://github.com/ngrunwald/datasplash/pull/7.patch"},"body":"The current code performs a test at each loop iteration. This PR moves the test out of the loop (no pun intended). I don’t have any data on the performance improvement, thought.\r\n\r\nI wasn’t able to run `lein test` because of an exception:\r\n\r\n```\r\n$ lein test\r\nRetrieving org/hamcrest/hamcrest-all/1.3/hamcrest-all-1.3.pom from central\r\nRetrieving org/hamcrest/hamcrest-all/1.3/hamcrest-all-1.3.jar from central\r\nCompiling datasplash.api-test\r\nCompiling datasplash.examples\r\nCompiling clj-time.core\r\nException in thread \"main\" java.lang.NoClassDefFoundError: clojure/tools/logging/impl/LoggerFactory, compiling:(/tmp/form-init1405529213507449495.clj:1:73)\r\n\tat clojure.lang.Compiler.load(Compiler.java:7391)\r\n```"},"comment":{"url":"https://api.github.com/repos/ngrunwald/datasplash/issues/comments/254873228","html_url":"https://github.com/ngrunwald/datasplash/pull/7#issuecomment-254873228","issue_url":"https://api.github.com/repos/ngrunwald/datasplash/issues/7","id":254873228,"user":{"login":"ngrunwald","id":65414,"avatar_url":"https://avatars.githubusercontent.com/u/65414?v=3","gravatar_id":"","url":"https://api.github.com/users/ngrunwald","html_url":"https://github.com/ngrunwald","followers_url":"https://api.github.com/users/ngrunwald/followers","following_url":"https://api.github.com/users/ngrunwald/following{/other_user}","gists_url":"https://api.github.com/users/ngrunwald/gists{/gist_id}","starred_url":"https://api.github.com/users/ngrunwald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngrunwald/subscriptions","organizations_url":"https://api.github.com/users/ngrunwald/orgs","repos_url":"https://api.github.com/users/ngrunwald/repos","events_url":"https://api.github.com/users/ngrunwald/events{/privacy}","received_events_url":"https://api.github.com/users/ngrunwald/received_events","type":"User","site_admin":false},"created_at":"2016-10-19T16:52:20Z","updated_at":"2016-10-19T16:52:20Z","body":"Strange, I have no problem running the tests, maybe you missed a _lein clean_ or have a conflict in your _profiles.clj_? Anyway, there was just a problem with the _let_ block inside the *->>* macro, fixed and merged, it should mean something for very large inputs :)"}}
{"actor":{"display_login":"ngrunwald"}}