{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/15060","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/15060/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/15060/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/15060/events","html_url":"https://github.com/NixOS/nixpkgs/pull/15060","id":151714502,"number":15060,"title":"iscsiadm can't load modules, so let's update open-iscsi and patch it.","user":{"login":"clefru","id":443728,"avatar_url":"https://avatars.githubusercontent.com/u/443728?v=3","gravatar_id":"","url":"https://api.github.com/users/clefru","html_url":"https://github.com/clefru","followers_url":"https://api.github.com/users/clefru/followers","following_url":"https://api.github.com/users/clefru/following{/other_user}","gists_url":"https://api.github.com/users/clefru/gists{/gist_id}","starred_url":"https://api.github.com/users/clefru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clefru/subscriptions","organizations_url":"https://api.github.com/users/clefru/orgs","repos_url":"https://api.github.com/users/clefru/repos","events_url":"https://api.github.com/users/clefru/events{/privacy}","received_events_url":"https://api.github.com/users/clefru/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/0.kind:%20enhancement","name":"0.kind: enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20package%20(new)","name":"8.has: package (new)","color":"009800"},{"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20package%20(update)","name":"8.has: package (update)","color":"009800"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2016-04-28T18:42:58Z","updated_at":"2016-04-30T17:17:37Z","closed_at":"2016-04-29T15:37:23Z","pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/15060","html_url":"https://github.com/NixOS/nixpkgs/pull/15060","diff_url":"https://github.com/NixOS/nixpkgs/pull/15060.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/15060.patch"},"body":"iscsiadm tries to load iscsi transport tcp modules when needed. Luckily open-iscsi has kmod support that just needs to be enabled. That's more easy when open-iscsi is updated. This introduces an open-isns dependency. The patch set deals with these points in reverse order.\r\n\r\n###### Things done\r\n\r\n- [x] Tested using sandboxing\r\n  ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS,\r\n    or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)\r\n    on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] OS X\r\n   - [ ] Linux\r\n- [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/215979877","html_url":"https://github.com/NixOS/nixpkgs/pull/15060#issuecomment-215979877","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/15060","id":215979877,"user":{"login":"clefru","id":443728,"avatar_url":"https://avatars.githubusercontent.com/u/443728?v=3","gravatar_id":"","url":"https://api.github.com/users/clefru","html_url":"https://github.com/clefru","followers_url":"https://api.github.com/users/clefru/followers","following_url":"https://api.github.com/users/clefru/following{/other_user}","gists_url":"https://api.github.com/users/clefru/gists{/gist_id}","starred_url":"https://api.github.com/users/clefru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clefru/subscriptions","organizations_url":"https://api.github.com/users/clefru/orgs","repos_url":"https://api.github.com/users/clefru/repos","events_url":"https://api.github.com/users/clefru/events{/privacy}","received_events_url":"https://api.github.com/users/clefru/received_events","type":"User","site_admin":false},"created_at":"2016-04-30T17:17:37Z","updated_at":"2016-04-30T17:17:37Z","body":"https://github.com/open-iscsi/open-iscsi/commit/63d086c9cb84b881e13ce8a5b4ddb80234948258 is to blame which removes -static upstream without any remark why that was.\r\n\r\nThere doesn't seem to be a way to add \"-static\" just for iscsistart. Should we just prepare an individual patch?"}}