{"action":"created","comment":{"url":"https://api.github.com/repos/miloyip/rapidjson/pulls/comments/65292628","id":65292628,"diff_hunk":"@@ -52,6 +53,9 @@ RAPIDJSON_DIAG_OFF(effc++)\n \n RAPIDJSON_NAMESPACE_BEGIN\n \n+static const double LOWEST_FLOAT_AS_DOUBLE = static_cast<double>(-3.4028234e38f);","path":"include/rapidjson/document.h","position":12,"original_position":12,"commit_id":"d27a2550bb1de7156c1a931c789eeeddac06d942","original_commit_id":"d27a2550bb1de7156c1a931c789eeeddac06d942","user":{"login":"miloyip","id":1195774,"avatar_url":"https://avatars.githubusercontent.com/u/1195774?v=3","gravatar_id":"","url":"https://api.github.com/users/miloyip","html_url":"https://github.com/miloyip","followers_url":"https://api.github.com/users/miloyip/followers","following_url":"https://api.github.com/users/miloyip/following{/other_user}","gists_url":"https://api.github.com/users/miloyip/gists{/gist_id}","starred_url":"https://api.github.com/users/miloyip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miloyip/subscriptions","organizations_url":"https://api.github.com/users/miloyip/orgs","repos_url":"https://api.github.com/users/miloyip/repos","events_url":"https://api.github.com/users/miloyip/events{/privacy}","received_events_url":"https://api.github.com/users/miloyip/received_events","type":"User","site_admin":false},"body":"Global static variable needed to be prevented, because it may be included by multiple implementation files. In other headers I use inline function to return the values instead, if they needed to be named.","created_at":"2016-06-01T02:04:05Z","updated_at":"2016-06-01T02:04:05Z","html_url":"https://github.com/miloyip/rapidjson/pull/646#discussion_r65292628","pull_request_url":"https://api.github.com/repos/miloyip/rapidjson/pulls/646","_links":{"self":{"href":"https://api.github.com/repos/miloyip/rapidjson/pulls/comments/65292628"},"html":{"href":"https://github.com/miloyip/rapidjson/pull/646#discussion_r65292628"},"pull_request":{"href":"https://api.github.com/repos/miloyip/rapidjson/pulls/646"}}},"pull_request":{"url":"https://api.github.com/repos/miloyip/rapidjson/pulls/646","id":72067523,"html_url":"https://github.com/miloyip/rapidjson/pull/646","diff_url":"https://github.com/miloyip/rapidjson/pull/646.diff","patch_url":"https://github.com/miloyip/rapidjson/pull/646.patch","issue_url":"https://api.github.com/repos/miloyip/rapidjson/issues/646","number":646,"state":"open","locked":false,"title":"Fix undefined behaviour","user":{"login":"efidler","id":415600,"avatar_url":"https://avatars.githubusercontent.com/u/415600?v=3","gravatar_id":"","url":"https://api.github.com/users/efidler","html_url":"https://github.com/efidler","followers_url":"https://api.github.com/users/efidler/followers","following_url":"https://api.github.com/users/efidler/following{/other_user}","gists_url":"https://api.github.com/users/efidler/gists{/gist_id}","starred_url":"https://api.github.com/users/efidler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/efidler/subscriptions","organizations_url":"https://api.github.com/users/efidler/orgs","repos_url":"https://api.github.com/users/efidler/repos","events_url":"https://api.github.com/users/efidler/events{/privacy}","received_events_url":"https://api.github.com/users/efidler/received_events","type":"User","site_admin":false},"body":"Fix issues with undefined behaviour, mostly found by running the unittests under UBSAN on Clang/OSX and GCC5/Linux.\r\n\r\nIssue #644","created_at":"2016-05-31T18:57:07Z","updated_at":"2016-06-01T02:04:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c08bd401b9548e4d428f7eed19b509bff40712a0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/miloyip/rapidjson/pulls/646/commits","review_comments_url":"https://api.github.com/repos/miloyip/rapidjson/pulls/646/comments","review_comment_url":"https://api.github.com/repos/miloyip/rapidjson/pulls/comments{/number}","comments_url":"https://api.github.com/repos/miloyip/rapidjson/issues/646/comments","statuses_url":"https://api.github.com/repos/miloyip/rapidjson/statuses/d27a2550bb1de7156c1a931c789eeeddac06d942","head":{"label":"efidler:ubsan","ref":"ubsan","sha":"d27a2550bb1de7156c1a931c789eeeddac06d942","user":{"login":"efidler","id":415600,"avatar_url":"https://avatars.githubusercontent.com/u/415600?v=3","gravatar_id":"","url":"https://api.github.com/users/efidler","html_url":"https://github.com/efidler","followers_url":"https://api.github.com/users/efidler/followers","following_url":"https://api.github.com/users/efidler/following{/other_user}","gists_url":"https://api.github.com/users/efidler/gists{/gist_id}","starred_url":"https://api.github.com/users/efidler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/efidler/subscriptions","organizations_url":"https://api.github.com/users/efidler/orgs","repos_url":"https://api.github.com/users/efidler/repos","events_url":"https://api.github.com/users/efidler/events{/privacy}","received_events_url":"https://api.github.com/users/efidler/received_events","type":"User","site_admin":false},"repo":{"id":60097928,"name":"rapidjson","full_name":"efidler/rapidjson","owner":{"login":"efidler","id":415600,"avatar_url":"https://avatars.githubusercontent.com/u/415600?v=3","gravatar_id":"","url":"https://api.github.com/users/efidler","html_url":"https://github.com/efidler","followers_url":"https://api.github.com/users/efidler/followers","following_url":"https://api.github.com/users/efidler/following{/other_user}","gists_url":"https://api.github.com/users/efidler/gists{/gist_id}","starred_url":"https://api.github.com/users/efidler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/efidler/subscriptions","organizations_url":"https://api.github.com/users/efidler/orgs","repos_url":"https://api.github.com/users/efidler/repos","events_url":"https://api.github.com/users/efidler/events{/privacy}","received_events_url":"https://api.github.com/users/efidler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/efidler/rapidjson","description":"A fast JSON parser/generator for C++ with both SAX/DOM style API","fork":true,"url":"https://api.github.com/repos/efidler/rapidjson","forks_url":"https://api.github.com/repos/efidler/rapidjson/forks","keys_url":"https://api.github.com/repos/efidler/rapidjson/keys{/key_id}","collaborators_url":"https://api.github.com/repos/efidler/rapidjson/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/efidler/rapidjson/teams","hooks_url":"https://api.github.com/repos/efidler/rapidjson/hooks","issue_events_url":"https://api.github.com/repos/efidler/rapidjson/issues/events{/number}","events_url":"https://api.github.com/repos/efidler/rapidjson/events","assignees_url":"https://api.github.com/repos/efidler/rapidjson/assignees{/user}","branches_url":"https://api.github.com/repos/efidler/rapidjson/branches{/branch}","tags_url":"https://api.github.com/repos/efidler/rapidjson/tags","blobs_url":"https://api.github.com/repos/efidler/rapidjson/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/efidler/rapidjson/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/efidler/rapidjson/git/refs{/sha}","trees_url":"https://api.github.com/repos/efidler/rapidjson/git/trees{/sha}","statuses_url":"https://api.github.com/repos/efidler/rapidjson/statuses/{sha}","languages_url":"https://api.github.com/repos/efidler/rapidjson/languages","stargazers_url":"https://api.github.com/repos/efidler/rapidjson/stargazers","contributors_url":"https://api.github.com/repos/efidler/rapidjson/contributors","subscribers_url":"https://api.github.com/repos/efidler/rapidjson/subscribers","subscription_url":"https://api.github.com/repos/efidler/rapidjson/subscription","commits_url":"https://api.github.com/repos/efidler/rapidjson/commits{/sha}","git_commits_url":"https://api.github.com/repos/efidler/rapidjson/git/commits{/sha}","comments_url":"https://api.github.com/repos/efidler/rapidjson/comments{/number}","issue_comment_url":"https://api.github.com/repos/efidler/rapidjson/issues/comments{/number}","contents_url":"https://api.github.com/repos/efidler/rapidjson/contents/{+path}","compare_url":"https://api.github.com/repos/efidler/rapidjson/compare/{base}...{head}","merges_url":"https://api.github.com/repos/efidler/rapidjson/merges","archive_url":"https://api.github.com/repos/efidler/rapidjson/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/efidler/rapidjson/downloads","issues_url":"https://api.github.com/repos/efidler/rapidjson/issues{/number}","pulls_url":"https://api.github.com/repos/efidler/rapidjson/pulls{/number}","milestones_url":"https://api.github.com/repos/efidler/rapidjson/milestones{/number}","notifications_url":"https://api.github.com/repos/efidler/rapidjson/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/efidler/rapidjson/labels{/name}","releases_url":"https://api.github.com/repos/efidler/rapidjson/releases{/id}","deployments_url":"https://api.github.com/repos/efidler/rapidjson/deployments","created_at":"2016-05-31T14:44:11Z","updated_at":"2016-05-31T14:44:13Z","pushed_at":"2016-05-31T19:35:36Z","git_url":"git://github.com/efidler/rapidjson.git","ssh_url":"git@github.com:efidler/rapidjson.git","clone_url":"https://github.com/efidler/rapidjson.git","svn_url":"https://github.com/efidler/rapidjson","homepage":"http://rapidjson.org/","size":17487,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"miloyip:master","ref":"master","sha":"e6895ec115d2f48b6d7753ab9e5e5eb0732c1a7e","user":{"login":"miloyip","id":1195774,"avatar_url":"https://avatars.githubusercontent.com/u/1195774?v=3","gravatar_id":"","url":"https://api.github.com/users/miloyip","html_url":"https://github.com/miloyip","followers_url":"https://api.github.com/users/miloyip/followers","following_url":"https://api.github.com/users/miloyip/following{/other_user}","gists_url":"https://api.github.com/users/miloyip/gists{/gist_id}","starred_url":"https://api.github.com/users/miloyip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miloyip/subscriptions","organizations_url":"https://api.github.com/users/miloyip/orgs","repos_url":"https://api.github.com/users/miloyip/repos","events_url":"https://api.github.com/users/miloyip/events{/privacy}","received_events_url":"https://api.github.com/users/miloyip/received_events","type":"User","site_admin":false},"repo":{"id":17391973,"name":"rapidjson","full_name":"miloyip/rapidjson","owner":{"login":"miloyip","id":1195774,"avatar_url":"https://avatars.githubusercontent.com/u/1195774?v=3","gravatar_id":"","url":"https://api.github.com/users/miloyip","html_url":"https://github.com/miloyip","followers_url":"https://api.github.com/users/miloyip/followers","following_url":"https://api.github.com/users/miloyip/following{/other_user}","gists_url":"https://api.github.com/users/miloyip/gists{/gist_id}","starred_url":"https://api.github.com/users/miloyip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miloyip/subscriptions","organizations_url":"https://api.github.com/users/miloyip/orgs","repos_url":"https://api.github.com/users/miloyip/repos","events_url":"https://api.github.com/users/miloyip/events{/privacy}","received_events_url":"https://api.github.com/users/miloyip/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/miloyip/rapidjson","description":"A fast JSON parser/generator for C++ with both SAX/DOM style API","fork":false,"url":"https://api.github.com/repos/miloyip/rapidjson","forks_url":"https://api.github.com/repos/miloyip/rapidjson/forks","keys_url":"https://api.github.com/repos/miloyip/rapidjson/keys{/key_id}","collaborators_url":"https://api.github.com/repos/miloyip/rapidjson/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/miloyip/rapidjson/teams","hooks_url":"https://api.github.com/repos/miloyip/rapidjson/hooks","issue_events_url":"https://api.github.com/repos/miloyip/rapidjson/issues/events{/number}","events_url":"https://api.github.com/repos/miloyip/rapidjson/events","assignees_url":"https://api.github.com/repos/miloyip/rapidjson/assignees{/user}","branches_url":"https://api.github.com/repos/miloyip/rapidjson/branches{/branch}","tags_url":"https://api.github.com/repos/miloyip/rapidjson/tags","blobs_url":"https://api.github.com/repos/miloyip/rapidjson/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/miloyip/rapidjson/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/miloyip/rapidjson/git/refs{/sha}","trees_url":"https://api.github.com/repos/miloyip/rapidjson/git/trees{/sha}","statuses_url":"https://api.github.com/repos/miloyip/rapidjson/statuses/{sha}","languages_url":"https://api.github.com/repos/miloyip/rapidjson/languages","stargazers_url":"https://api.github.com/repos/miloyip/rapidjson/stargazers","contributors_url":"https://api.github.com/repos/miloyip/rapidjson/contributors","subscribers_url":"https://api.github.com/repos/miloyip/rapidjson/subscribers","subscription_url":"https://api.github.com/repos/miloyip/rapidjson/subscription","commits_url":"https://api.github.com/repos/miloyip/rapidjson/commits{/sha}","git_commits_url":"https://api.github.com/repos/miloyip/rapidjson/git/commits{/sha}","comments_url":"https://api.github.com/repos/miloyip/rapidjson/comments{/number}","issue_comment_url":"https://api.github.com/repos/miloyip/rapidjson/issues/comments{/number}","contents_url":"https://api.github.com/repos/miloyip/rapidjson/contents/{+path}","compare_url":"https://api.github.com/repos/miloyip/rapidjson/compare/{base}...{head}","merges_url":"https://api.github.com/repos/miloyip/rapidjson/merges","archive_url":"https://api.github.com/repos/miloyip/rapidjson/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/miloyip/rapidjson/downloads","issues_url":"https://api.github.com/repos/miloyip/rapidjson/issues{/number}","pulls_url":"https://api.github.com/repos/miloyip/rapidjson/pulls{/number}","milestones_url":"https://api.github.com/repos/miloyip/rapidjson/milestones{/number}","notifications_url":"https://api.github.com/repos/miloyip/rapidjson/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/miloyip/rapidjson/labels{/name}","releases_url":"https://api.github.com/repos/miloyip/rapidjson/releases{/id}","deployments_url":"https://api.github.com/repos/miloyip/rapidjson/deployments","created_at":"2014-03-04T05:53:37Z","updated_at":"2016-05-31T09:17:39Z","pushed_at":"2016-05-31T19:35:36Z","git_url":"git://github.com/miloyip/rapidjson.git","ssh_url":"git@github.com:miloyip/rapidjson.git","clone_url":"https://github.com/miloyip/rapidjson.git","svn_url":"https://github.com/miloyip/rapidjson","homepage":"http://rapidjson.org/","size":21681,"stargazers_count":3023,"watchers_count":3023,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":868,"mirror_url":null,"open_issues_count":42,"forks":868,"open_issues":42,"watchers":3023,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/miloyip/rapidjson/pulls/646"},"html":{"href":"https://github.com/miloyip/rapidjson/pull/646"},"issue":{"href":"https://api.github.com/repos/miloyip/rapidjson/issues/646"},"comments":{"href":"https://api.github.com/repos/miloyip/rapidjson/issues/646/comments"},"review_comments":{"href":"https://api.github.com/repos/miloyip/rapidjson/pulls/646/comments"},"review_comment":{"href":"https://api.github.com/repos/miloyip/rapidjson/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/miloyip/rapidjson/pulls/646/commits"},"statuses":{"href":"https://api.github.com/repos/miloyip/rapidjson/statuses/d27a2550bb1de7156c1a931c789eeeddac06d942"}}}}
{"actor":{"display_login":"miloyip"}}