{"action":"created","comment":{"url":"https://api.github.com/repos/rah003/neat-jsonfn/pulls/comments/67182780","id":67182780,"diff_hunk":"@@ -475,12 +471,13 @@ private boolean isArrayParent(Node candidate) {\n             return false;\n         }\n \n-        private Object childrenAsContentMapList(Node node) {\n+        private List<ContentMap> childrenAsContentMapList(Node node) {\n             try {\n                 return asNodeStream(node.getNodes()).map(n -> new EntryableContentMap(config.cloneWith(n)))\n                         .collect(Collectors.toList());\n             } catch (RepositoryException e) {\n-                throw new RuntimeException(e);\n+                log.error(\"Failed to get children of node {}\", node, e);\n+                return new ArrayList<>();","path":"src/main/java/com/neatresults/mgnltweaks/json/JsonBuilder.java","position":null,"original_position":44,"commit_id":"b68ffce883f6da2433b90e71fa60d8c29e3ab91f","original_commit_id":"70eea620f1ab011a6cbf6ace3379bf214cc51791","user":{"login":"rah003","id":5908150,"avatar_url":"https://avatars.githubusercontent.com/u/5908150?v=3","gravatar_id":"","url":"https://api.github.com/users/rah003","html_url":"https://github.com/rah003","followers_url":"https://api.github.com/users/rah003/followers","following_url":"https://api.github.com/users/rah003/following{/other_user}","gists_url":"https://api.github.com/users/rah003/gists{/gist_id}","starred_url":"https://api.github.com/users/rah003/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rah003/subscriptions","organizations_url":"https://api.github.com/users/rah003/orgs","repos_url":"https://api.github.com/users/rah003/repos","events_url":"https://api.github.com/users/rah003/events{/privacy}","received_events_url":"https://api.github.com/users/rah003/received_events","type":"User","site_admin":false},"body":"`Collections.EMPTY_LIST` rather than new object and really make those exceptions `log.debug()` only. The only way you can get exception here (if you dive in `o.a.j.core.NodeImpl.getNodes()` is either when node was deleted under your hands, in which case it is ok to act like it didn't exist in a first place or when someone removed access to the node from under your hands in which case it is again ok to act as if it doesn't exist. Whole JCR API is polluted by `RepositoryException` and while I'm not friend of sneaky throws, I also don't see a reason to transfer this pollution in the logs just for situations that are perfectly valid and out of control of the user.","created_at":"2016-06-15T15:20:18Z","updated_at":"2016-06-15T15:20:18Z","html_url":"https://github.com/rah003/neat-jsonfn/pull/12#discussion_r67182780","pull_request_url":"https://api.github.com/repos/rah003/neat-jsonfn/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/rah003/neat-jsonfn/pulls/comments/67182780"},"html":{"href":"https://github.com/rah003/neat-jsonfn/pull/12#discussion_r67182780"},"pull_request":{"href":"https://api.github.com/repos/rah003/neat-jsonfn/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/rah003/neat-jsonfn/pulls/12","id":73872448,"html_url":"https://github.com/rah003/neat-jsonfn/pull/12","diff_url":"https://github.com/rah003/neat-jsonfn/pull/12.diff","patch_url":"https://github.com/rah003/neat-jsonfn/pull/12.patch","issue_url":"https://api.github.com/repos/rah003/neat-jsonfn/issues/12","number":12,"state":"open","locked":false,"title":"New function \"childrenAsArray\"","user":{"login":"CedricReichenbach","id":1576321,"avatar_url":"https://avatars.githubusercontent.com/u/1576321?v=3","gravatar_id":"","url":"https://api.github.com/users/CedricReichenbach","html_url":"https://github.com/CedricReichenbach","followers_url":"https://api.github.com/users/CedricReichenbach/followers","following_url":"https://api.github.com/users/CedricReichenbach/following{/other_user}","gists_url":"https://api.github.com/users/CedricReichenbach/gists{/gist_id}","starred_url":"https://api.github.com/users/CedricReichenbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CedricReichenbach/subscriptions","organizations_url":"https://api.github.com/users/CedricReichenbach/orgs","repos_url":"https://api.github.com/users/CedricReichenbach/repos","events_url":"https://api.github.com/users/CedricReichenbach/events{/privacy}","received_events_url":"https://api.github.com/users/CedricReichenbach/received_events","type":"User","site_admin":false},"body":"Hi Jan,\r\n\r\nAs mentioned on the Mgnl-Unconference, we had been looking for some jsonfn templating functions, and this one is quite cool. However, we needed to be able to print children of some nodes as JSON arrays rather than sub-objects, so we added a function `childrenAsArray(keyRegex, valueRegex)` which prints children of matching nodes as arrays (and properties are skipped). Matching parent nodes means those having a property complying with `keyRegex : valueRegex` (see unit tests for examples).\r\n\r\nWe though that maybe you want to merge this back into the original project, as it would be cool to have all in one place, what do you think? Feel free to review the code and point out any bad things, and we'll try to fix them. :)\r\n\r\nAlso, do you plan a new release of the module to the Magnolia Nexus anytime soon? Apart of this change, there are a few other things like the backslash fix that aren't released yet.\r\n\r\nCheers,\r\nCedric","created_at":"2016-06-15T08:42:38Z","updated_at":"2016-06-15T15:20:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"37b789bf99ac4ad8e2bfe8d93bff99fd94307e8f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rah003/neat-jsonfn/pulls/12/commits","review_comments_url":"https://api.github.com/repos/rah003/neat-jsonfn/pulls/12/comments","review_comment_url":"https://api.github.com/repos/rah003/neat-jsonfn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rah003/neat-jsonfn/issues/12/comments","statuses_url":"https://api.github.com/repos/rah003/neat-jsonfn/statuses/b68ffce883f6da2433b90e71fa60d8c29e3ab91f","head":{"label":"CedricReichenbach:master","ref":"master","sha":"b68ffce883f6da2433b90e71fa60d8c29e3ab91f","user":{"login":"CedricReichenbach","id":1576321,"avatar_url":"https://avatars.githubusercontent.com/u/1576321?v=3","gravatar_id":"","url":"https://api.github.com/users/CedricReichenbach","html_url":"https://github.com/CedricReichenbach","followers_url":"https://api.github.com/users/CedricReichenbach/followers","following_url":"https://api.github.com/users/CedricReichenbach/following{/other_user}","gists_url":"https://api.github.com/users/CedricReichenbach/gists{/gist_id}","starred_url":"https://api.github.com/users/CedricReichenbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CedricReichenbach/subscriptions","organizations_url":"https://api.github.com/users/CedricReichenbach/orgs","repos_url":"https://api.github.com/users/CedricReichenbach/repos","events_url":"https://api.github.com/users/CedricReichenbach/events{/privacy}","received_events_url":"https://api.github.com/users/CedricReichenbach/received_events","type":"User","site_admin":false},"repo":{"id":61103978,"name":"neat-jsonfn","full_name":"CedricReichenbach/neat-jsonfn","owner":{"login":"CedricReichenbach","id":1576321,"avatar_url":"https://avatars.githubusercontent.com/u/1576321?v=3","gravatar_id":"","url":"https://api.github.com/users/CedricReichenbach","html_url":"https://github.com/CedricReichenbach","followers_url":"https://api.github.com/users/CedricReichenbach/followers","following_url":"https://api.github.com/users/CedricReichenbach/following{/other_user}","gists_url":"https://api.github.com/users/CedricReichenbach/gists{/gist_id}","starred_url":"https://api.github.com/users/CedricReichenbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CedricReichenbach/subscriptions","organizations_url":"https://api.github.com/users/CedricReichenbach/orgs","repos_url":"https://api.github.com/users/CedricReichenbach/repos","events_url":"https://api.github.com/users/CedricReichenbach/events{/privacy}","received_events_url":"https://api.github.com/users/CedricReichenbach/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CedricReichenbach/neat-jsonfn","description":"Set of functions for making conversion of JCR nodes into JSON easier","fork":true,"url":"https://api.github.com/repos/CedricReichenbach/neat-jsonfn","forks_url":"https://api.github.com/repos/CedricReichenbach/neat-jsonfn/forks","keys_url":"https://api.github.com/repos/CedricReichenbach/neat-jsonfn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CedricReichenbach/neat-jsonfn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CedricReichenbach/neat-jsonfn/teams","hooks_url":"https://api.github.com/repos/CedricReichenbach/neat-jsonfn/hooks","issue_events_url":"https://api.github.com/repos/CedricReichenbach/neat-jsonfn/issues/events{/number}","events_url":"https://api.github.com/repos/CedricReichenbach/neat-jsonfn/events","assignees_url":"https://api.github.com/repos/CedricReichenbach/neat-jsonfn/assignees{/user}","branches_url":"https://api.github.com/repos/CedricReichenbach/neat-jsonfn/branches{/branch}","tags_url":"https://api.github.com/repos/CedricReichenbach/neat-jsonfn/tags","blobs_url":"https://api.github.com/repos/CedricReichenbach/neat-jsonfn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CedricReichenbach/neat-jsonfn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CedricReichenbach/neat-jsonfn/git/refs{/sha}","trees_url":"https://api.github.com/repos/CedricReichenbach/neat-jsonfn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CedricReichenbach/neat-jsonfn/statuses/{sha}","languages_url":"https://api.github.com/repos/CedricReichenbach/neat-jsonfn/languages","stargazers_url":"https://api.github.com/repos/CedricReichenbach/neat-jsonfn/stargazers","contributors_url":"https://api.github.com/repos/CedricReichenbach/neat-jsonfn/contributors","subscribers_url":"https://api.github.com/repos/CedricReichenbach/neat-jsonfn/subscribers","subscription_url":"https://api.github.com/repos/CedricReichenbach/neat-jsonfn/subscription","commits_url":"https://api.github.com/repos/CedricReichenbach/neat-jsonfn/commits{/sha}","git_commits_url":"https://api.github.com/repos/CedricReichenbach/neat-jsonfn/git/commits{/sha}","comments_url":"https://api.github.com/repos/CedricReichenbach/neat-jsonfn/comments{/number}","issue_comment_url":"https://api.github.com/repos/CedricReichenbach/neat-jsonfn/issues/comments{/number}","contents_url":"https://api.github.com/repos/CedricReichenbach/neat-jsonfn/contents/{+path}","compare_url":"https://api.github.com/repos/CedricReichenbach/neat-jsonfn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CedricReichenbach/neat-jsonfn/merges","archive_url":"https://api.github.com/repos/CedricReichenbach/neat-jsonfn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CedricReichenbach/neat-jsonfn/downloads","issues_url":"https://api.github.com/repos/CedricReichenbach/neat-jsonfn/issues{/number}","pulls_url":"https://api.github.com/repos/CedricReichenbach/neat-jsonfn/pulls{/number}","milestones_url":"https://api.github.com/repos/CedricReichenbach/neat-jsonfn/milestones{/number}","notifications_url":"https://api.github.com/repos/CedricReichenbach/neat-jsonfn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CedricReichenbach/neat-jsonfn/labels{/name}","releases_url":"https://api.github.com/repos/CedricReichenbach/neat-jsonfn/releases{/id}","deployments_url":"https://api.github.com/repos/CedricReichenbach/neat-jsonfn/deployments","created_at":"2016-06-14T08:06:17Z","updated_at":"2016-06-14T08:06:19Z","pushed_at":"2016-06-15T13:52:13Z","git_url":"git://github.com/CedricReichenbach/neat-jsonfn.git","ssh_url":"git@github.com:CedricReichenbach/neat-jsonfn.git","clone_url":"https://github.com/CedricReichenbach/neat-jsonfn.git","svn_url":"https://github.com/CedricReichenbach/neat-jsonfn","homepage":null,"size":74,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rah003:master","ref":"master","sha":"45cd7ec885f61f755ae555cc64c9abdaa1cb2b45","user":{"login":"rah003","id":5908150,"avatar_url":"https://avatars.githubusercontent.com/u/5908150?v=3","gravatar_id":"","url":"https://api.github.com/users/rah003","html_url":"https://github.com/rah003","followers_url":"https://api.github.com/users/rah003/followers","following_url":"https://api.github.com/users/rah003/following{/other_user}","gists_url":"https://api.github.com/users/rah003/gists{/gist_id}","starred_url":"https://api.github.com/users/rah003/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rah003/subscriptions","organizations_url":"https://api.github.com/users/rah003/orgs","repos_url":"https://api.github.com/users/rah003/repos","events_url":"https://api.github.com/users/rah003/events{/privacy}","received_events_url":"https://api.github.com/users/rah003/received_events","type":"User","site_admin":false},"repo":{"id":48486120,"name":"neat-jsonfn","full_name":"rah003/neat-jsonfn","owner":{"login":"rah003","id":5908150,"avatar_url":"https://avatars.githubusercontent.com/u/5908150?v=3","gravatar_id":"","url":"https://api.github.com/users/rah003","html_url":"https://github.com/rah003","followers_url":"https://api.github.com/users/rah003/followers","following_url":"https://api.github.com/users/rah003/following{/other_user}","gists_url":"https://api.github.com/users/rah003/gists{/gist_id}","starred_url":"https://api.github.com/users/rah003/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rah003/subscriptions","organizations_url":"https://api.github.com/users/rah003/orgs","repos_url":"https://api.github.com/users/rah003/repos","events_url":"https://api.github.com/users/rah003/events{/privacy}","received_events_url":"https://api.github.com/users/rah003/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rah003/neat-jsonfn","description":"Set of functions for making conversion of JCR nodes into JSON easier","fork":false,"url":"https://api.github.com/repos/rah003/neat-jsonfn","forks_url":"https://api.github.com/repos/rah003/neat-jsonfn/forks","keys_url":"https://api.github.com/repos/rah003/neat-jsonfn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rah003/neat-jsonfn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rah003/neat-jsonfn/teams","hooks_url":"https://api.github.com/repos/rah003/neat-jsonfn/hooks","issue_events_url":"https://api.github.com/repos/rah003/neat-jsonfn/issues/events{/number}","events_url":"https://api.github.com/repos/rah003/neat-jsonfn/events","assignees_url":"https://api.github.com/repos/rah003/neat-jsonfn/assignees{/user}","branches_url":"https://api.github.com/repos/rah003/neat-jsonfn/branches{/branch}","tags_url":"https://api.github.com/repos/rah003/neat-jsonfn/tags","blobs_url":"https://api.github.com/repos/rah003/neat-jsonfn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rah003/neat-jsonfn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rah003/neat-jsonfn/git/refs{/sha}","trees_url":"https://api.github.com/repos/rah003/neat-jsonfn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rah003/neat-jsonfn/statuses/{sha}","languages_url":"https://api.github.com/repos/rah003/neat-jsonfn/languages","stargazers_url":"https://api.github.com/repos/rah003/neat-jsonfn/stargazers","contributors_url":"https://api.github.com/repos/rah003/neat-jsonfn/contributors","subscribers_url":"https://api.github.com/repos/rah003/neat-jsonfn/subscribers","subscription_url":"https://api.github.com/repos/rah003/neat-jsonfn/subscription","commits_url":"https://api.github.com/repos/rah003/neat-jsonfn/commits{/sha}","git_commits_url":"https://api.github.com/repos/rah003/neat-jsonfn/git/commits{/sha}","comments_url":"https://api.github.com/repos/rah003/neat-jsonfn/comments{/number}","issue_comment_url":"https://api.github.com/repos/rah003/neat-jsonfn/issues/comments{/number}","contents_url":"https://api.github.com/repos/rah003/neat-jsonfn/contents/{+path}","compare_url":"https://api.github.com/repos/rah003/neat-jsonfn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rah003/neat-jsonfn/merges","archive_url":"https://api.github.com/repos/rah003/neat-jsonfn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rah003/neat-jsonfn/downloads","issues_url":"https://api.github.com/repos/rah003/neat-jsonfn/issues{/number}","pulls_url":"https://api.github.com/repos/rah003/neat-jsonfn/pulls{/number}","milestones_url":"https://api.github.com/repos/rah003/neat-jsonfn/milestones{/number}","notifications_url":"https://api.github.com/repos/rah003/neat-jsonfn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rah003/neat-jsonfn/labels{/name}","releases_url":"https://api.github.com/repos/rah003/neat-jsonfn/releases{/id}","deployments_url":"https://api.github.com/repos/rah003/neat-jsonfn/deployments","created_at":"2015-12-23T11:02:27Z","updated_at":"2016-06-15T08:47:58Z","pushed_at":"2016-06-15T13:52:14Z","git_url":"git://github.com/rah003/neat-jsonfn.git","ssh_url":"git@github.com:rah003/neat-jsonfn.git","clone_url":"https://github.com/rah003/neat-jsonfn.git","svn_url":"https://github.com/rah003/neat-jsonfn","homepage":null,"size":68,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rah003/neat-jsonfn/pulls/12"},"html":{"href":"https://github.com/rah003/neat-jsonfn/pull/12"},"issue":{"href":"https://api.github.com/repos/rah003/neat-jsonfn/issues/12"},"comments":{"href":"https://api.github.com/repos/rah003/neat-jsonfn/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/rah003/neat-jsonfn/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/rah003/neat-jsonfn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rah003/neat-jsonfn/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/rah003/neat-jsonfn/statuses/b68ffce883f6da2433b90e71fa60d8c29e3ab91f"}}}}
{"actor":{"display_login":"rah003"}}