{"action":"created","issue":{"url":"https://api.github.com/repos/coq/coq/issues/332","repository_url":"https://api.github.com/repos/coq/coq","labels_url":"https://api.github.com/repos/coq/coq/issues/332/labels{/name}","comments_url":"https://api.github.com/repos/coq/coq/issues/332/comments","events_url":"https://api.github.com/repos/coq/coq/issues/332/events","html_url":"https://github.com/coq/coq/pull/332","id":184253115,"number":332,"title":"Removing an horribly designed syntax for eauto bfs.","user":{"login":"Zimmi48","id":1108325,"avatar_url":"https://avatars.githubusercontent.com/u/1108325?v=3","gravatar_id":"","url":"https://api.github.com/users/Zimmi48","html_url":"https://github.com/Zimmi48","followers_url":"https://api.github.com/users/Zimmi48/followers","following_url":"https://api.github.com/users/Zimmi48/following{/other_user}","gists_url":"https://api.github.com/users/Zimmi48/gists{/gist_id}","starred_url":"https://api.github.com/users/Zimmi48/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zimmi48/subscriptions","organizations_url":"https://api.github.com/users/Zimmi48/orgs","repos_url":"https://api.github.com/users/Zimmi48/repos","events_url":"https://api.github.com/users/Zimmi48/events{/privacy}","received_events_url":"https://api.github.com/users/Zimmi48/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/coq/coq/milestones/1","html_url":"https://github.com/coq/coq/milestones/8.6beta1","labels_url":"https://api.github.com/repos/coq/coq/milestones/1/labels","id":2039504,"number":1,"title":"8.6beta1","description":"","creator":{"login":"maximedenes","id":647105,"avatar_url":"https://avatars.githubusercontent.com/u/647105?v=3","gravatar_id":"","url":"https://api.github.com/users/maximedenes","html_url":"https://github.com/maximedenes","followers_url":"https://api.github.com/users/maximedenes/followers","following_url":"https://api.github.com/users/maximedenes/following{/other_user}","gists_url":"https://api.github.com/users/maximedenes/gists{/gist_id}","starred_url":"https://api.github.com/users/maximedenes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximedenes/subscriptions","organizations_url":"https://api.github.com/users/maximedenes/orgs","repos_url":"https://api.github.com/users/maximedenes/repos","events_url":"https://api.github.com/users/maximedenes/events{/privacy}","received_events_url":"https://api.github.com/users/maximedenes/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":24,"state":"open","created_at":"2016-09-30T07:16:25Z","updated_at":"2016-10-25T21:25:38Z","due_on":null,"closed_at":null},"comments":23,"created_at":"2016-10-20T14:56:12Z","updated_at":"2016-10-26T09:50:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/coq/coq/pulls/332","html_url":"https://github.com/coq/coq/pull/332","diff_url":"https://github.com/coq/coq/pull/332.diff","patch_url":"https://github.com/coq/coq/pull/332.patch"},"body":"Before this commit, it was possible to use `eauto 4 3` to call `eauto` in breadth-first search with depth 3 (`4` being a completely dummy argument).\r\nThis horrible syntax does not seem to be documented anywhere, not even in CHANGES so there is nothing against removing it.\r\nIt is not used in the stdlib.\r\nA grep on coq-contribs seems to indicate that it is not used there either but to be sure, I am also running https://ci.inria.fr/coq/view/coq-contribs/job/coq-contribs/521/console.\r\n\r\nNB: this syntax has existed at least since 2002 when .ml4 files were introduced. I did not manage to trace it back earlier but it probably wasn't invented then.\r\n\r\nWhen we are at it, shouldn't we also remove `dfs eauto` (which does nothing more than `eauto`, is undocumented and not used in either the stdlib or the contribs) or provide a new `bfs eauto`? I am a bit skeptical about the second option however because no one is asking for it. People who want more control on `eauto` are already using `typeclasses eauto` anyway and the latter is going to replace the former eventually.\r\nIf we decide not to provide any way to call `eauto` in breadth-first search mode (as is the case currently, except for this syntax that *I hope* no one knew about), maybe we could clean `eauto` from this possibility (to shorten the code).\r\n\r\nWhat is `new auto`? It is undocumented as well and I couldn't find any use in the contribs or the stdlib.\r\n\r\nFinally, while this patch strives to be minimal, I would have additionally replaced the use of `Eauto.make_depth` with an optional argument in `Eauto.gen_eauto`. Should I do it or, since this tactic is doomed anyway, I shouldn't worry about it?"},"comment":{"url":"https://api.github.com/repos/coq/coq/issues/comments/256300824","html_url":"https://github.com/coq/coq/pull/332#issuecomment-256300824","issue_url":"https://api.github.com/repos/coq/coq/issues/332","id":256300824,"user":{"login":"mattam82","id":98373,"avatar_url":"https://avatars.githubusercontent.com/u/98373?v=3","gravatar_id":"","url":"https://api.github.com/users/mattam82","html_url":"https://github.com/mattam82","followers_url":"https://api.github.com/users/mattam82/followers","following_url":"https://api.github.com/users/mattam82/following{/other_user}","gists_url":"https://api.github.com/users/mattam82/gists{/gist_id}","starred_url":"https://api.github.com/users/mattam82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattam82/subscriptions","organizations_url":"https://api.github.com/users/mattam82/orgs","repos_url":"https://api.github.com/users/mattam82/repos","events_url":"https://api.github.com/users/mattam82/events{/privacy}","received_events_url":"https://api.github.com/users/mattam82/received_events","type":"User","site_admin":false},"created_at":"2016-10-26T09:50:45Z","updated_at":"2016-10-26T09:50:45Z","body":"In this particular case we think it's dead code and would like to be aware if anyone was using it, even if I agree the method is a bit \"cavalier\". So I'm in favor in having it removed, even if it is late in the release cycle."}}
{"actor":{"display_login":"mattam82"}}