{"action":"created","issue":{"url":"https://api.github.com/repos/skatejs/skatejs/issues/984","repository_url":"https://api.github.com/repos/skatejs/skatejs","labels_url":"https://api.github.com/repos/skatejs/skatejs/issues/984/labels{/name}","comments_url":"https://api.github.com/repos/skatejs/skatejs/issues/984/comments","events_url":"https://api.github.com/repos/skatejs/skatejs/issues/984/events","html_url":"https://github.com/skatejs/skatejs/issues/984","id":197064587,"number":984,"title":"Add example on how to use css frameworks","user":{"login":"treshugart","id":136556,"avatar_url":"https://avatars.githubusercontent.com/u/136556?v=3","gravatar_id":"","url":"https://api.github.com/users/treshugart","html_url":"https://github.com/treshugart","followers_url":"https://api.github.com/users/treshugart/followers","following_url":"https://api.github.com/users/treshugart/following{/other_user}","gists_url":"https://api.github.com/users/treshugart/gists{/gist_id}","starred_url":"https://api.github.com/users/treshugart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/treshugart/subscriptions","organizations_url":"https://api.github.com/users/treshugart/orgs","repos_url":"https://api.github.com/users/treshugart/repos","events_url":"https://api.github.com/users/treshugart/events{/privacy}","received_events_url":"https://api.github.com/users/treshugart/received_events","type":"User","site_admin":false},"labels":[{"id":127684036,"url":"https://api.github.com/repos/skatejs/skatejs/labels/documentation","name":"documentation","color":"bfe5bf","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-12-22T00:13:13Z","updated_at":"2016-12-31T02:06:35Z","closed_at":null,"body":"For example: http://www.webpackbin.com/EJ_kDWEEG"},"comment":{"url":"https://api.github.com/repos/skatejs/skatejs/issues/comments/269843463","html_url":"https://github.com/skatejs/skatejs/issues/984#issuecomment-269843463","issue_url":"https://api.github.com/repos/skatejs/skatejs/issues/984","id":269843463,"user":{"login":"treshugart","id":136556,"avatar_url":"https://avatars.githubusercontent.com/u/136556?v=3","gravatar_id":"","url":"https://api.github.com/users/treshugart","html_url":"https://github.com/treshugart","followers_url":"https://api.github.com/users/treshugart/followers","following_url":"https://api.github.com/users/treshugart/following{/other_user}","gists_url":"https://api.github.com/users/treshugart/gists{/gist_id}","starred_url":"https://api.github.com/users/treshugart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/treshugart/subscriptions","organizations_url":"https://api.github.com/users/treshugart/orgs","repos_url":"https://api.github.com/users/treshugart/repos","events_url":"https://api.github.com/users/treshugart/events{/privacy}","received_events_url":"https://api.github.com/users/treshugart/received_events","type":"User","site_admin":false},"created_at":"2016-12-31T02:06:35Z","updated_at":"2016-12-31T02:06:35Z","body":"> We are shipping it inline for instance, not the best way from Perf perspective, but the only viable at this moment for us https://github.com/wc-catalogue/blaze-elements/blob/master/packages/button/Button.tsx#L50\r\n\r\nThat is the *canonical* way to do styling in web components for the time being. What's the performance penalty? Do you have numbers here?\r\n\r\n> About the ShadowDom, without it no content projection === no point of using WC at all ( we tried to use Preact for element rendering, wrapped with vanilla JS but ditched that because projection wasn't possible )\r\n\r\nNot sure what you mean by \"without it no content projection === no point of using WC\". Can you clarify, please?\r\n\r\n> So maybe we should include both your solution and ours within docs, WDYT?\r\n\r\nI'm not sure I'd include my example. After reading the article, I don't think it'd be a good idea to advocate an antipattern, even though it works (tm). I like yours - this is what I normally do - and am curious as to what performance issues you're experiencing as this is the recommended way to do styling in web components. Would it be because your css file transitively brings in the Blaze button css? It looks like you're only bringing in *just* the css for the buttons, which is exactly what CSS frameworks should provide when I say \"CSS frameworks need to change\". It would seem on the surface that you're not doing anything wrong."}}
{"actor":{"display_login":"treshugart"}}