{"action":"created","comment":{"url":"https://api.github.com/repos/ethcore/parity/pulls/comments/81213791","pull_request_review_id":2204654,"id":81213791,"diff_hunk":"@@ -0,0 +1,27 @@\n+[package]\n+authors = [\"Ethcore <admin@ethcore.io>\"]\n+description = \"Parity Rpc Client\"\n+homepage = \"http://ethcore.io\"\n+license = \"GPL-3.0\"\n+name = \"parity-rpc-client\"\n+version = \"1.4.0\"\n+\n+[dependencies]\n+futures = \"0.1\"\n+lazy_static = \"0.2.1\"\n+matches = \"0.1.2\"\n+rand = \"0.3.14\"\n+serde = \"0.8\"\n+serde_json = \"0.8\"\n+tempdir = \"0.3.5\"\n+url = \"1.2.0\"\n+ws = \"0.5.3\"\n+\n+[dependencies.ethcore-rpc]","path":"rpc_client/Cargo.toml","position":20,"original_position":20,"commit_id":"ad941fad51be09cbcd7042cce4258fe3868cf6e8","original_commit_id":"ad941fad51be09cbcd7042cce4258fe3868cf6e8","user":{"login":"tomusdrw","id":581548,"avatar_url":"https://avatars.githubusercontent.com/u/581548?v=3","gravatar_id":"","url":"https://api.github.com/users/tomusdrw","html_url":"https://github.com/tomusdrw","followers_url":"https://api.github.com/users/tomusdrw/followers","following_url":"https://api.github.com/users/tomusdrw/following{/other_user}","gists_url":"https://api.github.com/users/tomusdrw/gists{/gist_id}","starred_url":"https://api.github.com/users/tomusdrw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomusdrw/subscriptions","organizations_url":"https://api.github.com/users/tomusdrw/orgs","repos_url":"https://api.github.com/users/tomusdrw/repos","events_url":"https://api.github.com/users/tomusdrw/events{/privacy}","received_events_url":"https://api.github.com/users/tomusdrw/received_events","type":"User","site_admin":false},"body":"I think we are using this format everywhere:\r\n```toml\r\nethcore-rpc = { path = \"../rpc\" }\r\n```","created_at":"2016-09-29T19:16:06Z","updated_at":"2016-09-29T19:16:06Z","html_url":"https://github.com/ethcore/parity/pull/2384#discussion_r81213791","pull_request_url":"https://api.github.com/repos/ethcore/parity/pulls/2384","_links":{"self":{"href":"https://api.github.com/repos/ethcore/parity/pulls/comments/81213791"},"html":{"href":"https://github.com/ethcore/parity/pull/2384#discussion_r81213791"},"pull_request":{"href":"https://api.github.com/repos/ethcore/parity/pulls/2384"}}},"pull_request":{"url":"https://api.github.com/repos/ethcore/parity/pulls/2384","id":87163302,"html_url":"https://github.com/ethcore/parity/pull/2384","diff_url":"https://github.com/ethcore/parity/pull/2384.diff","patch_url":"https://github.com/ethcore/parity/pull/2384.patch","issue_url":"https://api.github.com/repos/ethcore/parity/issues/2384","number":2384,"state":"open","locked":false,"title":"Add Ws Json rpc client and command line utils","user":{"login":"krl","id":59379,"avatar_url":"https://avatars.githubusercontent.com/u/59379?v=3","gravatar_id":"","url":"https://api.github.com/users/krl","html_url":"https://github.com/krl","followers_url":"https://api.github.com/users/krl/followers","following_url":"https://api.github.com/users/krl/following{/other_user}","gists_url":"https://api.github.com/users/krl/gists{/gist_id}","starred_url":"https://api.github.com/users/krl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krl/subscriptions","organizations_url":"https://api.github.com/users/krl/orgs","repos_url":"https://api.github.com/users/krl/repos","events_url":"https://api.github.com/users/krl/events{/privacy}","received_events_url":"https://api.github.com/users/krl/received_events","type":"User","site_admin":false},"body":"Example run:\r\n\r\n```\r\ncargo run signer sign\r\n     Running `target/debug/parity signer sign`\r\nPassword: \r\n\r\nid: U256(1), U256(1000000000000000000) from fac892bcc6cec67eb0311c5c91617151f7d097dd to Some(000000000000000000000000000000000000dead)\r\nSign this transaction? (y)es/(N)o/(r)eject: y\r\nwarning: error: Err(ParseError: expected ident at line 1 column 2), new_message\r\nSigned transaction id: 0x42a65f49a23c12abb1b1d1e3e7d24c8ba94c556a23c174895cfed3dd3cf9cd59\r\n```\r\n\r\nNeed some tips/advice on how to organize this, not sure this is the best structure of crates/directories.\r\n\r\nThe warning is because of #2337\r\n\r\nTodos:\r\n- [ ] Clean up/format the output\r\n- [x] Deal with unused warnings\r\n- [ ] Testing signing/rejecting from the signer queue","created_at":"2016-09-28T17:22:46Z","updated_at":"2016-09-29T19:36:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0bf6cb94836bdf0635f20793a3260e9710f9f3e6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethcore/parity/pulls/2384/commits","review_comments_url":"https://api.github.com/repos/ethcore/parity/pulls/2384/comments","review_comment_url":"https://api.github.com/repos/ethcore/parity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethcore/parity/issues/2384/comments","statuses_url":"https://api.github.com/repos/ethcore/parity/statuses/ad941fad51be09cbcd7042cce4258fe3868cf6e8","head":{"label":"ethcore:cli-rpc","ref":"cli-rpc","sha":"ad941fad51be09cbcd7042cce4258fe3868cf6e8","user":{"login":"ethcore","id":14176906,"avatar_url":"https://avatars.githubusercontent.com/u/14176906?v=3","gravatar_id":"","url":"https://api.github.com/users/ethcore","html_url":"https://github.com/ethcore","followers_url":"https://api.github.com/users/ethcore/followers","following_url":"https://api.github.com/users/ethcore/following{/other_user}","gists_url":"https://api.github.com/users/ethcore/gists{/gist_id}","starred_url":"https://api.github.com/users/ethcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethcore/subscriptions","organizations_url":"https://api.github.com/users/ethcore/orgs","repos_url":"https://api.github.com/users/ethcore/repos","events_url":"https://api.github.com/users/ethcore/events{/privacy}","received_events_url":"https://api.github.com/users/ethcore/received_events","type":"Organization","site_admin":false},"repo":{"id":46714939,"name":"parity","full_name":"ethcore/parity","owner":{"login":"ethcore","id":14176906,"avatar_url":"https://avatars.githubusercontent.com/u/14176906?v=3","gravatar_id":"","url":"https://api.github.com/users/ethcore","html_url":"https://github.com/ethcore","followers_url":"https://api.github.com/users/ethcore/followers","following_url":"https://api.github.com/users/ethcore/following{/other_user}","gists_url":"https://api.github.com/users/ethcore/gists{/gist_id}","starred_url":"https://api.github.com/users/ethcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethcore/subscriptions","organizations_url":"https://api.github.com/users/ethcore/orgs","repos_url":"https://api.github.com/users/ethcore/repos","events_url":"https://api.github.com/users/ethcore/events{/privacy}","received_events_url":"https://api.github.com/users/ethcore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethcore/parity","description":"Fast, light, robust Ethereum implementation","fork":false,"url":"https://api.github.com/repos/ethcore/parity","forks_url":"https://api.github.com/repos/ethcore/parity/forks","keys_url":"https://api.github.com/repos/ethcore/parity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethcore/parity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethcore/parity/teams","hooks_url":"https://api.github.com/repos/ethcore/parity/hooks","issue_events_url":"https://api.github.com/repos/ethcore/parity/issues/events{/number}","events_url":"https://api.github.com/repos/ethcore/parity/events","assignees_url":"https://api.github.com/repos/ethcore/parity/assignees{/user}","branches_url":"https://api.github.com/repos/ethcore/parity/branches{/branch}","tags_url":"https://api.github.com/repos/ethcore/parity/tags","blobs_url":"https://api.github.com/repos/ethcore/parity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethcore/parity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethcore/parity/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethcore/parity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethcore/parity/statuses/{sha}","languages_url":"https://api.github.com/repos/ethcore/parity/languages","stargazers_url":"https://api.github.com/repos/ethcore/parity/stargazers","contributors_url":"https://api.github.com/repos/ethcore/parity/contributors","subscribers_url":"https://api.github.com/repos/ethcore/parity/subscribers","subscription_url":"https://api.github.com/repos/ethcore/parity/subscription","commits_url":"https://api.github.com/repos/ethcore/parity/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethcore/parity/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethcore/parity/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethcore/parity/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethcore/parity/contents/{+path}","compare_url":"https://api.github.com/repos/ethcore/parity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethcore/parity/merges","archive_url":"https://api.github.com/repos/ethcore/parity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethcore/parity/downloads","issues_url":"https://api.github.com/repos/ethcore/parity/issues{/number}","pulls_url":"https://api.github.com/repos/ethcore/parity/pulls{/number}","milestones_url":"https://api.github.com/repos/ethcore/parity/milestones{/number}","notifications_url":"https://api.github.com/repos/ethcore/parity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethcore/parity/labels{/name}","releases_url":"https://api.github.com/repos/ethcore/parity/releases{/id}","deployments_url":"https://api.github.com/repos/ethcore/parity/deployments","created_at":"2015-11-23T11:07:32Z","updated_at":"2016-09-29T13:03:32Z","pushed_at":"2016-09-29T17:18:56Z","git_url":"git://github.com/ethcore/parity.git","ssh_url":"git@github.com:ethcore/parity.git","clone_url":"https://github.com/ethcore/parity.git","svn_url":"https://github.com/ethcore/parity","homepage":"","size":37937,"stargazers_count":566,"watchers_count":566,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":100,"mirror_url":null,"open_issues_count":191,"forks":100,"open_issues":191,"watchers":566,"default_branch":"master"}},"base":{"label":"ethcore:master","ref":"master","sha":"6df1c3d157a6619ffd1b11014bd743b1c8d564ae","user":{"login":"ethcore","id":14176906,"avatar_url":"https://avatars.githubusercontent.com/u/14176906?v=3","gravatar_id":"","url":"https://api.github.com/users/ethcore","html_url":"https://github.com/ethcore","followers_url":"https://api.github.com/users/ethcore/followers","following_url":"https://api.github.com/users/ethcore/following{/other_user}","gists_url":"https://api.github.com/users/ethcore/gists{/gist_id}","starred_url":"https://api.github.com/users/ethcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethcore/subscriptions","organizations_url":"https://api.github.com/users/ethcore/orgs","repos_url":"https://api.github.com/users/ethcore/repos","events_url":"https://api.github.com/users/ethcore/events{/privacy}","received_events_url":"https://api.github.com/users/ethcore/received_events","type":"Organization","site_admin":false},"repo":{"id":46714939,"name":"parity","full_name":"ethcore/parity","owner":{"login":"ethcore","id":14176906,"avatar_url":"https://avatars.githubusercontent.com/u/14176906?v=3","gravatar_id":"","url":"https://api.github.com/users/ethcore","html_url":"https://github.com/ethcore","followers_url":"https://api.github.com/users/ethcore/followers","following_url":"https://api.github.com/users/ethcore/following{/other_user}","gists_url":"https://api.github.com/users/ethcore/gists{/gist_id}","starred_url":"https://api.github.com/users/ethcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethcore/subscriptions","organizations_url":"https://api.github.com/users/ethcore/orgs","repos_url":"https://api.github.com/users/ethcore/repos","events_url":"https://api.github.com/users/ethcore/events{/privacy}","received_events_url":"https://api.github.com/users/ethcore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethcore/parity","description":"Fast, light, robust Ethereum implementation","fork":false,"url":"https://api.github.com/repos/ethcore/parity","forks_url":"https://api.github.com/repos/ethcore/parity/forks","keys_url":"https://api.github.com/repos/ethcore/parity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethcore/parity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethcore/parity/teams","hooks_url":"https://api.github.com/repos/ethcore/parity/hooks","issue_events_url":"https://api.github.com/repos/ethcore/parity/issues/events{/number}","events_url":"https://api.github.com/repos/ethcore/parity/events","assignees_url":"https://api.github.com/repos/ethcore/parity/assignees{/user}","branches_url":"https://api.github.com/repos/ethcore/parity/branches{/branch}","tags_url":"https://api.github.com/repos/ethcore/parity/tags","blobs_url":"https://api.github.com/repos/ethcore/parity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethcore/parity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethcore/parity/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethcore/parity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethcore/parity/statuses/{sha}","languages_url":"https://api.github.com/repos/ethcore/parity/languages","stargazers_url":"https://api.github.com/repos/ethcore/parity/stargazers","contributors_url":"https://api.github.com/repos/ethcore/parity/contributors","subscribers_url":"https://api.github.com/repos/ethcore/parity/subscribers","subscription_url":"https://api.github.com/repos/ethcore/parity/subscription","commits_url":"https://api.github.com/repos/ethcore/parity/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethcore/parity/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethcore/parity/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethcore/parity/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethcore/parity/contents/{+path}","compare_url":"https://api.github.com/repos/ethcore/parity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethcore/parity/merges","archive_url":"https://api.github.com/repos/ethcore/parity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethcore/parity/downloads","issues_url":"https://api.github.com/repos/ethcore/parity/issues{/number}","pulls_url":"https://api.github.com/repos/ethcore/parity/pulls{/number}","milestones_url":"https://api.github.com/repos/ethcore/parity/milestones{/number}","notifications_url":"https://api.github.com/repos/ethcore/parity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethcore/parity/labels{/name}","releases_url":"https://api.github.com/repos/ethcore/parity/releases{/id}","deployments_url":"https://api.github.com/repos/ethcore/parity/deployments","created_at":"2015-11-23T11:07:32Z","updated_at":"2016-09-29T13:03:32Z","pushed_at":"2016-09-29T17:18:56Z","git_url":"git://github.com/ethcore/parity.git","ssh_url":"git@github.com:ethcore/parity.git","clone_url":"https://github.com/ethcore/parity.git","svn_url":"https://github.com/ethcore/parity","homepage":"","size":37937,"stargazers_count":566,"watchers_count":566,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":100,"mirror_url":null,"open_issues_count":191,"forks":100,"open_issues":191,"watchers":566,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethcore/parity/pulls/2384"},"html":{"href":"https://github.com/ethcore/parity/pull/2384"},"issue":{"href":"https://api.github.com/repos/ethcore/parity/issues/2384"},"comments":{"href":"https://api.github.com/repos/ethcore/parity/issues/2384/comments"},"review_comments":{"href":"https://api.github.com/repos/ethcore/parity/pulls/2384/comments"},"review_comment":{"href":"https://api.github.com/repos/ethcore/parity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethcore/parity/pulls/2384/commits"},"statuses":{"href":"https://api.github.com/repos/ethcore/parity/statuses/ad941fad51be09cbcd7042cce4258fe3868cf6e8"}}}}
{"actor":{"display_login":"tomusdrw"}}