{"action":"created","comment":{"url":"https://api.github.com/repos/lostisland/faraday/pulls/comments/84547192","pull_request_review_id":5322188,"id":84547192,"diff_hunk":"@@ -17,8 +17,11 @@ def with_net_http_connection(env)\n             define_method(:password) { proxy[:password] }\n           end if proxy[:user]\n         end\n-\n-        yield Net::HTTP::Persistent.new 'Faraday', proxy_uri\n+        if Net::HTTP::Persistent::VERSION >= '3'","path":"lib/faraday/adapter/net_http_persistent.rb","position":6,"original_position":6,"commit_id":"4eb008ea6a76d7ef261cdc24029b5ab306d449ae","original_commit_id":"3f65cb77cfa6ccd114c2629388a240981418231c","user":{"login":"drbrain","id":9831,"avatar_url":"https://avatars.githubusercontent.com/u/9831?v=3","gravatar_id":"","url":"https://api.github.com/users/drbrain","html_url":"https://github.com/drbrain","followers_url":"https://api.github.com/users/drbrain/followers","following_url":"https://api.github.com/users/drbrain/following{/other_user}","gists_url":"https://api.github.com/users/drbrain/gists{/gist_id}","starred_url":"https://api.github.com/users/drbrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drbrain/subscriptions","organizations_url":"https://api.github.com/users/drbrain/orgs","repos_url":"https://api.github.com/users/drbrain/repos","events_url":"https://api.github.com/users/drbrain/events{/privacy}","received_events_url":"https://api.github.com/users/drbrain/received_events","type":"User","site_admin":false},"body":"🙇🏻\r\n\r\nI switched this to open the possibility of adding arbitrary configuration keyword argument to the constructor.  Keeping the few positional arguments seemed silly.","created_at":"2016-10-21T21:24:39Z","updated_at":"2016-10-21T21:24:39Z","html_url":"https://github.com/lostisland/faraday/pull/619#discussion_r84547192","pull_request_url":"https://api.github.com/repos/lostisland/faraday/pulls/619","_links":{"self":{"href":"https://api.github.com/repos/lostisland/faraday/pulls/comments/84547192"},"html":{"href":"https://github.com/lostisland/faraday/pull/619#discussion_r84547192"},"pull_request":{"href":"https://api.github.com/repos/lostisland/faraday/pulls/619"}}},"pull_request":{"url":"https://api.github.com/repos/lostisland/faraday/pulls/619","id":89370348,"html_url":"https://github.com/lostisland/faraday/pull/619","diff_url":"https://github.com/lostisland/faraday/pull/619.diff","patch_url":"https://github.com/lostisland/faraday/pull/619.patch","issue_url":"https://api.github.com/repos/lostisland/faraday/issues/619","number":619,"state":"open","locked":false,"title":"Adapter support for Net::HTTP::Persistent v3.0.0","user":{"login":"olleolleolle","id":211,"avatar_url":"https://avatars.githubusercontent.com/u/211?v=3","gravatar_id":"","url":"https://api.github.com/users/olleolleolle","html_url":"https://github.com/olleolleolle","followers_url":"https://api.github.com/users/olleolleolle/followers","following_url":"https://api.github.com/users/olleolleolle/following{/other_user}","gists_url":"https://api.github.com/users/olleolleolle/gists{/gist_id}","starred_url":"https://api.github.com/users/olleolleolle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olleolleolle/subscriptions","organizations_url":"https://api.github.com/users/olleolleolle/orgs","repos_url":"https://api.github.com/users/olleolleolle/repos","events_url":"https://api.github.com/users/olleolleolle/events{/privacy}","received_events_url":"https://api.github.com/users/olleolleolle/received_events","type":"User","site_admin":false},"body":"This PR attempts to make it possible to use [Net::HTTP::Persistent](https://github.com/drbrain/net-http-persistent) 3.x with its existing Faraday Adapter.","created_at":"2016-10-14T11:44:03Z","updated_at":"2016-10-21T21:24:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c1d7ef12ac8739bc7a90910091778bbec016712","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/lostisland/faraday/pulls/619/commits","review_comments_url":"https://api.github.com/repos/lostisland/faraday/pulls/619/comments","review_comment_url":"https://api.github.com/repos/lostisland/faraday/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lostisland/faraday/issues/619/comments","statuses_url":"https://api.github.com/repos/lostisland/faraday/statuses/4eb008ea6a76d7ef261cdc24029b5ab306d449ae","head":{"label":"olleolleolle:master","ref":"master","sha":"4eb008ea6a76d7ef261cdc24029b5ab306d449ae","user":{"login":"olleolleolle","id":211,"avatar_url":"https://avatars.githubusercontent.com/u/211?v=3","gravatar_id":"","url":"https://api.github.com/users/olleolleolle","html_url":"https://github.com/olleolleolle","followers_url":"https://api.github.com/users/olleolleolle/followers","following_url":"https://api.github.com/users/olleolleolle/following{/other_user}","gists_url":"https://api.github.com/users/olleolleolle/gists{/gist_id}","starred_url":"https://api.github.com/users/olleolleolle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olleolleolle/subscriptions","organizations_url":"https://api.github.com/users/olleolleolle/orgs","repos_url":"https://api.github.com/users/olleolleolle/repos","events_url":"https://api.github.com/users/olleolleolle/events{/privacy}","received_events_url":"https://api.github.com/users/olleolleolle/received_events","type":"User","site_admin":false},"repo":{"id":70904212,"name":"faraday","full_name":"olleolleolle/faraday","owner":{"login":"olleolleolle","id":211,"avatar_url":"https://avatars.githubusercontent.com/u/211?v=3","gravatar_id":"","url":"https://api.github.com/users/olleolleolle","html_url":"https://github.com/olleolleolle","followers_url":"https://api.github.com/users/olleolleolle/followers","following_url":"https://api.github.com/users/olleolleolle/following{/other_user}","gists_url":"https://api.github.com/users/olleolleolle/gists{/gist_id}","starred_url":"https://api.github.com/users/olleolleolle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olleolleolle/subscriptions","organizations_url":"https://api.github.com/users/olleolleolle/orgs","repos_url":"https://api.github.com/users/olleolleolle/repos","events_url":"https://api.github.com/users/olleolleolle/events{/privacy}","received_events_url":"https://api.github.com/users/olleolleolle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/olleolleolle/faraday","description":"Simple, but flexible HTTP client library, with support for multiple backends.","fork":true,"url":"https://api.github.com/repos/olleolleolle/faraday","forks_url":"https://api.github.com/repos/olleolleolle/faraday/forks","keys_url":"https://api.github.com/repos/olleolleolle/faraday/keys{/key_id}","collaborators_url":"https://api.github.com/repos/olleolleolle/faraday/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/olleolleolle/faraday/teams","hooks_url":"https://api.github.com/repos/olleolleolle/faraday/hooks","issue_events_url":"https://api.github.com/repos/olleolleolle/faraday/issues/events{/number}","events_url":"https://api.github.com/repos/olleolleolle/faraday/events","assignees_url":"https://api.github.com/repos/olleolleolle/faraday/assignees{/user}","branches_url":"https://api.github.com/repos/olleolleolle/faraday/branches{/branch}","tags_url":"https://api.github.com/repos/olleolleolle/faraday/tags","blobs_url":"https://api.github.com/repos/olleolleolle/faraday/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/olleolleolle/faraday/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/olleolleolle/faraday/git/refs{/sha}","trees_url":"https://api.github.com/repos/olleolleolle/faraday/git/trees{/sha}","statuses_url":"https://api.github.com/repos/olleolleolle/faraday/statuses/{sha}","languages_url":"https://api.github.com/repos/olleolleolle/faraday/languages","stargazers_url":"https://api.github.com/repos/olleolleolle/faraday/stargazers","contributors_url":"https://api.github.com/repos/olleolleolle/faraday/contributors","subscribers_url":"https://api.github.com/repos/olleolleolle/faraday/subscribers","subscription_url":"https://api.github.com/repos/olleolleolle/faraday/subscription","commits_url":"https://api.github.com/repos/olleolleolle/faraday/commits{/sha}","git_commits_url":"https://api.github.com/repos/olleolleolle/faraday/git/commits{/sha}","comments_url":"https://api.github.com/repos/olleolleolle/faraday/comments{/number}","issue_comment_url":"https://api.github.com/repos/olleolleolle/faraday/issues/comments{/number}","contents_url":"https://api.github.com/repos/olleolleolle/faraday/contents/{+path}","compare_url":"https://api.github.com/repos/olleolleolle/faraday/compare/{base}...{head}","merges_url":"https://api.github.com/repos/olleolleolle/faraday/merges","archive_url":"https://api.github.com/repos/olleolleolle/faraday/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/olleolleolle/faraday/downloads","issues_url":"https://api.github.com/repos/olleolleolle/faraday/issues{/number}","pulls_url":"https://api.github.com/repos/olleolleolle/faraday/pulls{/number}","milestones_url":"https://api.github.com/repos/olleolleolle/faraday/milestones{/number}","notifications_url":"https://api.github.com/repos/olleolleolle/faraday/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/olleolleolle/faraday/labels{/name}","releases_url":"https://api.github.com/repos/olleolleolle/faraday/releases{/id}","deployments_url":"https://api.github.com/repos/olleolleolle/faraday/deployments","created_at":"2016-10-14T11:31:33Z","updated_at":"2016-10-14T11:31:35Z","pushed_at":"2016-10-18T13:53:28Z","git_url":"git://github.com/olleolleolle/faraday.git","ssh_url":"git@github.com:olleolleolle/faraday.git","clone_url":"https://github.com/olleolleolle/faraday.git","svn_url":"https://github.com/olleolleolle/faraday","homepage":"","size":1216,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lostisland:master","ref":"master","sha":"f440c44c6ef195b2098f98026bb66b3603bf0388","user":{"login":"lostisland","id":2613464,"avatar_url":"https://avatars.githubusercontent.com/u/2613464?v=3","gravatar_id":"","url":"https://api.github.com/users/lostisland","html_url":"https://github.com/lostisland","followers_url":"https://api.github.com/users/lostisland/followers","following_url":"https://api.github.com/users/lostisland/following{/other_user}","gists_url":"https://api.github.com/users/lostisland/gists{/gist_id}","starred_url":"https://api.github.com/users/lostisland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lostisland/subscriptions","organizations_url":"https://api.github.com/users/lostisland/orgs","repos_url":"https://api.github.com/users/lostisland/repos","events_url":"https://api.github.com/users/lostisland/events{/privacy}","received_events_url":"https://api.github.com/users/lostisland/received_events","type":"Organization","site_admin":false},"repo":{"id":417389,"name":"faraday","full_name":"lostisland/faraday","owner":{"login":"lostisland","id":2613464,"avatar_url":"https://avatars.githubusercontent.com/u/2613464?v=3","gravatar_id":"","url":"https://api.github.com/users/lostisland","html_url":"https://github.com/lostisland","followers_url":"https://api.github.com/users/lostisland/followers","following_url":"https://api.github.com/users/lostisland/following{/other_user}","gists_url":"https://api.github.com/users/lostisland/gists{/gist_id}","starred_url":"https://api.github.com/users/lostisland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lostisland/subscriptions","organizations_url":"https://api.github.com/users/lostisland/orgs","repos_url":"https://api.github.com/users/lostisland/repos","events_url":"https://api.github.com/users/lostisland/events{/privacy}","received_events_url":"https://api.github.com/users/lostisland/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lostisland/faraday","description":"Simple, but flexible HTTP client library, with support for multiple backends.","fork":false,"url":"https://api.github.com/repos/lostisland/faraday","forks_url":"https://api.github.com/repos/lostisland/faraday/forks","keys_url":"https://api.github.com/repos/lostisland/faraday/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lostisland/faraday/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lostisland/faraday/teams","hooks_url":"https://api.github.com/repos/lostisland/faraday/hooks","issue_events_url":"https://api.github.com/repos/lostisland/faraday/issues/events{/number}","events_url":"https://api.github.com/repos/lostisland/faraday/events","assignees_url":"https://api.github.com/repos/lostisland/faraday/assignees{/user}","branches_url":"https://api.github.com/repos/lostisland/faraday/branches{/branch}","tags_url":"https://api.github.com/repos/lostisland/faraday/tags","blobs_url":"https://api.github.com/repos/lostisland/faraday/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lostisland/faraday/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lostisland/faraday/git/refs{/sha}","trees_url":"https://api.github.com/repos/lostisland/faraday/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lostisland/faraday/statuses/{sha}","languages_url":"https://api.github.com/repos/lostisland/faraday/languages","stargazers_url":"https://api.github.com/repos/lostisland/faraday/stargazers","contributors_url":"https://api.github.com/repos/lostisland/faraday/contributors","subscribers_url":"https://api.github.com/repos/lostisland/faraday/subscribers","subscription_url":"https://api.github.com/repos/lostisland/faraday/subscription","commits_url":"https://api.github.com/repos/lostisland/faraday/commits{/sha}","git_commits_url":"https://api.github.com/repos/lostisland/faraday/git/commits{/sha}","comments_url":"https://api.github.com/repos/lostisland/faraday/comments{/number}","issue_comment_url":"https://api.github.com/repos/lostisland/faraday/issues/comments{/number}","contents_url":"https://api.github.com/repos/lostisland/faraday/contents/{+path}","compare_url":"https://api.github.com/repos/lostisland/faraday/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lostisland/faraday/merges","archive_url":"https://api.github.com/repos/lostisland/faraday/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lostisland/faraday/downloads","issues_url":"https://api.github.com/repos/lostisland/faraday/issues{/number}","pulls_url":"https://api.github.com/repos/lostisland/faraday/pulls{/number}","milestones_url":"https://api.github.com/repos/lostisland/faraday/milestones{/number}","notifications_url":"https://api.github.com/repos/lostisland/faraday/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lostisland/faraday/labels{/name}","releases_url":"https://api.github.com/repos/lostisland/faraday/releases{/id}","deployments_url":"https://api.github.com/repos/lostisland/faraday/deployments","created_at":"2009-12-10T17:14:55Z","updated_at":"2016-10-21T09:52:59Z","pushed_at":"2016-10-21T19:49:57Z","git_url":"git://github.com/lostisland/faraday.git","ssh_url":"git@github.com:lostisland/faraday.git","clone_url":"https://github.com/lostisland/faraday.git","svn_url":"https://github.com/lostisland/faraday","homepage":"","size":2599,"stargazers_count":3304,"watchers_count":3304,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":503,"mirror_url":null,"open_issues_count":72,"forks":503,"open_issues":72,"watchers":3304,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lostisland/faraday/pulls/619"},"html":{"href":"https://github.com/lostisland/faraday/pull/619"},"issue":{"href":"https://api.github.com/repos/lostisland/faraday/issues/619"},"comments":{"href":"https://api.github.com/repos/lostisland/faraday/issues/619/comments"},"review_comments":{"href":"https://api.github.com/repos/lostisland/faraday/pulls/619/comments"},"review_comment":{"href":"https://api.github.com/repos/lostisland/faraday/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lostisland/faraday/pulls/619/commits"},"statuses":{"href":"https://api.github.com/repos/lostisland/faraday/statuses/4eb008ea6a76d7ef261cdc24029b5ab306d449ae"}}}}
{"actor":{"display_login":"drbrain"}}