{"action":"created","comment":{"url":"https://api.github.com/repos/napalm-automation/napalm-eos/pulls/comments/89784226","pull_request_review_id":10318131,"id":89784226,"diff_hunk":"@@ -204,18 +204,26 @@ def rollback(self):\n         commands.append('write memory')\n         self.device.run_commands(commands)\n \n+    def _get_version(self):","path":"napalm_eos/eos.py","position":4,"original_position":4,"commit_id":"0c1042a404b8968a8a943cca6324cfebdae12b95","original_commit_id":"0c1042a404b8968a8a943cca6324cfebdae12b95","user":{"login":"mirceaulinic","id":16694679,"avatar_url":"https://avatars.githubusercontent.com/u/16694679?v=3","gravatar_id":"","url":"https://api.github.com/users/mirceaulinic","html_url":"https://github.com/mirceaulinic","followers_url":"https://api.github.com/users/mirceaulinic/followers","following_url":"https://api.github.com/users/mirceaulinic/following{/other_user}","gists_url":"https://api.github.com/users/mirceaulinic/gists{/gist_id}","starred_url":"https://api.github.com/users/mirceaulinic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirceaulinic/subscriptions","organizations_url":"https://api.github.com/users/mirceaulinic/orgs","repos_url":"https://api.github.com/users/mirceaulinic/repos","events_url":"https://api.github.com/users/mirceaulinic/events{/privacy}","received_events_url":"https://api.github.com/users/mirceaulinic/received_events","type":"User","site_admin":false},"body":"> result = self.device.run_commands(commands)[0]\r\n\r\nNo particular reason, just my personal preference - I don't like when there are many parans :)\r\n\r\n> And it also forces you to do several API calls instead of making one with several commands (particularly painful if you are operating devices with a high latency).\r\n\r\nIn ```get_facts``` right? That's true, will change that.","created_at":"2016-11-28T13:54:26Z","updated_at":"2016-11-28T13:54:26Z","html_url":"https://github.com/napalm-automation/napalm-eos/pull/94#discussion_r89784226","pull_request_url":"https://api.github.com/repos/napalm-automation/napalm-eos/pulls/94","_links":{"self":{"href":"https://api.github.com/repos/napalm-automation/napalm-eos/pulls/comments/89784226"},"html":{"href":"https://github.com/napalm-automation/napalm-eos/pull/94#discussion_r89784226"},"pull_request":{"href":"https://api.github.com/repos/napalm-automation/napalm-eos/pulls/94"}}},"pull_request":{"url":"https://api.github.com/repos/napalm-automation/napalm-eos/pulls/94","id":95493780,"html_url":"https://github.com/napalm-automation/napalm-eos/pull/94","diff_url":"https://github.com/napalm-automation/napalm-eos/pull/94.diff","patch_url":"https://github.com/napalm-automation/napalm-eos/pull/94.patch","issue_url":"https://api.github.com/repos/napalm-automation/napalm-eos/issues/94","number":94,"state":"open","locked":false,"title":"Fix #90","user":{"login":"mirceaulinic","id":16694679,"avatar_url":"https://avatars.githubusercontent.com/u/16694679?v=3","gravatar_id":"","url":"https://api.github.com/users/mirceaulinic","html_url":"https://github.com/mirceaulinic","followers_url":"https://api.github.com/users/mirceaulinic/followers","following_url":"https://api.github.com/users/mirceaulinic/following{/other_user}","gists_url":"https://api.github.com/users/mirceaulinic/gists{/gist_id}","starred_url":"https://api.github.com/users/mirceaulinic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirceaulinic/subscriptions","organizations_url":"https://api.github.com/users/mirceaulinic/orgs","repos_url":"https://api.github.com/users/mirceaulinic/repos","events_url":"https://api.github.com/users/mirceaulinic/events{/privacy}","received_events_url":"https://api.github.com/users/mirceaulinic/received_events","type":"User","site_admin":false},"body":"Fixes #90 ","created_at":"2016-11-28T12:56:49Z","updated_at":"2016-11-28T13:54:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05a297aca91a4a8c5b9cebd0feb150824357913f","assignee":{"login":"mirceaulinic","id":16694679,"avatar_url":"https://avatars.githubusercontent.com/u/16694679?v=3","gravatar_id":"","url":"https://api.github.com/users/mirceaulinic","html_url":"https://github.com/mirceaulinic","followers_url":"https://api.github.com/users/mirceaulinic/followers","following_url":"https://api.github.com/users/mirceaulinic/following{/other_user}","gists_url":"https://api.github.com/users/mirceaulinic/gists{/gist_id}","starred_url":"https://api.github.com/users/mirceaulinic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirceaulinic/subscriptions","organizations_url":"https://api.github.com/users/mirceaulinic/orgs","repos_url":"https://api.github.com/users/mirceaulinic/repos","events_url":"https://api.github.com/users/mirceaulinic/events{/privacy}","received_events_url":"https://api.github.com/users/mirceaulinic/received_events","type":"User","site_admin":false},"assignees":[{"login":"mirceaulinic","id":16694679,"avatar_url":"https://avatars.githubusercontent.com/u/16694679?v=3","gravatar_id":"","url":"https://api.github.com/users/mirceaulinic","html_url":"https://github.com/mirceaulinic","followers_url":"https://api.github.com/users/mirceaulinic/followers","following_url":"https://api.github.com/users/mirceaulinic/following{/other_user}","gists_url":"https://api.github.com/users/mirceaulinic/gists{/gist_id}","starred_url":"https://api.github.com/users/mirceaulinic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirceaulinic/subscriptions","organizations_url":"https://api.github.com/users/mirceaulinic/orgs","repos_url":"https://api.github.com/users/mirceaulinic/repos","events_url":"https://api.github.com/users/mirceaulinic/events{/privacy}","received_events_url":"https://api.github.com/users/mirceaulinic/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/napalm-automation/napalm-eos/milestones/13","html_url":"https://github.com/napalm-automation/napalm-eos/milestones/0.5.0","labels_url":"https://api.github.com/repos/napalm-automation/napalm-eos/milestones/13/labels","id":2144472,"number":13,"title":"0.5.0","description":null,"creator":{"login":"mirceaulinic","id":16694679,"avatar_url":"https://avatars.githubusercontent.com/u/16694679?v=3","gravatar_id":"","url":"https://api.github.com/users/mirceaulinic","html_url":"https://github.com/mirceaulinic","followers_url":"https://api.github.com/users/mirceaulinic/followers","following_url":"https://api.github.com/users/mirceaulinic/following{/other_user}","gists_url":"https://api.github.com/users/mirceaulinic/gists{/gist_id}","starred_url":"https://api.github.com/users/mirceaulinic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirceaulinic/subscriptions","organizations_url":"https://api.github.com/users/mirceaulinic/orgs","repos_url":"https://api.github.com/users/mirceaulinic/repos","events_url":"https://api.github.com/users/mirceaulinic/events{/privacy}","received_events_url":"https://api.github.com/users/mirceaulinic/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":5,"state":"open","created_at":"2016-11-18T15:58:49Z","updated_at":"2016-11-28T13:18:01Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/napalm-automation/napalm-eos/pulls/94/commits","review_comments_url":"https://api.github.com/repos/napalm-automation/napalm-eos/pulls/94/comments","review_comment_url":"https://api.github.com/repos/napalm-automation/napalm-eos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/napalm-automation/napalm-eos/issues/94/comments","statuses_url":"https://api.github.com/repos/napalm-automation/napalm-eos/statuses/0c1042a404b8968a8a943cca6324cfebdae12b95","head":{"label":"mirceaulinic:FIX-90","ref":"FIX-90","sha":"0c1042a404b8968a8a943cca6324cfebdae12b95","user":{"login":"mirceaulinic","id":16694679,"avatar_url":"https://avatars.githubusercontent.com/u/16694679?v=3","gravatar_id":"","url":"https://api.github.com/users/mirceaulinic","html_url":"https://github.com/mirceaulinic","followers_url":"https://api.github.com/users/mirceaulinic/followers","following_url":"https://api.github.com/users/mirceaulinic/following{/other_user}","gists_url":"https://api.github.com/users/mirceaulinic/gists{/gist_id}","starred_url":"https://api.github.com/users/mirceaulinic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirceaulinic/subscriptions","organizations_url":"https://api.github.com/users/mirceaulinic/orgs","repos_url":"https://api.github.com/users/mirceaulinic/repos","events_url":"https://api.github.com/users/mirceaulinic/events{/privacy}","received_events_url":"https://api.github.com/users/mirceaulinic/received_events","type":"User","site_admin":false},"repo":{"id":53277994,"name":"napalm-eos","full_name":"mirceaulinic/napalm-eos","owner":{"login":"mirceaulinic","id":16694679,"avatar_url":"https://avatars.githubusercontent.com/u/16694679?v=3","gravatar_id":"","url":"https://api.github.com/users/mirceaulinic","html_url":"https://github.com/mirceaulinic","followers_url":"https://api.github.com/users/mirceaulinic/followers","following_url":"https://api.github.com/users/mirceaulinic/following{/other_user}","gists_url":"https://api.github.com/users/mirceaulinic/gists{/gist_id}","starred_url":"https://api.github.com/users/mirceaulinic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirceaulinic/subscriptions","organizations_url":"https://api.github.com/users/mirceaulinic/orgs","repos_url":"https://api.github.com/users/mirceaulinic/repos","events_url":"https://api.github.com/users/mirceaulinic/events{/privacy}","received_events_url":"https://api.github.com/users/mirceaulinic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mirceaulinic/napalm-eos","description":null,"fork":true,"url":"https://api.github.com/repos/mirceaulinic/napalm-eos","forks_url":"https://api.github.com/repos/mirceaulinic/napalm-eos/forks","keys_url":"https://api.github.com/repos/mirceaulinic/napalm-eos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mirceaulinic/napalm-eos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mirceaulinic/napalm-eos/teams","hooks_url":"https://api.github.com/repos/mirceaulinic/napalm-eos/hooks","issue_events_url":"https://api.github.com/repos/mirceaulinic/napalm-eos/issues/events{/number}","events_url":"https://api.github.com/repos/mirceaulinic/napalm-eos/events","assignees_url":"https://api.github.com/repos/mirceaulinic/napalm-eos/assignees{/user}","branches_url":"https://api.github.com/repos/mirceaulinic/napalm-eos/branches{/branch}","tags_url":"https://api.github.com/repos/mirceaulinic/napalm-eos/tags","blobs_url":"https://api.github.com/repos/mirceaulinic/napalm-eos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mirceaulinic/napalm-eos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mirceaulinic/napalm-eos/git/refs{/sha}","trees_url":"https://api.github.com/repos/mirceaulinic/napalm-eos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mirceaulinic/napalm-eos/statuses/{sha}","languages_url":"https://api.github.com/repos/mirceaulinic/napalm-eos/languages","stargazers_url":"https://api.github.com/repos/mirceaulinic/napalm-eos/stargazers","contributors_url":"https://api.github.com/repos/mirceaulinic/napalm-eos/contributors","subscribers_url":"https://api.github.com/repos/mirceaulinic/napalm-eos/subscribers","subscription_url":"https://api.github.com/repos/mirceaulinic/napalm-eos/subscription","commits_url":"https://api.github.com/repos/mirceaulinic/napalm-eos/commits{/sha}","git_commits_url":"https://api.github.com/repos/mirceaulinic/napalm-eos/git/commits{/sha}","comments_url":"https://api.github.com/repos/mirceaulinic/napalm-eos/comments{/number}","issue_comment_url":"https://api.github.com/repos/mirceaulinic/napalm-eos/issues/comments{/number}","contents_url":"https://api.github.com/repos/mirceaulinic/napalm-eos/contents/{+path}","compare_url":"https://api.github.com/repos/mirceaulinic/napalm-eos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mirceaulinic/napalm-eos/merges","archive_url":"https://api.github.com/repos/mirceaulinic/napalm-eos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mirceaulinic/napalm-eos/downloads","issues_url":"https://api.github.com/repos/mirceaulinic/napalm-eos/issues{/number}","pulls_url":"https://api.github.com/repos/mirceaulinic/napalm-eos/pulls{/number}","milestones_url":"https://api.github.com/repos/mirceaulinic/napalm-eos/milestones{/number}","notifications_url":"https://api.github.com/repos/mirceaulinic/napalm-eos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mirceaulinic/napalm-eos/labels{/name}","releases_url":"https://api.github.com/repos/mirceaulinic/napalm-eos/releases{/id}","deployments_url":"https://api.github.com/repos/mirceaulinic/napalm-eos/deployments","created_at":"2016-03-06T21:48:35Z","updated_at":"2016-03-06T21:48:37Z","pushed_at":"2016-11-28T13:13:41Z","git_url":"git://github.com/mirceaulinic/napalm-eos.git","ssh_url":"git@github.com:mirceaulinic/napalm-eos.git","clone_url":"https://github.com/mirceaulinic/napalm-eos.git","svn_url":"https://github.com/mirceaulinic/napalm-eos","homepage":null,"size":392,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"napalm-automation:develop","ref":"develop","sha":"4fb8c60400014ff394f8a18f4a1a24bb4d72e83a","user":{"login":"napalm-automation","id":16415577,"avatar_url":"https://avatars.githubusercontent.com/u/16415577?v=3","gravatar_id":"","url":"https://api.github.com/users/napalm-automation","html_url":"https://github.com/napalm-automation","followers_url":"https://api.github.com/users/napalm-automation/followers","following_url":"https://api.github.com/users/napalm-automation/following{/other_user}","gists_url":"https://api.github.com/users/napalm-automation/gists{/gist_id}","starred_url":"https://api.github.com/users/napalm-automation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/napalm-automation/subscriptions","organizations_url":"https://api.github.com/users/napalm-automation/orgs","repos_url":"https://api.github.com/users/napalm-automation/repos","events_url":"https://api.github.com/users/napalm-automation/events{/privacy}","received_events_url":"https://api.github.com/users/napalm-automation/received_events","type":"Organization","site_admin":false},"repo":{"id":53214857,"name":"napalm-eos","full_name":"napalm-automation/napalm-eos","owner":{"login":"napalm-automation","id":16415577,"avatar_url":"https://avatars.githubusercontent.com/u/16415577?v=3","gravatar_id":"","url":"https://api.github.com/users/napalm-automation","html_url":"https://github.com/napalm-automation","followers_url":"https://api.github.com/users/napalm-automation/followers","following_url":"https://api.github.com/users/napalm-automation/following{/other_user}","gists_url":"https://api.github.com/users/napalm-automation/gists{/gist_id}","starred_url":"https://api.github.com/users/napalm-automation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/napalm-automation/subscriptions","organizations_url":"https://api.github.com/users/napalm-automation/orgs","repos_url":"https://api.github.com/users/napalm-automation/repos","events_url":"https://api.github.com/users/napalm-automation/events{/privacy}","received_events_url":"https://api.github.com/users/napalm-automation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/napalm-automation/napalm-eos","description":null,"fork":false,"url":"https://api.github.com/repos/napalm-automation/napalm-eos","forks_url":"https://api.github.com/repos/napalm-automation/napalm-eos/forks","keys_url":"https://api.github.com/repos/napalm-automation/napalm-eos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/napalm-automation/napalm-eos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/napalm-automation/napalm-eos/teams","hooks_url":"https://api.github.com/repos/napalm-automation/napalm-eos/hooks","issue_events_url":"https://api.github.com/repos/napalm-automation/napalm-eos/issues/events{/number}","events_url":"https://api.github.com/repos/napalm-automation/napalm-eos/events","assignees_url":"https://api.github.com/repos/napalm-automation/napalm-eos/assignees{/user}","branches_url":"https://api.github.com/repos/napalm-automation/napalm-eos/branches{/branch}","tags_url":"https://api.github.com/repos/napalm-automation/napalm-eos/tags","blobs_url":"https://api.github.com/repos/napalm-automation/napalm-eos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/napalm-automation/napalm-eos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/napalm-automation/napalm-eos/git/refs{/sha}","trees_url":"https://api.github.com/repos/napalm-automation/napalm-eos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/napalm-automation/napalm-eos/statuses/{sha}","languages_url":"https://api.github.com/repos/napalm-automation/napalm-eos/languages","stargazers_url":"https://api.github.com/repos/napalm-automation/napalm-eos/stargazers","contributors_url":"https://api.github.com/repos/napalm-automation/napalm-eos/contributors","subscribers_url":"https://api.github.com/repos/napalm-automation/napalm-eos/subscribers","subscription_url":"https://api.github.com/repos/napalm-automation/napalm-eos/subscription","commits_url":"https://api.github.com/repos/napalm-automation/napalm-eos/commits{/sha}","git_commits_url":"https://api.github.com/repos/napalm-automation/napalm-eos/git/commits{/sha}","comments_url":"https://api.github.com/repos/napalm-automation/napalm-eos/comments{/number}","issue_comment_url":"https://api.github.com/repos/napalm-automation/napalm-eos/issues/comments{/number}","contents_url":"https://api.github.com/repos/napalm-automation/napalm-eos/contents/{+path}","compare_url":"https://api.github.com/repos/napalm-automation/napalm-eos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/napalm-automation/napalm-eos/merges","archive_url":"https://api.github.com/repos/napalm-automation/napalm-eos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/napalm-automation/napalm-eos/downloads","issues_url":"https://api.github.com/repos/napalm-automation/napalm-eos/issues{/number}","pulls_url":"https://api.github.com/repos/napalm-automation/napalm-eos/pulls{/number}","milestones_url":"https://api.github.com/repos/napalm-automation/napalm-eos/milestones{/number}","notifications_url":"https://api.github.com/repos/napalm-automation/napalm-eos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/napalm-automation/napalm-eos/labels{/name}","releases_url":"https://api.github.com/repos/napalm-automation/napalm-eos/releases{/id}","deployments_url":"https://api.github.com/repos/napalm-automation/napalm-eos/deployments","created_at":"2016-03-05T17:52:13Z","updated_at":"2016-10-24T09:50:00Z","pushed_at":"2016-11-28T13:18:01Z","git_url":"git://github.com/napalm-automation/napalm-eos.git","ssh_url":"git@github.com:napalm-automation/napalm-eos.git","clone_url":"https://github.com/napalm-automation/napalm-eos.git","svn_url":"https://github.com/napalm-automation/napalm-eos","homepage":null,"size":430,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":5,"forks":18,"open_issues":5,"watchers":6,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/napalm-automation/napalm-eos/pulls/94"},"html":{"href":"https://github.com/napalm-automation/napalm-eos/pull/94"},"issue":{"href":"https://api.github.com/repos/napalm-automation/napalm-eos/issues/94"},"comments":{"href":"https://api.github.com/repos/napalm-automation/napalm-eos/issues/94/comments"},"review_comments":{"href":"https://api.github.com/repos/napalm-automation/napalm-eos/pulls/94/comments"},"review_comment":{"href":"https://api.github.com/repos/napalm-automation/napalm-eos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/napalm-automation/napalm-eos/pulls/94/commits"},"statuses":{"href":"https://api.github.com/repos/napalm-automation/napalm-eos/statuses/0c1042a404b8968a8a943cca6324cfebdae12b95"}}}}
{"actor":{"display_login":"mirceaulinic"}}