{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/5392","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/5392/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/5392/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/5392/events","html_url":"https://github.com/nodejs/node/pull/5392","id":135814667,"number":5392,"title":"(vee-eight-4.9) contextify: update deprecated SetWeak usage","user":{"login":"ofrobots","id":79017,"avatar_url":"https://avatars.githubusercontent.com/u/79017?v=3","gravatar_id":"","url":"https://api.github.com/users/ofrobots","html_url":"https://github.com/ofrobots","followers_url":"https://api.github.com/users/ofrobots/followers","following_url":"https://api.github.com/users/ofrobots/following{/other_user}","gists_url":"https://api.github.com/users/ofrobots/gists{/gist_id}","starred_url":"https://api.github.com/users/ofrobots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofrobots/subscriptions","organizations_url":"https://api.github.com/users/ofrobots/orgs","repos_url":"https://api.github.com/users/ofrobots/repos","events_url":"https://api.github.com/users/ofrobots/events{/privacy}","received_events_url":"https://api.github.com/users/ofrobots/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/lts-watch-v4.x","name":"lts-watch-v4.x","color":"eb6420"},{"url":"https://api.github.com/repos/nodejs/node/labels/v8","name":"v8","color":"0052cc"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-02-23T17:59:50Z","updated_at":"2016-03-17T19:53:53Z","closed_at":"2016-02-26T22:17:45Z","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/5392","html_url":"https://github.com/nodejs/node/pull/5392","diff_url":"https://github.com/nodejs/node/pull/5392.diff","patch_url":"https://github.com/nodejs/node/pull/5392.patch"},"body":"### Description of change\r\n\r\nFollow on from #5204 (which is pending landing once the CI resumes).\r\n\r\nThis PR cleans up the complexity with how weakness was being used in node_contextify and updates to the new style Phantom weakness API.\r\n\r\n### Pull Request check-list\r\n\r\n_Please make sure to review and check all of these items:_\r\n\r\n- [x] Does `make -j8 test` (UNIX) or `vcbuild test nosign` (Windows) pass with\r\n  this change (including linting)?\r\n- [x] Is the commit message formatted according to [CONTRIBUTING.md][0]?\r\n- [x] If this change fixes a bug (or a performance problem), is a regression\r\n  test (or a benchmark) included?\r\n- [x] Is a documentation update included (if this change modifies\r\n  existing APIs, or introduces new ones)?\r\n\r\n_NOTE: these things are not required to open a PR and can be done afterwards /\r\nwhile the PR is open._\r\n\r\n### Affected core subsystem(s)\r\n\r\ncontextify\r\n\r\nR=@bnoordhuis, @indutny \r\n/cc @nodejs/v8\r\n\r\n[0]: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/198056646","html_url":"https://github.com/nodejs/node/pull/5392#issuecomment-198056646","issue_url":"https://api.github.com/repos/nodejs/node/issues/5392","id":198056646,"user":{"login":"jasnell","id":439929,"avatar_url":"https://avatars.githubusercontent.com/u/439929?v=3","gravatar_id":"","url":"https://api.github.com/users/jasnell","html_url":"https://github.com/jasnell","followers_url":"https://api.github.com/users/jasnell/followers","following_url":"https://api.github.com/users/jasnell/following{/other_user}","gists_url":"https://api.github.com/users/jasnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jasnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasnell/subscriptions","organizations_url":"https://api.github.com/users/jasnell/orgs","repos_url":"https://api.github.com/users/jasnell/repos","events_url":"https://api.github.com/users/jasnell/events{/privacy}","received_events_url":"https://api.github.com/users/jasnell/received_events","type":"User","site_admin":false},"created_at":"2016-03-17T19:53:53Z","updated_at":"2016-03-17T19:53:53Z","body":"hmm.. @ofrobots would you be able to prepare a separate backport PR for v4?"}}