{"action":"created","comment":{"url":"https://api.github.com/repos/JabRef/jabref/pulls/comments/56789586","id":56789586,"diff_hunk":"@@ -305,7 +306,7 @@ private boolean tryXmpImport(String fileName, ExternalFileType fileType, NamedCo\n     //\n     // @return true if user pushed \"OK\", false otherwise\n     //\n-    private boolean showLinkMoveCopyRenameDialog(String linkFileName, ExternalFileType fileType,\n+    private boolean showLinkMoveCopyRenameDialog(String linkFileName, Optional<ExternalFileType> fileType,","path":"src/main/java/net/sf/jabref/external/DroppedFileHandler.java","position":65,"original_position":65,"commit_id":"f8850929a0c8189645ace0583efb7e3dad0ef0e7","original_commit_id":"f8850929a0c8189645ace0583efb7e3dad0ef0e7","user":{"login":"oscargus","id":8114497,"avatar_url":"https://avatars.githubusercontent.com/u/8114497?v=3","gravatar_id":"","url":"https://api.github.com/users/oscargus","html_url":"https://github.com/oscargus","followers_url":"https://api.github.com/users/oscargus/followers","following_url":"https://api.github.com/users/oscargus/following{/other_user}","gists_url":"https://api.github.com/users/oscargus/gists{/gist_id}","starred_url":"https://api.github.com/users/oscargus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oscargus/subscriptions","organizations_url":"https://api.github.com/users/oscargus/orgs","repos_url":"https://api.github.com/users/oscargus/repos","events_url":"https://api.github.com/users/oscargus/events{/privacy}","received_events_url":"https://api.github.com/users/oscargus/received_events","type":"User","site_admin":false},"body":"Only called with an ExternalFileType obtained from hardcoded \"pdf\", but I added a test that we have a valid type.","created_at":"2016-03-21T08:03:23Z","updated_at":"2016-03-21T08:03:23Z","html_url":"https://github.com/JabRef/jabref/pull/1003#discussion_r56789586","pull_request_url":"https://api.github.com/repos/JabRef/jabref/pulls/1003","_links":{"self":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/comments/56789586"},"html":{"href":"https://github.com/JabRef/jabref/pull/1003#discussion_r56789586"},"pull_request":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/1003"}}},"pull_request":{"url":"https://api.github.com/repos/JabRef/jabref/pulls/1003","id":63494653,"html_url":"https://github.com/JabRef/jabref/pull/1003","diff_url":"https://github.com/JabRef/jabref/pull/1003.diff","patch_url":"https://github.com/JabRef/jabref/pull/1003.patch","issue_url":"https://api.github.com/repos/JabRef/jabref/issues/1003","number":1003,"state":"open","locked":false,"title":"Used Optional for the getExternalFileType-methods and fixed an issue …","user":{"login":"oscargus","id":8114497,"avatar_url":"https://avatars.githubusercontent.com/u/8114497?v=3","gravatar_id":"","url":"https://api.github.com/users/oscargus","html_url":"https://github.com/oscargus","followers_url":"https://api.github.com/users/oscargus/followers","following_url":"https://api.github.com/users/oscargus/following{/other_user}","gists_url":"https://api.github.com/users/oscargus/gists{/gist_id}","starred_url":"https://api.github.com/users/oscargus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oscargus/subscriptions","organizations_url":"https://api.github.com/users/oscargus/orgs","repos_url":"https://api.github.com/users/oscargus/repos","events_url":"https://api.github.com/users/oscargus/events{/privacy}","received_events_url":"https://api.github.com/users/oscargus/received_events","type":"User","site_admin":false},"body":"Better to avoid null assignments and null checks...","created_at":"2016-03-20T12:53:55Z","updated_at":"2016-03-21T08:03:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7de041094afa1b941fb6927e60e9de98aeb625fd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JabRef/jabref/pulls/1003/commits","review_comments_url":"https://api.github.com/repos/JabRef/jabref/pulls/1003/comments","review_comment_url":"https://api.github.com/repos/JabRef/jabref/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JabRef/jabref/issues/1003/comments","statuses_url":"https://api.github.com/repos/JabRef/jabref/statuses/f8850929a0c8189645ace0583efb7e3dad0ef0e7","head":{"label":"oscargus:fewernullsexternalfiletype","ref":"fewernullsexternalfiletype","sha":"f8850929a0c8189645ace0583efb7e3dad0ef0e7","user":{"login":"oscargus","id":8114497,"avatar_url":"https://avatars.githubusercontent.com/u/8114497?v=3","gravatar_id":"","url":"https://api.github.com/users/oscargus","html_url":"https://github.com/oscargus","followers_url":"https://api.github.com/users/oscargus/followers","following_url":"https://api.github.com/users/oscargus/following{/other_user}","gists_url":"https://api.github.com/users/oscargus/gists{/gist_id}","starred_url":"https://api.github.com/users/oscargus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oscargus/subscriptions","organizations_url":"https://api.github.com/users/oscargus/orgs","repos_url":"https://api.github.com/users/oscargus/repos","events_url":"https://api.github.com/users/oscargus/events{/privacy}","received_events_url":"https://api.github.com/users/oscargus/received_events","type":"User","site_admin":false},"repo":{"id":43496954,"name":"jabref","full_name":"oscargus/jabref","owner":{"login":"oscargus","id":8114497,"avatar_url":"https://avatars.githubusercontent.com/u/8114497?v=3","gravatar_id":"","url":"https://api.github.com/users/oscargus","html_url":"https://github.com/oscargus","followers_url":"https://api.github.com/users/oscargus/followers","following_url":"https://api.github.com/users/oscargus/following{/other_user}","gists_url":"https://api.github.com/users/oscargus/gists{/gist_id}","starred_url":"https://api.github.com/users/oscargus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oscargus/subscriptions","organizations_url":"https://api.github.com/users/oscargus/orgs","repos_url":"https://api.github.com/users/oscargus/repos","events_url":"https://api.github.com/users/oscargus/events{/privacy}","received_events_url":"https://api.github.com/users/oscargus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oscargus/jabref","description":"Graphical Java application for managing bibtex (.bib) databases","fork":true,"url":"https://api.github.com/repos/oscargus/jabref","forks_url":"https://api.github.com/repos/oscargus/jabref/forks","keys_url":"https://api.github.com/repos/oscargus/jabref/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oscargus/jabref/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oscargus/jabref/teams","hooks_url":"https://api.github.com/repos/oscargus/jabref/hooks","issue_events_url":"https://api.github.com/repos/oscargus/jabref/issues/events{/number}","events_url":"https://api.github.com/repos/oscargus/jabref/events","assignees_url":"https://api.github.com/repos/oscargus/jabref/assignees{/user}","branches_url":"https://api.github.com/repos/oscargus/jabref/branches{/branch}","tags_url":"https://api.github.com/repos/oscargus/jabref/tags","blobs_url":"https://api.github.com/repos/oscargus/jabref/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oscargus/jabref/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oscargus/jabref/git/refs{/sha}","trees_url":"https://api.github.com/repos/oscargus/jabref/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oscargus/jabref/statuses/{sha}","languages_url":"https://api.github.com/repos/oscargus/jabref/languages","stargazers_url":"https://api.github.com/repos/oscargus/jabref/stargazers","contributors_url":"https://api.github.com/repos/oscargus/jabref/contributors","subscribers_url":"https://api.github.com/repos/oscargus/jabref/subscribers","subscription_url":"https://api.github.com/repos/oscargus/jabref/subscription","commits_url":"https://api.github.com/repos/oscargus/jabref/commits{/sha}","git_commits_url":"https://api.github.com/repos/oscargus/jabref/git/commits{/sha}","comments_url":"https://api.github.com/repos/oscargus/jabref/comments{/number}","issue_comment_url":"https://api.github.com/repos/oscargus/jabref/issues/comments{/number}","contents_url":"https://api.github.com/repos/oscargus/jabref/contents/{+path}","compare_url":"https://api.github.com/repos/oscargus/jabref/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oscargus/jabref/merges","archive_url":"https://api.github.com/repos/oscargus/jabref/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oscargus/jabref/downloads","issues_url":"https://api.github.com/repos/oscargus/jabref/issues{/number}","pulls_url":"https://api.github.com/repos/oscargus/jabref/pulls{/number}","milestones_url":"https://api.github.com/repos/oscargus/jabref/milestones{/number}","notifications_url":"https://api.github.com/repos/oscargus/jabref/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oscargus/jabref/labels{/name}","releases_url":"https://api.github.com/repos/oscargus/jabref/releases{/id}","deployments_url":"https://api.github.com/repos/oscargus/jabref/deployments","created_at":"2015-10-01T13:07:32Z","updated_at":"2016-01-11T08:19:16Z","pushed_at":"2016-03-21T07:26:47Z","git_url":"git://github.com/oscargus/jabref.git","ssh_url":"git@github.com:oscargus/jabref.git","clone_url":"https://github.com/oscargus/jabref.git","svn_url":"https://github.com/oscargus/jabref","homepage":"http://jabref.sourceforge.net/","size":81311,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JabRef:master","ref":"master","sha":"4730f7e8ce6fef8a6e7cfbaa71f9c4f629935f22","user":{"login":"JabRef","id":3914421,"avatar_url":"https://avatars.githubusercontent.com/u/3914421?v=3","gravatar_id":"","url":"https://api.github.com/users/JabRef","html_url":"https://github.com/JabRef","followers_url":"https://api.github.com/users/JabRef/followers","following_url":"https://api.github.com/users/JabRef/following{/other_user}","gists_url":"https://api.github.com/users/JabRef/gists{/gist_id}","starred_url":"https://api.github.com/users/JabRef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JabRef/subscriptions","organizations_url":"https://api.github.com/users/JabRef/orgs","repos_url":"https://api.github.com/users/JabRef/repos","events_url":"https://api.github.com/users/JabRef/events{/privacy}","received_events_url":"https://api.github.com/users/JabRef/received_events","type":"Organization","site_admin":false},"repo":{"id":17634071,"name":"jabref","full_name":"JabRef/jabref","owner":{"login":"JabRef","id":3914421,"avatar_url":"https://avatars.githubusercontent.com/u/3914421?v=3","gravatar_id":"","url":"https://api.github.com/users/JabRef","html_url":"https://github.com/JabRef","followers_url":"https://api.github.com/users/JabRef/followers","following_url":"https://api.github.com/users/JabRef/following{/other_user}","gists_url":"https://api.github.com/users/JabRef/gists{/gist_id}","starred_url":"https://api.github.com/users/JabRef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JabRef/subscriptions","organizations_url":"https://api.github.com/users/JabRef/orgs","repos_url":"https://api.github.com/users/JabRef/repos","events_url":"https://api.github.com/users/JabRef/events{/privacy}","received_events_url":"https://api.github.com/users/JabRef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JabRef/jabref","description":"Graphical Java application for managing bibtex (.bib) databases","fork":false,"url":"https://api.github.com/repos/JabRef/jabref","forks_url":"https://api.github.com/repos/JabRef/jabref/forks","keys_url":"https://api.github.com/repos/JabRef/jabref/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JabRef/jabref/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JabRef/jabref/teams","hooks_url":"https://api.github.com/repos/JabRef/jabref/hooks","issue_events_url":"https://api.github.com/repos/JabRef/jabref/issues/events{/number}","events_url":"https://api.github.com/repos/JabRef/jabref/events","assignees_url":"https://api.github.com/repos/JabRef/jabref/assignees{/user}","branches_url":"https://api.github.com/repos/JabRef/jabref/branches{/branch}","tags_url":"https://api.github.com/repos/JabRef/jabref/tags","blobs_url":"https://api.github.com/repos/JabRef/jabref/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JabRef/jabref/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JabRef/jabref/git/refs{/sha}","trees_url":"https://api.github.com/repos/JabRef/jabref/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JabRef/jabref/statuses/{sha}","languages_url":"https://api.github.com/repos/JabRef/jabref/languages","stargazers_url":"https://api.github.com/repos/JabRef/jabref/stargazers","contributors_url":"https://api.github.com/repos/JabRef/jabref/contributors","subscribers_url":"https://api.github.com/repos/JabRef/jabref/subscribers","subscription_url":"https://api.github.com/repos/JabRef/jabref/subscription","commits_url":"https://api.github.com/repos/JabRef/jabref/commits{/sha}","git_commits_url":"https://api.github.com/repos/JabRef/jabref/git/commits{/sha}","comments_url":"https://api.github.com/repos/JabRef/jabref/comments{/number}","issue_comment_url":"https://api.github.com/repos/JabRef/jabref/issues/comments{/number}","contents_url":"https://api.github.com/repos/JabRef/jabref/contents/{+path}","compare_url":"https://api.github.com/repos/JabRef/jabref/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JabRef/jabref/merges","archive_url":"https://api.github.com/repos/JabRef/jabref/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JabRef/jabref/downloads","issues_url":"https://api.github.com/repos/JabRef/jabref/issues{/number}","pulls_url":"https://api.github.com/repos/JabRef/jabref/pulls{/number}","milestones_url":"https://api.github.com/repos/JabRef/jabref/milestones{/number}","notifications_url":"https://api.github.com/repos/JabRef/jabref/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JabRef/jabref/labels{/name}","releases_url":"https://api.github.com/repos/JabRef/jabref/releases{/id}","deployments_url":"https://api.github.com/repos/JabRef/jabref/deployments","created_at":"2014-03-11T14:48:42Z","updated_at":"2016-03-20T10:09:32Z","pushed_at":"2016-03-21T07:28:24Z","git_url":"git://github.com/JabRef/jabref.git","ssh_url":"git@github.com:JabRef/jabref.git","clone_url":"https://github.com/JabRef/jabref.git","svn_url":"https://github.com/JabRef/jabref","homepage":"http://www.jabref.org/","size":84409,"stargazers_count":240,"watchers_count":240,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":159,"mirror_url":null,"open_issues_count":180,"forks":159,"open_issues":180,"watchers":240,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/1003"},"html":{"href":"https://github.com/JabRef/jabref/pull/1003"},"issue":{"href":"https://api.github.com/repos/JabRef/jabref/issues/1003"},"comments":{"href":"https://api.github.com/repos/JabRef/jabref/issues/1003/comments"},"review_comments":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/1003/comments"},"review_comment":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/1003/commits"},"statuses":{"href":"https://api.github.com/repos/JabRef/jabref/statuses/f8850929a0c8189645ace0583efb7e3dad0ef0e7"}}}}