{"action":"created","comment":{"url":"https://api.github.com/repos/koajs/koa/pulls/comments/83420037","pull_request_review_id":4266242,"id":83420037,"diff_hunk":"@@ -178,9 +178,7 @@ module.exports = class Application extends Emitter {\n     if (this.silent) return;\n \n     const msg = err.stack || err.toString();\n-    console.error();\n-    console.error(msg.replace(/^/gm, '  '));\n-    console.error();\n+    console.error(`\\n${msg.replace(/^/gm, '  ')}\\n`);","path":"lib/application.js","position":20,"original_position":20,"commit_id":"814cd8a35049f418b2d1ab2d7afd8967bd476a59","original_commit_id":"814cd8a35049f418b2d1ab2d7afd8967bd476a59","user":{"login":"dougmoscrop","id":586516,"avatar_url":"https://avatars.githubusercontent.com/u/586516?v=3","gravatar_id":"","url":"https://api.github.com/users/dougmoscrop","html_url":"https://github.com/dougmoscrop","followers_url":"https://api.github.com/users/dougmoscrop/followers","following_url":"https://api.github.com/users/dougmoscrop/following{/other_user}","gists_url":"https://api.github.com/users/dougmoscrop/gists{/gist_id}","starred_url":"https://api.github.com/users/dougmoscrop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dougmoscrop/subscriptions","organizations_url":"https://api.github.com/users/dougmoscrop/orgs","repos_url":"https://api.github.com/users/dougmoscrop/repos","events_url":"https://api.github.com/users/dougmoscrop/events{/privacy}","received_events_url":"https://api.github.com/users/dougmoscrop/received_events","type":"User","site_admin":false},"body":"`console.error('\\n', msg.replace(/^/gm, ' '), '\\n')` is another option","created_at":"2016-10-14T13:23:34Z","updated_at":"2016-10-14T13:23:34Z","html_url":"https://github.com/koajs/koa/pull/744#discussion_r83420037","pull_request_url":"https://api.github.com/repos/koajs/koa/pulls/744","_links":{"self":{"href":"https://api.github.com/repos/koajs/koa/pulls/comments/83420037"},"html":{"href":"https://github.com/koajs/koa/pull/744#discussion_r83420037"},"pull_request":{"href":"https://api.github.com/repos/koajs/koa/pulls/744"}}},"pull_request":{"url":"https://api.github.com/repos/koajs/koa/pulls/744","id":71524496,"html_url":"https://github.com/koajs/koa/pull/744","diff_url":"https://github.com/koajs/koa/pull/744.diff","patch_url":"https://github.com/koajs/koa/pull/744.patch","issue_url":"https://api.github.com/repos/koajs/koa/issues/744","number":744,"state":"open","locked":false,"title":"2.x change three console.error statements into one.","user":{"login":"iyuq","id":2170848,"avatar_url":"https://avatars.githubusercontent.com/u/2170848?v=3","gravatar_id":"","url":"https://api.github.com/users/iyuq","html_url":"https://github.com/iyuq","followers_url":"https://api.github.com/users/iyuq/followers","following_url":"https://api.github.com/users/iyuq/following{/other_user}","gists_url":"https://api.github.com/users/iyuq/gists{/gist_id}","starred_url":"https://api.github.com/users/iyuq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iyuq/subscriptions","organizations_url":"https://api.github.com/users/iyuq/orgs","repos_url":"https://api.github.com/users/iyuq/repos","events_url":"https://api.github.com/users/iyuq/events{/privacy}","received_events_url":"https://api.github.com/users/iyuq/received_events","type":"User","site_admin":false},"body":"1. change three console.error statements into one, this should improve some performance for the console.error is a sync io operation, reduce the number of times to call to console.error should improve some performance although this will not cause realtime problem.\r\n\r\n2. user template string in multiple lines of strings to avoid + operator.","created_at":"2016-05-26T09:21:29Z","updated_at":"2016-10-14T13:23:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b131b2aa4c052192085a382d7034a5b571050b3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/koajs/koa/pulls/744/commits","review_comments_url":"https://api.github.com/repos/koajs/koa/pulls/744/comments","review_comment_url":"https://api.github.com/repos/koajs/koa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/koajs/koa/issues/744/comments","statuses_url":"https://api.github.com/repos/koajs/koa/statuses/814cd8a35049f418b2d1ab2d7afd8967bd476a59","head":{"label":"iyuq:dev2.x","ref":"dev2.x","sha":"814cd8a35049f418b2d1ab2d7afd8967bd476a59","user":{"login":"iyuq","id":2170848,"avatar_url":"https://avatars.githubusercontent.com/u/2170848?v=3","gravatar_id":"","url":"https://api.github.com/users/iyuq","html_url":"https://github.com/iyuq","followers_url":"https://api.github.com/users/iyuq/followers","following_url":"https://api.github.com/users/iyuq/following{/other_user}","gists_url":"https://api.github.com/users/iyuq/gists{/gist_id}","starred_url":"https://api.github.com/users/iyuq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iyuq/subscriptions","organizations_url":"https://api.github.com/users/iyuq/orgs","repos_url":"https://api.github.com/users/iyuq/repos","events_url":"https://api.github.com/users/iyuq/events{/privacy}","received_events_url":"https://api.github.com/users/iyuq/received_events","type":"User","site_admin":false},"repo":{"id":57945753,"name":"koa","full_name":"iyuq/koa","owner":{"login":"iyuq","id":2170848,"avatar_url":"https://avatars.githubusercontent.com/u/2170848?v=3","gravatar_id":"","url":"https://api.github.com/users/iyuq","html_url":"https://github.com/iyuq","followers_url":"https://api.github.com/users/iyuq/followers","following_url":"https://api.github.com/users/iyuq/following{/other_user}","gists_url":"https://api.github.com/users/iyuq/gists{/gist_id}","starred_url":"https://api.github.com/users/iyuq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iyuq/subscriptions","organizations_url":"https://api.github.com/users/iyuq/orgs","repos_url":"https://api.github.com/users/iyuq/repos","events_url":"https://api.github.com/users/iyuq/events{/privacy}","received_events_url":"https://api.github.com/users/iyuq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iyuq/koa","description":"Expressive middleware for node.js using generators","fork":true,"url":"https://api.github.com/repos/iyuq/koa","forks_url":"https://api.github.com/repos/iyuq/koa/forks","keys_url":"https://api.github.com/repos/iyuq/koa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iyuq/koa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iyuq/koa/teams","hooks_url":"https://api.github.com/repos/iyuq/koa/hooks","issue_events_url":"https://api.github.com/repos/iyuq/koa/issues/events{/number}","events_url":"https://api.github.com/repos/iyuq/koa/events","assignees_url":"https://api.github.com/repos/iyuq/koa/assignees{/user}","branches_url":"https://api.github.com/repos/iyuq/koa/branches{/branch}","tags_url":"https://api.github.com/repos/iyuq/koa/tags","blobs_url":"https://api.github.com/repos/iyuq/koa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iyuq/koa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iyuq/koa/git/refs{/sha}","trees_url":"https://api.github.com/repos/iyuq/koa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iyuq/koa/statuses/{sha}","languages_url":"https://api.github.com/repos/iyuq/koa/languages","stargazers_url":"https://api.github.com/repos/iyuq/koa/stargazers","contributors_url":"https://api.github.com/repos/iyuq/koa/contributors","subscribers_url":"https://api.github.com/repos/iyuq/koa/subscribers","subscription_url":"https://api.github.com/repos/iyuq/koa/subscription","commits_url":"https://api.github.com/repos/iyuq/koa/commits{/sha}","git_commits_url":"https://api.github.com/repos/iyuq/koa/git/commits{/sha}","comments_url":"https://api.github.com/repos/iyuq/koa/comments{/number}","issue_comment_url":"https://api.github.com/repos/iyuq/koa/issues/comments{/number}","contents_url":"https://api.github.com/repos/iyuq/koa/contents/{+path}","compare_url":"https://api.github.com/repos/iyuq/koa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iyuq/koa/merges","archive_url":"https://api.github.com/repos/iyuq/koa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iyuq/koa/downloads","issues_url":"https://api.github.com/repos/iyuq/koa/issues{/number}","pulls_url":"https://api.github.com/repos/iyuq/koa/pulls{/number}","milestones_url":"https://api.github.com/repos/iyuq/koa/milestones{/number}","notifications_url":"https://api.github.com/repos/iyuq/koa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iyuq/koa/labels{/name}","releases_url":"https://api.github.com/repos/iyuq/koa/releases{/id}","deployments_url":"https://api.github.com/repos/iyuq/koa/deployments","created_at":"2016-05-03T06:13:43Z","updated_at":"2016-05-03T06:13:44Z","pushed_at":"2016-05-26T09:16:31Z","git_url":"git://github.com/iyuq/koa.git","ssh_url":"git@github.com:iyuq/koa.git","clone_url":"https://github.com/iyuq/koa.git","svn_url":"https://github.com/iyuq/koa","homepage":"http://koajs.com","size":1622,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"koajs:v2.x","ref":"v2.x","sha":"b16d24ecb83b403e26f9c4f9c5f67023fbdeb6f7","user":{"login":"koajs","id":5055057,"avatar_url":"https://avatars.githubusercontent.com/u/5055057?v=3","gravatar_id":"","url":"https://api.github.com/users/koajs","html_url":"https://github.com/koajs","followers_url":"https://api.github.com/users/koajs/followers","following_url":"https://api.github.com/users/koajs/following{/other_user}","gists_url":"https://api.github.com/users/koajs/gists{/gist_id}","starred_url":"https://api.github.com/users/koajs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koajs/subscriptions","organizations_url":"https://api.github.com/users/koajs/orgs","repos_url":"https://api.github.com/users/koajs/repos","events_url":"https://api.github.com/users/koajs/events{/privacy}","received_events_url":"https://api.github.com/users/koajs/received_events","type":"Organization","site_admin":false},"repo":{"id":11551538,"name":"koa","full_name":"koajs/koa","owner":{"login":"koajs","id":5055057,"avatar_url":"https://avatars.githubusercontent.com/u/5055057?v=3","gravatar_id":"","url":"https://api.github.com/users/koajs","html_url":"https://github.com/koajs","followers_url":"https://api.github.com/users/koajs/followers","following_url":"https://api.github.com/users/koajs/following{/other_user}","gists_url":"https://api.github.com/users/koajs/gists{/gist_id}","starred_url":"https://api.github.com/users/koajs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koajs/subscriptions","organizations_url":"https://api.github.com/users/koajs/orgs","repos_url":"https://api.github.com/users/koajs/repos","events_url":"https://api.github.com/users/koajs/events{/privacy}","received_events_url":"https://api.github.com/users/koajs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/koajs/koa","description":"Expressive middleware for node.js using generators","fork":false,"url":"https://api.github.com/repos/koajs/koa","forks_url":"https://api.github.com/repos/koajs/koa/forks","keys_url":"https://api.github.com/repos/koajs/koa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/koajs/koa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/koajs/koa/teams","hooks_url":"https://api.github.com/repos/koajs/koa/hooks","issue_events_url":"https://api.github.com/repos/koajs/koa/issues/events{/number}","events_url":"https://api.github.com/repos/koajs/koa/events","assignees_url":"https://api.github.com/repos/koajs/koa/assignees{/user}","branches_url":"https://api.github.com/repos/koajs/koa/branches{/branch}","tags_url":"https://api.github.com/repos/koajs/koa/tags","blobs_url":"https://api.github.com/repos/koajs/koa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/koajs/koa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/koajs/koa/git/refs{/sha}","trees_url":"https://api.github.com/repos/koajs/koa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/koajs/koa/statuses/{sha}","languages_url":"https://api.github.com/repos/koajs/koa/languages","stargazers_url":"https://api.github.com/repos/koajs/koa/stargazers","contributors_url":"https://api.github.com/repos/koajs/koa/contributors","subscribers_url":"https://api.github.com/repos/koajs/koa/subscribers","subscription_url":"https://api.github.com/repos/koajs/koa/subscription","commits_url":"https://api.github.com/repos/koajs/koa/commits{/sha}","git_commits_url":"https://api.github.com/repos/koajs/koa/git/commits{/sha}","comments_url":"https://api.github.com/repos/koajs/koa/comments{/number}","issue_comment_url":"https://api.github.com/repos/koajs/koa/issues/comments{/number}","contents_url":"https://api.github.com/repos/koajs/koa/contents/{+path}","compare_url":"https://api.github.com/repos/koajs/koa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/koajs/koa/merges","archive_url":"https://api.github.com/repos/koajs/koa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/koajs/koa/downloads","issues_url":"https://api.github.com/repos/koajs/koa/issues{/number}","pulls_url":"https://api.github.com/repos/koajs/koa/pulls{/number}","milestones_url":"https://api.github.com/repos/koajs/koa/milestones{/number}","notifications_url":"https://api.github.com/repos/koajs/koa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/koajs/koa/labels{/name}","releases_url":"https://api.github.com/repos/koajs/koa/releases{/id}","deployments_url":"https://api.github.com/repos/koajs/koa/deployments","created_at":"2013-07-20T18:53:45Z","updated_at":"2016-10-14T13:11:45Z","pushed_at":"2016-10-10T09:56:14Z","git_url":"git://github.com/koajs/koa.git","ssh_url":"git@github.com:koajs/koa.git","clone_url":"https://github.com/koajs/koa.git","svn_url":"https://github.com/koajs/koa","homepage":"http://koajs.com","size":2502,"stargazers_count":12163,"watchers_count":12163,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1043,"mirror_url":null,"open_issues_count":20,"forks":1043,"open_issues":20,"watchers":12163,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/koajs/koa/pulls/744"},"html":{"href":"https://github.com/koajs/koa/pull/744"},"issue":{"href":"https://api.github.com/repos/koajs/koa/issues/744"},"comments":{"href":"https://api.github.com/repos/koajs/koa/issues/744/comments"},"review_comments":{"href":"https://api.github.com/repos/koajs/koa/pulls/744/comments"},"review_comment":{"href":"https://api.github.com/repos/koajs/koa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/koajs/koa/pulls/744/commits"},"statuses":{"href":"https://api.github.com/repos/koajs/koa/statuses/814cd8a35049f418b2d1ab2d7afd8967bd476a59"}}}}
{"actor":{"display_login":"dougmoscrop"}}