{"action":"created","comment":{"url":"https://api.github.com/repos/CommBank/coppersmith/pulls/comments/70360806","id":70360806,"diff_hunk":"@@ -1,3 +1,4 @@\n /_site/\n .idea/\n target\n+.DS_Store","path":".gitignore","position":4,"original_position":4,"commit_id":"deec379673a64ac59a25fca2091bf9071a1e2b63","original_commit_id":"deec379673a64ac59a25fca2091bf9071a1e2b63","user":{"login":"triggerNZ","id":489039,"avatar_url":"https://avatars.githubusercontent.com/u/489039?v=3","gravatar_id":"","url":"https://api.github.com/users/triggerNZ","html_url":"https://github.com/triggerNZ","followers_url":"https://api.github.com/users/triggerNZ/followers","following_url":"https://api.github.com/users/triggerNZ/following{/other_user}","gists_url":"https://api.github.com/users/triggerNZ/gists{/gist_id}","starred_url":"https://api.github.com/users/triggerNZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/triggerNZ/subscriptions","organizations_url":"https://api.github.com/users/triggerNZ/orgs","repos_url":"https://api.github.com/users/triggerNZ/repos","events_url":"https://api.github.com/users/triggerNZ/events{/privacy}","received_events_url":"https://api.github.com/users/triggerNZ/received_events","type":"User","site_admin":false},"body":"I could go either way on this. Typically we try to ignore stuff generated by the build and leave OS and environment specific stuff to be ignored in your personal global `.gitignore`. But we do have `.idea`, so that kinda defeats my argument. @dkristian ?","created_at":"2016-07-12T00:28:17Z","updated_at":"2016-07-12T00:28:17Z","html_url":"https://github.com/CommBank/coppersmith/pull/41#discussion_r70360806","pull_request_url":"https://api.github.com/repos/CommBank/coppersmith/pulls/41","_links":{"self":{"href":"https://api.github.com/repos/CommBank/coppersmith/pulls/comments/70360806"},"html":{"href":"https://github.com/CommBank/coppersmith/pull/41#discussion_r70360806"},"pull_request":{"href":"https://api.github.com/repos/CommBank/coppersmith/pulls/41"}}},"pull_request":{"url":"https://api.github.com/repos/CommBank/coppersmith/pulls/41","id":76908211,"html_url":"https://github.com/CommBank/coppersmith/pull/41","diff_url":"https://github.com/CommBank/coppersmith/pull/41.diff","patch_url":"https://github.com/CommBank/coppersmith/pull/41.patch","issue_url":"https://api.github.com/repos/CommBank/coppersmith/issues/41","number":41,"state":"open","locked":false,"title":"Bool as a new Feature value type","user":{"login":"pmellati","id":2670251,"avatar_url":"https://avatars.githubusercontent.com/u/2670251?v=3","gravatar_id":"","url":"https://api.github.com/users/pmellati","html_url":"https://github.com/pmellati","followers_url":"https://api.github.com/users/pmellati/followers","following_url":"https://api.github.com/users/pmellati/following{/other_user}","gists_url":"https://api.github.com/users/pmellati/gists{/gist_id}","starred_url":"https://api.github.com/users/pmellati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmellati/subscriptions","organizations_url":"https://api.github.com/users/pmellati/orgs","repos_url":"https://api.github.com/users/pmellati/repos","events_url":"https://api.github.com/users/pmellati/events{/privacy}","received_events_url":"https://api.github.com/users/pmellati/received_events","type":"User","site_admin":false},"body":"Introduces `Bool` as a new `Feature.Value`.","created_at":"2016-07-11T07:09:02Z","updated_at":"2016-07-12T00:28:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9579614161283620b0bb8723e6e6d56e17b247f4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/CommBank/coppersmith/pulls/41/commits","review_comments_url":"https://api.github.com/repos/CommBank/coppersmith/pulls/41/comments","review_comment_url":"https://api.github.com/repos/CommBank/coppersmith/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CommBank/coppersmith/issues/41/comments","statuses_url":"https://api.github.com/repos/CommBank/coppersmith/statuses/deec379673a64ac59a25fca2091bf9071a1e2b63","head":{"label":"CommBank:boolFeatureValues","ref":"boolFeatureValues","sha":"deec379673a64ac59a25fca2091bf9071a1e2b63","user":{"login":"CommBank","id":4240076,"avatar_url":"https://avatars.githubusercontent.com/u/4240076?v=3","gravatar_id":"","url":"https://api.github.com/users/CommBank","html_url":"https://github.com/CommBank","followers_url":"https://api.github.com/users/CommBank/followers","following_url":"https://api.github.com/users/CommBank/following{/other_user}","gists_url":"https://api.github.com/users/CommBank/gists{/gist_id}","starred_url":"https://api.github.com/users/CommBank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CommBank/subscriptions","organizations_url":"https://api.github.com/users/CommBank/orgs","repos_url":"https://api.github.com/users/CommBank/repos","events_url":"https://api.github.com/users/CommBank/events{/privacy}","received_events_url":"https://api.github.com/users/CommBank/received_events","type":"Organization","site_admin":false},"repo":{"id":55942036,"name":"coppersmith","full_name":"CommBank/coppersmith","owner":{"login":"CommBank","id":4240076,"avatar_url":"https://avatars.githubusercontent.com/u/4240076?v=3","gravatar_id":"","url":"https://api.github.com/users/CommBank","html_url":"https://github.com/CommBank","followers_url":"https://api.github.com/users/CommBank/followers","following_url":"https://api.github.com/users/CommBank/following{/other_user}","gists_url":"https://api.github.com/users/CommBank/gists{/gist_id}","starred_url":"https://api.github.com/users/CommBank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CommBank/subscriptions","organizations_url":"https://api.github.com/users/CommBank/orgs","repos_url":"https://api.github.com/users/CommBank/repos","events_url":"https://api.github.com/users/CommBank/events{/privacy}","received_events_url":"https://api.github.com/users/CommBank/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CommBank/coppersmith","description":"Feature Engineering as Composable Functions","fork":false,"url":"https://api.github.com/repos/CommBank/coppersmith","forks_url":"https://api.github.com/repos/CommBank/coppersmith/forks","keys_url":"https://api.github.com/repos/CommBank/coppersmith/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CommBank/coppersmith/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CommBank/coppersmith/teams","hooks_url":"https://api.github.com/repos/CommBank/coppersmith/hooks","issue_events_url":"https://api.github.com/repos/CommBank/coppersmith/issues/events{/number}","events_url":"https://api.github.com/repos/CommBank/coppersmith/events","assignees_url":"https://api.github.com/repos/CommBank/coppersmith/assignees{/user}","branches_url":"https://api.github.com/repos/CommBank/coppersmith/branches{/branch}","tags_url":"https://api.github.com/repos/CommBank/coppersmith/tags","blobs_url":"https://api.github.com/repos/CommBank/coppersmith/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CommBank/coppersmith/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CommBank/coppersmith/git/refs{/sha}","trees_url":"https://api.github.com/repos/CommBank/coppersmith/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CommBank/coppersmith/statuses/{sha}","languages_url":"https://api.github.com/repos/CommBank/coppersmith/languages","stargazers_url":"https://api.github.com/repos/CommBank/coppersmith/stargazers","contributors_url":"https://api.github.com/repos/CommBank/coppersmith/contributors","subscribers_url":"https://api.github.com/repos/CommBank/coppersmith/subscribers","subscription_url":"https://api.github.com/repos/CommBank/coppersmith/subscription","commits_url":"https://api.github.com/repos/CommBank/coppersmith/commits{/sha}","git_commits_url":"https://api.github.com/repos/CommBank/coppersmith/git/commits{/sha}","comments_url":"https://api.github.com/repos/CommBank/coppersmith/comments{/number}","issue_comment_url":"https://api.github.com/repos/CommBank/coppersmith/issues/comments{/number}","contents_url":"https://api.github.com/repos/CommBank/coppersmith/contents/{+path}","compare_url":"https://api.github.com/repos/CommBank/coppersmith/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CommBank/coppersmith/merges","archive_url":"https://api.github.com/repos/CommBank/coppersmith/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CommBank/coppersmith/downloads","issues_url":"https://api.github.com/repos/CommBank/coppersmith/issues{/number}","pulls_url":"https://api.github.com/repos/CommBank/coppersmith/pulls{/number}","milestones_url":"https://api.github.com/repos/CommBank/coppersmith/milestones{/number}","notifications_url":"https://api.github.com/repos/CommBank/coppersmith/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CommBank/coppersmith/labels{/name}","releases_url":"https://api.github.com/repos/CommBank/coppersmith/releases{/id}","deployments_url":"https://api.github.com/repos/CommBank/coppersmith/deployments","created_at":"2016-04-11T04:38:16Z","updated_at":"2016-07-07T05:45:08Z","pushed_at":"2016-07-11T07:09:02Z","git_url":"git://github.com/CommBank/coppersmith.git","ssh_url":"git@github.com:CommBank/coppersmith.git","clone_url":"https://github.com/CommBank/coppersmith.git","svn_url":"https://github.com/CommBank/coppersmith","homepage":null,"size":975,"stargazers_count":17,"watchers_count":17,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":5,"forks":6,"open_issues":5,"watchers":17,"default_branch":"master"}},"base":{"label":"CommBank:master","ref":"master","sha":"09543c1703e19dfa302fc6659ae323a19becece9","user":{"login":"CommBank","id":4240076,"avatar_url":"https://avatars.githubusercontent.com/u/4240076?v=3","gravatar_id":"","url":"https://api.github.com/users/CommBank","html_url":"https://github.com/CommBank","followers_url":"https://api.github.com/users/CommBank/followers","following_url":"https://api.github.com/users/CommBank/following{/other_user}","gists_url":"https://api.github.com/users/CommBank/gists{/gist_id}","starred_url":"https://api.github.com/users/CommBank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CommBank/subscriptions","organizations_url":"https://api.github.com/users/CommBank/orgs","repos_url":"https://api.github.com/users/CommBank/repos","events_url":"https://api.github.com/users/CommBank/events{/privacy}","received_events_url":"https://api.github.com/users/CommBank/received_events","type":"Organization","site_admin":false},"repo":{"id":55942036,"name":"coppersmith","full_name":"CommBank/coppersmith","owner":{"login":"CommBank","id":4240076,"avatar_url":"https://avatars.githubusercontent.com/u/4240076?v=3","gravatar_id":"","url":"https://api.github.com/users/CommBank","html_url":"https://github.com/CommBank","followers_url":"https://api.github.com/users/CommBank/followers","following_url":"https://api.github.com/users/CommBank/following{/other_user}","gists_url":"https://api.github.com/users/CommBank/gists{/gist_id}","starred_url":"https://api.github.com/users/CommBank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CommBank/subscriptions","organizations_url":"https://api.github.com/users/CommBank/orgs","repos_url":"https://api.github.com/users/CommBank/repos","events_url":"https://api.github.com/users/CommBank/events{/privacy}","received_events_url":"https://api.github.com/users/CommBank/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CommBank/coppersmith","description":"Feature Engineering as Composable Functions","fork":false,"url":"https://api.github.com/repos/CommBank/coppersmith","forks_url":"https://api.github.com/repos/CommBank/coppersmith/forks","keys_url":"https://api.github.com/repos/CommBank/coppersmith/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CommBank/coppersmith/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CommBank/coppersmith/teams","hooks_url":"https://api.github.com/repos/CommBank/coppersmith/hooks","issue_events_url":"https://api.github.com/repos/CommBank/coppersmith/issues/events{/number}","events_url":"https://api.github.com/repos/CommBank/coppersmith/events","assignees_url":"https://api.github.com/repos/CommBank/coppersmith/assignees{/user}","branches_url":"https://api.github.com/repos/CommBank/coppersmith/branches{/branch}","tags_url":"https://api.github.com/repos/CommBank/coppersmith/tags","blobs_url":"https://api.github.com/repos/CommBank/coppersmith/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CommBank/coppersmith/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CommBank/coppersmith/git/refs{/sha}","trees_url":"https://api.github.com/repos/CommBank/coppersmith/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CommBank/coppersmith/statuses/{sha}","languages_url":"https://api.github.com/repos/CommBank/coppersmith/languages","stargazers_url":"https://api.github.com/repos/CommBank/coppersmith/stargazers","contributors_url":"https://api.github.com/repos/CommBank/coppersmith/contributors","subscribers_url":"https://api.github.com/repos/CommBank/coppersmith/subscribers","subscription_url":"https://api.github.com/repos/CommBank/coppersmith/subscription","commits_url":"https://api.github.com/repos/CommBank/coppersmith/commits{/sha}","git_commits_url":"https://api.github.com/repos/CommBank/coppersmith/git/commits{/sha}","comments_url":"https://api.github.com/repos/CommBank/coppersmith/comments{/number}","issue_comment_url":"https://api.github.com/repos/CommBank/coppersmith/issues/comments{/number}","contents_url":"https://api.github.com/repos/CommBank/coppersmith/contents/{+path}","compare_url":"https://api.github.com/repos/CommBank/coppersmith/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CommBank/coppersmith/merges","archive_url":"https://api.github.com/repos/CommBank/coppersmith/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CommBank/coppersmith/downloads","issues_url":"https://api.github.com/repos/CommBank/coppersmith/issues{/number}","pulls_url":"https://api.github.com/repos/CommBank/coppersmith/pulls{/number}","milestones_url":"https://api.github.com/repos/CommBank/coppersmith/milestones{/number}","notifications_url":"https://api.github.com/repos/CommBank/coppersmith/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CommBank/coppersmith/labels{/name}","releases_url":"https://api.github.com/repos/CommBank/coppersmith/releases{/id}","deployments_url":"https://api.github.com/repos/CommBank/coppersmith/deployments","created_at":"2016-04-11T04:38:16Z","updated_at":"2016-07-07T05:45:08Z","pushed_at":"2016-07-11T07:09:02Z","git_url":"git://github.com/CommBank/coppersmith.git","ssh_url":"git@github.com:CommBank/coppersmith.git","clone_url":"https://github.com/CommBank/coppersmith.git","svn_url":"https://github.com/CommBank/coppersmith","homepage":null,"size":975,"stargazers_count":17,"watchers_count":17,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":5,"forks":6,"open_issues":5,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CommBank/coppersmith/pulls/41"},"html":{"href":"https://github.com/CommBank/coppersmith/pull/41"},"issue":{"href":"https://api.github.com/repos/CommBank/coppersmith/issues/41"},"comments":{"href":"https://api.github.com/repos/CommBank/coppersmith/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/CommBank/coppersmith/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/CommBank/coppersmith/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CommBank/coppersmith/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/CommBank/coppersmith/statuses/deec379673a64ac59a25fca2091bf9071a1e2b63"}}}}
{"actor":{"display_login":"triggerNZ"}}