{"action":"created","comment":{"url":"https://api.github.com/repos/C5T/Current/pulls/comments/88444918","pull_request_review_id":9017648,"id":88444918,"diff_hunk":"@@ -227,7 +318,7 @@ TEST(FNCAS, OptimizationOfRosenbrockUsingConjugateGradient) {\n   EXPECT_NEAR(1.0, result.point[1], 1e-6);\n }\n \n-TEST(FNCAS, OptimizationOfHimmelbaluUsingCojugateGradient) {\n+TEST(FNCAS, OptimizationOfHimmelblauUsingCojugateGradient) {","path":"FnCAS/test.cc","position":223,"original_position":223,"commit_id":"c7920fc74c7237e01b0ba3ec53dc7eeae32b3652","original_commit_id":"c7920fc74c7237e01b0ba3ec53dc7eeae32b3652","user":{"login":"mzhurovich","id":11226961,"avatar_url":"https://avatars.githubusercontent.com/u/11226961?v=3","gravatar_id":"","url":"https://api.github.com/users/mzhurovich","html_url":"https://github.com/mzhurovich","followers_url":"https://api.github.com/users/mzhurovich/followers","following_url":"https://api.github.com/users/mzhurovich/following{/other_user}","gists_url":"https://api.github.com/users/mzhurovich/gists{/gist_id}","starred_url":"https://api.github.com/users/mzhurovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzhurovich/subscriptions","organizations_url":"https://api.github.com/users/mzhurovich/orgs","repos_url":"https://api.github.com/users/mzhurovich/repos","events_url":"https://api.github.com/users/mzhurovich/events{/privacy}","received_events_url":"https://api.github.com/users/mzhurovich/received_events","type":"User","site_admin":false},"body":"s/Cojugate/Conjugate/","created_at":"2016-11-17T12:49:49Z","updated_at":"2016-11-17T12:49:49Z","html_url":"https://github.com/C5T/Current/pull/687#discussion_r88444918","pull_request_url":"https://api.github.com/repos/C5T/Current/pulls/687","_links":{"self":{"href":"https://api.github.com/repos/C5T/Current/pulls/comments/88444918"},"html":{"href":"https://github.com/C5T/Current/pull/687#discussion_r88444918"},"pull_request":{"href":"https://api.github.com/repos/C5T/Current/pulls/687"}}},"pull_request":{"url":"https://api.github.com/repos/C5T/Current/pulls/687","id":93506394,"html_url":"https://github.com/C5T/Current/pull/687","diff_url":"https://github.com/C5T/Current/pull/687.diff","patch_url":"https://github.com/C5T/Current/pull/687.patch","issue_url":"https://api.github.com/repos/C5T/Current/issues/687","number":687,"state":"open","locked":false,"title":"FnCAS: Allowed member function optimization.","user":{"login":"dkorolev","id":2159447,"avatar_url":"https://avatars.githubusercontent.com/u/2159447?v=3","gravatar_id":"","url":"https://api.github.com/users/dkorolev","html_url":"https://github.com/dkorolev","followers_url":"https://api.github.com/users/dkorolev/followers","following_url":"https://api.github.com/users/dkorolev/following{/other_user}","gists_url":"https://api.github.com/users/dkorolev/gists{/gist_id}","starred_url":"https://api.github.com/users/dkorolev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkorolev/subscriptions","organizations_url":"https://api.github.com/users/dkorolev/orgs","repos_url":"https://api.github.com/users/dkorolev/repos","events_url":"https://api.github.com/users/dkorolev/events{/privacy}","received_events_url":"https://api.github.com/users/dkorolev/received_events","type":"User","site_admin":false},"body":"Hi @mzhurovich,\r\n\r\nAdded member functions optimization alongside the existing optimization of static functions.\r\n\r\nSome refactoring as well, but nothing beyond just keeping this 3+ years code in line with our modern guide.\r\n\r\nAlso, ran the integration and performance test (both under `deprecated_test/`). They both passed.\r\n\r\nThanks,\r\nDima","created_at":"2016-11-14T04:23:05Z","updated_at":"2016-11-17T12:49:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc3434892a722c6b8c27e9535df5a589c1a65f3a","assignee":{"login":"mzhurovich","id":11226961,"avatar_url":"https://avatars.githubusercontent.com/u/11226961?v=3","gravatar_id":"","url":"https://api.github.com/users/mzhurovich","html_url":"https://github.com/mzhurovich","followers_url":"https://api.github.com/users/mzhurovich/followers","following_url":"https://api.github.com/users/mzhurovich/following{/other_user}","gists_url":"https://api.github.com/users/mzhurovich/gists{/gist_id}","starred_url":"https://api.github.com/users/mzhurovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzhurovich/subscriptions","organizations_url":"https://api.github.com/users/mzhurovich/orgs","repos_url":"https://api.github.com/users/mzhurovich/repos","events_url":"https://api.github.com/users/mzhurovich/events{/privacy}","received_events_url":"https://api.github.com/users/mzhurovich/received_events","type":"User","site_admin":false},"assignees":[{"login":"mzhurovich","id":11226961,"avatar_url":"https://avatars.githubusercontent.com/u/11226961?v=3","gravatar_id":"","url":"https://api.github.com/users/mzhurovich","html_url":"https://github.com/mzhurovich","followers_url":"https://api.github.com/users/mzhurovich/followers","following_url":"https://api.github.com/users/mzhurovich/following{/other_user}","gists_url":"https://api.github.com/users/mzhurovich/gists{/gist_id}","starred_url":"https://api.github.com/users/mzhurovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzhurovich/subscriptions","organizations_url":"https://api.github.com/users/mzhurovich/orgs","repos_url":"https://api.github.com/users/mzhurovich/repos","events_url":"https://api.github.com/users/mzhurovich/events{/privacy}","received_events_url":"https://api.github.com/users/mzhurovich/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/C5T/Current/pulls/687/commits","review_comments_url":"https://api.github.com/repos/C5T/Current/pulls/687/comments","review_comment_url":"https://api.github.com/repos/C5T/Current/pulls/comments{/number}","comments_url":"https://api.github.com/repos/C5T/Current/issues/687/comments","statuses_url":"https://api.github.com/repos/C5T/Current/statuses/c7920fc74c7237e01b0ba3ec53dc7eeae32b3652","head":{"label":"dkorolev:fncas","ref":"fncas","sha":"c7920fc74c7237e01b0ba3ec53dc7eeae32b3652","user":{"login":"dkorolev","id":2159447,"avatar_url":"https://avatars.githubusercontent.com/u/2159447?v=3","gravatar_id":"","url":"https://api.github.com/users/dkorolev","html_url":"https://github.com/dkorolev","followers_url":"https://api.github.com/users/dkorolev/followers","following_url":"https://api.github.com/users/dkorolev/following{/other_user}","gists_url":"https://api.github.com/users/dkorolev/gists{/gist_id}","starred_url":"https://api.github.com/users/dkorolev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkorolev/subscriptions","organizations_url":"https://api.github.com/users/dkorolev/orgs","repos_url":"https://api.github.com/users/dkorolev/repos","events_url":"https://api.github.com/users/dkorolev/events{/privacy}","received_events_url":"https://api.github.com/users/dkorolev/received_events","type":"User","site_admin":false},"repo":{"id":27625438,"name":"Current","full_name":"dkorolev/Current","owner":{"login":"dkorolev","id":2159447,"avatar_url":"https://avatars.githubusercontent.com/u/2159447?v=3","gravatar_id":"","url":"https://api.github.com/users/dkorolev","html_url":"https://github.com/dkorolev","followers_url":"https://api.github.com/users/dkorolev/followers","following_url":"https://api.github.com/users/dkorolev/following{/other_user}","gists_url":"https://api.github.com/users/dkorolev/gists{/gist_id}","starred_url":"https://api.github.com/users/dkorolev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkorolev/subscriptions","organizations_url":"https://api.github.com/users/dkorolev/orgs","repos_url":"https://api.github.com/users/dkorolev/repos","events_url":"https://api.github.com/users/dkorolev/events{/privacy}","received_events_url":"https://api.github.com/users/dkorolev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dkorolev/Current","description":"Data Infrastructure in a Box:","fork":true,"url":"https://api.github.com/repos/dkorolev/Current","forks_url":"https://api.github.com/repos/dkorolev/Current/forks","keys_url":"https://api.github.com/repos/dkorolev/Current/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dkorolev/Current/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dkorolev/Current/teams","hooks_url":"https://api.github.com/repos/dkorolev/Current/hooks","issue_events_url":"https://api.github.com/repos/dkorolev/Current/issues/events{/number}","events_url":"https://api.github.com/repos/dkorolev/Current/events","assignees_url":"https://api.github.com/repos/dkorolev/Current/assignees{/user}","branches_url":"https://api.github.com/repos/dkorolev/Current/branches{/branch}","tags_url":"https://api.github.com/repos/dkorolev/Current/tags","blobs_url":"https://api.github.com/repos/dkorolev/Current/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dkorolev/Current/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dkorolev/Current/git/refs{/sha}","trees_url":"https://api.github.com/repos/dkorolev/Current/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dkorolev/Current/statuses/{sha}","languages_url":"https://api.github.com/repos/dkorolev/Current/languages","stargazers_url":"https://api.github.com/repos/dkorolev/Current/stargazers","contributors_url":"https://api.github.com/repos/dkorolev/Current/contributors","subscribers_url":"https://api.github.com/repos/dkorolev/Current/subscribers","subscription_url":"https://api.github.com/repos/dkorolev/Current/subscription","commits_url":"https://api.github.com/repos/dkorolev/Current/commits{/sha}","git_commits_url":"https://api.github.com/repos/dkorolev/Current/git/commits{/sha}","comments_url":"https://api.github.com/repos/dkorolev/Current/comments{/number}","issue_comment_url":"https://api.github.com/repos/dkorolev/Current/issues/comments{/number}","contents_url":"https://api.github.com/repos/dkorolev/Current/contents/{+path}","compare_url":"https://api.github.com/repos/dkorolev/Current/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dkorolev/Current/merges","archive_url":"https://api.github.com/repos/dkorolev/Current/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dkorolev/Current/downloads","issues_url":"https://api.github.com/repos/dkorolev/Current/issues{/number}","pulls_url":"https://api.github.com/repos/dkorolev/Current/pulls{/number}","milestones_url":"https://api.github.com/repos/dkorolev/Current/milestones{/number}","notifications_url":"https://api.github.com/repos/dkorolev/Current/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dkorolev/Current/labels{/name}","releases_url":"https://api.github.com/repos/dkorolev/Current/releases{/id}","deployments_url":"https://api.github.com/repos/dkorolev/Current/deployments","created_at":"2014-12-06T06:52:51Z","updated_at":"2016-10-22T05:39:22Z","pushed_at":"2016-11-16T19:19:00Z","git_url":"git://github.com/dkorolev/Current.git","ssh_url":"git@github.com:dkorolev/Current.git","clone_url":"https://github.com/dkorolev/Current.git","svn_url":"https://github.com/dkorolev/Current","homepage":"http://dima.ai/static/current.pdf","size":13650,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"C5T:master","ref":"master","sha":"21f957361a814b0171a1d5b9658eb02c0b480324","user":{"login":"C5T","id":12224789,"avatar_url":"https://avatars.githubusercontent.com/u/12224789?v=3","gravatar_id":"","url":"https://api.github.com/users/C5T","html_url":"https://github.com/C5T","followers_url":"https://api.github.com/users/C5T/followers","following_url":"https://api.github.com/users/C5T/following{/other_user}","gists_url":"https://api.github.com/users/C5T/gists{/gist_id}","starred_url":"https://api.github.com/users/C5T/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/C5T/subscriptions","organizations_url":"https://api.github.com/users/C5T/orgs","repos_url":"https://api.github.com/users/C5T/repos","events_url":"https://api.github.com/users/C5T/events{/privacy}","received_events_url":"https://api.github.com/users/C5T/received_events","type":"Organization","site_admin":false},"repo":{"id":27625425,"name":"Current","full_name":"C5T/Current","owner":{"login":"C5T","id":12224789,"avatar_url":"https://avatars.githubusercontent.com/u/12224789?v=3","gravatar_id":"","url":"https://api.github.com/users/C5T","html_url":"https://github.com/C5T","followers_url":"https://api.github.com/users/C5T/followers","following_url":"https://api.github.com/users/C5T/following{/other_user}","gists_url":"https://api.github.com/users/C5T/gists{/gist_id}","starred_url":"https://api.github.com/users/C5T/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/C5T/subscriptions","organizations_url":"https://api.github.com/users/C5T/orgs","repos_url":"https://api.github.com/users/C5T/repos","events_url":"https://api.github.com/users/C5T/events{/privacy}","received_events_url":"https://api.github.com/users/C5T/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/C5T/Current","description":"Data Infrastructure in a Box.","fork":false,"url":"https://api.github.com/repos/C5T/Current","forks_url":"https://api.github.com/repos/C5T/Current/forks","keys_url":"https://api.github.com/repos/C5T/Current/keys{/key_id}","collaborators_url":"https://api.github.com/repos/C5T/Current/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/C5T/Current/teams","hooks_url":"https://api.github.com/repos/C5T/Current/hooks","issue_events_url":"https://api.github.com/repos/C5T/Current/issues/events{/number}","events_url":"https://api.github.com/repos/C5T/Current/events","assignees_url":"https://api.github.com/repos/C5T/Current/assignees{/user}","branches_url":"https://api.github.com/repos/C5T/Current/branches{/branch}","tags_url":"https://api.github.com/repos/C5T/Current/tags","blobs_url":"https://api.github.com/repos/C5T/Current/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/C5T/Current/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/C5T/Current/git/refs{/sha}","trees_url":"https://api.github.com/repos/C5T/Current/git/trees{/sha}","statuses_url":"https://api.github.com/repos/C5T/Current/statuses/{sha}","languages_url":"https://api.github.com/repos/C5T/Current/languages","stargazers_url":"https://api.github.com/repos/C5T/Current/stargazers","contributors_url":"https://api.github.com/repos/C5T/Current/contributors","subscribers_url":"https://api.github.com/repos/C5T/Current/subscribers","subscription_url":"https://api.github.com/repos/C5T/Current/subscription","commits_url":"https://api.github.com/repos/C5T/Current/commits{/sha}","git_commits_url":"https://api.github.com/repos/C5T/Current/git/commits{/sha}","comments_url":"https://api.github.com/repos/C5T/Current/comments{/number}","issue_comment_url":"https://api.github.com/repos/C5T/Current/issues/comments{/number}","contents_url":"https://api.github.com/repos/C5T/Current/contents/{+path}","compare_url":"https://api.github.com/repos/C5T/Current/compare/{base}...{head}","merges_url":"https://api.github.com/repos/C5T/Current/merges","archive_url":"https://api.github.com/repos/C5T/Current/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/C5T/Current/downloads","issues_url":"https://api.github.com/repos/C5T/Current/issues{/number}","pulls_url":"https://api.github.com/repos/C5T/Current/pulls{/number}","milestones_url":"https://api.github.com/repos/C5T/Current/milestones{/number}","notifications_url":"https://api.github.com/repos/C5T/Current/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/C5T/Current/labels{/name}","releases_url":"https://api.github.com/repos/C5T/Current/releases{/id}","deployments_url":"https://api.github.com/repos/C5T/Current/deployments","created_at":"2014-12-06T06:52:23Z","updated_at":"2016-10-24T14:02:04Z","pushed_at":"2016-11-16T21:06:04Z","git_url":"git://github.com/C5T/Current.git","ssh_url":"git@github.com:C5T/Current.git","clone_url":"https://github.com/C5T/Current.git","svn_url":"https://github.com/C5T/Current","homepage":"http://dima.ai/static/current.pdf","size":13522,"stargazers_count":29,"watchers_count":29,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":15,"forks":12,"open_issues":15,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/C5T/Current/pulls/687"},"html":{"href":"https://github.com/C5T/Current/pull/687"},"issue":{"href":"https://api.github.com/repos/C5T/Current/issues/687"},"comments":{"href":"https://api.github.com/repos/C5T/Current/issues/687/comments"},"review_comments":{"href":"https://api.github.com/repos/C5T/Current/pulls/687/comments"},"review_comment":{"href":"https://api.github.com/repos/C5T/Current/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/C5T/Current/pulls/687/commits"},"statuses":{"href":"https://api.github.com/repos/C5T/Current/statuses/c7920fc74c7237e01b0ba3ec53dc7eeae32b3652"}}}}
{"actor":{"display_login":"mzhurovich"}}