{"action":"created","issue":{"url":"https://api.github.com/repos/ImageEngine/gaffer/issues/1864","repository_url":"https://api.github.com/repos/ImageEngine/gaffer","labels_url":"https://api.github.com/repos/ImageEngine/gaffer/issues/1864/labels{/name}","comments_url":"https://api.github.com/repos/ImageEngine/gaffer/issues/1864/comments","events_url":"https://api.github.com/repos/ImageEngine/gaffer/issues/1864/events","html_url":"https://github.com/ImageEngine/gaffer/pull/1864","id":179844409,"number":1864,"title":"ArnoldShader UI improvements","user":{"login":"johnhaddon","id":1133871,"avatar_url":"https://avatars.githubusercontent.com/u/1133871?v=3","gravatar_id":"","url":"https://api.github.com/users/johnhaddon","html_url":"https://github.com/johnhaddon","followers_url":"https://api.github.com/users/johnhaddon/followers","following_url":"https://api.github.com/users/johnhaddon/following{/other_user}","gists_url":"https://api.github.com/users/johnhaddon/gists{/gist_id}","starred_url":"https://api.github.com/users/johnhaddon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnhaddon/subscriptions","organizations_url":"https://api.github.com/users/johnhaddon/orgs","repos_url":"https://api.github.com/users/johnhaddon/repos","events_url":"https://api.github.com/users/johnhaddon/events{/privacy}","received_events_url":"https://api.github.com/users/johnhaddon/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-09-28T18:04:17Z","updated_at":"2016-09-29T16:39:33Z","closed_at":"2016-09-29T16:11:09Z","pull_request":{"url":"https://api.github.com/repos/ImageEngine/gaffer/pulls/1864","html_url":"https://github.com/ImageEngine/gaffer/pull/1864","diff_url":"https://github.com/ImageEngine/gaffer/pull/1864.diff","patch_url":"https://github.com/ImageEngine/gaffer/pull/1864.patch"},"body":"This adds support for both OSL and Houdini style metadata for defining the UI for ArnoldShaders. OSL style because that is what we have standardised on for RSL and OSL shaders, and Houdini style because that is what is available out-of-the-box with the AlShaders. This means we now have a half decent layouts in the NodeEditor for the AlSurface.\r\n\r\n![alsurface](https://cloud.githubusercontent.com/assets/1133871/18925926/b004b476-85ad-11e6-8cbc-d93039e62955.png)\r\n\r\nThe eagle eyed might notice some strange matte parameters outside of any section in the screenshot. This appears to be a problem in the AlSurface metadata - those parameters are not given any section. In Houdini, that means they end up out of the tab container entirely, but at the bottom, and in Gaffer it means they end up out of the section, but at the top. Really this needs to be fixed on the AlShaders side, but I could hack in some overrides into this PR if folks think that would be useful in the short term."},"comment":{"url":"https://api.github.com/repos/ImageEngine/gaffer/issues/comments/250522183","html_url":"https://github.com/ImageEngine/gaffer/pull/1864#issuecomment-250522183","issue_url":"https://api.github.com/repos/ImageEngine/gaffer/issues/1864","id":250522183,"user":{"login":"thiasbxl","id":5577929,"avatar_url":"https://avatars.githubusercontent.com/u/5577929?v=3","gravatar_id":"","url":"https://api.github.com/users/thiasbxl","html_url":"https://github.com/thiasbxl","followers_url":"https://api.github.com/users/thiasbxl/followers","following_url":"https://api.github.com/users/thiasbxl/following{/other_user}","gists_url":"https://api.github.com/users/thiasbxl/gists{/gist_id}","starred_url":"https://api.github.com/users/thiasbxl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thiasbxl/subscriptions","organizations_url":"https://api.github.com/users/thiasbxl/orgs","repos_url":"https://api.github.com/users/thiasbxl/repos","events_url":"https://api.github.com/users/thiasbxl/events{/privacy}","received_events_url":"https://api.github.com/users/thiasbxl/received_events","type":"User","site_admin":false},"created_at":"2016-09-29T16:39:33Z","updated_at":"2016-09-29T16:39:33Z","body":"Nesting the parameters in collapsible sections is going to be a big improvement over the current flat stacking. I don't really like the idea of having a lot of tabs to access the different components, this approach tends to stretch UIs horizontally which isn't ideal from a layout and usability POV. I prefer a mostly vertical layout in this case."}}
{"actor":{"display_login":"thiasbxl"}}