{"action":"created","comment":{"url":"https://api.github.com/repos/JabRef/jabref/pulls/comments/56794924","id":56794924,"diff_hunk":"@@ -158,30 +156,33 @@ public synchronized BibEntry getEntryByKey(String key) {\n      * use Util.createId(...) to make up a unique ID for an entry.\n      */\n     public synchronized boolean insertEntry(BibEntry entry) throws KeyCollisionException {\n+        if (entry == null){","path":"src/main/java/net/sf/jabref/model/database/BibDatabase.java","position":28,"original_position":28,"commit_id":"29d3ab8a5dc9852dcf546c8164152861744021f3","original_commit_id":"29d3ab8a5dc9852dcf546c8164152861744021f3","user":{"login":"tobiasdiez","id":5037600,"avatar_url":"https://avatars.githubusercontent.com/u/5037600?v=3","gravatar_id":"","url":"https://api.github.com/users/tobiasdiez","html_url":"https://github.com/tobiasdiez","followers_url":"https://api.github.com/users/tobiasdiez/followers","following_url":"https://api.github.com/users/tobiasdiez/following{/other_user}","gists_url":"https://api.github.com/users/tobiasdiez/gists{/gist_id}","starred_url":"https://api.github.com/users/tobiasdiez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobiasdiez/subscriptions","organizations_url":"https://api.github.com/users/tobiasdiez/orgs","repos_url":"https://api.github.com/users/tobiasdiez/repos","events_url":"https://api.github.com/users/tobiasdiez/events{/privacy}","received_events_url":"https://api.github.com/users/tobiasdiez/received_events","type":"User","site_admin":false},"body":"I think Objects.requireNonNull is more appropriate here.","created_at":"2016-03-21T09:13:54Z","updated_at":"2016-03-21T09:13:54Z","html_url":"https://github.com/JabRef/jabref/pull/996#discussion_r56794924","pull_request_url":"https://api.github.com/repos/JabRef/jabref/pulls/996","_links":{"self":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/comments/56794924"},"html":{"href":"https://github.com/JabRef/jabref/pull/996#discussion_r56794924"},"pull_request":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/996"}}},"pull_request":{"url":"https://api.github.com/repos/JabRef/jabref/pulls/996","id":63396161,"html_url":"https://github.com/JabRef/jabref/pull/996","diff_url":"https://github.com/JabRef/jabref/pull/996.diff","patch_url":"https://github.com/JabRef/jabref/pull/996.patch","issue_url":"https://api.github.com/repos/JabRef/jabref/issues/996","number":996,"state":"open","locked":false,"title":"fix entry deletion from database","user":{"login":"bartsch-dev","id":15333371,"avatar_url":"https://avatars.githubusercontent.com/u/15333371?v=3","gravatar_id":"","url":"https://api.github.com/users/bartsch-dev","html_url":"https://github.com/bartsch-dev","followers_url":"https://api.github.com/users/bartsch-dev/followers","following_url":"https://api.github.com/users/bartsch-dev/following{/other_user}","gists_url":"https://api.github.com/users/bartsch-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/bartsch-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartsch-dev/subscriptions","organizations_url":"https://api.github.com/users/bartsch-dev/orgs","repos_url":"https://api.github.com/users/bartsch-dev/repos","events_url":"https://api.github.com/users/bartsch-dev/events{/privacy}","received_events_url":"https://api.github.com/users/bartsch-dev/received_events","type":"User","site_admin":false},"body":"Fixes #991, a Bug introduced in b3aee00bae8b589aa1252ef182f8b3293d06bd69.\r\n\r\nWhile moving from `Map` to `List` as the data structure for the stored `BibEntries` is has been forgotten to adjust the `removeEntry`-Method.\r\n\r\n- [x] Change in CHANGELOG.md described?\r\n- [x] Changes in pull request outlined? (What, why, ...)\r\n- [x] Tests created for changes?\r\n- [x] Tests green?\r\n\r\n","created_at":"2016-03-18T15:58:01Z","updated_at":"2016-03-21T09:13:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68c1773320277ec7468ab54e483b3600aa853731","assignee":{"login":"bartsch-dev","id":15333371,"avatar_url":"https://avatars.githubusercontent.com/u/15333371?v=3","gravatar_id":"","url":"https://api.github.com/users/bartsch-dev","html_url":"https://github.com/bartsch-dev","followers_url":"https://api.github.com/users/bartsch-dev/followers","following_url":"https://api.github.com/users/bartsch-dev/following{/other_user}","gists_url":"https://api.github.com/users/bartsch-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/bartsch-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartsch-dev/subscriptions","organizations_url":"https://api.github.com/users/bartsch-dev/orgs","repos_url":"https://api.github.com/users/bartsch-dev/repos","events_url":"https://api.github.com/users/bartsch-dev/events{/privacy}","received_events_url":"https://api.github.com/users/bartsch-dev/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/JabRef/jabref/milestones/6","html_url":"https://github.com/JabRef/jabref/milestones/v3.3","labels_url":"https://api.github.com/repos/JabRef/jabref/milestones/6/labels","id":1491548,"number":6,"title":"v3.3","description":"","creator":{"login":"koppor","id":1366654,"avatar_url":"https://avatars.githubusercontent.com/u/1366654?v=3","gravatar_id":"","url":"https://api.github.com/users/koppor","html_url":"https://github.com/koppor","followers_url":"https://api.github.com/users/koppor/followers","following_url":"https://api.github.com/users/koppor/following{/other_user}","gists_url":"https://api.github.com/users/koppor/gists{/gist_id}","starred_url":"https://api.github.com/users/koppor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koppor/subscriptions","organizations_url":"https://api.github.com/users/koppor/orgs","repos_url":"https://api.github.com/users/koppor/repos","events_url":"https://api.github.com/users/koppor/events{/privacy}","received_events_url":"https://api.github.com/users/koppor/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":25,"state":"open","created_at":"2016-01-08T14:44:29Z","updated_at":"2016-03-20T11:39:33Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/JabRef/jabref/pulls/996/commits","review_comments_url":"https://api.github.com/repos/JabRef/jabref/pulls/996/comments","review_comment_url":"https://api.github.com/repos/JabRef/jabref/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JabRef/jabref/issues/996/comments","statuses_url":"https://api.github.com/repos/JabRef/jabref/statuses/29d3ab8a5dc9852dcf546c8164152861744021f3","head":{"label":"bartsch-dev:fixEntryDeletion","ref":"fixEntryDeletion","sha":"29d3ab8a5dc9852dcf546c8164152861744021f3","user":{"login":"bartsch-dev","id":15333371,"avatar_url":"https://avatars.githubusercontent.com/u/15333371?v=3","gravatar_id":"","url":"https://api.github.com/users/bartsch-dev","html_url":"https://github.com/bartsch-dev","followers_url":"https://api.github.com/users/bartsch-dev/followers","following_url":"https://api.github.com/users/bartsch-dev/following{/other_user}","gists_url":"https://api.github.com/users/bartsch-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/bartsch-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartsch-dev/subscriptions","organizations_url":"https://api.github.com/users/bartsch-dev/orgs","repos_url":"https://api.github.com/users/bartsch-dev/repos","events_url":"https://api.github.com/users/bartsch-dev/events{/privacy}","received_events_url":"https://api.github.com/users/bartsch-dev/received_events","type":"User","site_admin":false},"repo":{"id":45906343,"name":"jabref","full_name":"bartsch-dev/jabref","owner":{"login":"bartsch-dev","id":15333371,"avatar_url":"https://avatars.githubusercontent.com/u/15333371?v=3","gravatar_id":"","url":"https://api.github.com/users/bartsch-dev","html_url":"https://github.com/bartsch-dev","followers_url":"https://api.github.com/users/bartsch-dev/followers","following_url":"https://api.github.com/users/bartsch-dev/following{/other_user}","gists_url":"https://api.github.com/users/bartsch-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/bartsch-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartsch-dev/subscriptions","organizations_url":"https://api.github.com/users/bartsch-dev/orgs","repos_url":"https://api.github.com/users/bartsch-dev/repos","events_url":"https://api.github.com/users/bartsch-dev/events{/privacy}","received_events_url":"https://api.github.com/users/bartsch-dev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bartsch-dev/jabref","description":"Graphical Java application for managing bibtex (.bib) databases","fork":true,"url":"https://api.github.com/repos/bartsch-dev/jabref","forks_url":"https://api.github.com/repos/bartsch-dev/jabref/forks","keys_url":"https://api.github.com/repos/bartsch-dev/jabref/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bartsch-dev/jabref/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bartsch-dev/jabref/teams","hooks_url":"https://api.github.com/repos/bartsch-dev/jabref/hooks","issue_events_url":"https://api.github.com/repos/bartsch-dev/jabref/issues/events{/number}","events_url":"https://api.github.com/repos/bartsch-dev/jabref/events","assignees_url":"https://api.github.com/repos/bartsch-dev/jabref/assignees{/user}","branches_url":"https://api.github.com/repos/bartsch-dev/jabref/branches{/branch}","tags_url":"https://api.github.com/repos/bartsch-dev/jabref/tags","blobs_url":"https://api.github.com/repos/bartsch-dev/jabref/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bartsch-dev/jabref/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bartsch-dev/jabref/git/refs{/sha}","trees_url":"https://api.github.com/repos/bartsch-dev/jabref/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bartsch-dev/jabref/statuses/{sha}","languages_url":"https://api.github.com/repos/bartsch-dev/jabref/languages","stargazers_url":"https://api.github.com/repos/bartsch-dev/jabref/stargazers","contributors_url":"https://api.github.com/repos/bartsch-dev/jabref/contributors","subscribers_url":"https://api.github.com/repos/bartsch-dev/jabref/subscribers","subscription_url":"https://api.github.com/repos/bartsch-dev/jabref/subscription","commits_url":"https://api.github.com/repos/bartsch-dev/jabref/commits{/sha}","git_commits_url":"https://api.github.com/repos/bartsch-dev/jabref/git/commits{/sha}","comments_url":"https://api.github.com/repos/bartsch-dev/jabref/comments{/number}","issue_comment_url":"https://api.github.com/repos/bartsch-dev/jabref/issues/comments{/number}","contents_url":"https://api.github.com/repos/bartsch-dev/jabref/contents/{+path}","compare_url":"https://api.github.com/repos/bartsch-dev/jabref/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bartsch-dev/jabref/merges","archive_url":"https://api.github.com/repos/bartsch-dev/jabref/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bartsch-dev/jabref/downloads","issues_url":"https://api.github.com/repos/bartsch-dev/jabref/issues{/number}","pulls_url":"https://api.github.com/repos/bartsch-dev/jabref/pulls{/number}","milestones_url":"https://api.github.com/repos/bartsch-dev/jabref/milestones{/number}","notifications_url":"https://api.github.com/repos/bartsch-dev/jabref/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bartsch-dev/jabref/labels{/name}","releases_url":"https://api.github.com/repos/bartsch-dev/jabref/releases{/id}","deployments_url":"https://api.github.com/repos/bartsch-dev/jabref/deployments","created_at":"2015-11-10T11:01:40Z","updated_at":"2016-01-11T14:41:19Z","pushed_at":"2016-03-21T08:50:02Z","git_url":"git://github.com/bartsch-dev/jabref.git","ssh_url":"git@github.com:bartsch-dev/jabref.git","clone_url":"https://github.com/bartsch-dev/jabref.git","svn_url":"https://github.com/bartsch-dev/jabref","homepage":"http://jabref.sourceforge.net/","size":80808,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JabRef:master","ref":"master","sha":"ba4e3ae42ed9bc8b1c5cfbcdaf51990b2231e6b4","user":{"login":"JabRef","id":3914421,"avatar_url":"https://avatars.githubusercontent.com/u/3914421?v=3","gravatar_id":"","url":"https://api.github.com/users/JabRef","html_url":"https://github.com/JabRef","followers_url":"https://api.github.com/users/JabRef/followers","following_url":"https://api.github.com/users/JabRef/following{/other_user}","gists_url":"https://api.github.com/users/JabRef/gists{/gist_id}","starred_url":"https://api.github.com/users/JabRef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JabRef/subscriptions","organizations_url":"https://api.github.com/users/JabRef/orgs","repos_url":"https://api.github.com/users/JabRef/repos","events_url":"https://api.github.com/users/JabRef/events{/privacy}","received_events_url":"https://api.github.com/users/JabRef/received_events","type":"Organization","site_admin":false},"repo":{"id":17634071,"name":"jabref","full_name":"JabRef/jabref","owner":{"login":"JabRef","id":3914421,"avatar_url":"https://avatars.githubusercontent.com/u/3914421?v=3","gravatar_id":"","url":"https://api.github.com/users/JabRef","html_url":"https://github.com/JabRef","followers_url":"https://api.github.com/users/JabRef/followers","following_url":"https://api.github.com/users/JabRef/following{/other_user}","gists_url":"https://api.github.com/users/JabRef/gists{/gist_id}","starred_url":"https://api.github.com/users/JabRef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JabRef/subscriptions","organizations_url":"https://api.github.com/users/JabRef/orgs","repos_url":"https://api.github.com/users/JabRef/repos","events_url":"https://api.github.com/users/JabRef/events{/privacy}","received_events_url":"https://api.github.com/users/JabRef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JabRef/jabref","description":"Graphical Java application for managing bibtex (.bib) databases","fork":false,"url":"https://api.github.com/repos/JabRef/jabref","forks_url":"https://api.github.com/repos/JabRef/jabref/forks","keys_url":"https://api.github.com/repos/JabRef/jabref/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JabRef/jabref/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JabRef/jabref/teams","hooks_url":"https://api.github.com/repos/JabRef/jabref/hooks","issue_events_url":"https://api.github.com/repos/JabRef/jabref/issues/events{/number}","events_url":"https://api.github.com/repos/JabRef/jabref/events","assignees_url":"https://api.github.com/repos/JabRef/jabref/assignees{/user}","branches_url":"https://api.github.com/repos/JabRef/jabref/branches{/branch}","tags_url":"https://api.github.com/repos/JabRef/jabref/tags","blobs_url":"https://api.github.com/repos/JabRef/jabref/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JabRef/jabref/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JabRef/jabref/git/refs{/sha}","trees_url":"https://api.github.com/repos/JabRef/jabref/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JabRef/jabref/statuses/{sha}","languages_url":"https://api.github.com/repos/JabRef/jabref/languages","stargazers_url":"https://api.github.com/repos/JabRef/jabref/stargazers","contributors_url":"https://api.github.com/repos/JabRef/jabref/contributors","subscribers_url":"https://api.github.com/repos/JabRef/jabref/subscribers","subscription_url":"https://api.github.com/repos/JabRef/jabref/subscription","commits_url":"https://api.github.com/repos/JabRef/jabref/commits{/sha}","git_commits_url":"https://api.github.com/repos/JabRef/jabref/git/commits{/sha}","comments_url":"https://api.github.com/repos/JabRef/jabref/comments{/number}","issue_comment_url":"https://api.github.com/repos/JabRef/jabref/issues/comments{/number}","contents_url":"https://api.github.com/repos/JabRef/jabref/contents/{+path}","compare_url":"https://api.github.com/repos/JabRef/jabref/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JabRef/jabref/merges","archive_url":"https://api.github.com/repos/JabRef/jabref/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JabRef/jabref/downloads","issues_url":"https://api.github.com/repos/JabRef/jabref/issues{/number}","pulls_url":"https://api.github.com/repos/JabRef/jabref/pulls{/number}","milestones_url":"https://api.github.com/repos/JabRef/jabref/milestones{/number}","notifications_url":"https://api.github.com/repos/JabRef/jabref/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JabRef/jabref/labels{/name}","releases_url":"https://api.github.com/repos/JabRef/jabref/releases{/id}","deployments_url":"https://api.github.com/repos/JabRef/jabref/deployments","created_at":"2014-03-11T14:48:42Z","updated_at":"2016-03-20T10:09:32Z","pushed_at":"2016-03-21T09:12:26Z","git_url":"git://github.com/JabRef/jabref.git","ssh_url":"git@github.com:JabRef/jabref.git","clone_url":"https://github.com/JabRef/jabref.git","svn_url":"https://github.com/JabRef/jabref","homepage":"http://www.jabref.org/","size":84409,"stargazers_count":240,"watchers_count":240,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":159,"mirror_url":null,"open_issues_count":181,"forks":159,"open_issues":181,"watchers":240,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/996"},"html":{"href":"https://github.com/JabRef/jabref/pull/996"},"issue":{"href":"https://api.github.com/repos/JabRef/jabref/issues/996"},"comments":{"href":"https://api.github.com/repos/JabRef/jabref/issues/996/comments"},"review_comments":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/996/comments"},"review_comment":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/996/commits"},"statuses":{"href":"https://api.github.com/repos/JabRef/jabref/statuses/29d3ab8a5dc9852dcf546c8164152861744021f3"}}}}