{"action":"created","comment":{"url":"https://api.github.com/repos/jupyter/nbformat/pulls/comments/88048467","pull_request_review_id":8633986,"id":88048467,"diff_hunk":"@@ -351,16 +351,14 @@\n             \"mimebundle\": {\n                 \"description\": \"A mime-type keyed dictionary of data\",\n                 \"type\": \"object\",\n-                \"additionalProperties\": false,\n-                \"properties\": {\n-                    \"application/json\": {\n-                        \"type\": \"object\"\n-                    }\n+                \"additionalProperties\": {\n+                  \"description\": \"mimetype output (e.g. text/plain), represented as either an array of strings or a string.\",\n+                  \"$ref\": \"#/definitions/misc/multiline_string\"\n                 },\n                 \"patternProperties\": {\n-                    \"^(?!application/json$)[a-zA-Z0-9]+/[a-zA-Z0-9\\\\-\\\\+\\\\.]+$\": {\n-                        \"description\": \"mimetype output (e.g. text/plain), represented as either an array of strings or a string.\",\n-                        \"$ref\": \"#/definitions/misc/multiline_string\"\n+                    \"^application/([a-zA-Z0-9.]+\\\\+)?json$\": {\n+                        \"description\": \"Mimetypes with JSON output, can be an object\",\n+                        \"type\": \"object\"","path":"nbformat/v4/nbformat.v4.schema.json","position":19,"original_position":19,"commit_id":"23212776eb72c6a74e82e9099e2da49b448e2392","original_commit_id":"23212776eb72c6a74e82e9099e2da49b448e2392","user":{"login":"gnestor","id":512354,"avatar_url":"https://avatars.githubusercontent.com/u/512354?v=3","gravatar_id":"","url":"https://api.github.com/users/gnestor","html_url":"https://github.com/gnestor","followers_url":"https://api.github.com/users/gnestor/followers","following_url":"https://api.github.com/users/gnestor/following{/other_user}","gists_url":"https://api.github.com/users/gnestor/gists{/gist_id}","starred_url":"https://api.github.com/users/gnestor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnestor/subscriptions","organizations_url":"https://api.github.com/users/gnestor/orgs","repos_url":"https://api.github.com/users/gnestor/repos","events_url":"https://api.github.com/users/gnestor/events{/privacy}","received_events_url":"https://api.github.com/users/gnestor/received_events","type":"User","site_admin":false},"body":"Related: https://github.com/jupyter/nbformat/issues/57","created_at":"2016-11-15T16:02:56Z","updated_at":"2016-11-15T16:02:56Z","html_url":"https://github.com/jupyter/nbformat/pull/43#discussion_r88048467","pull_request_url":"https://api.github.com/repos/jupyter/nbformat/pulls/43","_links":{"self":{"href":"https://api.github.com/repos/jupyter/nbformat/pulls/comments/88048467"},"html":{"href":"https://github.com/jupyter/nbformat/pull/43#discussion_r88048467"},"pull_request":{"href":"https://api.github.com/repos/jupyter/nbformat/pulls/43"}}},"pull_request":{"url":"https://api.github.com/repos/jupyter/nbformat/pulls/43","id":83900624,"html_url":"https://github.com/jupyter/nbformat/pull/43","diff_url":"https://github.com/jupyter/nbformat/pull/43.diff","patch_url":"https://github.com/jupyter/nbformat/pull/43.patch","issue_url":"https://api.github.com/repos/jupyter/nbformat/issues/43","number":43,"state":"closed","locked":false,"title":"Allow custom mimetypes with +json suffix","user":{"login":"rgbkrk","id":836375,"avatar_url":"https://avatars.githubusercontent.com/u/836375?v=3","gravatar_id":"","url":"https://api.github.com/users/rgbkrk","html_url":"https://github.com/rgbkrk","followers_url":"https://api.github.com/users/rgbkrk/followers","following_url":"https://api.github.com/users/rgbkrk/following{/other_user}","gists_url":"https://api.github.com/users/rgbkrk/gists{/gist_id}","starred_url":"https://api.github.com/users/rgbkrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgbkrk/subscriptions","organizations_url":"https://api.github.com/users/rgbkrk/orgs","repos_url":"https://api.github.com/users/rgbkrk/repos","events_url":"https://api.github.com/users/rgbkrk/events{/privacy}","received_events_url":"https://api.github.com/users/rgbkrk/received_events","type":"User","site_admin":false},"body":"Closes #42.\n\nOtherwise plain JSON objects will make the notebook displeased. Currently if a mime type like this comes across on the message spec, all is fine up until the notebook is saved. nbviewer and nteract handle it fine, jupyter notebook does not:\n\n![output complaints from jupyter notebook](https://cloud.githubusercontent.com/assets/1280389/18218499/077c8828-7131-11e6-9e05-5d0456be124c.png)\n","created_at":"2016-09-03T17:13:33Z","updated_at":"2016-11-15T16:02:56Z","closed_at":"2016-09-06T09:35:25Z","merged_at":"2016-09-06T09:35:25Z","merge_commit_sha":"65ccddb7d07599a139b9ef9d336b78625b8ae768","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/jupyter/nbformat/milestones/6","html_url":"https://github.com/jupyter/nbformat/milestones/4.2","labels_url":"https://api.github.com/repos/jupyter/nbformat/milestones/6/labels","id":1337992,"number":6,"title":"4.2","description":null,"creator":{"login":"minrk","id":151929,"avatar_url":"https://avatars.githubusercontent.com/u/151929?v=3","gravatar_id":"","url":"https://api.github.com/users/minrk","html_url":"https://github.com/minrk","followers_url":"https://api.github.com/users/minrk/followers","following_url":"https://api.github.com/users/minrk/following{/other_user}","gists_url":"https://api.github.com/users/minrk/gists{/gist_id}","starred_url":"https://api.github.com/users/minrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minrk/subscriptions","organizations_url":"https://api.github.com/users/minrk/orgs","repos_url":"https://api.github.com/users/minrk/repos","events_url":"https://api.github.com/users/minrk/events{/privacy}","received_events_url":"https://api.github.com/users/minrk/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":9,"state":"open","created_at":"2015-10-05T11:24:42Z","updated_at":"2016-10-18T13:22:12Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/jupyter/nbformat/pulls/43/commits","review_comments_url":"https://api.github.com/repos/jupyter/nbformat/pulls/43/comments","review_comment_url":"https://api.github.com/repos/jupyter/nbformat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jupyter/nbformat/issues/43/comments","statuses_url":"https://api.github.com/repos/jupyter/nbformat/statuses/23212776eb72c6a74e82e9099e2da49b448e2392","head":{"label":"rgbkrk:custom-json-mimetype","ref":"custom-json-mimetype","sha":"23212776eb72c6a74e82e9099e2da49b448e2392","user":{"login":"rgbkrk","id":836375,"avatar_url":"https://avatars.githubusercontent.com/u/836375?v=3","gravatar_id":"","url":"https://api.github.com/users/rgbkrk","html_url":"https://github.com/rgbkrk","followers_url":"https://api.github.com/users/rgbkrk/followers","following_url":"https://api.github.com/users/rgbkrk/following{/other_user}","gists_url":"https://api.github.com/users/rgbkrk/gists{/gist_id}","starred_url":"https://api.github.com/users/rgbkrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgbkrk/subscriptions","organizations_url":"https://api.github.com/users/rgbkrk/orgs","repos_url":"https://api.github.com/users/rgbkrk/repos","events_url":"https://api.github.com/users/rgbkrk/events{/privacy}","received_events_url":"https://api.github.com/users/rgbkrk/received_events","type":"User","site_admin":false},"repo":{"id":67301661,"name":"nbformat","full_name":"rgbkrk/nbformat","owner":{"login":"rgbkrk","id":836375,"avatar_url":"https://avatars.githubusercontent.com/u/836375?v=3","gravatar_id":"","url":"https://api.github.com/users/rgbkrk","html_url":"https://github.com/rgbkrk","followers_url":"https://api.github.com/users/rgbkrk/followers","following_url":"https://api.github.com/users/rgbkrk/following{/other_user}","gists_url":"https://api.github.com/users/rgbkrk/gists{/gist_id}","starred_url":"https://api.github.com/users/rgbkrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgbkrk/subscriptions","organizations_url":"https://api.github.com/users/rgbkrk/orgs","repos_url":"https://api.github.com/users/rgbkrk/repos","events_url":"https://api.github.com/users/rgbkrk/events{/privacy}","received_events_url":"https://api.github.com/users/rgbkrk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rgbkrk/nbformat","description":"Reference implementation of the Jupyter Notebook format","fork":true,"url":"https://api.github.com/repos/rgbkrk/nbformat","forks_url":"https://api.github.com/repos/rgbkrk/nbformat/forks","keys_url":"https://api.github.com/repos/rgbkrk/nbformat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rgbkrk/nbformat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rgbkrk/nbformat/teams","hooks_url":"https://api.github.com/repos/rgbkrk/nbformat/hooks","issue_events_url":"https://api.github.com/repos/rgbkrk/nbformat/issues/events{/number}","events_url":"https://api.github.com/repos/rgbkrk/nbformat/events","assignees_url":"https://api.github.com/repos/rgbkrk/nbformat/assignees{/user}","branches_url":"https://api.github.com/repos/rgbkrk/nbformat/branches{/branch}","tags_url":"https://api.github.com/repos/rgbkrk/nbformat/tags","blobs_url":"https://api.github.com/repos/rgbkrk/nbformat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rgbkrk/nbformat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rgbkrk/nbformat/git/refs{/sha}","trees_url":"https://api.github.com/repos/rgbkrk/nbformat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rgbkrk/nbformat/statuses/{sha}","languages_url":"https://api.github.com/repos/rgbkrk/nbformat/languages","stargazers_url":"https://api.github.com/repos/rgbkrk/nbformat/stargazers","contributors_url":"https://api.github.com/repos/rgbkrk/nbformat/contributors","subscribers_url":"https://api.github.com/repos/rgbkrk/nbformat/subscribers","subscription_url":"https://api.github.com/repos/rgbkrk/nbformat/subscription","commits_url":"https://api.github.com/repos/rgbkrk/nbformat/commits{/sha}","git_commits_url":"https://api.github.com/repos/rgbkrk/nbformat/git/commits{/sha}","comments_url":"https://api.github.com/repos/rgbkrk/nbformat/comments{/number}","issue_comment_url":"https://api.github.com/repos/rgbkrk/nbformat/issues/comments{/number}","contents_url":"https://api.github.com/repos/rgbkrk/nbformat/contents/{+path}","compare_url":"https://api.github.com/repos/rgbkrk/nbformat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rgbkrk/nbformat/merges","archive_url":"https://api.github.com/repos/rgbkrk/nbformat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rgbkrk/nbformat/downloads","issues_url":"https://api.github.com/repos/rgbkrk/nbformat/issues{/number}","pulls_url":"https://api.github.com/repos/rgbkrk/nbformat/pulls{/number}","milestones_url":"https://api.github.com/repos/rgbkrk/nbformat/milestones{/number}","notifications_url":"https://api.github.com/repos/rgbkrk/nbformat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rgbkrk/nbformat/labels{/name}","releases_url":"https://api.github.com/repos/rgbkrk/nbformat/releases{/id}","deployments_url":"https://api.github.com/repos/rgbkrk/nbformat/deployments","created_at":"2016-09-03T17:02:05Z","updated_at":"2016-09-03T17:02:05Z","pushed_at":"2016-09-06T13:59:14Z","git_url":"git://github.com/rgbkrk/nbformat.git","ssh_url":"git@github.com:rgbkrk/nbformat.git","clone_url":"https://github.com/rgbkrk/nbformat.git","svn_url":"https://github.com/rgbkrk/nbformat","homepage":"http://nbformat.readthedocs.io/","size":368,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jupyter:master","ref":"master","sha":"9ffcc3eb19d55cfa7aedd56b57a06d0c0c68ff0c","user":{"login":"jupyter","id":7388996,"avatar_url":"https://avatars.githubusercontent.com/u/7388996?v=3","gravatar_id":"","url":"https://api.github.com/users/jupyter","html_url":"https://github.com/jupyter","followers_url":"https://api.github.com/users/jupyter/followers","following_url":"https://api.github.com/users/jupyter/following{/other_user}","gists_url":"https://api.github.com/users/jupyter/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyter/subscriptions","organizations_url":"https://api.github.com/users/jupyter/orgs","repos_url":"https://api.github.com/users/jupyter/repos","events_url":"https://api.github.com/users/jupyter/events{/privacy}","received_events_url":"https://api.github.com/users/jupyter/received_events","type":"Organization","site_admin":false},"repo":{"id":33640907,"name":"nbformat","full_name":"jupyter/nbformat","owner":{"login":"jupyter","id":7388996,"avatar_url":"https://avatars.githubusercontent.com/u/7388996?v=3","gravatar_id":"","url":"https://api.github.com/users/jupyter","html_url":"https://github.com/jupyter","followers_url":"https://api.github.com/users/jupyter/followers","following_url":"https://api.github.com/users/jupyter/following{/other_user}","gists_url":"https://api.github.com/users/jupyter/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyter/subscriptions","organizations_url":"https://api.github.com/users/jupyter/orgs","repos_url":"https://api.github.com/users/jupyter/repos","events_url":"https://api.github.com/users/jupyter/events{/privacy}","received_events_url":"https://api.github.com/users/jupyter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jupyter/nbformat","description":"Reference implementation of the Jupyter Notebook format","fork":false,"url":"https://api.github.com/repos/jupyter/nbformat","forks_url":"https://api.github.com/repos/jupyter/nbformat/forks","keys_url":"https://api.github.com/repos/jupyter/nbformat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jupyter/nbformat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jupyter/nbformat/teams","hooks_url":"https://api.github.com/repos/jupyter/nbformat/hooks","issue_events_url":"https://api.github.com/repos/jupyter/nbformat/issues/events{/number}","events_url":"https://api.github.com/repos/jupyter/nbformat/events","assignees_url":"https://api.github.com/repos/jupyter/nbformat/assignees{/user}","branches_url":"https://api.github.com/repos/jupyter/nbformat/branches{/branch}","tags_url":"https://api.github.com/repos/jupyter/nbformat/tags","blobs_url":"https://api.github.com/repos/jupyter/nbformat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jupyter/nbformat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jupyter/nbformat/git/refs{/sha}","trees_url":"https://api.github.com/repos/jupyter/nbformat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jupyter/nbformat/statuses/{sha}","languages_url":"https://api.github.com/repos/jupyter/nbformat/languages","stargazers_url":"https://api.github.com/repos/jupyter/nbformat/stargazers","contributors_url":"https://api.github.com/repos/jupyter/nbformat/contributors","subscribers_url":"https://api.github.com/repos/jupyter/nbformat/subscribers","subscription_url":"https://api.github.com/repos/jupyter/nbformat/subscription","commits_url":"https://api.github.com/repos/jupyter/nbformat/commits{/sha}","git_commits_url":"https://api.github.com/repos/jupyter/nbformat/git/commits{/sha}","comments_url":"https://api.github.com/repos/jupyter/nbformat/comments{/number}","issue_comment_url":"https://api.github.com/repos/jupyter/nbformat/issues/comments{/number}","contents_url":"https://api.github.com/repos/jupyter/nbformat/contents/{+path}","compare_url":"https://api.github.com/repos/jupyter/nbformat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jupyter/nbformat/merges","archive_url":"https://api.github.com/repos/jupyter/nbformat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jupyter/nbformat/downloads","issues_url":"https://api.github.com/repos/jupyter/nbformat/issues{/number}","pulls_url":"https://api.github.com/repos/jupyter/nbformat/pulls{/number}","milestones_url":"https://api.github.com/repos/jupyter/nbformat/milestones{/number}","notifications_url":"https://api.github.com/repos/jupyter/nbformat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jupyter/nbformat/labels{/name}","releases_url":"https://api.github.com/repos/jupyter/nbformat/releases{/id}","deployments_url":"https://api.github.com/repos/jupyter/nbformat/deployments","created_at":"2015-04-09T01:07:29Z","updated_at":"2016-11-13T22:59:05Z","pushed_at":"2016-11-14T21:26:53Z","git_url":"git://github.com/jupyter/nbformat.git","ssh_url":"git@github.com:jupyter/nbformat.git","clone_url":"https://github.com/jupyter/nbformat.git","svn_url":"https://github.com/jupyter/nbformat","homepage":"http://nbformat.readthedocs.io/","size":1085,"stargazers_count":17,"watchers_count":17,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":16,"forks":35,"open_issues":16,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jupyter/nbformat/pulls/43"},"html":{"href":"https://github.com/jupyter/nbformat/pull/43"},"issue":{"href":"https://api.github.com/repos/jupyter/nbformat/issues/43"},"comments":{"href":"https://api.github.com/repos/jupyter/nbformat/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/jupyter/nbformat/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/jupyter/nbformat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jupyter/nbformat/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/jupyter/nbformat/statuses/23212776eb72c6a74e82e9099e2da49b448e2392"}}}}
{"actor":{"display_login":"gnestor"}}