{"action":"closed","number":46,"pull_request":{"url":"https://api.github.com/repos/kaimallea/isMobile/pulls/46","id":60771190,"html_url":"https://github.com/kaimallea/isMobile/pull/46","diff_url":"https://github.com/kaimallea/isMobile/pull/46.diff","patch_url":"https://github.com/kaimallea/isMobile/pull/46.patch","issue_url":"https://api.github.com/repos/kaimallea/isMobile/issues/46","number":46,"state":"closed","locked":false,"title":"Fixed twitter app integrated browser  tablets detection","user":{"login":"pivica","id":1798146,"avatar_url":"https://avatars.githubusercontent.com/u/1798146?v=3","gravatar_id":"","url":"https://api.github.com/users/pivica","html_url":"https://github.com/pivica","followers_url":"https://api.github.com/users/pivica/followers","following_url":"https://api.github.com/users/pivica/following{/other_user}","gists_url":"https://api.github.com/users/pivica/gists{/gist_id}","starred_url":"https://api.github.com/users/pivica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pivica/subscriptions","organizations_url":"https://api.github.com/users/pivica/orgs","repos_url":"https://api.github.com/users/pivica/repos","events_url":"https://api.github.com/users/pivica/events{/privacy}","received_events_url":"https://api.github.com/users/pivica/received_events","type":"User","site_admin":false},"body":"Twitter app integrated browser tablets is adding strings to user agent that will confuse detection.\r\n\r\nThis is for example user agent string on iPad\r\n\r\n `Mozilla/5.0 (iPad; CPU OS 9_2_1 like Mac OS X) AppleWebKit/601.1.46 (KHTML, like Gecko) Mobile/13D15 Twitter for iPhone`\r\n\r\nThe last part 'Twitter for iPhone' will confuse platform detection so isMobile will thing that this is mobile and not a tablet platform.\r\n\r\nProposed fix is just removing added Twitter part from user agent, similarly like FB integrated browser is fixed.","created_at":"2016-02-26T00:12:19Z","updated_at":"2016-03-04T02:37:50Z","closed_at":"2016-03-04T02:37:50Z","merged_at":"2016-03-04T02:37:50Z","merge_commit_sha":"bf7ce5f7d2e5db54bfa7c04d453b4c235094ea09","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kaimallea/isMobile/pulls/46/commits","review_comments_url":"https://api.github.com/repos/kaimallea/isMobile/pulls/46/comments","review_comment_url":"https://api.github.com/repos/kaimallea/isMobile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kaimallea/isMobile/issues/46/comments","statuses_url":"https://api.github.com/repos/kaimallea/isMobile/statuses/20a4d9cefdb49e55fa81e4e9645a342668c91878","head":{"label":"pivica:features/tablet-twitter-app-in-browser-detection-fix","ref":"features/tablet-twitter-app-in-browser-detection-fix","sha":"20a4d9cefdb49e55fa81e4e9645a342668c91878","user":{"login":"pivica","id":1798146,"avatar_url":"https://avatars.githubusercontent.com/u/1798146?v=3","gravatar_id":"","url":"https://api.github.com/users/pivica","html_url":"https://github.com/pivica","followers_url":"https://api.github.com/users/pivica/followers","following_url":"https://api.github.com/users/pivica/following{/other_user}","gists_url":"https://api.github.com/users/pivica/gists{/gist_id}","starred_url":"https://api.github.com/users/pivica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pivica/subscriptions","organizations_url":"https://api.github.com/users/pivica/orgs","repos_url":"https://api.github.com/users/pivica/repos","events_url":"https://api.github.com/users/pivica/events{/privacy}","received_events_url":"https://api.github.com/users/pivica/received_events","type":"User","site_admin":false},"repo":{"id":52550377,"name":"isMobile","full_name":"pivica/isMobile","owner":{"login":"pivica","id":1798146,"avatar_url":"https://avatars.githubusercontent.com/u/1798146?v=3","gravatar_id":"","url":"https://api.github.com/users/pivica","html_url":"https://github.com/pivica","followers_url":"https://api.github.com/users/pivica/followers","following_url":"https://api.github.com/users/pivica/following{/other_user}","gists_url":"https://api.github.com/users/pivica/gists{/gist_id}","starred_url":"https://api.github.com/users/pivica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pivica/subscriptions","organizations_url":"https://api.github.com/users/pivica/orgs","repos_url":"https://api.github.com/users/pivica/repos","events_url":"https://api.github.com/users/pivica/events{/privacy}","received_events_url":"https://api.github.com/users/pivica/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pivica/isMobile","description":"A simple JS library that detects mobile devices.","fork":true,"url":"https://api.github.com/repos/pivica/isMobile","forks_url":"https://api.github.com/repos/pivica/isMobile/forks","keys_url":"https://api.github.com/repos/pivica/isMobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pivica/isMobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pivica/isMobile/teams","hooks_url":"https://api.github.com/repos/pivica/isMobile/hooks","issue_events_url":"https://api.github.com/repos/pivica/isMobile/issues/events{/number}","events_url":"https://api.github.com/repos/pivica/isMobile/events","assignees_url":"https://api.github.com/repos/pivica/isMobile/assignees{/user}","branches_url":"https://api.github.com/repos/pivica/isMobile/branches{/branch}","tags_url":"https://api.github.com/repos/pivica/isMobile/tags","blobs_url":"https://api.github.com/repos/pivica/isMobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pivica/isMobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pivica/isMobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/pivica/isMobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pivica/isMobile/statuses/{sha}","languages_url":"https://api.github.com/repos/pivica/isMobile/languages","stargazers_url":"https://api.github.com/repos/pivica/isMobile/stargazers","contributors_url":"https://api.github.com/repos/pivica/isMobile/contributors","subscribers_url":"https://api.github.com/repos/pivica/isMobile/subscribers","subscription_url":"https://api.github.com/repos/pivica/isMobile/subscription","commits_url":"https://api.github.com/repos/pivica/isMobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/pivica/isMobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/pivica/isMobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/pivica/isMobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/pivica/isMobile/contents/{+path}","compare_url":"https://api.github.com/repos/pivica/isMobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pivica/isMobile/merges","archive_url":"https://api.github.com/repos/pivica/isMobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pivica/isMobile/downloads","issues_url":"https://api.github.com/repos/pivica/isMobile/issues{/number}","pulls_url":"https://api.github.com/repos/pivica/isMobile/pulls{/number}","milestones_url":"https://api.github.com/repos/pivica/isMobile/milestones{/number}","notifications_url":"https://api.github.com/repos/pivica/isMobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pivica/isMobile/labels{/name}","releases_url":"https://api.github.com/repos/pivica/isMobile/releases{/id}","deployments_url":"https://api.github.com/repos/pivica/isMobile/deployments","created_at":"2016-02-25T19:18:20Z","updated_at":"2016-02-25T19:18:21Z","pushed_at":"2016-03-02T07:49:07Z","git_url":"git://github.com/pivica/isMobile.git","ssh_url":"git@github.com:pivica/isMobile.git","clone_url":"https://github.com/pivica/isMobile.git","svn_url":"https://github.com/pivica/isMobile","homepage":"","size":90,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kaimallea:master","ref":"master","sha":"4e16f263b1634e58d10d72891ef82eeed0d13d3e","user":{"login":"kaimallea","id":228982,"avatar_url":"https://avatars.githubusercontent.com/u/228982?v=3","gravatar_id":"","url":"https://api.github.com/users/kaimallea","html_url":"https://github.com/kaimallea","followers_url":"https://api.github.com/users/kaimallea/followers","following_url":"https://api.github.com/users/kaimallea/following{/other_user}","gists_url":"https://api.github.com/users/kaimallea/gists{/gist_id}","starred_url":"https://api.github.com/users/kaimallea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaimallea/subscriptions","organizations_url":"https://api.github.com/users/kaimallea/orgs","repos_url":"https://api.github.com/users/kaimallea/repos","events_url":"https://api.github.com/users/kaimallea/events{/privacy}","received_events_url":"https://api.github.com/users/kaimallea/received_events","type":"User","site_admin":false},"repo":{"id":5195122,"name":"isMobile","full_name":"kaimallea/isMobile","owner":{"login":"kaimallea","id":228982,"avatar_url":"https://avatars.githubusercontent.com/u/228982?v=3","gravatar_id":"","url":"https://api.github.com/users/kaimallea","html_url":"https://github.com/kaimallea","followers_url":"https://api.github.com/users/kaimallea/followers","following_url":"https://api.github.com/users/kaimallea/following{/other_user}","gists_url":"https://api.github.com/users/kaimallea/gists{/gist_id}","starred_url":"https://api.github.com/users/kaimallea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaimallea/subscriptions","organizations_url":"https://api.github.com/users/kaimallea/orgs","repos_url":"https://api.github.com/users/kaimallea/repos","events_url":"https://api.github.com/users/kaimallea/events{/privacy}","received_events_url":"https://api.github.com/users/kaimallea/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kaimallea/isMobile","description":"A simple JS library that detects mobile devices.","fork":false,"url":"https://api.github.com/repos/kaimallea/isMobile","forks_url":"https://api.github.com/repos/kaimallea/isMobile/forks","keys_url":"https://api.github.com/repos/kaimallea/isMobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaimallea/isMobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaimallea/isMobile/teams","hooks_url":"https://api.github.com/repos/kaimallea/isMobile/hooks","issue_events_url":"https://api.github.com/repos/kaimallea/isMobile/issues/events{/number}","events_url":"https://api.github.com/repos/kaimallea/isMobile/events","assignees_url":"https://api.github.com/repos/kaimallea/isMobile/assignees{/user}","branches_url":"https://api.github.com/repos/kaimallea/isMobile/branches{/branch}","tags_url":"https://api.github.com/repos/kaimallea/isMobile/tags","blobs_url":"https://api.github.com/repos/kaimallea/isMobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaimallea/isMobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaimallea/isMobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaimallea/isMobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaimallea/isMobile/statuses/{sha}","languages_url":"https://api.github.com/repos/kaimallea/isMobile/languages","stargazers_url":"https://api.github.com/repos/kaimallea/isMobile/stargazers","contributors_url":"https://api.github.com/repos/kaimallea/isMobile/contributors","subscribers_url":"https://api.github.com/repos/kaimallea/isMobile/subscribers","subscription_url":"https://api.github.com/repos/kaimallea/isMobile/subscription","commits_url":"https://api.github.com/repos/kaimallea/isMobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaimallea/isMobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaimallea/isMobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaimallea/isMobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaimallea/isMobile/contents/{+path}","compare_url":"https://api.github.com/repos/kaimallea/isMobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaimallea/isMobile/merges","archive_url":"https://api.github.com/repos/kaimallea/isMobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaimallea/isMobile/downloads","issues_url":"https://api.github.com/repos/kaimallea/isMobile/issues{/number}","pulls_url":"https://api.github.com/repos/kaimallea/isMobile/pulls{/number}","milestones_url":"https://api.github.com/repos/kaimallea/isMobile/milestones{/number}","notifications_url":"https://api.github.com/repos/kaimallea/isMobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaimallea/isMobile/labels{/name}","releases_url":"https://api.github.com/repos/kaimallea/isMobile/releases{/id}","deployments_url":"https://api.github.com/repos/kaimallea/isMobile/deployments","created_at":"2012-07-26T17:31:23Z","updated_at":"2016-03-03T02:29:49Z","pushed_at":"2016-03-04T02:37:50Z","git_url":"git://github.com/kaimallea/isMobile.git","ssh_url":"git@github.com:kaimallea/isMobile.git","clone_url":"https://github.com/kaimallea/isMobile.git","svn_url":"https://github.com/kaimallea/isMobile","homepage":"","size":88,"stargazers_count":621,"watchers_count":621,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":104,"mirror_url":null,"open_issues_count":0,"forks":104,"open_issues":0,"watchers":621,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kaimallea/isMobile/pulls/46"},"html":{"href":"https://github.com/kaimallea/isMobile/pull/46"},"issue":{"href":"https://api.github.com/repos/kaimallea/isMobile/issues/46"},"comments":{"href":"https://api.github.com/repos/kaimallea/isMobile/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/kaimallea/isMobile/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/kaimallea/isMobile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kaimallea/isMobile/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/kaimallea/isMobile/statuses/20a4d9cefdb49e55fa81e4e9645a342668c91878"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kaimallea","id":228982,"avatar_url":"https://avatars.githubusercontent.com/u/228982?v=3","gravatar_id":"","url":"https://api.github.com/users/kaimallea","html_url":"https://github.com/kaimallea","followers_url":"https://api.github.com/users/kaimallea/followers","following_url":"https://api.github.com/users/kaimallea/following{/other_user}","gists_url":"https://api.github.com/users/kaimallea/gists{/gist_id}","starred_url":"https://api.github.com/users/kaimallea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaimallea/subscriptions","organizations_url":"https://api.github.com/users/kaimallea/orgs","repos_url":"https://api.github.com/users/kaimallea/repos","events_url":"https://api.github.com/users/kaimallea/events{/privacy}","received_events_url":"https://api.github.com/users/kaimallea/received_events","type":"User","site_admin":false},"comments":4,"review_comments":1,"commits":3,"additions":59,"deletions":1,"changed_files":3}}