{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/56034963","id":56034963,"diff_hunk":"@@ -34,6 +34,16 @@ namespace System.Diagnostics\n     /// </summary>\n     public class DiagnosticListener : DiagnosticSource, IObservable<KeyValuePair<string, object>>, IDisposable\n     {\n+#if false\n+        /// <summary>\n+        /// This is the DiagnosticListener that is used by default by the class library.   \n+        /// Generally you don't want to make your own but rather have everyone use this one, which\n+        /// ensures that everyone who wished to subscribe gets the callbacks.  \n+        /// The main reason not to us this one is that you WANT isolation from other \n+        /// events in the system (e.g. multi-tenancy).  \n+        /// </summary>\n+        public static DiagnosticListener DefaultListener { get { return s_default; } }\n+#endif ","path":"src/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/DiagnosticListener.cs","position":null,"original_position":13,"commit_id":"81b9d2b6b9dc02e95e0990d039468d010cba97aa","original_commit_id":"3a73a908407c2f57a9bd8cde76eeb835cd2d2dea","user":{"login":"vancem","id":8459414,"avatar_url":"https://avatars.githubusercontent.com/u/8459414?v=3","gravatar_id":"","url":"https://api.github.com/users/vancem","html_url":"https://github.com/vancem","followers_url":"https://api.github.com/users/vancem/followers","following_url":"https://api.github.com/users/vancem/following{/other_user}","gists_url":"https://api.github.com/users/vancem/gists{/gist_id}","starred_url":"https://api.github.com/users/vancem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vancem/subscriptions","organizations_url":"https://api.github.com/users/vancem/orgs","repos_url":"https://api.github.com/users/vancem/repos","events_url":"https://api.github.com/users/vancem/events{/privacy}","received_events_url":"https://api.github.com/users/vancem/received_events","type":"User","site_admin":false},"body":"This was a merge error.  Fixed. ","created_at":"2016-03-14T16:59:06Z","updated_at":"2016-03-14T16:59:06Z","html_url":"https://github.com/dotnet/corefx/pull/6867#discussion_r56034963","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/6867","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/56034963"},"html":{"href":"https://github.com/dotnet/corefx/pull/6867#discussion_r56034963"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/6867"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/6867","id":62763205,"html_url":"https://github.com/dotnet/corefx/pull/6867","diff_url":"https://github.com/dotnet/corefx/pull/6867.diff","patch_url":"https://github.com/dotnet/corefx/pull/6867.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/6867","number":6867,"state":"open","locked":false,"title":"Adding DiagnosticSource to EventSource Bridge.","user":{"login":"vancem","id":8459414,"avatar_url":"https://avatars.githubusercontent.com/u/8459414?v=3","gravatar_id":"","url":"https://api.github.com/users/vancem","html_url":"https://github.com/vancem","followers_url":"https://api.github.com/users/vancem/followers","following_url":"https://api.github.com/users/vancem/following{/other_user}","gists_url":"https://api.github.com/users/vancem/gists{/gist_id}","starred_url":"https://api.github.com/users/vancem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vancem/subscriptions","organizations_url":"https://api.github.com/users/vancem/orgs","repos_url":"https://api.github.com/users/vancem/repos","events_url":"https://api.github.com/users/vancem/events{/privacy}","received_events_url":"https://api.github.com/users/vancem/received_events","type":"User","site_admin":false},"body":"Currently DiagnosticSource just goes to DiagnosticListeners.   We want to\r\nbe able to have the capabilty to pipe DiagnosticSource information to\r\nEventSource consumers (ETW and EventListeners).  We do this with a new\r\nDiagnosticSource EventSource called 'Microsoft-DiagnosticsSource'  If\r\nEventListener / ETW subscribe to that EventSource they can get events\r\nfrom any DiangnosticSouce.\r\n\r\nSee the comments in the code itself as well as the tests in the file\r\nDiagnosticSourceEventSourceBridgeTests.cs for more on specifics of\r\nusing this new functionality.","created_at":"2016-03-14T15:11:39Z","updated_at":"2016-03-14T16:59:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3599a03853d9d4da48b246b129b95a9cfe89d634","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/6867/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/6867/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/6867/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/81b9d2b6b9dc02e95e0990d039468d010cba97aa","head":{"label":"vancem:DiagnosticSourceBridge","ref":"DiagnosticSourceBridge","sha":"81b9d2b6b9dc02e95e0990d039468d010cba97aa","user":{"login":"vancem","id":8459414,"avatar_url":"https://avatars.githubusercontent.com/u/8459414?v=3","gravatar_id":"","url":"https://api.github.com/users/vancem","html_url":"https://github.com/vancem","followers_url":"https://api.github.com/users/vancem/followers","following_url":"https://api.github.com/users/vancem/following{/other_user}","gists_url":"https://api.github.com/users/vancem/gists{/gist_id}","starred_url":"https://api.github.com/users/vancem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vancem/subscriptions","organizations_url":"https://api.github.com/users/vancem/orgs","repos_url":"https://api.github.com/users/vancem/repos","events_url":"https://api.github.com/users/vancem/events{/privacy}","received_events_url":"https://api.github.com/users/vancem/received_events","type":"User","site_admin":false},"repo":{"id":41119686,"name":"corefx","full_name":"vancem/corefx","owner":{"login":"vancem","id":8459414,"avatar_url":"https://avatars.githubusercontent.com/u/8459414?v=3","gravatar_id":"","url":"https://api.github.com/users/vancem","html_url":"https://github.com/vancem","followers_url":"https://api.github.com/users/vancem/followers","following_url":"https://api.github.com/users/vancem/following{/other_user}","gists_url":"https://api.github.com/users/vancem/gists{/gist_id}","starred_url":"https://api.github.com/users/vancem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vancem/subscriptions","organizations_url":"https://api.github.com/users/vancem/orgs","repos_url":"https://api.github.com/users/vancem/repos","events_url":"https://api.github.com/users/vancem/events{/privacy}","received_events_url":"https://api.github.com/users/vancem/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vancem/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/vancem/corefx","forks_url":"https://api.github.com/repos/vancem/corefx/forks","keys_url":"https://api.github.com/repos/vancem/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vancem/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vancem/corefx/teams","hooks_url":"https://api.github.com/repos/vancem/corefx/hooks","issue_events_url":"https://api.github.com/repos/vancem/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/vancem/corefx/events","assignees_url":"https://api.github.com/repos/vancem/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/vancem/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/vancem/corefx/tags","blobs_url":"https://api.github.com/repos/vancem/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vancem/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vancem/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/vancem/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vancem/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/vancem/corefx/languages","stargazers_url":"https://api.github.com/repos/vancem/corefx/stargazers","contributors_url":"https://api.github.com/repos/vancem/corefx/contributors","subscribers_url":"https://api.github.com/repos/vancem/corefx/subscribers","subscription_url":"https://api.github.com/repos/vancem/corefx/subscription","commits_url":"https://api.github.com/repos/vancem/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/vancem/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/vancem/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/vancem/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/vancem/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/vancem/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vancem/corefx/merges","archive_url":"https://api.github.com/repos/vancem/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vancem/corefx/downloads","issues_url":"https://api.github.com/repos/vancem/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/vancem/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/vancem/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/vancem/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vancem/corefx/labels{/name}","releases_url":"https://api.github.com/repos/vancem/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/vancem/corefx/deployments","created_at":"2015-08-20T21:27:34Z","updated_at":"2016-01-15T22:13:48Z","pushed_at":"2016-03-14T16:17:37Z","git_url":"git://github.com/vancem/corefx.git","ssh_url":"git@github.com:vancem/corefx.git","clone_url":"https://github.com/vancem/corefx.git","svn_url":"https://github.com/vancem/corefx","homepage":"http://dotnet.github.io/core/","size":58892,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"0c8c722b5506370f638126aef35599869da97254","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-03-14T15:46:06Z","pushed_at":"2016-03-14T16:55:15Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/","size":79318,"stargazers_count":9312,"watchers_count":9312,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2193,"mirror_url":null,"open_issues_count":936,"forks":2193,"open_issues":936,"watchers":9312,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/6867"},"html":{"href":"https://github.com/dotnet/corefx/pull/6867"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/6867"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/6867/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/6867/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/6867/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/81b9d2b6b9dc02e95e0990d039468d010cba97aa"}}}}