{"action":"opened","number":24,"pull_request":{"url":"https://api.github.com/repos/hassox/rails_warden/pulls/24","id":92147757,"html_url":"https://github.com/hassox/rails_warden/pull/24","diff_url":"https://github.com/hassox/rails_warden/pull/24.diff","patch_url":"https://github.com/hassox/rails_warden/pull/24.patch","issue_url":"https://api.github.com/repos/hassox/rails_warden/issues/24","number":24,"state":"open","locked":false,"title":"Rails 5 Support","user":{"login":"jspooner","id":24090,"avatar_url":"https://avatars.githubusercontent.com/u/24090?v=3","gravatar_id":"","url":"https://api.github.com/users/jspooner","html_url":"https://github.com/jspooner","followers_url":"https://api.github.com/users/jspooner/followers","following_url":"https://api.github.com/users/jspooner/following{/other_user}","gists_url":"https://api.github.com/users/jspooner/gists{/gist_id}","starred_url":"https://api.github.com/users/jspooner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jspooner/subscriptions","organizations_url":"https://api.github.com/users/jspooner/orgs","repos_url":"https://api.github.com/users/jspooner/repos","events_url":"https://api.github.com/users/jspooner/events{/privacy}","received_events_url":"https://api.github.com/users/jspooner/received_events","type":"User","site_admin":false},"body":"**Changes**\r\n\r\nWhen the class_eval methods were not wrapped in an on_load block I was getting strange results where my helpers in the including project were wiped out. I noticed all Railsies in the Rails project has this on_load block.\r\na) class_eval needed to be wrapped in a ActiveSupport.on_load(:action_controller) block\r\nb) ActionView::Base class_eval was clobbering existing controller helpers when not wrapped in a ActiveSupport.on_load(:action_view) block\r\n\r\nIf the rails version has ::ActionController::API we also add the helper methods there also.\r\n\r\nRails 5 has a new view on including helpers in controllers. We now call helper vs include\r\nrails/rails#24866","created_at":"2016-11-03T12:56:58Z","updated_at":"2016-11-03T12:56:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hassox/rails_warden/pulls/24/commits","review_comments_url":"https://api.github.com/repos/hassox/rails_warden/pulls/24/comments","review_comment_url":"https://api.github.com/repos/hassox/rails_warden/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hassox/rails_warden/issues/24/comments","statuses_url":"https://api.github.com/repos/hassox/rails_warden/statuses/58343bf5506bed78cd19214ad4f8916d76b12abf","head":{"label":"VerveWireless:master","ref":"master","sha":"58343bf5506bed78cd19214ad4f8916d76b12abf","user":{"login":"VerveWireless","id":588680,"avatar_url":"https://avatars.githubusercontent.com/u/588680?v=3","gravatar_id":"","url":"https://api.github.com/users/VerveWireless","html_url":"https://github.com/VerveWireless","followers_url":"https://api.github.com/users/VerveWireless/followers","following_url":"https://api.github.com/users/VerveWireless/following{/other_user}","gists_url":"https://api.github.com/users/VerveWireless/gists{/gist_id}","starred_url":"https://api.github.com/users/VerveWireless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VerveWireless/subscriptions","organizations_url":"https://api.github.com/users/VerveWireless/orgs","repos_url":"https://api.github.com/users/VerveWireless/repos","events_url":"https://api.github.com/users/VerveWireless/events{/privacy}","received_events_url":"https://api.github.com/users/VerveWireless/received_events","type":"Organization","site_admin":false},"repo":{"id":72686657,"name":"rails_warden","full_name":"VerveWireless/rails_warden","owner":{"login":"VerveWireless","id":588680,"avatar_url":"https://avatars.githubusercontent.com/u/588680?v=3","gravatar_id":"","url":"https://api.github.com/users/VerveWireless","html_url":"https://github.com/VerveWireless","followers_url":"https://api.github.com/users/VerveWireless/followers","following_url":"https://api.github.com/users/VerveWireless/following{/other_user}","gists_url":"https://api.github.com/users/VerveWireless/gists{/gist_id}","starred_url":"https://api.github.com/users/VerveWireless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VerveWireless/subscriptions","organizations_url":"https://api.github.com/users/VerveWireless/orgs","repos_url":"https://api.github.com/users/VerveWireless/repos","events_url":"https://api.github.com/users/VerveWireless/events{/privacy}","received_events_url":"https://api.github.com/users/VerveWireless/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VerveWireless/rails_warden","description":"A thin rails plugin on top of Warden for Authentication","fork":true,"url":"https://api.github.com/repos/VerveWireless/rails_warden","forks_url":"https://api.github.com/repos/VerveWireless/rails_warden/forks","keys_url":"https://api.github.com/repos/VerveWireless/rails_warden/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VerveWireless/rails_warden/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VerveWireless/rails_warden/teams","hooks_url":"https://api.github.com/repos/VerveWireless/rails_warden/hooks","issue_events_url":"https://api.github.com/repos/VerveWireless/rails_warden/issues/events{/number}","events_url":"https://api.github.com/repos/VerveWireless/rails_warden/events","assignees_url":"https://api.github.com/repos/VerveWireless/rails_warden/assignees{/user}","branches_url":"https://api.github.com/repos/VerveWireless/rails_warden/branches{/branch}","tags_url":"https://api.github.com/repos/VerveWireless/rails_warden/tags","blobs_url":"https://api.github.com/repos/VerveWireless/rails_warden/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VerveWireless/rails_warden/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VerveWireless/rails_warden/git/refs{/sha}","trees_url":"https://api.github.com/repos/VerveWireless/rails_warden/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VerveWireless/rails_warden/statuses/{sha}","languages_url":"https://api.github.com/repos/VerveWireless/rails_warden/languages","stargazers_url":"https://api.github.com/repos/VerveWireless/rails_warden/stargazers","contributors_url":"https://api.github.com/repos/VerveWireless/rails_warden/contributors","subscribers_url":"https://api.github.com/repos/VerveWireless/rails_warden/subscribers","subscription_url":"https://api.github.com/repos/VerveWireless/rails_warden/subscription","commits_url":"https://api.github.com/repos/VerveWireless/rails_warden/commits{/sha}","git_commits_url":"https://api.github.com/repos/VerveWireless/rails_warden/git/commits{/sha}","comments_url":"https://api.github.com/repos/VerveWireless/rails_warden/comments{/number}","issue_comment_url":"https://api.github.com/repos/VerveWireless/rails_warden/issues/comments{/number}","contents_url":"https://api.github.com/repos/VerveWireless/rails_warden/contents/{+path}","compare_url":"https://api.github.com/repos/VerveWireless/rails_warden/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VerveWireless/rails_warden/merges","archive_url":"https://api.github.com/repos/VerveWireless/rails_warden/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VerveWireless/rails_warden/downloads","issues_url":"https://api.github.com/repos/VerveWireless/rails_warden/issues{/number}","pulls_url":"https://api.github.com/repos/VerveWireless/rails_warden/pulls{/number}","milestones_url":"https://api.github.com/repos/VerveWireless/rails_warden/milestones{/number}","notifications_url":"https://api.github.com/repos/VerveWireless/rails_warden/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VerveWireless/rails_warden/labels{/name}","releases_url":"https://api.github.com/repos/VerveWireless/rails_warden/releases{/id}","deployments_url":"https://api.github.com/repos/VerveWireless/rails_warden/deployments","created_at":"2016-11-02T22:25:31Z","updated_at":"2016-11-02T22:25:32Z","pushed_at":"2016-11-02T22:42:18Z","git_url":"git://github.com/VerveWireless/rails_warden.git","ssh_url":"git@github.com:VerveWireless/rails_warden.git","clone_url":"https://github.com/VerveWireless/rails_warden.git","svn_url":"https://github.com/VerveWireless/rails_warden","homepage":"","size":40,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hassox:master","ref":"master","sha":"729809e6b46b001abae58360342e66e28679612e","user":{"login":"hassox","id":104,"avatar_url":"https://avatars.githubusercontent.com/u/104?v=3","gravatar_id":"","url":"https://api.github.com/users/hassox","html_url":"https://github.com/hassox","followers_url":"https://api.github.com/users/hassox/followers","following_url":"https://api.github.com/users/hassox/following{/other_user}","gists_url":"https://api.github.com/users/hassox/gists{/gist_id}","starred_url":"https://api.github.com/users/hassox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hassox/subscriptions","organizations_url":"https://api.github.com/users/hassox/orgs","repos_url":"https://api.github.com/users/hassox/repos","events_url":"https://api.github.com/users/hassox/events{/privacy}","received_events_url":"https://api.github.com/users/hassox/received_events","type":"User","site_admin":false},"repo":{"id":199758,"name":"rails_warden","full_name":"hassox/rails_warden","owner":{"login":"hassox","id":104,"avatar_url":"https://avatars.githubusercontent.com/u/104?v=3","gravatar_id":"","url":"https://api.github.com/users/hassox","html_url":"https://github.com/hassox","followers_url":"https://api.github.com/users/hassox/followers","following_url":"https://api.github.com/users/hassox/following{/other_user}","gists_url":"https://api.github.com/users/hassox/gists{/gist_id}","starred_url":"https://api.github.com/users/hassox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hassox/subscriptions","organizations_url":"https://api.github.com/users/hassox/orgs","repos_url":"https://api.github.com/users/hassox/repos","events_url":"https://api.github.com/users/hassox/events{/privacy}","received_events_url":"https://api.github.com/users/hassox/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hassox/rails_warden","description":"A thin rails plugin on top of Warden for Authentication","fork":false,"url":"https://api.github.com/repos/hassox/rails_warden","forks_url":"https://api.github.com/repos/hassox/rails_warden/forks","keys_url":"https://api.github.com/repos/hassox/rails_warden/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hassox/rails_warden/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hassox/rails_warden/teams","hooks_url":"https://api.github.com/repos/hassox/rails_warden/hooks","issue_events_url":"https://api.github.com/repos/hassox/rails_warden/issues/events{/number}","events_url":"https://api.github.com/repos/hassox/rails_warden/events","assignees_url":"https://api.github.com/repos/hassox/rails_warden/assignees{/user}","branches_url":"https://api.github.com/repos/hassox/rails_warden/branches{/branch}","tags_url":"https://api.github.com/repos/hassox/rails_warden/tags","blobs_url":"https://api.github.com/repos/hassox/rails_warden/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hassox/rails_warden/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hassox/rails_warden/git/refs{/sha}","trees_url":"https://api.github.com/repos/hassox/rails_warden/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hassox/rails_warden/statuses/{sha}","languages_url":"https://api.github.com/repos/hassox/rails_warden/languages","stargazers_url":"https://api.github.com/repos/hassox/rails_warden/stargazers","contributors_url":"https://api.github.com/repos/hassox/rails_warden/contributors","subscribers_url":"https://api.github.com/repos/hassox/rails_warden/subscribers","subscription_url":"https://api.github.com/repos/hassox/rails_warden/subscription","commits_url":"https://api.github.com/repos/hassox/rails_warden/commits{/sha}","git_commits_url":"https://api.github.com/repos/hassox/rails_warden/git/commits{/sha}","comments_url":"https://api.github.com/repos/hassox/rails_warden/comments{/number}","issue_comment_url":"https://api.github.com/repos/hassox/rails_warden/issues/comments{/number}","contents_url":"https://api.github.com/repos/hassox/rails_warden/contents/{+path}","compare_url":"https://api.github.com/repos/hassox/rails_warden/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hassox/rails_warden/merges","archive_url":"https://api.github.com/repos/hassox/rails_warden/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hassox/rails_warden/downloads","issues_url":"https://api.github.com/repos/hassox/rails_warden/issues{/number}","pulls_url":"https://api.github.com/repos/hassox/rails_warden/pulls{/number}","milestones_url":"https://api.github.com/repos/hassox/rails_warden/milestones{/number}","notifications_url":"https://api.github.com/repos/hassox/rails_warden/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hassox/rails_warden/labels{/name}","releases_url":"https://api.github.com/repos/hassox/rails_warden/releases{/id}","deployments_url":"https://api.github.com/repos/hassox/rails_warden/deployments","created_at":"2009-05-13T12:16:17Z","updated_at":"2016-06-19T06:13:55Z","pushed_at":"2016-11-03T12:56:58Z","git_url":"git://github.com/hassox/rails_warden.git","ssh_url":"git@github.com:hassox/rails_warden.git","clone_url":"https://github.com/hassox/rails_warden.git","svn_url":"https://github.com/hassox/rails_warden","homepage":"","size":365,"stargazers_count":142,"watchers_count":142,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":3,"forks":23,"open_issues":3,"watchers":142,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hassox/rails_warden/pulls/24"},"html":{"href":"https://github.com/hassox/rails_warden/pull/24"},"issue":{"href":"https://api.github.com/repos/hassox/rails_warden/issues/24"},"comments":{"href":"https://api.github.com/repos/hassox/rails_warden/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/hassox/rails_warden/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/hassox/rails_warden/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hassox/rails_warden/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/hassox/rails_warden/statuses/58343bf5506bed78cd19214ad4f8916d76b12abf"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":22,"deletions":8,"changed_files":3}}
{"actor":{"display_login":"jspooner"}}