{"action":"created","issue":{"url":"https://api.github.com/repos/eclipse/vert.x/issues/1381","repository_url":"https://api.github.com/repos/eclipse/vert.x","labels_url":"https://api.github.com/repos/eclipse/vert.x/issues/1381/labels{/name}","comments_url":"https://api.github.com/repos/eclipse/vert.x/issues/1381/comments","events_url":"https://api.github.com/repos/eclipse/vert.x/issues/1381/events","html_url":"https://github.com/eclipse/vert.x/pull/1381","id":148502617,"number":1381,"title":"Add host verification to NetClient","user":{"login":"dan-lind","id":433464,"avatar_url":"https://avatars.githubusercontent.com/u/433464?v=3","gravatar_id":"","url":"https://api.github.com/users/dan-lind","html_url":"https://github.com/dan-lind","followers_url":"https://api.github.com/users/dan-lind/followers","following_url":"https://api.github.com/users/dan-lind/following{/other_user}","gists_url":"https://api.github.com/users/dan-lind/gists{/gist_id}","starred_url":"https://api.github.com/users/dan-lind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dan-lind/subscriptions","organizations_url":"https://api.github.com/users/dan-lind/orgs","repos_url":"https://api.github.com/users/dan-lind/repos","events_url":"https://api.github.com/users/dan-lind/events{/privacy}","received_events_url":"https://api.github.com/users/dan-lind/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/eclipse/vert.x/labels/to%20review","name":"to review","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-04-14T22:35:04Z","updated_at":"2016-04-16T07:05:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/eclipse/vert.x/pulls/1381","html_url":"https://github.com/eclipse/vert.x/pull/1381","diff_url":"https://github.com/eclipse/vert.x/pull/1381.diff","patch_url":"https://github.com/eclipse/vert.x/pull/1381.patch"},"body":"Add host verification to NetClient\r\nAdded missing tests for host verification to HttpTLSTest\r\n\r\nPlease note breaking change in NetSocket.java\r\npublic NetSocket upgradeToSsl(Handler<Void> handler);\r\nchanges to\r\npublic NetSocket upgradeToSsl(String host, int port, Handler<Void> handler);\r\n\r\nSigned-off-by: Daniel Lindberg <daniel.lindberg@omegapoint.se>"},"comment":{"url":"https://api.github.com/repos/eclipse/vert.x/issues/comments/210753887","html_url":"https://github.com/eclipse/vert.x/pull/1381#issuecomment-210753887","issue_url":"https://api.github.com/repos/eclipse/vert.x/issues/1381","id":210753887,"user":{"login":"dan-lind","id":433464,"avatar_url":"https://avatars.githubusercontent.com/u/433464?v=3","gravatar_id":"","url":"https://api.github.com/users/dan-lind","html_url":"https://github.com/dan-lind","followers_url":"https://api.github.com/users/dan-lind/followers","following_url":"https://api.github.com/users/dan-lind/following{/other_user}","gists_url":"https://api.github.com/users/dan-lind/gists{/gist_id}","starred_url":"https://api.github.com/users/dan-lind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dan-lind/subscriptions","organizations_url":"https://api.github.com/users/dan-lind/orgs","repos_url":"https://api.github.com/users/dan-lind/repos","events_url":"https://api.github.com/users/dan-lind/events{/privacy}","received_events_url":"https://api.github.com/users/dan-lind/received_events","type":"User","site_admin":false},"created_at":"2016-04-16T07:05:53Z","updated_at":"2016-04-16T07:05:53Z","body":"I can fix that. Only problem is that I don't really know how to test the LDAP verification..."}}