{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/9216","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/9216/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/9216/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/9216/events","html_url":"https://github.com/joomla/joomla-cms/pull/9216","id":136546353,"number":9216,"title":"Added Toggle Unpublished Modules in Menu item edit view","user":{"login":"cheiff","id":2758555,"avatar_url":"https://avatars.githubusercontent.com/u/2758555?v=3","gravatar_id":"","url":"https://api.github.com/users/cheiff","html_url":"https://github.com/cheiff","followers_url":"https://api.github.com/users/cheiff/followers","following_url":"https://api.github.com/users/cheiff/following{/other_user}","gists_url":"https://api.github.com/users/cheiff/gists{/gist_id}","starred_url":"https://api.github.com/users/cheiff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cheiff/subscriptions","organizations_url":"https://api.github.com/users/cheiff/orgs","repos_url":"https://api.github.com/users/cheiff/repos","events_url":"https://api.github.com/users/cheiff/events{/privacy}","received_events_url":"https://api.github.com/users/cheiff/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/joomla/joomla-cms/labels/Language%20Change","name":"Language Change","color":"eb6420"},{"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-25T23:35:24Z","updated_at":"2016-02-26T00:10:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/9216","html_url":"https://github.com/joomla/joomla-cms/pull/9216","diff_url":"https://github.com/joomla/joomla-cms/pull/9216.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/9216.patch"},"body":"Pull Request for a new feature.\r\n\r\n#### Summary of Changes\r\n\r\nAdded a button to toggle unpublished modules in menu item edit view, similar to toggle unassigned modules.\r\n\r\n#### Testing Instructions\r\n\r\nFrom Administrator panel, select a menu (e.g. Main Menu), select a menu item (e.g. Home). In the Module Assignment tab, there is a new column \"Published\" and a new button that allows to toggle the modules based on their status (published/unpublished).\r\nIf there are some modules and some are unpublished, clicking the button will hide them.\r\n\r\n#### Comments\r\n\r\nI let the label colour for \"Trashed\" as default (gray) after editing a module in order to be easily recognizable. On reloading, trashed modules will disappear from the view, so it is a temporary colour.\r\n\r\nI put the buttons next to each other in order to not take up more space. That is the reason for a new layout file for the fieldset. If there is a better way or I should let the buttons one on top of the other, just let me know.\r\n\r\nOne idiomatic question: I left the language strings same as for toggle unassigned menus, but, shouldn't it be \"Shows or hides modules\" instead of \"Shows or hide modules\"?\r\n\r\nThanks, regards"},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/189046967","html_url":"https://github.com/joomla/joomla-cms/pull/9216#issuecomment-189046967","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/9216","id":189046967,"user":{"login":"cheiff","id":2758555,"avatar_url":"https://avatars.githubusercontent.com/u/2758555?v=3","gravatar_id":"","url":"https://api.github.com/users/cheiff","html_url":"https://github.com/cheiff","followers_url":"https://api.github.com/users/cheiff/followers","following_url":"https://api.github.com/users/cheiff/following{/other_user}","gists_url":"https://api.github.com/users/cheiff/gists{/gist_id}","starred_url":"https://api.github.com/users/cheiff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cheiff/subscriptions","organizations_url":"https://api.github.com/users/cheiff/orgs","repos_url":"https://api.github.com/users/cheiff/repos","events_url":"https://api.github.com/users/cheiff/events{/privacy}","received_events_url":"https://api.github.com/users/cheiff/received_events","type":"User","site_admin":false},"created_at":"2016-02-26T00:10:58Z","updated_at":"2016-02-26T00:10:58Z","body":"Two screenshots showing what the PR does\r\n\r\n![togglebutton1](https://cloud.githubusercontent.com/assets/2758555/13338991/a4a5f5f4-dc25-11e5-85a9-8d3b5926a974.png)\r\n![togglebutton2](https://cloud.githubusercontent.com/assets/2758555/13338990/a46561ec-dc25-11e5-90be-2b7aeeaeed1d.png)\r\n\r\n"}}