{"action":"created","issue":{"url":"https://api.github.com/repos/rails/rails/issues/23996","repository_url":"https://api.github.com/repos/rails/rails","labels_url":"https://api.github.com/repos/rails/rails/issues/23996/labels{/name}","comments_url":"https://api.github.com/repos/rails/rails/issues/23996/comments","events_url":"https://api.github.com/repos/rails/rails/issues/23996/events","html_url":"https://github.com/rails/rails/pull/23996","id":137767771,"number":23996,"title":"[WIP] Fix #23964 with response.body(should_send)","user":{"login":"rthbound","id":708692,"avatar_url":"https://avatars.githubusercontent.com/u/708692?v=3","gravatar_id":"","url":"https://api.github.com/users/rthbound","html_url":"https://github.com/rthbound","followers_url":"https://api.github.com/users/rthbound/followers","following_url":"https://api.github.com/users/rthbound/following{/other_user}","gists_url":"https://api.github.com/users/rthbound/gists{/gist_id}","starred_url":"https://api.github.com/users/rthbound/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rthbound/subscriptions","organizations_url":"https://api.github.com/users/rthbound/orgs","repos_url":"https://api.github.com/users/rthbound/repos","events_url":"https://api.github.com/users/rthbound/events{/privacy}","received_events_url":"https://api.github.com/users/rthbound/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"schneems","id":59744,"avatar_url":"https://avatars.githubusercontent.com/u/59744?v=3","gravatar_id":"","url":"https://api.github.com/users/schneems","html_url":"https://github.com/schneems","followers_url":"https://api.github.com/users/schneems/followers","following_url":"https://api.github.com/users/schneems/following{/other_user}","gists_url":"https://api.github.com/users/schneems/gists{/gist_id}","starred_url":"https://api.github.com/users/schneems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schneems/subscriptions","organizations_url":"https://api.github.com/users/schneems/orgs","repos_url":"https://api.github.com/users/schneems/repos","events_url":"https://api.github.com/users/schneems/events{/privacy}","received_events_url":"https://api.github.com/users/schneems/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2016-03-02T04:15:16Z","updated_at":"2016-03-02T04:15:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/23996","html_url":"https://github.com/rails/rails/pull/23996","diff_url":"https://github.com/rails/rails/pull/23996.diff","patch_url":"https://github.com/rails/rails/pull/23996.patch"},"body":"### Summary\r\n\r\nA developer might need to access `response.body` before actually sending the response. Currently, a side effect of accessing `response.body` is the raising of some flags (`@sending == @sent == @committed == true`) and freezing of response headers. For a user to access `request.body` as he/she normally would, the default behavior should be to not raise those flags and to not freeze the headers.\r\n\r\n### Other Information\r\n\r\n  - defaults to false (don't send) so user's can continue using\r\n    response.body\r\n  - response.body(should_send = false) would allow users to read the\r\n    response body without raising the sending, sent, committed flags\r\n    and without freezing the response headers\r\n  - - [ ] would want to call response.body(should_send = true) when we actually send"},"comment":{"url":"https://api.github.com/repos/rails/rails/issues/comments/191049873","html_url":"https://github.com/rails/rails/pull/23996#issuecomment-191049873","issue_url":"https://api.github.com/repos/rails/rails/issues/23996","id":191049873,"user":{"login":"rails-bot","id":7468109,"avatar_url":"https://avatars.githubusercontent.com/u/7468109?v=3","gravatar_id":"","url":"https://api.github.com/users/rails-bot","html_url":"https://github.com/rails-bot","followers_url":"https://api.github.com/users/rails-bot/followers","following_url":"https://api.github.com/users/rails-bot/following{/other_user}","gists_url":"https://api.github.com/users/rails-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/rails-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails-bot/subscriptions","organizations_url":"https://api.github.com/users/rails-bot/orgs","repos_url":"https://api.github.com/users/rails-bot/repos","events_url":"https://api.github.com/users/rails-bot/events{/privacy}","received_events_url":"https://api.github.com/users/rails-bot/received_events","type":"User","site_admin":false},"created_at":"2016-03-02T04:15:18Z","updated_at":"2016-03-02T04:15:18Z","body":"Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon.\n\nIf any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.\n\nPlease see [the contribution instructions](http://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html) for more information.\n"}}