{"action":"closed","issue":{"url":"https://api.github.com/repos/PierreRaybaut/formlayout/issues/35","repository_url":"https://api.github.com/repos/PierreRaybaut/formlayout","labels_url":"https://api.github.com/repos/PierreRaybaut/formlayout/issues/35/labels{/name}","comments_url":"https://api.github.com/repos/PierreRaybaut/formlayout/issues/35/comments","events_url":"https://api.github.com/repos/PierreRaybaut/formlayout/issues/35/events","html_url":"https://github.com/PierreRaybaut/formlayout/issues/35","id":156221077,"number":35,"title":"Ensure compatibility with PyQt4 v4.4 (and earlier) by keeping old-style signals and slots","user":{"login":"PierreRaybaut","id":1311787,"avatar_url":"https://avatars.githubusercontent.com/u/1311787?v=3","gravatar_id":"","url":"https://api.github.com/users/PierreRaybaut","html_url":"https://github.com/PierreRaybaut","followers_url":"https://api.github.com/users/PierreRaybaut/followers","following_url":"https://api.github.com/users/PierreRaybaut/following{/other_user}","gists_url":"https://api.github.com/users/PierreRaybaut/gists{/gist_id}","starred_url":"https://api.github.com/users/PierreRaybaut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PierreRaybaut/subscriptions","organizations_url":"https://api.github.com/users/PierreRaybaut/orgs","repos_url":"https://api.github.com/users/PierreRaybaut/repos","events_url":"https://api.github.com/users/PierreRaybaut/events{/privacy}","received_events_url":"https://api.github.com/users/PierreRaybaut/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/PierreRaybaut/formlayout/labels/bug","name":"bug","color":"fc2929"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-05-23T08:02:01Z","updated_at":"2016-05-25T09:58:18Z","closed_at":"2016-05-25T09:58:18Z","body":"I have noticed that we progressively forgot to ensure compatibility with old-style signals and slots.\r\n\r\nUnfortunately, that is not something we can test with travis because compatibility issues will cause silent fails (slots will not be triggered by emitted signals).\r\n\r\nHere is what need to be fixed.\r\nAll occurences of the `QObject` method named `connect` need to be handled this way.\r\nThe following example:\r\n```python\r\nself.widget.valueChanged.connect(layout.update)\r\n```\r\nshould be replaced by:\r\n```python\r\nif SIGNAL is None:\r\n    self.widget.valueChanged.connect(layout.update)\r\nelse:\r\n    self.connect(self.widget, SIGNAL(\"valueChanged(int)\"), layout.update)\r\n```"}}
{"actor":{"display_login":"PierreRaybaut"}}