{"action":"created","comment":{"url":"https://api.github.com/repos/openucx/ucx/pulls/comments/53947071","id":53947071,"diff_hunk":"@@ -153,15 +194,19 @@ struct uct_ud_ep {\n          uct_ud_psn_t           psn;          /* Next PSN to send */\n          uct_ud_psn_t           max_psn;      /* Largest PSN that can be sent - (ack_psn + window) (from incoming packet) */\n          uct_ud_psn_t           acked_psn;    /* last psn that was acked by remote side */\n-         uct_ud_psn_t           rt_psn;       /* last psn that was retransmitted */\n          ucs_queue_head_t       window;       /* send window */\n          uct_ud_ep_pending_op_t pending;      /* pending ops */\n          ucs_time_t             send_time;    /* tx time of last packet */\n-         ucs_queue_iter_t       rt_pos;       /* points to the part of tx window that needs to be resent */\n          UCS_STATS_NODE_DECLARE(stats);\n          UCT_UD_EP_HOOK_DECLARE(tx_hook);\n     } tx;\n     struct {\n+         uct_ud_psn_t           psn;       /* last psn that was retransmitted */\n+         uct_ud_psn_t           max_psn;   /* max psn that should be retransmitted */\n+         ucs_queue_iter_t       pos;       /* points to the part of tx window that needs to be resent */\n+         char                   is_active; /* resend operation is in progress */","path":"src/uct/ib/ud/base/ud_ep.h","position":64,"original_position":64,"commit_id":"a2897ab9aae4127ac352fb4230c549e334e3c39f","original_commit_id":"a2897ab9aae4127ac352fb4230c549e334e3c39f","user":{"login":"yosefe","id":2255631,"avatar_url":"https://avatars.githubusercontent.com/u/2255631?v=3","gravatar_id":"","url":"https://api.github.com/users/yosefe","html_url":"https://github.com/yosefe","followers_url":"https://api.github.com/users/yosefe/followers","following_url":"https://api.github.com/users/yosefe/following{/other_user}","gists_url":"https://api.github.com/users/yosefe/gists{/gist_id}","starred_url":"https://api.github.com/users/yosefe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yosefe/subscriptions","organizations_url":"https://api.github.com/users/yosefe/orgs","repos_url":"https://api.github.com/users/yosefe/repos","events_url":"https://api.github.com/users/yosefe/events{/privacy}","received_events_url":"https://api.github.com/users/yosefe/received_events","type":"User","site_admin":false},"body":"maybe better to declare this struct as packed. is it possible to eliminate some fields to reduce memory footprint?","created_at":"2016-02-24T14:42:59Z","updated_at":"2016-02-24T14:42:59Z","html_url":"https://github.com/openucx/ucx/pull/650#discussion_r53947071","pull_request_url":"https://api.github.com/repos/openucx/ucx/pulls/650","_links":{"self":{"href":"https://api.github.com/repos/openucx/ucx/pulls/comments/53947071"},"html":{"href":"https://github.com/openucx/ucx/pull/650#discussion_r53947071"},"pull_request":{"href":"https://api.github.com/repos/openucx/ucx/pulls/650"}}},"pull_request":{"url":"https://api.github.com/repos/openucx/ucx/pulls/650","id":60517398,"html_url":"https://github.com/openucx/ucx/pull/650","diff_url":"https://github.com/openucx/ucx/pull/650.diff","patch_url":"https://github.com/openucx/ucx/pull/650.patch","issue_url":"https://api.github.com/repos/openucx/ucx/issues/650","number":650,"state":"open","locked":false,"title":"UCT/UD: resend more packets if ack is received","user":{"login":"alex-mikheev","id":8735389,"avatar_url":"https://avatars.githubusercontent.com/u/8735389?v=3","gravatar_id":"","url":"https://api.github.com/users/alex-mikheev","html_url":"https://github.com/alex-mikheev","followers_url":"https://api.github.com/users/alex-mikheev/followers","following_url":"https://api.github.com/users/alex-mikheev/following{/other_user}","gists_url":"https://api.github.com/users/alex-mikheev/gists{/gist_id}","starred_url":"https://api.github.com/users/alex-mikheev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex-mikheev/subscriptions","organizations_url":"https://api.github.com/users/alex-mikheev/orgs","repos_url":"https://api.github.com/users/alex-mikheev/repos","events_url":"https://api.github.com/users/alex-mikheev/events{/privacy}","received_events_url":"https://api.github.com/users/alex-mikheev/received_events","type":"User","site_admin":false},"body":"@yosefe \r\nDoing this will keep retransmit going if receiver keeps sending acks.\r\n\r\nOtherwise it was possible to get to the situation where cwnd allows\r\nresending only one packet a time.","created_at":"2016-02-24T14:33:53Z","updated_at":"2016-02-24T14:42:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b073c3a8a0d9500fac9e4a346f10ac21fc450fb9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openucx/ucx/pulls/650/commits","review_comments_url":"https://api.github.com/repos/openucx/ucx/pulls/650/comments","review_comment_url":"https://api.github.com/repos/openucx/ucx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openucx/ucx/issues/650/comments","statuses_url":"https://api.github.com/repos/openucx/ucx/statuses/a2897ab9aae4127ac352fb4230c549e334e3c39f","head":{"label":"alex-mikheev:topic/ud_resend_refactor","ref":"topic/ud_resend_refactor","sha":"a2897ab9aae4127ac352fb4230c549e334e3c39f","user":{"login":"alex-mikheev","id":8735389,"avatar_url":"https://avatars.githubusercontent.com/u/8735389?v=3","gravatar_id":"","url":"https://api.github.com/users/alex-mikheev","html_url":"https://github.com/alex-mikheev","followers_url":"https://api.github.com/users/alex-mikheev/followers","following_url":"https://api.github.com/users/alex-mikheev/following{/other_user}","gists_url":"https://api.github.com/users/alex-mikheev/gists{/gist_id}","starred_url":"https://api.github.com/users/alex-mikheev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex-mikheev/subscriptions","organizations_url":"https://api.github.com/users/alex-mikheev/orgs","repos_url":"https://api.github.com/users/alex-mikheev/repos","events_url":"https://api.github.com/users/alex-mikheev/events{/privacy}","received_events_url":"https://api.github.com/users/alex-mikheev/received_events","type":"User","site_admin":false},"repo":{"id":27329497,"name":"ucx","full_name":"alex-mikheev/ucx","owner":{"login":"alex-mikheev","id":8735389,"avatar_url":"https://avatars.githubusercontent.com/u/8735389?v=3","gravatar_id":"","url":"https://api.github.com/users/alex-mikheev","html_url":"https://github.com/alex-mikheev","followers_url":"https://api.github.com/users/alex-mikheev/followers","following_url":"https://api.github.com/users/alex-mikheev/following{/other_user}","gists_url":"https://api.github.com/users/alex-mikheev/gists{/gist_id}","starred_url":"https://api.github.com/users/alex-mikheev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex-mikheev/subscriptions","organizations_url":"https://api.github.com/users/alex-mikheev/orgs","repos_url":"https://api.github.com/users/alex-mikheev/repos","events_url":"https://api.github.com/users/alex-mikheev/events{/privacy}","received_events_url":"https://api.github.com/users/alex-mikheev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alex-mikheev/ucx","description":"The UCX","fork":true,"url":"https://api.github.com/repos/alex-mikheev/ucx","forks_url":"https://api.github.com/repos/alex-mikheev/ucx/forks","keys_url":"https://api.github.com/repos/alex-mikheev/ucx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alex-mikheev/ucx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alex-mikheev/ucx/teams","hooks_url":"https://api.github.com/repos/alex-mikheev/ucx/hooks","issue_events_url":"https://api.github.com/repos/alex-mikheev/ucx/issues/events{/number}","events_url":"https://api.github.com/repos/alex-mikheev/ucx/events","assignees_url":"https://api.github.com/repos/alex-mikheev/ucx/assignees{/user}","branches_url":"https://api.github.com/repos/alex-mikheev/ucx/branches{/branch}","tags_url":"https://api.github.com/repos/alex-mikheev/ucx/tags","blobs_url":"https://api.github.com/repos/alex-mikheev/ucx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alex-mikheev/ucx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alex-mikheev/ucx/git/refs{/sha}","trees_url":"https://api.github.com/repos/alex-mikheev/ucx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alex-mikheev/ucx/statuses/{sha}","languages_url":"https://api.github.com/repos/alex-mikheev/ucx/languages","stargazers_url":"https://api.github.com/repos/alex-mikheev/ucx/stargazers","contributors_url":"https://api.github.com/repos/alex-mikheev/ucx/contributors","subscribers_url":"https://api.github.com/repos/alex-mikheev/ucx/subscribers","subscription_url":"https://api.github.com/repos/alex-mikheev/ucx/subscription","commits_url":"https://api.github.com/repos/alex-mikheev/ucx/commits{/sha}","git_commits_url":"https://api.github.com/repos/alex-mikheev/ucx/git/commits{/sha}","comments_url":"https://api.github.com/repos/alex-mikheev/ucx/comments{/number}","issue_comment_url":"https://api.github.com/repos/alex-mikheev/ucx/issues/comments{/number}","contents_url":"https://api.github.com/repos/alex-mikheev/ucx/contents/{+path}","compare_url":"https://api.github.com/repos/alex-mikheev/ucx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alex-mikheev/ucx/merges","archive_url":"https://api.github.com/repos/alex-mikheev/ucx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alex-mikheev/ucx/downloads","issues_url":"https://api.github.com/repos/alex-mikheev/ucx/issues{/number}","pulls_url":"https://api.github.com/repos/alex-mikheev/ucx/pulls{/number}","milestones_url":"https://api.github.com/repos/alex-mikheev/ucx/milestones{/number}","notifications_url":"https://api.github.com/repos/alex-mikheev/ucx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alex-mikheev/ucx/labels{/name}","releases_url":"https://api.github.com/repos/alex-mikheev/ucx/releases{/id}","deployments_url":"https://api.github.com/repos/alex-mikheev/ucx/deployments","created_at":"2014-11-30T08:32:27Z","updated_at":"2015-07-14T14:20:06Z","pushed_at":"2016-02-24T14:30:30Z","git_url":"git://github.com/alex-mikheev/ucx.git","ssh_url":"git@github.com:alex-mikheev/ucx.git","clone_url":"https://github.com/alex-mikheev/ucx.git","svn_url":"https://github.com/alex-mikheev/ucx","homepage":"","size":4137,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openucx:master","ref":"master","sha":"5928f1abdf878301f534218f98a9228a7e679411","user":{"login":"openucx","id":13118737,"avatar_url":"https://avatars.githubusercontent.com/u/13118737?v=3","gravatar_id":"","url":"https://api.github.com/users/openucx","html_url":"https://github.com/openucx","followers_url":"https://api.github.com/users/openucx/followers","following_url":"https://api.github.com/users/openucx/following{/other_user}","gists_url":"https://api.github.com/users/openucx/gists{/gist_id}","starred_url":"https://api.github.com/users/openucx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openucx/subscriptions","organizations_url":"https://api.github.com/users/openucx/orgs","repos_url":"https://api.github.com/users/openucx/repos","events_url":"https://api.github.com/users/openucx/events{/privacy}","received_events_url":"https://api.github.com/users/openucx/received_events","type":"Organization","site_admin":false},"repo":{"id":25379390,"name":"ucx","full_name":"openucx/ucx","owner":{"login":"openucx","id":13118737,"avatar_url":"https://avatars.githubusercontent.com/u/13118737?v=3","gravatar_id":"","url":"https://api.github.com/users/openucx","html_url":"https://github.com/openucx","followers_url":"https://api.github.com/users/openucx/followers","following_url":"https://api.github.com/users/openucx/following{/other_user}","gists_url":"https://api.github.com/users/openucx/gists{/gist_id}","starred_url":"https://api.github.com/users/openucx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openucx/subscriptions","organizations_url":"https://api.github.com/users/openucx/orgs","repos_url":"https://api.github.com/users/openucx/repos","events_url":"https://api.github.com/users/openucx/events{/privacy}","received_events_url":"https://api.github.com/users/openucx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openucx/ucx","description":"Unified Communication X  (mailing list - https://elist.ornl.gov/mailman/listinfo/ucx-group): ","fork":false,"url":"https://api.github.com/repos/openucx/ucx","forks_url":"https://api.github.com/repos/openucx/ucx/forks","keys_url":"https://api.github.com/repos/openucx/ucx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openucx/ucx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openucx/ucx/teams","hooks_url":"https://api.github.com/repos/openucx/ucx/hooks","issue_events_url":"https://api.github.com/repos/openucx/ucx/issues/events{/number}","events_url":"https://api.github.com/repos/openucx/ucx/events","assignees_url":"https://api.github.com/repos/openucx/ucx/assignees{/user}","branches_url":"https://api.github.com/repos/openucx/ucx/branches{/branch}","tags_url":"https://api.github.com/repos/openucx/ucx/tags","blobs_url":"https://api.github.com/repos/openucx/ucx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openucx/ucx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openucx/ucx/git/refs{/sha}","trees_url":"https://api.github.com/repos/openucx/ucx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openucx/ucx/statuses/{sha}","languages_url":"https://api.github.com/repos/openucx/ucx/languages","stargazers_url":"https://api.github.com/repos/openucx/ucx/stargazers","contributors_url":"https://api.github.com/repos/openucx/ucx/contributors","subscribers_url":"https://api.github.com/repos/openucx/ucx/subscribers","subscription_url":"https://api.github.com/repos/openucx/ucx/subscription","commits_url":"https://api.github.com/repos/openucx/ucx/commits{/sha}","git_commits_url":"https://api.github.com/repos/openucx/ucx/git/commits{/sha}","comments_url":"https://api.github.com/repos/openucx/ucx/comments{/number}","issue_comment_url":"https://api.github.com/repos/openucx/ucx/issues/comments{/number}","contents_url":"https://api.github.com/repos/openucx/ucx/contents/{+path}","compare_url":"https://api.github.com/repos/openucx/ucx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openucx/ucx/merges","archive_url":"https://api.github.com/repos/openucx/ucx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openucx/ucx/downloads","issues_url":"https://api.github.com/repos/openucx/ucx/issues{/number}","pulls_url":"https://api.github.com/repos/openucx/ucx/pulls{/number}","milestones_url":"https://api.github.com/repos/openucx/ucx/milestones{/number}","notifications_url":"https://api.github.com/repos/openucx/ucx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openucx/ucx/labels{/name}","releases_url":"https://api.github.com/repos/openucx/ucx/releases{/id}","deployments_url":"https://api.github.com/repos/openucx/ucx/deployments","created_at":"2014-10-17T22:17:24Z","updated_at":"2016-02-01T08:04:14Z","pushed_at":"2016-02-24T14:33:53Z","git_url":"git://github.com/openucx/ucx.git","ssh_url":"git@github.com:openucx/ucx.git","clone_url":"https://github.com/openucx/ucx.git","svn_url":"https://github.com/openucx/ucx","homepage":" http://www.openucx.org","size":5955,"stargazers_count":27,"watchers_count":27,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":27,"mirror_url":null,"open_issues_count":53,"forks":27,"open_issues":53,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openucx/ucx/pulls/650"},"html":{"href":"https://github.com/openucx/ucx/pull/650"},"issue":{"href":"https://api.github.com/repos/openucx/ucx/issues/650"},"comments":{"href":"https://api.github.com/repos/openucx/ucx/issues/650/comments"},"review_comments":{"href":"https://api.github.com/repos/openucx/ucx/pulls/650/comments"},"review_comment":{"href":"https://api.github.com/repos/openucx/ucx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openucx/ucx/pulls/650/commits"},"statuses":{"href":"https://api.github.com/repos/openucx/ucx/statuses/a2897ab9aae4127ac352fb4230c549e334e3c39f"}}}}