{"action":"created","comment":{"url":"https://api.github.com/repos/buildbot/buildbot/pulls/comments/70415362","id":70415362,"diff_hunk":"@@ -199,12 +225,29 @@ def addBuildUrls(self, rclist):\n     def run(self):\n         schedulers_and_props = yield self.getSchedulersAndProperties()\n \n+        schedulers_and_props_list = []\n+        \n+        # To be back compatible we need to differ between old and new style\n+        # schedulers_and_props can either consist of 2 elements tuple or dictionary\n+        for element in schedulers_and_props:\n+            if type(element) == dict:\n+                schedulers_and_props_list.append(element)","path":"master/buildbot/steps/trigger.py","position":84,"original_position":84,"commit_id":"e3340dd91074b694863d7d009613913622fe9686","original_commit_id":"e3340dd91074b694863d7d009613913622fe9686","user":{"login":"tardyp","id":109859,"avatar_url":"https://avatars.githubusercontent.com/u/109859?v=3","gravatar_id":"","url":"https://api.github.com/users/tardyp","html_url":"https://github.com/tardyp","followers_url":"https://api.github.com/users/tardyp/followers","following_url":"https://api.github.com/users/tardyp/following{/other_user}","gists_url":"https://api.github.com/users/tardyp/gists{/gist_id}","starred_url":"https://api.github.com/users/tardyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tardyp/subscriptions","organizations_url":"https://api.github.com/users/tardyp/orgs","repos_url":"https://api.github.com/users/tardyp/repos","events_url":"https://api.github.com/users/tardyp/events{/privacy}","received_events_url":"https://api.github.com/users/tardyp/received_events","type":"User","site_admin":false},"body":"I would do short path:\r\nschedulers_and_props_list = schedulers_and_props\r\nbreak","created_at":"2016-07-12T10:40:09Z","updated_at":"2016-07-12T10:40:09Z","html_url":"https://github.com/buildbot/buildbot/pull/2315#discussion_r70415362","pull_request_url":"https://api.github.com/repos/buildbot/buildbot/pulls/2315","_links":{"self":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/comments/70415362"},"html":{"href":"https://github.com/buildbot/buildbot/pull/2315#discussion_r70415362"},"pull_request":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/2315"}}},"pull_request":{"url":"https://api.github.com/repos/buildbot/buildbot/pulls/2315","id":76986002,"html_url":"https://github.com/buildbot/buildbot/pull/2315","diff_url":"https://github.com/buildbot/buildbot/pull/2315.diff","patch_url":"https://github.com/buildbot/buildbot/pull/2315.patch","issue_url":"https://api.github.com/repos/buildbot/buildbot/issues/2315","number":2315,"state":"open","locked":false,"title":"Non critical triggered schedulers","user":{"login":"Riziero","id":965018,"avatar_url":"https://avatars.githubusercontent.com/u/965018?v=3","gravatar_id":"","url":"https://api.github.com/users/Riziero","html_url":"https://github.com/Riziero","followers_url":"https://api.github.com/users/Riziero/followers","following_url":"https://api.github.com/users/Riziero/following{/other_user}","gists_url":"https://api.github.com/users/Riziero/gists{/gist_id}","starred_url":"https://api.github.com/users/Riziero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Riziero/subscriptions","organizations_url":"https://api.github.com/users/Riziero/orgs","repos_url":"https://api.github.com/users/Riziero/repos","events_url":"https://api.github.com/users/Riziero/events{/privacy}","received_events_url":"https://api.github.com/users/Riziero/received_events","type":"User","site_admin":false},"body":"![capture](https://cloud.githubusercontent.com/assets/965018/16738825/a94bbafc-4797-11e6-98c3-8ecc6d440805.PNG)\r\n","created_at":"2016-07-11T16:46:29Z","updated_at":"2016-07-12T10:40:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c56c564f3602198dc8acd60ee953ee5f03bddf0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/buildbot/buildbot/pulls/2315/commits","review_comments_url":"https://api.github.com/repos/buildbot/buildbot/pulls/2315/comments","review_comment_url":"https://api.github.com/repos/buildbot/buildbot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/buildbot/buildbot/issues/2315/comments","statuses_url":"https://api.github.com/repos/buildbot/buildbot/statuses/e3340dd91074b694863d7d009613913622fe9686","head":{"label":"Riziero:non_critical_triggered_schedulers","ref":"non_critical_triggered_schedulers","sha":"e3340dd91074b694863d7d009613913622fe9686","user":{"login":"Riziero","id":965018,"avatar_url":"https://avatars.githubusercontent.com/u/965018?v=3","gravatar_id":"","url":"https://api.github.com/users/Riziero","html_url":"https://github.com/Riziero","followers_url":"https://api.github.com/users/Riziero/followers","following_url":"https://api.github.com/users/Riziero/following{/other_user}","gists_url":"https://api.github.com/users/Riziero/gists{/gist_id}","starred_url":"https://api.github.com/users/Riziero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Riziero/subscriptions","organizations_url":"https://api.github.com/users/Riziero/orgs","repos_url":"https://api.github.com/users/Riziero/repos","events_url":"https://api.github.com/users/Riziero/events{/privacy}","received_events_url":"https://api.github.com/users/Riziero/received_events","type":"User","site_admin":false},"repo":{"id":62386045,"name":"buildbot","full_name":"Riziero/buildbot","owner":{"login":"Riziero","id":965018,"avatar_url":"https://avatars.githubusercontent.com/u/965018?v=3","gravatar_id":"","url":"https://api.github.com/users/Riziero","html_url":"https://github.com/Riziero","followers_url":"https://api.github.com/users/Riziero/followers","following_url":"https://api.github.com/users/Riziero/following{/other_user}","gists_url":"https://api.github.com/users/Riziero/gists{/gist_id}","starred_url":"https://api.github.com/users/Riziero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Riziero/subscriptions","organizations_url":"https://api.github.com/users/Riziero/orgs","repos_url":"https://api.github.com/users/Riziero/repos","events_url":"https://api.github.com/users/Riziero/events{/privacy}","received_events_url":"https://api.github.com/users/Riziero/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Riziero/buildbot","description":"Python-based continuous integration testing framework; your pull requests are more than welcome!","fork":true,"url":"https://api.github.com/repos/Riziero/buildbot","forks_url":"https://api.github.com/repos/Riziero/buildbot/forks","keys_url":"https://api.github.com/repos/Riziero/buildbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Riziero/buildbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Riziero/buildbot/teams","hooks_url":"https://api.github.com/repos/Riziero/buildbot/hooks","issue_events_url":"https://api.github.com/repos/Riziero/buildbot/issues/events{/number}","events_url":"https://api.github.com/repos/Riziero/buildbot/events","assignees_url":"https://api.github.com/repos/Riziero/buildbot/assignees{/user}","branches_url":"https://api.github.com/repos/Riziero/buildbot/branches{/branch}","tags_url":"https://api.github.com/repos/Riziero/buildbot/tags","blobs_url":"https://api.github.com/repos/Riziero/buildbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Riziero/buildbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Riziero/buildbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/Riziero/buildbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Riziero/buildbot/statuses/{sha}","languages_url":"https://api.github.com/repos/Riziero/buildbot/languages","stargazers_url":"https://api.github.com/repos/Riziero/buildbot/stargazers","contributors_url":"https://api.github.com/repos/Riziero/buildbot/contributors","subscribers_url":"https://api.github.com/repos/Riziero/buildbot/subscribers","subscription_url":"https://api.github.com/repos/Riziero/buildbot/subscription","commits_url":"https://api.github.com/repos/Riziero/buildbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/Riziero/buildbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/Riziero/buildbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/Riziero/buildbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/Riziero/buildbot/contents/{+path}","compare_url":"https://api.github.com/repos/Riziero/buildbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Riziero/buildbot/merges","archive_url":"https://api.github.com/repos/Riziero/buildbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Riziero/buildbot/downloads","issues_url":"https://api.github.com/repos/Riziero/buildbot/issues{/number}","pulls_url":"https://api.github.com/repos/Riziero/buildbot/pulls{/number}","milestones_url":"https://api.github.com/repos/Riziero/buildbot/milestones{/number}","notifications_url":"https://api.github.com/repos/Riziero/buildbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Riziero/buildbot/labels{/name}","releases_url":"https://api.github.com/repos/Riziero/buildbot/releases{/id}","deployments_url":"https://api.github.com/repos/Riziero/buildbot/deployments","created_at":"2016-07-01T10:42:06Z","updated_at":"2016-07-01T10:42:12Z","pushed_at":"2016-07-12T10:02:09Z","git_url":"git://github.com/Riziero/buildbot.git","ssh_url":"git@github.com:Riziero/buildbot.git","clone_url":"https://github.com/Riziero/buildbot.git","svn_url":"https://github.com/Riziero/buildbot","homepage":"http://buildbot.net","size":44168,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"buildbot:master","ref":"master","sha":"00a48de507452dffdea5be7891afdc13b4f7996a","user":{"login":"buildbot","id":324515,"avatar_url":"https://avatars.githubusercontent.com/u/324515?v=3","gravatar_id":"","url":"https://api.github.com/users/buildbot","html_url":"https://github.com/buildbot","followers_url":"https://api.github.com/users/buildbot/followers","following_url":"https://api.github.com/users/buildbot/following{/other_user}","gists_url":"https://api.github.com/users/buildbot/gists{/gist_id}","starred_url":"https://api.github.com/users/buildbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildbot/subscriptions","organizations_url":"https://api.github.com/users/buildbot/orgs","repos_url":"https://api.github.com/users/buildbot/repos","events_url":"https://api.github.com/users/buildbot/events{/privacy}","received_events_url":"https://api.github.com/users/buildbot/received_events","type":"Organization","site_admin":false},"repo":{"id":760165,"name":"buildbot","full_name":"buildbot/buildbot","owner":{"login":"buildbot","id":324515,"avatar_url":"https://avatars.githubusercontent.com/u/324515?v=3","gravatar_id":"","url":"https://api.github.com/users/buildbot","html_url":"https://github.com/buildbot","followers_url":"https://api.github.com/users/buildbot/followers","following_url":"https://api.github.com/users/buildbot/following{/other_user}","gists_url":"https://api.github.com/users/buildbot/gists{/gist_id}","starred_url":"https://api.github.com/users/buildbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildbot/subscriptions","organizations_url":"https://api.github.com/users/buildbot/orgs","repos_url":"https://api.github.com/users/buildbot/repos","events_url":"https://api.github.com/users/buildbot/events{/privacy}","received_events_url":"https://api.github.com/users/buildbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/buildbot/buildbot","description":"Python-based continuous integration testing framework; your pull requests are more than welcome!","fork":false,"url":"https://api.github.com/repos/buildbot/buildbot","forks_url":"https://api.github.com/repos/buildbot/buildbot/forks","keys_url":"https://api.github.com/repos/buildbot/buildbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buildbot/buildbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buildbot/buildbot/teams","hooks_url":"https://api.github.com/repos/buildbot/buildbot/hooks","issue_events_url":"https://api.github.com/repos/buildbot/buildbot/issues/events{/number}","events_url":"https://api.github.com/repos/buildbot/buildbot/events","assignees_url":"https://api.github.com/repos/buildbot/buildbot/assignees{/user}","branches_url":"https://api.github.com/repos/buildbot/buildbot/branches{/branch}","tags_url":"https://api.github.com/repos/buildbot/buildbot/tags","blobs_url":"https://api.github.com/repos/buildbot/buildbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buildbot/buildbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buildbot/buildbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/buildbot/buildbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buildbot/buildbot/statuses/{sha}","languages_url":"https://api.github.com/repos/buildbot/buildbot/languages","stargazers_url":"https://api.github.com/repos/buildbot/buildbot/stargazers","contributors_url":"https://api.github.com/repos/buildbot/buildbot/contributors","subscribers_url":"https://api.github.com/repos/buildbot/buildbot/subscribers","subscription_url":"https://api.github.com/repos/buildbot/buildbot/subscription","commits_url":"https://api.github.com/repos/buildbot/buildbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/buildbot/buildbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/buildbot/buildbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/buildbot/buildbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/buildbot/buildbot/contents/{+path}","compare_url":"https://api.github.com/repos/buildbot/buildbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buildbot/buildbot/merges","archive_url":"https://api.github.com/repos/buildbot/buildbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buildbot/buildbot/downloads","issues_url":"https://api.github.com/repos/buildbot/buildbot/issues{/number}","pulls_url":"https://api.github.com/repos/buildbot/buildbot/pulls{/number}","milestones_url":"https://api.github.com/repos/buildbot/buildbot/milestones{/number}","notifications_url":"https://api.github.com/repos/buildbot/buildbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buildbot/buildbot/labels{/name}","releases_url":"https://api.github.com/repos/buildbot/buildbot/releases{/id}","deployments_url":"https://api.github.com/repos/buildbot/buildbot/deployments","created_at":"2010-07-06T17:56:53Z","updated_at":"2016-07-12T00:51:42Z","pushed_at":"2016-07-12T10:02:11Z","git_url":"git://github.com/buildbot/buildbot.git","ssh_url":"git@github.com:buildbot/buildbot.git","clone_url":"https://github.com/buildbot/buildbot.git","svn_url":"https://github.com/buildbot/buildbot","homepage":"http://buildbot.net","size":93451,"stargazers_count":2234,"watchers_count":2234,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":918,"mirror_url":null,"open_issues_count":11,"forks":918,"open_issues":11,"watchers":2234,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/2315"},"html":{"href":"https://github.com/buildbot/buildbot/pull/2315"},"issue":{"href":"https://api.github.com/repos/buildbot/buildbot/issues/2315"},"comments":{"href":"https://api.github.com/repos/buildbot/buildbot/issues/2315/comments"},"review_comments":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/2315/comments"},"review_comment":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/2315/commits"},"statuses":{"href":"https://api.github.com/repos/buildbot/buildbot/statuses/e3340dd91074b694863d7d009613913622fe9686"}}}}
{"actor":{"display_login":"tardyp"}}