{"action":"created","issue":{"url":"https://api.github.com/repos/analogdevicesinc/fru_tools/issues/4","repository_url":"https://api.github.com/repos/analogdevicesinc/fru_tools","labels_url":"https://api.github.com/repos/analogdevicesinc/fru_tools/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/analogdevicesinc/fru_tools/issues/4/comments","events_url":"https://api.github.com/repos/analogdevicesinc/fru_tools/issues/4/events","html_url":"https://github.com/analogdevicesinc/fru_tools/pull/4","id":170604219,"number":4,"title":"product info and multirecord picmg support","user":{"login":"bspruck","id":1573461,"avatar_url":"https://avatars.githubusercontent.com/u/1573461?v=3","gravatar_id":"","url":"https://api.github.com/users/bspruck","html_url":"https://github.com/bspruck","followers_url":"https://api.github.com/users/bspruck/followers","following_url":"https://api.github.com/users/bspruck/following{/other_user}","gists_url":"https://api.github.com/users/bspruck/gists{/gist_id}","starred_url":"https://api.github.com/users/bspruck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bspruck/subscriptions","organizations_url":"https://api.github.com/users/bspruck/orgs","repos_url":"https://api.github.com/users/bspruck/repos","events_url":"https://api.github.com/users/bspruck/events{/privacy}","received_events_url":"https://api.github.com/users/bspruck/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-11T09:28:49Z","updated_at":"2016-08-11T11:51:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/analogdevicesinc/fru_tools/pulls/4","html_url":"https://github.com/analogdevicesinc/fru_tools/pull/4","diff_url":"https://github.com/analogdevicesinc/fru_tools/pull/4.diff","patch_url":"https://github.com/analogdevicesinc/fru_tools/pull/4.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/analogdevicesinc/fru_tools/issues/comments/239139762","html_url":"https://github.com/analogdevicesinc/fru_tools/pull/4#issuecomment-239139762","issue_url":"https://api.github.com/repos/analogdevicesinc/fru_tools/issues/4","id":239139762,"user":{"login":"rgetz","id":1017869,"avatar_url":"https://avatars.githubusercontent.com/u/1017869?v=3","gravatar_id":"","url":"https://api.github.com/users/rgetz","html_url":"https://github.com/rgetz","followers_url":"https://api.github.com/users/rgetz/followers","following_url":"https://api.github.com/users/rgetz/following{/other_user}","gists_url":"https://api.github.com/users/rgetz/gists{/gist_id}","starred_url":"https://api.github.com/users/rgetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgetz/subscriptions","organizations_url":"https://api.github.com/users/rgetz/orgs","repos_url":"https://api.github.com/users/rgetz/repos","events_url":"https://api.github.com/users/rgetz/events{/privacy}","received_events_url":"https://api.github.com/users/rgetz/received_events","type":"User","site_admin":false},"created_at":"2016-08-11T11:51:44Z","updated_at":"2016-08-11T11:51:44Z","body":"Thanks for the patches.\r\n\r\nOne issue - in 49738eb & 2107e5c & cbf6ddd is that we try to keep plain \"printf\" out of fru.c - it's used in many other projects (Xilinx (uses it with newlib, where printf doesn't really exist) and in the IIO 'osc' application, which is GTK/gui) where users /developers don't want anything on the console (or a console may not exist). Can you change that to a printf_warn, or printf_info, so people can selectively compile that away when they want it to be quiet? (or smaller).\r\n\r\nI will add a note describing that in fru.c/fru.h after we are done.\r\n\r\nIn 273167d, you just forgot to add something to the -h option, that describes the \"-r\" function.\r\n\r\nThanks again.\r\n-Robin"}}
{"actor":{"display_login":"rgetz"}}