{"action":"created","issue":{"url":"https://api.github.com/repos/shazow/urllib3/issues/1001","repository_url":"https://api.github.com/repos/shazow/urllib3","labels_url":"https://api.github.com/repos/shazow/urllib3/issues/1001/labels{/name}","comments_url":"https://api.github.com/repos/shazow/urllib3/issues/1001/comments","events_url":"https://api.github.com/repos/shazow/urllib3/issues/1001/events","html_url":"https://github.com/shazow/urllib3/pull/1001","id":183854351,"number":1001,"title":"Create custom Selectors (Kqueue, Epoll, Poll, and Select) Backport","user":{"login":"SethMichaelLarson","id":18519037,"avatar_url":"https://avatars.githubusercontent.com/u/18519037?v=3","gravatar_id":"","url":"https://api.github.com/users/SethMichaelLarson","html_url":"https://github.com/SethMichaelLarson","followers_url":"https://api.github.com/users/SethMichaelLarson/followers","following_url":"https://api.github.com/users/SethMichaelLarson/following{/other_user}","gists_url":"https://api.github.com/users/SethMichaelLarson/gists{/gist_id}","starred_url":"https://api.github.com/users/SethMichaelLarson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SethMichaelLarson/subscriptions","organizations_url":"https://api.github.com/users/SethMichaelLarson/orgs","repos_url":"https://api.github.com/users/SethMichaelLarson/repos","events_url":"https://api.github.com/users/SethMichaelLarson/events{/privacy}","received_events_url":"https://api.github.com/users/SethMichaelLarson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":88,"created_at":"2016-10-19T03:01:50Z","updated_at":"2016-10-31T12:56:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/shazow/urllib3/pulls/1001","html_url":"https://github.com/shazow/urllib3/pull/1001","diff_url":"https://github.com/shazow/urllib3/pull/1001.diff","patch_url":"https://github.com/shazow/urllib3/pull/1001.patch"},"body":"This PR adds all the `select` methods to a new util module called `wait`. Uses the same ordering used by `selectors.py` in the standard library to determine which selector should be used. Also factored in a way to allow easy patching and testing. Similar to #998 but uses a different way to break up the different methods to wait for I/O events. Also adds tests to exercise the selectors which can probably be extended.\n"},"comment":{"url":"https://api.github.com/repos/shazow/urllib3/issues/comments/257286856","html_url":"https://github.com/shazow/urllib3/pull/1001#issuecomment-257286856","issue_url":"https://api.github.com/repos/shazow/urllib3/issues/1001","id":257286856,"user":{"login":"SethMichaelLarson","id":18519037,"avatar_url":"https://avatars.githubusercontent.com/u/18519037?v=3","gravatar_id":"","url":"https://api.github.com/users/SethMichaelLarson","html_url":"https://github.com/SethMichaelLarson","followers_url":"https://api.github.com/users/SethMichaelLarson/followers","following_url":"https://api.github.com/users/SethMichaelLarson/following{/other_user}","gists_url":"https://api.github.com/users/SethMichaelLarson/gists{/gist_id}","starred_url":"https://api.github.com/users/SethMichaelLarson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SethMichaelLarson/subscriptions","organizations_url":"https://api.github.com/users/SethMichaelLarson/orgs","repos_url":"https://api.github.com/users/SethMichaelLarson/repos","events_url":"https://api.github.com/users/SethMichaelLarson/events{/privacy}","received_events_url":"https://api.github.com/users/SethMichaelLarson/received_events","type":"User","site_admin":false},"created_at":"2016-10-31T12:56:55Z","updated_at":"2016-10-31T12:56:55Z","body":"We can get by, this is the reason why I was originally just doing single-bounded tests for timeouts, I knew that Travis was going to be really finicky :P The main thing was that I wanted to make sure that selectors behave correctly in all circumstances that they'll be subjected to having to deal with system interrupts and restarting, and it seems that they do from the Travis testing.\r\n\r\nI'll leave this decision to you @Lukasa, I don't really know what is best here. We still want to maintain coverage unless we move this module to another uncovered place."}}
{"actor":{"display_login":"SethMichaelLarson"}}