{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/85533847","pull_request_review_id":6245508,"id":85533847,"diff_hunk":"@@ -101,6 +105,8 @@ public AbstractMetricGroup(MetricRegistry registry, String[] scope, A parent) {\n \t\tthis.registry = checkNotNull(registry);\n \t\tthis.scopeComponents = checkNotNull(scope);\n \t\tthis.parent = parent;\n+\t\tscopeStrings = new String[registry.getReporters().size()];","path":"flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java","position":27,"original_position":27,"commit_id":"e40149a28b4cd8103c979ca24b682120d0b037a9","original_commit_id":"e40149a28b4cd8103c979ca24b682120d0b037a9","user":{"login":"zentol","id":5725237,"avatar_url":"https://avatars.githubusercontent.com/u/5725237?v=3","gravatar_id":"","url":"https://api.github.com/users/zentol","html_url":"https://github.com/zentol","followers_url":"https://api.github.com/users/zentol/followers","following_url":"https://api.github.com/users/zentol/following{/other_user}","gists_url":"https://api.github.com/users/zentol/gists{/gist_id}","starred_url":"https://api.github.com/users/zentol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zentol/subscriptions","organizations_url":"https://api.github.com/users/zentol/orgs","repos_url":"https://api.github.com/users/zentol/repos","events_url":"https://api.github.com/users/zentol/events{/privacy}","received_events_url":"https://api.github.com/users/zentol/received_events","type":"User","site_admin":false},"body":"for consistency it would be neat to prefix these with `this.`.","created_at":"2016-10-28T13:53:16Z","updated_at":"2016-10-28T13:54:49Z","html_url":"https://github.com/apache/flink/pull/2650#discussion_r85533847","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/2650","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/85533847"},"html":{"href":"https://github.com/apache/flink/pull/2650#discussion_r85533847"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/2650"}}},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/2650","id":89624723,"html_url":"https://github.com/apache/flink/pull/2650","diff_url":"https://github.com/apache/flink/pull/2650.diff","patch_url":"https://github.com/apache/flink/pull/2650.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/2650","number":2650,"state":"open","locked":false,"title":"[FLINK-4563] [metrics] scope caching not adjusted for multiple reporters","user":{"login":"ex00","id":13835761,"avatar_url":"https://avatars.githubusercontent.com/u/13835761?v=3","gravatar_id":"","url":"https://api.github.com/users/ex00","html_url":"https://github.com/ex00","followers_url":"https://api.github.com/users/ex00/followers","following_url":"https://api.github.com/users/ex00/following{/other_user}","gists_url":"https://api.github.com/users/ex00/gists{/gist_id}","starred_url":"https://api.github.com/users/ex00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ex00/subscriptions","organizations_url":"https://api.github.com/users/ex00/orgs","repos_url":"https://api.github.com/users/ex00/repos","events_url":"https://api.github.com/users/ex00/events{/privacy}","received_events_url":"https://api.github.com/users/ex00/received_events","type":"User","site_admin":false},"body":"Hello. \r\nIt is implementation FLINK-4563.\r\nIn ``AbstractMetricGroup.java`` added characterFilter and firstReporterIndex for cached scopeString\r\n","created_at":"2016-10-17T13:36:48Z","updated_at":"2016-10-28T13:54:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c763ebe2ba4e2ca5303eb18f5991da6fdede78c5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/2650/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/2650/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/2650/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/e40149a28b4cd8103c979ca24b682120d0b037a9","head":{"label":"ex00:FLINK-4563","ref":"FLINK-4563","sha":"e40149a28b4cd8103c979ca24b682120d0b037a9","user":{"login":"ex00","id":13835761,"avatar_url":"https://avatars.githubusercontent.com/u/13835761?v=3","gravatar_id":"","url":"https://api.github.com/users/ex00","html_url":"https://github.com/ex00","followers_url":"https://api.github.com/users/ex00/followers","following_url":"https://api.github.com/users/ex00/following{/other_user}","gists_url":"https://api.github.com/users/ex00/gists{/gist_id}","starred_url":"https://api.github.com/users/ex00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ex00/subscriptions","organizations_url":"https://api.github.com/users/ex00/orgs","repos_url":"https://api.github.com/users/ex00/repos","events_url":"https://api.github.com/users/ex00/events{/privacy}","received_events_url":"https://api.github.com/users/ex00/received_events","type":"User","site_admin":false},"repo":{"id":68594087,"name":"flink","full_name":"ex00/flink","owner":{"login":"ex00","id":13835761,"avatar_url":"https://avatars.githubusercontent.com/u/13835761?v=3","gravatar_id":"","url":"https://api.github.com/users/ex00","html_url":"https://github.com/ex00","followers_url":"https://api.github.com/users/ex00/followers","following_url":"https://api.github.com/users/ex00/following{/other_user}","gists_url":"https://api.github.com/users/ex00/gists{/gist_id}","starred_url":"https://api.github.com/users/ex00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ex00/subscriptions","organizations_url":"https://api.github.com/users/ex00/orgs","repos_url":"https://api.github.com/users/ex00/repos","events_url":"https://api.github.com/users/ex00/events{/privacy}","received_events_url":"https://api.github.com/users/ex00/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ex00/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/ex00/flink","forks_url":"https://api.github.com/repos/ex00/flink/forks","keys_url":"https://api.github.com/repos/ex00/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ex00/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ex00/flink/teams","hooks_url":"https://api.github.com/repos/ex00/flink/hooks","issue_events_url":"https://api.github.com/repos/ex00/flink/issues/events{/number}","events_url":"https://api.github.com/repos/ex00/flink/events","assignees_url":"https://api.github.com/repos/ex00/flink/assignees{/user}","branches_url":"https://api.github.com/repos/ex00/flink/branches{/branch}","tags_url":"https://api.github.com/repos/ex00/flink/tags","blobs_url":"https://api.github.com/repos/ex00/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ex00/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ex00/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/ex00/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ex00/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/ex00/flink/languages","stargazers_url":"https://api.github.com/repos/ex00/flink/stargazers","contributors_url":"https://api.github.com/repos/ex00/flink/contributors","subscribers_url":"https://api.github.com/repos/ex00/flink/subscribers","subscription_url":"https://api.github.com/repos/ex00/flink/subscription","commits_url":"https://api.github.com/repos/ex00/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/ex00/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/ex00/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/ex00/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/ex00/flink/contents/{+path}","compare_url":"https://api.github.com/repos/ex00/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ex00/flink/merges","archive_url":"https://api.github.com/repos/ex00/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ex00/flink/downloads","issues_url":"https://api.github.com/repos/ex00/flink/issues{/number}","pulls_url":"https://api.github.com/repos/ex00/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/ex00/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/ex00/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ex00/flink/labels{/name}","releases_url":"https://api.github.com/repos/ex00/flink/releases{/id}","deployments_url":"https://api.github.com/repos/ex00/flink/deployments","created_at":"2016-09-19T10:10:58Z","updated_at":"2016-09-19T10:11:19Z","pushed_at":"2016-10-27T08:37:58Z","git_url":"git://github.com/ex00/flink.git","ssh_url":"git@github.com:ex00/flink.git","clone_url":"https://github.com/ex00/flink.git","svn_url":"https://github.com/ex00/flink","homepage":null,"size":98029,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"069de27df67faecad741d8ba95ca0ada609e930c","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"name":"flink","full_name":"apache/flink","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/flink","description":"Mirror of Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink/deployments","created_at":"2014-06-07T07:00:10Z","updated_at":"2016-10-28T07:04:48Z","pushed_at":"2016-10-28T13:46:38Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":null,"size":135332,"stargazers_count":1686,"watchers_count":1686,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1148,"mirror_url":"git://git.apache.org/flink.git","open_issues_count":152,"forks":1148,"open_issues":152,"watchers":1686,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/2650"},"html":{"href":"https://github.com/apache/flink/pull/2650"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/2650"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/2650/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/2650/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/2650/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/e40149a28b4cd8103c979ca24b682120d0b037a9"}}}}
{"actor":{"display_login":"zentol"}}