{"action":"created","comment":{"url":"https://api.github.com/repos/globus/globus-cli/pulls/comments/84324198","pull_request_review_id":5108919,"id":84324198,"diff_hunk":"@@ -9,15 +10,14 @@\n @click.command('create', help='Create a new Share, hosted on an Endpoint')\n @common_options\n @endpoint_create_and_update_opts(create=True, shared_ep=True)\n-@click.option('--host-endpoint-id', required=True,\n-              help='ID of the endpoint on which this Share is hosted')\n-def share_create(host_endpoint_id, display_name, description, organization,\n+@endpoint_id_arg(metavar='HOST_ENDPOINT_ID')\n+def share_create(endpoint_id, display_name, description, organization,\n                  contact_email, contact_info, info_link, public):","path":"globus_cli/services/transfer/share/create.py","position":18,"original_position":18,"commit_id":"2de39ff0e6196fe92dfac49899dc7beda5b92366","original_commit_id":"2de39ff0e6196fe92dfac49899dc7beda5b92366","user":{"login":"sirosen","id":1300022,"avatar_url":"https://avatars.githubusercontent.com/u/1300022?v=3","gravatar_id":"","url":"https://api.github.com/users/sirosen","html_url":"https://github.com/sirosen","followers_url":"https://api.github.com/users/sirosen/followers","following_url":"https://api.github.com/users/sirosen/following{/other_user}","gists_url":"https://api.github.com/users/sirosen/gists{/gist_id}","starred_url":"https://api.github.com/users/sirosen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sirosen/subscriptions","organizations_url":"https://api.github.com/users/sirosen/orgs","repos_url":"https://api.github.com/users/sirosen/repos","events_url":"https://api.github.com/users/sirosen/events{/privacy}","received_events_url":"https://api.github.com/users/sirosen/received_events","type":"User","site_admin":false},"body":"I noticed that issue with shares while doing this work, but decided to fix it later and just replicate the current behavior with the new parsing tools.\r\nIt will probably take an `ENDPOINT_PLUS_REQPATH`.\r\n\r\nit seems pretty reasonable for `assemble_generic_doc()` -- whose sole purpose in this world is to help build Transfer document bodies -- would be able to apply the \"safe stringify\" to UUIDs at least.\r\nIn case of nested docs, it shouldn't try to do too much and risk accidentally storing a `str(subdict)` in the resulting JSON body.","created_at":"2016-10-20T16:35:02Z","updated_at":"2016-10-20T16:35:03Z","html_url":"https://github.com/globus/globus-cli/pull/86#discussion_r84324198","pull_request_url":"https://api.github.com/repos/globus/globus-cli/pulls/86","_links":{"self":{"href":"https://api.github.com/repos/globus/globus-cli/pulls/comments/84324198"},"html":{"href":"https://github.com/globus/globus-cli/pull/86#discussion_r84324198"},"pull_request":{"href":"https://api.github.com/repos/globus/globus-cli/pulls/86"}}},"pull_request":{"url":"https://api.github.com/repos/globus/globus-cli/pulls/86","id":89913376,"html_url":"https://github.com/globus/globus-cli/pull/86","diff_url":"https://github.com/globus/globus-cli/pull/86.diff","patch_url":"https://github.com/globus/globus-cli/pull/86.patch","issue_url":"https://api.github.com/repos/globus/globus-cli/issues/86","number":86,"state":"open","locked":false,"title":"Implement EndpointPlusPath Type, apply it in all \"easy\" scenarios, enforce Endpoint IDs being UUIDs","user":{"login":"sirosen","id":1300022,"avatar_url":"https://avatars.githubusercontent.com/u/1300022?v=3","gravatar_id":"","url":"https://api.github.com/users/sirosen","html_url":"https://github.com/sirosen","followers_url":"https://api.github.com/users/sirosen/followers","following_url":"https://api.github.com/users/sirosen/following{/other_user}","gists_url":"https://api.github.com/users/sirosen/gists{/gist_id}","starred_url":"https://api.github.com/users/sirosen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sirosen/subscriptions","organizations_url":"https://api.github.com/users/sirosen/orgs","repos_url":"https://api.github.com/users/sirosen/repos","events_url":"https://api.github.com/users/sirosen/events{/privacy}","received_events_url":"https://api.github.com/users/sirosen/received_events","type":"User","site_admin":false},"body":"This is a new `click.ParamType`.\r\nUnfortunately, a little bit of hackery is needed because of a bad behavior (which I call a bug) in `click` ( https://github.com/pallets/click/issues/674 ), so in some locations the parameter type is not used inline, but defined at the top of the file. This is actually fine, but a little annoying.\r\n\r\nAlso converts all obvious cases of `--endpoint-id` plus `--path` to this type.\r\nSome commands, like shared endpoint creation, could use this type but (for now at least) don't.\r\n\r\nI consider this sufficient to conclude #73, and we can work on #72 separately as an addition on top of this.","created_at":"2016-10-18T22:51:04Z","updated_at":"2016-10-20T16:35:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"55d445a72185fa17cdc24499ee7999b2fce2c1ab","assignee":{"login":"jaswilli","id":214142,"avatar_url":"https://avatars.githubusercontent.com/u/214142?v=3","gravatar_id":"","url":"https://api.github.com/users/jaswilli","html_url":"https://github.com/jaswilli","followers_url":"https://api.github.com/users/jaswilli/followers","following_url":"https://api.github.com/users/jaswilli/following{/other_user}","gists_url":"https://api.github.com/users/jaswilli/gists{/gist_id}","starred_url":"https://api.github.com/users/jaswilli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaswilli/subscriptions","organizations_url":"https://api.github.com/users/jaswilli/orgs","repos_url":"https://api.github.com/users/jaswilli/repos","events_url":"https://api.github.com/users/jaswilli/events{/privacy}","received_events_url":"https://api.github.com/users/jaswilli/received_events","type":"User","site_admin":false},"assignees":[{"login":"jaswilli","id":214142,"avatar_url":"https://avatars.githubusercontent.com/u/214142?v=3","gravatar_id":"","url":"https://api.github.com/users/jaswilli","html_url":"https://github.com/jaswilli","followers_url":"https://api.github.com/users/jaswilli/followers","following_url":"https://api.github.com/users/jaswilli/following{/other_user}","gists_url":"https://api.github.com/users/jaswilli/gists{/gist_id}","starred_url":"https://api.github.com/users/jaswilli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaswilli/subscriptions","organizations_url":"https://api.github.com/users/jaswilli/orgs","repos_url":"https://api.github.com/users/jaswilli/repos","events_url":"https://api.github.com/users/jaswilli/events{/privacy}","received_events_url":"https://api.github.com/users/jaswilli/received_events","type":"User","site_admin":false},{"login":"corpulentcoffee","id":3958448,"avatar_url":"https://avatars.githubusercontent.com/u/3958448?v=3","gravatar_id":"","url":"https://api.github.com/users/corpulentcoffee","html_url":"https://github.com/corpulentcoffee","followers_url":"https://api.github.com/users/corpulentcoffee/followers","following_url":"https://api.github.com/users/corpulentcoffee/following{/other_user}","gists_url":"https://api.github.com/users/corpulentcoffee/gists{/gist_id}","starred_url":"https://api.github.com/users/corpulentcoffee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corpulentcoffee/subscriptions","organizations_url":"https://api.github.com/users/corpulentcoffee/orgs","repos_url":"https://api.github.com/users/corpulentcoffee/repos","events_url":"https://api.github.com/users/corpulentcoffee/events{/privacy}","received_events_url":"https://api.github.com/users/corpulentcoffee/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/globus/globus-cli/milestones/2","html_url":"https://github.com/globus/globus-cli/milestones/1.0","labels_url":"https://api.github.com/repos/globus/globus-cli/milestones/2/labels","id":1743413,"number":2,"title":"1.0","description":"","creator":{"login":"sirosen","id":1300022,"avatar_url":"https://avatars.githubusercontent.com/u/1300022?v=3","gravatar_id":"","url":"https://api.github.com/users/sirosen","html_url":"https://github.com/sirosen","followers_url":"https://api.github.com/users/sirosen/followers","following_url":"https://api.github.com/users/sirosen/following{/other_user}","gists_url":"https://api.github.com/users/sirosen/gists{/gist_id}","starred_url":"https://api.github.com/users/sirosen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sirosen/subscriptions","organizations_url":"https://api.github.com/users/sirosen/orgs","repos_url":"https://api.github.com/users/sirosen/repos","events_url":"https://api.github.com/users/sirosen/events{/privacy}","received_events_url":"https://api.github.com/users/sirosen/received_events","type":"User","site_admin":false},"open_issues":24,"closed_issues":12,"state":"open","created_at":"2016-05-02T20:29:30Z","updated_at":"2016-10-19T22:01:13Z","due_on":"2016-11-11T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/globus/globus-cli/pulls/86/commits","review_comments_url":"https://api.github.com/repos/globus/globus-cli/pulls/86/comments","review_comment_url":"https://api.github.com/repos/globus/globus-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/globus/globus-cli/issues/86/comments","statuses_url":"https://api.github.com/repos/globus/globus-cli/statuses/2de39ff0e6196fe92dfac49899dc7beda5b92366","head":{"label":"sirosen:parsing/types/endpoint-plus-path","ref":"parsing/types/endpoint-plus-path","sha":"2de39ff0e6196fe92dfac49899dc7beda5b92366","user":{"login":"sirosen","id":1300022,"avatar_url":"https://avatars.githubusercontent.com/u/1300022?v=3","gravatar_id":"","url":"https://api.github.com/users/sirosen","html_url":"https://github.com/sirosen","followers_url":"https://api.github.com/users/sirosen/followers","following_url":"https://api.github.com/users/sirosen/following{/other_user}","gists_url":"https://api.github.com/users/sirosen/gists{/gist_id}","starred_url":"https://api.github.com/users/sirosen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sirosen/subscriptions","organizations_url":"https://api.github.com/users/sirosen/orgs","repos_url":"https://api.github.com/users/sirosen/repos","events_url":"https://api.github.com/users/sirosen/events{/privacy}","received_events_url":"https://api.github.com/users/sirosen/received_events","type":"User","site_admin":false},"repo":{"id":69377442,"name":"globus-cli","full_name":"sirosen/globus-cli","owner":{"login":"sirosen","id":1300022,"avatar_url":"https://avatars.githubusercontent.com/u/1300022?v=3","gravatar_id":"","url":"https://api.github.com/users/sirosen","html_url":"https://github.com/sirosen","followers_url":"https://api.github.com/users/sirosen/followers","following_url":"https://api.github.com/users/sirosen/following{/other_user}","gists_url":"https://api.github.com/users/sirosen/gists{/gist_id}","starred_url":"https://api.github.com/users/sirosen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sirosen/subscriptions","organizations_url":"https://api.github.com/users/sirosen/orgs","repos_url":"https://api.github.com/users/sirosen/repos","events_url":"https://api.github.com/users/sirosen/events{/privacy}","received_events_url":"https://api.github.com/users/sirosen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sirosen/globus-cli","description":"A Command Line Wrapper over the Globus SDK for Python","fork":true,"url":"https://api.github.com/repos/sirosen/globus-cli","forks_url":"https://api.github.com/repos/sirosen/globus-cli/forks","keys_url":"https://api.github.com/repos/sirosen/globus-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sirosen/globus-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sirosen/globus-cli/teams","hooks_url":"https://api.github.com/repos/sirosen/globus-cli/hooks","issue_events_url":"https://api.github.com/repos/sirosen/globus-cli/issues/events{/number}","events_url":"https://api.github.com/repos/sirosen/globus-cli/events","assignees_url":"https://api.github.com/repos/sirosen/globus-cli/assignees{/user}","branches_url":"https://api.github.com/repos/sirosen/globus-cli/branches{/branch}","tags_url":"https://api.github.com/repos/sirosen/globus-cli/tags","blobs_url":"https://api.github.com/repos/sirosen/globus-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sirosen/globus-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sirosen/globus-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/sirosen/globus-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sirosen/globus-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/sirosen/globus-cli/languages","stargazers_url":"https://api.github.com/repos/sirosen/globus-cli/stargazers","contributors_url":"https://api.github.com/repos/sirosen/globus-cli/contributors","subscribers_url":"https://api.github.com/repos/sirosen/globus-cli/subscribers","subscription_url":"https://api.github.com/repos/sirosen/globus-cli/subscription","commits_url":"https://api.github.com/repos/sirosen/globus-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/sirosen/globus-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/sirosen/globus-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/sirosen/globus-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/sirosen/globus-cli/contents/{+path}","compare_url":"https://api.github.com/repos/sirosen/globus-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sirosen/globus-cli/merges","archive_url":"https://api.github.com/repos/sirosen/globus-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sirosen/globus-cli/downloads","issues_url":"https://api.github.com/repos/sirosen/globus-cli/issues{/number}","pulls_url":"https://api.github.com/repos/sirosen/globus-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/sirosen/globus-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/sirosen/globus-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sirosen/globus-cli/labels{/name}","releases_url":"https://api.github.com/repos/sirosen/globus-cli/releases{/id}","deployments_url":"https://api.github.com/repos/sirosen/globus-cli/deployments","created_at":"2016-09-27T16:38:04Z","updated_at":"2016-09-27T16:38:05Z","pushed_at":"2016-10-20T16:23:11Z","git_url":"git://github.com/sirosen/globus-cli.git","ssh_url":"git@github.com:sirosen/globus-cli.git","clone_url":"https://github.com/sirosen/globus-cli.git","svn_url":"https://github.com/sirosen/globus-cli","homepage":null,"size":476,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"globus:master","ref":"master","sha":"f2c7fefbf2f6a65b9c796d770e9e1f8ae04aa503","user":{"login":"globus","id":6120321,"avatar_url":"https://avatars.githubusercontent.com/u/6120321?v=3","gravatar_id":"","url":"https://api.github.com/users/globus","html_url":"https://github.com/globus","followers_url":"https://api.github.com/users/globus/followers","following_url":"https://api.github.com/users/globus/following{/other_user}","gists_url":"https://api.github.com/users/globus/gists{/gist_id}","starred_url":"https://api.github.com/users/globus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/globus/subscriptions","organizations_url":"https://api.github.com/users/globus/orgs","repos_url":"https://api.github.com/users/globus/repos","events_url":"https://api.github.com/users/globus/events{/privacy}","received_events_url":"https://api.github.com/users/globus/received_events","type":"Organization","site_admin":false},"repo":{"id":53438969,"name":"globus-cli","full_name":"globus/globus-cli","owner":{"login":"globus","id":6120321,"avatar_url":"https://avatars.githubusercontent.com/u/6120321?v=3","gravatar_id":"","url":"https://api.github.com/users/globus","html_url":"https://github.com/globus","followers_url":"https://api.github.com/users/globus/followers","following_url":"https://api.github.com/users/globus/following{/other_user}","gists_url":"https://api.github.com/users/globus/gists{/gist_id}","starred_url":"https://api.github.com/users/globus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/globus/subscriptions","organizations_url":"https://api.github.com/users/globus/orgs","repos_url":"https://api.github.com/users/globus/repos","events_url":"https://api.github.com/users/globus/events{/privacy}","received_events_url":"https://api.github.com/users/globus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/globus/globus-cli","description":"A Command Line Wrapper over the Globus SDK for Python","fork":false,"url":"https://api.github.com/repos/globus/globus-cli","forks_url":"https://api.github.com/repos/globus/globus-cli/forks","keys_url":"https://api.github.com/repos/globus/globus-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/globus/globus-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/globus/globus-cli/teams","hooks_url":"https://api.github.com/repos/globus/globus-cli/hooks","issue_events_url":"https://api.github.com/repos/globus/globus-cli/issues/events{/number}","events_url":"https://api.github.com/repos/globus/globus-cli/events","assignees_url":"https://api.github.com/repos/globus/globus-cli/assignees{/user}","branches_url":"https://api.github.com/repos/globus/globus-cli/branches{/branch}","tags_url":"https://api.github.com/repos/globus/globus-cli/tags","blobs_url":"https://api.github.com/repos/globus/globus-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/globus/globus-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/globus/globus-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/globus/globus-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/globus/globus-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/globus/globus-cli/languages","stargazers_url":"https://api.github.com/repos/globus/globus-cli/stargazers","contributors_url":"https://api.github.com/repos/globus/globus-cli/contributors","subscribers_url":"https://api.github.com/repos/globus/globus-cli/subscribers","subscription_url":"https://api.github.com/repos/globus/globus-cli/subscription","commits_url":"https://api.github.com/repos/globus/globus-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/globus/globus-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/globus/globus-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/globus/globus-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/globus/globus-cli/contents/{+path}","compare_url":"https://api.github.com/repos/globus/globus-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/globus/globus-cli/merges","archive_url":"https://api.github.com/repos/globus/globus-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/globus/globus-cli/downloads","issues_url":"https://api.github.com/repos/globus/globus-cli/issues{/number}","pulls_url":"https://api.github.com/repos/globus/globus-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/globus/globus-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/globus/globus-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/globus/globus-cli/labels{/name}","releases_url":"https://api.github.com/repos/globus/globus-cli/releases{/id}","deployments_url":"https://api.github.com/repos/globus/globus-cli/deployments","created_at":"2016-03-08T19:25:41Z","updated_at":"2016-10-14T19:36:17Z","pushed_at":"2016-10-20T16:23:12Z","git_url":"git://github.com/globus/globus-cli.git","ssh_url":"git@github.com:globus/globus-cli.git","clone_url":"https://github.com/globus/globus-cli.git","svn_url":"https://github.com/globus/globus-cli","homepage":null,"size":476,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":35,"forks":4,"open_issues":35,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/globus/globus-cli/pulls/86"},"html":{"href":"https://github.com/globus/globus-cli/pull/86"},"issue":{"href":"https://api.github.com/repos/globus/globus-cli/issues/86"},"comments":{"href":"https://api.github.com/repos/globus/globus-cli/issues/86/comments"},"review_comments":{"href":"https://api.github.com/repos/globus/globus-cli/pulls/86/comments"},"review_comment":{"href":"https://api.github.com/repos/globus/globus-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/globus/globus-cli/pulls/86/commits"},"statuses":{"href":"https://api.github.com/repos/globus/globus-cli/statuses/2de39ff0e6196fe92dfac49899dc7beda5b92366"}}}}
{"actor":{"display_login":"sirosen"}}