{"action":"created","comment":{"url":"https://api.github.com/repos/ioam/geoviews/pulls/comments/60886999","id":60886999,"diff_hunk":"@@ -8,6 +8,27 @@\n from holoviews.element import Text as HVText\n from iris.cube import Cube\n \n+geographic_types = (cGoogleTiles, cFeature)\n+\n+def is_geographic(dataset, kdims=None):\n+    \"\"\"\n+    Small utility that determines whether the supplied dataset\n+    and kdims represent a geographic coordinate system.\n+    \"\"\"\n+    if kdims:\n+        kdims = [dataset.get_dimension(d) for d in kdims]\n+    else:\n+        kdims = dataset.kdims\n+\n+    if isinstance(dataset.data, geographic_types) or isinstance(dataset, WMTS):\n+        return True\n+    if (len(kdims) == 2 and\n+        ((isinstance(dataset, _Element) and kdims == dataset.kdims) or","path":"geoviews/element/geo.py","position":26,"original_position":26,"commit_id":"543930e9cce088f6ab5cd57bf62cf7cf8370c979","original_commit_id":"543930e9cce088f6ab5cd57bf62cf7cf8370c979","user":{"login":"philippjfr","id":1550771,"avatar_url":"https://avatars.githubusercontent.com/u/1550771?v=3","gravatar_id":"","url":"https://api.github.com/users/philippjfr","html_url":"https://github.com/philippjfr","followers_url":"https://api.github.com/users/philippjfr/followers","following_url":"https://api.github.com/users/philippjfr/following{/other_user}","gists_url":"https://api.github.com/users/philippjfr/gists{/gist_id}","starred_url":"https://api.github.com/users/philippjfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philippjfr/subscriptions","organizations_url":"https://api.github.com/users/philippjfr/orgs","repos_url":"https://api.github.com/users/philippjfr/repos","events_url":"https://api.github.com/users/philippjfr/events{/privacy}","received_events_url":"https://api.github.com/users/philippjfr/received_events","type":"User","site_admin":false},"body":"This is missing ``and  dataset.crs``.","created_at":"2016-04-25T09:44:04Z","updated_at":"2016-04-25T09:44:04Z","html_url":"https://github.com/ioam/geoviews/pull/17#discussion_r60886999","pull_request_url":"https://api.github.com/repos/ioam/geoviews/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/ioam/geoviews/pulls/comments/60886999"},"html":{"href":"https://github.com/ioam/geoviews/pull/17#discussion_r60886999"},"pull_request":{"href":"https://api.github.com/repos/ioam/geoviews/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/ioam/geoviews/pulls/17","id":67616698,"html_url":"https://github.com/ioam/geoviews/pull/17","diff_url":"https://github.com/ioam/geoviews/pull/17.diff","patch_url":"https://github.com/ioam/geoviews/pull/17.patch","issue_url":"https://api.github.com/repos/ioam/geoviews/issues/17","number":17,"state":"open","locked":false,"title":"Improved support for geographic plot aspects and extents","user":{"login":"philippjfr","id":1550771,"avatar_url":"https://avatars.githubusercontent.com/u/1550771?v=3","gravatar_id":"","url":"https://api.github.com/users/philippjfr","html_url":"https://github.com/philippjfr","followers_url":"https://api.github.com/users/philippjfr/followers","following_url":"https://api.github.com/users/philippjfr/following{/other_user}","gists_url":"https://api.github.com/users/philippjfr/gists{/gist_id}","starred_url":"https://api.github.com/users/philippjfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philippjfr/subscriptions","organizations_url":"https://api.github.com/users/philippjfr/orgs","repos_url":"https://api.github.com/users/philippjfr/repos","events_url":"https://api.github.com/users/philippjfr/events{/privacy}","received_events_url":"https://api.github.com/users/philippjfr/received_events","type":"User","site_admin":false},"body":"This PR makes three main improvements:\r\n\r\n1. Fix for the ``is_geographic`` function to correctly handle Tiles, WMTS and Feature Elements.\r\n\r\n2. Only set the aspect to equal on geographic plot types, avoiding the issue raised in #15.\r\n\r\n3. Add a get_extents method, which makes use of ``GeoAxes.set_extent`` to correctly compute the plot extents based on the range and extents of the Element. This allows setting extents on the Element in its native coordinate system.\r\n\r\nLetting cartopy handle computing the extent transform is good, but it would be nice if we could factor out the code in cartopy's ``GeoAxes.set_extents`` to compute the extent transform without having to set it.","created_at":"2016-04-23T19:51:25Z","updated_at":"2016-04-25T09:44:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d10ab2b15cf864b02b748ceec07d8f0cbed3956","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ioam/geoviews/pulls/17/commits","review_comments_url":"https://api.github.com/repos/ioam/geoviews/pulls/17/comments","review_comment_url":"https://api.github.com/repos/ioam/geoviews/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ioam/geoviews/issues/17/comments","statuses_url":"https://api.github.com/repos/ioam/geoviews/statuses/543930e9cce088f6ab5cd57bf62cf7cf8370c979","head":{"label":"ioam:geo_extents","ref":"geo_extents","sha":"543930e9cce088f6ab5cd57bf62cf7cf8370c979","user":{"login":"ioam","id":1693676,"avatar_url":"https://avatars.githubusercontent.com/u/1693676?v=3","gravatar_id":"","url":"https://api.github.com/users/ioam","html_url":"https://github.com/ioam","followers_url":"https://api.github.com/users/ioam/followers","following_url":"https://api.github.com/users/ioam/following{/other_user}","gists_url":"https://api.github.com/users/ioam/gists{/gist_id}","starred_url":"https://api.github.com/users/ioam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ioam/subscriptions","organizations_url":"https://api.github.com/users/ioam/orgs","repos_url":"https://api.github.com/users/ioam/repos","events_url":"https://api.github.com/users/ioam/events{/privacy}","received_events_url":"https://api.github.com/users/ioam/received_events","type":"Organization","site_admin":false},"repo":{"id":56613435,"name":"geoviews","full_name":"ioam/geoviews","owner":{"login":"ioam","id":1693676,"avatar_url":"https://avatars.githubusercontent.com/u/1693676?v=3","gravatar_id":"","url":"https://api.github.com/users/ioam","html_url":"https://github.com/ioam","followers_url":"https://api.github.com/users/ioam/followers","following_url":"https://api.github.com/users/ioam/following{/other_user}","gists_url":"https://api.github.com/users/ioam/gists{/gist_id}","starred_url":"https://api.github.com/users/ioam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ioam/subscriptions","organizations_url":"https://api.github.com/users/ioam/orgs","repos_url":"https://api.github.com/users/ioam/repos","events_url":"https://api.github.com/users/ioam/events{/privacy}","received_events_url":"https://api.github.com/users/ioam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ioam/geoviews","description":"","fork":false,"url":"https://api.github.com/repos/ioam/geoviews","forks_url":"https://api.github.com/repos/ioam/geoviews/forks","keys_url":"https://api.github.com/repos/ioam/geoviews/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ioam/geoviews/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ioam/geoviews/teams","hooks_url":"https://api.github.com/repos/ioam/geoviews/hooks","issue_events_url":"https://api.github.com/repos/ioam/geoviews/issues/events{/number}","events_url":"https://api.github.com/repos/ioam/geoviews/events","assignees_url":"https://api.github.com/repos/ioam/geoviews/assignees{/user}","branches_url":"https://api.github.com/repos/ioam/geoviews/branches{/branch}","tags_url":"https://api.github.com/repos/ioam/geoviews/tags","blobs_url":"https://api.github.com/repos/ioam/geoviews/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ioam/geoviews/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ioam/geoviews/git/refs{/sha}","trees_url":"https://api.github.com/repos/ioam/geoviews/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ioam/geoviews/statuses/{sha}","languages_url":"https://api.github.com/repos/ioam/geoviews/languages","stargazers_url":"https://api.github.com/repos/ioam/geoviews/stargazers","contributors_url":"https://api.github.com/repos/ioam/geoviews/contributors","subscribers_url":"https://api.github.com/repos/ioam/geoviews/subscribers","subscription_url":"https://api.github.com/repos/ioam/geoviews/subscription","commits_url":"https://api.github.com/repos/ioam/geoviews/commits{/sha}","git_commits_url":"https://api.github.com/repos/ioam/geoviews/git/commits{/sha}","comments_url":"https://api.github.com/repos/ioam/geoviews/comments{/number}","issue_comment_url":"https://api.github.com/repos/ioam/geoviews/issues/comments{/number}","contents_url":"https://api.github.com/repos/ioam/geoviews/contents/{+path}","compare_url":"https://api.github.com/repos/ioam/geoviews/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ioam/geoviews/merges","archive_url":"https://api.github.com/repos/ioam/geoviews/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ioam/geoviews/downloads","issues_url":"https://api.github.com/repos/ioam/geoviews/issues{/number}","pulls_url":"https://api.github.com/repos/ioam/geoviews/pulls{/number}","milestones_url":"https://api.github.com/repos/ioam/geoviews/milestones{/number}","notifications_url":"https://api.github.com/repos/ioam/geoviews/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ioam/geoviews/labels{/name}","releases_url":"https://api.github.com/repos/ioam/geoviews/releases{/id}","deployments_url":"https://api.github.com/repos/ioam/geoviews/deployments","created_at":"2016-04-19T16:27:01Z","updated_at":"2016-04-20T16:42:16Z","pushed_at":"2016-04-25T08:01:11Z","git_url":"git://github.com/ioam/geoviews.git","ssh_url":"git@github.com:ioam/geoviews.git","clone_url":"https://github.com/ioam/geoviews.git","svn_url":"https://github.com/ioam/geoviews","homepage":"http://geo.holoviews.org","size":220,"stargazers_count":1,"watchers_count":1,"language":"Jupyter Notebook","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":3,"forks":4,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"ioam:master","ref":"master","sha":"ea28e7c55e26e2c99c278559d0dff42895315fac","user":{"login":"ioam","id":1693676,"avatar_url":"https://avatars.githubusercontent.com/u/1693676?v=3","gravatar_id":"","url":"https://api.github.com/users/ioam","html_url":"https://github.com/ioam","followers_url":"https://api.github.com/users/ioam/followers","following_url":"https://api.github.com/users/ioam/following{/other_user}","gists_url":"https://api.github.com/users/ioam/gists{/gist_id}","starred_url":"https://api.github.com/users/ioam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ioam/subscriptions","organizations_url":"https://api.github.com/users/ioam/orgs","repos_url":"https://api.github.com/users/ioam/repos","events_url":"https://api.github.com/users/ioam/events{/privacy}","received_events_url":"https://api.github.com/users/ioam/received_events","type":"Organization","site_admin":false},"repo":{"id":56613435,"name":"geoviews","full_name":"ioam/geoviews","owner":{"login":"ioam","id":1693676,"avatar_url":"https://avatars.githubusercontent.com/u/1693676?v=3","gravatar_id":"","url":"https://api.github.com/users/ioam","html_url":"https://github.com/ioam","followers_url":"https://api.github.com/users/ioam/followers","following_url":"https://api.github.com/users/ioam/following{/other_user}","gists_url":"https://api.github.com/users/ioam/gists{/gist_id}","starred_url":"https://api.github.com/users/ioam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ioam/subscriptions","organizations_url":"https://api.github.com/users/ioam/orgs","repos_url":"https://api.github.com/users/ioam/repos","events_url":"https://api.github.com/users/ioam/events{/privacy}","received_events_url":"https://api.github.com/users/ioam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ioam/geoviews","description":"","fork":false,"url":"https://api.github.com/repos/ioam/geoviews","forks_url":"https://api.github.com/repos/ioam/geoviews/forks","keys_url":"https://api.github.com/repos/ioam/geoviews/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ioam/geoviews/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ioam/geoviews/teams","hooks_url":"https://api.github.com/repos/ioam/geoviews/hooks","issue_events_url":"https://api.github.com/repos/ioam/geoviews/issues/events{/number}","events_url":"https://api.github.com/repos/ioam/geoviews/events","assignees_url":"https://api.github.com/repos/ioam/geoviews/assignees{/user}","branches_url":"https://api.github.com/repos/ioam/geoviews/branches{/branch}","tags_url":"https://api.github.com/repos/ioam/geoviews/tags","blobs_url":"https://api.github.com/repos/ioam/geoviews/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ioam/geoviews/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ioam/geoviews/git/refs{/sha}","trees_url":"https://api.github.com/repos/ioam/geoviews/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ioam/geoviews/statuses/{sha}","languages_url":"https://api.github.com/repos/ioam/geoviews/languages","stargazers_url":"https://api.github.com/repos/ioam/geoviews/stargazers","contributors_url":"https://api.github.com/repos/ioam/geoviews/contributors","subscribers_url":"https://api.github.com/repos/ioam/geoviews/subscribers","subscription_url":"https://api.github.com/repos/ioam/geoviews/subscription","commits_url":"https://api.github.com/repos/ioam/geoviews/commits{/sha}","git_commits_url":"https://api.github.com/repos/ioam/geoviews/git/commits{/sha}","comments_url":"https://api.github.com/repos/ioam/geoviews/comments{/number}","issue_comment_url":"https://api.github.com/repos/ioam/geoviews/issues/comments{/number}","contents_url":"https://api.github.com/repos/ioam/geoviews/contents/{+path}","compare_url":"https://api.github.com/repos/ioam/geoviews/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ioam/geoviews/merges","archive_url":"https://api.github.com/repos/ioam/geoviews/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ioam/geoviews/downloads","issues_url":"https://api.github.com/repos/ioam/geoviews/issues{/number}","pulls_url":"https://api.github.com/repos/ioam/geoviews/pulls{/number}","milestones_url":"https://api.github.com/repos/ioam/geoviews/milestones{/number}","notifications_url":"https://api.github.com/repos/ioam/geoviews/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ioam/geoviews/labels{/name}","releases_url":"https://api.github.com/repos/ioam/geoviews/releases{/id}","deployments_url":"https://api.github.com/repos/ioam/geoviews/deployments","created_at":"2016-04-19T16:27:01Z","updated_at":"2016-04-20T16:42:16Z","pushed_at":"2016-04-25T08:01:11Z","git_url":"git://github.com/ioam/geoviews.git","ssh_url":"git@github.com:ioam/geoviews.git","clone_url":"https://github.com/ioam/geoviews.git","svn_url":"https://github.com/ioam/geoviews","homepage":"http://geo.holoviews.org","size":220,"stargazers_count":1,"watchers_count":1,"language":"Jupyter Notebook","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":3,"forks":4,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ioam/geoviews/pulls/17"},"html":{"href":"https://github.com/ioam/geoviews/pull/17"},"issue":{"href":"https://api.github.com/repos/ioam/geoviews/issues/17"},"comments":{"href":"https://api.github.com/repos/ioam/geoviews/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/ioam/geoviews/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/ioam/geoviews/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ioam/geoviews/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/ioam/geoviews/statuses/543930e9cce088f6ab5cd57bf62cf7cf8370c979"}}}}