{"action":"opened","number":424,"pull_request":{"url":"https://api.github.com/repos/github/choosealicense.com/pulls/424","id":72098813,"html_url":"https://github.com/github/choosealicense.com/pull/424","diff_url":"https://github.com/github/choosealicense.com/pull/424.diff","patch_url":"https://github.com/github/choosealicense.com/pull/424.patch","issue_url":"https://api.github.com/repos/github/choosealicense.com/issues/424","number":424,"state":"open","locked":false,"title":"make tests not overwrite non-mutable document 'id'","user":{"login":"mlinksva","id":40415,"avatar_url":"https://avatars.githubusercontent.com/u/40415?v=3","gravatar_id":"","url":"https://api.github.com/users/mlinksva","html_url":"https://github.com/mlinksva","followers_url":"https://api.github.com/users/mlinksva/followers","following_url":"https://api.github.com/users/mlinksva/following{/other_user}","gists_url":"https://api.github.com/users/mlinksva/gists{/gist_id}","starred_url":"https://api.github.com/users/mlinksva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlinksva/subscriptions","organizations_url":"https://api.github.com/users/mlinksva/orgs","repos_url":"https://api.github.com/users/mlinksva/repos","events_url":"https://api.github.com/users/mlinksva/events{/privacy}","received_events_url":"https://api.github.com/users/mlinksva/received_events","type":"User","site_admin":true},"body":"WIth Jekyll 3.1.6 CI is now failing. Skimming sources I'm not sure when introduced, but now the class that represents a document has a 'id' method and is considered immutable, so our tests which add an 'id' property to each license to set up the tests now fail when adding that property (see stracktrace below). So I changed the property added and used from 'id' to 'spdx-lcase' which is descriptive of the property value. Now tests/CI will pass.\r\n\r\ncc @parkr as likely to be able to tell me if I'm missing something obvious or otherwise doing it wrong.\r\n\r\n\r\n\r\n```\r\n/home/travis/build/github/choosealicense.com/vendor/bundle/ruby/2.0.0/gems/jekyll-3.1.6/lib/jekyll/drops/drop.rb:78:in `[]=': Key id cannot be set in the drop. (Jekyll::Errors::DropMutationException)\r\n\tfrom /home/travis/build/github/choosealicense.com/vendor/bundle/ruby/2.0.0/gems/jekyll-3.1.6/lib/jekyll/drops/drop.rb:194:in `block in merge!'\r\n\tfrom /home/travis/build/github/choosealicense.com/vendor/bundle/ruby/2.0.0/gems/jekyll-3.1.6/lib/jekyll/drops/drop.rb:185:in `each_key'\r\n\tfrom /home/travis/build/github/choosealicense.com/vendor/bundle/ruby/2.0.0/gems/jekyll-3.1.6/lib/jekyll/drops/drop.rb:185:in `merge!'\r\n\tfrom /home/travis/build/github/choosealicense.com/vendor/bundle/ruby/2.0.0/gems/jekyll-3.1.6/lib/jekyll/drops/drop.rb:177:in `block in merge'\r\n\tfrom /home/travis/build/github/choosealicense.com/vendor/bundle/ruby/2.0.0/gems/jekyll-3.1.6/lib/jekyll/drops/drop.rb:175:in `tap'\r\n\tfrom /home/travis/build/github/choosealicense.com/vendor/bundle/ruby/2.0.0/gems/jekyll-3.1.6/lib/jekyll/drops/drop.rb:175:in `merge'\r\n\tfrom /home/travis/build/github/choosealicense.com/spec/spec_helper.rb:38:in `block in licenses'\r\n\tfrom /home/travis/build/github/choosealicense.com/spec/spec_helper.rb:36:in `map'\r\n\tfrom /home/travis/build/github/choosealicense.com/spec/spec_helper.rb:36:in `licenses'\r\n\tfrom /home/travis/build/github/choosealicense.com/spec/license_fields_spec.rb:4:in `block in <top (required)>'\r\n\tfrom /home/travis/build/github/choosealicense.com/vendor/bundle/ruby/2.0.0/gems/rspec-core-3.4.4/lib/rspec/core/example_group.rb:385:in `module_exec'\r\n\tfrom /home/travis/build/github/choosealicense.com/vendor/bundle/ruby/2.0.0/gems/rspec-core-3.4.4/lib/rspec/core/example_group.rb:385:in `subclass'\r\n\tfrom /home/travis/build/github/choosealicense.com/vendor/bundle/ruby/2.0.0/gems/rspec-core-3.4.4/lib/rspec/core/example_group.rb:255:in `block in define_example_group_method'\r\n\tfrom /home/travis/build/github/choosealicense.com/vendor/bundle/ruby/2.0.0/gems/rspec-core-3.4.4/lib/rspec/core/dsl.rb:43:in `block in expose_example_group_alias'\r\n\tfrom /home/travis/build/github/choosealicense.com/vendor/bundle/ruby/2.0.0/gems/rspec-core-3.4.4/lib/rspec/core/dsl.rb:82:in `block (2 levels) in expose_example_group_alias_globally'\r\n\tfrom /home/travis/build/github/choosealicense.com/spec/license_fields_spec.rb:3:in `<top (required)>'\r\n\tfrom /home/travis/build/github/choosealicense.com/vendor/bundle/ruby/2.0.0/gems/rspec-core-3.4.4/lib/rspec/core/configuration.rb:1361:in `load'\r\n\tfrom /home/travis/build/github/choosealicense.com/vendor/bundle/ruby/2.0.0/gems/rspec-core-3.4.4/lib/rspec/core/configuration.rb:1361:in `block in load_spec_files'\r\n\tfrom /home/travis/build/github/choosealicense.com/vendor/bundle/ruby/2.0.0/gems/rspec-core-3.4.4/lib/rspec/core/configuration.rb:1359:in `each'\r\n\tfrom /home/travis/build/github/choosealicense.com/vendor/bundle/ruby/2.0.0/gems/rspec-core-3.4.4/lib/rspec/core/configuration.rb:1359:in `load_spec_files'\r\n\tfrom /home/travis/build/github/choosealicense.com/vendor/bundle/ruby/2.0.0/gems/rspec-core-3.4.4/lib/rspec/core/runner.rb:106:in `setup'\r\n\tfrom /home/travis/build/github/choosealicense.com/vendor/bundle/ruby/2.0.0/gems/rspec-core-3.4.4/lib/rspec/core/runner.rb:92:in `run'\r\n\tfrom /home/travis/build/github/choosealicense.com/vendor/bundle/ruby/2.0.0/gems/rspec-core-3.4.4/lib/rspec/core/runner.rb:78:in `run'\r\n\tfrom /home/travis/build/github/choosealicense.com/vendor/bundle/ruby/2.0.0/gems/rspec-core-3.4.4/lib/rspec/core/runner.rb:45:in `invoke'\r\n\tfrom /home/travis/build/github/choosealicense.com/vendor/bundle/ruby/2.0.0/gems/rspec-core-3.4.4/exe/rspec:4:in `<main>'\r\n```","created_at":"2016-05-31T22:54:15Z","updated_at":"2016-05-31T22:54:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/github/choosealicense.com/pulls/424/commits","review_comments_url":"https://api.github.com/repos/github/choosealicense.com/pulls/424/comments","review_comment_url":"https://api.github.com/repos/github/choosealicense.com/pulls/comments{/number}","comments_url":"https://api.github.com/repos/github/choosealicense.com/issues/424/comments","statuses_url":"https://api.github.com/repos/github/choosealicense.com/statuses/49fca012805c457f3da856ec3bf01a33ebd4209e","head":{"label":"github:non-mutable-id","ref":"non-mutable-id","sha":"49fca012805c457f3da856ec3bf01a33ebd4209e","user":{"login":"github","id":9919,"avatar_url":"https://avatars.githubusercontent.com/u/9919?v=3","gravatar_id":"","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"repo":{"id":11426474,"name":"choosealicense.com","full_name":"github/choosealicense.com","owner":{"login":"github","id":9919,"avatar_url":"https://avatars.githubusercontent.com/u/9919?v=3","gravatar_id":"","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/github/choosealicense.com","description":"A site to provide non-judgmental guidance on choosing a license for your open source project","fork":false,"url":"https://api.github.com/repos/github/choosealicense.com","forks_url":"https://api.github.com/repos/github/choosealicense.com/forks","keys_url":"https://api.github.com/repos/github/choosealicense.com/keys{/key_id}","collaborators_url":"https://api.github.com/repos/github/choosealicense.com/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/github/choosealicense.com/teams","hooks_url":"https://api.github.com/repos/github/choosealicense.com/hooks","issue_events_url":"https://api.github.com/repos/github/choosealicense.com/issues/events{/number}","events_url":"https://api.github.com/repos/github/choosealicense.com/events","assignees_url":"https://api.github.com/repos/github/choosealicense.com/assignees{/user}","branches_url":"https://api.github.com/repos/github/choosealicense.com/branches{/branch}","tags_url":"https://api.github.com/repos/github/choosealicense.com/tags","blobs_url":"https://api.github.com/repos/github/choosealicense.com/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/github/choosealicense.com/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/github/choosealicense.com/git/refs{/sha}","trees_url":"https://api.github.com/repos/github/choosealicense.com/git/trees{/sha}","statuses_url":"https://api.github.com/repos/github/choosealicense.com/statuses/{sha}","languages_url":"https://api.github.com/repos/github/choosealicense.com/languages","stargazers_url":"https://api.github.com/repos/github/choosealicense.com/stargazers","contributors_url":"https://api.github.com/repos/github/choosealicense.com/contributors","subscribers_url":"https://api.github.com/repos/github/choosealicense.com/subscribers","subscription_url":"https://api.github.com/repos/github/choosealicense.com/subscription","commits_url":"https://api.github.com/repos/github/choosealicense.com/commits{/sha}","git_commits_url":"https://api.github.com/repos/github/choosealicense.com/git/commits{/sha}","comments_url":"https://api.github.com/repos/github/choosealicense.com/comments{/number}","issue_comment_url":"https://api.github.com/repos/github/choosealicense.com/issues/comments{/number}","contents_url":"https://api.github.com/repos/github/choosealicense.com/contents/{+path}","compare_url":"https://api.github.com/repos/github/choosealicense.com/compare/{base}...{head}","merges_url":"https://api.github.com/repos/github/choosealicense.com/merges","archive_url":"https://api.github.com/repos/github/choosealicense.com/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/github/choosealicense.com/downloads","issues_url":"https://api.github.com/repos/github/choosealicense.com/issues{/number}","pulls_url":"https://api.github.com/repos/github/choosealicense.com/pulls{/number}","milestones_url":"https://api.github.com/repos/github/choosealicense.com/milestones{/number}","notifications_url":"https://api.github.com/repos/github/choosealicense.com/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/github/choosealicense.com/labels{/name}","releases_url":"https://api.github.com/repos/github/choosealicense.com/releases{/id}","deployments_url":"https://api.github.com/repos/github/choosealicense.com/deployments","created_at":"2013-07-15T15:25:34Z","updated_at":"2016-05-31T08:53:37Z","pushed_at":"2016-05-31T22:46:09Z","git_url":"git://github.com/github/choosealicense.com.git","ssh_url":"git@github.com:github/choosealicense.com.git","clone_url":"https://github.com/github/choosealicense.com.git","svn_url":"https://github.com/github/choosealicense.com","homepage":"http://choosealicense.com","size":3124,"stargazers_count":593,"watchers_count":593,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":193,"mirror_url":null,"open_issues_count":22,"forks":193,"open_issues":22,"watchers":593,"default_branch":"gh-pages"}},"base":{"label":"github:gh-pages","ref":"gh-pages","sha":"4551fddd8880db5496579c6e83f3e0627e5aff26","user":{"login":"github","id":9919,"avatar_url":"https://avatars.githubusercontent.com/u/9919?v=3","gravatar_id":"","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"repo":{"id":11426474,"name":"choosealicense.com","full_name":"github/choosealicense.com","owner":{"login":"github","id":9919,"avatar_url":"https://avatars.githubusercontent.com/u/9919?v=3","gravatar_id":"","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/github/choosealicense.com","description":"A site to provide non-judgmental guidance on choosing a license for your open source project","fork":false,"url":"https://api.github.com/repos/github/choosealicense.com","forks_url":"https://api.github.com/repos/github/choosealicense.com/forks","keys_url":"https://api.github.com/repos/github/choosealicense.com/keys{/key_id}","collaborators_url":"https://api.github.com/repos/github/choosealicense.com/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/github/choosealicense.com/teams","hooks_url":"https://api.github.com/repos/github/choosealicense.com/hooks","issue_events_url":"https://api.github.com/repos/github/choosealicense.com/issues/events{/number}","events_url":"https://api.github.com/repos/github/choosealicense.com/events","assignees_url":"https://api.github.com/repos/github/choosealicense.com/assignees{/user}","branches_url":"https://api.github.com/repos/github/choosealicense.com/branches{/branch}","tags_url":"https://api.github.com/repos/github/choosealicense.com/tags","blobs_url":"https://api.github.com/repos/github/choosealicense.com/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/github/choosealicense.com/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/github/choosealicense.com/git/refs{/sha}","trees_url":"https://api.github.com/repos/github/choosealicense.com/git/trees{/sha}","statuses_url":"https://api.github.com/repos/github/choosealicense.com/statuses/{sha}","languages_url":"https://api.github.com/repos/github/choosealicense.com/languages","stargazers_url":"https://api.github.com/repos/github/choosealicense.com/stargazers","contributors_url":"https://api.github.com/repos/github/choosealicense.com/contributors","subscribers_url":"https://api.github.com/repos/github/choosealicense.com/subscribers","subscription_url":"https://api.github.com/repos/github/choosealicense.com/subscription","commits_url":"https://api.github.com/repos/github/choosealicense.com/commits{/sha}","git_commits_url":"https://api.github.com/repos/github/choosealicense.com/git/commits{/sha}","comments_url":"https://api.github.com/repos/github/choosealicense.com/comments{/number}","issue_comment_url":"https://api.github.com/repos/github/choosealicense.com/issues/comments{/number}","contents_url":"https://api.github.com/repos/github/choosealicense.com/contents/{+path}","compare_url":"https://api.github.com/repos/github/choosealicense.com/compare/{base}...{head}","merges_url":"https://api.github.com/repos/github/choosealicense.com/merges","archive_url":"https://api.github.com/repos/github/choosealicense.com/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/github/choosealicense.com/downloads","issues_url":"https://api.github.com/repos/github/choosealicense.com/issues{/number}","pulls_url":"https://api.github.com/repos/github/choosealicense.com/pulls{/number}","milestones_url":"https://api.github.com/repos/github/choosealicense.com/milestones{/number}","notifications_url":"https://api.github.com/repos/github/choosealicense.com/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/github/choosealicense.com/labels{/name}","releases_url":"https://api.github.com/repos/github/choosealicense.com/releases{/id}","deployments_url":"https://api.github.com/repos/github/choosealicense.com/deployments","created_at":"2013-07-15T15:25:34Z","updated_at":"2016-05-31T08:53:37Z","pushed_at":"2016-05-31T22:46:09Z","git_url":"git://github.com/github/choosealicense.com.git","ssh_url":"git@github.com:github/choosealicense.com.git","clone_url":"https://github.com/github/choosealicense.com.git","svn_url":"https://github.com/github/choosealicense.com","homepage":"http://choosealicense.com","size":3124,"stargazers_count":593,"watchers_count":593,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":193,"mirror_url":null,"open_issues_count":22,"forks":193,"open_issues":22,"watchers":593,"default_branch":"gh-pages"}},"_links":{"self":{"href":"https://api.github.com/repos/github/choosealicense.com/pulls/424"},"html":{"href":"https://github.com/github/choosealicense.com/pull/424"},"issue":{"href":"https://api.github.com/repos/github/choosealicense.com/issues/424"},"comments":{"href":"https://api.github.com/repos/github/choosealicense.com/issues/424/comments"},"review_comments":{"href":"https://api.github.com/repos/github/choosealicense.com/pulls/424/comments"},"review_comment":{"href":"https://api.github.com/repos/github/choosealicense.com/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/github/choosealicense.com/pulls/424/commits"},"statuses":{"href":"https://api.github.com/repos/github/choosealicense.com/statuses/49fca012805c457f3da856ec3bf01a33ebd4209e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":3,"deletions":3,"changed_files":3}}
{"actor":{"display_login":"mlinksva"}}