{"action":"created","issue":{"url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/2081","repository_url":"https://api.github.com/repos/The-Compiler/qutebrowser","labels_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/2081/labels{/name}","comments_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/2081/comments","events_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/2081/events","html_url":"https://github.com/The-Compiler/qutebrowser/pull/2081","id":186614724,"number":2081,"title":"auto save session","user":{"login":"cosminadrianpopescu","id":5187873,"avatar_url":"https://avatars.githubusercontent.com/u/5187873?v=3","gravatar_id":"","url":"https://api.github.com/users/cosminadrianpopescu","html_url":"https://github.com/cosminadrianpopescu","followers_url":"https://api.github.com/users/cosminadrianpopescu/followers","following_url":"https://api.github.com/users/cosminadrianpopescu/following{/other_user}","gists_url":"https://api.github.com/users/cosminadrianpopescu/gists{/gist_id}","starred_url":"https://api.github.com/users/cosminadrianpopescu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosminadrianpopescu/subscriptions","organizations_url":"https://api.github.com/users/cosminadrianpopescu/orgs","repos_url":"https://api.github.com/users/cosminadrianpopescu/repos","events_url":"https://api.github.com/users/cosminadrianpopescu/events{/privacy}","received_events_url":"https://api.github.com/users/cosminadrianpopescu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-01T18:48:16Z","updated_at":"2016-11-01T19:57:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/2081","html_url":"https://github.com/The-Compiler/qutebrowser/pull/2081","diff_url":"https://github.com/The-Compiler/qutebrowser/pull/2081.diff","patch_url":"https://github.com/The-Compiler/qutebrowser/pull/2081.patch"},"body":"Auto saves a session when loadFinished is emmited."},"comment":{"url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/comments/257676967","html_url":"https://github.com/The-Compiler/qutebrowser/pull/2081#issuecomment-257676967","issue_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/2081","id":257676967,"user":{"login":"The-Compiler","id":625793,"avatar_url":"https://avatars.githubusercontent.com/u/625793?v=3","gravatar_id":"","url":"https://api.github.com/users/The-Compiler","html_url":"https://github.com/The-Compiler","followers_url":"https://api.github.com/users/The-Compiler/followers","following_url":"https://api.github.com/users/The-Compiler/following{/other_user}","gists_url":"https://api.github.com/users/The-Compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/The-Compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/The-Compiler/subscriptions","organizations_url":"https://api.github.com/users/The-Compiler/orgs","repos_url":"https://api.github.com/users/The-Compiler/repos","events_url":"https://api.github.com/users/The-Compiler/events{/privacy}","received_events_url":"https://api.github.com/users/The-Compiler/received_events","type":"User","site_admin":false},"created_at":"2016-11-01T19:57:26Z","updated_at":"2016-11-01T19:57:26Z","body":"I'm guessing the intention of this is to have some kind of crash recovery, right?\r\n\r\nIn any case, I think this is quite problematic - if we save the session before a crash, the user will just be in a crash loop (because usually, if a page crashes the browser, it'll do the same next time) and I'm pretty sure people will be frustrated by that (and I'll be by the support :laughing:) .\r\n\r\nIt'd be better to have some kind of special `_autosave` session, and then after a crash inform the user that they can load that session (after editing it if needed).\r\n\r\nIn the long run, ideally we'd have some kind of crash recovery dialog/page, where the user can select which tabs to restore."}}
{"actor":{"display_login":"The-Compiler"}}