{"action":"created","comment":{"url":"https://api.github.com/repos/camptocamp/ngeo/pulls/comments/66225699","id":66225699,"diff_hunk":"@@ -1,12 +1,14 @@\n-<div ng-class=\"::{'dropdown': true, 'dropup': scaleselectorCtrl.options.dropup}\">\n-  <button type=\"button\" class=\"btn btn-primary\" data-toggle=\"dropdown\">\n-    <span ng-bind-html=\"scaleselectorCtrl.currentScale\"></span>&nbsp;<span class=\"caret\"></span>\n-  </button>\n-  <ul class=\"dropdown-menu\" role=\"menu\">\n-    <li ng-repeat=\"zoomLevel in ::scaleselectorCtrl.zoomLevels\">\n-      <a href ng-click=\"scaleselectorCtrl.changeZoom(zoomLevel)\"\n-         ng-bind-html=\"scaleselectorCtrl.getScale(zoomLevel)\">\n-      </a>\n-    </li>\n-  </ul>\n+<div class=\"form-group form-group-sm dropdown\" ng-class=\"::{'dropup': scaleselectorCtrl.options.dropup}\">\n+  <div class=\"btn-group btn-block\">\n+      <button type=\"button\" class=\"btn btn-default form-control\" data-toggle=\"dropdown\" aria-expanded=\"false\">","path":"src/directives/partials/scaleselector.html","position":14,"original_position":14,"commit_id":"11eea101d7ecc2883cb1146717cd6bc15b3f57d9","original_commit_id":"11eea101d7ecc2883cb1146717cd6bc15b3f57d9","user":{"login":"pgiraud","id":319774,"avatar_url":"https://avatars.githubusercontent.com/u/319774?v=3","gravatar_id":"","url":"https://api.github.com/users/pgiraud","html_url":"https://github.com/pgiraud","followers_url":"https://api.github.com/users/pgiraud/followers","following_url":"https://api.github.com/users/pgiraud/following{/other_user}","gists_url":"https://api.github.com/users/pgiraud/gists{/gist_id}","starred_url":"https://api.github.com/users/pgiraud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgiraud/subscriptions","organizations_url":"https://api.github.com/users/pgiraud/orgs","repos_url":"https://api.github.com/users/pgiraud/repos","events_url":"https://api.github.com/users/pgiraud/events{/privacy}","received_events_url":"https://api.github.com/users/pgiraud/received_events","type":"User","site_admin":false},"body":"You need to add the `dropdown-toggle` class name otherwise the corners are squared on the right.\r\n![screenshot from 2016-06-08 11 48 45](https://cloud.githubusercontent.com/assets/319774/15890259/fca57596-2d6e-11e6-83a9-b7e85b64570e.png)\r\n","created_at":"2016-06-08T09:49:18Z","updated_at":"2016-06-08T09:49:18Z","html_url":"https://github.com/camptocamp/ngeo/pull/1352#discussion_r66225699","pull_request_url":"https://api.github.com/repos/camptocamp/ngeo/pulls/1352","_links":{"self":{"href":"https://api.github.com/repos/camptocamp/ngeo/pulls/comments/66225699"},"html":{"href":"https://github.com/camptocamp/ngeo/pull/1352#discussion_r66225699"},"pull_request":{"href":"https://api.github.com/repos/camptocamp/ngeo/pulls/1352"}}},"pull_request":{"url":"https://api.github.com/repos/camptocamp/ngeo/pulls/1352","id":73007783,"html_url":"https://github.com/camptocamp/ngeo/pull/1352","diff_url":"https://github.com/camptocamp/ngeo/pull/1352.diff","patch_url":"https://github.com/camptocamp/ngeo/pull/1352.patch","issue_url":"https://api.github.com/repos/camptocamp/ngeo/issues/1352","number":1352,"state":"open","locked":false,"title":"Infobar","user":{"login":"ger-benjamin","id":1792111,"avatar_url":"https://avatars.githubusercontent.com/u/1792111?v=3","gravatar_id":"","url":"https://api.github.com/users/ger-benjamin","html_url":"https://github.com/ger-benjamin","followers_url":"https://api.github.com/users/ger-benjamin/followers","following_url":"https://api.github.com/users/ger-benjamin/following{/other_user}","gists_url":"https://api.github.com/users/ger-benjamin/gists{/gist_id}","starred_url":"https://api.github.com/users/ger-benjamin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ger-benjamin/subscriptions","organizations_url":"https://api.github.com/users/ger-benjamin/orgs","repos_url":"https://api.github.com/users/ger-benjamin/repos","events_url":"https://api.github.com/users/ger-benjamin/events{/privacy}","received_events_url":"https://api.github.com/users/ger-benjamin/received_events","type":"User","site_admin":false},"body":"Revival of #1128 \r\n\r\nFix: https://github.com/camptocamp/c2cgeoportal/issues/1668 (without \"contextual information\" because `Display contextual information on right click. (still to be designed!)`)\r\n\r\nSpecs: https://github.com/camptocamp/c2cgeoportal/wiki/Spec-%231668-Map-(Info-bar)\r\n\r\nExamples: \r\n - https://ger-benjamin.github.io/ngeo/infobar/examples/contribs/gmf/apps/desktop\r\n - https://ger-benjamin.github.io/ngeo/infobar/examples/contribs/gmf/apps/desktop_alt (without choice for elevation)\r\n\r\nMust be done in another PR (2.1?):\r\n - Display contextual information on right click (still to be designed, ping @ybolognini ) \r\n - For a same zoom level, scales are not the same in the print panel and in the infobar (perhaps that's normal but this is strange to see).\r\n\r\nMust be done in another PR (2.2):\r\n - Uniforms scaleselector, elevation and mouseposition. Because: \r\n  - `scaleselector` is old, doesn't use filter for scales, use partial with dropdown included and with one option to configure it (dropup).\r\n  - `mouseposition` use partial with dropdown but without any option to configure it.\r\n  - `elevation` doesn't include any partial so the dropdown is full configurable but the `index.html` is less compact.\r\n\r\nFor the design of the buttons, it was too [hard / manual] to use a dropdown button on the side of a component and the same style for the component but without having the button effect. So I make a unique button (As proposed by @pgiraud).","created_at":"2016-06-08T08:48:48Z","updated_at":"2016-06-08T09:49:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"abfab819d82e8dfea41f8087c6e8c2904a27cceb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/camptocamp/ngeo/pulls/1352/commits","review_comments_url":"https://api.github.com/repos/camptocamp/ngeo/pulls/1352/comments","review_comment_url":"https://api.github.com/repos/camptocamp/ngeo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/camptocamp/ngeo/issues/1352/comments","statuses_url":"https://api.github.com/repos/camptocamp/ngeo/statuses/11eea101d7ecc2883cb1146717cd6bc15b3f57d9","head":{"label":"ger-benjamin:infobar","ref":"infobar","sha":"11eea101d7ecc2883cb1146717cd6bc15b3f57d9","user":{"login":"ger-benjamin","id":1792111,"avatar_url":"https://avatars.githubusercontent.com/u/1792111?v=3","gravatar_id":"","url":"https://api.github.com/users/ger-benjamin","html_url":"https://github.com/ger-benjamin","followers_url":"https://api.github.com/users/ger-benjamin/followers","following_url":"https://api.github.com/users/ger-benjamin/following{/other_user}","gists_url":"https://api.github.com/users/ger-benjamin/gists{/gist_id}","starred_url":"https://api.github.com/users/ger-benjamin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ger-benjamin/subscriptions","organizations_url":"https://api.github.com/users/ger-benjamin/orgs","repos_url":"https://api.github.com/users/ger-benjamin/repos","events_url":"https://api.github.com/users/ger-benjamin/events{/privacy}","received_events_url":"https://api.github.com/users/ger-benjamin/received_events","type":"User","site_admin":false},"repo":{"id":45966295,"name":"ngeo","full_name":"ger-benjamin/ngeo","owner":{"login":"ger-benjamin","id":1792111,"avatar_url":"https://avatars.githubusercontent.com/u/1792111?v=3","gravatar_id":"","url":"https://api.github.com/users/ger-benjamin","html_url":"https://github.com/ger-benjamin","followers_url":"https://api.github.com/users/ger-benjamin/followers","following_url":"https://api.github.com/users/ger-benjamin/following{/other_user}","gists_url":"https://api.github.com/users/ger-benjamin/gists{/gist_id}","starred_url":"https://api.github.com/users/ger-benjamin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ger-benjamin/subscriptions","organizations_url":"https://api.github.com/users/ger-benjamin/orgs","repos_url":"https://api.github.com/users/ger-benjamin/repos","events_url":"https://api.github.com/users/ger-benjamin/events{/privacy}","received_events_url":"https://api.github.com/users/ger-benjamin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ger-benjamin/ngeo","description":"Library combining OpenLayers 3 and AngularJS","fork":true,"url":"https://api.github.com/repos/ger-benjamin/ngeo","forks_url":"https://api.github.com/repos/ger-benjamin/ngeo/forks","keys_url":"https://api.github.com/repos/ger-benjamin/ngeo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ger-benjamin/ngeo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ger-benjamin/ngeo/teams","hooks_url":"https://api.github.com/repos/ger-benjamin/ngeo/hooks","issue_events_url":"https://api.github.com/repos/ger-benjamin/ngeo/issues/events{/number}","events_url":"https://api.github.com/repos/ger-benjamin/ngeo/events","assignees_url":"https://api.github.com/repos/ger-benjamin/ngeo/assignees{/user}","branches_url":"https://api.github.com/repos/ger-benjamin/ngeo/branches{/branch}","tags_url":"https://api.github.com/repos/ger-benjamin/ngeo/tags","blobs_url":"https://api.github.com/repos/ger-benjamin/ngeo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ger-benjamin/ngeo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ger-benjamin/ngeo/git/refs{/sha}","trees_url":"https://api.github.com/repos/ger-benjamin/ngeo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ger-benjamin/ngeo/statuses/{sha}","languages_url":"https://api.github.com/repos/ger-benjamin/ngeo/languages","stargazers_url":"https://api.github.com/repos/ger-benjamin/ngeo/stargazers","contributors_url":"https://api.github.com/repos/ger-benjamin/ngeo/contributors","subscribers_url":"https://api.github.com/repos/ger-benjamin/ngeo/subscribers","subscription_url":"https://api.github.com/repos/ger-benjamin/ngeo/subscription","commits_url":"https://api.github.com/repos/ger-benjamin/ngeo/commits{/sha}","git_commits_url":"https://api.github.com/repos/ger-benjamin/ngeo/git/commits{/sha}","comments_url":"https://api.github.com/repos/ger-benjamin/ngeo/comments{/number}","issue_comment_url":"https://api.github.com/repos/ger-benjamin/ngeo/issues/comments{/number}","contents_url":"https://api.github.com/repos/ger-benjamin/ngeo/contents/{+path}","compare_url":"https://api.github.com/repos/ger-benjamin/ngeo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ger-benjamin/ngeo/merges","archive_url":"https://api.github.com/repos/ger-benjamin/ngeo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ger-benjamin/ngeo/downloads","issues_url":"https://api.github.com/repos/ger-benjamin/ngeo/issues{/number}","pulls_url":"https://api.github.com/repos/ger-benjamin/ngeo/pulls{/number}","milestones_url":"https://api.github.com/repos/ger-benjamin/ngeo/milestones{/number}","notifications_url":"https://api.github.com/repos/ger-benjamin/ngeo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ger-benjamin/ngeo/labels{/name}","releases_url":"https://api.github.com/repos/ger-benjamin/ngeo/releases{/id}","deployments_url":"https://api.github.com/repos/ger-benjamin/ngeo/deployments","created_at":"2015-11-11T07:25:12Z","updated_at":"2016-01-11T13:51:53Z","pushed_at":"2016-06-08T09:09:16Z","git_url":"git://github.com/ger-benjamin/ngeo.git","ssh_url":"git@github.com:ger-benjamin/ngeo.git","clone_url":"https://github.com/ger-benjamin/ngeo.git","svn_url":"https://github.com/ger-benjamin/ngeo","homepage":null,"size":51279,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"camptocamp:master","ref":"master","sha":"9902acef87e7f2989090a854f850fded259cc988","user":{"login":"camptocamp","id":28109,"avatar_url":"https://avatars.githubusercontent.com/u/28109?v=3","gravatar_id":"","url":"https://api.github.com/users/camptocamp","html_url":"https://github.com/camptocamp","followers_url":"https://api.github.com/users/camptocamp/followers","following_url":"https://api.github.com/users/camptocamp/following{/other_user}","gists_url":"https://api.github.com/users/camptocamp/gists{/gist_id}","starred_url":"https://api.github.com/users/camptocamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camptocamp/subscriptions","organizations_url":"https://api.github.com/users/camptocamp/orgs","repos_url":"https://api.github.com/users/camptocamp/repos","events_url":"https://api.github.com/users/camptocamp/events{/privacy}","received_events_url":"https://api.github.com/users/camptocamp/received_events","type":"Organization","site_admin":false},"repo":{"id":20212761,"name":"ngeo","full_name":"camptocamp/ngeo","owner":{"login":"camptocamp","id":28109,"avatar_url":"https://avatars.githubusercontent.com/u/28109?v=3","gravatar_id":"","url":"https://api.github.com/users/camptocamp","html_url":"https://github.com/camptocamp","followers_url":"https://api.github.com/users/camptocamp/followers","following_url":"https://api.github.com/users/camptocamp/following{/other_user}","gists_url":"https://api.github.com/users/camptocamp/gists{/gist_id}","starred_url":"https://api.github.com/users/camptocamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camptocamp/subscriptions","organizations_url":"https://api.github.com/users/camptocamp/orgs","repos_url":"https://api.github.com/users/camptocamp/repos","events_url":"https://api.github.com/users/camptocamp/events{/privacy}","received_events_url":"https://api.github.com/users/camptocamp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/camptocamp/ngeo","description":"Library combining OpenLayers 3 and AngularJS","fork":false,"url":"https://api.github.com/repos/camptocamp/ngeo","forks_url":"https://api.github.com/repos/camptocamp/ngeo/forks","keys_url":"https://api.github.com/repos/camptocamp/ngeo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/camptocamp/ngeo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/camptocamp/ngeo/teams","hooks_url":"https://api.github.com/repos/camptocamp/ngeo/hooks","issue_events_url":"https://api.github.com/repos/camptocamp/ngeo/issues/events{/number}","events_url":"https://api.github.com/repos/camptocamp/ngeo/events","assignees_url":"https://api.github.com/repos/camptocamp/ngeo/assignees{/user}","branches_url":"https://api.github.com/repos/camptocamp/ngeo/branches{/branch}","tags_url":"https://api.github.com/repos/camptocamp/ngeo/tags","blobs_url":"https://api.github.com/repos/camptocamp/ngeo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/camptocamp/ngeo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/camptocamp/ngeo/git/refs{/sha}","trees_url":"https://api.github.com/repos/camptocamp/ngeo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/camptocamp/ngeo/statuses/{sha}","languages_url":"https://api.github.com/repos/camptocamp/ngeo/languages","stargazers_url":"https://api.github.com/repos/camptocamp/ngeo/stargazers","contributors_url":"https://api.github.com/repos/camptocamp/ngeo/contributors","subscribers_url":"https://api.github.com/repos/camptocamp/ngeo/subscribers","subscription_url":"https://api.github.com/repos/camptocamp/ngeo/subscription","commits_url":"https://api.github.com/repos/camptocamp/ngeo/commits{/sha}","git_commits_url":"https://api.github.com/repos/camptocamp/ngeo/git/commits{/sha}","comments_url":"https://api.github.com/repos/camptocamp/ngeo/comments{/number}","issue_comment_url":"https://api.github.com/repos/camptocamp/ngeo/issues/comments{/number}","contents_url":"https://api.github.com/repos/camptocamp/ngeo/contents/{+path}","compare_url":"https://api.github.com/repos/camptocamp/ngeo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/camptocamp/ngeo/merges","archive_url":"https://api.github.com/repos/camptocamp/ngeo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/camptocamp/ngeo/downloads","issues_url":"https://api.github.com/repos/camptocamp/ngeo/issues{/number}","pulls_url":"https://api.github.com/repos/camptocamp/ngeo/pulls{/number}","milestones_url":"https://api.github.com/repos/camptocamp/ngeo/milestones{/number}","notifications_url":"https://api.github.com/repos/camptocamp/ngeo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/camptocamp/ngeo/labels{/name}","releases_url":"https://api.github.com/repos/camptocamp/ngeo/releases{/id}","deployments_url":"https://api.github.com/repos/camptocamp/ngeo/deployments","created_at":"2014-05-27T08:34:54Z","updated_at":"2016-05-30T12:16:12Z","pushed_at":"2016-06-08T09:44:03Z","git_url":"git://github.com/camptocamp/ngeo.git","ssh_url":"git@github.com:camptocamp/ngeo.git","clone_url":"https://github.com/camptocamp/ngeo.git","svn_url":"https://github.com/camptocamp/ngeo","homepage":null,"size":121130,"stargazers_count":71,"watchers_count":71,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":44,"mirror_url":null,"open_issues_count":77,"forks":44,"open_issues":77,"watchers":71,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/camptocamp/ngeo/pulls/1352"},"html":{"href":"https://github.com/camptocamp/ngeo/pull/1352"},"issue":{"href":"https://api.github.com/repos/camptocamp/ngeo/issues/1352"},"comments":{"href":"https://api.github.com/repos/camptocamp/ngeo/issues/1352/comments"},"review_comments":{"href":"https://api.github.com/repos/camptocamp/ngeo/pulls/1352/comments"},"review_comment":{"href":"https://api.github.com/repos/camptocamp/ngeo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/camptocamp/ngeo/pulls/1352/commits"},"statuses":{"href":"https://api.github.com/repos/camptocamp/ngeo/statuses/11eea101d7ecc2883cb1146717cd6bc15b3f57d9"}}}}
{"actor":{"display_login":"pgiraud"}}