{"action":"created","issue":{"url":"https://api.github.com/repos/mjul/docjure/issues/19","repository_url":"https://api.github.com/repos/mjul/docjure","labels_url":"https://api.github.com/repos/mjul/docjure/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/mjul/docjure/issues/19/comments","events_url":"https://api.github.com/repos/mjul/docjure/issues/19/events","html_url":"https://github.com/mjul/docjure/issues/19","id":25879679,"number":19,"title":"Blank rows/cells are omitted from sequences and from select-columns","user":{"login":"kornysietsma","id":17765,"avatar_url":"https://avatars.githubusercontent.com/u/17765?v=3","gravatar_id":"","url":"https://api.github.com/users/kornysietsma","html_url":"https://github.com/kornysietsma","followers_url":"https://api.github.com/users/kornysietsma/followers","following_url":"https://api.github.com/users/kornysietsma/following{/other_user}","gists_url":"https://api.github.com/users/kornysietsma/gists{/gist_id}","starred_url":"https://api.github.com/users/kornysietsma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kornysietsma/subscriptions","organizations_url":"https://api.github.com/users/kornysietsma/orgs","repos_url":"https://api.github.com/users/kornysietsma/repos","events_url":"https://api.github.com/users/kornysietsma/events{/privacy}","received_events_url":"https://api.github.com/users/kornysietsma/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2014-01-19T12:45:26Z","updated_at":"2016-09-06T07:54:09Z","closed_at":null,"body":"This is basically the same as the issue my colleague nurous raised against clj-excel:\r\nhttps://github.com/mebaran/clj-excel/pull/5\r\n\r\nThe root problem is that iterators in POI skips blank rows and cells.  As a result, a blank row won't be returned in a `row-seq` call, and a blank cell won't be returned in a `cell-seq` call.  Worse, when running functions like `select-columns` the results can be quite wrong due to these problems.\r\n\r\n(note that this is for truly blank cells - a spreadsheet seems to be implemented somewhere as a sparse array.  Cells where you've entered data previously, and then deleted the data, may still be returned by these functions)"},"comment":{"url":"https://api.github.com/repos/mjul/docjure/issues/comments/244876316","html_url":"https://github.com/mjul/docjure/issues/19#issuecomment-244876316","issue_url":"https://api.github.com/repos/mjul/docjure/issues/19","id":244876316,"user":{"login":"dmichulke","id":2175675,"avatar_url":"https://avatars.githubusercontent.com/u/2175675?v=3","gravatar_id":"","url":"https://api.github.com/users/dmichulke","html_url":"https://github.com/dmichulke","followers_url":"https://api.github.com/users/dmichulke/followers","following_url":"https://api.github.com/users/dmichulke/following{/other_user}","gists_url":"https://api.github.com/users/dmichulke/gists{/gist_id}","starred_url":"https://api.github.com/users/dmichulke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmichulke/subscriptions","organizations_url":"https://api.github.com/users/dmichulke/orgs","repos_url":"https://api.github.com/users/dmichulke/repos","events_url":"https://api.github.com/users/dmichulke/events{/privacy}","received_events_url":"https://api.github.com/users/dmichulke/received_events","type":"User","site_admin":false},"created_at":"2016-09-06T07:54:09Z","updated_at":"2016-09-06T07:54:09Z","body":"Not my decision but I'd also prefer option 2 - returning nil for blank rows/cells. \r\nThe reason is that removing nils from the dense version is easy with standard clojure functionality\r\nAdding nils to the non-dense version at the right places is impossible. \r\n\r\nSo the former is more general one but still requires only few workarounds to make it works a before.\r\n\r\nProbably the changelog should contain the word **BREAKING CHANGE** and you might want to increase the major version."}}
{"actor":{"display_login":"dmichulke"}}