{"action":"created","issue":{"url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/1440","repository_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine","labels_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/1440/labels{/name}","comments_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/1440/comments","events_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/1440/events","html_url":"https://github.com/TeamPorcupine/ProjectPorcupine/pull/1440","id":178507235,"number":1440,"title":"[WIP] [Feedback] Dialog logic for Save, Load, and implementation of New World in Options","user":{"login":"jaselito","id":21699103,"avatar_url":"https://avatars.githubusercontent.com/u/21699103?v=3","gravatar_id":"","url":"https://api.github.com/users/jaselito","html_url":"https://github.com/jaselito","followers_url":"https://api.github.com/users/jaselito/followers","following_url":"https://api.github.com/users/jaselito/following{/other_user}","gists_url":"https://api.github.com/users/jaselito/gists{/gist_id}","starred_url":"https://api.github.com/users/jaselito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaselito/subscriptions","organizations_url":"https://api.github.com/users/jaselito/orgs","repos_url":"https://api.github.com/users/jaselito/repos","events_url":"https://api.github.com/users/jaselito/events{/privacy}","received_events_url":"https://api.github.com/users/jaselito/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2016-09-22T02:44:52Z","updated_at":"2016-09-23T06:46:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/pulls/1440","html_url":"https://github.com/TeamPorcupine/ProjectPorcupine/pull/1440","diff_url":"https://github.com/TeamPorcupine/ProjectPorcupine/pull/1440.diff","patch_url":"https://github.com/TeamPorcupine/ProjectPorcupine/pull/1440.patch"},"body":"Implemented the New World option in the Options dialog. In order to do this I replaced the AreYouSure dialog with a general purpose PromptOrInfoDialog, which can be used to show simple messages with an OK button or to prompt the user to validate actions, with Yes, No, and/or Cancel buttons.  Also introduced logic to allow multiple dialogs to be shown at the same time.\r\n\r\nI went ahead and implemented dialog logic for the Save and Load options and changed their skins to match our UI style. \r\n\r\nHere a couple screenshots:\r\n\r\n![new world](https://cloud.githubusercontent.com/assets/21699103/18735456/9bfe3886-8043-11e6-8ff1-587be0d71a7f.png)\r\n![save](https://cloud.githubusercontent.com/assets/21699103/18735457/9c00a044-8043-11e6-845d-c9b7e2cdc1b4.png)\r\n\r\nThis will introduce a couple of keys not found in the localization file... I left it like that since I don't know if I can edit the file myself or what the current deal with localization is.\r\n\r\nAlso, some times when opening the save or load dialogs I've found this\r\n\r\n![list bug](https://cloud.githubusercontent.com/assets/21699103/18735533/19dfeef2-8044-11e6-8715-285b65a51efc.png)\r\n\r\nThis disappears when refreshing the dialog (for instance moving the scroll bar) but I haven't been able to fix it in code other than in a hacky way, so right now I left it like that in case someone knows the proper fix."},"comment":{"url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/comments/249115527","html_url":"https://github.com/TeamPorcupine/ProjectPorcupine/pull/1440#issuecomment-249115527","issue_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/1440","id":249115527,"user":{"login":"TomMalbran","id":1299997,"avatar_url":"https://avatars.githubusercontent.com/u/1299997?v=3","gravatar_id":"","url":"https://api.github.com/users/TomMalbran","html_url":"https://github.com/TomMalbran","followers_url":"https://api.github.com/users/TomMalbran/followers","following_url":"https://api.github.com/users/TomMalbran/following{/other_user}","gists_url":"https://api.github.com/users/TomMalbran/gists{/gist_id}","starred_url":"https://api.github.com/users/TomMalbran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomMalbran/subscriptions","organizations_url":"https://api.github.com/users/TomMalbran/orgs","repos_url":"https://api.github.com/users/TomMalbran/repos","events_url":"https://api.github.com/users/TomMalbran/events{/privacy}","received_events_url":"https://api.github.com/users/TomMalbran/received_events","type":"User","site_admin":false},"created_at":"2016-09-23T06:46:08Z","updated_at":"2016-09-23T06:46:08Z","body":"I tested the error. If I have 7 files, which means that I don't need to scroll I get it all the time. If I have 8, it works fine.\r\n\r\nI had another weird issue. For some reason I have a file with no name showing in the list (not sure why). If I try to delete it I can't. But then when I try to delete another file I get 3 buttons yes, no, okay. The last issue might have something to do with no resetting the buttons. The other 2 are separate from this PR."}}
{"actor":{"display_login":"TomMalbran"}}