{"action":"created","issue":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/9043","repository_url":"https://api.github.com/repos/highfidelity/hifi","labels_url":"https://api.github.com/repos/highfidelity/hifi/issues/9043/labels{/name}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/9043/comments","events_url":"https://api.github.com/repos/highfidelity/hifi/issues/9043/events","html_url":"https://github.com/highfidelity/hifi/pull/9043","id":188410166,"number":9043,"title":"add support for whitelist entity scripts","user":{"login":"ZappoMan","id":2093195,"avatar_url":"https://avatars.githubusercontent.com/u/2093195?v=3","gravatar_id":"","url":"https://api.github.com/users/ZappoMan","html_url":"https://github.com/ZappoMan","followers_url":"https://api.github.com/users/ZappoMan/followers","following_url":"https://api.github.com/users/ZappoMan/following{/other_user}","gists_url":"https://api.github.com/users/ZappoMan/gists{/gist_id}","starred_url":"https://api.github.com/users/ZappoMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZappoMan/subscriptions","organizations_url":"https://api.github.com/users/ZappoMan/orgs","repos_url":"https://api.github.com/users/ZappoMan/repos","events_url":"https://api.github.com/users/ZappoMan/events{/privacy}","received_events_url":"https://api.github.com/users/ZappoMan/received_events","type":"User","site_admin":false},"labels":[{"id":412774488,"url":"https://api.github.com/repos/highfidelity/hifi/labels/Critical%20Fix","name":"Critical Fix","color":"fbca04","default":false},{"id":314155368,"url":"https://api.github.com/repos/highfidelity/hifi/labels/Development%20Approved","name":"Development Approved","color":"009800","default":false},{"id":314155316,"url":"https://api.github.com/repos/highfidelity/hifi/labels/QA%20Approved","name":"QA Approved","color":"009800","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-11-10T03:13:05Z","updated_at":"2016-11-10T17:01:17Z","closed_at":"2016-11-10T16:17:30Z","pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/9043","html_url":"https://github.com/highfidelity/hifi/pull/9043","diff_url":"https://github.com/highfidelity/hifi/pull/9043.diff","patch_url":"https://github.com/highfidelity/hifi/pull/9043.patch"},"body":"allows domain operator to limit entity scripts to only a specific white list of sources"},"comment":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/comments/259746256","html_url":"https://github.com/highfidelity/hifi/pull/9043#issuecomment-259746256","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/9043","id":259746256,"user":{"login":"huffman","id":167747,"avatar_url":"https://avatars.githubusercontent.com/u/167747?v=3","gravatar_id":"","url":"https://api.github.com/users/huffman","html_url":"https://github.com/huffman","followers_url":"https://api.github.com/users/huffman/followers","following_url":"https://api.github.com/users/huffman/following{/other_user}","gists_url":"https://api.github.com/users/huffman/gists{/gist_id}","starred_url":"https://api.github.com/users/huffman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huffman/subscriptions","organizations_url":"https://api.github.com/users/huffman/orgs","repos_url":"https://api.github.com/users/huffman/repos","events_url":"https://api.github.com/users/huffman/events{/privacy}","received_events_url":"https://api.github.com/users/huffman/received_events","type":"User","site_admin":false},"created_at":"2016-11-10T17:01:17Z","updated_at":"2016-11-10T17:01:17Z","body":"@ZappoMan I was late to the party, couple thoughts - \r\n\r\n 1. This seems like it will block marketplace items with scripts. We might want an easy way to include those prefixes\r\n 1. I don't think this will retroactively disable or delete entities with \"banned\" scripts. It would be nice to improve this with that functionality at some point (if we let entity be created but don't let the script run on the client, that would be one way of approaching it).\r\n 1. If you try bringing in something with multiple entities you can end up in a situation where some of the entities are created but some aren't. As a user this would be very confusing. I think we need to seriously think about how we are presenting this to the user. Or, more simply, I bring in an entity but it doesn't show up. This just makes it look like something is broken."}}
{"actor":{"display_login":"huffman"}}