{"action":"created","issue":{"url":"https://api.github.com/repos/criteo/biggraphite/issues/49","repository_url":"https://api.github.com/repos/criteo/biggraphite","labels_url":"https://api.github.com/repos/criteo/biggraphite/issues/49/labels{/name}","comments_url":"https://api.github.com/repos/criteo/biggraphite/issues/49/comments","events_url":"https://api.github.com/repos/criteo/biggraphite/issues/49/events","html_url":"https://github.com/criteo/biggraphite/pull/49","id":166084050,"number":49,"title":"Improve Downsampler to use actual metric metadata","user":{"login":"natbraun","id":12711504,"avatar_url":"https://avatars.githubusercontent.com/u/12711504?v=3","gravatar_id":"","url":"https://api.github.com/users/natbraun","html_url":"https://github.com/natbraun","followers_url":"https://api.github.com/users/natbraun/followers","following_url":"https://api.github.com/users/natbraun/following{/other_user}","gists_url":"https://api.github.com/users/natbraun/gists{/gist_id}","starred_url":"https://api.github.com/users/natbraun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natbraun/subscriptions","organizations_url":"https://api.github.com/users/natbraun/orgs","repos_url":"https://api.github.com/users/natbraun/repos","events_url":"https://api.github.com/users/natbraun/events{/privacy}","received_events_url":"https://api.github.com/users/natbraun/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"iksaif","id":1032963,"avatar_url":"https://avatars.githubusercontent.com/u/1032963?v=3","gravatar_id":"","url":"https://api.github.com/users/iksaif","html_url":"https://github.com/iksaif","followers_url":"https://api.github.com/users/iksaif/followers","following_url":"https://api.github.com/users/iksaif/following{/other_user}","gists_url":"https://api.github.com/users/iksaif/gists{/gist_id}","starred_url":"https://api.github.com/users/iksaif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iksaif/subscriptions","organizations_url":"https://api.github.com/users/iksaif/orgs","repos_url":"https://api.github.com/users/iksaif/repos","events_url":"https://api.github.com/users/iksaif/events{/privacy}","received_events_url":"https://api.github.com/users/iksaif/received_events","type":"User","site_admin":false},"assignees":[{"login":"iksaif","id":1032963,"avatar_url":"https://avatars.githubusercontent.com/u/1032963?v=3","gravatar_id":"","url":"https://api.github.com/users/iksaif","html_url":"https://github.com/iksaif","followers_url":"https://api.github.com/users/iksaif/followers","following_url":"https://api.github.com/users/iksaif/following{/other_user}","gists_url":"https://api.github.com/users/iksaif/gists{/gist_id}","starred_url":"https://api.github.com/users/iksaif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iksaif/subscriptions","organizations_url":"https://api.github.com/users/iksaif/orgs","repos_url":"https://api.github.com/users/iksaif/repos","events_url":"https://api.github.com/users/iksaif/events{/privacy}","received_events_url":"https://api.github.com/users/iksaif/received_events","type":"User","site_admin":false}],"milestone":null,"comments":11,"created_at":"2016-07-18T12:39:16Z","updated_at":"2016-07-19T11:45:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/criteo/biggraphite/pulls/49","html_url":"https://github.com/criteo/biggraphite/pull/49","diff_url":"https://github.com/criteo/biggraphite/pull/49.diff","patch_url":"https://github.com/criteo/biggraphite/pull/49.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/criteo/biggraphite/49)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/criteo/biggraphite/issues/comments/233607887","html_url":"https://github.com/criteo/biggraphite/pull/49#issuecomment-233607887","issue_url":"https://api.github.com/repos/criteo/biggraphite/issues/49","id":233607887,"user":{"login":"unbrice","id":530291,"avatar_url":"https://avatars.githubusercontent.com/u/530291?v=3","gravatar_id":"","url":"https://api.github.com/users/unbrice","html_url":"https://github.com/unbrice","followers_url":"https://api.github.com/users/unbrice/followers","following_url":"https://api.github.com/users/unbrice/following{/other_user}","gists_url":"https://api.github.com/users/unbrice/gists{/gist_id}","starred_url":"https://api.github.com/users/unbrice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unbrice/subscriptions","organizations_url":"https://api.github.com/users/unbrice/orgs","repos_url":"https://api.github.com/users/unbrice/repos","events_url":"https://api.github.com/users/unbrice/events{/privacy}","received_events_url":"https://api.github.com/users/unbrice/received_events","type":"User","site_admin":false},"created_at":"2016-07-19T11:45:03Z","updated_at":"2016-07-19T11:45:03Z","body":"\n\n\n\nReview status: all files reviewed at latest revision, 4 unresolved discussions.\n\n---\n\n*[biggraphite/drivers/downsampling.py, line 51 \\[r4\\]](https://reviewable.io:443/reviews/criteo/biggraphite/49#-KN1uN98I-Ab6pfKiLGA:-KN1uN98I-Ab6pfKiLGB:1805448501) ([raw file](https://github.com/criteo/biggraphite/blob/8a9790b91fec4f762a58b075f836a4968a038842/biggraphite/drivers/downsampling.py#L51)):*\n> ```Python\n>         \"\"\"\n>         # Sort points by increasing timestamp.\n>         sorted_points = sorted(datapoints, key=lambda p: p[0])\n> ```\n\nkey is not needed here and makes sorting slower (one function call)\n\n---\n\n*[biggraphite/drivers/downsampling.py, line 56 \\[r4\\]](https://reviewable.io:443/reviews/criteo/biggraphite/49#-KN1ukavJYNZk20yE_CX:-KN1ukavJYNZk20yE_CY:1045857653) ([raw file](https://github.com/criteo/biggraphite/blob/8a9790b91fec4f762a58b075f836a4968a038842/biggraphite/drivers/downsampling.py#L56)):*\n> ```Python\n>         expired_points = []\n>         for timestamp, value in sorted_points:\n>             expired_points.extend(self.__buffer.put(timestamp, value))\n> ```\n\nPlease confirm it is safe to call\nd.feed([4200, 0.0])\nd.feed([4000, 1.0])\neven though 4200 and 4000 will be out of order\n\n---\n\n*[tests/test_drivers_downsampling.py, line 308 \\[r4\\]](https://reviewable.io:443/reviews/criteo/biggraphite/49#-KN1xkibJ3FZYpph5wr8:-KN1xkic6MTDgGBcNvjr:1922602567) ([raw file](https://github.com/criteo/biggraphite/blob/8a9790b91fec4f762a58b075f836a4968a038842/tests/test_drivers_downsampling.py#L308)):*\n> ```Python\n>         ]\n>         expected_stage_1 = [\n>             (0, 26, 3, self.PRECISION ** 2)\n> ```\n\nplease add a comment: \"26 is 9 + 10 +7, sum of stage0 values\"\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/criteo/biggraphite/49)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"unbrice"}}