{"action":"created","issue":{"url":"https://api.github.com/repos/apple/swift/issues/2123","repository_url":"https://api.github.com/repos/apple/swift","labels_url":"https://api.github.com/repos/apple/swift/issues/2123/labels{/name}","comments_url":"https://api.github.com/repos/apple/swift/issues/2123/comments","events_url":"https://api.github.com/repos/apple/swift/issues/2123/events","html_url":"https://github.com/apple/swift/pull/2123","id":147199650,"number":2123,"title":"[AST][Sema] Fixes the IterativeTypeChecker and better manages circular protocol inheritance","user":{"login":"manavgabhawala","id":8603246,"avatar_url":"https://avatars.githubusercontent.com/u/8603246?v=3","gravatar_id":"","url":"https://api.github.com/users/manavgabhawala","html_url":"https://github.com/manavgabhawala","followers_url":"https://api.github.com/users/manavgabhawala/followers","following_url":"https://api.github.com/users/manavgabhawala/following{/other_user}","gists_url":"https://api.github.com/users/manavgabhawala/gists{/gist_id}","starred_url":"https://api.github.com/users/manavgabhawala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manavgabhawala/subscriptions","organizations_url":"https://api.github.com/users/manavgabhawala/orgs","repos_url":"https://api.github.com/users/manavgabhawala/repos","events_url":"https://api.github.com/users/manavgabhawala/events{/privacy}","received_events_url":"https://api.github.com/users/manavgabhawala/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"jopamer","id":618552,"avatar_url":"https://avatars.githubusercontent.com/u/618552?v=3","gravatar_id":"","url":"https://api.github.com/users/jopamer","html_url":"https://github.com/jopamer","followers_url":"https://api.github.com/users/jopamer/followers","following_url":"https://api.github.com/users/jopamer/following{/other_user}","gists_url":"https://api.github.com/users/jopamer/gists{/gist_id}","starred_url":"https://api.github.com/users/jopamer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jopamer/subscriptions","organizations_url":"https://api.github.com/users/jopamer/orgs","repos_url":"https://api.github.com/users/jopamer/repos","events_url":"https://api.github.com/users/jopamer/events{/privacy}","received_events_url":"https://api.github.com/users/jopamer/received_events","type":"User","site_admin":false},"milestone":null,"comments":9,"created_at":"2016-04-10T06:38:36Z","updated_at":"2016-05-08T23:25:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/2123","html_url":"https://github.com/apple/swift/pull/2123","diff_url":"https://github.com/apple/swift/pull/2123.diff","patch_url":"https://github.com/apple/swift/pull/2123.patch"},"body":"<!-- Please complete this template before creating pull request. -->\r\n#### What's in this pull request?\r\nImproves the diagnostics produced for circular protocol inheritance, further it improves the IterativeTypeChecker to use loops instead of recursion to help minimize the stack size and lastly improves the efficiency of detecting circular inheritance by making it a part of the main cycle when checking for inherited protocols.\r\n\r\n* * * *\r\n\r\n<!-- This selection should only be completed by Swift admin -->\r\nBefore merging this pull request to apple/swift repository:\r\n- [ ] Test pull request on Swift continuous integration.\r\n\r\n<details>\r\n  <summary>Triggering Swift CI</summary>\r\n\r\nThe swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:\r\n\r\n**Smoke Testing**\r\n\r\n        Platform     | Comment\r\n        ------------ | -------------\r\n        All supported platforms     | @swift-ci Please smoke test\r\n        OS X platform               | @swift-ci Please smoke test OS X platform\r\n        Linux platform              | @swift-ci Please smoke test Linux platform\r\n\r\n **Validation Testing**\r\n\r\n        Platform     | Comment\r\n        ------------ | -------------\r\n        All supported platforms     | @swift-ci Please test\r\n        OS X platform               | @swift-ci Please test OS X platform\r\n        Linux platform              | @swift-ci Please test Linux platform\r\n\r\nNote: Only members of the Apple organization can trigger swift-ci.\r\n</details>\r\n<!-- Thank you for your contribution to Swift! -->\r\n"},"comment":{"url":"https://api.github.com/repos/apple/swift/issues/comments/217752491","html_url":"https://github.com/apple/swift/pull/2123#issuecomment-217752491","issue_url":"https://api.github.com/repos/apple/swift/issues/2123","id":217752491,"user":{"login":"manavgabhawala","id":8603246,"avatar_url":"https://avatars.githubusercontent.com/u/8603246?v=3","gravatar_id":"","url":"https://api.github.com/users/manavgabhawala","html_url":"https://github.com/manavgabhawala","followers_url":"https://api.github.com/users/manavgabhawala/followers","following_url":"https://api.github.com/users/manavgabhawala/following{/other_user}","gists_url":"https://api.github.com/users/manavgabhawala/gists{/gist_id}","starred_url":"https://api.github.com/users/manavgabhawala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manavgabhawala/subscriptions","organizations_url":"https://api.github.com/users/manavgabhawala/orgs","repos_url":"https://api.github.com/users/manavgabhawala/repos","events_url":"https://api.github.com/users/manavgabhawala/events{/privacy}","received_events_url":"https://api.github.com/users/manavgabhawala/received_events","type":"User","site_admin":false},"created_at":"2016-05-08T23:25:57Z","updated_at":"2016-05-08T23:25:57Z","body":"@DougGregor I think the builds timed out. Is there something I need to do to fix it?"}}