{"push_id":1300310192,"size":97,"distinct_size":3,"ref":"refs/heads/separate-services","head":"5d21632458e48bed29f48277e5b3850cd43693a2","before":"459dced2c6c673b76c6db7a2209237c1c3dbf1d6","commits":[{"sha":"8dbff4892641b03bb8913034425edb0bf1f4e4ec","author":{"name":"Radu Berinde","email":"ea8e73412c2808db667796f35f8c95b16e969d70@gmail.com"},"message":"client: clean up the txnSender mess\n\nThis is a rough description of the current nightmare in Txn: NewTxn takes a db;\nit remembers the db's original Sender in txn.wrapped, and then it highjacks\n`db.sender`, setting it to txnSender. txnSender is a Sender implementation\nwhich uses the saved (wrapped) sender internally (it also ignores the provided\ncontext).\n\nAll this mind bending stuff is there for the sole purpose of reusing the code\nin `db.send()` which does very little stuff before calling to db.sender.\n\nCleaning all this stuff up. We keep DB as is, and use a `sendInternal` function\ninstead of `db.send`. Factoring out the little stuff that `db.send()` does into\n`db.prepareToSend()` so we can reuse it. This will be folded back into\n`db.send()` once it supports a context.","distinct":false,"url":"https://api.github.com/repos/tamird/cockroach/commits/8dbff4892641b03bb8913034425edb0bf1f4e4ec"},{"sha":"81586586550885fe7acc0b352a03d541e633505b","author":{"name":"RaduBerinde","email":"295c33b47a77c8cc349159d95207f89af9f8470a@cockroachlabs.com"},"message":"Merge pull request #9248 from RaduBerinde/ctx-fixes\n\nclient: clean up the txnSender mess","distinct":false,"url":"https://api.github.com/repos/tamird/cockroach/commits/81586586550885fe7acc0b352a03d541e633505b"},{"sha":"71936556762f9e3841126efbbd756c64db511ec4","author":{"name":"Ben Darnell","email":"9c85637c38b80821c7bd8a03bde7b59da81ab77d@cockroachlabs.com"},"message":"kv: Hack around GRPC context leak\n\nI believe this will prevent the leak described in\nhttps://github.com/grpc/grpc-go/issues/888","distinct":false,"url":"https://api.github.com/repos/tamird/cockroach/commits/71936556762f9e3841126efbbd756c64db511ec4"},{"sha":"d8213c22bde5ed4debeb979f36e6856dbb2a51b4","author":{"name":"Ben Darnell","email":"9c85637c38b80821c7bd8a03bde7b59da81ab77d@bendarnell.com"},"message":"Merge pull request #9258 from bdarnell/hack-context-leak\n\nkv: Hack around GRPC context leak","distinct":false,"url":"https://api.github.com/repos/tamird/cockroach/commits/d8213c22bde5ed4debeb979f36e6856dbb2a51b4"},{"sha":"13d84aaca5e4b58890b2e2062cc3f2f99867941e","author":{"name":"Andrei Matei","email":"82d83a1950b1b041ac07a9fa8d0428277a5e4bfe@cockroachlabs.com"},"message":"sql: move span collection from a client.Txn to a TxnState\n\nThe TxnState matches the lifetime of a SQL txn, whereas the client.Txn\ngoes away when the SQL txn goes, for example, to the Aborted state.\nPlus, the SQL executor has direct access to a txnState, so it's natural\nfor it to use the TxnState's context for log messages, and we want these\nmessages aassocited with the \"transaction's trace\". In fact, the\nTxnState was already the the holder of a txn's root span, so this is in\neffect unifying the owner of the span and of all the collected children\nspans.\n\nThis commit also makes all SQL transactions be executed with a root\nspan.","distinct":false,"url":"https://api.github.com/repos/tamird/cockroach/commits/13d84aaca5e4b58890b2e2062cc3f2f99867941e"},{"sha":"fb897b9e92e21c5f715b80c82a08d8a5ee535cb0","author":{"name":"Andrei Matei","email":"82d83a1950b1b041ac07a9fa8d0428277a5e4bfe@cockroachlabs.com"},"message":"sql: clean up a transaction when the session closes\n\nAt the very least, we have to close the transaction's root span.\nWe also do more cleanup and attempt to rollback the txn. This is nice\nbecause it lets the rollback attempt be done in the context of the txn.\nIt supersedes the aborting that was being done by the TxnCoordSender\nthrough the cancellation of the session's context with interrupted the\ntxn's heartbeat loop.","distinct":false,"url":"https://api.github.com/repos/tamird/cockroach/commits/fb897b9e92e21c5f715b80c82a08d8a5ee535cb0"},{"sha":"84c0247191314c53aa40b8d5698f6e5c1e524a87","author":{"name":"Andrei Matei","email":"82d83a1950b1b041ac07a9fa8d0428277a5e4bfe@cockroachlabs.com"},"message":"log: add file:line to trace log messages\n\nThis only affects messages coming from log.Infof(). Messages going\ndirectly to log.Trace(), or messages going through log.VTrace() but with\nthe verbosity turned off are not affected and will continue to not have\nfile/line.","distinct":false,"url":"https://api.github.com/repos/tamird/cockroach/commits/84c0247191314c53aa40b8d5698f6e5c1e524a87"},{"sha":"4659e38c30c1623d7e49500ded9d27c85ca69bb1","author":{"name":"Andrei Matei","email":"82d83a1950b1b041ac07a9fa8d0428277a5e4bfe@cockroachlabs.com"},"message":"sql: add special tracing to trap #7881\n\nI've decided to go medieval and invest in tracing all SQL execution in\nthe hope that #7881 will be triggered again. This builds on the prev\ncommit that added the ability to collect spans across the executor and a\nclient.Txn.\nThe tracing is gated by an env var. When turned on, every SQL txn\ncreates a new tracer that accumulates spans in the session's txnState\n(this is similar to how \"SQL tracing\" currently works). When we detect\n7881, we mark the root span of the current one of these traces for\n\"sampling\", which means that later, when that span (and hence the trace)\nis closed, we dump the trace with all the log messages in it (note that\ncurrently this trace only has one span, since we're not very good at\nstarting child spans yet).","distinct":false,"url":"https://api.github.com/repos/tamird/cockroach/commits/4659e38c30c1623d7e49500ded9d27c85ca69bb1"},{"sha":"860d5044234abcda41ca45990e3f0f2cebabf454","author":{"name":"Andrei Matei","email":"10a93020cc4f038c14193f054a8660a80d6d683c@gmail.com"},"message":"Merge pull request #8681 from andreimatei/fix-autocommit\n\n[stability] sql: add special tracing to trap #7881","distinct":false,"url":"https://api.github.com/repos/tamird/cockroach/commits/860d5044234abcda41ca45990e3f0f2cebabf454"},{"sha":"d717cf10ee7ce30116a7cbf6f47036e4386d776a","author":{"name":"Tamir Duberstein","email":"e1bddfe3ffe5ebd2c7f96cf97e1a1b1e30f1ebb8@gmail.com"},"message":"server: skip flaky test","distinct":false,"url":"https://api.github.com/repos/tamird/cockroach/commits/d717cf10ee7ce30116a7cbf6f47036e4386d776a"},{"sha":"9fee2cd52fcb2ef0b91618a1ac8dd9364270a133","author":{"name":"Tamir Duberstein","email":"e1bddfe3ffe5ebd2c7f96cf97e1a1b1e30f1ebb8@gmail.com"},"message":"Merge pull request #9270 from tamird/skip-flaky\n\nserver: skip flaky test","distinct":false,"url":"https://api.github.com/repos/tamird/cockroach/commits/9fee2cd52fcb2ef0b91618a1ac8dd9364270a133"},{"sha":"c7aa7c9ebb2b8ac90f53ead33c04a2805b56fd6c","author":{"name":"Radu Berinde","email":"ea8e73412c2808db667796f35f8c95b16e969d70@gmail.com"},"message":"sql: put session events in eventlog\n\nSQL has a per-session \"debug/request\" trace which can be very long-lived.\nReplacing it with an EventLog (which shows up under \"debug/events\").\n\nCherry-pick of 889aa7 from develop.","distinct":false,"url":"https://api.github.com/repos/tamird/cockroach/commits/c7aa7c9ebb2b8ac90f53ead33c04a2805b56fd6c"},{"sha":"c7442bcd3fb84fa0f57ff7f214a3dda694cf1ef7","author":{"name":"Tobias Schottdorf","email":"b6841086cafcf6616505d164b61ac2cf1ab42c4e@gmail.com"},"message":"Minor log message fixes","distinct":false,"url":"https://api.github.com/repos/tamird/cockroach/commits/c7442bcd3fb84fa0f57ff7f214a3dda694cf1ef7"},{"sha":"3e038650252d8400bfb0af263470f7f6944dccc7","author":{"name":"RaduBerinde","email":"295c33b47a77c8cc349159d95207f89af9f8470a@cockroachlabs.com"},"message":"Merge pull request #9262 from RaduBerinde/cherry-sql-event\n\nsql: put session events in eventlog","distinct":false,"url":"https://api.github.com/repos/tamird/cockroach/commits/3e038650252d8400bfb0af263470f7f6944dccc7"},{"sha":"3df74831f9487cb3f7c44a9b70f3a43c4607aa20","author":{"name":"Radu Berinde","email":"ea8e73412c2808db667796f35f8c95b16e969d70@gmail.com"},"message":"client: remove Runnable interface\n\nRemoving the Runnable interface; refactoring the helper functions to just take\nthe result of Run() (instead of calling it themselves).","distinct":false,"url":"https://api.github.com/repos/tamird/cockroach/commits/3df74831f9487cb3f7c44a9b70f3a43c4607aa20"},{"sha":"0e98a17e35d80b0dfceccbbafa05b6f259d38398","author":{"name":"Radu Berinde","email":"ea8e73412c2808db667796f35f8c95b16e969d70@gmail.com"},"message":"client: add context to Db.Run()","distinct":false,"url":"https://api.github.com/repos/tamird/cockroach/commits/0e98a17e35d80b0dfceccbbafa05b6f259d38398"},{"sha":"95901e908873db82399ef101bf06bb17b52a97bc","author":{"name":"RaduBerinde","email":"295c33b47a77c8cc349159d95207f89af9f8470a@cockroachlabs.com"},"message":"Merge pull request #9260 from RaduBerinde/client-ctx-first\n\nclient: add context to DB.Run()","distinct":false,"url":"https://api.github.com/repos/tamird/cockroach/commits/95901e908873db82399ef101bf06bb17b52a97bc"},{"sha":"cdabd9041244a1b170d87fc39f4d957745c56ae3","author":{"name":"Tobias Schottdorf","email":"b6841086cafcf6616505d164b61ac2cf1ab42c4e@gmail.com"},"message":"Merge pull request #9274 from tschottdorf/typo\n\nMinor log message fixes","distinct":false,"url":"https://api.github.com/repos/tamird/cockroach/commits/cdabd9041244a1b170d87fc39f4d957745c56ae3"},{"sha":"b64d176af7a69bab1c9de3c0fa19af6f034cd530","author":{"name":"Radu Berinde","email":"ea8e73412c2808db667796f35f8c95b16e969d70@gmail.com"},"message":"ts: plumb contexts\n\nThe bathes ran by `ts` now get contexts. This fixes the lack of node tagas on\nthese operations. In addition they are also marked with the `ts-srv` or\n`ts-poll` tag.","distinct":false,"url":"https://api.github.com/repos/tamird/cockroach/commits/b64d176af7a69bab1c9de3c0fa19af6f034cd530"},{"sha":"f7549d19cbebd6050cc167e7d806941aa77d4e5c","author":{"name":"Radu Berinde","email":"ea8e73412c2808db667796f35f8c95b16e969d70@gmail.com"},"message":"log: don't duplicate tags\n\nDon't duplicate tags when using WithLogTagsFromCtx.","distinct":false,"url":"https://api.github.com/repos/tamird/cockroach/commits/f7549d19cbebd6050cc167e7d806941aa77d4e5c"}]}
{"actor":{"display_login":"tamird"}}