{"action":"created","comment":{"url":"https://api.github.com/repos/servo/servo/pulls/comments/85578135","pull_request_review_id":6288444,"id":85578135,"diff_hunk":"@@ -640,27 +640,27 @@ pub fn process_resolved_style_request<'a, N, C>(requested_node: N,\n     ensure_node_data_initialized(&requested_node);\n     ensure_element_styled(requested_node.as_element().unwrap(), style_context);\n \n-    let layout_node = requested_node.to_threadsafe();\n-    let layout_node = match *pseudo {\n-        Some(PseudoElement::Before) => layout_node.get_before_pseudo(),\n-        Some(PseudoElement::After) => layout_node.get_after_pseudo(),\n+    let layout_el = requested_node.to_threadsafe().as_element().unwrap();","path":"components/layout/query.rs","position":26,"original_position":26,"commit_id":"9094b8c88cb462c105e386def605c62a85cc2bb4","original_commit_id":"9094b8c88cb462c105e386def605c62a85cc2bb4","user":{"login":"bholley","id":377435,"avatar_url":"https://avatars.githubusercontent.com/u/377435?v=3","gravatar_id":"","url":"https://api.github.com/users/bholley","html_url":"https://github.com/bholley","followers_url":"https://api.github.com/users/bholley/followers","following_url":"https://api.github.com/users/bholley/following{/other_user}","gists_url":"https://api.github.com/users/bholley/gists{/gist_id}","starred_url":"https://api.github.com/users/bholley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bholley/subscriptions","organizations_url":"https://api.github.com/users/bholley/orgs","repos_url":"https://api.github.com/users/bholley/repos","events_url":"https://api.github.com/users/bholley/events{/privacy}","received_events_url":"https://api.github.com/users/bholley/received_events","type":"User","site_admin":false},"body":"Turns out to be kinda hard to do because LayoutElement doesn't exist until #13956, and the opaque representations are all Node-y. We can do it later.","created_at":"2016-10-28T17:48:53Z","updated_at":"2016-10-28T17:48:53Z","html_url":"https://github.com/servo/servo/pull/13951#discussion_r85578135","pull_request_url":"https://api.github.com/repos/servo/servo/pulls/13951","_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/comments/85578135"},"html":{"href":"https://github.com/servo/servo/pull/13951#discussion_r85578135"},"pull_request":{"href":"https://api.github.com/repos/servo/servo/pulls/13951"}}},"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/13951","id":91305950,"html_url":"https://github.com/servo/servo/pull/13951","diff_url":"https://github.com/servo/servo/pull/13951.diff","patch_url":"https://github.com/servo/servo/pull/13951.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/13951","number":13951,"state":"open","locked":false,"title":"incremental restyle: Hoist more stuff to Element","user":{"login":"bholley","id":377435,"avatar_url":"https://avatars.githubusercontent.com/u/377435?v=3","gravatar_id":"","url":"https://api.github.com/users/bholley","html_url":"https://github.com/bholley","followers_url":"https://api.github.com/users/bholley/followers","following_url":"https://api.github.com/users/bholley/following{/other_user}","gists_url":"https://api.github.com/users/bholley/gists{/gist_id}","starred_url":"https://api.github.com/users/bholley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bholley/subscriptions","organizations_url":"https://api.github.com/users/bholley/orgs","repos_url":"https://api.github.com/users/bholley/repos","events_url":"https://api.github.com/users/bholley/events{/privacy}","received_events_url":"https://api.github.com/users/bholley/received_events","type":"User","site_admin":false},"body":"The patch here hoists pseudo-element handling onto ThreadSafeLayoutElement. I have another patch which hoists stuff from TNode to TElement, but want to make sure this patch passes try first.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/13951)\n<!-- Reviewable:end -->\n","created_at":"2016-10-28T00:47:00Z","updated_at":"2016-10-28T17:48:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81810b5c3da2b51181de622d24c255e5d8c2b463","assignee":{"login":"emilio","id":1323194,"avatar_url":"https://avatars.githubusercontent.com/u/1323194?v=3","gravatar_id":"","url":"https://api.github.com/users/emilio","html_url":"https://github.com/emilio","followers_url":"https://api.github.com/users/emilio/followers","following_url":"https://api.github.com/users/emilio/following{/other_user}","gists_url":"https://api.github.com/users/emilio/gists{/gist_id}","starred_url":"https://api.github.com/users/emilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilio/subscriptions","organizations_url":"https://api.github.com/users/emilio/orgs","repos_url":"https://api.github.com/users/emilio/repos","events_url":"https://api.github.com/users/emilio/events{/privacy}","received_events_url":"https://api.github.com/users/emilio/received_events","type":"User","site_admin":false},"assignees":[{"login":"emilio","id":1323194,"avatar_url":"https://avatars.githubusercontent.com/u/1323194?v=3","gravatar_id":"","url":"https://api.github.com/users/emilio","html_url":"https://github.com/emilio","followers_url":"https://api.github.com/users/emilio/followers","following_url":"https://api.github.com/users/emilio/following{/other_user}","gists_url":"https://api.github.com/users/emilio/gists{/gist_id}","starred_url":"https://api.github.com/users/emilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilio/subscriptions","organizations_url":"https://api.github.com/users/emilio/orgs","repos_url":"https://api.github.com/users/emilio/repos","events_url":"https://api.github.com/users/emilio/events{/privacy}","received_events_url":"https://api.github.com/users/emilio/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/13951/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/13951/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/13951/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/9094b8c88cb462c105e386def605c62a85cc2bb4","head":{"label":"bholley:more_element","ref":"more_element","sha":"9094b8c88cb462c105e386def605c62a85cc2bb4","user":{"login":"bholley","id":377435,"avatar_url":"https://avatars.githubusercontent.com/u/377435?v=3","gravatar_id":"","url":"https://api.github.com/users/bholley","html_url":"https://github.com/bholley","followers_url":"https://api.github.com/users/bholley/followers","following_url":"https://api.github.com/users/bholley/following{/other_user}","gists_url":"https://api.github.com/users/bholley/gists{/gist_id}","starred_url":"https://api.github.com/users/bholley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bholley/subscriptions","organizations_url":"https://api.github.com/users/bholley/orgs","repos_url":"https://api.github.com/users/bholley/repos","events_url":"https://api.github.com/users/bholley/events{/privacy}","received_events_url":"https://api.github.com/users/bholley/received_events","type":"User","site_admin":false},"repo":{"id":13421111,"name":"servo","full_name":"bholley/servo","owner":{"login":"bholley","id":377435,"avatar_url":"https://avatars.githubusercontent.com/u/377435?v=3","gravatar_id":"","url":"https://api.github.com/users/bholley","html_url":"https://github.com/bholley","followers_url":"https://api.github.com/users/bholley/followers","following_url":"https://api.github.com/users/bholley/following{/other_user}","gists_url":"https://api.github.com/users/bholley/gists{/gist_id}","starred_url":"https://api.github.com/users/bholley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bholley/subscriptions","organizations_url":"https://api.github.com/users/bholley/orgs","repos_url":"https://api.github.com/users/bholley/repos","events_url":"https://api.github.com/users/bholley/events{/privacy}","received_events_url":"https://api.github.com/users/bholley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bholley/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/bholley/servo","forks_url":"https://api.github.com/repos/bholley/servo/forks","keys_url":"https://api.github.com/repos/bholley/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bholley/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bholley/servo/teams","hooks_url":"https://api.github.com/repos/bholley/servo/hooks","issue_events_url":"https://api.github.com/repos/bholley/servo/issues/events{/number}","events_url":"https://api.github.com/repos/bholley/servo/events","assignees_url":"https://api.github.com/repos/bholley/servo/assignees{/user}","branches_url":"https://api.github.com/repos/bholley/servo/branches{/branch}","tags_url":"https://api.github.com/repos/bholley/servo/tags","blobs_url":"https://api.github.com/repos/bholley/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bholley/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bholley/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/bholley/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bholley/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/bholley/servo/languages","stargazers_url":"https://api.github.com/repos/bholley/servo/stargazers","contributors_url":"https://api.github.com/repos/bholley/servo/contributors","subscribers_url":"https://api.github.com/repos/bholley/servo/subscribers","subscription_url":"https://api.github.com/repos/bholley/servo/subscription","commits_url":"https://api.github.com/repos/bholley/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/bholley/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/bholley/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/bholley/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/bholley/servo/contents/{+path}","compare_url":"https://api.github.com/repos/bholley/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bholley/servo/merges","archive_url":"https://api.github.com/repos/bholley/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bholley/servo/downloads","issues_url":"https://api.github.com/repos/bholley/servo/issues{/number}","pulls_url":"https://api.github.com/repos/bholley/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/bholley/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/bholley/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bholley/servo/labels{/name}","releases_url":"https://api.github.com/repos/bholley/servo/releases{/id}","deployments_url":"https://api.github.com/repos/bholley/servo/deployments","created_at":"2013-10-08T17:55:47Z","updated_at":"2015-10-09T02:34:11Z","pushed_at":"2016-10-28T07:30:48Z","git_url":"git://github.com/bholley/servo.git","ssh_url":"git@github.com:bholley/servo.git","clone_url":"https://github.com/bholley/servo.git","svn_url":"https://github.com/bholley/servo","homepage":"","size":213130,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"b4a882f81ab9d8128166a49f0514a398ad7a3b7d","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","deployments_url":"https://api.github.com/repos/servo/servo/deployments","created_at":"2012-02-08T19:07:25Z","updated_at":"2016-10-28T17:03:17Z","pushed_at":"2016-10-28T17:31:56Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"https://servo.org/","size":303896,"stargazers_count":8161,"watchers_count":8161,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1328,"mirror_url":null,"open_issues_count":1864,"forks":1328,"open_issues":1864,"watchers":8161,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/13951"},"html":{"href":"https://github.com/servo/servo/pull/13951"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/13951"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/13951/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/13951/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/13951/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/9094b8c88cb462c105e386def605c62a85cc2bb4"}}}}
{"actor":{"display_login":"bholley"}}