{"action":"closed","number":544,"pull_request":{"url":"https://api.github.com/repos/wireapp/wire-webapp/pulls/544","id":97289933,"html_url":"https://github.com/wireapp/wire-webapp/pull/544","diff_url":"https://github.com/wireapp/wire-webapp/pull/544.diff","patch_url":"https://github.com/wireapp/wire-webapp/pull/544.patch","issue_url":"https://api.github.com/repos/wireapp/wire-webapp/issues/544","number":544,"state":"closed","locked":false,"title":"hide avatar using knockouts virtual if binding","user":{"login":"herrmannplatz","id":174685,"avatar_url":"https://avatars.githubusercontent.com/u/174685?v=3","gravatar_id":"","url":"https://api.github.com/users/herrmannplatz","html_url":"https://github.com/herrmannplatz","followers_url":"https://api.github.com/users/herrmannplatz/followers","following_url":"https://api.github.com/users/herrmannplatz/following{/other_user}","gists_url":"https://api.github.com/users/herrmannplatz/gists{/gist_id}","starred_url":"https://api.github.com/users/herrmannplatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/herrmannplatz/subscriptions","organizations_url":"https://api.github.com/users/herrmannplatz/orgs","repos_url":"https://api.github.com/users/herrmannplatz/repos","events_url":"https://api.github.com/users/herrmannplatz/events{/privacy}","received_events_url":"https://api.github.com/users/herrmannplatz/received_events","type":"User","site_admin":false},"body":"## Type of change\r\nSince the user avatar was removed using `display: none`, all knockout bindings where triggered. This can be avoided using the if binding.\r\n\r\n## Screenshot\r\n<!--- Please add a screenshot if it's a design change. -->\r\n<!--- Info: https://help.github.com/articles/file-attachments-on-issues-and-pull-requests/ -->\r\n\r\n","created_at":"2016-12-09T11:04:42Z","updated_at":"2016-12-09T13:53:03Z","closed_at":"2016-12-09T13:53:03Z","merged_at":"2016-12-09T13:53:03Z","merge_commit_sha":"c42fd82f8ef7b670f21334458556aaf0b5e8fdd7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/wireapp/wire-webapp/pulls/544/commits","review_comments_url":"https://api.github.com/repos/wireapp/wire-webapp/pulls/544/comments","review_comment_url":"https://api.github.com/repos/wireapp/wire-webapp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wireapp/wire-webapp/issues/544/comments","statuses_url":"https://api.github.com/repos/wireapp/wire-webapp/statuses/3320a7bba0cadf5eb0b644168cfac67a4b2090da","head":{"label":"wireapp:improvement/hide-avatars-ko","ref":"improvement/hide-avatars-ko","sha":"3320a7bba0cadf5eb0b644168cfac67a4b2090da","user":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars.githubusercontent.com/u/16047324?v=3","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":63881328,"name":"wire-webapp","full_name":"wireapp/wire-webapp","owner":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars.githubusercontent.com/u/16047324?v=3","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wireapp/wire-webapp","description":"👽 Wire for Web — Modern communication. Full privacy.","fork":false,"url":"https://api.github.com/repos/wireapp/wire-webapp","forks_url":"https://api.github.com/repos/wireapp/wire-webapp/forks","keys_url":"https://api.github.com/repos/wireapp/wire-webapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-webapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-webapp/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-webapp/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-webapp/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-webapp/events","assignees_url":"https://api.github.com/repos/wireapp/wire-webapp/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-webapp/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-webapp/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-webapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-webapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-webapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-webapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-webapp/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-webapp/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-webapp/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-webapp/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-webapp/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-webapp/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-webapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-webapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-webapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-webapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-webapp/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-webapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-webapp/merges","archive_url":"https://api.github.com/repos/wireapp/wire-webapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-webapp/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-webapp/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-webapp/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-webapp/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-webapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-webapp/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-webapp/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-webapp/deployments","created_at":"2016-07-21T15:34:05Z","updated_at":"2016-12-08T23:41:02Z","pushed_at":"2016-12-09T13:53:04Z","git_url":"git://github.com/wireapp/wire-webapp.git","ssh_url":"git@github.com:wireapp/wire-webapp.git","clone_url":"https://github.com/wireapp/wire-webapp.git","svn_url":"https://github.com/wireapp/wire-webapp","homepage":"https://app.wire.com","size":12066,"stargazers_count":526,"watchers_count":526,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":83,"mirror_url":null,"open_issues_count":49,"forks":83,"open_issues":49,"watchers":526,"default_branch":"dev"}},"base":{"label":"wireapp:dev","ref":"dev","sha":"12c52c2cfb38c16da53bcb6e602a0deafa326d2d","user":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars.githubusercontent.com/u/16047324?v=3","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":63881328,"name":"wire-webapp","full_name":"wireapp/wire-webapp","owner":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars.githubusercontent.com/u/16047324?v=3","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wireapp/wire-webapp","description":"👽 Wire for Web — Modern communication. Full privacy.","fork":false,"url":"https://api.github.com/repos/wireapp/wire-webapp","forks_url":"https://api.github.com/repos/wireapp/wire-webapp/forks","keys_url":"https://api.github.com/repos/wireapp/wire-webapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-webapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-webapp/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-webapp/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-webapp/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-webapp/events","assignees_url":"https://api.github.com/repos/wireapp/wire-webapp/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-webapp/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-webapp/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-webapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-webapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-webapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-webapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-webapp/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-webapp/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-webapp/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-webapp/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-webapp/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-webapp/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-webapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-webapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-webapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-webapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-webapp/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-webapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-webapp/merges","archive_url":"https://api.github.com/repos/wireapp/wire-webapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-webapp/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-webapp/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-webapp/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-webapp/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-webapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-webapp/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-webapp/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-webapp/deployments","created_at":"2016-07-21T15:34:05Z","updated_at":"2016-12-08T23:41:02Z","pushed_at":"2016-12-09T13:53:04Z","git_url":"git://github.com/wireapp/wire-webapp.git","ssh_url":"git@github.com:wireapp/wire-webapp.git","clone_url":"https://github.com/wireapp/wire-webapp.git","svn_url":"https://github.com/wireapp/wire-webapp","homepage":"https://app.wire.com","size":12066,"stargazers_count":526,"watchers_count":526,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":83,"mirror_url":null,"open_issues_count":49,"forks":83,"open_issues":49,"watchers":526,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/wireapp/wire-webapp/pulls/544"},"html":{"href":"https://github.com/wireapp/wire-webapp/pull/544"},"issue":{"href":"https://api.github.com/repos/wireapp/wire-webapp/issues/544"},"comments":{"href":"https://api.github.com/repos/wireapp/wire-webapp/issues/544/comments"},"review_comments":{"href":"https://api.github.com/repos/wireapp/wire-webapp/pulls/544/comments"},"review_comment":{"href":"https://api.github.com/repos/wireapp/wire-webapp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wireapp/wire-webapp/pulls/544/commits"},"statuses":{"href":"https://api.github.com/repos/wireapp/wire-webapp/statuses/3320a7bba0cadf5eb0b644168cfac67a4b2090da"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"herrmannplatz","id":174685,"avatar_url":"https://avatars.githubusercontent.com/u/174685?v=3","gravatar_id":"","url":"https://api.github.com/users/herrmannplatz","html_url":"https://github.com/herrmannplatz","followers_url":"https://api.github.com/users/herrmannplatz/followers","following_url":"https://api.github.com/users/herrmannplatz/following{/other_user}","gists_url":"https://api.github.com/users/herrmannplatz/gists{/gist_id}","starred_url":"https://api.github.com/users/herrmannplatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/herrmannplatz/subscriptions","organizations_url":"https://api.github.com/users/herrmannplatz/orgs","repos_url":"https://api.github.com/users/herrmannplatz/repos","events_url":"https://api.github.com/users/herrmannplatz/events{/privacy}","received_events_url":"https://api.github.com/users/herrmannplatz/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":12,"deletions":10,"changed_files":1}}
{"actor":{"display_login":"herrmannplatz"}}