{"action":"created","comment":{"url":"https://api.github.com/repos/ament/ament_tools/pulls/comments/52085148","id":52085148,"diff_hunk":"@@ -231,14 +231,18 @@ def _get_visual_studio_configuration(self, context):\n                 break\n         else:\n             # get for CMake build type from the CMake cache\n-            line_prefix = 'CMAKE_BUILD_TYPE:STRING='\n+            line_prefix = 'CMAKE_BUILD_TYPE:'\n             cmake_cache = os.path.join(context.build_space, 'CMakeCache.txt')\n             if os.path.exists(cmake_cache):\n                 with open(cmake_cache, 'r') as h:\n                     lines = h.read().splitlines()\n                 for line in lines:\n                     if line.startswith(line_prefix):\n-                        build_type = line[len(line_prefix):]\n+                        try:\n+                            index = line.index('=')\n+                        except ValueError:\n+                            continue\n+                        build_type = line[index + 1:]","path":"ament_tools/build_types/cmake.py","position":17,"original_position":17,"commit_id":"c51dad2790c1878efe7eb4c48b008441a2a76c4d","original_commit_id":"c51dad2790c1878efe7eb4c48b008441a2a76c4d","user":{"login":"wjwwood","id":100427,"avatar_url":"https://avatars.githubusercontent.com/u/100427?v=3","gravatar_id":"","url":"https://api.github.com/users/wjwwood","html_url":"https://github.com/wjwwood","followers_url":"https://api.github.com/users/wjwwood/followers","following_url":"https://api.github.com/users/wjwwood/following{/other_user}","gists_url":"https://api.github.com/users/wjwwood/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwwood/subscriptions","organizations_url":"https://api.github.com/users/wjwwood/orgs","repos_url":"https://api.github.com/users/wjwwood/repos","events_url":"https://api.github.com/users/wjwwood/events{/privacy}","received_events_url":"https://api.github.com/users/wjwwood/received_events","type":"User","site_admin":false},"body":"I see.","created_at":"2016-02-05T23:07:29Z","updated_at":"2016-02-05T23:07:29Z","html_url":"https://github.com/ament/ament_tools/pull/75#discussion_r52085148","pull_request_url":"https://api.github.com/repos/ament/ament_tools/pulls/75","_links":{"self":{"href":"https://api.github.com/repos/ament/ament_tools/pulls/comments/52085148"},"html":{"href":"https://github.com/ament/ament_tools/pull/75#discussion_r52085148"},"pull_request":{"href":"https://api.github.com/repos/ament/ament_tools/pulls/75"}}},"pull_request":{"url":"https://api.github.com/repos/ament/ament_tools/pulls/75","id":58494175,"html_url":"https://github.com/ament/ament_tools/pull/75","diff_url":"https://github.com/ament/ament_tools/pull/75.diff","patch_url":"https://github.com/ament/ament_tools/pull/75.patch","issue_url":"https://api.github.com/repos/ament/ament_tools/issues/75","number":75,"state":"open","locked":false,"title":"improve logic to determine build type","user":{"login":"dirk-thomas","id":1335366,"avatar_url":"https://avatars.githubusercontent.com/u/1335366?v=3","gravatar_id":"","url":"https://api.github.com/users/dirk-thomas","html_url":"https://github.com/dirk-thomas","followers_url":"https://api.github.com/users/dirk-thomas/followers","following_url":"https://api.github.com/users/dirk-thomas/following{/other_user}","gists_url":"https://api.github.com/users/dirk-thomas/gists{/gist_id}","starred_url":"https://api.github.com/users/dirk-thomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirk-thomas/subscriptions","organizations_url":"https://api.github.com/users/dirk-thomas/orgs","repos_url":"https://api.github.com/users/dirk-thomas/repos","events_url":"https://api.github.com/users/dirk-thomas/events{/privacy}","received_events_url":"https://api.github.com/users/dirk-thomas/received_events","type":"User","site_admin":false},"body":"CMake is not consistently using the PATH type for the cache entry.\r\n\r\nFollowup of #73.","created_at":"2016-02-05T22:34:59Z","updated_at":"2016-02-05T23:07:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80efbee2a2c413654abe01007cfbd6a60179a263","assignee":{"login":"dirk-thomas","id":1335366,"avatar_url":"https://avatars.githubusercontent.com/u/1335366?v=3","gravatar_id":"","url":"https://api.github.com/users/dirk-thomas","html_url":"https://github.com/dirk-thomas","followers_url":"https://api.github.com/users/dirk-thomas/followers","following_url":"https://api.github.com/users/dirk-thomas/following{/other_user}","gists_url":"https://api.github.com/users/dirk-thomas/gists{/gist_id}","starred_url":"https://api.github.com/users/dirk-thomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirk-thomas/subscriptions","organizations_url":"https://api.github.com/users/dirk-thomas/orgs","repos_url":"https://api.github.com/users/dirk-thomas/repos","events_url":"https://api.github.com/users/dirk-thomas/events{/privacy}","received_events_url":"https://api.github.com/users/dirk-thomas/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/ament/ament_tools/pulls/75/commits","review_comments_url":"https://api.github.com/repos/ament/ament_tools/pulls/75/comments","review_comment_url":"https://api.github.com/repos/ament/ament_tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ament/ament_tools/issues/75/comments","statuses_url":"https://api.github.com/repos/ament/ament_tools/statuses/c51dad2790c1878efe7eb4c48b008441a2a76c4d","head":{"label":"ament:generator_expression","ref":"generator_expression","sha":"c51dad2790c1878efe7eb4c48b008441a2a76c4d","user":{"login":"ament","id":7365061,"avatar_url":"https://avatars.githubusercontent.com/u/7365061?v=3","gravatar_id":"","url":"https://api.github.com/users/ament","html_url":"https://github.com/ament","followers_url":"https://api.github.com/users/ament/followers","following_url":"https://api.github.com/users/ament/following{/other_user}","gists_url":"https://api.github.com/users/ament/gists{/gist_id}","starred_url":"https://api.github.com/users/ament/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ament/subscriptions","organizations_url":"https://api.github.com/users/ament/orgs","repos_url":"https://api.github.com/users/ament/repos","events_url":"https://api.github.com/users/ament/events{/privacy}","received_events_url":"https://api.github.com/users/ament/received_events","type":"Organization","site_admin":false},"repo":{"id":19927831,"name":"ament_tools","full_name":"ament/ament_tools","owner":{"login":"ament","id":7365061,"avatar_url":"https://avatars.githubusercontent.com/u/7365061?v=3","gravatar_id":"","url":"https://api.github.com/users/ament","html_url":"https://github.com/ament","followers_url":"https://api.github.com/users/ament/followers","following_url":"https://api.github.com/users/ament/following{/other_user}","gists_url":"https://api.github.com/users/ament/gists{/gist_id}","starred_url":"https://api.github.com/users/ament/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ament/subscriptions","organizations_url":"https://api.github.com/users/ament/orgs","repos_url":"https://api.github.com/users/ament/repos","events_url":"https://api.github.com/users/ament/events{/privacy}","received_events_url":"https://api.github.com/users/ament/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ament/ament_tools","description":"Command line tools for working with ament","fork":false,"url":"https://api.github.com/repos/ament/ament_tools","forks_url":"https://api.github.com/repos/ament/ament_tools/forks","keys_url":"https://api.github.com/repos/ament/ament_tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ament/ament_tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ament/ament_tools/teams","hooks_url":"https://api.github.com/repos/ament/ament_tools/hooks","issue_events_url":"https://api.github.com/repos/ament/ament_tools/issues/events{/number}","events_url":"https://api.github.com/repos/ament/ament_tools/events","assignees_url":"https://api.github.com/repos/ament/ament_tools/assignees{/user}","branches_url":"https://api.github.com/repos/ament/ament_tools/branches{/branch}","tags_url":"https://api.github.com/repos/ament/ament_tools/tags","blobs_url":"https://api.github.com/repos/ament/ament_tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ament/ament_tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ament/ament_tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/ament/ament_tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ament/ament_tools/statuses/{sha}","languages_url":"https://api.github.com/repos/ament/ament_tools/languages","stargazers_url":"https://api.github.com/repos/ament/ament_tools/stargazers","contributors_url":"https://api.github.com/repos/ament/ament_tools/contributors","subscribers_url":"https://api.github.com/repos/ament/ament_tools/subscribers","subscription_url":"https://api.github.com/repos/ament/ament_tools/subscription","commits_url":"https://api.github.com/repos/ament/ament_tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/ament/ament_tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/ament/ament_tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/ament/ament_tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/ament/ament_tools/contents/{+path}","compare_url":"https://api.github.com/repos/ament/ament_tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ament/ament_tools/merges","archive_url":"https://api.github.com/repos/ament/ament_tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ament/ament_tools/downloads","issues_url":"https://api.github.com/repos/ament/ament_tools/issues{/number}","pulls_url":"https://api.github.com/repos/ament/ament_tools/pulls{/number}","milestones_url":"https://api.github.com/repos/ament/ament_tools/milestones{/number}","notifications_url":"https://api.github.com/repos/ament/ament_tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ament/ament_tools/labels{/name}","releases_url":"https://api.github.com/repos/ament/ament_tools/releases{/id}","deployments_url":"https://api.github.com/repos/ament/ament_tools/deployments","created_at":"2014-05-19T03:13:15Z","updated_at":"2016-01-19T06:32:57Z","pushed_at":"2016-02-05T22:35:00Z","git_url":"git://github.com/ament/ament_tools.git","ssh_url":"git@github.com:ament/ament_tools.git","clone_url":"https://github.com/ament/ament_tools.git","svn_url":"https://github.com/ament/ament_tools","homepage":"","size":282,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":6,"forks":3,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"ament:master","ref":"master","sha":"8233c9c5ae4e93ebba5e5401dc13a597d45b0b39","user":{"login":"ament","id":7365061,"avatar_url":"https://avatars.githubusercontent.com/u/7365061?v=3","gravatar_id":"","url":"https://api.github.com/users/ament","html_url":"https://github.com/ament","followers_url":"https://api.github.com/users/ament/followers","following_url":"https://api.github.com/users/ament/following{/other_user}","gists_url":"https://api.github.com/users/ament/gists{/gist_id}","starred_url":"https://api.github.com/users/ament/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ament/subscriptions","organizations_url":"https://api.github.com/users/ament/orgs","repos_url":"https://api.github.com/users/ament/repos","events_url":"https://api.github.com/users/ament/events{/privacy}","received_events_url":"https://api.github.com/users/ament/received_events","type":"Organization","site_admin":false},"repo":{"id":19927831,"name":"ament_tools","full_name":"ament/ament_tools","owner":{"login":"ament","id":7365061,"avatar_url":"https://avatars.githubusercontent.com/u/7365061?v=3","gravatar_id":"","url":"https://api.github.com/users/ament","html_url":"https://github.com/ament","followers_url":"https://api.github.com/users/ament/followers","following_url":"https://api.github.com/users/ament/following{/other_user}","gists_url":"https://api.github.com/users/ament/gists{/gist_id}","starred_url":"https://api.github.com/users/ament/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ament/subscriptions","organizations_url":"https://api.github.com/users/ament/orgs","repos_url":"https://api.github.com/users/ament/repos","events_url":"https://api.github.com/users/ament/events{/privacy}","received_events_url":"https://api.github.com/users/ament/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ament/ament_tools","description":"Command line tools for working with ament","fork":false,"url":"https://api.github.com/repos/ament/ament_tools","forks_url":"https://api.github.com/repos/ament/ament_tools/forks","keys_url":"https://api.github.com/repos/ament/ament_tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ament/ament_tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ament/ament_tools/teams","hooks_url":"https://api.github.com/repos/ament/ament_tools/hooks","issue_events_url":"https://api.github.com/repos/ament/ament_tools/issues/events{/number}","events_url":"https://api.github.com/repos/ament/ament_tools/events","assignees_url":"https://api.github.com/repos/ament/ament_tools/assignees{/user}","branches_url":"https://api.github.com/repos/ament/ament_tools/branches{/branch}","tags_url":"https://api.github.com/repos/ament/ament_tools/tags","blobs_url":"https://api.github.com/repos/ament/ament_tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ament/ament_tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ament/ament_tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/ament/ament_tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ament/ament_tools/statuses/{sha}","languages_url":"https://api.github.com/repos/ament/ament_tools/languages","stargazers_url":"https://api.github.com/repos/ament/ament_tools/stargazers","contributors_url":"https://api.github.com/repos/ament/ament_tools/contributors","subscribers_url":"https://api.github.com/repos/ament/ament_tools/subscribers","subscription_url":"https://api.github.com/repos/ament/ament_tools/subscription","commits_url":"https://api.github.com/repos/ament/ament_tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/ament/ament_tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/ament/ament_tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/ament/ament_tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/ament/ament_tools/contents/{+path}","compare_url":"https://api.github.com/repos/ament/ament_tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ament/ament_tools/merges","archive_url":"https://api.github.com/repos/ament/ament_tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ament/ament_tools/downloads","issues_url":"https://api.github.com/repos/ament/ament_tools/issues{/number}","pulls_url":"https://api.github.com/repos/ament/ament_tools/pulls{/number}","milestones_url":"https://api.github.com/repos/ament/ament_tools/milestones{/number}","notifications_url":"https://api.github.com/repos/ament/ament_tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ament/ament_tools/labels{/name}","releases_url":"https://api.github.com/repos/ament/ament_tools/releases{/id}","deployments_url":"https://api.github.com/repos/ament/ament_tools/deployments","created_at":"2014-05-19T03:13:15Z","updated_at":"2016-01-19T06:32:57Z","pushed_at":"2016-02-05T22:35:00Z","git_url":"git://github.com/ament/ament_tools.git","ssh_url":"git@github.com:ament/ament_tools.git","clone_url":"https://github.com/ament/ament_tools.git","svn_url":"https://github.com/ament/ament_tools","homepage":"","size":282,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":6,"forks":3,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ament/ament_tools/pulls/75"},"html":{"href":"https://github.com/ament/ament_tools/pull/75"},"issue":{"href":"https://api.github.com/repos/ament/ament_tools/issues/75"},"comments":{"href":"https://api.github.com/repos/ament/ament_tools/issues/75/comments"},"review_comments":{"href":"https://api.github.com/repos/ament/ament_tools/pulls/75/comments"},"review_comment":{"href":"https://api.github.com/repos/ament/ament_tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ament/ament_tools/pulls/75/commits"},"statuses":{"href":"https://api.github.com/repos/ament/ament_tools/statuses/c51dad2790c1878efe7eb4c48b008441a2a76c4d"}}}}