{"action":"created","comment":{"url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/comments/57009632","id":57009632,"diff_hunk":"@@ -7578,40 +7489,55 @@ vkCmdBindDescriptorSets(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipel\n                                         DRAWSTATE_INVALID_SET, \"DS\", \"Attempt to bind DS %#\" PRIxLEAST64 \" that doesn't exist!\",\n                                         (uint64_t)pDescriptorSets[i]);\n                 }\n-            }\n-            skipCall |= addCmd(dev_data, pCB, CMD_BINDDESCRIPTORSETS, \"vkCmdBindDescrsiptorSets()\");\n-            // For any previously bound sets, need to set them to \"invalid\" if they were disturbed by this update\n-            if (firstSet > 0) { // Check set #s below the first bound set\n-                for (uint32_t i = 0; i < firstSet; ++i) {\n-                    if (pCB->boundDescriptorSets[i] &&\n-                        !verify_set_layout_compatibility(dev_data, dev_data->setMap[pCB->boundDescriptorSets[i]], layout, i,\n+                skipCall |= addCmd(dev_data, pCB, CMD_BINDDESCRIPTORSETS, \"vkCmdBindDescrsiptorSets()\");","path":"layers/core_validation.cpp","position":null,"original_position":811,"commit_id":"dc47c7da0cedb5f9626cb3cd6eec0e9c35432b1b","original_commit_id":"4b0b52388a1133fbaec0a11d7d8a57478ff02e5e","user":{"login":"tobine","id":7526739,"avatar_url":"https://avatars.githubusercontent.com/u/7526739?v=3","gravatar_id":"","url":"https://api.github.com/users/tobine","html_url":"https://github.com/tobine","followers_url":"https://api.github.com/users/tobine/followers","following_url":"https://api.github.com/users/tobine/following{/other_user}","gists_url":"https://api.github.com/users/tobine/gists{/gist_id}","starred_url":"https://api.github.com/users/tobine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobine/subscriptions","organizations_url":"https://api.github.com/users/tobine/orgs","repos_url":"https://api.github.com/users/tobine/repos","events_url":"https://api.github.com/users/tobine/events{/privacy}","received_events_url":"https://api.github.com/users/tobine/received_events","type":"User","site_admin":false},"body":"point noted. That work is orthogonal to this PR so will address later.","created_at":"2016-03-22T15:41:14Z","updated_at":"2016-03-22T15:41:14Z","html_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/163#discussion_r57009632","pull_request_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/163","_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/comments/57009632"},"html":{"href":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/163#discussion_r57009632"},"pull_request":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/163"}}},"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/163","id":63630130,"html_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/163","diff_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/163.diff","patch_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/163.patch","issue_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/163","number":163,"state":"open","locked":false,"title":"layers: Merge of cmd buffer maps in core_validation","user":{"login":"tobine","id":7526739,"avatar_url":"https://avatars.githubusercontent.com/u/7526739?v=3","gravatar_id":"","url":"https://api.github.com/users/tobine","html_url":"https://github.com/tobine","followers_url":"https://api.github.com/users/tobine/followers","following_url":"https://api.github.com/users/tobine/following{/other_user}","gists_url":"https://api.github.com/users/tobine/gists{/gist_id}","starred_url":"https://api.github.com/users/tobine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobine/subscriptions","organizations_url":"https://api.github.com/users/tobine/orgs","repos_url":"https://api.github.com/users/tobine/repos","events_url":"https://api.github.com/users/tobine/events{/privacy}","received_events_url":"https://api.github.com/users/tobine/received_events","type":"User","site_admin":false},"body":"This is the first step in killing cbMap from mem_tracker and merging\r\nall cmd buffer tracking into commandBufferMap.\r\nThis removes all cbMap references, merges some data between the two maps\r\nas appropriate, and replicates some of the mem_tracker data into the\r\nGLOBAL_CB_NODE struct.\r\nThere is still some work to be done here in order to remove some of\r\nthe replicated data and improve some algorithms that use the\r\ncommandBufferMap to avoid duplicate efforts.","created_at":"2016-03-21T20:50:54Z","updated_at":"2016-03-22T15:41:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1e41ed022e651fa4ded9bb0f22c49c8c7597a95","assignee":{"login":"lentinem","id":9709345,"avatar_url":"https://avatars.githubusercontent.com/u/9709345?v=3","gravatar_id":"","url":"https://api.github.com/users/lentinem","html_url":"https://github.com/lentinem","followers_url":"https://api.github.com/users/lentinem/followers","following_url":"https://api.github.com/users/lentinem/following{/other_user}","gists_url":"https://api.github.com/users/lentinem/gists{/gist_id}","starred_url":"https://api.github.com/users/lentinem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lentinem/subscriptions","organizations_url":"https://api.github.com/users/lentinem/orgs","repos_url":"https://api.github.com/users/lentinem/repos","events_url":"https://api.github.com/users/lentinem/events{/privacy}","received_events_url":"https://api.github.com/users/lentinem/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/163/commits","review_comments_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/163/comments","review_comment_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/163/comments","statuses_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/statuses/dc47c7da0cedb5f9626cb3cd6eec0e9c35432b1b","head":{"label":"KhronosGroup:tobin_cv_cmd_buffer_map_merge","ref":"tobin_cv_cmd_buffer_map_merge","sha":"dc47c7da0cedb5f9626cb3cd6eec0e9c35432b1b","user":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":51507157,"name":"Vulkan-LoaderAndValidationLayers","full_name":"KhronosGroup/Vulkan-LoaderAndValidationLayers","owner":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers","description":"Vulkan loader and validation layers","fork":false,"url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers","forks_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/forks","keys_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/events","assignees_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/merges","archive_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/releases{/id}","deployments_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/deployments","created_at":"2016-02-11T10:16:16Z","updated_at":"2016-03-22T02:12:24Z","pushed_at":"2016-03-22T15:37:58Z","git_url":"git://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers.git","ssh_url":"git@github.com:KhronosGroup/Vulkan-LoaderAndValidationLayers.git","clone_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers.git","svn_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers","homepage":null,"size":45747,"stargazers_count":148,"watchers_count":148,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":43,"forks":37,"open_issues":43,"watchers":148,"default_branch":"master"}},"base":{"label":"KhronosGroup:master","ref":"master","sha":"bd5496d31a8dfa707a969b5c6724f5ed89e491bc","user":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":51507157,"name":"Vulkan-LoaderAndValidationLayers","full_name":"KhronosGroup/Vulkan-LoaderAndValidationLayers","owner":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers","description":"Vulkan loader and validation layers","fork":false,"url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers","forks_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/forks","keys_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/events","assignees_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/merges","archive_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/releases{/id}","deployments_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/deployments","created_at":"2016-02-11T10:16:16Z","updated_at":"2016-03-22T02:12:24Z","pushed_at":"2016-03-22T15:37:58Z","git_url":"git://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers.git","ssh_url":"git@github.com:KhronosGroup/Vulkan-LoaderAndValidationLayers.git","clone_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers.git","svn_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers","homepage":null,"size":45747,"stargazers_count":148,"watchers_count":148,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":43,"forks":37,"open_issues":43,"watchers":148,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/163"},"html":{"href":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/163"},"issue":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/163"},"comments":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/163/comments"},"review_comments":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/163/comments"},"review_comment":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/163/commits"},"statuses":{"href":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/statuses/dc47c7da0cedb5f9626cb3cd6eec0e9c35432b1b"}}}}