{"action":"created","issue":{"url":"https://api.github.com/repos/rgbkrk/libvirt-go/issues/97","repository_url":"https://api.github.com/repos/rgbkrk/libvirt-go","labels_url":"https://api.github.com/repos/rgbkrk/libvirt-go/issues/97/labels{/name}","comments_url":"https://api.github.com/repos/rgbkrk/libvirt-go/issues/97/comments","events_url":"https://api.github.com/repos/rgbkrk/libvirt-go/issues/97/events","html_url":"https://github.com/rgbkrk/libvirt-go/pull/97","id":167678189,"number":97,"title":"ci: replace drone.io tests by Travis CI","user":{"login":"vincentbernat","id":631446,"avatar_url":"https://avatars.githubusercontent.com/u/631446?v=3","gravatar_id":"","url":"https://api.github.com/users/vincentbernat","html_url":"https://github.com/vincentbernat","followers_url":"https://api.github.com/users/vincentbernat/followers","following_url":"https://api.github.com/users/vincentbernat/following{/other_user}","gists_url":"https://api.github.com/users/vincentbernat/gists{/gist_id}","starred_url":"https://api.github.com/users/vincentbernat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vincentbernat/subscriptions","organizations_url":"https://api.github.com/users/vincentbernat/orgs","repos_url":"https://api.github.com/users/vincentbernat/repos","events_url":"https://api.github.com/users/vincentbernat/events{/privacy}","received_events_url":"https://api.github.com/users/vincentbernat/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-07-26T18:30:22Z","updated_at":"2016-07-27T07:03:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rgbkrk/libvirt-go/pulls/97","html_url":"https://github.com/rgbkrk/libvirt-go/pull/97","diff_url":"https://github.com/rgbkrk/libvirt-go/pull/97.diff","patch_url":"https://github.com/rgbkrk/libvirt-go/pull/97.patch"},"body":"Not to be merged yet, not tested!"},"comment":{"url":"https://api.github.com/repos/rgbkrk/libvirt-go/issues/comments/235503597","html_url":"https://github.com/rgbkrk/libvirt-go/pull/97#issuecomment-235503597","issue_url":"https://api.github.com/repos/rgbkrk/libvirt-go/issues/97","id":235503597,"user":{"login":"vincentbernat","id":631446,"avatar_url":"https://avatars.githubusercontent.com/u/631446?v=3","gravatar_id":"","url":"https://api.github.com/users/vincentbernat","html_url":"https://github.com/vincentbernat","followers_url":"https://api.github.com/users/vincentbernat/followers","following_url":"https://api.github.com/users/vincentbernat/following{/other_user}","gists_url":"https://api.github.com/users/vincentbernat/gists{/gist_id}","starred_url":"https://api.github.com/users/vincentbernat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vincentbernat/subscriptions","organizations_url":"https://api.github.com/users/vincentbernat/orgs","repos_url":"https://api.github.com/users/vincentbernat/repos","events_url":"https://api.github.com/users/vincentbernat/events{/privacy}","received_events_url":"https://api.github.com/users/vincentbernat/received_events","type":"User","site_admin":false},"created_at":"2016-07-27T07:03:46Z","updated_at":"2016-07-27T07:03:46Z","body":"Ok, so libvirt is now compiled from source. Tests are done for Go 1.5 and Go 1.6. libvirt 1.2.2 and 1.2.14 are tested. And I have added a commit to make the conditional compilation like I described above.\r\n\r\nA project needing features from libvirt 1.2.14 should build with `-tags libvirt.1.2.14`. Only a few tags are valid (currently one) to not have too long `// +build` lines. But let's suppose we want to add feature `virDomanRename` from libvirt 1.2.19, we would add the tag `libvirt.1.2.19` and a user wanting this feature would build with `-tags libvirt.1.2.19`, we would add a `domain_1.2.19.go` file with`// +build libvirt.1.2.19` and the `domain_1.2.14.go` file would get `// +build libvirt.1.2.14 libvirt.1.2.19`.\r\n\r\nWe can of course only keep the first commit and I can do a PR for the second one."}}
{"actor":{"display_login":"vincentbernat"}}