{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/comments/78237232","id":78237232,"diff_hunk":"@@ -31,6 +31,11 @@ def test__lookup_virtual(self):\n         with self.assertRaises(NotImplementedError):\n             api_base._lookup(None, None)\n \n+    def test__run_query_virtual(self):\n+        api_base = self._makeOne()\n+        with self.assertRaises(NotImplementedError):\n+            api_base._run_query(None, None)\n+","path":"unit_tests/datastore/test__api.py","position":38,"original_position":8,"commit_id":"500ae929a6e747edea7b3ac2bbf500087784f8cb","original_commit_id":"e7f7aa4f8075666487ca793f9d87d983e1b0b4be","user":{"login":"tseaver","id":242750,"avatar_url":"https://avatars.githubusercontent.com/u/242750?v=3","gravatar_id":"","url":"https://api.github.com/users/tseaver","html_url":"https://github.com/tseaver","followers_url":"https://api.github.com/users/tseaver/followers","following_url":"https://api.github.com/users/tseaver/following{/other_user}","gists_url":"https://api.github.com/users/tseaver/gists{/gist_id}","starred_url":"https://api.github.com/users/tseaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tseaver/subscriptions","organizations_url":"https://api.github.com/users/tseaver/orgs","repos_url":"https://api.github.com/users/tseaver/repos","events_url":"https://api.github.com/users/tseaver/events{/privacy}","received_events_url":"https://api.github.com/users/tseaver/received_events","type":"User","site_admin":false},"body":"Don't we need to test the base class's version of `run_query` here?","created_at":"2016-09-09T19:40:41Z","updated_at":"2016-09-09T19:40:41Z","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/2287#discussion_r78237232","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/2287","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/comments/78237232"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/2287#discussion_r78237232"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/2287"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/2287","id":84697077,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/2287","diff_url":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/2287.diff","patch_url":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/2287.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/2287","number":2287,"state":"open","locked":false,"title":"Refactor datastore connection: move behavior into API objects","user":{"login":"dhermes","id":520669,"avatar_url":"https://avatars.githubusercontent.com/u/520669?v=3","gravatar_id":"","url":"https://api.github.com/users/dhermes","html_url":"https://github.com/dhermes","followers_url":"https://api.github.com/users/dhermes/followers","following_url":"https://api.github.com/users/dhermes/following{/other_user}","gists_url":"https://api.github.com/users/dhermes/gists{/gist_id}","starred_url":"https://api.github.com/users/dhermes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhermes/subscriptions","organizations_url":"https://api.github.com/users/dhermes/orgs","repos_url":"https://api.github.com/users/dhermes/repos","events_url":"https://api.github.com/users/dhermes/events{/privacy}","received_events_url":"https://api.github.com/users/dhermes/received_events","type":"User","site_admin":false},"body":"@tseaver This is what we discussed in #2230. LMKWYT. This way we can just ditch `google.cloud.client.Client` (for `_ClientFactoryMixin`) and remove the `connection` module. Right now, the only real logic in the `Connection` class is in the constructor.","created_at":"2016-09-09T18:32:31Z","updated_at":"2016-09-09T19:40:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f47d5ea7681d87ca4371d05f422333b629f7a5b","assignee":{"login":"tseaver","id":242750,"avatar_url":"https://avatars.githubusercontent.com/u/242750?v=3","gravatar_id":"","url":"https://api.github.com/users/tseaver","html_url":"https://github.com/tseaver","followers_url":"https://api.github.com/users/tseaver/followers","following_url":"https://api.github.com/users/tseaver/following{/other_user}","gists_url":"https://api.github.com/users/tseaver/gists{/gist_id}","starred_url":"https://api.github.com/users/tseaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tseaver/subscriptions","organizations_url":"https://api.github.com/users/tseaver/orgs","repos_url":"https://api.github.com/users/tseaver/repos","events_url":"https://api.github.com/users/tseaver/events{/privacy}","received_events_url":"https://api.github.com/users/tseaver/received_events","type":"User","site_admin":false},"assignees":[{"login":"tseaver","id":242750,"avatar_url":"https://avatars.githubusercontent.com/u/242750?v=3","gravatar_id":"","url":"https://api.github.com/users/tseaver","html_url":"https://github.com/tseaver","followers_url":"https://api.github.com/users/tseaver/followers","following_url":"https://api.github.com/users/tseaver/following{/other_user}","gists_url":"https://api.github.com/users/tseaver/gists{/gist_id}","starred_url":"https://api.github.com/users/tseaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tseaver/subscriptions","organizations_url":"https://api.github.com/users/tseaver/orgs","repos_url":"https://api.github.com/users/tseaver/repos","events_url":"https://api.github.com/users/tseaver/events{/privacy}","received_events_url":"https://api.github.com/users/tseaver/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/2287/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/2287/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/2287/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/statuses/500ae929a6e747edea7b3ac2bbf500087784f8cb","head":{"label":"dhermes:refactor-ds-cnxn","ref":"refactor-ds-cnxn","sha":"500ae929a6e747edea7b3ac2bbf500087784f8cb","user":{"login":"dhermes","id":520669,"avatar_url":"https://avatars.githubusercontent.com/u/520669?v=3","gravatar_id":"","url":"https://api.github.com/users/dhermes","html_url":"https://github.com/dhermes","followers_url":"https://api.github.com/users/dhermes/followers","following_url":"https://api.github.com/users/dhermes/following{/other_user}","gists_url":"https://api.github.com/users/dhermes/gists{/gist_id}","starred_url":"https://api.github.com/users/dhermes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhermes/subscriptions","organizations_url":"https://api.github.com/users/dhermes/orgs","repos_url":"https://api.github.com/users/dhermes/repos","events_url":"https://api.github.com/users/dhermes/events{/privacy}","received_events_url":"https://api.github.com/users/dhermes/received_events","type":"User","site_admin":false},"repo":{"id":23001795,"name":"google-cloud-python","full_name":"dhermes/google-cloud-python","owner":{"login":"dhermes","id":520669,"avatar_url":"https://avatars.githubusercontent.com/u/520669?v=3","gravatar_id":"","url":"https://api.github.com/users/dhermes","html_url":"https://github.com/dhermes","followers_url":"https://api.github.com/users/dhermes/followers","following_url":"https://api.github.com/users/dhermes/following{/other_user}","gists_url":"https://api.github.com/users/dhermes/gists{/gist_id}","starred_url":"https://api.github.com/users/dhermes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhermes/subscriptions","organizations_url":"https://api.github.com/users/dhermes/orgs","repos_url":"https://api.github.com/users/dhermes/repos","events_url":"https://api.github.com/users/dhermes/events{/privacy}","received_events_url":"https://api.github.com/users/dhermes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dhermes/google-cloud-python","description":"Google Cloud Python Client Library","fork":true,"url":"https://api.github.com/repos/dhermes/google-cloud-python","forks_url":"https://api.github.com/repos/dhermes/google-cloud-python/forks","keys_url":"https://api.github.com/repos/dhermes/google-cloud-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhermes/google-cloud-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhermes/google-cloud-python/teams","hooks_url":"https://api.github.com/repos/dhermes/google-cloud-python/hooks","issue_events_url":"https://api.github.com/repos/dhermes/google-cloud-python/issues/events{/number}","events_url":"https://api.github.com/repos/dhermes/google-cloud-python/events","assignees_url":"https://api.github.com/repos/dhermes/google-cloud-python/assignees{/user}","branches_url":"https://api.github.com/repos/dhermes/google-cloud-python/branches{/branch}","tags_url":"https://api.github.com/repos/dhermes/google-cloud-python/tags","blobs_url":"https://api.github.com/repos/dhermes/google-cloud-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhermes/google-cloud-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhermes/google-cloud-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhermes/google-cloud-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhermes/google-cloud-python/statuses/{sha}","languages_url":"https://api.github.com/repos/dhermes/google-cloud-python/languages","stargazers_url":"https://api.github.com/repos/dhermes/google-cloud-python/stargazers","contributors_url":"https://api.github.com/repos/dhermes/google-cloud-python/contributors","subscribers_url":"https://api.github.com/repos/dhermes/google-cloud-python/subscribers","subscription_url":"https://api.github.com/repos/dhermes/google-cloud-python/subscription","commits_url":"https://api.github.com/repos/dhermes/google-cloud-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhermes/google-cloud-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhermes/google-cloud-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhermes/google-cloud-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/dhermes/google-cloud-python/contents/{+path}","compare_url":"https://api.github.com/repos/dhermes/google-cloud-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhermes/google-cloud-python/merges","archive_url":"https://api.github.com/repos/dhermes/google-cloud-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhermes/google-cloud-python/downloads","issues_url":"https://api.github.com/repos/dhermes/google-cloud-python/issues{/number}","pulls_url":"https://api.github.com/repos/dhermes/google-cloud-python/pulls{/number}","milestones_url":"https://api.github.com/repos/dhermes/google-cloud-python/milestones{/number}","notifications_url":"https://api.github.com/repos/dhermes/google-cloud-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhermes/google-cloud-python/labels{/name}","releases_url":"https://api.github.com/repos/dhermes/google-cloud-python/releases{/id}","deployments_url":"https://api.github.com/repos/dhermes/google-cloud-python/deployments","created_at":"2014-08-15T20:18:30Z","updated_at":"2016-09-09T01:44:03Z","pushed_at":"2016-09-09T19:09:01Z","git_url":"git://github.com/dhermes/google-cloud-python.git","ssh_url":"git@github.com:dhermes/google-cloud-python.git","clone_url":"https://github.com/dhermes/google-cloud-python.git","svn_url":"https://github.com/dhermes/google-cloud-python","homepage":"http://googlecloudplatform.github.io/gcloud-python/","size":13319,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"6b42be945920e8b9a888c468cbb81b69ea73f731","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":16316451,"name":"google-cloud-python","full_name":"GoogleCloudPlatform/google-cloud-python","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-python","description":"Google Cloud Client Library for Python","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/deployments","created_at":"2014-01-28T15:51:47Z","updated_at":"2016-09-09T16:19:29Z","pushed_at":"2016-09-09T19:09:02Z","git_url":"git://github.com/GoogleCloudPlatform/google-cloud-python.git","ssh_url":"git@github.com:GoogleCloudPlatform/google-cloud-python.git","clone_url":"https://github.com/GoogleCloudPlatform/google-cloud-python.git","svn_url":"https://github.com/GoogleCloudPlatform/google-cloud-python","homepage":"https://googlecloudplatform.github.io/gcloud-python/","size":77383,"stargazers_count":391,"watchers_count":391,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":199,"mirror_url":null,"open_issues_count":195,"forks":199,"open_issues":195,"watchers":391,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/2287"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/2287"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/2287"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/2287/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/2287/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/2287/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/statuses/500ae929a6e747edea7b3ac2bbf500087784f8cb"}}}}
{"actor":{"display_login":"tseaver"}}