{"action":"created","comment":{"url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/pulls/comments/89464954","pull_request_review_id":10009829,"id":89464954,"diff_hunk":"@@ -0,0 +1,70 @@\n+---------------------------------------------------------------------------------------------\n+-- Requirement summary:\n+--     [ChangeRegistration]: appRevoked:true\n+-- Description:\n+-- <appID> application is assigned with specific policies (for example, appID = 123abc->\n+-- \"app_policies\" -> \"123abc\" : { <specific policies> }\n+-- Steps:\n+-- 1. any PolicyTableUpdate trigger happens\n+-- 2. PTU is valid -> <appID> gets \"null\" policy\n+-- Expected:\n+-- SDL -> HMI: OnAppPermissionChanged (<appID>, appRevoked=true, params)\n+--\n+-- Test:\n+--     1. Preconditions:\n+--        Start SDL\n+--\n+--     2. Steps\n+--        Register application with policy id 123abc\n+--        Perform PTU with structure \"123abc\": null\n+--\n+--     3. Expected result:\n+--        SDL -> HMI: OnAppPermissionChanged (<appID>, appRevoked=true, params)\n+--\n+---------------------------------------------------------------------------------------------\n+\n+--[[ General configuration parameters ]]\n+  config.deviceMAC = \"12ca17b49af2289436f303e0166030a21e525d266e209267433801a8fd4071a0\"\n+\n+--[[ Required Shared libraries ]]\n+  local Common = require(\"user_modules/shared_testcases/testCasesForPolicyAppIdManagament\")\n+\n+--[[ General Settings for configuration ]]\n+  Test = require(\"connecttest\")\n+  local mobile_session = require(\"mobile_session\")\n+\n+  function Test:Pre_StartNewSession()\n+    self.mobileSession2 = mobile_session.MobileSession(self, self.mobileConnection)\n+    self.mobileSession2:StartService(7)\n+  end\n+\n+--[[ Test ]]\n+  function Test:RegisterNewApp_PerformPTU_Check_OnAppPermissionChanged()\n+    local registerAppInterfaceParams =\n+      {\n+        syncMsgVersion =\n+        {\n+          majorVersion = 3,\n+          minorVersion = 0\n+        },\n+        appName = \"App1\",\n+        isMediaApplication = true,\n+        languageDesired = 'EN-US',\n+        hmiDisplayLanguageDesired = 'EN-US',\n+        appHMIType = { \"NAVIGATION\" },\n+        appID = \"123abc\",\n+        deviceInfo =\n+        {\n+          os = \"Android\",\n+          carrier = \"Megafon\",\n+          firmwareRev = \"Name: Linux, Version: 3.4.0-perf\",\n+          osVersion = \"4.4.2\",\n+          maxNumberRFCOMMPorts = 1\n+        }\n+      }\n+\n+    self.mobileSession2:SendRPC(\"RegisterAppInterface\", registerAppInterfaceParams)\n+    Common:update_policy_table(self, \"files/jsons/Policies/appID_Management/ptu_23511.json\")\n+    EXPECT_HMINOTIFICATION(\"SDL.OnAppPermissionChanged\", { appRevoked = true })\n+  end","path":"test_scripts/Polices/appID_Management/ATF_P_TC_OnAppPermissionChanged_appRevoked_true.lua","position":null,"original_position":69,"commit_id":"eec995ac3d1206f0bda26353c26371517852b1b7","original_commit_id":"86287b099145162e2364d46078292d0fab49486f","user":{"login":"dtrunov","id":11158877,"avatar_url":"https://avatars.githubusercontent.com/u/11158877?v=3","gravatar_id":"","url":"https://api.github.com/users/dtrunov","html_url":"https://github.com/dtrunov","followers_url":"https://api.github.com/users/dtrunov/followers","following_url":"https://api.github.com/users/dtrunov/following{/other_user}","gists_url":"https://api.github.com/users/dtrunov/gists{/gist_id}","starred_url":"https://api.github.com/users/dtrunov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtrunov/subscriptions","organizations_url":"https://api.github.com/users/dtrunov/orgs","repos_url":"https://api.github.com/users/dtrunov/repos","events_url":"https://api.github.com/users/dtrunov/events{/privacy}","received_events_url":"https://api.github.com/users/dtrunov/received_events","type":"User","site_admin":false},"body":"@maria-mih Fixed with commit eec995a","created_at":"2016-11-24T09:55:50Z","updated_at":"2016-11-24T09:55:50Z","html_url":"https://github.com/smartdevicelink/sdl_atf_test_scripts/pull/91#discussion_r89464954","pull_request_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/pulls/91","_links":{"self":{"href":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/pulls/comments/89464954"},"html":{"href":"https://github.com/smartdevicelink/sdl_atf_test_scripts/pull/91#discussion_r89464954"},"pull_request":{"href":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/pulls/91"}}},"pull_request":{"url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/pulls/91","id":94614314,"html_url":"https://github.com/smartdevicelink/sdl_atf_test_scripts/pull/91","diff_url":"https://github.com/smartdevicelink/sdl_atf_test_scripts/pull/91.diff","patch_url":"https://github.com/smartdevicelink/sdl_atf_test_scripts/pull/91.patch","issue_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/issues/91","number":91,"state":"open","locked":false,"title":"Feature/check on app permision changed with app revoked true after ptu","user":{"login":"dtrunov","id":11158877,"avatar_url":"https://avatars.githubusercontent.com/u/11158877?v=3","gravatar_id":"","url":"https://api.github.com/users/dtrunov","html_url":"https://github.com/dtrunov","followers_url":"https://api.github.com/users/dtrunov/followers","following_url":"https://api.github.com/users/dtrunov/following{/other_user}","gists_url":"https://api.github.com/users/dtrunov/gists{/gist_id}","starred_url":"https://api.github.com/users/dtrunov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtrunov/subscriptions","organizations_url":"https://api.github.com/users/dtrunov/orgs","repos_url":"https://api.github.com/users/dtrunov/repos","events_url":"https://api.github.com/users/dtrunov/events{/privacy}","received_events_url":"https://api.github.com/users/dtrunov/received_events","type":"User","site_admin":false},"body":"Add script that check sending notification to HMI OnAppPermisionChanged with appRevoked true after PTU","created_at":"2016-11-21T13:24:16Z","updated_at":"2016-11-24T09:55:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40c86b4a283053fb8e2b48e85d98543c3670cf9b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/pulls/91/commits","review_comments_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/pulls/91/comments","review_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/issues/91/comments","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/statuses/eec995ac3d1206f0bda26353c26371517852b1b7","head":{"label":"dtrunov:feature/Check_OnAppPermisionChanged_with_appRevoked_true_afterPTU","ref":"feature/Check_OnAppPermisionChanged_with_appRevoked_true_afterPTU","sha":"eec995ac3d1206f0bda26353c26371517852b1b7","user":{"login":"dtrunov","id":11158877,"avatar_url":"https://avatars.githubusercontent.com/u/11158877?v=3","gravatar_id":"","url":"https://api.github.com/users/dtrunov","html_url":"https://github.com/dtrunov","followers_url":"https://api.github.com/users/dtrunov/followers","following_url":"https://api.github.com/users/dtrunov/following{/other_user}","gists_url":"https://api.github.com/users/dtrunov/gists{/gist_id}","starred_url":"https://api.github.com/users/dtrunov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtrunov/subscriptions","organizations_url":"https://api.github.com/users/dtrunov/orgs","repos_url":"https://api.github.com/users/dtrunov/repos","events_url":"https://api.github.com/users/dtrunov/events{/privacy}","received_events_url":"https://api.github.com/users/dtrunov/received_events","type":"User","site_admin":false},"repo":{"id":74130143,"name":"sdl_atf_test_scripts","full_name":"dtrunov/sdl_atf_test_scripts","owner":{"login":"dtrunov","id":11158877,"avatar_url":"https://avatars.githubusercontent.com/u/11158877?v=3","gravatar_id":"","url":"https://api.github.com/users/dtrunov","html_url":"https://github.com/dtrunov","followers_url":"https://api.github.com/users/dtrunov/followers","following_url":"https://api.github.com/users/dtrunov/following{/other_user}","gists_url":"https://api.github.com/users/dtrunov/gists{/gist_id}","starred_url":"https://api.github.com/users/dtrunov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtrunov/subscriptions","organizations_url":"https://api.github.com/users/dtrunov/orgs","repos_url":"https://api.github.com/users/dtrunov/repos","events_url":"https://api.github.com/users/dtrunov/events{/privacy}","received_events_url":"https://api.github.com/users/dtrunov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dtrunov/sdl_atf_test_scripts","description":"Test scripts for sdl_atf","fork":true,"url":"https://api.github.com/repos/dtrunov/sdl_atf_test_scripts","forks_url":"https://api.github.com/repos/dtrunov/sdl_atf_test_scripts/forks","keys_url":"https://api.github.com/repos/dtrunov/sdl_atf_test_scripts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dtrunov/sdl_atf_test_scripts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dtrunov/sdl_atf_test_scripts/teams","hooks_url":"https://api.github.com/repos/dtrunov/sdl_atf_test_scripts/hooks","issue_events_url":"https://api.github.com/repos/dtrunov/sdl_atf_test_scripts/issues/events{/number}","events_url":"https://api.github.com/repos/dtrunov/sdl_atf_test_scripts/events","assignees_url":"https://api.github.com/repos/dtrunov/sdl_atf_test_scripts/assignees{/user}","branches_url":"https://api.github.com/repos/dtrunov/sdl_atf_test_scripts/branches{/branch}","tags_url":"https://api.github.com/repos/dtrunov/sdl_atf_test_scripts/tags","blobs_url":"https://api.github.com/repos/dtrunov/sdl_atf_test_scripts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dtrunov/sdl_atf_test_scripts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dtrunov/sdl_atf_test_scripts/git/refs{/sha}","trees_url":"https://api.github.com/repos/dtrunov/sdl_atf_test_scripts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dtrunov/sdl_atf_test_scripts/statuses/{sha}","languages_url":"https://api.github.com/repos/dtrunov/sdl_atf_test_scripts/languages","stargazers_url":"https://api.github.com/repos/dtrunov/sdl_atf_test_scripts/stargazers","contributors_url":"https://api.github.com/repos/dtrunov/sdl_atf_test_scripts/contributors","subscribers_url":"https://api.github.com/repos/dtrunov/sdl_atf_test_scripts/subscribers","subscription_url":"https://api.github.com/repos/dtrunov/sdl_atf_test_scripts/subscription","commits_url":"https://api.github.com/repos/dtrunov/sdl_atf_test_scripts/commits{/sha}","git_commits_url":"https://api.github.com/repos/dtrunov/sdl_atf_test_scripts/git/commits{/sha}","comments_url":"https://api.github.com/repos/dtrunov/sdl_atf_test_scripts/comments{/number}","issue_comment_url":"https://api.github.com/repos/dtrunov/sdl_atf_test_scripts/issues/comments{/number}","contents_url":"https://api.github.com/repos/dtrunov/sdl_atf_test_scripts/contents/{+path}","compare_url":"https://api.github.com/repos/dtrunov/sdl_atf_test_scripts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dtrunov/sdl_atf_test_scripts/merges","archive_url":"https://api.github.com/repos/dtrunov/sdl_atf_test_scripts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dtrunov/sdl_atf_test_scripts/downloads","issues_url":"https://api.github.com/repos/dtrunov/sdl_atf_test_scripts/issues{/number}","pulls_url":"https://api.github.com/repos/dtrunov/sdl_atf_test_scripts/pulls{/number}","milestones_url":"https://api.github.com/repos/dtrunov/sdl_atf_test_scripts/milestones{/number}","notifications_url":"https://api.github.com/repos/dtrunov/sdl_atf_test_scripts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dtrunov/sdl_atf_test_scripts/labels{/name}","releases_url":"https://api.github.com/repos/dtrunov/sdl_atf_test_scripts/releases{/id}","deployments_url":"https://api.github.com/repos/dtrunov/sdl_atf_test_scripts/deployments","created_at":"2016-11-18T13:02:43Z","updated_at":"2016-11-18T13:02:46Z","pushed_at":"2016-11-24T09:35:58Z","git_url":"git://github.com/dtrunov/sdl_atf_test_scripts.git","ssh_url":"git@github.com:dtrunov/sdl_atf_test_scripts.git","clone_url":"https://github.com/dtrunov/sdl_atf_test_scripts.git","svn_url":"https://github.com/dtrunov/sdl_atf_test_scripts","homepage":null,"size":18118,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"smartdevicelink:develop","ref":"develop","sha":"091d905fc8a12a16b56eafafdf08caf0ebc4fd86","user":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars.githubusercontent.com/u/8671397?v=3","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"repo":{"id":53459525,"name":"sdl_atf_test_scripts","full_name":"smartdevicelink/sdl_atf_test_scripts","owner":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars.githubusercontent.com/u/8671397?v=3","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smartdevicelink/sdl_atf_test_scripts","description":"Test scripts for sdl_atf","fork":false,"url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts","forks_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/forks","keys_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/teams","hooks_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/hooks","issue_events_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/issues/events{/number}","events_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/events","assignees_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/assignees{/user}","branches_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/branches{/branch}","tags_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/tags","blobs_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/statuses/{sha}","languages_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/languages","stargazers_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/stargazers","contributors_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/contributors","subscribers_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/subscribers","subscription_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/subscription","commits_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/contents/{+path}","compare_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/merges","archive_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/downloads","issues_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/issues{/number}","pulls_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/pulls{/number}","milestones_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/milestones{/number}","notifications_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/labels{/name}","releases_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/releases{/id}","deployments_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/deployments","created_at":"2016-03-09T01:53:02Z","updated_at":"2016-04-27T09:25:04Z","pushed_at":"2016-11-24T09:35:59Z","git_url":"git://github.com/smartdevicelink/sdl_atf_test_scripts.git","ssh_url":"git@github.com:smartdevicelink/sdl_atf_test_scripts.git","clone_url":"https://github.com/smartdevicelink/sdl_atf_test_scripts.git","svn_url":"https://github.com/smartdevicelink/sdl_atf_test_scripts","homepage":null,"size":18960,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":94,"forks":20,"open_issues":94,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/pulls/91"},"html":{"href":"https://github.com/smartdevicelink/sdl_atf_test_scripts/pull/91"},"issue":{"href":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/issues/91"},"comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/issues/91/comments"},"review_comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/pulls/91/comments"},"review_comment":{"href":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/pulls/91/commits"},"statuses":{"href":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/statuses/eec995ac3d1206f0bda26353c26371517852b1b7"}}}}
{"actor":{"display_login":"dtrunov"}}