{"action":"created","issue":{"url":"https://api.github.com/repos/Metaswitch/cpp-common/issues/546","repository_url":"https://api.github.com/repos/Metaswitch/cpp-common","labels_url":"https://api.github.com/repos/Metaswitch/cpp-common/issues/546/labels{/name}","comments_url":"https://api.github.com/repos/Metaswitch/cpp-common/issues/546/comments","events_url":"https://api.github.com/repos/Metaswitch/cpp-common/issues/546/events","html_url":"https://github.com/Metaswitch/cpp-common/pull/546","id":171626198,"number":546,"title":"[Reviewer: AJH] Add HTTP Connection Pooling to MemcachedStore","user":{"login":"TJW2","id":20281378,"avatar_url":"https://avatars.githubusercontent.com/u/20281378?v=3","gravatar_id":"","url":"https://api.github.com/users/TJW2","html_url":"https://github.com/TJW2","followers_url":"https://api.github.com/users/TJW2/followers","following_url":"https://api.github.com/users/TJW2/following{/other_user}","gists_url":"https://api.github.com/users/TJW2/gists{/gist_id}","starred_url":"https://api.github.com/users/TJW2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TJW2/subscriptions","organizations_url":"https://api.github.com/users/TJW2/orgs","repos_url":"https://api.github.com/users/TJW2/repos","events_url":"https://api.github.com/users/TJW2/events{/privacy}","received_events_url":"https://api.github.com/users/TJW2/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"AlexHockey","id":4903205,"avatar_url":"https://avatars.githubusercontent.com/u/4903205?v=3","gravatar_id":"","url":"https://api.github.com/users/AlexHockey","html_url":"https://github.com/AlexHockey","followers_url":"https://api.github.com/users/AlexHockey/followers","following_url":"https://api.github.com/users/AlexHockey/following{/other_user}","gists_url":"https://api.github.com/users/AlexHockey/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexHockey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexHockey/subscriptions","organizations_url":"https://api.github.com/users/AlexHockey/orgs","repos_url":"https://api.github.com/users/AlexHockey/repos","events_url":"https://api.github.com/users/AlexHockey/events{/privacy}","received_events_url":"https://api.github.com/users/AlexHockey/received_events","type":"User","site_admin":false},"assignees":[{"login":"AlexHockey","id":4903205,"avatar_url":"https://avatars.githubusercontent.com/u/4903205?v=3","gravatar_id":"","url":"https://api.github.com/users/AlexHockey","html_url":"https://github.com/AlexHockey","followers_url":"https://api.github.com/users/AlexHockey/followers","following_url":"https://api.github.com/users/AlexHockey/following{/other_user}","gists_url":"https://api.github.com/users/AlexHockey/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexHockey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexHockey/subscriptions","organizations_url":"https://api.github.com/users/AlexHockey/orgs","repos_url":"https://api.github.com/users/AlexHockey/repos","events_url":"https://api.github.com/users/AlexHockey/events{/privacy}","received_events_url":"https://api.github.com/users/AlexHockey/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-08-17T10:36:48Z","updated_at":"2016-08-17T13:34:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Metaswitch/cpp-common/pulls/546","html_url":"https://github.com/Metaswitch/cpp-common/pull/546","diff_url":"https://github.com/Metaswitch/cpp-common/pull/546.diff","patch_url":"https://github.com/Metaswitch/cpp-common/pull/546.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/Metaswitch/cpp-common/issues/comments/240412325","html_url":"https://github.com/Metaswitch/cpp-common/pull/546#issuecomment-240412325","issue_url":"https://api.github.com/repos/Metaswitch/cpp-common/issues/546","id":240412325,"user":{"login":"AlexHockey","id":4903205,"avatar_url":"https://avatars.githubusercontent.com/u/4903205?v=3","gravatar_id":"","url":"https://api.github.com/users/AlexHockey","html_url":"https://github.com/AlexHockey","followers_url":"https://api.github.com/users/AlexHockey/followers","following_url":"https://api.github.com/users/AlexHockey/following{/other_user}","gists_url":"https://api.github.com/users/AlexHockey/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexHockey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexHockey/subscriptions","organizations_url":"https://api.github.com/users/AlexHockey/orgs","repos_url":"https://api.github.com/users/AlexHockey/repos","events_url":"https://api.github.com/users/AlexHockey/events{/privacy}","received_events_url":"https://api.github.com/users/AlexHockey/received_events","type":"User","site_admin":false},"created_at":"2016-08-17T13:34:51Z","updated_at":"2016-08-17T13:34:51Z","body":"This looks really good. Well done. I've put some comments inline but most were cosmetic. \r\n\r\nA couple of high level things:\r\n\r\n* When you make a pull request, could you put some detail in the description (containing what the PR is for, what testing you've done, and any other useful information). We sometimes go back to old PRs to figure out why a change was made, and this information is handy. \r\n* It's good to try and identify where you're doing something weird (or not doing something expected), and add a comment to satisfy the reader. For example when your connection pool destructor didn't free any objects. "}}
{"actor":{"display_login":"AlexHockey"}}