{"action":"created","comment":{"url":"https://api.github.com/repos/interledger/rfcs/pulls/comments/90990928","pull_request_review_id":11503238,"id":90990928,"diff_hunk":"@@ -110,387 +110,380 @@ informative:\n \n --- note_Feedback\n \n-This specification is a part of the [Interledger Protocol](https://interledger.org/) work. Feedback related to this specification should be sent to <public-interledger@w3.org>.\n+This specification is a part of the [Interledger Protocol](https://interledger.org/) work. Feedback related to this specification should be sent to <ledger@ietf.org>.\n \n --- abstract\n \n-Crypto-conditions provide a mechanism to describe a signed message such that multiple actors in a distributed system can all verify the same signed message and agree on whether it matches the description. This provides a useful primitive for event-based systems that are distributed on the Internet since we can describe events in a standard deterministic manner (represented by signed messages) and therefore define generic authenticated event handlers.\n+Crypto-conditions defines a set of encoding formats and data structures for conditions and fulfillments.  A condition uniquely identifies a boolean circuit constructed from one or more logic gates, evaluated by either validating a cryptographic signature or verifying the preimage of a hash digest. A fulfillment is a data structure encoding one or more cryptographic signatures and hash digest preimages that can be used to evaluate the result of the circuit.","path":"0002-crypto-conditions/0002-crypto-conditions.md","position":19,"original_position":19,"commit_id":"ea3e15be2763c2a32147835b1972b54ee03959ac","original_commit_id":"ea3e15be2763c2a32147835b1972b54ee03959ac","user":{"login":"justmoon","id":53233,"avatar_url":"https://avatars.githubusercontent.com/u/53233?v=3","gravatar_id":"","url":"https://api.github.com/users/justmoon","html_url":"https://github.com/justmoon","followers_url":"https://api.github.com/users/justmoon/followers","following_url":"https://api.github.com/users/justmoon/following{/other_user}","gists_url":"https://api.github.com/users/justmoon/gists{/gist_id}","starred_url":"https://api.github.com/users/justmoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justmoon/subscriptions","organizations_url":"https://api.github.com/users/justmoon/orgs","repos_url":"https://api.github.com/users/justmoon/repos","events_url":"https://api.github.com/users/justmoon/events{/privacy}","received_events_url":"https://api.github.com/users/justmoon/received_events","type":"User","site_admin":false},"body":"Yeah, the abstract is a bit self-referential:\r\n\r\n> Crypto-**conditions** defines a set of encoding formats and data structures for **conditions** and fulfillments.\r\n\r\nMaybe we can consolidate these sections, they seem fairly redundant. Maybe move the first paragraph of the intro to the abstract and make the intro more of a section about why we are doing this, perhaps referencing Chris Allen's Smart Signatures etc.","created_at":"2016-12-06T00:48:18Z","updated_at":"2016-12-06T00:48:18Z","html_url":"https://github.com/interledger/rfcs/pull/124#discussion_r90990928","pull_request_url":"https://api.github.com/repos/interledger/rfcs/pulls/124","_links":{"self":{"href":"https://api.github.com/repos/interledger/rfcs/pulls/comments/90990928"},"html":{"href":"https://github.com/interledger/rfcs/pull/124#discussion_r90990928"},"pull_request":{"href":"https://api.github.com/repos/interledger/rfcs/pulls/124"}}},"pull_request":{"url":"https://api.github.com/repos/interledger/rfcs/pulls/124","id":93256883,"html_url":"https://github.com/interledger/rfcs/pull/124","diff_url":"https://github.com/interledger/rfcs/pull/124.diff","patch_url":"https://github.com/interledger/rfcs/pull/124.patch","issue_url":"https://api.github.com/repos/interledger/rfcs/issues/124","number":124,"state":"open","locked":false,"title":"Updates to crypto-conditions","user":{"login":"adrianhopebailie","id":49902,"avatar_url":"https://avatars.githubusercontent.com/u/49902?v=3","gravatar_id":"","url":"https://api.github.com/users/adrianhopebailie","html_url":"https://github.com/adrianhopebailie","followers_url":"https://api.github.com/users/adrianhopebailie/followers","following_url":"https://api.github.com/users/adrianhopebailie/following{/other_user}","gists_url":"https://api.github.com/users/adrianhopebailie/gists{/gist_id}","starred_url":"https://api.github.com/users/adrianhopebailie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrianhopebailie/subscriptions","organizations_url":"https://api.github.com/users/adrianhopebailie/orgs","repos_url":"https://api.github.com/users/adrianhopebailie/repos","events_url":"https://api.github.com/users/adrianhopebailie/events{/privacy}","received_events_url":"https://api.github.com/users/adrianhopebailie/received_events","type":"User","site_admin":false},"body":"Moved string encoding to appendix\r\nDropped featurebitmask in favour of subtypes\r\nDropped weights from threshold type\r\nChanged some field sizes\r\nRe-write abstract, intro and others","created_at":"2016-11-11T00:09:59Z","updated_at":"2016-12-06T01:02:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f7c27401099ded18d396939a0ea3cd4e1e00a2b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/interledger/rfcs/pulls/124/commits","review_comments_url":"https://api.github.com/repos/interledger/rfcs/pulls/124/comments","review_comment_url":"https://api.github.com/repos/interledger/rfcs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/interledger/rfcs/issues/124/comments","statuses_url":"https://api.github.com/repos/interledger/rfcs/statuses/ea3e15be2763c2a32147835b1972b54ee03959ac","head":{"label":"interledger:adrianhopebailie-draft-02","ref":"adrianhopebailie-draft-02","sha":"ea3e15be2763c2a32147835b1972b54ee03959ac","user":{"login":"interledger","id":14062960,"avatar_url":"https://avatars.githubusercontent.com/u/14062960?v=3","gravatar_id":"","url":"https://api.github.com/users/interledger","html_url":"https://github.com/interledger","followers_url":"https://api.github.com/users/interledger/followers","following_url":"https://api.github.com/users/interledger/following{/other_user}","gists_url":"https://api.github.com/users/interledger/gists{/gist_id}","starred_url":"https://api.github.com/users/interledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interledger/subscriptions","organizations_url":"https://api.github.com/users/interledger/orgs","repos_url":"https://api.github.com/users/interledger/repos","events_url":"https://api.github.com/users/interledger/events{/privacy}","received_events_url":"https://api.github.com/users/interledger/received_events","type":"Organization","site_admin":false},"repo":{"id":41705345,"name":"rfcs","full_name":"interledger/rfcs","owner":{"login":"interledger","id":14062960,"avatar_url":"https://avatars.githubusercontent.com/u/14062960?v=3","gravatar_id":"","url":"https://api.github.com/users/interledger","html_url":"https://github.com/interledger","followers_url":"https://api.github.com/users/interledger/followers","following_url":"https://api.github.com/users/interledger/following{/other_user}","gists_url":"https://api.github.com/users/interledger/gists{/gist_id}","starred_url":"https://api.github.com/users/interledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interledger/subscriptions","organizations_url":"https://api.github.com/users/interledger/orgs","repos_url":"https://api.github.com/users/interledger/repos","events_url":"https://api.github.com/users/interledger/events{/privacy}","received_events_url":"https://api.github.com/users/interledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/interledger/rfcs","description":"A set of draft specifications for enabling interledger payments","fork":false,"url":"https://api.github.com/repos/interledger/rfcs","forks_url":"https://api.github.com/repos/interledger/rfcs/forks","keys_url":"https://api.github.com/repos/interledger/rfcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/interledger/rfcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/interledger/rfcs/teams","hooks_url":"https://api.github.com/repos/interledger/rfcs/hooks","issue_events_url":"https://api.github.com/repos/interledger/rfcs/issues/events{/number}","events_url":"https://api.github.com/repos/interledger/rfcs/events","assignees_url":"https://api.github.com/repos/interledger/rfcs/assignees{/user}","branches_url":"https://api.github.com/repos/interledger/rfcs/branches{/branch}","tags_url":"https://api.github.com/repos/interledger/rfcs/tags","blobs_url":"https://api.github.com/repos/interledger/rfcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/interledger/rfcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/interledger/rfcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/interledger/rfcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/interledger/rfcs/statuses/{sha}","languages_url":"https://api.github.com/repos/interledger/rfcs/languages","stargazers_url":"https://api.github.com/repos/interledger/rfcs/stargazers","contributors_url":"https://api.github.com/repos/interledger/rfcs/contributors","subscribers_url":"https://api.github.com/repos/interledger/rfcs/subscribers","subscription_url":"https://api.github.com/repos/interledger/rfcs/subscription","commits_url":"https://api.github.com/repos/interledger/rfcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/interledger/rfcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/interledger/rfcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/interledger/rfcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/interledger/rfcs/contents/{+path}","compare_url":"https://api.github.com/repos/interledger/rfcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/interledger/rfcs/merges","archive_url":"https://api.github.com/repos/interledger/rfcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/interledger/rfcs/downloads","issues_url":"https://api.github.com/repos/interledger/rfcs/issues{/number}","pulls_url":"https://api.github.com/repos/interledger/rfcs/pulls{/number}","milestones_url":"https://api.github.com/repos/interledger/rfcs/milestones{/number}","notifications_url":"https://api.github.com/repos/interledger/rfcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/interledger/rfcs/labels{/name}","releases_url":"https://api.github.com/repos/interledger/rfcs/releases{/id}","deployments_url":"https://api.github.com/repos/interledger/rfcs/deployments","created_at":"2015-08-31T23:17:16Z","updated_at":"2016-12-03T01:06:25Z","pushed_at":"2016-12-02T19:37:37Z","git_url":"git://github.com/interledger/rfcs.git","ssh_url":"git@github.com:interledger/rfcs.git","clone_url":"https://github.com/interledger/rfcs.git","svn_url":"https://github.com/interledger/rfcs","homepage":null,"size":602,"stargazers_count":26,"watchers_count":26,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"open_issues_count":32,"forks":12,"open_issues":32,"watchers":26,"default_branch":"master"}},"base":{"label":"interledger:master","ref":"master","sha":"3af53b85aba5b6fb5c52df70633a991b4562dc33","user":{"login":"interledger","id":14062960,"avatar_url":"https://avatars.githubusercontent.com/u/14062960?v=3","gravatar_id":"","url":"https://api.github.com/users/interledger","html_url":"https://github.com/interledger","followers_url":"https://api.github.com/users/interledger/followers","following_url":"https://api.github.com/users/interledger/following{/other_user}","gists_url":"https://api.github.com/users/interledger/gists{/gist_id}","starred_url":"https://api.github.com/users/interledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interledger/subscriptions","organizations_url":"https://api.github.com/users/interledger/orgs","repos_url":"https://api.github.com/users/interledger/repos","events_url":"https://api.github.com/users/interledger/events{/privacy}","received_events_url":"https://api.github.com/users/interledger/received_events","type":"Organization","site_admin":false},"repo":{"id":41705345,"name":"rfcs","full_name":"interledger/rfcs","owner":{"login":"interledger","id":14062960,"avatar_url":"https://avatars.githubusercontent.com/u/14062960?v=3","gravatar_id":"","url":"https://api.github.com/users/interledger","html_url":"https://github.com/interledger","followers_url":"https://api.github.com/users/interledger/followers","following_url":"https://api.github.com/users/interledger/following{/other_user}","gists_url":"https://api.github.com/users/interledger/gists{/gist_id}","starred_url":"https://api.github.com/users/interledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interledger/subscriptions","organizations_url":"https://api.github.com/users/interledger/orgs","repos_url":"https://api.github.com/users/interledger/repos","events_url":"https://api.github.com/users/interledger/events{/privacy}","received_events_url":"https://api.github.com/users/interledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/interledger/rfcs","description":"A set of draft specifications for enabling interledger payments","fork":false,"url":"https://api.github.com/repos/interledger/rfcs","forks_url":"https://api.github.com/repos/interledger/rfcs/forks","keys_url":"https://api.github.com/repos/interledger/rfcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/interledger/rfcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/interledger/rfcs/teams","hooks_url":"https://api.github.com/repos/interledger/rfcs/hooks","issue_events_url":"https://api.github.com/repos/interledger/rfcs/issues/events{/number}","events_url":"https://api.github.com/repos/interledger/rfcs/events","assignees_url":"https://api.github.com/repos/interledger/rfcs/assignees{/user}","branches_url":"https://api.github.com/repos/interledger/rfcs/branches{/branch}","tags_url":"https://api.github.com/repos/interledger/rfcs/tags","blobs_url":"https://api.github.com/repos/interledger/rfcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/interledger/rfcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/interledger/rfcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/interledger/rfcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/interledger/rfcs/statuses/{sha}","languages_url":"https://api.github.com/repos/interledger/rfcs/languages","stargazers_url":"https://api.github.com/repos/interledger/rfcs/stargazers","contributors_url":"https://api.github.com/repos/interledger/rfcs/contributors","subscribers_url":"https://api.github.com/repos/interledger/rfcs/subscribers","subscription_url":"https://api.github.com/repos/interledger/rfcs/subscription","commits_url":"https://api.github.com/repos/interledger/rfcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/interledger/rfcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/interledger/rfcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/interledger/rfcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/interledger/rfcs/contents/{+path}","compare_url":"https://api.github.com/repos/interledger/rfcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/interledger/rfcs/merges","archive_url":"https://api.github.com/repos/interledger/rfcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/interledger/rfcs/downloads","issues_url":"https://api.github.com/repos/interledger/rfcs/issues{/number}","pulls_url":"https://api.github.com/repos/interledger/rfcs/pulls{/number}","milestones_url":"https://api.github.com/repos/interledger/rfcs/milestones{/number}","notifications_url":"https://api.github.com/repos/interledger/rfcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/interledger/rfcs/labels{/name}","releases_url":"https://api.github.com/repos/interledger/rfcs/releases{/id}","deployments_url":"https://api.github.com/repos/interledger/rfcs/deployments","created_at":"2015-08-31T23:17:16Z","updated_at":"2016-12-03T01:06:25Z","pushed_at":"2016-12-02T19:37:37Z","git_url":"git://github.com/interledger/rfcs.git","ssh_url":"git@github.com:interledger/rfcs.git","clone_url":"https://github.com/interledger/rfcs.git","svn_url":"https://github.com/interledger/rfcs","homepage":null,"size":602,"stargazers_count":26,"watchers_count":26,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"open_issues_count":32,"forks":12,"open_issues":32,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/interledger/rfcs/pulls/124"},"html":{"href":"https://github.com/interledger/rfcs/pull/124"},"issue":{"href":"https://api.github.com/repos/interledger/rfcs/issues/124"},"comments":{"href":"https://api.github.com/repos/interledger/rfcs/issues/124/comments"},"review_comments":{"href":"https://api.github.com/repos/interledger/rfcs/pulls/124/comments"},"review_comment":{"href":"https://api.github.com/repos/interledger/rfcs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/interledger/rfcs/pulls/124/commits"},"statuses":{"href":"https://api.github.com/repos/interledger/rfcs/statuses/ea3e15be2763c2a32147835b1972b54ee03959ac"}}}}
{"actor":{"display_login":"justmoon"}}