{"action":"closed","issue":{"url":"https://api.github.com/repos/freeorion/freeorion/issues/471","repository_url":"https://api.github.com/repos/freeorion/freeorion","labels_url":"https://api.github.com/repos/freeorion/freeorion/issues/471/labels{/name}","comments_url":"https://api.github.com/repos/freeorion/freeorion/issues/471/comments","events_url":"https://api.github.com/repos/freeorion/freeorion/issues/471/events","html_url":"https://github.com/freeorion/freeorion/issues/471","id":131905056,"number":471,"title":"Probably wrong operator precedence in SidePanel code","user":{"login":"adrianbroher","id":84891,"avatar_url":"https://avatars.githubusercontent.com/u/84891?v=3","gravatar_id":"","url":"https://api.github.com/users/adrianbroher","html_url":"https://github.com/adrianbroher","followers_url":"https://api.github.com/users/adrianbroher/followers","following_url":"https://api.github.com/users/adrianbroher/following{/other_user}","gists_url":"https://api.github.com/users/adrianbroher/gists{/gist_id}","starred_url":"https://api.github.com/users/adrianbroher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrianbroher/subscriptions","organizations_url":"https://api.github.com/users/adrianbroher/orgs","repos_url":"https://api.github.com/users/adrianbroher/repos","events_url":"https://api.github.com/users/adrianbroher/events{/privacy}","received_events_url":"https://api.github.com/users/adrianbroher/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/freeorion/freeorion/labels/bug","name":"bug","color":"fc2929"}],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/freeorion/freeorion/milestones/15","html_url":"https://github.com/freeorion/freeorion/milestones/Next%20release","labels_url":"https://api.github.com/repos/freeorion/freeorion/milestones/15/labels","id":1226316,"number":15,"title":"Next release","description":"Bugs, features and pull requests that should be fixed until next release.","creator":{"login":"adrianbroher","id":84891,"avatar_url":"https://avatars.githubusercontent.com/u/84891?v=3","gravatar_id":"","url":"https://api.github.com/users/adrianbroher","html_url":"https://github.com/adrianbroher","followers_url":"https://api.github.com/users/adrianbroher/followers","following_url":"https://api.github.com/users/adrianbroher/following{/other_user}","gists_url":"https://api.github.com/users/adrianbroher/gists{/gist_id}","starred_url":"https://api.github.com/users/adrianbroher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrianbroher/subscriptions","organizations_url":"https://api.github.com/users/adrianbroher/orgs","repos_url":"https://api.github.com/users/adrianbroher/repos","events_url":"https://api.github.com/users/adrianbroher/events{/privacy}","received_events_url":"https://api.github.com/users/adrianbroher/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":141,"state":"open","created_at":"2015-07-26T16:21:09Z","updated_at":"2016-02-07T14:12:06Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2016-02-06T22:21:35Z","updated_at":"2016-02-07T14:12:06Z","closed_at":"2016-02-07T14:12:06Z","body":"When compiling `UI/Sidepanel.cpp` g++ reports the following warning:\r\n\r\n```\r\n<project dir>/UI/SidePanel.cpp: In Elementfunktion »void SidePanel::PlanetPanel::ClickColonize()«:\r\n<project dir>/UI/SidePanel.cpp:2086:65: Warnung: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]\r\n     if (!planet || !planet->CurrentMeterValue(METER_POPULATION) == 0.0 || !m_order_issuing_enabled)\r\n```\r\n\r\nI haven't yet the time to check what is the right statement by means of gameplay logic, but `!value == 0.0` probably doesn't reflect what the author actually had in mind."}}