{"action":"created","comment":{"url":"https://api.github.com/repos/Financial-Times/next-sitemaps/pulls/comments/77318147","id":77318147,"diff_hunk":"@@ -31,6 +31,31 @@\n                     \"Uri\": { \"Fn::Join\": [\"\", [\"arn:aws:apigateway:\", { \"Ref\": \"AWS::Region\" }, \":lambda:path/2015-03-31/functions/arn:aws:lambda:\", { \"Ref\": \"AWS::Region\" }, \":\", { \"Ref\": \"AWS::AccountId\" }, \":function:nextsitemaps_index/invocations\"] ]}\n                 }\n             }\n+        },\n+        \"NextSitemapsVideoBucket\": {\n+            \"Type\": \"AWS::S3::Bucket\",\n+            \"Properties\": {\n+                \"BucketName\": \"nextsitemaps.video\"","path":"templates/master.json","position":13,"original_position":8,"commit_id":"e8e26fc57ce5fe9089050176849fcf4d7589811f","original_commit_id":"d610bc0fb1681863d6af8ec904f7f7b0a06d9c79","user":{"login":"TheoLeanse","id":4750238,"avatar_url":"https://avatars.githubusercontent.com/u/4750238?v=3","gravatar_id":"","url":"https://api.github.com/users/TheoLeanse","html_url":"https://github.com/TheoLeanse","followers_url":"https://api.github.com/users/TheoLeanse/followers","following_url":"https://api.github.com/users/TheoLeanse/following{/other_user}","gists_url":"https://api.github.com/users/TheoLeanse/gists{/gist_id}","starred_url":"https://api.github.com/users/TheoLeanse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheoLeanse/subscriptions","organizations_url":"https://api.github.com/users/TheoLeanse/orgs","repos_url":"https://api.github.com/users/TheoLeanse/repos","events_url":"https://api.github.com/users/TheoLeanse/events{/privacy}","received_events_url":"https://api.github.com/users/TheoLeanse/received_events","type":"User","site_admin":false},"body":"ah I see what you mean re: separate buckets - one bucket is way more sensible of course.\r\n\r\nnot sure what you mean re: separate accounts though - dev and prod? so different names? ah, so would it be enough to append the environment to the name, if you can do that in cloudformation? ","created_at":"2016-09-02T09:24:58Z","updated_at":"2016-09-02T09:24:58Z","html_url":"https://github.com/Financial-Times/next-sitemaps/pull/4#discussion_r77318147","pull_request_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/Financial-Times/next-sitemaps/pulls/comments/77318147"},"html":{"href":"https://github.com/Financial-Times/next-sitemaps/pull/4#discussion_r77318147"},"pull_request":{"href":"https://api.github.com/repos/Financial-Times/next-sitemaps/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/Financial-Times/next-sitemaps/pulls/4","id":83769510,"html_url":"https://github.com/Financial-Times/next-sitemaps/pull/4","diff_url":"https://github.com/Financial-Times/next-sitemaps/pull/4.diff","patch_url":"https://github.com/Financial-Times/next-sitemaps/pull/4.patch","issue_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/issues/4","number":4,"state":"open","locked":false,"title":"Add S3 buckets and permissions","user":{"login":"TheoLeanse","id":4750238,"avatar_url":"https://avatars.githubusercontent.com/u/4750238?v=3","gravatar_id":"","url":"https://api.github.com/users/TheoLeanse","html_url":"https://github.com/TheoLeanse","followers_url":"https://api.github.com/users/TheoLeanse/followers","following_url":"https://api.github.com/users/TheoLeanse/following{/other_user}","gists_url":"https://api.github.com/users/TheoLeanse/gists{/gist_id}","starred_url":"https://api.github.com/users/TheoLeanse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheoLeanse/subscriptions","organizations_url":"https://api.github.com/users/TheoLeanse/orgs","repos_url":"https://api.github.com/users/TheoLeanse/repos","events_url":"https://api.github.com/users/TheoLeanse/events{/privacy}","received_events_url":"https://api.github.com/users/TheoLeanse/received_events","type":"User","site_admin":false},"body":"/cc @matthew-andrews ","created_at":"2016-09-02T09:17:27Z","updated_at":"2016-09-02T09:24:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da2f7bd7845ca0c9b0bf59bd8ca71e62f737bdae","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/pulls/4/commits","review_comments_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/pulls/4/comments","review_comment_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/issues/4/comments","statuses_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/statuses/e8e26fc57ce5fe9089050176849fcf4d7589811f","head":{"label":"Financial-Times:theo/add-buckets-to-cloudformation","ref":"theo/add-buckets-to-cloudformation","sha":"e8e26fc57ce5fe9089050176849fcf4d7589811f","user":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"repo":{"id":67120775,"name":"next-sitemaps","full_name":"Financial-Times/next-sitemaps","owner":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Financial-Times/next-sitemaps","description":"Generates sitemaps for Next FT.com","fork":false,"url":"https://api.github.com/repos/Financial-Times/next-sitemaps","forks_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/forks","keys_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/teams","hooks_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/hooks","issue_events_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/issues/events{/number}","events_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/events","assignees_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/assignees{/user}","branches_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/branches{/branch}","tags_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/tags","blobs_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/git/refs{/sha}","trees_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/statuses/{sha}","languages_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/languages","stargazers_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/stargazers","contributors_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/contributors","subscribers_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/subscribers","subscription_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/subscription","commits_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/commits{/sha}","git_commits_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/git/commits{/sha}","comments_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/comments{/number}","issue_comment_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/issues/comments{/number}","contents_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/contents/{+path}","compare_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/merges","archive_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/downloads","issues_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/issues{/number}","pulls_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/pulls{/number}","milestones_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/milestones{/number}","notifications_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/labels{/name}","releases_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/releases{/id}","deployments_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/deployments","created_at":"2016-09-01T10:11:46Z","updated_at":"2016-09-01T11:06:03Z","pushed_at":"2016-09-02T09:21:16Z","git_url":"git://github.com/Financial-Times/next-sitemaps.git","ssh_url":"git@github.com:Financial-Times/next-sitemaps.git","clone_url":"https://github.com/Financial-Times/next-sitemaps.git","svn_url":"https://github.com/Financial-Times/next-sitemaps","homepage":"","size":8,"stargazers_count":0,"watchers_count":0,"language":"Makefile","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Financial-Times:master","ref":"master","sha":"f48907914fd5afefaa29bb5b0a4c15f1201dbddd","user":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"repo":{"id":67120775,"name":"next-sitemaps","full_name":"Financial-Times/next-sitemaps","owner":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Financial-Times/next-sitemaps","description":"Generates sitemaps for Next FT.com","fork":false,"url":"https://api.github.com/repos/Financial-Times/next-sitemaps","forks_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/forks","keys_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/teams","hooks_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/hooks","issue_events_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/issues/events{/number}","events_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/events","assignees_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/assignees{/user}","branches_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/branches{/branch}","tags_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/tags","blobs_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/git/refs{/sha}","trees_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/statuses/{sha}","languages_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/languages","stargazers_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/stargazers","contributors_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/contributors","subscribers_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/subscribers","subscription_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/subscription","commits_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/commits{/sha}","git_commits_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/git/commits{/sha}","comments_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/comments{/number}","issue_comment_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/issues/comments{/number}","contents_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/contents/{+path}","compare_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/merges","archive_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/downloads","issues_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/issues{/number}","pulls_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/pulls{/number}","milestones_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/milestones{/number}","notifications_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/labels{/name}","releases_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/releases{/id}","deployments_url":"https://api.github.com/repos/Financial-Times/next-sitemaps/deployments","created_at":"2016-09-01T10:11:46Z","updated_at":"2016-09-01T11:06:03Z","pushed_at":"2016-09-02T09:21:16Z","git_url":"git://github.com/Financial-Times/next-sitemaps.git","ssh_url":"git@github.com:Financial-Times/next-sitemaps.git","clone_url":"https://github.com/Financial-Times/next-sitemaps.git","svn_url":"https://github.com/Financial-Times/next-sitemaps","homepage":"","size":8,"stargazers_count":0,"watchers_count":0,"language":"Makefile","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Financial-Times/next-sitemaps/pulls/4"},"html":{"href":"https://github.com/Financial-Times/next-sitemaps/pull/4"},"issue":{"href":"https://api.github.com/repos/Financial-Times/next-sitemaps/issues/4"},"comments":{"href":"https://api.github.com/repos/Financial-Times/next-sitemaps/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/Financial-Times/next-sitemaps/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/Financial-Times/next-sitemaps/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Financial-Times/next-sitemaps/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/Financial-Times/next-sitemaps/statuses/e8e26fc57ce5fe9089050176849fcf4d7589811f"}}}}
{"actor":{"display_login":"TheoLeanse"}}