{"push_id":1381838675,"size":293,"distinct_size":1,"ref":"refs/heads/pr/nxcomp-support-generic-events","head":"0555bb88c80858a439586db4d43d34fcaf433118","before":"7c6118ee17761772c4036c85319b1eb78e2c4b62","commits":[{"sha":"f0b87f3de6261a4b95e6a68aa0a24b35b5278e56","author":{"name":"Daniel Stone","email":"4b94a04674ad2c69d990e94ab196ac3f8e9e03d4@fooishbar.org"},"message":"XStringToKeysym: Special case for XF86 keysyms\n\nSome XFree86 keysyms were in XKeysymDB as XF86_foo, despite really being\nXF86foo.  So, if we get to the bottom of XStringToKeysym and haven't\nfound our XF86_foo, try it again as XF86foo.\n\nSigned-off-by: Daniel Stone <daniel@fooishbar.org>\nReviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>\nBackported-to-NX-by: Ulrich Sibiller <uli42@gmx.de>","distinct":false,"url":"https://api.github.com/repos/sunweaver/nx-libs/commits/f0b87f3de6261a4b95e6a68aa0a24b35b5278e56"},{"sha":"c1b175d3d1496fdbbad783e8cc0319ca954829b4","author":{"name":"Daniel Stone","email":"4b94a04674ad2c69d990e94ab196ac3f8e9e03d4@fooishbar.org"},"message":"Delete now-redundant XKeysymDB\n\nSince XStringToKeysym now supports all the vendor keysyms, just delete\nour XKeysymDB, which was incomplete at best, misleading at worst, and\nalways an annoyance.\n\nSigned-off-by: Daniel Stone <daniel@fooishbar.org>\nReviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>\nBackported-to-NX-by: Ulrich Sibiller <uli42@gmx.de>","distinct":false,"url":"https://api.github.com/repos/sunweaver/nx-libs/commits/c1b175d3d1496fdbbad783e8cc0319ca954829b4"},{"sha":"b414bc2c6f389224023c1d184d8aa0d18387512c","author":{"name":"Daniel Stone","email":"4b94a04674ad2c69d990e94ab196ac3f8e9e03d4@fooishbar.org"},"message":"XStringToKeysym: Check strdup() return value\n\nSigned-off-by: Daniel Stone <daniel@fooishbar.org>\nReviewed-by: Keith Packard <keithp@keithp.com>\nBackported-to-NX-by: Ulrich Sibiller <uli42@gmx.de>","distinct":false,"url":"https://api.github.com/repos/sunweaver/nx-libs/commits/b414bc2c6f389224023c1d184d8aa0d18387512c"},{"sha":"93b55eeec022007d638c0a3b305765d44d3cd185","author":{"name":"Daniel Stone","email":"4b94a04674ad2c69d990e94ab196ac3f8e9e03d4@fooishbar.org"},"message":"XStringToKeysym: Cope with 0x1234cafe-style input\n\nIf we get input in the style of 0xdeadbeef, just return that exact\nkeysym.  Introduces a dependency on strtoul, which I'm told is OK on all\nthe systems we care about.\n\nSigned-off-by: Daniel Stone <daniel@fooishbar.org>\nBackported-to-NX-by: Ulrich Sibiller <uli42@gmx.de>","distinct":false,"url":"https://api.github.com/repos/sunweaver/nx-libs/commits/93b55eeec022007d638c0a3b305765d44d3cd185"},{"sha":"8ff526111bfc6ca8d2384c4d4962b8e8ff3621f9","author":{"name":"Alan Coopersmith","email":"213b6a7fe88aaaa0324352cedf990a0b57cb6ef5@oracle.com"},"message":"LINEAR_RGB_InitSCCData: When malloc fails, don't try to free unallocated bits\n\nOne of the malloc failure checks had a goto to the wrong spot in the\nlist of cleanup free() calls to unwind at the end, and was freeing\nbits that hadn't been initialized/allocated yet, since they would be\nstored in the struct that just failed to be allocated.\n\nError: Null pointer dereference (CWE 476)\n   Read from pointer that could be constant 'NULL'\n        at line 805 of /export/alanc/X.Org/sx86/lib/libX11/nx-X11/lib/X11/LRGB.c in function 'LINEAR_RGB_InitSCCData'.\n          Pointer checked against constant 'NULL' at line 754 but does not protect the dereference.\n\n[ This bug was found by the Parfait bug checking tool.\n  For more information see http://research.sun.com/projects/parfait ]\n\nSigned-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>\nBackported-to-NX-by: Ulrich Sibiller <uli42@gmx.de>","distinct":false,"url":"https://api.github.com/repos/sunweaver/nx-libs/commits/8ff526111bfc6ca8d2384c4d4962b8e8ff3621f9"},{"sha":"1a72bc41460aa37b2ae6ce37bc9fb9e3644f5943","author":{"name":"Pauli Nieminen","email":"2077134d16a7a5d0ce2f26d6c5ab691733efdac9@nokia.com"},"message":"Initialize event type\n\nIf we receive unsupported event closing connection triggers valgrind\nerror.\n\n==12017== Conditional jump or move depends on uninitialised value(s)\n==12017==    at 0x487D454: _XFreeDisplayStructure (OpenDis.c:607)\n==12017==    by 0x486857B: XCloseDisplay (ClDisplay.c:72)\n*snip*\n==12017==  Uninitialised value was created by a heap allocation\n==12017==    at 0x4834C48: malloc (vg_replace_malloc.c:236)\n==12017==    by 0x4894147: _XEnq (XlibInt.c:877)\n==12017==    by 0x4891BF3: handle_response (xcb_io.c:335)\n==12017==    by 0x4892263: _XReply (xcb_io.c:626)\n*snip*\n\nProblem is that XFreeDisplaySturture is checking for qelt->event.type ==\nGenericEvent while _XUnknownWireEvent doesn't store the type.\n\nReviewed-by: Adam Jackson <ajax@redhat.com>\nReviewed-by: Peter Hutterer <peter.hutterer@who-t.net>\nSigned-off-by: Pauli Nieminen <ext-pauli.nieminen@nokia.com>\nBackported-to-NX-by: Ulrich Sibiller <uli42@gmx.de>","distinct":false,"url":"https://api.github.com/repos/sunweaver/nx-libs/commits/1a72bc41460aa37b2ae6ce37bc9fb9e3644f5943"},{"sha":"8aacb3fab5824e20e07699cef93c5a20daaff368","author":{"name":"Erkki Seppälä","email":"1d6c8d14c8b9faf9dadd31d9b27c531b15850a0a@vincit.fi"},"message":"Using freed pointer \"e\"\n\nReordered code to first to do the comparison and then to release data\n\nReviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>\nReviewed-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>\nSigned-off-by: Erkki Seppälä <erkki.seppala@vincit.fi>\nBackported-to-NX-by: Ulrich Sibiller <uli42@gmx.de>","distinct":false,"url":"https://api.github.com/repos/sunweaver/nx-libs/commits/8aacb3fab5824e20e07699cef93c5a20daaff368"},{"sha":"e175587865ccd01f1771f61cc05735158c8ba6df","author":{"name":"Erkki Seppälä","email":"1d6c8d14c8b9faf9dadd31d9b27c531b15850a0a@vincit.fi"},"message":"Dereferencing possibly NULL \"str\" in call to function \"memcpy\" (Deref assumed on the basis of 'nonnull' parameter attribute.)\n\nIf _XkbGetReadBufferPtr returns NULL, goto BAILOUT\n\nReviewed-by: Dirk Wallenstein <halsmit@t-online.de>\nReviewed-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>\nSigned-off-by: Erkki Seppälä <erkki.seppala@vincit.fi>\nBackported-to-NX-by: Ulrich Sibiller <uli42@gmx.de>","distinct":false,"url":"https://api.github.com/repos/sunweaver/nx-libs/commits/e175587865ccd01f1771f61cc05735158c8ba6df"},{"sha":"3147ddbf47897688b61e95c18f255cbd8ccc0532","author":{"name":"Erkki Seppälä","email":"1d6c8d14c8b9faf9dadd31d9b27c531b15850a0a@vincit.fi"},"message":"Variable \"entry\" tracked as NULL was dereferenced.\n\nCheck entry for non-nullness before dereferencing it\n\nReviewed-by: Dirk Wallenstein <halsmit@t-online.de>\nReviewed-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>\nSigned-off-by: Erkki Seppälä <erkki.seppala@vincit.fi>\nBackported-to-NX-by: Ulrich Sibiller <uli42@gmx.de>","distinct":false,"url":"https://api.github.com/repos/sunweaver/nx-libs/commits/3147ddbf47897688b61e95c18f255cbd8ccc0532"},{"sha":"b7694b0b51cdf07f49d89132fbe100b5ebfb086b","author":{"name":"Erkki Seppälä","email":"1d6c8d14c8b9faf9dadd31d9b27c531b15850a0a@vincit.fi"},"message":"Comparing array against NULL is not useful \"&xkb->server->vmods != NULL\"\n\nRemoved superfluous comparison.\n\nReviewed-by: Dirk Wallenstein <halsmit@t-online.de>\nSigned-off-by: Erkki Seppälä <erkki.seppala@vincit.fi>\nBackported-to-NX-by: Ulrich Sibiller <uli42@gmx.de>","distinct":false,"url":"https://api.github.com/repos/sunweaver/nx-libs/commits/b7694b0b51cdf07f49d89132fbe100b5ebfb086b"},{"sha":"54550ebb2a1fc504406b199550b8e023ef2c9517","author":{"name":"Alan Coopersmith","email":"213b6a7fe88aaaa0324352cedf990a0b57cb6ef5@oracle.com"},"message":"XDefaultOMIF.c: Fix memory leaks in get_font_name\n\nInstead of copying the value returned by get_prop_name and then releasing it,\ndirectly use the return value of get_prop_name, which allocates memory for the\nname.\n\nIf get_prop_name returns NULL, continue on to XFreeFont to release the font\nbefore returning the NULL via the normal function return.\n\nReviewed-by: Erkki Seppälä <erkki.seppala@vincit.fi>\nSigned-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>\nBackported-to-NX-by: Ulrich Sibiller <uli42@gmx.de>","distinct":false,"url":"https://api.github.com/repos/sunweaver/nx-libs/commits/54550ebb2a1fc504406b199550b8e023ef2c9517"},{"sha":"865043ea08c5f4effae397341b5faae8514f220e","author":{"name":"Erkki Seppälä","email":"1d6c8d14c8b9faf9dadd31d9b27c531b15850a0a@vincit.fi"},"message":"xcmx/cmxColNm: Removed unused assignments to pBuf (in two functions)\n\nPointer \"pBuf\" returned from \"fgets(buf, 256, stream)\" is never used\n\nReviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>\nReviewed-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>\nSigned-off-by: Erkki Seppälä <erkki.seppala@vincit.fi>\nSigned-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>\nBackported-to-NX-by: Ulrich Sibiller <uli42@gmx.de>","distinct":false,"url":"https://api.github.com/repos/sunweaver/nx-libs/commits/865043ea08c5f4effae397341b5faae8514f220e"},{"sha":"52d2c35580bd29d27ce8b8712a94be1042cabdda","author":{"name":"Erkki Seppälä","email":"1d6c8d14c8b9faf9dadd31d9b27c531b15850a0a@vincit.fi"},"message":"xlibi18n/lcGeneric: Initialize uninitialized local variable\n\nUsing uninitialized value \"new\"\n\nReviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>\nReviewed-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>\nSigned-off-by: Erkki Seppälä <erkki.seppala@vincit.fi>\nSigned-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>\nBackported-to-NX-by: Ulrich Sibiller <uli42@gmx.de>","distinct":false,"url":"https://api.github.com/repos/sunweaver/nx-libs/commits/52d2c35580bd29d27ce8b8712a94be1042cabdda"},{"sha":"1ac1b691d24af84db4061ca7b3fffb0f588e8f3c","author":{"name":"Erkki Seppälä","email":"1d6c8d14c8b9faf9dadd31d9b27c531b15850a0a@vincit.fi"},"message":"ImUtil: Handle a memory leak in one early return branch\n\nFixed memory leak by adding Xfree for image\n\nVariable \"image\" goes out of scope\n\nReviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>\nReviewed-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>\nSigned-off-by: Erkki Seppälä <erkki.seppala@vincit.fi>\nSigned-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>\nBackported-to-NX-by: Ulrich Sibiller <uli42@gmx.de>","distinct":false,"url":"https://api.github.com/repos/sunweaver/nx-libs/commits/1ac1b691d24af84db4061ca7b3fffb0f588e8f3c"},{"sha":"afd1d4eb5378d3c7419021b33e9c55619c364c1a","author":{"name":"Erkki Seppälä","email":"1d6c8d14c8b9faf9dadd31d9b27c531b15850a0a@vincit.fi"},"message":"Xrm: NEWTABLE had a memory leak after a memory allocation error\n\nThe NEWTABLE macro missed freeing its allocated memory on subsequent\nmemory allocation errors. Added call to Xfree.\n\nVariable \"table\" goes out of scope\n\nReviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>\nReviewed-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>\nSigned-off-by: Erkki Seppälä <erkki.seppala@vincit.fi>\nSigned-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>\nBackported-to-NX-by: Ulrich Sibiller <uli42@gmx.de>","distinct":false,"url":"https://api.github.com/repos/sunweaver/nx-libs/commits/afd1d4eb5378d3c7419021b33e9c55619c364c1a"},{"sha":"8f5a56474671bf3dd4909aa73fec1062fb5a14d8","author":{"name":"Ander Conselvan de Oliveira","email":"3e05af3e9c4c821b0bec9d48c959c6f3b2288179@nokia.com"},"message":"xcms/LRGB: Fix potential resource leak.\n\nproperty_return was not free'd if the allocation of pRedTbl failed.\n\nReviewed-by: Erkki Seppälä <erkki.seppala@vincit.fi>\nSigned-off-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>\nSigned-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>\nBackported-to-NX-by: Ulrich Sibiller <uli42@gmx.de>","distinct":false,"url":"https://api.github.com/repos/sunweaver/nx-libs/commits/8f5a56474671bf3dd4909aa73fec1062fb5a14d8"},{"sha":"7482afcaa71df7ed60909c3c3f995f4723190d4e","author":{"name":"Ander Conselvan de Oliveira","email":"3e05af3e9c4c821b0bec9d48c959c6f3b2288179@nokia.com"},"message":"xcms/LRGB: Add a label for freeing property_return.\n\nThe rest of the code uses goto's to free memory allocated later\nand prevent memory leaks, but there were several paths were\nproperty_return was free'd just before a goto.\n\nReviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>\nSigned-off-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>\nSigned-off-by: Erkki Seppälä <erkki.seppala@vincit.fi>\nSigned-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>\nBackported-to-NX-by: Ulrich Sibiller <uli42@gmx.de>","distinct":false,"url":"https://api.github.com/repos/sunweaver/nx-libs/commits/7482afcaa71df7ed60909c3c3f995f4723190d4e"},{"sha":"698270c47b3b78e3e746c4767a277c5e1e73ec14","author":{"name":"Ander Conselvan de Oliveira","email":"3e05af3e9c4c821b0bec9d48c959c6f3b2288179@nokia.com"},"message":"XlibInt: info_list->watch_data was reallocated, but result was discarded\n\ninfo_list->watch_data was being reallocated, but the return value of\nthe reallocation was stored only into a local variable. This might\ncause some funky behavior and crashes.\n\nVariable \"wd_array\" goes out of scope\nValue \"wd_array\" is overwritten in \"wd_array = (XPointer*)realloc((char*)info_list->watch_data, (((dpy->watcher_count + 1) * 4U == 0U) ? 1U : ((dpy->watcher_count + 1) * 4U)))\"\n\nReviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>\nReviewed-by: Erkki Seppälä <erkki.seppala@vincit.fi>\nSigned-off-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>\nSigned-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>\nBackported-to-NX-by: Ulrich Sibiller <uli42@gmx.de>","distinct":false,"url":"https://api.github.com/repos/sunweaver/nx-libs/commits/698270c47b3b78e3e746c4767a277c5e1e73ec14"},{"sha":"7576f5f150ee5d6cb32ebc55d2a5b32bd642a32d","author":{"name":"Erkki Seppälä","email":"1d6c8d14c8b9faf9dadd31d9b27c531b15850a0a@vincit.fi"},"message":"xlibi18n/lcFile: Removed superfluous check for NULL target_dir\n\nThe situation is already handled before this code.\n\nCannot reach dead expression \"0U\" inside statement \"if (1U + (target_dir ? strl...\"\n\nReviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>\nReviewed-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>\nSigned-off-by: Erkki Seppälä <erkki.seppala@vincit.fi>\nSigned-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>\nBackported-to-NX-by: Ulrich Sibiller <uli42@gmx.de>","distinct":false,"url":"https://api.github.com/repos/sunweaver/nx-libs/commits/7576f5f150ee5d6cb32ebc55d2a5b32bd642a32d"},{"sha":"20470a83e3a57f936cd90856325b897fa115b9ad","author":{"name":"Erkki Seppälä","email":"1d6c8d14c8b9faf9dadd31d9b27c531b15850a0a@vincit.fi"},"message":"XlibInt: Use strncpy+zero termination instead of strcpy to enforce buffer size\n\nPossible overrun of 8192 byte fixed size buffer \"buffer\" by copying\n\"ext->name\" without length checking\n\nReviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>\nReviewed-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>\nSigned-off-by: Erkki Seppälä <erkki.seppala@vincit.fi>\nSigned-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>\nBackported-to-NX-by: Ulrich Sibiller <uli42@gmx.de>","distinct":false,"url":"https://api.github.com/repos/sunweaver/nx-libs/commits/20470a83e3a57f936cd90856325b897fa115b9ad"}]}
{"actor":{"display_login":"sunweaver"}}