{"action":"created","issue":{"url":"https://api.github.com/repos/MakerDAO/maker-otc/issues/34","repository_url":"https://api.github.com/repos/MakerDAO/maker-otc","labels_url":"https://api.github.com/repos/MakerDAO/maker-otc/issues/34/labels{/name}","comments_url":"https://api.github.com/repos/MakerDAO/maker-otc/issues/34/comments","events_url":"https://api.github.com/repos/MakerDAO/maker-otc/issues/34/events","html_url":"https://github.com/MakerDAO/maker-otc/issues/34","id":149144769,"number":34,"title":"ci improvements","user":{"login":"rainbeam","id":18486361,"avatar_url":"https://avatars.githubusercontent.com/u/18486361?v=3","gravatar_id":"","url":"https://api.github.com/users/rainbeam","html_url":"https://github.com/rainbeam","followers_url":"https://api.github.com/users/rainbeam/followers","following_url":"https://api.github.com/users/rainbeam/following{/other_user}","gists_url":"https://api.github.com/users/rainbeam/gists{/gist_id}","starred_url":"https://api.github.com/users/rainbeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rainbeam/subscriptions","organizations_url":"https://api.github.com/users/rainbeam/orgs","repos_url":"https://api.github.com/users/rainbeam/repos","events_url":"https://api.github.com/users/rainbeam/events{/privacy}","received_events_url":"https://api.github.com/users/rainbeam/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-04-18T13:02:06Z","updated_at":"2016-06-28T09:45:47Z","closed_at":"2016-06-28T09:45:47Z","body":"Basic travis coverage implemented in #31. Various improvements that could be made:\r\n\r\n1. [ ] migrate dapple docker image to canonical location (currently rainbeam/dapple)\r\n2. [x] reduce size of docker image\r\n3. [x] add `npm test` to test script\r\n\r\n---\r\n**Image location** is currently at `rainbeam/dapple`, which is built from https://github.com/rainbeam/dapple-travis\r\n\r\nWould be nice to push this to a more central location e.g. `nexusdev/dapple-minimal`. Especially useful if this is used in a general dapple ci solution.\r\n\r\n---\r\n**Image size** is currently around 1GB. This can be reduced quite a lot for faster test setup. An ubuntu image with dapple and solc can be taken down to ~400MB, depending on violently you gut the OS and squash the fs layers. A minimal install based on Alpine can be brought down to 100MB (without solc).\r\n\r\n---\r\n**`npm test`** I'm not too familiar with the frontend, but maybe it has linters (semistandard?) that want checking. These could easily be added."},"comment":{"url":"https://api.github.com/repos/MakerDAO/maker-otc/issues/comments/229002589","html_url":"https://github.com/MakerDAO/maker-otc/issues/34#issuecomment-229002589","issue_url":"https://api.github.com/repos/MakerDAO/maker-otc/issues/34","id":229002589,"user":{"login":"cassiopaia","id":6280810,"avatar_url":"https://avatars.githubusercontent.com/u/6280810?v=3","gravatar_id":"","url":"https://api.github.com/users/cassiopaia","html_url":"https://github.com/cassiopaia","followers_url":"https://api.github.com/users/cassiopaia/followers","following_url":"https://api.github.com/users/cassiopaia/following{/other_user}","gists_url":"https://api.github.com/users/cassiopaia/gists{/gist_id}","starred_url":"https://api.github.com/users/cassiopaia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cassiopaia/subscriptions","organizations_url":"https://api.github.com/users/cassiopaia/orgs","repos_url":"https://api.github.com/users/cassiopaia/repos","events_url":"https://api.github.com/users/cassiopaia/events{/privacy}","received_events_url":"https://api.github.com/users/cassiopaia/received_events","type":"User","site_admin":false},"created_at":"2016-06-28T09:45:47Z","updated_at":"2016-06-28T09:45:47Z","body":"https://github.com/MakerDAO/maker-market/issues/6"}}
{"actor":{"display_login":"cassiopaia"}}