{"action":"created","comment":{"url":"https://api.github.com/repos/w0rp/ale/pulls/comments/82918049","pull_request_review_id":3791730,"id":82918049,"diff_hunk":"@@ -1,8 +1,10 @@\n----","path":".travis.yml","position":null,"original_position":1,"commit_id":"1548d40f45ed766fd6a4a34f07afca36acbd4faf","original_commit_id":"3245f5d9fc223a41fc17260bcc356e7ba203fff5","user":{"login":"prashcr","id":7514066,"avatar_url":"https://avatars.githubusercontent.com/u/7514066?v=3","gravatar_id":"","url":"https://api.github.com/users/prashcr","html_url":"https://github.com/prashcr","followers_url":"https://api.github.com/users/prashcr/followers","following_url":"https://api.github.com/users/prashcr/following{/other_user}","gists_url":"https://api.github.com/users/prashcr/gists{/gist_id}","starred_url":"https://api.github.com/users/prashcr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prashcr/subscriptions","organizations_url":"https://api.github.com/users/prashcr/orgs","repos_url":"https://api.github.com/users/prashcr/repos","events_url":"https://api.github.com/users/prashcr/events{/privacy}","received_events_url":"https://api.github.com/users/prashcr/received_events","type":"User","site_admin":false},"body":"done","created_at":"2016-10-12T00:40:07Z","updated_at":"2016-10-12T00:40:07Z","html_url":"https://github.com/w0rp/ale/pull/88#discussion_r82918049","pull_request_url":"https://api.github.com/repos/w0rp/ale/pulls/88","_links":{"self":{"href":"https://api.github.com/repos/w0rp/ale/pulls/comments/82918049"},"html":{"href":"https://github.com/w0rp/ale/pull/88#discussion_r82918049"},"pull_request":{"href":"https://api.github.com/repos/w0rp/ale/pulls/88"}}},"pull_request":{"url":"https://api.github.com/repos/w0rp/ale/pulls/88","id":88771564,"html_url":"https://github.com/w0rp/ale/pull/88","diff_url":"https://github.com/w0rp/ale/pull/88.diff","patch_url":"https://github.com/w0rp/ale/pull/88.patch","issue_url":"https://api.github.com/repos/w0rp/ale/issues/88","number":88,"state":"open","locked":false,"title":"Use vim-testbed to run Vader tests on Travis","user":{"login":"prashcr","id":7514066,"avatar_url":"https://avatars.githubusercontent.com/u/7514066?v=3","gravatar_id":"","url":"https://api.github.com/users/prashcr","html_url":"https://github.com/prashcr","followers_url":"https://api.github.com/users/prashcr/followers","following_url":"https://api.github.com/users/prashcr/following{/other_user}","gists_url":"https://api.github.com/users/prashcr/gists{/gist_id}","starred_url":"https://api.github.com/users/prashcr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prashcr/subscriptions","organizations_url":"https://api.github.com/users/prashcr/orgs","repos_url":"https://api.github.com/users/prashcr/repos","events_url":"https://api.github.com/users/prashcr/events{/privacy}","received_events_url":"https://api.github.com/users/prashcr/received_events","type":"User","site_admin":false},"body":"In addition to the current `vint` script currently on Travis, I added infrastructure for automated testing with Vader inside a Docker container with multiple vim builds that are cached on Docker Hub.\r\n\r\nMost of what I wrote is copied from https://github.com/tweekmonster/vim-testbed/tree/master/example, except I created a [new Docker image](https://hub.docker.com/r/prashcr/vim8s/) based on vim-testbed containing vim v8.0.0000 and v8.0.0027.\r\n\r\nIt was quite a lot for me to wrap my head around at first as well, but I'm convinced the benefits are worth it.  I understand the Makefile and Docker Hub image can be a bit daunting. However, from a tester's perspective, all they need to know is that\r\n1. tests go in `test/`\r\n2. they can modify the `vimrc` there which is used in tests\r\n\r\nAs this is quite a lot already for one PR so I only included a very basic Vader test as an example.\r\n\r\n### Versus our current approach\r\n* Our current approach limits us to whatever version of vim is installed on Ubuntu 12.04, which happens to be v7.3.429 and is useless for testing a vim 8 plugin. The only alternate solution is to build vim from source for every Travis build, but this is messy and takes minutes.\r\n* OS-agnostic testing of multiple vim versions\r\n* Travis builds in seconds, not minutes, allowing for quicker iterations during development\r\n* Contributors just need to link their Github to Travis and push to their fork to run tests, no need to install vint or vader\r\n* Eventual Neovim support https://github.com/tweekmonster/vim-testbed/issues/1\r\n\r\n#59\r\n\r\n@KabbAmine Try running adding your Vader tests to this and let me know how it goes.","created_at":"2016-10-11T05:02:25Z","updated_at":"2016-10-12T00:40:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4f387ce2461615d58063f48559e010c80a7da2c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/w0rp/ale/pulls/88/commits","review_comments_url":"https://api.github.com/repos/w0rp/ale/pulls/88/comments","review_comment_url":"https://api.github.com/repos/w0rp/ale/pulls/comments{/number}","comments_url":"https://api.github.com/repos/w0rp/ale/issues/88/comments","statuses_url":"https://api.github.com/repos/w0rp/ale/statuses/1548d40f45ed766fd6a4a34f07afca36acbd4faf","head":{"label":"prashcr:master","ref":"master","sha":"1548d40f45ed766fd6a4a34f07afca36acbd4faf","user":{"login":"prashcr","id":7514066,"avatar_url":"https://avatars.githubusercontent.com/u/7514066?v=3","gravatar_id":"","url":"https://api.github.com/users/prashcr","html_url":"https://github.com/prashcr","followers_url":"https://api.github.com/users/prashcr/followers","following_url":"https://api.github.com/users/prashcr/following{/other_user}","gists_url":"https://api.github.com/users/prashcr/gists{/gist_id}","starred_url":"https://api.github.com/users/prashcr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prashcr/subscriptions","organizations_url":"https://api.github.com/users/prashcr/orgs","repos_url":"https://api.github.com/users/prashcr/repos","events_url":"https://api.github.com/users/prashcr/events{/privacy}","received_events_url":"https://api.github.com/users/prashcr/received_events","type":"User","site_admin":false},"repo":{"id":68443546,"name":"ale","full_name":"prashcr/ale","owner":{"login":"prashcr","id":7514066,"avatar_url":"https://avatars.githubusercontent.com/u/7514066?v=3","gravatar_id":"","url":"https://api.github.com/users/prashcr","html_url":"https://github.com/prashcr","followers_url":"https://api.github.com/users/prashcr/followers","following_url":"https://api.github.com/users/prashcr/following{/other_user}","gists_url":"https://api.github.com/users/prashcr/gists{/gist_id}","starred_url":"https://api.github.com/users/prashcr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prashcr/subscriptions","organizations_url":"https://api.github.com/users/prashcr/orgs","repos_url":"https://api.github.com/users/prashcr/repos","events_url":"https://api.github.com/users/prashcr/events{/privacy}","received_events_url":"https://api.github.com/users/prashcr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/prashcr/ale","description":"Asynchronous Lint Engine","fork":true,"url":"https://api.github.com/repos/prashcr/ale","forks_url":"https://api.github.com/repos/prashcr/ale/forks","keys_url":"https://api.github.com/repos/prashcr/ale/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prashcr/ale/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prashcr/ale/teams","hooks_url":"https://api.github.com/repos/prashcr/ale/hooks","issue_events_url":"https://api.github.com/repos/prashcr/ale/issues/events{/number}","events_url":"https://api.github.com/repos/prashcr/ale/events","assignees_url":"https://api.github.com/repos/prashcr/ale/assignees{/user}","branches_url":"https://api.github.com/repos/prashcr/ale/branches{/branch}","tags_url":"https://api.github.com/repos/prashcr/ale/tags","blobs_url":"https://api.github.com/repos/prashcr/ale/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prashcr/ale/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prashcr/ale/git/refs{/sha}","trees_url":"https://api.github.com/repos/prashcr/ale/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prashcr/ale/statuses/{sha}","languages_url":"https://api.github.com/repos/prashcr/ale/languages","stargazers_url":"https://api.github.com/repos/prashcr/ale/stargazers","contributors_url":"https://api.github.com/repos/prashcr/ale/contributors","subscribers_url":"https://api.github.com/repos/prashcr/ale/subscribers","subscription_url":"https://api.github.com/repos/prashcr/ale/subscription","commits_url":"https://api.github.com/repos/prashcr/ale/commits{/sha}","git_commits_url":"https://api.github.com/repos/prashcr/ale/git/commits{/sha}","comments_url":"https://api.github.com/repos/prashcr/ale/comments{/number}","issue_comment_url":"https://api.github.com/repos/prashcr/ale/issues/comments{/number}","contents_url":"https://api.github.com/repos/prashcr/ale/contents/{+path}","compare_url":"https://api.github.com/repos/prashcr/ale/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prashcr/ale/merges","archive_url":"https://api.github.com/repos/prashcr/ale/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prashcr/ale/downloads","issues_url":"https://api.github.com/repos/prashcr/ale/issues{/number}","pulls_url":"https://api.github.com/repos/prashcr/ale/pulls{/number}","milestones_url":"https://api.github.com/repos/prashcr/ale/milestones{/number}","notifications_url":"https://api.github.com/repos/prashcr/ale/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prashcr/ale/labels{/name}","releases_url":"https://api.github.com/repos/prashcr/ale/releases{/id}","deployments_url":"https://api.github.com/repos/prashcr/ale/deployments","created_at":"2016-09-17T09:30:20Z","updated_at":"2016-09-17T09:30:20Z","pushed_at":"2016-10-12T00:39:12Z","git_url":"git://github.com/prashcr/ale.git","ssh_url":"git@github.com:prashcr/ale.git","clone_url":"https://github.com/prashcr/ale.git","svn_url":"https://github.com/prashcr/ale","homepage":null,"size":3758,"stargazers_count":0,"watchers_count":0,"language":"VimL","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"w0rp:master","ref":"master","sha":"5e0f33615e8ac0dd8b9ec2a46c41d7cd7f2387df","user":{"login":"w0rp","id":3518142,"avatar_url":"https://avatars.githubusercontent.com/u/3518142?v=3","gravatar_id":"","url":"https://api.github.com/users/w0rp","html_url":"https://github.com/w0rp","followers_url":"https://api.github.com/users/w0rp/followers","following_url":"https://api.github.com/users/w0rp/following{/other_user}","gists_url":"https://api.github.com/users/w0rp/gists{/gist_id}","starred_url":"https://api.github.com/users/w0rp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w0rp/subscriptions","organizations_url":"https://api.github.com/users/w0rp/orgs","repos_url":"https://api.github.com/users/w0rp/repos","events_url":"https://api.github.com/users/w0rp/events{/privacy}","received_events_url":"https://api.github.com/users/w0rp/received_events","type":"User","site_admin":false},"repo":{"id":67747748,"name":"ale","full_name":"w0rp/ale","owner":{"login":"w0rp","id":3518142,"avatar_url":"https://avatars.githubusercontent.com/u/3518142?v=3","gravatar_id":"","url":"https://api.github.com/users/w0rp","html_url":"https://github.com/w0rp","followers_url":"https://api.github.com/users/w0rp/followers","following_url":"https://api.github.com/users/w0rp/following{/other_user}","gists_url":"https://api.github.com/users/w0rp/gists{/gist_id}","starred_url":"https://api.github.com/users/w0rp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w0rp/subscriptions","organizations_url":"https://api.github.com/users/w0rp/orgs","repos_url":"https://api.github.com/users/w0rp/repos","events_url":"https://api.github.com/users/w0rp/events{/privacy}","received_events_url":"https://api.github.com/users/w0rp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/w0rp/ale","description":"Asynchronous Lint Engine","fork":false,"url":"https://api.github.com/repos/w0rp/ale","forks_url":"https://api.github.com/repos/w0rp/ale/forks","keys_url":"https://api.github.com/repos/w0rp/ale/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w0rp/ale/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w0rp/ale/teams","hooks_url":"https://api.github.com/repos/w0rp/ale/hooks","issue_events_url":"https://api.github.com/repos/w0rp/ale/issues/events{/number}","events_url":"https://api.github.com/repos/w0rp/ale/events","assignees_url":"https://api.github.com/repos/w0rp/ale/assignees{/user}","branches_url":"https://api.github.com/repos/w0rp/ale/branches{/branch}","tags_url":"https://api.github.com/repos/w0rp/ale/tags","blobs_url":"https://api.github.com/repos/w0rp/ale/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w0rp/ale/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w0rp/ale/git/refs{/sha}","trees_url":"https://api.github.com/repos/w0rp/ale/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w0rp/ale/statuses/{sha}","languages_url":"https://api.github.com/repos/w0rp/ale/languages","stargazers_url":"https://api.github.com/repos/w0rp/ale/stargazers","contributors_url":"https://api.github.com/repos/w0rp/ale/contributors","subscribers_url":"https://api.github.com/repos/w0rp/ale/subscribers","subscription_url":"https://api.github.com/repos/w0rp/ale/subscription","commits_url":"https://api.github.com/repos/w0rp/ale/commits{/sha}","git_commits_url":"https://api.github.com/repos/w0rp/ale/git/commits{/sha}","comments_url":"https://api.github.com/repos/w0rp/ale/comments{/number}","issue_comment_url":"https://api.github.com/repos/w0rp/ale/issues/comments{/number}","contents_url":"https://api.github.com/repos/w0rp/ale/contents/{+path}","compare_url":"https://api.github.com/repos/w0rp/ale/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w0rp/ale/merges","archive_url":"https://api.github.com/repos/w0rp/ale/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w0rp/ale/downloads","issues_url":"https://api.github.com/repos/w0rp/ale/issues{/number}","pulls_url":"https://api.github.com/repos/w0rp/ale/pulls{/number}","milestones_url":"https://api.github.com/repos/w0rp/ale/milestones{/number}","notifications_url":"https://api.github.com/repos/w0rp/ale/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w0rp/ale/labels{/name}","releases_url":"https://api.github.com/repos/w0rp/ale/releases{/id}","deployments_url":"https://api.github.com/repos/w0rp/ale/deployments","created_at":"2016-09-08T23:22:45Z","updated_at":"2016-10-11T20:18:02Z","pushed_at":"2016-10-12T00:39:13Z","git_url":"git://github.com/w0rp/ale.git","ssh_url":"git@github.com:w0rp/ale.git","clone_url":"https://github.com/w0rp/ale.git","svn_url":"https://github.com/w0rp/ale","homepage":null,"size":21681,"stargazers_count":96,"watchers_count":96,"language":"VimL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":9,"forks":16,"open_issues":9,"watchers":96,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/w0rp/ale/pulls/88"},"html":{"href":"https://github.com/w0rp/ale/pull/88"},"issue":{"href":"https://api.github.com/repos/w0rp/ale/issues/88"},"comments":{"href":"https://api.github.com/repos/w0rp/ale/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/w0rp/ale/pulls/88/comments"},"review_comment":{"href":"https://api.github.com/repos/w0rp/ale/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/w0rp/ale/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/w0rp/ale/statuses/1548d40f45ed766fd6a4a34f07afca36acbd4faf"}}}}
{"actor":{"display_login":"prashcr"}}