{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/4533","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/4533/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/4533/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/4533/events","html_url":"https://github.com/cockroachdb/cockroach/pull/4533","id":135028535,"number":4533,"title":"acceptance: cleanup","user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-02-20T03:41:46Z","updated_at":"2016-02-20T17:05:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/4533","html_url":"https://github.com/cockroachdb/cockroach/pull/4533","diff_url":"https://github.com/cockroachdb/cockroach/pull/4533.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/4533.patch"},"body":"Update dependencies while I'm here.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.svg\" height=\"40\" alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/4533)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/186655123","html_url":"https://github.com/cockroachdb/cockroach/pull/4533#issuecomment-186655123","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/4533","id":186655123,"user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"created_at":"2016-02-20T17:05:39Z","updated_at":"2016-02-20T17:05:39Z","body":"\n\n\n\nReview status: 0 of 4 files reviewed at latest revision, 2 unresolved discussions.\n\n---\n\n*[acceptance/cluster/docker.go, line 72 \\[r1\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/4533#-KAzbXMyKC3vFYY72xop:-KAzctRJg57hdSTD9lcs:807326756) ([raw file](https://github.com/cockroachdb/cockroach/blob/124acfddc82dd2eb65a4ce378818d45911807fa1/acceptance/cluster/docker.go#L72)):*\nI think all the callers to this do that. No need to make this less general.\n\n---\n\n*[acceptance/cluster/docker.go, line 84 \\[r1\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/4533#-KAzb75_cEVTYpS4gh5w:-KAzczSORH5mu3XRcKDN:678157164) ([raw file](https://github.com/cockroachdb/cockroach/blob/124acfddc82dd2eb65a4ce378818d45911807fa1/acceptance/cluster/docker.go#L84)):*\nA few reasons:\n- performance (doesn't matter here)\n- specificity; a more specific interface might be able to print more nicely\n- strictness; we might want to blow up if we get something unexpected back\n\n---\n\n\n*Comments from the [review on Reviewable.io](https://reviewable.io:443/reviews/cockroachdb/cockroach/4533)*\n<!-- Sent from Reviewable.io -->\n"}}