{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/561","repository_url":"https://api.github.com/repos/GoogleChrome/lighthouse","labels_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/561/labels{/name}","comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/561/comments","events_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/561/events","html_url":"https://github.com/GoogleChrome/lighthouse/pull/561","id":169496505,"number":561,"title":"handle new trace object format","user":{"login":"brendankenny","id":316891,"avatar_url":"https://avatars.githubusercontent.com/u/316891?v=3","gravatar_id":"","url":"https://api.github.com/users/brendankenny","html_url":"https://github.com/brendankenny","followers_url":"https://api.github.com/users/brendankenny/followers","following_url":"https://api.github.com/users/brendankenny/following{/other_user}","gists_url":"https://api.github.com/users/brendankenny/gists{/gist_id}","starred_url":"https://api.github.com/users/brendankenny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendankenny/subscriptions","organizations_url":"https://api.github.com/users/brendankenny/orgs","repos_url":"https://api.github.com/users/brendankenny/repos","events_url":"https://api.github.com/users/brendankenny/events{/privacy}","received_events_url":"https://api.github.com/users/brendankenny/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-04T23:23:00Z","updated_at":"2016-08-05T00:00:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/561","html_url":"https://github.com/GoogleChrome/lighthouse/pull/561","diff_url":"https://github.com/GoogleChrome/lighthouse/pull/561.diff","patch_url":"https://github.com/GoogleChrome/lighthouse/pull/561.patch"},"body":"Fixes #555 \r\n\r\nWith https://codereview.chromium.org/2161583004 the trace object we get is slightly different, with the trace events array as a `traceEvents` property on the object instead of as the object itself. This was causing all -1s in the performance test as they couldn't understand the updated trace format.\r\n\r\nOn the simplest level, this PR moves `artifacts.traces` from something like\r\n```\r\nartifacts.traces = {\r\n  defaultPass: {\r\n    traceContents: [/* trace events */]\r\n  }\r\n}\r\n```\r\n\r\nto \r\n```\r\nartifacts.traces = {\r\n  defaultPass: {\r\n    traceEvents: [/* trace events */],\r\n    metaData: { /* trace meta data */}\r\n  }\r\n}\r\n```\r\nand then the rest of the PR is just fixing import and export code to handle both the new and the old trace object formats."},"comment":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/comments/237721124","html_url":"https://github.com/GoogleChrome/lighthouse/pull/561#issuecomment-237721124","issue_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/561","id":237721124,"user":{"login":"paulirish","id":39191,"avatar_url":"https://avatars.githubusercontent.com/u/39191?v=3","gravatar_id":"","url":"https://api.github.com/users/paulirish","html_url":"https://github.com/paulirish","followers_url":"https://api.github.com/users/paulirish/followers","following_url":"https://api.github.com/users/paulirish/following{/other_user}","gists_url":"https://api.github.com/users/paulirish/gists{/gist_id}","starred_url":"https://api.github.com/users/paulirish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulirish/subscriptions","organizations_url":"https://api.github.com/users/paulirish/orgs","repos_url":"https://api.github.com/users/paulirish/repos","events_url":"https://api.github.com/users/paulirish/events{/privacy}","received_events_url":"https://api.github.com/users/paulirish/received_events","type":"User","site_admin":false},"created_at":"2016-08-05T00:00:28Z","updated_at":"2016-08-05T00:00:28Z","body":"cc @michaelgerakis if you rely on the string `traceContents` in your integration, this will break you. "}}
{"actor":{"display_login":"paulirish"}}