{"action":"opened","number":3658,"pull_request":{"url":"https://api.github.com/repos/videojs/video.js/pulls/3658","id":87413568,"html_url":"https://github.com/videojs/video.js/pull/3658","diff_url":"https://github.com/videojs/video.js/pull/3658.diff","patch_url":"https://github.com/videojs/video.js/pull/3658.patch","issue_url":"https://api.github.com/repos/videojs/video.js/issues/3658","number":3658,"state":"open","locked":false,"title":"style(_progress): Provide padding for the `vjs-progress-holder` while…","user":{"login":"chemoish","id":549319,"avatar_url":"https://avatars.githubusercontent.com/u/549319?v=3","gravatar_id":"","url":"https://api.github.com/users/chemoish","html_url":"https://github.com/chemoish","followers_url":"https://api.github.com/users/chemoish/followers","following_url":"https://api.github.com/users/chemoish/following{/other_user}","gists_url":"https://api.github.com/users/chemoish/gists{/gist_id}","starred_url":"https://api.github.com/users/chemoish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chemoish/subscriptions","organizations_url":"https://api.github.com/users/chemoish/orgs","repos_url":"https://api.github.com/users/chemoish/repos","events_url":"https://api.github.com/users/chemoish/events{/privacy}","received_events_url":"https://api.github.com/users/chemoish/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nFixes https://github.com/videojs/video.js/issues/3645. Looks like it doesn't effect `volume-bar`,  which is the only other dependent of `Slider`, because it manages its own margins. SEE: https://github.com/videojs/video.js/blob/master/src/css/components/_volume.scss#L28\r\n\r\n## Specific Changes proposed\r\n\r\n![image](https://cloud.githubusercontent.com/assets/549319/18975972/175f7b5a-8663-11e6-8f36-7e3f99f5ee8b.png)\r\n\r\n## Requirements Checklist\r\n- [ ] Feature implemented / Bug fixed\r\n- [ ] If necessary, more likely in a feature request than a bug fix\r\n  - [ ] Unit Tests updated or fixed\r\n  - [ ] Docs/guides updated\r\n  - [ ] Example created ([starter template on JSBin](http://jsbin.com/axedog/edit?html,output))\r\n- [ ] Reviewed by Two Core Contributors\r\n\r\n… allowing it to resize on hover. Thereby containing the `MouseTimeDisplay` to the `vjs-progress-holder` instead of it bleeding outside.\r\n\r\nNOTE: Guessing that the margin was put in place to provide some spacing between the slider and the surrounding controls. Because the slider itself, or rather, `vjs-progress-holder` becomes larger on hover, we cannot have the \"padding\" also be responsive on the same element.","created_at":"2016-09-29T23:43:53Z","updated_at":"2016-09-29T23:43:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/videojs/video.js/pulls/3658/commits","review_comments_url":"https://api.github.com/repos/videojs/video.js/pulls/3658/comments","review_comment_url":"https://api.github.com/repos/videojs/video.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/videojs/video.js/issues/3658/comments","statuses_url":"https://api.github.com/repos/videojs/video.js/statuses/708d4ad901053cc7e337c454cc393abf3e0bcf99","head":{"label":"chemoish:feature/style-mouse-time-display","ref":"feature/style-mouse-time-display","sha":"708d4ad901053cc7e337c454cc393abf3e0bcf99","user":{"login":"chemoish","id":549319,"avatar_url":"https://avatars.githubusercontent.com/u/549319?v=3","gravatar_id":"","url":"https://api.github.com/users/chemoish","html_url":"https://github.com/chemoish","followers_url":"https://api.github.com/users/chemoish/followers","following_url":"https://api.github.com/users/chemoish/following{/other_user}","gists_url":"https://api.github.com/users/chemoish/gists{/gist_id}","starred_url":"https://api.github.com/users/chemoish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chemoish/subscriptions","organizations_url":"https://api.github.com/users/chemoish/orgs","repos_url":"https://api.github.com/users/chemoish/repos","events_url":"https://api.github.com/users/chemoish/events{/privacy}","received_events_url":"https://api.github.com/users/chemoish/received_events","type":"User","site_admin":false},"repo":{"id":40019264,"name":"video.js","full_name":"chemoish/video.js","owner":{"login":"chemoish","id":549319,"avatar_url":"https://avatars.githubusercontent.com/u/549319?v=3","gravatar_id":"","url":"https://api.github.com/users/chemoish","html_url":"https://github.com/chemoish","followers_url":"https://api.github.com/users/chemoish/followers","following_url":"https://api.github.com/users/chemoish/following{/other_user}","gists_url":"https://api.github.com/users/chemoish/gists{/gist_id}","starred_url":"https://api.github.com/users/chemoish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chemoish/subscriptions","organizations_url":"https://api.github.com/users/chemoish/orgs","repos_url":"https://api.github.com/users/chemoish/repos","events_url":"https://api.github.com/users/chemoish/events{/privacy}","received_events_url":"https://api.github.com/users/chemoish/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chemoish/video.js","description":"Video.js - open source HTML5 & Flash video player","fork":true,"url":"https://api.github.com/repos/chemoish/video.js","forks_url":"https://api.github.com/repos/chemoish/video.js/forks","keys_url":"https://api.github.com/repos/chemoish/video.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chemoish/video.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chemoish/video.js/teams","hooks_url":"https://api.github.com/repos/chemoish/video.js/hooks","issue_events_url":"https://api.github.com/repos/chemoish/video.js/issues/events{/number}","events_url":"https://api.github.com/repos/chemoish/video.js/events","assignees_url":"https://api.github.com/repos/chemoish/video.js/assignees{/user}","branches_url":"https://api.github.com/repos/chemoish/video.js/branches{/branch}","tags_url":"https://api.github.com/repos/chemoish/video.js/tags","blobs_url":"https://api.github.com/repos/chemoish/video.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chemoish/video.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chemoish/video.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/chemoish/video.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chemoish/video.js/statuses/{sha}","languages_url":"https://api.github.com/repos/chemoish/video.js/languages","stargazers_url":"https://api.github.com/repos/chemoish/video.js/stargazers","contributors_url":"https://api.github.com/repos/chemoish/video.js/contributors","subscribers_url":"https://api.github.com/repos/chemoish/video.js/subscribers","subscription_url":"https://api.github.com/repos/chemoish/video.js/subscription","commits_url":"https://api.github.com/repos/chemoish/video.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/chemoish/video.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/chemoish/video.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/chemoish/video.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/chemoish/video.js/contents/{+path}","compare_url":"https://api.github.com/repos/chemoish/video.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chemoish/video.js/merges","archive_url":"https://api.github.com/repos/chemoish/video.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chemoish/video.js/downloads","issues_url":"https://api.github.com/repos/chemoish/video.js/issues{/number}","pulls_url":"https://api.github.com/repos/chemoish/video.js/pulls{/number}","milestones_url":"https://api.github.com/repos/chemoish/video.js/milestones{/number}","notifications_url":"https://api.github.com/repos/chemoish/video.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chemoish/video.js/labels{/name}","releases_url":"https://api.github.com/repos/chemoish/video.js/releases{/id}","deployments_url":"https://api.github.com/repos/chemoish/video.js/deployments","created_at":"2015-07-31T18:30:05Z","updated_at":"2016-03-15T21:31:05Z","pushed_at":"2016-09-29T23:36:49Z","git_url":"git://github.com/chemoish/video.js.git","ssh_url":"git@github.com:chemoish/video.js.git","clone_url":"https://github.com/chemoish/video.js.git","svn_url":"https://github.com/chemoish/video.js","homepage":"www.videojs.com","size":44635,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"videojs:master","ref":"master","sha":"ae3e27788db2ad2386f7194ffd2ac1aa9321f74e","user":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"repo":{"id":667006,"name":"video.js","full_name":"videojs/video.js","owner":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/videojs/video.js","description":"Video.js - open source HTML5 & Flash video player","fork":false,"url":"https://api.github.com/repos/videojs/video.js","forks_url":"https://api.github.com/repos/videojs/video.js/forks","keys_url":"https://api.github.com/repos/videojs/video.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/videojs/video.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/videojs/video.js/teams","hooks_url":"https://api.github.com/repos/videojs/video.js/hooks","issue_events_url":"https://api.github.com/repos/videojs/video.js/issues/events{/number}","events_url":"https://api.github.com/repos/videojs/video.js/events","assignees_url":"https://api.github.com/repos/videojs/video.js/assignees{/user}","branches_url":"https://api.github.com/repos/videojs/video.js/branches{/branch}","tags_url":"https://api.github.com/repos/videojs/video.js/tags","blobs_url":"https://api.github.com/repos/videojs/video.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/videojs/video.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/videojs/video.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/videojs/video.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/videojs/video.js/statuses/{sha}","languages_url":"https://api.github.com/repos/videojs/video.js/languages","stargazers_url":"https://api.github.com/repos/videojs/video.js/stargazers","contributors_url":"https://api.github.com/repos/videojs/video.js/contributors","subscribers_url":"https://api.github.com/repos/videojs/video.js/subscribers","subscription_url":"https://api.github.com/repos/videojs/video.js/subscription","commits_url":"https://api.github.com/repos/videojs/video.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/videojs/video.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/videojs/video.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/videojs/video.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/videojs/video.js/contents/{+path}","compare_url":"https://api.github.com/repos/videojs/video.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/videojs/video.js/merges","archive_url":"https://api.github.com/repos/videojs/video.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/videojs/video.js/downloads","issues_url":"https://api.github.com/repos/videojs/video.js/issues{/number}","pulls_url":"https://api.github.com/repos/videojs/video.js/pulls{/number}","milestones_url":"https://api.github.com/repos/videojs/video.js/milestones{/number}","notifications_url":"https://api.github.com/repos/videojs/video.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/videojs/video.js/labels{/name}","releases_url":"https://api.github.com/repos/videojs/video.js/releases{/id}","deployments_url":"https://api.github.com/repos/videojs/video.js/deployments","created_at":"2010-05-14T18:45:10Z","updated_at":"2016-09-29T23:05:05Z","pushed_at":"2016-09-29T22:05:46Z","git_url":"git://github.com/videojs/video.js.git","ssh_url":"git@github.com:videojs/video.js.git","clone_url":"https://github.com/videojs/video.js.git","svn_url":"https://github.com/videojs/video.js","homepage":"www.videojs.com","size":112610,"stargazers_count":13716,"watchers_count":13716,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":3992,"mirror_url":null,"open_issues_count":201,"forks":3992,"open_issues":201,"watchers":13716,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/videojs/video.js/pulls/3658"},"html":{"href":"https://github.com/videojs/video.js/pull/3658"},"issue":{"href":"https://api.github.com/repos/videojs/video.js/issues/3658"},"comments":{"href":"https://api.github.com/repos/videojs/video.js/issues/3658/comments"},"review_comments":{"href":"https://api.github.com/repos/videojs/video.js/pulls/3658/comments"},"review_comment":{"href":"https://api.github.com/repos/videojs/video.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/videojs/video.js/pulls/3658/commits"},"statuses":{"href":"https://api.github.com/repos/videojs/video.js/statuses/708d4ad901053cc7e337c454cc393abf3e0bcf99"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"chemoish"}}