{"action":"created","comment":{"url":"https://api.github.com/repos/mathiasbynens/Array.from/pulls/comments/79126851","id":79126851,"diff_hunk":"@@ -114,13 +116,10 @@ if ('Map' in global) {\n var usingIterator = function (items) {\n \tif (has(items, iteratorSymbol)) {\n \t\treturn items[iteratorSymbol]();\n-\t} else if ('Set' in global && 'Map' in global && isCallable(items.entries) && isCallable(items.values)) {\n-\t\tif (isSet(items)) {\n-\t\t\treturn items.values();\n-\t\t}\n-\t\tif (isMap(items)) {\n-\t\t\treturn items.entries();\n-\t\t}\n+\t} else if (hasMap && isMap(items)) {\n+\t\treturn items.entries();","path":"implementation.js","position":60,"original_position":60,"commit_id":"635b2f5ebbd64caa77b5e1549b3bd6af98019bb2","original_commit_id":"635b2f5ebbd64caa77b5e1549b3bd6af98019bb2","user":{"login":"ljharb","id":45469,"avatar_url":"https://avatars.githubusercontent.com/u/45469?v=3","gravatar_id":"","url":"https://api.github.com/users/ljharb","html_url":"https://github.com/ljharb","followers_url":"https://api.github.com/users/ljharb/followers","following_url":"https://api.github.com/users/ljharb/following{/other_user}","gists_url":"https://api.github.com/users/ljharb/gists{/gist_id}","starred_url":"https://api.github.com/users/ljharb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljharb/subscriptions","organizations_url":"https://api.github.com/users/ljharb/orgs","repos_url":"https://api.github.com/users/ljharb/repos","events_url":"https://api.github.com/users/ljharb/events{/privacy}","received_events_url":"https://api.github.com/users/ljharb/received_events","type":"User","site_admin":false},"body":"still looking for `entries.call(items)` where `entries` is `var entries = hasMap && Map.prototype.entries;`","created_at":"2016-09-16T08:34:10Z","updated_at":"2016-09-16T08:34:33Z","html_url":"https://github.com/mathiasbynens/Array.from/pull/35#discussion_r79126851","pull_request_url":"https://api.github.com/repos/mathiasbynens/Array.from/pulls/35","_links":{"self":{"href":"https://api.github.com/repos/mathiasbynens/Array.from/pulls/comments/79126851"},"html":{"href":"https://github.com/mathiasbynens/Array.from/pull/35#discussion_r79126851"},"pull_request":{"href":"https://api.github.com/repos/mathiasbynens/Array.from/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/mathiasbynens/Array.from/pulls/35","id":85529682,"html_url":"https://github.com/mathiasbynens/Array.from/pull/35","diff_url":"https://github.com/mathiasbynens/Array.from/pull/35.diff","patch_url":"https://github.com/mathiasbynens/Array.from/pull/35.patch","issue_url":"https://api.github.com/repos/mathiasbynens/Array.from/issues/35","number":35,"state":"open","locked":false,"title":"Segregate Map and Set object detections","user":{"login":"falsandtru","id":3143368,"avatar_url":"https://avatars.githubusercontent.com/u/3143368?v=3","gravatar_id":"","url":"https://api.github.com/users/falsandtru","html_url":"https://github.com/falsandtru","followers_url":"https://api.github.com/users/falsandtru/followers","following_url":"https://api.github.com/users/falsandtru/following{/other_user}","gists_url":"https://api.github.com/users/falsandtru/gists{/gist_id}","starred_url":"https://api.github.com/users/falsandtru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/falsandtru/subscriptions","organizations_url":"https://api.github.com/users/falsandtru/orgs","repos_url":"https://api.github.com/users/falsandtru/repos","events_url":"https://api.github.com/users/falsandtru/events{/privacy}","received_events_url":"https://api.github.com/users/falsandtru/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-16T07:30:51Z","updated_at":"2016-09-16T08:34:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3661f0f69afc641bc3e744150a9976b48f3fa7fb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mathiasbynens/Array.from/pulls/35/commits","review_comments_url":"https://api.github.com/repos/mathiasbynens/Array.from/pulls/35/comments","review_comment_url":"https://api.github.com/repos/mathiasbynens/Array.from/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mathiasbynens/Array.from/issues/35/comments","statuses_url":"https://api.github.com/repos/mathiasbynens/Array.from/statuses/635b2f5ebbd64caa77b5e1549b3bd6af98019bb2","head":{"label":"falsandtru:collection","ref":"collection","sha":"635b2f5ebbd64caa77b5e1549b3bd6af98019bb2","user":{"login":"falsandtru","id":3143368,"avatar_url":"https://avatars.githubusercontent.com/u/3143368?v=3","gravatar_id":"","url":"https://api.github.com/users/falsandtru","html_url":"https://github.com/falsandtru","followers_url":"https://api.github.com/users/falsandtru/followers","following_url":"https://api.github.com/users/falsandtru/following{/other_user}","gists_url":"https://api.github.com/users/falsandtru/gists{/gist_id}","starred_url":"https://api.github.com/users/falsandtru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/falsandtru/subscriptions","organizations_url":"https://api.github.com/users/falsandtru/orgs","repos_url":"https://api.github.com/users/falsandtru/repos","events_url":"https://api.github.com/users/falsandtru/events{/privacy}","received_events_url":"https://api.github.com/users/falsandtru/received_events","type":"User","site_admin":false},"repo":{"id":66007256,"name":"Array.from","full_name":"falsandtru/Array.from","owner":{"login":"falsandtru","id":3143368,"avatar_url":"https://avatars.githubusercontent.com/u/3143368?v=3","gravatar_id":"","url":"https://api.github.com/users/falsandtru","html_url":"https://github.com/falsandtru","followers_url":"https://api.github.com/users/falsandtru/followers","following_url":"https://api.github.com/users/falsandtru/following{/other_user}","gists_url":"https://api.github.com/users/falsandtru/gists{/gist_id}","starred_url":"https://api.github.com/users/falsandtru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/falsandtru/subscriptions","organizations_url":"https://api.github.com/users/falsandtru/orgs","repos_url":"https://api.github.com/users/falsandtru/repos","events_url":"https://api.github.com/users/falsandtru/events{/privacy}","received_events_url":"https://api.github.com/users/falsandtru/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/falsandtru/Array.from","description":"A robust & optimized ES3-compatible polyfill for the `Array.from` method in ECMAScript 6.","fork":true,"url":"https://api.github.com/repos/falsandtru/Array.from","forks_url":"https://api.github.com/repos/falsandtru/Array.from/forks","keys_url":"https://api.github.com/repos/falsandtru/Array.from/keys{/key_id}","collaborators_url":"https://api.github.com/repos/falsandtru/Array.from/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/falsandtru/Array.from/teams","hooks_url":"https://api.github.com/repos/falsandtru/Array.from/hooks","issue_events_url":"https://api.github.com/repos/falsandtru/Array.from/issues/events{/number}","events_url":"https://api.github.com/repos/falsandtru/Array.from/events","assignees_url":"https://api.github.com/repos/falsandtru/Array.from/assignees{/user}","branches_url":"https://api.github.com/repos/falsandtru/Array.from/branches{/branch}","tags_url":"https://api.github.com/repos/falsandtru/Array.from/tags","blobs_url":"https://api.github.com/repos/falsandtru/Array.from/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/falsandtru/Array.from/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/falsandtru/Array.from/git/refs{/sha}","trees_url":"https://api.github.com/repos/falsandtru/Array.from/git/trees{/sha}","statuses_url":"https://api.github.com/repos/falsandtru/Array.from/statuses/{sha}","languages_url":"https://api.github.com/repos/falsandtru/Array.from/languages","stargazers_url":"https://api.github.com/repos/falsandtru/Array.from/stargazers","contributors_url":"https://api.github.com/repos/falsandtru/Array.from/contributors","subscribers_url":"https://api.github.com/repos/falsandtru/Array.from/subscribers","subscription_url":"https://api.github.com/repos/falsandtru/Array.from/subscription","commits_url":"https://api.github.com/repos/falsandtru/Array.from/commits{/sha}","git_commits_url":"https://api.github.com/repos/falsandtru/Array.from/git/commits{/sha}","comments_url":"https://api.github.com/repos/falsandtru/Array.from/comments{/number}","issue_comment_url":"https://api.github.com/repos/falsandtru/Array.from/issues/comments{/number}","contents_url":"https://api.github.com/repos/falsandtru/Array.from/contents/{+path}","compare_url":"https://api.github.com/repos/falsandtru/Array.from/compare/{base}...{head}","merges_url":"https://api.github.com/repos/falsandtru/Array.from/merges","archive_url":"https://api.github.com/repos/falsandtru/Array.from/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/falsandtru/Array.from/downloads","issues_url":"https://api.github.com/repos/falsandtru/Array.from/issues{/number}","pulls_url":"https://api.github.com/repos/falsandtru/Array.from/pulls{/number}","milestones_url":"https://api.github.com/repos/falsandtru/Array.from/milestones{/number}","notifications_url":"https://api.github.com/repos/falsandtru/Array.from/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/falsandtru/Array.from/labels{/name}","releases_url":"https://api.github.com/repos/falsandtru/Array.from/releases{/id}","deployments_url":"https://api.github.com/repos/falsandtru/Array.from/deployments","created_at":"2016-08-18T15:09:58Z","updated_at":"2016-08-18T15:09:59Z","pushed_at":"2016-09-16T08:08:47Z","git_url":"git://github.com/falsandtru/Array.from.git","ssh_url":"git@github.com:falsandtru/Array.from.git","clone_url":"https://github.com/falsandtru/Array.from.git","svn_url":"https://github.com/falsandtru/Array.from","homepage":"https://mths.be/array-from","size":71,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mathiasbynens:master","ref":"master","sha":"5c7247658bbdddb8034c5c30758037457846cd1e","user":{"login":"mathiasbynens","id":81942,"avatar_url":"https://avatars.githubusercontent.com/u/81942?v=3","gravatar_id":"","url":"https://api.github.com/users/mathiasbynens","html_url":"https://github.com/mathiasbynens","followers_url":"https://api.github.com/users/mathiasbynens/followers","following_url":"https://api.github.com/users/mathiasbynens/following{/other_user}","gists_url":"https://api.github.com/users/mathiasbynens/gists{/gist_id}","starred_url":"https://api.github.com/users/mathiasbynens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathiasbynens/subscriptions","organizations_url":"https://api.github.com/users/mathiasbynens/orgs","repos_url":"https://api.github.com/users/mathiasbynens/repos","events_url":"https://api.github.com/users/mathiasbynens/events{/privacy}","received_events_url":"https://api.github.com/users/mathiasbynens/received_events","type":"User","site_admin":false},"repo":{"id":15342606,"name":"Array.from","full_name":"mathiasbynens/Array.from","owner":{"login":"mathiasbynens","id":81942,"avatar_url":"https://avatars.githubusercontent.com/u/81942?v=3","gravatar_id":"","url":"https://api.github.com/users/mathiasbynens","html_url":"https://github.com/mathiasbynens","followers_url":"https://api.github.com/users/mathiasbynens/followers","following_url":"https://api.github.com/users/mathiasbynens/following{/other_user}","gists_url":"https://api.github.com/users/mathiasbynens/gists{/gist_id}","starred_url":"https://api.github.com/users/mathiasbynens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathiasbynens/subscriptions","organizations_url":"https://api.github.com/users/mathiasbynens/orgs","repos_url":"https://api.github.com/users/mathiasbynens/repos","events_url":"https://api.github.com/users/mathiasbynens/events{/privacy}","received_events_url":"https://api.github.com/users/mathiasbynens/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mathiasbynens/Array.from","description":"A robust & optimized ES3-compatible polyfill for the `Array.from` method in ECMAScript 6.","fork":false,"url":"https://api.github.com/repos/mathiasbynens/Array.from","forks_url":"https://api.github.com/repos/mathiasbynens/Array.from/forks","keys_url":"https://api.github.com/repos/mathiasbynens/Array.from/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mathiasbynens/Array.from/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mathiasbynens/Array.from/teams","hooks_url":"https://api.github.com/repos/mathiasbynens/Array.from/hooks","issue_events_url":"https://api.github.com/repos/mathiasbynens/Array.from/issues/events{/number}","events_url":"https://api.github.com/repos/mathiasbynens/Array.from/events","assignees_url":"https://api.github.com/repos/mathiasbynens/Array.from/assignees{/user}","branches_url":"https://api.github.com/repos/mathiasbynens/Array.from/branches{/branch}","tags_url":"https://api.github.com/repos/mathiasbynens/Array.from/tags","blobs_url":"https://api.github.com/repos/mathiasbynens/Array.from/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mathiasbynens/Array.from/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mathiasbynens/Array.from/git/refs{/sha}","trees_url":"https://api.github.com/repos/mathiasbynens/Array.from/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mathiasbynens/Array.from/statuses/{sha}","languages_url":"https://api.github.com/repos/mathiasbynens/Array.from/languages","stargazers_url":"https://api.github.com/repos/mathiasbynens/Array.from/stargazers","contributors_url":"https://api.github.com/repos/mathiasbynens/Array.from/contributors","subscribers_url":"https://api.github.com/repos/mathiasbynens/Array.from/subscribers","subscription_url":"https://api.github.com/repos/mathiasbynens/Array.from/subscription","commits_url":"https://api.github.com/repos/mathiasbynens/Array.from/commits{/sha}","git_commits_url":"https://api.github.com/repos/mathiasbynens/Array.from/git/commits{/sha}","comments_url":"https://api.github.com/repos/mathiasbynens/Array.from/comments{/number}","issue_comment_url":"https://api.github.com/repos/mathiasbynens/Array.from/issues/comments{/number}","contents_url":"https://api.github.com/repos/mathiasbynens/Array.from/contents/{+path}","compare_url":"https://api.github.com/repos/mathiasbynens/Array.from/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mathiasbynens/Array.from/merges","archive_url":"https://api.github.com/repos/mathiasbynens/Array.from/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mathiasbynens/Array.from/downloads","issues_url":"https://api.github.com/repos/mathiasbynens/Array.from/issues{/number}","pulls_url":"https://api.github.com/repos/mathiasbynens/Array.from/pulls{/number}","milestones_url":"https://api.github.com/repos/mathiasbynens/Array.from/milestones{/number}","notifications_url":"https://api.github.com/repos/mathiasbynens/Array.from/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mathiasbynens/Array.from/labels{/name}","releases_url":"https://api.github.com/repos/mathiasbynens/Array.from/releases{/id}","deployments_url":"https://api.github.com/repos/mathiasbynens/Array.from/deployments","created_at":"2013-12-20T16:09:57Z","updated_at":"2016-08-28T06:01:50Z","pushed_at":"2016-09-16T08:32:42Z","git_url":"git://github.com/mathiasbynens/Array.from.git","ssh_url":"git@github.com:mathiasbynens/Array.from.git","clone_url":"https://github.com/mathiasbynens/Array.from.git","svn_url":"https://github.com/mathiasbynens/Array.from","homepage":"https://mths.be/array-from","size":69,"stargazers_count":37,"watchers_count":37,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":1,"forks":11,"open_issues":1,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mathiasbynens/Array.from/pulls/35"},"html":{"href":"https://github.com/mathiasbynens/Array.from/pull/35"},"issue":{"href":"https://api.github.com/repos/mathiasbynens/Array.from/issues/35"},"comments":{"href":"https://api.github.com/repos/mathiasbynens/Array.from/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/mathiasbynens/Array.from/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/mathiasbynens/Array.from/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mathiasbynens/Array.from/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/mathiasbynens/Array.from/statuses/635b2f5ebbd64caa77b5e1549b3bd6af98019bb2"}}}}
{"actor":{"display_login":"ljharb"}}