{"action":"created","comment":{"url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments/79696360","id":79696360,"diff_hunk":"@@ -0,0 +1,190 @@\n+/*\n+ * JBoss, Home of Professional Open Source\n+ * Copyright 2016 Red Hat, Inc., and individual contributors\n+ * as indicated by the @author tags.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package org.jboss.as.controller.security;\n+\n+import static org.jboss.as.controller.logging.ControllerLogger.ROOT_LOGGER;\n+\n+import javax.security.auth.DestroyFailedException;\n+import javax.security.auth.Destroyable;\n+\n+import org.jboss.logging.Logger;\n+import org.wildfly.common.Assert;\n+import org.wildfly.security.credential.Credential;\n+import org.wildfly.security.credential.PasswordCredential;\n+import org.wildfly.security.credential.store.CredentialStore;\n+import org.wildfly.security.credential.store.CredentialStoreException;\n+import org.wildfly.security.credential.store.UnsupportedCredentialTypeException;\n+import org.wildfly.security.password.interfaces.ClearPassword;\n+\n+/**\n+ * Client class used to talk to {@link CredentialStore} to obtain secret value (credential) from it.","path":"controller/src/main/java/org/jboss/as/controller/security/CredentialStoreClient.java","position":35,"original_position":35,"commit_id":"2be2da1b6f81b13a7e67d537387ea1b6e2665744","original_commit_id":"2be2da1b6f81b13a7e67d537387ea1b6e2665744","user":{"login":"bstansberry","id":299242,"avatar_url":"https://avatars.githubusercontent.com/u/299242?v=3","gravatar_id":"","url":"https://api.github.com/users/bstansberry","html_url":"https://github.com/bstansberry","followers_url":"https://api.github.com/users/bstansberry/followers","following_url":"https://api.github.com/users/bstansberry/following{/other_user}","gists_url":"https://api.github.com/users/bstansberry/gists{/gist_id}","starred_url":"https://api.github.com/users/bstansberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstansberry/subscriptions","organizations_url":"https://api.github.com/users/bstansberry/orgs","repos_url":"https://api.github.com/users/bstansberry/repos","events_url":"https://api.github.com/users/bstansberry/events{/privacy}","received_events_url":"https://api.github.com/users/bstansberry/received_events","type":"User","site_admin":false},"body":"This class should be documented as not being thread safe of should be made thread safe.","created_at":"2016-09-20T19:48:47Z","updated_at":"2016-09-20T19:48:47Z","html_url":"https://github.com/wildfly/wildfly-core/pull/1816#discussion_r79696360","pull_request_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1816","_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments/79696360"},"html":{"href":"https://github.com/wildfly/wildfly-core/pull/1816#discussion_r79696360"},"pull_request":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1816"}}},"pull_request":{"url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1816","id":85989165,"html_url":"https://github.com/wildfly/wildfly-core/pull/1816","diff_url":"https://github.com/wildfly/wildfly-core/pull/1816.diff","patch_url":"https://github.com/wildfly/wildfly-core/pull/1816.patch","issue_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/1816","number":1816,"state":"open","locked":false,"title":"[WFCORE-1547] Iniital CredentialStore Integration","user":{"login":"darranl","id":481922,"avatar_url":"https://avatars.githubusercontent.com/u/481922?v=3","gravatar_id":"","url":"https://api.github.com/users/darranl","html_url":"https://github.com/darranl","followers_url":"https://api.github.com/users/darranl/followers","following_url":"https://api.github.com/users/darranl/following{/other_user}","gists_url":"https://api.github.com/users/darranl/gists{/gist_id}","starred_url":"https://api.github.com/users/darranl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darranl/subscriptions","organizations_url":"https://api.github.com/users/darranl/orgs","repos_url":"https://api.github.com/users/darranl/repos","events_url":"https://api.github.com/users/darranl/events{/privacy}","received_events_url":"https://api.github.com/users/darranl/received_events","type":"User","site_admin":false},"body":":exclamation: Commits from this branch are used in numerous other topic branches so please do not cherry-pick or rebase. :exclamation:\r\n\r\nThis is initial commit that introduces:\r\n\r\n- CredentialReference class unifying access to credentials defined through CredentialStore or holding simple secret value. It defines credential reference attribute that other subsystems can use to reference external credentials of various types.\r\n- CredentialStoreClient class used to talk to CredentialStore to obtain secret value (credential) from it.\r\n- CredentialStoreURIParser class that parses configuration or reference URIs for easier parameter marshaling\r\n\r\nThese changes are tracked under the following Jira issue: -\r\n  https://issues.jboss.org/browse/WFCORE-1547\r\n\r\nThis Jira issue can be closed once the PR is merged.\r\n\r\nIf this PR is accepted is there also any chance of an early tag of WildFly Core, we have subsystem changes to follow up with but first require a tagged release we can reference.\r\n\r\n","created_at":"2016-09-20T14:40:20Z","updated_at":"2016-09-20T19:48:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"550e801dca51805bdefe770359992b6c8aa3e5d3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1816/commits","review_comments_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1816/comments","review_comment_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/1816/comments","statuses_url":"https://api.github.com/repos/wildfly/wildfly-core/statuses/2be2da1b6f81b13a7e67d537387ea1b6e2665744","head":{"label":"wildfly-security-incubator:WFCORE-1547","ref":"WFCORE-1547","sha":"2be2da1b6f81b13a7e67d537387ea1b6e2665744","user":{"login":"wildfly-security-incubator","id":11571905,"avatar_url":"https://avatars.githubusercontent.com/u/11571905?v=3","gravatar_id":"","url":"https://api.github.com/users/wildfly-security-incubator","html_url":"https://github.com/wildfly-security-incubator","followers_url":"https://api.github.com/users/wildfly-security-incubator/followers","following_url":"https://api.github.com/users/wildfly-security-incubator/following{/other_user}","gists_url":"https://api.github.com/users/wildfly-security-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly-security-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly-security-incubator/subscriptions","organizations_url":"https://api.github.com/users/wildfly-security-incubator/orgs","repos_url":"https://api.github.com/users/wildfly-security-incubator/repos","events_url":"https://api.github.com/users/wildfly-security-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly-security-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":32583015,"name":"wildfly-core","full_name":"wildfly-security-incubator/wildfly-core","owner":{"login":"wildfly-security-incubator","id":11571905,"avatar_url":"https://avatars.githubusercontent.com/u/11571905?v=3","gravatar_id":"","url":"https://api.github.com/users/wildfly-security-incubator","html_url":"https://github.com/wildfly-security-incubator","followers_url":"https://api.github.com/users/wildfly-security-incubator/followers","following_url":"https://api.github.com/users/wildfly-security-incubator/following{/other_user}","gists_url":"https://api.github.com/users/wildfly-security-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly-security-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly-security-incubator/subscriptions","organizations_url":"https://api.github.com/users/wildfly-security-incubator/orgs","repos_url":"https://api.github.com/users/wildfly-security-incubator/repos","events_url":"https://api.github.com/users/wildfly-security-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly-security-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wildfly-security-incubator/wildfly-core","description":"The core runtime that is used by the Wildfly application server","fork":true,"url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core","forks_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/forks","keys_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/teams","hooks_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/hooks","issue_events_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/issues/events{/number}","events_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/events","assignees_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/assignees{/user}","branches_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/branches{/branch}","tags_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/tags","blobs_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/statuses/{sha}","languages_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/languages","stargazers_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/stargazers","contributors_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/contributors","subscribers_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/subscribers","subscription_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/subscription","commits_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/contents/{+path}","compare_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/merges","archive_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/downloads","issues_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/issues{/number}","pulls_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/pulls{/number}","milestones_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/milestones{/number}","notifications_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/labels{/name}","releases_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/releases{/id}","deployments_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/deployments","created_at":"2015-03-20T12:40:48Z","updated_at":"2016-01-20T16:17:04Z","pushed_at":"2016-09-20T14:25:36Z","git_url":"git://github.com/wildfly-security-incubator/wildfly-core.git","ssh_url":"git@github.com:wildfly-security-incubator/wildfly-core.git","clone_url":"https://github.com/wildfly-security-incubator/wildfly-core.git","svn_url":"https://github.com/wildfly-security-incubator/wildfly-core","homepage":null,"size":50743,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"elytron_integration"}},"base":{"label":"wildfly:master","ref":"master","sha":"d2736992953d51978982e1dc36c2fc588dca0545","user":{"login":"wildfly","id":3066274,"avatar_url":"https://avatars.githubusercontent.com/u/3066274?v=3","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"repo":{"id":21394954,"name":"wildfly-core","full_name":"wildfly/wildfly-core","owner":{"login":"wildfly","id":3066274,"avatar_url":"https://avatars.githubusercontent.com/u/3066274?v=3","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wildfly/wildfly-core","description":"The core runtime that is used by the Wildfly application server","fork":false,"url":"https://api.github.com/repos/wildfly/wildfly-core","forks_url":"https://api.github.com/repos/wildfly/wildfly-core/forks","keys_url":"https://api.github.com/repos/wildfly/wildfly-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wildfly/wildfly-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wildfly/wildfly-core/teams","hooks_url":"https://api.github.com/repos/wildfly/wildfly-core/hooks","issue_events_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/events{/number}","events_url":"https://api.github.com/repos/wildfly/wildfly-core/events","assignees_url":"https://api.github.com/repos/wildfly/wildfly-core/assignees{/user}","branches_url":"https://api.github.com/repos/wildfly/wildfly-core/branches{/branch}","tags_url":"https://api.github.com/repos/wildfly/wildfly-core/tags","blobs_url":"https://api.github.com/repos/wildfly/wildfly-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wildfly/wildfly-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wildfly/wildfly-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/wildfly/wildfly-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wildfly/wildfly-core/statuses/{sha}","languages_url":"https://api.github.com/repos/wildfly/wildfly-core/languages","stargazers_url":"https://api.github.com/repos/wildfly/wildfly-core/stargazers","contributors_url":"https://api.github.com/repos/wildfly/wildfly-core/contributors","subscribers_url":"https://api.github.com/repos/wildfly/wildfly-core/subscribers","subscription_url":"https://api.github.com/repos/wildfly/wildfly-core/subscription","commits_url":"https://api.github.com/repos/wildfly/wildfly-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/wildfly/wildfly-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/wildfly/wildfly-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/wildfly/wildfly-core/contents/{+path}","compare_url":"https://api.github.com/repos/wildfly/wildfly-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wildfly/wildfly-core/merges","archive_url":"https://api.github.com/repos/wildfly/wildfly-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wildfly/wildfly-core/downloads","issues_url":"https://api.github.com/repos/wildfly/wildfly-core/issues{/number}","pulls_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls{/number}","milestones_url":"https://api.github.com/repos/wildfly/wildfly-core/milestones{/number}","notifications_url":"https://api.github.com/repos/wildfly/wildfly-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wildfly/wildfly-core/labels{/name}","releases_url":"https://api.github.com/repos/wildfly/wildfly-core/releases{/id}","deployments_url":"https://api.github.com/repos/wildfly/wildfly-core/deployments","created_at":"2014-07-01T16:33:34Z","updated_at":"2016-09-15T07:12:29Z","pushed_at":"2016-09-20T14:40:21Z","git_url":"git://github.com/wildfly/wildfly-core.git","ssh_url":"git@github.com:wildfly/wildfly-core.git","clone_url":"https://github.com/wildfly/wildfly-core.git","svn_url":"https://github.com/wildfly/wildfly-core","homepage":null,"size":58927,"stargazers_count":58,"watchers_count":58,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":221,"mirror_url":null,"open_issues_count":25,"forks":221,"open_issues":25,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1816"},"html":{"href":"https://github.com/wildfly/wildfly-core/pull/1816"},"issue":{"href":"https://api.github.com/repos/wildfly/wildfly-core/issues/1816"},"comments":{"href":"https://api.github.com/repos/wildfly/wildfly-core/issues/1816/comments"},"review_comments":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1816/comments"},"review_comment":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1816/commits"},"statuses":{"href":"https://api.github.com/repos/wildfly/wildfly-core/statuses/2be2da1b6f81b13a7e67d537387ea1b6e2665744"}}}}
{"actor":{"display_login":"bstansberry"}}