{"action":"created","issue":{"url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/381","repository_url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf","labels_url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/381/labels{/name}","comments_url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/381/comments","events_url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/381/events","html_url":"https://github.com/fgpv-vpgf/fgpv-vpgf/pull/381","id":139368133,"number":381,"title":"Proposal: split geoService !important","user":{"login":"AleksueiR","id":2285779,"avatar_url":"https://avatars.githubusercontent.com/u/2285779?v=3","gravatar_id":"","url":"https://api.github.com/users/AleksueiR","html_url":"https://github.com/AleksueiR","followers_url":"https://api.github.com/users/AleksueiR/followers","following_url":"https://api.github.com/users/AleksueiR/following{/other_user}","gists_url":"https://api.github.com/users/AleksueiR/gists{/gist_id}","starred_url":"https://api.github.com/users/AleksueiR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AleksueiR/subscriptions","organizations_url":"https://api.github.com/users/AleksueiR/orgs","repos_url":"https://api.github.com/users/AleksueiR/repos","events_url":"https://api.github.com/users/AleksueiR/events{/privacy}","received_events_url":"https://api.github.com/users/AleksueiR/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"alyec","id":7646414,"avatar_url":"https://avatars.githubusercontent.com/u/7646414?v=3","gravatar_id":"","url":"https://api.github.com/users/alyec","html_url":"https://github.com/alyec","followers_url":"https://api.github.com/users/alyec/followers","following_url":"https://api.github.com/users/alyec/following{/other_user}","gists_url":"https://api.github.com/users/alyec/gists{/gist_id}","starred_url":"https://api.github.com/users/alyec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alyec/subscriptions","organizations_url":"https://api.github.com/users/alyec/orgs","repos_url":"https://api.github.com/users/alyec/repos","events_url":"https://api.github.com/users/alyec/events{/privacy}","received_events_url":"https://api.github.com/users/alyec/received_events","type":"User","site_admin":false},"milestone":null,"comments":12,"created_at":"2016-03-08T19:18:26Z","updated_at":"2016-03-10T20:45:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/pulls/381","html_url":"https://github.com/fgpv-vpgf/fgpv-vpgf/pull/381","diff_url":"https://github.com/fgpv-vpgf/fgpv-vpgf/pull/381.diff","patch_url":"https://github.com/fgpv-vpgf/fgpv-vpgf/pull/381.patch"},"body":"New services created: `layerRegistry`, `mapService` and `gapiService`. They do not directly depend on `geoService`.\r\n\r\n`layerRegistry` manipulation with layers mostly (generate, register, remove, etc.)\r\n`mapService` used to register map node and hold reference to the map object\r\n`gapiService` holds reference to gapi\r\n\r\n`gapi` loading is hoisted and now starts when the lib package is download, even before `app-seed` initializes app instances.\r\n\r\n`identifyService` now accesses layers directly from `layerRegistry`, not storing them itself. This solves the growing number of layers when swapping configs. #367\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.svg\" height=\"40\" alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/fgpv-vpgf/fgpv-vpgf/381)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/comments/195038777","html_url":"https://github.com/fgpv-vpgf/fgpv-vpgf/pull/381#issuecomment-195038777","issue_url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/381","id":195038777,"user":{"login":"alyec","id":7646414,"avatar_url":"https://avatars.githubusercontent.com/u/7646414?v=3","gravatar_id":"","url":"https://api.github.com/users/alyec","html_url":"https://github.com/alyec","followers_url":"https://api.github.com/users/alyec/followers","following_url":"https://api.github.com/users/alyec/following{/other_user}","gists_url":"https://api.github.com/users/alyec/gists{/gist_id}","starred_url":"https://api.github.com/users/alyec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alyec/subscriptions","organizations_url":"https://api.github.com/users/alyec/orgs","repos_url":"https://api.github.com/users/alyec/repos","events_url":"https://api.github.com/users/alyec/events{/privacy}","received_events_url":"https://api.github.com/users/alyec/received_events","type":"User","site_admin":false},"created_at":"2016-03-10T20:45:25Z","updated_at":"2016-03-10T20:45:25Z","body":"\n\n\n\nReviewed 1 of 2 files at r4, 1 of 2 files at r5.\nReview status: all files reviewed at latest revision, 1 unresolved discussion.\n\n---\n\n*[src/app/geo/geo.service.js, line 47 \\[r3\\]](https://reviewable.io:443/reviews/fgpv-vpgf/fgpv-vpgf/381#-KCWzDgmNXod7BRedP8I:-KCX9LIC4vzaWdrlENc8:-1411840808) ([raw file](https://github.com/fgpv-vpgf/fgpv-vpgf/blob/93d701572eb11a1cffa539889b4c0bb385111565/src/app/geo/geo.service.js#L47)):*\nCan we rename it so it's obvious / add some detail to the jsdoc (maybe split out the jsdoc into a separate entry for isReady)?\n\n---\n\n*[src/app/geo/identify.service.js, line 247 \\[r3\\]](https://reviewable.io:443/reviews/fgpv-vpgf/fgpv-vpgf/381#-KCX-NqHhHcqXiAkb2Et:-KCXA53dGkbkn10RR9ig:1146509850) ([raw file](https://github.com/fgpv-vpgf/fgpv-vpgf/blob/93d701572eb11a1cffa539889b4c0bb385111565/src/app/geo/identify.service.js#L247)):*\nIt was more of a general comment to see what people prefer.  But especially things like \n\n---\n\n\n*Comments from the [review on Reviewable.io](https://reviewable.io:443/reviews/fgpv-vpgf/fgpv-vpgf/381)*\n<!-- Sent from Reviewable.io -->\n"}}