{"action":"created","comment":{"url":"https://api.github.com/repos/django/django/pulls/comments/93793124","pull_request_review_id":14329716,"id":93793124,"diff_hunk":"@@ -420,7 +414,7 @@ def get_aggregation(self, using, added_aggregate_names):\n                 # clearing the select clause can alter results if distinct is\n                 # used.\n                 if inner_query.default_cols and has_existing_annotations:\n-                    inner_query.group_by = [self.model._meta.pk.get_col(inner_query.get_initial_alias())]\n+                    inner_query.group_by = tuple([self.model._meta.pk.get_col(inner_query.get_initial_alias())])","path":"django/db/models/sql/query.py","position":108,"original_position":108,"commit_id":"37154df6fe6ed0d855398deed7e69bb5ec4f64cf","original_commit_id":"37154df6fe6ed0d855398deed7e69bb5ec4f64cf","user":{"login":"charettes","id":9293,"avatar_url":"https://avatars.githubusercontent.com/u/9293?v=3","gravatar_id":"","url":"https://api.github.com/users/charettes","html_url":"https://github.com/charettes","followers_url":"https://api.github.com/users/charettes/followers","following_url":"https://api.github.com/users/charettes/following{/other_user}","gists_url":"https://api.github.com/users/charettes/gists{/gist_id}","starred_url":"https://api.github.com/users/charettes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charettes/subscriptions","organizations_url":"https://api.github.com/users/charettes/orgs","repos_url":"https://api.github.com/users/charettes/repos","events_url":"https://api.github.com/users/charettes/events{/privacy}","received_events_url":"https://api.github.com/users/charettes/received_events","type":"User","site_admin":false},"body":"Unnecessary list comprehension,  `tuple(self.model._meta.pk.get_col(inner_query.get_initial_alias()))` should do.","created_at":"2016-12-23T18:47:39Z","updated_at":"2016-12-23T18:51:33Z","html_url":"https://github.com/django/django/pull/7730#discussion_r93793124","pull_request_url":"https://api.github.com/repos/django/django/pulls/7730","_links":{"self":{"href":"https://api.github.com/repos/django/django/pulls/comments/93793124"},"html":{"href":"https://github.com/django/django/pull/7730#discussion_r93793124"},"pull_request":{"href":"https://api.github.com/repos/django/django/pulls/7730"}}},"pull_request":{"url":"https://api.github.com/repos/django/django/pulls/7730","id":99178550,"html_url":"https://github.com/django/django/pull/7730","diff_url":"https://github.com/django/django/pull/7730.diff","patch_url":"https://github.com/django/django/pull/7730.patch","issue_url":"https://api.github.com/repos/django/django/issues/7730","number":7730,"state":"open","locked":false,"title":"Refs #27624 -- Made many attributes of Query immutable","user":{"login":"adamchainz","id":857609,"avatar_url":"https://avatars.githubusercontent.com/u/857609?v=3","gravatar_id":"","url":"https://api.github.com/users/adamchainz","html_url":"https://github.com/adamchainz","followers_url":"https://api.github.com/users/adamchainz/followers","following_url":"https://api.github.com/users/adamchainz/following{/other_user}","gists_url":"https://api.github.com/users/adamchainz/gists{/gist_id}","starred_url":"https://api.github.com/users/adamchainz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamchainz/subscriptions","organizations_url":"https://api.github.com/users/adamchainz/orgs","repos_url":"https://api.github.com/users/adamchainz/repos","events_url":"https://api.github.com/users/adamchainz/events{/privacy}","received_events_url":"https://api.github.com/users/adamchainz/received_events","type":"User","site_admin":false},"body":"[Ticket](https://code.djangoproject.com/ticket/27624)\n\n* Made `Query.tables` a `tuple`\n* Made `Query.order_by` a `tuple`\n* Made `Query.group_by` a `tuple`\n* Made `Query.distinct_fields` always a `tuple` (`add_distinct_fields` was already making it one)\n* Made `Query.values_select` a `tuple`\n* Removed `Query.add_select`, just use `set_select`\n* Made `Query.select` a `tuple`\n* Made `Query.deferred_loading[0]` a `frozenset`","created_at":"2016-12-22T22:18:44Z","updated_at":"2016-12-23T18:51:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d81128cc73b822ac56b0b6beffce417d45d25d67","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/django/django/pulls/7730/commits","review_comments_url":"https://api.github.com/repos/django/django/pulls/7730/comments","review_comment_url":"https://api.github.com/repos/django/django/pulls/comments{/number}","comments_url":"https://api.github.com/repos/django/django/issues/7730/comments","statuses_url":"https://api.github.com/repos/django/django/statuses/37154df6fe6ed0d855398deed7e69bb5ec4f64cf","head":{"label":"adamchainz:ticket_27624_Query","ref":"ticket_27624_Query","sha":"37154df6fe6ed0d855398deed7e69bb5ec4f64cf","user":{"login":"adamchainz","id":857609,"avatar_url":"https://avatars.githubusercontent.com/u/857609?v=3","gravatar_id":"","url":"https://api.github.com/users/adamchainz","html_url":"https://github.com/adamchainz","followers_url":"https://api.github.com/users/adamchainz/followers","following_url":"https://api.github.com/users/adamchainz/following{/other_user}","gists_url":"https://api.github.com/users/adamchainz/gists{/gist_id}","starred_url":"https://api.github.com/users/adamchainz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamchainz/subscriptions","organizations_url":"https://api.github.com/users/adamchainz/orgs","repos_url":"https://api.github.com/users/adamchainz/repos","events_url":"https://api.github.com/users/adamchainz/events{/privacy}","received_events_url":"https://api.github.com/users/adamchainz/received_events","type":"User","site_admin":false},"repo":{"id":26674533,"name":"django","full_name":"adamchainz/django","owner":{"login":"adamchainz","id":857609,"avatar_url":"https://avatars.githubusercontent.com/u/857609?v=3","gravatar_id":"","url":"https://api.github.com/users/adamchainz","html_url":"https://github.com/adamchainz","followers_url":"https://api.github.com/users/adamchainz/followers","following_url":"https://api.github.com/users/adamchainz/following{/other_user}","gists_url":"https://api.github.com/users/adamchainz/gists{/gist_id}","starred_url":"https://api.github.com/users/adamchainz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamchainz/subscriptions","organizations_url":"https://api.github.com/users/adamchainz/orgs","repos_url":"https://api.github.com/users/adamchainz/repos","events_url":"https://api.github.com/users/adamchainz/events{/privacy}","received_events_url":"https://api.github.com/users/adamchainz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adamchainz/django","description":"The Web framework for perfectionists with deadlines.","fork":true,"url":"https://api.github.com/repos/adamchainz/django","forks_url":"https://api.github.com/repos/adamchainz/django/forks","keys_url":"https://api.github.com/repos/adamchainz/django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adamchainz/django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adamchainz/django/teams","hooks_url":"https://api.github.com/repos/adamchainz/django/hooks","issue_events_url":"https://api.github.com/repos/adamchainz/django/issues/events{/number}","events_url":"https://api.github.com/repos/adamchainz/django/events","assignees_url":"https://api.github.com/repos/adamchainz/django/assignees{/user}","branches_url":"https://api.github.com/repos/adamchainz/django/branches{/branch}","tags_url":"https://api.github.com/repos/adamchainz/django/tags","blobs_url":"https://api.github.com/repos/adamchainz/django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adamchainz/django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adamchainz/django/git/refs{/sha}","trees_url":"https://api.github.com/repos/adamchainz/django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adamchainz/django/statuses/{sha}","languages_url":"https://api.github.com/repos/adamchainz/django/languages","stargazers_url":"https://api.github.com/repos/adamchainz/django/stargazers","contributors_url":"https://api.github.com/repos/adamchainz/django/contributors","subscribers_url":"https://api.github.com/repos/adamchainz/django/subscribers","subscription_url":"https://api.github.com/repos/adamchainz/django/subscription","commits_url":"https://api.github.com/repos/adamchainz/django/commits{/sha}","git_commits_url":"https://api.github.com/repos/adamchainz/django/git/commits{/sha}","comments_url":"https://api.github.com/repos/adamchainz/django/comments{/number}","issue_comment_url":"https://api.github.com/repos/adamchainz/django/issues/comments{/number}","contents_url":"https://api.github.com/repos/adamchainz/django/contents/{+path}","compare_url":"https://api.github.com/repos/adamchainz/django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adamchainz/django/merges","archive_url":"https://api.github.com/repos/adamchainz/django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adamchainz/django/downloads","issues_url":"https://api.github.com/repos/adamchainz/django/issues{/number}","pulls_url":"https://api.github.com/repos/adamchainz/django/pulls{/number}","milestones_url":"https://api.github.com/repos/adamchainz/django/milestones{/number}","notifications_url":"https://api.github.com/repos/adamchainz/django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adamchainz/django/labels{/name}","releases_url":"https://api.github.com/repos/adamchainz/django/releases{/id}","deployments_url":"https://api.github.com/repos/adamchainz/django/deployments","created_at":"2014-11-15T08:49:51Z","updated_at":"2016-01-20T12:15:16Z","pushed_at":"2016-12-23T17:22:04Z","git_url":"git://github.com/adamchainz/django.git","ssh_url":"git@github.com:adamchainz/django.git","clone_url":"https://github.com/adamchainz/django.git","svn_url":"https://github.com/adamchainz/django","homepage":"https://www.djangoproject.com/","size":149176,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"django:master","ref":"master","sha":"c1b221a9b913315998a1bcec2f29a9361a74d1ac","user":{"login":"django","id":27804,"avatar_url":"https://avatars.githubusercontent.com/u/27804?v=3","gravatar_id":"","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"repo":{"id":4164482,"name":"django","full_name":"django/django","owner":{"login":"django","id":27804,"avatar_url":"https://avatars.githubusercontent.com/u/27804?v=3","gravatar_id":"","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/django/django","description":"The Web framework for perfectionists with deadlines.","fork":false,"url":"https://api.github.com/repos/django/django","forks_url":"https://api.github.com/repos/django/django/forks","keys_url":"https://api.github.com/repos/django/django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/django/django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/django/django/teams","hooks_url":"https://api.github.com/repos/django/django/hooks","issue_events_url":"https://api.github.com/repos/django/django/issues/events{/number}","events_url":"https://api.github.com/repos/django/django/events","assignees_url":"https://api.github.com/repos/django/django/assignees{/user}","branches_url":"https://api.github.com/repos/django/django/branches{/branch}","tags_url":"https://api.github.com/repos/django/django/tags","blobs_url":"https://api.github.com/repos/django/django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/django/django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/django/django/git/refs{/sha}","trees_url":"https://api.github.com/repos/django/django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/django/django/statuses/{sha}","languages_url":"https://api.github.com/repos/django/django/languages","stargazers_url":"https://api.github.com/repos/django/django/stargazers","contributors_url":"https://api.github.com/repos/django/django/contributors","subscribers_url":"https://api.github.com/repos/django/django/subscribers","subscription_url":"https://api.github.com/repos/django/django/subscription","commits_url":"https://api.github.com/repos/django/django/commits{/sha}","git_commits_url":"https://api.github.com/repos/django/django/git/commits{/sha}","comments_url":"https://api.github.com/repos/django/django/comments{/number}","issue_comment_url":"https://api.github.com/repos/django/django/issues/comments{/number}","contents_url":"https://api.github.com/repos/django/django/contents/{+path}","compare_url":"https://api.github.com/repos/django/django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/django/django/merges","archive_url":"https://api.github.com/repos/django/django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/django/django/downloads","issues_url":"https://api.github.com/repos/django/django/issues{/number}","pulls_url":"https://api.github.com/repos/django/django/pulls{/number}","milestones_url":"https://api.github.com/repos/django/django/milestones{/number}","notifications_url":"https://api.github.com/repos/django/django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/django/django/labels{/name}","releases_url":"https://api.github.com/repos/django/django/releases{/id}","deployments_url":"https://api.github.com/repos/django/django/deployments","created_at":"2012-04-28T02:47:18Z","updated_at":"2016-12-23T17:39:57Z","pushed_at":"2016-12-23T18:30:48Z","git_url":"git://github.com/django/django.git","ssh_url":"git@github.com:django/django.git","clone_url":"https://github.com/django/django.git","svn_url":"https://github.com/django/django","homepage":"https://www.djangoproject.com/","size":155380,"stargazers_count":22762,"watchers_count":22762,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9196,"mirror_url":null,"open_issues_count":99,"forks":9196,"open_issues":99,"watchers":22762,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/django/django/pulls/7730"},"html":{"href":"https://github.com/django/django/pull/7730"},"issue":{"href":"https://api.github.com/repos/django/django/issues/7730"},"comments":{"href":"https://api.github.com/repos/django/django/issues/7730/comments"},"review_comments":{"href":"https://api.github.com/repos/django/django/pulls/7730/comments"},"review_comment":{"href":"https://api.github.com/repos/django/django/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/django/django/pulls/7730/commits"},"statuses":{"href":"https://api.github.com/repos/django/django/statuses/37154df6fe6ed0d855398deed7e69bb5ec4f64cf"}}}}
{"actor":{"display_login":"charettes"}}