{"action":"created","issue":{"url":"https://api.github.com/repos/firehol/netdata/issues/431","repository_url":"https://api.github.com/repos/firehol/netdata","labels_url":"https://api.github.com/repos/firehol/netdata/issues/431/labels{/name}","comments_url":"https://api.github.com/repos/firehol/netdata/issues/431/comments","events_url":"https://api.github.com/repos/firehol/netdata/issues/431/events","html_url":"https://github.com/firehol/netdata/pull/431","id":156106676,"number":431,"title":"optimizations","user":{"login":"ktsaou","id":2662304,"avatar_url":"https://avatars.githubusercontent.com/u/2662304?v=3","gravatar_id":"","url":"https://api.github.com/users/ktsaou","html_url":"https://github.com/ktsaou","followers_url":"https://api.github.com/users/ktsaou/followers","following_url":"https://api.github.com/users/ktsaou/following{/other_user}","gists_url":"https://api.github.com/users/ktsaou/gists{/gist_id}","starred_url":"https://api.github.com/users/ktsaou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktsaou/subscriptions","organizations_url":"https://api.github.com/users/ktsaou/orgs","repos_url":"https://api.github.com/users/ktsaou/repos","events_url":"https://api.github.com/users/ktsaou/events{/privacy}","received_events_url":"https://api.github.com/users/ktsaou/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2016-05-21T15:14:16Z","updated_at":"2016-05-22T11:43:37Z","closed_at":"2016-05-21T16:23:05Z","pull_request":{"url":"https://api.github.com/repos/firehol/netdata/pulls/431","html_url":"https://github.com/firehol/netdata/pull/431","diff_url":"https://github.com/firehol/netdata/pull/431.diff","patch_url":"https://github.com/firehol/netdata/pull/431.patch"},"body":"I did several optimizations to speed up netdata:\r\n\r\n- web statistics now use a single lock per web request.\r\n- diskstats cache all the config options for the disks, so that on each data collection iteration there is no configuration options check\r\n- eliminated a malloc()/free() per web request by refactoring the url_decode() function\r\n\r\na few optimizations to lower the memory requirements of netdata:\r\n\r\n- registry now uses dictionaries without statistics info (saved 32 bytes per person and machine)\r\n\r\nadded a new performance chart for netdata:\r\n\r\n- Average API response time in ms is now reported in netdata charts\r\n\r\nOptimized a bit the code that parses the web request:\r\n\r\n- a few array references were converted to pointer operations\r\n\r\nConfiguration changes\r\n\r\n- `on demand` renamed to `auto`. `on demand` still works when parsing the configuration file, but the generated one will have the values as `auto`.\r\n\r\nCode cleanup:\r\n\r\n- diskstats cleanup a bit the code, renamed the variables, etc.\r\n\r\nBugs fixed:\r\n\r\n- netdata was not able to find the hw sector size for partitions. Now it is. This fixes #393\r\n"},"comment":{"url":"https://api.github.com/repos/firehol/netdata/issues/comments/220828010","html_url":"https://github.com/firehol/netdata/pull/431#issuecomment-220828010","issue_url":"https://api.github.com/repos/firehol/netdata/issues/431","id":220828010,"user":{"login":"simonnagl","id":7253893,"avatar_url":"https://avatars.githubusercontent.com/u/7253893?v=3","gravatar_id":"","url":"https://api.github.com/users/simonnagl","html_url":"https://github.com/simonnagl","followers_url":"https://api.github.com/users/simonnagl/followers","following_url":"https://api.github.com/users/simonnagl/following{/other_user}","gists_url":"https://api.github.com/users/simonnagl/gists{/gist_id}","starred_url":"https://api.github.com/users/simonnagl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonnagl/subscriptions","organizations_url":"https://api.github.com/users/simonnagl/orgs","repos_url":"https://api.github.com/users/simonnagl/repos","events_url":"https://api.github.com/users/simonnagl/events{/privacy}","received_events_url":"https://api.github.com/users/simonnagl/received_events","type":"User","site_admin":false},"created_at":"2016-05-22T11:43:36Z","updated_at":"2016-05-22T11:43:36Z","body":"I see. No matter how we handle `btrfs` we need to split `proc_diskstats` into two modules because of space metrics for `tmpfs`.\r\nI am willing to do that. Also maybe this will automatically the `btrfs` issue.\r\n\r\nBefore doing that I would like to do two other things:\r\n\r\n- Merge the global polling #430 \r\n- Finish the discussion I startet just now. It is over how we name disks. #435\r\n\r\nWhat do you think?"}}
{"actor":{"display_login":"simonnagl"}}