{"action":"created","issue":{"url":"https://api.github.com/repos/keybase/client/issues/3038","repository_url":"https://api.github.com/repos/keybase/client","labels_url":"https://api.github.com/repos/keybase/client/issues/3038/labels{/name}","comments_url":"https://api.github.com/repos/keybase/client/issues/3038/comments","events_url":"https://api.github.com/repos/keybase/client/issues/3038/events","html_url":"https://github.com/keybase/client/pull/3038","id":159446160,"number":3038,"title":"Protect G.Clock to fix race, add Clock(), SetClock()","user":{"login":"patrickxb","id":2508,"avatar_url":"https://avatars.githubusercontent.com/u/2508?v=3","gravatar_id":"","url":"https://api.github.com/users/patrickxb","html_url":"https://github.com/patrickxb","followers_url":"https://api.github.com/users/patrickxb/followers","following_url":"https://api.github.com/users/patrickxb/following{/other_user}","gists_url":"https://api.github.com/users/patrickxb/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickxb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickxb/subscriptions","organizations_url":"https://api.github.com/users/patrickxb/orgs","repos_url":"https://api.github.com/users/patrickxb/repos","events_url":"https://api.github.com/users/patrickxb/events{/privacy}","received_events_url":"https://api.github.com/users/patrickxb/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-06-09T16:03:18Z","updated_at":"2016-06-09T16:18:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/keybase/client/pulls/3038","html_url":"https://github.com/keybase/client/pull/3038","diff_url":"https://github.com/keybase/client/pull/3038.diff","patch_url":"https://github.com/keybase/client/pull/3038.patch"},"body":"I found a race with the use of GlobalContext.Clock, and then found some inconsistent usage of G.GetClock() vs. G.Clock.\r\n\r\nThis fixes it all up, protects the clock member, and standardizes on G.Clock(), G.SetClock(...).\r\n\r\nThere is a slight chance this would have fixed the issue with fakeClock.BlockUntil(1) that we experienced in the rekey tests.\r\n\r\nr? @maxtaco "},"comment":{"url":"https://api.github.com/repos/keybase/client/issues/comments/224947076","html_url":"https://github.com/keybase/client/pull/3038#issuecomment-224947076","issue_url":"https://api.github.com/repos/keybase/client/issues/3038","id":224947076,"user":{"login":"patrickxb","id":2508,"avatar_url":"https://avatars.githubusercontent.com/u/2508?v=3","gravatar_id":"","url":"https://api.github.com/users/patrickxb","html_url":"https://github.com/patrickxb","followers_url":"https://api.github.com/users/patrickxb/followers","following_url":"https://api.github.com/users/patrickxb/following{/other_user}","gists_url":"https://api.github.com/users/patrickxb/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickxb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickxb/subscriptions","organizations_url":"https://api.github.com/users/patrickxb/orgs","repos_url":"https://api.github.com/users/patrickxb/repos","events_url":"https://api.github.com/users/patrickxb/events{/privacy}","received_events_url":"https://api.github.com/users/patrickxb/received_events","type":"User","site_admin":false},"created_at":"2016-06-09T16:18:39Z","updated_at":"2016-06-09T16:18:39Z","body":"Just tried and it had the same problem as yesterday.  \r\n\r\nNot spending any more time on it, but I think this PR is valid and fixes races, potential future issues."}}
{"actor":{"display_login":"patrickxb"}}