{"action":"closed","number":12,"pull_request":{"url":"https://api.github.com/repos/ONSdigital/florence/pulls/12","id":85972216,"html_url":"https://github.com/ONSdigital/florence/pull/12","diff_url":"https://github.com/ONSdigital/florence/pull/12.diff","patch_url":"https://github.com/ONSdigital/florence/pull/12.patch","issue_url":"https://api.github.com/repos/ONSdigital/florence/issues/12","number":12,"state":"closed","locked":false,"title":"Add warnings when uploading CSDB file with titling errors","user":{"login":"Crispioso","id":8183179,"avatar_url":"https://avatars.githubusercontent.com/u/8183179?v=3","gravatar_id":"","url":"https://api.github.com/users/Crispioso","html_url":"https://github.com/Crispioso","followers_url":"https://api.github.com/users/Crispioso/followers","following_url":"https://api.github.com/users/Crispioso/following{/other_user}","gists_url":"https://api.github.com/users/Crispioso/gists{/gist_id}","starred_url":"https://api.github.com/users/Crispioso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crispioso/subscriptions","organizations_url":"https://api.github.com/users/Crispioso/orgs","repos_url":"https://api.github.com/users/Crispioso/repos","events_url":"https://api.github.com/users/Crispioso/events{/privacy}","received_events_url":"https://api.github.com/users/Crispioso/received_events","type":"User","site_admin":false},"body":"### What\r\n\r\nValidate that CSDB file name matches dataset ID and that page has a dataset ID.\r\n\r\n### How to review\r\n\r\nAdd a CSDB file with a name that doesn't match the dataset ID and you should get a warning explaining what went wrong (without the file then being submitted). Also, remove the dataset ID from a dataset landing page, or find one without one, and then create a new version of the timeseries download and you should get another error message.\r\n\r\n### Who can review\r\n\r\nAnyone\r\n\r\n","created_at":"2016-09-20T13:14:01Z","updated_at":"2016-09-21T14:34:20Z","closed_at":"2016-09-21T14:34:20Z","merged_at":"2016-09-21T14:34:20Z","merge_commit_sha":"8906ec682786804d4954bc8e32e8ddc72814b583","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ONSdigital/florence/pulls/12/commits","review_comments_url":"https://api.github.com/repos/ONSdigital/florence/pulls/12/comments","review_comment_url":"https://api.github.com/repos/ONSdigital/florence/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ONSdigital/florence/issues/12/comments","statuses_url":"https://api.github.com/repos/ONSdigital/florence/statuses/8906ec682786804d4954bc8e32e8ddc72814b583","head":{"label":"ONSdigital:feature/csdb-file-validation","ref":"feature/csdb-file-validation","sha":"8906ec682786804d4954bc8e32e8ddc72814b583","user":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars.githubusercontent.com/u/6865137?v=3","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":30869863,"name":"florence","full_name":"ONSdigital/florence","owner":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars.githubusercontent.com/u/6865137?v=3","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ONSdigital/florence","description":"Beta publishing platform","fork":false,"url":"https://api.github.com/repos/ONSdigital/florence","forks_url":"https://api.github.com/repos/ONSdigital/florence/forks","keys_url":"https://api.github.com/repos/ONSdigital/florence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/florence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/florence/teams","hooks_url":"https://api.github.com/repos/ONSdigital/florence/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/florence/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/florence/events","assignees_url":"https://api.github.com/repos/ONSdigital/florence/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/florence/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/florence/tags","blobs_url":"https://api.github.com/repos/ONSdigital/florence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/florence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/florence/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/florence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/florence/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/florence/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/florence/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/florence/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/florence/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/florence/subscription","commits_url":"https://api.github.com/repos/ONSdigital/florence/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/florence/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/florence/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/florence/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/florence/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/florence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/florence/merges","archive_url":"https://api.github.com/repos/ONSdigital/florence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/florence/downloads","issues_url":"https://api.github.com/repos/ONSdigital/florence/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/florence/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/florence/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/florence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/florence/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/florence/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/florence/deployments","created_at":"2015-02-16T13:40:38Z","updated_at":"2016-04-01T10:22:36Z","pushed_at":"2016-09-21T14:34:19Z","git_url":"git://github.com/ONSdigital/florence.git","ssh_url":"git@github.com:ONSdigital/florence.git","clone_url":"https://github.com/ONSdigital/florence.git","svn_url":"https://github.com/ONSdigital/florence","homepage":null,"size":17561,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"develop"}},"base":{"label":"ONSdigital:develop","ref":"develop","sha":"60fdefc618569c612b211a6130644f93fc7a0a52","user":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars.githubusercontent.com/u/6865137?v=3","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":30869863,"name":"florence","full_name":"ONSdigital/florence","owner":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars.githubusercontent.com/u/6865137?v=3","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ONSdigital/florence","description":"Beta publishing platform","fork":false,"url":"https://api.github.com/repos/ONSdigital/florence","forks_url":"https://api.github.com/repos/ONSdigital/florence/forks","keys_url":"https://api.github.com/repos/ONSdigital/florence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/florence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/florence/teams","hooks_url":"https://api.github.com/repos/ONSdigital/florence/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/florence/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/florence/events","assignees_url":"https://api.github.com/repos/ONSdigital/florence/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/florence/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/florence/tags","blobs_url":"https://api.github.com/repos/ONSdigital/florence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/florence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/florence/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/florence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/florence/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/florence/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/florence/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/florence/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/florence/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/florence/subscription","commits_url":"https://api.github.com/repos/ONSdigital/florence/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/florence/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/florence/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/florence/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/florence/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/florence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/florence/merges","archive_url":"https://api.github.com/repos/ONSdigital/florence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/florence/downloads","issues_url":"https://api.github.com/repos/ONSdigital/florence/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/florence/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/florence/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/florence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/florence/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/florence/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/florence/deployments","created_at":"2015-02-16T13:40:38Z","updated_at":"2016-04-01T10:22:36Z","pushed_at":"2016-09-21T14:34:19Z","git_url":"git://github.com/ONSdigital/florence.git","ssh_url":"git@github.com:ONSdigital/florence.git","clone_url":"https://github.com/ONSdigital/florence.git","svn_url":"https://github.com/ONSdigital/florence","homepage":null,"size":17561,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ONSdigital/florence/pulls/12"},"html":{"href":"https://github.com/ONSdigital/florence/pull/12"},"issue":{"href":"https://api.github.com/repos/ONSdigital/florence/issues/12"},"comments":{"href":"https://api.github.com/repos/ONSdigital/florence/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/ONSdigital/florence/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/ONSdigital/florence/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ONSdigital/florence/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/ONSdigital/florence/statuses/8906ec682786804d4954bc8e32e8ddc72814b583"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Crispioso","id":8183179,"avatar_url":"https://avatars.githubusercontent.com/u/8183179?v=3","gravatar_id":"","url":"https://api.github.com/users/Crispioso","html_url":"https://github.com/Crispioso","followers_url":"https://api.github.com/users/Crispioso/followers","following_url":"https://api.github.com/users/Crispioso/following{/other_user}","gists_url":"https://api.github.com/users/Crispioso/gists{/gist_id}","starred_url":"https://api.github.com/users/Crispioso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crispioso/subscriptions","organizations_url":"https://api.github.com/users/Crispioso/orgs","repos_url":"https://api.github.com/users/Crispioso/repos","events_url":"https://api.github.com/users/Crispioso/events{/privacy}","received_events_url":"https://api.github.com/users/Crispioso/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":459,"deletions":412,"changed_files":1}}
{"actor":{"display_login":"Crispioso"}}