{"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/81446581","pull_request_review_id":2428604,"id":81446581,"diff_hunk":"@@ -371,54 +371,15 @@ void CGUIDialogSmartPlaylistRule::OnBrowse()\n   pDialog->Reset();\n }\n \n-void CGUIDialogSmartPlaylistRule::OnCancel()\n-{\n-  m_cancelled = true;\n-  Close();\n-}\n-\n-void CGUIDialogSmartPlaylistRule::OnField()\n-{\n-  CGUIMessage msg(GUI_MSG_ITEM_SELECTED, GetID(), CONTROL_FIELD);\n-  OnMessage(msg);\n-  m_rule.m_field = (Field)msg.GetParam1();\n-\n-  UpdateButtons();\n-}\n-\n-void CGUIDialogSmartPlaylistRule::OnOperator()\n-{\n-  CGUIMessage msg(GUI_MSG_ITEM_SELECTED, GetID(), CONTROL_OPERATOR);\n-  OnMessage(msg);\n-  m_rule.m_operator = (CDatabaseQueryRule::SEARCH_OPERATOR)msg.GetParam1();\n-\n-  UpdateButtons();\n-}\n-\n std::pair<std::string, int> OperatorLabel(CDatabaseQueryRule::SEARCH_OPERATOR op)\n {\n   return std::make_pair(CSmartPlaylistRule::GetLocalizedOperator(op), op);\n }\n \n-void CGUIDialogSmartPlaylistRule::UpdateButtons()\n+std::vector<std::pair<std::string, int>> CGUIDialogSmartPlaylistRule::GetValidOperators(CSmartPlaylistRule rule)","path":"xbmc/dialogs/GUIDialogSmartPlaylistRule.cpp","position":34,"original_position":34,"commit_id":"89e07d799dd467dd3f521182e8908a2af20254d6","original_commit_id":"89e07d799dd467dd3f521182e8908a2af20254d6","user":{"login":"Montellese","id":75864,"avatar_url":"https://avatars.githubusercontent.com/u/75864?v=3","gravatar_id":"","url":"https://api.github.com/users/Montellese","html_url":"https://github.com/Montellese","followers_url":"https://api.github.com/users/Montellese/followers","following_url":"https://api.github.com/users/Montellese/following{/other_user}","gists_url":"https://api.github.com/users/Montellese/gists{/gist_id}","starred_url":"https://api.github.com/users/Montellese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Montellese/subscriptions","organizations_url":"https://api.github.com/users/Montellese/orgs","repos_url":"https://api.github.com/users/Montellese/repos","events_url":"https://api.github.com/users/Montellese/events{/privacy}","received_events_url":"https://api.github.com/users/Montellese/received_events","type":"User","site_admin":false},"body":"`const CSmartPlaylistRule& rule`","created_at":"2016-10-01T08:55:18Z","updated_at":"2016-10-01T09:04:26Z","html_url":"https://github.com/xbmc/xbmc/pull/10594#discussion_r81446581","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/10594","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/81446581"},"html":{"href":"https://github.com/xbmc/xbmc/pull/10594#discussion_r81446581"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/10594"}}},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/10594","id":87414232,"html_url":"https://github.com/xbmc/xbmc/pull/10594","diff_url":"https://github.com/xbmc/xbmc/pull/10594.diff","patch_url":"https://github.com/xbmc/xbmc/pull/10594.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/10594","number":10594,"state":"open","locked":false,"title":"[gui] smartplaylisteditor: convert spinners etc to regular buttons","user":{"login":"phil65","id":110931,"avatar_url":"https://avatars.githubusercontent.com/u/110931?v=3","gravatar_id":"","url":"https://api.github.com/users/phil65","html_url":"https://github.com/phil65","followers_url":"https://api.github.com/users/phil65/followers","following_url":"https://api.github.com/users/phil65/following{/other_user}","gists_url":"https://api.github.com/users/phil65/gists{/gist_id}","starred_url":"https://api.github.com/users/phil65/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil65/subscriptions","organizations_url":"https://api.github.com/users/phil65/orgs","repos_url":"https://api.github.com/users/phil65/repos","events_url":"https://api.github.com/users/phil65/events{/privacy}","received_events_url":"https://api.github.com/users/phil65/received_events","type":"User","site_admin":false},"body":"Next one...this time the order-by button in Smartplaylisteditor.\r\nthis PR adds the same header file to GUIDialogSmartPlaylistEditor.cpp as https://github.com/xbmc/xbmc/pull/10593, so remind me to update the PR which gets pulled last. :)\r\nCould have put all commits into one big PR, so sorry for the additional pinging. \r\n\r\nEDIT: all PRs merged into this one.\r\n\r\nEDIT: FInished!\r\n![screenshot031](https://cloud.githubusercontent.com/assets/110931/18980048/afa36dbe-86d0-11e6-8c11-174fc483830d.png)\r\n","created_at":"2016-09-29T23:51:12Z","updated_at":"2016-10-01T09:04:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5dafd7c6d876efbfef8eda3a2ccec6d25d789d67","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/10594/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/10594/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/10594/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/89e07d799dd467dd3f521182e8908a2af20254d6","head":{"label":"phil65:playlistorder_spinner","ref":"playlistorder_spinner","sha":"89e07d799dd467dd3f521182e8908a2af20254d6","user":{"login":"phil65","id":110931,"avatar_url":"https://avatars.githubusercontent.com/u/110931?v=3","gravatar_id":"","url":"https://api.github.com/users/phil65","html_url":"https://github.com/phil65","followers_url":"https://api.github.com/users/phil65/followers","following_url":"https://api.github.com/users/phil65/following{/other_user}","gists_url":"https://api.github.com/users/phil65/gists{/gist_id}","starred_url":"https://api.github.com/users/phil65/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil65/subscriptions","organizations_url":"https://api.github.com/users/phil65/orgs","repos_url":"https://api.github.com/users/phil65/repos","events_url":"https://api.github.com/users/phil65/events{/privacy}","received_events_url":"https://api.github.com/users/phil65/received_events","type":"User","site_admin":false},"repo":{"id":6664672,"name":"xbmc","full_name":"phil65/xbmc","owner":{"login":"phil65","id":110931,"avatar_url":"https://avatars.githubusercontent.com/u/110931?v=3","gravatar_id":"","url":"https://api.github.com/users/phil65","html_url":"https://github.com/phil65","followers_url":"https://api.github.com/users/phil65/followers","following_url":"https://api.github.com/users/phil65/following{/other_user}","gists_url":"https://api.github.com/users/phil65/gists{/gist_id}","starred_url":"https://api.github.com/users/phil65/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil65/subscriptions","organizations_url":"https://api.github.com/users/phil65/orgs","repos_url":"https://api.github.com/users/phil65/repos","events_url":"https://api.github.com/users/phil65/events{/privacy}","received_events_url":"https://api.github.com/users/phil65/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/phil65/xbmc","description":"XBMC Main Repository","fork":true,"url":"https://api.github.com/repos/phil65/xbmc","forks_url":"https://api.github.com/repos/phil65/xbmc/forks","keys_url":"https://api.github.com/repos/phil65/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phil65/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phil65/xbmc/teams","hooks_url":"https://api.github.com/repos/phil65/xbmc/hooks","issue_events_url":"https://api.github.com/repos/phil65/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/phil65/xbmc/events","assignees_url":"https://api.github.com/repos/phil65/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/phil65/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/phil65/xbmc/tags","blobs_url":"https://api.github.com/repos/phil65/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phil65/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phil65/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/phil65/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phil65/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/phil65/xbmc/languages","stargazers_url":"https://api.github.com/repos/phil65/xbmc/stargazers","contributors_url":"https://api.github.com/repos/phil65/xbmc/contributors","subscribers_url":"https://api.github.com/repos/phil65/xbmc/subscribers","subscription_url":"https://api.github.com/repos/phil65/xbmc/subscription","commits_url":"https://api.github.com/repos/phil65/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/phil65/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/phil65/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/phil65/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/phil65/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/phil65/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phil65/xbmc/merges","archive_url":"https://api.github.com/repos/phil65/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phil65/xbmc/downloads","issues_url":"https://api.github.com/repos/phil65/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/phil65/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/phil65/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/phil65/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phil65/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/phil65/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/phil65/xbmc/deployments","created_at":"2012-11-13T03:07:57Z","updated_at":"2014-10-16T00:19:50Z","pushed_at":"2016-09-30T07:27:08Z","git_url":"git://github.com/phil65/xbmc.git","ssh_url":"git@github.com:phil65/xbmc.git","clone_url":"https://github.com/phil65/xbmc.git","svn_url":"https://github.com/phil65/xbmc","homepage":"http://xbmc.org","size":565308,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"da9c3c04bcd56c0d1ade20b89b7e3ca66df1cec0","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/xbmc/xbmc/deployments","created_at":"2011-01-03T21:18:51Z","updated_at":"2016-10-01T07:52:00Z","pushed_at":"2016-10-01T08:46:17Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1769422,"stargazers_count":5087,"watchers_count":5087,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3700,"mirror_url":null,"open_issues_count":191,"forks":3700,"open_issues":191,"watchers":5087,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/10594"},"html":{"href":"https://github.com/xbmc/xbmc/pull/10594"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/10594"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/10594/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/10594/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/10594/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/89e07d799dd467dd3f521182e8908a2af20254d6"}}}}
{"actor":{"display_login":"Montellese"}}