{"action":"created","issue":{"url":"https://api.github.com/repos/electron/electron/issues/6939","repository_url":"https://api.github.com/repos/electron/electron","labels_url":"https://api.github.com/repos/electron/electron/issues/6939/labels{/name}","comments_url":"https://api.github.com/repos/electron/electron/issues/6939/comments","events_url":"https://api.github.com/repos/electron/electron/issues/6939/events","html_url":"https://github.com/electron/electron/issues/6939","id":172583788,"number":6939,"title":"Ambiguous default value for nodeintegration in <webview>","user":{"login":"nikola","id":54608,"avatar_url":"https://avatars.githubusercontent.com/u/54608?v=3","gravatar_id":"","url":"https://api.github.com/users/nikola","html_url":"https://github.com/nikola","followers_url":"https://api.github.com/users/nikola/followers","following_url":"https://api.github.com/users/nikola/following{/other_user}","gists_url":"https://api.github.com/users/nikola/gists{/gist_id}","starred_url":"https://api.github.com/users/nikola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikola/subscriptions","organizations_url":"https://api.github.com/users/nikola/orgs","repos_url":"https://api.github.com/users/nikola/repos","events_url":"https://api.github.com/users/nikola/events{/privacy}","received_events_url":"https://api.github.com/users/nikola/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/electron/electron/labels/beginner","name":"beginner","color":"5319e7"},{"url":"https://api.github.com/repos/electron/electron/labels/documentation","name":"documentation","color":"eb6420"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-08-23T00:10:50Z","updated_at":"2016-09-25T20:33:59Z","closed_at":null,"body":"* Electron version: 1.3.3\r\n* Operating system: all\r\n\r\nIn\r\n\r\n`docs/api/web-view-tag.md`\r\n\r\nit reads:\r\n\r\n> `<webview src=\"http://www.google.com/\" nodeintegration></webview>`\r\n> If \"on\", the guest page in webview will have node integration and can use node APIs like require and process to access low level system resources.\r\n\r\nThe phrasing in the description implies that if the `nodeintegration` attribute is not explicitly set on the tag, then the `<webview>` won't have node integration.\r\n\r\nHowever, in\r\n\r\n`docs/tutorial/security.md`\r\n\r\nit reads:\r\n\r\n> WebViews: Set nodeintegration to false\r\n\r\nThis should be clarified in the documentation. Also, valid attribute values should either be `[true, false]` or `[on, off]`, not a mix as stated above. More generally, there should be exactly one way to set security properties, and all others should throw an error. As of 1.3.3, I can write `<webview nodeintegration=\"nada\">`, this won't throw an error or warning, and it's not immediately clear if the value evaluates to truthy or not."},"comment":{"url":"https://api.github.com/repos/electron/electron/issues/comments/249444970","html_url":"https://github.com/electron/electron/issues/6939#issuecomment-249444970","issue_url":"https://api.github.com/repos/electron/electron/issues/6939","id":249444970,"user":{"login":"jainmukul","id":10228876,"avatar_url":"https://avatars.githubusercontent.com/u/10228876?v=3","gravatar_id":"","url":"https://api.github.com/users/jainmukul","html_url":"https://github.com/jainmukul","followers_url":"https://api.github.com/users/jainmukul/followers","following_url":"https://api.github.com/users/jainmukul/following{/other_user}","gists_url":"https://api.github.com/users/jainmukul/gists{/gist_id}","starred_url":"https://api.github.com/users/jainmukul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jainmukul/subscriptions","organizations_url":"https://api.github.com/users/jainmukul/orgs","repos_url":"https://api.github.com/users/jainmukul/repos","events_url":"https://api.github.com/users/jainmukul/events{/privacy}","received_events_url":"https://api.github.com/users/jainmukul/received_events","type":"User","site_admin":false},"created_at":"2016-09-25T20:33:59Z","updated_at":"2016-09-25T20:33:59Z","body":"There are many attributes which are true by default like nodeintegration, shouldn't we write a common note for all or should write a individual note for each ?"}}
{"actor":{"display_login":"jainmukul"}}