{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/85616968","pull_request_review_id":6325883,"id":85616968,"diff_hunk":"@@ -50,6 +48,11 @@ func newDockerCommand(dockerCli *command.DockerCli) *cobra.Command {\n \tflags.StringVar(&opts.ConfigDir, \"config\", cliconfig.ConfigDir(), \"Location of client config files\")\n \topts.Common.InstallFlags(flags)\n \n+\t// flags must be the top-level command flags, not cmd.Flags()\n+\topts.Common.SetDefaultOptions(flags)\n+\tdockerCli.Initialize(opts)\n+\tdockerCli.Ping()","path":"cmd/docker/docker.go","position":19,"original_position":19,"commit_id":"f9870c2d9f1c1fe0d228e416c14b3140b640a623","original_commit_id":"56d08df06d8a9eb29df448a3ea78cf7112274e4b","user":{"login":"vieux","id":1032519,"avatar_url":"https://avatars.githubusercontent.com/u/1032519?v=3","gravatar_id":"","url":"https://api.github.com/users/vieux","html_url":"https://github.com/vieux","followers_url":"https://api.github.com/users/vieux/followers","following_url":"https://api.github.com/users/vieux/following{/other_user}","gists_url":"https://api.github.com/users/vieux/gists{/gist_id}","starred_url":"https://api.github.com/users/vieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vieux/subscriptions","organizations_url":"https://api.github.com/users/vieux/orgs","repos_url":"https://api.github.com/users/vieux/repos","events_url":"https://api.github.com/users/vieux/events{/privacy}","received_events_url":"https://api.github.com/users/vieux/received_events","type":"User","site_admin":false},"body":"oh ok I get what you mean @dnephin .\r\n\r\nSo how about we remove all the checks from the `cli` pkg, so we always display commands/flags but we error out in the `client` package only instead ?","created_at":"2016-10-28T21:56:09Z","updated_at":"2016-10-28T21:56:09Z","html_url":"https://github.com/docker/docker/pull/27745#discussion_r85616968","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/27745","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/85616968"},"html":{"href":"https://github.com/docker/docker/pull/27745#discussion_r85616968"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/27745"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/27745","id":90846618,"html_url":"https://github.com/docker/docker/pull/27745","diff_url":"https://github.com/docker/docker/pull/27745.diff","patch_url":"https://github.com/docker/docker/pull/27745.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/27745","number":27745,"state":"open","locked":false,"title":"[WIP] allow client to talk to an older server","user":{"login":"vieux","id":1032519,"avatar_url":"https://avatars.githubusercontent.com/u/1032519?v=3","gravatar_id":"","url":"https://api.github.com/users/vieux","html_url":"https://github.com/vieux","followers_url":"https://api.github.com/users/vieux/followers","following_url":"https://api.github.com/users/vieux/following{/other_user}","gists_url":"https://api.github.com/users/vieux/gists{/gist_id}","starred_url":"https://api.github.com/users/vieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vieux/subscriptions","organizations_url":"https://api.github.com/users/vieux/orgs","repos_url":"https://api.github.com/users/vieux/repos","events_url":"https://api.github.com/users/vieux/events{/privacy}","received_events_url":"https://api.github.com/users/vieux/received_events","type":"User","site_admin":false},"body":"- removed user-agent middleware (to prevent `Client and server don't have the same version` error)\r\n- removed check for `client is newer than server` error\r\n-  added `API-Version` header on all API calls\r\n- `Ping()` always calls `/_ping`, not `/v1.xx/_ping`\r\n- started added a few `if` where flags/features are only supported in `1.25`\r\n\r\nping @dnephin ","created_at":"2016-10-25T16:44:43Z","updated_at":"2016-10-28T21:56:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"462b1b4f17c81544fa7c92376dd04ac4ac74b956","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/docker/docker/milestones/56","html_url":"https://github.com/docker/docker/milestones/1.13.0","labels_url":"https://api.github.com/repos/docker/docker/milestones/56/labels","id":1839404,"number":56,"title":"1.13.0","description":"","creator":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"open_issues":109,"closed_issues":510,"state":"open","created_at":"2016-06-20T22:51:25Z","updated_at":"2016-10-28T21:28:56Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/docker/docker/pulls/27745/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/27745/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/27745/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/f9870c2d9f1c1fe0d228e416c14b3140b640a623","head":{"label":"vieux:cli_backward_compose_api","ref":"cli_backward_compose_api","sha":"f9870c2d9f1c1fe0d228e416c14b3140b640a623","user":{"login":"vieux","id":1032519,"avatar_url":"https://avatars.githubusercontent.com/u/1032519?v=3","gravatar_id":"","url":"https://api.github.com/users/vieux","html_url":"https://github.com/vieux","followers_url":"https://api.github.com/users/vieux/followers","following_url":"https://api.github.com/users/vieux/following{/other_user}","gists_url":"https://api.github.com/users/vieux/gists{/gist_id}","starred_url":"https://api.github.com/users/vieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vieux/subscriptions","organizations_url":"https://api.github.com/users/vieux/orgs","repos_url":"https://api.github.com/users/vieux/repos","events_url":"https://api.github.com/users/vieux/events{/privacy}","received_events_url":"https://api.github.com/users/vieux/received_events","type":"User","site_admin":false},"repo":{"id":9343231,"name":"docker","full_name":"vieux/docker","owner":{"login":"vieux","id":1032519,"avatar_url":"https://avatars.githubusercontent.com/u/1032519?v=3","gravatar_id":"","url":"https://api.github.com/users/vieux","html_url":"https://github.com/vieux","followers_url":"https://api.github.com/users/vieux/followers","following_url":"https://api.github.com/users/vieux/following{/other_user}","gists_url":"https://api.github.com/users/vieux/gists{/gist_id}","starred_url":"https://api.github.com/users/vieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vieux/subscriptions","organizations_url":"https://api.github.com/users/vieux/orgs","repos_url":"https://api.github.com/users/vieux/repos","events_url":"https://api.github.com/users/vieux/events{/privacy}","received_events_url":"https://api.github.com/users/vieux/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vieux/docker","description":"Docker - the Linux container runtime","fork":true,"url":"https://api.github.com/repos/vieux/docker","forks_url":"https://api.github.com/repos/vieux/docker/forks","keys_url":"https://api.github.com/repos/vieux/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vieux/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vieux/docker/teams","hooks_url":"https://api.github.com/repos/vieux/docker/hooks","issue_events_url":"https://api.github.com/repos/vieux/docker/issues/events{/number}","events_url":"https://api.github.com/repos/vieux/docker/events","assignees_url":"https://api.github.com/repos/vieux/docker/assignees{/user}","branches_url":"https://api.github.com/repos/vieux/docker/branches{/branch}","tags_url":"https://api.github.com/repos/vieux/docker/tags","blobs_url":"https://api.github.com/repos/vieux/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vieux/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vieux/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/vieux/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vieux/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/vieux/docker/languages","stargazers_url":"https://api.github.com/repos/vieux/docker/stargazers","contributors_url":"https://api.github.com/repos/vieux/docker/contributors","subscribers_url":"https://api.github.com/repos/vieux/docker/subscribers","subscription_url":"https://api.github.com/repos/vieux/docker/subscription","commits_url":"https://api.github.com/repos/vieux/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/vieux/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/vieux/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/vieux/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/vieux/docker/contents/{+path}","compare_url":"https://api.github.com/repos/vieux/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vieux/docker/merges","archive_url":"https://api.github.com/repos/vieux/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vieux/docker/downloads","issues_url":"https://api.github.com/repos/vieux/docker/issues{/number}","pulls_url":"https://api.github.com/repos/vieux/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/vieux/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/vieux/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vieux/docker/labels{/name}","releases_url":"https://api.github.com/repos/vieux/docker/releases{/id}","deployments_url":"https://api.github.com/repos/vieux/docker/deployments","created_at":"2013-04-10T09:57:14Z","updated_at":"2014-07-24T21:22:20Z","pushed_at":"2016-10-28T21:21:20Z","git_url":"git://github.com/vieux/docker.git","ssh_url":"git@github.com:vieux/docker.git","clone_url":"https://github.com/vieux/docker.git","svn_url":"https://github.com/vieux/docker","homepage":"http://docker.io","size":110787,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"beccf0f8986d1182fc2b3e192508d1309d5fc5c1","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","deployments_url":"https://api.github.com/repos/docker/docker/deployments","created_at":"2013-01-18T18:10:57Z","updated_at":"2016-10-28T20:56:56Z","pushed_at":"2016-10-28T21:38:29Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":216056,"stargazers_count":36377,"watchers_count":36377,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10739,"mirror_url":null,"open_issues_count":1914,"forks":10739,"open_issues":1914,"watchers":36377,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/27745"},"html":{"href":"https://github.com/docker/docker/pull/27745"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/27745"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/27745/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/27745/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/27745/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/f9870c2d9f1c1fe0d228e416c14b3140b640a623"}}}}
{"actor":{"display_login":"vieux"}}