{"action":"created","comment":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/77500751","id":77500751,"diff_hunk":"@@ -10,32 +10,39 @@ dbms.directories.import=import\n # Require (or disable the requirement of) auth to access Neo4j\n dbms.security.auth_enabled=true\n \n-#\n+# With default configuration Neo4j only accepts local connections.\n+# To accept non-local connections, uncomment this line:\n+#dbms.connectors.default_listen_address=0.0.0.0\n+\n+# You can also choose a specific network interface, and configure a non-default\n+# port for each connector, by setting their individual listen_address.\n+\n+# Neo4j advertises the addresses its connectors.\n+# To specify the hostname or IP address of this server used in those\n+# adverised addresses, uncomment this line:\n+#dbms.connectors.default_advertised_hostname=localhost\n+\n+# You can also choose a specific advertised hostname or IP address, and\n+# configure an advertised port for each connector, by setting their\n+# individual advertised_address.\n+\n # Bolt connector\n-#\n dbms.connector.bolt.type=BOLT\n dbms.connector.bolt.enabled=true\n dbms.connector.bolt.tls_level=OPTIONAL\n-# To have Bolt accept non-local connections, uncomment this line:\n-# dbms.connector.bolt.address=0.0.0.0:7687\n+dbms.connector.bolt.listen_address=:7687","path":"packaging/neo4j-desktop/src/main/resources/org/neo4j/desktop/config/neo4j-default.conf","position":28,"original_position":28,"commit_id":"8b0102e3275649c48e081de9ad3a89f129f8f429","original_commit_id":"8b0102e3275649c48e081de9ad3a89f129f8f429","user":{"login":"benbc","id":128750,"avatar_url":"https://avatars.githubusercontent.com/u/128750?v=3","gravatar_id":"","url":"https://api.github.com/users/benbc","html_url":"https://github.com/benbc","followers_url":"https://api.github.com/users/benbc/followers","following_url":"https://api.github.com/users/benbc/following{/other_user}","gists_url":"https://api.github.com/users/benbc/gists{/gist_id}","starred_url":"https://api.github.com/users/benbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benbc/subscriptions","organizations_url":"https://api.github.com/users/benbc/orgs","repos_url":"https://api.github.com/users/benbc/repos","events_url":"https://api.github.com/users/benbc/events{/privacy}","received_events_url":"https://api.github.com/users/benbc/received_events","type":"User","site_admin":false},"body":"Isn't this the default? Should be commented out.","created_at":"2016-09-05T10:20:02Z","updated_at":"2016-09-05T10:20:02Z","html_url":"https://github.com/neo4j/neo4j/pull/7855#discussion_r77500751","pull_request_url":"https://api.github.com/repos/neo4j/neo4j/pulls/7855","_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/77500751"},"html":{"href":"https://github.com/neo4j/neo4j/pull/7855#discussion_r77500751"},"pull_request":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/7855"}}},"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/7855","id":83925800,"html_url":"https://github.com/neo4j/neo4j/pull/7855","diff_url":"https://github.com/neo4j/neo4j/pull/7855.diff","patch_url":"https://github.com/neo4j/neo4j/pull/7855.patch","issue_url":"https://api.github.com/repos/neo4j/neo4j/issues/7855","number":7855,"state":"open","locked":false,"title":"Explicit listen and advertised addresses for Bolt and HTTP.","user":{"login":"apcj","id":98962,"avatar_url":"https://avatars.githubusercontent.com/u/98962?v=3","gravatar_id":"","url":"https://api.github.com/users/apcj","html_url":"https://github.com/apcj","followers_url":"https://api.github.com/users/apcj/followers","following_url":"https://api.github.com/users/apcj/following{/other_user}","gists_url":"https://api.github.com/users/apcj/gists{/gist_id}","starred_url":"https://api.github.com/users/apcj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apcj/subscriptions","organizations_url":"https://api.github.com/users/apcj/orgs","repos_url":"https://api.github.com/users/apcj/repos","events_url":"https://api.github.com/users/apcj/events{/privacy}","received_events_url":"https://api.github.com/users/apcj/received_events","type":"User","site_admin":false},"body":"Separates the two concerns of:\r\n\r\nA. Choosing a network interface and port on which to listen for\r\n   incoming connections: \"listen address\", and\r\nB. Advertising the address which a client should use to connect\r\n   to the server: \"advertised address\".\r\n\r\nBackground:\r\n\r\nA web server has no need to advertise its address; the server\r\nalways responds according its identity from the client's perspective.\r\n\r\nHowever, when there are multiple connectors available, or\r\nmultiple servers in a cluster, an advertised address is required.\r\n\r\nBefore this commit, Bolt and HTTP connectors tried to deduce their\r\nadvertised address from a single \"address\" setting that was also\r\nused for binding. This made it difficult to support network\r\nconfigurations where there was a difference in DNS between client\r\nand server, or where a proxy was used.\r\n\r\nThis distinction was already in place for core-edge clusters,\r\nbut this commit extends the concept to Bolt and HTTP.\r\n\r\nConfiguration changes:\r\n\r\nAll connectors now have a pair of properties \"listen_address\"\r\nand \"advertised_address\". The \"address\" is deprecated, and for\r\nbackwards compatibility its value is interpreted as \"listen_address\".\r\n\r\nadvertised_address need not be specified; by default it derives\r\nits value from listen address. Therefore there is no additional\r\nconfiguration required unless using the new ability to override\r\nthe default advertised address.\r\n\r\nAdditionally, there are some defaults to further reduce\r\nconfiguration. Both listen_address and advertised_address\r\nproperties can be specified as just a port without a hostname\r\nor address, e.g. \":7474\" in which case the hostname part is\r\ninherited from global settings dbms.connectors.default_listen_address\r\nor dbms.connectors.default_advertised_hostname respectively.\r\n\r\nThis means that when opening up a server from its default\r\nlocal-only configuration, there is only one property that needs\r\nupdating to 0.0.0.0, and all connectors will be open.\r\n\r\nImplementation notes:\r\n\r\nTwo tiny types ListenSocketAddress and AdvertisedSocketAddress\r\nare used to easily keep track of how the respective settings are\r\nused. These classes mostly replace HostnamePort in the affected\r\nmodules.","created_at":"2016-09-04T15:27:51Z","updated_at":"2016-09-05T10:20:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"896a7eb99f9a5dfeed50459d9cc17bf3a4084f90","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/neo4j/neo4j/pulls/7855/commits","review_comments_url":"https://api.github.com/repos/neo4j/neo4j/pulls/7855/comments","review_comment_url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo4j/neo4j/issues/7855/comments","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/8b0102e3275649c48e081de9ad3a89f129f8f429","head":{"label":"apcj:listen_advertise","ref":"listen_advertise","sha":"8b0102e3275649c48e081de9ad3a89f129f8f429","user":{"login":"apcj","id":98962,"avatar_url":"https://avatars.githubusercontent.com/u/98962?v=3","gravatar_id":"","url":"https://api.github.com/users/apcj","html_url":"https://github.com/apcj","followers_url":"https://api.github.com/users/apcj/followers","following_url":"https://api.github.com/users/apcj/following{/other_user}","gists_url":"https://api.github.com/users/apcj/gists{/gist_id}","starred_url":"https://api.github.com/users/apcj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apcj/subscriptions","organizations_url":"https://api.github.com/users/apcj/orgs","repos_url":"https://api.github.com/users/apcj/repos","events_url":"https://api.github.com/users/apcj/events{/privacy}","received_events_url":"https://api.github.com/users/apcj/received_events","type":"User","site_admin":false},"repo":{"id":8655412,"name":"neo4j","full_name":"apcj/neo4j","owner":{"login":"apcj","id":98962,"avatar_url":"https://avatars.githubusercontent.com/u/98962?v=3","gravatar_id":"","url":"https://api.github.com/users/apcj","html_url":"https://github.com/apcj","followers_url":"https://api.github.com/users/apcj/followers","following_url":"https://api.github.com/users/apcj/following{/other_user}","gists_url":"https://api.github.com/users/apcj/gists{/gist_id}","starred_url":"https://api.github.com/users/apcj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apcj/subscriptions","organizations_url":"https://api.github.com/users/apcj/orgs","repos_url":"https://api.github.com/users/apcj/repos","events_url":"https://api.github.com/users/apcj/events{/privacy}","received_events_url":"https://api.github.com/users/apcj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/apcj/neo4j","description":"","fork":true,"url":"https://api.github.com/repos/apcj/neo4j","forks_url":"https://api.github.com/repos/apcj/neo4j/forks","keys_url":"https://api.github.com/repos/apcj/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apcj/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apcj/neo4j/teams","hooks_url":"https://api.github.com/repos/apcj/neo4j/hooks","issue_events_url":"https://api.github.com/repos/apcj/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/apcj/neo4j/events","assignees_url":"https://api.github.com/repos/apcj/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/apcj/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/apcj/neo4j/tags","blobs_url":"https://api.github.com/repos/apcj/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apcj/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apcj/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/apcj/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apcj/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/apcj/neo4j/languages","stargazers_url":"https://api.github.com/repos/apcj/neo4j/stargazers","contributors_url":"https://api.github.com/repos/apcj/neo4j/contributors","subscribers_url":"https://api.github.com/repos/apcj/neo4j/subscribers","subscription_url":"https://api.github.com/repos/apcj/neo4j/subscription","commits_url":"https://api.github.com/repos/apcj/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/apcj/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/apcj/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/apcj/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/apcj/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/apcj/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apcj/neo4j/merges","archive_url":"https://api.github.com/repos/apcj/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apcj/neo4j/downloads","issues_url":"https://api.github.com/repos/apcj/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/apcj/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/apcj/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/apcj/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apcj/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/apcj/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/apcj/neo4j/deployments","created_at":"2013-03-08T16:56:21Z","updated_at":"2015-02-20T15:48:47Z","pushed_at":"2016-09-04T21:43:44Z","git_url":"git://github.com/apcj/neo4j.git","ssh_url":"git@github.com:apcj/neo4j.git","clone_url":"https://github.com/apcj/neo4j.git","svn_url":"https://github.com/apcj/neo4j","homepage":"http://neo4j.org","size":302308,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.3"}},"base":{"label":"neo4j:3.1","ref":"3.1","sha":"10b35a445340de5fd81d8bd61d88efc92a934b54","user":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"repo":{"id":6650539,"name":"neo4j","full_name":"neo4j/neo4j","owner":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo4j/neo4j","description":"Graphs for Everyone","fork":false,"url":"https://api.github.com/repos/neo4j/neo4j","forks_url":"https://api.github.com/repos/neo4j/neo4j/forks","keys_url":"https://api.github.com/repos/neo4j/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4j/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4j/neo4j/teams","hooks_url":"https://api.github.com/repos/neo4j/neo4j/hooks","issue_events_url":"https://api.github.com/repos/neo4j/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/neo4j/neo4j/events","assignees_url":"https://api.github.com/repos/neo4j/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/neo4j/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/neo4j/neo4j/tags","blobs_url":"https://api.github.com/repos/neo4j/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4j/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4j/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4j/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4j/neo4j/languages","stargazers_url":"https://api.github.com/repos/neo4j/neo4j/stargazers","contributors_url":"https://api.github.com/repos/neo4j/neo4j/contributors","subscribers_url":"https://api.github.com/repos/neo4j/neo4j/subscribers","subscription_url":"https://api.github.com/repos/neo4j/neo4j/subscription","commits_url":"https://api.github.com/repos/neo4j/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4j/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4j/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4j/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo4j/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/neo4j/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4j/neo4j/merges","archive_url":"https://api.github.com/repos/neo4j/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4j/neo4j/downloads","issues_url":"https://api.github.com/repos/neo4j/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/neo4j/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4j/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4j/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4j/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/neo4j/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/neo4j/neo4j/deployments","created_at":"2012-11-12T08:46:15Z","updated_at":"2016-09-05T05:53:38Z","pushed_at":"2016-09-05T10:18:56Z","git_url":"git://github.com/neo4j/neo4j.git","ssh_url":"git@github.com:neo4j/neo4j.git","clone_url":"https://github.com/neo4j/neo4j.git","svn_url":"https://github.com/neo4j/neo4j","homepage":"http://neo4j.com","size":371087,"stargazers_count":2947,"watchers_count":2947,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":977,"mirror_url":null,"open_issues_count":409,"forks":977,"open_issues":409,"watchers":2947,"default_branch":"3.1"}},"_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/7855"},"html":{"href":"https://github.com/neo4j/neo4j/pull/7855"},"issue":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/7855"},"comments":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/7855/comments"},"review_comments":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/7855/comments"},"review_comment":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/7855/commits"},"statuses":{"href":"https://api.github.com/repos/neo4j/neo4j/statuses/8b0102e3275649c48e081de9ad3a89f129f8f429"}}}}
{"actor":{"display_login":"benbc"}}