{"action":"created","issue":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/18337","repository_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/18337/labels{/name}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/18337/comments","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/18337/events","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/18337","id":176852614,"number":18337,"title":"Rebalance Bomb & Charge Explosive Power (plus other explosive tweaks)","user":{"login":"Nioca","id":11001797,"avatar_url":"https://avatars.githubusercontent.com/u/11001797?v=3","gravatar_id":"","url":"https://api.github.com/users/Nioca","html_url":"https://github.com/Nioca","followers_url":"https://api.github.com/users/Nioca/followers","following_url":"https://api.github.com/users/Nioca/following{/other_user}","gists_url":"https://api.github.com/users/Nioca/gists{/gist_id}","starred_url":"https://api.github.com/users/Nioca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nioca/subscriptions","organizations_url":"https://api.github.com/users/Nioca/orgs","repos_url":"https://api.github.com/users/Nioca/repos","events_url":"https://api.github.com/users/Nioca/events{/privacy}","received_events_url":"https://api.github.com/users/Nioca/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-09-14T09:01:12Z","updated_at":"2016-09-16T17:30:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/18337","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/18337","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/18337.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/18337.patch"},"body":"Right now, some of the values when it comes to the power and payload of bombs and explosive charges are rather messed up. I dove into it originally just planning to buff C-4 a bit, but then I started noticing some other errors, and it sorta snowballed from there. What this PR does is:\r\n\r\n- **Rebalance the blast power of certain explosive devices.** Despite being a crude, improvised ammonium nitrate bomb, the Fertilizer Bomb was one of the most powerful explosive devices available aside from the ANFO/RDX charges (and Mininukes, of course). By contrast. C-4 was woefully underpowered, being a full third weaker than a stick of dynamite. I rebalanced their blast power, plus the others, using their real life R.E. Factor as a guide to help determine about where they should sit relative to each other.\r\n\r\n- **Most bombs now explode if set on fire.** Black gunpowder-based bombs will explode as if used normally if set ablaze. RDX and ANFO explosives will also explode, but only at partial power due to their stability (the blast is less the RDX or ANFO exploding and more the dynamite/HMTD used as a detonator cooking off). C-4 will not explode if set on fire.\r\n\r\n- **Black Gunpowder Charges and RDX Charges now leave behind shrapnel.** Black Gunpowder Charges now leave fragments of scrap metal behind after detonating. RDX Charges leave just the unusuable Shrapnel. Notably, if an RDX Charge is set on fire and has a partial detonation, it'll leave behind Scrap Metal instead.\r\n\r\n- **Bomb and Explosive Charge Recipes altered to not break laws of physics.** The RDX Sand Bomb was an egregious offender here, somehow fitting 14 volume and 7kg of sand and RDX into a 2 volume bomb weighing only 2kg. The ANFO charge apparently consisted of only a 3kg smattering of ANFO on the bottom of a 100-Liter Steel Drum (it now uses an Aluminum or Steel Keg instead, see below), and the Black Gunpowder Charge used the same amount of gunpowder as the Black Gunpowder Bomb, despite packing 6x the punch (and shrapnel that wasn't actually included in the recipe!).\r\n\r\n- **ANFO stack size reduced by factor of 10.** Let's face it, we've got one recipe that uses ANFO, and any future recipes we potentially come up with aren't going to need so much precision that we have to measure it in 9-gram increments.\r\n\r\n- **New item: Steel Keg.** A craftable Steel Keg for use with ANFO and RDX charges (or just storing your favorite beverage). In addition, the Aluminum Keg had its weight drastically reduced, since it looks like someone used the weight for a stainless steel keg to represent an aluminum one.\r\n\r\n- **(09/16/2016) Migrates all explosive-type item recipes into the appropriate JSON file.** All recipes in the subcategory `CSC_WEAPON_EXPLOSIVE` have been migrated into `explosive.json`, and reformatted according to code standard."},"comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments/247659699","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/18337#issuecomment-247659699","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/18337","id":247659699,"user":{"login":"Vidiveni","id":19913451,"avatar_url":"https://avatars.githubusercontent.com/u/19913451?v=3","gravatar_id":"","url":"https://api.github.com/users/Vidiveni","html_url":"https://github.com/Vidiveni","followers_url":"https://api.github.com/users/Vidiveni/followers","following_url":"https://api.github.com/users/Vidiveni/following{/other_user}","gists_url":"https://api.github.com/users/Vidiveni/gists{/gist_id}","starred_url":"https://api.github.com/users/Vidiveni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vidiveni/subscriptions","organizations_url":"https://api.github.com/users/Vidiveni/orgs","repos_url":"https://api.github.com/users/Vidiveni/repos","events_url":"https://api.github.com/users/Vidiveni/events{/privacy}","received_events_url":"https://api.github.com/users/Vidiveni/received_events","type":"User","site_admin":false},"created_at":"2016-09-16T17:30:30Z","updated_at":"2016-09-16T17:30:30Z","body":"> Adding weight is sort of a double-edged sword when it comes to throwing weapons. On one hand, they do inflict more damage, but at the same time, their range becomes shorter. A lot shorter. To give you an idea, the 2kg RDX Sand Bomb has a range of 3 for an average 8 strength survivor. For a 14 strength superhuman, that increases to a whopping 6. As for adding Bash, it's worth noting that this effects both its effectiveness as a melee weapon as well as its power as a throwing weapon.\r\n\r\nAccording to @Coolthulhu an item's effective range increases from having some damage and weight stat. Nail bomb will often land 1 tile away as it is now, even with high throwing skill. I understand too much weight decreases max range, but with 0 bash and almost no weight the nail bomb is currently almost completely useless and just a newbie-trap. I suggest making it similar to the grenade at least, or buffing both. "}}
{"actor":{"display_login":"Vidiveni"}}