{"action":"created","comment":{"url":"https://api.github.com/repos/release-engineering/koji-containerbuild/pulls/comments/84242706","pull_request_review_id":5031185,"id":84242706,"diff_hunk":"@@ -406,11 +409,16 @@ def handler(self, src, target_info, arch, scratch=False,\n         build_id = build_response.get_build_name()\n         self.logger.debug(\"OSBS build id: %r\", build_id)\n \n-        self.logger.debug(\"Waiting for osbs build_id: %s to be scheduled.\",\n-                          build_id)\n-        # we need to wait for kubelet to schedule the build, otherwise it's 500\n-        self.osbs().wait_for_build_to_get_scheduled(build_id)","path":"koji_containerbuild/plugins/builder_containerbuild.py","position":33,"original_position":33,"commit_id":"cc1d5672ecd95ff33d45496fd8c7edd295d1cecf","original_commit_id":"cc1d5672ecd95ff33d45496fd8c7edd295d1cecf","user":{"login":"vrutkovs","id":114501,"avatar_url":"https://avatars.githubusercontent.com/u/114501?v=3","gravatar_id":"","url":"https://api.github.com/users/vrutkovs","html_url":"https://github.com/vrutkovs","followers_url":"https://api.github.com/users/vrutkovs/followers","following_url":"https://api.github.com/users/vrutkovs/following{/other_user}","gists_url":"https://api.github.com/users/vrutkovs/gists{/gist_id}","starred_url":"https://api.github.com/users/vrutkovs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrutkovs/subscriptions","organizations_url":"https://api.github.com/users/vrutkovs/orgs","repos_url":"https://api.github.com/users/vrutkovs/repos","events_url":"https://api.github.com/users/vrutkovs/events{/privacy}","received_events_url":"https://api.github.com/users/vrutkovs/received_events","type":"User","site_admin":false},"body":"Didn't try this on Origin, so not sure which version is required for that to work. I'll revert that part, and make sure that `signal.signal` solution works anyway","created_at":"2016-10-20T09:20:59Z","updated_at":"2016-10-20T09:20:59Z","html_url":"https://github.com/release-engineering/koji-containerbuild/pull/63#discussion_r84242706","pull_request_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/pulls/63","_links":{"self":{"href":"https://api.github.com/repos/release-engineering/koji-containerbuild/pulls/comments/84242706"},"html":{"href":"https://github.com/release-engineering/koji-containerbuild/pull/63#discussion_r84242706"},"pull_request":{"href":"https://api.github.com/repos/release-engineering/koji-containerbuild/pulls/63"}}},"pull_request":{"url":"https://api.github.com/repos/release-engineering/koji-containerbuild/pulls/63","id":90051969,"html_url":"https://github.com/release-engineering/koji-containerbuild/pull/63","diff_url":"https://github.com/release-engineering/koji-containerbuild/pull/63.diff","patch_url":"https://github.com/release-engineering/koji-containerbuild/pull/63.patch","issue_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/issues/63","number":63,"state":"open","locked":false,"title":"Cancel OSE builds when koji task is cancelled Mk.2","user":{"login":"vrutkovs","id":114501,"avatar_url":"https://avatars.githubusercontent.com/u/114501?v=3","gravatar_id":"","url":"https://api.github.com/users/vrutkovs","html_url":"https://github.com/vrutkovs","followers_url":"https://api.github.com/users/vrutkovs/followers","following_url":"https://api.github.com/users/vrutkovs/following{/other_user}","gists_url":"https://api.github.com/users/vrutkovs/gists{/gist_id}","starred_url":"https://api.github.com/users/vrutkovs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrutkovs/subscriptions","organizations_url":"https://api.github.com/users/vrutkovs/orgs","repos_url":"https://api.github.com/users/vrutkovs/repos","events_url":"https://api.github.com/users/vrutkovs/events{/privacy}","received_events_url":"https://api.github.com/users/vrutkovs/received_events","type":"User","site_admin":false},"body":"Use SIGINT signal handler to cancel OSE build (if it has been started). This change \nensures that the build in New/Pending state (where logs are not being written) is \nalso correctly cancelled.\n\nTested on local koji instance","created_at":"2016-10-19T17:08:05Z","updated_at":"2016-10-20T09:20:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"750994df836fbe0dfbe1ea0e1b853428ffada589","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/pulls/63/commits","review_comments_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/pulls/63/comments","review_comment_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/pulls/comments{/number}","comments_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/issues/63/comments","statuses_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/statuses/cc1d5672ecd95ff33d45496fd8c7edd295d1cecf","head":{"label":"vrutkovs:cancel_builds_v2","ref":"cancel_builds_v2","sha":"cc1d5672ecd95ff33d45496fd8c7edd295d1cecf","user":{"login":"vrutkovs","id":114501,"avatar_url":"https://avatars.githubusercontent.com/u/114501?v=3","gravatar_id":"","url":"https://api.github.com/users/vrutkovs","html_url":"https://github.com/vrutkovs","followers_url":"https://api.github.com/users/vrutkovs/followers","following_url":"https://api.github.com/users/vrutkovs/following{/other_user}","gists_url":"https://api.github.com/users/vrutkovs/gists{/gist_id}","starred_url":"https://api.github.com/users/vrutkovs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrutkovs/subscriptions","organizations_url":"https://api.github.com/users/vrutkovs/orgs","repos_url":"https://api.github.com/users/vrutkovs/repos","events_url":"https://api.github.com/users/vrutkovs/events{/privacy}","received_events_url":"https://api.github.com/users/vrutkovs/received_events","type":"User","site_admin":false},"repo":{"id":58740014,"name":"koji-containerbuild","full_name":"vrutkovs/koji-containerbuild","owner":{"login":"vrutkovs","id":114501,"avatar_url":"https://avatars.githubusercontent.com/u/114501?v=3","gravatar_id":"","url":"https://api.github.com/users/vrutkovs","html_url":"https://github.com/vrutkovs","followers_url":"https://api.github.com/users/vrutkovs/followers","following_url":"https://api.github.com/users/vrutkovs/following{/other_user}","gists_url":"https://api.github.com/users/vrutkovs/gists{/gist_id}","starred_url":"https://api.github.com/users/vrutkovs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrutkovs/subscriptions","organizations_url":"https://api.github.com/users/vrutkovs/orgs","repos_url":"https://api.github.com/users/vrutkovs/repos","events_url":"https://api.github.com/users/vrutkovs/events{/privacy}","received_events_url":"https://api.github.com/users/vrutkovs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vrutkovs/koji-containerbuild","description":"Container build support for Koji buildsystem","fork":true,"url":"https://api.github.com/repos/vrutkovs/koji-containerbuild","forks_url":"https://api.github.com/repos/vrutkovs/koji-containerbuild/forks","keys_url":"https://api.github.com/repos/vrutkovs/koji-containerbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vrutkovs/koji-containerbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vrutkovs/koji-containerbuild/teams","hooks_url":"https://api.github.com/repos/vrutkovs/koji-containerbuild/hooks","issue_events_url":"https://api.github.com/repos/vrutkovs/koji-containerbuild/issues/events{/number}","events_url":"https://api.github.com/repos/vrutkovs/koji-containerbuild/events","assignees_url":"https://api.github.com/repos/vrutkovs/koji-containerbuild/assignees{/user}","branches_url":"https://api.github.com/repos/vrutkovs/koji-containerbuild/branches{/branch}","tags_url":"https://api.github.com/repos/vrutkovs/koji-containerbuild/tags","blobs_url":"https://api.github.com/repos/vrutkovs/koji-containerbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vrutkovs/koji-containerbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vrutkovs/koji-containerbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/vrutkovs/koji-containerbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vrutkovs/koji-containerbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/vrutkovs/koji-containerbuild/languages","stargazers_url":"https://api.github.com/repos/vrutkovs/koji-containerbuild/stargazers","contributors_url":"https://api.github.com/repos/vrutkovs/koji-containerbuild/contributors","subscribers_url":"https://api.github.com/repos/vrutkovs/koji-containerbuild/subscribers","subscription_url":"https://api.github.com/repos/vrutkovs/koji-containerbuild/subscription","commits_url":"https://api.github.com/repos/vrutkovs/koji-containerbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/vrutkovs/koji-containerbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/vrutkovs/koji-containerbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/vrutkovs/koji-containerbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/vrutkovs/koji-containerbuild/contents/{+path}","compare_url":"https://api.github.com/repos/vrutkovs/koji-containerbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vrutkovs/koji-containerbuild/merges","archive_url":"https://api.github.com/repos/vrutkovs/koji-containerbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vrutkovs/koji-containerbuild/downloads","issues_url":"https://api.github.com/repos/vrutkovs/koji-containerbuild/issues{/number}","pulls_url":"https://api.github.com/repos/vrutkovs/koji-containerbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/vrutkovs/koji-containerbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/vrutkovs/koji-containerbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vrutkovs/koji-containerbuild/labels{/name}","releases_url":"https://api.github.com/repos/vrutkovs/koji-containerbuild/releases{/id}","deployments_url":"https://api.github.com/repos/vrutkovs/koji-containerbuild/deployments","created_at":"2016-05-13T12:49:30Z","updated_at":"2016-05-13T12:49:31Z","pushed_at":"2016-10-19T17:09:34Z","git_url":"git://github.com/vrutkovs/koji-containerbuild.git","ssh_url":"git@github.com:vrutkovs/koji-containerbuild.git","clone_url":"https://github.com/vrutkovs/koji-containerbuild.git","svn_url":"https://github.com/vrutkovs/koji-containerbuild","homepage":"","size":212,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"release-engineering:develop","ref":"develop","sha":"1d69784be091ab203985f5554e7900521f49d542","user":{"login":"release-engineering","id":9591189,"avatar_url":"https://avatars.githubusercontent.com/u/9591189?v=3","gravatar_id":"","url":"https://api.github.com/users/release-engineering","html_url":"https://github.com/release-engineering","followers_url":"https://api.github.com/users/release-engineering/followers","following_url":"https://api.github.com/users/release-engineering/following{/other_user}","gists_url":"https://api.github.com/users/release-engineering/gists{/gist_id}","starred_url":"https://api.github.com/users/release-engineering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/release-engineering/subscriptions","organizations_url":"https://api.github.com/users/release-engineering/orgs","repos_url":"https://api.github.com/users/release-engineering/repos","events_url":"https://api.github.com/users/release-engineering/events{/privacy}","received_events_url":"https://api.github.com/users/release-engineering/received_events","type":"Organization","site_admin":false},"repo":{"id":35804983,"name":"koji-containerbuild","full_name":"release-engineering/koji-containerbuild","owner":{"login":"release-engineering","id":9591189,"avatar_url":"https://avatars.githubusercontent.com/u/9591189?v=3","gravatar_id":"","url":"https://api.github.com/users/release-engineering","html_url":"https://github.com/release-engineering","followers_url":"https://api.github.com/users/release-engineering/followers","following_url":"https://api.github.com/users/release-engineering/following{/other_user}","gists_url":"https://api.github.com/users/release-engineering/gists{/gist_id}","starred_url":"https://api.github.com/users/release-engineering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/release-engineering/subscriptions","organizations_url":"https://api.github.com/users/release-engineering/orgs","repos_url":"https://api.github.com/users/release-engineering/repos","events_url":"https://api.github.com/users/release-engineering/events{/privacy}","received_events_url":"https://api.github.com/users/release-engineering/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/release-engineering/koji-containerbuild","description":"Container build support for Koji buildsystem","fork":false,"url":"https://api.github.com/repos/release-engineering/koji-containerbuild","forks_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/forks","keys_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/teams","hooks_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/hooks","issue_events_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/issues/events{/number}","events_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/events","assignees_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/assignees{/user}","branches_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/branches{/branch}","tags_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/tags","blobs_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/languages","stargazers_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/stargazers","contributors_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/contributors","subscribers_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/subscribers","subscription_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/subscription","commits_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/contents/{+path}","compare_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/merges","archive_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/downloads","issues_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/issues{/number}","pulls_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/labels{/name}","releases_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/releases{/id}","deployments_url":"https://api.github.com/repos/release-engineering/koji-containerbuild/deployments","created_at":"2015-05-18T08:06:46Z","updated_at":"2016-09-20T19:49:28Z","pushed_at":"2016-10-19T17:09:34Z","git_url":"git://github.com/release-engineering/koji-containerbuild.git","ssh_url":"git@github.com:release-engineering/koji-containerbuild.git","clone_url":"https://github.com/release-engineering/koji-containerbuild.git","svn_url":"https://github.com/release-engineering/koji-containerbuild","homepage":"","size":219,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":21,"forks":10,"open_issues":21,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/release-engineering/koji-containerbuild/pulls/63"},"html":{"href":"https://github.com/release-engineering/koji-containerbuild/pull/63"},"issue":{"href":"https://api.github.com/repos/release-engineering/koji-containerbuild/issues/63"},"comments":{"href":"https://api.github.com/repos/release-engineering/koji-containerbuild/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/release-engineering/koji-containerbuild/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/release-engineering/koji-containerbuild/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/release-engineering/koji-containerbuild/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/release-engineering/koji-containerbuild/statuses/cc1d5672ecd95ff33d45496fd8c7edd295d1cecf"}}}}
{"actor":{"display_login":"vrutkovs"}}