{"action":"created","issue":{"url":"https://api.github.com/repos/serilog/serilog/issues/896","repository_url":"https://api.github.com/repos/serilog/serilog","labels_url":"https://api.github.com/repos/serilog/serilog/issues/896/labels{/name}","comments_url":"https://api.github.com/repos/serilog/serilog/issues/896/comments","events_url":"https://api.github.com/repos/serilog/serilog/issues/896/events","html_url":"https://github.com/serilog/serilog/pull/896","id":187321438,"number":896,"title":"Convention tests for log level write methods in Serilog.Core.Logger","user":{"login":"clarkis117","id":3946178,"avatar_url":"https://avatars.githubusercontent.com/u/3946178?v=3","gravatar_id":"","url":"https://api.github.com/users/clarkis117","html_url":"https://github.com/clarkis117","followers_url":"https://api.github.com/users/clarkis117/followers","following_url":"https://api.github.com/users/clarkis117/following{/other_user}","gists_url":"https://api.github.com/users/clarkis117/gists{/gist_id}","starred_url":"https://api.github.com/users/clarkis117/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clarkis117/subscriptions","organizations_url":"https://api.github.com/users/clarkis117/orgs","repos_url":"https://api.github.com/users/clarkis117/repos","events_url":"https://api.github.com/users/clarkis117/events{/privacy}","received_events_url":"https://api.github.com/users/clarkis117/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-11-04T12:29:05Z","updated_at":"2016-11-08T01:15:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/serilog/serilog/pulls/896","html_url":"https://github.com/serilog/serilog/pull/896","diff_url":"https://github.com/serilog/serilog/pull/896.diff","patch_url":"https://github.com/serilog/serilog/pull/896.patch"},"body":"As proposed in #878, tests that check the convention of the log level wrapper methods in` Serilog.Core.Logger`. The tests reflect over the methods in `Serilog.Core.Logger` , that match known log level names. Then the methods and their parameters are checked against several rules that match the signatures listed below. If a method matches a know signature, it is invoked with some arbitrary data. If a method does not match a know signature, the test for its log level group fails with the unmatched method printed out as an error message.\r\n\r\n```\r\nMethod0 (string messageTemplate) : void\r\nMethod1<T> (string messageTemplate, T propertyValue) : void\r\nMethod2<T0, T1> (string messageTemplate, T0 propertyValue0, T1 propertyValue1) : void\r\nMethod3<T0, T1, T2> (string messageTemplate, T0 propertyValue0, T1 propertyValue1, T2 propertyValue2) : void\r\nMethod4 (string messageTemplate, params object[] propertyValues) : void\r\nMethod5 (Exception exception, string messageTemplate) : void\r\nMethod6<T> (Exception exception, string messageTemplate, T propertyValue) : void\r\nMethod7<T0, T1> (Exception exception, string messageTemplate, T0 propertyValue0, T1 propertyValue1) : void\r\nMethod8<T0, T1, T2> (Exception exception, string messageTemplate, T0 propertyValue0, T1 propertyValue1, T2 propertyValue2) : void\r\nMethod9 (Exception exception, string messageTemplate, params object[] propertyValues) : void\r\n```\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/serilog/serilog/issues/comments/259015997","html_url":"https://github.com/serilog/serilog/pull/896#issuecomment-259015997","issue_url":"https://api.github.com/repos/serilog/serilog/issues/896","id":259015997,"user":{"login":"clarkis117","id":3946178,"avatar_url":"https://avatars.githubusercontent.com/u/3946178?v=3","gravatar_id":"","url":"https://api.github.com/users/clarkis117","html_url":"https://github.com/clarkis117","followers_url":"https://api.github.com/users/clarkis117/followers","following_url":"https://api.github.com/users/clarkis117/following{/other_user}","gists_url":"https://api.github.com/users/clarkis117/gists{/gist_id}","starred_url":"https://api.github.com/users/clarkis117/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clarkis117/subscriptions","organizations_url":"https://api.github.com/users/clarkis117/orgs","repos_url":"https://api.github.com/users/clarkis117/repos","events_url":"https://api.github.com/users/clarkis117/events{/privacy}","received_events_url":"https://api.github.com/users/clarkis117/received_events","type":"User","site_admin":false},"created_at":"2016-11-08T01:15:16Z","updated_at":"2016-11-08T01:15:16Z","body":"If it’s okay, you can go ahead and merge this PR. I’ll add test coverage for `Serilog.Log` and `ILogger` in a separate PR and move the code out of `LoggerTests.cs` into `MethodOverloadConventionsTests.cs`, since it will require some modifications to the existing work. It would also probably be cleaner to keep the test code just in `MethodOverloadConventionsTests.cs`."}}
{"actor":{"display_login":"clarkis117"}}