{"action":"closed","number":608,"pull_request":{"url":"https://api.github.com/repos/ninenines/erlang.mk/pulls/608","id":88515546,"html_url":"https://github.com/ninenines/erlang.mk/pull/608","diff_url":"https://github.com/ninenines/erlang.mk/pull/608.diff","patch_url":"https://github.com/ninenines/erlang.mk/pull/608.patch","issue_url":"https://api.github.com/repos/ninenines/erlang.mk/issues/608","number":608,"state":"closed","locked":false,"title":"Support C compiler flag overrides for dependencies","user":{"login":"fhunleth","id":64669,"avatar_url":"https://avatars.githubusercontent.com/u/64669?v=3","gravatar_id":"","url":"https://api.github.com/users/fhunleth","html_url":"https://github.com/fhunleth","followers_url":"https://api.github.com/users/fhunleth/followers","following_url":"https://api.github.com/users/fhunleth/following{/other_user}","gists_url":"https://api.github.com/users/fhunleth/gists{/gist_id}","starred_url":"https://api.github.com/users/fhunleth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fhunleth/subscriptions","organizations_url":"https://api.github.com/users/fhunleth/orgs","repos_url":"https://api.github.com/users/fhunleth/repos","events_url":"https://api.github.com/users/fhunleth/events{/privacy}","received_events_url":"https://api.github.com/users/fhunleth/received_events","type":"User","site_admin":false},"body":"This change makes it possible to override the ERL_CFLAGS and ERL_LDFLAGS\r\nMakefile variables in project dependencies. For the main project, the\r\nability to override variables associated with C compilation already\r\nexisted in plugins/c_src.mk. With this change, the C compiler flag\r\nsemantics are similar for both the main project and dependencies.\r\n\r\nThis is important for cases where the automatically determined values\r\nfor the ERTS include and library directories are incorrect. This happens\r\nin cross-compiled environments where they point to the host's include\r\nand library directories. However, the desired behaviour is to have them\r\npoint to those that have been cross-compiled for the target.","created_at":"2016-10-07T22:05:57Z","updated_at":"2016-10-08T22:09:57Z","closed_at":"2016-10-08T22:09:57Z","merged_at":null,"merge_commit_sha":"a5fa90ebb8e1cbaf2a1cf507469a0140344397da","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ninenines/erlang.mk/pulls/608/commits","review_comments_url":"https://api.github.com/repos/ninenines/erlang.mk/pulls/608/comments","review_comment_url":"https://api.github.com/repos/ninenines/erlang.mk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ninenines/erlang.mk/issues/608/comments","statuses_url":"https://api.github.com/repos/ninenines/erlang.mk/statuses/cf4ba69e131a8176bca25e80c3c687767f14dd64","head":{"label":"fhunleth:crosscompile-deps","ref":"crosscompile-deps","sha":"cf4ba69e131a8176bca25e80c3c687767f14dd64","user":{"login":"fhunleth","id":64669,"avatar_url":"https://avatars.githubusercontent.com/u/64669?v=3","gravatar_id":"","url":"https://api.github.com/users/fhunleth","html_url":"https://github.com/fhunleth","followers_url":"https://api.github.com/users/fhunleth/followers","following_url":"https://api.github.com/users/fhunleth/following{/other_user}","gists_url":"https://api.github.com/users/fhunleth/gists{/gist_id}","starred_url":"https://api.github.com/users/fhunleth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fhunleth/subscriptions","organizations_url":"https://api.github.com/users/fhunleth/orgs","repos_url":"https://api.github.com/users/fhunleth/repos","events_url":"https://api.github.com/users/fhunleth/events{/privacy}","received_events_url":"https://api.github.com/users/fhunleth/received_events","type":"User","site_admin":false},"repo":{"id":70284644,"name":"erlang.mk","full_name":"fhunleth/erlang.mk","owner":{"login":"fhunleth","id":64669,"avatar_url":"https://avatars.githubusercontent.com/u/64669?v=3","gravatar_id":"","url":"https://api.github.com/users/fhunleth","html_url":"https://github.com/fhunleth","followers_url":"https://api.github.com/users/fhunleth/followers","following_url":"https://api.github.com/users/fhunleth/following{/other_user}","gists_url":"https://api.github.com/users/fhunleth/gists{/gist_id}","starred_url":"https://api.github.com/users/fhunleth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fhunleth/subscriptions","organizations_url":"https://api.github.com/users/fhunleth/orgs","repos_url":"https://api.github.com/users/fhunleth/repos","events_url":"https://api.github.com/users/fhunleth/events{/privacy}","received_events_url":"https://api.github.com/users/fhunleth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fhunleth/erlang.mk","description":"A build tool for Erlang that just works.","fork":true,"url":"https://api.github.com/repos/fhunleth/erlang.mk","forks_url":"https://api.github.com/repos/fhunleth/erlang.mk/forks","keys_url":"https://api.github.com/repos/fhunleth/erlang.mk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fhunleth/erlang.mk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fhunleth/erlang.mk/teams","hooks_url":"https://api.github.com/repos/fhunleth/erlang.mk/hooks","issue_events_url":"https://api.github.com/repos/fhunleth/erlang.mk/issues/events{/number}","events_url":"https://api.github.com/repos/fhunleth/erlang.mk/events","assignees_url":"https://api.github.com/repos/fhunleth/erlang.mk/assignees{/user}","branches_url":"https://api.github.com/repos/fhunleth/erlang.mk/branches{/branch}","tags_url":"https://api.github.com/repos/fhunleth/erlang.mk/tags","blobs_url":"https://api.github.com/repos/fhunleth/erlang.mk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fhunleth/erlang.mk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fhunleth/erlang.mk/git/refs{/sha}","trees_url":"https://api.github.com/repos/fhunleth/erlang.mk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fhunleth/erlang.mk/statuses/{sha}","languages_url":"https://api.github.com/repos/fhunleth/erlang.mk/languages","stargazers_url":"https://api.github.com/repos/fhunleth/erlang.mk/stargazers","contributors_url":"https://api.github.com/repos/fhunleth/erlang.mk/contributors","subscribers_url":"https://api.github.com/repos/fhunleth/erlang.mk/subscribers","subscription_url":"https://api.github.com/repos/fhunleth/erlang.mk/subscription","commits_url":"https://api.github.com/repos/fhunleth/erlang.mk/commits{/sha}","git_commits_url":"https://api.github.com/repos/fhunleth/erlang.mk/git/commits{/sha}","comments_url":"https://api.github.com/repos/fhunleth/erlang.mk/comments{/number}","issue_comment_url":"https://api.github.com/repos/fhunleth/erlang.mk/issues/comments{/number}","contents_url":"https://api.github.com/repos/fhunleth/erlang.mk/contents/{+path}","compare_url":"https://api.github.com/repos/fhunleth/erlang.mk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fhunleth/erlang.mk/merges","archive_url":"https://api.github.com/repos/fhunleth/erlang.mk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fhunleth/erlang.mk/downloads","issues_url":"https://api.github.com/repos/fhunleth/erlang.mk/issues{/number}","pulls_url":"https://api.github.com/repos/fhunleth/erlang.mk/pulls{/number}","milestones_url":"https://api.github.com/repos/fhunleth/erlang.mk/milestones{/number}","notifications_url":"https://api.github.com/repos/fhunleth/erlang.mk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fhunleth/erlang.mk/labels{/name}","releases_url":"https://api.github.com/repos/fhunleth/erlang.mk/releases{/id}","deployments_url":"https://api.github.com/repos/fhunleth/erlang.mk/deployments","created_at":"2016-10-07T21:35:10Z","updated_at":"2016-10-07T21:35:11Z","pushed_at":"2016-10-07T22:05:19Z","git_url":"git://github.com/fhunleth/erlang.mk.git","ssh_url":"git@github.com:fhunleth/erlang.mk.git","clone_url":"https://github.com/fhunleth/erlang.mk.git","svn_url":"https://github.com/fhunleth/erlang.mk","homepage":"http://erlang.mk","size":3063,"stargazers_count":0,"watchers_count":0,"language":"Makefile","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ninenines:master","ref":"master","sha":"833fc7b75116322757b0f2c30d25c65124fee7a5","user":{"login":"ninenines","id":1166740,"avatar_url":"https://avatars.githubusercontent.com/u/1166740?v=3","gravatar_id":"","url":"https://api.github.com/users/ninenines","html_url":"https://github.com/ninenines","followers_url":"https://api.github.com/users/ninenines/followers","following_url":"https://api.github.com/users/ninenines/following{/other_user}","gists_url":"https://api.github.com/users/ninenines/gists{/gist_id}","starred_url":"https://api.github.com/users/ninenines/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ninenines/subscriptions","organizations_url":"https://api.github.com/users/ninenines/orgs","repos_url":"https://api.github.com/users/ninenines/repos","events_url":"https://api.github.com/users/ninenines/events{/privacy}","received_events_url":"https://api.github.com/users/ninenines/received_events","type":"Organization","site_admin":false},"repo":{"id":9777075,"name":"erlang.mk","full_name":"ninenines/erlang.mk","owner":{"login":"ninenines","id":1166740,"avatar_url":"https://avatars.githubusercontent.com/u/1166740?v=3","gravatar_id":"","url":"https://api.github.com/users/ninenines","html_url":"https://github.com/ninenines","followers_url":"https://api.github.com/users/ninenines/followers","following_url":"https://api.github.com/users/ninenines/following{/other_user}","gists_url":"https://api.github.com/users/ninenines/gists{/gist_id}","starred_url":"https://api.github.com/users/ninenines/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ninenines/subscriptions","organizations_url":"https://api.github.com/users/ninenines/orgs","repos_url":"https://api.github.com/users/ninenines/repos","events_url":"https://api.github.com/users/ninenines/events{/privacy}","received_events_url":"https://api.github.com/users/ninenines/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ninenines/erlang.mk","description":"A build tool for Erlang that just works.","fork":false,"url":"https://api.github.com/repos/ninenines/erlang.mk","forks_url":"https://api.github.com/repos/ninenines/erlang.mk/forks","keys_url":"https://api.github.com/repos/ninenines/erlang.mk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ninenines/erlang.mk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ninenines/erlang.mk/teams","hooks_url":"https://api.github.com/repos/ninenines/erlang.mk/hooks","issue_events_url":"https://api.github.com/repos/ninenines/erlang.mk/issues/events{/number}","events_url":"https://api.github.com/repos/ninenines/erlang.mk/events","assignees_url":"https://api.github.com/repos/ninenines/erlang.mk/assignees{/user}","branches_url":"https://api.github.com/repos/ninenines/erlang.mk/branches{/branch}","tags_url":"https://api.github.com/repos/ninenines/erlang.mk/tags","blobs_url":"https://api.github.com/repos/ninenines/erlang.mk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ninenines/erlang.mk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ninenines/erlang.mk/git/refs{/sha}","trees_url":"https://api.github.com/repos/ninenines/erlang.mk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ninenines/erlang.mk/statuses/{sha}","languages_url":"https://api.github.com/repos/ninenines/erlang.mk/languages","stargazers_url":"https://api.github.com/repos/ninenines/erlang.mk/stargazers","contributors_url":"https://api.github.com/repos/ninenines/erlang.mk/contributors","subscribers_url":"https://api.github.com/repos/ninenines/erlang.mk/subscribers","subscription_url":"https://api.github.com/repos/ninenines/erlang.mk/subscription","commits_url":"https://api.github.com/repos/ninenines/erlang.mk/commits{/sha}","git_commits_url":"https://api.github.com/repos/ninenines/erlang.mk/git/commits{/sha}","comments_url":"https://api.github.com/repos/ninenines/erlang.mk/comments{/number}","issue_comment_url":"https://api.github.com/repos/ninenines/erlang.mk/issues/comments{/number}","contents_url":"https://api.github.com/repos/ninenines/erlang.mk/contents/{+path}","compare_url":"https://api.github.com/repos/ninenines/erlang.mk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ninenines/erlang.mk/merges","archive_url":"https://api.github.com/repos/ninenines/erlang.mk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ninenines/erlang.mk/downloads","issues_url":"https://api.github.com/repos/ninenines/erlang.mk/issues{/number}","pulls_url":"https://api.github.com/repos/ninenines/erlang.mk/pulls{/number}","milestones_url":"https://api.github.com/repos/ninenines/erlang.mk/milestones{/number}","notifications_url":"https://api.github.com/repos/ninenines/erlang.mk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ninenines/erlang.mk/labels{/name}","releases_url":"https://api.github.com/repos/ninenines/erlang.mk/releases{/id}","deployments_url":"https://api.github.com/repos/ninenines/erlang.mk/deployments","created_at":"2013-04-30T18:18:46Z","updated_at":"2016-10-06T09:30:44Z","pushed_at":"2016-10-08T22:09:46Z","git_url":"git://github.com/ninenines/erlang.mk.git","ssh_url":"git@github.com:ninenines/erlang.mk.git","clone_url":"https://github.com/ninenines/erlang.mk.git","svn_url":"https://github.com/ninenines/erlang.mk","homepage":"http://erlang.mk","size":3881,"stargazers_count":399,"watchers_count":399,"language":"Makefile","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":174,"mirror_url":null,"open_issues_count":139,"forks":174,"open_issues":139,"watchers":399,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ninenines/erlang.mk/pulls/608"},"html":{"href":"https://github.com/ninenines/erlang.mk/pull/608"},"issue":{"href":"https://api.github.com/repos/ninenines/erlang.mk/issues/608"},"comments":{"href":"https://api.github.com/repos/ninenines/erlang.mk/issues/608/comments"},"review_comments":{"href":"https://api.github.com/repos/ninenines/erlang.mk/pulls/608/comments"},"review_comment":{"href":"https://api.github.com/repos/ninenines/erlang.mk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ninenines/erlang.mk/pulls/608/commits"},"statuses":{"href":"https://api.github.com/repos/ninenines/erlang.mk/statuses/cf4ba69e131a8176bca25e80c3c687767f14dd64"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":4,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"essen"}}