{"action":"created","issue":{"url":"https://api.github.com/repos/callemall/material-ui/issues/5094","repository_url":"https://api.github.com/repos/callemall/material-ui","labels_url":"https://api.github.com/repos/callemall/material-ui/issues/5094/labels{/name}","comments_url":"https://api.github.com/repos/callemall/material-ui/issues/5094/comments","events_url":"https://api.github.com/repos/callemall/material-ui/issues/5094/events","html_url":"https://github.com/callemall/material-ui/issues/5094","id":174176879,"number":5094,"title":"[Tabs] TabTemplate to use 100% height ","user":{"login":"mustafa-visokio","id":13646247,"avatar_url":"https://avatars.githubusercontent.com/u/13646247?v=3","gravatar_id":"","url":"https://api.github.com/users/mustafa-visokio","html_url":"https://github.com/mustafa-visokio","followers_url":"https://api.github.com/users/mustafa-visokio/followers","following_url":"https://api.github.com/users/mustafa-visokio/following{/other_user}","gists_url":"https://api.github.com/users/mustafa-visokio/gists{/gist_id}","starred_url":"https://api.github.com/users/mustafa-visokio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mustafa-visokio/subscriptions","organizations_url":"https://api.github.com/users/mustafa-visokio/orgs","repos_url":"https://api.github.com/users/mustafa-visokio/repos","events_url":"https://api.github.com/users/mustafa-visokio/events{/privacy}","received_events_url":"https://api.github.com/users/mustafa-visokio/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-08-31T03:35:20Z","updated_at":"2016-09-28T17:28:41Z","closed_at":null,"body":"### When you use the default tab template as part of Tabs the styling in the code uses 100% width, but no 100% height. Meaning if you then want all your other components to get the height allocated under the tab template div you can't get at it when you use 100% height for children under the tab template div.\r\n\r\n### Steps to reproduce\r\n\r\nSimply create a tab and add some child to the tab (set the height property to 100% of the child - the height of div up till the template is correct, but then the child div can't the height.\r\n### Versions\r\n\r\n- Material-UI:  0.15.3\r\n- React: 15.3.0\r\n- Browser: Chrome / Safari\r\n\r\n<!-- Have a QUESTION? Please ask in [StackOverflow or gitter](http://tr.im/77pVj before opening an issue.\r\n\r\nIf you are having an issue with click events, please re-read the [README](http://tr.im/410Fg) (you did read the README, right? :-) ).\r\n\r\nIf you think you have found a _new_ issue that hasn't already been reported or fixed in HEAD, please complete the template above.\r\n\r\nFor feature requests, please delete the template above and use this one instead:\r\n\r\n### Description\r\n### Images & references\r\n\r\n-->\r\n\r\nAny help would be appreciated.\r\n\r\nRegards,\r\n\r\nMustafa"},"comment":{"url":"https://api.github.com/repos/callemall/material-ui/issues/comments/250237802","html_url":"https://github.com/callemall/material-ui/issues/5094#issuecomment-250237802","issue_url":"https://api.github.com/repos/callemall/material-ui/issues/5094","id":250237802,"user":{"login":"GAumala","id":5729175,"avatar_url":"https://avatars.githubusercontent.com/u/5729175?v=3","gravatar_id":"","url":"https://api.github.com/users/GAumala","html_url":"https://github.com/GAumala","followers_url":"https://api.github.com/users/GAumala/followers","following_url":"https://api.github.com/users/GAumala/following{/other_user}","gists_url":"https://api.github.com/users/GAumala/gists{/gist_id}","starred_url":"https://api.github.com/users/GAumala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GAumala/subscriptions","organizations_url":"https://api.github.com/users/GAumala/orgs","repos_url":"https://api.github.com/users/GAumala/repos","events_url":"https://api.github.com/users/GAumala/events{/privacy}","received_events_url":"https://api.github.com/users/GAumala/received_events","type":"User","site_admin":false},"created_at":"2016-09-28T17:28:41Z","updated_at":"2016-09-28T17:28:41Z","body":"This is a fairly common issue with the tabs component. Maybe the docs could be improved a little? The `tabTemplate` prop is described like this:\r\n\r\n> Override the default tab template used to wrap the content of each tab element.\r\n\r\nI think this is a little vague. linking to the [default tab template](https://github.com/callemall/material-ui/blob/master/src/Tabs/TabTemplate.js) could be a great start. Adding a little info about the default tab template's implementation would be nice too. \r\n\r\nHowever, overriding the component that changes the visibility of the tab might be an overkill for these kind of problems, not to mention error prone. Why not have a new prop called `tabTemplateStyle` that could be used to add `height: 100%` to the template style? I could work on a PR for this feature if you guys are interested :)"}}
{"actor":{"display_login":"GAumala"}}