{"action":"opened","number":210,"pull_request":{"url":"https://api.github.com/repos/smooch/smooch-js/pulls/210","id":63713201,"html_url":"https://github.com/smooch/smooch-js/pull/210","diff_url":"https://github.com/smooch/smooch-js/pull/210.diff","patch_url":"https://github.com/smooch/smooch-js/pull/210.patch","issue_url":"https://api.github.com/repos/smooch/smooch-js/issues/210","number":210,"state":"open","locked":false,"title":"Fix rounding issue for input width","user":{"login":"lemieux","id":781844,"avatar_url":"https://avatars.githubusercontent.com/u/781844?v=3","gravatar_id":"","url":"https://api.github.com/users/lemieux","html_url":"https://github.com/lemieux","followers_url":"https://api.github.com/users/lemieux/followers","following_url":"https://api.github.com/users/lemieux/following{/other_user}","gists_url":"https://api.github.com/users/lemieux/gists{/gist_id}","starred_url":"https://api.github.com/users/lemieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lemieux/subscriptions","organizations_url":"https://api.github.com/users/lemieux/orgs","repos_url":"https://api.github.com/users/lemieux/repos","events_url":"https://api.github.com/users/lemieux/events{/privacy}","received_events_url":"https://api.github.com/users/lemieux/received_events","type":"User","site_admin":false},"body":"As seen with the widget embedded in Elev.io, the input was just 1px to wide and was pushing the send button out. I realize that `offsetWidth` is always returning a rounded integer. In Elev.io case, the actual width (using the client rect) is 49.390625, but offsetWidth returns 49. This is just enough to break the footer rendering.\r\n\r\nBy using `getBoundingClientRect`, we ensure the real computed width is used and then we ceil it to get the worst case scenario.\r\n\r\n@alavers @dannytranlx @jugarrit @mspensieri ","created_at":"2016-03-22T12:41:09Z","updated_at":"2016-03-22T12:41:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/smooch/smooch-js/pulls/210/commits","review_comments_url":"https://api.github.com/repos/smooch/smooch-js/pulls/210/comments","review_comment_url":"https://api.github.com/repos/smooch/smooch-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smooch/smooch-js/issues/210/comments","statuses_url":"https://api.github.com/repos/smooch/smooch-js/statuses/54caa53509d22d3d4ef0ba7846da3a80393232a7","head":{"label":"smooch:b/embedded-input-width","ref":"b/embedded-input-width","sha":"54caa53509d22d3d4ef0ba7846da3a80393232a7","user":{"login":"smooch","id":14301989,"avatar_url":"https://avatars.githubusercontent.com/u/14301989?v=3","gravatar_id":"","url":"https://api.github.com/users/smooch","html_url":"https://github.com/smooch","followers_url":"https://api.github.com/users/smooch/followers","following_url":"https://api.github.com/users/smooch/following{/other_user}","gists_url":"https://api.github.com/users/smooch/gists{/gist_id}","starred_url":"https://api.github.com/users/smooch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smooch/subscriptions","organizations_url":"https://api.github.com/users/smooch/orgs","repos_url":"https://api.github.com/users/smooch/repos","events_url":"https://api.github.com/users/smooch/events{/privacy}","received_events_url":"https://api.github.com/users/smooch/received_events","type":"Organization","site_admin":false},"repo":{"id":36675403,"name":"smooch-js","full_name":"smooch/smooch-js","owner":{"login":"smooch","id":14301989,"avatar_url":"https://avatars.githubusercontent.com/u/14301989?v=3","gravatar_id":"","url":"https://api.github.com/users/smooch","html_url":"https://github.com/smooch","followers_url":"https://api.github.com/users/smooch/followers","following_url":"https://api.github.com/users/smooch/following{/other_user}","gists_url":"https://api.github.com/users/smooch/gists{/gist_id}","starred_url":"https://api.github.com/users/smooch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smooch/subscriptions","organizations_url":"https://api.github.com/users/smooch/orgs","repos_url":"https://api.github.com/users/smooch/repos","events_url":"https://api.github.com/users/smooch/events{/privacy}","received_events_url":"https://api.github.com/users/smooch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smooch/smooch-js","description":"Smooch lets you have rich conversations with your users, right in your app or on your website.","fork":false,"url":"https://api.github.com/repos/smooch/smooch-js","forks_url":"https://api.github.com/repos/smooch/smooch-js/forks","keys_url":"https://api.github.com/repos/smooch/smooch-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smooch/smooch-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smooch/smooch-js/teams","hooks_url":"https://api.github.com/repos/smooch/smooch-js/hooks","issue_events_url":"https://api.github.com/repos/smooch/smooch-js/issues/events{/number}","events_url":"https://api.github.com/repos/smooch/smooch-js/events","assignees_url":"https://api.github.com/repos/smooch/smooch-js/assignees{/user}","branches_url":"https://api.github.com/repos/smooch/smooch-js/branches{/branch}","tags_url":"https://api.github.com/repos/smooch/smooch-js/tags","blobs_url":"https://api.github.com/repos/smooch/smooch-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smooch/smooch-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smooch/smooch-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/smooch/smooch-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smooch/smooch-js/statuses/{sha}","languages_url":"https://api.github.com/repos/smooch/smooch-js/languages","stargazers_url":"https://api.github.com/repos/smooch/smooch-js/stargazers","contributors_url":"https://api.github.com/repos/smooch/smooch-js/contributors","subscribers_url":"https://api.github.com/repos/smooch/smooch-js/subscribers","subscription_url":"https://api.github.com/repos/smooch/smooch-js/subscription","commits_url":"https://api.github.com/repos/smooch/smooch-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/smooch/smooch-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/smooch/smooch-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/smooch/smooch-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/smooch/smooch-js/contents/{+path}","compare_url":"https://api.github.com/repos/smooch/smooch-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smooch/smooch-js/merges","archive_url":"https://api.github.com/repos/smooch/smooch-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smooch/smooch-js/downloads","issues_url":"https://api.github.com/repos/smooch/smooch-js/issues{/number}","pulls_url":"https://api.github.com/repos/smooch/smooch-js/pulls{/number}","milestones_url":"https://api.github.com/repos/smooch/smooch-js/milestones{/number}","notifications_url":"https://api.github.com/repos/smooch/smooch-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smooch/smooch-js/labels{/name}","releases_url":"https://api.github.com/repos/smooch/smooch-js/releases{/id}","deployments_url":"https://api.github.com/repos/smooch/smooch-js/deployments","created_at":"2015-06-01T17:03:32Z","updated_at":"2016-03-17T09:07:06Z","pushed_at":"2016-03-22T12:26:34Z","git_url":"git://github.com/smooch/smooch-js.git","ssh_url":"git@github.com:smooch/smooch-js.git","clone_url":"https://github.com/smooch/smooch-js.git","svn_url":"https://github.com/smooch/smooch-js","homepage":"https://smooch.io","size":10470,"stargazers_count":51,"watchers_count":51,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":5,"forks":18,"open_issues":5,"watchers":51,"default_branch":"integration"}},"base":{"label":"smooch:integration","ref":"integration","sha":"35422916d520559e1ad1714a9151097450aa1dfc","user":{"login":"smooch","id":14301989,"avatar_url":"https://avatars.githubusercontent.com/u/14301989?v=3","gravatar_id":"","url":"https://api.github.com/users/smooch","html_url":"https://github.com/smooch","followers_url":"https://api.github.com/users/smooch/followers","following_url":"https://api.github.com/users/smooch/following{/other_user}","gists_url":"https://api.github.com/users/smooch/gists{/gist_id}","starred_url":"https://api.github.com/users/smooch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smooch/subscriptions","organizations_url":"https://api.github.com/users/smooch/orgs","repos_url":"https://api.github.com/users/smooch/repos","events_url":"https://api.github.com/users/smooch/events{/privacy}","received_events_url":"https://api.github.com/users/smooch/received_events","type":"Organization","site_admin":false},"repo":{"id":36675403,"name":"smooch-js","full_name":"smooch/smooch-js","owner":{"login":"smooch","id":14301989,"avatar_url":"https://avatars.githubusercontent.com/u/14301989?v=3","gravatar_id":"","url":"https://api.github.com/users/smooch","html_url":"https://github.com/smooch","followers_url":"https://api.github.com/users/smooch/followers","following_url":"https://api.github.com/users/smooch/following{/other_user}","gists_url":"https://api.github.com/users/smooch/gists{/gist_id}","starred_url":"https://api.github.com/users/smooch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smooch/subscriptions","organizations_url":"https://api.github.com/users/smooch/orgs","repos_url":"https://api.github.com/users/smooch/repos","events_url":"https://api.github.com/users/smooch/events{/privacy}","received_events_url":"https://api.github.com/users/smooch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smooch/smooch-js","description":"Smooch lets you have rich conversations with your users, right in your app or on your website.","fork":false,"url":"https://api.github.com/repos/smooch/smooch-js","forks_url":"https://api.github.com/repos/smooch/smooch-js/forks","keys_url":"https://api.github.com/repos/smooch/smooch-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smooch/smooch-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smooch/smooch-js/teams","hooks_url":"https://api.github.com/repos/smooch/smooch-js/hooks","issue_events_url":"https://api.github.com/repos/smooch/smooch-js/issues/events{/number}","events_url":"https://api.github.com/repos/smooch/smooch-js/events","assignees_url":"https://api.github.com/repos/smooch/smooch-js/assignees{/user}","branches_url":"https://api.github.com/repos/smooch/smooch-js/branches{/branch}","tags_url":"https://api.github.com/repos/smooch/smooch-js/tags","blobs_url":"https://api.github.com/repos/smooch/smooch-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smooch/smooch-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smooch/smooch-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/smooch/smooch-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smooch/smooch-js/statuses/{sha}","languages_url":"https://api.github.com/repos/smooch/smooch-js/languages","stargazers_url":"https://api.github.com/repos/smooch/smooch-js/stargazers","contributors_url":"https://api.github.com/repos/smooch/smooch-js/contributors","subscribers_url":"https://api.github.com/repos/smooch/smooch-js/subscribers","subscription_url":"https://api.github.com/repos/smooch/smooch-js/subscription","commits_url":"https://api.github.com/repos/smooch/smooch-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/smooch/smooch-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/smooch/smooch-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/smooch/smooch-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/smooch/smooch-js/contents/{+path}","compare_url":"https://api.github.com/repos/smooch/smooch-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smooch/smooch-js/merges","archive_url":"https://api.github.com/repos/smooch/smooch-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smooch/smooch-js/downloads","issues_url":"https://api.github.com/repos/smooch/smooch-js/issues{/number}","pulls_url":"https://api.github.com/repos/smooch/smooch-js/pulls{/number}","milestones_url":"https://api.github.com/repos/smooch/smooch-js/milestones{/number}","notifications_url":"https://api.github.com/repos/smooch/smooch-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smooch/smooch-js/labels{/name}","releases_url":"https://api.github.com/repos/smooch/smooch-js/releases{/id}","deployments_url":"https://api.github.com/repos/smooch/smooch-js/deployments","created_at":"2015-06-01T17:03:32Z","updated_at":"2016-03-17T09:07:06Z","pushed_at":"2016-03-22T12:26:34Z","git_url":"git://github.com/smooch/smooch-js.git","ssh_url":"git@github.com:smooch/smooch-js.git","clone_url":"https://github.com/smooch/smooch-js.git","svn_url":"https://github.com/smooch/smooch-js","homepage":"https://smooch.io","size":10470,"stargazers_count":51,"watchers_count":51,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":5,"forks":18,"open_issues":5,"watchers":51,"default_branch":"integration"}},"_links":{"self":{"href":"https://api.github.com/repos/smooch/smooch-js/pulls/210"},"html":{"href":"https://github.com/smooch/smooch-js/pull/210"},"issue":{"href":"https://api.github.com/repos/smooch/smooch-js/issues/210"},"comments":{"href":"https://api.github.com/repos/smooch/smooch-js/issues/210/comments"},"review_comments":{"href":"https://api.github.com/repos/smooch/smooch-js/pulls/210/comments"},"review_comment":{"href":"https://api.github.com/repos/smooch/smooch-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smooch/smooch-js/pulls/210/commits"},"statuses":{"href":"https://api.github.com/repos/smooch/smooch-js/statuses/54caa53509d22d3d4ef0ba7846da3a80393232a7"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":10,"deletions":2,"changed_files":1}}