{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10651","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10651/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10651/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10651/events","html_url":"https://github.com/ManageIQ/manageiq/pull/10651","id":172326737,"number":10651,"title":"Changed supports_provisioning? logic to return false from base class","user":{"login":"h-kataria","id":3450808,"avatar_url":"https://avatars.githubusercontent.com/u/3450808?v=3","gravatar_id":"","url":"https://api.github.com/users/h-kataria","html_url":"https://github.com/h-kataria","followers_url":"https://api.github.com/users/h-kataria/followers","following_url":"https://api.github.com/users/h-kataria/following{/other_user}","gists_url":"https://api.github.com/users/h-kataria/gists{/gist_id}","starred_url":"https://api.github.com/users/h-kataria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-kataria/subscriptions","organizations_url":"https://api.github.com/users/h-kataria/orgs","repos_url":"https://api.github.com/users/h-kataria/repos","events_url":"https://api.github.com/users/h-kataria/events{/privacy}","received_events_url":"https://api.github.com/users/h-kataria/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/darga/yes","name":"darga/yes","color":"000000"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/pluggable%20providers","name":"pluggable providers","color":"5319e7"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/ui","name":"ui","color":"5319e7"}],"state":"closed","locked":false,"assignee":{"login":"durandom","id":161888,"avatar_url":"https://avatars.githubusercontent.com/u/161888?v=3","gravatar_id":"","url":"https://api.github.com/users/durandom","html_url":"https://github.com/durandom","followers_url":"https://api.github.com/users/durandom/followers","following_url":"https://api.github.com/users/durandom/following{/other_user}","gists_url":"https://api.github.com/users/durandom/gists{/gist_id}","starred_url":"https://api.github.com/users/durandom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/durandom/subscriptions","organizations_url":"https://api.github.com/users/durandom/orgs","repos_url":"https://api.github.com/users/durandom/repos","events_url":"https://api.github.com/users/durandom/events{/privacy}","received_events_url":"https://api.github.com/users/durandom/received_events","type":"User","site_admin":false},"assignees":[{"login":"durandom","id":161888,"avatar_url":"https://avatars.githubusercontent.com/u/161888?v=3","gravatar_id":"","url":"https://api.github.com/users/durandom","html_url":"https://github.com/durandom","followers_url":"https://api.github.com/users/durandom/followers","following_url":"https://api.github.com/users/durandom/following{/other_user}","gists_url":"https://api.github.com/users/durandom/gists{/gist_id}","starred_url":"https://api.github.com/users/durandom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/durandom/subscriptions","organizations_url":"https://api.github.com/users/durandom/orgs","repos_url":"https://api.github.com/users/durandom/repos","events_url":"https://api.github.com/users/durandom/events{/privacy}","received_events_url":"https://api.github.com/users/durandom/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/ManageIQ/manageiq/milestones/40","html_url":"https://github.com/ManageIQ/manageiq/milestones/Sprint%2046%20Ending%20Sep%2012,%202016","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones/40/labels","id":1958088,"number":40,"title":"Sprint 46 Ending Sep 12, 2016","description":"","creator":{"login":"chessbyte","id":82161,"avatar_url":"https://avatars.githubusercontent.com/u/82161?v=3","gravatar_id":"","url":"https://api.github.com/users/chessbyte","html_url":"https://github.com/chessbyte","followers_url":"https://api.github.com/users/chessbyte/followers","following_url":"https://api.github.com/users/chessbyte/following{/other_user}","gists_url":"https://api.github.com/users/chessbyte/gists{/gist_id}","starred_url":"https://api.github.com/users/chessbyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chessbyte/subscriptions","organizations_url":"https://api.github.com/users/chessbyte/orgs","repos_url":"https://api.github.com/users/chessbyte/repos","events_url":"https://api.github.com/users/chessbyte/events{/privacy}","received_events_url":"https://api.github.com/users/chessbyte/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":159,"state":"open","created_at":"2016-08-23T14:02:37Z","updated_at":"2016-09-01T01:11:49Z","due_on":"2016-09-12T00:00:00Z","closed_at":null},"comments":10,"created_at":"2016-08-21T15:43:54Z","updated_at":"2016-09-01T01:12:42Z","closed_at":"2016-08-23T09:27:33Z","pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10651","html_url":"https://github.com/ManageIQ/manageiq/pull/10651","diff_url":"https://github.com/ManageIQ/manageiq/pull/10651.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/10651.patch"},"body":"And added logic into subclasses that support template provisoning to return true/false based upon condition. Changes to address https://github.com/ManageIQ/manageiq/pull/10561#discussion_r75485697\r\n\r\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1344079\r\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1347278\r\n\r\n@dclarizio @gmcculloug please review, this is a follow up PR to address your comment https://github.com/ManageIQ/manageiq/pull/10561#discussion_r75485697.  \r\nAdded provisioning support for templates to match with methods here: \r\nhttps://github.com/ManageIQ/manageiq/blob/master/app/models/miq_template.rb#L28\r\nhttps://github.com/ManageIQ/manageiq/blob/master/app/models/manageiq/providers/cloud_manager/template.rb#L4\r\nhttps://github.com/ManageIQ/manageiq/blob/master/app/models/manageiq/providers/infra_manager/template.rb#L4"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/243948557","html_url":"https://github.com/ManageIQ/manageiq/pull/10651#issuecomment-243948557","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10651","id":243948557,"user":{"login":"chessbyte","id":82161,"avatar_url":"https://avatars.githubusercontent.com/u/82161?v=3","gravatar_id":"","url":"https://api.github.com/users/chessbyte","html_url":"https://github.com/chessbyte","followers_url":"https://api.github.com/users/chessbyte/followers","following_url":"https://api.github.com/users/chessbyte/following{/other_user}","gists_url":"https://api.github.com/users/chessbyte/gists{/gist_id}","starred_url":"https://api.github.com/users/chessbyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chessbyte/subscriptions","organizations_url":"https://api.github.com/users/chessbyte/orgs","repos_url":"https://api.github.com/users/chessbyte/repos","events_url":"https://api.github.com/users/chessbyte/events{/privacy}","received_events_url":"https://api.github.com/users/chessbyte/received_events","type":"User","site_admin":false},"created_at":"2016-09-01T01:12:42Z","updated_at":"2016-09-01T01:12:42Z","body":"Darga Backport details:\r\n```sh\r\n$ git log\r\n\r\ncommit e8d3a21769ef09b06708e009bdc2934eb08bef0f\r\nMerge: 51b7e20 1c7c492\r\nAuthor: Oleg Barenboim <chessbyte@gmail.com>\r\nDate:   Wed Aug 31 21:11:47 2016 -0400\r\n\r\n    Merge pull request #10746 from h-kataria/pr_10651_to_darga\r\n    \r\n    [DARGA] - Changed supports_provisioning? logic to return false from base class\r\n\r\ncommit 51b7e20db37a958575c5e96ea56c835d1f774690\r\nAuthor: Marcel Hild <hild@b4mad.net>\r\nDate:   Tue Aug 23 16:13:19 2016 +0200\r\n\r\n    Merge pull request #34 from h-kataria/template_supports_provsioning\r\n    \r\n    Added supports_provisioning?  support for Amazon Template\r\n    (cherry picked from commit 777f9d7c612d6d9b6d0687925e3017ebc768340e)\r\n```"}}
{"actor":{"display_login":"chessbyte"}}