{"action":"closed","number":9115,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9115","id":72411367,"html_url":"https://github.com/ManageIQ/manageiq/pull/9115","diff_url":"https://github.com/ManageIQ/manageiq/pull/9115.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/9115.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/9115","number":9115,"state":"closed","locked":false,"title":"Make Live Migrate work when called from outside of an explorer view","user":{"login":"mansam","id":628956,"avatar_url":"https://avatars.githubusercontent.com/u/628956?v=3","gravatar_id":"","url":"https://api.github.com/users/mansam","html_url":"https://github.com/mansam","followers_url":"https://api.github.com/users/mansam/followers","following_url":"https://api.github.com/users/mansam/following{/other_user}","gists_url":"https://api.github.com/users/mansam/gists{/gist_id}","starred_url":"https://api.github.com/users/mansam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mansam/subscriptions","organizations_url":"https://api.github.com/users/mansam/orgs","repos_url":"https://api.github.com/users/mansam/repos","events_url":"https://api.github.com/users/mansam/events{/privacy}","received_events_url":"https://api.github.com/users/mansam/received_events","type":"User","site_admin":false},"body":"This PR refactors the Live Migrate action to work when called from outside of an explorer view, and wires up the CloudVolumeController so that it can handle when that button is clicked while drilling down into a volume's instance relationships.\r\n\r\nThis is intended as a partial fix for https://bugzilla.redhat.com/show_bug.cgi?id=1334275 and https://bugzilla.redhat.com/show_bug.cgi?id=1339198, which revealed that buttons on the Instance list toolbar don't work when you navigate to it from a Cloud Volume or Provider.\r\n\r\nIf this is the right approach and reviewers are satisfied with it, I'll make similar changes to fix the rest of the broken buttons.\r\n\r\n@h-kataria @tzumainn ","created_at":"2016-06-02T20:24:21Z","updated_at":"2016-06-08T20:54:35Z","closed_at":"2016-06-08T20:54:34Z","merged_at":null,"merge_commit_sha":"b9c483bf3a8d2b60122dabdfab22ddbc3f24167c","assignee":{"login":"h-kataria","id":3450808,"avatar_url":"https://avatars.githubusercontent.com/u/3450808?v=3","gravatar_id":"","url":"https://api.github.com/users/h-kataria","html_url":"https://github.com/h-kataria","followers_url":"https://api.github.com/users/h-kataria/followers","following_url":"https://api.github.com/users/h-kataria/following{/other_user}","gists_url":"https://api.github.com/users/h-kataria/gists{/gist_id}","starred_url":"https://api.github.com/users/h-kataria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-kataria/subscriptions","organizations_url":"https://api.github.com/users/h-kataria/orgs","repos_url":"https://api.github.com/users/h-kataria/repos","events_url":"https://api.github.com/users/h-kataria/events{/privacy}","received_events_url":"https://api.github.com/users/h-kataria/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9115/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9115/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/9115/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/f321d2e2d8ffdc5fb789fd918f9afc59d41fd242","head":{"label":"mansam:make-live-migrate-work-outside-explorers","ref":"make-live-migrate-work-outside-explorers","sha":"f321d2e2d8ffdc5fb789fd918f9afc59d41fd242","user":{"login":"mansam","id":628956,"avatar_url":"https://avatars.githubusercontent.com/u/628956?v=3","gravatar_id":"","url":"https://api.github.com/users/mansam","html_url":"https://github.com/mansam","followers_url":"https://api.github.com/users/mansam/followers","following_url":"https://api.github.com/users/mansam/following{/other_user}","gists_url":"https://api.github.com/users/mansam/gists{/gist_id}","starred_url":"https://api.github.com/users/mansam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mansam/subscriptions","organizations_url":"https://api.github.com/users/mansam/orgs","repos_url":"https://api.github.com/users/mansam/repos","events_url":"https://api.github.com/users/mansam/events{/privacy}","received_events_url":"https://api.github.com/users/mansam/received_events","type":"User","site_admin":false},"repo":{"id":46511055,"name":"manageiq","full_name":"mansam/manageiq","owner":{"login":"mansam","id":628956,"avatar_url":"https://avatars.githubusercontent.com/u/628956?v=3","gravatar_id":"","url":"https://api.github.com/users/mansam","html_url":"https://github.com/mansam","followers_url":"https://api.github.com/users/mansam/followers","following_url":"https://api.github.com/users/mansam/following{/other_user}","gists_url":"https://api.github.com/users/mansam/gists{/gist_id}","starred_url":"https://api.github.com/users/mansam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mansam/subscriptions","organizations_url":"https://api.github.com/users/mansam/orgs","repos_url":"https://api.github.com/users/mansam/repos","events_url":"https://api.github.com/users/mansam/events{/privacy}","received_events_url":"https://api.github.com/users/mansam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mansam/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/mansam/manageiq","forks_url":"https://api.github.com/repos/mansam/manageiq/forks","keys_url":"https://api.github.com/repos/mansam/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mansam/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mansam/manageiq/teams","hooks_url":"https://api.github.com/repos/mansam/manageiq/hooks","issue_events_url":"https://api.github.com/repos/mansam/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/mansam/manageiq/events","assignees_url":"https://api.github.com/repos/mansam/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/mansam/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/mansam/manageiq/tags","blobs_url":"https://api.github.com/repos/mansam/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mansam/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mansam/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/mansam/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mansam/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/mansam/manageiq/languages","stargazers_url":"https://api.github.com/repos/mansam/manageiq/stargazers","contributors_url":"https://api.github.com/repos/mansam/manageiq/contributors","subscribers_url":"https://api.github.com/repos/mansam/manageiq/subscribers","subscription_url":"https://api.github.com/repos/mansam/manageiq/subscription","commits_url":"https://api.github.com/repos/mansam/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/mansam/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/mansam/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/mansam/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/mansam/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/mansam/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mansam/manageiq/merges","archive_url":"https://api.github.com/repos/mansam/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mansam/manageiq/downloads","issues_url":"https://api.github.com/repos/mansam/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/mansam/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/mansam/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/mansam/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mansam/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/mansam/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/mansam/manageiq/deployments","created_at":"2015-11-19T18:11:33Z","updated_at":"2015-11-19T18:11:56Z","pushed_at":"2016-06-08T20:42:37Z","git_url":"git://github.com/mansam/manageiq.git","ssh_url":"git@github.com:mansam/manageiq.git","clone_url":"https://github.com/mansam/manageiq.git","svn_url":"https://github.com/mansam/manageiq","homepage":"manageiq.org","size":129776,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"a0d0e627f65f99bf4b95010eed982479201cda82","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq/deployments","created_at":"2014-06-13T02:31:26Z","updated_at":"2016-06-08T14:16:27Z","pushed_at":"2016-06-08T20:54:10Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":170333,"stargazers_count":278,"watchers_count":278,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":296,"mirror_url":null,"open_issues_count":701,"forks":296,"open_issues":701,"watchers":278,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9115"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/9115"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/9115"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/9115/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9115/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9115/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/f321d2e2d8ffdc5fb789fd918f9afc59d41fd242"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":8,"review_comments":0,"commits":1,"additions":159,"deletions":99,"changed_files":7}}
{"actor":{"display_login":"mansam"}}