{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11474","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11474/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11474/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11474/events","html_url":"https://github.com/ManageIQ/manageiq/pull/11474","id":178766601,"number":11474,"title":"[WIP] Remove our vendored rspec `have_attributes` matcher","user":{"login":"cben","id":273688,"avatar_url":"https://avatars.githubusercontent.com/u/273688?v=3","gravatar_id":"","url":"https://api.github.com/users/cben","html_url":"https://github.com/cben","followers_url":"https://api.github.com/users/cben/followers","following_url":"https://api.github.com/users/cben/following{/other_user}","gists_url":"https://api.github.com/users/cben/gists{/gist_id}","starred_url":"https://api.github.com/users/cben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cben/subscriptions","organizations_url":"https://api.github.com/users/cben/orgs","repos_url":"https://api.github.com/users/cben/repos","events_url":"https://api.github.com/users/cben/events{/privacy}","received_events_url":"https://api.github.com/users/cben/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"chrisarcand","id":2430490,"avatar_url":"https://avatars.githubusercontent.com/u/2430490?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisarcand","html_url":"https://github.com/chrisarcand","followers_url":"https://api.github.com/users/chrisarcand/followers","following_url":"https://api.github.com/users/chrisarcand/following{/other_user}","gists_url":"https://api.github.com/users/chrisarcand/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisarcand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisarcand/subscriptions","organizations_url":"https://api.github.com/users/chrisarcand/orgs","repos_url":"https://api.github.com/users/chrisarcand/repos","events_url":"https://api.github.com/users/chrisarcand/events{/privacy}","received_events_url":"https://api.github.com/users/chrisarcand/received_events","type":"User","site_admin":false},"assignees":[{"login":"chrisarcand","id":2430490,"avatar_url":"https://avatars.githubusercontent.com/u/2430490?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisarcand","html_url":"https://github.com/chrisarcand","followers_url":"https://api.github.com/users/chrisarcand/followers","following_url":"https://api.github.com/users/chrisarcand/following{/other_user}","gists_url":"https://api.github.com/users/chrisarcand/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisarcand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisarcand/subscriptions","organizations_url":"https://api.github.com/users/chrisarcand/orgs","repos_url":"https://api.github.com/users/chrisarcand/repos","events_url":"https://api.github.com/users/chrisarcand/events{/privacy}","received_events_url":"https://api.github.com/users/chrisarcand/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-09-23T02:04:28Z","updated_at":"2016-09-23T08:59:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/11474","html_url":"https://github.com/ManageIQ/manageiq/pull/11474","diff_url":"https://github.com/ManageIQ/manageiq/pull/11474.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/11474.patch"},"body":"It exists in upstream rspec-expectations, and is better.  EDIT: not so simple\r\nI saw uninformative \"have the same attributes as passed\",\r\ncomplained to rspec: https://github.com/rspec/rspec-expectations/issues/944\r\nonly to discover rspec's implementation does it perfectly\r\nand the problem is in our copy.  Oops.\r\n\r\nHope travis won't tell me this breaks everything...\r\n\r\n@miq-bot assign chrisarcand"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/249139582","html_url":"https://github.com/ManageIQ/manageiq/pull/11474#issuecomment-249139582","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/11474","id":249139582,"user":{"login":"cben","id":273688,"avatar_url":"https://avatars.githubusercontent.com/u/273688?v=3","gravatar_id":"","url":"https://api.github.com/users/cben","html_url":"https://github.com/cben","followers_url":"https://api.github.com/users/cben/followers","following_url":"https://api.github.com/users/cben/following{/other_user}","gists_url":"https://api.github.com/users/cben/gists{/gist_id}","starred_url":"https://api.github.com/users/cben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cben/subscriptions","organizations_url":"https://api.github.com/users/cben/orgs","repos_url":"https://api.github.com/users/cben/repos","events_url":"https://api.github.com/users/cben/events{/privacy}","received_events_url":"https://api.github.com/users/cben/received_events","type":"User","site_admin":false},"created_at":"2016-09-23T08:59:27Z","updated_at":"2016-09-23T08:59:27Z","body":"OK, tons of errors.\r\nLooking at our matcher code, it seems it has 2 features upstream doesn't:\r\n\r\n1. If `.attr` fails, tries `['attr']`.  Most or all failures are of this kind!\r\n    IMO relying on a matcher with same name to have major different semantics than upstream is bad.\r\n    I'll try rewriting all these tests to use idiomatic `include` / `a_hash_including` matcher.\r\n2. automagically use `be_same_time_as`.\r\n    Not sure this magic is needed or used; it should be possible to explicitly compose where needed: `have_attributes(:foo => bar, :foo_time => be_same_time(bar_time))`.\r\n\r\nIf still fails, might have to backport upstream improvements into our version.\r\n\r\n@miq-bot add-label wip"}}
{"actor":{"display_login":"cben"}}