{"action":"created","comment":{"url":"https://api.github.com/repos/buildbot/buildbot/pulls/comments/91727261","pull_request_review_id":12238468,"id":91727261,"diff_hunk":"@@ -12,10 +12,13 @@\n # Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.\n #\n # Copyright Buildbot Team Members\n+import os\n+\n import mock","path":"master/buildbot/test/integration/test_worker_comm.py","position":6,"original_position":6,"commit_id":"baf935bb76b42c437cda402484974fb776f83413","original_commit_id":"baf935bb76b42c437cda402484974fb776f83413","user":{"login":"sa2ajj","id":447092,"avatar_url":"https://avatars.githubusercontent.com/u/447092?v=3","gravatar_id":"","url":"https://api.github.com/users/sa2ajj","html_url":"https://github.com/sa2ajj","followers_url":"https://api.github.com/users/sa2ajj/followers","following_url":"https://api.github.com/users/sa2ajj/following{/other_user}","gists_url":"https://api.github.com/users/sa2ajj/gists{/gist_id}","starred_url":"https://api.github.com/users/sa2ajj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sa2ajj/subscriptions","organizations_url":"https://api.github.com/users/sa2ajj/orgs","repos_url":"https://api.github.com/users/sa2ajj/repos","events_url":"https://api.github.com/users/sa2ajj/events{/privacy}","received_events_url":"https://api.github.com/users/sa2ajj/received_events","type":"User","site_admin":false},"body":"please disregard this: we use `isort` to sort imports...","created_at":"2016-12-09T14:43:29Z","updated_at":"2016-12-09T14:43:29Z","html_url":"https://github.com/buildbot/buildbot/pull/2387#discussion_r91727261","pull_request_url":"https://api.github.com/repos/buildbot/buildbot/pulls/2387","_links":{"self":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/comments/91727261"},"html":{"href":"https://github.com/buildbot/buildbot/pull/2387#discussion_r91727261"},"pull_request":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/2387"}}},"pull_request":{"url":"https://api.github.com/repos/buildbot/buildbot/pulls/2387","id":83798412,"html_url":"https://github.com/buildbot/buildbot/pull/2387","diff_url":"https://github.com/buildbot/buildbot/pull/2387.diff","patch_url":"https://github.com/buildbot/buildbot/pull/2387.patch","issue_url":"https://api.github.com/repos/buildbot/buildbot/issues/2387","number":2387,"state":"open","locked":false,"title":"WIP worker connecting with endpoints","user":{"login":"gracinet","id":474220,"avatar_url":"https://avatars.githubusercontent.com/u/474220?v=3","gravatar_id":"","url":"https://api.github.com/users/gracinet","html_url":"https://github.com/gracinet","followers_url":"https://api.github.com/users/gracinet/followers","following_url":"https://api.github.com/users/gracinet/following{/other_user}","gists_url":"https://api.github.com/users/gracinet/gists{/gist_id}","starred_url":"https://api.github.com/users/gracinet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gracinet/subscriptions","organizations_url":"https://api.github.com/users/gracinet/orgs","repos_url":"https://api.github.com/users/gracinet/repos","events_url":"https://api.github.com/users/gracinet/events{/privacy}","received_events_url":"https://api.github.com/users/gracinet/received_events","type":"User","site_admin":false},"body":"This PR is intended to make the worker connect with [endpoints](https://twistedmatrix.com/documents/current/core/howto/endpoints.html). In particular, it'll bring IPv6, TLS, sockets created by service manager (systemd) to the game.\n\nFor now it's work in progress, to see how tests behave in Travis\n","created_at":"2016-09-02T13:06:33Z","updated_at":"2016-12-09T14:43:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31aa5b0c92987a12a96b6156aab143f23ccef438","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/buildbot/buildbot/pulls/2387/commits","review_comments_url":"https://api.github.com/repos/buildbot/buildbot/pulls/2387/comments","review_comment_url":"https://api.github.com/repos/buildbot/buildbot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/buildbot/buildbot/issues/2387/comments","statuses_url":"https://api.github.com/repos/buildbot/buildbot/statuses/baf935bb76b42c437cda402484974fb776f83413","head":{"label":"gracinet:2880_worker_endpoint","ref":"2880_worker_endpoint","sha":"baf935bb76b42c437cda402484974fb776f83413","user":{"login":"gracinet","id":474220,"avatar_url":"https://avatars.githubusercontent.com/u/474220?v=3","gravatar_id":"","url":"https://api.github.com/users/gracinet","html_url":"https://github.com/gracinet","followers_url":"https://api.github.com/users/gracinet/followers","following_url":"https://api.github.com/users/gracinet/following{/other_user}","gists_url":"https://api.github.com/users/gracinet/gists{/gist_id}","starred_url":"https://api.github.com/users/gracinet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gracinet/subscriptions","organizations_url":"https://api.github.com/users/gracinet/orgs","repos_url":"https://api.github.com/users/gracinet/repos","events_url":"https://api.github.com/users/gracinet/events{/privacy}","received_events_url":"https://api.github.com/users/gracinet/received_events","type":"User","site_admin":false},"repo":{"id":3417399,"name":"buildbot","full_name":"gracinet/buildbot","owner":{"login":"gracinet","id":474220,"avatar_url":"https://avatars.githubusercontent.com/u/474220?v=3","gravatar_id":"","url":"https://api.github.com/users/gracinet","html_url":"https://github.com/gracinet","followers_url":"https://api.github.com/users/gracinet/followers","following_url":"https://api.github.com/users/gracinet/following{/other_user}","gists_url":"https://api.github.com/users/gracinet/gists{/gist_id}","starred_url":"https://api.github.com/users/gracinet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gracinet/subscriptions","organizations_url":"https://api.github.com/users/gracinet/orgs","repos_url":"https://api.github.com/users/gracinet/repos","events_url":"https://api.github.com/users/gracinet/events{/privacy}","received_events_url":"https://api.github.com/users/gracinet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gracinet/buildbot","description":"Python-based continuous integration testing framework; send pull requests for your patches!","fork":true,"url":"https://api.github.com/repos/gracinet/buildbot","forks_url":"https://api.github.com/repos/gracinet/buildbot/forks","keys_url":"https://api.github.com/repos/gracinet/buildbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gracinet/buildbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gracinet/buildbot/teams","hooks_url":"https://api.github.com/repos/gracinet/buildbot/hooks","issue_events_url":"https://api.github.com/repos/gracinet/buildbot/issues/events{/number}","events_url":"https://api.github.com/repos/gracinet/buildbot/events","assignees_url":"https://api.github.com/repos/gracinet/buildbot/assignees{/user}","branches_url":"https://api.github.com/repos/gracinet/buildbot/branches{/branch}","tags_url":"https://api.github.com/repos/gracinet/buildbot/tags","blobs_url":"https://api.github.com/repos/gracinet/buildbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gracinet/buildbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gracinet/buildbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/gracinet/buildbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gracinet/buildbot/statuses/{sha}","languages_url":"https://api.github.com/repos/gracinet/buildbot/languages","stargazers_url":"https://api.github.com/repos/gracinet/buildbot/stargazers","contributors_url":"https://api.github.com/repos/gracinet/buildbot/contributors","subscribers_url":"https://api.github.com/repos/gracinet/buildbot/subscribers","subscription_url":"https://api.github.com/repos/gracinet/buildbot/subscription","commits_url":"https://api.github.com/repos/gracinet/buildbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/gracinet/buildbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/gracinet/buildbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/gracinet/buildbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/gracinet/buildbot/contents/{+path}","compare_url":"https://api.github.com/repos/gracinet/buildbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gracinet/buildbot/merges","archive_url":"https://api.github.com/repos/gracinet/buildbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gracinet/buildbot/downloads","issues_url":"https://api.github.com/repos/gracinet/buildbot/issues{/number}","pulls_url":"https://api.github.com/repos/gracinet/buildbot/pulls{/number}","milestones_url":"https://api.github.com/repos/gracinet/buildbot/milestones{/number}","notifications_url":"https://api.github.com/repos/gracinet/buildbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gracinet/buildbot/labels{/name}","releases_url":"https://api.github.com/repos/gracinet/buildbot/releases{/id}","deployments_url":"https://api.github.com/repos/gracinet/buildbot/deployments","created_at":"2012-02-11T19:46:45Z","updated_at":"2016-04-01T17:56:24Z","pushed_at":"2016-09-19T11:39:57Z","git_url":"git://github.com/gracinet/buildbot.git","ssh_url":"git@github.com:gracinet/buildbot.git","clone_url":"https://github.com/gracinet/buildbot.git","svn_url":"https://github.com/gracinet/buildbot","homepage":"http://buildbot.net","size":40598,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"buildbot:master","ref":"master","sha":"cc3696b86a3949c3ec3a5d3686b31355b9832a34","user":{"login":"buildbot","id":324515,"avatar_url":"https://avatars.githubusercontent.com/u/324515?v=3","gravatar_id":"","url":"https://api.github.com/users/buildbot","html_url":"https://github.com/buildbot","followers_url":"https://api.github.com/users/buildbot/followers","following_url":"https://api.github.com/users/buildbot/following{/other_user}","gists_url":"https://api.github.com/users/buildbot/gists{/gist_id}","starred_url":"https://api.github.com/users/buildbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildbot/subscriptions","organizations_url":"https://api.github.com/users/buildbot/orgs","repos_url":"https://api.github.com/users/buildbot/repos","events_url":"https://api.github.com/users/buildbot/events{/privacy}","received_events_url":"https://api.github.com/users/buildbot/received_events","type":"Organization","site_admin":false},"repo":{"id":760165,"name":"buildbot","full_name":"buildbot/buildbot","owner":{"login":"buildbot","id":324515,"avatar_url":"https://avatars.githubusercontent.com/u/324515?v=3","gravatar_id":"","url":"https://api.github.com/users/buildbot","html_url":"https://github.com/buildbot","followers_url":"https://api.github.com/users/buildbot/followers","following_url":"https://api.github.com/users/buildbot/following{/other_user}","gists_url":"https://api.github.com/users/buildbot/gists{/gist_id}","starred_url":"https://api.github.com/users/buildbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildbot/subscriptions","organizations_url":"https://api.github.com/users/buildbot/orgs","repos_url":"https://api.github.com/users/buildbot/repos","events_url":"https://api.github.com/users/buildbot/events{/privacy}","received_events_url":"https://api.github.com/users/buildbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/buildbot/buildbot","description":"Python-based continuous integration testing framework; your pull requests are more than welcome!","fork":false,"url":"https://api.github.com/repos/buildbot/buildbot","forks_url":"https://api.github.com/repos/buildbot/buildbot/forks","keys_url":"https://api.github.com/repos/buildbot/buildbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buildbot/buildbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buildbot/buildbot/teams","hooks_url":"https://api.github.com/repos/buildbot/buildbot/hooks","issue_events_url":"https://api.github.com/repos/buildbot/buildbot/issues/events{/number}","events_url":"https://api.github.com/repos/buildbot/buildbot/events","assignees_url":"https://api.github.com/repos/buildbot/buildbot/assignees{/user}","branches_url":"https://api.github.com/repos/buildbot/buildbot/branches{/branch}","tags_url":"https://api.github.com/repos/buildbot/buildbot/tags","blobs_url":"https://api.github.com/repos/buildbot/buildbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buildbot/buildbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buildbot/buildbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/buildbot/buildbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buildbot/buildbot/statuses/{sha}","languages_url":"https://api.github.com/repos/buildbot/buildbot/languages","stargazers_url":"https://api.github.com/repos/buildbot/buildbot/stargazers","contributors_url":"https://api.github.com/repos/buildbot/buildbot/contributors","subscribers_url":"https://api.github.com/repos/buildbot/buildbot/subscribers","subscription_url":"https://api.github.com/repos/buildbot/buildbot/subscription","commits_url":"https://api.github.com/repos/buildbot/buildbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/buildbot/buildbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/buildbot/buildbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/buildbot/buildbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/buildbot/buildbot/contents/{+path}","compare_url":"https://api.github.com/repos/buildbot/buildbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buildbot/buildbot/merges","archive_url":"https://api.github.com/repos/buildbot/buildbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buildbot/buildbot/downloads","issues_url":"https://api.github.com/repos/buildbot/buildbot/issues{/number}","pulls_url":"https://api.github.com/repos/buildbot/buildbot/pulls{/number}","milestones_url":"https://api.github.com/repos/buildbot/buildbot/milestones{/number}","notifications_url":"https://api.github.com/repos/buildbot/buildbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buildbot/buildbot/labels{/name}","releases_url":"https://api.github.com/repos/buildbot/buildbot/releases{/id}","deployments_url":"https://api.github.com/repos/buildbot/buildbot/deployments","created_at":"2010-07-06T17:56:53Z","updated_at":"2016-12-09T12:11:01Z","pushed_at":"2016-12-09T14:41:10Z","git_url":"git://github.com/buildbot/buildbot.git","ssh_url":"git@github.com:buildbot/buildbot.git","clone_url":"https://github.com/buildbot/buildbot.git","svn_url":"https://github.com/buildbot/buildbot","homepage":"http://buildbot.net","size":95799,"stargazers_count":2473,"watchers_count":2473,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1007,"mirror_url":null,"open_issues_count":20,"forks":1007,"open_issues":20,"watchers":2473,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/2387"},"html":{"href":"https://github.com/buildbot/buildbot/pull/2387"},"issue":{"href":"https://api.github.com/repos/buildbot/buildbot/issues/2387"},"comments":{"href":"https://api.github.com/repos/buildbot/buildbot/issues/2387/comments"},"review_comments":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/2387/comments"},"review_comment":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/2387/commits"},"statuses":{"href":"https://api.github.com/repos/buildbot/buildbot/statuses/baf935bb76b42c437cda402484974fb776f83413"}}}}
{"actor":{"display_login":"sa2ajj"}}