{"action":"created","comment":{"url":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/comments/70889732","id":70889732,"diff_hunk":"@@ -0,0 +1,47 @@\n+package io.buoyant.namerd.storage.consul\n+\n+import com.fasterxml.jackson.annotation.JsonIgnore\n+import com.twitter.finagle.tracing.NullTracer\n+import com.twitter.finagle.{Http, Path}\n+import io.buoyant.config.types.Port\n+import io.buoyant.consul.SetHostFilter\n+import io.buoyant.consul.v1.KvApi\n+import io.buoyant.namerd.{DtabStore, DtabStoreConfig, DtabStoreInitializer}\n+\n+case class ConsulConfig(\n+  host: Option[String],\n+  port: Option[Port],\n+  pathPrefix: Option[Path]\n+) extends DtabStoreConfig {\n+  import ConsulConfig._\n+\n+  @JsonIgnore\n+  override val experimentalRequired = true\n+\n+  @JsonIgnore\n+  override def mkDtabStore: DtabStore = {\n+    val serviceHost = host getOrElse DefaultHost","path":"namerd/storage/consul/src/main/scala/io/buoyant/namerd/storage/consul/ConsulDtabStoreInitializer.scala","position":23,"original_position":23,"commit_id":"d84f7ef75c7efc0efef89266d0738eeb3cfae172","original_commit_id":"7d2d48d74255b560dec22f2cf252a5fe37644e8a","user":{"login":"adleong","id":3979810,"avatar_url":"https://avatars.githubusercontent.com/u/3979810?v=3","gravatar_id":"","url":"https://api.github.com/users/adleong","html_url":"https://github.com/adleong","followers_url":"https://api.github.com/users/adleong/followers","following_url":"https://api.github.com/users/adleong/following{/other_user}","gists_url":"https://api.github.com/users/adleong/gists{/gist_id}","starred_url":"https://api.github.com/users/adleong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adleong/subscriptions","organizations_url":"https://api.github.com/users/adleong/orgs","repos_url":"https://api.github.com/users/adleong/repos","events_url":"https://api.github.com/users/adleong/events{/privacy}","received_events_url":"https://api.github.com/users/adleong/received_events","type":"User","site_admin":false},"body":"`host.getOrElse(DefaultHost)`","created_at":"2016-07-14T21:42:10Z","updated_at":"2016-07-14T21:42:10Z","html_url":"https://github.com/BuoyantIO/linkerd/pull/541#discussion_r70889732","pull_request_url":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/541","_links":{"self":{"href":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/comments/70889732"},"html":{"href":"https://github.com/BuoyantIO/linkerd/pull/541#discussion_r70889732"},"pull_request":{"href":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/541"}}},"pull_request":{"url":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/541","id":77351125,"html_url":"https://github.com/BuoyantIO/linkerd/pull/541","diff_url":"https://github.com/BuoyantIO/linkerd/pull/541.diff","patch_url":"https://github.com/BuoyantIO/linkerd/pull/541.patch","issue_url":"https://api.github.com/repos/BuoyantIO/linkerd/issues/541","number":541,"state":"open","locked":false,"title":"Experimental Implementation of Consul Storage for Namerd","user":{"login":"Ashald","id":397987,"avatar_url":"https://avatars.githubusercontent.com/u/397987?v=3","gravatar_id":"","url":"https://api.github.com/users/Ashald","html_url":"https://github.com/Ashald","followers_url":"https://api.github.com/users/Ashald/followers","following_url":"https://api.github.com/users/Ashald/following{/other_user}","gists_url":"https://api.github.com/users/Ashald/gists{/gist_id}","starred_url":"https://api.github.com/users/Ashald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ashald/subscriptions","organizations_url":"https://api.github.com/users/Ashald/orgs","repos_url":"https://api.github.com/users/Ashald/repos","events_url":"https://api.github.com/users/Ashald/events{/privacy}","received_events_url":"https://api.github.com/users/Ashald/received_events","type":"User","site_admin":false},"body":"Although there are no integration tests I verified that it works with local Consul installation.","created_at":"2016-07-13T19:56:03Z","updated_at":"2016-07-14T21:42:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41be21dd5165d3615fe22392fd2fe5b96bd5b628","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/541/commits","review_comments_url":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/541/comments","review_comment_url":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BuoyantIO/linkerd/issues/541/comments","statuses_url":"https://api.github.com/repos/BuoyantIO/linkerd/statuses/d84f7ef75c7efc0efef89266d0738eeb3cfae172","head":{"label":"Ashald:feature/consul-store","ref":"feature/consul-store","sha":"d84f7ef75c7efc0efef89266d0738eeb3cfae172","user":{"login":"Ashald","id":397987,"avatar_url":"https://avatars.githubusercontent.com/u/397987?v=3","gravatar_id":"","url":"https://api.github.com/users/Ashald","html_url":"https://github.com/Ashald","followers_url":"https://api.github.com/users/Ashald/followers","following_url":"https://api.github.com/users/Ashald/following{/other_user}","gists_url":"https://api.github.com/users/Ashald/gists{/gist_id}","starred_url":"https://api.github.com/users/Ashald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ashald/subscriptions","organizations_url":"https://api.github.com/users/Ashald/orgs","repos_url":"https://api.github.com/users/Ashald/repos","events_url":"https://api.github.com/users/Ashald/events{/privacy}","received_events_url":"https://api.github.com/users/Ashald/received_events","type":"User","site_admin":false},"repo":{"id":62817214,"name":"linkerd","full_name":"Ashald/linkerd","owner":{"login":"Ashald","id":397987,"avatar_url":"https://avatars.githubusercontent.com/u/397987?v=3","gravatar_id":"","url":"https://api.github.com/users/Ashald","html_url":"https://github.com/Ashald","followers_url":"https://api.github.com/users/Ashald/followers","following_url":"https://api.github.com/users/Ashald/following{/other_user}","gists_url":"https://api.github.com/users/Ashald/gists{/gist_id}","starred_url":"https://api.github.com/users/Ashald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ashald/subscriptions","organizations_url":"https://api.github.com/users/Ashald/orgs","repos_url":"https://api.github.com/users/Ashald/repos","events_url":"https://api.github.com/users/Ashald/events{/privacy}","received_events_url":"https://api.github.com/users/Ashald/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ashald/linkerd","description":"A dynamic linker for microservices.","fork":true,"url":"https://api.github.com/repos/Ashald/linkerd","forks_url":"https://api.github.com/repos/Ashald/linkerd/forks","keys_url":"https://api.github.com/repos/Ashald/linkerd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ashald/linkerd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ashald/linkerd/teams","hooks_url":"https://api.github.com/repos/Ashald/linkerd/hooks","issue_events_url":"https://api.github.com/repos/Ashald/linkerd/issues/events{/number}","events_url":"https://api.github.com/repos/Ashald/linkerd/events","assignees_url":"https://api.github.com/repos/Ashald/linkerd/assignees{/user}","branches_url":"https://api.github.com/repos/Ashald/linkerd/branches{/branch}","tags_url":"https://api.github.com/repos/Ashald/linkerd/tags","blobs_url":"https://api.github.com/repos/Ashald/linkerd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ashald/linkerd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ashald/linkerd/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ashald/linkerd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ashald/linkerd/statuses/{sha}","languages_url":"https://api.github.com/repos/Ashald/linkerd/languages","stargazers_url":"https://api.github.com/repos/Ashald/linkerd/stargazers","contributors_url":"https://api.github.com/repos/Ashald/linkerd/contributors","subscribers_url":"https://api.github.com/repos/Ashald/linkerd/subscribers","subscription_url":"https://api.github.com/repos/Ashald/linkerd/subscription","commits_url":"https://api.github.com/repos/Ashald/linkerd/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ashald/linkerd/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ashald/linkerd/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ashald/linkerd/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ashald/linkerd/contents/{+path}","compare_url":"https://api.github.com/repos/Ashald/linkerd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ashald/linkerd/merges","archive_url":"https://api.github.com/repos/Ashald/linkerd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ashald/linkerd/downloads","issues_url":"https://api.github.com/repos/Ashald/linkerd/issues{/number}","pulls_url":"https://api.github.com/repos/Ashald/linkerd/pulls{/number}","milestones_url":"https://api.github.com/repos/Ashald/linkerd/milestones{/number}","notifications_url":"https://api.github.com/repos/Ashald/linkerd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ashald/linkerd/labels{/name}","releases_url":"https://api.github.com/repos/Ashald/linkerd/releases{/id}","deployments_url":"https://api.github.com/repos/Ashald/linkerd/deployments","created_at":"2016-07-07T15:20:38Z","updated_at":"2016-07-07T15:20:40Z","pushed_at":"2016-07-14T21:32:14Z","git_url":"git://github.com/Ashald/linkerd.git","ssh_url":"git@github.com:Ashald/linkerd.git","clone_url":"https://github.com/Ashald/linkerd.git","svn_url":"https://github.com/Ashald/linkerd","homepage":"https://linkerd.io","size":1753,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BuoyantIO:master","ref":"master","sha":"309586e19f7b534650074378e98cd0939dd0b6ae","user":{"login":"BuoyantIO","id":10824329,"avatar_url":"https://avatars.githubusercontent.com/u/10824329?v=3","gravatar_id":"","url":"https://api.github.com/users/BuoyantIO","html_url":"https://github.com/BuoyantIO","followers_url":"https://api.github.com/users/BuoyantIO/followers","following_url":"https://api.github.com/users/BuoyantIO/following{/other_user}","gists_url":"https://api.github.com/users/BuoyantIO/gists{/gist_id}","starred_url":"https://api.github.com/users/BuoyantIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BuoyantIO/subscriptions","organizations_url":"https://api.github.com/users/BuoyantIO/orgs","repos_url":"https://api.github.com/users/BuoyantIO/repos","events_url":"https://api.github.com/users/BuoyantIO/events{/privacy}","received_events_url":"https://api.github.com/users/BuoyantIO/received_events","type":"Organization","site_admin":false},"repo":{"id":49605596,"name":"linkerd","full_name":"BuoyantIO/linkerd","owner":{"login":"BuoyantIO","id":10824329,"avatar_url":"https://avatars.githubusercontent.com/u/10824329?v=3","gravatar_id":"","url":"https://api.github.com/users/BuoyantIO","html_url":"https://github.com/BuoyantIO","followers_url":"https://api.github.com/users/BuoyantIO/followers","following_url":"https://api.github.com/users/BuoyantIO/following{/other_user}","gists_url":"https://api.github.com/users/BuoyantIO/gists{/gist_id}","starred_url":"https://api.github.com/users/BuoyantIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BuoyantIO/subscriptions","organizations_url":"https://api.github.com/users/BuoyantIO/orgs","repos_url":"https://api.github.com/users/BuoyantIO/repos","events_url":"https://api.github.com/users/BuoyantIO/events{/privacy}","received_events_url":"https://api.github.com/users/BuoyantIO/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BuoyantIO/linkerd","description":"A dynamic linker for microservices.","fork":false,"url":"https://api.github.com/repos/BuoyantIO/linkerd","forks_url":"https://api.github.com/repos/BuoyantIO/linkerd/forks","keys_url":"https://api.github.com/repos/BuoyantIO/linkerd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BuoyantIO/linkerd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BuoyantIO/linkerd/teams","hooks_url":"https://api.github.com/repos/BuoyantIO/linkerd/hooks","issue_events_url":"https://api.github.com/repos/BuoyantIO/linkerd/issues/events{/number}","events_url":"https://api.github.com/repos/BuoyantIO/linkerd/events","assignees_url":"https://api.github.com/repos/BuoyantIO/linkerd/assignees{/user}","branches_url":"https://api.github.com/repos/BuoyantIO/linkerd/branches{/branch}","tags_url":"https://api.github.com/repos/BuoyantIO/linkerd/tags","blobs_url":"https://api.github.com/repos/BuoyantIO/linkerd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BuoyantIO/linkerd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BuoyantIO/linkerd/git/refs{/sha}","trees_url":"https://api.github.com/repos/BuoyantIO/linkerd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BuoyantIO/linkerd/statuses/{sha}","languages_url":"https://api.github.com/repos/BuoyantIO/linkerd/languages","stargazers_url":"https://api.github.com/repos/BuoyantIO/linkerd/stargazers","contributors_url":"https://api.github.com/repos/BuoyantIO/linkerd/contributors","subscribers_url":"https://api.github.com/repos/BuoyantIO/linkerd/subscribers","subscription_url":"https://api.github.com/repos/BuoyantIO/linkerd/subscription","commits_url":"https://api.github.com/repos/BuoyantIO/linkerd/commits{/sha}","git_commits_url":"https://api.github.com/repos/BuoyantIO/linkerd/git/commits{/sha}","comments_url":"https://api.github.com/repos/BuoyantIO/linkerd/comments{/number}","issue_comment_url":"https://api.github.com/repos/BuoyantIO/linkerd/issues/comments{/number}","contents_url":"https://api.github.com/repos/BuoyantIO/linkerd/contents/{+path}","compare_url":"https://api.github.com/repos/BuoyantIO/linkerd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BuoyantIO/linkerd/merges","archive_url":"https://api.github.com/repos/BuoyantIO/linkerd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BuoyantIO/linkerd/downloads","issues_url":"https://api.github.com/repos/BuoyantIO/linkerd/issues{/number}","pulls_url":"https://api.github.com/repos/BuoyantIO/linkerd/pulls{/number}","milestones_url":"https://api.github.com/repos/BuoyantIO/linkerd/milestones{/number}","notifications_url":"https://api.github.com/repos/BuoyantIO/linkerd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BuoyantIO/linkerd/labels{/name}","releases_url":"https://api.github.com/repos/BuoyantIO/linkerd/releases{/id}","deployments_url":"https://api.github.com/repos/BuoyantIO/linkerd/deployments","created_at":"2016-01-13T22:14:52Z","updated_at":"2016-07-14T12:20:00Z","pushed_at":"2016-07-14T21:32:15Z","git_url":"git://github.com/BuoyantIO/linkerd.git","ssh_url":"git@github.com:BuoyantIO/linkerd.git","clone_url":"https://github.com/BuoyantIO/linkerd.git","svn_url":"https://github.com/BuoyantIO/linkerd","homepage":"https://linkerd.io","size":2148,"stargazers_count":859,"watchers_count":859,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"open_issues_count":69,"forks":58,"open_issues":69,"watchers":859,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/541"},"html":{"href":"https://github.com/BuoyantIO/linkerd/pull/541"},"issue":{"href":"https://api.github.com/repos/BuoyantIO/linkerd/issues/541"},"comments":{"href":"https://api.github.com/repos/BuoyantIO/linkerd/issues/541/comments"},"review_comments":{"href":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/541/comments"},"review_comment":{"href":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/541/commits"},"statuses":{"href":"https://api.github.com/repos/BuoyantIO/linkerd/statuses/d84f7ef75c7efc0efef89266d0738eeb3cfae172"}}}}
{"actor":{"display_login":"adleong"}}