{"action":"opened","number":8320,"pull_request":{"url":"https://api.github.com/repos/zurb/foundation-sites/pulls/8320","id":61435898,"html_url":"https://github.com/zurb/foundation-sites/pull/8320","diff_url":"https://github.com/zurb/foundation-sites/pull/8320.diff","patch_url":"https://github.com/zurb/foundation-sites/pull/8320.patch","issue_url":"https://api.github.com/repos/zurb/foundation-sites/issues/8320","number":8320,"state":"open","locked":false,"title":"Drilldown height calculation with long titles","user":{"login":"gakimball","id":1142001,"avatar_url":"https://avatars.githubusercontent.com/u/1142001?v=3","gravatar_id":"","url":"https://api.github.com/users/gakimball","html_url":"https://github.com/gakimball","followers_url":"https://api.github.com/users/gakimball/followers","following_url":"https://api.github.com/users/gakimball/following{/other_user}","gists_url":"https://api.github.com/users/gakimball/gists{/gist_id}","starred_url":"https://api.github.com/users/gakimball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gakimball/subscriptions","organizations_url":"https://api.github.com/users/gakimball/orgs","repos_url":"https://api.github.com/users/gakimball/repos","events_url":"https://api.github.com/users/gakimball/events{/privacy}","received_events_url":"https://api.github.com/users/gakimball/received_events","type":"User","site_admin":false},"body":"The Drilldown plugin reads the height of each menu inside of it, and sets the height of the whole menu to match the tallest one. However, the calculated height will be wrong if any menu items differ in height, as reported in #7070.\r\n\r\nThis is because the total menu height is calculated by taking the height of the *first* item in the list, and multiplying it by the number of items in the menu.\r\n\r\nThis change instead just calculates the height of the entire menu all at once, so it will be accurate.\r\n\r\nHowever, the call to `.getBoundingClientRect()` manages to be inaccurate. In the test case I put together, the height calculated is always off by 10 pixels, and I'm not sure why.\r\n\r\nTo finish this fix, we need the height calculated accurately.","created_at":"2016-03-02T17:26:58Z","updated_at":"2016-03-02T17:26:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f907e4527e07c1257826658c074dc8139a2a696","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zurb/foundation-sites/pulls/8320/commits","review_comments_url":"https://api.github.com/repos/zurb/foundation-sites/pulls/8320/comments","review_comment_url":"https://api.github.com/repos/zurb/foundation-sites/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zurb/foundation-sites/issues/8320/comments","statuses_url":"https://api.github.com/repos/zurb/foundation-sites/statuses/451c3a572c78d2367017e1d40137544900af0b07","head":{"label":"zurb:drilldown-long-title","ref":"drilldown-long-title","sha":"451c3a572c78d2367017e1d40137544900af0b07","user":{"login":"zurb","id":156122,"avatar_url":"https://avatars.githubusercontent.com/u/156122?v=3","gravatar_id":"","url":"https://api.github.com/users/zurb","html_url":"https://github.com/zurb","followers_url":"https://api.github.com/users/zurb/followers","following_url":"https://api.github.com/users/zurb/following{/other_user}","gists_url":"https://api.github.com/users/zurb/gists{/gist_id}","starred_url":"https://api.github.com/users/zurb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zurb/subscriptions","organizations_url":"https://api.github.com/users/zurb/orgs","repos_url":"https://api.github.com/users/zurb/repos","events_url":"https://api.github.com/users/zurb/events{/privacy}","received_events_url":"https://api.github.com/users/zurb/received_events","type":"Organization","site_admin":false},"repo":{"id":2573058,"name":"foundation-sites","full_name":"zurb/foundation-sites","owner":{"login":"zurb","id":156122,"avatar_url":"https://avatars.githubusercontent.com/u/156122?v=3","gravatar_id":"","url":"https://api.github.com/users/zurb","html_url":"https://github.com/zurb","followers_url":"https://api.github.com/users/zurb/followers","following_url":"https://api.github.com/users/zurb/following{/other_user}","gists_url":"https://api.github.com/users/zurb/gists{/gist_id}","starred_url":"https://api.github.com/users/zurb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zurb/subscriptions","organizations_url":"https://api.github.com/users/zurb/orgs","repos_url":"https://api.github.com/users/zurb/repos","events_url":"https://api.github.com/users/zurb/events{/privacy}","received_events_url":"https://api.github.com/users/zurb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zurb/foundation-sites","description":"The most advanced responsive front-end framework in the world. Quickly create prototypes and production code for sites that work on any kind of device.","fork":false,"url":"https://api.github.com/repos/zurb/foundation-sites","forks_url":"https://api.github.com/repos/zurb/foundation-sites/forks","keys_url":"https://api.github.com/repos/zurb/foundation-sites/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zurb/foundation-sites/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zurb/foundation-sites/teams","hooks_url":"https://api.github.com/repos/zurb/foundation-sites/hooks","issue_events_url":"https://api.github.com/repos/zurb/foundation-sites/issues/events{/number}","events_url":"https://api.github.com/repos/zurb/foundation-sites/events","assignees_url":"https://api.github.com/repos/zurb/foundation-sites/assignees{/user}","branches_url":"https://api.github.com/repos/zurb/foundation-sites/branches{/branch}","tags_url":"https://api.github.com/repos/zurb/foundation-sites/tags","blobs_url":"https://api.github.com/repos/zurb/foundation-sites/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zurb/foundation-sites/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zurb/foundation-sites/git/refs{/sha}","trees_url":"https://api.github.com/repos/zurb/foundation-sites/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zurb/foundation-sites/statuses/{sha}","languages_url":"https://api.github.com/repos/zurb/foundation-sites/languages","stargazers_url":"https://api.github.com/repos/zurb/foundation-sites/stargazers","contributors_url":"https://api.github.com/repos/zurb/foundation-sites/contributors","subscribers_url":"https://api.github.com/repos/zurb/foundation-sites/subscribers","subscription_url":"https://api.github.com/repos/zurb/foundation-sites/subscription","commits_url":"https://api.github.com/repos/zurb/foundation-sites/commits{/sha}","git_commits_url":"https://api.github.com/repos/zurb/foundation-sites/git/commits{/sha}","comments_url":"https://api.github.com/repos/zurb/foundation-sites/comments{/number}","issue_comment_url":"https://api.github.com/repos/zurb/foundation-sites/issues/comments{/number}","contents_url":"https://api.github.com/repos/zurb/foundation-sites/contents/{+path}","compare_url":"https://api.github.com/repos/zurb/foundation-sites/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zurb/foundation-sites/merges","archive_url":"https://api.github.com/repos/zurb/foundation-sites/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zurb/foundation-sites/downloads","issues_url":"https://api.github.com/repos/zurb/foundation-sites/issues{/number}","pulls_url":"https://api.github.com/repos/zurb/foundation-sites/pulls{/number}","milestones_url":"https://api.github.com/repos/zurb/foundation-sites/milestones{/number}","notifications_url":"https://api.github.com/repos/zurb/foundation-sites/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zurb/foundation-sites/labels{/name}","releases_url":"https://api.github.com/repos/zurb/foundation-sites/releases{/id}","deployments_url":"https://api.github.com/repos/zurb/foundation-sites/deployments","created_at":"2011-10-13T23:05:42Z","updated_at":"2016-03-02T14:40:04Z","pushed_at":"2016-03-02T17:26:59Z","git_url":"git://github.com/zurb/foundation-sites.git","ssh_url":"git@github.com:zurb/foundation-sites.git","clone_url":"https://github.com/zurb/foundation-sites.git","svn_url":"https://github.com/zurb/foundation-sites","homepage":"http://foundation.zurb.com","size":134954,"stargazers_count":22736,"watchers_count":22736,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4892,"mirror_url":null,"open_issues_count":239,"forks":4892,"open_issues":239,"watchers":22736,"default_branch":"develop"}},"base":{"label":"zurb:develop","ref":"develop","sha":"e5746c7567118238ab00d3fb4183552d366562a0","user":{"login":"zurb","id":156122,"avatar_url":"https://avatars.githubusercontent.com/u/156122?v=3","gravatar_id":"","url":"https://api.github.com/users/zurb","html_url":"https://github.com/zurb","followers_url":"https://api.github.com/users/zurb/followers","following_url":"https://api.github.com/users/zurb/following{/other_user}","gists_url":"https://api.github.com/users/zurb/gists{/gist_id}","starred_url":"https://api.github.com/users/zurb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zurb/subscriptions","organizations_url":"https://api.github.com/users/zurb/orgs","repos_url":"https://api.github.com/users/zurb/repos","events_url":"https://api.github.com/users/zurb/events{/privacy}","received_events_url":"https://api.github.com/users/zurb/received_events","type":"Organization","site_admin":false},"repo":{"id":2573058,"name":"foundation-sites","full_name":"zurb/foundation-sites","owner":{"login":"zurb","id":156122,"avatar_url":"https://avatars.githubusercontent.com/u/156122?v=3","gravatar_id":"","url":"https://api.github.com/users/zurb","html_url":"https://github.com/zurb","followers_url":"https://api.github.com/users/zurb/followers","following_url":"https://api.github.com/users/zurb/following{/other_user}","gists_url":"https://api.github.com/users/zurb/gists{/gist_id}","starred_url":"https://api.github.com/users/zurb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zurb/subscriptions","organizations_url":"https://api.github.com/users/zurb/orgs","repos_url":"https://api.github.com/users/zurb/repos","events_url":"https://api.github.com/users/zurb/events{/privacy}","received_events_url":"https://api.github.com/users/zurb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zurb/foundation-sites","description":"The most advanced responsive front-end framework in the world. Quickly create prototypes and production code for sites that work on any kind of device.","fork":false,"url":"https://api.github.com/repos/zurb/foundation-sites","forks_url":"https://api.github.com/repos/zurb/foundation-sites/forks","keys_url":"https://api.github.com/repos/zurb/foundation-sites/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zurb/foundation-sites/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zurb/foundation-sites/teams","hooks_url":"https://api.github.com/repos/zurb/foundation-sites/hooks","issue_events_url":"https://api.github.com/repos/zurb/foundation-sites/issues/events{/number}","events_url":"https://api.github.com/repos/zurb/foundation-sites/events","assignees_url":"https://api.github.com/repos/zurb/foundation-sites/assignees{/user}","branches_url":"https://api.github.com/repos/zurb/foundation-sites/branches{/branch}","tags_url":"https://api.github.com/repos/zurb/foundation-sites/tags","blobs_url":"https://api.github.com/repos/zurb/foundation-sites/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zurb/foundation-sites/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zurb/foundation-sites/git/refs{/sha}","trees_url":"https://api.github.com/repos/zurb/foundation-sites/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zurb/foundation-sites/statuses/{sha}","languages_url":"https://api.github.com/repos/zurb/foundation-sites/languages","stargazers_url":"https://api.github.com/repos/zurb/foundation-sites/stargazers","contributors_url":"https://api.github.com/repos/zurb/foundation-sites/contributors","subscribers_url":"https://api.github.com/repos/zurb/foundation-sites/subscribers","subscription_url":"https://api.github.com/repos/zurb/foundation-sites/subscription","commits_url":"https://api.github.com/repos/zurb/foundation-sites/commits{/sha}","git_commits_url":"https://api.github.com/repos/zurb/foundation-sites/git/commits{/sha}","comments_url":"https://api.github.com/repos/zurb/foundation-sites/comments{/number}","issue_comment_url":"https://api.github.com/repos/zurb/foundation-sites/issues/comments{/number}","contents_url":"https://api.github.com/repos/zurb/foundation-sites/contents/{+path}","compare_url":"https://api.github.com/repos/zurb/foundation-sites/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zurb/foundation-sites/merges","archive_url":"https://api.github.com/repos/zurb/foundation-sites/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zurb/foundation-sites/downloads","issues_url":"https://api.github.com/repos/zurb/foundation-sites/issues{/number}","pulls_url":"https://api.github.com/repos/zurb/foundation-sites/pulls{/number}","milestones_url":"https://api.github.com/repos/zurb/foundation-sites/milestones{/number}","notifications_url":"https://api.github.com/repos/zurb/foundation-sites/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zurb/foundation-sites/labels{/name}","releases_url":"https://api.github.com/repos/zurb/foundation-sites/releases{/id}","deployments_url":"https://api.github.com/repos/zurb/foundation-sites/deployments","created_at":"2011-10-13T23:05:42Z","updated_at":"2016-03-02T14:40:04Z","pushed_at":"2016-03-02T17:26:59Z","git_url":"git://github.com/zurb/foundation-sites.git","ssh_url":"git@github.com:zurb/foundation-sites.git","clone_url":"https://github.com/zurb/foundation-sites.git","svn_url":"https://github.com/zurb/foundation-sites","homepage":"http://foundation.zurb.com","size":134954,"stargazers_count":22736,"watchers_count":22736,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4892,"mirror_url":null,"open_issues_count":239,"forks":4892,"open_issues":239,"watchers":22736,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/zurb/foundation-sites/pulls/8320"},"html":{"href":"https://github.com/zurb/foundation-sites/pull/8320"},"issue":{"href":"https://api.github.com/repos/zurb/foundation-sites/issues/8320"},"comments":{"href":"https://api.github.com/repos/zurb/foundation-sites/issues/8320/comments"},"review_comments":{"href":"https://api.github.com/repos/zurb/foundation-sites/pulls/8320/comments"},"review_comment":{"href":"https://api.github.com/repos/zurb/foundation-sites/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zurb/foundation-sites/pulls/8320/commits"},"statuses":{"href":"https://api.github.com/repos/zurb/foundation-sites/statuses/451c3a572c78d2367017e1d40137544900af0b07"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":81,"deletions":56,"changed_files":4}}