{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/gridicons/issues/176","repository_url":"https://api.github.com/repos/Automattic/gridicons","labels_url":"https://api.github.com/repos/Automattic/gridicons/issues/176/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/gridicons/issues/176/comments","events_url":"https://api.github.com/repos/Automattic/gridicons/issues/176/events","html_url":"https://github.com/Automattic/gridicons/issues/176","id":159301859,"number":176,"title":"Bug: \"react-pure-render/mixin\" required without being in package.json","user":{"login":"coderkevin","id":945228,"avatar_url":"https://avatars.githubusercontent.com/u/945228?v=3","gravatar_id":"","url":"https://api.github.com/users/coderkevin","html_url":"https://github.com/coderkevin","followers_url":"https://api.github.com/users/coderkevin/followers","following_url":"https://api.github.com/users/coderkevin/following{/other_user}","gists_url":"https://api.github.com/users/coderkevin/gists{/gist_id}","starred_url":"https://api.github.com/users/coderkevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coderkevin/subscriptions","organizations_url":"https://api.github.com/users/coderkevin/orgs","repos_url":"https://api.github.com/users/coderkevin/repos","events_url":"https://api.github.com/users/coderkevin/events{/privacy}","received_events_url":"https://api.github.com/users/coderkevin/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Automattic/gridicons/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-06-08T23:51:24Z","updated_at":"2016-06-14T13:06:14Z","closed_at":null,"body":"'react-pure-render' is being required [here](https://github.com/Automattic/gridicons/blob/master/react/gridicon/index.jsx#L14) and [here](https://github.com/Automattic/gridicons/blob/master/react/gridicon/inc/index-header.jsx#L14).\r\n\r\nHowever, package.json does not include this dependency.\r\n\r\n<!-- Thanks for contributing to Gridicons! Pick a clear title (\"New icon: add image\") and proceed.\r\n\r\nPLEASE NOTE\r\n- These comments won't show up when you submit the issue.\r\n- Try to add as many details as possible.\r\n- If requesting a new icon, explain why you'd like to see it added.\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/Automattic/gridicons/issues/comments/225874818","html_url":"https://github.com/Automattic/gridicons/issues/176#issuecomment-225874818","issue_url":"https://api.github.com/repos/Automattic/gridicons/issues/176","id":225874818,"user":{"login":"folletto","id":4389,"avatar_url":"https://avatars.githubusercontent.com/u/4389?v=3","gravatar_id":"","url":"https://api.github.com/users/folletto","html_url":"https://github.com/folletto","followers_url":"https://api.github.com/users/folletto/followers","following_url":"https://api.github.com/users/folletto/following{/other_user}","gists_url":"https://api.github.com/users/folletto/gists{/gist_id}","starred_url":"https://api.github.com/users/folletto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/folletto/subscriptions","organizations_url":"https://api.github.com/users/folletto/orgs","repos_url":"https://api.github.com/users/folletto/repos","events_url":"https://api.github.com/users/folletto/events{/privacy}","received_events_url":"https://api.github.com/users/folletto/received_events","type":"User","site_admin":false},"created_at":"2016-06-14T13:06:14Z","updated_at":"2016-06-14T13:06:14Z","body":"In my view this is very different. The Gridicons repository is primarily a builder (all the scripts are building scripts to create the assets), and among the things it builds, it builds a react component. \r\n\r\nInstead, `i18n-calypso` is only the component, which gets published on NPM directly.\r\n\r\nSo, we'd be comparing apple to oranges here.\r\n\r\nWe could probably generate the `/react/gridicon` folder to be a full fledged NPM component, so it could be then more easily ported and even published (does the NPM registry allow publishing from a subfolder instead of the root of the GitHub project?)."}}
{"actor":{"display_login":"folletto"}}