{"action":"created","comment":{"url":"https://api.github.com/repos/mdaus/coda-oss/pulls/comments/60790980","id":60790980,"diff_hunk":"@@ -116,10 +117,24 @@ class VectorOfPointers\n     iterator end() { return mValues.end(); }\n     const_iterator end() const { return mValues.end(); }\n \n+    iterator erase(const iterator &pos)\n+    {\n+        delete *pos;\n+        return mValues.erase(pos);\n+    }\n+\n+    iterator erase(const iterator &first, const iterator &last)\n+    {\n+        std::for_each(first, last, Deleter());","path":"modules/c++/mem/include/mem/VectorOfPointers.h","position":20,"original_position":20,"commit_id":"1b51ed77ef6b277630d71cea373ac0ce5cca9e67","original_commit_id":"1b51ed77ef6b277630d71cea373ac0ce5cca9e67","user":{"login":"asylvest","id":11707082,"avatar_url":"https://avatars.githubusercontent.com/u/11707082?v=3","gravatar_id":"","url":"https://api.github.com/users/asylvest","html_url":"https://github.com/asylvest","followers_url":"https://api.github.com/users/asylvest/followers","following_url":"https://api.github.com/users/asylvest/following{/other_user}","gists_url":"https://api.github.com/users/asylvest/gists{/gist_id}","starred_url":"https://api.github.com/users/asylvest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asylvest/subscriptions","organizations_url":"https://api.github.com/users/asylvest/orgs","repos_url":"https://api.github.com/users/asylvest/repos","events_url":"https://api.github.com/users/asylvest/events{/privacy}","received_events_url":"https://api.github.com/users/asylvest/received_events","type":"User","site_admin":false},"body":"So this is a style/opinion thing... If you could use a lambda here it would save you a few lines and `for_each()` would buy you something.  With something this simple, granted the name `Deleter` is obvious, but I have to go look at the struct to make sure and I think it's simpler code to skim over by just using a for loop.  Style-wise, we'll want curly braces even for one liner for loops FYI.","created_at":"2016-04-22T19:26:38Z","updated_at":"2016-04-22T19:26:38Z","html_url":"https://github.com/mdaus/coda-oss/pull/110#discussion_r60790980","pull_request_url":"https://api.github.com/repos/mdaus/coda-oss/pulls/110","_links":{"self":{"href":"https://api.github.com/repos/mdaus/coda-oss/pulls/comments/60790980"},"html":{"href":"https://github.com/mdaus/coda-oss/pull/110#discussion_r60790980"},"pull_request":{"href":"https://api.github.com/repos/mdaus/coda-oss/pulls/110"}}},"pull_request":{"url":"https://api.github.com/repos/mdaus/coda-oss/pulls/110","id":67546763,"html_url":"https://github.com/mdaus/coda-oss/pull/110","diff_url":"https://github.com/mdaus/coda-oss/pull/110.diff","patch_url":"https://github.com/mdaus/coda-oss/pull/110.patch","issue_url":"https://api.github.com/repos/mdaus/coda-oss/issues/110","number":110,"state":"open","locked":false,"title":"mem::VectorOfPointers<>::erase","user":{"login":"jbruce2112","id":1429561,"avatar_url":"https://avatars.githubusercontent.com/u/1429561?v=3","gravatar_id":"","url":"https://api.github.com/users/jbruce2112","html_url":"https://github.com/jbruce2112","followers_url":"https://api.github.com/users/jbruce2112/followers","following_url":"https://api.github.com/users/jbruce2112/following{/other_user}","gists_url":"https://api.github.com/users/jbruce2112/gists{/gist_id}","starred_url":"https://api.github.com/users/jbruce2112/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbruce2112/subscriptions","organizations_url":"https://api.github.com/users/jbruce2112/orgs","repos_url":"https://api.github.com/users/jbruce2112/repos","events_url":"https://api.github.com/users/jbruce2112/events{/privacy}","received_events_url":"https://api.github.com/users/jbruce2112/received_events","type":"User","site_admin":false},"body":"As I'm going through some SDS code, I found a similar class in that codebase to our `mem::VectorOfPointers`, so I removed it and added the `erase()` function to CODA's so we can instead use the CODA version.","created_at":"2016-04-22T17:36:25Z","updated_at":"2016-04-22T19:26:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"739ee5da8a5e2d181744eafd106ec73320adfd13","assignee":{"login":"asylvest","id":11707082,"avatar_url":"https://avatars.githubusercontent.com/u/11707082?v=3","gravatar_id":"","url":"https://api.github.com/users/asylvest","html_url":"https://github.com/asylvest","followers_url":"https://api.github.com/users/asylvest/followers","following_url":"https://api.github.com/users/asylvest/following{/other_user}","gists_url":"https://api.github.com/users/asylvest/gists{/gist_id}","starred_url":"https://api.github.com/users/asylvest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asylvest/subscriptions","organizations_url":"https://api.github.com/users/asylvest/orgs","repos_url":"https://api.github.com/users/asylvest/repos","events_url":"https://api.github.com/users/asylvest/events{/privacy}","received_events_url":"https://api.github.com/users/asylvest/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/mdaus/coda-oss/milestones/1","html_url":"https://github.com/mdaus/coda-oss/milestones/CODA%2016.07","labels_url":"https://api.github.com/repos/mdaus/coda-oss/milestones/1/labels","id":1702272,"number":1,"title":"CODA 16.07","description":null,"creator":{"login":"JonathanMeans","id":5521504,"avatar_url":"https://avatars.githubusercontent.com/u/5521504?v=3","gravatar_id":"","url":"https://api.github.com/users/JonathanMeans","html_url":"https://github.com/JonathanMeans","followers_url":"https://api.github.com/users/JonathanMeans/followers","following_url":"https://api.github.com/users/JonathanMeans/following{/other_user}","gists_url":"https://api.github.com/users/JonathanMeans/gists{/gist_id}","starred_url":"https://api.github.com/users/JonathanMeans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonathanMeans/subscriptions","organizations_url":"https://api.github.com/users/JonathanMeans/orgs","repos_url":"https://api.github.com/users/JonathanMeans/repos","events_url":"https://api.github.com/users/JonathanMeans/events{/privacy}","received_events_url":"https://api.github.com/users/JonathanMeans/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":9,"state":"open","created_at":"2016-04-12T19:46:07Z","updated_at":"2016-04-22T19:20:09Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/mdaus/coda-oss/pulls/110/commits","review_comments_url":"https://api.github.com/repos/mdaus/coda-oss/pulls/110/comments","review_comment_url":"https://api.github.com/repos/mdaus/coda-oss/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mdaus/coda-oss/issues/110/comments","statuses_url":"https://api.github.com/repos/mdaus/coda-oss/statuses/1b51ed77ef6b277630d71cea373ac0ce5cca9e67","head":{"label":"mdaus:vecOfPointersErase","ref":"vecOfPointersErase","sha":"1b51ed77ef6b277630d71cea373ac0ce5cca9e67","user":{"login":"mdaus","id":11707119,"avatar_url":"https://avatars.githubusercontent.com/u/11707119?v=3","gravatar_id":"","url":"https://api.github.com/users/mdaus","html_url":"https://github.com/mdaus","followers_url":"https://api.github.com/users/mdaus/followers","following_url":"https://api.github.com/users/mdaus/following{/other_user}","gists_url":"https://api.github.com/users/mdaus/gists{/gist_id}","starred_url":"https://api.github.com/users/mdaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdaus/subscriptions","organizations_url":"https://api.github.com/users/mdaus/orgs","repos_url":"https://api.github.com/users/mdaus/repos","events_url":"https://api.github.com/users/mdaus/events{/privacy}","received_events_url":"https://api.github.com/users/mdaus/received_events","type":"Organization","site_admin":false},"repo":{"id":33076757,"name":"coda-oss","full_name":"mdaus/coda-oss","owner":{"login":"mdaus","id":11707119,"avatar_url":"https://avatars.githubusercontent.com/u/11707119?v=3","gravatar_id":"","url":"https://api.github.com/users/mdaus","html_url":"https://github.com/mdaus","followers_url":"https://api.github.com/users/mdaus/followers","following_url":"https://api.github.com/users/mdaus/following{/other_user}","gists_url":"https://api.github.com/users/mdaus/gists{/gist_id}","starred_url":"https://api.github.com/users/mdaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdaus/subscriptions","organizations_url":"https://api.github.com/users/mdaus/orgs","repos_url":"https://api.github.com/users/mdaus/repos","events_url":"https://api.github.com/users/mdaus/events{/privacy}","received_events_url":"https://api.github.com/users/mdaus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mdaus/coda-oss","description":"The Common Open Development Archive (CODA-OSS) is a set of open source, modular components developed by MDA Information Systems LLC, primarily as a portable runtime for C++ processing.","fork":false,"url":"https://api.github.com/repos/mdaus/coda-oss","forks_url":"https://api.github.com/repos/mdaus/coda-oss/forks","keys_url":"https://api.github.com/repos/mdaus/coda-oss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mdaus/coda-oss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mdaus/coda-oss/teams","hooks_url":"https://api.github.com/repos/mdaus/coda-oss/hooks","issue_events_url":"https://api.github.com/repos/mdaus/coda-oss/issues/events{/number}","events_url":"https://api.github.com/repos/mdaus/coda-oss/events","assignees_url":"https://api.github.com/repos/mdaus/coda-oss/assignees{/user}","branches_url":"https://api.github.com/repos/mdaus/coda-oss/branches{/branch}","tags_url":"https://api.github.com/repos/mdaus/coda-oss/tags","blobs_url":"https://api.github.com/repos/mdaus/coda-oss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mdaus/coda-oss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mdaus/coda-oss/git/refs{/sha}","trees_url":"https://api.github.com/repos/mdaus/coda-oss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mdaus/coda-oss/statuses/{sha}","languages_url":"https://api.github.com/repos/mdaus/coda-oss/languages","stargazers_url":"https://api.github.com/repos/mdaus/coda-oss/stargazers","contributors_url":"https://api.github.com/repos/mdaus/coda-oss/contributors","subscribers_url":"https://api.github.com/repos/mdaus/coda-oss/subscribers","subscription_url":"https://api.github.com/repos/mdaus/coda-oss/subscription","commits_url":"https://api.github.com/repos/mdaus/coda-oss/commits{/sha}","git_commits_url":"https://api.github.com/repos/mdaus/coda-oss/git/commits{/sha}","comments_url":"https://api.github.com/repos/mdaus/coda-oss/comments{/number}","issue_comment_url":"https://api.github.com/repos/mdaus/coda-oss/issues/comments{/number}","contents_url":"https://api.github.com/repos/mdaus/coda-oss/contents/{+path}","compare_url":"https://api.github.com/repos/mdaus/coda-oss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mdaus/coda-oss/merges","archive_url":"https://api.github.com/repos/mdaus/coda-oss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mdaus/coda-oss/downloads","issues_url":"https://api.github.com/repos/mdaus/coda-oss/issues{/number}","pulls_url":"https://api.github.com/repos/mdaus/coda-oss/pulls{/number}","milestones_url":"https://api.github.com/repos/mdaus/coda-oss/milestones{/number}","notifications_url":"https://api.github.com/repos/mdaus/coda-oss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mdaus/coda-oss/labels{/name}","releases_url":"https://api.github.com/repos/mdaus/coda-oss/releases{/id}","deployments_url":"https://api.github.com/repos/mdaus/coda-oss/deployments","created_at":"2015-03-29T14:48:12Z","updated_at":"2016-01-26T13:50:06Z","pushed_at":"2016-04-22T19:18:55Z","git_url":"git://github.com/mdaus/coda-oss.git","ssh_url":"git@github.com:mdaus/coda-oss.git","clone_url":"https://github.com/mdaus/coda-oss.git","svn_url":"https://github.com/mdaus/coda-oss","homepage":null,"size":123246,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":12,"forks":3,"open_issues":12,"watchers":4,"default_branch":"master"}},"base":{"label":"mdaus:master","ref":"master","sha":"0f8115c3b6176c297cd4d6e054f591c7817115cc","user":{"login":"mdaus","id":11707119,"avatar_url":"https://avatars.githubusercontent.com/u/11707119?v=3","gravatar_id":"","url":"https://api.github.com/users/mdaus","html_url":"https://github.com/mdaus","followers_url":"https://api.github.com/users/mdaus/followers","following_url":"https://api.github.com/users/mdaus/following{/other_user}","gists_url":"https://api.github.com/users/mdaus/gists{/gist_id}","starred_url":"https://api.github.com/users/mdaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdaus/subscriptions","organizations_url":"https://api.github.com/users/mdaus/orgs","repos_url":"https://api.github.com/users/mdaus/repos","events_url":"https://api.github.com/users/mdaus/events{/privacy}","received_events_url":"https://api.github.com/users/mdaus/received_events","type":"Organization","site_admin":false},"repo":{"id":33076757,"name":"coda-oss","full_name":"mdaus/coda-oss","owner":{"login":"mdaus","id":11707119,"avatar_url":"https://avatars.githubusercontent.com/u/11707119?v=3","gravatar_id":"","url":"https://api.github.com/users/mdaus","html_url":"https://github.com/mdaus","followers_url":"https://api.github.com/users/mdaus/followers","following_url":"https://api.github.com/users/mdaus/following{/other_user}","gists_url":"https://api.github.com/users/mdaus/gists{/gist_id}","starred_url":"https://api.github.com/users/mdaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdaus/subscriptions","organizations_url":"https://api.github.com/users/mdaus/orgs","repos_url":"https://api.github.com/users/mdaus/repos","events_url":"https://api.github.com/users/mdaus/events{/privacy}","received_events_url":"https://api.github.com/users/mdaus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mdaus/coda-oss","description":"The Common Open Development Archive (CODA-OSS) is a set of open source, modular components developed by MDA Information Systems LLC, primarily as a portable runtime for C++ processing.","fork":false,"url":"https://api.github.com/repos/mdaus/coda-oss","forks_url":"https://api.github.com/repos/mdaus/coda-oss/forks","keys_url":"https://api.github.com/repos/mdaus/coda-oss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mdaus/coda-oss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mdaus/coda-oss/teams","hooks_url":"https://api.github.com/repos/mdaus/coda-oss/hooks","issue_events_url":"https://api.github.com/repos/mdaus/coda-oss/issues/events{/number}","events_url":"https://api.github.com/repos/mdaus/coda-oss/events","assignees_url":"https://api.github.com/repos/mdaus/coda-oss/assignees{/user}","branches_url":"https://api.github.com/repos/mdaus/coda-oss/branches{/branch}","tags_url":"https://api.github.com/repos/mdaus/coda-oss/tags","blobs_url":"https://api.github.com/repos/mdaus/coda-oss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mdaus/coda-oss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mdaus/coda-oss/git/refs{/sha}","trees_url":"https://api.github.com/repos/mdaus/coda-oss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mdaus/coda-oss/statuses/{sha}","languages_url":"https://api.github.com/repos/mdaus/coda-oss/languages","stargazers_url":"https://api.github.com/repos/mdaus/coda-oss/stargazers","contributors_url":"https://api.github.com/repos/mdaus/coda-oss/contributors","subscribers_url":"https://api.github.com/repos/mdaus/coda-oss/subscribers","subscription_url":"https://api.github.com/repos/mdaus/coda-oss/subscription","commits_url":"https://api.github.com/repos/mdaus/coda-oss/commits{/sha}","git_commits_url":"https://api.github.com/repos/mdaus/coda-oss/git/commits{/sha}","comments_url":"https://api.github.com/repos/mdaus/coda-oss/comments{/number}","issue_comment_url":"https://api.github.com/repos/mdaus/coda-oss/issues/comments{/number}","contents_url":"https://api.github.com/repos/mdaus/coda-oss/contents/{+path}","compare_url":"https://api.github.com/repos/mdaus/coda-oss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mdaus/coda-oss/merges","archive_url":"https://api.github.com/repos/mdaus/coda-oss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mdaus/coda-oss/downloads","issues_url":"https://api.github.com/repos/mdaus/coda-oss/issues{/number}","pulls_url":"https://api.github.com/repos/mdaus/coda-oss/pulls{/number}","milestones_url":"https://api.github.com/repos/mdaus/coda-oss/milestones{/number}","notifications_url":"https://api.github.com/repos/mdaus/coda-oss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mdaus/coda-oss/labels{/name}","releases_url":"https://api.github.com/repos/mdaus/coda-oss/releases{/id}","deployments_url":"https://api.github.com/repos/mdaus/coda-oss/deployments","created_at":"2015-03-29T14:48:12Z","updated_at":"2016-01-26T13:50:06Z","pushed_at":"2016-04-22T19:18:55Z","git_url":"git://github.com/mdaus/coda-oss.git","ssh_url":"git@github.com:mdaus/coda-oss.git","clone_url":"https://github.com/mdaus/coda-oss.git","svn_url":"https://github.com/mdaus/coda-oss","homepage":null,"size":123246,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":12,"forks":3,"open_issues":12,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mdaus/coda-oss/pulls/110"},"html":{"href":"https://github.com/mdaus/coda-oss/pull/110"},"issue":{"href":"https://api.github.com/repos/mdaus/coda-oss/issues/110"},"comments":{"href":"https://api.github.com/repos/mdaus/coda-oss/issues/110/comments"},"review_comments":{"href":"https://api.github.com/repos/mdaus/coda-oss/pulls/110/comments"},"review_comment":{"href":"https://api.github.com/repos/mdaus/coda-oss/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mdaus/coda-oss/pulls/110/commits"},"statuses":{"href":"https://api.github.com/repos/mdaus/coda-oss/statuses/1b51ed77ef6b277630d71cea373ac0ce5cca9e67"}}}}