{"action":"created","comment":{"url":"https://api.github.com/repos/control-center/serviced/pulls/comments/80699116","pull_request_review_id":1736666,"id":80699116,"diff_hunk":"@@ -131,10 +131,17 @@ func (s *DeviceMapperSuite) TestDeviceMapperExcludeDirs(c *C) {\n \n \tbasesize1, err := units.RAMInBytes(\"10M\")\n \n-\texportdrv, err := Init(c.MkDir(), []string{fmt.Sprintf(\"dm.basesize=%d\", basesize1)})\n+\t// seed rand for c.MkDir\n+\trand.Seed(time.Now().UnixNano())","path":"volume/devicemapper/devicemapper_test.go","position":6,"original_position":6,"commit_id":"313de1d560fece6c8043254a57c21d2d30de05d4","original_commit_id":"313de1d560fece6c8043254a57c21d2d30de05d4","user":{"login":"smousa","id":3171936,"avatar_url":"https://avatars.githubusercontent.com/u/3171936?v=3","gravatar_id":"","url":"https://api.github.com/users/smousa","html_url":"https://github.com/smousa","followers_url":"https://api.github.com/users/smousa/followers","following_url":"https://api.github.com/users/smousa/following{/other_user}","gists_url":"https://api.github.com/users/smousa/gists{/gist_id}","starred_url":"https://api.github.com/users/smousa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smousa/subscriptions","organizations_url":"https://api.github.com/users/smousa/orgs","repos_url":"https://api.github.com/users/smousa/repos","events_url":"https://api.github.com/users/smousa/events{/privacy}","received_events_url":"https://api.github.com/users/smousa/received_events","type":"User","site_admin":false},"body":"this should be in setupsuite","created_at":"2016-09-27T14:01:50Z","updated_at":"2016-09-27T14:01:50Z","html_url":"https://github.com/control-center/serviced/pull/3014#discussion_r80699116","pull_request_url":"https://api.github.com/repos/control-center/serviced/pulls/3014","_links":{"self":{"href":"https://api.github.com/repos/control-center/serviced/pulls/comments/80699116"},"html":{"href":"https://github.com/control-center/serviced/pull/3014#discussion_r80699116"},"pull_request":{"href":"https://api.github.com/repos/control-center/serviced/pulls/3014"}}},"pull_request":{"url":"https://api.github.com/repos/control-center/serviced/pulls/3014","id":86803778,"html_url":"https://github.com/control-center/serviced/pull/3014","diff_url":"https://github.com/control-center/serviced/pull/3014.diff","patch_url":"https://github.com/control-center/serviced/pull/3014.patch","issue_url":"https://api.github.com/repos/control-center/serviced/issues/3014","number":3014,"state":"open","locked":false,"title":"Clean up tmpDir to avoid panic in unit tests","user":{"login":"rphillipsz","id":15878956,"avatar_url":"https://avatars.githubusercontent.com/u/15878956?v=3","gravatar_id":"","url":"https://api.github.com/users/rphillipsz","html_url":"https://github.com/rphillipsz","followers_url":"https://api.github.com/users/rphillipsz/followers","following_url":"https://api.github.com/users/rphillipsz/following{/other_user}","gists_url":"https://api.github.com/users/rphillipsz/gists{/gist_id}","starred_url":"https://api.github.com/users/rphillipsz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rphillipsz/subscriptions","organizations_url":"https://api.github.com/users/rphillipsz/orgs","repos_url":"https://api.github.com/users/rphillipsz/repos","events_url":"https://api.github.com/users/rphillipsz/events{/privacy}","received_events_url":"https://api.github.com/users/rphillipsz/received_events","type":"User","site_admin":false},"body":"Failing unit tests.  It looks like the tmpDir from c.MkDir() is the same, but not cleaned up between calls.\r\n\r\nSee: http://jenkins.zendev.org/job/ControlCenter/job/develop/job/serviced-develop-pullrequests-unit/1853/console\r\n \r\nPanic: Couldn't create temporary directory: mkdir /tmp/check-3784560248718450071: file exists","created_at":"2016-09-26T19:29:15Z","updated_at":"2016-09-27T14:02:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"299a9a23daffeb60587747be27daf37416023243","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/control-center/serviced/pulls/3014/commits","review_comments_url":"https://api.github.com/repos/control-center/serviced/pulls/3014/comments","review_comment_url":"https://api.github.com/repos/control-center/serviced/pulls/comments{/number}","comments_url":"https://api.github.com/repos/control-center/serviced/issues/3014/comments","statuses_url":"https://api.github.com/repos/control-center/serviced/statuses/313de1d560fece6c8043254a57c21d2d30de05d4","head":{"label":"control-center:feature/authUnitTestFix","ref":"feature/authUnitTestFix","sha":"313de1d560fece6c8043254a57c21d2d30de05d4","user":{"login":"control-center","id":8160673,"avatar_url":"https://avatars.githubusercontent.com/u/8160673?v=3","gravatar_id":"","url":"https://api.github.com/users/control-center","html_url":"https://github.com/control-center","followers_url":"https://api.github.com/users/control-center/followers","following_url":"https://api.github.com/users/control-center/following{/other_user}","gists_url":"https://api.github.com/users/control-center/gists{/gist_id}","starred_url":"https://api.github.com/users/control-center/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/control-center/subscriptions","organizations_url":"https://api.github.com/users/control-center/orgs","repos_url":"https://api.github.com/users/control-center/repos","events_url":"https://api.github.com/users/control-center/events{/privacy}","received_events_url":"https://api.github.com/users/control-center/received_events","type":"Organization","site_admin":false},"repo":{"id":11929217,"name":"serviced","full_name":"control-center/serviced","owner":{"login":"control-center","id":8160673,"avatar_url":"https://avatars.githubusercontent.com/u/8160673?v=3","gravatar_id":"","url":"https://api.github.com/users/control-center","html_url":"https://github.com/control-center","followers_url":"https://api.github.com/users/control-center/followers","following_url":"https://api.github.com/users/control-center/following{/other_user}","gists_url":"https://api.github.com/users/control-center/gists{/gist_id}","starred_url":"https://api.github.com/users/control-center/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/control-center/subscriptions","organizations_url":"https://api.github.com/users/control-center/orgs","repos_url":"https://api.github.com/users/control-center/repos","events_url":"https://api.github.com/users/control-center/events{/privacy}","received_events_url":"https://api.github.com/users/control-center/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/control-center/serviced","description":"Serviced is a PaaS runtime. It allows users to create, manage and scale services in a uniform way.","fork":false,"url":"https://api.github.com/repos/control-center/serviced","forks_url":"https://api.github.com/repos/control-center/serviced/forks","keys_url":"https://api.github.com/repos/control-center/serviced/keys{/key_id}","collaborators_url":"https://api.github.com/repos/control-center/serviced/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/control-center/serviced/teams","hooks_url":"https://api.github.com/repos/control-center/serviced/hooks","issue_events_url":"https://api.github.com/repos/control-center/serviced/issues/events{/number}","events_url":"https://api.github.com/repos/control-center/serviced/events","assignees_url":"https://api.github.com/repos/control-center/serviced/assignees{/user}","branches_url":"https://api.github.com/repos/control-center/serviced/branches{/branch}","tags_url":"https://api.github.com/repos/control-center/serviced/tags","blobs_url":"https://api.github.com/repos/control-center/serviced/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/control-center/serviced/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/control-center/serviced/git/refs{/sha}","trees_url":"https://api.github.com/repos/control-center/serviced/git/trees{/sha}","statuses_url":"https://api.github.com/repos/control-center/serviced/statuses/{sha}","languages_url":"https://api.github.com/repos/control-center/serviced/languages","stargazers_url":"https://api.github.com/repos/control-center/serviced/stargazers","contributors_url":"https://api.github.com/repos/control-center/serviced/contributors","subscribers_url":"https://api.github.com/repos/control-center/serviced/subscribers","subscription_url":"https://api.github.com/repos/control-center/serviced/subscription","commits_url":"https://api.github.com/repos/control-center/serviced/commits{/sha}","git_commits_url":"https://api.github.com/repos/control-center/serviced/git/commits{/sha}","comments_url":"https://api.github.com/repos/control-center/serviced/comments{/number}","issue_comment_url":"https://api.github.com/repos/control-center/serviced/issues/comments{/number}","contents_url":"https://api.github.com/repos/control-center/serviced/contents/{+path}","compare_url":"https://api.github.com/repos/control-center/serviced/compare/{base}...{head}","merges_url":"https://api.github.com/repos/control-center/serviced/merges","archive_url":"https://api.github.com/repos/control-center/serviced/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/control-center/serviced/downloads","issues_url":"https://api.github.com/repos/control-center/serviced/issues{/number}","pulls_url":"https://api.github.com/repos/control-center/serviced/pulls{/number}","milestones_url":"https://api.github.com/repos/control-center/serviced/milestones{/number}","notifications_url":"https://api.github.com/repos/control-center/serviced/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/control-center/serviced/labels{/name}","releases_url":"https://api.github.com/repos/control-center/serviced/releases{/id}","deployments_url":"https://api.github.com/repos/control-center/serviced/deployments","created_at":"2013-08-06T16:45:00Z","updated_at":"2016-09-01T22:28:08Z","pushed_at":"2016-09-27T14:00:40Z","git_url":"git://github.com/control-center/serviced.git","ssh_url":"git@github.com:control-center/serviced.git","clone_url":"https://github.com/control-center/serviced.git","svn_url":"https://github.com/control-center/serviced","homepage":null,"size":88358,"stargazers_count":94,"watchers_count":94,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":13,"forks":13,"open_issues":13,"watchers":94,"default_branch":"develop"}},"base":{"label":"control-center:develop","ref":"develop","sha":"c54d33c4930774e5419e0893df37e7dfd3eafd7d","user":{"login":"control-center","id":8160673,"avatar_url":"https://avatars.githubusercontent.com/u/8160673?v=3","gravatar_id":"","url":"https://api.github.com/users/control-center","html_url":"https://github.com/control-center","followers_url":"https://api.github.com/users/control-center/followers","following_url":"https://api.github.com/users/control-center/following{/other_user}","gists_url":"https://api.github.com/users/control-center/gists{/gist_id}","starred_url":"https://api.github.com/users/control-center/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/control-center/subscriptions","organizations_url":"https://api.github.com/users/control-center/orgs","repos_url":"https://api.github.com/users/control-center/repos","events_url":"https://api.github.com/users/control-center/events{/privacy}","received_events_url":"https://api.github.com/users/control-center/received_events","type":"Organization","site_admin":false},"repo":{"id":11929217,"name":"serviced","full_name":"control-center/serviced","owner":{"login":"control-center","id":8160673,"avatar_url":"https://avatars.githubusercontent.com/u/8160673?v=3","gravatar_id":"","url":"https://api.github.com/users/control-center","html_url":"https://github.com/control-center","followers_url":"https://api.github.com/users/control-center/followers","following_url":"https://api.github.com/users/control-center/following{/other_user}","gists_url":"https://api.github.com/users/control-center/gists{/gist_id}","starred_url":"https://api.github.com/users/control-center/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/control-center/subscriptions","organizations_url":"https://api.github.com/users/control-center/orgs","repos_url":"https://api.github.com/users/control-center/repos","events_url":"https://api.github.com/users/control-center/events{/privacy}","received_events_url":"https://api.github.com/users/control-center/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/control-center/serviced","description":"Serviced is a PaaS runtime. It allows users to create, manage and scale services in a uniform way.","fork":false,"url":"https://api.github.com/repos/control-center/serviced","forks_url":"https://api.github.com/repos/control-center/serviced/forks","keys_url":"https://api.github.com/repos/control-center/serviced/keys{/key_id}","collaborators_url":"https://api.github.com/repos/control-center/serviced/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/control-center/serviced/teams","hooks_url":"https://api.github.com/repos/control-center/serviced/hooks","issue_events_url":"https://api.github.com/repos/control-center/serviced/issues/events{/number}","events_url":"https://api.github.com/repos/control-center/serviced/events","assignees_url":"https://api.github.com/repos/control-center/serviced/assignees{/user}","branches_url":"https://api.github.com/repos/control-center/serviced/branches{/branch}","tags_url":"https://api.github.com/repos/control-center/serviced/tags","blobs_url":"https://api.github.com/repos/control-center/serviced/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/control-center/serviced/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/control-center/serviced/git/refs{/sha}","trees_url":"https://api.github.com/repos/control-center/serviced/git/trees{/sha}","statuses_url":"https://api.github.com/repos/control-center/serviced/statuses/{sha}","languages_url":"https://api.github.com/repos/control-center/serviced/languages","stargazers_url":"https://api.github.com/repos/control-center/serviced/stargazers","contributors_url":"https://api.github.com/repos/control-center/serviced/contributors","subscribers_url":"https://api.github.com/repos/control-center/serviced/subscribers","subscription_url":"https://api.github.com/repos/control-center/serviced/subscription","commits_url":"https://api.github.com/repos/control-center/serviced/commits{/sha}","git_commits_url":"https://api.github.com/repos/control-center/serviced/git/commits{/sha}","comments_url":"https://api.github.com/repos/control-center/serviced/comments{/number}","issue_comment_url":"https://api.github.com/repos/control-center/serviced/issues/comments{/number}","contents_url":"https://api.github.com/repos/control-center/serviced/contents/{+path}","compare_url":"https://api.github.com/repos/control-center/serviced/compare/{base}...{head}","merges_url":"https://api.github.com/repos/control-center/serviced/merges","archive_url":"https://api.github.com/repos/control-center/serviced/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/control-center/serviced/downloads","issues_url":"https://api.github.com/repos/control-center/serviced/issues{/number}","pulls_url":"https://api.github.com/repos/control-center/serviced/pulls{/number}","milestones_url":"https://api.github.com/repos/control-center/serviced/milestones{/number}","notifications_url":"https://api.github.com/repos/control-center/serviced/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/control-center/serviced/labels{/name}","releases_url":"https://api.github.com/repos/control-center/serviced/releases{/id}","deployments_url":"https://api.github.com/repos/control-center/serviced/deployments","created_at":"2013-08-06T16:45:00Z","updated_at":"2016-09-01T22:28:08Z","pushed_at":"2016-09-27T14:00:40Z","git_url":"git://github.com/control-center/serviced.git","ssh_url":"git@github.com:control-center/serviced.git","clone_url":"https://github.com/control-center/serviced.git","svn_url":"https://github.com/control-center/serviced","homepage":null,"size":88358,"stargazers_count":94,"watchers_count":94,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":13,"forks":13,"open_issues":13,"watchers":94,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/control-center/serviced/pulls/3014"},"html":{"href":"https://github.com/control-center/serviced/pull/3014"},"issue":{"href":"https://api.github.com/repos/control-center/serviced/issues/3014"},"comments":{"href":"https://api.github.com/repos/control-center/serviced/issues/3014/comments"},"review_comments":{"href":"https://api.github.com/repos/control-center/serviced/pulls/3014/comments"},"review_comment":{"href":"https://api.github.com/repos/control-center/serviced/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/control-center/serviced/pulls/3014/commits"},"statuses":{"href":"https://api.github.com/repos/control-center/serviced/statuses/313de1d560fece6c8043254a57c21d2d30de05d4"}}}}
{"actor":{"display_login":"smousa"}}