{"action":"created","issue":{"url":"https://api.github.com/repos/LiskHQ/lisk-explorer/issues/43","repository_url":"https://api.github.com/repos/LiskHQ/lisk-explorer","labels_url":"https://api.github.com/repos/LiskHQ/lisk-explorer/issues/43/labels{/name}","comments_url":"https://api.github.com/repos/LiskHQ/lisk-explorer/issues/43/comments","events_url":"https://api.github.com/repos/LiskHQ/lisk-explorer/issues/43/events","html_url":"https://github.com/LiskHQ/lisk-explorer/pull/43","id":197072755,"number":43,"title":"Initial test suite for API endpoints","user":{"login":"Isabello","id":16565680,"avatar_url":"https://avatars.githubusercontent.com/u/16565680?v=3","gravatar_id":"","url":"https://api.github.com/users/Isabello","html_url":"https://github.com/Isabello","followers_url":"https://api.github.com/users/Isabello/followers","following_url":"https://api.github.com/users/Isabello/following{/other_user}","gists_url":"https://api.github.com/users/Isabello/gists{/gist_id}","starred_url":"https://api.github.com/users/Isabello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Isabello/subscriptions","organizations_url":"https://api.github.com/users/Isabello/orgs","repos_url":"https://api.github.com/users/Isabello/repos","events_url":"https://api.github.com/users/Isabello/events{/privacy}","received_events_url":"https://api.github.com/users/Isabello/received_events","type":"User","site_admin":false},"labels":[{"id":477019938,"url":"https://api.github.com/repos/LiskHQ/lisk-explorer/labels/in%20progress","name":"in progress","color":"ededed","default":false},{"id":497670170,"url":"https://api.github.com/repos/LiskHQ/lisk-explorer/labels/test","name":"test","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/LiskHQ/lisk-explorer/milestones/1","html_url":"https://github.com/LiskHQ/lisk-explorer/milestone/1","labels_url":"https://api.github.com/repos/LiskHQ/lisk-explorer/milestones/1/labels","id":2209919,"number":1,"title":"Version 1.1.0","description":"","creator":{"login":"karmacoma","id":8068,"avatar_url":"https://avatars.githubusercontent.com/u/8068?v=3","gravatar_id":"","url":"https://api.github.com/users/karmacoma","html_url":"https://github.com/karmacoma","followers_url":"https://api.github.com/users/karmacoma/followers","following_url":"https://api.github.com/users/karmacoma/following{/other_user}","gists_url":"https://api.github.com/users/karmacoma/gists{/gist_id}","starred_url":"https://api.github.com/users/karmacoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karmacoma/subscriptions","organizations_url":"https://api.github.com/users/karmacoma/orgs","repos_url":"https://api.github.com/users/karmacoma/repos","events_url":"https://api.github.com/users/karmacoma/events{/privacy}","received_events_url":"https://api.github.com/users/karmacoma/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":1,"state":"open","created_at":"2016-12-21T13:21:26Z","updated_at":"2016-12-22T01:18:46Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2016-12-22T01:18:46Z","updated_at":"2016-12-22T22:26:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/LiskHQ/lisk-explorer/pulls/43","html_url":"https://github.com/LiskHQ/lisk-explorer/pull/43","diff_url":"https://github.com/LiskHQ/lisk-explorer/pull/43.diff","patch_url":"https://github.com/LiskHQ/lisk-explorer/pull/43.patch"},"body":"This is the initial implementation of the test suite for lisk-explorer. It has been tested against the current development branch and has been linted appropriately.\r\n\r\nThere are 71 tests included in this pull request. Three tests are on hold due pending improvements to explorer. those tests are listed below.\r\n\r\n  Delegates API\r\n    GET /api/delegates/getLastBlocks\r\n     - should be not ok with invalidPublicKey\r\n    GET /api/delegates/getDelegateProposals ---- Accompanies #44 \r\n      - should be ok\r\n\r\n\r\n  Transactions API\r\n    GET /api/getUnconfirmedTransactions\r\n      - should be ok\r\n\r\nCloses #25 \r\n"},"comment":{"url":"https://api.github.com/repos/LiskHQ/lisk-explorer/issues/comments/268904438","html_url":"https://github.com/LiskHQ/lisk-explorer/pull/43#issuecomment-268904438","issue_url":"https://api.github.com/repos/LiskHQ/lisk-explorer/issues/43","id":268904438,"user":{"login":"Isabello","id":16565680,"avatar_url":"https://avatars.githubusercontent.com/u/16565680?v=3","gravatar_id":"","url":"https://api.github.com/users/Isabello","html_url":"https://github.com/Isabello","followers_url":"https://api.github.com/users/Isabello/followers","following_url":"https://api.github.com/users/Isabello/following{/other_user}","gists_url":"https://api.github.com/users/Isabello/gists{/gist_id}","starred_url":"https://api.github.com/users/Isabello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Isabello/subscriptions","organizations_url":"https://api.github.com/users/Isabello/orgs","repos_url":"https://api.github.com/users/Isabello/repos","events_url":"https://api.github.com/users/Isabello/events{/privacy}","received_events_url":"https://api.github.com/users/Isabello/received_events","type":"User","site_admin":false},"created_at":"2016-12-22T22:26:10Z","updated_at":"2016-12-22T22:26:10Z","body":"I have restandardized all array checks to be `contain.all.keys`. We have 3 failures to sort as a result of endpoints returning inconsistently.\r\n\r\n```\r\nTransactions API\r\n    GET /api/getTransaction\r\n      ✓ should be ok with Genesis transaction\r\n      ✓ should be not be ok with no transaction\r\n    GET /api/getUnconfirmedTransactions\r\n      - should be ok\r\n    GET /api/getLastTransactions\r\n      1) should be ok\r\n    GET /api/getTransactionsByAddress\r\n      ✓ should be ok with Genesis address\r\n      ✓ should be ok with Genesis address and offset 20\r\n      ✓ should be not ok with invalid address\r\n    GET /api/getTransactionsByBlock\r\n      2) should be ok with Genesis block\r\n      3) should be ok with Genesis block and offset 20\r\n      ✓ should be not ok with invalid block\r\n```"}}
{"actor":{"display_login":"Isabello"}}