{"push_id":974677416,"size":32,"distinct_size":32,"ref":"refs/heads/master","head":"e7bfade6ed466aede3c2c5dd6645574e2fa7daaa","before":"d356d75b3ee94be0af81f26e7bf76e958075ce29","commits":[{"sha":"1ac7e1f95710232f1b1fb7aa50170c63fcd041a2","author":{"email":"7099a2ef6c50dd66fffbba5b54e936b391fa821e@gmail.com","name":"Joe Wu"},"message":"finatra: Fix Wrong Content-Length of UTF-8 String in HttpClient\n\nSigned-off-by: Ryan O'Neill <ryano@twitter.com>\n\nRB_ID=778552","distinct":true,"url":"https://api.github.com/repos/willianzhao/finatra/commits/1ac7e1f95710232f1b1fb7aa50170c63fcd041a2"},{"sha":"a529c2d0678fd96e10729972ac3d621096ad8641","author":{"email":"5015687688b04c91d7f0679ab6f77fef8ba30af8@gmail.com","name":"kidoz"},"message":"finatra: Removed Redundant Character '<' in logback.xml\n\nSigned-off-by: Ryan O'Neill <ryano@twitter.com>\n\nRB_ID=778577","distinct":true,"url":"https://api.github.com/repos/willianzhao/finatra/commits/a529c2d0678fd96e10729972ac3d621096ad8641"},{"sha":"31e14acf3b351805e2ba4d7eb8a944d9baf657b3","author":{"email":"b4c216d71f93c1da07b5809d0200ee9312e369af@twitter.com","name":"Kevin Rohrbaugh"},"message":"finatra/inject: Throw StartupTimeoutException on startup timeout\n\nProblem\n\nEmbeddedApp currently doesn't clearly signal a startup timeout, which\nmakes tests that fail due to timeout difficult to handle (e.g.,\nretry). This sometimes leads to integration tests using the class to\nbe reported as flaky.\n\nSolution\n\nThis adds a specific exception type (StartupTimeoutException) and\nuses it to signal startup timeout for tests using EmbeddedApp,\nallowing clients of the class to decide what (if any) corrective\naction they wish to take.\n\nRB_ID=779528","distinct":true,"url":"https://api.github.com/repos/willianzhao/finatra/commits/31e14acf3b351805e2ba4d7eb8a944d9baf657b3"},{"sha":"05cffcc75b0f6ade7a63d15386690e7809561f0c","author":{"email":"7047f4780c29ac24150c1010b697fe8556488e80@twitter.com","name":"Alex Leong"},"message":"Finatra: Improve finatra thrift support.\n\nProblem:\nImplementing thrift services in finatra requires manual codegen which is confusing and tedious.\n\nSolution:\nProvide a Controller trait that takes advantage of recent additions to scrooge to convert the user-provided function implementation to a Service implementation that can be filtered.\n\nResult:\nCodegen is no longer required.  The structure of finatra thrift services more closely mirrors the structure of finatra http services.\n\nRB_ID=777558\nTBR=true","distinct":true,"url":"https://api.github.com/repos/willianzhao/finatra/commits/05cffcc75b0f6ade7a63d15386690e7809561f0c"},{"sha":"51b9904f86f0e49f920a269ed15f2efc824c8969","author":{"email":"1e22922d4e9b854c983345382952ff896fb2936f@twitter.com","name":"Taylor Leese"},"message":"Default travisci to 2.11.7 similar to finagle/bin/travisci\n\nRB_ID=782244","distinct":true,"url":"https://api.github.com/repos/willianzhao/finatra/commits/51b9904f86f0e49f920a269ed15f2efc824c8969"},{"sha":"ac0820d62ba43ccace718ca5497d433883bd688a","author":{"email":"34e44d6323ba95dbfdb7bcc702d381f79e5a20a5@twitter.com","name":"Christopher Coco"},"message":"examples - Update examples documentation\n\nProblem\n\nSome of the examples documentation is out of date or incorrect.\n\nResolution\n\nUpdate the examples documentation.\n\nResult\n\nCorrect examples documentation resulting in less confusion.\n\nRB_ID=783014","distinct":true,"url":"https://api.github.com/repos/willianzhao/finatra/commits/ac0820d62ba43ccace718ca5497d433883bd688a"},{"sha":"1202591dde98da6c1f7d62baa6c67124e35966f3","author":{"email":"1e22922d4e9b854c983345382952ff896fb2936f@twitter.com","name":"Taylor Leese"},"message":"Bump Scala from 2.10.5 to 2.10.6 for Travis CI\n\nProblem:\n\nThe Travis CI builds use Scala 2.10.5, but our build.sbt and Build.scala files use 2.10.6. We should bump the Travis builds to use 2.10.6.\n\nSolution:\n\nBump the .travis.yml files to 2.10.6.\n\nResult:\n\nTravis CI uses 2.10.6 rather than 2.10.5.\n\nRB_ID=781291","distinct":true,"url":"https://api.github.com/repos/willianzhao/finatra/commits/1202591dde98da6c1f7d62baa6c67124e35966f3"},{"sha":"2c2944386b83ddc11379258628e58736f78e3582","author":{"email":"1e22922d4e9b854c983345382952ff896fb2936f@twitter.com","name":"Taylor Leese"},"message":"finatra: cleanup build warnings\n\nProblem:\n\nThere were a large number of build warnings in finatra.\n\nSolution:\n\n1) fix all the sbt related warnings\n2) fix as many of the build warnings as possible\n\nResult:\n\n1) sbt warnings are resolved\n2) 41/41 finatra src targets with fatal warnings enabled\n3) 17/21 finatra test targets with fatal warnings enabled\n\nRB_ID=782487\nTBR=true","distinct":true,"url":"https://api.github.com/repos/willianzhao/finatra/commits/2c2944386b83ddc11379258628e58736f78e3582"},{"sha":"d511d97e9b7a75dc4e5fb475280aee1861e92a71","author":{"email":"34e44d6323ba95dbfdb7bcc702d381f79e5a20a5@twitter.com","name":"Christopher Coco"},"message":"thrift - Add flag and functionality for announcing Thrift Server\n\nProblem\n\nWe don't currently expose the ability to announce a Thrift server\nakin to the functionality in the HttpServer (via BaseHttpServer).\n\nResolution\n\nAdd the 'thrift.announce' flag and functionality to invoke\nserver.announce when the flag is set to bring functionality on\npar with Http support.\n\nResult\n\nUsers will be able to optionally announce their Thrift server by\nsetting the 'thrift.announce' flag appropriately.\n\nRB_ID=787543","distinct":true,"url":"https://api.github.com/repos/willianzhao/finatra/commits/d511d97e9b7a75dc4e5fb475280aee1861e92a71"},{"sha":"eedf64d90cbb5864b68a8473949a2905b1643c10","author":{"email":"34e44d6323ba95dbfdb7bcc702d381f79e5a20a5@twitter.com","name":"Christopher Coco"},"message":"http - Ensure RouteInfo is available for use in filters Problem\n\nCurrently routing happens after filters which means that filters cannot\nmake use of the RouteInfo seeded into the Request.ctx. This would be\nproblematic for any filter that wanted to expose information for the\ngiven route requested, e.g., an authentication filter providing that it\nfailed authentication to a specific route.\n\nResolution\n\nChanged the HttpRouter to apply routing first before filtering.\n\nResult\n\nRouting information, e.g., the seeded RouteInfo object is available in\nthe Request.ctx for filters to use.\n\nRB_ID=786561\nTBR=true","distinct":true,"url":"https://api.github.com/repos/willianzhao/finatra/commits/eedf64d90cbb5864b68a8473949a2905b1643c10"},{"sha":"ce82b65f5dcd2737a04b820b57065d45f2cdca4a","author":{"email":"34e44d6323ba95dbfdb7bcc702d381f79e5a20a5@twitter.com","name":"Christopher Coco"},"message":"http - Add test case for all possible filtering on controllers\n\nProblem\n\nWe are currently missing a test-case in filter testing with routing\nwhere we don't cover per-controller filtering.\n\nResolution\n\nAdd this test case.\n\nResult\n\nCoverage of all the possible filtering on controllers.\n\nRB_ID=788764","distinct":true,"url":"https://api.github.com/repos/willianzhao/finatra/commits/ce82b65f5dcd2737a04b820b57065d45f2cdca4a"},{"sha":"3866fc71389aa0c055e95b9d19b93ace10ddc64f","author":{"email":"58ed595e8e04be6b3bac0e0cda9518f5691ca54b@twitter.com","name":"Ryan O'Neill"},"message":"finatra: Fix Race Condition in Exception Startup Integration Test\n\nProblem\n\nAn integration test within StartupIntegrationTest is\nnon-deterministic to where the Exception bubbling up\nand appStarted are competing to see who finishes first\nand is seen by the loop which is checking both values.\n\nSolution\n\nFor this test, add a method to make sure appStarted is\nnot set at all.\n\nResult\n\nAs long as the exception is thrown within the test timeout\nperiod, the test should always pass now.\n\nRB_ID=769699","distinct":true,"url":"https://api.github.com/repos/willianzhao/finatra/commits/3866fc71389aa0c055e95b9d19b93ace10ddc64f"},{"sha":"6dc85840045528f1d59f68e99d2ba1fc440d3b10","author":{"email":"34e44d6323ba95dbfdb7bcc702d381f79e5a20a5@twitter.com","name":"Christopher Coco"},"message":"finatra - Additional tests\n\nProblem\n\nWe have some gaps in test cases in the json and httpclient packages. Additionally,\nwe missed updating the examples/thrift-server server definition to include the\n\"new-style\" thrift controller.\n\nResolution\n\nAdd new test cases and update the example CalculatorServer.\n\nResult\n\nBetter test coverage and example with test coverage over new-style thrift controller.\n\nRB_ID=790517","distinct":true,"url":"https://api.github.com/repos/willianzhao/finatra/commits/6dc85840045528f1d59f68e99d2ba1fc440d3b10"},{"sha":"71cee86d8a4dd1f688b2776ac2ec57976f798787","author":{"email":"34e44d6323ba95dbfdb7bcc702d381f79e5a20a5@twitter.com","name":"Christopher Coco"},"message":"finatra - Update CONTRIBUTING documentation Problem\n\nWe were missing information on how to correctly format commit\nmessages to the Finatra codebase from the open-source\ncommunity.\n\nResolution\n\nAdd the documentation.\n\nResult\n\nCorrect guidelines on how to format a Finatra commit message.\n\nRB_ID=790543","distinct":true,"url":"https://api.github.com/repos/willianzhao/finatra/commits/71cee86d8a4dd1f688b2776ac2ec57976f798787"},{"sha":"719b904e648595fe554d926e1333b743b563dff2","author":{"email":"34e44d6323ba95dbfdb7bcc702d381f79e5a20a5@twitter.com","name":"Christopher Coco"},"message":"finatra - fix typo in CONTRIBUTING.md\n\nProblem\n\nThere's a typo in the documentation.\n\nResolution\n\nFix the typo.\n\nRB_ID=790669\nTBR=true","distinct":true,"url":"https://api.github.com/repos/willianzhao/finatra/commits/719b904e648595fe554d926e1333b743b563dff2"},{"sha":"a6f86841cc61ba9e5588f82ef31c53bcb8edbae5","author":{"email":"34e44d6323ba95dbfdb7bcc702d381f79e5a20a5@twitter.com","name":"Christopher Coco"},"message":"finatra-http - Fix handling of failed JSON parsing in HttpClient\n\nProblem\n\nIn the case that HttpClient#executeJson fails to parse the\nsuccessful response body into an instance of the type T\nwe do not properly handle the parsing failure.\n\nResolution\n\nChange the code to properly handle the parsing failure by\nwrapping the call in a Try and pattern-matching on the\nresult which branches into either a properly parsed\nresponse body or a failed future wrapping an\nHttpClientException which encodes the underlying exception.\n\nResult\n\nBetter handling when parsing the response body fails even\non a successful response.\n\nRB_ID=791067","distinct":true,"url":"https://api.github.com/repos/willianzhao/finatra/commits/a6f86841cc61ba9e5588f82ef31c53bcb8edbae5"},{"sha":"75218303539db11f1a0a124300d76e368527a238","author":{"email":"34e44d6323ba95dbfdb7bcc702d381f79e5a20a5@twitter.com","name":"Christopher Coco"},"message":"finatra/examples/thrift-server - Remove unneeded manual codegen\n\nProblem\n\nThe initial implementation of Finatra thrift support required manual\ncode generation. We've re-worked how we implement thrift support\nand this manual code generation is no longer needed.\n\nResolution\n\nRemove the manual_codegen package.\n\nResult\n\nLess cruft.\n\nRB_ID=792767","distinct":true,"url":"https://api.github.com/repos/willianzhao/finatra/commits/75218303539db11f1a0a124300d76e368527a238"},{"sha":"b827f87ab4161fad329fbce8817fd15bcf94c90a","author":{"email":"46f1a0bd5592a2f9244ca321b129902a06b53e03@jensraaby.com","name":"Jens Raaby"},"message":"Pass disableTestLogging argument to EmbeddedApp\n\nProblem\nThe disableTestLogging constructor parameter in EmbeddedHttpServer,\nEmbeddedThriftServer and EmbeddedTwitterServer is not passed to the EmbeddedApp\nconstructor. This means the parameter does not have any effect and all tests\nproduce a full verbose output even when this is not desired.\n\nSolution\nPass the disableTestLogging argument to the parent constructors.\n\nSigned-off-by: Ryan O'Neill <ryano@twitter.com>\n\nRB_ID=793017","distinct":true,"url":"https://api.github.com/repos/willianzhao/finatra/commits/b827f87ab4161fad329fbce8817fd15bcf94c90a"},{"sha":"9544052a7705a9b1c5b64b19dd462b5262aecb5e","author":{"email":"3a72f3af1752133ee697b6c0168dfeffec01e88c@fayimora.com","name":"Fayimora Femi-Balogun"},"message":"finatra: Fix Order of Validation Error Messages in README\n\nProblem\n\nValidation error messages are now sorted in lexicographic order.\nThe documentation should be changed to reflect the change.\n\nSolution\n\nUpdate the README file to reflect the ordering change.\n\nSigned-off-by: Ryan O'Neill <ryano@twitter.com>\n\nRB_ID=793050","distinct":true,"url":"https://api.github.com/repos/willianzhao/finatra/commits/9544052a7705a9b1c5b64b19dd462b5262aecb5e"},{"sha":"8abb5e7bd4162be3380b8fc080a86bea1a2cad0e","author":{"email":"34e44d6323ba95dbfdb7bcc702d381f79e5a20a5@twitter.com","name":"Christopher Coco"},"message":"finatra-thrift - Improve Finatra thrift controller implementation\n\nProblem\n\nThe current implementation of the Thrift controller in Finatra\nsuffers from the need to special-case logic for methods with\ngreater than 22 args.\n\nResolution\n\nWith a recent scrooge change we are able to simplify the thrift\ncontroller to always handle a Function1 from\nThriftMethod.Args => ThriftMethod.Result. This allows us to\nremove the special-case code for methods greater than 22 args\nand also more closely mirros the Http controller route DSL\nin which the callback is a Function1 of Request => Any.\n\nResult\n\nSimpler code for Thrift controllers.\n\nRB_ID=793713","distinct":true,"url":"https://api.github.com/repos/willianzhao/finatra/commits/8abb5e7bd4162be3380b8fc080a86bea1a2cad0e"}]}