{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/azure-armrest/pulls/comments/73008200","id":73008200,"diff_hunk":"@@ -93,8 +96,12 @@ def initialize(args)\n           :grant_type   => 'client_credentials',\n           :proxy        => ENV['http_proxy'],\n           :ssl_version  => 'TLSv1',\n+          :max_threads  => 10\n         }.merge(args.symbolize_keys)\n \n+        # Avoid thread safety issues for VCR testing.\n+        options[:max_threads] = 1 if defined?(VCR)\n+","path":"lib/azure/armrest/configuration.rb","position":19,"original_position":19,"commit_id":"1244872e3d106ba63e52284b6d6f6d5a5e8fa141","original_commit_id":"1244872e3d106ba63e52284b6d6f6d5a5e8fa141","user":{"login":"bronaghs","id":4379675,"avatar_url":"https://avatars.githubusercontent.com/u/4379675?v=3","gravatar_id":"","url":"https://api.github.com/users/bronaghs","html_url":"https://github.com/bronaghs","followers_url":"https://api.github.com/users/bronaghs/followers","following_url":"https://api.github.com/users/bronaghs/following{/other_user}","gists_url":"https://api.github.com/users/bronaghs/gists{/gist_id}","starred_url":"https://api.github.com/users/bronaghs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bronaghs/subscriptions","organizations_url":"https://api.github.com/users/bronaghs/orgs","repos_url":"https://api.github.com/users/bronaghs/repos","events_url":"https://api.github.com/users/bronaghs/events{/privacy}","received_events_url":"https://api.github.com/users/bronaghs/received_events","type":"User","site_admin":false},"body":"@djberg96 - If we do not set ```VCR``` how will we ever set the max_threads to 1?\r\nIm trying to understand the logic, its not that i do not like it.","created_at":"2016-08-01T16:25:46Z","updated_at":"2016-08-01T16:25:46Z","html_url":"https://github.com/ManageIQ/azure-armrest/pull/204#discussion_r73008200","pull_request_url":"https://api.github.com/repos/ManageIQ/azure-armrest/pulls/204","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/azure-armrest/pulls/comments/73008200"},"html":{"href":"https://github.com/ManageIQ/azure-armrest/pull/204#discussion_r73008200"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/azure-armrest/pulls/204"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/azure-armrest/pulls/204","id":79401794,"html_url":"https://github.com/ManageIQ/azure-armrest/pull/204","diff_url":"https://github.com/ManageIQ/azure-armrest/pull/204.diff","patch_url":"https://github.com/ManageIQ/azure-armrest/pull/204.patch","issue_url":"https://api.github.com/repos/ManageIQ/azure-armrest/issues/204","number":204,"state":"open","locked":false,"title":"Add a :max_threads configuration option","user":{"login":"djberg96","id":78529,"avatar_url":"https://avatars.githubusercontent.com/u/78529?v=3","gravatar_id":"","url":"https://api.github.com/users/djberg96","html_url":"https://github.com/djberg96","followers_url":"https://api.github.com/users/djberg96/followers","following_url":"https://api.github.com/users/djberg96/following{/other_user}","gists_url":"https://api.github.com/users/djberg96/gists{/gist_id}","starred_url":"https://api.github.com/users/djberg96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djberg96/subscriptions","organizations_url":"https://api.github.com/users/djberg96/orgs","repos_url":"https://api.github.com/users/djberg96/repos","events_url":"https://api.github.com/users/djberg96/events{/privacy}","received_events_url":"https://api.github.com/users/djberg96/received_events","type":"User","site_admin":false},"body":"This adds a :max_threads option with a default of 10. This value is used internally as the value for any calls to Parallel.\r\n\r\nBecause of thread safety issues caused by the interaction of the Parallel and VCR gems, the default is reduced to 1 in a VCR environment.\r\n\r\nThere was also a minor change made to the StorageAccount#all_blobs method so that we can control the maximum number of threads there as well.","created_at":"2016-07-29T18:21:43Z","updated_at":"2016-08-01T16:25:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6640a7cd2288fce4dc071333add5516848e8385","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/azure-armrest/pulls/204/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/azure-armrest/pulls/204/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/azure-armrest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/azure-armrest/issues/204/comments","statuses_url":"https://api.github.com/repos/ManageIQ/azure-armrest/statuses/1244872e3d106ba63e52284b6d6f6d5a5e8fa141","head":{"label":"djberg96:thread_config","ref":"thread_config","sha":"1244872e3d106ba63e52284b6d6f6d5a5e8fa141","user":{"login":"djberg96","id":78529,"avatar_url":"https://avatars.githubusercontent.com/u/78529?v=3","gravatar_id":"","url":"https://api.github.com/users/djberg96","html_url":"https://github.com/djberg96","followers_url":"https://api.github.com/users/djberg96/followers","following_url":"https://api.github.com/users/djberg96/following{/other_user}","gists_url":"https://api.github.com/users/djberg96/gists{/gist_id}","starred_url":"https://api.github.com/users/djberg96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djberg96/subscriptions","organizations_url":"https://api.github.com/users/djberg96/orgs","repos_url":"https://api.github.com/users/djberg96/repos","events_url":"https://api.github.com/users/djberg96/events{/privacy}","received_events_url":"https://api.github.com/users/djberg96/received_events","type":"User","site_admin":false},"repo":{"id":37276845,"name":"azure-armrest","full_name":"djberg96/azure-armrest","owner":{"login":"djberg96","id":78529,"avatar_url":"https://avatars.githubusercontent.com/u/78529?v=3","gravatar_id":"","url":"https://api.github.com/users/djberg96","html_url":"https://github.com/djberg96","followers_url":"https://api.github.com/users/djberg96/followers","following_url":"https://api.github.com/users/djberg96/following{/other_user}","gists_url":"https://api.github.com/users/djberg96/gists{/gist_id}","starred_url":"https://api.github.com/users/djberg96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djberg96/subscriptions","organizations_url":"https://api.github.com/users/djberg96/orgs","repos_url":"https://api.github.com/users/djberg96/repos","events_url":"https://api.github.com/users/djberg96/events{/privacy}","received_events_url":"https://api.github.com/users/djberg96/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/djberg96/azure-armrest","description":"Ruby interface for Azure using the new REST API","fork":true,"url":"https://api.github.com/repos/djberg96/azure-armrest","forks_url":"https://api.github.com/repos/djberg96/azure-armrest/forks","keys_url":"https://api.github.com/repos/djberg96/azure-armrest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/djberg96/azure-armrest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/djberg96/azure-armrest/teams","hooks_url":"https://api.github.com/repos/djberg96/azure-armrest/hooks","issue_events_url":"https://api.github.com/repos/djberg96/azure-armrest/issues/events{/number}","events_url":"https://api.github.com/repos/djberg96/azure-armrest/events","assignees_url":"https://api.github.com/repos/djberg96/azure-armrest/assignees{/user}","branches_url":"https://api.github.com/repos/djberg96/azure-armrest/branches{/branch}","tags_url":"https://api.github.com/repos/djberg96/azure-armrest/tags","blobs_url":"https://api.github.com/repos/djberg96/azure-armrest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/djberg96/azure-armrest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/djberg96/azure-armrest/git/refs{/sha}","trees_url":"https://api.github.com/repos/djberg96/azure-armrest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/djberg96/azure-armrest/statuses/{sha}","languages_url":"https://api.github.com/repos/djberg96/azure-armrest/languages","stargazers_url":"https://api.github.com/repos/djberg96/azure-armrest/stargazers","contributors_url":"https://api.github.com/repos/djberg96/azure-armrest/contributors","subscribers_url":"https://api.github.com/repos/djberg96/azure-armrest/subscribers","subscription_url":"https://api.github.com/repos/djberg96/azure-armrest/subscription","commits_url":"https://api.github.com/repos/djberg96/azure-armrest/commits{/sha}","git_commits_url":"https://api.github.com/repos/djberg96/azure-armrest/git/commits{/sha}","comments_url":"https://api.github.com/repos/djberg96/azure-armrest/comments{/number}","issue_comment_url":"https://api.github.com/repos/djberg96/azure-armrest/issues/comments{/number}","contents_url":"https://api.github.com/repos/djberg96/azure-armrest/contents/{+path}","compare_url":"https://api.github.com/repos/djberg96/azure-armrest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/djberg96/azure-armrest/merges","archive_url":"https://api.github.com/repos/djberg96/azure-armrest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/djberg96/azure-armrest/downloads","issues_url":"https://api.github.com/repos/djberg96/azure-armrest/issues{/number}","pulls_url":"https://api.github.com/repos/djberg96/azure-armrest/pulls{/number}","milestones_url":"https://api.github.com/repos/djberg96/azure-armrest/milestones{/number}","notifications_url":"https://api.github.com/repos/djberg96/azure-armrest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/djberg96/azure-armrest/labels{/name}","releases_url":"https://api.github.com/repos/djberg96/azure-armrest/releases{/id}","deployments_url":"https://api.github.com/repos/djberg96/azure-armrest/deployments","created_at":"2015-06-11T17:55:30Z","updated_at":"2016-01-25T15:33:18Z","pushed_at":"2016-07-29T18:18:39Z","git_url":"git://github.com/djberg96/azure-armrest.git","ssh_url":"git@github.com:djberg96/azure-armrest.git","clone_url":"https://github.com/djberg96/azure-armrest.git","svn_url":"https://github.com/djberg96/azure-armrest","homepage":null,"size":491,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"98a90e00d10f156d42f17abd265eb36d1d27f067","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":35620488,"name":"azure-armrest","full_name":"ManageIQ/azure-armrest","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/azure-armrest","description":"Ruby interface for Azure using the new REST API","fork":false,"url":"https://api.github.com/repos/ManageIQ/azure-armrest","forks_url":"https://api.github.com/repos/ManageIQ/azure-armrest/forks","keys_url":"https://api.github.com/repos/ManageIQ/azure-armrest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/azure-armrest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/azure-armrest/teams","hooks_url":"https://api.github.com/repos/ManageIQ/azure-armrest/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/azure-armrest/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/azure-armrest/events","assignees_url":"https://api.github.com/repos/ManageIQ/azure-armrest/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/azure-armrest/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/azure-armrest/tags","blobs_url":"https://api.github.com/repos/ManageIQ/azure-armrest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/azure-armrest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/azure-armrest/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/azure-armrest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/azure-armrest/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/azure-armrest/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/azure-armrest/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/azure-armrest/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/azure-armrest/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/azure-armrest/subscription","commits_url":"https://api.github.com/repos/ManageIQ/azure-armrest/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/azure-armrest/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/azure-armrest/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/azure-armrest/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/azure-armrest/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/azure-armrest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/azure-armrest/merges","archive_url":"https://api.github.com/repos/ManageIQ/azure-armrest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/azure-armrest/downloads","issues_url":"https://api.github.com/repos/ManageIQ/azure-armrest/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/azure-armrest/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/azure-armrest/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/azure-armrest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/azure-armrest/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/azure-armrest/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/azure-armrest/deployments","created_at":"2015-05-14T15:51:27Z","updated_at":"2016-03-08T18:13:35Z","pushed_at":"2016-07-29T18:21:44Z","git_url":"git://github.com/ManageIQ/azure-armrest.git","ssh_url":"git@github.com:ManageIQ/azure-armrest.git","clone_url":"https://github.com/ManageIQ/azure-armrest.git","svn_url":"https://github.com/ManageIQ/azure-armrest","homepage":null,"size":537,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":7,"forks":13,"open_issues":7,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/azure-armrest/pulls/204"},"html":{"href":"https://github.com/ManageIQ/azure-armrest/pull/204"},"issue":{"href":"https://api.github.com/repos/ManageIQ/azure-armrest/issues/204"},"comments":{"href":"https://api.github.com/repos/ManageIQ/azure-armrest/issues/204/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/azure-armrest/pulls/204/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/azure-armrest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/azure-armrest/pulls/204/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/azure-armrest/statuses/1244872e3d106ba63e52284b6d6f6d5a5e8fa141"}}}}
{"actor":{"display_login":"bronaghs"}}