{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/84203576","pull_request_review_id":4994876,"id":84203576,"diff_hunk":"@@ -87,21 +85,13 @@ class TableFileCatalog(\n         }\n         val partitionSpec = PartitionSpec(schema, partitions)\n         new PrunedTableFileCatalog(\n-          sparkSession, new Path(baseLocation.get), partitionSpec)\n+          sparkSession, new Path(baseLocation.get), fileStatusCache, partitionSpec)\n       case None =>\n-        new ListingFileCatalog(sparkSession, rootPaths, parameters, None)\n-    }\n-  }\n-\n-  // Not used in the hot path of queries when metastore partition pruning is enabled\n-  def allPartitions: ListingFileCatalog = synchronized {\n-    if (cachedAllPartitions == null) {","path":"sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/TableFileCatalog.scala","position":62,"original_position":62,"commit_id":"35b565bf7aa114068fc11fd50a0c51574be0cbe8","original_commit_id":"35b565bf7aa114068fc11fd50a0c51574be0cbe8","user":{"login":"cloud-fan","id":3182036,"avatar_url":"https://avatars.githubusercontent.com/u/3182036?v=3","gravatar_id":"","url":"https://api.github.com/users/cloud-fan","html_url":"https://github.com/cloud-fan","followers_url":"https://api.github.com/users/cloud-fan/followers","following_url":"https://api.github.com/users/cloud-fan/following{/other_user}","gists_url":"https://api.github.com/users/cloud-fan/gists{/gist_id}","starred_url":"https://api.github.com/users/cloud-fan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloud-fan/subscriptions","organizations_url":"https://api.github.com/users/cloud-fan/orgs","repos_url":"https://api.github.com/users/cloud-fan/repos","events_url":"https://api.github.com/users/cloud-fan/events{/privacy}","received_events_url":"https://api.github.com/users/cloud-fan/received_events","type":"User","site_admin":false},"body":"`cachedAllPartitions` is useless now.","created_at":"2016-10-20T02:24:39Z","updated_at":"2016-10-20T02:24:39Z","html_url":"https://github.com/apache/spark/pull/15539#discussion_r84203576","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/15539","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/84203576"},"html":{"href":"https://github.com/apache/spark/pull/15539#discussion_r84203576"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/15539"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/15539","id":89920883,"html_url":"https://github.com/apache/spark/pull/15539","diff_url":"https://github.com/apache/spark/pull/15539.diff","patch_url":"https://github.com/apache/spark/pull/15539.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/15539","number":15539,"state":"open","locked":false,"title":"[SPARK-17994] [SQL] Add back a file status cache for catalog tables","user":{"login":"ericl","id":14922,"avatar_url":"https://avatars.githubusercontent.com/u/14922?v=3","gravatar_id":"","url":"https://api.github.com/users/ericl","html_url":"https://github.com/ericl","followers_url":"https://api.github.com/users/ericl/followers","following_url":"https://api.github.com/users/ericl/following{/other_user}","gists_url":"https://api.github.com/users/ericl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericl/subscriptions","organizations_url":"https://api.github.com/users/ericl/orgs","repos_url":"https://api.github.com/users/ericl/repos","events_url":"https://api.github.com/users/ericl/events{/privacy}","received_events_url":"https://api.github.com/users/ericl/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nIn SPARK-16980, we removed the full in-memory cache of table partitions in favor of loading only needed partitions from the metastore. This greatly improves the initial latency of queries that only read a small fraction of table partitions.\r\n\r\nHowever, since the metastore does not store file statistics, we need to discover those from remote storage. With the loss of the in-memory file status cache this has to happen on each query, increasing the latency of repeated queries over the same partitions.\r\n\r\nThe proposal is to add back a per-table cache of partition contents, i.e. Map[Path, Array[FileStatus]]. This cache would be retained per-table, and can be invalidated through refreshTable() and refreshByPath(). Unlike the prior cache, it can be incrementally updated as new partitions are read.\r\n\r\n## How was this patch tested?\r\n\r\nExisting tests and new tests in `HiveTablePerfStatsSuite`.\r\n\r\ncc @mallman ","created_at":"2016-10-19T00:04:57Z","updated_at":"2016-10-20T02:24:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b856f5edb1b050216f2cb32ecbd8ba48cdf120b7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/15539/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/15539/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/15539/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/35b565bf7aa114068fc11fd50a0c51574be0cbe8","head":{"label":"ericl:meta-cache","ref":"meta-cache","sha":"35b565bf7aa114068fc11fd50a0c51574be0cbe8","user":{"login":"ericl","id":14922,"avatar_url":"https://avatars.githubusercontent.com/u/14922?v=3","gravatar_id":"","url":"https://api.github.com/users/ericl","html_url":"https://github.com/ericl","followers_url":"https://api.github.com/users/ericl/followers","following_url":"https://api.github.com/users/ericl/following{/other_user}","gists_url":"https://api.github.com/users/ericl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericl/subscriptions","organizations_url":"https://api.github.com/users/ericl/orgs","repos_url":"https://api.github.com/users/ericl/repos","events_url":"https://api.github.com/users/ericl/events{/privacy}","received_events_url":"https://api.github.com/users/ericl/received_events","type":"User","site_admin":false},"repo":{"id":23644625,"name":"spark","full_name":"ericl/spark","owner":{"login":"ericl","id":14922,"avatar_url":"https://avatars.githubusercontent.com/u/14922?v=3","gravatar_id":"","url":"https://api.github.com/users/ericl","html_url":"https://github.com/ericl","followers_url":"https://api.github.com/users/ericl/followers","following_url":"https://api.github.com/users/ericl/following{/other_user}","gists_url":"https://api.github.com/users/ericl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericl/subscriptions","organizations_url":"https://api.github.com/users/ericl/orgs","repos_url":"https://api.github.com/users/ericl/repos","events_url":"https://api.github.com/users/ericl/events{/privacy}","received_events_url":"https://api.github.com/users/ericl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericl/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/ericl/spark","forks_url":"https://api.github.com/repos/ericl/spark/forks","keys_url":"https://api.github.com/repos/ericl/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericl/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericl/spark/teams","hooks_url":"https://api.github.com/repos/ericl/spark/hooks","issue_events_url":"https://api.github.com/repos/ericl/spark/issues/events{/number}","events_url":"https://api.github.com/repos/ericl/spark/events","assignees_url":"https://api.github.com/repos/ericl/spark/assignees{/user}","branches_url":"https://api.github.com/repos/ericl/spark/branches{/branch}","tags_url":"https://api.github.com/repos/ericl/spark/tags","blobs_url":"https://api.github.com/repos/ericl/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericl/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericl/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericl/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericl/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/ericl/spark/languages","stargazers_url":"https://api.github.com/repos/ericl/spark/stargazers","contributors_url":"https://api.github.com/repos/ericl/spark/contributors","subscribers_url":"https://api.github.com/repos/ericl/spark/subscribers","subscription_url":"https://api.github.com/repos/ericl/spark/subscription","commits_url":"https://api.github.com/repos/ericl/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericl/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericl/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericl/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericl/spark/contents/{+path}","compare_url":"https://api.github.com/repos/ericl/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericl/spark/merges","archive_url":"https://api.github.com/repos/ericl/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericl/spark/downloads","issues_url":"https://api.github.com/repos/ericl/spark/issues{/number}","pulls_url":"https://api.github.com/repos/ericl/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/ericl/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/ericl/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericl/spark/labels{/name}","releases_url":"https://api.github.com/repos/ericl/spark/releases{/id}","deployments_url":"https://api.github.com/repos/ericl/spark/deployments","created_at":"2014-09-04T01:48:06Z","updated_at":"2016-07-30T22:03:00Z","pushed_at":"2016-10-19T22:53:07Z","git_url":"git://github.com/ericl/spark.git","ssh_url":"git@github.com:ericl/spark.git","clone_url":"https://github.com/ericl/spark.git","svn_url":"https://github.com/ericl/spark","homepage":null,"size":237923,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"444c2d22e38a8a78135adf0d3a3774f0e9fc866c","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2016-10-20T01:06:43Z","pushed_at":"2016-10-20T02:16:27Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":598677,"stargazers_count":10423,"watchers_count":10423,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9689,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":486,"forks":9689,"open_issues":486,"watchers":10423,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/15539"},"html":{"href":"https://github.com/apache/spark/pull/15539"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/15539"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/15539/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/15539/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/15539/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/35b565bf7aa114068fc11fd50a0c51574be0cbe8"}}}}
{"actor":{"display_login":"cloud-fan"}}