{"action":"created","issue":{"url":"https://api.github.com/repos/cfpb/retirement/issues/163","repository_url":"https://api.github.com/repos/cfpb/retirement","labels_url":"https://api.github.com/repos/cfpb/retirement/issues/163/labels{/name}","comments_url":"https://api.github.com/repos/cfpb/retirement/issues/163/comments","events_url":"https://api.github.com/repos/cfpb/retirement/issues/163/events","html_url":"https://github.com/cfpb/retirement/pull/163","id":150046795,"number":163,"title":"Lifetime","user":{"login":"higs4281","id":515885,"avatar_url":"https://avatars.githubusercontent.com/u/515885?v=3","gravatar_id":"","url":"https://api.github.com/users/higs4281","html_url":"https://github.com/higs4281","followers_url":"https://api.github.com/users/higs4281/followers","following_url":"https://api.github.com/users/higs4281/following{/other_user}","gists_url":"https://api.github.com/users/higs4281/gists{/gist_id}","starred_url":"https://api.github.com/users/higs4281/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/higs4281/subscriptions","organizations_url":"https://api.github.com/users/higs4281/orgs","repos_url":"https://api.github.com/users/higs4281/repos","events_url":"https://api.github.com/users/higs4281/events{/privacy}","received_events_url":"https://api.github.com/users/higs4281/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-04-21T11:31:07Z","updated_at":"2016-04-22T13:34:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cfpb/retirement/pulls/163","html_url":"https://github.com/cfpb/retirement/pull/163","diff_url":"https://github.com/cfpb/retirement/pull/163.diff","patch_url":"https://github.com/cfpb/retirement/pull/163.patch"},"body":"This fixes cases where we were overestimating lifetime benefit values \r\nand moves lifetime calculations into the api.\r\n\r\n## Additions\r\n- new `calculate_lifetime_benefits` function in `utils/ss_calculator`, plus tests\r\n- new `lifetime-model` in `js/models`, plus supporting views and functions\r\n\r\n## Deletions\r\n- js code for calculating lifetime benefits\r\n\r\n## testing\r\nexample DOBs from the @hlortiz test spreadsheet should match the \"Should be\" column for the given age.\r\n\r\nI tested every combination in Hector's spreadsheet, plus every earlier birth year back to 1945, when our tool stops reporting.\r\n\r\n## Review\r\n@amymok, @mistergone, @niqjohnson, @marteki\r\n\r\n## Checklist\r\n\r\n* [x] CHANGELOG has been updated\r\n"},"comment":{"url":"https://api.github.com/repos/cfpb/retirement/issues/comments/213430160","html_url":"https://github.com/cfpb/retirement/pull/163#issuecomment-213430160","issue_url":"https://api.github.com/repos/cfpb/retirement/issues/163","id":213430160,"user":{"login":"higs4281","id":515885,"avatar_url":"https://avatars.githubusercontent.com/u/515885?v=3","gravatar_id":"","url":"https://api.github.com/users/higs4281","html_url":"https://github.com/higs4281","followers_url":"https://api.github.com/users/higs4281/followers","following_url":"https://api.github.com/users/higs4281/following{/other_user}","gists_url":"https://api.github.com/users/higs4281/gists{/gist_id}","starred_url":"https://api.github.com/users/higs4281/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/higs4281/subscriptions","organizations_url":"https://api.github.com/users/higs4281/orgs","repos_url":"https://api.github.com/users/higs4281/repos","events_url":"https://api.github.com/users/higs4281/events{/privacy}","received_events_url":"https://api.github.com/users/higs4281/received_events","type":"User","site_admin":false},"created_at":"2016-04-22T13:34:40Z","updated_at":"2016-04-22T13:34:40Z","body":"too soon. pull request hasn't been accepted yet. i'll ping you when it's\ndeployed.\n\nOn Fri, Apr 22, 2016 at 9:33 AM, hlortiz <notifications@github.com> wrote:\n\n> Hi Team,\n>\n> I checked in Build but is still showing the wrong amounts. Am I testing\n> too eagerly, too soon, and in the wrong place ?\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly or view it on GitHub\n> <https://github.com/cfpb/retirement/pull/163#issuecomment-213429788>\n>\n"}}