{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/10084","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/10084/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/10084/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/10084/events","html_url":"https://github.com/openshift/origin/pull/10084","id":168106489,"number":10084,"title":"Handled working dir changes in Bash relative path util","user":{"login":"stevekuznetsov","id":7328370,"avatar_url":"https://avatars.githubusercontent.com/u/7328370?v=3","gravatar_id":"","url":"https://api.github.com/users/stevekuznetsov","html_url":"https://github.com/stevekuznetsov","followers_url":"https://api.github.com/users/stevekuznetsov/followers","following_url":"https://api.github.com/users/stevekuznetsov/following{/other_user}","gists_url":"https://api.github.com/users/stevekuznetsov/gists{/gist_id}","starred_url":"https://api.github.com/users/stevekuznetsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevekuznetsov/subscriptions","organizations_url":"https://api.github.com/users/stevekuznetsov/orgs","repos_url":"https://api.github.com/users/stevekuznetsov/repos","events_url":"https://api.github.com/users/stevekuznetsov/events{/privacy}","received_events_url":"https://api.github.com/users/stevekuznetsov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-07-28T14:15:58Z","updated_at":"2016-07-28T15:38:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/10084","html_url":"https://github.com/openshift/origin/pull/10084","diff_url":"https://github.com/openshift/origin/pull/10084.diff","patch_url":"https://github.com/openshift/origin/pull/10084.patch"},"body":"The `os::util::repository_relative_path` utility attempts to print\r\nthe relative path from the repo root to a file in the repo. To\r\naccomplish this, it utilizes `realpath` and is therefore dependent\r\non the working directory to be able to resolve relative paths. If\r\na script changes the current working directory, the utility breaks.\r\nWith this change, the working directory at the time of sourcing\r\nthe utility is recorded and used to make the function is robust to\r\nthat behavior.\r\n\r\nSigned-off-by: Steve Kuznetsov <skuznets@redhat.com>\r\n\r\nFixes https://github.com/openshift/origin/issues/10041\r\n\r\n@Miciah PTAL\r\n@enj FYI"},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/235933978","html_url":"https://github.com/openshift/origin/pull/10084#issuecomment-235933978","issue_url":"https://api.github.com/repos/openshift/origin/issues/10084","id":235933978,"user":{"login":"stevekuznetsov","id":7328370,"avatar_url":"https://avatars.githubusercontent.com/u/7328370?v=3","gravatar_id":"","url":"https://api.github.com/users/stevekuznetsov","html_url":"https://github.com/stevekuznetsov","followers_url":"https://api.github.com/users/stevekuznetsov/followers","following_url":"https://api.github.com/users/stevekuznetsov/following{/other_user}","gists_url":"https://api.github.com/users/stevekuznetsov/gists{/gist_id}","starred_url":"https://api.github.com/users/stevekuznetsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevekuznetsov/subscriptions","organizations_url":"https://api.github.com/users/stevekuznetsov/orgs","repos_url":"https://api.github.com/users/stevekuznetsov/repos","events_url":"https://api.github.com/users/stevekuznetsov/events{/privacy}","received_events_url":"https://api.github.com/users/stevekuznetsov/received_events","type":"User","site_admin":false},"created_at":"2016-07-28T15:38:41Z","updated_at":"2016-07-28T15:38:41Z","body":"@deads2k this has a successful test and LGTM from @Miciah"}}
{"actor":{"display_login":"stevekuznetsov"}}