{"action":"created","issue":{"url":"https://api.github.com/repos/project-ncl/pnc/issues/1073","repository_url":"https://api.github.com/repos/project-ncl/pnc","labels_url":"https://api.github.com/repos/project-ncl/pnc/issues/1073/labels{/name}","comments_url":"https://api.github.com/repos/project-ncl/pnc/issues/1073/comments","events_url":"https://api.github.com/repos/project-ncl/pnc/issues/1073/events","html_url":"https://github.com/project-ncl/pnc/pull/1073","id":163341085,"number":1073,"title":"NCL-2112 Loading bar for specific socket communication","user":{"login":"matedo1","id":17566891,"avatar_url":"https://avatars.githubusercontent.com/u/17566891?v=3","gravatar_id":"","url":"https://api.github.com/users/matedo1","html_url":"https://github.com/matedo1","followers_url":"https://api.github.com/users/matedo1/followers","following_url":"https://api.github.com/users/matedo1/following{/other_user}","gists_url":"https://api.github.com/users/matedo1/gists{/gist_id}","starred_url":"https://api.github.com/users/matedo1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matedo1/subscriptions","organizations_url":"https://api.github.com/users/matedo1/orgs","repos_url":"https://api.github.com/users/matedo1/repos","events_url":"https://api.github.com/users/matedo1/events{/privacy}","received_events_url":"https://api.github.com/users/matedo1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-07-01T08:03:21Z","updated_at":"2016-07-08T11:14:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/project-ncl/pnc/pulls/1073","html_url":"https://github.com/project-ncl/pnc/pull/1073","diff_url":"https://github.com/project-ncl/pnc/pull/1073.diff","patch_url":"https://github.com/project-ncl/pnc/pull/1073.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/project-ncl/pnc/issues/comments/231335358","html_url":"https://github.com/project-ncl/pnc/pull/1073#issuecomment-231335358","issue_url":"https://api.github.com/repos/project-ncl/pnc/issues/1073","id":231335358,"user":{"login":"alexcreasy","id":4092230,"avatar_url":"https://avatars.githubusercontent.com/u/4092230?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcreasy","html_url":"https://github.com/alexcreasy","followers_url":"https://api.github.com/users/alexcreasy/followers","following_url":"https://api.github.com/users/alexcreasy/following{/other_user}","gists_url":"https://api.github.com/users/alexcreasy/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcreasy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcreasy/subscriptions","organizations_url":"https://api.github.com/users/alexcreasy/orgs","repos_url":"https://api.github.com/users/alexcreasy/repos","events_url":"https://api.github.com/users/alexcreasy/events{/privacy}","received_events_url":"https://api.github.com/users/alexcreasy/received_events","type":"User","site_admin":false},"created_at":"2016-07-08T11:14:26Z","updated_at":"2016-07-08T11:14:26Z","body":"I would make a few changes here just to make the interceptor code more generic:\r\n\r\n- Each interceptor should be a named angular service/factory etc with the required methods, rather than an anonymous function.\r\n- Doing it this way allows you to inject the cfpLoading bar into the specific interceptor you want to use it in, rather than injecting it into all the interceptors.\r\n- To achieve this: \r\n  1) in the config block, simply push the string name of the angular service to the interceptors array instead of an anonymous function.\r\n  2) In the jsonrpc client you can use the $injector service when you iterate over the interceptors array calling $injector.get(interceptor) to get the instance of the specific interceptor (Use a try catch block and rethrow a better, more specific exception than the obscure $injector failed one you'll get). "}}
{"actor":{"display_login":"alexcreasy"}}