{"action":"created","comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/76111225","id":76111225,"diff_hunk":"@@ -145,6 +194,19 @@ public function getCategoriesId($segment, $query)\n \t */\n \tpublic function getNewsfeedId($segment, $query)\n \t{\n+\t\tif ($this->noIDs)\n+\t\t{\n+\t\t\t$db = JFactory::getDbo();\n+\t\t\t$dbquery = $db->getQuery(true);","path":"components/com_newsfeeds/router.php","position":107,"original_position":107,"commit_id":"6159beb327d5d4a3b9695680bcc0fa8ec4b77849","original_commit_id":"6159beb327d5d4a3b9695680bcc0fa8ec4b77849","user":{"login":"yvesh","id":897638,"avatar_url":"https://avatars.githubusercontent.com/u/897638?v=3","gravatar_id":"","url":"https://api.github.com/users/yvesh","html_url":"https://github.com/yvesh","followers_url":"https://api.github.com/users/yvesh/followers","following_url":"https://api.github.com/users/yvesh/following{/other_user}","gists_url":"https://api.github.com/users/yvesh/gists{/gist_id}","starred_url":"https://api.github.com/users/yvesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yvesh/subscriptions","organizations_url":"https://api.github.com/users/yvesh/orgs","repos_url":"https://api.github.com/users/yvesh/repos","events_url":"https://api.github.com/users/yvesh/events{/privacy}","received_events_url":"https://api.github.com/users/yvesh/received_events","type":"User","site_admin":false},"body":"see comments above","created_at":"2016-08-24T18:22:15Z","updated_at":"2016-08-24T18:22:15Z","html_url":"https://github.com/joomla/joomla-cms/pull/11320#discussion_r76111225","pull_request_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/11320","_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/76111225"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/11320#discussion_r76111225"},"pull_request":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/11320"}}},"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/11320","id":79046778,"html_url":"https://github.com/joomla/joomla-cms/pull/11320","diff_url":"https://github.com/joomla/joomla-cms/pull/11320.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/11320.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/11320","number":11320,"state":"open","locked":false,"title":"Routing: Remove IDs from SEF URLs (new)","user":{"login":"Hackwar","id":313866,"avatar_url":"https://avatars.githubusercontent.com/u/313866?v=3","gravatar_id":"","url":"https://api.github.com/users/Hackwar","html_url":"https://github.com/Hackwar","followers_url":"https://api.github.com/users/Hackwar/followers","following_url":"https://api.github.com/users/Hackwar/following{/other_user}","gists_url":"https://api.github.com/users/Hackwar/gists{/gist_id}","starred_url":"https://api.github.com/users/Hackwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hackwar/subscriptions","organizations_url":"https://api.github.com/users/Hackwar/orgs","repos_url":"https://api.github.com/users/Hackwar/repos","events_url":"https://api.github.com/users/Hackwar/events{/privacy}","received_events_url":"https://api.github.com/users/Hackwar/received_events","type":"User","site_admin":false},"body":"This PR removes the IDs from the URLs when using the new advanced routing. To test, please enable \"Use new URL routing\" and \"Remove IDs from URLs\" in the components options in the backend. You can set this feature individually for com_contact, com_content and com_newsfeeds. When set to yes, the IDs are removed from the URLs of the respective component\r\n\r\nSee #10170 for further discussion.\r\n","created_at":"2016-07-27T15:36:34Z","updated_at":"2016-08-24T18:22:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f57b5894cb5531cf514c09e995f8e9948851f044","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/11320/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/11320/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/11320/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/6159beb327d5d4a3b9695680bcc0fa8ec4b77849","head":{"label":"Hackwar:sef_no_IDs","ref":"sef_no_IDs","sha":"6159beb327d5d4a3b9695680bcc0fa8ec4b77849","user":{"login":"Hackwar","id":313866,"avatar_url":"https://avatars.githubusercontent.com/u/313866?v=3","gravatar_id":"","url":"https://api.github.com/users/Hackwar","html_url":"https://github.com/Hackwar","followers_url":"https://api.github.com/users/Hackwar/followers","following_url":"https://api.github.com/users/Hackwar/following{/other_user}","gists_url":"https://api.github.com/users/Hackwar/gists{/gist_id}","starred_url":"https://api.github.com/users/Hackwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hackwar/subscriptions","organizations_url":"https://api.github.com/users/Hackwar/orgs","repos_url":"https://api.github.com/users/Hackwar/repos","events_url":"https://api.github.com/users/Hackwar/events{/privacy}","received_events_url":"https://api.github.com/users/Hackwar/received_events","type":"User","site_admin":false},"repo":{"id":2499669,"name":"joomla-cms","full_name":"Hackwar/joomla-cms","owner":{"login":"Hackwar","id":313866,"avatar_url":"https://avatars.githubusercontent.com/u/313866?v=3","gravatar_id":"","url":"https://api.github.com/users/Hackwar","html_url":"https://github.com/Hackwar","followers_url":"https://api.github.com/users/Hackwar/followers","following_url":"https://api.github.com/users/Hackwar/following{/other_user}","gists_url":"https://api.github.com/users/Hackwar/gists{/gist_id}","starred_url":"https://api.github.com/users/Hackwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hackwar/subscriptions","organizations_url":"https://api.github.com/users/Hackwar/orgs","repos_url":"https://api.github.com/users/Hackwar/repos","events_url":"https://api.github.com/users/Hackwar/events{/privacy}","received_events_url":"https://api.github.com/users/Hackwar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Hackwar/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/Hackwar/joomla-cms","forks_url":"https://api.github.com/repos/Hackwar/joomla-cms/forks","keys_url":"https://api.github.com/repos/Hackwar/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Hackwar/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Hackwar/joomla-cms/teams","hooks_url":"https://api.github.com/repos/Hackwar/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/Hackwar/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/Hackwar/joomla-cms/events","assignees_url":"https://api.github.com/repos/Hackwar/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/Hackwar/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/Hackwar/joomla-cms/tags","blobs_url":"https://api.github.com/repos/Hackwar/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Hackwar/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Hackwar/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/Hackwar/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Hackwar/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/Hackwar/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/Hackwar/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/Hackwar/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/Hackwar/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/Hackwar/joomla-cms/subscription","commits_url":"https://api.github.com/repos/Hackwar/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/Hackwar/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/Hackwar/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/Hackwar/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/Hackwar/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/Hackwar/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Hackwar/joomla-cms/merges","archive_url":"https://api.github.com/repos/Hackwar/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Hackwar/joomla-cms/downloads","issues_url":"https://api.github.com/repos/Hackwar/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/Hackwar/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/Hackwar/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/Hackwar/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Hackwar/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/Hackwar/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/Hackwar/joomla-cms/deployments","created_at":"2011-10-02T14:42:41Z","updated_at":"2015-01-17T14:15:28Z","pushed_at":"2016-07-27T15:46:28Z","git_url":"git://github.com/Hackwar/joomla-cms.git","ssh_url":"git@github.com:Hackwar/joomla-cms.git","clone_url":"https://github.com/Hackwar/joomla-cms.git","svn_url":"https://github.com/Hackwar/joomla-cms","homepage":"http://joomla.org","size":150858,"stargazers_count":7,"watchers_count":7,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":7,"default_branch":"master"}},"base":{"label":"joomla:3.7.x","ref":"3.7.x","sha":"32766cdd017fb35d0a2fcaa49e6234413aaee56b","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2016-08-24T11:00:58Z","pushed_at":"2016-08-24T18:01:12Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":291964,"stargazers_count":2119,"watchers_count":2119,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2278,"mirror_url":null,"open_issues_count":487,"forks":2278,"open_issues":487,"watchers":2119,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/11320"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/11320"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/11320"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/11320/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/11320/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/11320/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/6159beb327d5d4a3b9695680bcc0fa8ec4b77849"}}}}
{"actor":{"display_login":"yvesh"}}