{"action":"created","issue":{"url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/3943","labels_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/3943/labels{/name}","comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/3943/comments","events_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/3943/events","html_url":"https://github.com/D-Programming-Language/phobos/pull/3943","id":127768262,"number":3943,"title":"Fix Phobos Issue 15586","user":{"login":"tsbockman","id":1332026,"avatar_url":"https://avatars.githubusercontent.com/u/1332026?v=3","gravatar_id":"","url":"https://api.github.com/users/tsbockman","html_url":"https://github.com/tsbockman","followers_url":"https://api.github.com/users/tsbockman/followers","following_url":"https://api.github.com/users/tsbockman/following{/other_user}","gists_url":"https://api.github.com/users/tsbockman/gists{/gist_id}","starred_url":"https://api.github.com/users/tsbockman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsbockman/subscriptions","organizations_url":"https://api.github.com/users/tsbockman/orgs","repos_url":"https://api.github.com/users/tsbockman/repos","events_url":"https://api.github.com/users/tsbockman/events{/privacy}","received_events_url":"https://api.github.com/users/tsbockman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":33,"created_at":"2016-01-20T19:46:03Z","updated_at":"2016-01-29T23:31:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/3943","html_url":"https://github.com/D-Programming-Language/phobos/pull/3943","diff_url":"https://github.com/D-Programming-Language/phobos/pull/3943.diff","patch_url":"https://github.com/D-Programming-Language/phobos/pull/3943.patch"},"body":"`std.utf.toUTF8()` violates memory safety when fed an invalid `dchar` value, causing segfaults or other wrong behaviour: https://issues.dlang.org/show_bug.cgi?id=15586\r\n\r\nWhile this PR is technically independent, the related DMD issue (https://issues.dlang.org/show_bug.cgi?id=15585) really ought to be fixed at the same time. PR here: https://github.com/D-Programming-Language/dmd/pull/5229"},"comment":{"url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/comments/177017259","html_url":"https://github.com/D-Programming-Language/phobos/pull/3943#issuecomment-177017259","issue_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/3943","id":177017259,"user":{"login":"JakobOvrum","id":155856,"avatar_url":"https://avatars.githubusercontent.com/u/155856?v=3","gravatar_id":"","url":"https://api.github.com/users/JakobOvrum","html_url":"https://github.com/JakobOvrum","followers_url":"https://api.github.com/users/JakobOvrum/followers","following_url":"https://api.github.com/users/JakobOvrum/following{/other_user}","gists_url":"https://api.github.com/users/JakobOvrum/gists{/gist_id}","starred_url":"https://api.github.com/users/JakobOvrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JakobOvrum/subscriptions","organizations_url":"https://api.github.com/users/JakobOvrum/orgs","repos_url":"https://api.github.com/users/JakobOvrum/repos","events_url":"https://api.github.com/users/JakobOvrum/events{/privacy}","received_events_url":"https://api.github.com/users/JakobOvrum/received_events","type":"User","site_admin":false},"created_at":"2016-01-29T23:31:14Z","updated_at":"2016-01-29T23:31:14Z","body":"`version(assert) assert(isValidDchar(c));` is exactly the same as `assert(isValidDchar(c));`.\r\n\r\nI think the assert should be removed so the replacement character is used in all circumstances."}}