{"action":"closed","number":34566,"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/34566","id":76829380,"html_url":"https://github.com/saltstack/salt/pull/34566","diff_url":"https://github.com/saltstack/salt/pull/34566.diff","patch_url":"https://github.com/saltstack/salt/pull/34566.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/34566","number":34566,"state":"closed","locked":false,"title":"Implement includes for the mongo ext_pillar.","user":{"login":"pcdummy","id":358074,"avatar_url":"https://avatars.githubusercontent.com/u/358074?v=3","gravatar_id":"","url":"https://api.github.com/users/pcdummy","html_url":"https://github.com/pcdummy","followers_url":"https://api.github.com/users/pcdummy/followers","following_url":"https://api.github.com/users/pcdummy/following{/other_user}","gists_url":"https://api.github.com/users/pcdummy/gists{/gist_id}","starred_url":"https://api.github.com/users/pcdummy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcdummy/subscriptions","organizations_url":"https://api.github.com/users/pcdummy/orgs","repos_url":"https://api.github.com/users/pcdummy/repos","events_url":"https://api.github.com/users/pcdummy/events{/privacy}","received_events_url":"https://api.github.com/users/pcdummy/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\n\r\nA WIP feature which adds the possibility to include files from other pillars for the mongo ext_pillar.\r\n\r\nPlease give feedback, i have the following questions:\r\n\r\n- Is it usefull, something that we want in core?\r\n- Is there a better way to handle from which environment we include future includes instead of \r\n  defining it per include.\r\n\r\n\r\nThis is an example of such a mongodb document that i use with includes:\r\n\r\n    {\r\n        \"_id\" : \"srv02.pcdummy.lan\",\r\n        \"include\" : [ \r\n            {\r\n                \"file\" : \"roles.base.server\",\r\n                \"saltenv\" : \"pcdummy\"\r\n            }, \r\n            {\r\n                \"file\" : \"roles.base.lxc\",\r\n                \"saltenv\" : \"pcdummy\"\r\n            }, \r\n            {\r\n                \"file\" : \"roles.base.postfix-relayclient\",\r\n                \"saltenv\" : \"pcdummy\"\r\n            }\r\n        ],\r\n        \"lxc\" : {\r\n            \"default_conf\" : [ \r\n                {\r\n                    \"lxc:network:type\" : \"veth\"\r\n                }, \r\n                {\r\n                    \"lxc:network:link\" : \"lanbr0\"\r\n                }, \r\n                {\r\n                    \"lxc:network:flags\" : \"up\"\r\n                }, \r\n                {\r\n                    \"lxc:network:hwaddr\" : \"00:16:3e:04:xx:xx\"\r\n                }\r\n            ],\r\n            \"users\" : {\r\n                \"lxd\" : {\r\n                    \"interfaces\" : {\r\n                        \"lanbr0\" : {\r\n                            \"type\" : \"veth\",\r\n                            \"count\" : 100\r\n                        }\r\n                    }\r\n                }\r\n            }\r\n        }\r\n    }\r\n\r\n### Tests written?\r\n\r\nNo, there are no tests for the mongo ext_pillar.\r\n\r\nSigned-off-by: Rene Jochum <rene@jochums.at>","created_at":"2016-07-08T23:48:05Z","updated_at":"2016-07-18T16:20:41Z","closed_at":"2016-07-18T16:20:41Z","merged_at":null,"merge_commit_sha":"e9af47ee4a987e62c3747b4672a8a90993cd5e25","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/34566/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/34566/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/34566/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/726eed651359c55c55cf471eaf4af71071e978e9","head":{"label":"pcdummy:mongo_include","ref":"mongo_include","sha":"726eed651359c55c55cf471eaf4af71071e978e9","user":{"login":"pcdummy","id":358074,"avatar_url":"https://avatars.githubusercontent.com/u/358074?v=3","gravatar_id":"","url":"https://api.github.com/users/pcdummy","html_url":"https://github.com/pcdummy","followers_url":"https://api.github.com/users/pcdummy/followers","following_url":"https://api.github.com/users/pcdummy/following{/other_user}","gists_url":"https://api.github.com/users/pcdummy/gists{/gist_id}","starred_url":"https://api.github.com/users/pcdummy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcdummy/subscriptions","organizations_url":"https://api.github.com/users/pcdummy/orgs","repos_url":"https://api.github.com/users/pcdummy/repos","events_url":"https://api.github.com/users/pcdummy/events{/privacy}","received_events_url":"https://api.github.com/users/pcdummy/received_events","type":"User","site_admin":false},"repo":{"id":38623776,"name":"salt","full_name":"pcdummy/salt","owner":{"login":"pcdummy","id":358074,"avatar_url":"https://avatars.githubusercontent.com/u/358074?v=3","gravatar_id":"","url":"https://api.github.com/users/pcdummy","html_url":"https://github.com/pcdummy","followers_url":"https://api.github.com/users/pcdummy/followers","following_url":"https://api.github.com/users/pcdummy/following{/other_user}","gists_url":"https://api.github.com/users/pcdummy/gists{/gist_id}","starred_url":"https://api.github.com/users/pcdummy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcdummy/subscriptions","organizations_url":"https://api.github.com/users/pcdummy/orgs","repos_url":"https://api.github.com/users/pcdummy/repos","events_url":"https://api.github.com/users/pcdummy/events{/privacy}","received_events_url":"https://api.github.com/users/pcdummy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pcdummy/salt","description":"Infrastructure automation and management system","fork":true,"url":"https://api.github.com/repos/pcdummy/salt","forks_url":"https://api.github.com/repos/pcdummy/salt/forks","keys_url":"https://api.github.com/repos/pcdummy/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pcdummy/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pcdummy/salt/teams","hooks_url":"https://api.github.com/repos/pcdummy/salt/hooks","issue_events_url":"https://api.github.com/repos/pcdummy/salt/issues/events{/number}","events_url":"https://api.github.com/repos/pcdummy/salt/events","assignees_url":"https://api.github.com/repos/pcdummy/salt/assignees{/user}","branches_url":"https://api.github.com/repos/pcdummy/salt/branches{/branch}","tags_url":"https://api.github.com/repos/pcdummy/salt/tags","blobs_url":"https://api.github.com/repos/pcdummy/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pcdummy/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pcdummy/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/pcdummy/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pcdummy/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/pcdummy/salt/languages","stargazers_url":"https://api.github.com/repos/pcdummy/salt/stargazers","contributors_url":"https://api.github.com/repos/pcdummy/salt/contributors","subscribers_url":"https://api.github.com/repos/pcdummy/salt/subscribers","subscription_url":"https://api.github.com/repos/pcdummy/salt/subscription","commits_url":"https://api.github.com/repos/pcdummy/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/pcdummy/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/pcdummy/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/pcdummy/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/pcdummy/salt/contents/{+path}","compare_url":"https://api.github.com/repos/pcdummy/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pcdummy/salt/merges","archive_url":"https://api.github.com/repos/pcdummy/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pcdummy/salt/downloads","issues_url":"https://api.github.com/repos/pcdummy/salt/issues{/number}","pulls_url":"https://api.github.com/repos/pcdummy/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/pcdummy/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/pcdummy/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pcdummy/salt/labels{/name}","releases_url":"https://api.github.com/repos/pcdummy/salt/releases{/id}","deployments_url":"https://api.github.com/repos/pcdummy/salt/deployments","created_at":"2015-07-06T14:24:53Z","updated_at":"2016-07-08T22:53:04Z","pushed_at":"2016-07-12T15:04:47Z","git_url":"git://github.com/pcdummy/salt.git","ssh_url":"git@github.com:pcdummy/salt.git","clone_url":"https://github.com/pcdummy/salt.git","svn_url":"https://github.com/pcdummy/salt","homepage":"saltstack.com","size":171925,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"saltstack:develop","ref":"develop","sha":"81d5a7a8dbb1889e6fc06e4c04cca2cc3650442a","user":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt Open software package repository here: ","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","deployments_url":"https://api.github.com/repos/saltstack/salt/deployments","created_at":"2011-02-20T20:16:56Z","updated_at":"2016-07-18T13:01:38Z","pushed_at":"2016-07-18T16:15:49Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"https://repo.saltstack.com/","size":246439,"stargazers_count":6707,"watchers_count":6707,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3019,"mirror_url":null,"open_issues_count":3641,"forks":3019,"open_issues":3641,"watchers":6707,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/34566"},"html":{"href":"https://github.com/saltstack/salt/pull/34566"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/34566"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/34566/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/34566/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/34566/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/726eed651359c55c55cf471eaf4af71071e978e9"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":9,"review_comments":2,"commits":2,"additions":138,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"pcdummy"}}