{"action":"opened","number":9,"pull_request":{"url":"https://api.github.com/repos/peteut/hapi-shelf/pulls/9","id":67021388,"html_url":"https://github.com/peteut/hapi-shelf/pull/9","diff_url":"https://github.com/peteut/hapi-shelf/pull/9.diff","patch_url":"https://github.com/peteut/hapi-shelf/pull/9.patch","issue_url":"https://api.github.com/repos/peteut/hapi-shelf/issues/9","number":9,"state":"open","locked":false,"title":"Destroy knex connection pool when the server shuts down.","user":{"login":"PaulMougel","id":1788596,"avatar_url":"https://avatars.githubusercontent.com/u/1788596?v=3","gravatar_id":"","url":"https://api.github.com/users/PaulMougel","html_url":"https://github.com/PaulMougel","followers_url":"https://api.github.com/users/PaulMougel/followers","following_url":"https://api.github.com/users/PaulMougel/following{/other_user}","gists_url":"https://api.github.com/users/PaulMougel/gists{/gist_id}","starred_url":"https://api.github.com/users/PaulMougel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaulMougel/subscriptions","organizations_url":"https://api.github.com/users/PaulMougel/orgs","repos_url":"https://api.github.com/users/PaulMougel/repos","events_url":"https://api.github.com/users/PaulMougel/events{/privacy}","received_events_url":"https://api.github.com/users/PaulMougel/received_events","type":"User","site_admin":false},"body":"When the hapi server shuts down, i.e. when the onPostStop server\r\nextension point is called we tear down knex's connection pool.\r\n\r\nOtherwise, when a hapi server is stopped using `server.stop()`, the connection pool is still alive and the node.js program does not stop.","created_at":"2016-04-19T13:48:36Z","updated_at":"2016-04-19T13:48:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/peteut/hapi-shelf/pulls/9/commits","review_comments_url":"https://api.github.com/repos/peteut/hapi-shelf/pulls/9/comments","review_comment_url":"https://api.github.com/repos/peteut/hapi-shelf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/peteut/hapi-shelf/issues/9/comments","statuses_url":"https://api.github.com/repos/peteut/hapi-shelf/statuses/9b82ae5bdea09ba728c5513f87f93e26b48bdd39","head":{"label":"PaulMougel:master","ref":"master","sha":"9b82ae5bdea09ba728c5513f87f93e26b48bdd39","user":{"login":"PaulMougel","id":1788596,"avatar_url":"https://avatars.githubusercontent.com/u/1788596?v=3","gravatar_id":"","url":"https://api.github.com/users/PaulMougel","html_url":"https://github.com/PaulMougel","followers_url":"https://api.github.com/users/PaulMougel/followers","following_url":"https://api.github.com/users/PaulMougel/following{/other_user}","gists_url":"https://api.github.com/users/PaulMougel/gists{/gist_id}","starred_url":"https://api.github.com/users/PaulMougel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaulMougel/subscriptions","organizations_url":"https://api.github.com/users/PaulMougel/orgs","repos_url":"https://api.github.com/users/PaulMougel/repos","events_url":"https://api.github.com/users/PaulMougel/events{/privacy}","received_events_url":"https://api.github.com/users/PaulMougel/received_events","type":"User","site_admin":false},"repo":{"id":56599266,"name":"hapi-shelf","full_name":"PaulMougel/hapi-shelf","owner":{"login":"PaulMougel","id":1788596,"avatar_url":"https://avatars.githubusercontent.com/u/1788596?v=3","gravatar_id":"","url":"https://api.github.com/users/PaulMougel","html_url":"https://github.com/PaulMougel","followers_url":"https://api.github.com/users/PaulMougel/followers","following_url":"https://api.github.com/users/PaulMougel/following{/other_user}","gists_url":"https://api.github.com/users/PaulMougel/gists{/gist_id}","starred_url":"https://api.github.com/users/PaulMougel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaulMougel/subscriptions","organizations_url":"https://api.github.com/users/PaulMougel/orgs","repos_url":"https://api.github.com/users/PaulMougel/repos","events_url":"https://api.github.com/users/PaulMougel/events{/privacy}","received_events_url":"https://api.github.com/users/PaulMougel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PaulMougel/hapi-shelf","description":"Hapi plugin for bookshelf","fork":true,"url":"https://api.github.com/repos/PaulMougel/hapi-shelf","forks_url":"https://api.github.com/repos/PaulMougel/hapi-shelf/forks","keys_url":"https://api.github.com/repos/PaulMougel/hapi-shelf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PaulMougel/hapi-shelf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PaulMougel/hapi-shelf/teams","hooks_url":"https://api.github.com/repos/PaulMougel/hapi-shelf/hooks","issue_events_url":"https://api.github.com/repos/PaulMougel/hapi-shelf/issues/events{/number}","events_url":"https://api.github.com/repos/PaulMougel/hapi-shelf/events","assignees_url":"https://api.github.com/repos/PaulMougel/hapi-shelf/assignees{/user}","branches_url":"https://api.github.com/repos/PaulMougel/hapi-shelf/branches{/branch}","tags_url":"https://api.github.com/repos/PaulMougel/hapi-shelf/tags","blobs_url":"https://api.github.com/repos/PaulMougel/hapi-shelf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PaulMougel/hapi-shelf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PaulMougel/hapi-shelf/git/refs{/sha}","trees_url":"https://api.github.com/repos/PaulMougel/hapi-shelf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PaulMougel/hapi-shelf/statuses/{sha}","languages_url":"https://api.github.com/repos/PaulMougel/hapi-shelf/languages","stargazers_url":"https://api.github.com/repos/PaulMougel/hapi-shelf/stargazers","contributors_url":"https://api.github.com/repos/PaulMougel/hapi-shelf/contributors","subscribers_url":"https://api.github.com/repos/PaulMougel/hapi-shelf/subscribers","subscription_url":"https://api.github.com/repos/PaulMougel/hapi-shelf/subscription","commits_url":"https://api.github.com/repos/PaulMougel/hapi-shelf/commits{/sha}","git_commits_url":"https://api.github.com/repos/PaulMougel/hapi-shelf/git/commits{/sha}","comments_url":"https://api.github.com/repos/PaulMougel/hapi-shelf/comments{/number}","issue_comment_url":"https://api.github.com/repos/PaulMougel/hapi-shelf/issues/comments{/number}","contents_url":"https://api.github.com/repos/PaulMougel/hapi-shelf/contents/{+path}","compare_url":"https://api.github.com/repos/PaulMougel/hapi-shelf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PaulMougel/hapi-shelf/merges","archive_url":"https://api.github.com/repos/PaulMougel/hapi-shelf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PaulMougel/hapi-shelf/downloads","issues_url":"https://api.github.com/repos/PaulMougel/hapi-shelf/issues{/number}","pulls_url":"https://api.github.com/repos/PaulMougel/hapi-shelf/pulls{/number}","milestones_url":"https://api.github.com/repos/PaulMougel/hapi-shelf/milestones{/number}","notifications_url":"https://api.github.com/repos/PaulMougel/hapi-shelf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PaulMougel/hapi-shelf/labels{/name}","releases_url":"https://api.github.com/repos/PaulMougel/hapi-shelf/releases{/id}","deployments_url":"https://api.github.com/repos/PaulMougel/hapi-shelf/deployments","created_at":"2016-04-19T13:30:20Z","updated_at":"2016-04-19T13:30:21Z","pushed_at":"2016-04-19T13:47:22Z","git_url":"git://github.com/PaulMougel/hapi-shelf.git","ssh_url":"git@github.com:PaulMougel/hapi-shelf.git","clone_url":"https://github.com/PaulMougel/hapi-shelf.git","svn_url":"https://github.com/PaulMougel/hapi-shelf","homepage":null,"size":35,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"peteut:master","ref":"master","sha":"04b7ede70b83c54988018205cb64b28ce940c4cc","user":{"login":"peteut","id":1288741,"avatar_url":"https://avatars.githubusercontent.com/u/1288741?v=3","gravatar_id":"","url":"https://api.github.com/users/peteut","html_url":"https://github.com/peteut","followers_url":"https://api.github.com/users/peteut/followers","following_url":"https://api.github.com/users/peteut/following{/other_user}","gists_url":"https://api.github.com/users/peteut/gists{/gist_id}","starred_url":"https://api.github.com/users/peteut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peteut/subscriptions","organizations_url":"https://api.github.com/users/peteut/orgs","repos_url":"https://api.github.com/users/peteut/repos","events_url":"https://api.github.com/users/peteut/events{/privacy}","received_events_url":"https://api.github.com/users/peteut/received_events","type":"User","site_admin":false},"repo":{"id":28409561,"name":"hapi-shelf","full_name":"peteut/hapi-shelf","owner":{"login":"peteut","id":1288741,"avatar_url":"https://avatars.githubusercontent.com/u/1288741?v=3","gravatar_id":"","url":"https://api.github.com/users/peteut","html_url":"https://github.com/peteut","followers_url":"https://api.github.com/users/peteut/followers","following_url":"https://api.github.com/users/peteut/following{/other_user}","gists_url":"https://api.github.com/users/peteut/gists{/gist_id}","starred_url":"https://api.github.com/users/peteut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peteut/subscriptions","organizations_url":"https://api.github.com/users/peteut/orgs","repos_url":"https://api.github.com/users/peteut/repos","events_url":"https://api.github.com/users/peteut/events{/privacy}","received_events_url":"https://api.github.com/users/peteut/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peteut/hapi-shelf","description":"Hapi plugin for bookshelf","fork":false,"url":"https://api.github.com/repos/peteut/hapi-shelf","forks_url":"https://api.github.com/repos/peteut/hapi-shelf/forks","keys_url":"https://api.github.com/repos/peteut/hapi-shelf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peteut/hapi-shelf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peteut/hapi-shelf/teams","hooks_url":"https://api.github.com/repos/peteut/hapi-shelf/hooks","issue_events_url":"https://api.github.com/repos/peteut/hapi-shelf/issues/events{/number}","events_url":"https://api.github.com/repos/peteut/hapi-shelf/events","assignees_url":"https://api.github.com/repos/peteut/hapi-shelf/assignees{/user}","branches_url":"https://api.github.com/repos/peteut/hapi-shelf/branches{/branch}","tags_url":"https://api.github.com/repos/peteut/hapi-shelf/tags","blobs_url":"https://api.github.com/repos/peteut/hapi-shelf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peteut/hapi-shelf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peteut/hapi-shelf/git/refs{/sha}","trees_url":"https://api.github.com/repos/peteut/hapi-shelf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peteut/hapi-shelf/statuses/{sha}","languages_url":"https://api.github.com/repos/peteut/hapi-shelf/languages","stargazers_url":"https://api.github.com/repos/peteut/hapi-shelf/stargazers","contributors_url":"https://api.github.com/repos/peteut/hapi-shelf/contributors","subscribers_url":"https://api.github.com/repos/peteut/hapi-shelf/subscribers","subscription_url":"https://api.github.com/repos/peteut/hapi-shelf/subscription","commits_url":"https://api.github.com/repos/peteut/hapi-shelf/commits{/sha}","git_commits_url":"https://api.github.com/repos/peteut/hapi-shelf/git/commits{/sha}","comments_url":"https://api.github.com/repos/peteut/hapi-shelf/comments{/number}","issue_comment_url":"https://api.github.com/repos/peteut/hapi-shelf/issues/comments{/number}","contents_url":"https://api.github.com/repos/peteut/hapi-shelf/contents/{+path}","compare_url":"https://api.github.com/repos/peteut/hapi-shelf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peteut/hapi-shelf/merges","archive_url":"https://api.github.com/repos/peteut/hapi-shelf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peteut/hapi-shelf/downloads","issues_url":"https://api.github.com/repos/peteut/hapi-shelf/issues{/number}","pulls_url":"https://api.github.com/repos/peteut/hapi-shelf/pulls{/number}","milestones_url":"https://api.github.com/repos/peteut/hapi-shelf/milestones{/number}","notifications_url":"https://api.github.com/repos/peteut/hapi-shelf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peteut/hapi-shelf/labels{/name}","releases_url":"https://api.github.com/repos/peteut/hapi-shelf/releases{/id}","deployments_url":"https://api.github.com/repos/peteut/hapi-shelf/deployments","created_at":"2014-12-23T17:02:31Z","updated_at":"2016-03-05T12:00:42Z","pushed_at":"2016-03-21T14:20:31Z","git_url":"git://github.com/peteut/hapi-shelf.git","ssh_url":"git@github.com:peteut/hapi-shelf.git","clone_url":"https://github.com/peteut/hapi-shelf.git","svn_url":"https://github.com/peteut/hapi-shelf","homepage":null,"size":34,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/peteut/hapi-shelf/pulls/9"},"html":{"href":"https://github.com/peteut/hapi-shelf/pull/9"},"issue":{"href":"https://api.github.com/repos/peteut/hapi-shelf/issues/9"},"comments":{"href":"https://api.github.com/repos/peteut/hapi-shelf/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/peteut/hapi-shelf/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/peteut/hapi-shelf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/peteut/hapi-shelf/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/peteut/hapi-shelf/statuses/9b82ae5bdea09ba728c5513f87f93e26b48bdd39"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":8,"deletions":0,"changed_files":1}}