{"action":"created","issue":{"url":"https://api.github.com/repos/openscenegraph/OpenSceneGraph/issues/104","repository_url":"https://api.github.com/repos/openscenegraph/OpenSceneGraph","labels_url":"https://api.github.com/repos/openscenegraph/OpenSceneGraph/issues/104/labels{/name}","comments_url":"https://api.github.com/repos/openscenegraph/OpenSceneGraph/issues/104/comments","events_url":"https://api.github.com/repos/openscenegraph/OpenSceneGraph/issues/104/events","html_url":"https://github.com/openscenegraph/OpenSceneGraph/pull/104","id":163875789,"number":104,"title":"Fixes LWS scene load","user":{"login":"marchelbling","id":628701,"avatar_url":"https://avatars.githubusercontent.com/u/628701?v=3","gravatar_id":"","url":"https://api.github.com/users/marchelbling","html_url":"https://github.com/marchelbling","followers_url":"https://api.github.com/users/marchelbling/followers","following_url":"https://api.github.com/users/marchelbling/following{/other_user}","gists_url":"https://api.github.com/users/marchelbling/gists{/gist_id}","starred_url":"https://api.github.com/users/marchelbling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marchelbling/subscriptions","organizations_url":"https://api.github.com/users/marchelbling/orgs","repos_url":"https://api.github.com/users/marchelbling/repos","events_url":"https://api.github.com/users/marchelbling/events{/privacy}","received_events_url":"https://api.github.com/users/marchelbling/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-05T15:15:42Z","updated_at":"2016-07-05T17:13:59Z","closed_at":"2016-07-05T17:13:59Z","pull_request":{"url":"https://api.github.com/repos/openscenegraph/OpenSceneGraph/pulls/104","html_url":"https://github.com/openscenegraph/OpenSceneGraph/pull/104","diff_url":"https://github.com/openscenegraph/OpenSceneGraph/pull/104.diff","patch_url":"https://github.com/openscenegraph/OpenSceneGraph/pull/104.patch"},"body":"`readRefFile` calls `readRefObjectFile` which finally calls `readObject`. However, the LWS plugin currently implements only `readNode` and not `readObject`."},"comment":{"url":"https://api.github.com/repos/openscenegraph/OpenSceneGraph/issues/comments/230541664","html_url":"https://github.com/openscenegraph/OpenSceneGraph/pull/104#issuecomment-230541664","issue_url":"https://api.github.com/repos/openscenegraph/OpenSceneGraph/issues/104","id":230541664,"user":{"login":"openscenegraph","id":213099,"avatar_url":"https://avatars.githubusercontent.com/u/213099?v=3","gravatar_id":"","url":"https://api.github.com/users/openscenegraph","html_url":"https://github.com/openscenegraph","followers_url":"https://api.github.com/users/openscenegraph/followers","following_url":"https://api.github.com/users/openscenegraph/following{/other_user}","gists_url":"https://api.github.com/users/openscenegraph/gists{/gist_id}","starred_url":"https://api.github.com/users/openscenegraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openscenegraph/subscriptions","organizations_url":"https://api.github.com/users/openscenegraph/orgs","repos_url":"https://api.github.com/users/openscenegraph/repos","events_url":"https://api.github.com/users/openscenegraph/events{/privacy}","received_events_url":"https://api.github.com/users/openscenegraph/received_events","type":"User","site_admin":false},"created_at":"2016-07-05T17:13:59Z","updated_at":"2016-07-05T17:13:59Z","body":"Just reviewed the changes and it'll introduce a dangling pointer as the temporary smart pointer return form readRefNodeFile() will be deleted within the same line of code.\r\n\r\nThe correct fix will be to implement the readObjectFile().   I've gone ahead an implement this, see commit:\r\n\r\nhttps://github.com/openscenegraph/OpenSceneGraph/commit/8066a1da044a187d526d7285b07bba1684914922"}}
{"actor":{"display_login":"openscenegraph"}}