{"push_id":959732798,"size":3,"distinct_size":3,"ref":"refs/heads/master","head":"5bfd7f68f17f94452716659a04f534653aa42795","before":"f5eb6283601041365e399465fce9b19062ec45a0","commits":[{"sha":"ba32510d062e5c94bb55c50e7d85caaf6389f393","author":{"email":"505e66ae45028a0596c853559221f0b72c1cee21@cfengine.com","name":"Kristian Amlie"},"message":"Redmine #7808: Do not drop privileges when changes permissions on non fifo\n\nThe reason is that dropping privileges has some unexpected\nconsequences: CFEngine operates recursively on a file tree in a way\nthat may leave the directory being operated on last (e.g. files inside\nthe directory are treated before the directory itself). This means\nthat if we drop privileges, we may not always have the permissions to\nenter the directory. This is impossible to fix for FIFOs (other than\nchanging the order that CFEngine does things, but that is on a\ndifferent code level and has other implications), because FIFOs will\nblock if we try to open a file descriptor to them, but we can fix it\nfor regular files by switching back to the old method of opening the\nfile descriptor and doing fchmod on that.\n\nAn additional level of complexity in this case is that the path may\nend in a symlink *pointing* to a FIFO, hence the code that opens the\ntrue parent directory of the leaf.\n\nAlso rename the CHMOD_SETEUID_WORKS flag to CHMOD_SETEUID_HIGHBITS_WORK\nto make it clearer that it is not seteuid support which is missing,\nbut support for seteuid together with high bit flags in permission\nmodes.\n\nChangelog: Fix a regression which would sometimes cause \"Permission\ndenied\" errors on files inside directories with very restricted\npermissions.\n\nBased on a patch by Alexis Mousset <alexis.mousset@normation.com>.","distinct":true,"url":"https://api.github.com/repos/cfengine/core/commits/ba32510d062e5c94bb55c50e7d85caaf6389f393"},{"sha":"3d2caa38b1cf9a2611254dc61f922a28ea2f3986","author":{"email":"672a770a339ada15b1dadbff63d3da13f64595f0@normation.com","name":"Jonathan Clarke"},"message":"Refs #7808: add test for recursive permissions change\n\nModified by: Kristian Amlie <kristian.amlie@cfengine.com>\n- Skip test for non-Linux.","distinct":true,"url":"https://api.github.com/repos/cfengine/core/commits/3d2caa38b1cf9a2611254dc61f922a28ea2f3986"},{"sha":"5bfd7f68f17f94452716659a04f534653aa42795","author":{"email":"4260da5b73dd37b888449667bcfd1f251e1d1b74@users.noreply.github.com","name":"Kristian Amlie"},"message":"Merge pull request #2482 from kacf/avoid_dropping_privileges\n\nRedmine #7808: Do not drop privileges when changes permissions on non fifo","distinct":true,"url":"https://api.github.com/repos/cfengine/core/commits/5bfd7f68f17f94452716659a04f534653aa42795"}]}