{"action":"created","comment":{"url":"https://api.github.com/repos/nss-dev/nss/pulls/comments/79437568","id":79437568,"diff_hunk":"@@ -1611,6 +1611,13 @@ tls13_HandleCertificateRequest(sslSocket *ss, SSL3Opaque *b, PRUint32 length)\n     if (rv != SECSuccess)\n         goto loser;\n \n+    /* We don't support post-handshake client auth, the certificate request","path":"lib/ssl/tls13con.c","position":13,"original_position":4,"commit_id":"e218474858e79a488cc9c77cbba0e230f28f8148","original_commit_id":"30ce6cbfbacc8b44161e9afc4e91a138fb4751fe","user":{"login":"ekr","id":1111457,"avatar_url":"https://avatars.githubusercontent.com/u/1111457?v=3","gravatar_id":"","url":"https://api.github.com/users/ekr","html_url":"https://github.com/ekr","followers_url":"https://api.github.com/users/ekr/followers","following_url":"https://api.github.com/users/ekr/following{/other_user}","gists_url":"https://api.github.com/users/ekr/gists{/gist_id}","starred_url":"https://api.github.com/users/ekr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekr/subscriptions","organizations_url":"https://api.github.com/users/ekr/orgs","repos_url":"https://api.github.com/users/ekr/repos","events_url":"https://api.github.com/users/ekr/events{/privacy}","received_events_url":"https://api.github.com/users/ekr/received_events","type":"User","site_admin":false},"body":"Instead of doing this, why not just encode a 0 rather than an empty-length array.","created_at":"2016-09-19T16:58:11Z","updated_at":"2016-09-19T16:58:37Z","html_url":"https://github.com/nss-dev/nss/pull/18#discussion_r79437568","pull_request_url":"https://api.github.com/repos/nss-dev/nss/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/nss-dev/nss/pulls/comments/79437568"},"html":{"href":"https://github.com/nss-dev/nss/pull/18#discussion_r79437568"},"pull_request":{"href":"https://api.github.com/repos/nss-dev/nss/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/nss-dev/nss/pulls/18","id":85816979,"html_url":"https://github.com/nss-dev/nss/pull/18","diff_url":"https://github.com/nss-dev/nss/pull/18.diff","patch_url":"https://github.com/nss-dev/nss/pull/18.patch","issue_url":"https://api.github.com/repos/nss-dev/nss/issues/18","number":18,"state":"open","locked":false,"title":"Bug 1303711 - Fail when the req_ctx is non-zero during the handshake","user":{"login":"ttaubert","id":300895,"avatar_url":"https://avatars.githubusercontent.com/u/300895?v=3","gravatar_id":"","url":"https://api.github.com/users/ttaubert","html_url":"https://github.com/ttaubert","followers_url":"https://api.github.com/users/ttaubert/followers","following_url":"https://api.github.com/users/ttaubert/following{/other_user}","gists_url":"https://api.github.com/users/ttaubert/gists{/gist_id}","starred_url":"https://api.github.com/users/ttaubert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttaubert/subscriptions","organizations_url":"https://api.github.com/users/ttaubert/orgs","repos_url":"https://api.github.com/users/ttaubert/repos","events_url":"https://api.github.com/users/ttaubert/events{/privacy}","received_events_url":"https://api.github.com/users/ttaubert/received_events","type":"User","site_admin":false},"body":"r? @ekr ","created_at":"2016-09-19T15:37:11Z","updated_at":"2016-09-19T16:58:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e392646196ff9a98ef993fee1d19b075deafa05c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nss-dev/nss/pulls/18/commits","review_comments_url":"https://api.github.com/repos/nss-dev/nss/pulls/18/comments","review_comment_url":"https://api.github.com/repos/nss-dev/nss/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nss-dev/nss/issues/18/comments","statuses_url":"https://api.github.com/repos/nss-dev/nss/statuses/e218474858e79a488cc9c77cbba0e230f28f8148","head":{"label":"ttaubert:bug/1303711-cert-req-ctx","ref":"bug/1303711-cert-req-ctx","sha":"e218474858e79a488cc9c77cbba0e230f28f8148","user":{"login":"ttaubert","id":300895,"avatar_url":"https://avatars.githubusercontent.com/u/300895?v=3","gravatar_id":"","url":"https://api.github.com/users/ttaubert","html_url":"https://github.com/ttaubert","followers_url":"https://api.github.com/users/ttaubert/followers","following_url":"https://api.github.com/users/ttaubert/following{/other_user}","gists_url":"https://api.github.com/users/ttaubert/gists{/gist_id}","starred_url":"https://api.github.com/users/ttaubert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttaubert/subscriptions","organizations_url":"https://api.github.com/users/ttaubert/orgs","repos_url":"https://api.github.com/users/ttaubert/repos","events_url":"https://api.github.com/users/ttaubert/events{/privacy}","received_events_url":"https://api.github.com/users/ttaubert/received_events","type":"User","site_admin":false},"repo":{"id":41915099,"name":"nss","full_name":"ttaubert/nss","owner":{"login":"ttaubert","id":300895,"avatar_url":"https://avatars.githubusercontent.com/u/300895?v=3","gravatar_id":"","url":"https://api.github.com/users/ttaubert","html_url":"https://github.com/ttaubert","followers_url":"https://api.github.com/users/ttaubert/followers","following_url":"https://api.github.com/users/ttaubert/following{/other_user}","gists_url":"https://api.github.com/users/ttaubert/gists{/gist_id}","starred_url":"https://api.github.com/users/ttaubert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttaubert/subscriptions","organizations_url":"https://api.github.com/users/ttaubert/orgs","repos_url":"https://api.github.com/users/ttaubert/repos","events_url":"https://api.github.com/users/ttaubert/events{/privacy}","received_events_url":"https://api.github.com/users/ttaubert/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ttaubert/nss","description":"Read only mirror of https://hg.mozilla.org/projects/nss","fork":true,"url":"https://api.github.com/repos/ttaubert/nss","forks_url":"https://api.github.com/repos/ttaubert/nss/forks","keys_url":"https://api.github.com/repos/ttaubert/nss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ttaubert/nss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ttaubert/nss/teams","hooks_url":"https://api.github.com/repos/ttaubert/nss/hooks","issue_events_url":"https://api.github.com/repos/ttaubert/nss/issues/events{/number}","events_url":"https://api.github.com/repos/ttaubert/nss/events","assignees_url":"https://api.github.com/repos/ttaubert/nss/assignees{/user}","branches_url":"https://api.github.com/repos/ttaubert/nss/branches{/branch}","tags_url":"https://api.github.com/repos/ttaubert/nss/tags","blobs_url":"https://api.github.com/repos/ttaubert/nss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ttaubert/nss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ttaubert/nss/git/refs{/sha}","trees_url":"https://api.github.com/repos/ttaubert/nss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ttaubert/nss/statuses/{sha}","languages_url":"https://api.github.com/repos/ttaubert/nss/languages","stargazers_url":"https://api.github.com/repos/ttaubert/nss/stargazers","contributors_url":"https://api.github.com/repos/ttaubert/nss/contributors","subscribers_url":"https://api.github.com/repos/ttaubert/nss/subscribers","subscription_url":"https://api.github.com/repos/ttaubert/nss/subscription","commits_url":"https://api.github.com/repos/ttaubert/nss/commits{/sha}","git_commits_url":"https://api.github.com/repos/ttaubert/nss/git/commits{/sha}","comments_url":"https://api.github.com/repos/ttaubert/nss/comments{/number}","issue_comment_url":"https://api.github.com/repos/ttaubert/nss/issues/comments{/number}","contents_url":"https://api.github.com/repos/ttaubert/nss/contents/{+path}","compare_url":"https://api.github.com/repos/ttaubert/nss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ttaubert/nss/merges","archive_url":"https://api.github.com/repos/ttaubert/nss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ttaubert/nss/downloads","issues_url":"https://api.github.com/repos/ttaubert/nss/issues{/number}","pulls_url":"https://api.github.com/repos/ttaubert/nss/pulls{/number}","milestones_url":"https://api.github.com/repos/ttaubert/nss/milestones{/number}","notifications_url":"https://api.github.com/repos/ttaubert/nss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ttaubert/nss/labels{/name}","releases_url":"https://api.github.com/repos/ttaubert/nss/releases{/id}","deployments_url":"https://api.github.com/repos/ttaubert/nss/deployments","created_at":"2015-09-04T12:41:17Z","updated_at":"2016-01-11T10:10:51Z","pushed_at":"2016-09-19T15:50:35Z","git_url":"git://github.com/ttaubert/nss.git","ssh_url":"git@github.com:ttaubert/nss.git","clone_url":"https://github.com/ttaubert/nss.git","svn_url":"https://github.com/ttaubert/nss","homepage":null,"size":31552,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nss-dev:master","ref":"master","sha":"cc10192656166002d2887d3972b9891f46303f9b","user":{"login":"nss-dev","id":13671625,"avatar_url":"https://avatars.githubusercontent.com/u/13671625?v=3","gravatar_id":"","url":"https://api.github.com/users/nss-dev","html_url":"https://github.com/nss-dev","followers_url":"https://api.github.com/users/nss-dev/followers","following_url":"https://api.github.com/users/nss-dev/following{/other_user}","gists_url":"https://api.github.com/users/nss-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/nss-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nss-dev/subscriptions","organizations_url":"https://api.github.com/users/nss-dev/orgs","repos_url":"https://api.github.com/users/nss-dev/repos","events_url":"https://api.github.com/users/nss-dev/events{/privacy}","received_events_url":"https://api.github.com/users/nss-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":41180493,"name":"nss","full_name":"nss-dev/nss","owner":{"login":"nss-dev","id":13671625,"avatar_url":"https://avatars.githubusercontent.com/u/13671625?v=3","gravatar_id":"","url":"https://api.github.com/users/nss-dev","html_url":"https://github.com/nss-dev","followers_url":"https://api.github.com/users/nss-dev/followers","following_url":"https://api.github.com/users/nss-dev/following{/other_user}","gists_url":"https://api.github.com/users/nss-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/nss-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nss-dev/subscriptions","organizations_url":"https://api.github.com/users/nss-dev/orgs","repos_url":"https://api.github.com/users/nss-dev/repos","events_url":"https://api.github.com/users/nss-dev/events{/privacy}","received_events_url":"https://api.github.com/users/nss-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nss-dev/nss","description":"Read only mirror of https://hg.mozilla.org/projects/nss","fork":false,"url":"https://api.github.com/repos/nss-dev/nss","forks_url":"https://api.github.com/repos/nss-dev/nss/forks","keys_url":"https://api.github.com/repos/nss-dev/nss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nss-dev/nss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nss-dev/nss/teams","hooks_url":"https://api.github.com/repos/nss-dev/nss/hooks","issue_events_url":"https://api.github.com/repos/nss-dev/nss/issues/events{/number}","events_url":"https://api.github.com/repos/nss-dev/nss/events","assignees_url":"https://api.github.com/repos/nss-dev/nss/assignees{/user}","branches_url":"https://api.github.com/repos/nss-dev/nss/branches{/branch}","tags_url":"https://api.github.com/repos/nss-dev/nss/tags","blobs_url":"https://api.github.com/repos/nss-dev/nss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nss-dev/nss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nss-dev/nss/git/refs{/sha}","trees_url":"https://api.github.com/repos/nss-dev/nss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nss-dev/nss/statuses/{sha}","languages_url":"https://api.github.com/repos/nss-dev/nss/languages","stargazers_url":"https://api.github.com/repos/nss-dev/nss/stargazers","contributors_url":"https://api.github.com/repos/nss-dev/nss/contributors","subscribers_url":"https://api.github.com/repos/nss-dev/nss/subscribers","subscription_url":"https://api.github.com/repos/nss-dev/nss/subscription","commits_url":"https://api.github.com/repos/nss-dev/nss/commits{/sha}","git_commits_url":"https://api.github.com/repos/nss-dev/nss/git/commits{/sha}","comments_url":"https://api.github.com/repos/nss-dev/nss/comments{/number}","issue_comment_url":"https://api.github.com/repos/nss-dev/nss/issues/comments{/number}","contents_url":"https://api.github.com/repos/nss-dev/nss/contents/{+path}","compare_url":"https://api.github.com/repos/nss-dev/nss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nss-dev/nss/merges","archive_url":"https://api.github.com/repos/nss-dev/nss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nss-dev/nss/downloads","issues_url":"https://api.github.com/repos/nss-dev/nss/issues{/number}","pulls_url":"https://api.github.com/repos/nss-dev/nss/pulls{/number}","milestones_url":"https://api.github.com/repos/nss-dev/nss/milestones{/number}","notifications_url":"https://api.github.com/repos/nss-dev/nss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nss-dev/nss/labels{/name}","releases_url":"https://api.github.com/repos/nss-dev/nss/releases{/id}","deployments_url":"https://api.github.com/repos/nss-dev/nss/deployments","created_at":"2015-08-21T22:42:26Z","updated_at":"2016-04-22T23:34:59Z","pushed_at":"2016-09-19T15:50:35Z","git_url":"git://github.com/nss-dev/nss.git","ssh_url":"git@github.com:nss-dev/nss.git","clone_url":"https://github.com/nss-dev/nss.git","svn_url":"https://github.com/nss-dev/nss","homepage":null,"size":47553,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":10,"forks":7,"open_issues":10,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nss-dev/nss/pulls/18"},"html":{"href":"https://github.com/nss-dev/nss/pull/18"},"issue":{"href":"https://api.github.com/repos/nss-dev/nss/issues/18"},"comments":{"href":"https://api.github.com/repos/nss-dev/nss/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/nss-dev/nss/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/nss-dev/nss/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nss-dev/nss/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/nss-dev/nss/statuses/e218474858e79a488cc9c77cbba0e230f28f8148"}}}}
{"actor":{"display_login":"ekr"}}