{"push_id":1421468342,"size":5,"distinct_size":1,"ref":"refs/heads/master","head":"d23fabfdc7bb442e4575f978f9c5b52f325f388d","before":"9361c5eacfad8dafe837af062baff9da6b6e2cb6","commits":[{"sha":"2e404d07021d4c01f9ca831a7bb222efc15bed70","author":{"name":"Nicolas Grekas","email":"ec5ccb19bcd9237073a700927cff7f3ddf333fd9@gmail.com"},"message":"[HttpKernel] Fix exception when serializing request attributes","distinct":false,"url":"https://api.github.com/repos/symfony/symfony/commits/2e404d07021d4c01f9ca831a7bb222efc15bed70"},{"sha":"380c2687e75d1e319b20b6d089034819ea89ed7f","author":{"name":"Fabien Potencier","email":"6094910757de3667a08340f5b21f6399d2ffcc52@gmail.com"},"message":"bug #20621 [HttpKernel] Fix exception when serializing request attributes (nicolas-grekas)\n\nThis PR was merged into the 3.2 branch.\n\nDiscussion\n----------\n\n[HttpKernel] Fix exception when serializing request attributes\n\n| Q             | A\n| ------------- | ---\n| Branch?       | 3.2\n| Bug fix?      | yes\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | -\n| License       | MIT\n| Doc PR        | -\n\nSerializing request attributes obviously fails easily since once can put anything there (I've just got an \"Exception: Serialization of 'Closure' is not allowed\").\nYet, we don't need attributes when forging a request to feed the TraceableUrlMatcher in RouterController.\nWell, technically one could for sure register a listener before the router to add an attribute to the request, then use that in the url matcher.\nBut, it makes no sense. And if it were to have, the profiler is already broken in this respect because in e.g. 3.1, the attribute array that is used here has already been processed by the ValueExporter. So the original values have already been altered.\n\nLet's just handle request attributes as all the other collected data: using var dumper.\n\nCommits\n-------\n\n2e404d0 [HttpKernel] Fix exception when serializing request attributes","distinct":false,"url":"https://api.github.com/repos/symfony/symfony/commits/380c2687e75d1e319b20b6d089034819ea89ed7f"},{"sha":"330c0696047d1c9ea142b448858cbb2ca719b4b5","author":{"name":"Grégoire Pineau","email":"0884ca0d1bc9a2a5a3937bfb106e8cff1729c6a9@lyrixx.info"},"message":"[Workflow] Fixed graphviz dumper for state machine","distinct":false,"url":"https://api.github.com/repos/symfony/symfony/commits/330c0696047d1c9ea142b448858cbb2ca719b4b5"},{"sha":"215208e3ebdec75cd512ef1abbcd2bb976d51273","author":{"name":"Fabien Potencier","email":"6094910757de3667a08340f5b21f6399d2ffcc52@gmail.com"},"message":"bug #20583 [Workflow] Fixed graphviz dumper for state machine (lyrixx)\n\nThis PR was submitted for the master branch but it was merged into the 3.2 branch instead (closes #20583).\n\nDiscussion\n----------\n\n[Workflow] Fixed graphviz dumper for state machine\n\n| Q             | A\n| ------------- | ---\n| Branch?       | master\n| Bug fix?      | yes\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | #20497\n| License       | MIT\n| Doc PR        | ~\n\n---\n\nBefore:\n![before](https://cloud.githubusercontent.com/assets/408368/20490801/77cc0abe-b00f-11e6-8094-f4d428d5acde.png)\nAfter:\n![after](https://cloud.githubusercontent.com/assets/408368/20490809/7d21a4b0-b00f-11e6-8de2-c5021fe2d4e0.png)\n\n---\n\nScript:\n```php\n<?php\n\nrequire __DIR__.'/vendor/autoload.php';\n\nuse Symfony\\Component\\Workflow\\Definition;\nuse Symfony\\Component\\Workflow\\Dumper\\StateMachineGraphvizDumper;\nuse Symfony\\Component\\Workflow\\Marking;\nuse Symfony\\Component\\Workflow\\StateMachine;\nuse Symfony\\Component\\Workflow\\Transition;\n\n$places = array('a', 'b', 'c', 'd');\n$transitions[] = new Transition('t1', 'a', 'b');\n$transitions[] = new Transition('t1', 'd', 'b');\n$transitions[] = new Transition('t2', 'b', 'c');\n$transitions[] = new Transition('t3', 'b', 'd');\n$definition = new Definition($places, $transitions);\n\n$marking = new Marking(['d' => 1]);\n\necho (new StateMachineGraphvizDumper())->dump($definition, $marking);\n```\n\nCommits\n-------\n\n330c069 [Workflow] Fixed graphviz dumper for state machine","distinct":false,"url":"https://api.github.com/repos/symfony/symfony/commits/215208e3ebdec75cd512ef1abbcd2bb976d51273"},{"sha":"d23fabfdc7bb442e4575f978f9c5b52f325f388d","author":{"name":"Fabien Potencier","email":"6094910757de3667a08340f5b21f6399d2ffcc52@gmail.com"},"message":"Merge branch '3.2'\n\n* 3.2:\n  [Workflow] Fixed graphviz dumper for state machine\n  [HttpKernel] Fix exception when serializing request attributes","distinct":true,"url":"https://api.github.com/repos/symfony/symfony/commits/d23fabfdc7bb442e4575f978f9c5b52f325f388d"}]}
{"actor":{"display_login":"fabpot"}}