{"action":"created","comment":{"url":"https://api.github.com/repos/ably/ably-ios/pulls/comments/83265521","pull_request_review_id":4120827,"id":83265521,"diff_hunk":"@@ -565,6 +565,72 @@ class RestClient: QuickSpec {\n             // RSC15\n             context(\"Host Fallback\") {\n \n+                // TO3k7\n+                context(\"fallbackHostsUseDefault option\") {\n+\n+                    it(\"allows the default fallback hosts to be used when @environment@ is not production\") {\n+                        let options = ARTClientOptions(key: \"xxxx:xxxx\")\n+                        options.environment = \"not-production\"\n+                        options.fallbackHosts = [\"fakeA.ably.io\", \"fakeB.ably.io\"]\n+                        options.fallbackHostsUseDefault = true\n+\n+                        let client = ARTRest(options: options)\n+                        expect(client.options.fallbackHostsUseDefault).to(beTrue())\n+                        // Not production\n+                        expect(client.options.environment).toNot(beNil())\n+                        expect(client.options.environment).toNot(equal(\"production\"))\n+\n+                        let fallback = ARTFallback(options: client.options)\n+                        expect(fallback.hosts).to(haveCount(ARTDefault.fallbackHosts().count))\n+\n+                        ARTDefault.fallbackHosts().forEach() {\n+                            expect(fallback.hosts).to(contain($0))\n+                        }\n+                    }\n+\n+                    it(\"allows the default fallback hosts to be used when a custom Realtime or REST host endpoint is being used\") {\n+                        let options = ARTClientOptions(key: \"xxxx:xxxx\")\n+                        options.restHost = \"fake1.ably.io\"\n+                        options.realtimeHost = \"fake2.ably.io\"\n+                        options.fallbackHosts = [\"fakeA.ably.io\", \"fakeB.ably.io\"]\n+                        options.fallbackHostsUseDefault = true","path":"Spec/RestClient.swift","position":32,"original_position":32,"commit_id":"074e8513ef0e25126b9480b809167422317397cb","original_commit_id":"074e8513ef0e25126b9480b809167422317397cb","user":{"login":"mattheworiordan","id":43789,"avatar_url":"https://avatars.githubusercontent.com/u/43789?v=3","gravatar_id":"","url":"https://api.github.com/users/mattheworiordan","html_url":"https://github.com/mattheworiordan","followers_url":"https://api.github.com/users/mattheworiordan/followers","following_url":"https://api.github.com/users/mattheworiordan/following{/other_user}","gists_url":"https://api.github.com/users/mattheworiordan/gists{/gist_id}","starred_url":"https://api.github.com/users/mattheworiordan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattheworiordan/subscriptions","organizations_url":"https://api.github.com/users/mattheworiordan/orgs","repos_url":"https://api.github.com/users/mattheworiordan/repos","events_url":"https://api.github.com/users/mattheworiordan/events{/privacy}","received_events_url":"https://api.github.com/users/mattheworiordan/received_events","type":"User","site_admin":false},"body":"As above, this says \"allows the default fallback hosts to be used\" yet you're providing fallback hosts in the Array","created_at":"2016-10-13T17:13:49Z","updated_at":"2016-10-13T17:13:49Z","html_url":"https://github.com/ably/ably-ios/pull/513#discussion_r83265521","pull_request_url":"https://api.github.com/repos/ably/ably-ios/pulls/513","_links":{"self":{"href":"https://api.github.com/repos/ably/ably-ios/pulls/comments/83265521"},"html":{"href":"https://github.com/ably/ably-ios/pull/513#discussion_r83265521"},"pull_request":{"href":"https://api.github.com/repos/ably/ably-ios/pulls/513"}}},"pull_request":{"url":"https://api.github.com/repos/ably/ably-ios/pulls/513","id":89180459,"html_url":"https://github.com/ably/ably-ios/pull/513","diff_url":"https://github.com/ably/ably-ios/pull/513.diff","patch_url":"https://github.com/ably/ably-ios/pull/513.patch","issue_url":"https://api.github.com/repos/ably/ably-ios/issues/513","number":513,"state":"open","locked":false,"title":"TO3k7","user":{"login":"ricardopereira","id":3541185,"avatar_url":"https://avatars.githubusercontent.com/u/3541185?v=3","gravatar_id":"","url":"https://api.github.com/users/ricardopereira","html_url":"https://github.com/ricardopereira","followers_url":"https://api.github.com/users/ricardopereira/followers","following_url":"https://api.github.com/users/ricardopereira/following{/other_user}","gists_url":"https://api.github.com/users/ricardopereira/gists{/gist_id}","starred_url":"https://api.github.com/users/ricardopereira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricardopereira/subscriptions","organizations_url":"https://api.github.com/users/ricardopereira/orgs","repos_url":"https://api.github.com/users/ricardopereira/repos","events_url":"https://api.github.com/users/ricardopereira/events{/privacy}","received_events_url":"https://api.github.com/users/ricardopereira/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-13T11:05:13Z","updated_at":"2016-10-13T17:14:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86d9c164f73ddf0122ef9051dbfbc0b88a4db2d6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ably/ably-ios/pulls/513/commits","review_comments_url":"https://api.github.com/repos/ably/ably-ios/pulls/513/comments","review_comment_url":"https://api.github.com/repos/ably/ably-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ably/ably-ios/issues/513/comments","statuses_url":"https://api.github.com/repos/ably/ably-ios/statuses/074e8513ef0e25126b9480b809167422317397cb","head":{"label":"ably:to3k7","ref":"to3k7","sha":"074e8513ef0e25126b9480b809167422317397cb","user":{"login":"ably","id":1859245,"avatar_url":"https://avatars.githubusercontent.com/u/1859245?v=3","gravatar_id":"","url":"https://api.github.com/users/ably","html_url":"https://github.com/ably","followers_url":"https://api.github.com/users/ably/followers","following_url":"https://api.github.com/users/ably/following{/other_user}","gists_url":"https://api.github.com/users/ably/gists{/gist_id}","starred_url":"https://api.github.com/users/ably/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ably/subscriptions","organizations_url":"https://api.github.com/users/ably/orgs","repos_url":"https://api.github.com/users/ably/repos","events_url":"https://api.github.com/users/ably/events{/privacy}","received_events_url":"https://api.github.com/users/ably/received_events","type":"Organization","site_admin":false},"repo":{"id":27377471,"name":"ably-ios","full_name":"ably/ably-ios","owner":{"login":"ably","id":1859245,"avatar_url":"https://avatars.githubusercontent.com/u/1859245?v=3","gravatar_id":"","url":"https://api.github.com/users/ably","html_url":"https://github.com/ably","followers_url":"https://api.github.com/users/ably/followers","following_url":"https://api.github.com/users/ably/following{/other_user}","gists_url":"https://api.github.com/users/ably/gists{/gist_id}","starred_url":"https://api.github.com/users/ably/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ably/subscriptions","organizations_url":"https://api.github.com/users/ably/orgs","repos_url":"https://api.github.com/users/ably/repos","events_url":"https://api.github.com/users/ably/events{/privacy}","received_events_url":"https://api.github.com/users/ably/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ably/ably-ios","description":"iOS Objective-C client for Ably real-time messaging service","fork":false,"url":"https://api.github.com/repos/ably/ably-ios","forks_url":"https://api.github.com/repos/ably/ably-ios/forks","keys_url":"https://api.github.com/repos/ably/ably-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ably/ably-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ably/ably-ios/teams","hooks_url":"https://api.github.com/repos/ably/ably-ios/hooks","issue_events_url":"https://api.github.com/repos/ably/ably-ios/issues/events{/number}","events_url":"https://api.github.com/repos/ably/ably-ios/events","assignees_url":"https://api.github.com/repos/ably/ably-ios/assignees{/user}","branches_url":"https://api.github.com/repos/ably/ably-ios/branches{/branch}","tags_url":"https://api.github.com/repos/ably/ably-ios/tags","blobs_url":"https://api.github.com/repos/ably/ably-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ably/ably-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ably/ably-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/ably/ably-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ably/ably-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/ably/ably-ios/languages","stargazers_url":"https://api.github.com/repos/ably/ably-ios/stargazers","contributors_url":"https://api.github.com/repos/ably/ably-ios/contributors","subscribers_url":"https://api.github.com/repos/ably/ably-ios/subscribers","subscription_url":"https://api.github.com/repos/ably/ably-ios/subscription","commits_url":"https://api.github.com/repos/ably/ably-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/ably/ably-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/ably/ably-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/ably/ably-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/ably/ably-ios/contents/{+path}","compare_url":"https://api.github.com/repos/ably/ably-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ably/ably-ios/merges","archive_url":"https://api.github.com/repos/ably/ably-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ably/ably-ios/downloads","issues_url":"https://api.github.com/repos/ably/ably-ios/issues{/number}","pulls_url":"https://api.github.com/repos/ably/ably-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/ably/ably-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/ably/ably-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ably/ably-ios/labels{/name}","releases_url":"https://api.github.com/repos/ably/ably-ios/releases{/id}","deployments_url":"https://api.github.com/repos/ably/ably-ios/deployments","created_at":"2014-12-01T12:00:37Z","updated_at":"2016-08-22T14:07:36Z","pushed_at":"2016-10-13T16:56:15Z","git_url":"git://github.com/ably/ably-ios.git","ssh_url":"git@github.com:ably/ably-ios.git","clone_url":"https://github.com/ably/ably-ios.git","svn_url":"https://github.com/ably/ably-ios","homepage":null,"size":3289,"stargazers_count":3,"watchers_count":3,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":15,"forks":8,"open_issues":15,"watchers":3,"default_branch":"master"}},"base":{"label":"ably:0-9-master","ref":"0-9-master","sha":"0de23e295795277ba499068bbb1c57a1ea30d354","user":{"login":"ably","id":1859245,"avatar_url":"https://avatars.githubusercontent.com/u/1859245?v=3","gravatar_id":"","url":"https://api.github.com/users/ably","html_url":"https://github.com/ably","followers_url":"https://api.github.com/users/ably/followers","following_url":"https://api.github.com/users/ably/following{/other_user}","gists_url":"https://api.github.com/users/ably/gists{/gist_id}","starred_url":"https://api.github.com/users/ably/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ably/subscriptions","organizations_url":"https://api.github.com/users/ably/orgs","repos_url":"https://api.github.com/users/ably/repos","events_url":"https://api.github.com/users/ably/events{/privacy}","received_events_url":"https://api.github.com/users/ably/received_events","type":"Organization","site_admin":false},"repo":{"id":27377471,"name":"ably-ios","full_name":"ably/ably-ios","owner":{"login":"ably","id":1859245,"avatar_url":"https://avatars.githubusercontent.com/u/1859245?v=3","gravatar_id":"","url":"https://api.github.com/users/ably","html_url":"https://github.com/ably","followers_url":"https://api.github.com/users/ably/followers","following_url":"https://api.github.com/users/ably/following{/other_user}","gists_url":"https://api.github.com/users/ably/gists{/gist_id}","starred_url":"https://api.github.com/users/ably/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ably/subscriptions","organizations_url":"https://api.github.com/users/ably/orgs","repos_url":"https://api.github.com/users/ably/repos","events_url":"https://api.github.com/users/ably/events{/privacy}","received_events_url":"https://api.github.com/users/ably/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ably/ably-ios","description":"iOS Objective-C client for Ably real-time messaging service","fork":false,"url":"https://api.github.com/repos/ably/ably-ios","forks_url":"https://api.github.com/repos/ably/ably-ios/forks","keys_url":"https://api.github.com/repos/ably/ably-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ably/ably-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ably/ably-ios/teams","hooks_url":"https://api.github.com/repos/ably/ably-ios/hooks","issue_events_url":"https://api.github.com/repos/ably/ably-ios/issues/events{/number}","events_url":"https://api.github.com/repos/ably/ably-ios/events","assignees_url":"https://api.github.com/repos/ably/ably-ios/assignees{/user}","branches_url":"https://api.github.com/repos/ably/ably-ios/branches{/branch}","tags_url":"https://api.github.com/repos/ably/ably-ios/tags","blobs_url":"https://api.github.com/repos/ably/ably-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ably/ably-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ably/ably-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/ably/ably-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ably/ably-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/ably/ably-ios/languages","stargazers_url":"https://api.github.com/repos/ably/ably-ios/stargazers","contributors_url":"https://api.github.com/repos/ably/ably-ios/contributors","subscribers_url":"https://api.github.com/repos/ably/ably-ios/subscribers","subscription_url":"https://api.github.com/repos/ably/ably-ios/subscription","commits_url":"https://api.github.com/repos/ably/ably-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/ably/ably-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/ably/ably-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/ably/ably-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/ably/ably-ios/contents/{+path}","compare_url":"https://api.github.com/repos/ably/ably-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ably/ably-ios/merges","archive_url":"https://api.github.com/repos/ably/ably-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ably/ably-ios/downloads","issues_url":"https://api.github.com/repos/ably/ably-ios/issues{/number}","pulls_url":"https://api.github.com/repos/ably/ably-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/ably/ably-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/ably/ably-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ably/ably-ios/labels{/name}","releases_url":"https://api.github.com/repos/ably/ably-ios/releases{/id}","deployments_url":"https://api.github.com/repos/ably/ably-ios/deployments","created_at":"2014-12-01T12:00:37Z","updated_at":"2016-08-22T14:07:36Z","pushed_at":"2016-10-13T16:56:15Z","git_url":"git://github.com/ably/ably-ios.git","ssh_url":"git@github.com:ably/ably-ios.git","clone_url":"https://github.com/ably/ably-ios.git","svn_url":"https://github.com/ably/ably-ios","homepage":null,"size":3289,"stargazers_count":3,"watchers_count":3,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":15,"forks":8,"open_issues":15,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ably/ably-ios/pulls/513"},"html":{"href":"https://github.com/ably/ably-ios/pull/513"},"issue":{"href":"https://api.github.com/repos/ably/ably-ios/issues/513"},"comments":{"href":"https://api.github.com/repos/ably/ably-ios/issues/513/comments"},"review_comments":{"href":"https://api.github.com/repos/ably/ably-ios/pulls/513/comments"},"review_comment":{"href":"https://api.github.com/repos/ably/ably-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ably/ably-ios/pulls/513/commits"},"statuses":{"href":"https://api.github.com/repos/ably/ably-ios/statuses/074e8513ef0e25126b9480b809167422317397cb"}}}}
{"actor":{"display_login":"mattheworiordan"}}