{"action":"created","issue":{"url":"https://api.github.com/repos/appfolio/rentlinx_client/issues/53","repository_url":"https://api.github.com/repos/appfolio/rentlinx_client","labels_url":"https://api.github.com/repos/appfolio/rentlinx_client/issues/53/labels{/name}","comments_url":"https://api.github.com/repos/appfolio/rentlinx_client/issues/53/comments","events_url":"https://api.github.com/repos/appfolio/rentlinx_client/issues/53/events","html_url":"https://github.com/appfolio/rentlinx_client/pull/53","id":151260298,"number":53,"title":"Change phone number validation to match RentLinx regex [Delivers #118038889]","user":{"login":"blakeherrington","id":18268801,"avatar_url":"https://avatars.githubusercontent.com/u/18268801?v=3","gravatar_id":"","url":"https://api.github.com/users/blakeherrington","html_url":"https://github.com/blakeherrington","followers_url":"https://api.github.com/users/blakeherrington/followers","following_url":"https://api.github.com/users/blakeherrington/following{/other_user}","gists_url":"https://api.github.com/users/blakeherrington/gists{/gist_id}","starred_url":"https://api.github.com/users/blakeherrington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blakeherrington/subscriptions","organizations_url":"https://api.github.com/users/blakeherrington/orgs","repos_url":"https://api.github.com/users/blakeherrington/repos","events_url":"https://api.github.com/users/blakeherrington/events{/privacy}","received_events_url":"https://api.github.com/users/blakeherrington/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"XanderStrike","id":1565303,"avatar_url":"https://avatars.githubusercontent.com/u/1565303?v=3","gravatar_id":"","url":"https://api.github.com/users/XanderStrike","html_url":"https://github.com/XanderStrike","followers_url":"https://api.github.com/users/XanderStrike/followers","following_url":"https://api.github.com/users/XanderStrike/following{/other_user}","gists_url":"https://api.github.com/users/XanderStrike/gists{/gist_id}","starred_url":"https://api.github.com/users/XanderStrike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XanderStrike/subscriptions","organizations_url":"https://api.github.com/users/XanderStrike/orgs","repos_url":"https://api.github.com/users/XanderStrike/repos","events_url":"https://api.github.com/users/XanderStrike/events{/privacy}","received_events_url":"https://api.github.com/users/XanderStrike/received_events","type":"User","site_admin":false},"milestone":null,"comments":4,"created_at":"2016-04-26T23:08:30Z","updated_at":"2016-04-29T02:56:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/appfolio/rentlinx_client/pulls/53","html_url":"https://github.com/appfolio/rentlinx_client/pull/53","diff_url":"https://github.com/appfolio/rentlinx_client/pull/53.diff","patch_url":"https://github.com/appfolio/rentlinx_client/pull/53.patch"},"body":"Only partially delivers this story... need to make the change in user vacancy settings validation as well in apm_bundle...\r\n\r\np.s. I noticed there was no \"ace\" label for this since it's a different repo! Let me know if I'm missing anything that should normally be included in a PR."},"comment":{"url":"https://api.github.com/repos/appfolio/rentlinx_client/issues/comments/215615721","html_url":"https://github.com/appfolio/rentlinx_client/pull/53#issuecomment-215615721","issue_url":"https://api.github.com/repos/appfolio/rentlinx_client/issues/53","id":215615721,"user":{"login":"blakeherrington","id":18268801,"avatar_url":"https://avatars.githubusercontent.com/u/18268801?v=3","gravatar_id":"","url":"https://api.github.com/users/blakeherrington","html_url":"https://github.com/blakeherrington","followers_url":"https://api.github.com/users/blakeherrington/followers","following_url":"https://api.github.com/users/blakeherrington/following{/other_user}","gists_url":"https://api.github.com/users/blakeherrington/gists{/gist_id}","starred_url":"https://api.github.com/users/blakeherrington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blakeherrington/subscriptions","organizations_url":"https://api.github.com/users/blakeherrington/orgs","repos_url":"https://api.github.com/users/blakeherrington/repos","events_url":"https://api.github.com/users/blakeherrington/events{/privacy}","received_events_url":"https://api.github.com/users/blakeherrington/received_events","type":"User","site_admin":false},"created_at":"2016-04-29T02:56:16Z","updated_at":"2016-04-29T02:56:16Z","body":"After working on enforcing the same changes in property for when we save the user vacancy settings, I realized the way we were calculating the processed value had some weird implications.... we were just ripping out all non digits... but that means a number like (619) 495-rent(4953), would be valid, which I don't think we want. The new change will only strip out +, -, (,) and a space... I think this covers what would be in a valid phone number but not 100% sure. I also beefed up the tests to match what we're doing in property as well.\r\n\r\nLet me know if you guys agree with this change and we can finish things up for this story. 👍 "}}