{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/73332985","id":73332985,"diff_hunk":"@@ -0,0 +1,4 @@\n+module ManageIQ::Providers","path":"app/models/manageiq/providers/hawkular/middleware_manager/middleware_domain.rb","position":1,"original_position":1,"commit_id":"abd28236f2197fdf49ec14cb663d52d34f5b6e5a","original_commit_id":"abd28236f2197fdf49ec14cb663d52d34f5b6e5a","user":{"login":"Jiri-Kremser","id":535866,"avatar_url":"https://avatars.githubusercontent.com/u/535866?v=3","gravatar_id":"","url":"https://api.github.com/users/Jiri-Kremser","html_url":"https://github.com/Jiri-Kremser","followers_url":"https://api.github.com/users/Jiri-Kremser/followers","following_url":"https://api.github.com/users/Jiri-Kremser/following{/other_user}","gists_url":"https://api.github.com/users/Jiri-Kremser/gists{/gist_id}","starred_url":"https://api.github.com/users/Jiri-Kremser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jiri-Kremser/subscriptions","organizations_url":"https://api.github.com/users/Jiri-Kremser/orgs","repos_url":"https://api.github.com/users/Jiri-Kremser/repos","events_url":"https://api.github.com/users/Jiri-Kremser/events{/privacy}","received_events_url":"https://api.github.com/users/Jiri-Kremser/received_events","type":"User","site_admin":false},"body":"> perhaps I missed it, but where is acts_as_miq_taggable that enables tagging?\r\n\r\nyeah, I know, I've added it in a followup PR\r\n_https://github.com/ManageIQ/manageiq/pull/10172/files#diff-f783050e3d83a5114e9f9733a53ab741R5_\r\n\r\n> aren't the new models extending ActiveRecord or I misunderstood something? (like, for example, middleware_deployment, middleware_server, etc.)\r\n\r\nThey are, here https://github.com/ManageIQ/manageiq/pull/10048/files#diff-f783050e3d83a5114e9f9733a53ab741R1\r\n\r\nI don't understand the need for the duplicity either, but I feel it has to do something with the general middleware entity ([link](https://github.com/ManageIQ/manageiq/blob/master/app/models/middleware_server.rb)) X hawkula entity ([link](https://github.com/ManageIQ/manageiq/blob/master/app/models/manageiq/providers/hawkular/middleware_manager/middleware_server.rb))\r\n\r\nI used the same approach.. acutally, now I've noticed that 1 is under `app/models/` and the second that extends the first is under `app/models/manageiq/providers/hawkular/middleware_manager/`.","created_at":"2016-08-03T12:55:56Z","updated_at":"2016-08-03T12:55:56Z","html_url":"https://github.com/ManageIQ/manageiq/pull/10048#discussion_r73332985","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10048","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/73332985"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/10048#discussion_r73332985"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10048"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10048","id":78772949,"html_url":"https://github.com/ManageIQ/manageiq/pull/10048","diff_url":"https://github.com/ManageIQ/manageiq/pull/10048.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/10048.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10048","number":10048,"state":"open","locked":false,"title":"Adding models for middleware domain and server groups","user":{"login":"Jiri-Kremser","id":535866,"avatar_url":"https://avatars.githubusercontent.com/u/535866?v=3","gravatar_id":"","url":"https://api.github.com/users/Jiri-Kremser","html_url":"https://github.com/Jiri-Kremser","followers_url":"https://api.github.com/users/Jiri-Kremser/followers","following_url":"https://api.github.com/users/Jiri-Kremser/following{/other_user}","gists_url":"https://api.github.com/users/Jiri-Kremser/gists{/gist_id}","starred_url":"https://api.github.com/users/Jiri-Kremser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jiri-Kremser/subscriptions","organizations_url":"https://api.github.com/users/Jiri-Kremser/orgs","repos_url":"https://api.github.com/users/Jiri-Kremser/repos","events_url":"https://api.github.com/users/Jiri-Kremser/events{/privacy}","received_events_url":"https://api.github.com/users/Jiri-Kremser/received_events","type":"User","site_admin":false},"body":"No UI, only models, refresher logic and tests.\r\n\r\nThis PR adds two new models *middleware_domain* and *middleware_server_group*, the relations are as follows:\r\n\r\n| middleware_domain |  ---has_many--->  | middleware_server_group | ---has_many---> | middleware_server |\r\n\r\nHere is how to setup the domain mode with the hawkular agent on the localhost:\r\n\r\n1. run C*\r\n2. run hawkular services\r\n3. download the agent installer (http://localhost:8080/hawkular/wildfly-agent/installer)\r\n4. download a vanilla WF10 (or EAP in the corresponding version)\r\n5. run the agent installer \r\n\r\n```bash\r\njava -jar hawkular-wildfly-agent-installer.jar --target-location=/home/jkremser/install/wf/ --target-config=/home/jkremser/install/wf/domain/configuration/host.xml --username=jdoe --password=password --enabled\r\n```\r\n\r\nI also run this, but @jmazzitelli told me it wasn't necessary:\r\n```bash\r\njava -jar hawkular-wildfly-agent-installer.jar --target-location=/home/jkremser/install/wf/ --target-config=/home/jkremser/install/wf/domain/configuration/domain.xml --username=jdoe --password=password --enabled\r\n```\r\n\r\n6. run the WF in the domain mode\r\n```bash\r\n./domain.sh -b 127.0.0.1 -Djboss.bind.address.management=127.0.0.1 -Djboss.socket.binding.port-offset=10000\r\n```\r\n\r\n7. If you run the hawkular-services w/ `-Dhawkular.log.inventory.rest.requests=DEBUG` option you should now see the incoming REST requests from the agent installed in the new WF server to the inventory.\r\n\r\n8. that's it, the hawkular services now contain info about an external WF, that is running in a domain mode. Now run the MiQ and add the hawkular services as a provider. To verify, that the domain and the server groups are there, you can run `rails c`, in the console do the refresh `reload!; EmsRefresh.refresh(ManageIQ::Providers::Hawkular::MiddlewareManager.first)` and list all the domains/server groups: `Middleware{Domain|ServerGroup}.all`\r\n\r\n@miq-bot add_labels enhancement, providers/hawkular, darga/no\r\ncc @abonas ","created_at":"2016-07-26T00:11:23Z","updated_at":"2016-08-03T12:55:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ebd438ea69d1e422c62c1233ce589b7de9ab146","assignee":{"login":"josejulio","id":3845764,"avatar_url":"https://avatars.githubusercontent.com/u/3845764?v=3","gravatar_id":"","url":"https://api.github.com/users/josejulio","html_url":"https://github.com/josejulio","followers_url":"https://api.github.com/users/josejulio/followers","following_url":"https://api.github.com/users/josejulio/following{/other_user}","gists_url":"https://api.github.com/users/josejulio/gists{/gist_id}","starred_url":"https://api.github.com/users/josejulio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josejulio/subscriptions","organizations_url":"https://api.github.com/users/josejulio/orgs","repos_url":"https://api.github.com/users/josejulio/repos","events_url":"https://api.github.com/users/josejulio/events{/privacy}","received_events_url":"https://api.github.com/users/josejulio/received_events","type":"User","site_admin":false},"assignees":[{"login":"josejulio","id":3845764,"avatar_url":"https://avatars.githubusercontent.com/u/3845764?v=3","gravatar_id":"","url":"https://api.github.com/users/josejulio","html_url":"https://github.com/josejulio","followers_url":"https://api.github.com/users/josejulio/followers","following_url":"https://api.github.com/users/josejulio/following{/other_user}","gists_url":"https://api.github.com/users/josejulio/gists{/gist_id}","starred_url":"https://api.github.com/users/josejulio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josejulio/subscriptions","organizations_url":"https://api.github.com/users/josejulio/orgs","repos_url":"https://api.github.com/users/josejulio/repos","events_url":"https://api.github.com/users/josejulio/events{/privacy}","received_events_url":"https://api.github.com/users/josejulio/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10048/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10048/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10048/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/abd28236f2197fdf49ec14cb663d52d34f5b6e5a","head":{"label":"Jiri-Kremser:domains-and-server-groups","ref":"domains-and-server-groups","sha":"abd28236f2197fdf49ec14cb663d52d34f5b6e5a","user":{"login":"Jiri-Kremser","id":535866,"avatar_url":"https://avatars.githubusercontent.com/u/535866?v=3","gravatar_id":"","url":"https://api.github.com/users/Jiri-Kremser","html_url":"https://github.com/Jiri-Kremser","followers_url":"https://api.github.com/users/Jiri-Kremser/followers","following_url":"https://api.github.com/users/Jiri-Kremser/following{/other_user}","gists_url":"https://api.github.com/users/Jiri-Kremser/gists{/gist_id}","starred_url":"https://api.github.com/users/Jiri-Kremser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jiri-Kremser/subscriptions","organizations_url":"https://api.github.com/users/Jiri-Kremser/orgs","repos_url":"https://api.github.com/users/Jiri-Kremser/repos","events_url":"https://api.github.com/users/Jiri-Kremser/events{/privacy}","received_events_url":"https://api.github.com/users/Jiri-Kremser/received_events","type":"User","site_admin":false},"repo":{"id":52444986,"name":"manageiq","full_name":"Jiri-Kremser/manageiq","owner":{"login":"Jiri-Kremser","id":535866,"avatar_url":"https://avatars.githubusercontent.com/u/535866?v=3","gravatar_id":"","url":"https://api.github.com/users/Jiri-Kremser","html_url":"https://github.com/Jiri-Kremser","followers_url":"https://api.github.com/users/Jiri-Kremser/followers","following_url":"https://api.github.com/users/Jiri-Kremser/following{/other_user}","gists_url":"https://api.github.com/users/Jiri-Kremser/gists{/gist_id}","starred_url":"https://api.github.com/users/Jiri-Kremser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jiri-Kremser/subscriptions","organizations_url":"https://api.github.com/users/Jiri-Kremser/orgs","repos_url":"https://api.github.com/users/Jiri-Kremser/repos","events_url":"https://api.github.com/users/Jiri-Kremser/events{/privacy}","received_events_url":"https://api.github.com/users/Jiri-Kremser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Jiri-Kremser/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/Jiri-Kremser/manageiq","forks_url":"https://api.github.com/repos/Jiri-Kremser/manageiq/forks","keys_url":"https://api.github.com/repos/Jiri-Kremser/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jiri-Kremser/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jiri-Kremser/manageiq/teams","hooks_url":"https://api.github.com/repos/Jiri-Kremser/manageiq/hooks","issue_events_url":"https://api.github.com/repos/Jiri-Kremser/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/Jiri-Kremser/manageiq/events","assignees_url":"https://api.github.com/repos/Jiri-Kremser/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/Jiri-Kremser/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/Jiri-Kremser/manageiq/tags","blobs_url":"https://api.github.com/repos/Jiri-Kremser/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jiri-Kremser/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jiri-Kremser/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jiri-Kremser/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jiri-Kremser/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/Jiri-Kremser/manageiq/languages","stargazers_url":"https://api.github.com/repos/Jiri-Kremser/manageiq/stargazers","contributors_url":"https://api.github.com/repos/Jiri-Kremser/manageiq/contributors","subscribers_url":"https://api.github.com/repos/Jiri-Kremser/manageiq/subscribers","subscription_url":"https://api.github.com/repos/Jiri-Kremser/manageiq/subscription","commits_url":"https://api.github.com/repos/Jiri-Kremser/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jiri-Kremser/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jiri-Kremser/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jiri-Kremser/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jiri-Kremser/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/Jiri-Kremser/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jiri-Kremser/manageiq/merges","archive_url":"https://api.github.com/repos/Jiri-Kremser/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jiri-Kremser/manageiq/downloads","issues_url":"https://api.github.com/repos/Jiri-Kremser/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/Jiri-Kremser/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/Jiri-Kremser/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/Jiri-Kremser/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jiri-Kremser/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/Jiri-Kremser/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/Jiri-Kremser/manageiq/deployments","created_at":"2016-02-24T13:37:41Z","updated_at":"2016-02-24T13:37:59Z","pushed_at":"2016-08-03T10:31:29Z","git_url":"git://github.com/Jiri-Kremser/manageiq.git","ssh_url":"git@github.com:Jiri-Kremser/manageiq.git","clone_url":"https://github.com/Jiri-Kremser/manageiq.git","svn_url":"https://github.com/Jiri-Kremser/manageiq","homepage":"manageiq.org","size":141688,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"69664a529eca2cb47d5e5f604225b61c962cb614","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Open-Source Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq/deployments","created_at":"2014-06-13T02:31:26Z","updated_at":"2016-08-02T04:31:15Z","pushed_at":"2016-08-03T12:47:10Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":190950,"stargazers_count":300,"watchers_count":300,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":332,"mirror_url":null,"open_issues_count":731,"forks":332,"open_issues":731,"watchers":300,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10048"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/10048"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/10048"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/10048/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10048/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10048/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/abd28236f2197fdf49ec14cb663d52d34f5b6e5a"}}}}
{"actor":{"display_login":"Jiri-Kremser"}}