{"action":"created","issue":{"url":"https://api.github.com/repos/Molmed/clarity-ext/issues/25","repository_url":"https://api.github.com/repos/Molmed/clarity-ext","labels_url":"https://api.github.com/repos/Molmed/clarity-ext/issues/25/labels{/name}","comments_url":"https://api.github.com/repos/Molmed/clarity-ext/issues/25/comments","events_url":"https://api.github.com/repos/Molmed/clarity-ext/issues/25/events","html_url":"https://github.com/Molmed/clarity-ext/pull/25","id":173765388,"number":25,"title":"Major refactoring","user":{"login":"withrocks","id":800390,"avatar_url":"https://avatars.githubusercontent.com/u/800390?v=3","gravatar_id":"","url":"https://api.github.com/users/withrocks","html_url":"https://github.com/withrocks","followers_url":"https://api.github.com/users/withrocks/followers","following_url":"https://api.github.com/users/withrocks/following{/other_user}","gists_url":"https://api.github.com/users/withrocks/gists{/gist_id}","starred_url":"https://api.github.com/users/withrocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/withrocks/subscriptions","organizations_url":"https://api.github.com/users/withrocks/orgs","repos_url":"https://api.github.com/users/withrocks/repos","events_url":"https://api.github.com/users/withrocks/events{/privacy}","received_events_url":"https://api.github.com/users/withrocks/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-29T12:42:05Z","updated_at":"2016-08-30T12:15:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Molmed/clarity-ext/pulls/25","html_url":"https://github.com/Molmed/clarity-ext/pull/25","diff_url":"https://github.com/Molmed/clarity-ext/pull/25.diff","patch_url":"https://github.com/Molmed/clarity-ext/pull/25.patch"},"body":"- Cleanup and refactoring (tech debt form the prototype stage.)\r\n- Remove logic from the ExtensionContext into different services. This\r\n  allows us to only test the services.\r\n- Move several files around, e.g. ResultFile to domain/result_file.py\r\n- Factory method for the ExtensionContext.\r\n- Create a repository for local and remote files, which can be\r\n  injected into services\r\n- Major changes to the StepRepository. It now returns artifacts in pairs\r\n  (input, output) rather than one list of inputs and another of outputs.\r\n- Add the ArtifactService, which filters data from the step repository.\r\n  Services are designed to be tested while only their underlying repos\r\n  should be mocked. This way mocking is limited data only and unit tests\r\n  will cover most of the logic.\r\n- Move code to the new FileService. This handles downloading files and\r\n  parsing them to XML. Some of this code was in the ExtensionContext\r\n  before.\r\n- Add tests, coverage now at approx 92% when integration tests are also run\r\n- Add a Jupyter notebook for a quick overview of how things work together."},"comment":{"url":"https://api.github.com/repos/Molmed/clarity-ext/issues/comments/243419729","html_url":"https://github.com/Molmed/clarity-ext/pull/25#issuecomment-243419729","issue_url":"https://api.github.com/repos/Molmed/clarity-ext/issues/25","id":243419729,"user":{"login":"GitEdvard","id":12558805,"avatar_url":"https://avatars.githubusercontent.com/u/12558805?v=3","gravatar_id":"","url":"https://api.github.com/users/GitEdvard","html_url":"https://github.com/GitEdvard","followers_url":"https://api.github.com/users/GitEdvard/followers","following_url":"https://api.github.com/users/GitEdvard/following{/other_user}","gists_url":"https://api.github.com/users/GitEdvard/gists{/gist_id}","starred_url":"https://api.github.com/users/GitEdvard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GitEdvard/subscriptions","organizations_url":"https://api.github.com/users/GitEdvard/orgs","repos_url":"https://api.github.com/users/GitEdvard/repos","events_url":"https://api.github.com/users/GitEdvard/events{/privacy}","received_events_url":"https://api.github.com/users/GitEdvard/received_events","type":"User","site_admin":false},"created_at":"2016-08-30T12:15:11Z","updated_at":"2016-08-30T12:15:11Z","body":"Ok"}}
{"actor":{"display_login":"GitEdvard"}}