{"action":"created","comment":{"url":"https://api.github.com/repos/premake/premake-core/pulls/comments/70209692","id":70209692,"diff_hunk":"@@ -49,23 +49,33 @@\n \t\t\t-- convert the token into a function to execute\n \t\t\tlocal func, err = loadstring(\"return \" .. token)\n \t\t\tif not func then\n-\t\t\t\treturn nil, err\n+\t\t\t\treturn nil, \"load error: \" .. err\n \t\t\tend\n \n \t\t\t-- give the function access to the project objects\n \t\t\tsetfenv(func, e)\n \n \t\t\t-- run it and get the result\n-\t\t\tlocal result = func() or \"\"\n+\t\t\tlocal success, result = pcall(func)","path":"src/base/detoken.lua","position":13,"original_position":13,"commit_id":"22bccd94000e9caae0c295544fbc88a1ed052891","original_commit_id":"22bccd94000e9caae0c295544fbc88a1ed052891","user":{"login":"TurkeyMan","id":1146706,"avatar_url":"https://avatars.githubusercontent.com/u/1146706?v=3","gravatar_id":"","url":"https://api.github.com/users/TurkeyMan","html_url":"https://github.com/TurkeyMan","followers_url":"https://api.github.com/users/TurkeyMan/followers","following_url":"https://api.github.com/users/TurkeyMan/following{/other_user}","gists_url":"https://api.github.com/users/TurkeyMan/gists{/gist_id}","starred_url":"https://api.github.com/users/TurkeyMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TurkeyMan/subscriptions","organizations_url":"https://api.github.com/users/TurkeyMan/orgs","repos_url":"https://api.github.com/users/TurkeyMan/repos","events_url":"https://api.github.com/users/TurkeyMan/events{/privacy}","received_events_url":"https://api.github.com/users/TurkeyMan/received_events","type":"User","site_admin":false},"body":"This change in behaviour; `result` is no longer coerced to `\"\"` if `func()` returns `nil`, seem to cause problems...","created_at":"2016-07-11T07:05:39Z","updated_at":"2016-07-11T07:05:39Z","html_url":"https://github.com/premake/premake-core/pull/304#discussion_r70209692","pull_request_url":"https://api.github.com/repos/premake/premake-core/pulls/304","_links":{"self":{"href":"https://api.github.com/repos/premake/premake-core/pulls/comments/70209692"},"html":{"href":"https://github.com/premake/premake-core/pull/304#discussion_r70209692"},"pull_request":{"href":"https://api.github.com/repos/premake/premake-core/pulls/304"}}},"pull_request":{"url":"https://api.github.com/repos/premake/premake-core/pulls/304","id":47063851,"html_url":"https://github.com/premake/premake-core/pull/304","diff_url":"https://github.com/premake/premake-core/pull/304.diff","patch_url":"https://github.com/premake/premake-core/pull/304.patch","issue_url":"https://api.github.com/repos/premake/premake-core/issues/304","number":304,"state":"closed","locked":false,"title":"More fixes for detoken.","user":{"login":"tvandijck","id":451515,"avatar_url":"https://avatars.githubusercontent.com/u/451515?v=3","gravatar_id":"","url":"https://api.github.com/users/tvandijck","html_url":"https://github.com/tvandijck","followers_url":"https://api.github.com/users/tvandijck/followers","following_url":"https://api.github.com/users/tvandijck/following{/other_user}","gists_url":"https://api.github.com/users/tvandijck/gists{/gist_id}","starred_url":"https://api.github.com/users/tvandijck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tvandijck/subscriptions","organizations_url":"https://api.github.com/users/tvandijck/orgs","repos_url":"https://api.github.com/users/tvandijck/repos","events_url":"https://api.github.com/users/tvandijck/events{/privacy}","received_events_url":"https://api.github.com/users/tvandijck/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-07T18:28:20Z","updated_at":"2016-07-11T07:05:39Z","closed_at":"2015-12-15T17:30:15Z","merged_at":"2015-12-15T17:30:15Z","merge_commit_sha":"864919fa0d6282f0e4aa079acd670d930d985fde","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/premake/premake-core/pulls/304/commits","review_comments_url":"https://api.github.com/repos/premake/premake-core/pulls/304/comments","review_comment_url":"https://api.github.com/repos/premake/premake-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/premake/premake-core/issues/304/comments","statuses_url":"https://api.github.com/repos/premake/premake-core/statuses/22bccd94000e9caae0c295544fbc88a1ed052891","head":{"label":"Blizzard:more-detoken-fixes","ref":"more-detoken-fixes","sha":"22bccd94000e9caae0c295544fbc88a1ed052891","user":{"login":"Blizzard","id":483032,"avatar_url":"https://avatars.githubusercontent.com/u/483032?v=3","gravatar_id":"","url":"https://api.github.com/users/Blizzard","html_url":"https://github.com/Blizzard","followers_url":"https://api.github.com/users/Blizzard/followers","following_url":"https://api.github.com/users/Blizzard/following{/other_user}","gists_url":"https://api.github.com/users/Blizzard/gists{/gist_id}","starred_url":"https://api.github.com/users/Blizzard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blizzard/subscriptions","organizations_url":"https://api.github.com/users/Blizzard/orgs","repos_url":"https://api.github.com/users/Blizzard/repos","events_url":"https://api.github.com/users/Blizzard/events{/privacy}","received_events_url":"https://api.github.com/users/Blizzard/received_events","type":"Organization","site_admin":false},"repo":{"id":32937808,"name":"premake-core","full_name":"Blizzard/premake-core","owner":{"login":"Blizzard","id":483032,"avatar_url":"https://avatars.githubusercontent.com/u/483032?v=3","gravatar_id":"","url":"https://api.github.com/users/Blizzard","html_url":"https://github.com/Blizzard","followers_url":"https://api.github.com/users/Blizzard/followers","following_url":"https://api.github.com/users/Blizzard/following{/other_user}","gists_url":"https://api.github.com/users/Blizzard/gists{/gist_id}","starred_url":"https://api.github.com/users/Blizzard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blizzard/subscriptions","organizations_url":"https://api.github.com/users/Blizzard/orgs","repos_url":"https://api.github.com/users/Blizzard/repos","events_url":"https://api.github.com/users/Blizzard/events{/privacy}","received_events_url":"https://api.github.com/users/Blizzard/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Blizzard/premake-core","description":"Premake","fork":true,"url":"https://api.github.com/repos/Blizzard/premake-core","forks_url":"https://api.github.com/repos/Blizzard/premake-core/forks","keys_url":"https://api.github.com/repos/Blizzard/premake-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Blizzard/premake-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Blizzard/premake-core/teams","hooks_url":"https://api.github.com/repos/Blizzard/premake-core/hooks","issue_events_url":"https://api.github.com/repos/Blizzard/premake-core/issues/events{/number}","events_url":"https://api.github.com/repos/Blizzard/premake-core/events","assignees_url":"https://api.github.com/repos/Blizzard/premake-core/assignees{/user}","branches_url":"https://api.github.com/repos/Blizzard/premake-core/branches{/branch}","tags_url":"https://api.github.com/repos/Blizzard/premake-core/tags","blobs_url":"https://api.github.com/repos/Blizzard/premake-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Blizzard/premake-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Blizzard/premake-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Blizzard/premake-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Blizzard/premake-core/statuses/{sha}","languages_url":"https://api.github.com/repos/Blizzard/premake-core/languages","stargazers_url":"https://api.github.com/repos/Blizzard/premake-core/stargazers","contributors_url":"https://api.github.com/repos/Blizzard/premake-core/contributors","subscribers_url":"https://api.github.com/repos/Blizzard/premake-core/subscribers","subscription_url":"https://api.github.com/repos/Blizzard/premake-core/subscription","commits_url":"https://api.github.com/repos/Blizzard/premake-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Blizzard/premake-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Blizzard/premake-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Blizzard/premake-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Blizzard/premake-core/contents/{+path}","compare_url":"https://api.github.com/repos/Blizzard/premake-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Blizzard/premake-core/merges","archive_url":"https://api.github.com/repos/Blizzard/premake-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Blizzard/premake-core/downloads","issues_url":"https://api.github.com/repos/Blizzard/premake-core/issues{/number}","pulls_url":"https://api.github.com/repos/Blizzard/premake-core/pulls{/number}","milestones_url":"https://api.github.com/repos/Blizzard/premake-core/milestones{/number}","notifications_url":"https://api.github.com/repos/Blizzard/premake-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Blizzard/premake-core/labels{/name}","releases_url":"https://api.github.com/repos/Blizzard/premake-core/releases{/id}","deployments_url":"https://api.github.com/repos/Blizzard/premake-core/deployments","created_at":"2015-03-26T16:07:33Z","updated_at":"2016-06-05T02:02:03Z","pushed_at":"2016-06-22T19:12:58Z","git_url":"git://github.com/Blizzard/premake-core.git","ssh_url":"git@github.com:Blizzard/premake-core.git","clone_url":"https://github.com/Blizzard/premake-core.git","svn_url":"https://github.com/Blizzard/premake-core","homepage":null,"size":23829,"stargazers_count":10,"watchers_count":10,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":10,"default_branch":"master"}},"base":{"label":"premake:master","ref":"master","sha":"9f9353eb271c1ac13a25a79954d848647063a252","user":{"login":"premake","id":11135954,"avatar_url":"https://avatars.githubusercontent.com/u/11135954?v=3","gravatar_id":"","url":"https://api.github.com/users/premake","html_url":"https://github.com/premake","followers_url":"https://api.github.com/users/premake/followers","following_url":"https://api.github.com/users/premake/following{/other_user}","gists_url":"https://api.github.com/users/premake/gists{/gist_id}","starred_url":"https://api.github.com/users/premake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/premake/subscriptions","organizations_url":"https://api.github.com/users/premake/orgs","repos_url":"https://api.github.com/users/premake/repos","events_url":"https://api.github.com/users/premake/events{/privacy}","received_events_url":"https://api.github.com/users/premake/received_events","type":"Organization","site_admin":false},"repo":{"id":32634405,"name":"premake-core","full_name":"premake/premake-core","owner":{"login":"premake","id":11135954,"avatar_url":"https://avatars.githubusercontent.com/u/11135954?v=3","gravatar_id":"","url":"https://api.github.com/users/premake","html_url":"https://github.com/premake","followers_url":"https://api.github.com/users/premake/followers","following_url":"https://api.github.com/users/premake/following{/other_user}","gists_url":"https://api.github.com/users/premake/gists{/gist_id}","starred_url":"https://api.github.com/users/premake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/premake/subscriptions","organizations_url":"https://api.github.com/users/premake/orgs","repos_url":"https://api.github.com/users/premake/repos","events_url":"https://api.github.com/users/premake/events{/privacy}","received_events_url":"https://api.github.com/users/premake/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/premake/premake-core","description":"Premake","fork":false,"url":"https://api.github.com/repos/premake/premake-core","forks_url":"https://api.github.com/repos/premake/premake-core/forks","keys_url":"https://api.github.com/repos/premake/premake-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/premake/premake-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/premake/premake-core/teams","hooks_url":"https://api.github.com/repos/premake/premake-core/hooks","issue_events_url":"https://api.github.com/repos/premake/premake-core/issues/events{/number}","events_url":"https://api.github.com/repos/premake/premake-core/events","assignees_url":"https://api.github.com/repos/premake/premake-core/assignees{/user}","branches_url":"https://api.github.com/repos/premake/premake-core/branches{/branch}","tags_url":"https://api.github.com/repos/premake/premake-core/tags","blobs_url":"https://api.github.com/repos/premake/premake-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/premake/premake-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/premake/premake-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/premake/premake-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/premake/premake-core/statuses/{sha}","languages_url":"https://api.github.com/repos/premake/premake-core/languages","stargazers_url":"https://api.github.com/repos/premake/premake-core/stargazers","contributors_url":"https://api.github.com/repos/premake/premake-core/contributors","subscribers_url":"https://api.github.com/repos/premake/premake-core/subscribers","subscription_url":"https://api.github.com/repos/premake/premake-core/subscription","commits_url":"https://api.github.com/repos/premake/premake-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/premake/premake-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/premake/premake-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/premake/premake-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/premake/premake-core/contents/{+path}","compare_url":"https://api.github.com/repos/premake/premake-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/premake/premake-core/merges","archive_url":"https://api.github.com/repos/premake/premake-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/premake/premake-core/downloads","issues_url":"https://api.github.com/repos/premake/premake-core/issues{/number}","pulls_url":"https://api.github.com/repos/premake/premake-core/pulls{/number}","milestones_url":"https://api.github.com/repos/premake/premake-core/milestones{/number}","notifications_url":"https://api.github.com/repos/premake/premake-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/premake/premake-core/labels{/name}","releases_url":"https://api.github.com/repos/premake/premake-core/releases{/id}","deployments_url":"https://api.github.com/repos/premake/premake-core/deployments","created_at":"2015-03-21T14:08:15Z","updated_at":"2016-07-09T13:59:39Z","pushed_at":"2016-07-08T04:37:14Z","git_url":"git://github.com/premake/premake-core.git","ssh_url":"git@github.com:premake/premake-core.git","clone_url":"https://github.com/premake/premake-core.git","svn_url":"https://github.com/premake/premake-core","homepage":null,"size":26551,"stargazers_count":422,"watchers_count":422,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":121,"mirror_url":null,"open_issues_count":83,"forks":121,"open_issues":83,"watchers":422,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/premake/premake-core/pulls/304"},"html":{"href":"https://github.com/premake/premake-core/pull/304"},"issue":{"href":"https://api.github.com/repos/premake/premake-core/issues/304"},"comments":{"href":"https://api.github.com/repos/premake/premake-core/issues/304/comments"},"review_comments":{"href":"https://api.github.com/repos/premake/premake-core/pulls/304/comments"},"review_comment":{"href":"https://api.github.com/repos/premake/premake-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/premake/premake-core/pulls/304/commits"},"statuses":{"href":"https://api.github.com/repos/premake/premake-core/statuses/22bccd94000e9caae0c295544fbc88a1ed052891"}}}}
{"actor":{"display_login":"TurkeyMan"}}