{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-beam/pulls/comments/90065242","pull_request_review_id":10590364,"id":90065242,"diff_hunk":"@@ -243,4 +244,22 @@ public String apply(String from) {\n     expectedException.expectMessage(\"Not called from a runtime context\");\n     nvp.get();\n   }\n+\n+  private static class NonSerializable {}\n+\n+  private static class NonSerializableTranslator\n+      implements SerializableFunction<String, NonSerializable> {\n+    @Override\n+    public NonSerializable apply(String from) {\n+      return new NonSerializable();\n+    }\n+  }\n+\n+  @Test\n+  public void testNestedValueProviderSerialize() throws Exception {\n+    ValueProvider<String> rvp = StaticValueProvider.of(\"foo\");","path":"sdks/java/core/src/test/java/org/apache/beam/sdk/options/ValueProviderTest.java","position":25,"original_position":25,"commit_id":"29932b2fa1798df16d7114ed3dd915e0dcf50d93","original_commit_id":"29932b2fa1798df16d7114ed3dd915e0dcf50d93","user":{"login":"dhalperi","id":526415,"avatar_url":"https://avatars.githubusercontent.com/u/526415?v=3","gravatar_id":"","url":"https://api.github.com/users/dhalperi","html_url":"https://github.com/dhalperi","followers_url":"https://api.github.com/users/dhalperi/followers","following_url":"https://api.github.com/users/dhalperi/following{/other_user}","gists_url":"https://api.github.com/users/dhalperi/gists{/gist_id}","starred_url":"https://api.github.com/users/dhalperi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhalperi/subscriptions","organizations_url":"https://api.github.com/users/dhalperi/orgs","repos_url":"https://api.github.com/users/dhalperi/repos","events_url":"https://api.github.com/users/dhalperi/events{/privacy}","received_events_url":"https://api.github.com/users/dhalperi/received_events","type":"User","site_admin":false},"body":"maybe rename to `svp` and/or inline at L262?","created_at":"2016-11-29T17:50:39Z","updated_at":"2016-11-29T17:50:39Z","html_url":"https://github.com/apache/incubator-beam/pull/1452#discussion_r90065242","pull_request_url":"https://api.github.com/repos/apache/incubator-beam/pulls/1452","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/comments/90065242"},"html":{"href":"https://github.com/apache/incubator-beam/pull/1452#discussion_r90065242"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1452"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-beam/pulls/1452","id":95741688,"html_url":"https://github.com/apache/incubator-beam/pull/1452","diff_url":"https://github.com/apache/incubator-beam/pull/1452.diff","patch_url":"https://github.com/apache/incubator-beam/pull/1452.patch","issue_url":"https://api.github.com/repos/apache/incubator-beam/issues/1452","number":1452,"state":"open","locked":false,"title":"[BEAM-551] Add a test to demonstrate NVP serialization","user":{"login":"sammcveety","id":2364801,"avatar_url":"https://avatars.githubusercontent.com/u/2364801?v=3","gravatar_id":"","url":"https://api.github.com/users/sammcveety","html_url":"https://github.com/sammcveety","followers_url":"https://api.github.com/users/sammcveety/followers","following_url":"https://api.github.com/users/sammcveety/following{/other_user}","gists_url":"https://api.github.com/users/sammcveety/gists{/gist_id}","starred_url":"https://api.github.com/users/sammcveety/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sammcveety/subscriptions","organizations_url":"https://api.github.com/users/sammcveety/orgs","repos_url":"https://api.github.com/users/sammcveety/repos","events_url":"https://api.github.com/users/sammcveety/events{/privacy}","received_events_url":"https://api.github.com/users/sammcveety/received_events","type":"User","site_admin":false},"body":"R: @dhalperi \r\n","created_at":"2016-11-29T17:48:06Z","updated_at":"2016-11-29T17:50:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"71832c72b0356d6922a322ead85474e31a6266c4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-beam/pulls/1452/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-beam/pulls/1452/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-beam/issues/1452/comments","statuses_url":"https://api.github.com/repos/apache/incubator-beam/statuses/29932b2fa1798df16d7114ed3dd915e0dcf50d93","head":{"label":"sammcveety:sgmc/nvp_repro","ref":"sgmc/nvp_repro","sha":"29932b2fa1798df16d7114ed3dd915e0dcf50d93","user":{"login":"sammcveety","id":2364801,"avatar_url":"https://avatars.githubusercontent.com/u/2364801?v=3","gravatar_id":"","url":"https://api.github.com/users/sammcveety","html_url":"https://github.com/sammcveety","followers_url":"https://api.github.com/users/sammcveety/followers","following_url":"https://api.github.com/users/sammcveety/following{/other_user}","gists_url":"https://api.github.com/users/sammcveety/gists{/gist_id}","starred_url":"https://api.github.com/users/sammcveety/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sammcveety/subscriptions","organizations_url":"https://api.github.com/users/sammcveety/orgs","repos_url":"https://api.github.com/users/sammcveety/repos","events_url":"https://api.github.com/users/sammcveety/events{/privacy}","received_events_url":"https://api.github.com/users/sammcveety/received_events","type":"User","site_admin":false},"repo":{"id":63892406,"name":"incubator-beam","full_name":"sammcveety/incubator-beam","owner":{"login":"sammcveety","id":2364801,"avatar_url":"https://avatars.githubusercontent.com/u/2364801?v=3","gravatar_id":"","url":"https://api.github.com/users/sammcveety","html_url":"https://github.com/sammcveety","followers_url":"https://api.github.com/users/sammcveety/followers","following_url":"https://api.github.com/users/sammcveety/following{/other_user}","gists_url":"https://api.github.com/users/sammcveety/gists{/gist_id}","starred_url":"https://api.github.com/users/sammcveety/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sammcveety/subscriptions","organizations_url":"https://api.github.com/users/sammcveety/orgs","repos_url":"https://api.github.com/users/sammcveety/repos","events_url":"https://api.github.com/users/sammcveety/events{/privacy}","received_events_url":"https://api.github.com/users/sammcveety/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sammcveety/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":true,"url":"https://api.github.com/repos/sammcveety/incubator-beam","forks_url":"https://api.github.com/repos/sammcveety/incubator-beam/forks","keys_url":"https://api.github.com/repos/sammcveety/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sammcveety/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sammcveety/incubator-beam/teams","hooks_url":"https://api.github.com/repos/sammcveety/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/sammcveety/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/sammcveety/incubator-beam/events","assignees_url":"https://api.github.com/repos/sammcveety/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/sammcveety/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/sammcveety/incubator-beam/tags","blobs_url":"https://api.github.com/repos/sammcveety/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sammcveety/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sammcveety/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/sammcveety/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sammcveety/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/sammcveety/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/sammcveety/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/sammcveety/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/sammcveety/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/sammcveety/incubator-beam/subscription","commits_url":"https://api.github.com/repos/sammcveety/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/sammcveety/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/sammcveety/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/sammcveety/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/sammcveety/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/sammcveety/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sammcveety/incubator-beam/merges","archive_url":"https://api.github.com/repos/sammcveety/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sammcveety/incubator-beam/downloads","issues_url":"https://api.github.com/repos/sammcveety/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/sammcveety/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/sammcveety/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/sammcveety/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sammcveety/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/sammcveety/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/sammcveety/incubator-beam/deployments","created_at":"2016-07-21T18:17:58Z","updated_at":"2016-07-21T18:18:03Z","pushed_at":"2016-11-29T17:45:27Z","git_url":"git://github.com/sammcveety/incubator-beam.git","ssh_url":"git@github.com:sammcveety/incubator-beam.git","clone_url":"https://github.com/sammcveety/incubator-beam.git","svn_url":"https://github.com/sammcveety/incubator-beam","homepage":null,"size":23894,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"1716bfc4906b97bae434d9740a0af172c91f5e10","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50904245,"name":"incubator-beam","full_name":"apache/incubator-beam","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-beam","forks_url":"https://api.github.com/repos/apache/incubator-beam/forks","keys_url":"https://api.github.com/repos/apache/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-beam/teams","hooks_url":"https://api.github.com/repos/apache/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-beam/events","assignees_url":"https://api.github.com/repos/apache/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-beam/tags","blobs_url":"https://api.github.com/repos/apache/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-beam/subscription","commits_url":"https://api.github.com/repos/apache/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-beam/merges","archive_url":"https://api.github.com/repos/apache/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-beam/downloads","issues_url":"https://api.github.com/repos/apache/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-beam/deployments","created_at":"2016-02-02T08:00:06Z","updated_at":"2016-11-28T13:17:04Z","pushed_at":"2016-11-29T17:49:48Z","git_url":"git://github.com/apache/incubator-beam.git","ssh_url":"git@github.com:apache/incubator-beam.git","clone_url":"https://github.com/apache/incubator-beam.git","svn_url":"https://github.com/apache/incubator-beam","homepage":null,"size":36436,"stargazers_count":501,"watchers_count":501,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":297,"mirror_url":"git://git.apache.org/incubator-beam.git","open_issues_count":63,"forks":297,"open_issues":63,"watchers":501,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1452"},"html":{"href":"https://github.com/apache/incubator-beam/pull/1452"},"issue":{"href":"https://api.github.com/repos/apache/incubator-beam/issues/1452"},"comments":{"href":"https://api.github.com/repos/apache/incubator-beam/issues/1452/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1452/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1452/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-beam/statuses/29932b2fa1798df16d7114ed3dd915e0dcf50d93"}}}}
{"actor":{"display_login":"dhalperi"}}