{"action":"created","issue":{"url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/2633","repository_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2","labels_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/2633/labels{/name}","comments_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/2633/comments","events_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/2633/events","html_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/2633","id":190048299,"number":2633,"title":"Refactored AEConfig","user":{"login":"yueh","id":151949,"avatar_url":"https://avatars.githubusercontent.com/u/151949?v=3","gravatar_id":"","url":"https://api.github.com/users/yueh","html_url":"https://github.com/yueh","followers_url":"https://api.github.com/users/yueh/followers","following_url":"https://api.github.com/users/yueh/following{/other_user}","gists_url":"https://api.github.com/users/yueh/gists{/gist_id}","starred_url":"https://api.github.com/users/yueh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yueh/subscriptions","organizations_url":"https://api.github.com/users/yueh/orgs","repos_url":"https://api.github.com/users/yueh/repos","events_url":"https://api.github.com/users/yueh/events{/privacy}","received_events_url":"https://api.github.com/users/yueh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-17T13:35:20Z","updated_at":"2016-11-17T15:20:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/2633","html_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/2633","diff_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/2633.diff","patch_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/2633.patch"},"body":"**Tentative**"},"comment":{"url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/comments/261274803","html_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/2633#issuecomment-261274803","issue_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/2633","id":261274803,"user":{"login":"orod-org","id":14347709,"avatar_url":"https://avatars.githubusercontent.com/u/14347709?v=3","gravatar_id":"","url":"https://api.github.com/users/orod-org","html_url":"https://github.com/orod-org","followers_url":"https://api.github.com/users/orod-org/followers","following_url":"https://api.github.com/users/orod-org/following{/other_user}","gists_url":"https://api.github.com/users/orod-org/gists{/gist_id}","starred_url":"https://api.github.com/users/orod-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orod-org/subscriptions","organizations_url":"https://api.github.com/users/orod-org/orgs","repos_url":"https://api.github.com/users/orod-org/repos","events_url":"https://api.github.com/users/orod-org/events{/privacy}","received_events_url":"https://api.github.com/users/orod-org/received_events","type":"User","site_admin":false},"created_at":"2016-11-17T15:20:27Z","updated_at":"2016-11-17T15:20:27Z","body":"SonarQube analysis reported 114 issues\n* ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) 74 major\n* ![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) 29 minor\n* ![INFO](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-info.png) 11 info\n\nWatch the comments in this conversation to review them.\n\n#### Top 10 extra issues\n\nNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:\n\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [BlockQuartzFixture.java#L65](https://github.com/AppliedEnergistics/Applied-Energistics-2/blob/3dbba31fc8192810ac43b9cb05ad7b850cb4f7ee/src/main/java/appeng/block/misc/BlockQuartzFixture.java#L65): Method new appeng.block.misc.BlockQuartzFixture() needlessly boxes a boolean constant [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonar.orod.org/coding_rules#rule_key=fb-contrib%3ANAB_NEEDLESS_BOOLEAN_CONSTANT_CONVERSION)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [BlockQuartzGrowthAccelerator.java#L56](https://github.com/AppliedEnergistics/Applied-Energistics-2/blob/3dbba31fc8192810ac43b9cb05ad7b850cb4f7ee/src/main/java/appeng/block/misc/BlockQuartzGrowthAccelerator.java#L56): Method new appeng.block.misc.BlockQuartzGrowthAccelerator() needlessly boxes a boolean constant [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonar.orod.org/coding_rules#rule_key=fb-contrib%3ANAB_NEEDLESS_BOOLEAN_CONSTANT_CONVERSION)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [BlockQuartzGrowthAccelerator.java#L139](https://github.com/AppliedEnergistics/Applied-Energistics-2/blob/3dbba31fc8192810ac43b9cb05ad7b850cb4f7ee/src/main/java/appeng/block/misc/BlockQuartzGrowthAccelerator.java#L139): Null passed for non-null parameter of net.minecraft.world.World.getBlockState(BlockPos) in appeng.block.misc.BlockQuartzGrowthAccelerator.randomDisplayTick(IBlockState, World, BlockPos, Random) [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonar.orod.org/coding_rules#rule_key=findbugs%3ANP_NULL_PARAM_DEREF)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [BlockVibrationChamber.java#L58](https://github.com/AppliedEnergistics/Applied-Energistics-2/blob/3dbba31fc8192810ac43b9cb05ad7b850cb4f7ee/src/main/java/appeng/block/misc/BlockVibrationChamber.java#L58): Method new appeng.block.misc.BlockVibrationChamber() needlessly boxes a boolean constant [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonar.orod.org/coding_rules#rule_key=fb-contrib%3ANAB_NEEDLESS_BOOLEAN_CONSTANT_CONVERSION)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [ClientHelper.java#L85](https://github.com/AppliedEnergistics/Applied-Energistics-2/blob/3dbba31fc8192810ac43b9cb05ad7b850cb4f7ee/src/main/java/appeng/client/ClientHelper.java#L85): Method appeng.client.ClientHelper.preinit() orders expressions in a conditional in a sub optimal way [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonar.orod.org/coding_rules#rule_key=fb-contrib%3ASEO_SUBOPTIMAL_EXPRESSION_ORDER)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [AEBaseGui.java#L525](https://github.com/AppliedEnergistics/Applied-Energistics-2/blob/3dbba31fc8192810ac43b9cb05ad7b850cb4f7ee/src/main/java/appeng/client/gui/AEBaseGui.java#L525): Method appeng.client.gui.AEBaseGui.handleMouseClick(Slot, int, int, ClickType) orders expressions in a conditional in a sub optimal way [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonar.orod.org/coding_rules#rule_key=fb-contrib%3ASEO_SUBOPTIMAL_EXPRESSION_ORDER)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [AEBaseGui.java#L749](https://github.com/AppliedEnergistics/Applied-Energistics-2/blob/3dbba31fc8192810ac43b9cb05ad7b850cb4f7ee/src/main/java/appeng/client/gui/AEBaseGui.java#L749): Remove this silly call to \"Math.floor\" [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonar.orod.org/coding_rules#rule_key=squid%3AS2185)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [GuiCellWorkbench.java#L88](https://github.com/AppliedEnergistics/Applied-Energistics-2/blob/3dbba31fc8192810ac43b9cb05ad7b850cb4f7ee/src/main/java/appeng/client/gui/implementations/GuiCellWorkbench.java#L88): Method appeng.client.gui.implementations.GuiCellWorkbench.drawBG(int, int, int, int) appears to call the same method on the same object redundantly [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonar.orod.org/coding_rules#rule_key=fb-contrib%3APRMC_POSSIBLY_REDUNDANT_METHOD_CALLS)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [GuiCellWorkbench.java#L96](https://github.com/AppliedEnergistics/Applied-Energistics-2/blob/3dbba31fc8192810ac43b9cb05ad7b850cb4f7ee/src/main/java/appeng/client/gui/implementations/GuiCellWorkbench.java#L96): Method appeng.client.gui.implementations.GuiCellWorkbench.drawBG(int, int, int, int) appears to call the same method on the same object redundantly [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonar.orod.org/coding_rules#rule_key=fb-contrib%3APRMC_POSSIBLY_REDUNDANT_METHOD_CALLS)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [GuiCellWorkbench.java#L145](https://github.com/AppliedEnergistics/Applied-Energistics-2/blob/3dbba31fc8192810ac43b9cb05ad7b850cb4f7ee/src/main/java/appeng/client/gui/implementations/GuiCellWorkbench.java#L145): Method appeng.client.gui.implementations.GuiCellWorkbench.handleButtonVisibility() appears to call the same method on the same object redundantly [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonar.orod.org/coding_rules#rule_key=fb-contrib%3APRMC_POSSIBLY_REDUNDANT_METHOD_CALLS)\n"}}
{"actor":{"display_login":"orod-org"}}