{"action":"created","comment":{"url":"https://api.github.com/repos/ansible/ansible/pulls/comments/79639725","id":79639725,"diff_hunk":"@@ -32,6 +32,7 @@ def __init__(self):\n         self.super_ref.__init__()\n         self.last_task = None\n         self.shown_title = False\n+        self.diff = False","path":"lib/ansible/plugins/callback/actionable.py","position":4,"original_position":4,"commit_id":"049bc2eec7c317a646bb6e391f5bfcd2664686f6","original_commit_id":"049bc2eec7c317a646bb6e391f5bfcd2664686f6","user":{"login":"towolf","id":345210,"avatar_url":"https://avatars.githubusercontent.com/u/345210?v=3","gravatar_id":"","url":"https://api.github.com/users/towolf","html_url":"https://github.com/towolf","followers_url":"https://api.github.com/users/towolf/followers","following_url":"https://api.github.com/users/towolf/following{/other_user}","gists_url":"https://api.github.com/users/towolf/gists{/gist_id}","starred_url":"https://api.github.com/users/towolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/towolf/subscriptions","organizations_url":"https://api.github.com/users/towolf/orgs","repos_url":"https://api.github.com/users/towolf/repos","events_url":"https://api.github.com/users/towolf/events{/privacy}","received_events_url":"https://api.github.com/users/towolf/received_events","type":"User","site_admin":false},"body":"Not entirely sure, what you mean by that :confused: \r\n\r\nI added the `self.diff` locally to override handling of diffs in this particular callback.\r\n\r\nAre you proposing an entirely different and better fix?","created_at":"2016-09-20T15:30:12Z","updated_at":"2016-09-20T15:30:23Z","html_url":"https://github.com/ansible/ansible/pull/17459#discussion_r79639725","pull_request_url":"https://api.github.com/repos/ansible/ansible/pulls/17459","_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments/79639725"},"html":{"href":"https://github.com/ansible/ansible/pull/17459#discussion_r79639725"},"pull_request":{"href":"https://api.github.com/repos/ansible/ansible/pulls/17459"}}},"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/17459","id":84474024,"html_url":"https://github.com/ansible/ansible/pull/17459","diff_url":"https://github.com/ansible/ansible/pull/17459.diff","patch_url":"https://github.com/ansible/ansible/pull/17459.patch","issue_url":"https://api.github.com/repos/ansible/ansible/issues/17459","number":17459,"state":"open","locked":false,"title":"Re-fix diff display in the `actionable` stdout callback","user":{"login":"towolf","id":345210,"avatar_url":"https://avatars.githubusercontent.com/u/345210?v=3","gravatar_id":"","url":"https://api.github.com/users/towolf","html_url":"https://github.com/towolf","followers_url":"https://api.github.com/users/towolf/followers","following_url":"https://api.github.com/users/towolf/following{/other_user}","gists_url":"https://api.github.com/users/towolf/gists{/gist_id}","starred_url":"https://api.github.com/users/towolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/towolf/subscriptions","organizations_url":"https://api.github.com/users/towolf/orgs","repos_url":"https://api.github.com/users/towolf/repos","events_url":"https://api.github.com/users/towolf/events{/privacy}","received_events_url":"https://api.github.com/users/towolf/received_events","type":"User","site_admin":false},"body":"##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Bugfix Pull Request\r\n\r\n##### COMPONENT NAME\r\n<!--- Name of the plugin/module/task -->\r\n\r\n##### ANSIBLE VERSION\r\n<!--- Paste verbatim output from “ansible --version” between quotes below -->\r\n```\r\nansible 2.2.0 (temp e6deae7abf) last updated 2016/09/08 15:05:15 (GMT +200)\r\n  lib/ansible/modules/core: (devel 1d48b47cad) last updated 2016/09/01 09:55:33 (GMT +200)\r\n  lib/ansible/modules/extras: (detached HEAD 2ef4a34eee) last updated 2016/08/31 16:07:04 (GMT +200)\r\n  config file = /home/towolf/src/ansible/users/tobias.wolf/ansible.cfg\r\n  configured module search path = Default w/o overrides\r\n\r\n```\r\n\r\n##### SUMMARY\r\n\r\n**Regarding the actionable plugin**\r\n\r\nThe diff was displayed before the TASK banner for for itemized and\r\nunitemized tasks:\r\n\r\n1. diff\r\n2. banner\r\n3. item_on_ok\r\n\r\nI removed the loopwise handling of diff in the default callback and\r\nhandle the on_file_diff callback in the actionable callback plugin itself.\r\n\r\nNow all diff display correctly.\r\n\r\nThis PR requires the previous PR #17458\r\n\r\nPlease review the logic for this.","created_at":"2016-09-08T13:08:14Z","updated_at":"2016-09-20T15:30:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"33027a5d6b4f9eed26438aa89708da18086569b9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible/pulls/17459/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible/pulls/17459/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/17459/comments","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/049bc2eec7c317a646bb6e391f5bfcd2664686f6","head":{"label":"towolf:refix-diff-for-actionable-stdout-callback","ref":"refix-diff-for-actionable-stdout-callback","sha":"049bc2eec7c317a646bb6e391f5bfcd2664686f6","user":{"login":"towolf","id":345210,"avatar_url":"https://avatars.githubusercontent.com/u/345210?v=3","gravatar_id":"","url":"https://api.github.com/users/towolf","html_url":"https://github.com/towolf","followers_url":"https://api.github.com/users/towolf/followers","following_url":"https://api.github.com/users/towolf/following{/other_user}","gists_url":"https://api.github.com/users/towolf/gists{/gist_id}","starred_url":"https://api.github.com/users/towolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/towolf/subscriptions","organizations_url":"https://api.github.com/users/towolf/orgs","repos_url":"https://api.github.com/users/towolf/repos","events_url":"https://api.github.com/users/towolf/events{/privacy}","received_events_url":"https://api.github.com/users/towolf/received_events","type":"User","site_admin":false},"repo":{"id":49649505,"name":"ansible","full_name":"towolf/ansible","owner":{"login":"towolf","id":345210,"avatar_url":"https://avatars.githubusercontent.com/u/345210?v=3","gravatar_id":"","url":"https://api.github.com/users/towolf","html_url":"https://github.com/towolf","followers_url":"https://api.github.com/users/towolf/followers","following_url":"https://api.github.com/users/towolf/following{/other_user}","gists_url":"https://api.github.com/users/towolf/gists{/gist_id}","starred_url":"https://api.github.com/users/towolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/towolf/subscriptions","organizations_url":"https://api.github.com/users/towolf/orgs","repos_url":"https://api.github.com/users/towolf/repos","events_url":"https://api.github.com/users/towolf/events{/privacy}","received_events_url":"https://api.github.com/users/towolf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/towolf/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":true,"url":"https://api.github.com/repos/towolf/ansible","forks_url":"https://api.github.com/repos/towolf/ansible/forks","keys_url":"https://api.github.com/repos/towolf/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/towolf/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/towolf/ansible/teams","hooks_url":"https://api.github.com/repos/towolf/ansible/hooks","issue_events_url":"https://api.github.com/repos/towolf/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/towolf/ansible/events","assignees_url":"https://api.github.com/repos/towolf/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/towolf/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/towolf/ansible/tags","blobs_url":"https://api.github.com/repos/towolf/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/towolf/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/towolf/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/towolf/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/towolf/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/towolf/ansible/languages","stargazers_url":"https://api.github.com/repos/towolf/ansible/stargazers","contributors_url":"https://api.github.com/repos/towolf/ansible/contributors","subscribers_url":"https://api.github.com/repos/towolf/ansible/subscribers","subscription_url":"https://api.github.com/repos/towolf/ansible/subscription","commits_url":"https://api.github.com/repos/towolf/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/towolf/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/towolf/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/towolf/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/towolf/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/towolf/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/towolf/ansible/merges","archive_url":"https://api.github.com/repos/towolf/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/towolf/ansible/downloads","issues_url":"https://api.github.com/repos/towolf/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/towolf/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/towolf/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/towolf/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/towolf/ansible/labels{/name}","releases_url":"https://api.github.com/repos/towolf/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/towolf/ansible/deployments","created_at":"2016-01-14T13:40:39Z","updated_at":"2016-01-14T13:40:45Z","pushed_at":"2016-09-08T16:06:28Z","git_url":"git://github.com/towolf/ansible.git","ssh_url":"git@github.com:towolf/ansible.git","clone_url":"https://github.com/towolf/ansible.git","svn_url":"https://github.com/towolf/ansible","homepage":"http://ansible.com/","size":35293,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"982db58aff01033110522c6afe25988f65b05ebc","user":{"login":"ansible","id":1507452,"avatar_url":"https://avatars.githubusercontent.com/u/1507452?v=3","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":3638964,"name":"ansible","full_name":"ansible/ansible","owner":{"login":"ansible","id":1507452,"avatar_url":"https://avatars.githubusercontent.com/u/1507452?v=3","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ansible/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":false,"url":"https://api.github.com/repos/ansible/ansible","forks_url":"https://api.github.com/repos/ansible/ansible/forks","keys_url":"https://api.github.com/repos/ansible/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible/teams","hooks_url":"https://api.github.com/repos/ansible/ansible/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible/events","assignees_url":"https://api.github.com/repos/ansible/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible/tags","blobs_url":"https://api.github.com/repos/ansible/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible/subscription","commits_url":"https://api.github.com/repos/ansible/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible/merges","archive_url":"https://api.github.com/repos/ansible/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible/downloads","issues_url":"https://api.github.com/repos/ansible/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/ansible/deployments","created_at":"2012-03-06T14:58:02Z","updated_at":"2016-09-20T15:25:14Z","pushed_at":"2016-09-20T15:18:37Z","git_url":"git://github.com/ansible/ansible.git","ssh_url":"git@github.com:ansible/ansible.git","clone_url":"https://github.com/ansible/ansible.git","svn_url":"https://github.com/ansible/ansible","homepage":"http://ansible.com/","size":63924,"stargazers_count":18876,"watchers_count":18876,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5736,"mirror_url":null,"open_issues_count":1513,"forks":5736,"open_issues":1513,"watchers":18876,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/17459"},"html":{"href":"https://github.com/ansible/ansible/pull/17459"},"issue":{"href":"https://api.github.com/repos/ansible/ansible/issues/17459"},"comments":{"href":"https://api.github.com/repos/ansible/ansible/issues/17459/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible/pulls/17459/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible/pulls/17459/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible/statuses/049bc2eec7c317a646bb6e391f5bfcd2664686f6"}}}}
{"actor":{"display_login":"towolf"}}