{"action":"created","comment":{"url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/comments/67397150","id":67397150,"diff_hunk":"@@ -663,6 +665,8 @@ def set_password(self, raw_password, notify=True):\n         \"\"\"\n         had_existing_password = bool(self.password)\n         self.password = generate_password_hash(raw_password)\n+        if self.username == raw_password:","path":"framework/auth/core.py","position":20,"original_position":20,"commit_id":"a874b0f66e193c2bdfd30599d143e989962c59aa","original_commit_id":"a874b0f66e193c2bdfd30599d143e989962c59aa","user":{"login":"sloria","id":2379650,"avatar_url":"https://avatars.githubusercontent.com/u/2379650?v=3","gravatar_id":"","url":"https://api.github.com/users/sloria","html_url":"https://github.com/sloria","followers_url":"https://api.github.com/users/sloria/followers","following_url":"https://api.github.com/users/sloria/following{/other_user}","gists_url":"https://api.github.com/users/sloria/gists{/gist_id}","starred_url":"https://api.github.com/users/sloria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sloria/subscriptions","organizations_url":"https://api.github.com/users/sloria/orgs","repos_url":"https://api.github.com/users/sloria/repos","events_url":"https://api.github.com/users/sloria/events{/privacy}","received_events_url":"https://api.github.com/users/sloria/received_events","type":"User","site_admin":false},"body":"See https://github.com/CenterForOpenScience/osf.io/pull/5585/files#r67396994","created_at":"2016-06-16T18:17:47Z","updated_at":"2016-06-16T18:17:47Z","html_url":"https://github.com/CenterForOpenScience/osf.io/pull/5585#discussion_r67397150","pull_request_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/5585","_links":{"self":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/comments/67397150"},"html":{"href":"https://github.com/CenterForOpenScience/osf.io/pull/5585#discussion_r67397150"},"pull_request":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/5585"}}},"pull_request":{"url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/5585","id":68425415,"html_url":"https://github.com/CenterForOpenScience/osf.io/pull/5585","diff_url":"https://github.com/CenterForOpenScience/osf.io/pull/5585.diff","patch_url":"https://github.com/CenterForOpenScience/osf.io/pull/5585.patch","issue_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/5585","number":5585,"state":"open","locked":false,"title":"Feature/Stricter Password Requirements [#OSF-3457]","user":{"login":"erinspace","id":801594,"avatar_url":"https://avatars.githubusercontent.com/u/801594?v=3","gravatar_id":"","url":"https://api.github.com/users/erinspace","html_url":"https://github.com/erinspace","followers_url":"https://api.github.com/users/erinspace/followers","following_url":"https://api.github.com/users/erinspace/following{/other_user}","gists_url":"https://api.github.com/users/erinspace/gists{/gist_id}","starred_url":"https://api.github.com/users/erinspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erinspace/subscriptions","organizations_url":"https://api.github.com/users/erinspace/orgs","repos_url":"https://api.github.com/users/erinspace/repos","events_url":"https://api.github.com/users/erinspace/events{/privacy}","received_events_url":"https://api.github.com/users/erinspace/received_events","type":"User","site_admin":false},"body":"## Purpose\r\n\r\nWhen signing up for the OSF or changing your password, there are not very strict password strength requirements at the moment. This PR will add some stricter security requirements, and also some password strength suggestions, using Dropbox's zxcvbn library https://github.com/dropbox/zxcvbn\r\n\r\n## Changes\r\n\r\n- Add zxcvbn library to requirements\r\n- Add password strength bar to front page, create account login page, forgot password page and reset password page\r\n    - relies on the strength assigned 0-4 by zxcvbn\r\n- CSS classes for password width added to OSF helpers based on those strength numbers\r\n- only allows passwords with strength 2-4 as calculated by zxcvbn (yellow indicator)\r\n- On new accounts and password changes:\r\n    - password cannot be the same as the email address\r\n- Redo reset password form to use KO validation over WTForms\r\n- After password reset, user is redirected to login instead of logging in automatically\r\n\r\nWith the password \"bbbbbb\" --\r\n![screen shot 2016-05-23 at 1 34 54 pm](https://cloud.githubusercontent.com/assets/801594/15479061/5c354188-20ec-11e6-9729-2d23104ddb9c.png)\r\n\r\n\r\nWith the password \"password\" -- \r\n![screen shot 2016-05-23 at 1 42 49 pm](https://cloud.githubusercontent.com/assets/801594/15479066/655050b4-20ec-11e6-8f7e-190602ece7fb.png)\r\n\r\n\r\nWith the password \"horsesrule\" --\r\n![screen shot 2016-05-23 at 1 35 08 pm](https://cloud.githubusercontent.com/assets/801594/15479076/6e6e1a78-20ec-11e6-944d-e5226a310bd7.png)\r\n\r\nWith the password asdfghjkl;'\r\n![screen shot 2016-05-23 at 1 45 23 pm](https://cloud.githubusercontent.com/assets/801594/15479123/a65729ac-20ec-11e6-999b-05ac5afd5c1f.png)\r\n\r\nWith username same as your password:\r\n![screen shot 2016-05-23 at 2 04 08 pm](https://cloud.githubusercontent.com/assets/801594/15479710/7a9ec3b2-20ef-11e6-9c70-7c087a181391.png)\r\n\r\n\r\n## Side effects\r\n- It'd be awesome if someone could take a look at https://github.com/dropbox/zxcvbn#performance and double check that I haven't loaded the library in a way that will cause performance issues.  For example, I require it in ```koHelpers``` to add reusable custom KO validation - will this be slow?\r\n- Advice on how these strength indicators are placed are much welcome! Are they in the way? Is the feedback placed well? Any quirks?\r\n\r\nNOTE: This does NOT deal with password reset in the admin. \r\n\r\n\r\n## Ticket\r\nhttps://openscience.atlassian.net/browse/OSF-3457\r\n","created_at":"2016-04-29T19:58:59Z","updated_at":"2016-06-16T18:17:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9bef65cf94ac92edcbf0e8152a292d087d3d55f6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/5585/commits","review_comments_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/5585/comments","review_comment_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/5585/comments","statuses_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/statuses/a874b0f66e193c2bdfd30599d143e989962c59aa","head":{"label":"erinspace:feature/password_requirements","ref":"feature/password_requirements","sha":"a874b0f66e193c2bdfd30599d143e989962c59aa","user":{"login":"erinspace","id":801594,"avatar_url":"https://avatars.githubusercontent.com/u/801594?v=3","gravatar_id":"","url":"https://api.github.com/users/erinspace","html_url":"https://github.com/erinspace","followers_url":"https://api.github.com/users/erinspace/followers","following_url":"https://api.github.com/users/erinspace/following{/other_user}","gists_url":"https://api.github.com/users/erinspace/gists{/gist_id}","starred_url":"https://api.github.com/users/erinspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erinspace/subscriptions","organizations_url":"https://api.github.com/users/erinspace/orgs","repos_url":"https://api.github.com/users/erinspace/repos","events_url":"https://api.github.com/users/erinspace/events{/privacy}","received_events_url":"https://api.github.com/users/erinspace/received_events","type":"User","site_admin":false},"repo":{"id":27143923,"name":"osf.io","full_name":"erinspace/osf.io","owner":{"login":"erinspace","id":801594,"avatar_url":"https://avatars.githubusercontent.com/u/801594?v=3","gravatar_id":"","url":"https://api.github.com/users/erinspace","html_url":"https://github.com/erinspace","followers_url":"https://api.github.com/users/erinspace/followers","following_url":"https://api.github.com/users/erinspace/following{/other_user}","gists_url":"https://api.github.com/users/erinspace/gists{/gist_id}","starred_url":"https://api.github.com/users/erinspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erinspace/subscriptions","organizations_url":"https://api.github.com/users/erinspace/orgs","repos_url":"https://api.github.com/users/erinspace/repos","events_url":"https://api.github.com/users/erinspace/events{/privacy}","received_events_url":"https://api.github.com/users/erinspace/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/erinspace/osf.io","description":"Facilitating Open Science","fork":true,"url":"https://api.github.com/repos/erinspace/osf.io","forks_url":"https://api.github.com/repos/erinspace/osf.io/forks","keys_url":"https://api.github.com/repos/erinspace/osf.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erinspace/osf.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erinspace/osf.io/teams","hooks_url":"https://api.github.com/repos/erinspace/osf.io/hooks","issue_events_url":"https://api.github.com/repos/erinspace/osf.io/issues/events{/number}","events_url":"https://api.github.com/repos/erinspace/osf.io/events","assignees_url":"https://api.github.com/repos/erinspace/osf.io/assignees{/user}","branches_url":"https://api.github.com/repos/erinspace/osf.io/branches{/branch}","tags_url":"https://api.github.com/repos/erinspace/osf.io/tags","blobs_url":"https://api.github.com/repos/erinspace/osf.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erinspace/osf.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erinspace/osf.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/erinspace/osf.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erinspace/osf.io/statuses/{sha}","languages_url":"https://api.github.com/repos/erinspace/osf.io/languages","stargazers_url":"https://api.github.com/repos/erinspace/osf.io/stargazers","contributors_url":"https://api.github.com/repos/erinspace/osf.io/contributors","subscribers_url":"https://api.github.com/repos/erinspace/osf.io/subscribers","subscription_url":"https://api.github.com/repos/erinspace/osf.io/subscription","commits_url":"https://api.github.com/repos/erinspace/osf.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/erinspace/osf.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/erinspace/osf.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/erinspace/osf.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/erinspace/osf.io/contents/{+path}","compare_url":"https://api.github.com/repos/erinspace/osf.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erinspace/osf.io/merges","archive_url":"https://api.github.com/repos/erinspace/osf.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erinspace/osf.io/downloads","issues_url":"https://api.github.com/repos/erinspace/osf.io/issues{/number}","pulls_url":"https://api.github.com/repos/erinspace/osf.io/pulls{/number}","milestones_url":"https://api.github.com/repos/erinspace/osf.io/milestones{/number}","notifications_url":"https://api.github.com/repos/erinspace/osf.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erinspace/osf.io/labels{/name}","releases_url":"https://api.github.com/repos/erinspace/osf.io/releases{/id}","deployments_url":"https://api.github.com/repos/erinspace/osf.io/deployments","created_at":"2014-11-25T20:10:31Z","updated_at":"2015-04-03T14:29:22Z","pushed_at":"2016-06-15T21:04:17Z","git_url":"git://github.com/erinspace/osf.io.git","ssh_url":"git@github.com:erinspace/osf.io.git","clone_url":"https://github.com/erinspace/osf.io.git","svn_url":"https://github.com/erinspace/osf.io","homepage":"http://osf.io","size":133779,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"CenterForOpenScience:develop","ref":"develop","sha":"456b98050281110dcfa4075824844143f64b0937","user":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars.githubusercontent.com/u/3344584?v=3","gravatar_id":"","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"repo":{"id":10199599,"name":"osf.io","full_name":"CenterForOpenScience/osf.io","owner":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars.githubusercontent.com/u/3344584?v=3","gravatar_id":"","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CenterForOpenScience/osf.io","description":"Facilitating Open Science","fork":false,"url":"https://api.github.com/repos/CenterForOpenScience/osf.io","forks_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/forks","keys_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/teams","hooks_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/hooks","issue_events_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/events{/number}","events_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/events","assignees_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/assignees{/user}","branches_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/branches{/branch}","tags_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/tags","blobs_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/statuses/{sha}","languages_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/languages","stargazers_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/stargazers","contributors_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/contributors","subscribers_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/subscribers","subscription_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/subscription","commits_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/contents/{+path}","compare_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/merges","archive_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/downloads","issues_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues{/number}","pulls_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls{/number}","milestones_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/milestones{/number}","notifications_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/labels{/name}","releases_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/releases{/id}","deployments_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/deployments","created_at":"2013-05-21T15:53:37Z","updated_at":"2016-06-16T10:17:22Z","pushed_at":"2016-06-16T18:03:47Z","git_url":"git://github.com/CenterForOpenScience/osf.io.git","ssh_url":"git@github.com:CenterForOpenScience/osf.io.git","clone_url":"https://github.com/CenterForOpenScience/osf.io.git","svn_url":"https://github.com/CenterForOpenScience/osf.io","homepage":"http://osf.io","size":283631,"stargazers_count":226,"watchers_count":226,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":187,"mirror_url":null,"open_issues_count":214,"forks":187,"open_issues":214,"watchers":226,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/5585"},"html":{"href":"https://github.com/CenterForOpenScience/osf.io/pull/5585"},"issue":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/5585"},"comments":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/5585/comments"},"review_comments":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/5585/comments"},"review_comment":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/5585/commits"},"statuses":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/statuses/a874b0f66e193c2bdfd30599d143e989962c59aa"}}}}
{"actor":{"display_login":"sloria"}}