{"action":"created","issue":{"url":"https://api.github.com/repos/hashicorp/terraform/issues/7470","repository_url":"https://api.github.com/repos/hashicorp/terraform","labels_url":"https://api.github.com/repos/hashicorp/terraform/issues/7470/labels{/name}","comments_url":"https://api.github.com/repos/hashicorp/terraform/issues/7470/comments","events_url":"https://api.github.com/repos/hashicorp/terraform/issues/7470/events","html_url":"https://github.com/hashicorp/terraform/pull/7470","id":163529506,"number":7470,"title":"provider/aws: Allow VPC Classic Linking in Autoscaling Launch Configs","user":{"login":"andrewsykim","id":12699319,"avatar_url":"https://avatars.githubusercontent.com/u/12699319?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewsykim","html_url":"https://github.com/andrewsykim","followers_url":"https://api.github.com/users/andrewsykim/followers","following_url":"https://api.github.com/users/andrewsykim/following{/other_user}","gists_url":"https://api.github.com/users/andrewsykim/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewsykim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewsykim/subscriptions","organizations_url":"https://api.github.com/users/andrewsykim/orgs","repos_url":"https://api.github.com/users/andrewsykim/repos","events_url":"https://api.github.com/users/andrewsykim/events{/privacy}","received_events_url":"https://api.github.com/users/andrewsykim/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/hashicorp/terraform/labels/enhancement","name":"enhancement","color":"d4c5f9"},{"url":"https://api.github.com/repos/hashicorp/terraform/labels/provider/aws","name":"provider/aws","color":"bfdadc"},{"url":"https://api.github.com/repos/hashicorp/terraform/labels/waiting-response","name":"waiting-response","color":"5319e7"}],"state":"open","locked":false,"assignee":{"login":"stack72","id":227823,"avatar_url":"https://avatars.githubusercontent.com/u/227823?v=3","gravatar_id":"","url":"https://api.github.com/users/stack72","html_url":"https://github.com/stack72","followers_url":"https://api.github.com/users/stack72/followers","following_url":"https://api.github.com/users/stack72/following{/other_user}","gists_url":"https://api.github.com/users/stack72/gists{/gist_id}","starred_url":"https://api.github.com/users/stack72/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stack72/subscriptions","organizations_url":"https://api.github.com/users/stack72/orgs","repos_url":"https://api.github.com/users/stack72/repos","events_url":"https://api.github.com/users/stack72/events{/privacy}","received_events_url":"https://api.github.com/users/stack72/received_events","type":"User","site_admin":false},"assignees":[{"login":"stack72","id":227823,"avatar_url":"https://avatars.githubusercontent.com/u/227823?v=3","gravatar_id":"","url":"https://api.github.com/users/stack72","html_url":"https://github.com/stack72","followers_url":"https://api.github.com/users/stack72/followers","following_url":"https://api.github.com/users/stack72/following{/other_user}","gists_url":"https://api.github.com/users/stack72/gists{/gist_id}","starred_url":"https://api.github.com/users/stack72/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stack72/subscriptions","organizations_url":"https://api.github.com/users/stack72/orgs","repos_url":"https://api.github.com/users/stack72/repos","events_url":"https://api.github.com/users/stack72/events{/privacy}","received_events_url":"https://api.github.com/users/stack72/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-07-02T18:02:31Z","updated_at":"2016-07-15T19:27:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hashicorp/terraform/pulls/7470","html_url":"https://github.com/hashicorp/terraform/pull/7470","diff_url":"https://github.com/hashicorp/terraform/pull/7470.diff","patch_url":"https://github.com/hashicorp/terraform/pull/7470.patch"},"body":"AWS provides EC2 ClassicLink which allows instances outside of a VPC to reach instances within it. More details [here](http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/vpc-classiclink.html). The use case is mainly for transitioning existing infrastructure into a VPC. You can specify a default VPC id and an associated security group with an autoscaling launch config so that all instances within the autoscaling group are automatically linked to a desired VPC. From my current understanding, terraform does not have support yet for VPC linking in launch configurations. \r\n\r\nI noticed that the acceptance tests require the use of real AWS resources. I've tested my changes against resources that we own but I've replaced those values with some of the values I've seen in other examples for obvious reasons. As a result I'm not entirely sure if they'll work using your AWS resources. I'd be interested to know how you guys manage resources for acceptance testing from outside contributors. \r\n\r\n```\r\nterraform andrewsykim$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSLaunchConfiguration_withVpcClassicLink'\r\n==> Checking that code complies with gofmt requirements...\r\n/Users/andrewsykim/bin/stringer\r\ngo generate $(go list ./... | grep -v /vendor/)\r\n2016/07/02 13:40:52 Generated command/internal_plugin_list.go\r\nTF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSLaunchConfiguration_withVpcClassicLink -timeout 120m\r\n=== RUN   TestAccAWSLaunchConfiguration_withVpcClassicLink\r\n--- PASS: TestAccAWSLaunchConfiguration_withVpcClassicLink (10.37s)\r\nPASS\r\nok  \tgithub.com/hashicorp/terraform/builtin/providers/aws\t10.388s\r\n``` "},"comment":{"url":"https://api.github.com/repos/hashicorp/terraform/issues/comments/233048754","html_url":"https://github.com/hashicorp/terraform/pull/7470#issuecomment-233048754","issue_url":"https://api.github.com/repos/hashicorp/terraform/issues/7470","id":233048754,"user":{"login":"andrewsykim","id":12699319,"avatar_url":"https://avatars.githubusercontent.com/u/12699319?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewsykim","html_url":"https://github.com/andrewsykim","followers_url":"https://api.github.com/users/andrewsykim/followers","following_url":"https://api.github.com/users/andrewsykim/following{/other_user}","gists_url":"https://api.github.com/users/andrewsykim/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewsykim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewsykim/subscriptions","organizations_url":"https://api.github.com/users/andrewsykim/orgs","repos_url":"https://api.github.com/users/andrewsykim/repos","events_url":"https://api.github.com/users/andrewsykim/events{/privacy}","received_events_url":"https://api.github.com/users/andrewsykim/received_events","type":"User","site_admin":false},"created_at":"2016-07-15T19:27:59Z","updated_at":"2016-07-15T19:27:59Z","body":"@stack72 sounds good, I saw a few acceptance test cases that had hard coded values so I assumed there was a set of values we can hard code for those acceptance tests to work (with some shared AWS account). For the tests to pass I can add a setup step that creates all the existing resources required for this acceptance test "}}
{"actor":{"display_login":"andrewsykim"}}