{"action":"created","issue":{"url":"https://api.github.com/repos/google/googletest/issues/778","repository_url":"https://api.github.com/repos/google/googletest","labels_url":"https://api.github.com/repos/google/googletest/issues/778/labels{/name}","comments_url":"https://api.github.com/repos/google/googletest/issues/778/comments","events_url":"https://api.github.com/repos/google/googletest/issues/778/events","html_url":"https://github.com/google/googletest/pull/778","id":155477158,"number":778,"title":"Re-enable MSVC++ C4389 warning in CmdHelperEq()","user":{"login":"gpakosz","id":553208,"avatar_url":"https://avatars.githubusercontent.com/u/553208?v=3","gravatar_id":"","url":"https://api.github.com/users/gpakosz","html_url":"https://github.com/gpakosz","followers_url":"https://api.github.com/users/gpakosz/followers","following_url":"https://api.github.com/users/gpakosz/following{/other_user}","gists_url":"https://api.github.com/users/gpakosz/gists{/gist_id}","starred_url":"https://api.github.com/users/gpakosz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpakosz/subscriptions","organizations_url":"https://api.github.com/users/gpakosz/orgs","repos_url":"https://api.github.com/users/gpakosz/repos","events_url":"https://api.github.com/users/gpakosz/events{/privacy}","received_events_url":"https://api.github.com/users/gpakosz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-05-18T11:22:00Z","updated_at":"2016-06-23T19:11:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/google/googletest/pulls/778","html_url":"https://github.com/google/googletest/pull/778","diff_url":"https://github.com/google/googletest/pull/778.diff","patch_url":"https://github.com/google/googletest/pull/778.patch"},"body":"This PR re-enables C4389 as discussed in https://github.com/google/googletest/issues/683#issuecomment-196694742\r\n\r\nC4389 was inhibited in commit 4b83461 making behavior inconsistent with other compilers."},"comment":{"url":"https://api.github.com/repos/google/googletest/issues/comments/228153836","html_url":"https://github.com/google/googletest/pull/778#issuecomment-228153836","issue_url":"https://api.github.com/repos/google/googletest/issues/778","id":228153836,"user":{"login":"BillyDonahue","id":8611652,"avatar_url":"https://avatars.githubusercontent.com/u/8611652?v=3","gravatar_id":"","url":"https://api.github.com/users/BillyDonahue","html_url":"https://github.com/BillyDonahue","followers_url":"https://api.github.com/users/BillyDonahue/followers","following_url":"https://api.github.com/users/BillyDonahue/following{/other_user}","gists_url":"https://api.github.com/users/BillyDonahue/gists{/gist_id}","starred_url":"https://api.github.com/users/BillyDonahue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BillyDonahue/subscriptions","organizations_url":"https://api.github.com/users/BillyDonahue/orgs","repos_url":"https://api.github.com/users/BillyDonahue/repos","events_url":"https://api.github.com/users/BillyDonahue/events{/privacy}","received_events_url":"https://api.github.com/users/BillyDonahue/received_events","type":"User","site_admin":false},"created_at":"2016-06-23T19:11:01Z","updated_at":"2016-06-23T19:11:01Z","body":"It will cause them to do work. They will be in a better position to do that\nwhen they're upgrading to a new release.\n\nOn Thursday, June 23, 2016, Gregory Pakosz <notifications@github.com> wrote:\n\n> You're right it's going to change things for users.\n>\n> I would argue it's for the good. I disagree with qualifying this PR as\n> \"breaking things for some users\". The way googletest currently hides\n> warnings is bad:\n>\n> uint32_t a = 1;\n> int32_t b = -1;\n> EXPECT_GT(a, b);\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/google/googletest/pull/778#issuecomment-228146440>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe/AINnRFaUOHOkvD8GyB1MbOapYoJA0y39ks5qOtR1gaJpZM4IhLh7>\n> .\n>\n"}}
{"actor":{"display_login":"BillyDonahue"}}