{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/docs/issues/467","repository_url":"https://api.github.com/repos/cockroachdb/docs","labels_url":"https://api.github.com/repos/cockroachdb/docs/issues/467/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/docs/issues/467/comments","events_url":"https://api.github.com/repos/cockroachdb/docs/issues/467/events","html_url":"https://github.com/cockroachdb/docs/pull/467","id":166650893,"number":467,"title":"Docs feedback widget","user":{"login":"jseldess","id":15893490,"avatar_url":"https://avatars.githubusercontent.com/u/15893490?v=3","gravatar_id":"","url":"https://api.github.com/users/jseldess","html_url":"https://github.com/jseldess","followers_url":"https://api.github.com/users/jseldess/followers","following_url":"https://api.github.com/users/jseldess/following{/other_user}","gists_url":"https://api.github.com/users/jseldess/gists{/gist_id}","starred_url":"https://api.github.com/users/jseldess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jseldess/subscriptions","organizations_url":"https://api.github.com/users/jseldess/orgs","repos_url":"https://api.github.com/users/jseldess/repos","events_url":"https://api.github.com/users/jseldess/events{/privacy}","received_events_url":"https://api.github.com/users/jseldess/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"spencerkimball","id":6147149,"avatar_url":"https://avatars.githubusercontent.com/u/6147149?v=3","gravatar_id":"","url":"https://api.github.com/users/spencerkimball","html_url":"https://github.com/spencerkimball","followers_url":"https://api.github.com/users/spencerkimball/followers","following_url":"https://api.github.com/users/spencerkimball/following{/other_user}","gists_url":"https://api.github.com/users/spencerkimball/gists{/gist_id}","starred_url":"https://api.github.com/users/spencerkimball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spencerkimball/subscriptions","organizations_url":"https://api.github.com/users/spencerkimball/orgs","repos_url":"https://api.github.com/users/spencerkimball/repos","events_url":"https://api.github.com/users/spencerkimball/events{/privacy}","received_events_url":"https://api.github.com/users/spencerkimball/received_events","type":"User","site_admin":false},"assignees":[{"login":"spencerkimball","id":6147149,"avatar_url":"https://avatars.githubusercontent.com/u/6147149?v=3","gravatar_id":"","url":"https://api.github.com/users/spencerkimball","html_url":"https://github.com/spencerkimball","followers_url":"https://api.github.com/users/spencerkimball/followers","following_url":"https://api.github.com/users/spencerkimball/following{/other_user}","gists_url":"https://api.github.com/users/spencerkimball/gists{/gist_id}","starred_url":"https://api.github.com/users/spencerkimball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spencerkimball/subscriptions","organizations_url":"https://api.github.com/users/spencerkimball/orgs","repos_url":"https://api.github.com/users/spencerkimball/repos","events_url":"https://api.github.com/users/spencerkimball/events{/privacy}","received_events_url":"https://api.github.com/users/spencerkimball/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2016-07-20T18:34:25Z","updated_at":"2016-07-20T22:05:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/docs/pulls/467","html_url":"https://github.com/cockroachdb/docs/pull/467","diff_url":"https://github.com/cockroachdb/docs/pull/467.diff","patch_url":"https://github.com/cockroachdb/docs/pull/467.patch"},"body":"This PR adds a feedback mechanism to the bottom of every page of our docs. We're using a hubspot form to collect submitted feedback.\r\n\r\n- When a user clicks **Yes**, we send a \"yes\" response, along with the current page title, to hubspot via their forms api. \r\n- When a user clicks **No**, we open a popup (using the [magnificent popup script](http://dimsemenov.com/plugins/magnific-popup/#mfp-build-tool)) containing the embedded hubspot form. When the user then clicks **Submit**, all completed fields, along with the current page title, are sent to hubspot.\r\n\r\nIn cases where we don't want the feedback widget to show up on a page (i.e., the page is just a placeholder), `feedback: false` can be added to the page's frontmatter.\r\n\r\nOne benefit of using hubspot is that we can track known users' actions across our site. For example, we'll be able to see if a user submitting docs feedback is also signed up for a newsletter.\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/docs/467)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/docs/issues/comments/234098295","html_url":"https://github.com/cockroachdb/docs/pull/467#issuecomment-234098295","issue_url":"https://api.github.com/repos/cockroachdb/docs/issues/467","id":234098295,"user":{"login":"jseldess","id":15893490,"avatar_url":"https://avatars.githubusercontent.com/u/15893490?v=3","gravatar_id":"","url":"https://api.github.com/users/jseldess","html_url":"https://github.com/jseldess","followers_url":"https://api.github.com/users/jseldess/followers","following_url":"https://api.github.com/users/jseldess/following{/other_user}","gists_url":"https://api.github.com/users/jseldess/gists{/gist_id}","starred_url":"https://api.github.com/users/jseldess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jseldess/subscriptions","organizations_url":"https://api.github.com/users/jseldess/orgs","repos_url":"https://api.github.com/users/jseldess/repos","events_url":"https://api.github.com/users/jseldess/events{/privacy}","received_events_url":"https://api.github.com/users/jseldess/received_events","type":"User","site_admin":false},"created_at":"2016-07-20T22:05:14Z","updated_at":"2016-07-20T22:05:14Z","body":"\n\n\n\nReview status: 0 of 10 files reviewed at latest revision, 3 unresolved discussions.\n\n---\n\n*[css/feedback-widget.css, line 6 \\[r1\\]](https://reviewable.io:443/reviews/cockroachdb/docs/467#-KN8_atQDJGH2zRiCrrE-r1-6:-KN9JmGzNkWVBJ4xgdxa:-499146009) ([raw file](https://github.com/cockroachdb/docs/blob/520c70ba7976be2098c4b5e27cb96f3b7868bc62/css/feedback-widget.css#L6)):*\n<details><summary><i>Previously, maxlang (Max Lang) wrote…</i></summary>\n> Can just be `0` - drop the `px`\n</details>\nDone.\n\n---\n\n*[css/feedback-widget.css, line 62 \\[r1\\]](https://reviewable.io:443/reviews/cockroachdb/docs/467#-KN8_atQDJGH2zRiCrrE-r1-62:-KN9KYHGU07Z1q5_CeXe:-499146009) ([raw file](https://github.com/cockroachdb/docs/blob/520c70ba7976be2098c4b5e27cb96f3b7868bc62/css/feedback-widget.css#L62)):*\n<details><summary><i>Previously, maxlang (Max Lang) wrote…</i></summary>\n> I'd add the URL if you got these styles someplace specific.\n</details>\nDone.\n\n---\n\n*[css/feedback-widget.css, line 530 \\[r1\\]](https://reviewable.io:443/reviews/cockroachdb/docs/467#-KN8_atQDJGH2zRiCrrE-r1-530:-KN9KdR2pkDPV10pC5Kb:-499146009) ([raw file](https://github.com/cockroachdb/docs/blob/520c70ba7976be2098c4b5e27cb96f3b7868bc62/css/feedback-widget.css#L530)):*\n<details><summary><i>Previously, maxlang (Max Lang) wrote…</i></summary>\n> Remove commented code.\r> \n> \r> \n> File should probably end with a newline.\n</details>\nDone.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/cockroachdb/docs/467)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"jseldess"}}