{"action":"created","comment":{"url":"https://api.github.com/repos/firehol/firehol/pulls/comments/57517429","id":57517429,"diff_hunk":"@@ -18,11 +18,11 @@ AC_INIT([firehol],VERSION_NUMBER[]VERSION_SUFFIX,[firehol-devs@lists.firehol.org\n \n AC_CONFIG_MACRO_DIR([m4])\n AC_CONFIG_AUX_DIR([autotool])\n-AC_CONFIG_SRCDIR([sbin/firehol.in])\n-AC_CONFIG_SRCDIR([sbin/fireqos.in])\n-AC_CONFIG_SRCDIR([sbin/link-balancer.in])\n-AC_CONFIG_SRCDIR([sbin/update-ipsets.in])\n-AC_CONFIG_SRCDIR([sbin/vnetbuild.in])\n+AC_CONFIG_SRCDIR([sbin/firehol.in.in])\n+AC_CONFIG_SRCDIR([sbin/fireqos.in.in])\n+AC_CONFIG_SRCDIR([sbin/link-balancer.in.in])\n+AC_CONFIG_SRCDIR([sbin/update-ipsets.in.in])\n+AC_CONFIG_SRCDIR([sbin/vnetbuild.in.in])","path":"configure.ac","position":13,"original_position":13,"commit_id":"df09d75bcc615186e6e8a2e297492b7031fdce29","original_commit_id":"df09d75bcc615186e6e8a2e297492b7031fdce29","user":{"login":"alonbl","id":1263789,"avatar_url":"https://avatars.githubusercontent.com/u/1263789?v=3","gravatar_id":"","url":"https://api.github.com/users/alonbl","html_url":"https://github.com/alonbl","followers_url":"https://api.github.com/users/alonbl/followers","following_url":"https://api.github.com/users/alonbl/following{/other_user}","gists_url":"https://api.github.com/users/alonbl/gists{/gist_id}","starred_url":"https://api.github.com/users/alonbl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alonbl/subscriptions","organizations_url":"https://api.github.com/users/alonbl/orgs","repos_url":"https://api.github.com/users/alonbl/repos","events_url":"https://api.github.com/users/alonbl/events{/privacy}","received_events_url":"https://api.github.com/users/alonbl/received_events","type":"User","site_admin":false},"body":"I am unsure why you need more than one AC_CONFIG_SRCDIR in configure.ac","created_at":"2016-03-26T18:28:13Z","updated_at":"2016-03-26T18:28:13Z","html_url":"https://github.com/firehol/firehol/pull/128#discussion_r57517429","pull_request_url":"https://api.github.com/repos/firehol/firehol/pulls/128","_links":{"self":{"href":"https://api.github.com/repos/firehol/firehol/pulls/comments/57517429"},"html":{"href":"https://github.com/firehol/firehol/pull/128#discussion_r57517429"},"pull_request":{"href":"https://api.github.com/repos/firehol/firehol/pulls/128"}}},"pull_request":{"url":"https://api.github.com/repos/firehol/firehol/pulls/128","id":64244745,"html_url":"https://github.com/firehol/firehol/pull/128","diff_url":"https://github.com/firehol/firehol/pull/128.diff","patch_url":"https://github.com/firehol/firehol/pull/128.patch","issue_url":"https://api.github.com/repos/firehol/firehol/issues/128","number":128,"state":"open","locked":false,"title":"Move fully to autotools","user":{"login":"philwhineray","id":1271051,"avatar_url":"https://avatars.githubusercontent.com/u/1271051?v=3","gravatar_id":"","url":"https://api.github.com/users/philwhineray","html_url":"https://github.com/philwhineray","followers_url":"https://api.github.com/users/philwhineray/followers","following_url":"https://api.github.com/users/philwhineray/following{/other_user}","gists_url":"https://api.github.com/users/philwhineray/gists{/gist_id}","starred_url":"https://api.github.com/users/philwhineray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philwhineray/subscriptions","organizations_url":"https://api.github.com/users/philwhineray/orgs","repos_url":"https://api.github.com/users/philwhineray/repos","events_url":"https://api.github.com/users/philwhineray/events{/privacy}","received_events_url":"https://api.github.com/users/philwhineray/received_events","type":"User","site_admin":false},"body":"This pull request contains the @alonbl commit plus a whole series of others, to move all the scripts over to a common method requiring even developers to do a configure and make. It reduces the code size somewhat and ensures a consistent experience.","created_at":"2016-03-26T18:09:48Z","updated_at":"2016-03-26T18:28:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a1d2d1935cc5defa254edbc4fea844d8772d0757","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/firehol/firehol/pulls/128/commits","review_comments_url":"https://api.github.com/repos/firehol/firehol/pulls/128/comments","review_comment_url":"https://api.github.com/repos/firehol/firehol/pulls/comments{/number}","comments_url":"https://api.github.com/repos/firehol/firehol/issues/128/comments","statuses_url":"https://api.github.com/repos/firehol/firehol/statuses/df09d75bcc615186e6e8a2e297492b7031fdce29","head":{"label":"firehol:alonbl-build","ref":"alonbl-build","sha":"df09d75bcc615186e6e8a2e297492b7031fdce29","user":{"login":"firehol","id":9442231,"avatar_url":"https://avatars.githubusercontent.com/u/9442231?v=3","gravatar_id":"","url":"https://api.github.com/users/firehol","html_url":"https://github.com/firehol","followers_url":"https://api.github.com/users/firehol/followers","following_url":"https://api.github.com/users/firehol/following{/other_user}","gists_url":"https://api.github.com/users/firehol/gists{/gist_id}","starred_url":"https://api.github.com/users/firehol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firehol/subscriptions","organizations_url":"https://api.github.com/users/firehol/orgs","repos_url":"https://api.github.com/users/firehol/repos","events_url":"https://api.github.com/users/firehol/events{/privacy}","received_events_url":"https://api.github.com/users/firehol/received_events","type":"Organization","site_admin":false},"repo":{"id":12880290,"name":"firehol","full_name":"firehol/firehol","owner":{"login":"firehol","id":9442231,"avatar_url":"https://avatars.githubusercontent.com/u/9442231?v=3","gravatar_id":"","url":"https://api.github.com/users/firehol","html_url":"https://github.com/firehol","followers_url":"https://api.github.com/users/firehol/followers","following_url":"https://api.github.com/users/firehol/following{/other_user}","gists_url":"https://api.github.com/users/firehol/gists{/gist_id}","starred_url":"https://api.github.com/users/firehol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firehol/subscriptions","organizations_url":"https://api.github.com/users/firehol/orgs","repos_url":"https://api.github.com/users/firehol/repos","events_url":"https://api.github.com/users/firehol/events{/privacy}","received_events_url":"https://api.github.com/users/firehol/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/firehol/firehol","description":"A firewall for humans...","fork":false,"url":"https://api.github.com/repos/firehol/firehol","forks_url":"https://api.github.com/repos/firehol/firehol/forks","keys_url":"https://api.github.com/repos/firehol/firehol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firehol/firehol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firehol/firehol/teams","hooks_url":"https://api.github.com/repos/firehol/firehol/hooks","issue_events_url":"https://api.github.com/repos/firehol/firehol/issues/events{/number}","events_url":"https://api.github.com/repos/firehol/firehol/events","assignees_url":"https://api.github.com/repos/firehol/firehol/assignees{/user}","branches_url":"https://api.github.com/repos/firehol/firehol/branches{/branch}","tags_url":"https://api.github.com/repos/firehol/firehol/tags","blobs_url":"https://api.github.com/repos/firehol/firehol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firehol/firehol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firehol/firehol/git/refs{/sha}","trees_url":"https://api.github.com/repos/firehol/firehol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firehol/firehol/statuses/{sha}","languages_url":"https://api.github.com/repos/firehol/firehol/languages","stargazers_url":"https://api.github.com/repos/firehol/firehol/stargazers","contributors_url":"https://api.github.com/repos/firehol/firehol/contributors","subscribers_url":"https://api.github.com/repos/firehol/firehol/subscribers","subscription_url":"https://api.github.com/repos/firehol/firehol/subscription","commits_url":"https://api.github.com/repos/firehol/firehol/commits{/sha}","git_commits_url":"https://api.github.com/repos/firehol/firehol/git/commits{/sha}","comments_url":"https://api.github.com/repos/firehol/firehol/comments{/number}","issue_comment_url":"https://api.github.com/repos/firehol/firehol/issues/comments{/number}","contents_url":"https://api.github.com/repos/firehol/firehol/contents/{+path}","compare_url":"https://api.github.com/repos/firehol/firehol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firehol/firehol/merges","archive_url":"https://api.github.com/repos/firehol/firehol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firehol/firehol/downloads","issues_url":"https://api.github.com/repos/firehol/firehol/issues{/number}","pulls_url":"https://api.github.com/repos/firehol/firehol/pulls{/number}","milestones_url":"https://api.github.com/repos/firehol/firehol/milestones{/number}","notifications_url":"https://api.github.com/repos/firehol/firehol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firehol/firehol/labels{/name}","releases_url":"https://api.github.com/repos/firehol/firehol/releases{/id}","deployments_url":"https://api.github.com/repos/firehol/firehol/deployments","created_at":"2013-09-16T22:23:26Z","updated_at":"2016-03-24T14:48:20Z","pushed_at":"2016-03-26T18:09:48Z","git_url":"git://github.com/firehol/firehol.git","ssh_url":"git@github.com:firehol/firehol.git","clone_url":"https://github.com/firehol/firehol.git","svn_url":"https://github.com/firehol/firehol","homepage":null,"size":4643,"stargazers_count":153,"watchers_count":153,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":53,"forks":15,"open_issues":53,"watchers":153,"default_branch":"master"}},"base":{"label":"firehol:master","ref":"master","sha":"0d60cc20e3b25f25da38b6cfeb3fffb2243180fe","user":{"login":"firehol","id":9442231,"avatar_url":"https://avatars.githubusercontent.com/u/9442231?v=3","gravatar_id":"","url":"https://api.github.com/users/firehol","html_url":"https://github.com/firehol","followers_url":"https://api.github.com/users/firehol/followers","following_url":"https://api.github.com/users/firehol/following{/other_user}","gists_url":"https://api.github.com/users/firehol/gists{/gist_id}","starred_url":"https://api.github.com/users/firehol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firehol/subscriptions","organizations_url":"https://api.github.com/users/firehol/orgs","repos_url":"https://api.github.com/users/firehol/repos","events_url":"https://api.github.com/users/firehol/events{/privacy}","received_events_url":"https://api.github.com/users/firehol/received_events","type":"Organization","site_admin":false},"repo":{"id":12880290,"name":"firehol","full_name":"firehol/firehol","owner":{"login":"firehol","id":9442231,"avatar_url":"https://avatars.githubusercontent.com/u/9442231?v=3","gravatar_id":"","url":"https://api.github.com/users/firehol","html_url":"https://github.com/firehol","followers_url":"https://api.github.com/users/firehol/followers","following_url":"https://api.github.com/users/firehol/following{/other_user}","gists_url":"https://api.github.com/users/firehol/gists{/gist_id}","starred_url":"https://api.github.com/users/firehol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firehol/subscriptions","organizations_url":"https://api.github.com/users/firehol/orgs","repos_url":"https://api.github.com/users/firehol/repos","events_url":"https://api.github.com/users/firehol/events{/privacy}","received_events_url":"https://api.github.com/users/firehol/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/firehol/firehol","description":"A firewall for humans...","fork":false,"url":"https://api.github.com/repos/firehol/firehol","forks_url":"https://api.github.com/repos/firehol/firehol/forks","keys_url":"https://api.github.com/repos/firehol/firehol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firehol/firehol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firehol/firehol/teams","hooks_url":"https://api.github.com/repos/firehol/firehol/hooks","issue_events_url":"https://api.github.com/repos/firehol/firehol/issues/events{/number}","events_url":"https://api.github.com/repos/firehol/firehol/events","assignees_url":"https://api.github.com/repos/firehol/firehol/assignees{/user}","branches_url":"https://api.github.com/repos/firehol/firehol/branches{/branch}","tags_url":"https://api.github.com/repos/firehol/firehol/tags","blobs_url":"https://api.github.com/repos/firehol/firehol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firehol/firehol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firehol/firehol/git/refs{/sha}","trees_url":"https://api.github.com/repos/firehol/firehol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firehol/firehol/statuses/{sha}","languages_url":"https://api.github.com/repos/firehol/firehol/languages","stargazers_url":"https://api.github.com/repos/firehol/firehol/stargazers","contributors_url":"https://api.github.com/repos/firehol/firehol/contributors","subscribers_url":"https://api.github.com/repos/firehol/firehol/subscribers","subscription_url":"https://api.github.com/repos/firehol/firehol/subscription","commits_url":"https://api.github.com/repos/firehol/firehol/commits{/sha}","git_commits_url":"https://api.github.com/repos/firehol/firehol/git/commits{/sha}","comments_url":"https://api.github.com/repos/firehol/firehol/comments{/number}","issue_comment_url":"https://api.github.com/repos/firehol/firehol/issues/comments{/number}","contents_url":"https://api.github.com/repos/firehol/firehol/contents/{+path}","compare_url":"https://api.github.com/repos/firehol/firehol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firehol/firehol/merges","archive_url":"https://api.github.com/repos/firehol/firehol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firehol/firehol/downloads","issues_url":"https://api.github.com/repos/firehol/firehol/issues{/number}","pulls_url":"https://api.github.com/repos/firehol/firehol/pulls{/number}","milestones_url":"https://api.github.com/repos/firehol/firehol/milestones{/number}","notifications_url":"https://api.github.com/repos/firehol/firehol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firehol/firehol/labels{/name}","releases_url":"https://api.github.com/repos/firehol/firehol/releases{/id}","deployments_url":"https://api.github.com/repos/firehol/firehol/deployments","created_at":"2013-09-16T22:23:26Z","updated_at":"2016-03-24T14:48:20Z","pushed_at":"2016-03-26T18:09:48Z","git_url":"git://github.com/firehol/firehol.git","ssh_url":"git@github.com:firehol/firehol.git","clone_url":"https://github.com/firehol/firehol.git","svn_url":"https://github.com/firehol/firehol","homepage":null,"size":4643,"stargazers_count":153,"watchers_count":153,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":53,"forks":15,"open_issues":53,"watchers":153,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/firehol/firehol/pulls/128"},"html":{"href":"https://github.com/firehol/firehol/pull/128"},"issue":{"href":"https://api.github.com/repos/firehol/firehol/issues/128"},"comments":{"href":"https://api.github.com/repos/firehol/firehol/issues/128/comments"},"review_comments":{"href":"https://api.github.com/repos/firehol/firehol/pulls/128/comments"},"review_comment":{"href":"https://api.github.com/repos/firehol/firehol/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/firehol/firehol/pulls/128/commits"},"statuses":{"href":"https://api.github.com/repos/firehol/firehol/statuses/df09d75bcc615186e6e8a2e297492b7031fdce29"}}}}