{"action":"created","comment":{"url":"https://api.github.com/repos/OrchardCMS/Orchard/pulls/comments/63226432","id":63226432,"diff_hunk":"@@ -0,0 +1,35 @@\n+﻿using Orchard.Environment.Features;\n+using Orchard.Localization;\n+using Orchard.UI.Admin.Notification;\n+using Orchard.UI.Notify;\n+using System.Collections.Generic;\n+using System.Linq;\n+\n+namespace Orchard.Redis.Configuration {\n+    public class RedisCacheNotificationProvider : INotificationProvider {\n+        private readonly RedisConnectionProvider _redisConnectionProvider;\n+        private readonly FeatureManager _featureManager;\n+\n+        public RedisCacheNotificationProvider(FeatureManager featureManager, RedisConnectionProvider redisConnectionProvider) {\n+            _redisConnectionProvider = redisConnectionProvider;\n+            _featureManager = featureManager;\n+            T = NullLocalizer.Instance;\n+        }\n+\n+        public Localizer T { get; set; }\n+\n+        public IEnumerable<NotifyEntry> GetNotifications() {\n+            //verify if module is enabled first\n+            if (!_featureManager.GetEnabledFeatures().Where(f => f.Id == \"Orchard.Redis.Caching\").Any()) {","path":"src/Orchard.Web/Modules/Orchard.Redis/Services/RedisCacheNotificationProvider.cs","position":23,"original_position":23,"commit_id":"e8f6bce7a8d6cb8fac9bbbdf4c6a59266946470f","original_commit_id":"e8f6bce7a8d6cb8fac9bbbdf4c6a59266946470f","user":{"login":"sebastienros","id":1165805,"avatar_url":"https://avatars.githubusercontent.com/u/1165805?v=3","gravatar_id":"","url":"https://api.github.com/users/sebastienros","html_url":"https://github.com/sebastienros","followers_url":"https://api.github.com/users/sebastienros/followers","following_url":"https://api.github.com/users/sebastienros/following{/other_user}","gists_url":"https://api.github.com/users/sebastienros/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastienros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastienros/subscriptions","organizations_url":"https://api.github.com/users/sebastienros/orgs","repos_url":"https://api.github.com/users/sebastienros/repos","events_url":"https://api.github.com/users/sebastienros/events{/privacy}","received_events_url":"https://api.github.com/users/sebastienros/received_events","type":"User","site_admin":false},"body":"Wrong, you just need [OrchardFeature(\"Orchard.Redis.Caching\")] on the class. Look at the service for the same feature for an example.","created_at":"2016-05-13T18:05:43Z","updated_at":"2016-05-13T18:05:43Z","html_url":"https://github.com/OrchardCMS/Orchard/pull/6876#discussion_r63226432","pull_request_url":"https://api.github.com/repos/OrchardCMS/Orchard/pulls/6876","_links":{"self":{"href":"https://api.github.com/repos/OrchardCMS/Orchard/pulls/comments/63226432"},"html":{"href":"https://github.com/OrchardCMS/Orchard/pull/6876#discussion_r63226432"},"pull_request":{"href":"https://api.github.com/repos/OrchardCMS/Orchard/pulls/6876"}}},"pull_request":{"url":"https://api.github.com/repos/OrchardCMS/Orchard/pulls/6876","id":69258809,"html_url":"https://github.com/OrchardCMS/Orchard/pull/6876","diff_url":"https://github.com/OrchardCMS/Orchard/pull/6876.diff","patch_url":"https://github.com/OrchardCMS/Orchard/pull/6876.patch","issue_url":"https://api.github.com/repos/OrchardCMS/Orchard/issues/6876","number":6876,"state":"open","locked":false,"title":"Adding warning notification if Redis configuration string is not set …","user":{"login":"Skrypt","id":3228637,"avatar_url":"https://avatars.githubusercontent.com/u/3228637?v=3","gravatar_id":"","url":"https://api.github.com/users/Skrypt","html_url":"https://github.com/Skrypt","followers_url":"https://api.github.com/users/Skrypt/followers","following_url":"https://api.github.com/users/Skrypt/following{/other_user}","gists_url":"https://api.github.com/users/Skrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/Skrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Skrypt/subscriptions","organizations_url":"https://api.github.com/users/Skrypt/orgs","repos_url":"https://api.github.com/users/Skrypt/repos","events_url":"https://api.github.com/users/Skrypt/events{/privacy}","received_events_url":"https://api.github.com/users/Skrypt/received_events","type":"User","site_admin":false},"body":"…instead of throwing an exception and making the whole admin/website crash.\r\n\r\n![orchard manage aliases manage aliases](https://cloud.githubusercontent.com/assets/3228637/15099590/6162cf0c-1527-11e6-9828-77867a712b27.png)\r\n","created_at":"2016-05-08T02:38:55Z","updated_at":"2016-05-13T18:05:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"36b74eabc3f391b5c081089b791678a30bc629f9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OrchardCMS/Orchard/pulls/6876/commits","review_comments_url":"https://api.github.com/repos/OrchardCMS/Orchard/pulls/6876/comments","review_comment_url":"https://api.github.com/repos/OrchardCMS/Orchard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OrchardCMS/Orchard/issues/6876/comments","statuses_url":"https://api.github.com/repos/OrchardCMS/Orchard/statuses/e8f6bce7a8d6cb8fac9bbbdf4c6a59266946470f","head":{"label":"Skrypt:feature/redis-notifier","ref":"feature/redis-notifier","sha":"e8f6bce7a8d6cb8fac9bbbdf4c6a59266946470f","user":{"login":"Skrypt","id":3228637,"avatar_url":"https://avatars.githubusercontent.com/u/3228637?v=3","gravatar_id":"","url":"https://api.github.com/users/Skrypt","html_url":"https://github.com/Skrypt","followers_url":"https://api.github.com/users/Skrypt/followers","following_url":"https://api.github.com/users/Skrypt/following{/other_user}","gists_url":"https://api.github.com/users/Skrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/Skrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Skrypt/subscriptions","organizations_url":"https://api.github.com/users/Skrypt/orgs","repos_url":"https://api.github.com/users/Skrypt/repos","events_url":"https://api.github.com/users/Skrypt/events{/privacy}","received_events_url":"https://api.github.com/users/Skrypt/received_events","type":"User","site_admin":false},"repo":{"id":39158831,"name":"Orchard","full_name":"Skrypt/Orchard","owner":{"login":"Skrypt","id":3228637,"avatar_url":"https://avatars.githubusercontent.com/u/3228637?v=3","gravatar_id":"","url":"https://api.github.com/users/Skrypt","html_url":"https://github.com/Skrypt","followers_url":"https://api.github.com/users/Skrypt/followers","following_url":"https://api.github.com/users/Skrypt/following{/other_user}","gists_url":"https://api.github.com/users/Skrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/Skrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Skrypt/subscriptions","organizations_url":"https://api.github.com/users/Skrypt/orgs","repos_url":"https://api.github.com/users/Skrypt/repos","events_url":"https://api.github.com/users/Skrypt/events{/privacy}","received_events_url":"https://api.github.com/users/Skrypt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Skrypt/Orchard","description":"Orchard is a free, open source, community-focused Content Management System built on the ASP.NET MVC platform.","fork":true,"url":"https://api.github.com/repos/Skrypt/Orchard","forks_url":"https://api.github.com/repos/Skrypt/Orchard/forks","keys_url":"https://api.github.com/repos/Skrypt/Orchard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Skrypt/Orchard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Skrypt/Orchard/teams","hooks_url":"https://api.github.com/repos/Skrypt/Orchard/hooks","issue_events_url":"https://api.github.com/repos/Skrypt/Orchard/issues/events{/number}","events_url":"https://api.github.com/repos/Skrypt/Orchard/events","assignees_url":"https://api.github.com/repos/Skrypt/Orchard/assignees{/user}","branches_url":"https://api.github.com/repos/Skrypt/Orchard/branches{/branch}","tags_url":"https://api.github.com/repos/Skrypt/Orchard/tags","blobs_url":"https://api.github.com/repos/Skrypt/Orchard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Skrypt/Orchard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Skrypt/Orchard/git/refs{/sha}","trees_url":"https://api.github.com/repos/Skrypt/Orchard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Skrypt/Orchard/statuses/{sha}","languages_url":"https://api.github.com/repos/Skrypt/Orchard/languages","stargazers_url":"https://api.github.com/repos/Skrypt/Orchard/stargazers","contributors_url":"https://api.github.com/repos/Skrypt/Orchard/contributors","subscribers_url":"https://api.github.com/repos/Skrypt/Orchard/subscribers","subscription_url":"https://api.github.com/repos/Skrypt/Orchard/subscription","commits_url":"https://api.github.com/repos/Skrypt/Orchard/commits{/sha}","git_commits_url":"https://api.github.com/repos/Skrypt/Orchard/git/commits{/sha}","comments_url":"https://api.github.com/repos/Skrypt/Orchard/comments{/number}","issue_comment_url":"https://api.github.com/repos/Skrypt/Orchard/issues/comments{/number}","contents_url":"https://api.github.com/repos/Skrypt/Orchard/contents/{+path}","compare_url":"https://api.github.com/repos/Skrypt/Orchard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Skrypt/Orchard/merges","archive_url":"https://api.github.com/repos/Skrypt/Orchard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Skrypt/Orchard/downloads","issues_url":"https://api.github.com/repos/Skrypt/Orchard/issues{/number}","pulls_url":"https://api.github.com/repos/Skrypt/Orchard/pulls{/number}","milestones_url":"https://api.github.com/repos/Skrypt/Orchard/milestones{/number}","notifications_url":"https://api.github.com/repos/Skrypt/Orchard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Skrypt/Orchard/labels{/name}","releases_url":"https://api.github.com/repos/Skrypt/Orchard/releases{/id}","deployments_url":"https://api.github.com/repos/Skrypt/Orchard/deployments","created_at":"2015-07-15T20:13:06Z","updated_at":"2015-07-15T20:13:16Z","pushed_at":"2016-05-13T17:59:08Z","git_url":"git://github.com/Skrypt/Orchard.git","ssh_url":"git@github.com:Skrypt/Orchard.git","clone_url":"https://github.com/Skrypt/Orchard.git","svn_url":"https://github.com/Skrypt/Orchard","homepage":"http://orchardproject.net","size":153518,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"OrchardCMS:dev","ref":"dev","sha":"c8a4def111065c5bb2039638ce9507604ab51e55","user":{"login":"OrchardCMS","id":1159247,"avatar_url":"https://avatars.githubusercontent.com/u/1159247?v=3","gravatar_id":"","url":"https://api.github.com/users/OrchardCMS","html_url":"https://github.com/OrchardCMS","followers_url":"https://api.github.com/users/OrchardCMS/followers","following_url":"https://api.github.com/users/OrchardCMS/following{/other_user}","gists_url":"https://api.github.com/users/OrchardCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OrchardCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrchardCMS/subscriptions","organizations_url":"https://api.github.com/users/OrchardCMS/orgs","repos_url":"https://api.github.com/users/OrchardCMS/repos","events_url":"https://api.github.com/users/OrchardCMS/events{/privacy}","received_events_url":"https://api.github.com/users/OrchardCMS/received_events","type":"Organization","site_admin":false},"repo":{"id":33889464,"name":"Orchard","full_name":"OrchardCMS/Orchard","owner":{"login":"OrchardCMS","id":1159247,"avatar_url":"https://avatars.githubusercontent.com/u/1159247?v=3","gravatar_id":"","url":"https://api.github.com/users/OrchardCMS","html_url":"https://github.com/OrchardCMS","followers_url":"https://api.github.com/users/OrchardCMS/followers","following_url":"https://api.github.com/users/OrchardCMS/following{/other_user}","gists_url":"https://api.github.com/users/OrchardCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OrchardCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrchardCMS/subscriptions","organizations_url":"https://api.github.com/users/OrchardCMS/orgs","repos_url":"https://api.github.com/users/OrchardCMS/repos","events_url":"https://api.github.com/users/OrchardCMS/events{/privacy}","received_events_url":"https://api.github.com/users/OrchardCMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OrchardCMS/Orchard","description":"Orchard is a free, open source, community-focused Content Management System built on the ASP.NET MVC platform.","fork":false,"url":"https://api.github.com/repos/OrchardCMS/Orchard","forks_url":"https://api.github.com/repos/OrchardCMS/Orchard/forks","keys_url":"https://api.github.com/repos/OrchardCMS/Orchard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OrchardCMS/Orchard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OrchardCMS/Orchard/teams","hooks_url":"https://api.github.com/repos/OrchardCMS/Orchard/hooks","issue_events_url":"https://api.github.com/repos/OrchardCMS/Orchard/issues/events{/number}","events_url":"https://api.github.com/repos/OrchardCMS/Orchard/events","assignees_url":"https://api.github.com/repos/OrchardCMS/Orchard/assignees{/user}","branches_url":"https://api.github.com/repos/OrchardCMS/Orchard/branches{/branch}","tags_url":"https://api.github.com/repos/OrchardCMS/Orchard/tags","blobs_url":"https://api.github.com/repos/OrchardCMS/Orchard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OrchardCMS/Orchard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OrchardCMS/Orchard/git/refs{/sha}","trees_url":"https://api.github.com/repos/OrchardCMS/Orchard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OrchardCMS/Orchard/statuses/{sha}","languages_url":"https://api.github.com/repos/OrchardCMS/Orchard/languages","stargazers_url":"https://api.github.com/repos/OrchardCMS/Orchard/stargazers","contributors_url":"https://api.github.com/repos/OrchardCMS/Orchard/contributors","subscribers_url":"https://api.github.com/repos/OrchardCMS/Orchard/subscribers","subscription_url":"https://api.github.com/repos/OrchardCMS/Orchard/subscription","commits_url":"https://api.github.com/repos/OrchardCMS/Orchard/commits{/sha}","git_commits_url":"https://api.github.com/repos/OrchardCMS/Orchard/git/commits{/sha}","comments_url":"https://api.github.com/repos/OrchardCMS/Orchard/comments{/number}","issue_comment_url":"https://api.github.com/repos/OrchardCMS/Orchard/issues/comments{/number}","contents_url":"https://api.github.com/repos/OrchardCMS/Orchard/contents/{+path}","compare_url":"https://api.github.com/repos/OrchardCMS/Orchard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OrchardCMS/Orchard/merges","archive_url":"https://api.github.com/repos/OrchardCMS/Orchard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OrchardCMS/Orchard/downloads","issues_url":"https://api.github.com/repos/OrchardCMS/Orchard/issues{/number}","pulls_url":"https://api.github.com/repos/OrchardCMS/Orchard/pulls{/number}","milestones_url":"https://api.github.com/repos/OrchardCMS/Orchard/milestones{/number}","notifications_url":"https://api.github.com/repos/OrchardCMS/Orchard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OrchardCMS/Orchard/labels{/name}","releases_url":"https://api.github.com/repos/OrchardCMS/Orchard/releases{/id}","deployments_url":"https://api.github.com/repos/OrchardCMS/Orchard/deployments","created_at":"2015-04-13T19:35:52Z","updated_at":"2016-05-13T08:42:17Z","pushed_at":"2016-05-13T17:59:09Z","git_url":"git://github.com/OrchardCMS/Orchard.git","ssh_url":"git@github.com:OrchardCMS/Orchard.git","clone_url":"https://github.com/OrchardCMS/Orchard.git","svn_url":"https://github.com/OrchardCMS/Orchard","homepage":"http://orchardproject.net","size":211586,"stargazers_count":884,"watchers_count":884,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":597,"mirror_url":null,"open_issues_count":1688,"forks":597,"open_issues":1688,"watchers":884,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/OrchardCMS/Orchard/pulls/6876"},"html":{"href":"https://github.com/OrchardCMS/Orchard/pull/6876"},"issue":{"href":"https://api.github.com/repos/OrchardCMS/Orchard/issues/6876"},"comments":{"href":"https://api.github.com/repos/OrchardCMS/Orchard/issues/6876/comments"},"review_comments":{"href":"https://api.github.com/repos/OrchardCMS/Orchard/pulls/6876/comments"},"review_comment":{"href":"https://api.github.com/repos/OrchardCMS/Orchard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OrchardCMS/Orchard/pulls/6876/commits"},"statuses":{"href":"https://api.github.com/repos/OrchardCMS/Orchard/statuses/e8f6bce7a8d6cb8fac9bbbdf4c6a59266946470f"}}}}