{"action":"created","comment":{"url":"https://api.github.com/repos/googleapis/artman/pulls/comments/70894677","id":70894677,"diff_hunk":"@@ -0,0 +1,121 @@\n+# Copyright 2016 Google Inc. All Rights Reserved.\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+# http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n+\n+\"\"\"Pipelines that run GAPIC\"\"\"\n+\n+from pipeline.pipelines import pipeline_base\n+from pipeline.pipelines import package_generation_pipeline\n+from pipeline.tasks import gapic_tasks, format_tasks, protoc_tasks\n+from taskflow.patterns import linear_flow\n+\n+\n+class GapicConfigPipeline(pipeline_base.PipelineBase):\n+\n+    def __init__(self, **kwargs):\n+        kwargs['language'] = ''\n+        super(GapicConfigPipeline, self).__init__(**kwargs)\n+\n+    def do_build_flow(self, **kwargs):\n+        flow = linear_flow.Flow('gapic-configgen')\n+        flow.add(protoc_tasks.ProtoDescGenTask('ProtoDesc', inject=kwargs),\n+                 gapic_tasks.GapicConfigGenTask(\n+                     'GapicConfigGen', inject=kwargs),\n+                 gapic_tasks.GapicConfigMoveTask(\n+                     'GapicConfigMove', inject=kwargs))\n+        return flow\n+\n+    def validate_kwargs(self, **kwargs):\n+        pass\n+\n+\n+class GapicClientPipeline(pipeline_base.PipelineBase):\n+\n+    def __init__(self, **kwargs):\n+        super(GapicClientPipeline, self).__init__(**kwargs)\n+\n+    def do_build_flow(self, **kwargs):\n+        flow = linear_flow.Flow('gapic-codegen')\n+        flow.add(protoc_tasks.ProtoDescGenTask('ProtoDesc', inject=kwargs),\n+                 gapic_tasks.GapicCodeGenTask('GapicCodegen', inject=kwargs),\n+                 format_tasks.make_format_task(\n+                     kwargs['language'], 'GapicFormat', kwargs))\n+        return flow\n+\n+    def validate_kwargs(self, **kwargs):\n+        pass\n+\n+\n+class GapicClientPackagePipeline(pipeline_base.PipelineBase):","path":"pipeline/pipelines/gapic_generation_pipeline.py","position":59,"original_position":59,"commit_id":"be3d24e796a349643ee9204df5a7c34cf35e6c61","original_commit_id":"be3d24e796a349643ee9204df5a7c34cf35e6c61","user":{"login":"geigerj","id":14222439,"avatar_url":"https://avatars.githubusercontent.com/u/14222439?v=3","gravatar_id":"","url":"https://api.github.com/users/geigerj","html_url":"https://github.com/geigerj","followers_url":"https://api.github.com/users/geigerj/followers","following_url":"https://api.github.com/users/geigerj/following{/other_user}","gists_url":"https://api.github.com/users/geigerj/gists{/gist_id}","starred_url":"https://api.github.com/users/geigerj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geigerj/subscriptions","organizations_url":"https://api.github.com/users/geigerj/orgs","repos_url":"https://api.github.com/users/geigerj/repos","events_url":"https://api.github.com/users/geigerj/events{/privacy}","received_events_url":"https://api.github.com/users/geigerj/received_events","type":"User","site_admin":false},"body":"Or I'm wondering if there's a better way to name this -- right now, I find it somewhat unintuitive that `PythonGapicClientPipeline` is a `GapicClientPackagePipeline` that has (via its flow) a `GapicClientPipeline` -- maybe there's someway to reflect this relationship better in the names.\r\n\r\nBut if not, I'm fine leaving it as is, since one of the key points of pipelines is that they may contain other pipelines, which might just naturally lead to situations like this.","created_at":"2016-07-14T22:21:15Z","updated_at":"2016-07-14T22:21:15Z","html_url":"https://github.com/googleapis/artman/pull/44#discussion_r70894677","pull_request_url":"https://api.github.com/repos/googleapis/artman/pulls/44","_links":{"self":{"href":"https://api.github.com/repos/googleapis/artman/pulls/comments/70894677"},"html":{"href":"https://github.com/googleapis/artman/pull/44#discussion_r70894677"},"pull_request":{"href":"https://api.github.com/repos/googleapis/artman/pulls/44"}}},"pull_request":{"url":"https://api.github.com/repos/googleapis/artman/pulls/44","id":76655829,"html_url":"https://github.com/googleapis/artman/pull/44","diff_url":"https://github.com/googleapis/artman/pull/44.diff","patch_url":"https://github.com/googleapis/artman/pull/44.patch","issue_url":"https://api.github.com/repos/googleapis/artman/issues/44","number":44,"state":"open","locked":false,"title":"Restructured artman pipelines","user":{"login":"michaelbausor","id":14846209,"avatar_url":"https://avatars.githubusercontent.com/u/14846209?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelbausor","html_url":"https://github.com/michaelbausor","followers_url":"https://api.github.com/users/michaelbausor/followers","following_url":"https://api.github.com/users/michaelbausor/following{/other_user}","gists_url":"https://api.github.com/users/michaelbausor/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelbausor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelbausor/subscriptions","organizations_url":"https://api.github.com/users/michaelbausor/orgs","repos_url":"https://api.github.com/users/michaelbausor/repos","events_url":"https://api.github.com/users/michaelbausor/events{/privacy}","received_events_url":"https://api.github.com/users/michaelbausor/received_events","type":"User","site_admin":false},"body":"Refactored code_generation_pipeline file into multiple files for gapic, grpc, core and packaging\r\nRestructured pipelines to share flow construction and compose other pipelines instead of always composing tasks\r\nMoved argument parsing into a dedicated task","created_at":"2016-07-07T20:00:32Z","updated_at":"2016-07-14T22:21:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7fc29063e3b6f59da488b3178c06cb78de99d545","assignee":{"login":"shinfan","id":1514780,"avatar_url":"https://avatars.githubusercontent.com/u/1514780?v=3","gravatar_id":"","url":"https://api.github.com/users/shinfan","html_url":"https://github.com/shinfan","followers_url":"https://api.github.com/users/shinfan/followers","following_url":"https://api.github.com/users/shinfan/following{/other_user}","gists_url":"https://api.github.com/users/shinfan/gists{/gist_id}","starred_url":"https://api.github.com/users/shinfan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shinfan/subscriptions","organizations_url":"https://api.github.com/users/shinfan/orgs","repos_url":"https://api.github.com/users/shinfan/repos","events_url":"https://api.github.com/users/shinfan/events{/privacy}","received_events_url":"https://api.github.com/users/shinfan/received_events","type":"User","site_admin":false},"assignees":[{"login":"shinfan","id":1514780,"avatar_url":"https://avatars.githubusercontent.com/u/1514780?v=3","gravatar_id":"","url":"https://api.github.com/users/shinfan","html_url":"https://github.com/shinfan","followers_url":"https://api.github.com/users/shinfan/followers","following_url":"https://api.github.com/users/shinfan/following{/other_user}","gists_url":"https://api.github.com/users/shinfan/gists{/gist_id}","starred_url":"https://api.github.com/users/shinfan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shinfan/subscriptions","organizations_url":"https://api.github.com/users/shinfan/orgs","repos_url":"https://api.github.com/users/shinfan/repos","events_url":"https://api.github.com/users/shinfan/events{/privacy}","received_events_url":"https://api.github.com/users/shinfan/received_events","type":"User","site_admin":false},{"login":"garrettjonesgoogle","id":13341017,"avatar_url":"https://avatars.githubusercontent.com/u/13341017?v=3","gravatar_id":"","url":"https://api.github.com/users/garrettjonesgoogle","html_url":"https://github.com/garrettjonesgoogle","followers_url":"https://api.github.com/users/garrettjonesgoogle/followers","following_url":"https://api.github.com/users/garrettjonesgoogle/following{/other_user}","gists_url":"https://api.github.com/users/garrettjonesgoogle/gists{/gist_id}","starred_url":"https://api.github.com/users/garrettjonesgoogle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garrettjonesgoogle/subscriptions","organizations_url":"https://api.github.com/users/garrettjonesgoogle/orgs","repos_url":"https://api.github.com/users/garrettjonesgoogle/repos","events_url":"https://api.github.com/users/garrettjonesgoogle/events{/privacy}","received_events_url":"https://api.github.com/users/garrettjonesgoogle/received_events","type":"User","site_admin":false},{"login":"geigerj","id":14222439,"avatar_url":"https://avatars.githubusercontent.com/u/14222439?v=3","gravatar_id":"","url":"https://api.github.com/users/geigerj","html_url":"https://github.com/geigerj","followers_url":"https://api.github.com/users/geigerj/followers","following_url":"https://api.github.com/users/geigerj/following{/other_user}","gists_url":"https://api.github.com/users/geigerj/gists{/gist_id}","starred_url":"https://api.github.com/users/geigerj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geigerj/subscriptions","organizations_url":"https://api.github.com/users/geigerj/orgs","repos_url":"https://api.github.com/users/geigerj/repos","events_url":"https://api.github.com/users/geigerj/events{/privacy}","received_events_url":"https://api.github.com/users/geigerj/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/googleapis/artman/pulls/44/commits","review_comments_url":"https://api.github.com/repos/googleapis/artman/pulls/44/comments","review_comment_url":"https://api.github.com/repos/googleapis/artman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googleapis/artman/issues/44/comments","statuses_url":"https://api.github.com/repos/googleapis/artman/statuses/be3d24e796a349643ee9204df5a7c34cf35e6c61","head":{"label":"michaelbausor:master","ref":"master","sha":"be3d24e796a349643ee9204df5a7c34cf35e6c61","user":{"login":"michaelbausor","id":14846209,"avatar_url":"https://avatars.githubusercontent.com/u/14846209?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelbausor","html_url":"https://github.com/michaelbausor","followers_url":"https://api.github.com/users/michaelbausor/followers","following_url":"https://api.github.com/users/michaelbausor/following{/other_user}","gists_url":"https://api.github.com/users/michaelbausor/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelbausor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelbausor/subscriptions","organizations_url":"https://api.github.com/users/michaelbausor/orgs","repos_url":"https://api.github.com/users/michaelbausor/repos","events_url":"https://api.github.com/users/michaelbausor/events{/privacy}","received_events_url":"https://api.github.com/users/michaelbausor/received_events","type":"User","site_admin":false},"repo":{"id":55555691,"name":"artman","full_name":"michaelbausor/artman","owner":{"login":"michaelbausor","id":14846209,"avatar_url":"https://avatars.githubusercontent.com/u/14846209?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelbausor","html_url":"https://github.com/michaelbausor","followers_url":"https://api.github.com/users/michaelbausor/followers","following_url":"https://api.github.com/users/michaelbausor/following{/other_user}","gists_url":"https://api.github.com/users/michaelbausor/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelbausor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelbausor/subscriptions","organizations_url":"https://api.github.com/users/michaelbausor/orgs","repos_url":"https://api.github.com/users/michaelbausor/repos","events_url":"https://api.github.com/users/michaelbausor/events{/privacy}","received_events_url":"https://api.github.com/users/michaelbausor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/michaelbausor/artman","description":"","fork":true,"url":"https://api.github.com/repos/michaelbausor/artman","forks_url":"https://api.github.com/repos/michaelbausor/artman/forks","keys_url":"https://api.github.com/repos/michaelbausor/artman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/michaelbausor/artman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/michaelbausor/artman/teams","hooks_url":"https://api.github.com/repos/michaelbausor/artman/hooks","issue_events_url":"https://api.github.com/repos/michaelbausor/artman/issues/events{/number}","events_url":"https://api.github.com/repos/michaelbausor/artman/events","assignees_url":"https://api.github.com/repos/michaelbausor/artman/assignees{/user}","branches_url":"https://api.github.com/repos/michaelbausor/artman/branches{/branch}","tags_url":"https://api.github.com/repos/michaelbausor/artman/tags","blobs_url":"https://api.github.com/repos/michaelbausor/artman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/michaelbausor/artman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/michaelbausor/artman/git/refs{/sha}","trees_url":"https://api.github.com/repos/michaelbausor/artman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/michaelbausor/artman/statuses/{sha}","languages_url":"https://api.github.com/repos/michaelbausor/artman/languages","stargazers_url":"https://api.github.com/repos/michaelbausor/artman/stargazers","contributors_url":"https://api.github.com/repos/michaelbausor/artman/contributors","subscribers_url":"https://api.github.com/repos/michaelbausor/artman/subscribers","subscription_url":"https://api.github.com/repos/michaelbausor/artman/subscription","commits_url":"https://api.github.com/repos/michaelbausor/artman/commits{/sha}","git_commits_url":"https://api.github.com/repos/michaelbausor/artman/git/commits{/sha}","comments_url":"https://api.github.com/repos/michaelbausor/artman/comments{/number}","issue_comment_url":"https://api.github.com/repos/michaelbausor/artman/issues/comments{/number}","contents_url":"https://api.github.com/repos/michaelbausor/artman/contents/{+path}","compare_url":"https://api.github.com/repos/michaelbausor/artman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/michaelbausor/artman/merges","archive_url":"https://api.github.com/repos/michaelbausor/artman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/michaelbausor/artman/downloads","issues_url":"https://api.github.com/repos/michaelbausor/artman/issues{/number}","pulls_url":"https://api.github.com/repos/michaelbausor/artman/pulls{/number}","milestones_url":"https://api.github.com/repos/michaelbausor/artman/milestones{/number}","notifications_url":"https://api.github.com/repos/michaelbausor/artman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/michaelbausor/artman/labels{/name}","releases_url":"https://api.github.com/repos/michaelbausor/artman/releases{/id}","deployments_url":"https://api.github.com/repos/michaelbausor/artman/deployments","created_at":"2016-04-05T21:45:25Z","updated_at":"2016-05-02T21:37:16Z","pushed_at":"2016-07-08T00:28:21Z","git_url":"git://github.com/michaelbausor/artman.git","ssh_url":"git@github.com:michaelbausor/artman.git","clone_url":"https://github.com/michaelbausor/artman.git","svn_url":"https://github.com/michaelbausor/artman","homepage":null,"size":231,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"googleapis:master","ref":"master","sha":"37de64c81e613163c6a17b5cc13b93fd8205dddf","user":{"login":"googleapis","id":16785467,"avatar_url":"https://avatars.githubusercontent.com/u/16785467?v=3","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"repo":{"id":55101236,"name":"artman","full_name":"googleapis/artman","owner":{"login":"googleapis","id":16785467,"avatar_url":"https://avatars.githubusercontent.com/u/16785467?v=3","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googleapis/artman","description":"Google API Artifact manager","fork":false,"url":"https://api.github.com/repos/googleapis/artman","forks_url":"https://api.github.com/repos/googleapis/artman/forks","keys_url":"https://api.github.com/repos/googleapis/artman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googleapis/artman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googleapis/artman/teams","hooks_url":"https://api.github.com/repos/googleapis/artman/hooks","issue_events_url":"https://api.github.com/repos/googleapis/artman/issues/events{/number}","events_url":"https://api.github.com/repos/googleapis/artman/events","assignees_url":"https://api.github.com/repos/googleapis/artman/assignees{/user}","branches_url":"https://api.github.com/repos/googleapis/artman/branches{/branch}","tags_url":"https://api.github.com/repos/googleapis/artman/tags","blobs_url":"https://api.github.com/repos/googleapis/artman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googleapis/artman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googleapis/artman/git/refs{/sha}","trees_url":"https://api.github.com/repos/googleapis/artman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googleapis/artman/statuses/{sha}","languages_url":"https://api.github.com/repos/googleapis/artman/languages","stargazers_url":"https://api.github.com/repos/googleapis/artman/stargazers","contributors_url":"https://api.github.com/repos/googleapis/artman/contributors","subscribers_url":"https://api.github.com/repos/googleapis/artman/subscribers","subscription_url":"https://api.github.com/repos/googleapis/artman/subscription","commits_url":"https://api.github.com/repos/googleapis/artman/commits{/sha}","git_commits_url":"https://api.github.com/repos/googleapis/artman/git/commits{/sha}","comments_url":"https://api.github.com/repos/googleapis/artman/comments{/number}","issue_comment_url":"https://api.github.com/repos/googleapis/artman/issues/comments{/number}","contents_url":"https://api.github.com/repos/googleapis/artman/contents/{+path}","compare_url":"https://api.github.com/repos/googleapis/artman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googleapis/artman/merges","archive_url":"https://api.github.com/repos/googleapis/artman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googleapis/artman/downloads","issues_url":"https://api.github.com/repos/googleapis/artman/issues{/number}","pulls_url":"https://api.github.com/repos/googleapis/artman/pulls{/number}","milestones_url":"https://api.github.com/repos/googleapis/artman/milestones{/number}","notifications_url":"https://api.github.com/repos/googleapis/artman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googleapis/artman/labels{/name}","releases_url":"https://api.github.com/repos/googleapis/artman/releases{/id}","deployments_url":"https://api.github.com/repos/googleapis/artman/deployments","created_at":"2016-03-30T22:09:32Z","updated_at":"2016-05-03T00:46:17Z","pushed_at":"2016-07-14T21:26:53Z","git_url":"git://github.com/googleapis/artman.git","ssh_url":"git@github.com:googleapis/artman.git","clone_url":"https://github.com/googleapis/artman.git","svn_url":"https://github.com/googleapis/artman","homepage":"","size":269,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":12,"forks":12,"open_issues":12,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googleapis/artman/pulls/44"},"html":{"href":"https://github.com/googleapis/artman/pull/44"},"issue":{"href":"https://api.github.com/repos/googleapis/artman/issues/44"},"comments":{"href":"https://api.github.com/repos/googleapis/artman/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/googleapis/artman/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/googleapis/artman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googleapis/artman/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/googleapis/artman/statuses/be3d24e796a349643ee9204df5a7c34cf35e6c61"}}}}
{"actor":{"display_login":"geigerj"}}