{"action":"created","comment":{"url":"https://api.github.com/repos/mono/mono/pulls/comments/92402095","pull_request_review_id":12915912,"id":92402095,"diff_hunk":"@@ -2981,9 +2986,13 @@ MONO_SIG_HANDLER_FUNC (, mono_sigint_signal_handler)\n \tMonoException *exc;\n \tMONO_SIG_HANDLER_GET_CONTEXT;\n \n+\tMONO_ENTER_GC_UNSAFE_UNBALANCED;","path":"mono/mini/mini-runtime.c","position":35,"original_position":35,"commit_id":"a3dec8781867e73f845ccbf019fef2912f8b3c76","original_commit_id":"a3dec8781867e73f845ccbf019fef2912f8b3c76","user":{"login":"ludovic-henry","id":660779,"avatar_url":"https://avatars.githubusercontent.com/u/660779?v=3","gravatar_id":"","url":"https://api.github.com/users/ludovic-henry","html_url":"https://github.com/ludovic-henry","followers_url":"https://api.github.com/users/ludovic-henry/followers","following_url":"https://api.github.com/users/ludovic-henry/following{/other_user}","gists_url":"https://api.github.com/users/ludovic-henry/gists{/gist_id}","starred_url":"https://api.github.com/users/ludovic-henry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ludovic-henry/subscriptions","organizations_url":"https://api.github.com/users/ludovic-henry/orgs","repos_url":"https://api.github.com/users/ludovic-henry/repos","events_url":"https://api.github.com/users/ludovic-henry/events{/privacy}","received_events_url":"https://api.github.com/users/ludovic-henry/received_events","type":"User","site_admin":false},"body":"This conflicts with https://github.com/mono/mono/pull/4132/files#diff-307195a8afdfeac6e3df25eef5aaf9d6R2865","created_at":"2016-12-14T14:24:31Z","updated_at":"2016-12-14T14:25:11Z","html_url":"https://github.com/mono/mono/pull/4142#discussion_r92402095","pull_request_url":"https://api.github.com/repos/mono/mono/pulls/4142","_links":{"self":{"href":"https://api.github.com/repos/mono/mono/pulls/comments/92402095"},"html":{"href":"https://github.com/mono/mono/pull/4142#discussion_r92402095"},"pull_request":{"href":"https://api.github.com/repos/mono/mono/pulls/4142"}}},"pull_request":{"url":"https://api.github.com/repos/mono/mono/pulls/4142","id":97939749,"html_url":"https://github.com/mono/mono/pull/4142","diff_url":"https://github.com/mono/mono/pull/4142.diff","patch_url":"https://github.com/mono/mono/pull/4142.patch","issue_url":"https://api.github.com/repos/mono/mono/issues/4142","number":4142,"state":"open","locked":false,"title":"[coop] add GC unsafe state transitions to signal handlers","user":{"login":"lewurm","id":75403,"avatar_url":"https://avatars.githubusercontent.com/u/75403?v=3","gravatar_id":"","url":"https://api.github.com/users/lewurm","html_url":"https://github.com/lewurm","followers_url":"https://api.github.com/users/lewurm/followers","following_url":"https://api.github.com/users/lewurm/following{/other_user}","gists_url":"https://api.github.com/users/lewurm/gists{/gist_id}","starred_url":"https://api.github.com/users/lewurm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lewurm/subscriptions","organizations_url":"https://api.github.com/users/lewurm/orgs","repos_url":"https://api.github.com/users/lewurm/repos","events_url":"https://api.github.com/users/lewurm/events{/privacy}","received_events_url":"https://api.github.com/users/lewurm/received_events","type":"User","site_admin":false},"body":"Not sure if this is correct for the `SIGFPE` handler.  We do need to cover every exit, right? \r\n\r\nAlso missing: adding those macros to the `SIGSEGV` handler.\r\n\r\n/cc @ludovic-henry ","created_at":"2016-12-14T12:06:21Z","updated_at":"2016-12-14T14:25:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3c792f507307645d64f060b2e7ed2e2ddec829d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mono/mono/pulls/4142/commits","review_comments_url":"https://api.github.com/repos/mono/mono/pulls/4142/comments","review_comment_url":"https://api.github.com/repos/mono/mono/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mono/mono/issues/4142/comments","statuses_url":"https://api.github.com/repos/mono/mono/statuses/a3dec8781867e73f845ccbf019fef2912f8b3c76","head":{"label":"lewurm:unsafe-state-sigfpe-sigint","ref":"unsafe-state-sigfpe-sigint","sha":"a3dec8781867e73f845ccbf019fef2912f8b3c76","user":{"login":"lewurm","id":75403,"avatar_url":"https://avatars.githubusercontent.com/u/75403?v=3","gravatar_id":"","url":"https://api.github.com/users/lewurm","html_url":"https://github.com/lewurm","followers_url":"https://api.github.com/users/lewurm/followers","following_url":"https://api.github.com/users/lewurm/following{/other_user}","gists_url":"https://api.github.com/users/lewurm/gists{/gist_id}","starred_url":"https://api.github.com/users/lewurm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lewurm/subscriptions","organizations_url":"https://api.github.com/users/lewurm/orgs","repos_url":"https://api.github.com/users/lewurm/repos","events_url":"https://api.github.com/users/lewurm/events{/privacy}","received_events_url":"https://api.github.com/users/lewurm/received_events","type":"User","site_admin":false},"repo":{"id":39593825,"name":"mono","full_name":"lewurm/mono","owner":{"login":"lewurm","id":75403,"avatar_url":"https://avatars.githubusercontent.com/u/75403?v=3","gravatar_id":"","url":"https://api.github.com/users/lewurm","html_url":"https://github.com/lewurm","followers_url":"https://api.github.com/users/lewurm/followers","following_url":"https://api.github.com/users/lewurm/following{/other_user}","gists_url":"https://api.github.com/users/lewurm/gists{/gist_id}","starred_url":"https://api.github.com/users/lewurm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lewurm/subscriptions","organizations_url":"https://api.github.com/users/lewurm/orgs","repos_url":"https://api.github.com/users/lewurm/repos","events_url":"https://api.github.com/users/lewurm/events{/privacy}","received_events_url":"https://api.github.com/users/lewurm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lewurm/mono","description":"Mono open source ECMA CLI, C# and .NET implementation.","fork":true,"url":"https://api.github.com/repos/lewurm/mono","forks_url":"https://api.github.com/repos/lewurm/mono/forks","keys_url":"https://api.github.com/repos/lewurm/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lewurm/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lewurm/mono/teams","hooks_url":"https://api.github.com/repos/lewurm/mono/hooks","issue_events_url":"https://api.github.com/repos/lewurm/mono/issues/events{/number}","events_url":"https://api.github.com/repos/lewurm/mono/events","assignees_url":"https://api.github.com/repos/lewurm/mono/assignees{/user}","branches_url":"https://api.github.com/repos/lewurm/mono/branches{/branch}","tags_url":"https://api.github.com/repos/lewurm/mono/tags","blobs_url":"https://api.github.com/repos/lewurm/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lewurm/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lewurm/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/lewurm/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lewurm/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/lewurm/mono/languages","stargazers_url":"https://api.github.com/repos/lewurm/mono/stargazers","contributors_url":"https://api.github.com/repos/lewurm/mono/contributors","subscribers_url":"https://api.github.com/repos/lewurm/mono/subscribers","subscription_url":"https://api.github.com/repos/lewurm/mono/subscription","commits_url":"https://api.github.com/repos/lewurm/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/lewurm/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/lewurm/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/lewurm/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/lewurm/mono/contents/{+path}","compare_url":"https://api.github.com/repos/lewurm/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lewurm/mono/merges","archive_url":"https://api.github.com/repos/lewurm/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lewurm/mono/downloads","issues_url":"https://api.github.com/repos/lewurm/mono/issues{/number}","pulls_url":"https://api.github.com/repos/lewurm/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/lewurm/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/lewurm/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lewurm/mono/labels{/name}","releases_url":"https://api.github.com/repos/lewurm/mono/releases{/id}","deployments_url":"https://api.github.com/repos/lewurm/mono/deployments","created_at":"2015-07-23T21:24:32Z","updated_at":"2016-04-05T21:44:32Z","pushed_at":"2016-12-14T12:11:30Z","git_url":"git://github.com/lewurm/mono.git","ssh_url":"git@github.com:lewurm/mono.git","clone_url":"https://github.com/lewurm/mono.git","svn_url":"https://github.com/lewurm/mono","homepage":"http://www.mono-project.com/","size":537121,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mono:master","ref":"master","sha":"0b8670e8fbbb1d03cc0b879f288f45cb25572a93","user":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"repo":{"id":791611,"name":"mono","full_name":"mono/mono","owner":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mono/mono","description":"Mono open source ECMA CLI, C# and .NET implementation.","fork":false,"url":"https://api.github.com/repos/mono/mono","forks_url":"https://api.github.com/repos/mono/mono/forks","keys_url":"https://api.github.com/repos/mono/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mono/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mono/mono/teams","hooks_url":"https://api.github.com/repos/mono/mono/hooks","issue_events_url":"https://api.github.com/repos/mono/mono/issues/events{/number}","events_url":"https://api.github.com/repos/mono/mono/events","assignees_url":"https://api.github.com/repos/mono/mono/assignees{/user}","branches_url":"https://api.github.com/repos/mono/mono/branches{/branch}","tags_url":"https://api.github.com/repos/mono/mono/tags","blobs_url":"https://api.github.com/repos/mono/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mono/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mono/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/mono/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mono/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/mono/mono/languages","stargazers_url":"https://api.github.com/repos/mono/mono/stargazers","contributors_url":"https://api.github.com/repos/mono/mono/contributors","subscribers_url":"https://api.github.com/repos/mono/mono/subscribers","subscription_url":"https://api.github.com/repos/mono/mono/subscription","commits_url":"https://api.github.com/repos/mono/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/mono/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/mono/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/mono/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/mono/mono/contents/{+path}","compare_url":"https://api.github.com/repos/mono/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mono/mono/merges","archive_url":"https://api.github.com/repos/mono/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mono/mono/downloads","issues_url":"https://api.github.com/repos/mono/mono/issues{/number}","pulls_url":"https://api.github.com/repos/mono/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/mono/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/mono/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mono/mono/labels{/name}","releases_url":"https://api.github.com/repos/mono/mono/releases{/id}","deployments_url":"https://api.github.com/repos/mono/mono/deployments","created_at":"2010-07-22T18:06:36Z","updated_at":"2016-12-14T03:01:42Z","pushed_at":"2016-12-14T13:45:48Z","git_url":"git://github.com/mono/mono.git","ssh_url":"git@github.com:mono/mono.git","clone_url":"https://github.com/mono/mono.git","svn_url":"https://github.com/mono/mono","homepage":"http://www.mono-project.com/","size":434021,"stargazers_count":5120,"watchers_count":5120,"language":"C#","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2447,"mirror_url":null,"open_issues_count":154,"forks":2447,"open_issues":154,"watchers":5120,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mono/mono/pulls/4142"},"html":{"href":"https://github.com/mono/mono/pull/4142"},"issue":{"href":"https://api.github.com/repos/mono/mono/issues/4142"},"comments":{"href":"https://api.github.com/repos/mono/mono/issues/4142/comments"},"review_comments":{"href":"https://api.github.com/repos/mono/mono/pulls/4142/comments"},"review_comment":{"href":"https://api.github.com/repos/mono/mono/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mono/mono/pulls/4142/commits"},"statuses":{"href":"https://api.github.com/repos/mono/mono/statuses/a3dec8781867e73f845ccbf019fef2912f8b3c76"}}}}
{"actor":{"display_login":"ludovic-henry"}}