{"action":"closed","number":342,"pull_request":{"url":"https://api.github.com/repos/adobe-photoshop/generator-core/pulls/342","id":67272955,"html_url":"https://github.com/adobe-photoshop/generator-core/pull/342","diff_url":"https://github.com/adobe-photoshop/generator-core/pull/342.diff","patch_url":"https://github.com/adobe-photoshop/generator-core/pull/342.patch","issue_url":"https://api.github.com/repos/adobe-photoshop/generator-core/issues/342","number":342,"state":"closed","locked":false,"title":"take clipping into account when determining scale factors","user":{"login":"pineapplespatula","id":1008531,"avatar_url":"https://avatars.githubusercontent.com/u/1008531?v=3","gravatar_id":"","url":"https://api.github.com/users/pineapplespatula","html_url":"https://github.com/pineapplespatula","followers_url":"https://api.github.com/users/pineapplespatula/followers","following_url":"https://api.github.com/users/pineapplespatula/following{/other_user}","gists_url":"https://api.github.com/users/pineapplespatula/gists{/gist_id}","starred_url":"https://api.github.com/users/pineapplespatula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pineapplespatula/subscriptions","organizations_url":"https://api.github.com/users/pineapplespatula/orgs","repos_url":"https://api.github.com/users/pineapplespatula/repos","events_url":"https://api.github.com/users/pineapplespatula/events{/privacy}","received_events_url":"https://api.github.com/users/pineapplespatula/received_events","type":"User","site_admin":false},"body":"@mcilroyc  can you take a look at this. I'm still not happy with this function. and I feel like it does a lot of extra work, but I'm certain it shouldn't be ignoring the clipped case when determining scaleX and scaleY","created_at":"2016-04-20T23:07:59Z","updated_at":"2016-04-21T20:59:55Z","closed_at":"2016-04-21T20:59:55Z","merged_at":"2016-04-21T20:59:55Z","merge_commit_sha":"e83a2e98db08308972a78d8159f4d2cd2e510e37","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/adobe-photoshop/generator-core/pulls/342/commits","review_comments_url":"https://api.github.com/repos/adobe-photoshop/generator-core/pulls/342/comments","review_comment_url":"https://api.github.com/repos/adobe-photoshop/generator-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/adobe-photoshop/generator-core/issues/342/comments","statuses_url":"https://api.github.com/repos/adobe-photoshop/generator-core/statuses/f6861c72421e9f12359e094b99047fc61d67ea32","head":{"label":"adobe-photoshop:jecohen/clippedBounds","ref":"jecohen/clippedBounds","sha":"f6861c72421e9f12359e094b99047fc61d67ea32","user":{"login":"adobe-photoshop","id":4542585,"avatar_url":"https://avatars.githubusercontent.com/u/4542585?v=3","gravatar_id":"","url":"https://api.github.com/users/adobe-photoshop","html_url":"https://github.com/adobe-photoshop","followers_url":"https://api.github.com/users/adobe-photoshop/followers","following_url":"https://api.github.com/users/adobe-photoshop/following{/other_user}","gists_url":"https://api.github.com/users/adobe-photoshop/gists{/gist_id}","starred_url":"https://api.github.com/users/adobe-photoshop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adobe-photoshop/subscriptions","organizations_url":"https://api.github.com/users/adobe-photoshop/orgs","repos_url":"https://api.github.com/users/adobe-photoshop/repos","events_url":"https://api.github.com/users/adobe-photoshop/events{/privacy}","received_events_url":"https://api.github.com/users/adobe-photoshop/received_events","type":"Organization","site_admin":false},"repo":{"id":10320928,"name":"generator-core","full_name":"adobe-photoshop/generator-core","owner":{"login":"adobe-photoshop","id":4542585,"avatar_url":"https://avatars.githubusercontent.com/u/4542585?v=3","gravatar_id":"","url":"https://api.github.com/users/adobe-photoshop","html_url":"https://github.com/adobe-photoshop","followers_url":"https://api.github.com/users/adobe-photoshop/followers","following_url":"https://api.github.com/users/adobe-photoshop/following{/other_user}","gists_url":"https://api.github.com/users/adobe-photoshop/gists{/gist_id}","starred_url":"https://api.github.com/users/adobe-photoshop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adobe-photoshop/subscriptions","organizations_url":"https://api.github.com/users/adobe-photoshop/orgs","repos_url":"https://api.github.com/users/adobe-photoshop/repos","events_url":"https://api.github.com/users/adobe-photoshop/events{/privacy}","received_events_url":"https://api.github.com/users/adobe-photoshop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/adobe-photoshop/generator-core","description":"Core Node.js library for Adobe Photoshop CC's Generator extensibility layer","fork":false,"url":"https://api.github.com/repos/adobe-photoshop/generator-core","forks_url":"https://api.github.com/repos/adobe-photoshop/generator-core/forks","keys_url":"https://api.github.com/repos/adobe-photoshop/generator-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adobe-photoshop/generator-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adobe-photoshop/generator-core/teams","hooks_url":"https://api.github.com/repos/adobe-photoshop/generator-core/hooks","issue_events_url":"https://api.github.com/repos/adobe-photoshop/generator-core/issues/events{/number}","events_url":"https://api.github.com/repos/adobe-photoshop/generator-core/events","assignees_url":"https://api.github.com/repos/adobe-photoshop/generator-core/assignees{/user}","branches_url":"https://api.github.com/repos/adobe-photoshop/generator-core/branches{/branch}","tags_url":"https://api.github.com/repos/adobe-photoshop/generator-core/tags","blobs_url":"https://api.github.com/repos/adobe-photoshop/generator-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adobe-photoshop/generator-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adobe-photoshop/generator-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/adobe-photoshop/generator-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adobe-photoshop/generator-core/statuses/{sha}","languages_url":"https://api.github.com/repos/adobe-photoshop/generator-core/languages","stargazers_url":"https://api.github.com/repos/adobe-photoshop/generator-core/stargazers","contributors_url":"https://api.github.com/repos/adobe-photoshop/generator-core/contributors","subscribers_url":"https://api.github.com/repos/adobe-photoshop/generator-core/subscribers","subscription_url":"https://api.github.com/repos/adobe-photoshop/generator-core/subscription","commits_url":"https://api.github.com/repos/adobe-photoshop/generator-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/adobe-photoshop/generator-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/adobe-photoshop/generator-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/adobe-photoshop/generator-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/adobe-photoshop/generator-core/contents/{+path}","compare_url":"https://api.github.com/repos/adobe-photoshop/generator-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adobe-photoshop/generator-core/merges","archive_url":"https://api.github.com/repos/adobe-photoshop/generator-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adobe-photoshop/generator-core/downloads","issues_url":"https://api.github.com/repos/adobe-photoshop/generator-core/issues{/number}","pulls_url":"https://api.github.com/repos/adobe-photoshop/generator-core/pulls{/number}","milestones_url":"https://api.github.com/repos/adobe-photoshop/generator-core/milestones{/number}","notifications_url":"https://api.github.com/repos/adobe-photoshop/generator-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adobe-photoshop/generator-core/labels{/name}","releases_url":"https://api.github.com/repos/adobe-photoshop/generator-core/releases{/id}","deployments_url":"https://api.github.com/repos/adobe-photoshop/generator-core/deployments","created_at":"2013-05-27T19:10:52Z","updated_at":"2016-04-15T18:00:46Z","pushed_at":"2016-04-21T20:59:55Z","git_url":"git://github.com/adobe-photoshop/generator-core.git","ssh_url":"git@github.com:adobe-photoshop/generator-core.git","clone_url":"https://github.com/adobe-photoshop/generator-core.git","svn_url":"https://github.com/adobe-photoshop/generator-core","homepage":"","size":1115,"stargazers_count":467,"watchers_count":467,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"open_issues_count":54,"forks":55,"open_issues":54,"watchers":467,"default_branch":"master"}},"base":{"label":"adobe-photoshop:master","ref":"master","sha":"21f954a747a5dabcd05cec1694c422ac9b9af585","user":{"login":"adobe-photoshop","id":4542585,"avatar_url":"https://avatars.githubusercontent.com/u/4542585?v=3","gravatar_id":"","url":"https://api.github.com/users/adobe-photoshop","html_url":"https://github.com/adobe-photoshop","followers_url":"https://api.github.com/users/adobe-photoshop/followers","following_url":"https://api.github.com/users/adobe-photoshop/following{/other_user}","gists_url":"https://api.github.com/users/adobe-photoshop/gists{/gist_id}","starred_url":"https://api.github.com/users/adobe-photoshop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adobe-photoshop/subscriptions","organizations_url":"https://api.github.com/users/adobe-photoshop/orgs","repos_url":"https://api.github.com/users/adobe-photoshop/repos","events_url":"https://api.github.com/users/adobe-photoshop/events{/privacy}","received_events_url":"https://api.github.com/users/adobe-photoshop/received_events","type":"Organization","site_admin":false},"repo":{"id":10320928,"name":"generator-core","full_name":"adobe-photoshop/generator-core","owner":{"login":"adobe-photoshop","id":4542585,"avatar_url":"https://avatars.githubusercontent.com/u/4542585?v=3","gravatar_id":"","url":"https://api.github.com/users/adobe-photoshop","html_url":"https://github.com/adobe-photoshop","followers_url":"https://api.github.com/users/adobe-photoshop/followers","following_url":"https://api.github.com/users/adobe-photoshop/following{/other_user}","gists_url":"https://api.github.com/users/adobe-photoshop/gists{/gist_id}","starred_url":"https://api.github.com/users/adobe-photoshop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adobe-photoshop/subscriptions","organizations_url":"https://api.github.com/users/adobe-photoshop/orgs","repos_url":"https://api.github.com/users/adobe-photoshop/repos","events_url":"https://api.github.com/users/adobe-photoshop/events{/privacy}","received_events_url":"https://api.github.com/users/adobe-photoshop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/adobe-photoshop/generator-core","description":"Core Node.js library for Adobe Photoshop CC's Generator extensibility layer","fork":false,"url":"https://api.github.com/repos/adobe-photoshop/generator-core","forks_url":"https://api.github.com/repos/adobe-photoshop/generator-core/forks","keys_url":"https://api.github.com/repos/adobe-photoshop/generator-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adobe-photoshop/generator-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adobe-photoshop/generator-core/teams","hooks_url":"https://api.github.com/repos/adobe-photoshop/generator-core/hooks","issue_events_url":"https://api.github.com/repos/adobe-photoshop/generator-core/issues/events{/number}","events_url":"https://api.github.com/repos/adobe-photoshop/generator-core/events","assignees_url":"https://api.github.com/repos/adobe-photoshop/generator-core/assignees{/user}","branches_url":"https://api.github.com/repos/adobe-photoshop/generator-core/branches{/branch}","tags_url":"https://api.github.com/repos/adobe-photoshop/generator-core/tags","blobs_url":"https://api.github.com/repos/adobe-photoshop/generator-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adobe-photoshop/generator-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adobe-photoshop/generator-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/adobe-photoshop/generator-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adobe-photoshop/generator-core/statuses/{sha}","languages_url":"https://api.github.com/repos/adobe-photoshop/generator-core/languages","stargazers_url":"https://api.github.com/repos/adobe-photoshop/generator-core/stargazers","contributors_url":"https://api.github.com/repos/adobe-photoshop/generator-core/contributors","subscribers_url":"https://api.github.com/repos/adobe-photoshop/generator-core/subscribers","subscription_url":"https://api.github.com/repos/adobe-photoshop/generator-core/subscription","commits_url":"https://api.github.com/repos/adobe-photoshop/generator-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/adobe-photoshop/generator-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/adobe-photoshop/generator-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/adobe-photoshop/generator-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/adobe-photoshop/generator-core/contents/{+path}","compare_url":"https://api.github.com/repos/adobe-photoshop/generator-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adobe-photoshop/generator-core/merges","archive_url":"https://api.github.com/repos/adobe-photoshop/generator-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adobe-photoshop/generator-core/downloads","issues_url":"https://api.github.com/repos/adobe-photoshop/generator-core/issues{/number}","pulls_url":"https://api.github.com/repos/adobe-photoshop/generator-core/pulls{/number}","milestones_url":"https://api.github.com/repos/adobe-photoshop/generator-core/milestones{/number}","notifications_url":"https://api.github.com/repos/adobe-photoshop/generator-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adobe-photoshop/generator-core/labels{/name}","releases_url":"https://api.github.com/repos/adobe-photoshop/generator-core/releases{/id}","deployments_url":"https://api.github.com/repos/adobe-photoshop/generator-core/deployments","created_at":"2013-05-27T19:10:52Z","updated_at":"2016-04-15T18:00:46Z","pushed_at":"2016-04-21T20:59:55Z","git_url":"git://github.com/adobe-photoshop/generator-core.git","ssh_url":"git@github.com:adobe-photoshop/generator-core.git","clone_url":"https://github.com/adobe-photoshop/generator-core.git","svn_url":"https://github.com/adobe-photoshop/generator-core","homepage":"","size":1115,"stargazers_count":467,"watchers_count":467,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"open_issues_count":54,"forks":55,"open_issues":54,"watchers":467,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/adobe-photoshop/generator-core/pulls/342"},"html":{"href":"https://github.com/adobe-photoshop/generator-core/pull/342"},"issue":{"href":"https://api.github.com/repos/adobe-photoshop/generator-core/issues/342"},"comments":{"href":"https://api.github.com/repos/adobe-photoshop/generator-core/issues/342/comments"},"review_comments":{"href":"https://api.github.com/repos/adobe-photoshop/generator-core/pulls/342/comments"},"review_comment":{"href":"https://api.github.com/repos/adobe-photoshop/generator-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/adobe-photoshop/generator-core/pulls/342/commits"},"statuses":{"href":"https://api.github.com/repos/adobe-photoshop/generator-core/statuses/f6861c72421e9f12359e094b99047fc61d67ea32"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mcilroyc","id":1168110,"avatar_url":"https://avatars.githubusercontent.com/u/1168110?v=3","gravatar_id":"","url":"https://api.github.com/users/mcilroyc","html_url":"https://github.com/mcilroyc","followers_url":"https://api.github.com/users/mcilroyc/followers","following_url":"https://api.github.com/users/mcilroyc/following{/other_user}","gists_url":"https://api.github.com/users/mcilroyc/gists{/gist_id}","starred_url":"https://api.github.com/users/mcilroyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcilroyc/subscriptions","organizations_url":"https://api.github.com/users/mcilroyc/orgs","repos_url":"https://api.github.com/users/mcilroyc/repos","events_url":"https://api.github.com/users/mcilroyc/events{/privacy}","received_events_url":"https://api.github.com/users/mcilroyc/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":22,"deletions":20,"changed_files":1}}