{"action":"created","comment":{"url":"https://api.github.com/repos/minetest/minetest/pulls/comments/55922382","id":55922382,"diff_hunk":"@@ -919,11 +921,20 @@ void Server::AsyncRunStep(bool initial_step)\n \t\t\t\tsendRemoveNode(event->p, event->already_known_by_peer,\n \t\t\t\t\t\t&far_players, disable_single_change_sending ? 5 : 30);\n \t\t\t\tbreak;\n-\t\t\tcase MEET_BLOCK_NODE_METADATA_CHANGED:\n-\t\t\t\tinfostream << \"Server: MEET_BLOCK_NODE_METADATA_CHANGED\" << std::endl;\n-\t\t\t\t\t\tprof.add(\"MEET_BLOCK_NODE_METADATA_CHANGED\", 1);\n-\t\t\t\t\t\tsetBlockNotSent(event->p);\n+\t\t\tcase MEET_BLOCK_NODE_METADATA_CHANGED: {\n+\t\t\t\tverbosestream << \"Server: MEET_BLOCK_NODE_METADATA_CHANGED\" << std::endl;\n+\t\t\t\tprof.add(\"MEET_BLOCK_NODE_METADATA_CHANGED\", 1);\n+\t\t\t\t// Don't send the change yet. Collect them to eliminate dupes.\n+\t\t\t\tnode_meta_updates.remove(event->p);\n+\t\t\t\tnode_meta_updates.push_back(event->p);\n+\n+\t\t\t\tif (MapBlock *block = m_env->getMap().getBlockNoCreateNoEx(","path":"src/server.cpp","position":24,"original_position":24,"commit_id":"cee77ecaee3161df3cbcb0b3c8dbf76252c5a9ef","original_commit_id":"cee77ecaee3161df3cbcb0b3c8dbf76252c5a9ef","user":{"login":"rubenwardy","id":2122943,"avatar_url":"https://avatars.githubusercontent.com/u/2122943?v=3","gravatar_id":"","url":"https://api.github.com/users/rubenwardy","html_url":"https://github.com/rubenwardy","followers_url":"https://api.github.com/users/rubenwardy/followers","following_url":"https://api.github.com/users/rubenwardy/following{/other_user}","gists_url":"https://api.github.com/users/rubenwardy/gists{/gist_id}","starred_url":"https://api.github.com/users/rubenwardy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubenwardy/subscriptions","organizations_url":"https://api.github.com/users/rubenwardy/orgs","repos_url":"https://api.github.com/users/rubenwardy/repos","events_url":"https://api.github.com/users/rubenwardy/events{/privacy}","received_events_url":"https://api.github.com/users/rubenwardy/received_events","type":"User","site_admin":false},"body":"Could you split this into an assignment and a check?","created_at":"2016-03-12T14:58:40Z","updated_at":"2016-03-12T14:58:40Z","html_url":"https://github.com/minetest/minetest/pull/3848#discussion_r55922382","pull_request_url":"https://api.github.com/repos/minetest/minetest/pulls/3848","_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments/55922382"},"html":{"href":"https://github.com/minetest/minetest/pull/3848#discussion_r55922382"},"pull_request":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3848"}}},"pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/3848","id":62630482,"html_url":"https://github.com/minetest/minetest/pull/3848","diff_url":"https://github.com/minetest/minetest/pull/3848.diff","patch_url":"https://github.com/minetest/minetest/pull/3848.patch","issue_url":"https://api.github.com/repos/minetest/minetest/issues/3848","number":3848,"state":"open","locked":false,"title":"Send only changed node metadata to clients instead of whole mapblock","user":{"login":"est31","id":8872119,"avatar_url":"https://avatars.githubusercontent.com/u/8872119?v=3","gravatar_id":"","url":"https://api.github.com/users/est31","html_url":"https://github.com/est31","followers_url":"https://api.github.com/users/est31/followers","following_url":"https://api.github.com/users/est31/following{/other_user}","gists_url":"https://api.github.com/users/est31/gists{/gist_id}","starred_url":"https://api.github.com/users/est31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/est31/subscriptions","organizations_url":"https://api.github.com/users/est31/orgs","repos_url":"https://api.github.com/users/est31/repos","events_url":"https://api.github.com/users/est31/events{/privacy}","received_events_url":"https://api.github.com/users/est31/received_events","type":"User","site_admin":false},"body":"Rebased version of  #3775 (and #3166).\r\n\r\nAlso added some of my own improvements. Will squash before merge.","created_at":"2016-03-12T04:06:27Z","updated_at":"2016-03-12T14:58:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bfacebcdeaf7ed67b0caaec605b8f19840965682","assignee":null,"milestone":{"url":"https://api.github.com/repos/minetest/minetest/milestones/7","html_url":"https://github.com/minetest/minetest/milestones/0.4.14","labels_url":"https://api.github.com/repos/minetest/minetest/milestones/7/labels","id":1601315,"number":7,"title":"0.4.14","description":"This milestone for issues which should get resolved before the 0.4.14 release.","creator":{"login":"kahrl","id":630411,"avatar_url":"https://avatars.githubusercontent.com/u/630411?v=3","gravatar_id":"","url":"https://api.github.com/users/kahrl","html_url":"https://github.com/kahrl","followers_url":"https://api.github.com/users/kahrl/followers","following_url":"https://api.github.com/users/kahrl/following{/other_user}","gists_url":"https://api.github.com/users/kahrl/gists{/gist_id}","starred_url":"https://api.github.com/users/kahrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kahrl/subscriptions","organizations_url":"https://api.github.com/users/kahrl/orgs","repos_url":"https://api.github.com/users/kahrl/repos","events_url":"https://api.github.com/users/kahrl/events{/privacy}","received_events_url":"https://api.github.com/users/kahrl/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":22,"state":"open","created_at":"2016-02-23T23:07:27Z","updated_at":"2016-03-12T04:09:48Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/minetest/minetest/pulls/3848/commits","review_comments_url":"https://api.github.com/repos/minetest/minetest/pulls/3848/comments","review_comment_url":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/3848/comments","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/cee77ecaee3161df3cbcb0b3c8dbf76252c5a9ef","head":{"label":"est31:meta_stuff","ref":"meta_stuff","sha":"cee77ecaee3161df3cbcb0b3c8dbf76252c5a9ef","user":{"login":"est31","id":8872119,"avatar_url":"https://avatars.githubusercontent.com/u/8872119?v=3","gravatar_id":"","url":"https://api.github.com/users/est31","html_url":"https://github.com/est31","followers_url":"https://api.github.com/users/est31/followers","following_url":"https://api.github.com/users/est31/following{/other_user}","gists_url":"https://api.github.com/users/est31/gists{/gist_id}","starred_url":"https://api.github.com/users/est31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/est31/subscriptions","organizations_url":"https://api.github.com/users/est31/orgs","repos_url":"https://api.github.com/users/est31/repos","events_url":"https://api.github.com/users/est31/events{/privacy}","received_events_url":"https://api.github.com/users/est31/received_events","type":"User","site_admin":false},"repo":{"id":28881630,"name":"minetest","full_name":"est31/minetest","owner":{"login":"est31","id":8872119,"avatar_url":"https://avatars.githubusercontent.com/u/8872119?v=3","gravatar_id":"","url":"https://api.github.com/users/est31","html_url":"https://github.com/est31","followers_url":"https://api.github.com/users/est31/followers","following_url":"https://api.github.com/users/est31/following{/other_user}","gists_url":"https://api.github.com/users/est31/gists{/gist_id}","starred_url":"https://api.github.com/users/est31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/est31/subscriptions","organizations_url":"https://api.github.com/users/est31/orgs","repos_url":"https://api.github.com/users/est31/repos","events_url":"https://api.github.com/users/est31/events{/privacy}","received_events_url":"https://api.github.com/users/est31/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/est31/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also [minetest_game](https://github.com/minetest/minetest_game)]","fork":true,"url":"https://api.github.com/repos/est31/minetest","forks_url":"https://api.github.com/repos/est31/minetest/forks","keys_url":"https://api.github.com/repos/est31/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/est31/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/est31/minetest/teams","hooks_url":"https://api.github.com/repos/est31/minetest/hooks","issue_events_url":"https://api.github.com/repos/est31/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/est31/minetest/events","assignees_url":"https://api.github.com/repos/est31/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/est31/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/est31/minetest/tags","blobs_url":"https://api.github.com/repos/est31/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/est31/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/est31/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/est31/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/est31/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/est31/minetest/languages","stargazers_url":"https://api.github.com/repos/est31/minetest/stargazers","contributors_url":"https://api.github.com/repos/est31/minetest/contributors","subscribers_url":"https://api.github.com/repos/est31/minetest/subscribers","subscription_url":"https://api.github.com/repos/est31/minetest/subscription","commits_url":"https://api.github.com/repos/est31/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/est31/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/est31/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/est31/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/est31/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/est31/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/est31/minetest/merges","archive_url":"https://api.github.com/repos/est31/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/est31/minetest/downloads","issues_url":"https://api.github.com/repos/est31/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/est31/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/est31/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/est31/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/est31/minetest/labels{/name}","releases_url":"https://api.github.com/repos/est31/minetest/releases{/id}","deployments_url":"https://api.github.com/repos/est31/minetest/deployments","created_at":"2015-01-06T20:18:47Z","updated_at":"2016-03-03T07:19:14Z","pushed_at":"2016-03-12T05:24:55Z","git_url":"git://github.com/est31/minetest.git","ssh_url":"git@github.com:est31/minetest.git","clone_url":"https://github.com/est31/minetest.git","svn_url":"https://github.com/est31/minetest","homepage":"http://minetest.net/","size":46185,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":3,"default_branch":"github_stupid_forcepush_annoying"}},"base":{"label":"minetest:master","ref":"master","sha":"0d2df732e5c5075cd8848b9a9530865430630bfe","user":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"repo":{"id":2168780,"name":"minetest","full_name":"minetest/minetest","owner":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minetest/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":false,"url":"https://api.github.com/repos/minetest/minetest","forks_url":"https://api.github.com/repos/minetest/minetest/forks","keys_url":"https://api.github.com/repos/minetest/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minetest/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minetest/minetest/teams","hooks_url":"https://api.github.com/repos/minetest/minetest/hooks","issue_events_url":"https://api.github.com/repos/minetest/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/minetest/minetest/events","assignees_url":"https://api.github.com/repos/minetest/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/minetest/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/minetest/minetest/tags","blobs_url":"https://api.github.com/repos/minetest/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minetest/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minetest/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/minetest/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/minetest/minetest/languages","stargazers_url":"https://api.github.com/repos/minetest/minetest/stargazers","contributors_url":"https://api.github.com/repos/minetest/minetest/contributors","subscribers_url":"https://api.github.com/repos/minetest/minetest/subscribers","subscription_url":"https://api.github.com/repos/minetest/minetest/subscription","commits_url":"https://api.github.com/repos/minetest/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/minetest/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/minetest/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/minetest/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/minetest/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/minetest/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minetest/minetest/merges","archive_url":"https://api.github.com/repos/minetest/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minetest/minetest/downloads","issues_url":"https://api.github.com/repos/minetest/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/minetest/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/minetest/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/minetest/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minetest/minetest/labels{/name}","releases_url":"https://api.github.com/repos/minetest/minetest/releases{/id}","deployments_url":"https://api.github.com/repos/minetest/minetest/deployments","created_at":"2011-08-07T13:48:36Z","updated_at":"2016-03-12T12:57:16Z","pushed_at":"2016-03-12T05:26:27Z","git_url":"git://github.com/minetest/minetest.git","ssh_url":"git@github.com:minetest/minetest.git","clone_url":"https://github.com/minetest/minetest.git","svn_url":"https://github.com/minetest/minetest","homepage":"http://minetest.net/","size":92881,"stargazers_count":1847,"watchers_count":1847,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":601,"mirror_url":null,"open_issues_count":752,"forks":601,"open_issues":752,"watchers":1847,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3848"},"html":{"href":"https://github.com/minetest/minetest/pull/3848"},"issue":{"href":"https://api.github.com/repos/minetest/minetest/issues/3848"},"comments":{"href":"https://api.github.com/repos/minetest/minetest/issues/3848/comments"},"review_comments":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3848/comments"},"review_comment":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3848/commits"},"statuses":{"href":"https://api.github.com/repos/minetest/minetest/statuses/cee77ecaee3161df3cbcb0b3c8dbf76252c5a9ef"}}}}