{"action":"created","comment":{"url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/pulls/comments/81709647","pull_request_review_id":2668840,"id":81709647,"diff_hunk":"@@ -97,6 +97,7 @@ class GemUtils {\n                 // should already have taken care of, see #79\n                 environment 'JBUNDLE_SKIP', true\n                 environment 'JARS_SKIP', true\n+                environment 'GEM_HOME', destDir.absolutePath","path":"jruby-gradle-base-plugin/src/main/groovy/com/github/jrubygradle/GemUtils.groovy","position":null,"original_position":4,"commit_id":"9325d7a88ba0fcd302ec2ba95f9367c842d3db5d","original_commit_id":"9325d7a88ba0fcd302ec2ba95f9367c842d3db5d","user":{"login":"joankaradimov","id":221979,"avatar_url":"https://avatars.githubusercontent.com/u/221979?v=3","gravatar_id":"","url":"https://api.github.com/users/joankaradimov","html_url":"https://github.com/joankaradimov","followers_url":"https://api.github.com/users/joankaradimov/followers","following_url":"https://api.github.com/users/joankaradimov/following{/other_user}","gists_url":"https://api.github.com/users/joankaradimov/gists{/gist_id}","starred_url":"https://api.github.com/users/joankaradimov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joankaradimov/subscriptions","organizations_url":"https://api.github.com/users/joankaradimov/orgs","repos_url":"https://api.github.com/users/joankaradimov/repos","events_url":"https://api.github.com/users/joankaradimov/events{/privacy}","received_events_url":"https://api.github.com/users/joankaradimov/received_events","type":"User","site_admin":false},"body":"I see what you mean. I think it makes more sense to directly set `GEM_PATH` to `destDir.absolutePath`. Something similar to `[destDir.absolutePath, environment['GEM_PATH']].join(File.pathSeparator)` could be used, but that might break the isolation and create conflicts with other ruby installation.","created_at":"2016-10-04T08:40:20Z","updated_at":"2016-10-04T08:40:20Z","html_url":"https://github.com/jruby-gradle/jruby-gradle-plugin/pull/284#discussion_r81709647","pull_request_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/pulls/284","_links":{"self":{"href":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/pulls/comments/81709647"},"html":{"href":"https://github.com/jruby-gradle/jruby-gradle-plugin/pull/284#discussion_r81709647"},"pull_request":{"href":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/pulls/284"}}},"pull_request":{"url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/pulls/284","id":87753381,"html_url":"https://github.com/jruby-gradle/jruby-gradle-plugin/pull/284","diff_url":"https://github.com/jruby-gradle/jruby-gradle-plugin/pull/284.diff","patch_url":"https://github.com/jruby-gradle/jruby-gradle-plugin/pull/284.patch","issue_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/issues/284","number":284,"state":"open","locked":false,"title":"Mkmf compatibility","user":{"login":"joankaradimov","id":221979,"avatar_url":"https://avatars.githubusercontent.com/u/221979?v=3","gravatar_id":"","url":"https://api.github.com/users/joankaradimov","html_url":"https://github.com/joankaradimov","followers_url":"https://api.github.com/users/joankaradimov/followers","following_url":"https://api.github.com/users/joankaradimov/following{/other_user}","gists_url":"https://api.github.com/users/joankaradimov/gists{/gist_id}","starred_url":"https://api.github.com/users/joankaradimov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joankaradimov/subscriptions","organizations_url":"https://api.github.com/users/joankaradimov/orgs","repos_url":"https://api.github.com/users/joankaradimov/repos","events_url":"https://api.github.com/users/joankaradimov/events{/privacy}","received_events_url":"https://api.github.com/users/joankaradimov/received_events","type":"User","site_admin":false},"body":"I am trying to get capybara webkit to install in jruby-gradle (on Windows). I am slowly getting there. This has been possible in JRuby for a few weeks now since the `mkmf` module (MakeMakefile) has been introduced. But I encountered two problems in jruby-gradle and I have fixes for them...\r\n\r\n* The first is to get rid of the call to `setEnvironment`. With the code in master I get this error:\r\n  ```\r\n  'java' is not recognized as an internal or external command, operable program or batch file.\r\n  ```\r\n  ... `setEnvironment` appears to remove existing environment variables instead of just adding the two new ones. By using the alternative `environment` function I was able to fix this.\r\n\r\n* The second one is a bit more tricky. Using `GEM_HOME=/some/directory gem install` appears to differ from `gem install --install-dir=/some/directory/`. The difference is that `GEM_HOME` can also be used for temporary log files. Which is something that `mkmf` does while building capybara-webkit.","created_at":"2016-10-03T17:05:19Z","updated_at":"2016-10-04T08:40:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c048167ea92e29fd14514fd4224592f6ebb5ef1b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/pulls/284/commits","review_comments_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/pulls/284/comments","review_comment_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/issues/284/comments","statuses_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/statuses/9325d7a88ba0fcd302ec2ba95f9367c842d3db5d","head":{"label":"joankaradimov:mkmf-compatibility","ref":"mkmf-compatibility","sha":"9325d7a88ba0fcd302ec2ba95f9367c842d3db5d","user":{"login":"joankaradimov","id":221979,"avatar_url":"https://avatars.githubusercontent.com/u/221979?v=3","gravatar_id":"","url":"https://api.github.com/users/joankaradimov","html_url":"https://github.com/joankaradimov","followers_url":"https://api.github.com/users/joankaradimov/followers","following_url":"https://api.github.com/users/joankaradimov/following{/other_user}","gists_url":"https://api.github.com/users/joankaradimov/gists{/gist_id}","starred_url":"https://api.github.com/users/joankaradimov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joankaradimov/subscriptions","organizations_url":"https://api.github.com/users/joankaradimov/orgs","repos_url":"https://api.github.com/users/joankaradimov/repos","events_url":"https://api.github.com/users/joankaradimov/events{/privacy}","received_events_url":"https://api.github.com/users/joankaradimov/received_events","type":"User","site_admin":false},"repo":{"id":69880217,"name":"jruby-gradle-plugin","full_name":"joankaradimov/jruby-gradle-plugin","owner":{"login":"joankaradimov","id":221979,"avatar_url":"https://avatars.githubusercontent.com/u/221979?v=3","gravatar_id":"","url":"https://api.github.com/users/joankaradimov","html_url":"https://github.com/joankaradimov","followers_url":"https://api.github.com/users/joankaradimov/followers","following_url":"https://api.github.com/users/joankaradimov/following{/other_user}","gists_url":"https://api.github.com/users/joankaradimov/gists{/gist_id}","starred_url":"https://api.github.com/users/joankaradimov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joankaradimov/subscriptions","organizations_url":"https://api.github.com/users/joankaradimov/orgs","repos_url":"https://api.github.com/users/joankaradimov/repos","events_url":"https://api.github.com/users/joankaradimov/events{/privacy}","received_events_url":"https://api.github.com/users/joankaradimov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joankaradimov/jruby-gradle-plugin","description":"A Gradle plugin for working with JRuby projects for fun and profit. Mostly profit.","fork":true,"url":"https://api.github.com/repos/joankaradimov/jruby-gradle-plugin","forks_url":"https://api.github.com/repos/joankaradimov/jruby-gradle-plugin/forks","keys_url":"https://api.github.com/repos/joankaradimov/jruby-gradle-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joankaradimov/jruby-gradle-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joankaradimov/jruby-gradle-plugin/teams","hooks_url":"https://api.github.com/repos/joankaradimov/jruby-gradle-plugin/hooks","issue_events_url":"https://api.github.com/repos/joankaradimov/jruby-gradle-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/joankaradimov/jruby-gradle-plugin/events","assignees_url":"https://api.github.com/repos/joankaradimov/jruby-gradle-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/joankaradimov/jruby-gradle-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/joankaradimov/jruby-gradle-plugin/tags","blobs_url":"https://api.github.com/repos/joankaradimov/jruby-gradle-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joankaradimov/jruby-gradle-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joankaradimov/jruby-gradle-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/joankaradimov/jruby-gradle-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joankaradimov/jruby-gradle-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/joankaradimov/jruby-gradle-plugin/languages","stargazers_url":"https://api.github.com/repos/joankaradimov/jruby-gradle-plugin/stargazers","contributors_url":"https://api.github.com/repos/joankaradimov/jruby-gradle-plugin/contributors","subscribers_url":"https://api.github.com/repos/joankaradimov/jruby-gradle-plugin/subscribers","subscription_url":"https://api.github.com/repos/joankaradimov/jruby-gradle-plugin/subscription","commits_url":"https://api.github.com/repos/joankaradimov/jruby-gradle-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/joankaradimov/jruby-gradle-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/joankaradimov/jruby-gradle-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/joankaradimov/jruby-gradle-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/joankaradimov/jruby-gradle-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/joankaradimov/jruby-gradle-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joankaradimov/jruby-gradle-plugin/merges","archive_url":"https://api.github.com/repos/joankaradimov/jruby-gradle-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joankaradimov/jruby-gradle-plugin/downloads","issues_url":"https://api.github.com/repos/joankaradimov/jruby-gradle-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/joankaradimov/jruby-gradle-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/joankaradimov/jruby-gradle-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/joankaradimov/jruby-gradle-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joankaradimov/jruby-gradle-plugin/labels{/name}","releases_url":"https://api.github.com/repos/joankaradimov/jruby-gradle-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/joankaradimov/jruby-gradle-plugin/deployments","created_at":"2016-10-03T14:44:51Z","updated_at":"2016-10-03T14:44:52Z","pushed_at":"2016-10-03T14:48:48Z","git_url":"git://github.com/joankaradimov/jruby-gradle-plugin.git","ssh_url":"git@github.com:joankaradimov/jruby-gradle-plugin.git","clone_url":"https://github.com/joankaradimov/jruby-gradle-plugin.git","svn_url":"https://github.com/joankaradimov/jruby-gradle-plugin","homepage":"http://jruby-gradle.org","size":936,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jruby-gradle:master","ref":"master","sha":"36864bfd31df694471f281837a03a974d32cf0ec","user":{"login":"jruby-gradle","id":8550762,"avatar_url":"https://avatars.githubusercontent.com/u/8550762?v=3","gravatar_id":"","url":"https://api.github.com/users/jruby-gradle","html_url":"https://github.com/jruby-gradle","followers_url":"https://api.github.com/users/jruby-gradle/followers","following_url":"https://api.github.com/users/jruby-gradle/following{/other_user}","gists_url":"https://api.github.com/users/jruby-gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/jruby-gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jruby-gradle/subscriptions","organizations_url":"https://api.github.com/users/jruby-gradle/orgs","repos_url":"https://api.github.com/users/jruby-gradle/repos","events_url":"https://api.github.com/users/jruby-gradle/events{/privacy}","received_events_url":"https://api.github.com/users/jruby-gradle/received_events","type":"Organization","site_admin":false},"repo":{"id":22769318,"name":"jruby-gradle-plugin","full_name":"jruby-gradle/jruby-gradle-plugin","owner":{"login":"jruby-gradle","id":8550762,"avatar_url":"https://avatars.githubusercontent.com/u/8550762?v=3","gravatar_id":"","url":"https://api.github.com/users/jruby-gradle","html_url":"https://github.com/jruby-gradle","followers_url":"https://api.github.com/users/jruby-gradle/followers","following_url":"https://api.github.com/users/jruby-gradle/following{/other_user}","gists_url":"https://api.github.com/users/jruby-gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/jruby-gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jruby-gradle/subscriptions","organizations_url":"https://api.github.com/users/jruby-gradle/orgs","repos_url":"https://api.github.com/users/jruby-gradle/repos","events_url":"https://api.github.com/users/jruby-gradle/events{/privacy}","received_events_url":"https://api.github.com/users/jruby-gradle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jruby-gradle/jruby-gradle-plugin","description":"A Gradle plugin for working with JRuby projects for fun and profit. Mostly profit.","fork":false,"url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin","forks_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/forks","keys_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/teams","hooks_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/hooks","issue_events_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/events","assignees_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/tags","blobs_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/languages","stargazers_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/stargazers","contributors_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/contributors","subscribers_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/subscribers","subscription_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/subscription","commits_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/merges","archive_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/downloads","issues_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/deployments","created_at":"2014-08-08T19:35:28Z","updated_at":"2016-09-26T22:35:40Z","pushed_at":"2016-10-03T17:05:19Z","git_url":"git://github.com/jruby-gradle/jruby-gradle-plugin.git","ssh_url":"git@github.com:jruby-gradle/jruby-gradle-plugin.git","clone_url":"https://github.com/jruby-gradle/jruby-gradle-plugin.git","svn_url":"https://github.com/jruby-gradle/jruby-gradle-plugin","homepage":"http://jruby-gradle.org","size":981,"stargazers_count":62,"watchers_count":62,"language":"Groovy","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":45,"forks":22,"open_issues":45,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/pulls/284"},"html":{"href":"https://github.com/jruby-gradle/jruby-gradle-plugin/pull/284"},"issue":{"href":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/issues/284"},"comments":{"href":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/issues/284/comments"},"review_comments":{"href":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/pulls/284/comments"},"review_comment":{"href":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/pulls/284/commits"},"statuses":{"href":"https://api.github.com/repos/jruby-gradle/jruby-gradle-plugin/statuses/9325d7a88ba0fcd302ec2ba95f9367c842d3db5d"}}}}
{"actor":{"display_login":"joankaradimov"}}