{"action":"created","comment":{"url":"https://api.github.com/repos/codice/alliance/pulls/comments/79250912","id":79250912,"diff_hunk":"@@ -231,6 +231,24 @@\n                 true /* tokenized */,\n                 false /* multivalued */,\n                 BasicTypes.STRING_TYPE));\n+        DESCRIPTORS.add(new AttributeDescriptorImpl(SNOW_COVER,\n+                true /* indexed */,\n+                true /* stored */,\n+                false /* tokenized */,\n+                false /* multivalued */,\n+                BasicTypes.BOOLEAN_TYPE));\n+        DESCRIPTORS.add(new AttributeDescriptorImpl(SNOW_DEPTH_MIN_CENTIMETERS,\n+                true /* indexed */,\n+                true /* stored */,\n+                false /* tokenized */,\n+                false /* multivalued */,\n+                BasicTypes.DOUBLE_TYPE));\n+        DESCRIPTORS.add(new AttributeDescriptorImpl(SNOW_DEPTH_MAX_CENTIMETERS,\n+                true /* indexed */,\n+                true /* stored */,\n+                false /* tokenized */,\n+                false /* multivalued */,\n+                BasicTypes.DOUBLE_TYPE));","path":"catalog/core/catalog-core-api-impl/src/main/java/org/codice/alliance/catalog/core/api/impl/types/IsrAttributes.java","position":15,"original_position":21,"commit_id":"27a64399b4308af5972aeccfdf89ba0d06b5f1a1","original_commit_id":"27a64399b4308af5972aeccfdf89ba0d06b5f1a1","user":{"login":"glenhein","id":17837152,"avatar_url":"https://avatars.githubusercontent.com/u/17837152?v=3","gravatar_id":"","url":"https://api.github.com/users/glenhein","html_url":"https://github.com/glenhein","followers_url":"https://api.github.com/users/glenhein/followers","following_url":"https://api.github.com/users/glenhein/following{/other_user}","gists_url":"https://api.github.com/users/glenhein/gists{/gist_id}","starred_url":"https://api.github.com/users/glenhein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glenhein/subscriptions","organizations_url":"https://api.github.com/users/glenhein/orgs","repos_url":"https://api.github.com/users/glenhein/repos","events_url":"https://api.github.com/users/glenhein/events{/privacy}","received_events_url":"https://api.github.com/users/glenhein/received_events","type":"User","site_admin":false},"body":"I decided to use double because it's higher precision. But I can change it to float if enough reviewers agree.","created_at":"2016-09-16T21:04:43Z","updated_at":"2016-09-16T21:04:43Z","html_url":"https://github.com/codice/alliance/pull/143#discussion_r79250912","pull_request_url":"https://api.github.com/repos/codice/alliance/pulls/143","_links":{"self":{"href":"https://api.github.com/repos/codice/alliance/pulls/comments/79250912"},"html":{"href":"https://github.com/codice/alliance/pull/143#discussion_r79250912"},"pull_request":{"href":"https://api.github.com/repos/codice/alliance/pulls/143"}}},"pull_request":{"url":"https://api.github.com/repos/codice/alliance/pulls/143","id":84517051,"html_url":"https://github.com/codice/alliance/pull/143","diff_url":"https://github.com/codice/alliance/pull/143.diff","patch_url":"https://github.com/codice/alliance/pull/143.patch","issue_url":"https://api.github.com/repos/codice/alliance/issues/143","number":143,"state":"open","locked":false,"title":"CAL-132 Add NITF TRE support for CSEXRA, PIAIMC, CSDIDA","user":{"login":"glenhein","id":17837152,"avatar_url":"https://avatars.githubusercontent.com/u/17837152?v=3","gravatar_id":"","url":"https://api.github.com/users/glenhein","html_url":"https://github.com/glenhein","followers_url":"https://api.github.com/users/glenhein/followers","following_url":"https://api.github.com/users/glenhein/following{/other_user}","gists_url":"https://api.github.com/users/glenhein/gists{/gist_id}","starred_url":"https://api.github.com/users/glenhein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glenhein/subscriptions","organizations_url":"https://api.github.com/users/glenhein/orgs","repos_url":"https://api.github.com/users/glenhein/repos","events_url":"https://api.github.com/users/glenhein/events{/privacy}","received_events_url":"https://api.github.com/users/glenhein/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\n\r\nThe attributes being added to ISR are SNOW_COVER, SNOW_DEPTH_MIN and SNOW_DEPTH_MAX,\r\nwhich are similar to existing ISR attributes. The metadata from the NITF TREs that\r\ncorresponding to other existing metacard attributes are extracted, normalized where\r\nneeded, and set.\r\n\r\n#### Who is reviewing it (please choose AT LEAST two reviewers that need to approve the PR before it can get merged; if a component team is listed, at least one of its members needs to approve)?\r\n@dcruver \r\n@lcrosenbu \r\n@roelens8 \r\n#### Choose 2 committers to review/merge the PR (please choose ONLY two committers from below, delete the rest).\r\n@beyelerb\r\n@kcwire\r\n#### How should this be tested?\r\nJust run the unit tests for now. If I find sample NITF files applicable to the new code, then I will update the PR.\r\n\r\n#### Any background context you want to provide?\r\n\r\nThe ticket also called for HISTOA, but I couldn't find any corresponding metacard attributes.\r\n\r\nThis PR is based on the umerged work in CAL-79 (https://github.com/codice/alliance/pull/82). \r\n\r\nThe unit tests cover the new code, but I am looking for NITF files that contain the fields addressed by this PR.\r\n\r\n#### What are the relevant tickets?\r\n\r\nCAL-132\r\nCAL-79\r\n\r\n#### Screenshots (if appropriate)\r\n#### Checklist:\r\n- [X] Documentation Updated\r\n- [X] Update / Add Unit Tests\r\n- [ ] Update / Add Integration Tests\r\n","created_at":"2016-09-08T17:11:42Z","updated_at":"2016-09-16T21:04:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4861d26601a5296f77494d5d308df3cea78e0556","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/codice/alliance/pulls/143/commits","review_comments_url":"https://api.github.com/repos/codice/alliance/pulls/143/comments","review_comment_url":"https://api.github.com/repos/codice/alliance/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codice/alliance/issues/143/comments","statuses_url":"https://api.github.com/repos/codice/alliance/statuses/27a64399b4308af5972aeccfdf89ba0d06b5f1a1","head":{"label":"glenhein:CAL-132","ref":"CAL-132","sha":"27a64399b4308af5972aeccfdf89ba0d06b5f1a1","user":{"login":"glenhein","id":17837152,"avatar_url":"https://avatars.githubusercontent.com/u/17837152?v=3","gravatar_id":"","url":"https://api.github.com/users/glenhein","html_url":"https://github.com/glenhein","followers_url":"https://api.github.com/users/glenhein/followers","following_url":"https://api.github.com/users/glenhein/following{/other_user}","gists_url":"https://api.github.com/users/glenhein/gists{/gist_id}","starred_url":"https://api.github.com/users/glenhein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glenhein/subscriptions","organizations_url":"https://api.github.com/users/glenhein/orgs","repos_url":"https://api.github.com/users/glenhein/repos","events_url":"https://api.github.com/users/glenhein/events{/privacy}","received_events_url":"https://api.github.com/users/glenhein/received_events","type":"User","site_admin":false},"repo":{"id":56005607,"name":"alliance","full_name":"glenhein/alliance","owner":{"login":"glenhein","id":17837152,"avatar_url":"https://avatars.githubusercontent.com/u/17837152?v=3","gravatar_id":"","url":"https://api.github.com/users/glenhein","html_url":"https://github.com/glenhein","followers_url":"https://api.github.com/users/glenhein/followers","following_url":"https://api.github.com/users/glenhein/following{/other_user}","gists_url":"https://api.github.com/users/glenhein/gists{/gist_id}","starred_url":"https://api.github.com/users/glenhein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glenhein/subscriptions","organizations_url":"https://api.github.com/users/glenhein/orgs","repos_url":"https://api.github.com/users/glenhein/repos","events_url":"https://api.github.com/users/glenhein/events{/privacy}","received_events_url":"https://api.github.com/users/glenhein/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/glenhein/alliance","description":"","fork":true,"url":"https://api.github.com/repos/glenhein/alliance","forks_url":"https://api.github.com/repos/glenhein/alliance/forks","keys_url":"https://api.github.com/repos/glenhein/alliance/keys{/key_id}","collaborators_url":"https://api.github.com/repos/glenhein/alliance/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/glenhein/alliance/teams","hooks_url":"https://api.github.com/repos/glenhein/alliance/hooks","issue_events_url":"https://api.github.com/repos/glenhein/alliance/issues/events{/number}","events_url":"https://api.github.com/repos/glenhein/alliance/events","assignees_url":"https://api.github.com/repos/glenhein/alliance/assignees{/user}","branches_url":"https://api.github.com/repos/glenhein/alliance/branches{/branch}","tags_url":"https://api.github.com/repos/glenhein/alliance/tags","blobs_url":"https://api.github.com/repos/glenhein/alliance/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/glenhein/alliance/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/glenhein/alliance/git/refs{/sha}","trees_url":"https://api.github.com/repos/glenhein/alliance/git/trees{/sha}","statuses_url":"https://api.github.com/repos/glenhein/alliance/statuses/{sha}","languages_url":"https://api.github.com/repos/glenhein/alliance/languages","stargazers_url":"https://api.github.com/repos/glenhein/alliance/stargazers","contributors_url":"https://api.github.com/repos/glenhein/alliance/contributors","subscribers_url":"https://api.github.com/repos/glenhein/alliance/subscribers","subscription_url":"https://api.github.com/repos/glenhein/alliance/subscription","commits_url":"https://api.github.com/repos/glenhein/alliance/commits{/sha}","git_commits_url":"https://api.github.com/repos/glenhein/alliance/git/commits{/sha}","comments_url":"https://api.github.com/repos/glenhein/alliance/comments{/number}","issue_comment_url":"https://api.github.com/repos/glenhein/alliance/issues/comments{/number}","contents_url":"https://api.github.com/repos/glenhein/alliance/contents/{+path}","compare_url":"https://api.github.com/repos/glenhein/alliance/compare/{base}...{head}","merges_url":"https://api.github.com/repos/glenhein/alliance/merges","archive_url":"https://api.github.com/repos/glenhein/alliance/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/glenhein/alliance/downloads","issues_url":"https://api.github.com/repos/glenhein/alliance/issues{/number}","pulls_url":"https://api.github.com/repos/glenhein/alliance/pulls{/number}","milestones_url":"https://api.github.com/repos/glenhein/alliance/milestones{/number}","notifications_url":"https://api.github.com/repos/glenhein/alliance/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/glenhein/alliance/labels{/name}","releases_url":"https://api.github.com/repos/glenhein/alliance/releases{/id}","deployments_url":"https://api.github.com/repos/glenhein/alliance/deployments","created_at":"2016-04-11T20:33:23Z","updated_at":"2016-04-11T20:33:25Z","pushed_at":"2016-09-08T18:56:18Z","git_url":"git://github.com/glenhein/alliance.git","ssh_url":"git@github.com:glenhein/alliance.git","clone_url":"https://github.com/glenhein/alliance.git","svn_url":"https://github.com/glenhein/alliance","homepage":null,"size":19521,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codice:master","ref":"master","sha":"4e0188ad78bc020aa6c05331893200b65c2ad198","user":{"login":"codice","id":2386734,"avatar_url":"https://avatars.githubusercontent.com/u/2386734?v=3","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"repo":{"id":52804523,"name":"alliance","full_name":"codice/alliance","owner":{"login":"codice","id":2386734,"avatar_url":"https://avatars.githubusercontent.com/u/2386734?v=3","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codice/alliance","description":"","fork":false,"url":"https://api.github.com/repos/codice/alliance","forks_url":"https://api.github.com/repos/codice/alliance/forks","keys_url":"https://api.github.com/repos/codice/alliance/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codice/alliance/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codice/alliance/teams","hooks_url":"https://api.github.com/repos/codice/alliance/hooks","issue_events_url":"https://api.github.com/repos/codice/alliance/issues/events{/number}","events_url":"https://api.github.com/repos/codice/alliance/events","assignees_url":"https://api.github.com/repos/codice/alliance/assignees{/user}","branches_url":"https://api.github.com/repos/codice/alliance/branches{/branch}","tags_url":"https://api.github.com/repos/codice/alliance/tags","blobs_url":"https://api.github.com/repos/codice/alliance/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codice/alliance/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codice/alliance/git/refs{/sha}","trees_url":"https://api.github.com/repos/codice/alliance/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codice/alliance/statuses/{sha}","languages_url":"https://api.github.com/repos/codice/alliance/languages","stargazers_url":"https://api.github.com/repos/codice/alliance/stargazers","contributors_url":"https://api.github.com/repos/codice/alliance/contributors","subscribers_url":"https://api.github.com/repos/codice/alliance/subscribers","subscription_url":"https://api.github.com/repos/codice/alliance/subscription","commits_url":"https://api.github.com/repos/codice/alliance/commits{/sha}","git_commits_url":"https://api.github.com/repos/codice/alliance/git/commits{/sha}","comments_url":"https://api.github.com/repos/codice/alliance/comments{/number}","issue_comment_url":"https://api.github.com/repos/codice/alliance/issues/comments{/number}","contents_url":"https://api.github.com/repos/codice/alliance/contents/{+path}","compare_url":"https://api.github.com/repos/codice/alliance/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codice/alliance/merges","archive_url":"https://api.github.com/repos/codice/alliance/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codice/alliance/downloads","issues_url":"https://api.github.com/repos/codice/alliance/issues{/number}","pulls_url":"https://api.github.com/repos/codice/alliance/pulls{/number}","milestones_url":"https://api.github.com/repos/codice/alliance/milestones{/number}","notifications_url":"https://api.github.com/repos/codice/alliance/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codice/alliance/labels{/name}","releases_url":"https://api.github.com/repos/codice/alliance/releases{/id}","deployments_url":"https://api.github.com/repos/codice/alliance/deployments","created_at":"2016-02-29T16:10:33Z","updated_at":"2016-06-14T21:40:26Z","pushed_at":"2016-09-16T20:44:00Z","git_url":"git://github.com/codice/alliance.git","ssh_url":"git@github.com:codice/alliance.git","clone_url":"https://github.com/codice/alliance.git","svn_url":"https://github.com/codice/alliance","homepage":null,"size":26202,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":14,"forks":28,"open_issues":14,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codice/alliance/pulls/143"},"html":{"href":"https://github.com/codice/alliance/pull/143"},"issue":{"href":"https://api.github.com/repos/codice/alliance/issues/143"},"comments":{"href":"https://api.github.com/repos/codice/alliance/issues/143/comments"},"review_comments":{"href":"https://api.github.com/repos/codice/alliance/pulls/143/comments"},"review_comment":{"href":"https://api.github.com/repos/codice/alliance/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codice/alliance/pulls/143/commits"},"statuses":{"href":"https://api.github.com/repos/codice/alliance/statuses/27a64399b4308af5972aeccfdf89ba0d06b5f1a1"}}}}
{"actor":{"display_login":"glenhein"}}