{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/5733","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/5733/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/5733/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/5733/events","html_url":"https://github.com/nodejs/node/pull/5733","id":141165414,"number":5733,"title":"net: stricter checking for internal/net isLegalPort","user":{"login":"jasnell","id":439929,"avatar_url":"https://avatars.githubusercontent.com/u/439929?v=3","gravatar_id":"","url":"https://api.github.com/users/jasnell","html_url":"https://github.com/jasnell","followers_url":"https://api.github.com/users/jasnell/followers","following_url":"https://api.github.com/users/jasnell/following{/other_user}","gists_url":"https://api.github.com/users/jasnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jasnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasnell/subscriptions","organizations_url":"https://api.github.com/users/jasnell/orgs","repos_url":"https://api.github.com/users/jasnell/repos","events_url":"https://api.github.com/users/jasnell/events{/privacy}","received_events_url":"https://api.github.com/users/jasnell/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/net","name":"net","color":"eb6420"},{"url":"https://api.github.com/repos/nodejs/node/labels/semver-major","name":"semver-major","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-03-16T03:49:02Z","updated_at":"2016-03-16T04:05:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/5733","html_url":"https://github.com/nodejs/node/pull/5733","diff_url":"https://github.com/nodejs/node/pull/5733.diff","patch_url":"https://github.com/nodejs/node/pull/5733.patch"},"body":"### Pull Request check-list\r\n\r\n- [x] Does `make -j8 test` (UNIX) or `vcbuild test nosign` (Windows) pass with\r\n  this change (including linting)?\r\n- [x] Is the commit message formatted according to [CONTRIBUTING.md][0]?\r\n- [x] If this change fixes a bug (or a performance problem), is a regression\r\n  test (or a benchmark) included?\r\n- [ ] Is a documentation update included (if this change modifies\r\n  existing APIs, or introduces new ones)?\r\n\r\n### Affected core subsystem(s)\r\n\r\nnet\r\n\r\n### Description of change\r\n\r\n_Please provide a description of the change here._\r\n\r\nAdd stricter testing for the isLegalPort method in internal/net.\r\nThis ensures that odd inputs such as isLegalPort(true) and\r\nisLegalPort([1]) aren't acceptable as valid port inputs.\r\n\r\nRefs: https://github.com/nodejs/node/pull/5732"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/197142807","html_url":"https://github.com/nodejs/node/pull/5733#issuecomment-197142807","issue_url":"https://api.github.com/repos/nodejs/node/issues/5733","id":197142807,"user":{"login":"jasnell","id":439929,"avatar_url":"https://avatars.githubusercontent.com/u/439929?v=3","gravatar_id":"","url":"https://api.github.com/users/jasnell","html_url":"https://github.com/jasnell","followers_url":"https://api.github.com/users/jasnell/followers","following_url":"https://api.github.com/users/jasnell/following{/other_user}","gists_url":"https://api.github.com/users/jasnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jasnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasnell/subscriptions","organizations_url":"https://api.github.com/users/jasnell/orgs","repos_url":"https://api.github.com/users/jasnell/repos","events_url":"https://api.github.com/users/jasnell/events{/privacy}","received_events_url":"https://api.github.com/users/jasnell/received_events","type":"User","site_admin":false},"created_at":"2016-03-16T04:05:23Z","updated_at":"2016-03-16T04:05:23Z","body":"semver-major because this causes previously acceptable (but quite odd) input values to be rejected."}}