{"action":"created","comment":{"url":"https://api.github.com/repos/OP-TEE/build/pulls/comments/72637125","id":72637125,"diff_hunk":"@@ -278,10 +278,10 @@ filelist-all: busybox\n \texport TOP=$(ROOT); export MULTIARCH=$(MULTIARCH); \\\n \t$(expand-env-var) <$(PATCHES_PATH)/rootfs/initramfs-add-files.txt >> $(GEN_ROOTFS_PATH)/filelist-all.txt; \\","path":"hikey.mk","position":2,"original_position":2,"commit_id":"c73f9d51463c0a1cf429b15001d4aff0b126fe0f","original_commit_id":"c73f9d51463c0a1cf429b15001d4aff0b126fe0f","user":{"login":"jforissier","id":8288195,"avatar_url":"https://avatars.githubusercontent.com/u/8288195?v=3","gravatar_id":"","url":"https://api.github.com/users/jforissier","html_url":"https://github.com/jforissier","followers_url":"https://api.github.com/users/jforissier/followers","following_url":"https://api.github.com/users/jforissier/following{/other_user}","gists_url":"https://api.github.com/users/jforissier/gists{/gist_id}","starred_url":"https://api.github.com/users/jforissier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jforissier/subscriptions","organizations_url":"https://api.github.com/users/jforissier/orgs","repos_url":"https://api.github.com/users/jforissier/repos","events_url":"https://api.github.com/users/jforissier/events{/privacy}","received_events_url":"https://api.github.com/users/jforissier/received_events","type":"User","site_admin":false},"body":"It seems that only this line (expand-env-var) needs `TOP` and `MULTIARCH` to be set. So you may as well remove all the line continuation characters from the subsequent lines (well not inside the `if` of course) and keep the `@`. I think it would be a better solution because it's not the first time this kind of mistake happens IIRC.","created_at":"2016-07-28T14:50:29Z","updated_at":"2016-07-28T14:50:29Z","html_url":"https://github.com/OP-TEE/build/pull/72#discussion_r72637125","pull_request_url":"https://api.github.com/repos/OP-TEE/build/pulls/72","_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/build/pulls/comments/72637125"},"html":{"href":"https://github.com/OP-TEE/build/pull/72#discussion_r72637125"},"pull_request":{"href":"https://api.github.com/repos/OP-TEE/build/pulls/72"}}},"pull_request":{"url":"https://api.github.com/repos/OP-TEE/build/pulls/72","id":79198481,"html_url":"https://github.com/OP-TEE/build/pull/72","diff_url":"https://github.com/OP-TEE/build/pull/72.diff","patch_url":"https://github.com/OP-TEE/build/pull/72.patch","issue_url":"https://api.github.com/repos/OP-TEE/build/issues/72","number":72,"state":"open","locked":false,"title":"hikey: fix bug: @echo: command not found","user":{"login":"vchong","id":7334750,"avatar_url":"https://avatars.githubusercontent.com/u/7334750?v=3","gravatar_id":"","url":"https://api.github.com/users/vchong","html_url":"https://github.com/vchong","followers_url":"https://api.github.com/users/vchong/followers","following_url":"https://api.github.com/users/vchong/following{/other_user}","gists_url":"https://api.github.com/users/vchong/gists{/gist_id}","starred_url":"https://api.github.com/users/vchong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vchong/subscriptions","organizations_url":"https://api.github.com/users/vchong/orgs","repos_url":"https://api.github.com/users/vchong/repos","events_url":"https://api.github.com/users/vchong/events{/privacy}","received_events_url":"https://api.github.com/users/vchong/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Victor Chong <victor.chong@linaro.org>\r\nTested-by: Victor Chong <victor.chong@linaro.org> (hikey)","created_at":"2016-07-28T13:46:49Z","updated_at":"2016-07-28T14:50:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1855dac28a275a3f32d4eb599e51a27a3cd2b338","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/OP-TEE/build/pulls/72/commits","review_comments_url":"https://api.github.com/repos/OP-TEE/build/pulls/72/comments","review_comment_url":"https://api.github.com/repos/OP-TEE/build/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OP-TEE/build/issues/72/comments","statuses_url":"https://api.github.com/repos/OP-TEE/build/statuses/c73f9d51463c0a1cf429b15001d4aff0b126fe0f","head":{"label":"vchong:hellofix","ref":"hellofix","sha":"c73f9d51463c0a1cf429b15001d4aff0b126fe0f","user":{"login":"vchong","id":7334750,"avatar_url":"https://avatars.githubusercontent.com/u/7334750?v=3","gravatar_id":"","url":"https://api.github.com/users/vchong","html_url":"https://github.com/vchong","followers_url":"https://api.github.com/users/vchong/followers","following_url":"https://api.github.com/users/vchong/following{/other_user}","gists_url":"https://api.github.com/users/vchong/gists{/gist_id}","starred_url":"https://api.github.com/users/vchong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vchong/subscriptions","organizations_url":"https://api.github.com/users/vchong/orgs","repos_url":"https://api.github.com/users/vchong/repos","events_url":"https://api.github.com/users/vchong/events{/privacy}","received_events_url":"https://api.github.com/users/vchong/received_events","type":"User","site_admin":false},"repo":{"id":46433831,"name":"build","full_name":"vchong/build","owner":{"login":"vchong","id":7334750,"avatar_url":"https://avatars.githubusercontent.com/u/7334750?v=3","gravatar_id":"","url":"https://api.github.com/users/vchong","html_url":"https://github.com/vchong","followers_url":"https://api.github.com/users/vchong/followers","following_url":"https://api.github.com/users/vchong/following{/other_user}","gists_url":"https://api.github.com/users/vchong/gists{/gist_id}","starred_url":"https://api.github.com/users/vchong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vchong/subscriptions","organizations_url":"https://api.github.com/users/vchong/orgs","repos_url":"https://api.github.com/users/vchong/repos","events_url":"https://api.github.com/users/vchong/events{/privacy}","received_events_url":"https://api.github.com/users/vchong/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vchong/build","description":"Makefiles to use OP-TEE on various platforms","fork":true,"url":"https://api.github.com/repos/vchong/build","forks_url":"https://api.github.com/repos/vchong/build/forks","keys_url":"https://api.github.com/repos/vchong/build/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vchong/build/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vchong/build/teams","hooks_url":"https://api.github.com/repos/vchong/build/hooks","issue_events_url":"https://api.github.com/repos/vchong/build/issues/events{/number}","events_url":"https://api.github.com/repos/vchong/build/events","assignees_url":"https://api.github.com/repos/vchong/build/assignees{/user}","branches_url":"https://api.github.com/repos/vchong/build/branches{/branch}","tags_url":"https://api.github.com/repos/vchong/build/tags","blobs_url":"https://api.github.com/repos/vchong/build/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vchong/build/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vchong/build/git/refs{/sha}","trees_url":"https://api.github.com/repos/vchong/build/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vchong/build/statuses/{sha}","languages_url":"https://api.github.com/repos/vchong/build/languages","stargazers_url":"https://api.github.com/repos/vchong/build/stargazers","contributors_url":"https://api.github.com/repos/vchong/build/contributors","subscribers_url":"https://api.github.com/repos/vchong/build/subscribers","subscription_url":"https://api.github.com/repos/vchong/build/subscription","commits_url":"https://api.github.com/repos/vchong/build/commits{/sha}","git_commits_url":"https://api.github.com/repos/vchong/build/git/commits{/sha}","comments_url":"https://api.github.com/repos/vchong/build/comments{/number}","issue_comment_url":"https://api.github.com/repos/vchong/build/issues/comments{/number}","contents_url":"https://api.github.com/repos/vchong/build/contents/{+path}","compare_url":"https://api.github.com/repos/vchong/build/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vchong/build/merges","archive_url":"https://api.github.com/repos/vchong/build/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vchong/build/downloads","issues_url":"https://api.github.com/repos/vchong/build/issues{/number}","pulls_url":"https://api.github.com/repos/vchong/build/pulls{/number}","milestones_url":"https://api.github.com/repos/vchong/build/milestones{/number}","notifications_url":"https://api.github.com/repos/vchong/build/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vchong/build/labels{/name}","releases_url":"https://api.github.com/repos/vchong/build/releases{/id}","deployments_url":"https://api.github.com/repos/vchong/build/deployments","created_at":"2015-11-18T17:01:07Z","updated_at":"2016-03-15T06:04:56Z","pushed_at":"2016-07-28T13:47:37Z","git_url":"git://github.com/vchong/build.git","ssh_url":"git@github.com:vchong/build.git","clone_url":"https://github.com/vchong/build.git","svn_url":"https://github.com/vchong/build","homepage":null,"size":127,"stargazers_count":0,"watchers_count":0,"language":"Makefile","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"myhikey"}},"base":{"label":"OP-TEE:master","ref":"master","sha":"8519bcf7f51fa613592418227f5db8c6e3af741e","user":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars.githubusercontent.com/u/7488961?v=3","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"repo":{"id":38863043,"name":"build","full_name":"OP-TEE/build","owner":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars.githubusercontent.com/u/7488961?v=3","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OP-TEE/build","description":"Makefiles to use OP-TEE on various platforms","fork":false,"url":"https://api.github.com/repos/OP-TEE/build","forks_url":"https://api.github.com/repos/OP-TEE/build/forks","keys_url":"https://api.github.com/repos/OP-TEE/build/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OP-TEE/build/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OP-TEE/build/teams","hooks_url":"https://api.github.com/repos/OP-TEE/build/hooks","issue_events_url":"https://api.github.com/repos/OP-TEE/build/issues/events{/number}","events_url":"https://api.github.com/repos/OP-TEE/build/events","assignees_url":"https://api.github.com/repos/OP-TEE/build/assignees{/user}","branches_url":"https://api.github.com/repos/OP-TEE/build/branches{/branch}","tags_url":"https://api.github.com/repos/OP-TEE/build/tags","blobs_url":"https://api.github.com/repos/OP-TEE/build/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OP-TEE/build/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OP-TEE/build/git/refs{/sha}","trees_url":"https://api.github.com/repos/OP-TEE/build/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OP-TEE/build/statuses/{sha}","languages_url":"https://api.github.com/repos/OP-TEE/build/languages","stargazers_url":"https://api.github.com/repos/OP-TEE/build/stargazers","contributors_url":"https://api.github.com/repos/OP-TEE/build/contributors","subscribers_url":"https://api.github.com/repos/OP-TEE/build/subscribers","subscription_url":"https://api.github.com/repos/OP-TEE/build/subscription","commits_url":"https://api.github.com/repos/OP-TEE/build/commits{/sha}","git_commits_url":"https://api.github.com/repos/OP-TEE/build/git/commits{/sha}","comments_url":"https://api.github.com/repos/OP-TEE/build/comments{/number}","issue_comment_url":"https://api.github.com/repos/OP-TEE/build/issues/comments{/number}","contents_url":"https://api.github.com/repos/OP-TEE/build/contents/{+path}","compare_url":"https://api.github.com/repos/OP-TEE/build/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OP-TEE/build/merges","archive_url":"https://api.github.com/repos/OP-TEE/build/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OP-TEE/build/downloads","issues_url":"https://api.github.com/repos/OP-TEE/build/issues{/number}","pulls_url":"https://api.github.com/repos/OP-TEE/build/pulls{/number}","milestones_url":"https://api.github.com/repos/OP-TEE/build/milestones{/number}","notifications_url":"https://api.github.com/repos/OP-TEE/build/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OP-TEE/build/labels{/name}","releases_url":"https://api.github.com/repos/OP-TEE/build/releases{/id}","deployments_url":"https://api.github.com/repos/OP-TEE/build/deployments","created_at":"2015-07-10T05:39:14Z","updated_at":"2016-06-11T14:55:55Z","pushed_at":"2016-07-28T13:47:37Z","git_url":"git://github.com/OP-TEE/build.git","ssh_url":"git@github.com:OP-TEE/build.git","clone_url":"https://github.com/OP-TEE/build.git","svn_url":"https://github.com/OP-TEE/build","homepage":null,"size":700,"stargazers_count":7,"watchers_count":7,"language":"Makefile","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":3,"forks":16,"open_issues":3,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/build/pulls/72"},"html":{"href":"https://github.com/OP-TEE/build/pull/72"},"issue":{"href":"https://api.github.com/repos/OP-TEE/build/issues/72"},"comments":{"href":"https://api.github.com/repos/OP-TEE/build/issues/72/comments"},"review_comments":{"href":"https://api.github.com/repos/OP-TEE/build/pulls/72/comments"},"review_comment":{"href":"https://api.github.com/repos/OP-TEE/build/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OP-TEE/build/pulls/72/commits"},"statuses":{"href":"https://api.github.com/repos/OP-TEE/build/statuses/c73f9d51463c0a1cf429b15001d4aff0b126fe0f"}}}}
{"actor":{"display_login":"jforissier"}}