{"action":"created","comment":{"url":"https://api.github.com/repos/ably/docs/pulls/comments/92121693","pull_request_review_id":12629792,"id":92121693,"diff_hunk":"@@ -1,25 +1,92 @@\n-@ARTChannelEvent@ is the enum emitted as the event in @ARTRealtimeChannel.on@. The variants correspond to \"@Realtime Channel@ state\":/realtime/channels-messages/#channel-state changes, plus an arbitrary @Error@.\n-\n-```[objc]\n-  typedef NS_ENUM(NSUInteger, ARTChannelEvent) {\n-      ARTChannelEventInitialized,\n-      ARTChannelEventAttaching,\n-      ARTChannelEventAttached,\n-      ARTChannelEventDetaching,\n-      ARTChannelEventDetached,\n-      ARTChannelEventFailed,\n-      ARTChannelEventError\n-  };\n-```\n-\n-```[swift]\n-  enum ARTChannelEvent : UInt {\n-      case Initialized\n-      case Attaching\n-      case Attached\n-      case Detaching\n-      case Detached\n-      case Failed\n-      case Error\n-  }\n-```\n+blang[jsall].\n+  @ChannelEvent@ is a String that can be emitted as an event on the @Channel@ object; either a \"@ChannelState@\":/realtime/channels-messages#channel-states or an @update@ event.\n+\n+\n+  ```[javascript]\n+    var allChannelEvents = allChannelStates.concat(['update']);","path":"content/types/_channel_event.textile","position":31,"original_position":31,"commit_id":"0f4aac14659787552865c996a740b14104740578","original_commit_id":"0f4aac14659787552865c996a740b14104740578","user":{"login":"SimonWoolf","id":5908687,"avatar_url":"https://avatars.githubusercontent.com/u/5908687?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonWoolf","html_url":"https://github.com/SimonWoolf","followers_url":"https://api.github.com/users/SimonWoolf/followers","following_url":"https://api.github.com/users/SimonWoolf/following{/other_user}","gists_url":"https://api.github.com/users/SimonWoolf/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonWoolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonWoolf/subscriptions","organizations_url":"https://api.github.com/users/SimonWoolf/orgs","repos_url":"https://api.github.com/users/SimonWoolf/repos","events_url":"https://api.github.com/users/SimonWoolf/events{/privacy}","received_events_url":"https://api.github.com/users/SimonWoolf/received_events","type":"User","site_admin":false},"body":"It's not defined in this partial, but everywhere `channel_event` is included, `channel_state` is included right above it, which defines it. I figured this way makes it clearer what the difference actually is between the two. But happy to switch out for a full list if you think that'd be better, wdyt?","created_at":"2016-12-13T08:55:24Z","updated_at":"2016-12-13T08:55:24Z","html_url":"https://github.com/ably/docs/pull/217#discussion_r92121693","pull_request_url":"https://api.github.com/repos/ably/docs/pulls/217","_links":{"self":{"href":"https://api.github.com/repos/ably/docs/pulls/comments/92121693"},"html":{"href":"https://github.com/ably/docs/pull/217#discussion_r92121693"},"pull_request":{"href":"https://api.github.com/repos/ably/docs/pulls/217"}}},"pull_request":{"url":"https://api.github.com/repos/ably/docs/pulls/217","id":96537980,"html_url":"https://github.com/ably/docs/pull/217","diff_url":"https://github.com/ably/docs/pull/217.diff","patch_url":"https://github.com/ably/docs/pull/217.patch","issue_url":"https://api.github.com/repos/ably/docs/issues/217","number":217,"state":"open","locked":false,"title":"Update documentation for UPDATE event","user":{"login":"SimonWoolf","id":5908687,"avatar_url":"https://avatars.githubusercontent.com/u/5908687?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonWoolf","html_url":"https://github.com/SimonWoolf","followers_url":"https://api.github.com/users/SimonWoolf/followers","following_url":"https://api.github.com/users/SimonWoolf/following{/other_user}","gists_url":"https://api.github.com/users/SimonWoolf/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonWoolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonWoolf/subscriptions","organizations_url":"https://api.github.com/users/SimonWoolf/orgs","repos_url":"https://api.github.com/users/SimonWoolf/repos","events_url":"https://api.github.com/users/SimonWoolf/events{/privacy}","received_events_url":"https://api.github.com/users/SimonWoolf/received_events","type":"User","site_admin":false},"body":"Documentation changes for https://github.com/ably/docs/pull/208 (adding `update` event, removing `error`).\r\n\r\nPer @mattheworiordan's comment [here](https://github.com/ably/docs/pull/181#issuecomment-260531685) I've made the changes for all languages, making guesses as to what non-js languages will look like, as Matt's done with the rest of the 0.9 spec. (In particular I'm not sure if the typed languages will just have ChannelEvent as a separate enum from ChannelState (which is what I've assumed in this PR), or have some way to inherit enums, or ChannelEvent'd only have one element and the on() methods'd take either a ChannelState or ChannelEvent, or whatever)","created_at":"2016-12-05T14:26:53Z","updated_at":"2016-12-13T08:55:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c08bd715049aaddbb1275c9d6f7d29912fb467b6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ably/docs/pulls/217/commits","review_comments_url":"https://api.github.com/repos/ably/docs/pulls/217/comments","review_comment_url":"https://api.github.com/repos/ably/docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ably/docs/issues/217/comments","statuses_url":"https://api.github.com/repos/ably/docs/statuses/0f4aac14659787552865c996a740b14104740578","head":{"label":"ably:update-event-0-9","ref":"update-event-0-9","sha":"0f4aac14659787552865c996a740b14104740578","user":{"login":"ably","id":1859245,"avatar_url":"https://avatars.githubusercontent.com/u/1859245?v=3","gravatar_id":"","url":"https://api.github.com/users/ably","html_url":"https://github.com/ably","followers_url":"https://api.github.com/users/ably/followers","following_url":"https://api.github.com/users/ably/following{/other_user}","gists_url":"https://api.github.com/users/ably/gists{/gist_id}","starred_url":"https://api.github.com/users/ably/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ably/subscriptions","organizations_url":"https://api.github.com/users/ably/orgs","repos_url":"https://api.github.com/users/ably/repos","events_url":"https://api.github.com/users/ably/events{/privacy}","received_events_url":"https://api.github.com/users/ably/received_events","type":"Organization","site_admin":false},"repo":{"id":7221949,"name":"docs","full_name":"ably/docs","owner":{"login":"ably","id":1859245,"avatar_url":"https://avatars.githubusercontent.com/u/1859245?v=3","gravatar_id":"","url":"https://api.github.com/users/ably","html_url":"https://github.com/ably","followers_url":"https://api.github.com/users/ably/followers","following_url":"https://api.github.com/users/ably/following{/other_user}","gists_url":"https://api.github.com/users/ably/gists{/gist_id}","starred_url":"https://api.github.com/users/ably/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ably/subscriptions","organizations_url":"https://api.github.com/users/ably/orgs","repos_url":"https://api.github.com/users/ably/repos","events_url":"https://api.github.com/users/ably/events{/privacy}","received_events_url":"https://api.github.com/users/ably/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ably/docs","description":"Ably API documentation ","fork":false,"url":"https://api.github.com/repos/ably/docs","forks_url":"https://api.github.com/repos/ably/docs/forks","keys_url":"https://api.github.com/repos/ably/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ably/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ably/docs/teams","hooks_url":"https://api.github.com/repos/ably/docs/hooks","issue_events_url":"https://api.github.com/repos/ably/docs/issues/events{/number}","events_url":"https://api.github.com/repos/ably/docs/events","assignees_url":"https://api.github.com/repos/ably/docs/assignees{/user}","branches_url":"https://api.github.com/repos/ably/docs/branches{/branch}","tags_url":"https://api.github.com/repos/ably/docs/tags","blobs_url":"https://api.github.com/repos/ably/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ably/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ably/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ably/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ably/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/ably/docs/languages","stargazers_url":"https://api.github.com/repos/ably/docs/stargazers","contributors_url":"https://api.github.com/repos/ably/docs/contributors","subscribers_url":"https://api.github.com/repos/ably/docs/subscribers","subscription_url":"https://api.github.com/repos/ably/docs/subscription","commits_url":"https://api.github.com/repos/ably/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ably/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ably/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ably/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ably/docs/contents/{+path}","compare_url":"https://api.github.com/repos/ably/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ably/docs/merges","archive_url":"https://api.github.com/repos/ably/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ably/docs/downloads","issues_url":"https://api.github.com/repos/ably/docs/issues{/number}","pulls_url":"https://api.github.com/repos/ably/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/ably/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/ably/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ably/docs/labels{/name}","releases_url":"https://api.github.com/repos/ably/docs/releases{/id}","deployments_url":"https://api.github.com/repos/ably/docs/deployments","created_at":"2012-12-18T10:59:49Z","updated_at":"2016-11-07T07:07:06Z","pushed_at":"2016-12-13T08:26:07Z","git_url":"git://github.com/ably/docs.git","ssh_url":"git@github.com:ably/docs.git","clone_url":"https://github.com/ably/docs.git","svn_url":"https://github.com/ably/docs","homepage":null,"size":14339,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":47,"forks":12,"open_issues":47,"watchers":1,"default_branch":"source"}},"base":{"label":"ably:jsall-0-9","ref":"jsall-0-9","sha":"4280e2a0167560c7d960b037248c1ae94eb25d40","user":{"login":"ably","id":1859245,"avatar_url":"https://avatars.githubusercontent.com/u/1859245?v=3","gravatar_id":"","url":"https://api.github.com/users/ably","html_url":"https://github.com/ably","followers_url":"https://api.github.com/users/ably/followers","following_url":"https://api.github.com/users/ably/following{/other_user}","gists_url":"https://api.github.com/users/ably/gists{/gist_id}","starred_url":"https://api.github.com/users/ably/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ably/subscriptions","organizations_url":"https://api.github.com/users/ably/orgs","repos_url":"https://api.github.com/users/ably/repos","events_url":"https://api.github.com/users/ably/events{/privacy}","received_events_url":"https://api.github.com/users/ably/received_events","type":"Organization","site_admin":false},"repo":{"id":7221949,"name":"docs","full_name":"ably/docs","owner":{"login":"ably","id":1859245,"avatar_url":"https://avatars.githubusercontent.com/u/1859245?v=3","gravatar_id":"","url":"https://api.github.com/users/ably","html_url":"https://github.com/ably","followers_url":"https://api.github.com/users/ably/followers","following_url":"https://api.github.com/users/ably/following{/other_user}","gists_url":"https://api.github.com/users/ably/gists{/gist_id}","starred_url":"https://api.github.com/users/ably/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ably/subscriptions","organizations_url":"https://api.github.com/users/ably/orgs","repos_url":"https://api.github.com/users/ably/repos","events_url":"https://api.github.com/users/ably/events{/privacy}","received_events_url":"https://api.github.com/users/ably/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ably/docs","description":"Ably API documentation ","fork":false,"url":"https://api.github.com/repos/ably/docs","forks_url":"https://api.github.com/repos/ably/docs/forks","keys_url":"https://api.github.com/repos/ably/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ably/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ably/docs/teams","hooks_url":"https://api.github.com/repos/ably/docs/hooks","issue_events_url":"https://api.github.com/repos/ably/docs/issues/events{/number}","events_url":"https://api.github.com/repos/ably/docs/events","assignees_url":"https://api.github.com/repos/ably/docs/assignees{/user}","branches_url":"https://api.github.com/repos/ably/docs/branches{/branch}","tags_url":"https://api.github.com/repos/ably/docs/tags","blobs_url":"https://api.github.com/repos/ably/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ably/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ably/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ably/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ably/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/ably/docs/languages","stargazers_url":"https://api.github.com/repos/ably/docs/stargazers","contributors_url":"https://api.github.com/repos/ably/docs/contributors","subscribers_url":"https://api.github.com/repos/ably/docs/subscribers","subscription_url":"https://api.github.com/repos/ably/docs/subscription","commits_url":"https://api.github.com/repos/ably/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ably/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ably/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ably/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ably/docs/contents/{+path}","compare_url":"https://api.github.com/repos/ably/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ably/docs/merges","archive_url":"https://api.github.com/repos/ably/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ably/docs/downloads","issues_url":"https://api.github.com/repos/ably/docs/issues{/number}","pulls_url":"https://api.github.com/repos/ably/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/ably/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/ably/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ably/docs/labels{/name}","releases_url":"https://api.github.com/repos/ably/docs/releases{/id}","deployments_url":"https://api.github.com/repos/ably/docs/deployments","created_at":"2012-12-18T10:59:49Z","updated_at":"2016-11-07T07:07:06Z","pushed_at":"2016-12-13T08:26:07Z","git_url":"git://github.com/ably/docs.git","ssh_url":"git@github.com:ably/docs.git","clone_url":"https://github.com/ably/docs.git","svn_url":"https://github.com/ably/docs","homepage":null,"size":14339,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":47,"forks":12,"open_issues":47,"watchers":1,"default_branch":"source"}},"_links":{"self":{"href":"https://api.github.com/repos/ably/docs/pulls/217"},"html":{"href":"https://github.com/ably/docs/pull/217"},"issue":{"href":"https://api.github.com/repos/ably/docs/issues/217"},"comments":{"href":"https://api.github.com/repos/ably/docs/issues/217/comments"},"review_comments":{"href":"https://api.github.com/repos/ably/docs/pulls/217/comments"},"review_comment":{"href":"https://api.github.com/repos/ably/docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ably/docs/pulls/217/commits"},"statuses":{"href":"https://api.github.com/repos/ably/docs/statuses/0f4aac14659787552865c996a740b14104740578"}}}}
{"actor":{"display_login":"SimonWoolf"}}