{"push_id":1099476086,"size":2,"distinct_size":2,"ref":"refs/heads/master","head":"38545741f42801a2ed7439ebf34ef1b109ff7735","before":"ce3d70030f1ef32e4149845ad7659972d38de0de","commits":[{"sha":"5a28da91c59e711a007384b763a1f637787a6a33","author":{"email":"baaed8b0b39ae711da8baa7a1217a5001399f96b@proxmox.com","name":"Thomas Lamprecht"},"message":"fix relocate/restart trial count leak on service deletion\n\nIf a service gets remove from HA remove also its relocate and\nrestart trial count from LRM status and manager_status, else it\nnever gets deleted (leak).\n\nSigned-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>","distinct":true,"url":"https://api.github.com/repos/GamerSource/pve-ha-manager/commits/5a28da91c59e711a007384b763a1f637787a6a33"},{"sha":"38545741f42801a2ed7439ebf34ef1b109ff7735","author":{"email":"baaed8b0b39ae711da8baa7a1217a5001399f96b@proxmox.com","name":"Thomas Lamprecht"},"message":"LRM: do not count erroneous service as active\n\nFixes an infinite hang on updating or restarting a nodes LRM when a\nservice within the error state is located on it.\n\nWe fix that by not counting those services towards the \"active\nservice count\" as an service in an error state is *not* managed by\nHA, thus also not active.\n\nAs we use the active service count in three places this change has\nthe following effects:\n\n* when determining if we should try to acquire our agent_lock and\nmake the state transition from wait_for_agent_lock => active. Here\nits safe as we cannot do anything with the erroneous states anyhow,\nand as the only way to move out from error state is disabling the\nservice (thus marking it as stopped) has the result that it still\nis not counted as active, as we skip stopped also, so this is safe\nand also wanted.\n\n* when restarting the LRM to see if it has frozen all active\nservices and thus it's allowed to finish the restart. This is the\nprimary intent of this patch as it allows the LRM to restart safely\nwitouth hanging forever (and then be killed by systemd which results\nin a watchdog node reset).\n\n* when shutting down a LRM in lost_agent_lock state, here it has the\neffect that with this patch the node won't get shot by its watchdog\nif it has erroneous services but not active ones, this is not only\nsave but wanted. It makes no sense letting the watchdog trigger when\nwe have no active services besides the one in the error state, as\nwhen restarting it does not make anything better (error services\nwon't get touched after all).\n\nSigned-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>","distinct":true,"url":"https://api.github.com/repos/GamerSource/pve-ha-manager/commits/38545741f42801a2ed7439ebf34ef1b109ff7735"}]}