{"action":"created","issue":{"url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/issues/17","repository_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource","labels_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/issues/17/comments","events_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/issues/17/events","html_url":"https://github.com/concourse/bosh-io-stemcell-resource/pull/17","id":187838715,"number":17,"title":"Tweak retry logic to be more robust to poor network connection","user":{"login":"ljfranklin","id":1923644,"avatar_url":"https://avatars.githubusercontent.com/u/1923644?v=3","gravatar_id":"","url":"https://api.github.com/users/ljfranklin","html_url":"https://github.com/ljfranklin","followers_url":"https://api.github.com/users/ljfranklin/followers","following_url":"https://api.github.com/users/ljfranklin/following{/other_user}","gists_url":"https://api.github.com/users/ljfranklin/gists{/gist_id}","starred_url":"https://api.github.com/users/ljfranklin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljfranklin/subscriptions","organizations_url":"https://api.github.com/users/ljfranklin/orgs","repos_url":"https://api.github.com/users/ljfranklin/repos","events_url":"https://api.github.com/users/ljfranklin/events{/privacy}","received_events_url":"https://api.github.com/users/ljfranklin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-07T21:48:50Z","updated_at":"2016-11-07T21:53:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/pulls/17","html_url":"https://github.com/concourse/bosh-io-stemcell-resource/pull/17","diff_url":"https://github.com/concourse/bosh-io-stemcell-resource/pull/17.diff","patch_url":"https://github.com/concourse/bosh-io-stemcell-resource/pull/17.patch"},"body":"Summary: We have an external Concourse worker with a **very** poor internet connection. This PR makes a few tweaks to HTTP retries and underlying TCP settings to make downloads more reliable in this environment.\r\n\r\n- Revert removal of HTTPClient wrapper\r\n  - We needed to change some default HTTP client settings\r\n  - We were still able to use a fake client to simulate a retryable error\r\n- Retry on \"connection refused\"\r\n  - Downloading from S3 into our worker saw this error frequently\r\n- Bumps TLS Handshake timeout\r\n  - We saw this timeout several times on our worker (although this error will be retried regardless)\r\n- Disable TCP keepalive messages and TCP connection re-use\r\n  - these settings were recommended by BOSH team as they saw issues\r\n    using these settings on various infrastructures\r\n  - Although not conclusive, disabling these settings did seem to drop\r\n    our error rate in our environment\r\n- Refactors out `goto` call\r\n\r\n[#133704741](https://www.pivotaltracker.com/story/show/133704741)\r\n\r\nSigned-off-by: Chris Hajas <chajas@pivotal.io>\r\n"},"comment":{"url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/issues/comments/258974923","html_url":"https://github.com/concourse/bosh-io-stemcell-resource/pull/17#issuecomment-258974923","issue_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/issues/17","id":258974923,"user":{"login":"zachgersh","id":689411,"avatar_url":"https://avatars.githubusercontent.com/u/689411?v=3","gravatar_id":"","url":"https://api.github.com/users/zachgersh","html_url":"https://github.com/zachgersh","followers_url":"https://api.github.com/users/zachgersh/followers","following_url":"https://api.github.com/users/zachgersh/following{/other_user}","gists_url":"https://api.github.com/users/zachgersh/gists{/gist_id}","starred_url":"https://api.github.com/users/zachgersh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zachgersh/subscriptions","organizations_url":"https://api.github.com/users/zachgersh/orgs","repos_url":"https://api.github.com/users/zachgersh/repos","events_url":"https://api.github.com/users/zachgersh/events{/privacy}","received_events_url":"https://api.github.com/users/zachgersh/received_events","type":"User","site_admin":false},"created_at":"2016-11-07T21:53:23Z","updated_at":"2016-11-07T21:53:23Z","body":"@ljfranklin - I am cool with this. Can we not bring the constructor back though? I prefer to just go with the struct as an initializer."}}
{"actor":{"display_login":"zachgersh"}}