{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/buck/issues/847","repository_url":"https://api.github.com/repos/facebook/buck","labels_url":"https://api.github.com/repos/facebook/buck/issues/847/labels{/name}","comments_url":"https://api.github.com/repos/facebook/buck/issues/847/comments","events_url":"https://api.github.com/repos/facebook/buck/issues/847/events","html_url":"https://github.com/facebook/buck/pull/847","id":172116605,"number":847,"title":"Propagate swift flavors instead of combining SwiftLibrary & SwiftCompile","user":{"login":"nguyentruongtho","id":1457567,"avatar_url":"https://avatars.githubusercontent.com/u/1457567?v=3","gravatar_id":"","url":"https://api.github.com/users/nguyentruongtho","html_url":"https://github.com/nguyentruongtho","followers_url":"https://api.github.com/users/nguyentruongtho/followers","following_url":"https://api.github.com/users/nguyentruongtho/following{/other_user}","gists_url":"https://api.github.com/users/nguyentruongtho/gists{/gist_id}","starred_url":"https://api.github.com/users/nguyentruongtho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nguyentruongtho/subscriptions","organizations_url":"https://api.github.com/users/nguyentruongtho/orgs","repos_url":"https://api.github.com/users/nguyentruongtho/repos","events_url":"https://api.github.com/users/nguyentruongtho/events{/privacy}","received_events_url":"https://api.github.com/users/nguyentruongtho/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/buck/labels/CLA%20Signed","name":"CLA Signed","color":"009900"},{"url":"https://api.github.com/repos/facebook/buck/labels/GH%20Review:%20review-needed","name":"GH Review: review-needed","color":"207de5"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":22,"created_at":"2016-08-19T12:03:50Z","updated_at":"2016-08-24T16:28:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/buck/pulls/847","html_url":"https://github.com/facebook/buck/pull/847","diff_url":"https://github.com/facebook/buck/pull/847.diff","patch_url":"https://github.com/facebook/buck/pull/847.patch"},"body":"This PR will fix the mistake I made in https://github.com/facebook/buck/pull/831 and fix a problem with flavors propagation mentioned in https://github.com/facebook/buck/pull/843.\r\nA few noticeable changes:\r\n1. When platform flavor is not present, `SwiftLibraryDescription` will create a place holder (`SwiftLibrary`).\r\n2. Create Swift companion target and add it in the extra deps list when necessary, this target will only be created in building target graph phrase.\r\n\r\n@ryu2 Please check if I have merge your changes correctly.\r\n@Coneko This is the approach we talked about yesterday, please have a look, love to hear your thought :)"},"comment":{"url":"https://api.github.com/repos/facebook/buck/issues/comments/242127352","html_url":"https://github.com/facebook/buck/pull/847#issuecomment-242127352","issue_url":"https://api.github.com/repos/facebook/buck/issues/847","id":242127352,"user":{"login":"Coneko","id":1614903,"avatar_url":"https://avatars.githubusercontent.com/u/1614903?v=3","gravatar_id":"","url":"https://api.github.com/users/Coneko","html_url":"https://github.com/Coneko","followers_url":"https://api.github.com/users/Coneko/followers","following_url":"https://api.github.com/users/Coneko/following{/other_user}","gists_url":"https://api.github.com/users/Coneko/gists{/gist_id}","starred_url":"https://api.github.com/users/Coneko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Coneko/subscriptions","organizations_url":"https://api.github.com/users/Coneko/orgs","repos_url":"https://api.github.com/users/Coneko/repos","events_url":"https://api.github.com/users/Coneko/events{/privacy}","received_events_url":"https://api.github.com/users/Coneko/received_events","type":"User","site_admin":false},"created_at":"2016-08-24T16:28:53Z","updated_at":"2016-08-24T16:28:53Z","body":"@facebook-github-bot shipit"}}
{"actor":{"display_login":"Coneko"}}