{"action":"created","comment":{"url":"https://api.github.com/repos/tgstation/tgstation/pulls/comments/69794245","id":69794245,"diff_hunk":"@@ -0,0 +1,50 @@\n+var/datum/subsystem/pool/SSpool\n+\n+/datum/subsystem/pool\n+\tname = \"Pool\"\n+\tinit_order = 20\n+\tflags = SS_BACKGROUND | SS_FIRE_IN_LOBBY\n+\tvar/list/global_pool\n+\tvar/list/pool_levels = list()\n+\tvar/sum = 0\n+\n+\tvar/list/maintained_types = list(\n+\t\t/obj/item/stack/tile/plasteel = 100\n+\t)\n+\n+\tvar/list/stats_placed_in_pool = list()\n+\tvar/list/stats_pooled_or_newed = list()\n+\tvar/list/stats_reused = list()\n+\tvar/list/stats_created_new = list()\n+\n+/datum/subsystem/pool/New()\n+\tNEW_SS_GLOBAL(SSpool)\n+\n+/datum/subsystem/pool/Initialize(timeofday)\n+\tglobal_pool = GlobalPool\n+\n+/datum/subsystem/pool/stat_entry(msg)\n+\tif(global_pool)\n+\t\tmsg += \"Types: [global_pool.len]|Total Pooled Objects: [sum]\"\n+\telse\n+\t\tmsg += \"NULL POOL\"\n+\t..(msg)\n+\n+/datum/subsystem/pool/fire()\n+\tsum = 0\n+\tfor(var/type in global_pool + maintained_types)\n+\t\tvar/list/L = global_pool[type]\n+\t\tvar/required_number = 0\n+\t\tif(type in maintained_types)","path":"code/controllers/subsystem/pool.dm","position":38,"original_position":38,"commit_id":"9957bf2cabbc108ce1b4c87ee1ef191fd5a85b09","original_commit_id":"9957bf2cabbc108ce1b4c87ee1ef191fd5a85b09","user":{"login":"RemieRichards","id":4043781,"avatar_url":"https://avatars.githubusercontent.com/u/4043781?v=3","gravatar_id":"","url":"https://api.github.com/users/RemieRichards","html_url":"https://github.com/RemieRichards","followers_url":"https://api.github.com/users/RemieRichards/followers","following_url":"https://api.github.com/users/RemieRichards/following{/other_user}","gists_url":"https://api.github.com/users/RemieRichards/gists{/gist_id}","starred_url":"https://api.github.com/users/RemieRichards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RemieRichards/subscriptions","organizations_url":"https://api.github.com/users/RemieRichards/orgs","repos_url":"https://api.github.com/users/RemieRichards/repos","events_url":"https://api.github.com/users/RemieRichards/events{/privacy}","received_events_url":"https://api.github.com/users/RemieRichards/received_events","type":"User","site_admin":false},"body":"```if(maintained_types[type])``` is faster","created_at":"2016-07-06T19:17:23Z","updated_at":"2016-07-06T19:17:23Z","html_url":"https://github.com/tgstation/tgstation/pull/19112#discussion_r69794245","pull_request_url":"https://api.github.com/repos/tgstation/tgstation/pulls/19112","_links":{"self":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/comments/69794245"},"html":{"href":"https://github.com/tgstation/tgstation/pull/19112#discussion_r69794245"},"pull_request":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/19112"}}},"pull_request":{"url":"https://api.github.com/repos/tgstation/tgstation/pulls/19112","id":76100196,"html_url":"https://github.com/tgstation/tgstation/pull/19112","diff_url":"https://github.com/tgstation/tgstation/pull/19112.diff","patch_url":"https://github.com/tgstation/tgstation/pull/19112.patch","issue_url":"https://api.github.com/repos/tgstation/tgstation/issues/19112","number":19112,"state":"open","locked":false,"title":"Tiles are now (mostly) pooled objects","user":{"login":"coiax","id":609465,"avatar_url":"https://avatars.githubusercontent.com/u/609465?v=3","gravatar_id":"","url":"https://api.github.com/users/coiax","html_url":"https://github.com/coiax","followers_url":"https://api.github.com/users/coiax/followers","following_url":"https://api.github.com/users/coiax/following{/other_user}","gists_url":"https://api.github.com/users/coiax/gists{/gist_id}","starred_url":"https://api.github.com/users/coiax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coiax/subscriptions","organizations_url":"https://api.github.com/users/coiax/orgs","repos_url":"https://api.github.com/users/coiax/repos","events_url":"https://api.github.com/users/coiax/events{/privacy}","received_events_url":"https://api.github.com/users/coiax/received_events","type":"User","site_admin":false},"body":"Floors no longer have a builtin_tile, but instead use PoolOrNew(). Mostly. Some things still use new, but turfs use pooled tiles.\r\n\r\nAlso added a do-nothing SSpool so you can inspect the global pool.","created_at":"2016-07-03T22:27:27Z","updated_at":"2016-07-06T19:17:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3677f55d85cff460c2d78e2ff086320bbf72244c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/tgstation/tgstation/pulls/19112/commits","review_comments_url":"https://api.github.com/repos/tgstation/tgstation/pulls/19112/comments","review_comment_url":"https://api.github.com/repos/tgstation/tgstation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tgstation/tgstation/issues/19112/comments","statuses_url":"https://api.github.com/repos/tgstation/tgstation/statuses/9957bf2cabbc108ce1b4c87ee1ef191fd5a85b09","head":{"label":"coiax:tile-pool","ref":"tile-pool","sha":"9957bf2cabbc108ce1b4c87ee1ef191fd5a85b09","user":{"login":"coiax","id":609465,"avatar_url":"https://avatars.githubusercontent.com/u/609465?v=3","gravatar_id":"","url":"https://api.github.com/users/coiax","html_url":"https://github.com/coiax","followers_url":"https://api.github.com/users/coiax/followers","following_url":"https://api.github.com/users/coiax/following{/other_user}","gists_url":"https://api.github.com/users/coiax/gists{/gist_id}","starred_url":"https://api.github.com/users/coiax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coiax/subscriptions","organizations_url":"https://api.github.com/users/coiax/orgs","repos_url":"https://api.github.com/users/coiax/repos","events_url":"https://api.github.com/users/coiax/events{/privacy}","received_events_url":"https://api.github.com/users/coiax/received_events","type":"User","site_admin":false},"repo":{"id":54189694,"name":"-tg-station","full_name":"coiax/-tg-station","owner":{"login":"coiax","id":609465,"avatar_url":"https://avatars.githubusercontent.com/u/609465?v=3","gravatar_id":"","url":"https://api.github.com/users/coiax","html_url":"https://github.com/coiax","followers_url":"https://api.github.com/users/coiax/followers","following_url":"https://api.github.com/users/coiax/following{/other_user}","gists_url":"https://api.github.com/users/coiax/gists{/gist_id}","starred_url":"https://api.github.com/users/coiax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coiax/subscriptions","organizations_url":"https://api.github.com/users/coiax/orgs","repos_url":"https://api.github.com/users/coiax/repos","events_url":"https://api.github.com/users/coiax/events{/privacy}","received_events_url":"https://api.github.com/users/coiax/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/coiax/-tg-station","description":"the /tg/station branch of SS13","fork":true,"url":"https://api.github.com/repos/coiax/-tg-station","forks_url":"https://api.github.com/repos/coiax/-tg-station/forks","keys_url":"https://api.github.com/repos/coiax/-tg-station/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coiax/-tg-station/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coiax/-tg-station/teams","hooks_url":"https://api.github.com/repos/coiax/-tg-station/hooks","issue_events_url":"https://api.github.com/repos/coiax/-tg-station/issues/events{/number}","events_url":"https://api.github.com/repos/coiax/-tg-station/events","assignees_url":"https://api.github.com/repos/coiax/-tg-station/assignees{/user}","branches_url":"https://api.github.com/repos/coiax/-tg-station/branches{/branch}","tags_url":"https://api.github.com/repos/coiax/-tg-station/tags","blobs_url":"https://api.github.com/repos/coiax/-tg-station/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coiax/-tg-station/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coiax/-tg-station/git/refs{/sha}","trees_url":"https://api.github.com/repos/coiax/-tg-station/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coiax/-tg-station/statuses/{sha}","languages_url":"https://api.github.com/repos/coiax/-tg-station/languages","stargazers_url":"https://api.github.com/repos/coiax/-tg-station/stargazers","contributors_url":"https://api.github.com/repos/coiax/-tg-station/contributors","subscribers_url":"https://api.github.com/repos/coiax/-tg-station/subscribers","subscription_url":"https://api.github.com/repos/coiax/-tg-station/subscription","commits_url":"https://api.github.com/repos/coiax/-tg-station/commits{/sha}","git_commits_url":"https://api.github.com/repos/coiax/-tg-station/git/commits{/sha}","comments_url":"https://api.github.com/repos/coiax/-tg-station/comments{/number}","issue_comment_url":"https://api.github.com/repos/coiax/-tg-station/issues/comments{/number}","contents_url":"https://api.github.com/repos/coiax/-tg-station/contents/{+path}","compare_url":"https://api.github.com/repos/coiax/-tg-station/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coiax/-tg-station/merges","archive_url":"https://api.github.com/repos/coiax/-tg-station/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coiax/-tg-station/downloads","issues_url":"https://api.github.com/repos/coiax/-tg-station/issues{/number}","pulls_url":"https://api.github.com/repos/coiax/-tg-station/pulls{/number}","milestones_url":"https://api.github.com/repos/coiax/-tg-station/milestones{/number}","notifications_url":"https://api.github.com/repos/coiax/-tg-station/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coiax/-tg-station/labels{/name}","releases_url":"https://api.github.com/repos/coiax/-tg-station/releases{/id}","deployments_url":"https://api.github.com/repos/coiax/-tg-station/deployments","created_at":"2016-03-18T09:28:37Z","updated_at":"2016-06-12T21:35:23Z","pushed_at":"2016-07-06T19:15:43Z","git_url":"git://github.com/coiax/-tg-station.git","ssh_url":"git@github.com:coiax/-tg-station.git","clone_url":"https://github.com/coiax/-tg-station.git","svn_url":"https://github.com/coiax/-tg-station","homepage":"http://www.tgstation13.org/","size":629448,"stargazers_count":1,"watchers_count":1,"language":"DM","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"tgstation:master","ref":"master","sha":"2d5fd0c9c793223f017b4bc71bb0f3895f030803","user":{"login":"tgstation","id":1363778,"avatar_url":"https://avatars.githubusercontent.com/u/1363778?v=3","gravatar_id":"","url":"https://api.github.com/users/tgstation","html_url":"https://github.com/tgstation","followers_url":"https://api.github.com/users/tgstation/followers","following_url":"https://api.github.com/users/tgstation/following{/other_user}","gists_url":"https://api.github.com/users/tgstation/gists{/gist_id}","starred_url":"https://api.github.com/users/tgstation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgstation/subscriptions","organizations_url":"https://api.github.com/users/tgstation/orgs","repos_url":"https://api.github.com/users/tgstation/repos","events_url":"https://api.github.com/users/tgstation/events{/privacy}","received_events_url":"https://api.github.com/users/tgstation/received_events","type":"Organization","site_admin":false},"repo":{"id":3234987,"name":"tgstation","full_name":"tgstation/tgstation","owner":{"login":"tgstation","id":1363778,"avatar_url":"https://avatars.githubusercontent.com/u/1363778?v=3","gravatar_id":"","url":"https://api.github.com/users/tgstation","html_url":"https://github.com/tgstation","followers_url":"https://api.github.com/users/tgstation/followers","following_url":"https://api.github.com/users/tgstation/following{/other_user}","gists_url":"https://api.github.com/users/tgstation/gists{/gist_id}","starred_url":"https://api.github.com/users/tgstation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgstation/subscriptions","organizations_url":"https://api.github.com/users/tgstation/orgs","repos_url":"https://api.github.com/users/tgstation/repos","events_url":"https://api.github.com/users/tgstation/events{/privacy}","received_events_url":"https://api.github.com/users/tgstation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tgstation/tgstation","description":"the /tg/station branch of SS13","fork":false,"url":"https://api.github.com/repos/tgstation/tgstation","forks_url":"https://api.github.com/repos/tgstation/tgstation/forks","keys_url":"https://api.github.com/repos/tgstation/tgstation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tgstation/tgstation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tgstation/tgstation/teams","hooks_url":"https://api.github.com/repos/tgstation/tgstation/hooks","issue_events_url":"https://api.github.com/repos/tgstation/tgstation/issues/events{/number}","events_url":"https://api.github.com/repos/tgstation/tgstation/events","assignees_url":"https://api.github.com/repos/tgstation/tgstation/assignees{/user}","branches_url":"https://api.github.com/repos/tgstation/tgstation/branches{/branch}","tags_url":"https://api.github.com/repos/tgstation/tgstation/tags","blobs_url":"https://api.github.com/repos/tgstation/tgstation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tgstation/tgstation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tgstation/tgstation/git/refs{/sha}","trees_url":"https://api.github.com/repos/tgstation/tgstation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tgstation/tgstation/statuses/{sha}","languages_url":"https://api.github.com/repos/tgstation/tgstation/languages","stargazers_url":"https://api.github.com/repos/tgstation/tgstation/stargazers","contributors_url":"https://api.github.com/repos/tgstation/tgstation/contributors","subscribers_url":"https://api.github.com/repos/tgstation/tgstation/subscribers","subscription_url":"https://api.github.com/repos/tgstation/tgstation/subscription","commits_url":"https://api.github.com/repos/tgstation/tgstation/commits{/sha}","git_commits_url":"https://api.github.com/repos/tgstation/tgstation/git/commits{/sha}","comments_url":"https://api.github.com/repos/tgstation/tgstation/comments{/number}","issue_comment_url":"https://api.github.com/repos/tgstation/tgstation/issues/comments{/number}","contents_url":"https://api.github.com/repos/tgstation/tgstation/contents/{+path}","compare_url":"https://api.github.com/repos/tgstation/tgstation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tgstation/tgstation/merges","archive_url":"https://api.github.com/repos/tgstation/tgstation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tgstation/tgstation/downloads","issues_url":"https://api.github.com/repos/tgstation/tgstation/issues{/number}","pulls_url":"https://api.github.com/repos/tgstation/tgstation/pulls{/number}","milestones_url":"https://api.github.com/repos/tgstation/tgstation/milestones{/number}","notifications_url":"https://api.github.com/repos/tgstation/tgstation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tgstation/tgstation/labels{/name}","releases_url":"https://api.github.com/repos/tgstation/tgstation/releases{/id}","deployments_url":"https://api.github.com/repos/tgstation/tgstation/deployments","created_at":"2012-01-21T17:32:47Z","updated_at":"2016-07-06T15:34:55Z","pushed_at":"2016-07-06T19:15:44Z","git_url":"git://github.com/tgstation/tgstation.git","ssh_url":"git@github.com:tgstation/tgstation.git","clone_url":"https://github.com/tgstation/tgstation.git","svn_url":"https://github.com/tgstation/tgstation","homepage":"http://www.tgstation13.org/","size":902942,"stargazers_count":303,"watchers_count":303,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1090,"mirror_url":null,"open_issues_count":783,"forks":1090,"open_issues":783,"watchers":303,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/19112"},"html":{"href":"https://github.com/tgstation/tgstation/pull/19112"},"issue":{"href":"https://api.github.com/repos/tgstation/tgstation/issues/19112"},"comments":{"href":"https://api.github.com/repos/tgstation/tgstation/issues/19112/comments"},"review_comments":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/19112/comments"},"review_comment":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/19112/commits"},"statuses":{"href":"https://api.github.com/repos/tgstation/tgstation/statuses/9957bf2cabbc108ce1b4c87ee1ef191fd5a85b09"}}}}
{"actor":{"display_login":"RemieRichards"}}