{"action":"created","comment":{"url":"https://api.github.com/repos/Netflix/dynomite/pulls/comments/93801045","pull_request_review_id":14338109,"id":93801045,"diff_hunk":"@@ -2286,19 +2286,24 @@ conf_validate_pool(struct conf *cf, struct conf_pool *cp)\n         log_debug(LOG_INFO, \"setting env to default value:%s\", CONF_DEFAULT_ENV);\n     }\n \n-    if (string_empty(&cp->pem_key_file)) {\n-        string_copy_c(&cp->pem_key_file, (const uint8_t *)PEM_KEY_FILE);\n-        log_debug(LOG_INFO, \"setting pem key file to default value:%s\", PEM_KEY_FILE);\n-    }\n-\n-    if (string_empty(&cp->recon_key_file)) {\n-        string_copy_c(&cp->recon_key_file, (const uint8_t *)RECON_KEY_FILE);\n-        log_debug(LOG_INFO, \"setting reconciliation key file to default value:%s\", RECON_KEY_FILE);\n-    }\n-\n-    if (string_empty(&cp->recon_iv_file)) {\n-        string_copy_c(&cp->recon_iv_file, (const uint8_t *)RECON_IV_FILE);\n-        log_debug(LOG_INFO, \"setting reconciliation IV file to default value:%s\", RECON_IV_FILE);\n+    /**\n+     * if the secure server options is not set, then no need to load KEY files\n+     */\n+    if (string_compare(&cp->secure_server_option, (const uint8_t *)CONF_STR_NONE) == 0) {","path":"src/dyn_conf.c","position":20,"original_position":20,"commit_id":"688fa118e81a46762bed700d1374370890f171c0","original_commit_id":"688fa118e81a46762bed700d1374370890f171c0","user":{"login":"ipapapa","id":4562887,"avatar_url":"https://avatars.githubusercontent.com/u/4562887?v=3","gravatar_id":"","url":"https://api.github.com/users/ipapapa","html_url":"https://github.com/ipapapa","followers_url":"https://api.github.com/users/ipapapa/followers","following_url":"https://api.github.com/users/ipapapa/following{/other_user}","gists_url":"https://api.github.com/users/ipapapa/gists{/gist_id}","starred_url":"https://api.github.com/users/ipapapa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipapapa/subscriptions","organizations_url":"https://api.github.com/users/ipapapa/orgs","repos_url":"https://api.github.com/users/ipapapa/repos","events_url":"https://api.github.com/users/ipapapa/events{/privacy}","received_events_url":"https://api.github.com/users/ipapapa/received_events","type":"User","site_admin":false},"body":"Yeah, I thought about that as well but by not setting it at all it will also bypass the issue of recon PEM files not existing. I open to other approaches...","created_at":"2016-12-23T20:48:18Z","updated_at":"2016-12-23T20:48:18Z","html_url":"https://github.com/Netflix/dynomite/pull/398#discussion_r93801045","pull_request_url":"https://api.github.com/repos/Netflix/dynomite/pulls/398","_links":{"self":{"href":"https://api.github.com/repos/Netflix/dynomite/pulls/comments/93801045"},"html":{"href":"https://github.com/Netflix/dynomite/pull/398#discussion_r93801045"},"pull_request":{"href":"https://api.github.com/repos/Netflix/dynomite/pulls/398"}}},"pull_request":{"url":"https://api.github.com/repos/Netflix/dynomite/pulls/398","id":99274308,"html_url":"https://github.com/Netflix/dynomite/pull/398","diff_url":"https://github.com/Netflix/dynomite/pull/398.diff","patch_url":"https://github.com/Netflix/dynomite/pull/398.patch","issue_url":"https://api.github.com/repos/Netflix/dynomite/issues/398","number":398,"state":"open","locked":false,"title":"making loading PEM file optional if not provided","user":{"login":"ipapapa","id":4562887,"avatar_url":"https://avatars.githubusercontent.com/u/4562887?v=3","gravatar_id":"","url":"https://api.github.com/users/ipapapa","html_url":"https://github.com/ipapapa","followers_url":"https://api.github.com/users/ipapapa/followers","following_url":"https://api.github.com/users/ipapapa/following{/other_user}","gists_url":"https://api.github.com/users/ipapapa/gists{/gist_id}","starred_url":"https://api.github.com/users/ipapapa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipapapa/subscriptions","organizations_url":"https://api.github.com/users/ipapapa/orgs","repos_url":"https://api.github.com/users/ipapapa/repos","events_url":"https://api.github.com/users/ipapapa/events{/privacy}","received_events_url":"https://api.github.com/users/ipapapa/received_events","type":"User","site_admin":false},"body":"Addresses: https://github.com/Netflix/dynomite/issues/96","created_at":"2016-12-23T19:20:10Z","updated_at":"2016-12-23T20:48:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f32fada81b5e236a7064e2445e185c7e16c6baa1","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/Netflix/dynomite/milestones/4","html_url":"https://github.com/Netflix/dynomite/milestone/4","labels_url":"https://api.github.com/repos/Netflix/dynomite/milestones/4/labels","id":2192231,"number":4,"title":"Dynomite v0.5.9","description":"","creator":{"login":"ipapapa","id":4562887,"avatar_url":"https://avatars.githubusercontent.com/u/4562887?v=3","gravatar_id":"","url":"https://api.github.com/users/ipapapa","html_url":"https://github.com/ipapapa","followers_url":"https://api.github.com/users/ipapapa/followers","following_url":"https://api.github.com/users/ipapapa/following{/other_user}","gists_url":"https://api.github.com/users/ipapapa/gists{/gist_id}","starred_url":"https://api.github.com/users/ipapapa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipapapa/subscriptions","organizations_url":"https://api.github.com/users/ipapapa/orgs","repos_url":"https://api.github.com/users/ipapapa/repos","events_url":"https://api.github.com/users/ipapapa/events{/privacy}","received_events_url":"https://api.github.com/users/ipapapa/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":16,"state":"open","created_at":"2016-12-12T21:33:17Z","updated_at":"2016-12-23T19:20:10Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Netflix/dynomite/pulls/398/commits","review_comments_url":"https://api.github.com/repos/Netflix/dynomite/pulls/398/comments","review_comment_url":"https://api.github.com/repos/Netflix/dynomite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Netflix/dynomite/issues/398/comments","statuses_url":"https://api.github.com/repos/Netflix/dynomite/statuses/688fa118e81a46762bed700d1374370890f171c0","head":{"label":"Netflix:optionalkeys","ref":"optionalkeys","sha":"688fa118e81a46762bed700d1374370890f171c0","user":{"login":"Netflix","id":913567,"avatar_url":"https://avatars.githubusercontent.com/u/913567?v=3","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"repo":{"id":13484625,"name":"dynomite","full_name":"Netflix/dynomite","owner":{"login":"Netflix","id":913567,"avatar_url":"https://avatars.githubusercontent.com/u/913567?v=3","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Netflix/dynomite","description":"A generic dynamo implementation for different k-v storage engines","fork":false,"url":"https://api.github.com/repos/Netflix/dynomite","forks_url":"https://api.github.com/repos/Netflix/dynomite/forks","keys_url":"https://api.github.com/repos/Netflix/dynomite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Netflix/dynomite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Netflix/dynomite/teams","hooks_url":"https://api.github.com/repos/Netflix/dynomite/hooks","issue_events_url":"https://api.github.com/repos/Netflix/dynomite/issues/events{/number}","events_url":"https://api.github.com/repos/Netflix/dynomite/events","assignees_url":"https://api.github.com/repos/Netflix/dynomite/assignees{/user}","branches_url":"https://api.github.com/repos/Netflix/dynomite/branches{/branch}","tags_url":"https://api.github.com/repos/Netflix/dynomite/tags","blobs_url":"https://api.github.com/repos/Netflix/dynomite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Netflix/dynomite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Netflix/dynomite/git/refs{/sha}","trees_url":"https://api.github.com/repos/Netflix/dynomite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Netflix/dynomite/statuses/{sha}","languages_url":"https://api.github.com/repos/Netflix/dynomite/languages","stargazers_url":"https://api.github.com/repos/Netflix/dynomite/stargazers","contributors_url":"https://api.github.com/repos/Netflix/dynomite/contributors","subscribers_url":"https://api.github.com/repos/Netflix/dynomite/subscribers","subscription_url":"https://api.github.com/repos/Netflix/dynomite/subscription","commits_url":"https://api.github.com/repos/Netflix/dynomite/commits{/sha}","git_commits_url":"https://api.github.com/repos/Netflix/dynomite/git/commits{/sha}","comments_url":"https://api.github.com/repos/Netflix/dynomite/comments{/number}","issue_comment_url":"https://api.github.com/repos/Netflix/dynomite/issues/comments{/number}","contents_url":"https://api.github.com/repos/Netflix/dynomite/contents/{+path}","compare_url":"https://api.github.com/repos/Netflix/dynomite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Netflix/dynomite/merges","archive_url":"https://api.github.com/repos/Netflix/dynomite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Netflix/dynomite/downloads","issues_url":"https://api.github.com/repos/Netflix/dynomite/issues{/number}","pulls_url":"https://api.github.com/repos/Netflix/dynomite/pulls{/number}","milestones_url":"https://api.github.com/repos/Netflix/dynomite/milestones{/number}","notifications_url":"https://api.github.com/repos/Netflix/dynomite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Netflix/dynomite/labels{/name}","releases_url":"https://api.github.com/repos/Netflix/dynomite/releases{/id}","deployments_url":"https://api.github.com/repos/Netflix/dynomite/deployments","created_at":"2013-10-10T22:36:31Z","updated_at":"2016-12-23T08:18:06Z","pushed_at":"2016-12-23T19:20:10Z","git_url":"git://github.com/Netflix/dynomite.git","ssh_url":"git@github.com:Netflix/dynomite.git","clone_url":"https://github.com/Netflix/dynomite.git","svn_url":"https://github.com/Netflix/dynomite","homepage":"","size":4683,"stargazers_count":1730,"watchers_count":1730,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":209,"mirror_url":null,"open_issues_count":26,"forks":209,"open_issues":26,"watchers":1730,"default_branch":"dev"}},"base":{"label":"Netflix:dev","ref":"dev","sha":"c7758b02c33290bdbfcf4d6074d61334375fd709","user":{"login":"Netflix","id":913567,"avatar_url":"https://avatars.githubusercontent.com/u/913567?v=3","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"repo":{"id":13484625,"name":"dynomite","full_name":"Netflix/dynomite","owner":{"login":"Netflix","id":913567,"avatar_url":"https://avatars.githubusercontent.com/u/913567?v=3","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Netflix/dynomite","description":"A generic dynamo implementation for different k-v storage engines","fork":false,"url":"https://api.github.com/repos/Netflix/dynomite","forks_url":"https://api.github.com/repos/Netflix/dynomite/forks","keys_url":"https://api.github.com/repos/Netflix/dynomite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Netflix/dynomite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Netflix/dynomite/teams","hooks_url":"https://api.github.com/repos/Netflix/dynomite/hooks","issue_events_url":"https://api.github.com/repos/Netflix/dynomite/issues/events{/number}","events_url":"https://api.github.com/repos/Netflix/dynomite/events","assignees_url":"https://api.github.com/repos/Netflix/dynomite/assignees{/user}","branches_url":"https://api.github.com/repos/Netflix/dynomite/branches{/branch}","tags_url":"https://api.github.com/repos/Netflix/dynomite/tags","blobs_url":"https://api.github.com/repos/Netflix/dynomite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Netflix/dynomite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Netflix/dynomite/git/refs{/sha}","trees_url":"https://api.github.com/repos/Netflix/dynomite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Netflix/dynomite/statuses/{sha}","languages_url":"https://api.github.com/repos/Netflix/dynomite/languages","stargazers_url":"https://api.github.com/repos/Netflix/dynomite/stargazers","contributors_url":"https://api.github.com/repos/Netflix/dynomite/contributors","subscribers_url":"https://api.github.com/repos/Netflix/dynomite/subscribers","subscription_url":"https://api.github.com/repos/Netflix/dynomite/subscription","commits_url":"https://api.github.com/repos/Netflix/dynomite/commits{/sha}","git_commits_url":"https://api.github.com/repos/Netflix/dynomite/git/commits{/sha}","comments_url":"https://api.github.com/repos/Netflix/dynomite/comments{/number}","issue_comment_url":"https://api.github.com/repos/Netflix/dynomite/issues/comments{/number}","contents_url":"https://api.github.com/repos/Netflix/dynomite/contents/{+path}","compare_url":"https://api.github.com/repos/Netflix/dynomite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Netflix/dynomite/merges","archive_url":"https://api.github.com/repos/Netflix/dynomite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Netflix/dynomite/downloads","issues_url":"https://api.github.com/repos/Netflix/dynomite/issues{/number}","pulls_url":"https://api.github.com/repos/Netflix/dynomite/pulls{/number}","milestones_url":"https://api.github.com/repos/Netflix/dynomite/milestones{/number}","notifications_url":"https://api.github.com/repos/Netflix/dynomite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Netflix/dynomite/labels{/name}","releases_url":"https://api.github.com/repos/Netflix/dynomite/releases{/id}","deployments_url":"https://api.github.com/repos/Netflix/dynomite/deployments","created_at":"2013-10-10T22:36:31Z","updated_at":"2016-12-23T08:18:06Z","pushed_at":"2016-12-23T19:20:10Z","git_url":"git://github.com/Netflix/dynomite.git","ssh_url":"git@github.com:Netflix/dynomite.git","clone_url":"https://github.com/Netflix/dynomite.git","svn_url":"https://github.com/Netflix/dynomite","homepage":"","size":4683,"stargazers_count":1730,"watchers_count":1730,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":209,"mirror_url":null,"open_issues_count":26,"forks":209,"open_issues":26,"watchers":1730,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Netflix/dynomite/pulls/398"},"html":{"href":"https://github.com/Netflix/dynomite/pull/398"},"issue":{"href":"https://api.github.com/repos/Netflix/dynomite/issues/398"},"comments":{"href":"https://api.github.com/repos/Netflix/dynomite/issues/398/comments"},"review_comments":{"href":"https://api.github.com/repos/Netflix/dynomite/pulls/398/comments"},"review_comment":{"href":"https://api.github.com/repos/Netflix/dynomite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Netflix/dynomite/pulls/398/commits"},"statuses":{"href":"https://api.github.com/repos/Netflix/dynomite/statuses/688fa118e81a46762bed700d1374370890f171c0"}}}}
{"actor":{"display_login":"ipapapa"}}