{"action":"created","comment":{"url":"https://api.github.com/repos/EFForg/https-everywhere/pulls/comments/81657306","pull_request_review_id":2621810,"id":81657306,"diff_hunk":"@@ -11,70 +9,23 @@\n \t* Shows profiles; mismatched, CN: profiles.theatlantic.com\n \n \n-\tProblematic domains:\n-\n-\t\t- theatlantic.com ¹\n-\t\t- assets.theatlantic.com\t(self-signed)\n-\t\t- profiles.theatlantic.com ²\n-\n-\t¹ Dropped\n-\t² Self-signed\n-\n-\n \tFully covered domains:\n-\n+\t\t- www.theatlantic.com\n \t\t- cdn.theatlantic.com\n \t\t- assets.theatlantic.com\t(→ cdn.theatlantic.com)\n-\n-\n-\tMixed content:\n-\n-\t\t- Scripts, on:\n-\n-\t\t\t- www from cdn ¹\n-\t\t\t- www from admin.brightcove.com ¹\n-\t\t\t- theatlantic.disqus.com\n-\n-\t\t- css on www from cdn ¹\n-\n-\t\t- Ads/web bugs, on www from:\n-\n-\t\t\t- atlanticmedia.122.2o7.net ¹\n-\t\t\t- api.bizographics.com ¹\n-\t\t\t- ct.buzzfeed.com ²\n-\t\t\t- siterecruit.comscore.com ¹\n-\t\t\t- ad.doubleclick.net ³\n-\t\t\t- pubads.g.doubleclick.net ³\n-\t\t\t- loadus.exelator.com ¹\n-\t\t\t- apis.google.com ¹\n-\t\t\t- widgets.outbrain.com ¹\n-\t\t\t- catrg.peer39.net ⁴\n-\t\t\t- www.reddit.com ¹\n-\t\t\t- b.scorecardresearch.com ¹\n-\t\t\t- cdn.taboolasyndication.com ¹\n-\t\t\t- a.visualrevenue.com ⁵\n-\n-\t\t- Images on www from cdn ¹\n-\n-\t¹ Secured by us\n-\t² Unsecurable\n-\t³ Rule disabled by default\n-\t⁴ Rule disabled by default <= mismatched cert\n-\t⁵ Unsecurable <= 503, akamai\n-\n -->\n-<ruleset name=\"The Atlantic.com (partial)\">\n+<ruleset name=\"The Atlantic.com\">\n \n \t<!--\tDirect rewrites:\n \t\t\t\t-->\n+\t<target host=\"www.theatlantic.com\" />\n \t<target host=\"cdn.theatlantic.com\" />\n \t<target host=\"ssl.theatlantic.com\" />","path":"src/chrome/content/rules/The_Atlantic.com.xml","position":null,"original_position":71,"commit_id":"7c3a136c20bdabd080428b7b8ba12a4759123e91","original_commit_id":"fe03d45b57e84550f88a49269c40d31f44adbead","user":{"login":"gloomy-ghost","id":13086421,"avatar_url":"https://avatars.githubusercontent.com/u/13086421?v=3","gravatar_id":"","url":"https://api.github.com/users/gloomy-ghost","html_url":"https://github.com/gloomy-ghost","followers_url":"https://api.github.com/users/gloomy-ghost/followers","following_url":"https://api.github.com/users/gloomy-ghost/following{/other_user}","gists_url":"https://api.github.com/users/gloomy-ghost/gists{/gist_id}","starred_url":"https://api.github.com/users/gloomy-ghost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gloomy-ghost/subscriptions","organizations_url":"https://api.github.com/users/gloomy-ghost/orgs","repos_url":"https://api.github.com/users/gloomy-ghost/repos","events_url":"https://api.github.com/users/gloomy-ghost/events{/privacy}","received_events_url":"https://api.github.com/users/gloomy-ghost/received_events","type":"User","site_admin":false},"body":"Don't worry about it if it is not existing anymore.","created_at":"2016-10-03T22:54:26Z","updated_at":"2016-10-03T22:54:26Z","html_url":"https://github.com/EFForg/https-everywhere/pull/6983#discussion_r81657306","pull_request_url":"https://api.github.com/repos/EFForg/https-everywhere/pulls/6983","_links":{"self":{"href":"https://api.github.com/repos/EFForg/https-everywhere/pulls/comments/81657306"},"html":{"href":"https://github.com/EFForg/https-everywhere/pull/6983#discussion_r81657306"},"pull_request":{"href":"https://api.github.com/repos/EFForg/https-everywhere/pulls/6983"}}},"pull_request":{"url":"https://api.github.com/repos/EFForg/https-everywhere/pulls/6983","id":86572272,"html_url":"https://github.com/EFForg/https-everywhere/pull/6983","diff_url":"https://github.com/EFForg/https-everywhere/pull/6983.diff","patch_url":"https://github.com/EFForg/https-everywhere/pull/6983.patch","issue_url":"https://api.github.com/repos/EFForg/https-everywhere/issues/6983","number":6983,"state":"open","locked":false,"title":"Updated HTTPS rules for TheAtlantic.com","user":{"login":"joshmaker","id":18324,"avatar_url":"https://avatars.githubusercontent.com/u/18324?v=3","gravatar_id":"","url":"https://api.github.com/users/joshmaker","html_url":"https://github.com/joshmaker","followers_url":"https://api.github.com/users/joshmaker/followers","following_url":"https://api.github.com/users/joshmaker/following{/other_user}","gists_url":"https://api.github.com/users/joshmaker/gists{/gist_id}","starred_url":"https://api.github.com/users/joshmaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshmaker/subscriptions","organizations_url":"https://api.github.com/users/joshmaker/orgs","repos_url":"https://api.github.com/users/joshmaker/repos","events_url":"https://api.github.com/users/joshmaker/events{/privacy}","received_events_url":"https://api.github.com/users/joshmaker/received_events","type":"User","site_admin":false},"body":"The Atlantic (www.theatlantic.com) now supports HTTPS. As a result the falsemixed rule file The_Atlantic.com-falsemixed.xml has been deleted and a redirect from http://www.theatlantic.com to https://www.theatlantic.com has been added to The_Atlantic.com.xml\r\n\r\nI ran the tests I could, but was unable to run the full test suite on my Macbook because `./install-dev-dependencies.sh` fails for me locally (Mac OS 10.11.6, Homebrew 0.9.9):\r\n\r\n```\r\n$ ./install-dev-dependencies.sh\r\n+ set -o errexit -o xtrace\r\n+ '[' 1365886654 '!=' 0 ']'\r\n+ SUDO_SHIM=sudo\r\n+ type apt-get\r\n./install-dev-dependencies.sh: line 10: type: apt-get: not found\r\n+ type brew\r\n+ brew list python\r\n+ brew install libxml2 gnu-sed chromedriver\r\nWarning: libxml2-2.9.4 already installed\r\nWarning: gnu-sed-4.2.2 already installed\r\n==> Downloading https://chromedriver.storage.googleapis.com/2.23/chromedriver_mac32.zip\r\n\r\ncurl: (22) The requested URL returned error: 404 Not Found\r\nError: Failed to download resource \"chromedriver\"\r\nDownload failed: https://chromedriver.storage.googleapis.com/2.23/chromedriver_mac32.zip\r\n```\r\n\r\nHappy to do further testing if possible.\r\n","created_at":"2016-09-23T20:00:59Z","updated_at":"2016-10-03T22:54:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a1cab535a17dabfbbef9e595da3448fa85d111c3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/EFForg/https-everywhere/pulls/6983/commits","review_comments_url":"https://api.github.com/repos/EFForg/https-everywhere/pulls/6983/comments","review_comment_url":"https://api.github.com/repos/EFForg/https-everywhere/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EFForg/https-everywhere/issues/6983/comments","statuses_url":"https://api.github.com/repos/EFForg/https-everywhere/statuses/7c3a136c20bdabd080428b7b8ba12a4759123e91","head":{"label":"theatlantic:master","ref":"master","sha":"7c3a136c20bdabd080428b7b8ba12a4759123e91","user":{"login":"theatlantic","id":565305,"avatar_url":"https://avatars.githubusercontent.com/u/565305?v=3","gravatar_id":"","url":"https://api.github.com/users/theatlantic","html_url":"https://github.com/theatlantic","followers_url":"https://api.github.com/users/theatlantic/followers","following_url":"https://api.github.com/users/theatlantic/following{/other_user}","gists_url":"https://api.github.com/users/theatlantic/gists{/gist_id}","starred_url":"https://api.github.com/users/theatlantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theatlantic/subscriptions","organizations_url":"https://api.github.com/users/theatlantic/orgs","repos_url":"https://api.github.com/users/theatlantic/repos","events_url":"https://api.github.com/users/theatlantic/events{/privacy}","received_events_url":"https://api.github.com/users/theatlantic/received_events","type":"Organization","site_admin":false},"repo":{"id":68756202,"name":"https-everywhere","full_name":"theatlantic/https-everywhere","owner":{"login":"theatlantic","id":565305,"avatar_url":"https://avatars.githubusercontent.com/u/565305?v=3","gravatar_id":"","url":"https://api.github.com/users/theatlantic","html_url":"https://github.com/theatlantic","followers_url":"https://api.github.com/users/theatlantic/followers","following_url":"https://api.github.com/users/theatlantic/following{/other_user}","gists_url":"https://api.github.com/users/theatlantic/gists{/gist_id}","starred_url":"https://api.github.com/users/theatlantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theatlantic/subscriptions","organizations_url":"https://api.github.com/users/theatlantic/orgs","repos_url":"https://api.github.com/users/theatlantic/repos","events_url":"https://api.github.com/users/theatlantic/events{/privacy}","received_events_url":"https://api.github.com/users/theatlantic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theatlantic/https-everywhere","description":"A browser extension that encrypts your communications with many websites that offer HTTPS but don't yet enforce it.","fork":true,"url":"https://api.github.com/repos/theatlantic/https-everywhere","forks_url":"https://api.github.com/repos/theatlantic/https-everywhere/forks","keys_url":"https://api.github.com/repos/theatlantic/https-everywhere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theatlantic/https-everywhere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theatlantic/https-everywhere/teams","hooks_url":"https://api.github.com/repos/theatlantic/https-everywhere/hooks","issue_events_url":"https://api.github.com/repos/theatlantic/https-everywhere/issues/events{/number}","events_url":"https://api.github.com/repos/theatlantic/https-everywhere/events","assignees_url":"https://api.github.com/repos/theatlantic/https-everywhere/assignees{/user}","branches_url":"https://api.github.com/repos/theatlantic/https-everywhere/branches{/branch}","tags_url":"https://api.github.com/repos/theatlantic/https-everywhere/tags","blobs_url":"https://api.github.com/repos/theatlantic/https-everywhere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theatlantic/https-everywhere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theatlantic/https-everywhere/git/refs{/sha}","trees_url":"https://api.github.com/repos/theatlantic/https-everywhere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theatlantic/https-everywhere/statuses/{sha}","languages_url":"https://api.github.com/repos/theatlantic/https-everywhere/languages","stargazers_url":"https://api.github.com/repos/theatlantic/https-everywhere/stargazers","contributors_url":"https://api.github.com/repos/theatlantic/https-everywhere/contributors","subscribers_url":"https://api.github.com/repos/theatlantic/https-everywhere/subscribers","subscription_url":"https://api.github.com/repos/theatlantic/https-everywhere/subscription","commits_url":"https://api.github.com/repos/theatlantic/https-everywhere/commits{/sha}","git_commits_url":"https://api.github.com/repos/theatlantic/https-everywhere/git/commits{/sha}","comments_url":"https://api.github.com/repos/theatlantic/https-everywhere/comments{/number}","issue_comment_url":"https://api.github.com/repos/theatlantic/https-everywhere/issues/comments{/number}","contents_url":"https://api.github.com/repos/theatlantic/https-everywhere/contents/{+path}","compare_url":"https://api.github.com/repos/theatlantic/https-everywhere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theatlantic/https-everywhere/merges","archive_url":"https://api.github.com/repos/theatlantic/https-everywhere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theatlantic/https-everywhere/downloads","issues_url":"https://api.github.com/repos/theatlantic/https-everywhere/issues{/number}","pulls_url":"https://api.github.com/repos/theatlantic/https-everywhere/pulls{/number}","milestones_url":"https://api.github.com/repos/theatlantic/https-everywhere/milestones{/number}","notifications_url":"https://api.github.com/repos/theatlantic/https-everywhere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theatlantic/https-everywhere/labels{/name}","releases_url":"https://api.github.com/repos/theatlantic/https-everywhere/releases{/id}","deployments_url":"https://api.github.com/repos/theatlantic/https-everywhere/deployments","created_at":"2016-09-20T21:48:57Z","updated_at":"2016-09-20T21:50:03Z","pushed_at":"2016-10-03T22:19:16Z","git_url":"git://github.com/theatlantic/https-everywhere.git","ssh_url":"git@github.com:theatlantic/https-everywhere.git","clone_url":"https://github.com/theatlantic/https-everywhere.git","svn_url":"https://github.com/theatlantic/https-everywhere","homepage":"https://eff.org/https-everywhere","size":161444,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"EFForg:master","ref":"master","sha":"342768f2a9f1a5ff2a7fc3e1508e9751ed3cf1f4","user":{"login":"EFForg","id":2120271,"avatar_url":"https://avatars.githubusercontent.com/u/2120271?v=3","gravatar_id":"","url":"https://api.github.com/users/EFForg","html_url":"https://github.com/EFForg","followers_url":"https://api.github.com/users/EFForg/followers","following_url":"https://api.github.com/users/EFForg/following{/other_user}","gists_url":"https://api.github.com/users/EFForg/gists{/gist_id}","starred_url":"https://api.github.com/users/EFForg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EFForg/subscriptions","organizations_url":"https://api.github.com/users/EFForg/orgs","repos_url":"https://api.github.com/users/EFForg/repos","events_url":"https://api.github.com/users/EFForg/events{/privacy}","received_events_url":"https://api.github.com/users/EFForg/received_events","type":"Organization","site_admin":false},"repo":{"id":14939303,"name":"https-everywhere","full_name":"EFForg/https-everywhere","owner":{"login":"EFForg","id":2120271,"avatar_url":"https://avatars.githubusercontent.com/u/2120271?v=3","gravatar_id":"","url":"https://api.github.com/users/EFForg","html_url":"https://github.com/EFForg","followers_url":"https://api.github.com/users/EFForg/followers","following_url":"https://api.github.com/users/EFForg/following{/other_user}","gists_url":"https://api.github.com/users/EFForg/gists{/gist_id}","starred_url":"https://api.github.com/users/EFForg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EFForg/subscriptions","organizations_url":"https://api.github.com/users/EFForg/orgs","repos_url":"https://api.github.com/users/EFForg/repos","events_url":"https://api.github.com/users/EFForg/events{/privacy}","received_events_url":"https://api.github.com/users/EFForg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EFForg/https-everywhere","description":"A browser extension that encrypts your communications with many websites that offer HTTPS but don't yet enforce it.","fork":false,"url":"https://api.github.com/repos/EFForg/https-everywhere","forks_url":"https://api.github.com/repos/EFForg/https-everywhere/forks","keys_url":"https://api.github.com/repos/EFForg/https-everywhere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EFForg/https-everywhere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EFForg/https-everywhere/teams","hooks_url":"https://api.github.com/repos/EFForg/https-everywhere/hooks","issue_events_url":"https://api.github.com/repos/EFForg/https-everywhere/issues/events{/number}","events_url":"https://api.github.com/repos/EFForg/https-everywhere/events","assignees_url":"https://api.github.com/repos/EFForg/https-everywhere/assignees{/user}","branches_url":"https://api.github.com/repos/EFForg/https-everywhere/branches{/branch}","tags_url":"https://api.github.com/repos/EFForg/https-everywhere/tags","blobs_url":"https://api.github.com/repos/EFForg/https-everywhere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EFForg/https-everywhere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EFForg/https-everywhere/git/refs{/sha}","trees_url":"https://api.github.com/repos/EFForg/https-everywhere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EFForg/https-everywhere/statuses/{sha}","languages_url":"https://api.github.com/repos/EFForg/https-everywhere/languages","stargazers_url":"https://api.github.com/repos/EFForg/https-everywhere/stargazers","contributors_url":"https://api.github.com/repos/EFForg/https-everywhere/contributors","subscribers_url":"https://api.github.com/repos/EFForg/https-everywhere/subscribers","subscription_url":"https://api.github.com/repos/EFForg/https-everywhere/subscription","commits_url":"https://api.github.com/repos/EFForg/https-everywhere/commits{/sha}","git_commits_url":"https://api.github.com/repos/EFForg/https-everywhere/git/commits{/sha}","comments_url":"https://api.github.com/repos/EFForg/https-everywhere/comments{/number}","issue_comment_url":"https://api.github.com/repos/EFForg/https-everywhere/issues/comments{/number}","contents_url":"https://api.github.com/repos/EFForg/https-everywhere/contents/{+path}","compare_url":"https://api.github.com/repos/EFForg/https-everywhere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EFForg/https-everywhere/merges","archive_url":"https://api.github.com/repos/EFForg/https-everywhere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EFForg/https-everywhere/downloads","issues_url":"https://api.github.com/repos/EFForg/https-everywhere/issues{/number}","pulls_url":"https://api.github.com/repos/EFForg/https-everywhere/pulls{/number}","milestones_url":"https://api.github.com/repos/EFForg/https-everywhere/milestones{/number}","notifications_url":"https://api.github.com/repos/EFForg/https-everywhere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EFForg/https-everywhere/labels{/name}","releases_url":"https://api.github.com/repos/EFForg/https-everywhere/releases{/id}","deployments_url":"https://api.github.com/repos/EFForg/https-everywhere/deployments","created_at":"2013-12-04T23:53:07Z","updated_at":"2016-10-03T17:20:09Z","pushed_at":"2016-10-03T22:19:21Z","git_url":"git://github.com/EFForg/https-everywhere.git","ssh_url":"git@github.com:EFForg/https-everywhere.git","clone_url":"https://github.com/EFForg/https-everywhere.git","svn_url":"https://github.com/EFForg/https-everywhere","homepage":"https://eff.org/https-everywhere","size":305330,"stargazers_count":1233,"watchers_count":1233,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":663,"mirror_url":null,"open_issues_count":1006,"forks":663,"open_issues":1006,"watchers":1233,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EFForg/https-everywhere/pulls/6983"},"html":{"href":"https://github.com/EFForg/https-everywhere/pull/6983"},"issue":{"href":"https://api.github.com/repos/EFForg/https-everywhere/issues/6983"},"comments":{"href":"https://api.github.com/repos/EFForg/https-everywhere/issues/6983/comments"},"review_comments":{"href":"https://api.github.com/repos/EFForg/https-everywhere/pulls/6983/comments"},"review_comment":{"href":"https://api.github.com/repos/EFForg/https-everywhere/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EFForg/https-everywhere/pulls/6983/commits"},"statuses":{"href":"https://api.github.com/repos/EFForg/https-everywhere/statuses/7c3a136c20bdabd080428b7b8ba12a4759123e91"}}}}
{"actor":{"display_login":"gloomy-ghost"}}