{"action":"created","comment":{"url":"https://api.github.com/repos/doshprompt/angular-localization/pulls/comments/53996574","id":53996574,"diff_hunk":"@@ -63,28 +65,40 @@ angular.module('ngLocalize')\n \n                 locale.ready(langFiles).then(function () {\n                     var value = '';\n-\n                     for(var key in values) {\n                         exp = values[key];\n                         value = locale.getString(exp);\n                         if (lastValues[key] !== value) {\n-                            attrs.$set(attrs.$normalize(key), lastValues[key] = value);\n+                            lastValues[key] = value;\n+                            setAttr(attrs, key, value);\n                         }\n                     }\n                 });\n-            }\n+            };\n+        }\n+        return {","path":"src/localization.directives.js","position":45,"original_position":45,"commit_id":"8edece663492ba19895d1dc9b1524cd00c305e76","original_commit_id":"8edece663492ba19895d1dc9b1524cd00c305e76","user":{"login":"doshprompt","id":1147078,"avatar_url":"https://avatars.githubusercontent.com/u/1147078?v=3","gravatar_id":"","url":"https://api.github.com/users/doshprompt","html_url":"https://github.com/doshprompt","followers_url":"https://api.github.com/users/doshprompt/followers","following_url":"https://api.github.com/users/doshprompt/following{/other_user}","gists_url":"https://api.github.com/users/doshprompt/gists{/gist_id}","starred_url":"https://api.github.com/users/doshprompt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doshprompt/subscriptions","organizations_url":"https://api.github.com/users/doshprompt/orgs","repos_url":"https://api.github.com/users/doshprompt/repos","events_url":"https://api.github.com/users/doshprompt/events{/privacy}","received_events_url":"https://api.github.com/users/doshprompt/received_events","type":"User","site_admin":false},"body":"newline","created_at":"2016-02-24T19:53:12Z","updated_at":"2016-02-24T19:53:12Z","html_url":"https://github.com/doshprompt/angular-localization/pull/91#discussion_r53996574","pull_request_url":"https://api.github.com/repos/doshprompt/angular-localization/pulls/91","_links":{"self":{"href":"https://api.github.com/repos/doshprompt/angular-localization/pulls/comments/53996574"},"html":{"href":"https://github.com/doshprompt/angular-localization/pull/91#discussion_r53996574"},"pull_request":{"href":"https://api.github.com/repos/doshprompt/angular-localization/pulls/91"}}},"pull_request":{"url":"https://api.github.com/repos/doshprompt/angular-localization/pulls/91","id":60460424,"html_url":"https://github.com/doshprompt/angular-localization/pull/91","diff_url":"https://github.com/doshprompt/angular-localization/pull/91.diff","patch_url":"https://github.com/doshprompt/angular-localization/pull/91.patch","issue_url":"https://api.github.com/repos/doshprompt/angular-localization/issues/91","number":91,"state":"open","locked":false,"title":"feat(i18nAttr): avoids the aria-label warning","user":{"login":"bretkikehara","id":853008,"avatar_url":"https://avatars.githubusercontent.com/u/853008?v=3","gravatar_id":"","url":"https://api.github.com/users/bretkikehara","html_url":"https://github.com/bretkikehara","followers_url":"https://api.github.com/users/bretkikehara/followers","following_url":"https://api.github.com/users/bretkikehara/following{/other_user}","gists_url":"https://api.github.com/users/bretkikehara/gists{/gist_id}","starred_url":"https://api.github.com/users/bretkikehara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bretkikehara/subscriptions","organizations_url":"https://api.github.com/users/bretkikehara/orgs","repos_url":"https://api.github.com/users/bretkikehara/repos","events_url":"https://api.github.com/users/bretkikehara/events{/privacy}","received_events_url":"https://api.github.com/users/bretkikehara/received_events","type":"User","site_admin":false},"body":"add default attributes before resolving lang files.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.svg\" height=\"40\" alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/doshprompt/angular-localization/91)\n<!-- Reviewable:end -->\n","created_at":"2016-02-24T05:57:53Z","updated_at":"2016-02-24T19:53:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"87db0a605c5d09dc8b2dc8e7ff9b9dde60599feb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/doshprompt/angular-localization/pulls/91/commits","review_comments_url":"https://api.github.com/repos/doshprompt/angular-localization/pulls/91/comments","review_comment_url":"https://api.github.com/repos/doshprompt/angular-localization/pulls/comments{/number}","comments_url":"https://api.github.com/repos/doshprompt/angular-localization/issues/91/comments","statuses_url":"https://api.github.com/repos/doshprompt/angular-localization/statuses/8edece663492ba19895d1dc9b1524cd00c305e76","head":{"label":"bretkikehara:feat-aria-warning","ref":"feat-aria-warning","sha":"8edece663492ba19895d1dc9b1524cd00c305e76","user":{"login":"bretkikehara","id":853008,"avatar_url":"https://avatars.githubusercontent.com/u/853008?v=3","gravatar_id":"","url":"https://api.github.com/users/bretkikehara","html_url":"https://github.com/bretkikehara","followers_url":"https://api.github.com/users/bretkikehara/followers","following_url":"https://api.github.com/users/bretkikehara/following{/other_user}","gists_url":"https://api.github.com/users/bretkikehara/gists{/gist_id}","starred_url":"https://api.github.com/users/bretkikehara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bretkikehara/subscriptions","organizations_url":"https://api.github.com/users/bretkikehara/orgs","repos_url":"https://api.github.com/users/bretkikehara/repos","events_url":"https://api.github.com/users/bretkikehara/events{/privacy}","received_events_url":"https://api.github.com/users/bretkikehara/received_events","type":"User","site_admin":false},"repo":{"id":42267999,"name":"angular-localization","full_name":"bretkikehara/angular-localization","owner":{"login":"bretkikehara","id":853008,"avatar_url":"https://avatars.githubusercontent.com/u/853008?v=3","gravatar_id":"","url":"https://api.github.com/users/bretkikehara","html_url":"https://github.com/bretkikehara","followers_url":"https://api.github.com/users/bretkikehara/followers","following_url":"https://api.github.com/users/bretkikehara/following{/other_user}","gists_url":"https://api.github.com/users/bretkikehara/gists{/gist_id}","starred_url":"https://api.github.com/users/bretkikehara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bretkikehara/subscriptions","organizations_url":"https://api.github.com/users/bretkikehara/orgs","repos_url":"https://api.github.com/users/bretkikehara/repos","events_url":"https://api.github.com/users/bretkikehara/events{/privacy}","received_events_url":"https://api.github.com/users/bretkikehara/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bretkikehara/angular-localization","description":"angularjs localization done right.","fork":true,"url":"https://api.github.com/repos/bretkikehara/angular-localization","forks_url":"https://api.github.com/repos/bretkikehara/angular-localization/forks","keys_url":"https://api.github.com/repos/bretkikehara/angular-localization/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bretkikehara/angular-localization/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bretkikehara/angular-localization/teams","hooks_url":"https://api.github.com/repos/bretkikehara/angular-localization/hooks","issue_events_url":"https://api.github.com/repos/bretkikehara/angular-localization/issues/events{/number}","events_url":"https://api.github.com/repos/bretkikehara/angular-localization/events","assignees_url":"https://api.github.com/repos/bretkikehara/angular-localization/assignees{/user}","branches_url":"https://api.github.com/repos/bretkikehara/angular-localization/branches{/branch}","tags_url":"https://api.github.com/repos/bretkikehara/angular-localization/tags","blobs_url":"https://api.github.com/repos/bretkikehara/angular-localization/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bretkikehara/angular-localization/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bretkikehara/angular-localization/git/refs{/sha}","trees_url":"https://api.github.com/repos/bretkikehara/angular-localization/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bretkikehara/angular-localization/statuses/{sha}","languages_url":"https://api.github.com/repos/bretkikehara/angular-localization/languages","stargazers_url":"https://api.github.com/repos/bretkikehara/angular-localization/stargazers","contributors_url":"https://api.github.com/repos/bretkikehara/angular-localization/contributors","subscribers_url":"https://api.github.com/repos/bretkikehara/angular-localization/subscribers","subscription_url":"https://api.github.com/repos/bretkikehara/angular-localization/subscription","commits_url":"https://api.github.com/repos/bretkikehara/angular-localization/commits{/sha}","git_commits_url":"https://api.github.com/repos/bretkikehara/angular-localization/git/commits{/sha}","comments_url":"https://api.github.com/repos/bretkikehara/angular-localization/comments{/number}","issue_comment_url":"https://api.github.com/repos/bretkikehara/angular-localization/issues/comments{/number}","contents_url":"https://api.github.com/repos/bretkikehara/angular-localization/contents/{+path}","compare_url":"https://api.github.com/repos/bretkikehara/angular-localization/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bretkikehara/angular-localization/merges","archive_url":"https://api.github.com/repos/bretkikehara/angular-localization/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bretkikehara/angular-localization/downloads","issues_url":"https://api.github.com/repos/bretkikehara/angular-localization/issues{/number}","pulls_url":"https://api.github.com/repos/bretkikehara/angular-localization/pulls{/number}","milestones_url":"https://api.github.com/repos/bretkikehara/angular-localization/milestones{/number}","notifications_url":"https://api.github.com/repos/bretkikehara/angular-localization/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bretkikehara/angular-localization/labels{/name}","releases_url":"https://api.github.com/repos/bretkikehara/angular-localization/releases{/id}","deployments_url":"https://api.github.com/repos/bretkikehara/angular-localization/deployments","created_at":"2015-09-10T20:07:26Z","updated_at":"2015-09-10T20:07:27Z","pushed_at":"2016-02-24T06:57:07Z","git_url":"git://github.com/bretkikehara/angular-localization.git","ssh_url":"git@github.com:bretkikehara/angular-localization.git","clone_url":"https://github.com/bretkikehara/angular-localization.git","svn_url":"https://github.com/bretkikehara/angular-localization","homepage":"http://doshprompt.github.io/angular-localization","size":1262,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"doshprompt:master","ref":"master","sha":"9e97a171d8da0f7d56d4bc284b6dadf71d06a296","user":{"login":"doshprompt","id":1147078,"avatar_url":"https://avatars.githubusercontent.com/u/1147078?v=3","gravatar_id":"","url":"https://api.github.com/users/doshprompt","html_url":"https://github.com/doshprompt","followers_url":"https://api.github.com/users/doshprompt/followers","following_url":"https://api.github.com/users/doshprompt/following{/other_user}","gists_url":"https://api.github.com/users/doshprompt/gists{/gist_id}","starred_url":"https://api.github.com/users/doshprompt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doshprompt/subscriptions","organizations_url":"https://api.github.com/users/doshprompt/orgs","repos_url":"https://api.github.com/users/doshprompt/repos","events_url":"https://api.github.com/users/doshprompt/events{/privacy}","received_events_url":"https://api.github.com/users/doshprompt/received_events","type":"User","site_admin":false},"repo":{"id":20308557,"name":"angular-localization","full_name":"doshprompt/angular-localization","owner":{"login":"doshprompt","id":1147078,"avatar_url":"https://avatars.githubusercontent.com/u/1147078?v=3","gravatar_id":"","url":"https://api.github.com/users/doshprompt","html_url":"https://github.com/doshprompt","followers_url":"https://api.github.com/users/doshprompt/followers","following_url":"https://api.github.com/users/doshprompt/following{/other_user}","gists_url":"https://api.github.com/users/doshprompt/gists{/gist_id}","starred_url":"https://api.github.com/users/doshprompt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doshprompt/subscriptions","organizations_url":"https://api.github.com/users/doshprompt/orgs","repos_url":"https://api.github.com/users/doshprompt/repos","events_url":"https://api.github.com/users/doshprompt/events{/privacy}","received_events_url":"https://api.github.com/users/doshprompt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/doshprompt/angular-localization","description":"angularjs localization done right.","fork":false,"url":"https://api.github.com/repos/doshprompt/angular-localization","forks_url":"https://api.github.com/repos/doshprompt/angular-localization/forks","keys_url":"https://api.github.com/repos/doshprompt/angular-localization/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doshprompt/angular-localization/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doshprompt/angular-localization/teams","hooks_url":"https://api.github.com/repos/doshprompt/angular-localization/hooks","issue_events_url":"https://api.github.com/repos/doshprompt/angular-localization/issues/events{/number}","events_url":"https://api.github.com/repos/doshprompt/angular-localization/events","assignees_url":"https://api.github.com/repos/doshprompt/angular-localization/assignees{/user}","branches_url":"https://api.github.com/repos/doshprompt/angular-localization/branches{/branch}","tags_url":"https://api.github.com/repos/doshprompt/angular-localization/tags","blobs_url":"https://api.github.com/repos/doshprompt/angular-localization/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doshprompt/angular-localization/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doshprompt/angular-localization/git/refs{/sha}","trees_url":"https://api.github.com/repos/doshprompt/angular-localization/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doshprompt/angular-localization/statuses/{sha}","languages_url":"https://api.github.com/repos/doshprompt/angular-localization/languages","stargazers_url":"https://api.github.com/repos/doshprompt/angular-localization/stargazers","contributors_url":"https://api.github.com/repos/doshprompt/angular-localization/contributors","subscribers_url":"https://api.github.com/repos/doshprompt/angular-localization/subscribers","subscription_url":"https://api.github.com/repos/doshprompt/angular-localization/subscription","commits_url":"https://api.github.com/repos/doshprompt/angular-localization/commits{/sha}","git_commits_url":"https://api.github.com/repos/doshprompt/angular-localization/git/commits{/sha}","comments_url":"https://api.github.com/repos/doshprompt/angular-localization/comments{/number}","issue_comment_url":"https://api.github.com/repos/doshprompt/angular-localization/issues/comments{/number}","contents_url":"https://api.github.com/repos/doshprompt/angular-localization/contents/{+path}","compare_url":"https://api.github.com/repos/doshprompt/angular-localization/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doshprompt/angular-localization/merges","archive_url":"https://api.github.com/repos/doshprompt/angular-localization/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doshprompt/angular-localization/downloads","issues_url":"https://api.github.com/repos/doshprompt/angular-localization/issues{/number}","pulls_url":"https://api.github.com/repos/doshprompt/angular-localization/pulls{/number}","milestones_url":"https://api.github.com/repos/doshprompt/angular-localization/milestones{/number}","notifications_url":"https://api.github.com/repos/doshprompt/angular-localization/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doshprompt/angular-localization/labels{/name}","releases_url":"https://api.github.com/repos/doshprompt/angular-localization/releases{/id}","deployments_url":"https://api.github.com/repos/doshprompt/angular-localization/deployments","created_at":"2014-05-29T21:08:45Z","updated_at":"2016-02-19T12:43:10Z","pushed_at":"2016-02-24T06:15:40Z","git_url":"git://github.com/doshprompt/angular-localization.git","ssh_url":"git@github.com:doshprompt/angular-localization.git","clone_url":"https://github.com/doshprompt/angular-localization.git","svn_url":"https://github.com/doshprompt/angular-localization","homepage":"http://doshprompt.github.io/angular-localization","size":1341,"stargazers_count":128,"watchers_count":128,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":45,"mirror_url":null,"open_issues_count":41,"forks":45,"open_issues":41,"watchers":128,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/doshprompt/angular-localization/pulls/91"},"html":{"href":"https://github.com/doshprompt/angular-localization/pull/91"},"issue":{"href":"https://api.github.com/repos/doshprompt/angular-localization/issues/91"},"comments":{"href":"https://api.github.com/repos/doshprompt/angular-localization/issues/91/comments"},"review_comments":{"href":"https://api.github.com/repos/doshprompt/angular-localization/pulls/91/comments"},"review_comment":{"href":"https://api.github.com/repos/doshprompt/angular-localization/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/doshprompt/angular-localization/pulls/91/commits"},"statuses":{"href":"https://api.github.com/repos/doshprompt/angular-localization/statuses/8edece663492ba19895d1dc9b1524cd00c305e76"}}}}