{"action":"created","issue":{"url":"https://api.github.com/repos/twingly/twingly-search-api-ruby/issues/51","repository_url":"https://api.github.com/repos/twingly/twingly-search-api-ruby","labels_url":"https://api.github.com/repos/twingly/twingly-search-api-ruby/issues/51/labels{/name}","comments_url":"https://api.github.com/repos/twingly/twingly-search-api-ruby/issues/51/comments","events_url":"https://api.github.com/repos/twingly/twingly-search-api-ruby/issues/51/events","html_url":"https://github.com/twingly/twingly-search-api-ruby/pull/51","id":134275018,"number":51,"title":"Improve time handling","user":{"login":"dentarg","id":42626,"avatar_url":"https://avatars.githubusercontent.com/u/42626?v=3","gravatar_id":"","url":"https://api.github.com/users/dentarg","html_url":"https://github.com/dentarg","followers_url":"https://api.github.com/users/dentarg/followers","following_url":"https://api.github.com/users/dentarg/following{/other_user}","gists_url":"https://api.github.com/users/dentarg/gists{/gist_id}","starred_url":"https://api.github.com/users/dentarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dentarg/subscriptions","organizations_url":"https://api.github.com/users/dentarg/orgs","repos_url":"https://api.github.com/users/dentarg/repos","events_url":"https://api.github.com/users/dentarg/events{/privacy}","received_events_url":"https://api.github.com/users/dentarg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-17T13:08:31Z","updated_at":"2016-02-17T13:36:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/twingly/twingly-search-api-ruby/pulls/51","html_url":"https://github.com/twingly/twingly-search-api-ruby/pull/51","diff_url":"https://github.com/twingly/twingly-search-api-ruby/pull/51.diff","patch_url":"https://github.com/twingly/twingly-search-api-ruby/pull/51.patch"},"body":"What do we think about this?"},"comment":{"url":"https://api.github.com/repos/twingly/twingly-search-api-ruby/issues/comments/185206063","html_url":"https://github.com/twingly/twingly-search-api-ruby/pull/51#issuecomment-185206063","issue_url":"https://api.github.com/repos/twingly/twingly-search-api-ruby/issues/51","id":185206063,"user":{"login":"jage","id":7913,"avatar_url":"https://avatars.githubusercontent.com/u/7913?v=3","gravatar_id":"","url":"https://api.github.com/users/jage","html_url":"https://github.com/jage","followers_url":"https://api.github.com/users/jage/followers","following_url":"https://api.github.com/users/jage/following{/other_user}","gists_url":"https://api.github.com/users/jage/gists{/gist_id}","starred_url":"https://api.github.com/users/jage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jage/subscriptions","organizations_url":"https://api.github.com/users/jage/orgs","repos_url":"https://api.github.com/users/jage/repos","events_url":"https://api.github.com/users/jage/events{/privacy}","received_events_url":"https://api.github.com/users/jage/received_events","type":"User","site_admin":false},"created_at":"2016-02-17T13:36:14Z","updated_at":"2016-02-17T13:36:14Z","body":"Looks good, I'm thinking maybe should think about what happens when a non-compliant object passed on. At least document with a spec that it will blow up, but it might be even better to do an assertion in the setter and raise a more helpful error.\r\n\r\nSomething like:\r\n\r\n```Ruby\r\n    context \"when given non-time object\" do\r\n      let(:time) { \"2013-12-28+09%3A01%3A22\" }\r\n\r\n      it \"should raise exception\" do\r\n        expect { subject.request_parameters }.to raise_error(NoMethodError)\r\n      end\r\n    end\r\n```"}}