{"action":"created","comment":{"url":"https://api.github.com/repos/airbnb/superset/pulls/comments/91774227","pull_request_review_id":12286713,"id":91774227,"diff_hunk":"@@ -123,7 +123,7 @@ class QueryTable extends React.PureComponent {\n           />\n         );\n       } else {\n-        q.output = q.tempTable;\n+        q.output = [q.schema, q.tempTable].filter((v) => (v)).join('.');","path":"superset/assets/javascripts/SqlLab/components/QueryTable.jsx","position":5,"original_position":5,"commit_id":"f0b7cf7cfb15484eaaa947cc00cb581180d8046d","original_commit_id":"f0b7cf7cfb15484eaaa947cc00cb581180d8046d","user":{"login":"bkyryliuk","id":5727938,"avatar_url":"https://avatars.githubusercontent.com/u/5727938?v=3","gravatar_id":"","url":"https://api.github.com/users/bkyryliuk","html_url":"https://github.com/bkyryliuk","followers_url":"https://api.github.com/users/bkyryliuk/followers","following_url":"https://api.github.com/users/bkyryliuk/following{/other_user}","gists_url":"https://api.github.com/users/bkyryliuk/gists{/gist_id}","starred_url":"https://api.github.com/users/bkyryliuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkyryliuk/subscriptions","organizations_url":"https://api.github.com/users/bkyryliuk/orgs","repos_url":"https://api.github.com/users/bkyryliuk/repos","events_url":"https://api.github.com/users/bkyryliuk/events{/privacy}","received_events_url":"https://api.github.com/users/bkyryliuk/received_events","type":"User","site_admin":false},"body":"nice!","created_at":"2016-12-09T19:02:23Z","updated_at":"2016-12-09T19:02:23Z","html_url":"https://github.com/airbnb/superset/pull/1790#discussion_r91774227","pull_request_url":"https://api.github.com/repos/airbnb/superset/pulls/1790","_links":{"self":{"href":"https://api.github.com/repos/airbnb/superset/pulls/comments/91774227"},"html":{"href":"https://github.com/airbnb/superset/pull/1790#discussion_r91774227"},"pull_request":{"href":"https://api.github.com/repos/airbnb/superset/pulls/1790"}}},"pull_request":{"url":"https://api.github.com/repos/airbnb/superset/pulls/1790","id":96962379,"html_url":"https://github.com/airbnb/superset/pull/1790","diff_url":"https://github.com/airbnb/superset/pull/1790.diff","patch_url":"https://github.com/airbnb/superset/pull/1790.patch","issue_url":"https://api.github.com/repos/airbnb/superset/issues/1790","number":1790,"state":"open","locked":false,"title":"Add schema name to output column in query history","user":{"login":"vera-liu","id":20978302,"avatar_url":"https://avatars.githubusercontent.com/u/20978302?v=3","gravatar_id":"","url":"https://api.github.com/users/vera-liu","html_url":"https://github.com/vera-liu","followers_url":"https://api.github.com/users/vera-liu/followers","following_url":"https://api.github.com/users/vera-liu/following{/other_user}","gists_url":"https://api.github.com/users/vera-liu/gists{/gist_id}","starred_url":"https://api.github.com/users/vera-liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vera-liu/subscriptions","organizations_url":"https://api.github.com/users/vera-liu/orgs","repos_url":"https://api.github.com/users/vera-liu/repos","events_url":"https://api.github.com/users/vera-liu/events{/privacy}","received_events_url":"https://api.github.com/users/vera-liu/received_events","type":"User","site_admin":false},"body":"Issue: \r\n - temp table name is shown in output when query is not run using ctas [https://github.com/airbnb/superset/issues/1745](url)\r\n - schema name is not shown in output [https://github.com/airbnb/superset/issues/1708](url)\r\n\r\nDone:\r\n - when query was not run as ctas, leave output column empty\r\n - add schema name before temp table name for queries run using ctas\r\n\r\nneeds-review @ascott @bkyryliuk @mistercrunch \r\n","created_at":"2016-12-07T16:50:37Z","updated_at":"2016-12-09T19:02:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9bd442e0609cd10e8215f855c01dc1c46672df4a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/airbnb/superset/pulls/1790/commits","review_comments_url":"https://api.github.com/repos/airbnb/superset/pulls/1790/comments","review_comment_url":"https://api.github.com/repos/airbnb/superset/pulls/comments{/number}","comments_url":"https://api.github.com/repos/airbnb/superset/issues/1790/comments","statuses_url":"https://api.github.com/repos/airbnb/superset/statuses/f0b7cf7cfb15484eaaa947cc00cb581180d8046d","head":{"label":"vera-liu:vliu_query_output","ref":"vliu_query_output","sha":"f0b7cf7cfb15484eaaa947cc00cb581180d8046d","user":{"login":"vera-liu","id":20978302,"avatar_url":"https://avatars.githubusercontent.com/u/20978302?v=3","gravatar_id":"","url":"https://api.github.com/users/vera-liu","html_url":"https://github.com/vera-liu","followers_url":"https://api.github.com/users/vera-liu/followers","following_url":"https://api.github.com/users/vera-liu/following{/other_user}","gists_url":"https://api.github.com/users/vera-liu/gists{/gist_id}","starred_url":"https://api.github.com/users/vera-liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vera-liu/subscriptions","organizations_url":"https://api.github.com/users/vera-liu/orgs","repos_url":"https://api.github.com/users/vera-liu/repos","events_url":"https://api.github.com/users/vera-liu/events{/privacy}","received_events_url":"https://api.github.com/users/vera-liu/received_events","type":"User","site_admin":false},"repo":{"id":65501764,"name":"caravel","full_name":"vera-liu/caravel","owner":{"login":"vera-liu","id":20978302,"avatar_url":"https://avatars.githubusercontent.com/u/20978302?v=3","gravatar_id":"","url":"https://api.github.com/users/vera-liu","html_url":"https://github.com/vera-liu","followers_url":"https://api.github.com/users/vera-liu/followers","following_url":"https://api.github.com/users/vera-liu/following{/other_user}","gists_url":"https://api.github.com/users/vera-liu/gists{/gist_id}","starred_url":"https://api.github.com/users/vera-liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vera-liu/subscriptions","organizations_url":"https://api.github.com/users/vera-liu/orgs","repos_url":"https://api.github.com/users/vera-liu/repos","events_url":"https://api.github.com/users/vera-liu/events{/privacy}","received_events_url":"https://api.github.com/users/vera-liu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vera-liu/caravel","description":"Caravel is a data exploration platform designed to be visual, intuitive, and interactive","fork":true,"url":"https://api.github.com/repos/vera-liu/caravel","forks_url":"https://api.github.com/repos/vera-liu/caravel/forks","keys_url":"https://api.github.com/repos/vera-liu/caravel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vera-liu/caravel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vera-liu/caravel/teams","hooks_url":"https://api.github.com/repos/vera-liu/caravel/hooks","issue_events_url":"https://api.github.com/repos/vera-liu/caravel/issues/events{/number}","events_url":"https://api.github.com/repos/vera-liu/caravel/events","assignees_url":"https://api.github.com/repos/vera-liu/caravel/assignees{/user}","branches_url":"https://api.github.com/repos/vera-liu/caravel/branches{/branch}","tags_url":"https://api.github.com/repos/vera-liu/caravel/tags","blobs_url":"https://api.github.com/repos/vera-liu/caravel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vera-liu/caravel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vera-liu/caravel/git/refs{/sha}","trees_url":"https://api.github.com/repos/vera-liu/caravel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vera-liu/caravel/statuses/{sha}","languages_url":"https://api.github.com/repos/vera-liu/caravel/languages","stargazers_url":"https://api.github.com/repos/vera-liu/caravel/stargazers","contributors_url":"https://api.github.com/repos/vera-liu/caravel/contributors","subscribers_url":"https://api.github.com/repos/vera-liu/caravel/subscribers","subscription_url":"https://api.github.com/repos/vera-liu/caravel/subscription","commits_url":"https://api.github.com/repos/vera-liu/caravel/commits{/sha}","git_commits_url":"https://api.github.com/repos/vera-liu/caravel/git/commits{/sha}","comments_url":"https://api.github.com/repos/vera-liu/caravel/comments{/number}","issue_comment_url":"https://api.github.com/repos/vera-liu/caravel/issues/comments{/number}","contents_url":"https://api.github.com/repos/vera-liu/caravel/contents/{+path}","compare_url":"https://api.github.com/repos/vera-liu/caravel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vera-liu/caravel/merges","archive_url":"https://api.github.com/repos/vera-liu/caravel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vera-liu/caravel/downloads","issues_url":"https://api.github.com/repos/vera-liu/caravel/issues{/number}","pulls_url":"https://api.github.com/repos/vera-liu/caravel/pulls{/number}","milestones_url":"https://api.github.com/repos/vera-liu/caravel/milestones{/number}","notifications_url":"https://api.github.com/repos/vera-liu/caravel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vera-liu/caravel/labels{/name}","releases_url":"https://api.github.com/repos/vera-liu/caravel/releases{/id}","deployments_url":"https://api.github.com/repos/vera-liu/caravel/deployments","created_at":"2016-08-11T21:10:17Z","updated_at":"2016-08-11T21:10:18Z","pushed_at":"2016-12-09T17:30:15Z","git_url":"git://github.com/vera-liu/caravel.git","ssh_url":"git@github.com:vera-liu/caravel.git","clone_url":"https://github.com/vera-liu/caravel.git","svn_url":"https://github.com/vera-liu/caravel","homepage":"","size":38748,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"airbnb:master","ref":"master","sha":"401d9afd54ce46f5c63a821094350098f07823a1","user":{"login":"airbnb","id":698437,"avatar_url":"https://avatars.githubusercontent.com/u/698437?v=3","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"repo":{"id":39464018,"name":"superset","full_name":"airbnb/superset","owner":{"login":"airbnb","id":698437,"avatar_url":"https://avatars.githubusercontent.com/u/698437?v=3","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/airbnb/superset","description":"Superset is a data exploration platform designed to be visual, intuitive, and interactive","fork":false,"url":"https://api.github.com/repos/airbnb/superset","forks_url":"https://api.github.com/repos/airbnb/superset/forks","keys_url":"https://api.github.com/repos/airbnb/superset/keys{/key_id}","collaborators_url":"https://api.github.com/repos/airbnb/superset/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/airbnb/superset/teams","hooks_url":"https://api.github.com/repos/airbnb/superset/hooks","issue_events_url":"https://api.github.com/repos/airbnb/superset/issues/events{/number}","events_url":"https://api.github.com/repos/airbnb/superset/events","assignees_url":"https://api.github.com/repos/airbnb/superset/assignees{/user}","branches_url":"https://api.github.com/repos/airbnb/superset/branches{/branch}","tags_url":"https://api.github.com/repos/airbnb/superset/tags","blobs_url":"https://api.github.com/repos/airbnb/superset/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/airbnb/superset/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/airbnb/superset/git/refs{/sha}","trees_url":"https://api.github.com/repos/airbnb/superset/git/trees{/sha}","statuses_url":"https://api.github.com/repos/airbnb/superset/statuses/{sha}","languages_url":"https://api.github.com/repos/airbnb/superset/languages","stargazers_url":"https://api.github.com/repos/airbnb/superset/stargazers","contributors_url":"https://api.github.com/repos/airbnb/superset/contributors","subscribers_url":"https://api.github.com/repos/airbnb/superset/subscribers","subscription_url":"https://api.github.com/repos/airbnb/superset/subscription","commits_url":"https://api.github.com/repos/airbnb/superset/commits{/sha}","git_commits_url":"https://api.github.com/repos/airbnb/superset/git/commits{/sha}","comments_url":"https://api.github.com/repos/airbnb/superset/comments{/number}","issue_comment_url":"https://api.github.com/repos/airbnb/superset/issues/comments{/number}","contents_url":"https://api.github.com/repos/airbnb/superset/contents/{+path}","compare_url":"https://api.github.com/repos/airbnb/superset/compare/{base}...{head}","merges_url":"https://api.github.com/repos/airbnb/superset/merges","archive_url":"https://api.github.com/repos/airbnb/superset/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/airbnb/superset/downloads","issues_url":"https://api.github.com/repos/airbnb/superset/issues{/number}","pulls_url":"https://api.github.com/repos/airbnb/superset/pulls{/number}","milestones_url":"https://api.github.com/repos/airbnb/superset/milestones{/number}","notifications_url":"https://api.github.com/repos/airbnb/superset/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/airbnb/superset/labels{/name}","releases_url":"https://api.github.com/repos/airbnb/superset/releases{/id}","deployments_url":"https://api.github.com/repos/airbnb/superset/deployments","created_at":"2015-07-21T18:55:34Z","updated_at":"2016-12-09T18:37:18Z","pushed_at":"2016-12-09T18:55:27Z","git_url":"git://github.com/airbnb/superset.git","ssh_url":"git@github.com:airbnb/superset.git","clone_url":"https://github.com/airbnb/superset.git","svn_url":"https://github.com/airbnb/superset","homepage":"","size":46879,"stargazers_count":9868,"watchers_count":9868,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1164,"mirror_url":null,"open_issues_count":375,"forks":1164,"open_issues":375,"watchers":9868,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/airbnb/superset/pulls/1790"},"html":{"href":"https://github.com/airbnb/superset/pull/1790"},"issue":{"href":"https://api.github.com/repos/airbnb/superset/issues/1790"},"comments":{"href":"https://api.github.com/repos/airbnb/superset/issues/1790/comments"},"review_comments":{"href":"https://api.github.com/repos/airbnb/superset/pulls/1790/comments"},"review_comment":{"href":"https://api.github.com/repos/airbnb/superset/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/airbnb/superset/pulls/1790/commits"},"statuses":{"href":"https://api.github.com/repos/airbnb/superset/statuses/f0b7cf7cfb15484eaaa947cc00cb581180d8046d"}}}}
{"actor":{"display_login":"bkyryliuk"}}