{"action":"created","issue":{"url":"https://api.github.com/repos/getgrav/grav/issues/906","repository_url":"https://api.github.com/repos/getgrav/grav","labels_url":"https://api.github.com/repos/getgrav/grav/issues/906/labels{/name}","comments_url":"https://api.github.com/repos/getgrav/grav/issues/906/comments","events_url":"https://api.github.com/repos/getgrav/grav/issues/906/events","html_url":"https://github.com/getgrav/grav/pull/906","id":160595704,"number":906,"title":"Respect `enable_asset_timestamp` settings for pipelined Assets","user":{"login":"Sommerregen","id":9073307,"avatar_url":"https://avatars.githubusercontent.com/u/9073307?v=3","gravatar_id":"","url":"https://api.github.com/users/Sommerregen","html_url":"https://github.com/Sommerregen","followers_url":"https://api.github.com/users/Sommerregen/followers","following_url":"https://api.github.com/users/Sommerregen/following{/other_user}","gists_url":"https://api.github.com/users/Sommerregen/gists{/gist_id}","starred_url":"https://api.github.com/users/Sommerregen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sommerregen/subscriptions","organizations_url":"https://api.github.com/users/Sommerregen/orgs","repos_url":"https://api.github.com/users/Sommerregen/repos","events_url":"https://api.github.com/users/Sommerregen/events{/privacy}","received_events_url":"https://api.github.com/users/Sommerregen/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/getgrav/grav/labels/in%20progress","name":"in progress","color":"c2e0c6"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-06-16T07:32:33Z","updated_at":"2016-06-16T17:33:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/getgrav/grav/pulls/906","html_url":"https://github.com/getgrav/grav/pull/906","diff_url":"https://github.com/getgrav/grav/pull/906.diff","patch_url":"https://github.com/getgrav/grav/pull/906.patch"},"body":"I don't know if this is intentional, but the enabled `enable_asset_timestamp` settings is not respected for pipelined assets. Even if I disable this setting the cache key is always added.\r\n\r\nI know why the cache key should be present due to browser cache invalidation of changes. However what I don't understand is then, why this setting currently only affects non-pipelined assets (see e.g. [Assets.php#L556](https://github.com/Sommerregen/grav/blob/4cec9851a1f51d78894ee2b5cab28570a3e343e8/system/src/Grav/Common/Assets.php#L556)).\r\n\r\nThis PR is for the lazy-man. Instead of opening an issue we can discuss it here or if this behavior is intentional, feel free to close it."},"comment":{"url":"https://api.github.com/repos/getgrav/grav/issues/comments/226556884","html_url":"https://github.com/getgrav/grav/pull/906#issuecomment-226556884","issue_url":"https://api.github.com/repos/getgrav/grav/issues/906","id":226556884,"user":{"login":"Sommerregen","id":9073307,"avatar_url":"https://avatars.githubusercontent.com/u/9073307?v=3","gravatar_id":"","url":"https://api.github.com/users/Sommerregen","html_url":"https://github.com/Sommerregen","followers_url":"https://api.github.com/users/Sommerregen/followers","following_url":"https://api.github.com/users/Sommerregen/following{/other_user}","gists_url":"https://api.github.com/users/Sommerregen/gists{/gist_id}","starred_url":"https://api.github.com/users/Sommerregen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sommerregen/subscriptions","organizations_url":"https://api.github.com/users/Sommerregen/orgs","repos_url":"https://api.github.com/users/Sommerregen/repos","events_url":"https://api.github.com/users/Sommerregen/events{/privacy}","received_events_url":"https://api.github.com/users/Sommerregen/received_events","type":"User","site_admin":false},"created_at":"2016-06-16T17:33:27Z","updated_at":"2016-06-16T17:33:27Z","body":"@flaviocopes That's a good point! I'll wait for @rhukster maybe he can shed some more light on it. Concerning the `enable_asset_timestamp: false` case, it runs as follows: `$this->timestamp` is `''` as this is the default (L80) in (L180) it gets set to the Grav cache key."}}
{"actor":{"display_login":"Sommerregen"}}