{"action":"created","issue":{"url":"https://api.github.com/repos/xonsh/xonsh/issues/1211","repository_url":"https://api.github.com/repos/xonsh/xonsh","labels_url":"https://api.github.com/repos/xonsh/xonsh/issues/1211/labels{/name}","comments_url":"https://api.github.com/repos/xonsh/xonsh/issues/1211/comments","events_url":"https://api.github.com/repos/xonsh/xonsh/issues/1211/events","html_url":"https://github.com/xonsh/xonsh/pull/1211","id":159802415,"number":1211,"title":"History all","user":{"login":"JohnLunzer","id":8135795,"avatar_url":"https://avatars.githubusercontent.com/u/8135795?v=3","gravatar_id":"","url":"https://api.github.com/users/JohnLunzer","html_url":"https://github.com/JohnLunzer","followers_url":"https://api.github.com/users/JohnLunzer/followers","following_url":"https://api.github.com/users/JohnLunzer/following{/other_user}","gists_url":"https://api.github.com/users/JohnLunzer/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnLunzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnLunzer/subscriptions","organizations_url":"https://api.github.com/users/JohnLunzer/orgs","repos_url":"https://api.github.com/users/JohnLunzer/repos","events_url":"https://api.github.com/users/JohnLunzer/events{/privacy}","received_events_url":"https://api.github.com/users/JohnLunzer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-06-12T01:43:40Z","updated_at":"2016-06-13T15:01:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xonsh/xonsh/pulls/1211","html_url":"https://github.com/xonsh/xonsh/pull/1211","diff_url":"https://github.com/xonsh/xonsh/pull/1211.diff","patch_url":"https://github.com/xonsh/xonsh/pull/1211.patch"},"body":"This PR should fully address #572. Some pretty good stuff here!\r\n\r\nThere are a couple of changes which I'd like to address as they may be seen as controversial. I've removed `history show`. This was redundant as the simpler `history` did the exact same thing. I highly doubt anyone was using `history show` in scripts and so this should not be seen as a breaking change. Though the documentation will need to be updated. \r\n\r\nThe documentation will also need to take into account the new functionality for `__xonsh_history__.show()`, which probably needs its docstring to be a little more descriptive as well. \r\n\r\nFrankly there are probably a couple of commits left to make but I wanted to get this out into the wild for people to test so I could get some feedback."},"comment":{"url":"https://api.github.com/repos/xonsh/xonsh/issues/comments/225608018","html_url":"https://github.com/xonsh/xonsh/pull/1211#issuecomment-225608018","issue_url":"https://api.github.com/repos/xonsh/xonsh/issues/1211","id":225608018,"user":{"login":"gforsyth","id":3596999,"avatar_url":"https://avatars.githubusercontent.com/u/3596999?v=3","gravatar_id":"","url":"https://api.github.com/users/gforsyth","html_url":"https://github.com/gforsyth","followers_url":"https://api.github.com/users/gforsyth/followers","following_url":"https://api.github.com/users/gforsyth/following{/other_user}","gists_url":"https://api.github.com/users/gforsyth/gists{/gist_id}","starred_url":"https://api.github.com/users/gforsyth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gforsyth/subscriptions","organizations_url":"https://api.github.com/users/gforsyth/orgs","repos_url":"https://api.github.com/users/gforsyth/repos","events_url":"https://api.github.com/users/gforsyth/events{/privacy}","received_events_url":"https://api.github.com/users/gforsyth/received_events","type":"User","site_admin":false},"created_at":"2016-06-13T15:01:52Z","updated_at":"2016-06-13T15:01:52Z","body":"Since the `JSONDecodeError` is just there to catch bad files, I think you can replace it with a `ValueError` and it will work the same."}}
{"actor":{"display_login":"gforsyth"}}