{"action":"closed","number":5,"pull_request":{"url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/pulls/5","id":72132000,"html_url":"https://github.com/LindseyRoseC/Linked-Lists-Project/pull/5","diff_url":"https://github.com/LindseyRoseC/Linked-Lists-Project/pull/5.diff","patch_url":"https://github.com/LindseyRoseC/Linked-Lists-Project/pull/5.patch","issue_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/issues/5","number":5,"state":"closed","locked":false,"title":"Update CyclicLinkedList.h","user":{"login":"LindseyRoseC","id":19634534,"avatar_url":"https://avatars.githubusercontent.com/u/19634534?v=3","gravatar_id":"","url":"https://api.github.com/users/LindseyRoseC","html_url":"https://github.com/LindseyRoseC","followers_url":"https://api.github.com/users/LindseyRoseC/followers","following_url":"https://api.github.com/users/LindseyRoseC/following{/other_user}","gists_url":"https://api.github.com/users/LindseyRoseC/gists{/gist_id}","starred_url":"https://api.github.com/users/LindseyRoseC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LindseyRoseC/subscriptions","organizations_url":"https://api.github.com/users/LindseyRoseC/orgs","repos_url":"https://api.github.com/users/LindseyRoseC/repos","events_url":"https://api.github.com/users/LindseyRoseC/events{/privacy}","received_events_url":"https://api.github.com/users/LindseyRoseC/received_events","type":"User","site_admin":false},"body":"Hey good work so far! I always have trouble starting assignments so the fact that you went ahead and got this far was super helpful for me.\r\n\r\nChanges:\r\nSimplified your push_front and push_back functions. I couldn't figure out why you were using a while loop and creating 2 pointers instead of 1, both things seemed unnecessary.\r\n\r\nIn your functions you were never setting tail->next = head. So it wasn't cyclic, tail->next was always equal to 0. Once I changed this so that tail->next = head it ruined your print and count functions. They were set to go until ptr/temp = 0 but it never does in a cyclic linked list so they went on forever. So you can see how I changed them to fix this problem.\r\n\r\nI also created a Menu.cpp which will be our main menu program that we use to show off our project to the TA/class. Too tired to catch this up to what we have completed so far, but don't worry about working on this, this will be my next project.\r\n\r\nnote: aside from our 3 functions we have left to complete for the singly linked list, we still need to finish our destructor. According to the project guidelines it is supposed to delete every node in the list but ours only deletes the head and tail pointers.","created_at":"2016-06-01T07:05:06Z","updated_at":"2016-06-01T14:37:04Z","closed_at":"2016-06-01T14:37:04Z","merged_at":"2016-06-01T14:37:04Z","merge_commit_sha":"9a6a60f01bebfb886030217ea46556534d9424ac","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/pulls/5/commits","review_comments_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/pulls/5/comments","review_comment_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/issues/5/comments","statuses_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/statuses/293cb16217c16c151a2a9a645af914c4c360359d","head":{"label":"LindseyRoseC:LindseyRoseC-patch---major-simplification/fixes","ref":"LindseyRoseC-patch---major-simplification/fixes","sha":"293cb16217c16c151a2a9a645af914c4c360359d","user":{"login":"LindseyRoseC","id":19634534,"avatar_url":"https://avatars.githubusercontent.com/u/19634534?v=3","gravatar_id":"","url":"https://api.github.com/users/LindseyRoseC","html_url":"https://github.com/LindseyRoseC","followers_url":"https://api.github.com/users/LindseyRoseC/followers","following_url":"https://api.github.com/users/LindseyRoseC/following{/other_user}","gists_url":"https://api.github.com/users/LindseyRoseC/gists{/gist_id}","starred_url":"https://api.github.com/users/LindseyRoseC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LindseyRoseC/subscriptions","organizations_url":"https://api.github.com/users/LindseyRoseC/orgs","repos_url":"https://api.github.com/users/LindseyRoseC/repos","events_url":"https://api.github.com/users/LindseyRoseC/events{/privacy}","received_events_url":"https://api.github.com/users/LindseyRoseC/received_events","type":"User","site_admin":false},"repo":{"id":59944124,"name":"Linked-Lists-Project","full_name":"LindseyRoseC/Linked-Lists-Project","owner":{"login":"LindseyRoseC","id":19634534,"avatar_url":"https://avatars.githubusercontent.com/u/19634534?v=3","gravatar_id":"","url":"https://api.github.com/users/LindseyRoseC","html_url":"https://github.com/LindseyRoseC","followers_url":"https://api.github.com/users/LindseyRoseC/followers","following_url":"https://api.github.com/users/LindseyRoseC/following{/other_user}","gists_url":"https://api.github.com/users/LindseyRoseC/gists{/gist_id}","starred_url":"https://api.github.com/users/LindseyRoseC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LindseyRoseC/subscriptions","organizations_url":"https://api.github.com/users/LindseyRoseC/orgs","repos_url":"https://api.github.com/users/LindseyRoseC/repos","events_url":"https://api.github.com/users/LindseyRoseC/events{/privacy}","received_events_url":"https://api.github.com/users/LindseyRoseC/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LindseyRoseC/Linked-Lists-Project","description":"Due June 5th!","fork":false,"url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project","forks_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/forks","keys_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/teams","hooks_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/hooks","issue_events_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/issues/events{/number}","events_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/events","assignees_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/assignees{/user}","branches_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/branches{/branch}","tags_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/tags","blobs_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/git/refs{/sha}","trees_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/statuses/{sha}","languages_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/languages","stargazers_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/stargazers","contributors_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/contributors","subscribers_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/subscribers","subscription_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/subscription","commits_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/commits{/sha}","git_commits_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/git/commits{/sha}","comments_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/comments{/number}","issue_comment_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/issues/comments{/number}","contents_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/contents/{+path}","compare_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/merges","archive_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/downloads","issues_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/issues{/number}","pulls_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/pulls{/number}","milestones_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/milestones{/number}","notifications_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/labels{/name}","releases_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/releases{/id}","deployments_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/deployments","created_at":"2016-05-29T13:22:29Z","updated_at":"2016-05-29T19:08:56Z","pushed_at":"2016-06-01T14:37:04Z","git_url":"git://github.com/LindseyRoseC/Linked-Lists-Project.git","ssh_url":"git@github.com:LindseyRoseC/Linked-Lists-Project.git","clone_url":"https://github.com/LindseyRoseC/Linked-Lists-Project.git","svn_url":"https://github.com/LindseyRoseC/Linked-Lists-Project","homepage":"","size":14,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"LindseyRoseC:master","ref":"master","sha":"00b5a15a506c3057748c64e5293aa696df0734cf","user":{"login":"LindseyRoseC","id":19634534,"avatar_url":"https://avatars.githubusercontent.com/u/19634534?v=3","gravatar_id":"","url":"https://api.github.com/users/LindseyRoseC","html_url":"https://github.com/LindseyRoseC","followers_url":"https://api.github.com/users/LindseyRoseC/followers","following_url":"https://api.github.com/users/LindseyRoseC/following{/other_user}","gists_url":"https://api.github.com/users/LindseyRoseC/gists{/gist_id}","starred_url":"https://api.github.com/users/LindseyRoseC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LindseyRoseC/subscriptions","organizations_url":"https://api.github.com/users/LindseyRoseC/orgs","repos_url":"https://api.github.com/users/LindseyRoseC/repos","events_url":"https://api.github.com/users/LindseyRoseC/events{/privacy}","received_events_url":"https://api.github.com/users/LindseyRoseC/received_events","type":"User","site_admin":false},"repo":{"id":59944124,"name":"Linked-Lists-Project","full_name":"LindseyRoseC/Linked-Lists-Project","owner":{"login":"LindseyRoseC","id":19634534,"avatar_url":"https://avatars.githubusercontent.com/u/19634534?v=3","gravatar_id":"","url":"https://api.github.com/users/LindseyRoseC","html_url":"https://github.com/LindseyRoseC","followers_url":"https://api.github.com/users/LindseyRoseC/followers","following_url":"https://api.github.com/users/LindseyRoseC/following{/other_user}","gists_url":"https://api.github.com/users/LindseyRoseC/gists{/gist_id}","starred_url":"https://api.github.com/users/LindseyRoseC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LindseyRoseC/subscriptions","organizations_url":"https://api.github.com/users/LindseyRoseC/orgs","repos_url":"https://api.github.com/users/LindseyRoseC/repos","events_url":"https://api.github.com/users/LindseyRoseC/events{/privacy}","received_events_url":"https://api.github.com/users/LindseyRoseC/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LindseyRoseC/Linked-Lists-Project","description":"Due June 5th!","fork":false,"url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project","forks_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/forks","keys_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/teams","hooks_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/hooks","issue_events_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/issues/events{/number}","events_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/events","assignees_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/assignees{/user}","branches_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/branches{/branch}","tags_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/tags","blobs_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/git/refs{/sha}","trees_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/statuses/{sha}","languages_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/languages","stargazers_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/stargazers","contributors_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/contributors","subscribers_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/subscribers","subscription_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/subscription","commits_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/commits{/sha}","git_commits_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/git/commits{/sha}","comments_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/comments{/number}","issue_comment_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/issues/comments{/number}","contents_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/contents/{+path}","compare_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/merges","archive_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/downloads","issues_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/issues{/number}","pulls_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/pulls{/number}","milestones_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/milestones{/number}","notifications_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/labels{/name}","releases_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/releases{/id}","deployments_url":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/deployments","created_at":"2016-05-29T13:22:29Z","updated_at":"2016-05-29T19:08:56Z","pushed_at":"2016-06-01T14:37:04Z","git_url":"git://github.com/LindseyRoseC/Linked-Lists-Project.git","ssh_url":"git@github.com:LindseyRoseC/Linked-Lists-Project.git","clone_url":"https://github.com/LindseyRoseC/Linked-Lists-Project.git","svn_url":"https://github.com/LindseyRoseC/Linked-Lists-Project","homepage":"","size":14,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/pulls/5"},"html":{"href":"https://github.com/LindseyRoseC/Linked-Lists-Project/pull/5"},"issue":{"href":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/issues/5"},"comments":{"href":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/LindseyRoseC/Linked-Lists-Project/statuses/293cb16217c16c151a2a9a645af914c4c360359d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Latesia18","id":19637497,"avatar_url":"https://avatars.githubusercontent.com/u/19637497?v=3","gravatar_id":"","url":"https://api.github.com/users/Latesia18","html_url":"https://github.com/Latesia18","followers_url":"https://api.github.com/users/Latesia18/followers","following_url":"https://api.github.com/users/Latesia18/following{/other_user}","gists_url":"https://api.github.com/users/Latesia18/gists{/gist_id}","starred_url":"https://api.github.com/users/Latesia18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Latesia18/subscriptions","organizations_url":"https://api.github.com/users/Latesia18/orgs","repos_url":"https://api.github.com/users/Latesia18/repos","events_url":"https://api.github.com/users/Latesia18/events{/privacy}","received_events_url":"https://api.github.com/users/Latesia18/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":49,"deletions":35,"changed_files":1}}
{"actor":{"display_login":"Latesia18"}}