{"action":"created","issue":{"url":"https://api.github.com/repos/apple/swift/issues/5481","repository_url":"https://api.github.com/repos/apple/swift","labels_url":"https://api.github.com/repos/apple/swift/issues/5481/labels{/name}","comments_url":"https://api.github.com/repos/apple/swift/issues/5481/comments","events_url":"https://api.github.com/repos/apple/swift/issues/5481/events","html_url":"https://github.com/apple/swift/pull/5481","id":185474188,"number":5481,"title":"Push the debug info for the artificial error inout argument up to SIL.","user":{"login":"adrian-prantl","id":2251653,"avatar_url":"https://avatars.githubusercontent.com/u/2251653?v=3","gravatar_id":"","url":"https://api.github.com/users/adrian-prantl","html_url":"https://github.com/adrian-prantl","followers_url":"https://api.github.com/users/adrian-prantl/followers","following_url":"https://api.github.com/users/adrian-prantl/following{/other_user}","gists_url":"https://api.github.com/users/adrian-prantl/gists{/gist_id}","starred_url":"https://api.github.com/users/adrian-prantl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrian-prantl/subscriptions","organizations_url":"https://api.github.com/users/adrian-prantl/orgs","repos_url":"https://api.github.com/users/adrian-prantl/repos","events_url":"https://api.github.com/users/adrian-prantl/events{/privacy}","received_events_url":"https://api.github.com/users/adrian-prantl/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-10-26T18:33:40Z","updated_at":"2016-10-27T15:32:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/5481","html_url":"https://github.com/apple/swift/pull/5481","diff_url":"https://github.com/apple/swift/pull/5481.diff","patch_url":"https://github.com/apple/swift/pull/5481.patch"},"body":"<!-- What's in this pull request? -->\r\n\r\n\r\n<!--\r\nBefore merging this pull request, you must run the Swift continuous integration tests.\r\nFor information about triggering CI builds via @swift-ci, see:\r\nhttps://github.com/apple/swift/blob/master/docs/ContinuousIntegration.md#swift-ci\r\n\r\nThank you for your contribution to Swift!\r\n-->\r\n\r\nPreviously IRGen was using a heuristic to assign the argument number\r\nto the $error variable that was not generally correct for optimizaed\r\ncode. This patch inserts a debug_value instruction in SILGen and thus\r\nassigns the ArgNo together with all the other function arguments. This\r\nis more robust and faster than than the old heuristic.\r\n\r\n<rdar://problem/28748323>"},"comment":{"url":"https://api.github.com/repos/apple/swift/issues/comments/256676537","html_url":"https://github.com/apple/swift/pull/5481#issuecomment-256676537","issue_url":"https://api.github.com/repos/apple/swift/issues/5481","id":256676537,"user":{"login":"adrian-prantl","id":2251653,"avatar_url":"https://avatars.githubusercontent.com/u/2251653?v=3","gravatar_id":"","url":"https://api.github.com/users/adrian-prantl","html_url":"https://github.com/adrian-prantl","followers_url":"https://api.github.com/users/adrian-prantl/followers","following_url":"https://api.github.com/users/adrian-prantl/following{/other_user}","gists_url":"https://api.github.com/users/adrian-prantl/gists{/gist_id}","starred_url":"https://api.github.com/users/adrian-prantl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrian-prantl/subscriptions","organizations_url":"https://api.github.com/users/adrian-prantl/orgs","repos_url":"https://api.github.com/users/adrian-prantl/repos","events_url":"https://api.github.com/users/adrian-prantl/events{/privacy}","received_events_url":"https://api.github.com/users/adrian-prantl/received_events","type":"User","site_admin":false},"created_at":"2016-10-27T15:32:07Z","updated_at":"2016-10-27T15:32:07Z","body":"@swift-ci please test OS X platform"}}
{"actor":{"display_login":"adrian-prantl"}}