{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/core/issues/24691","repository_url":"https://api.github.com/repos/owncloud/core","labels_url":"https://api.github.com/repos/owncloud/core/issues/24691/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/core/issues/24691/comments","events_url":"https://api.github.com/repos/owncloud/core/issues/24691/events","html_url":"https://github.com/owncloud/core/pull/24691","id":155480402,"number":24691,"title":"Allow chunk GC mtime tolerance for unfinished part chunks","user":{"login":"PVince81","id":277525,"avatar_url":"https://avatars.githubusercontent.com/u/277525?v=3","gravatar_id":"","url":"https://api.github.com/users/PVince81","html_url":"https://github.com/PVince81","followers_url":"https://api.github.com/users/PVince81/followers","following_url":"https://api.github.com/users/PVince81/following{/other_user}","gists_url":"https://api.github.com/users/PVince81/gists{/gist_id}","starred_url":"https://api.github.com/users/PVince81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PVince81/subscriptions","organizations_url":"https://api.github.com/users/PVince81/orgs","repos_url":"https://api.github.com/users/PVince81/repos","events_url":"https://api.github.com/users/PVince81/events{/privacy}","received_events_url":"https://api.github.com/users/PVince81/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/owncloud/core/labels/3%20-%20To%20Review","name":"3 - To Review","color":"ededed"},{"url":"https://api.github.com/repos/owncloud/core/labels/comp:filesystem","name":"comp:filesystem","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/62","html_url":"https://github.com/owncloud/core/milestones/9.1-current","labels_url":"https://api.github.com/repos/owncloud/core/milestones/62/labels","id":1322460,"number":62,"title":"9.1-current","description":"","creator":{"login":"MorrisJobke","id":245432,"avatar_url":"https://avatars.githubusercontent.com/u/245432?v=3","gravatar_id":"","url":"https://api.github.com/users/MorrisJobke","html_url":"https://github.com/MorrisJobke","followers_url":"https://api.github.com/users/MorrisJobke/followers","following_url":"https://api.github.com/users/MorrisJobke/following{/other_user}","gists_url":"https://api.github.com/users/MorrisJobke/gists{/gist_id}","starred_url":"https://api.github.com/users/MorrisJobke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MorrisJobke/subscriptions","organizations_url":"https://api.github.com/users/MorrisJobke/orgs","repos_url":"https://api.github.com/users/MorrisJobke/repos","events_url":"https://api.github.com/users/MorrisJobke/events{/privacy}","received_events_url":"https://api.github.com/users/MorrisJobke/received_events","type":"User","site_admin":false},"open_issues":734,"closed_issues":783,"state":"open","created_at":"2015-09-24T16:30:14Z","updated_at":"2016-05-18T12:33:27Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2016-05-18T11:41:19Z","updated_at":"2016-05-18T12:39:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/24691","html_url":"https://github.com/owncloud/core/pull/24691","diff_url":"https://github.com/owncloud/core/pull/24691.diff","patch_url":"https://github.com/owncloud/core/pull/24691.patch"},"body":"Whenever part chunks are written, every fwrite in the write loop will\r\nreset the mtime to the current mtime. Only at the end will the touch()\r\noperation set the mtime to now + ttl, in the future.\r\n\r\nHowever the GC code is expecting that every chunk with mtime < now are\r\nold and must be deleted. This causes the GC to sometimes delete part\r\nchunks in which the write loop is slow.\r\n\r\nTo fix this, a tolerance value is added in the GC code to allow for\r\nmore time before a part chunk gets deleted.\r\n\r\nFixes https://github.com/owncloud/core/issues/24653\r\nSteps here: https://github.com/owncloud/core/issues/24653#issuecomment-219735296\r\n\r\nPlease review @icewind1991 @Marginal @MorrisJobke @nickvergessen @schiesbn @rullzer "},"comment":{"url":"https://api.github.com/repos/owncloud/core/issues/comments/220013580","html_url":"https://github.com/owncloud/core/pull/24691#issuecomment-220013580","issue_url":"https://api.github.com/repos/owncloud/core/issues/24691","id":220013580,"user":{"login":"icewind1991","id":1283854,"avatar_url":"https://avatars.githubusercontent.com/u/1283854?v=3","gravatar_id":"","url":"https://api.github.com/users/icewind1991","html_url":"https://github.com/icewind1991","followers_url":"https://api.github.com/users/icewind1991/followers","following_url":"https://api.github.com/users/icewind1991/following{/other_user}","gists_url":"https://api.github.com/users/icewind1991/gists{/gist_id}","starred_url":"https://api.github.com/users/icewind1991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icewind1991/subscriptions","organizations_url":"https://api.github.com/users/icewind1991/orgs","repos_url":"https://api.github.com/users/icewind1991/repos","events_url":"https://api.github.com/users/icewind1991/events{/privacy}","received_events_url":"https://api.github.com/users/icewind1991/received_events","type":"User","site_admin":false},"created_at":"2016-05-18T12:39:55Z","updated_at":"2016-05-18T12:39:55Z","body":":+1: looks good"}}