{"action":"created","comment":{"url":"https://api.github.com/repos/labrad/scalabrad-web/pulls/comments/73625795","id":73625795,"diff_hunk":"@@ -180,9 +190,40 @@\n     td.controls {\n       width: 350px;\n     }\n+    #buttons {\n+      height: 50px;\n+    }\n+    #buttons paper-icon-button {\n+      margin: 5px;\n+    }\n+    .autostartFilterOn {\n+      color: #000;\n+    }\n+    .autostartFilterOff {\n+      color: #aaa;\n+    }\n   </style>\n   <template>\n-    <div>\n+   <div id=\"container\" class='fit'>\n+   <paper-header-panel id=\"left-column\">\n+    <div class=\"paper-header\" id=\"buttons\">\n+      <paper-icon-button\n+        hidden$={{isAutostartFiltered}}\n+        class='autostartFilterOff'","path":"client-js/app/elements/labrad-nodes.html","position":41,"original_position":41,"commit_id":"5f555c7897930622720f7772f99f101ebe76a563","original_commit_id":"5f555c7897930622720f7772f99f101ebe76a563","user":{"login":"adamcw","id":153444,"avatar_url":"https://avatars.githubusercontent.com/u/153444?v=3","gravatar_id":"","url":"https://api.github.com/users/adamcw","html_url":"https://github.com/adamcw","followers_url":"https://api.github.com/users/adamcw/followers","following_url":"https://api.github.com/users/adamcw/following{/other_user}","gists_url":"https://api.github.com/users/adamcw/gists{/gist_id}","starred_url":"https://api.github.com/users/adamcw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamcw/subscriptions","organizations_url":"https://api.github.com/users/adamcw/orgs","repos_url":"https://api.github.com/users/adamcw/repos","events_url":"https://api.github.com/users/adamcw/events{/privacy}","received_events_url":"https://api.github.com/users/adamcw/received_events","type":"User","site_admin":false},"body":"Yeah, my brain struggles with the swapping between TypeScript (single) and HTML (double). I was actually thinking to mention we may want to standardise HTML to single quotes to make it more consistent. I do believe the style guide allows either as long as it's consistent.","created_at":"2016-08-05T00:27:53Z","updated_at":"2016-08-05T00:27:53Z","html_url":"https://github.com/labrad/scalabrad-web/pull/257#discussion_r73625795","pull_request_url":"https://api.github.com/repos/labrad/scalabrad-web/pulls/257","_links":{"self":{"href":"https://api.github.com/repos/labrad/scalabrad-web/pulls/comments/73625795"},"html":{"href":"https://github.com/labrad/scalabrad-web/pull/257#discussion_r73625795"},"pull_request":{"href":"https://api.github.com/repos/labrad/scalabrad-web/pulls/257"}}},"pull_request":{"url":"https://api.github.com/repos/labrad/scalabrad-web/pulls/257","id":80167768,"html_url":"https://github.com/labrad/scalabrad-web/pull/257","diff_url":"https://github.com/labrad/scalabrad-web/pull/257.diff","patch_url":"https://github.com/labrad/scalabrad-web/pull/257.patch","issue_url":"https://api.github.com/repos/labrad/scalabrad-web/issues/257","number":257,"state":"open","locked":false,"title":"[#143, Part 2] Added filtering of servers in Node view based on autostart status.","user":{"login":"adamcw","id":153444,"avatar_url":"https://avatars.githubusercontent.com/u/153444?v=3","gravatar_id":"","url":"https://api.github.com/users/adamcw","html_url":"https://github.com/adamcw","followers_url":"https://api.github.com/users/adamcw/followers","following_url":"https://api.github.com/users/adamcw/following{/other_user}","gists_url":"https://api.github.com/users/adamcw/gists{/gist_id}","starred_url":"https://api.github.com/users/adamcw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamcw/subscriptions","organizations_url":"https://api.github.com/users/adamcw/orgs","repos_url":"https://api.github.com/users/adamcw/repos","events_url":"https://api.github.com/users/adamcw/events{/privacy}","received_events_url":"https://api.github.com/users/adamcw/received_events","type":"User","site_admin":false},"body":"Partial fix for #143. Added controls for filtering the list of servers based on if they appear in an autostart list or not. \r\n\r\nThis required refactoring the code to no longer use computed properties. Specifically, with the original way, when filtering the list, all state information of the servers would be lost as the list would just get recreated from scratch. The new code isn't substantially more complicated than the existing, despite having to properly keep the list state current.\r\n\r\nThis also fixes an unreported bug where the control states were incorrect on page load due to the server controls not communicating their state to one another.","created_at":"2016-08-04T23:43:07Z","updated_at":"2016-08-05T00:27:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a58490cd7d152c74456240333aba3b57e11ce02","assignee":{"login":"maffoo","id":129268,"avatar_url":"https://avatars.githubusercontent.com/u/129268?v=3","gravatar_id":"","url":"https://api.github.com/users/maffoo","html_url":"https://github.com/maffoo","followers_url":"https://api.github.com/users/maffoo/followers","following_url":"https://api.github.com/users/maffoo/following{/other_user}","gists_url":"https://api.github.com/users/maffoo/gists{/gist_id}","starred_url":"https://api.github.com/users/maffoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maffoo/subscriptions","organizations_url":"https://api.github.com/users/maffoo/orgs","repos_url":"https://api.github.com/users/maffoo/repos","events_url":"https://api.github.com/users/maffoo/events{/privacy}","received_events_url":"https://api.github.com/users/maffoo/received_events","type":"User","site_admin":false},"assignees":[{"login":"maffoo","id":129268,"avatar_url":"https://avatars.githubusercontent.com/u/129268?v=3","gravatar_id":"","url":"https://api.github.com/users/maffoo","html_url":"https://github.com/maffoo","followers_url":"https://api.github.com/users/maffoo/followers","following_url":"https://api.github.com/users/maffoo/following{/other_user}","gists_url":"https://api.github.com/users/maffoo/gists{/gist_id}","starred_url":"https://api.github.com/users/maffoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maffoo/subscriptions","organizations_url":"https://api.github.com/users/maffoo/orgs","repos_url":"https://api.github.com/users/maffoo/repos","events_url":"https://api.github.com/users/maffoo/events{/privacy}","received_events_url":"https://api.github.com/users/maffoo/received_events","type":"User","site_admin":false},{"login":"joshmutus","id":8173925,"avatar_url":"https://avatars.githubusercontent.com/u/8173925?v=3","gravatar_id":"","url":"https://api.github.com/users/joshmutus","html_url":"https://github.com/joshmutus","followers_url":"https://api.github.com/users/joshmutus/followers","following_url":"https://api.github.com/users/joshmutus/following{/other_user}","gists_url":"https://api.github.com/users/joshmutus/gists{/gist_id}","starred_url":"https://api.github.com/users/joshmutus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshmutus/subscriptions","organizations_url":"https://api.github.com/users/joshmutus/orgs","repos_url":"https://api.github.com/users/joshmutus/repos","events_url":"https://api.github.com/users/joshmutus/events{/privacy}","received_events_url":"https://api.github.com/users/joshmutus/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/labrad/scalabrad-web/pulls/257/commits","review_comments_url":"https://api.github.com/repos/labrad/scalabrad-web/pulls/257/comments","review_comment_url":"https://api.github.com/repos/labrad/scalabrad-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/labrad/scalabrad-web/issues/257/comments","statuses_url":"https://api.github.com/repos/labrad/scalabrad-web/statuses/5f555c7897930622720f7772f99f101ebe76a563","head":{"label":"labrad:143-server-subset-node-manager-2","ref":"143-server-subset-node-manager-2","sha":"5f555c7897930622720f7772f99f101ebe76a563","user":{"login":"labrad","id":7157139,"avatar_url":"https://avatars.githubusercontent.com/u/7157139?v=3","gravatar_id":"","url":"https://api.github.com/users/labrad","html_url":"https://github.com/labrad","followers_url":"https://api.github.com/users/labrad/followers","following_url":"https://api.github.com/users/labrad/following{/other_user}","gists_url":"https://api.github.com/users/labrad/gists{/gist_id}","starred_url":"https://api.github.com/users/labrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labrad/subscriptions","organizations_url":"https://api.github.com/users/labrad/orgs","repos_url":"https://api.github.com/users/labrad/repos","events_url":"https://api.github.com/users/labrad/events{/privacy}","received_events_url":"https://api.github.com/users/labrad/received_events","type":"Organization","site_admin":false},"repo":{"id":32440005,"name":"scalabrad-web","full_name":"labrad/scalabrad-web","owner":{"login":"labrad","id":7157139,"avatar_url":"https://avatars.githubusercontent.com/u/7157139?v=3","gravatar_id":"","url":"https://api.github.com/users/labrad","html_url":"https://github.com/labrad","followers_url":"https://api.github.com/users/labrad/followers","following_url":"https://api.github.com/users/labrad/following{/other_user}","gists_url":"https://api.github.com/users/labrad/gists{/gist_id}","starred_url":"https://api.github.com/users/labrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labrad/subscriptions","organizations_url":"https://api.github.com/users/labrad/orgs","repos_url":"https://api.github.com/users/labrad/repos","events_url":"https://api.github.com/users/labrad/events{/privacy}","received_events_url":"https://api.github.com/users/labrad/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/labrad/scalabrad-web","description":"A web interface for labrad","fork":false,"url":"https://api.github.com/repos/labrad/scalabrad-web","forks_url":"https://api.github.com/repos/labrad/scalabrad-web/forks","keys_url":"https://api.github.com/repos/labrad/scalabrad-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/labrad/scalabrad-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/labrad/scalabrad-web/teams","hooks_url":"https://api.github.com/repos/labrad/scalabrad-web/hooks","issue_events_url":"https://api.github.com/repos/labrad/scalabrad-web/issues/events{/number}","events_url":"https://api.github.com/repos/labrad/scalabrad-web/events","assignees_url":"https://api.github.com/repos/labrad/scalabrad-web/assignees{/user}","branches_url":"https://api.github.com/repos/labrad/scalabrad-web/branches{/branch}","tags_url":"https://api.github.com/repos/labrad/scalabrad-web/tags","blobs_url":"https://api.github.com/repos/labrad/scalabrad-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/labrad/scalabrad-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/labrad/scalabrad-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/labrad/scalabrad-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/labrad/scalabrad-web/statuses/{sha}","languages_url":"https://api.github.com/repos/labrad/scalabrad-web/languages","stargazers_url":"https://api.github.com/repos/labrad/scalabrad-web/stargazers","contributors_url":"https://api.github.com/repos/labrad/scalabrad-web/contributors","subscribers_url":"https://api.github.com/repos/labrad/scalabrad-web/subscribers","subscription_url":"https://api.github.com/repos/labrad/scalabrad-web/subscription","commits_url":"https://api.github.com/repos/labrad/scalabrad-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/labrad/scalabrad-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/labrad/scalabrad-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/labrad/scalabrad-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/labrad/scalabrad-web/contents/{+path}","compare_url":"https://api.github.com/repos/labrad/scalabrad-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/labrad/scalabrad-web/merges","archive_url":"https://api.github.com/repos/labrad/scalabrad-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/labrad/scalabrad-web/downloads","issues_url":"https://api.github.com/repos/labrad/scalabrad-web/issues{/number}","pulls_url":"https://api.github.com/repos/labrad/scalabrad-web/pulls{/number}","milestones_url":"https://api.github.com/repos/labrad/scalabrad-web/milestones{/number}","notifications_url":"https://api.github.com/repos/labrad/scalabrad-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/labrad/scalabrad-web/labels{/name}","releases_url":"https://api.github.com/repos/labrad/scalabrad-web/releases{/id}","deployments_url":"https://api.github.com/repos/labrad/scalabrad-web/deployments","created_at":"2015-03-18T05:34:53Z","updated_at":"2016-08-01T21:37:48Z","pushed_at":"2016-08-04T23:59:13Z","git_url":"git://github.com/labrad/scalabrad-web.git","ssh_url":"git@github.com:labrad/scalabrad-web.git","clone_url":"https://github.com/labrad/scalabrad-web.git","svn_url":"https://github.com/labrad/scalabrad-web","homepage":"","size":944,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":31,"forks":1,"open_issues":31,"watchers":3,"default_branch":"master"}},"base":{"label":"labrad:143-server-subset-node-manager-1","ref":"143-server-subset-node-manager-1","sha":"f06f91f62e5fb5455f6c43dd4862d1c17df01c96","user":{"login":"labrad","id":7157139,"avatar_url":"https://avatars.githubusercontent.com/u/7157139?v=3","gravatar_id":"","url":"https://api.github.com/users/labrad","html_url":"https://github.com/labrad","followers_url":"https://api.github.com/users/labrad/followers","following_url":"https://api.github.com/users/labrad/following{/other_user}","gists_url":"https://api.github.com/users/labrad/gists{/gist_id}","starred_url":"https://api.github.com/users/labrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labrad/subscriptions","organizations_url":"https://api.github.com/users/labrad/orgs","repos_url":"https://api.github.com/users/labrad/repos","events_url":"https://api.github.com/users/labrad/events{/privacy}","received_events_url":"https://api.github.com/users/labrad/received_events","type":"Organization","site_admin":false},"repo":{"id":32440005,"name":"scalabrad-web","full_name":"labrad/scalabrad-web","owner":{"login":"labrad","id":7157139,"avatar_url":"https://avatars.githubusercontent.com/u/7157139?v=3","gravatar_id":"","url":"https://api.github.com/users/labrad","html_url":"https://github.com/labrad","followers_url":"https://api.github.com/users/labrad/followers","following_url":"https://api.github.com/users/labrad/following{/other_user}","gists_url":"https://api.github.com/users/labrad/gists{/gist_id}","starred_url":"https://api.github.com/users/labrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labrad/subscriptions","organizations_url":"https://api.github.com/users/labrad/orgs","repos_url":"https://api.github.com/users/labrad/repos","events_url":"https://api.github.com/users/labrad/events{/privacy}","received_events_url":"https://api.github.com/users/labrad/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/labrad/scalabrad-web","description":"A web interface for labrad","fork":false,"url":"https://api.github.com/repos/labrad/scalabrad-web","forks_url":"https://api.github.com/repos/labrad/scalabrad-web/forks","keys_url":"https://api.github.com/repos/labrad/scalabrad-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/labrad/scalabrad-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/labrad/scalabrad-web/teams","hooks_url":"https://api.github.com/repos/labrad/scalabrad-web/hooks","issue_events_url":"https://api.github.com/repos/labrad/scalabrad-web/issues/events{/number}","events_url":"https://api.github.com/repos/labrad/scalabrad-web/events","assignees_url":"https://api.github.com/repos/labrad/scalabrad-web/assignees{/user}","branches_url":"https://api.github.com/repos/labrad/scalabrad-web/branches{/branch}","tags_url":"https://api.github.com/repos/labrad/scalabrad-web/tags","blobs_url":"https://api.github.com/repos/labrad/scalabrad-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/labrad/scalabrad-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/labrad/scalabrad-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/labrad/scalabrad-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/labrad/scalabrad-web/statuses/{sha}","languages_url":"https://api.github.com/repos/labrad/scalabrad-web/languages","stargazers_url":"https://api.github.com/repos/labrad/scalabrad-web/stargazers","contributors_url":"https://api.github.com/repos/labrad/scalabrad-web/contributors","subscribers_url":"https://api.github.com/repos/labrad/scalabrad-web/subscribers","subscription_url":"https://api.github.com/repos/labrad/scalabrad-web/subscription","commits_url":"https://api.github.com/repos/labrad/scalabrad-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/labrad/scalabrad-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/labrad/scalabrad-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/labrad/scalabrad-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/labrad/scalabrad-web/contents/{+path}","compare_url":"https://api.github.com/repos/labrad/scalabrad-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/labrad/scalabrad-web/merges","archive_url":"https://api.github.com/repos/labrad/scalabrad-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/labrad/scalabrad-web/downloads","issues_url":"https://api.github.com/repos/labrad/scalabrad-web/issues{/number}","pulls_url":"https://api.github.com/repos/labrad/scalabrad-web/pulls{/number}","milestones_url":"https://api.github.com/repos/labrad/scalabrad-web/milestones{/number}","notifications_url":"https://api.github.com/repos/labrad/scalabrad-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/labrad/scalabrad-web/labels{/name}","releases_url":"https://api.github.com/repos/labrad/scalabrad-web/releases{/id}","deployments_url":"https://api.github.com/repos/labrad/scalabrad-web/deployments","created_at":"2015-03-18T05:34:53Z","updated_at":"2016-08-01T21:37:48Z","pushed_at":"2016-08-04T23:59:13Z","git_url":"git://github.com/labrad/scalabrad-web.git","ssh_url":"git@github.com:labrad/scalabrad-web.git","clone_url":"https://github.com/labrad/scalabrad-web.git","svn_url":"https://github.com/labrad/scalabrad-web","homepage":"","size":944,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":31,"forks":1,"open_issues":31,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/labrad/scalabrad-web/pulls/257"},"html":{"href":"https://github.com/labrad/scalabrad-web/pull/257"},"issue":{"href":"https://api.github.com/repos/labrad/scalabrad-web/issues/257"},"comments":{"href":"https://api.github.com/repos/labrad/scalabrad-web/issues/257/comments"},"review_comments":{"href":"https://api.github.com/repos/labrad/scalabrad-web/pulls/257/comments"},"review_comment":{"href":"https://api.github.com/repos/labrad/scalabrad-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/labrad/scalabrad-web/pulls/257/commits"},"statuses":{"href":"https://api.github.com/repos/labrad/scalabrad-web/statuses/5f555c7897930622720f7772f99f101ebe76a563"}}}}
{"actor":{"display_login":"adamcw"}}