{"action":"created","comment":{"url":"https://api.github.com/repos/rho-devel/rho/pulls/comments/71966861","id":71966861,"diff_hunk":"@@ -0,0 +1,223 @@\n+/*\n+ *  R : A Computer Language for Statistical Data Analysis\n+ *  Copyright (C) 1995, 1996  Robert Gentleman and Ross Ihaka\n+ *  Copyright (C) 1998-2007   The R Development Core Team.\n+ *  Copyright (C) 2008-2014  Andrew R. Runnalls.\n+ *  Copyright (C) 2014 and onwards the Rho Project Authors.\n+ *\n+ *  Rho is not part of the R project, and bugs and other issues should\n+ *  not be reported via r-bugs or other R project channels; instead refer\n+ *  to the Rho website.\n+ *\n+ *  This program is free software; you can redistribute it and/or modify\n+ *  it under the terms of the GNU General Public License as published by\n+ *  the Free Software Foundation; either version 2 of the License, or\n+ *  (at your option) any later version.\n+ *\n+ *  This program is distributed in the hope that it will be useful,\n+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n+ *  GNU General Public License for more details.\n+ *\n+ *  You should have received a copy of the GNU General Public License\n+ *  along with this program; if not, a copy is available at\n+ *  https://www.R-project.org/Licenses/\n+ */\n+\n+#ifndef RHO_GCNODEALLOCATOR_HPP\n+#define RHO_GCNODEALLOCATOR_HPP\n+\n+#include <cstdint>\n+#include <functional>\n+\n+#include \"rho/AddressSanitizer.hpp\"\n+\n+/** Reports an allocation error and calls abort(). */\n+void allocerr(const char* message);\n+\n+namespace rho {\n+  // Forward declarations.\n+  class AllocationTable;\n+  class AllocatorSuperblock;\n+  class GCNode;\n+\n+  /**\n+   * Freelists are used to store superblock nodes and large allocations.\n+   * For large allocations the block and superblock members are unused.\n+   */\n+  struct FreeListNode {","path":"src/include/rho/GCNodeAllocator.hpp","position":48,"original_position":48,"commit_id":"2a5ff9b1039e2ad68e79424e6497f9c10e5f703b","original_commit_id":"2a5ff9b1039e2ad68e79424e6497f9c10e5f703b","user":{"login":"llbit","id":2757386,"avatar_url":"https://avatars.githubusercontent.com/u/2757386?v=3","gravatar_id":"","url":"https://api.github.com/users/llbit","html_url":"https://github.com/llbit","followers_url":"https://api.github.com/users/llbit/followers","following_url":"https://api.github.com/users/llbit/following{/other_user}","gists_url":"https://api.github.com/users/llbit/gists{/gist_id}","starred_url":"https://api.github.com/users/llbit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llbit/subscriptions","organizations_url":"https://api.github.com/users/llbit/orgs","repos_url":"https://api.github.com/users/llbit/repos","events_url":"https://api.github.com/users/llbit/events{/privacy}","received_events_url":"https://api.github.com/users/llbit/received_events","type":"User","site_admin":false},"body":"After looking into this more, I think using `boost::intrusive::slist` is difficult to integrate well with the quarantine list because it needs to unpoison the allocations in the freelist during iteration.","created_at":"2016-07-23T04:38:12Z","updated_at":"2016-07-23T04:38:12Z","html_url":"https://github.com/rho-devel/rho/pull/106#discussion_r71966861","pull_request_url":"https://api.github.com/repos/rho-devel/rho/pulls/106","_links":{"self":{"href":"https://api.github.com/repos/rho-devel/rho/pulls/comments/71966861"},"html":{"href":"https://github.com/rho-devel/rho/pull/106#discussion_r71966861"},"pull_request":{"href":"https://api.github.com/repos/rho-devel/rho/pulls/106"}}},"pull_request":{"url":"https://api.github.com/repos/rho-devel/rho/pulls/106","id":77524150,"html_url":"https://github.com/rho-devel/rho/pull/106","diff_url":"https://github.com/rho-devel/rho/pull/106.diff","patch_url":"https://github.com/rho-devel/rho/pull/106.patch","issue_url":"https://api.github.com/repos/rho-devel/rho/issues/106","number":106,"state":"open","locked":false,"title":"Add BlockPool allocator for GCNode allocation","user":{"login":"llbit","id":2757386,"avatar_url":"https://avatars.githubusercontent.com/u/2757386?v=3","gravatar_id":"","url":"https://api.github.com/users/llbit","html_url":"https://github.com/llbit","followers_url":"https://api.github.com/users/llbit/followers","following_url":"https://api.github.com/users/llbit/following{/other_user}","gists_url":"https://api.github.com/users/llbit/gists{/gist_id}","starred_url":"https://api.github.com/users/llbit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llbit/subscriptions","organizations_url":"https://api.github.com/users/llbit/orgs","repos_url":"https://api.github.com/users/llbit/repos","events_url":"https://api.github.com/users/llbit/events{/privacy}","received_events_url":"https://api.github.com/users/llbit/received_events","type":"User","site_admin":false},"body":"This replaces the use of BDWGC for allocating GCNodes. The BlockPool\r\nallocator allocates small objects in an arena, this speeds up allocation\r\nand pointer lookup for scalars.","created_at":"2016-07-14T20:54:30Z","updated_at":"2016-07-23T04:38:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"13a0550b8a0ac3c51c8fa62bef69f96c733cede7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rho-devel/rho/pulls/106/commits","review_comments_url":"https://api.github.com/repos/rho-devel/rho/pulls/106/comments","review_comment_url":"https://api.github.com/repos/rho-devel/rho/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rho-devel/rho/issues/106/comments","statuses_url":"https://api.github.com/repos/rho-devel/rho/statuses/2a5ff9b1039e2ad68e79424e6497f9c10e5f703b","head":{"label":"llbit:blockpool","ref":"blockpool","sha":"2a5ff9b1039e2ad68e79424e6497f9c10e5f703b","user":{"login":"llbit","id":2757386,"avatar_url":"https://avatars.githubusercontent.com/u/2757386?v=3","gravatar_id":"","url":"https://api.github.com/users/llbit","html_url":"https://github.com/llbit","followers_url":"https://api.github.com/users/llbit/followers","following_url":"https://api.github.com/users/llbit/following{/other_user}","gists_url":"https://api.github.com/users/llbit/gists{/gist_id}","starred_url":"https://api.github.com/users/llbit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llbit/subscriptions","organizations_url":"https://api.github.com/users/llbit/orgs","repos_url":"https://api.github.com/users/llbit/repos","events_url":"https://api.github.com/users/llbit/events{/privacy}","received_events_url":"https://api.github.com/users/llbit/received_events","type":"User","site_admin":false},"repo":{"id":58224837,"name":"rho","full_name":"llbit/rho","owner":{"login":"llbit","id":2757386,"avatar_url":"https://avatars.githubusercontent.com/u/2757386?v=3","gravatar_id":"","url":"https://api.github.com/users/llbit","html_url":"https://github.com/llbit","followers_url":"https://api.github.com/users/llbit/followers","following_url":"https://api.github.com/users/llbit/following{/other_user}","gists_url":"https://api.github.com/users/llbit/gists{/gist_id}","starred_url":"https://api.github.com/users/llbit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llbit/subscriptions","organizations_url":"https://api.github.com/users/llbit/orgs","repos_url":"https://api.github.com/users/llbit/repos","events_url":"https://api.github.com/users/llbit/events{/privacy}","received_events_url":"https://api.github.com/users/llbit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/llbit/rho","description":"","fork":true,"url":"https://api.github.com/repos/llbit/rho","forks_url":"https://api.github.com/repos/llbit/rho/forks","keys_url":"https://api.github.com/repos/llbit/rho/keys{/key_id}","collaborators_url":"https://api.github.com/repos/llbit/rho/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/llbit/rho/teams","hooks_url":"https://api.github.com/repos/llbit/rho/hooks","issue_events_url":"https://api.github.com/repos/llbit/rho/issues/events{/number}","events_url":"https://api.github.com/repos/llbit/rho/events","assignees_url":"https://api.github.com/repos/llbit/rho/assignees{/user}","branches_url":"https://api.github.com/repos/llbit/rho/branches{/branch}","tags_url":"https://api.github.com/repos/llbit/rho/tags","blobs_url":"https://api.github.com/repos/llbit/rho/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/llbit/rho/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/llbit/rho/git/refs{/sha}","trees_url":"https://api.github.com/repos/llbit/rho/git/trees{/sha}","statuses_url":"https://api.github.com/repos/llbit/rho/statuses/{sha}","languages_url":"https://api.github.com/repos/llbit/rho/languages","stargazers_url":"https://api.github.com/repos/llbit/rho/stargazers","contributors_url":"https://api.github.com/repos/llbit/rho/contributors","subscribers_url":"https://api.github.com/repos/llbit/rho/subscribers","subscription_url":"https://api.github.com/repos/llbit/rho/subscription","commits_url":"https://api.github.com/repos/llbit/rho/commits{/sha}","git_commits_url":"https://api.github.com/repos/llbit/rho/git/commits{/sha}","comments_url":"https://api.github.com/repos/llbit/rho/comments{/number}","issue_comment_url":"https://api.github.com/repos/llbit/rho/issues/comments{/number}","contents_url":"https://api.github.com/repos/llbit/rho/contents/{+path}","compare_url":"https://api.github.com/repos/llbit/rho/compare/{base}...{head}","merges_url":"https://api.github.com/repos/llbit/rho/merges","archive_url":"https://api.github.com/repos/llbit/rho/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/llbit/rho/downloads","issues_url":"https://api.github.com/repos/llbit/rho/issues{/number}","pulls_url":"https://api.github.com/repos/llbit/rho/pulls{/number}","milestones_url":"https://api.github.com/repos/llbit/rho/milestones{/number}","notifications_url":"https://api.github.com/repos/llbit/rho/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/llbit/rho/labels{/name}","releases_url":"https://api.github.com/repos/llbit/rho/releases{/id}","deployments_url":"https://api.github.com/repos/llbit/rho/deployments","created_at":"2016-05-06T17:48:18Z","updated_at":"2016-05-06T17:48:38Z","pushed_at":"2016-07-22T21:33:15Z","git_url":"git://github.com/llbit/rho.git","ssh_url":"git@github.com:llbit/rho.git","clone_url":"https://github.com/llbit/rho.git","svn_url":"https://github.com/llbit/rho","homepage":null,"size":290963,"stargazers_count":0,"watchers_count":0,"language":"R","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rho-devel:master","ref":"master","sha":"bb9422b124ff4b21f2cecde0c86b20594479c5b9","user":{"login":"rho-devel","id":7842444,"avatar_url":"https://avatars.githubusercontent.com/u/7842444?v=3","gravatar_id":"","url":"https://api.github.com/users/rho-devel","html_url":"https://github.com/rho-devel","followers_url":"https://api.github.com/users/rho-devel/followers","following_url":"https://api.github.com/users/rho-devel/following{/other_user}","gists_url":"https://api.github.com/users/rho-devel/gists{/gist_id}","starred_url":"https://api.github.com/users/rho-devel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rho-devel/subscriptions","organizations_url":"https://api.github.com/users/rho-devel/orgs","repos_url":"https://api.github.com/users/rho-devel/repos","events_url":"https://api.github.com/users/rho-devel/events{/privacy}","received_events_url":"https://api.github.com/users/rho-devel/received_events","type":"Organization","site_admin":false},"repo":{"id":20585604,"name":"rho","full_name":"rho-devel/rho","owner":{"login":"rho-devel","id":7842444,"avatar_url":"https://avatars.githubusercontent.com/u/7842444?v=3","gravatar_id":"","url":"https://api.github.com/users/rho-devel","html_url":"https://github.com/rho-devel","followers_url":"https://api.github.com/users/rho-devel/followers","following_url":"https://api.github.com/users/rho-devel/following{/other_user}","gists_url":"https://api.github.com/users/rho-devel/gists{/gist_id}","starred_url":"https://api.github.com/users/rho-devel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rho-devel/subscriptions","organizations_url":"https://api.github.com/users/rho-devel/orgs","repos_url":"https://api.github.com/users/rho-devel/repos","events_url":"https://api.github.com/users/rho-devel/events{/privacy}","received_events_url":"https://api.github.com/users/rho-devel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rho-devel/rho","description":"","fork":false,"url":"https://api.github.com/repos/rho-devel/rho","forks_url":"https://api.github.com/repos/rho-devel/rho/forks","keys_url":"https://api.github.com/repos/rho-devel/rho/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rho-devel/rho/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rho-devel/rho/teams","hooks_url":"https://api.github.com/repos/rho-devel/rho/hooks","issue_events_url":"https://api.github.com/repos/rho-devel/rho/issues/events{/number}","events_url":"https://api.github.com/repos/rho-devel/rho/events","assignees_url":"https://api.github.com/repos/rho-devel/rho/assignees{/user}","branches_url":"https://api.github.com/repos/rho-devel/rho/branches{/branch}","tags_url":"https://api.github.com/repos/rho-devel/rho/tags","blobs_url":"https://api.github.com/repos/rho-devel/rho/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rho-devel/rho/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rho-devel/rho/git/refs{/sha}","trees_url":"https://api.github.com/repos/rho-devel/rho/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rho-devel/rho/statuses/{sha}","languages_url":"https://api.github.com/repos/rho-devel/rho/languages","stargazers_url":"https://api.github.com/repos/rho-devel/rho/stargazers","contributors_url":"https://api.github.com/repos/rho-devel/rho/contributors","subscribers_url":"https://api.github.com/repos/rho-devel/rho/subscribers","subscription_url":"https://api.github.com/repos/rho-devel/rho/subscription","commits_url":"https://api.github.com/repos/rho-devel/rho/commits{/sha}","git_commits_url":"https://api.github.com/repos/rho-devel/rho/git/commits{/sha}","comments_url":"https://api.github.com/repos/rho-devel/rho/comments{/number}","issue_comment_url":"https://api.github.com/repos/rho-devel/rho/issues/comments{/number}","contents_url":"https://api.github.com/repos/rho-devel/rho/contents/{+path}","compare_url":"https://api.github.com/repos/rho-devel/rho/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rho-devel/rho/merges","archive_url":"https://api.github.com/repos/rho-devel/rho/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rho-devel/rho/downloads","issues_url":"https://api.github.com/repos/rho-devel/rho/issues{/number}","pulls_url":"https://api.github.com/repos/rho-devel/rho/pulls{/number}","milestones_url":"https://api.github.com/repos/rho-devel/rho/milestones{/number}","notifications_url":"https://api.github.com/repos/rho-devel/rho/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rho-devel/rho/labels{/name}","releases_url":"https://api.github.com/repos/rho-devel/rho/releases{/id}","deployments_url":"https://api.github.com/repos/rho-devel/rho/deployments","created_at":"2014-06-07T04:38:55Z","updated_at":"2016-07-21T11:37:47Z","pushed_at":"2016-07-23T01:04:03Z","git_url":"git://github.com/rho-devel/rho.git","ssh_url":"git@github.com:rho-devel/rho.git","clone_url":"https://github.com/rho-devel/rho.git","svn_url":"https://github.com/rho-devel/rho","homepage":null,"size":309977,"stargazers_count":85,"watchers_count":85,"language":"R","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":8,"forks":17,"open_issues":8,"watchers":85,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rho-devel/rho/pulls/106"},"html":{"href":"https://github.com/rho-devel/rho/pull/106"},"issue":{"href":"https://api.github.com/repos/rho-devel/rho/issues/106"},"comments":{"href":"https://api.github.com/repos/rho-devel/rho/issues/106/comments"},"review_comments":{"href":"https://api.github.com/repos/rho-devel/rho/pulls/106/comments"},"review_comment":{"href":"https://api.github.com/repos/rho-devel/rho/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rho-devel/rho/pulls/106/commits"},"statuses":{"href":"https://api.github.com/repos/rho-devel/rho/statuses/2a5ff9b1039e2ad68e79424e6497f9c10e5f703b"}}}}
{"actor":{"display_login":"llbit"}}