{"action":"created","comment":{"url":"https://api.github.com/repos/vexim/vexim2/pulls/comments/75581647","id":75581647,"diff_hunk":"@@ -492,7 +487,6 @@ dnslookup:\n   domains = ! +local_domains\n   transport = remote_smtp\n   ignore_target_hosts = 0.0.0.0 : 127.0.0.0/8\n-  headers_remove = X-Spam-Report:X-Spam-Score","path":"docs/configure","position":23,"original_position":23,"commit_id":"bfa77ac88bffd72927a996dfdb2c7353c566c3ca","original_commit_id":"bde6bf3db96db591e59704833a83b6462e53274e","user":{"login":"rimas-kudelis","id":2812673,"avatar_url":"https://avatars.githubusercontent.com/u/2812673?v=3","gravatar_id":"","url":"https://api.github.com/users/rimas-kudelis","html_url":"https://github.com/rimas-kudelis","followers_url":"https://api.github.com/users/rimas-kudelis/followers","following_url":"https://api.github.com/users/rimas-kudelis/following{/other_user}","gists_url":"https://api.github.com/users/rimas-kudelis/gists{/gist_id}","starred_url":"https://api.github.com/users/rimas-kudelis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rimas-kudelis/subscriptions","organizations_url":"https://api.github.com/users/rimas-kudelis/orgs","repos_url":"https://api.github.com/users/rimas-kudelis/repos","events_url":"https://api.github.com/users/rimas-kudelis/events{/privacy}","received_events_url":"https://api.github.com/users/rimas-kudelis/received_events","type":"User","site_admin":false},"body":"> Do you have a larger mailbox? \r\n\r\nYes\r\n\r\n> You could just grep through the mails, if there are many with spamassassin-stuff from other mail hosts. I will try that as well.\r\n\r\nI have messages with these headers dating back to 2006, but I can't know for sure whether or not it was my server that added them.\r\n\r\nI'm just thinking if we're removing these headers, why not remove more.\r\n\r\nOn the other hand, perhaps we shouldn't be removing them after all, since preserving them might help with debugging etc. The important thing is not to consider them authoritative. I just got an e-mail from LibreOffice mailing list, and it contains all these X-Spam headers from LibO server.\r\n\r\nThe only downside of keeping them I can think of right now is that they may make the decision more difficult for MUA's which can be told to treat them as authoritative. If one `X-Spam-Flag` says \"NO\", and the other says \"YES\", which one is the right one?\r\nOn the other hand, mail server admin might be about the only person with a \"my server knows best\" opinion, everyone else might be more open or not care enough.\r\n\r\nI'm now in favor of at least commenting out removal of these headers by default. :)","created_at":"2016-08-20T16:53:31Z","updated_at":"2016-08-20T16:53:31Z","html_url":"https://github.com/vexim/vexim2/pull/203#discussion_r75581647","pull_request_url":"https://api.github.com/repos/vexim/vexim2/pulls/203","_links":{"self":{"href":"https://api.github.com/repos/vexim/vexim2/pulls/comments/75581647"},"html":{"href":"https://github.com/vexim/vexim2/pull/203#discussion_r75581647"},"pull_request":{"href":"https://api.github.com/repos/vexim/vexim2/pulls/203"}}},"pull_request":{"url":"https://api.github.com/repos/vexim/vexim2/pulls/203","id":81931302,"html_url":"https://github.com/vexim/vexim2/pull/203","diff_url":"https://github.com/vexim/vexim2/pull/203.diff","patch_url":"https://github.com/vexim/vexim2/pull/203.patch","issue_url":"https://api.github.com/repos/vexim/vexim2/issues/203","number":203,"state":"open","locked":false,"title":"Do not add spam headers during ACL phase so we don't have to remove them later","user":{"login":"rimas-kudelis","id":2812673,"avatar_url":"https://avatars.githubusercontent.com/u/2812673?v=3","gravatar_id":"","url":"https://api.github.com/users/rimas-kudelis","html_url":"https://github.com/rimas-kudelis","followers_url":"https://api.github.com/users/rimas-kudelis/followers","following_url":"https://api.github.com/users/rimas-kudelis/following{/other_user}","gists_url":"https://api.github.com/users/rimas-kudelis/gists{/gist_id}","starred_url":"https://api.github.com/users/rimas-kudelis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rimas-kudelis/subscriptions","organizations_url":"https://api.github.com/users/rimas-kudelis/orgs","repos_url":"https://api.github.com/users/rimas-kudelis/repos","events_url":"https://api.github.com/users/rimas-kudelis/events{/privacy}","received_events_url":"https://api.github.com/users/rimas-kudelis/received_events","type":"User","site_admin":false},"body":"Instead, persist `$spam_*` variables as `$acl_m_spam_*` (except `$spam_score_int`, which persists by itself), and use these variables to add headers at delivery time.\r\nThis will add `X-Spam-Score`, `X-Spam-Score-Int` and `X-Spam-Bar` headers regardless of whether or not the message is spam, but this can be easily changed.\r\n\r\nComments welcome.","created_at":"2016-08-19T06:13:16Z","updated_at":"2016-08-20T16:53:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28e36854c5e03a618ac6f4edacad2134fdc1f009","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/vexim/vexim2/milestones/3","html_url":"https://github.com/vexim/vexim2/milestones/Version%202.3.1","labels_url":"https://api.github.com/repos/vexim/vexim2/milestones/3/labels","id":1765655,"number":3,"title":"Version 2.3.1","description":null,"creator":{"login":"Udera","id":6325524,"avatar_url":"https://avatars.githubusercontent.com/u/6325524?v=3","gravatar_id":"","url":"https://api.github.com/users/Udera","html_url":"https://github.com/Udera","followers_url":"https://api.github.com/users/Udera/followers","following_url":"https://api.github.com/users/Udera/following{/other_user}","gists_url":"https://api.github.com/users/Udera/gists{/gist_id}","starred_url":"https://api.github.com/users/Udera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Udera/subscriptions","organizations_url":"https://api.github.com/users/Udera/orgs","repos_url":"https://api.github.com/users/Udera/repos","events_url":"https://api.github.com/users/Udera/events{/privacy}","received_events_url":"https://api.github.com/users/Udera/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":2,"state":"open","created_at":"2016-05-13T21:11:00Z","updated_at":"2016-08-20T15:25:15Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/vexim/vexim2/pulls/203/commits","review_comments_url":"https://api.github.com/repos/vexim/vexim2/pulls/203/comments","review_comment_url":"https://api.github.com/repos/vexim/vexim2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vexim/vexim2/issues/203/comments","statuses_url":"https://api.github.com/repos/vexim/vexim2/statuses/bfa77ac88bffd72927a996dfdb2c7353c566c3ca","head":{"label":"rimas-kudelis:no-headers-remove","ref":"no-headers-remove","sha":"bfa77ac88bffd72927a996dfdb2c7353c566c3ca","user":{"login":"rimas-kudelis","id":2812673,"avatar_url":"https://avatars.githubusercontent.com/u/2812673?v=3","gravatar_id":"","url":"https://api.github.com/users/rimas-kudelis","html_url":"https://github.com/rimas-kudelis","followers_url":"https://api.github.com/users/rimas-kudelis/followers","following_url":"https://api.github.com/users/rimas-kudelis/following{/other_user}","gists_url":"https://api.github.com/users/rimas-kudelis/gists{/gist_id}","starred_url":"https://api.github.com/users/rimas-kudelis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rimas-kudelis/subscriptions","organizations_url":"https://api.github.com/users/rimas-kudelis/orgs","repos_url":"https://api.github.com/users/rimas-kudelis/repos","events_url":"https://api.github.com/users/rimas-kudelis/events{/privacy}","received_events_url":"https://api.github.com/users/rimas-kudelis/received_events","type":"User","site_admin":false},"repo":{"id":43461207,"name":"vexim2","full_name":"rimas-kudelis/vexim2","owner":{"login":"rimas-kudelis","id":2812673,"avatar_url":"https://avatars.githubusercontent.com/u/2812673?v=3","gravatar_id":"","url":"https://api.github.com/users/rimas-kudelis","html_url":"https://github.com/rimas-kudelis","followers_url":"https://api.github.com/users/rimas-kudelis/followers","following_url":"https://api.github.com/users/rimas-kudelis/following{/other_user}","gists_url":"https://api.github.com/users/rimas-kudelis/gists{/gist_id}","starred_url":"https://api.github.com/users/rimas-kudelis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rimas-kudelis/subscriptions","organizations_url":"https://api.github.com/users/rimas-kudelis/orgs","repos_url":"https://api.github.com/users/rimas-kudelis/repos","events_url":"https://api.github.com/users/rimas-kudelis/events{/privacy}","received_events_url":"https://api.github.com/users/rimas-kudelis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rimas-kudelis/vexim2","description":"Virtual Exim 2","fork":true,"url":"https://api.github.com/repos/rimas-kudelis/vexim2","forks_url":"https://api.github.com/repos/rimas-kudelis/vexim2/forks","keys_url":"https://api.github.com/repos/rimas-kudelis/vexim2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rimas-kudelis/vexim2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rimas-kudelis/vexim2/teams","hooks_url":"https://api.github.com/repos/rimas-kudelis/vexim2/hooks","issue_events_url":"https://api.github.com/repos/rimas-kudelis/vexim2/issues/events{/number}","events_url":"https://api.github.com/repos/rimas-kudelis/vexim2/events","assignees_url":"https://api.github.com/repos/rimas-kudelis/vexim2/assignees{/user}","branches_url":"https://api.github.com/repos/rimas-kudelis/vexim2/branches{/branch}","tags_url":"https://api.github.com/repos/rimas-kudelis/vexim2/tags","blobs_url":"https://api.github.com/repos/rimas-kudelis/vexim2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rimas-kudelis/vexim2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rimas-kudelis/vexim2/git/refs{/sha}","trees_url":"https://api.github.com/repos/rimas-kudelis/vexim2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rimas-kudelis/vexim2/statuses/{sha}","languages_url":"https://api.github.com/repos/rimas-kudelis/vexim2/languages","stargazers_url":"https://api.github.com/repos/rimas-kudelis/vexim2/stargazers","contributors_url":"https://api.github.com/repos/rimas-kudelis/vexim2/contributors","subscribers_url":"https://api.github.com/repos/rimas-kudelis/vexim2/subscribers","subscription_url":"https://api.github.com/repos/rimas-kudelis/vexim2/subscription","commits_url":"https://api.github.com/repos/rimas-kudelis/vexim2/commits{/sha}","git_commits_url":"https://api.github.com/repos/rimas-kudelis/vexim2/git/commits{/sha}","comments_url":"https://api.github.com/repos/rimas-kudelis/vexim2/comments{/number}","issue_comment_url":"https://api.github.com/repos/rimas-kudelis/vexim2/issues/comments{/number}","contents_url":"https://api.github.com/repos/rimas-kudelis/vexim2/contents/{+path}","compare_url":"https://api.github.com/repos/rimas-kudelis/vexim2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rimas-kudelis/vexim2/merges","archive_url":"https://api.github.com/repos/rimas-kudelis/vexim2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rimas-kudelis/vexim2/downloads","issues_url":"https://api.github.com/repos/rimas-kudelis/vexim2/issues{/number}","pulls_url":"https://api.github.com/repos/rimas-kudelis/vexim2/pulls{/number}","milestones_url":"https://api.github.com/repos/rimas-kudelis/vexim2/milestones{/number}","notifications_url":"https://api.github.com/repos/rimas-kudelis/vexim2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rimas-kudelis/vexim2/labels{/name}","releases_url":"https://api.github.com/repos/rimas-kudelis/vexim2/releases{/id}","deployments_url":"https://api.github.com/repos/rimas-kudelis/vexim2/deployments","created_at":"2015-09-30T21:46:52Z","updated_at":"2016-03-02T17:26:45Z","pushed_at":"2016-08-20T16:07:20Z","git_url":"git://github.com/rimas-kudelis/vexim2.git","ssh_url":"git@github.com:rimas-kudelis/vexim2.git","clone_url":"https://github.com/rimas-kudelis/vexim2.git","svn_url":"https://github.com/rimas-kudelis/vexim2","homepage":null,"size":1076,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vexim:master","ref":"master","sha":"f4500939fd618a4f4db10e2f21af5e46d3fbd2cd","user":{"login":"vexim","id":15042477,"avatar_url":"https://avatars.githubusercontent.com/u/15042477?v=3","gravatar_id":"","url":"https://api.github.com/users/vexim","html_url":"https://github.com/vexim","followers_url":"https://api.github.com/users/vexim/followers","following_url":"https://api.github.com/users/vexim/following{/other_user}","gists_url":"https://api.github.com/users/vexim/gists{/gist_id}","starred_url":"https://api.github.com/users/vexim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vexim/subscriptions","organizations_url":"https://api.github.com/users/vexim/orgs","repos_url":"https://api.github.com/users/vexim/repos","events_url":"https://api.github.com/users/vexim/events{/privacy}","received_events_url":"https://api.github.com/users/vexim/received_events","type":"Organization","site_admin":false},"repo":{"id":8384299,"name":"vexim2","full_name":"vexim/vexim2","owner":{"login":"vexim","id":15042477,"avatar_url":"https://avatars.githubusercontent.com/u/15042477?v=3","gravatar_id":"","url":"https://api.github.com/users/vexim","html_url":"https://github.com/vexim","followers_url":"https://api.github.com/users/vexim/followers","following_url":"https://api.github.com/users/vexim/following{/other_user}","gists_url":"https://api.github.com/users/vexim/gists{/gist_id}","starred_url":"https://api.github.com/users/vexim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vexim/subscriptions","organizations_url":"https://api.github.com/users/vexim/orgs","repos_url":"https://api.github.com/users/vexim/repos","events_url":"https://api.github.com/users/vexim/events{/privacy}","received_events_url":"https://api.github.com/users/vexim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vexim/vexim2","description":"Virtual Exim 2","fork":false,"url":"https://api.github.com/repos/vexim/vexim2","forks_url":"https://api.github.com/repos/vexim/vexim2/forks","keys_url":"https://api.github.com/repos/vexim/vexim2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vexim/vexim2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vexim/vexim2/teams","hooks_url":"https://api.github.com/repos/vexim/vexim2/hooks","issue_events_url":"https://api.github.com/repos/vexim/vexim2/issues/events{/number}","events_url":"https://api.github.com/repos/vexim/vexim2/events","assignees_url":"https://api.github.com/repos/vexim/vexim2/assignees{/user}","branches_url":"https://api.github.com/repos/vexim/vexim2/branches{/branch}","tags_url":"https://api.github.com/repos/vexim/vexim2/tags","blobs_url":"https://api.github.com/repos/vexim/vexim2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vexim/vexim2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vexim/vexim2/git/refs{/sha}","trees_url":"https://api.github.com/repos/vexim/vexim2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vexim/vexim2/statuses/{sha}","languages_url":"https://api.github.com/repos/vexim/vexim2/languages","stargazers_url":"https://api.github.com/repos/vexim/vexim2/stargazers","contributors_url":"https://api.github.com/repos/vexim/vexim2/contributors","subscribers_url":"https://api.github.com/repos/vexim/vexim2/subscribers","subscription_url":"https://api.github.com/repos/vexim/vexim2/subscription","commits_url":"https://api.github.com/repos/vexim/vexim2/commits{/sha}","git_commits_url":"https://api.github.com/repos/vexim/vexim2/git/commits{/sha}","comments_url":"https://api.github.com/repos/vexim/vexim2/comments{/number}","issue_comment_url":"https://api.github.com/repos/vexim/vexim2/issues/comments{/number}","contents_url":"https://api.github.com/repos/vexim/vexim2/contents/{+path}","compare_url":"https://api.github.com/repos/vexim/vexim2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vexim/vexim2/merges","archive_url":"https://api.github.com/repos/vexim/vexim2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vexim/vexim2/downloads","issues_url":"https://api.github.com/repos/vexim/vexim2/issues{/number}","pulls_url":"https://api.github.com/repos/vexim/vexim2/pulls{/number}","milestones_url":"https://api.github.com/repos/vexim/vexim2/milestones{/number}","notifications_url":"https://api.github.com/repos/vexim/vexim2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vexim/vexim2/labels{/name}","releases_url":"https://api.github.com/repos/vexim/vexim2/releases{/id}","deployments_url":"https://api.github.com/repos/vexim/vexim2/deployments","created_at":"2013-02-24T00:35:20Z","updated_at":"2016-08-20T03:26:20Z","pushed_at":"2016-08-20T16:07:20Z","git_url":"git://github.com/vexim/vexim2.git","ssh_url":"git@github.com:vexim/vexim2.git","clone_url":"https://github.com/vexim/vexim2.git","svn_url":"https://github.com/vexim/vexim2","homepage":null,"size":1447,"stargazers_count":46,"watchers_count":46,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":30,"forks":34,"open_issues":30,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vexim/vexim2/pulls/203"},"html":{"href":"https://github.com/vexim/vexim2/pull/203"},"issue":{"href":"https://api.github.com/repos/vexim/vexim2/issues/203"},"comments":{"href":"https://api.github.com/repos/vexim/vexim2/issues/203/comments"},"review_comments":{"href":"https://api.github.com/repos/vexim/vexim2/pulls/203/comments"},"review_comment":{"href":"https://api.github.com/repos/vexim/vexim2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vexim/vexim2/pulls/203/commits"},"statuses":{"href":"https://api.github.com/repos/vexim/vexim2/statuses/bfa77ac88bffd72927a996dfdb2c7353c566c3ca"}}}}
{"actor":{"display_login":"rimas-kudelis"}}