{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments/81878816","pull_request_review_id":2826653,"id":81878816,"diff_hunk":"@@ -12,18 +12,48 @@\n # See the License for the specific language governing permissions and\n # limitations under the License.\n \n-IMG = gcr.io/google-containers/kubekins-test\n+IMG = gcr.io/k8s-testimages/kubekins-test\n TAG = $(shell date +v%Y%m%d)-$(shell git describe --tags --always --dirty)\n+FILES := $(wildcard ./Dockerfile-*)\n \n-all: build\n+do_build = \\\n+\t$(eval FILETAG := $(subst ./Dockerfile-,,$(f)))\\\n+\tdocker build -f $(f) -t $(IMG):$(FILETAG)-$(TAG) . ;\\\n+\tdocker tag -f $(IMG):$(FILETAG)-$(TAG) $(IMG):$(FILETAG)-latest ;\\\n+\techo Built $(IMG):$(FILETAG)-$(TAG) and tagged with $(IMG):$(FILETAG)-latest ;\n \n-build:\n-\tdocker build -t $(IMG):$(TAG) .\n-\tdocker tag $(IMG):$(TAG) $(IMG):latest\n-\t@echo Built $(IMG):$(TAG) and tagged with $(IMG):latest\n+do_push = \\\n+\t$(eval FILETAG := $(subst ./Dockerfile-,,$(f)))\\\n+\tgcloud docker -- push $(IMG):$(FILETAG)-$(TAG);\\\n+\tgcloud docker -- push $(IMG):$(FILETAG)-latest;\\\n+\techo Pushed $(IMG):$(FILETAG)-latest and $(IMG):$(FILETAG)-$(TAG);\n \n-push: build\n-\tgcloud docker push $(IMG):$(TAG)\n-\tgcloud docker push $(IMG):latest\n-\t@echo Pushed $(IMG):latest and $(IMG):$(TAG)\n+all:\n+\t@echo Please Explicitly Specify Your Target\n+\n+build-all:\n+\t@$(foreach f,$(FILES),$(do_build))\n+\n+push-all: build\n+\t@$(foreach f,$(FILES),$(do_push))\n+\n+build-single:\n+\t@$(eval f := ./$(filter-out $@,$(MAKECMDGOALS)))\n+\t@$(call do_build,$(f))\n+\n+push-single:\n+\t@$(eval f := $(filter-out $@,$(MAKECMDGOALS)))\n+\t@$(call do_build,$(f))\n+\t@$(call do_push,$(f))\n+\n+help:\n+\t@echo \"TARGETS:\"\n+\t@echo \" all:            NOOP\"\n+\t@echo \" build-all:      builds all the Dockerfile-*\"\n+\t@echo \" push-all:       builds all the Dockerfile-* and pushes to k8s-testimages\"\n+\t@echo \" build-single:   builds target file as an input argument\"","path":"jenkins/test-image/Makefile","position":53,"original_position":53,"commit_id":"d5ed3b2a817f57dcce591d63c09806001a40e708","original_commit_id":"d5ed3b2a817f57dcce591d63c09806001a40e708","user":{"login":"ixdy","id":8061296,"avatar_url":"https://avatars.githubusercontent.com/u/8061296?v=3","gravatar_id":"","url":"https://api.github.com/users/ixdy","html_url":"https://github.com/ixdy","followers_url":"https://api.github.com/users/ixdy/followers","following_url":"https://api.github.com/users/ixdy/following{/other_user}","gists_url":"https://api.github.com/users/ixdy/gists{/gist_id}","starred_url":"https://api.github.com/users/ixdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ixdy/subscriptions","organizations_url":"https://api.github.com/users/ixdy/orgs","repos_url":"https://api.github.com/users/ixdy/repos","events_url":"https://api.github.com/users/ixdy/events{/privacy}","received_events_url":"https://api.github.com/users/ixdy/received_events","type":"User","site_admin":false},"body":"how do you specify the target to build?","created_at":"2016-10-04T23:59:22Z","updated_at":"2016-10-05T00:02:52Z","html_url":"https://github.com/kubernetes/test-infra/pull/740#discussion_r81878816","pull_request_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/740","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments/81878816"},"html":{"href":"https://github.com/kubernetes/test-infra/pull/740#discussion_r81878816"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/740"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/test-infra/pulls/740","id":87818561,"html_url":"https://github.com/kubernetes/test-infra/pull/740","diff_url":"https://github.com/kubernetes/test-infra/pull/740.diff","patch_url":"https://github.com/kubernetes/test-infra/pull/740.patch","issue_url":"https://api.github.com/repos/kubernetes/test-infra/issues/740","number":740,"state":"open","locked":false,"title":"Make two test images for k8s 1.4 ( and previous ), and 1.5","user":{"login":"krzyzacy","id":1108148,"avatar_url":"https://avatars.githubusercontent.com/u/1108148?v=3","gravatar_id":"","url":"https://api.github.com/users/krzyzacy","html_url":"https://github.com/krzyzacy","followers_url":"https://api.github.com/users/krzyzacy/followers","following_url":"https://api.github.com/users/krzyzacy/following{/other_user}","gists_url":"https://api.github.com/users/krzyzacy/gists{/gist_id}","starred_url":"https://api.github.com/users/krzyzacy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krzyzacy/subscriptions","organizations_url":"https://api.github.com/users/krzyzacy/orgs","repos_url":"https://api.github.com/users/krzyzacy/repos","events_url":"https://api.github.com/users/krzyzacy/events{/privacy}","received_events_url":"https://api.github.com/users/krzyzacy/received_events","type":"User","site_admin":false},"body":"Basically now make push will loop through the current dir and gather all\r\nfiles with Dockerfile-*, and * will be part of the tag name. Hope it can\r\nserver other purposes.\r\n\r\nCreated k8s-testimages project to store test images.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/test-infra/740)\n<!-- Reviewable:end -->\n","created_at":"2016-10-04T00:59:34Z","updated_at":"2016-10-05T00:02:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ded8687ebd708b53e965a97c31a58613b9f125f6","assignee":{"login":"ixdy","id":8061296,"avatar_url":"https://avatars.githubusercontent.com/u/8061296?v=3","gravatar_id":"","url":"https://api.github.com/users/ixdy","html_url":"https://github.com/ixdy","followers_url":"https://api.github.com/users/ixdy/followers","following_url":"https://api.github.com/users/ixdy/following{/other_user}","gists_url":"https://api.github.com/users/ixdy/gists{/gist_id}","starred_url":"https://api.github.com/users/ixdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ixdy/subscriptions","organizations_url":"https://api.github.com/users/ixdy/orgs","repos_url":"https://api.github.com/users/ixdy/repos","events_url":"https://api.github.com/users/ixdy/events{/privacy}","received_events_url":"https://api.github.com/users/ixdy/received_events","type":"User","site_admin":false},"assignees":[{"login":"ixdy","id":8061296,"avatar_url":"https://avatars.githubusercontent.com/u/8061296?v=3","gravatar_id":"","url":"https://api.github.com/users/ixdy","html_url":"https://github.com/ixdy","followers_url":"https://api.github.com/users/ixdy/followers","following_url":"https://api.github.com/users/ixdy/following{/other_user}","gists_url":"https://api.github.com/users/ixdy/gists{/gist_id}","starred_url":"https://api.github.com/users/ixdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ixdy/subscriptions","organizations_url":"https://api.github.com/users/ixdy/orgs","repos_url":"https://api.github.com/users/ixdy/repos","events_url":"https://api.github.com/users/ixdy/events{/privacy}","received_events_url":"https://api.github.com/users/ixdy/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/740/commits","review_comments_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/740/comments","review_comment_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/issues/740/comments","statuses_url":"https://api.github.com/repos/kubernetes/test-infra/statuses/d5ed3b2a817f57dcce591d63c09806001a40e708","head":{"label":"krzyzacy:image","ref":"image","sha":"d5ed3b2a817f57dcce591d63c09806001a40e708","user":{"login":"krzyzacy","id":1108148,"avatar_url":"https://avatars.githubusercontent.com/u/1108148?v=3","gravatar_id":"","url":"https://api.github.com/users/krzyzacy","html_url":"https://github.com/krzyzacy","followers_url":"https://api.github.com/users/krzyzacy/followers","following_url":"https://api.github.com/users/krzyzacy/following{/other_user}","gists_url":"https://api.github.com/users/krzyzacy/gists{/gist_id}","starred_url":"https://api.github.com/users/krzyzacy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krzyzacy/subscriptions","organizations_url":"https://api.github.com/users/krzyzacy/orgs","repos_url":"https://api.github.com/users/krzyzacy/repos","events_url":"https://api.github.com/users/krzyzacy/events{/privacy}","received_events_url":"https://api.github.com/users/krzyzacy/received_events","type":"User","site_admin":false},"repo":{"id":65492161,"name":"test-infra","full_name":"krzyzacy/test-infra","owner":{"login":"krzyzacy","id":1108148,"avatar_url":"https://avatars.githubusercontent.com/u/1108148?v=3","gravatar_id":"","url":"https://api.github.com/users/krzyzacy","html_url":"https://github.com/krzyzacy","followers_url":"https://api.github.com/users/krzyzacy/followers","following_url":"https://api.github.com/users/krzyzacy/following{/other_user}","gists_url":"https://api.github.com/users/krzyzacy/gists{/gist_id}","starred_url":"https://api.github.com/users/krzyzacy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krzyzacy/subscriptions","organizations_url":"https://api.github.com/users/krzyzacy/orgs","repos_url":"https://api.github.com/users/krzyzacy/repos","events_url":"https://api.github.com/users/krzyzacy/events{/privacy}","received_events_url":"https://api.github.com/users/krzyzacy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krzyzacy/test-infra","description":"Test infrastructure for the Kubernetes project.","fork":true,"url":"https://api.github.com/repos/krzyzacy/test-infra","forks_url":"https://api.github.com/repos/krzyzacy/test-infra/forks","keys_url":"https://api.github.com/repos/krzyzacy/test-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krzyzacy/test-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krzyzacy/test-infra/teams","hooks_url":"https://api.github.com/repos/krzyzacy/test-infra/hooks","issue_events_url":"https://api.github.com/repos/krzyzacy/test-infra/issues/events{/number}","events_url":"https://api.github.com/repos/krzyzacy/test-infra/events","assignees_url":"https://api.github.com/repos/krzyzacy/test-infra/assignees{/user}","branches_url":"https://api.github.com/repos/krzyzacy/test-infra/branches{/branch}","tags_url":"https://api.github.com/repos/krzyzacy/test-infra/tags","blobs_url":"https://api.github.com/repos/krzyzacy/test-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krzyzacy/test-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krzyzacy/test-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/krzyzacy/test-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krzyzacy/test-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/krzyzacy/test-infra/languages","stargazers_url":"https://api.github.com/repos/krzyzacy/test-infra/stargazers","contributors_url":"https://api.github.com/repos/krzyzacy/test-infra/contributors","subscribers_url":"https://api.github.com/repos/krzyzacy/test-infra/subscribers","subscription_url":"https://api.github.com/repos/krzyzacy/test-infra/subscription","commits_url":"https://api.github.com/repos/krzyzacy/test-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/krzyzacy/test-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/krzyzacy/test-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/krzyzacy/test-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/krzyzacy/test-infra/contents/{+path}","compare_url":"https://api.github.com/repos/krzyzacy/test-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krzyzacy/test-infra/merges","archive_url":"https://api.github.com/repos/krzyzacy/test-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krzyzacy/test-infra/downloads","issues_url":"https://api.github.com/repos/krzyzacy/test-infra/issues{/number}","pulls_url":"https://api.github.com/repos/krzyzacy/test-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/krzyzacy/test-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/krzyzacy/test-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krzyzacy/test-infra/labels{/name}","releases_url":"https://api.github.com/repos/krzyzacy/test-infra/releases{/id}","deployments_url":"https://api.github.com/repos/krzyzacy/test-infra/deployments","created_at":"2016-08-11T18:25:52Z","updated_at":"2016-08-11T18:25:54Z","pushed_at":"2016-10-04T22:30:01Z","git_url":"git://github.com/krzyzacy/test-infra.git","ssh_url":"git@github.com:krzyzacy/test-infra.git","clone_url":"https://github.com/krzyzacy/test-infra.git","svn_url":"https://github.com/krzyzacy/test-infra","homepage":null,"size":5030,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"c35a411a17a109b2c9f8fab339f8aec5cbf53a7a","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":57333709,"name":"test-infra","full_name":"kubernetes/test-infra","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/test-infra","description":"Test infrastructure for the Kubernetes project.","fork":false,"url":"https://api.github.com/repos/kubernetes/test-infra","forks_url":"https://api.github.com/repos/kubernetes/test-infra/forks","keys_url":"https://api.github.com/repos/kubernetes/test-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/test-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/test-infra/teams","hooks_url":"https://api.github.com/repos/kubernetes/test-infra/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/test-infra/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/test-infra/events","assignees_url":"https://api.github.com/repos/kubernetes/test-infra/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/test-infra/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/test-infra/tags","blobs_url":"https://api.github.com/repos/kubernetes/test-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/test-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/test-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/test-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/test-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/test-infra/languages","stargazers_url":"https://api.github.com/repos/kubernetes/test-infra/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/test-infra/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/test-infra/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/test-infra/subscription","commits_url":"https://api.github.com/repos/kubernetes/test-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/test-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/test-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/test-infra/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/test-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/test-infra/merges","archive_url":"https://api.github.com/repos/kubernetes/test-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/test-infra/downloads","issues_url":"https://api.github.com/repos/kubernetes/test-infra/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/test-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/test-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/test-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/test-infra/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/test-infra/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/test-infra/deployments","created_at":"2016-04-28T21:05:35Z","updated_at":"2016-10-04T21:33:29Z","pushed_at":"2016-10-04T23:37:31Z","git_url":"git://github.com/kubernetes/test-infra.git","ssh_url":"git@github.com:kubernetes/test-infra.git","clone_url":"https://github.com/kubernetes/test-infra.git","svn_url":"https://github.com/kubernetes/test-infra","homepage":null,"size":5532,"stargazers_count":19,"watchers_count":19,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":59,"mirror_url":null,"open_issues_count":50,"forks":59,"open_issues":50,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/740"},"html":{"href":"https://github.com/kubernetes/test-infra/pull/740"},"issue":{"href":"https://api.github.com/repos/kubernetes/test-infra/issues/740"},"comments":{"href":"https://api.github.com/repos/kubernetes/test-infra/issues/740/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/740/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/740/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/test-infra/statuses/d5ed3b2a817f57dcce591d63c09806001a40e708"}}}}
{"actor":{"display_login":"ixdy"}}