{"action":"created","comment":{"url":"https://api.github.com/repos/openspending/fiscal-data-package/pulls/comments/66779692","id":66779692,"diff_hunk":"@@ -335,163 +325,131 @@ Each dimension is represented by a key in the `dimensions` object. The object ha\n }\n ```\n \n-## Examples\n-\n-{% assign sorted_pages = site.pages | sort:\"order\" %}\n-{% for page in sorted_pages %}\n-  {% if page.category == 'example' %}\n-  * [{{ page.title }}]({{ page.url | remove: 'index.html' }}) \n-  {% endif %}\n-{% endfor %}\n-\n-# Content\n-\n-This section provides a standard framework for the \"content\" of Fiscal Data Packages. The previous section has been about the form both for the data (e.g. that it is CSV) and for the metadata (the information in the datapackage.json). This section is about the \"content\", that is the kind of actual data a Package contains. In particular, it sets out guidelines for what information, exactly, is present. For example, that government budget information is classified according to a standard classification codesheet like the [UN's COFOG][cofog].\n-\n-[cofog]: http://data.okfn.org/data/core/cofog/\n-\n-Content requirements will necessarily vary across the different types of fiscal data. For example, the data describing high level budgets may be different from that describing day-to-day expenditures, and expenditure information may be different from revenue. Thus, our framework will distinguish different types of fiscal data.\n-\n-We also emphasize that what we provide is a framework rather than a strict standard. That is, we provide recommendations on what information should be provided rather than strict requirements.\n-\n-Finally, our recommendations place requirements on the \"logical\" model not the physical model. Of course, the logical model data is sourced from the physical model so requirements on the logical model ultimately place requirements on the physical model. However, by defining our requirements on the logical model, we keep the flexibility in naming and structure of the raw, source data - for example, whilst a classification dimension with COFOG data should be named `cofog` and have an attribute called `code` your source CSV could have that COFOG data in a column called \"COFOG-Code\" or \"Classification\" or any other name.\n-\n \n-## Required data (all categories)\n+# Dimension types\n \n-All datasets MUST have at least one measure. Essentially this is requiring each dataset have at least one field / column which corresponds to an \"amount\" of money.\n+This section provides guidance, and certain requirements, on the naming of dimension attributes. For example, if you have a column representing the name of an organisation, it should be modelled as a `title` attribute on an dimension with `dimensionType` of `entity`.\n \n-## Special Dimensions\n+## Classification\n \n-### Classifications\n-\n-It is common for fiscal data to be classified in various ways. A classification is a labelling of a given item with a reference to standardized codesheet.\n-\n-Classifications will be represented in the model as a dimension. Each classification dimension `MUST` have a `code` attribute whose value will correspond to the classification code in the official codesheet. Sometimes classifications can change and we recommend utilizing a `version` attribute if there is a need to indicate the version of a classification.\n-\n-Whenever we have a code attribute in a classification dimension, the licit values for that attribute consist of the numerical codes from the appropriate codesheet, with hierarchical levels separated by periods. `1.1.4.1.3` is a licit value for a dimension named `gfsm`, for example, corresponding to the code for \"Turnover and other general taxes on goods and services\".\n-\n-Classifications are of different types. The type of the classification `MAY` be indicated using the `classificationType` attribute on the dimension. Values are:\n-\n-* `functional`\n-* `administrative`\n-* `economic`\n-\n-#### Hierarchical Classifications\n-\n-It is common for classifications to be hierarchical and have different levels. For example, a functional classification might include a top-level of \"Healthcare\" and a sub-level under \"Healthcare\" of \"Hospitals\".\n-\n-This hierarchical structure of the classification can be recorded using the keyword `parent`.  The `parent` keyword is used within an attribute definition to reference another attribute in the same dimension that is the parent of the first attribute. Here is an example:\n+```javascript\n+\"spending-classification\": {\n+  \"dimensionType\": \"classification\",\n+\n+  // RECOMMENDED: The basis on which transactions are being classified, one of these values:\n+  //\n+  // * \"administrative\": an organisational structure, such as \n+  //   Portfolio > Department > Branch\n+  // * \"functional\": the purpose of the spending, such as \n+  //   Health > Hospital services > Nursing\n+  // * \"economic\": focused on the nature of the accounting, such \n+  //   as Compensation > Wages and salaries > Wages and salaries in cash\n+  \"classificationType\": \"administrative\"\n \n-```\n-\"your-classification\": {\n   \"attributes\": {\n+    // REQUIRED: a \"code\" column containing unique identifiers from an official codesheet. If classifications are subject to change, a `version` attribute `SHOULD` be used. \n     \"code\": {\n-      // this will be the precise code\n-      \"source\": \"...\"\n+      \"source\": \"PROJECT_CODE\",\n+      // To define a hierarchical classification, the \"parent\" attribute refers to the attribute \"above\" it in the hierarchy.\n+      // Set it on the `code` field, not a title field. See the [\"Labels and Hierarchies\" example][/examples/labels-and-hierarchies/].\n+      \"parent\": \"PROGRAMME_NAME\"","path":"spec/index.md","position":129,"original_position":126,"commit_id":"c327309437cecc9ef0298464cb962d9b256bc9d3","original_commit_id":"ac5dd8bbe1e1092301368e99b76161fce8f4b5ec","user":{"login":"stevage","id":678344,"avatar_url":"https://avatars.githubusercontent.com/u/678344?v=3","gravatar_id":"","url":"https://api.github.com/users/stevage","html_url":"https://github.com/stevage","followers_url":"https://api.github.com/users/stevage/followers","following_url":"https://api.github.com/users/stevage/following{/other_user}","gists_url":"https://api.github.com/users/stevage/gists{/gist_id}","starred_url":"https://api.github.com/users/stevage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevage/subscriptions","organizations_url":"https://api.github.com/users/stevage/orgs","repos_url":"https://api.github.com/users/stevage/repos","events_url":"https://api.github.com/users/stevage/events{/privacy}","received_events_url":"https://api.github.com/users/stevage/received_events","type":"User","site_admin":false},"body":"Thinking about it more, there wasn't much I could add about the `code` attribute - but maybe I missed something. There's definitely a bit of a gap in the spec about how external codesheets are referenced.","created_at":"2016-06-13T11:59:17Z","updated_at":"2016-06-13T11:59:17Z","html_url":"https://github.com/openspending/fiscal-data-package/pull/157#discussion_r66779692","pull_request_url":"https://api.github.com/repos/openspending/fiscal-data-package/pulls/157","_links":{"self":{"href":"https://api.github.com/repos/openspending/fiscal-data-package/pulls/comments/66779692"},"html":{"href":"https://github.com/openspending/fiscal-data-package/pull/157#discussion_r66779692"},"pull_request":{"href":"https://api.github.com/repos/openspending/fiscal-data-package/pulls/157"}}},"pull_request":{"url":"https://api.github.com/repos/openspending/fiscal-data-package/pulls/157","id":73499114,"html_url":"https://github.com/openspending/fiscal-data-package/pull/157","diff_url":"https://github.com/openspending/fiscal-data-package/pull/157.diff","patch_url":"https://github.com/openspending/fiscal-data-package/pull/157.patch","issue_url":"https://api.github.com/repos/openspending/fiscal-data-package/issues/157","number":157,"state":"open","locked":false,"title":"Huge simplification and tighten-up of the \"Content\" section, ","user":{"login":"stevage","id":678344,"avatar_url":"https://avatars.githubusercontent.com/u/678344?v=3","gravatar_id":"","url":"https://api.github.com/users/stevage","html_url":"https://github.com/stevage","followers_url":"https://api.github.com/users/stevage/followers","following_url":"https://api.github.com/users/stevage/following{/other_user}","gists_url":"https://api.github.com/users/stevage/gists{/gist_id}","starred_url":"https://api.github.com/users/stevage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevage/subscriptions","organizations_url":"https://api.github.com/users/stevage/orgs","repos_url":"https://api.github.com/users/stevage/repos","events_url":"https://api.github.com/users/stevage/events{/privacy}","received_events_url":"https://api.github.com/users/stevage/received_events","type":"User","site_admin":false},"body":"which is now renamed \"Dimension types\". Removed a lot of chatter, replacing it with\r\nspecific guidance in commented JSON format.\r\n\r\nOne thing I noticed is that there are a couple of underspecified recommendations:\r\n\r\n- how exactly should codelist versions be specified\r\n- how should location codelists be referred to?","created_at":"2016-06-12T15:34:18Z","updated_at":"2016-06-13T11:59:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"adb563656c26cb7f2010b80154f1cc5190bc11a8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openspending/fiscal-data-package/pulls/157/commits","review_comments_url":"https://api.github.com/repos/openspending/fiscal-data-package/pulls/157/comments","review_comment_url":"https://api.github.com/repos/openspending/fiscal-data-package/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openspending/fiscal-data-package/issues/157/comments","statuses_url":"https://api.github.com/repos/openspending/fiscal-data-package/statuses/c327309437cecc9ef0298464cb962d9b256bc9d3","head":{"label":"stevage:dimension-types-cleanup","ref":"dimension-types-cleanup","sha":"c327309437cecc9ef0298464cb962d9b256bc9d3","user":{"login":"stevage","id":678344,"avatar_url":"https://avatars.githubusercontent.com/u/678344?v=3","gravatar_id":"","url":"https://api.github.com/users/stevage","html_url":"https://github.com/stevage","followers_url":"https://api.github.com/users/stevage/followers","following_url":"https://api.github.com/users/stevage/following{/other_user}","gists_url":"https://api.github.com/users/stevage/gists{/gist_id}","starred_url":"https://api.github.com/users/stevage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevage/subscriptions","organizations_url":"https://api.github.com/users/stevage/orgs","repos_url":"https://api.github.com/users/stevage/repos","events_url":"https://api.github.com/users/stevage/events{/privacy}","received_events_url":"https://api.github.com/users/stevage/received_events","type":"User","site_admin":false},"repo":{"id":46640225,"name":"fiscal-data-package","full_name":"stevage/fiscal-data-package","owner":{"login":"stevage","id":678344,"avatar_url":"https://avatars.githubusercontent.com/u/678344?v=3","gravatar_id":"","url":"https://api.github.com/users/stevage","html_url":"https://github.com/stevage","followers_url":"https://api.github.com/users/stevage/followers","following_url":"https://api.github.com/users/stevage/following{/other_user}","gists_url":"https://api.github.com/users/stevage/gists{/gist_id}","starred_url":"https://api.github.com/users/stevage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevage/subscriptions","organizations_url":"https://api.github.com/users/stevage/orgs","repos_url":"https://api.github.com/users/stevage/repos","events_url":"https://api.github.com/users/stevage/events{/privacy}","received_events_url":"https://api.github.com/users/stevage/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stevage/fiscal-data-package","description":"Fiscal Data Package, an open specification for government budget and spending data.","fork":true,"url":"https://api.github.com/repos/stevage/fiscal-data-package","forks_url":"https://api.github.com/repos/stevage/fiscal-data-package/forks","keys_url":"https://api.github.com/repos/stevage/fiscal-data-package/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stevage/fiscal-data-package/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stevage/fiscal-data-package/teams","hooks_url":"https://api.github.com/repos/stevage/fiscal-data-package/hooks","issue_events_url":"https://api.github.com/repos/stevage/fiscal-data-package/issues/events{/number}","events_url":"https://api.github.com/repos/stevage/fiscal-data-package/events","assignees_url":"https://api.github.com/repos/stevage/fiscal-data-package/assignees{/user}","branches_url":"https://api.github.com/repos/stevage/fiscal-data-package/branches{/branch}","tags_url":"https://api.github.com/repos/stevage/fiscal-data-package/tags","blobs_url":"https://api.github.com/repos/stevage/fiscal-data-package/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stevage/fiscal-data-package/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stevage/fiscal-data-package/git/refs{/sha}","trees_url":"https://api.github.com/repos/stevage/fiscal-data-package/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stevage/fiscal-data-package/statuses/{sha}","languages_url":"https://api.github.com/repos/stevage/fiscal-data-package/languages","stargazers_url":"https://api.github.com/repos/stevage/fiscal-data-package/stargazers","contributors_url":"https://api.github.com/repos/stevage/fiscal-data-package/contributors","subscribers_url":"https://api.github.com/repos/stevage/fiscal-data-package/subscribers","subscription_url":"https://api.github.com/repos/stevage/fiscal-data-package/subscription","commits_url":"https://api.github.com/repos/stevage/fiscal-data-package/commits{/sha}","git_commits_url":"https://api.github.com/repos/stevage/fiscal-data-package/git/commits{/sha}","comments_url":"https://api.github.com/repos/stevage/fiscal-data-package/comments{/number}","issue_comment_url":"https://api.github.com/repos/stevage/fiscal-data-package/issues/comments{/number}","contents_url":"https://api.github.com/repos/stevage/fiscal-data-package/contents/{+path}","compare_url":"https://api.github.com/repos/stevage/fiscal-data-package/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stevage/fiscal-data-package/merges","archive_url":"https://api.github.com/repos/stevage/fiscal-data-package/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stevage/fiscal-data-package/downloads","issues_url":"https://api.github.com/repos/stevage/fiscal-data-package/issues{/number}","pulls_url":"https://api.github.com/repos/stevage/fiscal-data-package/pulls{/number}","milestones_url":"https://api.github.com/repos/stevage/fiscal-data-package/milestones{/number}","notifications_url":"https://api.github.com/repos/stevage/fiscal-data-package/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stevage/fiscal-data-package/labels{/name}","releases_url":"https://api.github.com/repos/stevage/fiscal-data-package/releases{/id}","deployments_url":"https://api.github.com/repos/stevage/fiscal-data-package/deployments","created_at":"2015-11-22T00:37:39Z","updated_at":"2015-11-22T00:37:41Z","pushed_at":"2016-06-13T10:13:40Z","git_url":"git://github.com/stevage/fiscal-data-package.git","ssh_url":"git@github.com:stevage/fiscal-data-package.git","clone_url":"https://github.com/stevage/fiscal-data-package.git","svn_url":"https://github.com/stevage/fiscal-data-package","homepage":"http://fiscal.dataprotocols.org/","size":265,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openspending:master","ref":"master","sha":"908f50d5e808ec19c4cbc354c92e0fb0b2ab6c09","user":{"login":"openspending","id":1392301,"avatar_url":"https://avatars.githubusercontent.com/u/1392301?v=3","gravatar_id":"","url":"https://api.github.com/users/openspending","html_url":"https://github.com/openspending","followers_url":"https://api.github.com/users/openspending/followers","following_url":"https://api.github.com/users/openspending/following{/other_user}","gists_url":"https://api.github.com/users/openspending/gists{/gist_id}","starred_url":"https://api.github.com/users/openspending/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openspending/subscriptions","organizations_url":"https://api.github.com/users/openspending/orgs","repos_url":"https://api.github.com/users/openspending/repos","events_url":"https://api.github.com/users/openspending/events{/privacy}","received_events_url":"https://api.github.com/users/openspending/received_events","type":"Organization","site_admin":false},"repo":{"id":19077889,"name":"fiscal-data-package","full_name":"openspending/fiscal-data-package","owner":{"login":"openspending","id":1392301,"avatar_url":"https://avatars.githubusercontent.com/u/1392301?v=3","gravatar_id":"","url":"https://api.github.com/users/openspending","html_url":"https://github.com/openspending","followers_url":"https://api.github.com/users/openspending/followers","following_url":"https://api.github.com/users/openspending/following{/other_user}","gists_url":"https://api.github.com/users/openspending/gists{/gist_id}","starred_url":"https://api.github.com/users/openspending/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openspending/subscriptions","organizations_url":"https://api.github.com/users/openspending/orgs","repos_url":"https://api.github.com/users/openspending/repos","events_url":"https://api.github.com/users/openspending/events{/privacy}","received_events_url":"https://api.github.com/users/openspending/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openspending/fiscal-data-package","description":"Fiscal Data Package, an open specification for government budget and spending data.","fork":false,"url":"https://api.github.com/repos/openspending/fiscal-data-package","forks_url":"https://api.github.com/repos/openspending/fiscal-data-package/forks","keys_url":"https://api.github.com/repos/openspending/fiscal-data-package/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openspending/fiscal-data-package/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openspending/fiscal-data-package/teams","hooks_url":"https://api.github.com/repos/openspending/fiscal-data-package/hooks","issue_events_url":"https://api.github.com/repos/openspending/fiscal-data-package/issues/events{/number}","events_url":"https://api.github.com/repos/openspending/fiscal-data-package/events","assignees_url":"https://api.github.com/repos/openspending/fiscal-data-package/assignees{/user}","branches_url":"https://api.github.com/repos/openspending/fiscal-data-package/branches{/branch}","tags_url":"https://api.github.com/repos/openspending/fiscal-data-package/tags","blobs_url":"https://api.github.com/repos/openspending/fiscal-data-package/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openspending/fiscal-data-package/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openspending/fiscal-data-package/git/refs{/sha}","trees_url":"https://api.github.com/repos/openspending/fiscal-data-package/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openspending/fiscal-data-package/statuses/{sha}","languages_url":"https://api.github.com/repos/openspending/fiscal-data-package/languages","stargazers_url":"https://api.github.com/repos/openspending/fiscal-data-package/stargazers","contributors_url":"https://api.github.com/repos/openspending/fiscal-data-package/contributors","subscribers_url":"https://api.github.com/repos/openspending/fiscal-data-package/subscribers","subscription_url":"https://api.github.com/repos/openspending/fiscal-data-package/subscription","commits_url":"https://api.github.com/repos/openspending/fiscal-data-package/commits{/sha}","git_commits_url":"https://api.github.com/repos/openspending/fiscal-data-package/git/commits{/sha}","comments_url":"https://api.github.com/repos/openspending/fiscal-data-package/comments{/number}","issue_comment_url":"https://api.github.com/repos/openspending/fiscal-data-package/issues/comments{/number}","contents_url":"https://api.github.com/repos/openspending/fiscal-data-package/contents/{+path}","compare_url":"https://api.github.com/repos/openspending/fiscal-data-package/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openspending/fiscal-data-package/merges","archive_url":"https://api.github.com/repos/openspending/fiscal-data-package/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openspending/fiscal-data-package/downloads","issues_url":"https://api.github.com/repos/openspending/fiscal-data-package/issues{/number}","pulls_url":"https://api.github.com/repos/openspending/fiscal-data-package/pulls{/number}","milestones_url":"https://api.github.com/repos/openspending/fiscal-data-package/milestones{/number}","notifications_url":"https://api.github.com/repos/openspending/fiscal-data-package/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openspending/fiscal-data-package/labels{/name}","releases_url":"https://api.github.com/repos/openspending/fiscal-data-package/releases{/id}","deployments_url":"https://api.github.com/repos/openspending/fiscal-data-package/deployments","created_at":"2014-04-23T16:57:12Z","updated_at":"2016-04-14T12:21:38Z","pushed_at":"2016-06-13T10:13:41Z","git_url":"git://github.com/openspending/fiscal-data-package.git","ssh_url":"git@github.com:openspending/fiscal-data-package.git","clone_url":"https://github.com/openspending/fiscal-data-package.git","svn_url":"https://github.com/openspending/fiscal-data-package","homepage":"http://fiscal.dataprotocols.org/","size":233,"stargazers_count":21,"watchers_count":21,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":22,"forks":5,"open_issues":22,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openspending/fiscal-data-package/pulls/157"},"html":{"href":"https://github.com/openspending/fiscal-data-package/pull/157"},"issue":{"href":"https://api.github.com/repos/openspending/fiscal-data-package/issues/157"},"comments":{"href":"https://api.github.com/repos/openspending/fiscal-data-package/issues/157/comments"},"review_comments":{"href":"https://api.github.com/repos/openspending/fiscal-data-package/pulls/157/comments"},"review_comment":{"href":"https://api.github.com/repos/openspending/fiscal-data-package/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openspending/fiscal-data-package/pulls/157/commits"},"statuses":{"href":"https://api.github.com/repos/openspending/fiscal-data-package/statuses/c327309437cecc9ef0298464cb962d9b256bc9d3"}}}}
{"actor":{"display_login":"stevage"}}