{"action":"created","issue":{"url":"https://api.github.com/repos/esheldon/fitsio/issues/95","repository_url":"https://api.github.com/repos/esheldon/fitsio","labels_url":"https://api.github.com/repos/esheldon/fitsio/issues/95/labels{/name}","comments_url":"https://api.github.com/repos/esheldon/fitsio/issues/95/comments","events_url":"https://api.github.com/repos/esheldon/fitsio/issues/95/events","html_url":"https://github.com/esheldon/fitsio/issues/95","id":170576670,"number":95,"title":"current master is not py3 compatible","user":{"login":"dneise","id":8200858,"avatar_url":"https://avatars.githubusercontent.com/u/8200858?v=3","gravatar_id":"","url":"https://api.github.com/users/dneise","html_url":"https://github.com/dneise","followers_url":"https://api.github.com/users/dneise/followers","following_url":"https://api.github.com/users/dneise/following{/other_user}","gists_url":"https://api.github.com/users/dneise/gists{/gist_id}","starred_url":"https://api.github.com/users/dneise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dneise/subscriptions","organizations_url":"https://api.github.com/users/dneise/orgs","repos_url":"https://api.github.com/users/dneise/repos","events_url":"https://api.github.com/users/dneise/events{/privacy}","received_events_url":"https://api.github.com/users/dneise/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-08-11T06:11:51Z","updated_at":"2016-08-11T13:51:21Z","closed_at":null,"body":"The problems I reported in #94, were based on version 0.9.9.1 installed from pypi. \r\nI wanted to have a closer look myself and maybe even propose  a PR on this matter, so I installed the master, which also claims to be 0.9.9.1\r\n\r\nBut the master is not py3 compatible. The build does not fail on py3, but `import fitsio` fails.\r\nI checked your `travis.yml` and saw that the build is performed, but the tests are not done, so you cannot see if everything works.\r\n\r\nI have not much experience with travis, so I forked your repo and played around so I can find a minimalistic yml, which reproduces the error.\r\n\r\nOne can find the log on https://travis-ci.org/dneise/fitsio\r\nand the minimalistic `travis.yml` here: https://github.com/dneise/fitsio/blob/master/.travis.yml\r\n\r\n----\r\n\r\nThe version on pypi is py3 compatible, so I wondered what I did wrong. First I assumed you might have a dedicated py3 branch, but there are no active branches.\r\n\r\n----\r\n\r\nThen I ran `2to3` on `fitsio/fitslib.py`, which was enough to let me `import fitsio` successfully, \r\nbut the tests now fail. \r\n"},"comment":{"url":"https://api.github.com/repos/esheldon/fitsio/issues/comments/239166572","html_url":"https://github.com/esheldon/fitsio/issues/95#issuecomment-239166572","issue_url":"https://api.github.com/repos/esheldon/fitsio/issues/95","id":239166572,"user":{"login":"dneise","id":8200858,"avatar_url":"https://avatars.githubusercontent.com/u/8200858?v=3","gravatar_id":"","url":"https://api.github.com/users/dneise","html_url":"https://github.com/dneise","followers_url":"https://api.github.com/users/dneise/followers","following_url":"https://api.github.com/users/dneise/following{/other_user}","gists_url":"https://api.github.com/users/dneise/gists{/gist_id}","starred_url":"https://api.github.com/users/dneise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dneise/subscriptions","organizations_url":"https://api.github.com/users/dneise/orgs","repos_url":"https://api.github.com/users/dneise/repos","events_url":"https://api.github.com/users/dneise/events{/privacy}","received_events_url":"https://api.github.com/users/dneise/received_events","type":"User","site_admin":false},"created_at":"2016-08-11T13:51:21Z","updated_at":"2016-08-11T13:51:21Z","body":"Ah aweseom ...  now I start to understand.\r\n\r\nThe line \r\n\"pip install -e .\" \r\ndoes install the package.\r\n\r\nat least I though so.\r\n\r\nBut apparently it does not invoke the \"build_py_2to3\" part in the setup.py file. No idea why ... I will try to find it out."}}
{"actor":{"display_login":"dneise"}}