{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/EntityFramework/pulls/comments/85792423","pull_request_review_id":6487067,"id":85792423,"diff_hunk":"@@ -6277,6 +6277,29 @@ public override void Subquery_member_pushdown_does_not_change_original_subquery_\n                 Sql);\n         }\n \n+        public override void Query_expression_with_to_string_and_contains()\n+        {\n+            base.Query_expression_with_to_string_and_contains();\n+\n+            Assert.Equal(\n+                @\"SELECT [o].[CustomerID]\n+FROM [Orders] AS [o]\n+WHERE [o].[OrderDate] IS NOT NULL AND (CHARINDEX(N'10', CONVERT(VARCHAR(MAX), [o].[EmployeeID])) > 0)\",\n+                Sql);\n+        }\n+\n+\n+        public override void Select_expression_to_string()\n+        {\n+            base.Select_expression_to_string();\n+\n+            Assert.Equal(\n+                @\"SELECT CONVERT(VARCHAR(MAX), [o].[EmployeeID])","path":"test/Microsoft.EntityFrameworkCore.SqlServer.FunctionalTests/QuerySqlServerTest.cs","position":21,"original_position":21,"commit_id":"b4520fd8e217d9a6eca6db33c94aa81025e0b26b","original_commit_id":"b4520fd8e217d9a6eca6db33c94aa81025e0b26b","user":{"login":"anpete","id":1210944,"avatar_url":"https://avatars.githubusercontent.com/u/1210944?v=3","gravatar_id":"","url":"https://api.github.com/users/anpete","html_url":"https://github.com/anpete","followers_url":"https://api.github.com/users/anpete/followers","following_url":"https://api.github.com/users/anpete/following{/other_user}","gists_url":"https://api.github.com/users/anpete/gists{/gist_id}","starred_url":"https://api.github.com/users/anpete/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anpete/subscriptions","organizations_url":"https://api.github.com/users/anpete/orgs","repos_url":"https://api.github.com/users/anpete/repos","events_url":"https://api.github.com/users/anpete/events{/privacy}","received_events_url":"https://api.github.com/users/anpete/received_events","type":"User","site_admin":false},"body":"Does size matter here. I.e. for some expressions we know the column size from metadata.\r\n\r\ncc @divega ","created_at":"2016-10-31T17:42:37Z","updated_at":"2016-10-31T17:42:37Z","html_url":"https://github.com/aspnet/EntityFramework/pull/6908#discussion_r85792423","pull_request_url":"https://api.github.com/repos/aspnet/EntityFramework/pulls/6908","_links":{"self":{"href":"https://api.github.com/repos/aspnet/EntityFramework/pulls/comments/85792423"},"html":{"href":"https://github.com/aspnet/EntityFramework/pull/6908#discussion_r85792423"},"pull_request":{"href":"https://api.github.com/repos/aspnet/EntityFramework/pulls/6908"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/EntityFramework/pulls/6908","id":91627380,"html_url":"https://github.com/aspnet/EntityFramework/pull/6908","diff_url":"https://github.com/aspnet/EntityFramework/pull/6908.diff","patch_url":"https://github.com/aspnet/EntityFramework/pull/6908.patch","issue_url":"https://api.github.com/repos/aspnet/EntityFramework/issues/6908","number":6908,"state":"open","locked":false,"title":"feat(Translators): support for translating ToString() to sql server","user":{"login":"laskoviymishka","id":2754361,"avatar_url":"https://avatars.githubusercontent.com/u/2754361?v=3","gravatar_id":"","url":"https://api.github.com/users/laskoviymishka","html_url":"https://github.com/laskoviymishka","followers_url":"https://api.github.com/users/laskoviymishka/followers","following_url":"https://api.github.com/users/laskoviymishka/following{/other_user}","gists_url":"https://api.github.com/users/laskoviymishka/gists{/gist_id}","starred_url":"https://api.github.com/users/laskoviymishka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laskoviymishka/subscriptions","organizations_url":"https://api.github.com/users/laskoviymishka/orgs","repos_url":"https://api.github.com/users/laskoviymishka/repos","events_url":"https://api.github.com/users/laskoviymishka/events{/privacy}","received_events_url":"https://api.github.com/users/laskoviymishka/received_events","type":"User","site_admin":false},"body":"- [x] The code builds and tests pass (verified by our automated build checks)\r\n- [x] Commit messages follow this format\r\n- [x] Tests for the changes have been added (for bug fixes / features)\r\n- [x] Code meets the expectations our engineering guidelines. \r\n\r\n```\r\nAdd new translator for to string in sql server translators. Add corresponding tests\r\n```\r\n\r\nFixes #6264","created_at":"2016-10-31T15:14:27Z","updated_at":"2016-10-31T17:42:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0d288a880ea2de55715d5fd6494bbe1b4558a44","assignee":{"login":"anpete","id":1210944,"avatar_url":"https://avatars.githubusercontent.com/u/1210944?v=3","gravatar_id":"","url":"https://api.github.com/users/anpete","html_url":"https://github.com/anpete","followers_url":"https://api.github.com/users/anpete/followers","following_url":"https://api.github.com/users/anpete/following{/other_user}","gists_url":"https://api.github.com/users/anpete/gists{/gist_id}","starred_url":"https://api.github.com/users/anpete/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anpete/subscriptions","organizations_url":"https://api.github.com/users/anpete/orgs","repos_url":"https://api.github.com/users/anpete/repos","events_url":"https://api.github.com/users/anpete/events{/privacy}","received_events_url":"https://api.github.com/users/anpete/received_events","type":"User","site_admin":false},"assignees":[{"login":"anpete","id":1210944,"avatar_url":"https://avatars.githubusercontent.com/u/1210944?v=3","gravatar_id":"","url":"https://api.github.com/users/anpete","html_url":"https://github.com/anpete","followers_url":"https://api.github.com/users/anpete/followers","following_url":"https://api.github.com/users/anpete/following{/other_user}","gists_url":"https://api.github.com/users/anpete/gists{/gist_id}","starred_url":"https://api.github.com/users/anpete/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anpete/subscriptions","organizations_url":"https://api.github.com/users/anpete/orgs","repos_url":"https://api.github.com/users/anpete/repos","events_url":"https://api.github.com/users/anpete/events{/privacy}","received_events_url":"https://api.github.com/users/anpete/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/EntityFramework/pulls/6908/commits","review_comments_url":"https://api.github.com/repos/aspnet/EntityFramework/pulls/6908/comments","review_comment_url":"https://api.github.com/repos/aspnet/EntityFramework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/EntityFramework/issues/6908/comments","statuses_url":"https://api.github.com/repos/aspnet/EntityFramework/statuses/b4520fd8e217d9a6eca6db33c94aa81025e0b26b","head":{"label":"laskoviymishka:feature/toStringSql","ref":"feature/toStringSql","sha":"b4520fd8e217d9a6eca6db33c94aa81025e0b26b","user":{"login":"laskoviymishka","id":2754361,"avatar_url":"https://avatars.githubusercontent.com/u/2754361?v=3","gravatar_id":"","url":"https://api.github.com/users/laskoviymishka","html_url":"https://github.com/laskoviymishka","followers_url":"https://api.github.com/users/laskoviymishka/followers","following_url":"https://api.github.com/users/laskoviymishka/following{/other_user}","gists_url":"https://api.github.com/users/laskoviymishka/gists{/gist_id}","starred_url":"https://api.github.com/users/laskoviymishka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laskoviymishka/subscriptions","organizations_url":"https://api.github.com/users/laskoviymishka/orgs","repos_url":"https://api.github.com/users/laskoviymishka/repos","events_url":"https://api.github.com/users/laskoviymishka/events{/privacy}","received_events_url":"https://api.github.com/users/laskoviymishka/received_events","type":"User","site_admin":false},"repo":{"id":38584576,"name":"EntityFramework","full_name":"laskoviymishka/EntityFramework","owner":{"login":"laskoviymishka","id":2754361,"avatar_url":"https://avatars.githubusercontent.com/u/2754361?v=3","gravatar_id":"","url":"https://api.github.com/users/laskoviymishka","html_url":"https://github.com/laskoviymishka","followers_url":"https://api.github.com/users/laskoviymishka/followers","following_url":"https://api.github.com/users/laskoviymishka/following{/other_user}","gists_url":"https://api.github.com/users/laskoviymishka/gists{/gist_id}","starred_url":"https://api.github.com/users/laskoviymishka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laskoviymishka/subscriptions","organizations_url":"https://api.github.com/users/laskoviymishka/orgs","repos_url":"https://api.github.com/users/laskoviymishka/repos","events_url":"https://api.github.com/users/laskoviymishka/events{/privacy}","received_events_url":"https://api.github.com/users/laskoviymishka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/laskoviymishka/EntityFramework","description":"Microsoft's recommended data access technology for new applications in .NET.","fork":true,"url":"https://api.github.com/repos/laskoviymishka/EntityFramework","forks_url":"https://api.github.com/repos/laskoviymishka/EntityFramework/forks","keys_url":"https://api.github.com/repos/laskoviymishka/EntityFramework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laskoviymishka/EntityFramework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laskoviymishka/EntityFramework/teams","hooks_url":"https://api.github.com/repos/laskoviymishka/EntityFramework/hooks","issue_events_url":"https://api.github.com/repos/laskoviymishka/EntityFramework/issues/events{/number}","events_url":"https://api.github.com/repos/laskoviymishka/EntityFramework/events","assignees_url":"https://api.github.com/repos/laskoviymishka/EntityFramework/assignees{/user}","branches_url":"https://api.github.com/repos/laskoviymishka/EntityFramework/branches{/branch}","tags_url":"https://api.github.com/repos/laskoviymishka/EntityFramework/tags","blobs_url":"https://api.github.com/repos/laskoviymishka/EntityFramework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laskoviymishka/EntityFramework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laskoviymishka/EntityFramework/git/refs{/sha}","trees_url":"https://api.github.com/repos/laskoviymishka/EntityFramework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laskoviymishka/EntityFramework/statuses/{sha}","languages_url":"https://api.github.com/repos/laskoviymishka/EntityFramework/languages","stargazers_url":"https://api.github.com/repos/laskoviymishka/EntityFramework/stargazers","contributors_url":"https://api.github.com/repos/laskoviymishka/EntityFramework/contributors","subscribers_url":"https://api.github.com/repos/laskoviymishka/EntityFramework/subscribers","subscription_url":"https://api.github.com/repos/laskoviymishka/EntityFramework/subscription","commits_url":"https://api.github.com/repos/laskoviymishka/EntityFramework/commits{/sha}","git_commits_url":"https://api.github.com/repos/laskoviymishka/EntityFramework/git/commits{/sha}","comments_url":"https://api.github.com/repos/laskoviymishka/EntityFramework/comments{/number}","issue_comment_url":"https://api.github.com/repos/laskoviymishka/EntityFramework/issues/comments{/number}","contents_url":"https://api.github.com/repos/laskoviymishka/EntityFramework/contents/{+path}","compare_url":"https://api.github.com/repos/laskoviymishka/EntityFramework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laskoviymishka/EntityFramework/merges","archive_url":"https://api.github.com/repos/laskoviymishka/EntityFramework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laskoviymishka/EntityFramework/downloads","issues_url":"https://api.github.com/repos/laskoviymishka/EntityFramework/issues{/number}","pulls_url":"https://api.github.com/repos/laskoviymishka/EntityFramework/pulls{/number}","milestones_url":"https://api.github.com/repos/laskoviymishka/EntityFramework/milestones{/number}","notifications_url":"https://api.github.com/repos/laskoviymishka/EntityFramework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laskoviymishka/EntityFramework/labels{/name}","releases_url":"https://api.github.com/repos/laskoviymishka/EntityFramework/releases{/id}","deployments_url":"https://api.github.com/repos/laskoviymishka/EntityFramework/deployments","created_at":"2015-07-05T21:21:59Z","updated_at":"2016-03-11T10:04:07Z","pushed_at":"2016-10-31T15:13:11Z","git_url":"git://github.com/laskoviymishka/EntityFramework.git","ssh_url":"git@github.com:laskoviymishka/EntityFramework.git","clone_url":"https://github.com/laskoviymishka/EntityFramework.git","svn_url":"https://github.com/laskoviymishka/EntityFramework","homepage":"","size":41020,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"aspnet:feature/1.2.0","ref":"feature/1.2.0","sha":"bd3a6bb749a94f52fb51d6afe36a509cd9eb20f9","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":16157746,"name":"EntityFramework","full_name":"aspnet/EntityFramework","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/EntityFramework","description":"Entity Framework Core is a lightweight and extensible version of the popular Entity Framework data access technology","fork":false,"url":"https://api.github.com/repos/aspnet/EntityFramework","forks_url":"https://api.github.com/repos/aspnet/EntityFramework/forks","keys_url":"https://api.github.com/repos/aspnet/EntityFramework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/EntityFramework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/EntityFramework/teams","hooks_url":"https://api.github.com/repos/aspnet/EntityFramework/hooks","issue_events_url":"https://api.github.com/repos/aspnet/EntityFramework/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/EntityFramework/events","assignees_url":"https://api.github.com/repos/aspnet/EntityFramework/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/EntityFramework/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/EntityFramework/tags","blobs_url":"https://api.github.com/repos/aspnet/EntityFramework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/EntityFramework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/EntityFramework/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/EntityFramework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/EntityFramework/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/EntityFramework/languages","stargazers_url":"https://api.github.com/repos/aspnet/EntityFramework/stargazers","contributors_url":"https://api.github.com/repos/aspnet/EntityFramework/contributors","subscribers_url":"https://api.github.com/repos/aspnet/EntityFramework/subscribers","subscription_url":"https://api.github.com/repos/aspnet/EntityFramework/subscription","commits_url":"https://api.github.com/repos/aspnet/EntityFramework/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/EntityFramework/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/EntityFramework/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/EntityFramework/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/EntityFramework/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/EntityFramework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/EntityFramework/merges","archive_url":"https://api.github.com/repos/aspnet/EntityFramework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/EntityFramework/downloads","issues_url":"https://api.github.com/repos/aspnet/EntityFramework/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/EntityFramework/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/EntityFramework/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/EntityFramework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/EntityFramework/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/EntityFramework/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/EntityFramework/deployments","created_at":"2014-01-23T00:52:01Z","updated_at":"2016-10-31T08:49:43Z","pushed_at":"2016-10-31T15:14:27Z","git_url":"git://github.com/aspnet/EntityFramework.git","ssh_url":"git@github.com:aspnet/EntityFramework.git","clone_url":"https://github.com/aspnet/EntityFramework.git","svn_url":"https://github.com/aspnet/EntityFramework","homepage":"https://docs.efproject.net","size":60018,"stargazers_count":3865,"watchers_count":3865,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1147,"mirror_url":null,"open_issues_count":504,"forks":1147,"open_issues":504,"watchers":3865,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/EntityFramework/pulls/6908"},"html":{"href":"https://github.com/aspnet/EntityFramework/pull/6908"},"issue":{"href":"https://api.github.com/repos/aspnet/EntityFramework/issues/6908"},"comments":{"href":"https://api.github.com/repos/aspnet/EntityFramework/issues/6908/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/EntityFramework/pulls/6908/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/EntityFramework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/EntityFramework/pulls/6908/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/EntityFramework/statuses/b4520fd8e217d9a6eca6db33c94aa81025e0b26b"}}}}
{"actor":{"display_login":"anpete"}}