{"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/brew/pulls/comments/79311782","id":79311782,"diff_hunk":"@@ -1,3 +1,4 @@\n+#!/bin/bash","path":"etc/bash_completion.d/brew","position":null,"original_position":1,"commit_id":"12094fb16288b8753984bfd2d9a268c63b603e25","original_commit_id":"4331093fa9929ad206334dd390db2e1eac2b120a","user":{"login":"elyscape","id":792695,"avatar_url":"https://avatars.githubusercontent.com/u/792695?v=3","gravatar_id":"","url":"https://api.github.com/users/elyscape","html_url":"https://github.com/elyscape","followers_url":"https://api.github.com/users/elyscape/followers","following_url":"https://api.github.com/users/elyscape/following{/other_user}","gists_url":"https://api.github.com/users/elyscape/gists{/gist_id}","starred_url":"https://api.github.com/users/elyscape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elyscape/subscriptions","organizations_url":"https://api.github.com/users/elyscape/orgs","repos_url":"https://api.github.com/users/elyscape/repos","events_url":"https://api.github.com/users/elyscape/events{/privacy}","received_events_url":"https://api.github.com/users/elyscape/received_events","type":"User","site_admin":false},"body":"Fixed.","created_at":"2016-09-18T18:15:15Z","updated_at":"2016-09-18T18:15:15Z","html_url":"https://github.com/Homebrew/brew/pull/901#discussion_r79311782","pull_request_url":"https://api.github.com/repos/Homebrew/brew/pulls/901","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/comments/79311782"},"html":{"href":"https://github.com/Homebrew/brew/pull/901#discussion_r79311782"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/901"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/brew/pulls/901","id":84722683,"html_url":"https://github.com/Homebrew/brew/pull/901","diff_url":"https://github.com/Homebrew/brew/pull/901.diff","patch_url":"https://github.com/Homebrew/brew/pull/901.patch","issue_url":"https://api.github.com/repos/Homebrew/brew/issues/901","number":901,"state":"open","locked":false,"title":"completion: Avoid aliases with `command ls`","user":{"login":"elyscape","id":792695,"avatar_url":"https://avatars.githubusercontent.com/u/792695?v=3","gravatar_id":"","url":"https://api.github.com/users/elyscape","html_url":"https://github.com/elyscape","followers_url":"https://api.github.com/users/elyscape/followers","following_url":"https://api.github.com/users/elyscape/following{/other_user}","gists_url":"https://api.github.com/users/elyscape/gists{/gist_id}","starred_url":"https://api.github.com/users/elyscape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elyscape/subscriptions","organizations_url":"https://api.github.com/users/elyscape/orgs","repos_url":"https://api.github.com/users/elyscape/repos","events_url":"https://api.github.com/users/elyscape/events{/privacy}","received_events_url":"https://api.github.com/users/elyscape/received_events","type":"User","site_admin":false},"body":"- [x] Have you followed the guidelines in our [Contributing](https://github.com/Homebrew/brew/blob/master/.github/CONTRIBUTING.md) document?\r\n- [x] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/Homebrew/brew/pulls) for the same change?\r\n- [x] Have you added an explanation of what your changes do and why you'd like us to include them?\r\n- [ ] Have you written new tests for your changes? [Here's an example](https://github.com/Homebrew/homebrew/pull/49031).\r\n- [x] Have you successfully run `brew tests` with your changes locally?\r\n\r\nI haven't written new tests because there aren't really any tests for the bash completion. Additionally, when running `brew tests`, several tests fail with this error:\r\n```\r\ngit config --file=/tmp/homebrew-tests-20160909-38939-rk5nwv/prefix/.git/config --replace-all homebrew.devcmdrun true\r\nerror: could not lock config file /tmp/homebrew-tests-20160909-38939-rk5nwv/prefix/.git/config: No such file or directory\r\n```\r\nThe same tests fail without my changes, though. I'm not sure what that issue is.\r\n\r\n-----\r\n\r\nIf the user has an alias overriding the `ls` command that modifies the output (e.g. `alias ls='ls -F'`), it will cause unexpected characters to appear in completions. Using `command ls` forces the shell to use the command directly, without alias expansion.\r\n\r\nThis also blackholes the stderr of `ls` in the `__brew_complete_logs` function to avoid printing  errors during completion if the Homebrew logs directory does not exist.","created_at":"2016-09-09T21:32:42Z","updated_at":"2016-09-18T18:15:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"626f5dc7bcce0652dac8cfb4909496a3d0b1647e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/brew/pulls/901/commits","review_comments_url":"https://api.github.com/repos/Homebrew/brew/pulls/901/comments","review_comment_url":"https://api.github.com/repos/Homebrew/brew/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/brew/issues/901/comments","statuses_url":"https://api.github.com/repos/Homebrew/brew/statuses/12094fb16288b8753984bfd2d9a268c63b603e25","head":{"label":"elyscape:use-command-ls","ref":"use-command-ls","sha":"12094fb16288b8753984bfd2d9a268c63b603e25","user":{"login":"elyscape","id":792695,"avatar_url":"https://avatars.githubusercontent.com/u/792695?v=3","gravatar_id":"","url":"https://api.github.com/users/elyscape","html_url":"https://github.com/elyscape","followers_url":"https://api.github.com/users/elyscape/followers","following_url":"https://api.github.com/users/elyscape/following{/other_user}","gists_url":"https://api.github.com/users/elyscape/gists{/gist_id}","starred_url":"https://api.github.com/users/elyscape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elyscape/subscriptions","organizations_url":"https://api.github.com/users/elyscape/orgs","repos_url":"https://api.github.com/users/elyscape/repos","events_url":"https://api.github.com/users/elyscape/events{/privacy}","received_events_url":"https://api.github.com/users/elyscape/received_events","type":"User","site_admin":false},"repo":{"id":67832992,"name":"brew","full_name":"elyscape/brew","owner":{"login":"elyscape","id":792695,"avatar_url":"https://avatars.githubusercontent.com/u/792695?v=3","gravatar_id":"","url":"https://api.github.com/users/elyscape","html_url":"https://github.com/elyscape","followers_url":"https://api.github.com/users/elyscape/followers","following_url":"https://api.github.com/users/elyscape/following{/other_user}","gists_url":"https://api.github.com/users/elyscape/gists{/gist_id}","starred_url":"https://api.github.com/users/elyscape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elyscape/subscriptions","organizations_url":"https://api.github.com/users/elyscape/orgs","repos_url":"https://api.github.com/users/elyscape/repos","events_url":"https://api.github.com/users/elyscape/events{/privacy}","received_events_url":"https://api.github.com/users/elyscape/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/elyscape/brew","description":":beer: The missing package manager for OS X","fork":true,"url":"https://api.github.com/repos/elyscape/brew","forks_url":"https://api.github.com/repos/elyscape/brew/forks","keys_url":"https://api.github.com/repos/elyscape/brew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elyscape/brew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elyscape/brew/teams","hooks_url":"https://api.github.com/repos/elyscape/brew/hooks","issue_events_url":"https://api.github.com/repos/elyscape/brew/issues/events{/number}","events_url":"https://api.github.com/repos/elyscape/brew/events","assignees_url":"https://api.github.com/repos/elyscape/brew/assignees{/user}","branches_url":"https://api.github.com/repos/elyscape/brew/branches{/branch}","tags_url":"https://api.github.com/repos/elyscape/brew/tags","blobs_url":"https://api.github.com/repos/elyscape/brew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elyscape/brew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elyscape/brew/git/refs{/sha}","trees_url":"https://api.github.com/repos/elyscape/brew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elyscape/brew/statuses/{sha}","languages_url":"https://api.github.com/repos/elyscape/brew/languages","stargazers_url":"https://api.github.com/repos/elyscape/brew/stargazers","contributors_url":"https://api.github.com/repos/elyscape/brew/contributors","subscribers_url":"https://api.github.com/repos/elyscape/brew/subscribers","subscription_url":"https://api.github.com/repos/elyscape/brew/subscription","commits_url":"https://api.github.com/repos/elyscape/brew/commits{/sha}","git_commits_url":"https://api.github.com/repos/elyscape/brew/git/commits{/sha}","comments_url":"https://api.github.com/repos/elyscape/brew/comments{/number}","issue_comment_url":"https://api.github.com/repos/elyscape/brew/issues/comments{/number}","contents_url":"https://api.github.com/repos/elyscape/brew/contents/{+path}","compare_url":"https://api.github.com/repos/elyscape/brew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elyscape/brew/merges","archive_url":"https://api.github.com/repos/elyscape/brew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elyscape/brew/downloads","issues_url":"https://api.github.com/repos/elyscape/brew/issues{/number}","pulls_url":"https://api.github.com/repos/elyscape/brew/pulls{/number}","milestones_url":"https://api.github.com/repos/elyscape/brew/milestones{/number}","notifications_url":"https://api.github.com/repos/elyscape/brew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elyscape/brew/labels{/name}","releases_url":"https://api.github.com/repos/elyscape/brew/releases{/id}","deployments_url":"https://api.github.com/repos/elyscape/brew/deployments","created_at":"2016-09-09T21:11:02Z","updated_at":"2016-09-09T21:11:04Z","pushed_at":"2016-09-18T18:14:56Z","git_url":"git://github.com/elyscape/brew.git","ssh_url":"git@github.com:elyscape/brew.git","clone_url":"https://github.com/elyscape/brew.git","svn_url":"https://github.com/elyscape/brew","homepage":"http://brew.sh","size":16375,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"f4a8d28819f1fee73fcc63d08e70cb36eecdfb20","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":53238813,"name":"brew","full_name":"Homebrew/brew","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/brew","description":":beer: The missing package manager for OS X","fork":false,"url":"https://api.github.com/repos/Homebrew/brew","forks_url":"https://api.github.com/repos/Homebrew/brew/forks","keys_url":"https://api.github.com/repos/Homebrew/brew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/brew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/brew/teams","hooks_url":"https://api.github.com/repos/Homebrew/brew/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/brew/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/brew/events","assignees_url":"https://api.github.com/repos/Homebrew/brew/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/brew/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/brew/tags","blobs_url":"https://api.github.com/repos/Homebrew/brew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/brew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/brew/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/brew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/brew/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/brew/languages","stargazers_url":"https://api.github.com/repos/Homebrew/brew/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/brew/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/brew/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/brew/subscription","commits_url":"https://api.github.com/repos/Homebrew/brew/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/brew/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/brew/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/brew/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/brew/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/brew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/brew/merges","archive_url":"https://api.github.com/repos/Homebrew/brew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/brew/downloads","issues_url":"https://api.github.com/repos/Homebrew/brew/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/brew/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/brew/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/brew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/brew/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/brew/releases{/id}","deployments_url":"https://api.github.com/repos/Homebrew/brew/deployments","created_at":"2016-03-06T05:08:38Z","updated_at":"2016-09-18T16:01:16Z","pushed_at":"2016-09-18T18:14:57Z","git_url":"git://github.com/Homebrew/brew.git","ssh_url":"git@github.com:Homebrew/brew.git","clone_url":"https://github.com/Homebrew/brew.git","svn_url":"https://github.com/Homebrew/brew","homepage":"http://brew.sh","size":17303,"stargazers_count":3210,"watchers_count":3210,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":932,"mirror_url":null,"open_issues_count":59,"forks":932,"open_issues":59,"watchers":3210,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/901"},"html":{"href":"https://github.com/Homebrew/brew/pull/901"},"issue":{"href":"https://api.github.com/repos/Homebrew/brew/issues/901"},"comments":{"href":"https://api.github.com/repos/Homebrew/brew/issues/901/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/901/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/901/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/brew/statuses/12094fb16288b8753984bfd2d9a268c63b603e25"}}}}
{"actor":{"display_login":"elyscape"}}