{"action":"opened","issue":{"url":"https://api.github.com/repos/dj-wasabi/puppet-zabbix/issues/157","labels_url":"https://api.github.com/repos/dj-wasabi/puppet-zabbix/issues/157/labels{/name}","comments_url":"https://api.github.com/repos/dj-wasabi/puppet-zabbix/issues/157/comments","events_url":"https://api.github.com/repos/dj-wasabi/puppet-zabbix/issues/157/events","html_url":"https://github.com/dj-wasabi/puppet-zabbix/issues/157","id":130246161,"number":157,"title":"The puppetgem fact is incorrect for Puppet 4 AIO installation","user":{"login":"rnelson0","id":1898351,"avatar_url":"https://avatars.githubusercontent.com/u/1898351?v=3","gravatar_id":"","url":"https://api.github.com/users/rnelson0","html_url":"https://github.com/rnelson0","followers_url":"https://api.github.com/users/rnelson0/followers","following_url":"https://api.github.com/users/rnelson0/following{/other_user}","gists_url":"https://api.github.com/users/rnelson0/gists{/gist_id}","starred_url":"https://api.github.com/users/rnelson0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rnelson0/subscriptions","organizations_url":"https://api.github.com/users/rnelson0/orgs","repos_url":"https://api.github.com/users/rnelson0/repos","events_url":"https://api.github.com/users/rnelson0/events{/privacy}","received_events_url":"https://api.github.com/users/rnelson0/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-02-01T03:39:42Z","updated_at":"2016-02-01T03:39:42Z","closed_at":null,"body":"According to the puppetgem fact, the [presence of /etc/puppetlabs/puppet/puppet.conf](https://github.com/dj-wasabi/puppet-zabbix/blob/master/lib/facter/puppetgem.rb#L5-L6) indicates that `pe_gem` is the proper gem provider. In the Puppet 4 AIO installation, this file is present in the FOSS edition of puppet-agent.\r\n````\r\n[root@zabbix ~]# rpm -ql puppet-agent | grep /etc/puppetlabs/puppet/puppet.conf\r\n/etc/puppetlabs/puppet/puppet.conf\r\n[root@zabbix ~]# rpm -qi puppet-agent\r\nName        : puppet-agent\r\nVersion     : 1.3.2\r\nRelease     : 1.el7\r\nArchitecture: x86_64\r\nInstall Date: Thu 14 Jan 2016 01:04:44 PM UTC\r\nGroup       : System Environment/Base\r\nSize        : 102953686\r\nLicense     : See components\r\nSignature   : RSA/SHA1, Wed 02 Dec 2015 11:21:40 PM UTC, Key ID 1054b7a24bd6ec30\r\nSource RPM  : puppet-agent-1.3.2-1.el7.src.rpm\r\nBuild Date  : Wed 02 Dec 2015 07:31:43 PM UTC\r\nBuild Host  : pz30efh339jcnfe.delivery.puppetlabs.net\r\nRelocations : (not relocatable)\r\nVendor      : Puppet Labs\r\nURL         : https://www.puppetlabs.com\r\nSummary     : The Puppet Agent package contains all of the elements needed to run puppet, including ruby, facter, hiera and mcollective.\r\nDescription :\r\nThe Puppet Agent package contains all of the elements needed to run puppet, including ruby, facter, hiera and mcollective.\r\n````\r\nThe `puppetgem` fact needs to adjust for this and better detect the proper gem provider. I've looked at how other modules address this and it appears that few use facts and instead use some complicated if statements, such as in [hunner/hiera](https://github.com/hunner/puppet-hiera/blob/d594244af41e92811cf0f04eacddc74e22856c74/manifests/params.pp#L18-L51), since there doesn't seem to be a reliable fact for this or a stdlib function."}}