{"action":"closed","number":484,"pull_request":{"url":"https://api.github.com/repos/google/oauth2client/pulls/484","id":65557952,"html_url":"https://github.com/google/oauth2client/pull/484","diff_url":"https://github.com/google/oauth2client/pull/484.diff","patch_url":"https://github.com/google/oauth2client/pull/484.patch","issue_url":"https://api.github.com/repos/google/oauth2client/issues/484","number":484,"state":"closed","locked":false,"title":"Clarify control flow in LockedFile constructor","user":{"login":"nathanielmanistaatgoogle","id":10131044,"avatar_url":"https://avatars.githubusercontent.com/u/10131044?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanielmanistaatgoogle","html_url":"https://github.com/nathanielmanistaatgoogle","followers_url":"https://api.github.com/users/nathanielmanistaatgoogle/followers","following_url":"https://api.github.com/users/nathanielmanistaatgoogle/following{/other_user}","gists_url":"https://api.github.com/users/nathanielmanistaatgoogle/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanielmanistaatgoogle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanielmanistaatgoogle/subscriptions","organizations_url":"https://api.github.com/users/nathanielmanistaatgoogle/orgs","repos_url":"https://api.github.com/users/nathanielmanistaatgoogle/repos","events_url":"https://api.github.com/users/nathanielmanistaatgoogle/events{/privacy}","received_events_url":"https://api.github.com/users/nathanielmanistaatgoogle/received_events","type":"User","site_admin":false},"body":"Eliminate the unnecessary local field \"opener\" and ensure that\r\nself._opener is assigned exactly once along every trajectory through\r\nthe constructor body.\r\n\r\nI don't believe the `not opener` on line 349 of the old implementation could ever have been false, and if `_Win32Opener` and `_FcntlOpener` were both non-None then for calls with `use_native_locking` true the old implementation would have constructed an object just to throw it away. Right?","created_at":"2016-04-07T00:36:16Z","updated_at":"2016-07-25T16:48:40Z","closed_at":"2016-07-25T16:48:40Z","merged_at":null,"merge_commit_sha":"150b42665ef87c02087fe169c02e5a3b6fa6257a","assignee":{"login":"jonparrott","id":250995,"avatar_url":"https://avatars.githubusercontent.com/u/250995?v=3","gravatar_id":"","url":"https://api.github.com/users/jonparrott","html_url":"https://github.com/jonparrott","followers_url":"https://api.github.com/users/jonparrott/followers","following_url":"https://api.github.com/users/jonparrott/following{/other_user}","gists_url":"https://api.github.com/users/jonparrott/gists{/gist_id}","starred_url":"https://api.github.com/users/jonparrott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonparrott/subscriptions","organizations_url":"https://api.github.com/users/jonparrott/orgs","repos_url":"https://api.github.com/users/jonparrott/repos","events_url":"https://api.github.com/users/jonparrott/events{/privacy}","received_events_url":"https://api.github.com/users/jonparrott/received_events","type":"User","site_admin":false},"assignees":[{"login":"jonparrott","id":250995,"avatar_url":"https://avatars.githubusercontent.com/u/250995?v=3","gravatar_id":"","url":"https://api.github.com/users/jonparrott","html_url":"https://github.com/jonparrott","followers_url":"https://api.github.com/users/jonparrott/followers","following_url":"https://api.github.com/users/jonparrott/following{/other_user}","gists_url":"https://api.github.com/users/jonparrott/gists{/gist_id}","starred_url":"https://api.github.com/users/jonparrott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonparrott/subscriptions","organizations_url":"https://api.github.com/users/jonparrott/orgs","repos_url":"https://api.github.com/users/jonparrott/repos","events_url":"https://api.github.com/users/jonparrott/events{/privacy}","received_events_url":"https://api.github.com/users/jonparrott/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/google/oauth2client/pulls/484/commits","review_comments_url":"https://api.github.com/repos/google/oauth2client/pulls/484/comments","review_comment_url":"https://api.github.com/repos/google/oauth2client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/oauth2client/issues/484/comments","statuses_url":"https://api.github.com/repos/google/oauth2client/statuses/8e9ba71c30e7fa819ff35b34dc840816d1cfaab7","head":{"label":"nathanielmanistaatgoogle:locked-file-constructor","ref":"locked-file-constructor","sha":"8e9ba71c30e7fa819ff35b34dc840816d1cfaab7","user":{"login":"nathanielmanistaatgoogle","id":10131044,"avatar_url":"https://avatars.githubusercontent.com/u/10131044?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanielmanistaatgoogle","html_url":"https://github.com/nathanielmanistaatgoogle","followers_url":"https://api.github.com/users/nathanielmanistaatgoogle/followers","following_url":"https://api.github.com/users/nathanielmanistaatgoogle/following{/other_user}","gists_url":"https://api.github.com/users/nathanielmanistaatgoogle/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanielmanistaatgoogle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanielmanistaatgoogle/subscriptions","organizations_url":"https://api.github.com/users/nathanielmanistaatgoogle/orgs","repos_url":"https://api.github.com/users/nathanielmanistaatgoogle/repos","events_url":"https://api.github.com/users/nathanielmanistaatgoogle/events{/privacy}","received_events_url":"https://api.github.com/users/nathanielmanistaatgoogle/received_events","type":"User","site_admin":false},"repo":{"id":29361194,"name":"oauth2client","full_name":"nathanielmanistaatgoogle/oauth2client","owner":{"login":"nathanielmanistaatgoogle","id":10131044,"avatar_url":"https://avatars.githubusercontent.com/u/10131044?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanielmanistaatgoogle","html_url":"https://github.com/nathanielmanistaatgoogle","followers_url":"https://api.github.com/users/nathanielmanistaatgoogle/followers","following_url":"https://api.github.com/users/nathanielmanistaatgoogle/following{/other_user}","gists_url":"https://api.github.com/users/nathanielmanistaatgoogle/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanielmanistaatgoogle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanielmanistaatgoogle/subscriptions","organizations_url":"https://api.github.com/users/nathanielmanistaatgoogle/orgs","repos_url":"https://api.github.com/users/nathanielmanistaatgoogle/repos","events_url":"https://api.github.com/users/nathanielmanistaatgoogle/events{/privacy}","received_events_url":"https://api.github.com/users/nathanielmanistaatgoogle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nathanielmanistaatgoogle/oauth2client","description":"This is a python library for accessing resources protected by OAuth 2.0.","fork":true,"url":"https://api.github.com/repos/nathanielmanistaatgoogle/oauth2client","forks_url":"https://api.github.com/repos/nathanielmanistaatgoogle/oauth2client/forks","keys_url":"https://api.github.com/repos/nathanielmanistaatgoogle/oauth2client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nathanielmanistaatgoogle/oauth2client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nathanielmanistaatgoogle/oauth2client/teams","hooks_url":"https://api.github.com/repos/nathanielmanistaatgoogle/oauth2client/hooks","issue_events_url":"https://api.github.com/repos/nathanielmanistaatgoogle/oauth2client/issues/events{/number}","events_url":"https://api.github.com/repos/nathanielmanistaatgoogle/oauth2client/events","assignees_url":"https://api.github.com/repos/nathanielmanistaatgoogle/oauth2client/assignees{/user}","branches_url":"https://api.github.com/repos/nathanielmanistaatgoogle/oauth2client/branches{/branch}","tags_url":"https://api.github.com/repos/nathanielmanistaatgoogle/oauth2client/tags","blobs_url":"https://api.github.com/repos/nathanielmanistaatgoogle/oauth2client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nathanielmanistaatgoogle/oauth2client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nathanielmanistaatgoogle/oauth2client/git/refs{/sha}","trees_url":"https://api.github.com/repos/nathanielmanistaatgoogle/oauth2client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nathanielmanistaatgoogle/oauth2client/statuses/{sha}","languages_url":"https://api.github.com/repos/nathanielmanistaatgoogle/oauth2client/languages","stargazers_url":"https://api.github.com/repos/nathanielmanistaatgoogle/oauth2client/stargazers","contributors_url":"https://api.github.com/repos/nathanielmanistaatgoogle/oauth2client/contributors","subscribers_url":"https://api.github.com/repos/nathanielmanistaatgoogle/oauth2client/subscribers","subscription_url":"https://api.github.com/repos/nathanielmanistaatgoogle/oauth2client/subscription","commits_url":"https://api.github.com/repos/nathanielmanistaatgoogle/oauth2client/commits{/sha}","git_commits_url":"https://api.github.com/repos/nathanielmanistaatgoogle/oauth2client/git/commits{/sha}","comments_url":"https://api.github.com/repos/nathanielmanistaatgoogle/oauth2client/comments{/number}","issue_comment_url":"https://api.github.com/repos/nathanielmanistaatgoogle/oauth2client/issues/comments{/number}","contents_url":"https://api.github.com/repos/nathanielmanistaatgoogle/oauth2client/contents/{+path}","compare_url":"https://api.github.com/repos/nathanielmanistaatgoogle/oauth2client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nathanielmanistaatgoogle/oauth2client/merges","archive_url":"https://api.github.com/repos/nathanielmanistaatgoogle/oauth2client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nathanielmanistaatgoogle/oauth2client/downloads","issues_url":"https://api.github.com/repos/nathanielmanistaatgoogle/oauth2client/issues{/number}","pulls_url":"https://api.github.com/repos/nathanielmanistaatgoogle/oauth2client/pulls{/number}","milestones_url":"https://api.github.com/repos/nathanielmanistaatgoogle/oauth2client/milestones{/number}","notifications_url":"https://api.github.com/repos/nathanielmanistaatgoogle/oauth2client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nathanielmanistaatgoogle/oauth2client/labels{/name}","releases_url":"https://api.github.com/repos/nathanielmanistaatgoogle/oauth2client/releases{/id}","deployments_url":"https://api.github.com/repos/nathanielmanistaatgoogle/oauth2client/deployments","created_at":"2015-01-16T18:13:51Z","updated_at":"2015-01-16T19:29:17Z","pushed_at":"2016-07-19T02:40:39Z","git_url":"git://github.com/nathanielmanistaatgoogle/oauth2client.git","ssh_url":"git@github.com:nathanielmanistaatgoogle/oauth2client.git","clone_url":"https://github.com/nathanielmanistaatgoogle/oauth2client.git","svn_url":"https://github.com/nathanielmanistaatgoogle/oauth2client","homepage":"","size":22543,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"cbe633059b8157303ba9cb826f815f1c35cb7364","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":14211461,"name":"oauth2client","full_name":"google/oauth2client","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/oauth2client","description":"This is a Python library for accessing resources protected by OAuth 2.0.","fork":false,"url":"https://api.github.com/repos/google/oauth2client","forks_url":"https://api.github.com/repos/google/oauth2client/forks","keys_url":"https://api.github.com/repos/google/oauth2client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/oauth2client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/oauth2client/teams","hooks_url":"https://api.github.com/repos/google/oauth2client/hooks","issue_events_url":"https://api.github.com/repos/google/oauth2client/issues/events{/number}","events_url":"https://api.github.com/repos/google/oauth2client/events","assignees_url":"https://api.github.com/repos/google/oauth2client/assignees{/user}","branches_url":"https://api.github.com/repos/google/oauth2client/branches{/branch}","tags_url":"https://api.github.com/repos/google/oauth2client/tags","blobs_url":"https://api.github.com/repos/google/oauth2client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/oauth2client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/oauth2client/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/oauth2client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/oauth2client/statuses/{sha}","languages_url":"https://api.github.com/repos/google/oauth2client/languages","stargazers_url":"https://api.github.com/repos/google/oauth2client/stargazers","contributors_url":"https://api.github.com/repos/google/oauth2client/contributors","subscribers_url":"https://api.github.com/repos/google/oauth2client/subscribers","subscription_url":"https://api.github.com/repos/google/oauth2client/subscription","commits_url":"https://api.github.com/repos/google/oauth2client/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/oauth2client/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/oauth2client/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/oauth2client/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/oauth2client/contents/{+path}","compare_url":"https://api.github.com/repos/google/oauth2client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/oauth2client/merges","archive_url":"https://api.github.com/repos/google/oauth2client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/oauth2client/downloads","issues_url":"https://api.github.com/repos/google/oauth2client/issues{/number}","pulls_url":"https://api.github.com/repos/google/oauth2client/pulls{/number}","milestones_url":"https://api.github.com/repos/google/oauth2client/milestones{/number}","notifications_url":"https://api.github.com/repos/google/oauth2client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/oauth2client/labels{/name}","releases_url":"https://api.github.com/repos/google/oauth2client/releases{/id}","deployments_url":"https://api.github.com/repos/google/oauth2client/deployments","created_at":"2013-11-07T18:03:04Z","updated_at":"2016-07-25T07:12:40Z","pushed_at":"2016-07-25T16:44:43Z","git_url":"git://github.com/google/oauth2client.git","ssh_url":"git@github.com:google/oauth2client.git","clone_url":"https://github.com/google/oauth2client.git","svn_url":"https://github.com/google/oauth2client","homepage":"","size":24736,"stargazers_count":398,"watchers_count":398,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":210,"mirror_url":null,"open_issues_count":88,"forks":210,"open_issues":88,"watchers":398,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/oauth2client/pulls/484"},"html":{"href":"https://github.com/google/oauth2client/pull/484"},"issue":{"href":"https://api.github.com/repos/google/oauth2client/issues/484"},"comments":{"href":"https://api.github.com/repos/google/oauth2client/issues/484/comments"},"review_comments":{"href":"https://api.github.com/repos/google/oauth2client/pulls/484/comments"},"review_comment":{"href":"https://api.github.com/repos/google/oauth2client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/oauth2client/pulls/484/commits"},"statuses":{"href":"https://api.github.com/repos/google/oauth2client/statuses/8e9ba71c30e7fa819ff35b34dc840816d1cfaab7"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":4,"review_comments":0,"commits":1,"additions":9,"deletions":10,"changed_files":2}}
{"actor":{"display_login":"jonparrott"}}