{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/73418800","id":73418800,"diff_hunk":"@@ -139,6 +139,27 @@ func IsDNS1035Label(value string) []string {\n \treturn errs\n }\n \n+// wildcard definition - RFC 1034 section 4.3.3.\n+// examples:\n+// - valid: *.bar.com, *.foo.bar.com\n+// - invalid: *.*.bar.com, *.foo.*.com, *bar.com, f*.bar.com, *\n+const wildcardDNF1123SubdomainFmt = \"\\\\*\\\\.\" + dns1123SubdomainFmt\n+\n+// IsWildcardDNS1123Subdomain tests for a string that conforms to the definition of a\n+// wildcard subdomain in DNS (RFC 1034 section 4.3.3).\n+func IsWildcardDNS1123Subdomain(value string) []string {\n+\twildcardDNS1123SubdomainRegexp := regexp.MustCompile(\"^\\\\*\\\\.\" + dns1123SubdomainFmt + \"$\")","path":"pkg/util/validation/validation.go","position":13,"original_position":13,"commit_id":"52073a5838f2f3c0b4f20391657a058ec113ce8c","original_commit_id":"52073a5838f2f3c0b4f20391657a058ec113ce8c","user":{"login":"bprashanth","id":10927820,"avatar_url":"https://avatars.githubusercontent.com/u/10927820?v=3","gravatar_id":"","url":"https://api.github.com/users/bprashanth","html_url":"https://github.com/bprashanth","followers_url":"https://api.github.com/users/bprashanth/followers","following_url":"https://api.github.com/users/bprashanth/following{/other_user}","gists_url":"https://api.github.com/users/bprashanth/gists{/gist_id}","starred_url":"https://api.github.com/users/bprashanth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bprashanth/subscriptions","organizations_url":"https://api.github.com/users/bprashanth/orgs","repos_url":"https://api.github.com/users/bprashanth/repos","events_url":"https://api.github.com/users/bprashanth/events{/privacy}","received_events_url":"https://api.github.com/users/bprashanth/received_events","type":"User","site_admin":false},"body":"was looking at the wrong rfc, yeah f*.com is invalid. ","created_at":"2016-08-03T20:54:14Z","updated_at":"2016-08-03T20:54:14Z","html_url":"https://github.com/kubernetes/kubernetes/pull/29204#discussion_r73418800","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/29204","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/73418800"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/29204#discussion_r73418800"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/29204"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/29204","id":77994230,"html_url":"https://github.com/kubernetes/kubernetes/pull/29204","diff_url":"https://github.com/kubernetes/kubernetes/pull/29204.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/29204.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/29204","number":29204,"state":"open","locked":false,"title":"Allow leading * in ingress hostname","user":{"login":"aledbf","id":161571,"avatar_url":"https://avatars.githubusercontent.com/u/161571?v=3","gravatar_id":"","url":"https://api.github.com/users/aledbf","html_url":"https://github.com/aledbf","followers_url":"https://api.github.com/users/aledbf/followers","following_url":"https://api.github.com/users/aledbf/following{/other_user}","gists_url":"https://api.github.com/users/aledbf/gists{/gist_id}","starred_url":"https://api.github.com/users/aledbf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledbf/subscriptions","organizations_url":"https://api.github.com/users/aledbf/orgs","repos_url":"https://api.github.com/users/aledbf/repos","events_url":"https://api.github.com/users/aledbf/events{/privacy}","received_events_url":"https://api.github.com/users/aledbf/received_events","type":"User","site_admin":false},"body":"fixes #29043","created_at":"2016-07-19T15:11:02Z","updated_at":"2016-08-03T20:54:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3cd4a9cab2ab6f6033a5495500e3bf002f9b1b96","assignee":{"login":"bprashanth","id":10927820,"avatar_url":"https://avatars.githubusercontent.com/u/10927820?v=3","gravatar_id":"","url":"https://api.github.com/users/bprashanth","html_url":"https://github.com/bprashanth","followers_url":"https://api.github.com/users/bprashanth/followers","following_url":"https://api.github.com/users/bprashanth/following{/other_user}","gists_url":"https://api.github.com/users/bprashanth/gists{/gist_id}","starred_url":"https://api.github.com/users/bprashanth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bprashanth/subscriptions","organizations_url":"https://api.github.com/users/bprashanth/orgs","repos_url":"https://api.github.com/users/bprashanth/repos","events_url":"https://api.github.com/users/bprashanth/events{/privacy}","received_events_url":"https://api.github.com/users/bprashanth/received_events","type":"User","site_admin":false},"assignees":[{"login":"bprashanth","id":10927820,"avatar_url":"https://avatars.githubusercontent.com/u/10927820?v=3","gravatar_id":"","url":"https://api.github.com/users/bprashanth","html_url":"https://github.com/bprashanth","followers_url":"https://api.github.com/users/bprashanth/followers","following_url":"https://api.github.com/users/bprashanth/following{/other_user}","gists_url":"https://api.github.com/users/bprashanth/gists{/gist_id}","starred_url":"https://api.github.com/users/bprashanth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bprashanth/subscriptions","organizations_url":"https://api.github.com/users/bprashanth/orgs","repos_url":"https://api.github.com/users/bprashanth/repos","events_url":"https://api.github.com/users/bprashanth/events{/privacy}","received_events_url":"https://api.github.com/users/bprashanth/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/29204/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/29204/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/29204/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/52073a5838f2f3c0b4f20391657a058ec113ce8c","head":{"label":"aledbf:ingress-wildcard-hosts","ref":"ingress-wildcard-hosts","sha":"52073a5838f2f3c0b4f20391657a058ec113ce8c","user":{"login":"aledbf","id":161571,"avatar_url":"https://avatars.githubusercontent.com/u/161571?v=3","gravatar_id":"","url":"https://api.github.com/users/aledbf","html_url":"https://github.com/aledbf","followers_url":"https://api.github.com/users/aledbf/followers","following_url":"https://api.github.com/users/aledbf/following{/other_user}","gists_url":"https://api.github.com/users/aledbf/gists{/gist_id}","starred_url":"https://api.github.com/users/aledbf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledbf/subscriptions","organizations_url":"https://api.github.com/users/aledbf/orgs","repos_url":"https://api.github.com/users/aledbf/repos","events_url":"https://api.github.com/users/aledbf/events{/privacy}","received_events_url":"https://api.github.com/users/aledbf/received_events","type":"User","site_admin":false},"repo":{"id":37000342,"name":"kubernetes","full_name":"aledbf/kubernetes","owner":{"login":"aledbf","id":161571,"avatar_url":"https://avatars.githubusercontent.com/u/161571?v=3","gravatar_id":"","url":"https://api.github.com/users/aledbf","html_url":"https://github.com/aledbf","followers_url":"https://api.github.com/users/aledbf/followers","following_url":"https://api.github.com/users/aledbf/following{/other_user}","gists_url":"https://api.github.com/users/aledbf/gists{/gist_id}","starred_url":"https://api.github.com/users/aledbf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledbf/subscriptions","organizations_url":"https://api.github.com/users/aledbf/orgs","repos_url":"https://api.github.com/users/aledbf/repos","events_url":"https://api.github.com/users/aledbf/events{/privacy}","received_events_url":"https://api.github.com/users/aledbf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aledbf/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/aledbf/kubernetes","forks_url":"https://api.github.com/repos/aledbf/kubernetes/forks","keys_url":"https://api.github.com/repos/aledbf/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aledbf/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aledbf/kubernetes/teams","hooks_url":"https://api.github.com/repos/aledbf/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/aledbf/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/aledbf/kubernetes/events","assignees_url":"https://api.github.com/repos/aledbf/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/aledbf/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/aledbf/kubernetes/tags","blobs_url":"https://api.github.com/repos/aledbf/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aledbf/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aledbf/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/aledbf/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aledbf/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/aledbf/kubernetes/languages","stargazers_url":"https://api.github.com/repos/aledbf/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/aledbf/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/aledbf/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/aledbf/kubernetes/subscription","commits_url":"https://api.github.com/repos/aledbf/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/aledbf/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/aledbf/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/aledbf/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/aledbf/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/aledbf/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aledbf/kubernetes/merges","archive_url":"https://api.github.com/repos/aledbf/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aledbf/kubernetes/downloads","issues_url":"https://api.github.com/repos/aledbf/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/aledbf/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/aledbf/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/aledbf/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aledbf/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/aledbf/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/aledbf/kubernetes/deployments","created_at":"2015-06-07T01:18:27Z","updated_at":"2016-01-19T15:17:19Z","pushed_at":"2016-08-03T19:39:29Z","git_url":"git://github.com/aledbf/kubernetes.git","ssh_url":"git@github.com:aledbf/kubernetes.git","clone_url":"https://github.com/aledbf/kubernetes.git","svn_url":"https://github.com/aledbf/kubernetes","homepage":"http://kubernetes.io","size":297606,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"6b523ce6db8baf739cdd96c6e8791da6654d476a","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-08-03T17:50:18Z","pushed_at":"2016-08-03T20:46:25Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":513312,"stargazers_count":15934,"watchers_count":15934,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5044,"mirror_url":null,"open_issues_count":4103,"forks":5044,"open_issues":4103,"watchers":15934,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/29204"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/29204"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/29204"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/29204/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/29204/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/29204/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/52073a5838f2f3c0b4f20391657a058ec113ce8c"}}}}
{"actor":{"display_login":"bprashanth"}}