{"action":"created","comment":{"url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/pulls/comments/82111674","pull_request_review_id":3040765,"id":82111674,"diff_hunk":"@@ -55,17 +56,21 @@ func main() {\n \n \tlocation := os.Args[1]\n \n-\tclient := boshio.NewClient(progress.NewBar(), content.NewRanger(routines))\n+\tclient := boshio.NewClient(progress.NewBar(), content.NewRanger(routines), inRequest.Source.ForceRegular)\n \n \tstemcells, err := client.GetStemcells(inRequest.Source.Name)\n \tif err != nil {\n \t\tlog.Fatalln(err)\n \t}\n \n-\tstemcell, err := client.FilterStemcells(inRequest.Version.Version, stemcells)\n-\tif err != nil {\n-\t\tlog.Fatalln(err)\n+\tfilterFunc := func(stemcell boshio.Stemcell) bool {\n+\t\treturn stemcell.Version == inRequest.Version.Version\n+\t}","path":"cmd/in/main.go","position":27,"original_position":27,"commit_id":"e7cf7cd5c557002ca9b40dab66fecd4ab5d5d3d8","original_commit_id":"e7cf7cd5c557002ca9b40dab66fecd4ab5d5d3d8","user":{"login":"zachgersh","id":689411,"avatar_url":"https://avatars.githubusercontent.com/u/689411?v=3","gravatar_id":"","url":"https://api.github.com/users/zachgersh","html_url":"https://github.com/zachgersh","followers_url":"https://api.github.com/users/zachgersh/followers","following_url":"https://api.github.com/users/zachgersh/following{/other_user}","gists_url":"https://api.github.com/users/zachgersh/gists{/gist_id}","starred_url":"https://api.github.com/users/zachgersh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zachgersh/subscriptions","organizations_url":"https://api.github.com/users/zachgersh/orgs","repos_url":"https://api.github.com/users/zachgersh/repos","events_url":"https://api.github.com/users/zachgersh/events{/privacy}","received_events_url":"https://api.github.com/users/zachgersh/received_events","type":"User","site_admin":false},"body":"Again, I'd love to figure out how to push this logic down into the `FIlterStemcell` function itself instead of it living in main.","created_at":"2016-10-06T03:26:42Z","updated_at":"2016-10-06T03:30:09Z","html_url":"https://github.com/concourse/bosh-io-stemcell-resource/pull/12#discussion_r82111674","pull_request_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/pulls/comments/82111674"},"html":{"href":"https://github.com/concourse/bosh-io-stemcell-resource/pull/12#discussion_r82111674"},"pull_request":{"href":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/pulls/12","id":86253418,"html_url":"https://github.com/concourse/bosh-io-stemcell-resource/pull/12","diff_url":"https://github.com/concourse/bosh-io-stemcell-resource/pull/12.diff","patch_url":"https://github.com/concourse/bosh-io-stemcell-resource/pull/12.patch","issue_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/issues/12","number":12,"state":"open","locked":false,"title":"Add `force_regular` property and fine-tune light vs regular behavior","user":{"login":"ljfranklin","id":1923644,"avatar_url":"https://avatars.githubusercontent.com/u/1923644?v=3","gravatar_id":"","url":"https://api.github.com/users/ljfranklin","html_url":"https://github.com/ljfranklin","followers_url":"https://api.github.com/users/ljfranklin/followers","following_url":"https://api.github.com/users/ljfranklin/following{/other_user}","gists_url":"https://api.github.com/users/ljfranklin/gists{/gist_id}","starred_url":"https://api.github.com/users/ljfranklin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljfranklin/subscriptions","organizations_url":"https://api.github.com/users/ljfranklin/orgs","repos_url":"https://api.github.com/users/ljfranklin/repos","events_url":"https://api.github.com/users/ljfranklin/events{/privacy}","received_events_url":"https://api.github.com/users/ljfranklin/received_events","type":"User","site_admin":false},"body":"- If `force_regular` is true (default false), the resource will only check/get\r\n  stemcells with that have a regular (i.e. heavy) stemcell URL\r\n- Handles timing issues in stemcell publishing process where a heavy stemcell appears on\r\n  bosh.io before the corresponding light stemcell\r\n  - Unless `force_regular` is true, `check` will now ignore new versions that only have a regular\r\n    stemcell and will only trigger once the light version appears for IaaSes that support light stemcells\r\n  - It would be bad on AWS if Concourse triggered on a heavy stemcell instead of waiting for the light\r\n    stemcell\r\n\r\n[#129544375](https://www.pivotaltracker.com/story/show/129544375)","created_at":"2016-09-21T22:33:27Z","updated_at":"2016-10-06T03:30:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1d11e9c1c073bf3fa1d61d3bd6a9cc76f25091ed","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/pulls/12/commits","review_comments_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/pulls/12/comments","review_comment_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/pulls/comments{/number}","comments_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/issues/12/comments","statuses_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/statuses/e7cf7cd5c557002ca9b40dab66fecd4ab5d5d3d8","head":{"label":"ljfranklin:PR-add-force-regular","ref":"PR-add-force-regular","sha":"e7cf7cd5c557002ca9b40dab66fecd4ab5d5d3d8","user":{"login":"ljfranklin","id":1923644,"avatar_url":"https://avatars.githubusercontent.com/u/1923644?v=3","gravatar_id":"","url":"https://api.github.com/users/ljfranklin","html_url":"https://github.com/ljfranklin","followers_url":"https://api.github.com/users/ljfranklin/followers","following_url":"https://api.github.com/users/ljfranklin/following{/other_user}","gists_url":"https://api.github.com/users/ljfranklin/gists{/gist_id}","starred_url":"https://api.github.com/users/ljfranklin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljfranklin/subscriptions","organizations_url":"https://api.github.com/users/ljfranklin/orgs","repos_url":"https://api.github.com/users/ljfranklin/repos","events_url":"https://api.github.com/users/ljfranklin/events{/privacy}","received_events_url":"https://api.github.com/users/ljfranklin/received_events","type":"User","site_admin":false},"repo":{"id":65832340,"name":"bosh-io-stemcell-resource","full_name":"ljfranklin/bosh-io-stemcell-resource","owner":{"login":"ljfranklin","id":1923644,"avatar_url":"https://avatars.githubusercontent.com/u/1923644?v=3","gravatar_id":"","url":"https://api.github.com/users/ljfranklin","html_url":"https://github.com/ljfranklin","followers_url":"https://api.github.com/users/ljfranklin/followers","following_url":"https://api.github.com/users/ljfranklin/following{/other_user}","gists_url":"https://api.github.com/users/ljfranklin/gists{/gist_id}","starred_url":"https://api.github.com/users/ljfranklin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljfranklin/subscriptions","organizations_url":"https://api.github.com/users/ljfranklin/orgs","repos_url":"https://api.github.com/users/ljfranklin/repos","events_url":"https://api.github.com/users/ljfranklin/events{/privacy}","received_events_url":"https://api.github.com/users/ljfranklin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ljfranklin/bosh-io-stemcell-resource","description":"tracks BOSH stemcells published on https://bosh.io","fork":true,"url":"https://api.github.com/repos/ljfranklin/bosh-io-stemcell-resource","forks_url":"https://api.github.com/repos/ljfranklin/bosh-io-stemcell-resource/forks","keys_url":"https://api.github.com/repos/ljfranklin/bosh-io-stemcell-resource/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ljfranklin/bosh-io-stemcell-resource/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ljfranklin/bosh-io-stemcell-resource/teams","hooks_url":"https://api.github.com/repos/ljfranklin/bosh-io-stemcell-resource/hooks","issue_events_url":"https://api.github.com/repos/ljfranklin/bosh-io-stemcell-resource/issues/events{/number}","events_url":"https://api.github.com/repos/ljfranklin/bosh-io-stemcell-resource/events","assignees_url":"https://api.github.com/repos/ljfranklin/bosh-io-stemcell-resource/assignees{/user}","branches_url":"https://api.github.com/repos/ljfranklin/bosh-io-stemcell-resource/branches{/branch}","tags_url":"https://api.github.com/repos/ljfranklin/bosh-io-stemcell-resource/tags","blobs_url":"https://api.github.com/repos/ljfranklin/bosh-io-stemcell-resource/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ljfranklin/bosh-io-stemcell-resource/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ljfranklin/bosh-io-stemcell-resource/git/refs{/sha}","trees_url":"https://api.github.com/repos/ljfranklin/bosh-io-stemcell-resource/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ljfranklin/bosh-io-stemcell-resource/statuses/{sha}","languages_url":"https://api.github.com/repos/ljfranklin/bosh-io-stemcell-resource/languages","stargazers_url":"https://api.github.com/repos/ljfranklin/bosh-io-stemcell-resource/stargazers","contributors_url":"https://api.github.com/repos/ljfranklin/bosh-io-stemcell-resource/contributors","subscribers_url":"https://api.github.com/repos/ljfranklin/bosh-io-stemcell-resource/subscribers","subscription_url":"https://api.github.com/repos/ljfranklin/bosh-io-stemcell-resource/subscription","commits_url":"https://api.github.com/repos/ljfranklin/bosh-io-stemcell-resource/commits{/sha}","git_commits_url":"https://api.github.com/repos/ljfranklin/bosh-io-stemcell-resource/git/commits{/sha}","comments_url":"https://api.github.com/repos/ljfranklin/bosh-io-stemcell-resource/comments{/number}","issue_comment_url":"https://api.github.com/repos/ljfranklin/bosh-io-stemcell-resource/issues/comments{/number}","contents_url":"https://api.github.com/repos/ljfranklin/bosh-io-stemcell-resource/contents/{+path}","compare_url":"https://api.github.com/repos/ljfranklin/bosh-io-stemcell-resource/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ljfranklin/bosh-io-stemcell-resource/merges","archive_url":"https://api.github.com/repos/ljfranklin/bosh-io-stemcell-resource/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ljfranklin/bosh-io-stemcell-resource/downloads","issues_url":"https://api.github.com/repos/ljfranklin/bosh-io-stemcell-resource/issues{/number}","pulls_url":"https://api.github.com/repos/ljfranklin/bosh-io-stemcell-resource/pulls{/number}","milestones_url":"https://api.github.com/repos/ljfranklin/bosh-io-stemcell-resource/milestones{/number}","notifications_url":"https://api.github.com/repos/ljfranklin/bosh-io-stemcell-resource/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ljfranklin/bosh-io-stemcell-resource/labels{/name}","releases_url":"https://api.github.com/repos/ljfranklin/bosh-io-stemcell-resource/releases{/id}","deployments_url":"https://api.github.com/repos/ljfranklin/bosh-io-stemcell-resource/deployments","created_at":"2016-08-16T15:38:38Z","updated_at":"2016-08-16T15:38:40Z","pushed_at":"2016-09-21T22:32:43Z","git_url":"git://github.com/ljfranklin/bosh-io-stemcell-resource.git","ssh_url":"git@github.com:ljfranklin/bosh-io-stemcell-resource.git","clone_url":"https://github.com/ljfranklin/bosh-io-stemcell-resource.git","svn_url":"https://github.com/ljfranklin/bosh-io-stemcell-resource","homepage":"","size":829,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"concourse:master","ref":"master","sha":"300c0962779c22df3322a8f7562053a81a0b6998","user":{"login":"concourse","id":7809479,"avatar_url":"https://avatars.githubusercontent.com/u/7809479?v=3","gravatar_id":"","url":"https://api.github.com/users/concourse","html_url":"https://github.com/concourse","followers_url":"https://api.github.com/users/concourse/followers","following_url":"https://api.github.com/users/concourse/following{/other_user}","gists_url":"https://api.github.com/users/concourse/gists{/gist_id}","starred_url":"https://api.github.com/users/concourse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concourse/subscriptions","organizations_url":"https://api.github.com/users/concourse/orgs","repos_url":"https://api.github.com/users/concourse/repos","events_url":"https://api.github.com/users/concourse/events{/privacy}","received_events_url":"https://api.github.com/users/concourse/received_events","type":"Organization","site_admin":false},"repo":{"id":33003241,"name":"bosh-io-stemcell-resource","full_name":"concourse/bosh-io-stemcell-resource","owner":{"login":"concourse","id":7809479,"avatar_url":"https://avatars.githubusercontent.com/u/7809479?v=3","gravatar_id":"","url":"https://api.github.com/users/concourse","html_url":"https://github.com/concourse","followers_url":"https://api.github.com/users/concourse/followers","following_url":"https://api.github.com/users/concourse/following{/other_user}","gists_url":"https://api.github.com/users/concourse/gists{/gist_id}","starred_url":"https://api.github.com/users/concourse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concourse/subscriptions","organizations_url":"https://api.github.com/users/concourse/orgs","repos_url":"https://api.github.com/users/concourse/repos","events_url":"https://api.github.com/users/concourse/events{/privacy}","received_events_url":"https://api.github.com/users/concourse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/concourse/bosh-io-stemcell-resource","description":"tracks BOSH stemcells published on https://bosh.io","fork":false,"url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource","forks_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/forks","keys_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/keys{/key_id}","collaborators_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/teams","hooks_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/hooks","issue_events_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/issues/events{/number}","events_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/events","assignees_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/assignees{/user}","branches_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/branches{/branch}","tags_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/tags","blobs_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/git/refs{/sha}","trees_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/git/trees{/sha}","statuses_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/statuses/{sha}","languages_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/languages","stargazers_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/stargazers","contributors_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/contributors","subscribers_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/subscribers","subscription_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/subscription","commits_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/commits{/sha}","git_commits_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/git/commits{/sha}","comments_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/comments{/number}","issue_comment_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/issues/comments{/number}","contents_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/contents/{+path}","compare_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/compare/{base}...{head}","merges_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/merges","archive_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/downloads","issues_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/issues{/number}","pulls_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/pulls{/number}","milestones_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/milestones{/number}","notifications_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/labels{/name}","releases_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/releases{/id}","deployments_url":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/deployments","created_at":"2015-03-27T18:44:28Z","updated_at":"2016-09-20T18:35:56Z","pushed_at":"2016-09-23T23:11:03Z","git_url":"git://github.com/concourse/bosh-io-stemcell-resource.git","ssh_url":"git@github.com:concourse/bosh-io-stemcell-resource.git","clone_url":"https://github.com/concourse/bosh-io-stemcell-resource.git","svn_url":"https://github.com/concourse/bosh-io-stemcell-resource","homepage":"","size":844,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":2,"forks":8,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/pulls/12"},"html":{"href":"https://github.com/concourse/bosh-io-stemcell-resource/pull/12"},"issue":{"href":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/issues/12"},"comments":{"href":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/concourse/bosh-io-stemcell-resource/statuses/e7cf7cd5c557002ca9b40dab66fecd4ab5d5d3d8"}}}}
{"actor":{"display_login":"zachgersh"}}