{"action":"created","comment":{"url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/comments/51579270","id":51579270,"diff_hunk":"@@ -305,7 +305,7 @@ def __init__( self, **kwargs ):\n             self.use_tool_dependencies = True\n         else:\n             self.tool_dependency_dir = None\n-            self.use_tool_dependencies = False\n+            self.use_tool_dependencies = os.path.exists(self.dependency_resolvers_config_file)","path":"lib/galaxy/config.py","position":5,"original_position":5,"commit_id":"afc5f2a45399c474d86f1530a62afe280a0eb3be","original_commit_id":"afc5f2a45399c474d86f1530a62afe280a0eb3be","user":{"login":"jmchilton","id":216771,"avatar_url":"https://avatars.githubusercontent.com/u/216771?v=3","gravatar_id":"","url":"https://api.github.com/users/jmchilton","html_url":"https://github.com/jmchilton","followers_url":"https://api.github.com/users/jmchilton/followers","following_url":"https://api.github.com/users/jmchilton/following{/other_user}","gists_url":"https://api.github.com/users/jmchilton/gists{/gist_id}","starred_url":"https://api.github.com/users/jmchilton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmchilton/subscriptions","organizations_url":"https://api.github.com/users/jmchilton/orgs","repos_url":"https://api.github.com/users/jmchilton/repos","events_url":"https://api.github.com/users/jmchilton/events{/privacy}","received_events_url":"https://api.github.com/users/jmchilton/received_events","type":"User","site_admin":false},"body":"```\r\n         if 'tool_dependency_dir' in kwargs:\r\n             self.tool_dependency_dir = resolve_path( kwargs.get( \"tool_dependency_dir\" ), self.root )\r\n             # Setting the following flag to true will ultimately cause tool dependencies\r\n             # to be located in the shell environment and used by the job that is executing\r\n             # the tool.\r\n             self.use_tool_dependencies = True\r\n         else:\r\n             self.tool_dependency_dir = None\r\n-            self.use_tool_dependencies = False\r\n+            self.use_tool_dependencies = os.path.exists(self.dependency_resolvers_config_file)\r\n```\r\n\r\n@nsoranzo This is all in the ``tool_dependency_dir`` not set ``else`` block. If ``tool_dependency_dir`` is set ``use_tool_dependencies`` will always be ``True`` still.","created_at":"2016-02-02T15:02:47Z","updated_at":"2016-02-02T15:02:47Z","html_url":"https://github.com/galaxyproject/galaxy/pull/1648#discussion_r51579270","pull_request_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/1648","_links":{"self":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/comments/51579270"},"html":{"href":"https://github.com/galaxyproject/galaxy/pull/1648#discussion_r51579270"},"pull_request":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/1648"}}},"pull_request":{"url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/1648","id":57989958,"html_url":"https://github.com/galaxyproject/galaxy/pull/1648","diff_url":"https://github.com/galaxyproject/galaxy/pull/1648.diff","patch_url":"https://github.com/galaxyproject/galaxy/pull/1648.patch","issue_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/1648","number":1648,"state":"open","locked":false,"title":"[16.01] Fix use_tool_dependencies for non-default dependency_resolver_conf files.","user":{"login":"jmchilton","id":216771,"avatar_url":"https://avatars.githubusercontent.com/u/216771?v=3","gravatar_id":"","url":"https://api.github.com/users/jmchilton","html_url":"https://github.com/jmchilton","followers_url":"https://api.github.com/users/jmchilton/followers","following_url":"https://api.github.com/users/jmchilton/following{/other_user}","gists_url":"https://api.github.com/users/jmchilton/gists{/gist_id}","starred_url":"https://api.github.com/users/jmchilton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmchilton/subscriptions","organizations_url":"https://api.github.com/users/jmchilton/orgs","repos_url":"https://api.github.com/users/jmchilton/repos","events_url":"https://api.github.com/users/jmchilton/events{/privacy}","received_events_url":"https://api.github.com/users/jmchilton/received_events","type":"User","site_admin":false},"body":"This way resolvers like the module resolver work even if tool_dependency_dir is not set.\r\n\r\nPing @pvanheus.","created_at":"2016-02-02T13:59:05Z","updated_at":"2016-02-02T15:02:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"287074ae65578c44ff8df9ef69d82aaf93624d17","assignee":null,"milestone":{"url":"https://api.github.com/repos/galaxyproject/galaxy/milestones/1","html_url":"https://github.com/galaxyproject/galaxy/milestones/16.01","labels_url":"https://api.github.com/repos/galaxyproject/galaxy/milestones/1/labels","id":1340720,"number":1,"title":"16.01","description":"Tentative freeze date for 16.01","creator":{"login":"erasche","id":458683,"avatar_url":"https://avatars.githubusercontent.com/u/458683?v=3","gravatar_id":"","url":"https://api.github.com/users/erasche","html_url":"https://github.com/erasche","followers_url":"https://api.github.com/users/erasche/followers","following_url":"https://api.github.com/users/erasche/following{/other_user}","gists_url":"https://api.github.com/users/erasche/gists{/gist_id}","starred_url":"https://api.github.com/users/erasche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erasche/subscriptions","organizations_url":"https://api.github.com/users/erasche/orgs","repos_url":"https://api.github.com/users/erasche/repos","events_url":"https://api.github.com/users/erasche/events{/privacy}","received_events_url":"https://api.github.com/users/erasche/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":340,"state":"open","created_at":"2015-10-06T16:36:51Z","updated_at":"2016-02-02T13:59:05Z","due_on":"2016-01-05T06:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/1648/commits","review_comments_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/1648/comments","review_comment_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/1648/comments","statuses_url":"https://api.github.com/repos/galaxyproject/galaxy/statuses/afc5f2a45399c474d86f1530a62afe280a0eb3be","head":{"label":"jmchilton:dependencies_conf","ref":"dependencies_conf","sha":"afc5f2a45399c474d86f1530a62afe280a0eb3be","user":{"login":"jmchilton","id":216771,"avatar_url":"https://avatars.githubusercontent.com/u/216771?v=3","gravatar_id":"","url":"https://api.github.com/users/jmchilton","html_url":"https://github.com/jmchilton","followers_url":"https://api.github.com/users/jmchilton/followers","following_url":"https://api.github.com/users/jmchilton/following{/other_user}","gists_url":"https://api.github.com/users/jmchilton/gists{/gist_id}","starred_url":"https://api.github.com/users/jmchilton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmchilton/subscriptions","organizations_url":"https://api.github.com/users/jmchilton/orgs","repos_url":"https://api.github.com/users/jmchilton/repos","events_url":"https://api.github.com/users/jmchilton/events{/privacy}","received_events_url":"https://api.github.com/users/jmchilton/received_events","type":"User","site_admin":false},"repo":{"id":31215230,"name":"galaxy","full_name":"jmchilton/galaxy","owner":{"login":"jmchilton","id":216771,"avatar_url":"https://avatars.githubusercontent.com/u/216771?v=3","gravatar_id":"","url":"https://api.github.com/users/jmchilton","html_url":"https://github.com/jmchilton","followers_url":"https://api.github.com/users/jmchilton/followers","following_url":"https://api.github.com/users/jmchilton/following{/other_user}","gists_url":"https://api.github.com/users/jmchilton/gists{/gist_id}","starred_url":"https://api.github.com/users/jmchilton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmchilton/subscriptions","organizations_url":"https://api.github.com/users/jmchilton/orgs","repos_url":"https://api.github.com/users/jmchilton/repos","events_url":"https://api.github.com/users/jmchilton/events{/privacy}","received_events_url":"https://api.github.com/users/jmchilton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmchilton/galaxy","description":"Galaxy Github repository BETA 2. May be destroyed and recreated if additional post-conversion problems are found (but post-conversion commits on this repo will be reapplied to any recreations). Full details:","fork":true,"url":"https://api.github.com/repos/jmchilton/galaxy","forks_url":"https://api.github.com/repos/jmchilton/galaxy/forks","keys_url":"https://api.github.com/repos/jmchilton/galaxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmchilton/galaxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmchilton/galaxy/teams","hooks_url":"https://api.github.com/repos/jmchilton/galaxy/hooks","issue_events_url":"https://api.github.com/repos/jmchilton/galaxy/issues/events{/number}","events_url":"https://api.github.com/repos/jmchilton/galaxy/events","assignees_url":"https://api.github.com/repos/jmchilton/galaxy/assignees{/user}","branches_url":"https://api.github.com/repos/jmchilton/galaxy/branches{/branch}","tags_url":"https://api.github.com/repos/jmchilton/galaxy/tags","blobs_url":"https://api.github.com/repos/jmchilton/galaxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmchilton/galaxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmchilton/galaxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmchilton/galaxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmchilton/galaxy/statuses/{sha}","languages_url":"https://api.github.com/repos/jmchilton/galaxy/languages","stargazers_url":"https://api.github.com/repos/jmchilton/galaxy/stargazers","contributors_url":"https://api.github.com/repos/jmchilton/galaxy/contributors","subscribers_url":"https://api.github.com/repos/jmchilton/galaxy/subscribers","subscription_url":"https://api.github.com/repos/jmchilton/galaxy/subscription","commits_url":"https://api.github.com/repos/jmchilton/galaxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmchilton/galaxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmchilton/galaxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmchilton/galaxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmchilton/galaxy/contents/{+path}","compare_url":"https://api.github.com/repos/jmchilton/galaxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmchilton/galaxy/merges","archive_url":"https://api.github.com/repos/jmchilton/galaxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmchilton/galaxy/downloads","issues_url":"https://api.github.com/repos/jmchilton/galaxy/issues{/number}","pulls_url":"https://api.github.com/repos/jmchilton/galaxy/pulls{/number}","milestones_url":"https://api.github.com/repos/jmchilton/galaxy/milestones{/number}","notifications_url":"https://api.github.com/repos/jmchilton/galaxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmchilton/galaxy/labels{/name}","releases_url":"https://api.github.com/repos/jmchilton/galaxy/releases{/id}","deployments_url":"https://api.github.com/repos/jmchilton/galaxy/deployments","created_at":"2015-02-23T15:54:52Z","updated_at":"2016-01-26T19:53:09Z","pushed_at":"2016-02-02T13:57:15Z","git_url":"git://github.com/jmchilton/galaxy.git","ssh_url":"git@github.com:jmchilton/galaxy.git","clone_url":"https://github.com/jmchilton/galaxy.git","svn_url":"https://github.com/jmchilton/galaxy","homepage":"https://trello.com/c/iiSBweRQ","size":96444,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":28,"forks":0,"open_issues":28,"watchers":3,"default_branch":"dev"}},"base":{"label":"galaxyproject:release_16.01","ref":"release_16.01","sha":"9170865dfbe0f8588ec47449e683236e5ba92a39","user":{"login":"galaxyproject","id":7937847,"avatar_url":"https://avatars.githubusercontent.com/u/7937847?v=3","gravatar_id":"","url":"https://api.github.com/users/galaxyproject","html_url":"https://github.com/galaxyproject","followers_url":"https://api.github.com/users/galaxyproject/followers","following_url":"https://api.github.com/users/galaxyproject/following{/other_user}","gists_url":"https://api.github.com/users/galaxyproject/gists{/gist_id}","starred_url":"https://api.github.com/users/galaxyproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galaxyproject/subscriptions","organizations_url":"https://api.github.com/users/galaxyproject/orgs","repos_url":"https://api.github.com/users/galaxyproject/repos","events_url":"https://api.github.com/users/galaxyproject/events{/privacy}","received_events_url":"https://api.github.com/users/galaxyproject/received_events","type":"Organization","site_admin":false},"repo":{"id":31211061,"name":"galaxy","full_name":"galaxyproject/galaxy","owner":{"login":"galaxyproject","id":7937847,"avatar_url":"https://avatars.githubusercontent.com/u/7937847?v=3","gravatar_id":"","url":"https://api.github.com/users/galaxyproject","html_url":"https://github.com/galaxyproject","followers_url":"https://api.github.com/users/galaxyproject/followers","following_url":"https://api.github.com/users/galaxyproject/following{/other_user}","gists_url":"https://api.github.com/users/galaxyproject/gists{/gist_id}","starred_url":"https://api.github.com/users/galaxyproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galaxyproject/subscriptions","organizations_url":"https://api.github.com/users/galaxyproject/orgs","repos_url":"https://api.github.com/users/galaxyproject/repos","events_url":"https://api.github.com/users/galaxyproject/events{/privacy}","received_events_url":"https://api.github.com/users/galaxyproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/galaxyproject/galaxy","description":"Data intensive science for everyone.","fork":false,"url":"https://api.github.com/repos/galaxyproject/galaxy","forks_url":"https://api.github.com/repos/galaxyproject/galaxy/forks","keys_url":"https://api.github.com/repos/galaxyproject/galaxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/galaxyproject/galaxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/galaxyproject/galaxy/teams","hooks_url":"https://api.github.com/repos/galaxyproject/galaxy/hooks","issue_events_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/events{/number}","events_url":"https://api.github.com/repos/galaxyproject/galaxy/events","assignees_url":"https://api.github.com/repos/galaxyproject/galaxy/assignees{/user}","branches_url":"https://api.github.com/repos/galaxyproject/galaxy/branches{/branch}","tags_url":"https://api.github.com/repos/galaxyproject/galaxy/tags","blobs_url":"https://api.github.com/repos/galaxyproject/galaxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/galaxyproject/galaxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/galaxyproject/galaxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/galaxyproject/galaxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/galaxyproject/galaxy/statuses/{sha}","languages_url":"https://api.github.com/repos/galaxyproject/galaxy/languages","stargazers_url":"https://api.github.com/repos/galaxyproject/galaxy/stargazers","contributors_url":"https://api.github.com/repos/galaxyproject/galaxy/contributors","subscribers_url":"https://api.github.com/repos/galaxyproject/galaxy/subscribers","subscription_url":"https://api.github.com/repos/galaxyproject/galaxy/subscription","commits_url":"https://api.github.com/repos/galaxyproject/galaxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/galaxyproject/galaxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/galaxyproject/galaxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/galaxyproject/galaxy/contents/{+path}","compare_url":"https://api.github.com/repos/galaxyproject/galaxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/galaxyproject/galaxy/merges","archive_url":"https://api.github.com/repos/galaxyproject/galaxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/galaxyproject/galaxy/downloads","issues_url":"https://api.github.com/repos/galaxyproject/galaxy/issues{/number}","pulls_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls{/number}","milestones_url":"https://api.github.com/repos/galaxyproject/galaxy/milestones{/number}","notifications_url":"https://api.github.com/repos/galaxyproject/galaxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/galaxyproject/galaxy/labels{/name}","releases_url":"https://api.github.com/repos/galaxyproject/galaxy/releases{/id}","deployments_url":"https://api.github.com/repos/galaxyproject/galaxy/deployments","created_at":"2015-02-23T14:18:06Z","updated_at":"2016-02-02T07:19:51Z","pushed_at":"2016-02-02T14:47:21Z","git_url":"git://github.com/galaxyproject/galaxy.git","ssh_url":"git@github.com:galaxyproject/galaxy.git","clone_url":"https://github.com/galaxyproject/galaxy.git","svn_url":"https://github.com/galaxyproject/galaxy","homepage":"https://galaxyproject.org/","size":110181,"stargazers_count":109,"watchers_count":109,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":162,"mirror_url":null,"open_issues_count":273,"forks":162,"open_issues":273,"watchers":109,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/1648"},"html":{"href":"https://github.com/galaxyproject/galaxy/pull/1648"},"issue":{"href":"https://api.github.com/repos/galaxyproject/galaxy/issues/1648"},"comments":{"href":"https://api.github.com/repos/galaxyproject/galaxy/issues/1648/comments"},"review_comments":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/1648/comments"},"review_comment":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/1648/commits"},"statuses":{"href":"https://api.github.com/repos/galaxyproject/galaxy/statuses/afc5f2a45399c474d86f1530a62afe280a0eb3be"}}}}