{"action":"created","comment":{"url":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/comments/65121717","id":65121717,"diff_hunk":"@@ -0,0 +1,396 @@\n+#!/usr/bin/env python\n+\n+# Copyright 2016  Vimal Manohar\n+# Apache 2.0\n+\n+from __future__ import print_function\n+import sys, operator, argparse\n+\n+# Append to the CTM the Levenshtein alignment of 'hypothesis' and 'reference':\n+# (i.e. the output of 'align-text' post-processed by 'wer_per_utt_details.pl')\n+\n+# The tags in the processed Levenshtein alignment are:\n+#  'C' = correct\n+#  'S' = substitution\n+#  'D' = deletion\n+#  'I' = insertion\n+#  'EC' = silence and neighboring words are both correct","path":"egs/wsj/s5/steps/cleanup/append_eval_to_ctm.py","position":17,"original_position":17,"commit_id":"b523f9d63f1a28d24e4a59eff59c6abec472147a","original_commit_id":"b523f9d63f1a28d24e4a59eff59c6abec472147a","user":{"login":"danpovey","id":3298747,"avatar_url":"https://avatars.githubusercontent.com/u/3298747?v=3","gravatar_id":"","url":"https://api.github.com/users/danpovey","html_url":"https://github.com/danpovey","followers_url":"https://api.github.com/users/danpovey/followers","following_url":"https://api.github.com/users/danpovey/following{/other_user}","gists_url":"https://api.github.com/users/danpovey/gists{/gist_id}","starred_url":"https://api.github.com/users/danpovey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danpovey/subscriptions","organizations_url":"https://api.github.com/users/danpovey/orgs","repos_url":"https://api.github.com/users/danpovey/repos","events_url":"https://api.github.com/users/danpovey/events{/privacy}","received_events_url":"https://api.github.com/users/danpovey/received_events","type":"User","site_admin":false},"body":"> > +# Copyright 2016 Vimal Manohar\n>\n> > +# Apache 2.0\n> > +\n> > +from __future__ import print_function\n> > +import sys, operator, argparse\n> > +\n> > +# Append to the CTM the Levenshtein alignment of 'hypothesis' and 'reference':\n> > +# (i.e. the output of 'align-text' post-processed by 'wer_per_utt_details.pl')\n> > +\n> > +# The tags in the processed Levenshtein alignment are:\n> > +#  'C' = correct\n> > +#  'S' = substitution\n> > +#  'D' = deletion\n> > +#  'I' = insertion\n> > +#  'EC' = silence and neighboring words are both correct\n>\n> I don't understand the naming convention here, why E?\n>\n> I believe E was because silence was represented as <eps> in the CTM.\n>\n\nIt might be better to use 'S' as the prefix for silence-- this would be\nmore obvious to readers.\nYour documentation says that the script \"Append[s] to the CTM the\nLevenshtein alignment of 'hypothesis' and 'reference'\".\nThis would seem to be inconsistent with the notion that it's adding new CTM\nlines corresponding to deletions.  Be precise!\n\nYou should explain at this point what the precedence is among the types of\n> error. For instance, del sil sub, what tag does that put on the silence?\n>\n> This is explained in the comments above the later functions. But I can add\n> a line here.\n>\nThis comment is like an interface-level documentation (if this were a\nheader file).  Having documentation inside the implementation does not\nremove the obligation to have documentation of the interface.  If some\nparts would take too long to explain you can refer to other parts of the\ncode.\n\n\n> What does it mean for a neighboring word to be a deletion, given that a\n> deletion does not appear in a transcript? You might need to develop more\n> precise language for this (or explain further below). Does you add extra\n> lines to the CTM for deletions? Does 'silence' mean any phone that is in\n> phones/silence.txt, or just the optional silence?\n>\n> Deletion is found from using align-text information. A silence token <eps>\n> is marked as a deletion if there is a silence present or otherwise a\n> silence token of length 0 is added to the CTM. In the final processed CTM\n> with 'ED', 'EI' etc. an ED will always be next to a D.\n>\nI think you need to distinguish between silence tokens that represent\nactual silence, and <eps> which is a placeholder used in alignments.  I\ndon't think you should be referring to the <eps> that arise from the\nalignment, as 'silence' in any context-- that's not at all what they mean.\n\nWe do under some circumtances use <eps> as the word label for silences in\nthe ctm where there is no corresponding label in the graph, but I don't\nthink it's a good idea to confuse these with the <eps> tokens that arise\nfrom the alignment.\n\nMaking this distinction may require some non-cosmetic changes to the script.\n\nIs it really necessary to add this information at this point, given that\n> much of it is easy to work out from the CTM?\n>\n> It simplifies later segmentation script. Some things like handling\n> deletions are more complicated.\n>\n> Be clear about what you mean by an OOV-- presumably a reference word that\n> does not appear in words.txt. Try to be explicit what you mean about\n> 'words' here (e.g. in 'neighboring words'), given that there are two word\n> sequences involved.\n>\n> —\n> You are receiving this because you commented.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/kaldi-asr/kaldi/pull/777/files/b523f9d63f1a28d24e4a59eff59c6abec472147a#r65121245>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe/ADJVu4qfDFNdFOFSi24pvOHn1MpEW5PTks5qG7I7gaJpZM4IeUC0>\n> .\n>\n","created_at":"2016-05-31T04:11:55Z","updated_at":"2016-05-31T04:11:55Z","html_url":"https://github.com/kaldi-asr/kaldi/pull/777#discussion_r65121717","pull_request_url":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/777","_links":{"self":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/comments/65121717"},"html":{"href":"https://github.com/kaldi-asr/kaldi/pull/777#discussion_r65121717"},"pull_request":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/777"}}},"pull_request":{"url":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/777","id":70046251,"html_url":"https://github.com/kaldi-asr/kaldi/pull/777","diff_url":"https://github.com/kaldi-asr/kaldi/pull/777.diff","patch_url":"https://github.com/kaldi-asr/kaldi/pull/777.patch","issue_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/777","number":777,"state":"open","locked":false,"title":"WIP: Data cleanup","user":{"login":"vimalmanohar","id":4199255,"avatar_url":"https://avatars.githubusercontent.com/u/4199255?v=3","gravatar_id":"","url":"https://api.github.com/users/vimalmanohar","html_url":"https://github.com/vimalmanohar","followers_url":"https://api.github.com/users/vimalmanohar/followers","following_url":"https://api.github.com/users/vimalmanohar/following{/other_user}","gists_url":"https://api.github.com/users/vimalmanohar/gists{/gist_id}","starred_url":"https://api.github.com/users/vimalmanohar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vimalmanohar/subscriptions","organizations_url":"https://api.github.com/users/vimalmanohar/orgs","repos_url":"https://api.github.com/users/vimalmanohar/repos","events_url":"https://api.github.com/users/vimalmanohar/events{/privacy}","received_events_url":"https://api.github.com/users/vimalmanohar/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-05-13T19:28:45Z","updated_at":"2016-05-31T04:11:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81ec65e4185fd39a841fcf92d2c0fae16740326c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/777/commits","review_comments_url":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/777/comments","review_comment_url":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/777/comments","statuses_url":"https://api.github.com/repos/kaldi-asr/kaldi/statuses/b523f9d63f1a28d24e4a59eff59c6abec472147a","head":{"label":"vimalmanohar:cleanup","ref":"cleanup","sha":"b523f9d63f1a28d24e4a59eff59c6abec472147a","user":{"login":"vimalmanohar","id":4199255,"avatar_url":"https://avatars.githubusercontent.com/u/4199255?v=3","gravatar_id":"","url":"https://api.github.com/users/vimalmanohar","html_url":"https://github.com/vimalmanohar","followers_url":"https://api.github.com/users/vimalmanohar/followers","following_url":"https://api.github.com/users/vimalmanohar/following{/other_user}","gists_url":"https://api.github.com/users/vimalmanohar/gists{/gist_id}","starred_url":"https://api.github.com/users/vimalmanohar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vimalmanohar/subscriptions","organizations_url":"https://api.github.com/users/vimalmanohar/orgs","repos_url":"https://api.github.com/users/vimalmanohar/repos","events_url":"https://api.github.com/users/vimalmanohar/events{/privacy}","received_events_url":"https://api.github.com/users/vimalmanohar/received_events","type":"User","site_admin":false},"repo":{"id":39757201,"name":"kaldi","full_name":"vimalmanohar/kaldi","owner":{"login":"vimalmanohar","id":4199255,"avatar_url":"https://avatars.githubusercontent.com/u/4199255?v=3","gravatar_id":"","url":"https://api.github.com/users/vimalmanohar","html_url":"https://github.com/vimalmanohar","followers_url":"https://api.github.com/users/vimalmanohar/followers","following_url":"https://api.github.com/users/vimalmanohar/following{/other_user}","gists_url":"https://api.github.com/users/vimalmanohar/gists{/gist_id}","starred_url":"https://api.github.com/users/vimalmanohar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vimalmanohar/subscriptions","organizations_url":"https://api.github.com/users/vimalmanohar/orgs","repos_url":"https://api.github.com/users/vimalmanohar/repos","events_url":"https://api.github.com/users/vimalmanohar/events{/privacy}","received_events_url":"https://api.github.com/users/vimalmanohar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vimalmanohar/kaldi","description":"This is now the official location of the Kaldi project.","fork":true,"url":"https://api.github.com/repos/vimalmanohar/kaldi","forks_url":"https://api.github.com/repos/vimalmanohar/kaldi/forks","keys_url":"https://api.github.com/repos/vimalmanohar/kaldi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vimalmanohar/kaldi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vimalmanohar/kaldi/teams","hooks_url":"https://api.github.com/repos/vimalmanohar/kaldi/hooks","issue_events_url":"https://api.github.com/repos/vimalmanohar/kaldi/issues/events{/number}","events_url":"https://api.github.com/repos/vimalmanohar/kaldi/events","assignees_url":"https://api.github.com/repos/vimalmanohar/kaldi/assignees{/user}","branches_url":"https://api.github.com/repos/vimalmanohar/kaldi/branches{/branch}","tags_url":"https://api.github.com/repos/vimalmanohar/kaldi/tags","blobs_url":"https://api.github.com/repos/vimalmanohar/kaldi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vimalmanohar/kaldi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vimalmanohar/kaldi/git/refs{/sha}","trees_url":"https://api.github.com/repos/vimalmanohar/kaldi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vimalmanohar/kaldi/statuses/{sha}","languages_url":"https://api.github.com/repos/vimalmanohar/kaldi/languages","stargazers_url":"https://api.github.com/repos/vimalmanohar/kaldi/stargazers","contributors_url":"https://api.github.com/repos/vimalmanohar/kaldi/contributors","subscribers_url":"https://api.github.com/repos/vimalmanohar/kaldi/subscribers","subscription_url":"https://api.github.com/repos/vimalmanohar/kaldi/subscription","commits_url":"https://api.github.com/repos/vimalmanohar/kaldi/commits{/sha}","git_commits_url":"https://api.github.com/repos/vimalmanohar/kaldi/git/commits{/sha}","comments_url":"https://api.github.com/repos/vimalmanohar/kaldi/comments{/number}","issue_comment_url":"https://api.github.com/repos/vimalmanohar/kaldi/issues/comments{/number}","contents_url":"https://api.github.com/repos/vimalmanohar/kaldi/contents/{+path}","compare_url":"https://api.github.com/repos/vimalmanohar/kaldi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vimalmanohar/kaldi/merges","archive_url":"https://api.github.com/repos/vimalmanohar/kaldi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vimalmanohar/kaldi/downloads","issues_url":"https://api.github.com/repos/vimalmanohar/kaldi/issues{/number}","pulls_url":"https://api.github.com/repos/vimalmanohar/kaldi/pulls{/number}","milestones_url":"https://api.github.com/repos/vimalmanohar/kaldi/milestones{/number}","notifications_url":"https://api.github.com/repos/vimalmanohar/kaldi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vimalmanohar/kaldi/labels{/name}","releases_url":"https://api.github.com/repos/vimalmanohar/kaldi/releases{/id}","deployments_url":"https://api.github.com/repos/vimalmanohar/kaldi/deployments","created_at":"2015-07-27T05:46:16Z","updated_at":"2016-04-19T15:27:41Z","pushed_at":"2016-05-30T19:49:42Z","git_url":"git://github.com/vimalmanohar/kaldi.git","ssh_url":"git@github.com:vimalmanohar/kaldi.git","clone_url":"https://github.com/vimalmanohar/kaldi.git","svn_url":"https://github.com/vimalmanohar/kaldi","homepage":"http://kaldi-asr.org","size":108500,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":5,"default_branch":"master"}},"base":{"label":"kaldi-asr:master","ref":"master","sha":"d8b196951c1cf3437b3fa6cd76edbbc0542b3db9","user":{"login":"kaldi-asr","id":11650082,"avatar_url":"https://avatars.githubusercontent.com/u/11650082?v=3","gravatar_id":"","url":"https://api.github.com/users/kaldi-asr","html_url":"https://github.com/kaldi-asr","followers_url":"https://api.github.com/users/kaldi-asr/followers","following_url":"https://api.github.com/users/kaldi-asr/following{/other_user}","gists_url":"https://api.github.com/users/kaldi-asr/gists{/gist_id}","starred_url":"https://api.github.com/users/kaldi-asr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaldi-asr/subscriptions","organizations_url":"https://api.github.com/users/kaldi-asr/orgs","repos_url":"https://api.github.com/users/kaldi-asr/repos","events_url":"https://api.github.com/users/kaldi-asr/events{/privacy}","received_events_url":"https://api.github.com/users/kaldi-asr/received_events","type":"Organization","site_admin":false},"repo":{"id":34275045,"name":"kaldi","full_name":"kaldi-asr/kaldi","owner":{"login":"kaldi-asr","id":11650082,"avatar_url":"https://avatars.githubusercontent.com/u/11650082?v=3","gravatar_id":"","url":"https://api.github.com/users/kaldi-asr","html_url":"https://github.com/kaldi-asr","followers_url":"https://api.github.com/users/kaldi-asr/followers","following_url":"https://api.github.com/users/kaldi-asr/following{/other_user}","gists_url":"https://api.github.com/users/kaldi-asr/gists{/gist_id}","starred_url":"https://api.github.com/users/kaldi-asr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaldi-asr/subscriptions","organizations_url":"https://api.github.com/users/kaldi-asr/orgs","repos_url":"https://api.github.com/users/kaldi-asr/repos","events_url":"https://api.github.com/users/kaldi-asr/events{/privacy}","received_events_url":"https://api.github.com/users/kaldi-asr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kaldi-asr/kaldi","description":"This is now the official location of the Kaldi project.","fork":false,"url":"https://api.github.com/repos/kaldi-asr/kaldi","forks_url":"https://api.github.com/repos/kaldi-asr/kaldi/forks","keys_url":"https://api.github.com/repos/kaldi-asr/kaldi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaldi-asr/kaldi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaldi-asr/kaldi/teams","hooks_url":"https://api.github.com/repos/kaldi-asr/kaldi/hooks","issue_events_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/events{/number}","events_url":"https://api.github.com/repos/kaldi-asr/kaldi/events","assignees_url":"https://api.github.com/repos/kaldi-asr/kaldi/assignees{/user}","branches_url":"https://api.github.com/repos/kaldi-asr/kaldi/branches{/branch}","tags_url":"https://api.github.com/repos/kaldi-asr/kaldi/tags","blobs_url":"https://api.github.com/repos/kaldi-asr/kaldi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaldi-asr/kaldi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaldi-asr/kaldi/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaldi-asr/kaldi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaldi-asr/kaldi/statuses/{sha}","languages_url":"https://api.github.com/repos/kaldi-asr/kaldi/languages","stargazers_url":"https://api.github.com/repos/kaldi-asr/kaldi/stargazers","contributors_url":"https://api.github.com/repos/kaldi-asr/kaldi/contributors","subscribers_url":"https://api.github.com/repos/kaldi-asr/kaldi/subscribers","subscription_url":"https://api.github.com/repos/kaldi-asr/kaldi/subscription","commits_url":"https://api.github.com/repos/kaldi-asr/kaldi/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaldi-asr/kaldi/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaldi-asr/kaldi/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaldi-asr/kaldi/contents/{+path}","compare_url":"https://api.github.com/repos/kaldi-asr/kaldi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaldi-asr/kaldi/merges","archive_url":"https://api.github.com/repos/kaldi-asr/kaldi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaldi-asr/kaldi/downloads","issues_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues{/number}","pulls_url":"https://api.github.com/repos/kaldi-asr/kaldi/pulls{/number}","milestones_url":"https://api.github.com/repos/kaldi-asr/kaldi/milestones{/number}","notifications_url":"https://api.github.com/repos/kaldi-asr/kaldi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaldi-asr/kaldi/labels{/name}","releases_url":"https://api.github.com/repos/kaldi-asr/kaldi/releases{/id}","deployments_url":"https://api.github.com/repos/kaldi-asr/kaldi/deployments","created_at":"2015-04-20T17:23:16Z","updated_at":"2016-05-30T22:56:06Z","pushed_at":"2016-05-31T02:08:39Z","git_url":"git://github.com/kaldi-asr/kaldi.git","ssh_url":"git@github.com:kaldi-asr/kaldi.git","clone_url":"https://github.com/kaldi-asr/kaldi.git","svn_url":"https://github.com/kaldi-asr/kaldi","homepage":"http://kaldi-asr.org","size":117321,"stargazers_count":670,"watchers_count":670,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":409,"mirror_url":null,"open_issues_count":67,"forks":409,"open_issues":67,"watchers":670,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/777"},"html":{"href":"https://github.com/kaldi-asr/kaldi/pull/777"},"issue":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/issues/777"},"comments":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/issues/777/comments"},"review_comments":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/777/comments"},"review_comment":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/777/commits"},"statuses":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/statuses/b523f9d63f1a28d24e4a59eff59c6abec472147a"}}}}
{"actor":{"display_login":"danpovey"}}