{"action":"created","issue":{"url":"https://api.github.com/repos/sul-dlss/argo/issues/410","labels_url":"https://api.github.com/repos/sul-dlss/argo/issues/410/labels{/name}","comments_url":"https://api.github.com/repos/sul-dlss/argo/issues/410/comments","events_url":"https://api.github.com/repos/sul-dlss/argo/issues/410/events","html_url":"https://github.com/sul-dlss/argo/pull/410","id":124866901,"number":410,"title":"Modify modals for consistency","user":{"login":"mejackreed","id":1656824,"avatar_url":"https://avatars.githubusercontent.com/u/1656824?v=3","gravatar_id":"","url":"https://api.github.com/users/mejackreed","html_url":"https://github.com/mejackreed","followers_url":"https://api.github.com/users/mejackreed/followers","following_url":"https://api.github.com/users/mejackreed/following{/other_user}","gists_url":"https://api.github.com/users/mejackreed/gists{/gist_id}","starred_url":"https://api.github.com/users/mejackreed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mejackreed/subscriptions","organizations_url":"https://api.github.com/users/mejackreed/orgs","repos_url":"https://api.github.com/users/mejackreed/repos","events_url":"https://api.github.com/users/mejackreed/events{/privacy}","received_events_url":"https://api.github.com/users/mejackreed/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2016-01-05T00:05:31Z","updated_at":"2016-01-08T02:04:30Z","closed_at":"2016-01-08T02:03:56Z","pull_request":{"url":"https://api.github.com/repos/sul-dlss/argo/pulls/410","html_url":"https://github.com/sul-dlss/argo/pull/410","diff_url":"https://github.com/sul-dlss/argo/pull/410.diff","patch_url":"https://github.com/sul-dlss/argo/pull/410.patch"},"body":"This pull request standardizes the approach to modals in Argo.\r\n\r\nCloses #403 \r\nCloses #408 60e94b4\r\nPartially addresses #409 \r\nCloses #412 \r\n\r\nWhat this PR aims to do is use Rails template hierarchy to provide views for modals the the non-modal view of a page. When a view is requested it will render using the path: `[action].[format].erb`. For html format requests, the `[action].html.erb` template will be called, for js format requests (modals) the `[action].js.erb` template will be called. Both of these templates provide containers for the partial `_[action].html.erb` which provides the shared display view.\r\n\r\n\r\nModals/pages affected:\r\n\r\n### Facet -> more\r\n<img width=\"997\" alt=\"screen shot 2016-01-06 at 6 07 32 pm\" src=\"https://cloud.githubusercontent.com/assets/1656824/12157520/61d6031a-b4a0-11e5-94ac-d64771d81513.png\">\r\n\r\n### dor/reindex\r\nNote: Per #415 this will actually go away at some point\r\n<img width=\"964\" alt=\"screen shot 2016-01-06 at 5 53 11 pm\" src=\"https://cloud.githubusercontent.com/assets/1656824/12157243/6c077140-b49e-11e5-8882-19fd0ba998f9.png\">\r\n\r\n### items/add_workflow\r\n<img width=\"985\" alt=\"screen shot 2016-01-06 at 5 56 56 pm\" src=\"https://cloud.githubusercontent.com/assets/1656824/12157319/0468f4a4-b49f-11e5-86ef-0a3eeef92201.png\">\r\n\r\n### items/close_version_ui\r\nNote: partially addresses #409, still needs select box options to work\r\n<img width=\"970\" alt=\"screen shot 2016-01-06 at 5 58 44 pm\" src=\"https://cloud.githubusercontent.com/assets/1656824/12157333/26d9b140-b49f-11e5-89b3-b9b859beae3f.png\">\r\n\r\n### items/collection_ui\r\n<img width=\"949\" alt=\"screen shot 2016-01-06 at 6 00 21 pm\" src=\"https://cloud.githubusercontent.com/assets/1656824/12157373/6ade96f8-b49f-11e5-8860-d9d9f2f28a43.png\">\r\n\r\n### items/content_type\r\n<img width=\"708\" alt=\"screen shot 2016-01-06 at 6 01 21 pm\" src=\"https://cloud.githubusercontent.com/assets/1656824/12157388/8561c946-b49f-11e5-82ac-ef4aa4248639.png\">\r\n\r\n### items/open_version_ui\r\n<img width=\"977\" alt=\"screen shot 2016-01-06 at 6 02 05 pm\" src=\"https://cloud.githubusercontent.com/assets/1656824/12157409/aa3be940-b49f-11e5-8c6f-3567a67982aa.png\">\r\n\r\n### items/rights\r\n<img width=\"983\" alt=\"screen shot 2016-01-06 at 6 02 50 pm\" src=\"https://cloud.githubusercontent.com/assets/1656824/12157421/bb1969f4-b49f-11e5-8b7d-36230d5bb55e.png\">\r\n\r\n### items/source_id_ui\r\n<img width=\"944\" alt=\"screen shot 2016-01-06 at 6 03 17 pm\" src=\"https://cloud.githubusercontent.com/assets/1656824/12157447/d0e98692-b49f-11e5-81fd-072063bbc235.png\">\r\n\r\n### items/tags_ui\r\n<img width=\"633\" alt=\"screen shot 2016-01-06 at 6 04 20 pm\" src=\"https://cloud.githubusercontent.com/assets/1656824/12157474/f183bbb6-b49f-11e5-8cdd-d31ba51893f4.png\">\r\n\r\n### items/workflow_history_view\r\n<img width=\"963\" alt=\"screen shot 2016-01-06 at 6 05 37 pm\" src=\"https://cloud.githubusercontent.com/assets/1656824/12157500/21a10236-b4a0-11e5-80a0-a4766414a19e.png\">\r\n\r\n### items/workflow_view\r\n<img width=\"946\" alt=\"screen shot 2016-01-06 at 6 06 20 pm\" src=\"https://cloud.githubusercontent.com/assets/1656824/12157504/365e1a88-b4a0-11e5-8067-2890b5dde97d.png\">\r\n\r\n### view/:id/dc\r\n<img width=\"945\" alt=\"screen shot 2016-01-06 at 9 24 15 pm\" src=\"https://cloud.githubusercontent.com/assets/1656824/12160627/dce27140-b4bb-11e5-9b78-8c4a61980325.png\">\r\n<img width=\"953\" alt=\"screen shot 2016-01-06 at 9 24 43 pm\" src=\"https://cloud.githubusercontent.com/assets/1656824/12160637/f38a589a-b4bb-11e5-80ed-a79f2a66e9b6.png\">\r\n\r\n### view/:id/purl_preview\r\n<img width=\"950\" alt=\"screen shot 2016-01-06 at 9 25 34 pm\" src=\"https://cloud.githubusercontent.com/assets/1656824/12160643/0d984012-b4bc-11e5-93d2-968491a5967d.png\">\r\n"},"comment":{"url":"https://api.github.com/repos/sul-dlss/argo/issues/comments/169865541","html_url":"https://github.com/sul-dlss/argo/pull/410#issuecomment-169865541","issue_url":"https://api.github.com/repos/sul-dlss/argo/issues/410","id":169865541,"user":{"login":"drh-stanford","id":1861171,"avatar_url":"https://avatars.githubusercontent.com/u/1861171?v=3","gravatar_id":"","url":"https://api.github.com/users/drh-stanford","html_url":"https://github.com/drh-stanford","followers_url":"https://api.github.com/users/drh-stanford/followers","following_url":"https://api.github.com/users/drh-stanford/following{/other_user}","gists_url":"https://api.github.com/users/drh-stanford/gists{/gist_id}","starred_url":"https://api.github.com/users/drh-stanford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drh-stanford/subscriptions","organizations_url":"https://api.github.com/users/drh-stanford/orgs","repos_url":"https://api.github.com/users/drh-stanford/repos","events_url":"https://api.github.com/users/drh-stanford/events{/privacy}","received_events_url":"https://api.github.com/users/drh-stanford/received_events","type":"User","site_admin":false},"created_at":"2016-01-08T02:04:29Z","updated_at":"2016-01-08T02:04:29Z","body":"ok, then it all looks good. i've checked all the modals that i can find and that you pointed out above."}}