{"action":"created","comment":{"url":"https://api.github.com/repos/servo/servo/pulls/comments/86784432","pull_request_review_id":7423470,"id":86784432,"diff_hunk":"@@ -467,12 +467,21 @@ impl HTMLFormElement {\n     fn static_validation(&self) -> Result<(), Vec<FormSubmittableElement>> {\n         let node = self.upcast::<Node>();\n         for child in node.traverse_preorder() {\n-            match child.downcast::<Element>() {\n-                Some(el) if !el.disabled_state() => (match el.as_maybe_validatable() {\n-                    Some(ele) => (if ele.is_instance_validatable() {}),\n-                    None => {}\n-                }),\n-                _ => continue,\n+            if let Some(el) = child.downcast::<Element>() {\n+                if el.disabled_state() {\n+                    continue;\n+                }\n+                let validatable = match el.as_maybe_validatable() {\n+                    Some(v) => v,\n+                    None => continue,\n+                };\n+                if !validatable.is_instance_validatable() {\n+                    continue;\n+                }\n+                let mut validate_flags: ValidationFlags = ValidationFlags::empty();\n+                // Need match and insert ValidationFlags later\n+                validatable.validate(validate_flags);","path":"components/script/dom/htmlformelement.rs","position":26,"original_position":32,"commit_id":"3ff9d7e575a3d0cf3f082788f14684cb6974a206","original_commit_id":"3ff9d7e575a3d0cf3f082788f14684cb6974a206","user":{"login":"jdm","id":27658,"avatar_url":"https://avatars.githubusercontent.com/u/27658?v=3","gravatar_id":"","url":"https://api.github.com/users/jdm","html_url":"https://github.com/jdm","followers_url":"https://api.github.com/users/jdm/followers","following_url":"https://api.github.com/users/jdm/following{/other_user}","gists_url":"https://api.github.com/users/jdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdm/subscriptions","organizations_url":"https://api.github.com/users/jdm/orgs","repos_url":"https://api.github.com/users/jdm/repos","events_url":"https://api.github.com/users/jdm/events{/privacy}","received_events_url":"https://api.github.com/users/jdm/received_events","type":"User","site_admin":false},"body":"I would go ahead and call `validatable.validate(ValidationFlags::empty())` for the time being.","created_at":"2016-11-07T14:25:20Z","updated_at":"2016-11-07T14:25:20Z","html_url":"https://github.com/servo/servo/pull/13969#discussion_r86784432","pull_request_url":"https://api.github.com/repos/servo/servo/pulls/13969","_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/comments/86784432"},"html":{"href":"https://github.com/servo/servo/pull/13969#discussion_r86784432"},"pull_request":{"href":"https://api.github.com/repos/servo/servo/pulls/13969"}}},"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/13969","id":91474038,"html_url":"https://github.com/servo/servo/pull/13969","diff_url":"https://github.com/servo/servo/pull/13969.diff","patch_url":"https://github.com/servo/servo/pull/13969.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/13969","number":13969,"state":"open","locked":false,"title":"html form validation initial steps with  test html file","user":{"login":"bbansalWolfPack","id":21151022,"avatar_url":"https://avatars.githubusercontent.com/u/21151022?v=3","gravatar_id":"","url":"https://api.github.com/users/bbansalWolfPack","html_url":"https://github.com/bbansalWolfPack","followers_url":"https://api.github.com/users/bbansalWolfPack/followers","following_url":"https://api.github.com/users/bbansalWolfPack/following{/other_user}","gists_url":"https://api.github.com/users/bbansalWolfPack/gists{/gist_id}","starred_url":"https://api.github.com/users/bbansalWolfPack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbansalWolfPack/subscriptions","organizations_url":"https://api.github.com/users/bbansalWolfPack/orgs","repos_url":"https://api.github.com/users/bbansalWolfPack/repos","events_url":"https://api.github.com/users/bbansalWolfPack/events{/privacy}","received_events_url":"https://api.github.com/users/bbansalWolfPack/received_events","type":"User","site_admin":false},"body":"<!-- Please describe your changes on the following line: -->\n\nAdded code for initial steps in html form validation. \n1. Added methods for trait validatable\n2. implemented stub methods for  elements like HTMLInputElement, HTMLButtonElement, etc\n## 3. Added code to call methods from static validation inHTMLFormElement.rs file\n\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\n- [X ] `./mach build -d` does not report any errors\n- [ X] `./mach test-tidy` does not report any errors\n- [ ] These changes fix #__ (github issue number if applicable).\n\n<!-- Either: -->\n- [ ] There are tests for these changes OR\n- [ ] These changes do not require tests because _____\n\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\n\n<!-- Reviewable:start -->\n---\n\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/13969)\n\n<!-- Reviewable:end -->\n","created_at":"2016-10-29T01:24:28Z","updated_at":"2016-11-07T14:29:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0e096f7d2da32d2075600c2b5926ed6d4454307","assignee":{"login":"jdm","id":27658,"avatar_url":"https://avatars.githubusercontent.com/u/27658?v=3","gravatar_id":"","url":"https://api.github.com/users/jdm","html_url":"https://github.com/jdm","followers_url":"https://api.github.com/users/jdm/followers","following_url":"https://api.github.com/users/jdm/following{/other_user}","gists_url":"https://api.github.com/users/jdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdm/subscriptions","organizations_url":"https://api.github.com/users/jdm/orgs","repos_url":"https://api.github.com/users/jdm/repos","events_url":"https://api.github.com/users/jdm/events{/privacy}","received_events_url":"https://api.github.com/users/jdm/received_events","type":"User","site_admin":false},"assignees":[{"login":"jdm","id":27658,"avatar_url":"https://avatars.githubusercontent.com/u/27658?v=3","gravatar_id":"","url":"https://api.github.com/users/jdm","html_url":"https://github.com/jdm","followers_url":"https://api.github.com/users/jdm/followers","following_url":"https://api.github.com/users/jdm/following{/other_user}","gists_url":"https://api.github.com/users/jdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdm/subscriptions","organizations_url":"https://api.github.com/users/jdm/orgs","repos_url":"https://api.github.com/users/jdm/repos","events_url":"https://api.github.com/users/jdm/events{/privacy}","received_events_url":"https://api.github.com/users/jdm/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/13969/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/13969/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/13969/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/3ff9d7e575a3d0cf3f082788f14684cb6974a206","head":{"label":"bbansalWolfPack:master","ref":"master","sha":"3ff9d7e575a3d0cf3f082788f14684cb6974a206","user":{"login":"bbansalWolfPack","id":21151022,"avatar_url":"https://avatars.githubusercontent.com/u/21151022?v=3","gravatar_id":"","url":"https://api.github.com/users/bbansalWolfPack","html_url":"https://github.com/bbansalWolfPack","followers_url":"https://api.github.com/users/bbansalWolfPack/followers","following_url":"https://api.github.com/users/bbansalWolfPack/following{/other_user}","gists_url":"https://api.github.com/users/bbansalWolfPack/gists{/gist_id}","starred_url":"https://api.github.com/users/bbansalWolfPack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbansalWolfPack/subscriptions","organizations_url":"https://api.github.com/users/bbansalWolfPack/orgs","repos_url":"https://api.github.com/users/bbansalWolfPack/repos","events_url":"https://api.github.com/users/bbansalWolfPack/events{/privacy}","received_events_url":"https://api.github.com/users/bbansalWolfPack/received_events","type":"User","site_admin":false},"repo":{"id":69998342,"name":"servo","full_name":"bbansalWolfPack/servo","owner":{"login":"bbansalWolfPack","id":21151022,"avatar_url":"https://avatars.githubusercontent.com/u/21151022?v=3","gravatar_id":"","url":"https://api.github.com/users/bbansalWolfPack","html_url":"https://github.com/bbansalWolfPack","followers_url":"https://api.github.com/users/bbansalWolfPack/followers","following_url":"https://api.github.com/users/bbansalWolfPack/following{/other_user}","gists_url":"https://api.github.com/users/bbansalWolfPack/gists{/gist_id}","starred_url":"https://api.github.com/users/bbansalWolfPack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbansalWolfPack/subscriptions","organizations_url":"https://api.github.com/users/bbansalWolfPack/orgs","repos_url":"https://api.github.com/users/bbansalWolfPack/repos","events_url":"https://api.github.com/users/bbansalWolfPack/events{/privacy}","received_events_url":"https://api.github.com/users/bbansalWolfPack/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bbansalWolfPack/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/bbansalWolfPack/servo","forks_url":"https://api.github.com/repos/bbansalWolfPack/servo/forks","keys_url":"https://api.github.com/repos/bbansalWolfPack/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbansalWolfPack/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbansalWolfPack/servo/teams","hooks_url":"https://api.github.com/repos/bbansalWolfPack/servo/hooks","issue_events_url":"https://api.github.com/repos/bbansalWolfPack/servo/issues/events{/number}","events_url":"https://api.github.com/repos/bbansalWolfPack/servo/events","assignees_url":"https://api.github.com/repos/bbansalWolfPack/servo/assignees{/user}","branches_url":"https://api.github.com/repos/bbansalWolfPack/servo/branches{/branch}","tags_url":"https://api.github.com/repos/bbansalWolfPack/servo/tags","blobs_url":"https://api.github.com/repos/bbansalWolfPack/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbansalWolfPack/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbansalWolfPack/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbansalWolfPack/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbansalWolfPack/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/bbansalWolfPack/servo/languages","stargazers_url":"https://api.github.com/repos/bbansalWolfPack/servo/stargazers","contributors_url":"https://api.github.com/repos/bbansalWolfPack/servo/contributors","subscribers_url":"https://api.github.com/repos/bbansalWolfPack/servo/subscribers","subscription_url":"https://api.github.com/repos/bbansalWolfPack/servo/subscription","commits_url":"https://api.github.com/repos/bbansalWolfPack/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbansalWolfPack/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbansalWolfPack/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbansalWolfPack/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/bbansalWolfPack/servo/contents/{+path}","compare_url":"https://api.github.com/repos/bbansalWolfPack/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbansalWolfPack/servo/merges","archive_url":"https://api.github.com/repos/bbansalWolfPack/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbansalWolfPack/servo/downloads","issues_url":"https://api.github.com/repos/bbansalWolfPack/servo/issues{/number}","pulls_url":"https://api.github.com/repos/bbansalWolfPack/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/bbansalWolfPack/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/bbansalWolfPack/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbansalWolfPack/servo/labels{/name}","releases_url":"https://api.github.com/repos/bbansalWolfPack/servo/releases{/id}","deployments_url":"https://api.github.com/repos/bbansalWolfPack/servo/deployments","created_at":"2016-10-04T19:22:25Z","updated_at":"2016-10-04T18:53:43Z","pushed_at":"2016-11-05T05:10:06Z","git_url":"git://github.com/bbansalWolfPack/servo.git","ssh_url":"git@github.com:bbansalWolfPack/servo.git","clone_url":"https://github.com/bbansalWolfPack/servo.git","svn_url":"https://github.com/bbansalWolfPack/servo","homepage":"https://servo.org/","size":221544,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"e4fcc066d1248dc072026ba1dd887ffca5049c53","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","deployments_url":"https://api.github.com/repos/servo/servo/deployments","created_at":"2012-02-08T19:07:25Z","updated_at":"2016-11-07T10:14:22Z","pushed_at":"2016-11-07T14:24:31Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"https://servo.org/","size":310743,"stargazers_count":8223,"watchers_count":8223,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1341,"mirror_url":null,"open_issues_count":1874,"forks":1341,"open_issues":1874,"watchers":8223,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/13969"},"html":{"href":"https://github.com/servo/servo/pull/13969"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/13969"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/13969/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/13969/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/13969/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/3ff9d7e575a3d0cf3f082788f14684cb6974a206"}}}}
{"actor":{"display_login":"jdm"}}