{"action":"created","comment":{"url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/comments/68172532","id":68172532,"diff_hunk":"@@ -63,6 +63,13 @@ public static Payload utf8EncodedPayload(final String data, final String metadat\n         return new PayloadImpl(data, metadata);\n     }\n \n+    public static String dataAsString(Payload payload) {\n+        ByteBuffer data = payload.getData();\n+        byte[] dst = new byte[data.remaining()];\n+        data.get(dst);\n+        return new String(dst);","path":"reactivesocket-test/src/main/java/io/reactivesocket/test/TestUtil.java","position":8,"original_position":8,"commit_id":"6372600750f742c03ccc89468151986ce475ec99","original_commit_id":"6372600750f742c03ccc89468151986ce475ec99","user":{"login":"stevegury","id":376195,"avatar_url":"https://avatars.githubusercontent.com/u/376195?v=3","gravatar_id":"","url":"https://api.github.com/users/stevegury","html_url":"https://github.com/stevegury","followers_url":"https://api.github.com/users/stevegury/followers","following_url":"https://api.github.com/users/stevegury/following{/other_user}","gists_url":"https://api.github.com/users/stevegury/gists{/gist_id}","starred_url":"https://api.github.com/users/stevegury/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevegury/subscriptions","organizations_url":"https://api.github.com/users/stevegury/orgs","repos_url":"https://api.github.com/users/stevegury/repos","events_url":"https://api.github.com/users/stevegury/events{/privacy}","received_events_url":"https://api.github.com/users/stevegury/received_events","type":"User","site_admin":false},"body":"We'll add a charset in another commit ;-)","created_at":"2016-06-23T03:57:17Z","updated_at":"2016-06-23T03:57:17Z","html_url":"https://github.com/ReactiveSocket/reactivesocket-java/pull/101#discussion_r68172532","pull_request_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/101","_links":{"self":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/comments/68172532"},"html":{"href":"https://github.com/ReactiveSocket/reactivesocket-java/pull/101#discussion_r68172532"},"pull_request":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/101"}}},"pull_request":{"url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/101","id":74866143,"html_url":"https://github.com/ReactiveSocket/reactivesocket-java/pull/101","diff_url":"https://github.com/ReactiveSocket/reactivesocket-java/pull/101.diff","patch_url":"https://github.com/ReactiveSocket/reactivesocket-java/pull/101.patch","issue_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/issues/101","number":101,"state":"open","locked":false,"title":"Using RxNetty for tcp transport","user":{"login":"NiteshKant","id":820005,"avatar_url":"https://avatars.githubusercontent.com/u/820005?v=3","gravatar_id":"","url":"https://api.github.com/users/NiteshKant","html_url":"https://github.com/NiteshKant","followers_url":"https://api.github.com/users/NiteshKant/followers","following_url":"https://api.github.com/users/NiteshKant/following{/other_user}","gists_url":"https://api.github.com/users/NiteshKant/gists{/gist_id}","starred_url":"https://api.github.com/users/NiteshKant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NiteshKant/subscriptions","organizations_url":"https://api.github.com/users/NiteshKant/orgs","repos_url":"https://api.github.com/users/NiteshKant/repos","events_url":"https://api.github.com/users/NiteshKant/events{/privacy}","received_events_url":"https://api.github.com/users/NiteshKant/received_events","type":"User","site_admin":false},"body":"#### Problem\r\n\r\nCurrent TCP transport implementation lacks a few critical features around insights and network flow control.\r\n\r\n#### Solution\r\n\r\nSince RxNetty already has these features, it makes sense to use it.\r\n\r\n__This is a backward incompatible change as it removes some public classes__\r\n\r\n`EchoClient` in examples module contains the usage example.","created_at":"2016-06-22T22:06:46Z","updated_at":"2016-06-23T03:57:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c375dcbd9f9bd4a3efcbf1855480fc568a022ca5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/101/commits","review_comments_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/101/comments","review_comment_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/issues/101/comments","statuses_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/statuses/6372600750f742c03ccc89468151986ce475ec99","head":{"label":"NiteshKant:rxnetty","ref":"rxnetty","sha":"6372600750f742c03ccc89468151986ce475ec99","user":{"login":"NiteshKant","id":820005,"avatar_url":"https://avatars.githubusercontent.com/u/820005?v=3","gravatar_id":"","url":"https://api.github.com/users/NiteshKant","html_url":"https://github.com/NiteshKant","followers_url":"https://api.github.com/users/NiteshKant/followers","following_url":"https://api.github.com/users/NiteshKant/following{/other_user}","gists_url":"https://api.github.com/users/NiteshKant/gists{/gist_id}","starred_url":"https://api.github.com/users/NiteshKant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NiteshKant/subscriptions","organizations_url":"https://api.github.com/users/NiteshKant/orgs","repos_url":"https://api.github.com/users/NiteshKant/repos","events_url":"https://api.github.com/users/NiteshKant/events{/privacy}","received_events_url":"https://api.github.com/users/NiteshKant/received_events","type":"User","site_admin":false},"repo":{"id":39788725,"name":"reactivesocket-java","full_name":"NiteshKant/reactivesocket-java","owner":{"login":"NiteshKant","id":820005,"avatar_url":"https://avatars.githubusercontent.com/u/820005?v=3","gravatar_id":"","url":"https://api.github.com/users/NiteshKant","html_url":"https://github.com/NiteshKant","followers_url":"https://api.github.com/users/NiteshKant/followers","following_url":"https://api.github.com/users/NiteshKant/following{/other_user}","gists_url":"https://api.github.com/users/NiteshKant/gists{/gist_id}","starred_url":"https://api.github.com/users/NiteshKant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NiteshKant/subscriptions","organizations_url":"https://api.github.com/users/NiteshKant/orgs","repos_url":"https://api.github.com/users/NiteshKant/repos","events_url":"https://api.github.com/users/NiteshKant/events{/privacy}","received_events_url":"https://api.github.com/users/NiteshKant/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NiteshKant/reactivesocket-java","description":"ReactiveSocket Protocol for Client/Server for Java","fork":true,"url":"https://api.github.com/repos/NiteshKant/reactivesocket-java","forks_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/forks","keys_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/teams","hooks_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/hooks","issue_events_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/issues/events{/number}","events_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/events","assignees_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/assignees{/user}","branches_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/branches{/branch}","tags_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/tags","blobs_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/statuses/{sha}","languages_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/languages","stargazers_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/stargazers","contributors_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/contributors","subscribers_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/subscribers","subscription_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/subscription","commits_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/contents/{+path}","compare_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/merges","archive_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/downloads","issues_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/issues{/number}","pulls_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/pulls{/number}","milestones_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/milestones{/number}","notifications_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/labels{/name}","releases_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/releases{/id}","deployments_url":"https://api.github.com/repos/NiteshKant/reactivesocket-java/deployments","created_at":"2015-07-27T17:41:09Z","updated_at":"2016-05-04T18:50:32Z","pushed_at":"2016-06-23T01:00:10Z","git_url":"git://github.com/NiteshKant/reactivesocket-java.git","ssh_url":"git@github.com:NiteshKant/reactivesocket-java.git","clone_url":"https://github.com/NiteshKant/reactivesocket-java.git","svn_url":"https://github.com/NiteshKant/reactivesocket-java","homepage":"reactivesocket.io","size":1134,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ReactiveSocket:master","ref":"master","sha":"59a4ebebe77959a93a33471e8f7ed82ecf0054d7","user":{"login":"ReactiveSocket","id":13168916,"avatar_url":"https://avatars.githubusercontent.com/u/13168916?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveSocket","html_url":"https://github.com/ReactiveSocket","followers_url":"https://api.github.com/users/ReactiveSocket/followers","following_url":"https://api.github.com/users/ReactiveSocket/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveSocket/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveSocket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveSocket/subscriptions","organizations_url":"https://api.github.com/users/ReactiveSocket/orgs","repos_url":"https://api.github.com/users/ReactiveSocket/repos","events_url":"https://api.github.com/users/ReactiveSocket/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveSocket/received_events","type":"Organization","site_admin":false},"repo":{"id":38732107,"name":"reactivesocket-java","full_name":"ReactiveSocket/reactivesocket-java","owner":{"login":"ReactiveSocket","id":13168916,"avatar_url":"https://avatars.githubusercontent.com/u/13168916?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveSocket","html_url":"https://github.com/ReactiveSocket","followers_url":"https://api.github.com/users/ReactiveSocket/followers","following_url":"https://api.github.com/users/ReactiveSocket/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveSocket/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveSocket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveSocket/subscriptions","organizations_url":"https://api.github.com/users/ReactiveSocket/orgs","repos_url":"https://api.github.com/users/ReactiveSocket/repos","events_url":"https://api.github.com/users/ReactiveSocket/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveSocket/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ReactiveSocket/reactivesocket-java","description":"ReactiveSocket Protocol for Client/Server for Java","fork":false,"url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java","forks_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/forks","keys_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/teams","hooks_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/hooks","issue_events_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/issues/events{/number}","events_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/events","assignees_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/assignees{/user}","branches_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/branches{/branch}","tags_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/tags","blobs_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/statuses/{sha}","languages_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/languages","stargazers_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/stargazers","contributors_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/contributors","subscribers_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/subscribers","subscription_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/subscription","commits_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/contents/{+path}","compare_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/merges","archive_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/downloads","issues_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/issues{/number}","pulls_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls{/number}","milestones_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/milestones{/number}","notifications_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/labels{/name}","releases_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/releases{/id}","deployments_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/deployments","created_at":"2015-07-08T04:36:42Z","updated_at":"2016-06-21T23:50:03Z","pushed_at":"2016-06-23T03:49:26Z","git_url":"git://github.com/ReactiveSocket/reactivesocket-java.git","ssh_url":"git@github.com:ReactiveSocket/reactivesocket-java.git","clone_url":"https://github.com/ReactiveSocket/reactivesocket-java.git","svn_url":"https://github.com/ReactiveSocket/reactivesocket-java","homepage":"reactivesocket.io","size":1208,"stargazers_count":71,"watchers_count":71,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":15,"forks":11,"open_issues":15,"watchers":71,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/101"},"html":{"href":"https://github.com/ReactiveSocket/reactivesocket-java/pull/101"},"issue":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/issues/101"},"comments":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/issues/101/comments"},"review_comments":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/101/comments"},"review_comment":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/101/commits"},"statuses":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/statuses/6372600750f742c03ccc89468151986ce475ec99"}}}}
{"actor":{"display_login":"stevegury"}}