{"action":"created","issue":{"url":"https://api.github.com/repos/stan-dev/math/issues/471","repository_url":"https://api.github.com/repos/stan-dev/math","labels_url":"https://api.github.com/repos/stan-dev/math/issues/471/labels{/name}","comments_url":"https://api.github.com/repos/stan-dev/math/issues/471/comments","events_url":"https://api.github.com/repos/stan-dev/math/issues/471/events","html_url":"https://github.com/stan-dev/math/pull/471","id":197629484,"number":471,"title":"Feature/issue 90 poisson logcdf","user":{"login":"thelseraphim","id":11104789,"avatar_url":"https://avatars.githubusercontent.com/u/11104789?v=3","gravatar_id":"","url":"https://api.github.com/users/thelseraphim","html_url":"https://github.com/thelseraphim","followers_url":"https://api.github.com/users/thelseraphim/followers","following_url":"https://api.github.com/users/thelseraphim/following{/other_user}","gists_url":"https://api.github.com/users/thelseraphim/gists{/gist_id}","starred_url":"https://api.github.com/users/thelseraphim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thelseraphim/subscriptions","organizations_url":"https://api.github.com/users/thelseraphim/orgs","repos_url":"https://api.github.com/users/thelseraphim/repos","events_url":"https://api.github.com/users/thelseraphim/events{/privacy}","received_events_url":"https://api.github.com/users/thelseraphim/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-12-27T00:37:26Z","updated_at":"2016-12-30T01:09:56Z","closed_at":"2016-12-30T00:38:03Z","pull_request":{"url":"https://api.github.com/repos/stan-dev/math/pulls/471","html_url":"https://github.com/stan-dev/math/pull/471","diff_url":"https://github.com/stan-dev/math/pull/471.diff","patch_url":"https://github.com/stan-dev/math/pull/471.patch"},"body":"#### Submisison Checklist\r\n\r\n- [ ] Run unit tests: `./runTests.py test/unit`\r\n- [ ] Run cpplint: `make cpplint`\r\n- [ ] Declare copyright holder and open-source license: see below\r\n\r\n#### Summary:\r\nadds `poisson_log_cdf`, `poisson_log_cdf_log`, and `poisson_log_ccdf_log` and adds tests for correct values and partial derivatives with respect to the log rate parameter. this is computed in the silly way you'd expect, `poisson_log_cdf(n, t) = poisson_cdf(n, exp(t))` and the derivatives get a corresponding correction from the chain rule applied to the second argument.\r\n\r\nresolves https://github.com/stan-dev/math/issues/90\r\n\r\n#### Intended Effect:\r\n\r\n#### How to Verify:\r\nBesides running the six tests, it may be helpful to look at the adjacent files `poisson_cdf.hpp,` `poisson_cdf_log.hpp`, and `poisson_ccdf_log.hpp` of which these files are a minor variation. \r\n\r\n#### Side Effects:\r\nNone, adds three functions to the math library.\r\n\r\n#### Documentation:\r\nWill follow up with a PR adding these to the stan language and add doc in the manual at that time\r\n\r\n#### Reviewer Suggestions: \r\n\r\n#### Copyright and Licensing\r\n\r\nPlease list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Columbia University\r\n\r\nBy submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:\r\n- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)\r\n- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)\r\n"},"comment":{"url":"https://api.github.com/repos/stan-dev/math/issues/comments/269718066","html_url":"https://github.com/stan-dev/math/pull/471#issuecomment-269718066","issue_url":"https://api.github.com/repos/stan-dev/math/issues/471","id":269718066,"user":{"login":"thelseraphim","id":11104789,"avatar_url":"https://avatars.githubusercontent.com/u/11104789?v=3","gravatar_id":"","url":"https://api.github.com/users/thelseraphim","html_url":"https://github.com/thelseraphim","followers_url":"https://api.github.com/users/thelseraphim/followers","following_url":"https://api.github.com/users/thelseraphim/following{/other_user}","gists_url":"https://api.github.com/users/thelseraphim/gists{/gist_id}","starred_url":"https://api.github.com/users/thelseraphim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thelseraphim/subscriptions","organizations_url":"https://api.github.com/users/thelseraphim/orgs","repos_url":"https://api.github.com/users/thelseraphim/repos","events_url":"https://api.github.com/users/thelseraphim/events{/privacy}","received_events_url":"https://api.github.com/users/thelseraphim/received_events","type":"User","site_admin":false},"created_at":"2016-12-30T01:09:56Z","updated_at":"2016-12-30T01:09:56Z","body":"oh just because I don't want to merge it, I'm going to rewrite poisson_cdf, etc, which are also not up to standards, and add these after, following their pattern."}}
{"actor":{"display_login":"thelseraphim"}}