{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/60516038","id":60516038,"diff_hunk":"@@ -268,6 +269,7 @@ backend be_secure_{{$cfgIdx}}\n {{     range $idx, $cfg := $serviceUnit.ServiceAliasConfigs }}\n {{       if and (ne $cfg.Host \"\") (eq $cfg.TLSTermination \"edge\")}}\n {{$cfg.Host}}{{$cfg.Path}} {{$idx}}\n+{{$cfg.Host}}{{env \"ROUTER_SERVICE_HTTPS_PORT\" \"443\"}}{{$cfg.Path}} {{$idx}}","path":"images/router/haproxy/conf/haproxy-config.template","position":12,"original_position":12,"commit_id":"310dc6c297f4e2c45fd4c33a313771dbb696f8c8","original_commit_id":"310dc6c297f4e2c45fd4c33a313771dbb696f8c8","user":{"login":"ramr","id":928868,"avatar_url":"https://avatars.githubusercontent.com/u/928868?v=3","gravatar_id":"","url":"https://api.github.com/users/ramr","html_url":"https://github.com/ramr","followers_url":"https://api.github.com/users/ramr/followers","following_url":"https://api.github.com/users/ramr/following{/other_user}","gists_url":"https://api.github.com/users/ramr/gists{/gist_id}","starred_url":"https://api.github.com/users/ramr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramr/subscriptions","organizations_url":"https://api.github.com/users/ramr/orgs","repos_url":"https://api.github.com/users/ramr/repos","events_url":"https://api.github.com/users/ramr/events{/privacy}","received_events_url":"https://api.github.com/users/ramr/received_events","type":"User","site_admin":false},"body":"Same as above - missing host-port separator.","created_at":"2016-04-21T01:48:30Z","updated_at":"2016-04-21T01:48:30Z","html_url":"https://github.com/openshift/origin/pull/8490#discussion_r60516038","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/8490","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/60516038"},"html":{"href":"https://github.com/openshift/origin/pull/8490#discussion_r60516038"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/8490"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/8490","id":66246037,"html_url":"https://github.com/openshift/origin/pull/8490","diff_url":"https://github.com/openshift/origin/pull/8490.diff","patch_url":"https://github.com/openshift/origin/pull/8490.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/8490","number":8490,"state":"open","locked":false,"title":"Support path routes with port number in Host header","user":{"login":"elyscape","id":792695,"avatar_url":"https://avatars.githubusercontent.com/u/792695?v=3","gravatar_id":"","url":"https://api.github.com/users/elyscape","html_url":"https://github.com/elyscape","followers_url":"https://api.github.com/users/elyscape/followers","following_url":"https://api.github.com/users/elyscape/following{/other_user}","gists_url":"https://api.github.com/users/elyscape/gists{/gist_id}","starred_url":"https://api.github.com/users/elyscape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elyscape/subscriptions","organizations_url":"https://api.github.com/users/elyscape/orgs","repos_url":"https://api.github.com/users/elyscape/repos","events_url":"https://api.github.com/users/elyscape/events{/privacy}","received_events_url":"https://api.github.com/users/elyscape/received_events","type":"User","site_admin":false},"body":"This deals with #8471 by adding a duplicate entry to the map files that also includes the port, which will match values of `base` that result when a client includes the port number in the `Host` header.\r\n\r\nFixes #8471.","created_at":"2016-04-12T23:43:47Z","updated_at":"2016-04-21T01:48:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e02d2038b70b3917408b3135d9bcd1a61d68d395","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/8490/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/8490/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/8490/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/310dc6c297f4e2c45fd4c33a313771dbb696f8c8","head":{"label":"elyscape:8471-path-route-port","ref":"8471-path-route-port","sha":"310dc6c297f4e2c45fd4c33a313771dbb696f8c8","user":{"login":"elyscape","id":792695,"avatar_url":"https://avatars.githubusercontent.com/u/792695?v=3","gravatar_id":"","url":"https://api.github.com/users/elyscape","html_url":"https://github.com/elyscape","followers_url":"https://api.github.com/users/elyscape/followers","following_url":"https://api.github.com/users/elyscape/following{/other_user}","gists_url":"https://api.github.com/users/elyscape/gists{/gist_id}","starred_url":"https://api.github.com/users/elyscape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elyscape/subscriptions","organizations_url":"https://api.github.com/users/elyscape/orgs","repos_url":"https://api.github.com/users/elyscape/repos","events_url":"https://api.github.com/users/elyscape/events{/privacy}","received_events_url":"https://api.github.com/users/elyscape/received_events","type":"User","site_admin":false},"repo":{"id":50382128,"name":"origin","full_name":"elyscape/origin","owner":{"login":"elyscape","id":792695,"avatar_url":"https://avatars.githubusercontent.com/u/792695?v=3","gravatar_id":"","url":"https://api.github.com/users/elyscape","html_url":"https://github.com/elyscape","followers_url":"https://api.github.com/users/elyscape/followers","following_url":"https://api.github.com/users/elyscape/following{/other_user}","gists_url":"https://api.github.com/users/elyscape/gists{/gist_id}","starred_url":"https://api.github.com/users/elyscape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elyscape/subscriptions","organizations_url":"https://api.github.com/users/elyscape/orgs","repos_url":"https://api.github.com/users/elyscape/repos","events_url":"https://api.github.com/users/elyscape/events{/privacy}","received_events_url":"https://api.github.com/users/elyscape/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/elyscape/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/elyscape/origin","forks_url":"https://api.github.com/repos/elyscape/origin/forks","keys_url":"https://api.github.com/repos/elyscape/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elyscape/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elyscape/origin/teams","hooks_url":"https://api.github.com/repos/elyscape/origin/hooks","issue_events_url":"https://api.github.com/repos/elyscape/origin/issues/events{/number}","events_url":"https://api.github.com/repos/elyscape/origin/events","assignees_url":"https://api.github.com/repos/elyscape/origin/assignees{/user}","branches_url":"https://api.github.com/repos/elyscape/origin/branches{/branch}","tags_url":"https://api.github.com/repos/elyscape/origin/tags","blobs_url":"https://api.github.com/repos/elyscape/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elyscape/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elyscape/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/elyscape/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elyscape/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/elyscape/origin/languages","stargazers_url":"https://api.github.com/repos/elyscape/origin/stargazers","contributors_url":"https://api.github.com/repos/elyscape/origin/contributors","subscribers_url":"https://api.github.com/repos/elyscape/origin/subscribers","subscription_url":"https://api.github.com/repos/elyscape/origin/subscription","commits_url":"https://api.github.com/repos/elyscape/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/elyscape/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/elyscape/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/elyscape/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/elyscape/origin/contents/{+path}","compare_url":"https://api.github.com/repos/elyscape/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elyscape/origin/merges","archive_url":"https://api.github.com/repos/elyscape/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elyscape/origin/downloads","issues_url":"https://api.github.com/repos/elyscape/origin/issues{/number}","pulls_url":"https://api.github.com/repos/elyscape/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/elyscape/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/elyscape/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elyscape/origin/labels{/name}","releases_url":"https://api.github.com/repos/elyscape/origin/releases{/id}","deployments_url":"https://api.github.com/repos/elyscape/origin/deployments","created_at":"2016-01-25T21:27:02Z","updated_at":"2016-01-25T21:27:08Z","pushed_at":"2016-04-12T23:38:22Z","git_url":"git://github.com/elyscape/origin.git","ssh_url":"git@github.com:elyscape/origin.git","clone_url":"https://github.com/elyscape/origin.git","svn_url":"https://github.com/elyscape/origin","homepage":"http://www.openshift.org","size":242654,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"984f0ba630ff1403196a772e08db8199135e0508","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"The Continuous Application Platform - build, deploy, and manage cloud-native and legacy applications on Kubernetes and Docker","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2016-04-20T21:02:49Z","pushed_at":"2016-04-21T01:03:55Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":331318,"stargazers_count":1236,"watchers_count":1236,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":748,"mirror_url":null,"open_issues_count":1029,"forks":748,"open_issues":1029,"watchers":1236,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/8490"},"html":{"href":"https://github.com/openshift/origin/pull/8490"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/8490"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/8490/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/8490/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/8490/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/310dc6c297f4e2c45fd4c33a313771dbb696f8c8"}}}}