{"action":"created","comment":{"url":"https://api.github.com/repos/xwiki/xwiki-platform/pulls/comments/75330702","id":75330702,"diff_hunk":"@@ -194,9 +201,17 @@ $doc.dropPermissions()##\n         {{error}}Internal error: All objects were filtered out for application: $appName.{{/error}}\n \n       #else\n-        #set($formAction = $xwiki.getURL($app.getFullName(), 'save'))\n-        #set($formId = \"${section.toLowerCase()}_${app.getFullName()}\")\n-        #set($escapedAppName = $escapetool.xml($app.getFullName()))\n+        #if ($editor == \"globaladmin\")\n+          #set($escapedAppName = $escapetool.xml($app.getFullName()))\n+          #set($formAction = $xwiki.getURL($app.getFullName(), 'save'))\n+          #set($formId = \"${section.toLowerCase()}_${app.getFullName()}\")\n+        #else\n+          ## when the application is configured at the space level, it uses the same form but with some different parameters\n+          ## escapedAppName, formAction and formId are changed in order to be relative to the space document configuration (WebPreferences)\n+          #set($escapedAppName = $escapetool.xml($doc.getFullName()))\n+          #set($formAction = $xwiki.getURL($doc.getFullName(), 'save'))\n+          #set($formId = \"${section.toLowerCase()}_${doc.getFullName()}\")\n+        #end","path":"xwiki-platform-core/xwiki-platform-administration/xwiki-platform-administration-ui/src/main/resources/XWiki/ConfigurableClass.xml","position":44,"original_position":44,"commit_id":"86a04eb42cc031f51452dfa2429442a5aba1e184","original_commit_id":"86a04eb42cc031f51452dfa2429442a5aba1e184","user":{"login":"vmassol","id":628267,"avatar_url":"https://avatars.githubusercontent.com/u/628267?v=3","gravatar_id":"","url":"https://api.github.com/users/vmassol","html_url":"https://github.com/vmassol","followers_url":"https://api.github.com/users/vmassol/followers","following_url":"https://api.github.com/users/vmassol/following{/other_user}","gists_url":"https://api.github.com/users/vmassol/gists{/gist_id}","starred_url":"https://api.github.com/users/vmassol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmassol/subscriptions","organizations_url":"https://api.github.com/users/vmassol/orgs","repos_url":"https://api.github.com/users/vmassol/repos","events_url":"https://api.github.com/users/vmassol/events{/privacy}","received_events_url":"https://api.github.com/users/vmassol/received_events","type":"User","site_admin":false},"body":"You should refactor this since the the code inside the \"if\" and \"else\" is the same except one is using $app and the other $doc. You should introduce a local macro for that.","created_at":"2016-08-18T15:29:26Z","updated_at":"2016-08-18T15:29:26Z","html_url":"https://github.com/xwiki/xwiki-platform/pull/485#discussion_r75330702","pull_request_url":"https://api.github.com/repos/xwiki/xwiki-platform/pulls/485","_links":{"self":{"href":"https://api.github.com/repos/xwiki/xwiki-platform/pulls/comments/75330702"},"html":{"href":"https://github.com/xwiki/xwiki-platform/pull/485#discussion_r75330702"},"pull_request":{"href":"https://api.github.com/repos/xwiki/xwiki-platform/pulls/485"}}},"pull_request":{"url":"https://api.github.com/repos/xwiki/xwiki-platform/pulls/485","id":66887916,"html_url":"https://github.com/xwiki/xwiki-platform/pull/485","diff_url":"https://github.com/xwiki/xwiki-platform/pull/485.diff","patch_url":"https://github.com/xwiki/xwiki-platform/pull/485.patch","issue_url":"https://api.github.com/repos/xwiki/xwiki-platform/issues/485","number":485,"state":"open","locked":false,"title":"XWIKI-13321  Add a new \"visibility\" xproperty to the XWiki.ConfigurableClass class","user":{"login":"acotiuga","id":8121819,"avatar_url":"https://avatars.githubusercontent.com/u/8121819?v=3","gravatar_id":"","url":"https://api.github.com/users/acotiuga","html_url":"https://github.com/acotiuga","followers_url":"https://api.github.com/users/acotiuga/followers","following_url":"https://api.github.com/users/acotiuga/following{/other_user}","gists_url":"https://api.github.com/users/acotiuga/gists{/gist_id}","starred_url":"https://api.github.com/users/acotiuga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acotiuga/subscriptions","organizations_url":"https://api.github.com/users/acotiuga/orgs","repos_url":"https://api.github.com/users/acotiuga/repos","events_url":"https://api.github.com/users/acotiuga/events{/privacy}","received_events_url":"https://api.github.com/users/acotiuga/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-04-18T17:05:11Z","updated_at":"2016-08-18T15:29:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8cab8185c6a871a154ff82c45c8742e2e5108105","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/xwiki/xwiki-platform/pulls/485/commits","review_comments_url":"https://api.github.com/repos/xwiki/xwiki-platform/pulls/485/comments","review_comment_url":"https://api.github.com/repos/xwiki/xwiki-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xwiki/xwiki-platform/issues/485/comments","statuses_url":"https://api.github.com/repos/xwiki/xwiki-platform/statuses/86a04eb42cc031f51452dfa2429442a5aba1e184","head":{"label":"acotiuga:XWIKI-13321","ref":"XWIKI-13321","sha":"86a04eb42cc031f51452dfa2429442a5aba1e184","user":{"login":"acotiuga","id":8121819,"avatar_url":"https://avatars.githubusercontent.com/u/8121819?v=3","gravatar_id":"","url":"https://api.github.com/users/acotiuga","html_url":"https://github.com/acotiuga","followers_url":"https://api.github.com/users/acotiuga/followers","following_url":"https://api.github.com/users/acotiuga/following{/other_user}","gists_url":"https://api.github.com/users/acotiuga/gists{/gist_id}","starred_url":"https://api.github.com/users/acotiuga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acotiuga/subscriptions","organizations_url":"https://api.github.com/users/acotiuga/orgs","repos_url":"https://api.github.com/users/acotiuga/repos","events_url":"https://api.github.com/users/acotiuga/events{/privacy}","received_events_url":"https://api.github.com/users/acotiuga/received_events","type":"User","site_admin":false},"repo":null},"base":{"label":"xwiki:master","ref":"master","sha":"85991e12dba028409be0bcdb129ebbc14c5a6883","user":{"login":"xwiki","id":488445,"avatar_url":"https://avatars.githubusercontent.com/u/488445?v=3","gravatar_id":"","url":"https://api.github.com/users/xwiki","html_url":"https://github.com/xwiki","followers_url":"https://api.github.com/users/xwiki/followers","following_url":"https://api.github.com/users/xwiki/following{/other_user}","gists_url":"https://api.github.com/users/xwiki/gists{/gist_id}","starred_url":"https://api.github.com/users/xwiki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwiki/subscriptions","organizations_url":"https://api.github.com/users/xwiki/orgs","repos_url":"https://api.github.com/users/xwiki/repos","events_url":"https://api.github.com/users/xwiki/events{/privacy}","received_events_url":"https://api.github.com/users/xwiki/received_events","type":"Organization","site_admin":false},"repo":{"id":1463490,"name":"xwiki-platform","full_name":"xwiki/xwiki-platform","owner":{"login":"xwiki","id":488445,"avatar_url":"https://avatars.githubusercontent.com/u/488445?v=3","gravatar_id":"","url":"https://api.github.com/users/xwiki","html_url":"https://github.com/xwiki","followers_url":"https://api.github.com/users/xwiki/followers","following_url":"https://api.github.com/users/xwiki/following{/other_user}","gists_url":"https://api.github.com/users/xwiki/gists{/gist_id}","starred_url":"https://api.github.com/users/xwiki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwiki/subscriptions","organizations_url":"https://api.github.com/users/xwiki/orgs","repos_url":"https://api.github.com/users/xwiki/repos","events_url":"https://api.github.com/users/xwiki/events{/privacy}","received_events_url":"https://api.github.com/users/xwiki/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xwiki/xwiki-platform","description":"The XWiki platform","fork":false,"url":"https://api.github.com/repos/xwiki/xwiki-platform","forks_url":"https://api.github.com/repos/xwiki/xwiki-platform/forks","keys_url":"https://api.github.com/repos/xwiki/xwiki-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xwiki/xwiki-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xwiki/xwiki-platform/teams","hooks_url":"https://api.github.com/repos/xwiki/xwiki-platform/hooks","issue_events_url":"https://api.github.com/repos/xwiki/xwiki-platform/issues/events{/number}","events_url":"https://api.github.com/repos/xwiki/xwiki-platform/events","assignees_url":"https://api.github.com/repos/xwiki/xwiki-platform/assignees{/user}","branches_url":"https://api.github.com/repos/xwiki/xwiki-platform/branches{/branch}","tags_url":"https://api.github.com/repos/xwiki/xwiki-platform/tags","blobs_url":"https://api.github.com/repos/xwiki/xwiki-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xwiki/xwiki-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xwiki/xwiki-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/xwiki/xwiki-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xwiki/xwiki-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/xwiki/xwiki-platform/languages","stargazers_url":"https://api.github.com/repos/xwiki/xwiki-platform/stargazers","contributors_url":"https://api.github.com/repos/xwiki/xwiki-platform/contributors","subscribers_url":"https://api.github.com/repos/xwiki/xwiki-platform/subscribers","subscription_url":"https://api.github.com/repos/xwiki/xwiki-platform/subscription","commits_url":"https://api.github.com/repos/xwiki/xwiki-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/xwiki/xwiki-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/xwiki/xwiki-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/xwiki/xwiki-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/xwiki/xwiki-platform/contents/{+path}","compare_url":"https://api.github.com/repos/xwiki/xwiki-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xwiki/xwiki-platform/merges","archive_url":"https://api.github.com/repos/xwiki/xwiki-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xwiki/xwiki-platform/downloads","issues_url":"https://api.github.com/repos/xwiki/xwiki-platform/issues{/number}","pulls_url":"https://api.github.com/repos/xwiki/xwiki-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/xwiki/xwiki-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/xwiki/xwiki-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xwiki/xwiki-platform/labels{/name}","releases_url":"https://api.github.com/repos/xwiki/xwiki-platform/releases{/id}","deployments_url":"https://api.github.com/repos/xwiki/xwiki-platform/deployments","created_at":"2011-03-10T13:26:41Z","updated_at":"2016-08-07T10:05:50Z","pushed_at":"2016-08-18T13:42:15Z","git_url":"git://github.com/xwiki/xwiki-platform.git","ssh_url":"git@github.com:xwiki/xwiki-platform.git","clone_url":"https://github.com/xwiki/xwiki-platform.git","svn_url":"https://github.com/xwiki/xwiki-platform","homepage":"http://platform.xwiki.org/","size":329383,"stargazers_count":170,"watchers_count":170,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":192,"mirror_url":null,"open_issues_count":28,"forks":192,"open_issues":28,"watchers":170,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xwiki/xwiki-platform/pulls/485"},"html":{"href":"https://github.com/xwiki/xwiki-platform/pull/485"},"issue":{"href":"https://api.github.com/repos/xwiki/xwiki-platform/issues/485"},"comments":{"href":"https://api.github.com/repos/xwiki/xwiki-platform/issues/485/comments"},"review_comments":{"href":"https://api.github.com/repos/xwiki/xwiki-platform/pulls/485/comments"},"review_comment":{"href":"https://api.github.com/repos/xwiki/xwiki-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xwiki/xwiki-platform/pulls/485/commits"},"statuses":{"href":"https://api.github.com/repos/xwiki/xwiki-platform/statuses/86a04eb42cc031f51452dfa2429442a5aba1e184"}}}}
{"actor":{"display_login":"vmassol"}}