{"action":"created","comment":{"url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments/82655061","pull_request_review_id":3547914,"id":82655061,"diff_hunk":"@@ -1032,10 +1032,10 @@ zfsctl_snapshot_unmount(char *snapname, int flags)\n \n \targv[2] = kmem_asprintf(SET_UNMOUNT_CMD,\n \t    flags & MNT_FORCE ? \"-f \" : \"\", se->se_path);\n-\tzfsctl_snapshot_rele(se);\n \tdprintf(\"unmount; path=%s\\n\", se->se_path);\n \terror = call_usermodehelper(argv[0], argv, envp, UMH_WAIT_PROC);\n \tstrfree(argv[2]);\n+\tzfsctl_snapshot_rele(se);","path":"module/zfs/zfs_ctldir.c","position":null,"original_position":8,"commit_id":"5dc1ff29ec385bc58d76e76bb367d4391c6ee155","original_commit_id":"00b65db711021d60cc4df57f327d1443ea54a9e1","user":{"login":"tuxoko","id":119672,"avatar_url":"https://avatars.githubusercontent.com/u/119672?v=3","gravatar_id":"","url":"https://api.github.com/users/tuxoko","html_url":"https://github.com/tuxoko","followers_url":"https://api.github.com/users/tuxoko/followers","following_url":"https://api.github.com/users/tuxoko/following{/other_user}","gists_url":"https://api.github.com/users/tuxoko/gists{/gist_id}","starred_url":"https://api.github.com/users/tuxoko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuxoko/subscriptions","organizations_url":"https://api.github.com/users/tuxoko/orgs","repos_url":"https://api.github.com/users/tuxoko/repos","events_url":"https://api.github.com/users/tuxoko/events{/privacy}","received_events_url":"https://api.github.com/users/tuxoko/received_events","type":"User","site_admin":false},"body":"What's the point of this patch when your other patch negate the possibility of use-after-free?","created_at":"2016-10-10T18:10:46Z","updated_at":"2016-10-10T18:10:54Z","html_url":"https://github.com/zfsonlinux/zfs/pull/5250#discussion_r82655061","pull_request_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5250","_links":{"self":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments/82655061"},"html":{"href":"https://github.com/zfsonlinux/zfs/pull/5250#discussion_r82655061"},"pull_request":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5250"}}},"pull_request":{"url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5250","id":88562707,"html_url":"https://github.com/zfsonlinux/zfs/pull/5250","diff_url":"https://github.com/zfsonlinux/zfs/pull/5250.diff","patch_url":"https://github.com/zfsonlinux/zfs/pull/5250.patch","issue_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/5250","number":5250,"state":"open","locked":false,"title":"Fix zfsctl_snapshot_{,un}mount() issues","user":{"login":"stiell","id":214909,"avatar_url":"https://avatars.githubusercontent.com/u/214909?v=3","gravatar_id":"","url":"https://api.github.com/users/stiell","html_url":"https://github.com/stiell","followers_url":"https://api.github.com/users/stiell/followers","following_url":"https://api.github.com/users/stiell/following{/other_user}","gists_url":"https://api.github.com/users/stiell/gists{/gist_id}","starred_url":"https://api.github.com/users/stiell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stiell/subscriptions","organizations_url":"https://api.github.com/users/stiell/orgs","repos_url":"https://api.github.com/users/stiell/repos","events_url":"https://api.github.com/users/stiell/events{/privacy}","received_events_url":"https://api.github.com/users/stiell/received_events","type":"User","site_admin":false},"body":"Fix use after free in `zfsctl_snapshot_unmount()`. Use `/usr/bin/env` instead of `/bin/sh` to fix a shell code injection flaw and allow use with grsecurity.\r\n\r\nNot yet tested on a kernel with grsecurity.\r\n\r\nFixes #4377. Supersedes #4568 and #4573.","created_at":"2016-10-08T23:42:28Z","updated_at":"2016-10-10T18:10:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c9c34a7a87b0e87de98033ab180a6c1ff3046035","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5250/commits","review_comments_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5250/comments","review_comment_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/5250/comments","statuses_url":"https://api.github.com/repos/zfsonlinux/zfs/statuses/5dc1ff29ec385bc58d76e76bb367d4391c6ee155","head":{"label":"stiell:ctldir-fix","ref":"ctldir-fix","sha":"5dc1ff29ec385bc58d76e76bb367d4391c6ee155","user":{"login":"stiell","id":214909,"avatar_url":"https://avatars.githubusercontent.com/u/214909?v=3","gravatar_id":"","url":"https://api.github.com/users/stiell","html_url":"https://github.com/stiell","followers_url":"https://api.github.com/users/stiell/followers","following_url":"https://api.github.com/users/stiell/following{/other_user}","gists_url":"https://api.github.com/users/stiell/gists{/gist_id}","starred_url":"https://api.github.com/users/stiell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stiell/subscriptions","organizations_url":"https://api.github.com/users/stiell/orgs","repos_url":"https://api.github.com/users/stiell/repos","events_url":"https://api.github.com/users/stiell/events{/privacy}","received_events_url":"https://api.github.com/users/stiell/received_events","type":"User","site_admin":false},"repo":{"id":57029938,"name":"zfs","full_name":"stiell/zfs","owner":{"login":"stiell","id":214909,"avatar_url":"https://avatars.githubusercontent.com/u/214909?v=3","gravatar_id":"","url":"https://api.github.com/users/stiell","html_url":"https://github.com/stiell","followers_url":"https://api.github.com/users/stiell/followers","following_url":"https://api.github.com/users/stiell/following{/other_user}","gists_url":"https://api.github.com/users/stiell/gists{/gist_id}","starred_url":"https://api.github.com/users/stiell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stiell/subscriptions","organizations_url":"https://api.github.com/users/stiell/orgs","repos_url":"https://api.github.com/users/stiell/repos","events_url":"https://api.github.com/users/stiell/events{/privacy}","received_events_url":"https://api.github.com/users/stiell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stiell/zfs","description":"Native ZFS for Linux","fork":true,"url":"https://api.github.com/repos/stiell/zfs","forks_url":"https://api.github.com/repos/stiell/zfs/forks","keys_url":"https://api.github.com/repos/stiell/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stiell/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stiell/zfs/teams","hooks_url":"https://api.github.com/repos/stiell/zfs/hooks","issue_events_url":"https://api.github.com/repos/stiell/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/stiell/zfs/events","assignees_url":"https://api.github.com/repos/stiell/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/stiell/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/stiell/zfs/tags","blobs_url":"https://api.github.com/repos/stiell/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stiell/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stiell/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/stiell/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stiell/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/stiell/zfs/languages","stargazers_url":"https://api.github.com/repos/stiell/zfs/stargazers","contributors_url":"https://api.github.com/repos/stiell/zfs/contributors","subscribers_url":"https://api.github.com/repos/stiell/zfs/subscribers","subscription_url":"https://api.github.com/repos/stiell/zfs/subscription","commits_url":"https://api.github.com/repos/stiell/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/stiell/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/stiell/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/stiell/zfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/stiell/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/stiell/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stiell/zfs/merges","archive_url":"https://api.github.com/repos/stiell/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stiell/zfs/downloads","issues_url":"https://api.github.com/repos/stiell/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/stiell/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/stiell/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/stiell/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stiell/zfs/labels{/name}","releases_url":"https://api.github.com/repos/stiell/zfs/releases{/id}","deployments_url":"https://api.github.com/repos/stiell/zfs/deployments","created_at":"2016-04-25T09:37:45Z","updated_at":"2016-04-25T09:37:51Z","pushed_at":"2016-10-09T18:39:36Z","git_url":"git://github.com/stiell/zfs.git","ssh_url":"git@github.com:stiell/zfs.git","clone_url":"https://github.com/stiell/zfs.git","svn_url":"https://github.com/stiell/zfs","homepage":"http://zfsonlinux.org/","size":32532,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zfsonlinux:master","ref":"master","sha":"7515f8f63d1f001adb0e752f9a0f3550e16a6315","user":{"login":"zfsonlinux","id":575083,"avatar_url":"https://avatars.githubusercontent.com/u/575083?v=3","gravatar_id":"","url":"https://api.github.com/users/zfsonlinux","html_url":"https://github.com/zfsonlinux","followers_url":"https://api.github.com/users/zfsonlinux/followers","following_url":"https://api.github.com/users/zfsonlinux/following{/other_user}","gists_url":"https://api.github.com/users/zfsonlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/zfsonlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfsonlinux/subscriptions","organizations_url":"https://api.github.com/users/zfsonlinux/orgs","repos_url":"https://api.github.com/users/zfsonlinux/repos","events_url":"https://api.github.com/users/zfsonlinux/events{/privacy}","received_events_url":"https://api.github.com/users/zfsonlinux/received_events","type":"Organization","site_admin":false},"repo":{"id":437011,"name":"zfs","full_name":"zfsonlinux/zfs","owner":{"login":"zfsonlinux","id":575083,"avatar_url":"https://avatars.githubusercontent.com/u/575083?v=3","gravatar_id":"","url":"https://api.github.com/users/zfsonlinux","html_url":"https://github.com/zfsonlinux","followers_url":"https://api.github.com/users/zfsonlinux/followers","following_url":"https://api.github.com/users/zfsonlinux/following{/other_user}","gists_url":"https://api.github.com/users/zfsonlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/zfsonlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfsonlinux/subscriptions","organizations_url":"https://api.github.com/users/zfsonlinux/orgs","repos_url":"https://api.github.com/users/zfsonlinux/repos","events_url":"https://api.github.com/users/zfsonlinux/events{/privacy}","received_events_url":"https://api.github.com/users/zfsonlinux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zfsonlinux/zfs","description":"ZFS on Linux - the official OpenZFS implementation for Linux.","fork":false,"url":"https://api.github.com/repos/zfsonlinux/zfs","forks_url":"https://api.github.com/repos/zfsonlinux/zfs/forks","keys_url":"https://api.github.com/repos/zfsonlinux/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zfsonlinux/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zfsonlinux/zfs/teams","hooks_url":"https://api.github.com/repos/zfsonlinux/zfs/hooks","issue_events_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/zfsonlinux/zfs/events","assignees_url":"https://api.github.com/repos/zfsonlinux/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/zfsonlinux/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/zfsonlinux/zfs/tags","blobs_url":"https://api.github.com/repos/zfsonlinux/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zfsonlinux/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zfsonlinux/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/zfsonlinux/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zfsonlinux/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/zfsonlinux/zfs/languages","stargazers_url":"https://api.github.com/repos/zfsonlinux/zfs/stargazers","contributors_url":"https://api.github.com/repos/zfsonlinux/zfs/contributors","subscribers_url":"https://api.github.com/repos/zfsonlinux/zfs/subscribers","subscription_url":"https://api.github.com/repos/zfsonlinux/zfs/subscription","commits_url":"https://api.github.com/repos/zfsonlinux/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/zfsonlinux/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/zfsonlinux/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/zfsonlinux/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zfsonlinux/zfs/merges","archive_url":"https://api.github.com/repos/zfsonlinux/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zfsonlinux/zfs/downloads","issues_url":"https://api.github.com/repos/zfsonlinux/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/zfsonlinux/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/zfsonlinux/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zfsonlinux/zfs/labels{/name}","releases_url":"https://api.github.com/repos/zfsonlinux/zfs/releases{/id}","deployments_url":"https://api.github.com/repos/zfsonlinux/zfs/deployments","created_at":"2009-12-14T20:20:34Z","updated_at":"2016-10-10T00:53:09Z","pushed_at":"2016-10-10T18:00:19Z","git_url":"git://github.com/zfsonlinux/zfs.git","ssh_url":"git@github.com:zfsonlinux/zfs.git","clone_url":"https://github.com/zfsonlinux/zfs.git","svn_url":"https://github.com/zfsonlinux/zfs","homepage":"http://zfsonlinux.org/","size":60461,"stargazers_count":2081,"watchers_count":2081,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":520,"mirror_url":null,"open_issues_count":984,"forks":520,"open_issues":984,"watchers":2081,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5250"},"html":{"href":"https://github.com/zfsonlinux/zfs/pull/5250"},"issue":{"href":"https://api.github.com/repos/zfsonlinux/zfs/issues/5250"},"comments":{"href":"https://api.github.com/repos/zfsonlinux/zfs/issues/5250/comments"},"review_comments":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5250/comments"},"review_comment":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5250/commits"},"statuses":{"href":"https://api.github.com/repos/zfsonlinux/zfs/statuses/5dc1ff29ec385bc58d76e76bb367d4391c6ee155"}}}}
{"actor":{"display_login":"tuxoko"}}