{"action":"opened","issue":{"url":"https://api.github.com/repos/torch/nn/issues/603","labels_url":"https://api.github.com/repos/torch/nn/issues/603/labels{/name}","comments_url":"https://api.github.com/repos/torch/nn/issues/603/comments","events_url":"https://api.github.com/repos/torch/nn/issues/603/events","html_url":"https://github.com/torch/nn/issues/603","id":130707491,"number":603,"title":"commmit 'b2af7ea fix for torch7 minall/maxall changes' breaks build for me","user":{"login":"hughperkins","id":123560,"avatar_url":"https://avatars.githubusercontent.com/u/123560?v=3","gravatar_id":"","url":"https://api.github.com/users/hughperkins","html_url":"https://github.com/hughperkins","followers_url":"https://api.github.com/users/hughperkins/followers","following_url":"https://api.github.com/users/hughperkins/following{/other_user}","gists_url":"https://api.github.com/users/hughperkins/gists{/gist_id}","starred_url":"https://api.github.com/users/hughperkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughperkins/subscriptions","organizations_url":"https://api.github.com/users/hughperkins/orgs","repos_url":"https://api.github.com/users/hughperkins/repos","events_url":"https://api.github.com/users/hughperkins/events{/privacy}","received_events_url":"https://api.github.com/users/hughperkins/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-02-02T15:00:20Z","updated_at":"2016-02-02T15:00:20Z","closed_at":null,"body":"with commit `89017f4 Merge pull request #578 from andreaskoepf/THNN_koepf_4` => nn builds ok\r\n\r\nwith commit 'b2af7ea', build result is:\r\n\r\n```\r\nScanning dependencies of target THNN\r\n[100%] Building C object lib/THNN/CMakeFiles/THNN.dir/init.c.o\r\nIn file included from /home/ubuntu/torch/install/include/TH/TH.h:4:0,\r\n                 from /home/ubuntu/git/nn/lib/THNN/init.c:1:\r\n/home/ubuntu/git/nn/lib/THNN/generic/MultiLabelMarginCriterion.c: In function ‘THNN_FloatMultiLabelMarginCriterion_updateOutput’:\r\n/home/ubuntu/torch/install/include/TH/THTensor.h:8:39: error: too many arguments to function ‘THFloatTensor_minall’\r\n #define THTensor_(NAME)   TH_CONCAT_4(TH,Real,Tensor_,NAME)\r\n                                       ^\r\n/home/ubuntu/torch/install/include/TH/THGeneral.h:60:57: note: in definition of macro ‘THArgCheck’\r\n #define THArgCheck(...) _THArgCheck(__FILE__, __LINE__, __VA_ARGS__)\r\n                                                         ^\r\n/home/ubuntu/torch/install/include/TH/THGeneral.h:90:30: note: in expansion of macro ‘TH_CONCAT_4_EXPAND’\r\n #define TH_CONCAT_4(x,y,z,w) TH_CONCAT_4_EXPAND(x,y,z,w)\r\n                              ^\r\n/home/ubuntu/torch/install/include/TH/THTensor.h:8:27: note: in expansion of macro ‘TH_CONCAT_4’\r\n #define THTensor_(NAME)   TH_CONCAT_4(TH,Real,Tensor_,NAME)\r\n                           ^\r\n/home/ubuntu/git/nn/lib/THNN/generic/MultiLabelMarginCriterion.c:27:14: note: in expansion of macro ‘THTensor_’\r\n   THArgCheck(THTensor_(minall)(NULL, target) >= 0, 3, \"target out of range\");\r\n              ^\r\n/home/ubuntu/torch/install/include/TH/THTensor.h:8:39: note: declared here\r\n #define THTensor_(NAME)   TH_CONCAT_4(TH,Real,Tensor_,NAME)\r\n\r\n```"}}