{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/smarthome/pulls/comments/86673122","pull_request_review_id":7321588,"id":86673122,"diff_hunk":"@@ -202,14 +208,13 @@ protected String processColor(Widget w, String snippet) {\n     }\n \n     protected String getCategory(Widget w) {\n-        String category = escapeURL(itemUIRegistry.getCategory(w));\n-        return category;\n+        return itemUIRegistry.getCategory(w);\n     }\n \n     protected String getState(Widget w) {\n         State state = itemUIRegistry.getState(w);\n         if (state != null) {\n-            return escapeURL(state.toString());","path":"extensions/ui/org.eclipse.smarthome.ui.basic/src/main/java/org/eclipse/smarthome/ui/basic/internal/render/AbstractWidgetRenderer.java","position":40,"original_position":40,"commit_id":"d18635e4419e068489b5b956dc64c6aa456d6617","original_commit_id":"d18635e4419e068489b5b956dc64c6aa456d6617","user":{"login":"kaikreuzer","id":3244965,"avatar_url":"https://avatars.githubusercontent.com/u/3244965?v=3","gravatar_id":"","url":"https://api.github.com/users/kaikreuzer","html_url":"https://github.com/kaikreuzer","followers_url":"https://api.github.com/users/kaikreuzer/followers","following_url":"https://api.github.com/users/kaikreuzer/following{/other_user}","gists_url":"https://api.github.com/users/kaikreuzer/gists{/gist_id}","starred_url":"https://api.github.com/users/kaikreuzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaikreuzer/subscriptions","organizations_url":"https://api.github.com/users/kaikreuzer/orgs","repos_url":"https://api.github.com/users/kaikreuzer/repos","events_url":"https://api.github.com/users/kaikreuzer/events{/privacy}","received_events_url":"https://api.github.com/users/kaikreuzer/received_events","type":"User","site_admin":false},"body":"Why did you move the escaping to the preprocessSnippets method? Are there other callers of getState where you do not want escaping being done?","created_at":"2016-11-05T20:55:43Z","updated_at":"2016-11-05T20:55:45Z","html_url":"https://github.com/eclipse/smarthome/pull/2411#discussion_r86673122","pull_request_url":"https://api.github.com/repos/eclipse/smarthome/pulls/2411","_links":{"self":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/comments/86673122"},"html":{"href":"https://github.com/eclipse/smarthome/pull/2411#discussion_r86673122"},"pull_request":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/2411"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/smarthome/pulls/2411","id":92464483,"html_url":"https://github.com/eclipse/smarthome/pull/2411","diff_url":"https://github.com/eclipse/smarthome/pull/2411.diff","patch_url":"https://github.com/eclipse/smarthome/pull/2411.patch","issue_url":"https://api.github.com/repos/eclipse/smarthome/issues/2411","number":2411,"state":"open","locked":false,"title":"BasicUI: fix possible NPE in widget renderer, fixes #2379","user":{"login":"resetnow","id":2057191,"avatar_url":"https://avatars.githubusercontent.com/u/2057191?v=3","gravatar_id":"","url":"https://api.github.com/users/resetnow","html_url":"https://github.com/resetnow","followers_url":"https://api.github.com/users/resetnow/followers","following_url":"https://api.github.com/users/resetnow/following{/other_user}","gists_url":"https://api.github.com/users/resetnow/gists{/gist_id}","starred_url":"https://api.github.com/users/resetnow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resetnow/subscriptions","organizations_url":"https://api.github.com/users/resetnow/orgs","repos_url":"https://api.github.com/users/resetnow/repos","events_url":"https://api.github.com/users/resetnow/events{/privacy}","received_events_url":"https://api.github.com/users/resetnow/received_events","type":"User","site_admin":false},"body":"fixes #2379\r\n\r\nSigned-off-by: Vlad Ivanov <vlad-mbx@ya.ru>","created_at":"2016-11-05T19:34:59Z","updated_at":"2016-11-05T20:55:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c2dfea60d4ff759779d75c78d1b204731b2e0e1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/smarthome/pulls/2411/commits","review_comments_url":"https://api.github.com/repos/eclipse/smarthome/pulls/2411/comments","review_comment_url":"https://api.github.com/repos/eclipse/smarthome/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/smarthome/issues/2411/comments","statuses_url":"https://api.github.com/repos/eclipse/smarthome/statuses/d18635e4419e068489b5b956dc64c6aa456d6617","head":{"label":"resetnow:basicui-fix-2379","ref":"basicui-fix-2379","sha":"d18635e4419e068489b5b956dc64c6aa456d6617","user":{"login":"resetnow","id":2057191,"avatar_url":"https://avatars.githubusercontent.com/u/2057191?v=3","gravatar_id":"","url":"https://api.github.com/users/resetnow","html_url":"https://github.com/resetnow","followers_url":"https://api.github.com/users/resetnow/followers","following_url":"https://api.github.com/users/resetnow/following{/other_user}","gists_url":"https://api.github.com/users/resetnow/gists{/gist_id}","starred_url":"https://api.github.com/users/resetnow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resetnow/subscriptions","organizations_url":"https://api.github.com/users/resetnow/orgs","repos_url":"https://api.github.com/users/resetnow/repos","events_url":"https://api.github.com/users/resetnow/events{/privacy}","received_events_url":"https://api.github.com/users/resetnow/received_events","type":"User","site_admin":false},"repo":{"id":48529275,"name":"smarthome","full_name":"resetnow/smarthome","owner":{"login":"resetnow","id":2057191,"avatar_url":"https://avatars.githubusercontent.com/u/2057191?v=3","gravatar_id":"","url":"https://api.github.com/users/resetnow","html_url":"https://github.com/resetnow","followers_url":"https://api.github.com/users/resetnow/followers","following_url":"https://api.github.com/users/resetnow/following{/other_user}","gists_url":"https://api.github.com/users/resetnow/gists{/gist_id}","starred_url":"https://api.github.com/users/resetnow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resetnow/subscriptions","organizations_url":"https://api.github.com/users/resetnow/orgs","repos_url":"https://api.github.com/users/resetnow/repos","events_url":"https://api.github.com/users/resetnow/events{/privacy}","received_events_url":"https://api.github.com/users/resetnow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/resetnow/smarthome","description":"Eclipse SmartHome project","fork":true,"url":"https://api.github.com/repos/resetnow/smarthome","forks_url":"https://api.github.com/repos/resetnow/smarthome/forks","keys_url":"https://api.github.com/repos/resetnow/smarthome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/resetnow/smarthome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/resetnow/smarthome/teams","hooks_url":"https://api.github.com/repos/resetnow/smarthome/hooks","issue_events_url":"https://api.github.com/repos/resetnow/smarthome/issues/events{/number}","events_url":"https://api.github.com/repos/resetnow/smarthome/events","assignees_url":"https://api.github.com/repos/resetnow/smarthome/assignees{/user}","branches_url":"https://api.github.com/repos/resetnow/smarthome/branches{/branch}","tags_url":"https://api.github.com/repos/resetnow/smarthome/tags","blobs_url":"https://api.github.com/repos/resetnow/smarthome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/resetnow/smarthome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/resetnow/smarthome/git/refs{/sha}","trees_url":"https://api.github.com/repos/resetnow/smarthome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/resetnow/smarthome/statuses/{sha}","languages_url":"https://api.github.com/repos/resetnow/smarthome/languages","stargazers_url":"https://api.github.com/repos/resetnow/smarthome/stargazers","contributors_url":"https://api.github.com/repos/resetnow/smarthome/contributors","subscribers_url":"https://api.github.com/repos/resetnow/smarthome/subscribers","subscription_url":"https://api.github.com/repos/resetnow/smarthome/subscription","commits_url":"https://api.github.com/repos/resetnow/smarthome/commits{/sha}","git_commits_url":"https://api.github.com/repos/resetnow/smarthome/git/commits{/sha}","comments_url":"https://api.github.com/repos/resetnow/smarthome/comments{/number}","issue_comment_url":"https://api.github.com/repos/resetnow/smarthome/issues/comments{/number}","contents_url":"https://api.github.com/repos/resetnow/smarthome/contents/{+path}","compare_url":"https://api.github.com/repos/resetnow/smarthome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/resetnow/smarthome/merges","archive_url":"https://api.github.com/repos/resetnow/smarthome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/resetnow/smarthome/downloads","issues_url":"https://api.github.com/repos/resetnow/smarthome/issues{/number}","pulls_url":"https://api.github.com/repos/resetnow/smarthome/pulls{/number}","milestones_url":"https://api.github.com/repos/resetnow/smarthome/milestones{/number}","notifications_url":"https://api.github.com/repos/resetnow/smarthome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/resetnow/smarthome/labels{/name}","releases_url":"https://api.github.com/repos/resetnow/smarthome/releases{/id}","deployments_url":"https://api.github.com/repos/resetnow/smarthome/deployments","created_at":"2015-12-24T06:44:08Z","updated_at":"2016-01-16T12:34:23Z","pushed_at":"2016-11-05T19:38:07Z","git_url":"git://github.com/resetnow/smarthome.git","ssh_url":"git@github.com:resetnow/smarthome.git","clone_url":"https://github.com/resetnow/smarthome.git","svn_url":"https://github.com/resetnow/smarthome","homepage":null,"size":21290,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"62e402d67ad7460aea7064e10838127a7cccfa1b","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":15778981,"name":"smarthome","full_name":"eclipse/smarthome","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/smarthome","description":"Eclipse SmartHome™ project","fork":false,"url":"https://api.github.com/repos/eclipse/smarthome","forks_url":"https://api.github.com/repos/eclipse/smarthome/forks","keys_url":"https://api.github.com/repos/eclipse/smarthome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/smarthome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/smarthome/teams","hooks_url":"https://api.github.com/repos/eclipse/smarthome/hooks","issue_events_url":"https://api.github.com/repos/eclipse/smarthome/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/smarthome/events","assignees_url":"https://api.github.com/repos/eclipse/smarthome/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/smarthome/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/smarthome/tags","blobs_url":"https://api.github.com/repos/eclipse/smarthome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/smarthome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/smarthome/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/smarthome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/smarthome/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/smarthome/languages","stargazers_url":"https://api.github.com/repos/eclipse/smarthome/stargazers","contributors_url":"https://api.github.com/repos/eclipse/smarthome/contributors","subscribers_url":"https://api.github.com/repos/eclipse/smarthome/subscribers","subscription_url":"https://api.github.com/repos/eclipse/smarthome/subscription","commits_url":"https://api.github.com/repos/eclipse/smarthome/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/smarthome/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/smarthome/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/smarthome/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/smarthome/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/smarthome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/smarthome/merges","archive_url":"https://api.github.com/repos/eclipse/smarthome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/smarthome/downloads","issues_url":"https://api.github.com/repos/eclipse/smarthome/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/smarthome/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/smarthome/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/smarthome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/smarthome/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/smarthome/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/smarthome/deployments","created_at":"2014-01-09T20:47:19Z","updated_at":"2016-11-05T19:55:30Z","pushed_at":"2016-11-05T19:48:59Z","git_url":"git://github.com/eclipse/smarthome.git","ssh_url":"git@github.com:eclipse/smarthome.git","clone_url":"https://github.com/eclipse/smarthome.git","svn_url":"https://github.com/eclipse/smarthome","homepage":"https://www.eclipse.org/smarthome/","size":40347,"stargazers_count":382,"watchers_count":382,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":366,"mirror_url":null,"open_issues_count":235,"forks":366,"open_issues":235,"watchers":382,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/2411"},"html":{"href":"https://github.com/eclipse/smarthome/pull/2411"},"issue":{"href":"https://api.github.com/repos/eclipse/smarthome/issues/2411"},"comments":{"href":"https://api.github.com/repos/eclipse/smarthome/issues/2411/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/2411/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/2411/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/smarthome/statuses/d18635e4419e068489b5b956dc64c6aa456d6617"}}}}
{"actor":{"display_login":"kaikreuzer"}}