{"action":"created","issue":{"url":"https://api.github.com/repos/amalgam8/amalgam8/issues/401","repository_url":"https://api.github.com/repos/amalgam8/amalgam8","labels_url":"https://api.github.com/repos/amalgam8/amalgam8/issues/401/labels{/name}","comments_url":"https://api.github.com/repos/amalgam8/amalgam8/issues/401/comments","events_url":"https://api.github.com/repos/amalgam8/amalgam8/issues/401/events","html_url":"https://github.com/amalgam8/amalgam8/issues/401","id":190041319,"number":401,"title":"Zombie reaping logic hijacks child exit status","user":{"login":"zcahana","id":17428696,"avatar_url":"https://avatars.githubusercontent.com/u/17428696?v=3","gravatar_id":"","url":"https://api.github.com/users/zcahana","html_url":"https://github.com/zcahana","followers_url":"https://api.github.com/users/zcahana/followers","following_url":"https://api.github.com/users/zcahana/following{/other_user}","gists_url":"https://api.github.com/users/zcahana/gists{/gist_id}","starred_url":"https://api.github.com/users/zcahana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcahana/subscriptions","organizations_url":"https://api.github.com/users/zcahana/orgs","repos_url":"https://api.github.com/users/zcahana/repos","events_url":"https://api.github.com/users/zcahana/events{/privacy}","received_events_url":"https://api.github.com/users/zcahana/received_events","type":"User","site_admin":false},"labels":[{"id":437715840,"url":"https://api.github.com/repos/amalgam8/amalgam8/labels/bug","name":"bug","color":"ee0701","default":true},{"id":438616139,"url":"https://api.github.com/repos/amalgam8/amalgam8/labels/sidecar","name":"sidecar","color":"e99695","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-11-17T13:03:30Z","updated_at":"2016-11-17T14:37:39Z","closed_at":null,"body":"The newly added zombie reaping logic reacts to SIGCHLD by doing a wait() syscall.\r\nThis hijacks the child's exit status from competing wait() calls, interfering with......\r\n\r\n1. Nginx updater code which [fails to verify that nginx is running](https://github.com/amalgam8/amalgam8/blob/master/sidecar/proxy/nginx/service.go#L82), so doesn't update nginx with new rules/services:\r\n```time=\"2016-11-17T12:52:44Z\" level=error msg=\"Could not get status of NGINX service\" error=\"waitid: no child processes\" \r\ntime=\"2016-11-17T12:52:44Z\" level=warning msg=\"Controller listener failed\" error=\"waitid: no child processes\" \r\n```\r\n\r\n2. Command-type healthchecks (e.g., `file:///bin/ls` for the productpage microservice) which [fails to read the command exit status](https://github.com/amalgam8/amalgam8/blob/master/sidecar/register/healthcheck/command.go#L87\r\n), and triggers deregistration:\r\n```time=\"2016-11-17T12:46:04Z\" level=info msg=\"Starting Amalgam8 service registration agent\" service_name=productpage \r\ntime=\"2016-11-17T12:46:04Z\" level=info msg=\"Service successfully registered with Amalgam8\" instance_id=c366a7b3223239bc service_name=productpage \r\ntime=\"2016-11-17T12:48:29Z\" level=info msg=\"Stopping Amalgam8 service registration agent\" service_name=productpage \r\ntime=\"2016-11-17T12:48:29Z\" level=info msg=\"Attempting to deregister service with Amalgam8\" instance_id=c366a7b3223239bc service_name=productpage \r\ntime=\"2016-11-17T12:48:29Z\" level=info msg=\"Service successfully deregistered with Amalgam8\" instance_id=c366a7b3223239bc service_name=productpage \r\ntime=\"2016-11-17T12:48:59Z\" level=info msg=\"Starting Amalgam8 service registration agent\" service_name=productpage \r\ntime=\"2016-11-17T12:48:59Z\" level=info msg=\"Service successfully registered with Amalgam8\" instance_id=c366a7b3223239bc service_name=productpage \r\ntime=\"2016-11-17T12:49:29Z\" level=info msg=\"Stopping Amalgam8 service registration agent\" service_name=productpage \r\ntime=\"2016-11-17T12:49:29Z\" level=info msg=\"Attempting to deregister service with Amalgam8\" instance_id=c366a7b3223239bc service_name=productpage \r\ntime=\"2016-11-17T12:49:29Z\" level=info msg=\"Service successfully deregistered with Amalgam8\" instance_id=c366a7b3223239bc service_name=productpage "},"comment":{"url":"https://api.github.com/repos/amalgam8/amalgam8/issues/comments/261262633","html_url":"https://github.com/amalgam8/amalgam8/issues/401#issuecomment-261262633","issue_url":"https://api.github.com/repos/amalgam8/amalgam8/issues/401","id":261262633,"user":{"login":"GregHanson","id":19473391,"avatar_url":"https://avatars.githubusercontent.com/u/19473391?v=3","gravatar_id":"","url":"https://api.github.com/users/GregHanson","html_url":"https://github.com/GregHanson","followers_url":"https://api.github.com/users/GregHanson/followers","following_url":"https://api.github.com/users/GregHanson/following{/other_user}","gists_url":"https://api.github.com/users/GregHanson/gists{/gist_id}","starred_url":"https://api.github.com/users/GregHanson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GregHanson/subscriptions","organizations_url":"https://api.github.com/users/GregHanson/orgs","repos_url":"https://api.github.com/users/GregHanson/repos","events_url":"https://api.github.com/users/GregHanson/events{/privacy}","received_events_url":"https://api.github.com/users/GregHanson/received_events","type":"User","site_admin":false},"created_at":"2016-11-17T14:37:39Z","updated_at":"2016-11-17T14:37:39Z","body":"@zcahana can you document the exact steps to reproduce the nginx item?"}}
{"actor":{"display_login":"GregHanson"}}