{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/9458","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/9458/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/9458/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/9458/events","html_url":"https://github.com/ManageIQ/manageiq/pull/9458","id":162483755,"number":9458,"title":"Refactor the default view keys mapping in the _ui_2 view","user":{"login":"jzigmund","id":2270962,"avatar_url":"https://avatars.githubusercontent.com/u/2270962?v=3","gravatar_id":"","url":"https://api.github.com/users/jzigmund","html_url":"https://github.com/jzigmund","followers_url":"https://api.github.com/users/jzigmund/followers","following_url":"https://api.github.com/users/jzigmund/following{/other_user}","gists_url":"https://api.github.com/users/jzigmund/gists{/gist_id}","starred_url":"https://api.github.com/users/jzigmund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jzigmund/subscriptions","organizations_url":"https://api.github.com/users/jzigmund/orgs","repos_url":"https://api.github.com/users/jzigmund/repos","events_url":"https://api.github.com/users/jzigmund/events{/privacy}","received_events_url":"https://api.github.com/users/jzigmund/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/refactoring","name":"refactoring","color":"fbca04"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/ui","name":"ui","color":"5319e7"}],"state":"open","locked":false,"assignee":{"login":"dclarizio","id":3433754,"avatar_url":"https://avatars.githubusercontent.com/u/3433754?v=3","gravatar_id":"","url":"https://api.github.com/users/dclarizio","html_url":"https://github.com/dclarizio","followers_url":"https://api.github.com/users/dclarizio/followers","following_url":"https://api.github.com/users/dclarizio/following{/other_user}","gists_url":"https://api.github.com/users/dclarizio/gists{/gist_id}","starred_url":"https://api.github.com/users/dclarizio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dclarizio/subscriptions","organizations_url":"https://api.github.com/users/dclarizio/orgs","repos_url":"https://api.github.com/users/dclarizio/repos","events_url":"https://api.github.com/users/dclarizio/events{/privacy}","received_events_url":"https://api.github.com/users/dclarizio/received_events","type":"User","site_admin":false},"assignees":[{"login":"dclarizio","id":3433754,"avatar_url":"https://avatars.githubusercontent.com/u/3433754?v=3","gravatar_id":"","url":"https://api.github.com/users/dclarizio","html_url":"https://github.com/dclarizio","followers_url":"https://api.github.com/users/dclarizio/followers","following_url":"https://api.github.com/users/dclarizio/following{/other_user}","gists_url":"https://api.github.com/users/dclarizio/gists{/gist_id}","starred_url":"https://api.github.com/users/dclarizio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dclarizio/subscriptions","organizations_url":"https://api.github.com/users/dclarizio/orgs","repos_url":"https://api.github.com/users/dclarizio/repos","events_url":"https://api.github.com/users/dclarizio/events{/privacy}","received_events_url":"https://api.github.com/users/dclarizio/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2016-06-27T15:43:37Z","updated_at":"2016-07-13T17:35:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9458","html_url":"https://github.com/ManageIQ/manageiq/pull/9458","diff_url":"https://github.com/ManageIQ/manageiq/pull/9458.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/9458.patch"},"body":"This PR is cleaning up the default views keys mapping and their rendering. I've done that as I needed to debug wrong keys mapping between the view and the DEFAULT_VIEWS ui constant(in ui_constants.rb).\r\n\r\nProbably good idea is moving those keys to the helper to not pollute the view with those mappings and also the iterrations through the mappings. For now this PR is the cleaning of the view."},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/232429550","html_url":"https://github.com/ManageIQ/manageiq/pull/9458#issuecomment-232429550","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/9458","id":232429550,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2016-07-13T17:35:24Z","updated_at":"2016-07-13T17:35:24Z","body":"<rubocop />Checked commit https://github.com/jzigmund/manageiq/commit/3b28d08e342d5b8bc1a84b2ce748efe37676edca with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1\n1 file checked, 11 offenses detected\n\n**app/views/configuration/_ui_2.html.haml**\n- [ ] :warning: - [Line 102](https://github.com/jzigmund/manageiq/blob/3b28d08e342d5b8bc1a84b2ce748efe37676edca/app/views/configuration/_ui_2.html.haml#L102) - Use `%w` or `%W` for an array of words.\n- [ ] :warning: - [Line 102](https://github.com/jzigmund/manageiq/blob/3b28d08e342d5b8bc1a84b2ce748efe37676edca/app/views/configuration/_ui_2.html.haml#L102) - Use `%w` or `%W` for an array of words.\n- [ ] :warning: - [Line 102](https://github.com/jzigmund/manageiq/blob/3b28d08e342d5b8bc1a84b2ce748efe37676edca/app/views/configuration/_ui_2.html.haml#L102) - Use `%w` or `%W` for an array of words.\n- [ ] :warning: - [Line 114](https://github.com/jzigmund/manageiq/blob/3b28d08e342d5b8bc1a84b2ce748efe37676edca/app/views/configuration/_ui_2.html.haml#L114) - Line is too long. [169/160]\n- [ ] :warning: - [Line 115](https://github.com/jzigmund/manageiq/blob/3b28d08e342d5b8bc1a84b2ce748efe37676edca/app/views/configuration/_ui_2.html.haml#L115) - Space between { and | missing.\n- [ ] :warning: - [Line 115](https://github.com/jzigmund/manageiq/blob/3b28d08e342d5b8bc1a84b2ce748efe37676edca/app/views/configuration/_ui_2.html.haml#L115) - Space missing inside }.\n- [ ] :warning: - [Line 69](https://github.com/jzigmund/manageiq/blob/3b28d08e342d5b8bc1a84b2ce748efe37676edca/app/views/configuration/_ui_2.html.haml#L69) - Line is too long. [162/160]\n- [ ] :warning: - [Line 80](https://github.com/jzigmund/manageiq/blob/3b28d08e342d5b8bc1a84b2ce748efe37676edca/app/views/configuration/_ui_2.html.haml#L80) - Use `%w` or `%W` for an array of words.\n- [ ] :warning: - [Line 80](https://github.com/jzigmund/manageiq/blob/3b28d08e342d5b8bc1a84b2ce748efe37676edca/app/views/configuration/_ui_2.html.haml#L80) - Use `%w` or `%W` for an array of words.\n- [ ] :warning: - [Line 92](https://github.com/jzigmund/manageiq/blob/3b28d08e342d5b8bc1a84b2ce748efe37676edca/app/views/configuration/_ui_2.html.haml#L92) - Space between { and | missing.\n- [ ] :warning: - [Line 92](https://github.com/jzigmund/manageiq/blob/3b28d08e342d5b8bc1a84b2ce748efe37676edca/app/views/configuration/_ui_2.html.haml#L92) - Space missing inside }.\n"}}
{"actor":{"display_login":"miq-bot"}}