{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/benchmarking/issues/49","repository_url":"https://api.github.com/repos/nodejs/benchmarking","labels_url":"https://api.github.com/repos/nodejs/benchmarking/issues/49/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/benchmarking/issues/49/comments","events_url":"https://api.github.com/repos/nodejs/benchmarking/issues/49/events","html_url":"https://github.com/nodejs/benchmarking/pull/49","id":159370192,"number":49,"title":"Adding Docker on AcmeAir to repo.","user":{"login":"gareth-ellis","id":14981026,"avatar_url":"https://avatars.githubusercontent.com/u/14981026?v=3","gravatar_id":"","url":"https://api.github.com/users/gareth-ellis","html_url":"https://github.com/gareth-ellis","followers_url":"https://api.github.com/users/gareth-ellis/followers","following_url":"https://api.github.com/users/gareth-ellis/following{/other_user}","gists_url":"https://api.github.com/users/gareth-ellis/gists{/gist_id}","starred_url":"https://api.github.com/users/gareth-ellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gareth-ellis/subscriptions","organizations_url":"https://api.github.com/users/gareth-ellis/orgs","repos_url":"https://api.github.com/users/gareth-ellis/repos","events_url":"https://api.github.com/users/gareth-ellis/events{/privacy}","received_events_url":"https://api.github.com/users/gareth-ellis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"gareth-ellis","id":14981026,"avatar_url":"https://avatars.githubusercontent.com/u/14981026?v=3","gravatar_id":"","url":"https://api.github.com/users/gareth-ellis","html_url":"https://github.com/gareth-ellis","followers_url":"https://api.github.com/users/gareth-ellis/followers","following_url":"https://api.github.com/users/gareth-ellis/following{/other_user}","gists_url":"https://api.github.com/users/gareth-ellis/gists{/gist_id}","starred_url":"https://api.github.com/users/gareth-ellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gareth-ellis/subscriptions","organizations_url":"https://api.github.com/users/gareth-ellis/orgs","repos_url":"https://api.github.com/users/gareth-ellis/repos","events_url":"https://api.github.com/users/gareth-ellis/events{/privacy}","received_events_url":"https://api.github.com/users/gareth-ellis/received_events","type":"User","site_admin":false},"milestone":null,"comments":4,"created_at":"2016-06-09T09:58:26Z","updated_at":"2016-06-13T18:00:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/benchmarking/pulls/49","html_url":"https://github.com/nodejs/benchmarking/pull/49","diff_url":"https://github.com/nodejs/benchmarking/pull/49.diff","patch_url":"https://github.com/nodejs/benchmarking/pull/49.patch"},"body":"This is the work for running AcmeAIr on docker as requested in #47 \r\n\r\nYou need the Dockerfile, plus two folders - each containing copies of node.\r\n\r\nnode_undertest/bin/node -> this is the copy of node you're wanting to test\r\nnode_baseline/bin/node -> this is the copy of node you're using as a baseline - typically this will be the same as node_undertest but without a change that's potentially risky to performance.\r\n\r\nI've tested it locally and the I'm getting fairly consistent numbers. By default it will run three iterations of copy of node interleaved, and then report a percentage at the end of the test along with the individual scores.\r\n\r\nA percentage above 100% is good, below 100% is bad.\r\n\r\ne.g.\r\n\r\n`docker build -t gareth/acmeair:test .`\r\n\r\nwe then get \r\nRESULTS:\r\nBUILD results:\r\n2144.56 2139.11 2136.03\r\nAverage : 2139\r\nBASELINE results:\r\n1871.63 1914.1 1900.93\r\nAverage: 1895\r\nPercentage of build vs baseline - above 100% is good, less than is bad\r\nPercentage : 112.8700%\r\n\r\nI'll leave this for a day or so and then merge it in - i haven't changed any other files, so it won't effect the current acmeair tests.\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/benchmarking/issues/comments/225659582","html_url":"https://github.com/nodejs/benchmarking/pull/49#issuecomment-225659582","issue_url":"https://api.github.com/repos/nodejs/benchmarking/issues/49","id":225659582,"user":{"login":"retrohacker","id":1081565,"avatar_url":"https://avatars.githubusercontent.com/u/1081565?v=3","gravatar_id":"","url":"https://api.github.com/users/retrohacker","html_url":"https://github.com/retrohacker","followers_url":"https://api.github.com/users/retrohacker/followers","following_url":"https://api.github.com/users/retrohacker/following{/other_user}","gists_url":"https://api.github.com/users/retrohacker/gists{/gist_id}","starred_url":"https://api.github.com/users/retrohacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/retrohacker/subscriptions","organizations_url":"https://api.github.com/users/retrohacker/orgs","repos_url":"https://api.github.com/users/retrohacker/repos","events_url":"https://api.github.com/users/retrohacker/events{/privacy}","received_events_url":"https://api.github.com/users/retrohacker/received_events","type":"User","site_admin":false},"created_at":"2016-06-13T18:00:30Z","updated_at":"2016-06-13T18:00:30Z","body":"I reviewed the Dockerfile :smile:\r\n\r\nThis was awesome work @gareth-ellis! A solid pass at a Dockerfile!"}}
{"actor":{"display_login":"retrohacker"}}