{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/8931","repository_url":"https://api.github.com/repos/Automattic/wp-calypso","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/8931/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/8931/comments","events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/8931/events","html_url":"https://github.com/Automattic/wp-calypso/pull/8931","id":184958486,"number":8931,"title":"Framework: Update abtest to remove site list usage","user":{"login":"gwwar","id":1270189,"avatar_url":"https://avatars.githubusercontent.com/u/1270189?v=3","gravatar_id":"","url":"https://api.github.com/users/gwwar","html_url":"https://github.com/gwwar","followers_url":"https://api.github.com/users/gwwar/followers","following_url":"https://api.github.com/users/gwwar/following{/other_user}","gists_url":"https://api.github.com/users/gwwar/gists{/gist_id}","starred_url":"https://api.github.com/users/gwwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwwar/subscriptions","organizations_url":"https://api.github.com/users/gwwar/orgs","repos_url":"https://api.github.com/users/gwwar/repos","events_url":"https://api.github.com/users/gwwar/events{/privacy}","received_events_url":"https://api.github.com/users/gwwar/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Framework","name":"Framework","color":"006b75"},{"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Ready%20to%20Merge","name":"[Status] Ready to Merge","color":"d4fb79"},{"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Type]%20Janitorial","name":"[Type] Janitorial","color":"fad8c7"}],"state":"open","locked":false,"assignee":{"login":"dmsnell","id":5431237,"avatar_url":"https://avatars.githubusercontent.com/u/5431237?v=3","gravatar_id":"","url":"https://api.github.com/users/dmsnell","html_url":"https://github.com/dmsnell","followers_url":"https://api.github.com/users/dmsnell/followers","following_url":"https://api.github.com/users/dmsnell/following{/other_user}","gists_url":"https://api.github.com/users/dmsnell/gists{/gist_id}","starred_url":"https://api.github.com/users/dmsnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmsnell/subscriptions","organizations_url":"https://api.github.com/users/dmsnell/orgs","repos_url":"https://api.github.com/users/dmsnell/repos","events_url":"https://api.github.com/users/dmsnell/events{/privacy}","received_events_url":"https://api.github.com/users/dmsnell/received_events","type":"User","site_admin":false},"assignees":[{"login":"dmsnell","id":5431237,"avatar_url":"https://avatars.githubusercontent.com/u/5431237?v=3","gravatar_id":"","url":"https://api.github.com/users/dmsnell","html_url":"https://github.com/dmsnell","followers_url":"https://api.github.com/users/dmsnell/followers","following_url":"https://api.github.com/users/dmsnell/following{/other_user}","gists_url":"https://api.github.com/users/dmsnell/gists{/gist_id}","starred_url":"https://api.github.com/users/dmsnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmsnell/subscriptions","organizations_url":"https://api.github.com/users/dmsnell/orgs","repos_url":"https://api.github.com/users/dmsnell/repos","events_url":"https://api.github.com/users/dmsnell/events{/privacy}","received_events_url":"https://api.github.com/users/dmsnell/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2016-10-24T21:23:18Z","updated_at":"2016-10-26T16:15:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/8931","html_url":"https://github.com/Automattic/wp-calypso/pull/8931","diff_url":"https://github.com/Automattic/wp-calypso/pull/8931.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/8931.patch"},"body":"Part of #8726 this removes the siteList.getSelectedSite() usage in this library.\r\n\r\n~~Note that I'm still working through if the callee should always pass through needed data, versus exposing the redux store to this library.~~\r\n\r\nAs @nb suggested, in this particular library the `excludeJetpackSites` and `excludeSitesWithPaidPlan` do not appear to be used on any active tests. With this change I've removed them. \r\n\r\nIn the future, any components needing complex test activation logic can work around this by checking for the abtest condition last to avoid triggering an ab test start event in an incorrect group:\r\n```javascript\r\ncondition1 &&\r\ncondition2 &&\r\nabtest( 'experiment' )\r\n```\r\n\r\n### Testing Instructions\r\n- No functional changes\r\n- Set debug to `localStorage.debug = 'calypso:abtests';`\r\n- Existing abtests fire\r\n\r\ncc @artpi @dmsnell @aduth @rralian @lamosty "},"comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments/256399918","html_url":"https://github.com/Automattic/wp-calypso/pull/8931#issuecomment-256399918","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/8931","id":256399918,"user":{"login":"gwwar","id":1270189,"avatar_url":"https://avatars.githubusercontent.com/u/1270189?v=3","gravatar_id":"","url":"https://api.github.com/users/gwwar","html_url":"https://github.com/gwwar","followers_url":"https://api.github.com/users/gwwar/followers","following_url":"https://api.github.com/users/gwwar/following{/other_user}","gists_url":"https://api.github.com/users/gwwar/gists{/gist_id}","starred_url":"https://api.github.com/users/gwwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwwar/subscriptions","organizations_url":"https://api.github.com/users/gwwar/orgs","repos_url":"https://api.github.com/users/gwwar/repos","events_url":"https://api.github.com/users/gwwar/events{/privacy}","received_events_url":"https://api.github.com/users/gwwar/received_events","type":"User","site_admin":false},"created_at":"2016-10-26T16:15:53Z","updated_at":"2016-10-26T16:15:53Z","body":"Thanks for the reviews!"}}
{"actor":{"display_login":"gwwar"}}