{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/17142","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/17142/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/17142/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/17142/events","html_url":"https://github.com/NixOS/nixpkgs/pull/17142","id":166763747,"number":17142,"title":"midori: 0.5.8 -> 0.5.11","user":{"login":"RamKromberg","id":14829269,"avatar_url":"https://avatars.githubusercontent.com/u/14829269?v=3","gravatar_id":"","url":"https://api.github.com/users/RamKromberg","html_url":"https://github.com/RamKromberg","followers_url":"https://api.github.com/users/RamKromberg/followers","following_url":"https://api.github.com/users/RamKromberg/following{/other_user}","gists_url":"https://api.github.com/users/RamKromberg/gists{/gist_id}","starred_url":"https://api.github.com/users/RamKromberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RamKromberg/subscriptions","organizations_url":"https://api.github.com/users/RamKromberg/orgs","repos_url":"https://api.github.com/users/RamKromberg/repos","events_url":"https://api.github.com/users/RamKromberg/events{/privacy}","received_events_url":"https://api.github.com/users/RamKromberg/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20package%20(update)","name":"8.has: package (update)","color":"009800"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-07-21T08:25:49Z","updated_at":"2016-07-25T20:37:45Z","closed_at":"2016-07-25T20:25:43Z","pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/17142","html_url":"https://github.com/NixOS/nixpkgs/pull/17142","diff_url":"https://github.com/NixOS/nixpkgs/pull/17142.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/17142.patch"},"body":"###### Motivation for this change\r\n\r\n```\r\nv0.5.11\r\n Add fake theme for built-in icons\r\n * Don't truncate long speed dial titles if there's room to display them\r\n Fix warnings for -Wformat-security\r\n Ensure vala knows the prototypes of functions it calls, fixing pointer truncation in tests\r\n Add unit test to check appmenu/menubar visibility\r\n Fix last known GTK2 entry placeholder text bugs\r\n Make sure that only one of appmenu and menubar are visible *initially* as well as when changed\r\n Move adblock icons to hicolor\r\n Limit bookmarks panel callbacks to the lifetime of the panel to fix a crash\r\n Fix fallout (broken bookmarks and history panel search) from tweaks to GTK2 entry placeholder\r\n fix property binding to ensure that exactly one of appmenu button and menubar is always visible\r\n Skip open-with codepath with abp links, they are internal\r\n Use find_file to locate execinfo.h\r\n Fix middle/ctrl/normal clicking bookmarks (not folders) in the bookmarkbar.\r\n Add copright header to sanitize_bar.sh\r\n Adblock fixup: Escape . in filter with \\\r\n Don't shadow variable uri in midori_browser_save_uri\r\n Switch Adblock icons to 24px color\r\n Always include app menu in toolbar\r\n Fix various mis[sing ]annotations and style issues in GIR\r\n Compile typelib from gir\r\n Fix assert when resetting webapp state after inactivity reset\r\n clean up handling of double-valued db column in Tabby\r\n Add a comment to explain MidoriBrowser popup callback\r\n fix warnings printed when right-clicking resize grip between location and search entries\r\n Win32: Use Dr. MinGW if present to preserve crash info\r\n Fix menubar warning caused by direct cast instead of `as`\r\n Helper script for setting up bzr with some usefull plugins and settings\r\n Stop using Gtk.Entry.max_width_chars\r\n avoid deprecated SoupServer API with libsoup 2.48\r\n Use unowned in foreach loops in Midori.Window\r\n Use unowned in foreach loops in Midori.Completion\r\n Use unowned with Adblock.Subscription and Element in foreach loops\r\n Use unowned strings in foreach loops\r\n Enable openWith in app mode and make it work with view-new\r\n Implement Midori.Window class with toolbar/ headerbar\r\n Drop support for libsoup-gnome-2.4 < 2.37.1\r\n Make search icons for engines work correctly\r\n Move to WebKit2 4.0 which broke ABI\r\n Port to zeitgeist-2.0\r\n win32: Bump shipped GrayBird theme version to fix some rendering issues\r\n avoid deprecated GtkDialog API with GTK+2 >= 2.22\r\n Title case for \"Export Certificate\" button\r\n fix incorrect type of MAX(sorting) in Tabby\r\n\r\nv0.5.10\r\n use exit instead of return in license script\r\n Fix HAVE_GCR guards after GtkPopover port\r\n Remove example app and .desktop before creating it in the unit test\r\n Fix cache dir path in Adblock and always mkdir tmp\r\n Port location action from Granite.PopOver to Gtk.Popover\r\n Match https site when user-style is using domain syntax\r\n Always disable developer tools on Win32\r\n Reimplement Midori.URI.unescape and add various tests\r\n Make the inspector resizable with GTK3 by packing into a GtkScrolledWindow\r\n Don't build tabs2one in release builds\r\n Don't assume GNotification works on Win32\r\n update copyright date in About dialog\r\n Don't entity-escape history and bookmark results in location completion\r\n Only set tabs' error state if errors come from the main frame\r\n Implement Paste and Proceed as an action\r\n No Gcr on Win for the moment\r\n Yet another Speed Dial CSS update:\r\n Port bookmark popover from Granite to Gtk.Popover\r\n Make application choosers resizable with a sane default size\r\n Use GNotification >= 2.40 and use Midori.App API in webmedia\r\n Rework mouse button handling in KatzeArrayAction\r\n Don't bind :day in HistoryDatabase.query\r\n Make GCR mandatory for all builds\r\n Update coub support in mediaHerald\r\n history-list: Fix gtk+3 build caused by dropping \"using Gtk;\"\r\n Drop all remaining usages of \"using *;\"\r\n Don't open search engines menu when clearing search action\r\n Only remove apps in the sidepanel when left-clicking the delete icon\r\n Improve robustness of GTK3-compatibility placeholder text fallback\r\n Clean up vapi dependency\r\n tls_flags from webkit_web_view_get_tls_info need to be 0\r\n Don't add failed pages to history\r\n Throw error for wrong paramter in Statement.bind\r\n Replace NoJS \"allow all pages\" setting with \"allow local pages\"\r\n Avoid bugs due to race condition in addons delete dialog\r\n Calculate transfer progress at regular intervals to fix 0B/s bug and recalcitrant progess bars\r\n Fix warnings occurring with EXTRA_WARNINGS\r\n Escape parentheses in adblock_fixup_regexp()\r\n Use File.query_exist() on win32 when checking for db to attach\r\n Handle _NEW_WINDOW_ACTION explicitly to make _blank targets work\r\n Fix undefined behavior uint in mouse gestures\r\n fix JavaScript keyup event by calling inherited key-release-event handler in MidoriBrowser\r\n Inline renaming of speed dials\r\n Handle current_size and last_size of Download being equal\r\n Add proper copyright headers to element_hider and autosuggestcontrol\r\n Add X-GNOME-UsesNotifications to indicate the use of notifications\r\n Fix typo in Bookmarks menu UI definition\r\n\r\nv0.5.9\r\n Remove dead code from browser and preferences\r\n Build-fix: Make PanedAction's Child.widget public\r\n fixes tab history undo\r\n Set a placeholder text on the URL entry\r\n Add \"Add Bookmark\" to menu\r\n Show search menu upon left icon click in location bar\r\n Fix crash when saving with associated resources\r\n Fix webkit2 downloads based on older branch\r\n don't hide window decorations for Midori-Granite\r\n Connect bookmarks-db singleton correctly to fix menus\r\n Fix some symbol names and transfer annotations in doc comments\r\n Use correct signature for window-state-event handler\r\n Do not overescape page titles in view completion\r\n Make adblock skip non-standard last update metadata strings\r\n Drop deprecated Granite LightWindow used for the Clear Private Data dialog\r\n Keep storing the last web media tab played.\r\n Allocate CookiePermissionManagerModalInfobar correctly\r\n Make middle clicking reload button duplicate the current tab, similar to other browsers\r\n Use network-changed of GNetworkMonitor to reload all tabs if network becomes available\r\n Show different messages based on network connectivity.\r\n Fix crash when activating the edit menu\r\n Fix \"open all in tabs\" for bookmarks\r\n Fix a few simple leaks\r\n Don't focus the locationaction when leaving blank pages\r\n Fix leaks of two references to the MidoriApp in Tabby\r\n Compile with valac 0.16 again\r\n Never display about:new in the urlbar\r\n fix crash right-clicking forms on local pages\r\n Share 'youtube, vimeo, dailymotion' that you are playing in Midori using org.midori.mediaHerald\r\n Give the SoupURI a path when checking cookie relevance\r\n Resolve ellipsis and title stripping in completion\r\n Add www. and .com/.country_domain and proceed with Ctrl+Enter/Shift+Enter with (readable code)\r\n Clean up browser tab/ uri/ title notify\r\n Drop pseudo Granite distinction in completion layout\r\n Fix visibility of SpeedDial, Toolbar, Bookmarkbar context menu items\r\n Distinguish between desc file missing and other parsing issues\r\n Use dependencies to clear test folders before execution\r\n win32: Drop dropbox usage from win release script, rename resulting output files\r\n```\r\nhttp://midori-browser.org/changelog/\r\n\r\nNote this PR depends on https://github.com/NixOS/nixpkgs/pull/16897 and can't compile without it.\r\n\r\n###### Things done\r\n\r\n- [x] Tested using sandboxing\r\n  ([nix.useChroot](http://nixos.org/nixos/manual/options.html#opt-nix.useChroot) on NixOS,\r\n    or option `build-use-chroot` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)\r\n    on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] OS X\r\n   - [x] Linux\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/235077011","html_url":"https://github.com/NixOS/nixpkgs/pull/17142#issuecomment-235077011","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/17142","id":235077011,"user":{"login":"RamKromberg","id":14829269,"avatar_url":"https://avatars.githubusercontent.com/u/14829269?v=3","gravatar_id":"","url":"https://api.github.com/users/RamKromberg","html_url":"https://github.com/RamKromberg","followers_url":"https://api.github.com/users/RamKromberg/followers","following_url":"https://api.github.com/users/RamKromberg/following{/other_user}","gists_url":"https://api.github.com/users/RamKromberg/gists{/gist_id}","starred_url":"https://api.github.com/users/RamKromberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RamKromberg/subscriptions","organizations_url":"https://api.github.com/users/RamKromberg/orgs","repos_url":"https://api.github.com/users/RamKromberg/repos","events_url":"https://api.github.com/users/RamKromberg/events{/privacy}","received_events_url":"https://api.github.com/users/RamKromberg/received_events","type":"User","site_admin":false},"created_at":"2016-07-25T20:37:45Z","updated_at":"2016-07-25T20:37:45Z","body":"Thank You! :)"}}
{"actor":{"display_login":"RamKromberg"}}