{"action":"created","comment":{"url":"https://api.github.com/repos/smpallen99/ex_admin/pulls/comments/64153699","id":64153699,"diff_hunk":"@@ -237,7 +210,7 @@ defmodule ExAdmin do\n \n   @doc false\n   def get_title_actions(%Plug.Conn{private: _private, path_info: path_info} = conn) do\n-    defn = get_registered_by_controller_route(path_info)\n+    defn = conn.assigns.defn","path":"lib/ex_admin/ex_admin.ex","position":39,"original_position":39,"commit_id":"eacbed0b90cb209c2a288c851a8f211628fa8f07","original_commit_id":"eacbed0b90cb209c2a288c851a8f211628fa8f07","user":{"login":"smpallen99","id":891045,"avatar_url":"https://avatars.githubusercontent.com/u/891045?v=3","gravatar_id":"","url":"https://api.github.com/users/smpallen99","html_url":"https://github.com/smpallen99","followers_url":"https://api.github.com/users/smpallen99/followers","following_url":"https://api.github.com/users/smpallen99/following{/other_user}","gists_url":"https://api.github.com/users/smpallen99/gists{/gist_id}","starred_url":"https://api.github.com/users/smpallen99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smpallen99/subscriptions","organizations_url":"https://api.github.com/users/smpallen99/orgs","repos_url":"https://api.github.com/users/smpallen99/repos","events_url":"https://api.github.com/users/smpallen99/events{/privacy}","received_events_url":"https://api.github.com/users/smpallen99/received_events","type":"User","site_admin":false},"body":"The only example i can think of is if they add their own plugs like authentication or authorization. So, not probable, but possible\n> On May 22, 2016, at 1:53 PM, Roman Smirnov <notifications@github.com> wrote:\n> \n> In lib/ex_admin/ex_admin.ex <https://github.com/smpallen99/ex_admin/pull/127#discussion_r64153631>:\n> \n> > @@ -237,7 +210,7 @@ defmodule ExAdmin do\n> >  \n> >    @doc false\n> >    def get_title_actions(%Plug.Conn{private: _private, path_info: path_info} = conn) do\n> > -    defn = get_registered_by_controller_route(path_info)\n> > +    defn = conn.assigns.defn\n> @smpallen99 <https://github.com/smpallen99> What is the purpose of namespaces here? We assign these keys to connections that handle requests to admin controllers. So, no interference with frontend-controllers is possible.\n> As to ea_required, maybe required_fields would be more descriptive?\n> \n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly or view it on GitHub <https://github.com/smpallen99/ex_admin/pull/127/files/eacbed0b90cb209c2a288c851a8f211628fa8f07#r64153631>\n\n","created_at":"2016-05-22T17:57:45Z","updated_at":"2016-05-22T17:57:45Z","html_url":"https://github.com/smpallen99/ex_admin/pull/127#discussion_r64153699","pull_request_url":"https://api.github.com/repos/smpallen99/ex_admin/pulls/127","_links":{"self":{"href":"https://api.github.com/repos/smpallen99/ex_admin/pulls/comments/64153699"},"html":{"href":"https://github.com/smpallen99/ex_admin/pull/127#discussion_r64153699"},"pull_request":{"href":"https://api.github.com/repos/smpallen99/ex_admin/pulls/127"}}},"pull_request":{"url":"https://api.github.com/repos/smpallen99/ex_admin/pulls/127","id":70970872,"html_url":"https://github.com/smpallen99/ex_admin/pull/127","diff_url":"https://github.com/smpallen99/ex_admin/pull/127.diff","patch_url":"https://github.com/smpallen99/ex_admin/pull/127.patch","issue_url":"https://api.github.com/repos/smpallen99/ex_admin/issues/127","number":127,"state":"open","locked":false,"title":"Encapsulate getting ExAdmin definition by controller path ","user":{"login":"romul","id":28540,"avatar_url":"https://avatars.githubusercontent.com/u/28540?v=3","gravatar_id":"","url":"https://api.github.com/users/romul","html_url":"https://github.com/romul","followers_url":"https://api.github.com/users/romul/followers","following_url":"https://api.github.com/users/romul/following{/other_user}","gists_url":"https://api.github.com/users/romul/gists{/gist_id}","starred_url":"https://api.github.com/users/romul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romul/subscriptions","organizations_url":"https://api.github.com/users/romul/orgs","repos_url":"https://api.github.com/users/romul/repos","events_url":"https://api.github.com/users/romul/events{/privacy}","received_events_url":"https://api.github.com/users/romul/received_events","type":"User","site_admin":false},"body":"Call of `get_registered_by_controller_route!` should be done once per request and only from controller.","created_at":"2016-05-22T08:07:45Z","updated_at":"2016-05-22T17:57:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"635711b60081e07aaf71a8b11722c4f7afc1bd98","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/smpallen99/ex_admin/pulls/127/commits","review_comments_url":"https://api.github.com/repos/smpallen99/ex_admin/pulls/127/comments","review_comment_url":"https://api.github.com/repos/smpallen99/ex_admin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smpallen99/ex_admin/issues/127/comments","statuses_url":"https://api.github.com/repos/smpallen99/ex_admin/statuses/eacbed0b90cb209c2a288c851a8f211628fa8f07","head":{"label":"romul:get_registered_by_controller_route_ecto11","ref":"get_registered_by_controller_route_ecto11","sha":"eacbed0b90cb209c2a288c851a8f211628fa8f07","user":{"login":"romul","id":28540,"avatar_url":"https://avatars.githubusercontent.com/u/28540?v=3","gravatar_id":"","url":"https://api.github.com/users/romul","html_url":"https://github.com/romul","followers_url":"https://api.github.com/users/romul/followers","following_url":"https://api.github.com/users/romul/following{/other_user}","gists_url":"https://api.github.com/users/romul/gists{/gist_id}","starred_url":"https://api.github.com/users/romul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romul/subscriptions","organizations_url":"https://api.github.com/users/romul/orgs","repos_url":"https://api.github.com/users/romul/repos","events_url":"https://api.github.com/users/romul/events{/privacy}","received_events_url":"https://api.github.com/users/romul/received_events","type":"User","site_admin":false},"repo":{"id":53782784,"name":"ex_admin","full_name":"romul/ex_admin","owner":{"login":"romul","id":28540,"avatar_url":"https://avatars.githubusercontent.com/u/28540?v=3","gravatar_id":"","url":"https://api.github.com/users/romul","html_url":"https://github.com/romul","followers_url":"https://api.github.com/users/romul/followers","following_url":"https://api.github.com/users/romul/following{/other_user}","gists_url":"https://api.github.com/users/romul/gists{/gist_id}","starred_url":"https://api.github.com/users/romul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romul/subscriptions","organizations_url":"https://api.github.com/users/romul/orgs","repos_url":"https://api.github.com/users/romul/repos","events_url":"https://api.github.com/users/romul/events{/privacy}","received_events_url":"https://api.github.com/users/romul/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/romul/ex_admin","description":"","fork":true,"url":"https://api.github.com/repos/romul/ex_admin","forks_url":"https://api.github.com/repos/romul/ex_admin/forks","keys_url":"https://api.github.com/repos/romul/ex_admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/romul/ex_admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/romul/ex_admin/teams","hooks_url":"https://api.github.com/repos/romul/ex_admin/hooks","issue_events_url":"https://api.github.com/repos/romul/ex_admin/issues/events{/number}","events_url":"https://api.github.com/repos/romul/ex_admin/events","assignees_url":"https://api.github.com/repos/romul/ex_admin/assignees{/user}","branches_url":"https://api.github.com/repos/romul/ex_admin/branches{/branch}","tags_url":"https://api.github.com/repos/romul/ex_admin/tags","blobs_url":"https://api.github.com/repos/romul/ex_admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/romul/ex_admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/romul/ex_admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/romul/ex_admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/romul/ex_admin/statuses/{sha}","languages_url":"https://api.github.com/repos/romul/ex_admin/languages","stargazers_url":"https://api.github.com/repos/romul/ex_admin/stargazers","contributors_url":"https://api.github.com/repos/romul/ex_admin/contributors","subscribers_url":"https://api.github.com/repos/romul/ex_admin/subscribers","subscription_url":"https://api.github.com/repos/romul/ex_admin/subscription","commits_url":"https://api.github.com/repos/romul/ex_admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/romul/ex_admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/romul/ex_admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/romul/ex_admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/romul/ex_admin/contents/{+path}","compare_url":"https://api.github.com/repos/romul/ex_admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/romul/ex_admin/merges","archive_url":"https://api.github.com/repos/romul/ex_admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/romul/ex_admin/downloads","issues_url":"https://api.github.com/repos/romul/ex_admin/issues{/number}","pulls_url":"https://api.github.com/repos/romul/ex_admin/pulls{/number}","milestones_url":"https://api.github.com/repos/romul/ex_admin/milestones{/number}","notifications_url":"https://api.github.com/repos/romul/ex_admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/romul/ex_admin/labels{/name}","releases_url":"https://api.github.com/repos/romul/ex_admin/releases{/id}","deployments_url":"https://api.github.com/repos/romul/ex_admin/deployments","created_at":"2016-03-13T11:59:39Z","updated_at":"2016-05-15T22:17:39Z","pushed_at":"2016-05-22T08:05:25Z","git_url":"git://github.com/romul/ex_admin.git","ssh_url":"git@github.com:romul/ex_admin.git","clone_url":"https://github.com/romul/ex_admin.git","svn_url":"https://github.com/romul/ex_admin","homepage":null,"size":16066,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"smpallen99:ecto-1.1","ref":"ecto-1.1","sha":"14cbf6e9d4d1cc36873d24d038167b5750b6cc59","user":{"login":"smpallen99","id":891045,"avatar_url":"https://avatars.githubusercontent.com/u/891045?v=3","gravatar_id":"","url":"https://api.github.com/users/smpallen99","html_url":"https://github.com/smpallen99","followers_url":"https://api.github.com/users/smpallen99/followers","following_url":"https://api.github.com/users/smpallen99/following{/other_user}","gists_url":"https://api.github.com/users/smpallen99/gists{/gist_id}","starred_url":"https://api.github.com/users/smpallen99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smpallen99/subscriptions","organizations_url":"https://api.github.com/users/smpallen99/orgs","repos_url":"https://api.github.com/users/smpallen99/repos","events_url":"https://api.github.com/users/smpallen99/events{/privacy}","received_events_url":"https://api.github.com/users/smpallen99/received_events","type":"User","site_admin":false},"repo":{"id":36470617,"name":"ex_admin","full_name":"smpallen99/ex_admin","owner":{"login":"smpallen99","id":891045,"avatar_url":"https://avatars.githubusercontent.com/u/891045?v=3","gravatar_id":"","url":"https://api.github.com/users/smpallen99","html_url":"https://github.com/smpallen99","followers_url":"https://api.github.com/users/smpallen99/followers","following_url":"https://api.github.com/users/smpallen99/following{/other_user}","gists_url":"https://api.github.com/users/smpallen99/gists{/gist_id}","starred_url":"https://api.github.com/users/smpallen99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smpallen99/subscriptions","organizations_url":"https://api.github.com/users/smpallen99/orgs","repos_url":"https://api.github.com/users/smpallen99/repos","events_url":"https://api.github.com/users/smpallen99/events{/privacy}","received_events_url":"https://api.github.com/users/smpallen99/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smpallen99/ex_admin","description":"ExAdmin is an auto administration package for Elixir and the Phoenix Framework","fork":false,"url":"https://api.github.com/repos/smpallen99/ex_admin","forks_url":"https://api.github.com/repos/smpallen99/ex_admin/forks","keys_url":"https://api.github.com/repos/smpallen99/ex_admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smpallen99/ex_admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smpallen99/ex_admin/teams","hooks_url":"https://api.github.com/repos/smpallen99/ex_admin/hooks","issue_events_url":"https://api.github.com/repos/smpallen99/ex_admin/issues/events{/number}","events_url":"https://api.github.com/repos/smpallen99/ex_admin/events","assignees_url":"https://api.github.com/repos/smpallen99/ex_admin/assignees{/user}","branches_url":"https://api.github.com/repos/smpallen99/ex_admin/branches{/branch}","tags_url":"https://api.github.com/repos/smpallen99/ex_admin/tags","blobs_url":"https://api.github.com/repos/smpallen99/ex_admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smpallen99/ex_admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smpallen99/ex_admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/smpallen99/ex_admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smpallen99/ex_admin/statuses/{sha}","languages_url":"https://api.github.com/repos/smpallen99/ex_admin/languages","stargazers_url":"https://api.github.com/repos/smpallen99/ex_admin/stargazers","contributors_url":"https://api.github.com/repos/smpallen99/ex_admin/contributors","subscribers_url":"https://api.github.com/repos/smpallen99/ex_admin/subscribers","subscription_url":"https://api.github.com/repos/smpallen99/ex_admin/subscription","commits_url":"https://api.github.com/repos/smpallen99/ex_admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/smpallen99/ex_admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/smpallen99/ex_admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/smpallen99/ex_admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/smpallen99/ex_admin/contents/{+path}","compare_url":"https://api.github.com/repos/smpallen99/ex_admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smpallen99/ex_admin/merges","archive_url":"https://api.github.com/repos/smpallen99/ex_admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smpallen99/ex_admin/downloads","issues_url":"https://api.github.com/repos/smpallen99/ex_admin/issues{/number}","pulls_url":"https://api.github.com/repos/smpallen99/ex_admin/pulls{/number}","milestones_url":"https://api.github.com/repos/smpallen99/ex_admin/milestones{/number}","notifications_url":"https://api.github.com/repos/smpallen99/ex_admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smpallen99/ex_admin/labels{/name}","releases_url":"https://api.github.com/repos/smpallen99/ex_admin/releases{/id}","deployments_url":"https://api.github.com/repos/smpallen99/ex_admin/deployments","created_at":"2015-05-28T22:55:28Z","updated_at":"2016-05-22T09:00:57Z","pushed_at":"2016-05-22T17:04:45Z","git_url":"git://github.com/smpallen99/ex_admin.git","ssh_url":"git@github.com:smpallen99/ex_admin.git","clone_url":"https://github.com/smpallen99/ex_admin.git","svn_url":"https://github.com/smpallen99/ex_admin","homepage":"","size":16071,"stargazers_count":206,"watchers_count":206,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":35,"forks":36,"open_issues":35,"watchers":206,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smpallen99/ex_admin/pulls/127"},"html":{"href":"https://github.com/smpallen99/ex_admin/pull/127"},"issue":{"href":"https://api.github.com/repos/smpallen99/ex_admin/issues/127"},"comments":{"href":"https://api.github.com/repos/smpallen99/ex_admin/issues/127/comments"},"review_comments":{"href":"https://api.github.com/repos/smpallen99/ex_admin/pulls/127/comments"},"review_comment":{"href":"https://api.github.com/repos/smpallen99/ex_admin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smpallen99/ex_admin/pulls/127/commits"},"statuses":{"href":"https://api.github.com/repos/smpallen99/ex_admin/statuses/eacbed0b90cb209c2a288c851a8f211628fa8f07"}}}}
{"actor":{"display_login":"smpallen99"}}