{"action":"created","comment":{"url":"https://api.github.com/repos/ushahidi/platform-client/pulls/comments/67279377","id":67279377,"diff_hunk":"@@ -29,12 +37,91 @@ function (\n             query = query || PostFilters.getQueryParams($scope.filters);\n \n             $scope.isLoading = true;\n+\n+            var postDetailPromises = [];\n+\n             return PostEndpoint.geojson(query).$promise.then(function (posts) {\n-                map.reloadPosts(posts);\n-                $scope.isLoading = false;\n+                _.each(posts.features, function (feature) {","path":"app/post/views/post-view-map.directive.js","position":35,"original_position":35,"commit_id":"a542acaa5709fa8bceedc382fdf55e45558b6573","original_commit_id":"a542acaa5709fa8bceedc382fdf55e45558b6573","user":{"login":"rjmackay","id":7965,"avatar_url":"https://avatars.githubusercontent.com/u/7965?v=3","gravatar_id":"","url":"https://api.github.com/users/rjmackay","html_url":"https://github.com/rjmackay","followers_url":"https://api.github.com/users/rjmackay/followers","following_url":"https://api.github.com/users/rjmackay/following{/other_user}","gists_url":"https://api.github.com/users/rjmackay/gists{/gist_id}","starred_url":"https://api.github.com/users/rjmackay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjmackay/subscriptions","organizations_url":"https://api.github.com/users/rjmackay/orgs","repos_url":"https://api.github.com/users/rjmackay/repos","events_url":"https://api.github.com/users/rjmackay/events{/privacy}","received_events_url":"https://api.github.com/users/rjmackay/received_events","type":"User","site_admin":false},"body":"This is going to be terrible for deployments that have a few posts. We only need the full post for the single post with an open popup, so loading the data for ALL of them is a waste..","created_at":"2016-06-16T02:34:05Z","updated_at":"2016-06-16T02:34:05Z","html_url":"https://github.com/ushahidi/platform-client/pull/255#discussion_r67279377","pull_request_url":"https://api.github.com/repos/ushahidi/platform-client/pulls/255","_links":{"self":{"href":"https://api.github.com/repos/ushahidi/platform-client/pulls/comments/67279377"},"html":{"href":"https://github.com/ushahidi/platform-client/pull/255#discussion_r67279377"},"pull_request":{"href":"https://api.github.com/repos/ushahidi/platform-client/pulls/255"}}},"pull_request":{"url":"https://api.github.com/repos/ushahidi/platform-client/pulls/255","id":73788629,"html_url":"https://github.com/ushahidi/platform-client/pull/255","diff_url":"https://github.com/ushahidi/platform-client/pull/255.diff","patch_url":"https://github.com/ushahidi/platform-client/pull/255.patch","issue_url":"https://api.github.com/repos/ushahidi/platform-client/issues/255","number":255,"state":"open","locked":false,"title":"Load images, date and author details for map pop-ups","user":{"login":"jasonmule","id":150815,"avatar_url":"https://avatars.githubusercontent.com/u/150815?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonmule","html_url":"https://github.com/jasonmule","followers_url":"https://api.github.com/users/jasonmule/followers","following_url":"https://api.github.com/users/jasonmule/following{/other_user}","gists_url":"https://api.github.com/users/jasonmule/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonmule/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonmule/subscriptions","organizations_url":"https://api.github.com/users/jasonmule/orgs","repos_url":"https://api.github.com/users/jasonmule/repos","events_url":"https://api.github.com/users/jasonmule/events{/privacy}","received_events_url":"https://api.github.com/users/jasonmule/received_events","type":"User","site_admin":false},"body":"This pull request makes the following changes:\r\n- Loads images, dates and author details for map pop-ups\r\n\r\nTest these changes by:\r\n- Clicking on a marker to load a pop-up\r\n\r\nFixes ushahidi/platform#1149.\r\n\r\nPing @ushahidi/platform\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/ushahidi/platform-client/255)\n<!-- Reviewable:end -->\n","created_at":"2016-06-14T18:21:01Z","updated_at":"2016-06-16T02:34:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ushahidi/platform-client/pulls/255/commits","review_comments_url":"https://api.github.com/repos/ushahidi/platform-client/pulls/255/comments","review_comment_url":"https://api.github.com/repos/ushahidi/platform-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ushahidi/platform-client/issues/255/comments","statuses_url":"https://api.github.com/repos/ushahidi/platform-client/statuses/a542acaa5709fa8bceedc382fdf55e45558b6573","head":{"label":"ushahidi:1149-images-in-map-popup","ref":"1149-images-in-map-popup","sha":"a542acaa5709fa8bceedc382fdf55e45558b6573","user":{"login":"ushahidi","id":16959,"avatar_url":"https://avatars.githubusercontent.com/u/16959?v=3","gravatar_id":"","url":"https://api.github.com/users/ushahidi","html_url":"https://github.com/ushahidi","followers_url":"https://api.github.com/users/ushahidi/followers","following_url":"https://api.github.com/users/ushahidi/following{/other_user}","gists_url":"https://api.github.com/users/ushahidi/gists{/gist_id}","starred_url":"https://api.github.com/users/ushahidi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ushahidi/subscriptions","organizations_url":"https://api.github.com/users/ushahidi/orgs","repos_url":"https://api.github.com/users/ushahidi/repos","events_url":"https://api.github.com/users/ushahidi/events{/privacy}","received_events_url":"https://api.github.com/users/ushahidi/received_events","type":"Organization","site_admin":false},"repo":{"id":22108131,"name":"platform-client","full_name":"ushahidi/platform-client","owner":{"login":"ushahidi","id":16959,"avatar_url":"https://avatars.githubusercontent.com/u/16959?v=3","gravatar_id":"","url":"https://api.github.com/users/ushahidi","html_url":"https://github.com/ushahidi","followers_url":"https://api.github.com/users/ushahidi/followers","following_url":"https://api.github.com/users/ushahidi/following{/other_user}","gists_url":"https://api.github.com/users/ushahidi/gists{/gist_id}","starred_url":"https://api.github.com/users/ushahidi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ushahidi/subscriptions","organizations_url":"https://api.github.com/users/ushahidi/orgs","repos_url":"https://api.github.com/users/ushahidi/repos","events_url":"https://api.github.com/users/ushahidi/events{/privacy}","received_events_url":"https://api.github.com/users/ushahidi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ushahidi/platform-client","description":"Ushahidi Platform Client","fork":false,"url":"https://api.github.com/repos/ushahidi/platform-client","forks_url":"https://api.github.com/repos/ushahidi/platform-client/forks","keys_url":"https://api.github.com/repos/ushahidi/platform-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ushahidi/platform-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ushahidi/platform-client/teams","hooks_url":"https://api.github.com/repos/ushahidi/platform-client/hooks","issue_events_url":"https://api.github.com/repos/ushahidi/platform-client/issues/events{/number}","events_url":"https://api.github.com/repos/ushahidi/platform-client/events","assignees_url":"https://api.github.com/repos/ushahidi/platform-client/assignees{/user}","branches_url":"https://api.github.com/repos/ushahidi/platform-client/branches{/branch}","tags_url":"https://api.github.com/repos/ushahidi/platform-client/tags","blobs_url":"https://api.github.com/repos/ushahidi/platform-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ushahidi/platform-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ushahidi/platform-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/ushahidi/platform-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ushahidi/platform-client/statuses/{sha}","languages_url":"https://api.github.com/repos/ushahidi/platform-client/languages","stargazers_url":"https://api.github.com/repos/ushahidi/platform-client/stargazers","contributors_url":"https://api.github.com/repos/ushahidi/platform-client/contributors","subscribers_url":"https://api.github.com/repos/ushahidi/platform-client/subscribers","subscription_url":"https://api.github.com/repos/ushahidi/platform-client/subscription","commits_url":"https://api.github.com/repos/ushahidi/platform-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/ushahidi/platform-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/ushahidi/platform-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/ushahidi/platform-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/ushahidi/platform-client/contents/{+path}","compare_url":"https://api.github.com/repos/ushahidi/platform-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ushahidi/platform-client/merges","archive_url":"https://api.github.com/repos/ushahidi/platform-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ushahidi/platform-client/downloads","issues_url":"https://api.github.com/repos/ushahidi/platform-client/issues{/number}","pulls_url":"https://api.github.com/repos/ushahidi/platform-client/pulls{/number}","milestones_url":"https://api.github.com/repos/ushahidi/platform-client/milestones{/number}","notifications_url":"https://api.github.com/repos/ushahidi/platform-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ushahidi/platform-client/labels{/name}","releases_url":"https://api.github.com/repos/ushahidi/platform-client/releases{/id}","deployments_url":"https://api.github.com/repos/ushahidi/platform-client/deployments","created_at":"2014-07-22T14:53:40Z","updated_at":"2016-05-16T13:29:04Z","pushed_at":"2016-06-15T19:57:09Z","git_url":"git://github.com/ushahidi/platform-client.git","ssh_url":"git@github.com:ushahidi/platform-client.git","clone_url":"https://github.com/ushahidi/platform-client.git","svn_url":"https://github.com/ushahidi/platform-client","homepage":"http://ushahidi.com","size":5517,"stargazers_count":26,"watchers_count":26,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":24,"forks":46,"open_issues":24,"watchers":26,"default_branch":"develop"}},"base":{"label":"ushahidi:develop","ref":"develop","sha":"22e4b4791ae86a4393ec929082ba26bc95b52999","user":{"login":"ushahidi","id":16959,"avatar_url":"https://avatars.githubusercontent.com/u/16959?v=3","gravatar_id":"","url":"https://api.github.com/users/ushahidi","html_url":"https://github.com/ushahidi","followers_url":"https://api.github.com/users/ushahidi/followers","following_url":"https://api.github.com/users/ushahidi/following{/other_user}","gists_url":"https://api.github.com/users/ushahidi/gists{/gist_id}","starred_url":"https://api.github.com/users/ushahidi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ushahidi/subscriptions","organizations_url":"https://api.github.com/users/ushahidi/orgs","repos_url":"https://api.github.com/users/ushahidi/repos","events_url":"https://api.github.com/users/ushahidi/events{/privacy}","received_events_url":"https://api.github.com/users/ushahidi/received_events","type":"Organization","site_admin":false},"repo":{"id":22108131,"name":"platform-client","full_name":"ushahidi/platform-client","owner":{"login":"ushahidi","id":16959,"avatar_url":"https://avatars.githubusercontent.com/u/16959?v=3","gravatar_id":"","url":"https://api.github.com/users/ushahidi","html_url":"https://github.com/ushahidi","followers_url":"https://api.github.com/users/ushahidi/followers","following_url":"https://api.github.com/users/ushahidi/following{/other_user}","gists_url":"https://api.github.com/users/ushahidi/gists{/gist_id}","starred_url":"https://api.github.com/users/ushahidi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ushahidi/subscriptions","organizations_url":"https://api.github.com/users/ushahidi/orgs","repos_url":"https://api.github.com/users/ushahidi/repos","events_url":"https://api.github.com/users/ushahidi/events{/privacy}","received_events_url":"https://api.github.com/users/ushahidi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ushahidi/platform-client","description":"Ushahidi Platform Client","fork":false,"url":"https://api.github.com/repos/ushahidi/platform-client","forks_url":"https://api.github.com/repos/ushahidi/platform-client/forks","keys_url":"https://api.github.com/repos/ushahidi/platform-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ushahidi/platform-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ushahidi/platform-client/teams","hooks_url":"https://api.github.com/repos/ushahidi/platform-client/hooks","issue_events_url":"https://api.github.com/repos/ushahidi/platform-client/issues/events{/number}","events_url":"https://api.github.com/repos/ushahidi/platform-client/events","assignees_url":"https://api.github.com/repos/ushahidi/platform-client/assignees{/user}","branches_url":"https://api.github.com/repos/ushahidi/platform-client/branches{/branch}","tags_url":"https://api.github.com/repos/ushahidi/platform-client/tags","blobs_url":"https://api.github.com/repos/ushahidi/platform-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ushahidi/platform-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ushahidi/platform-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/ushahidi/platform-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ushahidi/platform-client/statuses/{sha}","languages_url":"https://api.github.com/repos/ushahidi/platform-client/languages","stargazers_url":"https://api.github.com/repos/ushahidi/platform-client/stargazers","contributors_url":"https://api.github.com/repos/ushahidi/platform-client/contributors","subscribers_url":"https://api.github.com/repos/ushahidi/platform-client/subscribers","subscription_url":"https://api.github.com/repos/ushahidi/platform-client/subscription","commits_url":"https://api.github.com/repos/ushahidi/platform-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/ushahidi/platform-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/ushahidi/platform-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/ushahidi/platform-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/ushahidi/platform-client/contents/{+path}","compare_url":"https://api.github.com/repos/ushahidi/platform-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ushahidi/platform-client/merges","archive_url":"https://api.github.com/repos/ushahidi/platform-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ushahidi/platform-client/downloads","issues_url":"https://api.github.com/repos/ushahidi/platform-client/issues{/number}","pulls_url":"https://api.github.com/repos/ushahidi/platform-client/pulls{/number}","milestones_url":"https://api.github.com/repos/ushahidi/platform-client/milestones{/number}","notifications_url":"https://api.github.com/repos/ushahidi/platform-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ushahidi/platform-client/labels{/name}","releases_url":"https://api.github.com/repos/ushahidi/platform-client/releases{/id}","deployments_url":"https://api.github.com/repos/ushahidi/platform-client/deployments","created_at":"2014-07-22T14:53:40Z","updated_at":"2016-05-16T13:29:04Z","pushed_at":"2016-06-15T19:57:09Z","git_url":"git://github.com/ushahidi/platform-client.git","ssh_url":"git@github.com:ushahidi/platform-client.git","clone_url":"https://github.com/ushahidi/platform-client.git","svn_url":"https://github.com/ushahidi/platform-client","homepage":"http://ushahidi.com","size":5517,"stargazers_count":26,"watchers_count":26,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":24,"forks":46,"open_issues":24,"watchers":26,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ushahidi/platform-client/pulls/255"},"html":{"href":"https://github.com/ushahidi/platform-client/pull/255"},"issue":{"href":"https://api.github.com/repos/ushahidi/platform-client/issues/255"},"comments":{"href":"https://api.github.com/repos/ushahidi/platform-client/issues/255/comments"},"review_comments":{"href":"https://api.github.com/repos/ushahidi/platform-client/pulls/255/comments"},"review_comment":{"href":"https://api.github.com/repos/ushahidi/platform-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ushahidi/platform-client/pulls/255/commits"},"statuses":{"href":"https://api.github.com/repos/ushahidi/platform-client/statuses/a542acaa5709fa8bceedc382fdf55e45558b6573"}}}}
{"actor":{"display_login":"rjmackay"}}