{"action":"created","issue":{"url":"https://api.github.com/repos/OpenGeoscience/geojs/issues/651","repository_url":"https://api.github.com/repos/OpenGeoscience/geojs","labels_url":"https://api.github.com/repos/OpenGeoscience/geojs/issues/651/labels{/name}","comments_url":"https://api.github.com/repos/OpenGeoscience/geojs/issues/651/comments","events_url":"https://api.github.com/repos/OpenGeoscience/geojs/issues/651/events","html_url":"https://github.com/OpenGeoscience/geojs/pull/651","id":193573693,"number":651,"title":"Use firefox and xvfb to test webgl and examples.","user":{"login":"manthey","id":8781639,"avatar_url":"https://avatars.githubusercontent.com/u/8781639?v=3","gravatar_id":"","url":"https://api.github.com/users/manthey","html_url":"https://github.com/manthey","followers_url":"https://api.github.com/users/manthey/followers","following_url":"https://api.github.com/users/manthey/following{/other_user}","gists_url":"https://api.github.com/users/manthey/gists{/gist_id}","starred_url":"https://api.github.com/users/manthey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manthey/subscriptions","organizations_url":"https://api.github.com/users/manthey/orgs","repos_url":"https://api.github.com/users/manthey/repos","events_url":"https://api.github.com/users/manthey/events{/privacy}","received_events_url":"https://api.github.com/users/manthey/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-12-05T18:25:44Z","updated_at":"2016-12-05T19:45:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OpenGeoscience/geojs/pulls/651","html_url":"https://github.com/OpenGeoscience/geojs/pull/651","diff_url":"https://github.com/OpenGeoscience/geojs/pull/651.diff","patch_url":"https://github.com/OpenGeoscience/geojs/pull/651.patch"},"body":"To test this locally, make sure you have xvfb, firefox, and mesa installed.  The ci tests will no longer work under windows, as some environment variables are set in the npm commands.\r\n\r\nWhen you run 'npm run start' and visit 127.0.0.1:9876/debug.html, all tests (both gl and non-gl) are run.  The ci tests run the unit tests in PhantomJS and the gl tests in Firefox.\r\n\r\nThere was a problem running the canvas tests in Chrome via karma debug, which has been fixed.\r\n\r\nSo far this has only two of the many selenium tests moved to headless testing.  It is enough to show the technique.  For non-canvas selenium tests, more work will be needed (using screenshots of xvfb rather than asking for the canvas's contents)."},"comment":{"url":"https://api.github.com/repos/OpenGeoscience/geojs/issues/comments/264956172","html_url":"https://github.com/OpenGeoscience/geojs/pull/651#issuecomment-264956172","issue_url":"https://api.github.com/repos/OpenGeoscience/geojs/issues/651","id":264956172,"user":{"login":"manthey","id":8781639,"avatar_url":"https://avatars.githubusercontent.com/u/8781639?v=3","gravatar_id":"","url":"https://api.github.com/users/manthey","html_url":"https://github.com/manthey","followers_url":"https://api.github.com/users/manthey/followers","following_url":"https://api.github.com/users/manthey/following{/other_user}","gists_url":"https://api.github.com/users/manthey/gists{/gist_id}","starred_url":"https://api.github.com/users/manthey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manthey/subscriptions","organizations_url":"https://api.github.com/users/manthey/orgs","repos_url":"https://api.github.com/users/manthey/repos","events_url":"https://api.github.com/users/manthey/events{/privacy}","received_events_url":"https://api.github.com/users/manthey/received_events","type":"User","site_admin":false},"created_at":"2016-12-05T19:45:31Z","updated_at":"2016-12-05T19:45:31Z","body":"I agree that it is odd to need to run ctest to get the data.  It is probably just ignorance on my part, but I'm not sure how to get ctest to download the data without running `make` as an explicit step in the process.  For the examples, directly linking to girder would be fine, as we expect web connectivity anyway.  Eventually, though, I'd like to see us testing the examples as part of the CI (issue #329), for which purpose downloading the data makes some sense."}}
{"actor":{"display_login":"manthey"}}