{"action":"closed","number":29,"pull_request":{"url":"https://api.github.com/repos/mapbox/team-directory/pulls/29","id":90119185,"html_url":"https://github.com/mapbox/team-directory/pull/29","diff_url":"https://github.com/mapbox/team-directory/pull/29.diff","patch_url":"https://github.com/mapbox/team-directory/pull/29.patch","issue_url":"https://api.github.com/repos/mapbox/team-directory/issues/29","number":29,"state":"closed","locked":false,"title":"Update vcf vCard module from 0.2.0 → 1.1.2","user":{"login":"jhermsmeier","id":244907,"avatar_url":"https://avatars.githubusercontent.com/u/244907?v=3","gravatar_id":"","url":"https://api.github.com/users/jhermsmeier","html_url":"https://github.com/jhermsmeier","followers_url":"https://api.github.com/users/jhermsmeier/followers","following_url":"https://api.github.com/users/jhermsmeier/following{/other_user}","gists_url":"https://api.github.com/users/jhermsmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/jhermsmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhermsmeier/subscriptions","organizations_url":"https://api.github.com/users/jhermsmeier/orgs","repos_url":"https://api.github.com/users/jhermsmeier/repos","events_url":"https://api.github.com/users/jhermsmeier/events{/privacy}","received_events_url":"https://api.github.com/users/jhermsmeier/received_events","type":"User","site_admin":false},"body":"Hello, hello\n\nI noticed that the `vcf` module was a bit outdated, and took a quick stab at updating it.\n\nThe only things in need of change (as far as I can see) were the property names,\nas they are now automatically dash-cased and should be written in camel-case.\n### Module Changes\n\nOther changes since `0.2.0`\n\n**Fixes:**\n- Fix trim empty lines in `.normalize()`\n- Fix missing return in `.get()`\n- Parse JSON in `.fromJSON()`, if necessary\n- Fix trim empty lines in `.parse()`\n- Fix regex pattern to not match values\n- Fix parsing `BEGIN`/`END`\n- Fix rendering empty properties with `undefined` as value\n\n**API:**\n- Add `.toJCard([version='4.0'])`\n- Add `.setProperty()`\n- Add test case for base64 encoded photos\n- Add `vCard.parseMultiple()`\n- Implement `vCard.format()`, `vCard#toString()`\n- Implement `vCard.fromJSON()`, `Property.fromJSON()`\n- Remove data-types, parameters, properties\n- Remove cardinality guard\n","created_at":"2016-10-20T01:26:07Z","updated_at":"2016-11-17T17:00:21Z","closed_at":"2016-11-17T17:00:20Z","merged_at":"2016-11-17T17:00:20Z","merge_commit_sha":"d5f2585bf83a0976abb724a0e28898a67f50277f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapbox/team-directory/pulls/29/commits","review_comments_url":"https://api.github.com/repos/mapbox/team-directory/pulls/29/comments","review_comment_url":"https://api.github.com/repos/mapbox/team-directory/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapbox/team-directory/issues/29/comments","statuses_url":"https://api.github.com/repos/mapbox/team-directory/statuses/7247b7f96718893e7fec2ddb81fe455526886c5e","head":{"label":"jhermsmeier:update-vcf","ref":"update-vcf","sha":"7247b7f96718893e7fec2ddb81fe455526886c5e","user":{"login":"jhermsmeier","id":244907,"avatar_url":"https://avatars.githubusercontent.com/u/244907?v=3","gravatar_id":"","url":"https://api.github.com/users/jhermsmeier","html_url":"https://github.com/jhermsmeier","followers_url":"https://api.github.com/users/jhermsmeier/followers","following_url":"https://api.github.com/users/jhermsmeier/following{/other_user}","gists_url":"https://api.github.com/users/jhermsmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/jhermsmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhermsmeier/subscriptions","organizations_url":"https://api.github.com/users/jhermsmeier/orgs","repos_url":"https://api.github.com/users/jhermsmeier/repos","events_url":"https://api.github.com/users/jhermsmeier/events{/privacy}","received_events_url":"https://api.github.com/users/jhermsmeier/received_events","type":"User","site_admin":false},"repo":{"id":71409552,"name":"team-directory","full_name":"jhermsmeier/team-directory","owner":{"login":"jhermsmeier","id":244907,"avatar_url":"https://avatars.githubusercontent.com/u/244907?v=3","gravatar_id":"","url":"https://api.github.com/users/jhermsmeier","html_url":"https://github.com/jhermsmeier","followers_url":"https://api.github.com/users/jhermsmeier/followers","following_url":"https://api.github.com/users/jhermsmeier/following{/other_user}","gists_url":"https://api.github.com/users/jhermsmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/jhermsmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhermsmeier/subscriptions","organizations_url":"https://api.github.com/users/jhermsmeier/orgs","repos_url":"https://api.github.com/users/jhermsmeier/repos","events_url":"https://api.github.com/users/jhermsmeier/events{/privacy}","received_events_url":"https://api.github.com/users/jhermsmeier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jhermsmeier/team-directory","description":"A rolodex for teams","fork":true,"url":"https://api.github.com/repos/jhermsmeier/team-directory","forks_url":"https://api.github.com/repos/jhermsmeier/team-directory/forks","keys_url":"https://api.github.com/repos/jhermsmeier/team-directory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jhermsmeier/team-directory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jhermsmeier/team-directory/teams","hooks_url":"https://api.github.com/repos/jhermsmeier/team-directory/hooks","issue_events_url":"https://api.github.com/repos/jhermsmeier/team-directory/issues/events{/number}","events_url":"https://api.github.com/repos/jhermsmeier/team-directory/events","assignees_url":"https://api.github.com/repos/jhermsmeier/team-directory/assignees{/user}","branches_url":"https://api.github.com/repos/jhermsmeier/team-directory/branches{/branch}","tags_url":"https://api.github.com/repos/jhermsmeier/team-directory/tags","blobs_url":"https://api.github.com/repos/jhermsmeier/team-directory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jhermsmeier/team-directory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jhermsmeier/team-directory/git/refs{/sha}","trees_url":"https://api.github.com/repos/jhermsmeier/team-directory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jhermsmeier/team-directory/statuses/{sha}","languages_url":"https://api.github.com/repos/jhermsmeier/team-directory/languages","stargazers_url":"https://api.github.com/repos/jhermsmeier/team-directory/stargazers","contributors_url":"https://api.github.com/repos/jhermsmeier/team-directory/contributors","subscribers_url":"https://api.github.com/repos/jhermsmeier/team-directory/subscribers","subscription_url":"https://api.github.com/repos/jhermsmeier/team-directory/subscription","commits_url":"https://api.github.com/repos/jhermsmeier/team-directory/commits{/sha}","git_commits_url":"https://api.github.com/repos/jhermsmeier/team-directory/git/commits{/sha}","comments_url":"https://api.github.com/repos/jhermsmeier/team-directory/comments{/number}","issue_comment_url":"https://api.github.com/repos/jhermsmeier/team-directory/issues/comments{/number}","contents_url":"https://api.github.com/repos/jhermsmeier/team-directory/contents/{+path}","compare_url":"https://api.github.com/repos/jhermsmeier/team-directory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jhermsmeier/team-directory/merges","archive_url":"https://api.github.com/repos/jhermsmeier/team-directory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jhermsmeier/team-directory/downloads","issues_url":"https://api.github.com/repos/jhermsmeier/team-directory/issues{/number}","pulls_url":"https://api.github.com/repos/jhermsmeier/team-directory/pulls{/number}","milestones_url":"https://api.github.com/repos/jhermsmeier/team-directory/milestones{/number}","notifications_url":"https://api.github.com/repos/jhermsmeier/team-directory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jhermsmeier/team-directory/labels{/name}","releases_url":"https://api.github.com/repos/jhermsmeier/team-directory/releases{/id}","deployments_url":"https://api.github.com/repos/jhermsmeier/team-directory/deployments","created_at":"2016-10-20T00:02:34Z","updated_at":"2016-10-20T00:02:35Z","pushed_at":"2016-10-20T01:15:36Z","git_url":"git://github.com/jhermsmeier/team-directory.git","ssh_url":"git@github.com:jhermsmeier/team-directory.git","clone_url":"https://github.com/jhermsmeier/team-directory.git","svn_url":"https://github.com/jhermsmeier/team-directory","homepage":"","size":922,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapbox:master","ref":"master","sha":"52c257e760de485fd54c9dad0f1a88bf143cf71c","user":{"login":"mapbox","id":600935,"avatar_url":"https://avatars.githubusercontent.com/u/600935?v=3","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":45922444,"name":"team-directory","full_name":"mapbox/team-directory","owner":{"login":"mapbox","id":600935,"avatar_url":"https://avatars.githubusercontent.com/u/600935?v=3","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/team-directory","description":"A rolodex for teams","fork":false,"url":"https://api.github.com/repos/mapbox/team-directory","forks_url":"https://api.github.com/repos/mapbox/team-directory/forks","keys_url":"https://api.github.com/repos/mapbox/team-directory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/team-directory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/team-directory/teams","hooks_url":"https://api.github.com/repos/mapbox/team-directory/hooks","issue_events_url":"https://api.github.com/repos/mapbox/team-directory/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/team-directory/events","assignees_url":"https://api.github.com/repos/mapbox/team-directory/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/team-directory/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/team-directory/tags","blobs_url":"https://api.github.com/repos/mapbox/team-directory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/team-directory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/team-directory/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/team-directory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/team-directory/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/team-directory/languages","stargazers_url":"https://api.github.com/repos/mapbox/team-directory/stargazers","contributors_url":"https://api.github.com/repos/mapbox/team-directory/contributors","subscribers_url":"https://api.github.com/repos/mapbox/team-directory/subscribers","subscription_url":"https://api.github.com/repos/mapbox/team-directory/subscription","commits_url":"https://api.github.com/repos/mapbox/team-directory/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/team-directory/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/team-directory/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/team-directory/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/team-directory/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/team-directory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/team-directory/merges","archive_url":"https://api.github.com/repos/mapbox/team-directory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/team-directory/downloads","issues_url":"https://api.github.com/repos/mapbox/team-directory/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/team-directory/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/team-directory/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/team-directory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/team-directory/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/team-directory/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/team-directory/deployments","created_at":"2015-11-10T15:52:17Z","updated_at":"2016-11-15T12:59:47Z","pushed_at":"2016-11-17T17:00:20Z","git_url":"git://github.com/mapbox/team-directory.git","ssh_url":"git@github.com:mapbox/team-directory.git","clone_url":"https://github.com/mapbox/team-directory.git","svn_url":"https://github.com/mapbox/team-directory","homepage":"","size":921,"stargazers_count":116,"watchers_count":116,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":9,"forks":16,"open_issues":9,"watchers":116,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapbox/team-directory/pulls/29"},"html":{"href":"https://github.com/mapbox/team-directory/pull/29"},"issue":{"href":"https://api.github.com/repos/mapbox/team-directory/issues/29"},"comments":{"href":"https://api.github.com/repos/mapbox/team-directory/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/mapbox/team-directory/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/mapbox/team-directory/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapbox/team-directory/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/mapbox/team-directory/statuses/7247b7f96718893e7fec2ddb81fe455526886c5e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tmcw","id":32314,"avatar_url":"https://avatars.githubusercontent.com/u/32314?v=3","gravatar_id":"","url":"https://api.github.com/users/tmcw","html_url":"https://github.com/tmcw","followers_url":"https://api.github.com/users/tmcw/followers","following_url":"https://api.github.com/users/tmcw/following{/other_user}","gists_url":"https://api.github.com/users/tmcw/gists{/gist_id}","starred_url":"https://api.github.com/users/tmcw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmcw/subscriptions","organizations_url":"https://api.github.com/users/tmcw/orgs","repos_url":"https://api.github.com/users/tmcw/repos","events_url":"https://api.github.com/users/tmcw/events{/privacy}","received_events_url":"https://api.github.com/users/tmcw/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":8,"deletions":8,"changed_files":3}}
{"actor":{"display_login":"tmcw"}}