{"action":"closed","number":4287,"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/4287","id":51474453,"html_url":"https://github.com/facebook/react-native/pull/4287","diff_url":"https://github.com/facebook/react-native/pull/4287.diff","patch_url":"https://github.com/facebook/react-native/pull/4287.patch","issue_url":"https://api.github.com/repos/facebook/react-native/issues/4287","number":4287,"state":"closed","locked":false,"title":"Fixed crash when polyfillGlobal attempts to polyfill a property with a getter","user":{"login":"brianreavis","id":118480,"avatar_url":"https://avatars.githubusercontent.com/u/118480?v=3","gravatar_id":"","url":"https://api.github.com/users/brianreavis","html_url":"https://github.com/brianreavis","followers_url":"https://api.github.com/users/brianreavis/followers","following_url":"https://api.github.com/users/brianreavis/following{/other_user}","gists_url":"https://api.github.com/users/brianreavis/gists{/gist_id}","starred_url":"https://api.github.com/users/brianreavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianreavis/subscriptions","organizations_url":"https://api.github.com/users/brianreavis/orgs","repos_url":"https://api.github.com/users/brianreavis/repos","events_url":"https://api.github.com/users/brianreavis/events{/privacy}","received_events_url":"https://api.github.com/users/brianreavis/received_events","type":"User","site_admin":false},"body":"This PR fixes an exception that occurs when `polyfillGlobal()` attempts to polyfill a property that has a getter defined instead of a value. This seems to affect `geolocation` in `setUpGeolocation()` on device. My app was working last night... then I woke up to it not working (screenshot below). Maybe the OS updated overnight? Who knows... regardless, this should be safer.\r\n\r\n```\r\nInvalid property. 'value' present on property with getter or setter.\r\n```\r\n\r\nThe fix boils down to these lines:\r\nhttps://github.com/facebook/react-native/pull/4287/files#diff-5fb096262c3668e49ebaf855d35cdd49R40\r\n\r\n<img src=\"https://cloud.githubusercontent.com/assets/118480/11326173/7c2fd564-911f-11e5-9ad8-df27a74ac04f.PNG\" width=\"300\" />","created_at":"2015-11-22T20:58:25Z","updated_at":"2016-03-20T16:14:21Z","closed_at":"2016-03-20T16:14:20Z","merged_at":null,"merge_commit_sha":"6fd51556d0e90240fe3637095365ad26ace16b92","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react-native/pulls/4287/commits","review_comments_url":"https://api.github.com/repos/facebook/react-native/pulls/4287/comments","review_comment_url":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/4287/comments","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/46fa28b9719e6e28a404f9ca4985513c3951c0ac","head":{"label":"naturalatlas:init-js-fixes","ref":"init-js-fixes","sha":"46fa28b9719e6e28a404f9ca4985513c3951c0ac","user":{"login":"naturalatlas","id":6006167,"avatar_url":"https://avatars.githubusercontent.com/u/6006167?v=3","gravatar_id":"","url":"https://api.github.com/users/naturalatlas","html_url":"https://github.com/naturalatlas","followers_url":"https://api.github.com/users/naturalatlas/followers","following_url":"https://api.github.com/users/naturalatlas/following{/other_user}","gists_url":"https://api.github.com/users/naturalatlas/gists{/gist_id}","starred_url":"https://api.github.com/users/naturalatlas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naturalatlas/subscriptions","organizations_url":"https://api.github.com/users/naturalatlas/orgs","repos_url":"https://api.github.com/users/naturalatlas/repos","events_url":"https://api.github.com/users/naturalatlas/events{/privacy}","received_events_url":"https://api.github.com/users/naturalatlas/received_events","type":"Organization","site_admin":false},"repo":{"id":46676222,"name":"react-native","full_name":"naturalatlas/react-native","owner":{"login":"naturalatlas","id":6006167,"avatar_url":"https://avatars.githubusercontent.com/u/6006167?v=3","gravatar_id":"","url":"https://api.github.com/users/naturalatlas","html_url":"https://github.com/naturalatlas","followers_url":"https://api.github.com/users/naturalatlas/followers","following_url":"https://api.github.com/users/naturalatlas/following{/other_user}","gists_url":"https://api.github.com/users/naturalatlas/gists{/gist_id}","starred_url":"https://api.github.com/users/naturalatlas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naturalatlas/subscriptions","organizations_url":"https://api.github.com/users/naturalatlas/orgs","repos_url":"https://api.github.com/users/naturalatlas/repos","events_url":"https://api.github.com/users/naturalatlas/events{/privacy}","received_events_url":"https://api.github.com/users/naturalatlas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/naturalatlas/react-native","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/naturalatlas/react-native","forks_url":"https://api.github.com/repos/naturalatlas/react-native/forks","keys_url":"https://api.github.com/repos/naturalatlas/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/naturalatlas/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/naturalatlas/react-native/teams","hooks_url":"https://api.github.com/repos/naturalatlas/react-native/hooks","issue_events_url":"https://api.github.com/repos/naturalatlas/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/naturalatlas/react-native/events","assignees_url":"https://api.github.com/repos/naturalatlas/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/naturalatlas/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/naturalatlas/react-native/tags","blobs_url":"https://api.github.com/repos/naturalatlas/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/naturalatlas/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/naturalatlas/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/naturalatlas/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/naturalatlas/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/naturalatlas/react-native/languages","stargazers_url":"https://api.github.com/repos/naturalatlas/react-native/stargazers","contributors_url":"https://api.github.com/repos/naturalatlas/react-native/contributors","subscribers_url":"https://api.github.com/repos/naturalatlas/react-native/subscribers","subscription_url":"https://api.github.com/repos/naturalatlas/react-native/subscription","commits_url":"https://api.github.com/repos/naturalatlas/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/naturalatlas/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/naturalatlas/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/naturalatlas/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/naturalatlas/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/naturalatlas/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/naturalatlas/react-native/merges","archive_url":"https://api.github.com/repos/naturalatlas/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/naturalatlas/react-native/downloads","issues_url":"https://api.github.com/repos/naturalatlas/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/naturalatlas/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/naturalatlas/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/naturalatlas/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/naturalatlas/react-native/labels{/name}","releases_url":"https://api.github.com/repos/naturalatlas/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/naturalatlas/react-native/deployments","created_at":"2015-11-22T19:31:08Z","updated_at":"2015-11-22T19:31:15Z","pushed_at":"2015-12-07T03:48:48Z","git_url":"git://github.com/naturalatlas/react-native.git","ssh_url":"git@github.com:naturalatlas/react-native.git","clone_url":"https://github.com/naturalatlas/react-native.git","svn_url":"https://github.com/naturalatlas/react-native","homepage":"http://facebook.github.io/react-native/","size":33758,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"0a3694ce48be8991839c42aab2586202a12d43aa","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":29028775,"name":"react-native","full_name":"facebook/react-native","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react-native","description":"A framework for building native apps with React.","fork":false,"url":"https://api.github.com/repos/facebook/react-native","forks_url":"https://api.github.com/repos/facebook/react-native/forks","keys_url":"https://api.github.com/repos/facebook/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react-native/teams","hooks_url":"https://api.github.com/repos/facebook/react-native/hooks","issue_events_url":"https://api.github.com/repos/facebook/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react-native/events","assignees_url":"https://api.github.com/repos/facebook/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react-native/tags","blobs_url":"https://api.github.com/repos/facebook/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react-native/languages","stargazers_url":"https://api.github.com/repos/facebook/react-native/stargazers","contributors_url":"https://api.github.com/repos/facebook/react-native/contributors","subscribers_url":"https://api.github.com/repos/facebook/react-native/subscribers","subscription_url":"https://api.github.com/repos/facebook/react-native/subscription","commits_url":"https://api.github.com/repos/facebook/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react-native/merges","archive_url":"https://api.github.com/repos/facebook/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react-native/downloads","issues_url":"https://api.github.com/repos/facebook/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react-native/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react-native/deployments","created_at":"2015-01-09T18:10:16Z","updated_at":"2016-03-20T16:12:20Z","pushed_at":"2016-03-20T15:47:55Z","git_url":"git://github.com/facebook/react-native.git","ssh_url":"git@github.com:facebook/react-native.git","clone_url":"https://github.com/facebook/react-native.git","svn_url":"https://github.com/facebook/react-native","homepage":"http://facebook.github.io/react-native/","size":83918,"stargazers_count":29022,"watchers_count":29022,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5531,"mirror_url":null,"open_issues_count":967,"forks":5531,"open_issues":967,"watchers":29022,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/4287"},"html":{"href":"https://github.com/facebook/react-native/pull/4287"},"issue":{"href":"https://api.github.com/repos/facebook/react-native/issues/4287"},"comments":{"href":"https://api.github.com/repos/facebook/react-native/issues/4287/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react-native/pulls/4287/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react-native/pulls/4287/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react-native/statuses/46fa28b9719e6e28a404f9ca4985513c3951c0ac"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":12,"review_comments":0,"commits":3,"additions":205,"deletions":44,"changed_files":4}}