{"action":"closed","number":2054,"pull_request":{"url":"https://api.github.com/repos/angular/angular-cli/pulls/2054","id":84790025,"html_url":"https://github.com/angular/angular-cli/pull/2054","diff_url":"https://github.com/angular/angular-cli/pull/2054.diff","patch_url":"https://github.com/angular/angular-cli/pull/2054.patch","issue_url":"https://api.github.com/repos/angular/angular-cli/issues/2054","number":2054,"state":"closed","locked":false,"title":"chore(e2e): bump protractor to 4.0.5","user":{"login":"cexbrayat","id":411874,"avatar_url":"https://avatars.githubusercontent.com/u/411874?v=3","gravatar_id":"","url":"https://api.github.com/users/cexbrayat","html_url":"https://github.com/cexbrayat","followers_url":"https://api.github.com/users/cexbrayat/followers","following_url":"https://api.github.com/users/cexbrayat/following{/other_user}","gists_url":"https://api.github.com/users/cexbrayat/gists{/gist_id}","starred_url":"https://api.github.com/users/cexbrayat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cexbrayat/subscriptions","organizations_url":"https://api.github.com/users/cexbrayat/orgs","repos_url":"https://api.github.com/users/cexbrayat/repos","events_url":"https://api.github.com/users/cexbrayat/events{/privacy}","received_events_url":"https://api.github.com/users/cexbrayat/received_events","type":"User","site_admin":false},"body":"Fixes #1977 \r\n\r\nProtractor 4.0.3 has a critical bug, and will return a success code even if the tests are failing or if there is no `ng serve` running... (see the related https://github.com/angular/protractor/issues/3505)\r\n\r\n4.0.5 fixes it, but it now relies on `@types/node` (as stated in the changelog https://github.com/angular/protractor/blob/master/CHANGELOG.md#405), which conflicts with the declarations in the `typings.d.ts` file. As they are now duplicated, removing them from the `typings.d.ts` file solves the problem.\r\n\r\n`declare var require: any;`  has to be added to the `test.ts` file because this is not the same `NodeRequire` that `@types/node` declares, but a `WebpackRequire` with the `context` field.\r\n\r\nThere is probably a more elegant solution to solve this, but at least this one unblocked us.","created_at":"2016-09-11T15:54:04Z","updated_at":"2016-09-12T03:30:06Z","closed_at":"2016-09-12T03:30:05Z","merged_at":"2016-09-12T03:30:05Z","merge_commit_sha":"a4fad1a540a2c6604b8c2c5d2e7591e651b3e02a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular-cli/pulls/2054/commits","review_comments_url":"https://api.github.com/repos/angular/angular-cli/pulls/2054/comments","review_comment_url":"https://api.github.com/repos/angular/angular-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular-cli/issues/2054/comments","statuses_url":"https://api.github.com/repos/angular/angular-cli/statuses/ad062baf495a9fbdd1146490eb033ae4abd0458f","head":{"label":"cexbrayat:fix/1977-protractor","ref":"fix/1977-protractor","sha":"ad062baf495a9fbdd1146490eb033ae4abd0458f","user":{"login":"cexbrayat","id":411874,"avatar_url":"https://avatars.githubusercontent.com/u/411874?v=3","gravatar_id":"","url":"https://api.github.com/users/cexbrayat","html_url":"https://github.com/cexbrayat","followers_url":"https://api.github.com/users/cexbrayat/followers","following_url":"https://api.github.com/users/cexbrayat/following{/other_user}","gists_url":"https://api.github.com/users/cexbrayat/gists{/gist_id}","starred_url":"https://api.github.com/users/cexbrayat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cexbrayat/subscriptions","organizations_url":"https://api.github.com/users/cexbrayat/orgs","repos_url":"https://api.github.com/users/cexbrayat/repos","events_url":"https://api.github.com/users/cexbrayat/events{/privacy}","received_events_url":"https://api.github.com/users/cexbrayat/received_events","type":"User","site_admin":false},"repo":{"id":52079649,"name":"angular-cli","full_name":"cexbrayat/angular-cli","owner":{"login":"cexbrayat","id":411874,"avatar_url":"https://avatars.githubusercontent.com/u/411874?v=3","gravatar_id":"","url":"https://api.github.com/users/cexbrayat","html_url":"https://github.com/cexbrayat","followers_url":"https://api.github.com/users/cexbrayat/followers","following_url":"https://api.github.com/users/cexbrayat/following{/other_user}","gists_url":"https://api.github.com/users/cexbrayat/gists{/gist_id}","starred_url":"https://api.github.com/users/cexbrayat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cexbrayat/subscriptions","organizations_url":"https://api.github.com/users/cexbrayat/orgs","repos_url":"https://api.github.com/users/cexbrayat/repos","events_url":"https://api.github.com/users/cexbrayat/events{/privacy}","received_events_url":"https://api.github.com/users/cexbrayat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cexbrayat/angular-cli","description":"","fork":true,"url":"https://api.github.com/repos/cexbrayat/angular-cli","forks_url":"https://api.github.com/repos/cexbrayat/angular-cli/forks","keys_url":"https://api.github.com/repos/cexbrayat/angular-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cexbrayat/angular-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cexbrayat/angular-cli/teams","hooks_url":"https://api.github.com/repos/cexbrayat/angular-cli/hooks","issue_events_url":"https://api.github.com/repos/cexbrayat/angular-cli/issues/events{/number}","events_url":"https://api.github.com/repos/cexbrayat/angular-cli/events","assignees_url":"https://api.github.com/repos/cexbrayat/angular-cli/assignees{/user}","branches_url":"https://api.github.com/repos/cexbrayat/angular-cli/branches{/branch}","tags_url":"https://api.github.com/repos/cexbrayat/angular-cli/tags","blobs_url":"https://api.github.com/repos/cexbrayat/angular-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cexbrayat/angular-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cexbrayat/angular-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/cexbrayat/angular-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cexbrayat/angular-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/cexbrayat/angular-cli/languages","stargazers_url":"https://api.github.com/repos/cexbrayat/angular-cli/stargazers","contributors_url":"https://api.github.com/repos/cexbrayat/angular-cli/contributors","subscribers_url":"https://api.github.com/repos/cexbrayat/angular-cli/subscribers","subscription_url":"https://api.github.com/repos/cexbrayat/angular-cli/subscription","commits_url":"https://api.github.com/repos/cexbrayat/angular-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/cexbrayat/angular-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/cexbrayat/angular-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/cexbrayat/angular-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/cexbrayat/angular-cli/contents/{+path}","compare_url":"https://api.github.com/repos/cexbrayat/angular-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cexbrayat/angular-cli/merges","archive_url":"https://api.github.com/repos/cexbrayat/angular-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cexbrayat/angular-cli/downloads","issues_url":"https://api.github.com/repos/cexbrayat/angular-cli/issues{/number}","pulls_url":"https://api.github.com/repos/cexbrayat/angular-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/cexbrayat/angular-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/cexbrayat/angular-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cexbrayat/angular-cli/labels{/name}","releases_url":"https://api.github.com/repos/cexbrayat/angular-cli/releases{/id}","deployments_url":"https://api.github.com/repos/cexbrayat/angular-cli/deployments","created_at":"2016-02-19T10:14:10Z","updated_at":"2016-02-19T10:14:11Z","pushed_at":"2016-09-11T16:02:42Z","git_url":"git://github.com/cexbrayat/angular-cli.git","ssh_url":"git@github.com:cexbrayat/angular-cli.git","clone_url":"https://github.com/cexbrayat/angular-cli.git","svn_url":"https://github.com/cexbrayat/angular-cli","homepage":null,"size":1423,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"ba668a8862725f894da3f9608871756507096bb9","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":36891867,"name":"angular-cli","full_name":"angular/angular-cli","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular-cli","description":"CLI tool for Angular2","fork":false,"url":"https://api.github.com/repos/angular/angular-cli","forks_url":"https://api.github.com/repos/angular/angular-cli/forks","keys_url":"https://api.github.com/repos/angular/angular-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular-cli/teams","hooks_url":"https://api.github.com/repos/angular/angular-cli/hooks","issue_events_url":"https://api.github.com/repos/angular/angular-cli/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular-cli/events","assignees_url":"https://api.github.com/repos/angular/angular-cli/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular-cli/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular-cli/tags","blobs_url":"https://api.github.com/repos/angular/angular-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular-cli/languages","stargazers_url":"https://api.github.com/repos/angular/angular-cli/stargazers","contributors_url":"https://api.github.com/repos/angular/angular-cli/contributors","subscribers_url":"https://api.github.com/repos/angular/angular-cli/subscribers","subscription_url":"https://api.github.com/repos/angular/angular-cli/subscription","commits_url":"https://api.github.com/repos/angular/angular-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular-cli/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular-cli/merges","archive_url":"https://api.github.com/repos/angular/angular-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular-cli/downloads","issues_url":"https://api.github.com/repos/angular/angular-cli/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular-cli/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular-cli/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular-cli/deployments","created_at":"2015-06-04T19:49:37Z","updated_at":"2016-09-12T02:55:33Z","pushed_at":"2016-09-12T03:30:06Z","git_url":"git://github.com/angular/angular-cli.git","ssh_url":"git@github.com:angular/angular-cli.git","clone_url":"https://github.com/angular/angular-cli.git","svn_url":"https://github.com/angular/angular-cli","homepage":"","size":3380,"stargazers_count":3500,"watchers_count":3500,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":520,"mirror_url":null,"open_issues_count":298,"forks":520,"open_issues":298,"watchers":3500,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular-cli/pulls/2054"},"html":{"href":"https://github.com/angular/angular-cli/pull/2054"},"issue":{"href":"https://api.github.com/repos/angular/angular-cli/issues/2054"},"comments":{"href":"https://api.github.com/repos/angular/angular-cli/issues/2054/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular-cli/pulls/2054/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular-cli/pulls/2054/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular-cli/statuses/ad062baf495a9fbdd1146490eb033ae4abd0458f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"hansl","id":681969,"avatar_url":"https://avatars.githubusercontent.com/u/681969?v=3","gravatar_id":"","url":"https://api.github.com/users/hansl","html_url":"https://github.com/hansl","followers_url":"https://api.github.com/users/hansl/followers","following_url":"https://api.github.com/users/hansl/following{/other_user}","gists_url":"https://api.github.com/users/hansl/gists{/gist_id}","starred_url":"https://api.github.com/users/hansl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hansl/subscriptions","organizations_url":"https://api.github.com/users/hansl/orgs","repos_url":"https://api.github.com/users/hansl/repos","events_url":"https://api.github.com/users/hansl/events{/privacy}","received_events_url":"https://api.github.com/users/hansl/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":2,"deletions":4,"changed_files":3}}
{"actor":{"display_login":"hansl"}}