{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/74873342","id":74873342,"diff_hunk":"@@ -710,12 +713,32 @@ func (gce *GCECloud) EnsureLoadBalancer(clusterName string, apiService *api.Serv\n \t\tglog.Infof(\"EnsureLoadBalancer(%v(%v)): deleted forwarding rule\", loadBalancerName, serviceName)\n \t}\n \tif tpExists && tpNeedsUpdate {\n-\t\tif err := gce.deleteTargetPool(loadBalancerName, gce.region); err != nil {\n+\t\thc := []*compute.HttpHealthCheck{}","path":"pkg/cloudprovider/providers/gce/gce.go","position":41,"original_position":41,"commit_id":"73c26671ea73f130d1c9d0b24f590309b4c057cc","original_commit_id":"ae6ad281e2400e4196f7d675f38cddfd951898b1","user":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"body":"Also, you seem to be allocating `hc` in this block but never using it...","created_at":"2016-08-16T04:03:22Z","updated_at":"2016-08-16T04:03:22Z","html_url":"https://github.com/kubernetes/kubernetes/pull/29409#discussion_r74873342","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/29409","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/74873342"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/29409#discussion_r74873342"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/29409"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/29409","id":78404829,"html_url":"https://github.com/kubernetes/kubernetes/pull/29409","diff_url":"https://github.com/kubernetes/kubernetes/pull/29409.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/29409.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/29409","number":29409,"state":"open","locked":false,"title":"Source IP Preservation for cloud lb services","user":{"login":"girishkalele","id":18541549,"avatar_url":"https://avatars.githubusercontent.com/u/18541549?v=3","gravatar_id":"","url":"https://api.github.com/users/girishkalele","html_url":"https://github.com/girishkalele","followers_url":"https://api.github.com/users/girishkalele/followers","following_url":"https://api.github.com/users/girishkalele/following{/other_user}","gists_url":"https://api.github.com/users/girishkalele/gists{/gist_id}","starred_url":"https://api.github.com/users/girishkalele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/girishkalele/subscriptions","organizations_url":"https://api.github.com/users/girishkalele/orgs","repos_url":"https://api.github.com/users/girishkalele/repos","events_url":"https://api.github.com/users/girishkalele/events{/privacy}","received_events_url":"https://api.github.com/users/girishkalele/received_events","type":"User","site_admin":false},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/29409)\n<!-- Reviewable:end -->\n","created_at":"2016-07-21T23:37:41Z","updated_at":"2016-08-16T04:03:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec5d8d6663143f96694027684db7f00a8cf0037a","assignee":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"assignees":[{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/29409/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/29409/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/29409/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/73c26671ea73f130d1c9d0b24f590309b4c057cc","head":{"label":"girishkalele:esipp-cloud-lb","ref":"esipp-cloud-lb","sha":"73c26671ea73f130d1c9d0b24f590309b4c057cc","user":{"login":"girishkalele","id":18541549,"avatar_url":"https://avatars.githubusercontent.com/u/18541549?v=3","gravatar_id":"","url":"https://api.github.com/users/girishkalele","html_url":"https://github.com/girishkalele","followers_url":"https://api.github.com/users/girishkalele/followers","following_url":"https://api.github.com/users/girishkalele/following{/other_user}","gists_url":"https://api.github.com/users/girishkalele/gists{/gist_id}","starred_url":"https://api.github.com/users/girishkalele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/girishkalele/subscriptions","organizations_url":"https://api.github.com/users/girishkalele/orgs","repos_url":"https://api.github.com/users/girishkalele/repos","events_url":"https://api.github.com/users/girishkalele/events{/privacy}","received_events_url":"https://api.github.com/users/girishkalele/received_events","type":"User","site_admin":false},"repo":{"id":58407800,"name":"kubernetes","full_name":"girishkalele/kubernetes","owner":{"login":"girishkalele","id":18541549,"avatar_url":"https://avatars.githubusercontent.com/u/18541549?v=3","gravatar_id":"","url":"https://api.github.com/users/girishkalele","html_url":"https://github.com/girishkalele","followers_url":"https://api.github.com/users/girishkalele/followers","following_url":"https://api.github.com/users/girishkalele/following{/other_user}","gists_url":"https://api.github.com/users/girishkalele/gists{/gist_id}","starred_url":"https://api.github.com/users/girishkalele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/girishkalele/subscriptions","organizations_url":"https://api.github.com/users/girishkalele/orgs","repos_url":"https://api.github.com/users/girishkalele/repos","events_url":"https://api.github.com/users/girishkalele/events{/privacy}","received_events_url":"https://api.github.com/users/girishkalele/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/girishkalele/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/girishkalele/kubernetes","forks_url":"https://api.github.com/repos/girishkalele/kubernetes/forks","keys_url":"https://api.github.com/repos/girishkalele/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/girishkalele/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/girishkalele/kubernetes/teams","hooks_url":"https://api.github.com/repos/girishkalele/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/girishkalele/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/girishkalele/kubernetes/events","assignees_url":"https://api.github.com/repos/girishkalele/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/girishkalele/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/girishkalele/kubernetes/tags","blobs_url":"https://api.github.com/repos/girishkalele/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/girishkalele/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/girishkalele/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/girishkalele/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/girishkalele/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/girishkalele/kubernetes/languages","stargazers_url":"https://api.github.com/repos/girishkalele/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/girishkalele/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/girishkalele/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/girishkalele/kubernetes/subscription","commits_url":"https://api.github.com/repos/girishkalele/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/girishkalele/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/girishkalele/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/girishkalele/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/girishkalele/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/girishkalele/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/girishkalele/kubernetes/merges","archive_url":"https://api.github.com/repos/girishkalele/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/girishkalele/kubernetes/downloads","issues_url":"https://api.github.com/repos/girishkalele/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/girishkalele/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/girishkalele/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/girishkalele/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/girishkalele/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/girishkalele/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/girishkalele/kubernetes/deployments","created_at":"2016-05-09T20:59:15Z","updated_at":"2016-05-09T20:59:30Z","pushed_at":"2016-08-16T04:01:26Z","git_url":"git://github.com/girishkalele/kubernetes.git","ssh_url":"git@github.com:girishkalele/kubernetes.git","clone_url":"https://github.com/girishkalele/kubernetes.git","svn_url":"https://github.com/girishkalele/kubernetes","homepage":"http://kubernetes.io","size":306209,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"431e7ce1ab9f6086d38538a28989741f0576114c","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-08-16T02:31:25Z","pushed_at":"2016-08-16T04:01:39Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":522812,"stargazers_count":16149,"watchers_count":16149,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5139,"mirror_url":null,"open_issues_count":4186,"forks":5139,"open_issues":4186,"watchers":16149,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/29409"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/29409"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/29409"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/29409/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/29409/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/29409/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/73c26671ea73f130d1c9d0b24f590309b4c057cc"}}}}
{"actor":{"display_login":"thockin"}}