{"action":"opened","issue":{"url":"https://api.github.com/repos/electron/electron/issues/5699","repository_url":"https://api.github.com/repos/electron/electron","labels_url":"https://api.github.com/repos/electron/electron/issues/5699/labels{/name}","comments_url":"https://api.github.com/repos/electron/electron/issues/5699/comments","events_url":"https://api.github.com/repos/electron/electron/issues/5699/events","html_url":"https://github.com/electron/electron/issues/5699","id":156856420,"number":5699,"title":"BrowserWindow([options]) fullscreenable documentation is probably obsolete","user":{"login":"andruhon","id":1694497,"avatar_url":"https://avatars.githubusercontent.com/u/1694497?v=3","gravatar_id":"","url":"https://api.github.com/users/andruhon","html_url":"https://github.com/andruhon","followers_url":"https://api.github.com/users/andruhon/followers","following_url":"https://api.github.com/users/andruhon/following{/other_user}","gists_url":"https://api.github.com/users/andruhon/gists{/gist_id}","starred_url":"https://api.github.com/users/andruhon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andruhon/subscriptions","organizations_url":"https://api.github.com/users/andruhon/orgs","repos_url":"https://api.github.com/users/andruhon/repos","events_url":"https://api.github.com/users/andruhon/events{/privacy}","received_events_url":"https://api.github.com/users/andruhon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-05-25T21:38:05Z","updated_at":"2016-05-25T21:38:05Z","closed_at":null,"body":"* Electron version: 1.1.3\r\n* Operating system: Windows 10 Pro x64\r\n\r\nDocumentation in https://github.com/electron/electron/blob/master/docs/api/browser-window.md on `fullscreenable` seems to be not exactly true.\r\n\r\n`fullscreenable` default value on windows seems to be the same as `fullscreen` option, not just false\r\n\r\nFor example:\r\nmain.js\r\n```JavaScript\r\n  mainWindow = new BrowserWindow({\r\n    width: 800, height: 600,\r\n    minWidth: 800, minHeight: 600,\r\n    center: true,\r\n    fullscreen: false,\r\n    autoHideMenuBar: true,\r\n    frame: false,\r\n    resizable: false\r\n  });\r\n```\r\n\r\nsomewhere in client code:\r\n```JavaScript\r\n        //...\r\n        let currentWindow = electron.remote.getCurrentWindow();\r\n        currentWindow.setFullScreen(true); //Does not switch to the fullscreen\r\n        //currentWindow.setFullScreen(false) and back to true  works when initial fullscreen:true\r\n        //...\r\n```\r\n\r\n**However** the code below seems to work as expected,\r\nmain.js\r\n```JavaScript\r\n  mainWindow = new BrowserWindow({\r\n    width: 800, height: 600,\r\n    minWidth: 800, minHeight: 600,\r\n    center: true,\r\n    fullscreen: false,\r\n    fullscreenable: true, //ADDED\r\n    autoHideMenuBar: true,\r\n    frame: false,\r\n    resizable: false\r\n  });\r\n```\r\n\r\nsomewhere in client code:\r\n```JavaScript\r\n        //...\r\n        let currentWindow = electron.remote.getCurrentWindow();\r\n        currentWindow.setFullScreen(true); //does switch to the fullscreen\r\n        //...\r\n```"}}
{"actor":{"display_login":"andruhon"}}