{"push_id":1272558963,"size":59,"distinct_size":2,"ref":"refs/heads/snapcraft","head":"63c92c591ceb4af4411eb1fa9e8f92bc5343c26e","before":"aa42bc781c6c1b49377b3e78bbd0df47a9004eb9","commits":[{"sha":"499880c4b4099f78a59f1ecc3ce4fdabfe97358c","author":{"name":"Dan Carley","email":"04c8d52955ea1a89c2f0ed83d99cd9b0c494607f@gmail.com"},"message":"trace: Redact all passwords and tokens in JSON\n\nExtend the regex that redacts the values of sensitive keys in JSON responses\nto include case-insensitive and substring matches of the key names\n\"password\" and \"token\".\n\nIt's quite common to provide credentials to 12factor[0] applications using\nenvironment variables. These can be unexpectedly leaked in the CLI output if\nyou run a command such as `CF_TRACE=true cf apps`, because the API endpoints\nfor space and application summaries always include `environment_json`.\n\nThis problem is mitigated by user-provided services[1], but the docs don't\nstate that it's a security feature and it would be good to make the default\nuse case safer.\n\nSome notes about the specific implementation, I have:\n\n- added `(?i)` to the regex to make it a case-insensitive match\n- added `[^\"]*` around the property name to match substrings\n- used the capture group `$1` to preserve the entire matched property name\n  in the replacement\n- removed the separate function calls for `access_token`, `refresh_token`\n  and `oldPassword` because these are now covered by the existing `token`\n  and `password` calls with the new regex\n- adjusted one of the test assertions to account for the fact that the value\n  of `token_type` is now also redacted. This is a side-effect of the\n  changes, but I don't think it's a bad thing\n\n[0]: http://12factor.net/config\n[1]: https://docs.cloudfoundry.org/devguide/services/user-provided.html","distinct":false,"url":"https://api.github.com/repos/elopio/cli/commits/499880c4b4099f78a59f1ecc3ce4fdabfe97358c"},{"sha":"0025cd4884984e17f9387aae922530f21120d70e","author":{"name":"Difan Zhao","email":"be0f7cff9bcfdb99e042345af79c1ebe36ef8955@pivotal.io"},"message":"Allow apps with 0 instances to be started\n\n[finishes #127824189]\n\nSigned-off-by: Luan Santos <lsantos@pivotal.io>","distinct":false,"url":"https://api.github.com/repos/elopio/cli/commits/0025cd4884984e17f9387aae922530f21120d70e"},{"sha":"8691ceb041def9de622dff09fdb3f1d90d814b10","author":{"name":"Luan Santos","email":"b1c40b5218d589acd313ed2644c3c9b03cf12ee8@pivotal.io"},"message":"fixup bad linebreak on i18n file\n\nSigned-off-by: Difan Zhao <dzhao@pivotal.io>","distinct":false,"url":"https://api.github.com/repos/elopio/cli/commits/8691ceb041def9de622dff09fdb3f1d90d814b10"},{"sha":"70cd0557a5513f24b851b19c8dc1e8a96a608733","author":{"name":"Luan Santos","email":"b1c40b5218d589acd313ed2644c3c9b03cf12ee8@pivotal.io"},"message":"Make `cf plugins` output alphabetical\n\n[finishes #128135489]","distinct":false,"url":"https://api.github.com/repos/elopio/cli/commits/70cd0557a5513f24b851b19c8dc1e8a96a608733"},{"sha":"ca5715166dfbb9acbf88c4345081b50d0061078f","author":{"name":"Anand Gaitonde","email":"53068674ce17ffc1f895b209f1a427e5819408f4@pivotal.io"},"message":"no more shadows\n\nSigned-off-by: Luan Santos <lsantos@pivotal.io>","distinct":false,"url":"https://api.github.com/repos/elopio/cli/commits/ca5715166dfbb9acbf88c4345081b50d0061078f"},{"sha":"5cb8b429d542f004d8d9f9d7317ee5a0ad4bd5d6","author":{"name":"Luan Santos","email":"b1c40b5218d589acd313ed2644c3c9b03cf12ee8@pivotal.io"},"message":"Sort plugins list alphabetically\n\n[finishes ##128135489]","distinct":false,"url":"https://api.github.com/repos/elopio/cli/commits/5cb8b429d542f004d8d9f9d7317ee5a0ad4bd5d6"},{"sha":"53c85fce5dd49b853f1a33f615cf7bd50c7eeba7","author":{"name":"Jeff Pak","email":"a669f783df468d50a1f9e9e709ddf8afda1a67a1@emc.com"},"message":"output stderr for plugin commands\n\n[fixes #128457169]\n\nSigned-off-by: Difan Zhao <dzhao@pivotal.io>","distinct":false,"url":"https://api.github.com/repos/elopio/cli/commits/53c85fce5dd49b853f1a33f615cf7bd50c7eeba7"},{"sha":"8599c8a4ad72adc66530fd9c425c700361957abf","author":{"name":"Shannon Coen","email":"e1fcf3bc53c4d96e8ef7b93f2887d354f16b00ea@users.noreply.github.com"},"message":"fixing links","distinct":false,"url":"https://api.github.com/repos/elopio/cli/commits/8599c8a4ad72adc66530fd9c425c700361957abf"},{"sha":"cb0a97ac0b5d0229f2e4f06052978ad0868541f5","author":{"name":"Luan Santos","email":"b1c40b5218d589acd313ed2644c3c9b03cf12ee8@pivotal.io"},"message":"Fix a few problems that arise with go 1.7\n\n[#128451573]","distinct":false,"url":"https://api.github.com/repos/elopio/cli/commits/cb0a97ac0b5d0229f2e4f06052978ad0868541f5"},{"sha":"46ff47241b97b141e0bfb52164975ff689c36ec2","author":{"name":"Luan Santos","email":"b1c40b5218d589acd313ed2644c3c9b03cf12ee8@pivotal.io"},"message":"Use absolute path on actors test\n\n[#128135489]","distinct":false,"url":"https://api.github.com/repos/elopio/cli/commits/46ff47241b97b141e0bfb52164975ff689c36ec2"},{"sha":"25cade2c7ad535450bd8f75048dab97c6bf1d1bd","author":{"name":"Dies Koper","email":"7c6a1afedccf173242a890ddedac0ceece6a7371@fast.au.fujitsu.com"},"message":"Merge pull request #931 from cloudfoundry/shalako-patch-1\n\nfixing links","distinct":false,"url":"https://api.github.com/repos/elopio/cli/commits/25cade2c7ad535450bd8f75048dab97c6bf1d1bd"},{"sha":"e406d5c2f80d39694095b0fd5a878e52029046e9","author":{"name":"Dies Koper","email":"7c6a1afedccf173242a890ddedac0ceece6a7371@fast.au.fujitsu.com"},"message":"mentioned that PRs with command/flag changes should be discussed in an issue first","distinct":false,"url":"https://api.github.com/repos/elopio/cli/commits/e406d5c2f80d39694095b0fd5a878e52029046e9"},{"sha":"e7069e9c1dd7c2dae8ee95476f1bf0e9299644bc","author":{"name":"Dies Koper","email":"7c6a1afedccf173242a890ddedac0ceece6a7371@fast.au.fujitsu.com"},"message":"added items from main readme","distinct":false,"url":"https://api.github.com/repos/elopio/cli/commits/e7069e9c1dd7c2dae8ee95476f1bf0e9299644bc"},{"sha":"059f127102bded005a664f458d28c69194414d6a","author":{"name":"Dies Koper","email":"7c6a1afedccf173242a890ddedac0ceece6a7371@fast.au.fujitsu.com"},"message":"removed details that are included in the issue template already","distinct":false,"url":"https://api.github.com/repos/elopio/cli/commits/059f127102bded005a664f458d28c69194414d6a"},{"sha":"de94a0743c9dde8ac79fc1f68d1778425a4449ed","author":{"name":"Dies Koper","email":"7c6a1afedccf173242a890ddedac0ceece6a7371@fast.au.fujitsu.com"},"message":"added filing feature requests","distinct":false,"url":"https://api.github.com/repos/elopio/cli/commits/de94a0743c9dde8ac79fc1f68d1778425a4449ed"},{"sha":"9cb97623ed2790361f72f26dfa614b78a3069142","author":{"name":"Dies Koper","email":"7c6a1afedccf173242a890ddedac0ceece6a7371@fast.au.fujitsu.com"},"message":"added plug for/link to community plugins site","distinct":false,"url":"https://api.github.com/repos/elopio/cli/commits/9cb97623ed2790361f72f26dfa614b78a3069142"},{"sha":"2747c07e84a1ad104069893dfe4cda3412901410","author":{"name":"Dies Koper","email":"7c6a1afedccf173242a890ddedac0ceece6a7371@fast.au.fujitsu.com"},"message":"moved edge binaries to end of download section","distinct":false,"url":"https://api.github.com/repos/elopio/cli/commits/2747c07e84a1ad104069893dfe4cda3412901410"},{"sha":"d82560db4034389d58097854ea59a1e27c778602","author":{"name":"Dies Koper","email":"7c6a1afedccf173242a890ddedac0ceece6a7371@fast.au.fujitsu.com"},"message":"improved wording","distinct":false,"url":"https://api.github.com/repos/elopio/cli/commits/d82560db4034389d58097854ea59a1e27c778602"},{"sha":"92b408dba4233436e82327e8916bb65d0677f987","author":{"name":"Luan Santos","email":"b1c40b5218d589acd313ed2644c3c9b03cf12ee8@pivotal.io"},"message":"fixes an error with the way the cli resolves symlinks on windows\n\n- in go 1.7 relative paths are not resolved properly when passed into\nEvalSymlinks\n\n[#128451573]\n\nSigned-off-by: Nick Wei <nwei@pivotal.io>","distinct":false,"url":"https://api.github.com/repos/elopio/cli/commits/92b408dba4233436e82327e8916bb65d0677f987"},{"sha":"cd086c82859f3cf2d7cc18d3eb2636f56c6cdd8c","author":{"name":"Nick Wei","email":"dee5f5d1a640ca8908dac586d094f0c3b3434867@pivotal.io"},"message":"Prevent usage messages form being printed twice\n\n[fixes #128555341]\n\nSigned-off-by: Luan Santos <lsantos@pivotal.io>","distinct":false,"url":"https://api.github.com/repos/elopio/cli/commits/cd086c82859f3cf2d7cc18d3eb2636f56c6cdd8c"}]}
{"actor":{"display_login":"elopio"}}