{"action":"created","issue":{"url":"https://api.github.com/repos/google/blockly/issues/617","repository_url":"https://api.github.com/repos/google/blockly","labels_url":"https://api.github.com/repos/google/blockly/issues/617/labels{/name}","comments_url":"https://api.github.com/repos/google/blockly/issues/617/comments","events_url":"https://api.github.com/repos/google/blockly/issues/617/events","html_url":"https://github.com/google/blockly/pull/617","id":174383380,"number":617,"title":"Blockly Factory: Check for Unsaved Changes in Workspace Factory","user":{"login":"evd2014","id":18580768,"avatar_url":"https://avatars.githubusercontent.com/u/18580768?v=3","gravatar_id":"","url":"https://api.github.com/users/evd2014","html_url":"https://github.com/evd2014","followers_url":"https://api.github.com/users/evd2014/followers","following_url":"https://api.github.com/users/evd2014/following{/other_user}","gists_url":"https://api.github.com/users/evd2014/gists{/gist_id}","starred_url":"https://api.github.com/users/evd2014/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evd2014/subscriptions","organizations_url":"https://api.github.com/users/evd2014/orgs","repos_url":"https://api.github.com/users/evd2014/repos","events_url":"https://api.github.com/users/evd2014/events{/privacy}","received_events_url":"https://api.github.com/users/evd2014/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-08-31T21:28:10Z","updated_at":"2016-09-01T05:35:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/google/blockly/pulls/617","html_url":"https://github.com/google/blockly/pull/617","diff_url":"https://github.com/google/blockly/pull/617.diff","patch_url":"https://github.com/google/blockly/pull/617.patch"},"body":"Extend check for unsaved changes in Blockly Factory to check for unsaved changes in Workspace Factory (this is especially useful because Workspace Factory doesn't use local or session storage). Also removed blocks from the category name for imported blocks (shortens the name so that it fits more easily on the screen), and fixed bug when adding a variables or functions category from a prompt when in workspace mode.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/google/blockly/617)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/google/blockly/issues/comments/243980688","html_url":"https://github.com/google/blockly/pull/617#issuecomment-243980688","issue_url":"https://api.github.com/repos/google/blockly/issues/617","id":243980688,"user":{"login":"quachtina96","id":10423718,"avatar_url":"https://avatars.githubusercontent.com/u/10423718?v=3","gravatar_id":"","url":"https://api.github.com/users/quachtina96","html_url":"https://github.com/quachtina96","followers_url":"https://api.github.com/users/quachtina96/followers","following_url":"https://api.github.com/users/quachtina96/following{/other_user}","gists_url":"https://api.github.com/users/quachtina96/gists{/gist_id}","starred_url":"https://api.github.com/users/quachtina96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quachtina96/subscriptions","organizations_url":"https://api.github.com/users/quachtina96/orgs","repos_url":"https://api.github.com/users/quachtina96/repos","events_url":"https://api.github.com/users/quachtina96/events{/privacy}","received_events_url":"https://api.github.com/users/quachtina96/received_events","type":"User","site_admin":false},"created_at":"2016-09-01T05:35:25Z","updated_at":"2016-09-01T05:35:25Z","body":"\n\n\n\nReview status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.\n\n---\n\n*[demos/blocklyfactory/app_controller.js, line 630 \\[r1\\]](https://reviewable.io:443/reviews/google/blockly/617#-KQY2mCzk3-wdxRPejHp:-KQZERqvqPZOys7ue1c2:bij94zc) ([raw file](https://github.com/google/blockly/blob/dee0cd6e5c70ad997218f0908b1c4fe5621270f7/demos/blocklyfactory/app_controller.js#L630)):*\n<details><summary><i>Previously, picklesrus wrote…</i></summary>\n> What do you think about constructing the message to indicate where the unsaved changes are? e.g. workspace factory, block factory, or both.\n</details>\nThe text returned in this function is not reflected in the actual alert received. From what I read, this is browser dependent (and version dependent)\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/google/blockly/617)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"quachtina96"}}