{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/corefx/issues/7840","repository_url":"https://api.github.com/repos/dotnet/corefx","labels_url":"https://api.github.com/repos/dotnet/corefx/issues/7840/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/7840/comments","events_url":"https://api.github.com/repos/dotnet/corefx/issues/7840/events","html_url":"https://github.com/dotnet/corefx/pull/7840","id":149247823,"number":7840,"title":"Fix clrcompression windows build","user":{"login":"ianhays","id":2606879,"avatar_url":"https://avatars.githubusercontent.com/u/2606879?v=3","gravatar_id":"","url":"https://api.github.com/users/ianhays","html_url":"https://github.com/ianhays","followers_url":"https://api.github.com/users/ianhays/followers","following_url":"https://api.github.com/users/ianhays/following{/other_user}","gists_url":"https://api.github.com/users/ianhays/gists{/gist_id}","starred_url":"https://api.github.com/users/ianhays/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianhays/subscriptions","organizations_url":"https://api.github.com/users/ianhays/orgs","repos_url":"https://api.github.com/users/ianhays/repos","events_url":"https://api.github.com/users/ianhays/events{/privacy}","received_events_url":"https://api.github.com/users/ianhays/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/corefx/labels/2%20-%20In%20Progress","name":"2 - In Progress","color":"CCCCCC"},{"url":"https://api.github.com/repos/dotnet/corefx/labels/cla-already-signed","name":"cla-already-signed","color":"009800"},{"url":"https://api.github.com/repos/dotnet/corefx/labels/packaging","name":"packaging","color":"e11d21"},{"url":"https://api.github.com/repos/dotnet/corefx/labels/System.IO.Compression","name":"System.IO.Compression","color":"d4c5f9"},{"url":"https://api.github.com/repos/dotnet/corefx/labels/Windows","name":"Windows","color":"fef2c0"}],"state":"open","locked":false,"assignee":{"login":"ianhays","id":2606879,"avatar_url":"https://avatars.githubusercontent.com/u/2606879?v=3","gravatar_id":"","url":"https://api.github.com/users/ianhays","html_url":"https://github.com/ianhays","followers_url":"https://api.github.com/users/ianhays/followers","following_url":"https://api.github.com/users/ianhays/following{/other_user}","gists_url":"https://api.github.com/users/ianhays/gists{/gist_id}","starred_url":"https://api.github.com/users/ianhays/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianhays/subscriptions","organizations_url":"https://api.github.com/users/ianhays/orgs","repos_url":"https://api.github.com/users/ianhays/repos","events_url":"https://api.github.com/users/ianhays/events{/privacy}","received_events_url":"https://api.github.com/users/ianhays/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/dotnet/corefx/milestones/4","html_url":"https://github.com/dotnet/corefx/milestones/1.0.0-rtm","labels_url":"https://api.github.com/repos/dotnet/corefx/milestones/4/labels","id":1248719,"number":4,"title":"1.0.0-rtm","description":"2016 https://github.com/aspnet/Home/wiki/Roadmap","creator":{"login":"joshfree","id":1302850,"avatar_url":"https://avatars.githubusercontent.com/u/1302850?v=3","gravatar_id":"","url":"https://api.github.com/users/joshfree","html_url":"https://github.com/joshfree","followers_url":"https://api.github.com/users/joshfree/followers","following_url":"https://api.github.com/users/joshfree/following{/other_user}","gists_url":"https://api.github.com/users/joshfree/gists{/gist_id}","starred_url":"https://api.github.com/users/joshfree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshfree/subscriptions","organizations_url":"https://api.github.com/users/joshfree/orgs","repos_url":"https://api.github.com/users/joshfree/repos","events_url":"https://api.github.com/users/joshfree/events{/privacy}","received_events_url":"https://api.github.com/users/joshfree/received_events","type":"User","site_admin":false},"open_issues":350,"closed_issues":564,"state":"open","created_at":"2015-08-10T18:04:00Z","updated_at":"2016-04-18T19:25:15Z","due_on":"2016-06-30T07:00:00Z","closed_at":null},"comments":1,"created_at":"2016-04-18T19:25:15Z","updated_at":"2016-04-18T19:28:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/7840","html_url":"https://github.com/dotnet/corefx/pull/7840","diff_url":"https://github.com/dotnet/corefx/pull/7840.diff","patch_url":"https://github.com/dotnet/corefx/pull/7840.patch"},"body":"The Open Windows native build of clrcompression was inferior to the one in TFS for a few reasons:\r\n- The Open clrcompression imported vcruntime140.dll\r\n- It did not produce a pdb for either build config\r\n- The linker/compiler flags being used were incorrect or inadequate\r\n\r\nThose problems have been resolved. The clrcompression.dll produced in the open is now the same as the one produced internally with the exception that it is linked against the UCRT instead of a fixed msvcrt from TFS. I also took this opportunity to fix the appx package and add the /guard:cf flag which is missing from the TFS clrcompression.\r\n\r\nresolves #7436\r\nresolves #7748\r\nrelated to #7756\r\n\r\n@dagood @ellismg @gkhanna79"},"comment":{"url":"https://api.github.com/repos/dotnet/corefx/issues/comments/211541503","html_url":"https://github.com/dotnet/corefx/pull/7840#issuecomment-211541503","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/7840","id":211541503,"user":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars.githubusercontent.com/u/2642209?v=3","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"created_at":"2016-04-18T19:28:37Z","updated_at":"2016-04-18T19:28:37Z","body":"> I also took this opportunity to fix the appx package and add the /guard:cf flag\r\n\r\nI'm not suggesting we not do this, but do we understand what, if any, perf impact there is to using the guard flag?  If nothing else, if there is an impact, it'd be good to understand what that impact is in case we hear of it resulting in any regressions for folks."}}