{"action":"created","comment":{"url":"https://api.github.com/repos/php/php-src/pulls/comments/67404933","id":67404933,"diff_hunk":"@@ -3499,6 +3526,26 @@ static EVP_PKEY * php_openssl_generate_private_key(struct php_x509_request * req\n \t\t\t\t}\n \t\t\t\tbreak;\n #endif\n+#ifdef HAVE_EVP_PKEY_EC\n+\t\t\tcase OPENSSL_KEYTYPE_EC:\n+\t\t\t\t{\n+\t\t\t\t\tif (req->curve_name == NID_undef) {\n+\t\t\t\t\t\tphp_error_docref(NULL TSRMLS_CC, E_WARNING, \"Missing configuration value: 'curve_name' not set\");","path":"ext/openssl/openssl.c","position":70,"original_position":70,"commit_id":"aaf069bbca8525264864942ded93ef1bd387077f","original_commit_id":"aaf069bbca8525264864942ded93ef1bd387077f","user":{"login":"bukka","id":137594,"avatar_url":"https://avatars.githubusercontent.com/u/137594?v=3","gravatar_id":"","url":"https://api.github.com/users/bukka","html_url":"https://github.com/bukka","followers_url":"https://api.github.com/users/bukka/followers","following_url":"https://api.github.com/users/bukka/following{/other_user}","gists_url":"https://api.github.com/users/bukka/gists{/gist_id}","starred_url":"https://api.github.com/users/bukka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bukka/subscriptions","organizations_url":"https://api.github.com/users/bukka/orgs","repos_url":"https://api.github.com/users/bukka/repos","events_url":"https://api.github.com/users/bukka/events{/privacy}","received_events_url":"https://api.github.com/users/bukka/received_events","type":"User","site_admin":false},"body":"TSRMLS_CC as above...","created_at":"2016-06-16T19:01:54Z","updated_at":"2016-06-16T19:01:54Z","html_url":"https://github.com/php/php-src/pull/1686#discussion_r67404933","pull_request_url":"https://api.github.com/repos/php/php-src/pulls/1686","_links":{"self":{"href":"https://api.github.com/repos/php/php-src/pulls/comments/67404933"},"html":{"href":"https://github.com/php/php-src/pull/1686#discussion_r67404933"},"pull_request":{"href":"https://api.github.com/repos/php/php-src/pulls/1686"}}},"pull_request":{"url":"https://api.github.com/repos/php/php-src/pulls/1686","id":54095561,"html_url":"https://github.com/php/php-src/pull/1686","diff_url":"https://github.com/php/php-src/pull/1686.diff","patch_url":"https://github.com/php/php-src/pull/1686.patch","issue_url":"https://api.github.com/repos/php/php-src/issues/1686","number":1686,"state":"open","locked":false,"title":"Feature/openssl ecc keypair support","user":{"login":"dol","id":41777,"avatar_url":"https://avatars.githubusercontent.com/u/41777?v=3","gravatar_id":"","url":"https://api.github.com/users/dol","html_url":"https://github.com/dol","followers_url":"https://api.github.com/users/dol/followers","following_url":"https://api.github.com/users/dol/following{/other_user}","gists_url":"https://api.github.com/users/dol/gists{/gist_id}","starred_url":"https://api.github.com/users/dol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dol/subscriptions","organizations_url":"https://api.github.com/users/dol/orgs","repos_url":"https://api.github.com/users/dol/repos","events_url":"https://api.github.com/users/dol/events{/privacy}","received_events_url":"https://api.github.com/users/dol/received_events","type":"User","site_admin":false},"body":"The current ECC (eliptic curver crypthography) support of the OpenSSL extensions has no possibility to generate a EC public key pair.\r\n\r\nThe PR is a modified version of the patch provided in https://bugs.php.net/bug.php?id=61204 .\r\n- Renamed 'ec_group_name' parameter to 'curve_name' to be compliant with the export parameter naming of [openssl_pkey_get_details()](https://github.com/php/php-src/commit/5d1cc7d13536d1753adce40b903d71c5c841c30a#diff-69bad938d17f4283faa5f7fea17fa627R3512).\r\n- Added some missing memory free statements\r\n- Added more test cases\r\n\r\nThe PR also fixes some tabs/spaces formatting issues.","created_at":"2015-12-18T12:06:13Z","updated_at":"2016-06-16T19:01:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"222bbe8a3558b844ed9d173df8785482c106636f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/php/php-src/pulls/1686/commits","review_comments_url":"https://api.github.com/repos/php/php-src/pulls/1686/comments","review_comment_url":"https://api.github.com/repos/php/php-src/pulls/comments{/number}","comments_url":"https://api.github.com/repos/php/php-src/issues/1686/comments","statuses_url":"https://api.github.com/repos/php/php-src/statuses/aaf069bbca8525264864942ded93ef1bd387077f","head":{"label":"dol:feature/openssl-ecc-keypair-support","ref":"feature/openssl-ecc-keypair-support","sha":"aaf069bbca8525264864942ded93ef1bd387077f","user":{"login":"dol","id":41777,"avatar_url":"https://avatars.githubusercontent.com/u/41777?v=3","gravatar_id":"","url":"https://api.github.com/users/dol","html_url":"https://github.com/dol","followers_url":"https://api.github.com/users/dol/followers","following_url":"https://api.github.com/users/dol/following{/other_user}","gists_url":"https://api.github.com/users/dol/gists{/gist_id}","starred_url":"https://api.github.com/users/dol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dol/subscriptions","organizations_url":"https://api.github.com/users/dol/orgs","repos_url":"https://api.github.com/users/dol/repos","events_url":"https://api.github.com/users/dol/events{/privacy}","received_events_url":"https://api.github.com/users/dol/received_events","type":"User","site_admin":false},"repo":{"id":26829891,"name":"php-src","full_name":"dol/php-src","owner":{"login":"dol","id":41777,"avatar_url":"https://avatars.githubusercontent.com/u/41777?v=3","gravatar_id":"","url":"https://api.github.com/users/dol","html_url":"https://github.com/dol","followers_url":"https://api.github.com/users/dol/followers","following_url":"https://api.github.com/users/dol/following{/other_user}","gists_url":"https://api.github.com/users/dol/gists{/gist_id}","starred_url":"https://api.github.com/users/dol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dol/subscriptions","organizations_url":"https://api.github.com/users/dol/orgs","repos_url":"https://api.github.com/users/dol/repos","events_url":"https://api.github.com/users/dol/events{/privacy}","received_events_url":"https://api.github.com/users/dol/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dol/php-src","description":"The PHP Interpreter","fork":true,"url":"https://api.github.com/repos/dol/php-src","forks_url":"https://api.github.com/repos/dol/php-src/forks","keys_url":"https://api.github.com/repos/dol/php-src/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dol/php-src/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dol/php-src/teams","hooks_url":"https://api.github.com/repos/dol/php-src/hooks","issue_events_url":"https://api.github.com/repos/dol/php-src/issues/events{/number}","events_url":"https://api.github.com/repos/dol/php-src/events","assignees_url":"https://api.github.com/repos/dol/php-src/assignees{/user}","branches_url":"https://api.github.com/repos/dol/php-src/branches{/branch}","tags_url":"https://api.github.com/repos/dol/php-src/tags","blobs_url":"https://api.github.com/repos/dol/php-src/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dol/php-src/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dol/php-src/git/refs{/sha}","trees_url":"https://api.github.com/repos/dol/php-src/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dol/php-src/statuses/{sha}","languages_url":"https://api.github.com/repos/dol/php-src/languages","stargazers_url":"https://api.github.com/repos/dol/php-src/stargazers","contributors_url":"https://api.github.com/repos/dol/php-src/contributors","subscribers_url":"https://api.github.com/repos/dol/php-src/subscribers","subscription_url":"https://api.github.com/repos/dol/php-src/subscription","commits_url":"https://api.github.com/repos/dol/php-src/commits{/sha}","git_commits_url":"https://api.github.com/repos/dol/php-src/git/commits{/sha}","comments_url":"https://api.github.com/repos/dol/php-src/comments{/number}","issue_comment_url":"https://api.github.com/repos/dol/php-src/issues/comments{/number}","contents_url":"https://api.github.com/repos/dol/php-src/contents/{+path}","compare_url":"https://api.github.com/repos/dol/php-src/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dol/php-src/merges","archive_url":"https://api.github.com/repos/dol/php-src/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dol/php-src/downloads","issues_url":"https://api.github.com/repos/dol/php-src/issues{/number}","pulls_url":"https://api.github.com/repos/dol/php-src/pulls{/number}","milestones_url":"https://api.github.com/repos/dol/php-src/milestones{/number}","notifications_url":"https://api.github.com/repos/dol/php-src/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dol/php-src/labels{/name}","releases_url":"https://api.github.com/repos/dol/php-src/releases{/id}","deployments_url":"https://api.github.com/repos/dol/php-src/deployments","created_at":"2014-11-18T21:04:50Z","updated_at":"2016-04-12T21:12:37Z","pushed_at":"2016-06-15T20:37:20Z","git_url":"git://github.com/dol/php-src.git","ssh_url":"git@github.com:dol/php-src.git","clone_url":"https://github.com/dol/php-src.git","svn_url":"https://github.com/dol/php-src","homepage":"http://www.php.net","size":250453,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"php:master","ref":"master","sha":"006b8417d11d8f5b3ba88c4e9478df2843c5588a","user":{"login":"php","id":25158,"avatar_url":"https://avatars.githubusercontent.com/u/25158?v=3","gravatar_id":"","url":"https://api.github.com/users/php","html_url":"https://github.com/php","followers_url":"https://api.github.com/users/php/followers","following_url":"https://api.github.com/users/php/following{/other_user}","gists_url":"https://api.github.com/users/php/gists{/gist_id}","starred_url":"https://api.github.com/users/php/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php/subscriptions","organizations_url":"https://api.github.com/users/php/orgs","repos_url":"https://api.github.com/users/php/repos","events_url":"https://api.github.com/users/php/events{/privacy}","received_events_url":"https://api.github.com/users/php/received_events","type":"Organization","site_admin":false},"repo":{"id":1903522,"name":"php-src","full_name":"php/php-src","owner":{"login":"php","id":25158,"avatar_url":"https://avatars.githubusercontent.com/u/25158?v=3","gravatar_id":"","url":"https://api.github.com/users/php","html_url":"https://github.com/php","followers_url":"https://api.github.com/users/php/followers","following_url":"https://api.github.com/users/php/following{/other_user}","gists_url":"https://api.github.com/users/php/gists{/gist_id}","starred_url":"https://api.github.com/users/php/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php/subscriptions","organizations_url":"https://api.github.com/users/php/orgs","repos_url":"https://api.github.com/users/php/repos","events_url":"https://api.github.com/users/php/events{/privacy}","received_events_url":"https://api.github.com/users/php/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/php/php-src","description":"The PHP Interpreter","fork":false,"url":"https://api.github.com/repos/php/php-src","forks_url":"https://api.github.com/repos/php/php-src/forks","keys_url":"https://api.github.com/repos/php/php-src/keys{/key_id}","collaborators_url":"https://api.github.com/repos/php/php-src/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/php/php-src/teams","hooks_url":"https://api.github.com/repos/php/php-src/hooks","issue_events_url":"https://api.github.com/repos/php/php-src/issues/events{/number}","events_url":"https://api.github.com/repos/php/php-src/events","assignees_url":"https://api.github.com/repos/php/php-src/assignees{/user}","branches_url":"https://api.github.com/repos/php/php-src/branches{/branch}","tags_url":"https://api.github.com/repos/php/php-src/tags","blobs_url":"https://api.github.com/repos/php/php-src/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/php/php-src/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/php/php-src/git/refs{/sha}","trees_url":"https://api.github.com/repos/php/php-src/git/trees{/sha}","statuses_url":"https://api.github.com/repos/php/php-src/statuses/{sha}","languages_url":"https://api.github.com/repos/php/php-src/languages","stargazers_url":"https://api.github.com/repos/php/php-src/stargazers","contributors_url":"https://api.github.com/repos/php/php-src/contributors","subscribers_url":"https://api.github.com/repos/php/php-src/subscribers","subscription_url":"https://api.github.com/repos/php/php-src/subscription","commits_url":"https://api.github.com/repos/php/php-src/commits{/sha}","git_commits_url":"https://api.github.com/repos/php/php-src/git/commits{/sha}","comments_url":"https://api.github.com/repos/php/php-src/comments{/number}","issue_comment_url":"https://api.github.com/repos/php/php-src/issues/comments{/number}","contents_url":"https://api.github.com/repos/php/php-src/contents/{+path}","compare_url":"https://api.github.com/repos/php/php-src/compare/{base}...{head}","merges_url":"https://api.github.com/repos/php/php-src/merges","archive_url":"https://api.github.com/repos/php/php-src/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/php/php-src/downloads","issues_url":"https://api.github.com/repos/php/php-src/issues{/number}","pulls_url":"https://api.github.com/repos/php/php-src/pulls{/number}","milestones_url":"https://api.github.com/repos/php/php-src/milestones{/number}","notifications_url":"https://api.github.com/repos/php/php-src/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/php/php-src/labels{/name}","releases_url":"https://api.github.com/repos/php/php-src/releases{/id}","deployments_url":"https://api.github.com/repos/php/php-src/deployments","created_at":"2011-06-16T01:52:25Z","updated_at":"2016-06-16T17:44:23Z","pushed_at":"2016-06-16T12:36:09Z","git_url":"git://github.com/php/php-src.git","ssh_url":"git@github.com:php/php-src.git","clone_url":"https://github.com/php/php-src.git","svn_url":"https://github.com/php/php-src","homepage":"http://www.php.net","size":393045,"stargazers_count":9349,"watchers_count":9349,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3251,"mirror_url":null,"open_issues_count":332,"forks":3251,"open_issues":332,"watchers":9349,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/php/php-src/pulls/1686"},"html":{"href":"https://github.com/php/php-src/pull/1686"},"issue":{"href":"https://api.github.com/repos/php/php-src/issues/1686"},"comments":{"href":"https://api.github.com/repos/php/php-src/issues/1686/comments"},"review_comments":{"href":"https://api.github.com/repos/php/php-src/pulls/1686/comments"},"review_comment":{"href":"https://api.github.com/repos/php/php-src/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/php/php-src/pulls/1686/commits"},"statuses":{"href":"https://api.github.com/repos/php/php-src/statuses/aaf069bbca8525264864942ded93ef1bd387077f"}}}}
{"actor":{"display_login":"bukka"}}