{"action":"created","issue":{"url":"https://api.github.com/repos/5to6/5to6-codemod/issues/17","repository_url":"https://api.github.com/repos/5to6/5to6-codemod","labels_url":"https://api.github.com/repos/5to6/5to6-codemod/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/5to6/5to6-codemod/issues/17/comments","events_url":"https://api.github.com/repos/5to6/5to6-codemod/issues/17/events","html_url":"https://github.com/5to6/5to6-codemod/pull/17","id":152674839,"number":17,"title":"var { module1, module2 } = require('module3) => import { module1, module2 } from 'module3';","user":{"login":"frodosamoa","id":1582620,"avatar_url":"https://avatars.githubusercontent.com/u/1582620?v=3","gravatar_id":"","url":"https://api.github.com/users/frodosamoa","html_url":"https://github.com/frodosamoa","followers_url":"https://api.github.com/users/frodosamoa/followers","following_url":"https://api.github.com/users/frodosamoa/following{/other_user}","gists_url":"https://api.github.com/users/frodosamoa/gists{/gist_id}","starred_url":"https://api.github.com/users/frodosamoa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frodosamoa/subscriptions","organizations_url":"https://api.github.com/users/frodosamoa/orgs","repos_url":"https://api.github.com/users/frodosamoa/repos","events_url":"https://api.github.com/users/frodosamoa/events{/privacy}","received_events_url":"https://api.github.com/users/frodosamoa/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-05-03T00:21:53Z","updated_at":"2016-05-06T18:23:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/5to6/5to6-codemod/pulls/17","html_url":"https://github.com/5to6/5to6-codemod/pull/17","diff_url":"https://github.com/5to6/5to6-codemod/pull/17.diff","patch_url":"https://github.com/5to6/5to6-codemod/pull/17.patch"},"body":"Also, I took a look at `master` and three tests are failing off the bat. This PR only adds one error which seems to be wrong:\r\n```\r\n1) CJS transform should convert require('jquery') -> import 'jquery' :\r\n\r\n      AssertionError: '// CJS top comment\\n\\nimport jamis from \\'jquery\\';\\nimport $ from \\'jquery\\';\\nimport $ from \\'jquery\\';\\nimport \\'something\\' == '// CJS top comment\\n\\nimport jamis from \\'jquery\\';\\nimport $ from \\'jquery\\';\\nimport $ from \\'jquery\\';\\nimport \\'something\\'\r\n      + expected - actual\r\n\r\n       var jamis = 'bar', bar, foo = 'bar';\r\n\r\n       import {routeTo} from '../routeHelper';\r\n       import {pluck as fetch} from '../someUtil';\r\n      -import {includes, pick} from 'lodash';\r\n      +import {includes, pick} from 'lodash';\r\n\r\n      at Context.<anonymous> (test/transforms/cjs.js:25:12)\r\n```\r\n\r\nIt is complaining about the last line even though they look totally indentical. I'm thinking maybe a whitespace issue?"},"comment":{"url":"https://api.github.com/repos/5to6/5to6-codemod/issues/comments/217521012","html_url":"https://github.com/5to6/5to6-codemod/pull/17#issuecomment-217521012","issue_url":"https://api.github.com/repos/5to6/5to6-codemod/issues/17","id":217521012,"user":{"login":"frodosamoa","id":1582620,"avatar_url":"https://avatars.githubusercontent.com/u/1582620?v=3","gravatar_id":"","url":"https://api.github.com/users/frodosamoa","html_url":"https://github.com/frodosamoa","followers_url":"https://api.github.com/users/frodosamoa/followers","following_url":"https://api.github.com/users/frodosamoa/following{/other_user}","gists_url":"https://api.github.com/users/frodosamoa/gists{/gist_id}","starred_url":"https://api.github.com/users/frodosamoa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frodosamoa/subscriptions","organizations_url":"https://api.github.com/users/frodosamoa/orgs","repos_url":"https://api.github.com/users/frodosamoa/repos","events_url":"https://api.github.com/users/frodosamoa/events{/privacy}","received_events_url":"https://api.github.com/users/frodosamoa/received_events","type":"User","site_admin":false},"created_at":"2016-05-06T18:23:08Z","updated_at":"2016-05-06T18:23:08Z","body":"Alright, I'll edit my PR to include the `trim`!"}}