{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/61498741","id":61498741,"diff_hunk":"@@ -52,7 +53,7 @@ func validRoute() *api.Route {\n }\n \n func TestCreate(t *testing.T) {\n-\tstorage, server := newStorage(t, &testAllocator{})\n+\tstorage, server := newStorage(t, nil)","path":"pkg/route/registry/route/etcd/etcd_test.go","position":22,"original_position":22,"commit_id":"8388ce24d4d8be27d1da43f9cbb7fff1994d1680","original_commit_id":"8388ce24d4d8be27d1da43f9cbb7fff1994d1680","user":{"login":"pweil-","id":5230419,"avatar_url":"https://avatars.githubusercontent.com/u/5230419?v=3","gravatar_id":"","url":"https://api.github.com/users/pweil-","html_url":"https://github.com/pweil-","followers_url":"https://api.github.com/users/pweil-/followers","following_url":"https://api.github.com/users/pweil-/following{/other_user}","gists_url":"https://api.github.com/users/pweil-/gists{/gist_id}","starred_url":"https://api.github.com/users/pweil-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pweil-/subscriptions","organizations_url":"https://api.github.com/users/pweil-/orgs","repos_url":"https://api.github.com/users/pweil-/repos","events_url":"https://api.github.com/users/pweil-/events{/privacy}","received_events_url":"https://api.github.com/users/pweil-/received_events","type":"User","site_admin":false},"body":"@ramr I went ahead and changed this to nil as well to ensure we have a test with nil and a test with an allocator for both create and update","created_at":"2016-04-28T20:41:31Z","updated_at":"2016-04-28T20:41:31Z","html_url":"https://github.com/openshift/origin/pull/8677#discussion_r61498741","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/8677","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/61498741"},"html":{"href":"https://github.com/openshift/origin/pull/8677#discussion_r61498741"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/8677"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/8677","id":68286714,"html_url":"https://github.com/openshift/origin/pull/8677","diff_url":"https://github.com/openshift/origin/pull/8677.diff","patch_url":"https://github.com/openshift/origin/pull/8677.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/8677","number":8677,"state":"open","locked":false,"title":"BZ 1331303 allocate route host on update if host is empty in spec","user":{"login":"pweil-","id":5230419,"avatar_url":"https://avatars.githubusercontent.com/u/5230419?v=3","gravatar_id":"","url":"https://api.github.com/users/pweil-","html_url":"https://github.com/pweil-","followers_url":"https://api.github.com/users/pweil-/followers","following_url":"https://api.github.com/users/pweil-/following{/other_user}","gists_url":"https://api.github.com/users/pweil-/gists{/gist_id}","starred_url":"https://api.github.com/users/pweil-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pweil-/subscriptions","organizations_url":"https://api.github.com/users/pweil-/orgs","repos_url":"https://api.github.com/users/pweil-/repos","events_url":"https://api.github.com/users/pweil-/events{/privacy}","received_events_url":"https://api.github.com/users/pweil-/received_events","type":"User","site_admin":false},"body":"@ramr since I had this code open I went ahead and made a PR for it.\r\n","created_at":"2016-04-28T20:40:24Z","updated_at":"2016-04-28T20:41:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"198882b3953399ab234e31c1aebc205184e5410e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/8677/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/8677/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/8677/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/8388ce24d4d8be27d1da43f9cbb7fff1994d1680","head":{"label":"pweil-:route-update-host","ref":"route-update-host","sha":"8388ce24d4d8be27d1da43f9cbb7fff1994d1680","user":{"login":"pweil-","id":5230419,"avatar_url":"https://avatars.githubusercontent.com/u/5230419?v=3","gravatar_id":"","url":"https://api.github.com/users/pweil-","html_url":"https://github.com/pweil-","followers_url":"https://api.github.com/users/pweil-/followers","following_url":"https://api.github.com/users/pweil-/following{/other_user}","gists_url":"https://api.github.com/users/pweil-/gists{/gist_id}","starred_url":"https://api.github.com/users/pweil-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pweil-/subscriptions","organizations_url":"https://api.github.com/users/pweil-/orgs","repos_url":"https://api.github.com/users/pweil-/repos","events_url":"https://api.github.com/users/pweil-/events{/privacy}","received_events_url":"https://api.github.com/users/pweil-/received_events","type":"User","site_admin":false},"repo":{"id":24119315,"name":"origin","full_name":"pweil-/origin","owner":{"login":"pweil-","id":5230419,"avatar_url":"https://avatars.githubusercontent.com/u/5230419?v=3","gravatar_id":"","url":"https://api.github.com/users/pweil-","html_url":"https://github.com/pweil-","followers_url":"https://api.github.com/users/pweil-/followers","following_url":"https://api.github.com/users/pweil-/following{/other_user}","gists_url":"https://api.github.com/users/pweil-/gists{/gist_id}","starred_url":"https://api.github.com/users/pweil-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pweil-/subscriptions","organizations_url":"https://api.github.com/users/pweil-/orgs","repos_url":"https://api.github.com/users/pweil-/repos","events_url":"https://api.github.com/users/pweil-/events{/privacy}","received_events_url":"https://api.github.com/users/pweil-/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pweil-/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/pweil-/origin","forks_url":"https://api.github.com/repos/pweil-/origin/forks","keys_url":"https://api.github.com/repos/pweil-/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pweil-/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pweil-/origin/teams","hooks_url":"https://api.github.com/repos/pweil-/origin/hooks","issue_events_url":"https://api.github.com/repos/pweil-/origin/issues/events{/number}","events_url":"https://api.github.com/repos/pweil-/origin/events","assignees_url":"https://api.github.com/repos/pweil-/origin/assignees{/user}","branches_url":"https://api.github.com/repos/pweil-/origin/branches{/branch}","tags_url":"https://api.github.com/repos/pweil-/origin/tags","blobs_url":"https://api.github.com/repos/pweil-/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pweil-/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pweil-/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/pweil-/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pweil-/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/pweil-/origin/languages","stargazers_url":"https://api.github.com/repos/pweil-/origin/stargazers","contributors_url":"https://api.github.com/repos/pweil-/origin/contributors","subscribers_url":"https://api.github.com/repos/pweil-/origin/subscribers","subscription_url":"https://api.github.com/repos/pweil-/origin/subscription","commits_url":"https://api.github.com/repos/pweil-/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/pweil-/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/pweil-/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/pweil-/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/pweil-/origin/contents/{+path}","compare_url":"https://api.github.com/repos/pweil-/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pweil-/origin/merges","archive_url":"https://api.github.com/repos/pweil-/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pweil-/origin/downloads","issues_url":"https://api.github.com/repos/pweil-/origin/issues{/number}","pulls_url":"https://api.github.com/repos/pweil-/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/pweil-/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/pweil-/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pweil-/origin/labels{/name}","releases_url":"https://api.github.com/repos/pweil-/origin/releases{/id}","deployments_url":"https://api.github.com/repos/pweil-/origin/deployments","created_at":"2014-09-16T21:53:06Z","updated_at":"2016-01-13T20:36:57Z","pushed_at":"2016-04-28T20:39:31Z","git_url":"git://github.com/pweil-/origin.git","ssh_url":"git@github.com:pweil-/origin.git","clone_url":"https://github.com/pweil-/origin.git","svn_url":"https://github.com/pweil-/origin","homepage":"https://openshift.github.io","size":265016,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"68e1ee27037ded6187a9c4bd4df576177c6e9318","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"The Continuous Application Platform - build, deploy, and manage cloud-native and legacy applications on Kubernetes and Docker","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2016-04-28T20:30:46Z","pushed_at":"2016-04-28T20:40:24Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":344108,"stargazers_count":1256,"watchers_count":1256,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":758,"mirror_url":null,"open_issues_count":998,"forks":758,"open_issues":998,"watchers":1256,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/8677"},"html":{"href":"https://github.com/openshift/origin/pull/8677"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/8677"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/8677/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/8677/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/8677/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/8388ce24d4d8be27d1da43f9cbb7fff1994d1680"}}}}