{"action":"created","comment":{"url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/comments/83125806","pull_request_review_id":3986890,"id":83125806,"diff_hunk":"@@ -1,11 +1,17 @@\n {\n   \"images\" : [\n     {\n+      \"orientation\" : \"portrait\",\n+      \"idiom\" : \"ipad\",\n+      \"extent\" : \"full-screen\",\n+      \"scale\" : \"1x\"\n+    },\n+    {\n       \"extent\" : \"full-screen\",\n       \"idiom\" : \"iphone\",\n       \"subtype\" : \"736h\",\n       \"filename\" : \"Default1242x2208.png\",\n-      \"minimum-system-version\" : \"9.0\",\n+      \"minimum-system-version\" : \"8.0\",","path":"shared/resources/Images.xcassets/LaunchImage.launchimage/Contents.json","position":15,"original_position":15,"commit_id":"6231c0d0bffae907cd9dc41faf6f1cb7faa73ca6","original_commit_id":"6231c0d0bffae907cd9dc41faf6f1cb7faa73ca6","user":{"login":"bhariharan","id":1820287,"avatar_url":"https://avatars.githubusercontent.com/u/1820287?v=3","gravatar_id":"","url":"https://api.github.com/users/bhariharan","html_url":"https://github.com/bhariharan","followers_url":"https://api.github.com/users/bhariharan/followers","following_url":"https://api.github.com/users/bhariharan/following{/other_user}","gists_url":"https://api.github.com/users/bhariharan/gists{/gist_id}","starred_url":"https://api.github.com/users/bhariharan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhariharan/subscriptions","organizations_url":"https://api.github.com/users/bhariharan/orgs","repos_url":"https://api.github.com/users/bhariharan/repos","events_url":"https://api.github.com/users/bhariharan/events{/privacy}","received_events_url":"https://api.github.com/users/bhariharan/received_events","type":"User","site_admin":false},"body":"Should be `9.0`.","created_at":"2016-10-13T00:26:19Z","updated_at":"2016-10-13T00:26:40Z","html_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS/pull/1769#discussion_r83125806","pull_request_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/1769","_links":{"self":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/comments/83125806"},"html":{"href":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS/pull/1769#discussion_r83125806"},"pull_request":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/1769"}}},"pull_request":{"url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/1769","id":88953535,"html_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS/pull/1769","diff_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS/pull/1769.diff","patch_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS/pull/1769.patch","issue_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/1769","number":1769,"state":"open","locked":false,"title":"Significantly reduced warnings ","user":{"login":"trooper2013","id":4625334,"avatar_url":"https://avatars.githubusercontent.com/u/4625334?v=3","gravatar_id":"","url":"https://api.github.com/users/trooper2013","html_url":"https://github.com/trooper2013","followers_url":"https://api.github.com/users/trooper2013/followers","following_url":"https://api.github.com/users/trooper2013/following{/other_user}","gists_url":"https://api.github.com/users/trooper2013/gists{/gist_id}","starred_url":"https://api.github.com/users/trooper2013/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trooper2013/subscriptions","organizations_url":"https://api.github.com/users/trooper2013/orgs","repos_url":"https://api.github.com/users/trooper2013/repos","events_url":"https://api.github.com/users/trooper2013/events{/privacy}","received_events_url":"https://api.github.com/users/trooper2013/received_events","type":"User","site_admin":false},"body":"\r\nThere were 60+ warnings when building \"everything\".  Now the number is reduced to 34 of which  at least 30 or so warnings are related to code in third party libs.\r\n\r\n1. Modified code that used deprecated UIAlert & UIActionSheet.\r\n2. Added images and removed images that aren't quite required for iOS 8.0+ (Unassigned images lead to significant number of warnings in xcode8)\r\n3. Fixed launch screen from use of storyboard to image assets. \r\n4. Added flags to indicate extension safe usage for libs(s) and the opposite for tests. \r\n\r\n \r\n\r\n\r\n","created_at":"2016-10-12T04:56:08Z","updated_at":"2016-10-13T00:26:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad24ce4df9547ce72287ecb19fb2e1782cc89603","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/1769/commits","review_comments_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/1769/comments","review_comment_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/1769/comments","statuses_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/statuses/6231c0d0bffae907cd9dc41faf6f1cb7faa73ca6","head":{"label":"trooper2013:unstable","ref":"unstable","sha":"6231c0d0bffae907cd9dc41faf6f1cb7faa73ca6","user":{"login":"trooper2013","id":4625334,"avatar_url":"https://avatars.githubusercontent.com/u/4625334?v=3","gravatar_id":"","url":"https://api.github.com/users/trooper2013","html_url":"https://github.com/trooper2013","followers_url":"https://api.github.com/users/trooper2013/followers","following_url":"https://api.github.com/users/trooper2013/following{/other_user}","gists_url":"https://api.github.com/users/trooper2013/gists{/gist_id}","starred_url":"https://api.github.com/users/trooper2013/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trooper2013/subscriptions","organizations_url":"https://api.github.com/users/trooper2013/orgs","repos_url":"https://api.github.com/users/trooper2013/repos","events_url":"https://api.github.com/users/trooper2013/events{/privacy}","received_events_url":"https://api.github.com/users/trooper2013/received_events","type":"User","site_admin":false},"repo":{"id":62419453,"name":"SalesforceMobileSDK-iOS","full_name":"trooper2013/SalesforceMobileSDK-iOS","owner":{"login":"trooper2013","id":4625334,"avatar_url":"https://avatars.githubusercontent.com/u/4625334?v=3","gravatar_id":"","url":"https://api.github.com/users/trooper2013","html_url":"https://github.com/trooper2013","followers_url":"https://api.github.com/users/trooper2013/followers","following_url":"https://api.github.com/users/trooper2013/following{/other_user}","gists_url":"https://api.github.com/users/trooper2013/gists{/gist_id}","starred_url":"https://api.github.com/users/trooper2013/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trooper2013/subscriptions","organizations_url":"https://api.github.com/users/trooper2013/orgs","repos_url":"https://api.github.com/users/trooper2013/repos","events_url":"https://api.github.com/users/trooper2013/events{/privacy}","received_events_url":"https://api.github.com/users/trooper2013/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trooper2013/SalesforceMobileSDK-iOS","description":"Force.com mobile SDK for iOS applications","fork":true,"url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS","forks_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/forks","keys_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/teams","hooks_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/hooks","issue_events_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/events","assignees_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/tags","blobs_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/languages","stargazers_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/stargazers","contributors_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/contributors","subscribers_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/subscribers","subscription_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/subscription","commits_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/merges","archive_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/downloads","issues_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/labels{/name}","releases_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/deployments","created_at":"2016-07-01T21:01:11Z","updated_at":"2016-07-01T21:01:15Z","pushed_at":"2016-10-12T23:47:35Z","git_url":"git://github.com/trooper2013/SalesforceMobileSDK-iOS.git","ssh_url":"git@github.com:trooper2013/SalesforceMobileSDK-iOS.git","clone_url":"https://github.com/trooper2013/SalesforceMobileSDK-iOS.git","svn_url":"https://github.com/trooper2013/SalesforceMobileSDK-iOS","homepage":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS","size":341512,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"forcedotcom:unstable","ref":"unstable","sha":"2022d1673dd8ff41fea503b345ab5f02c9db0d96","user":{"login":"forcedotcom","id":464563,"avatar_url":"https://avatars.githubusercontent.com/u/464563?v=3","gravatar_id":"","url":"https://api.github.com/users/forcedotcom","html_url":"https://github.com/forcedotcom","followers_url":"https://api.github.com/users/forcedotcom/followers","following_url":"https://api.github.com/users/forcedotcom/following{/other_user}","gists_url":"https://api.github.com/users/forcedotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/forcedotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forcedotcom/subscriptions","organizations_url":"https://api.github.com/users/forcedotcom/orgs","repos_url":"https://api.github.com/users/forcedotcom/repos","events_url":"https://api.github.com/users/forcedotcom/events{/privacy}","received_events_url":"https://api.github.com/users/forcedotcom/received_events","type":"Organization","site_admin":false},"repo":{"id":2338086,"name":"SalesforceMobileSDK-iOS","full_name":"forcedotcom/SalesforceMobileSDK-iOS","owner":{"login":"forcedotcom","id":464563,"avatar_url":"https://avatars.githubusercontent.com/u/464563?v=3","gravatar_id":"","url":"https://api.github.com/users/forcedotcom","html_url":"https://github.com/forcedotcom","followers_url":"https://api.github.com/users/forcedotcom/followers","following_url":"https://api.github.com/users/forcedotcom/following{/other_user}","gists_url":"https://api.github.com/users/forcedotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/forcedotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forcedotcom/subscriptions","organizations_url":"https://api.github.com/users/forcedotcom/orgs","repos_url":"https://api.github.com/users/forcedotcom/repos","events_url":"https://api.github.com/users/forcedotcom/events{/privacy}","received_events_url":"https://api.github.com/users/forcedotcom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS","description":"Force.com mobile SDK for iOS applications","fork":false,"url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS","forks_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/forks","keys_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/teams","hooks_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/hooks","issue_events_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/events","assignees_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/tags","blobs_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/languages","stargazers_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/stargazers","contributors_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/contributors","subscribers_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/subscribers","subscription_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/subscription","commits_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/merges","archive_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/downloads","issues_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/labels{/name}","releases_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/deployments","created_at":"2011-09-06T23:13:57Z","updated_at":"2016-10-10T05:43:10Z","pushed_at":"2016-10-12T23:49:08Z","git_url":"git://github.com/forcedotcom/SalesforceMobileSDK-iOS.git","ssh_url":"git@github.com:forcedotcom/SalesforceMobileSDK-iOS.git","clone_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS.git","svn_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS","homepage":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS","size":355744,"stargazers_count":343,"watchers_count":343,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":250,"mirror_url":null,"open_issues_count":10,"forks":250,"open_issues":10,"watchers":343,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/1769"},"html":{"href":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS/pull/1769"},"issue":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/1769"},"comments":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/1769/comments"},"review_comments":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/1769/comments"},"review_comment":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/1769/commits"},"statuses":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/statuses/6231c0d0bffae907cd9dc41faf6f1cb7faa73ca6"}}}}
{"actor":{"display_login":"bhariharan"}}