{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/15959","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15959/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15959/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15959/events","html_url":"https://github.com/cms-sw/cmssw/pull/15959","id":178649290,"number":15959,"title":"HBHE: siPM M2 reco fixes ","user":{"login":"mariadalfonso","id":5656714,"avatar_url":"https://avatars.githubusercontent.com/u/5656714?v=3","gravatar_id":"","url":"https://api.github.com/users/mariadalfonso","html_url":"https://github.com/mariadalfonso","followers_url":"https://api.github.com/users/mariadalfonso/followers","following_url":"https://api.github.com/users/mariadalfonso/following{/other_user}","gists_url":"https://api.github.com/users/mariadalfonso/gists{/gist_id}","starred_url":"https://api.github.com/users/mariadalfonso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariadalfonso/subscriptions","organizations_url":"https://api.github.com/users/mariadalfonso/orgs","repos_url":"https://api.github.com/users/mariadalfonso/repos","events_url":"https://api.github.com/users/mariadalfonso/events{/privacy}","received_events_url":"https://api.github.com/users/mariadalfonso/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/alca-approved","name":"alca-approved","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"009800"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_1_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59/labels","id":1590252,"number":59,"title":"Next CMSSW_8_1_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":81,"closed_issues":1624,"state":"open","created_at":"2016-02-18T09:12:12Z","updated_at":"2016-10-11T14:14:25Z","due_on":null,"closed_at":null},"comments":94,"created_at":"2016-09-22T15:55:38Z","updated_at":"2016-10-11T14:33:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/15959","html_url":"https://github.com/cms-sw/cmssw/pull/15959","diff_url":"https://github.com/cms-sw/cmssw/pull/15959.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/15959.patch"},"body":"1) FIX the initialization of the siPM pulse (Run2-phase1). \r\nBefore the M2 siPM fits was done with the HPD pulse and parameters.\r\nThe  save 20% of CPU time on single particle no PU\r\n2) Add extra features: add the ADC granularity or siPM (phase1)\r\n\r\nThis PR discuss also a possible move the initial time of the M2 fit to 2ns (Run2-phase1 ), but this is removed from the list of commit.\r\nThe save an extra 20% of CPU time on single particle no PU\r\n\r\nSome reference slide\r\nhttps://indico.cern.ch/event/570231/contributions/2306435/attachments/1341696/2021200/PR15959.pdf"},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/252934807","html_url":"https://github.com/cms-sw/cmssw/pull/15959#issuecomment-252934807","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15959","id":252934807,"user":{"login":"abdoulline","id":5010650,"avatar_url":"https://avatars.githubusercontent.com/u/5010650?v=3","gravatar_id":"","url":"https://api.github.com/users/abdoulline","html_url":"https://github.com/abdoulline","followers_url":"https://api.github.com/users/abdoulline/followers","following_url":"https://api.github.com/users/abdoulline/following{/other_user}","gists_url":"https://api.github.com/users/abdoulline/gists{/gist_id}","starred_url":"https://api.github.com/users/abdoulline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abdoulline/subscriptions","organizations_url":"https://api.github.com/users/abdoulline/orgs","repos_url":"https://api.github.com/users/abdoulline/repos","events_url":"https://api.github.com/users/abdoulline/events{/privacy}","received_events_url":"https://api.github.com/users/abdoulline/received_events","type":"User","site_admin":false},"created_at":"2016-10-11T14:33:38Z","updated_at":"2016-10-11T14:33:38Z","body":"\n   Slava, such plots (RecHits vs SimHits) were in Validation/HcalRecHits for \nabout 10 years, but they were used only privately (as were excluded from \nthe mainstream RelVals by \"allHistos\" = False) and they have recently been \ncompletely removed in the most recent \"cleaning\" HCAL Validation update\nhttps://github.com/cms-sw/cmssw/pull/15714\n\neven though the declarations (but not histo booking) still exist\nhttp://cmslxr.fnal.gov/source/Validation/HcalRecHits/interface/HcalRecHitsValidation.h#0327\n\nActually there is a substantial variation of Rec/Sim ratio (10-20%) even \nwithin each subdetector - depending mostly on electronics parameters and \n\"samplingFactor\" (as major Digitization components) variation. So 2d \nRecHits vs SimHits were always quite broad.\n\nNow it would take quite some time/efforts to bring these histos back to \nwork...\n\n\nOn Tue, 11 Oct 2016, Slava Krutelyov wrote:\n\n> On 10/11/16 7:11 AM, Viktor Khristenko wrote:\n> > @slava77 <https://github.com/slava77>\n> > SIM level objects are not among those that HCAL DQM group is responsible\n> > for.\n> > Within HCAL, it is validation...\n> \n> Thanks for the clarification.\n> Which group is responsible for HCAL validation (the parts where\n> comparisons with sim may be present)?\n> \n> \n> >\n> > VK\n> >\n> > —\n> > You are receiving this because you were mentioned.\n> > Reply to this email directly, view it on GitHub\n> > <https://github.com/cms-sw/cmssw/pull/15959#issuecomment-252928044>, or\n> > mute the thread\n> > <https://github.com/notifications/unsubscribe-auth/AEdcbrV2mmvVqEh2mFoUEvwcAK6wyD1fks5qy5j8gaJpZM4KED23>.\n> >\n> \n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub, or mute the\n> thread.[AEx02ktc2iNpIEZRmkZnyzm1Eu2fuMrFks5qy5mngaJpZM4KED23.gif]\n> \n> \n>"}}
{"actor":{"display_login":"abdoulline"}}