{"action":"opened","issue":{"url":"https://api.github.com/repos/dotnet/corefx/issues/12316","repository_url":"https://api.github.com/repos/dotnet/corefx","labels_url":"https://api.github.com/repos/dotnet/corefx/issues/12316/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/12316/comments","events_url":"https://api.github.com/repos/dotnet/corefx/issues/12316/events","html_url":"https://github.com/dotnet/corefx/issues/12316","id":180711442,"number":12316,"title":"Port System.Security.Cryptography.HMAC.BlockSizeValue","user":{"login":"steveharter","id":6986755,"avatar_url":"https://avatars.githubusercontent.com/u/6986755?v=3","gravatar_id":"","url":"https://api.github.com/users/steveharter","html_url":"https://github.com/steveharter","followers_url":"https://api.github.com/users/steveharter/followers","following_url":"https://api.github.com/users/steveharter/following{/other_user}","gists_url":"https://api.github.com/users/steveharter/gists{/gist_id}","starred_url":"https://api.github.com/users/steveharter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveharter/subscriptions","organizations_url":"https://api.github.com/users/steveharter/orgs","repos_url":"https://api.github.com/users/steveharter/repos","events_url":"https://api.github.com/users/steveharter/events{/privacy}","received_events_url":"https://api.github.com/users/steveharter/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/corefx/labels/area-System.Security","name":"area-System.Security","color":"d4c5f9"},{"url":"https://api.github.com/repos/dotnet/corefx/labels/netstandard2.0","name":"netstandard2.0","color":"c5def5"}],"state":"open","locked":false,"assignee":{"login":"steveharter","id":6986755,"avatar_url":"https://avatars.githubusercontent.com/u/6986755?v=3","gravatar_id":"","url":"https://api.github.com/users/steveharter","html_url":"https://github.com/steveharter","followers_url":"https://api.github.com/users/steveharter/followers","following_url":"https://api.github.com/users/steveharter/following{/other_user}","gists_url":"https://api.github.com/users/steveharter/gists{/gist_id}","starred_url":"https://api.github.com/users/steveharter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveharter/subscriptions","organizations_url":"https://api.github.com/users/steveharter/orgs","repos_url":"https://api.github.com/users/steveharter/repos","events_url":"https://api.github.com/users/steveharter/events{/privacy}","received_events_url":"https://api.github.com/users/steveharter/received_events","type":"User","site_admin":false},"assignees":[{"login":"steveharter","id":6986755,"avatar_url":"https://avatars.githubusercontent.com/u/6986755?v=3","gravatar_id":"","url":"https://api.github.com/users/steveharter","html_url":"https://github.com/steveharter","followers_url":"https://api.github.com/users/steveharter/followers","following_url":"https://api.github.com/users/steveharter/following{/other_user}","gists_url":"https://api.github.com/users/steveharter/gists{/gist_id}","starred_url":"https://api.github.com/users/steveharter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveharter/subscriptions","organizations_url":"https://api.github.com/users/steveharter/orgs","repos_url":"https://api.github.com/users/steveharter/repos","events_url":"https://api.github.com/users/steveharter/events{/privacy}","received_events_url":"https://api.github.com/users/steveharter/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/corefx/milestones/4","html_url":"https://github.com/dotnet/corefx/milestones/1.2.0","labels_url":"https://api.github.com/repos/dotnet/corefx/milestones/4/labels","id":1248719,"number":4,"title":"1.2.0","description":".NET Core 1.2 Placeholder.  https://github.com/dotnet/core/blob/master/roadmap.md","creator":{"login":"joshfree","id":1302850,"avatar_url":"https://avatars.githubusercontent.com/u/1302850?v=3","gravatar_id":"","url":"https://api.github.com/users/joshfree","html_url":"https://github.com/joshfree","followers_url":"https://api.github.com/users/joshfree/followers","following_url":"https://api.github.com/users/joshfree/following{/other_user}","gists_url":"https://api.github.com/users/joshfree/gists{/gist_id}","starred_url":"https://api.github.com/users/joshfree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshfree/subscriptions","organizations_url":"https://api.github.com/users/joshfree/orgs","repos_url":"https://api.github.com/users/joshfree/repos","events_url":"https://api.github.com/users/joshfree/events{/privacy}","received_events_url":"https://api.github.com/users/joshfree/received_events","type":"User","site_admin":false},"open_issues":649,"closed_issues":1185,"state":"open","created_at":"2015-08-10T18:04:00Z","updated_at":"2016-10-03T18:28:40Z","due_on":"2017-04-30T07:00:00Z","closed_at":null},"comments":0,"created_at":"2016-10-03T18:28:40Z","updated_at":"2016-10-03T18:28:40Z","closed_at":null,"body":"Default value is 64. Must also ensure any other HMAC-derived classes including\r\nAes (128)\r\nDES (64)\r\nHMACSHA1 (64)\r\nHMACSHA256 (64)\r\nHMACSHA384 (64?/128)\r\nHMACSHA512 (64?/128)\r\nRC2 (64)\r\nRijndael (128)\r\nTripleDES (64)\r\n\r\n````\r\n        protected int BlockSizeValue {\r\n            get {}\r\n            set {}        \r\n        }       \r\n````\r\n\r\nConsider HMACSHA* netfx code with comments such as\r\n````\r\n        /// <summary>\r\n        ///     In Whidbey we incorrectly used a block size of 64 bytes for HMAC-SHA-384 and HMAC-SHA-512,\r\n        ///     rather than using the correct value of 128 bytes.  Setting this to true causes us to fall\r\n        ///     back to the Whidbey mode which produces incorrect HMAC values.\r\n        ///     \r\n        ///     This value should be set only once, before hashing has begun, since we need to reset the key\r\n        ///     buffer for the block size change to take effect.\r\n        ///     \r\n        ///     The default vaue is off, however this can be toggled for the application by setting the\r\n        ///     legacyHMACMode config switch.\r\n        /// </summary>\r\n        public bool ProduceLegacyHmacValues {\r\n            get { return m_useLegacyBlockSize; }\r\n\r\n            set {\r\n                m_useLegacyBlockSize = value;\r\n\r\n                BlockSizeValue = BlockSize;\r\n                InitializeKey(KeyValue);\r\n            }\r\n        }\r\n````"}}
{"actor":{"display_login":"steveharter"}}