{"action":"opened","number":3274,"pull_request":{"url":"https://api.github.com/repos/pantsbuild/pants/pulls/3274","id":67924383,"html_url":"https://github.com/pantsbuild/pants/pull/3274","diff_url":"https://github.com/pantsbuild/pants/pull/3274.diff","patch_url":"https://github.com/pantsbuild/pants/pull/3274.patch","issue_url":"https://api.github.com/repos/pantsbuild/pants/issues/3274","number":3274,"state":"open","locked":false,"title":"[engine] bug fix: to get/put within the proper context","user":{"login":"peiyuwang","id":2474428,"avatar_url":"https://avatars.githubusercontent.com/u/2474428?v=3","gravatar_id":"","url":"https://api.github.com/users/peiyuwang","html_url":"https://github.com/peiyuwang","followers_url":"https://api.github.com/users/peiyuwang/followers","following_url":"https://api.github.com/users/peiyuwang/following{/other_user}","gists_url":"https://api.github.com/users/peiyuwang/gists{/gist_id}","starred_url":"https://api.github.com/users/peiyuwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peiyuwang/subscriptions","organizations_url":"https://api.github.com/users/peiyuwang/orgs","repos_url":"https://api.github.com/users/peiyuwang/repos","events_url":"https://api.github.com/users/peiyuwang/events{/privacy}","received_events_url":"https://api.github.com/users/peiyuwang/received_events","type":"User","site_admin":false},"body":"We have two places that `get` and `put` from/to storage are not used within\r\nthe proper context.\r\n\r\n* StringIO buffer for write, saving buffer to storage happens outside its context.\r\n* lmdb buffer for read, the invalid buffer was used outside transction context.\r\n\r\nThe earlier attempt is red herring: https://rbcommons.com/s/twitter/r/3751/.\r\n\r\nThese two behaviors are clearly documented, see [1] and [2].\r\n[1] https://docs.python.org/2/library/stringio.html\r\n[2] https://lmdb.readthedocs.org/en/release/","created_at":"2016-04-26T17:18:50Z","updated_at":"2016-04-26T17:18:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pantsbuild/pants/pulls/3274/commits","review_comments_url":"https://api.github.com/repos/pantsbuild/pants/pulls/3274/comments","review_comment_url":"https://api.github.com/repos/pantsbuild/pants/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pantsbuild/pants/issues/3274/comments","statuses_url":"https://api.github.com/repos/pantsbuild/pants/statuses/26d37e6b97391cd97941e00dd75d22c452d92ab8","head":{"label":"peiyuwang:peiyu/fix-closing-scope","ref":"peiyu/fix-closing-scope","sha":"26d37e6b97391cd97941e00dd75d22c452d92ab8","user":{"login":"peiyuwang","id":2474428,"avatar_url":"https://avatars.githubusercontent.com/u/2474428?v=3","gravatar_id":"","url":"https://api.github.com/users/peiyuwang","html_url":"https://github.com/peiyuwang","followers_url":"https://api.github.com/users/peiyuwang/followers","following_url":"https://api.github.com/users/peiyuwang/following{/other_user}","gists_url":"https://api.github.com/users/peiyuwang/gists{/gist_id}","starred_url":"https://api.github.com/users/peiyuwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peiyuwang/subscriptions","organizations_url":"https://api.github.com/users/peiyuwang/orgs","repos_url":"https://api.github.com/users/peiyuwang/repos","events_url":"https://api.github.com/users/peiyuwang/events{/privacy}","received_events_url":"https://api.github.com/users/peiyuwang/received_events","type":"User","site_admin":false},"repo":{"id":27841884,"name":"pants","full_name":"peiyuwang/pants","owner":{"login":"peiyuwang","id":2474428,"avatar_url":"https://avatars.githubusercontent.com/u/2474428?v=3","gravatar_id":"","url":"https://api.github.com/users/peiyuwang","html_url":"https://github.com/peiyuwang","followers_url":"https://api.github.com/users/peiyuwang/followers","following_url":"https://api.github.com/users/peiyuwang/following{/other_user}","gists_url":"https://api.github.com/users/peiyuwang/gists{/gist_id}","starred_url":"https://api.github.com/users/peiyuwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peiyuwang/subscriptions","organizations_url":"https://api.github.com/users/peiyuwang/orgs","repos_url":"https://api.github.com/users/peiyuwang/repos","events_url":"https://api.github.com/users/peiyuwang/events{/privacy}","received_events_url":"https://api.github.com/users/peiyuwang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peiyuwang/pants","description":"Pants Build System","fork":true,"url":"https://api.github.com/repos/peiyuwang/pants","forks_url":"https://api.github.com/repos/peiyuwang/pants/forks","keys_url":"https://api.github.com/repos/peiyuwang/pants/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peiyuwang/pants/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peiyuwang/pants/teams","hooks_url":"https://api.github.com/repos/peiyuwang/pants/hooks","issue_events_url":"https://api.github.com/repos/peiyuwang/pants/issues/events{/number}","events_url":"https://api.github.com/repos/peiyuwang/pants/events","assignees_url":"https://api.github.com/repos/peiyuwang/pants/assignees{/user}","branches_url":"https://api.github.com/repos/peiyuwang/pants/branches{/branch}","tags_url":"https://api.github.com/repos/peiyuwang/pants/tags","blobs_url":"https://api.github.com/repos/peiyuwang/pants/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peiyuwang/pants/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peiyuwang/pants/git/refs{/sha}","trees_url":"https://api.github.com/repos/peiyuwang/pants/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peiyuwang/pants/statuses/{sha}","languages_url":"https://api.github.com/repos/peiyuwang/pants/languages","stargazers_url":"https://api.github.com/repos/peiyuwang/pants/stargazers","contributors_url":"https://api.github.com/repos/peiyuwang/pants/contributors","subscribers_url":"https://api.github.com/repos/peiyuwang/pants/subscribers","subscription_url":"https://api.github.com/repos/peiyuwang/pants/subscription","commits_url":"https://api.github.com/repos/peiyuwang/pants/commits{/sha}","git_commits_url":"https://api.github.com/repos/peiyuwang/pants/git/commits{/sha}","comments_url":"https://api.github.com/repos/peiyuwang/pants/comments{/number}","issue_comment_url":"https://api.github.com/repos/peiyuwang/pants/issues/comments{/number}","contents_url":"https://api.github.com/repos/peiyuwang/pants/contents/{+path}","compare_url":"https://api.github.com/repos/peiyuwang/pants/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peiyuwang/pants/merges","archive_url":"https://api.github.com/repos/peiyuwang/pants/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peiyuwang/pants/downloads","issues_url":"https://api.github.com/repos/peiyuwang/pants/issues{/number}","pulls_url":"https://api.github.com/repos/peiyuwang/pants/pulls{/number}","milestones_url":"https://api.github.com/repos/peiyuwang/pants/milestones{/number}","notifications_url":"https://api.github.com/repos/peiyuwang/pants/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peiyuwang/pants/labels{/name}","releases_url":"https://api.github.com/repos/peiyuwang/pants/releases{/id}","deployments_url":"https://api.github.com/repos/peiyuwang/pants/deployments","created_at":"2014-12-10T22:02:15Z","updated_at":"2016-04-25T06:47:59Z","pushed_at":"2016-04-26T17:14:25Z","git_url":"git://github.com/peiyuwang/pants.git","ssh_url":"git@github.com:peiyuwang/pants.git","clone_url":"https://github.com/peiyuwang/pants.git","svn_url":"https://github.com/peiyuwang/pants","homepage":"http://pantsbuild.github.io/","size":67395,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pantsbuild:master","ref":"master","sha":"d108834aaa494dfa7f04233e5518120d0e67d246","user":{"login":"pantsbuild","id":3065172,"avatar_url":"https://avatars.githubusercontent.com/u/3065172?v=3","gravatar_id":"","url":"https://api.github.com/users/pantsbuild","html_url":"https://github.com/pantsbuild","followers_url":"https://api.github.com/users/pantsbuild/followers","following_url":"https://api.github.com/users/pantsbuild/following{/other_user}","gists_url":"https://api.github.com/users/pantsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/pantsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantsbuild/subscriptions","organizations_url":"https://api.github.com/users/pantsbuild/orgs","repos_url":"https://api.github.com/users/pantsbuild/repos","events_url":"https://api.github.com/users/pantsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/pantsbuild/received_events","type":"Organization","site_admin":false},"repo":{"id":7209075,"name":"pants","full_name":"pantsbuild/pants","owner":{"login":"pantsbuild","id":3065172,"avatar_url":"https://avatars.githubusercontent.com/u/3065172?v=3","gravatar_id":"","url":"https://api.github.com/users/pantsbuild","html_url":"https://github.com/pantsbuild","followers_url":"https://api.github.com/users/pantsbuild/followers","following_url":"https://api.github.com/users/pantsbuild/following{/other_user}","gists_url":"https://api.github.com/users/pantsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/pantsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantsbuild/subscriptions","organizations_url":"https://api.github.com/users/pantsbuild/orgs","repos_url":"https://api.github.com/users/pantsbuild/repos","events_url":"https://api.github.com/users/pantsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/pantsbuild/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pantsbuild/pants","description":"Pants Build System","fork":false,"url":"https://api.github.com/repos/pantsbuild/pants","forks_url":"https://api.github.com/repos/pantsbuild/pants/forks","keys_url":"https://api.github.com/repos/pantsbuild/pants/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pantsbuild/pants/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pantsbuild/pants/teams","hooks_url":"https://api.github.com/repos/pantsbuild/pants/hooks","issue_events_url":"https://api.github.com/repos/pantsbuild/pants/issues/events{/number}","events_url":"https://api.github.com/repos/pantsbuild/pants/events","assignees_url":"https://api.github.com/repos/pantsbuild/pants/assignees{/user}","branches_url":"https://api.github.com/repos/pantsbuild/pants/branches{/branch}","tags_url":"https://api.github.com/repos/pantsbuild/pants/tags","blobs_url":"https://api.github.com/repos/pantsbuild/pants/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pantsbuild/pants/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pantsbuild/pants/git/refs{/sha}","trees_url":"https://api.github.com/repos/pantsbuild/pants/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pantsbuild/pants/statuses/{sha}","languages_url":"https://api.github.com/repos/pantsbuild/pants/languages","stargazers_url":"https://api.github.com/repos/pantsbuild/pants/stargazers","contributors_url":"https://api.github.com/repos/pantsbuild/pants/contributors","subscribers_url":"https://api.github.com/repos/pantsbuild/pants/subscribers","subscription_url":"https://api.github.com/repos/pantsbuild/pants/subscription","commits_url":"https://api.github.com/repos/pantsbuild/pants/commits{/sha}","git_commits_url":"https://api.github.com/repos/pantsbuild/pants/git/commits{/sha}","comments_url":"https://api.github.com/repos/pantsbuild/pants/comments{/number}","issue_comment_url":"https://api.github.com/repos/pantsbuild/pants/issues/comments{/number}","contents_url":"https://api.github.com/repos/pantsbuild/pants/contents/{+path}","compare_url":"https://api.github.com/repos/pantsbuild/pants/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pantsbuild/pants/merges","archive_url":"https://api.github.com/repos/pantsbuild/pants/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pantsbuild/pants/downloads","issues_url":"https://api.github.com/repos/pantsbuild/pants/issues{/number}","pulls_url":"https://api.github.com/repos/pantsbuild/pants/pulls{/number}","milestones_url":"https://api.github.com/repos/pantsbuild/pants/milestones{/number}","notifications_url":"https://api.github.com/repos/pantsbuild/pants/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pantsbuild/pants/labels{/name}","releases_url":"https://api.github.com/repos/pantsbuild/pants/releases{/id}","deployments_url":"https://api.github.com/repos/pantsbuild/pants/deployments","created_at":"2012-12-17T17:39:04Z","updated_at":"2016-04-26T09:40:03Z","pushed_at":"2016-04-26T17:18:51Z","git_url":"git://github.com/pantsbuild/pants.git","ssh_url":"git@github.com:pantsbuild/pants.git","clone_url":"https://github.com/pantsbuild/pants.git","svn_url":"https://github.com/pantsbuild/pants","homepage":"http://pantsbuild.github.io/","size":82639,"stargazers_count":496,"watchers_count":496,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":154,"mirror_url":null,"open_issues_count":359,"forks":154,"open_issues":359,"watchers":496,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/3274"},"html":{"href":"https://github.com/pantsbuild/pants/pull/3274"},"issue":{"href":"https://api.github.com/repos/pantsbuild/pants/issues/3274"},"comments":{"href":"https://api.github.com/repos/pantsbuild/pants/issues/3274/comments"},"review_comments":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/3274/comments"},"review_comment":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/3274/commits"},"statuses":{"href":"https://api.github.com/repos/pantsbuild/pants/statuses/26d37e6b97391cd97941e00dd75d22c452d92ab8"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":4,"additions":21,"deletions":17,"changed_files":2}}