{"action":"closed","number":190,"pull_request":{"url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/pulls/190","id":86004058,"html_url":"https://github.com/Brightspace/d2l-navigation-ui/pull/190","diff_url":"https://github.com/Brightspace/d2l-navigation-ui/pull/190.diff","patch_url":"https://github.com/Brightspace/d2l-navigation-ui/pull/190.patch","issue_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/issues/190","number":190,"state":"closed","locked":false,"title":"Adjusting z-index of mobile menu to be much greater","user":{"login":"capajon","id":5125171,"avatar_url":"https://avatars.githubusercontent.com/u/5125171?v=3","gravatar_id":"","url":"https://api.github.com/users/capajon","html_url":"https://github.com/capajon","followers_url":"https://api.github.com/users/capajon/followers","following_url":"https://api.github.com/users/capajon/following{/other_user}","gists_url":"https://api.github.com/users/capajon/gists{/gist_id}","starred_url":"https://api.github.com/users/capajon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/capajon/subscriptions","organizations_url":"https://api.github.com/users/capajon/orgs","repos_url":"https://api.github.com/users/capajon/repos","events_url":"https://api.github.com/users/capajon/events{/privacy}","received_events_url":"https://api.github.com/users/capajon/received_events","type":"User","site_admin":false},"body":"@dlockhart z-indexes... ughhh.\r\n\r\nHere's some I found in the LMS for reference\r\nFlating buttons - 999 (this is the one I wanted to make sure the menu is above)\r\nDialogs - 1002\r\nDropdown - 1000\r\nConfirmation alerts - 10000\r\n\r\nI did some searching on github too.  There are a lot of z-indexes in our FRAs, most seem < 9000 and greater than 500 or so.  Not sure which are nested of course.\r\n\r\nAnyway, 9000 seemed right to me.  We want alerts to be highest 'priority' I believe, but otherwise the mobile menu should probably win out against almost everything else... I think.\r\n\r\nAnd over 9000? Seems right out.\r\n![image](https://cloud.githubusercontent.com/assets/5125171/18677937/7ad5096c-7f28-11e6-9fc9-c8a4e8c0cea0.png)\r\n\r\nFloating buttons might need to be adjusted too, to be lower, but there is no grievous scenario I am aware of right now so I'll just leave it alone.","created_at":"2016-09-20T15:53:20Z","updated_at":"2016-09-22T18:05:48Z","closed_at":"2016-09-22T18:05:48Z","merged_at":"2016-09-22T18:05:48Z","merge_commit_sha":"902a246e83acccf415fc569ec876e9d419bd8e36","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/pulls/190/commits","review_comments_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/pulls/190/comments","review_comment_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/issues/190/comments","statuses_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/statuses/54b6fc6ac825da4b5f7dfb4c87e34bf9bc27c109","head":{"label":"Brightspace:Adjusting-Z-Index","ref":"Adjusting-Z-Index","sha":"54b6fc6ac825da4b5f7dfb4c87e34bf9bc27c109","user":{"login":"Brightspace","id":5429170,"avatar_url":"https://avatars.githubusercontent.com/u/5429170?v=3","gravatar_id":"","url":"https://api.github.com/users/Brightspace","html_url":"https://github.com/Brightspace","followers_url":"https://api.github.com/users/Brightspace/followers","following_url":"https://api.github.com/users/Brightspace/following{/other_user}","gists_url":"https://api.github.com/users/Brightspace/gists{/gist_id}","starred_url":"https://api.github.com/users/Brightspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brightspace/subscriptions","organizations_url":"https://api.github.com/users/Brightspace/orgs","repos_url":"https://api.github.com/users/Brightspace/repos","events_url":"https://api.github.com/users/Brightspace/events{/privacy}","received_events_url":"https://api.github.com/users/Brightspace/received_events","type":"Organization","site_admin":false},"repo":{"id":53450848,"name":"d2l-navigation-ui","full_name":"Brightspace/d2l-navigation-ui","owner":{"login":"Brightspace","id":5429170,"avatar_url":"https://avatars.githubusercontent.com/u/5429170?v=3","gravatar_id":"","url":"https://api.github.com/users/Brightspace","html_url":"https://github.com/Brightspace","followers_url":"https://api.github.com/users/Brightspace/followers","following_url":"https://api.github.com/users/Brightspace/following{/other_user}","gists_url":"https://api.github.com/users/Brightspace/gists{/gist_id}","starred_url":"https://api.github.com/users/Brightspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brightspace/subscriptions","organizations_url":"https://api.github.com/users/Brightspace/orgs","repos_url":"https://api.github.com/users/Brightspace/repos","events_url":"https://api.github.com/users/Brightspace/events{/privacy}","received_events_url":"https://api.github.com/users/Brightspace/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Brightspace/d2l-navigation-ui","description":"Web component for the Daylight navigation in Brightspace","fork":false,"url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui","forks_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/forks","keys_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/teams","hooks_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/hooks","issue_events_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/issues/events{/number}","events_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/events","assignees_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/assignees{/user}","branches_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/branches{/branch}","tags_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/tags","blobs_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/languages","stargazers_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/stargazers","contributors_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/contributors","subscribers_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/subscribers","subscription_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/subscription","commits_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/contents/{+path}","compare_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/merges","archive_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/downloads","issues_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/issues{/number}","pulls_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/labels{/name}","releases_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/releases{/id}","deployments_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/deployments","created_at":"2016-03-08T22:47:48Z","updated_at":"2016-04-29T19:22:44Z","pushed_at":"2016-09-22T18:05:48Z","git_url":"git://github.com/Brightspace/d2l-navigation-ui.git","ssh_url":"git@github.com:Brightspace/d2l-navigation-ui.git","clone_url":"https://github.com/Brightspace/d2l-navigation-ui.git","svn_url":"https://github.com/Brightspace/d2l-navigation-ui","homepage":"","size":392,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":6,"forks":3,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"Brightspace:master","ref":"master","sha":"a3f8839ce882630b5263745ba6dc8a5adf1c3f5f","user":{"login":"Brightspace","id":5429170,"avatar_url":"https://avatars.githubusercontent.com/u/5429170?v=3","gravatar_id":"","url":"https://api.github.com/users/Brightspace","html_url":"https://github.com/Brightspace","followers_url":"https://api.github.com/users/Brightspace/followers","following_url":"https://api.github.com/users/Brightspace/following{/other_user}","gists_url":"https://api.github.com/users/Brightspace/gists{/gist_id}","starred_url":"https://api.github.com/users/Brightspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brightspace/subscriptions","organizations_url":"https://api.github.com/users/Brightspace/orgs","repos_url":"https://api.github.com/users/Brightspace/repos","events_url":"https://api.github.com/users/Brightspace/events{/privacy}","received_events_url":"https://api.github.com/users/Brightspace/received_events","type":"Organization","site_admin":false},"repo":{"id":53450848,"name":"d2l-navigation-ui","full_name":"Brightspace/d2l-navigation-ui","owner":{"login":"Brightspace","id":5429170,"avatar_url":"https://avatars.githubusercontent.com/u/5429170?v=3","gravatar_id":"","url":"https://api.github.com/users/Brightspace","html_url":"https://github.com/Brightspace","followers_url":"https://api.github.com/users/Brightspace/followers","following_url":"https://api.github.com/users/Brightspace/following{/other_user}","gists_url":"https://api.github.com/users/Brightspace/gists{/gist_id}","starred_url":"https://api.github.com/users/Brightspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brightspace/subscriptions","organizations_url":"https://api.github.com/users/Brightspace/orgs","repos_url":"https://api.github.com/users/Brightspace/repos","events_url":"https://api.github.com/users/Brightspace/events{/privacy}","received_events_url":"https://api.github.com/users/Brightspace/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Brightspace/d2l-navigation-ui","description":"Web component for the Daylight navigation in Brightspace","fork":false,"url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui","forks_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/forks","keys_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/teams","hooks_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/hooks","issue_events_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/issues/events{/number}","events_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/events","assignees_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/assignees{/user}","branches_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/branches{/branch}","tags_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/tags","blobs_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/languages","stargazers_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/stargazers","contributors_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/contributors","subscribers_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/subscribers","subscription_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/subscription","commits_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/contents/{+path}","compare_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/merges","archive_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/downloads","issues_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/issues{/number}","pulls_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/labels{/name}","releases_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/releases{/id}","deployments_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/deployments","created_at":"2016-03-08T22:47:48Z","updated_at":"2016-04-29T19:22:44Z","pushed_at":"2016-09-22T18:05:48Z","git_url":"git://github.com/Brightspace/d2l-navigation-ui.git","ssh_url":"git@github.com:Brightspace/d2l-navigation-ui.git","clone_url":"https://github.com/Brightspace/d2l-navigation-ui.git","svn_url":"https://github.com/Brightspace/d2l-navigation-ui","homepage":"","size":392,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":6,"forks":3,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/pulls/190"},"html":{"href":"https://github.com/Brightspace/d2l-navigation-ui/pull/190"},"issue":{"href":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/issues/190"},"comments":{"href":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/issues/190/comments"},"review_comments":{"href":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/pulls/190/comments"},"review_comment":{"href":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/pulls/190/commits"},"statuses":{"href":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/statuses/54b6fc6ac825da4b5f7dfb4c87e34bf9bc27c109"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"capajon","id":5125171,"avatar_url":"https://avatars.githubusercontent.com/u/5125171?v=3","gravatar_id":"","url":"https://api.github.com/users/capajon","html_url":"https://github.com/capajon","followers_url":"https://api.github.com/users/capajon/followers","following_url":"https://api.github.com/users/capajon/following{/other_user}","gists_url":"https://api.github.com/users/capajon/gists{/gist_id}","starred_url":"https://api.github.com/users/capajon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/capajon/subscriptions","organizations_url":"https://api.github.com/users/capajon/orgs","repos_url":"https://api.github.com/users/capajon/repos","events_url":"https://api.github.com/users/capajon/events{/privacy}","received_events_url":"https://api.github.com/users/capajon/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"capajon"}}