{"action":"created","issue":{"url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2228","repository_url":"https://api.github.com/repos/MovingBlocks/Terasology","labels_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2228/labels{/name}","comments_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2228/comments","events_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2228/events","html_url":"https://github.com/MovingBlocks/Terasology/pull/2228","id":140450191,"number":2228,"title":"More avoiding dividing by zero in the inventory grid","user":{"login":"Josharias","id":5922109,"avatar_url":"https://avatars.githubusercontent.com/u/5922109?v=3","gravatar_id":"","url":"https://api.github.com/users/Josharias","html_url":"https://github.com/Josharias","followers_url":"https://api.github.com/users/Josharias/followers","following_url":"https://api.github.com/users/Josharias/following{/other_user}","gists_url":"https://api.github.com/users/Josharias/gists{/gist_id}","starred_url":"https://api.github.com/users/Josharias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Josharias/subscriptions","organizations_url":"https://api.github.com/users/Josharias/orgs","repos_url":"https://api.github.com/users/Josharias/repos","events_url":"https://api.github.com/users/Josharias/events{/privacy}","received_events_url":"https://api.github.com/users/Josharias/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/MovingBlocks/Terasology/labels/Bug","name":"Bug","color":"e10c02"},{"url":"https://api.github.com/repos/MovingBlocks/Terasology/labels/in%20progress","name":"in progress","color":"ededed"},{"url":"https://api.github.com/repos/MovingBlocks/Terasology/labels/UI","name":"UI","color":"06FF06"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-03-13T05:21:36Z","updated_at":"2016-03-28T13:21:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2228","html_url":"https://github.com/MovingBlocks/Terasology/pull/2228","diff_url":"https://github.com/MovingBlocks/Terasology/pull/2228.diff","patch_url":"https://github.com/MovingBlocks/Terasology/pull/2228.patch"},"body":"### Contains\r\n\r\nFixes another issue like #2212 after applying #2227 which makes the item icons bigger than the canvas.  In this divide by zero problem,  the canvas is smaller than the inventory item and so it rounds down horizontalCells to 0,  causing another divide by zero problem.  This will make it still draw the item even though it may not fit correctly.\r\n\r\n### How to test\r\n\r\nAfter opening a wooden workbench (hit two side by side logs on the top) and getting some craftable items (and able to see the results thanks to #2227), it would crash at this point."},"comment":{"url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/comments/202388824","html_url":"https://github.com/MovingBlocks/Terasology/pull/2228#issuecomment-202388824","issue_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2228","id":202388824,"user":{"login":"skaldarnar","id":1448874,"avatar_url":"https://avatars.githubusercontent.com/u/1448874?v=3","gravatar_id":"","url":"https://api.github.com/users/skaldarnar","html_url":"https://github.com/skaldarnar","followers_url":"https://api.github.com/users/skaldarnar/followers","following_url":"https://api.github.com/users/skaldarnar/following{/other_user}","gists_url":"https://api.github.com/users/skaldarnar/gists{/gist_id}","starred_url":"https://api.github.com/users/skaldarnar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skaldarnar/subscriptions","organizations_url":"https://api.github.com/users/skaldarnar/orgs","repos_url":"https://api.github.com/users/skaldarnar/repos","events_url":"https://api.github.com/users/skaldarnar/events{/privacy}","received_events_url":"https://api.github.com/users/skaldarnar/received_events","type":"User","site_admin":false},"created_at":"2016-03-28T13:21:49Z","updated_at":"2016-03-28T13:21:49Z","body":"It fixes one issue, making way for another one. Crafting with the workbench is still not possible as the actual crafting process crashes (again with division by zero). \r\nI'd like to say we should either get the workbench crafting working again (continue work on this issue) or merge and make a new issue for the new crash situation."}}