{"action":"closed","number":4893,"pull_request":{"url":"https://api.github.com/repos/systemd/systemd/pulls/4893","id":98172754,"html_url":"https://github.com/systemd/systemd/pull/4893","diff_url":"https://github.com/systemd/systemd/pull/4893.diff","patch_url":"https://github.com/systemd/systemd/pull/4893.patch","issue_url":"https://api.github.com/repos/systemd/systemd/issues/4893","number":4893,"state":"closed","locked":false,"title":"rules: identify internal sound cards on platform bus","user":{"login":"dsd","id":81864,"avatar_url":"https://avatars.githubusercontent.com/u/81864?v=3","gravatar_id":"","url":"https://api.github.com/users/dsd","html_url":"https://github.com/dsd","followers_url":"https://api.github.com/users/dsd/followers","following_url":"https://api.github.com/users/dsd/following{/other_user}","gists_url":"https://api.github.com/users/dsd/gists{/gist_id}","starred_url":"https://api.github.com/users/dsd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsd/subscriptions","organizations_url":"https://api.github.com/users/dsd/orgs","repos_url":"https://api.github.com/users/dsd/repos","events_url":"https://api.github.com/users/dsd/events{/privacy}","received_events_url":"https://api.github.com/users/dsd/received_events","type":"User","site_admin":false},"body":"We have a system which has the HDMI audio capability internally,\r\nbut pulseaudio is not giving it a very high priority compared\r\nto e.g. USB sound cards.\r\n\r\nThe sound device appears on the platform bus and it is not\r\ncurrently tagged with any form factor information.\r\n\r\nIt seems safe to assume that any sound card that is directly on the\r\nplatform bus is of internal form factor, but we must be careful because\r\nudev rules will match all parent devices, not just the immediate parent,\r\nand you will frequently encounter setups such as:\r\n\r\n Platform bus -> USB host controller -> USB sound card\r\n\r\nIn that case, SUBSYSTEMS==platform would match even though we're\r\nclearly working with an external USB sound card.\r\n\r\nIn order to detect true platform devices here, we rely on the observation\r\nthat if any parent devices of the sound card are PCI, USB or firewire\r\ndevices, then this sound card cannot directly connected to the platform\r\nbus. Otherwise, if we find a parent device on the platform bus, we assume\r\nthis is an internal sound card connected directly to the platform bus.","created_at":"2016-12-15T15:33:13Z","updated_at":"2016-12-15T22:11:11Z","closed_at":"2016-12-15T22:11:11Z","merged_at":"2016-12-15T22:11:11Z","merge_commit_sha":"d84071d569700547f6283061d5f66b585ec952b3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/systemd/systemd/pulls/4893/commits","review_comments_url":"https://api.github.com/repos/systemd/systemd/pulls/4893/comments","review_comment_url":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/systemd/systemd/issues/4893/comments","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/0cb200b9f78b66617b509f01419742c92520d9e6","head":{"label":"dsd:master","ref":"master","sha":"0cb200b9f78b66617b509f01419742c92520d9e6","user":{"login":"dsd","id":81864,"avatar_url":"https://avatars.githubusercontent.com/u/81864?v=3","gravatar_id":"","url":"https://api.github.com/users/dsd","html_url":"https://github.com/dsd","followers_url":"https://api.github.com/users/dsd/followers","following_url":"https://api.github.com/users/dsd/following{/other_user}","gists_url":"https://api.github.com/users/dsd/gists{/gist_id}","starred_url":"https://api.github.com/users/dsd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsd/subscriptions","organizations_url":"https://api.github.com/users/dsd/orgs","repos_url":"https://api.github.com/users/dsd/repos","events_url":"https://api.github.com/users/dsd/events{/privacy}","received_events_url":"https://api.github.com/users/dsd/received_events","type":"User","site_admin":false},"repo":{"id":76571856,"name":"systemd","full_name":"dsd/systemd","owner":{"login":"dsd","id":81864,"avatar_url":"https://avatars.githubusercontent.com/u/81864?v=3","gravatar_id":"","url":"https://api.github.com/users/dsd","html_url":"https://github.com/dsd","followers_url":"https://api.github.com/users/dsd/followers","following_url":"https://api.github.com/users/dsd/following{/other_user}","gists_url":"https://api.github.com/users/dsd/gists{/gist_id}","starred_url":"https://api.github.com/users/dsd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsd/subscriptions","organizations_url":"https://api.github.com/users/dsd/orgs","repos_url":"https://api.github.com/users/dsd/repos","events_url":"https://api.github.com/users/dsd/events{/privacy}","received_events_url":"https://api.github.com/users/dsd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dsd/systemd","description":"systemd upstream","fork":true,"url":"https://api.github.com/repos/dsd/systemd","forks_url":"https://api.github.com/repos/dsd/systemd/forks","keys_url":"https://api.github.com/repos/dsd/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dsd/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dsd/systemd/teams","hooks_url":"https://api.github.com/repos/dsd/systemd/hooks","issue_events_url":"https://api.github.com/repos/dsd/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/dsd/systemd/events","assignees_url":"https://api.github.com/repos/dsd/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/dsd/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/dsd/systemd/tags","blobs_url":"https://api.github.com/repos/dsd/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dsd/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dsd/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/dsd/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dsd/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/dsd/systemd/languages","stargazers_url":"https://api.github.com/repos/dsd/systemd/stargazers","contributors_url":"https://api.github.com/repos/dsd/systemd/contributors","subscribers_url":"https://api.github.com/repos/dsd/systemd/subscribers","subscription_url":"https://api.github.com/repos/dsd/systemd/subscription","commits_url":"https://api.github.com/repos/dsd/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/dsd/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/dsd/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/dsd/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/dsd/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/dsd/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dsd/systemd/merges","archive_url":"https://api.github.com/repos/dsd/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dsd/systemd/downloads","issues_url":"https://api.github.com/repos/dsd/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/dsd/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/dsd/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/dsd/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dsd/systemd/labels{/name}","releases_url":"https://api.github.com/repos/dsd/systemd/releases{/id}","deployments_url":"https://api.github.com/repos/dsd/systemd/deployments","created_at":"2016-12-15T15:31:52Z","updated_at":"2016-12-15T15:59:24Z","pushed_at":"2016-12-15T15:32:27Z","git_url":"git://github.com/dsd/systemd.git","ssh_url":"git@github.com:dsd/systemd.git","clone_url":"https://github.com/dsd/systemd.git","svn_url":"https://github.com/dsd/systemd","homepage":"http://www.freedesktop.org/wiki/Software/systemd/","size":64664,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"systemd:master","ref":"master","sha":"fc2371c7b1b41c2e3c8123317933322173f8abae","user":{"login":"systemd","id":1918868,"avatar_url":"https://avatars.githubusercontent.com/u/1918868?v=3","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"repo":{"id":32873313,"name":"systemd","full_name":"systemd/systemd","owner":{"login":"systemd","id":1918868,"avatar_url":"https://avatars.githubusercontent.com/u/1918868?v=3","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/systemd/systemd","description":"systemd upstream","fork":false,"url":"https://api.github.com/repos/systemd/systemd","forks_url":"https://api.github.com/repos/systemd/systemd/forks","keys_url":"https://api.github.com/repos/systemd/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/systemd/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/systemd/systemd/teams","hooks_url":"https://api.github.com/repos/systemd/systemd/hooks","issue_events_url":"https://api.github.com/repos/systemd/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/systemd/systemd/events","assignees_url":"https://api.github.com/repos/systemd/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/systemd/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/systemd/systemd/tags","blobs_url":"https://api.github.com/repos/systemd/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/systemd/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/systemd/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/systemd/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/systemd/systemd/languages","stargazers_url":"https://api.github.com/repos/systemd/systemd/stargazers","contributors_url":"https://api.github.com/repos/systemd/systemd/contributors","subscribers_url":"https://api.github.com/repos/systemd/systemd/subscribers","subscription_url":"https://api.github.com/repos/systemd/systemd/subscription","commits_url":"https://api.github.com/repos/systemd/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/systemd/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/systemd/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/systemd/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/systemd/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/systemd/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/systemd/systemd/merges","archive_url":"https://api.github.com/repos/systemd/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/systemd/systemd/downloads","issues_url":"https://api.github.com/repos/systemd/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/systemd/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/systemd/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/systemd/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/systemd/systemd/labels{/name}","releases_url":"https://api.github.com/repos/systemd/systemd/releases{/id}","deployments_url":"https://api.github.com/repos/systemd/systemd/deployments","created_at":"2015-03-25T15:27:27Z","updated_at":"2016-12-15T08:23:13Z","pushed_at":"2016-12-15T22:11:11Z","git_url":"git://github.com/systemd/systemd.git","ssh_url":"git@github.com:systemd/systemd.git","clone_url":"https://github.com/systemd/systemd.git","svn_url":"https://github.com/systemd/systemd","homepage":"http://www.freedesktop.org/wiki/Software/systemd/","size":64919,"stargazers_count":1518,"watchers_count":1518,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":646,"mirror_url":null,"open_issues_count":520,"forks":646,"open_issues":520,"watchers":1518,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/systemd/systemd/pulls/4893"},"html":{"href":"https://github.com/systemd/systemd/pull/4893"},"issue":{"href":"https://api.github.com/repos/systemd/systemd/issues/4893"},"comments":{"href":"https://api.github.com/repos/systemd/systemd/issues/4893/comments"},"review_comments":{"href":"https://api.github.com/repos/systemd/systemd/pulls/4893/comments"},"review_comment":{"href":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/systemd/systemd/pulls/4893/commits"},"statuses":{"href":"https://api.github.com/repos/systemd/systemd/statuses/0cb200b9f78b66617b509f01419742c92520d9e6"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"poettering","id":2130732,"avatar_url":"https://avatars.githubusercontent.com/u/2130732?v=3","gravatar_id":"","url":"https://api.github.com/users/poettering","html_url":"https://github.com/poettering","followers_url":"https://api.github.com/users/poettering/followers","following_url":"https://api.github.com/users/poettering/following{/other_user}","gists_url":"https://api.github.com/users/poettering/gists{/gist_id}","starred_url":"https://api.github.com/users/poettering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poettering/subscriptions","organizations_url":"https://api.github.com/users/poettering/orgs","repos_url":"https://api.github.com/users/poettering/repos","events_url":"https://api.github.com/users/poettering/events{/privacy}","received_events_url":"https://api.github.com/users/poettering/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":7,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"poettering"}}