{"action":"created","comment":{"url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/pulls/comments/92583992","pull_request_review_id":13101485,"id":92583992,"diff_hunk":"@@ -40,7 +59,7 @@\n \n   private static final JsonArray EMPTY = new JsonArray(Collections.unmodifiableList(new ArrayList<>()));\n \n-  private static final Pattern DATETIME = Pattern.compile(\"^\\\\d{4}-(?:0[0-9]|1[0-2])-[0-9]{2}T\\\\d{2}:\\\\d{2}:\\\\d{2}(\\\\.\\\\d{3})?Z$\");","path":"src/main/java/io/vertx/ext/jdbc/impl/actions/JDBCStatementHelper.java","position":37,"original_position":37,"commit_id":"1d4d0b742866ed5aa10300b13ce2879ed3c1fbd5","original_commit_id":"10bef803882f1e86ca1c2ba8916e14fbddb23e4a","user":{"login":"pmlopes","id":849467,"avatar_url":"https://avatars.githubusercontent.com/u/849467?v=3","gravatar_id":"","url":"https://api.github.com/users/pmlopes","html_url":"https://github.com/pmlopes","followers_url":"https://api.github.com/users/pmlopes/followers","following_url":"https://api.github.com/users/pmlopes/following{/other_user}","gists_url":"https://api.github.com/users/pmlopes/gists{/gist_id}","starred_url":"https://api.github.com/users/pmlopes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmlopes/subscriptions","organizations_url":"https://api.github.com/users/pmlopes/orgs","repos_url":"https://api.github.com/users/pmlopes/repos","events_url":"https://api.github.com/users/pmlopes/events{/privacy}","received_events_url":"https://api.github.com/users/pmlopes/received_events","type":"User","site_admin":false},"body":"The reason for this is that most JS engines date resolution is based on a 64bit int since the epoch so when encoding to json the nanos will be lost. ","created_at":"2016-12-15T10:40:17Z","updated_at":"2016-12-15T10:40:17Z","html_url":"https://github.com/vert-x3/vertx-jdbc-client/pull/83#discussion_r92583992","pull_request_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/pulls/83","_links":{"self":{"href":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/pulls/comments/92583992"},"html":{"href":"https://github.com/vert-x3/vertx-jdbc-client/pull/83#discussion_r92583992"},"pull_request":{"href":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/pulls/83"}}},"pull_request":{"url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/pulls/83","id":98121442,"html_url":"https://github.com/vert-x3/vertx-jdbc-client/pull/83","diff_url":"https://github.com/vert-x3/vertx-jdbc-client/pull/83.diff","patch_url":"https://github.com/vert-x3/vertx-jdbc-client/pull/83.patch","issue_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/issues/83","number":83,"state":"open","locked":false,"title":"Fixes Instant/Timestamp conversion","user":{"login":"tsegismont","id":1500598,"avatar_url":"https://avatars.githubusercontent.com/u/1500598?v=3","gravatar_id":"","url":"https://api.github.com/users/tsegismont","html_url":"https://github.com/tsegismont","followers_url":"https://api.github.com/users/tsegismont/followers","following_url":"https://api.github.com/users/tsegismont/following{/other_user}","gists_url":"https://api.github.com/users/tsegismont/gists{/gist_id}","starred_url":"https://api.github.com/users/tsegismont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsegismont/subscriptions","organizations_url":"https://api.github.com/users/tsegismont/orgs","repos_url":"https://api.github.com/users/tsegismont/repos","events_url":"https://api.github.com/users/tsegismont/events{/privacy}","received_events_url":"https://api.github.com/users/tsegismont/received_events","type":"User","site_admin":false},"body":"An Instant may carry submillisecond data. So when it is added to Json, this information is reflected in the String conversion.\nBut the current regular expression in JDBCStatementHelper only allows for milliseconds precision.\nConsequently, the value is not even identified as a timestamp, but as a String.\n\nIn addition to that, the current from/to SQL conversion methods simply erase submillisecond data, even though it's supported in the java.sql.Timestamp format.\n\nSQLConvertTest has been updated with more test cases. Also it's been fixed because if something wasn't properly detected, it was simply returned as String and of course was equal to the original.","created_at":"2016-12-15T10:16:25Z","updated_at":"2016-12-15T10:40:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f1b03107e56aae82e4a3af2ae22b3e3dc683569","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/pulls/83/commits","review_comments_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/pulls/83/comments","review_comment_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/issues/83/comments","statuses_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/statuses/1d4d0b742866ed5aa10300b13ce2879ed3c1fbd5","head":{"label":"tsegismont:temporal-conversion-fixes","ref":"temporal-conversion-fixes","sha":"1d4d0b742866ed5aa10300b13ce2879ed3c1fbd5","user":{"login":"tsegismont","id":1500598,"avatar_url":"https://avatars.githubusercontent.com/u/1500598?v=3","gravatar_id":"","url":"https://api.github.com/users/tsegismont","html_url":"https://github.com/tsegismont","followers_url":"https://api.github.com/users/tsegismont/followers","following_url":"https://api.github.com/users/tsegismont/following{/other_user}","gists_url":"https://api.github.com/users/tsegismont/gists{/gist_id}","starred_url":"https://api.github.com/users/tsegismont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsegismont/subscriptions","organizations_url":"https://api.github.com/users/tsegismont/orgs","repos_url":"https://api.github.com/users/tsegismont/repos","events_url":"https://api.github.com/users/tsegismont/events{/privacy}","received_events_url":"https://api.github.com/users/tsegismont/received_events","type":"User","site_admin":false},"repo":{"id":52348997,"name":"vertx-jdbc-client","full_name":"tsegismont/vertx-jdbc-client","owner":{"login":"tsegismont","id":1500598,"avatar_url":"https://avatars.githubusercontent.com/u/1500598?v=3","gravatar_id":"","url":"https://api.github.com/users/tsegismont","html_url":"https://github.com/tsegismont","followers_url":"https://api.github.com/users/tsegismont/followers","following_url":"https://api.github.com/users/tsegismont/following{/other_user}","gists_url":"https://api.github.com/users/tsegismont/gists{/gist_id}","starred_url":"https://api.github.com/users/tsegismont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsegismont/subscriptions","organizations_url":"https://api.github.com/users/tsegismont/orgs","repos_url":"https://api.github.com/users/tsegismont/repos","events_url":"https://api.github.com/users/tsegismont/events{/privacy}","received_events_url":"https://api.github.com/users/tsegismont/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tsegismont/vertx-jdbc-client","description":"JDBC support for Vert.x","fork":true,"url":"https://api.github.com/repos/tsegismont/vertx-jdbc-client","forks_url":"https://api.github.com/repos/tsegismont/vertx-jdbc-client/forks","keys_url":"https://api.github.com/repos/tsegismont/vertx-jdbc-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tsegismont/vertx-jdbc-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tsegismont/vertx-jdbc-client/teams","hooks_url":"https://api.github.com/repos/tsegismont/vertx-jdbc-client/hooks","issue_events_url":"https://api.github.com/repos/tsegismont/vertx-jdbc-client/issues/events{/number}","events_url":"https://api.github.com/repos/tsegismont/vertx-jdbc-client/events","assignees_url":"https://api.github.com/repos/tsegismont/vertx-jdbc-client/assignees{/user}","branches_url":"https://api.github.com/repos/tsegismont/vertx-jdbc-client/branches{/branch}","tags_url":"https://api.github.com/repos/tsegismont/vertx-jdbc-client/tags","blobs_url":"https://api.github.com/repos/tsegismont/vertx-jdbc-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tsegismont/vertx-jdbc-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tsegismont/vertx-jdbc-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/tsegismont/vertx-jdbc-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tsegismont/vertx-jdbc-client/statuses/{sha}","languages_url":"https://api.github.com/repos/tsegismont/vertx-jdbc-client/languages","stargazers_url":"https://api.github.com/repos/tsegismont/vertx-jdbc-client/stargazers","contributors_url":"https://api.github.com/repos/tsegismont/vertx-jdbc-client/contributors","subscribers_url":"https://api.github.com/repos/tsegismont/vertx-jdbc-client/subscribers","subscription_url":"https://api.github.com/repos/tsegismont/vertx-jdbc-client/subscription","commits_url":"https://api.github.com/repos/tsegismont/vertx-jdbc-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/tsegismont/vertx-jdbc-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/tsegismont/vertx-jdbc-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/tsegismont/vertx-jdbc-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/tsegismont/vertx-jdbc-client/contents/{+path}","compare_url":"https://api.github.com/repos/tsegismont/vertx-jdbc-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tsegismont/vertx-jdbc-client/merges","archive_url":"https://api.github.com/repos/tsegismont/vertx-jdbc-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tsegismont/vertx-jdbc-client/downloads","issues_url":"https://api.github.com/repos/tsegismont/vertx-jdbc-client/issues{/number}","pulls_url":"https://api.github.com/repos/tsegismont/vertx-jdbc-client/pulls{/number}","milestones_url":"https://api.github.com/repos/tsegismont/vertx-jdbc-client/milestones{/number}","notifications_url":"https://api.github.com/repos/tsegismont/vertx-jdbc-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tsegismont/vertx-jdbc-client/labels{/name}","releases_url":"https://api.github.com/repos/tsegismont/vertx-jdbc-client/releases{/id}","deployments_url":"https://api.github.com/repos/tsegismont/vertx-jdbc-client/deployments","created_at":"2016-02-23T09:57:12Z","updated_at":"2016-02-23T09:57:13Z","pushed_at":"2016-12-15T10:24:45Z","git_url":"git://github.com/tsegismont/vertx-jdbc-client.git","ssh_url":"git@github.com:tsegismont/vertx-jdbc-client.git","clone_url":"https://github.com/tsegismont/vertx-jdbc-client.git","svn_url":"https://github.com/tsegismont/vertx-jdbc-client","homepage":null,"size":475,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vert-x3:master","ref":"master","sha":"cfd34a30a849c65ae33336b0afba50625d540ebd","user":{"login":"vert-x3","id":8124623,"avatar_url":"https://avatars.githubusercontent.com/u/8124623?v=3","gravatar_id":"","url":"https://api.github.com/users/vert-x3","html_url":"https://github.com/vert-x3","followers_url":"https://api.github.com/users/vert-x3/followers","following_url":"https://api.github.com/users/vert-x3/following{/other_user}","gists_url":"https://api.github.com/users/vert-x3/gists{/gist_id}","starred_url":"https://api.github.com/users/vert-x3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vert-x3/subscriptions","organizations_url":"https://api.github.com/users/vert-x3/orgs","repos_url":"https://api.github.com/users/vert-x3/repos","events_url":"https://api.github.com/users/vert-x3/events{/privacy}","received_events_url":"https://api.github.com/users/vert-x3/received_events","type":"Organization","site_admin":false},"repo":{"id":26814908,"name":"vertx-jdbc-client","full_name":"vert-x3/vertx-jdbc-client","owner":{"login":"vert-x3","id":8124623,"avatar_url":"https://avatars.githubusercontent.com/u/8124623?v=3","gravatar_id":"","url":"https://api.github.com/users/vert-x3","html_url":"https://github.com/vert-x3","followers_url":"https://api.github.com/users/vert-x3/followers","following_url":"https://api.github.com/users/vert-x3/following{/other_user}","gists_url":"https://api.github.com/users/vert-x3/gists{/gist_id}","starred_url":"https://api.github.com/users/vert-x3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vert-x3/subscriptions","organizations_url":"https://api.github.com/users/vert-x3/orgs","repos_url":"https://api.github.com/users/vert-x3/repos","events_url":"https://api.github.com/users/vert-x3/events{/privacy}","received_events_url":"https://api.github.com/users/vert-x3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vert-x3/vertx-jdbc-client","description":"JDBC support for Vert.x","fork":false,"url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client","forks_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/forks","keys_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/teams","hooks_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/hooks","issue_events_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/issues/events{/number}","events_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/events","assignees_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/assignees{/user}","branches_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/branches{/branch}","tags_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/tags","blobs_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/statuses/{sha}","languages_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/languages","stargazers_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/stargazers","contributors_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/contributors","subscribers_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/subscribers","subscription_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/subscription","commits_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/contents/{+path}","compare_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/merges","archive_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/downloads","issues_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/issues{/number}","pulls_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/pulls{/number}","milestones_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/milestones{/number}","notifications_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/labels{/name}","releases_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/releases{/id}","deployments_url":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/deployments","created_at":"2014-11-18T15:14:46Z","updated_at":"2016-11-27T19:54:20Z","pushed_at":"2016-12-15T10:24:45Z","git_url":"git://github.com/vert-x3/vertx-jdbc-client.git","ssh_url":"git@github.com:vert-x3/vertx-jdbc-client.git","clone_url":"https://github.com/vert-x3/vertx-jdbc-client.git","svn_url":"https://github.com/vert-x3/vertx-jdbc-client","homepage":null,"size":534,"stargazers_count":22,"watchers_count":22,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":6,"forks":34,"open_issues":6,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/pulls/83"},"html":{"href":"https://github.com/vert-x3/vertx-jdbc-client/pull/83"},"issue":{"href":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/issues/83"},"comments":{"href":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/vert-x3/vertx-jdbc-client/statuses/1d4d0b742866ed5aa10300b13ce2879ed3c1fbd5"}}}}
{"actor":{"display_login":"pmlopes"}}