{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/69994740","id":69994740,"diff_hunk":"@@ -671,6 +671,9 @@ Microsoft.CodeAnalysis.Semantics.UnaryOperationKind.UnsignedPostfixDecrement = 7\n Microsoft.CodeAnalysis.Semantics.UnaryOperationKind.UnsignedPostfixIncrement = 771 -> Microsoft.CodeAnalysis.Semantics.UnaryOperationKind\n Microsoft.CodeAnalysis.Semantics.UnaryOperationKind.UnsignedPrefixDecrement = 774 -> Microsoft.CodeAnalysis.Semantics.UnaryOperationKind\n Microsoft.CodeAnalysis.Semantics.UnaryOperationKind.UnsignedPrefixIncrement = 773 -> Microsoft.CodeAnalysis.Semantics.UnaryOperationKind\n+Microsoft.CodeAnalysis.SymbolDisplayFormat.RemoveGenericsOptions(Microsoft.CodeAnalysis.SymbolDisplayGenericsOptions options) -> Microsoft.CodeAnalysis.SymbolDisplayFormat\n+Microsoft.CodeAnalysis.SymbolDisplayFormat.RemoveLocalOptions(Microsoft.CodeAnalysis.SymbolDisplayLocalOptions options) -> Microsoft.CodeAnalysis.SymbolDisplayFormat\n+Microsoft.CodeAnalysis.SymbolDisplayFormat.RemoveMiscellaneousOptions(Microsoft.CodeAnalysis.SymbolDisplayMiscellaneousOptions options) -> Microsoft.CodeAnalysis.SymbolDisplayFormat","path":"src/Compilers/Core/Portable/PublicAPI.Unshipped.txt","position":6,"original_position":6,"commit_id":"498827ab796b0852030d09255f8f6208b9aece48","original_commit_id":"498827ab796b0852030d09255f8f6208b9aece48","user":{"login":"jcouv","id":12466233,"avatar_url":"https://avatars.githubusercontent.com/u/12466233?v=3","gravatar_id":"","url":"https://api.github.com/users/jcouv","html_url":"https://github.com/jcouv","followers_url":"https://api.github.com/users/jcouv/followers","following_url":"https://api.github.com/users/jcouv/following{/other_user}","gists_url":"https://api.github.com/users/jcouv/gists{/gist_id}","starred_url":"https://api.github.com/users/jcouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcouv/subscriptions","organizations_url":"https://api.github.com/users/jcouv/orgs","repos_url":"https://api.github.com/users/jcouv/repos","events_url":"https://api.github.com/users/jcouv/events{/privacy}","received_events_url":"https://api.github.com/users/jcouv/received_events","type":"User","site_admin":false},"body":"It seems that, out of the three new public methods, only `RemoveMiscellaneousOptions` is used in the code, the other two new APIs are un-used at this point. Are there here just for consistency?\r\n\r\nAlso, all three Remove APIs are just `AddSomeOption(~option)`. If we're going to be consistent, are we going to have Remove APIs whenever we have Add APIs?\r\n\r\nWas there a discussion on whether we need those new public APIs?","created_at":"2016-07-07T21:54:05Z","updated_at":"2016-07-07T21:54:05Z","html_url":"https://github.com/dotnet/roslyn/pull/12092#discussion_r69994740","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/12092","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/69994740"},"html":{"href":"https://github.com/dotnet/roslyn/pull/12092#discussion_r69994740"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/12092"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/12092","id":74339133,"html_url":"https://github.com/dotnet/roslyn/pull/12092","diff_url":"https://github.com/dotnet/roslyn/pull/12092.diff","patch_url":"https://github.com/dotnet/roslyn/pull/12092.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/12092","number":12092,"state":"open","locked":false,"title":"Add partial-type-name suggestions to C# and some fixes for VB","user":{"login":"lorcanmooney","id":13181165,"avatar_url":"https://avatars.githubusercontent.com/u/13181165?v=3","gravatar_id":"","url":"https://api.github.com/users/lorcanmooney","html_url":"https://github.com/lorcanmooney","followers_url":"https://api.github.com/users/lorcanmooney/followers","following_url":"https://api.github.com/users/lorcanmooney/following{/other_user}","gists_url":"https://api.github.com/users/lorcanmooney/gists{/gist_id}","starred_url":"https://api.github.com/users/lorcanmooney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorcanmooney/subscriptions","organizations_url":"https://api.github.com/users/lorcanmooney/orgs","repos_url":"https://api.github.com/users/lorcanmooney/repos","events_url":"https://api.github.com/users/lorcanmooney/events{/privacy}","received_events_url":"https://api.github.com/users/lorcanmooney/received_events","type":"User","site_admin":false},"body":"- Closes #7213. Refactors the VB provider, creating a base class and a C# implementation.\r\n- Fixes #4137. In VB, when a user commits a generic type using `(` only the type name will be inserted.\r\n- Fixes an issue in the VB provider where suggestions we pulled from all ancestor types and namespaces, instead of just the directly enclosing container.\r\n- Fixes an issue in the VB provider where types wouldn't be suggested because their spans overlapped, despite being in different documents.","created_at":"2016-06-18T14:58:38Z","updated_at":"2016-07-07T21:54:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8f4760ded1a1e9c652bce081d5aaf20cd4057891","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/12092/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/12092/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/12092/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/498827ab796b0852030d09255f8f6208b9aece48","head":{"label":"lorcanmooney:issue7213-partials","ref":"issue7213-partials","sha":"498827ab796b0852030d09255f8f6208b9aece48","user":{"login":"lorcanmooney","id":13181165,"avatar_url":"https://avatars.githubusercontent.com/u/13181165?v=3","gravatar_id":"","url":"https://api.github.com/users/lorcanmooney","html_url":"https://github.com/lorcanmooney","followers_url":"https://api.github.com/users/lorcanmooney/followers","following_url":"https://api.github.com/users/lorcanmooney/following{/other_user}","gists_url":"https://api.github.com/users/lorcanmooney/gists{/gist_id}","starred_url":"https://api.github.com/users/lorcanmooney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorcanmooney/subscriptions","organizations_url":"https://api.github.com/users/lorcanmooney/orgs","repos_url":"https://api.github.com/users/lorcanmooney/repos","events_url":"https://api.github.com/users/lorcanmooney/events{/privacy}","received_events_url":"https://api.github.com/users/lorcanmooney/received_events","type":"User","site_admin":false},"repo":{"id":48291854,"name":"roslyn","full_name":"lorcanmooney/roslyn","owner":{"login":"lorcanmooney","id":13181165,"avatar_url":"https://avatars.githubusercontent.com/u/13181165?v=3","gravatar_id":"","url":"https://api.github.com/users/lorcanmooney","html_url":"https://github.com/lorcanmooney","followers_url":"https://api.github.com/users/lorcanmooney/followers","following_url":"https://api.github.com/users/lorcanmooney/following{/other_user}","gists_url":"https://api.github.com/users/lorcanmooney/gists{/gist_id}","starred_url":"https://api.github.com/users/lorcanmooney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorcanmooney/subscriptions","organizations_url":"https://api.github.com/users/lorcanmooney/orgs","repos_url":"https://api.github.com/users/lorcanmooney/repos","events_url":"https://api.github.com/users/lorcanmooney/events{/privacy}","received_events_url":"https://api.github.com/users/lorcanmooney/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lorcanmooney/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/lorcanmooney/roslyn","forks_url":"https://api.github.com/repos/lorcanmooney/roslyn/forks","keys_url":"https://api.github.com/repos/lorcanmooney/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lorcanmooney/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lorcanmooney/roslyn/teams","hooks_url":"https://api.github.com/repos/lorcanmooney/roslyn/hooks","issue_events_url":"https://api.github.com/repos/lorcanmooney/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/lorcanmooney/roslyn/events","assignees_url":"https://api.github.com/repos/lorcanmooney/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/lorcanmooney/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/lorcanmooney/roslyn/tags","blobs_url":"https://api.github.com/repos/lorcanmooney/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lorcanmooney/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lorcanmooney/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/lorcanmooney/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lorcanmooney/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/lorcanmooney/roslyn/languages","stargazers_url":"https://api.github.com/repos/lorcanmooney/roslyn/stargazers","contributors_url":"https://api.github.com/repos/lorcanmooney/roslyn/contributors","subscribers_url":"https://api.github.com/repos/lorcanmooney/roslyn/subscribers","subscription_url":"https://api.github.com/repos/lorcanmooney/roslyn/subscription","commits_url":"https://api.github.com/repos/lorcanmooney/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/lorcanmooney/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/lorcanmooney/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/lorcanmooney/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/lorcanmooney/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/lorcanmooney/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lorcanmooney/roslyn/merges","archive_url":"https://api.github.com/repos/lorcanmooney/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lorcanmooney/roslyn/downloads","issues_url":"https://api.github.com/repos/lorcanmooney/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/lorcanmooney/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/lorcanmooney/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/lorcanmooney/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lorcanmooney/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/lorcanmooney/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/lorcanmooney/roslyn/deployments","created_at":"2015-12-19T17:57:32Z","updated_at":"2016-02-11T23:12:02Z","pushed_at":"2016-07-07T21:03:19Z","git_url":"git://github.com/lorcanmooney/roslyn.git","ssh_url":"git@github.com:lorcanmooney/roslyn.git","clone_url":"https://github.com/lorcanmooney/roslyn.git","svn_url":"https://github.com/lorcanmooney/roslyn","homepage":"","size":169279,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"8ef0f0b1fa769858a4f105335a5c5624447253ab","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2016-07-07T20:13:37Z","pushed_at":"2016-07-07T21:48:39Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":312784,"stargazers_count":5763,"watchers_count":5763,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1380,"mirror_url":null,"open_issues_count":3001,"forks":1380,"open_issues":3001,"watchers":5763,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/12092"},"html":{"href":"https://github.com/dotnet/roslyn/pull/12092"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/12092"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/12092/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/12092/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/12092/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/498827ab796b0852030d09255f8f6208b9aece48"}}}}
{"actor":{"display_login":"jcouv"}}