{"action":"created","comment":{"url":"https://api.github.com/repos/aurelia/dialog/pulls/comments/93169224","pull_request_review_id":13689851,"id":93169224,"diff_hunk":"@@ -16,32 +14,38 @@ describe('the Dialog Controller', function () {\n     });\n   }\n \n-  beforeEach(function () {\n-    new Container().makeGlobal();\n-    settings = { name: 'Test' };\n-    dialogController = new DialogController(renderer, settings, Function.prototype, Function.prototype);\n+  function createDialogController(settings = {}) {\n+    const dialogController = new DialogController(renderer, settings, Function.prototype, Function.prototype);\n     dialogController.viewModel = {};\n     dialogController.controller = {\n       unbind() { }\n     };\n     dialogController.renderer.hideDialog = Function.prototype;\n+    return dialogController;\n+  }\n+\n+  beforeEach(function () {\n+    this.dialogController = createDialogController();","path":"test/unit/dialog-controller.spec.js","position":32,"original_position":32,"commit_id":"22022bd8d25ae488d45566f509378a8813aeef7a","original_commit_id":"22022bd8d25ae488d45566f509378a8813aeef7a","user":{"login":"PWKad","id":4238393,"avatar_url":"https://avatars.githubusercontent.com/u/4238393?v=3","gravatar_id":"","url":"https://api.github.com/users/PWKad","html_url":"https://github.com/PWKad","followers_url":"https://api.github.com/users/PWKad/followers","following_url":"https://api.github.com/users/PWKad/following{/other_user}","gists_url":"https://api.github.com/users/PWKad/gists{/gist_id}","starred_url":"https://api.github.com/users/PWKad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PWKad/subscriptions","organizations_url":"https://api.github.com/users/PWKad/orgs","repos_url":"https://api.github.com/users/PWKad/repos","events_url":"https://api.github.com/users/PWKad/events{/privacy}","received_events_url":"https://api.github.com/users/PWKad/received_events","type":"User","site_admin":false},"body":"Looks like this may be a way to get around defining the same variable twice, but naming should take care of this.","created_at":"2016-12-20T04:14:27Z","updated_at":"2016-12-20T04:15:37Z","html_url":"https://github.com/aurelia/dialog/pull/218#discussion_r93169224","pull_request_url":"https://api.github.com/repos/aurelia/dialog/pulls/218","_links":{"self":{"href":"https://api.github.com/repos/aurelia/dialog/pulls/comments/93169224"},"html":{"href":"https://github.com/aurelia/dialog/pull/218#discussion_r93169224"},"pull_request":{"href":"https://api.github.com/repos/aurelia/dialog/pulls/218"}}},"pull_request":{"url":"https://api.github.com/repos/aurelia/dialog/pulls/218","id":88559854,"html_url":"https://github.com/aurelia/dialog/pull/218","diff_url":"https://github.com/aurelia/dialog/pull/218.diff","patch_url":"https://github.com/aurelia/dialog/pull/218.patch","issue_url":"https://api.github.com/repos/aurelia/dialog/issues/218","number":218,"state":"open","locked":false,"title":"feat(dialog-service): add .closeAll()","user":{"login":"StrahilKazlachev","id":5302492,"avatar_url":"https://avatars.githubusercontent.com/u/5302492?v=3","gravatar_id":"","url":"https://api.github.com/users/StrahilKazlachev","html_url":"https://github.com/StrahilKazlachev","followers_url":"https://api.github.com/users/StrahilKazlachev/followers","following_url":"https://api.github.com/users/StrahilKazlachev/following{/other_user}","gists_url":"https://api.github.com/users/StrahilKazlachev/gists{/gist_id}","starred_url":"https://api.github.com/users/StrahilKazlachev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrahilKazlachev/subscriptions","organizations_url":"https://api.github.com/users/StrahilKazlachev/orgs","repos_url":"https://api.github.com/users/StrahilKazlachev/repos","events_url":"https://api.github.com/users/StrahilKazlachev/events{/privacy}","received_events_url":"https://api.github.com/users/StrahilKazlachev/received_events","type":"User","site_admin":false},"body":"Add a convenience method to close all open dialogs, see #214.\n","created_at":"2016-10-08T21:35:35Z","updated_at":"2016-12-20T04:15:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b3fbc57ee77d745e87f79fd0e0c334a7c6fb514c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/aurelia/dialog/pulls/218/commits","review_comments_url":"https://api.github.com/repos/aurelia/dialog/pulls/218/comments","review_comment_url":"https://api.github.com/repos/aurelia/dialog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aurelia/dialog/issues/218/comments","statuses_url":"https://api.github.com/repos/aurelia/dialog/statuses/22022bd8d25ae488d45566f509378a8813aeef7a","head":{"label":"StrahilKazlachev:feature/dialog-service/close-all","ref":"feature/dialog-service/close-all","sha":"22022bd8d25ae488d45566f509378a8813aeef7a","user":{"login":"StrahilKazlachev","id":5302492,"avatar_url":"https://avatars.githubusercontent.com/u/5302492?v=3","gravatar_id":"","url":"https://api.github.com/users/StrahilKazlachev","html_url":"https://github.com/StrahilKazlachev","followers_url":"https://api.github.com/users/StrahilKazlachev/followers","following_url":"https://api.github.com/users/StrahilKazlachev/following{/other_user}","gists_url":"https://api.github.com/users/StrahilKazlachev/gists{/gist_id}","starred_url":"https://api.github.com/users/StrahilKazlachev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrahilKazlachev/subscriptions","organizations_url":"https://api.github.com/users/StrahilKazlachev/orgs","repos_url":"https://api.github.com/users/StrahilKazlachev/repos","events_url":"https://api.github.com/users/StrahilKazlachev/events{/privacy}","received_events_url":"https://api.github.com/users/StrahilKazlachev/received_events","type":"User","site_admin":false},"repo":{"id":66665521,"name":"dialog","full_name":"StrahilKazlachev/dialog","owner":{"login":"StrahilKazlachev","id":5302492,"avatar_url":"https://avatars.githubusercontent.com/u/5302492?v=3","gravatar_id":"","url":"https://api.github.com/users/StrahilKazlachev","html_url":"https://github.com/StrahilKazlachev","followers_url":"https://api.github.com/users/StrahilKazlachev/followers","following_url":"https://api.github.com/users/StrahilKazlachev/following{/other_user}","gists_url":"https://api.github.com/users/StrahilKazlachev/gists{/gist_id}","starred_url":"https://api.github.com/users/StrahilKazlachev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrahilKazlachev/subscriptions","organizations_url":"https://api.github.com/users/StrahilKazlachev/orgs","repos_url":"https://api.github.com/users/StrahilKazlachev/repos","events_url":"https://api.github.com/users/StrahilKazlachev/events{/privacy}","received_events_url":"https://api.github.com/users/StrahilKazlachev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/StrahilKazlachev/dialog","description":"A dialog plugin for Aurelia.","fork":true,"url":"https://api.github.com/repos/StrahilKazlachev/dialog","forks_url":"https://api.github.com/repos/StrahilKazlachev/dialog/forks","keys_url":"https://api.github.com/repos/StrahilKazlachev/dialog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StrahilKazlachev/dialog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StrahilKazlachev/dialog/teams","hooks_url":"https://api.github.com/repos/StrahilKazlachev/dialog/hooks","issue_events_url":"https://api.github.com/repos/StrahilKazlachev/dialog/issues/events{/number}","events_url":"https://api.github.com/repos/StrahilKazlachev/dialog/events","assignees_url":"https://api.github.com/repos/StrahilKazlachev/dialog/assignees{/user}","branches_url":"https://api.github.com/repos/StrahilKazlachev/dialog/branches{/branch}","tags_url":"https://api.github.com/repos/StrahilKazlachev/dialog/tags","blobs_url":"https://api.github.com/repos/StrahilKazlachev/dialog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StrahilKazlachev/dialog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StrahilKazlachev/dialog/git/refs{/sha}","trees_url":"https://api.github.com/repos/StrahilKazlachev/dialog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StrahilKazlachev/dialog/statuses/{sha}","languages_url":"https://api.github.com/repos/StrahilKazlachev/dialog/languages","stargazers_url":"https://api.github.com/repos/StrahilKazlachev/dialog/stargazers","contributors_url":"https://api.github.com/repos/StrahilKazlachev/dialog/contributors","subscribers_url":"https://api.github.com/repos/StrahilKazlachev/dialog/subscribers","subscription_url":"https://api.github.com/repos/StrahilKazlachev/dialog/subscription","commits_url":"https://api.github.com/repos/StrahilKazlachev/dialog/commits{/sha}","git_commits_url":"https://api.github.com/repos/StrahilKazlachev/dialog/git/commits{/sha}","comments_url":"https://api.github.com/repos/StrahilKazlachev/dialog/comments{/number}","issue_comment_url":"https://api.github.com/repos/StrahilKazlachev/dialog/issues/comments{/number}","contents_url":"https://api.github.com/repos/StrahilKazlachev/dialog/contents/{+path}","compare_url":"https://api.github.com/repos/StrahilKazlachev/dialog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StrahilKazlachev/dialog/merges","archive_url":"https://api.github.com/repos/StrahilKazlachev/dialog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StrahilKazlachev/dialog/downloads","issues_url":"https://api.github.com/repos/StrahilKazlachev/dialog/issues{/number}","pulls_url":"https://api.github.com/repos/StrahilKazlachev/dialog/pulls{/number}","milestones_url":"https://api.github.com/repos/StrahilKazlachev/dialog/milestones{/number}","notifications_url":"https://api.github.com/repos/StrahilKazlachev/dialog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StrahilKazlachev/dialog/labels{/name}","releases_url":"https://api.github.com/repos/StrahilKazlachev/dialog/releases{/id}","deployments_url":"https://api.github.com/repos/StrahilKazlachev/dialog/deployments","created_at":"2016-08-26T17:11:16Z","updated_at":"2016-08-26T17:11:17Z","pushed_at":"2016-12-18T08:08:45Z","git_url":"git://github.com/StrahilKazlachev/dialog.git","ssh_url":"git@github.com:StrahilKazlachev/dialog.git","clone_url":"https://github.com/StrahilKazlachev/dialog.git","svn_url":"https://github.com/StrahilKazlachev/dialog","homepage":"","size":539,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aurelia:master","ref":"master","sha":"50de877904a7732f5a8a0a1112d45a2d658a228c","user":{"login":"aurelia","id":9808864,"avatar_url":"https://avatars.githubusercontent.com/u/9808864?v=3","gravatar_id":"","url":"https://api.github.com/users/aurelia","html_url":"https://github.com/aurelia","followers_url":"https://api.github.com/users/aurelia/followers","following_url":"https://api.github.com/users/aurelia/following{/other_user}","gists_url":"https://api.github.com/users/aurelia/gists{/gist_id}","starred_url":"https://api.github.com/users/aurelia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aurelia/subscriptions","organizations_url":"https://api.github.com/users/aurelia/orgs","repos_url":"https://api.github.com/users/aurelia/repos","events_url":"https://api.github.com/users/aurelia/events{/privacy}","received_events_url":"https://api.github.com/users/aurelia/received_events","type":"Organization","site_admin":false},"repo":{"id":38711355,"name":"dialog","full_name":"aurelia/dialog","owner":{"login":"aurelia","id":9808864,"avatar_url":"https://avatars.githubusercontent.com/u/9808864?v=3","gravatar_id":"","url":"https://api.github.com/users/aurelia","html_url":"https://github.com/aurelia","followers_url":"https://api.github.com/users/aurelia/followers","following_url":"https://api.github.com/users/aurelia/following{/other_user}","gists_url":"https://api.github.com/users/aurelia/gists{/gist_id}","starred_url":"https://api.github.com/users/aurelia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aurelia/subscriptions","organizations_url":"https://api.github.com/users/aurelia/orgs","repos_url":"https://api.github.com/users/aurelia/repos","events_url":"https://api.github.com/users/aurelia/events{/privacy}","received_events_url":"https://api.github.com/users/aurelia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aurelia/dialog","description":"A dialog plugin for Aurelia.","fork":false,"url":"https://api.github.com/repos/aurelia/dialog","forks_url":"https://api.github.com/repos/aurelia/dialog/forks","keys_url":"https://api.github.com/repos/aurelia/dialog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aurelia/dialog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aurelia/dialog/teams","hooks_url":"https://api.github.com/repos/aurelia/dialog/hooks","issue_events_url":"https://api.github.com/repos/aurelia/dialog/issues/events{/number}","events_url":"https://api.github.com/repos/aurelia/dialog/events","assignees_url":"https://api.github.com/repos/aurelia/dialog/assignees{/user}","branches_url":"https://api.github.com/repos/aurelia/dialog/branches{/branch}","tags_url":"https://api.github.com/repos/aurelia/dialog/tags","blobs_url":"https://api.github.com/repos/aurelia/dialog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aurelia/dialog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aurelia/dialog/git/refs{/sha}","trees_url":"https://api.github.com/repos/aurelia/dialog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aurelia/dialog/statuses/{sha}","languages_url":"https://api.github.com/repos/aurelia/dialog/languages","stargazers_url":"https://api.github.com/repos/aurelia/dialog/stargazers","contributors_url":"https://api.github.com/repos/aurelia/dialog/contributors","subscribers_url":"https://api.github.com/repos/aurelia/dialog/subscribers","subscription_url":"https://api.github.com/repos/aurelia/dialog/subscription","commits_url":"https://api.github.com/repos/aurelia/dialog/commits{/sha}","git_commits_url":"https://api.github.com/repos/aurelia/dialog/git/commits{/sha}","comments_url":"https://api.github.com/repos/aurelia/dialog/comments{/number}","issue_comment_url":"https://api.github.com/repos/aurelia/dialog/issues/comments{/number}","contents_url":"https://api.github.com/repos/aurelia/dialog/contents/{+path}","compare_url":"https://api.github.com/repos/aurelia/dialog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aurelia/dialog/merges","archive_url":"https://api.github.com/repos/aurelia/dialog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aurelia/dialog/downloads","issues_url":"https://api.github.com/repos/aurelia/dialog/issues{/number}","pulls_url":"https://api.github.com/repos/aurelia/dialog/pulls{/number}","milestones_url":"https://api.github.com/repos/aurelia/dialog/milestones{/number}","notifications_url":"https://api.github.com/repos/aurelia/dialog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aurelia/dialog/labels{/name}","releases_url":"https://api.github.com/repos/aurelia/dialog/releases{/id}","deployments_url":"https://api.github.com/repos/aurelia/dialog/deployments","created_at":"2015-07-07T19:56:03Z","updated_at":"2016-12-15T08:17:39Z","pushed_at":"2016-12-18T08:08:46Z","git_url":"git://github.com/aurelia/dialog.git","ssh_url":"git@github.com:aurelia/dialog.git","clone_url":"https://github.com/aurelia/dialog.git","svn_url":"https://github.com/aurelia/dialog","homepage":"","size":567,"stargazers_count":65,"watchers_count":65,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":73,"mirror_url":null,"open_issues_count":17,"forks":73,"open_issues":17,"watchers":65,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aurelia/dialog/pulls/218"},"html":{"href":"https://github.com/aurelia/dialog/pull/218"},"issue":{"href":"https://api.github.com/repos/aurelia/dialog/issues/218"},"comments":{"href":"https://api.github.com/repos/aurelia/dialog/issues/218/comments"},"review_comments":{"href":"https://api.github.com/repos/aurelia/dialog/pulls/218/comments"},"review_comment":{"href":"https://api.github.com/repos/aurelia/dialog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aurelia/dialog/pulls/218/commits"},"statuses":{"href":"https://api.github.com/repos/aurelia/dialog/statuses/22022bd8d25ae488d45566f509378a8813aeef7a"}}}}
{"actor":{"display_login":"PWKad"}}