{"action":"created","issue":{"url":"https://api.github.com/repos/jenkinsci/groovy-events-listener-plugin/issues/17","repository_url":"https://api.github.com/repos/jenkinsci/groovy-events-listener-plugin","labels_url":"https://api.github.com/repos/jenkinsci/groovy-events-listener-plugin/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/jenkinsci/groovy-events-listener-plugin/issues/17/comments","events_url":"https://api.github.com/repos/jenkinsci/groovy-events-listener-plugin/issues/17/events","html_url":"https://github.com/jenkinsci/groovy-events-listener-plugin/issues/17","id":160305062,"number":17,"title":"Pre-pull request review","user":{"login":"nickgrealy","id":1669373,"avatar_url":"https://avatars.githubusercontent.com/u/1669373?v=3","gravatar_id":"","url":"https://api.github.com/users/nickgrealy","html_url":"https://github.com/nickgrealy","followers_url":"https://api.github.com/users/nickgrealy/followers","following_url":"https://api.github.com/users/nickgrealy/following{/other_user}","gists_url":"https://api.github.com/users/nickgrealy/gists{/gist_id}","starred_url":"https://api.github.com/users/nickgrealy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickgrealy/subscriptions","organizations_url":"https://api.github.com/users/nickgrealy/orgs","repos_url":"https://api.github.com/users/nickgrealy/repos","events_url":"https://api.github.com/users/nickgrealy/events{/privacy}","received_events_url":"https://api.github.com/users/nickgrealy/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/jenkinsci/groovy-events-listener-plugin/labels/question","name":"question","color":"cc317c"}],"state":"open","locked":false,"assignee":{"login":"nickgrealy","id":1669373,"avatar_url":"https://avatars.githubusercontent.com/u/1669373?v=3","gravatar_id":"","url":"https://api.github.com/users/nickgrealy","html_url":"https://github.com/nickgrealy","followers_url":"https://api.github.com/users/nickgrealy/followers","following_url":"https://api.github.com/users/nickgrealy/following{/other_user}","gists_url":"https://api.github.com/users/nickgrealy/gists{/gist_id}","starred_url":"https://api.github.com/users/nickgrealy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickgrealy/subscriptions","organizations_url":"https://api.github.com/users/nickgrealy/orgs","repos_url":"https://api.github.com/users/nickgrealy/repos","events_url":"https://api.github.com/users/nickgrealy/events{/privacy}","received_events_url":"https://api.github.com/users/nickgrealy/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/jenkinsci/groovy-events-listener-plugin/milestones/5","html_url":"https://github.com/jenkinsci/groovy-events-listener-plugin/milestones/1.014","labels_url":"https://api.github.com/repos/jenkinsci/groovy-events-listener-plugin/milestones/5/labels","id":1726238,"number":5,"title":"1.014","description":"","creator":{"login":"nickgrealy","id":1669373,"avatar_url":"https://avatars.githubusercontent.com/u/1669373?v=3","gravatar_id":"","url":"https://api.github.com/users/nickgrealy","html_url":"https://github.com/nickgrealy","followers_url":"https://api.github.com/users/nickgrealy/followers","following_url":"https://api.github.com/users/nickgrealy/following{/other_user}","gists_url":"https://api.github.com/users/nickgrealy/gists{/gist_id}","starred_url":"https://api.github.com/users/nickgrealy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickgrealy/subscriptions","organizations_url":"https://api.github.com/users/nickgrealy/orgs","repos_url":"https://api.github.com/users/nickgrealy/repos","events_url":"https://api.github.com/users/nickgrealy/events{/privacy}","received_events_url":"https://api.github.com/users/nickgrealy/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":0,"state":"open","created_at":"2016-04-23T01:01:53Z","updated_at":"2016-06-14T23:09:48Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2016-06-14T23:09:48Z","updated_at":"2016-06-14T23:29:08Z","closed_at":null,"body":"@llaaiiqq has asked if we can provide some thoughts/insight/feedback before he submits a pull request:\r\n\r\n> I've extended it to listen to node online/offline events and job queue events. Code is on my fork. I haven't submitted a PR yet because I want to clean things up a bit first - adding nine more event types added a lot of boilerplate code, and I'd like to refactor things to trim it down.\r\n> \r\n> I was wondering if you had any thoughts on where you'd like to see things go before I dive in.\r\n\r\nFork is here: https://github.com/llaaiiqq/groovy-events-listener-plugin/commits/master\r\n\r\n@Jimilian - just wanted your input as well, as you've been large contributor to date."},"comment":{"url":"https://api.github.com/repos/jenkinsci/groovy-events-listener-plugin/issues/comments/226047144","html_url":"https://github.com/jenkinsci/groovy-events-listener-plugin/issues/17#issuecomment-226047144","issue_url":"https://api.github.com/repos/jenkinsci/groovy-events-listener-plugin/issues/17","id":226047144,"user":{"login":"nickgrealy","id":1669373,"avatar_url":"https://avatars.githubusercontent.com/u/1669373?v=3","gravatar_id":"","url":"https://api.github.com/users/nickgrealy","html_url":"https://github.com/nickgrealy","followers_url":"https://api.github.com/users/nickgrealy/followers","following_url":"https://api.github.com/users/nickgrealy/following{/other_user}","gists_url":"https://api.github.com/users/nickgrealy/gists{/gist_id}","starred_url":"https://api.github.com/users/nickgrealy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickgrealy/subscriptions","organizations_url":"https://api.github.com/users/nickgrealy/orgs","repos_url":"https://api.github.com/users/nickgrealy/repos","events_url":"https://api.github.com/users/nickgrealy/events{/privacy}","received_events_url":"https://api.github.com/users/nickgrealy/received_events","type":"User","site_admin":false},"created_at":"2016-06-14T23:29:08Z","updated_at":"2016-06-14T23:29:08Z","body":"First of all, thanks for taking the time to contribute! It's much appreciated, and I'm sure it will help others.\r\n\r\n**Having a quick look at the code:**\r\n- I like the new functionality - (Node and Queue listeners make sense)\r\n- I like the qualified event names (e.g. `Queue.*`, ,`Run.*`, etc)\r\n- I like the `processEvents` method, how it cleans up some of the boiler plate code\r\n\r\n**Things I'd like to see:**\r\n- tests - I can't see any tests that cover the new functionality. This could be as simple as adding a [few more scenarios in here](https://github.com/llaaiiqq/groovy-events-listener-plugin/blob/master/src/test/resources/org/jenkinsci/plugins/globalEventsPlugin/acceptance/Groovy%20Script%20-%20Runtime.feature#L28-32). Let me know if you need a hand with writing/modifying cucumber acceptance tests.\r\n- a screenshot - what do the new configuration options look like\r\n\r\n\r\n**Things I need to add:**\r\n- static code analysis - basically I need [to add this file into the project](https://github.com/jenkinsci/poll-mailbox-trigger-plugin/blob/master/config/gradle/staticCodeAnalysis.gradle) at some point. This will (hopefully) improve the quality of code submissions, and give people a guideline for code style (without being too oppressive??). I'll wait until after your pull-request if you prefer?"}}
{"actor":{"display_login":"nickgrealy"}}