{"action":"closed","number":1088,"pull_request":{"url":"https://api.github.com/repos/ninja-build/ninja/pulls/1088","id":55584891,"html_url":"https://github.com/ninja-build/ninja/pull/1088","diff_url":"https://github.com/ninja-build/ninja/pull/1088.diff","patch_url":"https://github.com/ninja-build/ninja/pull/1088.patch","issue_url":"https://api.github.com/repos/ninja-build/ninja/issues/1088","number":1088,"state":"closed","locked":false,"title":"Delete a newed DiskInterface object if it is owned.","user":{"login":"tetsuok","id":1183444,"avatar_url":"https://avatars.githubusercontent.com/u/1183444?v=3","gravatar_id":"","url":"https://api.github.com/users/tetsuok","html_url":"https://github.com/tetsuok","followers_url":"https://api.github.com/users/tetsuok/followers","following_url":"https://api.github.com/users/tetsuok/following{/other_user}","gists_url":"https://api.github.com/users/tetsuok/gists{/gist_id}","starred_url":"https://api.github.com/users/tetsuok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tetsuok/subscriptions","organizations_url":"https://api.github.com/users/tetsuok/orgs","repos_url":"https://api.github.com/users/tetsuok/repos","events_url":"https://api.github.com/users/tetsuok/events{/privacy}","received_events_url":"https://api.github.com/users/tetsuok/received_events","type":"User","site_admin":false},"body":"`Cleaner` has two type of constructors: (1) allocates a `DiskInterface` object by `new` (i.e., owns the object); (2) takes a pointer to a `DiskInterface` object (AFAIK, the class doesn't own the object).\r\n\r\nIf the first type of the constructor is called, it is the Cleaner's responsibility to free the `DiskInterface` object when the object is not needed any more.","created_at":"2016-01-11T03:47:43Z","updated_at":"2016-01-12T10:42:15Z","closed_at":"2016-01-12T10:42:15Z","merged_at":null,"merge_commit_sha":"1f071e637bbfc971a392b6f9d99c33c0fd9bb615","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ninja-build/ninja/pulls/1088/commits","review_comments_url":"https://api.github.com/repos/ninja-build/ninja/pulls/1088/comments","review_comment_url":"https://api.github.com/repos/ninja-build/ninja/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ninja-build/ninja/issues/1088/comments","statuses_url":"https://api.github.com/repos/ninja-build/ninja/statuses/836c59fd046a7536ec51c71edaf954ddd6120e35","head":{"label":"tetsuok:delete-disk-inteface","ref":"delete-disk-inteface","sha":"836c59fd046a7536ec51c71edaf954ddd6120e35","user":{"login":"tetsuok","id":1183444,"avatar_url":"https://avatars.githubusercontent.com/u/1183444?v=3","gravatar_id":"","url":"https://api.github.com/users/tetsuok","html_url":"https://github.com/tetsuok","followers_url":"https://api.github.com/users/tetsuok/followers","following_url":"https://api.github.com/users/tetsuok/following{/other_user}","gists_url":"https://api.github.com/users/tetsuok/gists{/gist_id}","starred_url":"https://api.github.com/users/tetsuok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tetsuok/subscriptions","organizations_url":"https://api.github.com/users/tetsuok/orgs","repos_url":"https://api.github.com/users/tetsuok/repos","events_url":"https://api.github.com/users/tetsuok/events{/privacy}","received_events_url":"https://api.github.com/users/tetsuok/received_events","type":"User","site_admin":false},"repo":{"id":49365924,"name":"ninja","full_name":"tetsuok/ninja","owner":{"login":"tetsuok","id":1183444,"avatar_url":"https://avatars.githubusercontent.com/u/1183444?v=3","gravatar_id":"","url":"https://api.github.com/users/tetsuok","html_url":"https://github.com/tetsuok","followers_url":"https://api.github.com/users/tetsuok/followers","following_url":"https://api.github.com/users/tetsuok/following{/other_user}","gists_url":"https://api.github.com/users/tetsuok/gists{/gist_id}","starred_url":"https://api.github.com/users/tetsuok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tetsuok/subscriptions","organizations_url":"https://api.github.com/users/tetsuok/orgs","repos_url":"https://api.github.com/users/tetsuok/repos","events_url":"https://api.github.com/users/tetsuok/events{/privacy}","received_events_url":"https://api.github.com/users/tetsuok/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tetsuok/ninja","description":"a small build system with a focus on speed","fork":true,"url":"https://api.github.com/repos/tetsuok/ninja","forks_url":"https://api.github.com/repos/tetsuok/ninja/forks","keys_url":"https://api.github.com/repos/tetsuok/ninja/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tetsuok/ninja/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tetsuok/ninja/teams","hooks_url":"https://api.github.com/repos/tetsuok/ninja/hooks","issue_events_url":"https://api.github.com/repos/tetsuok/ninja/issues/events{/number}","events_url":"https://api.github.com/repos/tetsuok/ninja/events","assignees_url":"https://api.github.com/repos/tetsuok/ninja/assignees{/user}","branches_url":"https://api.github.com/repos/tetsuok/ninja/branches{/branch}","tags_url":"https://api.github.com/repos/tetsuok/ninja/tags","blobs_url":"https://api.github.com/repos/tetsuok/ninja/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tetsuok/ninja/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tetsuok/ninja/git/refs{/sha}","trees_url":"https://api.github.com/repos/tetsuok/ninja/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tetsuok/ninja/statuses/{sha}","languages_url":"https://api.github.com/repos/tetsuok/ninja/languages","stargazers_url":"https://api.github.com/repos/tetsuok/ninja/stargazers","contributors_url":"https://api.github.com/repos/tetsuok/ninja/contributors","subscribers_url":"https://api.github.com/repos/tetsuok/ninja/subscribers","subscription_url":"https://api.github.com/repos/tetsuok/ninja/subscription","commits_url":"https://api.github.com/repos/tetsuok/ninja/commits{/sha}","git_commits_url":"https://api.github.com/repos/tetsuok/ninja/git/commits{/sha}","comments_url":"https://api.github.com/repos/tetsuok/ninja/comments{/number}","issue_comment_url":"https://api.github.com/repos/tetsuok/ninja/issues/comments{/number}","contents_url":"https://api.github.com/repos/tetsuok/ninja/contents/{+path}","compare_url":"https://api.github.com/repos/tetsuok/ninja/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tetsuok/ninja/merges","archive_url":"https://api.github.com/repos/tetsuok/ninja/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tetsuok/ninja/downloads","issues_url":"https://api.github.com/repos/tetsuok/ninja/issues{/number}","pulls_url":"https://api.github.com/repos/tetsuok/ninja/pulls{/number}","milestones_url":"https://api.github.com/repos/tetsuok/ninja/milestones{/number}","notifications_url":"https://api.github.com/repos/tetsuok/ninja/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tetsuok/ninja/labels{/name}","releases_url":"https://api.github.com/repos/tetsuok/ninja/releases{/id}","created_at":"2016-01-10T12:30:02Z","updated_at":"2016-01-10T12:30:03Z","pushed_at":"2016-01-11T03:41:49Z","git_url":"git://github.com/tetsuok/ninja.git","ssh_url":"git@github.com:tetsuok/ninja.git","clone_url":"https://github.com/tetsuok/ninja.git","svn_url":"https://github.com/tetsuok/ninja","homepage":"http://ninja-build.org/","size":2009,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ninja-build:master","ref":"master","sha":"19a3066bf76bd121ca39ca138577f90bea5a10a2","user":{"login":"ninja-build","id":11653218,"avatar_url":"https://avatars.githubusercontent.com/u/11653218?v=3","gravatar_id":"","url":"https://api.github.com/users/ninja-build","html_url":"https://github.com/ninja-build","followers_url":"https://api.github.com/users/ninja-build/followers","following_url":"https://api.github.com/users/ninja-build/following{/other_user}","gists_url":"https://api.github.com/users/ninja-build/gists{/gist_id}","starred_url":"https://api.github.com/users/ninja-build/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ninja-build/subscriptions","organizations_url":"https://api.github.com/users/ninja-build/orgs","repos_url":"https://api.github.com/users/ninja-build/repos","events_url":"https://api.github.com/users/ninja-build/events{/privacy}","received_events_url":"https://api.github.com/users/ninja-build/received_events","type":"Organization","site_admin":false},"repo":{"id":1335132,"name":"ninja","full_name":"ninja-build/ninja","owner":{"login":"ninja-build","id":11653218,"avatar_url":"https://avatars.githubusercontent.com/u/11653218?v=3","gravatar_id":"","url":"https://api.github.com/users/ninja-build","html_url":"https://github.com/ninja-build","followers_url":"https://api.github.com/users/ninja-build/followers","following_url":"https://api.github.com/users/ninja-build/following{/other_user}","gists_url":"https://api.github.com/users/ninja-build/gists{/gist_id}","starred_url":"https://api.github.com/users/ninja-build/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ninja-build/subscriptions","organizations_url":"https://api.github.com/users/ninja-build/orgs","repos_url":"https://api.github.com/users/ninja-build/repos","events_url":"https://api.github.com/users/ninja-build/events{/privacy}","received_events_url":"https://api.github.com/users/ninja-build/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ninja-build/ninja","description":"a small build system with a focus on speed","fork":false,"url":"https://api.github.com/repos/ninja-build/ninja","forks_url":"https://api.github.com/repos/ninja-build/ninja/forks","keys_url":"https://api.github.com/repos/ninja-build/ninja/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ninja-build/ninja/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ninja-build/ninja/teams","hooks_url":"https://api.github.com/repos/ninja-build/ninja/hooks","issue_events_url":"https://api.github.com/repos/ninja-build/ninja/issues/events{/number}","events_url":"https://api.github.com/repos/ninja-build/ninja/events","assignees_url":"https://api.github.com/repos/ninja-build/ninja/assignees{/user}","branches_url":"https://api.github.com/repos/ninja-build/ninja/branches{/branch}","tags_url":"https://api.github.com/repos/ninja-build/ninja/tags","blobs_url":"https://api.github.com/repos/ninja-build/ninja/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ninja-build/ninja/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ninja-build/ninja/git/refs{/sha}","trees_url":"https://api.github.com/repos/ninja-build/ninja/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ninja-build/ninja/statuses/{sha}","languages_url":"https://api.github.com/repos/ninja-build/ninja/languages","stargazers_url":"https://api.github.com/repos/ninja-build/ninja/stargazers","contributors_url":"https://api.github.com/repos/ninja-build/ninja/contributors","subscribers_url":"https://api.github.com/repos/ninja-build/ninja/subscribers","subscription_url":"https://api.github.com/repos/ninja-build/ninja/subscription","commits_url":"https://api.github.com/repos/ninja-build/ninja/commits{/sha}","git_commits_url":"https://api.github.com/repos/ninja-build/ninja/git/commits{/sha}","comments_url":"https://api.github.com/repos/ninja-build/ninja/comments{/number}","issue_comment_url":"https://api.github.com/repos/ninja-build/ninja/issues/comments{/number}","contents_url":"https://api.github.com/repos/ninja-build/ninja/contents/{+path}","compare_url":"https://api.github.com/repos/ninja-build/ninja/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ninja-build/ninja/merges","archive_url":"https://api.github.com/repos/ninja-build/ninja/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ninja-build/ninja/downloads","issues_url":"https://api.github.com/repos/ninja-build/ninja/issues{/number}","pulls_url":"https://api.github.com/repos/ninja-build/ninja/pulls{/number}","milestones_url":"https://api.github.com/repos/ninja-build/ninja/milestones{/number}","notifications_url":"https://api.github.com/repos/ninja-build/ninja/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ninja-build/ninja/labels{/name}","releases_url":"https://api.github.com/repos/ninja-build/ninja/releases{/id}","created_at":"2011-02-06T19:07:12Z","updated_at":"2016-01-12T09:47:24Z","pushed_at":"2016-01-11T03:47:44Z","git_url":"git://github.com/ninja-build/ninja.git","ssh_url":"git@github.com:ninja-build/ninja.git","clone_url":"https://github.com/ninja-build/ninja.git","svn_url":"https://github.com/ninja-build/ninja","homepage":"http://ninja-build.org/","size":7855,"stargazers_count":1770,"watchers_count":1770,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":310,"mirror_url":null,"open_issues_count":164,"forks":310,"open_issues":164,"watchers":1770,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ninja-build/ninja/pulls/1088"},"html":{"href":"https://github.com/ninja-build/ninja/pull/1088"},"issue":{"href":"https://api.github.com/repos/ninja-build/ninja/issues/1088"},"comments":{"href":"https://api.github.com/repos/ninja-build/ninja/issues/1088/comments"},"review_comments":{"href":"https://api.github.com/repos/ninja-build/ninja/pulls/1088/comments"},"review_comment":{"href":"https://api.github.com/repos/ninja-build/ninja/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ninja-build/ninja/pulls/1088/commits"},"statuses":{"href":"https://api.github.com/repos/ninja-build/ninja/statuses/836c59fd046a7536ec51c71edaf954ddd6120e35"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":9,"deletions":0,"changed_files":2}}