{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/53836104","id":53836104,"diff_hunk":"@@ -62,6 +62,8 @@ const (\n \n \tMinimumDockerAPIVersion = \"1.18\"\n \n+\tOOMScoreAdjDockerAPIVersion = \"1.21\"","path":"pkg/kubelet/dockertools/manager.go","position":4,"original_position":4,"commit_id":"d4651027a2db72f0fd9d78641302993b9116238f","original_commit_id":"d4651027a2db72f0fd9d78641302993b9116238f","user":{"login":"vishh","id":7063592,"avatar_url":"https://avatars.githubusercontent.com/u/7063592?v=3","gravatar_id":"","url":"https://api.github.com/users/vishh","html_url":"https://github.com/vishh","followers_url":"https://api.github.com/users/vishh/followers","following_url":"https://api.github.com/users/vishh/following{/other_user}","gists_url":"https://api.github.com/users/vishh/gists{/gist_id}","starred_url":"https://api.github.com/users/vishh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishh/subscriptions","organizations_url":"https://api.github.com/users/vishh/orgs","repos_url":"https://api.github.com/users/vishh/repos","events_url":"https://api.github.com/users/vishh/events{/privacy}","received_events_url":"https://api.github.com/users/vishh/received_events","type":"User","site_admin":false},"body":"nit: This version adds a few more features. Can you rename this to be `dockerv110APIVersion` instead?","created_at":"2016-02-23T19:34:45Z","updated_at":"2016-02-23T19:34:45Z","html_url":"https://github.com/kubernetes/kubernetes/pull/21741#discussion_r53836104","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/21741","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/53836104"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/21741#discussion_r53836104"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/21741"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/21741","id":60314544,"html_url":"https://github.com/kubernetes/kubernetes/pull/21741","diff_url":"https://github.com/kubernetes/kubernetes/pull/21741.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/21741.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/21741","number":21741,"state":"open","locked":false,"title":"[WIP]Use OomScoreAdj in kubelet for newer docker api","user":{"login":"resouer","id":1701782,"avatar_url":"https://avatars.githubusercontent.com/u/1701782?v=3","gravatar_id":"","url":"https://api.github.com/users/resouer","html_url":"https://github.com/resouer","followers_url":"https://api.github.com/users/resouer/followers","following_url":"https://api.github.com/users/resouer/following{/other_user}","gists_url":"https://api.github.com/users/resouer/gists{/gist_id}","starred_url":"https://api.github.com/users/resouer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resouer/subscriptions","organizations_url":"https://api.github.com/users/resouer/orgs","repos_url":"https://api.github.com/users/resouer/repos","events_url":"https://api.github.com/users/resouer/events{/privacy}","received_events_url":"https://api.github.com/users/resouer/received_events","type":"User","site_admin":false},"body":"fixes: #20121\r\n\r\nRelated: client side PR [pull 454](https://github.com/fsouza/go-dockerclient/pull/454)\r\n\r\nGodeps has already been updated to `0099401a7342ad77e71ca9f9a57c5e72fb80f6b2`, which included client side's modification. But it seems too aggressive to upgrade the docker api version of kubelet. ","created_at":"2016-02-23T10:01:44Z","updated_at":"2016-02-23T19:34:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c5b404ce6c55487c548ad3c14a4067ff9bbc700","assignee":{"login":"dchen1107","id":7740897,"avatar_url":"https://avatars.githubusercontent.com/u/7740897?v=3","gravatar_id":"","url":"https://api.github.com/users/dchen1107","html_url":"https://github.com/dchen1107","followers_url":"https://api.github.com/users/dchen1107/followers","following_url":"https://api.github.com/users/dchen1107/following{/other_user}","gists_url":"https://api.github.com/users/dchen1107/gists{/gist_id}","starred_url":"https://api.github.com/users/dchen1107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchen1107/subscriptions","organizations_url":"https://api.github.com/users/dchen1107/orgs","repos_url":"https://api.github.com/users/dchen1107/repos","events_url":"https://api.github.com/users/dchen1107/events{/privacy}","received_events_url":"https://api.github.com/users/dchen1107/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/21741/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/21741/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/21741/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/d4651027a2db72f0fd9d78641302993b9116238f","head":{"label":"resouer:oomscore","ref":"oomscore","sha":"d4651027a2db72f0fd9d78641302993b9116238f","user":{"login":"resouer","id":1701782,"avatar_url":"https://avatars.githubusercontent.com/u/1701782?v=3","gravatar_id":"","url":"https://api.github.com/users/resouer","html_url":"https://github.com/resouer","followers_url":"https://api.github.com/users/resouer/followers","following_url":"https://api.github.com/users/resouer/following{/other_user}","gists_url":"https://api.github.com/users/resouer/gists{/gist_id}","starred_url":"https://api.github.com/users/resouer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resouer/subscriptions","organizations_url":"https://api.github.com/users/resouer/orgs","repos_url":"https://api.github.com/users/resouer/repos","events_url":"https://api.github.com/users/resouer/events{/privacy}","received_events_url":"https://api.github.com/users/resouer/received_events","type":"User","site_admin":false},"repo":{"id":28023343,"name":"kubernetes","full_name":"resouer/kubernetes","owner":{"login":"resouer","id":1701782,"avatar_url":"https://avatars.githubusercontent.com/u/1701782?v=3","gravatar_id":"","url":"https://api.github.com/users/resouer","html_url":"https://github.com/resouer","followers_url":"https://api.github.com/users/resouer/followers","following_url":"https://api.github.com/users/resouer/following{/other_user}","gists_url":"https://api.github.com/users/resouer/gists{/gist_id}","starred_url":"https://api.github.com/users/resouer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resouer/subscriptions","organizations_url":"https://api.github.com/users/resouer/orgs","repos_url":"https://api.github.com/users/resouer/repos","events_url":"https://api.github.com/users/resouer/events{/privacy}","received_events_url":"https://api.github.com/users/resouer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/resouer/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/resouer/kubernetes","forks_url":"https://api.github.com/repos/resouer/kubernetes/forks","keys_url":"https://api.github.com/repos/resouer/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/resouer/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/resouer/kubernetes/teams","hooks_url":"https://api.github.com/repos/resouer/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/resouer/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/resouer/kubernetes/events","assignees_url":"https://api.github.com/repos/resouer/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/resouer/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/resouer/kubernetes/tags","blobs_url":"https://api.github.com/repos/resouer/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/resouer/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/resouer/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/resouer/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/resouer/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/resouer/kubernetes/languages","stargazers_url":"https://api.github.com/repos/resouer/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/resouer/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/resouer/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/resouer/kubernetes/subscription","commits_url":"https://api.github.com/repos/resouer/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/resouer/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/resouer/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/resouer/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/resouer/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/resouer/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/resouer/kubernetes/merges","archive_url":"https://api.github.com/repos/resouer/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/resouer/kubernetes/downloads","issues_url":"https://api.github.com/repos/resouer/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/resouer/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/resouer/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/resouer/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/resouer/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/resouer/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/resouer/kubernetes/deployments","created_at":"2014-12-15T06:15:28Z","updated_at":"2016-01-11T07:18:05Z","pushed_at":"2016-02-23T15:55:02Z","git_url":"git://github.com/resouer/kubernetes.git","ssh_url":"git@github.com:resouer/kubernetes.git","clone_url":"https://github.com/resouer/kubernetes.git","svn_url":"https://github.com/resouer/kubernetes","homepage":null,"size":169371,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"d0ce85a6d1dfd45cf30fda02980aba6a48409008","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-02-23T19:15:12Z","pushed_at":"2016-02-23T19:33:26Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":329606,"stargazers_count":12840,"watchers_count":12840,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3666,"mirror_url":null,"open_issues_count":2933,"forks":3666,"open_issues":2933,"watchers":12840,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/21741"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/21741"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/21741"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/21741/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/21741/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/21741/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/d4651027a2db72f0fd9d78641302993b9116238f"}}}}