{"action":"closed","number":1753,"pull_request":{"url":"https://api.github.com/repos/facebook/flow/pulls/1753","id":69175864,"html_url":"https://github.com/facebook/flow/pull/1753","diff_url":"https://github.com/facebook/flow/pull/1753.diff","patch_url":"https://github.com/facebook/flow/pull/1753.patch","issue_url":"https://api.github.com/repos/facebook/flow/issues/1753","number":1753,"state":"closed","locked":false,"title":"Fix Makefile rebuilding of object files","user":{"login":"mroch","id":3012,"avatar_url":"https://avatars.githubusercontent.com/u/3012?v=3","gravatar_id":"","url":"https://api.github.com/users/mroch","html_url":"https://github.com/mroch","followers_url":"https://api.github.com/users/mroch/followers","following_url":"https://api.github.com/users/mroch/following{/other_user}","gists_url":"https://api.github.com/users/mroch/gists{/gist_id}","starred_url":"https://api.github.com/users/mroch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mroch/subscriptions","organizations_url":"https://api.github.com/users/mroch/orgs","repos_url":"https://api.github.com/users/mroch/repos","events_url":"https://api.github.com/users/mroch/events{/privacy}","received_events_url":"https://api.github.com/users/mroch/received_events","type":"User","site_admin":false},"body":"I was having problems with `make` not picking up changes to `.c` files. I think the problem is that `build-flow` depends on `build-flow-native-deps` which does not actually depend on the `.c` files, so that step was getting skipped.\r\n\r\nAs I started tweaking stuff, I eventually just replaced the target that runs `ocamlbuild` on all `.o` files with a rule that directly runs `ocamlopt` on each `.c` file, letting `make` instead of `ocamlbuild` decide when it's dirty. this is faster.\r\n\r\nTest Plan: changed hh_shared.c, ran `make`. before, it wasn't picking up my changes unless I deleted `_build/`. after, it works. running `make` again doesn't rebuild things that are clean.","created_at":"2016-05-06T16:28:32Z","updated_at":"2016-05-06T20:55:26Z","closed_at":"2016-05-06T20:55:26Z","merged_at":null,"merge_commit_sha":"f556b8e9443a43a03a13e8d14babd05063b6676a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/flow/pulls/1753/commits","review_comments_url":"https://api.github.com/repos/facebook/flow/pulls/1753/comments","review_comment_url":"https://api.github.com/repos/facebook/flow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/flow/issues/1753/comments","statuses_url":"https://api.github.com/repos/facebook/flow/statuses/7de14cc3fe1c89def6159a84b7b47bc1ed044df8","head":{"label":"mroch:makefile_objects","ref":"makefile_objects","sha":"7de14cc3fe1c89def6159a84b7b47bc1ed044df8","user":{"login":"mroch","id":3012,"avatar_url":"https://avatars.githubusercontent.com/u/3012?v=3","gravatar_id":"","url":"https://api.github.com/users/mroch","html_url":"https://github.com/mroch","followers_url":"https://api.github.com/users/mroch/followers","following_url":"https://api.github.com/users/mroch/following{/other_user}","gists_url":"https://api.github.com/users/mroch/gists{/gist_id}","starred_url":"https://api.github.com/users/mroch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mroch/subscriptions","organizations_url":"https://api.github.com/users/mroch/orgs","repos_url":"https://api.github.com/users/mroch/repos","events_url":"https://api.github.com/users/mroch/events{/privacy}","received_events_url":"https://api.github.com/users/mroch/received_events","type":"User","site_admin":false},"repo":{"id":33884096,"name":"flow","full_name":"mroch/flow","owner":{"login":"mroch","id":3012,"avatar_url":"https://avatars.githubusercontent.com/u/3012?v=3","gravatar_id":"","url":"https://api.github.com/users/mroch","html_url":"https://github.com/mroch","followers_url":"https://api.github.com/users/mroch/followers","following_url":"https://api.github.com/users/mroch/following{/other_user}","gists_url":"https://api.github.com/users/mroch/gists{/gist_id}","starred_url":"https://api.github.com/users/mroch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mroch/subscriptions","organizations_url":"https://api.github.com/users/mroch/orgs","repos_url":"https://api.github.com/users/mroch/repos","events_url":"https://api.github.com/users/mroch/events{/privacy}","received_events_url":"https://api.github.com/users/mroch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mroch/flow","description":"Adds static typing to JavaScript to improve developer productivity and code quality.","fork":true,"url":"https://api.github.com/repos/mroch/flow","forks_url":"https://api.github.com/repos/mroch/flow/forks","keys_url":"https://api.github.com/repos/mroch/flow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mroch/flow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mroch/flow/teams","hooks_url":"https://api.github.com/repos/mroch/flow/hooks","issue_events_url":"https://api.github.com/repos/mroch/flow/issues/events{/number}","events_url":"https://api.github.com/repos/mroch/flow/events","assignees_url":"https://api.github.com/repos/mroch/flow/assignees{/user}","branches_url":"https://api.github.com/repos/mroch/flow/branches{/branch}","tags_url":"https://api.github.com/repos/mroch/flow/tags","blobs_url":"https://api.github.com/repos/mroch/flow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mroch/flow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mroch/flow/git/refs{/sha}","trees_url":"https://api.github.com/repos/mroch/flow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mroch/flow/statuses/{sha}","languages_url":"https://api.github.com/repos/mroch/flow/languages","stargazers_url":"https://api.github.com/repos/mroch/flow/stargazers","contributors_url":"https://api.github.com/repos/mroch/flow/contributors","subscribers_url":"https://api.github.com/repos/mroch/flow/subscribers","subscription_url":"https://api.github.com/repos/mroch/flow/subscription","commits_url":"https://api.github.com/repos/mroch/flow/commits{/sha}","git_commits_url":"https://api.github.com/repos/mroch/flow/git/commits{/sha}","comments_url":"https://api.github.com/repos/mroch/flow/comments{/number}","issue_comment_url":"https://api.github.com/repos/mroch/flow/issues/comments{/number}","contents_url":"https://api.github.com/repos/mroch/flow/contents/{+path}","compare_url":"https://api.github.com/repos/mroch/flow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mroch/flow/merges","archive_url":"https://api.github.com/repos/mroch/flow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mroch/flow/downloads","issues_url":"https://api.github.com/repos/mroch/flow/issues{/number}","pulls_url":"https://api.github.com/repos/mroch/flow/pulls{/number}","milestones_url":"https://api.github.com/repos/mroch/flow/milestones{/number}","notifications_url":"https://api.github.com/repos/mroch/flow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mroch/flow/labels{/name}","releases_url":"https://api.github.com/repos/mroch/flow/releases{/id}","deployments_url":"https://api.github.com/repos/mroch/flow/deployments","created_at":"2015-04-13T17:48:19Z","updated_at":"2016-01-20T00:41:47Z","pushed_at":"2016-05-06T19:00:35Z","git_url":"git://github.com/mroch/flow.git","ssh_url":"git@github.com:mroch/flow.git","clone_url":"https://github.com/mroch/flow.git","svn_url":"https://github.com/mroch/flow","homepage":"http://flowtype.org/","size":148497,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"9fa034ea710defeaf938861a1e5e310c35147e97","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":25880891,"name":"flow","full_name":"facebook/flow","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/flow","description":"Adds static typing to JavaScript to improve developer productivity and code quality.","fork":false,"url":"https://api.github.com/repos/facebook/flow","forks_url":"https://api.github.com/repos/facebook/flow/forks","keys_url":"https://api.github.com/repos/facebook/flow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/flow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/flow/teams","hooks_url":"https://api.github.com/repos/facebook/flow/hooks","issue_events_url":"https://api.github.com/repos/facebook/flow/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/flow/events","assignees_url":"https://api.github.com/repos/facebook/flow/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/flow/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/flow/tags","blobs_url":"https://api.github.com/repos/facebook/flow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/flow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/flow/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/flow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/flow/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/flow/languages","stargazers_url":"https://api.github.com/repos/facebook/flow/stargazers","contributors_url":"https://api.github.com/repos/facebook/flow/contributors","subscribers_url":"https://api.github.com/repos/facebook/flow/subscribers","subscription_url":"https://api.github.com/repos/facebook/flow/subscription","commits_url":"https://api.github.com/repos/facebook/flow/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/flow/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/flow/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/flow/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/flow/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/flow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/flow/merges","archive_url":"https://api.github.com/repos/facebook/flow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/flow/downloads","issues_url":"https://api.github.com/repos/facebook/flow/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/flow/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/flow/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/flow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/flow/labels{/name}","releases_url":"https://api.github.com/repos/facebook/flow/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/flow/deployments","created_at":"2014-10-28T17:17:45Z","updated_at":"2016-05-06T19:31:06Z","pushed_at":"2016-05-06T20:55:25Z","git_url":"git://github.com/facebook/flow.git","ssh_url":"git@github.com:facebook/flow.git","clone_url":"https://github.com/facebook/flow.git","svn_url":"https://github.com/facebook/flow","homepage":"http://flowtype.org/","size":152394,"stargazers_count":7127,"watchers_count":7127,"language":"OCaml","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":471,"mirror_url":null,"open_issues_count":526,"forks":471,"open_issues":526,"watchers":7127,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/flow/pulls/1753"},"html":{"href":"https://github.com/facebook/flow/pull/1753"},"issue":{"href":"https://api.github.com/repos/facebook/flow/issues/1753"},"comments":{"href":"https://api.github.com/repos/facebook/flow/issues/1753/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/flow/pulls/1753/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/flow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/flow/pulls/1753/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/flow/statuses/7de14cc3fe1c89def6159a84b7b47bc1ed044df8"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":2,"review_comments":0,"commits":2,"additions":20,"deletions":12,"changed_files":1}}