{"action":"created","comment":{"url":"https://api.github.com/repos/fedora-infra/nuancier/pulls/comments/91681690","pull_request_review_id":12191904,"id":91681690,"diff_hunk":"@@ -48,7 +52,39 @@ def is_number(form, field):\n         raise wtf.ValidationError('Field must contain a number')\n \n \n-class AddElectionForm(flask_wtf.Form):\n+class BaseForm(flask_wtf.Form):\n+    \"\"\"\n+    Provide a base form class.\n+\n+    For new versions of flask-wtf (greater than 0.10.0), this behaves exactly\n+    like :class:`flask_wtf.Form`.\n+\n+    Versions of flask-wtf prior to 0.10.0 did not have or did not properly use\n+    the 'WTF_CSRF_TIME_LIMIT' setting. This configures the self.TIME_LIMIT\n+    value used by flask-wtf if the delta is not None and it's an old version of\n+    flask-wtf. See https://github.com/lepture/flask-wtf/issues/131 for more\n+    information.\n+    \"\"\"\n+\n+    def __init__(self, *args, **kwargs):\n+        delta = APP.config.get('WTF_CSRF_TIME_LIMIT', 3600)","path":"nuancier/forms.py","position":50,"original_position":50,"commit_id":"76d8ec990e971c929265f1f0c77c8363693a948c","original_commit_id":"76d8ec990e971c929265f1f0c77c8363693a948c","user":{"login":"pypingou","id":1240038,"avatar_url":"https://avatars.githubusercontent.com/u/1240038?v=3","gravatar_id":"","url":"https://api.github.com/users/pypingou","html_url":"https://github.com/pypingou","followers_url":"https://api.github.com/users/pypingou/followers","following_url":"https://api.github.com/users/pypingou/following{/other_user}","gists_url":"https://api.github.com/users/pypingou/gists{/gist_id}","starred_url":"https://api.github.com/users/pypingou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pypingou/subscriptions","organizations_url":"https://api.github.com/users/pypingou/orgs","repos_url":"https://api.github.com/users/pypingou/repos","events_url":"https://api.github.com/users/pypingou/events{/privacy}","received_events_url":"https://api.github.com/users/pypingou/received_events","type":"User","site_admin":false},"body":"Well, we actually do support delta being ``None``, in that case the CSRF life-time is linked to the session life-time.","created_at":"2016-12-09T09:23:15Z","updated_at":"2016-12-09T09:23:15Z","html_url":"https://github.com/fedora-infra/nuancier/pull/105#discussion_r91681690","pull_request_url":"https://api.github.com/repos/fedora-infra/nuancier/pulls/105","_links":{"self":{"href":"https://api.github.com/repos/fedora-infra/nuancier/pulls/comments/91681690"},"html":{"href":"https://github.com/fedora-infra/nuancier/pull/105#discussion_r91681690"},"pull_request":{"href":"https://api.github.com/repos/fedora-infra/nuancier/pulls/105"}}},"pull_request":{"url":"https://api.github.com/repos/fedora-infra/nuancier/pulls/105","id":96936180,"html_url":"https://github.com/fedora-infra/nuancier/pull/105","diff_url":"https://github.com/fedora-infra/nuancier/pull/105.diff","patch_url":"https://github.com/fedora-infra/nuancier/pull/105.patch","issue_url":"https://api.github.com/repos/fedora-infra/nuancier/issues/105","number":105,"state":"open","locked":false,"title":"Make the CSRF token timeout configurable","user":{"login":"jeremycline","id":1977525,"avatar_url":"https://avatars.githubusercontent.com/u/1977525?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremycline","html_url":"https://github.com/jeremycline","followers_url":"https://api.github.com/users/jeremycline/followers","following_url":"https://api.github.com/users/jeremycline/following{/other_user}","gists_url":"https://api.github.com/users/jeremycline/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremycline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremycline/subscriptions","organizations_url":"https://api.github.com/users/jeremycline/orgs","repos_url":"https://api.github.com/users/jeremycline/repos","events_url":"https://api.github.com/users/jeremycline/events{/privacy}","received_events_url":"https://api.github.com/users/jeremycline/received_events","type":"User","site_admin":false},"body":"Previously, the ``WTF_CSRF_TIME_LIMIT`` setting was not in the default\r\nconfiguration, nor was it documented. It also only worked in\r\nflask-wtf-0.10.1+, which is not available in EPEL7. This makes it both\r\nwork in EPEL7's version (0.8) and documents the setting.\r\n\r\nfixes #78\r\n\r\nSigned-off-by: Jeremy Cline <jeremy@jcline.org>","created_at":"2016-12-07T14:43:43Z","updated_at":"2016-12-09T09:23:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49fb5d1988b788855082eb90a0c22433a35660eb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/fedora-infra/nuancier/pulls/105/commits","review_comments_url":"https://api.github.com/repos/fedora-infra/nuancier/pulls/105/comments","review_comment_url":"https://api.github.com/repos/fedora-infra/nuancier/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fedora-infra/nuancier/issues/105/comments","statuses_url":"https://api.github.com/repos/fedora-infra/nuancier/statuses/76d8ec990e971c929265f1f0c77c8363693a948c","head":{"label":"jeremycline:fix-csrf-timeout","ref":"fix-csrf-timeout","sha":"76d8ec990e971c929265f1f0c77c8363693a948c","user":{"login":"jeremycline","id":1977525,"avatar_url":"https://avatars.githubusercontent.com/u/1977525?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremycline","html_url":"https://github.com/jeremycline","followers_url":"https://api.github.com/users/jeremycline/followers","following_url":"https://api.github.com/users/jeremycline/following{/other_user}","gists_url":"https://api.github.com/users/jeremycline/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremycline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremycline/subscriptions","organizations_url":"https://api.github.com/users/jeremycline/orgs","repos_url":"https://api.github.com/users/jeremycline/repos","events_url":"https://api.github.com/users/jeremycline/events{/privacy}","received_events_url":"https://api.github.com/users/jeremycline/received_events","type":"User","site_admin":false},"repo":{"id":75418164,"name":"nuancier","full_name":"jeremycline/nuancier","owner":{"login":"jeremycline","id":1977525,"avatar_url":"https://avatars.githubusercontent.com/u/1977525?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremycline","html_url":"https://github.com/jeremycline","followers_url":"https://api.github.com/users/jeremycline/followers","following_url":"https://api.github.com/users/jeremycline/following{/other_user}","gists_url":"https://api.github.com/users/jeremycline/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremycline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremycline/subscriptions","organizations_url":"https://api.github.com/users/jeremycline/orgs","repos_url":"https://api.github.com/users/jeremycline/repos","events_url":"https://api.github.com/users/jeremycline/events{/privacy}","received_events_url":"https://api.github.com/users/jeremycline/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeremycline/nuancier","description":"A light web application for voting on supplementary wallpapers of Fedora","fork":true,"url":"https://api.github.com/repos/jeremycline/nuancier","forks_url":"https://api.github.com/repos/jeremycline/nuancier/forks","keys_url":"https://api.github.com/repos/jeremycline/nuancier/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeremycline/nuancier/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeremycline/nuancier/teams","hooks_url":"https://api.github.com/repos/jeremycline/nuancier/hooks","issue_events_url":"https://api.github.com/repos/jeremycline/nuancier/issues/events{/number}","events_url":"https://api.github.com/repos/jeremycline/nuancier/events","assignees_url":"https://api.github.com/repos/jeremycline/nuancier/assignees{/user}","branches_url":"https://api.github.com/repos/jeremycline/nuancier/branches{/branch}","tags_url":"https://api.github.com/repos/jeremycline/nuancier/tags","blobs_url":"https://api.github.com/repos/jeremycline/nuancier/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeremycline/nuancier/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeremycline/nuancier/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeremycline/nuancier/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeremycline/nuancier/statuses/{sha}","languages_url":"https://api.github.com/repos/jeremycline/nuancier/languages","stargazers_url":"https://api.github.com/repos/jeremycline/nuancier/stargazers","contributors_url":"https://api.github.com/repos/jeremycline/nuancier/contributors","subscribers_url":"https://api.github.com/repos/jeremycline/nuancier/subscribers","subscription_url":"https://api.github.com/repos/jeremycline/nuancier/subscription","commits_url":"https://api.github.com/repos/jeremycline/nuancier/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeremycline/nuancier/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeremycline/nuancier/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeremycline/nuancier/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeremycline/nuancier/contents/{+path}","compare_url":"https://api.github.com/repos/jeremycline/nuancier/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeremycline/nuancier/merges","archive_url":"https://api.github.com/repos/jeremycline/nuancier/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeremycline/nuancier/downloads","issues_url":"https://api.github.com/repos/jeremycline/nuancier/issues{/number}","pulls_url":"https://api.github.com/repos/jeremycline/nuancier/pulls{/number}","milestones_url":"https://api.github.com/repos/jeremycline/nuancier/milestones{/number}","notifications_url":"https://api.github.com/repos/jeremycline/nuancier/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeremycline/nuancier/labels{/name}","releases_url":"https://api.github.com/repos/jeremycline/nuancier/releases{/id}","deployments_url":"https://api.github.com/repos/jeremycline/nuancier/deployments","created_at":"2016-12-02T17:51:02Z","updated_at":"2016-12-02T17:51:03Z","pushed_at":"2016-12-07T15:21:01Z","git_url":"git://github.com/jeremycline/nuancier.git","ssh_url":"git@github.com:jeremycline/nuancier.git","clone_url":"https://github.com/jeremycline/nuancier.git","svn_url":"https://github.com/jeremycline/nuancier","homepage":null,"size":36250,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fedora-infra:master","ref":"master","sha":"25ad8d50804a503195f0b8b685aa5486e62c3f81","user":{"login":"fedora-infra","id":3316637,"avatar_url":"https://avatars.githubusercontent.com/u/3316637?v=3","gravatar_id":"","url":"https://api.github.com/users/fedora-infra","html_url":"https://github.com/fedora-infra","followers_url":"https://api.github.com/users/fedora-infra/followers","following_url":"https://api.github.com/users/fedora-infra/following{/other_user}","gists_url":"https://api.github.com/users/fedora-infra/gists{/gist_id}","starred_url":"https://api.github.com/users/fedora-infra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fedora-infra/subscriptions","organizations_url":"https://api.github.com/users/fedora-infra/orgs","repos_url":"https://api.github.com/users/fedora-infra/repos","events_url":"https://api.github.com/users/fedora-infra/events{/privacy}","received_events_url":"https://api.github.com/users/fedora-infra/received_events","type":"Organization","site_admin":false},"repo":{"id":12565539,"name":"nuancier","full_name":"fedora-infra/nuancier","owner":{"login":"fedora-infra","id":3316637,"avatar_url":"https://avatars.githubusercontent.com/u/3316637?v=3","gravatar_id":"","url":"https://api.github.com/users/fedora-infra","html_url":"https://github.com/fedora-infra","followers_url":"https://api.github.com/users/fedora-infra/followers","following_url":"https://api.github.com/users/fedora-infra/following{/other_user}","gists_url":"https://api.github.com/users/fedora-infra/gists{/gist_id}","starred_url":"https://api.github.com/users/fedora-infra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fedora-infra/subscriptions","organizations_url":"https://api.github.com/users/fedora-infra/orgs","repos_url":"https://api.github.com/users/fedora-infra/repos","events_url":"https://api.github.com/users/fedora-infra/events{/privacy}","received_events_url":"https://api.github.com/users/fedora-infra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fedora-infra/nuancier","description":"A light web application for voting on supplementary wallpapers of Fedora","fork":false,"url":"https://api.github.com/repos/fedora-infra/nuancier","forks_url":"https://api.github.com/repos/fedora-infra/nuancier/forks","keys_url":"https://api.github.com/repos/fedora-infra/nuancier/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fedora-infra/nuancier/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fedora-infra/nuancier/teams","hooks_url":"https://api.github.com/repos/fedora-infra/nuancier/hooks","issue_events_url":"https://api.github.com/repos/fedora-infra/nuancier/issues/events{/number}","events_url":"https://api.github.com/repos/fedora-infra/nuancier/events","assignees_url":"https://api.github.com/repos/fedora-infra/nuancier/assignees{/user}","branches_url":"https://api.github.com/repos/fedora-infra/nuancier/branches{/branch}","tags_url":"https://api.github.com/repos/fedora-infra/nuancier/tags","blobs_url":"https://api.github.com/repos/fedora-infra/nuancier/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fedora-infra/nuancier/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fedora-infra/nuancier/git/refs{/sha}","trees_url":"https://api.github.com/repos/fedora-infra/nuancier/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fedora-infra/nuancier/statuses/{sha}","languages_url":"https://api.github.com/repos/fedora-infra/nuancier/languages","stargazers_url":"https://api.github.com/repos/fedora-infra/nuancier/stargazers","contributors_url":"https://api.github.com/repos/fedora-infra/nuancier/contributors","subscribers_url":"https://api.github.com/repos/fedora-infra/nuancier/subscribers","subscription_url":"https://api.github.com/repos/fedora-infra/nuancier/subscription","commits_url":"https://api.github.com/repos/fedora-infra/nuancier/commits{/sha}","git_commits_url":"https://api.github.com/repos/fedora-infra/nuancier/git/commits{/sha}","comments_url":"https://api.github.com/repos/fedora-infra/nuancier/comments{/number}","issue_comment_url":"https://api.github.com/repos/fedora-infra/nuancier/issues/comments{/number}","contents_url":"https://api.github.com/repos/fedora-infra/nuancier/contents/{+path}","compare_url":"https://api.github.com/repos/fedora-infra/nuancier/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fedora-infra/nuancier/merges","archive_url":"https://api.github.com/repos/fedora-infra/nuancier/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fedora-infra/nuancier/downloads","issues_url":"https://api.github.com/repos/fedora-infra/nuancier/issues{/number}","pulls_url":"https://api.github.com/repos/fedora-infra/nuancier/pulls{/number}","milestones_url":"https://api.github.com/repos/fedora-infra/nuancier/milestones{/number}","notifications_url":"https://api.github.com/repos/fedora-infra/nuancier/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fedora-infra/nuancier/labels{/name}","releases_url":"https://api.github.com/repos/fedora-infra/nuancier/releases{/id}","deployments_url":"https://api.github.com/repos/fedora-infra/nuancier/deployments","created_at":"2013-09-03T14:11:25Z","updated_at":"2016-07-22T01:12:49Z","pushed_at":"2016-12-07T15:21:19Z","git_url":"git://github.com/fedora-infra/nuancier.git","ssh_url":"git@github.com:fedora-infra/nuancier.git","clone_url":"https://github.com/fedora-infra/nuancier.git","svn_url":"https://github.com/fedora-infra/nuancier","homepage":null,"size":36257,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":7,"forks":18,"open_issues":7,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fedora-infra/nuancier/pulls/105"},"html":{"href":"https://github.com/fedora-infra/nuancier/pull/105"},"issue":{"href":"https://api.github.com/repos/fedora-infra/nuancier/issues/105"},"comments":{"href":"https://api.github.com/repos/fedora-infra/nuancier/issues/105/comments"},"review_comments":{"href":"https://api.github.com/repos/fedora-infra/nuancier/pulls/105/comments"},"review_comment":{"href":"https://api.github.com/repos/fedora-infra/nuancier/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fedora-infra/nuancier/pulls/105/commits"},"statuses":{"href":"https://api.github.com/repos/fedora-infra/nuancier/statuses/76d8ec990e971c929265f1f0c77c8363693a948c"}}}}
{"actor":{"display_login":"pypingou"}}