{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/issues/1149","repository_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/issues/1149/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/issues/1149/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/issues/1149/events","html_url":"https://github.com/GoogleCloudPlatform/gcloud-java/pull/1149","id":170516841,"number":1149,"title":"Change pubsub endpoint from pubsub-experimental to pubsub","user":{"login":"mziccard","id":450933,"avatar_url":"https://avatars.githubusercontent.com/u/450933?v=3","gravatar_id":"","url":"https://api.github.com/users/mziccard","html_url":"https://github.com/mziccard","followers_url":"https://api.github.com/users/mziccard/followers","following_url":"https://api.github.com/users/mziccard/following{/other_user}","gists_url":"https://api.github.com/users/mziccard/gists{/gist_id}","starred_url":"https://api.github.com/users/mziccard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mziccard/subscriptions","organizations_url":"https://api.github.com/users/mziccard/orgs","repos_url":"https://api.github.com/users/mziccard/repos","events_url":"https://api.github.com/users/mziccard/events{/privacy}","received_events_url":"https://api.github.com/users/mziccard/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/labels/cla:%20yes","name":"cla: yes","color":"009800"},{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/labels/pubsub","name":"pubsub","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-08-10T20:56:27Z","updated_at":"2016-08-10T21:51:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/pulls/1149","html_url":"https://github.com/GoogleCloudPlatform/gcloud-java/pull/1149","diff_url":"https://github.com/GoogleCloudPlatform/gcloud-java/pull/1149.diff","patch_url":"https://github.com/GoogleCloudPlatform/gcloud-java/pull/1149.patch"},"body":"This change will be also made at the Veneer Toolkit level at next code-generation round. While we wait for that we go ahead and override the endpoint.\r\n\r\nFor reference: `pubsub-experimental.googleapis.com` stopped working today with the following error:\r\n\r\n> com.google.cloud.pubsub.PubSubException: io.grpc.StatusRuntimeException: PERMISSION_DENIED: Google Cloud Pub/Sub API (Experimental) has not been used in project google.com:gcloud-devel before or it is disabled. Enable it by visiting https://console.developers.google.com/apis/api/pubsub-experimental.googleapis.com/overview?project=gcloud-devel then retry. If you enabled this API recently, wait a few minutes for the action to propagate to our systems and retry.\r\n\r\nSee [this comment](https://github.com/GoogleCloudPlatform/gcloud-java/issues/381#issuecomment-239001059) and [this StackOverflow question](http://stackoverflow.com/questions/38860888/gloud-java-permission-denied-google-cloud-pub-sub-api-experimental)."},"comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/issues/comments/239015952","html_url":"https://github.com/GoogleCloudPlatform/gcloud-java/pull/1149#issuecomment-239015952","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/issues/1149","id":239015952,"user":{"login":"garrettjonesgoogle","id":13341017,"avatar_url":"https://avatars.githubusercontent.com/u/13341017?v=3","gravatar_id":"","url":"https://api.github.com/users/garrettjonesgoogle","html_url":"https://github.com/garrettjonesgoogle","followers_url":"https://api.github.com/users/garrettjonesgoogle/followers","following_url":"https://api.github.com/users/garrettjonesgoogle/following{/other_user}","gists_url":"https://api.github.com/users/garrettjonesgoogle/gists{/gist_id}","starred_url":"https://api.github.com/users/garrettjonesgoogle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garrettjonesgoogle/subscriptions","organizations_url":"https://api.github.com/users/garrettjonesgoogle/orgs","repos_url":"https://api.github.com/users/garrettjonesgoogle/repos","events_url":"https://api.github.com/users/garrettjonesgoogle/events{/privacy}","received_events_url":"https://api.github.com/users/garrettjonesgoogle/received_events","type":"User","site_admin":false},"created_at":"2016-08-10T21:51:08Z","updated_at":"2016-08-10T21:51:08Z","body":">> Why not just edit the line in PublisherSettings & SubscriberSettings with the default host? \r\n\r\n>This way we also support setting other hosts using the `host()` setter in the option builder (even though it should not be needed). And I wanted to avoid conflicts with the autogen code.\r\n\r\nOk it makes sense to plumb through the host from the options. But, my preference would be for PubSubOptions.DEFAULT_HOST to be set to PublisherSettings.DEFAULT_SERVICE_ADDRESS. \r\n\r\nIf you simply edit the DEFAULT_SERVICE_ADDRESS value e.g. at https://github.com/GoogleCloudPlatform/gcloud-java/blob/master/gcloud-java-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/PublisherSettings.java#L112 , then it should match what the generator will output in the next generation, and there won't be a conflict. \r\n\r\nThat said, it's not a strong opinion, and we can edit the veneer code when we generate next time.\r\n"}}
{"actor":{"display_login":"garrettjonesgoogle"}}