{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/osquery/issues/2499","repository_url":"https://api.github.com/repos/facebook/osquery","labels_url":"https://api.github.com/repos/facebook/osquery/issues/2499/labels{/name}","comments_url":"https://api.github.com/repos/facebook/osquery/issues/2499/comments","events_url":"https://api.github.com/repos/facebook/osquery/issues/2499/events","html_url":"https://github.com/facebook/osquery/pull/2499","id":178459040,"number":2499,"title":"[Fix #2483] Lock registry manipulation while setting active plugins","user":{"login":"theopolis","id":981645,"avatar_url":"https://avatars.githubusercontent.com/u/981645?v=3","gravatar_id":"","url":"https://api.github.com/users/theopolis","html_url":"https://github.com/theopolis","followers_url":"https://api.github.com/users/theopolis/followers","following_url":"https://api.github.com/users/theopolis/following{/other_user}","gists_url":"https://api.github.com/users/theopolis/gists{/gist_id}","starred_url":"https://api.github.com/users/theopolis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theopolis/subscriptions","organizations_url":"https://api.github.com/users/theopolis/orgs","repos_url":"https://api.github.com/users/theopolis/repos","events_url":"https://api.github.com/users/theopolis/events{/privacy}","received_events_url":"https://api.github.com/users/theopolis/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/osquery/labels/CLA%20Signed","name":"CLA Signed","color":"009900"},{"url":"https://api.github.com/repos/facebook/osquery/labels/dynamic%20analysis","name":"dynamic analysis","color":"d93f0b"},{"url":"https://api.github.com/repos/facebook/osquery/labels/extensions","name":"extensions","color":"207de5"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-21T20:51:00Z","updated_at":"2016-09-21T21:41:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/osquery/pulls/2499","html_url":"https://github.com/facebook/osquery/pull/2499","diff_url":"https://github.com/facebook/osquery/pull/2499.diff","patch_url":"https://github.com/facebook/osquery/pull/2499.patch"},"body":"I'm hesitant to consider #2483 a true positive. However, this lock does not introduce circular locking and seems reasonable.\r\n\r\nThe high-level case:\r\n1. Config Extension starts, responds to `ping`, is assigned a `uuid` and the `Initializer` flow continues.\r\n2. (race) The extension dies and is deregistered immediately. \r\n3. (race) `Initializer` attempts to `setUp` and `setActive` the config plugin.\r\n"},"comment":{"url":"https://api.github.com/repos/facebook/osquery/issues/comments/248751427","html_url":"https://github.com/facebook/osquery/pull/2499#issuecomment-248751427","issue_url":"https://api.github.com/repos/facebook/osquery/issues/2499","id":248751427,"user":{"login":"osqueryer","id":9722826,"avatar_url":"https://avatars.githubusercontent.com/u/9722826?v=3","gravatar_id":"","url":"https://api.github.com/users/osqueryer","html_url":"https://github.com/osqueryer","followers_url":"https://api.github.com/users/osqueryer/followers","following_url":"https://api.github.com/users/osqueryer/following{/other_user}","gists_url":"https://api.github.com/users/osqueryer/gists{/gist_id}","starred_url":"https://api.github.com/users/osqueryer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osqueryer/subscriptions","organizations_url":"https://api.github.com/users/osqueryer/orgs","repos_url":"https://api.github.com/users/osqueryer/repos","events_url":"https://api.github.com/users/osqueryer/events{/privacy}","received_events_url":"https://api.github.com/users/osqueryer/received_events","type":"User","site_admin":false},"created_at":"2016-09-21T21:41:02Z","updated_at":"2016-09-21T21:41:02Z","body":":-1: The commit eb13320dc3425fd2ab3e95963d7661afb041e153 (Job results: [3302](https://jenkins.osquery.io/job/osqueryPullRequestBuild/3302/)) failed one or more tests (**OS X/Linux**).\n"}}
{"actor":{"display_login":"osqueryer"}}