{"action":"created","comment":{"url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/pulls/comments/86422758","pull_request_review_id":7083665,"id":86422758,"diff_hunk":"@@ -163,24 +163,18 @@ def __init__(self, url):\n         self.allowed_oembed_types = {\"video\", \"rich\", \"link\", \"photo\"}\n         self.oembed_params[\"key\"] = g.embedly_api_key\n \n+    def fetch_media(self):","path":"reddit_liveupdate/media_embeds.py","position":4,"original_position":4,"commit_id":"bacb82fb087283a685dc8526dcab6d76d43cc8e3","original_commit_id":"b07a19ec0c4caf0a567836f21436dff7b853e9ac","user":{"login":"bsimpson63","id":833317,"avatar_url":"https://avatars.githubusercontent.com/u/833317?v=3","gravatar_id":"","url":"https://api.github.com/users/bsimpson63","html_url":"https://github.com/bsimpson63","followers_url":"https://api.github.com/users/bsimpson63/followers","following_url":"https://api.github.com/users/bsimpson63/following{/other_user}","gists_url":"https://api.github.com/users/bsimpson63/gists{/gist_id}","starred_url":"https://api.github.com/users/bsimpson63/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsimpson63/subscriptions","organizations_url":"https://api.github.com/users/bsimpson63/orgs","repos_url":"https://api.github.com/users/bsimpson63/repos","events_url":"https://api.github.com/users/bsimpson63/events{/privacy}","received_events_url":"https://api.github.com/users/bsimpson63/received_events","type":"User","site_admin":false},"body":"Do you need to make this a noop? You're already overriding the only caller `scrape()`.","created_at":"2016-11-03T19:19:54Z","updated_at":"2016-11-03T19:19:54Z","html_url":"https://github.com/reddit/reddit-plugin-liveupdate/pull/144#discussion_r86422758","pull_request_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/pulls/144","_links":{"self":{"href":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/pulls/comments/86422758"},"html":{"href":"https://github.com/reddit/reddit-plugin-liveupdate/pull/144#discussion_r86422758"},"pull_request":{"href":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/pulls/144"}}},"pull_request":{"url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/pulls/144","id":92079846,"html_url":"https://github.com/reddit/reddit-plugin-liveupdate/pull/144","diff_url":"https://github.com/reddit/reddit-plugin-liveupdate/pull/144.diff","patch_url":"https://github.com/reddit/reddit-plugin-liveupdate/pull/144.patch","issue_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/issues/144","number":144,"state":"open","locked":false,"title":"Make mobile scraping simpler","user":{"login":"dkasper","id":139474,"avatar_url":"https://avatars.githubusercontent.com/u/139474?v=3","gravatar_id":"","url":"https://api.github.com/users/dkasper","html_url":"https://github.com/dkasper","followers_url":"https://api.github.com/users/dkasper/followers","following_url":"https://api.github.com/users/dkasper/following{/other_user}","gists_url":"https://api.github.com/users/dkasper/gists{/gist_id}","starred_url":"https://api.github.com/users/dkasper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkasper/subscriptions","organizations_url":"https://api.github.com/users/dkasper/orgs","repos_url":"https://api.github.com/users/dkasper/repos","events_url":"https://api.github.com/users/dkasper/events{/privacy}","received_events_url":"https://api.github.com/users/dkasper/received_events","type":"User","site_admin":false},"body":"The purpose of this is to fix scraping of oembed data for urls such as http://www.northwestprintwear.com/WildLifeImprints/kids/large/KDELG.jpg. Embedly doesn't return a thumbnail for these which makes the superclass ignore them, so I simplified the logic to just always return the oembed whether there is a thumbnail or not in the mobile scraping class.","created_at":"2016-11-03T00:16:54Z","updated_at":"2016-11-03T19:19:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"abdad2866787f245c055f929d970c35837f1b466","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/pulls/144/commits","review_comments_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/pulls/144/comments","review_comment_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/issues/144/comments","statuses_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/statuses/bacb82fb087283a685dc8526dcab6d76d43cc8e3","head":{"label":"dkasper:make-scraping-simpler","ref":"make-scraping-simpler","sha":"bacb82fb087283a685dc8526dcab6d76d43cc8e3","user":{"login":"dkasper","id":139474,"avatar_url":"https://avatars.githubusercontent.com/u/139474?v=3","gravatar_id":"","url":"https://api.github.com/users/dkasper","html_url":"https://github.com/dkasper","followers_url":"https://api.github.com/users/dkasper/followers","following_url":"https://api.github.com/users/dkasper/following{/other_user}","gists_url":"https://api.github.com/users/dkasper/gists{/gist_id}","starred_url":"https://api.github.com/users/dkasper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkasper/subscriptions","organizations_url":"https://api.github.com/users/dkasper/orgs","repos_url":"https://api.github.com/users/dkasper/repos","events_url":"https://api.github.com/users/dkasper/events{/privacy}","received_events_url":"https://api.github.com/users/dkasper/received_events","type":"User","site_admin":false},"repo":{"id":69993577,"name":"reddit-plugin-liveupdate","full_name":"dkasper/reddit-plugin-liveupdate","owner":{"login":"dkasper","id":139474,"avatar_url":"https://avatars.githubusercontent.com/u/139474?v=3","gravatar_id":"","url":"https://api.github.com/users/dkasper","html_url":"https://github.com/dkasper","followers_url":"https://api.github.com/users/dkasper/followers","following_url":"https://api.github.com/users/dkasper/following{/other_user}","gists_url":"https://api.github.com/users/dkasper/gists{/gist_id}","starred_url":"https://api.github.com/users/dkasper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkasper/subscriptions","organizations_url":"https://api.github.com/users/dkasper/orgs","repos_url":"https://api.github.com/users/dkasper/repos","events_url":"https://api.github.com/users/dkasper/events{/privacy}","received_events_url":"https://api.github.com/users/dkasper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dkasper/reddit-plugin-liveupdate","description":"the code behind reddit live","fork":true,"url":"https://api.github.com/repos/dkasper/reddit-plugin-liveupdate","forks_url":"https://api.github.com/repos/dkasper/reddit-plugin-liveupdate/forks","keys_url":"https://api.github.com/repos/dkasper/reddit-plugin-liveupdate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dkasper/reddit-plugin-liveupdate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dkasper/reddit-plugin-liveupdate/teams","hooks_url":"https://api.github.com/repos/dkasper/reddit-plugin-liveupdate/hooks","issue_events_url":"https://api.github.com/repos/dkasper/reddit-plugin-liveupdate/issues/events{/number}","events_url":"https://api.github.com/repos/dkasper/reddit-plugin-liveupdate/events","assignees_url":"https://api.github.com/repos/dkasper/reddit-plugin-liveupdate/assignees{/user}","branches_url":"https://api.github.com/repos/dkasper/reddit-plugin-liveupdate/branches{/branch}","tags_url":"https://api.github.com/repos/dkasper/reddit-plugin-liveupdate/tags","blobs_url":"https://api.github.com/repos/dkasper/reddit-plugin-liveupdate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dkasper/reddit-plugin-liveupdate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dkasper/reddit-plugin-liveupdate/git/refs{/sha}","trees_url":"https://api.github.com/repos/dkasper/reddit-plugin-liveupdate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dkasper/reddit-plugin-liveupdate/statuses/{sha}","languages_url":"https://api.github.com/repos/dkasper/reddit-plugin-liveupdate/languages","stargazers_url":"https://api.github.com/repos/dkasper/reddit-plugin-liveupdate/stargazers","contributors_url":"https://api.github.com/repos/dkasper/reddit-plugin-liveupdate/contributors","subscribers_url":"https://api.github.com/repos/dkasper/reddit-plugin-liveupdate/subscribers","subscription_url":"https://api.github.com/repos/dkasper/reddit-plugin-liveupdate/subscription","commits_url":"https://api.github.com/repos/dkasper/reddit-plugin-liveupdate/commits{/sha}","git_commits_url":"https://api.github.com/repos/dkasper/reddit-plugin-liveupdate/git/commits{/sha}","comments_url":"https://api.github.com/repos/dkasper/reddit-plugin-liveupdate/comments{/number}","issue_comment_url":"https://api.github.com/repos/dkasper/reddit-plugin-liveupdate/issues/comments{/number}","contents_url":"https://api.github.com/repos/dkasper/reddit-plugin-liveupdate/contents/{+path}","compare_url":"https://api.github.com/repos/dkasper/reddit-plugin-liveupdate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dkasper/reddit-plugin-liveupdate/merges","archive_url":"https://api.github.com/repos/dkasper/reddit-plugin-liveupdate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dkasper/reddit-plugin-liveupdate/downloads","issues_url":"https://api.github.com/repos/dkasper/reddit-plugin-liveupdate/issues{/number}","pulls_url":"https://api.github.com/repos/dkasper/reddit-plugin-liveupdate/pulls{/number}","milestones_url":"https://api.github.com/repos/dkasper/reddit-plugin-liveupdate/milestones{/number}","notifications_url":"https://api.github.com/repos/dkasper/reddit-plugin-liveupdate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dkasper/reddit-plugin-liveupdate/labels{/name}","releases_url":"https://api.github.com/repos/dkasper/reddit-plugin-liveupdate/releases{/id}","deployments_url":"https://api.github.com/repos/dkasper/reddit-plugin-liveupdate/deployments","created_at":"2016-10-04T18:24:14Z","updated_at":"2016-10-04T18:24:16Z","pushed_at":"2016-11-03T00:16:31Z","git_url":"git://github.com/dkasper/reddit-plugin-liveupdate.git","ssh_url":"git@github.com:dkasper/reddit-plugin-liveupdate.git","clone_url":"https://github.com/dkasper/reddit-plugin-liveupdate.git","svn_url":"https://github.com/dkasper/reddit-plugin-liveupdate","homepage":"https://www.reddit.com/live","size":559,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"reddit:master","ref":"master","sha":"89ed0fd53eb17825666c8272c564c415e8b1b1f1","user":{"login":"reddit","id":14248,"avatar_url":"https://avatars.githubusercontent.com/u/14248?v=3","gravatar_id":"","url":"https://api.github.com/users/reddit","html_url":"https://github.com/reddit","followers_url":"https://api.github.com/users/reddit/followers","following_url":"https://api.github.com/users/reddit/following{/other_user}","gists_url":"https://api.github.com/users/reddit/gists{/gist_id}","starred_url":"https://api.github.com/users/reddit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddit/subscriptions","organizations_url":"https://api.github.com/users/reddit/orgs","repos_url":"https://api.github.com/users/reddit/repos","events_url":"https://api.github.com/users/reddit/events{/privacy}","received_events_url":"https://api.github.com/users/reddit/received_events","type":"Organization","site_admin":false},"repo":{"id":10514101,"name":"reddit-plugin-liveupdate","full_name":"reddit/reddit-plugin-liveupdate","owner":{"login":"reddit","id":14248,"avatar_url":"https://avatars.githubusercontent.com/u/14248?v=3","gravatar_id":"","url":"https://api.github.com/users/reddit","html_url":"https://github.com/reddit","followers_url":"https://api.github.com/users/reddit/followers","following_url":"https://api.github.com/users/reddit/following{/other_user}","gists_url":"https://api.github.com/users/reddit/gists{/gist_id}","starred_url":"https://api.github.com/users/reddit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddit/subscriptions","organizations_url":"https://api.github.com/users/reddit/orgs","repos_url":"https://api.github.com/users/reddit/repos","events_url":"https://api.github.com/users/reddit/events{/privacy}","received_events_url":"https://api.github.com/users/reddit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reddit/reddit-plugin-liveupdate","description":"the code behind reddit live","fork":false,"url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate","forks_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/forks","keys_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/teams","hooks_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/hooks","issue_events_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/issues/events{/number}","events_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/events","assignees_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/assignees{/user}","branches_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/branches{/branch}","tags_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/tags","blobs_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/git/refs{/sha}","trees_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/statuses/{sha}","languages_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/languages","stargazers_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/stargazers","contributors_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/contributors","subscribers_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/subscribers","subscription_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/subscription","commits_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/commits{/sha}","git_commits_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/git/commits{/sha}","comments_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/comments{/number}","issue_comment_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/issues/comments{/number}","contents_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/contents/{+path}","compare_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/merges","archive_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/downloads","issues_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/issues{/number}","pulls_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/pulls{/number}","milestones_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/milestones{/number}","notifications_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/labels{/name}","releases_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/releases{/id}","deployments_url":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/deployments","created_at":"2013-06-05T22:26:13Z","updated_at":"2016-10-25T21:26:56Z","pushed_at":"2016-11-03T00:16:55Z","git_url":"git://github.com/reddit/reddit-plugin-liveupdate.git","ssh_url":"git@github.com:reddit/reddit-plugin-liveupdate.git","clone_url":"https://github.com/reddit/reddit-plugin-liveupdate.git","svn_url":"https://github.com/reddit/reddit-plugin-liveupdate","homepage":"https://www.reddit.com/live","size":723,"stargazers_count":30,"watchers_count":30,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":10,"forks":41,"open_issues":10,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/pulls/144"},"html":{"href":"https://github.com/reddit/reddit-plugin-liveupdate/pull/144"},"issue":{"href":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/issues/144"},"comments":{"href":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/issues/144/comments"},"review_comments":{"href":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/pulls/144/comments"},"review_comment":{"href":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/pulls/144/commits"},"statuses":{"href":"https://api.github.com/repos/reddit/reddit-plugin-liveupdate/statuses/bacb82fb087283a685dc8526dcab6d76d43cc8e3"}}}}
{"actor":{"display_login":"bsimpson63"}}