{"action":"created","comment":{"url":"https://api.github.com/repos/BlueBrain/Livre/pulls/comments/53609871","id":53609871,"diff_hunk":"@@ -189,7 +187,7 @@ typedef std::vector< RenderBrickPtr > RenderBricks;\n  * Map definitions\n  */\n typedef boost::unordered_map< NodeId, dash::NodePtr > NodeIDDashNodePtrMap;\n-typedef boost::unordered_map< CacheId, CacheObjectPtr > CacheMap;\n+typedef boost::unordered_map< CacheId, CacheObject* > CacheMap;","path":"livre/core/types.h","position":41,"original_position":41,"commit_id":"e1cae63049cd2bcfe3b0e1a674d9bb62bfd4f95a","original_commit_id":"e1cae63049cd2bcfe3b0e1a674d9bb62bfd4f95a","user":{"login":"bilgili","id":1157568,"avatar_url":"https://avatars.githubusercontent.com/u/1157568?v=3","gravatar_id":"","url":"https://api.github.com/users/bilgili","html_url":"https://github.com/bilgili","followers_url":"https://api.github.com/users/bilgili/followers","following_url":"https://api.github.com/users/bilgili/following{/other_user}","gists_url":"https://api.github.com/users/bilgili/gists{/gist_id}","starred_url":"https://api.github.com/users/bilgili/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bilgili/subscriptions","organizations_url":"https://api.github.com/users/bilgili/orgs","repos_url":"https://api.github.com/users/bilgili/repos","events_url":"https://api.github.com/users/bilgili/events{/privacy}","received_events_url":"https://api.github.com/users/bilgili/received_events","type":"User","site_admin":false},"body":"Fishyness above ?","created_at":"2016-02-22T10:52:29Z","updated_at":"2016-02-22T10:52:29Z","html_url":"https://github.com/BlueBrain/Livre/pull/251#discussion_r53609871","pull_request_url":"https://api.github.com/repos/BlueBrain/Livre/pulls/251","_links":{"self":{"href":"https://api.github.com/repos/BlueBrain/Livre/pulls/comments/53609871"},"html":{"href":"https://github.com/BlueBrain/Livre/pull/251#discussion_r53609871"},"pull_request":{"href":"https://api.github.com/repos/BlueBrain/Livre/pulls/251"}}},"pull_request":{"url":"https://api.github.com/repos/BlueBrain/Livre/pulls/251","id":59649346,"html_url":"https://github.com/BlueBrain/Livre/pull/251","diff_url":"https://github.com/BlueBrain/Livre/pull/251.diff","patch_url":"https://github.com/BlueBrain/Livre/pull/251.patch","issue_url":"https://api.github.com/repos/BlueBrain/Livre/issues/251","number":251,"state":"open","locked":false,"title":"Cache sharedptr","user":{"login":"bilgili","id":1157568,"avatar_url":"https://avatars.githubusercontent.com/u/1157568?v=3","gravatar_id":"","url":"https://api.github.com/users/bilgili","html_url":"https://github.com/bilgili","followers_url":"https://api.github.com/users/bilgili/followers","following_url":"https://api.github.com/users/bilgili/following{/other_user}","gists_url":"https://api.github.com/users/bilgili/gists{/gist_id}","starred_url":"https://api.github.com/users/bilgili/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bilgili/subscriptions","organizations_url":"https://api.github.com/users/bilgili/orgs","repos_url":"https://api.github.com/users/bilgili/repos","events_url":"https://api.github.com/users/bilgili/events{/privacy}","received_events_url":"https://api.github.com/users/bilgili/received_events","type":"User","site_admin":false},"body":"FYI @eile Simplified cache","created_at":"2016-02-17T14:16:36Z","updated_at":"2016-02-22T10:52:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"546ac7acd075da7acdb663176ac94d4cfc79e7dd","assignee":{"login":"eile","id":354947,"avatar_url":"https://avatars.githubusercontent.com/u/354947?v=3","gravatar_id":"","url":"https://api.github.com/users/eile","html_url":"https://github.com/eile","followers_url":"https://api.github.com/users/eile/followers","following_url":"https://api.github.com/users/eile/following{/other_user}","gists_url":"https://api.github.com/users/eile/gists{/gist_id}","starred_url":"https://api.github.com/users/eile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eile/subscriptions","organizations_url":"https://api.github.com/users/eile/orgs","repos_url":"https://api.github.com/users/eile/repos","events_url":"https://api.github.com/users/eile/events{/privacy}","received_events_url":"https://api.github.com/users/eile/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/BlueBrain/Livre/pulls/251/commits","review_comments_url":"https://api.github.com/repos/BlueBrain/Livre/pulls/251/comments","review_comment_url":"https://api.github.com/repos/BlueBrain/Livre/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BlueBrain/Livre/issues/251/comments","statuses_url":"https://api.github.com/repos/BlueBrain/Livre/statuses/e1cae63049cd2bcfe3b0e1a674d9bb62bfd4f95a","head":{"label":"bilgili:cache_sharedptr","ref":"cache_sharedptr","sha":"e1cae63049cd2bcfe3b0e1a674d9bb62bfd4f95a","user":{"login":"bilgili","id":1157568,"avatar_url":"https://avatars.githubusercontent.com/u/1157568?v=3","gravatar_id":"","url":"https://api.github.com/users/bilgili","html_url":"https://github.com/bilgili","followers_url":"https://api.github.com/users/bilgili/followers","following_url":"https://api.github.com/users/bilgili/following{/other_user}","gists_url":"https://api.github.com/users/bilgili/gists{/gist_id}","starred_url":"https://api.github.com/users/bilgili/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bilgili/subscriptions","organizations_url":"https://api.github.com/users/bilgili/orgs","repos_url":"https://api.github.com/users/bilgili/repos","events_url":"https://api.github.com/users/bilgili/events{/privacy}","received_events_url":"https://api.github.com/users/bilgili/received_events","type":"User","site_admin":false},"repo":{"id":34505794,"name":"Livre","full_name":"bilgili/Livre","owner":{"login":"bilgili","id":1157568,"avatar_url":"https://avatars.githubusercontent.com/u/1157568?v=3","gravatar_id":"","url":"https://api.github.com/users/bilgili","html_url":"https://github.com/bilgili","followers_url":"https://api.github.com/users/bilgili/followers","following_url":"https://api.github.com/users/bilgili/following{/other_user}","gists_url":"https://api.github.com/users/bilgili/gists{/gist_id}","starred_url":"https://api.github.com/users/bilgili/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bilgili/subscriptions","organizations_url":"https://api.github.com/users/bilgili/orgs","repos_url":"https://api.github.com/users/bilgili/repos","events_url":"https://api.github.com/users/bilgili/events{/privacy}","received_events_url":"https://api.github.com/users/bilgili/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bilgili/Livre","description":"Largescale Interactive Volume Rendering Engine","fork":true,"url":"https://api.github.com/repos/bilgili/Livre","forks_url":"https://api.github.com/repos/bilgili/Livre/forks","keys_url":"https://api.github.com/repos/bilgili/Livre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bilgili/Livre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bilgili/Livre/teams","hooks_url":"https://api.github.com/repos/bilgili/Livre/hooks","issue_events_url":"https://api.github.com/repos/bilgili/Livre/issues/events{/number}","events_url":"https://api.github.com/repos/bilgili/Livre/events","assignees_url":"https://api.github.com/repos/bilgili/Livre/assignees{/user}","branches_url":"https://api.github.com/repos/bilgili/Livre/branches{/branch}","tags_url":"https://api.github.com/repos/bilgili/Livre/tags","blobs_url":"https://api.github.com/repos/bilgili/Livre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bilgili/Livre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bilgili/Livre/git/refs{/sha}","trees_url":"https://api.github.com/repos/bilgili/Livre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bilgili/Livre/statuses/{sha}","languages_url":"https://api.github.com/repos/bilgili/Livre/languages","stargazers_url":"https://api.github.com/repos/bilgili/Livre/stargazers","contributors_url":"https://api.github.com/repos/bilgili/Livre/contributors","subscribers_url":"https://api.github.com/repos/bilgili/Livre/subscribers","subscription_url":"https://api.github.com/repos/bilgili/Livre/subscription","commits_url":"https://api.github.com/repos/bilgili/Livre/commits{/sha}","git_commits_url":"https://api.github.com/repos/bilgili/Livre/git/commits{/sha}","comments_url":"https://api.github.com/repos/bilgili/Livre/comments{/number}","issue_comment_url":"https://api.github.com/repos/bilgili/Livre/issues/comments{/number}","contents_url":"https://api.github.com/repos/bilgili/Livre/contents/{+path}","compare_url":"https://api.github.com/repos/bilgili/Livre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bilgili/Livre/merges","archive_url":"https://api.github.com/repos/bilgili/Livre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bilgili/Livre/downloads","issues_url":"https://api.github.com/repos/bilgili/Livre/issues{/number}","pulls_url":"https://api.github.com/repos/bilgili/Livre/pulls{/number}","milestones_url":"https://api.github.com/repos/bilgili/Livre/milestones{/number}","notifications_url":"https://api.github.com/repos/bilgili/Livre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bilgili/Livre/labels{/name}","releases_url":"https://api.github.com/repos/bilgili/Livre/releases{/id}","deployments_url":"https://api.github.com/repos/bilgili/Livre/deployments","created_at":"2015-04-24T08:00:16Z","updated_at":"2015-05-04T13:03:11Z","pushed_at":"2016-02-19T10:58:12Z","git_url":"git://github.com/bilgili/Livre.git","ssh_url":"git@github.com:bilgili/Livre.git","clone_url":"https://github.com/bilgili/Livre.git","svn_url":"https://github.com/bilgili/Livre","homepage":"https://bluebrain.github.io","size":7980,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BlueBrain:master","ref":"master","sha":"b05a6c15927df8404b12937c0f274b3cd47af3d7","user":{"login":"BlueBrain","id":1479142,"avatar_url":"https://avatars.githubusercontent.com/u/1479142?v=3","gravatar_id":"","url":"https://api.github.com/users/BlueBrain","html_url":"https://github.com/BlueBrain","followers_url":"https://api.github.com/users/BlueBrain/followers","following_url":"https://api.github.com/users/BlueBrain/following{/other_user}","gists_url":"https://api.github.com/users/BlueBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/BlueBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlueBrain/subscriptions","organizations_url":"https://api.github.com/users/BlueBrain/orgs","repos_url":"https://api.github.com/users/BlueBrain/repos","events_url":"https://api.github.com/users/BlueBrain/events{/privacy}","received_events_url":"https://api.github.com/users/BlueBrain/received_events","type":"Organization","site_admin":false},"repo":{"id":10625435,"name":"Livre","full_name":"BlueBrain/Livre","owner":{"login":"BlueBrain","id":1479142,"avatar_url":"https://avatars.githubusercontent.com/u/1479142?v=3","gravatar_id":"","url":"https://api.github.com/users/BlueBrain","html_url":"https://github.com/BlueBrain","followers_url":"https://api.github.com/users/BlueBrain/followers","following_url":"https://api.github.com/users/BlueBrain/following{/other_user}","gists_url":"https://api.github.com/users/BlueBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/BlueBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlueBrain/subscriptions","organizations_url":"https://api.github.com/users/BlueBrain/orgs","repos_url":"https://api.github.com/users/BlueBrain/repos","events_url":"https://api.github.com/users/BlueBrain/events{/privacy}","received_events_url":"https://api.github.com/users/BlueBrain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BlueBrain/Livre","description":"Large-scale Interactive Volume Rendering Engine","fork":false,"url":"https://api.github.com/repos/BlueBrain/Livre","forks_url":"https://api.github.com/repos/BlueBrain/Livre/forks","keys_url":"https://api.github.com/repos/BlueBrain/Livre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BlueBrain/Livre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BlueBrain/Livre/teams","hooks_url":"https://api.github.com/repos/BlueBrain/Livre/hooks","issue_events_url":"https://api.github.com/repos/BlueBrain/Livre/issues/events{/number}","events_url":"https://api.github.com/repos/BlueBrain/Livre/events","assignees_url":"https://api.github.com/repos/BlueBrain/Livre/assignees{/user}","branches_url":"https://api.github.com/repos/BlueBrain/Livre/branches{/branch}","tags_url":"https://api.github.com/repos/BlueBrain/Livre/tags","blobs_url":"https://api.github.com/repos/BlueBrain/Livre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BlueBrain/Livre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BlueBrain/Livre/git/refs{/sha}","trees_url":"https://api.github.com/repos/BlueBrain/Livre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BlueBrain/Livre/statuses/{sha}","languages_url":"https://api.github.com/repos/BlueBrain/Livre/languages","stargazers_url":"https://api.github.com/repos/BlueBrain/Livre/stargazers","contributors_url":"https://api.github.com/repos/BlueBrain/Livre/contributors","subscribers_url":"https://api.github.com/repos/BlueBrain/Livre/subscribers","subscription_url":"https://api.github.com/repos/BlueBrain/Livre/subscription","commits_url":"https://api.github.com/repos/BlueBrain/Livre/commits{/sha}","git_commits_url":"https://api.github.com/repos/BlueBrain/Livre/git/commits{/sha}","comments_url":"https://api.github.com/repos/BlueBrain/Livre/comments{/number}","issue_comment_url":"https://api.github.com/repos/BlueBrain/Livre/issues/comments{/number}","contents_url":"https://api.github.com/repos/BlueBrain/Livre/contents/{+path}","compare_url":"https://api.github.com/repos/BlueBrain/Livre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BlueBrain/Livre/merges","archive_url":"https://api.github.com/repos/BlueBrain/Livre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BlueBrain/Livre/downloads","issues_url":"https://api.github.com/repos/BlueBrain/Livre/issues{/number}","pulls_url":"https://api.github.com/repos/BlueBrain/Livre/pulls{/number}","milestones_url":"https://api.github.com/repos/BlueBrain/Livre/milestones{/number}","notifications_url":"https://api.github.com/repos/BlueBrain/Livre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BlueBrain/Livre/labels{/name}","releases_url":"https://api.github.com/repos/BlueBrain/Livre/releases{/id}","deployments_url":"https://api.github.com/repos/BlueBrain/Livre/deployments","created_at":"2013-06-11T16:13:56Z","updated_at":"2016-02-04T10:44:08Z","pushed_at":"2016-02-22T08:47:27Z","git_url":"git://github.com/BlueBrain/Livre.git","ssh_url":"git@github.com:BlueBrain/Livre.git","clone_url":"https://github.com/BlueBrain/Livre.git","svn_url":"https://github.com/BlueBrain/Livre","homepage":"https://bluebrain.github.io","size":8067,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":22,"forks":14,"open_issues":22,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BlueBrain/Livre/pulls/251"},"html":{"href":"https://github.com/BlueBrain/Livre/pull/251"},"issue":{"href":"https://api.github.com/repos/BlueBrain/Livre/issues/251"},"comments":{"href":"https://api.github.com/repos/BlueBrain/Livre/issues/251/comments"},"review_comments":{"href":"https://api.github.com/repos/BlueBrain/Livre/pulls/251/comments"},"review_comment":{"href":"https://api.github.com/repos/BlueBrain/Livre/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BlueBrain/Livre/pulls/251/commits"},"statuses":{"href":"https://api.github.com/repos/BlueBrain/Livre/statuses/e1cae63049cd2bcfe3b0e1a674d9bb62bfd4f95a"}}}}