{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/core/issues/22646","repository_url":"https://api.github.com/repos/owncloud/core","labels_url":"https://api.github.com/repos/owncloud/core/issues/22646/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/core/issues/22646/comments","events_url":"https://api.github.com/repos/owncloud/core/issues/22646/events","html_url":"https://github.com/owncloud/core/pull/22646","id":136387970,"number":22646,"title":"Set default expiration date if none given on share creation","user":{"login":"rullzer","id":45821,"avatar_url":"https://avatars.githubusercontent.com/u/45821?v=3","gravatar_id":"","url":"https://api.github.com/users/rullzer","html_url":"https://github.com/rullzer","followers_url":"https://api.github.com/users/rullzer/followers","following_url":"https://api.github.com/users/rullzer/following{/other_user}","gists_url":"https://api.github.com/users/rullzer/gists{/gist_id}","starred_url":"https://api.github.com/users/rullzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rullzer/subscriptions","organizations_url":"https://api.github.com/users/rullzer/orgs","repos_url":"https://api.github.com/users/rullzer/repos","events_url":"https://api.github.com/users/rullzer/events{/privacy}","received_events_url":"https://api.github.com/users/rullzer/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/owncloud/core/labels/3%20-%20To%20Review","name":"3 - To Review","color":"ededed"},{"url":"https://api.github.com/repos/owncloud/core/labels/feature:sharing","name":"feature:sharing","color":"d4c5f9"},{"url":"https://api.github.com/repos/owncloud/core/labels/in%20progress","name":"in progress","color":"ededed"},{"url":"https://api.github.com/repos/owncloud/core/labels/sev2-high","name":"sev2-high","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/48","html_url":"https://github.com/owncloud/core/milestones/9.0-current","labels_url":"https://api.github.com/repos/owncloud/core/milestones/48/labels","id":1196845,"number":48,"title":"9.0-current","description":"","creator":{"login":"cmonteroluque","id":879976,"avatar_url":"https://avatars.githubusercontent.com/u/879976?v=3","gravatar_id":"","url":"https://api.github.com/users/cmonteroluque","html_url":"https://github.com/cmonteroluque","followers_url":"https://api.github.com/users/cmonteroluque/followers","following_url":"https://api.github.com/users/cmonteroluque/following{/other_user}","gists_url":"https://api.github.com/users/cmonteroluque/gists{/gist_id}","starred_url":"https://api.github.com/users/cmonteroluque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmonteroluque/subscriptions","organizations_url":"https://api.github.com/users/cmonteroluque/orgs","repos_url":"https://api.github.com/users/cmonteroluque/repos","events_url":"https://api.github.com/users/cmonteroluque/events{/privacy}","received_events_url":"https://api.github.com/users/cmonteroluque/received_events","type":"User","site_admin":false},"open_issues":90,"closed_issues":1691,"state":"open","created_at":"2015-07-07T14:21:23Z","updated_at":"2016-02-25T17:09:08Z","due_on":"2016-03-08T04:00:00Z","closed_at":null},"comments":4,"created_at":"2016-02-25T13:28:43Z","updated_at":"2016-02-25T17:14:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/22646","html_url":"https://github.com/owncloud/core/pull/22646","diff_url":"https://github.com/owncloud/core/pull/22646.diff","patch_url":"https://github.com/owncloud/core/pull/22646.patch"},"body":"When we create a share for the first time we should set the default\r\nexpiration date. If none is given.\r\n\r\nThis used to be the case. But I think I did it wrong when I reused it for updateShare as well.\r\n\r\nNow there is a unit test for this.\r\nFixes #22642\r\n\r\n@SergioBertolinSG is it possible to have intergration tests that test this part of the sharing API as well (so with the config stuff changing)?\r\n\r\n@javiergonzper please verify this fixes it.\r\n\r\nCC: @PVince81 @schiesbn @nickvergessen @MorrisJobke "},"comment":{"url":"https://api.github.com/repos/owncloud/core/issues/comments/188884014","html_url":"https://github.com/owncloud/core/pull/22646#issuecomment-188884014","issue_url":"https://api.github.com/repos/owncloud/core/issues/22646","id":188884014,"user":{"login":"PVince81","id":277525,"avatar_url":"https://avatars.githubusercontent.com/u/277525?v=3","gravatar_id":"","url":"https://api.github.com/users/PVince81","html_url":"https://github.com/PVince81","followers_url":"https://api.github.com/users/PVince81/followers","following_url":"https://api.github.com/users/PVince81/following{/other_user}","gists_url":"https://api.github.com/users/PVince81/gists{/gist_id}","starred_url":"https://api.github.com/users/PVince81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PVince81/subscriptions","organizations_url":"https://api.github.com/users/PVince81/orgs","repos_url":"https://api.github.com/users/PVince81/repos","events_url":"https://api.github.com/users/PVince81/events{/privacy}","received_events_url":"https://api.github.com/users/PVince81/received_events","type":"User","site_admin":false},"created_at":"2016-02-25T17:14:36Z","updated_at":"2016-02-25T17:14:36Z","body":"@xerc https://github.com/owncloud/core/pull/18651"}}