{"action":"created","issue":{"url":"https://api.github.com/repos/weaveworks/scope/issues/752","labels_url":"https://api.github.com/repos/weaveworks/scope/issues/752/labels{/name}","comments_url":"https://api.github.com/repos/weaveworks/scope/issues/752/comments","events_url":"https://api.github.com/repos/weaveworks/scope/issues/752/events","html_url":"https://github.com/weaveworks/scope/pull/752","id":121752259,"number":752,"title":"[WIP] Details panel redesign","user":{"login":"davkal","id":859729,"avatar_url":"https://avatars.githubusercontent.com/u/859729?v=3","gravatar_id":"","url":"https://api.github.com/users/davkal","html_url":"https://github.com/davkal","followers_url":"https://api.github.com/users/davkal/followers","following_url":"https://api.github.com/users/davkal/following{/other_user}","gists_url":"https://api.github.com/users/davkal/gists{/gist_id}","starred_url":"https://api.github.com/users/davkal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davkal/subscriptions","organizations_url":"https://api.github.com/users/davkal/orgs","repos_url":"https://api.github.com/users/davkal/repos","events_url":"https://api.github.com/users/davkal/events{/privacy}","received_events_url":"https://api.github.com/users/davkal/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":19,"created_at":"2015-12-11T17:10:08Z","updated_at":"2016-01-18T16:25:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/weaveworks/scope/pulls/752","html_url":"https://github.com/weaveworks/scope/pull/752","diff_url":"https://github.com/weaveworks/scope/pull/752.diff","patch_url":"https://github.com/weaveworks/scope/pull/752.patch"},"body":"This PR is to redesign the details panel that appears when clicking on a node.  Fixes #382, fixes #301.\r\n\r\n- [x] Links to relatives below main title\r\n- [x] Health section with big last value and sparklines\r\n- [x] Show-more option for grouped Health items\r\n- [x] Tables for child nodes with metrics\r\n- [x] Limit tables and lists to 5 entries with show more/less button\r\n- [x] make links work (need unified node IDs)\r\n- [x] sort table by metric\r\n- [x] try alternative transitions when showing new details after link click\r\n- [x] paul: fix ids so we can link between topologies (and get metrics/metadata reliably)\r\n- [x] paul: remove \"self\" from \"parents\" table\r\n- [x] ~~add connections summary section~~ (pushed to https://github.com/weaveworks/scope/issues/680)\r\n- [x] paul: clean up backend code\r\n- [x] paul: update backend tests\r\n- [x] don't link unconnected processes in child table\r\n- [x] try it with k8s\r\n- [x] fix container-host-container bug\r\n- [ ] stop containers with no image name displaying `<none>:<none>` as a parent (also containers with no name displaying as `<none>`)\r\n- [x] fix bug with containers (w/o an image, maybe?) showing up in hosts view\r\n\r\n![screen shot 2015-12-11 at 17 52 39](https://cloud.githubusercontent.com/assets/859729/11750198/64ba8e16-a032-11e5-98de-d389d938ed5f.png)\r\n"},"comment":{"url":"https://api.github.com/repos/weaveworks/scope/issues/comments/172576761","html_url":"https://github.com/weaveworks/scope/pull/752#issuecomment-172576761","issue_url":"https://api.github.com/repos/weaveworks/scope/issues/752","id":172576761,"user":{"login":"tomwilkie","id":444037,"avatar_url":"https://avatars.githubusercontent.com/u/444037?v=3","gravatar_id":"","url":"https://api.github.com/users/tomwilkie","html_url":"https://github.com/tomwilkie","followers_url":"https://api.github.com/users/tomwilkie/followers","following_url":"https://api.github.com/users/tomwilkie/following{/other_user}","gists_url":"https://api.github.com/users/tomwilkie/gists{/gist_id}","starred_url":"https://api.github.com/users/tomwilkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomwilkie/subscriptions","organizations_url":"https://api.github.com/users/tomwilkie/orgs","repos_url":"https://api.github.com/users/tomwilkie/repos","events_url":"https://api.github.com/users/tomwilkie/events{/privacy}","received_events_url":"https://api.github.com/users/tomwilkie/received_events","type":"User","site_admin":false},"created_at":"2016-01-18T16:25:52Z","updated_at":"2016-01-18T16:25:52Z","body":"> Could refactor it to a struct (instead of a fn), so the \"type\" goes at the end.\r\n\r\nRoger, please file a ticket against 0.13 and we'll do that then.\r\n\r\n> Started on this, but you have to change all the MakeNode and MakeNodeWiths, got about 726 lines in, and stashed it.\r\n\r\nDitto, we can fix in 0.13\r\n\r\n> I hypothesise that it may be this bug: #815\r\n\r\nOkay we need to fix this before the merge - I think dropping the metrics when we create new \"Derived\" nodes in the rendering will be enough for now.  I'll take a look today."}}