{"action":"created","comment":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/81734143","pull_request_review_id":2691254,"id":81734143,"diff_hunk":"@@ -1479,15 +1473,13 @@ class TC_GAME_API SmartWaypointMgr\n \n         void LoadFromDB();\n \n-        WPPath* GetPath(uint32 id)\n+        WPPath const &GetPath(uint32 id)\n         {\n-            if (waypoint_map.find(id) != waypoint_map.end())\n-                return waypoint_map[id];\n-            else return nullptr;\n+            return waypoint_map[id];","path":"src/server/game/AI/SmartScripts/SmartScriptMgr.h","position":51,"original_position":43,"commit_id":"50c05e55c2864a0150ad89c8a0b23ef543c71f68","original_commit_id":"c4893efb992076b88233504726ec5f56798b5e6c","user":{"login":"Riztazz","id":16348711,"avatar_url":"https://avatars.githubusercontent.com/u/16348711?v=3","gravatar_id":"","url":"https://api.github.com/users/Riztazz","html_url":"https://github.com/Riztazz","followers_url":"https://api.github.com/users/Riztazz/followers","following_url":"https://api.github.com/users/Riztazz/following{/other_user}","gists_url":"https://api.github.com/users/Riztazz/gists{/gist_id}","starred_url":"https://api.github.com/users/Riztazz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Riztazz/subscriptions","organizations_url":"https://api.github.com/users/Riztazz/orgs","repos_url":"https://api.github.com/users/Riztazz/repos","events_url":"https://api.github.com/users/Riztazz/events{/privacy}","received_events_url":"https://api.github.com/users/Riztazz/received_events","type":"User","site_admin":false},"body":"would this be alright?\r\n`cpp\r\nWPPath const &GetPath(uint32 id)\r\n{\r\n    auto itr = waypoint_map.find(id);\r\n    if (itr != waypoint_map.end())\r\n        return itr->second;\r\n\r\n    return WPPath();\r\n}\r\n`","created_at":"2016-10-04T11:15:00Z","updated_at":"2016-10-04T11:15:00Z","html_url":"https://github.com/TrinityCore/TrinityCore/pull/18020#discussion_r81734143","pull_request_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/18020","_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/81734143"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/18020#discussion_r81734143"},"pull_request":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/18020"}}},"pull_request":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/18020","id":87209106,"html_url":"https://github.com/TrinityCore/TrinityCore/pull/18020","diff_url":"https://github.com/TrinityCore/TrinityCore/pull/18020.diff","patch_url":"https://github.com/TrinityCore/TrinityCore/pull/18020.patch","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/18020","number":18020,"state":"open","locked":false,"title":"[WIP][3.3.5][6.x should work as well] Core/Movement: Smooth movement #13467","user":{"login":"Riztazz","id":16348711,"avatar_url":"https://avatars.githubusercontent.com/u/16348711?v=3","gravatar_id":"","url":"https://api.github.com/users/Riztazz","html_url":"https://github.com/Riztazz","followers_url":"https://api.github.com/users/Riztazz/followers","following_url":"https://api.github.com/users/Riztazz/following{/other_user}","gists_url":"https://api.github.com/users/Riztazz/gists{/gist_id}","starred_url":"https://api.github.com/users/Riztazz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Riztazz/subscriptions","organizations_url":"https://api.github.com/users/Riztazz/orgs","repos_url":"https://api.github.com/users/Riztazz/repos","events_url":"https://api.github.com/users/Riztazz/events{/privacy}","received_events_url":"https://api.github.com/users/Riztazz/received_events","type":"User","site_admin":false},"body":"[//]: # (************************************************************)\r\n[//]: # (** DON'T DELETE THIS TEMPLATE ELSE YOUR PR WILL BE CLOSED **)\r\n[//]: # (************************************************************)\r\n\r\n**Changes proposed:**\r\nImplement smooth movement for all waypoint pathing and escortai\r\n\r\n**Target branch(es):** 3.3.5/6.x\r\n3.3.5/6.x should work as well\r\n**Issues addressed:** Closes #13467\r\n\r\n**Tests performed:** (Does it build, tested in-game, etc)\r\nBuilds on vs2015, travis will probably complain about some shit\r\n\r\n","created_at":"2016-09-28T21:54:44Z","updated_at":"2016-10-04T11:15:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"320452ddd27aa47526b4df04adcb86233468807a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/18020/commits","review_comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/18020/comments","review_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/18020/comments","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/50c05e55c2864a0150ad89c8a0b23ef543c71f68","head":{"label":"Riztazz:smooth-movement","ref":"smooth-movement","sha":"50c05e55c2864a0150ad89c8a0b23ef543c71f68","user":{"login":"Riztazz","id":16348711,"avatar_url":"https://avatars.githubusercontent.com/u/16348711?v=3","gravatar_id":"","url":"https://api.github.com/users/Riztazz","html_url":"https://github.com/Riztazz","followers_url":"https://api.github.com/users/Riztazz/followers","following_url":"https://api.github.com/users/Riztazz/following{/other_user}","gists_url":"https://api.github.com/users/Riztazz/gists{/gist_id}","starred_url":"https://api.github.com/users/Riztazz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Riztazz/subscriptions","organizations_url":"https://api.github.com/users/Riztazz/orgs","repos_url":"https://api.github.com/users/Riztazz/repos","events_url":"https://api.github.com/users/Riztazz/events{/privacy}","received_events_url":"https://api.github.com/users/Riztazz/received_events","type":"User","site_admin":false},"repo":{"id":68272004,"name":"TrinityCore","full_name":"Riztazz/TrinityCore","owner":{"login":"Riztazz","id":16348711,"avatar_url":"https://avatars.githubusercontent.com/u/16348711?v=3","gravatar_id":"","url":"https://api.github.com/users/Riztazz","html_url":"https://github.com/Riztazz","followers_url":"https://api.github.com/users/Riztazz/followers","following_url":"https://api.github.com/users/Riztazz/following{/other_user}","gists_url":"https://api.github.com/users/Riztazz/gists{/gist_id}","starred_url":"https://api.github.com/users/Riztazz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Riztazz/subscriptions","organizations_url":"https://api.github.com/users/Riztazz/orgs","repos_url":"https://api.github.com/users/Riztazz/repos","events_url":"https://api.github.com/users/Riztazz/events{/privacy}","received_events_url":"https://api.github.com/users/Riztazz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Riztazz/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":true,"url":"https://api.github.com/repos/Riztazz/TrinityCore","forks_url":"https://api.github.com/repos/Riztazz/TrinityCore/forks","keys_url":"https://api.github.com/repos/Riztazz/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Riztazz/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Riztazz/TrinityCore/teams","hooks_url":"https://api.github.com/repos/Riztazz/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/Riztazz/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/Riztazz/TrinityCore/events","assignees_url":"https://api.github.com/repos/Riztazz/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/Riztazz/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/Riztazz/TrinityCore/tags","blobs_url":"https://api.github.com/repos/Riztazz/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Riztazz/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Riztazz/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Riztazz/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Riztazz/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/Riztazz/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/Riztazz/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/Riztazz/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/Riztazz/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/Riztazz/TrinityCore/subscription","commits_url":"https://api.github.com/repos/Riztazz/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Riztazz/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Riztazz/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Riztazz/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Riztazz/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/Riztazz/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Riztazz/TrinityCore/merges","archive_url":"https://api.github.com/repos/Riztazz/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Riztazz/TrinityCore/downloads","issues_url":"https://api.github.com/repos/Riztazz/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/Riztazz/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/Riztazz/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/Riztazz/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Riztazz/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/Riztazz/TrinityCore/releases{/id}","deployments_url":"https://api.github.com/repos/Riztazz/TrinityCore/deployments","created_at":"2016-09-15T06:38:50Z","updated_at":"2016-09-15T06:39:08Z","pushed_at":"2016-10-03T09:34:49Z","git_url":"git://github.com/Riztazz/TrinityCore.git","ssh_url":"git@github.com:Riztazz/TrinityCore.git","clone_url":"https://github.com/Riztazz/TrinityCore.git","svn_url":"https://github.com/Riztazz/TrinityCore","homepage":"http://www.trinitycore.org","size":375451,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"6.x"}},"base":{"label":"TrinityCore:3.3.5","ref":"3.3.5","sha":"e1bafd62a76d83c841006265a0fe08b7e5e66eb7","user":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"repo":{"id":1204412,"name":"TrinityCore","full_name":"TrinityCore/TrinityCore","owner":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TrinityCore/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":false,"url":"https://api.github.com/repos/TrinityCore/TrinityCore","forks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/forks","keys_url":"https://api.github.com/repos/TrinityCore/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TrinityCore/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TrinityCore/TrinityCore/teams","hooks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/events","assignees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/TrinityCore/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/tags","blobs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/TrinityCore/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscription","commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/TrinityCore/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TrinityCore/TrinityCore/merges","archive_url":"https://api.github.com/repos/TrinityCore/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TrinityCore/TrinityCore/downloads","issues_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/TrinityCore/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/TrinityCore/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/TrinityCore/TrinityCore/releases{/id}","deployments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/deployments","created_at":"2010-12-28T23:40:07Z","updated_at":"2016-10-04T05:31:41Z","pushed_at":"2016-10-04T10:23:25Z","git_url":"git://github.com/TrinityCore/TrinityCore.git","ssh_url":"git@github.com:TrinityCore/TrinityCore.git","clone_url":"https://github.com/TrinityCore/TrinityCore.git","svn_url":"https://github.com/TrinityCore/TrinityCore","homepage":"http://www.trinitycore.org","size":806863,"stargazers_count":3486,"watchers_count":3486,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3561,"mirror_url":null,"open_issues_count":1314,"forks":3561,"open_issues":1314,"watchers":3486,"default_branch":"6.x"}},"_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/18020"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/18020"},"issue":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/18020"},"comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/18020/comments"},"review_comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/18020/comments"},"review_comment":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/18020/commits"},"statuses":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/50c05e55c2864a0150ad89c8a0b23ef543c71f68"}}}}
{"actor":{"display_login":"Riztazz"}}