{"action":"created","issue":{"url":"https://api.github.com/repos/varnishcache/varnish-cache/issues/1935","repository_url":"https://api.github.com/repos/varnishcache/varnish-cache","labels_url":"https://api.github.com/repos/varnishcache/varnish-cache/issues/1935/labels{/name}","comments_url":"https://api.github.com/repos/varnishcache/varnish-cache/issues/1935/comments","events_url":"https://api.github.com/repos/varnishcache/varnish-cache/issues/1935/events","html_url":"https://github.com/varnishcache/varnish-cache/pull/1935","id":152532094,"number":1935,"title":"VTCP_connect retry","user":{"login":"ehocdet","id":15999974,"avatar_url":"https://avatars.githubusercontent.com/u/15999974?v=3","gravatar_id":"","url":"https://api.github.com/users/ehocdet","html_url":"https://github.com/ehocdet","followers_url":"https://api.github.com/users/ehocdet/followers","following_url":"https://api.github.com/users/ehocdet/following{/other_user}","gists_url":"https://api.github.com/users/ehocdet/gists{/gist_id}","starred_url":"https://api.github.com/users/ehocdet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehocdet/subscriptions","organizations_url":"https://api.github.com/users/ehocdet/orgs","repos_url":"https://api.github.com/users/ehocdet/repos","events_url":"https://api.github.com/users/ehocdet/events{/privacy}","received_events_url":"https://api.github.com/users/ehocdet/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-05-02T10:59:50Z","updated_at":"2016-05-02T11:57:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/varnishcache/varnish-cache/pulls/1935","html_url":"https://github.com/varnishcache/varnish-cache/pull/1935","diff_url":"https://github.com/varnishcache/varnish-cache/pull/1935.diff","patch_url":"https://github.com/varnishcache/varnish-cache/pull/1935.patch"},"body":"introduce retry mechanism to VTCP_connect.\r\n\r\nIt fix an old misbehavior seen in production:\r\n. VTCP_connect can fail with ETIMEDOUT errno.\r\n. No retry is done and Varnish return 503 instantly\r\n\r\nRetry 3 time is a robust setting.\r\nSet this in varnish-cli parameter, i think it should be necessary to extend the VTCP_connect with a retry parameter. VTCP_connect errno like ETIMEDOUT should not be out of VTCP_connect.\r\n\r\n(split from https://github.com/varnishcache/varnish-cache/pull/1925)"},"comment":{"url":"https://api.github.com/repos/varnishcache/varnish-cache/issues/comments/216218192","html_url":"https://github.com/varnishcache/varnish-cache/pull/1935#issuecomment-216218192","issue_url":"https://api.github.com/repos/varnishcache/varnish-cache/issues/1935","id":216218192,"user":{"login":"fgsch","id":241785,"avatar_url":"https://avatars.githubusercontent.com/u/241785?v=3","gravatar_id":"","url":"https://api.github.com/users/fgsch","html_url":"https://github.com/fgsch","followers_url":"https://api.github.com/users/fgsch/followers","following_url":"https://api.github.com/users/fgsch/following{/other_user}","gists_url":"https://api.github.com/users/fgsch/gists{/gist_id}","starred_url":"https://api.github.com/users/fgsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgsch/subscriptions","organizations_url":"https://api.github.com/users/fgsch/orgs","repos_url":"https://api.github.com/users/fgsch/repos","events_url":"https://api.github.com/users/fgsch/events{/privacy}","received_events_url":"https://api.github.com/users/fgsch/received_events","type":"User","site_admin":false},"created_at":"2016-05-02T11:57:45Z","updated_at":"2016-05-02T11:57:45Z","body":"Isn't this what bereq.retries / return (retry) is for?"}}