{"action":"created","comment":{"url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/pulls/comments/60573644","id":60573644,"diff_hunk":"@@ -1499,17 +1518,21 @@ module internal MagicAssemblyResolution =\n         Assembly.LoadFrom(path)\n #endif\n \n-    let ResolveAssembly(m,tcConfigB, tcImports: TcImports, fsiDynamicCompiler: FsiDynamicCompiler, fsiConsoleOutput: FsiConsoleOutput, fullAssemName:string) = \n+    let Install(tcConfigB, tcImports: TcImports, fsiDynamicCompiler: FsiDynamicCompiler, fsiConsoleOutput: FsiConsoleOutput) = ","path":"src/fsharp/fsi/fsi.fs","position":130,"original_position":168,"commit_id":"d377a1e718558c6de538fc7530c360075caa153f","original_commit_id":"a66b8fa3a997c09a94765407a9e1bd2f3dae3bc5","user":{"login":"dsyme","id":7204669,"avatar_url":"https://avatars.githubusercontent.com/u/7204669?v=3","gravatar_id":"","url":"https://api.github.com/users/dsyme","html_url":"https://github.com/dsyme","followers_url":"https://api.github.com/users/dsyme/followers","following_url":"https://api.github.com/users/dsyme/following{/other_user}","gists_url":"https://api.github.com/users/dsyme/gists{/gist_id}","starred_url":"https://api.github.com/users/dsyme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsyme/subscriptions","organizations_url":"https://api.github.com/users/dsyme/orgs","repos_url":"https://api.github.com/users/dsyme/repos","events_url":"https://api.github.com/users/dsyme/events{/privacy}","received_events_url":"https://api.github.com/users/dsyme/received_events","type":"User","site_admin":false},"body":"Please prefer the FCS version, thanks","created_at":"2016-04-21T12:52:35Z","updated_at":"2016-04-21T12:52:35Z","html_url":"https://github.com/fsharp/FSharp.Compiler.Service/pull/556#discussion_r60573644","pull_request_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/pulls/556","_links":{"self":{"href":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/pulls/comments/60573644"},"html":{"href":"https://github.com/fsharp/FSharp.Compiler.Service/pull/556#discussion_r60573644"},"pull_request":{"href":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/pulls/556"}}},"pull_request":{"url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/pulls/556","id":66722161,"html_url":"https://github.com/fsharp/FSharp.Compiler.Service/pull/556","diff_url":"https://github.com/fsharp/FSharp.Compiler.Service/pull/556.diff","patch_url":"https://github.com/fsharp/FSharp.Compiler.Service/pull/556.patch","issue_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/issues/556","number":556,"state":"open","locked":false,"title":"dotnet core cli build","user":{"login":"ncave","id":777696,"avatar_url":"https://avatars.githubusercontent.com/u/777696?v=3","gravatar_id":"","url":"https://api.github.com/users/ncave","html_url":"https://github.com/ncave","followers_url":"https://api.github.com/users/ncave/followers","following_url":"https://api.github.com/users/ncave/following{/other_user}","gists_url":"https://api.github.com/users/ncave/gists{/gist_id}","starred_url":"https://api.github.com/users/ncave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncave/subscriptions","organizations_url":"https://api.github.com/users/ncave/orgs","repos_url":"https://api.github.com/users/ncave/repos","events_url":"https://api.github.com/users/ncave/events{/privacy}","received_events_url":"https://api.github.com/users/ncave/received_events","type":"User","site_admin":false},"body":"Rough cut, work in progress, just for evaluation and comments (maybe put it in a branch).\r\nFCS builds successfully, but:\r\n- no xplat tools yet, so all generated files are checked in an output folder\r\n- tests not fixed yet\r\n- no appveyor / travis yet","created_at":"2016-04-16T00:44:26Z","updated_at":"2016-04-21T12:52:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cfb92db6214ef4af5076619bcc2047b757bbf469","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/pulls/556/commits","review_comments_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/pulls/556/comments","review_comment_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/issues/556/comments","statuses_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/statuses/d377a1e718558c6de538fc7530c360075caa153f","head":{"label":"ncave:netcore","ref":"netcore","sha":"d377a1e718558c6de538fc7530c360075caa153f","user":{"login":"ncave","id":777696,"avatar_url":"https://avatars.githubusercontent.com/u/777696?v=3","gravatar_id":"","url":"https://api.github.com/users/ncave","html_url":"https://github.com/ncave","followers_url":"https://api.github.com/users/ncave/followers","following_url":"https://api.github.com/users/ncave/following{/other_user}","gists_url":"https://api.github.com/users/ncave/gists{/gist_id}","starred_url":"https://api.github.com/users/ncave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncave/subscriptions","organizations_url":"https://api.github.com/users/ncave/orgs","repos_url":"https://api.github.com/users/ncave/repos","events_url":"https://api.github.com/users/ncave/events{/privacy}","received_events_url":"https://api.github.com/users/ncave/received_events","type":"User","site_admin":false},"repo":{"id":56172119,"name":"FSharp.Compiler.Service","full_name":"ncave/FSharp.Compiler.Service","owner":{"login":"ncave","id":777696,"avatar_url":"https://avatars.githubusercontent.com/u/777696?v=3","gravatar_id":"","url":"https://api.github.com/users/ncave","html_url":"https://github.com/ncave","followers_url":"https://api.github.com/users/ncave/followers","following_url":"https://api.github.com/users/ncave/following{/other_user}","gists_url":"https://api.github.com/users/ncave/gists{/gist_id}","starred_url":"https://api.github.com/users/ncave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncave/subscriptions","organizations_url":"https://api.github.com/users/ncave/orgs","repos_url":"https://api.github.com/users/ncave/repos","events_url":"https://api.github.com/users/ncave/events{/privacy}","received_events_url":"https://api.github.com/users/ncave/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ncave/FSharp.Compiler.Service","description":"F# compiler component exposing additional functionality for editing and compilation clients","fork":true,"url":"https://api.github.com/repos/ncave/FSharp.Compiler.Service","forks_url":"https://api.github.com/repos/ncave/FSharp.Compiler.Service/forks","keys_url":"https://api.github.com/repos/ncave/FSharp.Compiler.Service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ncave/FSharp.Compiler.Service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ncave/FSharp.Compiler.Service/teams","hooks_url":"https://api.github.com/repos/ncave/FSharp.Compiler.Service/hooks","issue_events_url":"https://api.github.com/repos/ncave/FSharp.Compiler.Service/issues/events{/number}","events_url":"https://api.github.com/repos/ncave/FSharp.Compiler.Service/events","assignees_url":"https://api.github.com/repos/ncave/FSharp.Compiler.Service/assignees{/user}","branches_url":"https://api.github.com/repos/ncave/FSharp.Compiler.Service/branches{/branch}","tags_url":"https://api.github.com/repos/ncave/FSharp.Compiler.Service/tags","blobs_url":"https://api.github.com/repos/ncave/FSharp.Compiler.Service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ncave/FSharp.Compiler.Service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ncave/FSharp.Compiler.Service/git/refs{/sha}","trees_url":"https://api.github.com/repos/ncave/FSharp.Compiler.Service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ncave/FSharp.Compiler.Service/statuses/{sha}","languages_url":"https://api.github.com/repos/ncave/FSharp.Compiler.Service/languages","stargazers_url":"https://api.github.com/repos/ncave/FSharp.Compiler.Service/stargazers","contributors_url":"https://api.github.com/repos/ncave/FSharp.Compiler.Service/contributors","subscribers_url":"https://api.github.com/repos/ncave/FSharp.Compiler.Service/subscribers","subscription_url":"https://api.github.com/repos/ncave/FSharp.Compiler.Service/subscription","commits_url":"https://api.github.com/repos/ncave/FSharp.Compiler.Service/commits{/sha}","git_commits_url":"https://api.github.com/repos/ncave/FSharp.Compiler.Service/git/commits{/sha}","comments_url":"https://api.github.com/repos/ncave/FSharp.Compiler.Service/comments{/number}","issue_comment_url":"https://api.github.com/repos/ncave/FSharp.Compiler.Service/issues/comments{/number}","contents_url":"https://api.github.com/repos/ncave/FSharp.Compiler.Service/contents/{+path}","compare_url":"https://api.github.com/repos/ncave/FSharp.Compiler.Service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ncave/FSharp.Compiler.Service/merges","archive_url":"https://api.github.com/repos/ncave/FSharp.Compiler.Service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ncave/FSharp.Compiler.Service/downloads","issues_url":"https://api.github.com/repos/ncave/FSharp.Compiler.Service/issues{/number}","pulls_url":"https://api.github.com/repos/ncave/FSharp.Compiler.Service/pulls{/number}","milestones_url":"https://api.github.com/repos/ncave/FSharp.Compiler.Service/milestones{/number}","notifications_url":"https://api.github.com/repos/ncave/FSharp.Compiler.Service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ncave/FSharp.Compiler.Service/labels{/name}","releases_url":"https://api.github.com/repos/ncave/FSharp.Compiler.Service/releases{/id}","deployments_url":"https://api.github.com/repos/ncave/FSharp.Compiler.Service/deployments","created_at":"2016-04-13T17:24:32Z","updated_at":"2016-04-13T17:24:34Z","pushed_at":"2016-04-21T07:37:41Z","git_url":"git://github.com/ncave/FSharp.Compiler.Service.git","ssh_url":"git@github.com:ncave/FSharp.Compiler.Service.git","clone_url":"https://github.com/ncave/FSharp.Compiler.Service.git","svn_url":"https://github.com/ncave/FSharp.Compiler.Service","homepage":"http://fsharp.github.io/FSharp.Compiler.Service","size":148242,"stargazers_count":0,"watchers_count":0,"language":"F#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fsharp:master","ref":"master","sha":"2eeb2bfd64c6753a77a979522a381197214d2509","user":{"login":"fsharp","id":485415,"avatar_url":"https://avatars.githubusercontent.com/u/485415?v=3","gravatar_id":"","url":"https://api.github.com/users/fsharp","html_url":"https://github.com/fsharp","followers_url":"https://api.github.com/users/fsharp/followers","following_url":"https://api.github.com/users/fsharp/following{/other_user}","gists_url":"https://api.github.com/users/fsharp/gists{/gist_id}","starred_url":"https://api.github.com/users/fsharp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsharp/subscriptions","organizations_url":"https://api.github.com/users/fsharp/orgs","repos_url":"https://api.github.com/users/fsharp/repos","events_url":"https://api.github.com/users/fsharp/events{/privacy}","received_events_url":"https://api.github.com/users/fsharp/received_events","type":"Organization","site_admin":false},"repo":{"id":13227260,"name":"FSharp.Compiler.Service","full_name":"fsharp/FSharp.Compiler.Service","owner":{"login":"fsharp","id":485415,"avatar_url":"https://avatars.githubusercontent.com/u/485415?v=3","gravatar_id":"","url":"https://api.github.com/users/fsharp","html_url":"https://github.com/fsharp","followers_url":"https://api.github.com/users/fsharp/followers","following_url":"https://api.github.com/users/fsharp/following{/other_user}","gists_url":"https://api.github.com/users/fsharp/gists{/gist_id}","starred_url":"https://api.github.com/users/fsharp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsharp/subscriptions","organizations_url":"https://api.github.com/users/fsharp/orgs","repos_url":"https://api.github.com/users/fsharp/repos","events_url":"https://api.github.com/users/fsharp/events{/privacy}","received_events_url":"https://api.github.com/users/fsharp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fsharp/FSharp.Compiler.Service","description":"F# compiler component exposing additional functionality for editing and compilation clients","fork":false,"url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service","forks_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/forks","keys_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/teams","hooks_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/hooks","issue_events_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/issues/events{/number}","events_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/events","assignees_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/assignees{/user}","branches_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/branches{/branch}","tags_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/tags","blobs_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/git/refs{/sha}","trees_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/statuses/{sha}","languages_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/languages","stargazers_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/stargazers","contributors_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/contributors","subscribers_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/subscribers","subscription_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/subscription","commits_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/commits{/sha}","git_commits_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/git/commits{/sha}","comments_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/comments{/number}","issue_comment_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/issues/comments{/number}","contents_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/contents/{+path}","compare_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/merges","archive_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/downloads","issues_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/issues{/number}","pulls_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/pulls{/number}","milestones_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/milestones{/number}","notifications_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/labels{/name}","releases_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/releases{/id}","deployments_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/deployments","created_at":"2013-09-30T21:01:56Z","updated_at":"2016-04-20T10:58:53Z","pushed_at":"2016-04-21T08:47:05Z","git_url":"git://github.com/fsharp/FSharp.Compiler.Service.git","ssh_url":"git@github.com:fsharp/FSharp.Compiler.Service.git","clone_url":"https://github.com/fsharp/FSharp.Compiler.Service.git","svn_url":"https://github.com/fsharp/FSharp.Compiler.Service","homepage":"http://fsharp.github.io/FSharp.Compiler.Service","size":149310,"stargazers_count":113,"watchers_count":113,"language":"F#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":74,"mirror_url":null,"open_issues_count":90,"forks":74,"open_issues":90,"watchers":113,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/pulls/556"},"html":{"href":"https://github.com/fsharp/FSharp.Compiler.Service/pull/556"},"issue":{"href":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/issues/556"},"comments":{"href":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/issues/556/comments"},"review_comments":{"href":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/pulls/556/comments"},"review_comment":{"href":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/pulls/556/commits"},"statuses":{"href":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/statuses/d377a1e718558c6de538fc7530c360075caa153f"}}}}