{"push_id":1148230136,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"5dea8e2016fb80203ccf66138d224fb047a546a0","before":"4648d240474f73379b798530304a1a65266194bc","commits":[{"sha":"5dea8e2016fb80203ccf66138d224fb047a546a0","author":{"name":"Liang Xiong","email":"81493a5c2a19ebdf5df899369d572ab31dec1b12@fb.com"},"message":"accept json serialization options in thrift cpp readFromJson\n\nSummary:\nthrift cpp1 uses parseJson() in readFromJson, without any options. the thrift struct can contains some large double values that got converted to a large int string and cause troubles.\n\nthe root cause is, thrift cpp1 readFromJson() first deserialize the string, get a dynamic, and the serialize part of it so that the member fields can parse it again. in other words, it's string -> dynamic -> string -> dynamic. during the second conversion, some large doubles will become int strings as configured by kConvMaxDecimalInShortestHigh. then in the third conversion, this big int is either causing precision problems or overflow problems.\n\ndouble_fallback in folly::json::serialization_opts can solve this problem. and we need a way to pass it in. this diff does just that.\n\nReviewed By: alandau\n\nDifferential Revision: D3391761\n\nfbshipit-source-id: 147ec045075972fd4c10e4b6920fbedf9e000fcb","distinct":true,"url":"https://api.github.com/repos/facebook/fbthrift/commits/5dea8e2016fb80203ccf66138d224fb047a546a0"}]}
{"actor":{"display_login":"facebook-github-bot-7"}}