{"action":"reopened","issue":{"url":"https://api.github.com/repos/openvstorage/framework/issues/648","repository_url":"https://api.github.com/repos/openvstorage/framework","labels_url":"https://api.github.com/repos/openvstorage/framework/issues/648/labels{/name}","comments_url":"https://api.github.com/repos/openvstorage/framework/issues/648/comments","events_url":"https://api.github.com/repos/openvstorage/framework/issues/648/events","html_url":"https://github.com/openvstorage/framework/issues/648","id":161626562,"number":648,"title":"Wrong prefix for alba fragment cache","user":{"login":"domsj","id":89326,"avatar_url":"https://avatars.githubusercontent.com/u/89326?v=3","gravatar_id":"","url":"https://api.github.com/users/domsj","html_url":"https://github.com/domsj","followers_url":"https://api.github.com/users/domsj/followers","following_url":"https://api.github.com/users/domsj/following{/other_user}","gists_url":"https://api.github.com/users/domsj/gists{/gist_id}","starred_url":"https://api.github.com/users/domsj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domsj/subscriptions","organizations_url":"https://api.github.com/users/domsj/orgs","repos_url":"https://api.github.com/users/domsj/repos","events_url":"https://api.github.com/users/domsj/events{/privacy}","received_events_url":"https://api.github.com/users/domsj/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/openvstorage/framework/labels/priority_urgent","name":"priority_urgent","color":"d93f0b"},{"url":"https://api.github.com/repos/openvstorage/framework/labels/type_bug","name":"type_bug","color":"fef2c0"}],"state":"open","locked":false,"assignee":{"login":"khenderick","id":1453214,"avatar_url":"https://avatars.githubusercontent.com/u/1453214?v=3","gravatar_id":"","url":"https://api.github.com/users/khenderick","html_url":"https://github.com/khenderick","followers_url":"https://api.github.com/users/khenderick/followers","following_url":"https://api.github.com/users/khenderick/following{/other_user}","gists_url":"https://api.github.com/users/khenderick/gists{/gist_id}","starred_url":"https://api.github.com/users/khenderick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khenderick/subscriptions","organizations_url":"https://api.github.com/users/khenderick/orgs","repos_url":"https://api.github.com/users/khenderick/repos","events_url":"https://api.github.com/users/khenderick/events{/privacy}","received_events_url":"https://api.github.com/users/khenderick/received_events","type":"User","site_admin":false},"assignees":[{"login":"khenderick","id":1453214,"avatar_url":"https://avatars.githubusercontent.com/u/1453214?v=3","gravatar_id":"","url":"https://api.github.com/users/khenderick","html_url":"https://github.com/khenderick","followers_url":"https://api.github.com/users/khenderick/followers","following_url":"https://api.github.com/users/khenderick/following{/other_user}","gists_url":"https://api.github.com/users/khenderick/gists{/gist_id}","starred_url":"https://api.github.com/users/khenderick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khenderick/subscriptions","organizations_url":"https://api.github.com/users/khenderick/orgs","repos_url":"https://api.github.com/users/khenderick/repos","events_url":"https://api.github.com/users/khenderick/events{/privacy}","received_events_url":"https://api.github.com/users/khenderick/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/openvstorage/framework/milestones/3","html_url":"https://github.com/openvstorage/framework/milestones/Fargo","labels_url":"https://api.github.com/repos/openvstorage/framework/milestones/3/labels","id":1817566,"number":3,"title":"Fargo","description":"","creator":{"login":"wimpers","id":8392927,"avatar_url":"https://avatars.githubusercontent.com/u/8392927?v=3","gravatar_id":"","url":"https://api.github.com/users/wimpers","html_url":"https://github.com/wimpers","followers_url":"https://api.github.com/users/wimpers/followers","following_url":"https://api.github.com/users/wimpers/following{/other_user}","gists_url":"https://api.github.com/users/wimpers/gists{/gist_id}","starred_url":"https://api.github.com/users/wimpers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wimpers/subscriptions","organizations_url":"https://api.github.com/users/wimpers/orgs","repos_url":"https://api.github.com/users/wimpers/repos","events_url":"https://api.github.com/users/wimpers/events{/privacy}","received_events_url":"https://api.github.com/users/wimpers/received_events","type":"User","site_admin":false},"open_issues":31,"closed_issues":15,"state":"open","created_at":"2016-06-09T12:20:32Z","updated_at":"2016-07-01T18:01:35Z","due_on":"2016-08-30T22:00:00Z","closed_at":null},"comments":1,"created_at":"2016-06-22T08:52:26Z","updated_at":"2016-07-01T18:01:35Z","closed_at":null,"body":"While investigating an issue I noticed this in the config of a proxy:\r\n\r\n```\r\n\"fragment_cache\": [\"alba\", {\r\n\"albamgr_cfg_url\": \"etcd://127.0.0.1:2379/ovs/vpools/e4d07c5c-5106-44e4-8fea-5d36e0f0be9f/proxies/95ee2c88-c861-4b7f-abaf-64169fd73c85/config/abm_aa\", \r\n\"cache_on_write\": true, \r\n\"manifest_cache_size\": 17179869184, \r\n\"cache_on_read\": true, \r\n\"bucket_strategy\": [\"1-to-1\", {\"prefix\": \"flash-roub\", \"preset\": \"default\"\r\n}]}]\r\n```\r\n\r\nAs you can see there's a fragment cache of type alba configured (to be used for flash acceleration).\r\nThe prefix used for the cache however is the name of the flash backend, while I expected it to be the name of the backend (or some other identifier related to the backend) that is being accelerated.\r\nThis choice of prefix may lead to problems when the flash alba is also used to accelerate other backends. I strongly recommend changing the prefix used for caching.\r\nI would also recommend adding a prefix/suffix to the prefix to identify this prefix is used as a cache.\r\n\r\nThat last remark would similarly also apply to when a backend is used as an osd in another backend.\r\n\r\nThere's also a difference in the prefixes for cache vs for alba-as-osd: one uses some name of the backend, and the other uses some guid. Maybe you want to streamline both into\r\n{name}\\_{guid}\\_{fragment_cache/alba_osd} ?"}}
{"actor":{"display_login":"khenderick"}}