{"action":"created","issue":{"url":"https://api.github.com/repos/playframework/playframework/issues/6170","repository_url":"https://api.github.com/repos/playframework/playframework","labels_url":"https://api.github.com/repos/playframework/playframework/issues/6170/labels{/name}","comments_url":"https://api.github.com/repos/playframework/playframework/issues/6170/comments","events_url":"https://api.github.com/repos/playframework/playframework/issues/6170/events","html_url":"https://github.com/playframework/playframework/pull/6170","id":155599312,"number":6170,"title":"Fixes #4796 makes acceptAnyCertificate work","user":{"login":"schmitch","id":1641401,"avatar_url":"https://avatars.githubusercontent.com/u/1641401?v=3","gravatar_id":"","url":"https://api.github.com/users/schmitch","html_url":"https://github.com/schmitch","followers_url":"https://api.github.com/users/schmitch/followers","following_url":"https://api.github.com/users/schmitch/following{/other_user}","gists_url":"https://api.github.com/users/schmitch/gists{/gist_id}","starred_url":"https://api.github.com/users/schmitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmitch/subscriptions","organizations_url":"https://api.github.com/users/schmitch/orgs","repos_url":"https://api.github.com/users/schmitch/repos","events_url":"https://api.github.com/users/schmitch/events{/privacy}","received_events_url":"https://api.github.com/users/schmitch/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-05-18T20:55:01Z","updated_at":"2016-05-19T20:35:41Z","closed_at":"2016-05-19T20:34:20Z","pull_request":{"url":"https://api.github.com/repos/playframework/playframework/pulls/6170","html_url":"https://github.com/playframework/playframework/pull/6170","diff_url":"https://github.com/playframework/playframework/pull/6170.diff","patch_url":"https://github.com/playframework/playframework/pull/6170.patch"},"body":"## Fixes\r\n\r\nFixes #4796\r\n\r\n## Purpose\r\n\r\nActually it makes acceptAnyCertificate working\r\n\r\n## Background Context\r\n\r\nIn Play 2.4 upwards Play added a JsseSslContext and relied on Netty 4 / Asynchttpclient 2 while everything worked, the certificate handling changed and made it impossible to run under \"really\" loose SSL setups.\r\n\r\nAt the moment there aren't tests for this, but it will be actually hard to implement.\r\nThere is one way but since I would need to work around some things I didn't. Actually setting up a play instance with -Dhttps.port=9443 and point a ws.url to itself it will actually fail with a SSL Error so there would be a way to test, however the WS Test client doesn't rely on a typesafe config (https://github.com/playframework/playframework/blob/9a06b9a0a6ea7d1299e61ea3c1f37a08b714297e/framework/src/play-ws/src/main/scala/play/api/test/WSTestClient.scala#L65) I would need to create a new client just for a single test. any ideas to work that out or could we ignore a test for this?"},"comment":{"url":"https://api.github.com/repos/playframework/playframework/issues/comments/220444381","html_url":"https://github.com/playframework/playframework/pull/6170#issuecomment-220444381","issue_url":"https://api.github.com/repos/playframework/playframework/issues/6170","id":220444381,"user":{"login":"gmethvin","id":171663,"avatar_url":"https://avatars.githubusercontent.com/u/171663?v=3","gravatar_id":"","url":"https://api.github.com/users/gmethvin","html_url":"https://github.com/gmethvin","followers_url":"https://api.github.com/users/gmethvin/followers","following_url":"https://api.github.com/users/gmethvin/following{/other_user}","gists_url":"https://api.github.com/users/gmethvin/gists{/gist_id}","starred_url":"https://api.github.com/users/gmethvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmethvin/subscriptions","organizations_url":"https://api.github.com/users/gmethvin/orgs","repos_url":"https://api.github.com/users/gmethvin/repos","events_url":"https://api.github.com/users/gmethvin/events{/privacy}","received_events_url":"https://api.github.com/users/gmethvin/received_events","type":"User","site_admin":false},"created_at":"2016-05-19T20:35:41Z","updated_at":"2016-05-19T20:35:41Z","body":"@schmitch Maybe we should add a warning when loose ssl configuration is used in production. I think this should probably go in SSLConfigParser though."}}