{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/74434773","id":74434773,"diff_hunk":"@@ -0,0 +1,101 @@\n+/*\n+Copyright 2016 The Kubernetes Authors.\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+    http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package e2e\n+\n+import (\n+\t\"fmt\"\n+\t\"time\"\n+\n+\tfederation_api \"k8s.io/kubernetes/federation/apis/federation/v1beta1\"\n+\tapi \"k8s.io/kubernetes/pkg/api\"\n+\tapi_v1 \"k8s.io/kubernetes/pkg/api/v1\"\n+\t\"k8s.io/kubernetes/pkg/util/wait\"\n+\t\"k8s.io/kubernetes/test/e2e/framework\"\n+)\n+\n+func createClusterObjectOrFail_14(f *framework.Framework, context *framework.E2EContext) {\n+\tframework.Logf(\"Creating cluster object: %s (%s, secret: %s)\", context.Name, context.Cluster.Cluster.Server, context.Name)\n+\tcluster := federation_api.Cluster{\n+\t\tObjectMeta: api_v1.ObjectMeta{\n+\t\t\tName: context.Name,\n+\t\t},\n+\t\tSpec: federation_api.ClusterSpec{\n+\t\t\tServerAddressByClientCIDRs: []federation_api.ServerAddressByClientCIDR{\n+\t\t\t\t{\n+\t\t\t\t\tClientCIDR:    \"0.0.0.0/0\",\n+\t\t\t\t\tServerAddress: context.Cluster.Cluster.Server,\n+\t\t\t\t},\n+\t\t\t},\n+\t\t\tSecretRef: &api_v1.LocalObjectReference{\n+\t\t\t\t// Note: Name must correlate with federation build script secret name,\n+\t\t\t\t//       which currently matches the cluster name.\n+\t\t\t\t//       See federation/cluster/common.sh:132\n+\t\t\t\tName: context.Name,\n+\t\t\t},\n+\t\t},\n+\t}\n+\t_, err := f.FederationClientset_1_4.Federation().Clusters().Create(&cluster)\n+\tframework.ExpectNoError(err, fmt.Sprintf(\"creating cluster: %+v\", err))\n+\tframework.Logf(\"Successfully created cluster object: %s (%s, secret: %s)\", context.Name, context.Cluster.Cluster.Server, context.Name)\n+}\n+\n+func clusterIsReadyOrFail_14(f *framework.Framework, context *framework.E2EContext) {\n+\tc, err := f.FederationClientset_1_4.Federation().Clusters().Get(context.Name)\n+\tframework.ExpectNoError(err, fmt.Sprintf(\"get cluster: %+v\", err))\n+\tif c.ObjectMeta.Name != context.Name {\n+\t\tframework.Failf(\"cluster name does not match input context: actual=%+v, expected=%+v\", c, context)\n+\t}\n+\terr = isReady(context.Name, f.FederationClientset)","path":"test/e2e/federation-util-14.go","position":62,"original_position":62,"commit_id":"16ecc4ec35a5841d85ab83ae069e070d5f1ca8c6","original_commit_id":"16ecc4ec35a5841d85ab83ae069e070d5f1ca8c6","user":{"login":"mwielgus","id":11994812,"avatar_url":"https://avatars.githubusercontent.com/u/11994812?v=3","gravatar_id":"","url":"https://api.github.com/users/mwielgus","html_url":"https://github.com/mwielgus","followers_url":"https://api.github.com/users/mwielgus/followers","following_url":"https://api.github.com/users/mwielgus/following{/other_user}","gists_url":"https://api.github.com/users/mwielgus/gists{/gist_id}","starred_url":"https://api.github.com/users/mwielgus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwielgus/subscriptions","organizations_url":"https://api.github.com/users/mwielgus/orgs","repos_url":"https://api.github.com/users/mwielgus/repos","events_url":"https://api.github.com/users/mwielgus/events{/privacy}","received_events_url":"https://api.github.com/users/mwielgus/received_events","type":"User","site_admin":false},"body":"I would rather keep it consistent with federation-util.go.","created_at":"2016-08-11T14:41:03Z","updated_at":"2016-08-11T14:41:03Z","html_url":"https://github.com/kubernetes/kubernetes/pull/30443#discussion_r74434773","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30443","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/74434773"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/30443#discussion_r74434773"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30443"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30443","id":80949028,"html_url":"https://github.com/kubernetes/kubernetes/pull/30443","diff_url":"https://github.com/kubernetes/kubernetes/pull/30443.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/30443.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/30443","number":30443,"state":"open","locked":false,"title":"Federation e2e test util using clientset 1.4","user":{"login":"mwielgus","id":11994812,"avatar_url":"https://avatars.githubusercontent.com/u/11994812?v=3","gravatar_id":"","url":"https://api.github.com/users/mwielgus","html_url":"https://github.com/mwielgus","followers_url":"https://api.github.com/users/mwielgus/followers","following_url":"https://api.github.com/users/mwielgus/following{/other_user}","gists_url":"https://api.github.com/users/mwielgus/gists{/gist_id}","starred_url":"https://api.github.com/users/mwielgus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwielgus/subscriptions","organizations_url":"https://api.github.com/users/mwielgus/orgs","repos_url":"https://api.github.com/users/mwielgus/repos","events_url":"https://api.github.com/users/mwielgus/events{/privacy}","received_events_url":"https://api.github.com/users/mwielgus/received_events","type":"User","site_admin":false},"body":"Federation-util.go uses non versioned objects and clients.\r\n\r\ncc: @quinton-hoole @wojtek-t @kubernetes/sig-cluster-federation\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/30443)\n<!-- Reviewable:end -->\n","created_at":"2016-08-11T12:30:38Z","updated_at":"2016-08-11T14:41:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d988abd7ce76edc860ca0f62236c8db5b4220f6a","assignee":{"login":"wojtek-t","id":10743879,"avatar_url":"https://avatars.githubusercontent.com/u/10743879?v=3","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false},"assignees":[{"login":"wojtek-t","id":10743879,"avatar_url":"https://avatars.githubusercontent.com/u/10743879?v=3","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30443/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30443/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/30443/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/16ecc4ec35a5841d85ab83ae069e070d5f1ca8c6","head":{"label":"mwielgus:fed-util-e2e","ref":"fed-util-e2e","sha":"16ecc4ec35a5841d85ab83ae069e070d5f1ca8c6","user":{"login":"mwielgus","id":11994812,"avatar_url":"https://avatars.githubusercontent.com/u/11994812?v=3","gravatar_id":"","url":"https://api.github.com/users/mwielgus","html_url":"https://github.com/mwielgus","followers_url":"https://api.github.com/users/mwielgus/followers","following_url":"https://api.github.com/users/mwielgus/following{/other_user}","gists_url":"https://api.github.com/users/mwielgus/gists{/gist_id}","starred_url":"https://api.github.com/users/mwielgus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwielgus/subscriptions","organizations_url":"https://api.github.com/users/mwielgus/orgs","repos_url":"https://api.github.com/users/mwielgus/repos","events_url":"https://api.github.com/users/mwielgus/events{/privacy}","received_events_url":"https://api.github.com/users/mwielgus/received_events","type":"User","site_admin":false},"repo":{"id":34387979,"name":"kubernetes","full_name":"mwielgus/kubernetes","owner":{"login":"mwielgus","id":11994812,"avatar_url":"https://avatars.githubusercontent.com/u/11994812?v=3","gravatar_id":"","url":"https://api.github.com/users/mwielgus","html_url":"https://github.com/mwielgus","followers_url":"https://api.github.com/users/mwielgus/followers","following_url":"https://api.github.com/users/mwielgus/following{/other_user}","gists_url":"https://api.github.com/users/mwielgus/gists{/gist_id}","starred_url":"https://api.github.com/users/mwielgus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwielgus/subscriptions","organizations_url":"https://api.github.com/users/mwielgus/orgs","repos_url":"https://api.github.com/users/mwielgus/repos","events_url":"https://api.github.com/users/mwielgus/events{/privacy}","received_events_url":"https://api.github.com/users/mwielgus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mwielgus/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/mwielgus/kubernetes","forks_url":"https://api.github.com/repos/mwielgus/kubernetes/forks","keys_url":"https://api.github.com/repos/mwielgus/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mwielgus/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mwielgus/kubernetes/teams","hooks_url":"https://api.github.com/repos/mwielgus/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/mwielgus/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/mwielgus/kubernetes/events","assignees_url":"https://api.github.com/repos/mwielgus/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/mwielgus/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/mwielgus/kubernetes/tags","blobs_url":"https://api.github.com/repos/mwielgus/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mwielgus/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mwielgus/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/mwielgus/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mwielgus/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/mwielgus/kubernetes/languages","stargazers_url":"https://api.github.com/repos/mwielgus/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/mwielgus/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/mwielgus/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/mwielgus/kubernetes/subscription","commits_url":"https://api.github.com/repos/mwielgus/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/mwielgus/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/mwielgus/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/mwielgus/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/mwielgus/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/mwielgus/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mwielgus/kubernetes/merges","archive_url":"https://api.github.com/repos/mwielgus/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mwielgus/kubernetes/downloads","issues_url":"https://api.github.com/repos/mwielgus/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/mwielgus/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/mwielgus/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/mwielgus/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mwielgus/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/mwielgus/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/mwielgus/kubernetes/deployments","created_at":"2015-04-22T12:04:42Z","updated_at":"2015-04-22T12:04:46Z","pushed_at":"2016-08-11T14:21:52Z","git_url":"git://github.com/mwielgus/kubernetes.git","ssh_url":"git@github.com:mwielgus/kubernetes.git","clone_url":"https://github.com/mwielgus/kubernetes.git","svn_url":"https://github.com/mwielgus/kubernetes","homepage":"http://kubernetes.io","size":300174,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"b159e29da2fbd9b578597fb9306971ec3ce965ad","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-08-11T11:57:16Z","pushed_at":"2016-08-11T14:39:34Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":519622,"stargazers_count":16079,"watchers_count":16079,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5103,"mirror_url":null,"open_issues_count":4165,"forks":5103,"open_issues":4165,"watchers":16079,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30443"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/30443"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/30443"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/30443/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30443/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30443/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/16ecc4ec35a5841d85ab83ae069e070d5f1ca8c6"}}}}
{"actor":{"display_login":"mwielgus"}}