{"action":"created","comment":{"url":"https://api.github.com/repos/openssl/openssl/pulls/comments/55460907","id":55460907,"diff_hunk":"@@ -111,7 +111,7 @@ static int ct_x509_get_ext(X509 *cert, int nid, int *is_duplicated)\n  * AKID from the presigner certificate, if necessary.\n  * Returns 1 on success, 0 otherwise.\n  */\n-static int ct_x509_cert_fixup(X509 *cert, X509 *presigner)\n+__owur static int ct_x509_cert_fixup(X509 *cert, X509 *presigner)","path":"crypto/ct/ct_sct_ctx.c","position":5,"original_position":5,"commit_id":"11989b95ad1cb96707b2b7c6efe326477f94a888","original_commit_id":"100dbb3f141339173474cf68407d470c3924871e","user":{"login":"RJPercival","id":1949076,"avatar_url":"https://avatars.githubusercontent.com/u/1949076?v=3","gravatar_id":"","url":"https://api.github.com/users/RJPercival","html_url":"https://github.com/RJPercival","followers_url":"https://api.github.com/users/RJPercival/followers","following_url":"https://api.github.com/users/RJPercival/following{/other_user}","gists_url":"https://api.github.com/users/RJPercival/gists{/gist_id}","starred_url":"https://api.github.com/users/RJPercival/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RJPercival/subscriptions","organizations_url":"https://api.github.com/users/RJPercival/orgs","repos_url":"https://api.github.com/users/RJPercival/repos","events_url":"https://api.github.com/users/RJPercival/events{/privacy}","received_events_url":"https://api.github.com/users/RJPercival/received_events","type":"User","site_admin":false},"body":"All constification done. Can't constify here because `X509_get_ext_by_NID` doesn't take a const `X509` parameter.","created_at":"2016-03-09T01:43:23Z","updated_at":"2016-03-09T01:43:23Z","html_url":"https://github.com/openssl/openssl/pull/791#discussion_r55460907","pull_request_url":"https://api.github.com/repos/openssl/openssl/pulls/791","_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments/55460907"},"html":{"href":"https://github.com/openssl/openssl/pull/791#discussion_r55460907"},"pull_request":{"href":"https://api.github.com/repos/openssl/openssl/pulls/791"}}},"pull_request":{"url":"https://api.github.com/repos/openssl/openssl/pulls/791","id":61762575,"html_url":"https://github.com/openssl/openssl/pull/791","diff_url":"https://github.com/openssl/openssl/pull/791.diff","patch_url":"https://github.com/openssl/openssl/pull/791.patch","issue_url":"https://api.github.com/repos/openssl/openssl/issues/791","number":791,"state":"open","locked":false,"title":"Minor improvements to CT functions","user":{"login":"RJPercival","id":1949076,"avatar_url":"https://avatars.githubusercontent.com/u/1949076?v=3","gravatar_id":"","url":"https://api.github.com/users/RJPercival","html_url":"https://github.com/RJPercival","followers_url":"https://api.github.com/users/RJPercival/followers","following_url":"https://api.github.com/users/RJPercival/following{/other_user}","gists_url":"https://api.github.com/users/RJPercival/gists{/gist_id}","starred_url":"https://api.github.com/users/RJPercival/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RJPercival/subscriptions","organizations_url":"https://api.github.com/users/RJPercival/orgs","repos_url":"https://api.github.com/users/RJPercival/repos","events_url":"https://api.github.com/users/RJPercival/events{/privacy}","received_events_url":"https://api.github.com/users/RJPercival/received_events","type":"User","site_admin":false},"body":"- Used __owur to ensure the return values of boolean functions are checked.\r\n- Improved documentation.\r\n- Made parameters of CTLOG_get* const.\r\n- Made SCT_LIST_set_source return the number of successes.","created_at":"2016-03-04T19:55:52Z","updated_at":"2016-03-09T01:43:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a3c55adec435956fef6b304a286029cb52f6265","assignee":{"login":"richsalz","id":7332500,"avatar_url":"https://avatars.githubusercontent.com/u/7332500?v=3","gravatar_id":"","url":"https://api.github.com/users/richsalz","html_url":"https://github.com/richsalz","followers_url":"https://api.github.com/users/richsalz/followers","following_url":"https://api.github.com/users/richsalz/following{/other_user}","gists_url":"https://api.github.com/users/richsalz/gists{/gist_id}","starred_url":"https://api.github.com/users/richsalz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richsalz/subscriptions","organizations_url":"https://api.github.com/users/richsalz/orgs","repos_url":"https://api.github.com/users/richsalz/repos","events_url":"https://api.github.com/users/richsalz/events{/privacy}","received_events_url":"https://api.github.com/users/richsalz/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/openssl/openssl/pulls/791/commits","review_comments_url":"https://api.github.com/repos/openssl/openssl/pulls/791/comments","review_comment_url":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openssl/openssl/issues/791/comments","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/11989b95ad1cb96707b2b7c6efe326477f94a888","head":{"label":"RJPercival:ct_bool_funcs","ref":"ct_bool_funcs","sha":"11989b95ad1cb96707b2b7c6efe326477f94a888","user":{"login":"RJPercival","id":1949076,"avatar_url":"https://avatars.githubusercontent.com/u/1949076?v=3","gravatar_id":"","url":"https://api.github.com/users/RJPercival","html_url":"https://github.com/RJPercival","followers_url":"https://api.github.com/users/RJPercival/followers","following_url":"https://api.github.com/users/RJPercival/following{/other_user}","gists_url":"https://api.github.com/users/RJPercival/gists{/gist_id}","starred_url":"https://api.github.com/users/RJPercival/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RJPercival/subscriptions","organizations_url":"https://api.github.com/users/RJPercival/orgs","repos_url":"https://api.github.com/users/RJPercival/repos","events_url":"https://api.github.com/users/RJPercival/events{/privacy}","received_events_url":"https://api.github.com/users/RJPercival/received_events","type":"User","site_admin":false},"repo":{"id":47709710,"name":"openssl","full_name":"RJPercival/openssl","owner":{"login":"RJPercival","id":1949076,"avatar_url":"https://avatars.githubusercontent.com/u/1949076?v=3","gravatar_id":"","url":"https://api.github.com/users/RJPercival","html_url":"https://github.com/RJPercival","followers_url":"https://api.github.com/users/RJPercival/followers","following_url":"https://api.github.com/users/RJPercival/following{/other_user}","gists_url":"https://api.github.com/users/RJPercival/gists{/gist_id}","starred_url":"https://api.github.com/users/RJPercival/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RJPercival/subscriptions","organizations_url":"https://api.github.com/users/RJPercival/orgs","repos_url":"https://api.github.com/users/RJPercival/repos","events_url":"https://api.github.com/users/RJPercival/events{/privacy}","received_events_url":"https://api.github.com/users/RJPercival/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RJPercival/openssl","description":"TLS/SSL and crypto library","fork":true,"url":"https://api.github.com/repos/RJPercival/openssl","forks_url":"https://api.github.com/repos/RJPercival/openssl/forks","keys_url":"https://api.github.com/repos/RJPercival/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RJPercival/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RJPercival/openssl/teams","hooks_url":"https://api.github.com/repos/RJPercival/openssl/hooks","issue_events_url":"https://api.github.com/repos/RJPercival/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/RJPercival/openssl/events","assignees_url":"https://api.github.com/repos/RJPercival/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/RJPercival/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/RJPercival/openssl/tags","blobs_url":"https://api.github.com/repos/RJPercival/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RJPercival/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RJPercival/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/RJPercival/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RJPercival/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/RJPercival/openssl/languages","stargazers_url":"https://api.github.com/repos/RJPercival/openssl/stargazers","contributors_url":"https://api.github.com/repos/RJPercival/openssl/contributors","subscribers_url":"https://api.github.com/repos/RJPercival/openssl/subscribers","subscription_url":"https://api.github.com/repos/RJPercival/openssl/subscription","commits_url":"https://api.github.com/repos/RJPercival/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/RJPercival/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/RJPercival/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/RJPercival/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/RJPercival/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/RJPercival/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RJPercival/openssl/merges","archive_url":"https://api.github.com/repos/RJPercival/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RJPercival/openssl/downloads","issues_url":"https://api.github.com/repos/RJPercival/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/RJPercival/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/RJPercival/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/RJPercival/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RJPercival/openssl/labels{/name}","releases_url":"https://api.github.com/repos/RJPercival/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/RJPercival/openssl/deployments","created_at":"2015-12-09T18:10:22Z","updated_at":"2016-01-15T16:14:35Z","pushed_at":"2016-03-08T19:28:27Z","git_url":"git://github.com/RJPercival/openssl.git","ssh_url":"git@github.com:RJPercival/openssl.git","clone_url":"https://github.com/RJPercival/openssl.git","svn_url":"https://github.com/RJPercival/openssl","homepage":"https://www.openssl.org","size":83551,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openssl:master","ref":"master","sha":"c7f1fa8ec0c022e5014ef45348e869f9d8781327","user":{"login":"openssl","id":3279138,"avatar_url":"https://avatars.githubusercontent.com/u/3279138?v=3","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"repo":{"id":7634677,"name":"openssl","full_name":"openssl/openssl","owner":{"login":"openssl","id":3279138,"avatar_url":"https://avatars.githubusercontent.com/u/3279138?v=3","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openssl/openssl","description":"TLS/SSL and crypto library","fork":false,"url":"https://api.github.com/repos/openssl/openssl","forks_url":"https://api.github.com/repos/openssl/openssl/forks","keys_url":"https://api.github.com/repos/openssl/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openssl/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openssl/openssl/teams","hooks_url":"https://api.github.com/repos/openssl/openssl/hooks","issue_events_url":"https://api.github.com/repos/openssl/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/openssl/openssl/events","assignees_url":"https://api.github.com/repos/openssl/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/openssl/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/openssl/openssl/tags","blobs_url":"https://api.github.com/repos/openssl/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openssl/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openssl/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/openssl/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/openssl/openssl/languages","stargazers_url":"https://api.github.com/repos/openssl/openssl/stargazers","contributors_url":"https://api.github.com/repos/openssl/openssl/contributors","subscribers_url":"https://api.github.com/repos/openssl/openssl/subscribers","subscription_url":"https://api.github.com/repos/openssl/openssl/subscription","commits_url":"https://api.github.com/repos/openssl/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/openssl/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/openssl/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/openssl/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/openssl/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/openssl/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openssl/openssl/merges","archive_url":"https://api.github.com/repos/openssl/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openssl/openssl/downloads","issues_url":"https://api.github.com/repos/openssl/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/openssl/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/openssl/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/openssl/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openssl/openssl/labels{/name}","releases_url":"https://api.github.com/repos/openssl/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/openssl/openssl/deployments","created_at":"2013-01-15T22:34:48Z","updated_at":"2016-03-08T19:38:57Z","pushed_at":"2016-03-09T01:22:47Z","git_url":"git://github.com/openssl/openssl.git","ssh_url":"git@github.com:openssl/openssl.git","clone_url":"https://github.com/openssl/openssl.git","svn_url":"https://github.com/openssl/openssl","homepage":"https://www.openssl.org","size":91850,"stargazers_count":2249,"watchers_count":2249,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1299,"mirror_url":null,"open_issues_count":138,"forks":1299,"open_issues":138,"watchers":2249,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/791"},"html":{"href":"https://github.com/openssl/openssl/pull/791"},"issue":{"href":"https://api.github.com/repos/openssl/openssl/issues/791"},"comments":{"href":"https://api.github.com/repos/openssl/openssl/issues/791/comments"},"review_comments":{"href":"https://api.github.com/repos/openssl/openssl/pulls/791/comments"},"review_comment":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openssl/openssl/pulls/791/commits"},"statuses":{"href":"https://api.github.com/repos/openssl/openssl/statuses/11989b95ad1cb96707b2b7c6efe326477f94a888"}}}}