{"action":"created","comment":{"url":"https://api.github.com/repos/apache/struts/pulls/comments/50081302","id":50081302,"diff_hunk":"@@ -777,11 +777,21 @@ protected Class verifyResultType(String className, Location loc) {\n                 }\n                 params.putAll(resultParams);\n \n-                ResultConfig resultConfig = new ResultConfig.Builder(resultName, resultClass)\n-                        .addParams(params)\n-                        .location(DomHelper.getLocationObject(element))\n-                        .build();\n-                results.put(resultConfig.getName(), resultConfig);\n+                Set<String> resultNamesSet;\n+                if (\",\".equals(resultName.trim())) {\n+                    resultNamesSet = new HashSet<>(1);\n+                    resultNamesSet.add(resultName);","path":"core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java","position":12,"original_position":12,"commit_id":"087cf610abcd262980a41c30a2f9360aa3f416e1","original_commit_id":"087cf610abcd262980a41c30a2f9360aa3f416e1","user":{"login":"lukaszlenart","id":170103,"avatar_url":"https://avatars.githubusercontent.com/u/170103?v=3","gravatar_id":"","url":"https://api.github.com/users/lukaszlenart","html_url":"https://github.com/lukaszlenart","followers_url":"https://api.github.com/users/lukaszlenart/followers","following_url":"https://api.github.com/users/lukaszlenart/following{/other_user}","gists_url":"https://api.github.com/users/lukaszlenart/gists{/gist_id}","starred_url":"https://api.github.com/users/lukaszlenart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukaszlenart/subscriptions","organizations_url":"https://api.github.com/users/lukaszlenart/orgs","repos_url":"https://api.github.com/users/lukaszlenart/repos","events_url":"https://api.github.com/users/lukaszlenart/events{/privacy}","received_events_url":"https://api.github.com/users/lukaszlenart/received_events","type":"User","site_admin":false},"body":"Why not just do it this way instead of this `if..else`?\r\n`resultNamesSet = TextParseUtil.commaDelimitedStringToSet(resultName);`","created_at":"2016-01-19T07:53:11Z","updated_at":"2016-01-19T07:53:11Z","html_url":"https://github.com/apache/struts/pull/75#discussion_r50081302","pull_request_url":"https://api.github.com/repos/apache/struts/pulls/75","_links":{"self":{"href":"https://api.github.com/repos/apache/struts/pulls/comments/50081302"},"html":{"href":"https://github.com/apache/struts/pull/75#discussion_r50081302"},"pull_request":{"href":"https://api.github.com/repos/apache/struts/pulls/75"}}},"pull_request":{"url":"https://api.github.com/repos/apache/struts/pulls/75","id":56382311,"html_url":"https://github.com/apache/struts/pull/75","diff_url":"https://github.com/apache/struts/pull/75.diff","patch_url":"https://github.com/apache/struts/pull/75.patch","issue_url":"https://api.github.com/repos/apache/struts/issues/75","number":75,"state":"open","locked":false,"title":"WW-4590 - Allow to use multiple names in result","user":{"login":"aleksandr-m","id":5055566,"avatar_url":"https://avatars.githubusercontent.com/u/5055566?v=3","gravatar_id":"","url":"https://api.github.com/users/aleksandr-m","html_url":"https://github.com/aleksandr-m","followers_url":"https://api.github.com/users/aleksandr-m/followers","following_url":"https://api.github.com/users/aleksandr-m/following{/other_user}","gists_url":"https://api.github.com/users/aleksandr-m/gists{/gist_id}","starred_url":"https://api.github.com/users/aleksandr-m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aleksandr-m/subscriptions","organizations_url":"https://api.github.com/users/aleksandr-m/orgs","repos_url":"https://api.github.com/users/aleksandr-m/repos","events_url":"https://api.github.com/users/aleksandr-m/events{/privacy}","received_events_url":"https://api.github.com/users/aleksandr-m/received_events","type":"User","site_admin":false},"body":"Allow to use multiple values in `result` tag `name` attribute and in `Result` annotation `name`.\r\n\r\nSo this typical configuration:\r\n\r\n```\r\n<action name=\"save\">\r\n    <result>success.jsp</result>\r\n    <result name=\"error\">input-form.jsp</result>\r\n    <result name=\"input\">input-form.jsp</result>\r\n</action>\r\n```\r\n\r\nCan be shorten to that:\r\n\r\n```\r\n<action name=\"save\">\r\n    <result>success.jsp</result>\r\n    <result name=\"error, input\">input-form.jsp</result>\r\n</action>\r\n```\r\n\r\nAnd this annotations:\r\n\r\n```\r\n@Action(results = {\r\n    @Result(name=\"error\", location=\"input-form.jsp\"),\r\n    @Result(name=\"input\", location=\"input-form.jsp\"),\r\n    @Result(name=\"success\", location=\"success.jsp\")\r\n})\r\n```\r\n\r\nTo that:\r\n\r\n```\r\n@Action(results = {\r\n    @Result(name=\"error, input\", location=\"input-form.jsp\"),\r\n    @Result(name=\"success\", location=\"success.jsp\")\r\n})\r\n```","created_at":"2016-01-18T19:27:19Z","updated_at":"2016-01-19T07:53:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f9f637cc1ea271d6eda44dc4e5a48e39f0b71ef","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/struts/pulls/75/commits","review_comments_url":"https://api.github.com/repos/apache/struts/pulls/75/comments","review_comment_url":"https://api.github.com/repos/apache/struts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/struts/issues/75/comments","statuses_url":"https://api.github.com/repos/apache/struts/statuses/087cf610abcd262980a41c30a2f9360aa3f416e1","head":{"label":"aleksandr-m:feature/multiple_result_names","ref":"feature/multiple_result_names","sha":"087cf610abcd262980a41c30a2f9360aa3f416e1","user":{"login":"aleksandr-m","id":5055566,"avatar_url":"https://avatars.githubusercontent.com/u/5055566?v=3","gravatar_id":"","url":"https://api.github.com/users/aleksandr-m","html_url":"https://github.com/aleksandr-m","followers_url":"https://api.github.com/users/aleksandr-m/followers","following_url":"https://api.github.com/users/aleksandr-m/following{/other_user}","gists_url":"https://api.github.com/users/aleksandr-m/gists{/gist_id}","starred_url":"https://api.github.com/users/aleksandr-m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aleksandr-m/subscriptions","organizations_url":"https://api.github.com/users/aleksandr-m/orgs","repos_url":"https://api.github.com/users/aleksandr-m/repos","events_url":"https://api.github.com/users/aleksandr-m/events{/privacy}","received_events_url":"https://api.github.com/users/aleksandr-m/received_events","type":"User","site_admin":false},"repo":{"id":19788383,"name":"struts","full_name":"aleksandr-m/struts","owner":{"login":"aleksandr-m","id":5055566,"avatar_url":"https://avatars.githubusercontent.com/u/5055566?v=3","gravatar_id":"","url":"https://api.github.com/users/aleksandr-m","html_url":"https://github.com/aleksandr-m","followers_url":"https://api.github.com/users/aleksandr-m/followers","following_url":"https://api.github.com/users/aleksandr-m/following{/other_user}","gists_url":"https://api.github.com/users/aleksandr-m/gists{/gist_id}","starred_url":"https://api.github.com/users/aleksandr-m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aleksandr-m/subscriptions","organizations_url":"https://api.github.com/users/aleksandr-m/orgs","repos_url":"https://api.github.com/users/aleksandr-m/repos","events_url":"https://api.github.com/users/aleksandr-m/events{/privacy}","received_events_url":"https://api.github.com/users/aleksandr-m/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aleksandr-m/struts","description":"Mirror of Apache Struts","fork":true,"url":"https://api.github.com/repos/aleksandr-m/struts","forks_url":"https://api.github.com/repos/aleksandr-m/struts/forks","keys_url":"https://api.github.com/repos/aleksandr-m/struts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aleksandr-m/struts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aleksandr-m/struts/teams","hooks_url":"https://api.github.com/repos/aleksandr-m/struts/hooks","issue_events_url":"https://api.github.com/repos/aleksandr-m/struts/issues/events{/number}","events_url":"https://api.github.com/repos/aleksandr-m/struts/events","assignees_url":"https://api.github.com/repos/aleksandr-m/struts/assignees{/user}","branches_url":"https://api.github.com/repos/aleksandr-m/struts/branches{/branch}","tags_url":"https://api.github.com/repos/aleksandr-m/struts/tags","blobs_url":"https://api.github.com/repos/aleksandr-m/struts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aleksandr-m/struts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aleksandr-m/struts/git/refs{/sha}","trees_url":"https://api.github.com/repos/aleksandr-m/struts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aleksandr-m/struts/statuses/{sha}","languages_url":"https://api.github.com/repos/aleksandr-m/struts/languages","stargazers_url":"https://api.github.com/repos/aleksandr-m/struts/stargazers","contributors_url":"https://api.github.com/repos/aleksandr-m/struts/contributors","subscribers_url":"https://api.github.com/repos/aleksandr-m/struts/subscribers","subscription_url":"https://api.github.com/repos/aleksandr-m/struts/subscription","commits_url":"https://api.github.com/repos/aleksandr-m/struts/commits{/sha}","git_commits_url":"https://api.github.com/repos/aleksandr-m/struts/git/commits{/sha}","comments_url":"https://api.github.com/repos/aleksandr-m/struts/comments{/number}","issue_comment_url":"https://api.github.com/repos/aleksandr-m/struts/issues/comments{/number}","contents_url":"https://api.github.com/repos/aleksandr-m/struts/contents/{+path}","compare_url":"https://api.github.com/repos/aleksandr-m/struts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aleksandr-m/struts/merges","archive_url":"https://api.github.com/repos/aleksandr-m/struts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aleksandr-m/struts/downloads","issues_url":"https://api.github.com/repos/aleksandr-m/struts/issues{/number}","pulls_url":"https://api.github.com/repos/aleksandr-m/struts/pulls{/number}","milestones_url":"https://api.github.com/repos/aleksandr-m/struts/milestones{/number}","notifications_url":"https://api.github.com/repos/aleksandr-m/struts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aleksandr-m/struts/labels{/name}","releases_url":"https://api.github.com/repos/aleksandr-m/struts/releases{/id}","created_at":"2014-05-14T17:05:30Z","updated_at":"2016-01-13T18:07:57Z","pushed_at":"2016-01-18T19:24:25Z","git_url":"git://github.com/aleksandr-m/struts.git","ssh_url":"git@github.com:aleksandr-m/struts.git","clone_url":"https://github.com/aleksandr-m/struts.git","svn_url":"https://github.com/aleksandr-m/struts","homepage":null,"size":66418,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"d923c7c4f2c7a674949c623350cd8948869ea987","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":15928650,"name":"struts","full_name":"apache/struts","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/struts","description":"Mirror of Apache Struts","fork":false,"url":"https://api.github.com/repos/apache/struts","forks_url":"https://api.github.com/repos/apache/struts/forks","keys_url":"https://api.github.com/repos/apache/struts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/struts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/struts/teams","hooks_url":"https://api.github.com/repos/apache/struts/hooks","issue_events_url":"https://api.github.com/repos/apache/struts/issues/events{/number}","events_url":"https://api.github.com/repos/apache/struts/events","assignees_url":"https://api.github.com/repos/apache/struts/assignees{/user}","branches_url":"https://api.github.com/repos/apache/struts/branches{/branch}","tags_url":"https://api.github.com/repos/apache/struts/tags","blobs_url":"https://api.github.com/repos/apache/struts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/struts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/struts/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/struts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/struts/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/struts/languages","stargazers_url":"https://api.github.com/repos/apache/struts/stargazers","contributors_url":"https://api.github.com/repos/apache/struts/contributors","subscribers_url":"https://api.github.com/repos/apache/struts/subscribers","subscription_url":"https://api.github.com/repos/apache/struts/subscription","commits_url":"https://api.github.com/repos/apache/struts/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/struts/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/struts/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/struts/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/struts/contents/{+path}","compare_url":"https://api.github.com/repos/apache/struts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/struts/merges","archive_url":"https://api.github.com/repos/apache/struts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/struts/downloads","issues_url":"https://api.github.com/repos/apache/struts/issues{/number}","pulls_url":"https://api.github.com/repos/apache/struts/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/struts/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/struts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/struts/labels{/name}","releases_url":"https://api.github.com/repos/apache/struts/releases{/id}","created_at":"2014-01-15T08:00:08Z","updated_at":"2016-01-19T03:46:40Z","pushed_at":"2016-01-19T07:47:52Z","git_url":"git://github.com/apache/struts.git","ssh_url":"git@github.com:apache/struts.git","clone_url":"https://github.com/apache/struts.git","svn_url":"https://github.com/apache/struts","homepage":null,"size":67374,"stargazers_count":319,"watchers_count":319,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":305,"mirror_url":"git://git.apache.org/struts.git","open_issues_count":5,"forks":305,"open_issues":5,"watchers":319,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/struts/pulls/75"},"html":{"href":"https://github.com/apache/struts/pull/75"},"issue":{"href":"https://api.github.com/repos/apache/struts/issues/75"},"comments":{"href":"https://api.github.com/repos/apache/struts/issues/75/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/struts/pulls/75/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/struts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/struts/pulls/75/commits"},"statuses":{"href":"https://api.github.com/repos/apache/struts/statuses/087cf610abcd262980a41c30a2f9360aa3f416e1"}}}}