{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments/91055674","pull_request_review_id":11565475,"id":91055674,"diff_hunk":"@@ -40,6 +41,18 @@ for router in $routers; do\n     # delete old routers namespaces. Unassignment didn't delete the namespaces\n     ssh $old_host ip netns delete qrouter-$router\n \n+    # wait for router ports to migrate\n+    ports=$(neutron router-port-list $router -f value -c id)\n+    for port in $ports; do\n+        port_host=$(neutron port-show $port -c binding:host_id -f value)\n+        num_tries=60\n+        while [ $port_host != $hostname ] || [ $num_tries -gt 0 ]; do\n+            sleep 1\n+            num_tries=$(( $num_tries - 1 ))\n+            port_host=$(neutron port-show $router -c binding:host_id -f value)","path":"chef/cookbooks/crowbar/templates/default/crowbar-router-migration.sh.erb","position":22,"original_position":22,"commit_id":"42b092630bbcf9ff095c55e888f2d2d89680b390","original_commit_id":"42b092630bbcf9ff095c55e888f2d2d89680b390","user":{"login":"jsuchome","id":910000,"avatar_url":"https://avatars.githubusercontent.com/u/910000?v=3","gravatar_id":"","url":"https://api.github.com/users/jsuchome","html_url":"https://github.com/jsuchome","followers_url":"https://api.github.com/users/jsuchome/followers","following_url":"https://api.github.com/users/jsuchome/following{/other_user}","gists_url":"https://api.github.com/users/jsuchome/gists{/gist_id}","starred_url":"https://api.github.com/users/jsuchome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsuchome/subscriptions","organizations_url":"https://api.github.com/users/jsuchome/orgs","repos_url":"https://api.github.com/users/jsuchome/repos","events_url":"https://api.github.com/users/jsuchome/events{/privacy}","received_events_url":"https://api.github.com/users/jsuchome/received_events","type":"User","site_admin":false},"body":"`$port` ?","created_at":"2016-12-06T11:04:10Z","updated_at":"2016-12-06T11:04:11Z","html_url":"https://github.com/crowbar/crowbar-core/pull/853#discussion_r91055674","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/853","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments/91055674"},"html":{"href":"https://github.com/crowbar/crowbar-core/pull/853#discussion_r91055674"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/853"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/853","id":96525201,"html_url":"https://github.com/crowbar/crowbar-core/pull/853","diff_url":"https://github.com/crowbar/crowbar-core/pull/853.diff","patch_url":"https://github.com/crowbar/crowbar-core/pull/853.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/853","number":853,"state":"open","locked":false,"title":"Make router migration synchronous","user":{"login":"abel-navarro","id":1333236,"avatar_url":"https://avatars.githubusercontent.com/u/1333236?v=3","gravatar_id":"","url":"https://api.github.com/users/abel-navarro","html_url":"https://github.com/abel-navarro","followers_url":"https://api.github.com/users/abel-navarro/followers","following_url":"https://api.github.com/users/abel-navarro/following{/other_user}","gists_url":"https://api.github.com/users/abel-navarro/gists{/gist_id}","starred_url":"https://api.github.com/users/abel-navarro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abel-navarro/subscriptions","organizations_url":"https://api.github.com/users/abel-navarro/orgs","repos_url":"https://api.github.com/users/abel-navarro/repos","events_url":"https://api.github.com/users/abel-navarro/events{/privacy}","received_events_url":"https://api.github.com/users/abel-navarro/received_events","type":"User","site_admin":false},"body":"The fact that we call to neutron l3-agent-router-add doesn't mean the\r\nactual router migration occurs immediately, although neutron call does.\r\nWhen migrating several routers the phasing adds up which increate the\r\nouttage times.","created_at":"2016-12-05T13:05:27Z","updated_at":"2016-12-06T11:04:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d6a5496728460d85f4a758b7c851585fa9491de","assignee":{"login":"rhafer","id":373399,"avatar_url":"https://avatars.githubusercontent.com/u/373399?v=3","gravatar_id":"","url":"https://api.github.com/users/rhafer","html_url":"https://github.com/rhafer","followers_url":"https://api.github.com/users/rhafer/followers","following_url":"https://api.github.com/users/rhafer/following{/other_user}","gists_url":"https://api.github.com/users/rhafer/gists{/gist_id}","starred_url":"https://api.github.com/users/rhafer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhafer/subscriptions","organizations_url":"https://api.github.com/users/rhafer/orgs","repos_url":"https://api.github.com/users/rhafer/repos","events_url":"https://api.github.com/users/rhafer/events{/privacy}","received_events_url":"https://api.github.com/users/rhafer/received_events","type":"User","site_admin":false},"assignees":[{"login":"rhafer","id":373399,"avatar_url":"https://avatars.githubusercontent.com/u/373399?v=3","gravatar_id":"","url":"https://api.github.com/users/rhafer","html_url":"https://github.com/rhafer","followers_url":"https://api.github.com/users/rhafer/followers","following_url":"https://api.github.com/users/rhafer/following{/other_user}","gists_url":"https://api.github.com/users/rhafer/gists{/gist_id}","starred_url":"https://api.github.com/users/rhafer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhafer/subscriptions","organizations_url":"https://api.github.com/users/rhafer/orgs","repos_url":"https://api.github.com/users/rhafer/repos","events_url":"https://api.github.com/users/rhafer/events{/privacy}","received_events_url":"https://api.github.com/users/rhafer/received_events","type":"User","site_admin":false},{"login":"jsuchome","id":910000,"avatar_url":"https://avatars.githubusercontent.com/u/910000?v=3","gravatar_id":"","url":"https://api.github.com/users/jsuchome","html_url":"https://github.com/jsuchome","followers_url":"https://api.github.com/users/jsuchome/followers","following_url":"https://api.github.com/users/jsuchome/following{/other_user}","gists_url":"https://api.github.com/users/jsuchome/gists{/gist_id}","starred_url":"https://api.github.com/users/jsuchome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsuchome/subscriptions","organizations_url":"https://api.github.com/users/jsuchome/orgs","repos_url":"https://api.github.com/users/jsuchome/repos","events_url":"https://api.github.com/users/jsuchome/events{/privacy}","received_events_url":"https://api.github.com/users/jsuchome/received_events","type":"User","site_admin":false},{"login":"matelakat","id":1521690,"avatar_url":"https://avatars.githubusercontent.com/u/1521690?v=3","gravatar_id":"","url":"https://api.github.com/users/matelakat","html_url":"https://github.com/matelakat","followers_url":"https://api.github.com/users/matelakat/followers","following_url":"https://api.github.com/users/matelakat/following{/other_user}","gists_url":"https://api.github.com/users/matelakat/gists{/gist_id}","starred_url":"https://api.github.com/users/matelakat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matelakat/subscriptions","organizations_url":"https://api.github.com/users/matelakat/orgs","repos_url":"https://api.github.com/users/matelakat/repos","events_url":"https://api.github.com/users/matelakat/events{/privacy}","received_events_url":"https://api.github.com/users/matelakat/received_events","type":"User","site_admin":false},{"login":"vuntz","id":1758783,"avatar_url":"https://avatars.githubusercontent.com/u/1758783?v=3","gravatar_id":"","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/853/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/853/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/853/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-core/statuses/42b092630bbcf9ff095c55e888f2d2d89680b390","head":{"label":"abel-navarro:sync_router_migration","ref":"sync_router_migration","sha":"42b092630bbcf9ff095c55e888f2d2d89680b390","user":{"login":"abel-navarro","id":1333236,"avatar_url":"https://avatars.githubusercontent.com/u/1333236?v=3","gravatar_id":"","url":"https://api.github.com/users/abel-navarro","html_url":"https://github.com/abel-navarro","followers_url":"https://api.github.com/users/abel-navarro/followers","following_url":"https://api.github.com/users/abel-navarro/following{/other_user}","gists_url":"https://api.github.com/users/abel-navarro/gists{/gist_id}","starred_url":"https://api.github.com/users/abel-navarro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abel-navarro/subscriptions","organizations_url":"https://api.github.com/users/abel-navarro/orgs","repos_url":"https://api.github.com/users/abel-navarro/repos","events_url":"https://api.github.com/users/abel-navarro/events{/privacy}","received_events_url":"https://api.github.com/users/abel-navarro/received_events","type":"User","site_admin":false},"repo":{"id":56769837,"name":"crowbar-core","full_name":"abel-navarro/crowbar-core","owner":{"login":"abel-navarro","id":1333236,"avatar_url":"https://avatars.githubusercontent.com/u/1333236?v=3","gravatar_id":"","url":"https://api.github.com/users/abel-navarro","html_url":"https://github.com/abel-navarro","followers_url":"https://api.github.com/users/abel-navarro/followers","following_url":"https://api.github.com/users/abel-navarro/following{/other_user}","gists_url":"https://api.github.com/users/abel-navarro/gists{/gist_id}","starred_url":"https://api.github.com/users/abel-navarro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abel-navarro/subscriptions","organizations_url":"https://api.github.com/users/abel-navarro/orgs","repos_url":"https://api.github.com/users/abel-navarro/repos","events_url":"https://api.github.com/users/abel-navarro/events{/privacy}","received_events_url":"https://api.github.com/users/abel-navarro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abel-navarro/crowbar-core","description":"Core deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/abel-navarro/crowbar-core","forks_url":"https://api.github.com/repos/abel-navarro/crowbar-core/forks","keys_url":"https://api.github.com/repos/abel-navarro/crowbar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abel-navarro/crowbar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abel-navarro/crowbar-core/teams","hooks_url":"https://api.github.com/repos/abel-navarro/crowbar-core/hooks","issue_events_url":"https://api.github.com/repos/abel-navarro/crowbar-core/issues/events{/number}","events_url":"https://api.github.com/repos/abel-navarro/crowbar-core/events","assignees_url":"https://api.github.com/repos/abel-navarro/crowbar-core/assignees{/user}","branches_url":"https://api.github.com/repos/abel-navarro/crowbar-core/branches{/branch}","tags_url":"https://api.github.com/repos/abel-navarro/crowbar-core/tags","blobs_url":"https://api.github.com/repos/abel-navarro/crowbar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abel-navarro/crowbar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abel-navarro/crowbar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/abel-navarro/crowbar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abel-navarro/crowbar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/abel-navarro/crowbar-core/languages","stargazers_url":"https://api.github.com/repos/abel-navarro/crowbar-core/stargazers","contributors_url":"https://api.github.com/repos/abel-navarro/crowbar-core/contributors","subscribers_url":"https://api.github.com/repos/abel-navarro/crowbar-core/subscribers","subscription_url":"https://api.github.com/repos/abel-navarro/crowbar-core/subscription","commits_url":"https://api.github.com/repos/abel-navarro/crowbar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/abel-navarro/crowbar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/abel-navarro/crowbar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/abel-navarro/crowbar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/abel-navarro/crowbar-core/contents/{+path}","compare_url":"https://api.github.com/repos/abel-navarro/crowbar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abel-navarro/crowbar-core/merges","archive_url":"https://api.github.com/repos/abel-navarro/crowbar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abel-navarro/crowbar-core/downloads","issues_url":"https://api.github.com/repos/abel-navarro/crowbar-core/issues{/number}","pulls_url":"https://api.github.com/repos/abel-navarro/crowbar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/abel-navarro/crowbar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/abel-navarro/crowbar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abel-navarro/crowbar-core/labels{/name}","releases_url":"https://api.github.com/repos/abel-navarro/crowbar-core/releases{/id}","deployments_url":"https://api.github.com/repos/abel-navarro/crowbar-core/deployments","created_at":"2016-04-21T11:57:42Z","updated_at":"2016-04-21T11:57:44Z","pushed_at":"2016-12-05T14:39:53Z","git_url":"git://github.com/abel-navarro/crowbar-core.git","ssh_url":"git@github.com:abel-navarro/crowbar-core.git","clone_url":"https://github.com/abel-navarro/crowbar-core.git","svn_url":"https://github.com/abel-navarro/crowbar-core","homepage":null,"size":106430,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"9a21ae54c4c1af62de80846a5a4fa8df5e70b1c6","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39003227,"name":"crowbar-core","full_name":"crowbar/crowbar-core","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-core","description":"Core deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-core","forks_url":"https://api.github.com/repos/crowbar/crowbar-core/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-core/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-core/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-core/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-core/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-core/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-core/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-core/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-core/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-core/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-core/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-core/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-core/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-core/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-core/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-core/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-core/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-core/releases{/id}","deployments_url":"https://api.github.com/repos/crowbar/crowbar-core/deployments","created_at":"2015-07-13T09:31:28Z","updated_at":"2016-11-11T19:16:44Z","pushed_at":"2016-12-06T10:59:22Z","git_url":"git://github.com/crowbar/crowbar-core.git","ssh_url":"git@github.com:crowbar/crowbar-core.git","clone_url":"https://github.com/crowbar/crowbar-core.git","svn_url":"https://github.com/crowbar/crowbar-core","homepage":null,"size":121962,"stargazers_count":9,"watchers_count":9,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":49,"forks":38,"open_issues":49,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/853"},"html":{"href":"https://github.com/crowbar/crowbar-core/pull/853"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-core/issues/853"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-core/issues/853/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/853/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/853/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-core/statuses/42b092630bbcf9ff095c55e888f2d2d89680b390"}}}}
{"actor":{"display_login":"jsuchome"}}