{"action":"created","issue":{"url":"https://api.github.com/repos/imperugo/StackExchange.Redis.Extensions/issues/80","repository_url":"https://api.github.com/repos/imperugo/StackExchange.Redis.Extensions","labels_url":"https://api.github.com/repos/imperugo/StackExchange.Redis.Extensions/issues/80/labels{/name}","comments_url":"https://api.github.com/repos/imperugo/StackExchange.Redis.Extensions/issues/80/comments","events_url":"https://api.github.com/repos/imperugo/StackExchange.Redis.Extensions/issues/80/events","html_url":"https://github.com/imperugo/StackExchange.Redis.Extensions/pull/80","id":173636369,"number":80,"title":"Move the project to .net Core 1","user":{"login":"EugeneKrapivin","id":8215989,"avatar_url":"https://avatars.githubusercontent.com/u/8215989?v=3","gravatar_id":"","url":"https://api.github.com/users/EugeneKrapivin","html_url":"https://github.com/EugeneKrapivin","followers_url":"https://api.github.com/users/EugeneKrapivin/followers","following_url":"https://api.github.com/users/EugeneKrapivin/following{/other_user}","gists_url":"https://api.github.com/users/EugeneKrapivin/gists{/gist_id}","starred_url":"https://api.github.com/users/EugeneKrapivin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EugeneKrapivin/subscriptions","organizations_url":"https://api.github.com/users/EugeneKrapivin/orgs","repos_url":"https://api.github.com/users/EugeneKrapivin/repos","events_url":"https://api.github.com/users/EugeneKrapivin/events{/privacy}","received_events_url":"https://api.github.com/users/EugeneKrapivin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-08-28T08:43:33Z","updated_at":"2016-09-25T13:14:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/imperugo/StackExchange.Redis.Extensions/pulls/80","html_url":"https://github.com/imperugo/StackExchange.Redis.Extensions/pull/80","diff_url":"https://github.com/imperugo/StackExchange.Redis.Extensions/pull/80.diff","patch_url":"https://github.com/imperugo/StackExchange.Redis.Extensions/pull/80.patch"},"body":"[#37](https://github.com/imperugo/StackExchange.Redis.Extensions/issues/37)\r\n\r\nAs dotnet core exited RC and entered RTM I've began porting the library to .net core.\r\n\r\nSince `StackExchange.Redis` is still in alpha we are using the most recent alpha version.\r\n\r\n**Currently ported:**\r\n1. Core project was converted and uses [NETStandard1.6](https://github.com/dotnet/corefx/blob/master/Documentation/architecture/net-platform-standard.md#mapping-the-net-platform-standard-to-platforms) which should map to `.net Core 1` and `.net Framework 4.6.3`\r\n2. `Newtonsoft` serializer is ported and uses most recent stable version.\r\n3. `ProtoBuf` serializer is ported and uses most recent stable version.\r\n4. `MsgPack` serializer is ported and uses most recent stable version (0.8.0).\r\n5. `Jil` is currently **not** supported since `Jil` is not yet complaint with `NETStandard` at all.\r\n\r\nI've added extension methods on all serializers to register on the `RedisExtensionsConfiguration` object that is passed to them from the `AddRedisExtension`s method from the `Core` package extensions as discussed on [#37](https://github.com/imperugo/StackExchange.Redis.Extensions/issues/37).\r\n```\r\nservices.AddRedisExtensions(config => // RedisExtensionsConfigurations\r\n{\r\n    config.ConfigurationOptions = new ConfigurationOptions\r\n    {\r\n        /* configure ConnectionMultiplexer */\r\n    };\r\n\r\n    config.UseNewtonsoft(settings => \r\n        {\r\n        /* configure newtonsoft serializer settings */\r\n    });\r\n\r\n    config.ServerEnumerationStrategy = new ServerEnumerationStrategy\r\n    {\r\n        /* configure enumeration strategy */\r\n    };\r\n);\r\n```\r\n\r\nI've removed the OS assertion in the `Info_Should_Return_Valid_Information` test because it assumes that the server is sitting on windows OS, which doesn't hold at all if you run it on Docker hosted on windows or on a remote linux machine.\r\n\r\nAll tests pass, except the skipped test (pub/sub test)."},"comment":{"url":"https://api.github.com/repos/imperugo/StackExchange.Redis.Extensions/issues/comments/249421277","html_url":"https://github.com/imperugo/StackExchange.Redis.Extensions/pull/80#issuecomment-249421277","issue_url":"https://api.github.com/repos/imperugo/StackExchange.Redis.Extensions/issues/80","id":249421277,"user":{"login":"EugeneKrapivin","id":8215989,"avatar_url":"https://avatars.githubusercontent.com/u/8215989?v=3","gravatar_id":"","url":"https://api.github.com/users/EugeneKrapivin","html_url":"https://github.com/EugeneKrapivin","followers_url":"https://api.github.com/users/EugeneKrapivin/followers","following_url":"https://api.github.com/users/EugeneKrapivin/following{/other_user}","gists_url":"https://api.github.com/users/EugeneKrapivin/gists{/gist_id}","starred_url":"https://api.github.com/users/EugeneKrapivin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EugeneKrapivin/subscriptions","organizations_url":"https://api.github.com/users/EugeneKrapivin/orgs","repos_url":"https://api.github.com/users/EugeneKrapivin/repos","events_url":"https://api.github.com/users/EugeneKrapivin/events{/privacy}","received_events_url":"https://api.github.com/users/EugeneKrapivin/received_events","type":"User","site_admin":false},"created_at":"2016-09-25T13:14:19Z","updated_at":"2016-09-25T13:14:19Z","body":"@imperugo We could check if it is feasible to port `Jil` ourselves.\r\nanother obvious options is to - not support `Jil` from day 1, since the serializers are packages separately.\r\n\r\nRegarding the update, I'll check backward compatibility to `.Net framework 4.5.1` and check if we can support it. I think `NetStandard1.6` currently supports `.net core 1` and `.Net framework 4.6.3`.\r\nI think all libraries we currently support"}}
{"actor":{"display_login":"EugeneKrapivin"}}