{"action":"created","comment":{"url":"https://api.github.com/repos/stack-of-tasks/pinocchio/pulls/comments/55005994","id":55005994,"diff_hunk":"@@ -133,34 +139,37 @@ namespace se3\n           throw std::invalid_argument(exception_message);\n         }\n \n-      } // if(link->inertial)\n+      }\n       \n       BOOST_FOREACH(::urdf::LinkConstPtr child,link->child_links)\n       {\n-        parseTreeForGeom(child, model, geom_model, meshRootDir, rootJointAdded);\n+        parseTreeForGeom(child, model, geom_model, package_dirs, rootJointAdded);\n       }\n+\n     }\n \n-    GeometryModel buildGeom(const Model & model,\n-                            const std::string & filename,\n-                            const std::string & meshRootDir)\n+\n+    inline GeometryModel buildGeom(const Model & model,\n+                                  const std::string & filename,\n+                                  const std::vector<std::string> & package_dirs,\n+                                  const bool root_joint)","path":"src/multibody/parser/urdf-with-geometry.hxx","position":92,"original_position":92,"commit_id":"f9bdd9c9a0557d4a97910dd22bb3ad10ea79c687","original_commit_id":"f9bdd9c9a0557d4a97910dd22bb3ad10ea79c687","user":{"login":"jcarpent","id":1567317,"avatar_url":"https://avatars.githubusercontent.com/u/1567317?v=3","gravatar_id":"","url":"https://api.github.com/users/jcarpent","html_url":"https://github.com/jcarpent","followers_url":"https://api.github.com/users/jcarpent/followers","following_url":"https://api.github.com/users/jcarpent/following{/other_user}","gists_url":"https://api.github.com/users/jcarpent/gists{/gist_id}","starred_url":"https://api.github.com/users/jcarpent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcarpent/subscriptions","organizations_url":"https://api.github.com/users/jcarpent/orgs","repos_url":"https://api.github.com/users/jcarpent/repos","events_url":"https://api.github.com/users/jcarpent/events{/privacy}","received_events_url":"https://api.github.com/users/jcarpent/received_events","type":"User","site_admin":false},"body":"You don't need to give this information, as your are just adding meshes to supporting body so supporting joint.","created_at":"2016-03-04T09:12:21Z","updated_at":"2016-03-04T09:12:21Z","html_url":"https://github.com/stack-of-tasks/pinocchio/pull/110#discussion_r55005994","pull_request_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/pulls/110","_links":{"self":{"href":"https://api.github.com/repos/stack-of-tasks/pinocchio/pulls/comments/55005994"},"html":{"href":"https://github.com/stack-of-tasks/pinocchio/pull/110#discussion_r55005994"},"pull_request":{"href":"https://api.github.com/repos/stack-of-tasks/pinocchio/pulls/110"}}},"pull_request":{"url":"https://api.github.com/repos/stack-of-tasks/pinocchio/pulls/110","id":61218465,"html_url":"https://github.com/stack-of-tasks/pinocchio/pull/110","diff_url":"https://github.com/stack-of-tasks/pinocchio/pull/110.diff","patch_url":"https://github.com/stack-of-tasks/pinocchio/pull/110.patch","issue_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/issues/110","number":110,"state":"open","locked":false,"title":"Topic/parse ros path","user":{"login":"fvalenza","id":7045681,"avatar_url":"https://avatars.githubusercontent.com/u/7045681?v=3","gravatar_id":"","url":"https://api.github.com/users/fvalenza","html_url":"https://github.com/fvalenza","followers_url":"https://api.github.com/users/fvalenza/followers","following_url":"https://api.github.com/users/fvalenza/following{/other_user}","gists_url":"https://api.github.com/users/fvalenza/gists{/gist_id}","starred_url":"https://api.github.com/users/fvalenza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fvalenza/subscriptions","organizations_url":"https://api.github.com/users/fvalenza/orgs","repos_url":"https://api.github.com/users/fvalenza/repos","events_url":"https://api.github.com/users/fvalenza/events{/privacy}","received_events_url":"https://api.github.com/users/fvalenza/received_events","type":"User","site_admin":false},"body":"Fixed a bug in Geometry parser when parsing twice the urdf tree not in a row.\r\n\r\nAdded a function to retrieve the list of package directories from the environment variable ROS_PACKAGE_PATH.\r\n\r\nThe idea is when searching for mesh, replace package:// by one of this path. If no one is found, we try to open a file that doesn't exist in loadPolyhedronFromResource() then it returns an exception (\"Could not open ressource\")\r\n\r\n","created_at":"2016-03-01T10:03:42Z","updated_at":"2016-03-04T09:12:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66544b2d4ee9dfa473650fb5855178ebe5b32b7a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/pulls/110/commits","review_comments_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/pulls/110/comments","review_comment_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/issues/110/comments","statuses_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/statuses/f9bdd9c9a0557d4a97910dd22bb3ad10ea79c687","head":{"label":"fvalenza:topic/parse-ros-path","ref":"topic/parse-ros-path","sha":"f9bdd9c9a0557d4a97910dd22bb3ad10ea79c687","user":{"login":"fvalenza","id":7045681,"avatar_url":"https://avatars.githubusercontent.com/u/7045681?v=3","gravatar_id":"","url":"https://api.github.com/users/fvalenza","html_url":"https://github.com/fvalenza","followers_url":"https://api.github.com/users/fvalenza/followers","following_url":"https://api.github.com/users/fvalenza/following{/other_user}","gists_url":"https://api.github.com/users/fvalenza/gists{/gist_id}","starred_url":"https://api.github.com/users/fvalenza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fvalenza/subscriptions","organizations_url":"https://api.github.com/users/fvalenza/orgs","repos_url":"https://api.github.com/users/fvalenza/repos","events_url":"https://api.github.com/users/fvalenza/events{/privacy}","received_events_url":"https://api.github.com/users/fvalenza/received_events","type":"User","site_admin":false},"repo":{"id":34853975,"name":"pinocchio","full_name":"fvalenza/pinocchio","owner":{"login":"fvalenza","id":7045681,"avatar_url":"https://avatars.githubusercontent.com/u/7045681?v=3","gravatar_id":"","url":"https://api.github.com/users/fvalenza","html_url":"https://github.com/fvalenza","followers_url":"https://api.github.com/users/fvalenza/followers","following_url":"https://api.github.com/users/fvalenza/following{/other_user}","gists_url":"https://api.github.com/users/fvalenza/gists{/gist_id}","starred_url":"https://api.github.com/users/fvalenza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fvalenza/subscriptions","organizations_url":"https://api.github.com/users/fvalenza/orgs","repos_url":"https://api.github.com/users/fvalenza/repos","events_url":"https://api.github.com/users/fvalenza/events{/privacy}","received_events_url":"https://api.github.com/users/fvalenza/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fvalenza/pinocchio","description":"Dynamic computations using Spatial Algebra","fork":true,"url":"https://api.github.com/repos/fvalenza/pinocchio","forks_url":"https://api.github.com/repos/fvalenza/pinocchio/forks","keys_url":"https://api.github.com/repos/fvalenza/pinocchio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fvalenza/pinocchio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fvalenza/pinocchio/teams","hooks_url":"https://api.github.com/repos/fvalenza/pinocchio/hooks","issue_events_url":"https://api.github.com/repos/fvalenza/pinocchio/issues/events{/number}","events_url":"https://api.github.com/repos/fvalenza/pinocchio/events","assignees_url":"https://api.github.com/repos/fvalenza/pinocchio/assignees{/user}","branches_url":"https://api.github.com/repos/fvalenza/pinocchio/branches{/branch}","tags_url":"https://api.github.com/repos/fvalenza/pinocchio/tags","blobs_url":"https://api.github.com/repos/fvalenza/pinocchio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fvalenza/pinocchio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fvalenza/pinocchio/git/refs{/sha}","trees_url":"https://api.github.com/repos/fvalenza/pinocchio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fvalenza/pinocchio/statuses/{sha}","languages_url":"https://api.github.com/repos/fvalenza/pinocchio/languages","stargazers_url":"https://api.github.com/repos/fvalenza/pinocchio/stargazers","contributors_url":"https://api.github.com/repos/fvalenza/pinocchio/contributors","subscribers_url":"https://api.github.com/repos/fvalenza/pinocchio/subscribers","subscription_url":"https://api.github.com/repos/fvalenza/pinocchio/subscription","commits_url":"https://api.github.com/repos/fvalenza/pinocchio/commits{/sha}","git_commits_url":"https://api.github.com/repos/fvalenza/pinocchio/git/commits{/sha}","comments_url":"https://api.github.com/repos/fvalenza/pinocchio/comments{/number}","issue_comment_url":"https://api.github.com/repos/fvalenza/pinocchio/issues/comments{/number}","contents_url":"https://api.github.com/repos/fvalenza/pinocchio/contents/{+path}","compare_url":"https://api.github.com/repos/fvalenza/pinocchio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fvalenza/pinocchio/merges","archive_url":"https://api.github.com/repos/fvalenza/pinocchio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fvalenza/pinocchio/downloads","issues_url":"https://api.github.com/repos/fvalenza/pinocchio/issues{/number}","pulls_url":"https://api.github.com/repos/fvalenza/pinocchio/pulls{/number}","milestones_url":"https://api.github.com/repos/fvalenza/pinocchio/milestones{/number}","notifications_url":"https://api.github.com/repos/fvalenza/pinocchio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fvalenza/pinocchio/labels{/name}","releases_url":"https://api.github.com/repos/fvalenza/pinocchio/releases{/id}","deployments_url":"https://api.github.com/repos/fvalenza/pinocchio/deployments","created_at":"2015-04-30T12:46:31Z","updated_at":"2015-04-30T12:46:34Z","pushed_at":"2016-03-03T15:06:30Z","git_url":"git://github.com/fvalenza/pinocchio.git","ssh_url":"git@github.com:fvalenza/pinocchio.git","clone_url":"https://github.com/fvalenza/pinocchio.git","svn_url":"https://github.com/fvalenza/pinocchio","homepage":null,"size":6556,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stack-of-tasks:devel","ref":"devel","sha":"f56121237a08dc93f2ac82596c59cdee63381a4f","user":{"login":"stack-of-tasks","id":3725101,"avatar_url":"https://avatars.githubusercontent.com/u/3725101?v=3","gravatar_id":"","url":"https://api.github.com/users/stack-of-tasks","html_url":"https://github.com/stack-of-tasks","followers_url":"https://api.github.com/users/stack-of-tasks/followers","following_url":"https://api.github.com/users/stack-of-tasks/following{/other_user}","gists_url":"https://api.github.com/users/stack-of-tasks/gists{/gist_id}","starred_url":"https://api.github.com/users/stack-of-tasks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stack-of-tasks/subscriptions","organizations_url":"https://api.github.com/users/stack-of-tasks/orgs","repos_url":"https://api.github.com/users/stack-of-tasks/repos","events_url":"https://api.github.com/users/stack-of-tasks/events{/privacy}","received_events_url":"https://api.github.com/users/stack-of-tasks/received_events","type":"Organization","site_admin":false},"repo":{"id":24897645,"name":"pinocchio","full_name":"stack-of-tasks/pinocchio","owner":{"login":"stack-of-tasks","id":3725101,"avatar_url":"https://avatars.githubusercontent.com/u/3725101?v=3","gravatar_id":"","url":"https://api.github.com/users/stack-of-tasks","html_url":"https://github.com/stack-of-tasks","followers_url":"https://api.github.com/users/stack-of-tasks/followers","following_url":"https://api.github.com/users/stack-of-tasks/following{/other_user}","gists_url":"https://api.github.com/users/stack-of-tasks/gists{/gist_id}","starred_url":"https://api.github.com/users/stack-of-tasks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stack-of-tasks/subscriptions","organizations_url":"https://api.github.com/users/stack-of-tasks/orgs","repos_url":"https://api.github.com/users/stack-of-tasks/repos","events_url":"https://api.github.com/users/stack-of-tasks/events{/privacy}","received_events_url":"https://api.github.com/users/stack-of-tasks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stack-of-tasks/pinocchio","description":"Dynamic computations using Spatial Algebra","fork":false,"url":"https://api.github.com/repos/stack-of-tasks/pinocchio","forks_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/forks","keys_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/teams","hooks_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/hooks","issue_events_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/issues/events{/number}","events_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/events","assignees_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/assignees{/user}","branches_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/branches{/branch}","tags_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/tags","blobs_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/git/refs{/sha}","trees_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/statuses/{sha}","languages_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/languages","stargazers_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/stargazers","contributors_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/contributors","subscribers_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/subscribers","subscription_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/subscription","commits_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/commits{/sha}","git_commits_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/git/commits{/sha}","comments_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/comments{/number}","issue_comment_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/issues/comments{/number}","contents_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/contents/{+path}","compare_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/merges","archive_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/downloads","issues_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/issues{/number}","pulls_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/pulls{/number}","milestones_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/milestones{/number}","notifications_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/labels{/name}","releases_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/releases{/id}","deployments_url":"https://api.github.com/repos/stack-of-tasks/pinocchio/deployments","created_at":"2014-10-07T15:42:51Z","updated_at":"2016-02-10T14:34:42Z","pushed_at":"2016-03-03T17:59:49Z","git_url":"git://github.com/stack-of-tasks/pinocchio.git","ssh_url":"git@github.com:stack-of-tasks/pinocchio.git","clone_url":"https://github.com/stack-of-tasks/pinocchio.git","svn_url":"https://github.com/stack-of-tasks/pinocchio","homepage":null,"size":6857,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":14,"mirror_url":null,"open_issues_count":18,"forks":14,"open_issues":18,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stack-of-tasks/pinocchio/pulls/110"},"html":{"href":"https://github.com/stack-of-tasks/pinocchio/pull/110"},"issue":{"href":"https://api.github.com/repos/stack-of-tasks/pinocchio/issues/110"},"comments":{"href":"https://api.github.com/repos/stack-of-tasks/pinocchio/issues/110/comments"},"review_comments":{"href":"https://api.github.com/repos/stack-of-tasks/pinocchio/pulls/110/comments"},"review_comment":{"href":"https://api.github.com/repos/stack-of-tasks/pinocchio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stack-of-tasks/pinocchio/pulls/110/commits"},"statuses":{"href":"https://api.github.com/repos/stack-of-tasks/pinocchio/statuses/f9bdd9c9a0557d4a97910dd22bb3ad10ea79c687"}}}}