{"action":"created","issue":{"url":"https://api.github.com/repos/sillsdev/flexbridge/issues/101","repository_url":"https://api.github.com/repos/sillsdev/flexbridge","labels_url":"https://api.github.com/repos/sillsdev/flexbridge/issues/101/labels{/name}","comments_url":"https://api.github.com/repos/sillsdev/flexbridge/issues/101/comments","events_url":"https://api.github.com/repos/sillsdev/flexbridge/issues/101/events","html_url":"https://github.com/sillsdev/flexbridge/pull/101","id":162648502,"number":101,"title":"Update working directory after pulling changes","user":{"login":"ermshiperete","id":181336,"avatar_url":"https://avatars.githubusercontent.com/u/181336?v=3","gravatar_id":"","url":"https://api.github.com/users/ermshiperete","html_url":"https://github.com/ermshiperete","followers_url":"https://api.github.com/users/ermshiperete/followers","following_url":"https://api.github.com/users/ermshiperete/following{/other_user}","gists_url":"https://api.github.com/users/ermshiperete/gists{/gist_id}","starred_url":"https://api.github.com/users/ermshiperete/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ermshiperete/subscriptions","organizations_url":"https://api.github.com/users/ermshiperete/orgs","repos_url":"https://api.github.com/users/ermshiperete/repos","events_url":"https://api.github.com/users/ermshiperete/events{/privacy}","received_events_url":"https://api.github.com/users/ermshiperete/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-06-28T10:03:53Z","updated_at":"2016-07-01T07:06:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sillsdev/flexbridge/pulls/101","html_url":"https://github.com/sillsdev/flexbridge/pull/101","diff_url":"https://github.com/sillsdev/flexbridge/pull/101.diff","patch_url":"https://github.com/sillsdev/flexbridge/pull/101.patch"},"body":"This fixes the problem in LfMergeBridge where changes we got from\r\nothers didn't show up in LanguageForge because the working directory\r\ndidn't get updated.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/sillsdev/flexbridge/101)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/sillsdev/flexbridge/issues/comments/229871407","html_url":"https://github.com/sillsdev/flexbridge/pull/101#issuecomment-229871407","issue_url":"https://api.github.com/repos/sillsdev/flexbridge/issues/101","id":229871407,"user":{"login":"ermshiperete","id":181336,"avatar_url":"https://avatars.githubusercontent.com/u/181336?v=3","gravatar_id":"","url":"https://api.github.com/users/ermshiperete","html_url":"https://github.com/ermshiperete","followers_url":"https://api.github.com/users/ermshiperete/followers","following_url":"https://api.github.com/users/ermshiperete/following{/other_user}","gists_url":"https://api.github.com/users/ermshiperete/gists{/gist_id}","starred_url":"https://api.github.com/users/ermshiperete/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ermshiperete/subscriptions","organizations_url":"https://api.github.com/users/ermshiperete/orgs","repos_url":"https://api.github.com/users/ermshiperete/repos","events_url":"https://api.github.com/users/ermshiperete/events{/privacy}","received_events_url":"https://api.github.com/users/ermshiperete/received_events","type":"User","site_admin":false},"created_at":"2016-07-01T07:06:36Z","updated_at":"2016-07-01T07:06:36Z","body":"This action handler is unique in that it does a pull first in order to be able to check the highest branch. This is necessary because LfMerge doesn't do data migrations. Because we do a pull outside of Chorus, Chorus doesn't see that there are new changes (unless there were local changes) and so doesn't update the working directory.\n\nThe improvement that Randy suggests in Chorus (see comment in `LanguageForgeSendReceiveActionHandler.cs`) might be a better way, but since it needs to be a general solution (instead of the LfMerge targeted one here) it needs careful implementation and unit tests. I think I'd prefer to add a ENHANCE comment and merge it with the workaround for now.\n\n---\n\nReview status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.\n\n---\n\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/sillsdev/flexbridge/101#-:-KL_Ep8FIn0dIduD49ZZ:-997176688)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"ermshiperete"}}