{"action":"created","comment":{"url":"https://api.github.com/repos/xenserver/xenadmin/pulls/comments/93395067","pull_request_review_id":13920135,"id":93395067,"diff_hunk":"@@ -0,0 +1,56 @@\n+#!/bin/bash\n+\n+# Copyright (c) Citrix Systems Inc. \n+# All rights reserved.\n+# \n+# Redistribution and use in source and binary forms, \n+# with or without modification, are permitted provided \n+# that the following conditions are met: \n+# \n+# *   Redistributions of source code must retain the above \n+#     copyright notice, this list of conditions and the \n+#     following disclaimer. \n+# *   Redistributions in binary form must reproduce the above \n+#     copyright notice, this list of conditions and the \n+#     following disclaimer in the documentation and/or other \n+#     materials provided with the distribution. \n+# \n+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND \n+# CONTRIBUTORS \"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, \n+# INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF \n+# MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE \n+# DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR \n+# CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, \n+# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, \n+# BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR \n+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS \n+# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, \n+# WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING \n+# NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE \n+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF \n+# SUCH DAMAGE.\n+\n+set -u\n+\n+source \"$( cd -P \"$( dirname \"${BASH_SOURCE[0]}\" )\" && pwd )/declarations.sh\"\n+\n+net start ncover || true # May fail if ncover already running, so ignore that error\n+\n+echo \"Running + monitoring coverage of tests...\"\n+\n+export NCOVER_USING_PROJECT=\"${NCOVER_PROJECT_ID}\"\n+export NCOVER_BUILD_ID=\"${BUILD_ID}\"\n+\n+source \"$( cd -P \"$( dirname \"${BASH_SOURCE[0]}\" )\" && pwd )/tests-checks.sh\"\n+\n+ncover summarize --project=\"XC Tests\" --wait\n+\n+echo \"Generating coverage report...\"\n+ncover report --project=\"XC Tests\" --execution=\"${BUILD_ID}\" --file=\"$(cygpath -d ${TEST_DIR})\\coverage.html\" --detail=method\n+cp ${TEST_DIR}/coverage.html ${OUTPUT_DIR}\n+\n+net stop ncover","path":"mk/tests-checks-cover.sh","position":52,"original_position":52,"commit_id":"7fc58882d89c32854246fd71899d61f739e8f2e6","original_commit_id":"7fc58882d89c32854246fd71899d61f739e8f2e6","user":{"login":"kc284","id":3705142,"avatar_url":"https://avatars.githubusercontent.com/u/3705142?v=3","gravatar_id":"","url":"https://api.github.com/users/kc284","html_url":"https://github.com/kc284","followers_url":"https://api.github.com/users/kc284/followers","following_url":"https://api.github.com/users/kc284/following{/other_user}","gists_url":"https://api.github.com/users/kc284/gists{/gist_id}","starred_url":"https://api.github.com/users/kc284/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kc284/subscriptions","organizations_url":"https://api.github.com/users/kc284/orgs","repos_url":"https://api.github.com/users/kc284/repos","events_url":"https://api.github.com/users/kc284/events{/privacy}","received_events_url":"https://api.github.com/users/kc284/received_events","type":"User","site_admin":false},"body":"Same question as above: should we check if it hasn't stopped and kill it if not? Or is is not an issue?","created_at":"2016-12-21T08:36:50Z","updated_at":"2016-12-21T08:36:50Z","html_url":"https://github.com/xenserver/xenadmin/pull/1329#discussion_r93395067","pull_request_url":"https://api.github.com/repos/xenserver/xenadmin/pulls/1329","_links":{"self":{"href":"https://api.github.com/repos/xenserver/xenadmin/pulls/comments/93395067"},"html":{"href":"https://github.com/xenserver/xenadmin/pull/1329#discussion_r93395067"},"pull_request":{"href":"https://api.github.com/repos/xenserver/xenadmin/pulls/1329"}}},"pull_request":{"url":"https://api.github.com/repos/xenserver/xenadmin/pulls/1329","id":96708267,"html_url":"https://github.com/xenserver/xenadmin/pull/1329","diff_url":"https://github.com/xenserver/xenadmin/pull/1329.diff","patch_url":"https://github.com/xenserver/xenadmin/pull/1329.patch","issue_url":"https://api.github.com/repos/xenserver/xenadmin/issues/1329","number":1329,"state":"open","locked":false,"title":"[CP-19888] Add support for code coverage in build jobs","user":{"login":"mcintyre94","id":1711350,"avatar_url":"https://avatars.githubusercontent.com/u/1711350?v=3","gravatar_id":"","url":"https://api.github.com/users/mcintyre94","html_url":"https://github.com/mcintyre94","followers_url":"https://api.github.com/users/mcintyre94/followers","following_url":"https://api.github.com/users/mcintyre94/following{/other_user}","gists_url":"https://api.github.com/users/mcintyre94/gists{/gist_id}","starred_url":"https://api.github.com/users/mcintyre94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcintyre94/subscriptions","organizations_url":"https://api.github.com/users/mcintyre94/orgs","repos_url":"https://api.github.com/users/mcintyre94/repos","events_url":"https://api.github.com/users/mcintyre94/events{/privacy}","received_events_url":"https://api.github.com/users/mcintyre94/received_events","type":"User","site_admin":false},"body":"Add support for a new environment variable REPORT_COVERAGE, which causes the tests phase to use the new script tests-checks-cover instead of tests-checks.This new script wraps the tests-checks script, by instrumenting NCover to monitor before it runs, and writing a summary log and generating a HTML report of coverage in the workspace output directory.","created_at":"2016-12-06T11:39:43Z","updated_at":"2016-12-21T08:36:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc020d2a67396248e7070109cd0749af209a7cba","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/xenserver/xenadmin/pulls/1329/commits","review_comments_url":"https://api.github.com/repos/xenserver/xenadmin/pulls/1329/comments","review_comment_url":"https://api.github.com/repos/xenserver/xenadmin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xenserver/xenadmin/issues/1329/comments","statuses_url":"https://api.github.com/repos/xenserver/xenadmin/statuses/7fc58882d89c32854246fd71899d61f739e8f2e6","head":{"label":"mcintyre94:CP-19888-copy","ref":"CP-19888-copy","sha":"7fc58882d89c32854246fd71899d61f739e8f2e6","user":{"login":"mcintyre94","id":1711350,"avatar_url":"https://avatars.githubusercontent.com/u/1711350?v=3","gravatar_id":"","url":"https://api.github.com/users/mcintyre94","html_url":"https://github.com/mcintyre94","followers_url":"https://api.github.com/users/mcintyre94/followers","following_url":"https://api.github.com/users/mcintyre94/following{/other_user}","gists_url":"https://api.github.com/users/mcintyre94/gists{/gist_id}","starred_url":"https://api.github.com/users/mcintyre94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcintyre94/subscriptions","organizations_url":"https://api.github.com/users/mcintyre94/orgs","repos_url":"https://api.github.com/users/mcintyre94/repos","events_url":"https://api.github.com/users/mcintyre94/events{/privacy}","received_events_url":"https://api.github.com/users/mcintyre94/received_events","type":"User","site_admin":false},"repo":{"id":65204861,"name":"xenadmin","full_name":"mcintyre94/xenadmin","owner":{"login":"mcintyre94","id":1711350,"avatar_url":"https://avatars.githubusercontent.com/u/1711350?v=3","gravatar_id":"","url":"https://api.github.com/users/mcintyre94","html_url":"https://github.com/mcintyre94","followers_url":"https://api.github.com/users/mcintyre94/followers","following_url":"https://api.github.com/users/mcintyre94/following{/other_user}","gists_url":"https://api.github.com/users/mcintyre94/gists{/gist_id}","starred_url":"https://api.github.com/users/mcintyre94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcintyre94/subscriptions","organizations_url":"https://api.github.com/users/mcintyre94/orgs","repos_url":"https://api.github.com/users/mcintyre94/repos","events_url":"https://api.github.com/users/mcintyre94/events{/privacy}","received_events_url":"https://api.github.com/users/mcintyre94/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mcintyre94/xenadmin","description":"XenCenter, the Windows management console for XenServer","fork":true,"url":"https://api.github.com/repos/mcintyre94/xenadmin","forks_url":"https://api.github.com/repos/mcintyre94/xenadmin/forks","keys_url":"https://api.github.com/repos/mcintyre94/xenadmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mcintyre94/xenadmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mcintyre94/xenadmin/teams","hooks_url":"https://api.github.com/repos/mcintyre94/xenadmin/hooks","issue_events_url":"https://api.github.com/repos/mcintyre94/xenadmin/issues/events{/number}","events_url":"https://api.github.com/repos/mcintyre94/xenadmin/events","assignees_url":"https://api.github.com/repos/mcintyre94/xenadmin/assignees{/user}","branches_url":"https://api.github.com/repos/mcintyre94/xenadmin/branches{/branch}","tags_url":"https://api.github.com/repos/mcintyre94/xenadmin/tags","blobs_url":"https://api.github.com/repos/mcintyre94/xenadmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mcintyre94/xenadmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mcintyre94/xenadmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/mcintyre94/xenadmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mcintyre94/xenadmin/statuses/{sha}","languages_url":"https://api.github.com/repos/mcintyre94/xenadmin/languages","stargazers_url":"https://api.github.com/repos/mcintyre94/xenadmin/stargazers","contributors_url":"https://api.github.com/repos/mcintyre94/xenadmin/contributors","subscribers_url":"https://api.github.com/repos/mcintyre94/xenadmin/subscribers","subscription_url":"https://api.github.com/repos/mcintyre94/xenadmin/subscription","commits_url":"https://api.github.com/repos/mcintyre94/xenadmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/mcintyre94/xenadmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/mcintyre94/xenadmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/mcintyre94/xenadmin/issues/comments{/number}","contents_url":"https://api.github.com/repos/mcintyre94/xenadmin/contents/{+path}","compare_url":"https://api.github.com/repos/mcintyre94/xenadmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mcintyre94/xenadmin/merges","archive_url":"https://api.github.com/repos/mcintyre94/xenadmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mcintyre94/xenadmin/downloads","issues_url":"https://api.github.com/repos/mcintyre94/xenadmin/issues{/number}","pulls_url":"https://api.github.com/repos/mcintyre94/xenadmin/pulls{/number}","milestones_url":"https://api.github.com/repos/mcintyre94/xenadmin/milestones{/number}","notifications_url":"https://api.github.com/repos/mcintyre94/xenadmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mcintyre94/xenadmin/labels{/name}","releases_url":"https://api.github.com/repos/mcintyre94/xenadmin/releases{/id}","deployments_url":"https://api.github.com/repos/mcintyre94/xenadmin/deployments","created_at":"2016-08-08T13:05:48Z","updated_at":"2016-08-08T13:06:01Z","pushed_at":"2016-12-19T17:19:06Z","git_url":"git://github.com/mcintyre94/xenadmin.git","ssh_url":"git@github.com:mcintyre94/xenadmin.git","clone_url":"https://github.com/mcintyre94/xenadmin.git","svn_url":"https://github.com/mcintyre94/xenadmin","homepage":"","size":113845,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xenserver:master","ref":"master","sha":"c2f66b0e816ded2df66f7832ff0bac79e65daf32","user":{"login":"xenserver","id":4669806,"avatar_url":"https://avatars.githubusercontent.com/u/4669806?v=3","gravatar_id":"","url":"https://api.github.com/users/xenserver","html_url":"https://github.com/xenserver","followers_url":"https://api.github.com/users/xenserver/followers","following_url":"https://api.github.com/users/xenserver/following{/other_user}","gists_url":"https://api.github.com/users/xenserver/gists{/gist_id}","starred_url":"https://api.github.com/users/xenserver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xenserver/subscriptions","organizations_url":"https://api.github.com/users/xenserver/orgs","repos_url":"https://api.github.com/users/xenserver/repos","events_url":"https://api.github.com/users/xenserver/events{/privacy}","received_events_url":"https://api.github.com/users/xenserver/received_events","type":"Organization","site_admin":false},"repo":{"id":10915984,"name":"xenadmin","full_name":"xenserver/xenadmin","owner":{"login":"xenserver","id":4669806,"avatar_url":"https://avatars.githubusercontent.com/u/4669806?v=3","gravatar_id":"","url":"https://api.github.com/users/xenserver","html_url":"https://github.com/xenserver","followers_url":"https://api.github.com/users/xenserver/followers","following_url":"https://api.github.com/users/xenserver/following{/other_user}","gists_url":"https://api.github.com/users/xenserver/gists{/gist_id}","starred_url":"https://api.github.com/users/xenserver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xenserver/subscriptions","organizations_url":"https://api.github.com/users/xenserver/orgs","repos_url":"https://api.github.com/users/xenserver/repos","events_url":"https://api.github.com/users/xenserver/events{/privacy}","received_events_url":"https://api.github.com/users/xenserver/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xenserver/xenadmin","description":"XenCenter, the Windows management console for XenServer","fork":false,"url":"https://api.github.com/repos/xenserver/xenadmin","forks_url":"https://api.github.com/repos/xenserver/xenadmin/forks","keys_url":"https://api.github.com/repos/xenserver/xenadmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xenserver/xenadmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xenserver/xenadmin/teams","hooks_url":"https://api.github.com/repos/xenserver/xenadmin/hooks","issue_events_url":"https://api.github.com/repos/xenserver/xenadmin/issues/events{/number}","events_url":"https://api.github.com/repos/xenserver/xenadmin/events","assignees_url":"https://api.github.com/repos/xenserver/xenadmin/assignees{/user}","branches_url":"https://api.github.com/repos/xenserver/xenadmin/branches{/branch}","tags_url":"https://api.github.com/repos/xenserver/xenadmin/tags","blobs_url":"https://api.github.com/repos/xenserver/xenadmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xenserver/xenadmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xenserver/xenadmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/xenserver/xenadmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xenserver/xenadmin/statuses/{sha}","languages_url":"https://api.github.com/repos/xenserver/xenadmin/languages","stargazers_url":"https://api.github.com/repos/xenserver/xenadmin/stargazers","contributors_url":"https://api.github.com/repos/xenserver/xenadmin/contributors","subscribers_url":"https://api.github.com/repos/xenserver/xenadmin/subscribers","subscription_url":"https://api.github.com/repos/xenserver/xenadmin/subscription","commits_url":"https://api.github.com/repos/xenserver/xenadmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/xenserver/xenadmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/xenserver/xenadmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/xenserver/xenadmin/issues/comments{/number}","contents_url":"https://api.github.com/repos/xenserver/xenadmin/contents/{+path}","compare_url":"https://api.github.com/repos/xenserver/xenadmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xenserver/xenadmin/merges","archive_url":"https://api.github.com/repos/xenserver/xenadmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xenserver/xenadmin/downloads","issues_url":"https://api.github.com/repos/xenserver/xenadmin/issues{/number}","pulls_url":"https://api.github.com/repos/xenserver/xenadmin/pulls{/number}","milestones_url":"https://api.github.com/repos/xenserver/xenadmin/milestones{/number}","notifications_url":"https://api.github.com/repos/xenserver/xenadmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xenserver/xenadmin/labels{/name}","releases_url":"https://api.github.com/repos/xenserver/xenadmin/releases{/id}","deployments_url":"https://api.github.com/repos/xenserver/xenadmin/deployments","created_at":"2013-06-24T18:10:24Z","updated_at":"2016-12-19T15:43:08Z","pushed_at":"2016-12-20T16:21:11Z","git_url":"git://github.com/xenserver/xenadmin.git","ssh_url":"git@github.com:xenserver/xenadmin.git","clone_url":"https://github.com/xenserver/xenadmin.git","svn_url":"https://github.com/xenserver/xenadmin","homepage":"","size":114327,"stargazers_count":125,"watchers_count":125,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":93,"mirror_url":null,"open_issues_count":9,"forks":93,"open_issues":9,"watchers":125,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xenserver/xenadmin/pulls/1329"},"html":{"href":"https://github.com/xenserver/xenadmin/pull/1329"},"issue":{"href":"https://api.github.com/repos/xenserver/xenadmin/issues/1329"},"comments":{"href":"https://api.github.com/repos/xenserver/xenadmin/issues/1329/comments"},"review_comments":{"href":"https://api.github.com/repos/xenserver/xenadmin/pulls/1329/comments"},"review_comment":{"href":"https://api.github.com/repos/xenserver/xenadmin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xenserver/xenadmin/pulls/1329/commits"},"statuses":{"href":"https://api.github.com/repos/xenserver/xenadmin/statuses/7fc58882d89c32854246fd71899d61f739e8f2e6"}}}}
{"actor":{"display_login":"kc284"}}