{"action":"created","issue":{"url":"https://api.github.com/repos/fatiando/fatiando/issues/313","repository_url":"https://api.github.com/repos/fatiando/fatiando","labels_url":"https://api.github.com/repos/fatiando/fatiando/issues/313/labels{/name}","comments_url":"https://api.github.com/repos/fatiando/fatiando/issues/313/comments","events_url":"https://api.github.com/repos/fatiando/fatiando/issues/313/events","html_url":"https://github.com/fatiando/fatiando/pull/313","id":174475635,"number":313,"title":"Modified carvetopo to mask mesh below a surface","user":{"login":"cmeessen","id":14222414,"avatar_url":"https://avatars.githubusercontent.com/u/14222414?v=3","gravatar_id":"","url":"https://api.github.com/users/cmeessen","html_url":"https://github.com/cmeessen","followers_url":"https://api.github.com/users/cmeessen/followers","following_url":"https://api.github.com/users/cmeessen/following{/other_user}","gists_url":"https://api.github.com/users/cmeessen/gists{/gist_id}","starred_url":"https://api.github.com/users/cmeessen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmeessen/subscriptions","organizations_url":"https://api.github.com/users/cmeessen/orgs","repos_url":"https://api.github.com/users/cmeessen/repos","events_url":"https://api.github.com/users/cmeessen/events{/privacy}","received_events_url":"https://api.github.com/users/cmeessen/received_events","type":"User","site_admin":false},"labels":[{"id":46883714,"url":"https://api.github.com/repos/fatiando/fatiando/labels/feature","name":"feature","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":{"login":"leouieda","id":290082,"avatar_url":"https://avatars.githubusercontent.com/u/290082?v=3","gravatar_id":"","url":"https://api.github.com/users/leouieda","html_url":"https://github.com/leouieda","followers_url":"https://api.github.com/users/leouieda/followers","following_url":"https://api.github.com/users/leouieda/following{/other_user}","gists_url":"https://api.github.com/users/leouieda/gists{/gist_id}","starred_url":"https://api.github.com/users/leouieda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leouieda/subscriptions","organizations_url":"https://api.github.com/users/leouieda/orgs","repos_url":"https://api.github.com/users/leouieda/repos","events_url":"https://api.github.com/users/leouieda/events{/privacy}","received_events_url":"https://api.github.com/users/leouieda/received_events","type":"User","site_admin":false},"assignees":[{"login":"leouieda","id":290082,"avatar_url":"https://avatars.githubusercontent.com/u/290082?v=3","gravatar_id":"","url":"https://api.github.com/users/leouieda","html_url":"https://github.com/leouieda","followers_url":"https://api.github.com/users/leouieda/followers","following_url":"https://api.github.com/users/leouieda/following{/other_user}","gists_url":"https://api.github.com/users/leouieda/gists{/gist_id}","starred_url":"https://api.github.com/users/leouieda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leouieda/subscriptions","organizations_url":"https://api.github.com/users/leouieda/orgs","repos_url":"https://api.github.com/users/leouieda/repos","events_url":"https://api.github.com/users/leouieda/events{/privacy}","received_events_url":"https://api.github.com/users/leouieda/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/fatiando/fatiando/milestones/8","html_url":"https://github.com/fatiando/fatiando/milestone/8","labels_url":"https://api.github.com/repos/fatiando/fatiando/milestones/8/labels","id":1214348,"number":8,"title":"0.6","description":"","creator":{"login":"leouieda","id":290082,"avatar_url":"https://avatars.githubusercontent.com/u/290082?v=3","gravatar_id":"","url":"https://api.github.com/users/leouieda","html_url":"https://github.com/leouieda","followers_url":"https://api.github.com/users/leouieda/followers","following_url":"https://api.github.com/users/leouieda/following{/other_user}","gists_url":"https://api.github.com/users/leouieda/gists{/gist_id}","starred_url":"https://api.github.com/users/leouieda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leouieda/subscriptions","organizations_url":"https://api.github.com/users/leouieda/orgs","repos_url":"https://api.github.com/users/leouieda/repos","events_url":"https://api.github.com/users/leouieda/events{/privacy}","received_events_url":"https://api.github.com/users/leouieda/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":6,"state":"open","created_at":"2015-07-18T19:46:59Z","updated_at":"2016-12-07T17:29:31Z","due_on":"2017-02-28T03:00:00Z","closed_at":null},"comments":6,"created_at":"2016-09-01T09:20:34Z","updated_at":"2016-12-08T09:48:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/fatiando/fatiando/pulls/313","html_url":"https://github.com/fatiando/fatiando/pull/313","diff_url":"https://github.com/fatiando/fatiando/pull/313.diff","patch_url":"https://github.com/fatiando/fatiando/pull/313.patch"},"body":"Tackles #312\r\n\r\nIn order to restrict the growth of the harvester I slightly modified `carvetopo()` (after suggestions by @leouieda). The new parameter _below_ reverses the masking process.\r\n\r\nThe image below shows a prism mesh that has been successfully masked above and below two surfaces.\r\n\r\n![snapshot](https://cloud.githubusercontent.com/assets/14222414/18162266/dfe5430a-7035-11e6-8a5c-ca56ba406642.png)\r\n\r\nI am not familiar with testing the code. Just by looking at the results the carving seems to be working fine. Would an automated test be required?\r\n### Checklist:\r\n- [x] Make tests for new code (at least 80% coverage)\r\n- [x] Create/update docstrings\r\n- [x] Include relevant equations and citations in docstrings\r\n- [x] Docstrings follow the style conventions\r\n- [x] Code follows PEP8 style conventions\r\n- [x] Code and docs have been spellchecked\r\n- [x] Include new dependencies in `doc/install.rst`, `requirements.txt`, `environment.yml`, `ci/requirements-conda.txt` and `ci/requirements-pip.txt`.\r\n- [x] Documentation builds properly (run `cd doc; make` locally)\r\n- [x] Changelog entry (leave for last to avoid conflicts)\r\n- [x] First-time contributor? Add yourself to `doc/contributors.rst` (leave for last to avoid conflicts)\r\n"},"comment":{"url":"https://api.github.com/repos/fatiando/fatiando/issues/comments/265698302","html_url":"https://github.com/fatiando/fatiando/pull/313#issuecomment-265698302","issue_url":"https://api.github.com/repos/fatiando/fatiando/issues/313","id":265698302,"user":{"login":"cmeessen","id":14222414,"avatar_url":"https://avatars.githubusercontent.com/u/14222414?v=3","gravatar_id":"","url":"https://api.github.com/users/cmeessen","html_url":"https://github.com/cmeessen","followers_url":"https://api.github.com/users/cmeessen/followers","following_url":"https://api.github.com/users/cmeessen/following{/other_user}","gists_url":"https://api.github.com/users/cmeessen/gists{/gist_id}","starred_url":"https://api.github.com/users/cmeessen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmeessen/subscriptions","organizations_url":"https://api.github.com/users/cmeessen/orgs","repos_url":"https://api.github.com/users/cmeessen/repos","events_url":"https://api.github.com/users/cmeessen/events{/privacy}","received_events_url":"https://api.github.com/users/cmeessen/received_events","type":"User","site_admin":false},"created_at":"2016-12-08T09:48:36Z","updated_at":"2016-12-08T09:48:36Z","body":"@leouieda this PR is ready to merge now as well. I still would like to create a gallery plot but since I have problems with mayavi (QDate has already been set to version 1) I would rather like to wait until there is a proper replacement for this package."}}
{"actor":{"display_login":"cmeessen"}}