{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/82061577","pull_request_review_id":2995455,"id":82061577,"diff_hunk":"@@ -215,33 +223,142 @@ static void MutateTxAddInput(CMutableTransaction& tx, const string& strInput)\n \n static void MutateTxAddOutAddr(CMutableTransaction& tx, const string& strInput)\n {\n-    // separate VALUE:ADDRESS in string\n-    size_t pos = strInput.find(':');\n-    if ((pos == string::npos) ||\n-        (pos == 0) ||\n-        (pos == (strInput.size() - 1)))\n-        throw runtime_error(\"TX output missing separator\");\n+    // Seperate into VALUE:ADDRESS\n+    vector<string> vStrInputParts;\n+    boost::split(vStrInputParts, strInput, boost::is_any_of(\":\"));","path":"src/bitcoin-tx.cpp","position":30,"original_position":30,"commit_id":"f6bbe646075164edf44c810e33526a18ddc90b7c","original_commit_id":"f6bbe646075164edf44c810e33526a18ddc90b7c","user":{"login":"paveljanik","id":6848764,"avatar_url":"https://avatars.githubusercontent.com/u/6848764?v=3","gravatar_id":"","url":"https://api.github.com/users/paveljanik","html_url":"https://github.com/paveljanik","followers_url":"https://api.github.com/users/paveljanik/followers","following_url":"https://api.github.com/users/paveljanik/following{/other_user}","gists_url":"https://api.github.com/users/paveljanik/gists{/gist_id}","starred_url":"https://api.github.com/users/paveljanik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paveljanik/subscriptions","organizations_url":"https://api.github.com/users/paveljanik/orgs","repos_url":"https://api.github.com/users/paveljanik/repos","events_url":"https://api.github.com/users/paveljanik/events{/privacy}","received_events_url":"https://api.github.com/users/paveljanik/received_events","type":"User","site_admin":false},"body":"This adds another dependency on boost. But as we already use it in this file, it is OK.\r\n","created_at":"2016-10-05T20:21:57Z","updated_at":"2016-10-05T20:21:57Z","html_url":"https://github.com/bitcoin/bitcoin/pull/8883#discussion_r82061577","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8883","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/82061577"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/8883#discussion_r82061577"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8883"}}},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8883","id":87977972,"html_url":"https://github.com/bitcoin/bitcoin/pull/8883","diff_url":"https://github.com/bitcoin/bitcoin/pull/8883.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/8883.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8883","number":8883,"state":"open","locked":false,"title":"Add all standard TXO types to bitcoin-tx","user":{"login":"jnewbery","id":1063656,"avatar_url":"https://avatars.githubusercontent.com/u/1063656?v=3","gravatar_id":"","url":"https://api.github.com/users/jnewbery","html_url":"https://github.com/jnewbery","followers_url":"https://api.github.com/users/jnewbery/followers","following_url":"https://api.github.com/users/jnewbery/following{/other_user}","gists_url":"https://api.github.com/users/jnewbery/gists{/gist_id}","starred_url":"https://api.github.com/users/jnewbery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnewbery/subscriptions","organizations_url":"https://api.github.com/users/jnewbery/orgs","repos_url":"https://api.github.com/users/jnewbery/repos","events_url":"https://api.github.com/users/jnewbery/events{/privacy}","received_events_url":"https://api.github.com/users/jnewbery/received_events","type":"User","site_admin":false},"body":"bitcoin-tx can currently create transactions with the following TXO types:\r\n\r\n- Pay to Pub Key Hash\r\n- null data (OP_RETURN)\r\n- Pay to Script Hash\r\n\r\nThis PR enhances bitcoin-tx so all remaining standard TXO types can be created:\r\n\r\n- Pay to Pub Key\r\n- Multi-sig\r\n    - bare multi-sig\r\n    - multi-sig in Pay To Script Hash\r\n    - multi-sig in Pay to Witness Script Hash\r\n    - multi-sig in Pay to Witness Script Hash, wrapped in P2SH\r\n- Pay to Witness Pub Key Hash\r\n    - Pay to Witness Pub Key Hash, wrapped in P2SH\r\n- Pay to Witness Script Hash\r\n    - Pay to Witness Script Hash, wrapped in P2SH\r\n\r\nThe PR also includes new test cases for all tx types.","created_at":"2016-10-04T21:29:02Z","updated_at":"2016-10-05T20:21:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8843a0e9f90906447c5b36ebda0e336b3d27a455","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8883/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8883/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8883/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/f6bbe646075164edf44c810e33526a18ddc90b7c","head":{"label":"HackerResidency:add-p2sh-segwit-options-to-bitcoin-tx","ref":"add-p2sh-segwit-options-to-bitcoin-tx","sha":"f6bbe646075164edf44c810e33526a18ddc90b7c","user":{"login":"HackerResidency","id":21365453,"avatar_url":"https://avatars.githubusercontent.com/u/21365453?v=3","gravatar_id":"","url":"https://api.github.com/users/HackerResidency","html_url":"https://github.com/HackerResidency","followers_url":"https://api.github.com/users/HackerResidency/followers","following_url":"https://api.github.com/users/HackerResidency/following{/other_user}","gists_url":"https://api.github.com/users/HackerResidency/gists{/gist_id}","starred_url":"https://api.github.com/users/HackerResidency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HackerResidency/subscriptions","organizations_url":"https://api.github.com/users/HackerResidency/orgs","repos_url":"https://api.github.com/users/HackerResidency/repos","events_url":"https://api.github.com/users/HackerResidency/events{/privacy}","received_events_url":"https://api.github.com/users/HackerResidency/received_events","type":"Organization","site_admin":false},"repo":{"id":67049666,"name":"bitcoin","full_name":"HackerResidency/bitcoin","owner":{"login":"HackerResidency","id":21365453,"avatar_url":"https://avatars.githubusercontent.com/u/21365453?v=3","gravatar_id":"","url":"https://api.github.com/users/HackerResidency","html_url":"https://github.com/HackerResidency","followers_url":"https://api.github.com/users/HackerResidency/followers","following_url":"https://api.github.com/users/HackerResidency/following{/other_user}","gists_url":"https://api.github.com/users/HackerResidency/gists{/gist_id}","starred_url":"https://api.github.com/users/HackerResidency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HackerResidency/subscriptions","organizations_url":"https://api.github.com/users/HackerResidency/orgs","repos_url":"https://api.github.com/users/HackerResidency/repos","events_url":"https://api.github.com/users/HackerResidency/events{/privacy}","received_events_url":"https://api.github.com/users/HackerResidency/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HackerResidency/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/HackerResidency/bitcoin","forks_url":"https://api.github.com/repos/HackerResidency/bitcoin/forks","keys_url":"https://api.github.com/repos/HackerResidency/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HackerResidency/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HackerResidency/bitcoin/teams","hooks_url":"https://api.github.com/repos/HackerResidency/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/HackerResidency/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/HackerResidency/bitcoin/events","assignees_url":"https://api.github.com/repos/HackerResidency/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/HackerResidency/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/HackerResidency/bitcoin/tags","blobs_url":"https://api.github.com/repos/HackerResidency/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HackerResidency/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HackerResidency/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/HackerResidency/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HackerResidency/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/HackerResidency/bitcoin/languages","stargazers_url":"https://api.github.com/repos/HackerResidency/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/HackerResidency/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/HackerResidency/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/HackerResidency/bitcoin/subscription","commits_url":"https://api.github.com/repos/HackerResidency/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/HackerResidency/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/HackerResidency/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/HackerResidency/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/HackerResidency/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/HackerResidency/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HackerResidency/bitcoin/merges","archive_url":"https://api.github.com/repos/HackerResidency/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HackerResidency/bitcoin/downloads","issues_url":"https://api.github.com/repos/HackerResidency/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/HackerResidency/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/HackerResidency/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/HackerResidency/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HackerResidency/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/HackerResidency/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/HackerResidency/bitcoin/deployments","created_at":"2016-08-31T15:23:28Z","updated_at":"2016-08-31T15:23:41Z","pushed_at":"2016-10-05T19:03:36Z","git_url":"git://github.com/HackerResidency/bitcoin.git","ssh_url":"git@github.com:HackerResidency/bitcoin.git","clone_url":"https://github.com/HackerResidency/bitcoin.git","svn_url":"https://github.com/HackerResidency/bitcoin","homepage":"https://bitcoin.org/en/download","size":72313,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"223f4c2dd5fa287f4c208d188a473dceea844256","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2016-10-05T20:00:29Z","pushed_at":"2016-10-05T19:46:53Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":154663,"stargazers_count":10045,"watchers_count":10045,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":6673,"mirror_url":null,"open_issues_count":538,"forks":6673,"open_issues":538,"watchers":10045,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8883"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/8883"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/8883"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/8883/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8883/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8883/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/f6bbe646075164edf44c810e33526a18ddc90b7c"}}}}
{"actor":{"display_login":"paveljanik"}}