{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/beats/issues/1231","repository_url":"https://api.github.com/repos/elastic/beats","labels_url":"https://api.github.com/repos/elastic/beats/issues/1231/labels{/name}","comments_url":"https://api.github.com/repos/elastic/beats/issues/1231/comments","events_url":"https://api.github.com/repos/elastic/beats/issues/1231/events","html_url":"https://github.com/elastic/beats/pull/1231","id":143307609,"number":1231,"title":"packetbeat: add support for NFS v3 and v4 protocols","user":{"login":"kofemann","id":575965,"avatar_url":"https://avatars.githubusercontent.com/u/575965?v=3","gravatar_id":"","url":"https://api.github.com/users/kofemann","html_url":"https://github.com/kofemann","followers_url":"https://api.github.com/users/kofemann/followers","following_url":"https://api.github.com/users/kofemann/following{/other_user}","gists_url":"https://api.github.com/users/kofemann/gists{/gist_id}","starred_url":"https://api.github.com/users/kofemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kofemann/subscriptions","organizations_url":"https://api.github.com/users/kofemann/orgs","repos_url":"https://api.github.com/users/kofemann/repos","events_url":"https://api.github.com/users/kofemann/events{/privacy}","received_events_url":"https://api.github.com/users/kofemann/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/elastic/beats/labels/enhancement","name":"enhancement","color":"fbca04"},{"url":"https://api.github.com/repos/elastic/beats/labels/new%20module","name":"new module","color":"20b2aa"},{"url":"https://api.github.com/repos/elastic/beats/labels/Packetbeat","name":"Packetbeat","color":"008000"},{"url":"https://api.github.com/repos/elastic/beats/labels/review","name":"review","color":"207de5"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-03-24T17:19:43Z","updated_at":"2016-03-29T01:05:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/elastic/beats/pulls/1231","html_url":"https://github.com/elastic/beats/pull/1231","diff_url":"https://github.com/elastic/beats/pull/1231.diff","patch_url":"https://github.com/elastic/beats/pull/1231.patch"},"body":"This pull request is more an RFC. We will run it bit in production go get more experience. Comments are welcome. The example output:\r\n{\r\n    \"@timestamp\": \"2016-03-24T17:10:54.249Z\",\r\n    \"auth_flavor\": \"unix\",\r\n    \"beat\": {\r\n      \"hostname\": \"xxx\",\r\n      \"name\": \"xxx\"\r\n    },\r\n    \"count\": 1,\r\n    \"cred\": {\r\n      \"gid\": 0,\r\n      \"gids\": [\r\n        0\r\n      ],\r\n      \"machinename\": \"xxx\",\r\n      \"stamp\": 17362766,\r\n      \"uid\": 0\r\n    },\r\n    \"dst\": \"a.b.c.d\",\r\n    \"dst_port\": 2049,\r\n    \"nfs_minor_version\": 1,\r\n    \"nfs_opcode\": \"GETATTR\",\r\n    \"nfs_status\": \"NFS_OK\",\r\n    \"nfs_tag\": \"\",\r\n    \"nfs_version\": 4,\r\n    \"rpc_status\": \"success\",\r\n    \"rpc_time\": 1000000,\r\n    \"rpc_time_str\": \"1ms\",\r\n    \"src\": \"A.B.C.D\",\r\n    \"src_port\": 835,\r\n    \"type\": \"nfs\",\r\n    \"xid\": \"0d8df9cb\"\r\n  }"},"comment":{"url":"https://api.github.com/repos/elastic/beats/issues/comments/202651220","html_url":"https://github.com/elastic/beats/pull/1231#issuecomment-202651220","issue_url":"https://api.github.com/repos/elastic/beats/issues/1231","id":202651220,"user":{"login":"andrewkroh","id":4565752,"avatar_url":"https://avatars.githubusercontent.com/u/4565752?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewkroh","html_url":"https://github.com/andrewkroh","followers_url":"https://api.github.com/users/andrewkroh/followers","following_url":"https://api.github.com/users/andrewkroh/following{/other_user}","gists_url":"https://api.github.com/users/andrewkroh/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewkroh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewkroh/subscriptions","organizations_url":"https://api.github.com/users/andrewkroh/orgs","repos_url":"https://api.github.com/users/andrewkroh/repos","events_url":"https://api.github.com/users/andrewkroh/events{/privacy}","received_events_url":"https://api.github.com/users/andrewkroh/received_events","type":"User","site_admin":false},"created_at":"2016-03-29T01:05:16Z","updated_at":"2016-03-29T01:05:16Z","body":"Thanks for the contribution! Very cool screen shot. A couple miscellaneous points:\r\n\r\n- Try running your package against `goimports`. It should change the ordering on some of the imports.\r\n- Some of the variable names are using underscores. The Go convention is [mixedCase](https://golang.org/doc/effective_go.html#mixed-caps). Try running `golint` against your package.\r\n- I see you added some pcaps. To ensure that there are no regressions we like to have some system tests in-place that replay the pcaps and check the outputs. Could you add some test cases like [these ones](https://github.com/elastic/beats/blob/master/packetbeat/tests/system/test_0032_dns.py) that use those pcaps?\r\n- And finally, to make sure that everyone understands what the fields mean it would be great if you could document their meanings. We put each field into [fields.yml](https://github.com/elastic/beats/blob/master/packetbeat/etc/fields.yml) then we generate documentation from it by running `make update`."}}