{"action":"created","issue":{"url":"https://api.github.com/repos/mat/besticon/issues/14","repository_url":"https://api.github.com/repos/mat/besticon","labels_url":"https://api.github.com/repos/mat/besticon/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/mat/besticon/issues/14/comments","events_url":"https://api.github.com/repos/mat/besticon/issues/14/events","html_url":"https://github.com/mat/besticon/pull/14","id":184627857,"number":14,"title":"Add colorize_letters query flag to API.","user":{"login":"mmkal","id":15040698,"avatar_url":"https://avatars.githubusercontent.com/u/15040698?v=3","gravatar_id":"","url":"https://api.github.com/users/mmkal","html_url":"https://github.com/mmkal","followers_url":"https://api.github.com/users/mmkal/followers","following_url":"https://api.github.com/users/mmkal/following{/other_user}","gists_url":"https://api.github.com/users/mmkal/gists{/gist_id}","starred_url":"https://api.github.com/users/mmkal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmkal/subscriptions","organizations_url":"https://api.github.com/users/mmkal/orgs","repos_url":"https://api.github.com/users/mmkal/repos","events_url":"https://api.github.com/users/mmkal/events{/privacy}","received_events_url":"https://api.github.com/users/mmkal/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-10-22T12:33:09Z","updated_at":"2016-10-22T20:16:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mat/besticon/pulls/14","html_url":"https://github.com/mat/besticon/pull/14","diff_url":"https://github.com/mat/besticon/pull/14.diff","patch_url":"https://github.com/mat/besticon/pull/14.patch"},"body":"If provided in the query parameters, this will use a hash of the URL passed in to color the letter icon used. The color is used when there is no icon of the requested size, and no \"main color\" could be found in smaller icons.\r\n\r\nThe idea is that this will prevent so many icons being grey when a large icon size is requested."},"comment":{"url":"https://api.github.com/repos/mat/besticon/issues/comments/255551321","html_url":"https://github.com/mat/besticon/pull/14#issuecomment-255551321","issue_url":"https://api.github.com/repos/mat/besticon/issues/14","id":255551321,"user":{"login":"mat","id":23060,"avatar_url":"https://avatars.githubusercontent.com/u/23060?v=3","gravatar_id":"","url":"https://api.github.com/users/mat","html_url":"https://github.com/mat","followers_url":"https://api.github.com/users/mat/followers","following_url":"https://api.github.com/users/mat/following{/other_user}","gists_url":"https://api.github.com/users/mat/gists{/gist_id}","starred_url":"https://api.github.com/users/mat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mat/subscriptions","organizations_url":"https://api.github.com/users/mat/orgs","repos_url":"https://api.github.com/users/mat/repos","events_url":"https://api.github.com/users/mat/events{/privacy}","received_events_url":"https://api.github.com/users/mat/received_events","type":"User","site_admin":false},"created_at":"2016-10-22T20:16:48Z","updated_at":"2016-10-22T20:16:48Z","body":"Hey @mmkal first of all thanks for your work!\r\n\r\nWhile I find the idea interesting I don't believe it's the right approach to fix the (annoying) issue which is the grey icons: Having some background color for the sake of having a colorful icon is not really the goal of extracting the 'main color' from other existing icons. The goal is to resemble the actual favicon at least in terms of color. This is not at all the case with randomized colors.\r\n\r\nThat said, I definitely can see the value of setting another fallback color as grey - for users like you who prefer randomized colors or for users who want the fallback color be more fitting to the rest of their UI.\r\n\r\nMy proposal: Instead of a `colorize_letters` parameter we introduce a `fallback_iconcolor` parameter which would allow for that and which is even more flexible.\r\n\r\nWhat do you think?\r\n"}}
{"actor":{"display_login":"mat"}}