{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/78690656","id":78690656,"diff_hunk":"@@ -254,6 +254,14 @@ class RGWObjManifest {\n                              as object might have been copied across buckets */\n   map<uint64_t, RGWObjManifestRule> rules;\n \n+  /* If this object is copied from another versioned object, @src_instance \n+   * is used to store src's version_id. \n+   * \n+   * @copied_obj is used to indicate whether @src_instance is valid.\n+   * */\n+  string src_instance; \n+  bool copied_obj;","path":"src/rgw/rgw_rados.h","position":null,"original_position":10,"commit_id":"5104f852d255cfc140be33885f696b7f93a6cfad","original_commit_id":"2e95e2c824c6cc829c39180b0f6809ff312e5892","user":{"login":"yehudasa","id":1036377,"avatar_url":"https://avatars.githubusercontent.com/u/1036377?v=3","gravatar_id":"","url":"https://api.github.com/users/yehudasa","html_url":"https://github.com/yehudasa","followers_url":"https://api.github.com/users/yehudasa/followers","following_url":"https://api.github.com/users/yehudasa/following{/other_user}","gists_url":"https://api.github.com/users/yehudasa/gists{/gist_id}","starred_url":"https://api.github.com/users/yehudasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yehudasa/subscriptions","organizations_url":"https://api.github.com/users/yehudasa/orgs","repos_url":"https://api.github.com/users/yehudasa/repos","events_url":"https://api.github.com/users/yehudasa/events{/privacy}","received_events_url":"https://api.github.com/users/yehudasa/received_events","type":"User","site_admin":false},"body":"@yanghonggang ok, I understand the issue now. Instead of calling the field \"tail_instance\", it should really be use_instance. By default it should match the instance field, unless it's copied and in that case it should match the copied object instance.","created_at":"2016-09-14T06:09:59Z","updated_at":"2016-09-14T06:09:59Z","html_url":"https://github.com/ceph/ceph/pull/10820#discussion_r78690656","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/10820","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/78690656"},"html":{"href":"https://github.com/ceph/ceph/pull/10820#discussion_r78690656"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/10820"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/10820","id":82299382,"html_url":"https://github.com/ceph/ceph/pull/10820","diff_url":"https://github.com/ceph/ceph/pull/10820.diff","patch_url":"https://github.com/ceph/ceph/pull/10820.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/10820","number":10820,"state":"open","locked":false,"title":"rgw: fix get object instance  returned NoSuchKey error","user":{"login":"yanghonggang","id":20939112,"avatar_url":"https://avatars.githubusercontent.com/u/20939112?v=3","gravatar_id":"","url":"https://api.github.com/users/yanghonggang","html_url":"https://github.com/yanghonggang","followers_url":"https://api.github.com/users/yanghonggang/followers","following_url":"https://api.github.com/users/yanghonggang/following{/other_user}","gists_url":"https://api.github.com/users/yanghonggang/gists{/gist_id}","starred_url":"https://api.github.com/users/yanghonggang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yanghonggang/subscriptions","organizations_url":"https://api.github.com/users/yanghonggang/orgs","repos_url":"https://api.github.com/users/yanghonggang/repos","events_url":"https://api.github.com/users/yanghonggang/events{/privacy}","received_events_url":"https://api.github.com/users/yanghonggang/received_events","type":"User","site_admin":false},"body":"When accessing the copied destination object, the source object's instance ID \r\ninformation is needed, however it's missing now in the destination object’s \r\nmanifest. This will cause an IO error when get the copied object. In order to fix \r\nthis problem, we can record source object's version_id/instance into dest object's \r\nmanifest.\r\n\r\nSigned-off-by: Yang Honggang <joseph.yang@xtaotech.com>","created_at":"2016-08-23T03:47:24Z","updated_at":"2016-09-14T06:09:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba96d343677bf97403afbaa047ef4cb015c0337b","assignee":{"login":"yehudasa","id":1036377,"avatar_url":"https://avatars.githubusercontent.com/u/1036377?v=3","gravatar_id":"","url":"https://api.github.com/users/yehudasa","html_url":"https://github.com/yehudasa","followers_url":"https://api.github.com/users/yehudasa/followers","following_url":"https://api.github.com/users/yehudasa/following{/other_user}","gists_url":"https://api.github.com/users/yehudasa/gists{/gist_id}","starred_url":"https://api.github.com/users/yehudasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yehudasa/subscriptions","organizations_url":"https://api.github.com/users/yehudasa/orgs","repos_url":"https://api.github.com/users/yehudasa/repos","events_url":"https://api.github.com/users/yehudasa/events{/privacy}","received_events_url":"https://api.github.com/users/yehudasa/received_events","type":"User","site_admin":false},"assignees":[{"login":"yehudasa","id":1036377,"avatar_url":"https://avatars.githubusercontent.com/u/1036377?v=3","gravatar_id":"","url":"https://api.github.com/users/yehudasa","html_url":"https://github.com/yehudasa","followers_url":"https://api.github.com/users/yehudasa/followers","following_url":"https://api.github.com/users/yehudasa/following{/other_user}","gists_url":"https://api.github.com/users/yehudasa/gists{/gist_id}","starred_url":"https://api.github.com/users/yehudasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yehudasa/subscriptions","organizations_url":"https://api.github.com/users/yehudasa/orgs","repos_url":"https://api.github.com/users/yehudasa/repos","events_url":"https://api.github.com/users/yehudasa/events{/privacy}","received_events_url":"https://api.github.com/users/yehudasa/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/10820/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/10820/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/10820/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/5104f852d255cfc140be33885f696b7f93a6cfad","head":{"label":"yanghonggang:master","ref":"master","sha":"5104f852d255cfc140be33885f696b7f93a6cfad","user":{"login":"yanghonggang","id":20939112,"avatar_url":"https://avatars.githubusercontent.com/u/20939112?v=3","gravatar_id":"","url":"https://api.github.com/users/yanghonggang","html_url":"https://github.com/yanghonggang","followers_url":"https://api.github.com/users/yanghonggang/followers","following_url":"https://api.github.com/users/yanghonggang/following{/other_user}","gists_url":"https://api.github.com/users/yanghonggang/gists{/gist_id}","starred_url":"https://api.github.com/users/yanghonggang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yanghonggang/subscriptions","organizations_url":"https://api.github.com/users/yanghonggang/orgs","repos_url":"https://api.github.com/users/yanghonggang/repos","events_url":"https://api.github.com/users/yanghonggang/events{/privacy}","received_events_url":"https://api.github.com/users/yanghonggang/received_events","type":"User","site_admin":false},"repo":{"id":65369000,"name":"ceph","full_name":"yanghonggang/ceph","owner":{"login":"yanghonggang","id":20939112,"avatar_url":"https://avatars.githubusercontent.com/u/20939112?v=3","gravatar_id":"","url":"https://api.github.com/users/yanghonggang","html_url":"https://github.com/yanghonggang","followers_url":"https://api.github.com/users/yanghonggang/followers","following_url":"https://api.github.com/users/yanghonggang/following{/other_user}","gists_url":"https://api.github.com/users/yanghonggang/gists{/gist_id}","starred_url":"https://api.github.com/users/yanghonggang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yanghonggang/subscriptions","organizations_url":"https://api.github.com/users/yanghonggang/orgs","repos_url":"https://api.github.com/users/yanghonggang/repos","events_url":"https://api.github.com/users/yanghonggang/events{/privacy}","received_events_url":"https://api.github.com/users/yanghonggang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yanghonggang/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/yanghonggang/ceph","forks_url":"https://api.github.com/repos/yanghonggang/ceph/forks","keys_url":"https://api.github.com/repos/yanghonggang/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yanghonggang/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yanghonggang/ceph/teams","hooks_url":"https://api.github.com/repos/yanghonggang/ceph/hooks","issue_events_url":"https://api.github.com/repos/yanghonggang/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/yanghonggang/ceph/events","assignees_url":"https://api.github.com/repos/yanghonggang/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/yanghonggang/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/yanghonggang/ceph/tags","blobs_url":"https://api.github.com/repos/yanghonggang/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yanghonggang/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yanghonggang/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/yanghonggang/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yanghonggang/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/yanghonggang/ceph/languages","stargazers_url":"https://api.github.com/repos/yanghonggang/ceph/stargazers","contributors_url":"https://api.github.com/repos/yanghonggang/ceph/contributors","subscribers_url":"https://api.github.com/repos/yanghonggang/ceph/subscribers","subscription_url":"https://api.github.com/repos/yanghonggang/ceph/subscription","commits_url":"https://api.github.com/repos/yanghonggang/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/yanghonggang/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/yanghonggang/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/yanghonggang/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/yanghonggang/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/yanghonggang/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yanghonggang/ceph/merges","archive_url":"https://api.github.com/repos/yanghonggang/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yanghonggang/ceph/downloads","issues_url":"https://api.github.com/repos/yanghonggang/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/yanghonggang/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/yanghonggang/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/yanghonggang/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yanghonggang/ceph/labels{/name}","releases_url":"https://api.github.com/repos/yanghonggang/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/yanghonggang/ceph/deployments","created_at":"2016-08-10T09:23:45Z","updated_at":"2016-08-10T09:24:06Z","pushed_at":"2016-09-06T09:46:51Z","git_url":"git://github.com/yanghonggang/ceph.git","ssh_url":"git@github.com:yanghonggang/ceph.git","clone_url":"https://github.com/yanghonggang/ceph.git","svn_url":"https://github.com/yanghonggang/ceph","homepage":"http://ceph.com","size":175915,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"e2299fab08f4b51425b7e61c8372cd96815c3716","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2016-09-14T03:18:39Z","pushed_at":"2016-09-14T05:55:12Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":240288,"stargazers_count":2472,"watchers_count":2472,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1457,"mirror_url":null,"open_issues_count":445,"forks":1457,"open_issues":445,"watchers":2472,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/10820"},"html":{"href":"https://github.com/ceph/ceph/pull/10820"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/10820"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/10820/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/10820/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/10820/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/5104f852d255cfc140be33885f696b7f93a6cfad"}}}}
{"actor":{"display_login":"yehudasa"}}