{"action":"created","issue":{"url":"https://api.github.com/repos/apollostack/apollo-client/issues/1062","repository_url":"https://api.github.com/repos/apollostack/apollo-client","labels_url":"https://api.github.com/repos/apollostack/apollo-client/issues/1062/labels{/name}","comments_url":"https://api.github.com/repos/apollostack/apollo-client/issues/1062/comments","events_url":"https://api.github.com/repos/apollostack/apollo-client/issues/1062/events","html_url":"https://github.com/apollostack/apollo-client/pull/1062","id":196291792,"number":1062,"title":"Move type dependencies as dev deps","user":{"login":"rricard","id":246520,"avatar_url":"https://avatars.githubusercontent.com/u/246520?v=3","gravatar_id":"","url":"https://api.github.com/users/rricard","html_url":"https://github.com/rricard","followers_url":"https://api.github.com/users/rricard/followers","following_url":"https://api.github.com/users/rricard/following{/other_user}","gists_url":"https://api.github.com/users/rricard/gists{/gist_id}","starred_url":"https://api.github.com/users/rricard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rricard/subscriptions","organizations_url":"https://api.github.com/users/rricard/orgs","repos_url":"https://api.github.com/users/rricard/repos","events_url":"https://api.github.com/users/rricard/events{/privacy}","received_events_url":"https://api.github.com/users/rricard/received_events","type":"User","site_admin":false},"labels":[{"id":386214855,"url":"https://api.github.com/repos/apollostack/apollo-client/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"rricard","id":246520,"avatar_url":"https://avatars.githubusercontent.com/u/246520?v=3","gravatar_id":"","url":"https://api.github.com/users/rricard","html_url":"https://github.com/rricard","followers_url":"https://api.github.com/users/rricard/followers","following_url":"https://api.github.com/users/rricard/following{/other_user}","gists_url":"https://api.github.com/users/rricard/gists{/gist_id}","starred_url":"https://api.github.com/users/rricard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rricard/subscriptions","organizations_url":"https://api.github.com/users/rricard/orgs","repos_url":"https://api.github.com/users/rricard/repos","events_url":"https://api.github.com/users/rricard/events{/privacy}","received_events_url":"https://api.github.com/users/rricard/received_events","type":"User","site_admin":false},"assignees":[{"login":"rricard","id":246520,"avatar_url":"https://avatars.githubusercontent.com/u/246520?v=3","gravatar_id":"","url":"https://api.github.com/users/rricard","html_url":"https://github.com/rricard","followers_url":"https://api.github.com/users/rricard/followers","following_url":"https://api.github.com/users/rricard/following{/other_user}","gists_url":"https://api.github.com/users/rricard/gists{/gist_id}","starred_url":"https://api.github.com/users/rricard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rricard/subscriptions","organizations_url":"https://api.github.com/users/rricard/orgs","repos_url":"https://api.github.com/users/rricard/repos","events_url":"https://api.github.com/users/rricard/events{/privacy}","received_events_url":"https://api.github.com/users/rricard/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-12-18T18:49:57Z","updated_at":"2016-12-19T13:26:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apollostack/apollo-client/pulls/1062","html_url":"https://github.com/apollostack/apollo-client/pull/1062","diff_url":"https://github.com/apollostack/apollo-client/pull/1062.diff","patch_url":"https://github.com/apollostack/apollo-client/pull/1062.patch"},"body":"Attempt to fix #1061\r\n\r\n<!--\r\n  Thanks for filing a pull request on Apollo Client!\r\n\r\n  Please look at the following checklist to ensure that your PR\r\n  can be accepted quickly:\r\n-->\r\n\r\nTODO:\r\n\r\n- [ ] If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)\r\n- [ ] Make sure all of the significant new logic is covered by tests\r\n- [ ] Rebase your changes on master so that they can be merged easily\r\n- [ ] Make sure all tests and linter rules pass\r\n- [ ] Update CHANGELOG.md with your change\r\n- [ ] Add your name and email to the AUTHORS file (optional)\r\n- [ ] If this was a change that affects the external API, update the docs and post a link to the PR in the discussion\r\n"},"comment":{"url":"https://api.github.com/repos/apollostack/apollo-client/issues/comments/267963351","html_url":"https://github.com/apollostack/apollo-client/pull/1062#issuecomment-267963351","issue_url":"https://api.github.com/repos/apollostack/apollo-client/issues/1062","id":267963351,"user":{"login":"helfer","id":6569980,"avatar_url":"https://avatars.githubusercontent.com/u/6569980?v=3","gravatar_id":"","url":"https://api.github.com/users/helfer","html_url":"https://github.com/helfer","followers_url":"https://api.github.com/users/helfer/followers","following_url":"https://api.github.com/users/helfer/following{/other_user}","gists_url":"https://api.github.com/users/helfer/gists{/gist_id}","starred_url":"https://api.github.com/users/helfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helfer/subscriptions","organizations_url":"https://api.github.com/users/helfer/orgs","repos_url":"https://api.github.com/users/helfer/repos","events_url":"https://api.github.com/users/helfer/events{/privacy}","received_events_url":"https://api.github.com/users/helfer/received_events","type":"User","site_admin":false},"created_at":"2016-12-19T13:26:21Z","updated_at":"2016-12-19T13:26:21Z","body":"Hm, I feel like we're going in circles with Typescript here... #733 #949. Is there really no way in Typescript to have projects just work and download the correct typings when they're installed, but also work in plain JavaScript without requiring the typings?\r\n\r\nAnd is it really the case that if you use typings for graphql and other things, none of your dependencies can use different typings for those packages without getting you into a world of pain? Is it just me or is this a huge drawback of using Typescript?\r\n\r\nAnyway, trying to be a bit more productive: if we merge this PR, will people get warnings about missing typings and be required to install them by hand? Are we really fixing anything here, or are we just choosing the less bad of two possible solutions?"}}
{"actor":{"display_login":"helfer"}}