{"action":"created","issue":{"url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/4931","repository_url":"https://api.github.com/repos/ArduPilot/ardupilot","labels_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/4931/labels{/name}","comments_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/4931/comments","events_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/4931/events","html_url":"https://github.com/ArduPilot/ardupilot/pull/4931","id":180942315,"number":4931,"title":"build: don't build examples with old build system","user":{"login":"lucasdemarchi","id":31864,"avatar_url":"https://avatars.githubusercontent.com/u/31864?v=3","gravatar_id":"","url":"https://api.github.com/users/lucasdemarchi","html_url":"https://github.com/lucasdemarchi","followers_url":"https://api.github.com/users/lucasdemarchi/followers","following_url":"https://api.github.com/users/lucasdemarchi/following{/other_user}","gists_url":"https://api.github.com/users/lucasdemarchi/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasdemarchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasdemarchi/subscriptions","organizations_url":"https://api.github.com/users/lucasdemarchi/orgs","repos_url":"https://api.github.com/users/lucasdemarchi/repos","events_url":"https://api.github.com/users/lucasdemarchi/events{/privacy}","received_events_url":"https://api.github.com/users/lucasdemarchi/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ArduPilot/ardupilot/labels/BuildSystem","name":"BuildSystem","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"tridge","id":831867,"avatar_url":"https://avatars.githubusercontent.com/u/831867?v=3","gravatar_id":"","url":"https://api.github.com/users/tridge","html_url":"https://github.com/tridge","followers_url":"https://api.github.com/users/tridge/followers","following_url":"https://api.github.com/users/tridge/following{/other_user}","gists_url":"https://api.github.com/users/tridge/gists{/gist_id}","starred_url":"https://api.github.com/users/tridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tridge/subscriptions","organizations_url":"https://api.github.com/users/tridge/orgs","repos_url":"https://api.github.com/users/tridge/repos","events_url":"https://api.github.com/users/tridge/events{/privacy}","received_events_url":"https://api.github.com/users/tridge/received_events","type":"User","site_admin":false},"assignees":[{"login":"tridge","id":831867,"avatar_url":"https://avatars.githubusercontent.com/u/831867?v=3","gravatar_id":"","url":"https://api.github.com/users/tridge","html_url":"https://github.com/tridge","followers_url":"https://api.github.com/users/tridge/followers","following_url":"https://api.github.com/users/tridge/following{/other_user}","gists_url":"https://api.github.com/users/tridge/gists{/gist_id}","starred_url":"https://api.github.com/users/tridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tridge/subscriptions","organizations_url":"https://api.github.com/users/tridge/orgs","repos_url":"https://api.github.com/users/tridge/repos","events_url":"https://api.github.com/users/tridge/events{/privacy}","received_events_url":"https://api.github.com/users/tridge/received_events","type":"User","site_admin":false},{"login":"OXINARF","id":1778527,"avatar_url":"https://avatars.githubusercontent.com/u/1778527?v=3","gravatar_id":"","url":"https://api.github.com/users/OXINARF","html_url":"https://github.com/OXINARF","followers_url":"https://api.github.com/users/OXINARF/followers","following_url":"https://api.github.com/users/OXINARF/following{/other_user}","gists_url":"https://api.github.com/users/OXINARF/gists{/gist_id}","starred_url":"https://api.github.com/users/OXINARF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OXINARF/subscriptions","organizations_url":"https://api.github.com/users/OXINARF/orgs","repos_url":"https://api.github.com/users/OXINARF/repos","events_url":"https://api.github.com/users/OXINARF/events{/privacy}","received_events_url":"https://api.github.com/users/OXINARF/received_events","type":"User","site_admin":false},{"login":"guludo","id":6026123,"avatar_url":"https://avatars.githubusercontent.com/u/6026123?v=3","gravatar_id":"","url":"https://api.github.com/users/guludo","html_url":"https://github.com/guludo","followers_url":"https://api.github.com/users/guludo/followers","following_url":"https://api.github.com/users/guludo/following{/other_user}","gists_url":"https://api.github.com/users/guludo/gists{/gist_id}","starred_url":"https://api.github.com/users/guludo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guludo/subscriptions","organizations_url":"https://api.github.com/users/guludo/orgs","repos_url":"https://api.github.com/users/guludo/repos","events_url":"https://api.github.com/users/guludo/events{/privacy}","received_events_url":"https://api.github.com/users/guludo/received_events","type":"User","site_admin":false},{"login":"peterbarker","id":7077857,"avatar_url":"https://avatars.githubusercontent.com/u/7077857?v=3","gravatar_id":"","url":"https://api.github.com/users/peterbarker","html_url":"https://github.com/peterbarker","followers_url":"https://api.github.com/users/peterbarker/followers","following_url":"https://api.github.com/users/peterbarker/following{/other_user}","gists_url":"https://api.github.com/users/peterbarker/gists{/gist_id}","starred_url":"https://api.github.com/users/peterbarker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterbarker/subscriptions","organizations_url":"https://api.github.com/users/peterbarker/orgs","repos_url":"https://api.github.com/users/peterbarker/repos","events_url":"https://api.github.com/users/peterbarker/events{/privacy}","received_events_url":"https://api.github.com/users/peterbarker/received_events","type":"User","site_admin":false}],"milestone":null,"comments":11,"created_at":"2016-10-04T16:30:24Z","updated_at":"2016-10-04T19:47:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/4931","html_url":"https://github.com/ArduPilot/ardupilot/pull/4931","diff_url":"https://github.com/ArduPilot/ardupilot/pull/4931.diff","patch_url":"https://github.com/ArduPilot/ardupilot/pull/4931.patch"},"body":"We currently check examples are buildable with waf which doesn't need\r\nthe libraries to be specified in a make.inc file.  Having the makefiles\r\nthere is misleading since people try to build and realize the build is\r\nbroken."},"comment":{"url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/comments/251492778","html_url":"https://github.com/ArduPilot/ardupilot/pull/4931#issuecomment-251492778","issue_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/4931","id":251492778,"user":{"login":"lucasdemarchi","id":31864,"avatar_url":"https://avatars.githubusercontent.com/u/31864?v=3","gravatar_id":"","url":"https://api.github.com/users/lucasdemarchi","html_url":"https://github.com/lucasdemarchi","followers_url":"https://api.github.com/users/lucasdemarchi/followers","following_url":"https://api.github.com/users/lucasdemarchi/following{/other_user}","gists_url":"https://api.github.com/users/lucasdemarchi/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasdemarchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasdemarchi/subscriptions","organizations_url":"https://api.github.com/users/lucasdemarchi/orgs","repos_url":"https://api.github.com/users/lucasdemarchi/repos","events_url":"https://api.github.com/users/lucasdemarchi/events{/privacy}","received_events_url":"https://api.github.com/users/lucasdemarchi/received_events","type":"User","site_admin":false},"created_at":"2016-10-04T19:47:55Z","updated_at":"2016-10-04T19:47:55Z","body":"> I dont want to build all the examples.\r\n\r\nyou can still pass `--targets` and build a single example.\r\n\r\n> Currently I go to the directory I am working and type make.\r\n\r\nyou surely type `make <something>`, not only make.\r\n\r\n> How to do the same with waf?\r\n\r\nAs I said there's missing doc on ardupilot.org. We are very much aware of the.  The BUILD.md file should cover much of what's need. Constructive feedback is appreciated.\r\n\r\nSo... suppose you are testing examples on PX4. What you do (once) is:\r\n\r\n```\r\n./waf configure --board px4-v2\r\n```\r\n\r\nThen:\r\n\r\n```\r\n./waf --targets examples/AHRS_Test\r\n```\r\n\r\nTesting another example:\r\n\r\n```\r\n./waf --targets examples/AHRS_Test\r\n```\r\n\r\nBuilding and uploading to the board:\r\n\r\n```\r\n./waf --targets examples/AHRS_Test --upload\r\n```\r\n\r\nSee the documentation mentioned. You may query a list of possible targets. If you want a list of examples:\r\n\r\n```\r\n./waf list | grep examples/\r\n```\r\n\r\n> BTW. for px4 the Nuttx stuff would be better as a static lib. Make one mod to one example source file and it takes minutes to rebuild. Not very fun!\r\n\r\nsigh. This is exactly what we do in waf. As opposed to the make build system, we build the common parts once creating some static libraries.  Experiment building all the examples, modifying one of them and building again."}}
{"actor":{"display_login":"lucasdemarchi"}}