{"action":"created","comment":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments/52790203","id":52790203,"diff_hunk":"@@ -37,11 +37,21 @@\n -                    if (!this.field_177193_i && itemstack.func_77948_v())\n +                }\n +                // Default\n-+                    if (!this.field_177193_i && itemstack.func_77962_s())\n++                    if (!this.field_177193_i && itemstack.func_77962_s() && net.minecraftforge.client.ForgeHooksClient.renderArmorGlint(itemstack, t, p_177182_1_, p_177182_9_))\n                      {\n                          this.func_177183_a(p_177182_1_, t, p_177182_2_, p_177182_3_, p_177182_4_, p_177182_5_, p_177182_6_, p_177182_7_, p_177182_8_);\n                      }\n-@@ -135,11 +134,13 @@\n+@@ -114,8 +113,7 @@\n+         {\n+             GlStateManager.func_179140_f();\n+             GlStateManager.func_179112_b(768, 1);\n+-            float f2 = 0.76F;\n+-            GlStateManager.func_179131_c(0.5F * f2, 0.25F * f2, 0.8F * f2, 1.0F);\n++            net.minecraftforge.client.ForgeHooksClient.applyGlintColor();","path":"patches/minecraft/net/minecraft/client/renderer/entity/layers/LayerArmorBase.java.patch","position":16,"original_position":16,"commit_id":"b8c87f5c9f28ab896c10e6322a6f566becf1e2f7","original_commit_id":"b8c87f5c9f28ab896c10e6322a6f566becf1e2f7","user":{"login":"LexManos","id":702211,"avatar_url":"https://avatars.githubusercontent.com/u/702211?v=3","gravatar_id":"","url":"https://api.github.com/users/LexManos","html_url":"https://github.com/LexManos","followers_url":"https://api.github.com/users/LexManos/followers","following_url":"https://api.github.com/users/LexManos/following{/other_user}","gists_url":"https://api.github.com/users/LexManos/gists{/gist_id}","starred_url":"https://api.github.com/users/LexManos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LexManos/subscriptions","organizations_url":"https://api.github.com/users/LexManos/orgs","repos_url":"https://api.github.com/users/LexManos/repos","events_url":"https://api.github.com/users/LexManos/events{/privacy}","received_events_url":"https://api.github.com/users/LexManos/received_events","type":"User","site_admin":false},"body":"Same goes for here, both methods are private and only referenced one time. Modders shouldn't be accessing private methods so it should be safe to break binary compatibility in this instance.","created_at":"2016-02-12T19:54:20Z","updated_at":"2016-02-12T19:54:20Z","html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/2458#discussion_r52790203","pull_request_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2458","_links":{"self":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments/52790203"},"html":{"href":"https://github.com/MinecraftForge/MinecraftForge/pull/2458#discussion_r52790203"},"pull_request":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2458"}}},"pull_request":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2458","id":58972239,"html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/2458","diff_url":"https://github.com/MinecraftForge/MinecraftForge/pull/2458.diff","patch_url":"https://github.com/MinecraftForge/MinecraftForge/pull/2458.patch","issue_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/2458","number":2458,"state":"open","locked":false,"title":"Render Glint Hooks & Events","user":{"login":"RANKSHANK","id":1190024,"avatar_url":"https://avatars.githubusercontent.com/u/1190024?v=3","gravatar_id":"","url":"https://api.github.com/users/RANKSHANK","html_url":"https://github.com/RANKSHANK","followers_url":"https://api.github.com/users/RANKSHANK/followers","following_url":"https://api.github.com/users/RANKSHANK/following{/other_user}","gists_url":"https://api.github.com/users/RANKSHANK/gists{/gist_id}","starred_url":"https://api.github.com/users/RANKSHANK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RANKSHANK/subscriptions","organizations_url":"https://api.github.com/users/RANKSHANK/orgs","repos_url":"https://api.github.com/users/RANKSHANK/repos","events_url":"https://api.github.com/users/RANKSHANK/events{/privacy}","received_events_url":"https://api.github.com/users/RANKSHANK/received_events","type":"User","site_admin":false},"body":"![screenshot 2016-02-11 10 06 06](https://cloud.githubusercontent.com/assets/1190024/12964981/21bb184c-d0a7-11e5-9321-e1e680e083a3.png)\r\n## Overview\r\nThis opens up the effect rendering to modders, allowing for item stack and armor stack aware coloring of the enchantment overlay respectively using added methods in the Item.class. This allows for potential visual feedback of item/armor status through glint color or simple vanity. \r\n\r\nThe events allow for more control over the effect passes (vanilla uses 2 passes in both instances), allowing for custom effects to be rendered with the supplied model, or simple modification/cancellation of existing effects.\r\n\r\nThe events may also create a segue for IBakedModel workarounds, allowing for elements to be added to models during the effect passes.\r\n\r\n#### Included is a test mod that does the following:\r\n1.  Adds an ItemArmor(lazily as possible) that has a different glint color for its ItemStack in comparison to its Armor Model (leather helmet) **[hook]**\r\n2. Gives all enchanted boots a yellowish glint **[event]**\r\n3. Potions have glint according to their color **[event]**\r\n4. Enchanted books have their glint canceled **[event]**\r\n\r\n#### Patch changes are as follows:\r\n1. RenderItem:\r\n    * Adds check to the existing to cancel rendering based on the event result\r\n    * Changes the int fed into the overlay render model \r\n2. LayerArmorBase\r\n    * Adds check to the existing to cancel rendering based on the event result\r\n    * Replaces GLState call  with one based on the glintValue stored in forgehooks \r\n3. Item\r\n    * Adds constant int reflecting the vanilla glint value.\r\n    * Adds method for returning glint color for itemstack \r\n    * Adds method for returning glint color for armor\r\n\r\n#### Potential Pitfalls:\r\nThe integers passed for the glint require the a byte dedicated to the alpha channel. This may cause confusion for modders given that most vanilla methods that take colors in the form of integers do not have alpha channels resulting in the appearance that the effect is not being rendered when the alpha channel is empty. This can be remedied simply with : [0xff << 24 | alphalessInteger]\r\n\r\n*Sorry ahead of time for any issues with the patches. Not 100% on them*","created_at":"2016-02-10T23:35:25Z","updated_at":"2016-02-12T19:54:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c277e9e514e87aeedb1c1ae63b0ff2825886f491","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2458/commits","review_comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2458/comments","review_comment_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/2458/comments","statuses_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/b8c87f5c9f28ab896c10e6322a6f566becf1e2f7","head":{"label":"RANKSHANK:master","ref":"master","sha":"b8c87f5c9f28ab896c10e6322a6f566becf1e2f7","user":{"login":"RANKSHANK","id":1190024,"avatar_url":"https://avatars.githubusercontent.com/u/1190024?v=3","gravatar_id":"","url":"https://api.github.com/users/RANKSHANK","html_url":"https://github.com/RANKSHANK","followers_url":"https://api.github.com/users/RANKSHANK/followers","following_url":"https://api.github.com/users/RANKSHANK/following{/other_user}","gists_url":"https://api.github.com/users/RANKSHANK/gists{/gist_id}","starred_url":"https://api.github.com/users/RANKSHANK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RANKSHANK/subscriptions","organizations_url":"https://api.github.com/users/RANKSHANK/orgs","repos_url":"https://api.github.com/users/RANKSHANK/repos","events_url":"https://api.github.com/users/RANKSHANK/events{/privacy}","received_events_url":"https://api.github.com/users/RANKSHANK/received_events","type":"User","site_admin":false},"repo":{"id":51248233,"name":"MinecraftForge","full_name":"RANKSHANK/MinecraftForge","owner":{"login":"RANKSHANK","id":1190024,"avatar_url":"https://avatars.githubusercontent.com/u/1190024?v=3","gravatar_id":"","url":"https://api.github.com/users/RANKSHANK","html_url":"https://github.com/RANKSHANK","followers_url":"https://api.github.com/users/RANKSHANK/followers","following_url":"https://api.github.com/users/RANKSHANK/following{/other_user}","gists_url":"https://api.github.com/users/RANKSHANK/gists{/gist_id}","starred_url":"https://api.github.com/users/RANKSHANK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RANKSHANK/subscriptions","organizations_url":"https://api.github.com/users/RANKSHANK/orgs","repos_url":"https://api.github.com/users/RANKSHANK/repos","events_url":"https://api.github.com/users/RANKSHANK/events{/privacy}","received_events_url":"https://api.github.com/users/RANKSHANK/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RANKSHANK/MinecraftForge","description":"Modifications to the Minecraft base files to assist in compatibility between mods.","fork":true,"url":"https://api.github.com/repos/RANKSHANK/MinecraftForge","forks_url":"https://api.github.com/repos/RANKSHANK/MinecraftForge/forks","keys_url":"https://api.github.com/repos/RANKSHANK/MinecraftForge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RANKSHANK/MinecraftForge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RANKSHANK/MinecraftForge/teams","hooks_url":"https://api.github.com/repos/RANKSHANK/MinecraftForge/hooks","issue_events_url":"https://api.github.com/repos/RANKSHANK/MinecraftForge/issues/events{/number}","events_url":"https://api.github.com/repos/RANKSHANK/MinecraftForge/events","assignees_url":"https://api.github.com/repos/RANKSHANK/MinecraftForge/assignees{/user}","branches_url":"https://api.github.com/repos/RANKSHANK/MinecraftForge/branches{/branch}","tags_url":"https://api.github.com/repos/RANKSHANK/MinecraftForge/tags","blobs_url":"https://api.github.com/repos/RANKSHANK/MinecraftForge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RANKSHANK/MinecraftForge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RANKSHANK/MinecraftForge/git/refs{/sha}","trees_url":"https://api.github.com/repos/RANKSHANK/MinecraftForge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RANKSHANK/MinecraftForge/statuses/{sha}","languages_url":"https://api.github.com/repos/RANKSHANK/MinecraftForge/languages","stargazers_url":"https://api.github.com/repos/RANKSHANK/MinecraftForge/stargazers","contributors_url":"https://api.github.com/repos/RANKSHANK/MinecraftForge/contributors","subscribers_url":"https://api.github.com/repos/RANKSHANK/MinecraftForge/subscribers","subscription_url":"https://api.github.com/repos/RANKSHANK/MinecraftForge/subscription","commits_url":"https://api.github.com/repos/RANKSHANK/MinecraftForge/commits{/sha}","git_commits_url":"https://api.github.com/repos/RANKSHANK/MinecraftForge/git/commits{/sha}","comments_url":"https://api.github.com/repos/RANKSHANK/MinecraftForge/comments{/number}","issue_comment_url":"https://api.github.com/repos/RANKSHANK/MinecraftForge/issues/comments{/number}","contents_url":"https://api.github.com/repos/RANKSHANK/MinecraftForge/contents/{+path}","compare_url":"https://api.github.com/repos/RANKSHANK/MinecraftForge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RANKSHANK/MinecraftForge/merges","archive_url":"https://api.github.com/repos/RANKSHANK/MinecraftForge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RANKSHANK/MinecraftForge/downloads","issues_url":"https://api.github.com/repos/RANKSHANK/MinecraftForge/issues{/number}","pulls_url":"https://api.github.com/repos/RANKSHANK/MinecraftForge/pulls{/number}","milestones_url":"https://api.github.com/repos/RANKSHANK/MinecraftForge/milestones{/number}","notifications_url":"https://api.github.com/repos/RANKSHANK/MinecraftForge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RANKSHANK/MinecraftForge/labels{/name}","releases_url":"https://api.github.com/repos/RANKSHANK/MinecraftForge/releases{/id}","deployments_url":"https://api.github.com/repos/RANKSHANK/MinecraftForge/deployments","created_at":"2016-02-07T13:19:34Z","updated_at":"2016-02-07T13:19:38Z","pushed_at":"2016-02-12T10:13:54Z","git_url":"git://github.com/RANKSHANK/MinecraftForge.git","ssh_url":"git@github.com:RANKSHANK/MinecraftForge.git","clone_url":"https://github.com/RANKSHANK/MinecraftForge.git","svn_url":"https://github.com/RANKSHANK/MinecraftForge","homepage":"","size":83540,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MinecraftForge:master","ref":"master","sha":"9070ab56e3ec76e6dbb7db4fef54cf15ae1f776a","user":{"login":"MinecraftForge","id":1390178,"avatar_url":"https://avatars.githubusercontent.com/u/1390178?v=3","gravatar_id":"","url":"https://api.github.com/users/MinecraftForge","html_url":"https://github.com/MinecraftForge","followers_url":"https://api.github.com/users/MinecraftForge/followers","following_url":"https://api.github.com/users/MinecraftForge/following{/other_user}","gists_url":"https://api.github.com/users/MinecraftForge/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecraftForge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecraftForge/subscriptions","organizations_url":"https://api.github.com/users/MinecraftForge/orgs","repos_url":"https://api.github.com/users/MinecraftForge/repos","events_url":"https://api.github.com/users/MinecraftForge/events{/privacy}","received_events_url":"https://api.github.com/users/MinecraftForge/received_events","type":"Organization","site_admin":false},"repo":{"id":3301400,"name":"MinecraftForge","full_name":"MinecraftForge/MinecraftForge","owner":{"login":"MinecraftForge","id":1390178,"avatar_url":"https://avatars.githubusercontent.com/u/1390178?v=3","gravatar_id":"","url":"https://api.github.com/users/MinecraftForge","html_url":"https://github.com/MinecraftForge","followers_url":"https://api.github.com/users/MinecraftForge/followers","following_url":"https://api.github.com/users/MinecraftForge/following{/other_user}","gists_url":"https://api.github.com/users/MinecraftForge/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecraftForge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecraftForge/subscriptions","organizations_url":"https://api.github.com/users/MinecraftForge/orgs","repos_url":"https://api.github.com/users/MinecraftForge/repos","events_url":"https://api.github.com/users/MinecraftForge/events{/privacy}","received_events_url":"https://api.github.com/users/MinecraftForge/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MinecraftForge/MinecraftForge","description":"Modifications to the Minecraft base files to assist in compatibility between mods.","fork":false,"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge","forks_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/forks","keys_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/teams","hooks_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/hooks","issue_events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/events{/number}","events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/events","assignees_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/assignees{/user}","branches_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/branches{/branch}","tags_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/tags","blobs_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/refs{/sha}","trees_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/{sha}","languages_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/languages","stargazers_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/stargazers","contributors_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/contributors","subscribers_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/subscribers","subscription_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/subscription","commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/commits{/sha}","git_commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/commits{/sha}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/comments{/number}","issue_comment_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/comments{/number}","contents_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/contents/{+path}","compare_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/merges","archive_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/downloads","issues_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues{/number}","pulls_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls{/number}","milestones_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/milestones{/number}","notifications_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/labels{/name}","releases_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/releases{/id}","deployments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/deployments","created_at":"2012-01-30T01:35:01Z","updated_at":"2016-02-12T10:33:35Z","pushed_at":"2016-02-12T18:53:33Z","git_url":"git://github.com/MinecraftForge/MinecraftForge.git","ssh_url":"git@github.com:MinecraftForge/MinecraftForge.git","clone_url":"https://github.com/MinecraftForge/MinecraftForge.git","svn_url":"https://github.com/MinecraftForge/MinecraftForge","homepage":"","size":141540,"stargazers_count":1213,"watchers_count":1213,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":693,"mirror_url":null,"open_issues_count":248,"forks":693,"open_issues":248,"watchers":1213,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2458"},"html":{"href":"https://github.com/MinecraftForge/MinecraftForge/pull/2458"},"issue":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/2458"},"comments":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/2458/comments"},"review_comments":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2458/comments"},"review_comment":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2458/commits"},"statuses":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/b8c87f5c9f28ab896c10e6322a6f566becf1e2f7"}}}}