{"action":"created","comment":{"url":"https://api.github.com/repos/apereo/cas/pulls/comments/84667692","pull_request_review_id":5429794,"id":84667692,"diff_hunk":"@@ -81,12 +92,29 @@ public Long getTimeToIdle() {\n         return 0L;\n     }\n \n-    public void setRememberMeExpirationPolicy(\n-        final ExpirationPolicy rememberMeExpirationPolicy) {\n+    public void setRememberMeExpirationPolicy(final ExpirationPolicy rememberMeExpirationPolicy) {\n         this.rememberMeExpirationPolicy = rememberMeExpirationPolicy;\n     }\n \n     public void setSessionExpirationPolicy(final ExpirationPolicy sessionExpirationPolicy) {\n         this.sessionExpirationPolicy = sessionExpirationPolicy;\n     }\n+\n+    @Override\n+    public boolean equals(Object o) {\n+        if (this == o) return true;","path":"core/cas-server-core-tickets/src/main/java/org/apereo/cas/ticket/support/RememberMeDelegatingExpirationPolicy.java","position":65,"original_position":65,"commit_id":"1d51d039a725f68a0f405818242405e4b03487ba","original_commit_id":"1d51d039a725f68a0f405818242405e4b03487ba","user":{"login":"codacy-bot","id":19940114,"avatar_url":"https://avatars.githubusercontent.com/u/19940114?v=3","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":"![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: ['if' construct must use '{}'s.](https://www.codacy.com/app/mmoayyed/cas/file/4262170812/issues/source?bid=3256115&fileBranchId=3819110#l105)","created_at":"2016-10-24T11:31:51Z","updated_at":"2016-10-24T11:31:51Z","html_url":"https://github.com/apereo/cas/pull/2055#discussion_r84667692","pull_request_url":"https://api.github.com/repos/apereo/cas/pulls/2055","_links":{"self":{"href":"https://api.github.com/repos/apereo/cas/pulls/comments/84667692"},"html":{"href":"https://github.com/apereo/cas/pull/2055#discussion_r84667692"},"pull_request":{"href":"https://api.github.com/repos/apereo/cas/pulls/2055"}}},"pull_request":{"url":"https://api.github.com/repos/apereo/cas/pulls/2055","id":89960302,"html_url":"https://github.com/apereo/cas/pull/2055","diff_url":"https://github.com/apereo/cas/pull/2055.diff","patch_url":"https://github.com/apereo/cas/pull/2055.patch","issue_url":"https://api.github.com/repos/apereo/cas/issues/2055","number":2055,"state":"open","locked":false,"title":"Cassandra ticket registry: Jackson annotations in interfaces","user":{"login":"DavidRG13","id":5788241,"avatar_url":"https://avatars.githubusercontent.com/u/5788241?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidRG13","html_url":"https://github.com/DavidRG13","followers_url":"https://api.github.com/users/DavidRG13/followers","following_url":"https://api.github.com/users/DavidRG13/following{/other_user}","gists_url":"https://api.github.com/users/DavidRG13/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidRG13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidRG13/subscriptions","organizations_url":"https://api.github.com/users/DavidRG13/orgs","repos_url":"https://api.github.com/users/DavidRG13/repos","events_url":"https://api.github.com/users/DavidRG13/events{/privacy}","received_events_url":"https://api.github.com/users/DavidRG13/received_events","type":"User","site_admin":false},"body":"Closes #2045 \r\n\r\n- Add Jackson annotations that allow polymorphic serialization\r\n- Fix DefaultHandlerResult equals comparison\r\n\r\n\r\nConfiguration:\r\nIn order to serialize ZonedDateTime, Jackson needs some configuration. This is shown in TicketGrantingTicketImplTests\r\n\r\nPossible limitations:\r\nGiven that there is lot of classes implements these interfaces (Principal, Authentication, CredentialMetaData, ...), the serialization should be tested for any different types used.\r\n\r\n","created_at":"2016-10-19T08:10:55Z","updated_at":"2016-10-24T11:31:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3d014a7fc3a7f386cb37f7b2e7713f5e543dbbf","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/apereo/cas/milestones/4","html_url":"https://github.com/apereo/cas/milestones/5.1.0.RC1","labels_url":"https://api.github.com/repos/apereo/cas/milestones/4/labels","id":721281,"number":4,"title":"5.1.0.RC1","description":"Feature release: Release Candidate (Beta)","creator":{"login":"mmoayyed","id":1205228,"avatar_url":"https://avatars.githubusercontent.com/u/1205228?v=3","gravatar_id":"","url":"https://api.github.com/users/mmoayyed","html_url":"https://github.com/mmoayyed","followers_url":"https://api.github.com/users/mmoayyed/followers","following_url":"https://api.github.com/users/mmoayyed/following{/other_user}","gists_url":"https://api.github.com/users/mmoayyed/gists{/gist_id}","starred_url":"https://api.github.com/users/mmoayyed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmoayyed/subscriptions","organizations_url":"https://api.github.com/users/mmoayyed/orgs","repos_url":"https://api.github.com/users/mmoayyed/repos","events_url":"https://api.github.com/users/mmoayyed/events{/privacy}","received_events_url":"https://api.github.com/users/mmoayyed/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":5,"state":"open","created_at":"2014-07-15T06:16:11Z","updated_at":"2016-10-24T09:05:08Z","due_on":"2016-12-23T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/apereo/cas/pulls/2055/commits","review_comments_url":"https://api.github.com/repos/apereo/cas/pulls/2055/comments","review_comment_url":"https://api.github.com/repos/apereo/cas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apereo/cas/issues/2055/comments","statuses_url":"https://api.github.com/repos/apereo/cas/statuses/1d51d039a725f68a0f405818242405e4b03487ba","head":{"label":"William-Hill-Online:CAS-2045","ref":"CAS-2045","sha":"1d51d039a725f68a0f405818242405e4b03487ba","user":{"login":"William-Hill-Online","id":16120005,"avatar_url":"https://avatars.githubusercontent.com/u/16120005?v=3","gravatar_id":"","url":"https://api.github.com/users/William-Hill-Online","html_url":"https://github.com/William-Hill-Online","followers_url":"https://api.github.com/users/William-Hill-Online/followers","following_url":"https://api.github.com/users/William-Hill-Online/following{/other_user}","gists_url":"https://api.github.com/users/William-Hill-Online/gists{/gist_id}","starred_url":"https://api.github.com/users/William-Hill-Online/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/William-Hill-Online/subscriptions","organizations_url":"https://api.github.com/users/William-Hill-Online/orgs","repos_url":"https://api.github.com/users/William-Hill-Online/repos","events_url":"https://api.github.com/users/William-Hill-Online/events{/privacy}","received_events_url":"https://api.github.com/users/William-Hill-Online/received_events","type":"Organization","site_admin":false},"repo":{"id":71229990,"name":"cas","full_name":"William-Hill-Online/cas","owner":{"login":"William-Hill-Online","id":16120005,"avatar_url":"https://avatars.githubusercontent.com/u/16120005?v=3","gravatar_id":"","url":"https://api.github.com/users/William-Hill-Online","html_url":"https://github.com/William-Hill-Online","followers_url":"https://api.github.com/users/William-Hill-Online/followers","following_url":"https://api.github.com/users/William-Hill-Online/following{/other_user}","gists_url":"https://api.github.com/users/William-Hill-Online/gists{/gist_id}","starred_url":"https://api.github.com/users/William-Hill-Online/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/William-Hill-Online/subscriptions","organizations_url":"https://api.github.com/users/William-Hill-Online/orgs","repos_url":"https://api.github.com/users/William-Hill-Online/repos","events_url":"https://api.github.com/users/William-Hill-Online/events{/privacy}","received_events_url":"https://api.github.com/users/William-Hill-Online/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/William-Hill-Online/cas","description":"Apereo CAS - Enterprise Single Sign On for all","fork":true,"url":"https://api.github.com/repos/William-Hill-Online/cas","forks_url":"https://api.github.com/repos/William-Hill-Online/cas/forks","keys_url":"https://api.github.com/repos/William-Hill-Online/cas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/William-Hill-Online/cas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/William-Hill-Online/cas/teams","hooks_url":"https://api.github.com/repos/William-Hill-Online/cas/hooks","issue_events_url":"https://api.github.com/repos/William-Hill-Online/cas/issues/events{/number}","events_url":"https://api.github.com/repos/William-Hill-Online/cas/events","assignees_url":"https://api.github.com/repos/William-Hill-Online/cas/assignees{/user}","branches_url":"https://api.github.com/repos/William-Hill-Online/cas/branches{/branch}","tags_url":"https://api.github.com/repos/William-Hill-Online/cas/tags","blobs_url":"https://api.github.com/repos/William-Hill-Online/cas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/William-Hill-Online/cas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/William-Hill-Online/cas/git/refs{/sha}","trees_url":"https://api.github.com/repos/William-Hill-Online/cas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/William-Hill-Online/cas/statuses/{sha}","languages_url":"https://api.github.com/repos/William-Hill-Online/cas/languages","stargazers_url":"https://api.github.com/repos/William-Hill-Online/cas/stargazers","contributors_url":"https://api.github.com/repos/William-Hill-Online/cas/contributors","subscribers_url":"https://api.github.com/repos/William-Hill-Online/cas/subscribers","subscription_url":"https://api.github.com/repos/William-Hill-Online/cas/subscription","commits_url":"https://api.github.com/repos/William-Hill-Online/cas/commits{/sha}","git_commits_url":"https://api.github.com/repos/William-Hill-Online/cas/git/commits{/sha}","comments_url":"https://api.github.com/repos/William-Hill-Online/cas/comments{/number}","issue_comment_url":"https://api.github.com/repos/William-Hill-Online/cas/issues/comments{/number}","contents_url":"https://api.github.com/repos/William-Hill-Online/cas/contents/{+path}","compare_url":"https://api.github.com/repos/William-Hill-Online/cas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/William-Hill-Online/cas/merges","archive_url":"https://api.github.com/repos/William-Hill-Online/cas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/William-Hill-Online/cas/downloads","issues_url":"https://api.github.com/repos/William-Hill-Online/cas/issues{/number}","pulls_url":"https://api.github.com/repos/William-Hill-Online/cas/pulls{/number}","milestones_url":"https://api.github.com/repos/William-Hill-Online/cas/milestones{/number}","notifications_url":"https://api.github.com/repos/William-Hill-Online/cas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/William-Hill-Online/cas/labels{/name}","releases_url":"https://api.github.com/repos/William-Hill-Online/cas/releases{/id}","deployments_url":"https://api.github.com/repos/William-Hill-Online/cas/deployments","created_at":"2016-10-18T09:10:14Z","updated_at":"2016-10-20T08:53:47Z","pushed_at":"2016-10-24T11:23:52Z","git_url":"git://github.com/William-Hill-Online/cas.git","ssh_url":"git@github.com:William-Hill-Online/cas.git","clone_url":"https://github.com/William-Hill-Online/cas.git","svn_url":"https://github.com/William-Hill-Online/cas","homepage":"https://apereo.github.io/cas/","size":1259334,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apereo:master","ref":"master","sha":"068dbbe7446dcc39e19b6738b75dc7de8fc411e2","user":{"login":"apereo","id":4679233,"avatar_url":"https://avatars.githubusercontent.com/u/4679233?v=3","gravatar_id":"","url":"https://api.github.com/users/apereo","html_url":"https://github.com/apereo","followers_url":"https://api.github.com/users/apereo/followers","following_url":"https://api.github.com/users/apereo/following{/other_user}","gists_url":"https://api.github.com/users/apereo/gists{/gist_id}","starred_url":"https://api.github.com/users/apereo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apereo/subscriptions","organizations_url":"https://api.github.com/users/apereo/orgs","repos_url":"https://api.github.com/users/apereo/repos","events_url":"https://api.github.com/users/apereo/events{/privacy}","received_events_url":"https://api.github.com/users/apereo/received_events","type":"Organization","site_admin":false},"repo":{"id":2352744,"name":"cas","full_name":"apereo/cas","owner":{"login":"apereo","id":4679233,"avatar_url":"https://avatars.githubusercontent.com/u/4679233?v=3","gravatar_id":"","url":"https://api.github.com/users/apereo","html_url":"https://github.com/apereo","followers_url":"https://api.github.com/users/apereo/followers","following_url":"https://api.github.com/users/apereo/following{/other_user}","gists_url":"https://api.github.com/users/apereo/gists{/gist_id}","starred_url":"https://api.github.com/users/apereo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apereo/subscriptions","organizations_url":"https://api.github.com/users/apereo/orgs","repos_url":"https://api.github.com/users/apereo/repos","events_url":"https://api.github.com/users/apereo/events{/privacy}","received_events_url":"https://api.github.com/users/apereo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apereo/cas","description":"Apereo CAS - Enterprise Single Sign On for all","fork":false,"url":"https://api.github.com/repos/apereo/cas","forks_url":"https://api.github.com/repos/apereo/cas/forks","keys_url":"https://api.github.com/repos/apereo/cas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apereo/cas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apereo/cas/teams","hooks_url":"https://api.github.com/repos/apereo/cas/hooks","issue_events_url":"https://api.github.com/repos/apereo/cas/issues/events{/number}","events_url":"https://api.github.com/repos/apereo/cas/events","assignees_url":"https://api.github.com/repos/apereo/cas/assignees{/user}","branches_url":"https://api.github.com/repos/apereo/cas/branches{/branch}","tags_url":"https://api.github.com/repos/apereo/cas/tags","blobs_url":"https://api.github.com/repos/apereo/cas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apereo/cas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apereo/cas/git/refs{/sha}","trees_url":"https://api.github.com/repos/apereo/cas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apereo/cas/statuses/{sha}","languages_url":"https://api.github.com/repos/apereo/cas/languages","stargazers_url":"https://api.github.com/repos/apereo/cas/stargazers","contributors_url":"https://api.github.com/repos/apereo/cas/contributors","subscribers_url":"https://api.github.com/repos/apereo/cas/subscribers","subscription_url":"https://api.github.com/repos/apereo/cas/subscription","commits_url":"https://api.github.com/repos/apereo/cas/commits{/sha}","git_commits_url":"https://api.github.com/repos/apereo/cas/git/commits{/sha}","comments_url":"https://api.github.com/repos/apereo/cas/comments{/number}","issue_comment_url":"https://api.github.com/repos/apereo/cas/issues/comments{/number}","contents_url":"https://api.github.com/repos/apereo/cas/contents/{+path}","compare_url":"https://api.github.com/repos/apereo/cas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apereo/cas/merges","archive_url":"https://api.github.com/repos/apereo/cas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apereo/cas/downloads","issues_url":"https://api.github.com/repos/apereo/cas/issues{/number}","pulls_url":"https://api.github.com/repos/apereo/cas/pulls{/number}","milestones_url":"https://api.github.com/repos/apereo/cas/milestones{/number}","notifications_url":"https://api.github.com/repos/apereo/cas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apereo/cas/labels{/name}","releases_url":"https://api.github.com/repos/apereo/cas/releases{/id}","deployments_url":"https://api.github.com/repos/apereo/cas/deployments","created_at":"2011-09-09T01:36:42Z","updated_at":"2016-10-24T08:18:17Z","pushed_at":"2016-10-24T11:23:54Z","git_url":"git://github.com/apereo/cas.git","ssh_url":"git@github.com:apereo/cas.git","clone_url":"https://github.com/apereo/cas.git","svn_url":"https://github.com/apereo/cas","homepage":"https://apereo.github.io/cas/","size":1310966,"stargazers_count":1883,"watchers_count":1883,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1219,"mirror_url":null,"open_issues_count":35,"forks":1219,"open_issues":35,"watchers":1883,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apereo/cas/pulls/2055"},"html":{"href":"https://github.com/apereo/cas/pull/2055"},"issue":{"href":"https://api.github.com/repos/apereo/cas/issues/2055"},"comments":{"href":"https://api.github.com/repos/apereo/cas/issues/2055/comments"},"review_comments":{"href":"https://api.github.com/repos/apereo/cas/pulls/2055/comments"},"review_comment":{"href":"https://api.github.com/repos/apereo/cas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apereo/cas/pulls/2055/commits"},"statuses":{"href":"https://api.github.com/repos/apereo/cas/statuses/1d51d039a725f68a0f405818242405e4b03487ba"}}}}
{"actor":{"display_login":"codacy-bot"}}