{"action":"created","comment":{"url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/pulls/comments/73262814","id":73262814,"diff_hunk":"@@ -63,21 +102,51 @@\n         [string]$Key,\n \n         [Parameter(Mandatory=$true,ValueFromPipeline=$true)]\n+        [Alias('Payload')]\n         $InputObject,\n \n         [switch]$Persistent,\n \n         [Int32]$Depth = 2,\n \n-        [PSCredential]$Credential,\n+        [PSCredential]\n+        [System.Management.Automation.Credential()]\n+        $Credential,\n \n         [System.Security.Authentication.SslProtocols]$Ssl,\n \n-        [parameter(Mandatory = $false)]\n-        [string]$vhost\n+        [string]$vhost = '/',\n+\n+        [ValidateSet('application/clixml+xml','application/json','text/xml', 'text/plain')]","path":"PSRabbitMq/Send-RabbitMqMessage.ps1","position":68,"original_position":68,"commit_id":"bb5c6704ad7f8d30808182c6c1b25b58bef694c0","original_commit_id":"bb5c6704ad7f8d30808182c6c1b25b58bef694c0","user":{"login":"gpduck","id":4645098,"avatar_url":"https://avatars.githubusercontent.com/u/4645098?v=3","gravatar_id":"","url":"https://api.github.com/users/gpduck","html_url":"https://github.com/gpduck","followers_url":"https://api.github.com/users/gpduck/followers","following_url":"https://api.github.com/users/gpduck/following{/other_user}","gists_url":"https://api.github.com/users/gpduck/gists{/gist_id}","starred_url":"https://api.github.com/users/gpduck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpduck/subscriptions","organizations_url":"https://api.github.com/users/gpduck/orgs","repos_url":"https://api.github.com/users/gpduck/repos","events_url":"https://api.github.com/users/gpduck/events{/privacy}","received_events_url":"https://api.github.com/users/gpduck/received_events","type":"User","site_admin":false},"body":"I know these are the valid content types for this module, but if we're sending a message to another type of consumer it could support another content type, so I'm not sure we want to restrict this here.","created_at":"2016-08-03T00:26:21Z","updated_at":"2016-08-03T00:26:21Z","html_url":"https://github.com/RamblingCookieMonster/PSRabbitMq/pull/7#discussion_r73262814","pull_request_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/pulls/comments/73262814"},"html":{"href":"https://github.com/RamblingCookieMonster/PSRabbitMq/pull/7#discussion_r73262814"},"pull_request":{"href":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/pulls/7","id":79494944,"html_url":"https://github.com/RamblingCookieMonster/PSRabbitMq/pull/7","diff_url":"https://github.com/RamblingCookieMonster/PSRabbitMq/pull/7.diff","patch_url":"https://github.com/RamblingCookieMonster/PSRabbitMq/pull/7.patch","issue_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/issues/7","number":7,"state":"open","locked":false,"title":"Basic properties + ContentTypes","user":{"login":"gaelcolas","id":8962101,"avatar_url":"https://avatars.githubusercontent.com/u/8962101?v=3","gravatar_id":"","url":"https://api.github.com/users/gaelcolas","html_url":"https://github.com/gaelcolas","followers_url":"https://api.github.com/users/gaelcolas/followers","following_url":"https://api.github.com/users/gaelcolas/following{/other_user}","gists_url":"https://api.github.com/users/gaelcolas/gists{/gist_id}","starred_url":"https://api.github.com/users/gaelcolas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaelcolas/subscriptions","organizations_url":"https://api.github.com/users/gaelcolas/orgs","repos_url":"https://api.github.com/users/gaelcolas/repos","events_url":"https://api.github.com/users/gaelcolas/events{/privacy}","received_events_url":"https://api.github.com/users/gaelcolas/received_events","type":"User","site_admin":false},"body":"Hi @gpduck and @RamblingCookieMonster,\r\n\r\nHere's a PR to add some features I needed (should not be any breaking change):\r\n- Allow the 'envelope' to be returned with the Payload upon demand\r\n- added support for other ContentType than CLI/XML, but default to it\r\n- Added support for ReplyTo, ReplyToAddress, CorrelationID, MessageID, Priority, DeliveryMode, headers, Type, UserID, TTL in the BasicProperties of a Send-RabbitMQMessage (and in the returned envelope of ConvertFrom-RabbitMQDelivery).\r\n\r\nI've written some Integration tests that I run through Test-Kitchen, but it'd mess-up your current scaffolding, so I've excluded them via .gitignore for now. This system needs to mature a bit before I share it.\r\n\r\nFeedback welcome. :)\r\n","created_at":"2016-07-31T20:23:28Z","updated_at":"2016-08-03T00:26:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f607dc5b2a7c09194ff25d49e86a229667be3ec5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/pulls/7/commits","review_comments_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/pulls/7/comments","review_comment_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/issues/7/comments","statuses_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/statuses/bb5c6704ad7f8d30808182c6c1b25b58bef694c0","head":{"label":"gaelcolas:BasicProperties","ref":"BasicProperties","sha":"bb5c6704ad7f8d30808182c6c1b25b58bef694c0","user":{"login":"gaelcolas","id":8962101,"avatar_url":"https://avatars.githubusercontent.com/u/8962101?v=3","gravatar_id":"","url":"https://api.github.com/users/gaelcolas","html_url":"https://github.com/gaelcolas","followers_url":"https://api.github.com/users/gaelcolas/followers","following_url":"https://api.github.com/users/gaelcolas/following{/other_user}","gists_url":"https://api.github.com/users/gaelcolas/gists{/gist_id}","starred_url":"https://api.github.com/users/gaelcolas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaelcolas/subscriptions","organizations_url":"https://api.github.com/users/gaelcolas/orgs","repos_url":"https://api.github.com/users/gaelcolas/repos","events_url":"https://api.github.com/users/gaelcolas/events{/privacy}","received_events_url":"https://api.github.com/users/gaelcolas/received_events","type":"User","site_admin":false},"repo":{"id":55620336,"name":"PSRabbitMq","full_name":"gaelcolas/PSRabbitMq","owner":{"login":"gaelcolas","id":8962101,"avatar_url":"https://avatars.githubusercontent.com/u/8962101?v=3","gravatar_id":"","url":"https://api.github.com/users/gaelcolas","html_url":"https://github.com/gaelcolas","followers_url":"https://api.github.com/users/gaelcolas/followers","following_url":"https://api.github.com/users/gaelcolas/following{/other_user}","gists_url":"https://api.github.com/users/gaelcolas/gists{/gist_id}","starred_url":"https://api.github.com/users/gaelcolas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaelcolas/subscriptions","organizations_url":"https://api.github.com/users/gaelcolas/orgs","repos_url":"https://api.github.com/users/gaelcolas/repos","events_url":"https://api.github.com/users/gaelcolas/events{/privacy}","received_events_url":"https://api.github.com/users/gaelcolas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gaelcolas/PSRabbitMq","description":"PowerShell module to send and receive messages from a RabbitMq server","fork":true,"url":"https://api.github.com/repos/gaelcolas/PSRabbitMq","forks_url":"https://api.github.com/repos/gaelcolas/PSRabbitMq/forks","keys_url":"https://api.github.com/repos/gaelcolas/PSRabbitMq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gaelcolas/PSRabbitMq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gaelcolas/PSRabbitMq/teams","hooks_url":"https://api.github.com/repos/gaelcolas/PSRabbitMq/hooks","issue_events_url":"https://api.github.com/repos/gaelcolas/PSRabbitMq/issues/events{/number}","events_url":"https://api.github.com/repos/gaelcolas/PSRabbitMq/events","assignees_url":"https://api.github.com/repos/gaelcolas/PSRabbitMq/assignees{/user}","branches_url":"https://api.github.com/repos/gaelcolas/PSRabbitMq/branches{/branch}","tags_url":"https://api.github.com/repos/gaelcolas/PSRabbitMq/tags","blobs_url":"https://api.github.com/repos/gaelcolas/PSRabbitMq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gaelcolas/PSRabbitMq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gaelcolas/PSRabbitMq/git/refs{/sha}","trees_url":"https://api.github.com/repos/gaelcolas/PSRabbitMq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gaelcolas/PSRabbitMq/statuses/{sha}","languages_url":"https://api.github.com/repos/gaelcolas/PSRabbitMq/languages","stargazers_url":"https://api.github.com/repos/gaelcolas/PSRabbitMq/stargazers","contributors_url":"https://api.github.com/repos/gaelcolas/PSRabbitMq/contributors","subscribers_url":"https://api.github.com/repos/gaelcolas/PSRabbitMq/subscribers","subscription_url":"https://api.github.com/repos/gaelcolas/PSRabbitMq/subscription","commits_url":"https://api.github.com/repos/gaelcolas/PSRabbitMq/commits{/sha}","git_commits_url":"https://api.github.com/repos/gaelcolas/PSRabbitMq/git/commits{/sha}","comments_url":"https://api.github.com/repos/gaelcolas/PSRabbitMq/comments{/number}","issue_comment_url":"https://api.github.com/repos/gaelcolas/PSRabbitMq/issues/comments{/number}","contents_url":"https://api.github.com/repos/gaelcolas/PSRabbitMq/contents/{+path}","compare_url":"https://api.github.com/repos/gaelcolas/PSRabbitMq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gaelcolas/PSRabbitMq/merges","archive_url":"https://api.github.com/repos/gaelcolas/PSRabbitMq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gaelcolas/PSRabbitMq/downloads","issues_url":"https://api.github.com/repos/gaelcolas/PSRabbitMq/issues{/number}","pulls_url":"https://api.github.com/repos/gaelcolas/PSRabbitMq/pulls{/number}","milestones_url":"https://api.github.com/repos/gaelcolas/PSRabbitMq/milestones{/number}","notifications_url":"https://api.github.com/repos/gaelcolas/PSRabbitMq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gaelcolas/PSRabbitMq/labels{/name}","releases_url":"https://api.github.com/repos/gaelcolas/PSRabbitMq/releases{/id}","deployments_url":"https://api.github.com/repos/gaelcolas/PSRabbitMq/deployments","created_at":"2016-04-06T16:00:50Z","updated_at":"2016-04-06T16:00:51Z","pushed_at":"2016-07-31T20:08:14Z","git_url":"git://github.com/gaelcolas/PSRabbitMq.git","ssh_url":"git@github.com:gaelcolas/PSRabbitMq.git","clone_url":"https://github.com/gaelcolas/PSRabbitMq.git","svn_url":"https://github.com/gaelcolas/PSRabbitMq","homepage":"http://ramblingcookiemonster.github.io/RabbitMQ-Intro/","size":546,"stargazers_count":0,"watchers_count":0,"language":"PowerShell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RamblingCookieMonster:master","ref":"master","sha":"48834192c2296d7fc7220828dd2202ae49775f60","user":{"login":"RamblingCookieMonster","id":6377597,"avatar_url":"https://avatars.githubusercontent.com/u/6377597?v=3","gravatar_id":"","url":"https://api.github.com/users/RamblingCookieMonster","html_url":"https://github.com/RamblingCookieMonster","followers_url":"https://api.github.com/users/RamblingCookieMonster/followers","following_url":"https://api.github.com/users/RamblingCookieMonster/following{/other_user}","gists_url":"https://api.github.com/users/RamblingCookieMonster/gists{/gist_id}","starred_url":"https://api.github.com/users/RamblingCookieMonster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RamblingCookieMonster/subscriptions","organizations_url":"https://api.github.com/users/RamblingCookieMonster/orgs","repos_url":"https://api.github.com/users/RamblingCookieMonster/repos","events_url":"https://api.github.com/users/RamblingCookieMonster/events{/privacy}","received_events_url":"https://api.github.com/users/RamblingCookieMonster/received_events","type":"User","site_admin":false},"repo":{"id":37942190,"name":"PSRabbitMq","full_name":"RamblingCookieMonster/PSRabbitMq","owner":{"login":"RamblingCookieMonster","id":6377597,"avatar_url":"https://avatars.githubusercontent.com/u/6377597?v=3","gravatar_id":"","url":"https://api.github.com/users/RamblingCookieMonster","html_url":"https://github.com/RamblingCookieMonster","followers_url":"https://api.github.com/users/RamblingCookieMonster/followers","following_url":"https://api.github.com/users/RamblingCookieMonster/following{/other_user}","gists_url":"https://api.github.com/users/RamblingCookieMonster/gists{/gist_id}","starred_url":"https://api.github.com/users/RamblingCookieMonster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RamblingCookieMonster/subscriptions","organizations_url":"https://api.github.com/users/RamblingCookieMonster/orgs","repos_url":"https://api.github.com/users/RamblingCookieMonster/repos","events_url":"https://api.github.com/users/RamblingCookieMonster/events{/privacy}","received_events_url":"https://api.github.com/users/RamblingCookieMonster/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RamblingCookieMonster/PSRabbitMq","description":"PowerShell module to send and receive messages from a RabbitMq server","fork":false,"url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq","forks_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/forks","keys_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/teams","hooks_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/hooks","issue_events_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/issues/events{/number}","events_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/events","assignees_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/assignees{/user}","branches_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/branches{/branch}","tags_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/tags","blobs_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/git/refs{/sha}","trees_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/statuses/{sha}","languages_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/languages","stargazers_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/stargazers","contributors_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/contributors","subscribers_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/subscribers","subscription_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/subscription","commits_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/commits{/sha}","git_commits_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/git/commits{/sha}","comments_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/comments{/number}","issue_comment_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/issues/comments{/number}","contents_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/contents/{+path}","compare_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/merges","archive_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/downloads","issues_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/issues{/number}","pulls_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/pulls{/number}","milestones_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/milestones{/number}","notifications_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/labels{/name}","releases_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/releases{/id}","deployments_url":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/deployments","created_at":"2015-06-23T20:08:42Z","updated_at":"2016-03-10T06:36:33Z","pushed_at":"2016-07-31T20:23:28Z","git_url":"git://github.com/RamblingCookieMonster/PSRabbitMq.git","ssh_url":"git@github.com:RamblingCookieMonster/PSRabbitMq.git","clone_url":"https://github.com/RamblingCookieMonster/PSRabbitMq.git","svn_url":"https://github.com/RamblingCookieMonster/PSRabbitMq","homepage":"http://ramblingcookiemonster.github.io/RabbitMQ-Intro/","size":537,"stargazers_count":9,"watchers_count":9,"language":"PowerShell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/pulls/7"},"html":{"href":"https://github.com/RamblingCookieMonster/PSRabbitMq/pull/7"},"issue":{"href":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/issues/7"},"comments":{"href":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/RamblingCookieMonster/PSRabbitMq/statuses/bb5c6704ad7f8d30808182c6c1b25b58bef694c0"}}}}
{"actor":{"display_login":"gpduck"}}