{"action":"created","issue":{"url":"https://api.github.com/repos/stampit-org/stamp-specification/issues/101","repository_url":"https://api.github.com/repos/stampit-org/stamp-specification","labels_url":"https://api.github.com/repos/stampit-org/stamp-specification/issues/101/labels{/name}","comments_url":"https://api.github.com/repos/stampit-org/stamp-specification/issues/101/comments","events_url":"https://api.github.com/repos/stampit-org/stamp-specification/issues/101/events","html_url":"https://github.com/stampit-org/stamp-specification/issues/101","id":160082304,"number":101,"title":"Specify details on how are things deeply merged","user":{"login":"FredyC","id":1096340,"avatar_url":"https://avatars.githubusercontent.com/u/1096340?v=3","gravatar_id":"","url":"https://api.github.com/users/FredyC","html_url":"https://github.com/FredyC","followers_url":"https://api.github.com/users/FredyC/followers","following_url":"https://api.github.com/users/FredyC/following{/other_user}","gists_url":"https://api.github.com/users/FredyC/gists{/gist_id}","starred_url":"https://api.github.com/users/FredyC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FredyC/subscriptions","organizations_url":"https://api.github.com/users/FredyC/orgs","repos_url":"https://api.github.com/users/FredyC/repos","events_url":"https://api.github.com/users/FredyC/events{/privacy}","received_events_url":"https://api.github.com/users/FredyC/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-06-14T02:05:57Z","updated_at":"2016-06-14T03:07:01Z","closed_at":null,"body":"This is very vague here as it was simply assuming use of lodash. However in case someone wants to make their own implementation, it should be clearly specified how this merge behaves. Concretely with `stampit` which now uses own merge function, it does clone functions as a set of properties instead of referencing them (see [related issue](https://github.com/stampit-org/stampit/issues/217)).\r\n\r\nI think that functions should be exception on deep cloning for sure. Do you have other opinion?\r\n\r\nMight be also related to the Symbol support #86 which talks mainly about cloning Symbol when used instead of properties names. However Symbol reference should be kept intact even when used as value."},"comment":{"url":"https://api.github.com/repos/stampit-org/stamp-specification/issues/comments/225768152","html_url":"https://github.com/stampit-org/stamp-specification/issues/101#issuecomment-225768152","issue_url":"https://api.github.com/repos/stampit-org/stamp-specification/issues/101","id":225768152,"user":{"login":"FredyC","id":1096340,"avatar_url":"https://avatars.githubusercontent.com/u/1096340?v=3","gravatar_id":"","url":"https://api.github.com/users/FredyC","html_url":"https://github.com/FredyC","followers_url":"https://api.github.com/users/FredyC/followers","following_url":"https://api.github.com/users/FredyC/following{/other_user}","gists_url":"https://api.github.com/users/FredyC/gists{/gist_id}","starred_url":"https://api.github.com/users/FredyC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FredyC/subscriptions","organizations_url":"https://api.github.com/users/FredyC/orgs","repos_url":"https://api.github.com/users/FredyC/repos","events_url":"https://api.github.com/users/FredyC/events{/privacy}","received_events_url":"https://api.github.com/users/FredyC/received_events","type":"User","site_admin":false},"created_at":"2016-06-14T03:07:01Z","updated_at":"2016-06-14T03:07:01Z","body":"One thing is metadata as bunch of primitives or even arrays, but function is something way different. As it cannot be cloned, it needs to stay in place untouched unless something else wants to put another kind of data in same spot (even another function). In that case it simply forgets completely about that function and new data are used. That's how lodash is doing it (see http://jsfiddle.net/ybem606s/3/).\r\n\r\nI think we should adopt that behavior. It's something that sane person would expect. If you say to consumer \"you need to override merger\" then I believe most of people would just go away from it because it adds up another unwanted hassle for something trivial like this."}}
{"actor":{"display_login":"FredyC"}}