{"action":"created","comment":{"url":"https://api.github.com/repos/dcjones/Gadfly.jl/pulls/comments/81899361","pull_request_review_id":2845288,"id":81899361,"diff_hunk":"@@ -1132,50 +1140,74 @@ include(\"statistics.jl\")\n # All aesthetics must have a scale. If none is given, we use a default.\n # The default depends on whether the input is discrete or continuous (i.e.,\n # PooledDataVector or DataVector, respectively).\n-const default_aes_scales = @compat Dict{Symbol, Dict}(\n-        :distribution => Dict{Symbol, Any}(:x => Scale.x_distribution(),\n-                                           :y => Scale.y_distribution()),\n-        :functional => Dict{Symbol, Any}(:z => Scale.z_func(),\n-                                         :y => Scale.y_func()),\n-        :numerical => Dict{Symbol, Any}(:x           => Scale.x_continuous(),\n-                                        :xmin        => Scale.x_continuous(),\n-                                        :xmax        => Scale.x_continuous(),\n-                                        :xintercept       => Scale.x_continuous(),\n-                                        :xend  => Scale.x_continuous(),\n-                                        :yend  => Scale.y_continuous(),\n-                                        :y           => Scale.y_continuous(),\n-                                        :ymin        => Scale.y_continuous(),\n-                                        :ymax        => Scale.y_continuous(),\n-                                        :yintercept  => Scale.y_continuous(),\n-                                        :middle      => Scale.y_continuous(),\n-                                        :upper_fence => Scale.y_continuous(),\n-                                        :lower_fence => Scale.y_continuous(),\n-                                        :upper_hinge => Scale.y_continuous(),\n-                                        :lower_hinge => Scale.y_continuous(),\n-                                        :xgroup      => Scale.xgroup(),\n-                                        :ygroup      => Scale.ygroup(),\n-                                        :color       => Scale.color_continuous(),\n-                                        :shape       => Scale.shape_discrete(),\n-                                        :group       => Scale.group_discrete(),\n-                                        :label       => Scale.label(),\n-                                        :size        => Scale.size_continuous()),\n-        :categorical => Dict{Symbol, Any}(:x          => Scale.x_discrete(),\n-                                          :xmin       => Scale.x_discrete(),\n-                                          :xmax       => Scale.x_discrete(),\n-                                          :xintercept => Scale.x_discrete(),\n-                                        :xend  => Scale.x_discrete(),\n-                                        :yend  => Scale.y_discrete(),\n-                                          :y          => Scale.y_discrete(),\n-                                          :ymin       => Scale.y_discrete(),\n-                                          :ymax       => Scale.y_discrete(),\n-                                          :yintercept => Scale.y_discrete(),\n-                                          :xgroup     => Scale.xgroup(),\n-                                          :ygroup     => Scale.ygroup(),\n-                                          :color      => Scale.color_discrete(),\n-                                          :shape      => Scale.shape_discrete(),\n-                                          :group      => Scale.group_discrete(),\n-                                          :label      => Scale.label()))\n+const default_aes_scales = Dict{Symbol, Dict}(","path":"src/Gadfly.jl","position":114,"original_position":114,"commit_id":"5ca51d6be9a5cec2de4f3041537adabd43e5dfae","original_commit_id":"5ca51d6be9a5cec2de4f3041537adabd43e5dfae","user":{"login":"shashi","id":25916,"avatar_url":"https://avatars.githubusercontent.com/u/25916?v=3","gravatar_id":"","url":"https://api.github.com/users/shashi","html_url":"https://github.com/shashi","followers_url":"https://api.github.com/users/shashi/followers","following_url":"https://api.github.com/users/shashi/following{/other_user}","gists_url":"https://api.github.com/users/shashi/gists{/gist_id}","starred_url":"https://api.github.com/users/shashi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shashi/subscriptions","organizations_url":"https://api.github.com/users/shashi/orgs","repos_url":"https://api.github.com/users/shashi/repos","events_url":"https://api.github.com/users/shashi/events{/privacy}","received_events_url":"https://api.github.com/users/shashi/received_events","type":"User","site_admin":false},"body":"Not anymore since we depend on Julia 0.4+","created_at":"2016-10-05T04:38:02Z","updated_at":"2016-10-05T04:38:02Z","html_url":"https://github.com/dcjones/Gadfly.jl/pull/908#discussion_r81899361","pull_request_url":"https://api.github.com/repos/dcjones/Gadfly.jl/pulls/908","_links":{"self":{"href":"https://api.github.com/repos/dcjones/Gadfly.jl/pulls/comments/81899361"},"html":{"href":"https://github.com/dcjones/Gadfly.jl/pull/908#discussion_r81899361"},"pull_request":{"href":"https://api.github.com/repos/dcjones/Gadfly.jl/pulls/908"}}},"pull_request":{"url":"https://api.github.com/repos/dcjones/Gadfly.jl/pulls/908","id":87912411,"html_url":"https://github.com/dcjones/Gadfly.jl/pull/908","diff_url":"https://github.com/dcjones/Gadfly.jl/pull/908.diff","patch_url":"https://github.com/dcjones/Gadfly.jl/pull/908.patch","issue_url":"https://api.github.com/repos/dcjones/Gadfly.jl/issues/908","number":908,"state":"open","locked":false,"title":"RFC: Color schemes","user":{"login":"shashi","id":25916,"avatar_url":"https://avatars.githubusercontent.com/u/25916?v=3","gravatar_id":"","url":"https://api.github.com/users/shashi","html_url":"https://github.com/shashi","followers_url":"https://api.github.com/users/shashi/followers","following_url":"https://api.github.com/users/shashi/following{/other_user}","gists_url":"https://api.github.com/users/shashi/gists{/gist_id}","starred_url":"https://api.github.com/users/shashi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shashi/subscriptions","organizations_url":"https://api.github.com/users/shashi/orgs","repos_url":"https://api.github.com/users/shashi/repos","events_url":"https://api.github.com/users/shashi/events{/privacy}","received_events_url":"https://api.github.com/users/shashi/received_events","type":"User","site_admin":false},"body":"This adds the ability to\r\n\r\n1. Set color scales in `Theme` (`discrete_color_scale`, `continuous_color_scale`)\r\n2. Ability to set a theme with `set_theme(::Theme)`, or with `set_theme(theme_name::Symbol)` given `get_theme(::Type{Val{theme_name}})` returns a `Theme`\r\n3. A `style` function which will modify the current theme instead of creating a new one with the default default values.\r\n4. Set theme using GADFLY_THEME env variable\r\n\r\nand adds a dark theme:\r\n\r\n![image](https://cloud.githubusercontent.com/assets/25916/19078175/e5d8aa30-8a6c-11e6-987c-a2a456ce972a.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/25916/19079341/fb803656-8a70-11e6-80b8-117cc9af375f.png)\r\n\r\n\r\n![image](https://cloud.githubusercontent.com/assets/25916/19079264/ad44a6de-8a70-11e6-9590-2b5b253f2e41.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/25916/19079406/268eaaf8-8a71-11e6-9a85-404f40f22ef1.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/25916/19079310/d8703152-8a70-11e6-9671-10cf61daea09.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/25916/19079471/5992e004-8a71-11e6-89e5-377acd0fd492.png)\r\n\r\nAnd is intended for use in Atom\r\n\r\n![image](https://cloud.githubusercontent.com/assets/25916/19078245/1d7e0fd4-8a6d-11e6-895c-c0c4a593b4bf.png)\r\n\r\n","created_at":"2016-10-04T15:03:19Z","updated_at":"2016-10-05T04:38:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c96600ae0e230f94382fce5501dac963de21150","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dcjones/Gadfly.jl/pulls/908/commits","review_comments_url":"https://api.github.com/repos/dcjones/Gadfly.jl/pulls/908/comments","review_comment_url":"https://api.github.com/repos/dcjones/Gadfly.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dcjones/Gadfly.jl/issues/908/comments","statuses_url":"https://api.github.com/repos/dcjones/Gadfly.jl/statuses/5ca51d6be9a5cec2de4f3041537adabd43e5dfae","head":{"label":"shashi:colorscheme","ref":"colorscheme","sha":"5ca51d6be9a5cec2de4f3041537adabd43e5dfae","user":{"login":"shashi","id":25916,"avatar_url":"https://avatars.githubusercontent.com/u/25916?v=3","gravatar_id":"","url":"https://api.github.com/users/shashi","html_url":"https://github.com/shashi","followers_url":"https://api.github.com/users/shashi/followers","following_url":"https://api.github.com/users/shashi/following{/other_user}","gists_url":"https://api.github.com/users/shashi/gists{/gist_id}","starred_url":"https://api.github.com/users/shashi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shashi/subscriptions","organizations_url":"https://api.github.com/users/shashi/orgs","repos_url":"https://api.github.com/users/shashi/repos","events_url":"https://api.github.com/users/shashi/events{/privacy}","received_events_url":"https://api.github.com/users/shashi/received_events","type":"User","site_admin":false},"repo":{"id":28101630,"name":"Gadfly.jl","full_name":"shashi/Gadfly.jl","owner":{"login":"shashi","id":25916,"avatar_url":"https://avatars.githubusercontent.com/u/25916?v=3","gravatar_id":"","url":"https://api.github.com/users/shashi","html_url":"https://github.com/shashi","followers_url":"https://api.github.com/users/shashi/followers","following_url":"https://api.github.com/users/shashi/following{/other_user}","gists_url":"https://api.github.com/users/shashi/gists{/gist_id}","starred_url":"https://api.github.com/users/shashi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shashi/subscriptions","organizations_url":"https://api.github.com/users/shashi/orgs","repos_url":"https://api.github.com/users/shashi/repos","events_url":"https://api.github.com/users/shashi/events{/privacy}","received_events_url":"https://api.github.com/users/shashi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shashi/Gadfly.jl","description":"Crafty statistical graphics for Julia.","fork":true,"url":"https://api.github.com/repos/shashi/Gadfly.jl","forks_url":"https://api.github.com/repos/shashi/Gadfly.jl/forks","keys_url":"https://api.github.com/repos/shashi/Gadfly.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shashi/Gadfly.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shashi/Gadfly.jl/teams","hooks_url":"https://api.github.com/repos/shashi/Gadfly.jl/hooks","issue_events_url":"https://api.github.com/repos/shashi/Gadfly.jl/issues/events{/number}","events_url":"https://api.github.com/repos/shashi/Gadfly.jl/events","assignees_url":"https://api.github.com/repos/shashi/Gadfly.jl/assignees{/user}","branches_url":"https://api.github.com/repos/shashi/Gadfly.jl/branches{/branch}","tags_url":"https://api.github.com/repos/shashi/Gadfly.jl/tags","blobs_url":"https://api.github.com/repos/shashi/Gadfly.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shashi/Gadfly.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shashi/Gadfly.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/shashi/Gadfly.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shashi/Gadfly.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/shashi/Gadfly.jl/languages","stargazers_url":"https://api.github.com/repos/shashi/Gadfly.jl/stargazers","contributors_url":"https://api.github.com/repos/shashi/Gadfly.jl/contributors","subscribers_url":"https://api.github.com/repos/shashi/Gadfly.jl/subscribers","subscription_url":"https://api.github.com/repos/shashi/Gadfly.jl/subscription","commits_url":"https://api.github.com/repos/shashi/Gadfly.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/shashi/Gadfly.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/shashi/Gadfly.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/shashi/Gadfly.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/shashi/Gadfly.jl/contents/{+path}","compare_url":"https://api.github.com/repos/shashi/Gadfly.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shashi/Gadfly.jl/merges","archive_url":"https://api.github.com/repos/shashi/Gadfly.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shashi/Gadfly.jl/downloads","issues_url":"https://api.github.com/repos/shashi/Gadfly.jl/issues{/number}","pulls_url":"https://api.github.com/repos/shashi/Gadfly.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/shashi/Gadfly.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/shashi/Gadfly.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shashi/Gadfly.jl/labels{/name}","releases_url":"https://api.github.com/repos/shashi/Gadfly.jl/releases{/id}","deployments_url":"https://api.github.com/repos/shashi/Gadfly.jl/deployments","created_at":"2014-12-16T19:01:19Z","updated_at":"2014-12-16T19:01:20Z","pushed_at":"2016-10-04T15:01:47Z","git_url":"git://github.com/shashi/Gadfly.jl.git","ssh_url":"git@github.com:shashi/Gadfly.jl.git","clone_url":"https://github.com/shashi/Gadfly.jl.git","svn_url":"https://github.com/shashi/Gadfly.jl","homepage":"http://gadflyjl.org/","size":4569,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dcjones:master","ref":"master","sha":"22d4659d82959208ef43de8d5b4ee8c0df61cf77","user":{"login":"dcjones","id":210361,"avatar_url":"https://avatars.githubusercontent.com/u/210361?v=3","gravatar_id":"","url":"https://api.github.com/users/dcjones","html_url":"https://github.com/dcjones","followers_url":"https://api.github.com/users/dcjones/followers","following_url":"https://api.github.com/users/dcjones/following{/other_user}","gists_url":"https://api.github.com/users/dcjones/gists{/gist_id}","starred_url":"https://api.github.com/users/dcjones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcjones/subscriptions","organizations_url":"https://api.github.com/users/dcjones/orgs","repos_url":"https://api.github.com/users/dcjones/repos","events_url":"https://api.github.com/users/dcjones/events{/privacy}","received_events_url":"https://api.github.com/users/dcjones/received_events","type":"User","site_admin":false},"repo":{"id":5319457,"name":"Gadfly.jl","full_name":"dcjones/Gadfly.jl","owner":{"login":"dcjones","id":210361,"avatar_url":"https://avatars.githubusercontent.com/u/210361?v=3","gravatar_id":"","url":"https://api.github.com/users/dcjones","html_url":"https://github.com/dcjones","followers_url":"https://api.github.com/users/dcjones/followers","following_url":"https://api.github.com/users/dcjones/following{/other_user}","gists_url":"https://api.github.com/users/dcjones/gists{/gist_id}","starred_url":"https://api.github.com/users/dcjones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcjones/subscriptions","organizations_url":"https://api.github.com/users/dcjones/orgs","repos_url":"https://api.github.com/users/dcjones/repos","events_url":"https://api.github.com/users/dcjones/events{/privacy}","received_events_url":"https://api.github.com/users/dcjones/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dcjones/Gadfly.jl","description":"Crafty statistical graphics for Julia.","fork":false,"url":"https://api.github.com/repos/dcjones/Gadfly.jl","forks_url":"https://api.github.com/repos/dcjones/Gadfly.jl/forks","keys_url":"https://api.github.com/repos/dcjones/Gadfly.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcjones/Gadfly.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcjones/Gadfly.jl/teams","hooks_url":"https://api.github.com/repos/dcjones/Gadfly.jl/hooks","issue_events_url":"https://api.github.com/repos/dcjones/Gadfly.jl/issues/events{/number}","events_url":"https://api.github.com/repos/dcjones/Gadfly.jl/events","assignees_url":"https://api.github.com/repos/dcjones/Gadfly.jl/assignees{/user}","branches_url":"https://api.github.com/repos/dcjones/Gadfly.jl/branches{/branch}","tags_url":"https://api.github.com/repos/dcjones/Gadfly.jl/tags","blobs_url":"https://api.github.com/repos/dcjones/Gadfly.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcjones/Gadfly.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcjones/Gadfly.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcjones/Gadfly.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcjones/Gadfly.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/dcjones/Gadfly.jl/languages","stargazers_url":"https://api.github.com/repos/dcjones/Gadfly.jl/stargazers","contributors_url":"https://api.github.com/repos/dcjones/Gadfly.jl/contributors","subscribers_url":"https://api.github.com/repos/dcjones/Gadfly.jl/subscribers","subscription_url":"https://api.github.com/repos/dcjones/Gadfly.jl/subscription","commits_url":"https://api.github.com/repos/dcjones/Gadfly.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcjones/Gadfly.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcjones/Gadfly.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcjones/Gadfly.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcjones/Gadfly.jl/contents/{+path}","compare_url":"https://api.github.com/repos/dcjones/Gadfly.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcjones/Gadfly.jl/merges","archive_url":"https://api.github.com/repos/dcjones/Gadfly.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcjones/Gadfly.jl/downloads","issues_url":"https://api.github.com/repos/dcjones/Gadfly.jl/issues{/number}","pulls_url":"https://api.github.com/repos/dcjones/Gadfly.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/dcjones/Gadfly.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/dcjones/Gadfly.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcjones/Gadfly.jl/labels{/name}","releases_url":"https://api.github.com/repos/dcjones/Gadfly.jl/releases{/id}","deployments_url":"https://api.github.com/repos/dcjones/Gadfly.jl/deployments","created_at":"2012-08-06T20:46:58Z","updated_at":"2016-09-27T15:18:28Z","pushed_at":"2016-10-04T18:49:12Z","git_url":"git://github.com/dcjones/Gadfly.jl.git","ssh_url":"git@github.com:dcjones/Gadfly.jl.git","clone_url":"https://github.com/dcjones/Gadfly.jl.git","svn_url":"https://github.com/dcjones/Gadfly.jl","homepage":"http://gadflyjl.org/stable/","size":7817,"stargazers_count":932,"watchers_count":932,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":164,"mirror_url":null,"open_issues_count":220,"forks":164,"open_issues":220,"watchers":932,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dcjones/Gadfly.jl/pulls/908"},"html":{"href":"https://github.com/dcjones/Gadfly.jl/pull/908"},"issue":{"href":"https://api.github.com/repos/dcjones/Gadfly.jl/issues/908"},"comments":{"href":"https://api.github.com/repos/dcjones/Gadfly.jl/issues/908/comments"},"review_comments":{"href":"https://api.github.com/repos/dcjones/Gadfly.jl/pulls/908/comments"},"review_comment":{"href":"https://api.github.com/repos/dcjones/Gadfly.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dcjones/Gadfly.jl/pulls/908/commits"},"statuses":{"href":"https://api.github.com/repos/dcjones/Gadfly.jl/statuses/5ca51d6be9a5cec2de4f3041537adabd43e5dfae"}}}}
{"actor":{"display_login":"shashi"}}