{"action":"created","comment":{"url":"https://api.github.com/repos/openvstorage/alba/pulls/comments/92582258","pull_request_review_id":13099755,"id":92582258,"diff_hunk":"@@ -21,22 +21,26 @@ open Lwt_bytes2\n \n module ReadBuffer = struct\n     type t = { buf : Lwt_bytes.t;\n-               mutable pos : int; }\n+               mutable pos : int;\n+               too_far : int;\n+             }\n \n     type 'a deserializer = t -> 'a\n \n-    let make_buffer buf pos = { buf; pos; }\n+    let make_buffer buf pos too_far = { buf; pos; too_far }\n \n     let advance_pos buf delta = buf.pos <- buf.pos + delta","path":"ocaml/src/tools/llio2.ml","position":14,"original_position":14,"commit_id":"0740b16b98b827078ad9f8bf6a28f6bb4c0c0610","original_commit_id":"0740b16b98b827078ad9f8bf6a28f6bb4c0c0610","user":{"login":"domsj","id":89326,"avatar_url":"https://avatars.githubusercontent.com/u/89326?v=3","gravatar_id":"","url":"https://api.github.com/users/domsj","html_url":"https://github.com/domsj","followers_url":"https://api.github.com/users/domsj/followers","following_url":"https://api.github.com/users/domsj/following{/other_user}","gists_url":"https://api.github.com/users/domsj/gists{/gist_id}","starred_url":"https://api.github.com/users/domsj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domsj/subscriptions","organizations_url":"https://api.github.com/users/domsj/orgs","repos_url":"https://api.github.com/users/domsj/repos","events_url":"https://api.github.com/users/domsj/events{/privacy}","received_events_url":"https://api.github.com/users/domsj/received_events","type":"User","site_admin":false},"body":"add an assert here that `buf.pos <= buf.max_pos`\r\n(max_pos is more descriptive for me than too_far)","created_at":"2016-12-15T10:30:02Z","updated_at":"2016-12-15T10:30:03Z","html_url":"https://github.com/openvstorage/alba/pull/504#discussion_r92582258","pull_request_url":"https://api.github.com/repos/openvstorage/alba/pulls/504","_links":{"self":{"href":"https://api.github.com/repos/openvstorage/alba/pulls/comments/92582258"},"html":{"href":"https://github.com/openvstorage/alba/pull/504#discussion_r92582258"},"pull_request":{"href":"https://api.github.com/repos/openvstorage/alba/pulls/504"}}},"pull_request":{"url":"https://api.github.com/repos/openvstorage/alba/pulls/504","id":98120583,"html_url":"https://github.com/openvstorage/alba/pull/504","diff_url":"https://github.com/openvstorage/alba/pull/504.diff","patch_url":"https://github.com/openvstorage/alba/pull/504.patch","issue_url":"https://api.github.com/repos/openvstorage/alba/issues/504","number":504,"state":"open","locked":false,"title":"recycle buffers in asd_client","user":{"login":"toolslive","id":1249832,"avatar_url":"https://avatars.githubusercontent.com/u/1249832?v=3","gravatar_id":"","url":"https://api.github.com/users/toolslive","html_url":"https://github.com/toolslive","followers_url":"https://api.github.com/users/toolslive/followers","following_url":"https://api.github.com/users/toolslive/following{/other_user}","gists_url":"https://api.github.com/users/toolslive/gists{/gist_id}","starred_url":"https://api.github.com/users/toolslive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toolslive/subscriptions","organizations_url":"https://api.github.com/users/toolslive/orgs","repos_url":"https://api.github.com/users/toolslive/repos","events_url":"https://api.github.com/users/toolslive/events{/privacy}","received_events_url":"https://api.github.com/users/toolslive/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-12-15T10:10:57Z","updated_at":"2016-12-15T10:30:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3249b1f3d9a86e40adc927f2c134a17f4b8b5b12","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openvstorage/alba/pulls/504/commits","review_comments_url":"https://api.github.com/repos/openvstorage/alba/pulls/504/comments","review_comment_url":"https://api.github.com/repos/openvstorage/alba/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openvstorage/alba/issues/504/comments","statuses_url":"https://api.github.com/repos/openvstorage/alba/statuses/0740b16b98b827078ad9f8bf6a28f6bb4c0c0610","head":{"label":"openvstorage:asd_performance","ref":"asd_performance","sha":"0740b16b98b827078ad9f8bf6a28f6bb4c0c0610","user":{"login":"openvstorage","id":12763393,"avatar_url":"https://avatars.githubusercontent.com/u/12763393?v=3","gravatar_id":"","url":"https://api.github.com/users/openvstorage","html_url":"https://github.com/openvstorage","followers_url":"https://api.github.com/users/openvstorage/followers","following_url":"https://api.github.com/users/openvstorage/following{/other_user}","gists_url":"https://api.github.com/users/openvstorage/gists{/gist_id}","starred_url":"https://api.github.com/users/openvstorage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openvstorage/subscriptions","organizations_url":"https://api.github.com/users/openvstorage/orgs","repos_url":"https://api.github.com/users/openvstorage/repos","events_url":"https://api.github.com/users/openvstorage/events{/privacy}","received_events_url":"https://api.github.com/users/openvstorage/received_events","type":"Organization","site_admin":false},"repo":{"id":38867740,"name":"alba","full_name":"openvstorage/alba","owner":{"login":"openvstorage","id":12763393,"avatar_url":"https://avatars.githubusercontent.com/u/12763393?v=3","gravatar_id":"","url":"https://api.github.com/users/openvstorage","html_url":"https://github.com/openvstorage","followers_url":"https://api.github.com/users/openvstorage/followers","following_url":"https://api.github.com/users/openvstorage/following{/other_user}","gists_url":"https://api.github.com/users/openvstorage/gists{/gist_id}","starred_url":"https://api.github.com/users/openvstorage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openvstorage/subscriptions","organizations_url":"https://api.github.com/users/openvstorage/orgs","repos_url":"https://api.github.com/users/openvstorage/repos","events_url":"https://api.github.com/users/openvstorage/events{/privacy}","received_events_url":"https://api.github.com/users/openvstorage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openvstorage/alba","description":"Open vStorage ALBA (alternate backend) creates a replicated or flexible network raid’ed  object storage backend out of Seagate Kinetic drives and local disk supporting compression, encryption.","fork":false,"url":"https://api.github.com/repos/openvstorage/alba","forks_url":"https://api.github.com/repos/openvstorage/alba/forks","keys_url":"https://api.github.com/repos/openvstorage/alba/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openvstorage/alba/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openvstorage/alba/teams","hooks_url":"https://api.github.com/repos/openvstorage/alba/hooks","issue_events_url":"https://api.github.com/repos/openvstorage/alba/issues/events{/number}","events_url":"https://api.github.com/repos/openvstorage/alba/events","assignees_url":"https://api.github.com/repos/openvstorage/alba/assignees{/user}","branches_url":"https://api.github.com/repos/openvstorage/alba/branches{/branch}","tags_url":"https://api.github.com/repos/openvstorage/alba/tags","blobs_url":"https://api.github.com/repos/openvstorage/alba/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openvstorage/alba/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openvstorage/alba/git/refs{/sha}","trees_url":"https://api.github.com/repos/openvstorage/alba/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openvstorage/alba/statuses/{sha}","languages_url":"https://api.github.com/repos/openvstorage/alba/languages","stargazers_url":"https://api.github.com/repos/openvstorage/alba/stargazers","contributors_url":"https://api.github.com/repos/openvstorage/alba/contributors","subscribers_url":"https://api.github.com/repos/openvstorage/alba/subscribers","subscription_url":"https://api.github.com/repos/openvstorage/alba/subscription","commits_url":"https://api.github.com/repos/openvstorage/alba/commits{/sha}","git_commits_url":"https://api.github.com/repos/openvstorage/alba/git/commits{/sha}","comments_url":"https://api.github.com/repos/openvstorage/alba/comments{/number}","issue_comment_url":"https://api.github.com/repos/openvstorage/alba/issues/comments{/number}","contents_url":"https://api.github.com/repos/openvstorage/alba/contents/{+path}","compare_url":"https://api.github.com/repos/openvstorage/alba/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openvstorage/alba/merges","archive_url":"https://api.github.com/repos/openvstorage/alba/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openvstorage/alba/downloads","issues_url":"https://api.github.com/repos/openvstorage/alba/issues{/number}","pulls_url":"https://api.github.com/repos/openvstorage/alba/pulls{/number}","milestones_url":"https://api.github.com/repos/openvstorage/alba/milestones{/number}","notifications_url":"https://api.github.com/repos/openvstorage/alba/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openvstorage/alba/labels{/name}","releases_url":"https://api.github.com/repos/openvstorage/alba/releases{/id}","deployments_url":"https://api.github.com/repos/openvstorage/alba/deployments","created_at":"2015-07-10T07:40:52Z","updated_at":"2016-10-25T09:54:12Z","pushed_at":"2016-12-15T10:13:15Z","git_url":"git://github.com/openvstorage/alba.git","ssh_url":"git@github.com:openvstorage/alba.git","clone_url":"https://github.com/openvstorage/alba.git","svn_url":"https://github.com/openvstorage/alba","homepage":"","size":35798,"stargazers_count":15,"watchers_count":15,"language":"OCaml","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":44,"forks":4,"open_issues":44,"watchers":15,"default_branch":"master"}},"base":{"label":"openvstorage:master","ref":"master","sha":"eea793aae34d92cbae4034172c5ba5b0d27a9d27","user":{"login":"openvstorage","id":12763393,"avatar_url":"https://avatars.githubusercontent.com/u/12763393?v=3","gravatar_id":"","url":"https://api.github.com/users/openvstorage","html_url":"https://github.com/openvstorage","followers_url":"https://api.github.com/users/openvstorage/followers","following_url":"https://api.github.com/users/openvstorage/following{/other_user}","gists_url":"https://api.github.com/users/openvstorage/gists{/gist_id}","starred_url":"https://api.github.com/users/openvstorage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openvstorage/subscriptions","organizations_url":"https://api.github.com/users/openvstorage/orgs","repos_url":"https://api.github.com/users/openvstorage/repos","events_url":"https://api.github.com/users/openvstorage/events{/privacy}","received_events_url":"https://api.github.com/users/openvstorage/received_events","type":"Organization","site_admin":false},"repo":{"id":38867740,"name":"alba","full_name":"openvstorage/alba","owner":{"login":"openvstorage","id":12763393,"avatar_url":"https://avatars.githubusercontent.com/u/12763393?v=3","gravatar_id":"","url":"https://api.github.com/users/openvstorage","html_url":"https://github.com/openvstorage","followers_url":"https://api.github.com/users/openvstorage/followers","following_url":"https://api.github.com/users/openvstorage/following{/other_user}","gists_url":"https://api.github.com/users/openvstorage/gists{/gist_id}","starred_url":"https://api.github.com/users/openvstorage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openvstorage/subscriptions","organizations_url":"https://api.github.com/users/openvstorage/orgs","repos_url":"https://api.github.com/users/openvstorage/repos","events_url":"https://api.github.com/users/openvstorage/events{/privacy}","received_events_url":"https://api.github.com/users/openvstorage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openvstorage/alba","description":"Open vStorage ALBA (alternate backend) creates a replicated or flexible network raid’ed  object storage backend out of Seagate Kinetic drives and local disk supporting compression, encryption.","fork":false,"url":"https://api.github.com/repos/openvstorage/alba","forks_url":"https://api.github.com/repos/openvstorage/alba/forks","keys_url":"https://api.github.com/repos/openvstorage/alba/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openvstorage/alba/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openvstorage/alba/teams","hooks_url":"https://api.github.com/repos/openvstorage/alba/hooks","issue_events_url":"https://api.github.com/repos/openvstorage/alba/issues/events{/number}","events_url":"https://api.github.com/repos/openvstorage/alba/events","assignees_url":"https://api.github.com/repos/openvstorage/alba/assignees{/user}","branches_url":"https://api.github.com/repos/openvstorage/alba/branches{/branch}","tags_url":"https://api.github.com/repos/openvstorage/alba/tags","blobs_url":"https://api.github.com/repos/openvstorage/alba/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openvstorage/alba/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openvstorage/alba/git/refs{/sha}","trees_url":"https://api.github.com/repos/openvstorage/alba/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openvstorage/alba/statuses/{sha}","languages_url":"https://api.github.com/repos/openvstorage/alba/languages","stargazers_url":"https://api.github.com/repos/openvstorage/alba/stargazers","contributors_url":"https://api.github.com/repos/openvstorage/alba/contributors","subscribers_url":"https://api.github.com/repos/openvstorage/alba/subscribers","subscription_url":"https://api.github.com/repos/openvstorage/alba/subscription","commits_url":"https://api.github.com/repos/openvstorage/alba/commits{/sha}","git_commits_url":"https://api.github.com/repos/openvstorage/alba/git/commits{/sha}","comments_url":"https://api.github.com/repos/openvstorage/alba/comments{/number}","issue_comment_url":"https://api.github.com/repos/openvstorage/alba/issues/comments{/number}","contents_url":"https://api.github.com/repos/openvstorage/alba/contents/{+path}","compare_url":"https://api.github.com/repos/openvstorage/alba/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openvstorage/alba/merges","archive_url":"https://api.github.com/repos/openvstorage/alba/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openvstorage/alba/downloads","issues_url":"https://api.github.com/repos/openvstorage/alba/issues{/number}","pulls_url":"https://api.github.com/repos/openvstorage/alba/pulls{/number}","milestones_url":"https://api.github.com/repos/openvstorage/alba/milestones{/number}","notifications_url":"https://api.github.com/repos/openvstorage/alba/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openvstorage/alba/labels{/name}","releases_url":"https://api.github.com/repos/openvstorage/alba/releases{/id}","deployments_url":"https://api.github.com/repos/openvstorage/alba/deployments","created_at":"2015-07-10T07:40:52Z","updated_at":"2016-10-25T09:54:12Z","pushed_at":"2016-12-15T10:13:15Z","git_url":"git://github.com/openvstorage/alba.git","ssh_url":"git@github.com:openvstorage/alba.git","clone_url":"https://github.com/openvstorage/alba.git","svn_url":"https://github.com/openvstorage/alba","homepage":"","size":35798,"stargazers_count":15,"watchers_count":15,"language":"OCaml","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":44,"forks":4,"open_issues":44,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openvstorage/alba/pulls/504"},"html":{"href":"https://github.com/openvstorage/alba/pull/504"},"issue":{"href":"https://api.github.com/repos/openvstorage/alba/issues/504"},"comments":{"href":"https://api.github.com/repos/openvstorage/alba/issues/504/comments"},"review_comments":{"href":"https://api.github.com/repos/openvstorage/alba/pulls/504/comments"},"review_comment":{"href":"https://api.github.com/repos/openvstorage/alba/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openvstorage/alba/pulls/504/commits"},"statuses":{"href":"https://api.github.com/repos/openvstorage/alba/statuses/0740b16b98b827078ad9f8bf6a28f6bb4c0c0610"}}}}
{"actor":{"display_login":"domsj"}}