{"action":"created","issue":{"url":"https://api.github.com/repos/spring-projects/spring-hateoas/issues/509","repository_url":"https://api.github.com/repos/spring-projects/spring-hateoas","labels_url":"https://api.github.com/repos/spring-projects/spring-hateoas/issues/509/labels{/name}","comments_url":"https://api.github.com/repos/spring-projects/spring-hateoas/issues/509/comments","events_url":"https://api.github.com/repos/spring-projects/spring-hateoas/issues/509/events","html_url":"https://github.com/spring-projects/spring-hateoas/issues/509","id":187317799,"number":509,"title":"ControllerLinkBuilder does not handle multiple X-Forwarded-* headers values","user":{"login":"smilasek","id":743696,"avatar_url":"https://avatars.githubusercontent.com/u/743696?v=3","gravatar_id":"","url":"https://api.github.com/users/smilasek","html_url":"https://github.com/smilasek","followers_url":"https://api.github.com/users/smilasek/followers","following_url":"https://api.github.com/users/smilasek/following{/other_user}","gists_url":"https://api.github.com/users/smilasek/gists{/gist_id}","starred_url":"https://api.github.com/users/smilasek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smilasek/subscriptions","organizations_url":"https://api.github.com/users/smilasek/orgs","repos_url":"https://api.github.com/users/smilasek/repos","events_url":"https://api.github.com/users/smilasek/events{/privacy}","received_events_url":"https://api.github.com/users/smilasek/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-11-04T12:08:44Z","updated_at":"2016-11-04T17:43:21Z","closed_at":null,"body":"Hi,\r\n\r\nSpring Cloud has released Camden.SR2 this week. It includes following bug fix from Spring Cloud Netflix project: https://github.com/spring-cloud/spring-cloud-netflix/issues/959.\r\nparticular commit: https://github.com/spring-cloud/spring-cloud-netflix/commit/a38b7b71ac8be9608ac2530dac41cd6298d696cf\r\n\r\nBased on that `X-Forwarded-Host`, `X-Forwarded-Port` and `X-Forwarded-Proto` could have multiple values separated by comma.\r\n\r\n`X-Forwarded-Host` is already handled properly by `ControllerLinkBuilder` (https://github.com/spring-projects/spring-hateoas/blob/642b6736764068ffeee38379629db5fc15cf927d/src/main/java/org/springframework/hateoas/mvc/ControllerLinkBuilder.java#L236-L256).\r\n\r\n`X-Forwarded-Port` and `X-Forwarded-Proto` are not.\r\n\r\nAdditionally for multiple values of `X-Forwarded-Port` header application is throwing `NumberFormatException`because of input values like `8080,443` etc.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/spring-projects/spring-hateoas/issues/comments/258500067","html_url":"https://github.com/spring-projects/spring-hateoas/issues/509#issuecomment-258500067","issue_url":"https://api.github.com/repos/spring-projects/spring-hateoas/issues/509","id":258500067,"user":{"login":"dsyer","id":124075,"avatar_url":"https://avatars.githubusercontent.com/u/124075?v=3","gravatar_id":"","url":"https://api.github.com/users/dsyer","html_url":"https://github.com/dsyer","followers_url":"https://api.github.com/users/dsyer/followers","following_url":"https://api.github.com/users/dsyer/following{/other_user}","gists_url":"https://api.github.com/users/dsyer/gists{/gist_id}","starred_url":"https://api.github.com/users/dsyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsyer/subscriptions","organizations_url":"https://api.github.com/users/dsyer/orgs","repos_url":"https://api.github.com/users/dsyer/repos","events_url":"https://api.github.com/users/dsyer/events{/privacy}","received_events_url":"https://api.github.com/users/dsyer/received_events","type":"User","site_admin":false},"created_at":"2016-11-04T17:43:21Z","updated_at":"2016-11-04T17:43:21Z","body":"There's no RFC for `X-Forwarded-Port` as far as I know. But it seems to be a common enough convention in proxies that we support it in Spring (https://github.com/spring-projects/spring-framework/blob/1f6f0dc101fb425bd63786ef669b0626a6591543/spring-web/src/main/java/org/springframework/web/util/UriComponentsBuilder.java#L674)."}}
{"actor":{"display_login":"dsyer"}}