{"action":"closed","number":151,"pull_request":{"url":"https://api.github.com/repos/orocos-toolchain/rtt/pulls/151","id":69861349,"html_url":"https://github.com/orocos-toolchain/rtt/pull/151","diff_url":"https://github.com/orocos-toolchain/rtt/pull/151.diff","patch_url":"https://github.com/orocos-toolchain/rtt/pull/151.patch","issue_url":"https://api.github.com/repos/orocos-toolchain/rtt/issues/151","number":151,"state":"closed","locked":false,"title":"corba: revert oneway writes and fixed connection cleanup and TAO builds","user":{"login":"meyerj","id":2506837,"avatar_url":"https://avatars.githubusercontent.com/u/2506837?v=3","gravatar_id":"","url":"https://api.github.com/users/meyerj","html_url":"https://github.com/meyerj","followers_url":"https://api.github.com/users/meyerj/followers","following_url":"https://api.github.com/users/meyerj/following{/other_user}","gists_url":"https://api.github.com/users/meyerj/gists{/gist_id}","starred_url":"https://api.github.com/users/meyerj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meyerj/subscriptions","organizations_url":"https://api.github.com/users/meyerj/orgs","repos_url":"https://api.github.com/users/meyerj/repos","events_url":"https://api.github.com/users/meyerj/events{/privacy}","received_events_url":"https://api.github.com/users/meyerj/received_events","type":"User","site_admin":false},"body":"This PR adds some patches that fix the behavior of the CORBA transport in the toolchain-2.9 branch, which is a merge of various features, especially the efficiency patches (#123) and the updated dataflow semantics (#114).\r\n\r\nThe first commit 63218b0 fixes an issue that broke the proper cleanup after one end of a CORBA connection terminates or crashes. Now the `RemoteChannelElement::write()` call would return the WriteStatus `NotConnected` and thus indirectly, via the dispatcher, cause the writing side to remove the connection from the port. This is basically the behavior of RTT versions before 2.9. It is up to the user to eventually reestablish broken connections if the port's write call returns `NotConnected` in case this is required.\r\n\r\nThe second commit f69a0b7 reintroduces the standard blocking two-ways CORBA calls unless RTT has been compiled with the cmake option `PLUGINS_CORBA_PORTS_WRITE_ONEWAY` enabled explicitly. See also discussion in #122 and #123 for further information on this issue. It is up to a future update to make this a run-time option, e.g. by adding a boolean field `reliable` to the ConnPolicy struct.\r\n\r\nThe last commit bc6503b fixes some small issues if RTT is compiled with TAO as underlying CORBA implementation and corrects some whitespace inconsistencies. It has been tested with TAO 2.3.1 and all the unit tests run successfully now.","created_at":"2016-05-12T15:51:58Z","updated_at":"2016-05-31T11:36:02Z","closed_at":"2016-05-31T11:36:02Z","merged_at":"2016-05-31T11:36:02Z","merge_commit_sha":"bc6503b7012f42a4d08a062839dee5fdead02ed5","assignee":null,"milestone":{"url":"https://api.github.com/repos/orocos-toolchain/rtt/milestones/3","html_url":"https://github.com/orocos-toolchain/rtt/milestones/2.9","labels_url":"https://api.github.com/repos/orocos-toolchain/rtt/milestones/3/labels","id":1187076,"number":3,"title":"2.9","description":"","creator":{"login":"meyerj","id":2506837,"avatar_url":"https://avatars.githubusercontent.com/u/2506837?v=3","gravatar_id":"","url":"https://api.github.com/users/meyerj","html_url":"https://github.com/meyerj","followers_url":"https://api.github.com/users/meyerj/followers","following_url":"https://api.github.com/users/meyerj/following{/other_user}","gists_url":"https://api.github.com/users/meyerj/gists{/gist_id}","starred_url":"https://api.github.com/users/meyerj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meyerj/subscriptions","organizations_url":"https://api.github.com/users/meyerj/orgs","repos_url":"https://api.github.com/users/meyerj/repos","events_url":"https://api.github.com/users/meyerj/events{/privacy}","received_events_url":"https://api.github.com/users/meyerj/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":5,"state":"open","created_at":"2015-06-30T13:18:31Z","updated_at":"2016-05-31T11:36:02Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/orocos-toolchain/rtt/pulls/151/commits","review_comments_url":"https://api.github.com/repos/orocos-toolchain/rtt/pulls/151/comments","review_comment_url":"https://api.github.com/repos/orocos-toolchain/rtt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/orocos-toolchain/rtt/issues/151/comments","statuses_url":"https://api.github.com/repos/orocos-toolchain/rtt/statuses/bc6503b7012f42a4d08a062839dee5fdead02ed5","head":{"label":"orocos-toolchain:toolchain-2.9-corba-efficiency-patches","ref":"toolchain-2.9-corba-efficiency-patches","sha":"bc6503b7012f42a4d08a062839dee5fdead02ed5","user":{"login":"orocos-toolchain","id":2902399,"avatar_url":"https://avatars.githubusercontent.com/u/2902399?v=3","gravatar_id":"","url":"https://api.github.com/users/orocos-toolchain","html_url":"https://github.com/orocos-toolchain","followers_url":"https://api.github.com/users/orocos-toolchain/followers","following_url":"https://api.github.com/users/orocos-toolchain/following{/other_user}","gists_url":"https://api.github.com/users/orocos-toolchain/gists{/gist_id}","starred_url":"https://api.github.com/users/orocos-toolchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orocos-toolchain/subscriptions","organizations_url":"https://api.github.com/users/orocos-toolchain/orgs","repos_url":"https://api.github.com/users/orocos-toolchain/repos","events_url":"https://api.github.com/users/orocos-toolchain/events{/privacy}","received_events_url":"https://api.github.com/users/orocos-toolchain/received_events","type":"Organization","site_admin":false},"repo":{"id":6884031,"name":"rtt","full_name":"orocos-toolchain/rtt","owner":{"login":"orocos-toolchain","id":2902399,"avatar_url":"https://avatars.githubusercontent.com/u/2902399?v=3","gravatar_id":"","url":"https://api.github.com/users/orocos-toolchain","html_url":"https://github.com/orocos-toolchain","followers_url":"https://api.github.com/users/orocos-toolchain/followers","following_url":"https://api.github.com/users/orocos-toolchain/following{/other_user}","gists_url":"https://api.github.com/users/orocos-toolchain/gists{/gist_id}","starred_url":"https://api.github.com/users/orocos-toolchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orocos-toolchain/subscriptions","organizations_url":"https://api.github.com/users/orocos-toolchain/orgs","repos_url":"https://api.github.com/users/orocos-toolchain/repos","events_url":"https://api.github.com/users/orocos-toolchain/events{/privacy}","received_events_url":"https://api.github.com/users/orocos-toolchain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/orocos-toolchain/rtt","description":"Real-Time Toolkit","fork":false,"url":"https://api.github.com/repos/orocos-toolchain/rtt","forks_url":"https://api.github.com/repos/orocos-toolchain/rtt/forks","keys_url":"https://api.github.com/repos/orocos-toolchain/rtt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/orocos-toolchain/rtt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/orocos-toolchain/rtt/teams","hooks_url":"https://api.github.com/repos/orocos-toolchain/rtt/hooks","issue_events_url":"https://api.github.com/repos/orocos-toolchain/rtt/issues/events{/number}","events_url":"https://api.github.com/repos/orocos-toolchain/rtt/events","assignees_url":"https://api.github.com/repos/orocos-toolchain/rtt/assignees{/user}","branches_url":"https://api.github.com/repos/orocos-toolchain/rtt/branches{/branch}","tags_url":"https://api.github.com/repos/orocos-toolchain/rtt/tags","blobs_url":"https://api.github.com/repos/orocos-toolchain/rtt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/orocos-toolchain/rtt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/orocos-toolchain/rtt/git/refs{/sha}","trees_url":"https://api.github.com/repos/orocos-toolchain/rtt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/orocos-toolchain/rtt/statuses/{sha}","languages_url":"https://api.github.com/repos/orocos-toolchain/rtt/languages","stargazers_url":"https://api.github.com/repos/orocos-toolchain/rtt/stargazers","contributors_url":"https://api.github.com/repos/orocos-toolchain/rtt/contributors","subscribers_url":"https://api.github.com/repos/orocos-toolchain/rtt/subscribers","subscription_url":"https://api.github.com/repos/orocos-toolchain/rtt/subscription","commits_url":"https://api.github.com/repos/orocos-toolchain/rtt/commits{/sha}","git_commits_url":"https://api.github.com/repos/orocos-toolchain/rtt/git/commits{/sha}","comments_url":"https://api.github.com/repos/orocos-toolchain/rtt/comments{/number}","issue_comment_url":"https://api.github.com/repos/orocos-toolchain/rtt/issues/comments{/number}","contents_url":"https://api.github.com/repos/orocos-toolchain/rtt/contents/{+path}","compare_url":"https://api.github.com/repos/orocos-toolchain/rtt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/orocos-toolchain/rtt/merges","archive_url":"https://api.github.com/repos/orocos-toolchain/rtt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/orocos-toolchain/rtt/downloads","issues_url":"https://api.github.com/repos/orocos-toolchain/rtt/issues{/number}","pulls_url":"https://api.github.com/repos/orocos-toolchain/rtt/pulls{/number}","milestones_url":"https://api.github.com/repos/orocos-toolchain/rtt/milestones{/number}","notifications_url":"https://api.github.com/repos/orocos-toolchain/rtt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/orocos-toolchain/rtt/labels{/name}","releases_url":"https://api.github.com/repos/orocos-toolchain/rtt/releases{/id}","deployments_url":"https://api.github.com/repos/orocos-toolchain/rtt/deployments","created_at":"2012-11-27T13:45:18Z","updated_at":"2016-04-20T07:40:20Z","pushed_at":"2016-05-31T11:36:02Z","git_url":"git://github.com/orocos-toolchain/rtt.git","ssh_url":"git@github.com:orocos-toolchain/rtt.git","clone_url":"https://github.com/orocos-toolchain/rtt.git","svn_url":"https://github.com/orocos-toolchain/rtt","homepage":"www.orocos.org","size":21803,"stargazers_count":10,"watchers_count":10,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":39,"forks":24,"open_issues":39,"watchers":10,"default_branch":"master"}},"base":{"label":"orocos-toolchain:toolchain-2.9","ref":"toolchain-2.9","sha":"c20f03798b492dd22a89241a14ba47d932481992","user":{"login":"orocos-toolchain","id":2902399,"avatar_url":"https://avatars.githubusercontent.com/u/2902399?v=3","gravatar_id":"","url":"https://api.github.com/users/orocos-toolchain","html_url":"https://github.com/orocos-toolchain","followers_url":"https://api.github.com/users/orocos-toolchain/followers","following_url":"https://api.github.com/users/orocos-toolchain/following{/other_user}","gists_url":"https://api.github.com/users/orocos-toolchain/gists{/gist_id}","starred_url":"https://api.github.com/users/orocos-toolchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orocos-toolchain/subscriptions","organizations_url":"https://api.github.com/users/orocos-toolchain/orgs","repos_url":"https://api.github.com/users/orocos-toolchain/repos","events_url":"https://api.github.com/users/orocos-toolchain/events{/privacy}","received_events_url":"https://api.github.com/users/orocos-toolchain/received_events","type":"Organization","site_admin":false},"repo":{"id":6884031,"name":"rtt","full_name":"orocos-toolchain/rtt","owner":{"login":"orocos-toolchain","id":2902399,"avatar_url":"https://avatars.githubusercontent.com/u/2902399?v=3","gravatar_id":"","url":"https://api.github.com/users/orocos-toolchain","html_url":"https://github.com/orocos-toolchain","followers_url":"https://api.github.com/users/orocos-toolchain/followers","following_url":"https://api.github.com/users/orocos-toolchain/following{/other_user}","gists_url":"https://api.github.com/users/orocos-toolchain/gists{/gist_id}","starred_url":"https://api.github.com/users/orocos-toolchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orocos-toolchain/subscriptions","organizations_url":"https://api.github.com/users/orocos-toolchain/orgs","repos_url":"https://api.github.com/users/orocos-toolchain/repos","events_url":"https://api.github.com/users/orocos-toolchain/events{/privacy}","received_events_url":"https://api.github.com/users/orocos-toolchain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/orocos-toolchain/rtt","description":"Real-Time Toolkit","fork":false,"url":"https://api.github.com/repos/orocos-toolchain/rtt","forks_url":"https://api.github.com/repos/orocos-toolchain/rtt/forks","keys_url":"https://api.github.com/repos/orocos-toolchain/rtt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/orocos-toolchain/rtt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/orocos-toolchain/rtt/teams","hooks_url":"https://api.github.com/repos/orocos-toolchain/rtt/hooks","issue_events_url":"https://api.github.com/repos/orocos-toolchain/rtt/issues/events{/number}","events_url":"https://api.github.com/repos/orocos-toolchain/rtt/events","assignees_url":"https://api.github.com/repos/orocos-toolchain/rtt/assignees{/user}","branches_url":"https://api.github.com/repos/orocos-toolchain/rtt/branches{/branch}","tags_url":"https://api.github.com/repos/orocos-toolchain/rtt/tags","blobs_url":"https://api.github.com/repos/orocos-toolchain/rtt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/orocos-toolchain/rtt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/orocos-toolchain/rtt/git/refs{/sha}","trees_url":"https://api.github.com/repos/orocos-toolchain/rtt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/orocos-toolchain/rtt/statuses/{sha}","languages_url":"https://api.github.com/repos/orocos-toolchain/rtt/languages","stargazers_url":"https://api.github.com/repos/orocos-toolchain/rtt/stargazers","contributors_url":"https://api.github.com/repos/orocos-toolchain/rtt/contributors","subscribers_url":"https://api.github.com/repos/orocos-toolchain/rtt/subscribers","subscription_url":"https://api.github.com/repos/orocos-toolchain/rtt/subscription","commits_url":"https://api.github.com/repos/orocos-toolchain/rtt/commits{/sha}","git_commits_url":"https://api.github.com/repos/orocos-toolchain/rtt/git/commits{/sha}","comments_url":"https://api.github.com/repos/orocos-toolchain/rtt/comments{/number}","issue_comment_url":"https://api.github.com/repos/orocos-toolchain/rtt/issues/comments{/number}","contents_url":"https://api.github.com/repos/orocos-toolchain/rtt/contents/{+path}","compare_url":"https://api.github.com/repos/orocos-toolchain/rtt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/orocos-toolchain/rtt/merges","archive_url":"https://api.github.com/repos/orocos-toolchain/rtt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/orocos-toolchain/rtt/downloads","issues_url":"https://api.github.com/repos/orocos-toolchain/rtt/issues{/number}","pulls_url":"https://api.github.com/repos/orocos-toolchain/rtt/pulls{/number}","milestones_url":"https://api.github.com/repos/orocos-toolchain/rtt/milestones{/number}","notifications_url":"https://api.github.com/repos/orocos-toolchain/rtt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/orocos-toolchain/rtt/labels{/name}","releases_url":"https://api.github.com/repos/orocos-toolchain/rtt/releases{/id}","deployments_url":"https://api.github.com/repos/orocos-toolchain/rtt/deployments","created_at":"2012-11-27T13:45:18Z","updated_at":"2016-04-20T07:40:20Z","pushed_at":"2016-05-31T11:36:02Z","git_url":"git://github.com/orocos-toolchain/rtt.git","ssh_url":"git@github.com:orocos-toolchain/rtt.git","clone_url":"https://github.com/orocos-toolchain/rtt.git","svn_url":"https://github.com/orocos-toolchain/rtt","homepage":"www.orocos.org","size":21803,"stargazers_count":10,"watchers_count":10,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":39,"forks":24,"open_issues":39,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/orocos-toolchain/rtt/pulls/151"},"html":{"href":"https://github.com/orocos-toolchain/rtt/pull/151"},"issue":{"href":"https://api.github.com/repos/orocos-toolchain/rtt/issues/151"},"comments":{"href":"https://api.github.com/repos/orocos-toolchain/rtt/issues/151/comments"},"review_comments":{"href":"https://api.github.com/repos/orocos-toolchain/rtt/pulls/151/comments"},"review_comment":{"href":"https://api.github.com/repos/orocos-toolchain/rtt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/orocos-toolchain/rtt/pulls/151/commits"},"statuses":{"href":"https://api.github.com/repos/orocos-toolchain/rtt/statuses/bc6503b7012f42a4d08a062839dee5fdead02ed5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"meyerj","id":2506837,"avatar_url":"https://avatars.githubusercontent.com/u/2506837?v=3","gravatar_id":"","url":"https://api.github.com/users/meyerj","html_url":"https://github.com/meyerj","followers_url":"https://api.github.com/users/meyerj/followers","following_url":"https://api.github.com/users/meyerj/following{/other_user}","gists_url":"https://api.github.com/users/meyerj/gists{/gist_id}","starred_url":"https://api.github.com/users/meyerj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meyerj/subscriptions","organizations_url":"https://api.github.com/users/meyerj/orgs","repos_url":"https://api.github.com/users/meyerj/repos","events_url":"https://api.github.com/users/meyerj/events{/privacy}","received_events_url":"https://api.github.com/users/meyerj/received_events","type":"User","site_admin":false},"comments":0,"review_comments":1,"commits":3,"additions":186,"deletions":162,"changed_files":14}}
{"actor":{"display_login":"meyerj"}}