{"action":"created","issue":{"url":"https://api.github.com/repos/Yelp/paasta/issues/744","repository_url":"https://api.github.com/repos/Yelp/paasta","labels_url":"https://api.github.com/repos/Yelp/paasta/issues/744/labels{/name}","comments_url":"https://api.github.com/repos/Yelp/paasta/issues/744/comments","events_url":"https://api.github.com/repos/Yelp/paasta/issues/744/events","html_url":"https://github.com/Yelp/paasta/pull/744","id":176065615,"number":744,"title":"Wait for deployment option","user":{"login":"mattmb","id":2462243,"avatar_url":"https://avatars.githubusercontent.com/u/2462243?v=3","gravatar_id":"","url":"https://api.github.com/users/mattmb","html_url":"https://github.com/mattmb","followers_url":"https://api.github.com/users/mattmb/followers","following_url":"https://api.github.com/users/mattmb/following{/other_user}","gists_url":"https://api.github.com/users/mattmb/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmb/subscriptions","organizations_url":"https://api.github.com/users/mattmb/orgs","repos_url":"https://api.github.com/users/mattmb/repos","events_url":"https://api.github.com/users/mattmb/events{/privacy}","received_events_url":"https://api.github.com/users/mattmb/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Yelp/paasta/labels/in%20review","name":"in review","color":"eac04b"}],"state":"open","locked":false,"assignee":{"login":"mattmb","id":2462243,"avatar_url":"https://avatars.githubusercontent.com/u/2462243?v=3","gravatar_id":"","url":"https://api.github.com/users/mattmb","html_url":"https://github.com/mattmb","followers_url":"https://api.github.com/users/mattmb/followers","following_url":"https://api.github.com/users/mattmb/following{/other_user}","gists_url":"https://api.github.com/users/mattmb/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmb/subscriptions","organizations_url":"https://api.github.com/users/mattmb/orgs","repos_url":"https://api.github.com/users/mattmb/repos","events_url":"https://api.github.com/users/mattmb/events{/privacy}","received_events_url":"https://api.github.com/users/mattmb/received_events","type":"User","site_admin":false},"assignees":[{"login":"mattmb","id":2462243,"avatar_url":"https://avatars.githubusercontent.com/u/2462243?v=3","gravatar_id":"","url":"https://api.github.com/users/mattmb","html_url":"https://github.com/mattmb","followers_url":"https://api.github.com/users/mattmb/followers","following_url":"https://api.github.com/users/mattmb/following{/other_user}","gists_url":"https://api.github.com/users/mattmb/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmb/subscriptions","organizations_url":"https://api.github.com/users/mattmb/orgs","repos_url":"https://api.github.com/users/mattmb/repos","events_url":"https://api.github.com/users/mattmb/events{/privacy}","received_events_url":"https://api.github.com/users/mattmb/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-09-09T17:37:07Z","updated_at":"2016-09-13T18:17:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Yelp/paasta/pulls/744","html_url":"https://github.com/Yelp/paasta/pull/744","diff_url":"https://github.com/Yelp/paasta/pull/744.diff","patch_url":"https://github.com/Yelp/paasta/pull/744.patch"},"body":"Still need to finish the unit tests and take a look at the itests.\r\n\r\nHowever, this mostly seems to work so let me know if you think this is the right way to do this. I'm thinking that I'll change the internal code to generate the paasta pipelines once this has shipped.\r\n\r\nI'm thinking that having `--wait-for-deployment` on should actually be the default but we can allow it to be disabled in the `deploy.yaml`. Something like:\r\n```\r\n- step: prod.main\r\n  wait_for_deployment: False\r\n```\r\n\r\nAnd set the timeout, something like:\r\n```\r\n- step: prod.main\r\n  wait_for_deployment: True\r\n  deployment_timeout: 600\r\n```"},"comment":{"url":"https://api.github.com/repos/Yelp/paasta/issues/comments/246773642","html_url":"https://github.com/Yelp/paasta/pull/744#issuecomment-246773642","issue_url":"https://api.github.com/repos/Yelp/paasta/issues/744","id":246773642,"user":{"login":"solarkennedy","id":370205,"avatar_url":"https://avatars.githubusercontent.com/u/370205?v=3","gravatar_id":"","url":"https://api.github.com/users/solarkennedy","html_url":"https://github.com/solarkennedy","followers_url":"https://api.github.com/users/solarkennedy/followers","following_url":"https://api.github.com/users/solarkennedy/following{/other_user}","gists_url":"https://api.github.com/users/solarkennedy/gists{/gist_id}","starred_url":"https://api.github.com/users/solarkennedy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solarkennedy/subscriptions","organizations_url":"https://api.github.com/users/solarkennedy/orgs","repos_url":"https://api.github.com/users/solarkennedy/repos","events_url":"https://api.github.com/users/solarkennedy/events{/privacy}","received_events_url":"https://api.github.com/users/solarkennedy/received_events","type":"User","site_admin":false},"created_at":"2016-09-13T18:17:23Z","updated_at":"2016-09-13T18:17:23Z","body":"I say ship and iterate!"}}
{"actor":{"display_login":"solarkennedy"}}