{"action":"created","comment":{"url":"https://api.github.com/repos/UW-Hydro/VIC/pulls/comments/62259969","id":62259969,"diff_hunk":"@@ -351,28 +355,38 @@ def run_system(config_file, vic_exe, test_data_dir, out_dir, driver):\n                                                         expectation))\n \n             # -------------------------------------------------------- #\n-            # check output files\n+            # check output files (different tests depending on driver)\n             if test_dict['check']:\n-                if 'complete' in test_dict['check']:\n-                    start = None\n-                    end = None\n-\n-                for fname in glob.glob(os.path.join(dirs['results'], '*')):\n-                    df = read_vic_ascii(fname, header=True)\n-                    # do numeric tests\n-\n-                    # check that each dataframe includes all timestamps\n                     if 'complete' in test_dict['check']:\n-                        if (start is not None) and (end is not None):\n-                            check_completed(df, start, end)\n-                        else:\n-                            start = df.index[0]\n-                            end = df.index[-1]\n-\n-                    # check for nans in the df\n-                    if 'nonans' in test_dict['check']:\n-                        check_for_nans(df)\n-            # -------------------------------------------------------- #\n+                        start = None\n+                        end = None\n+                        \n+                        if driver == \"classic\": \n+                    \n+                            for fname in glob.glob(os.path.join(dirs['results'], '*')):\n+                                df = read_vic_ascii(fname, header=True)\n+                                # do numeric tests\n+\n+                                # check that each dataframe includes all timestamps\n+                                if (start is not None) and (end is not None):\n+                                    check_completed(df, start, end)\n+                                else:\n+                                    start = df.index[0]\n+                                    end = df.index[-1]\n+\n+                    if 'output_file_nans' in test_dict['check']:\n+\n+                        if driver == \"classic\": \n+                            # check for nans in the df \n+                            check_for_nans(df) \n+\n+                        elif driver == \"image\": \n+                            # check for nans in domain file  \n+                            ds_domain = xr.open_dataset(os.path.join(test_dir, 'system', \n+                                                        test_dict['domain_file']))\n+                            ds_output = xr.open_dataset(os.path.join(dirs['results'], \n+                                                        'Stehekin.history.nc')) ","path":"tests/run_tests.py","position":81,"original_position":81,"commit_id":"5201cd6153e432a75cfc2373f0b50f2581b5c340","original_commit_id":"5201cd6153e432a75cfc2373f0b50f2581b5c340","user":{"login":"jhamman","id":2443309,"avatar_url":"https://avatars.githubusercontent.com/u/2443309?v=3","gravatar_id":"","url":"https://api.github.com/users/jhamman","html_url":"https://github.com/jhamman","followers_url":"https://api.github.com/users/jhamman/followers","following_url":"https://api.github.com/users/jhamman/following{/other_user}","gists_url":"https://api.github.com/users/jhamman/gists{/gist_id}","starred_url":"https://api.github.com/users/jhamman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhamman/subscriptions","organizations_url":"https://api.github.com/users/jhamman/orgs","repos_url":"https://api.github.com/users/jhamman/repos","events_url":"https://api.github.com/users/jhamman/events{/privacy}","received_events_url":"https://api.github.com/users/jhamman/received_events","type":"User","site_admin":false},"body":"Instead of hard-coding this file name, can we do a `glob` wildcard (`*.nc`) inside the results directory and check all files present?","created_at":"2016-05-05T21:39:37Z","updated_at":"2016-05-05T21:39:37Z","html_url":"https://github.com/UW-Hydro/VIC/pull/491#discussion_r62259969","pull_request_url":"https://api.github.com/repos/UW-Hydro/VIC/pulls/491","_links":{"self":{"href":"https://api.github.com/repos/UW-Hydro/VIC/pulls/comments/62259969"},"html":{"href":"https://github.com/UW-Hydro/VIC/pull/491#discussion_r62259969"},"pull_request":{"href":"https://api.github.com/repos/UW-Hydro/VIC/pulls/491"}}},"pull_request":{"url":"https://api.github.com/repos/UW-Hydro/VIC/pulls/491","id":68657639,"html_url":"https://github.com/UW-Hydro/VIC/pull/491","diff_url":"https://github.com/UW-Hydro/VIC/pull/491.diff","patch_url":"https://github.com/UW-Hydro/VIC/pull/491.patch","issue_url":"https://api.github.com/repos/UW-Hydro/VIC/issues/491","number":491,"state":"open","locked":false,"title":"changes to system test infrastructure and added tests to check output a…","user":{"login":"dgergel","id":5017308,"avatar_url":"https://avatars.githubusercontent.com/u/5017308?v=3","gravatar_id":"","url":"https://api.github.com/users/dgergel","html_url":"https://github.com/dgergel","followers_url":"https://api.github.com/users/dgergel/followers","following_url":"https://api.github.com/users/dgergel/following{/other_user}","gists_url":"https://api.github.com/users/dgergel/gists{/gist_id}","starred_url":"https://api.github.com/users/dgergel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgergel/subscriptions","organizations_url":"https://api.github.com/users/dgergel/orgs","repos_url":"https://api.github.com/users/dgergel/repos","events_url":"https://api.github.com/users/dgergel/events{/privacy}","received_events_url":"https://api.github.com/users/dgergel/received_events","type":"User","site_admin":false},"body":"…nd domain files for image driver","created_at":"2016-05-03T04:52:03Z","updated_at":"2016-05-05T21:39:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ceb9f60eff61092df581e3231c792bf0845d9e21","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/UW-Hydro/VIC/pulls/491/commits","review_comments_url":"https://api.github.com/repos/UW-Hydro/VIC/pulls/491/comments","review_comment_url":"https://api.github.com/repos/UW-Hydro/VIC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UW-Hydro/VIC/issues/491/comments","statuses_url":"https://api.github.com/repos/UW-Hydro/VIC/statuses/5201cd6153e432a75cfc2373f0b50f2581b5c340","head":{"label":"dgergel:feature/test_image_outputs","ref":"feature/test_image_outputs","sha":"5201cd6153e432a75cfc2373f0b50f2581b5c340","user":{"login":"dgergel","id":5017308,"avatar_url":"https://avatars.githubusercontent.com/u/5017308?v=3","gravatar_id":"","url":"https://api.github.com/users/dgergel","html_url":"https://github.com/dgergel","followers_url":"https://api.github.com/users/dgergel/followers","following_url":"https://api.github.com/users/dgergel/following{/other_user}","gists_url":"https://api.github.com/users/dgergel/gists{/gist_id}","starred_url":"https://api.github.com/users/dgergel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgergel/subscriptions","organizations_url":"https://api.github.com/users/dgergel/orgs","repos_url":"https://api.github.com/users/dgergel/repos","events_url":"https://api.github.com/users/dgergel/events{/privacy}","received_events_url":"https://api.github.com/users/dgergel/received_events","type":"User","site_admin":false},"repo":{"id":30215351,"name":"VIC","full_name":"dgergel/VIC","owner":{"login":"dgergel","id":5017308,"avatar_url":"https://avatars.githubusercontent.com/u/5017308?v=3","gravatar_id":"","url":"https://api.github.com/users/dgergel","html_url":"https://github.com/dgergel","followers_url":"https://api.github.com/users/dgergel/followers","following_url":"https://api.github.com/users/dgergel/following{/other_user}","gists_url":"https://api.github.com/users/dgergel/gists{/gist_id}","starred_url":"https://api.github.com/users/dgergel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgergel/subscriptions","organizations_url":"https://api.github.com/users/dgergel/orgs","repos_url":"https://api.github.com/users/dgergel/repos","events_url":"https://api.github.com/users/dgergel/events{/privacy}","received_events_url":"https://api.github.com/users/dgergel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dgergel/VIC","description":"The Variable Infiltration Capacity (VIC) Macroscale Hydrologic Model","fork":true,"url":"https://api.github.com/repos/dgergel/VIC","forks_url":"https://api.github.com/repos/dgergel/VIC/forks","keys_url":"https://api.github.com/repos/dgergel/VIC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dgergel/VIC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dgergel/VIC/teams","hooks_url":"https://api.github.com/repos/dgergel/VIC/hooks","issue_events_url":"https://api.github.com/repos/dgergel/VIC/issues/events{/number}","events_url":"https://api.github.com/repos/dgergel/VIC/events","assignees_url":"https://api.github.com/repos/dgergel/VIC/assignees{/user}","branches_url":"https://api.github.com/repos/dgergel/VIC/branches{/branch}","tags_url":"https://api.github.com/repos/dgergel/VIC/tags","blobs_url":"https://api.github.com/repos/dgergel/VIC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dgergel/VIC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dgergel/VIC/git/refs{/sha}","trees_url":"https://api.github.com/repos/dgergel/VIC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dgergel/VIC/statuses/{sha}","languages_url":"https://api.github.com/repos/dgergel/VIC/languages","stargazers_url":"https://api.github.com/repos/dgergel/VIC/stargazers","contributors_url":"https://api.github.com/repos/dgergel/VIC/contributors","subscribers_url":"https://api.github.com/repos/dgergel/VIC/subscribers","subscription_url":"https://api.github.com/repos/dgergel/VIC/subscription","commits_url":"https://api.github.com/repos/dgergel/VIC/commits{/sha}","git_commits_url":"https://api.github.com/repos/dgergel/VIC/git/commits{/sha}","comments_url":"https://api.github.com/repos/dgergel/VIC/comments{/number}","issue_comment_url":"https://api.github.com/repos/dgergel/VIC/issues/comments{/number}","contents_url":"https://api.github.com/repos/dgergel/VIC/contents/{+path}","compare_url":"https://api.github.com/repos/dgergel/VIC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dgergel/VIC/merges","archive_url":"https://api.github.com/repos/dgergel/VIC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dgergel/VIC/downloads","issues_url":"https://api.github.com/repos/dgergel/VIC/issues{/number}","pulls_url":"https://api.github.com/repos/dgergel/VIC/pulls{/number}","milestones_url":"https://api.github.com/repos/dgergel/VIC/milestones{/number}","notifications_url":"https://api.github.com/repos/dgergel/VIC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dgergel/VIC/labels{/name}","releases_url":"https://api.github.com/repos/dgergel/VIC/releases{/id}","deployments_url":"https://api.github.com/repos/dgergel/VIC/deployments","created_at":"2015-02-02T23:53:45Z","updated_at":"2016-03-24T20:15:28Z","pushed_at":"2016-05-05T19:24:49Z","git_url":"git://github.com/dgergel/VIC.git","ssh_url":"git@github.com:dgergel/VIC.git","clone_url":"https://github.com/dgergel/VIC.git","svn_url":"https://github.com/dgergel/VIC","homepage":"http://www.hydro.washington.edu/Lettenmaier/Models/VIC/index.shtml","size":13898,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"UW-Hydro:develop","ref":"develop","sha":"a4ba4ec790dad4483861b998227f269793caec38","user":{"login":"UW-Hydro","id":3475662,"avatar_url":"https://avatars.githubusercontent.com/u/3475662?v=3","gravatar_id":"","url":"https://api.github.com/users/UW-Hydro","html_url":"https://github.com/UW-Hydro","followers_url":"https://api.github.com/users/UW-Hydro/followers","following_url":"https://api.github.com/users/UW-Hydro/following{/other_user}","gists_url":"https://api.github.com/users/UW-Hydro/gists{/gist_id}","starred_url":"https://api.github.com/users/UW-Hydro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UW-Hydro/subscriptions","organizations_url":"https://api.github.com/users/UW-Hydro/orgs","repos_url":"https://api.github.com/users/UW-Hydro/repos","events_url":"https://api.github.com/users/UW-Hydro/events{/privacy}","received_events_url":"https://api.github.com/users/UW-Hydro/received_events","type":"Organization","site_admin":false},"repo":{"id":8064928,"name":"VIC","full_name":"UW-Hydro/VIC","owner":{"login":"UW-Hydro","id":3475662,"avatar_url":"https://avatars.githubusercontent.com/u/3475662?v=3","gravatar_id":"","url":"https://api.github.com/users/UW-Hydro","html_url":"https://github.com/UW-Hydro","followers_url":"https://api.github.com/users/UW-Hydro/followers","following_url":"https://api.github.com/users/UW-Hydro/following{/other_user}","gists_url":"https://api.github.com/users/UW-Hydro/gists{/gist_id}","starred_url":"https://api.github.com/users/UW-Hydro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UW-Hydro/subscriptions","organizations_url":"https://api.github.com/users/UW-Hydro/orgs","repos_url":"https://api.github.com/users/UW-Hydro/repos","events_url":"https://api.github.com/users/UW-Hydro/events{/privacy}","received_events_url":"https://api.github.com/users/UW-Hydro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UW-Hydro/VIC","description":"The Variable Infiltration Capacity (VIC) Macroscale Hydrologic Model","fork":false,"url":"https://api.github.com/repos/UW-Hydro/VIC","forks_url":"https://api.github.com/repos/UW-Hydro/VIC/forks","keys_url":"https://api.github.com/repos/UW-Hydro/VIC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UW-Hydro/VIC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UW-Hydro/VIC/teams","hooks_url":"https://api.github.com/repos/UW-Hydro/VIC/hooks","issue_events_url":"https://api.github.com/repos/UW-Hydro/VIC/issues/events{/number}","events_url":"https://api.github.com/repos/UW-Hydro/VIC/events","assignees_url":"https://api.github.com/repos/UW-Hydro/VIC/assignees{/user}","branches_url":"https://api.github.com/repos/UW-Hydro/VIC/branches{/branch}","tags_url":"https://api.github.com/repos/UW-Hydro/VIC/tags","blobs_url":"https://api.github.com/repos/UW-Hydro/VIC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UW-Hydro/VIC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UW-Hydro/VIC/git/refs{/sha}","trees_url":"https://api.github.com/repos/UW-Hydro/VIC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UW-Hydro/VIC/statuses/{sha}","languages_url":"https://api.github.com/repos/UW-Hydro/VIC/languages","stargazers_url":"https://api.github.com/repos/UW-Hydro/VIC/stargazers","contributors_url":"https://api.github.com/repos/UW-Hydro/VIC/contributors","subscribers_url":"https://api.github.com/repos/UW-Hydro/VIC/subscribers","subscription_url":"https://api.github.com/repos/UW-Hydro/VIC/subscription","commits_url":"https://api.github.com/repos/UW-Hydro/VIC/commits{/sha}","git_commits_url":"https://api.github.com/repos/UW-Hydro/VIC/git/commits{/sha}","comments_url":"https://api.github.com/repos/UW-Hydro/VIC/comments{/number}","issue_comment_url":"https://api.github.com/repos/UW-Hydro/VIC/issues/comments{/number}","contents_url":"https://api.github.com/repos/UW-Hydro/VIC/contents/{+path}","compare_url":"https://api.github.com/repos/UW-Hydro/VIC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UW-Hydro/VIC/merges","archive_url":"https://api.github.com/repos/UW-Hydro/VIC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UW-Hydro/VIC/downloads","issues_url":"https://api.github.com/repos/UW-Hydro/VIC/issues{/number}","pulls_url":"https://api.github.com/repos/UW-Hydro/VIC/pulls{/number}","milestones_url":"https://api.github.com/repos/UW-Hydro/VIC/milestones{/number}","notifications_url":"https://api.github.com/repos/UW-Hydro/VIC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UW-Hydro/VIC/labels{/name}","releases_url":"https://api.github.com/repos/UW-Hydro/VIC/releases{/id}","deployments_url":"https://api.github.com/repos/UW-Hydro/VIC/deployments","created_at":"2013-02-07T02:30:14Z","updated_at":"2016-04-27T22:42:13Z","pushed_at":"2016-05-05T21:03:41Z","git_url":"git://github.com/UW-Hydro/VIC.git","ssh_url":"git@github.com:UW-Hydro/VIC.git","clone_url":"https://github.com/UW-Hydro/VIC.git","svn_url":"https://github.com/UW-Hydro/VIC","homepage":"http://vic.readthedocs.io","size":21179,"stargazers_count":32,"watchers_count":32,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":110,"mirror_url":null,"open_issues_count":81,"forks":110,"open_issues":81,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UW-Hydro/VIC/pulls/491"},"html":{"href":"https://github.com/UW-Hydro/VIC/pull/491"},"issue":{"href":"https://api.github.com/repos/UW-Hydro/VIC/issues/491"},"comments":{"href":"https://api.github.com/repos/UW-Hydro/VIC/issues/491/comments"},"review_comments":{"href":"https://api.github.com/repos/UW-Hydro/VIC/pulls/491/comments"},"review_comment":{"href":"https://api.github.com/repos/UW-Hydro/VIC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UW-Hydro/VIC/pulls/491/commits"},"statuses":{"href":"https://api.github.com/repos/UW-Hydro/VIC/statuses/5201cd6153e432a75cfc2373f0b50f2581b5c340"}}}}