{"action":"created","issue":{"url":"https://api.github.com/repos/zestedesavoir/zds-site/issues/3945","repository_url":"https://api.github.com/repos/zestedesavoir/zds-site","labels_url":"https://api.github.com/repos/zestedesavoir/zds-site/issues/3945/labels{/name}","comments_url":"https://api.github.com/repos/zestedesavoir/zds-site/issues/3945/comments","events_url":"https://api.github.com/repos/zestedesavoir/zds-site/issues/3945/events","html_url":"https://github.com/zestedesavoir/zds-site/pull/3945","id":187590423,"number":3945,"title":"Nouvelle version markdown supportant @ping","user":{"login":"cgabard","id":6103932,"avatar_url":"https://avatars.githubusercontent.com/u/6103932?v=3","gravatar_id":"","url":"https://api.github.com/users/cgabard","html_url":"https://github.com/cgabard","followers_url":"https://api.github.com/users/cgabard/followers","following_url":"https://api.github.com/users/cgabard/following{/other_user}","gists_url":"https://api.github.com/users/cgabard/gists{/gist_id}","starred_url":"https://api.github.com/users/cgabard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgabard/subscriptions","organizations_url":"https://api.github.com/users/cgabard/orgs","repos_url":"https://api.github.com/users/cgabard/repos","events_url":"https://api.github.com/users/cgabard/events{/privacy}","received_events_url":"https://api.github.com/users/cgabard/received_events","type":"User","site_admin":false},"labels":[{"id":104879870,"url":"https://api.github.com/repos/zestedesavoir/zds-site/labels/C-Back","name":"C-Back","color":"207de5","default":false},{"id":68166147,"url":"https://api.github.com/repos/zestedesavoir/zds-site/labels/S-BUG","name":"S-BUG","color":"e11d21","default":false},{"id":68166149,"url":"https://api.github.com/repos/zestedesavoir/zds-site/labels/S-%C3%89volution","name":"S-Évolution","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":28,"created_at":"2016-11-06T21:27:17Z","updated_at":"2016-11-20T22:18:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/3945","html_url":"https://github.com/zestedesavoir/zds-site/pull/3945","diff_url":"https://github.com/zestedesavoir/zds-site/pull/3945.diff","patch_url":"https://github.com/zestedesavoir/zds-site/pull/3945.patch"},"body":"| Q                                   | R\r\n| ----------------------------------- | -------------------------------------------\r\n| Type de modification                | correction de bug / nouvelle fonctionnalité \r\n| Ticket(s) (_issue(s)_) concerné(s)  | -\r\n\r\n### QA\r\n\r\nBeaucoup de modifications. La principale est le support du ping grâce à @GerardPaligot \r\n\r\nConcernant le markdown, il y a beaucoup de corrections de bugs, principalement : \r\n\r\n - Support des règles de typographie (voir https://github.com/zestedesavoir/Python-ZMarkdown/blob/master-zds/tests/test_zds.py#L195 pour des exemples)\r\n - Bug sur les tableaux et des cellules qui disparaissent : https://github.com/zestedesavoir/Python-ZMarkdown/issues/119 ou https://github.com/zestedesavoir/Python-ZMarkdown/issues/107\r\n - Le support des légendes qui corrigent beaucoup des bugs, dont les légendes de balises math qui n'avaient jamais vraiment marché.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/zestedesavoir/zds-site/issues/comments/261810340","html_url":"https://github.com/zestedesavoir/zds-site/pull/3945#issuecomment-261810340","issue_url":"https://api.github.com/repos/zestedesavoir/zds-site/issues/3945","id":261810340,"user":{"login":"vhf","id":2022803,"avatar_url":"https://avatars.githubusercontent.com/u/2022803?v=3","gravatar_id":"","url":"https://api.github.com/users/vhf","html_url":"https://github.com/vhf","followers_url":"https://api.github.com/users/vhf/followers","following_url":"https://api.github.com/users/vhf/following{/other_user}","gists_url":"https://api.github.com/users/vhf/gists{/gist_id}","starred_url":"https://api.github.com/users/vhf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vhf/subscriptions","organizations_url":"https://api.github.com/users/vhf/orgs","repos_url":"https://api.github.com/users/vhf/repos","events_url":"https://api.github.com/users/vhf/events{/privacy}","received_events_url":"https://api.github.com/users/vhf/received_events","type":"User","site_admin":false},"created_at":"2016-11-20T22:18:12Z","updated_at":"2016-11-20T22:18:12Z","body":"Super !\r\n\r\nAlors je propose que vous ajoutiez un feature flag dans le settings.py qui soit True par défaut pour activer les pings.\r\n\r\nSi le flag n'est pas True, on met simplement `ping_url = None` [juste avant cette ligne](https://github.com/zestedesavoir/zds-site/pull/3945/files#diff-357416f7359afef7a8915d076461dad1R31).\r\n\r\nComme ça on a les pings derrière le flag, et travis passe dessus, et on s'évite un gros rebase, et on s'évite de l'instabilité en prod."}}
{"actor":{"display_login":"vhf"}}