{"action":"created","issue":{"url":"https://api.github.com/repos/ably/ably-js/issues/314","repository_url":"https://api.github.com/repos/ably/ably-js","labels_url":"https://api.github.com/repos/ably/ably-js/issues/314/labels{/name}","comments_url":"https://api.github.com/repos/ably/ably-js/issues/314/comments","events_url":"https://api.github.com/repos/ably/ably-js/issues/314/events","html_url":"https://github.com/ably/ably-js/pull/314","id":165372589,"number":314,"title":"Emit any pre-connnect auth errors in a way the onConnect listeners will handle","user":{"login":"SimonWoolf","id":5908687,"avatar_url":"https://avatars.githubusercontent.com/u/5908687?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonWoolf","html_url":"https://github.com/SimonWoolf","followers_url":"https://api.github.com/users/SimonWoolf/followers","following_url":"https://api.github.com/users/SimonWoolf/following{/other_user}","gists_url":"https://api.github.com/users/SimonWoolf/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonWoolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonWoolf/subscriptions","organizations_url":"https://api.github.com/users/SimonWoolf/orgs","repos_url":"https://api.github.com/users/SimonWoolf/repos","events_url":"https://api.github.com/users/SimonWoolf/events{/privacy}","received_events_url":"https://api.github.com/users/SimonWoolf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-07-13T17:06:45Z","updated_at":"2016-07-14T08:54:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ably/ably-js/pulls/314","html_url":"https://github.com/ably/ably-js/pull/314","diff_url":"https://github.com/ably/ably-js/pull/314.diff","patch_url":"https://github.com/ably/ably-js/pull/314.patch"},"body":"Fixes https://github.com/ably/ably-js/issues/311\r\n\r\n@paddybyers would you mind explaining a couple things when you have a sec?\r\n\r\n- What's the semantic difference between finishing a transport with `failed` (which is what aborting does) and finishing it with `error`? Any reason not to merge the two events, and avoid bugs like this where something's listening for one but not the other?\r\n\r\n- You have a `/* FIXME: this should not be fatal */` in the websocket `onerror` handler. Why not? Is it possible it'll ever be called with a nonfatal error? (the w3 spec is [very vague](https://www.w3.org/TR/websockets/#handler-websocket-onerror), and the websocket spec isn't much help either - it defines a lot of codes for the close frame, but doesn't mention any nonfatal errors that I can find). And if nonfatal errors are possible, why have the abort there at all -- why not just log them and rely on the `onclose` being called immediately after if the error was fatal?"},"comment":{"url":"https://api.github.com/repos/ably/ably-js/issues/comments/232606171","html_url":"https://github.com/ably/ably-js/pull/314#issuecomment-232606171","issue_url":"https://api.github.com/repos/ably/ably-js/issues/314","id":232606171,"user":{"login":"paddybyers","id":1137574,"avatar_url":"https://avatars.githubusercontent.com/u/1137574?v=3","gravatar_id":"","url":"https://api.github.com/users/paddybyers","html_url":"https://github.com/paddybyers","followers_url":"https://api.github.com/users/paddybyers/followers","following_url":"https://api.github.com/users/paddybyers/following{/other_user}","gists_url":"https://api.github.com/users/paddybyers/gists{/gist_id}","starred_url":"https://api.github.com/users/paddybyers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paddybyers/subscriptions","organizations_url":"https://api.github.com/users/paddybyers/orgs","repos_url":"https://api.github.com/users/paddybyers/repos","events_url":"https://api.github.com/users/paddybyers/events{/privacy}","received_events_url":"https://api.github.com/users/paddybyers/received_events","type":"User","site_admin":false},"created_at":"2016-07-14T08:54:30Z","updated_at":"2016-07-14T08:54:30Z","body":"LGTM BTW"}}
{"actor":{"display_login":"paddybyers"}}