{"action":"created","comment":{"url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/comments/56540715","id":56540715,"diff_hunk":"@@ -7194,6 +7194,10 @@ namespace SolarShading {\n \t\t\t} else {\n \t\t\t\tSUN3( DayOfYear, AvgSinSolarDeclin, AvgEqOfTime );\n \t\t\t\tAvgCosSolarDeclin = std::sqrt( 1.0 - pow_2( AvgSinSolarDeclin ) );\n+\t\t\t\t// trigger display of progress in the simulation every two weeks","path":"src/EnergyPlus/SolarShading.cc","position":4,"original_position":4,"commit_id":"0d207afd1c2d623839ded7ef117c40c5b866d73d","original_commit_id":"0d207afd1c2d623839ded7ef117c40c5b866d73d","user":{"login":"JasonGlazer","id":2582150,"avatar_url":"https://avatars.githubusercontent.com/u/2582150?v=3","gravatar_id":"","url":"https://api.github.com/users/JasonGlazer","html_url":"https://github.com/JasonGlazer","followers_url":"https://api.github.com/users/JasonGlazer/followers","following_url":"https://api.github.com/users/JasonGlazer/following{/other_user}","gists_url":"https://api.github.com/users/JasonGlazer/gists{/gist_id}","starred_url":"https://api.github.com/users/JasonGlazer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JasonGlazer/subscriptions","organizations_url":"https://api.github.com/users/JasonGlazer/orgs","repos_url":"https://api.github.com/users/JasonGlazer/repos","events_url":"https://api.github.com/users/JasonGlazer/events{/privacy}","received_events_url":"https://api.github.com/users/JasonGlazer/received_events","type":"User","site_admin":false},"body":"@Myoldmopar I don't think there are any side affects It gets used at:\r\n\r\nhttps://github.com/NREL/EnergyPlus/blob/develop/src/EnergyPlus/SimulationManager.cc#L548\r\n\r\nand\r\n\r\nhttps://github.com/NREL/EnergyPlus/blob/develop/src/EnergyPlus/HVACSizingSimulationManager.cc#L349\r\n\r\nBut just to trigger the output window display of \"Continuing Simulation at...\". It time that is displayed it is set to false.\r\n\r\n","created_at":"2016-03-17T17:09:13Z","updated_at":"2016-03-17T17:09:13Z","html_url":"https://github.com/NREL/EnergyPlus/pull/5553#discussion_r56540715","pull_request_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5553","_links":{"self":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/comments/56540715"},"html":{"href":"https://github.com/NREL/EnergyPlus/pull/5553#discussion_r56540715"},"pull_request":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5553"}}},"pull_request":{"url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5553","id":63115654,"html_url":"https://github.com/NREL/EnergyPlus/pull/5553","diff_url":"https://github.com/NREL/EnergyPlus/pull/5553.diff","patch_url":"https://github.com/NREL/EnergyPlus/pull/5553.patch","issue_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5553","number":5553,"state":"open","locked":false,"title":"Added trigger to display date every two weeks when shadow calculation is occurring every timestep","user":{"login":"JasonGlazer","id":2582150,"avatar_url":"https://avatars.githubusercontent.com/u/2582150?v=3","gravatar_id":"","url":"https://api.github.com/users/JasonGlazer","html_url":"https://github.com/JasonGlazer","followers_url":"https://api.github.com/users/JasonGlazer/followers","following_url":"https://api.github.com/users/JasonGlazer/following{/other_user}","gists_url":"https://api.github.com/users/JasonGlazer/gists{/gist_id}","starred_url":"https://api.github.com/users/JasonGlazer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JasonGlazer/subscriptions","organizations_url":"https://api.github.com/users/JasonGlazer/orgs","repos_url":"https://api.github.com/users/JasonGlazer/repos","events_url":"https://api.github.com/users/JasonGlazer/events{/privacy}","received_events_url":"https://api.github.com/users/JasonGlazer/received_events","type":"User","site_admin":false},"body":"Addresses #5365 to show progress on the output window even when shadowing calculations are being done every timestep. Added a display of the date every two weeks. \r\n\r\n - [ ] Functional code review (it has to work!)\r\n - [ ] CI status: all green or justified\r\n - [ ] Performance: CI Linux results include performance check -- verify this\r\n - [ ] Unit Test(s)\r\n","created_at":"2016-03-16T18:44:12Z","updated_at":"2016-03-17T17:09:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f34db0d3650eeb8852b23caa9082a2751d19bbbe","assignee":{"login":"JasonGlazer","id":2582150,"avatar_url":"https://avatars.githubusercontent.com/u/2582150?v=3","gravatar_id":"","url":"https://api.github.com/users/JasonGlazer","html_url":"https://github.com/JasonGlazer","followers_url":"https://api.github.com/users/JasonGlazer/followers","following_url":"https://api.github.com/users/JasonGlazer/following{/other_user}","gists_url":"https://api.github.com/users/JasonGlazer/gists{/gist_id}","starred_url":"https://api.github.com/users/JasonGlazer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JasonGlazer/subscriptions","organizations_url":"https://api.github.com/users/JasonGlazer/orgs","repos_url":"https://api.github.com/users/JasonGlazer/repos","events_url":"https://api.github.com/users/JasonGlazer/events{/privacy}","received_events_url":"https://api.github.com/users/JasonGlazer/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5553/commits","review_comments_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5553/comments","review_comment_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5553/comments","statuses_url":"https://api.github.com/repos/NREL/EnergyPlus/statuses/0d207afd1c2d623839ded7ef117c40c5b866d73d","head":{"label":"NREL:ShowProgressWhenTimestepFrequency","ref":"ShowProgressWhenTimestepFrequency","sha":"0d207afd1c2d623839ded7ef117c40c5b866d73d","user":{"login":"NREL","id":1906800,"avatar_url":"https://avatars.githubusercontent.com/u/1906800?v=3","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"repo":{"id":14620185,"name":"EnergyPlus","full_name":"NREL/EnergyPlus","owner":{"login":"NREL","id":1906800,"avatar_url":"https://avatars.githubusercontent.com/u/1906800?v=3","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NREL/EnergyPlus","description":"EnergyPlus™ is a whole building energy simulation program that engineers, architects, and researchers use to model both energy consumption and water use in buildings.","fork":false,"url":"https://api.github.com/repos/NREL/EnergyPlus","forks_url":"https://api.github.com/repos/NREL/EnergyPlus/forks","keys_url":"https://api.github.com/repos/NREL/EnergyPlus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NREL/EnergyPlus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NREL/EnergyPlus/teams","hooks_url":"https://api.github.com/repos/NREL/EnergyPlus/hooks","issue_events_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/events{/number}","events_url":"https://api.github.com/repos/NREL/EnergyPlus/events","assignees_url":"https://api.github.com/repos/NREL/EnergyPlus/assignees{/user}","branches_url":"https://api.github.com/repos/NREL/EnergyPlus/branches{/branch}","tags_url":"https://api.github.com/repos/NREL/EnergyPlus/tags","blobs_url":"https://api.github.com/repos/NREL/EnergyPlus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NREL/EnergyPlus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NREL/EnergyPlus/git/refs{/sha}","trees_url":"https://api.github.com/repos/NREL/EnergyPlus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NREL/EnergyPlus/statuses/{sha}","languages_url":"https://api.github.com/repos/NREL/EnergyPlus/languages","stargazers_url":"https://api.github.com/repos/NREL/EnergyPlus/stargazers","contributors_url":"https://api.github.com/repos/NREL/EnergyPlus/contributors","subscribers_url":"https://api.github.com/repos/NREL/EnergyPlus/subscribers","subscription_url":"https://api.github.com/repos/NREL/EnergyPlus/subscription","commits_url":"https://api.github.com/repos/NREL/EnergyPlus/commits{/sha}","git_commits_url":"https://api.github.com/repos/NREL/EnergyPlus/git/commits{/sha}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/comments{/number}","issue_comment_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/comments{/number}","contents_url":"https://api.github.com/repos/NREL/EnergyPlus/contents/{+path}","compare_url":"https://api.github.com/repos/NREL/EnergyPlus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NREL/EnergyPlus/merges","archive_url":"https://api.github.com/repos/NREL/EnergyPlus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NREL/EnergyPlus/downloads","issues_url":"https://api.github.com/repos/NREL/EnergyPlus/issues{/number}","pulls_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls{/number}","milestones_url":"https://api.github.com/repos/NREL/EnergyPlus/milestones{/number}","notifications_url":"https://api.github.com/repos/NREL/EnergyPlus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/labels{/name}","releases_url":"https://api.github.com/repos/NREL/EnergyPlus/releases{/id}","deployments_url":"https://api.github.com/repos/NREL/EnergyPlus/deployments","created_at":"2013-11-22T14:47:34Z","updated_at":"2016-03-13T18:09:38Z","pushed_at":"2016-03-17T16:53:30Z","git_url":"git://github.com/NREL/EnergyPlus.git","ssh_url":"git@github.com:NREL/EnergyPlus.git","clone_url":"https://github.com/NREL/EnergyPlus.git","svn_url":"https://github.com/NREL/EnergyPlus","homepage":"https://energyplus.net","size":249768,"stargazers_count":95,"watchers_count":95,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":64,"mirror_url":null,"open_issues_count":414,"forks":64,"open_issues":414,"watchers":95,"default_branch":"develop"}},"base":{"label":"NREL:develop","ref":"develop","sha":"a070fda4208c2abc79ab64729a4197d30d313cb8","user":{"login":"NREL","id":1906800,"avatar_url":"https://avatars.githubusercontent.com/u/1906800?v=3","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"repo":{"id":14620185,"name":"EnergyPlus","full_name":"NREL/EnergyPlus","owner":{"login":"NREL","id":1906800,"avatar_url":"https://avatars.githubusercontent.com/u/1906800?v=3","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NREL/EnergyPlus","description":"EnergyPlus™ is a whole building energy simulation program that engineers, architects, and researchers use to model both energy consumption and water use in buildings.","fork":false,"url":"https://api.github.com/repos/NREL/EnergyPlus","forks_url":"https://api.github.com/repos/NREL/EnergyPlus/forks","keys_url":"https://api.github.com/repos/NREL/EnergyPlus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NREL/EnergyPlus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NREL/EnergyPlus/teams","hooks_url":"https://api.github.com/repos/NREL/EnergyPlus/hooks","issue_events_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/events{/number}","events_url":"https://api.github.com/repos/NREL/EnergyPlus/events","assignees_url":"https://api.github.com/repos/NREL/EnergyPlus/assignees{/user}","branches_url":"https://api.github.com/repos/NREL/EnergyPlus/branches{/branch}","tags_url":"https://api.github.com/repos/NREL/EnergyPlus/tags","blobs_url":"https://api.github.com/repos/NREL/EnergyPlus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NREL/EnergyPlus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NREL/EnergyPlus/git/refs{/sha}","trees_url":"https://api.github.com/repos/NREL/EnergyPlus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NREL/EnergyPlus/statuses/{sha}","languages_url":"https://api.github.com/repos/NREL/EnergyPlus/languages","stargazers_url":"https://api.github.com/repos/NREL/EnergyPlus/stargazers","contributors_url":"https://api.github.com/repos/NREL/EnergyPlus/contributors","subscribers_url":"https://api.github.com/repos/NREL/EnergyPlus/subscribers","subscription_url":"https://api.github.com/repos/NREL/EnergyPlus/subscription","commits_url":"https://api.github.com/repos/NREL/EnergyPlus/commits{/sha}","git_commits_url":"https://api.github.com/repos/NREL/EnergyPlus/git/commits{/sha}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/comments{/number}","issue_comment_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/comments{/number}","contents_url":"https://api.github.com/repos/NREL/EnergyPlus/contents/{+path}","compare_url":"https://api.github.com/repos/NREL/EnergyPlus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NREL/EnergyPlus/merges","archive_url":"https://api.github.com/repos/NREL/EnergyPlus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NREL/EnergyPlus/downloads","issues_url":"https://api.github.com/repos/NREL/EnergyPlus/issues{/number}","pulls_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls{/number}","milestones_url":"https://api.github.com/repos/NREL/EnergyPlus/milestones{/number}","notifications_url":"https://api.github.com/repos/NREL/EnergyPlus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/labels{/name}","releases_url":"https://api.github.com/repos/NREL/EnergyPlus/releases{/id}","deployments_url":"https://api.github.com/repos/NREL/EnergyPlus/deployments","created_at":"2013-11-22T14:47:34Z","updated_at":"2016-03-13T18:09:38Z","pushed_at":"2016-03-17T16:53:30Z","git_url":"git://github.com/NREL/EnergyPlus.git","ssh_url":"git@github.com:NREL/EnergyPlus.git","clone_url":"https://github.com/NREL/EnergyPlus.git","svn_url":"https://github.com/NREL/EnergyPlus","homepage":"https://energyplus.net","size":249768,"stargazers_count":95,"watchers_count":95,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":64,"mirror_url":null,"open_issues_count":414,"forks":64,"open_issues":414,"watchers":95,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5553"},"html":{"href":"https://github.com/NREL/EnergyPlus/pull/5553"},"issue":{"href":"https://api.github.com/repos/NREL/EnergyPlus/issues/5553"},"comments":{"href":"https://api.github.com/repos/NREL/EnergyPlus/issues/5553/comments"},"review_comments":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5553/comments"},"review_comment":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5553/commits"},"statuses":{"href":"https://api.github.com/repos/NREL/EnergyPlus/statuses/0d207afd1c2d623839ded7ef117c40c5b866d73d"}}}}