{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/78017818","id":78017818,"diff_hunk":"@@ -133,23 +128,27 @@ impl<'a, 'tcx> MarkSymbolVisitor<'a, 'tcx> {\n \n     fn handle_field_access(&mut self, lhs: &hir::Expr, name: ast::Name) {\n         match self.tcx.expr_ty_adjusted(lhs).sty {\n-            ty::TyStruct(def, _) | ty::TyUnion(def, _) => {\n+            ty::TyAdt(def, _) => {\n                 self.insert_def_id(def.struct_variant().field_named(name).did);","path":"src/librustc/middle/dead.rs","position":29,"original_position":29,"commit_id":"84ebbcc0ae658a5128471580e92d6e29dac47d1d","original_commit_id":"84ebbcc0ae658a5128471580e92d6e29dac47d1d","user":{"login":"nagisa","id":679122,"avatar_url":"https://avatars.githubusercontent.com/u/679122?v=3","gravatar_id":"","url":"https://api.github.com/users/nagisa","html_url":"https://github.com/nagisa","followers_url":"https://api.github.com/users/nagisa/followers","following_url":"https://api.github.com/users/nagisa/following{/other_user}","gists_url":"https://api.github.com/users/nagisa/gists{/gist_id}","starred_url":"https://api.github.com/users/nagisa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nagisa/subscriptions","organizations_url":"https://api.github.com/users/nagisa/orgs","repos_url":"https://api.github.com/users/nagisa/repos","events_url":"https://api.github.com/users/nagisa/events{/privacy}","received_events_url":"https://api.github.com/users/nagisa/received_events","type":"User","site_admin":false},"body":"What happens here if  `sty` here was a `TyEnum` previously?","created_at":"2016-09-08T14:33:16Z","updated_at":"2016-09-08T14:33:16Z","html_url":"https://github.com/rust-lang/rust/pull/36331#discussion_r78017818","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/36331","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/78017818"},"html":{"href":"https://github.com/rust-lang/rust/pull/36331#discussion_r78017818"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/36331"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/36331","id":84374945,"html_url":"https://github.com/rust-lang/rust/pull/36331","diff_url":"https://github.com/rust-lang/rust/pull/36331.diff","patch_url":"https://github.com/rust-lang/rust/pull/36331.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/36331","number":36331,"state":"open","locked":false,"title":"Refactor `TyStruct`/`TyEnum`/`TyUnion` into `TyAdt`","user":{"login":"petrochenkov","id":5751617,"avatar_url":"https://avatars.githubusercontent.com/u/5751617?v=3","gravatar_id":"","url":"https://api.github.com/users/petrochenkov","html_url":"https://github.com/petrochenkov","followers_url":"https://api.github.com/users/petrochenkov/followers","following_url":"https://api.github.com/users/petrochenkov/following{/other_user}","gists_url":"https://api.github.com/users/petrochenkov/gists{/gist_id}","starred_url":"https://api.github.com/users/petrochenkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petrochenkov/subscriptions","organizations_url":"https://api.github.com/users/petrochenkov/orgs","repos_url":"https://api.github.com/users/petrochenkov/repos","events_url":"https://api.github.com/users/petrochenkov/events{/privacy}","received_events_url":"https://api.github.com/users/petrochenkov/received_events","type":"User","site_admin":false},"body":"r? @eddyb ","created_at":"2016-09-07T21:14:50Z","updated_at":"2016-09-08T14:33:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"59f9215d7877096ce85e3bd68cb9f5c0f3a1918c","assignee":{"login":"eddyb","id":77424,"avatar_url":"https://avatars.githubusercontent.com/u/77424?v=3","gravatar_id":"","url":"https://api.github.com/users/eddyb","html_url":"https://github.com/eddyb","followers_url":"https://api.github.com/users/eddyb/followers","following_url":"https://api.github.com/users/eddyb/following{/other_user}","gists_url":"https://api.github.com/users/eddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/eddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddyb/subscriptions","organizations_url":"https://api.github.com/users/eddyb/orgs","repos_url":"https://api.github.com/users/eddyb/repos","events_url":"https://api.github.com/users/eddyb/events{/privacy}","received_events_url":"https://api.github.com/users/eddyb/received_events","type":"User","site_admin":false},"assignees":[{"login":"eddyb","id":77424,"avatar_url":"https://avatars.githubusercontent.com/u/77424?v=3","gravatar_id":"","url":"https://api.github.com/users/eddyb","html_url":"https://github.com/eddyb","followers_url":"https://api.github.com/users/eddyb/followers","following_url":"https://api.github.com/users/eddyb/following{/other_user}","gists_url":"https://api.github.com/users/eddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/eddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddyb/subscriptions","organizations_url":"https://api.github.com/users/eddyb/orgs","repos_url":"https://api.github.com/users/eddyb/repos","events_url":"https://api.github.com/users/eddyb/events{/privacy}","received_events_url":"https://api.github.com/users/eddyb/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/36331/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/36331/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/36331/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/84ebbcc0ae658a5128471580e92d6e29dac47d1d","head":{"label":"petrochenkov:tyadt","ref":"tyadt","sha":"84ebbcc0ae658a5128471580e92d6e29dac47d1d","user":{"login":"petrochenkov","id":5751617,"avatar_url":"https://avatars.githubusercontent.com/u/5751617?v=3","gravatar_id":"","url":"https://api.github.com/users/petrochenkov","html_url":"https://github.com/petrochenkov","followers_url":"https://api.github.com/users/petrochenkov/followers","following_url":"https://api.github.com/users/petrochenkov/following{/other_user}","gists_url":"https://api.github.com/users/petrochenkov/gists{/gist_id}","starred_url":"https://api.github.com/users/petrochenkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petrochenkov/subscriptions","organizations_url":"https://api.github.com/users/petrochenkov/orgs","repos_url":"https://api.github.com/users/petrochenkov/repos","events_url":"https://api.github.com/users/petrochenkov/events{/privacy}","received_events_url":"https://api.github.com/users/petrochenkov/received_events","type":"User","site_admin":false},"repo":{"id":26977039,"name":"rust","full_name":"petrochenkov/rust","owner":{"login":"petrochenkov","id":5751617,"avatar_url":"https://avatars.githubusercontent.com/u/5751617?v=3","gravatar_id":"","url":"https://api.github.com/users/petrochenkov","html_url":"https://github.com/petrochenkov","followers_url":"https://api.github.com/users/petrochenkov/followers","following_url":"https://api.github.com/users/petrochenkov/following{/other_user}","gists_url":"https://api.github.com/users/petrochenkov/gists{/gist_id}","starred_url":"https://api.github.com/users/petrochenkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petrochenkov/subscriptions","organizations_url":"https://api.github.com/users/petrochenkov/orgs","repos_url":"https://api.github.com/users/petrochenkov/repos","events_url":"https://api.github.com/users/petrochenkov/events{/privacy}","received_events_url":"https://api.github.com/users/petrochenkov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/petrochenkov/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/petrochenkov/rust","forks_url":"https://api.github.com/repos/petrochenkov/rust/forks","keys_url":"https://api.github.com/repos/petrochenkov/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/petrochenkov/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/petrochenkov/rust/teams","hooks_url":"https://api.github.com/repos/petrochenkov/rust/hooks","issue_events_url":"https://api.github.com/repos/petrochenkov/rust/issues/events{/number}","events_url":"https://api.github.com/repos/petrochenkov/rust/events","assignees_url":"https://api.github.com/repos/petrochenkov/rust/assignees{/user}","branches_url":"https://api.github.com/repos/petrochenkov/rust/branches{/branch}","tags_url":"https://api.github.com/repos/petrochenkov/rust/tags","blobs_url":"https://api.github.com/repos/petrochenkov/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/petrochenkov/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/petrochenkov/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/petrochenkov/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/petrochenkov/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/petrochenkov/rust/languages","stargazers_url":"https://api.github.com/repos/petrochenkov/rust/stargazers","contributors_url":"https://api.github.com/repos/petrochenkov/rust/contributors","subscribers_url":"https://api.github.com/repos/petrochenkov/rust/subscribers","subscription_url":"https://api.github.com/repos/petrochenkov/rust/subscription","commits_url":"https://api.github.com/repos/petrochenkov/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/petrochenkov/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/petrochenkov/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/petrochenkov/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/petrochenkov/rust/contents/{+path}","compare_url":"https://api.github.com/repos/petrochenkov/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/petrochenkov/rust/merges","archive_url":"https://api.github.com/repos/petrochenkov/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/petrochenkov/rust/downloads","issues_url":"https://api.github.com/repos/petrochenkov/rust/issues{/number}","pulls_url":"https://api.github.com/repos/petrochenkov/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/petrochenkov/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/petrochenkov/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/petrochenkov/rust/labels{/name}","releases_url":"https://api.github.com/repos/petrochenkov/rust/releases{/id}","deployments_url":"https://api.github.com/repos/petrochenkov/rust/deployments","created_at":"2014-11-21T20:39:20Z","updated_at":"2016-01-14T18:00:04Z","pushed_at":"2016-09-07T21:31:16Z","git_url":"git://github.com/petrochenkov/rust.git","ssh_url":"git@github.com:petrochenkov/rust.git","clone_url":"https://github.com/petrochenkov/rust.git","svn_url":"https://github.com/petrochenkov/rust","homepage":"http://www.rust-lang.org","size":298374,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"cf0cdc452b3335eec4d0d5ec27e922763d9835bc","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2016-09-08T13:23:11Z","pushed_at":"2016-09-08T14:29:29Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":509776,"stargazers_count":18205,"watchers_count":18205,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3516,"mirror_url":null,"open_issues_count":2793,"forks":3516,"open_issues":2793,"watchers":18205,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/36331"},"html":{"href":"https://github.com/rust-lang/rust/pull/36331"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/36331"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/36331/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/36331/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/36331/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/84ebbcc0ae658a5128471580e92d6e29dac47d1d"}}}}
{"actor":{"display_login":"nagisa"}}