{"action":"closed","number":7721,"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/7721","id":60035994,"html_url":"https://github.com/ceph/ceph/pull/7721","diff_url":"https://github.com/ceph/ceph/pull/7721.diff","patch_url":"https://github.com/ceph/ceph/pull/7721.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/7721","number":7721,"state":"closed","locked":false,"title":"os/filestore: fix result handling logic of destroy_collection","user":{"login":"xiexingguo","id":14193361,"avatar_url":"https://avatars.githubusercontent.com/u/14193361?v=3","gravatar_id":"","url":"https://api.github.com/users/xiexingguo","html_url":"https://github.com/xiexingguo","followers_url":"https://api.github.com/users/xiexingguo/followers","following_url":"https://api.github.com/users/xiexingguo/following{/other_user}","gists_url":"https://api.github.com/users/xiexingguo/gists{/gist_id}","starred_url":"https://api.github.com/users/xiexingguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiexingguo/subscriptions","organizations_url":"https://api.github.com/users/xiexingguo/orgs","repos_url":"https://api.github.com/users/xiexingguo/repos","events_url":"https://api.github.com/users/xiexingguo/events{/privacy}","received_events_url":"https://api.github.com/users/xiexingguo/received_events","type":"User","site_admin":false},"body":"The problem here is if we fail to remove the original collection,\r\nwe may go on to removing the temp collection(if there is any) and\r\nsucceed(although the probability can be really small), then the\r\nresult code for the former operation can be overwritten, which is\r\nunsafe and can be misleading.\r\n\r\nThis pr solves the above problem by starting the process of\r\nparallelly removing a temp collection only if we succeed in\r\nremoving the original collection.\r\n\r\nSigned-off-by: xie xingguo <xie.xingguo@zte.com.cn>","created_at":"2016-02-20T03:31:45Z","updated_at":"2016-03-18T01:55:11Z","closed_at":"2016-03-18T01:55:11Z","merged_at":"2016-03-18T01:55:11Z","merge_commit_sha":"175857491a7f1896dabd330536028878423066c0","assignee":{"login":"tchaikov","id":59071,"avatar_url":"https://avatars.githubusercontent.com/u/59071?v=3","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/ceph/ceph/milestones/8","html_url":"https://github.com/ceph/ceph/milestones/jewel","labels_url":"https://api.github.com/repos/ceph/ceph/milestones/8/labels","id":1403256,"number":8,"title":"jewel","description":"","creator":{"login":"dillaman","id":4739042,"avatar_url":"https://avatars.githubusercontent.com/u/4739042?v=3","gravatar_id":"","url":"https://api.github.com/users/dillaman","html_url":"https://github.com/dillaman","followers_url":"https://api.github.com/users/dillaman/followers","following_url":"https://api.github.com/users/dillaman/following{/other_user}","gists_url":"https://api.github.com/users/dillaman/gists{/gist_id}","starred_url":"https://api.github.com/users/dillaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dillaman/subscriptions","organizations_url":"https://api.github.com/users/dillaman/orgs","repos_url":"https://api.github.com/users/dillaman/repos","events_url":"https://api.github.com/users/dillaman/events{/privacy}","received_events_url":"https://api.github.com/users/dillaman/received_events","type":"User","site_admin":false},"open_issues":30,"closed_issues":192,"state":"open","created_at":"2015-11-09T22:29:48Z","updated_at":"2016-03-18T01:55:11Z","due_on":"2016-03-20T04:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/7721/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/7721/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/7721/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/80dc45445ab8c8181e461a2eb819e8fcf4a9721d","head":{"label":"xiexingguo:xxg-wip-fixdc","ref":"xxg-wip-fixdc","sha":"80dc45445ab8c8181e461a2eb819e8fcf4a9721d","user":{"login":"xiexingguo","id":14193361,"avatar_url":"https://avatars.githubusercontent.com/u/14193361?v=3","gravatar_id":"","url":"https://api.github.com/users/xiexingguo","html_url":"https://github.com/xiexingguo","followers_url":"https://api.github.com/users/xiexingguo/followers","following_url":"https://api.github.com/users/xiexingguo/following{/other_user}","gists_url":"https://api.github.com/users/xiexingguo/gists{/gist_id}","starred_url":"https://api.github.com/users/xiexingguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiexingguo/subscriptions","organizations_url":"https://api.github.com/users/xiexingguo/orgs","repos_url":"https://api.github.com/users/xiexingguo/repos","events_url":"https://api.github.com/users/xiexingguo/events{/privacy}","received_events_url":"https://api.github.com/users/xiexingguo/received_events","type":"User","site_admin":false},"repo":{"id":45168396,"name":"ceph","full_name":"xiexingguo/ceph","owner":{"login":"xiexingguo","id":14193361,"avatar_url":"https://avatars.githubusercontent.com/u/14193361?v=3","gravatar_id":"","url":"https://api.github.com/users/xiexingguo","html_url":"https://github.com/xiexingguo","followers_url":"https://api.github.com/users/xiexingguo/followers","following_url":"https://api.github.com/users/xiexingguo/following{/other_user}","gists_url":"https://api.github.com/users/xiexingguo/gists{/gist_id}","starred_url":"https://api.github.com/users/xiexingguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiexingguo/subscriptions","organizations_url":"https://api.github.com/users/xiexingguo/orgs","repos_url":"https://api.github.com/users/xiexingguo/repos","events_url":"https://api.github.com/users/xiexingguo/events{/privacy}","received_events_url":"https://api.github.com/users/xiexingguo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xiexingguo/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/xiexingguo/ceph","forks_url":"https://api.github.com/repos/xiexingguo/ceph/forks","keys_url":"https://api.github.com/repos/xiexingguo/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xiexingguo/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xiexingguo/ceph/teams","hooks_url":"https://api.github.com/repos/xiexingguo/ceph/hooks","issue_events_url":"https://api.github.com/repos/xiexingguo/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/xiexingguo/ceph/events","assignees_url":"https://api.github.com/repos/xiexingguo/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/xiexingguo/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/xiexingguo/ceph/tags","blobs_url":"https://api.github.com/repos/xiexingguo/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xiexingguo/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xiexingguo/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/xiexingguo/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xiexingguo/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/xiexingguo/ceph/languages","stargazers_url":"https://api.github.com/repos/xiexingguo/ceph/stargazers","contributors_url":"https://api.github.com/repos/xiexingguo/ceph/contributors","subscribers_url":"https://api.github.com/repos/xiexingguo/ceph/subscribers","subscription_url":"https://api.github.com/repos/xiexingguo/ceph/subscription","commits_url":"https://api.github.com/repos/xiexingguo/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/xiexingguo/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/xiexingguo/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/xiexingguo/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/xiexingguo/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/xiexingguo/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xiexingguo/ceph/merges","archive_url":"https://api.github.com/repos/xiexingguo/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xiexingguo/ceph/downloads","issues_url":"https://api.github.com/repos/xiexingguo/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/xiexingguo/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/xiexingguo/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/xiexingguo/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xiexingguo/ceph/labels{/name}","releases_url":"https://api.github.com/repos/xiexingguo/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/xiexingguo/ceph/deployments","created_at":"2015-10-29T07:51:41Z","updated_at":"2016-01-11T08:49:47Z","pushed_at":"2016-03-17T14:05:10Z","git_url":"git://github.com/xiexingguo/ceph.git","ssh_url":"git@github.com:xiexingguo/ceph.git","clone_url":"https://github.com/xiexingguo/ceph.git","svn_url":"https://github.com/xiexingguo/ceph","homepage":"http://ceph.com","size":164288,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"0a92973bec3ddc034362471cd57c897c16e31309","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2016-03-17T23:07:20Z","pushed_at":"2016-03-18T01:55:11Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":207343,"stargazers_count":1960,"watchers_count":1960,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1200,"mirror_url":null,"open_issues_count":267,"forks":1200,"open_issues":267,"watchers":1960,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/7721"},"html":{"href":"https://github.com/ceph/ceph/pull/7721"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/7721"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/7721/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/7721/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/7721/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/80dc45445ab8c8181e461a2eb819e8fcf4a9721d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"liewegas","id":433031,"avatar_url":"https://avatars.githubusercontent.com/u/433031?v=3","gravatar_id":"","url":"https://api.github.com/users/liewegas","html_url":"https://github.com/liewegas","followers_url":"https://api.github.com/users/liewegas/followers","following_url":"https://api.github.com/users/liewegas/following{/other_user}","gists_url":"https://api.github.com/users/liewegas/gists{/gist_id}","starred_url":"https://api.github.com/users/liewegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liewegas/subscriptions","organizations_url":"https://api.github.com/users/liewegas/orgs","repos_url":"https://api.github.com/users/liewegas/repos","events_url":"https://api.github.com/users/liewegas/events{/privacy}","received_events_url":"https://api.github.com/users/liewegas/received_events","type":"User","site_admin":false},"comments":11,"review_comments":0,"commits":6,"additions":10,"deletions":7,"changed_files":1}}