{"action":"created","issue":{"url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/1425","repository_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine","labels_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/1425/labels{/name}","comments_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/1425/comments","events_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/1425/events","html_url":"https://github.com/TeamPorcupine/ProjectPorcupine/issues/1425","id":177950814,"number":1425,"title":"Missing English translations","user":{"login":"mikejbrown","id":855931,"avatar_url":"https://avatars.githubusercontent.com/u/855931?v=3","gravatar_id":"","url":"https://api.github.com/users/mikejbrown","html_url":"https://github.com/mikejbrown","followers_url":"https://api.github.com/users/mikejbrown/followers","following_url":"https://api.github.com/users/mikejbrown/following{/other_user}","gists_url":"https://api.github.com/users/mikejbrown/gists{/gist_id}","starred_url":"https://api.github.com/users/mikejbrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikejbrown/subscriptions","organizations_url":"https://api.github.com/users/mikejbrown/orgs","repos_url":"https://api.github.com/users/mikejbrown/repos","events_url":"https://api.github.com/users/mikejbrown/events{/privacy}","received_events_url":"https://api.github.com/users/mikejbrown/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/labels/bug","name":"bug","color":"ee0701"},{"url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/labels/help%20wanted","name":"help wanted","color":"128A0C"},{"url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/labels/localization","name":"localization","color":"006b75"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":23,"created_at":"2016-09-20T02:56:52Z","updated_at":"2016-09-25T16:03:03Z","closed_at":null,"body":"These are just the ones I found in a ~minutes play through. Feel free to add any others you find. (I am not expecting a separate issue for each language. This is only because en_US is the default and all keys should be there in the repo.)\r\n\r\n- [x] Translation for Empty in en_US language failed: Key not in dictionary.\r\n- [x] Translation for Floor in en_US language failed: Key not in dictionary.\r\n- [x] Translation for Ladder in en_US language failed: Key not in dictionary.\r\n- [x] Translation for furn_metal_furnace in en_US language failed: Key not in dictionary.\r\n- [x] Translation for furn_vent in en_US language failed: Key not in dictionary.\r\n- [x] Translation for util_power_cable in en_US language failed: Key not in dictionary.\r\n- [x] Translation for util_water_pipe in en_US language failed: Key not in dictionary.\r\n- [ ] Translation for  in en_US language failed: Key not in dictionary. (hmmm... not sure why this one was trying to access an empty key...)"},"comment":{"url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/comments/249429783","html_url":"https://github.com/TeamPorcupine/ProjectPorcupine/issues/1425#issuecomment-249429783","issue_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/1425","id":249429783,"user":{"login":"koosemose","id":6334643,"avatar_url":"https://avatars.githubusercontent.com/u/6334643?v=3","gravatar_id":"","url":"https://api.github.com/users/koosemose","html_url":"https://github.com/koosemose","followers_url":"https://api.github.com/users/koosemose/followers","following_url":"https://api.github.com/users/koosemose/following{/other_user}","gists_url":"https://api.github.com/users/koosemose/gists{/gist_id}","starred_url":"https://api.github.com/users/koosemose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koosemose/subscriptions","organizations_url":"https://api.github.com/users/koosemose/orgs","repos_url":"https://api.github.com/users/koosemose/repos","events_url":"https://api.github.com/users/koosemose/events{/privacy}","received_events_url":"https://api.github.com/users/koosemose/received_events","type":"User","site_admin":false},"created_at":"2016-09-25T16:03:03Z","updated_at":"2016-09-25T16:03:03Z","body":"If I remember correctly the reason for using the formatValues array was for things where the localization key for the object isn't everything, such as how the furniture buttons used to be, they would say, for example, Build Oxygen Generator, and originally we would just append the locale for build to the front... which is wrong because word order is going to be different in some languages, I think the formatValues is the solution to that, allowing the language to also feed in a string with the appropriate places for object's translated name to go, so we weren't forcing everything into english word order, which would be wrong for some languages (and the longer text we start having to have translated with some word arbitrarily inserted into it, the more languages trying it the old way without formatValues will be)."}}
{"actor":{"display_login":"koosemose"}}