{"action":"created","comment":{"url":"https://api.github.com/repos/gluon-lang/gluon/pulls/comments/92953639","pull_request_review_id":13474900,"id":92953639,"diff_hunk":"@@ -133,11 +133,8 @@ impl<I> Substitutable for ArcType<I> {\n     type Variable = TypeVariable;\n \n     fn new(id: u32) -> ArcType<I> {\n-        Type::variable(TypeVariable::new(id))\n-    }\n-\n-    fn from_variable(var: TypeVariable) -> ArcType<I> {\n-        Type::variable(var)\n+        // FIXME: using `Kind::hole()` here results in test failures\n+        Type::variable(TypeVariable::new(id, Kind::typ()))","path":"check/src/unify_type.rs","position":28,"original_position":28,"commit_id":"0c6ddf9b0d2808956f3e955ebb514b48639e35f1","original_commit_id":"2f8291a5a53a594f64c8a3387f38131ee5428071","user":{"login":"brendanzab","id":695077,"avatar_url":"https://avatars.githubusercontent.com/u/695077?v=3","gravatar_id":"","url":"https://api.github.com/users/brendanzab","html_url":"https://github.com/brendanzab","followers_url":"https://api.github.com/users/brendanzab/followers","following_url":"https://api.github.com/users/brendanzab/following{/other_user}","gists_url":"https://api.github.com/users/brendanzab/gists{/gist_id}","starred_url":"https://api.github.com/users/brendanzab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendanzab/subscriptions","organizations_url":"https://api.github.com/users/brendanzab/orgs","repos_url":"https://api.github.com/users/brendanzab/repos","events_url":"https://api.github.com/users/brendanzab/events{/privacy}","received_events_url":"https://api.github.com/users/brendanzab/received_events","type":"User","site_admin":false},"body":"The bane of premature abstraction 😆 \r\n\r\nI would like to have a look at how other type checkers do it... full disclosure - been experimenting with implementing a separate System-Fω checker in a local repo to learn how it works 😅 ","created_at":"2016-12-18T23:15:15Z","updated_at":"2016-12-18T23:15:15Z","html_url":"https://github.com/gluon-lang/gluon/pull/227#discussion_r92953639","pull_request_url":"https://api.github.com/repos/gluon-lang/gluon/pulls/227","_links":{"self":{"href":"https://api.github.com/repos/gluon-lang/gluon/pulls/comments/92953639"},"html":{"href":"https://github.com/gluon-lang/gluon/pull/227#discussion_r92953639"},"pull_request":{"href":"https://api.github.com/repos/gluon-lang/gluon/pulls/227"}}},"pull_request":{"url":"https://api.github.com/repos/gluon-lang/gluon/pulls/227","id":98460607,"html_url":"https://github.com/gluon-lang/gluon/pull/227","diff_url":"https://github.com/gluon-lang/gluon/pull/227.diff","patch_url":"https://github.com/gluon-lang/gluon/pull/227.patch","issue_url":"https://api.github.com/repos/gluon-lang/gluon/issues/227","number":227,"state":"open","locked":false,"title":"Never assume that the kind of a type variable is ‘type’","user":{"login":"brendanzab","id":695077,"avatar_url":"https://avatars.githubusercontent.com/u/695077?v=3","gravatar_id":"","url":"https://api.github.com/users/brendanzab","html_url":"https://github.com/brendanzab","followers_url":"https://api.github.com/users/brendanzab/followers","following_url":"https://api.github.com/users/brendanzab/following{/other_user}","gists_url":"https://api.github.com/users/brendanzab/gists{/gist_id}","starred_url":"https://api.github.com/users/brendanzab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendanzab/subscriptions","organizations_url":"https://api.github.com/users/brendanzab/orgs","repos_url":"https://api.github.com/users/brendanzab/repos","events_url":"https://api.github.com/users/brendanzab/events{/privacy}","received_events_url":"https://api.github.com/users/brendanzab/received_events","type":"User","site_admin":false},"body":"I was thinking this could show up some mistakes with kind instantiation.","created_at":"2016-12-18T00:32:02Z","updated_at":"2016-12-18T23:15:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a592a6902caa08fdfc2daa447bb15e89e6d0873","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/gluon-lang/gluon/pulls/227/commits","review_comments_url":"https://api.github.com/repos/gluon-lang/gluon/pulls/227/comments","review_comment_url":"https://api.github.com/repos/gluon-lang/gluon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gluon-lang/gluon/issues/227/comments","statuses_url":"https://api.github.com/repos/gluon-lang/gluon/statuses/0c6ddf9b0d2808956f3e955ebb514b48639e35f1","head":{"label":"brendanzab:type-variables","ref":"type-variables","sha":"0c6ddf9b0d2808956f3e955ebb514b48639e35f1","user":{"login":"brendanzab","id":695077,"avatar_url":"https://avatars.githubusercontent.com/u/695077?v=3","gravatar_id":"","url":"https://api.github.com/users/brendanzab","html_url":"https://github.com/brendanzab","followers_url":"https://api.github.com/users/brendanzab/followers","following_url":"https://api.github.com/users/brendanzab/following{/other_user}","gists_url":"https://api.github.com/users/brendanzab/gists{/gist_id}","starred_url":"https://api.github.com/users/brendanzab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendanzab/subscriptions","organizations_url":"https://api.github.com/users/brendanzab/orgs","repos_url":"https://api.github.com/users/brendanzab/repos","events_url":"https://api.github.com/users/brendanzab/events{/privacy}","received_events_url":"https://api.github.com/users/brendanzab/received_events","type":"User","site_admin":false},"repo":{"id":63468087,"name":"gluon","full_name":"brendanzab/gluon","owner":{"login":"brendanzab","id":695077,"avatar_url":"https://avatars.githubusercontent.com/u/695077?v=3","gravatar_id":"","url":"https://api.github.com/users/brendanzab","html_url":"https://github.com/brendanzab","followers_url":"https://api.github.com/users/brendanzab/followers","following_url":"https://api.github.com/users/brendanzab/following{/other_user}","gists_url":"https://api.github.com/users/brendanzab/gists{/gist_id}","starred_url":"https://api.github.com/users/brendanzab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendanzab/subscriptions","organizations_url":"https://api.github.com/users/brendanzab/orgs","repos_url":"https://api.github.com/users/brendanzab/repos","events_url":"https://api.github.com/users/brendanzab/events{/privacy}","received_events_url":"https://api.github.com/users/brendanzab/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brendanzab/gluon","description":"A static, type inferred and embeddable language written in Rust.","fork":true,"url":"https://api.github.com/repos/brendanzab/gluon","forks_url":"https://api.github.com/repos/brendanzab/gluon/forks","keys_url":"https://api.github.com/repos/brendanzab/gluon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brendanzab/gluon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brendanzab/gluon/teams","hooks_url":"https://api.github.com/repos/brendanzab/gluon/hooks","issue_events_url":"https://api.github.com/repos/brendanzab/gluon/issues/events{/number}","events_url":"https://api.github.com/repos/brendanzab/gluon/events","assignees_url":"https://api.github.com/repos/brendanzab/gluon/assignees{/user}","branches_url":"https://api.github.com/repos/brendanzab/gluon/branches{/branch}","tags_url":"https://api.github.com/repos/brendanzab/gluon/tags","blobs_url":"https://api.github.com/repos/brendanzab/gluon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brendanzab/gluon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brendanzab/gluon/git/refs{/sha}","trees_url":"https://api.github.com/repos/brendanzab/gluon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brendanzab/gluon/statuses/{sha}","languages_url":"https://api.github.com/repos/brendanzab/gluon/languages","stargazers_url":"https://api.github.com/repos/brendanzab/gluon/stargazers","contributors_url":"https://api.github.com/repos/brendanzab/gluon/contributors","subscribers_url":"https://api.github.com/repos/brendanzab/gluon/subscribers","subscription_url":"https://api.github.com/repos/brendanzab/gluon/subscription","commits_url":"https://api.github.com/repos/brendanzab/gluon/commits{/sha}","git_commits_url":"https://api.github.com/repos/brendanzab/gluon/git/commits{/sha}","comments_url":"https://api.github.com/repos/brendanzab/gluon/comments{/number}","issue_comment_url":"https://api.github.com/repos/brendanzab/gluon/issues/comments{/number}","contents_url":"https://api.github.com/repos/brendanzab/gluon/contents/{+path}","compare_url":"https://api.github.com/repos/brendanzab/gluon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brendanzab/gluon/merges","archive_url":"https://api.github.com/repos/brendanzab/gluon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brendanzab/gluon/downloads","issues_url":"https://api.github.com/repos/brendanzab/gluon/issues{/number}","pulls_url":"https://api.github.com/repos/brendanzab/gluon/pulls{/number}","milestones_url":"https://api.github.com/repos/brendanzab/gluon/milestones{/number}","notifications_url":"https://api.github.com/repos/brendanzab/gluon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brendanzab/gluon/labels{/name}","releases_url":"https://api.github.com/repos/brendanzab/gluon/releases{/id}","deployments_url":"https://api.github.com/repos/brendanzab/gluon/deployments","created_at":"2016-07-16T06:01:05Z","updated_at":"2016-07-16T06:01:07Z","pushed_at":"2016-12-18T10:53:12Z","git_url":"git://github.com/brendanzab/gluon.git","ssh_url":"git@github.com:brendanzab/gluon.git","clone_url":"https://github.com/brendanzab/gluon.git","svn_url":"https://github.com/brendanzab/gluon","homepage":"","size":3060,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gluon-lang:master","ref":"master","sha":"9adf8be8065ebeb385c94829ad2368c307c95d6e","user":{"login":"gluon-lang","id":22563494,"avatar_url":"https://avatars.githubusercontent.com/u/22563494?v=3","gravatar_id":"","url":"https://api.github.com/users/gluon-lang","html_url":"https://github.com/gluon-lang","followers_url":"https://api.github.com/users/gluon-lang/followers","following_url":"https://api.github.com/users/gluon-lang/following{/other_user}","gists_url":"https://api.github.com/users/gluon-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/gluon-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gluon-lang/subscriptions","organizations_url":"https://api.github.com/users/gluon-lang/orgs","repos_url":"https://api.github.com/users/gluon-lang/repos","events_url":"https://api.github.com/users/gluon-lang/events{/privacy}","received_events_url":"https://api.github.com/users/gluon-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":40078838,"name":"gluon","full_name":"gluon-lang/gluon","owner":{"login":"gluon-lang","id":22563494,"avatar_url":"https://avatars.githubusercontent.com/u/22563494?v=3","gravatar_id":"","url":"https://api.github.com/users/gluon-lang","html_url":"https://github.com/gluon-lang","followers_url":"https://api.github.com/users/gluon-lang/followers","following_url":"https://api.github.com/users/gluon-lang/following{/other_user}","gists_url":"https://api.github.com/users/gluon-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/gluon-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gluon-lang/subscriptions","organizations_url":"https://api.github.com/users/gluon-lang/orgs","repos_url":"https://api.github.com/users/gluon-lang/repos","events_url":"https://api.github.com/users/gluon-lang/events{/privacy}","received_events_url":"https://api.github.com/users/gluon-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gluon-lang/gluon","description":"A static, type inferred and embeddable language written in Rust.","fork":false,"url":"https://api.github.com/repos/gluon-lang/gluon","forks_url":"https://api.github.com/repos/gluon-lang/gluon/forks","keys_url":"https://api.github.com/repos/gluon-lang/gluon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gluon-lang/gluon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gluon-lang/gluon/teams","hooks_url":"https://api.github.com/repos/gluon-lang/gluon/hooks","issue_events_url":"https://api.github.com/repos/gluon-lang/gluon/issues/events{/number}","events_url":"https://api.github.com/repos/gluon-lang/gluon/events","assignees_url":"https://api.github.com/repos/gluon-lang/gluon/assignees{/user}","branches_url":"https://api.github.com/repos/gluon-lang/gluon/branches{/branch}","tags_url":"https://api.github.com/repos/gluon-lang/gluon/tags","blobs_url":"https://api.github.com/repos/gluon-lang/gluon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gluon-lang/gluon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gluon-lang/gluon/git/refs{/sha}","trees_url":"https://api.github.com/repos/gluon-lang/gluon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gluon-lang/gluon/statuses/{sha}","languages_url":"https://api.github.com/repos/gluon-lang/gluon/languages","stargazers_url":"https://api.github.com/repos/gluon-lang/gluon/stargazers","contributors_url":"https://api.github.com/repos/gluon-lang/gluon/contributors","subscribers_url":"https://api.github.com/repos/gluon-lang/gluon/subscribers","subscription_url":"https://api.github.com/repos/gluon-lang/gluon/subscription","commits_url":"https://api.github.com/repos/gluon-lang/gluon/commits{/sha}","git_commits_url":"https://api.github.com/repos/gluon-lang/gluon/git/commits{/sha}","comments_url":"https://api.github.com/repos/gluon-lang/gluon/comments{/number}","issue_comment_url":"https://api.github.com/repos/gluon-lang/gluon/issues/comments{/number}","contents_url":"https://api.github.com/repos/gluon-lang/gluon/contents/{+path}","compare_url":"https://api.github.com/repos/gluon-lang/gluon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gluon-lang/gluon/merges","archive_url":"https://api.github.com/repos/gluon-lang/gluon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gluon-lang/gluon/downloads","issues_url":"https://api.github.com/repos/gluon-lang/gluon/issues{/number}","pulls_url":"https://api.github.com/repos/gluon-lang/gluon/pulls{/number}","milestones_url":"https://api.github.com/repos/gluon-lang/gluon/milestones{/number}","notifications_url":"https://api.github.com/repos/gluon-lang/gluon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gluon-lang/gluon/labels{/name}","releases_url":"https://api.github.com/repos/gluon-lang/gluon/releases{/id}","deployments_url":"https://api.github.com/repos/gluon-lang/gluon/deployments","created_at":"2015-08-02T12:35:56Z","updated_at":"2016-12-08T17:38:26Z","pushed_at":"2016-12-18T21:07:10Z","git_url":"git://github.com/gluon-lang/gluon.git","ssh_url":"git@github.com:gluon-lang/gluon.git","clone_url":"https://github.com/gluon-lang/gluon.git","svn_url":"https://github.com/gluon-lang/gluon","homepage":"","size":10608,"stargazers_count":499,"watchers_count":499,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":22,"mirror_url":null,"open_issues_count":66,"forks":22,"open_issues":66,"watchers":499,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gluon-lang/gluon/pulls/227"},"html":{"href":"https://github.com/gluon-lang/gluon/pull/227"},"issue":{"href":"https://api.github.com/repos/gluon-lang/gluon/issues/227"},"comments":{"href":"https://api.github.com/repos/gluon-lang/gluon/issues/227/comments"},"review_comments":{"href":"https://api.github.com/repos/gluon-lang/gluon/pulls/227/comments"},"review_comment":{"href":"https://api.github.com/repos/gluon-lang/gluon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gluon-lang/gluon/pulls/227/commits"},"statuses":{"href":"https://api.github.com/repos/gluon-lang/gluon/statuses/0c6ddf9b0d2808956f3e955ebb514b48639e35f1"}}}}
{"actor":{"display_login":"brendanzab"}}