{"action":"created","issue":{"url":"https://api.github.com/repos/dsavransky/EXOSIMS/issues/9","repository_url":"https://api.github.com/repos/dsavransky/EXOSIMS","labels_url":"https://api.github.com/repos/dsavransky/EXOSIMS/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/dsavransky/EXOSIMS/issues/9/comments","events_url":"https://api.github.com/repos/dsavransky/EXOSIMS/issues/9/events","html_url":"https://github.com/dsavransky/EXOSIMS/issues/9","id":163273919,"number":9,"title":"CpCb attenuation","user":{"login":"rhondamorgan","id":13055696,"avatar_url":"https://avatars.githubusercontent.com/u/13055696?v=3","gravatar_id":"","url":"https://api.github.com/users/rhondamorgan","html_url":"https://github.com/rhondamorgan","followers_url":"https://api.github.com/users/rhondamorgan/followers","following_url":"https://api.github.com/users/rhondamorgan/following{/other_user}","gists_url":"https://api.github.com/users/rhondamorgan/gists{/gist_id}","starred_url":"https://api.github.com/users/rhondamorgan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhondamorgan/subscriptions","organizations_url":"https://api.github.com/users/rhondamorgan/orgs","repos_url":"https://api.github.com/users/rhondamorgan/repos","events_url":"https://api.github.com/users/rhondamorgan/events{/privacy}","received_events_url":"https://api.github.com/users/rhondamorgan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-06-30T21:44:31Z","updated_at":"2016-07-07T12:59:05Z","closed_at":null,"body":"in prototype OpticalSystem method CpCb, lines 432 and 433 use the telescope attenuation in the calculation of throughput:\r\nT = syst['throughput'](lam, WA) / inst['Ns'] \\\r\n                * self.attenuation**2               # throughput\r\n\r\nIt is my understanding from the defintion of telescope attenuation in the ICD, that the attenuation in the equation above should not be squared."},"comment":{"url":"https://api.github.com/repos/dsavransky/EXOSIMS/issues/comments/231069963","html_url":"https://github.com/dsavransky/EXOSIMS/issues/9#issuecomment-231069963","issue_url":"https://api.github.com/repos/dsavransky/EXOSIMS/issues/9","id":231069963,"user":{"login":"ChrisDelaX","id":12912366,"avatar_url":"https://avatars.githubusercontent.com/u/12912366?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisDelaX","html_url":"https://github.com/ChrisDelaX","followers_url":"https://api.github.com/users/ChrisDelaX/followers","following_url":"https://api.github.com/users/ChrisDelaX/following{/other_user}","gists_url":"https://api.github.com/users/ChrisDelaX/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisDelaX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisDelaX/subscriptions","organizations_url":"https://api.github.com/users/ChrisDelaX/orgs","repos_url":"https://api.github.com/users/ChrisDelaX/repos","events_url":"https://api.github.com/users/ChrisDelaX/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisDelaX/received_events","type":"User","site_admin":false},"created_at":"2016-07-07T12:59:05Z","updated_at":"2016-07-07T12:59:05Z","body":"OpticalSystem.attenuation is the overall attenuation of the optical elements up to the exit pupil (including any reduction due to an image plane mask), cf. Kasdin&Braems2006 paper, Eqn. (2). It is squared because the irradiance I ∝ E^2.  And indeed, this is different from the definition in the ICD. I can \r\n- either adapt the definition in the ICD to match the eta in Kasdin&Braems (and also adapt the definition in the modules documentation)\r\n- or remove the power 2, and keep the attenuation definition as it is."}}
{"actor":{"display_login":"ChrisDelaX"}}