{"action":"created","issue":{"url":"https://api.github.com/repos/commonsguy/cwac-provider/issues/15","repository_url":"https://api.github.com/repos/commonsguy/cwac-provider","labels_url":"https://api.github.com/repos/commonsguy/cwac-provider/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/commonsguy/cwac-provider/issues/15/comments","events_url":"https://api.github.com/repos/commonsguy/cwac-provider/issues/15/events","html_url":"https://github.com/commonsguy/cwac-provider/issues/15","id":169746321,"number":15,"title":"Is it desirable to extend LocalPathStrategy?","user":{"login":"mikrosk","id":3062260,"avatar_url":"https://avatars.githubusercontent.com/u/3062260?v=3","gravatar_id":"","url":"https://api.github.com/users/mikrosk","html_url":"https://github.com/mikrosk","followers_url":"https://api.github.com/users/mikrosk/followers","following_url":"https://api.github.com/users/mikrosk/following{/other_user}","gists_url":"https://api.github.com/users/mikrosk/gists{/gist_id}","starred_url":"https://api.github.com/users/mikrosk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikrosk/subscriptions","organizations_url":"https://api.github.com/users/mikrosk/orgs","repos_url":"https://api.github.com/users/mikrosk/repos","events_url":"https://api.github.com/users/mikrosk/events{/privacy}","received_events_url":"https://api.github.com/users/mikrosk/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-06T13:16:44Z","updated_at":"2016-08-06T23:27:35Z","closed_at":"2016-08-06T22:53:10Z","body":"I've finally managed to align my code with #11. I'd like to provide an `insert()` for my files so I've been thinking to just extend `LocalPathStrategy` and add this function. However, without `getFileForUri()` being `protected` it's very inconvenient. I'd rather avoid copying & pasting your code to a new stream strategy.\r\n\r\nSame goes for `StreamProvider`'s `buildPath()` but this method is not that long/complex so I could live with a small copied&pasted code at this occasion.\r\n\r\nAlso, it's not clear to me how I am supposed to work with `getValueForQueryColumn()`? If I have a new strategy, I will \"register\" it in `buildStrategy()` and then what? How can I access my (extended) strategy which is accessible through new columns? Should I make a private reference to it in `buildStrategy()`? (in this case the original strategies can't work with custom columns even if they could -- imagine a `getUniqueFilenameForThisUri()`)."},"comment":{"url":"https://api.github.com/repos/commonsguy/cwac-provider/issues/comments/238054233","html_url":"https://github.com/commonsguy/cwac-provider/issues/15#issuecomment-238054233","issue_url":"https://api.github.com/repos/commonsguy/cwac-provider/issues/15","id":238054233,"user":{"login":"mikrosk","id":3062260,"avatar_url":"https://avatars.githubusercontent.com/u/3062260?v=3","gravatar_id":"","url":"https://api.github.com/users/mikrosk","html_url":"https://github.com/mikrosk","followers_url":"https://api.github.com/users/mikrosk/followers","following_url":"https://api.github.com/users/mikrosk/following{/other_user}","gists_url":"https://api.github.com/users/mikrosk/gists{/gist_id}","starred_url":"https://api.github.com/users/mikrosk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikrosk/subscriptions","organizations_url":"https://api.github.com/users/mikrosk/orgs","repos_url":"https://api.github.com/users/mikrosk/repos","events_url":"https://api.github.com/users/mikrosk/events{/privacy}","received_events_url":"https://api.github.com/users/mikrosk/received_events","type":"User","site_admin":false},"created_at":"2016-08-06T23:27:35Z","updated_at":"2016-08-06T23:27:35Z","body":"> With regards to your first two paragraphs, are you asking me to make those methods protected, or are you asking something else? I am fine with making those protected, but I want to make sure that is what you are seeking.\r\nThat's exactly what am I seeking. :)\r\n\r\nAbout `getValueForQueryColumn()`: well, in my case, I wanted to make file's modification time accessible via a new column. So it's not a patch, just an extension. If you would like to continue this on SO, I'll post the question there."}}
{"actor":{"display_login":"mikrosk"}}