{"action":"created","issue":{"url":"https://api.github.com/repos/emoncms/emoncms/issues/603","repository_url":"https://api.github.com/repos/emoncms/emoncms","labels_url":"https://api.github.com/repos/emoncms/emoncms/issues/603/labels{/name}","comments_url":"https://api.github.com/repos/emoncms/emoncms/issues/603/comments","events_url":"https://api.github.com/repos/emoncms/emoncms/issues/603/events","html_url":"https://github.com/emoncms/emoncms/pull/603","id":189000364,"number":603,"title":"Validate variables after environment loaded","user":{"login":"spikeheap","id":464482,"avatar_url":"https://avatars.githubusercontent.com/u/464482?v=3","gravatar_id":"","url":"https://api.github.com/users/spikeheap","html_url":"https://github.com/spikeheap","followers_url":"https://api.github.com/users/spikeheap/followers","following_url":"https://api.github.com/users/spikeheap/following{/other_user}","gists_url":"https://api.github.com/users/spikeheap/gists{/gist_id}","starred_url":"https://api.github.com/users/spikeheap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spikeheap/subscriptions","organizations_url":"https://api.github.com/users/spikeheap/orgs","repos_url":"https://api.github.com/users/spikeheap/repos","events_url":"https://api.github.com/users/spikeheap/events{/privacy}","received_events_url":"https://api.github.com/users/spikeheap/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-13T22:35:27Z","updated_at":"2016-11-14T14:06:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/emoncms/emoncms/pulls/603","html_url":"https://github.com/emoncms/emoncms/pull/603","diff_url":"https://github.com/emoncms/emoncms/pull/603.diff","patch_url":"https://github.com/emoncms/emoncms/pull/603.patch"},"body":"This PR improves the recently merged environment variable support (https://github.com/emoncms/emoncms/pull/602) by validating the setup _after_ the environment variables have been pulled in. This has a couple of benefits:\r\n\r\n1. In a setup where environment variables are used, the config no longer needs to be duplicated in `settings.php`, but omitting the config from _both_ yields the correct error.\r\n2. Any validation added in future will be applied to values loaded from environment variables, making the behaviour consistent across config approaches.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/emoncms/emoncms/issues/comments/260343196","html_url":"https://github.com/emoncms/emoncms/pull/603#issuecomment-260343196","issue_url":"https://api.github.com/repos/emoncms/emoncms/issues/603","id":260343196,"user":{"login":"chaveiro","id":4527135,"avatar_url":"https://avatars.githubusercontent.com/u/4527135?v=3","gravatar_id":"","url":"https://api.github.com/users/chaveiro","html_url":"https://github.com/chaveiro","followers_url":"https://api.github.com/users/chaveiro/followers","following_url":"https://api.github.com/users/chaveiro/following{/other_user}","gists_url":"https://api.github.com/users/chaveiro/gists{/gist_id}","starred_url":"https://api.github.com/users/chaveiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaveiro/subscriptions","organizations_url":"https://api.github.com/users/chaveiro/orgs","repos_url":"https://api.github.com/users/chaveiro/repos","events_url":"https://api.github.com/users/chaveiro/events{/privacy}","received_events_url":"https://api.github.com/users/chaveiro/received_events","type":"User","site_admin":false},"created_at":"2016-11-14T14:06:47Z","updated_at":"2016-11-14T14:06:47Z","body":"Hi glyn, my recommendation to implement this feature : clone settings.php on a folder outside version control for each dev environment like settings.dev.php or settings.test.php and set ONE env variable to point emoncms to use that file accordingly to your environment.\r\n\r\nPros:\r\n    Code is cleaner.\r\n    Does not slow down emoncms with IF's, only one is used.\r\n    Supports every config usecase.\r\n    It's future proof.\r\n\r\nCons:\r\n    None.\r\n"}}
{"actor":{"display_login":"chaveiro"}}