{"action":"created","comment":{"url":"https://api.github.com/repos/ocsigen/ocsigen-start/pulls/comments/78944671","id":78944671,"diff_hunk":"@@ -30,8 +30,20 @@ ELIOMDEP          := $(ENV_PSQL) $(ELIOMDEP)\n # should be the same as ENV_PSQL)\n OCSIGENSERVER     := $(OCSIGENSERVER)\n OCSIGENSERVER.OPT := $(OCSIGENSERVER.OPT)\n+\n ## ---------------------------------------------------------------------\n \n+##----------------------------------------------------------------------\n+\n+pg_dump = pg_dump\n+\n+pg_ctl  = $(shell \\\n+           sh -c \"which pg_ctl\" || \\\n+           sh -c \"which pg_ctlcluster\" || \\\n+           sh -c \"if [ -f pg_ctl ]; then (echo ./pg_ctl) else (echo '') fi\")","path":"template.distillery/Makefile.db","position":14,"original_position":14,"commit_id":"21c27ad6957fcacb5a2b1fb093dfdb0032a9198d","original_commit_id":"21c27ad6957fcacb5a2b1fb093dfdb0032a9198d","user":{"login":"vasilisp","id":4950946,"avatar_url":"https://avatars.githubusercontent.com/u/4950946?v=3","gravatar_id":"","url":"https://api.github.com/users/vasilisp","html_url":"https://github.com/vasilisp","followers_url":"https://api.github.com/users/vasilisp/followers","following_url":"https://api.github.com/users/vasilisp/following{/other_user}","gists_url":"https://api.github.com/users/vasilisp/gists{/gist_id}","starred_url":"https://api.github.com/users/vasilisp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vasilisp/subscriptions","organizations_url":"https://api.github.com/users/vasilisp/orgs","repos_url":"https://api.github.com/users/vasilisp/repos","events_url":"https://api.github.com/users/vasilisp/events{/privacy}","received_events_url":"https://api.github.com/users/vasilisp/received_events","type":"User","site_admin":false},"body":"If we end up in the empty string case, the result will be very confusing error messages, no? Maybe make up an informational non-existent executable, e.g., `cannot_find_pg_ctl`.","created_at":"2016-09-15T11:43:53Z","updated_at":"2016-09-15T11:45:24Z","html_url":"https://github.com/ocsigen/ocsigen-start/pull/130#discussion_r78944671","pull_request_url":"https://api.github.com/repos/ocsigen/ocsigen-start/pulls/130","_links":{"self":{"href":"https://api.github.com/repos/ocsigen/ocsigen-start/pulls/comments/78944671"},"html":{"href":"https://github.com/ocsigen/ocsigen-start/pull/130#discussion_r78944671"},"pull_request":{"href":"https://api.github.com/repos/ocsigen/ocsigen-start/pulls/130"}}},"pull_request":{"url":"https://api.github.com/repos/ocsigen/ocsigen-start/pulls/130","id":85032552,"html_url":"https://github.com/ocsigen/ocsigen-start/pull/130","diff_url":"https://github.com/ocsigen/ocsigen-start/pull/130.diff","patch_url":"https://github.com/ocsigen/ocsigen-start/pull/130.patch","issue_url":"https://api.github.com/repos/ocsigen/ocsigen-start/issues/130","number":130,"state":"open","locked":false,"title":"From bs Makefile.bs: add db-snapshot rule.","user":{"login":"dannywillems","id":6018454,"avatar_url":"https://avatars.githubusercontent.com/u/6018454?v=3","gravatar_id":"","url":"https://api.github.com/users/dannywillems","html_url":"https://github.com/dannywillems","followers_url":"https://api.github.com/users/dannywillems/followers","following_url":"https://api.github.com/users/dannywillems/following{/other_user}","gists_url":"https://api.github.com/users/dannywillems/gists{/gist_id}","starred_url":"https://api.github.com/users/dannywillems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dannywillems/subscriptions","organizations_url":"https://api.github.com/users/dannywillems/orgs","repos_url":"https://api.github.com/users/dannywillems/repos","events_url":"https://api.github.com/users/dannywillems/events{/privacy}","received_events_url":"https://api.github.com/users/dannywillems/received_events","type":"User","site_admin":false},"body":"- Use DB_SNAPSHOT instead of DBSNAPSHOT and put this variable in Makefile.options.\r\n- Use a variable for pg_dump.\r\n\r\n### Makefile.db reorganisation\r\n- Move pg_dump and pg_ctl at the top (because all variables must be on the top).\r\n- Remove an useless empty new line.","created_at":"2016-09-13T11:43:21Z","updated_at":"2016-09-15T11:45:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a6079027d81d41b0ee28cae58c58138ae1dc527e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ocsigen/ocsigen-start/pulls/130/commits","review_comments_url":"https://api.github.com/repos/ocsigen/ocsigen-start/pulls/130/comments","review_comment_url":"https://api.github.com/repos/ocsigen/ocsigen-start/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ocsigen/ocsigen-start/issues/130/comments","statuses_url":"https://api.github.com/repos/ocsigen/ocsigen-start/statuses/21c27ad6957fcacb5a2b1fb093dfdb0032a9198d","head":{"label":"dannywillems:makefile_db_snapshot_target","ref":"makefile_db_snapshot_target","sha":"21c27ad6957fcacb5a2b1fb093dfdb0032a9198d","user":{"login":"dannywillems","id":6018454,"avatar_url":"https://avatars.githubusercontent.com/u/6018454?v=3","gravatar_id":"","url":"https://api.github.com/users/dannywillems","html_url":"https://github.com/dannywillems","followers_url":"https://api.github.com/users/dannywillems/followers","following_url":"https://api.github.com/users/dannywillems/following{/other_user}","gists_url":"https://api.github.com/users/dannywillems/gists{/gist_id}","starred_url":"https://api.github.com/users/dannywillems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dannywillems/subscriptions","organizations_url":"https://api.github.com/users/dannywillems/orgs","repos_url":"https://api.github.com/users/dannywillems/repos","events_url":"https://api.github.com/users/dannywillems/events{/privacy}","received_events_url":"https://api.github.com/users/dannywillems/received_events","type":"User","site_admin":false},"repo":{"id":67039409,"name":"ocsigen-start","full_name":"dannywillems/ocsigen-start","owner":{"login":"dannywillems","id":6018454,"avatar_url":"https://avatars.githubusercontent.com/u/6018454?v=3","gravatar_id":"","url":"https://api.github.com/users/dannywillems","html_url":"https://github.com/dannywillems","followers_url":"https://api.github.com/users/dannywillems/followers","following_url":"https://api.github.com/users/dannywillems/following{/other_user}","gists_url":"https://api.github.com/users/dannywillems/gists{/gist_id}","starred_url":"https://api.github.com/users/dannywillems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dannywillems/subscriptions","organizations_url":"https://api.github.com/users/dannywillems/orgs","repos_url":"https://api.github.com/users/dannywillems/repos","events_url":"https://api.github.com/users/dannywillems/events{/privacy}","received_events_url":"https://api.github.com/users/dannywillems/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dannywillems/ocsigen-start","description":"Eliom Base Application: an Eliom application skeleton ready to use to build your own application with users, (pre)registration, notifications, etc.","fork":true,"url":"https://api.github.com/repos/dannywillems/ocsigen-start","forks_url":"https://api.github.com/repos/dannywillems/ocsigen-start/forks","keys_url":"https://api.github.com/repos/dannywillems/ocsigen-start/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dannywillems/ocsigen-start/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dannywillems/ocsigen-start/teams","hooks_url":"https://api.github.com/repos/dannywillems/ocsigen-start/hooks","issue_events_url":"https://api.github.com/repos/dannywillems/ocsigen-start/issues/events{/number}","events_url":"https://api.github.com/repos/dannywillems/ocsigen-start/events","assignees_url":"https://api.github.com/repos/dannywillems/ocsigen-start/assignees{/user}","branches_url":"https://api.github.com/repos/dannywillems/ocsigen-start/branches{/branch}","tags_url":"https://api.github.com/repos/dannywillems/ocsigen-start/tags","blobs_url":"https://api.github.com/repos/dannywillems/ocsigen-start/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dannywillems/ocsigen-start/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dannywillems/ocsigen-start/git/refs{/sha}","trees_url":"https://api.github.com/repos/dannywillems/ocsigen-start/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dannywillems/ocsigen-start/statuses/{sha}","languages_url":"https://api.github.com/repos/dannywillems/ocsigen-start/languages","stargazers_url":"https://api.github.com/repos/dannywillems/ocsigen-start/stargazers","contributors_url":"https://api.github.com/repos/dannywillems/ocsigen-start/contributors","subscribers_url":"https://api.github.com/repos/dannywillems/ocsigen-start/subscribers","subscription_url":"https://api.github.com/repos/dannywillems/ocsigen-start/subscription","commits_url":"https://api.github.com/repos/dannywillems/ocsigen-start/commits{/sha}","git_commits_url":"https://api.github.com/repos/dannywillems/ocsigen-start/git/commits{/sha}","comments_url":"https://api.github.com/repos/dannywillems/ocsigen-start/comments{/number}","issue_comment_url":"https://api.github.com/repos/dannywillems/ocsigen-start/issues/comments{/number}","contents_url":"https://api.github.com/repos/dannywillems/ocsigen-start/contents/{+path}","compare_url":"https://api.github.com/repos/dannywillems/ocsigen-start/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dannywillems/ocsigen-start/merges","archive_url":"https://api.github.com/repos/dannywillems/ocsigen-start/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dannywillems/ocsigen-start/downloads","issues_url":"https://api.github.com/repos/dannywillems/ocsigen-start/issues{/number}","pulls_url":"https://api.github.com/repos/dannywillems/ocsigen-start/pulls{/number}","milestones_url":"https://api.github.com/repos/dannywillems/ocsigen-start/milestones{/number}","notifications_url":"https://api.github.com/repos/dannywillems/ocsigen-start/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dannywillems/ocsigen-start/labels{/name}","releases_url":"https://api.github.com/repos/dannywillems/ocsigen-start/releases{/id}","deployments_url":"https://api.github.com/repos/dannywillems/ocsigen-start/deployments","created_at":"2016-08-31T13:22:31Z","updated_at":"2016-08-31T13:22:33Z","pushed_at":"2016-09-15T11:26:35Z","git_url":"git://github.com/dannywillems/ocsigen-start.git","ssh_url":"git@github.com:dannywillems/ocsigen-start.git","clone_url":"https://github.com/dannywillems/ocsigen-start.git","svn_url":"https://github.com/dannywillems/ocsigen-start","homepage":"","size":2061,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ocsigen:master","ref":"master","sha":"880638d5ab3cdfede2541d74f0f38569067a34cd","user":{"login":"ocsigen","id":4729424,"avatar_url":"https://avatars.githubusercontent.com/u/4729424?v=3","gravatar_id":"","url":"https://api.github.com/users/ocsigen","html_url":"https://github.com/ocsigen","followers_url":"https://api.github.com/users/ocsigen/followers","following_url":"https://api.github.com/users/ocsigen/following{/other_user}","gists_url":"https://api.github.com/users/ocsigen/gists{/gist_id}","starred_url":"https://api.github.com/users/ocsigen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocsigen/subscriptions","organizations_url":"https://api.github.com/users/ocsigen/orgs","repos_url":"https://api.github.com/users/ocsigen/repos","events_url":"https://api.github.com/users/ocsigen/events{/privacy}","received_events_url":"https://api.github.com/users/ocsigen/received_events","type":"Organization","site_admin":false},"repo":{"id":11151396,"name":"ocsigen-start","full_name":"ocsigen/ocsigen-start","owner":{"login":"ocsigen","id":4729424,"avatar_url":"https://avatars.githubusercontent.com/u/4729424?v=3","gravatar_id":"","url":"https://api.github.com/users/ocsigen","html_url":"https://github.com/ocsigen","followers_url":"https://api.github.com/users/ocsigen/followers","following_url":"https://api.github.com/users/ocsigen/following{/other_user}","gists_url":"https://api.github.com/users/ocsigen/gists{/gist_id}","starred_url":"https://api.github.com/users/ocsigen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocsigen/subscriptions","organizations_url":"https://api.github.com/users/ocsigen/orgs","repos_url":"https://api.github.com/users/ocsigen/repos","events_url":"https://api.github.com/users/ocsigen/events{/privacy}","received_events_url":"https://api.github.com/users/ocsigen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ocsigen/ocsigen-start","description":"Eliom Base Application: an Eliom application skeleton ready to use to build your own application with users, (pre)registration, notifications, etc.","fork":false,"url":"https://api.github.com/repos/ocsigen/ocsigen-start","forks_url":"https://api.github.com/repos/ocsigen/ocsigen-start/forks","keys_url":"https://api.github.com/repos/ocsigen/ocsigen-start/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocsigen/ocsigen-start/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocsigen/ocsigen-start/teams","hooks_url":"https://api.github.com/repos/ocsigen/ocsigen-start/hooks","issue_events_url":"https://api.github.com/repos/ocsigen/ocsigen-start/issues/events{/number}","events_url":"https://api.github.com/repos/ocsigen/ocsigen-start/events","assignees_url":"https://api.github.com/repos/ocsigen/ocsigen-start/assignees{/user}","branches_url":"https://api.github.com/repos/ocsigen/ocsigen-start/branches{/branch}","tags_url":"https://api.github.com/repos/ocsigen/ocsigen-start/tags","blobs_url":"https://api.github.com/repos/ocsigen/ocsigen-start/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocsigen/ocsigen-start/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocsigen/ocsigen-start/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocsigen/ocsigen-start/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocsigen/ocsigen-start/statuses/{sha}","languages_url":"https://api.github.com/repos/ocsigen/ocsigen-start/languages","stargazers_url":"https://api.github.com/repos/ocsigen/ocsigen-start/stargazers","contributors_url":"https://api.github.com/repos/ocsigen/ocsigen-start/contributors","subscribers_url":"https://api.github.com/repos/ocsigen/ocsigen-start/subscribers","subscription_url":"https://api.github.com/repos/ocsigen/ocsigen-start/subscription","commits_url":"https://api.github.com/repos/ocsigen/ocsigen-start/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocsigen/ocsigen-start/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocsigen/ocsigen-start/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocsigen/ocsigen-start/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocsigen/ocsigen-start/contents/{+path}","compare_url":"https://api.github.com/repos/ocsigen/ocsigen-start/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocsigen/ocsigen-start/merges","archive_url":"https://api.github.com/repos/ocsigen/ocsigen-start/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocsigen/ocsigen-start/downloads","issues_url":"https://api.github.com/repos/ocsigen/ocsigen-start/issues{/number}","pulls_url":"https://api.github.com/repos/ocsigen/ocsigen-start/pulls{/number}","milestones_url":"https://api.github.com/repos/ocsigen/ocsigen-start/milestones{/number}","notifications_url":"https://api.github.com/repos/ocsigen/ocsigen-start/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocsigen/ocsigen-start/labels{/name}","releases_url":"https://api.github.com/repos/ocsigen/ocsigen-start/releases{/id}","deployments_url":"https://api.github.com/repos/ocsigen/ocsigen-start/deployments","created_at":"2013-07-03T13:24:21Z","updated_at":"2016-08-22T14:26:55Z","pushed_at":"2016-09-15T11:26:35Z","git_url":"git://github.com/ocsigen/ocsigen-start.git","ssh_url":"git@github.com:ocsigen/ocsigen-start.git","clone_url":"https://github.com/ocsigen/ocsigen-start.git","svn_url":"https://github.com/ocsigen/ocsigen-start","homepage":"","size":2374,"stargazers_count":19,"watchers_count":19,"language":"OCaml","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":32,"forks":12,"open_issues":32,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ocsigen/ocsigen-start/pulls/130"},"html":{"href":"https://github.com/ocsigen/ocsigen-start/pull/130"},"issue":{"href":"https://api.github.com/repos/ocsigen/ocsigen-start/issues/130"},"comments":{"href":"https://api.github.com/repos/ocsigen/ocsigen-start/issues/130/comments"},"review_comments":{"href":"https://api.github.com/repos/ocsigen/ocsigen-start/pulls/130/comments"},"review_comment":{"href":"https://api.github.com/repos/ocsigen/ocsigen-start/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ocsigen/ocsigen-start/pulls/130/commits"},"statuses":{"href":"https://api.github.com/repos/ocsigen/ocsigen-start/statuses/21c27ad6957fcacb5a2b1fb093dfdb0032a9198d"}}}}
{"actor":{"display_login":"vasilisp"}}