{"action":"created","comment":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/88493566","pull_request_review_id":9065966,"id":88493566,"diff_hunk":"@@ -1426,12 +1432,18 @@ def setup_volume_source_space(subject, fname=None, pos=5.0, mri=None,\n     \"\"\"\n     subjects_dir = get_subjects_dir(subjects_dir)\n \n+    if fname is not None or overwrite is not None:\n+        warn(\"Parameters 'fname' and 'overwrite' are deprecated and will be \"\n+             \"removed in version 0.15. The source spaces will not be saved. \"\n+             \"Use mne.write_source_spaces instead.\")\n     if bem is not None and surface is not None:\n         raise ValueError('Only one of \"bem\" and \"surface\" should be '\n                          'specified')\n     if mri is not None:\n         if not op.isfile(mri):\n-            raise IOError('mri file \"%s\" not found' % mri)\n+            mri = op.join(subjects_dir, subject, 'mri', mri)","path":"mne/source_space.py","position":78,"original_position":78,"commit_id":"7aba8fca8143066b1c3a844d3cb68f95a8000992","original_commit_id":"7aba8fca8143066b1c3a844d3cb68f95a8000992","user":{"login":"Eric89GXL","id":2365790,"avatar_url":"https://avatars.githubusercontent.com/u/2365790?v=3","gravatar_id":"","url":"https://api.github.com/users/Eric89GXL","html_url":"https://github.com/Eric89GXL","followers_url":"https://api.github.com/users/Eric89GXL/followers","following_url":"https://api.github.com/users/Eric89GXL/following{/other_user}","gists_url":"https://api.github.com/users/Eric89GXL/gists{/gist_id}","starred_url":"https://api.github.com/users/Eric89GXL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eric89GXL/subscriptions","organizations_url":"https://api.github.com/users/Eric89GXL/orgs","repos_url":"https://api.github.com/users/Eric89GXL/repos","events_url":"https://api.github.com/users/Eric89GXL/events{/privacy}","received_events_url":"https://api.github.com/users/Eric89GXL/received_events","type":"User","site_admin":false},"body":"for example, this will break when subject is None","created_at":"2016-11-17T16:44:00Z","updated_at":"2016-11-17T16:44:00Z","html_url":"https://github.com/mne-tools/mne-python/pull/3771#discussion_r88493566","pull_request_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3771","_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/88493566"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/3771#discussion_r88493566"},"pull_request":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3771"}}},"pull_request":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3771","id":93965990,"html_url":"https://github.com/mne-tools/mne-python/pull/3771","diff_url":"https://github.com/mne-tools/mne-python/pull/3771.diff","patch_url":"https://github.com/mne-tools/mne-python/pull/3771.patch","issue_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3771","number":3771,"state":"open","locked":false,"title":"MRG+1: Fixes to setup_volume_source_space.","user":{"login":"jaeilepp","id":3456414,"avatar_url":"https://avatars.githubusercontent.com/u/3456414?v=3","gravatar_id":"","url":"https://api.github.com/users/jaeilepp","html_url":"https://github.com/jaeilepp","followers_url":"https://api.github.com/users/jaeilepp/followers","following_url":"https://api.github.com/users/jaeilepp/following{/other_user}","gists_url":"https://api.github.com/users/jaeilepp/gists{/gist_id}","starred_url":"https://api.github.com/users/jaeilepp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaeilepp/subscriptions","organizations_url":"https://api.github.com/users/jaeilepp/orgs","repos_url":"https://api.github.com/users/jaeilepp/repos","events_url":"https://api.github.com/users/jaeilepp/events{/privacy}","received_events_url":"https://api.github.com/users/jaeilepp/received_events","type":"User","site_admin":false},"body":"Closes https://github.com/mne-tools/mne-python/issues/3708\r\nWould this be good enough?","created_at":"2016-11-16T13:31:56Z","updated_at":"2016-11-17T16:45:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c525afdfe37131a291ff189a0115e3cc830b247","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3771/commits","review_comments_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3771/comments","review_comment_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3771/comments","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/7aba8fca8143066b1c3a844d3cb68f95a8000992","head":{"label":"jaeilepp:fix-setup-volume","ref":"fix-setup-volume","sha":"7aba8fca8143066b1c3a844d3cb68f95a8000992","user":{"login":"jaeilepp","id":3456414,"avatar_url":"https://avatars.githubusercontent.com/u/3456414?v=3","gravatar_id":"","url":"https://api.github.com/users/jaeilepp","html_url":"https://github.com/jaeilepp","followers_url":"https://api.github.com/users/jaeilepp/followers","following_url":"https://api.github.com/users/jaeilepp/following{/other_user}","gists_url":"https://api.github.com/users/jaeilepp/gists{/gist_id}","starred_url":"https://api.github.com/users/jaeilepp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaeilepp/subscriptions","organizations_url":"https://api.github.com/users/jaeilepp/orgs","repos_url":"https://api.github.com/users/jaeilepp/repos","events_url":"https://api.github.com/users/jaeilepp/events{/privacy}","received_events_url":"https://api.github.com/users/jaeilepp/received_events","type":"User","site_admin":false},"repo":{"id":35097627,"name":"mne-python","full_name":"jaeilepp/mne-python","owner":{"login":"jaeilepp","id":3456414,"avatar_url":"https://avatars.githubusercontent.com/u/3456414?v=3","gravatar_id":"","url":"https://api.github.com/users/jaeilepp","html_url":"https://github.com/jaeilepp","followers_url":"https://api.github.com/users/jaeilepp/followers","following_url":"https://api.github.com/users/jaeilepp/following{/other_user}","gists_url":"https://api.github.com/users/jaeilepp/gists{/gist_id}","starred_url":"https://api.github.com/users/jaeilepp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaeilepp/subscriptions","organizations_url":"https://api.github.com/users/jaeilepp/orgs","repos_url":"https://api.github.com/users/jaeilepp/repos","events_url":"https://api.github.com/users/jaeilepp/events{/privacy}","received_events_url":"https://api.github.com/users/jaeilepp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jaeilepp/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":true,"url":"https://api.github.com/repos/jaeilepp/mne-python","forks_url":"https://api.github.com/repos/jaeilepp/mne-python/forks","keys_url":"https://api.github.com/repos/jaeilepp/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaeilepp/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaeilepp/mne-python/teams","hooks_url":"https://api.github.com/repos/jaeilepp/mne-python/hooks","issue_events_url":"https://api.github.com/repos/jaeilepp/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/jaeilepp/mne-python/events","assignees_url":"https://api.github.com/repos/jaeilepp/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/jaeilepp/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/jaeilepp/mne-python/tags","blobs_url":"https://api.github.com/repos/jaeilepp/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaeilepp/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaeilepp/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaeilepp/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaeilepp/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/jaeilepp/mne-python/languages","stargazers_url":"https://api.github.com/repos/jaeilepp/mne-python/stargazers","contributors_url":"https://api.github.com/repos/jaeilepp/mne-python/contributors","subscribers_url":"https://api.github.com/repos/jaeilepp/mne-python/subscribers","subscription_url":"https://api.github.com/repos/jaeilepp/mne-python/subscription","commits_url":"https://api.github.com/repos/jaeilepp/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaeilepp/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaeilepp/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaeilepp/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/jaeilepp/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/jaeilepp/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaeilepp/mne-python/merges","archive_url":"https://api.github.com/repos/jaeilepp/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaeilepp/mne-python/downloads","issues_url":"https://api.github.com/repos/jaeilepp/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/jaeilepp/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/jaeilepp/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/jaeilepp/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaeilepp/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/jaeilepp/mne-python/releases{/id}","deployments_url":"https://api.github.com/repos/jaeilepp/mne-python/deployments","created_at":"2015-05-05T12:24:30Z","updated_at":"2016-02-29T07:08:15Z","pushed_at":"2016-11-17T14:25:23Z","git_url":"git://github.com/jaeilepp/mne-python.git","ssh_url":"git@github.com:jaeilepp/mne-python.git","clone_url":"https://github.com/jaeilepp/mne-python.git","svn_url":"https://github.com/jaeilepp/mne-python","homepage":"http://martinos.org/mne/","size":90700,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mne-tools:master","ref":"master","sha":"7afb9034cc1e2ef6229d857f14216826d80c5a1f","user":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars.githubusercontent.com/u/583875?v=3","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"repo":{"id":1301584,"name":"mne-python","full_name":"mne-tools/mne-python","owner":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars.githubusercontent.com/u/583875?v=3","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mne-tools/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":false,"url":"https://api.github.com/repos/mne-tools/mne-python","forks_url":"https://api.github.com/repos/mne-tools/mne-python/forks","keys_url":"https://api.github.com/repos/mne-tools/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mne-tools/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mne-tools/mne-python/teams","hooks_url":"https://api.github.com/repos/mne-tools/mne-python/hooks","issue_events_url":"https://api.github.com/repos/mne-tools/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/mne-tools/mne-python/events","assignees_url":"https://api.github.com/repos/mne-tools/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/mne-tools/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/mne-tools/mne-python/tags","blobs_url":"https://api.github.com/repos/mne-tools/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mne-tools/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mne-tools/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/mne-tools/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/mne-tools/mne-python/languages","stargazers_url":"https://api.github.com/repos/mne-tools/mne-python/stargazers","contributors_url":"https://api.github.com/repos/mne-tools/mne-python/contributors","subscribers_url":"https://api.github.com/repos/mne-tools/mne-python/subscribers","subscription_url":"https://api.github.com/repos/mne-tools/mne-python/subscription","commits_url":"https://api.github.com/repos/mne-tools/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/mne-tools/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/mne-tools/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/mne-tools/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/mne-tools/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mne-tools/mne-python/merges","archive_url":"https://api.github.com/repos/mne-tools/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mne-tools/mne-python/downloads","issues_url":"https://api.github.com/repos/mne-tools/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/mne-tools/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/mne-tools/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/mne-tools/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mne-tools/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/mne-tools/mne-python/releases{/id}","deployments_url":"https://api.github.com/repos/mne-tools/mne-python/deployments","created_at":"2011-01-28T03:31:13Z","updated_at":"2016-11-16T09:09:07Z","pushed_at":"2016-11-17T16:02:08Z","git_url":"git://github.com/mne-tools/mne-python.git","ssh_url":"git@github.com:mne-tools/mne-python.git","clone_url":"https://github.com/mne-tools/mne-python.git","svn_url":"https://github.com/mne-tools/mne-python","homepage":"http://martinos.org/mne/","size":190093,"stargazers_count":240,"watchers_count":240,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":225,"mirror_url":null,"open_issues_count":233,"forks":225,"open_issues":233,"watchers":240,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3771"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/3771"},"issue":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/3771"},"comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/3771/comments"},"review_comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3771/comments"},"review_comment":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3771/commits"},"statuses":{"href":"https://api.github.com/repos/mne-tools/mne-python/statuses/7aba8fca8143066b1c3a844d3cb68f95a8000992"}}}}
{"actor":{"display_login":"Eric89GXL"}}