{"action":"created","comment":{"url":"https://api.github.com/repos/geerlingguy/drupal-vm/pulls/comments/65803598","id":65803598,"diff_hunk":"@@ -34,19 +35,31 @@ vagrant_cpus: 2\n # The web server software to use. Can be either 'apache' or 'nginx'.\n drupalvm_webserver: apache\n \n-# Set this to false if you are using a different site deployment strategy and\n+# Set this to 'false' if you are using a different site deployment strategy and\n # would like to configure 'vagrant_synced_folders' and 'apache_vhosts' manually.\n build_makefile: true\n drush_makefile_path: \"{{ config_dir }}/drupal.make.yml\"\n \n-# Set this to false if you don't need to install drupal (using the drupal_*\n+# Set 'build_makefile' to 'false' and this to 'true' if you are using a\n+# composer based site deployment strategy.\n+build_composer: false\n+drupal_composer_path: \"{{ config_dir }}/drupal.composer.json\"\n+drupal_composer_install_dir: \"/var/www/drupalvm/drupal\"\n+drupal_composer_dependencies: []\n+\n+# Set this to 'true' and 'build_makefile', 'build_composer' to 'false' if you\n+# are using Composer's create-project as a site deployment strategy.\n+build_composer_project: false\n+drupal_composer_project_package: \"\"\n+drupal_composer_project_options: \"--prefer-dist --stability dev --no-interaction\"\n+\n+# Set this to 'false' if you don't need to install drupal (using the drupal_*\n # settings below), but instead copy down a database (e.g. using drush sql-sync).\n install_site: true\n \n-# Settings for building a Drupal site from a makefile (if 'build_makefile:'\n-# is 'true').\n+# Settings for installing a Drupal site (if 'install_site:' is 'true').\n drupal_major_version: 8\n-drupal_core_path: \"/var/www/drupalvm/drupal\"\n+drupal_core_path: \"{{ drupal_composer_install_dir }}/docroot\"","path":"default.config.yml","position":43,"original_position":43,"commit_id":"27f70538f0eeee9529c4937265e2df6be8d2c892","original_commit_id":"27f70538f0eeee9529c4937265e2df6be8d2c892","user":{"login":"oxyc","id":302736,"avatar_url":"https://avatars.githubusercontent.com/u/302736?v=3","gravatar_id":"","url":"https://api.github.com/users/oxyc","html_url":"https://github.com/oxyc","followers_url":"https://api.github.com/users/oxyc/followers","following_url":"https://api.github.com/users/oxyc/following{/other_user}","gists_url":"https://api.github.com/users/oxyc/gists{/gist_id}","starred_url":"https://api.github.com/users/oxyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oxyc/subscriptions","organizations_url":"https://api.github.com/users/oxyc/orgs","repos_url":"https://api.github.com/users/oxyc/repos","events_url":"https://api.github.com/users/oxyc/events{/privacy}","received_events_url":"https://api.github.com/users/oxyc/received_events","type":"User","site_admin":false},"body":"I can also keep the old behaviour as makefiles are still the default. Just need to mention that this needs to be changed in the composer docs.","created_at":"2016-06-04T15:02:32Z","updated_at":"2016-06-04T15:02:32Z","html_url":"https://github.com/geerlingguy/drupal-vm/pull/694#discussion_r65803598","pull_request_url":"https://api.github.com/repos/geerlingguy/drupal-vm/pulls/694","_links":{"self":{"href":"https://api.github.com/repos/geerlingguy/drupal-vm/pulls/comments/65803598"},"html":{"href":"https://github.com/geerlingguy/drupal-vm/pull/694#discussion_r65803598"},"pull_request":{"href":"https://api.github.com/repos/geerlingguy/drupal-vm/pulls/694"}}},"pull_request":{"url":"https://api.github.com/repos/geerlingguy/drupal-vm/pulls/694","id":72543478,"html_url":"https://github.com/geerlingguy/drupal-vm/pull/694","diff_url":"https://github.com/geerlingguy/drupal-vm/pull/694.diff","patch_url":"https://github.com/geerlingguy/drupal-vm/pull/694.patch","issue_url":"https://api.github.com/repos/geerlingguy/drupal-vm/issues/694","number":694,"state":"open","locked":false,"title":"Issue #506: Add support for composer based site builds","user":{"login":"oxyc","id":302736,"avatar_url":"https://avatars.githubusercontent.com/u/302736?v=3","gravatar_id":"","url":"https://api.github.com/users/oxyc","html_url":"https://github.com/oxyc","followers_url":"https://api.github.com/users/oxyc/followers","following_url":"https://api.github.com/users/oxyc/following{/other_user}","gists_url":"https://api.github.com/users/oxyc/gists{/gist_id}","starred_url":"https://api.github.com/users/oxyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oxyc/subscriptions","organizations_url":"https://api.github.com/users/oxyc/orgs","repos_url":"https://api.github.com/users/oxyc/repos","events_url":"https://api.github.com/users/oxyc/events{/privacy}","received_events_url":"https://api.github.com/users/oxyc/received_events","type":"User","site_admin":false},"body":"Issue #506. This is still WIP, just checking travis' opinion.","created_at":"2016-06-03T17:43:22Z","updated_at":"2016-06-04T15:02:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ff770e973f9a998ae26eddcc6f32b2f6e1be064","assignee":null,"milestone":{"url":"https://api.github.com/repos/geerlingguy/drupal-vm/milestones/4","html_url":"https://github.com/geerlingguy/drupal-vm/milestones/3.1.0","labels_url":"https://api.github.com/repos/geerlingguy/drupal-vm/milestones/4/labels","id":1766614,"number":4,"title":"3.1.0","description":"","creator":{"login":"geerlingguy","id":481677,"avatar_url":"https://avatars.githubusercontent.com/u/481677?v=3","gravatar_id":"","url":"https://api.github.com/users/geerlingguy","html_url":"https://github.com/geerlingguy","followers_url":"https://api.github.com/users/geerlingguy/followers","following_url":"https://api.github.com/users/geerlingguy/following{/other_user}","gists_url":"https://api.github.com/users/geerlingguy/gists{/gist_id}","starred_url":"https://api.github.com/users/geerlingguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geerlingguy/subscriptions","organizations_url":"https://api.github.com/users/geerlingguy/orgs","repos_url":"https://api.github.com/users/geerlingguy/repos","events_url":"https://api.github.com/users/geerlingguy/events{/privacy}","received_events_url":"https://api.github.com/users/geerlingguy/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":5,"state":"open","created_at":"2016-05-15T02:45:28Z","updated_at":"2016-06-03T17:44:27Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/geerlingguy/drupal-vm/pulls/694/commits","review_comments_url":"https://api.github.com/repos/geerlingguy/drupal-vm/pulls/694/comments","review_comment_url":"https://api.github.com/repos/geerlingguy/drupal-vm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/geerlingguy/drupal-vm/issues/694/comments","statuses_url":"https://api.github.com/repos/geerlingguy/drupal-vm/statuses/27f70538f0eeee9529c4937265e2df6be8d2c892","head":{"label":"oxyc:drupal-project","ref":"drupal-project","sha":"27f70538f0eeee9529c4937265e2df6be8d2c892","user":{"login":"oxyc","id":302736,"avatar_url":"https://avatars.githubusercontent.com/u/302736?v=3","gravatar_id":"","url":"https://api.github.com/users/oxyc","html_url":"https://github.com/oxyc","followers_url":"https://api.github.com/users/oxyc/followers","following_url":"https://api.github.com/users/oxyc/following{/other_user}","gists_url":"https://api.github.com/users/oxyc/gists{/gist_id}","starred_url":"https://api.github.com/users/oxyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oxyc/subscriptions","organizations_url":"https://api.github.com/users/oxyc/orgs","repos_url":"https://api.github.com/users/oxyc/repos","events_url":"https://api.github.com/users/oxyc/events{/privacy}","received_events_url":"https://api.github.com/users/oxyc/received_events","type":"User","site_admin":false},"repo":{"id":38467501,"name":"drupal-vm","full_name":"oxyc/drupal-vm","owner":{"login":"oxyc","id":302736,"avatar_url":"https://avatars.githubusercontent.com/u/302736?v=3","gravatar_id":"","url":"https://api.github.com/users/oxyc","html_url":"https://github.com/oxyc","followers_url":"https://api.github.com/users/oxyc/followers","following_url":"https://api.github.com/users/oxyc/following{/other_user}","gists_url":"https://api.github.com/users/oxyc/gists{/gist_id}","starred_url":"https://api.github.com/users/oxyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oxyc/subscriptions","organizations_url":"https://api.github.com/users/oxyc/orgs","repos_url":"https://api.github.com/users/oxyc/repos","events_url":"https://api.github.com/users/oxyc/events{/privacy}","received_events_url":"https://api.github.com/users/oxyc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oxyc/drupal-vm","description":"Drupal Development VM using Vagrant + Ansible","fork":true,"url":"https://api.github.com/repos/oxyc/drupal-vm","forks_url":"https://api.github.com/repos/oxyc/drupal-vm/forks","keys_url":"https://api.github.com/repos/oxyc/drupal-vm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oxyc/drupal-vm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oxyc/drupal-vm/teams","hooks_url":"https://api.github.com/repos/oxyc/drupal-vm/hooks","issue_events_url":"https://api.github.com/repos/oxyc/drupal-vm/issues/events{/number}","events_url":"https://api.github.com/repos/oxyc/drupal-vm/events","assignees_url":"https://api.github.com/repos/oxyc/drupal-vm/assignees{/user}","branches_url":"https://api.github.com/repos/oxyc/drupal-vm/branches{/branch}","tags_url":"https://api.github.com/repos/oxyc/drupal-vm/tags","blobs_url":"https://api.github.com/repos/oxyc/drupal-vm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oxyc/drupal-vm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oxyc/drupal-vm/git/refs{/sha}","trees_url":"https://api.github.com/repos/oxyc/drupal-vm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oxyc/drupal-vm/statuses/{sha}","languages_url":"https://api.github.com/repos/oxyc/drupal-vm/languages","stargazers_url":"https://api.github.com/repos/oxyc/drupal-vm/stargazers","contributors_url":"https://api.github.com/repos/oxyc/drupal-vm/contributors","subscribers_url":"https://api.github.com/repos/oxyc/drupal-vm/subscribers","subscription_url":"https://api.github.com/repos/oxyc/drupal-vm/subscription","commits_url":"https://api.github.com/repos/oxyc/drupal-vm/commits{/sha}","git_commits_url":"https://api.github.com/repos/oxyc/drupal-vm/git/commits{/sha}","comments_url":"https://api.github.com/repos/oxyc/drupal-vm/comments{/number}","issue_comment_url":"https://api.github.com/repos/oxyc/drupal-vm/issues/comments{/number}","contents_url":"https://api.github.com/repos/oxyc/drupal-vm/contents/{+path}","compare_url":"https://api.github.com/repos/oxyc/drupal-vm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oxyc/drupal-vm/merges","archive_url":"https://api.github.com/repos/oxyc/drupal-vm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oxyc/drupal-vm/downloads","issues_url":"https://api.github.com/repos/oxyc/drupal-vm/issues{/number}","pulls_url":"https://api.github.com/repos/oxyc/drupal-vm/pulls{/number}","milestones_url":"https://api.github.com/repos/oxyc/drupal-vm/milestones{/number}","notifications_url":"https://api.github.com/repos/oxyc/drupal-vm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oxyc/drupal-vm/labels{/name}","releases_url":"https://api.github.com/repos/oxyc/drupal-vm/releases{/id}","deployments_url":"https://api.github.com/repos/oxyc/drupal-vm/deployments","created_at":"2015-07-03T02:27:12Z","updated_at":"2016-01-15T17:16:16Z","pushed_at":"2016-06-04T14:57:31Z","git_url":"git://github.com/oxyc/drupal-vm.git","ssh_url":"git@github.com:oxyc/drupal-vm.git","clone_url":"https://github.com/oxyc/drupal-vm.git","svn_url":"https://github.com/oxyc/drupal-vm","homepage":"http://www.drupalvm.com/","size":565,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"geerlingguy:master","ref":"master","sha":"f76446f350ae466dc57ece9ab1ca6040a0f2c109","user":{"login":"geerlingguy","id":481677,"avatar_url":"https://avatars.githubusercontent.com/u/481677?v=3","gravatar_id":"","url":"https://api.github.com/users/geerlingguy","html_url":"https://github.com/geerlingguy","followers_url":"https://api.github.com/users/geerlingguy/followers","following_url":"https://api.github.com/users/geerlingguy/following{/other_user}","gists_url":"https://api.github.com/users/geerlingguy/gists{/gist_id}","starred_url":"https://api.github.com/users/geerlingguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geerlingguy/subscriptions","organizations_url":"https://api.github.com/users/geerlingguy/orgs","repos_url":"https://api.github.com/users/geerlingguy/repos","events_url":"https://api.github.com/users/geerlingguy/events{/privacy}","received_events_url":"https://api.github.com/users/geerlingguy/received_events","type":"User","site_admin":false},"repo":{"id":16246536,"name":"drupal-vm","full_name":"geerlingguy/drupal-vm","owner":{"login":"geerlingguy","id":481677,"avatar_url":"https://avatars.githubusercontent.com/u/481677?v=3","gravatar_id":"","url":"https://api.github.com/users/geerlingguy","html_url":"https://github.com/geerlingguy","followers_url":"https://api.github.com/users/geerlingguy/followers","following_url":"https://api.github.com/users/geerlingguy/following{/other_user}","gists_url":"https://api.github.com/users/geerlingguy/gists{/gist_id}","starred_url":"https://api.github.com/users/geerlingguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geerlingguy/subscriptions","organizations_url":"https://api.github.com/users/geerlingguy/orgs","repos_url":"https://api.github.com/users/geerlingguy/repos","events_url":"https://api.github.com/users/geerlingguy/events{/privacy}","received_events_url":"https://api.github.com/users/geerlingguy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/geerlingguy/drupal-vm","description":"A VM for local Drupal development","fork":false,"url":"https://api.github.com/repos/geerlingguy/drupal-vm","forks_url":"https://api.github.com/repos/geerlingguy/drupal-vm/forks","keys_url":"https://api.github.com/repos/geerlingguy/drupal-vm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geerlingguy/drupal-vm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geerlingguy/drupal-vm/teams","hooks_url":"https://api.github.com/repos/geerlingguy/drupal-vm/hooks","issue_events_url":"https://api.github.com/repos/geerlingguy/drupal-vm/issues/events{/number}","events_url":"https://api.github.com/repos/geerlingguy/drupal-vm/events","assignees_url":"https://api.github.com/repos/geerlingguy/drupal-vm/assignees{/user}","branches_url":"https://api.github.com/repos/geerlingguy/drupal-vm/branches{/branch}","tags_url":"https://api.github.com/repos/geerlingguy/drupal-vm/tags","blobs_url":"https://api.github.com/repos/geerlingguy/drupal-vm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geerlingguy/drupal-vm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geerlingguy/drupal-vm/git/refs{/sha}","trees_url":"https://api.github.com/repos/geerlingguy/drupal-vm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geerlingguy/drupal-vm/statuses/{sha}","languages_url":"https://api.github.com/repos/geerlingguy/drupal-vm/languages","stargazers_url":"https://api.github.com/repos/geerlingguy/drupal-vm/stargazers","contributors_url":"https://api.github.com/repos/geerlingguy/drupal-vm/contributors","subscribers_url":"https://api.github.com/repos/geerlingguy/drupal-vm/subscribers","subscription_url":"https://api.github.com/repos/geerlingguy/drupal-vm/subscription","commits_url":"https://api.github.com/repos/geerlingguy/drupal-vm/commits{/sha}","git_commits_url":"https://api.github.com/repos/geerlingguy/drupal-vm/git/commits{/sha}","comments_url":"https://api.github.com/repos/geerlingguy/drupal-vm/comments{/number}","issue_comment_url":"https://api.github.com/repos/geerlingguy/drupal-vm/issues/comments{/number}","contents_url":"https://api.github.com/repos/geerlingguy/drupal-vm/contents/{+path}","compare_url":"https://api.github.com/repos/geerlingguy/drupal-vm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geerlingguy/drupal-vm/merges","archive_url":"https://api.github.com/repos/geerlingguy/drupal-vm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geerlingguy/drupal-vm/downloads","issues_url":"https://api.github.com/repos/geerlingguy/drupal-vm/issues{/number}","pulls_url":"https://api.github.com/repos/geerlingguy/drupal-vm/pulls{/number}","milestones_url":"https://api.github.com/repos/geerlingguy/drupal-vm/milestones{/number}","notifications_url":"https://api.github.com/repos/geerlingguy/drupal-vm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geerlingguy/drupal-vm/labels{/name}","releases_url":"https://api.github.com/repos/geerlingguy/drupal-vm/releases{/id}","deployments_url":"https://api.github.com/repos/geerlingguy/drupal-vm/deployments","created_at":"2014-01-26T04:26:54Z","updated_at":"2016-06-03T23:43:23Z","pushed_at":"2016-06-04T14:57:31Z","git_url":"git://github.com/geerlingguy/drupal-vm.git","ssh_url":"git@github.com:geerlingguy/drupal-vm.git","clone_url":"https://github.com/geerlingguy/drupal-vm.git","svn_url":"https://github.com/geerlingguy/drupal-vm","homepage":"http://www.drupalvm.com/","size":833,"stargazers_count":641,"watchers_count":641,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":285,"mirror_url":null,"open_issues_count":27,"forks":285,"open_issues":27,"watchers":641,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/geerlingguy/drupal-vm/pulls/694"},"html":{"href":"https://github.com/geerlingguy/drupal-vm/pull/694"},"issue":{"href":"https://api.github.com/repos/geerlingguy/drupal-vm/issues/694"},"comments":{"href":"https://api.github.com/repos/geerlingguy/drupal-vm/issues/694/comments"},"review_comments":{"href":"https://api.github.com/repos/geerlingguy/drupal-vm/pulls/694/comments"},"review_comment":{"href":"https://api.github.com/repos/geerlingguy/drupal-vm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/geerlingguy/drupal-vm/pulls/694/commits"},"statuses":{"href":"https://api.github.com/repos/geerlingguy/drupal-vm/statuses/27f70538f0eeee9529c4937265e2df6be8d2c892"}}}}
{"actor":{"display_login":"oxyc"}}