{"push_id":1463672182,"size":12,"distinct_size":2,"ref":"refs/heads/master","head":"90bb3ea494b8f03fa44c3f1114f950898f7d9277","before":"3b5625de42114cd121282bdfc4879a28e85d64ec","commits":[{"sha":"17973679c2d85c2ee5bd2e093ce9d9428a9d00ac","author":{"name":"Martynas Narbutas","email":"bec14364fad26213ff41210f6f84d1aa7984bbf0@foodpanda.com"},"message":"[Security] AbstractVoter method supportsAttribute gives false positive if attribute is zero (0)","distinct":false,"url":"https://api.github.com/repos/symfony/security/commits/17973679c2d85c2ee5bd2e093ce9d9428a9d00ac"},{"sha":"e396644d91c69dd7844f83735832e896e6ed4bf3","author":{"name":"Fabien Potencier","email":"6094910757de3667a08340f5b21f6399d2ffcc52@gmail.com"},"message":"bug #20734 [Security] AbstractVoter->supportsAttribute gives false positive if attribute is zero (0) (martynas-foodpanda)\n\nThis PR was merged into the 2.7 branch.\n\nDiscussion\n----------\n\n[Security] AbstractVoter->supportsAttribute gives false positive if attribute is zero (0)\n\n| Q             | A\n| ------------- | ---\n| Branch?       |  2.7\n| Bug fix?      | yes\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets |\n| License       | MIT\n| Doc PR        |\n\nIssue is easy to reproduce with test giving negative data set.\n0 should not pass as supported attribute for any set of attributes but it does as in_array in the method does not use flag 'strict' set to true.\n\nAs this is abstract voter and is used by users with their code flag 'strict' should be set to true.\nSince is there in 2.7 and 2.8 (LTS) IMHO it should be fixed.\n\nCommits\n-------\n\n8306530 [Security] AbstractVoter method supportsAttribute gives false positive if attribute is zero (0)","distinct":false,"url":"https://api.github.com/repos/symfony/security/commits/e396644d91c69dd7844f83735832e896e6ed4bf3"},{"sha":"d97a78775c5df380551d5ba188216dd38d6628ab","author":{"name":"Fabien Potencier","email":"6094910757de3667a08340f5b21f6399d2ffcc52@gmail.com"},"message":"Merge branch '2.7' into 2.8\n\n* 2.7:\n  [Validator] add Indonesian translation\n  fixed CS\n  [config] Fix issue when key removed and left value only\n  [Security] AbstractVoter method supportsAttribute gives false positive if attribute is zero (0)","distinct":false,"url":"https://api.github.com/repos/symfony/security/commits/d97a78775c5df380551d5ba188216dd38d6628ab"},{"sha":"8a7bf02f6038110dbf43a6c7dbf247acccac9817","author":{"name":"Nicolas Grekas","email":"ec5ccb19bcd9237073a700927cff7f3ddf333fd9@gmail.com"},"message":"[Security] Fix test","distinct":false,"url":"https://api.github.com/repos/symfony/security/commits/8a7bf02f6038110dbf43a6c7dbf247acccac9817"},{"sha":"0582ad240b9aa4b86945b3fdee0f84b20eb0856f","author":{"name":"Fabien Potencier","email":"6094910757de3667a08340f5b21f6399d2ffcc52@gmail.com"},"message":"fixed obsolete getMock() usage","distinct":false,"url":"https://api.github.com/repos/symfony/security/commits/0582ad240b9aa4b86945b3fdee0f84b20eb0856f"},{"sha":"b61218eac019add58b6eaf5bd0bdf331fb375ffb","author":{"name":"Fabien Potencier","email":"6094910757de3667a08340f5b21f6399d2ffcc52@gmail.com"},"message":"Merge branch '2.7' into 2.8\n\n* 2.7:\n  fixed obsolete getMock() usage\n  [WebProfilerBundle] Display multiple HTTP headers in WDT","distinct":false,"url":"https://api.github.com/repos/symfony/security/commits/b61218eac019add58b6eaf5bd0bdf331fb375ffb"},{"sha":"674b38ff1ae98e993fd18e599120ead43705c4bc","author":{"name":"Fabien Potencier","email":"6094910757de3667a08340f5b21f6399d2ffcc52@gmail.com"},"message":"fixed obsolete getMock() usage","distinct":false,"url":"https://api.github.com/repos/symfony/security/commits/674b38ff1ae98e993fd18e599120ead43705c4bc"},{"sha":"a57c25800dcd39387a9a831ef8f436a6bebb8e72","author":{"name":"Fabien Potencier","email":"6094910757de3667a08340f5b21f6399d2ffcc52@gmail.com"},"message":"Merge branch '2.8' into 3.1\n\n* 2.8:\n  fixed obsolete getMock() usage\n  fixed obsolete getMock() usage\n  [WebProfilerBundle] Display multiple HTTP headers in WDT\n  do not remove the Twig ExceptionController service\n  removed obsolete condition\n  do not try to register incomplete definitions","distinct":false,"url":"https://api.github.com/repos/symfony/security/commits/a57c25800dcd39387a9a831ef8f436a6bebb8e72"},{"sha":"b6686776ba39726bafa6435319ba0b3686e41498","author":{"name":"Fabien Potencier","email":"6094910757de3667a08340f5b21f6399d2ffcc52@gmail.com"},"message":"fixed obsolete getMock() usage","distinct":false,"url":"https://api.github.com/repos/symfony/security/commits/b6686776ba39726bafa6435319ba0b3686e41498"},{"sha":"7a9b11f3428243d368690b9485098e2d531703e7","author":{"name":"Fabien Potencier","email":"6094910757de3667a08340f5b21f6399d2ffcc52@gmail.com"},"message":"Merge branch '3.1' into 3.2\n\n* 3.1:\n  fixed obsolete getMock() usage\n  fixed obsolete getMock() usage\n  fixed obsolete getMock() usage\n  [WebProfilerBundle] Display multiple HTTP headers in WDT\n  do not remove the Twig ExceptionController service\n  removed obsolete condition\n  do not try to register incomplete definitions","distinct":false,"url":"https://api.github.com/repos/symfony/security/commits/7a9b11f3428243d368690b9485098e2d531703e7"},{"sha":"9ba5cbed388bbf235d6ba2e2211134ff5514960f","author":{"name":"Fabien Potencier","email":"6094910757de3667a08340f5b21f6399d2ffcc52@gmail.com"},"message":"Merge branch '3.2'\n\n* 3.2:\n  fixed obsolete getMock() usage\n  fixed obsolete getMock() usage\n  fixed obsolete getMock() usage\n  fixed obsolete getMock() usage\n  [WebProfilerBundle] Display multiple HTTP headers in WDT\n  do not remove the Twig ExceptionController service\n  removed obsolete condition\n  do not try to register incomplete definitions","distinct":true,"url":"https://api.github.com/repos/symfony/security/commits/9ba5cbed388bbf235d6ba2e2211134ff5514960f"},{"sha":"90bb3ea494b8f03fa44c3f1114f950898f7d9277","author":{"name":"Fabien Potencier","email":"6094910757de3667a08340f5b21f6399d2ffcc52@gmail.com"},"message":"fixed obsolete getMock() usage","distinct":true,"url":"https://api.github.com/repos/symfony/security/commits/90bb3ea494b8f03fa44c3f1114f950898f7d9277"}]}
{"actor":{"display_login":"sensiolabs-splitter"}}