{"action":"closed","number":10,"pull_request":{"url":"https://api.github.com/repos/containous/oxy/pulls/10","id":80845743,"html_url":"https://github.com/containous/oxy/pull/10","diff_url":"https://github.com/containous/oxy/pull/10.diff","patch_url":"https://github.com/containous/oxy/pull/10.patch","issue_url":"https://api.github.com/repos/containous/oxy/issues/10","number":10,"state":"closed","locked":false,"title":"Fix incorrect test to match the actual sticky session actions","user":{"login":"owen","id":784413,"avatar_url":"https://avatars.githubusercontent.com/u/784413?v=3","gravatar_id":"","url":"https://api.github.com/users/owen","html_url":"https://github.com/owen","followers_url":"https://api.github.com/users/owen/followers","following_url":"https://api.github.com/users/owen/following{/other_user}","gists_url":"https://api.github.com/users/owen/gists{/gist_id}","starred_url":"https://api.github.com/users/owen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owen/subscriptions","organizations_url":"https://api.github.com/users/owen/orgs","repos_url":"https://api.github.com/users/owen/repos","events_url":"https://api.github.com/users/owen/events{/privacy}","received_events_url":"https://api.github.com/users/owen/received_events","type":"User","site_admin":false},"body":"Hi @emilevauge!\r\n\r\nThis caught your comment in #4.\r\n\r\nIt looks like the TestBadCookieVal test case wasn't testing what I thought it did!\r\n\r\nThe test case sets up a RR with a sticky cookie, and then attempts to test it with a bad cookie value.  It expects to see an HTTP 500 with a bad cookie; however, during development, I changed the sticky session to be more robust - it will always attempt to rotate to the next available server if one isn't able to be reached.\r\n\r\nSo my test case was expecting a failure but I had two valid working servers, oops!\r\n\r\nI've fixed the test case to test two possible cases now:\r\n\r\n* A bad cookie was sent when a server is active to receive connections\r\n* A bad cookie was sent when no servers are available to respond\r\n\r\nThe overall code is OK, this is a test only fix.\r\n\r\nThanks for that catch!","created_at":"2016-08-10T18:42:48Z","updated_at":"2016-08-11T15:55:44Z","closed_at":"2016-08-11T15:55:44Z","merged_at":"2016-08-11T15:55:44Z","merge_commit_sha":"fcc76b52eb8568540a020b7a99e854d9d752b364","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/containous/oxy/pulls/10/commits","review_comments_url":"https://api.github.com/repos/containous/oxy/pulls/10/comments","review_comment_url":"https://api.github.com/repos/containous/oxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/containous/oxy/issues/10/comments","statuses_url":"https://api.github.com/repos/containous/oxy/statuses/756c0f9ad6f60c1fb1f22fd86c52eaef3f3086dd","head":{"label":"owen:master","ref":"master","sha":"756c0f9ad6f60c1fb1f22fd86c52eaef3f3086dd","user":{"login":"owen","id":784413,"avatar_url":"https://avatars.githubusercontent.com/u/784413?v=3","gravatar_id":"","url":"https://api.github.com/users/owen","html_url":"https://github.com/owen","followers_url":"https://api.github.com/users/owen/followers","following_url":"https://api.github.com/users/owen/following{/other_user}","gists_url":"https://api.github.com/users/owen/gists{/gist_id}","starred_url":"https://api.github.com/users/owen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owen/subscriptions","organizations_url":"https://api.github.com/users/owen/orgs","repos_url":"https://api.github.com/users/owen/repos","events_url":"https://api.github.com/users/owen/events{/privacy}","received_events_url":"https://api.github.com/users/owen/received_events","type":"User","site_admin":false},"repo":{"id":55196156,"name":"oxy","full_name":"owen/oxy","owner":{"login":"owen","id":784413,"avatar_url":"https://avatars.githubusercontent.com/u/784413?v=3","gravatar_id":"","url":"https://api.github.com/users/owen","html_url":"https://github.com/owen","followers_url":"https://api.github.com/users/owen/followers","following_url":"https://api.github.com/users/owen/following{/other_user}","gists_url":"https://api.github.com/users/owen/gists{/gist_id}","starred_url":"https://api.github.com/users/owen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owen/subscriptions","organizations_url":"https://api.github.com/users/owen/orgs","repos_url":"https://api.github.com/users/owen/repos","events_url":"https://api.github.com/users/owen/events{/privacy}","received_events_url":"https://api.github.com/users/owen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/owen/oxy","description":"Go middlewares for HTTP servers & proxies","fork":true,"url":"https://api.github.com/repos/owen/oxy","forks_url":"https://api.github.com/repos/owen/oxy/forks","keys_url":"https://api.github.com/repos/owen/oxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owen/oxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owen/oxy/teams","hooks_url":"https://api.github.com/repos/owen/oxy/hooks","issue_events_url":"https://api.github.com/repos/owen/oxy/issues/events{/number}","events_url":"https://api.github.com/repos/owen/oxy/events","assignees_url":"https://api.github.com/repos/owen/oxy/assignees{/user}","branches_url":"https://api.github.com/repos/owen/oxy/branches{/branch}","tags_url":"https://api.github.com/repos/owen/oxy/tags","blobs_url":"https://api.github.com/repos/owen/oxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owen/oxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owen/oxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/owen/oxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owen/oxy/statuses/{sha}","languages_url":"https://api.github.com/repos/owen/oxy/languages","stargazers_url":"https://api.github.com/repos/owen/oxy/stargazers","contributors_url":"https://api.github.com/repos/owen/oxy/contributors","subscribers_url":"https://api.github.com/repos/owen/oxy/subscribers","subscription_url":"https://api.github.com/repos/owen/oxy/subscription","commits_url":"https://api.github.com/repos/owen/oxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/owen/oxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/owen/oxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/owen/oxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/owen/oxy/contents/{+path}","compare_url":"https://api.github.com/repos/owen/oxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owen/oxy/merges","archive_url":"https://api.github.com/repos/owen/oxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owen/oxy/downloads","issues_url":"https://api.github.com/repos/owen/oxy/issues{/number}","pulls_url":"https://api.github.com/repos/owen/oxy/pulls{/number}","milestones_url":"https://api.github.com/repos/owen/oxy/milestones{/number}","notifications_url":"https://api.github.com/repos/owen/oxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owen/oxy/labels{/name}","releases_url":"https://api.github.com/repos/owen/oxy/releases{/id}","deployments_url":"https://api.github.com/repos/owen/oxy/deployments","created_at":"2016-04-01T01:58:21Z","updated_at":"2016-04-01T01:58:22Z","pushed_at":"2016-08-10T18:40:00Z","git_url":"git://github.com/owen/oxy.git","ssh_url":"git@github.com:owen/oxy.git","clone_url":"https://github.com/owen/oxy.git","svn_url":"https://github.com/owen/oxy","homepage":"","size":195,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"containous:master","ref":"master","sha":"4298f24d572dc554eb984f2ffdf6bdd54d4bd613","user":{"login":"containous","id":16349663,"avatar_url":"https://avatars.githubusercontent.com/u/16349663?v=3","gravatar_id":"","url":"https://api.github.com/users/containous","html_url":"https://github.com/containous","followers_url":"https://api.github.com/users/containous/followers","following_url":"https://api.github.com/users/containous/following{/other_user}","gists_url":"https://api.github.com/users/containous/gists{/gist_id}","starred_url":"https://api.github.com/users/containous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/containous/subscriptions","organizations_url":"https://api.github.com/users/containous/orgs","repos_url":"https://api.github.com/users/containous/repos","events_url":"https://api.github.com/users/containous/events{/privacy}","received_events_url":"https://api.github.com/users/containous/received_events","type":"Organization","site_admin":false},"repo":{"id":53363324,"name":"oxy","full_name":"containous/oxy","owner":{"login":"containous","id":16349663,"avatar_url":"https://avatars.githubusercontent.com/u/16349663?v=3","gravatar_id":"","url":"https://api.github.com/users/containous","html_url":"https://github.com/containous","followers_url":"https://api.github.com/users/containous/followers","following_url":"https://api.github.com/users/containous/following{/other_user}","gists_url":"https://api.github.com/users/containous/gists{/gist_id}","starred_url":"https://api.github.com/users/containous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/containous/subscriptions","organizations_url":"https://api.github.com/users/containous/orgs","repos_url":"https://api.github.com/users/containous/repos","events_url":"https://api.github.com/users/containous/events{/privacy}","received_events_url":"https://api.github.com/users/containous/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/containous/oxy","description":"Go middlewares for HTTP servers & proxies","fork":true,"url":"https://api.github.com/repos/containous/oxy","forks_url":"https://api.github.com/repos/containous/oxy/forks","keys_url":"https://api.github.com/repos/containous/oxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/containous/oxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/containous/oxy/teams","hooks_url":"https://api.github.com/repos/containous/oxy/hooks","issue_events_url":"https://api.github.com/repos/containous/oxy/issues/events{/number}","events_url":"https://api.github.com/repos/containous/oxy/events","assignees_url":"https://api.github.com/repos/containous/oxy/assignees{/user}","branches_url":"https://api.github.com/repos/containous/oxy/branches{/branch}","tags_url":"https://api.github.com/repos/containous/oxy/tags","blobs_url":"https://api.github.com/repos/containous/oxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/containous/oxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/containous/oxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/containous/oxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/containous/oxy/statuses/{sha}","languages_url":"https://api.github.com/repos/containous/oxy/languages","stargazers_url":"https://api.github.com/repos/containous/oxy/stargazers","contributors_url":"https://api.github.com/repos/containous/oxy/contributors","subscribers_url":"https://api.github.com/repos/containous/oxy/subscribers","subscription_url":"https://api.github.com/repos/containous/oxy/subscription","commits_url":"https://api.github.com/repos/containous/oxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/containous/oxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/containous/oxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/containous/oxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/containous/oxy/contents/{+path}","compare_url":"https://api.github.com/repos/containous/oxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/containous/oxy/merges","archive_url":"https://api.github.com/repos/containous/oxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/containous/oxy/downloads","issues_url":"https://api.github.com/repos/containous/oxy/issues{/number}","pulls_url":"https://api.github.com/repos/containous/oxy/pulls{/number}","milestones_url":"https://api.github.com/repos/containous/oxy/milestones{/number}","notifications_url":"https://api.github.com/repos/containous/oxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/containous/oxy/labels{/name}","releases_url":"https://api.github.com/repos/containous/oxy/releases{/id}","deployments_url":"https://api.github.com/repos/containous/oxy/deployments","created_at":"2016-03-07T22:19:10Z","updated_at":"2016-07-01T17:38:09Z","pushed_at":"2016-08-11T15:55:44Z","git_url":"git://github.com/containous/oxy.git","ssh_url":"git@github.com:containous/oxy.git","clone_url":"https://github.com/containous/oxy.git","svn_url":"https://github.com/containous/oxy","homepage":"","size":234,"stargazers_count":4,"watchers_count":4,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":2,"forks":8,"open_issues":2,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/containous/oxy/pulls/10"},"html":{"href":"https://github.com/containous/oxy/pull/10"},"issue":{"href":"https://api.github.com/repos/containous/oxy/issues/10"},"comments":{"href":"https://api.github.com/repos/containous/oxy/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/containous/oxy/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/containous/oxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/containous/oxy/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/containous/oxy/statuses/756c0f9ad6f60c1fb1f22fd86c52eaef3f3086dd"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"emilevauge","id":6207234,"avatar_url":"https://avatars.githubusercontent.com/u/6207234?v=3","gravatar_id":"","url":"https://api.github.com/users/emilevauge","html_url":"https://github.com/emilevauge","followers_url":"https://api.github.com/users/emilevauge/followers","following_url":"https://api.github.com/users/emilevauge/following{/other_user}","gists_url":"https://api.github.com/users/emilevauge/gists{/gist_id}","starred_url":"https://api.github.com/users/emilevauge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilevauge/subscriptions","organizations_url":"https://api.github.com/users/emilevauge/orgs","repos_url":"https://api.github.com/users/emilevauge/repos","events_url":"https://api.github.com/users/emilevauge/events{/privacy}","received_events_url":"https://api.github.com/users/emilevauge/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":18,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"emilevauge"}}