{"action":"created","issue":{"url":"https://api.github.com/repos/seattlerb/image_science/issues/24","repository_url":"https://api.github.com/repos/seattlerb/image_science","labels_url":"https://api.github.com/repos/seattlerb/image_science/issues/24/labels{/name}","comments_url":"https://api.github.com/repos/seattlerb/image_science/issues/24/comments","events_url":"https://api.github.com/repos/seattlerb/image_science/issues/24/events","html_url":"https://github.com/seattlerb/image_science/pull/24","id":139434191,"number":24,"title":"Change error-raising behaviour.","user":{"login":"omp","id":117980,"avatar_url":"https://avatars.githubusercontent.com/u/117980?v=3","gravatar_id":"","url":"https://api.github.com/users/omp","html_url":"https://github.com/omp","followers_url":"https://api.github.com/users/omp/followers","following_url":"https://api.github.com/users/omp/following{/other_user}","gists_url":"https://api.github.com/users/omp/gists{/gist_id}","starred_url":"https://api.github.com/users/omp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omp/subscriptions","organizations_url":"https://api.github.com/users/omp/orgs","repos_url":"https://api.github.com/users/omp/repos","events_url":"https://api.github.com/users/omp/events{/privacy}","received_events_url":"https://api.github.com/users/omp/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"zenspider","id":9832,"avatar_url":"https://avatars.githubusercontent.com/u/9832?v=3","gravatar_id":"","url":"https://api.github.com/users/zenspider","html_url":"https://github.com/zenspider","followers_url":"https://api.github.com/users/zenspider/followers","following_url":"https://api.github.com/users/zenspider/following{/other_user}","gists_url":"https://api.github.com/users/zenspider/gists{/gist_id}","starred_url":"https://api.github.com/users/zenspider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenspider/subscriptions","organizations_url":"https://api.github.com/users/zenspider/orgs","repos_url":"https://api.github.com/users/zenspider/repos","events_url":"https://api.github.com/users/zenspider/events{/privacy}","received_events_url":"https://api.github.com/users/zenspider/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2016-03-09T00:21:12Z","updated_at":"2016-03-16T03:32:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/seattlerb/image_science/pulls/24","html_url":"https://github.com/seattlerb/image_science/pull/24","diff_url":"https://github.com/seattlerb/image_science/pull/24.diff","patch_url":"https://github.com/seattlerb/image_science/pull/24.patch"},"body":"The previous logic was to raise an error whenever FreeImage calls the\r\nerror output handler, which is also called for warnings. This change\r\ninstead raises an error when a FreeImage function call returns a null\r\npointer."},"comment":{"url":"https://api.github.com/repos/seattlerb/image_science/issues/comments/197137106","html_url":"https://github.com/seattlerb/image_science/pull/24#issuecomment-197137106","issue_url":"https://api.github.com/repos/seattlerb/image_science/issues/24","id":197137106,"user":{"login":"omp","id":117980,"avatar_url":"https://avatars.githubusercontent.com/u/117980?v=3","gravatar_id":"","url":"https://api.github.com/users/omp","html_url":"https://github.com/omp","followers_url":"https://api.github.com/users/omp/followers","following_url":"https://api.github.com/users/omp/following{/other_user}","gists_url":"https://api.github.com/users/omp/gists{/gist_id}","starred_url":"https://api.github.com/users/omp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omp/subscriptions","organizations_url":"https://api.github.com/users/omp/orgs","repos_url":"https://api.github.com/users/omp/repos","events_url":"https://api.github.com/users/omp/events{/privacy}","received_events_url":"https://api.github.com/users/omp/received_events","type":"User","site_admin":false},"created_at":"2016-03-16T03:32:04Z","updated_at":"2016-03-16T03:32:04Z","body":"This is essentially a fix for issue #21 on here, which references the following freeimage issue:\r\nhttps://sourceforge.net/p/freeimage/support-requests/31/\r\n\r\n> This being said, you can load an image that looks suspicious to FreeImage (you will then get an error message or a warning message that can be catched using FreeImage_SetOutputMessage), but still have a correct dib on output (i.e. a dib that is not NULL). \r\n> As long as the returned dib is not NULL, then you can trust FreeImage. The fact that you get warning/error messages is not a problem as long as the returned dib is not NULL.\r\n\r\nThe fix I implemented is to still store the warning/error output in the thread, but only raise it as an error if a null pointer is returned from one of the freeimage function calls, clearing it otherwise."}}