{"action":"created","comment":{"url":"https://api.github.com/repos/baldurk/renderdoc/pulls/comments/74761265","id":74761265,"diff_hunk":"@@ -28,6 +28,7 @@\n #include <string.h>\n #include <unistd.h>\n #include <string>\n+#include \"../os/android/android_specific.h\"","path":"renderdoccmd/renderdoccmd_android.cpp","position":4,"original_position":4,"commit_id":"f63f801a1df9f1cffa5171312423a026ccfd8246","original_commit_id":"81967f13dce89ff6e534a0fd7a42e1191879cc3b","user":{"login":"baldurk","id":661798,"avatar_url":"https://avatars.githubusercontent.com/u/661798?v=3","gravatar_id":"","url":"https://api.github.com/users/baldurk","html_url":"https://github.com/baldurk","followers_url":"https://api.github.com/users/baldurk/followers","following_url":"https://api.github.com/users/baldurk/following{/other_user}","gists_url":"https://api.github.com/users/baldurk/gists{/gist_id}","starred_url":"https://api.github.com/users/baldurk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baldurk/subscriptions","organizations_url":"https://api.github.com/users/baldurk/orgs","repos_url":"https://api.github.com/users/baldurk/repos","events_url":"https://api.github.com/users/baldurk/events{/privacy}","received_events_url":"https://api.github.com/users/baldurk/received_events","type":"User","site_admin":false},"body":"`renderdoccmd` can only access the core library through the existing replay public interface, not through directly including files like this. Likewise this is something very specific that I don't want to tunnel through and expose up to a cross-platform external interface - I'm not sure why the implementation can't just be in this file though, since it's android specific and fairly small. See below comment though.","created_at":"2016-08-15T13:31:32Z","updated_at":"2016-08-15T13:31:32Z","html_url":"https://github.com/baldurk/renderdoc/pull/327#discussion_r74761265","pull_request_url":"https://api.github.com/repos/baldurk/renderdoc/pulls/327","_links":{"self":{"href":"https://api.github.com/repos/baldurk/renderdoc/pulls/comments/74761265"},"html":{"href":"https://github.com/baldurk/renderdoc/pull/327#discussion_r74761265"},"pull_request":{"href":"https://api.github.com/repos/baldurk/renderdoc/pulls/327"}}},"pull_request":{"url":"https://api.github.com/repos/baldurk/renderdoc/pulls/327","id":81296517,"html_url":"https://github.com/baldurk/renderdoc/pull/327","diff_url":"https://github.com/baldurk/renderdoc/pull/327.diff","patch_url":"https://github.com/baldurk/renderdoc/pull/327.patch","issue_url":"https://api.github.com/repos/baldurk/renderdoc/issues/327","number":327,"state":"open","locked":false,"title":"Fix Android replay check so we can record from APKs.","user":{"login":"michaelrgb","id":20949168,"avatar_url":"https://avatars.githubusercontent.com/u/20949168?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelrgb","html_url":"https://github.com/michaelrgb","followers_url":"https://api.github.com/users/michaelrgb/followers","following_url":"https://api.github.com/users/michaelrgb/following{/other_user}","gists_url":"https://api.github.com/users/michaelrgb/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelrgb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelrgb/subscriptions","organizations_url":"https://api.github.com/users/michaelrgb/orgs","repos_url":"https://api.github.com/users/michaelrgb/repos","events_url":"https://api.github.com/users/michaelrgb/events{/privacy}","received_events_url":"https://api.github.com/users/michaelrgb/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-15T10:46:16Z","updated_at":"2016-08-15T13:31:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16df0c328648b64ea251b36524c470134a0d592c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/baldurk/renderdoc/pulls/327/commits","review_comments_url":"https://api.github.com/repos/baldurk/renderdoc/pulls/327/comments","review_comment_url":"https://api.github.com/repos/baldurk/renderdoc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/baldurk/renderdoc/issues/327/comments","statuses_url":"https://api.github.com/repos/baldurk/renderdoc/statuses/f63f801a1df9f1cffa5171312423a026ccfd8246","head":{"label":"michaelrgb:master","ref":"master","sha":"f63f801a1df9f1cffa5171312423a026ccfd8246","user":{"login":"michaelrgb","id":20949168,"avatar_url":"https://avatars.githubusercontent.com/u/20949168?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelrgb","html_url":"https://github.com/michaelrgb","followers_url":"https://api.github.com/users/michaelrgb/followers","following_url":"https://api.github.com/users/michaelrgb/following{/other_user}","gists_url":"https://api.github.com/users/michaelrgb/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelrgb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelrgb/subscriptions","organizations_url":"https://api.github.com/users/michaelrgb/orgs","repos_url":"https://api.github.com/users/michaelrgb/repos","events_url":"https://api.github.com/users/michaelrgb/events{/privacy}","received_events_url":"https://api.github.com/users/michaelrgb/received_events","type":"User","site_admin":false},"repo":{"id":65391397,"name":"renderdoc","full_name":"michaelrgb/renderdoc","owner":{"login":"michaelrgb","id":20949168,"avatar_url":"https://avatars.githubusercontent.com/u/20949168?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelrgb","html_url":"https://github.com/michaelrgb","followers_url":"https://api.github.com/users/michaelrgb/followers","following_url":"https://api.github.com/users/michaelrgb/following{/other_user}","gists_url":"https://api.github.com/users/michaelrgb/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelrgb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelrgb/subscriptions","organizations_url":"https://api.github.com/users/michaelrgb/orgs","repos_url":"https://api.github.com/users/michaelrgb/repos","events_url":"https://api.github.com/users/michaelrgb/events{/privacy}","received_events_url":"https://api.github.com/users/michaelrgb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/michaelrgb/renderdoc","description":"RenderDoc is a stand-alone graphics debugging tool.","fork":true,"url":"https://api.github.com/repos/michaelrgb/renderdoc","forks_url":"https://api.github.com/repos/michaelrgb/renderdoc/forks","keys_url":"https://api.github.com/repos/michaelrgb/renderdoc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/michaelrgb/renderdoc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/michaelrgb/renderdoc/teams","hooks_url":"https://api.github.com/repos/michaelrgb/renderdoc/hooks","issue_events_url":"https://api.github.com/repos/michaelrgb/renderdoc/issues/events{/number}","events_url":"https://api.github.com/repos/michaelrgb/renderdoc/events","assignees_url":"https://api.github.com/repos/michaelrgb/renderdoc/assignees{/user}","branches_url":"https://api.github.com/repos/michaelrgb/renderdoc/branches{/branch}","tags_url":"https://api.github.com/repos/michaelrgb/renderdoc/tags","blobs_url":"https://api.github.com/repos/michaelrgb/renderdoc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/michaelrgb/renderdoc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/michaelrgb/renderdoc/git/refs{/sha}","trees_url":"https://api.github.com/repos/michaelrgb/renderdoc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/michaelrgb/renderdoc/statuses/{sha}","languages_url":"https://api.github.com/repos/michaelrgb/renderdoc/languages","stargazers_url":"https://api.github.com/repos/michaelrgb/renderdoc/stargazers","contributors_url":"https://api.github.com/repos/michaelrgb/renderdoc/contributors","subscribers_url":"https://api.github.com/repos/michaelrgb/renderdoc/subscribers","subscription_url":"https://api.github.com/repos/michaelrgb/renderdoc/subscription","commits_url":"https://api.github.com/repos/michaelrgb/renderdoc/commits{/sha}","git_commits_url":"https://api.github.com/repos/michaelrgb/renderdoc/git/commits{/sha}","comments_url":"https://api.github.com/repos/michaelrgb/renderdoc/comments{/number}","issue_comment_url":"https://api.github.com/repos/michaelrgb/renderdoc/issues/comments{/number}","contents_url":"https://api.github.com/repos/michaelrgb/renderdoc/contents/{+path}","compare_url":"https://api.github.com/repos/michaelrgb/renderdoc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/michaelrgb/renderdoc/merges","archive_url":"https://api.github.com/repos/michaelrgb/renderdoc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/michaelrgb/renderdoc/downloads","issues_url":"https://api.github.com/repos/michaelrgb/renderdoc/issues{/number}","pulls_url":"https://api.github.com/repos/michaelrgb/renderdoc/pulls{/number}","milestones_url":"https://api.github.com/repos/michaelrgb/renderdoc/milestones{/number}","notifications_url":"https://api.github.com/repos/michaelrgb/renderdoc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/michaelrgb/renderdoc/labels{/name}","releases_url":"https://api.github.com/repos/michaelrgb/renderdoc/releases{/id}","deployments_url":"https://api.github.com/repos/michaelrgb/renderdoc/deployments","created_at":"2016-08-10T14:55:35Z","updated_at":"2016-08-10T14:56:19Z","pushed_at":"2016-08-12T16:51:56Z","git_url":"git://github.com/michaelrgb/renderdoc.git","ssh_url":"git@github.com:michaelrgb/renderdoc.git","clone_url":"https://github.com/michaelrgb/renderdoc.git","svn_url":"https://github.com/michaelrgb/renderdoc","homepage":"https://renderdoc.org/builds","size":27955,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"baldurk:master","ref":"master","sha":"d531ffdad4cca632a7b48bf9980882644e4b3bef","user":{"login":"baldurk","id":661798,"avatar_url":"https://avatars.githubusercontent.com/u/661798?v=3","gravatar_id":"","url":"https://api.github.com/users/baldurk","html_url":"https://github.com/baldurk","followers_url":"https://api.github.com/users/baldurk/followers","following_url":"https://api.github.com/users/baldurk/following{/other_user}","gists_url":"https://api.github.com/users/baldurk/gists{/gist_id}","starred_url":"https://api.github.com/users/baldurk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baldurk/subscriptions","organizations_url":"https://api.github.com/users/baldurk/orgs","repos_url":"https://api.github.com/users/baldurk/repos","events_url":"https://api.github.com/users/baldurk/events{/privacy}","received_events_url":"https://api.github.com/users/baldurk/received_events","type":"User","site_admin":false},"repo":{"id":17253131,"name":"renderdoc","full_name":"baldurk/renderdoc","owner":{"login":"baldurk","id":661798,"avatar_url":"https://avatars.githubusercontent.com/u/661798?v=3","gravatar_id":"","url":"https://api.github.com/users/baldurk","html_url":"https://github.com/baldurk","followers_url":"https://api.github.com/users/baldurk/followers","following_url":"https://api.github.com/users/baldurk/following{/other_user}","gists_url":"https://api.github.com/users/baldurk/gists{/gist_id}","starred_url":"https://api.github.com/users/baldurk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baldurk/subscriptions","organizations_url":"https://api.github.com/users/baldurk/orgs","repos_url":"https://api.github.com/users/baldurk/repos","events_url":"https://api.github.com/users/baldurk/events{/privacy}","received_events_url":"https://api.github.com/users/baldurk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/baldurk/renderdoc","description":"RenderDoc is a stand-alone graphics debugging tool.","fork":false,"url":"https://api.github.com/repos/baldurk/renderdoc","forks_url":"https://api.github.com/repos/baldurk/renderdoc/forks","keys_url":"https://api.github.com/repos/baldurk/renderdoc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/baldurk/renderdoc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/baldurk/renderdoc/teams","hooks_url":"https://api.github.com/repos/baldurk/renderdoc/hooks","issue_events_url":"https://api.github.com/repos/baldurk/renderdoc/issues/events{/number}","events_url":"https://api.github.com/repos/baldurk/renderdoc/events","assignees_url":"https://api.github.com/repos/baldurk/renderdoc/assignees{/user}","branches_url":"https://api.github.com/repos/baldurk/renderdoc/branches{/branch}","tags_url":"https://api.github.com/repos/baldurk/renderdoc/tags","blobs_url":"https://api.github.com/repos/baldurk/renderdoc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/baldurk/renderdoc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/baldurk/renderdoc/git/refs{/sha}","trees_url":"https://api.github.com/repos/baldurk/renderdoc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/baldurk/renderdoc/statuses/{sha}","languages_url":"https://api.github.com/repos/baldurk/renderdoc/languages","stargazers_url":"https://api.github.com/repos/baldurk/renderdoc/stargazers","contributors_url":"https://api.github.com/repos/baldurk/renderdoc/contributors","subscribers_url":"https://api.github.com/repos/baldurk/renderdoc/subscribers","subscription_url":"https://api.github.com/repos/baldurk/renderdoc/subscription","commits_url":"https://api.github.com/repos/baldurk/renderdoc/commits{/sha}","git_commits_url":"https://api.github.com/repos/baldurk/renderdoc/git/commits{/sha}","comments_url":"https://api.github.com/repos/baldurk/renderdoc/comments{/number}","issue_comment_url":"https://api.github.com/repos/baldurk/renderdoc/issues/comments{/number}","contents_url":"https://api.github.com/repos/baldurk/renderdoc/contents/{+path}","compare_url":"https://api.github.com/repos/baldurk/renderdoc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/baldurk/renderdoc/merges","archive_url":"https://api.github.com/repos/baldurk/renderdoc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/baldurk/renderdoc/downloads","issues_url":"https://api.github.com/repos/baldurk/renderdoc/issues{/number}","pulls_url":"https://api.github.com/repos/baldurk/renderdoc/pulls{/number}","milestones_url":"https://api.github.com/repos/baldurk/renderdoc/milestones{/number}","notifications_url":"https://api.github.com/repos/baldurk/renderdoc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/baldurk/renderdoc/labels{/name}","releases_url":"https://api.github.com/repos/baldurk/renderdoc/releases{/id}","deployments_url":"https://api.github.com/repos/baldurk/renderdoc/deployments","created_at":"2014-02-27T15:16:30Z","updated_at":"2016-08-15T13:24:50Z","pushed_at":"2016-08-15T10:46:16Z","git_url":"git://github.com/baldurk/renderdoc.git","ssh_url":"git@github.com:baldurk/renderdoc.git","clone_url":"https://github.com/baldurk/renderdoc.git","svn_url":"https://github.com/baldurk/renderdoc","homepage":"https://renderdoc.org/builds","size":30201,"stargazers_count":1147,"watchers_count":1147,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":182,"mirror_url":null,"open_issues_count":36,"forks":182,"open_issues":36,"watchers":1147,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/baldurk/renderdoc/pulls/327"},"html":{"href":"https://github.com/baldurk/renderdoc/pull/327"},"issue":{"href":"https://api.github.com/repos/baldurk/renderdoc/issues/327"},"comments":{"href":"https://api.github.com/repos/baldurk/renderdoc/issues/327/comments"},"review_comments":{"href":"https://api.github.com/repos/baldurk/renderdoc/pulls/327/comments"},"review_comment":{"href":"https://api.github.com/repos/baldurk/renderdoc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/baldurk/renderdoc/pulls/327/commits"},"statuses":{"href":"https://api.github.com/repos/baldurk/renderdoc/statuses/f63f801a1df9f1cffa5171312423a026ccfd8246"}}}}
{"actor":{"display_login":"baldurk"}}