{"action":"created","comment":{"url":"https://api.github.com/repos/Riverline/multipart-parser/pulls/comments/57028728","id":57028728,"diff_hunk":"@@ -46,7 +46,7 @@ public function __construct($content)\n     protected function parseContentString($content)\n     {\n         // Split headers and body\n-        $splits = preg_split('/(\\r?\\n){2}/', $content, 2);","path":"src/Riverline/MultiPartParser/Part.php","position":null,"original_position":4,"commit_id":"6b3765d0271375d58caf5fb70d136b6beb0b6ffb","original_commit_id":"ffb6fe5092435333f179868595069511d8c4e931","user":{"login":"rcambien","id":400464,"avatar_url":"https://avatars.githubusercontent.com/u/400464?v=3","gravatar_id":"","url":"https://api.github.com/users/rcambien","html_url":"https://github.com/rcambien","followers_url":"https://api.github.com/users/rcambien/followers","following_url":"https://api.github.com/users/rcambien/following{/other_user}","gists_url":"https://api.github.com/users/rcambien/gists{/gist_id}","starred_url":"https://api.github.com/users/rcambien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcambien/subscriptions","organizations_url":"https://api.github.com/users/rcambien/orgs","repos_url":"https://api.github.com/users/rcambien/repos","events_url":"https://api.github.com/users/rcambien/events{/privacy}","received_events_url":"https://api.github.com/users/rcambien/received_events","type":"User","site_admin":false},"body":"According to section 3.5 : Although the line terminator for the start-line and header fields is the sequence CRLF, a recipient MAY recognize a single LF as a line terminator and ignore any preceding CR.\r\n\r\nI used this lib to parse many multipart emails and unfortunaly I see a lot of problem with this.","created_at":"2016-03-22T17:18:21Z","updated_at":"2016-03-22T17:18:21Z","html_url":"https://github.com/Riverline/multipart-parser/pull/6#discussion_r57028728","pull_request_url":"https://api.github.com/repos/Riverline/multipart-parser/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/Riverline/multipart-parser/pulls/comments/57028728"},"html":{"href":"https://github.com/Riverline/multipart-parser/pull/6#discussion_r57028728"},"pull_request":{"href":"https://api.github.com/repos/Riverline/multipart-parser/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/Riverline/multipart-parser/pulls/6","id":63496028,"html_url":"https://github.com/Riverline/multipart-parser/pull/6","diff_url":"https://github.com/Riverline/multipart-parser/pull/6.diff","patch_url":"https://github.com/Riverline/multipart-parser/pull/6.patch","issue_url":"https://api.github.com/repos/Riverline/multipart-parser/issues/6","number":6,"state":"open","locked":false,"title":"Stream support","user":{"login":"nazar-pc","id":928965,"avatar_url":"https://avatars.githubusercontent.com/u/928965?v=3","gravatar_id":"","url":"https://api.github.com/users/nazar-pc","html_url":"https://github.com/nazar-pc","followers_url":"https://api.github.com/users/nazar-pc/followers","following_url":"https://api.github.com/users/nazar-pc/following{/other_user}","gists_url":"https://api.github.com/users/nazar-pc/gists{/gist_id}","starred_url":"https://api.github.com/users/nazar-pc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nazar-pc/subscriptions","organizations_url":"https://api.github.com/users/nazar-pc/orgs","repos_url":"https://api.github.com/users/nazar-pc/repos","events_url":"https://api.github.com/users/nazar-pc/events{/privacy}","received_events_url":"https://api.github.com/users/nazar-pc/received_events","type":"User","site_admin":false},"body":"Stream support implementation, fixes #1\r\n\r\nInstead of having constructor, `::fromString()` and `::fromStream()` factory methods added in order to provide distinction from calls and allow calling constructor just for creating empty object (constructor is deprecated, but still behaves as it was before, no tests were changed).\r\n\r\nCode is highly refactored in order to work with streams as primary thing and string processing under the hood also uses code for stream without any visible overhead. Also optimizations added like avoiding regular expressions usage.\r\n\r\nAfter these changes it is possible to handle request that are few GiB long without any issues.\r\n\r\nAlso tests are not added for streams, but I'd like to see my other PRs from today merged, then I'll rebase and add tests.\r\n\r\nFor review, please, take a look at commits, total diff is pretty difficult to understand","created_at":"2016-03-20T13:57:33Z","updated_at":"2016-03-22T17:18:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec4608f997e78679049cb038a6b1ff83129bf083","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Riverline/multipart-parser/pulls/6/commits","review_comments_url":"https://api.github.com/repos/Riverline/multipart-parser/pulls/6/comments","review_comment_url":"https://api.github.com/repos/Riverline/multipart-parser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Riverline/multipart-parser/issues/6/comments","statuses_url":"https://api.github.com/repos/Riverline/multipart-parser/statuses/6b3765d0271375d58caf5fb70d136b6beb0b6ffb","head":{"label":"nazar-pc:stream-support","ref":"stream-support","sha":"6b3765d0271375d58caf5fb70d136b6beb0b6ffb","user":{"login":"nazar-pc","id":928965,"avatar_url":"https://avatars.githubusercontent.com/u/928965?v=3","gravatar_id":"","url":"https://api.github.com/users/nazar-pc","html_url":"https://github.com/nazar-pc","followers_url":"https://api.github.com/users/nazar-pc/followers","following_url":"https://api.github.com/users/nazar-pc/following{/other_user}","gists_url":"https://api.github.com/users/nazar-pc/gists{/gist_id}","starred_url":"https://api.github.com/users/nazar-pc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nazar-pc/subscriptions","organizations_url":"https://api.github.com/users/nazar-pc/orgs","repos_url":"https://api.github.com/users/nazar-pc/repos","events_url":"https://api.github.com/users/nazar-pc/events{/privacy}","received_events_url":"https://api.github.com/users/nazar-pc/received_events","type":"User","site_admin":false},"repo":{"id":54297518,"name":"multipart-parser","full_name":"nazar-pc/multipart-parser","owner":{"login":"nazar-pc","id":928965,"avatar_url":"https://avatars.githubusercontent.com/u/928965?v=3","gravatar_id":"","url":"https://api.github.com/users/nazar-pc","html_url":"https://github.com/nazar-pc","followers_url":"https://api.github.com/users/nazar-pc/followers","following_url":"https://api.github.com/users/nazar-pc/following{/other_user}","gists_url":"https://api.github.com/users/nazar-pc/gists{/gist_id}","starred_url":"https://api.github.com/users/nazar-pc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nazar-pc/subscriptions","organizations_url":"https://api.github.com/users/nazar-pc/orgs","repos_url":"https://api.github.com/users/nazar-pc/repos","events_url":"https://api.github.com/users/nazar-pc/events{/privacy}","received_events_url":"https://api.github.com/users/nazar-pc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nazar-pc/multipart-parser","description":"A one class lib to parse multipart document ( multipart email, multipart form, etc ...) and manage each part encoding and charset to extract their content.","fork":true,"url":"https://api.github.com/repos/nazar-pc/multipart-parser","forks_url":"https://api.github.com/repos/nazar-pc/multipart-parser/forks","keys_url":"https://api.github.com/repos/nazar-pc/multipart-parser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nazar-pc/multipart-parser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nazar-pc/multipart-parser/teams","hooks_url":"https://api.github.com/repos/nazar-pc/multipart-parser/hooks","issue_events_url":"https://api.github.com/repos/nazar-pc/multipart-parser/issues/events{/number}","events_url":"https://api.github.com/repos/nazar-pc/multipart-parser/events","assignees_url":"https://api.github.com/repos/nazar-pc/multipart-parser/assignees{/user}","branches_url":"https://api.github.com/repos/nazar-pc/multipart-parser/branches{/branch}","tags_url":"https://api.github.com/repos/nazar-pc/multipart-parser/tags","blobs_url":"https://api.github.com/repos/nazar-pc/multipart-parser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nazar-pc/multipart-parser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nazar-pc/multipart-parser/git/refs{/sha}","trees_url":"https://api.github.com/repos/nazar-pc/multipart-parser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nazar-pc/multipart-parser/statuses/{sha}","languages_url":"https://api.github.com/repos/nazar-pc/multipart-parser/languages","stargazers_url":"https://api.github.com/repos/nazar-pc/multipart-parser/stargazers","contributors_url":"https://api.github.com/repos/nazar-pc/multipart-parser/contributors","subscribers_url":"https://api.github.com/repos/nazar-pc/multipart-parser/subscribers","subscription_url":"https://api.github.com/repos/nazar-pc/multipart-parser/subscription","commits_url":"https://api.github.com/repos/nazar-pc/multipart-parser/commits{/sha}","git_commits_url":"https://api.github.com/repos/nazar-pc/multipart-parser/git/commits{/sha}","comments_url":"https://api.github.com/repos/nazar-pc/multipart-parser/comments{/number}","issue_comment_url":"https://api.github.com/repos/nazar-pc/multipart-parser/issues/comments{/number}","contents_url":"https://api.github.com/repos/nazar-pc/multipart-parser/contents/{+path}","compare_url":"https://api.github.com/repos/nazar-pc/multipart-parser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nazar-pc/multipart-parser/merges","archive_url":"https://api.github.com/repos/nazar-pc/multipart-parser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nazar-pc/multipart-parser/downloads","issues_url":"https://api.github.com/repos/nazar-pc/multipart-parser/issues{/number}","pulls_url":"https://api.github.com/repos/nazar-pc/multipart-parser/pulls{/number}","milestones_url":"https://api.github.com/repos/nazar-pc/multipart-parser/milestones{/number}","notifications_url":"https://api.github.com/repos/nazar-pc/multipart-parser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nazar-pc/multipart-parser/labels{/name}","releases_url":"https://api.github.com/repos/nazar-pc/multipart-parser/releases{/id}","deployments_url":"https://api.github.com/repos/nazar-pc/multipart-parser/deployments","created_at":"2016-03-20T02:51:21Z","updated_at":"2016-03-20T02:51:22Z","pushed_at":"2016-03-21T11:17:46Z","git_url":"git://github.com/nazar-pc/multipart-parser.git","ssh_url":"git@github.com:nazar-pc/multipart-parser.git","clone_url":"https://github.com/nazar-pc/multipart-parser.git","svn_url":"https://github.com/nazar-pc/multipart-parser","homepage":"","size":25,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Riverline:master","ref":"master","sha":"a25de1a3b01886a6cf25203d7623aa908895ebfb","user":{"login":"Riverline","id":8589449,"avatar_url":"https://avatars.githubusercontent.com/u/8589449?v=3","gravatar_id":"","url":"https://api.github.com/users/Riverline","html_url":"https://github.com/Riverline","followers_url":"https://api.github.com/users/Riverline/followers","following_url":"https://api.github.com/users/Riverline/following{/other_user}","gists_url":"https://api.github.com/users/Riverline/gists{/gist_id}","starred_url":"https://api.github.com/users/Riverline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Riverline/subscriptions","organizations_url":"https://api.github.com/users/Riverline/orgs","repos_url":"https://api.github.com/users/Riverline/repos","events_url":"https://api.github.com/users/Riverline/events{/privacy}","received_events_url":"https://api.github.com/users/Riverline/received_events","type":"Organization","site_admin":false},"repo":{"id":45602225,"name":"multipart-parser","full_name":"Riverline/multipart-parser","owner":{"login":"Riverline","id":8589449,"avatar_url":"https://avatars.githubusercontent.com/u/8589449?v=3","gravatar_id":"","url":"https://api.github.com/users/Riverline","html_url":"https://github.com/Riverline","followers_url":"https://api.github.com/users/Riverline/followers","following_url":"https://api.github.com/users/Riverline/following{/other_user}","gists_url":"https://api.github.com/users/Riverline/gists{/gist_id}","starred_url":"https://api.github.com/users/Riverline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Riverline/subscriptions","organizations_url":"https://api.github.com/users/Riverline/orgs","repos_url":"https://api.github.com/users/Riverline/repos","events_url":"https://api.github.com/users/Riverline/events{/privacy}","received_events_url":"https://api.github.com/users/Riverline/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Riverline/multipart-parser","description":"A one class lib to parse multipart document ( multipart email, multipart form, etc ...) and manage each part encoding and charset to extract their content.","fork":false,"url":"https://api.github.com/repos/Riverline/multipart-parser","forks_url":"https://api.github.com/repos/Riverline/multipart-parser/forks","keys_url":"https://api.github.com/repos/Riverline/multipart-parser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Riverline/multipart-parser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Riverline/multipart-parser/teams","hooks_url":"https://api.github.com/repos/Riverline/multipart-parser/hooks","issue_events_url":"https://api.github.com/repos/Riverline/multipart-parser/issues/events{/number}","events_url":"https://api.github.com/repos/Riverline/multipart-parser/events","assignees_url":"https://api.github.com/repos/Riverline/multipart-parser/assignees{/user}","branches_url":"https://api.github.com/repos/Riverline/multipart-parser/branches{/branch}","tags_url":"https://api.github.com/repos/Riverline/multipart-parser/tags","blobs_url":"https://api.github.com/repos/Riverline/multipart-parser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Riverline/multipart-parser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Riverline/multipart-parser/git/refs{/sha}","trees_url":"https://api.github.com/repos/Riverline/multipart-parser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Riverline/multipart-parser/statuses/{sha}","languages_url":"https://api.github.com/repos/Riverline/multipart-parser/languages","stargazers_url":"https://api.github.com/repos/Riverline/multipart-parser/stargazers","contributors_url":"https://api.github.com/repos/Riverline/multipart-parser/contributors","subscribers_url":"https://api.github.com/repos/Riverline/multipart-parser/subscribers","subscription_url":"https://api.github.com/repos/Riverline/multipart-parser/subscription","commits_url":"https://api.github.com/repos/Riverline/multipart-parser/commits{/sha}","git_commits_url":"https://api.github.com/repos/Riverline/multipart-parser/git/commits{/sha}","comments_url":"https://api.github.com/repos/Riverline/multipart-parser/comments{/number}","issue_comment_url":"https://api.github.com/repos/Riverline/multipart-parser/issues/comments{/number}","contents_url":"https://api.github.com/repos/Riverline/multipart-parser/contents/{+path}","compare_url":"https://api.github.com/repos/Riverline/multipart-parser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Riverline/multipart-parser/merges","archive_url":"https://api.github.com/repos/Riverline/multipart-parser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Riverline/multipart-parser/downloads","issues_url":"https://api.github.com/repos/Riverline/multipart-parser/issues{/number}","pulls_url":"https://api.github.com/repos/Riverline/multipart-parser/pulls{/number}","milestones_url":"https://api.github.com/repos/Riverline/multipart-parser/milestones{/number}","notifications_url":"https://api.github.com/repos/Riverline/multipart-parser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Riverline/multipart-parser/labels{/name}","releases_url":"https://api.github.com/repos/Riverline/multipart-parser/releases{/id}","deployments_url":"https://api.github.com/repos/Riverline/multipart-parser/deployments","created_at":"2015-11-05T09:49:26Z","updated_at":"2016-03-21T08:28:16Z","pushed_at":"2016-03-21T08:35:08Z","git_url":"git://github.com/Riverline/multipart-parser.git","ssh_url":"git@github.com:Riverline/multipart-parser.git","clone_url":"https://github.com/Riverline/multipart-parser.git","svn_url":"https://github.com/Riverline/multipart-parser","homepage":"","size":29,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Riverline/multipart-parser/pulls/6"},"html":{"href":"https://github.com/Riverline/multipart-parser/pull/6"},"issue":{"href":"https://api.github.com/repos/Riverline/multipart-parser/issues/6"},"comments":{"href":"https://api.github.com/repos/Riverline/multipart-parser/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/Riverline/multipart-parser/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/Riverline/multipart-parser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Riverline/multipart-parser/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/Riverline/multipart-parser/statuses/6b3765d0271375d58caf5fb70d136b6beb0b6ffb"}}}}