{"action":"created","comment":{"url":"https://api.github.com/repos/apollostack/apollo-android/pulls/comments/92874318","pull_request_review_id":13399041,"id":92874318,"diff_hunk":"@@ -1,17 +1,34 @@\n package com.apollostack.api;\n \n-import java.util.List;\n+import java.util.Collections;\n import java.util.Map;\n \n /** TODO */\n-public interface Query {\n+public interface Query<V extends Query.Variables> {","path":"apollo-api/src/main/java/com/apollostack/api/Query.java","position":9,"original_position":9,"commit_id":"f926d22c72904d2962ba68e7880c74a3d0ffe03c","original_commit_id":"f926d22c72904d2962ba68e7880c74a3d0ffe03c","user":{"login":"felipecsl","id":190648,"avatar_url":"https://avatars.githubusercontent.com/u/190648?v=3","gravatar_id":"","url":"https://api.github.com/users/felipecsl","html_url":"https://github.com/felipecsl","followers_url":"https://api.github.com/users/felipecsl/followers","following_url":"https://api.github.com/users/felipecsl/following{/other_user}","gists_url":"https://api.github.com/users/felipecsl/gists{/gist_id}","starred_url":"https://api.github.com/users/felipecsl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felipecsl/subscriptions","organizations_url":"https://api.github.com/users/felipecsl/orgs","repos_url":"https://api.github.com/users/felipecsl/repos","events_url":"https://api.github.com/users/felipecsl/events{/privacy}","received_events_url":"https://api.github.com/users/felipecsl/received_events","type":"User","site_admin":false},"body":"ok fair enough, I haven't used GraphQL in production yet to know how often you use variables, but sounds like it's something quite useful","created_at":"2016-12-16T19:47:03Z","updated_at":"2016-12-16T19:47:03Z","html_url":"https://github.com/apollostack/apollo-android/pull/53#discussion_r92874318","pull_request_url":"https://api.github.com/repos/apollostack/apollo-android/pulls/53","_links":{"self":{"href":"https://api.github.com/repos/apollostack/apollo-android/pulls/comments/92874318"},"html":{"href":"https://github.com/apollostack/apollo-android/pull/53#discussion_r92874318"},"pull_request":{"href":"https://api.github.com/repos/apollostack/apollo-android/pulls/53"}}},"pull_request":{"url":"https://api.github.com/repos/apollostack/apollo-android/pulls/53","id":98208585,"html_url":"https://github.com/apollostack/apollo-android/pull/53","diff_url":"https://github.com/apollostack/apollo-android/pull/53.diff","patch_url":"https://github.com/apollostack/apollo-android/pull/53.patch","issue_url":"https://api.github.com/repos/apollostack/apollo-android/issues/53","number":53,"state":"open","locked":false,"title":"Update query code generation","user":{"login":"sav007","id":902816,"avatar_url":"https://avatars.githubusercontent.com/u/902816?v=3","gravatar_id":"","url":"https://api.github.com/users/sav007","html_url":"https://github.com/sav007","followers_url":"https://api.github.com/users/sav007/followers","following_url":"https://api.github.com/users/sav007/following{/other_user}","gists_url":"https://api.github.com/users/sav007/gists{/gist_id}","starred_url":"https://api.github.com/users/sav007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sav007/subscriptions","organizations_url":"https://api.github.com/users/sav007/orgs","repos_url":"https://api.github.com/users/sav007/repos","events_url":"https://api.github.com/users/sav007/events{/privacy}","received_events_url":"https://api.github.com/users/sav007/received_events","type":"User","site_admin":false},"body":"Refactor `com.apollostack.api.Query`\r\nUpdate how query been generated to comply with `Query` api\r\n\r\nExample of generated code with arguments: https://github.com/apollostack/apollo-android/blob/f926d22c72904d2962ba68e7880c74a3d0ffe03c/apollo-compiler/src/test/graphql/com/example/simple_arguments/TestQueryExpected.java\r\n\r\nExample of generated code with fragments: https://github.com/apollostack/apollo-android/blob/f926d22c72904d2962ba68e7880c74a3d0ffe03c/apollo-compiler/src/test/graphql/com/example/fragments_with_type_condition/TestQueryExpected.java\r\n\r\nAPI usage example:\r\n```\r\nfinal Query query = new TestQuery(\r\n        new TestQuery.Variables.Builder()\r\n            .episode(Episode.JEDI)\r\n            .includeName(true)\r\n            .build()\r\n    );\r\n```\r\n\r\nTo get access to operation definition source and variables map for serialization purpose:\r\n```\r\nString definition = query.operationDefinition();\r\nMap<String, Object> varialbles = query.variables().toMap();\r\n```\r\n\r\nCloses #51 \r\n\r\n@felipecsl @martijnwalraven pls take a look","created_at":"2016-12-15T18:51:39Z","updated_at":"2016-12-16T19:47:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8980b699266558776db188436503dff3072ee6fe","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apollostack/apollo-android/pulls/53/commits","review_comments_url":"https://api.github.com/repos/apollostack/apollo-android/pulls/53/comments","review_comment_url":"https://api.github.com/repos/apollostack/apollo-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apollostack/apollo-android/issues/53/comments","statuses_url":"https://api.github.com/repos/apollostack/apollo-android/statuses/f926d22c72904d2962ba68e7880c74a3d0ffe03c","head":{"label":"sav007:feature-51/refactor-query-generation","ref":"feature-51/refactor-query-generation","sha":"f926d22c72904d2962ba68e7880c74a3d0ffe03c","user":{"login":"sav007","id":902816,"avatar_url":"https://avatars.githubusercontent.com/u/902816?v=3","gravatar_id":"","url":"https://api.github.com/users/sav007","html_url":"https://github.com/sav007","followers_url":"https://api.github.com/users/sav007/followers","following_url":"https://api.github.com/users/sav007/following{/other_user}","gists_url":"https://api.github.com/users/sav007/gists{/gist_id}","starred_url":"https://api.github.com/users/sav007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sav007/subscriptions","organizations_url":"https://api.github.com/users/sav007/orgs","repos_url":"https://api.github.com/users/sav007/repos","events_url":"https://api.github.com/users/sav007/events{/privacy}","received_events_url":"https://api.github.com/users/sav007/received_events","type":"User","site_admin":false},"repo":{"id":75508760,"name":"apollo-android","full_name":"sav007/apollo-android","owner":{"login":"sav007","id":902816,"avatar_url":"https://avatars.githubusercontent.com/u/902816?v=3","gravatar_id":"","url":"https://api.github.com/users/sav007","html_url":"https://github.com/sav007","followers_url":"https://api.github.com/users/sav007/followers","following_url":"https://api.github.com/users/sav007/following{/other_user}","gists_url":"https://api.github.com/users/sav007/gists{/gist_id}","starred_url":"https://api.github.com/users/sav007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sav007/subscriptions","organizations_url":"https://api.github.com/users/sav007/orgs","repos_url":"https://api.github.com/users/sav007/repos","events_url":"https://api.github.com/users/sav007/events{/privacy}","received_events_url":"https://api.github.com/users/sav007/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sav007/apollo-android","description":":pager: A GraphQL client for Android (WIP)","fork":true,"url":"https://api.github.com/repos/sav007/apollo-android","forks_url":"https://api.github.com/repos/sav007/apollo-android/forks","keys_url":"https://api.github.com/repos/sav007/apollo-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sav007/apollo-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sav007/apollo-android/teams","hooks_url":"https://api.github.com/repos/sav007/apollo-android/hooks","issue_events_url":"https://api.github.com/repos/sav007/apollo-android/issues/events{/number}","events_url":"https://api.github.com/repos/sav007/apollo-android/events","assignees_url":"https://api.github.com/repos/sav007/apollo-android/assignees{/user}","branches_url":"https://api.github.com/repos/sav007/apollo-android/branches{/branch}","tags_url":"https://api.github.com/repos/sav007/apollo-android/tags","blobs_url":"https://api.github.com/repos/sav007/apollo-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sav007/apollo-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sav007/apollo-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/sav007/apollo-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sav007/apollo-android/statuses/{sha}","languages_url":"https://api.github.com/repos/sav007/apollo-android/languages","stargazers_url":"https://api.github.com/repos/sav007/apollo-android/stargazers","contributors_url":"https://api.github.com/repos/sav007/apollo-android/contributors","subscribers_url":"https://api.github.com/repos/sav007/apollo-android/subscribers","subscription_url":"https://api.github.com/repos/sav007/apollo-android/subscription","commits_url":"https://api.github.com/repos/sav007/apollo-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/sav007/apollo-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/sav007/apollo-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/sav007/apollo-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/sav007/apollo-android/contents/{+path}","compare_url":"https://api.github.com/repos/sav007/apollo-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sav007/apollo-android/merges","archive_url":"https://api.github.com/repos/sav007/apollo-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sav007/apollo-android/downloads","issues_url":"https://api.github.com/repos/sav007/apollo-android/issues{/number}","pulls_url":"https://api.github.com/repos/sav007/apollo-android/pulls{/number}","milestones_url":"https://api.github.com/repos/sav007/apollo-android/milestones{/number}","notifications_url":"https://api.github.com/repos/sav007/apollo-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sav007/apollo-android/labels{/name}","releases_url":"https://api.github.com/repos/sav007/apollo-android/releases{/id}","deployments_url":"https://api.github.com/repos/sav007/apollo-android/deployments","created_at":"2016-12-04T00:33:01Z","updated_at":"2016-12-04T00:33:02Z","pushed_at":"2016-12-16T02:26:36Z","git_url":"git://github.com/sav007/apollo-android.git","ssh_url":"git@github.com:sav007/apollo-android.git","clone_url":"https://github.com/sav007/apollo-android.git","svn_url":"https://github.com/sav007/apollo-android","homepage":"","size":195,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apollostack:master","ref":"master","sha":"67c41e19ca2a6ad7e633c702e9f271fbdc4d403b","user":{"login":"apollostack","id":17189275,"avatar_url":"https://avatars.githubusercontent.com/u/17189275?v=3","gravatar_id":"","url":"https://api.github.com/users/apollostack","html_url":"https://github.com/apollostack","followers_url":"https://api.github.com/users/apollostack/followers","following_url":"https://api.github.com/users/apollostack/following{/other_user}","gists_url":"https://api.github.com/users/apollostack/gists{/gist_id}","starred_url":"https://api.github.com/users/apollostack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollostack/subscriptions","organizations_url":"https://api.github.com/users/apollostack/orgs","repos_url":"https://api.github.com/users/apollostack/repos","events_url":"https://api.github.com/users/apollostack/events{/privacy}","received_events_url":"https://api.github.com/users/apollostack/received_events","type":"Organization","site_admin":false},"repo":{"id":69469299,"name":"apollo-android","full_name":"apollostack/apollo-android","owner":{"login":"apollostack","id":17189275,"avatar_url":"https://avatars.githubusercontent.com/u/17189275?v=3","gravatar_id":"","url":"https://api.github.com/users/apollostack","html_url":"https://github.com/apollostack","followers_url":"https://api.github.com/users/apollostack/followers","following_url":"https://api.github.com/users/apollostack/following{/other_user}","gists_url":"https://api.github.com/users/apollostack/gists{/gist_id}","starred_url":"https://api.github.com/users/apollostack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollostack/subscriptions","organizations_url":"https://api.github.com/users/apollostack/orgs","repos_url":"https://api.github.com/users/apollostack/repos","events_url":"https://api.github.com/users/apollostack/events{/privacy}","received_events_url":"https://api.github.com/users/apollostack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apollostack/apollo-android","description":":pager: A GraphQL client for Android (WIP)","fork":false,"url":"https://api.github.com/repos/apollostack/apollo-android","forks_url":"https://api.github.com/repos/apollostack/apollo-android/forks","keys_url":"https://api.github.com/repos/apollostack/apollo-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apollostack/apollo-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apollostack/apollo-android/teams","hooks_url":"https://api.github.com/repos/apollostack/apollo-android/hooks","issue_events_url":"https://api.github.com/repos/apollostack/apollo-android/issues/events{/number}","events_url":"https://api.github.com/repos/apollostack/apollo-android/events","assignees_url":"https://api.github.com/repos/apollostack/apollo-android/assignees{/user}","branches_url":"https://api.github.com/repos/apollostack/apollo-android/branches{/branch}","tags_url":"https://api.github.com/repos/apollostack/apollo-android/tags","blobs_url":"https://api.github.com/repos/apollostack/apollo-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apollostack/apollo-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apollostack/apollo-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/apollostack/apollo-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apollostack/apollo-android/statuses/{sha}","languages_url":"https://api.github.com/repos/apollostack/apollo-android/languages","stargazers_url":"https://api.github.com/repos/apollostack/apollo-android/stargazers","contributors_url":"https://api.github.com/repos/apollostack/apollo-android/contributors","subscribers_url":"https://api.github.com/repos/apollostack/apollo-android/subscribers","subscription_url":"https://api.github.com/repos/apollostack/apollo-android/subscription","commits_url":"https://api.github.com/repos/apollostack/apollo-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/apollostack/apollo-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/apollostack/apollo-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/apollostack/apollo-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/apollostack/apollo-android/contents/{+path}","compare_url":"https://api.github.com/repos/apollostack/apollo-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apollostack/apollo-android/merges","archive_url":"https://api.github.com/repos/apollostack/apollo-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apollostack/apollo-android/downloads","issues_url":"https://api.github.com/repos/apollostack/apollo-android/issues{/number}","pulls_url":"https://api.github.com/repos/apollostack/apollo-android/pulls{/number}","milestones_url":"https://api.github.com/repos/apollostack/apollo-android/milestones{/number}","notifications_url":"https://api.github.com/repos/apollostack/apollo-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apollostack/apollo-android/labels{/name}","releases_url":"https://api.github.com/repos/apollostack/apollo-android/releases{/id}","deployments_url":"https://api.github.com/repos/apollostack/apollo-android/deployments","created_at":"2016-09-28T14:03:30Z","updated_at":"2016-12-16T02:21:55Z","pushed_at":"2016-12-16T02:46:29Z","git_url":"git://github.com/apollostack/apollo-android.git","ssh_url":"git@github.com:apollostack/apollo-android.git","clone_url":"https://github.com/apollostack/apollo-android.git","svn_url":"https://github.com/apollostack/apollo-android","homepage":"","size":194,"stargazers_count":43,"watchers_count":43,"language":"Kotlin","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":10,"forks":5,"open_issues":10,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apollostack/apollo-android/pulls/53"},"html":{"href":"https://github.com/apollostack/apollo-android/pull/53"},"issue":{"href":"https://api.github.com/repos/apollostack/apollo-android/issues/53"},"comments":{"href":"https://api.github.com/repos/apollostack/apollo-android/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/apollostack/apollo-android/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/apollostack/apollo-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apollostack/apollo-android/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/apollostack/apollo-android/statuses/f926d22c72904d2962ba68e7880c74a3d0ffe03c"}}}}
{"actor":{"display_login":"felipecsl"}}