{"action":"created","comment":{"url":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/comments/91567770","pull_request_review_id":12077718,"id":91567770,"diff_hunk":"@@ -31,8 +31,8 @@ export function isNotificationSupported() {\n   return window && window.Notification;\n }\n \n-export function requestPermissionForNotifications() {\n-  return window.Notification.requestPermission();\n+export function requestPermissionForNotifications(callback) {","path":"packages/widget-chat/src/utils/browser.js","position":6,"original_position":6,"commit_id":"772592a3612ffec49418e0d7d770d7e987355f52","original_commit_id":"772592a3612ffec49418e0d7d770d7e987355f52","user":{"login":"ianwremmel","id":1182361,"avatar_url":"https://avatars.githubusercontent.com/u/1182361?v=3","gravatar_id":"","url":"https://api.github.com/users/ianwremmel","html_url":"https://github.com/ianwremmel","followers_url":"https://api.github.com/users/ianwremmel/followers","following_url":"https://api.github.com/users/ianwremmel/following{/other_user}","gists_url":"https://api.github.com/users/ianwremmel/gists{/gist_id}","starred_url":"https://api.github.com/users/ianwremmel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianwremmel/subscriptions","organizations_url":"https://api.github.com/users/ianwremmel/orgs","repos_url":"https://api.github.com/users/ianwremmel/repos","events_url":"https://api.github.com/users/ianwremmel/events{/privacy}","received_events_url":"https://api.github.com/users/ianwremmel/received_events","type":"User","site_admin":false},"body":"gotcha","created_at":"2016-12-08T17:49:44Z","updated_at":"2016-12-08T17:49:45Z","html_url":"https://github.com/ciscospark/spark-js-sdk/pull/367#discussion_r91567770","pull_request_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/367","_links":{"self":{"href":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/comments/91567770"},"html":{"href":"https://github.com/ciscospark/spark-js-sdk/pull/367#discussion_r91567770"},"pull_request":{"href":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/367"}}},"pull_request":{"url":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/367","id":97011392,"html_url":"https://github.com/ciscospark/spark-js-sdk/pull/367","diff_url":"https://github.com/ciscospark/spark-js-sdk/pull/367.diff","patch_url":"https://github.com/ciscospark/spark-js-sdk/pull/367.patch","issue_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/issues/367","number":367,"state":"open","locked":false,"title":"fix(widget-chat): Browser fixes","user":{"login":"bzang","id":99547,"avatar_url":"https://avatars.githubusercontent.com/u/99547?v=3","gravatar_id":"","url":"https://api.github.com/users/bzang","html_url":"https://github.com/bzang","followers_url":"https://api.github.com/users/bzang/followers","following_url":"https://api.github.com/users/bzang/following{/other_user}","gists_url":"https://api.github.com/users/bzang/gists{/gist_id}","starred_url":"https://api.github.com/users/bzang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bzang/subscriptions","organizations_url":"https://api.github.com/users/bzang/orgs","repos_url":"https://api.github.com/users/bzang/repos","events_url":"https://api.github.com/users/bzang/events{/privacy}","received_events_url":"https://api.github.com/users/bzang/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-12-07T21:31:59Z","updated_at":"2016-12-08T17:49:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3ad673d99b1a49211233965dedfa090f4eadaad","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/367/commits","review_comments_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/367/comments","review_comment_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/issues/367/comments","statuses_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/statuses/772592a3612ffec49418e0d7d770d7e987355f52","head":{"label":"bzang:browser-fixes","ref":"browser-fixes","sha":"772592a3612ffec49418e0d7d770d7e987355f52","user":{"login":"bzang","id":99547,"avatar_url":"https://avatars.githubusercontent.com/u/99547?v=3","gravatar_id":"","url":"https://api.github.com/users/bzang","html_url":"https://github.com/bzang","followers_url":"https://api.github.com/users/bzang/followers","following_url":"https://api.github.com/users/bzang/following{/other_user}","gists_url":"https://api.github.com/users/bzang/gists{/gist_id}","starred_url":"https://api.github.com/users/bzang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bzang/subscriptions","organizations_url":"https://api.github.com/users/bzang/orgs","repos_url":"https://api.github.com/users/bzang/repos","events_url":"https://api.github.com/users/bzang/events{/privacy}","received_events_url":"https://api.github.com/users/bzang/received_events","type":"User","site_admin":false},"repo":{"id":69598624,"name":"spark-js-sdk","full_name":"bzang/spark-js-sdk","owner":{"login":"bzang","id":99547,"avatar_url":"https://avatars.githubusercontent.com/u/99547?v=3","gravatar_id":"","url":"https://api.github.com/users/bzang","html_url":"https://github.com/bzang","followers_url":"https://api.github.com/users/bzang/followers","following_url":"https://api.github.com/users/bzang/following{/other_user}","gists_url":"https://api.github.com/users/bzang/gists{/gist_id}","starred_url":"https://api.github.com/users/bzang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bzang/subscriptions","organizations_url":"https://api.github.com/users/bzang/orgs","repos_url":"https://api.github.com/users/bzang/repos","events_url":"https://api.github.com/users/bzang/events{/privacy}","received_events_url":"https://api.github.com/users/bzang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bzang/spark-js-sdk","description":null,"fork":true,"url":"https://api.github.com/repos/bzang/spark-js-sdk","forks_url":"https://api.github.com/repos/bzang/spark-js-sdk/forks","keys_url":"https://api.github.com/repos/bzang/spark-js-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bzang/spark-js-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bzang/spark-js-sdk/teams","hooks_url":"https://api.github.com/repos/bzang/spark-js-sdk/hooks","issue_events_url":"https://api.github.com/repos/bzang/spark-js-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/bzang/spark-js-sdk/events","assignees_url":"https://api.github.com/repos/bzang/spark-js-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/bzang/spark-js-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/bzang/spark-js-sdk/tags","blobs_url":"https://api.github.com/repos/bzang/spark-js-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bzang/spark-js-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bzang/spark-js-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/bzang/spark-js-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bzang/spark-js-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/bzang/spark-js-sdk/languages","stargazers_url":"https://api.github.com/repos/bzang/spark-js-sdk/stargazers","contributors_url":"https://api.github.com/repos/bzang/spark-js-sdk/contributors","subscribers_url":"https://api.github.com/repos/bzang/spark-js-sdk/subscribers","subscription_url":"https://api.github.com/repos/bzang/spark-js-sdk/subscription","commits_url":"https://api.github.com/repos/bzang/spark-js-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/bzang/spark-js-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/bzang/spark-js-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/bzang/spark-js-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/bzang/spark-js-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/bzang/spark-js-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bzang/spark-js-sdk/merges","archive_url":"https://api.github.com/repos/bzang/spark-js-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bzang/spark-js-sdk/downloads","issues_url":"https://api.github.com/repos/bzang/spark-js-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/bzang/spark-js-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/bzang/spark-js-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/bzang/spark-js-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bzang/spark-js-sdk/labels{/name}","releases_url":"https://api.github.com/repos/bzang/spark-js-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/bzang/spark-js-sdk/deployments","created_at":"2016-09-29T19:02:02Z","updated_at":"2016-09-29T19:02:04Z","pushed_at":"2016-12-08T16:56:45Z","git_url":"git://github.com/bzang/spark-js-sdk.git","ssh_url":"git@github.com:bzang/spark-js-sdk.git","clone_url":"https://github.com/bzang/spark-js-sdk.git","svn_url":"https://github.com/bzang/spark-js-sdk","homepage":"https://ciscospark.github.io/spark-js-sdk/","size":15180,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ciscospark:widget-chat-features","ref":"widget-chat-features","sha":"aba49b00f47d5971c44cd71f5f2d9a24c5ff7dca","user":{"login":"ciscospark","id":15900782,"avatar_url":"https://avatars.githubusercontent.com/u/15900782?v=3","gravatar_id":"","url":"https://api.github.com/users/ciscospark","html_url":"https://github.com/ciscospark","followers_url":"https://api.github.com/users/ciscospark/followers","following_url":"https://api.github.com/users/ciscospark/following{/other_user}","gists_url":"https://api.github.com/users/ciscospark/gists{/gist_id}","starred_url":"https://api.github.com/users/ciscospark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciscospark/subscriptions","organizations_url":"https://api.github.com/users/ciscospark/orgs","repos_url":"https://api.github.com/users/ciscospark/repos","events_url":"https://api.github.com/users/ciscospark/events{/privacy}","received_events_url":"https://api.github.com/users/ciscospark/received_events","type":"Organization","site_admin":false},"repo":{"id":62836827,"name":"spark-js-sdk","full_name":"ciscospark/spark-js-sdk","owner":{"login":"ciscospark","id":15900782,"avatar_url":"https://avatars.githubusercontent.com/u/15900782?v=3","gravatar_id":"","url":"https://api.github.com/users/ciscospark","html_url":"https://github.com/ciscospark","followers_url":"https://api.github.com/users/ciscospark/followers","following_url":"https://api.github.com/users/ciscospark/following{/other_user}","gists_url":"https://api.github.com/users/ciscospark/gists{/gist_id}","starred_url":"https://api.github.com/users/ciscospark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciscospark/subscriptions","organizations_url":"https://api.github.com/users/ciscospark/orgs","repos_url":"https://api.github.com/users/ciscospark/repos","events_url":"https://api.github.com/users/ciscospark/events{/privacy}","received_events_url":"https://api.github.com/users/ciscospark/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ciscospark/spark-js-sdk","description":null,"fork":false,"url":"https://api.github.com/repos/ciscospark/spark-js-sdk","forks_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/forks","keys_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/teams","hooks_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/hooks","issue_events_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/events","assignees_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/tags","blobs_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/languages","stargazers_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/stargazers","contributors_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/contributors","subscribers_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/subscribers","subscription_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/subscription","commits_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/merges","archive_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/downloads","issues_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/labels{/name}","releases_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/deployments","created_at":"2016-07-07T20:41:12Z","updated_at":"2016-12-07T20:50:41Z","pushed_at":"2016-12-08T17:41:27Z","git_url":"git://github.com/ciscospark/spark-js-sdk.git","ssh_url":"git@github.com:ciscospark/spark-js-sdk.git","clone_url":"https://github.com/ciscospark/spark-js-sdk.git","svn_url":"https://github.com/ciscospark/spark-js-sdk","homepage":"https://ciscospark.github.io/spark-js-sdk/","size":18999,"stargazers_count":24,"watchers_count":24,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":32,"mirror_url":null,"open_issues_count":95,"forks":32,"open_issues":95,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/367"},"html":{"href":"https://github.com/ciscospark/spark-js-sdk/pull/367"},"issue":{"href":"https://api.github.com/repos/ciscospark/spark-js-sdk/issues/367"},"comments":{"href":"https://api.github.com/repos/ciscospark/spark-js-sdk/issues/367/comments"},"review_comments":{"href":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/367/comments"},"review_comment":{"href":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/367/commits"},"statuses":{"href":"https://api.github.com/repos/ciscospark/spark-js-sdk/statuses/772592a3612ffec49418e0d7d770d7e987355f52"}}}}
{"actor":{"display_login":"ianwremmel"}}