{"action":"created","comment":{"url":"https://api.github.com/repos/mockingbirdnest/Principia/pulls/comments/58309822","id":58309822,"diff_hunk":"@@ -286,17 +286,40 @@ not_null<Tr4jectory*> Forkable<Tr4jectory, It3rator>::NewFork(\n     time = internal::ForkableTraits<Tr4jectory>::time(timeline_it);\n   }\n   auto const child_it = children_.emplace(time, std::make_unique<Tr4jectory>());\n-  typename Children::const_iterator const_child_it = child_it;\n \n   // Now set the members of the child object.\n-  std::unique_ptr<Tr4jectory> const& child_forkable = const_child_it->second;\n+  std::unique_ptr<Tr4jectory> const& child_forkable = child_it->second;\n   child_forkable->parent_ = that();\n-  child_forkable->position_in_parent_children_ = const_child_it;\n+  child_forkable->position_in_parent_children_ = child_it;\n   child_forkable->position_in_parent_timeline_ = timeline_it;\n \n   return child_forkable.get();\n }\n \n+template <typename Tr4jectory, typename It3rator>\n+void Forkable<Tr4jectory, It3rator>::DetachForkWithCopiedBegin() {","path":"physics/forkable_body.hpp","position":45,"original_position":45,"commit_id":"6a572a5a468af2e800c31861fae678dc71ad2a3d","original_commit_id":"6a572a5a468af2e800c31861fae678dc71ad2a3d","user":{"login":"eggrobin","id":2284290,"avatar_url":"https://avatars.githubusercontent.com/u/2284290?v=3","gravatar_id":"","url":"https://api.github.com/users/eggrobin","html_url":"https://github.com/eggrobin","followers_url":"https://api.github.com/users/eggrobin/followers","following_url":"https://api.github.com/users/eggrobin/following{/other_user}","gists_url":"https://api.github.com/users/eggrobin/gists{/gist_id}","starred_url":"https://api.github.com/users/eggrobin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eggrobin/subscriptions","organizations_url":"https://api.github.com/users/eggrobin/orgs","repos_url":"https://api.github.com/users/eggrobin/repos","events_url":"https://api.github.com/users/eggrobin/events{/privacy}","received_events_url":"https://api.github.com/users/eggrobin/received_events","type":"User","site_admin":false},"body":"Have this return a `unique_ptr`","created_at":"2016-04-03T12:56:47Z","updated_at":"2016-04-03T12:56:47Z","html_url":"https://github.com/mockingbirdnest/Principia/pull/982#discussion_r58309822","pull_request_url":"https://api.github.com/repos/mockingbirdnest/Principia/pulls/982","_links":{"self":{"href":"https://api.github.com/repos/mockingbirdnest/Principia/pulls/comments/58309822"},"html":{"href":"https://github.com/mockingbirdnest/Principia/pull/982#discussion_r58309822"},"pull_request":{"href":"https://api.github.com/repos/mockingbirdnest/Principia/pulls/982"}}},"pull_request":{"url":"https://api.github.com/repos/mockingbirdnest/Principia/pulls/982","id":65067091,"html_url":"https://github.com/mockingbirdnest/Principia/pull/982","diff_url":"https://github.com/mockingbirdnest/Principia/pull/982.diff","patch_url":"https://github.com/mockingbirdnest/Principia/pull/982.patch","issue_url":"https://api.github.com/repos/mockingbirdnest/Principia/issues/982","number":982,"state":"open","locked":false,"title":"Add DetachFork and NewForkWithoutCopy","user":{"login":"pleroy","id":7423020,"avatar_url":"https://avatars.githubusercontent.com/u/7423020?v=3","gravatar_id":"","url":"https://api.github.com/users/pleroy","html_url":"https://github.com/pleroy","followers_url":"https://api.github.com/users/pleroy/followers","following_url":"https://api.github.com/users/pleroy/following{/other_user}","gists_url":"https://api.github.com/users/pleroy/gists{/gist_id}","starred_url":"https://api.github.com/users/pleroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pleroy/subscriptions","organizations_url":"https://api.github.com/users/pleroy/orgs","repos_url":"https://api.github.com/users/pleroy/repos","events_url":"https://api.github.com/users/pleroy/events{/privacy}","received_events_url":"https://api.github.com/users/pleroy/received_events","type":"User","site_admin":false},"body":"Also rename a protocol buffer.  This is the first step towards solving #972.","created_at":"2016-04-03T12:24:40Z","updated_at":"2016-04-03T12:56:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2266fdafd73f0d1d9a1e146c7dd3a7546e0935ad","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mockingbirdnest/Principia/pulls/982/commits","review_comments_url":"https://api.github.com/repos/mockingbirdnest/Principia/pulls/982/comments","review_comment_url":"https://api.github.com/repos/mockingbirdnest/Principia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mockingbirdnest/Principia/issues/982/comments","statuses_url":"https://api.github.com/repos/mockingbirdnest/Principia/statuses/6a572a5a468af2e800c31861fae678dc71ad2a3d","head":{"label":"pleroy:DetachForkable","ref":"DetachForkable","sha":"6a572a5a468af2e800c31861fae678dc71ad2a3d","user":{"login":"pleroy","id":7423020,"avatar_url":"https://avatars.githubusercontent.com/u/7423020?v=3","gravatar_id":"","url":"https://api.github.com/users/pleroy","html_url":"https://github.com/pleroy","followers_url":"https://api.github.com/users/pleroy/followers","following_url":"https://api.github.com/users/pleroy/following{/other_user}","gists_url":"https://api.github.com/users/pleroy/gists{/gist_id}","starred_url":"https://api.github.com/users/pleroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pleroy/subscriptions","organizations_url":"https://api.github.com/users/pleroy/orgs","repos_url":"https://api.github.com/users/pleroy/repos","events_url":"https://api.github.com/users/pleroy/events{/privacy}","received_events_url":"https://api.github.com/users/pleroy/received_events","type":"User","site_admin":false},"repo":{"id":19217274,"name":"Principia","full_name":"pleroy/Principia","owner":{"login":"pleroy","id":7423020,"avatar_url":"https://avatars.githubusercontent.com/u/7423020?v=3","gravatar_id":"","url":"https://api.github.com/users/pleroy","html_url":"https://github.com/pleroy","followers_url":"https://api.github.com/users/pleroy/followers","following_url":"https://api.github.com/users/pleroy/following{/other_user}","gists_url":"https://api.github.com/users/pleroy/gists{/gist_id}","starred_url":"https://api.github.com/users/pleroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pleroy/subscriptions","organizations_url":"https://api.github.com/users/pleroy/orgs","repos_url":"https://api.github.com/users/pleroy/repos","events_url":"https://api.github.com/users/pleroy/events{/privacy}","received_events_url":"https://api.github.com/users/pleroy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pleroy/Principia","description":"N-Body Gravitation and Better Integrators for Kerbal Space Program","fork":true,"url":"https://api.github.com/repos/pleroy/Principia","forks_url":"https://api.github.com/repos/pleroy/Principia/forks","keys_url":"https://api.github.com/repos/pleroy/Principia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pleroy/Principia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pleroy/Principia/teams","hooks_url":"https://api.github.com/repos/pleroy/Principia/hooks","issue_events_url":"https://api.github.com/repos/pleroy/Principia/issues/events{/number}","events_url":"https://api.github.com/repos/pleroy/Principia/events","assignees_url":"https://api.github.com/repos/pleroy/Principia/assignees{/user}","branches_url":"https://api.github.com/repos/pleroy/Principia/branches{/branch}","tags_url":"https://api.github.com/repos/pleroy/Principia/tags","blobs_url":"https://api.github.com/repos/pleroy/Principia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pleroy/Principia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pleroy/Principia/git/refs{/sha}","trees_url":"https://api.github.com/repos/pleroy/Principia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pleroy/Principia/statuses/{sha}","languages_url":"https://api.github.com/repos/pleroy/Principia/languages","stargazers_url":"https://api.github.com/repos/pleroy/Principia/stargazers","contributors_url":"https://api.github.com/repos/pleroy/Principia/contributors","subscribers_url":"https://api.github.com/repos/pleroy/Principia/subscribers","subscription_url":"https://api.github.com/repos/pleroy/Principia/subscription","commits_url":"https://api.github.com/repos/pleroy/Principia/commits{/sha}","git_commits_url":"https://api.github.com/repos/pleroy/Principia/git/commits{/sha}","comments_url":"https://api.github.com/repos/pleroy/Principia/comments{/number}","issue_comment_url":"https://api.github.com/repos/pleroy/Principia/issues/comments{/number}","contents_url":"https://api.github.com/repos/pleroy/Principia/contents/{+path}","compare_url":"https://api.github.com/repos/pleroy/Principia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pleroy/Principia/merges","archive_url":"https://api.github.com/repos/pleroy/Principia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pleroy/Principia/downloads","issues_url":"https://api.github.com/repos/pleroy/Principia/issues{/number}","pulls_url":"https://api.github.com/repos/pleroy/Principia/pulls{/number}","milestones_url":"https://api.github.com/repos/pleroy/Principia/milestones{/number}","notifications_url":"https://api.github.com/repos/pleroy/Principia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pleroy/Principia/labels{/name}","releases_url":"https://api.github.com/repos/pleroy/Principia/releases{/id}","deployments_url":"https://api.github.com/repos/pleroy/Principia/deployments","created_at":"2014-04-27T20:57:02Z","updated_at":"2016-02-14T21:22:51Z","pushed_at":"2016-04-03T12:23:48Z","git_url":"git://github.com/pleroy/Principia.git","ssh_url":"git@github.com:pleroy/Principia.git","clone_url":"https://github.com/pleroy/Principia.git","svn_url":"https://github.com/pleroy/Principia","homepage":"http://forum.kerbalspaceprogram.com/threads/68502-WIP-Principia-N-Body-Gravitation-and-Better-Integrators-for-Kerbal-Space-Program","size":24686,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mockingbirdnest:master","ref":"master","sha":"ddbb650d75dbb596c8b2a61a95490ba961ce593f","user":{"login":"mockingbirdnest","id":7462691,"avatar_url":"https://avatars.githubusercontent.com/u/7462691?v=3","gravatar_id":"","url":"https://api.github.com/users/mockingbirdnest","html_url":"https://github.com/mockingbirdnest","followers_url":"https://api.github.com/users/mockingbirdnest/followers","following_url":"https://api.github.com/users/mockingbirdnest/following{/other_user}","gists_url":"https://api.github.com/users/mockingbirdnest/gists{/gist_id}","starred_url":"https://api.github.com/users/mockingbirdnest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mockingbirdnest/subscriptions","organizations_url":"https://api.github.com/users/mockingbirdnest/orgs","repos_url":"https://api.github.com/users/mockingbirdnest/repos","events_url":"https://api.github.com/users/mockingbirdnest/events{/privacy}","received_events_url":"https://api.github.com/users/mockingbirdnest/received_events","type":"Organization","site_admin":false},"repo":{"id":16634370,"name":"Principia","full_name":"mockingbirdnest/Principia","owner":{"login":"mockingbirdnest","id":7462691,"avatar_url":"https://avatars.githubusercontent.com/u/7462691?v=3","gravatar_id":"","url":"https://api.github.com/users/mockingbirdnest","html_url":"https://github.com/mockingbirdnest","followers_url":"https://api.github.com/users/mockingbirdnest/followers","following_url":"https://api.github.com/users/mockingbirdnest/following{/other_user}","gists_url":"https://api.github.com/users/mockingbirdnest/gists{/gist_id}","starred_url":"https://api.github.com/users/mockingbirdnest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mockingbirdnest/subscriptions","organizations_url":"https://api.github.com/users/mockingbirdnest/orgs","repos_url":"https://api.github.com/users/mockingbirdnest/repos","events_url":"https://api.github.com/users/mockingbirdnest/events{/privacy}","received_events_url":"https://api.github.com/users/mockingbirdnest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mockingbirdnest/Principia","description":"N-Body Gravitation and Better Integrators for Kerbal Space Program","fork":false,"url":"https://api.github.com/repos/mockingbirdnest/Principia","forks_url":"https://api.github.com/repos/mockingbirdnest/Principia/forks","keys_url":"https://api.github.com/repos/mockingbirdnest/Principia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mockingbirdnest/Principia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mockingbirdnest/Principia/teams","hooks_url":"https://api.github.com/repos/mockingbirdnest/Principia/hooks","issue_events_url":"https://api.github.com/repos/mockingbirdnest/Principia/issues/events{/number}","events_url":"https://api.github.com/repos/mockingbirdnest/Principia/events","assignees_url":"https://api.github.com/repos/mockingbirdnest/Principia/assignees{/user}","branches_url":"https://api.github.com/repos/mockingbirdnest/Principia/branches{/branch}","tags_url":"https://api.github.com/repos/mockingbirdnest/Principia/tags","blobs_url":"https://api.github.com/repos/mockingbirdnest/Principia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mockingbirdnest/Principia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mockingbirdnest/Principia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mockingbirdnest/Principia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mockingbirdnest/Principia/statuses/{sha}","languages_url":"https://api.github.com/repos/mockingbirdnest/Principia/languages","stargazers_url":"https://api.github.com/repos/mockingbirdnest/Principia/stargazers","contributors_url":"https://api.github.com/repos/mockingbirdnest/Principia/contributors","subscribers_url":"https://api.github.com/repos/mockingbirdnest/Principia/subscribers","subscription_url":"https://api.github.com/repos/mockingbirdnest/Principia/subscription","commits_url":"https://api.github.com/repos/mockingbirdnest/Principia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mockingbirdnest/Principia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mockingbirdnest/Principia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mockingbirdnest/Principia/issues/comments{/number}","contents_url":"https://api.github.com/repos/mockingbirdnest/Principia/contents/{+path}","compare_url":"https://api.github.com/repos/mockingbirdnest/Principia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mockingbirdnest/Principia/merges","archive_url":"https://api.github.com/repos/mockingbirdnest/Principia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mockingbirdnest/Principia/downloads","issues_url":"https://api.github.com/repos/mockingbirdnest/Principia/issues{/number}","pulls_url":"https://api.github.com/repos/mockingbirdnest/Principia/pulls{/number}","milestones_url":"https://api.github.com/repos/mockingbirdnest/Principia/milestones{/number}","notifications_url":"https://api.github.com/repos/mockingbirdnest/Principia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mockingbirdnest/Principia/labels{/name}","releases_url":"https://api.github.com/repos/mockingbirdnest/Principia/releases{/id}","deployments_url":"https://api.github.com/repos/mockingbirdnest/Principia/deployments","created_at":"2014-02-08T02:55:32Z","updated_at":"2016-04-02T23:05:28Z","pushed_at":"2016-04-03T12:24:41Z","git_url":"git://github.com/mockingbirdnest/Principia.git","ssh_url":"git@github.com:mockingbirdnest/Principia.git","clone_url":"https://github.com/mockingbirdnest/Principia.git","svn_url":"https://github.com/mockingbirdnest/Principia","homepage":"http://forum.kerbalspaceprogram.com/threads/68502-WIP-Principia-N-Body-Gravitation-and-Better-Integrators-for-Kerbal-Space-Program","size":26604,"stargazers_count":110,"watchers_count":110,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":58,"forks":14,"open_issues":58,"watchers":110,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mockingbirdnest/Principia/pulls/982"},"html":{"href":"https://github.com/mockingbirdnest/Principia/pull/982"},"issue":{"href":"https://api.github.com/repos/mockingbirdnest/Principia/issues/982"},"comments":{"href":"https://api.github.com/repos/mockingbirdnest/Principia/issues/982/comments"},"review_comments":{"href":"https://api.github.com/repos/mockingbirdnest/Principia/pulls/982/comments"},"review_comment":{"href":"https://api.github.com/repos/mockingbirdnest/Principia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mockingbirdnest/Principia/pulls/982/commits"},"statuses":{"href":"https://api.github.com/repos/mockingbirdnest/Principia/statuses/6a572a5a468af2e800c31861fae678dc71ad2a3d"}}}}