{"action":"created","comment":{"url":"https://api.github.com/repos/avTranscoder/avTranscoder/pulls/comments/66032716","id":66032716,"diff_hunk":"@@ -42,6 +42,16 @@ IOutputStream& OutputFile::addVideoStream(const VideoCodec& videoDesc)\n     stream.codec->level = videoDesc.getAVCodecContext().level;\n     stream.codec->field_order = videoDesc.getAVCodecContext().field_order;\n \n+    if (_formatContext.getAVOutputFormat().flags & AVFMT_GLOBALHEADER) {\n+        stream.codec->flags = CODEC_FLAG_GLOBAL_HEADER;","path":"src/AvTranscoder/file/OutputFile.cpp","position":5,"original_position":5,"commit_id":"054678c7f4ee436222ded828245523fae8de11c7","original_commit_id":"054678c7f4ee436222ded828245523fae8de11c7","user":{"login":"cchampet","id":2589095,"avatar_url":"https://avatars.githubusercontent.com/u/2589095?v=3","gravatar_id":"","url":"https://api.github.com/users/cchampet","html_url":"https://github.com/cchampet","followers_url":"https://api.github.com/users/cchampet/followers","following_url":"https://api.github.com/users/cchampet/following{/other_user}","gists_url":"https://api.github.com/users/cchampet/gists{/gist_id}","starred_url":"https://api.github.com/users/cchampet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cchampet/subscriptions","organizations_url":"https://api.github.com/users/cchampet/orgs","repos_url":"https://api.github.com/users/cchampet/repos","events_url":"https://api.github.com/users/cchampet/events{/privacy}","received_events_url":"https://api.github.com/users/cchampet/received_events","type":"User","site_admin":false},"body":"Because the _flags_ attribute could have a value before this assignement, I think it's better to do:\r\n```\r\nstream.codec->flags |= CODEC_FLAG_GLOBAL_HEADER;\r\n```\r\nDon't you think?","created_at":"2016-06-07T08:55:08Z","updated_at":"2016-06-07T08:55:08Z","html_url":"https://github.com/avTranscoder/avTranscoder/pull/251#discussion_r66032716","pull_request_url":"https://api.github.com/repos/avTranscoder/avTranscoder/pulls/251","_links":{"self":{"href":"https://api.github.com/repos/avTranscoder/avTranscoder/pulls/comments/66032716"},"html":{"href":"https://github.com/avTranscoder/avTranscoder/pull/251#discussion_r66032716"},"pull_request":{"href":"https://api.github.com/repos/avTranscoder/avTranscoder/pulls/251"}}},"pull_request":{"url":"https://api.github.com/repos/avTranscoder/avTranscoder/pulls/251","id":72741269,"html_url":"https://github.com/avTranscoder/avTranscoder/pull/251","diff_url":"https://github.com/avTranscoder/avTranscoder/pull/251.diff","patch_url":"https://github.com/avTranscoder/avTranscoder/pull/251.patch","issue_url":"https://api.github.com/repos/avTranscoder/avTranscoder/issues/251","number":251,"state":"open","locked":false,"title":"Patches to make integration of avTranscoder into other software easier","user":{"login":"dimula73","id":454873,"avatar_url":"https://avatars.githubusercontent.com/u/454873?v=3","gravatar_id":"","url":"https://api.github.com/users/dimula73","html_url":"https://github.com/dimula73","followers_url":"https://api.github.com/users/dimula73/followers","following_url":"https://api.github.com/users/dimula73/following{/other_user}","gists_url":"https://api.github.com/users/dimula73/gists{/gist_id}","starred_url":"https://api.github.com/users/dimula73/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimula73/subscriptions","organizations_url":"https://api.github.com/users/dimula73/orgs","repos_url":"https://api.github.com/users/dimula73/repos","events_url":"https://api.github.com/users/dimula73/events{/privacy}","received_events_url":"https://api.github.com/users/dimula73/received_events","type":"User","site_admin":false},"body":"Hi!\r\n\r\nI'm trying to integrate avTranscoder into Krita project. I need it to be able to save the hand-painted animation into various animation formats. My main target formats are mkv, mp4, ogg and gif.\r\n\r\nHere are the two patches I had to do to make integration of avTranscoder easier into other applications. One creates necessary cmake modules. The other one fixes a small bug when working with the .mkv format.\r\n\r\n","created_at":"2016-06-06T16:47:18Z","updated_at":"2016-06-07T08:55:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef3c08b0a6e726e521e38214fc1fc05f90bd8494","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/avTranscoder/avTranscoder/pulls/251/commits","review_comments_url":"https://api.github.com/repos/avTranscoder/avTranscoder/pulls/251/comments","review_comment_url":"https://api.github.com/repos/avTranscoder/avTranscoder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/avTranscoder/avTranscoder/issues/251/comments","statuses_url":"https://api.github.com/repos/avTranscoder/avTranscoder/statuses/054678c7f4ee436222ded828245523fae8de11c7","head":{"label":"dimula73:develop","ref":"develop","sha":"054678c7f4ee436222ded828245523fae8de11c7","user":{"login":"dimula73","id":454873,"avatar_url":"https://avatars.githubusercontent.com/u/454873?v=3","gravatar_id":"","url":"https://api.github.com/users/dimula73","html_url":"https://github.com/dimula73","followers_url":"https://api.github.com/users/dimula73/followers","following_url":"https://api.github.com/users/dimula73/following{/other_user}","gists_url":"https://api.github.com/users/dimula73/gists{/gist_id}","starred_url":"https://api.github.com/users/dimula73/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimula73/subscriptions","organizations_url":"https://api.github.com/users/dimula73/orgs","repos_url":"https://api.github.com/users/dimula73/repos","events_url":"https://api.github.com/users/dimula73/events{/privacy}","received_events_url":"https://api.github.com/users/dimula73/received_events","type":"User","site_admin":false},"repo":{"id":60543548,"name":"avTranscoder","full_name":"dimula73/avTranscoder","owner":{"login":"dimula73","id":454873,"avatar_url":"https://avatars.githubusercontent.com/u/454873?v=3","gravatar_id":"","url":"https://api.github.com/users/dimula73","html_url":"https://github.com/dimula73","followers_url":"https://api.github.com/users/dimula73/followers","following_url":"https://api.github.com/users/dimula73/following{/other_user}","gists_url":"https://api.github.com/users/dimula73/gists{/gist_id}","starred_url":"https://api.github.com/users/dimula73/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimula73/subscriptions","organizations_url":"https://api.github.com/users/dimula73/orgs","repos_url":"https://api.github.com/users/dimula73/repos","events_url":"https://api.github.com/users/dimula73/events{/privacy}","received_events_url":"https://api.github.com/users/dimula73/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dimula73/avTranscoder","description":"C++ API for LibAV / FFMpeg","fork":true,"url":"https://api.github.com/repos/dimula73/avTranscoder","forks_url":"https://api.github.com/repos/dimula73/avTranscoder/forks","keys_url":"https://api.github.com/repos/dimula73/avTranscoder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimula73/avTranscoder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimula73/avTranscoder/teams","hooks_url":"https://api.github.com/repos/dimula73/avTranscoder/hooks","issue_events_url":"https://api.github.com/repos/dimula73/avTranscoder/issues/events{/number}","events_url":"https://api.github.com/repos/dimula73/avTranscoder/events","assignees_url":"https://api.github.com/repos/dimula73/avTranscoder/assignees{/user}","branches_url":"https://api.github.com/repos/dimula73/avTranscoder/branches{/branch}","tags_url":"https://api.github.com/repos/dimula73/avTranscoder/tags","blobs_url":"https://api.github.com/repos/dimula73/avTranscoder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimula73/avTranscoder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimula73/avTranscoder/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimula73/avTranscoder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimula73/avTranscoder/statuses/{sha}","languages_url":"https://api.github.com/repos/dimula73/avTranscoder/languages","stargazers_url":"https://api.github.com/repos/dimula73/avTranscoder/stargazers","contributors_url":"https://api.github.com/repos/dimula73/avTranscoder/contributors","subscribers_url":"https://api.github.com/repos/dimula73/avTranscoder/subscribers","subscription_url":"https://api.github.com/repos/dimula73/avTranscoder/subscription","commits_url":"https://api.github.com/repos/dimula73/avTranscoder/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimula73/avTranscoder/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimula73/avTranscoder/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimula73/avTranscoder/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimula73/avTranscoder/contents/{+path}","compare_url":"https://api.github.com/repos/dimula73/avTranscoder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimula73/avTranscoder/merges","archive_url":"https://api.github.com/repos/dimula73/avTranscoder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimula73/avTranscoder/downloads","issues_url":"https://api.github.com/repos/dimula73/avTranscoder/issues{/number}","pulls_url":"https://api.github.com/repos/dimula73/avTranscoder/pulls{/number}","milestones_url":"https://api.github.com/repos/dimula73/avTranscoder/milestones{/number}","notifications_url":"https://api.github.com/repos/dimula73/avTranscoder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimula73/avTranscoder/labels{/name}","releases_url":"https://api.github.com/repos/dimula73/avTranscoder/releases{/id}","deployments_url":"https://api.github.com/repos/dimula73/avTranscoder/deployments","created_at":"2016-06-06T16:32:23Z","updated_at":"2016-06-06T16:32:25Z","pushed_at":"2016-06-06T16:38:01Z","git_url":"git://github.com/dimula73/avTranscoder.git","ssh_url":"git@github.com:dimula73/avTranscoder.git","clone_url":"https://github.com/dimula73/avTranscoder.git","svn_url":"https://github.com/dimula73/avTranscoder","homepage":null,"size":2778,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"avTranscoder:develop","ref":"develop","sha":"bd420a5bba7ed945d5d73f93358e109f16c9ba64","user":{"login":"avTranscoder","id":8028099,"avatar_url":"https://avatars.githubusercontent.com/u/8028099?v=3","gravatar_id":"","url":"https://api.github.com/users/avTranscoder","html_url":"https://github.com/avTranscoder","followers_url":"https://api.github.com/users/avTranscoder/followers","following_url":"https://api.github.com/users/avTranscoder/following{/other_user}","gists_url":"https://api.github.com/users/avTranscoder/gists{/gist_id}","starred_url":"https://api.github.com/users/avTranscoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avTranscoder/subscriptions","organizations_url":"https://api.github.com/users/avTranscoder/orgs","repos_url":"https://api.github.com/users/avTranscoder/repos","events_url":"https://api.github.com/users/avTranscoder/events{/privacy}","received_events_url":"https://api.github.com/users/avTranscoder/received_events","type":"Organization","site_admin":false},"repo":{"id":16405415,"name":"avTranscoder","full_name":"avTranscoder/avTranscoder","owner":{"login":"avTranscoder","id":8028099,"avatar_url":"https://avatars.githubusercontent.com/u/8028099?v=3","gravatar_id":"","url":"https://api.github.com/users/avTranscoder","html_url":"https://github.com/avTranscoder","followers_url":"https://api.github.com/users/avTranscoder/followers","following_url":"https://api.github.com/users/avTranscoder/following{/other_user}","gists_url":"https://api.github.com/users/avTranscoder/gists{/gist_id}","starred_url":"https://api.github.com/users/avTranscoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avTranscoder/subscriptions","organizations_url":"https://api.github.com/users/avTranscoder/orgs","repos_url":"https://api.github.com/users/avTranscoder/repos","events_url":"https://api.github.com/users/avTranscoder/events{/privacy}","received_events_url":"https://api.github.com/users/avTranscoder/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/avTranscoder/avTranscoder","description":"C++ API for LibAV / FFMpeg","fork":false,"url":"https://api.github.com/repos/avTranscoder/avTranscoder","forks_url":"https://api.github.com/repos/avTranscoder/avTranscoder/forks","keys_url":"https://api.github.com/repos/avTranscoder/avTranscoder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/avTranscoder/avTranscoder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/avTranscoder/avTranscoder/teams","hooks_url":"https://api.github.com/repos/avTranscoder/avTranscoder/hooks","issue_events_url":"https://api.github.com/repos/avTranscoder/avTranscoder/issues/events{/number}","events_url":"https://api.github.com/repos/avTranscoder/avTranscoder/events","assignees_url":"https://api.github.com/repos/avTranscoder/avTranscoder/assignees{/user}","branches_url":"https://api.github.com/repos/avTranscoder/avTranscoder/branches{/branch}","tags_url":"https://api.github.com/repos/avTranscoder/avTranscoder/tags","blobs_url":"https://api.github.com/repos/avTranscoder/avTranscoder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/avTranscoder/avTranscoder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/avTranscoder/avTranscoder/git/refs{/sha}","trees_url":"https://api.github.com/repos/avTranscoder/avTranscoder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/avTranscoder/avTranscoder/statuses/{sha}","languages_url":"https://api.github.com/repos/avTranscoder/avTranscoder/languages","stargazers_url":"https://api.github.com/repos/avTranscoder/avTranscoder/stargazers","contributors_url":"https://api.github.com/repos/avTranscoder/avTranscoder/contributors","subscribers_url":"https://api.github.com/repos/avTranscoder/avTranscoder/subscribers","subscription_url":"https://api.github.com/repos/avTranscoder/avTranscoder/subscription","commits_url":"https://api.github.com/repos/avTranscoder/avTranscoder/commits{/sha}","git_commits_url":"https://api.github.com/repos/avTranscoder/avTranscoder/git/commits{/sha}","comments_url":"https://api.github.com/repos/avTranscoder/avTranscoder/comments{/number}","issue_comment_url":"https://api.github.com/repos/avTranscoder/avTranscoder/issues/comments{/number}","contents_url":"https://api.github.com/repos/avTranscoder/avTranscoder/contents/{+path}","compare_url":"https://api.github.com/repos/avTranscoder/avTranscoder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/avTranscoder/avTranscoder/merges","archive_url":"https://api.github.com/repos/avTranscoder/avTranscoder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/avTranscoder/avTranscoder/downloads","issues_url":"https://api.github.com/repos/avTranscoder/avTranscoder/issues{/number}","pulls_url":"https://api.github.com/repos/avTranscoder/avTranscoder/pulls{/number}","milestones_url":"https://api.github.com/repos/avTranscoder/avTranscoder/milestones{/number}","notifications_url":"https://api.github.com/repos/avTranscoder/avTranscoder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/avTranscoder/avTranscoder/labels{/name}","releases_url":"https://api.github.com/repos/avTranscoder/avTranscoder/releases{/id}","deployments_url":"https://api.github.com/repos/avTranscoder/avTranscoder/deployments","created_at":"2014-01-31T10:41:40Z","updated_at":"2016-03-25T10:47:59Z","pushed_at":"2016-06-06T16:47:18Z","git_url":"git://github.com/avTranscoder/avTranscoder.git","ssh_url":"git@github.com:avTranscoder/avTranscoder.git","clone_url":"https://github.com/avTranscoder/avTranscoder.git","svn_url":"https://github.com/avTranscoder/avTranscoder","homepage":null,"size":2942,"stargazers_count":16,"watchers_count":16,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":27,"forks":16,"open_issues":27,"watchers":16,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/avTranscoder/avTranscoder/pulls/251"},"html":{"href":"https://github.com/avTranscoder/avTranscoder/pull/251"},"issue":{"href":"https://api.github.com/repos/avTranscoder/avTranscoder/issues/251"},"comments":{"href":"https://api.github.com/repos/avTranscoder/avTranscoder/issues/251/comments"},"review_comments":{"href":"https://api.github.com/repos/avTranscoder/avTranscoder/pulls/251/comments"},"review_comment":{"href":"https://api.github.com/repos/avTranscoder/avTranscoder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/avTranscoder/avTranscoder/pulls/251/commits"},"statuses":{"href":"https://api.github.com/repos/avTranscoder/avTranscoder/statuses/054678c7f4ee436222ded828245523fae8de11c7"}}}}
{"actor":{"display_login":"cchampet"}}