{"action":"created","issue":{"url":"https://api.github.com/repos/dart-lang/dev_compiler/issues/512","repository_url":"https://api.github.com/repos/dart-lang/dev_compiler","labels_url":"https://api.github.com/repos/dart-lang/dev_compiler/issues/512/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/dev_compiler/issues/512/comments","events_url":"https://api.github.com/repos/dart-lang/dev_compiler/issues/512/events","html_url":"https://github.com/dart-lang/dev_compiler/issues/512","id":149587651,"number":512,"title":"js_ast doesn't appear to rename temporaries with same name at the top level","user":{"login":"vsmenon","id":2119553,"avatar_url":"https://avatars.githubusercontent.com/u/2119553?v=3","gravatar_id":"","url":"https://api.github.com/users/vsmenon","html_url":"https://github.com/vsmenon","followers_url":"https://api.github.com/users/vsmenon/followers","following_url":"https://api.github.com/users/vsmenon/following{/other_user}","gists_url":"https://api.github.com/users/vsmenon/gists{/gist_id}","starred_url":"https://api.github.com/users/vsmenon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsmenon/subscriptions","organizations_url":"https://api.github.com/users/vsmenon/orgs","repos_url":"https://api.github.com/users/vsmenon/repos","events_url":"https://api.github.com/users/vsmenon/events{/privacy}","received_events_url":"https://api.github.com/users/vsmenon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-19T21:19:48Z","updated_at":"2016-04-19T21:30:02Z","closed_at":null,"body":"See this CL: \r\n\r\nhttps://codereview.chromium.org/1893293003/\r\n\r\nand new comment here in module_builder.dart.  I seem to have to add an extra js block to get correct disambiguation."},"comment":{"url":"https://api.github.com/repos/dart-lang/dev_compiler/issues/comments/212137738","html_url":"https://github.com/dart-lang/dev_compiler/issues/512#issuecomment-212137738","issue_url":"https://api.github.com/repos/dart-lang/dev_compiler/issues/512","id":212137738,"user":{"login":"vsmenon","id":2119553,"avatar_url":"https://avatars.githubusercontent.com/u/2119553?v=3","gravatar_id":"","url":"https://api.github.com/users/vsmenon","html_url":"https://github.com/vsmenon","followers_url":"https://api.github.com/users/vsmenon/followers","following_url":"https://api.github.com/users/vsmenon/following{/other_user}","gists_url":"https://api.github.com/users/vsmenon/gists{/gist_id}","starred_url":"https://api.github.com/users/vsmenon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsmenon/subscriptions","organizations_url":"https://api.github.com/users/vsmenon/orgs","repos_url":"https://api.github.com/users/vsmenon/repos","events_url":"https://api.github.com/users/vsmenon/events{/privacy}","received_events_url":"https://api.github.com/users/vsmenon/received_events","type":"User","site_admin":false},"created_at":"2016-04-19T21:30:02Z","updated_at":"2016-04-19T21:30:02Z","body":"Here's the relevant comment:\r\n\r\nOn 2016/04/18 20:52:18, John Messerly wrote:\r\n> On 2016/04/18 13:38:25, vsm wrote:\r\n> > Not entirely sure why I seem to need this. Without it, it seems\r\njs_ast wasn't\r\n> > renaming colliding identifiers. I'd get redundant declarations in\r\nthe SDK:\r\n> > \r\n> > const _add = Symbol('_add');\r\n> > ...\r\n> > const _add = Symbol('_add');\r\n> > \r\n> > By nesting the whole thing, I'd see:\r\n> > \r\n> > const _add = Symbol('_add');\r\n> > ...\r\n> > const _add$ = Symbol('_add');\r\n> > \r\n> > Is js_ast not renaming at the top-level?\r\n> \r\n> Yeah seems like it's skipping the top-level. That's probably an easy\r\nfix though.\r\n> \r\n> Do you mind taking a look? IMO, it'd be good to understand what's\r\ngoing on,\r\n> rather than work around it.\r\n> \r\n> Could be a TODO as well. But it'd be nice to keep the technical debt\r\nlow (I'm\r\n> still recovering from the last big cleanup ;)... not to mention our\r\nruntime/SDK\r\n> debt.)"}}