{"action":"created","comment":{"url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/pulls/comments/56755052","id":56755052,"diff_hunk":"@@ -9,21 +13,32 @@\n  * @author Joel Bradley\n  */\n public class RollNumberCommand implements ICommand {\n+    private int gameId;\n+    private int value;\n+    private int playerIndex;\n+    private IFacade facade;\n \n     /**\n      * Constructor\n      */\n-    public RollNumberCommand() {\n-\n+    public RollNumberCommand(IFacade facade, RollNumberDTO roll) {\n+        this.facade = facade;\n+        this.gameId = roll.getGameId();\n+        this.value = roll.getValue();\n+        this.playerIndex = roll.getPlayerIndex();\n     }\n \n     /**\n      * Communicates with the ServerFacade to carry out the Roll Number command\n-     * @return IDTO\n+     * @return JsonObject\n      */\n     @Override\n-    public IDTO execute() {\n-        return null;\n+    public IDTO execute() throws CommandExecutionFailedException {\n+        try {\n+            return facade.rollNumber(gameId, playerIndex, value);","path":"java/src/server/commands/moves/RollNumberCommand.java","position":43,"original_position":43,"commit_id":"d54ee1d321319ef625a2fd786d536b36b0480135","original_commit_id":"2dfd272d3d321568f6ebcadac902e1facd6fba73","user":{"login":"emeraldarcher","id":5711889,"avatar_url":"https://avatars.githubusercontent.com/u/5711889?v=3","gravatar_id":"","url":"https://api.github.com/users/emeraldarcher","html_url":"https://github.com/emeraldarcher","followers_url":"https://api.github.com/users/emeraldarcher/followers","following_url":"https://api.github.com/users/emeraldarcher/following{/other_user}","gists_url":"https://api.github.com/users/emeraldarcher/gists{/gist_id}","starred_url":"https://api.github.com/users/emeraldarcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emeraldarcher/subscriptions","organizations_url":"https://api.github.com/users/emeraldarcher/orgs","repos_url":"https://api.github.com/users/emeraldarcher/repos","events_url":"https://api.github.com/users/emeraldarcher/events{/privacy}","received_events_url":"https://api.github.com/users/emeraldarcher/received_events","type":"User","site_admin":false},"body":"I'm confused, that is in essence what I'm doing...I think. The command gets passed in the gameId and the DTO. I just extract what I need from the DTO in the constructor instead of having to call \"dto.getPlayerIndex()\" within my rollNumber function call. It looks cleaner IMO.\r\n","created_at":"2016-03-19T21:00:40Z","updated_at":"2016-03-19T21:00:40Z","html_url":"https://github.com/derekargueta/Settlers-of-Catan/pull/118#discussion_r56755052","pull_request_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/pulls/118","_links":{"self":{"href":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/pulls/comments/56755052"},"html":{"href":"https://github.com/derekargueta/Settlers-of-Catan/pull/118#discussion_r56755052"},"pull_request":{"href":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/pulls/118"}}},"pull_request":{"url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/pulls/118","id":63474424,"html_url":"https://github.com/derekargueta/Settlers-of-Catan/pull/118","diff_url":"https://github.com/derekargueta/Settlers-of-Catan/pull/118.diff","patch_url":"https://github.com/derekargueta/Settlers-of-Catan/pull/118.patch","issue_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/issues/118","number":118,"state":"open","locked":false,"title":"RollCommand Code","user":{"login":"emeraldarcher","id":5711889,"avatar_url":"https://avatars.githubusercontent.com/u/5711889?v=3","gravatar_id":"","url":"https://api.github.com/users/emeraldarcher","html_url":"https://github.com/emeraldarcher","followers_url":"https://api.github.com/users/emeraldarcher/followers","following_url":"https://api.github.com/users/emeraldarcher/following{/other_user}","gists_url":"https://api.github.com/users/emeraldarcher/gists{/gist_id}","starred_url":"https://api.github.com/users/emeraldarcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emeraldarcher/subscriptions","organizations_url":"https://api.github.com/users/emeraldarcher/orgs","repos_url":"https://api.github.com/users/emeraldarcher/repos","events_url":"https://api.github.com/users/emeraldarcher/events{/privacy}","received_events_url":"https://api.github.com/users/emeraldarcher/received_events","type":"User","site_admin":false},"body":"Implemented RollCommand","created_at":"2016-03-19T18:09:40Z","updated_at":"2016-03-19T21:00:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b037e78a33c7e1c41f91e8cd365f8e8bbda6fad7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/pulls/118/commits","review_comments_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/pulls/118/comments","review_comment_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/issues/118/comments","statuses_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/statuses/d54ee1d321319ef625a2fd786d536b36b0480135","head":{"label":"derekargueta:Server-RollCommand","ref":"Server-RollCommand","sha":"d54ee1d321319ef625a2fd786d536b36b0480135","user":{"login":"derekargueta","id":5253821,"avatar_url":"https://avatars.githubusercontent.com/u/5253821?v=3","gravatar_id":"","url":"https://api.github.com/users/derekargueta","html_url":"https://github.com/derekargueta","followers_url":"https://api.github.com/users/derekargueta/followers","following_url":"https://api.github.com/users/derekargueta/following{/other_user}","gists_url":"https://api.github.com/users/derekargueta/gists{/gist_id}","starred_url":"https://api.github.com/users/derekargueta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekargueta/subscriptions","organizations_url":"https://api.github.com/users/derekargueta/orgs","repos_url":"https://api.github.com/users/derekargueta/repos","events_url":"https://api.github.com/users/derekargueta/events{/privacy}","received_events_url":"https://api.github.com/users/derekargueta/received_events","type":"User","site_admin":false},"repo":{"id":49609884,"name":"Settlers-of-Catan","full_name":"derekargueta/Settlers-of-Catan","owner":{"login":"derekargueta","id":5253821,"avatar_url":"https://avatars.githubusercontent.com/u/5253821?v=3","gravatar_id":"","url":"https://api.github.com/users/derekargueta","html_url":"https://github.com/derekargueta","followers_url":"https://api.github.com/users/derekargueta/followers","following_url":"https://api.github.com/users/derekargueta/following{/other_user}","gists_url":"https://api.github.com/users/derekargueta/gists{/gist_id}","starred_url":"https://api.github.com/users/derekargueta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekargueta/subscriptions","organizations_url":"https://api.github.com/users/derekargueta/orgs","repos_url":"https://api.github.com/users/derekargueta/repos","events_url":"https://api.github.com/users/derekargueta/events{/privacy}","received_events_url":"https://api.github.com/users/derekargueta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/derekargueta/Settlers-of-Catan","description":"Class project for BYU CS 340 - Software Design and Testing","fork":false,"url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan","forks_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/forks","keys_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/teams","hooks_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/hooks","issue_events_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/issues/events{/number}","events_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/events","assignees_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/assignees{/user}","branches_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/branches{/branch}","tags_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/tags","blobs_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/git/refs{/sha}","trees_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/statuses/{sha}","languages_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/languages","stargazers_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/stargazers","contributors_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/contributors","subscribers_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/subscribers","subscription_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/subscription","commits_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/commits{/sha}","git_commits_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/git/commits{/sha}","comments_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/comments{/number}","issue_comment_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/issues/comments{/number}","contents_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/contents/{+path}","compare_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/merges","archive_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/downloads","issues_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/issues{/number}","pulls_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/pulls{/number}","milestones_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/milestones{/number}","notifications_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/labels{/name}","releases_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/releases{/id}","deployments_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/deployments","created_at":"2016-01-13T23:49:17Z","updated_at":"2016-03-05T05:56:53Z","pushed_at":"2016-03-19T20:55:44Z","git_url":"git://github.com/derekargueta/Settlers-of-Catan.git","ssh_url":"git@github.com:derekargueta/Settlers-of-Catan.git","clone_url":"https://github.com/derekargueta/Settlers-of-Catan.git","svn_url":"https://github.com/derekargueta/Settlers-of-Catan","homepage":"","size":78527,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"derekargueta:master","ref":"master","sha":"1a7ceaeed55f2d25b526d9f808e979b5247c5504","user":{"login":"derekargueta","id":5253821,"avatar_url":"https://avatars.githubusercontent.com/u/5253821?v=3","gravatar_id":"","url":"https://api.github.com/users/derekargueta","html_url":"https://github.com/derekargueta","followers_url":"https://api.github.com/users/derekargueta/followers","following_url":"https://api.github.com/users/derekargueta/following{/other_user}","gists_url":"https://api.github.com/users/derekargueta/gists{/gist_id}","starred_url":"https://api.github.com/users/derekargueta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekargueta/subscriptions","organizations_url":"https://api.github.com/users/derekargueta/orgs","repos_url":"https://api.github.com/users/derekargueta/repos","events_url":"https://api.github.com/users/derekargueta/events{/privacy}","received_events_url":"https://api.github.com/users/derekargueta/received_events","type":"User","site_admin":false},"repo":{"id":49609884,"name":"Settlers-of-Catan","full_name":"derekargueta/Settlers-of-Catan","owner":{"login":"derekargueta","id":5253821,"avatar_url":"https://avatars.githubusercontent.com/u/5253821?v=3","gravatar_id":"","url":"https://api.github.com/users/derekargueta","html_url":"https://github.com/derekargueta","followers_url":"https://api.github.com/users/derekargueta/followers","following_url":"https://api.github.com/users/derekargueta/following{/other_user}","gists_url":"https://api.github.com/users/derekargueta/gists{/gist_id}","starred_url":"https://api.github.com/users/derekargueta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekargueta/subscriptions","organizations_url":"https://api.github.com/users/derekargueta/orgs","repos_url":"https://api.github.com/users/derekargueta/repos","events_url":"https://api.github.com/users/derekargueta/events{/privacy}","received_events_url":"https://api.github.com/users/derekargueta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/derekargueta/Settlers-of-Catan","description":"Class project for BYU CS 340 - Software Design and Testing","fork":false,"url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan","forks_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/forks","keys_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/teams","hooks_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/hooks","issue_events_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/issues/events{/number}","events_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/events","assignees_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/assignees{/user}","branches_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/branches{/branch}","tags_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/tags","blobs_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/git/refs{/sha}","trees_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/statuses/{sha}","languages_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/languages","stargazers_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/stargazers","contributors_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/contributors","subscribers_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/subscribers","subscription_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/subscription","commits_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/commits{/sha}","git_commits_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/git/commits{/sha}","comments_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/comments{/number}","issue_comment_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/issues/comments{/number}","contents_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/contents/{+path}","compare_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/merges","archive_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/downloads","issues_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/issues{/number}","pulls_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/pulls{/number}","milestones_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/milestones{/number}","notifications_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/labels{/name}","releases_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/releases{/id}","deployments_url":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/deployments","created_at":"2016-01-13T23:49:17Z","updated_at":"2016-03-05T05:56:53Z","pushed_at":"2016-03-19T20:55:44Z","git_url":"git://github.com/derekargueta/Settlers-of-Catan.git","ssh_url":"git@github.com:derekargueta/Settlers-of-Catan.git","clone_url":"https://github.com/derekargueta/Settlers-of-Catan.git","svn_url":"https://github.com/derekargueta/Settlers-of-Catan","homepage":"","size":78527,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/pulls/118"},"html":{"href":"https://github.com/derekargueta/Settlers-of-Catan/pull/118"},"issue":{"href":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/issues/118"},"comments":{"href":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/issues/118/comments"},"review_comments":{"href":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/pulls/118/comments"},"review_comment":{"href":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/pulls/118/commits"},"statuses":{"href":"https://api.github.com/repos/derekargueta/Settlers-of-Catan/statuses/d54ee1d321319ef625a2fd786d536b36b0480135"}}}}