{"action":"created","comment":{"url":"https://api.github.com/repos/jdbi/jdbi/pulls/comments/70197980","id":70197980,"diff_hunk":"@@ -91,46 +91,69 @@\n         <basepom.test.timeout>240</basepom.test.timeout>\n     </properties>\n \n+    <profiles>\n+        <profile>\n+            <id>toolchains</id>\n+            <build>\n+                <pluginManagement>\n+                    <plugins>\n+                        <plugin>\n+                            <groupId>org.apache.maven.plugins</groupId>\n+                            <artifactId>maven-compiler-plugin</artifactId>\n+                            <configuration>\n+                                <compilerArguments>\n+                                    <parameters/>\n+                                </compilerArguments>\n+                            </configuration>\n+                        </plugin>","path":"pom.xml","position":18,"original_position":18,"commit_id":"372bea33f09b6b32ef0e47070d9f241bf901c204","original_commit_id":"372bea33f09b6b32ef0e47070d9f241bf901c204","user":{"login":"qualidafial","id":38629,"avatar_url":"https://avatars.githubusercontent.com/u/38629?v=3","gravatar_id":"","url":"https://api.github.com/users/qualidafial","html_url":"https://github.com/qualidafial","followers_url":"https://api.github.com/users/qualidafial/followers","following_url":"https://api.github.com/users/qualidafial/following{/other_user}","gists_url":"https://api.github.com/users/qualidafial/gists{/gist_id}","starred_url":"https://api.github.com/users/qualidafial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qualidafial/subscriptions","organizations_url":"https://api.github.com/users/qualidafial/orgs","repos_url":"https://api.github.com/users/qualidafial/repos","events_url":"https://api.github.com/users/qualidafial/events{/privacy}","received_events_url":"https://api.github.com/users/qualidafial/received_events","type":"User","site_admin":false},"body":"Is this plugin a leftover from trial and error?","created_at":"2016-07-11T03:24:16Z","updated_at":"2016-07-11T03:24:16Z","html_url":"https://github.com/jdbi/jdbi/pull/392#discussion_r70197980","pull_request_url":"https://api.github.com/repos/jdbi/jdbi/pulls/392","_links":{"self":{"href":"https://api.github.com/repos/jdbi/jdbi/pulls/comments/70197980"},"html":{"href":"https://github.com/jdbi/jdbi/pull/392#discussion_r70197980"},"pull_request":{"href":"https://api.github.com/repos/jdbi/jdbi/pulls/392"}}},"pull_request":{"url":"https://api.github.com/repos/jdbi/jdbi/pulls/392","id":72462076,"html_url":"https://github.com/jdbi/jdbi/pull/392","diff_url":"https://github.com/jdbi/jdbi/pull/392.diff","patch_url":"https://github.com/jdbi/jdbi/pull/392.patch","issue_url":"https://api.github.com/repos/jdbi/jdbi/issues/392","number":392,"state":"open","locked":false,"title":"Remove Maven Toolchains","user":{"login":"arteam","id":1717632,"avatar_url":"https://avatars.githubusercontent.com/u/1717632?v=3","gravatar_id":"","url":"https://api.github.com/users/arteam","html_url":"https://github.com/arteam","followers_url":"https://api.github.com/users/arteam/followers","following_url":"https://api.github.com/users/arteam/following{/other_user}","gists_url":"https://api.github.com/users/arteam/gists{/gist_id}","starred_url":"https://api.github.com/users/arteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arteam/subscriptions","organizations_url":"https://api.github.com/users/arteam/orgs","repos_url":"https://api.github.com/users/arteam/repos","events_url":"https://api.github.com/users/arteam/events{/privacy}","received_events_url":"https://api.github.com/users/arteam/received_events","type":"User","site_admin":false},"body":"Toolchains are useful when we compile against different JDKs or want to use a\r\nspecific old JDK. Since we target JDK8 in JDBI3, there is no big benefit in\r\nusing toolchains. In most development installations JDK8 is default and usually\r\nalready set in the PATH environment variable, so Maven can find it without\r\nspecific assistance. We only need to set-up source and target for the Java\r\ncompiler.\r\n\r\nAlso, avoiding using toolchains simplifies the process of contributing to JDBI,\r\nbecause developers don't need to add specific steps to configure the development\r\nenvironment and can build the project with `mvn clean install`.","created_at":"2016-06-03T06:59:31Z","updated_at":"2016-07-11T03:24:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9956e493a13e2dc4200dc0696746b38e4319e06d","assignee":{"login":"stevenschlansker","id":129097,"avatar_url":"https://avatars.githubusercontent.com/u/129097?v=3","gravatar_id":"","url":"https://api.github.com/users/stevenschlansker","html_url":"https://github.com/stevenschlansker","followers_url":"https://api.github.com/users/stevenschlansker/followers","following_url":"https://api.github.com/users/stevenschlansker/following{/other_user}","gists_url":"https://api.github.com/users/stevenschlansker/gists{/gist_id}","starred_url":"https://api.github.com/users/stevenschlansker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevenschlansker/subscriptions","organizations_url":"https://api.github.com/users/stevenschlansker/orgs","repos_url":"https://api.github.com/users/stevenschlansker/repos","events_url":"https://api.github.com/users/stevenschlansker/events{/privacy}","received_events_url":"https://api.github.com/users/stevenschlansker/received_events","type":"User","site_admin":false},"assignees":[{"login":"stevenschlansker","id":129097,"avatar_url":"https://avatars.githubusercontent.com/u/129097?v=3","gravatar_id":"","url":"https://api.github.com/users/stevenschlansker","html_url":"https://github.com/stevenschlansker","followers_url":"https://api.github.com/users/stevenschlansker/followers","following_url":"https://api.github.com/users/stevenschlansker/following{/other_user}","gists_url":"https://api.github.com/users/stevenschlansker/gists{/gist_id}","starred_url":"https://api.github.com/users/stevenschlansker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevenschlansker/subscriptions","organizations_url":"https://api.github.com/users/stevenschlansker/orgs","repos_url":"https://api.github.com/users/stevenschlansker/repos","events_url":"https://api.github.com/users/stevenschlansker/events{/privacy}","received_events_url":"https://api.github.com/users/stevenschlansker/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/jdbi/jdbi/milestones/3","html_url":"https://github.com/jdbi/jdbi/milestones/JDBI%203%20Beta%20blocker","labels_url":"https://api.github.com/repos/jdbi/jdbi/milestones/3/labels","id":1788535,"number":3,"title":"JDBI 3 Beta blocker","description":"","creator":{"login":"stevenschlansker","id":129097,"avatar_url":"https://avatars.githubusercontent.com/u/129097?v=3","gravatar_id":"","url":"https://api.github.com/users/stevenschlansker","html_url":"https://github.com/stevenschlansker","followers_url":"https://api.github.com/users/stevenschlansker/followers","following_url":"https://api.github.com/users/stevenschlansker/following{/other_user}","gists_url":"https://api.github.com/users/stevenschlansker/gists{/gist_id}","starred_url":"https://api.github.com/users/stevenschlansker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevenschlansker/subscriptions","organizations_url":"https://api.github.com/users/stevenschlansker/orgs","repos_url":"https://api.github.com/users/stevenschlansker/repos","events_url":"https://api.github.com/users/stevenschlansker/events{/privacy}","received_events_url":"https://api.github.com/users/stevenschlansker/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":31,"state":"open","created_at":"2016-05-25T21:46:37Z","updated_at":"2016-07-09T02:09:38Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/jdbi/jdbi/pulls/392/commits","review_comments_url":"https://api.github.com/repos/jdbi/jdbi/pulls/392/comments","review_comment_url":"https://api.github.com/repos/jdbi/jdbi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jdbi/jdbi/issues/392/comments","statuses_url":"https://api.github.com/repos/jdbi/jdbi/statuses/372bea33f09b6b32ef0e47070d9f241bf901c204","head":{"label":"arteam:no_toolchains","ref":"no_toolchains","sha":"372bea33f09b6b32ef0e47070d9f241bf901c204","user":{"login":"arteam","id":1717632,"avatar_url":"https://avatars.githubusercontent.com/u/1717632?v=3","gravatar_id":"","url":"https://api.github.com/users/arteam","html_url":"https://github.com/arteam","followers_url":"https://api.github.com/users/arteam/followers","following_url":"https://api.github.com/users/arteam/following{/other_user}","gists_url":"https://api.github.com/users/arteam/gists{/gist_id}","starred_url":"https://api.github.com/users/arteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arteam/subscriptions","organizations_url":"https://api.github.com/users/arteam/orgs","repos_url":"https://api.github.com/users/arteam/repos","events_url":"https://api.github.com/users/arteam/events{/privacy}","received_events_url":"https://api.github.com/users/arteam/received_events","type":"User","site_admin":false},"repo":{"id":19196987,"name":"jdbi","full_name":"arteam/jdbi","owner":{"login":"arteam","id":1717632,"avatar_url":"https://avatars.githubusercontent.com/u/1717632?v=3","gravatar_id":"","url":"https://api.github.com/users/arteam","html_url":"https://github.com/arteam","followers_url":"https://api.github.com/users/arteam/followers","following_url":"https://api.github.com/users/arteam/following{/other_user}","gists_url":"https://api.github.com/users/arteam/gists{/gist_id}","starred_url":"https://api.github.com/users/arteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arteam/subscriptions","organizations_url":"https://api.github.com/users/arteam/orgs","repos_url":"https://api.github.com/users/arteam/repos","events_url":"https://api.github.com/users/arteam/events{/privacy}","received_events_url":"https://api.github.com/users/arteam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arteam/jdbi","description":"jDBI is designed to provide convenient tabular data access in Java(tm). It uses the Java collections framework for query results, provides a convenient means of externalizing sql statements, and provides named parameter support for any database being used.","fork":true,"url":"https://api.github.com/repos/arteam/jdbi","forks_url":"https://api.github.com/repos/arteam/jdbi/forks","keys_url":"https://api.github.com/repos/arteam/jdbi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arteam/jdbi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arteam/jdbi/teams","hooks_url":"https://api.github.com/repos/arteam/jdbi/hooks","issue_events_url":"https://api.github.com/repos/arteam/jdbi/issues/events{/number}","events_url":"https://api.github.com/repos/arteam/jdbi/events","assignees_url":"https://api.github.com/repos/arteam/jdbi/assignees{/user}","branches_url":"https://api.github.com/repos/arteam/jdbi/branches{/branch}","tags_url":"https://api.github.com/repos/arteam/jdbi/tags","blobs_url":"https://api.github.com/repos/arteam/jdbi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arteam/jdbi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arteam/jdbi/git/refs{/sha}","trees_url":"https://api.github.com/repos/arteam/jdbi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arteam/jdbi/statuses/{sha}","languages_url":"https://api.github.com/repos/arteam/jdbi/languages","stargazers_url":"https://api.github.com/repos/arteam/jdbi/stargazers","contributors_url":"https://api.github.com/repos/arteam/jdbi/contributors","subscribers_url":"https://api.github.com/repos/arteam/jdbi/subscribers","subscription_url":"https://api.github.com/repos/arteam/jdbi/subscription","commits_url":"https://api.github.com/repos/arteam/jdbi/commits{/sha}","git_commits_url":"https://api.github.com/repos/arteam/jdbi/git/commits{/sha}","comments_url":"https://api.github.com/repos/arteam/jdbi/comments{/number}","issue_comment_url":"https://api.github.com/repos/arteam/jdbi/issues/comments{/number}","contents_url":"https://api.github.com/repos/arteam/jdbi/contents/{+path}","compare_url":"https://api.github.com/repos/arteam/jdbi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arteam/jdbi/merges","archive_url":"https://api.github.com/repos/arteam/jdbi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arteam/jdbi/downloads","issues_url":"https://api.github.com/repos/arteam/jdbi/issues{/number}","pulls_url":"https://api.github.com/repos/arteam/jdbi/pulls{/number}","milestones_url":"https://api.github.com/repos/arteam/jdbi/milestones{/number}","notifications_url":"https://api.github.com/repos/arteam/jdbi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arteam/jdbi/labels{/name}","releases_url":"https://api.github.com/repos/arteam/jdbi/releases{/id}","deployments_url":"https://api.github.com/repos/arteam/jdbi/deployments","created_at":"2014-04-27T05:55:15Z","updated_at":"2016-06-03T06:56:50Z","pushed_at":"2016-07-08T07:54:50Z","git_url":"git://github.com/arteam/jdbi.git","ssh_url":"git@github.com:arteam/jdbi.git","clone_url":"https://github.com/arteam/jdbi.git","svn_url":"https://github.com/arteam/jdbi","homepage":"http://jdbi.org/","size":13998,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jdbi:jdbi3","ref":"jdbi3","sha":"89707a66dd3ba9e3dc370e491f6db8d68b945fba","user":{"login":"jdbi","id":9668860,"avatar_url":"https://avatars.githubusercontent.com/u/9668860?v=3","gravatar_id":"","url":"https://api.github.com/users/jdbi","html_url":"https://github.com/jdbi","followers_url":"https://api.github.com/users/jdbi/followers","following_url":"https://api.github.com/users/jdbi/following{/other_user}","gists_url":"https://api.github.com/users/jdbi/gists{/gist_id}","starred_url":"https://api.github.com/users/jdbi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdbi/subscriptions","organizations_url":"https://api.github.com/users/jdbi/orgs","repos_url":"https://api.github.com/users/jdbi/repos","events_url":"https://api.github.com/users/jdbi/events{/privacy}","received_events_url":"https://api.github.com/users/jdbi/received_events","type":"Organization","site_admin":false},"repo":{"id":229738,"name":"jdbi","full_name":"jdbi/jdbi","owner":{"login":"jdbi","id":9668860,"avatar_url":"https://avatars.githubusercontent.com/u/9668860?v=3","gravatar_id":"","url":"https://api.github.com/users/jdbi","html_url":"https://github.com/jdbi","followers_url":"https://api.github.com/users/jdbi/followers","following_url":"https://api.github.com/users/jdbi/following{/other_user}","gists_url":"https://api.github.com/users/jdbi/gists{/gist_id}","starred_url":"https://api.github.com/users/jdbi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdbi/subscriptions","organizations_url":"https://api.github.com/users/jdbi/orgs","repos_url":"https://api.github.com/users/jdbi/repos","events_url":"https://api.github.com/users/jdbi/events{/privacy}","received_events_url":"https://api.github.com/users/jdbi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jdbi/jdbi","description":"jDBI is designed to provide convenient tabular data access in Java(tm). It uses the Java collections framework for query results, provides a convenient means of externalizing sql statements, and provides named parameter support for any database being used.","fork":false,"url":"https://api.github.com/repos/jdbi/jdbi","forks_url":"https://api.github.com/repos/jdbi/jdbi/forks","keys_url":"https://api.github.com/repos/jdbi/jdbi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdbi/jdbi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdbi/jdbi/teams","hooks_url":"https://api.github.com/repos/jdbi/jdbi/hooks","issue_events_url":"https://api.github.com/repos/jdbi/jdbi/issues/events{/number}","events_url":"https://api.github.com/repos/jdbi/jdbi/events","assignees_url":"https://api.github.com/repos/jdbi/jdbi/assignees{/user}","branches_url":"https://api.github.com/repos/jdbi/jdbi/branches{/branch}","tags_url":"https://api.github.com/repos/jdbi/jdbi/tags","blobs_url":"https://api.github.com/repos/jdbi/jdbi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdbi/jdbi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdbi/jdbi/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdbi/jdbi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdbi/jdbi/statuses/{sha}","languages_url":"https://api.github.com/repos/jdbi/jdbi/languages","stargazers_url":"https://api.github.com/repos/jdbi/jdbi/stargazers","contributors_url":"https://api.github.com/repos/jdbi/jdbi/contributors","subscribers_url":"https://api.github.com/repos/jdbi/jdbi/subscribers","subscription_url":"https://api.github.com/repos/jdbi/jdbi/subscription","commits_url":"https://api.github.com/repos/jdbi/jdbi/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdbi/jdbi/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdbi/jdbi/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdbi/jdbi/issues/comments{/number}","contents_url":"https://api.github.com/repos/jdbi/jdbi/contents/{+path}","compare_url":"https://api.github.com/repos/jdbi/jdbi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdbi/jdbi/merges","archive_url":"https://api.github.com/repos/jdbi/jdbi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdbi/jdbi/downloads","issues_url":"https://api.github.com/repos/jdbi/jdbi/issues{/number}","pulls_url":"https://api.github.com/repos/jdbi/jdbi/pulls{/number}","milestones_url":"https://api.github.com/repos/jdbi/jdbi/milestones{/number}","notifications_url":"https://api.github.com/repos/jdbi/jdbi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdbi/jdbi/labels{/name}","releases_url":"https://api.github.com/repos/jdbi/jdbi/releases{/id}","deployments_url":"https://api.github.com/repos/jdbi/jdbi/deployments","created_at":"2009-06-17T16:36:36Z","updated_at":"2016-07-09T14:11:11Z","pushed_at":"2016-07-09T01:21:46Z","git_url":"git://github.com/jdbi/jdbi.git","ssh_url":"git@github.com:jdbi/jdbi.git","clone_url":"https://github.com/jdbi/jdbi.git","svn_url":"https://github.com/jdbi/jdbi","homepage":"http://jdbi.org/","size":15241,"stargazers_count":656,"watchers_count":656,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":152,"mirror_url":null,"open_issues_count":49,"forks":152,"open_issues":49,"watchers":656,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jdbi/jdbi/pulls/392"},"html":{"href":"https://github.com/jdbi/jdbi/pull/392"},"issue":{"href":"https://api.github.com/repos/jdbi/jdbi/issues/392"},"comments":{"href":"https://api.github.com/repos/jdbi/jdbi/issues/392/comments"},"review_comments":{"href":"https://api.github.com/repos/jdbi/jdbi/pulls/392/comments"},"review_comment":{"href":"https://api.github.com/repos/jdbi/jdbi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jdbi/jdbi/pulls/392/commits"},"statuses":{"href":"https://api.github.com/repos/jdbi/jdbi/statuses/372bea33f09b6b32ef0e47070d9f241bf901c204"}}}}
{"actor":{"display_login":"qualidafial"}}