{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleChrome/sw-helpers/pulls/comments/90506789","pull_request_review_id":11025808,"id":90506789,"diff_hunk":"@@ -16,3 +16,6 @@\n export const defaultCacheId = `sw-precaching`;\n export const hashParamName = '_sw-precaching';\n export const version = 'v1';\n+export const DB_NAME = 'sw-precaching';","path":"packages/sw-precaching/src/lib/constants.js","position":4,"original_position":4,"commit_id":"e497c07936d4652641b6f86853d8c72631252d05","original_commit_id":"e497c07936d4652641b6f86853d8c72631252d05","user":{"login":"gauntface","id":139760,"avatar_url":"https://avatars.githubusercontent.com/u/139760?v=3","gravatar_id":"","url":"https://api.github.com/users/gauntface","html_url":"https://github.com/gauntface","followers_url":"https://api.github.com/users/gauntface/followers","following_url":"https://api.github.com/users/gauntface/following{/other_user}","gists_url":"https://api.github.com/users/gauntface/gists{/gist_id}","starred_url":"https://api.github.com/users/gauntface/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gauntface/subscriptions","organizations_url":"https://api.github.com/users/gauntface/orgs","repos_url":"https://api.github.com/users/gauntface/repos","events_url":"https://api.github.com/users/gauntface/events{/privacy}","received_events_url":"https://api.github.com/users/gauntface/received_events","type":"User","site_admin":false},"body":"Good point - I think I was copying sw-appcache-behaviour, but changed here.","created_at":"2016-12-01T18:26:39Z","updated_at":"2016-12-01T18:26:39Z","html_url":"https://github.com/GoogleChrome/sw-helpers/pull/76#discussion_r90506789","pull_request_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/pulls/76","_links":{"self":{"href":"https://api.github.com/repos/GoogleChrome/sw-helpers/pulls/comments/90506789"},"html":{"href":"https://github.com/GoogleChrome/sw-helpers/pull/76#discussion_r90506789"},"pull_request":{"href":"https://api.github.com/repos/GoogleChrome/sw-helpers/pulls/76"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleChrome/sw-helpers/pulls/76","id":95943107,"html_url":"https://github.com/GoogleChrome/sw-helpers/pull/76","diff_url":"https://github.com/GoogleChrome/sw-helpers/pull/76.diff","patch_url":"https://github.com/GoogleChrome/sw-helpers/pull/76.patch","issue_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/issues/76","number":76,"state":"open","locked":false,"title":"Sw precaching","user":{"login":"gauntface","id":139760,"avatar_url":"https://avatars.githubusercontent.com/u/139760?v=3","gravatar_id":"","url":"https://api.github.com/users/gauntface","html_url":"https://github.com/gauntface","followers_url":"https://api.github.com/users/gauntface/followers","following_url":"https://api.github.com/users/gauntface/following{/other_user}","gists_url":"https://api.github.com/users/gauntface/gists{/gist_id}","starred_url":"https://api.github.com/users/gauntface/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gauntface/subscriptions","organizations_url":"https://api.github.com/users/gauntface/orgs","repos_url":"https://api.github.com/users/gauntface/repos","events_url":"https://api.github.com/users/gauntface/events{/privacy}","received_events_url":"https://api.github.com/users/gauntface/received_events","type":"User","site_admin":false},"body":"R: @jeffposnick @addyosmani @gauntface\r\n\r\nThis is a super duper early cut of the sw-precaching.\r\n\r\nIt's safe landing in master as the package.json as private set to true. But would be good to get current thoughts.\r\n\r\nOne thing before landing this: I need to add cache headers.\r\n\r\nThings I need to do:\r\n\r\n1.) Add caching to test server to trigger possible http cache issues.\r\n2.) Switch back to search URL params to cache bust BUT cache the response against the origin path.\r\n3.) Add more tests to ensure robustness, including:\r\n    3.1) Cache absolute URLS\r\n    3.2) Cache absolute URLS for third party origins\r\n    3.3) Manipulate indexeddb and cache between runs.","created_at":"2016-11-30T18:03:29Z","updated_at":"2016-12-01T18:26:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aae51f2cef2fdcd2d116891fc2e1b6afee77ab74","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/pulls/76/commits","review_comments_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/pulls/76/comments","review_comment_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/issues/76/comments","statuses_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/statuses/e497c07936d4652641b6f86853d8c72631252d05","head":{"label":"GoogleChrome:sw-precaching","ref":"sw-precaching","sha":"e497c07936d4652641b6f86853d8c72631252d05","user":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars.githubusercontent.com/u/1778935?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"repo":{"id":55424670,"name":"sw-helpers","full_name":"GoogleChrome/sw-helpers","owner":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars.githubusercontent.com/u/1778935?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleChrome/sw-helpers","description":"Service Worker helper libraries","fork":false,"url":"https://api.github.com/repos/GoogleChrome/sw-helpers","forks_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/forks","keys_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/teams","hooks_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/hooks","issue_events_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/events","assignees_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/tags","blobs_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/languages","stargazers_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/stargazers","contributors_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/contributors","subscribers_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/subscribers","subscription_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/subscription","commits_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/merges","archive_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/downloads","issues_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/labels{/name}","releases_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/deployments","created_at":"2016-04-04T15:55:19Z","updated_at":"2016-11-30T12:53:18Z","pushed_at":"2016-11-30T21:14:01Z","git_url":"git://github.com/GoogleChrome/sw-helpers.git","ssh_url":"git@github.com:GoogleChrome/sw-helpers.git","clone_url":"https://github.com/GoogleChrome/sw-helpers.git","svn_url":"https://github.com/GoogleChrome/sw-helpers","homepage":"","size":1491,"stargazers_count":164,"watchers_count":164,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"open_issues_count":18,"forks":12,"open_issues":18,"watchers":164,"default_branch":"master"}},"base":{"label":"GoogleChrome:master","ref":"master","sha":"43dea0fe7c5c2dca3500b988667de8b9ead46a3a","user":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars.githubusercontent.com/u/1778935?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"repo":{"id":55424670,"name":"sw-helpers","full_name":"GoogleChrome/sw-helpers","owner":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars.githubusercontent.com/u/1778935?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleChrome/sw-helpers","description":"Service Worker helper libraries","fork":false,"url":"https://api.github.com/repos/GoogleChrome/sw-helpers","forks_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/forks","keys_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/teams","hooks_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/hooks","issue_events_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/events","assignees_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/tags","blobs_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/languages","stargazers_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/stargazers","contributors_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/contributors","subscribers_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/subscribers","subscription_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/subscription","commits_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/merges","archive_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/downloads","issues_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/labels{/name}","releases_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleChrome/sw-helpers/deployments","created_at":"2016-04-04T15:55:19Z","updated_at":"2016-11-30T12:53:18Z","pushed_at":"2016-11-30T21:14:01Z","git_url":"git://github.com/GoogleChrome/sw-helpers.git","ssh_url":"git@github.com:GoogleChrome/sw-helpers.git","clone_url":"https://github.com/GoogleChrome/sw-helpers.git","svn_url":"https://github.com/GoogleChrome/sw-helpers","homepage":"","size":1491,"stargazers_count":164,"watchers_count":164,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"open_issues_count":18,"forks":12,"open_issues":18,"watchers":164,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleChrome/sw-helpers/pulls/76"},"html":{"href":"https://github.com/GoogleChrome/sw-helpers/pull/76"},"issue":{"href":"https://api.github.com/repos/GoogleChrome/sw-helpers/issues/76"},"comments":{"href":"https://api.github.com/repos/GoogleChrome/sw-helpers/issues/76/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleChrome/sw-helpers/pulls/76/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleChrome/sw-helpers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleChrome/sw-helpers/pulls/76/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleChrome/sw-helpers/statuses/e497c07936d4652641b6f86853d8c72631252d05"}}}}
{"actor":{"display_login":"gauntface"}}