{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/draft-js/issues/340","repository_url":"https://api.github.com/repos/facebook/draft-js","labels_url":"https://api.github.com/repos/facebook/draft-js/issues/340/labels{/name}","comments_url":"https://api.github.com/repos/facebook/draft-js/issues/340/comments","events_url":"https://api.github.com/repos/facebook/draft-js/issues/340/events","html_url":"https://github.com/facebook/draft-js/pull/340","id":151070982,"number":340,"title":"Convert handler signature to return a `DraftHandleValue` value, instead of a boolean - #339","user":{"login":"johanneslumpe","id":3470207,"avatar_url":"https://avatars.githubusercontent.com/u/3470207?v=3","gravatar_id":"","url":"https://api.github.com/users/johanneslumpe","html_url":"https://github.com/johanneslumpe","followers_url":"https://api.github.com/users/johanneslumpe/followers","following_url":"https://api.github.com/users/johanneslumpe/following{/other_user}","gists_url":"https://api.github.com/users/johanneslumpe/gists{/gist_id}","starred_url":"https://api.github.com/users/johanneslumpe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johanneslumpe/subscriptions","organizations_url":"https://api.github.com/users/johanneslumpe/orgs","repos_url":"https://api.github.com/users/johanneslumpe/repos","events_url":"https://api.github.com/users/johanneslumpe/events{/privacy}","received_events_url":"https://api.github.com/users/johanneslumpe/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/draft-js/labels/CLA%20Signed","name":"CLA Signed","color":"009900"},{"url":"https://api.github.com/repos/facebook/draft-js/labels/GH%20Review:%20review-needed","name":"GH Review: review-needed","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-04-26T08:13:47Z","updated_at":"2016-08-17T16:33:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/draft-js/pulls/340","html_url":"https://github.com/facebook/draft-js/pull/340","diff_url":"https://github.com/facebook/draft-js/pull/340.diff","patch_url":"https://github.com/facebook/draft-js/pull/340.patch"},"body":"Changes for https://github.com/facebook/draft-js/issues/339\r\n\r\n@hellendag I'm not personally happy with all the literal `'handled'` strings now. The same counts for every usage of string literals, like the values of `DraftRemovalDirection`, `DraftBlockType` or any other type value. What are your thoughts on extracting them into constant files and using those constants instead?\r\n\r\nSomething along these lines:\r\n```js\r\n\r\nimport { HANDLED } from 'DraftHandleValueConstants';\r\n\r\n/*...*/\r\nhandleReturn(e) {\r\n  return HANDLED;\r\n}\r\n/*...*/\r\n```\r\nSince we already have those values to create the flow types, is that maybe a point where we can hook in to generate those constants, so we wouldn't have to duplicate them in two files?"},"comment":{"url":"https://api.github.com/repos/facebook/draft-js/issues/comments/240469267","html_url":"https://github.com/facebook/draft-js/pull/340#issuecomment-240469267","issue_url":"https://api.github.com/repos/facebook/draft-js/issues/340","id":240469267,"user":{"login":"hellendag","id":2823852,"avatar_url":"https://avatars.githubusercontent.com/u/2823852?v=3","gravatar_id":"","url":"https://api.github.com/users/hellendag","html_url":"https://github.com/hellendag","followers_url":"https://api.github.com/users/hellendag/followers","following_url":"https://api.github.com/users/hellendag/following{/other_user}","gists_url":"https://api.github.com/users/hellendag/gists{/gist_id}","starred_url":"https://api.github.com/users/hellendag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hellendag/subscriptions","organizations_url":"https://api.github.com/users/hellendag/orgs","repos_url":"https://api.github.com/users/hellendag/repos","events_url":"https://api.github.com/users/hellendag/events{/privacy}","received_events_url":"https://api.github.com/users/hellendag/received_events","type":"User","site_admin":false},"created_at":"2016-08-17T16:33:28Z","updated_at":"2016-08-17T16:33:28Z","body":"Looks good to me! Thanks @johanneslumpe!"}}
{"actor":{"display_login":"hellendag"}}