{"action":"closed","number":500,"pull_request":{"url":"https://api.github.com/repos/Z3Prover/z3/pulls/500","id":62219910,"html_url":"https://github.com/Z3Prover/z3/pull/500","diff_url":"https://github.com/Z3Prover/z3/pull/500.diff","patch_url":"https://github.com/Z3Prover/z3/pull/500.patch","issue_url":"https://api.github.com/repos/Z3Prover/z3/issues/500","number":500,"state":"closed","locked":false,"title":"In ``small_object_allocator`` remove early return for Debug builds","user":{"login":"delcypher","id":511795,"avatar_url":"https://avatars.githubusercontent.com/u/511795?v=3","gravatar_id":"","url":"https://api.github.com/users/delcypher","html_url":"https://github.com/delcypher","followers_url":"https://api.github.com/users/delcypher/followers","following_url":"https://api.github.com/users/delcypher/following{/other_user}","gists_url":"https://api.github.com/users/delcypher/gists{/gist_id}","starred_url":"https://api.github.com/users/delcypher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delcypher/subscriptions","organizations_url":"https://api.github.com/users/delcypher/orgs","repos_url":"https://api.github.com/users/delcypher/repos","events_url":"https://api.github.com/users/delcypher/events{/privacy}","received_events_url":"https://api.github.com/users/delcypher/received_events","type":"User","site_admin":false},"body":"In ``small_object_allocator`` remove early return for Debug builds on non-windows platforms.\r\n\r\nThe existing code meant that the ``SASSERT()`` calls were never checked\r\non non-windows platforms because they were only \"syntactically\"\r\nreachable in Release builds (in which they are no-ops). The comments\r\nsuggest that this early return was for Valgrind but this doesn't seem\r\nlike a good idea. If false positives occur when running Z3 under\r\nvalgrind then a suppression file should be used rather than trying to\r\nchange Z3's behaviour. This is related to #477 .","created_at":"2016-03-09T12:14:43Z","updated_at":"2016-03-09T13:01:40Z","closed_at":"2016-03-09T13:01:40Z","merged_at":null,"merge_commit_sha":"8911c96a7ebd16b009b699de9d13a4b5475840b1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Z3Prover/z3/pulls/500/commits","review_comments_url":"https://api.github.com/repos/Z3Prover/z3/pulls/500/comments","review_comment_url":"https://api.github.com/repos/Z3Prover/z3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Z3Prover/z3/issues/500/comments","statuses_url":"https://api.github.com/repos/Z3Prover/z3/statuses/13e12e82829ded7527e4b5ff0d0c3feb75bad1cd","head":{"label":"delcypher:no_early_return_smallobj_alloc","ref":"no_early_return_smallobj_alloc","sha":"13e12e82829ded7527e4b5ff0d0c3feb75bad1cd","user":{"login":"delcypher","id":511795,"avatar_url":"https://avatars.githubusercontent.com/u/511795?v=3","gravatar_id":"","url":"https://api.github.com/users/delcypher","html_url":"https://github.com/delcypher","followers_url":"https://api.github.com/users/delcypher/followers","following_url":"https://api.github.com/users/delcypher/following{/other_user}","gists_url":"https://api.github.com/users/delcypher/gists{/gist_id}","starred_url":"https://api.github.com/users/delcypher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delcypher/subscriptions","organizations_url":"https://api.github.com/users/delcypher/orgs","repos_url":"https://api.github.com/users/delcypher/repos","events_url":"https://api.github.com/users/delcypher/events{/privacy}","received_events_url":"https://api.github.com/users/delcypher/received_events","type":"User","site_admin":false},"repo":{"id":46787907,"name":"z3-1","full_name":"delcypher/z3-1","owner":{"login":"delcypher","id":511795,"avatar_url":"https://avatars.githubusercontent.com/u/511795?v=3","gravatar_id":"","url":"https://api.github.com/users/delcypher","html_url":"https://github.com/delcypher","followers_url":"https://api.github.com/users/delcypher/followers","following_url":"https://api.github.com/users/delcypher/following{/other_user}","gists_url":"https://api.github.com/users/delcypher/gists{/gist_id}","starred_url":"https://api.github.com/users/delcypher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delcypher/subscriptions","organizations_url":"https://api.github.com/users/delcypher/orgs","repos_url":"https://api.github.com/users/delcypher/repos","events_url":"https://api.github.com/users/delcypher/events{/privacy}","received_events_url":"https://api.github.com/users/delcypher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/delcypher/z3-1","description":"The Z3 Theorem Prover","fork":true,"url":"https://api.github.com/repos/delcypher/z3-1","forks_url":"https://api.github.com/repos/delcypher/z3-1/forks","keys_url":"https://api.github.com/repos/delcypher/z3-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/delcypher/z3-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/delcypher/z3-1/teams","hooks_url":"https://api.github.com/repos/delcypher/z3-1/hooks","issue_events_url":"https://api.github.com/repos/delcypher/z3-1/issues/events{/number}","events_url":"https://api.github.com/repos/delcypher/z3-1/events","assignees_url":"https://api.github.com/repos/delcypher/z3-1/assignees{/user}","branches_url":"https://api.github.com/repos/delcypher/z3-1/branches{/branch}","tags_url":"https://api.github.com/repos/delcypher/z3-1/tags","blobs_url":"https://api.github.com/repos/delcypher/z3-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/delcypher/z3-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/delcypher/z3-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/delcypher/z3-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/delcypher/z3-1/statuses/{sha}","languages_url":"https://api.github.com/repos/delcypher/z3-1/languages","stargazers_url":"https://api.github.com/repos/delcypher/z3-1/stargazers","contributors_url":"https://api.github.com/repos/delcypher/z3-1/contributors","subscribers_url":"https://api.github.com/repos/delcypher/z3-1/subscribers","subscription_url":"https://api.github.com/repos/delcypher/z3-1/subscription","commits_url":"https://api.github.com/repos/delcypher/z3-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/delcypher/z3-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/delcypher/z3-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/delcypher/z3-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/delcypher/z3-1/contents/{+path}","compare_url":"https://api.github.com/repos/delcypher/z3-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/delcypher/z3-1/merges","archive_url":"https://api.github.com/repos/delcypher/z3-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/delcypher/z3-1/downloads","issues_url":"https://api.github.com/repos/delcypher/z3-1/issues{/number}","pulls_url":"https://api.github.com/repos/delcypher/z3-1/pulls{/number}","milestones_url":"https://api.github.com/repos/delcypher/z3-1/milestones{/number}","notifications_url":"https://api.github.com/repos/delcypher/z3-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/delcypher/z3-1/labels{/name}","releases_url":"https://api.github.com/repos/delcypher/z3-1/releases{/id}","deployments_url":"https://api.github.com/repos/delcypher/z3-1/deployments","created_at":"2015-11-24T11:37:57Z","updated_at":"2016-03-07T16:25:22Z","pushed_at":"2016-03-09T12:14:14Z","git_url":"git://github.com/delcypher/z3-1.git","ssh_url":"git@github.com:delcypher/z3-1.git","clone_url":"https://github.com/delcypher/z3-1.git","svn_url":"https://github.com/delcypher/z3-1","homepage":null,"size":16555,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Z3Prover:master","ref":"master","sha":"71fff8ffa2fa80a34d2b3bf3f705ef0852310b04","user":{"login":"Z3Prover","id":11668813,"avatar_url":"https://avatars.githubusercontent.com/u/11668813?v=3","gravatar_id":"","url":"https://api.github.com/users/Z3Prover","html_url":"https://github.com/Z3Prover","followers_url":"https://api.github.com/users/Z3Prover/followers","following_url":"https://api.github.com/users/Z3Prover/following{/other_user}","gists_url":"https://api.github.com/users/Z3Prover/gists{/gist_id}","starred_url":"https://api.github.com/users/Z3Prover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Z3Prover/subscriptions","organizations_url":"https://api.github.com/users/Z3Prover/orgs","repos_url":"https://api.github.com/users/Z3Prover/repos","events_url":"https://api.github.com/users/Z3Prover/events{/privacy}","received_events_url":"https://api.github.com/users/Z3Prover/received_events","type":"Organization","site_admin":false},"repo":{"id":32944298,"name":"z3","full_name":"Z3Prover/z3","owner":{"login":"Z3Prover","id":11668813,"avatar_url":"https://avatars.githubusercontent.com/u/11668813?v=3","gravatar_id":"","url":"https://api.github.com/users/Z3Prover","html_url":"https://github.com/Z3Prover","followers_url":"https://api.github.com/users/Z3Prover/followers","following_url":"https://api.github.com/users/Z3Prover/following{/other_user}","gists_url":"https://api.github.com/users/Z3Prover/gists{/gist_id}","starred_url":"https://api.github.com/users/Z3Prover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Z3Prover/subscriptions","organizations_url":"https://api.github.com/users/Z3Prover/orgs","repos_url":"https://api.github.com/users/Z3Prover/repos","events_url":"https://api.github.com/users/Z3Prover/events{/privacy}","received_events_url":"https://api.github.com/users/Z3Prover/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Z3Prover/z3","description":"The Z3 Theorem Prover","fork":false,"url":"https://api.github.com/repos/Z3Prover/z3","forks_url":"https://api.github.com/repos/Z3Prover/z3/forks","keys_url":"https://api.github.com/repos/Z3Prover/z3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Z3Prover/z3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Z3Prover/z3/teams","hooks_url":"https://api.github.com/repos/Z3Prover/z3/hooks","issue_events_url":"https://api.github.com/repos/Z3Prover/z3/issues/events{/number}","events_url":"https://api.github.com/repos/Z3Prover/z3/events","assignees_url":"https://api.github.com/repos/Z3Prover/z3/assignees{/user}","branches_url":"https://api.github.com/repos/Z3Prover/z3/branches{/branch}","tags_url":"https://api.github.com/repos/Z3Prover/z3/tags","blobs_url":"https://api.github.com/repos/Z3Prover/z3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Z3Prover/z3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Z3Prover/z3/git/refs{/sha}","trees_url":"https://api.github.com/repos/Z3Prover/z3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Z3Prover/z3/statuses/{sha}","languages_url":"https://api.github.com/repos/Z3Prover/z3/languages","stargazers_url":"https://api.github.com/repos/Z3Prover/z3/stargazers","contributors_url":"https://api.github.com/repos/Z3Prover/z3/contributors","subscribers_url":"https://api.github.com/repos/Z3Prover/z3/subscribers","subscription_url":"https://api.github.com/repos/Z3Prover/z3/subscription","commits_url":"https://api.github.com/repos/Z3Prover/z3/commits{/sha}","git_commits_url":"https://api.github.com/repos/Z3Prover/z3/git/commits{/sha}","comments_url":"https://api.github.com/repos/Z3Prover/z3/comments{/number}","issue_comment_url":"https://api.github.com/repos/Z3Prover/z3/issues/comments{/number}","contents_url":"https://api.github.com/repos/Z3Prover/z3/contents/{+path}","compare_url":"https://api.github.com/repos/Z3Prover/z3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Z3Prover/z3/merges","archive_url":"https://api.github.com/repos/Z3Prover/z3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Z3Prover/z3/downloads","issues_url":"https://api.github.com/repos/Z3Prover/z3/issues{/number}","pulls_url":"https://api.github.com/repos/Z3Prover/z3/pulls{/number}","milestones_url":"https://api.github.com/repos/Z3Prover/z3/milestones{/number}","notifications_url":"https://api.github.com/repos/Z3Prover/z3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Z3Prover/z3/labels{/name}","releases_url":"https://api.github.com/repos/Z3Prover/z3/releases{/id}","deployments_url":"https://api.github.com/repos/Z3Prover/z3/deployments","created_at":"2015-03-26T18:16:07Z","updated_at":"2016-03-09T06:31:59Z","pushed_at":"2016-03-09T12:14:44Z","git_url":"git://github.com/Z3Prover/z3.git","ssh_url":"git@github.com:Z3Prover/z3.git","clone_url":"https://github.com/Z3Prover/z3.git","svn_url":"https://github.com/Z3Prover/z3","homepage":null,"size":22978,"stargazers_count":1435,"watchers_count":1435,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":239,"mirror_url":null,"open_issues_count":37,"forks":239,"open_issues":37,"watchers":1435,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Z3Prover/z3/pulls/500"},"html":{"href":"https://github.com/Z3Prover/z3/pull/500"},"issue":{"href":"https://api.github.com/repos/Z3Prover/z3/issues/500"},"comments":{"href":"https://api.github.com/repos/Z3Prover/z3/issues/500/comments"},"review_comments":{"href":"https://api.github.com/repos/Z3Prover/z3/pulls/500/comments"},"review_comment":{"href":"https://api.github.com/repos/Z3Prover/z3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Z3Prover/z3/pulls/500/commits"},"statuses":{"href":"https://api.github.com/repos/Z3Prover/z3/statuses/13e12e82829ded7527e4b5ff0d0c3feb75bad1cd"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":0,"deletions":9,"changed_files":1}}