{"action":"closed","number":69,"pull_request":{"url":"https://api.github.com/repos/CenterForOpenScience/lookit/pulls/69","id":90433456,"html_url":"https://github.com/CenterForOpenScience/lookit/pull/69","diff_url":"https://github.com/CenterForOpenScience/lookit/pull/69.diff","patch_url":"https://github.com/CenterForOpenScience/lookit/pull/69.patch","issue_url":"https://api.github.com/repos/CenterForOpenScience/lookit/issues/69","number":69,"state":"closed","locked":false,"title":"Fix issue where failing to sign up with a username- twice- hangs the …","user":{"login":"abought","id":2957073,"avatar_url":"https://avatars.githubusercontent.com/u/2957073?v=3","gravatar_id":"","url":"https://api.github.com/users/abought","html_url":"https://github.com/abought","followers_url":"https://api.github.com/users/abought/followers","following_url":"https://api.github.com/users/abought/following{/other_user}","gists_url":"https://api.github.com/users/abought/gists{/gist_id}","starred_url":"https://api.github.com/users/abought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abought/subscriptions","organizations_url":"https://api.github.com/users/abought/orgs","repos_url":"https://api.github.com/users/abought/repos","events_url":"https://api.github.com/users/abought/events{/privacy}","received_events_url":"https://api.github.com/users/abought/received_events","type":"User","site_admin":false},"body":"Refs: https://openscience.atlassian.net/browse/LEI-274\r\n\r\n## Purpose\r\nFix issue where two consecutive failures to register with the same username caused app to hang.\r\n\r\nThis appeared several times in production sentry after new user emails were sent out.\r\n\r\n## Summary of changes\r\n- Remove username field from payload (it's now just an alias for the ID)\r\n- If user creation fails due, unload the created-but-unsaved record from the store so that we can try again without createRecord throwing an error.\r\n\r\n## Testing notes\r\nSteps to reproduce:\r\n1. Try to create an account whose username is already taken.\r\n2. After it fails, hit create account again without changing the information.\r\n\r\nExpected result:\r\n1. A client-side error saying the user name is already taken\r\n\r\nActual result:\r\nThe \"Creating your account\" modal hangs indefinitely, and the console displays an unhandled error:\r\n\"Assertion Failed: The id abought has already been used with another record of type lookit-base@model:account:.\"","created_at":"2016-10-21T19:48:39Z","updated_at":"2016-10-21T21:50:41Z","closed_at":"2016-10-21T21:50:41Z","merged_at":"2016-10-21T21:50:41Z","merge_commit_sha":"c59d19f38b43dcecb1e735b307e69cd9ca4069c2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/CenterForOpenScience/lookit/pulls/69/commits","review_comments_url":"https://api.github.com/repos/CenterForOpenScience/lookit/pulls/69/comments","review_comment_url":"https://api.github.com/repos/CenterForOpenScience/lookit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CenterForOpenScience/lookit/issues/69/comments","statuses_url":"https://api.github.com/repos/CenterForOpenScience/lookit/statuses/bb65d9db21af979d418218504e26b6ef56b61eae","head":{"label":"abought:feature/lei274-account-creation","ref":"feature/lei274-account-creation","sha":"bb65d9db21af979d418218504e26b6ef56b61eae","user":{"login":"abought","id":2957073,"avatar_url":"https://avatars.githubusercontent.com/u/2957073?v=3","gravatar_id":"","url":"https://api.github.com/users/abought","html_url":"https://github.com/abought","followers_url":"https://api.github.com/users/abought/followers","following_url":"https://api.github.com/users/abought/following{/other_user}","gists_url":"https://api.github.com/users/abought/gists{/gist_id}","starred_url":"https://api.github.com/users/abought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abought/subscriptions","organizations_url":"https://api.github.com/users/abought/orgs","repos_url":"https://api.github.com/users/abought/repos","events_url":"https://api.github.com/users/abought/events{/privacy}","received_events_url":"https://api.github.com/users/abought/received_events","type":"User","site_admin":false},"repo":{"id":53979747,"name":"lookit-1","full_name":"abought/lookit-1","owner":{"login":"abought","id":2957073,"avatar_url":"https://avatars.githubusercontent.com/u/2957073?v=3","gravatar_id":"","url":"https://api.github.com/users/abought","html_url":"https://github.com/abought","followers_url":"https://api.github.com/users/abought/followers","following_url":"https://api.github.com/users/abought/following{/other_user}","gists_url":"https://api.github.com/users/abought/gists{/gist_id}","starred_url":"https://api.github.com/users/abought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abought/subscriptions","organizations_url":"https://api.github.com/users/abought/orgs","repos_url":"https://api.github.com/users/abought/repos","events_url":"https://api.github.com/users/abought/events{/privacy}","received_events_url":"https://api.github.com/users/abought/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abought/lookit-1","description":null,"fork":true,"url":"https://api.github.com/repos/abought/lookit-1","forks_url":"https://api.github.com/repos/abought/lookit-1/forks","keys_url":"https://api.github.com/repos/abought/lookit-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abought/lookit-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abought/lookit-1/teams","hooks_url":"https://api.github.com/repos/abought/lookit-1/hooks","issue_events_url":"https://api.github.com/repos/abought/lookit-1/issues/events{/number}","events_url":"https://api.github.com/repos/abought/lookit-1/events","assignees_url":"https://api.github.com/repos/abought/lookit-1/assignees{/user}","branches_url":"https://api.github.com/repos/abought/lookit-1/branches{/branch}","tags_url":"https://api.github.com/repos/abought/lookit-1/tags","blobs_url":"https://api.github.com/repos/abought/lookit-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abought/lookit-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abought/lookit-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/abought/lookit-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abought/lookit-1/statuses/{sha}","languages_url":"https://api.github.com/repos/abought/lookit-1/languages","stargazers_url":"https://api.github.com/repos/abought/lookit-1/stargazers","contributors_url":"https://api.github.com/repos/abought/lookit-1/contributors","subscribers_url":"https://api.github.com/repos/abought/lookit-1/subscribers","subscription_url":"https://api.github.com/repos/abought/lookit-1/subscription","commits_url":"https://api.github.com/repos/abought/lookit-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/abought/lookit-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/abought/lookit-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/abought/lookit-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/abought/lookit-1/contents/{+path}","compare_url":"https://api.github.com/repos/abought/lookit-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abought/lookit-1/merges","archive_url":"https://api.github.com/repos/abought/lookit-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abought/lookit-1/downloads","issues_url":"https://api.github.com/repos/abought/lookit-1/issues{/number}","pulls_url":"https://api.github.com/repos/abought/lookit-1/pulls{/number}","milestones_url":"https://api.github.com/repos/abought/lookit-1/milestones{/number}","notifications_url":"https://api.github.com/repos/abought/lookit-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abought/lookit-1/labels{/name}","releases_url":"https://api.github.com/repos/abought/lookit-1/releases{/id}","deployments_url":"https://api.github.com/repos/abought/lookit-1/deployments","created_at":"2016-03-15T21:28:36Z","updated_at":"2016-03-15T21:28:38Z","pushed_at":"2016-10-21T19:40:07Z","git_url":"git://github.com/abought/lookit-1.git","ssh_url":"git@github.com:abought/lookit-1.git","clone_url":"https://github.com/abought/lookit-1.git","svn_url":"https://github.com/abought/lookit-1","homepage":null,"size":18842,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"CenterForOpenScience:develop","ref":"develop","sha":"d00eb0d36fc76d9f1151f30f9300cdbdc01e4521","user":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars.githubusercontent.com/u/3344584?v=3","gravatar_id":"","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"repo":{"id":50365623,"name":"lookit","full_name":"CenterForOpenScience/lookit","owner":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars.githubusercontent.com/u/3344584?v=3","gravatar_id":"","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CenterForOpenScience/lookit","description":null,"fork":false,"url":"https://api.github.com/repos/CenterForOpenScience/lookit","forks_url":"https://api.github.com/repos/CenterForOpenScience/lookit/forks","keys_url":"https://api.github.com/repos/CenterForOpenScience/lookit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CenterForOpenScience/lookit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CenterForOpenScience/lookit/teams","hooks_url":"https://api.github.com/repos/CenterForOpenScience/lookit/hooks","issue_events_url":"https://api.github.com/repos/CenterForOpenScience/lookit/issues/events{/number}","events_url":"https://api.github.com/repos/CenterForOpenScience/lookit/events","assignees_url":"https://api.github.com/repos/CenterForOpenScience/lookit/assignees{/user}","branches_url":"https://api.github.com/repos/CenterForOpenScience/lookit/branches{/branch}","tags_url":"https://api.github.com/repos/CenterForOpenScience/lookit/tags","blobs_url":"https://api.github.com/repos/CenterForOpenScience/lookit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CenterForOpenScience/lookit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CenterForOpenScience/lookit/git/refs{/sha}","trees_url":"https://api.github.com/repos/CenterForOpenScience/lookit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CenterForOpenScience/lookit/statuses/{sha}","languages_url":"https://api.github.com/repos/CenterForOpenScience/lookit/languages","stargazers_url":"https://api.github.com/repos/CenterForOpenScience/lookit/stargazers","contributors_url":"https://api.github.com/repos/CenterForOpenScience/lookit/contributors","subscribers_url":"https://api.github.com/repos/CenterForOpenScience/lookit/subscribers","subscription_url":"https://api.github.com/repos/CenterForOpenScience/lookit/subscription","commits_url":"https://api.github.com/repos/CenterForOpenScience/lookit/commits{/sha}","git_commits_url":"https://api.github.com/repos/CenterForOpenScience/lookit/git/commits{/sha}","comments_url":"https://api.github.com/repos/CenterForOpenScience/lookit/comments{/number}","issue_comment_url":"https://api.github.com/repos/CenterForOpenScience/lookit/issues/comments{/number}","contents_url":"https://api.github.com/repos/CenterForOpenScience/lookit/contents/{+path}","compare_url":"https://api.github.com/repos/CenterForOpenScience/lookit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CenterForOpenScience/lookit/merges","archive_url":"https://api.github.com/repos/CenterForOpenScience/lookit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CenterForOpenScience/lookit/downloads","issues_url":"https://api.github.com/repos/CenterForOpenScience/lookit/issues{/number}","pulls_url":"https://api.github.com/repos/CenterForOpenScience/lookit/pulls{/number}","milestones_url":"https://api.github.com/repos/CenterForOpenScience/lookit/milestones{/number}","notifications_url":"https://api.github.com/repos/CenterForOpenScience/lookit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CenterForOpenScience/lookit/labels{/name}","releases_url":"https://api.github.com/repos/CenterForOpenScience/lookit/releases{/id}","deployments_url":"https://api.github.com/repos/CenterForOpenScience/lookit/deployments","created_at":"2016-01-25T16:53:21Z","updated_at":"2016-08-09T14:50:51Z","pushed_at":"2016-10-21T21:50:42Z","git_url":"git://github.com/CenterForOpenScience/lookit.git","ssh_url":"git@github.com:CenterForOpenScience/lookit.git","clone_url":"https://github.com/CenterForOpenScience/lookit.git","svn_url":"https://github.com/CenterForOpenScience/lookit","homepage":null,"size":18882,"stargazers_count":3,"watchers_count":3,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":1,"forks":6,"open_issues":1,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/CenterForOpenScience/lookit/pulls/69"},"html":{"href":"https://github.com/CenterForOpenScience/lookit/pull/69"},"issue":{"href":"https://api.github.com/repos/CenterForOpenScience/lookit/issues/69"},"comments":{"href":"https://api.github.com/repos/CenterForOpenScience/lookit/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/CenterForOpenScience/lookit/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/CenterForOpenScience/lookit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CenterForOpenScience/lookit/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/CenterForOpenScience/lookit/statuses/bb65d9db21af979d418218504e26b6ef56b61eae"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"abought","id":2957073,"avatar_url":"https://avatars.githubusercontent.com/u/2957073?v=3","gravatar_id":"","url":"https://api.github.com/users/abought","html_url":"https://github.com/abought","followers_url":"https://api.github.com/users/abought/followers","following_url":"https://api.github.com/users/abought/following{/other_user}","gists_url":"https://api.github.com/users/abought/gists{/gist_id}","starred_url":"https://api.github.com/users/abought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abought/subscriptions","organizations_url":"https://api.github.com/users/abought/orgs","repos_url":"https://api.github.com/users/abought/repos","events_url":"https://api.github.com/users/abought/events{/privacy}","received_events_url":"https://api.github.com/users/abought/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":3,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"abought"}}