{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-zeppelin/issues/761","repository_url":"https://api.github.com/repos/apache/incubator-zeppelin","labels_url":"https://api.github.com/repos/apache/incubator-zeppelin/issues/761/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-zeppelin/issues/761/comments","events_url":"https://api.github.com/repos/apache/incubator-zeppelin/issues/761/events","html_url":"https://github.com/apache/incubator-zeppelin/pull/761","id":138449318,"number":761,"title":"[ZEPPELIN-672] Add feature to export tables using Datatables","user":{"login":"ankurmitujjain","id":1140475,"avatar_url":"https://avatars.githubusercontent.com/u/1140475?v=3","gravatar_id":"","url":"https://api.github.com/users/ankurmitujjain","html_url":"https://github.com/ankurmitujjain","followers_url":"https://api.github.com/users/ankurmitujjain/followers","following_url":"https://api.github.com/users/ankurmitujjain/following{/other_user}","gists_url":"https://api.github.com/users/ankurmitujjain/gists{/gist_id}","starred_url":"https://api.github.com/users/ankurmitujjain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ankurmitujjain/subscriptions","organizations_url":"https://api.github.com/users/ankurmitujjain/orgs","repos_url":"https://api.github.com/users/ankurmitujjain/repos","events_url":"https://api.github.com/users/ankurmitujjain/events{/privacy}","received_events_url":"https://api.github.com/users/ankurmitujjain/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":29,"created_at":"2016-03-04T11:21:17Z","updated_at":"2016-04-11T10:39:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/incubator-zeppelin/pulls/761","html_url":"https://github.com/apache/incubator-zeppelin/pull/761","diff_url":"https://github.com/apache/incubator-zeppelin/pull/761.diff","patch_url":"https://github.com/apache/incubator-zeppelin/pull/761.patch"},"body":"### What is this PR for?\r\nIt is an extension of #6 #714\r\nIt allows user to export data in a paragraph to a TSV/CSV file.\r\n\r\n\r\n### What type of PR is it?\r\nFeature\r\n\r\n### Todos\r\n* [x] - Improves the current Table features like Search, Fixed Headers, Sorting\r\n* [x] - Allowing Export to be not only Table based, but also of Chart Pivoted data.\r\n\r\n### Is there a relevant Jira issue?\r\n[ZEPPELIN-672](https://issues.apache.org/jira/browse/ZEPPELIN-672)\r\n\r\n\r\n### How should this be tested?\r\n1. Create a paragraph with data in %table view\r\n2. Click on TSV/CSV button to export CSV/TSV file\r\n\r\n\r\n### Screenshots (if appropriate)\r\n![image](https://cloud.githubusercontent.com/assets/1140475/13525760/4913bd8e-e229-11e5-9cd5-480c8b583d5b.png)\r\n\r\n\r\n### Questions:\r\n* Does the licenses files need update?\r\n Need to have MIT license for Datatables.\r\n* Is there breaking changes for older versions?\r\nNo\r\n* Does this needs documentation?\r\nNo\r\n"},"comment":{"url":"https://api.github.com/repos/apache/incubator-zeppelin/issues/comments/208277805","html_url":"https://github.com/apache/incubator-zeppelin/pull/761#issuecomment-208277805","issue_url":"https://api.github.com/repos/apache/incubator-zeppelin/issues/761","id":208277805,"user":{"login":"ankurmitujjain","id":1140475,"avatar_url":"https://avatars.githubusercontent.com/u/1140475?v=3","gravatar_id":"","url":"https://api.github.com/users/ankurmitujjain","html_url":"https://github.com/ankurmitujjain","followers_url":"https://api.github.com/users/ankurmitujjain/followers","following_url":"https://api.github.com/users/ankurmitujjain/following{/other_user}","gists_url":"https://api.github.com/users/ankurmitujjain/gists{/gist_id}","starred_url":"https://api.github.com/users/ankurmitujjain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ankurmitujjain/subscriptions","organizations_url":"https://api.github.com/users/ankurmitujjain/orgs","repos_url":"https://api.github.com/users/ankurmitujjain/repos","events_url":"https://api.github.com/users/ankurmitujjain/events{/privacy}","received_events_url":"https://api.github.com/users/ankurmitujjain/received_events","type":"User","site_admin":false},"created_at":"2016-04-11T10:39:12Z","updated_at":"2016-04-11T10:39:12Z","body":"@corneadoug I believe with above suggested changes it seems that you want this PR to replace default table implementation with data-tables only...\r\n\r\nSo current PR will be without search and download/export buttons. \r\nMy main motive for this PR was to provide download button to download data in csv or tsv format. :P\r\n\r\nAlso you wanted to remove floatHead dependency which got added by #565  with default datatable scrollbar. \r\nNote: floatHead is to make table headers fixed, datatable alternative to this is FixedHeader\r\nFor scrolling current implementation is using perfect-scrollbar . \r\nPlease correct me if my understanding is wrong :P\r\n\r\nAfter going to datatables site it seems that default scrollbar of datatable needs fix \"y\" size , after doing a round of testing it seems, when we change paragraph size table will not get updated/redrawn automatically, so we will need some kind of tweak around to get that fixed or basically redraw table.\r\n\r\n[Datatable default Scroll](https://datatables.net/examples/basic_init/scroll_xy.html)\r\n\r\nI also saw a scroller and fixedheader plugin of datatable which implements scrolling over default scrollbar, but it seems that perfectScrollbar with floatHead is good alternative over those as I feel their UI is better and provide mu more functionality over these plugins...\r\n\r\n[floathead](http://mkoryak.github.io/floatThead/datatables/)\r\n[perfect-scrollbar](https://github.com/noraesae/perfect-scrollbar)\r\n\r\n\r\nFor other points..\r\n\r\n- the search bar is unnecessary in non-table case\r\nI will remove search box for now, but I was thinking to dynamically update charts on filtered dataset with that searchbox (may be another PR).\r\n\r\n- It doesn't download the pivoted data (doesn't really matter)\r\n- Hard to resize\r\nPlease share me steps /screenshots for above.\r\n\r\nPlease feel free to add any kind of changes to my PR, I would welcome good changes, as I like to have features added to zeppelin ASAP instead of thinking for credit/contribution sharing."}}