{"action":"created","issue":{"url":"https://api.github.com/repos/openSUSE/open-build-service/issues/2377","repository_url":"https://api.github.com/repos/openSUSE/open-build-service","labels_url":"https://api.github.com/repos/openSUSE/open-build-service/issues/2377/labels{/name}","comments_url":"https://api.github.com/repos/openSUSE/open-build-service/issues/2377/comments","events_url":"https://api.github.com/repos/openSUSE/open-build-service/issues/2377/events","html_url":"https://github.com/openSUSE/open-build-service/pull/2377","id":191650876,"number":2377,"title":"[api] Allow all base64 encoding characters in passwords.","user":{"login":"trhd","id":11553916,"avatar_url":"https://avatars.githubusercontent.com/u/11553916?v=3","gravatar_id":"","url":"https://api.github.com/users/trhd","html_url":"https://github.com/trhd","followers_url":"https://api.github.com/users/trhd/followers","following_url":"https://api.github.com/users/trhd/following{/other_user}","gists_url":"https://api.github.com/users/trhd/gists{/gist_id}","starred_url":"https://api.github.com/users/trhd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trhd/subscriptions","organizations_url":"https://api.github.com/users/trhd/orgs","repos_url":"https://api.github.com/users/trhd/repos","events_url":"https://api.github.com/users/trhd/events{/privacy}","received_events_url":"https://api.github.com/users/trhd/received_events","type":"User","site_admin":false},"labels":[{"id":21922370,"url":"https://api.github.com/repos/openSUSE/open-build-service/labels/frontend","name":"frontend","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-11-25T08:46:45Z","updated_at":"2016-12-08T09:57:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openSUSE/open-build-service/pulls/2377","html_url":"https://github.com/openSUSE/open-build-service/pull/2377","diff_url":"https://github.com/openSUSE/open-build-service/pull/2377.diff","patch_url":"https://github.com/openSUSE/open-build-service/pull/2377.patch"},"body":"The automatically generated fake passwords might not get accepted\r\notherwise.\r\n\r\n\r\nSaw this error when tried to log in for the first time via LDAP.\r\n\r\n[ca9b2501-e035-412b-890d-5d82a0314e0e] [13954:1.68] No user found in database, creating\r\n[ca9b2501-e035-412b-890d-5d82a0314e0e] [13954:1.68] Email: hemmo.nieminen@ericsson.com\r\n[ca9b2501-e035-412b-890d-5d82a0314e0e] [13954:1.68] Name : Hemmo Nieminen\r\n[ca9b2501-e035-412b-890d-5d82a0314e0e] [13954:1.68]    (0.1ms)  BEGIN\r\n[ca9b2501-e035-412b-890d-5d82a0314e0e] [13954:1.72]   User Exists (0.8ms)  SELECT  1 AS one FROM `users` WHERE `users`. `login` = '$username_here' LIMIT 1\r\n[ca9b2501-e035-412b-890d-5d82a0314e0e] [13954:1.72] Error - skipping to create user  #<ActiveModel::Errors:0x00000003b89018 @base=#<User id: nil, created_at: nil, updated_at: nil, last_logged_in_at: \"2016-11-24 14:33:16\", login_failure_count: 0, login: \"$username_here\", email: \"hemmo.nieminen@ericsson.com\", realname: \"\", password: \"$base64_string_here\", password_hash_type: \"md5\", password_salt: \"1234512345\", password_crypted: nil, adminnote: nil, state: \"unconfirmed\", owner_id: nil>, @messages={:password=>[\"must not contain invalid characters.\"]}, @details={:password=>[{:error=>:invalid, :value=>\"$base64_string_here\"}]}> true \"$base64_string_here\"\r\n[ca9b2501-e035-412b-890d-5d82a0314e0e] [13954:1.72]    (0.5ms)  ROLLBACK\r\n[ca9b2501-e035-412b-890d-5d82a0314e0e] [13954:1.72] Creating User failed with:\r\n[ca9b2501-e035-412b-890d-5d82a0314e0e] [13954:1.72] Password must not contain invalid characters.\r\n[ca9b2501-e035-412b-890d-5d82a0314e0e] [13954:1.73] Cannot create ldap userid: 'ehemnie' on OBS\\<br>Password must not co ntain invalid characters.\r\n\r\n\r\n\r\nThis change seemed to fix it."},"comment":{"url":"https://api.github.com/repos/openSUSE/open-build-service/issues/comments/265700291","html_url":"https://github.com/openSUSE/open-build-service/pull/2377#issuecomment-265700291","issue_url":"https://api.github.com/repos/openSUSE/open-build-service/issues/2377","id":265700291,"user":{"login":"bgeuken","id":968949,"avatar_url":"https://avatars.githubusercontent.com/u/968949?v=3","gravatar_id":"","url":"https://api.github.com/users/bgeuken","html_url":"https://github.com/bgeuken","followers_url":"https://api.github.com/users/bgeuken/followers","following_url":"https://api.github.com/users/bgeuken/following{/other_user}","gists_url":"https://api.github.com/users/bgeuken/gists{/gist_id}","starred_url":"https://api.github.com/users/bgeuken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgeuken/subscriptions","organizations_url":"https://api.github.com/users/bgeuken/orgs","repos_url":"https://api.github.com/users/bgeuken/repos","events_url":"https://api.github.com/users/bgeuken/events{/privacy}","received_events_url":"https://api.github.com/users/bgeuken/received_events","type":"User","site_admin":false},"created_at":"2016-12-08T09:57:37Z","updated_at":"2016-12-08T09:57:37Z","body":"LGTM as well. Also tested on my machine => merging"}}
{"actor":{"display_login":"bgeuken"}}