{"action":"created","issue":{"url":"https://api.github.com/repos/Azure/azure-xplat-cli/issues/2438","labels_url":"https://api.github.com/repos/Azure/azure-xplat-cli/issues/2438/labels{/name}","comments_url":"https://api.github.com/repos/Azure/azure-xplat-cli/issues/2438/comments","events_url":"https://api.github.com/repos/Azure/azure-xplat-cli/issues/2438/events","html_url":"https://github.com/Azure/azure-xplat-cli/pull/2438","id":127129578,"number":2438,"title":"simplify logging by removing all hacks, patches and redundancies","user":{"login":"yugangw-msft","id":6014209,"avatar_url":"https://avatars.githubusercontent.com/u/6014209?v=3","gravatar_id":"","url":"https://api.github.com/users/yugangw-msft","html_url":"https://github.com/yugangw-msft","followers_url":"https://api.github.com/users/yugangw-msft/followers","following_url":"https://api.github.com/users/yugangw-msft/following{/other_user}","gists_url":"https://api.github.com/users/yugangw-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/yugangw-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yugangw-msft/subscriptions","organizations_url":"https://api.github.com/users/yugangw-msft/orgs","repos_url":"https://api.github.com/users/yugangw-msft/repos","events_url":"https://api.github.com/users/yugangw-msft/events{/privacy}","received_events_url":"https://api.github.com/users/yugangw-msft/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Azure/azure-xplat-cli/labels/cla-not-required","name":"cla-not-required","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-01-17T22:39:49Z","updated_at":"2016-01-18T02:07:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/2438","html_url":"https://github.com/Azure/azure-xplat-cli/pull/2438","diff_url":"https://github.com/Azure/azure-xplat-cli/pull/2438.diff","patch_url":"https://github.com/Azure/azure-xplat-cli/pull/2438.patch"},"body":"Simply the logging code and get winston do the most heavy lifting. This way the logging code gets much simpler. Also the azure-cli's silly logging (azure.detail.*) no longer needs truncation as winston's async streaming will get all drained up. To get this natural process work, I updated azure-cli's exit logic not to call process.exit unless there is error code, which is a recommended practice anyway. "},"comment":{"url":"https://api.github.com/repos/Azure/azure-xplat-cli/issues/comments/172407853","html_url":"https://github.com/Azure/azure-xplat-cli/pull/2438#issuecomment-172407853","issue_url":"https://api.github.com/repos/Azure/azure-xplat-cli/issues/2438","id":172407853,"user":{"login":"yugangw-msft","id":6014209,"avatar_url":"https://avatars.githubusercontent.com/u/6014209?v=3","gravatar_id":"","url":"https://api.github.com/users/yugangw-msft","html_url":"https://github.com/yugangw-msft","followers_url":"https://api.github.com/users/yugangw-msft/followers","following_url":"https://api.github.com/users/yugangw-msft/following{/other_user}","gists_url":"https://api.github.com/users/yugangw-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/yugangw-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yugangw-msft/subscriptions","organizations_url":"https://api.github.com/users/yugangw-msft/orgs","repos_url":"https://api.github.com/users/yugangw-msft/repos","events_url":"https://api.github.com/users/yugangw-msft/events{/privacy}","received_events_url":"https://api.github.com/users/yugangw-msft/received_events","type":"User","site_admin":false},"created_at":"2016-01-18T02:07:28Z","updated_at":"2016-01-18T02:07:28Z","body":"Have been reviewed by 2 people, so merging"}}