{"action":"created","comment":{"url":"https://api.github.com/repos/Terasology/Fluid/pulls/comments/67563150","id":67563150,"diff_hunk":"@@ -60,6 +70,10 @@ public void fillFluidContainerItem(ActivateEvent event, EntityRef item, FluidCon\n \n                         FluidUtils.setFluidForContainerItem(removedItem, fluidType);\n \n+                        // Fill this fluid container up to max capacity.","path":"src/main/java/org/terasology/fluid/system/FluidAuthoritySystem.java","position":21,"original_position":21,"commit_id":"8627aaeba2821c844f3325e19803cafe73820c40","original_commit_id":"8627aaeba2821c844f3325e19803cafe73820c40","user":{"login":"Josharias","id":5922109,"avatar_url":"https://avatars.githubusercontent.com/u/5922109?v=3","gravatar_id":"","url":"https://api.github.com/users/Josharias","html_url":"https://github.com/Josharias","followers_url":"https://api.github.com/users/Josharias/followers","following_url":"https://api.github.com/users/Josharias/following{/other_user}","gists_url":"https://api.github.com/users/Josharias/gists{/gist_id}","starred_url":"https://api.github.com/users/Josharias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Josharias/subscriptions","organizations_url":"https://api.github.com/users/Josharias/orgs","repos_url":"https://api.github.com/users/Josharias/repos","events_url":"https://api.github.com/users/Josharias/events{/privacy}","received_events_url":"https://api.github.com/users/Josharias/received_events","type":"User","site_admin":false},"body":"Oh,  shoot... I forgot to mention that changing the component without saving it will work in single player,  but will not work in multiplayer scenarios.  Something to look out for.","created_at":"2016-06-17T19:29:14Z","updated_at":"2016-06-17T19:29:15Z","html_url":"https://github.com/Terasology/Fluid/pull/8#discussion_r67563150","pull_request_url":"https://api.github.com/repos/Terasology/Fluid/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/Terasology/Fluid/pulls/comments/67563150"},"html":{"href":"https://github.com/Terasology/Fluid/pull/8#discussion_r67563150"},"pull_request":{"href":"https://api.github.com/repos/Terasology/Fluid/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/Terasology/Fluid/pulls/8","id":74018401,"html_url":"https://github.com/Terasology/Fluid/pull/8","diff_url":"https://github.com/Terasology/Fluid/pull/8.diff","patch_url":"https://github.com/Terasology/Fluid/pull/8.patch","issue_url":"https://api.github.com/repos/Terasology/Fluid/issues/8","number":8,"state":"open","locked":false,"title":"Fluid inventory slots can now be filled even if the inputted volume exceeds the total capacity.","user":{"login":"xrtariq2594","id":8609763,"avatar_url":"https://avatars.githubusercontent.com/u/8609763?v=3","gravatar_id":"","url":"https://api.github.com/users/xrtariq2594","html_url":"https://github.com/xrtariq2594","followers_url":"https://api.github.com/users/xrtariq2594/followers","following_url":"https://api.github.com/users/xrtariq2594/following{/other_user}","gists_url":"https://api.github.com/users/xrtariq2594/gists{/gist_id}","starred_url":"https://api.github.com/users/xrtariq2594/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xrtariq2594/subscriptions","organizations_url":"https://api.github.com/users/xrtariq2594/orgs","repos_url":"https://api.github.com/users/xrtariq2594/repos","events_url":"https://api.github.com/users/xrtariq2594/events{/privacy}","received_events_url":"https://api.github.com/users/xrtariq2594/received_events","type":"User","site_admin":false},"body":"### Description of changes\r\n\r\nAt a high level, what I did was make the FluidManager be able to allow fluid to be deposited into fluid inventory slots even if the combined total was greater than the max capacity. So now, you won't face the scenario where a CraftingStation has 9500/10000 ml of water, but you can't refill it as the wooden bucket has 10000 ml of water. Now, the former will be filled back up to max, and the latter (as long as you use the addFluidFromHolder method), will be drained down to 9500 ml.\r\n\r\n### Other possible improvements\r\n\r\nAdd a description while mousing over the WoodenBuckets that shows their current volume and max capacity. For example, \"5000 / 10000 ml\".\r\n\r\n### How to test\r\n\r\nIn a module like WoodAndStone or ThroughtTheAges, create a PortableHerbalismStation and a WoodenBucket. Fill the WoodenBucket with water, and deposit it into the fluid input slot of the station. The fluid meter should be below 10,000 ml. Then, craft any potion using the station. Refill the bucket again. Deposit it back into the fluid input slot of the station. The fluid meter should be refilled back up to 10,000 ml, and the bucket will still show the filled texture. If this is the case, the test is a success.\r\n\r\n### Credits\r\n\r\n@Cervator and @Josharias ","created_at":"2016-06-16T03:47:09Z","updated_at":"2016-06-17T19:29:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82d1035bae8439bdfd2d1767a115df345ded6760","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Terasology/Fluid/pulls/8/commits","review_comments_url":"https://api.github.com/repos/Terasology/Fluid/pulls/8/comments","review_comment_url":"https://api.github.com/repos/Terasology/Fluid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Terasology/Fluid/issues/8/comments","statuses_url":"https://api.github.com/repos/Terasology/Fluid/statuses/8627aaeba2821c844f3325e19803cafe73820c40","head":{"label":"Terasology:develop","ref":"develop","sha":"8627aaeba2821c844f3325e19803cafe73820c40","user":{"login":"Terasology","id":4554375,"avatar_url":"https://avatars.githubusercontent.com/u/4554375?v=3","gravatar_id":"","url":"https://api.github.com/users/Terasology","html_url":"https://github.com/Terasology","followers_url":"https://api.github.com/users/Terasology/followers","following_url":"https://api.github.com/users/Terasology/following{/other_user}","gists_url":"https://api.github.com/users/Terasology/gists{/gist_id}","starred_url":"https://api.github.com/users/Terasology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Terasology/subscriptions","organizations_url":"https://api.github.com/users/Terasology/orgs","repos_url":"https://api.github.com/users/Terasology/repos","events_url":"https://api.github.com/users/Terasology/events{/privacy}","received_events_url":"https://api.github.com/users/Terasology/received_events","type":"Organization","site_admin":false},"repo":{"id":16919535,"name":"Fluid","full_name":"Terasology/Fluid","owner":{"login":"Terasology","id":4554375,"avatar_url":"https://avatars.githubusercontent.com/u/4554375?v=3","gravatar_id":"","url":"https://api.github.com/users/Terasology","html_url":"https://github.com/Terasology","followers_url":"https://api.github.com/users/Terasology/followers","following_url":"https://api.github.com/users/Terasology/following{/other_user}","gists_url":"https://api.github.com/users/Terasology/gists{/gist_id}","starred_url":"https://api.github.com/users/Terasology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Terasology/subscriptions","organizations_url":"https://api.github.com/users/Terasology/orgs","repos_url":"https://api.github.com/users/Terasology/repos","events_url":"https://api.github.com/users/Terasology/events{/privacy}","received_events_url":"https://api.github.com/users/Terasology/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Terasology/Fluid","description":"Fluids, as opposed to liquids, relate mainly to the storage and manipulation of substances that \"flow\" (which can even be gas) - at least in our definition of game terms where liquids would be more for natural water, lava, and similar larger scale systems. In other words this is not meant as a water simulation type module.","fork":false,"url":"https://api.github.com/repos/Terasology/Fluid","forks_url":"https://api.github.com/repos/Terasology/Fluid/forks","keys_url":"https://api.github.com/repos/Terasology/Fluid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Terasology/Fluid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Terasology/Fluid/teams","hooks_url":"https://api.github.com/repos/Terasology/Fluid/hooks","issue_events_url":"https://api.github.com/repos/Terasology/Fluid/issues/events{/number}","events_url":"https://api.github.com/repos/Terasology/Fluid/events","assignees_url":"https://api.github.com/repos/Terasology/Fluid/assignees{/user}","branches_url":"https://api.github.com/repos/Terasology/Fluid/branches{/branch}","tags_url":"https://api.github.com/repos/Terasology/Fluid/tags","blobs_url":"https://api.github.com/repos/Terasology/Fluid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Terasology/Fluid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Terasology/Fluid/git/refs{/sha}","trees_url":"https://api.github.com/repos/Terasology/Fluid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Terasology/Fluid/statuses/{sha}","languages_url":"https://api.github.com/repos/Terasology/Fluid/languages","stargazers_url":"https://api.github.com/repos/Terasology/Fluid/stargazers","contributors_url":"https://api.github.com/repos/Terasology/Fluid/contributors","subscribers_url":"https://api.github.com/repos/Terasology/Fluid/subscribers","subscription_url":"https://api.github.com/repos/Terasology/Fluid/subscription","commits_url":"https://api.github.com/repos/Terasology/Fluid/commits{/sha}","git_commits_url":"https://api.github.com/repos/Terasology/Fluid/git/commits{/sha}","comments_url":"https://api.github.com/repos/Terasology/Fluid/comments{/number}","issue_comment_url":"https://api.github.com/repos/Terasology/Fluid/issues/comments{/number}","contents_url":"https://api.github.com/repos/Terasology/Fluid/contents/{+path}","compare_url":"https://api.github.com/repos/Terasology/Fluid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Terasology/Fluid/merges","archive_url":"https://api.github.com/repos/Terasology/Fluid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Terasology/Fluid/downloads","issues_url":"https://api.github.com/repos/Terasology/Fluid/issues{/number}","pulls_url":"https://api.github.com/repos/Terasology/Fluid/pulls{/number}","milestones_url":"https://api.github.com/repos/Terasology/Fluid/milestones{/number}","notifications_url":"https://api.github.com/repos/Terasology/Fluid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Terasology/Fluid/labels{/name}","releases_url":"https://api.github.com/repos/Terasology/Fluid/releases{/id}","deployments_url":"https://api.github.com/repos/Terasology/Fluid/deployments","created_at":"2014-02-17T16:48:23Z","updated_at":"2016-02-22T05:43:47Z","pushed_at":"2016-06-16T20:53:08Z","git_url":"git://github.com/Terasology/Fluid.git","ssh_url":"git@github.com:Terasology/Fluid.git","clone_url":"https://github.com/Terasology/Fluid.git","svn_url":"https://github.com/Terasology/Fluid","homepage":null,"size":87,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Terasology:master","ref":"master","sha":"eef3b2e31869ca7059f4c5dbe207cbd73bdc434e","user":{"login":"Terasology","id":4554375,"avatar_url":"https://avatars.githubusercontent.com/u/4554375?v=3","gravatar_id":"","url":"https://api.github.com/users/Terasology","html_url":"https://github.com/Terasology","followers_url":"https://api.github.com/users/Terasology/followers","following_url":"https://api.github.com/users/Terasology/following{/other_user}","gists_url":"https://api.github.com/users/Terasology/gists{/gist_id}","starred_url":"https://api.github.com/users/Terasology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Terasology/subscriptions","organizations_url":"https://api.github.com/users/Terasology/orgs","repos_url":"https://api.github.com/users/Terasology/repos","events_url":"https://api.github.com/users/Terasology/events{/privacy}","received_events_url":"https://api.github.com/users/Terasology/received_events","type":"Organization","site_admin":false},"repo":{"id":16919535,"name":"Fluid","full_name":"Terasology/Fluid","owner":{"login":"Terasology","id":4554375,"avatar_url":"https://avatars.githubusercontent.com/u/4554375?v=3","gravatar_id":"","url":"https://api.github.com/users/Terasology","html_url":"https://github.com/Terasology","followers_url":"https://api.github.com/users/Terasology/followers","following_url":"https://api.github.com/users/Terasology/following{/other_user}","gists_url":"https://api.github.com/users/Terasology/gists{/gist_id}","starred_url":"https://api.github.com/users/Terasology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Terasology/subscriptions","organizations_url":"https://api.github.com/users/Terasology/orgs","repos_url":"https://api.github.com/users/Terasology/repos","events_url":"https://api.github.com/users/Terasology/events{/privacy}","received_events_url":"https://api.github.com/users/Terasology/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Terasology/Fluid","description":"Fluids, as opposed to liquids, relate mainly to the storage and manipulation of substances that \"flow\" (which can even be gas) - at least in our definition of game terms where liquids would be more for natural water, lava, and similar larger scale systems. In other words this is not meant as a water simulation type module.","fork":false,"url":"https://api.github.com/repos/Terasology/Fluid","forks_url":"https://api.github.com/repos/Terasology/Fluid/forks","keys_url":"https://api.github.com/repos/Terasology/Fluid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Terasology/Fluid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Terasology/Fluid/teams","hooks_url":"https://api.github.com/repos/Terasology/Fluid/hooks","issue_events_url":"https://api.github.com/repos/Terasology/Fluid/issues/events{/number}","events_url":"https://api.github.com/repos/Terasology/Fluid/events","assignees_url":"https://api.github.com/repos/Terasology/Fluid/assignees{/user}","branches_url":"https://api.github.com/repos/Terasology/Fluid/branches{/branch}","tags_url":"https://api.github.com/repos/Terasology/Fluid/tags","blobs_url":"https://api.github.com/repos/Terasology/Fluid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Terasology/Fluid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Terasology/Fluid/git/refs{/sha}","trees_url":"https://api.github.com/repos/Terasology/Fluid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Terasology/Fluid/statuses/{sha}","languages_url":"https://api.github.com/repos/Terasology/Fluid/languages","stargazers_url":"https://api.github.com/repos/Terasology/Fluid/stargazers","contributors_url":"https://api.github.com/repos/Terasology/Fluid/contributors","subscribers_url":"https://api.github.com/repos/Terasology/Fluid/subscribers","subscription_url":"https://api.github.com/repos/Terasology/Fluid/subscription","commits_url":"https://api.github.com/repos/Terasology/Fluid/commits{/sha}","git_commits_url":"https://api.github.com/repos/Terasology/Fluid/git/commits{/sha}","comments_url":"https://api.github.com/repos/Terasology/Fluid/comments{/number}","issue_comment_url":"https://api.github.com/repos/Terasology/Fluid/issues/comments{/number}","contents_url":"https://api.github.com/repos/Terasology/Fluid/contents/{+path}","compare_url":"https://api.github.com/repos/Terasology/Fluid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Terasology/Fluid/merges","archive_url":"https://api.github.com/repos/Terasology/Fluid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Terasology/Fluid/downloads","issues_url":"https://api.github.com/repos/Terasology/Fluid/issues{/number}","pulls_url":"https://api.github.com/repos/Terasology/Fluid/pulls{/number}","milestones_url":"https://api.github.com/repos/Terasology/Fluid/milestones{/number}","notifications_url":"https://api.github.com/repos/Terasology/Fluid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Terasology/Fluid/labels{/name}","releases_url":"https://api.github.com/repos/Terasology/Fluid/releases{/id}","deployments_url":"https://api.github.com/repos/Terasology/Fluid/deployments","created_at":"2014-02-17T16:48:23Z","updated_at":"2016-02-22T05:43:47Z","pushed_at":"2016-06-16T20:53:08Z","git_url":"git://github.com/Terasology/Fluid.git","ssh_url":"git@github.com:Terasology/Fluid.git","clone_url":"https://github.com/Terasology/Fluid.git","svn_url":"https://github.com/Terasology/Fluid","homepage":null,"size":87,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Terasology/Fluid/pulls/8"},"html":{"href":"https://github.com/Terasology/Fluid/pull/8"},"issue":{"href":"https://api.github.com/repos/Terasology/Fluid/issues/8"},"comments":{"href":"https://api.github.com/repos/Terasology/Fluid/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/Terasology/Fluid/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/Terasology/Fluid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Terasology/Fluid/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/Terasology/Fluid/statuses/8627aaeba2821c844f3325e19803cafe73820c40"}}}}
{"actor":{"display_login":"Josharias"}}