{"action":"created","issue":{"url":"https://api.github.com/repos/helena-project/tock/issues/103","repository_url":"https://api.github.com/repos/helena-project/tock","labels_url":"https://api.github.com/repos/helena-project/tock/issues/103/labels{/name}","comments_url":"https://api.github.com/repos/helena-project/tock/issues/103/comments","events_url":"https://api.github.com/repos/helena-project/tock/issues/103/events","html_url":"https://github.com/helena-project/tock/issues/103","id":173315595,"number":103,"title":"Consider splitting error out of `command_complete` interface","user":{"login":"ppannuto","id":339422,"avatar_url":"https://avatars.githubusercontent.com/u/339422?v=3","gravatar_id":"","url":"https://api.github.com/users/ppannuto","html_url":"https://github.com/ppannuto","followers_url":"https://api.github.com/users/ppannuto/followers","following_url":"https://api.github.com/users/ppannuto/following{/other_user}","gists_url":"https://api.github.com/users/ppannuto/gists{/gist_id}","starred_url":"https://api.github.com/users/ppannuto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppannuto/subscriptions","organizations_url":"https://api.github.com/users/ppannuto/orgs","repos_url":"https://api.github.com/users/ppannuto/repos","events_url":"https://api.github.com/users/ppannuto/events{/privacy}","received_events_url":"https://api.github.com/users/ppannuto/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-08-25T21:33:13Z","updated_at":"2016-08-25T23:53:48Z","closed_at":null,"body":"Inspired by https://github.com/helena-project/tock/pull/102/files#diff-6c77447f4906f04d927a4237b1655082L46\r\n\r\nDoes error as a parameter encourage implementers to simply ignore / not check error? Would we possibly better with separate `command_complete` and `command_error` traits? Sure, people could implement empty error functions, but that seems harder to mess up than forgetting / not bothering to check the error value."},"comment":{"url":"https://api.github.com/repos/helena-project/tock/issues/comments/242582252","html_url":"https://github.com/helena-project/tock/issues/103#issuecomment-242582252","issue_url":"https://api.github.com/repos/helena-project/tock/issues/103","id":242582252,"user":{"login":"phil-levis","id":4306795,"avatar_url":"https://avatars.githubusercontent.com/u/4306795?v=3","gravatar_id":"","url":"https://api.github.com/users/phil-levis","html_url":"https://github.com/phil-levis","followers_url":"https://api.github.com/users/phil-levis/followers","following_url":"https://api.github.com/users/phil-levis/following{/other_user}","gists_url":"https://api.github.com/users/phil-levis/gists{/gist_id}","starred_url":"https://api.github.com/users/phil-levis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil-levis/subscriptions","organizations_url":"https://api.github.com/users/phil-levis/orgs","repos_url":"https://api.github.com/users/phil-levis/repos","events_url":"https://api.github.com/users/phil-levis/events{/privacy}","received_events_url":"https://api.github.com/users/phil-levis/received_events","type":"User","site_admin":false},"created_at":"2016-08-25T23:53:48Z","updated_at":"2016-08-25T23:53:48Z","body":"We went back and forth on this for a long time in TinyOS, with a lot of experiences with both approaches. The eventual conclusion was that having an error parameter was better, often because there is shared code between both successful and failed operations."}}
{"actor":{"display_login":"phil-levis"}}