{"action":"created","comment":{"url":"https://api.github.com/repos/ScottLogic/BitFlux/pulls/comments/58356320","id":58356320,"diff_hunk":"@@ -61,5 +64,13 @@ export default function() {\n         zoomWidth = util.width(container.node()) - yAxisWidth;\n     };\n \n+    secondary.minimumVisiblePeriods = function(x) {","path":"src/assets/js/chart/secondary/base.js","position":28,"original_position":28,"commit_id":"2a94a8aae0b81bc39e0af5c7194cd6bc73554118","original_commit_id":"2a94a8aae0b81bc39e0af5c7194cd6bc73554118","user":{"login":"jdhodges","id":14218569,"avatar_url":"https://avatars.githubusercontent.com/u/14218569?v=3","gravatar_id":"","url":"https://api.github.com/users/jdhodges","html_url":"https://github.com/jdhodges","followers_url":"https://api.github.com/users/jdhodges/followers","following_url":"https://api.github.com/users/jdhodges/following{/other_user}","gists_url":"https://api.github.com/users/jdhodges/gists{/gist_id}","starred_url":"https://api.github.com/users/jdhodges/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdhodges/subscriptions","organizations_url":"https://api.github.com/users/jdhodges/orgs","repos_url":"https://api.github.com/users/jdhodges/repos","events_url":"https://api.github.com/users/jdhodges/events{/privacy}","received_events_url":"https://api.github.com/users/jdhodges/received_events","type":"User","site_admin":false},"body":"Don't think this is needed, `minimumVisiblePeriods` should still be in `model`.","created_at":"2016-04-04T10:33:19Z","updated_at":"2016-04-04T10:33:19Z","html_url":"https://github.com/ScottLogic/BitFlux/pull/722#discussion_r58356320","pull_request_url":"https://api.github.com/repos/ScottLogic/BitFlux/pulls/722","_links":{"self":{"href":"https://api.github.com/repos/ScottLogic/BitFlux/pulls/comments/58356320"},"html":{"href":"https://github.com/ScottLogic/BitFlux/pull/722#discussion_r58356320"},"pull_request":{"href":"https://api.github.com/repos/ScottLogic/BitFlux/pulls/722"}}},"pull_request":{"url":"https://api.github.com/repos/ScottLogic/BitFlux/pulls/722","id":65122452,"html_url":"https://github.com/ScottLogic/BitFlux/pull/722","diff_url":"https://github.com/ScottLogic/BitFlux/pull/722.diff","patch_url":"https://github.com/ScottLogic/BitFlux/pull/722.patch","issue_url":"https://api.github.com/repos/ScottLogic/BitFlux/issues/722","number":722,"state":"open","locked":false,"title":"Limited zoom to 5 periods - now working with discontinued weekends","user":{"login":"rjmcneill","id":10117342,"avatar_url":"https://avatars.githubusercontent.com/u/10117342?v=3","gravatar_id":"","url":"https://api.github.com/users/rjmcneill","html_url":"https://github.com/rjmcneill","followers_url":"https://api.github.com/users/rjmcneill/followers","following_url":"https://api.github.com/users/rjmcneill/following{/other_user}","gists_url":"https://api.github.com/users/rjmcneill/gists{/gist_id}","starred_url":"https://api.github.com/users/rjmcneill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjmcneill/subscriptions","organizations_url":"https://api.github.com/users/rjmcneill/orgs","repos_url":"https://api.github.com/users/rjmcneill/repos","events_url":"https://api.github.com/users/rjmcneill/events{/privacy}","received_events_url":"https://api.github.com/users/rjmcneill/received_events","type":"User","site_admin":false},"body":"Relates to #499 \r\nRelates to #168 \r\nReplaces and closes #525 ","created_at":"2016-04-04T10:16:32Z","updated_at":"2016-04-04T10:33:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0821005e4cc25cc26fdd7a314d524e7135855d83","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ScottLogic/BitFlux/pulls/722/commits","review_comments_url":"https://api.github.com/repos/ScottLogic/BitFlux/pulls/722/comments","review_comment_url":"https://api.github.com/repos/ScottLogic/BitFlux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ScottLogic/BitFlux/issues/722/comments","statuses_url":"https://api.github.com/repos/ScottLogic/BitFlux/statuses/2a94a8aae0b81bc39e0af5c7194cd6bc73554118","head":{"label":"rjmcneill:bug/limit-zoom-new","ref":"bug/limit-zoom-new","sha":"2a94a8aae0b81bc39e0af5c7194cd6bc73554118","user":{"login":"rjmcneill","id":10117342,"avatar_url":"https://avatars.githubusercontent.com/u/10117342?v=3","gravatar_id":"","url":"https://api.github.com/users/rjmcneill","html_url":"https://github.com/rjmcneill","followers_url":"https://api.github.com/users/rjmcneill/followers","following_url":"https://api.github.com/users/rjmcneill/following{/other_user}","gists_url":"https://api.github.com/users/rjmcneill/gists{/gist_id}","starred_url":"https://api.github.com/users/rjmcneill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjmcneill/subscriptions","organizations_url":"https://api.github.com/users/rjmcneill/orgs","repos_url":"https://api.github.com/users/rjmcneill/repos","events_url":"https://api.github.com/users/rjmcneill/events{/privacy}","received_events_url":"https://api.github.com/users/rjmcneill/received_events","type":"User","site_admin":false},"repo":{"id":44965754,"name":"d3fc-showcase","full_name":"rjmcneill/d3fc-showcase","owner":{"login":"rjmcneill","id":10117342,"avatar_url":"https://avatars.githubusercontent.com/u/10117342?v=3","gravatar_id":"","url":"https://api.github.com/users/rjmcneill","html_url":"https://github.com/rjmcneill","followers_url":"https://api.github.com/users/rjmcneill/followers","following_url":"https://api.github.com/users/rjmcneill/following{/other_user}","gists_url":"https://api.github.com/users/rjmcneill/gists{/gist_id}","starred_url":"https://api.github.com/users/rjmcneill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjmcneill/subscriptions","organizations_url":"https://api.github.com/users/rjmcneill/orgs","repos_url":"https://api.github.com/users/rjmcneill/repos","events_url":"https://api.github.com/users/rjmcneill/events{/privacy}","received_events_url":"https://api.github.com/users/rjmcneill/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rjmcneill/d3fc-showcase","description":"A cross-platform financial charting application to showcase the functionality of d3fc components.","fork":true,"url":"https://api.github.com/repos/rjmcneill/d3fc-showcase","forks_url":"https://api.github.com/repos/rjmcneill/d3fc-showcase/forks","keys_url":"https://api.github.com/repos/rjmcneill/d3fc-showcase/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rjmcneill/d3fc-showcase/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rjmcneill/d3fc-showcase/teams","hooks_url":"https://api.github.com/repos/rjmcneill/d3fc-showcase/hooks","issue_events_url":"https://api.github.com/repos/rjmcneill/d3fc-showcase/issues/events{/number}","events_url":"https://api.github.com/repos/rjmcneill/d3fc-showcase/events","assignees_url":"https://api.github.com/repos/rjmcneill/d3fc-showcase/assignees{/user}","branches_url":"https://api.github.com/repos/rjmcneill/d3fc-showcase/branches{/branch}","tags_url":"https://api.github.com/repos/rjmcneill/d3fc-showcase/tags","blobs_url":"https://api.github.com/repos/rjmcneill/d3fc-showcase/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rjmcneill/d3fc-showcase/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rjmcneill/d3fc-showcase/git/refs{/sha}","trees_url":"https://api.github.com/repos/rjmcneill/d3fc-showcase/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rjmcneill/d3fc-showcase/statuses/{sha}","languages_url":"https://api.github.com/repos/rjmcneill/d3fc-showcase/languages","stargazers_url":"https://api.github.com/repos/rjmcneill/d3fc-showcase/stargazers","contributors_url":"https://api.github.com/repos/rjmcneill/d3fc-showcase/contributors","subscribers_url":"https://api.github.com/repos/rjmcneill/d3fc-showcase/subscribers","subscription_url":"https://api.github.com/repos/rjmcneill/d3fc-showcase/subscription","commits_url":"https://api.github.com/repos/rjmcneill/d3fc-showcase/commits{/sha}","git_commits_url":"https://api.github.com/repos/rjmcneill/d3fc-showcase/git/commits{/sha}","comments_url":"https://api.github.com/repos/rjmcneill/d3fc-showcase/comments{/number}","issue_comment_url":"https://api.github.com/repos/rjmcneill/d3fc-showcase/issues/comments{/number}","contents_url":"https://api.github.com/repos/rjmcneill/d3fc-showcase/contents/{+path}","compare_url":"https://api.github.com/repos/rjmcneill/d3fc-showcase/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rjmcneill/d3fc-showcase/merges","archive_url":"https://api.github.com/repos/rjmcneill/d3fc-showcase/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rjmcneill/d3fc-showcase/downloads","issues_url":"https://api.github.com/repos/rjmcneill/d3fc-showcase/issues{/number}","pulls_url":"https://api.github.com/repos/rjmcneill/d3fc-showcase/pulls{/number}","milestones_url":"https://api.github.com/repos/rjmcneill/d3fc-showcase/milestones{/number}","notifications_url":"https://api.github.com/repos/rjmcneill/d3fc-showcase/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rjmcneill/d3fc-showcase/labels{/name}","releases_url":"https://api.github.com/repos/rjmcneill/d3fc-showcase/releases{/id}","deployments_url":"https://api.github.com/repos/rjmcneill/d3fc-showcase/deployments","created_at":"2015-10-26T12:03:38Z","updated_at":"2016-01-11T10:56:44Z","pushed_at":"2016-04-04T10:27:21Z","git_url":"git://github.com/rjmcneill/d3fc-showcase.git","ssh_url":"git@github.com:rjmcneill/d3fc-showcase.git","clone_url":"https://github.com/rjmcneill/d3fc-showcase.git","svn_url":"https://github.com/rjmcneill/d3fc-showcase","homepage":"http://scottlogic.github.io/d3fc-showcase/","size":2691,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ScottLogic:develop","ref":"develop","sha":"9df4ed47455cb02c615a688f257af3ae0bf470df","user":{"login":"ScottLogic","id":2046037,"avatar_url":"https://avatars.githubusercontent.com/u/2046037?v=3","gravatar_id":"","url":"https://api.github.com/users/ScottLogic","html_url":"https://github.com/ScottLogic","followers_url":"https://api.github.com/users/ScottLogic/followers","following_url":"https://api.github.com/users/ScottLogic/following{/other_user}","gists_url":"https://api.github.com/users/ScottLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/ScottLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScottLogic/subscriptions","organizations_url":"https://api.github.com/users/ScottLogic/orgs","repos_url":"https://api.github.com/users/ScottLogic/repos","events_url":"https://api.github.com/users/ScottLogic/events{/privacy}","received_events_url":"https://api.github.com/users/ScottLogic/received_events","type":"Organization","site_admin":false},"repo":{"id":39064095,"name":"BitFlux","full_name":"ScottLogic/BitFlux","owner":{"login":"ScottLogic","id":2046037,"avatar_url":"https://avatars.githubusercontent.com/u/2046037?v=3","gravatar_id":"","url":"https://api.github.com/users/ScottLogic","html_url":"https://github.com/ScottLogic","followers_url":"https://api.github.com/users/ScottLogic/followers","following_url":"https://api.github.com/users/ScottLogic/following{/other_user}","gists_url":"https://api.github.com/users/ScottLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/ScottLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScottLogic/subscriptions","organizations_url":"https://api.github.com/users/ScottLogic/orgs","repos_url":"https://api.github.com/users/ScottLogic/repos","events_url":"https://api.github.com/users/ScottLogic/events{/privacy}","received_events_url":"https://api.github.com/users/ScottLogic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ScottLogic/BitFlux","description":"A cross-platform financial charting application to showcase the functionality of d3fc components.","fork":false,"url":"https://api.github.com/repos/ScottLogic/BitFlux","forks_url":"https://api.github.com/repos/ScottLogic/BitFlux/forks","keys_url":"https://api.github.com/repos/ScottLogic/BitFlux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ScottLogic/BitFlux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ScottLogic/BitFlux/teams","hooks_url":"https://api.github.com/repos/ScottLogic/BitFlux/hooks","issue_events_url":"https://api.github.com/repos/ScottLogic/BitFlux/issues/events{/number}","events_url":"https://api.github.com/repos/ScottLogic/BitFlux/events","assignees_url":"https://api.github.com/repos/ScottLogic/BitFlux/assignees{/user}","branches_url":"https://api.github.com/repos/ScottLogic/BitFlux/branches{/branch}","tags_url":"https://api.github.com/repos/ScottLogic/BitFlux/tags","blobs_url":"https://api.github.com/repos/ScottLogic/BitFlux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ScottLogic/BitFlux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ScottLogic/BitFlux/git/refs{/sha}","trees_url":"https://api.github.com/repos/ScottLogic/BitFlux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ScottLogic/BitFlux/statuses/{sha}","languages_url":"https://api.github.com/repos/ScottLogic/BitFlux/languages","stargazers_url":"https://api.github.com/repos/ScottLogic/BitFlux/stargazers","contributors_url":"https://api.github.com/repos/ScottLogic/BitFlux/contributors","subscribers_url":"https://api.github.com/repos/ScottLogic/BitFlux/subscribers","subscription_url":"https://api.github.com/repos/ScottLogic/BitFlux/subscription","commits_url":"https://api.github.com/repos/ScottLogic/BitFlux/commits{/sha}","git_commits_url":"https://api.github.com/repos/ScottLogic/BitFlux/git/commits{/sha}","comments_url":"https://api.github.com/repos/ScottLogic/BitFlux/comments{/number}","issue_comment_url":"https://api.github.com/repos/ScottLogic/BitFlux/issues/comments{/number}","contents_url":"https://api.github.com/repos/ScottLogic/BitFlux/contents/{+path}","compare_url":"https://api.github.com/repos/ScottLogic/BitFlux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ScottLogic/BitFlux/merges","archive_url":"https://api.github.com/repos/ScottLogic/BitFlux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ScottLogic/BitFlux/downloads","issues_url":"https://api.github.com/repos/ScottLogic/BitFlux/issues{/number}","pulls_url":"https://api.github.com/repos/ScottLogic/BitFlux/pulls{/number}","milestones_url":"https://api.github.com/repos/ScottLogic/BitFlux/milestones{/number}","notifications_url":"https://api.github.com/repos/ScottLogic/BitFlux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ScottLogic/BitFlux/labels{/name}","releases_url":"https://api.github.com/repos/ScottLogic/BitFlux/releases{/id}","deployments_url":"https://api.github.com/repos/ScottLogic/BitFlux/deployments","created_at":"2015-07-14T08:47:46Z","updated_at":"2016-03-21T06:41:10Z","pushed_at":"2016-04-04T10:27:22Z","git_url":"git://github.com/ScottLogic/BitFlux.git","ssh_url":"git@github.com:ScottLogic/BitFlux.git","clone_url":"https://github.com/ScottLogic/BitFlux.git","svn_url":"https://github.com/ScottLogic/BitFlux","homepage":"http://scottlogic.github.io/BitFlux/","size":2624,"stargazers_count":19,"watchers_count":19,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":11,"mirror_url":null,"open_issues_count":119,"forks":11,"open_issues":119,"watchers":19,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ScottLogic/BitFlux/pulls/722"},"html":{"href":"https://github.com/ScottLogic/BitFlux/pull/722"},"issue":{"href":"https://api.github.com/repos/ScottLogic/BitFlux/issues/722"},"comments":{"href":"https://api.github.com/repos/ScottLogic/BitFlux/issues/722/comments"},"review_comments":{"href":"https://api.github.com/repos/ScottLogic/BitFlux/pulls/722/comments"},"review_comment":{"href":"https://api.github.com/repos/ScottLogic/BitFlux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ScottLogic/BitFlux/pulls/722/commits"},"statuses":{"href":"https://api.github.com/repos/ScottLogic/BitFlux/statuses/2a94a8aae0b81bc39e0af5c7194cd6bc73554118"}}}}