{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/73929951","id":73929951,"diff_hunk":"@@ -3203,6 +3203,9 @@ void GetTimeStampsForNativeImage(CORCOMPILE_VERSION_INFO * pNativeVersionInfo)\n #endif // FEATURE_CORECLR\n }\n \n+static constexpr uint32_t CMOVFlags = 0x00008001;\n+static constexpr uint32_t SSE2Flags = 0x04000000;","path":"src/vm/domainfile.cpp","position":5,"original_position":5,"commit_id":"bcb406196e98e9a6867eda81b382b6af8dbd39f2","original_commit_id":"bcb406196e98e9a6867eda81b382b6af8dbd39f2","user":{"login":"BruceForstall","id":10901265,"avatar_url":"https://avatars.githubusercontent.com/u/10901265?v=3","gravatar_id":"","url":"https://api.github.com/users/BruceForstall","html_url":"https://github.com/BruceForstall","followers_url":"https://api.github.com/users/BruceForstall/followers","following_url":"https://api.github.com/users/BruceForstall/following{/other_user}","gists_url":"https://api.github.com/users/BruceForstall/gists{/gist_id}","starred_url":"https://api.github.com/users/BruceForstall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BruceForstall/subscriptions","organizations_url":"https://api.github.com/users/BruceForstall/orgs","repos_url":"https://api.github.com/users/BruceForstall/repos","events_url":"https://api.github.com/users/BruceForstall/events{/privacy}","received_events_url":"https://api.github.com/users/BruceForstall/received_events","type":"User","site_admin":false},"body":"The compiler we build our TFS mirror with is older (I don't know why...) and doesn't have support for `constexpr`, so this will cause a build break for our internal builds. (The compiler version is 18.10.40116.6 -- an internal VS2013+ build?). You won't see `constexpr` anywhere else in the code.","created_at":"2016-08-08T18:39:19Z","updated_at":"2016-08-08T18:39:19Z","html_url":"https://github.com/dotnet/coreclr/pull/6647#discussion_r73929951","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/6647","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/73929951"},"html":{"href":"https://github.com/dotnet/coreclr/pull/6647#discussion_r73929951"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/6647"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/6647","id":80377994,"html_url":"https://github.com/dotnet/coreclr/pull/6647","diff_url":"https://github.com/dotnet/coreclr/pull/6647.diff","patch_url":"https://github.com/dotnet/coreclr/pull/6647.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/6647","number":6647,"state":"open","locked":false,"title":"Enable crossgen to use SSE2 instructions for x86","user":{"login":"jamesqo","id":9159214,"avatar_url":"https://avatars.githubusercontent.com/u/9159214?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesqo","html_url":"https://github.com/jamesqo","followers_url":"https://api.github.com/users/jamesqo/followers","following_url":"https://api.github.com/users/jamesqo/following{/other_user}","gists_url":"https://api.github.com/users/jamesqo/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesqo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesqo/subscriptions","organizations_url":"https://api.github.com/users/jamesqo/orgs","repos_url":"https://api.github.com/users/jamesqo/repos","events_url":"https://api.github.com/users/jamesqo/events{/privacy}","received_events_url":"https://api.github.com/users/jamesqo/received_events","type":"User","site_admin":false},"body":"crossgen currently doesn't generate SSE instructions of any kind for x86, which was causing issues in #6638 when I was attempting to use it with 16-and-larger byte types. This change enables it to use SSE2 instructions, dropping support for processors that don't support that.\r\n\r\n[Here](https://gist.githubusercontent.com/jamesqo/2311301df084e20ab6265fdbff382fbe/raw/0c585a9bc4278c0a011e423b2a95b18687653802/MovqXmm.output) is the gist that results when I dump the disassembly of every method in the `System.Private.CoreLib` native image, and grep for `xmm`.\r\n\r\nNotes:\r\n\r\n- According [to Wikipedia](https://en.wikipedia.org/wiki/SSE2) Pentium 4 (which is targeted for the framework) already supports SSE2, so there's no reason not to enable this for the framework.\r\n- The region ifdef'd under `FEATURE_CORECLR` seems to target Pentium Pro ([released in 1995](https://en.wikipedia.org/wiki/Pentium_Pro)), an *older* processor than Pentium 4. Since this has no support for SSE, I just deleted this and retargeted it to Pentium 4.\r\n- Removed `ifndef` for CoreCLR that contained a call to `GetSpecificCpuInfo`, which is presumably querying the actual processor's features at runtime. Is there any reason this wasn't enabled before?\r\n\r\ncc @jkotas @benaadams @tannergooding @mikedn","created_at":"2016-08-07T21:06:08Z","updated_at":"2016-08-08T18:39:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"98448422e2f8e77039496969a880dc013870ce3c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/6647/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/6647/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/6647/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/bcb406196e98e9a6867eda81b382b6af8dbd39f2","head":{"label":"jamesqo:enable-sse2","ref":"enable-sse2","sha":"bcb406196e98e9a6867eda81b382b6af8dbd39f2","user":{"login":"jamesqo","id":9159214,"avatar_url":"https://avatars.githubusercontent.com/u/9159214?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesqo","html_url":"https://github.com/jamesqo","followers_url":"https://api.github.com/users/jamesqo/followers","following_url":"https://api.github.com/users/jamesqo/following{/other_user}","gists_url":"https://api.github.com/users/jamesqo/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesqo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesqo/subscriptions","organizations_url":"https://api.github.com/users/jamesqo/orgs","repos_url":"https://api.github.com/users/jamesqo/repos","events_url":"https://api.github.com/users/jamesqo/events{/privacy}","received_events_url":"https://api.github.com/users/jamesqo/received_events","type":"User","site_admin":false},"repo":{"id":37690478,"name":"coreclr","full_name":"jamesqo/coreclr","owner":{"login":"jamesqo","id":9159214,"avatar_url":"https://avatars.githubusercontent.com/u/9159214?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesqo","html_url":"https://github.com/jamesqo","followers_url":"https://api.github.com/users/jamesqo/followers","following_url":"https://api.github.com/users/jamesqo/following{/other_user}","gists_url":"https://api.github.com/users/jamesqo/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesqo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesqo/subscriptions","organizations_url":"https://api.github.com/users/jamesqo/orgs","repos_url":"https://api.github.com/users/jamesqo/repos","events_url":"https://api.github.com/users/jamesqo/events{/privacy}","received_events_url":"https://api.github.com/users/jamesqo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jamesqo/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":true,"url":"https://api.github.com/repos/jamesqo/coreclr","forks_url":"https://api.github.com/repos/jamesqo/coreclr/forks","keys_url":"https://api.github.com/repos/jamesqo/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jamesqo/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jamesqo/coreclr/teams","hooks_url":"https://api.github.com/repos/jamesqo/coreclr/hooks","issue_events_url":"https://api.github.com/repos/jamesqo/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/jamesqo/coreclr/events","assignees_url":"https://api.github.com/repos/jamesqo/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/jamesqo/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/jamesqo/coreclr/tags","blobs_url":"https://api.github.com/repos/jamesqo/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jamesqo/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jamesqo/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/jamesqo/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jamesqo/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/jamesqo/coreclr/languages","stargazers_url":"https://api.github.com/repos/jamesqo/coreclr/stargazers","contributors_url":"https://api.github.com/repos/jamesqo/coreclr/contributors","subscribers_url":"https://api.github.com/repos/jamesqo/coreclr/subscribers","subscription_url":"https://api.github.com/repos/jamesqo/coreclr/subscription","commits_url":"https://api.github.com/repos/jamesqo/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/jamesqo/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/jamesqo/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/jamesqo/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/jamesqo/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/jamesqo/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jamesqo/coreclr/merges","archive_url":"https://api.github.com/repos/jamesqo/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jamesqo/coreclr/downloads","issues_url":"https://api.github.com/repos/jamesqo/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/jamesqo/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/jamesqo/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/jamesqo/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jamesqo/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/jamesqo/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/jamesqo/coreclr/deployments","created_at":"2015-06-18T23:12:00Z","updated_at":"2016-07-30T03:18:02Z","pushed_at":"2016-08-08T17:27:02Z","git_url":"git://github.com/jamesqo/coreclr.git","ssh_url":"git@github.com:jamesqo/coreclr.git","clone_url":"https://github.com/jamesqo/coreclr.git","svn_url":"https://github.com/jamesqo/coreclr","homepage":"http://dotnet.github.io/core/","size":94478,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"5976ffa9a624bd05bbb0d67a742e89bc9f16d1dc","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2016-08-08T11:08:20Z","pushed_at":"2016-08-08T18:30:58Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://docs.microsoft.com/dotnet/","size":105852,"stargazers_count":6766,"watchers_count":6766,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1592,"mirror_url":null,"open_issues_count":913,"forks":1592,"open_issues":913,"watchers":6766,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/6647"},"html":{"href":"https://github.com/dotnet/coreclr/pull/6647"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/6647"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/6647/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/6647/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/6647/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/bcb406196e98e9a6867eda81b382b6af8dbd39f2"}}}}
{"actor":{"display_login":"BruceForstall"}}