{"action":"closed","number":412,"pull_request":{"url":"https://api.github.com/repos/macvim-dev/macvim/pulls/412","id":94527653,"html_url":"https://github.com/macvim-dev/macvim/pull/412","diff_url":"https://github.com/macvim-dev/macvim/pull/412.diff","patch_url":"https://github.com/macvim-dev/macvim/pull/412.patch","issue_url":"https://api.github.com/repos/macvim-dev/macvim/issues/412","number":412,"state":"closed","locked":false,"title":"fix up core graphics full-screen animations","user":{"login":"osheroff","id":260084,"avatar_url":"https://avatars.githubusercontent.com/u/260084?v=3","gravatar_id":"","url":"https://api.github.com/users/osheroff","html_url":"https://github.com/osheroff","followers_url":"https://api.github.com/users/osheroff/followers","following_url":"https://api.github.com/users/osheroff/following{/other_user}","gists_url":"https://api.github.com/users/osheroff/gists{/gist_id}","starred_url":"https://api.github.com/users/osheroff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osheroff/subscriptions","organizations_url":"https://api.github.com/users/osheroff/orgs","repos_url":"https://api.github.com/users/osheroff/repos","events_url":"https://api.github.com/users/osheroff/events{/privacy}","received_events_url":"https://api.github.com/users/osheroff/received_events","type":"User","site_admin":false},"body":"This improves a \"flickering\" seen when entering and exiting full-screen, which is due to the layer code incorrectly drawing the non-fullscreen layer (often with the vim command `set invfu`) as an intermediate state.  Here we just tell the layer code to draw an empty screen until it receives the \"redraw-the-screen\" batch of commands from vim.\r\n\r\nThis solution isn't 100%, as it doesn't seem possible to control just when cocoa actually does work; sometimes the resize of the window doesn't take affect until some milliseconds after we start fading up into fullscreen, which means you catch a dim view of the old title bar whilst fading up.  Conversely, sometimes when exiting fullscreen the resize event hasn't taken place yet and you end \r\nfading out and then still painting the fullscreen window.\r\n\r\nIn short; I think this improves things, but not all the way.","created_at":"2016-11-20T18:45:17Z","updated_at":"2016-11-23T05:45:58Z","closed_at":"2016-11-23T05:45:58Z","merged_at":null,"merge_commit_sha":"323ff39b3dca51f402183d6f50fbe300d203540e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/macvim-dev/macvim/pulls/412/commits","review_comments_url":"https://api.github.com/repos/macvim-dev/macvim/pulls/412/comments","review_comment_url":"https://api.github.com/repos/macvim-dev/macvim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/macvim-dev/macvim/issues/412/comments","statuses_url":"https://api.github.com/repos/macvim-dev/macvim/statuses/991562d2f47a94bb03ad9df446fc60c134e134ab","head":{"label":"osheroff:blank_coretext_during_fullscreen_enter","ref":"blank_coretext_during_fullscreen_enter","sha":"991562d2f47a94bb03ad9df446fc60c134e134ab","user":{"login":"osheroff","id":260084,"avatar_url":"https://avatars.githubusercontent.com/u/260084?v=3","gravatar_id":"","url":"https://api.github.com/users/osheroff","html_url":"https://github.com/osheroff","followers_url":"https://api.github.com/users/osheroff/followers","following_url":"https://api.github.com/users/osheroff/following{/other_user}","gists_url":"https://api.github.com/users/osheroff/gists{/gist_id}","starred_url":"https://api.github.com/users/osheroff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osheroff/subscriptions","organizations_url":"https://api.github.com/users/osheroff/orgs","repos_url":"https://api.github.com/users/osheroff/repos","events_url":"https://api.github.com/users/osheroff/events{/privacy}","received_events_url":"https://api.github.com/users/osheroff/received_events","type":"User","site_admin":false},"repo":{"id":73670745,"name":"macvim","full_name":"osheroff/macvim","owner":{"login":"osheroff","id":260084,"avatar_url":"https://avatars.githubusercontent.com/u/260084?v=3","gravatar_id":"","url":"https://api.github.com/users/osheroff","html_url":"https://github.com/osheroff","followers_url":"https://api.github.com/users/osheroff/followers","following_url":"https://api.github.com/users/osheroff/following{/other_user}","gists_url":"https://api.github.com/users/osheroff/gists{/gist_id}","starred_url":"https://api.github.com/users/osheroff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osheroff/subscriptions","organizations_url":"https://api.github.com/users/osheroff/orgs","repos_url":"https://api.github.com/users/osheroff/repos","events_url":"https://api.github.com/users/osheroff/events{/privacy}","received_events_url":"https://api.github.com/users/osheroff/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/osheroff/macvim","description":"Vim - the text editor - for Mac OS X","fork":true,"url":"https://api.github.com/repos/osheroff/macvim","forks_url":"https://api.github.com/repos/osheroff/macvim/forks","keys_url":"https://api.github.com/repos/osheroff/macvim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/osheroff/macvim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/osheroff/macvim/teams","hooks_url":"https://api.github.com/repos/osheroff/macvim/hooks","issue_events_url":"https://api.github.com/repos/osheroff/macvim/issues/events{/number}","events_url":"https://api.github.com/repos/osheroff/macvim/events","assignees_url":"https://api.github.com/repos/osheroff/macvim/assignees{/user}","branches_url":"https://api.github.com/repos/osheroff/macvim/branches{/branch}","tags_url":"https://api.github.com/repos/osheroff/macvim/tags","blobs_url":"https://api.github.com/repos/osheroff/macvim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/osheroff/macvim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/osheroff/macvim/git/refs{/sha}","trees_url":"https://api.github.com/repos/osheroff/macvim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/osheroff/macvim/statuses/{sha}","languages_url":"https://api.github.com/repos/osheroff/macvim/languages","stargazers_url":"https://api.github.com/repos/osheroff/macvim/stargazers","contributors_url":"https://api.github.com/repos/osheroff/macvim/contributors","subscribers_url":"https://api.github.com/repos/osheroff/macvim/subscribers","subscription_url":"https://api.github.com/repos/osheroff/macvim/subscription","commits_url":"https://api.github.com/repos/osheroff/macvim/commits{/sha}","git_commits_url":"https://api.github.com/repos/osheroff/macvim/git/commits{/sha}","comments_url":"https://api.github.com/repos/osheroff/macvim/comments{/number}","issue_comment_url":"https://api.github.com/repos/osheroff/macvim/issues/comments{/number}","contents_url":"https://api.github.com/repos/osheroff/macvim/contents/{+path}","compare_url":"https://api.github.com/repos/osheroff/macvim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/osheroff/macvim/merges","archive_url":"https://api.github.com/repos/osheroff/macvim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/osheroff/macvim/downloads","issues_url":"https://api.github.com/repos/osheroff/macvim/issues{/number}","pulls_url":"https://api.github.com/repos/osheroff/macvim/pulls{/number}","milestones_url":"https://api.github.com/repos/osheroff/macvim/milestones{/number}","notifications_url":"https://api.github.com/repos/osheroff/macvim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/osheroff/macvim/labels{/name}","releases_url":"https://api.github.com/repos/osheroff/macvim/releases{/id}","deployments_url":"https://api.github.com/repos/osheroff/macvim/deployments","created_at":"2016-11-14T05:42:58Z","updated_at":"2016-11-14T05:43:10Z","pushed_at":"2016-11-23T05:43:01Z","git_url":"git://github.com/osheroff/macvim.git","ssh_url":"git@github.com:osheroff/macvim.git","clone_url":"https://github.com/osheroff/macvim.git","svn_url":"https://github.com/osheroff/macvim","homepage":"http://macvim-dev.github.io/macvim","size":80434,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"macvim-dev:master","ref":"master","sha":"c85f864c35de260ca75a1707dba8691838c0ae7c","user":{"login":"macvim-dev","id":11452312,"avatar_url":"https://avatars.githubusercontent.com/u/11452312?v=3","gravatar_id":"","url":"https://api.github.com/users/macvim-dev","html_url":"https://github.com/macvim-dev","followers_url":"https://api.github.com/users/macvim-dev/followers","following_url":"https://api.github.com/users/macvim-dev/following{/other_user}","gists_url":"https://api.github.com/users/macvim-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/macvim-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macvim-dev/subscriptions","organizations_url":"https://api.github.com/users/macvim-dev/orgs","repos_url":"https://api.github.com/users/macvim-dev/repos","events_url":"https://api.github.com/users/macvim-dev/events{/privacy}","received_events_url":"https://api.github.com/users/macvim-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":5641441,"name":"macvim","full_name":"macvim-dev/macvim","owner":{"login":"macvim-dev","id":11452312,"avatar_url":"https://avatars.githubusercontent.com/u/11452312?v=3","gravatar_id":"","url":"https://api.github.com/users/macvim-dev","html_url":"https://github.com/macvim-dev","followers_url":"https://api.github.com/users/macvim-dev/followers","following_url":"https://api.github.com/users/macvim-dev/following{/other_user}","gists_url":"https://api.github.com/users/macvim-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/macvim-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macvim-dev/subscriptions","organizations_url":"https://api.github.com/users/macvim-dev/orgs","repos_url":"https://api.github.com/users/macvim-dev/repos","events_url":"https://api.github.com/users/macvim-dev/events{/privacy}","received_events_url":"https://api.github.com/users/macvim-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/macvim-dev/macvim","description":"Vim - the text editor - for Mac OS X","fork":false,"url":"https://api.github.com/repos/macvim-dev/macvim","forks_url":"https://api.github.com/repos/macvim-dev/macvim/forks","keys_url":"https://api.github.com/repos/macvim-dev/macvim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/macvim-dev/macvim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/macvim-dev/macvim/teams","hooks_url":"https://api.github.com/repos/macvim-dev/macvim/hooks","issue_events_url":"https://api.github.com/repos/macvim-dev/macvim/issues/events{/number}","events_url":"https://api.github.com/repos/macvim-dev/macvim/events","assignees_url":"https://api.github.com/repos/macvim-dev/macvim/assignees{/user}","branches_url":"https://api.github.com/repos/macvim-dev/macvim/branches{/branch}","tags_url":"https://api.github.com/repos/macvim-dev/macvim/tags","blobs_url":"https://api.github.com/repos/macvim-dev/macvim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/macvim-dev/macvim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/macvim-dev/macvim/git/refs{/sha}","trees_url":"https://api.github.com/repos/macvim-dev/macvim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/macvim-dev/macvim/statuses/{sha}","languages_url":"https://api.github.com/repos/macvim-dev/macvim/languages","stargazers_url":"https://api.github.com/repos/macvim-dev/macvim/stargazers","contributors_url":"https://api.github.com/repos/macvim-dev/macvim/contributors","subscribers_url":"https://api.github.com/repos/macvim-dev/macvim/subscribers","subscription_url":"https://api.github.com/repos/macvim-dev/macvim/subscription","commits_url":"https://api.github.com/repos/macvim-dev/macvim/commits{/sha}","git_commits_url":"https://api.github.com/repos/macvim-dev/macvim/git/commits{/sha}","comments_url":"https://api.github.com/repos/macvim-dev/macvim/comments{/number}","issue_comment_url":"https://api.github.com/repos/macvim-dev/macvim/issues/comments{/number}","contents_url":"https://api.github.com/repos/macvim-dev/macvim/contents/{+path}","compare_url":"https://api.github.com/repos/macvim-dev/macvim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/macvim-dev/macvim/merges","archive_url":"https://api.github.com/repos/macvim-dev/macvim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/macvim-dev/macvim/downloads","issues_url":"https://api.github.com/repos/macvim-dev/macvim/issues{/number}","pulls_url":"https://api.github.com/repos/macvim-dev/macvim/pulls{/number}","milestones_url":"https://api.github.com/repos/macvim-dev/macvim/milestones{/number}","notifications_url":"https://api.github.com/repos/macvim-dev/macvim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/macvim-dev/macvim/labels{/name}","releases_url":"https://api.github.com/repos/macvim-dev/macvim/releases{/id}","deployments_url":"https://api.github.com/repos/macvim-dev/macvim/deployments","created_at":"2012-09-01T17:14:57Z","updated_at":"2016-11-23T02:18:21Z","pushed_at":"2016-11-21T21:05:12Z","git_url":"git://github.com/macvim-dev/macvim.git","ssh_url":"git@github.com:macvim-dev/macvim.git","clone_url":"https://github.com/macvim-dev/macvim.git","svn_url":"https://github.com/macvim-dev/macvim","homepage":"http://macvim-dev.github.io/macvim","size":86898,"stargazers_count":2494,"watchers_count":2494,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":338,"mirror_url":null,"open_issues_count":38,"forks":338,"open_issues":38,"watchers":2494,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/macvim-dev/macvim/pulls/412"},"html":{"href":"https://github.com/macvim-dev/macvim/pull/412"},"issue":{"href":"https://api.github.com/repos/macvim-dev/macvim/issues/412"},"comments":{"href":"https://api.github.com/repos/macvim-dev/macvim/issues/412/comments"},"review_comments":{"href":"https://api.github.com/repos/macvim-dev/macvim/pulls/412/comments"},"review_comment":{"href":"https://api.github.com/repos/macvim-dev/macvim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/macvim-dev/macvim/pulls/412/commits"},"statuses":{"href":"https://api.github.com/repos/macvim-dev/macvim/statuses/991562d2f47a94bb03ad9df446fc60c134e134ab"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":6,"review_comments":0,"commits":1,"additions":28,"deletions":2,"changed_files":5}}
{"actor":{"display_login":"osheroff"}}