{"action":"created","comment":{"url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/pulls/comments/64528087","id":64528087,"diff_hunk":"@@ -1223,3 +1223,79 @@ def verify_service_http(service_name, url, predicate=None):\n         return check_http_response(url, predicate)\n     except (IOError, ValueError) as e:\n         ctx.abort_operation('{0} error: {1}: {2}'.format(service_name, url, e))\n+","path":"components/utils.py","position":94,"original_position":94,"commit_id":"0ab5f4b3af1ce66b12a19321b6576fdae72b9e7a","original_commit_id":"0ab5f4b3af1ce66b12a19321b6576fdae72b9e7a","user":{"login":"nir0s","id":2003076,"avatar_url":"https://avatars.githubusercontent.com/u/2003076?v=3","gravatar_id":"","url":"https://api.github.com/users/nir0s","html_url":"https://github.com/nir0s","followers_url":"https://api.github.com/users/nir0s/followers","following_url":"https://api.github.com/users/nir0s/following{/other_user}","gists_url":"https://api.github.com/users/nir0s/gists{/gist_id}","starred_url":"https://api.github.com/users/nir0s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nir0s/subscriptions","organizations_url":"https://api.github.com/users/nir0s/orgs","repos_url":"https://api.github.com/users/nir0s/repos","events_url":"https://api.github.com/users/nir0s/events{/privacy}","received_events_url":"https://api.github.com/users/nir0s/received_events","type":"User","site_admin":false},"body":"are these functions used anywhere else in the blueprint? If not, why not move them to a different file and import it for each creaction_validation script?\r\n\r\nAlso, the name creaction_validation is misleading.. as it doesn't validate the creation of anything","created_at":"2016-05-25T07:41:55Z","updated_at":"2016-05-25T07:41:55Z","html_url":"https://github.com/cloudify-cosmo/cloudify-manager-blueprints/pull/297#discussion_r64528087","pull_request_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/pulls/297","_links":{"self":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/pulls/comments/64528087"},"html":{"href":"https://github.com/cloudify-cosmo/cloudify-manager-blueprints/pull/297#discussion_r64528087"},"pull_request":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/pulls/297"}}},"pull_request":{"url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/pulls/297","id":69858097,"html_url":"https://github.com/cloudify-cosmo/cloudify-manager-blueprints/pull/297","diff_url":"https://github.com/cloudify-cosmo/cloudify-manager-blueprints/pull/297.diff","patch_url":"https://github.com/cloudify-cosmo/cloudify-manager-blueprints/pull/297.patch","issue_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/issues/297","number":297,"state":"open","locked":false,"title":"CFY-4953 Pre-upgrade validations","user":{"login":"tehasdf","id":790215,"avatar_url":"https://avatars.githubusercontent.com/u/790215?v=3","gravatar_id":"","url":"https://api.github.com/users/tehasdf","html_url":"https://github.com/tehasdf","followers_url":"https://api.github.com/users/tehasdf/followers","following_url":"https://api.github.com/users/tehasdf/following{/other_user}","gists_url":"https://api.github.com/users/tehasdf/gists{/gist_id}","starred_url":"https://api.github.com/users/tehasdf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tehasdf/subscriptions","organizations_url":"https://api.github.com/users/tehasdf/orgs","repos_url":"https://api.github.com/users/tehasdf/repos","events_url":"https://api.github.com/users/tehasdf/events{/privacy}","received_events_url":"https://api.github.com/users/tehasdf/received_events","type":"User","site_admin":false},"body":"Add validation scripts to run before a manager upgrade,\r\nchecking that the required services are running, that the\r\ndirectory structure looks as expected, and that some\r\nproperties didn't change.","created_at":"2016-05-12T15:33:01Z","updated_at":"2016-05-25T07:41:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a82e5c8a034598a33da815607384464b6c4ceee6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/pulls/297/commits","review_comments_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/pulls/297/comments","review_comment_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/issues/297/comments","statuses_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/statuses/0ab5f4b3af1ce66b12a19321b6576fdae72b9e7a","head":{"label":"codilime:CFY-4953-upgrade-validation","ref":"CFY-4953-upgrade-validation","sha":"0ab5f4b3af1ce66b12a19321b6576fdae72b9e7a","user":{"login":"codilime","id":2143695,"avatar_url":"https://avatars.githubusercontent.com/u/2143695?v=3","gravatar_id":"","url":"https://api.github.com/users/codilime","html_url":"https://github.com/codilime","followers_url":"https://api.github.com/users/codilime/followers","following_url":"https://api.github.com/users/codilime/following{/other_user}","gists_url":"https://api.github.com/users/codilime/gists{/gist_id}","starred_url":"https://api.github.com/users/codilime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codilime/subscriptions","organizations_url":"https://api.github.com/users/codilime/orgs","repos_url":"https://api.github.com/users/codilime/repos","events_url":"https://api.github.com/users/codilime/events{/privacy}","received_events_url":"https://api.github.com/users/codilime/received_events","type":"Organization","site_admin":false},"repo":{"id":42187345,"name":"cloudify-manager-blueprints","full_name":"codilime/cloudify-manager-blueprints","owner":{"login":"codilime","id":2143695,"avatar_url":"https://avatars.githubusercontent.com/u/2143695?v=3","gravatar_id":"","url":"https://api.github.com/users/codilime","html_url":"https://github.com/codilime","followers_url":"https://api.github.com/users/codilime/followers","following_url":"https://api.github.com/users/codilime/following{/other_user}","gists_url":"https://api.github.com/users/codilime/gists{/gist_id}","starred_url":"https://api.github.com/users/codilime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codilime/subscriptions","organizations_url":"https://api.github.com/users/codilime/orgs","repos_url":"https://api.github.com/users/codilime/repos","events_url":"https://api.github.com/users/codilime/events{/privacy}","received_events_url":"https://api.github.com/users/codilime/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codilime/cloudify-manager-blueprints","description":"","fork":true,"url":"https://api.github.com/repos/codilime/cloudify-manager-blueprints","forks_url":"https://api.github.com/repos/codilime/cloudify-manager-blueprints/forks","keys_url":"https://api.github.com/repos/codilime/cloudify-manager-blueprints/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codilime/cloudify-manager-blueprints/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codilime/cloudify-manager-blueprints/teams","hooks_url":"https://api.github.com/repos/codilime/cloudify-manager-blueprints/hooks","issue_events_url":"https://api.github.com/repos/codilime/cloudify-manager-blueprints/issues/events{/number}","events_url":"https://api.github.com/repos/codilime/cloudify-manager-blueprints/events","assignees_url":"https://api.github.com/repos/codilime/cloudify-manager-blueprints/assignees{/user}","branches_url":"https://api.github.com/repos/codilime/cloudify-manager-blueprints/branches{/branch}","tags_url":"https://api.github.com/repos/codilime/cloudify-manager-blueprints/tags","blobs_url":"https://api.github.com/repos/codilime/cloudify-manager-blueprints/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codilime/cloudify-manager-blueprints/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codilime/cloudify-manager-blueprints/git/refs{/sha}","trees_url":"https://api.github.com/repos/codilime/cloudify-manager-blueprints/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codilime/cloudify-manager-blueprints/statuses/{sha}","languages_url":"https://api.github.com/repos/codilime/cloudify-manager-blueprints/languages","stargazers_url":"https://api.github.com/repos/codilime/cloudify-manager-blueprints/stargazers","contributors_url":"https://api.github.com/repos/codilime/cloudify-manager-blueprints/contributors","subscribers_url":"https://api.github.com/repos/codilime/cloudify-manager-blueprints/subscribers","subscription_url":"https://api.github.com/repos/codilime/cloudify-manager-blueprints/subscription","commits_url":"https://api.github.com/repos/codilime/cloudify-manager-blueprints/commits{/sha}","git_commits_url":"https://api.github.com/repos/codilime/cloudify-manager-blueprints/git/commits{/sha}","comments_url":"https://api.github.com/repos/codilime/cloudify-manager-blueprints/comments{/number}","issue_comment_url":"https://api.github.com/repos/codilime/cloudify-manager-blueprints/issues/comments{/number}","contents_url":"https://api.github.com/repos/codilime/cloudify-manager-blueprints/contents/{+path}","compare_url":"https://api.github.com/repos/codilime/cloudify-manager-blueprints/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codilime/cloudify-manager-blueprints/merges","archive_url":"https://api.github.com/repos/codilime/cloudify-manager-blueprints/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codilime/cloudify-manager-blueprints/downloads","issues_url":"https://api.github.com/repos/codilime/cloudify-manager-blueprints/issues{/number}","pulls_url":"https://api.github.com/repos/codilime/cloudify-manager-blueprints/pulls{/number}","milestones_url":"https://api.github.com/repos/codilime/cloudify-manager-blueprints/milestones{/number}","notifications_url":"https://api.github.com/repos/codilime/cloudify-manager-blueprints/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codilime/cloudify-manager-blueprints/labels{/name}","releases_url":"https://api.github.com/repos/codilime/cloudify-manager-blueprints/releases{/id}","deployments_url":"https://api.github.com/repos/codilime/cloudify-manager-blueprints/deployments","created_at":"2015-09-09T15:29:45Z","updated_at":"2015-09-09T15:29:46Z","pushed_at":"2016-05-24T21:59:33Z","git_url":"git://github.com/codilime/cloudify-manager-blueprints.git","ssh_url":"git@github.com:codilime/cloudify-manager-blueprints.git","clone_url":"https://github.com/codilime/cloudify-manager-blueprints.git","svn_url":"https://github.com/codilime/cloudify-manager-blueprints","homepage":null,"size":1899,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cloudify-cosmo:master","ref":"master","sha":"4b33ca3d2543548237c312aed5171edbde97cee3","user":{"login":"cloudify-cosmo","id":6260555,"avatar_url":"https://avatars.githubusercontent.com/u/6260555?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudify-cosmo","html_url":"https://github.com/cloudify-cosmo","followers_url":"https://api.github.com/users/cloudify-cosmo/followers","following_url":"https://api.github.com/users/cloudify-cosmo/following{/other_user}","gists_url":"https://api.github.com/users/cloudify-cosmo/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudify-cosmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudify-cosmo/subscriptions","organizations_url":"https://api.github.com/users/cloudify-cosmo/orgs","repos_url":"https://api.github.com/users/cloudify-cosmo/repos","events_url":"https://api.github.com/users/cloudify-cosmo/events{/privacy}","received_events_url":"https://api.github.com/users/cloudify-cosmo/received_events","type":"Organization","site_admin":false},"repo":{"id":24557021,"name":"cloudify-manager-blueprints","full_name":"cloudify-cosmo/cloudify-manager-blueprints","owner":{"login":"cloudify-cosmo","id":6260555,"avatar_url":"https://avatars.githubusercontent.com/u/6260555?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudify-cosmo","html_url":"https://github.com/cloudify-cosmo","followers_url":"https://api.github.com/users/cloudify-cosmo/followers","following_url":"https://api.github.com/users/cloudify-cosmo/following{/other_user}","gists_url":"https://api.github.com/users/cloudify-cosmo/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudify-cosmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudify-cosmo/subscriptions","organizations_url":"https://api.github.com/users/cloudify-cosmo/orgs","repos_url":"https://api.github.com/users/cloudify-cosmo/repos","events_url":"https://api.github.com/users/cloudify-cosmo/events{/privacy}","received_events_url":"https://api.github.com/users/cloudify-cosmo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudify-cosmo/cloudify-manager-blueprints","description":"","fork":false,"url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints","forks_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/forks","keys_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/teams","hooks_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/hooks","issue_events_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/issues/events{/number}","events_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/events","assignees_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/assignees{/user}","branches_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/branches{/branch}","tags_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/tags","blobs_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/languages","stargazers_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/stargazers","contributors_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/contributors","subscribers_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/subscribers","subscription_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/subscription","commits_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/contents/{+path}","compare_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/merges","archive_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/downloads","issues_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/issues{/number}","pulls_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/labels{/name}","releases_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/releases{/id}","deployments_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/deployments","created_at":"2014-09-28T10:35:22Z","updated_at":"2016-04-24T13:49:19Z","pushed_at":"2016-05-25T07:39:59Z","git_url":"git://github.com/cloudify-cosmo/cloudify-manager-blueprints.git","ssh_url":"git@github.com:cloudify-cosmo/cloudify-manager-blueprints.git","clone_url":"https://github.com/cloudify-cosmo/cloudify-manager-blueprints.git","svn_url":"https://github.com/cloudify-cosmo/cloudify-manager-blueprints","homepage":null,"size":2616,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":22,"forks":32,"open_issues":22,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/pulls/297"},"html":{"href":"https://github.com/cloudify-cosmo/cloudify-manager-blueprints/pull/297"},"issue":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/issues/297"},"comments":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/issues/297/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/pulls/297/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/pulls/297/commits"},"statuses":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager-blueprints/statuses/0ab5f4b3af1ce66b12a19321b6576fdae72b9e7a"}}}}
{"actor":{"display_login":"nir0s"}}