{"action":"created","comment":{"url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/pulls/comments/83564289","pull_request_review_id":4400093,"id":83564289,"diff_hunk":"@@ -0,0 +1,244 @@\n+package fpinscalamulti.Vanilla.state\n+\n+import org.scalatest.prop.GeneratorDrivenPropertyChecks\n+import org.scalatest.{FlatSpec, Matchers}\n+import org.scalacheck.Gen\n+\n+/**\n+  * Created by davenpcm on 8/21/16.\n+  */\n+class RNGTests extends FlatSpec with Matchers with GeneratorDrivenPropertyChecks {\n+  import RNG._\n+\n+\n+\n+  \"Simple RNG\"  should \"return integers based on seed\" in {\n+    val rng = RNG.SimpleRNG(42L)\n+\n+    rng.nextInt should be ((16159453, RNG.SimpleRNG(1059025964525L)))\n+    rng.nextInt should be ((16159453, RNG.SimpleRNG(1059025964525L)))\n+  }\n+\n+  it should \"return in an expected order\" in {\n+    val rng = RNG.SimpleRNG(42L)\n+    val rng2 = rng.nextInt._2\n+    rng2.nextInt should be ((-1281479697, RNG.SimpleRNG(197491923327988L)))\n+  }\n+\n+  \"nonNegativeInt\" should \"return an expected positive int for a given RNG\" in {\n+    val rng = RNG.SimpleRNG(103L)\n+    RNG.nonNegativeInt(rng) should be ((39629136, RNG.SimpleRNG(2597135103462L)))\n+  }\n+\n+  it should \"return a positive int for all seeds\" in {\n+    forAll(\"seed\"){ l: Long =>\n+      val rngInit = RNG.SimpleRNG(l)\n+      val (int, rng) = RNG.nonNegativeInt(rngInit)\n+      int should be >= 0\n+    }\n+  }\n+\n+  it should \"return a postivie int for a seed value nextInt will be negative\" in {\n+    val rng = RNG.SimpleRNG(107785L)","path":"src/test/scala/fpinscalamulti/Vanilla/state/RNGTests.scala","position":42,"original_position":42,"commit_id":"8d31b34b143a76694ee456c94c6b800de43cdfa9","original_commit_id":"8d31b34b143a76694ee456c94c6b800de43cdfa9","user":{"login":"codacy-bot","id":19940114,"avatar_url":"https://avatars.githubusercontent.com/u/19940114?v=3","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":"![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [Magic Number](https://www.codacy.com/app/christopherdavenport/fpInScalaMultiTool/file/4179104075/issues/source?bid=3676416&fileBranchId=3808912#l42)","created_at":"2016-10-17T00:06:53Z","updated_at":"2016-10-17T00:06:53Z","html_url":"https://github.com/ChristopherDavenport/fpInScalaMultiTool/pull/6#discussion_r83564289","pull_request_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/pulls/comments/83564289"},"html":{"href":"https://github.com/ChristopherDavenport/fpInScalaMultiTool/pull/6#discussion_r83564289"},"pull_request":{"href":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/pulls/6","id":89545869,"html_url":"https://github.com/ChristopherDavenport/fpInScalaMultiTool/pull/6","diff_url":"https://github.com/ChristopherDavenport/fpInScalaMultiTool/pull/6.diff","patch_url":"https://github.com/ChristopherDavenport/fpInScalaMultiTool/pull/6.patch","issue_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/issues/6","number":6,"state":"open","locked":false,"title":"Finished All State","user":{"login":"ChristopherDavenport","id":10272700,"avatar_url":"https://avatars.githubusercontent.com/u/10272700?v=3","gravatar_id":"","url":"https://api.github.com/users/ChristopherDavenport","html_url":"https://github.com/ChristopherDavenport","followers_url":"https://api.github.com/users/ChristopherDavenport/followers","following_url":"https://api.github.com/users/ChristopherDavenport/following{/other_user}","gists_url":"https://api.github.com/users/ChristopherDavenport/gists{/gist_id}","starred_url":"https://api.github.com/users/ChristopherDavenport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChristopherDavenport/subscriptions","organizations_url":"https://api.github.com/users/ChristopherDavenport/orgs","repos_url":"https://api.github.com/users/ChristopherDavenport/repos","events_url":"https://api.github.com/users/ChristopherDavenport/events{/privacy}","received_events_url":"https://api.github.com/users/ChristopherDavenport/received_events","type":"User","site_admin":false},"body":"Particularly Challenging and Particularly difficult I see how this gets worse to follow trying to do the examples. Lots more propery based testing for this sort of work.","created_at":"2016-10-17T00:04:22Z","updated_at":"2016-10-17T00:06:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f4737ffd09cdc8aad17bc4b3e7d081d8e7261cd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/pulls/6/commits","review_comments_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/pulls/6/comments","review_comment_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/issues/6/comments","statuses_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/statuses/8d31b34b143a76694ee456c94c6b800de43cdfa9","head":{"label":"ChristopherDavenport:State","ref":"State","sha":"8d31b34b143a76694ee456c94c6b800de43cdfa9","user":{"login":"ChristopherDavenport","id":10272700,"avatar_url":"https://avatars.githubusercontent.com/u/10272700?v=3","gravatar_id":"","url":"https://api.github.com/users/ChristopherDavenport","html_url":"https://github.com/ChristopherDavenport","followers_url":"https://api.github.com/users/ChristopherDavenport/followers","following_url":"https://api.github.com/users/ChristopherDavenport/following{/other_user}","gists_url":"https://api.github.com/users/ChristopherDavenport/gists{/gist_id}","starred_url":"https://api.github.com/users/ChristopherDavenport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChristopherDavenport/subscriptions","organizations_url":"https://api.github.com/users/ChristopherDavenport/orgs","repos_url":"https://api.github.com/users/ChristopherDavenport/repos","events_url":"https://api.github.com/users/ChristopherDavenport/events{/privacy}","received_events_url":"https://api.github.com/users/ChristopherDavenport/received_events","type":"User","site_admin":false},"repo":{"id":62598802,"name":"fpInScalaMultiTool","full_name":"ChristopherDavenport/fpInScalaMultiTool","owner":{"login":"ChristopherDavenport","id":10272700,"avatar_url":"https://avatars.githubusercontent.com/u/10272700?v=3","gravatar_id":"","url":"https://api.github.com/users/ChristopherDavenport","html_url":"https://github.com/ChristopherDavenport","followers_url":"https://api.github.com/users/ChristopherDavenport/followers","following_url":"https://api.github.com/users/ChristopherDavenport/following{/other_user}","gists_url":"https://api.github.com/users/ChristopherDavenport/gists{/gist_id}","starred_url":"https://api.github.com/users/ChristopherDavenport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChristopherDavenport/subscriptions","organizations_url":"https://api.github.com/users/ChristopherDavenport/orgs","repos_url":"https://api.github.com/users/ChristopherDavenport/repos","events_url":"https://api.github.com/users/ChristopherDavenport/events{/privacy}","received_events_url":"https://api.github.com/users/ChristopherDavenport/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ChristopherDavenport/fpInScalaMultiTool","description":null,"fork":false,"url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool","forks_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/forks","keys_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/teams","hooks_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/hooks","issue_events_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/issues/events{/number}","events_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/events","assignees_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/assignees{/user}","branches_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/branches{/branch}","tags_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/tags","blobs_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/git/refs{/sha}","trees_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/statuses/{sha}","languages_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/languages","stargazers_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/stargazers","contributors_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/contributors","subscribers_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/subscribers","subscription_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/subscription","commits_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/commits{/sha}","git_commits_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/git/commits{/sha}","comments_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/comments{/number}","issue_comment_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/issues/comments{/number}","contents_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/contents/{+path}","compare_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/merges","archive_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/downloads","issues_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/issues{/number}","pulls_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/pulls{/number}","milestones_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/milestones{/number}","notifications_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/labels{/name}","releases_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/releases{/id}","deployments_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/deployments","created_at":"2016-07-05T02:07:56Z","updated_at":"2016-07-05T02:08:17Z","pushed_at":"2016-10-17T00:04:22Z","git_url":"git://github.com/ChristopherDavenport/fpInScalaMultiTool.git","ssh_url":"git@github.com:ChristopherDavenport/fpInScalaMultiTool.git","clone_url":"https://github.com/ChristopherDavenport/fpInScalaMultiTool.git","svn_url":"https://github.com/ChristopherDavenport/fpInScalaMultiTool","homepage":null,"size":60,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ChristopherDavenport:master","ref":"master","sha":"7a2c9650eec329da6db8a5cb68539cbd0bd77648","user":{"login":"ChristopherDavenport","id":10272700,"avatar_url":"https://avatars.githubusercontent.com/u/10272700?v=3","gravatar_id":"","url":"https://api.github.com/users/ChristopherDavenport","html_url":"https://github.com/ChristopherDavenport","followers_url":"https://api.github.com/users/ChristopherDavenport/followers","following_url":"https://api.github.com/users/ChristopherDavenport/following{/other_user}","gists_url":"https://api.github.com/users/ChristopherDavenport/gists{/gist_id}","starred_url":"https://api.github.com/users/ChristopherDavenport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChristopherDavenport/subscriptions","organizations_url":"https://api.github.com/users/ChristopherDavenport/orgs","repos_url":"https://api.github.com/users/ChristopherDavenport/repos","events_url":"https://api.github.com/users/ChristopherDavenport/events{/privacy}","received_events_url":"https://api.github.com/users/ChristopherDavenport/received_events","type":"User","site_admin":false},"repo":{"id":62598802,"name":"fpInScalaMultiTool","full_name":"ChristopherDavenport/fpInScalaMultiTool","owner":{"login":"ChristopherDavenport","id":10272700,"avatar_url":"https://avatars.githubusercontent.com/u/10272700?v=3","gravatar_id":"","url":"https://api.github.com/users/ChristopherDavenport","html_url":"https://github.com/ChristopherDavenport","followers_url":"https://api.github.com/users/ChristopherDavenport/followers","following_url":"https://api.github.com/users/ChristopherDavenport/following{/other_user}","gists_url":"https://api.github.com/users/ChristopherDavenport/gists{/gist_id}","starred_url":"https://api.github.com/users/ChristopherDavenport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChristopherDavenport/subscriptions","organizations_url":"https://api.github.com/users/ChristopherDavenport/orgs","repos_url":"https://api.github.com/users/ChristopherDavenport/repos","events_url":"https://api.github.com/users/ChristopherDavenport/events{/privacy}","received_events_url":"https://api.github.com/users/ChristopherDavenport/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ChristopherDavenport/fpInScalaMultiTool","description":null,"fork":false,"url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool","forks_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/forks","keys_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/teams","hooks_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/hooks","issue_events_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/issues/events{/number}","events_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/events","assignees_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/assignees{/user}","branches_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/branches{/branch}","tags_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/tags","blobs_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/git/refs{/sha}","trees_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/statuses/{sha}","languages_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/languages","stargazers_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/stargazers","contributors_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/contributors","subscribers_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/subscribers","subscription_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/subscription","commits_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/commits{/sha}","git_commits_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/git/commits{/sha}","comments_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/comments{/number}","issue_comment_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/issues/comments{/number}","contents_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/contents/{+path}","compare_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/merges","archive_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/downloads","issues_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/issues{/number}","pulls_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/pulls{/number}","milestones_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/milestones{/number}","notifications_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/labels{/name}","releases_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/releases{/id}","deployments_url":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/deployments","created_at":"2016-07-05T02:07:56Z","updated_at":"2016-07-05T02:08:17Z","pushed_at":"2016-10-17T00:04:22Z","git_url":"git://github.com/ChristopherDavenport/fpInScalaMultiTool.git","ssh_url":"git@github.com:ChristopherDavenport/fpInScalaMultiTool.git","clone_url":"https://github.com/ChristopherDavenport/fpInScalaMultiTool.git","svn_url":"https://github.com/ChristopherDavenport/fpInScalaMultiTool","homepage":null,"size":60,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/pulls/6"},"html":{"href":"https://github.com/ChristopherDavenport/fpInScalaMultiTool/pull/6"},"issue":{"href":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/issues/6"},"comments":{"href":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/ChristopherDavenport/fpInScalaMultiTool/statuses/8d31b34b143a76694ee456c94c6b800de43cdfa9"}}}}
{"actor":{"display_login":"codacy-bot"}}