{"action":"opened","issue":{"url":"https://api.github.com/repos/IMSGlobal/LTI-Tool-Provider-Library-PHP/issues/17","repository_url":"https://api.github.com/repos/IMSGlobal/LTI-Tool-Provider-Library-PHP","labels_url":"https://api.github.com/repos/IMSGlobal/LTI-Tool-Provider-Library-PHP/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/IMSGlobal/LTI-Tool-Provider-Library-PHP/issues/17/comments","events_url":"https://api.github.com/repos/IMSGlobal/LTI-Tool-Provider-Library-PHP/issues/17/events","html_url":"https://github.com/IMSGlobal/LTI-Tool-Provider-Library-PHP/issues/17","id":197373894,"number":17,"title":"Support for SHA256 signature method","user":{"login":"madalinoprea","id":605494,"avatar_url":"https://avatars.githubusercontent.com/u/605494?v=3","gravatar_id":"","url":"https://api.github.com/users/madalinoprea","html_url":"https://github.com/madalinoprea","followers_url":"https://api.github.com/users/madalinoprea/followers","following_url":"https://api.github.com/users/madalinoprea/following{/other_user}","gists_url":"https://api.github.com/users/madalinoprea/gists{/gist_id}","starred_url":"https://api.github.com/users/madalinoprea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madalinoprea/subscriptions","organizations_url":"https://api.github.com/users/madalinoprea/orgs","repos_url":"https://api.github.com/users/madalinoprea/repos","events_url":"https://api.github.com/users/madalinoprea/events{/privacy}","received_events_url":"https://api.github.com/users/madalinoprea/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-12-23T13:59:05Z","updated_at":"2016-12-23T13:59:05Z","closed_at":null,"body":"Hey, \r\n\r\nIs there a reason why SHA256 is not registered as an accepted signature method?\r\n\r\nWhen I'm trying to authenticate a LTI launch request signed with SHA256 I'm getting an error from `\\IMSGlobal\\LTI\\OAuth\\OAuthServer::get_signature_method` that only SHA1 can be used.\r\n\r\nIf we add this line to https://github.com/IMSGlobal/LTI-Tool-Provider-Library-PHP/blob/master/src/ToolProvider/ToolProvider.php#L772 everything works as expected:\r\n\r\n`$server->add_signature_method(new OAuth\\OAuthSignatureMethod_HMAC_SHA256());`\r\n\r\nIs there a way to configure ToolProvider to accept this signature method?\r\n\r\nThanks,\r\nMario"}}
{"actor":{"display_login":"madalinoprea"}}