{"action":"closed","number":47,"pull_request":{"url":"https://api.github.com/repos/fastmonkeys/asomap/pulls/47","id":91613721,"html_url":"https://github.com/fastmonkeys/asomap/pull/47","diff_url":"https://github.com/fastmonkeys/asomap/pull/47.diff","patch_url":"https://github.com/fastmonkeys/asomap/pull/47.patch","issue_url":"https://api.github.com/repos/fastmonkeys/asomap/issues/47","number":47,"state":"closed","locked":false,"title":"Filter counts","user":{"login":"FelixLoether","id":221898,"avatar_url":"https://avatars.githubusercontent.com/u/221898?v=3","gravatar_id":"","url":"https://api.github.com/users/FelixLoether","html_url":"https://github.com/FelixLoether","followers_url":"https://api.github.com/users/FelixLoether/followers","following_url":"https://api.github.com/users/FelixLoether/following{/other_user}","gists_url":"https://api.github.com/users/FelixLoether/gists{/gist_id}","starred_url":"https://api.github.com/users/FelixLoether/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FelixLoether/subscriptions","organizations_url":"https://api.github.com/users/FelixLoether/orgs","repos_url":"https://api.github.com/users/FelixLoether/repos","events_url":"https://api.github.com/users/FelixLoether/events{/privacy}","received_events_url":"https://api.github.com/users/FelixLoether/received_events","type":"User","site_admin":false},"body":"Closes #46.\r\n\r\nThere are two fairly big changes here to make the counting possible / easier:\r\n\r\n- Normalizing the data in the API service instead of in the data reducer. The data from the API response will also be used in the filters reducer, so having it be normalized before the reducers makes things easier.\r\n- The postal code filter is filtered to valid selections only in the reducer. So for example if you select postal codes = 00100 and 02100 and then select city = Helsinki, `state.filters.postalCodes` would then be changed from `['00100', '02100']` to `['00100']`. Without this the counts shown in the city selector were super weird.","created_at":"2016-10-31T14:01:14Z","updated_at":"2016-11-01T10:37:54Z","closed_at":"2016-11-01T10:37:54Z","merged_at":"2016-11-01T10:37:54Z","merge_commit_sha":"daa2930977e4559c9e1aab9d4bacccdceb683437","assignee":{"login":"lraivio","id":946697,"avatar_url":"https://avatars.githubusercontent.com/u/946697?v=3","gravatar_id":"","url":"https://api.github.com/users/lraivio","html_url":"https://github.com/lraivio","followers_url":"https://api.github.com/users/lraivio/followers","following_url":"https://api.github.com/users/lraivio/following{/other_user}","gists_url":"https://api.github.com/users/lraivio/gists{/gist_id}","starred_url":"https://api.github.com/users/lraivio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lraivio/subscriptions","organizations_url":"https://api.github.com/users/lraivio/orgs","repos_url":"https://api.github.com/users/lraivio/repos","events_url":"https://api.github.com/users/lraivio/events{/privacy}","received_events_url":"https://api.github.com/users/lraivio/received_events","type":"User","site_admin":false},"assignees":[{"login":"lraivio","id":946697,"avatar_url":"https://avatars.githubusercontent.com/u/946697?v=3","gravatar_id":"","url":"https://api.github.com/users/lraivio","html_url":"https://github.com/lraivio","followers_url":"https://api.github.com/users/lraivio/followers","following_url":"https://api.github.com/users/lraivio/following{/other_user}","gists_url":"https://api.github.com/users/lraivio/gists{/gist_id}","starred_url":"https://api.github.com/users/lraivio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lraivio/subscriptions","organizations_url":"https://api.github.com/users/lraivio/orgs","repos_url":"https://api.github.com/users/lraivio/repos","events_url":"https://api.github.com/users/lraivio/events{/privacy}","received_events_url":"https://api.github.com/users/lraivio/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/fastmonkeys/asomap/pulls/47/commits","review_comments_url":"https://api.github.com/repos/fastmonkeys/asomap/pulls/47/comments","review_comment_url":"https://api.github.com/repos/fastmonkeys/asomap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fastmonkeys/asomap/issues/47/comments","statuses_url":"https://api.github.com/repos/fastmonkeys/asomap/statuses/f9621082c7e8e4fd729a65e451946e38a5327c07","head":{"label":"fastmonkeys:feature/46-filter-counts","ref":"feature/46-filter-counts","sha":"f9621082c7e8e4fd729a65e451946e38a5327c07","user":{"login":"fastmonkeys","id":946529,"avatar_url":"https://avatars.githubusercontent.com/u/946529?v=3","gravatar_id":"","url":"https://api.github.com/users/fastmonkeys","html_url":"https://github.com/fastmonkeys","followers_url":"https://api.github.com/users/fastmonkeys/followers","following_url":"https://api.github.com/users/fastmonkeys/following{/other_user}","gists_url":"https://api.github.com/users/fastmonkeys/gists{/gist_id}","starred_url":"https://api.github.com/users/fastmonkeys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastmonkeys/subscriptions","organizations_url":"https://api.github.com/users/fastmonkeys/orgs","repos_url":"https://api.github.com/users/fastmonkeys/repos","events_url":"https://api.github.com/users/fastmonkeys/events{/privacy}","received_events_url":"https://api.github.com/users/fastmonkeys/received_events","type":"Organization","site_admin":false},"repo":{"id":70702649,"name":"asomap","full_name":"fastmonkeys/asomap","owner":{"login":"fastmonkeys","id":946529,"avatar_url":"https://avatars.githubusercontent.com/u/946529?v=3","gravatar_id":"","url":"https://api.github.com/users/fastmonkeys","html_url":"https://github.com/fastmonkeys","followers_url":"https://api.github.com/users/fastmonkeys/followers","following_url":"https://api.github.com/users/fastmonkeys/following{/other_user}","gists_url":"https://api.github.com/users/fastmonkeys/gists{/gist_id}","starred_url":"https://api.github.com/users/fastmonkeys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastmonkeys/subscriptions","organizations_url":"https://api.github.com/users/fastmonkeys/orgs","repos_url":"https://api.github.com/users/fastmonkeys/repos","events_url":"https://api.github.com/users/fastmonkeys/events{/privacy}","received_events_url":"https://api.github.com/users/fastmonkeys/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fastmonkeys/asomap","description":"Asomap is the frontend of the City of Helsinki map service for right-of-occupancy apartments","fork":false,"url":"https://api.github.com/repos/fastmonkeys/asomap","forks_url":"https://api.github.com/repos/fastmonkeys/asomap/forks","keys_url":"https://api.github.com/repos/fastmonkeys/asomap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fastmonkeys/asomap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fastmonkeys/asomap/teams","hooks_url":"https://api.github.com/repos/fastmonkeys/asomap/hooks","issue_events_url":"https://api.github.com/repos/fastmonkeys/asomap/issues/events{/number}","events_url":"https://api.github.com/repos/fastmonkeys/asomap/events","assignees_url":"https://api.github.com/repos/fastmonkeys/asomap/assignees{/user}","branches_url":"https://api.github.com/repos/fastmonkeys/asomap/branches{/branch}","tags_url":"https://api.github.com/repos/fastmonkeys/asomap/tags","blobs_url":"https://api.github.com/repos/fastmonkeys/asomap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fastmonkeys/asomap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fastmonkeys/asomap/git/refs{/sha}","trees_url":"https://api.github.com/repos/fastmonkeys/asomap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fastmonkeys/asomap/statuses/{sha}","languages_url":"https://api.github.com/repos/fastmonkeys/asomap/languages","stargazers_url":"https://api.github.com/repos/fastmonkeys/asomap/stargazers","contributors_url":"https://api.github.com/repos/fastmonkeys/asomap/contributors","subscribers_url":"https://api.github.com/repos/fastmonkeys/asomap/subscribers","subscription_url":"https://api.github.com/repos/fastmonkeys/asomap/subscription","commits_url":"https://api.github.com/repos/fastmonkeys/asomap/commits{/sha}","git_commits_url":"https://api.github.com/repos/fastmonkeys/asomap/git/commits{/sha}","comments_url":"https://api.github.com/repos/fastmonkeys/asomap/comments{/number}","issue_comment_url":"https://api.github.com/repos/fastmonkeys/asomap/issues/comments{/number}","contents_url":"https://api.github.com/repos/fastmonkeys/asomap/contents/{+path}","compare_url":"https://api.github.com/repos/fastmonkeys/asomap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fastmonkeys/asomap/merges","archive_url":"https://api.github.com/repos/fastmonkeys/asomap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fastmonkeys/asomap/downloads","issues_url":"https://api.github.com/repos/fastmonkeys/asomap/issues{/number}","pulls_url":"https://api.github.com/repos/fastmonkeys/asomap/pulls{/number}","milestones_url":"https://api.github.com/repos/fastmonkeys/asomap/milestones{/number}","notifications_url":"https://api.github.com/repos/fastmonkeys/asomap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fastmonkeys/asomap/labels{/name}","releases_url":"https://api.github.com/repos/fastmonkeys/asomap/releases{/id}","deployments_url":"https://api.github.com/repos/fastmonkeys/asomap/deployments","created_at":"2016-10-12T13:29:06Z","updated_at":"2016-10-24T11:47:22Z","pushed_at":"2016-11-01T10:37:54Z","git_url":"git://github.com/fastmonkeys/asomap.git","ssh_url":"git@github.com:fastmonkeys/asomap.git","clone_url":"https://github.com/fastmonkeys/asomap.git","svn_url":"https://github.com/fastmonkeys/asomap","homepage":null,"size":132,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"fastmonkeys:develop","ref":"develop","sha":"8d48d473daba12e7fb2b60404f68ee54302c457c","user":{"login":"fastmonkeys","id":946529,"avatar_url":"https://avatars.githubusercontent.com/u/946529?v=3","gravatar_id":"","url":"https://api.github.com/users/fastmonkeys","html_url":"https://github.com/fastmonkeys","followers_url":"https://api.github.com/users/fastmonkeys/followers","following_url":"https://api.github.com/users/fastmonkeys/following{/other_user}","gists_url":"https://api.github.com/users/fastmonkeys/gists{/gist_id}","starred_url":"https://api.github.com/users/fastmonkeys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastmonkeys/subscriptions","organizations_url":"https://api.github.com/users/fastmonkeys/orgs","repos_url":"https://api.github.com/users/fastmonkeys/repos","events_url":"https://api.github.com/users/fastmonkeys/events{/privacy}","received_events_url":"https://api.github.com/users/fastmonkeys/received_events","type":"Organization","site_admin":false},"repo":{"id":70702649,"name":"asomap","full_name":"fastmonkeys/asomap","owner":{"login":"fastmonkeys","id":946529,"avatar_url":"https://avatars.githubusercontent.com/u/946529?v=3","gravatar_id":"","url":"https://api.github.com/users/fastmonkeys","html_url":"https://github.com/fastmonkeys","followers_url":"https://api.github.com/users/fastmonkeys/followers","following_url":"https://api.github.com/users/fastmonkeys/following{/other_user}","gists_url":"https://api.github.com/users/fastmonkeys/gists{/gist_id}","starred_url":"https://api.github.com/users/fastmonkeys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastmonkeys/subscriptions","organizations_url":"https://api.github.com/users/fastmonkeys/orgs","repos_url":"https://api.github.com/users/fastmonkeys/repos","events_url":"https://api.github.com/users/fastmonkeys/events{/privacy}","received_events_url":"https://api.github.com/users/fastmonkeys/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fastmonkeys/asomap","description":"Asomap is the frontend of the City of Helsinki map service for right-of-occupancy apartments","fork":false,"url":"https://api.github.com/repos/fastmonkeys/asomap","forks_url":"https://api.github.com/repos/fastmonkeys/asomap/forks","keys_url":"https://api.github.com/repos/fastmonkeys/asomap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fastmonkeys/asomap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fastmonkeys/asomap/teams","hooks_url":"https://api.github.com/repos/fastmonkeys/asomap/hooks","issue_events_url":"https://api.github.com/repos/fastmonkeys/asomap/issues/events{/number}","events_url":"https://api.github.com/repos/fastmonkeys/asomap/events","assignees_url":"https://api.github.com/repos/fastmonkeys/asomap/assignees{/user}","branches_url":"https://api.github.com/repos/fastmonkeys/asomap/branches{/branch}","tags_url":"https://api.github.com/repos/fastmonkeys/asomap/tags","blobs_url":"https://api.github.com/repos/fastmonkeys/asomap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fastmonkeys/asomap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fastmonkeys/asomap/git/refs{/sha}","trees_url":"https://api.github.com/repos/fastmonkeys/asomap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fastmonkeys/asomap/statuses/{sha}","languages_url":"https://api.github.com/repos/fastmonkeys/asomap/languages","stargazers_url":"https://api.github.com/repos/fastmonkeys/asomap/stargazers","contributors_url":"https://api.github.com/repos/fastmonkeys/asomap/contributors","subscribers_url":"https://api.github.com/repos/fastmonkeys/asomap/subscribers","subscription_url":"https://api.github.com/repos/fastmonkeys/asomap/subscription","commits_url":"https://api.github.com/repos/fastmonkeys/asomap/commits{/sha}","git_commits_url":"https://api.github.com/repos/fastmonkeys/asomap/git/commits{/sha}","comments_url":"https://api.github.com/repos/fastmonkeys/asomap/comments{/number}","issue_comment_url":"https://api.github.com/repos/fastmonkeys/asomap/issues/comments{/number}","contents_url":"https://api.github.com/repos/fastmonkeys/asomap/contents/{+path}","compare_url":"https://api.github.com/repos/fastmonkeys/asomap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fastmonkeys/asomap/merges","archive_url":"https://api.github.com/repos/fastmonkeys/asomap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fastmonkeys/asomap/downloads","issues_url":"https://api.github.com/repos/fastmonkeys/asomap/issues{/number}","pulls_url":"https://api.github.com/repos/fastmonkeys/asomap/pulls{/number}","milestones_url":"https://api.github.com/repos/fastmonkeys/asomap/milestones{/number}","notifications_url":"https://api.github.com/repos/fastmonkeys/asomap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fastmonkeys/asomap/labels{/name}","releases_url":"https://api.github.com/repos/fastmonkeys/asomap/releases{/id}","deployments_url":"https://api.github.com/repos/fastmonkeys/asomap/deployments","created_at":"2016-10-12T13:29:06Z","updated_at":"2016-10-24T11:47:22Z","pushed_at":"2016-11-01T10:37:54Z","git_url":"git://github.com/fastmonkeys/asomap.git","ssh_url":"git@github.com:fastmonkeys/asomap.git","clone_url":"https://github.com/fastmonkeys/asomap.git","svn_url":"https://github.com/fastmonkeys/asomap","homepage":null,"size":132,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/fastmonkeys/asomap/pulls/47"},"html":{"href":"https://github.com/fastmonkeys/asomap/pull/47"},"issue":{"href":"https://api.github.com/repos/fastmonkeys/asomap/issues/47"},"comments":{"href":"https://api.github.com/repos/fastmonkeys/asomap/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/fastmonkeys/asomap/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/fastmonkeys/asomap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fastmonkeys/asomap/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/fastmonkeys/asomap/statuses/f9621082c7e8e4fd729a65e451946e38a5327c07"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"lraivio","id":946697,"avatar_url":"https://avatars.githubusercontent.com/u/946697?v=3","gravatar_id":"","url":"https://api.github.com/users/lraivio","html_url":"https://github.com/lraivio","followers_url":"https://api.github.com/users/lraivio/followers","following_url":"https://api.github.com/users/lraivio/following{/other_user}","gists_url":"https://api.github.com/users/lraivio/gists{/gist_id}","starred_url":"https://api.github.com/users/lraivio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lraivio/subscriptions","organizations_url":"https://api.github.com/users/lraivio/orgs","repos_url":"https://api.github.com/users/lraivio/repos","events_url":"https://api.github.com/users/lraivio/events{/privacy}","received_events_url":"https://api.github.com/users/lraivio/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":4,"additions":395,"deletions":330,"changed_files":21}}
{"actor":{"display_login":"lraivio"}}