{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/loop/pulls/comments/63098558","id":63098558,"diff_hunk":"@@ -243,44 +243,27 @@ $(BUILT)/add-on/install.rdf: add-on/install.rdf.in \\\n # optimize this away.  We used the shared_jsx_temporary to make this code more\n # readable.\n shared_jsx_files=$(wildcard shared/js/*.jsx)\n-built_ui_shared_js_files=$(shared_jsx_files:%.jsx=$(BUILT)/ui/%.js)\n-built_add_on_shared_js_files=$(shared_jsx_files:%.jsx=$(BUILT)/add-on/chrome/content/%.js)\n-built_standalone_shared_js_files=$(shared_jsx_files:%.jsx=$(BUILT)/standalone/content/%.js)\n-\n-# We can't use $(shared_jsx_files) here because % rules don't accept that.\n-$(BUILT)/standalone/content/shared/js/%.js: shared/js/%.jsx\n-\t@mkdir -p $(@D)\n-\t$(BABEL) $< --out-file $@\n-\n-# We can't use $(shared_jsx_files) here because % rules don't accept that.\n-$(BUILT)/add-on/chrome/content/shared/js/%.js: shared/js/%.jsx\n-\t@mkdir -p $(@D)\n-\t$(BABEL) $< --out-file $@\n-\n-# We can't use $(shared_jsx_files) here because % rules don't accept that.\n-$(BUILT)/ui/shared/js/%.js: shared/js/%.jsx\n-\t@mkdir -p $(@D)\n-\t$(BABEL) $< --out-file $@\n+shared_js_files=$(wildcard shared/js/*.js)\n+shared_test_files=$(wildcard shared/test/*.js)\n+built_ui_shared_js_files=$(shared_jsx_files:%.jsx=$(BUILT)/ui/%.js) $(shared_js_files:%.js=$(BUILT)/ui/%.js) $(shared_test_files:%.js=$(BUILT)/ui/%.js)\n+built_add_on_shared_js_files=$(shared_jsx_files:%.jsx=$(BUILT)/add-on/chrome/content/%.js) $(shared_js_files:%.js=$(BUILT)/add-on/chrome/content/%.js) $(shared_test_files:%.js=$(BUILT)/add-on/chrome/content/%.js)\n+built_standalone_shared_js_files=$(shared_jsx_files:%.jsx=$(BUILT)/standalone/content/%.js) $(shared_js_files:%.js=$(BUILT)/standalone/content/%.js) $(shared_test_files:%.js=$(BUILT)/standalone/content/%.js)\n \n #\n # The following sections are for the non-shared assets:\n #\n \n # ui-showcase\n ui_jsx_files=$(wildcard ui/*.jsx)\n-built_ui_js_files=$(ui_jsx_files:%.jsx=$(BUILT)/%.js)\n-\n-$(BUILT)/ui/%.js: ui/%.jsx\n-\t@mkdir -p $(@D)\n-\t$(BABEL) $< --out-file $@\n+ui_js_files=$(wildcard ui/*.js)\n+built_ui_js_files=$(ui_jsx_files:%.jsx=$(BUILT)/%.js) $(ui_js_files:%.js=$(BUILT)/%.js)\n \n # standalone\n standalone_jsx_files=$(wildcard standalone/content/js/*.jsx)\n-built_standalone_js_files=$(standalone_jsx_files:%.jsx=$(BUILT)/%.js)\n-\n-$(BUILT)/standalone/content/js/%.js: standalone/content/js/%.jsx\n-\t@mkdir -p $(@D)\n-\t$(BABEL) $< --out-file $@\n+standalone_js_files=$(wildcard standalone/content/js/*.js)\n+standalone_test_files=$(wildcard standalone/test/*.js)\n+standalone_misc_files=$(wildcard standalone/*.js)\n+built_standalone_js_files=$(standalone_jsx_files:%.jsx=$(BUILT)/%.js) $(standalone_js_files:%.js=$(BUILT)/%.js) $(standalone_test_files:%.js=$(BUILT)/%.js) $(standalone_misc_files:%.js=$(BUILT)/%.js)","path":"Makefile","position":61,"original_position":61,"commit_id":"0fe5a19dd29574fb4593558d263ce65830f9f0ba","original_commit_id":"0fe5a19dd29574fb4593558d263ce65830f9f0ba","user":{"login":"Mardak","id":438537,"avatar_url":"https://avatars.githubusercontent.com/u/438537?v=3","gravatar_id":"","url":"https://api.github.com/users/Mardak","html_url":"https://github.com/Mardak","followers_url":"https://api.github.com/users/Mardak/followers","following_url":"https://api.github.com/users/Mardak/following{/other_user}","gists_url":"https://api.github.com/users/Mardak/gists{/gist_id}","starred_url":"https://api.github.com/users/Mardak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mardak/subscriptions","organizations_url":"https://api.github.com/users/Mardak/orgs","repos_url":"https://api.github.com/users/Mardak/repos","events_url":"https://api.github.com/users/Mardak/events{/privacy}","received_events_url":"https://api.github.com/users/Mardak/received_events","type":"User","site_admin":false},"body":"Just to be explicit, this can be cleaned up with the `addprefix`","created_at":"2016-05-12T21:14:16Z","updated_at":"2016-05-12T21:14:16Z","html_url":"https://github.com/mozilla/loop/pull/422#discussion_r63098558","pull_request_url":"https://api.github.com/repos/mozilla/loop/pulls/422","_links":{"self":{"href":"https://api.github.com/repos/mozilla/loop/pulls/comments/63098558"},"html":{"href":"https://github.com/mozilla/loop/pull/422#discussion_r63098558"},"pull_request":{"href":"https://api.github.com/repos/mozilla/loop/pulls/422"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/loop/pulls/422","id":69508993,"html_url":"https://github.com/mozilla/loop/pull/422","diff_url":"https://github.com/mozilla/loop/pull/422.diff","patch_url":"https://github.com/mozilla/loop/pull/422.patch","issue_url":"https://api.github.com/repos/mozilla/loop/issues/422","number":422,"state":"closed","locked":false,"title":"Bug 1270525 - Use babel on all js files","user":{"login":"fzzzy","id":46048,"avatar_url":"https://avatars.githubusercontent.com/u/46048?v=3","gravatar_id":"","url":"https://api.github.com/users/fzzzy","html_url":"https://github.com/fzzzy","followers_url":"https://api.github.com/users/fzzzy/followers","following_url":"https://api.github.com/users/fzzzy/following{/other_user}","gists_url":"https://api.github.com/users/fzzzy/gists{/gist_id}","starred_url":"https://api.github.com/users/fzzzy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fzzzy/subscriptions","organizations_url":"https://api.github.com/users/fzzzy/orgs","repos_url":"https://api.github.com/users/fzzzy/repos","events_url":"https://api.github.com/users/fzzzy/events{/privacy}","received_events_url":"https://api.github.com/users/fzzzy/received_events","type":"User","site_admin":false},"body":"Switch to using simplified makefile with make's second pass","created_at":"2016-05-10T13:47:48Z","updated_at":"2016-05-12T21:14:16Z","closed_at":"2016-05-11T14:56:09Z","merged_at":null,"merge_commit_sha":"89126adf41ca7223a38c0d347a8dcc4769e88944","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/loop/pulls/422/commits","review_comments_url":"https://api.github.com/repos/mozilla/loop/pulls/422/comments","review_comment_url":"https://api.github.com/repos/mozilla/loop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/loop/issues/422/comments","statuses_url":"https://api.github.com/repos/mozilla/loop/statuses/0fe5a19dd29574fb4593558d263ce65830f9f0ba","head":{"label":"fzzzy:babelify-2","ref":"babelify-2","sha":"0fe5a19dd29574fb4593558d263ce65830f9f0ba","user":{"login":"fzzzy","id":46048,"avatar_url":"https://avatars.githubusercontent.com/u/46048?v=3","gravatar_id":"","url":"https://api.github.com/users/fzzzy","html_url":"https://github.com/fzzzy","followers_url":"https://api.github.com/users/fzzzy/followers","following_url":"https://api.github.com/users/fzzzy/following{/other_user}","gists_url":"https://api.github.com/users/fzzzy/gists{/gist_id}","starred_url":"https://api.github.com/users/fzzzy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fzzzy/subscriptions","organizations_url":"https://api.github.com/users/fzzzy/orgs","repos_url":"https://api.github.com/users/fzzzy/repos","events_url":"https://api.github.com/users/fzzzy/events{/privacy}","received_events_url":"https://api.github.com/users/fzzzy/received_events","type":"User","site_admin":false},"repo":{"id":56186573,"name":"loop","full_name":"fzzzy/loop","owner":{"login":"fzzzy","id":46048,"avatar_url":"https://avatars.githubusercontent.com/u/46048?v=3","gravatar_id":"","url":"https://api.github.com/users/fzzzy","html_url":"https://github.com/fzzzy","followers_url":"https://api.github.com/users/fzzzy/followers","following_url":"https://api.github.com/users/fzzzy/following{/other_user}","gists_url":"https://api.github.com/users/fzzzy/gists{/gist_id}","starred_url":"https://api.github.com/users/fzzzy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fzzzy/subscriptions","organizations_url":"https://api.github.com/users/fzzzy/orgs","repos_url":"https://api.github.com/users/fzzzy/repos","events_url":"https://api.github.com/users/fzzzy/events{/privacy}","received_events_url":"https://api.github.com/users/fzzzy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fzzzy/loop","description":"This is the development repository for Firefox Hello","fork":true,"url":"https://api.github.com/repos/fzzzy/loop","forks_url":"https://api.github.com/repos/fzzzy/loop/forks","keys_url":"https://api.github.com/repos/fzzzy/loop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fzzzy/loop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fzzzy/loop/teams","hooks_url":"https://api.github.com/repos/fzzzy/loop/hooks","issue_events_url":"https://api.github.com/repos/fzzzy/loop/issues/events{/number}","events_url":"https://api.github.com/repos/fzzzy/loop/events","assignees_url":"https://api.github.com/repos/fzzzy/loop/assignees{/user}","branches_url":"https://api.github.com/repos/fzzzy/loop/branches{/branch}","tags_url":"https://api.github.com/repos/fzzzy/loop/tags","blobs_url":"https://api.github.com/repos/fzzzy/loop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fzzzy/loop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fzzzy/loop/git/refs{/sha}","trees_url":"https://api.github.com/repos/fzzzy/loop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fzzzy/loop/statuses/{sha}","languages_url":"https://api.github.com/repos/fzzzy/loop/languages","stargazers_url":"https://api.github.com/repos/fzzzy/loop/stargazers","contributors_url":"https://api.github.com/repos/fzzzy/loop/contributors","subscribers_url":"https://api.github.com/repos/fzzzy/loop/subscribers","subscription_url":"https://api.github.com/repos/fzzzy/loop/subscription","commits_url":"https://api.github.com/repos/fzzzy/loop/commits{/sha}","git_commits_url":"https://api.github.com/repos/fzzzy/loop/git/commits{/sha}","comments_url":"https://api.github.com/repos/fzzzy/loop/comments{/number}","issue_comment_url":"https://api.github.com/repos/fzzzy/loop/issues/comments{/number}","contents_url":"https://api.github.com/repos/fzzzy/loop/contents/{+path}","compare_url":"https://api.github.com/repos/fzzzy/loop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fzzzy/loop/merges","archive_url":"https://api.github.com/repos/fzzzy/loop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fzzzy/loop/downloads","issues_url":"https://api.github.com/repos/fzzzy/loop/issues{/number}","pulls_url":"https://api.github.com/repos/fzzzy/loop/pulls{/number}","milestones_url":"https://api.github.com/repos/fzzzy/loop/milestones{/number}","notifications_url":"https://api.github.com/repos/fzzzy/loop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fzzzy/loop/labels{/name}","releases_url":"https://api.github.com/repos/fzzzy/loop/releases{/id}","deployments_url":"https://api.github.com/repos/fzzzy/loop/deployments","created_at":"2016-04-13T21:13:57Z","updated_at":"2016-04-13T21:13:59Z","pushed_at":"2016-05-12T19:55:13Z","git_url":"git://github.com/fzzzy/loop.git","ssh_url":"git@github.com:fzzzy/loop.git","clone_url":"https://github.com/fzzzy/loop.git","svn_url":"https://github.com/fzzzy/loop","homepage":"https://wiki.mozilla.org/Loop","size":16120,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"09cdfa3ce423c2b27c17491b1119722dfdc7ef2f","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":45496273,"name":"loop","full_name":"mozilla/loop","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/loop","description":"This is the development repository for Firefox Hello","fork":false,"url":"https://api.github.com/repos/mozilla/loop","forks_url":"https://api.github.com/repos/mozilla/loop/forks","keys_url":"https://api.github.com/repos/mozilla/loop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/loop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/loop/teams","hooks_url":"https://api.github.com/repos/mozilla/loop/hooks","issue_events_url":"https://api.github.com/repos/mozilla/loop/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/loop/events","assignees_url":"https://api.github.com/repos/mozilla/loop/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/loop/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/loop/tags","blobs_url":"https://api.github.com/repos/mozilla/loop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/loop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/loop/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/loop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/loop/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/loop/languages","stargazers_url":"https://api.github.com/repos/mozilla/loop/stargazers","contributors_url":"https://api.github.com/repos/mozilla/loop/contributors","subscribers_url":"https://api.github.com/repos/mozilla/loop/subscribers","subscription_url":"https://api.github.com/repos/mozilla/loop/subscription","commits_url":"https://api.github.com/repos/mozilla/loop/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/loop/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/loop/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/loop/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/loop/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/loop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/loop/merges","archive_url":"https://api.github.com/repos/mozilla/loop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/loop/downloads","issues_url":"https://api.github.com/repos/mozilla/loop/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/loop/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/loop/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/loop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/loop/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/loop/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/loop/deployments","created_at":"2015-11-03T21:18:47Z","updated_at":"2016-05-04T13:29:02Z","pushed_at":"2016-05-12T20:43:36Z","git_url":"git://github.com/mozilla/loop.git","ssh_url":"git@github.com:mozilla/loop.git","clone_url":"https://github.com/mozilla/loop.git","svn_url":"https://github.com/mozilla/loop","homepage":"https://wiki.mozilla.org/Loop","size":16648,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":16,"forks":28,"open_issues":16,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/loop/pulls/422"},"html":{"href":"https://github.com/mozilla/loop/pull/422"},"issue":{"href":"https://api.github.com/repos/mozilla/loop/issues/422"},"comments":{"href":"https://api.github.com/repos/mozilla/loop/issues/422/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/loop/pulls/422/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/loop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/loop/pulls/422/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/loop/statuses/0fe5a19dd29574fb4593558d263ce65830f9f0ba"}}}}