{"action":"created","issue":{"url":"https://api.github.com/repos/xapian/xapian/issues/120","repository_url":"https://api.github.com/repos/xapian/xapian","labels_url":"https://api.github.com/repos/xapian/xapian/issues/120/labels{/name}","comments_url":"https://api.github.com/repos/xapian/xapian/issues/120/comments","events_url":"https://api.github.com/repos/xapian/xapian/issues/120/events","html_url":"https://github.com/xapian/xapian/pull/120","id":170742806,"number":120,"title":"letor: API changes","user":{"login":"ayshtmr","id":6681897,"avatar_url":"https://avatars.githubusercontent.com/u/6681897?v=3","gravatar_id":"","url":"https://api.github.com/users/ayshtmr","html_url":"https://github.com/ayshtmr","followers_url":"https://api.github.com/users/ayshtmr/followers","following_url":"https://api.github.com/users/ayshtmr/following{/other_user}","gists_url":"https://api.github.com/users/ayshtmr/gists{/gist_id}","starred_url":"https://api.github.com/users/ayshtmr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayshtmr/subscriptions","organizations_url":"https://api.github.com/users/ayshtmr/orgs","repos_url":"https://api.github.com/users/ayshtmr/repos","events_url":"https://api.github.com/users/ayshtmr/events{/privacy}","received_events_url":"https://api.github.com/users/ayshtmr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2016-08-11T20:48:50Z","updated_at":"2016-08-17T14:55:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xapian/xapian/pulls/120","html_url":"https://github.com/xapian/xapian/pull/120","diff_url":"https://github.com/xapian/xapian/pull/120.diff","patch_url":"https://github.com/xapian/xapian/pull/120.patch"},"body":"This PR proposes final API changes to `xapian-letor`\r\n\r\n1. `FeatureVector` changes:\r\n    * Change type of `fvals` from `map<int,double>` to `vector<double>`\r\n    * Enable variable `fcount`\r\n    * Clean-up of unnecessary methods and remove `featurevector_internal.cc`\r\n2. Add `Feature` class and subclasses:\r\n    * `Feature` is an abstract base class. Each subclass calculates a single feature.\r\n    * `Feature::Internal` class does the work of supplying `Feature` subclasses with document statistics (`tf`, `coll_tf` etc). \r\n    * `Feature` subclass implementations and `Feature::Internal` class defined in `xapian-letor/feature`\r\n3. Add `FeatureList` class:\r\n    * `FeatureList` does the work of creating `FeatureVectors`\r\n    * It contains `vector<Feature*>` - calls each Feature object to return `fval` values\r\n4. Update `Letor` class methods according to changes mentioned above\r\n5. Add filename parameters in `Letor` and `Ranker` methods\r\n    * Training file and model to be saved as user supplied filenames\r\n6. Eliminate `FeatureManager`:\r\n    * `FeatureManager::create_feature_vectors(*)` is replaced by `FeatureList::create_feature_vectors(*)`\r\n    * `FeatureManager's` role of supplying certain document stats is replaced by `Feature::Internal` class methods\r\n7. Eliminate `Features` (`letor_features.h` & `letor_features.cc`):\r\n    * `Feature` subclasses do the work of calculating feature values\r\n8. Documentation updates"},"comment":{"url":"https://api.github.com/repos/xapian/xapian/issues/comments/240438153","html_url":"https://github.com/xapian/xapian/pull/120#issuecomment-240438153","issue_url":"https://api.github.com/repos/xapian/xapian/issues/120","id":240438153,"user":{"login":"jaylett","id":80187,"avatar_url":"https://avatars.githubusercontent.com/u/80187?v=3","gravatar_id":"","url":"https://api.github.com/users/jaylett","html_url":"https://github.com/jaylett","followers_url":"https://api.github.com/users/jaylett/followers","following_url":"https://api.github.com/users/jaylett/following{/other_user}","gists_url":"https://api.github.com/users/jaylett/gists{/gist_id}","starred_url":"https://api.github.com/users/jaylett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaylett/subscriptions","organizations_url":"https://api.github.com/users/jaylett/orgs","repos_url":"https://api.github.com/users/jaylett/repos","events_url":"https://api.github.com/users/jaylett/events{/privacy}","received_events_url":"https://api.github.com/users/jaylett/received_events","type":"User","site_admin":false},"created_at":"2016-08-17T14:55:25Z","updated_at":"2016-08-17T14:55:25Z","body":"I'm just manually running the tests on G++ 4.9 since we can't get travis to work at the moment. Should be ready to merge once you're done with the fixes :)"}}
{"actor":{"display_login":"jaylett"}}