{"action":"created","issue":{"url":"https://api.github.com/repos/danielsz/system/issues/97","repository_url":"https://api.github.com/repos/danielsz/system","labels_url":"https://api.github.com/repos/danielsz/system/issues/97/labels{/name}","comments_url":"https://api.github.com/repos/danielsz/system/issues/97/comments","events_url":"https://api.github.com/repos/danielsz/system/issues/97/events","html_url":"https://github.com/danielsz/system/issues/97","id":178098657,"number":97,"title":"reloaded.repl / system.repl inconsistency","user":{"login":"martinklepsch","id":97496,"avatar_url":"https://avatars.githubusercontent.com/u/97496?v=3","gravatar_id":"","url":"https://api.github.com/users/martinklepsch","html_url":"https://github.com/martinklepsch","followers_url":"https://api.github.com/users/martinklepsch/followers","following_url":"https://api.github.com/users/martinklepsch/following{/other_user}","gists_url":"https://api.github.com/users/martinklepsch/gists{/gist_id}","starred_url":"https://api.github.com/users/martinklepsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinklepsch/subscriptions","organizations_url":"https://api.github.com/users/martinklepsch/orgs","repos_url":"https://api.github.com/users/martinklepsch/repos","events_url":"https://api.github.com/users/martinklepsch/events{/privacy}","received_events_url":"https://api.github.com/users/martinklepsch/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-09-20T15:45:54Z","updated_at":"2016-09-21T11:50:32Z","closed_at":null,"body":"`reloaded.repl/set-init!` expects a function whereas `system.repl/set-init!` needs a var. Given that people may be used to `reloaded.repl` an extra\r\n```clojure\r\n{:pre [(var? sys)]}\r\n```\r\nmight be warranted. "},"comment":{"url":"https://api.github.com/repos/danielsz/system/issues/comments/248588598","html_url":"https://github.com/danielsz/system/issues/97#issuecomment-248588598","issue_url":"https://api.github.com/repos/danielsz/system/issues/97","id":248588598,"user":{"login":"danielsz","id":859131,"avatar_url":"https://avatars.githubusercontent.com/u/859131?v=3","gravatar_id":"","url":"https://api.github.com/users/danielsz","html_url":"https://github.com/danielsz","followers_url":"https://api.github.com/users/danielsz/followers","following_url":"https://api.github.com/users/danielsz/following{/other_user}","gists_url":"https://api.github.com/users/danielsz/gists{/gist_id}","starred_url":"https://api.github.com/users/danielsz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielsz/subscriptions","organizations_url":"https://api.github.com/users/danielsz/orgs","repos_url":"https://api.github.com/users/danielsz/repos","events_url":"https://api.github.com/users/danielsz/events{/privacy}","received_events_url":"https://api.github.com/users/danielsz/received_events","type":"User","site_admin":false},"created_at":"2016-09-21T11:50:32Z","updated_at":"2016-09-21T11:50:32Z","body":"When you discovered that `set-init!` wasn't called when `auto` was set to false, you did the right thing, you opened an issue. (It is fixed now). When you called `set-init!` yourself to get work done, you did what any hacker would do, and that's great. \r\n\r\nIt so happens that `boot.system` uses `reloaded.repl` internally. Users may or may not know that fact. These are implementation details, after all. If you hack your way in and are surprised that they actually diverged somewhat, it is understandable, but wishing they wouldn't have seems unwarranted. No claims are being made regarding their correspondence. `system` takes some liberties with `tools.namespace` as well. And for the same good reason that `system` is driven by its own concerns.\r\n \r\nIf you got an error because you passed a function instead of a Var, that is bad only in the sense that you had to resort to calling `set-init!` yourself in the first place. \r\n\r\nThe way a user sets a system is via the `sys` keyword. If `auto` is true, system restarts will be managed automatically, otherwise `sys` is initialized and the user handles restarts manually at the REPL.\r\n\r\nType `boot system -h` at the CLI or the equivalent  at the REPL, and there you have our API. Nothing more, nothing less. Making sure that the options are properly explained and that everything works as advertised, that is in my opinion serving the user's best interest. \r\n\r\nThank you for arguing and pushing and whatnot. :+1:  This gives me an opportunity to clarify my positions and polishing the product, so to speak.\r\n \r\n"}}
{"actor":{"display_login":"danielsz"}}