{"action":"created","issue":{"url":"https://api.github.com/repos/libopencm3/libopencm3/issues/588","labels_url":"https://api.github.com/repos/libopencm3/libopencm3/issues/588/labels{/name}","comments_url":"https://api.github.com/repos/libopencm3/libopencm3/issues/588/comments","events_url":"https://api.github.com/repos/libopencm3/libopencm3/issues/588/events","html_url":"https://github.com/libopencm3/libopencm3/pull/588","id":124573611,"number":588,"title":"A few \"logical OR\" --> \"bitwise OR\" in comments","user":{"login":"jpouellet","id":1231207,"avatar_url":"https://avatars.githubusercontent.com/u/1231207?v=3","gravatar_id":"","url":"https://api.github.com/users/jpouellet","html_url":"https://github.com/jpouellet","followers_url":"https://api.github.com/users/jpouellet/followers","following_url":"https://api.github.com/users/jpouellet/following{/other_user}","gists_url":"https://api.github.com/users/jpouellet/gists{/gist_id}","starred_url":"https://api.github.com/users/jpouellet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpouellet/subscriptions","organizations_url":"https://api.github.com/users/jpouellet/orgs","repos_url":"https://api.github.com/users/jpouellet/repos","events_url":"https://api.github.com/users/jpouellet/events{/privacy}","received_events_url":"https://api.github.com/users/jpouellet/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-01-02T03:50:15Z","updated_at":"2016-01-02T03:50:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/libopencm3/libopencm3/pulls/588","html_url":"https://github.com/libopencm3/libopencm3/pull/588","diff_url":"https://github.com/libopencm3/libopencm3/pull/588.diff","patch_url":"https://github.com/libopencm3/libopencm3/pull/588.patch"},"body":"These seem inverted from conventional naming to me, although I might just be going crazy :/\r\n\r\nhttps://en.wikipedia.org/wiki/Bitwise_operations_in_C#Logical_equivalents"},"comment":{"url":"https://api.github.com/repos/libopencm3/libopencm3/issues/comments/168361781","html_url":"https://github.com/libopencm3/libopencm3/pull/588#issuecomment-168361781","issue_url":"https://api.github.com/repos/libopencm3/libopencm3/issues/588","id":168361781,"user":{"login":"jpouellet","id":1231207,"avatar_url":"https://avatars.githubusercontent.com/u/1231207?v=3","gravatar_id":"","url":"https://api.github.com/users/jpouellet","html_url":"https://github.com/jpouellet","followers_url":"https://api.github.com/users/jpouellet/followers","following_url":"https://api.github.com/users/jpouellet/following{/other_user}","gists_url":"https://api.github.com/users/jpouellet/gists{/gist_id}","starred_url":"https://api.github.com/users/jpouellet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpouellet/subscriptions","organizations_url":"https://api.github.com/users/jpouellet/orgs","repos_url":"https://api.github.com/users/jpouellet/repos","events_url":"https://api.github.com/users/jpouellet/events{/privacy}","received_events_url":"https://api.github.com/users/jpouellet/received_events","type":"User","site_admin":false},"created_at":"2016-01-02T03:50:26Z","updated_at":"2016-01-02T03:50:26Z","body":"There are a few more which require a closer look to be sure:\r\n - lib/stm32/common/timer_common_all.c\r\n\r\n   ```\r\n   199:@param[in] irq Unsigned int32. @ref tim_irq_enable. Logical OR of all interrupt\r\n   213:@param[in] irq Unsigned int32. @ref tim_irq_enable. Logical OR of all interrupt\r\n   541:tim_x_cr2_ois. If several settings are to be made, use the logical OR of the\r\n   ```\r\n - lib/stm32/common/dac_common_all.c\r\n\r\n   ```\r\n   327:dac_trig1_sel or a logical OR of one of each of these to set both channels\r\n   346:dac_wave2_en or a logical OR of one of each of these to set both channels\r\n   395:logical OR of one of each of these to set both channels simultaneously.\r\n   ```\r\n - lib/stm32/common/rcc_common_all.c\r\n\r\n   ```\r\n   35: * @param[in] en Unsigned int32. Logical OR of all enables to be set\r\n   56: * @param[in] en Unsigned int32. Logical OR of all enables to be used for\r\n   77: * @param[in] reset Unsigned int32. Logical OR of all resets.\r\n   97: * @param[in] clear_reset Unsigned int32. Logical OR of all resets to be\r\n   ```\r\n - lib/stm32/common/dma_common_l1f013.c\r\n\r\n   ```\r\n   10:between 3 and 6 hardware peripheral DMA signals in a logical OR arrangement.\r\n   70:same channel may be cleared by using the logical OR of the interrupt flags.\r\n   74:@param[in] interrupts unsigned int32. Logical OR of interrupt numbers: @ref\r\n   ```\r\n"}}