{"action":"created","comment":{"url":"https://api.github.com/repos/Talend/react-cmf/pulls/comments/77584877","id":77584877,"diff_hunk":"@@ -0,0 +1,53 @@\n+import { hashHistory } from 'react-router';\n+import { routerReducer, routerMiddleware } from 'react-router-redux';\n+import { combineReducers, createStore, applyMiddleware, compose } from 'redux';\n+import thunk from 'redux-thunk';\n+\n+import reducers from './reducers';\n+\n+const enhancers = [];\n+const middlewares = [thunk];\n+if (window) {\n+  if (window.devToolsExtension) {\n+    enhancers.push(window.devToolsExtension());\n+  }\n+}\n+\n+const configuredRouterMiddleware = routerMiddleware(hashHistory);\n+middlewares.push(configuredRouterMiddleware);\n+\n+export default function initializeStore(reducer, initialState, enhancer, middleware) {\n+  let rootReducer;\n+  if (reducer) {\n+    rootReducer = combineReducers({\n+      app: reducer,\n+      routing: routerReducer,\n+      cmf: reducers,\n+    });\n+  }\n+  else {","path":"src/store.js","position":28,"original_position":28,"commit_id":"d606f54390082ea8fd6d3ca07b29f69c21539422","original_commit_id":"d606f54390082ea8fd6d3ca07b29f69c21539422","user":{"login":"talend-glorieux","id":19686241,"avatar_url":"https://avatars.githubusercontent.com/u/19686241?v=3","gravatar_id":"","url":"https://api.github.com/users/talend-glorieux","html_url":"https://github.com/talend-glorieux","followers_url":"https://api.github.com/users/talend-glorieux/followers","following_url":"https://api.github.com/users/talend-glorieux/following{/other_user}","gists_url":"https://api.github.com/users/talend-glorieux/gists{/gist_id}","starred_url":"https://api.github.com/users/talend-glorieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talend-glorieux/subscriptions","organizations_url":"https://api.github.com/users/talend-glorieux/orgs","repos_url":"https://api.github.com/users/talend-glorieux/repos","events_url":"https://api.github.com/users/talend-glorieux/events{/privacy}","received_events_url":"https://api.github.com/users/talend-glorieux/received_events","type":"User","site_admin":false},"body":"Is this formatting based on the eslint rules ?","created_at":"2016-09-06T07:31:50Z","updated_at":"2016-09-06T07:31:50Z","html_url":"https://github.com/Talend/react-cmf/pull/19#discussion_r77584877","pull_request_url":"https://api.github.com/repos/Talend/react-cmf/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/Talend/react-cmf/pulls/comments/77584877"},"html":{"href":"https://github.com/Talend/react-cmf/pull/19#discussion_r77584877"},"pull_request":{"href":"https://api.github.com/repos/Talend/react-cmf/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/Talend/react-cmf/pulls/19","id":83409670,"html_url":"https://github.com/Talend/react-cmf/pull/19","diff_url":"https://github.com/Talend/react-cmf/pull/19.diff","patch_url":"https://github.com/Talend/react-cmf/pull/19.patch","issue_url":"https://api.github.com/repos/Talend/react-cmf/issues/19","number":19,"state":"open","locked":false,"title":"feat: minimize setup","user":{"login":"jmfrancois","id":19857479,"avatar_url":"https://avatars.githubusercontent.com/u/19857479?v=3","gravatar_id":"","url":"https://api.github.com/users/jmfrancois","html_url":"https://github.com/jmfrancois","followers_url":"https://api.github.com/users/jmfrancois/followers","following_url":"https://api.github.com/users/jmfrancois/following{/other_user}","gists_url":"https://api.github.com/users/jmfrancois/gists{/gist_id}","starred_url":"https://api.github.com/users/jmfrancois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmfrancois/subscriptions","organizations_url":"https://api.github.com/users/jmfrancois/orgs","repos_url":"https://api.github.com/users/jmfrancois/repos","events_url":"https://api.github.com/users/jmfrancois/events{/privacy}","received_events_url":"https://api.github.com/users/jmfrancois/received_events","type":"User","site_admin":false},"body":"Add store and history init API\r\n\r\nThis is a proposals lets discuss it.\r\n\r\nThe main idea is to simplify init of the router / store so a user don't have to init theses, just call API.\r\n\r\nA user should not have to know how CMF is working. The main issue here is we have to isolate CMF related store from the APP and let the app combined reducer being passed as params to go into app.\r\n\r\n```\r\n* app\r\n|- the app related reducers\r\n* cmf\r\n|- settings\r\n|- components\r\n|- collections\r\n```\r\n","created_at":"2016-08-31T08:34:28Z","updated_at":"2016-09-06T07:31:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7548db7dd5116341f28ea8ec70dfe0c98144895e","assignee":{"login":"acateland","id":19344650,"avatar_url":"https://avatars.githubusercontent.com/u/19344650?v=3","gravatar_id":"","url":"https://api.github.com/users/acateland","html_url":"https://github.com/acateland","followers_url":"https://api.github.com/users/acateland/followers","following_url":"https://api.github.com/users/acateland/following{/other_user}","gists_url":"https://api.github.com/users/acateland/gists{/gist_id}","starred_url":"https://api.github.com/users/acateland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acateland/subscriptions","organizations_url":"https://api.github.com/users/acateland/orgs","repos_url":"https://api.github.com/users/acateland/repos","events_url":"https://api.github.com/users/acateland/events{/privacy}","received_events_url":"https://api.github.com/users/acateland/received_events","type":"User","site_admin":false},"assignees":[{"login":"acateland","id":19344650,"avatar_url":"https://avatars.githubusercontent.com/u/19344650?v=3","gravatar_id":"","url":"https://api.github.com/users/acateland","html_url":"https://github.com/acateland","followers_url":"https://api.github.com/users/acateland/followers","following_url":"https://api.github.com/users/acateland/following{/other_user}","gists_url":"https://api.github.com/users/acateland/gists{/gist_id}","starred_url":"https://api.github.com/users/acateland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acateland/subscriptions","organizations_url":"https://api.github.com/users/acateland/orgs","repos_url":"https://api.github.com/users/acateland/repos","events_url":"https://api.github.com/users/acateland/events{/privacy}","received_events_url":"https://api.github.com/users/acateland/received_events","type":"User","site_admin":false},{"login":"jmfrancois","id":19857479,"avatar_url":"https://avatars.githubusercontent.com/u/19857479?v=3","gravatar_id":"","url":"https://api.github.com/users/jmfrancois","html_url":"https://github.com/jmfrancois","followers_url":"https://api.github.com/users/jmfrancois/followers","following_url":"https://api.github.com/users/jmfrancois/following{/other_user}","gists_url":"https://api.github.com/users/jmfrancois/gists{/gist_id}","starred_url":"https://api.github.com/users/jmfrancois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmfrancois/subscriptions","organizations_url":"https://api.github.com/users/jmfrancois/orgs","repos_url":"https://api.github.com/users/jmfrancois/repos","events_url":"https://api.github.com/users/jmfrancois/events{/privacy}","received_events_url":"https://api.github.com/users/jmfrancois/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Talend/react-cmf/pulls/19/commits","review_comments_url":"https://api.github.com/repos/Talend/react-cmf/pulls/19/comments","review_comment_url":"https://api.github.com/repos/Talend/react-cmf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Talend/react-cmf/issues/19/comments","statuses_url":"https://api.github.com/repos/Talend/react-cmf/statuses/d606f54390082ea8fd6d3ca07b29f69c21539422","head":{"label":"Talend:jmfrancois-minimize-setup","ref":"jmfrancois-minimize-setup","sha":"d606f54390082ea8fd6d3ca07b29f69c21539422","user":{"login":"Talend","id":459687,"avatar_url":"https://avatars.githubusercontent.com/u/459687?v=3","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":65370811,"name":"react-cmf","full_name":"Talend/react-cmf","owner":{"login":"Talend","id":459687,"avatar_url":"https://avatars.githubusercontent.com/u/459687?v=3","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Talend/react-cmf","description":"A framework built on top of best react libraries","fork":false,"url":"https://api.github.com/repos/Talend/react-cmf","forks_url":"https://api.github.com/repos/Talend/react-cmf/forks","keys_url":"https://api.github.com/repos/Talend/react-cmf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/react-cmf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/react-cmf/teams","hooks_url":"https://api.github.com/repos/Talend/react-cmf/hooks","issue_events_url":"https://api.github.com/repos/Talend/react-cmf/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/react-cmf/events","assignees_url":"https://api.github.com/repos/Talend/react-cmf/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/react-cmf/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/react-cmf/tags","blobs_url":"https://api.github.com/repos/Talend/react-cmf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/react-cmf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/react-cmf/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/react-cmf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/react-cmf/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/react-cmf/languages","stargazers_url":"https://api.github.com/repos/Talend/react-cmf/stargazers","contributors_url":"https://api.github.com/repos/Talend/react-cmf/contributors","subscribers_url":"https://api.github.com/repos/Talend/react-cmf/subscribers","subscription_url":"https://api.github.com/repos/Talend/react-cmf/subscription","commits_url":"https://api.github.com/repos/Talend/react-cmf/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/react-cmf/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/react-cmf/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/react-cmf/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/react-cmf/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/react-cmf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/react-cmf/merges","archive_url":"https://api.github.com/repos/Talend/react-cmf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/react-cmf/downloads","issues_url":"https://api.github.com/repos/Talend/react-cmf/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/react-cmf/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/react-cmf/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/react-cmf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/react-cmf/labels{/name}","releases_url":"https://api.github.com/repos/Talend/react-cmf/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/react-cmf/deployments","created_at":"2016-08-10T09:47:27Z","updated_at":"2016-08-31T22:33:49Z","pushed_at":"2016-09-05T16:06:08Z","git_url":"git://github.com/Talend/react-cmf.git","ssh_url":"git@github.com:Talend/react-cmf.git","clone_url":"https://github.com/Talend/react-cmf.git","svn_url":"https://github.com/Talend/react-cmf","homepage":"https://talend.github.io/react-cmf","size":87,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":12,"forks":0,"open_issues":12,"watchers":5,"default_branch":"master"}},"base":{"label":"Talend:master","ref":"master","sha":"0a07775e78c26bfbb89335deb8a2a3beea50a7ed","user":{"login":"Talend","id":459687,"avatar_url":"https://avatars.githubusercontent.com/u/459687?v=3","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":65370811,"name":"react-cmf","full_name":"Talend/react-cmf","owner":{"login":"Talend","id":459687,"avatar_url":"https://avatars.githubusercontent.com/u/459687?v=3","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Talend/react-cmf","description":"A framework built on top of best react libraries","fork":false,"url":"https://api.github.com/repos/Talend/react-cmf","forks_url":"https://api.github.com/repos/Talend/react-cmf/forks","keys_url":"https://api.github.com/repos/Talend/react-cmf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/react-cmf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/react-cmf/teams","hooks_url":"https://api.github.com/repos/Talend/react-cmf/hooks","issue_events_url":"https://api.github.com/repos/Talend/react-cmf/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/react-cmf/events","assignees_url":"https://api.github.com/repos/Talend/react-cmf/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/react-cmf/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/react-cmf/tags","blobs_url":"https://api.github.com/repos/Talend/react-cmf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/react-cmf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/react-cmf/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/react-cmf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/react-cmf/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/react-cmf/languages","stargazers_url":"https://api.github.com/repos/Talend/react-cmf/stargazers","contributors_url":"https://api.github.com/repos/Talend/react-cmf/contributors","subscribers_url":"https://api.github.com/repos/Talend/react-cmf/subscribers","subscription_url":"https://api.github.com/repos/Talend/react-cmf/subscription","commits_url":"https://api.github.com/repos/Talend/react-cmf/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/react-cmf/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/react-cmf/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/react-cmf/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/react-cmf/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/react-cmf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/react-cmf/merges","archive_url":"https://api.github.com/repos/Talend/react-cmf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/react-cmf/downloads","issues_url":"https://api.github.com/repos/Talend/react-cmf/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/react-cmf/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/react-cmf/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/react-cmf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/react-cmf/labels{/name}","releases_url":"https://api.github.com/repos/Talend/react-cmf/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/react-cmf/deployments","created_at":"2016-08-10T09:47:27Z","updated_at":"2016-08-31T22:33:49Z","pushed_at":"2016-09-05T16:06:08Z","git_url":"git://github.com/Talend/react-cmf.git","ssh_url":"git@github.com:Talend/react-cmf.git","clone_url":"https://github.com/Talend/react-cmf.git","svn_url":"https://github.com/Talend/react-cmf","homepage":"https://talend.github.io/react-cmf","size":87,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":12,"forks":0,"open_issues":12,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Talend/react-cmf/pulls/19"},"html":{"href":"https://github.com/Talend/react-cmf/pull/19"},"issue":{"href":"https://api.github.com/repos/Talend/react-cmf/issues/19"},"comments":{"href":"https://api.github.com/repos/Talend/react-cmf/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/Talend/react-cmf/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/Talend/react-cmf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Talend/react-cmf/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/Talend/react-cmf/statuses/d606f54390082ea8fd6d3ca07b29f69c21539422"}}}}
{"actor":{"display_login":"talend-glorieux"}}