{"action":"created","comment":{"url":"https://api.github.com/repos/AeroPython/PyFME/pulls/comments/78775310","id":78775310,"diff_hunk":"@@ -28,7 +28,7 @@\n from pyfme.simulator import BatchSimulation\n from pyfme.utils.trimmer import steady_state_flight_trimmer\n \n-aircraft = Cessna310()\n+aircraft = Cessna172()","path":"examples/example_001.py","position":14,"original_position":14,"commit_id":"64a3bf990af11d087eb9ccc58f8f52506ea2d13d","original_commit_id":"d7ff0602aa0720a8d5427ee408e5430e84f86725","user":{"login":"aqreed","id":20933068,"avatar_url":"https://avatars.githubusercontent.com/u/20933068?v=3","gravatar_id":"","url":"https://api.github.com/users/aqreed","html_url":"https://github.com/aqreed","followers_url":"https://api.github.com/users/aqreed/followers","following_url":"https://api.github.com/users/aqreed/following{/other_user}","gists_url":"https://api.github.com/users/aqreed/gists{/gist_id}","starred_url":"https://api.github.com/users/aqreed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aqreed/subscriptions","organizations_url":"https://api.github.com/users/aqreed/orgs","repos_url":"https://api.github.com/users/aqreed/repos","events_url":"https://api.github.com/users/aqreed/events{/privacy}","received_events_url":"https://api.github.com/users/aqreed/received_events","type":"User","site_admin":false},"body":"perdona que se me habia pasado esto! cuando tengas tiempo me explicas  y colaboro con loq  pueda","created_at":"2016-09-14T15:41:38Z","updated_at":"2016-09-14T15:41:38Z","html_url":"https://github.com/AeroPython/PyFME/pull/79#discussion_r78775310","pull_request_url":"https://api.github.com/repos/AeroPython/PyFME/pulls/79","_links":{"self":{"href":"https://api.github.com/repos/AeroPython/PyFME/pulls/comments/78775310"},"html":{"href":"https://github.com/AeroPython/PyFME/pull/79#discussion_r78775310"},"pull_request":{"href":"https://api.github.com/repos/AeroPython/PyFME/pulls/79"}}},"pull_request":{"url":"https://api.github.com/repos/AeroPython/PyFME/pulls/79","id":84932251,"html_url":"https://github.com/AeroPython/PyFME/pull/79","diff_url":"https://github.com/AeroPython/PyFME/pull/79.diff","patch_url":"https://github.com/AeroPython/PyFME/pull/79.patch","issue_url":"https://api.github.com/repos/AeroPython/PyFME/issues/79","number":79,"state":"open","locked":false,"title":"cessna172 with [LDY] in wind axes","user":{"login":"aqreed","id":20933068,"avatar_url":"https://avatars.githubusercontent.com/u/20933068?v=3","gravatar_id":"","url":"https://api.github.com/users/aqreed","html_url":"https://github.com/aqreed","followers_url":"https://api.github.com/users/aqreed/followers","following_url":"https://api.github.com/users/aqreed/following{/other_user}","gists_url":"https://api.github.com/users/aqreed/gists{/gist_id}","starred_url":"https://api.github.com/users/aqreed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aqreed/subscriptions","organizations_url":"https://api.github.com/users/aqreed/orgs","repos_url":"https://api.github.com/users/aqreed/repos","events_url":"https://api.github.com/users/aqreed/events{/privacy}","received_events_url":"https://api.github.com/users/aqreed/received_events","type":"User","site_admin":false},"body":"After indentation modifications, addressing of the remaining FIXMEs and including pqr in the model along with the aerodynamics data ","created_at":"2016-09-12T19:46:35Z","updated_at":"2016-09-14T15:41:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"496264d5c24071e935c1804e0a7d4c412ca46efd","assignee":{"login":"aqreed","id":20933068,"avatar_url":"https://avatars.githubusercontent.com/u/20933068?v=3","gravatar_id":"","url":"https://api.github.com/users/aqreed","html_url":"https://github.com/aqreed","followers_url":"https://api.github.com/users/aqreed/followers","following_url":"https://api.github.com/users/aqreed/following{/other_user}","gists_url":"https://api.github.com/users/aqreed/gists{/gist_id}","starred_url":"https://api.github.com/users/aqreed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aqreed/subscriptions","organizations_url":"https://api.github.com/users/aqreed/orgs","repos_url":"https://api.github.com/users/aqreed/repos","events_url":"https://api.github.com/users/aqreed/events{/privacy}","received_events_url":"https://api.github.com/users/aqreed/received_events","type":"User","site_admin":false},"assignees":[{"login":"aqreed","id":20933068,"avatar_url":"https://avatars.githubusercontent.com/u/20933068?v=3","gravatar_id":"","url":"https://api.github.com/users/aqreed","html_url":"https://github.com/aqreed","followers_url":"https://api.github.com/users/aqreed/followers","following_url":"https://api.github.com/users/aqreed/following{/other_user}","gists_url":"https://api.github.com/users/aqreed/gists{/gist_id}","starred_url":"https://api.github.com/users/aqreed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aqreed/subscriptions","organizations_url":"https://api.github.com/users/aqreed/orgs","repos_url":"https://api.github.com/users/aqreed/repos","events_url":"https://api.github.com/users/aqreed/events{/privacy}","received_events_url":"https://api.github.com/users/aqreed/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/AeroPython/PyFME/milestones/2","html_url":"https://github.com/AeroPython/PyFME/milestones/v0.1","labels_url":"https://api.github.com/repos/AeroPython/PyFME/milestones/2/labels","id":1505917,"number":2,"title":"v0.1","description":"Desde el punto de vista de las **funcionalidades**:\r\n\r\n* Esta versión no espera implementar grandes cambios en cuanto a modelos de avión, modelos dinámicos, de entorno (vientos, atmósfera...), sino aumentar nuestra confianza en la implementación actual, tanto en cuanto al uso del paquete como en cuanto a los resultados obtenidos.\r\n\r\n* Definida una maniobra (deflexiones de mandos, posición de palanca de gases...) mediante un array de entrada el avión debe ser capaz de ejecutarla, proporcionando el simulador el vector de estado en cada instante y el resto de variables que puedan ser de interés. (Pertenece al anterior pero no llegó a implementarse correctamente).\r\n\r\n* Al finalizar el hito, basándonos en las maniobras que hayamos desarrollado para el apartado anterior fijaremos las que creamos necesarias como maniobras de prueba y que mantendremos a lo largo de todo el desarrollo del simulador adaptándolas a los cambios que vayan haciéndose en el código (nuevas interfaces, OOP...)\r\n\r\n* Implementar un trimador.\r\n\r\nDesde el punto de vista del **código**:\r\n\r\n* Mantener las premisas anteriores en cuanto buenas prácticas respetando el pep8.\r\n* Adaptar el código anterior y nuevo a los convenios de nombres y cabeceras fijados por consenso.\r\n* Mantener los tests unitarios ayudados por Travis CI para la integración continua.\r\n* Llegar a un consenso sobre los nombres de las variables para mantener la uniformidad en el código.\r\n\r\nDesde el punto de vista del **equipo de desarrollo**:\r\n\r\n* Mantener involucrados a todos los miembros que han participado hasta ahora y tratar de atraer a nuevos.\r\n* Fomentar que cada miembro del equipo se vincule a las áreas que más puedan interesarle.\r\n* Mejorar y asentar la soltura adquirida con git/GitHub y el flujo de trabajo elegido.","creator":{"login":"AlexS12","id":6061587,"avatar_url":"https://avatars.githubusercontent.com/u/6061587?v=3","gravatar_id":"","url":"https://api.github.com/users/AlexS12","html_url":"https://github.com/AlexS12","followers_url":"https://api.github.com/users/AlexS12/followers","following_url":"https://api.github.com/users/AlexS12/following{/other_user}","gists_url":"https://api.github.com/users/AlexS12/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexS12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexS12/subscriptions","organizations_url":"https://api.github.com/users/AlexS12/orgs","repos_url":"https://api.github.com/users/AlexS12/repos","events_url":"https://api.github.com/users/AlexS12/events{/privacy}","received_events_url":"https://api.github.com/users/AlexS12/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":21,"state":"open","created_at":"2016-01-13T23:00:50Z","updated_at":"2016-09-13T16:02:31Z","due_on":"2016-09-14T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/AeroPython/PyFME/pulls/79/commits","review_comments_url":"https://api.github.com/repos/AeroPython/PyFME/pulls/79/comments","review_comment_url":"https://api.github.com/repos/AeroPython/PyFME/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AeroPython/PyFME/issues/79/comments","statuses_url":"https://api.github.com/repos/AeroPython/PyFME/statuses/64a3bf990af11d087eb9ccc58f8f52506ea2d13d","head":{"label":"aqreed:master","ref":"master","sha":"64a3bf990af11d087eb9ccc58f8f52506ea2d13d","user":{"login":"aqreed","id":20933068,"avatar_url":"https://avatars.githubusercontent.com/u/20933068?v=3","gravatar_id":"","url":"https://api.github.com/users/aqreed","html_url":"https://github.com/aqreed","followers_url":"https://api.github.com/users/aqreed/followers","following_url":"https://api.github.com/users/aqreed/following{/other_user}","gists_url":"https://api.github.com/users/aqreed/gists{/gist_id}","starred_url":"https://api.github.com/users/aqreed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aqreed/subscriptions","organizations_url":"https://api.github.com/users/aqreed/orgs","repos_url":"https://api.github.com/users/aqreed/repos","events_url":"https://api.github.com/users/aqreed/events{/privacy}","received_events_url":"https://api.github.com/users/aqreed/received_events","type":"User","site_admin":false},"repo":{"id":66288515,"name":"PyFME","full_name":"aqreed/PyFME","owner":{"login":"aqreed","id":20933068,"avatar_url":"https://avatars.githubusercontent.com/u/20933068?v=3","gravatar_id":"","url":"https://api.github.com/users/aqreed","html_url":"https://github.com/aqreed","followers_url":"https://api.github.com/users/aqreed/followers","following_url":"https://api.github.com/users/aqreed/following{/other_user}","gists_url":"https://api.github.com/users/aqreed/gists{/gist_id}","starred_url":"https://api.github.com/users/aqreed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aqreed/subscriptions","organizations_url":"https://api.github.com/users/aqreed/orgs","repos_url":"https://api.github.com/users/aqreed/repos","events_url":"https://api.github.com/users/aqreed/events{/privacy}","received_events_url":"https://api.github.com/users/aqreed/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aqreed/PyFME","description":"Python Flight Mechanics Engine","fork":true,"url":"https://api.github.com/repos/aqreed/PyFME","forks_url":"https://api.github.com/repos/aqreed/PyFME/forks","keys_url":"https://api.github.com/repos/aqreed/PyFME/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aqreed/PyFME/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aqreed/PyFME/teams","hooks_url":"https://api.github.com/repos/aqreed/PyFME/hooks","issue_events_url":"https://api.github.com/repos/aqreed/PyFME/issues/events{/number}","events_url":"https://api.github.com/repos/aqreed/PyFME/events","assignees_url":"https://api.github.com/repos/aqreed/PyFME/assignees{/user}","branches_url":"https://api.github.com/repos/aqreed/PyFME/branches{/branch}","tags_url":"https://api.github.com/repos/aqreed/PyFME/tags","blobs_url":"https://api.github.com/repos/aqreed/PyFME/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aqreed/PyFME/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aqreed/PyFME/git/refs{/sha}","trees_url":"https://api.github.com/repos/aqreed/PyFME/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aqreed/PyFME/statuses/{sha}","languages_url":"https://api.github.com/repos/aqreed/PyFME/languages","stargazers_url":"https://api.github.com/repos/aqreed/PyFME/stargazers","contributors_url":"https://api.github.com/repos/aqreed/PyFME/contributors","subscribers_url":"https://api.github.com/repos/aqreed/PyFME/subscribers","subscription_url":"https://api.github.com/repos/aqreed/PyFME/subscription","commits_url":"https://api.github.com/repos/aqreed/PyFME/commits{/sha}","git_commits_url":"https://api.github.com/repos/aqreed/PyFME/git/commits{/sha}","comments_url":"https://api.github.com/repos/aqreed/PyFME/comments{/number}","issue_comment_url":"https://api.github.com/repos/aqreed/PyFME/issues/comments{/number}","contents_url":"https://api.github.com/repos/aqreed/PyFME/contents/{+path}","compare_url":"https://api.github.com/repos/aqreed/PyFME/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aqreed/PyFME/merges","archive_url":"https://api.github.com/repos/aqreed/PyFME/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aqreed/PyFME/downloads","issues_url":"https://api.github.com/repos/aqreed/PyFME/issues{/number}","pulls_url":"https://api.github.com/repos/aqreed/PyFME/pulls{/number}","milestones_url":"https://api.github.com/repos/aqreed/PyFME/milestones{/number}","notifications_url":"https://api.github.com/repos/aqreed/PyFME/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aqreed/PyFME/labels{/name}","releases_url":"https://api.github.com/repos/aqreed/PyFME/releases{/id}","deployments_url":"https://api.github.com/repos/aqreed/PyFME/deployments","created_at":"2016-08-22T16:17:08Z","updated_at":"2016-08-23T18:34:06Z","pushed_at":"2016-09-13T21:35:23Z","git_url":"git://github.com/aqreed/PyFME.git","ssh_url":"git@github.com:aqreed/PyFME.git","clone_url":"https://github.com/aqreed/PyFME.git","svn_url":"https://github.com/aqreed/PyFME","homepage":"http://pyfme.readthedocs.org/","size":2994,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AeroPython:master","ref":"master","sha":"79c36f8bfa6d5cb6eb0901a0182d5d21efe0638b","user":{"login":"AeroPython","id":6246900,"avatar_url":"https://avatars.githubusercontent.com/u/6246900?v=3","gravatar_id":"","url":"https://api.github.com/users/AeroPython","html_url":"https://github.com/AeroPython","followers_url":"https://api.github.com/users/AeroPython/followers","following_url":"https://api.github.com/users/AeroPython/following{/other_user}","gists_url":"https://api.github.com/users/AeroPython/gists{/gist_id}","starred_url":"https://api.github.com/users/AeroPython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AeroPython/subscriptions","organizations_url":"https://api.github.com/users/AeroPython/orgs","repos_url":"https://api.github.com/users/AeroPython/repos","events_url":"https://api.github.com/users/AeroPython/events{/privacy}","received_events_url":"https://api.github.com/users/AeroPython/received_events","type":"Organization","site_admin":false},"repo":{"id":42995365,"name":"PyFME","full_name":"AeroPython/PyFME","owner":{"login":"AeroPython","id":6246900,"avatar_url":"https://avatars.githubusercontent.com/u/6246900?v=3","gravatar_id":"","url":"https://api.github.com/users/AeroPython","html_url":"https://github.com/AeroPython","followers_url":"https://api.github.com/users/AeroPython/followers","following_url":"https://api.github.com/users/AeroPython/following{/other_user}","gists_url":"https://api.github.com/users/AeroPython/gists{/gist_id}","starred_url":"https://api.github.com/users/AeroPython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AeroPython/subscriptions","organizations_url":"https://api.github.com/users/AeroPython/orgs","repos_url":"https://api.github.com/users/AeroPython/repos","events_url":"https://api.github.com/users/AeroPython/events{/privacy}","received_events_url":"https://api.github.com/users/AeroPython/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AeroPython/PyFME","description":"Python Flight Mechanics Engine","fork":false,"url":"https://api.github.com/repos/AeroPython/PyFME","forks_url":"https://api.github.com/repos/AeroPython/PyFME/forks","keys_url":"https://api.github.com/repos/AeroPython/PyFME/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AeroPython/PyFME/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AeroPython/PyFME/teams","hooks_url":"https://api.github.com/repos/AeroPython/PyFME/hooks","issue_events_url":"https://api.github.com/repos/AeroPython/PyFME/issues/events{/number}","events_url":"https://api.github.com/repos/AeroPython/PyFME/events","assignees_url":"https://api.github.com/repos/AeroPython/PyFME/assignees{/user}","branches_url":"https://api.github.com/repos/AeroPython/PyFME/branches{/branch}","tags_url":"https://api.github.com/repos/AeroPython/PyFME/tags","blobs_url":"https://api.github.com/repos/AeroPython/PyFME/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AeroPython/PyFME/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AeroPython/PyFME/git/refs{/sha}","trees_url":"https://api.github.com/repos/AeroPython/PyFME/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AeroPython/PyFME/statuses/{sha}","languages_url":"https://api.github.com/repos/AeroPython/PyFME/languages","stargazers_url":"https://api.github.com/repos/AeroPython/PyFME/stargazers","contributors_url":"https://api.github.com/repos/AeroPython/PyFME/contributors","subscribers_url":"https://api.github.com/repos/AeroPython/PyFME/subscribers","subscription_url":"https://api.github.com/repos/AeroPython/PyFME/subscription","commits_url":"https://api.github.com/repos/AeroPython/PyFME/commits{/sha}","git_commits_url":"https://api.github.com/repos/AeroPython/PyFME/git/commits{/sha}","comments_url":"https://api.github.com/repos/AeroPython/PyFME/comments{/number}","issue_comment_url":"https://api.github.com/repos/AeroPython/PyFME/issues/comments{/number}","contents_url":"https://api.github.com/repos/AeroPython/PyFME/contents/{+path}","compare_url":"https://api.github.com/repos/AeroPython/PyFME/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AeroPython/PyFME/merges","archive_url":"https://api.github.com/repos/AeroPython/PyFME/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AeroPython/PyFME/downloads","issues_url":"https://api.github.com/repos/AeroPython/PyFME/issues{/number}","pulls_url":"https://api.github.com/repos/AeroPython/PyFME/pulls{/number}","milestones_url":"https://api.github.com/repos/AeroPython/PyFME/milestones{/number}","notifications_url":"https://api.github.com/repos/AeroPython/PyFME/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AeroPython/PyFME/labels{/name}","releases_url":"https://api.github.com/repos/AeroPython/PyFME/releases{/id}","deployments_url":"https://api.github.com/repos/AeroPython/PyFME/deployments","created_at":"2015-09-23T10:47:58Z","updated_at":"2016-08-22T16:18:20Z","pushed_at":"2016-09-13T21:35:24Z","git_url":"git://github.com/AeroPython/PyFME.git","ssh_url":"git@github.com:AeroPython/PyFME.git","clone_url":"https://github.com/AeroPython/PyFME.git","svn_url":"https://github.com/AeroPython/PyFME","homepage":"http://pyfme.readthedocs.org/","size":2970,"stargazers_count":12,"watchers_count":12,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":17,"forks":12,"open_issues":17,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AeroPython/PyFME/pulls/79"},"html":{"href":"https://github.com/AeroPython/PyFME/pull/79"},"issue":{"href":"https://api.github.com/repos/AeroPython/PyFME/issues/79"},"comments":{"href":"https://api.github.com/repos/AeroPython/PyFME/issues/79/comments"},"review_comments":{"href":"https://api.github.com/repos/AeroPython/PyFME/pulls/79/comments"},"review_comment":{"href":"https://api.github.com/repos/AeroPython/PyFME/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AeroPython/PyFME/pulls/79/commits"},"statuses":{"href":"https://api.github.com/repos/AeroPython/PyFME/statuses/64a3bf990af11d087eb9ccc58f8f52506ea2d13d"}}}}
{"actor":{"display_login":"aqreed"}}