{"action":"created","comment":{"url":"https://api.github.com/repos/opencog/opencog/pulls/comments/73007889","id":73007889,"diff_hunk":"@@ -326,13 +326,13 @@\n \t\tresult\n \t\t; else check if entity is an evaluation or predicate or schema\n \t\t(let ((type (cog-type entity)))\n-\t\t\t(if (or (equal? type 'PredicateNode)\n-\t\t\t\t   (equal? type 'GroundedPredicateNode)\n+\t\t\t(if (or (equal? type 'GroundedPredicateNode)\n \t\t\t\t   (equal? type 'DefinedPredicateNode))\n \t\t\t\t(set! result (cog-evaluate! (Evaluation entity (List)))))\n-\t\t\t(if (or (equal? type 'SchemaNode)\n-            \t\t(equal? type 'GroundedSchemaNode)\n-            \t    (equal? type 'DefinedSchemaeNode))\n+\t\t\t(if (equal? type 'PredicateNode)\n+\t\t\t\t(set! result (cog-tv entity)))","path":"opencog/openpsi/utilities.scm","position":13,"original_position":13,"commit_id":"255ac40a46ca72d1fe5b4f88e3959a99a2c6658d","original_commit_id":"255ac40a46ca72d1fe5b4f88e3959a99a2c6658d","user":{"login":"eddiemonroe","id":4316602,"avatar_url":"https://avatars.githubusercontent.com/u/4316602?v=3","gravatar_id":"","url":"https://api.github.com/users/eddiemonroe","html_url":"https://github.com/eddiemonroe","followers_url":"https://api.github.com/users/eddiemonroe/followers","following_url":"https://api.github.com/users/eddiemonroe/following{/other_user}","gists_url":"https://api.github.com/users/eddiemonroe/gists{/gist_id}","starred_url":"https://api.github.com/users/eddiemonroe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddiemonroe/subscriptions","organizations_url":"https://api.github.com/users/eddiemonroe/orgs","repos_url":"https://api.github.com/users/eddiemonroe/repos","events_url":"https://api.github.com/users/eddiemonroe/events{/privacy}","received_events_url":"https://api.github.com/users/eddiemonroe/received_events","type":"User","site_admin":false},"body":"@bgoertzel What about the issue of (a) using EvaluationLink for assigning values to predicates with no arguments (for consistency with predicates that do have arguments) vs. (b) using the PredicateNode TV (rather than EvaluationLink) to assign value to predicates that don't have arguments?\r\n\r\nIt seems to me there should be an OpenCog standard here. For example, if openpsi wants to know the value of a 0-ary predicate that is defined by a different component of the system (e.g., a PAU like voice-width), where should openpsi look to get it's value from, the PredicateNode TV or a wrapped EvaluationLink TV?","created_at":"2016-08-01T16:23:48Z","updated_at":"2016-08-01T16:23:48Z","html_url":"https://github.com/opencog/opencog/pull/2334#discussion_r73007889","pull_request_url":"https://api.github.com/repos/opencog/opencog/pulls/2334","_links":{"self":{"href":"https://api.github.com/repos/opencog/opencog/pulls/comments/73007889"},"html":{"href":"https://github.com/opencog/opencog/pull/2334#discussion_r73007889"},"pull_request":{"href":"https://api.github.com/repos/opencog/opencog/pulls/2334"}}},"pull_request":{"url":"https://api.github.com/repos/opencog/opencog/pulls/2334","id":79453810,"html_url":"https://github.com/opencog/opencog/pull/2334","diff_url":"https://github.com/opencog/opencog/pull/2334.diff","patch_url":"https://github.com/opencog/opencog/pull/2334.patch","issue_url":"https://api.github.com/repos/opencog/opencog/issues/2334","number":2334,"state":"closed","locked":false,"title":"a small cleanup of psi-dynamics ","user":{"login":"AmeBel","id":2135577,"avatar_url":"https://avatars.githubusercontent.com/u/2135577?v=3","gravatar_id":"","url":"https://api.github.com/users/AmeBel","html_url":"https://github.com/AmeBel","followers_url":"https://api.github.com/users/AmeBel/followers","following_url":"https://api.github.com/users/AmeBel/following{/other_user}","gists_url":"https://api.github.com/users/AmeBel/gists{/gist_id}","starred_url":"https://api.github.com/users/AmeBel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AmeBel/subscriptions","organizations_url":"https://api.github.com/users/AmeBel/orgs","repos_url":"https://api.github.com/users/AmeBel/repos","events_url":"https://api.github.com/users/AmeBel/events{/privacy}","received_events_url":"https://api.github.com/users/AmeBel/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-07-30T10:13:54Z","updated_at":"2016-08-01T16:23:48Z","closed_at":"2016-08-01T01:49:28Z","merged_at":"2016-08-01T01:49:28Z","merge_commit_sha":"fd5a3b38457cf8dc4f6d93d64248d7d939f2efc8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/opencog/opencog/pulls/2334/commits","review_comments_url":"https://api.github.com/repos/opencog/opencog/pulls/2334/comments","review_comment_url":"https://api.github.com/repos/opencog/opencog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opencog/opencog/issues/2334/comments","statuses_url":"https://api.github.com/repos/opencog/opencog/statuses/255ac40a46ca72d1fe5b4f88e3959a99a2c6658d","head":{"label":"AmeBel:psi-dynamics","ref":"psi-dynamics","sha":"255ac40a46ca72d1fe5b4f88e3959a99a2c6658d","user":{"login":"AmeBel","id":2135577,"avatar_url":"https://avatars.githubusercontent.com/u/2135577?v=3","gravatar_id":"","url":"https://api.github.com/users/AmeBel","html_url":"https://github.com/AmeBel","followers_url":"https://api.github.com/users/AmeBel/followers","following_url":"https://api.github.com/users/AmeBel/following{/other_user}","gists_url":"https://api.github.com/users/AmeBel/gists{/gist_id}","starred_url":"https://api.github.com/users/AmeBel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AmeBel/subscriptions","organizations_url":"https://api.github.com/users/AmeBel/orgs","repos_url":"https://api.github.com/users/AmeBel/repos","events_url":"https://api.github.com/users/AmeBel/events{/privacy}","received_events_url":"https://api.github.com/users/AmeBel/received_events","type":"User","site_admin":false},"repo":{"id":10237865,"name":"opencog","full_name":"AmeBel/opencog","owner":{"login":"AmeBel","id":2135577,"avatar_url":"https://avatars.githubusercontent.com/u/2135577?v=3","gravatar_id":"","url":"https://api.github.com/users/AmeBel","html_url":"https://github.com/AmeBel","followers_url":"https://api.github.com/users/AmeBel/followers","following_url":"https://api.github.com/users/AmeBel/following{/other_user}","gists_url":"https://api.github.com/users/AmeBel/gists{/gist_id}","starred_url":"https://api.github.com/users/AmeBel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AmeBel/subscriptions","organizations_url":"https://api.github.com/users/AmeBel/orgs","repos_url":"https://api.github.com/users/AmeBel/repos","events_url":"https://api.github.com/users/AmeBel/events{/privacy}","received_events_url":"https://api.github.com/users/AmeBel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AmeBel/opencog","description":"A development framework for AGI","fork":true,"url":"https://api.github.com/repos/AmeBel/opencog","forks_url":"https://api.github.com/repos/AmeBel/opencog/forks","keys_url":"https://api.github.com/repos/AmeBel/opencog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AmeBel/opencog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AmeBel/opencog/teams","hooks_url":"https://api.github.com/repos/AmeBel/opencog/hooks","issue_events_url":"https://api.github.com/repos/AmeBel/opencog/issues/events{/number}","events_url":"https://api.github.com/repos/AmeBel/opencog/events","assignees_url":"https://api.github.com/repos/AmeBel/opencog/assignees{/user}","branches_url":"https://api.github.com/repos/AmeBel/opencog/branches{/branch}","tags_url":"https://api.github.com/repos/AmeBel/opencog/tags","blobs_url":"https://api.github.com/repos/AmeBel/opencog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AmeBel/opencog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AmeBel/opencog/git/refs{/sha}","trees_url":"https://api.github.com/repos/AmeBel/opencog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AmeBel/opencog/statuses/{sha}","languages_url":"https://api.github.com/repos/AmeBel/opencog/languages","stargazers_url":"https://api.github.com/repos/AmeBel/opencog/stargazers","contributors_url":"https://api.github.com/repos/AmeBel/opencog/contributors","subscribers_url":"https://api.github.com/repos/AmeBel/opencog/subscribers","subscription_url":"https://api.github.com/repos/AmeBel/opencog/subscription","commits_url":"https://api.github.com/repos/AmeBel/opencog/commits{/sha}","git_commits_url":"https://api.github.com/repos/AmeBel/opencog/git/commits{/sha}","comments_url":"https://api.github.com/repos/AmeBel/opencog/comments{/number}","issue_comment_url":"https://api.github.com/repos/AmeBel/opencog/issues/comments{/number}","contents_url":"https://api.github.com/repos/AmeBel/opencog/contents/{+path}","compare_url":"https://api.github.com/repos/AmeBel/opencog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AmeBel/opencog/merges","archive_url":"https://api.github.com/repos/AmeBel/opencog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AmeBel/opencog/downloads","issues_url":"https://api.github.com/repos/AmeBel/opencog/issues{/number}","pulls_url":"https://api.github.com/repos/AmeBel/opencog/pulls{/number}","milestones_url":"https://api.github.com/repos/AmeBel/opencog/milestones{/number}","notifications_url":"https://api.github.com/repos/AmeBel/opencog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AmeBel/opencog/labels{/name}","releases_url":"https://api.github.com/repos/AmeBel/opencog/releases{/id}","deployments_url":"https://api.github.com/repos/AmeBel/opencog/deployments","created_at":"2013-05-23T07:03:08Z","updated_at":"2016-07-06T02:10:52Z","pushed_at":"2016-08-01T01:50:07Z","git_url":"git://github.com/AmeBel/opencog.git","ssh_url":"git@github.com:AmeBel/opencog.git","clone_url":"https://github.com/AmeBel/opencog.git","svn_url":"https://github.com/AmeBel/opencog","homepage":"","size":145997,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opencog:master","ref":"master","sha":"780fa16fe19b2d78060b2284d9c23ccd1b7fc07a","user":{"login":"opencog","id":2109913,"avatar_url":"https://avatars.githubusercontent.com/u/2109913?v=3","gravatar_id":"","url":"https://api.github.com/users/opencog","html_url":"https://github.com/opencog","followers_url":"https://api.github.com/users/opencog/followers","following_url":"https://api.github.com/users/opencog/following{/other_user}","gists_url":"https://api.github.com/users/opencog/gists{/gist_id}","starred_url":"https://api.github.com/users/opencog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencog/subscriptions","organizations_url":"https://api.github.com/users/opencog/orgs","repos_url":"https://api.github.com/users/opencog/repos","events_url":"https://api.github.com/users/opencog/events{/privacy}","received_events_url":"https://api.github.com/users/opencog/received_events","type":"Organization","site_admin":false},"repo":{"id":6365343,"name":"opencog","full_name":"opencog/opencog","owner":{"login":"opencog","id":2109913,"avatar_url":"https://avatars.githubusercontent.com/u/2109913?v=3","gravatar_id":"","url":"https://api.github.com/users/opencog","html_url":"https://github.com/opencog","followers_url":"https://api.github.com/users/opencog/followers","following_url":"https://api.github.com/users/opencog/following{/other_user}","gists_url":"https://api.github.com/users/opencog/gists{/gist_id}","starred_url":"https://api.github.com/users/opencog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencog/subscriptions","organizations_url":"https://api.github.com/users/opencog/orgs","repos_url":"https://api.github.com/users/opencog/repos","events_url":"https://api.github.com/users/opencog/events{/privacy}","received_events_url":"https://api.github.com/users/opencog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opencog/opencog","description":"A framework for integrated Artificial Intelligence & Artificial General Intelligence (AGI)","fork":false,"url":"https://api.github.com/repos/opencog/opencog","forks_url":"https://api.github.com/repos/opencog/opencog/forks","keys_url":"https://api.github.com/repos/opencog/opencog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencog/opencog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencog/opencog/teams","hooks_url":"https://api.github.com/repos/opencog/opencog/hooks","issue_events_url":"https://api.github.com/repos/opencog/opencog/issues/events{/number}","events_url":"https://api.github.com/repos/opencog/opencog/events","assignees_url":"https://api.github.com/repos/opencog/opencog/assignees{/user}","branches_url":"https://api.github.com/repos/opencog/opencog/branches{/branch}","tags_url":"https://api.github.com/repos/opencog/opencog/tags","blobs_url":"https://api.github.com/repos/opencog/opencog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencog/opencog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencog/opencog/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencog/opencog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencog/opencog/statuses/{sha}","languages_url":"https://api.github.com/repos/opencog/opencog/languages","stargazers_url":"https://api.github.com/repos/opencog/opencog/stargazers","contributors_url":"https://api.github.com/repos/opencog/opencog/contributors","subscribers_url":"https://api.github.com/repos/opencog/opencog/subscribers","subscription_url":"https://api.github.com/repos/opencog/opencog/subscription","commits_url":"https://api.github.com/repos/opencog/opencog/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencog/opencog/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencog/opencog/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencog/opencog/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencog/opencog/contents/{+path}","compare_url":"https://api.github.com/repos/opencog/opencog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencog/opencog/merges","archive_url":"https://api.github.com/repos/opencog/opencog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencog/opencog/downloads","issues_url":"https://api.github.com/repos/opencog/opencog/issues{/number}","pulls_url":"https://api.github.com/repos/opencog/opencog/pulls{/number}","milestones_url":"https://api.github.com/repos/opencog/opencog/milestones{/number}","notifications_url":"https://api.github.com/repos/opencog/opencog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencog/opencog/labels{/name}","releases_url":"https://api.github.com/repos/opencog/opencog/releases{/id}","deployments_url":"https://api.github.com/repos/opencog/opencog/deployments","created_at":"2012-10-24T06:10:15Z","updated_at":"2016-08-01T06:18:31Z","pushed_at":"2016-08-01T08:20:47Z","git_url":"git://github.com/opencog/opencog.git","ssh_url":"git@github.com:opencog/opencog.git","clone_url":"https://github.com/opencog/opencog.git","svn_url":"https://github.com/opencog/opencog","homepage":"http://wiki.opencog.org/w/Development","size":162782,"stargazers_count":1007,"watchers_count":1007,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":457,"mirror_url":null,"open_issues_count":67,"forks":457,"open_issues":67,"watchers":1007,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencog/opencog/pulls/2334"},"html":{"href":"https://github.com/opencog/opencog/pull/2334"},"issue":{"href":"https://api.github.com/repos/opencog/opencog/issues/2334"},"comments":{"href":"https://api.github.com/repos/opencog/opencog/issues/2334/comments"},"review_comments":{"href":"https://api.github.com/repos/opencog/opencog/pulls/2334/comments"},"review_comment":{"href":"https://api.github.com/repos/opencog/opencog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opencog/opencog/pulls/2334/commits"},"statuses":{"href":"https://api.github.com/repos/opencog/opencog/statuses/255ac40a46ca72d1fe5b4f88e3959a99a2c6658d"}}}}
{"actor":{"display_login":"eddiemonroe"}}