{"action":"created","comment":{"url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/pulls/comments/77829203","id":77829203,"diff_hunk":"@@ -0,0 +1,12 @@\n+ifndef FH_SYSTEM_DUMP_TOOL_VERSION","path":"Makefile","position":1,"original_position":1,"commit_id":"35b500bb062bd74f6fd8ebd0850aa649f7974924","original_commit_id":"35b500bb062bd74f6fd8ebd0850aa649f7974924","user":{"login":"philbrookes","id":1033452,"avatar_url":"https://avatars.githubusercontent.com/u/1033452?v=3","gravatar_id":"","url":"https://api.github.com/users/philbrookes","html_url":"https://github.com/philbrookes","followers_url":"https://api.github.com/users/philbrookes/followers","following_url":"https://api.github.com/users/philbrookes/following{/other_user}","gists_url":"https://api.github.com/users/philbrookes/gists{/gist_id}","starred_url":"https://api.github.com/users/philbrookes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philbrookes/subscriptions","organizations_url":"https://api.github.com/users/philbrookes/orgs","repos_url":"https://api.github.com/users/philbrookes/repos","events_url":"https://api.github.com/users/philbrookes/events{/privacy}","received_events_url":"https://api.github.com/users/philbrookes/received_events","type":"User","site_admin":false},"body":"This is a great idea.","created_at":"2016-09-07T14:11:34Z","updated_at":"2016-09-07T14:11:34Z","html_url":"https://github.com/feedhenry/fh-system-dump-tool/pull/45#discussion_r77829203","pull_request_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/pulls/45","_links":{"self":{"href":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/pulls/comments/77829203"},"html":{"href":"https://github.com/feedhenry/fh-system-dump-tool/pull/45#discussion_r77829203"},"pull_request":{"href":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/pulls/45"}}},"pull_request":{"url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/pulls/45","id":84290085,"html_url":"https://github.com/feedhenry/fh-system-dump-tool/pull/45","diff_url":"https://github.com/feedhenry/fh-system-dump-tool/pull/45.diff","patch_url":"https://github.com/feedhenry/fh-system-dump-tool/pull/45.patch","issue_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/issues/45","number":45,"state":"open","locked":false,"title":"Take version from Git in build time","user":{"login":"rhcarvalho","id":88819,"avatar_url":"https://avatars.githubusercontent.com/u/88819?v=3","gravatar_id":"","url":"https://api.github.com/users/rhcarvalho","html_url":"https://github.com/rhcarvalho","followers_url":"https://api.github.com/users/rhcarvalho/followers","following_url":"https://api.github.com/users/rhcarvalho/following{/other_user}","gists_url":"https://api.github.com/users/rhcarvalho/gists{/gist_id}","starred_url":"https://api.github.com/users/rhcarvalho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhcarvalho/subscriptions","organizations_url":"https://api.github.com/users/rhcarvalho/orgs","repos_url":"https://api.github.com/users/rhcarvalho/repos","events_url":"https://api.github.com/users/rhcarvalho/events{/privacy}","received_events_url":"https://api.github.com/users/rhcarvalho/received_events","type":"User","site_admin":false},"body":"As part of having a standard build environment for building releases, this PR introduces a Makefile to use for \"standard builds\".\r\n\r\nThe code base is still buildable with the standard go tool without any special flag, though using `make` we consistently add version information taken from Git and loaded into the built binary.\r\n\r\nNote that this doesn't yet give us a build environment for community releases, this is something we may investigate separately (e.g., using Travis and integrating with GitHub).\r\n\r\n--- \r\n\r\nhttps://issues.jboss.org/browse/RHMAP-9400","created_at":"2016-09-07T12:23:36Z","updated_at":"2016-09-07T14:11:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"58772d79948df6ae751966e19d793570c54b81e3","assignee":{"login":"philbrookes","id":1033452,"avatar_url":"https://avatars.githubusercontent.com/u/1033452?v=3","gravatar_id":"","url":"https://api.github.com/users/philbrookes","html_url":"https://github.com/philbrookes","followers_url":"https://api.github.com/users/philbrookes/followers","following_url":"https://api.github.com/users/philbrookes/following{/other_user}","gists_url":"https://api.github.com/users/philbrookes/gists{/gist_id}","starred_url":"https://api.github.com/users/philbrookes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philbrookes/subscriptions","organizations_url":"https://api.github.com/users/philbrookes/orgs","repos_url":"https://api.github.com/users/philbrookes/repos","events_url":"https://api.github.com/users/philbrookes/events{/privacy}","received_events_url":"https://api.github.com/users/philbrookes/received_events","type":"User","site_admin":false},"assignees":[{"login":"philbrookes","id":1033452,"avatar_url":"https://avatars.githubusercontent.com/u/1033452?v=3","gravatar_id":"","url":"https://api.github.com/users/philbrookes","html_url":"https://github.com/philbrookes","followers_url":"https://api.github.com/users/philbrookes/followers","following_url":"https://api.github.com/users/philbrookes/following{/other_user}","gists_url":"https://api.github.com/users/philbrookes/gists{/gist_id}","starred_url":"https://api.github.com/users/philbrookes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philbrookes/subscriptions","organizations_url":"https://api.github.com/users/philbrookes/orgs","repos_url":"https://api.github.com/users/philbrookes/repos","events_url":"https://api.github.com/users/philbrookes/events{/privacy}","received_events_url":"https://api.github.com/users/philbrookes/received_events","type":"User","site_admin":false},{"login":"vibe13","id":6085861,"avatar_url":"https://avatars.githubusercontent.com/u/6085861?v=3","gravatar_id":"","url":"https://api.github.com/users/vibe13","html_url":"https://github.com/vibe13","followers_url":"https://api.github.com/users/vibe13/followers","following_url":"https://api.github.com/users/vibe13/following{/other_user}","gists_url":"https://api.github.com/users/vibe13/gists{/gist_id}","starred_url":"https://api.github.com/users/vibe13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vibe13/subscriptions","organizations_url":"https://api.github.com/users/vibe13/orgs","repos_url":"https://api.github.com/users/vibe13/repos","events_url":"https://api.github.com/users/vibe13/events{/privacy}","received_events_url":"https://api.github.com/users/vibe13/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/pulls/45/commits","review_comments_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/pulls/45/comments","review_comment_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/pulls/comments{/number}","comments_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/issues/45/comments","statuses_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/statuses/35b500bb062bd74f6fd8ebd0850aa649f7974924","head":{"label":"rhcarvalho:std-build","ref":"std-build","sha":"35b500bb062bd74f6fd8ebd0850aa649f7974924","user":{"login":"rhcarvalho","id":88819,"avatar_url":"https://avatars.githubusercontent.com/u/88819?v=3","gravatar_id":"","url":"https://api.github.com/users/rhcarvalho","html_url":"https://github.com/rhcarvalho","followers_url":"https://api.github.com/users/rhcarvalho/followers","following_url":"https://api.github.com/users/rhcarvalho/following{/other_user}","gists_url":"https://api.github.com/users/rhcarvalho/gists{/gist_id}","starred_url":"https://api.github.com/users/rhcarvalho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhcarvalho/subscriptions","organizations_url":"https://api.github.com/users/rhcarvalho/orgs","repos_url":"https://api.github.com/users/rhcarvalho/repos","events_url":"https://api.github.com/users/rhcarvalho/events{/privacy}","received_events_url":"https://api.github.com/users/rhcarvalho/received_events","type":"User","site_admin":false},"repo":{"id":65453502,"name":"fh-system-dump-tool","full_name":"rhcarvalho/fh-system-dump-tool","owner":{"login":"rhcarvalho","id":88819,"avatar_url":"https://avatars.githubusercontent.com/u/88819?v=3","gravatar_id":"","url":"https://api.github.com/users/rhcarvalho","html_url":"https://github.com/rhcarvalho","followers_url":"https://api.github.com/users/rhcarvalho/followers","following_url":"https://api.github.com/users/rhcarvalho/following{/other_user}","gists_url":"https://api.github.com/users/rhcarvalho/gists{/gist_id}","starred_url":"https://api.github.com/users/rhcarvalho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhcarvalho/subscriptions","organizations_url":"https://api.github.com/users/rhcarvalho/orgs","repos_url":"https://api.github.com/users/rhcarvalho/repos","events_url":"https://api.github.com/users/rhcarvalho/events{/privacy}","received_events_url":"https://api.github.com/users/rhcarvalho/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rhcarvalho/fh-system-dump-tool","description":"This repository contains the system dump tool for the RHMAP On-Prem product","fork":true,"url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool","forks_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/forks","keys_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/teams","hooks_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/hooks","issue_events_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/issues/events{/number}","events_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/events","assignees_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/assignees{/user}","branches_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/branches{/branch}","tags_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/tags","blobs_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/statuses/{sha}","languages_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/languages","stargazers_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/stargazers","contributors_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/contributors","subscribers_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/subscribers","subscription_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/subscription","commits_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/contents/{+path}","compare_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/merges","archive_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/downloads","issues_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/issues{/number}","pulls_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/pulls{/number}","milestones_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/milestones{/number}","notifications_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/labels{/name}","releases_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/releases{/id}","deployments_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/deployments","created_at":"2016-08-11T08:42:33Z","updated_at":"2016-08-11T08:42:34Z","pushed_at":"2016-09-07T13:41:55Z","git_url":"git://github.com/rhcarvalho/fh-system-dump-tool.git","ssh_url":"git@github.com:rhcarvalho/fh-system-dump-tool.git","clone_url":"https://github.com/rhcarvalho/fh-system-dump-tool.git","svn_url":"https://github.com/rhcarvalho/fh-system-dump-tool","homepage":null,"size":91,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"feedhenry:master","ref":"master","sha":"6234e77ad22dcc326d41c5633a56d4f535ae4728","user":{"login":"feedhenry","id":772226,"avatar_url":"https://avatars.githubusercontent.com/u/772226?v=3","gravatar_id":"","url":"https://api.github.com/users/feedhenry","html_url":"https://github.com/feedhenry","followers_url":"https://api.github.com/users/feedhenry/followers","following_url":"https://api.github.com/users/feedhenry/following{/other_user}","gists_url":"https://api.github.com/users/feedhenry/gists{/gist_id}","starred_url":"https://api.github.com/users/feedhenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feedhenry/subscriptions","organizations_url":"https://api.github.com/users/feedhenry/orgs","repos_url":"https://api.github.com/users/feedhenry/repos","events_url":"https://api.github.com/users/feedhenry/events{/privacy}","received_events_url":"https://api.github.com/users/feedhenry/received_events","type":"Organization","site_admin":false},"repo":{"id":63058395,"name":"fh-system-dump-tool","full_name":"feedhenry/fh-system-dump-tool","owner":{"login":"feedhenry","id":772226,"avatar_url":"https://avatars.githubusercontent.com/u/772226?v=3","gravatar_id":"","url":"https://api.github.com/users/feedhenry","html_url":"https://github.com/feedhenry","followers_url":"https://api.github.com/users/feedhenry/followers","following_url":"https://api.github.com/users/feedhenry/following{/other_user}","gists_url":"https://api.github.com/users/feedhenry/gists{/gist_id}","starred_url":"https://api.github.com/users/feedhenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feedhenry/subscriptions","organizations_url":"https://api.github.com/users/feedhenry/orgs","repos_url":"https://api.github.com/users/feedhenry/repos","events_url":"https://api.github.com/users/feedhenry/events{/privacy}","received_events_url":"https://api.github.com/users/feedhenry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/feedhenry/fh-system-dump-tool","description":"This repository contains the system dump tool for the RHMAP On-Prem product","fork":false,"url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool","forks_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/forks","keys_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/teams","hooks_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/hooks","issue_events_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/issues/events{/number}","events_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/events","assignees_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/assignees{/user}","branches_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/branches{/branch}","tags_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/tags","blobs_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/git/refs{/sha}","trees_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/statuses/{sha}","languages_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/languages","stargazers_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/stargazers","contributors_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/contributors","subscribers_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/subscribers","subscription_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/subscription","commits_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/commits{/sha}","git_commits_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/git/commits{/sha}","comments_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/comments{/number}","issue_comment_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/issues/comments{/number}","contents_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/contents/{+path}","compare_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/merges","archive_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/downloads","issues_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/issues{/number}","pulls_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/pulls{/number}","milestones_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/milestones{/number}","notifications_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/labels{/name}","releases_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/releases{/id}","deployments_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/deployments","created_at":"2016-07-11T10:20:52Z","updated_at":"2016-08-08T14:28:41Z","pushed_at":"2016-09-07T14:10:18Z","git_url":"git://github.com/feedhenry/fh-system-dump-tool.git","ssh_url":"git@github.com:feedhenry/fh-system-dump-tool.git","clone_url":"https://github.com/feedhenry/fh-system-dump-tool.git","svn_url":"https://github.com/feedhenry/fh-system-dump-tool","homepage":null,"size":129,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":3,"forks":4,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/pulls/45"},"html":{"href":"https://github.com/feedhenry/fh-system-dump-tool/pull/45"},"issue":{"href":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/issues/45"},"comments":{"href":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/statuses/35b500bb062bd74f6fd8ebd0850aa649f7974924"}}}}
{"actor":{"display_login":"philbrookes"}}