{"action":"created","comment":{"url":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls/comments/73070276","id":73070276,"diff_hunk":"@@ -183,13 +183,10 @@ def compiled_templates(app_id, asset_url_prefix)\n       end\n     end\n \n-    def market_translations!(locale)\n-      result = translations[locale].fetch('app', {})\n-      result.delete('name')\n-      result.delete('description')\n-      result.delete('long_description')\n-      result.delete('installation_instructions')\n-      result\n+    def translations_for(locale)\n+      trans = translations","path":"lib/zendesk_apps_support/package.rb","position":21,"original_position":21,"commit_id":"c6d02242a2afa073c1a9241aacb1b1df7877db8b","original_commit_id":"c6d02242a2afa073c1a9241aacb1b1df7877db8b","user":{"login":"sandlerr","id":5535625,"avatar_url":"https://avatars.githubusercontent.com/u/5535625?v=3","gravatar_id":"","url":"https://api.github.com/users/sandlerr","html_url":"https://github.com/sandlerr","followers_url":"https://api.github.com/users/sandlerr/followers","following_url":"https://api.github.com/users/sandlerr/following{/other_user}","gists_url":"https://api.github.com/users/sandlerr/gists{/gist_id}","starred_url":"https://api.github.com/users/sandlerr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandlerr/subscriptions","organizations_url":"https://api.github.com/users/sandlerr/orgs","repos_url":"https://api.github.com/users/sandlerr/repos","events_url":"https://api.github.com/users/sandlerr/events{/privacy}","received_events_url":"https://api.github.com/users/sandlerr/received_events","type":"User","site_admin":false},"body":"Better performance in the case of zat where calling `translations` reads in the files every time, other than that nothing. I didn't write this, just moved the method above `private`","created_at":"2016-08-01T23:16:51Z","updated_at":"2016-08-01T23:16:51Z","html_url":"https://github.com/zendesk/zendesk_apps_support/pull/128#discussion_r73070276","pull_request_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls/128","_links":{"self":{"href":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls/comments/73070276"},"html":{"href":"https://github.com/zendesk/zendesk_apps_support/pull/128#discussion_r73070276"},"pull_request":{"href":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls/128"}}},"pull_request":{"url":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls/128","id":79517478,"html_url":"https://github.com/zendesk/zendesk_apps_support/pull/128","diff_url":"https://github.com/zendesk/zendesk_apps_support/pull/128.diff","patch_url":"https://github.com/zendesk/zendesk_apps_support/pull/128.patch","issue_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/issues/128","number":128,"state":"open","locked":false,"title":"Refactor a method","user":{"login":"sandlerr","id":5535625,"avatar_url":"https://avatars.githubusercontent.com/u/5535625?v=3","gravatar_id":"","url":"https://api.github.com/users/sandlerr","html_url":"https://github.com/sandlerr","followers_url":"https://api.github.com/users/sandlerr/followers","following_url":"https://api.github.com/users/sandlerr/following{/other_user}","gists_url":"https://api.github.com/users/sandlerr/gists{/gist_id}","starred_url":"https://api.github.com/users/sandlerr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandlerr/subscriptions","organizations_url":"https://api.github.com/users/sandlerr/orgs","repos_url":"https://api.github.com/users/sandlerr/repos","events_url":"https://api.github.com/users/sandlerr/events{/privacy}","received_events_url":"https://api.github.com/users/sandlerr/received_events","type":"User","site_admin":false},"body":"This is for us to be able to store the long_description and installation_instructions in the app's zipfile, rather than as a separate manual installation step.\r\n\r\n- `market_translations!` is now renamed to `runtime_translations`, no longer mutates its input and is a private method since it is only useful as an input to `compile_js`.\r\n- `translations_for` is now public so that it can be used instead of `market_translations!` when persisting translations into a database when apps are uploaded.\r\n\r\n### Risks\r\n\r\n- [ medium ] translations stop working for new uploads","created_at":"2016-08-01T06:04:56Z","updated_at":"2016-08-01T23:16:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de98aa5054a0c028dc9a0fa3314dc9ff7ecbbd49","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls/128/commits","review_comments_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls/128/comments","review_comment_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/issues/128/comments","statuses_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/statuses/c6d02242a2afa073c1a9241aacb1b1df7877db8b","head":{"label":"zendesk:roman/ugc_translations","ref":"roman/ugc_translations","sha":"c6d02242a2afa073c1a9241aacb1b1df7877db8b","user":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"repo":{"id":6622163,"name":"zendesk_apps_support","full_name":"zendesk/zendesk_apps_support","owner":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendesk/zendesk_apps_support","description":"","fork":false,"url":"https://api.github.com/repos/zendesk/zendesk_apps_support","forks_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/forks","keys_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/teams","hooks_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/hooks","issue_events_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/issues/events{/number}","events_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/events","assignees_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/assignees{/user}","branches_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/branches{/branch}","tags_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/tags","blobs_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/statuses/{sha}","languages_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/languages","stargazers_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/stargazers","contributors_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/contributors","subscribers_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/subscribers","subscription_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/subscription","commits_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/issues/comments{/number}","contents_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/contents/{+path}","compare_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/merges","archive_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/downloads","issues_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/issues{/number}","pulls_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls{/number}","milestones_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/milestones{/number}","notifications_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/labels{/name}","releases_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/releases{/id}","deployments_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/deployments","created_at":"2012-11-09T23:29:16Z","updated_at":"2016-07-27T21:39:56Z","pushed_at":"2016-08-01T06:34:53Z","git_url":"git://github.com/zendesk/zendesk_apps_support.git","ssh_url":"git@github.com:zendesk/zendesk_apps_support.git","clone_url":"https://github.com/zendesk/zendesk_apps_support.git","svn_url":"https://github.com/zendesk/zendesk_apps_support","homepage":null,"size":679,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":5,"forks":5,"open_issues":5,"watchers":5,"default_branch":"master"}},"base":{"label":"zendesk:master","ref":"master","sha":"8c2f1b9384108eacc6afb15c0fbab719aa6696ad","user":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"repo":{"id":6622163,"name":"zendesk_apps_support","full_name":"zendesk/zendesk_apps_support","owner":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendesk/zendesk_apps_support","description":"","fork":false,"url":"https://api.github.com/repos/zendesk/zendesk_apps_support","forks_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/forks","keys_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/teams","hooks_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/hooks","issue_events_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/issues/events{/number}","events_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/events","assignees_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/assignees{/user}","branches_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/branches{/branch}","tags_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/tags","blobs_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/statuses/{sha}","languages_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/languages","stargazers_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/stargazers","contributors_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/contributors","subscribers_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/subscribers","subscription_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/subscription","commits_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/issues/comments{/number}","contents_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/contents/{+path}","compare_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/merges","archive_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/downloads","issues_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/issues{/number}","pulls_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls{/number}","milestones_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/milestones{/number}","notifications_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/labels{/name}","releases_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/releases{/id}","deployments_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/deployments","created_at":"2012-11-09T23:29:16Z","updated_at":"2016-07-27T21:39:56Z","pushed_at":"2016-08-01T06:34:53Z","git_url":"git://github.com/zendesk/zendesk_apps_support.git","ssh_url":"git@github.com:zendesk/zendesk_apps_support.git","clone_url":"https://github.com/zendesk/zendesk_apps_support.git","svn_url":"https://github.com/zendesk/zendesk_apps_support","homepage":null,"size":679,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":5,"forks":5,"open_issues":5,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls/128"},"html":{"href":"https://github.com/zendesk/zendesk_apps_support/pull/128"},"issue":{"href":"https://api.github.com/repos/zendesk/zendesk_apps_support/issues/128"},"comments":{"href":"https://api.github.com/repos/zendesk/zendesk_apps_support/issues/128/comments"},"review_comments":{"href":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls/128/comments"},"review_comment":{"href":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls/128/commits"},"statuses":{"href":"https://api.github.com/repos/zendesk/zendesk_apps_support/statuses/c6d02242a2afa073c1a9241aacb1b1df7877db8b"}}}}
{"actor":{"display_login":"sandlerr"}}