{"action":"created","comment":{"url":"https://api.github.com/repos/ripple/ripple-libpp/pulls/comments/93130210","pull_request_review_id":13652443,"id":93130210,"diff_hunk":"@@ -0,0 +1,91 @@\n+# cmake file for ripple-libpp\n+\n+# Include this library in your own CMake project by including the following somewhere\n+# below your project definition (`project(your_application)`)\n+#\n+# add_subdirectory(extras/ripple-libpp/src/unity)\n+#\n+# Customize the path as needed\n+\n+cmake_minimum_required(VERSION 3.1.0)\n+\n+list(APPEND CMAKE_MODULE_PATH\n+  \"${CMAKE_CURRENT_SOURCE_DIR}/../../extras/rippled/Builds/CMake\")\n+include(CMakeFuncs)\n+\n+include_directories(\n+  ../../extras/rippled/src\n+  ../../extras/rippled/src/beast/include\n+  ../../extras/rippled/src/beast/extras)\n+#  ../../extras/ripple-libpp/extras/rippled/src/srcp256k1\n+#  ../../extras/ripple-libpp/extras/rippled/src/ed25519-donna\n+\n+determine_build_type()\n+\n+use_boost(\n+  regex\n+  system\n+  thread)\n+\n+use_openssl(1.0.1)","path":"src/unity/CMakeLists.txt","position":30,"original_position":30,"commit_id":"335a05b0e9ee39fb17ec071b978aefc5113eadb8","original_commit_id":"b17e040e755943befe8221663a6ea8d99e7df171","user":{"login":"ximinez","id":6757714,"avatar_url":"https://avatars.githubusercontent.com/u/6757714?v=3","gravatar_id":"","url":"https://api.github.com/users/ximinez","html_url":"https://github.com/ximinez","followers_url":"https://api.github.com/users/ximinez/followers","following_url":"https://api.github.com/users/ximinez/following{/other_user}","gists_url":"https://api.github.com/users/ximinez/gists{/gist_id}","starred_url":"https://api.github.com/users/ximinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ximinez/subscriptions","organizations_url":"https://api.github.com/users/ximinez/orgs","repos_url":"https://api.github.com/users/ximinez/repos","events_url":"https://api.github.com/users/ximinez/events{/privacy}","received_events_url":"https://api.github.com/users/ximinez/received_events","type":"User","site_admin":false},"body":"It's a little sneakier than that. We start with 1.0.2 in `src/test/CMakeLists.txt`, but then we call `parse_target()`, which will override it to 1.0.1 if one if it has `ci` as a component, because that's the latest version we can get on the current Travis environment. However, this file does not call `parse_target()`, because I didn't want the dependency, so I just leave it as 1.0.1 here.","created_at":"2016-12-19T22:07:00Z","updated_at":"2016-12-19T22:07:00Z","html_url":"https://github.com/ripple/ripple-libpp/pull/7#discussion_r93130210","pull_request_url":"https://api.github.com/repos/ripple/ripple-libpp/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/ripple/ripple-libpp/pulls/comments/93130210"},"html":{"href":"https://github.com/ripple/ripple-libpp/pull/7#discussion_r93130210"},"pull_request":{"href":"https://api.github.com/repos/ripple/ripple-libpp/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/ripple/ripple-libpp/pulls/7","id":98645669,"html_url":"https://github.com/ripple/ripple-libpp/pull/7","diff_url":"https://github.com/ripple/ripple-libpp/pull/7.diff","patch_url":"https://github.com/ripple/ripple-libpp/pull/7.patch","issue_url":"https://api.github.com/repos/ripple/ripple-libpp/issues/7","number":7,"state":"open","locked":false,"title":"Reorganize CMake config to separate library and demo:","user":{"login":"ximinez","id":6757714,"avatar_url":"https://avatars.githubusercontent.com/u/6757714?v=3","gravatar_id":"","url":"https://api.github.com/users/ximinez","html_url":"https://github.com/ximinez","followers_url":"https://api.github.com/users/ximinez/followers","following_url":"https://api.github.com/users/ximinez/following{/other_user}","gists_url":"https://api.github.com/users/ximinez/gists{/gist_id}","starred_url":"https://api.github.com/users/ximinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ximinez/subscriptions","organizations_url":"https://api.github.com/users/ximinez/orgs","repos_url":"https://api.github.com/users/ximinez/repos","events_url":"https://api.github.com/users/ximinez/events{/privacy}","received_events_url":"https://api.github.com/users/ximinez/received_events","type":"User","site_admin":false},"body":"* Library and demo are in independent subdirectories.\r\n* Update setup documentation.\r\n* \"cmake --build\" in Appveyor.\r\n\r\nAlso updates the rippled submodule and includes the CMakeLists.txt updates from #5.","created_at":"2016-12-19T21:45:49Z","updated_at":"2016-12-19T22:07:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2be78ce16d6379070bf01787f283ec3d441b9ebe","assignee":{"login":"mellery451","id":463430,"avatar_url":"https://avatars.githubusercontent.com/u/463430?v=3","gravatar_id":"","url":"https://api.github.com/users/mellery451","html_url":"https://github.com/mellery451","followers_url":"https://api.github.com/users/mellery451/followers","following_url":"https://api.github.com/users/mellery451/following{/other_user}","gists_url":"https://api.github.com/users/mellery451/gists{/gist_id}","starred_url":"https://api.github.com/users/mellery451/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellery451/subscriptions","organizations_url":"https://api.github.com/users/mellery451/orgs","repos_url":"https://api.github.com/users/mellery451/repos","events_url":"https://api.github.com/users/mellery451/events{/privacy}","received_events_url":"https://api.github.com/users/mellery451/received_events","type":"User","site_admin":false},"assignees":[{"login":"mellery451","id":463430,"avatar_url":"https://avatars.githubusercontent.com/u/463430?v=3","gravatar_id":"","url":"https://api.github.com/users/mellery451","html_url":"https://github.com/mellery451","followers_url":"https://api.github.com/users/mellery451/followers","following_url":"https://api.github.com/users/mellery451/following{/other_user}","gists_url":"https://api.github.com/users/mellery451/gists{/gist_id}","starred_url":"https://api.github.com/users/mellery451/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellery451/subscriptions","organizations_url":"https://api.github.com/users/mellery451/orgs","repos_url":"https://api.github.com/users/mellery451/repos","events_url":"https://api.github.com/users/mellery451/events{/privacy}","received_events_url":"https://api.github.com/users/mellery451/received_events","type":"User","site_admin":false},{"login":"seelabs","id":5853458,"avatar_url":"https://avatars.githubusercontent.com/u/5853458?v=3","gravatar_id":"","url":"https://api.github.com/users/seelabs","html_url":"https://github.com/seelabs","followers_url":"https://api.github.com/users/seelabs/followers","following_url":"https://api.github.com/users/seelabs/following{/other_user}","gists_url":"https://api.github.com/users/seelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/seelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seelabs/subscriptions","organizations_url":"https://api.github.com/users/seelabs/orgs","repos_url":"https://api.github.com/users/seelabs/repos","events_url":"https://api.github.com/users/seelabs/events{/privacy}","received_events_url":"https://api.github.com/users/seelabs/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ripple/ripple-libpp/pulls/7/commits","review_comments_url":"https://api.github.com/repos/ripple/ripple-libpp/pulls/7/comments","review_comment_url":"https://api.github.com/repos/ripple/ripple-libpp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ripple/ripple-libpp/issues/7/comments","statuses_url":"https://api.github.com/repos/ripple/ripple-libpp/statuses/335a05b0e9ee39fb17ec071b978aefc5113eadb8","head":{"label":"ximinez:cmake-subdir","ref":"cmake-subdir","sha":"335a05b0e9ee39fb17ec071b978aefc5113eadb8","user":{"login":"ximinez","id":6757714,"avatar_url":"https://avatars.githubusercontent.com/u/6757714?v=3","gravatar_id":"","url":"https://api.github.com/users/ximinez","html_url":"https://github.com/ximinez","followers_url":"https://api.github.com/users/ximinez/followers","following_url":"https://api.github.com/users/ximinez/following{/other_user}","gists_url":"https://api.github.com/users/ximinez/gists{/gist_id}","starred_url":"https://api.github.com/users/ximinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ximinez/subscriptions","organizations_url":"https://api.github.com/users/ximinez/orgs","repos_url":"https://api.github.com/users/ximinez/repos","events_url":"https://api.github.com/users/ximinez/events{/privacy}","received_events_url":"https://api.github.com/users/ximinez/received_events","type":"User","site_admin":false},"repo":{"id":73756263,"name":"ripple-libpp","full_name":"ximinez/ripple-libpp","owner":{"login":"ximinez","id":6757714,"avatar_url":"https://avatars.githubusercontent.com/u/6757714?v=3","gravatar_id":"","url":"https://api.github.com/users/ximinez","html_url":"https://github.com/ximinez","followers_url":"https://api.github.com/users/ximinez/followers","following_url":"https://api.github.com/users/ximinez/following{/other_user}","gists_url":"https://api.github.com/users/ximinez/gists{/gist_id}","starred_url":"https://api.github.com/users/ximinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ximinez/subscriptions","organizations_url":"https://api.github.com/users/ximinez/orgs","repos_url":"https://api.github.com/users/ximinez/repos","events_url":"https://api.github.com/users/ximinez/events{/privacy}","received_events_url":"https://api.github.com/users/ximinez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ximinez/ripple-libpp","description":"Standalone RCL-compatible transaction signing and serialization library","fork":true,"url":"https://api.github.com/repos/ximinez/ripple-libpp","forks_url":"https://api.github.com/repos/ximinez/ripple-libpp/forks","keys_url":"https://api.github.com/repos/ximinez/ripple-libpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ximinez/ripple-libpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ximinez/ripple-libpp/teams","hooks_url":"https://api.github.com/repos/ximinez/ripple-libpp/hooks","issue_events_url":"https://api.github.com/repos/ximinez/ripple-libpp/issues/events{/number}","events_url":"https://api.github.com/repos/ximinez/ripple-libpp/events","assignees_url":"https://api.github.com/repos/ximinez/ripple-libpp/assignees{/user}","branches_url":"https://api.github.com/repos/ximinez/ripple-libpp/branches{/branch}","tags_url":"https://api.github.com/repos/ximinez/ripple-libpp/tags","blobs_url":"https://api.github.com/repos/ximinez/ripple-libpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ximinez/ripple-libpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ximinez/ripple-libpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/ximinez/ripple-libpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ximinez/ripple-libpp/statuses/{sha}","languages_url":"https://api.github.com/repos/ximinez/ripple-libpp/languages","stargazers_url":"https://api.github.com/repos/ximinez/ripple-libpp/stargazers","contributors_url":"https://api.github.com/repos/ximinez/ripple-libpp/contributors","subscribers_url":"https://api.github.com/repos/ximinez/ripple-libpp/subscribers","subscription_url":"https://api.github.com/repos/ximinez/ripple-libpp/subscription","commits_url":"https://api.github.com/repos/ximinez/ripple-libpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/ximinez/ripple-libpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/ximinez/ripple-libpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/ximinez/ripple-libpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/ximinez/ripple-libpp/contents/{+path}","compare_url":"https://api.github.com/repos/ximinez/ripple-libpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ximinez/ripple-libpp/merges","archive_url":"https://api.github.com/repos/ximinez/ripple-libpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ximinez/ripple-libpp/downloads","issues_url":"https://api.github.com/repos/ximinez/ripple-libpp/issues{/number}","pulls_url":"https://api.github.com/repos/ximinez/ripple-libpp/pulls{/number}","milestones_url":"https://api.github.com/repos/ximinez/ripple-libpp/milestones{/number}","notifications_url":"https://api.github.com/repos/ximinez/ripple-libpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ximinez/ripple-libpp/labels{/name}","releases_url":"https://api.github.com/repos/ximinez/ripple-libpp/releases{/id}","deployments_url":"https://api.github.com/repos/ximinez/ripple-libpp/deployments","created_at":"2016-11-14T23:28:58Z","updated_at":"2016-11-14T23:28:59Z","pushed_at":"2016-12-19T21:53:18Z","git_url":"git://github.com/ximinez/ripple-libpp.git","ssh_url":"git@github.com:ximinez/ripple-libpp.git","clone_url":"https://github.com/ximinez/ripple-libpp.git","svn_url":"https://github.com/ximinez/ripple-libpp","homepage":null,"size":18,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ripple:master","ref":"master","sha":"ba685107d2c8e629924cdff5279fa5678520a412","user":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"repo":{"id":66310754,"name":"ripple-libpp","full_name":"ripple/ripple-libpp","owner":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ripple/ripple-libpp","description":"Standalone RCL-compatible transaction signing and serialization library","fork":false,"url":"https://api.github.com/repos/ripple/ripple-libpp","forks_url":"https://api.github.com/repos/ripple/ripple-libpp/forks","keys_url":"https://api.github.com/repos/ripple/ripple-libpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ripple/ripple-libpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ripple/ripple-libpp/teams","hooks_url":"https://api.github.com/repos/ripple/ripple-libpp/hooks","issue_events_url":"https://api.github.com/repos/ripple/ripple-libpp/issues/events{/number}","events_url":"https://api.github.com/repos/ripple/ripple-libpp/events","assignees_url":"https://api.github.com/repos/ripple/ripple-libpp/assignees{/user}","branches_url":"https://api.github.com/repos/ripple/ripple-libpp/branches{/branch}","tags_url":"https://api.github.com/repos/ripple/ripple-libpp/tags","blobs_url":"https://api.github.com/repos/ripple/ripple-libpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ripple/ripple-libpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ripple/ripple-libpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/ripple/ripple-libpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ripple/ripple-libpp/statuses/{sha}","languages_url":"https://api.github.com/repos/ripple/ripple-libpp/languages","stargazers_url":"https://api.github.com/repos/ripple/ripple-libpp/stargazers","contributors_url":"https://api.github.com/repos/ripple/ripple-libpp/contributors","subscribers_url":"https://api.github.com/repos/ripple/ripple-libpp/subscribers","subscription_url":"https://api.github.com/repos/ripple/ripple-libpp/subscription","commits_url":"https://api.github.com/repos/ripple/ripple-libpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/ripple/ripple-libpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/ripple/ripple-libpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/ripple/ripple-libpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/ripple/ripple-libpp/contents/{+path}","compare_url":"https://api.github.com/repos/ripple/ripple-libpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ripple/ripple-libpp/merges","archive_url":"https://api.github.com/repos/ripple/ripple-libpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ripple/ripple-libpp/downloads","issues_url":"https://api.github.com/repos/ripple/ripple-libpp/issues{/number}","pulls_url":"https://api.github.com/repos/ripple/ripple-libpp/pulls{/number}","milestones_url":"https://api.github.com/repos/ripple/ripple-libpp/milestones{/number}","notifications_url":"https://api.github.com/repos/ripple/ripple-libpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ripple/ripple-libpp/labels{/name}","releases_url":"https://api.github.com/repos/ripple/ripple-libpp/releases{/id}","deployments_url":"https://api.github.com/repos/ripple/ripple-libpp/deployments","created_at":"2016-08-22T21:50:53Z","updated_at":"2016-12-06T20:50:21Z","pushed_at":"2016-12-19T21:53:18Z","git_url":"git://github.com/ripple/ripple-libpp.git","ssh_url":"git@github.com:ripple/ripple-libpp.git","clone_url":"https://github.com/ripple/ripple-libpp.git","svn_url":"https://github.com/ripple/ripple-libpp","homepage":null,"size":90,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ripple/ripple-libpp/pulls/7"},"html":{"href":"https://github.com/ripple/ripple-libpp/pull/7"},"issue":{"href":"https://api.github.com/repos/ripple/ripple-libpp/issues/7"},"comments":{"href":"https://api.github.com/repos/ripple/ripple-libpp/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/ripple/ripple-libpp/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/ripple/ripple-libpp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ripple/ripple-libpp/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/ripple/ripple-libpp/statuses/335a05b0e9ee39fb17ec071b978aefc5113eadb8"}}}}
{"actor":{"display_login":"ximinez"}}