{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/comments/54101762","id":54101762,"diff_hunk":"@@ -32,14 +36,30 @@\n     group: \"{{ dir_group }}\"\n     mode: \"{{ dir_mode }}\"\n \n-- name: ceph monitor mkfs (for or after infernalis release)\n+- name: ceph monitor mkfs with keyring (for or after infernalis release)\n   command: ceph-mon --setuser ceph --setgroup ceph --mkfs -i {{ ansible_hostname }} --fsid {{ fsid }} --keyring /var/lib/ceph/tmp/keyring.mon.{{ ansible_hostname }}\n   args:\n     creates: /var/lib/ceph/mon/ceph-{{ ansible_hostname }}/keyring\n-  when: is_ceph_infernalis\n+  when:\n+    cephx and\n+    is_ceph_infernalis\n \n-- name: ceph monitor mkfs (before infernalis release)\n+- name: ceph monitor mkfs without keyring (for or after infernalis release)\n+  command: ceph-mon --setuser ceph --setgroup ceph --mkfs -i {{ ansible_hostname }} --fsid {{ fsid }}\n+  when:\n+    not cephx and\n+    is_ceph_infernalis\n+\n+- name: ceph monitor mkfs with keyring (before infernalis release)\n   command: ceph-mon --mkfs -i {{ ansible_hostname }} --fsid {{ fsid }} --keyring /var/lib/ceph/tmp/keyring.mon.{{ ansible_hostname }}\n   args:\n     creates: /var/lib/ceph/mon/ceph-{{ ansible_hostname }}/keyring\n-  when: not is_ceph_infernalis\n+  when:\n+    cephx and\n+    not is_ceph_infernalis\n+\n+- name: ceph monitor mkfs without keyring (before infernalis release)\n+  command: ceph-mon --mkfs -i {{ ansible_hostname }} --fsid {{ fsid }}","path":"roles/ceph-mon/tasks/deploy_monitors.yml","position":61,"original_position":61,"commit_id":"e29a630d681375952c32553768282cd8815cf7f9","original_commit_id":"e29a630d681375952c32553768282cd8815cf7f9","user":{"login":"leseb","id":912735,"avatar_url":"https://avatars.githubusercontent.com/u/912735?v=3","gravatar_id":"","url":"https://api.github.com/users/leseb","html_url":"https://github.com/leseb","followers_url":"https://api.github.com/users/leseb/followers","following_url":"https://api.github.com/users/leseb/following{/other_user}","gists_url":"https://api.github.com/users/leseb/gists{/gist_id}","starred_url":"https://api.github.com/users/leseb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leseb/subscriptions","organizations_url":"https://api.github.com/users/leseb/orgs","repos_url":"https://api.github.com/users/leseb/repos","events_url":"https://api.github.com/users/leseb/events{/privacy}","received_events_url":"https://api.github.com/users/leseb/received_events","type":"User","site_admin":false},"body":"dito","created_at":"2016-02-25T14:29:21Z","updated_at":"2016-02-25T14:29:21Z","html_url":"https://github.com/ceph/ceph-ansible/pull/568#discussion_r54101762","pull_request_url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/568","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/comments/54101762"},"html":{"href":"https://github.com/ceph/ceph-ansible/pull/568#discussion_r54101762"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/568"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/568","id":60682197,"html_url":"https://github.com/ceph/ceph-ansible/pull/568","diff_url":"https://github.com/ceph/ceph-ansible/pull/568.diff","patch_url":"https://github.com/ceph/ceph-ansible/pull/568.patch","issue_url":"https://api.github.com/repos/ceph/ceph-ansible/issues/568","number":568,"state":"open","locked":false,"title":"Skip keyring tasks when cephx is disabled","user":{"login":"stpierre","id":632407,"avatar_url":"https://avatars.githubusercontent.com/u/632407?v=3","gravatar_id":"","url":"https://api.github.com/users/stpierre","html_url":"https://github.com/stpierre","followers_url":"https://api.github.com/users/stpierre/followers","following_url":"https://api.github.com/users/stpierre/following{/other_user}","gists_url":"https://api.github.com/users/stpierre/gists{/gist_id}","starred_url":"https://api.github.com/users/stpierre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stpierre/subscriptions","organizations_url":"https://api.github.com/users/stpierre/orgs","repos_url":"https://api.github.com/users/stpierre/repos","events_url":"https://api.github.com/users/stpierre/events{/privacy}","received_events_url":"https://api.github.com/users/stpierre/received_events","type":"User","site_admin":false},"body":"Skip a number of ceph keyring-related tasks (or remove the keyring\r\nportion of some tasks) when cephx is disabled. Specifically, avoid\r\ngenerating the initial keyring, which only clutters up the ansible\r\nrepo if cephx is not in use.","created_at":"2016-02-25T13:59:27Z","updated_at":"2016-02-25T14:29:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2031d6d4f920aeffdc3cdcf80539df162f555d2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/568/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/568/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph-ansible/issues/568/comments","statuses_url":"https://api.github.com/repos/ceph/ceph-ansible/statuses/e29a630d681375952c32553768282cd8815cf7f9","head":{"label":"stpierre:skip-keyring-cephx-disabled","ref":"skip-keyring-cephx-disabled","sha":"e29a630d681375952c32553768282cd8815cf7f9","user":{"login":"stpierre","id":632407,"avatar_url":"https://avatars.githubusercontent.com/u/632407?v=3","gravatar_id":"","url":"https://api.github.com/users/stpierre","html_url":"https://github.com/stpierre","followers_url":"https://api.github.com/users/stpierre/followers","following_url":"https://api.github.com/users/stpierre/following{/other_user}","gists_url":"https://api.github.com/users/stpierre/gists{/gist_id}","starred_url":"https://api.github.com/users/stpierre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stpierre/subscriptions","organizations_url":"https://api.github.com/users/stpierre/orgs","repos_url":"https://api.github.com/users/stpierre/repos","events_url":"https://api.github.com/users/stpierre/events{/privacy}","received_events_url":"https://api.github.com/users/stpierre/received_events","type":"User","site_admin":false},"repo":{"id":52116626,"name":"ceph-ansible","full_name":"stpierre/ceph-ansible","owner":{"login":"stpierre","id":632407,"avatar_url":"https://avatars.githubusercontent.com/u/632407?v=3","gravatar_id":"","url":"https://api.github.com/users/stpierre","html_url":"https://github.com/stpierre","followers_url":"https://api.github.com/users/stpierre/followers","following_url":"https://api.github.com/users/stpierre/following{/other_user}","gists_url":"https://api.github.com/users/stpierre/gists{/gist_id}","starred_url":"https://api.github.com/users/stpierre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stpierre/subscriptions","organizations_url":"https://api.github.com/users/stpierre/orgs","repos_url":"https://api.github.com/users/stpierre/repos","events_url":"https://api.github.com/users/stpierre/events{/privacy}","received_events_url":"https://api.github.com/users/stpierre/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stpierre/ceph-ansible","description":"Ansible playbooks for Ceph","fork":true,"url":"https://api.github.com/repos/stpierre/ceph-ansible","forks_url":"https://api.github.com/repos/stpierre/ceph-ansible/forks","keys_url":"https://api.github.com/repos/stpierre/ceph-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stpierre/ceph-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stpierre/ceph-ansible/teams","hooks_url":"https://api.github.com/repos/stpierre/ceph-ansible/hooks","issue_events_url":"https://api.github.com/repos/stpierre/ceph-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/stpierre/ceph-ansible/events","assignees_url":"https://api.github.com/repos/stpierre/ceph-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/stpierre/ceph-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/stpierre/ceph-ansible/tags","blobs_url":"https://api.github.com/repos/stpierre/ceph-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stpierre/ceph-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stpierre/ceph-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/stpierre/ceph-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stpierre/ceph-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/stpierre/ceph-ansible/languages","stargazers_url":"https://api.github.com/repos/stpierre/ceph-ansible/stargazers","contributors_url":"https://api.github.com/repos/stpierre/ceph-ansible/contributors","subscribers_url":"https://api.github.com/repos/stpierre/ceph-ansible/subscribers","subscription_url":"https://api.github.com/repos/stpierre/ceph-ansible/subscription","commits_url":"https://api.github.com/repos/stpierre/ceph-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/stpierre/ceph-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/stpierre/ceph-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/stpierre/ceph-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/stpierre/ceph-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/stpierre/ceph-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stpierre/ceph-ansible/merges","archive_url":"https://api.github.com/repos/stpierre/ceph-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stpierre/ceph-ansible/downloads","issues_url":"https://api.github.com/repos/stpierre/ceph-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/stpierre/ceph-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/stpierre/ceph-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/stpierre/ceph-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stpierre/ceph-ansible/labels{/name}","releases_url":"https://api.github.com/repos/stpierre/ceph-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/stpierre/ceph-ansible/deployments","created_at":"2016-02-19T21:11:31Z","updated_at":"2016-02-19T21:11:32Z","pushed_at":"2016-02-25T14:22:12Z","git_url":"git://github.com/stpierre/ceph-ansible.git","ssh_url":"git@github.com:stpierre/ceph-ansible.git","clone_url":"https://github.com/stpierre/ceph-ansible.git","svn_url":"https://github.com/stpierre/ceph-ansible","homepage":null,"size":1032,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"e9f3e792b03d36a6bd6837762465c54a45a5dfcb","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":17373313,"name":"ceph-ansible","full_name":"ceph/ceph-ansible","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph-ansible","description":"Ansible playbooks for Ceph","fork":false,"url":"https://api.github.com/repos/ceph/ceph-ansible","forks_url":"https://api.github.com/repos/ceph/ceph-ansible/forks","keys_url":"https://api.github.com/repos/ceph/ceph-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph-ansible/teams","hooks_url":"https://api.github.com/repos/ceph/ceph-ansible/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph-ansible/events","assignees_url":"https://api.github.com/repos/ceph/ceph-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph-ansible/tags","blobs_url":"https://api.github.com/repos/ceph/ceph-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph-ansible/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph-ansible/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph-ansible/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph-ansible/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph-ansible/subscription","commits_url":"https://api.github.com/repos/ceph/ceph-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph-ansible/merges","archive_url":"https://api.github.com/repos/ceph/ceph-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph-ansible/downloads","issues_url":"https://api.github.com/repos/ceph/ceph-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph-ansible/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph-ansible/deployments","created_at":"2014-03-03T17:12:09Z","updated_at":"2016-02-22T21:37:11Z","pushed_at":"2016-02-25T14:22:12Z","git_url":"git://github.com/ceph/ceph-ansible.git","ssh_url":"git@github.com:ceph/ceph-ansible.git","clone_url":"https://github.com/ceph/ceph-ansible.git","svn_url":"https://github.com/ceph/ceph-ansible","homepage":null,"size":23471,"stargazers_count":206,"watchers_count":206,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":135,"mirror_url":null,"open_issues_count":24,"forks":135,"open_issues":24,"watchers":206,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/568"},"html":{"href":"https://github.com/ceph/ceph-ansible/pull/568"},"issue":{"href":"https://api.github.com/repos/ceph/ceph-ansible/issues/568"},"comments":{"href":"https://api.github.com/repos/ceph/ceph-ansible/issues/568/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/568/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/568/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph-ansible/statuses/e29a630d681375952c32553768282cd8815cf7f9"}}}}