{"action":"created","comment":{"url":"https://api.github.com/repos/biolab/orange3/pulls/comments/89518801","pull_request_review_id":10064324,"id":89518801,"diff_hunk":"@@ -72,14 +74,46 @@ def preprocess(self, data):\n             data = pp(data)\n         return data\n \n-    def __repr__(self):\n-        return self.name\n-\n     def check_learner_adequacy(self, domain):\n         return True\n \n+    @property\n+    def name(self):\n+        \"\"\"Return a short name derived from Learner type name\"\"\"\n+        try:\n+            return self.__name\n+        except AttributeError:\n+            name = self.__class__.__name__\n+            assert name.endswith('Learner'), \\","path":"Orange/base.py","position":null,"original_position":41,"commit_id":"c6811221fc3a08b040eb8a5c14b443f52316ec60","original_commit_id":"aebf2fc77936444e3abce864f100fe8e9907c577","user":{"login":"kernc","id":684364,"avatar_url":"https://avatars.githubusercontent.com/u/684364?v=3","gravatar_id":"","url":"https://api.github.com/users/kernc","html_url":"https://github.com/kernc","followers_url":"https://api.github.com/users/kernc/followers","following_url":"https://api.github.com/users/kernc/following{/other_user}","gists_url":"https://api.github.com/users/kernc/gists{/gist_id}","starred_url":"https://api.github.com/users/kernc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kernc/subscriptions","organizations_url":"https://api.github.com/users/kernc/orgs","repos_url":"https://api.github.com/users/kernc/repos","events_url":"https://api.github.com/users/kernc/events{/privacy}","received_events_url":"https://api.github.com/users/kernc/received_events","type":"User","site_admin":false},"body":"To enforce some conformity. Now stripped.","created_at":"2016-11-24T15:42:21Z","updated_at":"2016-11-24T15:42:21Z","html_url":"https://github.com/biolab/orange3/pull/1771#discussion_r89518801","pull_request_url":"https://api.github.com/repos/biolab/orange3/pulls/1771","_links":{"self":{"href":"https://api.github.com/repos/biolab/orange3/pulls/comments/89518801"},"html":{"href":"https://github.com/biolab/orange3/pull/1771#discussion_r89518801"},"pull_request":{"href":"https://api.github.com/repos/biolab/orange3/pulls/1771"}}},"pull_request":{"url":"https://api.github.com/repos/biolab/orange3/pulls/1771","id":94889472,"html_url":"https://github.com/biolab/orange3/pull/1771","diff_url":"https://github.com/biolab/orange3/pull/1771.diff","patch_url":"https://github.com/biolab/orange3/pull/1771.patch","issue_url":"https://api.github.com/repos/biolab/orange3/issues/1771","number":1771,"state":"open","locked":false,"title":"Common __repr__ for common types","user":{"login":"kernc","id":684364,"avatar_url":"https://avatars.githubusercontent.com/u/684364?v=3","gravatar_id":"","url":"https://api.github.com/users/kernc","html_url":"https://github.com/kernc","followers_url":"https://api.github.com/users/kernc/followers","following_url":"https://api.github.com/users/kernc/following{/other_user}","gists_url":"https://api.github.com/users/kernc/gists{/gist_id}","starred_url":"https://api.github.com/users/kernc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kernc/subscriptions","organizations_url":"https://api.github.com/users/kernc/orgs","repos_url":"https://api.github.com/users/kernc/repos","events_url":"https://api.github.com/users/kernc/events{/privacy}","received_events_url":"https://api.github.com/users/kernc/received_events","type":"User","site_admin":false},"body":"##### Issue\r\nOur types all around.\r\n\r\n##### Description of changes\r\nMakes most of our types repr-able, as recommended by [python docs](https://docs.python.org/3/reference/datamodel.html#object.__repr__) and as needed eventually by https://github.com/biolab/orange3/pull/1449.\r\nA continuation of https://github.com/biolab/orange3/pull/1507.\r\n\r\n##### Includes\r\n- [X] Code changes\r\n- [X] Tests\r\n\r\n\r\nThis \"traits\" programming is quite clean. I reckon we shall soon also have types that are `_Copyable` and `_Enumerable`!\r\n\r\nWould _really_ appreciate a speedy review!","created_at":"2016-11-22T20:13:14Z","updated_at":"2016-11-24T15:42:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63dfebeaecad397346db2d595119467c79a3399e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/biolab/orange3/pulls/1771/commits","review_comments_url":"https://api.github.com/repos/biolab/orange3/pulls/1771/comments","review_comment_url":"https://api.github.com/repos/biolab/orange3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/biolab/orange3/issues/1771/comments","statuses_url":"https://api.github.com/repos/biolab/orange3/statuses/c6811221fc3a08b040eb8a5c14b443f52316ec60","head":{"label":"kernc:repr-pr","ref":"repr-pr","sha":"c6811221fc3a08b040eb8a5c14b443f52316ec60","user":{"login":"kernc","id":684364,"avatar_url":"https://avatars.githubusercontent.com/u/684364?v=3","gravatar_id":"","url":"https://api.github.com/users/kernc","html_url":"https://github.com/kernc","followers_url":"https://api.github.com/users/kernc/followers","following_url":"https://api.github.com/users/kernc/following{/other_user}","gists_url":"https://api.github.com/users/kernc/gists{/gist_id}","starred_url":"https://api.github.com/users/kernc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kernc/subscriptions","organizations_url":"https://api.github.com/users/kernc/orgs","repos_url":"https://api.github.com/users/kernc/repos","events_url":"https://api.github.com/users/kernc/events{/privacy}","received_events_url":"https://api.github.com/users/kernc/received_events","type":"User","site_admin":false},"repo":{"id":34139728,"name":"orange3","full_name":"kernc/orange3","owner":{"login":"kernc","id":684364,"avatar_url":"https://avatars.githubusercontent.com/u/684364?v=3","gravatar_id":"","url":"https://api.github.com/users/kernc","html_url":"https://github.com/kernc","followers_url":"https://api.github.com/users/kernc/followers","following_url":"https://api.github.com/users/kernc/following{/other_user}","gists_url":"https://api.github.com/users/kernc/gists{/gist_id}","starred_url":"https://api.github.com/users/kernc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kernc/subscriptions","organizations_url":"https://api.github.com/users/kernc/orgs","repos_url":"https://api.github.com/users/kernc/repos","events_url":"https://api.github.com/users/kernc/events{/privacy}","received_events_url":"https://api.github.com/users/kernc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kernc/orange3","description":null,"fork":true,"url":"https://api.github.com/repos/kernc/orange3","forks_url":"https://api.github.com/repos/kernc/orange3/forks","keys_url":"https://api.github.com/repos/kernc/orange3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kernc/orange3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kernc/orange3/teams","hooks_url":"https://api.github.com/repos/kernc/orange3/hooks","issue_events_url":"https://api.github.com/repos/kernc/orange3/issues/events{/number}","events_url":"https://api.github.com/repos/kernc/orange3/events","assignees_url":"https://api.github.com/repos/kernc/orange3/assignees{/user}","branches_url":"https://api.github.com/repos/kernc/orange3/branches{/branch}","tags_url":"https://api.github.com/repos/kernc/orange3/tags","blobs_url":"https://api.github.com/repos/kernc/orange3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kernc/orange3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kernc/orange3/git/refs{/sha}","trees_url":"https://api.github.com/repos/kernc/orange3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kernc/orange3/statuses/{sha}","languages_url":"https://api.github.com/repos/kernc/orange3/languages","stargazers_url":"https://api.github.com/repos/kernc/orange3/stargazers","contributors_url":"https://api.github.com/repos/kernc/orange3/contributors","subscribers_url":"https://api.github.com/repos/kernc/orange3/subscribers","subscription_url":"https://api.github.com/repos/kernc/orange3/subscription","commits_url":"https://api.github.com/repos/kernc/orange3/commits{/sha}","git_commits_url":"https://api.github.com/repos/kernc/orange3/git/commits{/sha}","comments_url":"https://api.github.com/repos/kernc/orange3/comments{/number}","issue_comment_url":"https://api.github.com/repos/kernc/orange3/issues/comments{/number}","contents_url":"https://api.github.com/repos/kernc/orange3/contents/{+path}","compare_url":"https://api.github.com/repos/kernc/orange3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kernc/orange3/merges","archive_url":"https://api.github.com/repos/kernc/orange3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kernc/orange3/downloads","issues_url":"https://api.github.com/repos/kernc/orange3/issues{/number}","pulls_url":"https://api.github.com/repos/kernc/orange3/pulls{/number}","milestones_url":"https://api.github.com/repos/kernc/orange3/milestones{/number}","notifications_url":"https://api.github.com/repos/kernc/orange3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kernc/orange3/labels{/name}","releases_url":"https://api.github.com/repos/kernc/orange3/releases{/id}","deployments_url":"https://api.github.com/repos/kernc/orange3/deployments","created_at":"2015-04-17T20:56:32Z","updated_at":"2016-01-14T12:39:26Z","pushed_at":"2016-11-24T15:33:10Z","git_url":"git://github.com/kernc/orange3.git","ssh_url":"git@github.com:kernc/orange3.git","clone_url":"https://github.com/kernc/orange3.git","svn_url":"https://github.com/kernc/orange3","homepage":null,"size":56202,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"biolab:master","ref":"master","sha":"f5dc821598fac545ec006f43b7317af81bfbe90a","user":{"login":"biolab","id":555189,"avatar_url":"https://avatars.githubusercontent.com/u/555189?v=3","gravatar_id":"","url":"https://api.github.com/users/biolab","html_url":"https://github.com/biolab","followers_url":"https://api.github.com/users/biolab/followers","following_url":"https://api.github.com/users/biolab/following{/other_user}","gists_url":"https://api.github.com/users/biolab/gists{/gist_id}","starred_url":"https://api.github.com/users/biolab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biolab/subscriptions","organizations_url":"https://api.github.com/users/biolab/orgs","repos_url":"https://api.github.com/users/biolab/repos","events_url":"https://api.github.com/users/biolab/events{/privacy}","received_events_url":"https://api.github.com/users/biolab/received_events","type":"Organization","site_admin":false},"repo":{"id":8357227,"name":"orange3","full_name":"biolab/orange3","owner":{"login":"biolab","id":555189,"avatar_url":"https://avatars.githubusercontent.com/u/555189?v=3","gravatar_id":"","url":"https://api.github.com/users/biolab","html_url":"https://github.com/biolab","followers_url":"https://api.github.com/users/biolab/followers","following_url":"https://api.github.com/users/biolab/following{/other_user}","gists_url":"https://api.github.com/users/biolab/gists{/gist_id}","starred_url":"https://api.github.com/users/biolab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biolab/subscriptions","organizations_url":"https://api.github.com/users/biolab/orgs","repos_url":"https://api.github.com/users/biolab/repos","events_url":"https://api.github.com/users/biolab/events{/privacy}","received_events_url":"https://api.github.com/users/biolab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/biolab/orange3","description":"Orange 3 data mining suite: http://orange.biolab.si ","fork":false,"url":"https://api.github.com/repos/biolab/orange3","forks_url":"https://api.github.com/repos/biolab/orange3/forks","keys_url":"https://api.github.com/repos/biolab/orange3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/biolab/orange3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/biolab/orange3/teams","hooks_url":"https://api.github.com/repos/biolab/orange3/hooks","issue_events_url":"https://api.github.com/repos/biolab/orange3/issues/events{/number}","events_url":"https://api.github.com/repos/biolab/orange3/events","assignees_url":"https://api.github.com/repos/biolab/orange3/assignees{/user}","branches_url":"https://api.github.com/repos/biolab/orange3/branches{/branch}","tags_url":"https://api.github.com/repos/biolab/orange3/tags","blobs_url":"https://api.github.com/repos/biolab/orange3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/biolab/orange3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/biolab/orange3/git/refs{/sha}","trees_url":"https://api.github.com/repos/biolab/orange3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/biolab/orange3/statuses/{sha}","languages_url":"https://api.github.com/repos/biolab/orange3/languages","stargazers_url":"https://api.github.com/repos/biolab/orange3/stargazers","contributors_url":"https://api.github.com/repos/biolab/orange3/contributors","subscribers_url":"https://api.github.com/repos/biolab/orange3/subscribers","subscription_url":"https://api.github.com/repos/biolab/orange3/subscription","commits_url":"https://api.github.com/repos/biolab/orange3/commits{/sha}","git_commits_url":"https://api.github.com/repos/biolab/orange3/git/commits{/sha}","comments_url":"https://api.github.com/repos/biolab/orange3/comments{/number}","issue_comment_url":"https://api.github.com/repos/biolab/orange3/issues/comments{/number}","contents_url":"https://api.github.com/repos/biolab/orange3/contents/{+path}","compare_url":"https://api.github.com/repos/biolab/orange3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/biolab/orange3/merges","archive_url":"https://api.github.com/repos/biolab/orange3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/biolab/orange3/downloads","issues_url":"https://api.github.com/repos/biolab/orange3/issues{/number}","pulls_url":"https://api.github.com/repos/biolab/orange3/pulls{/number}","milestones_url":"https://api.github.com/repos/biolab/orange3/milestones{/number}","notifications_url":"https://api.github.com/repos/biolab/orange3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/biolab/orange3/labels{/name}","releases_url":"https://api.github.com/repos/biolab/orange3/releases{/id}","deployments_url":"https://api.github.com/repos/biolab/orange3/deployments","created_at":"2013-02-22T12:52:56Z","updated_at":"2016-11-24T01:52:34Z","pushed_at":"2016-11-24T15:33:10Z","git_url":"git://github.com/biolab/orange3.git","ssh_url":"git@github.com:biolab/orange3.git","clone_url":"https://github.com/biolab/orange3.git","svn_url":"https://github.com/biolab/orange3","homepage":"","size":97228,"stargazers_count":551,"watchers_count":551,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":179,"mirror_url":null,"open_issues_count":80,"forks":179,"open_issues":80,"watchers":551,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/biolab/orange3/pulls/1771"},"html":{"href":"https://github.com/biolab/orange3/pull/1771"},"issue":{"href":"https://api.github.com/repos/biolab/orange3/issues/1771"},"comments":{"href":"https://api.github.com/repos/biolab/orange3/issues/1771/comments"},"review_comments":{"href":"https://api.github.com/repos/biolab/orange3/pulls/1771/comments"},"review_comment":{"href":"https://api.github.com/repos/biolab/orange3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/biolab/orange3/pulls/1771/commits"},"statuses":{"href":"https://api.github.com/repos/biolab/orange3/statuses/c6811221fc3a08b040eb8a5c14b443f52316ec60"}}}}
{"actor":{"display_login":"kernc"}}