{"action":"created","comment":{"url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/pulls/comments/67435786","id":67435786,"diff_hunk":"@@ -1092,10 +1093,17 @@ sub _store_workbook {\n     );\n \n     # Store the xlsx component files with the temp dir name removed.\n+    my $createtime = timegm(@{ $self->{_doc_properties}{created} || $self->{_createtime} });\n+\n     for my $filename ( @xlsx_files ) {\n         my $short_name = $filename;\n         $short_name =~ s{^\\Q$tempdir\\E/?}{};\n-        $zip->addFile( $filename, $short_name );\n+        my $member = $zip->addFile( $filename, $short_name );\n+\n+        # Set zip member timestamp to match the workbook's timestamp, so that\n+        # generated files are stable when the workbook's \"created\" property is\n+        # manually set.\n+        $member->setLastModFileDateTimeFromUnix( $createtime );","path":"lib/Excel/Writer/XLSX/Workbook.pm","position":23,"original_position":23,"commit_id":"ef2454f690ac65e88846375f103d75e58f1d5e88","original_commit_id":"ef2454f690ac65e88846375f103d75e58f1d5e88","user":{"login":"tsibley","id":79913,"avatar_url":"https://avatars.githubusercontent.com/u/79913?v=3","gravatar_id":"","url":"https://api.github.com/users/tsibley","html_url":"https://github.com/tsibley","followers_url":"https://api.github.com/users/tsibley/followers","following_url":"https://api.github.com/users/tsibley/following{/other_user}","gists_url":"https://api.github.com/users/tsibley/gists{/gist_id}","starred_url":"https://api.github.com/users/tsibley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsibley/subscriptions","organizations_url":"https://api.github.com/users/tsibley/orgs","repos_url":"https://api.github.com/users/tsibley/repos","events_url":"https://api.github.com/users/tsibley/events{/privacy}","received_events_url":"https://api.github.com/users/tsibley/received_events","type":"User","site_admin":false},"body":"Stable here means \"the same when generated with the same inputs\".\r\n\r\nI'll elaborate on the reason for this in the issue I create.","created_at":"2016-06-16T22:30:27Z","updated_at":"2016-06-16T22:30:27Z","html_url":"https://github.com/jmcnamara/excel-writer-xlsx/pull/166#discussion_r67435786","pull_request_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/pulls/166","_links":{"self":{"href":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/pulls/comments/67435786"},"html":{"href":"https://github.com/jmcnamara/excel-writer-xlsx/pull/166#discussion_r67435786"},"pull_request":{"href":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/pulls/166"}}},"pull_request":{"url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/pulls/166","id":74147777,"html_url":"https://github.com/jmcnamara/excel-writer-xlsx/pull/166","diff_url":"https://github.com/jmcnamara/excel-writer-xlsx/pull/166.diff","patch_url":"https://github.com/jmcnamara/excel-writer-xlsx/pull/166.patch","issue_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/issues/166","number":166,"state":"open","locked":false,"title":"Stable timestamps","user":{"login":"tsibley","id":79913,"avatar_url":"https://avatars.githubusercontent.com/u/79913?v=3","gravatar_id":"","url":"https://api.github.com/users/tsibley","html_url":"https://github.com/tsibley","followers_url":"https://api.github.com/users/tsibley/followers","following_url":"https://api.github.com/users/tsibley/following{/other_user}","gists_url":"https://api.github.com/users/tsibley/gists{/gist_id}","starred_url":"https://api.github.com/users/tsibley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsibley/subscriptions","organizations_url":"https://api.github.com/users/tsibley/orgs","repos_url":"https://api.github.com/users/tsibley/repos","events_url":"https://api.github.com/users/tsibley/events{/privacy}","received_events_url":"https://api.github.com/users/tsibley/received_events","type":"User","site_admin":false},"body":"One doc change for `set_properties` and a behaviour change when packaging up the zip file to set zip file member timestamps.\r\n\r\nThe commit messages explain the rationale.","created_at":"2016-06-16T20:36:42Z","updated_at":"2016-06-16T22:30:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7996f2ecd0b992164a19b7fe2affda7c0189d30e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/pulls/166/commits","review_comments_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/pulls/166/comments","review_comment_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/issues/166/comments","statuses_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/statuses/ef2454f690ac65e88846375f103d75e58f1d5e88","head":{"label":"tsibley:stable-timestamps","ref":"stable-timestamps","sha":"ef2454f690ac65e88846375f103d75e58f1d5e88","user":{"login":"tsibley","id":79913,"avatar_url":"https://avatars.githubusercontent.com/u/79913?v=3","gravatar_id":"","url":"https://api.github.com/users/tsibley","html_url":"https://github.com/tsibley","followers_url":"https://api.github.com/users/tsibley/followers","following_url":"https://api.github.com/users/tsibley/following{/other_user}","gists_url":"https://api.github.com/users/tsibley/gists{/gist_id}","starred_url":"https://api.github.com/users/tsibley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsibley/subscriptions","organizations_url":"https://api.github.com/users/tsibley/orgs","repos_url":"https://api.github.com/users/tsibley/repos","events_url":"https://api.github.com/users/tsibley/events{/privacy}","received_events_url":"https://api.github.com/users/tsibley/received_events","type":"User","site_admin":false},"repo":{"id":61314266,"name":"Excel-Writer-XLSX","full_name":"tsibley/Excel-Writer-XLSX","owner":{"login":"tsibley","id":79913,"avatar_url":"https://avatars.githubusercontent.com/u/79913?v=3","gravatar_id":"","url":"https://api.github.com/users/tsibley","html_url":"https://github.com/tsibley","followers_url":"https://api.github.com/users/tsibley/followers","following_url":"https://api.github.com/users/tsibley/following{/other_user}","gists_url":"https://api.github.com/users/tsibley/gists{/gist_id}","starred_url":"https://api.github.com/users/tsibley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsibley/subscriptions","organizations_url":"https://api.github.com/users/tsibley/orgs","repos_url":"https://api.github.com/users/tsibley/repos","events_url":"https://api.github.com/users/tsibley/events{/privacy}","received_events_url":"https://api.github.com/users/tsibley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tsibley/Excel-Writer-XLSX","description":"Perl module to create Excel XLSX files. ","fork":true,"url":"https://api.github.com/repos/tsibley/Excel-Writer-XLSX","forks_url":"https://api.github.com/repos/tsibley/Excel-Writer-XLSX/forks","keys_url":"https://api.github.com/repos/tsibley/Excel-Writer-XLSX/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tsibley/Excel-Writer-XLSX/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tsibley/Excel-Writer-XLSX/teams","hooks_url":"https://api.github.com/repos/tsibley/Excel-Writer-XLSX/hooks","issue_events_url":"https://api.github.com/repos/tsibley/Excel-Writer-XLSX/issues/events{/number}","events_url":"https://api.github.com/repos/tsibley/Excel-Writer-XLSX/events","assignees_url":"https://api.github.com/repos/tsibley/Excel-Writer-XLSX/assignees{/user}","branches_url":"https://api.github.com/repos/tsibley/Excel-Writer-XLSX/branches{/branch}","tags_url":"https://api.github.com/repos/tsibley/Excel-Writer-XLSX/tags","blobs_url":"https://api.github.com/repos/tsibley/Excel-Writer-XLSX/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tsibley/Excel-Writer-XLSX/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tsibley/Excel-Writer-XLSX/git/refs{/sha}","trees_url":"https://api.github.com/repos/tsibley/Excel-Writer-XLSX/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tsibley/Excel-Writer-XLSX/statuses/{sha}","languages_url":"https://api.github.com/repos/tsibley/Excel-Writer-XLSX/languages","stargazers_url":"https://api.github.com/repos/tsibley/Excel-Writer-XLSX/stargazers","contributors_url":"https://api.github.com/repos/tsibley/Excel-Writer-XLSX/contributors","subscribers_url":"https://api.github.com/repos/tsibley/Excel-Writer-XLSX/subscribers","subscription_url":"https://api.github.com/repos/tsibley/Excel-Writer-XLSX/subscription","commits_url":"https://api.github.com/repos/tsibley/Excel-Writer-XLSX/commits{/sha}","git_commits_url":"https://api.github.com/repos/tsibley/Excel-Writer-XLSX/git/commits{/sha}","comments_url":"https://api.github.com/repos/tsibley/Excel-Writer-XLSX/comments{/number}","issue_comment_url":"https://api.github.com/repos/tsibley/Excel-Writer-XLSX/issues/comments{/number}","contents_url":"https://api.github.com/repos/tsibley/Excel-Writer-XLSX/contents/{+path}","compare_url":"https://api.github.com/repos/tsibley/Excel-Writer-XLSX/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tsibley/Excel-Writer-XLSX/merges","archive_url":"https://api.github.com/repos/tsibley/Excel-Writer-XLSX/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tsibley/Excel-Writer-XLSX/downloads","issues_url":"https://api.github.com/repos/tsibley/Excel-Writer-XLSX/issues{/number}","pulls_url":"https://api.github.com/repos/tsibley/Excel-Writer-XLSX/pulls{/number}","milestones_url":"https://api.github.com/repos/tsibley/Excel-Writer-XLSX/milestones{/number}","notifications_url":"https://api.github.com/repos/tsibley/Excel-Writer-XLSX/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tsibley/Excel-Writer-XLSX/labels{/name}","releases_url":"https://api.github.com/repos/tsibley/Excel-Writer-XLSX/releases{/id}","deployments_url":"https://api.github.com/repos/tsibley/Excel-Writer-XLSX/deployments","created_at":"2016-06-16T17:51:12Z","updated_at":"2016-06-16T20:35:01Z","pushed_at":"2016-06-16T20:35:16Z","git_url":"git://github.com/tsibley/Excel-Writer-XLSX.git","ssh_url":"git@github.com:tsibley/Excel-Writer-XLSX.git","clone_url":"https://github.com/tsibley/Excel-Writer-XLSX.git","svn_url":"https://github.com/tsibley/Excel-Writer-XLSX","homepage":"http://search.cpan.org/dist/Excel-Writer-XLSX/lib/Excel/Writer/XLSX.pm","size":14094,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jmcnamara:master","ref":"master","sha":"7a15a0adda3336102db1c9470242544a36371c27","user":{"login":"jmcnamara","id":94267,"avatar_url":"https://avatars.githubusercontent.com/u/94267?v=3","gravatar_id":"","url":"https://api.github.com/users/jmcnamara","html_url":"https://github.com/jmcnamara","followers_url":"https://api.github.com/users/jmcnamara/followers","following_url":"https://api.github.com/users/jmcnamara/following{/other_user}","gists_url":"https://api.github.com/users/jmcnamara/gists{/gist_id}","starred_url":"https://api.github.com/users/jmcnamara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmcnamara/subscriptions","organizations_url":"https://api.github.com/users/jmcnamara/orgs","repos_url":"https://api.github.com/users/jmcnamara/repos","events_url":"https://api.github.com/users/jmcnamara/events{/privacy}","received_events_url":"https://api.github.com/users/jmcnamara/received_events","type":"User","site_admin":false},"repo":{"id":867559,"name":"excel-writer-xlsx","full_name":"jmcnamara/excel-writer-xlsx","owner":{"login":"jmcnamara","id":94267,"avatar_url":"https://avatars.githubusercontent.com/u/94267?v=3","gravatar_id":"","url":"https://api.github.com/users/jmcnamara","html_url":"https://github.com/jmcnamara","followers_url":"https://api.github.com/users/jmcnamara/followers","following_url":"https://api.github.com/users/jmcnamara/following{/other_user}","gists_url":"https://api.github.com/users/jmcnamara/gists{/gist_id}","starred_url":"https://api.github.com/users/jmcnamara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmcnamara/subscriptions","organizations_url":"https://api.github.com/users/jmcnamara/orgs","repos_url":"https://api.github.com/users/jmcnamara/repos","events_url":"https://api.github.com/users/jmcnamara/events{/privacy}","received_events_url":"https://api.github.com/users/jmcnamara/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmcnamara/excel-writer-xlsx","description":"Perl module to create Excel XLSX files. ","fork":false,"url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx","forks_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/forks","keys_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/teams","hooks_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/hooks","issue_events_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/issues/events{/number}","events_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/events","assignees_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/assignees{/user}","branches_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/branches{/branch}","tags_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/tags","blobs_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/statuses/{sha}","languages_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/languages","stargazers_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/stargazers","contributors_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/contributors","subscribers_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/subscribers","subscription_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/subscription","commits_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/contents/{+path}","compare_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/merges","archive_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/downloads","issues_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/issues{/number}","pulls_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/pulls{/number}","milestones_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/milestones{/number}","notifications_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/labels{/name}","releases_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/releases{/id}","deployments_url":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/deployments","created_at":"2010-08-28T00:26:49Z","updated_at":"2016-06-11T01:48:18Z","pushed_at":"2016-06-16T20:36:42Z","git_url":"git://github.com/jmcnamara/excel-writer-xlsx.git","ssh_url":"git@github.com:jmcnamara/excel-writer-xlsx.git","clone_url":"https://github.com/jmcnamara/excel-writer-xlsx.git","svn_url":"https://github.com/jmcnamara/excel-writer-xlsx","homepage":"http://search.cpan.org/dist/Excel-Writer-XLSX/lib/Excel/Writer/XLSX.pm","size":14516,"stargazers_count":60,"watchers_count":60,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":25,"mirror_url":null,"open_issues_count":12,"forks":25,"open_issues":12,"watchers":60,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/pulls/166"},"html":{"href":"https://github.com/jmcnamara/excel-writer-xlsx/pull/166"},"issue":{"href":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/issues/166"},"comments":{"href":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/issues/166/comments"},"review_comments":{"href":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/pulls/166/comments"},"review_comment":{"href":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/pulls/166/commits"},"statuses":{"href":"https://api.github.com/repos/jmcnamara/excel-writer-xlsx/statuses/ef2454f690ac65e88846375f103d75e58f1d5e88"}}}}
{"actor":{"display_login":"tsibley"}}