{"action":"created","comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments/69697230","id":69697230,"diff_hunk":"@@ -295,23 +318,54 @@ const PlansSetup = React.createClass( {\n \t},\n \n \trenderSuccess() {\n+\t\tlet noticeText;\n \t\tconst site = this.props.selectedSite;\n \t\tif ( ! this.props.hasRequested || ! this.props.isFinished ) {\n \t\t\treturn null;\n \t\t}\n \n-\t\tconst pluginsWithErrors = filter( this.props.plugins, ( item ) => {\n+\t\tconst plugins = this.addWporgDataToPlugins( this.props.plugins );\n+\t\tconst pluginsWithErrors = filter( plugins, ( item ) => {\n \t\t\treturn ( item.error !== null );\n \t\t} );\n \n \t\tif ( pluginsWithErrors.length ) {","path":"client/my-sites/plugins/jetpack-plugins-setup/index.jsx","position":88,"original_position":88,"commit_id":"3b083ccd8b95f362d8f68442159e295c4d9b1696","original_commit_id":"3b083ccd8b95f362d8f68442159e295c4d9b1696","user":{"login":"johnHackworth","id":1554855,"avatar_url":"https://avatars.githubusercontent.com/u/1554855?v=3","gravatar_id":"","url":"https://api.github.com/users/johnHackworth","html_url":"https://github.com/johnHackworth","followers_url":"https://api.github.com/users/johnHackworth/followers","following_url":"https://api.github.com/users/johnHackworth/following{/other_user}","gists_url":"https://api.github.com/users/johnHackworth/gists{/gist_id}","starred_url":"https://api.github.com/users/johnHackworth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnHackworth/subscriptions","organizations_url":"https://api.github.com/users/johnHackworth/orgs","repos_url":"https://api.github.com/users/johnHackworth/repos","events_url":"https://api.github.com/users/johnHackworth/events{/privacy}","received_events_url":"https://api.github.com/users/johnHackworth/received_events","type":"User","site_admin":false},"body":"Maybe all the code within this `if` block could be extracted to a new `renderErrorMessages` method so it's just \r\n```\r\nif ( pluginsWithErrors.length ) {\r\n   return this.renderErrorMessages();\r\n}\r\n```\r\n\r\nNot that it adds anything, but it would make the code a little more compact","created_at":"2016-07-06T09:08:07Z","updated_at":"2016-07-06T09:08:07Z","html_url":"https://github.com/Automattic/wp-calypso/pull/6480#discussion_r69697230","pull_request_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/6480","_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments/69697230"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/6480#discussion_r69697230"},"pull_request":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/6480"}}},"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/6480","id":75991723,"html_url":"https://github.com/Automattic/wp-calypso/pull/6480","diff_url":"https://github.com/Automattic/wp-calypso/pull/6480.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/6480.patch","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/6480","number":6480,"state":"open","locked":false,"title":"Jetpack NUX: Update error screen for plugins auto-config","user":{"login":"ryelle","id":541093,"avatar_url":"https://avatars.githubusercontent.com/u/541093?v=3","gravatar_id":"","url":"https://api.github.com/users/ryelle","html_url":"https://github.com/ryelle","followers_url":"https://api.github.com/users/ryelle/followers","following_url":"https://api.github.com/users/ryelle/following{/other_user}","gists_url":"https://api.github.com/users/ryelle/gists{/gist_id}","starred_url":"https://api.github.com/users/ryelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryelle/subscriptions","organizations_url":"https://api.github.com/users/ryelle/orgs","repos_url":"https://api.github.com/users/ryelle/repos","events_url":"https://api.github.com/users/ryelle/events{/privacy}","received_events_url":"https://api.github.com/users/ryelle/received_events","type":"User","site_admin":false},"body":"We should show more detailed error messages when we  can't install plugins, or when installation fails.\r\n\r\nTo test (part 1):\r\n\r\n1. Visit the install page for a site with `DISALLOW_FILE_MODS` set, or which is a subsite of a multisite, or any other case we can't install plugins on.\r\n2. You'll see an \"Oh no!\" message, with text saying why we can't install plugins on this site.\r\n3. You can click a \"Contact Support\" button.\r\n\r\nPreview:\r\n\r\n![screen shot 2016-06-30 at 6 06 47 pm](https://cloud.githubusercontent.com/assets/541093/16525154/0da22120-3f79-11e6-8ce7-da071a0c9bb3.png)\r\n\r\nTo test (part 2):\r\n\r\n1. Visit the install page with a site we know will encounter an error (easy breakage: create a folder called `akismet` in your plugins folder, set permissions so the web user can't write to it)\r\n2. Your plugins will start to install, then encounter whatever error case you have. The plugin with the error gets a compact error notice.\r\n3. When all plugins are installed, a larger notice appears, saying that there was an error, with a link to manual install instructions, and an action to contact support.\r\n\r\nPreview:\r\n\r\n![screen shot 2016-07-01 at 5 15 56 pm](https://cloud.githubusercontent.com/assets/541093/16534685/bbd9b3da-3faf-11e6-9f07-03f19e419f5f.png)\r\n\r\nFixes #6432\r\n\r\nTest live: https://calypso.live/?branch=update/jetpack-config-errors","created_at":"2016-07-01T14:51:59Z","updated_at":"2016-07-06T09:08:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1582fbd7046326dc6a50c5e1a99beb362cf817f","assignee":{"login":"ryelle","id":541093,"avatar_url":"https://avatars.githubusercontent.com/u/541093?v=3","gravatar_id":"","url":"https://api.github.com/users/ryelle","html_url":"https://github.com/ryelle","followers_url":"https://api.github.com/users/ryelle/followers","following_url":"https://api.github.com/users/ryelle/following{/other_user}","gists_url":"https://api.github.com/users/ryelle/gists{/gist_id}","starred_url":"https://api.github.com/users/ryelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryelle/subscriptions","organizations_url":"https://api.github.com/users/ryelle/orgs","repos_url":"https://api.github.com/users/ryelle/repos","events_url":"https://api.github.com/users/ryelle/events{/privacy}","received_events_url":"https://api.github.com/users/ryelle/received_events","type":"User","site_admin":false},"assignees":[{"login":"ryelle","id":541093,"avatar_url":"https://avatars.githubusercontent.com/u/541093?v=3","gravatar_id":"","url":"https://api.github.com/users/ryelle","html_url":"https://github.com/ryelle","followers_url":"https://api.github.com/users/ryelle/followers","following_url":"https://api.github.com/users/ryelle/following{/other_user}","gists_url":"https://api.github.com/users/ryelle/gists{/gist_id}","starred_url":"https://api.github.com/users/ryelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryelle/subscriptions","organizations_url":"https://api.github.com/users/ryelle/orgs","repos_url":"https://api.github.com/users/ryelle/repos","events_url":"https://api.github.com/users/ryelle/events{/privacy}","received_events_url":"https://api.github.com/users/ryelle/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Automattic/wp-calypso/milestones/94","html_url":"https://github.com/Automattic/wp-calypso/milestones/Jetpack%20NUX%20m1","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones/94/labels","id":1799332,"number":94,"title":"Jetpack NUX m1","description":"Iterating on Jetpack Connect and Premium Plugins Autoconfig, improvements to flows, testing alternatives","creator":{"login":"rickybanister","id":437258,"avatar_url":"https://avatars.githubusercontent.com/u/437258?v=3","gravatar_id":"","url":"https://api.github.com/users/rickybanister","html_url":"https://github.com/rickybanister","followers_url":"https://api.github.com/users/rickybanister/followers","following_url":"https://api.github.com/users/rickybanister/following{/other_user}","gists_url":"https://api.github.com/users/rickybanister/gists{/gist_id}","starred_url":"https://api.github.com/users/rickybanister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rickybanister/subscriptions","organizations_url":"https://api.github.com/users/rickybanister/orgs","repos_url":"https://api.github.com/users/rickybanister/repos","events_url":"https://api.github.com/users/rickybanister/events{/privacy}","received_events_url":"https://api.github.com/users/rickybanister/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":18,"state":"open","created_at":"2016-05-31T17:44:42Z","updated_at":"2016-07-05T11:35:24Z","due_on":"2016-08-30T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/6480/commits","review_comments_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/6480/comments","review_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/6480/comments","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/3b083ccd8b95f362d8f68442159e295c4d9b1696","head":{"label":"Automattic:update/jetpack-config-errors","ref":"update/jetpack-config-errors","sha":"3b083ccd8b95f362d8f68442159e295c4d9b1696","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The new JavaScript- and API-powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-calypso/deployments","created_at":"2015-11-10T20:00:16Z","updated_at":"2016-07-06T08:37:04Z","pushed_at":"2016-07-06T06:27:00Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"git@github.com:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":80822,"stargazers_count":7550,"watchers_count":7550,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":939,"mirror_url":null,"open_issues_count":1330,"forks":939,"open_issues":1330,"watchers":7550,"default_branch":"master"}},"base":{"label":"Automattic:master","ref":"master","sha":"8238571290db36b15e986fd04c83c3311708d8b0","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The new JavaScript- and API-powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-calypso/deployments","created_at":"2015-11-10T20:00:16Z","updated_at":"2016-07-06T08:37:04Z","pushed_at":"2016-07-06T06:27:00Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"git@github.com:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":80822,"stargazers_count":7550,"watchers_count":7550,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":939,"mirror_url":null,"open_issues_count":1330,"forks":939,"open_issues":1330,"watchers":7550,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/6480"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/6480"},"issue":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/6480"},"comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/6480/comments"},"review_comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/6480/comments"},"review_comment":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/6480/commits"},"statuses":{"href":"https://api.github.com/repos/Automattic/wp-calypso/statuses/3b083ccd8b95f362d8f68442159e295c4d9b1696"}}}}
{"actor":{"display_login":"johnHackworth"}}