{"action":"created","comment":{"url":"https://api.github.com/repos/socialcast/masamune/pulls/comments/70291670","id":70291670,"diff_hunk":"@@ -35,8 +35,8 @@\n   let(:rule) { Masamune::DataPlan::Rule.new(engine, name, type, path: '/report/%Y-%m-%d/%H') }\n   let(:other_rule) { Masamune::DataPlan::Rule.new(engine, name, type, path: '/log/%Y%m%d.*.log') }\n \n-  let(:start_time) { DateTime.civil(2013, 07, 19, 11, 07) }\n-  let(:other_start_time) { DateTime.civil(2013, 07, 20, 0, 0) }\n+  let(:start_time) { DateTime.civil(2013, 0o7, 19, 11, 0o7) }","path":"spec/masamune/data_plan/elem_spec.rb","position":6,"original_position":6,"commit_id":"bb14961216353f04ed6f76fc6cf112311478d04b","original_commit_id":"bb14961216353f04ed6f76fc6cf112311478d04b","user":{"login":"mandrews","id":120708,"avatar_url":"https://avatars.githubusercontent.com/u/120708?v=3","gravatar_id":"","url":"https://api.github.com/users/mandrews","html_url":"https://github.com/mandrews","followers_url":"https://api.github.com/users/mandrews/followers","following_url":"https://api.github.com/users/mandrews/following{/other_user}","gists_url":"https://api.github.com/users/mandrews/gists{/gist_id}","starred_url":"https://api.github.com/users/mandrews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandrews/subscriptions","organizations_url":"https://api.github.com/users/mandrews/orgs","repos_url":"https://api.github.com/users/mandrews/repos","events_url":"https://api.github.com/users/mandrews/events{/privacy}","received_events_url":"https://api.github.com/users/mandrews/received_events","type":"User","site_admin":false},"body":"@eatstoomuchjam - its just what rubocop wanted - I'll ignore that rule - seems confusing","created_at":"2016-07-11T16:33:57Z","updated_at":"2016-07-11T16:33:57Z","html_url":"https://github.com/socialcast/masamune/pull/186#discussion_r70291670","pull_request_url":"https://api.github.com/repos/socialcast/masamune/pulls/186","_links":{"self":{"href":"https://api.github.com/repos/socialcast/masamune/pulls/comments/70291670"},"html":{"href":"https://github.com/socialcast/masamune/pull/186#discussion_r70291670"},"pull_request":{"href":"https://api.github.com/repos/socialcast/masamune/pulls/186"}}},"pull_request":{"url":"https://api.github.com/repos/socialcast/masamune/pulls/186","id":76829309,"html_url":"https://github.com/socialcast/masamune/pull/186","diff_url":"https://github.com/socialcast/masamune/pull/186.diff","patch_url":"https://github.com/socialcast/masamune/pull/186.patch","issue_url":"https://api.github.com/repos/socialcast/masamune/issues/186","number":186,"state":"open","locked":false,"title":"Fix skip_or_raise","user":{"login":"mandrews","id":120708,"avatar_url":"https://avatars.githubusercontent.com/u/120708?v=3","gravatar_id":"","url":"https://api.github.com/users/mandrews","html_url":"https://github.com/mandrews","followers_url":"https://api.github.com/users/mandrews/followers","following_url":"https://api.github.com/users/mandrews/following{/other_user}","gists_url":"https://api.github.com/users/mandrews/gists{/gist_id}","starred_url":"https://api.github.com/users/mandrews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandrews/subscriptions","organizations_url":"https://api.github.com/users/mandrews/orgs","repos_url":"https://api.github.com/users/mandrews/repos","events_url":"https://api.github.com/users/mandrews/events{/privacy}","received_events_url":"https://api.github.com/users/mandrews/received_events","type":"User","site_admin":false},"body":"I noticed this backtrace:\r\n```\r\n/usr/local/share/ruby/gems/2.3/gems/masamune-0.17.14/lib/masamune/schema/map.rb:127:in `to_s': uninitialized constant Masamune::Schema::Map::Buffer::Tempfile (NameError)\r\n        from /usr/local/share/ruby/gems/2.3/gems/activesupport-5.0.0/lib/active_support/core_ext/object/try.rb:17:in `public_send'\r\n        from /usr/local/share/ruby/gems/2.3/gems/activesupport-5.0.0/lib/active_support/core_ext/object/try.rb:17:in `try!'\r\n        from /usr/local/share/ruby/gems/2.3/gems/activesupport-5.0.0/lib/active_support/core_ext/object/try.rb:6:in `try'\r\n        from /usr/local/share/ruby/gems/2.3/gems/masamune-0.17.14/lib/masamune/schema/map.rb:242:in `skip_or_raise'\r\n        from /usr/local/share/ruby/gems/2.3/gems/masamune-0.17.14/lib/masamune/schema/map.rb:158:in `rescue in safe_row'\r\n        from /usr/local/share/ruby/gems/2.3/gems/masamune-0.17.14/lib/masamune/schema/map.rb:156:in `safe_row'\r\n        from /usr/local/share/ruby/gems/2.3/gems/masamune-0.17.14/lib/masamune/schema/map.rb:108:in `block in each'\r\n        from /usr/share/ruby/2.3/csv.rb:1748:in `each'\r\n        from /usr/share/ruby/2.3/csv.rb:1312:in `parse'\r\n        from /usr/local/share/ruby/gems/2.3/gems/masamune-0.17.14/lib/masamune/schema/map.rb:106:in `each'\r\n        from /usr/local/share/ruby/gems/2.3/gems/masamune-0.17.14/lib/masamune/schema/map.rb:286:in `apply_buffer'\r\n        from /usr/local/share/ruby/gems/2.3/gems/masamune-0.17.14/lib/masamune/schema/map.rb:221:in `block (3 levels) in apply'\r\n        from /usr/local/share/ruby/gems/2.3/gems/masamune-0.17.14/lib/masamune/schema/map.rb:232:in `open_stream'\r\n        from /usr/local/share/ruby/gems/2.3/gems/masamune-0.17.14/lib/masamune/schema/map.rb:219:in `block (2 levels) in apply'\r\n        from /usr/local/share/ruby/gems/2.3/gems/masamune-0.17.14/lib/masamune/schema/map.rb:232:in `open_stream'\r\n        from /usr/local/share/ruby/gems/2.3/gems/masamune-0.17.14/lib/masamune/schema/map.rb:217:in `block in apply'\r\n        from /usr/local/share/ruby/gems/2.3/gems/masamune-0.17.14/lib/masamune/schema/map.rb:216:in `each'\r\n        from /usr/local/share/ruby/gems/2.3/gems/masamune-0.17.14/lib/masamune/schema/map.rb:216:in `apply'\r\n```\r\n\r\nIssue was that package \"tempfile\" was not being loaded at this point of execution. Since it's used throughout the code, solution is to just include in the module include and remove from `spec_helper.rb` to ensure the problem isn't masked.  After fixing code that actually reports the error I noticed that `JSON.load` was failing on Linux with UTF-8 values. Using `JSON.parse` without quirks mode fixes issue.\r\n\r\nRest of change is related to updating rubocop.","created_at":"2016-07-08T23:46:49Z","updated_at":"2016-07-11T16:33:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af741ef026187ca2860ac42e2a15d620f02422f8","assignee":{"login":"eatstoomuchjam","id":1179027,"avatar_url":"https://avatars.githubusercontent.com/u/1179027?v=3","gravatar_id":"","url":"https://api.github.com/users/eatstoomuchjam","html_url":"https://github.com/eatstoomuchjam","followers_url":"https://api.github.com/users/eatstoomuchjam/followers","following_url":"https://api.github.com/users/eatstoomuchjam/following{/other_user}","gists_url":"https://api.github.com/users/eatstoomuchjam/gists{/gist_id}","starred_url":"https://api.github.com/users/eatstoomuchjam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eatstoomuchjam/subscriptions","organizations_url":"https://api.github.com/users/eatstoomuchjam/orgs","repos_url":"https://api.github.com/users/eatstoomuchjam/repos","events_url":"https://api.github.com/users/eatstoomuchjam/events{/privacy}","received_events_url":"https://api.github.com/users/eatstoomuchjam/received_events","type":"User","site_admin":false},"assignees":[{"login":"eatstoomuchjam","id":1179027,"avatar_url":"https://avatars.githubusercontent.com/u/1179027?v=3","gravatar_id":"","url":"https://api.github.com/users/eatstoomuchjam","html_url":"https://github.com/eatstoomuchjam","followers_url":"https://api.github.com/users/eatstoomuchjam/followers","following_url":"https://api.github.com/users/eatstoomuchjam/following{/other_user}","gists_url":"https://api.github.com/users/eatstoomuchjam/gists{/gist_id}","starred_url":"https://api.github.com/users/eatstoomuchjam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eatstoomuchjam/subscriptions","organizations_url":"https://api.github.com/users/eatstoomuchjam/orgs","repos_url":"https://api.github.com/users/eatstoomuchjam/repos","events_url":"https://api.github.com/users/eatstoomuchjam/events{/privacy}","received_events_url":"https://api.github.com/users/eatstoomuchjam/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/socialcast/masamune/pulls/186/commits","review_comments_url":"https://api.github.com/repos/socialcast/masamune/pulls/186/comments","review_comment_url":"https://api.github.com/repos/socialcast/masamune/pulls/comments{/number}","comments_url":"https://api.github.com/repos/socialcast/masamune/issues/186/comments","statuses_url":"https://api.github.com/repos/socialcast/masamune/statuses/bb14961216353f04ed6f76fc6cf112311478d04b","head":{"label":"socialcast:fix-skip-or-raise","ref":"fix-skip-or-raise","sha":"bb14961216353f04ed6f76fc6cf112311478d04b","user":{"login":"socialcast","id":57931,"avatar_url":"https://avatars.githubusercontent.com/u/57931?v=3","gravatar_id":"","url":"https://api.github.com/users/socialcast","html_url":"https://github.com/socialcast","followers_url":"https://api.github.com/users/socialcast/followers","following_url":"https://api.github.com/users/socialcast/following{/other_user}","gists_url":"https://api.github.com/users/socialcast/gists{/gist_id}","starred_url":"https://api.github.com/users/socialcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socialcast/subscriptions","organizations_url":"https://api.github.com/users/socialcast/orgs","repos_url":"https://api.github.com/users/socialcast/repos","events_url":"https://api.github.com/users/socialcast/events{/privacy}","received_events_url":"https://api.github.com/users/socialcast/received_events","type":"Organization","site_admin":false},"repo":{"id":10484911,"name":"masamune","full_name":"socialcast/masamune","owner":{"login":"socialcast","id":57931,"avatar_url":"https://avatars.githubusercontent.com/u/57931?v=3","gravatar_id":"","url":"https://api.github.com/users/socialcast","html_url":"https://github.com/socialcast","followers_url":"https://api.github.com/users/socialcast/followers","following_url":"https://api.github.com/users/socialcast/following{/other_user}","gists_url":"https://api.github.com/users/socialcast/gists{/gist_id}","starred_url":"https://api.github.com/users/socialcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socialcast/subscriptions","organizations_url":"https://api.github.com/users/socialcast/orgs","repos_url":"https://api.github.com/users/socialcast/repos","events_url":"https://api.github.com/users/socialcast/events{/privacy}","received_events_url":"https://api.github.com/users/socialcast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/socialcast/masamune","description":"","fork":false,"url":"https://api.github.com/repos/socialcast/masamune","forks_url":"https://api.github.com/repos/socialcast/masamune/forks","keys_url":"https://api.github.com/repos/socialcast/masamune/keys{/key_id}","collaborators_url":"https://api.github.com/repos/socialcast/masamune/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/socialcast/masamune/teams","hooks_url":"https://api.github.com/repos/socialcast/masamune/hooks","issue_events_url":"https://api.github.com/repos/socialcast/masamune/issues/events{/number}","events_url":"https://api.github.com/repos/socialcast/masamune/events","assignees_url":"https://api.github.com/repos/socialcast/masamune/assignees{/user}","branches_url":"https://api.github.com/repos/socialcast/masamune/branches{/branch}","tags_url":"https://api.github.com/repos/socialcast/masamune/tags","blobs_url":"https://api.github.com/repos/socialcast/masamune/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/socialcast/masamune/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/socialcast/masamune/git/refs{/sha}","trees_url":"https://api.github.com/repos/socialcast/masamune/git/trees{/sha}","statuses_url":"https://api.github.com/repos/socialcast/masamune/statuses/{sha}","languages_url":"https://api.github.com/repos/socialcast/masamune/languages","stargazers_url":"https://api.github.com/repos/socialcast/masamune/stargazers","contributors_url":"https://api.github.com/repos/socialcast/masamune/contributors","subscribers_url":"https://api.github.com/repos/socialcast/masamune/subscribers","subscription_url":"https://api.github.com/repos/socialcast/masamune/subscription","commits_url":"https://api.github.com/repos/socialcast/masamune/commits{/sha}","git_commits_url":"https://api.github.com/repos/socialcast/masamune/git/commits{/sha}","comments_url":"https://api.github.com/repos/socialcast/masamune/comments{/number}","issue_comment_url":"https://api.github.com/repos/socialcast/masamune/issues/comments{/number}","contents_url":"https://api.github.com/repos/socialcast/masamune/contents/{+path}","compare_url":"https://api.github.com/repos/socialcast/masamune/compare/{base}...{head}","merges_url":"https://api.github.com/repos/socialcast/masamune/merges","archive_url":"https://api.github.com/repos/socialcast/masamune/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/socialcast/masamune/downloads","issues_url":"https://api.github.com/repos/socialcast/masamune/issues{/number}","pulls_url":"https://api.github.com/repos/socialcast/masamune/pulls{/number}","milestones_url":"https://api.github.com/repos/socialcast/masamune/milestones{/number}","notifications_url":"https://api.github.com/repos/socialcast/masamune/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/socialcast/masamune/labels{/name}","releases_url":"https://api.github.com/repos/socialcast/masamune/releases{/id}","deployments_url":"https://api.github.com/repos/socialcast/masamune/deployments","created_at":"2013-06-04T17:48:49Z","updated_at":"2016-01-12T21:33:34Z","pushed_at":"2016-07-09T00:08:28Z","git_url":"git://github.com/socialcast/masamune.git","ssh_url":"git@github.com:socialcast/masamune.git","clone_url":"https://github.com/socialcast/masamune.git","svn_url":"https://github.com/socialcast/masamune","homepage":null,"size":1948,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"socialcast:master","ref":"master","sha":"662927c2d806f26d5d8508a791b150fe1c43df38","user":{"login":"socialcast","id":57931,"avatar_url":"https://avatars.githubusercontent.com/u/57931?v=3","gravatar_id":"","url":"https://api.github.com/users/socialcast","html_url":"https://github.com/socialcast","followers_url":"https://api.github.com/users/socialcast/followers","following_url":"https://api.github.com/users/socialcast/following{/other_user}","gists_url":"https://api.github.com/users/socialcast/gists{/gist_id}","starred_url":"https://api.github.com/users/socialcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socialcast/subscriptions","organizations_url":"https://api.github.com/users/socialcast/orgs","repos_url":"https://api.github.com/users/socialcast/repos","events_url":"https://api.github.com/users/socialcast/events{/privacy}","received_events_url":"https://api.github.com/users/socialcast/received_events","type":"Organization","site_admin":false},"repo":{"id":10484911,"name":"masamune","full_name":"socialcast/masamune","owner":{"login":"socialcast","id":57931,"avatar_url":"https://avatars.githubusercontent.com/u/57931?v=3","gravatar_id":"","url":"https://api.github.com/users/socialcast","html_url":"https://github.com/socialcast","followers_url":"https://api.github.com/users/socialcast/followers","following_url":"https://api.github.com/users/socialcast/following{/other_user}","gists_url":"https://api.github.com/users/socialcast/gists{/gist_id}","starred_url":"https://api.github.com/users/socialcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socialcast/subscriptions","organizations_url":"https://api.github.com/users/socialcast/orgs","repos_url":"https://api.github.com/users/socialcast/repos","events_url":"https://api.github.com/users/socialcast/events{/privacy}","received_events_url":"https://api.github.com/users/socialcast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/socialcast/masamune","description":"","fork":false,"url":"https://api.github.com/repos/socialcast/masamune","forks_url":"https://api.github.com/repos/socialcast/masamune/forks","keys_url":"https://api.github.com/repos/socialcast/masamune/keys{/key_id}","collaborators_url":"https://api.github.com/repos/socialcast/masamune/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/socialcast/masamune/teams","hooks_url":"https://api.github.com/repos/socialcast/masamune/hooks","issue_events_url":"https://api.github.com/repos/socialcast/masamune/issues/events{/number}","events_url":"https://api.github.com/repos/socialcast/masamune/events","assignees_url":"https://api.github.com/repos/socialcast/masamune/assignees{/user}","branches_url":"https://api.github.com/repos/socialcast/masamune/branches{/branch}","tags_url":"https://api.github.com/repos/socialcast/masamune/tags","blobs_url":"https://api.github.com/repos/socialcast/masamune/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/socialcast/masamune/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/socialcast/masamune/git/refs{/sha}","trees_url":"https://api.github.com/repos/socialcast/masamune/git/trees{/sha}","statuses_url":"https://api.github.com/repos/socialcast/masamune/statuses/{sha}","languages_url":"https://api.github.com/repos/socialcast/masamune/languages","stargazers_url":"https://api.github.com/repos/socialcast/masamune/stargazers","contributors_url":"https://api.github.com/repos/socialcast/masamune/contributors","subscribers_url":"https://api.github.com/repos/socialcast/masamune/subscribers","subscription_url":"https://api.github.com/repos/socialcast/masamune/subscription","commits_url":"https://api.github.com/repos/socialcast/masamune/commits{/sha}","git_commits_url":"https://api.github.com/repos/socialcast/masamune/git/commits{/sha}","comments_url":"https://api.github.com/repos/socialcast/masamune/comments{/number}","issue_comment_url":"https://api.github.com/repos/socialcast/masamune/issues/comments{/number}","contents_url":"https://api.github.com/repos/socialcast/masamune/contents/{+path}","compare_url":"https://api.github.com/repos/socialcast/masamune/compare/{base}...{head}","merges_url":"https://api.github.com/repos/socialcast/masamune/merges","archive_url":"https://api.github.com/repos/socialcast/masamune/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/socialcast/masamune/downloads","issues_url":"https://api.github.com/repos/socialcast/masamune/issues{/number}","pulls_url":"https://api.github.com/repos/socialcast/masamune/pulls{/number}","milestones_url":"https://api.github.com/repos/socialcast/masamune/milestones{/number}","notifications_url":"https://api.github.com/repos/socialcast/masamune/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/socialcast/masamune/labels{/name}","releases_url":"https://api.github.com/repos/socialcast/masamune/releases{/id}","deployments_url":"https://api.github.com/repos/socialcast/masamune/deployments","created_at":"2013-06-04T17:48:49Z","updated_at":"2016-01-12T21:33:34Z","pushed_at":"2016-07-09T00:08:28Z","git_url":"git://github.com/socialcast/masamune.git","ssh_url":"git@github.com:socialcast/masamune.git","clone_url":"https://github.com/socialcast/masamune.git","svn_url":"https://github.com/socialcast/masamune","homepage":null,"size":1948,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/socialcast/masamune/pulls/186"},"html":{"href":"https://github.com/socialcast/masamune/pull/186"},"issue":{"href":"https://api.github.com/repos/socialcast/masamune/issues/186"},"comments":{"href":"https://api.github.com/repos/socialcast/masamune/issues/186/comments"},"review_comments":{"href":"https://api.github.com/repos/socialcast/masamune/pulls/186/comments"},"review_comment":{"href":"https://api.github.com/repos/socialcast/masamune/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/socialcast/masamune/pulls/186/commits"},"statuses":{"href":"https://api.github.com/repos/socialcast/masamune/statuses/bb14961216353f04ed6f76fc6cf112311478d04b"}}}}
{"actor":{"display_login":"mandrews"}}