{"action":"created","comment":{"url":"https://api.github.com/repos/fastlane/scan/pulls/comments/54638919","id":54638919,"diff_hunk":"@@ -47,15 +56,12 @@ def self.default_device_ios\n \n       sims = FastlaneCore::Simulator.all\n       xcode_target = Scan.project.build_settings(key: \"IPHONEOS_DEPLOYMENT_TARGET\")\n-\n-      # Filter out any simulators that are not the same major version of our deployment target\n-      if xcode_target.to_s.length > 0\n-        min_target = xcode_target.split(\".\").first.to_i\n-        sims = sims.select { |s| s.ios_version.to_i >= min_target }\n-      end\n+      sims = filter_simulators(sims, xcode_target)\n \n       # An iPhone 5s is reasonable small and useful for tests\n-      found = sims.find { |d| d.name == \"iPhone 5s\" }\n+      found = sims.find do |d|","path":"lib/scan/detect_values.rb","position":30,"original_position":30,"commit_id":"1be55bc8e2dea6e34993cae493d3c31375cf1b01","original_commit_id":"1be55bc8e2dea6e34993cae493d3c31375cf1b01","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Prefer `detect` over `find`.","created_at":"2016-03-01T21:30:36Z","updated_at":"2016-03-01T21:30:36Z","html_url":"https://github.com/fastlane/scan/pull/61#discussion_r54638919","pull_request_url":"https://api.github.com/repos/fastlane/scan/pulls/61","_links":{"self":{"href":"https://api.github.com/repos/fastlane/scan/pulls/comments/54638919"},"html":{"href":"https://github.com/fastlane/scan/pull/61#discussion_r54638919"},"pull_request":{"href":"https://api.github.com/repos/fastlane/scan/pulls/61"}}},"pull_request":{"url":"https://api.github.com/repos/fastlane/scan/pulls/61","id":54136388,"html_url":"https://github.com/fastlane/scan/pull/61","diff_url":"https://github.com/fastlane/scan/pull/61.diff","patch_url":"https://github.com/fastlane/scan/pull/61.patch","issue_url":"https://api.github.com/repos/fastlane/scan/issues/61","number":61,"state":"open","locked":false,"title":"Consider both major and minor versions when looking for compatible size","user":{"login":"mpirri","id":1190389,"avatar_url":"https://avatars.githubusercontent.com/u/1190389?v=3","gravatar_id":"","url":"https://api.github.com/users/mpirri","html_url":"https://github.com/mpirri","followers_url":"https://api.github.com/users/mpirri/followers","following_url":"https://api.github.com/users/mpirri/following{/other_user}","gists_url":"https://api.github.com/users/mpirri/gists{/gist_id}","starred_url":"https://api.github.com/users/mpirri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpirri/subscriptions","organizations_url":"https://api.github.com/users/mpirri/orgs","repos_url":"https://api.github.com/users/mpirri/repos","events_url":"https://api.github.com/users/mpirri/events{/privacy}","received_events_url":"https://api.github.com/users/mpirri/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-12-18T18:51:33Z","updated_at":"2016-03-01T21:30:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"275940aab96dcf5c0313af368b58188ff75609f5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fastlane/scan/pulls/61/commits","review_comments_url":"https://api.github.com/repos/fastlane/scan/pulls/61/comments","review_comment_url":"https://api.github.com/repos/fastlane/scan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fastlane/scan/issues/61/comments","statuses_url":"https://api.github.com/repos/fastlane/scan/statuses/1be55bc8e2dea6e34993cae493d3c31375cf1b01","head":{"label":"fastlane:feature/scan-os-minor-versions","ref":"feature/scan-os-minor-versions","sha":"1be55bc8e2dea6e34993cae493d3c31375cf1b01","user":{"login":"fastlane","id":11098337,"avatar_url":"https://avatars.githubusercontent.com/u/11098337?v=3","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"repo":{"id":43527860,"name":"scan","full_name":"fastlane/scan","owner":{"login":"fastlane","id":11098337,"avatar_url":"https://avatars.githubusercontent.com/u/11098337?v=3","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fastlane/scan","description":"The easiest way to run tests of your iOS and Mac app","fork":false,"url":"https://api.github.com/repos/fastlane/scan","forks_url":"https://api.github.com/repos/fastlane/scan/forks","keys_url":"https://api.github.com/repos/fastlane/scan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fastlane/scan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fastlane/scan/teams","hooks_url":"https://api.github.com/repos/fastlane/scan/hooks","issue_events_url":"https://api.github.com/repos/fastlane/scan/issues/events{/number}","events_url":"https://api.github.com/repos/fastlane/scan/events","assignees_url":"https://api.github.com/repos/fastlane/scan/assignees{/user}","branches_url":"https://api.github.com/repos/fastlane/scan/branches{/branch}","tags_url":"https://api.github.com/repos/fastlane/scan/tags","blobs_url":"https://api.github.com/repos/fastlane/scan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fastlane/scan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fastlane/scan/git/refs{/sha}","trees_url":"https://api.github.com/repos/fastlane/scan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fastlane/scan/statuses/{sha}","languages_url":"https://api.github.com/repos/fastlane/scan/languages","stargazers_url":"https://api.github.com/repos/fastlane/scan/stargazers","contributors_url":"https://api.github.com/repos/fastlane/scan/contributors","subscribers_url":"https://api.github.com/repos/fastlane/scan/subscribers","subscription_url":"https://api.github.com/repos/fastlane/scan/subscription","commits_url":"https://api.github.com/repos/fastlane/scan/commits{/sha}","git_commits_url":"https://api.github.com/repos/fastlane/scan/git/commits{/sha}","comments_url":"https://api.github.com/repos/fastlane/scan/comments{/number}","issue_comment_url":"https://api.github.com/repos/fastlane/scan/issues/comments{/number}","contents_url":"https://api.github.com/repos/fastlane/scan/contents/{+path}","compare_url":"https://api.github.com/repos/fastlane/scan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fastlane/scan/merges","archive_url":"https://api.github.com/repos/fastlane/scan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fastlane/scan/downloads","issues_url":"https://api.github.com/repos/fastlane/scan/issues{/number}","pulls_url":"https://api.github.com/repos/fastlane/scan/pulls{/number}","milestones_url":"https://api.github.com/repos/fastlane/scan/milestones{/number}","notifications_url":"https://api.github.com/repos/fastlane/scan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fastlane/scan/labels{/name}","releases_url":"https://api.github.com/repos/fastlane/scan/releases{/id}","deployments_url":"https://api.github.com/repos/fastlane/scan/deployments","created_at":"2015-10-02T00:07:42Z","updated_at":"2016-03-01T04:05:41Z","pushed_at":"2016-03-01T21:30:34Z","git_url":"git://github.com/fastlane/scan.git","ssh_url":"git@github.com:fastlane/scan.git","clone_url":"https://github.com/fastlane/scan.git","svn_url":"https://github.com/fastlane/scan","homepage":"https://fastlane.tools","size":950,"stargazers_count":233,"watchers_count":233,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":23,"forks":34,"open_issues":23,"watchers":233,"default_branch":"master"}},"base":{"label":"fastlane:master","ref":"master","sha":"2577e35e82d2eb8089f5028b258855dac16bf7e0","user":{"login":"fastlane","id":11098337,"avatar_url":"https://avatars.githubusercontent.com/u/11098337?v=3","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"repo":{"id":43527860,"name":"scan","full_name":"fastlane/scan","owner":{"login":"fastlane","id":11098337,"avatar_url":"https://avatars.githubusercontent.com/u/11098337?v=3","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fastlane/scan","description":"The easiest way to run tests of your iOS and Mac app","fork":false,"url":"https://api.github.com/repos/fastlane/scan","forks_url":"https://api.github.com/repos/fastlane/scan/forks","keys_url":"https://api.github.com/repos/fastlane/scan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fastlane/scan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fastlane/scan/teams","hooks_url":"https://api.github.com/repos/fastlane/scan/hooks","issue_events_url":"https://api.github.com/repos/fastlane/scan/issues/events{/number}","events_url":"https://api.github.com/repos/fastlane/scan/events","assignees_url":"https://api.github.com/repos/fastlane/scan/assignees{/user}","branches_url":"https://api.github.com/repos/fastlane/scan/branches{/branch}","tags_url":"https://api.github.com/repos/fastlane/scan/tags","blobs_url":"https://api.github.com/repos/fastlane/scan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fastlane/scan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fastlane/scan/git/refs{/sha}","trees_url":"https://api.github.com/repos/fastlane/scan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fastlane/scan/statuses/{sha}","languages_url":"https://api.github.com/repos/fastlane/scan/languages","stargazers_url":"https://api.github.com/repos/fastlane/scan/stargazers","contributors_url":"https://api.github.com/repos/fastlane/scan/contributors","subscribers_url":"https://api.github.com/repos/fastlane/scan/subscribers","subscription_url":"https://api.github.com/repos/fastlane/scan/subscription","commits_url":"https://api.github.com/repos/fastlane/scan/commits{/sha}","git_commits_url":"https://api.github.com/repos/fastlane/scan/git/commits{/sha}","comments_url":"https://api.github.com/repos/fastlane/scan/comments{/number}","issue_comment_url":"https://api.github.com/repos/fastlane/scan/issues/comments{/number}","contents_url":"https://api.github.com/repos/fastlane/scan/contents/{+path}","compare_url":"https://api.github.com/repos/fastlane/scan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fastlane/scan/merges","archive_url":"https://api.github.com/repos/fastlane/scan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fastlane/scan/downloads","issues_url":"https://api.github.com/repos/fastlane/scan/issues{/number}","pulls_url":"https://api.github.com/repos/fastlane/scan/pulls{/number}","milestones_url":"https://api.github.com/repos/fastlane/scan/milestones{/number}","notifications_url":"https://api.github.com/repos/fastlane/scan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fastlane/scan/labels{/name}","releases_url":"https://api.github.com/repos/fastlane/scan/releases{/id}","deployments_url":"https://api.github.com/repos/fastlane/scan/deployments","created_at":"2015-10-02T00:07:42Z","updated_at":"2016-03-01T04:05:41Z","pushed_at":"2016-03-01T21:30:34Z","git_url":"git://github.com/fastlane/scan.git","ssh_url":"git@github.com:fastlane/scan.git","clone_url":"https://github.com/fastlane/scan.git","svn_url":"https://github.com/fastlane/scan","homepage":"https://fastlane.tools","size":950,"stargazers_count":233,"watchers_count":233,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":23,"forks":34,"open_issues":23,"watchers":233,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fastlane/scan/pulls/61"},"html":{"href":"https://github.com/fastlane/scan/pull/61"},"issue":{"href":"https://api.github.com/repos/fastlane/scan/issues/61"},"comments":{"href":"https://api.github.com/repos/fastlane/scan/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/fastlane/scan/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/fastlane/scan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fastlane/scan/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/fastlane/scan/statuses/1be55bc8e2dea6e34993cae493d3c31375cf1b01"}}}}