{"action":"created","comment":{"url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/pulls/comments/56396162","id":56396162,"diff_hunk":"@@ -49,39 +55,49 @@ def tcpdump_rate(sw):\n     rate = int(total_packets) * 1000 / msec\n     return rate\n \n+\"\"\"\n+Start packet capture using tcpdump.\n+:param enode: Engine node to communicate with.\n+:type enode: topology.platforms.base.BaseNode\n+:param str interface_id: interface name.\n+:param int wait_time: Time in seconds to capture with tcpdump.\n+:param int num_cpu_samples: Number of CPU samples to get CPU utilization.\n+ Default is 0\n+\"\"\"\n \n-def tcpdump_capture_interface(sw, options, interface_id, wait_time, check_cpu):\n-    cmd_output = sw('ip netns exec swns tcpdump -D'.format(**locals()),\n-                    'bash')\n+def tcpdump_capture_interface(enode, options, interface_id, wait_time,","path":"lib/topology_lib_tcpdump/library.py","position":41,"original_position":41,"commit_id":"5cde4f3b5ec92388b55c1bff577d42f360f7ea77","original_commit_id":"5cde4f3b5ec92388b55c1bff577d42f360f7ea77","user":{"login":"vivekramamoorthy","id":13953219,"avatar_url":"https://avatars.githubusercontent.com/u/13953219?v=3","gravatar_id":"","url":"https://api.github.com/users/vivekramamoorthy","html_url":"https://github.com/vivekramamoorthy","followers_url":"https://api.github.com/users/vivekramamoorthy/followers","following_url":"https://api.github.com/users/vivekramamoorthy/following{/other_user}","gists_url":"https://api.github.com/users/vivekramamoorthy/gists{/gist_id}","starred_url":"https://api.github.com/users/vivekramamoorthy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivekramamoorthy/subscriptions","organizations_url":"https://api.github.com/users/vivekramamoorthy/orgs","repos_url":"https://api.github.com/users/vivekramamoorthy/repos","events_url":"https://api.github.com/users/vivekramamoorthy/events{/privacy}","received_events_url":"https://api.github.com/users/vivekramamoorthy/received_events","type":"User","site_admin":false},"body":"We are currently the only consumers of this API. This signature makes it more generic.","created_at":"2016-03-16T19:07:41Z","updated_at":"2016-03-16T19:07:41Z","html_url":"https://github.com/HPENetworking/topology_lib_tcpdump/pull/2#discussion_r56396162","pull_request_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/pulls/comments/56396162"},"html":{"href":"https://github.com/HPENetworking/topology_lib_tcpdump/pull/2#discussion_r56396162"},"pull_request":{"href":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/pulls/2","id":63114751,"html_url":"https://github.com/HPENetworking/topology_lib_tcpdump/pull/2","diff_url":"https://github.com/HPENetworking/topology_lib_tcpdump/pull/2.diff","patch_url":"https://github.com/HPENetworking/topology_lib_tcpdump/pull/2.patch","issue_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/issues/2","number":2,"state":"open","locked":false,"title":"Adding comments/documentation for APIs","user":{"login":"vivekramamoorthy","id":13953219,"avatar_url":"https://avatars.githubusercontent.com/u/13953219?v=3","gravatar_id":"","url":"https://api.github.com/users/vivekramamoorthy","html_url":"https://github.com/vivekramamoorthy","followers_url":"https://api.github.com/users/vivekramamoorthy/followers","following_url":"https://api.github.com/users/vivekramamoorthy/following{/other_user}","gists_url":"https://api.github.com/users/vivekramamoorthy/gists{/gist_id}","starred_url":"https://api.github.com/users/vivekramamoorthy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivekramamoorthy/subscriptions","organizations_url":"https://api.github.com/users/vivekramamoorthy/orgs","repos_url":"https://api.github.com/users/vivekramamoorthy/repos","events_url":"https://api.github.com/users/vivekramamoorthy/events{/privacy}","received_events_url":"https://api.github.com/users/vivekramamoorthy/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-03-16T18:38:55Z","updated_at":"2016-03-16T19:07:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c8dafd4ea6d4134d38c7db213610825e1839112d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/pulls/2/commits","review_comments_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/pulls/2/comments","review_comment_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/issues/2/comments","statuses_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/statuses/5cde4f3b5ec92388b55c1bff577d42f360f7ea77","head":{"label":"vivekramamoorthy:master","ref":"master","sha":"5cde4f3b5ec92388b55c1bff577d42f360f7ea77","user":{"login":"vivekramamoorthy","id":13953219,"avatar_url":"https://avatars.githubusercontent.com/u/13953219?v=3","gravatar_id":"","url":"https://api.github.com/users/vivekramamoorthy","html_url":"https://github.com/vivekramamoorthy","followers_url":"https://api.github.com/users/vivekramamoorthy/followers","following_url":"https://api.github.com/users/vivekramamoorthy/following{/other_user}","gists_url":"https://api.github.com/users/vivekramamoorthy/gists{/gist_id}","starred_url":"https://api.github.com/users/vivekramamoorthy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivekramamoorthy/subscriptions","organizations_url":"https://api.github.com/users/vivekramamoorthy/orgs","repos_url":"https://api.github.com/users/vivekramamoorthy/repos","events_url":"https://api.github.com/users/vivekramamoorthy/events{/privacy}","received_events_url":"https://api.github.com/users/vivekramamoorthy/received_events","type":"User","site_admin":false},"repo":{"id":52913685,"name":"topology_lib_tcpdump","full_name":"vivekramamoorthy/topology_lib_tcpdump","owner":{"login":"vivekramamoorthy","id":13953219,"avatar_url":"https://avatars.githubusercontent.com/u/13953219?v=3","gravatar_id":"","url":"https://api.github.com/users/vivekramamoorthy","html_url":"https://github.com/vivekramamoorthy","followers_url":"https://api.github.com/users/vivekramamoorthy/followers","following_url":"https://api.github.com/users/vivekramamoorthy/following{/other_user}","gists_url":"https://api.github.com/users/vivekramamoorthy/gists{/gist_id}","starred_url":"https://api.github.com/users/vivekramamoorthy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivekramamoorthy/subscriptions","organizations_url":"https://api.github.com/users/vivekramamoorthy/orgs","repos_url":"https://api.github.com/users/vivekramamoorthy/repos","events_url":"https://api.github.com/users/vivekramamoorthy/events{/privacy}","received_events_url":"https://api.github.com/users/vivekramamoorthy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vivekramamoorthy/topology_lib_tcpdump","description":"A Topology Communication Library for tcpdump.","fork":true,"url":"https://api.github.com/repos/vivekramamoorthy/topology_lib_tcpdump","forks_url":"https://api.github.com/repos/vivekramamoorthy/topology_lib_tcpdump/forks","keys_url":"https://api.github.com/repos/vivekramamoorthy/topology_lib_tcpdump/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vivekramamoorthy/topology_lib_tcpdump/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vivekramamoorthy/topology_lib_tcpdump/teams","hooks_url":"https://api.github.com/repos/vivekramamoorthy/topology_lib_tcpdump/hooks","issue_events_url":"https://api.github.com/repos/vivekramamoorthy/topology_lib_tcpdump/issues/events{/number}","events_url":"https://api.github.com/repos/vivekramamoorthy/topology_lib_tcpdump/events","assignees_url":"https://api.github.com/repos/vivekramamoorthy/topology_lib_tcpdump/assignees{/user}","branches_url":"https://api.github.com/repos/vivekramamoorthy/topology_lib_tcpdump/branches{/branch}","tags_url":"https://api.github.com/repos/vivekramamoorthy/topology_lib_tcpdump/tags","blobs_url":"https://api.github.com/repos/vivekramamoorthy/topology_lib_tcpdump/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vivekramamoorthy/topology_lib_tcpdump/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vivekramamoorthy/topology_lib_tcpdump/git/refs{/sha}","trees_url":"https://api.github.com/repos/vivekramamoorthy/topology_lib_tcpdump/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vivekramamoorthy/topology_lib_tcpdump/statuses/{sha}","languages_url":"https://api.github.com/repos/vivekramamoorthy/topology_lib_tcpdump/languages","stargazers_url":"https://api.github.com/repos/vivekramamoorthy/topology_lib_tcpdump/stargazers","contributors_url":"https://api.github.com/repos/vivekramamoorthy/topology_lib_tcpdump/contributors","subscribers_url":"https://api.github.com/repos/vivekramamoorthy/topology_lib_tcpdump/subscribers","subscription_url":"https://api.github.com/repos/vivekramamoorthy/topology_lib_tcpdump/subscription","commits_url":"https://api.github.com/repos/vivekramamoorthy/topology_lib_tcpdump/commits{/sha}","git_commits_url":"https://api.github.com/repos/vivekramamoorthy/topology_lib_tcpdump/git/commits{/sha}","comments_url":"https://api.github.com/repos/vivekramamoorthy/topology_lib_tcpdump/comments{/number}","issue_comment_url":"https://api.github.com/repos/vivekramamoorthy/topology_lib_tcpdump/issues/comments{/number}","contents_url":"https://api.github.com/repos/vivekramamoorthy/topology_lib_tcpdump/contents/{+path}","compare_url":"https://api.github.com/repos/vivekramamoorthy/topology_lib_tcpdump/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vivekramamoorthy/topology_lib_tcpdump/merges","archive_url":"https://api.github.com/repos/vivekramamoorthy/topology_lib_tcpdump/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vivekramamoorthy/topology_lib_tcpdump/downloads","issues_url":"https://api.github.com/repos/vivekramamoorthy/topology_lib_tcpdump/issues{/number}","pulls_url":"https://api.github.com/repos/vivekramamoorthy/topology_lib_tcpdump/pulls{/number}","milestones_url":"https://api.github.com/repos/vivekramamoorthy/topology_lib_tcpdump/milestones{/number}","notifications_url":"https://api.github.com/repos/vivekramamoorthy/topology_lib_tcpdump/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vivekramamoorthy/topology_lib_tcpdump/labels{/name}","releases_url":"https://api.github.com/repos/vivekramamoorthy/topology_lib_tcpdump/releases{/id}","deployments_url":"https://api.github.com/repos/vivekramamoorthy/topology_lib_tcpdump/deployments","created_at":"2016-03-01T22:06:46Z","updated_at":"2016-03-02T06:05:08Z","pushed_at":"2016-03-15T20:47:42Z","git_url":"git://github.com/vivekramamoorthy/topology_lib_tcpdump.git","ssh_url":"git@github.com:vivekramamoorthy/topology_lib_tcpdump.git","clone_url":"https://github.com/vivekramamoorthy/topology_lib_tcpdump.git","svn_url":"https://github.com/vivekramamoorthy/topology_lib_tcpdump","homepage":null,"size":3194,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HPENetworking:master","ref":"master","sha":"073a6ba6b945c2c40ea58c5eb05874141c884ff4","user":{"login":"HPENetworking","id":11503648,"avatar_url":"https://avatars.githubusercontent.com/u/11503648?v=3","gravatar_id":"","url":"https://api.github.com/users/HPENetworking","html_url":"https://github.com/HPENetworking","followers_url":"https://api.github.com/users/HPENetworking/followers","following_url":"https://api.github.com/users/HPENetworking/following{/other_user}","gists_url":"https://api.github.com/users/HPENetworking/gists{/gist_id}","starred_url":"https://api.github.com/users/HPENetworking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HPENetworking/subscriptions","organizations_url":"https://api.github.com/users/HPENetworking/orgs","repos_url":"https://api.github.com/users/HPENetworking/repos","events_url":"https://api.github.com/users/HPENetworking/events{/privacy}","received_events_url":"https://api.github.com/users/HPENetworking/received_events","type":"Organization","site_admin":false},"repo":{"id":52907692,"name":"topology_lib_tcpdump","full_name":"HPENetworking/topology_lib_tcpdump","owner":{"login":"HPENetworking","id":11503648,"avatar_url":"https://avatars.githubusercontent.com/u/11503648?v=3","gravatar_id":"","url":"https://api.github.com/users/HPENetworking","html_url":"https://github.com/HPENetworking","followers_url":"https://api.github.com/users/HPENetworking/followers","following_url":"https://api.github.com/users/HPENetworking/following{/other_user}","gists_url":"https://api.github.com/users/HPENetworking/gists{/gist_id}","starred_url":"https://api.github.com/users/HPENetworking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HPENetworking/subscriptions","organizations_url":"https://api.github.com/users/HPENetworking/orgs","repos_url":"https://api.github.com/users/HPENetworking/repos","events_url":"https://api.github.com/users/HPENetworking/events{/privacy}","received_events_url":"https://api.github.com/users/HPENetworking/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HPENetworking/topology_lib_tcpdump","description":"A Topology Communication Library for tcpdump.","fork":false,"url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump","forks_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/forks","keys_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/teams","hooks_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/hooks","issue_events_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/issues/events{/number}","events_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/events","assignees_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/assignees{/user}","branches_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/branches{/branch}","tags_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/tags","blobs_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/git/refs{/sha}","trees_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/statuses/{sha}","languages_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/languages","stargazers_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/stargazers","contributors_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/contributors","subscribers_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/subscribers","subscription_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/subscription","commits_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/commits{/sha}","git_commits_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/git/commits{/sha}","comments_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/comments{/number}","issue_comment_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/issues/comments{/number}","contents_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/contents/{+path}","compare_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/merges","archive_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/downloads","issues_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/issues{/number}","pulls_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/pulls{/number}","milestones_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/milestones{/number}","notifications_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/labels{/name}","releases_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/releases{/id}","deployments_url":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/deployments","created_at":"2016-03-01T20:31:27Z","updated_at":"2016-03-04T16:18:24Z","pushed_at":"2016-03-16T18:38:56Z","git_url":"git://github.com/HPENetworking/topology_lib_tcpdump.git","ssh_url":"git@github.com:HPENetworking/topology_lib_tcpdump.git","clone_url":"https://github.com/HPENetworking/topology_lib_tcpdump.git","svn_url":"https://github.com/HPENetworking/topology_lib_tcpdump","homepage":null,"size":3194,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/pulls/2"},"html":{"href":"https://github.com/HPENetworking/topology_lib_tcpdump/pull/2"},"issue":{"href":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/issues/2"},"comments":{"href":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/HPENetworking/topology_lib_tcpdump/statuses/5cde4f3b5ec92388b55c1bff577d42f360f7ea77"}}}}