{"action":"created","comment":{"url":"https://api.github.com/repos/apache/brooklyn-server/pulls/comments/64442720","id":64442720,"diff_hunk":"@@ -76,6 +76,10 @@\n     @CatalogConfig(label = \"Stop Command\", priority=1)\n     ConfigKey<String> STOP_COMMAND = VanillaSoftwareProcess.STOP_COMMAND;\n \n+    @CatalogConfig(label = \"Suppress failures occurred during installation. When using this parameter, Apache Brooklyn relies that your blueprint will report failures on the check running phase.\")\n+    ConfigKey<Boolean> SUPPRESS_INSTALL_FAILURE = ConfigKeys.newBooleanConfigKey(\"install.windows.suppressFailure\", \"Suppress any installation failure. It is a common case to restart windows together with the installation process.\" +\n+            \" In such case, it's hard to tell when the install command finished and entered into restart and you may want to support connectivity or other failures.\", false);","path":"software/base/src/main/java/org/apache/brooklyn/entity/software/base/VanillaWindowsProcess.java","position":6,"original_position":6,"commit_id":"11b8c815ffcc723790146dd38235d556617b74ad","original_commit_id":"11b8c815ffcc723790146dd38235d556617b74ad","user":{"login":"aledsage","id":593113,"avatar_url":"https://avatars.githubusercontent.com/u/593113?v=3","gravatar_id":"","url":"https://api.github.com/users/aledsage","html_url":"https://github.com/aledsage","followers_url":"https://api.github.com/users/aledsage/followers","following_url":"https://api.github.com/users/aledsage/following{/other_user}","gists_url":"https://api.github.com/users/aledsage/gists{/gist_id}","starred_url":"https://api.github.com/users/aledsage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledsage/subscriptions","organizations_url":"https://api.github.com/users/aledsage/orgs","repos_url":"https://api.github.com/users/aledsage/repos","events_url":"https://api.github.com/users/aledsage/events{/privacy}","received_events_url":"https://api.github.com/users/aledsage/received_events","type":"User","site_admin":false},"body":"Put the `, false` on a new line. Otherwise someone reading through the code will miss it (unless they scroll).","created_at":"2016-05-24T17:57:31Z","updated_at":"2016-05-24T17:57:31Z","html_url":"https://github.com/apache/brooklyn-server/pull/150#discussion_r64442720","pull_request_url":"https://api.github.com/repos/apache/brooklyn-server/pulls/150","_links":{"self":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/comments/64442720"},"html":{"href":"https://github.com/apache/brooklyn-server/pull/150#discussion_r64442720"},"pull_request":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/150"}}},"pull_request":{"url":"https://api.github.com/repos/apache/brooklyn-server/pulls/150","id":70922448,"html_url":"https://github.com/apache/brooklyn-server/pull/150","diff_url":"https://github.com/apache/brooklyn-server/pull/150.diff","patch_url":"https://github.com/apache/brooklyn-server/pull/150.patch","issue_url":"https://api.github.com/repos/apache/brooklyn-server/issues/150","number":150,"state":"open","locked":false,"title":"Ability to suppress install command failures on Windows","user":{"login":"bostko","id":1595054,"avatar_url":"https://avatars.githubusercontent.com/u/1595054?v=3","gravatar_id":"","url":"https://api.github.com/users/bostko","html_url":"https://github.com/bostko","followers_url":"https://api.github.com/users/bostko/followers","following_url":"https://api.github.com/users/bostko/following{/other_user}","gists_url":"https://api.github.com/users/bostko/gists{/gist_id}","starred_url":"https://api.github.com/users/bostko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bostko/subscriptions","organizations_url":"https://api.github.com/users/bostko/orgs","repos_url":"https://api.github.com/users/bostko/repos","events_url":"https://api.github.com/users/bostko/events{/privacy}","received_events_url":"https://api.github.com/users/bostko/received_events","type":"User","site_admin":false},"body":"- Configuration parameter for suppressing any installation failure.\r\n- set small and reasonable default value for connection retries of winrm4j client\r\n- make launch command non-obligatory for windows applications","created_at":"2016-05-20T21:53:54Z","updated_at":"2016-05-24T17:57:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5071b2149c90bbead2a5587b75039f76d90e17da","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/brooklyn-server/pulls/150/commits","review_comments_url":"https://api.github.com/repos/apache/brooklyn-server/pulls/150/comments","review_comment_url":"https://api.github.com/repos/apache/brooklyn-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/brooklyn-server/issues/150/comments","statuses_url":"https://api.github.com/repos/apache/brooklyn-server/statuses/11b8c815ffcc723790146dd38235d556617b74ad","head":{"label":"bostko:windows_is_running","ref":"windows_is_running","sha":"11b8c815ffcc723790146dd38235d556617b74ad","user":{"login":"bostko","id":1595054,"avatar_url":"https://avatars.githubusercontent.com/u/1595054?v=3","gravatar_id":"","url":"https://api.github.com/users/bostko","html_url":"https://github.com/bostko","followers_url":"https://api.github.com/users/bostko/followers","following_url":"https://api.github.com/users/bostko/following{/other_user}","gists_url":"https://api.github.com/users/bostko/gists{/gist_id}","starred_url":"https://api.github.com/users/bostko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bostko/subscriptions","organizations_url":"https://api.github.com/users/bostko/orgs","repos_url":"https://api.github.com/users/bostko/repos","events_url":"https://api.github.com/users/bostko/events{/privacy}","received_events_url":"https://api.github.com/users/bostko/received_events","type":"User","site_admin":false},"repo":{"id":50875100,"name":"brooklyn-server","full_name":"bostko/brooklyn-server","owner":{"login":"bostko","id":1595054,"avatar_url":"https://avatars.githubusercontent.com/u/1595054?v=3","gravatar_id":"","url":"https://api.github.com/users/bostko","html_url":"https://github.com/bostko","followers_url":"https://api.github.com/users/bostko/followers","following_url":"https://api.github.com/users/bostko/following{/other_user}","gists_url":"https://api.github.com/users/bostko/gists{/gist_id}","starred_url":"https://api.github.com/users/bostko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bostko/subscriptions","organizations_url":"https://api.github.com/users/bostko/orgs","repos_url":"https://api.github.com/users/bostko/repos","events_url":"https://api.github.com/users/bostko/events{/privacy}","received_events_url":"https://api.github.com/users/bostko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bostko/brooklyn-server","description":"Mirror of Apache Brooklyn server","fork":true,"url":"https://api.github.com/repos/bostko/brooklyn-server","forks_url":"https://api.github.com/repos/bostko/brooklyn-server/forks","keys_url":"https://api.github.com/repos/bostko/brooklyn-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bostko/brooklyn-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bostko/brooklyn-server/teams","hooks_url":"https://api.github.com/repos/bostko/brooklyn-server/hooks","issue_events_url":"https://api.github.com/repos/bostko/brooklyn-server/issues/events{/number}","events_url":"https://api.github.com/repos/bostko/brooklyn-server/events","assignees_url":"https://api.github.com/repos/bostko/brooklyn-server/assignees{/user}","branches_url":"https://api.github.com/repos/bostko/brooklyn-server/branches{/branch}","tags_url":"https://api.github.com/repos/bostko/brooklyn-server/tags","blobs_url":"https://api.github.com/repos/bostko/brooklyn-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bostko/brooklyn-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bostko/brooklyn-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/bostko/brooklyn-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bostko/brooklyn-server/statuses/{sha}","languages_url":"https://api.github.com/repos/bostko/brooklyn-server/languages","stargazers_url":"https://api.github.com/repos/bostko/brooklyn-server/stargazers","contributors_url":"https://api.github.com/repos/bostko/brooklyn-server/contributors","subscribers_url":"https://api.github.com/repos/bostko/brooklyn-server/subscribers","subscription_url":"https://api.github.com/repos/bostko/brooklyn-server/subscription","commits_url":"https://api.github.com/repos/bostko/brooklyn-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/bostko/brooklyn-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/bostko/brooklyn-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/bostko/brooklyn-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/bostko/brooklyn-server/contents/{+path}","compare_url":"https://api.github.com/repos/bostko/brooklyn-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bostko/brooklyn-server/merges","archive_url":"https://api.github.com/repos/bostko/brooklyn-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bostko/brooklyn-server/downloads","issues_url":"https://api.github.com/repos/bostko/brooklyn-server/issues{/number}","pulls_url":"https://api.github.com/repos/bostko/brooklyn-server/pulls{/number}","milestones_url":"https://api.github.com/repos/bostko/brooklyn-server/milestones{/number}","notifications_url":"https://api.github.com/repos/bostko/brooklyn-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bostko/brooklyn-server/labels{/name}","releases_url":"https://api.github.com/repos/bostko/brooklyn-server/releases{/id}","deployments_url":"https://api.github.com/repos/bostko/brooklyn-server/deployments","created_at":"2016-02-01T22:10:47Z","updated_at":"2016-02-01T22:10:59Z","pushed_at":"2016-05-24T16:58:58Z","git_url":"git://github.com/bostko/brooklyn-server.git","ssh_url":"git@github.com:bostko/brooklyn-server.git","clone_url":"https://github.com/bostko/brooklyn-server.git","svn_url":"https://github.com/bostko/brooklyn-server","homepage":null,"size":29454,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"a42d519a02c5f732326322b829d261bc851c433d","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":47246081,"name":"brooklyn-server","full_name":"apache/brooklyn-server","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/brooklyn-server","description":"Mirror of Apache Brooklyn server","fork":false,"url":"https://api.github.com/repos/apache/brooklyn-server","forks_url":"https://api.github.com/repos/apache/brooklyn-server/forks","keys_url":"https://api.github.com/repos/apache/brooklyn-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/brooklyn-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/brooklyn-server/teams","hooks_url":"https://api.github.com/repos/apache/brooklyn-server/hooks","issue_events_url":"https://api.github.com/repos/apache/brooklyn-server/issues/events{/number}","events_url":"https://api.github.com/repos/apache/brooklyn-server/events","assignees_url":"https://api.github.com/repos/apache/brooklyn-server/assignees{/user}","branches_url":"https://api.github.com/repos/apache/brooklyn-server/branches{/branch}","tags_url":"https://api.github.com/repos/apache/brooklyn-server/tags","blobs_url":"https://api.github.com/repos/apache/brooklyn-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/brooklyn-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/brooklyn-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/brooklyn-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/brooklyn-server/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/brooklyn-server/languages","stargazers_url":"https://api.github.com/repos/apache/brooklyn-server/stargazers","contributors_url":"https://api.github.com/repos/apache/brooklyn-server/contributors","subscribers_url":"https://api.github.com/repos/apache/brooklyn-server/subscribers","subscription_url":"https://api.github.com/repos/apache/brooklyn-server/subscription","commits_url":"https://api.github.com/repos/apache/brooklyn-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/brooklyn-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/brooklyn-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/brooklyn-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/brooklyn-server/contents/{+path}","compare_url":"https://api.github.com/repos/apache/brooklyn-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/brooklyn-server/merges","archive_url":"https://api.github.com/repos/apache/brooklyn-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/brooklyn-server/downloads","issues_url":"https://api.github.com/repos/apache/brooklyn-server/issues{/number}","pulls_url":"https://api.github.com/repos/apache/brooklyn-server/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/brooklyn-server/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/brooklyn-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/brooklyn-server/labels{/name}","releases_url":"https://api.github.com/repos/apache/brooklyn-server/releases{/id}","deployments_url":"https://api.github.com/repos/apache/brooklyn-server/deployments","created_at":"2015-12-02T08:00:06Z","updated_at":"2016-04-20T09:40:31Z","pushed_at":"2016-05-24T17:29:09Z","git_url":"git://github.com/apache/brooklyn-server.git","ssh_url":"git@github.com:apache/brooklyn-server.git","clone_url":"https://github.com/apache/brooklyn-server.git","svn_url":"https://github.com/apache/brooklyn-server","homepage":null,"size":29698,"stargazers_count":10,"watchers_count":10,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":32,"mirror_url":"git://git.apache.org/brooklyn-server.git","open_issues_count":18,"forks":32,"open_issues":18,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/150"},"html":{"href":"https://github.com/apache/brooklyn-server/pull/150"},"issue":{"href":"https://api.github.com/repos/apache/brooklyn-server/issues/150"},"comments":{"href":"https://api.github.com/repos/apache/brooklyn-server/issues/150/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/150/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/150/commits"},"statuses":{"href":"https://api.github.com/repos/apache/brooklyn-server/statuses/11b8c815ffcc723790146dd38235d556617b74ad"}}}}
{"actor":{"display_login":"aledsage"}}