{"action":"created","issue":{"url":"https://api.github.com/repos/bbc/sqs-consumer/issues/49","repository_url":"https://api.github.com/repos/bbc/sqs-consumer","labels_url":"https://api.github.com/repos/bbc/sqs-consumer/issues/49/labels{/name}","comments_url":"https://api.github.com/repos/bbc/sqs-consumer/issues/49/comments","events_url":"https://api.github.com/repos/bbc/sqs-consumer/issues/49/events","html_url":"https://github.com/bbc/sqs-consumer/pull/49","id":171855053,"number":49,"title":"Add empty queue event","user":{"login":"jacanotrigueros","id":6655364,"avatar_url":"https://avatars.githubusercontent.com/u/6655364?v=3","gravatar_id":"","url":"https://api.github.com/users/jacanotrigueros","html_url":"https://github.com/jacanotrigueros","followers_url":"https://api.github.com/users/jacanotrigueros/followers","following_url":"https://api.github.com/users/jacanotrigueros/following{/other_user}","gists_url":"https://api.github.com/users/jacanotrigueros/gists{/gist_id}","starred_url":"https://api.github.com/users/jacanotrigueros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacanotrigueros/subscriptions","organizations_url":"https://api.github.com/users/jacanotrigueros/orgs","repos_url":"https://api.github.com/users/jacanotrigueros/repos","events_url":"https://api.github.com/users/jacanotrigueros/events{/privacy}","received_events_url":"https://api.github.com/users/jacanotrigueros/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"robinjmurphy","id":917111,"avatar_url":"https://avatars.githubusercontent.com/u/917111?v=3","gravatar_id":"","url":"https://api.github.com/users/robinjmurphy","html_url":"https://github.com/robinjmurphy","followers_url":"https://api.github.com/users/robinjmurphy/followers","following_url":"https://api.github.com/users/robinjmurphy/following{/other_user}","gists_url":"https://api.github.com/users/robinjmurphy/gists{/gist_id}","starred_url":"https://api.github.com/users/robinjmurphy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robinjmurphy/subscriptions","organizations_url":"https://api.github.com/users/robinjmurphy/orgs","repos_url":"https://api.github.com/users/robinjmurphy/repos","events_url":"https://api.github.com/users/robinjmurphy/events{/privacy}","received_events_url":"https://api.github.com/users/robinjmurphy/received_events","type":"User","site_admin":false},"assignees":[{"login":"robinjmurphy","id":917111,"avatar_url":"https://avatars.githubusercontent.com/u/917111?v=3","gravatar_id":"","url":"https://api.github.com/users/robinjmurphy","html_url":"https://github.com/robinjmurphy","followers_url":"https://api.github.com/users/robinjmurphy/followers","following_url":"https://api.github.com/users/robinjmurphy/following{/other_user}","gists_url":"https://api.github.com/users/robinjmurphy/gists{/gist_id}","starred_url":"https://api.github.com/users/robinjmurphy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robinjmurphy/subscriptions","organizations_url":"https://api.github.com/users/robinjmurphy/orgs","repos_url":"https://api.github.com/users/robinjmurphy/repos","events_url":"https://api.github.com/users/robinjmurphy/events{/privacy}","received_events_url":"https://api.github.com/users/robinjmurphy/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2016-08-18T09:18:25Z","updated_at":"2016-08-22T07:41:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bbc/sqs-consumer/pulls/49","html_url":"https://github.com/bbc/sqs-consumer/pull/49","diff_url":"https://github.com/bbc/sqs-consumer/pull/49.diff","patch_url":"https://github.com/bbc/sqs-consumer/pull/49.patch"},"body":"Add empty queue event. When all messages have been consumed emit 'emptyQueue' and continues with the poll (you know when you can stop sqs consumer).\r\n\r\nInclude:\r\n- Updated tests\r\n- Updated documentation\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/bbc/sqs-consumer/issues/comments/241336187","html_url":"https://github.com/bbc/sqs-consumer/pull/49#issuecomment-241336187","issue_url":"https://api.github.com/repos/bbc/sqs-consumer/issues/49","id":241336187,"user":{"login":"robinjmurphy","id":917111,"avatar_url":"https://avatars.githubusercontent.com/u/917111?v=3","gravatar_id":"","url":"https://api.github.com/users/robinjmurphy","html_url":"https://github.com/robinjmurphy","followers_url":"https://api.github.com/users/robinjmurphy/followers","following_url":"https://api.github.com/users/robinjmurphy/following{/other_user}","gists_url":"https://api.github.com/users/robinjmurphy/gists{/gist_id}","starred_url":"https://api.github.com/users/robinjmurphy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robinjmurphy/subscriptions","organizations_url":"https://api.github.com/users/robinjmurphy/orgs","repos_url":"https://api.github.com/users/robinjmurphy/repos","events_url":"https://api.github.com/users/robinjmurphy/events{/privacy}","received_events_url":"https://api.github.com/users/robinjmurphy/received_events","type":"User","site_admin":false},"created_at":"2016-08-22T07:41:45Z","updated_at":"2016-08-22T07:41:45Z","body":"Thanks for the example.\r\n\r\nI think we should be able to get this in. There are a few things that I think we could change though:\r\n\r\n* The event doesn't need to be optional - people are free to ignore it if it's not useful to them. Let's _always_ fire it when the consumer receives an empty response\r\n* Let's change the event name to `empty` as it's simpler\r\n* I don't quite see why we need the `this.queueIsNotEmpty` property - I think we can just send the event in that `else` block - but maybe I've missed something?"}}
{"actor":{"display_login":"robinjmurphy"}}