{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/53056044","id":53056044,"diff_hunk":"@@ -0,0 +1,79 @@\n+/*\n+Copyright 2016 The Kubernetes Authors All rights reserved.\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+    http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package kubectl\n+\n+import (\n+\t\"fmt\"\n+\n+\t\"k8s.io/kubernetes/pkg/api\"\n+\t\"k8s.io/kubernetes/pkg/runtime\"\n+)\n+\n+// ServiceAccountGeneratorV1 supports stable generation of a service account\n+type ServiceAccountGeneratorV1 struct {\n+\t// Name of service account\n+\tName string\n+}\n+\n+// Ensure it supports the generator pattern that uses parameter injection\n+var _ Generator = &ServiceAccountGeneratorV1{}","path":"pkg/kubectl/serviceaccount.go","position":33,"original_position":33,"commit_id":"db77a67f40714844454619fb4a6a207206222053","original_commit_id":"db77a67f40714844454619fb4a6a207206222053","user":{"login":"deads2k","id":8225098,"avatar_url":"https://avatars.githubusercontent.com/u/8225098?v=3","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"body":"> @deads2k since you rebased the first structured generators in Origin, did you have any problem with them?\r\n\r\nI haven't seen any problems from them, though I will say that this adds a tremendous amount of boilerplate and indirection versus our `oc create` subcommands that directly create the object they need.","created_at":"2016-02-16T18:37:58Z","updated_at":"2016-02-16T18:37:58Z","html_url":"https://github.com/kubernetes/kubernetes/pull/21265#discussion_r53056044","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/21265","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/53056044"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/21265#discussion_r53056044"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/21265"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/21265","id":59379312,"html_url":"https://github.com/kubernetes/kubernetes/pull/21265","diff_url":"https://github.com/kubernetes/kubernetes/pull/21265.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/21265.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/21265","number":21265,"state":"open","locked":false,"title":"added 'kubectl create sa' to create serviceaccounts","user":{"login":"stevekuznetsov","id":7328370,"avatar_url":"https://avatars.githubusercontent.com/u/7328370?v=3","gravatar_id":"","url":"https://api.github.com/users/stevekuznetsov","html_url":"https://github.com/stevekuznetsov","followers_url":"https://api.github.com/users/stevekuznetsov/followers","following_url":"https://api.github.com/users/stevekuznetsov/following{/other_user}","gists_url":"https://api.github.com/users/stevekuznetsov/gists{/gist_id}","starred_url":"https://api.github.com/users/stevekuznetsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevekuznetsov/subscriptions","organizations_url":"https://api.github.com/users/stevekuznetsov/orgs","repos_url":"https://api.github.com/users/stevekuznetsov/repos","events_url":"https://api.github.com/users/stevekuznetsov/events{/privacy}","received_events_url":"https://api.github.com/users/stevekuznetsov/received_events","type":"User","site_admin":false},"body":"Added a new sub-command to `kubectl create` in order to create a service account with a given name.\r\n\r\n@deads2k PTAL","created_at":"2016-02-15T15:39:04Z","updated_at":"2016-02-16T18:37:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de622e11aebb356507d20735131200174c6ba04b","assignee":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/21265/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/21265/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/21265/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/db77a67f40714844454619fb4a6a207206222053","head":{"label":"stevekuznetsov:skuznets/new-sa","ref":"skuznets/new-sa","sha":"db77a67f40714844454619fb4a6a207206222053","user":{"login":"stevekuznetsov","id":7328370,"avatar_url":"https://avatars.githubusercontent.com/u/7328370?v=3","gravatar_id":"","url":"https://api.github.com/users/stevekuznetsov","html_url":"https://github.com/stevekuznetsov","followers_url":"https://api.github.com/users/stevekuznetsov/followers","following_url":"https://api.github.com/users/stevekuznetsov/following{/other_user}","gists_url":"https://api.github.com/users/stevekuznetsov/gists{/gist_id}","starred_url":"https://api.github.com/users/stevekuznetsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevekuznetsov/subscriptions","organizations_url":"https://api.github.com/users/stevekuznetsov/orgs","repos_url":"https://api.github.com/users/stevekuznetsov/repos","events_url":"https://api.github.com/users/stevekuznetsov/events{/privacy}","received_events_url":"https://api.github.com/users/stevekuznetsov/received_events","type":"User","site_admin":false},"repo":{"id":36075890,"name":"kubernetes","full_name":"stevekuznetsov/kubernetes","owner":{"login":"stevekuznetsov","id":7328370,"avatar_url":"https://avatars.githubusercontent.com/u/7328370?v=3","gravatar_id":"","url":"https://api.github.com/users/stevekuznetsov","html_url":"https://github.com/stevekuznetsov","followers_url":"https://api.github.com/users/stevekuznetsov/followers","following_url":"https://api.github.com/users/stevekuznetsov/following{/other_user}","gists_url":"https://api.github.com/users/stevekuznetsov/gists{/gist_id}","starred_url":"https://api.github.com/users/stevekuznetsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevekuznetsov/subscriptions","organizations_url":"https://api.github.com/users/stevekuznetsov/orgs","repos_url":"https://api.github.com/users/stevekuznetsov/repos","events_url":"https://api.github.com/users/stevekuznetsov/events{/privacy}","received_events_url":"https://api.github.com/users/stevekuznetsov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stevekuznetsov/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/stevekuznetsov/kubernetes","forks_url":"https://api.github.com/repos/stevekuznetsov/kubernetes/forks","keys_url":"https://api.github.com/repos/stevekuznetsov/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stevekuznetsov/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stevekuznetsov/kubernetes/teams","hooks_url":"https://api.github.com/repos/stevekuznetsov/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/stevekuznetsov/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/stevekuznetsov/kubernetes/events","assignees_url":"https://api.github.com/repos/stevekuznetsov/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/stevekuznetsov/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/stevekuznetsov/kubernetes/tags","blobs_url":"https://api.github.com/repos/stevekuznetsov/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stevekuznetsov/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stevekuznetsov/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/stevekuznetsov/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stevekuznetsov/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/stevekuznetsov/kubernetes/languages","stargazers_url":"https://api.github.com/repos/stevekuznetsov/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/stevekuznetsov/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/stevekuznetsov/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/stevekuznetsov/kubernetes/subscription","commits_url":"https://api.github.com/repos/stevekuznetsov/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/stevekuznetsov/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/stevekuznetsov/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/stevekuznetsov/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/stevekuznetsov/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/stevekuznetsov/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stevekuznetsov/kubernetes/merges","archive_url":"https://api.github.com/repos/stevekuznetsov/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stevekuznetsov/kubernetes/downloads","issues_url":"https://api.github.com/repos/stevekuznetsov/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/stevekuznetsov/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/stevekuznetsov/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/stevekuznetsov/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stevekuznetsov/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/stevekuznetsov/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/stevekuznetsov/kubernetes/deployments","created_at":"2015-05-22T14:14:55Z","updated_at":"2016-01-23T14:08:05Z","pushed_at":"2016-02-15T19:05:45Z","git_url":"git://github.com/stevekuznetsov/kubernetes.git","ssh_url":"git@github.com:stevekuznetsov/kubernetes.git","clone_url":"https://github.com/stevekuznetsov/kubernetes.git","svn_url":"https://github.com/stevekuznetsov/kubernetes","homepage":"http://kubernetes.io","size":164182,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"134d44cf2bcc441dd19833fde56015edec69d02b","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-02-16T18:32:52Z","pushed_at":"2016-02-16T18:37:44Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":326775,"stargazers_count":12714,"watchers_count":12714,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3621,"mirror_url":null,"open_issues_count":2850,"forks":3621,"open_issues":2850,"watchers":12714,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/21265"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/21265"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/21265"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/21265/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/21265/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/21265/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/db77a67f40714844454619fb4a6a207206222053"}}}}