{"action":"created","comment":{"url":"https://api.github.com/repos/rapid7/nexpose-client/pulls/comments/65244372","id":65244372,"diff_hunk":"@@ -44,22 +44,10 @@ def system_information\n     end\n \n     # Obtain the version information for each scan engine.\n-    # Includes Product, Content, and Java versions.\n+    # Includes dates and ids for Product and Content versions.\n     #\n     def engine_versions\n-      info = console_command('version engines')\n-      versions = []\n-      engines = info.sub('VERSION INFORMATION\\n', '').split(/\\n\\n/)\n-      engines.each do |eng|\n-        engdata = {}\n-        eng.split(/\\n/).each do |kv|\n-          key, value = kv.split(/:\\s*/)\n-          key = key.sub('Local Engine  ', '').sub('Remote Engine ', '')\n-          engdata[key] = value\n-        end\n-        versions << engdata\n-      end\n-      versions\n+      JSON.parse(AJAX.post(self, \"/data/engines\"))['records']","path":"lib/nexpose/manage.rb","position":21,"original_position":21,"commit_id":"b73cfa51d92976535d6bf5b77b5e8d786b33da7d","original_commit_id":"b73cfa51d92976535d6bf5b77b5e8d786b33da7d","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Prefer single-quoted strings when you don't need string interpolation or special symbols.","created_at":"2016-05-31T19:08:54Z","updated_at":"2016-05-31T19:08:54Z","html_url":"https://github.com/rapid7/nexpose-client/pull/231#discussion_r65244372","pull_request_url":"https://api.github.com/repos/rapid7/nexpose-client/pulls/231","_links":{"self":{"href":"https://api.github.com/repos/rapid7/nexpose-client/pulls/comments/65244372"},"html":{"href":"https://github.com/rapid7/nexpose-client/pull/231#discussion_r65244372"},"pull_request":{"href":"https://api.github.com/repos/rapid7/nexpose-client/pulls/231"}}},"pull_request":{"url":"https://api.github.com/repos/rapid7/nexpose-client/pulls/231","id":72069205,"html_url":"https://github.com/rapid7/nexpose-client/pull/231","diff_url":"https://github.com/rapid7/nexpose-client/pull/231.diff","patch_url":"https://github.com/rapid7/nexpose-client/pull/231.patch","issue_url":"https://api.github.com/repos/rapid7/nexpose-client/issues/231","number":231,"state":"open","locked":false,"title":"Use a different method for getting engine versions","user":{"login":"Red5d","id":1693880,"avatar_url":"https://avatars.githubusercontent.com/u/1693880?v=3","gravatar_id":"","url":"https://api.github.com/users/Red5d","html_url":"https://github.com/Red5d","followers_url":"https://api.github.com/users/Red5d/followers","following_url":"https://api.github.com/users/Red5d/following{/other_user}","gists_url":"https://api.github.com/users/Red5d/gists{/gist_id}","starred_url":"https://api.github.com/users/Red5d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Red5d/subscriptions","organizations_url":"https://api.github.com/users/Red5d/orgs","repos_url":"https://api.github.com/users/Red5d/repos","events_url":"https://api.github.com/users/Red5d/events{/privacy}","received_events_url":"https://api.github.com/users/Red5d/received_events","type":"User","site_admin":false},"body":"The previous method of parsing the output of the \"version engines\" console command doesn't always work. The console command sometimes doesn't return data. This AJAX post method is what the web UI uses to get the engine data. It returns an array of engine data hash objects.","created_at":"2016-05-31T19:08:51Z","updated_at":"2016-05-31T19:08:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e3bf8c81737def9f54a885ee510d7cec0fb55ce","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rapid7/nexpose-client/pulls/231/commits","review_comments_url":"https://api.github.com/repos/rapid7/nexpose-client/pulls/231/comments","review_comment_url":"https://api.github.com/repos/rapid7/nexpose-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rapid7/nexpose-client/issues/231/comments","statuses_url":"https://api.github.com/repos/rapid7/nexpose-client/statuses/b73cfa51d92976535d6bf5b77b5e8d786b33da7d","head":{"label":"Red5d:patch-2","ref":"patch-2","sha":"b73cfa51d92976535d6bf5b77b5e8d786b33da7d","user":{"login":"Red5d","id":1693880,"avatar_url":"https://avatars.githubusercontent.com/u/1693880?v=3","gravatar_id":"","url":"https://api.github.com/users/Red5d","html_url":"https://github.com/Red5d","followers_url":"https://api.github.com/users/Red5d/followers","following_url":"https://api.github.com/users/Red5d/following{/other_user}","gists_url":"https://api.github.com/users/Red5d/gists{/gist_id}","starred_url":"https://api.github.com/users/Red5d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Red5d/subscriptions","organizations_url":"https://api.github.com/users/Red5d/orgs","repos_url":"https://api.github.com/users/Red5d/repos","events_url":"https://api.github.com/users/Red5d/events{/privacy}","received_events_url":"https://api.github.com/users/Red5d/received_events","type":"User","site_admin":false},"repo":{"id":55170618,"name":"nexpose-client","full_name":"Red5d/nexpose-client","owner":{"login":"Red5d","id":1693880,"avatar_url":"https://avatars.githubusercontent.com/u/1693880?v=3","gravatar_id":"","url":"https://api.github.com/users/Red5d","html_url":"https://github.com/Red5d","followers_url":"https://api.github.com/users/Red5d/followers","following_url":"https://api.github.com/users/Red5d/following{/other_user}","gists_url":"https://api.github.com/users/Red5d/gists{/gist_id}","starred_url":"https://api.github.com/users/Red5d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Red5d/subscriptions","organizations_url":"https://api.github.com/users/Red5d/orgs","repos_url":"https://api.github.com/users/Red5d/repos","events_url":"https://api.github.com/users/Red5d/events{/privacy}","received_events_url":"https://api.github.com/users/Red5d/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Red5d/nexpose-client","description":"Rapid7 Nexpose API client library written in Ruby","fork":true,"url":"https://api.github.com/repos/Red5d/nexpose-client","forks_url":"https://api.github.com/repos/Red5d/nexpose-client/forks","keys_url":"https://api.github.com/repos/Red5d/nexpose-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Red5d/nexpose-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Red5d/nexpose-client/teams","hooks_url":"https://api.github.com/repos/Red5d/nexpose-client/hooks","issue_events_url":"https://api.github.com/repos/Red5d/nexpose-client/issues/events{/number}","events_url":"https://api.github.com/repos/Red5d/nexpose-client/events","assignees_url":"https://api.github.com/repos/Red5d/nexpose-client/assignees{/user}","branches_url":"https://api.github.com/repos/Red5d/nexpose-client/branches{/branch}","tags_url":"https://api.github.com/repos/Red5d/nexpose-client/tags","blobs_url":"https://api.github.com/repos/Red5d/nexpose-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Red5d/nexpose-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Red5d/nexpose-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/Red5d/nexpose-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Red5d/nexpose-client/statuses/{sha}","languages_url":"https://api.github.com/repos/Red5d/nexpose-client/languages","stargazers_url":"https://api.github.com/repos/Red5d/nexpose-client/stargazers","contributors_url":"https://api.github.com/repos/Red5d/nexpose-client/contributors","subscribers_url":"https://api.github.com/repos/Red5d/nexpose-client/subscribers","subscription_url":"https://api.github.com/repos/Red5d/nexpose-client/subscription","commits_url":"https://api.github.com/repos/Red5d/nexpose-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/Red5d/nexpose-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/Red5d/nexpose-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/Red5d/nexpose-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/Red5d/nexpose-client/contents/{+path}","compare_url":"https://api.github.com/repos/Red5d/nexpose-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Red5d/nexpose-client/merges","archive_url":"https://api.github.com/repos/Red5d/nexpose-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Red5d/nexpose-client/downloads","issues_url":"https://api.github.com/repos/Red5d/nexpose-client/issues{/number}","pulls_url":"https://api.github.com/repos/Red5d/nexpose-client/pulls{/number}","milestones_url":"https://api.github.com/repos/Red5d/nexpose-client/milestones{/number}","notifications_url":"https://api.github.com/repos/Red5d/nexpose-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Red5d/nexpose-client/labels{/name}","releases_url":"https://api.github.com/repos/Red5d/nexpose-client/releases{/id}","deployments_url":"https://api.github.com/repos/Red5d/nexpose-client/deployments","created_at":"2016-03-31T17:39:32Z","updated_at":"2016-03-31T17:39:33Z","pushed_at":"2016-05-31T19:08:18Z","git_url":"git://github.com/Red5d/nexpose-client.git","ssh_url":"git@github.com:Red5d/nexpose-client.git","clone_url":"https://github.com/Red5d/nexpose-client.git","svn_url":"https://github.com/Red5d/nexpose-client","homepage":"http://www.rapid7.com/","size":1132,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rapid7:master","ref":"master","sha":"29e460d9dbcc6a81c2b107c3abd771f290b03616","user":{"login":"rapid7","id":1013671,"avatar_url":"https://avatars.githubusercontent.com/u/1013671?v=3","gravatar_id":"","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"repo":{"id":2622467,"name":"nexpose-client","full_name":"rapid7/nexpose-client","owner":{"login":"rapid7","id":1013671,"avatar_url":"https://avatars.githubusercontent.com/u/1013671?v=3","gravatar_id":"","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rapid7/nexpose-client","description":"Rapid7 Nexpose API client library written in Ruby","fork":false,"url":"https://api.github.com/repos/rapid7/nexpose-client","forks_url":"https://api.github.com/repos/rapid7/nexpose-client/forks","keys_url":"https://api.github.com/repos/rapid7/nexpose-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rapid7/nexpose-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rapid7/nexpose-client/teams","hooks_url":"https://api.github.com/repos/rapid7/nexpose-client/hooks","issue_events_url":"https://api.github.com/repos/rapid7/nexpose-client/issues/events{/number}","events_url":"https://api.github.com/repos/rapid7/nexpose-client/events","assignees_url":"https://api.github.com/repos/rapid7/nexpose-client/assignees{/user}","branches_url":"https://api.github.com/repos/rapid7/nexpose-client/branches{/branch}","tags_url":"https://api.github.com/repos/rapid7/nexpose-client/tags","blobs_url":"https://api.github.com/repos/rapid7/nexpose-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rapid7/nexpose-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rapid7/nexpose-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/rapid7/nexpose-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rapid7/nexpose-client/statuses/{sha}","languages_url":"https://api.github.com/repos/rapid7/nexpose-client/languages","stargazers_url":"https://api.github.com/repos/rapid7/nexpose-client/stargazers","contributors_url":"https://api.github.com/repos/rapid7/nexpose-client/contributors","subscribers_url":"https://api.github.com/repos/rapid7/nexpose-client/subscribers","subscription_url":"https://api.github.com/repos/rapid7/nexpose-client/subscription","commits_url":"https://api.github.com/repos/rapid7/nexpose-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/rapid7/nexpose-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/rapid7/nexpose-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/rapid7/nexpose-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/rapid7/nexpose-client/contents/{+path}","compare_url":"https://api.github.com/repos/rapid7/nexpose-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rapid7/nexpose-client/merges","archive_url":"https://api.github.com/repos/rapid7/nexpose-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rapid7/nexpose-client/downloads","issues_url":"https://api.github.com/repos/rapid7/nexpose-client/issues{/number}","pulls_url":"https://api.github.com/repos/rapid7/nexpose-client/pulls{/number}","milestones_url":"https://api.github.com/repos/rapid7/nexpose-client/milestones{/number}","notifications_url":"https://api.github.com/repos/rapid7/nexpose-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rapid7/nexpose-client/labels{/name}","releases_url":"https://api.github.com/repos/rapid7/nexpose-client/releases{/id}","deployments_url":"https://api.github.com/repos/rapid7/nexpose-client/deployments","created_at":"2011-10-21T19:04:49Z","updated_at":"2016-05-12T07:23:46Z","pushed_at":"2016-05-31T19:08:51Z","git_url":"git://github.com/rapid7/nexpose-client.git","ssh_url":"git@github.com:rapid7/nexpose-client.git","clone_url":"https://github.com/rapid7/nexpose-client.git","svn_url":"https://github.com/rapid7/nexpose-client","homepage":"http://www.rapid7.com/","size":1887,"stargazers_count":98,"watchers_count":98,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":69,"mirror_url":null,"open_issues_count":12,"forks":69,"open_issues":12,"watchers":98,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rapid7/nexpose-client/pulls/231"},"html":{"href":"https://github.com/rapid7/nexpose-client/pull/231"},"issue":{"href":"https://api.github.com/repos/rapid7/nexpose-client/issues/231"},"comments":{"href":"https://api.github.com/repos/rapid7/nexpose-client/issues/231/comments"},"review_comments":{"href":"https://api.github.com/repos/rapid7/nexpose-client/pulls/231/comments"},"review_comment":{"href":"https://api.github.com/repos/rapid7/nexpose-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rapid7/nexpose-client/pulls/231/commits"},"statuses":{"href":"https://api.github.com/repos/rapid7/nexpose-client/statuses/b73cfa51d92976535d6bf5b77b5e8d786b33da7d"}}}}
{"actor":{"display_login":"houndci-bot"}}