{"action":"created","comment":{"url":"https://api.github.com/repos/9livesdata/whylog/pulls/comments/55033685","id":55033685,"diff_hunk":"@@ -28,6 +35,87 @@ def _filter_rule_set(self, parsers_list):\n     def _get_locations_for_logs(self, logs_types_list):\n         pass\n \n+    def add_rule(self, user_rule_intent):\n+        rule = self._create_rule_from_user_rule_intent(user_rule_intent)\n+        self._save_rule_definition(rule.get_rule_in_form_to_save())\n+        self._save_parsers_definition(rule.get_rule_parsers_in_form_to_save())\n+\n+    def _save_rule_definition(self, rule_definition):\n+        with open(self._rules_path, \"a\") as rules_file:\n+            rules_file.write(yaml.safe_dump(rule_definition, explicit_start=True))\n+\n+    def _save_parsers_definition(self, parser_definitions):\n+        with open(self._parsers_path, \"a\") as parsers_file:\n+            parsers_file.write(yaml.safe_dump_all(parser_definitions, explicit_start=True))\n+\n+    def _create_rule_from_user_rule_intent(self, user_rule_intent):\n+        parsers_dict = self._create_parsers_from_parsers_intents(user_rule_intent)\n+        effect = parsers_dict.get(user_rule_intent.effect_id)","path":"whylog/config/__init__.py","position":41,"original_position":41,"commit_id":"e7fba5bb1c3fa0ac9eef01778e6835a577bd3581","original_commit_id":"e7fba5bb1c3fa0ac9eef01778e6835a577bd3581","user":{"login":"ppolewicz","id":726553,"avatar_url":"https://avatars.githubusercontent.com/u/726553?v=3","gravatar_id":"","url":"https://api.github.com/users/ppolewicz","html_url":"https://github.com/ppolewicz","followers_url":"https://api.github.com/users/ppolewicz/followers","following_url":"https://api.github.com/users/ppolewicz/following{/other_user}","gists_url":"https://api.github.com/users/ppolewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/ppolewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppolewicz/subscriptions","organizations_url":"https://api.github.com/users/ppolewicz/orgs","repos_url":"https://api.github.com/users/ppolewicz/repos","events_url":"https://api.github.com/users/ppolewicz/events{/privacy}","received_events_url":"https://api.github.com/users/ppolewicz/received_events","type":"User","site_admin":false},"body":"Current code allows effect to be `None`!\r\n```python\r\neffect = parsers_dict.pop(user_rule_intent.effect_id)`\r\n```\r\n?","created_at":"2016-03-04T14:13:03Z","updated_at":"2016-03-04T14:13:03Z","html_url":"https://github.com/9livesdata/whylog/pull/58#discussion_r55033685","pull_request_url":"https://api.github.com/repos/9livesdata/whylog/pulls/58","_links":{"self":{"href":"https://api.github.com/repos/9livesdata/whylog/pulls/comments/55033685"},"html":{"href":"https://github.com/9livesdata/whylog/pull/58#discussion_r55033685"},"pull_request":{"href":"https://api.github.com/repos/9livesdata/whylog/pulls/58"}}},"pull_request":{"url":"https://api.github.com/repos/9livesdata/whylog/pulls/58","id":61649019,"html_url":"https://github.com/9livesdata/whylog/pull/58","diff_url":"https://github.com/9livesdata/whylog/pull/58.diff","patch_url":"https://github.com/9livesdata/whylog/pull/58.patch","issue_url":"https://api.github.com/repos/9livesdata/whylog/issues/58","number":58,"state":"open","locked":false,"title":"Creating Rule from RuleUserIntent ","user":{"login":"kgromadzki","id":11337119,"avatar_url":"https://avatars.githubusercontent.com/u/11337119?v=3","gravatar_id":"","url":"https://api.github.com/users/kgromadzki","html_url":"https://github.com/kgromadzki","followers_url":"https://api.github.com/users/kgromadzki/followers","following_url":"https://api.github.com/users/kgromadzki/following{/other_user}","gists_url":"https://api.github.com/users/kgromadzki/gists{/gist_id}","starred_url":"https://api.github.com/users/kgromadzki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgromadzki/subscriptions","organizations_url":"https://api.github.com/users/kgromadzki/orgs","repos_url":"https://api.github.com/users/kgromadzki/repos","events_url":"https://api.github.com/users/kgromadzki/events{/privacy}","received_events_url":"https://api.github.com/users/kgromadzki/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-03-04T00:24:36Z","updated_at":"2016-03-04T14:13:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f158100ca5ed0bed471f531fd2361184aae24fe8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/9livesdata/whylog/pulls/58/commits","review_comments_url":"https://api.github.com/repos/9livesdata/whylog/pulls/58/comments","review_comment_url":"https://api.github.com/repos/9livesdata/whylog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/9livesdata/whylog/issues/58/comments","statuses_url":"https://api.github.com/repos/9livesdata/whylog/statuses/e7fba5bb1c3fa0ac9eef01778e6835a577bd3581","head":{"label":"kgromadzki:rule_intent_transform","ref":"rule_intent_transform","sha":"e7fba5bb1c3fa0ac9eef01778e6835a577bd3581","user":{"login":"kgromadzki","id":11337119,"avatar_url":"https://avatars.githubusercontent.com/u/11337119?v=3","gravatar_id":"","url":"https://api.github.com/users/kgromadzki","html_url":"https://github.com/kgromadzki","followers_url":"https://api.github.com/users/kgromadzki/followers","following_url":"https://api.github.com/users/kgromadzki/following{/other_user}","gists_url":"https://api.github.com/users/kgromadzki/gists{/gist_id}","starred_url":"https://api.github.com/users/kgromadzki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgromadzki/subscriptions","organizations_url":"https://api.github.com/users/kgromadzki/orgs","repos_url":"https://api.github.com/users/kgromadzki/repos","events_url":"https://api.github.com/users/kgromadzki/events{/privacy}","received_events_url":"https://api.github.com/users/kgromadzki/received_events","type":"User","site_admin":false},"repo":{"id":46000029,"name":"whylog","full_name":"kgromadzki/whylog","owner":{"login":"kgromadzki","id":11337119,"avatar_url":"https://avatars.githubusercontent.com/u/11337119?v=3","gravatar_id":"","url":"https://api.github.com/users/kgromadzki","html_url":"https://github.com/kgromadzki","followers_url":"https://api.github.com/users/kgromadzki/followers","following_url":"https://api.github.com/users/kgromadzki/following{/other_user}","gists_url":"https://api.github.com/users/kgromadzki/gists{/gist_id}","starred_url":"https://api.github.com/users/kgromadzki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgromadzki/subscriptions","organizations_url":"https://api.github.com/users/kgromadzki/orgs","repos_url":"https://api.github.com/users/kgromadzki/repos","events_url":"https://api.github.com/users/kgromadzki/events{/privacy}","received_events_url":"https://api.github.com/users/kgromadzki/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kgromadzki/whylog","description":"","fork":true,"url":"https://api.github.com/repos/kgromadzki/whylog","forks_url":"https://api.github.com/repos/kgromadzki/whylog/forks","keys_url":"https://api.github.com/repos/kgromadzki/whylog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kgromadzki/whylog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kgromadzki/whylog/teams","hooks_url":"https://api.github.com/repos/kgromadzki/whylog/hooks","issue_events_url":"https://api.github.com/repos/kgromadzki/whylog/issues/events{/number}","events_url":"https://api.github.com/repos/kgromadzki/whylog/events","assignees_url":"https://api.github.com/repos/kgromadzki/whylog/assignees{/user}","branches_url":"https://api.github.com/repos/kgromadzki/whylog/branches{/branch}","tags_url":"https://api.github.com/repos/kgromadzki/whylog/tags","blobs_url":"https://api.github.com/repos/kgromadzki/whylog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kgromadzki/whylog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kgromadzki/whylog/git/refs{/sha}","trees_url":"https://api.github.com/repos/kgromadzki/whylog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kgromadzki/whylog/statuses/{sha}","languages_url":"https://api.github.com/repos/kgromadzki/whylog/languages","stargazers_url":"https://api.github.com/repos/kgromadzki/whylog/stargazers","contributors_url":"https://api.github.com/repos/kgromadzki/whylog/contributors","subscribers_url":"https://api.github.com/repos/kgromadzki/whylog/subscribers","subscription_url":"https://api.github.com/repos/kgromadzki/whylog/subscription","commits_url":"https://api.github.com/repos/kgromadzki/whylog/commits{/sha}","git_commits_url":"https://api.github.com/repos/kgromadzki/whylog/git/commits{/sha}","comments_url":"https://api.github.com/repos/kgromadzki/whylog/comments{/number}","issue_comment_url":"https://api.github.com/repos/kgromadzki/whylog/issues/comments{/number}","contents_url":"https://api.github.com/repos/kgromadzki/whylog/contents/{+path}","compare_url":"https://api.github.com/repos/kgromadzki/whylog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kgromadzki/whylog/merges","archive_url":"https://api.github.com/repos/kgromadzki/whylog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kgromadzki/whylog/downloads","issues_url":"https://api.github.com/repos/kgromadzki/whylog/issues{/number}","pulls_url":"https://api.github.com/repos/kgromadzki/whylog/pulls{/number}","milestones_url":"https://api.github.com/repos/kgromadzki/whylog/milestones{/number}","notifications_url":"https://api.github.com/repos/kgromadzki/whylog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kgromadzki/whylog/labels{/name}","releases_url":"https://api.github.com/repos/kgromadzki/whylog/releases{/id}","deployments_url":"https://api.github.com/repos/kgromadzki/whylog/deployments","created_at":"2015-11-11T18:06:33Z","updated_at":"2016-02-28T23:05:18Z","pushed_at":"2016-03-04T10:50:36Z","git_url":"git://github.com/kgromadzki/whylog.git","ssh_url":"git@github.com:kgromadzki/whylog.git","clone_url":"https://github.com/kgromadzki/whylog.git","svn_url":"https://github.com/kgromadzki/whylog","homepage":null,"size":164,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"9livesdata:master","ref":"master","sha":"882b88632d1e5a277b4cdc546059001e1bef21d2","user":{"login":"9livesdata","id":15250580,"avatar_url":"https://avatars.githubusercontent.com/u/15250580?v=3","gravatar_id":"","url":"https://api.github.com/users/9livesdata","html_url":"https://github.com/9livesdata","followers_url":"https://api.github.com/users/9livesdata/followers","following_url":"https://api.github.com/users/9livesdata/following{/other_user}","gists_url":"https://api.github.com/users/9livesdata/gists{/gist_id}","starred_url":"https://api.github.com/users/9livesdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9livesdata/subscriptions","organizations_url":"https://api.github.com/users/9livesdata/orgs","repos_url":"https://api.github.com/users/9livesdata/repos","events_url":"https://api.github.com/users/9livesdata/events{/privacy}","received_events_url":"https://api.github.com/users/9livesdata/received_events","type":"Organization","site_admin":false},"repo":{"id":44754618,"name":"whylog","full_name":"9livesdata/whylog","owner":{"login":"9livesdata","id":15250580,"avatar_url":"https://avatars.githubusercontent.com/u/15250580?v=3","gravatar_id":"","url":"https://api.github.com/users/9livesdata","html_url":"https://github.com/9livesdata","followers_url":"https://api.github.com/users/9livesdata/followers","following_url":"https://api.github.com/users/9livesdata/following{/other_user}","gists_url":"https://api.github.com/users/9livesdata/gists{/gist_id}","starred_url":"https://api.github.com/users/9livesdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9livesdata/subscriptions","organizations_url":"https://api.github.com/users/9livesdata/orgs","repos_url":"https://api.github.com/users/9livesdata/repos","events_url":"https://api.github.com/users/9livesdata/events{/privacy}","received_events_url":"https://api.github.com/users/9livesdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/9livesdata/whylog","description":"","fork":false,"url":"https://api.github.com/repos/9livesdata/whylog","forks_url":"https://api.github.com/repos/9livesdata/whylog/forks","keys_url":"https://api.github.com/repos/9livesdata/whylog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/9livesdata/whylog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/9livesdata/whylog/teams","hooks_url":"https://api.github.com/repos/9livesdata/whylog/hooks","issue_events_url":"https://api.github.com/repos/9livesdata/whylog/issues/events{/number}","events_url":"https://api.github.com/repos/9livesdata/whylog/events","assignees_url":"https://api.github.com/repos/9livesdata/whylog/assignees{/user}","branches_url":"https://api.github.com/repos/9livesdata/whylog/branches{/branch}","tags_url":"https://api.github.com/repos/9livesdata/whylog/tags","blobs_url":"https://api.github.com/repos/9livesdata/whylog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/9livesdata/whylog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/9livesdata/whylog/git/refs{/sha}","trees_url":"https://api.github.com/repos/9livesdata/whylog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/9livesdata/whylog/statuses/{sha}","languages_url":"https://api.github.com/repos/9livesdata/whylog/languages","stargazers_url":"https://api.github.com/repos/9livesdata/whylog/stargazers","contributors_url":"https://api.github.com/repos/9livesdata/whylog/contributors","subscribers_url":"https://api.github.com/repos/9livesdata/whylog/subscribers","subscription_url":"https://api.github.com/repos/9livesdata/whylog/subscription","commits_url":"https://api.github.com/repos/9livesdata/whylog/commits{/sha}","git_commits_url":"https://api.github.com/repos/9livesdata/whylog/git/commits{/sha}","comments_url":"https://api.github.com/repos/9livesdata/whylog/comments{/number}","issue_comment_url":"https://api.github.com/repos/9livesdata/whylog/issues/comments{/number}","contents_url":"https://api.github.com/repos/9livesdata/whylog/contents/{+path}","compare_url":"https://api.github.com/repos/9livesdata/whylog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/9livesdata/whylog/merges","archive_url":"https://api.github.com/repos/9livesdata/whylog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/9livesdata/whylog/downloads","issues_url":"https://api.github.com/repos/9livesdata/whylog/issues{/number}","pulls_url":"https://api.github.com/repos/9livesdata/whylog/pulls{/number}","milestones_url":"https://api.github.com/repos/9livesdata/whylog/milestones{/number}","notifications_url":"https://api.github.com/repos/9livesdata/whylog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/9livesdata/whylog/labels{/name}","releases_url":"https://api.github.com/repos/9livesdata/whylog/releases{/id}","deployments_url":"https://api.github.com/repos/9livesdata/whylog/deployments","created_at":"2015-10-22T15:28:20Z","updated_at":"2016-02-28T22:54:29Z","pushed_at":"2016-03-04T10:50:36Z","git_url":"git://github.com/9livesdata/whylog.git","ssh_url":"git@github.com:9livesdata/whylog.git","clone_url":"https://github.com/9livesdata/whylog.git","svn_url":"https://github.com/9livesdata/whylog","homepage":null,"size":554,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":20,"forks":5,"open_issues":20,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/9livesdata/whylog/pulls/58"},"html":{"href":"https://github.com/9livesdata/whylog/pull/58"},"issue":{"href":"https://api.github.com/repos/9livesdata/whylog/issues/58"},"comments":{"href":"https://api.github.com/repos/9livesdata/whylog/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/9livesdata/whylog/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/9livesdata/whylog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/9livesdata/whylog/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/9livesdata/whylog/statuses/e7fba5bb1c3fa0ac9eef01778e6835a577bd3581"}}}}