{"push_id":1308886507,"size":64,"distinct_size":56,"ref":"refs/heads/ftl","head":"2674981fac68bb3bddc5e7286f5d6b011aca7fdc","before":"bc1647ab3ba1bce5116110d14b7d382783839d26","commits":[{"sha":"2d24d165d6a56bf5c0eb7015649cab688bcb2863","author":{"name":"Ciara Loftus","email":"481282050defc25f41ffe93a44e2e99bcd36cf96@intel.com"},"message":"netdev-dpdk: Add new 'dpdkvhostuserclient' port type\n\nThe 'dpdkvhostuser' port type no longer supports both server and client\nmode. Instead, 'dpdkvhostuser' ports are always 'server' mode and\n'dpdkvhostuserclient' ports are always 'client' mode.\n\nSuggested-by: Daniele Di Proietto <diproiettod@vmware.com>\nSigned-off-by: Ciara Loftus <ciara.loftus@intel.com>\nSigned-off-by: Daniele Di Proietto <diproiettod@vmware.com>","distinct":false,"url":"https://api.github.com/repos/blp/ovs-reviews/commits/2d24d165d6a56bf5c0eb7015649cab688bcb2863"},{"sha":"5f88de0d9ff487f817484e4e9b117006940cba77","author":{"name":"Ilya Maximets","email":"8d2b0d23d2491417bf557dc7d3765b880009af04@samsung.com"},"message":"netdev-dpdk: Fix memory leak in dpdk_mp_{get, put}().\n\n'dmp' should be freed on failure and on put.\n\nFixes: 8a9562d21a40 (\"dpif-netdev: Add DPDK netdev.\")\nFixes: 8d38823bdf8b (\"netdev-dpdk: fix memory leak\")\nSigned-off-by: Ilya Maximets <i.maximets@samsung.com>\nSigned-off-by: Daniele Di Proietto <diproiettod@vmware.com>","distinct":false,"url":"https://api.github.com/repos/blp/ovs-reviews/commits/5f88de0d9ff487f817484e4e9b117006940cba77"},{"sha":"b17c822805390ebfe624a50bc446597efd10f212","author":{"name":"Ben Pfaff","email":"b30031e87fea8687a432a5f632461bee2630c54c@ovn.org"},"message":"ovsdb-idl: Update comments.\n\nTXN_AGAIN_WAIT and TXN_AGAIN_NOW were combined into a single return code\nTXN_TRY_AGAIN a long time ago, but these comment was not updated.\n\nReported-by: Justin Pettit <jpettit@ovn.org>\nSigned-off-by: Ben Pfaff <blp@ovn.org>\nAcked-by: Justin Pettit <jpettit@ovn.org>","distinct":false,"url":"https://api.github.com/repos/blp/ovs-reviews/commits/b17c822805390ebfe624a50bc446597efd10f212"},{"sha":"9ef3a410b2d93ae6890c6e831dd3ed84d3c374d9","author":{"name":"Shashank Ram","email":"212553a0b3224aaf4673f4438f4d1b3d9e5c0999@vmware.com"},"message":"datapath-windows: Add define for last module number\n\nAdds a define for the last defined module number.\n\nSigned-off-by: Shashank Ram <rams@vmware.com>\nAcked-by: Sairam Venugopal <vsairam@vmware.com>\nAcked-by: Nithin Raju <nithin@vmware.com>\nSigned-off-by: Gurucharan Shetty <guru@ovn.org>","distinct":false,"url":"https://api.github.com/repos/blp/ovs-reviews/commits/9ef3a410b2d93ae6890c6e831dd3ed84d3c374d9"},{"sha":"8483173bff2589a2c1515f711bc0e337792f1995","author":{"name":"Binbin Xu","email":"250f7019b3cdd12582df84462df8ea2397c2cf2c@zte.com.cn"},"message":"ofproto: Remove groups that nested actions reference when removing rule.\n\ntopology:\n                      +----------------+\n            +-------->| SDN Controller |<--------------+\n            |         +----------------+               |\n            |\t                                       |\n+-----------|-----+\t\t\t   +-----------|-----+\n| +-----+   |     |                        | +-----+   |     |\n| | VM1 |   |     |                        | | VM2 |   |     |\n| +-----+   |     |                        | +-----+   |     |\n|    ^      V     |                        |    ^      V     |\n|    |   +-----+  |                        |    |   +-----+  |\n|    +-> | OVS |  |                        |    +-> | OVS |  |\n|        +-----+  |                        |        +-----+  |\n|           ^     |                        |           ^     |\n+-----------|-----+                        +-----------|-----+\n\t    | Nic                                   Nic|\n            +------------------------------------------+\n\nWe start the communication between VM1 and VM2, for example, ICMP.\nAt the meantime, disconnect OVS and SDN controller, and reconnect\nthem again, the process ovs-vswitchd crashes.\n\nbacktrace:\n0  0x00007f658082ffe4 in cls_rule_make_invisible_in_version ()\n1  0x00007f65807f6bb3 in delete_flows_start__ ()\n2  0x00007f65807f7ee9 in ofproto_group_mod_start ()\n3  0x00007f65807fa07b in handle_openflow ()\n4  0x00007f658082119b in connmgr_run ()\n5  0x00007f65807f3ba6 in ofproto_run ()\n6  0x00007f65807e101c in bridge_run__ ()\n7  0x00007f65807e715d in bridge_run ()\n8  0x00007f658065784d in main ()\n\nSigned-off-by: Binbin Xu <xu.binbin1@zte.com.cn>\nSigned-off-by: Ben Pfaff <blp@ovn.org>","distinct":false,"url":"https://api.github.com/repos/blp/ovs-reviews/commits/8483173bff2589a2c1515f711bc0e337792f1995"},{"sha":"814aac29b582ec6be6ac984c158e6db1a8f139e5","author":{"name":"Binbin Xu","email":"250f7019b3cdd12582df84462df8ea2397c2cf2c@zte.com.cn"},"message":"ofp-actions: Remove unused OFPACT_FOR_EACH_TYPE.\n\nSigned-off-by: Binbin Xu <xu.binbin1@zte.com.cn>\nSigned-off-by: Ben Pfaff <blp@ovn.org>","distinct":false,"url":"https://api.github.com/repos/blp/ovs-reviews/commits/814aac29b582ec6be6ac984c158e6db1a8f139e5"},{"sha":"1388f0b7a45d0940a276b9888c5af7774e5197ce","author":{"name":"Huanle Han","email":"4c1aa3e0939e4f44b5ea1c94c56d48f9357e942c@gmail.com"},"message":"netdev: Avoid leaking seq in netdev_open() error path.\n\nSigned-off-by: Huanle Han <hanxueluo@gmail.com>\nSigned-off-by: Ben Pfaff <blp@ovn.org>","distinct":false,"url":"https://api.github.com/repos/blp/ovs-reviews/commits/1388f0b7a45d0940a276b9888c5af7774e5197ce"},{"sha":"3b4fff438cea524ae421269abfc5197430b65cb9","author":{"name":"Ryan Moats","email":"e79a1704e070f6044f34a46a3f5277e8ea05871b@us.ibm.com"},"message":"ofproto-dpif-xlate: Fix memory leak in execute_controller_action.\n\ncommit df70a7731 (\"ofproto-dpif-xlate: Allow translating\nwithout side-effects.\") created a memory leak by removing the\ndp_packet_delete statement in execute_controller_action that\nfreed the earlier cloned packet.  This commit restores this\nstatement to the end of the method.\n\nFixes: df70a7731 (\"ofproto-dpif-xlate: Allow translating without side-effects.\")\nSigned-off-by: Ryan Moats <rmoats@us.ibm.com>\nSigned-off-by: Ben Pfaff <blp@ovn.org>","distinct":false,"url":"https://api.github.com/repos/blp/ovs-reviews/commits/3b4fff438cea524ae421269abfc5197430b65cb9"},{"sha":"49700562e218f9b3ab93543225b57af511b9ca20","author":{"name":"Ben Pfaff","email":"b30031e87fea8687a432a5f632461bee2630c54c@ovn.org"},"message":"ovn: Fix races in MAC_Binding deletion test.\n\nThe test assumed that ovn-northd could delete the MAC_Binding rows\ninstantly, but it may take a while.\n\nSigned-off-by: Ben Pfaff <blp@ovn.org>","distinct":true,"url":"https://api.github.com/repos/blp/ovs-reviews/commits/49700562e218f9b3ab93543225b57af511b9ca20"},{"sha":"f769d827591d4f209177d5a7a5075cf8b0e513e9","author":{"name":"Ben Pfaff","email":"b30031e87fea8687a432a5f632461bee2630c54c@ovn.org"},"message":"ovn: Fix bugs in port security test.\n\nA number of instances of \"{i}\" in this test should have been \"${i}\".\n\nSigned-off-by: Ben Pfaff <blp@ovn.org>","distinct":true,"url":"https://api.github.com/repos/blp/ovs-reviews/commits/f769d827591d4f209177d5a7a5075cf8b0e513e9"},{"sha":"5983e51a87fc0e36f9dca8532243d3c6e937d76b","author":{"name":"Ben Pfaff","email":"b30031e87fea8687a432a5f632461bee2630c54c@ovn.org"},"message":"ovn: Fix some races in IPAM connectivity test.\n\nIt can take a way for dynamic addresses to propagate through ovn-northd,\nso wait for it to happen.\n\nSigned-off-by: Ben Pfaff <blp@ovn.org>","distinct":true,"url":"https://api.github.com/repos/blp/ovs-reviews/commits/5983e51a87fc0e36f9dca8532243d3c6e937d76b"},{"sha":"1e09f66a053554cbb91c874bb9598eea1311108f","author":{"name":"Ben Pfaff","email":"b30031e87fea8687a432a5f632461bee2630c54c@ovn.org"},"message":"ovn: Remove weird or unneeded keywords from tests.\n\nAT_KEYWORDS are mostly there to make it easier to find the tests you're\nlooking for.  One might, for example, mark tests as \"positive\" or\n\"negative\" so you can select the tests you want to run on that basis.\nThey're also useful for cases where Autotest just isn't good at splitting\nwords: for example, Autotest includes punctuation so that a test name\nthat has a word followed by a comma or colon won't be selected using a\nkeyword that lacks the comma or the colon.\n\nBut a lot of OVN tests had keywords that just didn't seem helpful in one\nof these ways.  For example, it's hard to guess why running together\nwords into a longer word would help someone select a test, and it's not\nhelpful at all to repeat one of the words in the test name, since those\nwords are keywords by default anyway.\n\nTherefore, this commit removes the keywords that don't seem helpful.\n\nSigned-off-by: Ben Pfaff <blp@ovn.org>","distinct":true,"url":"https://api.github.com/repos/blp/ovs-reviews/commits/1e09f66a053554cbb91c874bb9598eea1311108f"},{"sha":"534ddc7dc37e3a8da16ca621e84869520414b3ea","author":{"name":"Ben Pfaff","email":"b30031e87fea8687a432a5f632461bee2630c54c@ovn.org"},"message":"tests: Fix double-rebuild of testsuite for \"check-valgrind\".\n\nWhen I ran \"make check-valgrind -j10\" and the testsuite needed to be\nrebuilt, two copies of it were rebuilt in parallel and sometimes they\nraced with each other.  I don't have the full story on exactly why this\nhappened, but this commit, which eliminates redundant dependencies from\ncheck-* targets, fixes the problem for me.  The dependencies are redundant\nbecause these targets depend on \"all\", which also depends on them.\n\nSigned-off-by: Ben Pfaff <blp@ovn.org>","distinct":true,"url":"https://api.github.com/repos/blp/ovs-reviews/commits/534ddc7dc37e3a8da16ca621e84869520414b3ea"},{"sha":"d3a2a45714765f4c6660bbb95e4d47621d995593","author":{"name":"Ben Pfaff","email":"b30031e87fea8687a432a5f632461bee2630c54c@ovn.org"},"message":"tests: Get rid of overly specific --pidfile and --unixctl options.\n\nAt an early point in OVS development, OVS was built with fixed default\ndirectories for pidfiles and sockets.  This meant that it was necessary to\nuse lots of --pidfile and --unixctl options in the testsuite, to point the\ndaemons to where they should put these files (since the testsuite cannot\nand generally should not touch the real system /var/run).  Later on,\nthe environment variables OVS_RUNDIR, OVS_LOGDIR, etc. were introduced\nto override these defaults, and even later the testsuite was changed to\nalways set these variables correctly in every test.  Thus, these days it\nisn't usually necessary to specify a filename on --pidfile or to specify\n--unixctl at all.  However, many of the tests are built by cut-and-paste,\nso they tended to keep appearing anyhow.  This commit drops most of them,\nmaking the testsuite easier to read and understand.\n\nThis commit also sweeps away some other historical detritius.  In\nparticular, in early days of the testsuite there was no way to\nautomatically kill daemons when a test failed (or otherwise ended).  This\nmeant that some tests were littered with calls to \"kill `cat pidfile`\" on\nalmost every line (or m4 macros that expanded to the same thing) so that if\na test failed partway through the testsuite would not hang waiting for a\ndaemon to die that was never going to die without manual intervention.\nHowever, a long time ago we introduced the \"on_exit\" mechanism that\nobsoletes this.  This commit eliminates a lot of the old litter of kill\ninvocations, which also makes those tests easier to read.\n\nSigned-off-by: Ben Pfaff <blp@ovn.org>","distinct":true,"url":"https://api.github.com/repos/blp/ovs-reviews/commits/d3a2a45714765f4c6660bbb95e4d47621d995593"},{"sha":"52b6ecf5685852e7db4115944bca3d696405082e","author":{"name":"Ben Pfaff","email":"b30031e87fea8687a432a5f632461bee2630c54c@ovn.org"},"message":"ovsdb-idlc: Use ovsdb_datum_from_smap() instead of open-coding it.\n\nThere's no reason to have three copies of this code for every smap-type\ncolumn.\n\nThe code wasn't a perfect match for ovsdb_datum_from_smap(), so this commit\nalso changes ovsdb_datum_from_smap() to better suit it.  It only had one\ncaller and the new design is adequate for that caller.\n\nSigned-off-by: Ben Pfaff <blp@ovn.org>","distinct":true,"url":"https://api.github.com/repos/blp/ovs-reviews/commits/52b6ecf5685852e7db4115944bca3d696405082e"},{"sha":"2ed34ffed09f8ae277bb944c48a1422d2189e86a","author":{"name":"Ben Pfaff","email":"b30031e87fea8687a432a5f632461bee2630c54c@ovn.org"},"message":"ovsdb-idlc: Remove obsolete documentation and usage.\n\nSigned-off-by: Ben Pfaff <blp@ovn.org>","distinct":true,"url":"https://api.github.com/repos/blp/ovs-reviews/commits/2ed34ffed09f8ae277bb944c48a1422d2189e86a"},{"sha":"3568c7e4d5f24ab092853f70897a476b2fdf9aa5","author":{"name":"Ben Pfaff","email":"b30031e87fea8687a432a5f632461bee2630c54c@ovn.org"},"message":"ovsdb-idlc: Factor out sorting columns.\n\nSigned-off-by: Ben Pfaff <blp@ovn.org>","distinct":true,"url":"https://api.github.com/repos/blp/ovs-reviews/commits/3568c7e4d5f24ab092853f70897a476b2fdf9aa5"},{"sha":"16ead2cb0ac3aabef94d5736ddfcef96aa932a02","author":{"name":"Ben Pfaff","email":"b30031e87fea8687a432a5f632461bee2630c54c@ovn.org"},"message":"ovsdb-idlc: Simplify code generation to parse sets and maps of references.\n\nThis switches from code that looks like:\n    if (keyRow) {\n        ...\n    }\nto:\n    if (!keyRow) {\n        continue;\n    }\n    ...\nwhich is a little easier to generate because the indentation of ... is\nconstant.\n\nSigned-off-by: Ben Pfaff <blp@ovn.org>","distinct":true,"url":"https://api.github.com/repos/blp/ovs-reviews/commits/16ead2cb0ac3aabef94d5736ddfcef96aa932a02"},{"sha":"4635271e5672405a4d6c0aa2eb667eaa7f83496a","author":{"name":"Ben Pfaff","email":"b30031e87fea8687a432a5f632461bee2630c54c@ovn.org"},"message":"ovsdb-idlc: Make generated references to table classes easier to read.\n\nThis replaces &ovsrec_table_classes[OVSREC_TABLE_OPEN_VSWITCH] by the\neasier to read and equivalent &ovsrec_table_open_vswitch in generated code.\n\nSigned-off-by: Ben Pfaff <blp@ovn.org>","distinct":true,"url":"https://api.github.com/repos/blp/ovs-reviews/commits/4635271e5672405a4d6c0aa2eb667eaa7f83496a"},{"sha":"d1d484313b831c25fe88f16d7edaf690982b2046","author":{"name":"Ben Pfaff","email":"b30031e87fea8687a432a5f632461bee2630c54c@ovn.org"},"message":"ovsdb-idlc: Make generated references to columns easier to read.\n\nThis replaces ovsrec_open_vswitch_columns[OVSREC_OPEN_VSWITCH_COL_CUR_CFG]\nby the easier to read and equivalent ovsrec_open_vswitch_col_cur_cfg in\ngenerated code.\n\nSigned-off-by: Ben Pfaff <blp@ovn.org>","distinct":true,"url":"https://api.github.com/repos/blp/ovs-reviews/commits/d1d484313b831c25fe88f16d7edaf690982b2046"}]}
{"actor":{"display_login":"blp"}}