{"action":"created","comment":{"url":"https://api.github.com/repos/aerogear/aerogear-android-push/pulls/comments/60952097","id":60952097,"diff_hunk":"@@ -32,9 +32,16 @@\n     private String alias;\n     private List<String> categories = new ArrayList<String>();\n \n+    \n+    /**\n+     * Topics in GCM must conform to this pattern.\n+     * See : https://developers.google.com/android/reference/com/google/android/gms/gcm/GcmPubSub#unsubscribe(java.lang.String, java.lang.String)\n+     */\n+    private static final String GCM_TOPIC_PATTERN = \"[a-zA-Z0-9-_.~%]{1,900}\";","path":"aerogear-android-push/src/main/java/org/jboss/aerogear/android/unifiedpush/gcm/UnifiedPushConfig.java","position":38,"original_position":38,"commit_id":"f761998e0d659af94810a4bcaf1b036cb64a060d","original_commit_id":"f761998e0d659af94810a4bcaf1b036cb64a060d","user":{"login":"secondsun","id":2413816,"avatar_url":"https://avatars.githubusercontent.com/u/2413816?v=3","gravatar_id":"","url":"https://api.github.com/users/secondsun","html_url":"https://github.com/secondsun","followers_url":"https://api.github.com/users/secondsun/followers","following_url":"https://api.github.com/users/secondsun/following{/other_user}","gists_url":"https://api.github.com/users/secondsun/gists{/gist_id}","starred_url":"https://api.github.com/users/secondsun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/secondsun/subscriptions","organizations_url":"https://api.github.com/users/secondsun/orgs","repos_url":"https://api.github.com/users/secondsun/repos","events_url":"https://api.github.com/users/secondsun/events{/privacy}","received_events_url":"https://api.github.com/users/secondsun/received_events","type":"User","site_admin":false},"body":"It wouldn't hurt.","created_at":"2016-04-25T17:22:31Z","updated_at":"2016-04-25T17:22:31Z","html_url":"https://github.com/aerogear/aerogear-android-push/pull/50#discussion_r60952097","pull_request_url":"https://api.github.com/repos/aerogear/aerogear-android-push/pulls/50","_links":{"self":{"href":"https://api.github.com/repos/aerogear/aerogear-android-push/pulls/comments/60952097"},"html":{"href":"https://github.com/aerogear/aerogear-android-push/pull/50#discussion_r60952097"},"pull_request":{"href":"https://api.github.com/repos/aerogear/aerogear-android-push/pulls/50"}}},"pull_request":{"url":"https://api.github.com/repos/aerogear/aerogear-android-push/pulls/50","id":41787856,"html_url":"https://github.com/aerogear/aerogear-android-push/pull/50","diff_url":"https://github.com/aerogear/aerogear-android-push/pull/50.diff","patch_url":"https://github.com/aerogear/aerogear-android-push/pull/50.patch","issue_url":"https://api.github.com/repos/aerogear/aerogear-android-push/issues/50","number":50,"state":"open","locked":false,"title":"Agdroid 470 topic messaging","user":{"login":"secondsun","id":2413816,"avatar_url":"https://avatars.githubusercontent.com/u/2413816?v=3","gravatar_id":"","url":"https://api.github.com/users/secondsun","html_url":"https://github.com/secondsun","followers_url":"https://api.github.com/users/secondsun/followers","following_url":"https://api.github.com/users/secondsun/following{/other_user}","gists_url":"https://api.github.com/users/secondsun/gists{/gist_id}","starred_url":"https://api.github.com/users/secondsun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/secondsun/subscriptions","organizations_url":"https://api.github.com/users/secondsun/orgs","repos_url":"https://api.github.com/users/secondsun/repos","events_url":"https://api.github.com/users/secondsun/events{/privacy}","received_events_url":"https://api.github.com/users/secondsun/received_events","type":"User","site_admin":false},"body":"# How to test (requires a UPS feature branch)\r\n * Build the project.  Ask in #aerogear or on aerogear-dev if you need help\r\n * Build the gcm-topics PR for UPS\r\n * Configure a push variant etc etc in UPS\r\n * Configure a sample application (I used the hello world)\r\n * In the sample application add a category \"topic\" (or anything you want) to the Push Registrar config\r\n * In UPS sent a message to the device.  In the UPS log you will see Sending payload for [1] devices to GCM\r\n * Now send a message but set the category to \"topic\" (or whatever you set in step *)\r\n * In UPS you should see  Sending payload for [1] topics to GCM\r\n *  You should also see both messages in the app.","created_at":"2015-08-06T13:34:16Z","updated_at":"2016-04-25T17:22:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7084c49ef69cef9ca746b7491638190678dd813c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aerogear/aerogear-android-push/pulls/50/commits","review_comments_url":"https://api.github.com/repos/aerogear/aerogear-android-push/pulls/50/comments","review_comment_url":"https://api.github.com/repos/aerogear/aerogear-android-push/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aerogear/aerogear-android-push/issues/50/comments","statuses_url":"https://api.github.com/repos/aerogear/aerogear-android-push/statuses/f761998e0d659af94810a4bcaf1b036cb64a060d","head":{"label":"secondsun:AGDROID-470-TOPIC-MESSAGING","ref":"AGDROID-470-TOPIC-MESSAGING","sha":"f761998e0d659af94810a4bcaf1b036cb64a060d","user":{"login":"secondsun","id":2413816,"avatar_url":"https://avatars.githubusercontent.com/u/2413816?v=3","gravatar_id":"","url":"https://api.github.com/users/secondsun","html_url":"https://github.com/secondsun","followers_url":"https://api.github.com/users/secondsun/followers","following_url":"https://api.github.com/users/secondsun/following{/other_user}","gists_url":"https://api.github.com/users/secondsun/gists{/gist_id}","starred_url":"https://api.github.com/users/secondsun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/secondsun/subscriptions","organizations_url":"https://api.github.com/users/secondsun/orgs","repos_url":"https://api.github.com/users/secondsun/repos","events_url":"https://api.github.com/users/secondsun/events{/privacy}","received_events_url":"https://api.github.com/users/secondsun/received_events","type":"User","site_admin":false},"repo":{"id":21824214,"name":"aerogear-android-push","full_name":"secondsun/aerogear-android-push","owner":{"login":"secondsun","id":2413816,"avatar_url":"https://avatars.githubusercontent.com/u/2413816?v=3","gravatar_id":"","url":"https://api.github.com/users/secondsun","html_url":"https://github.com/secondsun","followers_url":"https://api.github.com/users/secondsun/followers","following_url":"https://api.github.com/users/secondsun/following{/other_user}","gists_url":"https://api.github.com/users/secondsun/gists{/gist_id}","starred_url":"https://api.github.com/users/secondsun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/secondsun/subscriptions","organizations_url":"https://api.github.com/users/secondsun/orgs","repos_url":"https://api.github.com/users/secondsun/repos","events_url":"https://api.github.com/users/secondsun/events{/privacy}","received_events_url":"https://api.github.com/users/secondsun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/secondsun/aerogear-android-push","description":"","fork":true,"url":"https://api.github.com/repos/secondsun/aerogear-android-push","forks_url":"https://api.github.com/repos/secondsun/aerogear-android-push/forks","keys_url":"https://api.github.com/repos/secondsun/aerogear-android-push/keys{/key_id}","collaborators_url":"https://api.github.com/repos/secondsun/aerogear-android-push/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/secondsun/aerogear-android-push/teams","hooks_url":"https://api.github.com/repos/secondsun/aerogear-android-push/hooks","issue_events_url":"https://api.github.com/repos/secondsun/aerogear-android-push/issues/events{/number}","events_url":"https://api.github.com/repos/secondsun/aerogear-android-push/events","assignees_url":"https://api.github.com/repos/secondsun/aerogear-android-push/assignees{/user}","branches_url":"https://api.github.com/repos/secondsun/aerogear-android-push/branches{/branch}","tags_url":"https://api.github.com/repos/secondsun/aerogear-android-push/tags","blobs_url":"https://api.github.com/repos/secondsun/aerogear-android-push/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/secondsun/aerogear-android-push/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/secondsun/aerogear-android-push/git/refs{/sha}","trees_url":"https://api.github.com/repos/secondsun/aerogear-android-push/git/trees{/sha}","statuses_url":"https://api.github.com/repos/secondsun/aerogear-android-push/statuses/{sha}","languages_url":"https://api.github.com/repos/secondsun/aerogear-android-push/languages","stargazers_url":"https://api.github.com/repos/secondsun/aerogear-android-push/stargazers","contributors_url":"https://api.github.com/repos/secondsun/aerogear-android-push/contributors","subscribers_url":"https://api.github.com/repos/secondsun/aerogear-android-push/subscribers","subscription_url":"https://api.github.com/repos/secondsun/aerogear-android-push/subscription","commits_url":"https://api.github.com/repos/secondsun/aerogear-android-push/commits{/sha}","git_commits_url":"https://api.github.com/repos/secondsun/aerogear-android-push/git/commits{/sha}","comments_url":"https://api.github.com/repos/secondsun/aerogear-android-push/comments{/number}","issue_comment_url":"https://api.github.com/repos/secondsun/aerogear-android-push/issues/comments{/number}","contents_url":"https://api.github.com/repos/secondsun/aerogear-android-push/contents/{+path}","compare_url":"https://api.github.com/repos/secondsun/aerogear-android-push/compare/{base}...{head}","merges_url":"https://api.github.com/repos/secondsun/aerogear-android-push/merges","archive_url":"https://api.github.com/repos/secondsun/aerogear-android-push/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/secondsun/aerogear-android-push/downloads","issues_url":"https://api.github.com/repos/secondsun/aerogear-android-push/issues{/number}","pulls_url":"https://api.github.com/repos/secondsun/aerogear-android-push/pulls{/number}","milestones_url":"https://api.github.com/repos/secondsun/aerogear-android-push/milestones{/number}","notifications_url":"https://api.github.com/repos/secondsun/aerogear-android-push/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/secondsun/aerogear-android-push/labels{/name}","releases_url":"https://api.github.com/repos/secondsun/aerogear-android-push/releases{/id}","deployments_url":"https://api.github.com/repos/secondsun/aerogear-android-push/deployments","created_at":"2014-07-14T15:12:37Z","updated_at":"2015-04-28T17:24:29Z","pushed_at":"2016-04-20T15:35:38Z","git_url":"git://github.com/secondsun/aerogear-android-push.git","ssh_url":"git@github.com:secondsun/aerogear-android-push.git","clone_url":"https://github.com/secondsun/aerogear-android-push.git","svn_url":"https://github.com/secondsun/aerogear-android-push","homepage":null,"size":332,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aerogear:master","ref":"master","sha":"748d259b51fa2b227edc550d72a6e00d0dda5e3c","user":{"login":"aerogear","id":954205,"avatar_url":"https://avatars.githubusercontent.com/u/954205?v=3","gravatar_id":"","url":"https://api.github.com/users/aerogear","html_url":"https://github.com/aerogear","followers_url":"https://api.github.com/users/aerogear/followers","following_url":"https://api.github.com/users/aerogear/following{/other_user}","gists_url":"https://api.github.com/users/aerogear/gists{/gist_id}","starred_url":"https://api.github.com/users/aerogear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerogear/subscriptions","organizations_url":"https://api.github.com/users/aerogear/orgs","repos_url":"https://api.github.com/users/aerogear/repos","events_url":"https://api.github.com/users/aerogear/events{/privacy}","received_events_url":"https://api.github.com/users/aerogear/received_events","type":"Organization","site_admin":false},"repo":{"id":18665536,"name":"aerogear-android-push","full_name":"aerogear/aerogear-android-push","owner":{"login":"aerogear","id":954205,"avatar_url":"https://avatars.githubusercontent.com/u/954205?v=3","gravatar_id":"","url":"https://api.github.com/users/aerogear","html_url":"https://github.com/aerogear","followers_url":"https://api.github.com/users/aerogear/followers","following_url":"https://api.github.com/users/aerogear/following{/other_user}","gists_url":"https://api.github.com/users/aerogear/gists{/gist_id}","starred_url":"https://api.github.com/users/aerogear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerogear/subscriptions","organizations_url":"https://api.github.com/users/aerogear/orgs","repos_url":"https://api.github.com/users/aerogear/repos","events_url":"https://api.github.com/users/aerogear/events{/privacy}","received_events_url":"https://api.github.com/users/aerogear/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aerogear/aerogear-android-push","description":"AeroGear Android Push","fork":false,"url":"https://api.github.com/repos/aerogear/aerogear-android-push","forks_url":"https://api.github.com/repos/aerogear/aerogear-android-push/forks","keys_url":"https://api.github.com/repos/aerogear/aerogear-android-push/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aerogear/aerogear-android-push/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aerogear/aerogear-android-push/teams","hooks_url":"https://api.github.com/repos/aerogear/aerogear-android-push/hooks","issue_events_url":"https://api.github.com/repos/aerogear/aerogear-android-push/issues/events{/number}","events_url":"https://api.github.com/repos/aerogear/aerogear-android-push/events","assignees_url":"https://api.github.com/repos/aerogear/aerogear-android-push/assignees{/user}","branches_url":"https://api.github.com/repos/aerogear/aerogear-android-push/branches{/branch}","tags_url":"https://api.github.com/repos/aerogear/aerogear-android-push/tags","blobs_url":"https://api.github.com/repos/aerogear/aerogear-android-push/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aerogear/aerogear-android-push/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aerogear/aerogear-android-push/git/refs{/sha}","trees_url":"https://api.github.com/repos/aerogear/aerogear-android-push/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aerogear/aerogear-android-push/statuses/{sha}","languages_url":"https://api.github.com/repos/aerogear/aerogear-android-push/languages","stargazers_url":"https://api.github.com/repos/aerogear/aerogear-android-push/stargazers","contributors_url":"https://api.github.com/repos/aerogear/aerogear-android-push/contributors","subscribers_url":"https://api.github.com/repos/aerogear/aerogear-android-push/subscribers","subscription_url":"https://api.github.com/repos/aerogear/aerogear-android-push/subscription","commits_url":"https://api.github.com/repos/aerogear/aerogear-android-push/commits{/sha}","git_commits_url":"https://api.github.com/repos/aerogear/aerogear-android-push/git/commits{/sha}","comments_url":"https://api.github.com/repos/aerogear/aerogear-android-push/comments{/number}","issue_comment_url":"https://api.github.com/repos/aerogear/aerogear-android-push/issues/comments{/number}","contents_url":"https://api.github.com/repos/aerogear/aerogear-android-push/contents/{+path}","compare_url":"https://api.github.com/repos/aerogear/aerogear-android-push/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aerogear/aerogear-android-push/merges","archive_url":"https://api.github.com/repos/aerogear/aerogear-android-push/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aerogear/aerogear-android-push/downloads","issues_url":"https://api.github.com/repos/aerogear/aerogear-android-push/issues{/number}","pulls_url":"https://api.github.com/repos/aerogear/aerogear-android-push/pulls{/number}","milestones_url":"https://api.github.com/repos/aerogear/aerogear-android-push/milestones{/number}","notifications_url":"https://api.github.com/repos/aerogear/aerogear-android-push/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aerogear/aerogear-android-push/labels{/name}","releases_url":"https://api.github.com/repos/aerogear/aerogear-android-push/releases{/id}","deployments_url":"https://api.github.com/repos/aerogear/aerogear-android-push/deployments","created_at":"2014-04-11T07:06:02Z","updated_at":"2016-03-29T14:21:13Z","pushed_at":"2016-04-20T15:35:38Z","git_url":"git://github.com/aerogear/aerogear-android-push.git","ssh_url":"git@github.com:aerogear/aerogear-android-push.git","clone_url":"https://github.com/aerogear/aerogear-android-push.git","svn_url":"https://github.com/aerogear/aerogear-android-push","homepage":"","size":416,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":1,"forks":24,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aerogear/aerogear-android-push/pulls/50"},"html":{"href":"https://github.com/aerogear/aerogear-android-push/pull/50"},"issue":{"href":"https://api.github.com/repos/aerogear/aerogear-android-push/issues/50"},"comments":{"href":"https://api.github.com/repos/aerogear/aerogear-android-push/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/aerogear/aerogear-android-push/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/aerogear/aerogear-android-push/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aerogear/aerogear-android-push/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/aerogear/aerogear-android-push/statuses/f761998e0d659af94810a4bcaf1b036cb64a060d"}}}}