{"action":"created","comment":{"url":"https://api.github.com/repos/PowerShell/PowerShell/pulls/comments/89418231","pull_request_review_id":9964026,"id":89418231,"diff_hunk":"@@ -435,7 +435,11 @@ function Invoke-AppveyorFinish\n             Publish-NuGetFeed -OutputPath .\\nuget-artifacts -VersionSuffix $preReleaseVersion\n         }\n \n-        $artifacts += (Get-ChildItem .\\nuget-artifacts -ErrorAction SilentlyContinue | ForEach-Object {$_.FullName})\n+        $nugetArtifacts = Get-ChildItem .\\nuget-artifacts -ErrorAction SilentlyContinue\n+        foreach($artifact in $nugetArtifacts)\n+        {\n+            $null = $artifacts.Add($artifact.FullName)\n+        }","path":"tools/appveyor.psm1","position":46,"original_position":46,"commit_id":"d5c5dbbbd7b7c3ff774f098052f0d13ffbd5a6f1","original_commit_id":"d5c5dbbbd7b7c3ff774f098052f0d13ffbd5a6f1","user":{"login":"daxian-dbw","id":127450,"avatar_url":"https://avatars.githubusercontent.com/u/127450?v=3","gravatar_id":"","url":"https://api.github.com/users/daxian-dbw","html_url":"https://github.com/daxian-dbw","followers_url":"https://api.github.com/users/daxian-dbw/followers","following_url":"https://api.github.com/users/daxian-dbw/following{/other_user}","gists_url":"https://api.github.com/users/daxian-dbw/gists{/gist_id}","starred_url":"https://api.github.com/users/daxian-dbw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daxian-dbw/subscriptions","organizations_url":"https://api.github.com/users/daxian-dbw/orgs","repos_url":"https://api.github.com/users/daxian-dbw/repos","events_url":"https://api.github.com/users/daxian-dbw/events{/privacy}","received_events_url":"https://api.github.com/users/daxian-dbw/received_events","type":"User","site_admin":false},"body":"How about `$artifacts.AddRange`? It's faster for adding a collection of objects and it doesn't return anything. ","created_at":"2016-11-24T00:05:59Z","updated_at":"2016-11-24T00:05:59Z","html_url":"https://github.com/PowerShell/PowerShell/pull/2776#discussion_r89418231","pull_request_url":"https://api.github.com/repos/PowerShell/PowerShell/pulls/2776","_links":{"self":{"href":"https://api.github.com/repos/PowerShell/PowerShell/pulls/comments/89418231"},"html":{"href":"https://github.com/PowerShell/PowerShell/pull/2776#discussion_r89418231"},"pull_request":{"href":"https://api.github.com/repos/PowerShell/PowerShell/pulls/2776"}}},"pull_request":{"url":"https://api.github.com/repos/PowerShell/PowerShell/pulls/2776","id":95095251,"html_url":"https://github.com/PowerShell/PowerShell/pull/2776","diff_url":"https://github.com/PowerShell/PowerShell/pull/2776.diff","patch_url":"https://github.com/PowerShell/PowerShell/pull/2776.patch","issue_url":"https://api.github.com/repos/PowerShell/PowerShell/issues/2776","number":2776,"state":"open","locked":false,"title":"Assigned all ArrayList.Add() to $null","user":{"login":"adityapatwardhan","id":12820925,"avatar_url":"https://avatars.githubusercontent.com/u/12820925?v=3","gravatar_id":"","url":"https://api.github.com/users/adityapatwardhan","html_url":"https://github.com/adityapatwardhan","followers_url":"https://api.github.com/users/adityapatwardhan/followers","following_url":"https://api.github.com/users/adityapatwardhan/following{/other_user}","gists_url":"https://api.github.com/users/adityapatwardhan/gists{/gist_id}","starred_url":"https://api.github.com/users/adityapatwardhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adityapatwardhan/subscriptions","organizations_url":"https://api.github.com/users/adityapatwardhan/orgs","repos_url":"https://api.github.com/users/adityapatwardhan/repos","events_url":"https://api.github.com/users/adityapatwardhan/events{/privacy}","received_events_url":"https://api.github.com/users/adityapatwardhan/received_events","type":"User","site_admin":false},"body":"ArrayList.Add() returns the array list size after the add. This causes the\r\nvalue to be thrown on the pipeline. Assigning them to $null as we do not\r\nneed to know the size after addition. This causes errors and unnecessary\r\noutput on the AppVeyor console.","created_at":"2016-11-23T23:23:53Z","updated_at":"2016-11-24T00:05:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f9e4daacdc8a9d95321a623b3a0478b73aa3698","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/PowerShell/PowerShell/pulls/2776/commits","review_comments_url":"https://api.github.com/repos/PowerShell/PowerShell/pulls/2776/comments","review_comment_url":"https://api.github.com/repos/PowerShell/PowerShell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PowerShell/PowerShell/issues/2776/comments","statuses_url":"https://api.github.com/repos/PowerShell/PowerShell/statuses/d5c5dbbbd7b7c3ff774f098052f0d13ffbd5a6f1","head":{"label":"adityapatwardhan:CodeCoverageBuildIssues","ref":"CodeCoverageBuildIssues","sha":"d5c5dbbbd7b7c3ff774f098052f0d13ffbd5a6f1","user":{"login":"adityapatwardhan","id":12820925,"avatar_url":"https://avatars.githubusercontent.com/u/12820925?v=3","gravatar_id":"","url":"https://api.github.com/users/adityapatwardhan","html_url":"https://github.com/adityapatwardhan","followers_url":"https://api.github.com/users/adityapatwardhan/followers","following_url":"https://api.github.com/users/adityapatwardhan/following{/other_user}","gists_url":"https://api.github.com/users/adityapatwardhan/gists{/gist_id}","starred_url":"https://api.github.com/users/adityapatwardhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adityapatwardhan/subscriptions","organizations_url":"https://api.github.com/users/adityapatwardhan/orgs","repos_url":"https://api.github.com/users/adityapatwardhan/repos","events_url":"https://api.github.com/users/adityapatwardhan/events{/privacy}","received_events_url":"https://api.github.com/users/adityapatwardhan/received_events","type":"User","site_admin":false},"repo":{"id":68341554,"name":"PowerShell","full_name":"adityapatwardhan/PowerShell","owner":{"login":"adityapatwardhan","id":12820925,"avatar_url":"https://avatars.githubusercontent.com/u/12820925?v=3","gravatar_id":"","url":"https://api.github.com/users/adityapatwardhan","html_url":"https://github.com/adityapatwardhan","followers_url":"https://api.github.com/users/adityapatwardhan/followers","following_url":"https://api.github.com/users/adityapatwardhan/following{/other_user}","gists_url":"https://api.github.com/users/adityapatwardhan/gists{/gist_id}","starred_url":"https://api.github.com/users/adityapatwardhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adityapatwardhan/subscriptions","organizations_url":"https://api.github.com/users/adityapatwardhan/orgs","repos_url":"https://api.github.com/users/adityapatwardhan/repos","events_url":"https://api.github.com/users/adityapatwardhan/events{/privacy}","received_events_url":"https://api.github.com/users/adityapatwardhan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adityapatwardhan/PowerShell","description":"PowerShell for every system!","fork":true,"url":"https://api.github.com/repos/adityapatwardhan/PowerShell","forks_url":"https://api.github.com/repos/adityapatwardhan/PowerShell/forks","keys_url":"https://api.github.com/repos/adityapatwardhan/PowerShell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adityapatwardhan/PowerShell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adityapatwardhan/PowerShell/teams","hooks_url":"https://api.github.com/repos/adityapatwardhan/PowerShell/hooks","issue_events_url":"https://api.github.com/repos/adityapatwardhan/PowerShell/issues/events{/number}","events_url":"https://api.github.com/repos/adityapatwardhan/PowerShell/events","assignees_url":"https://api.github.com/repos/adityapatwardhan/PowerShell/assignees{/user}","branches_url":"https://api.github.com/repos/adityapatwardhan/PowerShell/branches{/branch}","tags_url":"https://api.github.com/repos/adityapatwardhan/PowerShell/tags","blobs_url":"https://api.github.com/repos/adityapatwardhan/PowerShell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adityapatwardhan/PowerShell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adityapatwardhan/PowerShell/git/refs{/sha}","trees_url":"https://api.github.com/repos/adityapatwardhan/PowerShell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adityapatwardhan/PowerShell/statuses/{sha}","languages_url":"https://api.github.com/repos/adityapatwardhan/PowerShell/languages","stargazers_url":"https://api.github.com/repos/adityapatwardhan/PowerShell/stargazers","contributors_url":"https://api.github.com/repos/adityapatwardhan/PowerShell/contributors","subscribers_url":"https://api.github.com/repos/adityapatwardhan/PowerShell/subscribers","subscription_url":"https://api.github.com/repos/adityapatwardhan/PowerShell/subscription","commits_url":"https://api.github.com/repos/adityapatwardhan/PowerShell/commits{/sha}","git_commits_url":"https://api.github.com/repos/adityapatwardhan/PowerShell/git/commits{/sha}","comments_url":"https://api.github.com/repos/adityapatwardhan/PowerShell/comments{/number}","issue_comment_url":"https://api.github.com/repos/adityapatwardhan/PowerShell/issues/comments{/number}","contents_url":"https://api.github.com/repos/adityapatwardhan/PowerShell/contents/{+path}","compare_url":"https://api.github.com/repos/adityapatwardhan/PowerShell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adityapatwardhan/PowerShell/merges","archive_url":"https://api.github.com/repos/adityapatwardhan/PowerShell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adityapatwardhan/PowerShell/downloads","issues_url":"https://api.github.com/repos/adityapatwardhan/PowerShell/issues{/number}","pulls_url":"https://api.github.com/repos/adityapatwardhan/PowerShell/pulls{/number}","milestones_url":"https://api.github.com/repos/adityapatwardhan/PowerShell/milestones{/number}","notifications_url":"https://api.github.com/repos/adityapatwardhan/PowerShell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adityapatwardhan/PowerShell/labels{/name}","releases_url":"https://api.github.com/repos/adityapatwardhan/PowerShell/releases{/id}","deployments_url":"https://api.github.com/repos/adityapatwardhan/PowerShell/deployments","created_at":"2016-09-16T00:19:53Z","updated_at":"2016-09-16T00:20:02Z","pushed_at":"2016-11-24T00:02:24Z","git_url":"git://github.com/adityapatwardhan/PowerShell.git","ssh_url":"git@github.com:adityapatwardhan/PowerShell.git","clone_url":"https://github.com/adityapatwardhan/PowerShell.git","svn_url":"https://github.com/adityapatwardhan/PowerShell","homepage":"https://microsoft.com/powershell","size":20912,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PowerShell:master","ref":"master","sha":"6f92140886a328f60c7e59bb0e1ad5922246a679","user":{"login":"PowerShell","id":11524380,"avatar_url":"https://avatars.githubusercontent.com/u/11524380?v=3","gravatar_id":"","url":"https://api.github.com/users/PowerShell","html_url":"https://github.com/PowerShell","followers_url":"https://api.github.com/users/PowerShell/followers","following_url":"https://api.github.com/users/PowerShell/following{/other_user}","gists_url":"https://api.github.com/users/PowerShell/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerShell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerShell/subscriptions","organizations_url":"https://api.github.com/users/PowerShell/orgs","repos_url":"https://api.github.com/users/PowerShell/repos","events_url":"https://api.github.com/users/PowerShell/events{/privacy}","received_events_url":"https://api.github.com/users/PowerShell/received_events","type":"Organization","site_admin":false},"repo":{"id":49609581,"name":"PowerShell","full_name":"PowerShell/PowerShell","owner":{"login":"PowerShell","id":11524380,"avatar_url":"https://avatars.githubusercontent.com/u/11524380?v=3","gravatar_id":"","url":"https://api.github.com/users/PowerShell","html_url":"https://github.com/PowerShell","followers_url":"https://api.github.com/users/PowerShell/followers","following_url":"https://api.github.com/users/PowerShell/following{/other_user}","gists_url":"https://api.github.com/users/PowerShell/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerShell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerShell/subscriptions","organizations_url":"https://api.github.com/users/PowerShell/orgs","repos_url":"https://api.github.com/users/PowerShell/repos","events_url":"https://api.github.com/users/PowerShell/events{/privacy}","received_events_url":"https://api.github.com/users/PowerShell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PowerShell/PowerShell","description":"PowerShell for every system!","fork":false,"url":"https://api.github.com/repos/PowerShell/PowerShell","forks_url":"https://api.github.com/repos/PowerShell/PowerShell/forks","keys_url":"https://api.github.com/repos/PowerShell/PowerShell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PowerShell/PowerShell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PowerShell/PowerShell/teams","hooks_url":"https://api.github.com/repos/PowerShell/PowerShell/hooks","issue_events_url":"https://api.github.com/repos/PowerShell/PowerShell/issues/events{/number}","events_url":"https://api.github.com/repos/PowerShell/PowerShell/events","assignees_url":"https://api.github.com/repos/PowerShell/PowerShell/assignees{/user}","branches_url":"https://api.github.com/repos/PowerShell/PowerShell/branches{/branch}","tags_url":"https://api.github.com/repos/PowerShell/PowerShell/tags","blobs_url":"https://api.github.com/repos/PowerShell/PowerShell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PowerShell/PowerShell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PowerShell/PowerShell/git/refs{/sha}","trees_url":"https://api.github.com/repos/PowerShell/PowerShell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PowerShell/PowerShell/statuses/{sha}","languages_url":"https://api.github.com/repos/PowerShell/PowerShell/languages","stargazers_url":"https://api.github.com/repos/PowerShell/PowerShell/stargazers","contributors_url":"https://api.github.com/repos/PowerShell/PowerShell/contributors","subscribers_url":"https://api.github.com/repos/PowerShell/PowerShell/subscribers","subscription_url":"https://api.github.com/repos/PowerShell/PowerShell/subscription","commits_url":"https://api.github.com/repos/PowerShell/PowerShell/commits{/sha}","git_commits_url":"https://api.github.com/repos/PowerShell/PowerShell/git/commits{/sha}","comments_url":"https://api.github.com/repos/PowerShell/PowerShell/comments{/number}","issue_comment_url":"https://api.github.com/repos/PowerShell/PowerShell/issues/comments{/number}","contents_url":"https://api.github.com/repos/PowerShell/PowerShell/contents/{+path}","compare_url":"https://api.github.com/repos/PowerShell/PowerShell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PowerShell/PowerShell/merges","archive_url":"https://api.github.com/repos/PowerShell/PowerShell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PowerShell/PowerShell/downloads","issues_url":"https://api.github.com/repos/PowerShell/PowerShell/issues{/number}","pulls_url":"https://api.github.com/repos/PowerShell/PowerShell/pulls{/number}","milestones_url":"https://api.github.com/repos/PowerShell/PowerShell/milestones{/number}","notifications_url":"https://api.github.com/repos/PowerShell/PowerShell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PowerShell/PowerShell/labels{/name}","releases_url":"https://api.github.com/repos/PowerShell/PowerShell/releases{/id}","deployments_url":"https://api.github.com/repos/PowerShell/PowerShell/deployments","created_at":"2016-01-13T23:41:35Z","updated_at":"2016-11-23T19:49:49Z","pushed_at":"2016-11-24T00:02:25Z","git_url":"git://github.com/PowerShell/PowerShell.git","ssh_url":"git@github.com:PowerShell/PowerShell.git","clone_url":"https://github.com/PowerShell/PowerShell.git","svn_url":"https://github.com/PowerShell/PowerShell","homepage":"https://microsoft.com/powershell","size":28118,"stargazers_count":5644,"watchers_count":5644,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":664,"mirror_url":null,"open_issues_count":502,"forks":664,"open_issues":502,"watchers":5644,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PowerShell/PowerShell/pulls/2776"},"html":{"href":"https://github.com/PowerShell/PowerShell/pull/2776"},"issue":{"href":"https://api.github.com/repos/PowerShell/PowerShell/issues/2776"},"comments":{"href":"https://api.github.com/repos/PowerShell/PowerShell/issues/2776/comments"},"review_comments":{"href":"https://api.github.com/repos/PowerShell/PowerShell/pulls/2776/comments"},"review_comment":{"href":"https://api.github.com/repos/PowerShell/PowerShell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PowerShell/PowerShell/pulls/2776/commits"},"statuses":{"href":"https://api.github.com/repos/PowerShell/PowerShell/statuses/d5c5dbbbd7b7c3ff774f098052f0d13ffbd5a6f1"}}}}
{"actor":{"display_login":"daxian-dbw"}}