{"action":"created","comment":{"url":"https://api.github.com/repos/tgstation/tgstation/pulls/comments/72031662","id":72031662,"diff_hunk":"@@ -427,8 +427,7 @@\n \t\t\t\tL.fix()\n \n \t\tif(\"floorlava\")\n-\t\t\tvar/datum/weather/floor_is_lava/storm = new /datum/weather/floor_is_lava\n-\t\t\tstorm.weather_start_up()\n+\t\t\tSSweather.run_weather(\"the floor is lava\")","path":"code/modules/admin/secrets.dm","position":6,"original_position":6,"commit_id":"aca8af90a551fb73ed4015c375d6e79cbee17478","original_commit_id":"aca8af90a551fb73ed4015c375d6e79cbee17478","user":{"login":"xxalpha","id":4951579,"avatar_url":"https://avatars.githubusercontent.com/u/4951579?v=3","gravatar_id":"","url":"https://api.github.com/users/xxalpha","html_url":"https://github.com/xxalpha","followers_url":"https://api.github.com/users/xxalpha/followers","following_url":"https://api.github.com/users/xxalpha/following{/other_user}","gists_url":"https://api.github.com/users/xxalpha/gists{/gist_id}","starred_url":"https://api.github.com/users/xxalpha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xxalpha/subscriptions","organizations_url":"https://api.github.com/users/xxalpha/orgs","repos_url":"https://api.github.com/users/xxalpha/repos","events_url":"https://api.github.com/users/xxalpha/events{/privacy}","received_events_url":"https://api.github.com/users/xxalpha/received_events","type":"User","site_admin":false},"body":"Yes, number values with descriptive defines. There is no reason to use strings for this sort of stuff.","created_at":"2016-07-25T09:13:09Z","updated_at":"2016-07-25T09:13:09Z","html_url":"https://github.com/tgstation/tgstation/pull/19003#discussion_r72031662","pull_request_url":"https://api.github.com/repos/tgstation/tgstation/pulls/19003","_links":{"self":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/comments/72031662"},"html":{"href":"https://github.com/tgstation/tgstation/pull/19003#discussion_r72031662"},"pull_request":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/19003"}}},"pull_request":{"url":"https://api.github.com/repos/tgstation/tgstation/pulls/19003","id":75560148,"html_url":"https://github.com/tgstation/tgstation/pull/19003","diff_url":"https://github.com/tgstation/tgstation/pull/19003.diff","patch_url":"https://github.com/tgstation/tgstation/pull/19003.patch","issue_url":"https://api.github.com/repos/tgstation/tgstation/issues/19003","number":19003,"state":"closed","locked":false,"title":"Refactors weather into a subsystem","user":{"login":"Xhuis","id":15898043,"avatar_url":"https://avatars.githubusercontent.com/u/15898043?v=3","gravatar_id":"","url":"https://api.github.com/users/Xhuis","html_url":"https://github.com/Xhuis","followers_url":"https://api.github.com/users/Xhuis/followers","following_url":"https://api.github.com/users/Xhuis/following{/other_user}","gists_url":"https://api.github.com/users/Xhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/Xhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xhuis/subscriptions","organizations_url":"https://api.github.com/users/Xhuis/orgs","repos_url":"https://api.github.com/users/Xhuis/repos","events_url":"https://api.github.com/users/Xhuis/events{/privacy}","received_events_url":"https://api.github.com/users/Xhuis/received_events","type":"User","site_admin":false},"body":"Weather has been refactored from a weather control machine on the lavaland z-level into a subsystem. All existing weather has been changed to accommodate this change, and their code has been optimized by using `addtimer()` instead of `sleep()`.\r\n\r\nThe new subsystem also supports adding weather to any z-level; for instance, if you made a weather called `/datum/weather/rain_storm` and made it target z-level 3 with a 100% probability, the rain storm would occur as much as possible with 5-10 minute intermissions. These intermissions take into account the weather's duration.\r\n","created_at":"2016-06-28T22:19:20Z","updated_at":"2016-07-25T09:13:09Z","closed_at":"2016-07-04T01:55:36Z","merged_at":"2016-07-04T01:55:36Z","merge_commit_sha":"2ab3f554d9e03caa55747b8d08fc24b2ff5dfabe","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/tgstation/tgstation/pulls/19003/commits","review_comments_url":"https://api.github.com/repos/tgstation/tgstation/pulls/19003/comments","review_comment_url":"https://api.github.com/repos/tgstation/tgstation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tgstation/tgstation/issues/19003/comments","statuses_url":"https://api.github.com/repos/tgstation/tgstation/statuses/aca8af90a551fb73ed4015c375d6e79cbee17478","head":{"label":"Xhuis:weather_subsystem","ref":"weather_subsystem","sha":"aca8af90a551fb73ed4015c375d6e79cbee17478","user":{"login":"Xhuis","id":15898043,"avatar_url":"https://avatars.githubusercontent.com/u/15898043?v=3","gravatar_id":"","url":"https://api.github.com/users/Xhuis","html_url":"https://github.com/Xhuis","followers_url":"https://api.github.com/users/Xhuis/followers","following_url":"https://api.github.com/users/Xhuis/following{/other_user}","gists_url":"https://api.github.com/users/Xhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/Xhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xhuis/subscriptions","organizations_url":"https://api.github.com/users/Xhuis/orgs","repos_url":"https://api.github.com/users/Xhuis/repos","events_url":"https://api.github.com/users/Xhuis/events{/privacy}","received_events_url":"https://api.github.com/users/Xhuis/received_events","type":"User","site_admin":false},"repo":{"id":46378360,"name":"-tg-station","full_name":"Xhuis/-tg-station","owner":{"login":"Xhuis","id":15898043,"avatar_url":"https://avatars.githubusercontent.com/u/15898043?v=3","gravatar_id":"","url":"https://api.github.com/users/Xhuis","html_url":"https://github.com/Xhuis","followers_url":"https://api.github.com/users/Xhuis/followers","following_url":"https://api.github.com/users/Xhuis/following{/other_user}","gists_url":"https://api.github.com/users/Xhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/Xhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xhuis/subscriptions","organizations_url":"https://api.github.com/users/Xhuis/orgs","repos_url":"https://api.github.com/users/Xhuis/repos","events_url":"https://api.github.com/users/Xhuis/events{/privacy}","received_events_url":"https://api.github.com/users/Xhuis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Xhuis/-tg-station","description":"the /tg/station branch of SS13","fork":true,"url":"https://api.github.com/repos/Xhuis/-tg-station","forks_url":"https://api.github.com/repos/Xhuis/-tg-station/forks","keys_url":"https://api.github.com/repos/Xhuis/-tg-station/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Xhuis/-tg-station/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Xhuis/-tg-station/teams","hooks_url":"https://api.github.com/repos/Xhuis/-tg-station/hooks","issue_events_url":"https://api.github.com/repos/Xhuis/-tg-station/issues/events{/number}","events_url":"https://api.github.com/repos/Xhuis/-tg-station/events","assignees_url":"https://api.github.com/repos/Xhuis/-tg-station/assignees{/user}","branches_url":"https://api.github.com/repos/Xhuis/-tg-station/branches{/branch}","tags_url":"https://api.github.com/repos/Xhuis/-tg-station/tags","blobs_url":"https://api.github.com/repos/Xhuis/-tg-station/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Xhuis/-tg-station/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Xhuis/-tg-station/git/refs{/sha}","trees_url":"https://api.github.com/repos/Xhuis/-tg-station/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Xhuis/-tg-station/statuses/{sha}","languages_url":"https://api.github.com/repos/Xhuis/-tg-station/languages","stargazers_url":"https://api.github.com/repos/Xhuis/-tg-station/stargazers","contributors_url":"https://api.github.com/repos/Xhuis/-tg-station/contributors","subscribers_url":"https://api.github.com/repos/Xhuis/-tg-station/subscribers","subscription_url":"https://api.github.com/repos/Xhuis/-tg-station/subscription","commits_url":"https://api.github.com/repos/Xhuis/-tg-station/commits{/sha}","git_commits_url":"https://api.github.com/repos/Xhuis/-tg-station/git/commits{/sha}","comments_url":"https://api.github.com/repos/Xhuis/-tg-station/comments{/number}","issue_comment_url":"https://api.github.com/repos/Xhuis/-tg-station/issues/comments{/number}","contents_url":"https://api.github.com/repos/Xhuis/-tg-station/contents/{+path}","compare_url":"https://api.github.com/repos/Xhuis/-tg-station/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Xhuis/-tg-station/merges","archive_url":"https://api.github.com/repos/Xhuis/-tg-station/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Xhuis/-tg-station/downloads","issues_url":"https://api.github.com/repos/Xhuis/-tg-station/issues{/number}","pulls_url":"https://api.github.com/repos/Xhuis/-tg-station/pulls{/number}","milestones_url":"https://api.github.com/repos/Xhuis/-tg-station/milestones{/number}","notifications_url":"https://api.github.com/repos/Xhuis/-tg-station/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Xhuis/-tg-station/labels{/name}","releases_url":"https://api.github.com/repos/Xhuis/-tg-station/releases{/id}","deployments_url":"https://api.github.com/repos/Xhuis/-tg-station/deployments","created_at":"2015-11-17T22:04:37Z","updated_at":"2016-03-10T22:19:11Z","pushed_at":"2016-07-21T02:46:11Z","git_url":"git://github.com/Xhuis/-tg-station.git","ssh_url":"git@github.com:Xhuis/-tg-station.git","clone_url":"https://github.com/Xhuis/-tg-station.git","svn_url":"https://github.com/Xhuis/-tg-station","homepage":"http://www.tgstation13.org/","size":630257,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tgstation:master","ref":"master","sha":"09435d9d2770eafb41204d3b38cd1c84504707a6","user":{"login":"tgstation","id":1363778,"avatar_url":"https://avatars.githubusercontent.com/u/1363778?v=3","gravatar_id":"","url":"https://api.github.com/users/tgstation","html_url":"https://github.com/tgstation","followers_url":"https://api.github.com/users/tgstation/followers","following_url":"https://api.github.com/users/tgstation/following{/other_user}","gists_url":"https://api.github.com/users/tgstation/gists{/gist_id}","starred_url":"https://api.github.com/users/tgstation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgstation/subscriptions","organizations_url":"https://api.github.com/users/tgstation/orgs","repos_url":"https://api.github.com/users/tgstation/repos","events_url":"https://api.github.com/users/tgstation/events{/privacy}","received_events_url":"https://api.github.com/users/tgstation/received_events","type":"Organization","site_admin":false},"repo":{"id":3234987,"name":"tgstation","full_name":"tgstation/tgstation","owner":{"login":"tgstation","id":1363778,"avatar_url":"https://avatars.githubusercontent.com/u/1363778?v=3","gravatar_id":"","url":"https://api.github.com/users/tgstation","html_url":"https://github.com/tgstation","followers_url":"https://api.github.com/users/tgstation/followers","following_url":"https://api.github.com/users/tgstation/following{/other_user}","gists_url":"https://api.github.com/users/tgstation/gists{/gist_id}","starred_url":"https://api.github.com/users/tgstation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgstation/subscriptions","organizations_url":"https://api.github.com/users/tgstation/orgs","repos_url":"https://api.github.com/users/tgstation/repos","events_url":"https://api.github.com/users/tgstation/events{/privacy}","received_events_url":"https://api.github.com/users/tgstation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tgstation/tgstation","description":"the /tg/station branch of SS13","fork":false,"url":"https://api.github.com/repos/tgstation/tgstation","forks_url":"https://api.github.com/repos/tgstation/tgstation/forks","keys_url":"https://api.github.com/repos/tgstation/tgstation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tgstation/tgstation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tgstation/tgstation/teams","hooks_url":"https://api.github.com/repos/tgstation/tgstation/hooks","issue_events_url":"https://api.github.com/repos/tgstation/tgstation/issues/events{/number}","events_url":"https://api.github.com/repos/tgstation/tgstation/events","assignees_url":"https://api.github.com/repos/tgstation/tgstation/assignees{/user}","branches_url":"https://api.github.com/repos/tgstation/tgstation/branches{/branch}","tags_url":"https://api.github.com/repos/tgstation/tgstation/tags","blobs_url":"https://api.github.com/repos/tgstation/tgstation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tgstation/tgstation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tgstation/tgstation/git/refs{/sha}","trees_url":"https://api.github.com/repos/tgstation/tgstation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tgstation/tgstation/statuses/{sha}","languages_url":"https://api.github.com/repos/tgstation/tgstation/languages","stargazers_url":"https://api.github.com/repos/tgstation/tgstation/stargazers","contributors_url":"https://api.github.com/repos/tgstation/tgstation/contributors","subscribers_url":"https://api.github.com/repos/tgstation/tgstation/subscribers","subscription_url":"https://api.github.com/repos/tgstation/tgstation/subscription","commits_url":"https://api.github.com/repos/tgstation/tgstation/commits{/sha}","git_commits_url":"https://api.github.com/repos/tgstation/tgstation/git/commits{/sha}","comments_url":"https://api.github.com/repos/tgstation/tgstation/comments{/number}","issue_comment_url":"https://api.github.com/repos/tgstation/tgstation/issues/comments{/number}","contents_url":"https://api.github.com/repos/tgstation/tgstation/contents/{+path}","compare_url":"https://api.github.com/repos/tgstation/tgstation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tgstation/tgstation/merges","archive_url":"https://api.github.com/repos/tgstation/tgstation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tgstation/tgstation/downloads","issues_url":"https://api.github.com/repos/tgstation/tgstation/issues{/number}","pulls_url":"https://api.github.com/repos/tgstation/tgstation/pulls{/number}","milestones_url":"https://api.github.com/repos/tgstation/tgstation/milestones{/number}","notifications_url":"https://api.github.com/repos/tgstation/tgstation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tgstation/tgstation/labels{/name}","releases_url":"https://api.github.com/repos/tgstation/tgstation/releases{/id}","deployments_url":"https://api.github.com/repos/tgstation/tgstation/deployments","created_at":"2012-01-21T17:32:47Z","updated_at":"2016-07-24T09:53:53Z","pushed_at":"2016-07-25T09:12:38Z","git_url":"git://github.com/tgstation/tgstation.git","ssh_url":"git@github.com:tgstation/tgstation.git","clone_url":"https://github.com/tgstation/tgstation.git","svn_url":"https://github.com/tgstation/tgstation","homepage":"http://www.tgstation13.org/","size":910378,"stargazers_count":308,"watchers_count":308,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1105,"mirror_url":null,"open_issues_count":797,"forks":1105,"open_issues":797,"watchers":308,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/19003"},"html":{"href":"https://github.com/tgstation/tgstation/pull/19003"},"issue":{"href":"https://api.github.com/repos/tgstation/tgstation/issues/19003"},"comments":{"href":"https://api.github.com/repos/tgstation/tgstation/issues/19003/comments"},"review_comments":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/19003/comments"},"review_comment":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tgstation/tgstation/pulls/19003/commits"},"statuses":{"href":"https://api.github.com/repos/tgstation/tgstation/statuses/aca8af90a551fb73ed4015c375d6e79cbee17478"}}}}
{"actor":{"display_login":"xxalpha"}}