{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/11814","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/11814/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/11814/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/11814/events","html_url":"https://github.com/openshift/origin/pull/11814","id":187786505,"number":11814,"title":"oadm ca: add --expire-days option","user":{"login":"php-coder","id":87088,"avatar_url":"https://avatars.githubusercontent.com/u/87088?v=3","gravatar_id":"","url":"https://api.github.com/users/php-coder","html_url":"https://github.com/php-coder","followers_url":"https://api.github.com/users/php-coder/followers","following_url":"https://api.github.com/users/php-coder/following{/other_user}","gists_url":"https://api.github.com/users/php-coder/gists{/gist_id}","starred_url":"https://api.github.com/users/php-coder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-coder/subscriptions","organizations_url":"https://api.github.com/users/php-coder/orgs","repos_url":"https://api.github.com/users/php-coder/repos","events_url":"https://api.github.com/users/php-coder/events{/privacy}","received_events_url":"https://api.github.com/users/php-coder/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/openshift/origin/milestones/17","html_url":"https://github.com/openshift/origin/milestones/1.5.0","labels_url":"https://api.github.com/repos/openshift/origin/milestones/17/labels","id":2049440,"number":17,"title":"1.5.0","description":null,"creator":{"login":"soltysh","id":576341,"avatar_url":"https://avatars.githubusercontent.com/u/576341?v=3","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false},"open_issues":42,"closed_issues":8,"state":"open","created_at":"2016-10-05T12:16:28Z","updated_at":"2016-11-21T08:45:25Z","due_on":null,"closed_at":null},"comments":25,"created_at":"2016-11-07T18:12:37Z","updated_at":"2016-11-21T16:13:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/11814","html_url":"https://github.com/openshift/origin/pull/11814","diff_url":"https://github.com/openshift/origin/pull/11814.diff","patch_url":"https://github.com/openshift/origin/pull/11814.patch"},"body":"This PR adds `--expire-days` option to `osadm ca` sub commands. By default, generated certificates expire in 2 years (5 in case of CA certificate), but with this option user is able to specify any number of days.\r\n\r\nExample:\r\n```console\r\n$ oadm ca create-server-cert -h | grep expire\r\n      --expire-days=730: Validity of the certificate in days (defaults to 2 years). WARNING: extending this above default value is highly discouraged.\r\n$ sudo `which oadm` ca create-server-cert \\\r\n    --hostnames=one.example.org,two.example.org \\\r\n    --cert example.org.crt \\\r\n    --key example.org.key \\\r\n    --signer-cert=$CA/ca.crt \\\r\n    --signer-key=$CA/ca.key \\\r\n    --signer-serial=$CA/ca.serial.txt \\\r\n    --expire-days=60\r\n$ openssl x509 -in example.org.crt -text | head -9 | tail -3\r\nValidity\r\n            Not Before: Nov  8 12:22:51 2016 GMT\r\n            Not After : Jan  7 12:22:52 2017 GMT\r\n```\r\n\r\nWhen user specified validity period greater than default number of years, command will show warning:\r\n```console\r\n$ oadm ca create-master-certs --hostnames=example.org --expire-days=$[365*2+1]\r\nWARNING: Validity period of the certificate for \"system:openshift-node-admin\" is greater than 2 years!\r\nWARNING: By security reasons it is strongly recommended to change this period and make it smaller!\r\nWARNING: Validity period of the certificate for \"system:openshift-master\" is greater than 2 years!\r\nWARNING: By security reasons it is strongly recommended to change this period and make it smaller!\r\nGenerated new key pair as openshift.local.config/master/serviceaccounts.public.key and\r\nopenshift.local.config/master/serviceaccounts.private.key\r\nWARNING: Validity period of the certificate for \"example.org\" is greater than 2 years!\r\nWARNING: By security reasons it is strongly recommended to change this period and make it smaller!\r\nWARNING: Validity period of the certificate for \"system:master\" is greater than 2 years!\r\nWARNING: By security reasons it is strongly recommended to change this period and make it smaller!\r\nWARNING: Validity period of the certificate for \"system:master-proxy\" is greater than 2 years!\r\nWARNING: By security reasons it is strongly recommended to change this period and make it smaller!\r\nWARNING: Validity period of the certificate for \"example.org\" is greater than 2 years!\r\nWARNING: By security reasons it is strongly recommended to change this period and make it smaller!\r\nWARNING: Validity period of the certificate for \"system:admin\" is greater than 2 years!\r\nWARNING: By security reasons it is strongly recommended to change this period and make it smaller!\r\nWARNING: Validity period of the certificate for \"system:openshift-router\" is greater than 2 years!\r\nWARNING: By security reasons it is strongly recommended to change this period and make it smaller!\r\nWARNING: Validity period of the certificate for \"system:openshift-registry\" is greater than 2 years!\r\nWARNING: By security reasons it is strongly recommended to change this period and make it smaller!\r\n```\r\n\r\n\r\nTrello card: https://trello.com/c/de9h5mA4/829-3-allow-configuration-of-expiration-date-for-generated-certs\r\nPTAL @mfojtik @deads2k "},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/261983835","html_url":"https://github.com/openshift/origin/pull/11814#issuecomment-261983835","issue_url":"https://api.github.com/repos/openshift/origin/issues/11814","id":261983835,"user":{"login":"openshift-bot","id":1779249,"avatar_url":"https://avatars.githubusercontent.com/u/1779249?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift-bot","html_url":"https://github.com/openshift-bot","followers_url":"https://api.github.com/users/openshift-bot/followers","following_url":"https://api.github.com/users/openshift-bot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-bot/subscriptions","organizations_url":"https://api.github.com/users/openshift-bot/orgs","repos_url":"https://api.github.com/users/openshift-bot/repos","events_url":"https://api.github.com/users/openshift-bot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-bot/received_events","type":"User","site_admin":false},"created_at":"2016-11-21T16:13:27Z","updated_at":"2016-11-21T16:13:27Z","body":"Evaluated for origin test up to 9ea986527dfa175a30ebeb66860a9b97e1032907"}}
{"actor":{"display_login":"openshift-bot"}}