{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/5616","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/5616/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/5616/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/5616/events","html_url":"https://github.com/nodejs/node/pull/5616","id":139476124,"number":5616,"title":"fs: add Buffer support in fs methods","user":{"login":"jasnell","id":439929,"avatar_url":"https://avatars.githubusercontent.com/u/439929?v=3","gravatar_id":"","url":"https://api.github.com/users/jasnell","html_url":"https://github.com/jasnell","followers_url":"https://api.github.com/users/jasnell/followers","following_url":"https://api.github.com/users/jasnell/following{/other_user}","gists_url":"https://api.github.com/users/jasnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jasnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasnell/subscriptions","organizations_url":"https://api.github.com/users/jasnell/orgs","repos_url":"https://api.github.com/users/jasnell/repos","events_url":"https://api.github.com/users/jasnell/events{/privacy}","received_events_url":"https://api.github.com/users/jasnell/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/fs","name":"fs","color":"0052cc"},{"url":"https://api.github.com/repos/nodejs/node/labels/semver-major","name":"semver-major","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/nodejs/node/milestones/13","html_url":"https://github.com/nodejs/node/milestones/6.0.0","labels_url":"https://api.github.com/repos/nodejs/node/milestones/13/labels","id":1269366,"number":13,"title":"6.0.0","description":"","creator":{"login":"Fishrock123","id":1093990,"avatar_url":"https://avatars.githubusercontent.com/u/1093990?v=3","gravatar_id":"","url":"https://api.github.com/users/Fishrock123","html_url":"https://github.com/Fishrock123","followers_url":"https://api.github.com/users/Fishrock123/followers","following_url":"https://api.github.com/users/Fishrock123/following{/other_user}","gists_url":"https://api.github.com/users/Fishrock123/gists{/gist_id}","starred_url":"https://api.github.com/users/Fishrock123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fishrock123/subscriptions","organizations_url":"https://api.github.com/users/Fishrock123/orgs","repos_url":"https://api.github.com/users/Fishrock123/repos","events_url":"https://api.github.com/users/Fishrock123/events{/privacy}","received_events_url":"https://api.github.com/users/Fishrock123/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":8,"state":"open","created_at":"2015-08-24T13:31:52Z","updated_at":"2016-03-22T19:16:46Z","due_on":"2016-04-30T04:00:00Z","closed_at":null},"comments":55,"created_at":"2016-03-09T05:01:13Z","updated_at":"2016-03-23T16:06:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/5616","html_url":"https://github.com/nodejs/node/pull/5616","diff_url":"https://github.com/nodejs/node/pull/5616.diff","patch_url":"https://github.com/nodejs/node/pull/5616.patch"},"body":"### Pull Request check-list\r\n\r\n_Please make sure to review and check all of these items:_\r\n\r\n- [ ] Does `make -j8 test` (UNIX) or `vcbuild test nosign` (Windows) pass with\r\n  this change (including linting)?\r\n- [ ] Is the commit message formatted according to [CONTRIBUTING.md][0]?\r\n- [ ] If this change fixes a bug (or a performance problem), is a regression\r\n  test (or a benchmark) included?\r\n- [ ] Is a documentation update included (if this change modifies\r\n  existing APIs, or introduces new ones)?\r\n\r\n### Affected core subsystem(s)\r\n\r\nfs (/cc @trevnorris @bnoordhuis )\r\n\r\n### Description of change\r\n\r\n*Updated*: Reworked the implementation based on @trevnorris feedback. This now does several things:\r\n\r\n* Buffer accepted as Path on all fs methods that accept a Path\r\n* {encoding: '...'} option accepted on fs.readdir, fs.readdirSync, fs.readlink, fs.readlinkSync, and fs.watch\r\n* Documentation updates\r\n\r\nFixes: https://github.com/nodejs/node/issues/2088\r\nRef: https://github.com/nodejs/node/issues/3519\r\nSee Also: https://github.com/nodejs/node/pull/3401"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/200413334","html_url":"https://github.com/nodejs/node/pull/5616#issuecomment-200413334","issue_url":"https://api.github.com/repos/nodejs/node/issues/5616","id":200413334,"user":{"login":"jasnell","id":439929,"avatar_url":"https://avatars.githubusercontent.com/u/439929?v=3","gravatar_id":"","url":"https://api.github.com/users/jasnell","html_url":"https://github.com/jasnell","followers_url":"https://api.github.com/users/jasnell/followers","following_url":"https://api.github.com/users/jasnell/following{/other_user}","gists_url":"https://api.github.com/users/jasnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jasnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasnell/subscriptions","organizations_url":"https://api.github.com/users/jasnell/orgs","repos_url":"https://api.github.com/users/jasnell/repos","events_url":"https://api.github.com/users/jasnell/events{/privacy}","received_events_url":"https://api.github.com/users/jasnell/received_events","type":"User","site_admin":false},"created_at":"2016-03-23T16:06:10Z","updated_at":"2016-03-23T16:06:10Z","body":"+1 will make that edit.\r\n@nodejs/ctc ... I think this is ready to go, would appreciate additional eyes on it as it's a fairly significant change."}}