{"action":"created","issue":{"url":"https://api.github.com/repos/qTox/qTox/issues/3667","repository_url":"https://api.github.com/repos/qTox/qTox","labels_url":"https://api.github.com/repos/qTox/qTox/issues/3667/labels{/name}","comments_url":"https://api.github.com/repos/qTox/qTox/issues/3667/comments","events_url":"https://api.github.com/repos/qTox/qTox/issues/3667/events","html_url":"https://github.com/qTox/qTox/pull/3667","id":173782433,"number":3667,"title":" [WORKBRANCH] ui/redesign Change buttons","user":{"login":"Diadlo","id":6306608,"avatar_url":"https://avatars.githubusercontent.com/u/6306608?v=3","gravatar_id":"","url":"https://api.github.com/users/Diadlo","html_url":"https://github.com/Diadlo","followers_url":"https://api.github.com/users/Diadlo/followers","following_url":"https://api.github.com/users/Diadlo/following{/other_user}","gists_url":"https://api.github.com/users/Diadlo/gists{/gist_id}","starred_url":"https://api.github.com/users/Diadlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Diadlo/subscriptions","organizations_url":"https://api.github.com/users/Diadlo/orgs","repos_url":"https://api.github.com/users/Diadlo/repos","events_url":"https://api.github.com/users/Diadlo/events{/privacy}","received_events_url":"https://api.github.com/users/Diadlo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-29T14:05:46Z","updated_at":"2016-08-29T15:12:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/qTox/qTox/pulls/3667","html_url":"https://github.com/qTox/qTox/pull/3667","diff_url":"https://github.com/qTox/qTox/pull/3667.diff","patch_url":"https://github.com/qTox/qTox/pull/3667.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/qtox/qtox/3667)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/qTox/qTox/issues/comments/243153916","html_url":"https://github.com/qTox/qTox/pull/3667#issuecomment-243153916","issue_url":"https://api.github.com/repos/qTox/qTox/issues/3667","id":243153916,"user":{"login":"antis81","id":440517,"avatar_url":"https://avatars.githubusercontent.com/u/440517?v=3","gravatar_id":"","url":"https://api.github.com/users/antis81","html_url":"https://github.com/antis81","followers_url":"https://api.github.com/users/antis81/followers","following_url":"https://api.github.com/users/antis81/following{/other_user}","gists_url":"https://api.github.com/users/antis81/gists{/gist_id}","starred_url":"https://api.github.com/users/antis81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antis81/subscriptions","organizations_url":"https://api.github.com/users/antis81/orgs","repos_url":"https://api.github.com/users/antis81/repos","events_url":"https://api.github.com/users/antis81/events{/privacy}","received_events_url":"https://api.github.com/users/antis81/received_events","type":"User","site_admin":false},"created_at":"2016-08-29T15:12:35Z","updated_at":"2016-08-29T15:12:35Z","body":"\n\n\n\nReviewed 13 of 14 files at r1.\nReview status: 13 of 14 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.\n\n---\n\n*[src/widget/form/chatform.cpp, line 875 \\[r1\\]](https://reviewable.io:443/reviews/qtox/qtox/3667#-KQLn6kox4gRyZuXlAMq:-KQLn6kpInxEHaeAHu6z:b-qn0py7) ([raw file](https://github.com/qtox/qtox/blob/3fed9fd4da236c1f7614782dba4a93d8cf8520f2/src/widget/form/chatform.cpp#L875)):*\n> ```cpp\n>     volButton->setEnabled(av->isCallActive(f));\n> \n>     if (volButton->isEnabled())\n> ```\n\nOops, nice typo, thanks! :+1:\n\n---\n\n*[src/widget/form/chatform.cpp, line 888 \\[r1\\]](https://reviewable.io:443/reviews/qtox/qtox/3667#-KQLnQB1Tv4YzVD_Xpz_:-KQLnQB2ypbgS8WIws0k:bqe7z0j) ([raw file](https://github.com/qtox/qtox/blob/3fed9fd4da236c1f7614782dba4a93d8cf8520f2/src/widget/form/chatform.cpp#L888)):*\n> ```cpp\n>         }\n>     }\n>     else\n> ```\n\nBy fixing the \"enabled\" state, this should not be required any longer. The \":disabled\" pseudo-state should overrule the other stuff (exactly like in callButton/videoButton). Could you check that (also for micButton)? Otherwise code looks good.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/qtox/qtox/3667)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"antis81"}}