{"action":"closed","issue":{"url":"https://api.github.com/repos/ampproject/amphtml/issues/4801","repository_url":"https://api.github.com/repos/ampproject/amphtml","labels_url":"https://api.github.com/repos/ampproject/amphtml/issues/4801/labels{/name}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/4801/comments","events_url":"https://api.github.com/repos/ampproject/amphtml/issues/4801/events","html_url":"https://github.com/ampproject/amphtml/issues/4801","id":174508870,"number":4801,"title":"trackId don't allow a comma","user":{"login":"ireinhart","id":481299,"avatar_url":"https://avatars.githubusercontent.com/u/481299?v=3","gravatar_id":"","url":"https://api.github.com/users/ireinhart","html_url":"https://github.com/ireinhart","followers_url":"https://api.github.com/users/ireinhart/followers","following_url":"https://api.github.com/users/ireinhart/following{/other_user}","gists_url":"https://api.github.com/users/ireinhart/gists{/gist_id}","starred_url":"https://api.github.com/users/ireinhart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ireinhart/subscriptions","organizations_url":"https://api.github.com/users/ireinhart/orgs","repos_url":"https://api.github.com/users/ireinhart/repos","events_url":"https://api.github.com/users/ireinhart/events{/privacy}","received_events_url":"https://api.github.com/users/ireinhart/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ampproject/amphtml/labels/Related%20to:%20Analytics","name":"Related to: Analytics","color":"d4c5f9"}],"state":"closed","locked":false,"assignee":{"login":"avimehta","id":179359,"avatar_url":"https://avatars.githubusercontent.com/u/179359?v=3","gravatar_id":"","url":"https://api.github.com/users/avimehta","html_url":"https://github.com/avimehta","followers_url":"https://api.github.com/users/avimehta/followers","following_url":"https://api.github.com/users/avimehta/following{/other_user}","gists_url":"https://api.github.com/users/avimehta/gists{/gist_id}","starred_url":"https://api.github.com/users/avimehta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avimehta/subscriptions","organizations_url":"https://api.github.com/users/avimehta/orgs","repos_url":"https://api.github.com/users/avimehta/repos","events_url":"https://api.github.com/users/avimehta/events{/privacy}","received_events_url":"https://api.github.com/users/avimehta/received_events","type":"User","site_admin":false},"assignees":[{"login":"avimehta","id":179359,"avatar_url":"https://avatars.githubusercontent.com/u/179359?v=3","gravatar_id":"","url":"https://api.github.com/users/avimehta","html_url":"https://github.com/avimehta","followers_url":"https://api.github.com/users/avimehta/followers","following_url":"https://api.github.com/users/avimehta/following{/other_user}","gists_url":"https://api.github.com/users/avimehta/gists{/gist_id}","starred_url":"https://api.github.com/users/avimehta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avimehta/subscriptions","organizations_url":"https://api.github.com/users/avimehta/orgs","repos_url":"https://api.github.com/users/avimehta/repos","events_url":"https://api.github.com/users/avimehta/events{/privacy}","received_events_url":"https://api.github.com/users/avimehta/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/ampproject/amphtml/milestones/20","html_url":"https://github.com/ampproject/amphtml/milestones/Pending%20Triage","labels_url":"https://api.github.com/repos/ampproject/amphtml/milestones/20/labels","id":1884542,"number":20,"title":"Pending Triage","description":"These issues need to get put into another milestone. They should be assigned to the person who can best decide the appropriate milestone. Optionally, the issue can then be assigned to the most likely implementer.","creator":{"login":"rudygalfi","id":3888212,"avatar_url":"https://avatars.githubusercontent.com/u/3888212?v=3","gravatar_id":"","url":"https://api.github.com/users/rudygalfi","html_url":"https://github.com/rudygalfi","followers_url":"https://api.github.com/users/rudygalfi/followers","following_url":"https://api.github.com/users/rudygalfi/following{/other_user}","gists_url":"https://api.github.com/users/rudygalfi/gists{/gist_id}","starred_url":"https://api.github.com/users/rudygalfi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rudygalfi/subscriptions","organizations_url":"https://api.github.com/users/rudygalfi/orgs","repos_url":"https://api.github.com/users/rudygalfi/repos","events_url":"https://api.github.com/users/rudygalfi/events{/privacy}","received_events_url":"https://api.github.com/users/rudygalfi/received_events","type":"User","site_admin":false},"open_issues":47,"closed_issues":17,"state":"open","created_at":"2016-07-14T23:13:22Z","updated_at":"2016-09-02T07:44:32Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2016-09-01T12:20:07Z","updated_at":"2016-09-02T07:44:32Z","closed_at":"2016-09-02T07:44:32Z","body":"We like to use webtrekk with 2 trackId's, but it seams, that the \",\" gets wrong encoded.\r\n\r\n`<script async custom-element=\"amp-analytics\" src=\"https://cdn.ampproject.org/v0/amp-analytics-0.1.js\"></script><script async src=\"https://cdn.ampproject.org/v0.js\"></script>`\r\n\r\nand\r\n\r\n`    <amp-analytics type=\"webtrekk\">\r\n        <script type=\"application/json\">\r\n            {\r\n                \"requests\": {\r\n                    \"parameterPrefix\": \"?p=431,${contentId},1,${screenWidth}x${screenHeight},${screenColorDepth},1,${timestamp},${documentReferrer},${viewportWidth}x${viewportHeight},0&tz=${timezone}&eid=${clientId(amp-wt3-eid)}&la=${browserLanguage}\"\r\n                },\r\n                \"vars\": {\r\n                    \"trackDomain\": \"q3.webtrekk.net\",\r\n                    \"trackId\": \"886765640341113,511604217612660\"\r\n                }\r\n                }\r\n            }\r\n        </script>\r\n    </amp-analytics>`\r\n\r\nproduce a 404 at the webtrekk server.\r\n\r\nThe produced call is:\r\n`https://q3.webtrekk.net/886765640341113%2C511604217612660/...`\r\n\r\nbut it must be:\r\n`https://q3.webtrekk.net/886765640341113,511604217612660/...`\r\n"}}
{"actor":{"display_login":"avimehta"}}