{"action":"created","comment":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/61583181","id":61583181,"diff_hunk":"@@ -2,49 +2,50 @@\n \n import static org.testng.AssertJUnit.assertEquals;\n import org.infinispan.cli.connection.jmx.JMXUrl;\n+import org.infinispan.cli.connection.jmx.remoting.DirectJMXRemotingUrl;\n import org.infinispan.cli.connection.jmx.remoting.JMXRemotingUrl;\n import org.testng.annotations.Test;\n \n @Test(groups=\"functional\", testName=\"cli.JMXRemotingUrlTest\")\n public class JMXRemotingUrlTest {\n \n    public void testValidJMXUrl() {\n-      JMXUrl jmxUrl = new JMXRemotingUrl(\"remoting://localhost:12345\");\n+      JMXUrl jmxUrl = new DirectJMXRemotingUrl(\"remoting://localhost:12345\");\n       assertEquals(\"service:jmx:remoting-jmx://localhost:12345\", jmxUrl.getJMXServiceURL());\n    }\n \n    public void testValidJMXUrlWithContainer() {\n-      JMXUrl jmxUrl = new JMXRemotingUrl(\"remoting://localhost:12345/container\");\n+      JMXUrl jmxUrl = new DirectJMXRemotingUrl(\"remoting://localhost:12345/container\");\n       assertEquals(\"service:jmx:remoting-jmx://localhost:12345\", jmxUrl.getJMXServiceURL());\n       assertEquals(\"container\", jmxUrl.getContainer());\n    }\n \n    public void testValidJMXUrlWithContainerAndCache() {\n-      JMXUrl jmxUrl = new JMXRemotingUrl(\"remoting://localhost:12345/container/cache\");\n+      JMXUrl jmxUrl = new DirectJMXRemotingUrl(\"remoting://localhost:12345/container/cache\");\n       assertEquals(\"service:jmx:remoting-jmx://localhost:12345\", jmxUrl.getJMXServiceURL());\n       assertEquals(\"container\", jmxUrl.getContainer());\n       assertEquals(\"cache\", jmxUrl.getCache());\n    }\n \n    public void testValidIPV6JMXUrl() {\n-      JMXUrl jmxUrl = new JMXRemotingUrl(\"remoting://[FEDC:BA98:7654:3210:FEDC:BA98:7654:3210]:12345\");\n+      JMXUrl jmxUrl = new DirectJMXRemotingUrl(\"remoting://[FEDC:BA98:7654:3210:FEDC:BA98:7654:3210]:12345\");\n       assertEquals(\"service:jmx:remoting-jmx://[FEDC:BA98:7654:3210:FEDC:BA98:7654:3210]:12345\", jmxUrl.getJMXServiceURL());\n    }\n \n    public void testValidIPV6JMXUrlWithContainerAndCache() {\n-      JMXUrl jmxUrl = new JMXRemotingUrl(\"remoting://[FEDC:BA98:7654:3210:FEDC:BA98:7654:3210]:12345/container/cache\");\n+      JMXUrl jmxUrl = new DirectJMXRemotingUrl(\"remoting://[FEDC:BA98:7654:3210:FEDC:BA98:7654:3210]:12345/container/cache\");\n       assertEquals(\"service:jmx:remoting-jmx://[FEDC:BA98:7654:3210:FEDC:BA98:7654:3210]:12345\", jmxUrl.getJMXServiceURL());\n       assertEquals(\"container\", jmxUrl.getContainer());\n       assertEquals(\"cache\", jmxUrl.getCache());\n    }\n \n    public void testEmptyJMXUrl() {\n-      JMXUrl jmxUrl = new JMXRemotingUrl(\"\");\n+      JMXUrl jmxUrl = new DirectJMXRemotingUrl(\"\");\n       assertEquals(\"service:jmx:remoting-jmx://localhost:9999\", jmxUrl.getJMXServiceURL());\n    }\n \n    @Test(expectedExceptions=IllegalArgumentException.class)\n    public void testInvalidJMXUrl() {\n-      new JMXRemotingUrl(\"hotrod://localhost:12345\");\n+      new DirectJMXRemotingUrl(\"hotrod://localhost:12345\");","path":"cli/cli-client/src/test/java/org/infinispan/cli/JMXRemotingUrlTest.java","position":55,"original_position":55,"commit_id":"eb94cebf1cb67a8f1455cf722eee85432a18fcb2","original_commit_id":"9839422dd4473c51803f2161da152fc6aff9dbdb","user":{"login":"slaskawi","id":8417158,"avatar_url":"https://avatars.githubusercontent.com/u/8417158?v=3","gravatar_id":"","url":"https://api.github.com/users/slaskawi","html_url":"https://github.com/slaskawi","followers_url":"https://api.github.com/users/slaskawi/followers","following_url":"https://api.github.com/users/slaskawi/following{/other_user}","gists_url":"https://api.github.com/users/slaskawi/gists{/gist_id}","starred_url":"https://api.github.com/users/slaskawi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slaskawi/subscriptions","organizations_url":"https://api.github.com/users/slaskawi/orgs","repos_url":"https://api.github.com/users/slaskawi/repos","events_url":"https://api.github.com/users/slaskawi/events{/privacy}","received_events_url":"https://api.github.com/users/slaskawi/received_events","type":"User","site_admin":false},"body":"Should we mention supporting it somewhere in the Infinispan Server Guide?","created_at":"2016-04-29T14:11:01Z","updated_at":"2016-04-29T14:11:01Z","html_url":"https://github.com/infinispan/infinispan/pull/4282#discussion_r61583181","pull_request_url":"https://api.github.com/repos/infinispan/infinispan/pulls/4282","_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/61583181"},"html":{"href":"https://github.com/infinispan/infinispan/pull/4282#discussion_r61583181"},"pull_request":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/4282"}}},"pull_request":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/4282","id":68210469,"html_url":"https://github.com/infinispan/infinispan/pull/4282","diff_url":"https://github.com/infinispan/infinispan/pull/4282.diff","patch_url":"https://github.com/infinispan/infinispan/pull/4282.patch","issue_url":"https://api.github.com/repos/infinispan/infinispan/issues/4282","number":4282,"state":"open","locked":false,"title":"Cumulative CLI fixes","user":{"login":"tristantarrant","id":392478,"avatar_url":"https://avatars.githubusercontent.com/u/392478?v=3","gravatar_id":"","url":"https://api.github.com/users/tristantarrant","html_url":"https://github.com/tristantarrant","followers_url":"https://api.github.com/users/tristantarrant/followers","following_url":"https://api.github.com/users/tristantarrant/following{/other_user}","gists_url":"https://api.github.com/users/tristantarrant/gists{/gist_id}","starred_url":"https://api.github.com/users/tristantarrant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tristantarrant/subscriptions","organizations_url":"https://api.github.com/users/tristantarrant/orgs","repos_url":"https://api.github.com/users/tristantarrant/repos","events_url":"https://api.github.com/users/tristantarrant/events{/privacy}","received_events_url":"https://api.github.com/users/tristantarrant/received_events","type":"User","site_admin":false},"body":"https://issues.jboss.org/browse/ISPN-6516\r\nhttps://issues.jboss.org/browse/ISPN-6562\r\nhttps://issues.jboss.org/browse/ISPN-6565\r\nhttps://issues.jboss.org/browse/ISPN-6567\r\nhttps://issues.jboss.org/browse/ISPN-6569\r\nhttps://issues.jboss.org/browse/ISPN-6570","created_at":"2016-04-28T12:17:35Z","updated_at":"2016-04-29T14:11:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"50078d4222d48d2bb808e7d488625b3dec007e41","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/infinispan/infinispan/pulls/4282/commits","review_comments_url":"https://api.github.com/repos/infinispan/infinispan/pulls/4282/comments","review_comment_url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/infinispan/infinispan/issues/4282/comments","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/eb94cebf1cb67a8f1455cf722eee85432a18fcb2","head":{"label":"tristantarrant:ISPN-6516/aesh_upgrade","ref":"ISPN-6516/aesh_upgrade","sha":"eb94cebf1cb67a8f1455cf722eee85432a18fcb2","user":{"login":"tristantarrant","id":392478,"avatar_url":"https://avatars.githubusercontent.com/u/392478?v=3","gravatar_id":"","url":"https://api.github.com/users/tristantarrant","html_url":"https://github.com/tristantarrant","followers_url":"https://api.github.com/users/tristantarrant/followers","following_url":"https://api.github.com/users/tristantarrant/following{/other_user}","gists_url":"https://api.github.com/users/tristantarrant/gists{/gist_id}","starred_url":"https://api.github.com/users/tristantarrant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tristantarrant/subscriptions","organizations_url":"https://api.github.com/users/tristantarrant/orgs","repos_url":"https://api.github.com/users/tristantarrant/repos","events_url":"https://api.github.com/users/tristantarrant/events{/privacy}","received_events_url":"https://api.github.com/users/tristantarrant/received_events","type":"User","site_admin":false},"repo":{"id":2035565,"name":"infinispan","full_name":"tristantarrant/infinispan","owner":{"login":"tristantarrant","id":392478,"avatar_url":"https://avatars.githubusercontent.com/u/392478?v=3","gravatar_id":"","url":"https://api.github.com/users/tristantarrant","html_url":"https://github.com/tristantarrant","followers_url":"https://api.github.com/users/tristantarrant/followers","following_url":"https://api.github.com/users/tristantarrant/following{/other_user}","gists_url":"https://api.github.com/users/tristantarrant/gists{/gist_id}","starred_url":"https://api.github.com/users/tristantarrant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tristantarrant/subscriptions","organizations_url":"https://api.github.com/users/tristantarrant/orgs","repos_url":"https://api.github.com/users/tristantarrant/repos","events_url":"https://api.github.com/users/tristantarrant/events{/privacy}","received_events_url":"https://api.github.com/users/tristantarrant/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tristantarrant/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":true,"url":"https://api.github.com/repos/tristantarrant/infinispan","forks_url":"https://api.github.com/repos/tristantarrant/infinispan/forks","keys_url":"https://api.github.com/repos/tristantarrant/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tristantarrant/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tristantarrant/infinispan/teams","hooks_url":"https://api.github.com/repos/tristantarrant/infinispan/hooks","issue_events_url":"https://api.github.com/repos/tristantarrant/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/tristantarrant/infinispan/events","assignees_url":"https://api.github.com/repos/tristantarrant/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/tristantarrant/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/tristantarrant/infinispan/tags","blobs_url":"https://api.github.com/repos/tristantarrant/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tristantarrant/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tristantarrant/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/tristantarrant/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tristantarrant/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/tristantarrant/infinispan/languages","stargazers_url":"https://api.github.com/repos/tristantarrant/infinispan/stargazers","contributors_url":"https://api.github.com/repos/tristantarrant/infinispan/contributors","subscribers_url":"https://api.github.com/repos/tristantarrant/infinispan/subscribers","subscription_url":"https://api.github.com/repos/tristantarrant/infinispan/subscription","commits_url":"https://api.github.com/repos/tristantarrant/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/tristantarrant/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/tristantarrant/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/tristantarrant/infinispan/issues/comments{/number}","contents_url":"https://api.github.com/repos/tristantarrant/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/tristantarrant/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tristantarrant/infinispan/merges","archive_url":"https://api.github.com/repos/tristantarrant/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tristantarrant/infinispan/downloads","issues_url":"https://api.github.com/repos/tristantarrant/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/tristantarrant/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/tristantarrant/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/tristantarrant/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tristantarrant/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/tristantarrant/infinispan/releases{/id}","deployments_url":"https://api.github.com/repos/tristantarrant/infinispan/deployments","created_at":"2011-07-12T10:59:18Z","updated_at":"2014-06-25T09:10:17Z","pushed_at":"2016-04-28T16:15:00Z","git_url":"git://github.com/tristantarrant/infinispan.git","ssh_url":"git@github.com:tristantarrant/infinispan.git","clone_url":"https://github.com/tristantarrant/infinispan.git","svn_url":"https://github.com/tristantarrant/infinispan","homepage":"http://www.infinispan.org","size":68935,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"infinispan:master","ref":"master","sha":"4f0f1bde0b3ad870227f444af193baabbfc26cb3","user":{"login":"infinispan","id":458093,"avatar_url":"https://avatars.githubusercontent.com/u/458093?v=3","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"repo":{"id":1050944,"name":"infinispan","full_name":"infinispan/infinispan","owner":{"login":"infinispan","id":458093,"avatar_url":"https://avatars.githubusercontent.com/u/458093?v=3","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/infinispan/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":false,"url":"https://api.github.com/repos/infinispan/infinispan","forks_url":"https://api.github.com/repos/infinispan/infinispan/forks","keys_url":"https://api.github.com/repos/infinispan/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infinispan/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infinispan/infinispan/teams","hooks_url":"https://api.github.com/repos/infinispan/infinispan/hooks","issue_events_url":"https://api.github.com/repos/infinispan/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/infinispan/infinispan/events","assignees_url":"https://api.github.com/repos/infinispan/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/infinispan/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/infinispan/infinispan/tags","blobs_url":"https://api.github.com/repos/infinispan/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infinispan/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infinispan/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/infinispan/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/infinispan/infinispan/languages","stargazers_url":"https://api.github.com/repos/infinispan/infinispan/stargazers","contributors_url":"https://api.github.com/repos/infinispan/infinispan/contributors","subscribers_url":"https://api.github.com/repos/infinispan/infinispan/subscribers","subscription_url":"https://api.github.com/repos/infinispan/infinispan/subscription","commits_url":"https://api.github.com/repos/infinispan/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/infinispan/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/infinispan/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/infinispan/infinispan/issues/comments{/number}","contents_url":"https://api.github.com/repos/infinispan/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/infinispan/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infinispan/infinispan/merges","archive_url":"https://api.github.com/repos/infinispan/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infinispan/infinispan/downloads","issues_url":"https://api.github.com/repos/infinispan/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/infinispan/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/infinispan/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/infinispan/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infinispan/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/infinispan/infinispan/releases{/id}","deployments_url":"https://api.github.com/repos/infinispan/infinispan/deployments","created_at":"2010-11-04T12:33:19Z","updated_at":"2016-04-19T13:16:28Z","pushed_at":"2016-04-29T14:09:40Z","git_url":"git://github.com/infinispan/infinispan.git","ssh_url":"git@github.com:infinispan/infinispan.git","clone_url":"https://github.com/infinispan/infinispan.git","svn_url":"https://github.com/infinispan/infinispan","homepage":"http://www.infinispan.org","size":93356,"stargazers_count":462,"watchers_count":462,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":342,"mirror_url":null,"open_issues_count":27,"forks":342,"open_issues":27,"watchers":462,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/4282"},"html":{"href":"https://github.com/infinispan/infinispan/pull/4282"},"issue":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/4282"},"comments":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/4282/comments"},"review_comments":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/4282/comments"},"review_comment":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/4282/commits"},"statuses":{"href":"https://api.github.com/repos/infinispan/infinispan/statuses/eb94cebf1cb67a8f1455cf722eee85432a18fcb2"}}}}