{"action":"created","comment":{"url":"https://api.github.com/repos/socraticorg/mathjs/pulls/comments/83898573","pull_request_review_id":4711450,"id":83898573,"diff_hunk":"@@ -1,71 +1,75 @@\n 'use strict';\n \n+const math = require('../../../index');\n+\n const Fraction = require('./Fraction');\n const PolynomialTermNode = require('./PolynomialTermNode');\n const NodeCreator = require('./NodeCreator');\n const NodeType = require('./NodeType');\n \n // Prints an expression node properly.\n+// If latex is true, will return latex, otherwise will return asciimath\n // If showPlusMinus is true, print + - (e.g. 2 + -3)\n // If it's false (the default) 2 + -3 would print as 2 - 3\n // This supports the conversion of subtraction to addition of negative terms,\n // which is needed to flatten operands.\n-function prettyPrint(node, showPlusMinus=false) {\n-  let string = prettyPrintDFS(node);\n-  if (showPlusMinus) {\n-    return string;\n+function prettyPrint(node, latex=false, showPlusMinus=false) {\n+  let string = prettyPrintDFS(node, false);\n+  if (!showPlusMinus) {","path":"lib/expression/step-solver/prettyPrint.js","position":22,"original_position":22,"commit_id":"8231a027dc622a836b97a35f55cbac151cafe782","original_commit_id":"e35f894395600dfbff7fad46257efafd61e23ccd","user":{"login":"aelnaiem","id":786569,"avatar_url":"https://avatars.githubusercontent.com/u/786569?v=3","gravatar_id":"","url":"https://api.github.com/users/aelnaiem","html_url":"https://github.com/aelnaiem","followers_url":"https://api.github.com/users/aelnaiem/followers","following_url":"https://api.github.com/users/aelnaiem/following{/other_user}","gists_url":"https://api.github.com/users/aelnaiem/gists{/gist_id}","starred_url":"https://api.github.com/users/aelnaiem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aelnaiem/subscriptions","organizations_url":"https://api.github.com/users/aelnaiem/orgs","repos_url":"https://api.github.com/users/aelnaiem/repos","events_url":"https://api.github.com/users/aelnaiem/events{/privacy}","received_events_url":"https://api.github.com/users/aelnaiem/received_events","type":"User","site_admin":false},"body":"Now it does! That's was my original mistake","created_at":"2016-10-18T16:45:14Z","updated_at":"2016-10-18T16:45:14Z","html_url":"https://github.com/socraticorg/mathjs/pull/28#discussion_r83898573","pull_request_url":"https://api.github.com/repos/socraticorg/mathjs/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/socraticorg/mathjs/pulls/comments/83898573"},"html":{"href":"https://github.com/socraticorg/mathjs/pull/28#discussion_r83898573"},"pull_request":{"href":"https://api.github.com/repos/socraticorg/mathjs/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/socraticorg/mathjs/pulls/28","id":89717028,"html_url":"https://github.com/socraticorg/mathjs/pull/28","diff_url":"https://github.com/socraticorg/mathjs/pull/28.diff","patch_url":"https://github.com/socraticorg/mathjs/pull/28.patch","issue_url":"https://api.github.com/repos/socraticorg/mathjs/issues/28","number":28,"state":"open","locked":false,"title":"storing asciimath and latex for each step (using the node.toTex()) function","user":{"login":"aelnaiem","id":786569,"avatar_url":"https://avatars.githubusercontent.com/u/786569?v=3","gravatar_id":"","url":"https://api.github.com/users/aelnaiem","html_url":"https://github.com/aelnaiem","followers_url":"https://api.github.com/users/aelnaiem/followers","following_url":"https://api.github.com/users/aelnaiem/following{/other_user}","gists_url":"https://api.github.com/users/aelnaiem/gists{/gist_id}","starred_url":"https://api.github.com/users/aelnaiem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aelnaiem/subscriptions","organizations_url":"https://api.github.com/users/aelnaiem/orgs","repos_url":"https://api.github.com/users/aelnaiem/repos","events_url":"https://api.github.com/users/aelnaiem/events{/privacy}","received_events_url":"https://api.github.com/users/aelnaiem/received_events","type":"User","site_admin":false},"body":"Does math.js print asciimath? Maybe we don't have to do our own pretty printing? Anyway I think this can be cleaned up, but just putting it up before I call it a day. Pretty straightforward\r\n\r\nPart of [this task](https://app.asana.com/0/157236840334946/195847872672803)","created_at":"2016-10-17T22:40:54Z","updated_at":"2016-10-18T16:45:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f6893c47924153d842b24561c6386eb460bf09a","assignee":{"login":"evykassirer","id":5634097,"avatar_url":"https://avatars.githubusercontent.com/u/5634097?v=3","gravatar_id":"","url":"https://api.github.com/users/evykassirer","html_url":"https://github.com/evykassirer","followers_url":"https://api.github.com/users/evykassirer/followers","following_url":"https://api.github.com/users/evykassirer/following{/other_user}","gists_url":"https://api.github.com/users/evykassirer/gists{/gist_id}","starred_url":"https://api.github.com/users/evykassirer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evykassirer/subscriptions","organizations_url":"https://api.github.com/users/evykassirer/orgs","repos_url":"https://api.github.com/users/evykassirer/repos","events_url":"https://api.github.com/users/evykassirer/events{/privacy}","received_events_url":"https://api.github.com/users/evykassirer/received_events","type":"User","site_admin":false},"assignees":[{"login":"evykassirer","id":5634097,"avatar_url":"https://avatars.githubusercontent.com/u/5634097?v=3","gravatar_id":"","url":"https://api.github.com/users/evykassirer","html_url":"https://github.com/evykassirer","followers_url":"https://api.github.com/users/evykassirer/followers","following_url":"https://api.github.com/users/evykassirer/following{/other_user}","gists_url":"https://api.github.com/users/evykassirer/gists{/gist_id}","starred_url":"https://api.github.com/users/evykassirer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evykassirer/subscriptions","organizations_url":"https://api.github.com/users/evykassirer/orgs","repos_url":"https://api.github.com/users/evykassirer/repos","events_url":"https://api.github.com/users/evykassirer/events{/privacy}","received_events_url":"https://api.github.com/users/evykassirer/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/socraticorg/mathjs/pulls/28/commits","review_comments_url":"https://api.github.com/repos/socraticorg/mathjs/pulls/28/comments","review_comment_url":"https://api.github.com/repos/socraticorg/mathjs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/socraticorg/mathjs/issues/28/comments","statuses_url":"https://api.github.com/repos/socraticorg/mathjs/statuses/8231a027dc622a836b97a35f55cbac151cafe782","head":{"label":"socraticorg:ae_latex","ref":"ae_latex","sha":"8231a027dc622a836b97a35f55cbac151cafe782","user":{"login":"socraticorg","id":4368132,"avatar_url":"https://avatars.githubusercontent.com/u/4368132?v=3","gravatar_id":"","url":"https://api.github.com/users/socraticorg","html_url":"https://github.com/socraticorg","followers_url":"https://api.github.com/users/socraticorg/followers","following_url":"https://api.github.com/users/socraticorg/following{/other_user}","gists_url":"https://api.github.com/users/socraticorg/gists{/gist_id}","starred_url":"https://api.github.com/users/socraticorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socraticorg/subscriptions","organizations_url":"https://api.github.com/users/socraticorg/orgs","repos_url":"https://api.github.com/users/socraticorg/repos","events_url":"https://api.github.com/users/socraticorg/events{/privacy}","received_events_url":"https://api.github.com/users/socraticorg/received_events","type":"Organization","site_admin":false},"repo":{"id":66677351,"name":"mathjs","full_name":"socraticorg/mathjs","owner":{"login":"socraticorg","id":4368132,"avatar_url":"https://avatars.githubusercontent.com/u/4368132?v=3","gravatar_id":"","url":"https://api.github.com/users/socraticorg","html_url":"https://github.com/socraticorg","followers_url":"https://api.github.com/users/socraticorg/followers","following_url":"https://api.github.com/users/socraticorg/following{/other_user}","gists_url":"https://api.github.com/users/socraticorg/gists{/gist_id}","starred_url":"https://api.github.com/users/socraticorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socraticorg/subscriptions","organizations_url":"https://api.github.com/users/socraticorg/orgs","repos_url":"https://api.github.com/users/socraticorg/repos","events_url":"https://api.github.com/users/socraticorg/events{/privacy}","received_events_url":"https://api.github.com/users/socraticorg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/socraticorg/mathjs","description":"An extensive math library for JavaScript and Node.js","fork":true,"url":"https://api.github.com/repos/socraticorg/mathjs","forks_url":"https://api.github.com/repos/socraticorg/mathjs/forks","keys_url":"https://api.github.com/repos/socraticorg/mathjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/socraticorg/mathjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/socraticorg/mathjs/teams","hooks_url":"https://api.github.com/repos/socraticorg/mathjs/hooks","issue_events_url":"https://api.github.com/repos/socraticorg/mathjs/issues/events{/number}","events_url":"https://api.github.com/repos/socraticorg/mathjs/events","assignees_url":"https://api.github.com/repos/socraticorg/mathjs/assignees{/user}","branches_url":"https://api.github.com/repos/socraticorg/mathjs/branches{/branch}","tags_url":"https://api.github.com/repos/socraticorg/mathjs/tags","blobs_url":"https://api.github.com/repos/socraticorg/mathjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/socraticorg/mathjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/socraticorg/mathjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/socraticorg/mathjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/socraticorg/mathjs/statuses/{sha}","languages_url":"https://api.github.com/repos/socraticorg/mathjs/languages","stargazers_url":"https://api.github.com/repos/socraticorg/mathjs/stargazers","contributors_url":"https://api.github.com/repos/socraticorg/mathjs/contributors","subscribers_url":"https://api.github.com/repos/socraticorg/mathjs/subscribers","subscription_url":"https://api.github.com/repos/socraticorg/mathjs/subscription","commits_url":"https://api.github.com/repos/socraticorg/mathjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/socraticorg/mathjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/socraticorg/mathjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/socraticorg/mathjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/socraticorg/mathjs/contents/{+path}","compare_url":"https://api.github.com/repos/socraticorg/mathjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/socraticorg/mathjs/merges","archive_url":"https://api.github.com/repos/socraticorg/mathjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/socraticorg/mathjs/downloads","issues_url":"https://api.github.com/repos/socraticorg/mathjs/issues{/number}","pulls_url":"https://api.github.com/repos/socraticorg/mathjs/pulls{/number}","milestones_url":"https://api.github.com/repos/socraticorg/mathjs/milestones{/number}","notifications_url":"https://api.github.com/repos/socraticorg/mathjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/socraticorg/mathjs/labels{/name}","releases_url":"https://api.github.com/repos/socraticorg/mathjs/releases{/id}","deployments_url":"https://api.github.com/repos/socraticorg/mathjs/deployments","created_at":"2016-08-26T20:28:50Z","updated_at":"2016-08-26T20:28:52Z","pushed_at":"2016-10-18T16:44:23Z","git_url":"git://github.com/socraticorg/mathjs.git","ssh_url":"git@github.com:socraticorg/mathjs.git","clone_url":"https://github.com/socraticorg/mathjs.git","svn_url":"https://github.com/socraticorg/mathjs","homepage":"mathjs.org","size":32445,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"socraticorg:ek-mathsteps","ref":"ek-mathsteps","sha":"e445834189fb6a262be641ea5d28c3ba6b1155b0","user":{"login":"socraticorg","id":4368132,"avatar_url":"https://avatars.githubusercontent.com/u/4368132?v=3","gravatar_id":"","url":"https://api.github.com/users/socraticorg","html_url":"https://github.com/socraticorg","followers_url":"https://api.github.com/users/socraticorg/followers","following_url":"https://api.github.com/users/socraticorg/following{/other_user}","gists_url":"https://api.github.com/users/socraticorg/gists{/gist_id}","starred_url":"https://api.github.com/users/socraticorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socraticorg/subscriptions","organizations_url":"https://api.github.com/users/socraticorg/orgs","repos_url":"https://api.github.com/users/socraticorg/repos","events_url":"https://api.github.com/users/socraticorg/events{/privacy}","received_events_url":"https://api.github.com/users/socraticorg/received_events","type":"Organization","site_admin":false},"repo":{"id":66677351,"name":"mathjs","full_name":"socraticorg/mathjs","owner":{"login":"socraticorg","id":4368132,"avatar_url":"https://avatars.githubusercontent.com/u/4368132?v=3","gravatar_id":"","url":"https://api.github.com/users/socraticorg","html_url":"https://github.com/socraticorg","followers_url":"https://api.github.com/users/socraticorg/followers","following_url":"https://api.github.com/users/socraticorg/following{/other_user}","gists_url":"https://api.github.com/users/socraticorg/gists{/gist_id}","starred_url":"https://api.github.com/users/socraticorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socraticorg/subscriptions","organizations_url":"https://api.github.com/users/socraticorg/orgs","repos_url":"https://api.github.com/users/socraticorg/repos","events_url":"https://api.github.com/users/socraticorg/events{/privacy}","received_events_url":"https://api.github.com/users/socraticorg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/socraticorg/mathjs","description":"An extensive math library for JavaScript and Node.js","fork":true,"url":"https://api.github.com/repos/socraticorg/mathjs","forks_url":"https://api.github.com/repos/socraticorg/mathjs/forks","keys_url":"https://api.github.com/repos/socraticorg/mathjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/socraticorg/mathjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/socraticorg/mathjs/teams","hooks_url":"https://api.github.com/repos/socraticorg/mathjs/hooks","issue_events_url":"https://api.github.com/repos/socraticorg/mathjs/issues/events{/number}","events_url":"https://api.github.com/repos/socraticorg/mathjs/events","assignees_url":"https://api.github.com/repos/socraticorg/mathjs/assignees{/user}","branches_url":"https://api.github.com/repos/socraticorg/mathjs/branches{/branch}","tags_url":"https://api.github.com/repos/socraticorg/mathjs/tags","blobs_url":"https://api.github.com/repos/socraticorg/mathjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/socraticorg/mathjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/socraticorg/mathjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/socraticorg/mathjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/socraticorg/mathjs/statuses/{sha}","languages_url":"https://api.github.com/repos/socraticorg/mathjs/languages","stargazers_url":"https://api.github.com/repos/socraticorg/mathjs/stargazers","contributors_url":"https://api.github.com/repos/socraticorg/mathjs/contributors","subscribers_url":"https://api.github.com/repos/socraticorg/mathjs/subscribers","subscription_url":"https://api.github.com/repos/socraticorg/mathjs/subscription","commits_url":"https://api.github.com/repos/socraticorg/mathjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/socraticorg/mathjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/socraticorg/mathjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/socraticorg/mathjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/socraticorg/mathjs/contents/{+path}","compare_url":"https://api.github.com/repos/socraticorg/mathjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/socraticorg/mathjs/merges","archive_url":"https://api.github.com/repos/socraticorg/mathjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/socraticorg/mathjs/downloads","issues_url":"https://api.github.com/repos/socraticorg/mathjs/issues{/number}","pulls_url":"https://api.github.com/repos/socraticorg/mathjs/pulls{/number}","milestones_url":"https://api.github.com/repos/socraticorg/mathjs/milestones{/number}","notifications_url":"https://api.github.com/repos/socraticorg/mathjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/socraticorg/mathjs/labels{/name}","releases_url":"https://api.github.com/repos/socraticorg/mathjs/releases{/id}","deployments_url":"https://api.github.com/repos/socraticorg/mathjs/deployments","created_at":"2016-08-26T20:28:50Z","updated_at":"2016-08-26T20:28:52Z","pushed_at":"2016-10-18T16:44:23Z","git_url":"git://github.com/socraticorg/mathjs.git","ssh_url":"git@github.com:socraticorg/mathjs.git","clone_url":"https://github.com/socraticorg/mathjs.git","svn_url":"https://github.com/socraticorg/mathjs","homepage":"mathjs.org","size":32445,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/socraticorg/mathjs/pulls/28"},"html":{"href":"https://github.com/socraticorg/mathjs/pull/28"},"issue":{"href":"https://api.github.com/repos/socraticorg/mathjs/issues/28"},"comments":{"href":"https://api.github.com/repos/socraticorg/mathjs/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/socraticorg/mathjs/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/socraticorg/mathjs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/socraticorg/mathjs/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/socraticorg/mathjs/statuses/8231a027dc622a836b97a35f55cbac151cafe782"}}}}
{"actor":{"display_login":"aelnaiem"}}