{"action":"closed","issue":{"url":"https://api.github.com/repos/ethereum/solidity/issues/186","repository_url":"https://api.github.com/repos/ethereum/solidity","labels_url":"https://api.github.com/repos/ethereum/solidity/issues/186/labels{/name}","comments_url":"https://api.github.com/repos/ethereum/solidity/issues/186/comments","events_url":"https://api.github.com/repos/ethereum/solidity/issues/186/events","html_url":"https://github.com/ethereum/solidity/issues/186","id":114602559,"number":186,"title":"Version string does not include commit hash","user":{"login":"chriseth","id":9073706,"avatar_url":"https://avatars.githubusercontent.com/u/9073706?v=3","gravatar_id":"","url":"https://api.github.com/users/chriseth","html_url":"https://github.com/chriseth","followers_url":"https://api.github.com/users/chriseth/followers","following_url":"https://api.github.com/users/chriseth/following{/other_user}","gists_url":"https://api.github.com/users/chriseth/gists{/gist_id}","starred_url":"https://api.github.com/users/chriseth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriseth/subscriptions","organizations_url":"https://api.github.com/users/chriseth/orgs","repos_url":"https://api.github.com/users/chriseth/repos","events_url":"https://api.github.com/users/chriseth/events{/privacy}","received_events_url":"https://api.github.com/users/chriseth/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ethereum/solidity/labels/bug","name":"bug","color":"fc1313"},{"url":"https://api.github.com/repos/ethereum/solidity/labels/nextrelease","name":"nextrelease","color":"fbca04"},{"url":"https://api.github.com/repos/ethereum/solidity/labels/planned","name":"planned","color":"ededed"},{"url":"https://api.github.com/repos/ethereum/solidity/labels/soon","name":"soon","color":"0e8a16"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/ethereum/solidity/milestones/11","html_url":"https://github.com/ethereum/solidity/milestones/4-authenticated-binaries","labels_url":"https://api.github.com/repos/ethereum/solidity/milestones/11/labels","id":1925443,"number":11,"title":"4-authenticated-binaries","description":"Smart contract binaries should be authenticated in the sense that their source code and compiler is stamped into their bytecode (creation bytecode). Furhermore, it should be possible to see which compiler version is \"official\" from the blockchain.","creator":{"login":"chriseth","id":9073706,"avatar_url":"https://avatars.githubusercontent.com/u/9073706?v=3","gravatar_id":"","url":"https://api.github.com/users/chriseth","html_url":"https://github.com/chriseth","followers_url":"https://api.github.com/users/chriseth/followers","following_url":"https://api.github.com/users/chriseth/following{/other_user}","gists_url":"https://api.github.com/users/chriseth/gists{/gist_id}","starred_url":"https://api.github.com/users/chriseth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriseth/subscriptions","organizations_url":"https://api.github.com/users/chriseth/orgs","repos_url":"https://api.github.com/users/chriseth/repos","events_url":"https://api.github.com/users/chriseth/events{/privacy}","received_events_url":"https://api.github.com/users/chriseth/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":1,"state":"open","created_at":"2016-08-05T13:34:02Z","updated_at":"2016-08-27T05:58:33Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2015-11-02T14:17:45Z","updated_at":"2016-08-27T05:58:33Z","closed_at":"2016-08-27T05:58:33Z","body":"This applies to the binaries from the release repository.\r\n\r\nSuggested fix:\r\n\r\nChange the build scripts:\r\n\r\n - use `$TRAVIS_COMMIT` and explicitly store it in a special file as part of the source code (the one that is also uploaded to the ppa as \"orig\"), then run the build.\r\n\r\nChange cmake files:\r\n\r\n  - change the build_info cmake to: if `.git` is not present, use the special file (if not available, abort), otherwise read the commit hash from git.\r\n\r\nThis \"special file\" should be used to contain the prerelease- and the build specifier (as defined in semver). If the prerelease part is empty, this is a proper release (this should only be done from the release branch and potentially err if such a version already exists). The build specifier should contain the commit hash and potentially the platform and whether the source is modified from the commit. The prerelease specifier should be `-nightly-year-month-day`."}}
{"actor":{"display_login":"bobsummerwill"}}