{"action":"opened","number":3,"pull_request":{"url":"https://api.github.com/repos/skmetz/play/pulls/3","id":72422452,"html_url":"https://github.com/skmetz/play/pull/3","diff_url":"https://github.com/skmetz/play/pull/3.diff","patch_url":"https://github.com/skmetz/play/pull/3.patch","issue_url":"https://api.github.com/repos/skmetz/play/issues/3","number":3,"state":"open","locked":false,"title":"eliminate the result accumulator setup outside the reduce","user":{"login":"baob","id":55932,"avatar_url":"https://avatars.githubusercontent.com/u/55932?v=3","gravatar_id":"","url":"https://api.github.com/users/baob","html_url":"https://github.com/baob","followers_url":"https://api.github.com/users/baob/followers","following_url":"https://api.github.com/users/baob/following{/other_user}","gists_url":"https://api.github.com/users/baob/gists{/gist_id}","starred_url":"https://api.github.com/users/baob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baob/subscriptions","organizations_url":"https://api.github.com/users/baob/orgs","repos_url":"https://api.github.com/users/baob/repos","events_url":"https://api.github.com/users/baob/events{/privacy}","received_events_url":"https://api.github.com/users/baob/received_events","type":"User","site_admin":false},"body":"I'm not sure if I like the change now I've done it. However I was motivated to eliminate the setup outside the reduce.\r\n\r\nI kind of like the symmetry of having that array passed in to the reduce, that has a slowly building first part (roman numeral) and a slowly diminishing second part (number to be converted -> remainder).\r\n\r\nI like the fewer lines.\r\n\r\nI dislike that it's less readable. ","created_at":"2016-06-02T21:42:22Z","updated_at":"2016-06-02T21:42:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/skmetz/play/pulls/3/commits","review_comments_url":"https://api.github.com/repos/skmetz/play/pulls/3/comments","review_comment_url":"https://api.github.com/repos/skmetz/play/pulls/comments{/number}","comments_url":"https://api.github.com/repos/skmetz/play/issues/3/comments","statuses_url":"https://api.github.com/repos/skmetz/play/statuses/57857ce2b2378aeace0094e709503361fc7cdc75","head":{"label":"baob:master","ref":"master","sha":"57857ce2b2378aeace0094e709503361fc7cdc75","user":{"login":"baob","id":55932,"avatar_url":"https://avatars.githubusercontent.com/u/55932?v=3","gravatar_id":"","url":"https://api.github.com/users/baob","html_url":"https://github.com/baob","followers_url":"https://api.github.com/users/baob/followers","following_url":"https://api.github.com/users/baob/following{/other_user}","gists_url":"https://api.github.com/users/baob/gists{/gist_id}","starred_url":"https://api.github.com/users/baob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baob/subscriptions","organizations_url":"https://api.github.com/users/baob/orgs","repos_url":"https://api.github.com/users/baob/repos","events_url":"https://api.github.com/users/baob/events{/privacy}","received_events_url":"https://api.github.com/users/baob/received_events","type":"User","site_admin":false},"repo":{"id":60297312,"name":"play","full_name":"baob/play","owner":{"login":"baob","id":55932,"avatar_url":"https://avatars.githubusercontent.com/u/55932?v=3","gravatar_id":"","url":"https://api.github.com/users/baob","html_url":"https://github.com/baob","followers_url":"https://api.github.com/users/baob/followers","following_url":"https://api.github.com/users/baob/following{/other_user}","gists_url":"https://api.github.com/users/baob/gists{/gist_id}","starred_url":"https://api.github.com/users/baob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baob/subscriptions","organizations_url":"https://api.github.com/users/baob/orgs","repos_url":"https://api.github.com/users/baob/repos","events_url":"https://api.github.com/users/baob/events{/privacy}","received_events_url":"https://api.github.com/users/baob/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/baob/play","description":"Misc explorations","fork":true,"url":"https://api.github.com/repos/baob/play","forks_url":"https://api.github.com/repos/baob/play/forks","keys_url":"https://api.github.com/repos/baob/play/keys{/key_id}","collaborators_url":"https://api.github.com/repos/baob/play/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/baob/play/teams","hooks_url":"https://api.github.com/repos/baob/play/hooks","issue_events_url":"https://api.github.com/repos/baob/play/issues/events{/number}","events_url":"https://api.github.com/repos/baob/play/events","assignees_url":"https://api.github.com/repos/baob/play/assignees{/user}","branches_url":"https://api.github.com/repos/baob/play/branches{/branch}","tags_url":"https://api.github.com/repos/baob/play/tags","blobs_url":"https://api.github.com/repos/baob/play/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/baob/play/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/baob/play/git/refs{/sha}","trees_url":"https://api.github.com/repos/baob/play/git/trees{/sha}","statuses_url":"https://api.github.com/repos/baob/play/statuses/{sha}","languages_url":"https://api.github.com/repos/baob/play/languages","stargazers_url":"https://api.github.com/repos/baob/play/stargazers","contributors_url":"https://api.github.com/repos/baob/play/contributors","subscribers_url":"https://api.github.com/repos/baob/play/subscribers","subscription_url":"https://api.github.com/repos/baob/play/subscription","commits_url":"https://api.github.com/repos/baob/play/commits{/sha}","git_commits_url":"https://api.github.com/repos/baob/play/git/commits{/sha}","comments_url":"https://api.github.com/repos/baob/play/comments{/number}","issue_comment_url":"https://api.github.com/repos/baob/play/issues/comments{/number}","contents_url":"https://api.github.com/repos/baob/play/contents/{+path}","compare_url":"https://api.github.com/repos/baob/play/compare/{base}...{head}","merges_url":"https://api.github.com/repos/baob/play/merges","archive_url":"https://api.github.com/repos/baob/play/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/baob/play/downloads","issues_url":"https://api.github.com/repos/baob/play/issues{/number}","pulls_url":"https://api.github.com/repos/baob/play/pulls{/number}","milestones_url":"https://api.github.com/repos/baob/play/milestones{/number}","notifications_url":"https://api.github.com/repos/baob/play/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/baob/play/labels{/name}","releases_url":"https://api.github.com/repos/baob/play/releases{/id}","deployments_url":"https://api.github.com/repos/baob/play/deployments","created_at":"2016-06-02T21:05:50Z","updated_at":"2016-06-02T21:05:51Z","pushed_at":"2016-06-02T21:33:55Z","git_url":"git://github.com/baob/play.git","ssh_url":"git@github.com:baob/play.git","clone_url":"https://github.com/baob/play.git","svn_url":"https://github.com/baob/play","homepage":null,"size":26,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"skmetz:master","ref":"master","sha":"9bddf72daf6a890b6697806662edd88c903e0962","user":{"login":"skmetz","id":34443,"avatar_url":"https://avatars.githubusercontent.com/u/34443?v=3","gravatar_id":"","url":"https://api.github.com/users/skmetz","html_url":"https://github.com/skmetz","followers_url":"https://api.github.com/users/skmetz/followers","following_url":"https://api.github.com/users/skmetz/following{/other_user}","gists_url":"https://api.github.com/users/skmetz/gists{/gist_id}","starred_url":"https://api.github.com/users/skmetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skmetz/subscriptions","organizations_url":"https://api.github.com/users/skmetz/orgs","repos_url":"https://api.github.com/users/skmetz/repos","events_url":"https://api.github.com/users/skmetz/events{/privacy}","received_events_url":"https://api.github.com/users/skmetz/received_events","type":"User","site_admin":false},"repo":{"id":41089580,"name":"play","full_name":"skmetz/play","owner":{"login":"skmetz","id":34443,"avatar_url":"https://avatars.githubusercontent.com/u/34443?v=3","gravatar_id":"","url":"https://api.github.com/users/skmetz","html_url":"https://github.com/skmetz","followers_url":"https://api.github.com/users/skmetz/followers","following_url":"https://api.github.com/users/skmetz/following{/other_user}","gists_url":"https://api.github.com/users/skmetz/gists{/gist_id}","starred_url":"https://api.github.com/users/skmetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skmetz/subscriptions","organizations_url":"https://api.github.com/users/skmetz/orgs","repos_url":"https://api.github.com/users/skmetz/repos","events_url":"https://api.github.com/users/skmetz/events{/privacy}","received_events_url":"https://api.github.com/users/skmetz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skmetz/play","description":"Misc explorations","fork":false,"url":"https://api.github.com/repos/skmetz/play","forks_url":"https://api.github.com/repos/skmetz/play/forks","keys_url":"https://api.github.com/repos/skmetz/play/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skmetz/play/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skmetz/play/teams","hooks_url":"https://api.github.com/repos/skmetz/play/hooks","issue_events_url":"https://api.github.com/repos/skmetz/play/issues/events{/number}","events_url":"https://api.github.com/repos/skmetz/play/events","assignees_url":"https://api.github.com/repos/skmetz/play/assignees{/user}","branches_url":"https://api.github.com/repos/skmetz/play/branches{/branch}","tags_url":"https://api.github.com/repos/skmetz/play/tags","blobs_url":"https://api.github.com/repos/skmetz/play/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skmetz/play/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skmetz/play/git/refs{/sha}","trees_url":"https://api.github.com/repos/skmetz/play/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skmetz/play/statuses/{sha}","languages_url":"https://api.github.com/repos/skmetz/play/languages","stargazers_url":"https://api.github.com/repos/skmetz/play/stargazers","contributors_url":"https://api.github.com/repos/skmetz/play/contributors","subscribers_url":"https://api.github.com/repos/skmetz/play/subscribers","subscription_url":"https://api.github.com/repos/skmetz/play/subscription","commits_url":"https://api.github.com/repos/skmetz/play/commits{/sha}","git_commits_url":"https://api.github.com/repos/skmetz/play/git/commits{/sha}","comments_url":"https://api.github.com/repos/skmetz/play/comments{/number}","issue_comment_url":"https://api.github.com/repos/skmetz/play/issues/comments{/number}","contents_url":"https://api.github.com/repos/skmetz/play/contents/{+path}","compare_url":"https://api.github.com/repos/skmetz/play/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skmetz/play/merges","archive_url":"https://api.github.com/repos/skmetz/play/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skmetz/play/downloads","issues_url":"https://api.github.com/repos/skmetz/play/issues{/number}","pulls_url":"https://api.github.com/repos/skmetz/play/pulls{/number}","milestones_url":"https://api.github.com/repos/skmetz/play/milestones{/number}","notifications_url":"https://api.github.com/repos/skmetz/play/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skmetz/play/labels{/name}","releases_url":"https://api.github.com/repos/skmetz/play/releases{/id}","deployments_url":"https://api.github.com/repos/skmetz/play/deployments","created_at":"2015-08-20T10:15:50Z","updated_at":"2016-06-02T17:30:13Z","pushed_at":"2016-06-02T21:42:22Z","git_url":"git://github.com/skmetz/play.git","ssh_url":"git@github.com:skmetz/play.git","clone_url":"https://github.com/skmetz/play.git","svn_url":"https://github.com/skmetz/play","homepage":null,"size":25,"stargazers_count":9,"watchers_count":9,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":3,"forks":4,"open_issues":3,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/skmetz/play/pulls/3"},"html":{"href":"https://github.com/skmetz/play/pull/3"},"issue":{"href":"https://api.github.com/repos/skmetz/play/issues/3"},"comments":{"href":"https://api.github.com/repos/skmetz/play/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/skmetz/play/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/skmetz/play/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/skmetz/play/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/skmetz/play/statuses/57857ce2b2378aeace0094e709503361fc7cdc75"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":3,"deletions":5,"changed_files":2}}
{"actor":{"display_login":"baob"}}