{"action":"created","comment":{"url":"https://api.github.com/repos/solson/miri/pulls/comments/65261664","id":65261664,"diff_hunk":"@@ -7,7 +7,11 @@ pub enum EvalError {\n     DanglingPointerDeref,\n     InvalidBool,\n     InvalidDiscriminant,\n-    PointerOutOfBounds,\n+    PointerOutOfBounds {\n+        offset: usize,\n+        size: usize,\n+        len: usize,","path":"src/error.rs","position":14,"original_position":8,"commit_id":"24194ec865a403b8a830d64f79115e5d315bcc1f","original_commit_id":"24194ec865a403b8a830d64f79115e5d315bcc1f","user":{"login":"solson","id":26806,"avatar_url":"https://avatars.githubusercontent.com/u/26806?v=3","gravatar_id":"","url":"https://api.github.com/users/solson","html_url":"https://github.com/solson","followers_url":"https://api.github.com/users/solson/followers","following_url":"https://api.github.com/users/solson/following{/other_user}","gists_url":"https://api.github.com/users/solson/gists{/gist_id}","starred_url":"https://api.github.com/users/solson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solson/subscriptions","organizations_url":"https://api.github.com/users/solson/orgs","repos_url":"https://api.github.com/users/solson/repos","events_url":"https://api.github.com/users/solson/events{/privacy}","received_events_url":"https://api.github.com/users/solson/received_events","type":"User","site_admin":false},"body":"Can you rename `len` to something like `alloc_size` or `alloc_len` to make this clearer? It might be worth sticking the `AllocId` in here, too.\r\n\r\n(Really all the error variants need more information in them, which I have neglected so far.)","created_at":"2016-05-31T20:59:07Z","updated_at":"2016-05-31T20:59:07Z","html_url":"https://github.com/solson/miri/pull/15#discussion_r65261664","pull_request_url":"https://api.github.com/repos/solson/miri/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/solson/miri/pulls/comments/65261664"},"html":{"href":"https://github.com/solson/miri/pull/15#discussion_r65261664"},"pull_request":{"href":"https://api.github.com/repos/solson/miri/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/solson/miri/pulls/15","id":71989967,"html_url":"https://github.com/solson/miri/pull/15","diff_url":"https://github.com/solson/miri/pull/15.diff","patch_url":"https://github.com/solson/miri/pull/15.patch","issue_url":"https://api.github.com/repos/solson/miri/issues/15","number":15,"state":"open","locked":false,"title":"4 byte pointers + tests","user":{"login":"oli-obk","id":332036,"avatar_url":"https://avatars.githubusercontent.com/u/332036?v=3","gravatar_id":"","url":"https://api.github.com/users/oli-obk","html_url":"https://github.com/oli-obk","followers_url":"https://api.github.com/users/oli-obk/followers","following_url":"https://api.github.com/users/oli-obk/following{/other_user}","gists_url":"https://api.github.com/users/oli-obk/gists{/gist_id}","starred_url":"https://api.github.com/users/oli-obk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oli-obk/subscriptions","organizations_url":"https://api.github.com/users/oli-obk/orgs","repos_url":"https://api.github.com/users/oli-obk/repos","events_url":"https://api.github.com/users/oli-obk/events{/privacy}","received_events_url":"https://api.github.com/users/oli-obk/received_events","type":"User","site_admin":false},"body":"Right now this expects the target and host to be linux. I haven't figured out how to make compiletest not actually compile the run-pass tests (since we don't need to run them, miri runs during compilation).\r\n\r\nWe could add them as compile-fail tests and have the miri executable generate a \"miri succeeded\" error\r\n\r\nOnce that works, it would be possible to automatically detects all installed targets and run miri for all of them.\r\n\r\nThe commits should probably be read one by one. I can split them into multiple PRs if preferred and/or remove some of them (like the indentation hack with a `static mut`).","created_at":"2016-05-31T10:11:10Z","updated_at":"2016-05-31T20:59:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0326bd5f0488db1557f66bf056883f65c5415a75","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/solson/miri/pulls/15/commits","review_comments_url":"https://api.github.com/repos/solson/miri/pulls/15/comments","review_comment_url":"https://api.github.com/repos/solson/miri/pulls/comments{/number}","comments_url":"https://api.github.com/repos/solson/miri/issues/15/comments","statuses_url":"https://api.github.com/repos/solson/miri/statuses/24194ec865a403b8a830d64f79115e5d315bcc1f","head":{"label":"oli-obk:step_by_step","ref":"step_by_step","sha":"24194ec865a403b8a830d64f79115e5d315bcc1f","user":{"login":"oli-obk","id":332036,"avatar_url":"https://avatars.githubusercontent.com/u/332036?v=3","gravatar_id":"","url":"https://api.github.com/users/oli-obk","html_url":"https://github.com/oli-obk","followers_url":"https://api.github.com/users/oli-obk/followers","following_url":"https://api.github.com/users/oli-obk/following{/other_user}","gists_url":"https://api.github.com/users/oli-obk/gists{/gist_id}","starred_url":"https://api.github.com/users/oli-obk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oli-obk/subscriptions","organizations_url":"https://api.github.com/users/oli-obk/orgs","repos_url":"https://api.github.com/users/oli-obk/repos","events_url":"https://api.github.com/users/oli-obk/events{/privacy}","received_events_url":"https://api.github.com/users/oli-obk/received_events","type":"User","site_admin":false},"repo":{"id":51430710,"name":"miri","full_name":"oli-obk/miri","owner":{"login":"oli-obk","id":332036,"avatar_url":"https://avatars.githubusercontent.com/u/332036?v=3","gravatar_id":"","url":"https://api.github.com/users/oli-obk","html_url":"https://github.com/oli-obk","followers_url":"https://api.github.com/users/oli-obk/followers","following_url":"https://api.github.com/users/oli-obk/following{/other_user}","gists_url":"https://api.github.com/users/oli-obk/gists{/gist_id}","starred_url":"https://api.github.com/users/oli-obk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oli-obk/subscriptions","organizations_url":"https://api.github.com/users/oli-obk/orgs","repos_url":"https://api.github.com/users/oli-obk/repos","events_url":"https://api.github.com/users/oli-obk/events{/privacy}","received_events_url":"https://api.github.com/users/oli-obk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oli-obk/miri","description":"An experimental interpreter for Rust MIR","fork":true,"url":"https://api.github.com/repos/oli-obk/miri","forks_url":"https://api.github.com/repos/oli-obk/miri/forks","keys_url":"https://api.github.com/repos/oli-obk/miri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oli-obk/miri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oli-obk/miri/teams","hooks_url":"https://api.github.com/repos/oli-obk/miri/hooks","issue_events_url":"https://api.github.com/repos/oli-obk/miri/issues/events{/number}","events_url":"https://api.github.com/repos/oli-obk/miri/events","assignees_url":"https://api.github.com/repos/oli-obk/miri/assignees{/user}","branches_url":"https://api.github.com/repos/oli-obk/miri/branches{/branch}","tags_url":"https://api.github.com/repos/oli-obk/miri/tags","blobs_url":"https://api.github.com/repos/oli-obk/miri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oli-obk/miri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oli-obk/miri/git/refs{/sha}","trees_url":"https://api.github.com/repos/oli-obk/miri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oli-obk/miri/statuses/{sha}","languages_url":"https://api.github.com/repos/oli-obk/miri/languages","stargazers_url":"https://api.github.com/repos/oli-obk/miri/stargazers","contributors_url":"https://api.github.com/repos/oli-obk/miri/contributors","subscribers_url":"https://api.github.com/repos/oli-obk/miri/subscribers","subscription_url":"https://api.github.com/repos/oli-obk/miri/subscription","commits_url":"https://api.github.com/repos/oli-obk/miri/commits{/sha}","git_commits_url":"https://api.github.com/repos/oli-obk/miri/git/commits{/sha}","comments_url":"https://api.github.com/repos/oli-obk/miri/comments{/number}","issue_comment_url":"https://api.github.com/repos/oli-obk/miri/issues/comments{/number}","contents_url":"https://api.github.com/repos/oli-obk/miri/contents/{+path}","compare_url":"https://api.github.com/repos/oli-obk/miri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oli-obk/miri/merges","archive_url":"https://api.github.com/repos/oli-obk/miri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oli-obk/miri/downloads","issues_url":"https://api.github.com/repos/oli-obk/miri/issues{/number}","pulls_url":"https://api.github.com/repos/oli-obk/miri/pulls{/number}","milestones_url":"https://api.github.com/repos/oli-obk/miri/milestones{/number}","notifications_url":"https://api.github.com/repos/oli-obk/miri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oli-obk/miri/labels{/name}","releases_url":"https://api.github.com/repos/oli-obk/miri/releases{/id}","deployments_url":"https://api.github.com/repos/oli-obk/miri/deployments","created_at":"2016-02-10T09:10:02Z","updated_at":"2016-02-10T09:10:02Z","pushed_at":"2016-05-31T14:51:51Z","git_url":"git://github.com/oli-obk/miri.git","ssh_url":"git@github.com:oli-obk/miri.git","clone_url":"https://github.com/oli-obk/miri.git","svn_url":"https://github.com/oli-obk/miri","homepage":null,"size":409,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"solson:master","ref":"master","sha":"f3923eeb50e80e17b4529ae2e3c269fbb682bfed","user":{"login":"solson","id":26806,"avatar_url":"https://avatars.githubusercontent.com/u/26806?v=3","gravatar_id":"","url":"https://api.github.com/users/solson","html_url":"https://github.com/solson","followers_url":"https://api.github.com/users/solson/followers","following_url":"https://api.github.com/users/solson/following{/other_user}","gists_url":"https://api.github.com/users/solson/gists{/gist_id}","starred_url":"https://api.github.com/users/solson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solson/subscriptions","organizations_url":"https://api.github.com/users/solson/orgs","repos_url":"https://api.github.com/users/solson/repos","events_url":"https://api.github.com/users/solson/events{/privacy}","received_events_url":"https://api.github.com/users/solson/received_events","type":"User","site_admin":false},"repo":{"id":46083140,"name":"miri","full_name":"solson/miri","owner":{"login":"solson","id":26806,"avatar_url":"https://avatars.githubusercontent.com/u/26806?v=3","gravatar_id":"","url":"https://api.github.com/users/solson","html_url":"https://github.com/solson","followers_url":"https://api.github.com/users/solson/followers","following_url":"https://api.github.com/users/solson/following{/other_user}","gists_url":"https://api.github.com/users/solson/gists{/gist_id}","starred_url":"https://api.github.com/users/solson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solson/subscriptions","organizations_url":"https://api.github.com/users/solson/orgs","repos_url":"https://api.github.com/users/solson/repos","events_url":"https://api.github.com/users/solson/events{/privacy}","received_events_url":"https://api.github.com/users/solson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/solson/miri","description":"An experimental interpreter for Rust MIR","fork":false,"url":"https://api.github.com/repos/solson/miri","forks_url":"https://api.github.com/repos/solson/miri/forks","keys_url":"https://api.github.com/repos/solson/miri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/solson/miri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/solson/miri/teams","hooks_url":"https://api.github.com/repos/solson/miri/hooks","issue_events_url":"https://api.github.com/repos/solson/miri/issues/events{/number}","events_url":"https://api.github.com/repos/solson/miri/events","assignees_url":"https://api.github.com/repos/solson/miri/assignees{/user}","branches_url":"https://api.github.com/repos/solson/miri/branches{/branch}","tags_url":"https://api.github.com/repos/solson/miri/tags","blobs_url":"https://api.github.com/repos/solson/miri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/solson/miri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/solson/miri/git/refs{/sha}","trees_url":"https://api.github.com/repos/solson/miri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/solson/miri/statuses/{sha}","languages_url":"https://api.github.com/repos/solson/miri/languages","stargazers_url":"https://api.github.com/repos/solson/miri/stargazers","contributors_url":"https://api.github.com/repos/solson/miri/contributors","subscribers_url":"https://api.github.com/repos/solson/miri/subscribers","subscription_url":"https://api.github.com/repos/solson/miri/subscription","commits_url":"https://api.github.com/repos/solson/miri/commits{/sha}","git_commits_url":"https://api.github.com/repos/solson/miri/git/commits{/sha}","comments_url":"https://api.github.com/repos/solson/miri/comments{/number}","issue_comment_url":"https://api.github.com/repos/solson/miri/issues/comments{/number}","contents_url":"https://api.github.com/repos/solson/miri/contents/{+path}","compare_url":"https://api.github.com/repos/solson/miri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/solson/miri/merges","archive_url":"https://api.github.com/repos/solson/miri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/solson/miri/downloads","issues_url":"https://api.github.com/repos/solson/miri/issues{/number}","pulls_url":"https://api.github.com/repos/solson/miri/pulls{/number}","milestones_url":"https://api.github.com/repos/solson/miri/milestones{/number}","notifications_url":"https://api.github.com/repos/solson/miri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/solson/miri/labels{/name}","releases_url":"https://api.github.com/repos/solson/miri/releases{/id}","deployments_url":"https://api.github.com/repos/solson/miri/deployments","created_at":"2015-11-12T21:51:25Z","updated_at":"2016-05-30T17:50:53Z","pushed_at":"2016-05-31T10:11:10Z","git_url":"git://github.com/solson/miri.git","ssh_url":"git@github.com:solson/miri.git","clone_url":"https://github.com/solson/miri.git","svn_url":"https://github.com/solson/miri","homepage":null,"size":411,"stargazers_count":66,"watchers_count":66,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":3,"forks":10,"open_issues":3,"watchers":66,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/solson/miri/pulls/15"},"html":{"href":"https://github.com/solson/miri/pull/15"},"issue":{"href":"https://api.github.com/repos/solson/miri/issues/15"},"comments":{"href":"https://api.github.com/repos/solson/miri/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/solson/miri/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/solson/miri/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/solson/miri/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/solson/miri/statuses/24194ec865a403b8a830d64f79115e5d315bcc1f"}}}}
{"actor":{"display_login":"solson"}}