{"action":"created","issue":{"url":"https://api.github.com/repos/webpack/webpack.js.org/issues/284","repository_url":"https://api.github.com/repos/webpack/webpack.js.org","labels_url":"https://api.github.com/repos/webpack/webpack.js.org/issues/284/labels{/name}","comments_url":"https://api.github.com/repos/webpack/webpack.js.org/issues/284/comments","events_url":"https://api.github.com/repos/webpack/webpack.js.org/issues/284/events","html_url":"https://github.com/webpack/webpack.js.org/pull/284","id":186500450,"number":284,"title":"Connect search interface to search results","user":{"login":"dzello","id":174777,"avatar_url":"https://avatars.githubusercontent.com/u/174777?v=3","gravatar_id":"","url":"https://api.github.com/users/dzello","html_url":"https://github.com/dzello","followers_url":"https://api.github.com/users/dzello/followers","following_url":"https://api.github.com/users/dzello/following{/other_user}","gists_url":"https://api.github.com/users/dzello/gists{/gist_id}","starred_url":"https://api.github.com/users/dzello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzello/subscriptions","organizations_url":"https://api.github.com/users/dzello/orgs","repos_url":"https://api.github.com/users/dzello/repos","events_url":"https://api.github.com/users/dzello/events{/privacy}","received_events_url":"https://api.github.com/users/dzello/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2016-11-01T10:17:33Z","updated_at":"2016-11-04T07:18:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/webpack/webpack.js.org/pulls/284","html_url":"https://github.com/webpack/webpack.js.org/pull/284","diff_url":"https://github.com/webpack/webpack.js.org/pull/284.diff","patch_url":"https://github.com/webpack/webpack.js.org/pull/284.patch"},"body":"This PR wires up the new search box with the [DocSearch](https://github.com/algolia/docsearch) JS and corresponding CSS. DocSearch takes care of handling keystrokes, submitting the queries to the webpack.js.org Algolia index, and displaying the results in an overlay.\r\n\r\nFor now, I commented out a small piece of code in `search-results.jsx` responsible for showing the overlay, as DocSearch has its own. DocSearch will close the overlay if the user clicks on a result, clicks outside the modal, or hits the escape key.\r\n\r\nAs you're testing locally, you might see that clicking a search result takes you to `https://webpack.js.org` and not to `localhost:3000`. That is because the index is built from `https://webpack.js.org`. Once we get search & results functionality deployed, the URL in the search result will match the URL in the browser and we can test the on-page transitions. If we want to test transitions  before then I can create an index with records pointing to `localhost:3000`, but that seemed like extra work for now and I think the transitions should just work. The index is rebuilt from the latest site every 24 hours, so any changes will be picked up automatically and we can verify soon after a new site build is out.\r\n\r\nFor now, can someone with a keen visual eye have look at the styling and suggest any improvements? This is the list of [CSS customizations](https://github.com/algolia/docsearch#customization) we can make. Thanks!"},"comment":{"url":"https://api.github.com/repos/webpack/webpack.js.org/issues/comments/258360175","html_url":"https://github.com/webpack/webpack.js.org/pull/284#issuecomment-258360175","issue_url":"https://api.github.com/repos/webpack/webpack.js.org/issues/284","id":258360175,"user":{"login":"skipjack","id":8988697,"avatar_url":"https://avatars.githubusercontent.com/u/8988697?v=3","gravatar_id":"","url":"https://api.github.com/users/skipjack","html_url":"https://github.com/skipjack","followers_url":"https://api.github.com/users/skipjack/followers","following_url":"https://api.github.com/users/skipjack/following{/other_user}","gists_url":"https://api.github.com/users/skipjack/gists{/gist_id}","starred_url":"https://api.github.com/users/skipjack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skipjack/subscriptions","organizations_url":"https://api.github.com/users/skipjack/orgs","repos_url":"https://api.github.com/users/skipjack/repos","events_url":"https://api.github.com/users/skipjack/events{/privacy}","received_events_url":"https://api.github.com/users/skipjack/received_events","type":"User","site_admin":false},"created_at":"2016-11-04T07:18:36Z","updated_at":"2016-11-04T07:18:36Z","body":"Got it working, had to navigate around preact/react state for now. Any thoughts on how I should push these changes to this PR? There's a significant amount, as I cleaned up some other stuff relating to this."}}
{"actor":{"display_login":"skipjack"}}