{"action":"created","issue":{"url":"https://api.github.com/repos/aurelia/cli/issues/431","repository_url":"https://api.github.com/repos/aurelia/cli","labels_url":"https://api.github.com/repos/aurelia/cli/issues/431/labels{/name}","comments_url":"https://api.github.com/repos/aurelia/cli/issues/431/comments","events_url":"https://api.github.com/repos/aurelia/cli/issues/431/events","html_url":"https://github.com/aurelia/cli/pull/431","id":193652051,"number":431,"title":"Remove tracing","user":{"login":"huochunpeng","id":1188806,"avatar_url":"https://avatars.githubusercontent.com/u/1188806?v=3","gravatar_id":"","url":"https://api.github.com/users/huochunpeng","html_url":"https://github.com/huochunpeng","followers_url":"https://api.github.com/users/huochunpeng/followers","following_url":"https://api.github.com/users/huochunpeng/following{/other_user}","gists_url":"https://api.github.com/users/huochunpeng/gists{/gist_id}","starred_url":"https://api.github.com/users/huochunpeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huochunpeng/subscriptions","organizations_url":"https://api.github.com/users/huochunpeng/orgs","repos_url":"https://api.github.com/users/huochunpeng/repos","events_url":"https://api.github.com/users/huochunpeng/events{/privacy}","received_events_url":"https://api.github.com/users/huochunpeng/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-12-06T00:39:12Z","updated_at":"2016-12-08T20:28:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/aurelia/cli/pulls/431","html_url":"https://github.com/aurelia/cli/pull/431","diff_url":"https://github.com/aurelia/cli/pull/431.diff","patch_url":"https://github.com/aurelia/cli/pull/431.patch"},"body":"**This branch is not in clean state to be merged.**\r\n\r\nAs expected, `au build` is slightly faster than #419.\r\n\r\nWhile working on #419 , I realise cli doesn't really need amodro-trace. What amodro-trace brings to the table are two things.\r\n1. ensure all deps are bundled. (this can be achieved with modified aurelia.json)\r\n2. tranform all modules, more explicitly only need `write/defines.js` and `write/stubs.js`. (even stubs.js is not really needed, if we don't provide feature to stub module)\r\n\r\nThis branch removed tracing step, replaced it with just writeTransform on \"cjs\", \"defines\" and \"stubs\".\r\n\r\nTo use `\"aurelia-cli\": \"git://github.com/huochunpeng/cli.git#remove_tracing\",` in your app's package.json, you need to modify your `aurelia.json` to ensure all deps are bundled without tracing.\r\n\r\nLuckily, you only need to modify vendor-bundle section to add `\"resources\": [\"**/*.js\"]` for some aurelia packages.\r\n\r\nFor reference Here is my vendor-bundle section. I modified **\"aurelia-dialog\", \"aurelia-templating-resources\", \"aurelia-templating-router\", \"aurelia-testing\", and \"aurelia-i18n\"**.\r\n```\r\n{\r\n        \"name\": \"vendor-bundle.js\",\r\n        \"prepend\": [\r\n          \"node_modules/whatwg-fetch/fetch.js\",\r\n          \"node_modules/keymaster/keymaster.js\",\r\n          \"node_modules/bluebird/js/browser/bluebird.core.js\",\r\n          \"scripts/bluebird_turnon_cancellation.js\",\r\n          \"css/swell/js/vendor/jquery-1.11.2.min.js\",\r\n          \"css/jquery.gritter/js/jquery.gritter.min.js\",\r\n          \"css/swell/js/vendor/bootstrap.min.js\",\r\n          \"node_modules/moment/min/moment.min.js\",\r\n          \"css/swell/js/vendor/bootstrap-datetimepicker.js\",\r\n          \"css/swell/js/controls.js\",\r\n          \"css/bcxlib.js\",\r\n          \"node_modules/highcharts/highcharts.js\",\r\n          \"scripts/highcharts_options.js\",\r\n          \"node_modules/requirejs/require.js\"\r\n        ],\r\n        \"dependencies\": [\r\n          \"aurelia-binding\",\r\n          \"aurelia-bootstrapper\",\r\n          \"aurelia-dependency-injection\",\r\n          \"aurelia-event-aggregator\",\r\n          \"aurelia-fetch-client\",\r\n          \"aurelia-framework\",\r\n          \"aurelia-history\",\r\n          \"aurelia-history-browser\",\r\n          \"aurelia-loader\",\r\n          \"aurelia-loader-default\",\r\n          \"aurelia-logging\",\r\n          \"aurelia-logging-console\",\r\n          \"aurelia-metadata\",\r\n          \"aurelia-pal\",\r\n          \"aurelia-pal-browser\",\r\n          \"aurelia-path\",\r\n          \"aurelia-polyfills\",\r\n          \"aurelia-route-recognizer\",\r\n          \"aurelia-router\",\r\n          \"aurelia-task-queue\",\r\n          \"aurelia-templating\",\r\n          \"aurelia-templating-binding\",\r\n          \"text\",\r\n          {\r\n            \"name\": \"aurelia-dialog\",\r\n            \"path\": \"../node_modules/aurelia-dialog/dist/amd\",\r\n            \"main\": \"aurelia-dialog\",\r\n            \"resources\": [\r\n              \"**/*.js\"\r\n            ]\r\n          },\r\n          {\r\n            \"name\": \"aurelia-templating-resources\",\r\n            \"path\": \"../node_modules/aurelia-templating-resources/dist/amd\",\r\n            \"main\": \"aurelia-templating-resources\",\r\n            \"resources\": [\r\n              \"**/*.js\"\r\n            ]\r\n          },\r\n          {\r\n            \"name\": \"aurelia-templating-router\",\r\n            \"path\": \"../node_modules/aurelia-templating-router/dist/amd\",\r\n            \"main\": \"aurelia-templating-router\",\r\n            \"resources\": [\r\n              \"**/*.js\"\r\n            ]\r\n          },\r\n          {\r\n            \"name\": \"aurelia-testing\",\r\n            \"path\": \"../node_modules/aurelia-testing/dist/amd\",\r\n            \"main\": \"aurelia-testing\",\r\n            \"env\": \"dev\",\r\n            \"resources\": [\r\n              \"**/*.js\"\r\n            ]\r\n          },\r\n          {\r\n            \"name\": \"intl\",\r\n            \"path\": \"../node_modules/intl/dist\",\r\n            \"main\": \"Intl.min\"\r\n          },\r\n          {\r\n            \"name\": \"i18next\",\r\n            \"path\": \"../node_modules/i18next/dist/umd\",\r\n            \"main\": \"i18next\"\r\n          },\r\n          {\r\n            \"name\": \"aurelia-i18n\",\r\n            \"path\": \"../node_modules/aurelia-i18n/dist/amd\",\r\n            \"main\": \"aurelia-i18n\",\r\n            \"resources\": [\r\n              \"**/*.js\"\r\n            ]\r\n          },\r\n          {\r\n            \"name\": \"nprogress\",\r\n            \"path\": \"../node_modules/nprogress\",\r\n            \"main\": \"nprogress\",\r\n            \"resources\": [\r\n              \"nprogress.css\"\r\n            ]\r\n          },\r\n          \"lodash\",\r\n          \"numeral\",\r\n          \"node-uuid\",\r\n          \"dropzone\",\r\n          {\r\n            \"name\": \"mock/generate\",\r\n            \"path\": \"../mock\",\r\n            \"main\": \"generate\",\r\n            \"env\": \"dev\"\r\n          },\r\n          {\r\n            \"name\": \"codemirror\",\r\n            \"path\": \"../node_modules/codemirror\",\r\n            \"main\": \"lib/codemirror\",\r\n            \"resources\": [\r\n              \"addon/selection/active-line.js\",\r\n              \"addon/display/fullscreen.js\",\r\n              \"addon/display/fullscreen.css\",\r\n              \"addon/dialog/dialog.js\",\r\n              \"addon/dialog/dialog.css\",\r\n              \"addon/search/searchcursor.js\",\r\n              \"addon/search/search.js\",\r\n              \"addon/mode/simple.js\",\r\n              \"mode/shell/shell.js\",\r\n              \"mode/perl/perl.js\",\r\n              \"mode/ruby/ruby.js\",\r\n              \"mode/python/python.js\",\r\n              \"mode/sql/sql.js\",\r\n              \"mode/powershell/powershell.js\",\r\n              \"lib/codemirror.css\",\r\n              \"theme/abcdef.css\"\r\n            ]\r\n          }\r\n        ]\r\n      }\r\n```\r\n\r\nI am running my production app against this branch.\r\nWelcome more testing.\r\n"},"comment":{"url":"https://api.github.com/repos/aurelia/cli/issues/comments/265846306","html_url":"https://github.com/aurelia/cli/pull/431#issuecomment-265846306","issue_url":"https://api.github.com/repos/aurelia/cli/issues/431","id":265846306,"user":{"login":"huochunpeng","id":1188806,"avatar_url":"https://avatars.githubusercontent.com/u/1188806?v=3","gravatar_id":"","url":"https://api.github.com/users/huochunpeng","html_url":"https://github.com/huochunpeng","followers_url":"https://api.github.com/users/huochunpeng/followers","following_url":"https://api.github.com/users/huochunpeng/following{/other_user}","gists_url":"https://api.github.com/users/huochunpeng/gists{/gist_id}","starred_url":"https://api.github.com/users/huochunpeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huochunpeng/subscriptions","organizations_url":"https://api.github.com/users/huochunpeng/orgs","repos_url":"https://api.github.com/users/huochunpeng/repos","events_url":"https://api.github.com/users/huochunpeng/events{/privacy}","received_events_url":"https://api.github.com/users/huochunpeng/received_events","type":"User","site_admin":false},"created_at":"2016-12-08T20:28:22Z","updated_at":"2016-12-08T20:28:22Z","body":"Sorry, clicked wrong button."}}
{"actor":{"display_login":"huochunpeng"}}