{"action":"created","comment":{"url":"https://api.github.com/repos/warehouseai/cdnup/pulls/comments/94170508","pull_request_review_id":14701542,"id":94170508,"diff_hunk":"@@ -97,11 +97,7 @@ CDNUp.prototype.url = function () {\n     ? this.urls[Math.floor(Math.random() * this.urls.length)]\n     : this.urls[0];\n \n-  //\n-  // Remark: (jcrugzz) If a URL wasnt configured, we guess and use the endpoint for s3.\n-  // This may be incorrect but we do this or we error /shrug\n-  //\n-  prefix = prefix || this.client.config.endpoint;\n+  prefix = prefix || (this.client.protocol + this.client.endpoint);","path":"index.js","position":9,"original_position":9,"commit_id":"0e9b0da0e496dd9186e433ebaf1476c634900205","original_commit_id":"0e9b0da0e496dd9186e433ebaf1476c634900205","user":{"login":"jcrugzz","id":592149,"avatar_url":"https://avatars.githubusercontent.com/u/592149?v=3","gravatar_id":"","url":"https://api.github.com/users/jcrugzz","html_url":"https://github.com/jcrugzz","followers_url":"https://api.github.com/users/jcrugzz/followers","following_url":"https://api.github.com/users/jcrugzz/following{/other_user}","gists_url":"https://api.github.com/users/jcrugzz/gists{/gist_id}","starred_url":"https://api.github.com/users/jcrugzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcrugzz/subscriptions","organizations_url":"https://api.github.com/users/jcrugzz/orgs","repos_url":"https://api.github.com/users/jcrugzz/repos","events_url":"https://api.github.com/users/jcrugzz/events{/privacy}","received_events_url":"https://api.github.com/users/jcrugzz/received_events","type":"User","site_admin":false},"body":"they end up being the same value since it gets assigned to the client from the config. it just seemed nicer to do it this way.","created_at":"2016-12-29T19:19:40Z","updated_at":"2016-12-29T19:19:40Z","html_url":"https://github.com/warehouseai/cdnup/pull/1#discussion_r94170508","pull_request_url":"https://api.github.com/repos/warehouseai/cdnup/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/warehouseai/cdnup/pulls/comments/94170508"},"html":{"href":"https://github.com/warehouseai/cdnup/pull/1#discussion_r94170508"},"pull_request":{"href":"https://api.github.com/repos/warehouseai/cdnup/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/warehouseai/cdnup/pulls/1","id":99590769,"html_url":"https://github.com/warehouseai/cdnup/pull/1","diff_url":"https://github.com/warehouseai/cdnup/pull/1.diff","patch_url":"https://github.com/warehouseai/cdnup/pull/1.patch","issue_url":"https://api.github.com/repos/warehouseai/cdnup/issues/1","number":1,"state":"open","locked":false,"title":"[fix] correctly default the URL based on what we pass into pkgcloud","user":{"login":"jcrugzz","id":592149,"avatar_url":"https://avatars.githubusercontent.com/u/592149?v=3","gravatar_id":"","url":"https://api.github.com/users/jcrugzz","html_url":"https://github.com/jcrugzz","followers_url":"https://api.github.com/users/jcrugzz/followers","following_url":"https://api.github.com/users/jcrugzz/following{/other_user}","gists_url":"https://api.github.com/users/jcrugzz/gists{/gist_id}","starred_url":"https://api.github.com/users/jcrugzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcrugzz/subscriptions","organizations_url":"https://api.github.com/users/jcrugzz/orgs","repos_url":"https://api.github.com/users/jcrugzz/repos","events_url":"https://api.github.com/users/jcrugzz/events{/privacy}","received_events_url":"https://api.github.com/users/jcrugzz/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-12-28T20:44:37Z","updated_at":"2016-12-29T19:19:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c18609c7137e938f1d1e24e48cbbda2bb9af1982","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/warehouseai/cdnup/pulls/1/commits","review_comments_url":"https://api.github.com/repos/warehouseai/cdnup/pulls/1/comments","review_comment_url":"https://api.github.com/repos/warehouseai/cdnup/pulls/comments{/number}","comments_url":"https://api.github.com/repos/warehouseai/cdnup/issues/1/comments","statuses_url":"https://api.github.com/repos/warehouseai/cdnup/statuses/0e9b0da0e496dd9186e433ebaf1476c634900205","head":{"label":"warehouseai:correct-default","ref":"correct-default","sha":"0e9b0da0e496dd9186e433ebaf1476c634900205","user":{"login":"warehouseai","id":10928397,"avatar_url":"https://avatars.githubusercontent.com/u/10928397?v=3","gravatar_id":"","url":"https://api.github.com/users/warehouseai","html_url":"https://github.com/warehouseai","followers_url":"https://api.github.com/users/warehouseai/followers","following_url":"https://api.github.com/users/warehouseai/following{/other_user}","gists_url":"https://api.github.com/users/warehouseai/gists{/gist_id}","starred_url":"https://api.github.com/users/warehouseai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warehouseai/subscriptions","organizations_url":"https://api.github.com/users/warehouseai/orgs","repos_url":"https://api.github.com/users/warehouseai/repos","events_url":"https://api.github.com/users/warehouseai/events{/privacy}","received_events_url":"https://api.github.com/users/warehouseai/received_events","type":"Organization","site_admin":false},"repo":{"id":75198324,"name":"cdnup","full_name":"warehouseai/cdnup","owner":{"login":"warehouseai","id":10928397,"avatar_url":"https://avatars.githubusercontent.com/u/10928397?v=3","gravatar_id":"","url":"https://api.github.com/users/warehouseai","html_url":"https://github.com/warehouseai","followers_url":"https://api.github.com/users/warehouseai/followers","following_url":"https://api.github.com/users/warehouseai/following{/other_user}","gists_url":"https://api.github.com/users/warehouseai/gists{/gist_id}","starred_url":"https://api.github.com/users/warehouseai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warehouseai/subscriptions","organizations_url":"https://api.github.com/users/warehouseai/orgs","repos_url":"https://api.github.com/users/warehouseai/repos","events_url":"https://api.github.com/users/warehouseai/events{/privacy}","received_events_url":"https://api.github.com/users/warehouseai/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/warehouseai/cdnup","description":"CDN uploader with configurable URL resolution","fork":false,"url":"https://api.github.com/repos/warehouseai/cdnup","forks_url":"https://api.github.com/repos/warehouseai/cdnup/forks","keys_url":"https://api.github.com/repos/warehouseai/cdnup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/warehouseai/cdnup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/warehouseai/cdnup/teams","hooks_url":"https://api.github.com/repos/warehouseai/cdnup/hooks","issue_events_url":"https://api.github.com/repos/warehouseai/cdnup/issues/events{/number}","events_url":"https://api.github.com/repos/warehouseai/cdnup/events","assignees_url":"https://api.github.com/repos/warehouseai/cdnup/assignees{/user}","branches_url":"https://api.github.com/repos/warehouseai/cdnup/branches{/branch}","tags_url":"https://api.github.com/repos/warehouseai/cdnup/tags","blobs_url":"https://api.github.com/repos/warehouseai/cdnup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/warehouseai/cdnup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/warehouseai/cdnup/git/refs{/sha}","trees_url":"https://api.github.com/repos/warehouseai/cdnup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/warehouseai/cdnup/statuses/{sha}","languages_url":"https://api.github.com/repos/warehouseai/cdnup/languages","stargazers_url":"https://api.github.com/repos/warehouseai/cdnup/stargazers","contributors_url":"https://api.github.com/repos/warehouseai/cdnup/contributors","subscribers_url":"https://api.github.com/repos/warehouseai/cdnup/subscribers","subscription_url":"https://api.github.com/repos/warehouseai/cdnup/subscription","commits_url":"https://api.github.com/repos/warehouseai/cdnup/commits{/sha}","git_commits_url":"https://api.github.com/repos/warehouseai/cdnup/git/commits{/sha}","comments_url":"https://api.github.com/repos/warehouseai/cdnup/comments{/number}","issue_comment_url":"https://api.github.com/repos/warehouseai/cdnup/issues/comments{/number}","contents_url":"https://api.github.com/repos/warehouseai/cdnup/contents/{+path}","compare_url":"https://api.github.com/repos/warehouseai/cdnup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/warehouseai/cdnup/merges","archive_url":"https://api.github.com/repos/warehouseai/cdnup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/warehouseai/cdnup/downloads","issues_url":"https://api.github.com/repos/warehouseai/cdnup/issues{/number}","pulls_url":"https://api.github.com/repos/warehouseai/cdnup/pulls{/number}","milestones_url":"https://api.github.com/repos/warehouseai/cdnup/milestones{/number}","notifications_url":"https://api.github.com/repos/warehouseai/cdnup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/warehouseai/cdnup/labels{/name}","releases_url":"https://api.github.com/repos/warehouseai/cdnup/releases{/id}","deployments_url":"https://api.github.com/repos/warehouseai/cdnup/deployments","created_at":"2016-11-30T15:08:17Z","updated_at":"2016-11-30T16:56:56Z","pushed_at":"2016-12-28T20:44:38Z","git_url":"git://github.com/warehouseai/cdnup.git","ssh_url":"git@github.com:warehouseai/cdnup.git","clone_url":"https://github.com/warehouseai/cdnup.git","svn_url":"https://github.com/warehouseai/cdnup","homepage":null,"size":8,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"warehouseai:master","ref":"master","sha":"626a68abe74d4ccb6811e4dc274689db47cd5f45","user":{"login":"warehouseai","id":10928397,"avatar_url":"https://avatars.githubusercontent.com/u/10928397?v=3","gravatar_id":"","url":"https://api.github.com/users/warehouseai","html_url":"https://github.com/warehouseai","followers_url":"https://api.github.com/users/warehouseai/followers","following_url":"https://api.github.com/users/warehouseai/following{/other_user}","gists_url":"https://api.github.com/users/warehouseai/gists{/gist_id}","starred_url":"https://api.github.com/users/warehouseai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warehouseai/subscriptions","organizations_url":"https://api.github.com/users/warehouseai/orgs","repos_url":"https://api.github.com/users/warehouseai/repos","events_url":"https://api.github.com/users/warehouseai/events{/privacy}","received_events_url":"https://api.github.com/users/warehouseai/received_events","type":"Organization","site_admin":false},"repo":{"id":75198324,"name":"cdnup","full_name":"warehouseai/cdnup","owner":{"login":"warehouseai","id":10928397,"avatar_url":"https://avatars.githubusercontent.com/u/10928397?v=3","gravatar_id":"","url":"https://api.github.com/users/warehouseai","html_url":"https://github.com/warehouseai","followers_url":"https://api.github.com/users/warehouseai/followers","following_url":"https://api.github.com/users/warehouseai/following{/other_user}","gists_url":"https://api.github.com/users/warehouseai/gists{/gist_id}","starred_url":"https://api.github.com/users/warehouseai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warehouseai/subscriptions","organizations_url":"https://api.github.com/users/warehouseai/orgs","repos_url":"https://api.github.com/users/warehouseai/repos","events_url":"https://api.github.com/users/warehouseai/events{/privacy}","received_events_url":"https://api.github.com/users/warehouseai/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/warehouseai/cdnup","description":"CDN uploader with configurable URL resolution","fork":false,"url":"https://api.github.com/repos/warehouseai/cdnup","forks_url":"https://api.github.com/repos/warehouseai/cdnup/forks","keys_url":"https://api.github.com/repos/warehouseai/cdnup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/warehouseai/cdnup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/warehouseai/cdnup/teams","hooks_url":"https://api.github.com/repos/warehouseai/cdnup/hooks","issue_events_url":"https://api.github.com/repos/warehouseai/cdnup/issues/events{/number}","events_url":"https://api.github.com/repos/warehouseai/cdnup/events","assignees_url":"https://api.github.com/repos/warehouseai/cdnup/assignees{/user}","branches_url":"https://api.github.com/repos/warehouseai/cdnup/branches{/branch}","tags_url":"https://api.github.com/repos/warehouseai/cdnup/tags","blobs_url":"https://api.github.com/repos/warehouseai/cdnup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/warehouseai/cdnup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/warehouseai/cdnup/git/refs{/sha}","trees_url":"https://api.github.com/repos/warehouseai/cdnup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/warehouseai/cdnup/statuses/{sha}","languages_url":"https://api.github.com/repos/warehouseai/cdnup/languages","stargazers_url":"https://api.github.com/repos/warehouseai/cdnup/stargazers","contributors_url":"https://api.github.com/repos/warehouseai/cdnup/contributors","subscribers_url":"https://api.github.com/repos/warehouseai/cdnup/subscribers","subscription_url":"https://api.github.com/repos/warehouseai/cdnup/subscription","commits_url":"https://api.github.com/repos/warehouseai/cdnup/commits{/sha}","git_commits_url":"https://api.github.com/repos/warehouseai/cdnup/git/commits{/sha}","comments_url":"https://api.github.com/repos/warehouseai/cdnup/comments{/number}","issue_comment_url":"https://api.github.com/repos/warehouseai/cdnup/issues/comments{/number}","contents_url":"https://api.github.com/repos/warehouseai/cdnup/contents/{+path}","compare_url":"https://api.github.com/repos/warehouseai/cdnup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/warehouseai/cdnup/merges","archive_url":"https://api.github.com/repos/warehouseai/cdnup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/warehouseai/cdnup/downloads","issues_url":"https://api.github.com/repos/warehouseai/cdnup/issues{/number}","pulls_url":"https://api.github.com/repos/warehouseai/cdnup/pulls{/number}","milestones_url":"https://api.github.com/repos/warehouseai/cdnup/milestones{/number}","notifications_url":"https://api.github.com/repos/warehouseai/cdnup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/warehouseai/cdnup/labels{/name}","releases_url":"https://api.github.com/repos/warehouseai/cdnup/releases{/id}","deployments_url":"https://api.github.com/repos/warehouseai/cdnup/deployments","created_at":"2016-11-30T15:08:17Z","updated_at":"2016-11-30T16:56:56Z","pushed_at":"2016-12-28T20:44:38Z","git_url":"git://github.com/warehouseai/cdnup.git","ssh_url":"git@github.com:warehouseai/cdnup.git","clone_url":"https://github.com/warehouseai/cdnup.git","svn_url":"https://github.com/warehouseai/cdnup","homepage":null,"size":8,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/warehouseai/cdnup/pulls/1"},"html":{"href":"https://github.com/warehouseai/cdnup/pull/1"},"issue":{"href":"https://api.github.com/repos/warehouseai/cdnup/issues/1"},"comments":{"href":"https://api.github.com/repos/warehouseai/cdnup/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/warehouseai/cdnup/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/warehouseai/cdnup/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/warehouseai/cdnup/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/warehouseai/cdnup/statuses/0e9b0da0e496dd9186e433ebaf1476c634900205"}}}}
{"actor":{"display_login":"jcrugzz"}}