{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments/91324656","pull_request_review_id":11832707,"id":91324656,"diff_hunk":"@@ -36,12 +36,25 @@ lint: lint.sub\n push: push.sub\n test: test.sub\n \n+docker-all: .image\n+\tdocker run -ti \\","path":"Makefile","position":5,"original_position":5,"commit_id":"0922f3d300bf6f51c878a3540c9d49db7d08d8ff","original_commit_id":"0922f3d300bf6f51c878a3540c9d49db7d08d8ff","user":{"login":"martinmaly","id":5521294,"avatar_url":"https://avatars.githubusercontent.com/u/5521294?v=3","gravatar_id":"","url":"https://api.github.com/users/martinmaly","html_url":"https://github.com/martinmaly","followers_url":"https://api.github.com/users/martinmaly/followers","following_url":"https://api.github.com/users/martinmaly/following{/other_user}","gists_url":"https://api.github.com/users/martinmaly/gists{/gist_id}","starred_url":"https://api.github.com/users/martinmaly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinmaly/subscriptions","organizations_url":"https://api.github.com/users/martinmaly/orgs","repos_url":"https://api.github.com/users/martinmaly/repos","events_url":"https://api.github.com/users/martinmaly/events{/privacy}","received_events_url":"https://api.github.com/users/martinmaly/received_events","type":"User","site_admin":false},"body":"do we need `--rm` flag to `docker run` ?","created_at":"2016-12-07T16:04:00Z","updated_at":"2016-12-07T16:04:20Z","html_url":"https://github.com/kubernetes-incubator/service-catalog/pull/122#discussion_r91324656","pull_request_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/122","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments/91324656"},"html":{"href":"https://github.com/kubernetes-incubator/service-catalog/pull/122#discussion_r91324656"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/122"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/122","id":96932827,"html_url":"https://github.com/kubernetes-incubator/service-catalog/pull/122","diff_url":"https://github.com/kubernetes-incubator/service-catalog/pull/122.diff","patch_url":"https://github.com/kubernetes-incubator/service-catalog/pull/122.patch","issue_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/122","number":122,"state":"open","locked":false,"title":"tweak for dockerizing Makefile","user":{"login":"duglin","id":1944671,"avatar_url":"https://avatars.githubusercontent.com/u/1944671?v=3","gravatar_id":"","url":"https://api.github.com/users/duglin","html_url":"https://github.com/duglin","followers_url":"https://api.github.com/users/duglin/followers","following_url":"https://api.github.com/users/duglin/following{/other_user}","gists_url":"https://api.github.com/users/duglin/gists{/gist_id}","starred_url":"https://api.github.com/users/duglin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duglin/subscriptions","organizations_url":"https://api.github.com/users/duglin/orgs","repos_url":"https://api.github.com/users/duglin/repos","events_url":"https://api.github.com/users/duglin/events{/privacy}","received_events_url":"https://api.github.com/users/duglin/received_events","type":"User","site_admin":false},"body":"Add a target to build *everything* (even glide stuff) via Docker\r\n\r\nAlso adds \"--strip-vendor\" to glide stuff.\r\n\r\nSigned-off-by: Doug Davis <dug@us.ibm.com>","created_at":"2016-12-07T14:25:45Z","updated_at":"2016-12-07T16:13:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b26790165827d7206313b857c10dd56c5c282078","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/122/commits","review_comments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/122/comments","review_comment_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/122/comments","statuses_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/statuses/0922f3d300bf6f51c878a3540c9d49db7d08d8ff","head":{"label":"duglin:Makefile","ref":"Makefile","sha":"0922f3d300bf6f51c878a3540c9d49db7d08d8ff","user":{"login":"duglin","id":1944671,"avatar_url":"https://avatars.githubusercontent.com/u/1944671?v=3","gravatar_id":"","url":"https://api.github.com/users/duglin","html_url":"https://github.com/duglin","followers_url":"https://api.github.com/users/duglin/followers","following_url":"https://api.github.com/users/duglin/following{/other_user}","gists_url":"https://api.github.com/users/duglin/gists{/gist_id}","starred_url":"https://api.github.com/users/duglin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duglin/subscriptions","organizations_url":"https://api.github.com/users/duglin/orgs","repos_url":"https://api.github.com/users/duglin/repos","events_url":"https://api.github.com/users/duglin/events{/privacy}","received_events_url":"https://api.github.com/users/duglin/received_events","type":"User","site_admin":false},"repo":{"id":68609853,"name":"service-catalog","full_name":"duglin/service-catalog","owner":{"login":"duglin","id":1944671,"avatar_url":"https://avatars.githubusercontent.com/u/1944671?v=3","gravatar_id":"","url":"https://api.github.com/users/duglin","html_url":"https://github.com/duglin","followers_url":"https://api.github.com/users/duglin/followers","following_url":"https://api.github.com/users/duglin/following{/other_user}","gists_url":"https://api.github.com/users/duglin/gists{/gist_id}","starred_url":"https://api.github.com/users/duglin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duglin/subscriptions","organizations_url":"https://api.github.com/users/duglin/orgs","repos_url":"https://api.github.com/users/duglin/repos","events_url":"https://api.github.com/users/duglin/events{/privacy}","received_events_url":"https://api.github.com/users/duglin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/duglin/service-catalog","description":"Share and consume services in Kubernetes using service brokers","fork":true,"url":"https://api.github.com/repos/duglin/service-catalog","forks_url":"https://api.github.com/repos/duglin/service-catalog/forks","keys_url":"https://api.github.com/repos/duglin/service-catalog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/duglin/service-catalog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/duglin/service-catalog/teams","hooks_url":"https://api.github.com/repos/duglin/service-catalog/hooks","issue_events_url":"https://api.github.com/repos/duglin/service-catalog/issues/events{/number}","events_url":"https://api.github.com/repos/duglin/service-catalog/events","assignees_url":"https://api.github.com/repos/duglin/service-catalog/assignees{/user}","branches_url":"https://api.github.com/repos/duglin/service-catalog/branches{/branch}","tags_url":"https://api.github.com/repos/duglin/service-catalog/tags","blobs_url":"https://api.github.com/repos/duglin/service-catalog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/duglin/service-catalog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/duglin/service-catalog/git/refs{/sha}","trees_url":"https://api.github.com/repos/duglin/service-catalog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/duglin/service-catalog/statuses/{sha}","languages_url":"https://api.github.com/repos/duglin/service-catalog/languages","stargazers_url":"https://api.github.com/repos/duglin/service-catalog/stargazers","contributors_url":"https://api.github.com/repos/duglin/service-catalog/contributors","subscribers_url":"https://api.github.com/repos/duglin/service-catalog/subscribers","subscription_url":"https://api.github.com/repos/duglin/service-catalog/subscription","commits_url":"https://api.github.com/repos/duglin/service-catalog/commits{/sha}","git_commits_url":"https://api.github.com/repos/duglin/service-catalog/git/commits{/sha}","comments_url":"https://api.github.com/repos/duglin/service-catalog/comments{/number}","issue_comment_url":"https://api.github.com/repos/duglin/service-catalog/issues/comments{/number}","contents_url":"https://api.github.com/repos/duglin/service-catalog/contents/{+path}","compare_url":"https://api.github.com/repos/duglin/service-catalog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/duglin/service-catalog/merges","archive_url":"https://api.github.com/repos/duglin/service-catalog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/duglin/service-catalog/downloads","issues_url":"https://api.github.com/repos/duglin/service-catalog/issues{/number}","pulls_url":"https://api.github.com/repos/duglin/service-catalog/pulls{/number}","milestones_url":"https://api.github.com/repos/duglin/service-catalog/milestones{/number}","notifications_url":"https://api.github.com/repos/duglin/service-catalog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/duglin/service-catalog/labels{/name}","releases_url":"https://api.github.com/repos/duglin/service-catalog/releases{/id}","deployments_url":"https://api.github.com/repos/duglin/service-catalog/deployments","created_at":"2016-09-19T13:42:37Z","updated_at":"2016-11-29T22:51:04Z","pushed_at":"2016-12-07T15:17:39Z","git_url":"git://github.com/duglin/service-catalog.git","ssh_url":"git@github.com:duglin/service-catalog.git","clone_url":"https://github.com/duglin/service-catalog.git","svn_url":"https://github.com/duglin/service-catalog","homepage":"","size":39432,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-incubator:master","ref":"master","sha":"517637f528d082eba92be5e6e19072ee473c4f24","user":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars.githubusercontent.com/u/20862812?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":68024288,"name":"service-catalog","full_name":"kubernetes-incubator/service-catalog","owner":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars.githubusercontent.com/u/20862812?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes-incubator/service-catalog","description":"Share and consume services in Kubernetes using service brokers","fork":false,"url":"https://api.github.com/repos/kubernetes-incubator/service-catalog","forks_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/forks","keys_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/teams","hooks_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/events","assignees_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/tags","blobs_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/languages","stargazers_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/subscription","commits_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/merges","archive_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/downloads","issues_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/deployments","created_at":"2016-09-12T15:58:39Z","updated_at":"2016-12-06T06:19:30Z","pushed_at":"2016-12-07T14:54:44Z","git_url":"git://github.com/kubernetes-incubator/service-catalog.git","ssh_url":"git@github.com:kubernetes-incubator/service-catalog.git","clone_url":"https://github.com/kubernetes-incubator/service-catalog.git","svn_url":"https://github.com/kubernetes-incubator/service-catalog","homepage":"","size":39608,"stargazers_count":25,"watchers_count":25,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":36,"forks":21,"open_issues":36,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/122"},"html":{"href":"https://github.com/kubernetes-incubator/service-catalog/pull/122"},"issue":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/122"},"comments":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/122/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/122/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/122/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/statuses/0922f3d300bf6f51c878a3540c9d49db7d08d8ff"}}}}
{"actor":{"display_login":"martinmaly"}}