{"action":"created","issue":{"url":"https://api.github.com/repos/dpla/KriKri/issues/216","repository_url":"https://api.github.com/repos/dpla/KriKri","labels_url":"https://api.github.com/repos/dpla/KriKri/issues/216/labels{/name}","comments_url":"https://api.github.com/repos/dpla/KriKri/issues/216/comments","events_url":"https://api.github.com/repos/dpla/KriKri/issues/216/events","html_url":"https://github.com/dpla/KriKri/pull/216","id":132820236,"number":216,"title":"Allow use of RSpec 3.4.x","user":{"login":"no-reply","id":1361776,"avatar_url":"https://avatars.githubusercontent.com/u/1361776?v=3","gravatar_id":"","url":"https://api.github.com/users/no-reply","html_url":"https://github.com/no-reply","followers_url":"https://api.github.com/users/no-reply/followers","following_url":"https://api.github.com/users/no-reply/following{/other_user}","gists_url":"https://api.github.com/users/no-reply/gists{/gist_id}","starred_url":"https://api.github.com/users/no-reply/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/no-reply/subscriptions","organizations_url":"https://api.github.com/users/no-reply/orgs","repos_url":"https://api.github.com/users/no-reply/repos","events_url":"https://api.github.com/users/no-reply/events{/privacy}","received_events_url":"https://api.github.com/users/no-reply/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"markbreedlove","id":5550828,"avatar_url":"https://avatars.githubusercontent.com/u/5550828?v=3","gravatar_id":"","url":"https://api.github.com/users/markbreedlove","html_url":"https://github.com/markbreedlove","followers_url":"https://api.github.com/users/markbreedlove/followers","following_url":"https://api.github.com/users/markbreedlove/following{/other_user}","gists_url":"https://api.github.com/users/markbreedlove/gists{/gist_id}","starred_url":"https://api.github.com/users/markbreedlove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markbreedlove/subscriptions","organizations_url":"https://api.github.com/users/markbreedlove/orgs","repos_url":"https://api.github.com/users/markbreedlove/repos","events_url":"https://api.github.com/users/markbreedlove/events{/privacy}","received_events_url":"https://api.github.com/users/markbreedlove/received_events","type":"User","site_admin":false},"milestone":null,"comments":6,"created_at":"2016-02-10T21:19:35Z","updated_at":"2016-02-19T16:50:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dpla/KriKri/pulls/216","html_url":"https://github.com/dpla/KriKri/pull/216","diff_url":"https://github.com/dpla/KriKri/pull/216.diff","patch_url":"https://github.com/dpla/KriKri/pull/216.patch"},"body":"RSpec is nearing a 3.5 release, which will be necessary for Rails 5 compatibility. This gets us closer to that.\r\n\r\nIt also fixes up warnings raised by newer versions of RSpec.\r\n\r\nThe dependency is loosened so engine users aren't forced to upgrade."},"comment":{"url":"https://api.github.com/repos/dpla/KriKri/issues/comments/186299672","html_url":"https://github.com/dpla/KriKri/pull/216#issuecomment-186299672","issue_url":"https://api.github.com/repos/dpla/KriKri/issues/216","id":186299672,"user":{"login":"no-reply","id":1361776,"avatar_url":"https://avatars.githubusercontent.com/u/1361776?v=3","gravatar_id":"","url":"https://api.github.com/users/no-reply","html_url":"https://github.com/no-reply","followers_url":"https://api.github.com/users/no-reply/followers","following_url":"https://api.github.com/users/no-reply/following{/other_user}","gists_url":"https://api.github.com/users/no-reply/gists{/gist_id}","starred_url":"https://api.github.com/users/no-reply/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/no-reply/subscriptions","organizations_url":"https://api.github.com/users/no-reply/orgs","repos_url":"https://api.github.com/users/no-reply/repos","events_url":"https://api.github.com/users/no-reply/events{/privacy}","received_events_url":"https://api.github.com/users/no-reply/received_events","type":"User","site_admin":false},"created_at":"2016-02-19T16:50:33Z","updated_at":"2016-02-19T16:50:33Z","body":"Following up on this: it seems like `contain_exactly` changed subtly in [RSpec 3.3](http://rspec.info/blog/2015/06/rspec-3-3-has-been-released/). This ran afoul of the pattern matching we're using in the shared example:\r\n\r\n`actual.query(pattern).map(&:object)` yields an `RDF::Literal` instance, rather than the exact object. The `include` matcher still checks this in a way that takes advantage of RDF.rb's value-space literal equality.\r\n\r\nAs noted above, `include` is more precise for the test set, in either case. If we wanted to do `contain_exactly` in another context, we could cast the results."}}