{"action":"created","comment":{"url":"https://api.github.com/repos/SpadesNeil/VOREstation/pulls/comments/59244923","id":59244923,"diff_hunk":"@@ -30,12 +62,16 @@ var/list/whitelist = list()\n \telse\n \t\talien_whitelist = text2list(text, \"\\n\")\n \n-//todo: admin aliens\n /proc/is_alien_whitelisted(mob/M, var/species)\n \tif(!config.usealienwhitelist)\n \t\treturn 1\n-\tif(species != \"vox\" && species != \"Vox\" && species != \"diona\" && species != \"Diona\" && species != \"skeleton\" && species != \"Skeleton\")","path":"code/game/jobs/whitelist.dm","position":53,"original_position":53,"commit_id":"b247ce47baa3bbbcce76444381aefcd0453ea571","original_commit_id":"b247ce47baa3bbbcce76444381aefcd0453ea571","user":{"login":"ForFoxSake","id":16629824,"avatar_url":"https://avatars.githubusercontent.com/u/16629824?v=3","gravatar_id":"","url":"https://api.github.com/users/ForFoxSake","html_url":"https://github.com/ForFoxSake","followers_url":"https://api.github.com/users/ForFoxSake/followers","following_url":"https://api.github.com/users/ForFoxSake/following{/other_user}","gists_url":"https://api.github.com/users/ForFoxSake/gists{/gist_id}","starred_url":"https://api.github.com/users/ForFoxSake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ForFoxSake/subscriptions","organizations_url":"https://api.github.com/users/ForFoxSake/orgs","repos_url":"https://api.github.com/users/ForFoxSake/repos","events_url":"https://api.github.com/users/ForFoxSake/events{/privacy}","received_events_url":"https://api.github.com/users/ForFoxSake/received_events","type":"User","site_admin":false},"body":"Already testing a fix for this now.","created_at":"2016-04-11T17:25:31Z","updated_at":"2016-04-11T17:25:31Z","html_url":"https://github.com/SpadesNeil/VOREstation/pull/557#discussion_r59244923","pull_request_url":"https://api.github.com/repos/SpadesNeil/VOREstation/pulls/557","_links":{"self":{"href":"https://api.github.com/repos/SpadesNeil/VOREstation/pulls/comments/59244923"},"html":{"href":"https://github.com/SpadesNeil/VOREstation/pull/557#discussion_r59244923"},"pull_request":{"href":"https://api.github.com/repos/SpadesNeil/VOREstation/pulls/557"}}},"pull_request":{"url":"https://api.github.com/repos/SpadesNeil/VOREstation/pulls/557","id":65908684,"html_url":"https://github.com/SpadesNeil/VOREstation/pull/557","diff_url":"https://github.com/SpadesNeil/VOREstation/pull/557.diff","patch_url":"https://github.com/SpadesNeil/VOREstation/pull/557.patch","issue_url":"https://api.github.com/repos/SpadesNeil/VOREstation/issues/557","number":557,"state":"closed","locked":false,"title":"Job Whitelist","user":{"login":"Arokha","id":15028025,"avatar_url":"https://avatars.githubusercontent.com/u/15028025?v=3","gravatar_id":"","url":"https://api.github.com/users/Arokha","html_url":"https://github.com/Arokha","followers_url":"https://api.github.com/users/Arokha/followers","following_url":"https://api.github.com/users/Arokha/following{/other_user}","gists_url":"https://api.github.com/users/Arokha/gists{/gist_id}","starred_url":"https://api.github.com/users/Arokha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Arokha/subscriptions","organizations_url":"https://api.github.com/users/Arokha/orgs","repos_url":"https://api.github.com/users/Arokha/repos","events_url":"https://api.github.com/users/Arokha/events{/privacy}","received_events_url":"https://api.github.com/users/Arokha/received_events","type":"User","site_admin":false},"body":"This allows any job to be set to require whitelisting by adding the var\r\n\"job_whitelisted = 1\" to the settings for the job. It also adds a \"Unique\"\r\ndepartment, and an example job, \"CentCom Observer\", in a new special.dm\r\nfile for the special whitelist/admin jobs. There's no config file for\r\nWHICH jobs are whitelisted yet.\r\n\r\nAdmins always ignore the whitelist.\r\n\r\nThis makes the job priorities screen ugly, sorry. It will look nicer when\r\nthat third column has more jobs in it, or someone who knows more\r\nHTML-as-tortured-by-Byond can take a crack at it.\r\n\r\n**_THINGS YOU SHOULD KNOW:_**\r\nYou must create jobwhitelist.txt in the config folder. After updating,\r\nthere will be a copy in config/example.\r\n\r\nThere is a new config file option, USEJOBWHITELIST, that you need to add\r\nto enable job whitelists. Until then, this does not do anything. Do not\r\nuse USEWHITELIST, as that is the old version that only applies to head\r\nroles.\r\n\r\nYou can whitelist any job by going to the appropriate dm (medical.dm,\r\ncaptain.dm, etc) and adding \"job_whitelisted = 1\".\r\n\r\nI am 'fairly' sure this is robust. Someone extremely sneaky might figure\r\nout a way around it, but I can't think of a way. The randomizer skips you\r\nproperly I believe, and you can't pick whitelist jobs when latejoining.\r\n\r\nComments apparently are not ignored in config files so if you do something\r\nlike #arokha - All, it will still give all jobs whitelisted.\r\n\r\nResolves #493","created_at":"2016-04-10T12:09:25Z","updated_at":"2016-04-11T17:25:31Z","closed_at":"2016-04-10T15:19:42Z","merged_at":"2016-04-10T15:19:42Z","merge_commit_sha":"deaf1343423d02a376d55fb033892590677bc155","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SpadesNeil/VOREstation/pulls/557/commits","review_comments_url":"https://api.github.com/repos/SpadesNeil/VOREstation/pulls/557/comments","review_comment_url":"https://api.github.com/repos/SpadesNeil/VOREstation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SpadesNeil/VOREstation/issues/557/comments","statuses_url":"https://api.github.com/repos/SpadesNeil/VOREstation/statuses/b247ce47baa3bbbcce76444381aefcd0453ea571","head":{"label":"Arokha:jobwhitelist","ref":"jobwhitelist","sha":"b247ce47baa3bbbcce76444381aefcd0453ea571","user":{"login":"Arokha","id":15028025,"avatar_url":"https://avatars.githubusercontent.com/u/15028025?v=3","gravatar_id":"","url":"https://api.github.com/users/Arokha","html_url":"https://github.com/Arokha","followers_url":"https://api.github.com/users/Arokha/followers","following_url":"https://api.github.com/users/Arokha/following{/other_user}","gists_url":"https://api.github.com/users/Arokha/gists{/gist_id}","starred_url":"https://api.github.com/users/Arokha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Arokha/subscriptions","organizations_url":"https://api.github.com/users/Arokha/orgs","repos_url":"https://api.github.com/users/Arokha/repos","events_url":"https://api.github.com/users/Arokha/events{/privacy}","received_events_url":"https://api.github.com/users/Arokha/received_events","type":"User","site_admin":false},"repo":{"id":44539675,"name":"VOREstation","full_name":"Arokha/VOREstation","owner":{"login":"Arokha","id":15028025,"avatar_url":"https://avatars.githubusercontent.com/u/15028025?v=3","gravatar_id":"","url":"https://api.github.com/users/Arokha","html_url":"https://github.com/Arokha","followers_url":"https://api.github.com/users/Arokha/followers","following_url":"https://api.github.com/users/Arokha/following{/other_user}","gists_url":"https://api.github.com/users/Arokha/gists{/gist_id}","starred_url":"https://api.github.com/users/Arokha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Arokha/subscriptions","organizations_url":"https://api.github.com/users/Arokha/orgs","repos_url":"https://api.github.com/users/Arokha/repos","events_url":"https://api.github.com/users/Arokha/events{/privacy}","received_events_url":"https://api.github.com/users/Arokha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Arokha/VOREstation","description":"VORE Station's Github Repository","fork":true,"url":"https://api.github.com/repos/Arokha/VOREstation","forks_url":"https://api.github.com/repos/Arokha/VOREstation/forks","keys_url":"https://api.github.com/repos/Arokha/VOREstation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Arokha/VOREstation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Arokha/VOREstation/teams","hooks_url":"https://api.github.com/repos/Arokha/VOREstation/hooks","issue_events_url":"https://api.github.com/repos/Arokha/VOREstation/issues/events{/number}","events_url":"https://api.github.com/repos/Arokha/VOREstation/events","assignees_url":"https://api.github.com/repos/Arokha/VOREstation/assignees{/user}","branches_url":"https://api.github.com/repos/Arokha/VOREstation/branches{/branch}","tags_url":"https://api.github.com/repos/Arokha/VOREstation/tags","blobs_url":"https://api.github.com/repos/Arokha/VOREstation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Arokha/VOREstation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Arokha/VOREstation/git/refs{/sha}","trees_url":"https://api.github.com/repos/Arokha/VOREstation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Arokha/VOREstation/statuses/{sha}","languages_url":"https://api.github.com/repos/Arokha/VOREstation/languages","stargazers_url":"https://api.github.com/repos/Arokha/VOREstation/stargazers","contributors_url":"https://api.github.com/repos/Arokha/VOREstation/contributors","subscribers_url":"https://api.github.com/repos/Arokha/VOREstation/subscribers","subscription_url":"https://api.github.com/repos/Arokha/VOREstation/subscription","commits_url":"https://api.github.com/repos/Arokha/VOREstation/commits{/sha}","git_commits_url":"https://api.github.com/repos/Arokha/VOREstation/git/commits{/sha}","comments_url":"https://api.github.com/repos/Arokha/VOREstation/comments{/number}","issue_comment_url":"https://api.github.com/repos/Arokha/VOREstation/issues/comments{/number}","contents_url":"https://api.github.com/repos/Arokha/VOREstation/contents/{+path}","compare_url":"https://api.github.com/repos/Arokha/VOREstation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Arokha/VOREstation/merges","archive_url":"https://api.github.com/repos/Arokha/VOREstation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Arokha/VOREstation/downloads","issues_url":"https://api.github.com/repos/Arokha/VOREstation/issues{/number}","pulls_url":"https://api.github.com/repos/Arokha/VOREstation/pulls{/number}","milestones_url":"https://api.github.com/repos/Arokha/VOREstation/milestones{/number}","notifications_url":"https://api.github.com/repos/Arokha/VOREstation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Arokha/VOREstation/labels{/name}","releases_url":"https://api.github.com/repos/Arokha/VOREstation/releases{/id}","deployments_url":"https://api.github.com/repos/Arokha/VOREstation/deployments","created_at":"2015-10-19T14:15:42Z","updated_at":"2016-04-05T05:13:59Z","pushed_at":"2016-04-11T17:19:05Z","git_url":"git://github.com/Arokha/VOREstation.git","ssh_url":"git@github.com:Arokha/VOREstation.git","clone_url":"https://github.com/Arokha/VOREstation.git","svn_url":"https://github.com/Arokha/VOREstation","homepage":"http://vore-station.net","size":138163,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SpadesNeil:master","ref":"master","sha":"abfabb5595ee08596a2474c4681a56debeb7cddb","user":{"login":"SpadesNeil","id":6484985,"avatar_url":"https://avatars.githubusercontent.com/u/6484985?v=3","gravatar_id":"","url":"https://api.github.com/users/SpadesNeil","html_url":"https://github.com/SpadesNeil","followers_url":"https://api.github.com/users/SpadesNeil/followers","following_url":"https://api.github.com/users/SpadesNeil/following{/other_user}","gists_url":"https://api.github.com/users/SpadesNeil/gists{/gist_id}","starred_url":"https://api.github.com/users/SpadesNeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpadesNeil/subscriptions","organizations_url":"https://api.github.com/users/SpadesNeil/orgs","repos_url":"https://api.github.com/users/SpadesNeil/repos","events_url":"https://api.github.com/users/SpadesNeil/events{/privacy}","received_events_url":"https://api.github.com/users/SpadesNeil/received_events","type":"User","site_admin":false},"repo":{"id":36901248,"name":"VOREstation","full_name":"SpadesNeil/VOREstation","owner":{"login":"SpadesNeil","id":6484985,"avatar_url":"https://avatars.githubusercontent.com/u/6484985?v=3","gravatar_id":"","url":"https://api.github.com/users/SpadesNeil","html_url":"https://github.com/SpadesNeil","followers_url":"https://api.github.com/users/SpadesNeil/followers","following_url":"https://api.github.com/users/SpadesNeil/following{/other_user}","gists_url":"https://api.github.com/users/SpadesNeil/gists{/gist_id}","starred_url":"https://api.github.com/users/SpadesNeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpadesNeil/subscriptions","organizations_url":"https://api.github.com/users/SpadesNeil/orgs","repos_url":"https://api.github.com/users/SpadesNeil/repos","events_url":"https://api.github.com/users/SpadesNeil/events{/privacy}","received_events_url":"https://api.github.com/users/SpadesNeil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SpadesNeil/VOREstation","description":"VORE Station's Github Repository","fork":false,"url":"https://api.github.com/repos/SpadesNeil/VOREstation","forks_url":"https://api.github.com/repos/SpadesNeil/VOREstation/forks","keys_url":"https://api.github.com/repos/SpadesNeil/VOREstation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpadesNeil/VOREstation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpadesNeil/VOREstation/teams","hooks_url":"https://api.github.com/repos/SpadesNeil/VOREstation/hooks","issue_events_url":"https://api.github.com/repos/SpadesNeil/VOREstation/issues/events{/number}","events_url":"https://api.github.com/repos/SpadesNeil/VOREstation/events","assignees_url":"https://api.github.com/repos/SpadesNeil/VOREstation/assignees{/user}","branches_url":"https://api.github.com/repos/SpadesNeil/VOREstation/branches{/branch}","tags_url":"https://api.github.com/repos/SpadesNeil/VOREstation/tags","blobs_url":"https://api.github.com/repos/SpadesNeil/VOREstation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpadesNeil/VOREstation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpadesNeil/VOREstation/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpadesNeil/VOREstation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpadesNeil/VOREstation/statuses/{sha}","languages_url":"https://api.github.com/repos/SpadesNeil/VOREstation/languages","stargazers_url":"https://api.github.com/repos/SpadesNeil/VOREstation/stargazers","contributors_url":"https://api.github.com/repos/SpadesNeil/VOREstation/contributors","subscribers_url":"https://api.github.com/repos/SpadesNeil/VOREstation/subscribers","subscription_url":"https://api.github.com/repos/SpadesNeil/VOREstation/subscription","commits_url":"https://api.github.com/repos/SpadesNeil/VOREstation/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpadesNeil/VOREstation/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpadesNeil/VOREstation/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpadesNeil/VOREstation/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpadesNeil/VOREstation/contents/{+path}","compare_url":"https://api.github.com/repos/SpadesNeil/VOREstation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpadesNeil/VOREstation/merges","archive_url":"https://api.github.com/repos/SpadesNeil/VOREstation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpadesNeil/VOREstation/downloads","issues_url":"https://api.github.com/repos/SpadesNeil/VOREstation/issues{/number}","pulls_url":"https://api.github.com/repos/SpadesNeil/VOREstation/pulls{/number}","milestones_url":"https://api.github.com/repos/SpadesNeil/VOREstation/milestones{/number}","notifications_url":"https://api.github.com/repos/SpadesNeil/VOREstation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpadesNeil/VOREstation/labels{/name}","releases_url":"https://api.github.com/repos/SpadesNeil/VOREstation/releases{/id}","deployments_url":"https://api.github.com/repos/SpadesNeil/VOREstation/deployments","created_at":"2015-06-04T23:29:06Z","updated_at":"2016-03-30T02:06:00Z","pushed_at":"2016-04-11T00:17:55Z","git_url":"git://github.com/SpadesNeil/VOREstation.git","ssh_url":"git@github.com:SpadesNeil/VOREstation.git","clone_url":"https://github.com/SpadesNeil/VOREstation.git","svn_url":"https://github.com/SpadesNeil/VOREstation","homepage":"http://vore-station.net","size":139361,"stargazers_count":9,"watchers_count":9,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":72,"forks":22,"open_issues":72,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SpadesNeil/VOREstation/pulls/557"},"html":{"href":"https://github.com/SpadesNeil/VOREstation/pull/557"},"issue":{"href":"https://api.github.com/repos/SpadesNeil/VOREstation/issues/557"},"comments":{"href":"https://api.github.com/repos/SpadesNeil/VOREstation/issues/557/comments"},"review_comments":{"href":"https://api.github.com/repos/SpadesNeil/VOREstation/pulls/557/comments"},"review_comment":{"href":"https://api.github.com/repos/SpadesNeil/VOREstation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SpadesNeil/VOREstation/pulls/557/commits"},"statuses":{"href":"https://api.github.com/repos/SpadesNeil/VOREstation/statuses/b247ce47baa3bbbcce76444381aefcd0453ea571"}}}}