{"action":"created","comment":{"url":"https://api.github.com/repos/ekmett/lens/pulls/comments/76995447","id":76995447,"diff_hunk":"@@ -454,17 +458,25 @@ instance At (Maybe a) where\n   {-# INLINE at #-}\n \n instance At (IntMap a) where\n+#if MIN_VERSION_containers(0,5,8)","path":"src/Control/Lens/At.hs","position":15,"original_position":15,"commit_id":"791b3b5c676f3ccb44497a4855d2cdf66169fee1","original_commit_id":"791b3b5c676f3ccb44497a4855d2cdf66169fee1","user":{"login":"RyanGlScott","id":2364661,"avatar_url":"https://avatars.githubusercontent.com/u/2364661?v=3","gravatar_id":"","url":"https://api.github.com/users/RyanGlScott","html_url":"https://github.com/RyanGlScott","followers_url":"https://api.github.com/users/RyanGlScott/followers","following_url":"https://api.github.com/users/RyanGlScott/following{/other_user}","gists_url":"https://api.github.com/users/RyanGlScott/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanGlScott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanGlScott/subscriptions","organizations_url":"https://api.github.com/users/RyanGlScott/orgs","repos_url":"https://api.github.com/users/RyanGlScott/repos","events_url":"https://api.github.com/users/RyanGlScott/events{/privacy}","received_events_url":"https://api.github.com/users/RyanGlScott/received_events","type":"User","site_admin":false},"body":"> Do you have strong feelings about it?\r\n\r\nNo, certainly not! I only added it since you mentioned `IntMap`, and I was naïvely trying to catch all of the cases where `containers-0.5.8.1` added something that could be used in `lens`. I'll revert this particular change for now.","created_at":"2016-08-31T14:15:52Z","updated_at":"2016-08-31T14:15:52Z","html_url":"https://github.com/ekmett/lens/pull/673#discussion_r76995447","pull_request_url":"https://api.github.com/repos/ekmett/lens/pulls/673","_links":{"self":{"href":"https://api.github.com/repos/ekmett/lens/pulls/comments/76995447"},"html":{"href":"https://github.com/ekmett/lens/pull/673#discussion_r76995447"},"pull_request":{"href":"https://api.github.com/repos/ekmett/lens/pulls/673"}}},"pull_request":{"url":"https://api.github.com/repos/ekmett/lens/pulls/673","id":83446021,"html_url":"https://github.com/ekmett/lens/pull/673","diff_url":"https://github.com/ekmett/lens/pull/673.diff","patch_url":"https://github.com/ekmett/lens/pull/673.patch","issue_url":"https://api.github.com/repos/ekmett/lens/issues/673","number":673,"state":"open","locked":false,"title":"Use more efficient functions from containers-0.5.8.1 whenever possible","user":{"login":"RyanGlScott","id":2364661,"avatar_url":"https://avatars.githubusercontent.com/u/2364661?v=3","gravatar_id":"","url":"https://api.github.com/users/RyanGlScott","html_url":"https://github.com/RyanGlScott","followers_url":"https://api.github.com/users/RyanGlScott/followers","following_url":"https://api.github.com/users/RyanGlScott/following{/other_user}","gists_url":"https://api.github.com/users/RyanGlScott/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanGlScott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanGlScott/subscriptions","organizations_url":"https://api.github.com/users/RyanGlScott/orgs","repos_url":"https://api.github.com/users/RyanGlScott/repos","events_url":"https://api.github.com/users/RyanGlScott/events{/privacy}","received_events_url":"https://api.github.com/users/RyanGlScott/received_events","type":"User","site_admin":false},"body":"With `containers-0.5.8.1` or later, we can use the more efficient `traverseWithIndex` function for the `TraversableWithIndex` instance for `Seq`.\r\n\r\ncc'ing @treeowl in case there are other optimizations of this ilk I overlooked.\r\n\r\nFixes #629.","created_at":"2016-08-31T12:49:28Z","updated_at":"2016-08-31T14:15:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be6b1857446fcc6a38ed6e5e4069b4a9a9be6322","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ekmett/lens/pulls/673/commits","review_comments_url":"https://api.github.com/repos/ekmett/lens/pulls/673/comments","review_comment_url":"https://api.github.com/repos/ekmett/lens/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ekmett/lens/issues/673/comments","statuses_url":"https://api.github.com/repos/ekmett/lens/statuses/791b3b5c676f3ccb44497a4855d2cdf66169fee1","head":{"label":"ekmett:more-efficient-traverse-with-index","ref":"more-efficient-traverse-with-index","sha":"791b3b5c676f3ccb44497a4855d2cdf66169fee1","user":{"login":"ekmett","id":304657,"avatar_url":"https://avatars.githubusercontent.com/u/304657?v=3","gravatar_id":"","url":"https://api.github.com/users/ekmett","html_url":"https://github.com/ekmett","followers_url":"https://api.github.com/users/ekmett/followers","following_url":"https://api.github.com/users/ekmett/following{/other_user}","gists_url":"https://api.github.com/users/ekmett/gists{/gist_id}","starred_url":"https://api.github.com/users/ekmett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekmett/subscriptions","organizations_url":"https://api.github.com/users/ekmett/orgs","repos_url":"https://api.github.com/users/ekmett/repos","events_url":"https://api.github.com/users/ekmett/events{/privacy}","received_events_url":"https://api.github.com/users/ekmett/received_events","type":"User","site_admin":false},"repo":{"id":5185084,"name":"lens","full_name":"ekmett/lens","owner":{"login":"ekmett","id":304657,"avatar_url":"https://avatars.githubusercontent.com/u/304657?v=3","gravatar_id":"","url":"https://api.github.com/users/ekmett","html_url":"https://github.com/ekmett","followers_url":"https://api.github.com/users/ekmett/followers","following_url":"https://api.github.com/users/ekmett/following{/other_user}","gists_url":"https://api.github.com/users/ekmett/gists{/gist_id}","starred_url":"https://api.github.com/users/ekmett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekmett/subscriptions","organizations_url":"https://api.github.com/users/ekmett/orgs","repos_url":"https://api.github.com/users/ekmett/repos","events_url":"https://api.github.com/users/ekmett/events{/privacy}","received_events_url":"https://api.github.com/users/ekmett/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ekmett/lens","description":"Lenses, Folds, and Traversals - Join us on freenode #haskell-lens","fork":false,"url":"https://api.github.com/repos/ekmett/lens","forks_url":"https://api.github.com/repos/ekmett/lens/forks","keys_url":"https://api.github.com/repos/ekmett/lens/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ekmett/lens/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ekmett/lens/teams","hooks_url":"https://api.github.com/repos/ekmett/lens/hooks","issue_events_url":"https://api.github.com/repos/ekmett/lens/issues/events{/number}","events_url":"https://api.github.com/repos/ekmett/lens/events","assignees_url":"https://api.github.com/repos/ekmett/lens/assignees{/user}","branches_url":"https://api.github.com/repos/ekmett/lens/branches{/branch}","tags_url":"https://api.github.com/repos/ekmett/lens/tags","blobs_url":"https://api.github.com/repos/ekmett/lens/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ekmett/lens/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ekmett/lens/git/refs{/sha}","trees_url":"https://api.github.com/repos/ekmett/lens/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ekmett/lens/statuses/{sha}","languages_url":"https://api.github.com/repos/ekmett/lens/languages","stargazers_url":"https://api.github.com/repos/ekmett/lens/stargazers","contributors_url":"https://api.github.com/repos/ekmett/lens/contributors","subscribers_url":"https://api.github.com/repos/ekmett/lens/subscribers","subscription_url":"https://api.github.com/repos/ekmett/lens/subscription","commits_url":"https://api.github.com/repos/ekmett/lens/commits{/sha}","git_commits_url":"https://api.github.com/repos/ekmett/lens/git/commits{/sha}","comments_url":"https://api.github.com/repos/ekmett/lens/comments{/number}","issue_comment_url":"https://api.github.com/repos/ekmett/lens/issues/comments{/number}","contents_url":"https://api.github.com/repos/ekmett/lens/contents/{+path}","compare_url":"https://api.github.com/repos/ekmett/lens/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ekmett/lens/merges","archive_url":"https://api.github.com/repos/ekmett/lens/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ekmett/lens/downloads","issues_url":"https://api.github.com/repos/ekmett/lens/issues{/number}","pulls_url":"https://api.github.com/repos/ekmett/lens/pulls{/number}","milestones_url":"https://api.github.com/repos/ekmett/lens/milestones{/number}","notifications_url":"https://api.github.com/repos/ekmett/lens/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ekmett/lens/labels{/name}","releases_url":"https://api.github.com/repos/ekmett/lens/releases{/id}","deployments_url":"https://api.github.com/repos/ekmett/lens/deployments","created_at":"2012-07-25T22:00:42Z","updated_at":"2016-08-29T09:48:49Z","pushed_at":"2016-08-31T13:48:17Z","git_url":"git://github.com/ekmett/lens.git","ssh_url":"git@github.com:ekmett/lens.git","clone_url":"https://github.com/ekmett/lens.git","svn_url":"https://github.com/ekmett/lens","homepage":"http://lens.github.com/","size":27035,"stargazers_count":879,"watchers_count":879,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":156,"mirror_url":null,"open_issues_count":48,"forks":156,"open_issues":48,"watchers":879,"default_branch":"master"}},"base":{"label":"ekmett:master","ref":"master","sha":"a3f808dfdd78982e0d4ff43988ace9e8a5ddb884","user":{"login":"ekmett","id":304657,"avatar_url":"https://avatars.githubusercontent.com/u/304657?v=3","gravatar_id":"","url":"https://api.github.com/users/ekmett","html_url":"https://github.com/ekmett","followers_url":"https://api.github.com/users/ekmett/followers","following_url":"https://api.github.com/users/ekmett/following{/other_user}","gists_url":"https://api.github.com/users/ekmett/gists{/gist_id}","starred_url":"https://api.github.com/users/ekmett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekmett/subscriptions","organizations_url":"https://api.github.com/users/ekmett/orgs","repos_url":"https://api.github.com/users/ekmett/repos","events_url":"https://api.github.com/users/ekmett/events{/privacy}","received_events_url":"https://api.github.com/users/ekmett/received_events","type":"User","site_admin":false},"repo":{"id":5185084,"name":"lens","full_name":"ekmett/lens","owner":{"login":"ekmett","id":304657,"avatar_url":"https://avatars.githubusercontent.com/u/304657?v=3","gravatar_id":"","url":"https://api.github.com/users/ekmett","html_url":"https://github.com/ekmett","followers_url":"https://api.github.com/users/ekmett/followers","following_url":"https://api.github.com/users/ekmett/following{/other_user}","gists_url":"https://api.github.com/users/ekmett/gists{/gist_id}","starred_url":"https://api.github.com/users/ekmett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekmett/subscriptions","organizations_url":"https://api.github.com/users/ekmett/orgs","repos_url":"https://api.github.com/users/ekmett/repos","events_url":"https://api.github.com/users/ekmett/events{/privacy}","received_events_url":"https://api.github.com/users/ekmett/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ekmett/lens","description":"Lenses, Folds, and Traversals - Join us on freenode #haskell-lens","fork":false,"url":"https://api.github.com/repos/ekmett/lens","forks_url":"https://api.github.com/repos/ekmett/lens/forks","keys_url":"https://api.github.com/repos/ekmett/lens/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ekmett/lens/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ekmett/lens/teams","hooks_url":"https://api.github.com/repos/ekmett/lens/hooks","issue_events_url":"https://api.github.com/repos/ekmett/lens/issues/events{/number}","events_url":"https://api.github.com/repos/ekmett/lens/events","assignees_url":"https://api.github.com/repos/ekmett/lens/assignees{/user}","branches_url":"https://api.github.com/repos/ekmett/lens/branches{/branch}","tags_url":"https://api.github.com/repos/ekmett/lens/tags","blobs_url":"https://api.github.com/repos/ekmett/lens/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ekmett/lens/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ekmett/lens/git/refs{/sha}","trees_url":"https://api.github.com/repos/ekmett/lens/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ekmett/lens/statuses/{sha}","languages_url":"https://api.github.com/repos/ekmett/lens/languages","stargazers_url":"https://api.github.com/repos/ekmett/lens/stargazers","contributors_url":"https://api.github.com/repos/ekmett/lens/contributors","subscribers_url":"https://api.github.com/repos/ekmett/lens/subscribers","subscription_url":"https://api.github.com/repos/ekmett/lens/subscription","commits_url":"https://api.github.com/repos/ekmett/lens/commits{/sha}","git_commits_url":"https://api.github.com/repos/ekmett/lens/git/commits{/sha}","comments_url":"https://api.github.com/repos/ekmett/lens/comments{/number}","issue_comment_url":"https://api.github.com/repos/ekmett/lens/issues/comments{/number}","contents_url":"https://api.github.com/repos/ekmett/lens/contents/{+path}","compare_url":"https://api.github.com/repos/ekmett/lens/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ekmett/lens/merges","archive_url":"https://api.github.com/repos/ekmett/lens/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ekmett/lens/downloads","issues_url":"https://api.github.com/repos/ekmett/lens/issues{/number}","pulls_url":"https://api.github.com/repos/ekmett/lens/pulls{/number}","milestones_url":"https://api.github.com/repos/ekmett/lens/milestones{/number}","notifications_url":"https://api.github.com/repos/ekmett/lens/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ekmett/lens/labels{/name}","releases_url":"https://api.github.com/repos/ekmett/lens/releases{/id}","deployments_url":"https://api.github.com/repos/ekmett/lens/deployments","created_at":"2012-07-25T22:00:42Z","updated_at":"2016-08-29T09:48:49Z","pushed_at":"2016-08-31T13:48:17Z","git_url":"git://github.com/ekmett/lens.git","ssh_url":"git@github.com:ekmett/lens.git","clone_url":"https://github.com/ekmett/lens.git","svn_url":"https://github.com/ekmett/lens","homepage":"http://lens.github.com/","size":27035,"stargazers_count":879,"watchers_count":879,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":156,"mirror_url":null,"open_issues_count":48,"forks":156,"open_issues":48,"watchers":879,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ekmett/lens/pulls/673"},"html":{"href":"https://github.com/ekmett/lens/pull/673"},"issue":{"href":"https://api.github.com/repos/ekmett/lens/issues/673"},"comments":{"href":"https://api.github.com/repos/ekmett/lens/issues/673/comments"},"review_comments":{"href":"https://api.github.com/repos/ekmett/lens/pulls/673/comments"},"review_comment":{"href":"https://api.github.com/repos/ekmett/lens/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ekmett/lens/pulls/673/commits"},"statuses":{"href":"https://api.github.com/repos/ekmett/lens/statuses/791b3b5c676f3ccb44497a4855d2cdf66169fee1"}}}}
{"actor":{"display_login":"RyanGlScott"}}