{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/15690","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15690/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15690/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15690/events","html_url":"https://github.com/cms-sw/cmssw/pull/15690","id":174458149,"number":15690,"title":"Fixing Method 2 use in SimpleHBHEPhase1Algo","user":{"login":"igv4321","id":5552377,"avatar_url":"https://avatars.githubusercontent.com/u/5552377?v=3","gravatar_id":"","url":"https://api.github.com/users/igv4321","html_url":"https://github.com/igv4321","followers_url":"https://api.github.com/users/igv4321/followers","following_url":"https://api.github.com/users/igv4321/following{/other_user}","gists_url":"https://api.github.com/users/igv4321/gists{/gist_id}","starred_url":"https://api.github.com/users/igv4321/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igv4321/subscriptions","organizations_url":"https://api.github.com/users/igv4321/orgs","repos_url":"https://api.github.com/users/igv4321/repos","events_url":"https://api.github.com/users/igv4321/events{/privacy}","received_events_url":"https://api.github.com/users/igv4321/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"009800"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_1_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59/labels","id":1590252,"number":59,"title":"Next CMSSW_8_1_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":63,"closed_issues":1343,"state":"open","created_at":"2016-02-18T09:12:12Z","updated_at":"2016-09-02T18:40:25Z","due_on":null,"closed_at":null},"comments":9,"created_at":"2016-09-01T07:48:26Z","updated_at":"2016-09-02T20:08:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/15690","html_url":"https://github.com/cms-sw/cmssw/pull/15690","diff_url":"https://github.com/cms-sw/cmssw/pull/15690.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/15690.patch"},"body":"Calling \"setPulseShapeTemplate\" function of \"Method 2\" with the correct second argument\r\n(bug fix).\r\n\r\nSetting the rechit flag according to the use of \"triple pulse\" fit by Metod 2 (consistent with\r\nRun 2 code).\r\n"},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/244475558","html_url":"https://github.com/cms-sw/cmssw/pull/15690#issuecomment-244475558","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15690","id":244475558,"user":{"login":"slava77","id":4676718,"avatar_url":"https://avatars.githubusercontent.com/u/4676718?v=3","gravatar_id":"","url":"https://api.github.com/users/slava77","html_url":"https://github.com/slava77","followers_url":"https://api.github.com/users/slava77/followers","following_url":"https://api.github.com/users/slava77/following{/other_user}","gists_url":"https://api.github.com/users/slava77/gists{/gist_id}","starred_url":"https://api.github.com/users/slava77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slava77/subscriptions","organizations_url":"https://api.github.com/users/slava77/orgs","repos_url":"https://api.github.com/users/slava77/repos","events_url":"https://api.github.com/users/slava77/events{/privacy}","received_events_url":"https://api.github.com/users/slava77/received_events","type":"User","site_admin":false},"created_at":"2016-09-02T20:08:26Z","updated_at":"2016-09-02T20:08:26Z","body":"+1\r\n\r\nfor https://github.com/cms-sw/cmssw/pull/15690 6c5aaf3\r\n- changes in the code are as described: only phase-1 HCAL reco is affected (not in standard workflows yet)\r\n- jenkins tests pass and comparisons with baseline show no differences\r\n- local test with PU35 Hcal2017Full setup shows changes starting from hbhe energy and propagates downstream. This is in agreement with the bug fix (the baseline version had HPD settings swapped with SiPM)\r\n    - the bulk of the energy distribution is unchanged, there are more lower-pt (above threshold) hits now\r\n    - flag variable has changed, due to it now being set\r\n    - on the technical side, the CPU time has gone down by about 10%. \r\n![all_sign755vsorig_ttbarhcal2017fullpu35c_log10calotowerssorted_towermaker__reco_obj_obj_energy](https://cloud.githubusercontent.com/assets/4676718/18216654/f4fda804-710c-11e6-9883-bcce5bf1a666.png)\r\n![all_sign755vsorig_ttbarhcal2017fullpu35c_log10recopfcandidates_particleflow__reco_obj_pt55](https://cloud.githubusercontent.com/assets/4676718/18216730/8917cc86-710d-11e6-9d17-ba08742e69cf.png)\r\n"}}
{"actor":{"display_login":"slava77"}}