{"action":"created","issue":{"url":"https://api.github.com/repos/marmelroy/PhoneNumberKit/issues/92","repository_url":"https://api.github.com/repos/marmelroy/PhoneNumberKit","labels_url":"https://api.github.com/repos/marmelroy/PhoneNumberKit/issues/92/labels{/name}","comments_url":"https://api.github.com/repos/marmelroy/PhoneNumberKit/issues/92/comments","events_url":"https://api.github.com/repos/marmelroy/PhoneNumberKit/issues/92/events","html_url":"https://github.com/marmelroy/PhoneNumberKit/issues/92","id":192833164,"number":92,"title":"Parse slowness","user":{"login":"sgapr","id":16302482,"avatar_url":"https://avatars.githubusercontent.com/u/16302482?v=3","gravatar_id":"","url":"https://api.github.com/users/sgapr","html_url":"https://github.com/sgapr","followers_url":"https://api.github.com/users/sgapr/followers","following_url":"https://api.github.com/users/sgapr/following{/other_user}","gists_url":"https://api.github.com/users/sgapr/gists{/gist_id}","starred_url":"https://api.github.com/users/sgapr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgapr/subscriptions","organizations_url":"https://api.github.com/users/sgapr/orgs","repos_url":"https://api.github.com/users/sgapr/repos","events_url":"https://api.github.com/users/sgapr/events{/privacy}","received_events_url":"https://api.github.com/users/sgapr/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-01T12:27:00Z","updated_at":"2016-12-01T12:40:31Z","closed_at":"2016-12-01T12:30:49Z","body":"I am getting around 12-15s in doing 686 parses in serial using the following code. Replacing it with libPhoneNumber-iOS, i get around 3s for the same. Is this a regression ? \r\n\r\n```swift\r\nclass func normalizedString(phoneNumber: CNPhoneNumber, region: String) -> String? {\r\n       do {\r\n            let phoneNumber = try PhoneNumberUtils.sPhoneNumberKit.parse(phoneNumber.stringValue, withRegion: region)\r\n            return PhoneNumberUtils.sPhoneNumberKit.format(phoneNumber, toType: .e164)\r\n        } catch {\r\n            return nil\r\n        }\r\n}\r\n```\r\n "},"comment":{"url":"https://api.github.com/repos/marmelroy/PhoneNumberKit/issues/comments/264163879","html_url":"https://github.com/marmelroy/PhoneNumberKit/issues/92#issuecomment-264163879","issue_url":"https://api.github.com/repos/marmelroy/PhoneNumberKit/issues/92","id":264163879,"user":{"login":"sgapr","id":16302482,"avatar_url":"https://avatars.githubusercontent.com/u/16302482?v=3","gravatar_id":"","url":"https://api.github.com/users/sgapr","html_url":"https://github.com/sgapr","followers_url":"https://api.github.com/users/sgapr/followers","following_url":"https://api.github.com/users/sgapr/following{/other_user}","gists_url":"https://api.github.com/users/sgapr/gists{/gist_id}","starred_url":"https://api.github.com/users/sgapr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgapr/subscriptions","organizations_url":"https://api.github.com/users/sgapr/orgs","repos_url":"https://api.github.com/users/sgapr/repos","events_url":"https://api.github.com/users/sgapr/events{/privacy}","received_events_url":"https://api.github.com/users/sgapr/received_events","type":"User","site_admin":false},"created_at":"2016-12-01T12:40:31Z","updated_at":"2016-12-01T12:40:31Z","body":"Still the same. Looking inside the parse code, ignoreType does not seem to cut down any code. Below is the only usage of ignoreType\r\n\r\n```swift\r\n   let type = parser.checkNumberType(String(nationalNumber), metadata: regionMetadata, leadingZero: leadingZero)\r\n        if type == .unknown && !ignoreType {\r\n            throw PhoneNumberError.unknownType\r\n        }\r\n```"}}
{"actor":{"display_login":"sgapr"}}