{"action":"closed","number":2427,"pull_request":{"url":"https://api.github.com/repos/sulu/sulu/pulls/2427","id":72012246,"html_url":"https://github.com/sulu/sulu/pull/2427","diff_url":"https://github.com/sulu/sulu/pull/2427.diff","patch_url":"https://github.com/sulu/sulu/pull/2427.patch","issue_url":"https://api.github.com/repos/sulu/sulu/issues/2427","number":2427,"state":"closed","locked":false,"title":"Fixed bug when using non generic visitor in HashSerializeEventSubscriber","user":{"login":"turbo-ele","id":5152633,"avatar_url":"https://avatars.githubusercontent.com/u/5152633?v=3","gravatar_id":"","url":"https://api.github.com/users/turbo-ele","html_url":"https://github.com/turbo-ele","followers_url":"https://api.github.com/users/turbo-ele/followers","following_url":"https://api.github.com/users/turbo-ele/following{/other_user}","gists_url":"https://api.github.com/users/turbo-ele/gists{/gist_id}","starred_url":"https://api.github.com/users/turbo-ele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turbo-ele/subscriptions","organizations_url":"https://api.github.com/users/turbo-ele/orgs","repos_url":"https://api.github.com/users/turbo-ele/repos","events_url":"https://api.github.com/users/turbo-ele/events{/privacy}","received_events_url":"https://api.github.com/users/turbo-ele/received_events","type":"User","site_admin":false},"body":"| Q | A\r\n| --- | ---\r\n| Bug fix? | yes\r\n| New feature? | no\r\n| BC breaks? | no\r\n| Deprecations? | no\r\n| Fixed tickets | none\r\n| Related issues/PRs | none\r\n| License | MIT\r\n| Documentation PR | none\r\n\r\n#### What's in this PR?\r\n\r\nHashSerializeEventSubscriber called addData for every Visitor, even though it's only supported by GenericVisitor instances.\r\n\r\n#### Why?\r\n\r\nBecause that was a bug ;)","created_at":"2016-05-31T13:08:18Z","updated_at":"2016-05-31T14:19:45Z","closed_at":"2016-05-31T14:19:45Z","merged_at":"2016-05-31T14:19:45Z","merge_commit_sha":"c67943c3f0e4ac994f3e9bf05202adafad282cc4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sulu/sulu/pulls/2427/commits","review_comments_url":"https://api.github.com/repos/sulu/sulu/pulls/2427/comments","review_comment_url":"https://api.github.com/repos/sulu/sulu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sulu/sulu/issues/2427/comments","statuses_url":"https://api.github.com/repos/sulu/sulu/statuses/371be8bb1b8fe58be92996bfdbb9d9d3426962b3","head":{"label":"massiveart:bugfix/hashserialization","ref":"bugfix/hashserialization","sha":"371be8bb1b8fe58be92996bfdbb9d9d3426962b3","user":{"login":"massiveart","id":854731,"avatar_url":"https://avatars.githubusercontent.com/u/854731?v=3","gravatar_id":"","url":"https://api.github.com/users/massiveart","html_url":"https://github.com/massiveart","followers_url":"https://api.github.com/users/massiveart/followers","following_url":"https://api.github.com/users/massiveart/following{/other_user}","gists_url":"https://api.github.com/users/massiveart/gists{/gist_id}","starred_url":"https://api.github.com/users/massiveart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/massiveart/subscriptions","organizations_url":"https://api.github.com/users/massiveart/orgs","repos_url":"https://api.github.com/users/massiveart/repos","events_url":"https://api.github.com/users/massiveart/events{/privacy}","received_events_url":"https://api.github.com/users/massiveart/received_events","type":"Organization","site_admin":false},"repo":{"id":33129845,"name":"sulu","full_name":"massiveart/sulu","owner":{"login":"massiveart","id":854731,"avatar_url":"https://avatars.githubusercontent.com/u/854731?v=3","gravatar_id":"","url":"https://api.github.com/users/massiveart","html_url":"https://github.com/massiveart","followers_url":"https://api.github.com/users/massiveart/followers","following_url":"https://api.github.com/users/massiveart/following{/other_user}","gists_url":"https://api.github.com/users/massiveart/gists{/gist_id}","starred_url":"https://api.github.com/users/massiveart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/massiveart/subscriptions","organizations_url":"https://api.github.com/users/massiveart/orgs","repos_url":"https://api.github.com/users/massiveart/repos","events_url":"https://api.github.com/users/massiveart/events{/privacy}","received_events_url":"https://api.github.com/users/massiveart/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/massiveart/sulu","description":"Sulu 2.0 core bundle & components","fork":true,"url":"https://api.github.com/repos/massiveart/sulu","forks_url":"https://api.github.com/repos/massiveart/sulu/forks","keys_url":"https://api.github.com/repos/massiveart/sulu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/massiveart/sulu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/massiveart/sulu/teams","hooks_url":"https://api.github.com/repos/massiveart/sulu/hooks","issue_events_url":"https://api.github.com/repos/massiveart/sulu/issues/events{/number}","events_url":"https://api.github.com/repos/massiveart/sulu/events","assignees_url":"https://api.github.com/repos/massiveart/sulu/assignees{/user}","branches_url":"https://api.github.com/repos/massiveart/sulu/branches{/branch}","tags_url":"https://api.github.com/repos/massiveart/sulu/tags","blobs_url":"https://api.github.com/repos/massiveart/sulu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/massiveart/sulu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/massiveart/sulu/git/refs{/sha}","trees_url":"https://api.github.com/repos/massiveart/sulu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/massiveart/sulu/statuses/{sha}","languages_url":"https://api.github.com/repos/massiveart/sulu/languages","stargazers_url":"https://api.github.com/repos/massiveart/sulu/stargazers","contributors_url":"https://api.github.com/repos/massiveart/sulu/contributors","subscribers_url":"https://api.github.com/repos/massiveart/sulu/subscribers","subscription_url":"https://api.github.com/repos/massiveart/sulu/subscription","commits_url":"https://api.github.com/repos/massiveart/sulu/commits{/sha}","git_commits_url":"https://api.github.com/repos/massiveart/sulu/git/commits{/sha}","comments_url":"https://api.github.com/repos/massiveart/sulu/comments{/number}","issue_comment_url":"https://api.github.com/repos/massiveart/sulu/issues/comments{/number}","contents_url":"https://api.github.com/repos/massiveart/sulu/contents/{+path}","compare_url":"https://api.github.com/repos/massiveart/sulu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/massiveart/sulu/merges","archive_url":"https://api.github.com/repos/massiveart/sulu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/massiveart/sulu/downloads","issues_url":"https://api.github.com/repos/massiveart/sulu/issues{/number}","pulls_url":"https://api.github.com/repos/massiveart/sulu/pulls{/number}","milestones_url":"https://api.github.com/repos/massiveart/sulu/milestones{/number}","notifications_url":"https://api.github.com/repos/massiveart/sulu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/massiveart/sulu/labels{/name}","releases_url":"https://api.github.com/repos/massiveart/sulu/releases{/id}","deployments_url":"https://api.github.com/repos/massiveart/sulu/deployments","created_at":"2015-03-30T15:00:41Z","updated_at":"2015-04-24T07:15:08Z","pushed_at":"2016-05-31T13:11:23Z","git_url":"git://github.com/massiveart/sulu.git","ssh_url":"git@github.com:massiveart/sulu.git","clone_url":"https://github.com/massiveart/sulu.git","svn_url":"https://github.com/massiveart/sulu","homepage":"www.sulu.io","size":67998,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"sulu:master","ref":"master","sha":"099895801a1036b5bb36880f69de84905b2d4333","user":{"login":"sulu","id":5717006,"avatar_url":"https://avatars.githubusercontent.com/u/5717006?v=3","gravatar_id":"","url":"https://api.github.com/users/sulu","html_url":"https://github.com/sulu","followers_url":"https://api.github.com/users/sulu/followers","following_url":"https://api.github.com/users/sulu/following{/other_user}","gists_url":"https://api.github.com/users/sulu/gists{/gist_id}","starred_url":"https://api.github.com/users/sulu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulu/subscriptions","organizations_url":"https://api.github.com/users/sulu/orgs","repos_url":"https://api.github.com/users/sulu/repos","events_url":"https://api.github.com/users/sulu/events{/privacy}","received_events_url":"https://api.github.com/users/sulu/received_events","type":"Organization","site_admin":false},"repo":{"id":13678015,"name":"sulu","full_name":"sulu/sulu","owner":{"login":"sulu","id":5717006,"avatar_url":"https://avatars.githubusercontent.com/u/5717006?v=3","gravatar_id":"","url":"https://api.github.com/users/sulu","html_url":"https://github.com/sulu","followers_url":"https://api.github.com/users/sulu/followers","following_url":"https://api.github.com/users/sulu/following{/other_user}","gists_url":"https://api.github.com/users/sulu/gists{/gist_id}","starred_url":"https://api.github.com/users/sulu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulu/subscriptions","organizations_url":"https://api.github.com/users/sulu/orgs","repos_url":"https://api.github.com/users/sulu/repos","events_url":"https://api.github.com/users/sulu/events{/privacy}","received_events_url":"https://api.github.com/users/sulu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sulu/sulu","description":"Sulu core bundles & components","fork":false,"url":"https://api.github.com/repos/sulu/sulu","forks_url":"https://api.github.com/repos/sulu/sulu/forks","keys_url":"https://api.github.com/repos/sulu/sulu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sulu/sulu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sulu/sulu/teams","hooks_url":"https://api.github.com/repos/sulu/sulu/hooks","issue_events_url":"https://api.github.com/repos/sulu/sulu/issues/events{/number}","events_url":"https://api.github.com/repos/sulu/sulu/events","assignees_url":"https://api.github.com/repos/sulu/sulu/assignees{/user}","branches_url":"https://api.github.com/repos/sulu/sulu/branches{/branch}","tags_url":"https://api.github.com/repos/sulu/sulu/tags","blobs_url":"https://api.github.com/repos/sulu/sulu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sulu/sulu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sulu/sulu/git/refs{/sha}","trees_url":"https://api.github.com/repos/sulu/sulu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sulu/sulu/statuses/{sha}","languages_url":"https://api.github.com/repos/sulu/sulu/languages","stargazers_url":"https://api.github.com/repos/sulu/sulu/stargazers","contributors_url":"https://api.github.com/repos/sulu/sulu/contributors","subscribers_url":"https://api.github.com/repos/sulu/sulu/subscribers","subscription_url":"https://api.github.com/repos/sulu/sulu/subscription","commits_url":"https://api.github.com/repos/sulu/sulu/commits{/sha}","git_commits_url":"https://api.github.com/repos/sulu/sulu/git/commits{/sha}","comments_url":"https://api.github.com/repos/sulu/sulu/comments{/number}","issue_comment_url":"https://api.github.com/repos/sulu/sulu/issues/comments{/number}","contents_url":"https://api.github.com/repos/sulu/sulu/contents/{+path}","compare_url":"https://api.github.com/repos/sulu/sulu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sulu/sulu/merges","archive_url":"https://api.github.com/repos/sulu/sulu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sulu/sulu/downloads","issues_url":"https://api.github.com/repos/sulu/sulu/issues{/number}","pulls_url":"https://api.github.com/repos/sulu/sulu/pulls{/number}","milestones_url":"https://api.github.com/repos/sulu/sulu/milestones{/number}","notifications_url":"https://api.github.com/repos/sulu/sulu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sulu/sulu/labels{/name}","releases_url":"https://api.github.com/repos/sulu/sulu/releases{/id}","deployments_url":"https://api.github.com/repos/sulu/sulu/deployments","created_at":"2013-10-18T12:57:02Z","updated_at":"2016-05-24T11:18:57Z","pushed_at":"2016-05-31T14:19:45Z","git_url":"git://github.com/sulu/sulu.git","ssh_url":"git@github.com:sulu/sulu.git","clone_url":"https://github.com/sulu/sulu.git","svn_url":"https://github.com/sulu/sulu","homepage":"sulu.io","size":78372,"stargazers_count":126,"watchers_count":126,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":379,"forks":35,"open_issues":379,"watchers":126,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/sulu/sulu/pulls/2427"},"html":{"href":"https://github.com/sulu/sulu/pull/2427"},"issue":{"href":"https://api.github.com/repos/sulu/sulu/issues/2427"},"comments":{"href":"https://api.github.com/repos/sulu/sulu/issues/2427/comments"},"review_comments":{"href":"https://api.github.com/repos/sulu/sulu/pulls/2427/comments"},"review_comment":{"href":"https://api.github.com/repos/sulu/sulu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sulu/sulu/pulls/2427/commits"},"statuses":{"href":"https://api.github.com/repos/sulu/sulu/statuses/371be8bb1b8fe58be92996bfdbb9d9d3426962b3"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"danrot","id":405874,"avatar_url":"https://avatars.githubusercontent.com/u/405874?v=3","gravatar_id":"","url":"https://api.github.com/users/danrot","html_url":"https://github.com/danrot","followers_url":"https://api.github.com/users/danrot/followers","following_url":"https://api.github.com/users/danrot/following{/other_user}","gists_url":"https://api.github.com/users/danrot/gists{/gist_id}","starred_url":"https://api.github.com/users/danrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danrot/subscriptions","organizations_url":"https://api.github.com/users/danrot/orgs","repos_url":"https://api.github.com/users/danrot/repos","events_url":"https://api.github.com/users/danrot/events{/privacy}","received_events_url":"https://api.github.com/users/danrot/received_events","type":"User","site_admin":false},"comments":0,"review_comments":4,"commits":1,"additions":33,"deletions":11,"changed_files":8}}
{"actor":{"display_login":"danrot"}}