{"action":"created","issue":{"url":"https://api.github.com/repos/LMFDB/lmfdb/issues/1214","repository_url":"https://api.github.com/repos/LMFDB/lmfdb","labels_url":"https://api.github.com/repos/LMFDB/lmfdb/issues/1214/labels{/name}","comments_url":"https://api.github.com/repos/LMFDB/lmfdb/issues/1214/comments","events_url":"https://api.github.com/repos/LMFDB/lmfdb/issues/1214/events","html_url":"https://github.com/LMFDB/lmfdb/pull/1214","id":153565715,"number":1214,"title":"Fix critical issue #1207 in classical modular forms","user":{"login":"AndrewVSutherland","id":11425002,"avatar_url":"https://avatars.githubusercontent.com/u/11425002?v=3","gravatar_id":"","url":"https://api.github.com/users/AndrewVSutherland","html_url":"https://github.com/AndrewVSutherland","followers_url":"https://api.github.com/users/AndrewVSutherland/followers","following_url":"https://api.github.com/users/AndrewVSutherland/following{/other_user}","gists_url":"https://api.github.com/users/AndrewVSutherland/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrewVSutherland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrewVSutherland/subscriptions","organizations_url":"https://api.github.com/users/AndrewVSutherland/orgs","repos_url":"https://api.github.com/users/AndrewVSutherland/repos","events_url":"https://api.github.com/users/AndrewVSutherland/events{/privacy}","received_events_url":"https://api.github.com/users/AndrewVSutherland/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-05-07T01:33:27Z","updated_at":"2016-05-07T09:06:44Z","closed_at":"2016-05-07T01:36:26Z","pull_request":{"url":"https://api.github.com/repos/LMFDB/lmfdb/pulls/1214","html_url":"https://github.com/LMFDB/lmfdb/pull/1214","diff_url":"https://github.com/LMFDB/lmfdb/pull/1214.diff","patch_url":"https://github.com/LMFDB/lmfdb/pull/1214.patch"},"body":"This is a simple one line fix, the code was failing because the rational coefficient field has no method .relative_polynomial_latex. \r\n\r\nNote: test_non_triv_character fails, but it failed before this change as well, I will raise a separate (non-criticla) issue for this."},"comment":{"url":"https://api.github.com/repos/LMFDB/lmfdb/issues/comments/217621597","html_url":"https://github.com/LMFDB/lmfdb/pull/1214#issuecomment-217621597","issue_url":"https://api.github.com/repos/LMFDB/lmfdb/issues/1214","id":217621597,"user":{"login":"fredstro","id":1598083,"avatar_url":"https://avatars.githubusercontent.com/u/1598083?v=3","gravatar_id":"","url":"https://api.github.com/users/fredstro","html_url":"https://github.com/fredstro","followers_url":"https://api.github.com/users/fredstro/followers","following_url":"https://api.github.com/users/fredstro/following{/other_user}","gists_url":"https://api.github.com/users/fredstro/gists{/gist_id}","starred_url":"https://api.github.com/users/fredstro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredstro/subscriptions","organizations_url":"https://api.github.com/users/fredstro/orgs","repos_url":"https://api.github.com/users/fredstro/repos","events_url":"https://api.github.com/users/fredstro/events{/privacy}","received_events_url":"https://api.github.com/users/fredstro/received_events","type":"User","site_admin":false},"created_at":"2016-05-07T09:06:43Z","updated_at":"2016-05-07T09:06:43Z","body":"It is,  but not necessarily as you wrote it...\nThe underlying problem is that the coefficient field of a webnewform should\nbe a WebProperty which has a value which is a usual  number field but\nintrinsically is \"our version of\" a web number field which means in\nparticular that it has the property relative_polynomial_latex.\nIt is not a problem that the field is the rational field but rather that\nthe field was not initialized properly ftom the database,  most likely\nbecause of an incomplete database record.\nThis means of course that the problem could also appear for higher degree\nfields.\nThe best fix to avoid a critical fail would be to test for the property\nbefore calling the template or by using a python getattr with a default\nvalue.\nFredrik\n\nOn Sat, 7 May 2016 02:36 AndrewVSutherland, <notifications@github.com>\nwrote:\n\n> Merged #1214 <https://github.com/LMFDB/lmfdb/pull/1214>.\n>\n> —\n> You are receiving this because you are subscribed to this thread.\n> Reply to this email directly or view it on GitHub\n> <https://github.com/LMFDB/lmfdb/pull/1214#event-653309789>\n>\n"}}