{"action":"created","issue":{"url":"https://api.github.com/repos/adobe/brackets-shell/issues/553","repository_url":"https://api.github.com/repos/adobe/brackets-shell","labels_url":"https://api.github.com/repos/adobe/brackets-shell/issues/553/labels{/name}","comments_url":"https://api.github.com/repos/adobe/brackets-shell/issues/553/comments","events_url":"https://api.github.com/repos/adobe/brackets-shell/issues/553/events","html_url":"https://github.com/adobe/brackets-shell/pull/553","id":154902656,"number":553,"title":"[MAC] Fix for open file dialog being jerky","user":{"login":"nethip","id":1577184,"avatar_url":"https://avatars.githubusercontent.com/u/1577184?v=3","gravatar_id":"","url":"https://api.github.com/users/nethip","html_url":"https://github.com/nethip","followers_url":"https://api.github.com/users/nethip/followers","following_url":"https://api.github.com/users/nethip/following{/other_user}","gists_url":"https://api.github.com/users/nethip/gists{/gist_id}","starred_url":"https://api.github.com/users/nethip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nethip/subscriptions","organizations_url":"https://api.github.com/users/nethip/orgs","repos_url":"https://api.github.com/users/nethip/repos","events_url":"https://api.github.com/users/nethip/events{/privacy}","received_events_url":"https://api.github.com/users/nethip/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-05-15T11:02:08Z","updated_at":"2016-05-17T12:03:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/adobe/brackets-shell/pulls/553","html_url":"https://github.com/adobe/brackets-shell/pull/553","diff_url":"https://github.com/adobe/brackets-shell/pull/553.diff","patch_url":"https://github.com/adobe/brackets-shell/pull/553.patch"},"body":"This PR addresses the following items.\r\n\r\n - The file open/save dialog jerks a bit when launched from Brackets. The reason for that being we are not honouring the `completionHandler` semantics, when launching the dialog using `beginSheetModalForWindow`. After installing `completionHandler` block, I realised it is not straight forward, as we would have returning by then. So had to make changes which involved caching the reference of the browser, so that the same could be used inside the `completionHandler` block. Also took care of re-entrant scenarios by using a map, to cache the requests and send the response to the right corresponding browser.\r\n\r\n - When multiple windows like, new brackets window, or devtools, were open, the entries were missing from the *Window* menu. So made sure, we have a menu entry for all open windows under *Windows* menu on MAC.\r\n"},"comment":{"url":"https://api.github.com/repos/adobe/brackets-shell/issues/comments/219697522","html_url":"https://github.com/adobe/brackets-shell/pull/553#issuecomment-219697522","issue_url":"https://api.github.com/repos/adobe/brackets-shell/issues/553","id":219697522,"user":{"login":"nethip","id":1577184,"avatar_url":"https://avatars.githubusercontent.com/u/1577184?v=3","gravatar_id":"","url":"https://api.github.com/users/nethip","html_url":"https://github.com/nethip","followers_url":"https://api.github.com/users/nethip/followers","following_url":"https://api.github.com/users/nethip/following{/other_user}","gists_url":"https://api.github.com/users/nethip/gists{/gist_id}","starred_url":"https://api.github.com/users/nethip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nethip/subscriptions","organizations_url":"https://api.github.com/users/nethip/orgs","repos_url":"https://api.github.com/users/nethip/repos","events_url":"https://api.github.com/users/nethip/events{/privacy}","received_events_url":"https://api.github.com/users/nethip/received_events","type":"User","site_admin":false},"created_at":"2016-05-17T12:03:10Z","updated_at":"2016-05-17T12:03:10Z","body":"@abhijitapte "}}