{"action":"closed","number":914,"pull_request":{"url":"https://api.github.com/repos/instructure/canvas-lms/pulls/914","id":88511639,"html_url":"https://github.com/instructure/canvas-lms/pull/914","diff_url":"https://github.com/instructure/canvas-lms/pull/914.diff","patch_url":"https://github.com/instructure/canvas-lms/pull/914.patch","issue_url":"https://api.github.com/repos/instructure/canvas-lms/issues/914","number":914,"state":"closed","locked":false,"title":"For students show the display name in the roster redo","user":{"login":"eriko","id":5929,"avatar_url":"https://avatars.githubusercontent.com/u/5929?v=3","gravatar_id":"","url":"https://api.github.com/users/eriko","html_url":"https://github.com/eriko","followers_url":"https://api.github.com/users/eriko/followers","following_url":"https://api.github.com/users/eriko/following{/other_user}","gists_url":"https://api.github.com/users/eriko/gists{/gist_id}","starred_url":"https://api.github.com/users/eriko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eriko/subscriptions","organizations_url":"https://api.github.com/users/eriko/orgs","repos_url":"https://api.github.com/users/eriko/repos","events_url":"https://api.github.com/users/eriko/events{/privacy}","received_events_url":"https://api.github.com/users/eriko/received_events","type":"User","site_admin":false},"body":"I botched the rebase so here is #901 done on master.\nhttps://github.com/instructure/canvas-lms/pull/901\n\nrepeated from the other PR\nThis also applies to other non privileged users. In all other areas of canvas that are accessible to students the users display name is shown and not the legal name. For students who name in use is not their legal name this allows them to be contactable inside canvas by their name. This also should apply to groups. The display name is sent in the JSON as short_name and is easily available. For teachers and other privileged users the legal name will be displayed. That said a good option would be to display the (display name) in parens after the link. (I have changed to do this in the new PR)\n\nI looked through the selenium tests and people_spec was the closest to this that I could find but it was only testing in the context of people as a teacher or ta. So I am not sure where to put tests.\n","created_at":"2016-10-07T21:34:16Z","updated_at":"2016-11-01T00:23:11Z","closed_at":"2016-11-01T00:23:11Z","merged_at":null,"merge_commit_sha":"7781a6d77bbf44ad8284c48f9eba9de7c7260acb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/instructure/canvas-lms/pulls/914/commits","review_comments_url":"https://api.github.com/repos/instructure/canvas-lms/pulls/914/comments","review_comment_url":"https://api.github.com/repos/instructure/canvas-lms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/instructure/canvas-lms/issues/914/comments","statuses_url":"https://api.github.com/repos/instructure/canvas-lms/statuses/4bf207282f37cd2c5e836bffde79debe1f86cf2f","head":{"label":"eriko:patch-8","ref":"patch-8","sha":"4bf207282f37cd2c5e836bffde79debe1f86cf2f","user":{"login":"eriko","id":5929,"avatar_url":"https://avatars.githubusercontent.com/u/5929?v=3","gravatar_id":"","url":"https://api.github.com/users/eriko","html_url":"https://github.com/eriko","followers_url":"https://api.github.com/users/eriko/followers","following_url":"https://api.github.com/users/eriko/following{/other_user}","gists_url":"https://api.github.com/users/eriko/gists{/gist_id}","starred_url":"https://api.github.com/users/eriko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eriko/subscriptions","organizations_url":"https://api.github.com/users/eriko/orgs","repos_url":"https://api.github.com/users/eriko/repos","events_url":"https://api.github.com/users/eriko/events{/privacy}","received_events_url":"https://api.github.com/users/eriko/received_events","type":"User","site_admin":false},"repo":{"id":23446668,"name":"canvas-lms","full_name":"eriko/canvas-lms","owner":{"login":"eriko","id":5929,"avatar_url":"https://avatars.githubusercontent.com/u/5929?v=3","gravatar_id":"","url":"https://api.github.com/users/eriko","html_url":"https://github.com/eriko","followers_url":"https://api.github.com/users/eriko/followers","following_url":"https://api.github.com/users/eriko/following{/other_user}","gists_url":"https://api.github.com/users/eriko/gists{/gist_id}","starred_url":"https://api.github.com/users/eriko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eriko/subscriptions","organizations_url":"https://api.github.com/users/eriko/orgs","repos_url":"https://api.github.com/users/eriko/repos","events_url":"https://api.github.com/users/eriko/events{/privacy}","received_events_url":"https://api.github.com/users/eriko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eriko/canvas-lms","description":"The open LMS by Instructure, Inc.","fork":true,"url":"https://api.github.com/repos/eriko/canvas-lms","forks_url":"https://api.github.com/repos/eriko/canvas-lms/forks","keys_url":"https://api.github.com/repos/eriko/canvas-lms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eriko/canvas-lms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eriko/canvas-lms/teams","hooks_url":"https://api.github.com/repos/eriko/canvas-lms/hooks","issue_events_url":"https://api.github.com/repos/eriko/canvas-lms/issues/events{/number}","events_url":"https://api.github.com/repos/eriko/canvas-lms/events","assignees_url":"https://api.github.com/repos/eriko/canvas-lms/assignees{/user}","branches_url":"https://api.github.com/repos/eriko/canvas-lms/branches{/branch}","tags_url":"https://api.github.com/repos/eriko/canvas-lms/tags","blobs_url":"https://api.github.com/repos/eriko/canvas-lms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eriko/canvas-lms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eriko/canvas-lms/git/refs{/sha}","trees_url":"https://api.github.com/repos/eriko/canvas-lms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eriko/canvas-lms/statuses/{sha}","languages_url":"https://api.github.com/repos/eriko/canvas-lms/languages","stargazers_url":"https://api.github.com/repos/eriko/canvas-lms/stargazers","contributors_url":"https://api.github.com/repos/eriko/canvas-lms/contributors","subscribers_url":"https://api.github.com/repos/eriko/canvas-lms/subscribers","subscription_url":"https://api.github.com/repos/eriko/canvas-lms/subscription","commits_url":"https://api.github.com/repos/eriko/canvas-lms/commits{/sha}","git_commits_url":"https://api.github.com/repos/eriko/canvas-lms/git/commits{/sha}","comments_url":"https://api.github.com/repos/eriko/canvas-lms/comments{/number}","issue_comment_url":"https://api.github.com/repos/eriko/canvas-lms/issues/comments{/number}","contents_url":"https://api.github.com/repos/eriko/canvas-lms/contents/{+path}","compare_url":"https://api.github.com/repos/eriko/canvas-lms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eriko/canvas-lms/merges","archive_url":"https://api.github.com/repos/eriko/canvas-lms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eriko/canvas-lms/downloads","issues_url":"https://api.github.com/repos/eriko/canvas-lms/issues{/number}","pulls_url":"https://api.github.com/repos/eriko/canvas-lms/pulls{/number}","milestones_url":"https://api.github.com/repos/eriko/canvas-lms/milestones{/number}","notifications_url":"https://api.github.com/repos/eriko/canvas-lms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eriko/canvas-lms/labels{/name}","releases_url":"https://api.github.com/repos/eriko/canvas-lms/releases{/id}","deployments_url":"https://api.github.com/repos/eriko/canvas-lms/deployments","created_at":"2014-08-28T23:52:15Z","updated_at":"2014-09-24T23:18:03Z","pushed_at":"2016-11-01T00:20:17Z","git_url":"git://github.com/eriko/canvas-lms.git","ssh_url":"git@github.com:eriko/canvas-lms.git","clone_url":"https://github.com/eriko/canvas-lms.git","svn_url":"https://github.com/eriko/canvas-lms","homepage":"https://github.com/instructure/canvas-lms/wiki","size":258797,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"stable"}},"base":{"label":"instructure:master","ref":"master","sha":"0700cc24925ea6b61d125c130071ff3f4a6b57de","user":{"login":"instructure","id":515326,"avatar_url":"https://avatars.githubusercontent.com/u/515326?v=3","gravatar_id":"","url":"https://api.github.com/users/instructure","html_url":"https://github.com/instructure","followers_url":"https://api.github.com/users/instructure/followers","following_url":"https://api.github.com/users/instructure/following{/other_user}","gists_url":"https://api.github.com/users/instructure/gists{/gist_id}","starred_url":"https://api.github.com/users/instructure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/instructure/subscriptions","organizations_url":"https://api.github.com/users/instructure/orgs","repos_url":"https://api.github.com/users/instructure/repos","events_url":"https://api.github.com/users/instructure/events{/privacy}","received_events_url":"https://api.github.com/users/instructure/received_events","type":"Organization","site_admin":false},"repo":{"id":1314319,"name":"canvas-lms","full_name":"instructure/canvas-lms","owner":{"login":"instructure","id":515326,"avatar_url":"https://avatars.githubusercontent.com/u/515326?v=3","gravatar_id":"","url":"https://api.github.com/users/instructure","html_url":"https://github.com/instructure","followers_url":"https://api.github.com/users/instructure/followers","following_url":"https://api.github.com/users/instructure/following{/other_user}","gists_url":"https://api.github.com/users/instructure/gists{/gist_id}","starred_url":"https://api.github.com/users/instructure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/instructure/subscriptions","organizations_url":"https://api.github.com/users/instructure/orgs","repos_url":"https://api.github.com/users/instructure/repos","events_url":"https://api.github.com/users/instructure/events{/privacy}","received_events_url":"https://api.github.com/users/instructure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/instructure/canvas-lms","description":"The open LMS by Instructure, Inc.","fork":false,"url":"https://api.github.com/repos/instructure/canvas-lms","forks_url":"https://api.github.com/repos/instructure/canvas-lms/forks","keys_url":"https://api.github.com/repos/instructure/canvas-lms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/instructure/canvas-lms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/instructure/canvas-lms/teams","hooks_url":"https://api.github.com/repos/instructure/canvas-lms/hooks","issue_events_url":"https://api.github.com/repos/instructure/canvas-lms/issues/events{/number}","events_url":"https://api.github.com/repos/instructure/canvas-lms/events","assignees_url":"https://api.github.com/repos/instructure/canvas-lms/assignees{/user}","branches_url":"https://api.github.com/repos/instructure/canvas-lms/branches{/branch}","tags_url":"https://api.github.com/repos/instructure/canvas-lms/tags","blobs_url":"https://api.github.com/repos/instructure/canvas-lms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/instructure/canvas-lms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/instructure/canvas-lms/git/refs{/sha}","trees_url":"https://api.github.com/repos/instructure/canvas-lms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/instructure/canvas-lms/statuses/{sha}","languages_url":"https://api.github.com/repos/instructure/canvas-lms/languages","stargazers_url":"https://api.github.com/repos/instructure/canvas-lms/stargazers","contributors_url":"https://api.github.com/repos/instructure/canvas-lms/contributors","subscribers_url":"https://api.github.com/repos/instructure/canvas-lms/subscribers","subscription_url":"https://api.github.com/repos/instructure/canvas-lms/subscription","commits_url":"https://api.github.com/repos/instructure/canvas-lms/commits{/sha}","git_commits_url":"https://api.github.com/repos/instructure/canvas-lms/git/commits{/sha}","comments_url":"https://api.github.com/repos/instructure/canvas-lms/comments{/number}","issue_comment_url":"https://api.github.com/repos/instructure/canvas-lms/issues/comments{/number}","contents_url":"https://api.github.com/repos/instructure/canvas-lms/contents/{+path}","compare_url":"https://api.github.com/repos/instructure/canvas-lms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/instructure/canvas-lms/merges","archive_url":"https://api.github.com/repos/instructure/canvas-lms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/instructure/canvas-lms/downloads","issues_url":"https://api.github.com/repos/instructure/canvas-lms/issues{/number}","pulls_url":"https://api.github.com/repos/instructure/canvas-lms/pulls{/number}","milestones_url":"https://api.github.com/repos/instructure/canvas-lms/milestones{/number}","notifications_url":"https://api.github.com/repos/instructure/canvas-lms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/instructure/canvas-lms/labels{/name}","releases_url":"https://api.github.com/repos/instructure/canvas-lms/releases{/id}","deployments_url":"https://api.github.com/repos/instructure/canvas-lms/deployments","created_at":"2011-02-01T00:08:40Z","updated_at":"2016-10-30T20:41:22Z","pushed_at":"2016-11-01T00:22:27Z","git_url":"git://github.com/instructure/canvas-lms.git","ssh_url":"git@github.com:instructure/canvas-lms.git","clone_url":"https://github.com/instructure/canvas-lms.git","svn_url":"https://github.com/instructure/canvas-lms","homepage":"https://github.com/instructure/canvas-lms/wiki","size":287576,"stargazers_count":1863,"watchers_count":1863,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":812,"mirror_url":null,"open_issues_count":102,"forks":812,"open_issues":102,"watchers":1863,"default_branch":"stable"}},"_links":{"self":{"href":"https://api.github.com/repos/instructure/canvas-lms/pulls/914"},"html":{"href":"https://github.com/instructure/canvas-lms/pull/914"},"issue":{"href":"https://api.github.com/repos/instructure/canvas-lms/issues/914"},"comments":{"href":"https://api.github.com/repos/instructure/canvas-lms/issues/914/comments"},"review_comments":{"href":"https://api.github.com/repos/instructure/canvas-lms/pulls/914/comments"},"review_comment":{"href":"https://api.github.com/repos/instructure/canvas-lms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/instructure/canvas-lms/pulls/914/commits"},"statuses":{"href":"https://api.github.com/repos/instructure/canvas-lms/statuses/4bf207282f37cd2c5e836bffde79debe1f86cf2f"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":5,"review_comments":7,"commits":1,"additions":5,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"eriko"}}