{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaLang/julia/issues/18025","repository_url":"https://api.github.com/repos/JuliaLang/julia","labels_url":"https://api.github.com/repos/JuliaLang/julia/issues/18025/labels{/name}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/18025/comments","events_url":"https://api.github.com/repos/JuliaLang/julia/issues/18025/events","html_url":"https://github.com/JuliaLang/julia/pull/18025","id":171051482,"number":18025,"title":"specialize on type in getindex for types","user":{"login":"KristofferC","id":1282691,"avatar_url":"https://avatars.githubusercontent.com/u/1282691?v=3","gravatar_id":"","url":"https://api.github.com/users/KristofferC","html_url":"https://github.com/KristofferC","followers_url":"https://api.github.com/users/KristofferC/followers","following_url":"https://api.github.com/users/KristofferC/following{/other_user}","gists_url":"https://api.github.com/users/KristofferC/gists{/gist_id}","starred_url":"https://api.github.com/users/KristofferC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KristofferC/subscriptions","organizations_url":"https://api.github.com/users/KristofferC/orgs","repos_url":"https://api.github.com/users/KristofferC/repos","events_url":"https://api.github.com/users/KristofferC/events{/privacy}","received_events_url":"https://api.github.com/users/KristofferC/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/JuliaLang/julia/labels/backport%20pending%200.5","name":"backport pending 0.5","color":"d93f0b"},{"url":"https://api.github.com/repos/JuliaLang/julia/labels/performance","name":"performance","color":"d7e102"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-08-14T09:56:07Z","updated_at":"2016-08-14T17:03:23Z","closed_at":"2016-08-14T16:56:02Z","pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/18025","html_url":"https://github.com/JuliaLang/julia/pull/18025","diff_url":"https://github.com/JuliaLang/julia/pull/18025.diff","patch_url":"https://github.com/JuliaLang/julia/pull/18025.patch"},"body":"Fixes #18021. From 3.65 -> 0.25 seconds in the benchmark code in the linked issue.\r\n\r\nRef #17798 for similar correction\r\n\r\nFix found by eavesdropping on a discussion by @vtjnash and @yuyichao :)"},"comment":{"url":"https://api.github.com/repos/JuliaLang/julia/issues/comments/239684395","html_url":"https://github.com/JuliaLang/julia/pull/18025#issuecomment-239684395","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/18025","id":239684395,"user":{"login":"vtjnash","id":330950,"avatar_url":"https://avatars.githubusercontent.com/u/330950?v=3","gravatar_id":"","url":"https://api.github.com/users/vtjnash","html_url":"https://github.com/vtjnash","followers_url":"https://api.github.com/users/vtjnash/followers","following_url":"https://api.github.com/users/vtjnash/following{/other_user}","gists_url":"https://api.github.com/users/vtjnash/gists{/gist_id}","starred_url":"https://api.github.com/users/vtjnash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vtjnash/subscriptions","organizations_url":"https://api.github.com/users/vtjnash/orgs","repos_url":"https://api.github.com/users/vtjnash/repos","events_url":"https://api.github.com/users/vtjnash/events{/privacy}","received_events_url":"https://api.github.com/users/vtjnash/received_events","type":"User","site_admin":false},"created_at":"2016-08-14T17:03:23Z","updated_at":"2016-08-14T17:03:23Z","body":"> This now seems to be the general 0.5 performance trick. Has the specialization heuristics generally changed since 0.4? As I read it, this method was basically the same in 0.4.\r\n\r\nNo, this fix didn't address what is broken or why, but it just addresses one of the symptoms. The actual problem is that the fast path in `apply_type` hasn't been optimized and is still much too slow."}}
{"actor":{"display_login":"vtjnash"}}